instance_id stringlengths 17 39 | repo stringclasses 8
values | issue_id stringlengths 14 34 | pr_id stringlengths 14 34 | linking_methods listlengths 1 3 | base_commit stringlengths 40 40 | merge_commit stringlengths 0 40 ⌀ | hints_text listlengths 0 106 | resolved_comments listlengths 0 119 | created_at timestamp[ns, tz=UTC] | labeled_as listlengths 0 7 | problem_title stringlengths 7 174 | problem_statement stringlengths 0 55.4k | gold_files listlengths 0 10 | gold_files_postpatch listlengths 1 10 | test_files listlengths 0 60 | gold_patch stringlengths 220 5.83M | test_patch stringlengths 386 194k ⌀ | split_random stringclasses 3
values | split_time stringclasses 3
values | issue_start_time timestamp[ns] | issue_created_at timestamp[ns, tz=UTC] | issue_by_user stringlengths 3 21 | split_repo stringclasses 3
values |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
netty/netty/3945_3948 | netty/netty | netty/netty/3945 | netty/netty/3948 | [
"timestamp(timedelta=11.0, similarity=0.9110794132522602)"
] | a7f83aa23ebe14669119aadb2bbd3012f94fdf64 | 2ca6e201d9d4aac2929e67710d76f28a725214c0 | [
"@blucas makes sense. We love PRs as you know ;)\n",
"+1 to PRs :)\n",
"Let me fix this.\n",
"Fixed by https://github.com/netty/netty/pull/3948\n"
] | [] | 2015-07-07T17:33:17Z | [
"defect"
] | Http2ConnectionHandler breaks channelReadComplete pipeline notification | Netty Version: 5.0.0-Alpha3-SNAPSHOT
Hi guys,
`Http2ConnectionHandler` overrides `channelReadComplete(...)` [here](https://github.com/netty/netty/blob/master/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2ConnectionHandler.java#L421) but fails to pass notification further down the pipeline by calling `su... | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/Http2ConnectionHandler.java"
] | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/Http2ConnectionHandler.java"
] | [] | diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2ConnectionHandler.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2ConnectionHandler.java
index 844cef3c5ba..36073ed1bcc 100644
--- a/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2ConnectionHandler.java
+++ b/codec-... | null | train | train | 2015-07-07T22:50:23 | 2015-07-07T09:15:14Z | blucas | val |
netty/netty/3921_3951 | netty/netty | netty/netty/3921 | netty/netty/3951 | [
"timestamp(timedelta=78683.0, similarity=0.8417185682114167)"
] | 95b7de3a9f2260ac7a5ce41b878fe3c07b9d8200 | 8b7a8986499551052ab61470d990ab004eaa05a9 | [
"I misread the code, I thought it was adding the handlers after registering with the event loop, but it's actually adding the handlers before registering with the event loop, which is clearly not allowed.\n",
"@jroper can you show me the code you use ?\n",
"Sorry, I just noticed... the problem is that my `handl... | [
"Can you do this with real javadocs style ?\n\n``` java\n/**\n * ...\n * ...\n */\n```\n",
"same as above \n",
"also could you open an openjdk issue and link it ?\n",
"@normanmaurer Sure but what does this buy us?\n",
"Add CRLF after `**` \n",
"Add CRLF after `**`\n",
"That you can click the link ;)\n\n... | 2015-07-07T18:51:37Z | [
"defect"
] | EmbeddedChannel constructor throws IllegalStateException | On Netty 4.0.29, when I try to construct an `EmbeddedChannel`, I get an `IllegalStateException`:
```
java.lang.IllegalStateException: channel not registered to an event loop
at io.netty.channel.AbstractChannel.eventLoop(AbstractChannel.java:111)
at io.netty.channel.AbstractChannelHandlerContext.executor(Abstra... | [
"transport/src/main/java/io/netty/channel/nio/AbstractNioChannel.java",
"transport/src/main/java/io/netty/channel/socket/nio/NioSocketChannel.java"
] | [
"transport/src/main/java/io/netty/channel/nio/AbstractNioChannel.java",
"transport/src/main/java/io/netty/channel/socket/nio/NioSocketChannel.java"
] | [] | diff --git a/transport/src/main/java/io/netty/channel/nio/AbstractNioChannel.java b/transport/src/main/java/io/netty/channel/nio/AbstractNioChannel.java
index ba68408c23c..df6232e2a8b 100644
--- a/transport/src/main/java/io/netty/channel/nio/AbstractNioChannel.java
+++ b/transport/src/main/java/io/netty/channel/nio/Abs... | null | train | train | 2015-07-07T10:00:56 | 2015-06-29T08:00:52Z | jroper | val |
netty/netty/3946_3975 | netty/netty | netty/netty/3946 | netty/netty/3975 | [
"timestamp(timedelta=1325.0, similarity=0.8820260019713634)"
] | 3d6819623efc2f634009094ac8cf6a362fd3c2c1 | a38b9761c9c81f51945d70400f99e5ba687b91d1 | [
"/cc @Scottmitch \n\nLooks like `HttpToHttp2ConnectionHandler` currently requires `FullHttpMessage`. I don't recall whether or not there was a reason that it couldn't take `HttpMessage` or `HttpContent`. Contributions are always welcome :) \n",
"I think the main driver was HTTP generally has no proper framing a... | [
"Should probably set `release = false` just before the write.\n",
"Just to aid in readability, can you separate these blocks out into separate methods (e.g. `writeHttpMessage` and `writeHttpContent`)?\n",
"I think we should be able to simplify the logic a bit. Could we do something like this:\n\n``` java\nHttp... | 2015-07-11T11:14:15Z | [] | HttpToHttp2ConnectionHandler does not support converting from Http(Message|Content) to Http2 frames | Is there a reason why `HttpToHttp2ConnectionHandler` does not support converting from `Http(Message|Content)` to Http2 frames? Is there something that the handler requires that it cannot retrieve? Or some data missing from `Http(Message|Content)` that is required?
My use case is that I have an `HttpContentCompressor... | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/HttpToHttp2ConnectionHandler.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/HttpUtil.java"
] | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/HttpToHttp2ConnectionHandler.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/HttpUtil.java"
] | [
"codec-http2/src/test/java/io/netty/handler/codec/http2/HttpToHttp2ConnectionHandlerTest.java"
] | diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/HttpToHttp2ConnectionHandler.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/HttpToHttp2ConnectionHandler.java
index ca3676617d8..6bb45045dcf 100644
--- a/codec-http2/src/main/java/io/netty/handler/codec/http2/HttpToHttp2ConnectionHandler... | diff --git a/codec-http2/src/test/java/io/netty/handler/codec/http2/HttpToHttp2ConnectionHandlerTest.java b/codec-http2/src/test/java/io/netty/handler/codec/http2/HttpToHttp2ConnectionHandlerTest.java
index 04d5f7a7434..9960de21e7d 100644
--- a/codec-http2/src/test/java/io/netty/handler/codec/http2/HttpToHttp2Connectio... | train | train | 2015-07-20T22:47:00 | 2015-07-07T09:29:41Z | blucas | val |
netty/netty/3970_3984 | netty/netty | netty/netty/3970 | netty/netty/3984 | [
"timestamp(timedelta=57.0, similarity=0.8544424543669463)"
] | 3ec02bf7460c3fda4d382bdf4c3b9ef4c67704e1 | 0b938ec911b01027ae1d8b566c933cc343d97d1d | [
"Just do something like this:\n\n``` java\nclass IntObjectHashMap implements Map<Integer, Object> {\n public Object put(Integer key, Object value) {\n put(key.intValue(), value);\n }\n\n public Object put(int key, Object value) {\n // implementation goes here.\n }\n}\n```\n\nThat way one can use this as a... | [
"~~@nmittler those cast's aren't necessary no?~~\n",
"@nmittler I would be in favor of getting rid of `PEntry`. Don't think it's really worth it. WDYT? // @normanmaurer @Scottmitch \n",
"~~@nmittler can we do something like `containsKey(@primitiveType@)` i.e. `containsKey(int key)`?~~\n",
"Yes they are necess... | 2015-07-13T21:57:09Z | [
"improvement"
] | Have (Int,Long,Char,...)ObjectMap implement Map interface. | I just noticed that Netty's primitive hash map implementations don't implement the JDK's `Map` interface. I think they would be much more useful if they did.
| [
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2Connection.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2FrameReader.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2FrameWriter.java",
"codec-http2/src/main/java/io/netty/handler/codec/... | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2Connection.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2FrameReader.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2FrameWriter.java",
"codec-http2/src/main/java/io/netty/handler/codec/... | [
"codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2RemoteFlowControllerTest.java",
"codec-http2/src/test/java/io/netty/handler/codec/http2/Http2SettingsTest.java",
"common/src/test/templates/io.netty.util.collection/KObjectHashMapTest.template"
] | diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2Connection.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2Connection.java
index 71a574f6cc1..c437282f62e 100644
--- a/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2Connection.java
+++ b/codec-... | diff --git a/codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2RemoteFlowControllerTest.java b/codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2RemoteFlowControllerTest.java
index 327c7c820c2..963c43f9e8f 100644
--- a/codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2... | train | train | 2015-07-21T20:17:04 | 2015-07-10T18:20:05Z | buchgr | val |
netty/netty/3967_3991 | netty/netty | netty/netty/3967 | netty/netty/3991 | [
"timestamp(timedelta=17.0, similarity=0.9038943285140661)"
] | 88a2c6ef49b98e11ea8e3afafc3a448b99e3b845 | ddfb91a870c22fa724e1ef8d075ea443335c2af3 | [
"That's strange... let me check\n",
"@mingyu89 thanks for reporting.. I think I know what the problem is and I'm working on a fix.\n",
"@normanmaurer Thank you!\n"
] | [] | 2015-07-15T22:54:08Z | [
"defect"
] | NullPointerException in PendingWriteQueue | Netty Version: 4.0.27.final
Hi. When there're network outages, sometimes on server side we saw handler's exceptionCaught was called with a NullPointerException in PendingWriteQueue.
@trustin Is it a race condition between adding SslHandler and closing channel?
Thanks.
```
java.lang.NullPointerException
at i... | [
"transport/src/main/java/io/netty/channel/PendingWriteQueue.java"
] | [
"transport/src/main/java/io/netty/channel/PendingWriteQueue.java"
] | [
"transport/src/test/java/io/netty/channel/PendingWriteQueueTest.java"
] | diff --git a/transport/src/main/java/io/netty/channel/PendingWriteQueue.java b/transport/src/main/java/io/netty/channel/PendingWriteQueue.java
index b99bef796ed..b0bb0b0f202 100644
--- a/transport/src/main/java/io/netty/channel/PendingWriteQueue.java
+++ b/transport/src/main/java/io/netty/channel/PendingWriteQueue.java... | diff --git a/transport/src/test/java/io/netty/channel/PendingWriteQueueTest.java b/transport/src/test/java/io/netty/channel/PendingWriteQueueTest.java
index db2d1e8d05f..a28fbba4d62 100644
--- a/transport/src/test/java/io/netty/channel/PendingWriteQueueTest.java
+++ b/transport/src/test/java/io/netty/channel/PendingWri... | train | train | 2015-07-12T20:20:28 | 2015-07-09T20:10:41Z | mingyu89 | val |
netty/netty/3997_4003 | netty/netty | netty/netty/3997 | netty/netty/4003 | [
"timestamp(timedelta=32.0, similarity=0.8461993405517902)"
] | 36c80cd81819436cf7b40ae305f7db837aca30d7 | 955fb5ab3f44abe48889b37a196cf7b45b2d4af8 | [
"@justinjhendrick - Thanks for pointing this out. Also feel free to submit a PR and get credit for fixing :)\n",
"@Scottmitch, I would but my company wants to review any open source before we contribute. So, something small like this wouldn't be worth the time necessary for a review.\n",
"No worries I will fix... | [] | 2015-07-19T07:26:38Z | [
"documentation"
] | Documentation: wrong class mentioned in setter | {@link ByteBufAllocator} -> {@link MessageSizeEstimator} on
https://github.com/netty/netty/blob/4.0/transport/src/main/java/io/netty/channel/ChannelConfig.java#L248
this effects 4.0, 4.1, and master branches
| [
"transport/src/main/java/io/netty/channel/ChannelConfig.java"
] | [
"transport/src/main/java/io/netty/channel/ChannelConfig.java"
] | [] | diff --git a/transport/src/main/java/io/netty/channel/ChannelConfig.java b/transport/src/main/java/io/netty/channel/ChannelConfig.java
index b7ec03c45e1..7871285cd0c 100644
--- a/transport/src/main/java/io/netty/channel/ChannelConfig.java
+++ b/transport/src/main/java/io/netty/channel/ChannelConfig.java
@@ -245,7 +245,... | null | val | train | 2015-07-19T16:42:37 | 2015-07-16T23:37:01Z | justinjhendrick | val |
netty/netty/4001_4011 | netty/netty | netty/netty/4001 | netty/netty/4011 | [
"timestamp(timedelta=64.0, similarity=0.8452350038604813)"
] | 9e8b1ea5879c867e0203522cb72bd2bd6c9bfc8f | 04f16eb9e896bd684ad197560c117afa8e7f71cd | [
"@nmittler - FYI :)\n\nhttps://github.com/netty/netty/pull/3984#discussion_r34911766\n"
] | [] | 2015-07-21T15:02:35Z | [] | PrimitiveCollections should apply for all "scripted" types | Currently the PrimitiveCollections class has an implementation of `EmptyMap` and `UnmodifiableMap` only for the `int` variant of the primitive map. These objects should be templatized like the other primitive map types.
| [
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2Connection.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2FrameWriter.java",
"common/src/main/java/io/netty/util/collection/package-info.java",
"common/src/main/java/io/netty/util/collection/PrimitiveCollections.ja... | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2Connection.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2FrameWriter.java",
"common/src/main/templates/io/netty/util/collection/KCollections.template"
] | [] | diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2Connection.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2Connection.java
index c437282f62e..51b38c8b7eb 100644
--- a/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2Connection.java
+++ b/codec-... | null | val | train | 2015-07-23T00:52:01 | 2015-07-17T19:59:26Z | Scottmitch | val |
netty/netty/3988_4016 | netty/netty | netty/netty/3988 | netty/netty/4016 | [
"timestamp(timedelta=4790.0, similarity=0.8761306193745646)"
] | 5c7022d49449389f22d3387d6323b55870e28512 | 4a7c46488365c45066d5085e2b1c5ca14d535b7f | [
"@fratboy - Thanks for reporting!\n\n@normanmaurer - Assigned to you for now.\n",
"@fratboy thanks... fix in the works.\n",
"@normanmaurer My pleasure.\n",
"@fratboy could you verify https://github.com/netty/netty/pull/4016 ?\n",
"@normanmaurer It's exactly same with my patch in my project. It works perfect... | [] | 2015-07-21T16:48:02Z | [
"defect"
] | FixedChannelPool does not count acquired channels precisely | Netty version: 4.0.10.Beta5
Context:
When queued `AcquireTask` fails, `decrementAndRunTaskQueue()` method could throw assertion error.
Steps to reproduct:
1. Call `FixedChannelPool.acquire` enough to make some `AcquireTask`s be queued.
2. Close server channel abrubtly to make `AcquireTask` fail.
3. AssertionError can... | [
"transport/src/main/java/io/netty/channel/pool/FixedChannelPool.java"
] | [
"transport/src/main/java/io/netty/channel/pool/FixedChannelPool.java"
] | [] | diff --git a/transport/src/main/java/io/netty/channel/pool/FixedChannelPool.java b/transport/src/main/java/io/netty/channel/pool/FixedChannelPool.java
index 5c08ac6260a..f23c5404eb0 100644
--- a/transport/src/main/java/io/netty/channel/pool/FixedChannelPool.java
+++ b/transport/src/main/java/io/netty/channel/pool/Fixed... | null | train | train | 2015-07-21T18:37:55 | 2015-07-15T18:34:54Z | alexpark7712 | val |
netty/netty/4023_4029 | netty/netty | netty/netty/4023 | netty/netty/4029 | [
"timestamp(timedelta=1035.0, similarity=0.889983997942325)"
] | 348082c433e57d8faf53c8320e2c5fb01c53d69a | bcc6a40414b35703ba9da2a9b2226afee0bfb8ee | [
"Please review pull request: https://github.com/netty/netty/pull/4027\n",
"Will do tomorrow!\n\n> Am 26.07.2015 um 20:30 schrieb ioanbsu notifications@github.com:\n> \n> Please review pull request: #4027\n> \n> —\n> Reply to this email directly or view it on GitHub.\n",
"Applied all the changes to satisfy #4027... | [
"channelWasNotAcuired -> channelWasNotAcquired (typo)\n",
"final\n",
"Shouldn't we call also \"channelClosePromise.setFailure(...)\" if not success full ?\n",
"You can use FutureListener\n",
"You can use FutureListener\n",
"Don't we have to execute this with `FixedChannelPool.executor` ?\n",
"Hm. should... | 2015-07-27T18:26:30Z | [
"defect"
] | FixedChannelPool does not properly counts the acquiredChannelCount | Steps to reproduce:
1) create FixedChannelPool with maxConnections=1
``` java
FixedChannelPool(bootstrap.remoteAddress(key.host(), key.port()),
new AbstractChannelPoolHandler() {... },1);
```
2) Request channel from FixedChannelPool
3) Make request through channel and once done release it
4) Kill the connection whil... | [
"transport/src/main/java/io/netty/channel/pool/FixedChannelPool.java",
"transport/src/main/java/io/netty/channel/pool/SimpleChannelPool.java"
] | [
"transport/src/main/java/io/netty/channel/pool/FixedChannelPool.java",
"transport/src/main/java/io/netty/channel/pool/SimpleChannelPool.java"
] | [] | diff --git a/transport/src/main/java/io/netty/channel/pool/FixedChannelPool.java b/transport/src/main/java/io/netty/channel/pool/FixedChannelPool.java
index f23c5404eb0..b4f7f17037b 100644
--- a/transport/src/main/java/io/netty/channel/pool/FixedChannelPool.java
+++ b/transport/src/main/java/io/netty/channel/pool/Fixed... | null | train | train | 2015-07-27T15:58:50 | 2015-07-25T19:56:13Z | ioanbsu | val |
netty/netty/4031_4033 | netty/netty | netty/netty/4031 | netty/netty/4033 | [
"timestamp(timedelta=14.0, similarity=0.8902631432145431)"
] | 0f4d6c386efd4dfcae1082d6c095fe46bb9855fe | 5ae3392546b9820ddf5d10408f0004c0dd80bef0 | [] | [
"I think the old name was a better fit.\n",
"I got it, thanks.\n",
"change this to `assert acquiredChannelCount >= 0`\n"
] | 2015-07-28T16:45:06Z | [] | FixedChannelPool doesn't decrease acquiredChannelCount when timeout occurs | Netty version: 4.0.10.Beta5
Context:
When we use `FixedChannelPool` with `AcquireTimeoutAction.NEW`, if timeout occurs, `acquiredChannelCount` increases forever.
Steps to reproduce:
1. Create `FixedChannelPool` with `AcquireTimeoutAction.NEW`
2. Shutdown client network to simulate timeout
3. `acquiredChannelCount` in... | [
"transport/src/main/java/io/netty/channel/pool/FixedChannelPool.java"
] | [
"transport/src/main/java/io/netty/channel/pool/FixedChannelPool.java"
] | [] | diff --git a/transport/src/main/java/io/netty/channel/pool/FixedChannelPool.java b/transport/src/main/java/io/netty/channel/pool/FixedChannelPool.java
index f23c5404eb0..bd89bd64612 100644
--- a/transport/src/main/java/io/netty/channel/pool/FixedChannelPool.java
+++ b/transport/src/main/java/io/netty/channel/pool/Fixed... | null | test | train | 2015-07-29T18:37:42 | 2015-07-28T16:13:20Z | alexpark7712 | val |
netty/netty/4022_4034 | netty/netty | netty/netty/4022 | netty/netty/4034 | [
"timestamp(timedelta=14.0, similarity=0.8524517148954559)"
] | 148692705cf26a446263569e517566f635d6132b | b7b63391d669a6d41d2e80b8bc3741c5776c6688 | [
"@burtonator - Thanks for reaching out! Sounds like a useful feature. I'll put this on the todo list but if you get around to it before we do please feel free to submit a PR.\n",
"Thanks will check once i have free cycles\n\n> Am 25.07.2015 um 00:20 schrieb Kevin Burton notifications@github.com:\n> \n> It would b... | [] | 2015-07-28T19:39:39Z | [
"feature"
] | Implement IP_FREEBIND and Any-IP in native JNI base epoll | It would be really nice to have netty support IP_FREEBIND and Any-IP.
Essentially it allows you to bind() to any IP address, even if it's not associated with an Interface.
I was thinking this could be really helpful in ipv6 setups whereby you just setup your webserver on a subnet with 16k IPs and then when you want t... | [
"transport-native-epoll/src/main/c/io_netty_channel_epoll_Native.c",
"transport-native-epoll/src/main/c/io_netty_channel_epoll_Native.h",
"transport-native-epoll/src/main/java/io/netty/channel/epoll/EpollChannelOption.java",
"transport-native-epoll/src/main/java/io/netty/channel/epoll/EpollServerSocketChannel... | [
"transport-native-epoll/src/main/c/io_netty_channel_epoll_Native.c",
"transport-native-epoll/src/main/c/io_netty_channel_epoll_Native.h",
"transport-native-epoll/src/main/java/io/netty/channel/epoll/EpollChannelOption.java",
"transport-native-epoll/src/main/java/io/netty/channel/epoll/EpollServerSocketChannel... | [] | diff --git a/transport-native-epoll/src/main/c/io_netty_channel_epoll_Native.c b/transport-native-epoll/src/main/c/io_netty_channel_epoll_Native.c
index a277d1695a5..480bf50a1c7 100644
--- a/transport-native-epoll/src/main/c/io_netty_channel_epoll_Native.c
+++ b/transport-native-epoll/src/main/c/io_netty_channel_epoll_... | null | train | train | 2015-07-24T10:11:44 | 2015-07-24T22:20:29Z | burtonator | val |
netty/netty/4041_4042 | netty/netty | netty/netty/4041 | netty/netty/4042 | [
"timestamp(timedelta=78.0, similarity=0.9239012526455588)"
] | 94f65ed7ff214de3fc9680d80a5ec2d2fe2aaf48 | fd6091eda5783f9685bd5a850b349a86beb90576 | [
"We love contributions. Maybe care to submit a PR?\n\n> Am 29.07.2015 um 11:23 schrieb Jorge Castellanos Solaz notifications@github.com:\n> \n> Netty version: 4.1.0.Beta5\n> \n> Context:\n> I'm implementing an MQTT broker based on netty using the classes from the package io.netty.handler.codec.mqtt, in the version ... | [] | 2015-07-29T12:02:29Z | [
"improvement"
] | Add support for "session present" flag in io.netty.handler.codec.mqtt.MqttConnAckVariableHeader | Netty version: 4.1.0.Beta5
Context:
I'm implementing an MQTT broker based on netty using the classes from the package io.netty.handler.codec.mqtt, in the version 3.1.1 of the MQTT protocol it has been added a new flag in the variable header of the CONNACK message called "session present": http://docs.oasis-open.org/mq... | [
"codec-mqtt/src/main/java/io/netty/handler/codec/mqtt/MqttConnAckVariableHeader.java",
"codec-mqtt/src/main/java/io/netty/handler/codec/mqtt/MqttDecoder.java",
"codec-mqtt/src/main/java/io/netty/handler/codec/mqtt/MqttEncoder.java"
] | [
"codec-mqtt/src/main/java/io/netty/handler/codec/mqtt/MqttConnAckVariableHeader.java",
"codec-mqtt/src/main/java/io/netty/handler/codec/mqtt/MqttDecoder.java",
"codec-mqtt/src/main/java/io/netty/handler/codec/mqtt/MqttEncoder.java"
] | [
"codec-mqtt/src/test/java/io/netty/handler/codec/mqtt/MqttCodecTest.java"
] | diff --git a/codec-mqtt/src/main/java/io/netty/handler/codec/mqtt/MqttConnAckVariableHeader.java b/codec-mqtt/src/main/java/io/netty/handler/codec/mqtt/MqttConnAckVariableHeader.java
index 7dfa3094837..a1b73303d1d 100644
--- a/codec-mqtt/src/main/java/io/netty/handler/codec/mqtt/MqttConnAckVariableHeader.java
+++ b/cod... | diff --git a/codec-mqtt/src/test/java/io/netty/handler/codec/mqtt/MqttCodecTest.java b/codec-mqtt/src/test/java/io/netty/handler/codec/mqtt/MqttCodecTest.java
index f16602a64e6..705d071bfd8 100644
--- a/codec-mqtt/src/test/java/io/netty/handler/codec/mqtt/MqttCodecTest.java
+++ b/codec-mqtt/src/test/java/io/netty/handl... | train | train | 2015-07-28T18:54:14 | 2015-07-29T09:23:08Z | jorcasso | val |
netty/netty/4030_4043 | netty/netty | netty/netty/4030 | netty/netty/4043 | [
"timestamp(timedelta=1386.0, similarity=0.9335526844307486)"
] | 94f65ed7ff214de3fc9680d80a5ec2d2fe2aaf48 | c9eff2faa93f72ccf4199b05ddee674753ba2c64 | [
"Can you also test with 4.1.0.Beta6-SNAPSHOT just to be sure it is not fixed already ?\n",
"I've just checked newest commit on branch 4.1 (94f65ed7ff214de3fc9680d80a5ec2d2fe2aaf48) and the problem still exists. \n\nThe problem is in line 115, below comment _'found </, decrementing openBracketsCount'_. IMHO additi... | [] | 2015-07-29T12:24:23Z | [
"defect"
] | XmlFrameDecoder is corrupt | Netty Version: 4.1.0.Beta4
Context:
When writing TCP client which exchanges XML messages with server I've encountered an error in XmlFrameDecoder. Given not full XML element, decoder will output not valid XML.
Steps to reproduce:
1. BUG - Decode invalid XML: `'<a><b/></'` - decoder will put it to output list and it w... | [
"codec/src/main/java/io/netty/handler/codec/xml/XmlFrameDecoder.java"
] | [
"codec/src/main/java/io/netty/handler/codec/xml/XmlFrameDecoder.java"
] | [
"codec/src/test/java/io/netty/handler/codec/xml/XmlFrameDecoderTest.java"
] | diff --git a/codec/src/main/java/io/netty/handler/codec/xml/XmlFrameDecoder.java b/codec/src/main/java/io/netty/handler/codec/xml/XmlFrameDecoder.java
index c4f70974350..4a8b262bf8a 100644
--- a/codec/src/main/java/io/netty/handler/codec/xml/XmlFrameDecoder.java
+++ b/codec/src/main/java/io/netty/handler/codec/xml/XmlF... | diff --git a/codec/src/test/java/io/netty/handler/codec/xml/XmlFrameDecoderTest.java b/codec/src/test/java/io/netty/handler/codec/xml/XmlFrameDecoderTest.java
index 62f6719fd7b..db3660accf8 100644
--- a/codec/src/test/java/io/netty/handler/codec/xml/XmlFrameDecoderTest.java
+++ b/codec/src/test/java/io/netty/handler/co... | train | train | 2015-07-28T18:54:14 | 2015-07-28T13:03:48Z | tomaszc | val |
netty/netty/3886_4045 | netty/netty | netty/netty/3886 | netty/netty/4045 | [
"timestamp(timedelta=32.0, similarity=0.9286218771515881)"
] | 595fb888398b3565c84c675e21f2aec8b8f0d0f9 | a91266c674029b5b0328dd53d40cead35f966ad6 | [
"Problematic jar example: https://search.maven.org/remotecontent?filepath=io/netty/netty-transport/5.0.0.Alpha2/netty-transport-5.0.0.Alpha2-sources.jar\n",
"@FeiWongReed We love contributions. Maybe submit a PR ?\n",
"Ok, will try.\n",
"It's easy to fix this, but it was not accidentally mistake. Look at #205... | [] | 2015-07-29T14:56:51Z | [
"defect"
] | OSGi manifests in javadocs/sources jars | This problem affected many people more than year ago, but it's still here: https://stackoverflow.com/questions/23149966/classnotfoundexception-for-a-type-that-is-available-to-the-osgi-runtime-io-net
You are including OSGi manifests in sources/javadocs jars, so osgi container treats them as correct dependencies when re... | [
"pom.xml"
] | [
"pom.xml"
] | [] | diff --git a/pom.xml b/pom.xml
index f7ed52d1e1e..fd0e0e48ae8 100644
--- a/pom.xml
+++ b/pom.xml
@@ -1148,16 +1148,41 @@
</execution>
</executions>
</plugin>
+
+ <plugin>
+ <groupId>org.codehaus.mojo</groupId>
+ <artifactId>build-helper-maven-plugin</artifactId>
+ <v... | null | test | train | 2015-07-28T18:53:36 | 2015-06-14T11:58:15Z | pshirshov | val |
netty/netty/4071_4072 | netty/netty | netty/netty/4071 | netty/netty/4072 | [
"timestamp(timedelta=54.0, similarity=1.0000000000000002)"
] | fd5db7fa08d6392fdae23056481da39705da30aa | d9c455e1ca557fc41c96331cbd684df8adfe8633 | [] | [] | 2015-08-08T05:57:20Z | [] | MemoryRegionCache$Entry objects are not recycled | Netty Version: 4.0.30.Final
MemoryRegionCache$Entry instances are allocated from a Recycler but not recycled when done using them, leading to a lot of GCed objects.
| [
"buffer/src/main/java/io/netty/buffer/PoolThreadCache.java"
] | [
"buffer/src/main/java/io/netty/buffer/PoolThreadCache.java"
] | [] | diff --git a/buffer/src/main/java/io/netty/buffer/PoolThreadCache.java b/buffer/src/main/java/io/netty/buffer/PoolThreadCache.java
index 3792c3e65ae..425f657ca96 100644
--- a/buffer/src/main/java/io/netty/buffer/PoolThreadCache.java
+++ b/buffer/src/main/java/io/netty/buffer/PoolThreadCache.java
@@ -386,7 +386,14 @@ pr... | null | train | train | 2015-08-05T18:14:38 | 2015-08-08T05:54:58Z | merlimat | val |
netty/netty/4077_4078 | netty/netty | netty/netty/4077 | netty/netty/4078 | [
"timestamp(timedelta=37.0, similarity=0.8739797762840745)"
] | 2a7318ae0301d2541fd4da9f107731f15440e445 | 3151670b54cf0b98dbe3a953dab478b2ad2b550f | [
"@normanmaurer - I recall discussing this when we originally reviewed the pool. I think your rational was since we have to check the health anyways when we pull out of the pool, and the health check may be expensive (may include RTT), we wanted to minimize the number of health checks done. WDYT?\n",
"@Scottmitch... | [
"As discussed in https://github.com/netty/netty/issues/4077#issuecomment-130461684. Perhaps we should make this check configurable (some boolean flag to indicate we should check health when putting back into pool).\n",
"@Scottmitch sure, will do. What do you think the default behavior should be? Check health on r... | 2015-08-12T17:23:13Z | [
"feature"
] | SimpleChannelPool/FixedChannelPool: Don't put unhealthy channel back to the pool on release | Currently it is _required_ to release channel to the channel pool for `FixedChannelPool`.
Failure to release a channel may cause that `FixedChannelPool.acquiredChannelCount` becomes equal or bigger then `FixedChannelPool.maxConnections`. So basically it means that we have to release back all the channels even those on... | [
"transport/src/main/java/io/netty/channel/pool/FixedChannelPool.java",
"transport/src/main/java/io/netty/channel/pool/SimpleChannelPool.java"
] | [
"transport/src/main/java/io/netty/channel/pool/FixedChannelPool.java",
"transport/src/main/java/io/netty/channel/pool/SimpleChannelPool.java"
] | [
"transport/src/test/java/io/netty/channel/pool/SimpleChannelPoolTest.java"
] | diff --git a/transport/src/main/java/io/netty/channel/pool/FixedChannelPool.java b/transport/src/main/java/io/netty/channel/pool/FixedChannelPool.java
index bd89bd64612..1f57b7d640d 100644
--- a/transport/src/main/java/io/netty/channel/pool/FixedChannelPool.java
+++ b/transport/src/main/java/io/netty/channel/pool/Fixed... | diff --git a/transport/src/test/java/io/netty/channel/pool/SimpleChannelPoolTest.java b/transport/src/test/java/io/netty/channel/pool/SimpleChannelPoolTest.java
index 20d024ddd88..20ca46b7837 100644
--- a/transport/src/test/java/io/netty/channel/pool/SimpleChannelPoolTest.java
+++ b/transport/src/test/java/io/netty/cha... | train | train | 2015-08-17T19:12:10 | 2015-08-12T05:47:57Z | ioanbsu | val |
netty/netty/4085_4092 | netty/netty | netty/netty/4085 | netty/netty/4092 | [
"timestamp(timedelta=29.0, similarity=0.8904482250405097)"
] | f1a4454bf13487755395f30b3dcab16ab47b0bc6 | c0dd184ecdeac3689b4edbb78cfe9d92a7698fcb | [
"@yawkat can you tell me what you mean with \"abstract domain socket\" ?\n",
"See [this man page](http://man7.org/linux/man-pages/man7/unix.7.html). Basically, domain socket names allow `\\0` bytes in them, and on linux, a domain socket starting with `\\0` does not appear in the file system and is called abstract... | [
"Use : getBytes(CharsetUtil.UTF8)\n",
"Use : getBytes(CharsetUtil.UTF8)\n"
] | 2015-08-15T21:45:09Z | [
"feature"
] | Support abstract domain sockets using epoll on linux | Version: 5.0.0.Alpha2
Context:
I am trying to write a client for dbus on linux and need to support abstract domain sockets to properly connect to the native dbus servers.
It is currently not possible to create an abstract domain socket using the epoll selector. While creating normal domain sockets works fine, an atte... | [
"transport-native-epoll/src/main/c/io_netty_channel_epoll_Native.c",
"transport-native-epoll/src/main/java/io/netty/channel/epoll/Native.java"
] | [
"transport-native-epoll/src/main/c/io_netty_channel_epoll_Native.c",
"transport-native-epoll/src/main/java/io/netty/channel/epoll/Native.java"
] | [
"transport-native-epoll/src/test/java/io/netty/channel/epoll/EpollAbstractDomainSocketEchoTest.java"
] | diff --git a/transport-native-epoll/src/main/c/io_netty_channel_epoll_Native.c b/transport-native-epoll/src/main/c/io_netty_channel_epoll_Native.c
index 480bf50a1c7..4dc579ee9ef 100644
--- a/transport-native-epoll/src/main/c/io_netty_channel_epoll_Native.c
+++ b/transport-native-epoll/src/main/c/io_netty_channel_epoll_... | diff --git a/transport-native-epoll/src/test/java/io/netty/channel/epoll/EpollAbstractDomainSocketEchoTest.java b/transport-native-epoll/src/test/java/io/netty/channel/epoll/EpollAbstractDomainSocketEchoTest.java
new file mode 100644
index 00000000000..ea0deb94a65
--- /dev/null
+++ b/transport-native-epoll/src/test/jav... | val | train | 2015-08-15T02:07:47 | 2015-08-12T22:09:14Z | yawkat | val |
netty/netty/4091_4102 | netty/netty | netty/netty/4091 | netty/netty/4102 | [
"timestamp(timedelta=9.0, similarity=0.8442024319863696)"
] | ad0b7ca56db391248c95ff2c0e24793cc3a4d9d5 | 380eee5e769abf607c40caaf6d6ba20f6247d6c7 | [
"@rkapsi thx will check\n",
"@normanmaurer - I got this one.\n",
"Interesting, if I run that test from the CLI it's eventually starting to spew these ones...\n\n```\njava.nio.channels.ClosedChannelException\n java.nio.channels.ClosedChannelException\n java.nio.channels.ClosedChannelException\n java.io.... | [] | 2015-08-19T20:03:22Z | [
"defect"
] | Epoll HttpServer ClosedChannelException death spiral | There appears to be something like a ClosedChannelException death spiral in conjunction with chunked HTTP POSTs and Epoll.
It starts if there is a ChannelHandler that throws an Exception and an another ChannelHandler that catches it and attempts to close the Channel. The server will then spin for a bit throwing Closed... | [
"transport-native-epoll/src/main/java/io/netty/channel/epoll/AbstractEpollChannel.java",
"transport-native-epoll/src/main/java/io/netty/channel/epoll/AbstractEpollServerChannel.java",
"transport-native-epoll/src/main/java/io/netty/channel/epoll/AbstractEpollStreamChannel.java",
"transport-native-epoll/src/mai... | [
"transport-native-epoll/src/main/java/io/netty/channel/epoll/AbstractEpollChannel.java",
"transport-native-epoll/src/main/java/io/netty/channel/epoll/AbstractEpollServerChannel.java",
"transport-native-epoll/src/main/java/io/netty/channel/epoll/AbstractEpollStreamChannel.java",
"transport-native-epoll/src/mai... | [
"transport-native-epoll/src/test/java/io/netty/channel/epoll/EpollSocketChannelTest.java"
] | diff --git a/transport-native-epoll/src/main/java/io/netty/channel/epoll/AbstractEpollChannel.java b/transport-native-epoll/src/main/java/io/netty/channel/epoll/AbstractEpollChannel.java
index d3faad8d2a1..491e79dcaf8 100644
--- a/transport-native-epoll/src/main/java/io/netty/channel/epoll/AbstractEpollChannel.java
+++... | diff --git a/transport-native-epoll/src/test/java/io/netty/channel/epoll/EpollSocketChannelTest.java b/transport-native-epoll/src/test/java/io/netty/channel/epoll/EpollSocketChannelTest.java
index 9637006217e..c13ac8f7ee6 100644
--- a/transport-native-epoll/src/test/java/io/netty/channel/epoll/EpollSocketChannelTest.ja... | train | train | 2015-08-18T11:44:51 | 2015-08-14T20:11:34Z | rkapsi | val |
netty/netty/4020_4119 | netty/netty | netty/netty/4020 | netty/netty/4119 | [
"timestamp(timedelta=126215.0, similarity=0.8547458327797111)"
] | bd5091a14f6b10837900a0f80dcbad4144a557f3 | a3cdff520d15c6dc40d08d1f0ac45aa396cefc7d | [
"The only solution to this bug would be to dispose the ChannelGroup, so once a CG is closed, it remains closed and every new add()-invocation results in closing the channel.\n\nThe only other solution is to synchronize on the CG which would be bad.\n\nEDIT: Is there nobody who can verify if I'm right or wrong ?\n",... | [] | 2015-08-21T13:59:46Z | [
"defect"
] | ChannelGroup has race-condition | Hi,
the ChannelGroup doc says:
``` java
* If both {@link ServerChannel}s and non-{@link ServerChannel}s exist in the
* same {@link ChannelGroup}, any requested I/O operations on the group are
* performed for the {@link ServerChannel}s first and then for the others.
* <p>
* This rule is very useful when you shut ... | [
"transport/src/main/java/io/netty/channel/group/DefaultChannelGroup.java"
] | [
"transport/src/main/java/io/netty/channel/group/DefaultChannelGroup.java"
] | [] | diff --git a/transport/src/main/java/io/netty/channel/group/DefaultChannelGroup.java b/transport/src/main/java/io/netty/channel/group/DefaultChannelGroup.java
index 34029f7a3f9..a16938c7679 100644
--- a/transport/src/main/java/io/netty/channel/group/DefaultChannelGroup.java
+++ b/transport/src/main/java/io/netty/channe... | null | train | train | 2015-08-21T09:37:24 | 2015-07-24T08:56:07Z | chrisprobst | val |
netty/netty/4131_4140 | netty/netty | netty/netty/4131 | netty/netty/4140 | [
"timestamp(timedelta=11.0, similarity=0.8811317741985843)"
] | fb0fe111ac0dad760e3091a893bc4d5e452835af | bd50d92cf3707a18f22aa5f0182627620012504e | [
"@rkapsi - Is `PlatformDependent.throwException(null)` called from Netty code, and if so do you know where from?\n",
"@Scottmitch no, not from Netty code. It was some code I wrote and one can argue it was my own fault (given the nature of that class) but I wish it'd have failed more gracefully.\n",
"@rkapsi - H... | [
"Maybe renaming t to cause might make the exception message more sense?\n",
"Will do.\n"
] | 2015-08-26T21:51:48Z | [
"defect"
] | PlatformDependent.throwException() with null argument takes down the JVM | I'm not sure if it's a bug or feature but it's certainly not easy to debug.
Netty 4.1.0-Beta6-SNAPSHOT
```
#
# A fatal error has been detected by the Java Runtime Environment:
#
# SIGSEGV (0xb) at pc=0x00007f80fbe956c9, pid=1196, tid=140191066928896
#
# JRE version: Java(TM) SE Runtime Environment (8.0_40-b25) (buil... | [
"common/src/main/java/io/netty/util/internal/PlatformDependent0.java"
] | [
"common/src/main/java/io/netty/util/internal/PlatformDependent0.java"
] | [] | diff --git a/common/src/main/java/io/netty/util/internal/PlatformDependent0.java b/common/src/main/java/io/netty/util/internal/PlatformDependent0.java
index e72627a18d3..ef9e3b09186 100644
--- a/common/src/main/java/io/netty/util/internal/PlatformDependent0.java
+++ b/common/src/main/java/io/netty/util/internal/Platfor... | null | train | train | 2015-08-27T08:27:44 | 2015-08-24T20:50:18Z | rkapsi | val |
netty/netty/3884_4142 | netty/netty | netty/netty/3884 | netty/netty/4142 | [
"timestamp(timedelta=8.0, similarity=0.9799484004742384)"
] | 33001e84ff6eefbe7f1d67a6f18efe76721b5cab | 824cf42734077b8267c17d354fea3a5bfaf52bea | [
"@benevans @trustin - Any thoughts?\n",
"/cc @jestan \n",
"@jestan - Any objections to me removing this code?\n",
"@Scottmitch Please go ahead. We can't wait forever.\n",
"@trustin - Will do :)\n"
] | [] | 2015-08-26T21:59:38Z | [
"defect"
] | OioSctpChannel read iterating over selected keys | I'm curious why the [OioSctpChannel](https://github.com/netty/netty/blob/4.1/transport-sctp/src/main/java/io/netty/channel/sctp/oio/OioSctpChannel.java#L187) is iterating over `readSelector.selectedKeys()` but not using the `SelectionKey`. It seems like the assumption is the number of keys that are active is an indica... | [
"transport-sctp/src/main/java/io/netty/channel/sctp/oio/OioSctpChannel.java"
] | [
"transport-sctp/src/main/java/io/netty/channel/sctp/oio/OioSctpChannel.java"
] | [] | diff --git a/transport-sctp/src/main/java/io/netty/channel/sctp/oio/OioSctpChannel.java b/transport-sctp/src/main/java/io/netty/channel/sctp/oio/OioSctpChannel.java
index 6416ea4e60e..01a79d65ad5 100755
--- a/transport-sctp/src/main/java/io/netty/channel/sctp/oio/OioSctpChannel.java
+++ b/transport-sctp/src/main/java/i... | null | train | train | 2015-08-26T22:23:42 | 2015-06-12T19:32:35Z | Scottmitch | val |
netty/netty/4147_4157 | netty/netty | netty/netty/4147 | netty/netty/4157 | [
"timestamp(timedelta=19.0, similarity=0.9035731286287193)"
] | 1ba087bc86a68c2013361bc2fcfdebe1ad9b290f | 1a2c020c2ced837be1e41021da4879f0029832a6 | [
"@trustin should I take care?\n\n> Am 27.08.2015 um 05:11 schrieb Trustin Lee notifications@github.com:\n> \n> It seems like some users are observing an edge case where the WeakOrderQueue and Stack grow beyond its max capacity. Although we should fix it, there should be a way for a user to disable recycling complet... | [
"Should we stick to this default value? /cc @normanmaurer @tea-dragon \n",
"@trustin for now yes. Let us use a new pr if we want to adjust it\n"
] | 2015-08-28T05:37:50Z | [
"feature"
] | Provide a way to disable recycling completely | It seems like some users are observing an edge case where the `WeakOrderQueue` and `Stack` grow beyond its max capacity. Although we should fix it, there should be a way for a user to disable recycling completely so that he or she can perform with-recycler vs. without-recycler comparison.
/cc @ninja-
| [
"common/src/main/java/io/netty/util/Recycler.java"
] | [
"common/src/main/java/io/netty/util/Recycler.java"
] | [
"common/src/test/java/io/netty/util/RecyclerTest.java"
] | diff --git a/common/src/main/java/io/netty/util/Recycler.java b/common/src/main/java/io/netty/util/Recycler.java
index edc7672c7c6..1e0bc39e260 100644
--- a/common/src/main/java/io/netty/util/Recycler.java
+++ b/common/src/main/java/io/netty/util/Recycler.java
@@ -36,8 +36,11 @@ public abstract class Recycler<T> {
... | diff --git a/common/src/test/java/io/netty/util/RecyclerTest.java b/common/src/test/java/io/netty/util/RecyclerTest.java
index e90957034c6..cae4cc2e34e 100644
--- a/common/src/test/java/io/netty/util/RecyclerTest.java
+++ b/common/src/test/java/io/netty/util/RecyclerTest.java
@@ -40,6 +40,15 @@ public void testRecycle(... | train | train | 2015-08-28T14:54:00 | 2015-08-27T03:11:27Z | trustin | val |
netty/netty/4118_4163 | netty/netty | netty/netty/4118 | netty/netty/4163 | [
"timestamp(timedelta=7884.0, similarity=0.8773752337812172)"
] | 544ee95e582e493ff3c4d484284e82615f0462df | f6f0674ec2ff1caabd573a6cd6fd55ef9b256e19 | [] | [
"+1\n",
"would we need to check if the peer.finishReadFuture == peerReadFuture and only set to null in this case ? A.k.a an atomic operation.\n",
"Good catch!\n",
"Please try to use `PlatformDependent.newAtomicReferenceFieldUpdater` first in a static block like we do in other places like:\n\nhttps://github.c... | 2015-08-28T16:47:08Z | [
"defect"
] | LocalChannel sequencing issue leading to HTTP/2 unit test failure | There is a sequencing issue in LocalChannel that is resulting in a unit test failure as picked up on the CI server [Http2ConnectionRoundtripTest.noMoreStreamIdsShouldSendGoAway](https://garage.netty.io/teamcity/viewLog.html?buildId=593&tab=buildResultsDiv&buildTypeId=netty_build_oraclejdk7).
I have a PR pending approv... | [
"transport/src/main/java/io/netty/channel/local/LocalChannel.java"
] | [
"transport/src/main/java/io/netty/channel/local/LocalChannel.java"
] | [
"transport/src/test/java/io/netty/channel/local/LocalChannelTest.java"
] | diff --git a/transport/src/main/java/io/netty/channel/local/LocalChannel.java b/transport/src/main/java/io/netty/channel/local/LocalChannel.java
index 96e0acbfac9..59fc04480fa 100644
--- a/transport/src/main/java/io/netty/channel/local/LocalChannel.java
+++ b/transport/src/main/java/io/netty/channel/local/LocalChannel.... | diff --git a/transport/src/test/java/io/netty/channel/local/LocalChannelTest.java b/transport/src/test/java/io/netty/channel/local/LocalChannelTest.java
index 671b78d8459..cdbad06a658 100644
--- a/transport/src/test/java/io/netty/channel/local/LocalChannelTest.java
+++ b/transport/src/test/java/io/netty/channel/local/L... | train | train | 2015-08-28T18:24:09 | 2015-08-21T02:30:02Z | Scottmitch | val |
netty/netty/2677_4166 | netty/netty | netty/netty/2677 | netty/netty/4166 | [
"timestamp(timedelta=52.0, similarity=0.8607263387581197)"
] | 7d083ef6d662d043bac7f664283ee3b94e0bfab3 | 6b51bdb6df32783e6e803f80bce1bb8e5842e13b | [
"@jpinner I may miss something but I think in netty 4+ we don't need the synchronized stuff at all because of the new thread-model. Can you confirm ?\n",
"@jpinner ping :)\n",
"@jpinner could you please check so we can fix this... Thanks !\n",
"Let me fix this\n"
] | [] | 2015-08-28T20:31:17Z | [
"defect"
] | Inconsistent synchronization of some variables in SpdySessionHandler | 1. Field `io.netty.handler.codec.spdy.SpdySessionHandler.lastGoodStreamId`
Synchronized 50% of the time:
Unsynchronized access at SpdySessionHandler.java:[line 148]
Unsynchronized access at SpdySessionHandler.java:[line 243]
Synchronized access at SpdySessionHandler.java:[line 736]
Synchronized access at... | [
"codec-http/src/main/java/io/netty/handler/codec/spdy/SpdySessionHandler.java"
] | [
"codec-http/src/main/java/io/netty/handler/codec/spdy/SpdySessionHandler.java"
] | [] | diff --git a/codec-http/src/main/java/io/netty/handler/codec/spdy/SpdySessionHandler.java b/codec-http/src/main/java/io/netty/handler/codec/spdy/SpdySessionHandler.java
index 6e540256321..338456be5a7 100644
--- a/codec-http/src/main/java/io/netty/handler/codec/spdy/SpdySessionHandler.java
+++ b/codec-http/src/main/java... | null | train | train | 2015-08-28T21:38:12 | 2014-07-19T22:39:39Z | idelpivnitskiy | val |
netty/netty/4174_4175 | netty/netty | netty/netty/4174 | netty/netty/4175 | [
"timestamp(timedelta=60.0, similarity=0.8817071786875241)"
] | 2d4a8a75bbd6746c0fb63728f3877d1985af68ab | 606201fcdd633fd5c2e7d6a677c052d1236490cd | [] | [
"I think this a copy and paste error. \n\nTCP_USER_TIMEOUT.\n",
"Remoce extra empty line\n",
"Remove extra empty line\n"
] | 2015-08-30T22:17:33Z | [
"feature"
] | Introduce ability to set TCP_USER_TIMEOUT in transport-native-epoll | Context:
Netty 4.0.31.Final-SNAPSHOT
I am using ChannelOption.SO_KEEPALIVE together with EpollChannelOption.TCP_KEEP\* in order to detect connection problems. Works as expected however when I keep writing to that connection e.g. every second, the connection will not become idle and will not be torn down by the OS.
I'... | [
"transport-native-epoll/src/main/c/io_netty_channel_epoll_Native.c",
"transport-native-epoll/src/main/java/io/netty/channel/epoll/EpollChannelOption.java",
"transport-native-epoll/src/main/java/io/netty/channel/epoll/EpollSocketChannelConfig.java",
"transport-native-epoll/src/main/java/io/netty/channel/epoll/... | [
"transport-native-epoll/src/main/c/io_netty_channel_epoll_Native.c",
"transport-native-epoll/src/main/java/io/netty/channel/epoll/EpollChannelOption.java",
"transport-native-epoll/src/main/java/io/netty/channel/epoll/EpollSocketChannelConfig.java",
"transport-native-epoll/src/main/java/io/netty/channel/epoll/... | [] | diff --git a/transport-native-epoll/src/main/c/io_netty_channel_epoll_Native.c b/transport-native-epoll/src/main/c/io_netty_channel_epoll_Native.c
index cc1915fefa8..5fcc2e77ae9 100644
--- a/transport-native-epoll/src/main/c/io_netty_channel_epoll_Native.c
+++ b/transport-native-epoll/src/main/c/io_netty_channel_epoll_... | null | train | train | 2015-08-30T20:38:35 | 2015-08-30T21:53:50Z | tomasol | val |
netty/netty/4185_4190 | netty/netty | netty/netty/4185 | netty/netty/4190 | [
"timestamp(timedelta=37.0, similarity=0.958631723650472)"
] | f1eddd6117f5e3109257f911d51b80250e17e11d | 64551ee03cfcd819007a83c77b8310a60a847b04 | [
"@blucas - Sorry for breaking you :(. I guess we have at least 2 options:\n1. Add a constructor to `DefaultSpdyHeaders` which takes a `boolean validateHeaders` argument which can make header name validation optional. We would then need to carry this through the SPDY codec to pass along the `boolean` where ever the... | [] | 2015-09-04T17:10:37Z | [
"defect"
] | SpdyHttpEncoder fails to convert HttpResponse to SpdyFrame | Netty Version: Latest master (f1eddd6117f5e3109257f911d51b80250e17e11d)
When `SpdyHttpEncoder` attempts to create an `SpdyHeadersFrame` from a `HttpResponse` an `IllegalArgumentException` is thrown if the original `HttpResponse` contains a header that includes uppercase characters. The `IllegalArgumentException` is t... | [
"codec-http/src/main/java/io/netty/handler/codec/spdy/SpdyHttpEncoder.java"
] | [
"codec-http/src/main/java/io/netty/handler/codec/spdy/SpdyHttpEncoder.java"
] | [] | diff --git a/codec-http/src/main/java/io/netty/handler/codec/spdy/SpdyHttpEncoder.java b/codec-http/src/main/java/io/netty/handler/codec/spdy/SpdyHttpEncoder.java
index 8a62c1ac29d..e59afb8a95d 100644
--- a/codec-http/src/main/java/io/netty/handler/codec/spdy/SpdyHttpEncoder.java
+++ b/codec-http/src/main/java/io/netty... | null | test | train | 2015-09-03T08:54:10 | 2015-09-03T19:54:48Z | blucas | val |
netty/netty/3721_4223 | netty/netty | netty/netty/3721 | netty/netty/4223 | [
"timestamp(timedelta=11.0, similarity=0.859242328286967)"
] | b66b38d3e417324e4eae965795b94976baa9eb11 | 25f49603b1ecc0e0405653648d69a6c117828779 | [
"@ejona86 @Scottmitch @nmittler @louiscryan is this something we need to fix before 4.1.0.Final ?\n",
"I don't think so. We seem to be conforming to the spec since we're checking the size on the inbound frame.\n",
"@nmittler so closing ?\n",
"@ejona86 thoughts on closing?\n",
"wouldn't hurt to check the wri... | [] | 2015-09-14T20:20:21Z | [
"improvement"
] | http2: writePing does not verify data.readableBytes() == 8 | When [writing the ping frame](https://github.com/netty/netty/blob/master/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2FrameWriter.java#L238), we aren't verifying that the length is 8, as required by the spec:
> Receipt of a PING frame with a length field value other than 8 MUST be treated as a co... | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2FrameReader.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2FrameWriter.java"
] | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2FrameReader.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2FrameWriter.java"
] | [] | diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2FrameReader.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2FrameReader.java
index 035fc949e81..4b98985655c 100644
--- a/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2FrameReader.java
+++ b/cod... | null | test | train | 2015-09-14T22:16:36 | 2015-05-04T17:34:33Z | ejona86 | val |
netty/netty/4244_4245 | netty/netty | netty/netty/4244 | netty/netty/4245 | [
"timestamp(timedelta=102.0, similarity=0.867344004592763)"
] | 94bf412edbea73c0b1dbac4ada8919708c4f369e | 859ff46565cad8eefb851e733f9efa707e101b53 | [
"@Scottmitch @nmittler can you check?\n",
"fixed by https://github.com/netty/netty/pull/4245\n"
] | [] | 2015-09-21T16:09:33Z | [
"defect"
] | HttpConversionUtil.toHttp2Headers converts uri to path header unproperly | Netty version: 4.1.0.Beta6
Context:
When we use HttpConversionUtil.toHttp2Headers, if uri has urlencoded values, they are decoded unproperly in `:path` header.
I could't find any spec but below in https://httpwg.github.io/specs/rfc7540.html#HttpHeaders
> The :path pseudo-header field includes the path and query pa... | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/HttpConversionUtil.java"
] | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/HttpConversionUtil.java"
] | [
"codec-http2/src/test/java/io/netty/handler/codec/http2/HttpToHttp2ConnectionHandlerTest.java"
] | diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/HttpConversionUtil.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/HttpConversionUtil.java
index 7163f69f550..3231c50a926 100644
--- a/codec-http2/src/main/java/io/netty/handler/codec/http2/HttpConversionUtil.java
+++ b/codec-http2/src/ma... | diff --git a/codec-http2/src/test/java/io/netty/handler/codec/http2/HttpToHttp2ConnectionHandlerTest.java b/codec-http2/src/test/java/io/netty/handler/codec/http2/HttpToHttp2ConnectionHandlerTest.java
index 0377788887d..9d10e0d3bca 100644
--- a/codec-http2/src/test/java/io/netty/handler/codec/http2/HttpToHttp2Connectio... | test | train | 2015-09-18T21:17:34 | 2015-09-21T14:03:17Z | alexpark7712 | val |
netty/netty/4242_4258 | netty/netty | netty/netty/4242 | netty/netty/4258 | [
"timestamp(timedelta=19.0, similarity=0.867944925222094)"
] | beb75f0a04617faf19d80c9d42bea38c0ee7b22d | e109c8ef20fc8027801582a71dd6f1ef5e360d0c | [
"@blucas Thanks for the report!\n\nRegarding the [writeBytes method](https://github.com/netty/netty/blob/master/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2RemoteFlowController.java#L633), I believe the comment is wrong. I suspect it should be re-worded to something like \"The frame has data... | [] | 2015-09-23T14:45:53Z | [
"defect"
] | HTTP/2 FlowController allocated write and flush | Netty Version: lastest master (94bf412edbea73c0b1dbac4ada8919708c4f369e)
/cc @Scottmitch @nmittler
I have a serious issue (it is actually a blocker) that is preventing me from releasing the next version of our product (which will support HTTP/2 traffic). I would really appreciate it if this could be resolved quickl... | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2RemoteFlowController.java"
] | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2RemoteFlowController.java"
] | [] | diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2RemoteFlowController.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2RemoteFlowController.java
index 33b4262b001..3f7f3260835 100644
--- a/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2RemoteFl... | null | test | train | 2015-09-23T08:41:23 | 2015-09-20T11:45:43Z | blucas | val |
netty/netty/4265_4279 | netty/netty | netty/netty/4265 | netty/netty/4279 | [
"timestamp(timedelta=14.0, similarity=0.8620227261918824)"
] | 127886f469304f37ce39e5fff2412db54f8890e2 | d187462e394d4de2833c43bf680c8450e9aa0799 | [
"...why would you even do that\n",
"@willisblackburn thanks for the report. Will add a guard against this\n",
"@willisblackburn - I'm assuming you are using Netty 4.0?\n"
] | [
"In 4.1 we are not consistent in that this method `returns this;` and `add` throws an exception. I think we should be consistent in how we behave across versions (and maybe how we react to these 2 situations). So do we want to throw an exception, or just `return this;`?\n",
"hmm. when adding this check my thought... | 2015-09-25T15:54:03Z | [
"defect"
] | Adding DefaultHttpHeaders to itself creates infinite loop | Example:
```
public void test() {
HttpHeaders headers = new DefaultHttpHeaders();
headers.add("foo", "bar");
headers.add(headers);
// This will never end
headers.forEach(entry -> {});
}
```
| [
"codec-http/src/main/java/io/netty/handler/codec/http/DefaultHttpHeaders.java"
] | [
"codec-http/src/main/java/io/netty/handler/codec/http/DefaultHttpHeaders.java"
] | [
"codec-http/src/test/java/io/netty/handler/codec/http/HttpHeadersTest.java"
] | diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/DefaultHttpHeaders.java b/codec-http/src/main/java/io/netty/handler/codec/http/DefaultHttpHeaders.java
index 2b706565083..3b3d9eca61b 100644
--- a/codec-http/src/main/java/io/netty/handler/codec/http/DefaultHttpHeaders.java
+++ b/codec-http/src/main/java... | diff --git a/codec-http/src/test/java/io/netty/handler/codec/http/HttpHeadersTest.java b/codec-http/src/test/java/io/netty/handler/codec/http/HttpHeadersTest.java
index 47302c7425d..e2eadc33cab 100644
--- a/codec-http/src/test/java/io/netty/handler/codec/http/HttpHeadersTest.java
+++ b/codec-http/src/test/java/io/netty... | test | train | 2015-09-25T02:38:29 | 2015-09-23T20:52:27Z | willisblackburn | val |
netty/netty/4266_4282 | netty/netty | netty/netty/4266 | netty/netty/4282 | [
"timestamp(timedelta=80.0, similarity=0.8921734592383369)"
] | 747533408dbf3fa04fe0753e0f20cf80b8ac66ed | 60dbed85f22bbf3dae64023d14e792a1d840957d | [
"@nmittler - FYI\n",
"This is also related to https://github.com/netty/netty/issues/4242\n",
"@Scottmitch - Could you give an example for when this would happen? I haven't had this happen to me yet when testing HTTP/2 with Chrome/FF.\n",
"+1\n\n@Scottmitch as discussed offline, the first thing we need is a ne... | [
"revert this? It was more readable with the carriage return.\n",
"will do :)\n",
"Don't you still need `nextTotalWeight += child.weight`?\n",
"Oh you updated `stillHungry` to do that ... much better :)\n",
"I already moved into `stillHungry`. Seemed like it belonged there.\n",
"> Oh you updated stillHungr... | 2015-09-25T17:00:46Z | [
"defect"
] | DefaultHttp2RemoteFlowController not re-visiting nodes that still have streamable bytes | The allocation algorithm may not distributed all the available bytes even though the streams may be able to use all the bytes. This is caused by the children that have streamable bytes not being considered hungry because the `nextConnectionWindow` has collapsed.
Also related to [DefaultHttp2RemoteFlowController](https... | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2RemoteFlowController.java"
] | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2RemoteFlowController.java"
] | [
"codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2RemoteFlowControllerTest.java"
] | diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2RemoteFlowController.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2RemoteFlowController.java
index 3f7f3260835..b9243de2a4f 100644
--- a/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2RemoteFl... | diff --git a/codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2RemoteFlowControllerTest.java b/codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2RemoteFlowControllerTest.java
index 963c43f9e8f..95dd831fd3e 100644
--- a/codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2... | train | train | 2015-09-25T20:05:14 | 2015-09-23T23:43:58Z | Scottmitch | val |
netty/netty/4289_4309 | netty/netty | netty/netty/4289 | netty/netty/4309 | [
"timestamp(timedelta=388.0, similarity=0.8750055050435257)"
] | 11e8163aa9d29074d5002da662c5284e82ecd0d4 | 426b6bb4a5e21c12300e455a062735d17f9e0294 | [
"@trustin @normanmaurer - FYI\n",
"Already working on it :)\n\n> Am 27.09.2015 um 07:42 schrieb Scott Mitchell notifications@github.com:\n> \n> @trustin @normanmaurer - FYI\n> \n> —\n> Reply to this email directly or view it on GitHub.\n",
"Thanks @normanmaurer !\n",
"Thank you guys!\n"
] | [
"Does it make sense to keep this to be able to test against \"real\" servers during development? Enabled via some explicit command line flag?\n",
"not sure... I think it is fine to just use the mock.\n",
"Does it make sense to have some variation in the responses (and number of responses)?\n",
"sgtm. lets kee... | 2015-10-02T19:11:02Z | [
"improvement"
] | Mock DNS server for automated unit tests | The DNS unit tests frequently fail because they are relying on external DNS servers. We should work to make them more reliable and ideally decouple their reliance on external DNS servers.
| [
"pom.xml",
"resolver-dns/pom.xml",
"resolver-dns/src/main/java/io/netty/resolver/dns/DnsNameResolver.java",
"resolver-dns/src/main/java/io/netty/resolver/dns/DnsQueryContext.java"
] | [
"pom.xml",
"resolver-dns/pom.xml",
"resolver-dns/src/main/java/io/netty/resolver/dns/DnsNameResolver.java",
"resolver-dns/src/main/java/io/netty/resolver/dns/DnsQueryContext.java"
] | [
"resolver-dns/src/test/java/io/netty/resolver/dns/DnsNameResolverTest.java",
"resolver-dns/src/test/resources/logback-test.xml"
] | diff --git a/pom.xml b/pom.xml
index 88a45d0ef24..689a9d5edd1 100644
--- a/pom.xml
+++ b/pom.xml
@@ -893,6 +893,14 @@
<artifactId>xz</artifactId>
<version>1.5</version>
</dependency>
+
+ <!-- Test dependency for resolver-dns -->
+ <dependency>
+ <groupId>org.apache.directory.se... | diff --git a/resolver-dns/src/test/java/io/netty/resolver/dns/DnsNameResolverTest.java b/resolver-dns/src/test/java/io/netty/resolver/dns/DnsNameResolverTest.java
index 8967150cb1d..a1ca634386e 100644
--- a/resolver-dns/src/test/java/io/netty/resolver/dns/DnsNameResolverTest.java
+++ b/resolver-dns/src/test/java/io/net... | train | train | 2015-10-07T14:15:53 | 2015-09-27T05:42:02Z | Scottmitch | val |
netty/netty/4327_4341 | netty/netty | netty/netty/4327 | netty/netty/4341 | [
"timestamp(timedelta=14.0, similarity=0.861430330228934)"
] | 81a913ced197c2a1c3219ab602c49ded9ec195e7 | 6530ee5a4199dbbb180153fab396d746a76010d0 | [
"@jroper sounds like a bug... let me fix it.\n",
"Fixed by https://github.com/netty/netty/pull/4341\n"
] | [] | 2015-10-10T05:25:28Z | [
"defect"
] | A number of toString() methods on classes that implement ByteBufHolder can throw IllegalReferenceCountException | Two examples that I've found include `WebSocketFrame.toString()` and `DefaultByteBufHolder.toString()`. `toString()` implementations should always try to avoid throwing exceptions, since they're used for things like creating exception messages and arbitrary logging of inputs/outputs. Consequently, if `toString()` doe... | [
"buffer/src/main/java/io/netty/buffer/DefaultByteBufHolder.java",
"codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketFrame.java",
"transport-sctp/src/main/java/io/netty/channel/sctp/SctpMessage.java"
] | [
"buffer/src/main/java/io/netty/buffer/DefaultByteBufHolder.java",
"codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketFrame.java",
"transport-sctp/src/main/java/io/netty/channel/sctp/SctpMessage.java"
] | [
"buffer/src/test/java/io/netty/buffer/DefaultByteBufHolderTest.java"
] | diff --git a/buffer/src/main/java/io/netty/buffer/DefaultByteBufHolder.java b/buffer/src/main/java/io/netty/buffer/DefaultByteBufHolder.java
index c029accedf6..ef39045dcdd 100644
--- a/buffer/src/main/java/io/netty/buffer/DefaultByteBufHolder.java
+++ b/buffer/src/main/java/io/netty/buffer/DefaultByteBufHolder.java
@@ ... | diff --git a/buffer/src/test/java/io/netty/buffer/DefaultByteBufHolderTest.java b/buffer/src/test/java/io/netty/buffer/DefaultByteBufHolderTest.java
new file mode 100644
index 00000000000..0b462c4f541
--- /dev/null
+++ b/buffer/src/test/java/io/netty/buffer/DefaultByteBufHolderTest.java
@@ -0,0 +1,32 @@
+/*
+ * Copyrig... | test | train | 2015-10-09T19:43:12 | 2015-10-07T12:25:15Z | jroper | val |
netty/netty/4313_4345 | netty/netty | netty/netty/4313 | netty/netty/4345 | [
"timestamp(timedelta=31.0, similarity=0.9040483003970246)"
] | 99dfc9ea799348430a1c25776ce30a95bc10a1ff | 4b5959472213c36d3590ac02ceb1288689bc19cc | [
"Will check\n\n> Am 03.10.2015 um 13:26 schrieb scf37 notifications@github.com:\n> \n> There is interesting comment:\n> \n> // Maybe we could also check if we can unwrap() to access the wrapped buffer which\n> // may be an AbstractByteBuf. But this may be overkill so let us keep it simple for now.\n> But - simple H... | [] | 2015-10-10T05:38:48Z | [
"improvement"
] | ByteBufUtil.writeUtf8 and WrappedByteBuf | There is interesting comment:
```
// Maybe we could also check if we can unwrap() to access the wrapped buffer which
// may be an AbstractByteBuf. But this may be overkill so let us keep it simple for now.
```
But - simple HTTP server under load (like 5k req/sec) uses 38% time on String.getBytes. I use ByteBufUtil.wr... | [
"buffer/src/main/java/io/netty/buffer/ByteBufUtil.java",
"buffer/src/main/java/io/netty/buffer/WrappedByteBuf.java"
] | [
"buffer/src/main/java/io/netty/buffer/ByteBufUtil.java",
"buffer/src/main/java/io/netty/buffer/WrappedByteBuf.java"
] | [
"buffer/src/test/java/io/netty/buffer/ByteBufUtilTest.java"
] | diff --git a/buffer/src/main/java/io/netty/buffer/ByteBufUtil.java b/buffer/src/main/java/io/netty/buffer/ByteBufUtil.java
index 7dc375fbb47..08c747dfcf3 100644
--- a/buffer/src/main/java/io/netty/buffer/ByteBufUtil.java
+++ b/buffer/src/main/java/io/netty/buffer/ByteBufUtil.java
@@ -395,39 +395,46 @@ public static int... | diff --git a/buffer/src/test/java/io/netty/buffer/ByteBufUtilTest.java b/buffer/src/test/java/io/netty/buffer/ByteBufUtilTest.java
index fb04c78ce71..1725fb525ac 100644
--- a/buffer/src/test/java/io/netty/buffer/ByteBufUtilTest.java
+++ b/buffer/src/test/java/io/netty/buffer/ByteBufUtilTest.java
@@ -33,6 +33,19 @@ publ... | train | train | 2015-10-07T14:15:14 | 2015-10-03T11:26:10Z | scf37 | val |
netty/netty/4357_4367 | netty/netty | netty/netty/4357 | netty/netty/4367 | [
"timestamp(timedelta=15.0, similarity=0.8927650762146052)"
] | 0528118669fd08244cdf84848a96eba83d7651d5 | c1276962f713022908ba3fd45485bc5676a83195 | [
"Will check\n",
"@luengnat ok I think i know where the problem is... working on a fix now :+1: \n",
"Fixed\n",
"Oddly I started encountering this issue while upgrading from jdk 8u60 to 8u65. Not really sure why that would explain this. I was just curious @luengnat do you happen to remember what JDK you were... | [] | 2015-10-16T18:16:34Z | [
"defect"
] | Assertion error in globalEventExecutor | I am using Vertx 3.1 with Netty 4.0.31. Every once in a while, I got an assert on this line:
```
protected final Runnable pollScheduledTask(long nanoTime) {
assert this.inEventLoop();
Queue scheduledTaskQueue = this.scheduledTaskQueue;
ScheduledFutureTask scheduledTask = scheduledTaskQueue == null?null:(... | [
"common/src/main/java/io/netty/util/concurrent/GlobalEventExecutor.java"
] | [
"common/src/main/java/io/netty/util/concurrent/GlobalEventExecutor.java"
] | [] | diff --git a/common/src/main/java/io/netty/util/concurrent/GlobalEventExecutor.java b/common/src/main/java/io/netty/util/concurrent/GlobalEventExecutor.java
index 5f18ed8dda7..29d7ad12d36 100644
--- a/common/src/main/java/io/netty/util/concurrent/GlobalEventExecutor.java
+++ b/common/src/main/java/io/netty/util/concurr... | null | train | train | 2015-10-16T20:13:51 | 2015-10-14T04:16:22Z | luengnat | val |
netty/netty/4355_4387 | netty/netty | netty/netty/4355 | netty/netty/4387 | [
"timestamp(timedelta=11.0, similarity=0.8850444964418077)"
] | 40e0fbfcb6d278fa7a5e92c19debad7dd7b31e08 | f2dad1ae3f7a4502d5e577efef70e49cd07ef8ce | [
"@freels hmmm... s you would argue that either the user provides a full initialised TrustManagerFactory and not certs or none and the certs ?\n",
"Yes. This would match the behavior of JdkSslServerContext as well.\n\nIn my case, I am trying to provide a trust manager initialized with a root CA cert that a server ... | [] | 2015-10-23T20:01:47Z | [
"defect"
] | OpenSslServerContext reinitializes the provided TrustManagerFactory with the key cert chain. | AFAICT, this is incorrect behavior, as the provided trust manager factory should already be initialized.
| [
"handler/src/main/java/io/netty/handler/ssl/OpenSslServerContext.java"
] | [
"handler/src/main/java/io/netty/handler/ssl/OpenSslServerContext.java"
] | [] | diff --git a/handler/src/main/java/io/netty/handler/ssl/OpenSslServerContext.java b/handler/src/main/java/io/netty/handler/ssl/OpenSslServerContext.java
index 99fead914bb..e3bf3ac7e4f 100644
--- a/handler/src/main/java/io/netty/handler/ssl/OpenSslServerContext.java
+++ b/handler/src/main/java/io/netty/handler/ssl/OpenS... | null | train | train | 2015-10-23T12:05:15 | 2015-10-14T00:38:57Z | freels | val |
netty/netty/4409_4410 | netty/netty | netty/netty/4409 | netty/netty/4410 | [
"timestamp(timedelta=112.0, similarity=0.9327689825970706)"
] | e4816952670c5d2f6e8c8ffbac8777af4ec459aa | fe7db0f99563ff028d4ac3b32b5edfc3e7f8ae41 | [
"I guess all the native transport related stuff should only be built/triggered when a Linux only maven profile is enabled.\n",
"yes, that's also how the pom file seems to be set up, but idk how this \"conditional dependency\" stuff works in maven.\n",
"aww i think I have a fix.\n",
"@buchgr @normanmaurer CI b... | [
"this is just cause I also got warnings, that referring to props without a `project` prefix is deprecated.\n"
] | 2015-10-29T10:56:14Z | [] | Build fails on OSX | just wanted to build Netty master (mvn clean install) on a clean machine and building `microbench` fails
```
Failed to execute goal on project netty-microbench:
Could not resolve dependencies for project io.netty:netty-microbench:jar:5.0.0.Alpha3-SNAPSHOT:
Failure to find io.netty:netty-transport-native-epoll:jar:osx... | [
"microbench/pom.xml",
"pom.xml"
] | [
"microbench/pom.xml",
"pom.xml"
] | [] | diff --git a/microbench/pom.xml b/microbench/pom.xml
index f9946800489..087f99b0685 100644
--- a/microbench/pom.xml
+++ b/microbench/pom.xml
@@ -68,7 +68,6 @@
<groupId>${project.groupId}</groupId>
<artifactId>netty-transport-native-epoll</artifactId>
<version>${project.version}</version>
- <cl... | null | train | train | 2015-10-28T21:55:40 | 2015-10-29T10:25:16Z | buchgr | val |
netty/netty/4395_4414 | netty/netty | netty/netty/4395 | netty/netty/4414 | [
"timestamp(timedelta=26.0, similarity=0.8603650312112185)"
] | c6474f92185fa2ec58c686cce0822983f2ec9af3 | 1ae7a5cc37e1ca58bcd77617e600b78cdaa7f1cd | [
"thanks for reporting @maxwindiff!\n",
"@Scottmitch Does this also fix https://github.com/netty/netty/issues/3450?\n",
"@buchgr yes I think so.\n",
"@buchgr - Based upon your description (same scenario that is described in this issue), I would think this should take care of #3450. Is it possible to verify?\n"... | [
"Static?\n",
"done\n",
"just a nit but do we want to also prefix the new methods with \"test\" as the others in the class ?\n",
"done\n"
] | 2015-10-29T17:23:21Z | [
"duplicate"
] | StackOverflowError when adding listener to DefaultPromise w/ ImmediateEventExecutor | This will produce a `StackOverflowError`:
``` java
@Test
public void testName() throws Exception {
DefaultPromise<Object> promise = new DefaultPromise<>(ImmediateEventExecutor.INSTANCE);
promise.addListener(f1 -> {
promise.addListener(f2 -> System.out.println("done"));
});
... | [
"common/src/main/java/io/netty/util/concurrent/DefaultPromise.java"
] | [
"common/src/main/java/io/netty/util/concurrent/DefaultPromise.java"
] | [
"common/src/test/java/io/netty/util/concurrent/DefaultPromiseTest.java"
] | diff --git a/common/src/main/java/io/netty/util/concurrent/DefaultPromise.java b/common/src/main/java/io/netty/util/concurrent/DefaultPromise.java
index 4aec5b53061..142b88d5573 100644
--- a/common/src/main/java/io/netty/util/concurrent/DefaultPromise.java
+++ b/common/src/main/java/io/netty/util/concurrent/DefaultProm... | diff --git a/common/src/test/java/io/netty/util/concurrent/DefaultPromiseTest.java b/common/src/test/java/io/netty/util/concurrent/DefaultPromiseTest.java
index 26f304b09f3..ea7a56e6545 100644
--- a/common/src/test/java/io/netty/util/concurrent/DefaultPromiseTest.java
+++ b/common/src/test/java/io/netty/util/concurrent... | test | train | 2015-10-29T16:23:25 | 2015-10-26T22:12:04Z | maxwindiff | val |
netty/netty/4402_4417 | netty/netty | netty/netty/4402 | netty/netty/4417 | [
"timestamp(timedelta=432.0, similarity=0.8530380492232348)"
] | 48a3ba86cf9a76609bd26535afe3392ddf85c4d2 | c75fab21e5cba6dffb78bcc7af640c10d7ee5a34 | [
"Thanks for reporting @ninja- !\n\n@normanmaurer - assigned to you.\n",
"@Scottmitch :smiley: I am _squeezing_ every last bit of top hot methods and found lots of interesting things already.\nbtw. recycler.get() was something like 6% for the work and 94% for the thread local madness...I'd use something separate f... | [] | 2015-10-29T20:36:58Z | [] | FastThreadLocal slower than jdk | ```
# Run complete. Total time: 00:01:21
Benchmark Mode Cnt Score Error Units
FastThreadLocalBenchmark.fastThreadLocal thrpt 20 50264,632 ± 6021,328 ops/s
FastThreadLocalBenchmark.jdkThreadLocalGet thrpt 20 83866,710 ± 6483,523 ops/s
Benchmark ... | [
"microbench/src/main/java/io/netty/microbench/util/AbstractMicrobenchmark.java"
] | [
"microbench/src/main/java/io/netty/microbench/util/AbstractMicrobenchmark.java"
] | [] | diff --git a/microbench/src/main/java/io/netty/microbench/util/AbstractMicrobenchmark.java b/microbench/src/main/java/io/netty/microbench/util/AbstractMicrobenchmark.java
index 36816b16bca..c484d1cd5bb 100644
--- a/microbench/src/main/java/io/netty/microbench/util/AbstractMicrobenchmark.java
+++ b/microbench/src/main/j... | null | val | train | 2015-10-29T19:38:59 | 2015-10-28T17:33:02Z | ninja- | val |
netty/netty/4442_4443 | netty/netty | netty/netty/4442 | netty/netty/4443 | [
"timestamp(timedelta=95230.0, similarity=0.8515996131608482)"
] | fd810e717865f5d6cda27910cf3cfa635388ef1d | 4cc2050f193b0ec30bff9e2ef4c0762999d44bdd | [
"@louiscryan - I think we can close this now?\n"
] | [] | 2015-11-05T21:25:36Z | [] | 4.0 HttpHeader.set(HttpHeader) will cause itself to be emptied when passed self | public HttpHeaders set(HttpHeaders headers) {
if (headers == null) {
throw new NullPointerException("headers");
}
clear();
for (Map.Entry<String, String> e: headers) {
add(e.getKey(), e.getValue());
}
return this;
}
this is in conflict with Defaul... | [
"codec-http/src/main/java/io/netty/handler/codec/http/DefaultHttpHeaders.java",
"codec-http/src/main/java/io/netty/handler/codec/http/HttpHeaders.java"
] | [
"codec-http/src/main/java/io/netty/handler/codec/http/DefaultHttpHeaders.java",
"codec-http/src/main/java/io/netty/handler/codec/http/HttpHeaders.java"
] | [
"codec-http/src/test/java/io/netty/handler/codec/http/HttpHeadersTest.java"
] | diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/DefaultHttpHeaders.java b/codec-http/src/main/java/io/netty/handler/codec/http/DefaultHttpHeaders.java
index 3b3d9eca61b..7e5b986f54a 100644
--- a/codec-http/src/main/java/io/netty/handler/codec/http/DefaultHttpHeaders.java
+++ b/codec-http/src/main/java... | diff --git a/codec-http/src/test/java/io/netty/handler/codec/http/HttpHeadersTest.java b/codec-http/src/test/java/io/netty/handler/codec/http/HttpHeadersTest.java
index e2eadc33cab..21827c7747f 100644
--- a/codec-http/src/test/java/io/netty/handler/codec/http/HttpHeadersTest.java
+++ b/codec-http/src/test/java/io/netty... | train | train | 2015-11-05T08:51:59 | 2015-11-05T21:01:58Z | louiscryan | val |
netty/netty/4444_4445 | netty/netty | netty/netty/4444 | netty/netty/4445 | [
"timestamp(timedelta=20815.0, similarity=0.9127999973381334)"
] | 202b2dbc89439862c43caf53877cb4bff77c35a4 | fa6b765662381172f6e675b5ac82fa081098548f | [
"@louiscryan can be closed ?\n",
"@louiscryan - Thanks for the fix!\n"
] | [] | 2015-11-05T22:10:04Z | [] | DefaultHttp2Headers has memory leak when being cleared | When calling DefaultHttp2Headers.clear the firstNonPseudoHeaders reference holds onto data that has just been cleared
| [
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2Headers.java"
] | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2Headers.java"
] | [
"codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2HeadersTest.java"
] | diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2Headers.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2Headers.java
index 7a4bfe60435..69b1e17e079 100644
--- a/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2Headers.java
+++ b/codec-http2/src... | diff --git a/codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2HeadersTest.java b/codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2HeadersTest.java
index 5885ea153ce..eb187c9d4ad 100644
--- a/codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2HeadersTest.java
+++ b/cod... | train | train | 2015-11-05T08:51:37 | 2015-11-05T21:33:34Z | louiscryan | val |
netty/netty/4446_4447 | netty/netty | netty/netty/4446 | netty/netty/4447 | [
"timestamp(timedelta=20987.0, similarity=0.8665203016177547)"
] | 202b2dbc89439862c43caf53877cb4bff77c35a4 | 3d7bdc905ac6f84bfe108e10c5325c4179d8448e | [
"@louiscryan I think this can be closed ?\n",
"@louiscryan - thanks!\n"
] | [] | 2015-11-05T22:33:11Z | [] | Headers.set(self) and Headers.setAll(self) are inconsistent | The former will throw, the latter is a no-op.
| [
"codec/src/main/java/io/netty/handler/codec/DefaultHeaders.java"
] | [
"codec/src/main/java/io/netty/handler/codec/DefaultHeaders.java"
] | [
"codec-http/src/test/java/io/netty/handler/codec/http/HttpHeadersTest.java",
"codec/src/test/java/io/netty/handler/codec/DefaultHeadersTest.java"
] | diff --git a/codec/src/main/java/io/netty/handler/codec/DefaultHeaders.java b/codec/src/main/java/io/netty/handler/codec/DefaultHeaders.java
index 995a9268144..ead9f0a5562 100644
--- a/codec/src/main/java/io/netty/handler/codec/DefaultHeaders.java
+++ b/codec/src/main/java/io/netty/handler/codec/DefaultHeaders.java
@@ ... | diff --git a/codec-http/src/test/java/io/netty/handler/codec/http/HttpHeadersTest.java b/codec-http/src/test/java/io/netty/handler/codec/http/HttpHeadersTest.java
index bfd93b5143d..a4ab3eb3335 100644
--- a/codec-http/src/test/java/io/netty/handler/codec/http/HttpHeadersTest.java
+++ b/codec-http/src/test/java/io/netty... | train | train | 2015-11-05T08:51:37 | 2015-11-05T22:31:41Z | louiscryan | val |
netty/netty/3972_4455 | netty/netty | netty/netty/3972 | netty/netty/4455 | [
"timestamp(timedelta=22.0, similarity=0.873253803792159)"
] | 035053be4ad0e1961b434eedd9f93946ee119463 | 5e52720108c9b6a4a286c7354dfd982d3cb75295 | [
"I didn't expect people to produce such amount of load obviously. Let me get the query ID allocation done on per-server basis rather than on per-resolver basis.\n",
"Thanks. If you want to keep an array structure, perhaps size could be a configurable setting? In either case it should be possible to get the origin... | [
"We should not do this as this allows this to escape from the constructor and so we may see not fully initialise instances .\n",
"can't we use a ConcurrentMap here ?\n",
"We can't because we insert multiple entries.\n",
"I guess that's not gonna happen because `DnsQueryContext` is only accessed later when a m... | 2015-11-08T05:49:55Z | [
"defect"
] | DNS query ID space exhaustion | In running big DNS resolution loads with very high parallellism and logging turned on I'm running into query ID space exhaustion (logged messages below).
As I've reviewed the Netty DNS code, I see there is a hard limit of 65536 queries max (in reality a lot less because there would be too many collisions to obtain an ... | [
"resolver-dns/src/main/java/io/netty/resolver/dns/DnsNameResolver.java",
"resolver-dns/src/main/java/io/netty/resolver/dns/DnsQueryContext.java"
] | [
"resolver-dns/src/main/java/io/netty/resolver/dns/DnsNameResolver.java",
"resolver-dns/src/main/java/io/netty/resolver/dns/DnsQueryContext.java",
"resolver-dns/src/main/java/io/netty/resolver/dns/DnsQueryContextManager.java"
] | [] | diff --git a/resolver-dns/src/main/java/io/netty/resolver/dns/DnsNameResolver.java b/resolver-dns/src/main/java/io/netty/resolver/dns/DnsNameResolver.java
index 9c3b7a1d2bc..dce3e66d59b 100644
--- a/resolver-dns/src/main/java/io/netty/resolver/dns/DnsNameResolver.java
+++ b/resolver-dns/src/main/java/io/netty/resolver/... | null | train | train | 2015-11-07T19:15:20 | 2015-07-11T06:26:39Z | dmk23 | val |
netty/netty/4458_4463 | netty/netty | netty/netty/4458 | netty/netty/4463 | [
"timestamp(timedelta=30.0, similarity=0.9127479533480994)"
] | 120ffaf880b81c260141c9e46cec239ac235aeb9 | 14f1aa384bf33db413b3bd2e3f286a41be838625 | [
"No this is a bug\n\n> Am 08.11.2015 um 22:03 schrieb Brendt notifications@github.com:\n> \n> Netty Version: master (latest snapshot a6816bd)\n> \n> I've notice that if a DefaultFullHttpRequest or DefaultFullHttpResponse have been released, then calls to hashCode() will throw an IllegalRefCountException. I was wond... | [
"nit: `e` -> `ignore`\n",
"nit: `e` -> `ignore`\n"
] | 2015-11-09T20:02:40Z | [
"defect"
] | DefaultFullHttp(Request|Response).hashCode() throws IllegalRefCountException | Netty Version: master (latest snapshot a6816bd59ef2923d82af5b7a7f3b722507a56a3a)
I've notice that if a `DefaultFullHttpRequest` or `DefaultFullHttpResponse` have been released, then calls to `hashCode()` will throw an `IllegalRefCountException` [here](https://github.com/netty/netty/blob/master/codec-http/src/main/java... | [
"codec-http/src/main/java/io/netty/handler/codec/http/DefaultFullHttpRequest.java",
"codec-http/src/main/java/io/netty/handler/codec/http/DefaultFullHttpResponse.java"
] | [
"codec-http/src/main/java/io/netty/handler/codec/http/DefaultFullHttpRequest.java",
"codec-http/src/main/java/io/netty/handler/codec/http/DefaultFullHttpResponse.java"
] | [] | diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/DefaultFullHttpRequest.java b/codec-http/src/main/java/io/netty/handler/codec/http/DefaultFullHttpRequest.java
index 87b2cf5e125..2ca9329e7c6 100644
--- a/codec-http/src/main/java/io/netty/handler/codec/http/DefaultFullHttpRequest.java
+++ b/codec-http/s... | null | train | train | 2015-11-10T00:25:13 | 2015-11-09T06:03:02Z | blucas | val |
netty/netty/4484_4510 | netty/netty | netty/netty/4484 | netty/netty/4510 | [
"timestamp(timedelta=175.0, similarity=0.9108850013441069)"
] | dbaeb3314e32b7f707fd4d2ea8ee78abb370ed59 | 32903a3d6dcbd0364e1900e1306d840cdb0f8da8 | [
"Will check soon\n\n> Am 18.11.2015 um 14:01 schrieb Stephane Landelle notifications@github.com:\n> \n> Netty 4.0.33 (client)\n> Jetty 9.3 (server)\n> OSX 10.11.1\n> Hotspot 1.8.0_66\n> AUTO_READ is set to false, read is manually triggered from channelActive and readComplete \n> Hi,\n> \n> I ran into an issue while... | [] | 2015-11-24T23:22:37Z | [
"cleanup"
] | ChannelOption.AUTO_CLOSE javadoc default value incorrect | - Netty 4.0.33 (client)
- Jetty 9.3 (server)
- OSX 10.11.1
- Hotspot 1.8.0_66
Hi,
I ran into an issue while trying to upgrade AsyncHttpClient test suite to Jetty 9.3, see https://github.com/AsyncHttpClient/async-http-client/issues/1035.
The test is about sending a small `ChunkedStream` to a Jetty server expecting Ba... | [
"transport/src/main/java/io/netty/channel/ChannelOption.java"
] | [
"transport/src/main/java/io/netty/channel/ChannelOption.java"
] | [] | diff --git a/transport/src/main/java/io/netty/channel/ChannelOption.java b/transport/src/main/java/io/netty/channel/ChannelOption.java
index 08af650cfaa..1695631f50c 100644
--- a/transport/src/main/java/io/netty/channel/ChannelOption.java
+++ b/transport/src/main/java/io/netty/channel/ChannelOption.java
@@ -33,7 +33,6 ... | null | test | train | 2015-11-24T20:44:06 | 2015-11-18T22:01:00Z | slandelle | val |
netty/netty/4504_4524 | netty/netty | netty/netty/4504 | netty/netty/4524 | [
"timestamp(timedelta=4.0, similarity=0.8464062515270071)"
] | 0ec34b5f761f88bbb88def1216f5bae64a0a2d4b | 333bfa6aeee4878ff053aef05b6313f34273d22c | [
"I guess the root cause of this issue is at `HttpClientCodec.upgradeFrom()`, which removes the `Decoder` immediately. Perhaps we should remove it using `ctx.executor().execute()`?\n",
"To add a bit more, I'm using 101 to upgrade from HTTP/1 to HTTP/2. I sometimes get an `IllegalReferenceCountException`, a `First ... | [] | 2015-11-29T04:41:57Z | [
"defect"
] | IllegalReferenceCountException from HttpObjectDecoder when switching a protocol | I found `HttpObjectDecoder.decode()` raises an `IllegalReferenceCountException` at the `case UPGRADED` block. After pulling my hairs, I found that it can happen when a user removes the `HttpObjectDecoder` from the pipeline via `HttpClientUpgradeHandler`. The following buffer access trace should be a good hint:
```
R... | [
"codec-http/src/main/java/io/netty/handler/codec/http/HttpClientCodec.java"
] | [
"codec-http/src/main/java/io/netty/handler/codec/http/HttpClientCodec.java"
] | [] | diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/HttpClientCodec.java b/codec-http/src/main/java/io/netty/handler/codec/http/HttpClientCodec.java
index cae9055b29c..c19da6fec48 100644
--- a/codec-http/src/main/java/io/netty/handler/codec/http/HttpClientCodec.java
+++ b/codec-http/src/main/java/io/netty... | null | train | train | 2015-11-26T22:56:00 | 2015-11-23T08:12:30Z | trustin | val |
netty/netty/4508_4525 | netty/netty | netty/netty/4508 | netty/netty/4525 | [
"timestamp(timedelta=14.0, similarity=0.8718083460186403)"
] | 0ec34b5f761f88bbb88def1216f5bae64a0a2d4b | a4489b24020c510aab7fac73356d9a5f8cc32cc4 | [
"Seems like we should use `HttpHeaderValues` here. The specification calls out the lowercase variant [1]. Should we change `HttpHeaderValues.UPGRADE` to lowercase, and should/are we using case insensitive compare when evaluating this header value?\n\n[1] https://tools.ietf.org/html/rfc7230#section-6.7\n\n> When Upg... | [] | 2015-11-29T04:48:33Z | [
"defect"
] | HttpClientUpgradeHandler.setUpgradeHeaders() append a wrong 'upgrade'. | See [here](https://github.com/netty/netty/blob/92dee9e500bc141162e6c3a6ef91d8d22e50c449/codec-http/src/main/java/io/netty/handler/codec/http/HttpClientUpgradeHandler.java#L231).
It has to be `HttpHeaderValues.UPGRADE` instead. Most servers should be OK with `HttpHeaderNames.UPGRADE` because they do case-insensitive co... | [
"codec-http/src/main/java/io/netty/handler/codec/http/HttpClientUpgradeHandler.java",
"codec-http/src/main/java/io/netty/handler/codec/http/HttpHeaderValues.java"
] | [
"codec-http/src/main/java/io/netty/handler/codec/http/HttpClientUpgradeHandler.java",
"codec-http/src/main/java/io/netty/handler/codec/http/HttpHeaderValues.java"
] | [] | diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/HttpClientUpgradeHandler.java b/codec-http/src/main/java/io/netty/handler/codec/http/HttpClientUpgradeHandler.java
index b7b3fda8e93..f8c452de24a 100644
--- a/codec-http/src/main/java/io/netty/handler/codec/http/HttpClientUpgradeHandler.java
+++ b/codec-... | null | train | train | 2015-11-26T22:56:00 | 2015-11-24T08:55:57Z | trustin | val |
netty/netty/3852_4535 | netty/netty | netty/netty/3852 | netty/netty/4535 | [
"timestamp(timedelta=110249.0, similarity=0.8467921632658658)"
] | 613c8b22e1bd6a8adfe171d641b830a4382d021c | 64c369f82228c0a3c1417540468e37a2fe0d49e0 | [
"@louiscryan - Let me summarize the face value tradeoffs and follow up with some questions. Feel free to elaborate. It seems like goal is to potentially reduce the amount of data frames written (less data frame header overhead on the wire) at the cost of an extra iteration step before writing out data frames (unt... | [] | 2015-12-04T19:35:43Z | [] | HTTP2 should coalesce small writes into a single DATA frame | @Scottmitch @nmittler
This is the analog of
https://github.com/netty/netty/issues/3737
but is probably more useful in general though possibly more complicated to implement. The goal is to allow for more small data writes to fit into a single DATA frame. Given that we already implement a queue of DATA & HEADER fram... | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2FrameWriter.java"
] | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2FrameWriter.java"
] | [
"codec-http2/src/test/java/io/netty/handler/codec/http2/Http2FrameRoundtripTest.java"
] | diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2FrameWriter.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2FrameWriter.java
index 53066118b2a..4c410e52e36 100644
--- a/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2FrameWriter.java
+++ b/cod... | diff --git a/codec-http2/src/test/java/io/netty/handler/codec/http2/Http2FrameRoundtripTest.java b/codec-http2/src/test/java/io/netty/handler/codec/http2/Http2FrameRoundtripTest.java
index 29cdc162bf5..297fa57bb33 100644
--- a/codec-http2/src/test/java/io/netty/handler/codec/http2/Http2FrameRoundtripTest.java
+++ b/cod... | train | train | 2015-12-04T20:08:01 | 2015-06-02T00:40:41Z | louiscryan | val |
netty/netty/4457_4537 | netty/netty | netty/netty/4457 | netty/netty/4537 | [
"timestamp(timedelta=477.0, similarity=0.8917241508522582)"
] | 2fefb2f79c30bcda5b43815d64174aac900e740c | ff55d5a5e4fe2995319c152a172516a33c533a98 | [
"@Scottmitch @nmittler please have a look guys :)\n",
"I wonder if `HttpConversionUtil` should just group all multi-valued headers into single entries (i.e. not treat `Cookie` as special here). It wouldn't be invalid and I suspect would perform better end-to-end. \n\n@Scottmitch WDYT?\n",
"@nmittler +1\n",
"@... | [
"yikes ... was this missing? :)\n",
"Not new code, but why does the `if` statement above check for the value of `trailers`? Seems like checking the name equals `te` is sufficient, no?\n",
"final?\n",
"yikes :)\n",
"Are we guaranteed that we need to skip exactly 2 characters?\n",
"Maybe check for the excep... | 2015-12-04T19:47:00Z | [
"defect"
] | HttpConversionUtil - Incorrect conversion of Cookie header | Netty Version: master (latest snapshot: a6816bd59ef2923d82af5b7a7f3b722507a56a3a)
The browser (I used Chrome 46.0.2490.80 for testing) sent an HTTP/2 request containing multiple cookies to a netty service, the `HttpConversionUtil` generated multiple `Cookie` header entries in the HTTP/1.x request. According to [one st... | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2Headers.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/HttpConversionUtil.java",
"common/src/main/java/io/netty/util/AsciiString.java",
"common/src/main/java/io/netty/util/ByteProcessor.java"
] | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2Headers.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/HttpConversionUtil.java",
"common/src/main/java/io/netty/util/AsciiString.java",
"common/src/main/java/io/netty/util/ByteProcessor.java"
] | [
"codec-http2/src/test/java/io/netty/handler/codec/http2/HttpToHttp2ConnectionHandlerTest.java",
"codec-http2/src/test/java/io/netty/handler/codec/http2/InboundHttp2ToHttpAdapterTest.java",
"common/src/test/java/io/netty/util/AsciiStringMemoryTest.java"
] | diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2Headers.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2Headers.java
index 5b54fd61877..63bb5617872 100644
--- a/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2Headers.java
+++ b/codec-http2/src... | diff --git a/codec-http2/src/test/java/io/netty/handler/codec/http2/HttpToHttp2ConnectionHandlerTest.java b/codec-http2/src/test/java/io/netty/handler/codec/http2/HttpToHttp2ConnectionHandlerTest.java
index 55d9404fc72..f8727b0dc2b 100644
--- a/codec-http2/src/test/java/io/netty/handler/codec/http2/HttpToHttp2Connectio... | train | train | 2015-12-07T11:40:01 | 2015-11-09T05:58:54Z | blucas | val |
netty/netty/4505_4552 | netty/netty | netty/netty/4505 | netty/netty/4552 | [
"timestamp(timedelta=39.0, similarity=0.8664136669792186)"
] | 22ad5c502fe558662f7fc2b377a8dfb559e4df9f | c62538dfa6bfb3fc52cb3fc55a9465d8a21706a1 | [
"[This is the Workaround](https://github.com/saxsys/SynchronizeFX/blob/9789b889a160051c4f74097446a4bc563f2beabb/transmitter/netty-transmitter/src/main/java/de/saxsys/synchronizefx/netty/websockets/WhiteSpaceInPathWebSocketClientHandshaker13.java) i use. I basically use [getRawPath()](http://docs.oracle.com/javase/8... | [
"Extract the return value of `getQuery()`\n",
"Fixed...\n"
] | 2015-12-10T08:45:31Z | [
"defect"
] | Spaces in WebSocket URIs not handled correctly | Websocket connections to URIs that have spaces in the path can not be established in Netty 4.0.21.
The problematic code seams to be [this line](https://github.com/netty/netty/blob/master/codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketClientHandshaker13.java#L129). If the URI contains a space ... | [
"codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketClientHandshaker.java",
"codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketClientHandshaker00.java",
"codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketClientHandshaker07.java",
"codec-http/... | [
"codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketClientHandshaker.java",
"codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketClientHandshaker00.java",
"codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketClientHandshaker07.java",
"codec-http/... | [
"codec-http/src/test/java/io/netty/handler/codec/http/websocketx/WebSocketClientHandshaker00Test.java",
"codec-http/src/test/java/io/netty/handler/codec/http/websocketx/WebSocketClientHandshaker07Test.java",
"codec-http/src/test/java/io/netty/handler/codec/http/websocketx/WebSocketClientHandshaker08Test.java",
... | diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketClientHandshaker.java b/codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketClientHandshaker.java
index d67b85f3798..42ef07d704f 100644
--- a/codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSock... | diff --git a/codec-http/src/test/java/io/netty/handler/codec/http/websocketx/WebSocketClientHandshaker00Test.java b/codec-http/src/test/java/io/netty/handler/codec/http/websocketx/WebSocketClientHandshaker00Test.java
new file mode 100644
index 00000000000..100abf694d4
--- /dev/null
+++ b/codec-http/src/test/java/io/net... | train | train | 2015-12-10T08:58:09 | 2015-11-23T11:39:57Z | rbi | val |
netty/netty/4564_4565 | netty/netty | netty/netty/4564 | netty/netty/4565 | [
"timestamp(timedelta=14.0, similarity=0.8830104167249984)"
] | 6c0fef133baa4afce11953110a6947732d87ec8e | e2f3fb84275bf47fb0296f6d18eb80b59891518f | [
"Fixed by https://github.com/netty/netty/pull/4565\n"
] | [] | 2015-12-12T17:40:25Z | [
"defect"
] | AsciiString.contentEqualsIgnoreCase does not work correctly for AsciiString comparison | Netty Version: master (6c0fef133baa4afce11953110a6947732d87ec8e)
`AsciiString.contentEqualsIgnoreCase` fails when checking for equality between two `AsciiString` objects. For example
``` java
// returns true, should return false
new AsciiString("foo").contentEqualsIgnoreCase(new AsciiString("bar"));
```
The issue ... | [
"common/src/main/java/io/netty/util/AsciiString.java"
] | [
"common/src/main/java/io/netty/util/AsciiString.java"
] | [
"common/src/test/java/io/netty/util/AsciiStringCharacterTest.java"
] | diff --git a/common/src/main/java/io/netty/util/AsciiString.java b/common/src/main/java/io/netty/util/AsciiString.java
index ceb5bf0ca59..8baf6851c4a 100644
--- a/common/src/main/java/io/netty/util/AsciiString.java
+++ b/common/src/main/java/io/netty/util/AsciiString.java
@@ -530,7 +530,7 @@ public boolean contentEqual... | diff --git a/common/src/test/java/io/netty/util/AsciiStringCharacterTest.java b/common/src/test/java/io/netty/util/AsciiStringCharacterTest.java
index cbec28140d3..08f2bab2c21 100644
--- a/common/src/test/java/io/netty/util/AsciiStringCharacterTest.java
+++ b/common/src/test/java/io/netty/util/AsciiStringCharacterTest.... | train | train | 2015-12-11T19:47:37 | 2015-12-12T17:34:36Z | blucas | val |
netty/netty/4587_4599 | netty/netty | netty/netty/4587 | netty/netty/4599 | [
"timestamp(timedelta=15.0, similarity=0.933704597804567)"
] | f750d6e36c80e88fb302c99b5b7413e5649e6738 | eebe5129c41d5d4b2deedd94cfc5cb0232788b1c | [
"@nmittler - FYI\n",
"@Scottmitch good find! Any thoughts on a fix?\n",
"@nmittler - Yes. See https://github.com/netty/netty/pull/4599\n"
] | [
"Should `streamableBytes` just be `pendingBytes` or something like that. `streamableBytes` is a derived value based on the stream window.\n",
"spelling: `writing`\n",
"what if `windowSize == 0 && pendingBytes == 0`? Seems like we would want to write an empty frame.\n",
"done\n",
"`pendingBytes == 0` shoul... | 2015-12-18T19:01:39Z | [
"defect"
] | HTTP/2 DefaultHttp2RemoteFlowController Stream writability notification broken | `DefaultHttp2RemoteFlowController.ListenerWritabilityMonitor` no longer reliably detects when a stream's writability change occurs. `ListenerWritabilityMonitor` was implemented to avoid duplicating iteration over all streams when possible and instead was relying on the `PriorityStreamByteDistributor` to call `write` fo... | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2RemoteFlowController.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/Http2CodecUtil.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/PriorityStreamByteDistributor.java",
"codec-http2/src/main/java/io/netty/handler... | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2RemoteFlowController.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/Http2CodecUtil.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/PriorityStreamByteDistributor.java",
"codec-http2/src/main/java/io/netty/handler... | [
"codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2RemoteFlowControllerTest.java",
"codec-http2/src/test/java/io/netty/handler/codec/http2/PriorityStreamByteDistributorTest.java",
"codec-http2/src/test/java/io/netty/handler/codec/http2/UniformStreamByteDistributorFlowControllerTest.java",
"co... | diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2RemoteFlowController.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2RemoteFlowController.java
index c3963c48b4d..a39b10af324 100644
--- a/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2RemoteFl... | diff --git a/codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2RemoteFlowControllerTest.java b/codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2RemoteFlowControllerTest.java
index 2d93c63ccb0..c98dfd0b7d1 100644
--- a/codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2... | train | train | 2015-12-18T22:51:52 | 2015-12-17T21:40:52Z | Scottmitch | val |
netty/netty/4545_4601 | netty/netty | netty/netty/4545 | netty/netty/4601 | [
"timestamp(timedelta=15.0, similarity=0.9236626301501217)"
] | 7b2f55ec2fa83873c4eeacb7fbccaecfedece63e | df63625877189674ac0135ef9710df245eecfd94 | [
"@nmittler - FYI\n",
"@Scottmitch good catch! ... do you want to throw together a PR with the updated test?\n",
"@nmittler - Yes. I can handle this. However the new interface required to fix this is introduced and used in PR #4538. Would you mind if I fixed after this issue after PR #4538 is resolved?\n",
"@S... | [
"Maybe instead of using another variable `writeAllowed`, it might be more clear if we just use `windowSize` directly:\n\n``` java\nif (state.windowSize <= 0) {\n continue;\n}\n```\n",
"@nmittler - We could do this, but boolean should be less memory, and this would be the only reason why we need `windowSize`. ... | 2015-12-18T19:15:53Z | [
"defect"
] | HTTP/2 UniformStreamByteDistributor stream window ignored | UniformStreamByteDistributor will write to a stream even if the stream's flow control window is negative. This is not allowed by the rfc.
https://tools.ietf.org/html/rfc7540#section-6.9.2
> A change to SETTINGS_INITIAL_WINDOW_SIZE can cause the available
> space in a flow-control window to become negative. A send... | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/UniformStreamByteDistributor.java"
] | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/UniformStreamByteDistributor.java"
] | [
"codec-http2/src/test/java/io/netty/handler/codec/http2/UniformStreamByteDistributorTest.java"
] | diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/UniformStreamByteDistributor.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/UniformStreamByteDistributor.java
index 9b3cd2daded..565ddfaa260 100644
--- a/codec-http2/src/main/java/io/netty/handler/codec/http2/UniformStreamByteDistributor... | diff --git a/codec-http2/src/test/java/io/netty/handler/codec/http2/UniformStreamByteDistributorTest.java b/codec-http2/src/test/java/io/netty/handler/codec/http2/UniformStreamByteDistributorTest.java
index 98ae689627d..fc358468b09 100644
--- a/codec-http2/src/test/java/io/netty/handler/codec/http2/UniformStreamByteDis... | train | train | 2015-12-23T01:59:40 | 2015-12-09T02:25:07Z | Scottmitch | val |
netty/netty/4600_4618 | netty/netty | netty/netty/4600 | netty/netty/4618 | [
"timestamp(timedelta=4.0, similarity=0.9201898721503884)"
] | f22ad97cf30c63c0d93d7c40541da10a4de66f5f | cd5093db358a07bd8178928fe23b4eac1b1df474 | [
"@louiscryan @nmittler @ejona86 - I checked in gRPC and it looks like this is still not being used? Is the plan still to use this or eventually consume the stream writability changes?\n",
"So far it has not proven critical to performance and there are other perf improvements I would prioritize in GRPC above the u... | [] | 2015-12-22T19:25:14Z | [
"cleanup"
] | HTTP/2 RemoteFlowController$Listener.streamWritten | We should evaluate whether [Http2RemoteFlowController$Listener.streamWritten](https://github.com/netty/netty/blob/4.1/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2RemoteFlowController.java#L151) is necessary. If not we should remove it.
| [
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2RemoteFlowController.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/Http2RemoteFlowController.java"
] | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2RemoteFlowController.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/Http2RemoteFlowController.java"
] | [
"codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2RemoteFlowControllerTest.java"
] | diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2RemoteFlowController.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2RemoteFlowController.java
index 2db3e708652..c99f86d6278 100644
--- a/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2RemoteFl... | diff --git a/codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2RemoteFlowControllerTest.java b/codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2RemoteFlowControllerTest.java
index c98dfd0b7d1..58742311dd2 100644
--- a/codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2... | train | train | 2015-12-22T09:20:32 | 2015-12-18T19:07:27Z | Scottmitch | val |
netty/netty/4604_4619 | netty/netty | netty/netty/4604 | netty/netty/4619 | [
"timestamp(timedelta=27.0, similarity=0.8533197798933183)"
] | 7b2f55ec2fa83873c4eeacb7fbccaecfedece63e | c56b712767c97b4c9847eea21cd0c89e9008113b | [
"Sounds like an issue with loading the jni stuff. Can you show me how you specify the dependencies ?\n",
"```\n <dependency>\n <groupId>io.netty</groupId>\n <artifactId>netty-all</artifactId>\n <version>5.0.0.Alpha2</version>\n <scope>test</scope>\n </dependency>\n```\n\nit works if I co... | [
"consider making this a member variable and using a `@Before` to initialize and `@After` to tear it down.\n"
] | 2015-12-22T19:32:58Z | [
"defect"
] | isKeepAlive is not supported by Epoll | Calling isKeepAlive throws an exception
```
java.lang.UnsatisfiedLinkError: io.netty.channel.epoll.Native.isKeepAlive(I)I
at io.netty.channel.epoll.Native.isKeepAlive(Native Method)
at io.netty.channel.epoll.EpollSocketChannelConfig.isKeepAlive(EpollSocketChannelConfig.java:154)
```
| [
"transport-native-epoll/src/main/c/io_netty_channel_unix_Socket.c",
"transport-native-epoll/src/main/c/io_netty_channel_unix_Socket.h"
] | [
"transport-native-epoll/src/main/c/io_netty_channel_unix_Socket.c",
"transport-native-epoll/src/main/c/io_netty_channel_unix_Socket.h"
] | [
"transport-native-epoll/src/test/java/io/netty/channel/unix/SocketTest.java"
] | diff --git a/transport-native-epoll/src/main/c/io_netty_channel_unix_Socket.c b/transport-native-epoll/src/main/c/io_netty_channel_unix_Socket.c
index 60d7c4bc752..2800a69075e 100644
--- a/transport-native-epoll/src/main/c/io_netty_channel_unix_Socket.c
+++ b/transport-native-epoll/src/main/c/io_netty_channel_unix_Sock... | diff --git a/transport-native-epoll/src/test/java/io/netty/channel/unix/SocketTest.java b/transport-native-epoll/src/test/java/io/netty/channel/unix/SocketTest.java
new file mode 100644
index 00000000000..0fe9df0f385
--- /dev/null
+++ b/transport-native-epoll/src/test/java/io/netty/channel/unix/SocketTest.java
@@ -0,0 ... | train | train | 2015-12-23T01:59:40 | 2015-12-18T22:02:30Z | vrozov | val |
netty/netty/2973_4631 | netty/netty | netty/netty/2973 | netty/netty/4631 | [
"timestamp(timedelta=32.0, similarity=0.8424088020104541)"
] | 6ee5341cdfa397a7b2ca123b0f8a5f3170133429 | cd7371f18b8d5483c1fc5b94d1061eb4611344c6 | [
"@Scottmitch is this still valid ?\n",
"@normanmaurer - I think so. I have not done anything to fix it.\n",
"Fixed\n"
] | [
"can you explain why we need an array?\n",
"check `if (!timeout[0].isDone()) {..}` before adding the object?\n",
"I wonder if we need to keep a collection of timeouts. Because the time is fixed, each new event will alway fire later (in time) than the previous event. Can we just keep a reference to the \"last\" ... | 2015-12-28T08:45:04Z | [
"defect"
] | WriteTimeoutHandler missed cleanup | It seems like the `WriteTimeoutHandler` does not always cancel the timeout task it schedules in all the same cases that the and IdleStateHandler does. For example the `handlerRemoved` method is not overridden in `WrtieTimeoutHandler`. There may be other cases where the timeout is not canceled when it should be and fu... | [
"handler/src/main/java/io/netty/handler/timeout/WriteTimeoutHandler.java"
] | [
"handler/src/main/java/io/netty/handler/timeout/WriteTimeoutHandler.java"
] | [] | diff --git a/handler/src/main/java/io/netty/handler/timeout/WriteTimeoutHandler.java b/handler/src/main/java/io/netty/handler/timeout/WriteTimeoutHandler.java
index 4e87c7f17c0..d47760a857e 100644
--- a/handler/src/main/java/io/netty/handler/timeout/WriteTimeoutHandler.java
+++ b/handler/src/main/java/io/netty/handler/... | null | train | train | 2015-12-29T18:56:29 | 2014-10-07T01:31:46Z | Scottmitch | val |
netty/netty/4315_4639 | netty/netty | netty/netty/4315 | netty/netty/4639 | [
"timestamp(timedelta=48.0, similarity=0.8704097078767499)"
] | f90032933df8b27e8542fdeb40fb6381f2062563 | 72eb6fb85151373f9187be5d91ee6b542b587fc6 | [
"If you can make it with breakage use 4.0\n\n> Am 05.10.2015 um 17:36 schrieb Stephane Landelle notifications@github.com:\n> \n> Netty version: 4.0.32.Final\n> \n> Context:\n> In AHC, we have our own builder for requests, where we internally store headers into a HttpHeaders instance.\n> \n> Sadly, there's no way to... | [
"ObjectUtils.checkNonNull(...)\n",
"Replace with ObjectUtils.checkNonNull(...)\n",
"the getStatus -> the status\n",
"getMethod -> method\n"
] | 2015-12-30T21:49:55Z | [
"improvement"
] | Add DefaultHttpMessage constructor that takes a HttpHeaders instance | Netty version: 4.0.32.Final
Context:
In AHC, we have our own builder for requests, where we internally store headers into a `HttpHeaders` instance.
Sadly, there's no way to directly pass a `HttpHeaders` instance to `DefaultHttpMessage` hierarchy and we have to set our instance into the `DefaultHttpMessage`'s internal... | [
"codec-http/src/main/java/io/netty/handler/codec/http/DefaultFullHttpRequest.java",
"codec-http/src/main/java/io/netty/handler/codec/http/DefaultFullHttpResponse.java",
"codec-http/src/main/java/io/netty/handler/codec/http/DefaultHttpMessage.java",
"codec-http/src/main/java/io/netty/handler/codec/http/Default... | [
"codec-http/src/main/java/io/netty/handler/codec/http/DefaultFullHttpRequest.java",
"codec-http/src/main/java/io/netty/handler/codec/http/DefaultFullHttpResponse.java",
"codec-http/src/main/java/io/netty/handler/codec/http/DefaultHttpMessage.java",
"codec-http/src/main/java/io/netty/handler/codec/http/Default... | [] | diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/DefaultFullHttpRequest.java b/codec-http/src/main/java/io/netty/handler/codec/http/DefaultFullHttpRequest.java
index 2ca9329e7c6..285763e5448 100644
--- a/codec-http/src/main/java/io/netty/handler/codec/http/DefaultFullHttpRequest.java
+++ b/codec-http/s... | null | test | train | 2015-12-30T18:31:55 | 2015-10-05T15:36:23Z | slandelle | val |
netty/netty/4679_4681 | netty/netty | netty/netty/4679 | netty/netty/4681 | [
"timestamp(timedelta=38.0, similarity=0.9066869632289366)"
] | 5c05629da1bc9022a053a7dce697a1b33b81bfd4 | 9c795965435da0441f26d990db7694ebd8868d7c | [
"will have a look\n",
"Fixed in #4681\n",
"@valodzka could you test with latest 4.0 branch: \n\nThis test works for me:\n\n```\n\n @Test\n public void testToStringComposite() {\n CompositeByteBuf cBuff = compositeBuffer();\n cBuff.addComponent(buffer(8).writeLong(0));\n cBuff.addCompo... | [
"Can you use a more descriptive test name? something like `testToStringDoesNotThrowIndexOutOfBounds`\n"
] | 2016-01-09T00:03:34Z | [
"defect"
] | IndexOutOfBoundsException for CompositeByteBuf | This code worked up to netty 4.0.32, but stopped in 4.0.33.Final
```
ByteBufAllocator alloc = ByteBufAllocator.DEFAULT;
CompositeByteBuf cBuff = alloc.compositeDirectBuffer();
cBuff.addComponent(alloc.buffer(8).writeLong(0));
cBuff.addComponent(alloc.buffer(8).writeLong(0));
// work as expected
... | [
"buffer/src/main/java/io/netty/buffer/ByteBufUtil.java"
] | [
"buffer/src/main/java/io/netty/buffer/ByteBufUtil.java"
] | [
"buffer/src/test/java/io/netty/buffer/ByteBufUtilTest.java"
] | diff --git a/buffer/src/main/java/io/netty/buffer/ByteBufUtil.java b/buffer/src/main/java/io/netty/buffer/ByteBufUtil.java
index 1644ab3165f..44fc52eaa6e 100644
--- a/buffer/src/main/java/io/netty/buffer/ByteBufUtil.java
+++ b/buffer/src/main/java/io/netty/buffer/ByteBufUtil.java
@@ -548,7 +548,7 @@ static String decod... | diff --git a/buffer/src/test/java/io/netty/buffer/ByteBufUtilTest.java b/buffer/src/test/java/io/netty/buffer/ByteBufUtilTest.java
index 0309db57ec3..f3bcebef184 100644
--- a/buffer/src/test/java/io/netty/buffer/ByteBufUtilTest.java
+++ b/buffer/src/test/java/io/netty/buffer/ByteBufUtilTest.java
@@ -187,4 +187,17 @@ pr... | train | train | 2016-01-09T03:12:31 | 2016-01-08T21:31:03Z | valodzka | val |
netty/netty/4677_4683 | netty/netty | netty/netty/4677 | netty/netty/4683 | [
"timestamp(timedelta=96943.0, similarity=0.8577363022834855)"
] | 6fe0db4001ebb9801705f6f3ca8911ff5fd5fe1e | cc873fa6c998ec76a00faa3d021b4f44aa71fd1b | [
"> the DefaultFullHttpResponse implements LastHttpContent, after encode any of DefaultFullHttpResponse msg, HttpObjectEncoder#encodeChunkedContent will reset state to ST_INIT, then rest msg can not be encoded.\n\nI think this is the expected behaviour since it's a completed http message.\n",
"in `HttpStaticFileSe... | [] | 2016-01-09T07:57:22Z | [] | HttpObjectEncoder can not encode chunked response | I'm tring HttpStaticFileServer with netty `5.0.0.Alpha2`, but not work, and I find that has two issues.
1. the `DefaultFullHttpResponse` implements `LastHttpContent`, after encode any of `DefaultFullHttpResponse` msg, `HttpObjectEncoder#encodeChunkedContent` will reset `state` to `ST_INIT`, then rest msg can not be enc... | [
"example/src/main/java/io/netty/example/http/file/HttpStaticFileServerHandler.java"
] | [
"example/src/main/java/io/netty/example/http/file/HttpStaticFileServerHandler.java"
] | [] | diff --git a/example/src/main/java/io/netty/example/http/file/HttpStaticFileServerHandler.java b/example/src/main/java/io/netty/example/http/file/HttpStaticFileServerHandler.java
index b2a4f33b3b0..f40962f720b 100644
--- a/example/src/main/java/io/netty/example/http/file/HttpStaticFileServerHandler.java
+++ b/example/s... | null | train | train | 2016-01-09T04:11:57 | 2016-01-08T15:04:37Z | cpf624 | val |
netty/netty/4017_4713 | netty/netty | netty/netty/4017 | netty/netty/4713 | [
"timestamp(timedelta=38.0, similarity=0.8717868222015914)"
] | 4d854cc1496ab3397cad543e0a0557efe1106f0c | 84d3ad5b6f22654ca431b7a8a87ce278df7f7875 | [
"@normanmaurer @trustin - Any thoughts?\n",
"+1 thanks for creating @Scottmitch \n",
"@Scottmitch +1\n",
"@Scottmitch +1\n",
"@nmittler - Looks like we have our answer :) I'll take the assignment for now so it doesn't get dropped...feel free to take it though.\n",
"@Scottmitch FYI this isn't a super high... | [
"Can the level change? If not, would it be make sense to save off some sort of allocator for the leak aware buffers?\n",
"Yes it can change\n",
"Since you're sharing this now, would it make sense to move this to some sort of common util class? It seems to be the only thing that uses `ACQUIRE_AND_RELEASE_ONLY`, ... | 2016-01-14T19:10:34Z | [
"improvement",
"feature"
] | CompositeByteBuf leak detector design pattern different from other ByteBuf implementations | The `CompositeByteBuf` implementation has a `ResourceLeak` member variable and other `ByteBuf` implementations rely on the `ByteBufAllocator` (particularly `AbstractByteBufAllocator`) to wrap the object and provide simple/advanced levels of leak detection. Is there a reason why `CompositeByteBuf` needs to be different... | [
"buffer/src/main/java/io/netty/buffer/AbstractByteBufAllocator.java",
"buffer/src/main/java/io/netty/buffer/AbstractReferenceCountedByteBuf.java",
"buffer/src/main/java/io/netty/buffer/AdvancedLeakAwareByteBuf.java",
"buffer/src/main/java/io/netty/buffer/CompositeByteBuf.java",
"buffer/src/main/java/io/nett... | [
"buffer/src/main/java/io/netty/buffer/AbstractByteBufAllocator.java",
"buffer/src/main/java/io/netty/buffer/AbstractReferenceCountedByteBuf.java",
"buffer/src/main/java/io/netty/buffer/AdvancedLeakAwareByteBuf.java",
"buffer/src/main/java/io/netty/buffer/AdvancedLeakAwareCompositeByteBuf.java",
"buffer/src/... | [] | diff --git a/buffer/src/main/java/io/netty/buffer/AbstractByteBufAllocator.java b/buffer/src/main/java/io/netty/buffer/AbstractByteBufAllocator.java
index 7cb54c1365a..50d82e2512d 100644
--- a/buffer/src/main/java/io/netty/buffer/AbstractByteBufAllocator.java
+++ b/buffer/src/main/java/io/netty/buffer/AbstractByteBufAl... | null | train | train | 2016-01-14T07:19:23 | 2015-07-22T01:39:45Z | Scottmitch | val |
netty/netty/4699_4731 | netty/netty | netty/netty/4699 | netty/netty/4731 | [
"timestamp(timedelta=66518.0, similarity=0.8475097645824541)"
] | ae4e9ddc2d66f23c3cad6f8adeed72392aae67da | f8db04adf4104b0c81993903c3db51071d20c7ec | [
"@lw346 could you please comment ? \n",
"I guess he meant any number `&` with `0x3F` (63) must be less than 64.\n",
"Fixed in #4731\n"
] | [
"Removed `private` to call it in test\n",
"Removed `private` to call it in test\n",
"`decoded` and `Unpooled.wrappedBuffer(...)` need to be released.\n",
"+1\n",
"Just call ByteBuf.release() ?\n",
"just call `in.release()`?\n",
"@normanmaurer - +1 :wink: \n"
] | 2016-01-19T23:23:21Z | [] | Snappy.java's decodeLiteral method implemention | ``` java
private static int decodeLiteral(byte tag, ByteBuf in, ByteBuf out) {
in.markReaderIndex();
int length;
switch(tag >> 2 & 0x3F) {
case 60:
if (!in.isReadable()) {
return NOT_ENOUGH_INPUT;
}
length = in.readUnsignedByte();
... | [
"codec/src/main/java/io/netty/handler/codec/compression/Snappy.java"
] | [
"codec/src/main/java/io/netty/handler/codec/compression/Snappy.java"
] | [
"codec/src/test/java/io/netty/handler/codec/compression/SnappyTest.java"
] | diff --git a/codec/src/main/java/io/netty/handler/codec/compression/Snappy.java b/codec/src/main/java/io/netty/handler/codec/compression/Snappy.java
index 39ec873dc8d..df4e88a0821 100644
--- a/codec/src/main/java/io/netty/handler/codec/compression/Snappy.java
+++ b/codec/src/main/java/io/netty/handler/codec/compression... | diff --git a/codec/src/test/java/io/netty/handler/codec/compression/SnappyTest.java b/codec/src/test/java/io/netty/handler/codec/compression/SnappyTest.java
index 0ac3d6574c9..84b5e068362 100644
--- a/codec/src/test/java/io/netty/handler/codec/compression/SnappyTest.java
+++ b/codec/src/test/java/io/netty/handler/codec... | val | train | 2016-01-20T19:56:24 | 2016-01-13T08:16:33Z | johnsonma | val |
netty/netty/4738_4742 | netty/netty | netty/netty/4738 | netty/netty/4742 | [
"timestamp(timedelta=12.0, similarity=0.9466880115333267)"
] | d1ef33b8f419ac8ae591e864df2cdd24b36ef765 | 7e1387333eaa45ed15c0ba5e01ced0c4d6de18f1 | [
"@normanmaurer @trustin - Any objections?\n",
"@ejona86 works for me. Please open a pr\n"
] | [] | 2016-01-21T21:43:10Z | [
"feature"
] | Add ChannelHandlerContext.invoker() to 4.1 | The now-defunct 5.0 had a [ChannelHandlerContext.invoker()](https://github.com/netty/netty/blob/master_deprecated/transport/src/main/java/io/netty/channel/ChannelHandlerContext.java#L148) method. I found it to be useful, and the method is already implemented; it just needs to be exposed on the interface. It's my unders... | [
"microbench/src/main/java/io/netty/microbench/channel/EmbeddedChannelWriteReleaseHandlerContext.java",
"transport/src/main/java/io/netty/channel/AbstractChannelHandlerContext.java",
"transport/src/main/java/io/netty/channel/ChannelHandlerContext.java",
"transport/src/main/java/io/netty/channel/CombinedChannel... | [
"microbench/src/main/java/io/netty/microbench/channel/EmbeddedChannelWriteReleaseHandlerContext.java",
"transport/src/main/java/io/netty/channel/AbstractChannelHandlerContext.java",
"transport/src/main/java/io/netty/channel/ChannelHandlerContext.java",
"transport/src/main/java/io/netty/channel/CombinedChannel... | [] | diff --git a/microbench/src/main/java/io/netty/microbench/channel/EmbeddedChannelWriteReleaseHandlerContext.java b/microbench/src/main/java/io/netty/microbench/channel/EmbeddedChannelWriteReleaseHandlerContext.java
index b8984ea488d..9a74f98d97d 100644
--- a/microbench/src/main/java/io/netty/microbench/channel/Embedded... | null | test | train | 2016-01-21T09:59:10 | 2016-01-21T00:47:22Z | ejona86 | val |
netty/netty/4752_4753 | netty/netty | netty/netty/4752 | netty/netty/4753 | [
"timestamp(timedelta=46.0, similarity=0.8595048383618223)"
] | 1c417e5f8264271f785c18972a55d9e216d1b20b | 5c53230996b200bf2494b3f9e8f0b2f4a46c3ca4 | [] | [] | 2016-01-26T01:57:30Z | [] | Javadoc Fail: ChannelOutboundHandlerAdapter - deregister (4.1) | The description of the method `deregister` in the class ChannelOutboundHandlerAdapter says:
> Calls **ChannelHandlerContext.close(ChannelPromise)** to forward to the next ChannelOutboundHandler in the ChannelPipeline. Sub-classes may override this method to change behavior.
Should it not be the following?
> Calls **... | [
"transport/src/main/java/io/netty/channel/ChannelOutboundHandlerAdapter.java"
] | [
"transport/src/main/java/io/netty/channel/ChannelOutboundHandlerAdapter.java"
] | [] | diff --git a/transport/src/main/java/io/netty/channel/ChannelOutboundHandlerAdapter.java b/transport/src/main/java/io/netty/channel/ChannelOutboundHandlerAdapter.java
index c0a68971237..fa968925de9 100644
--- a/transport/src/main/java/io/netty/channel/ChannelOutboundHandlerAdapter.java
+++ b/transport/src/main/java/io/... | null | train | train | 2016-01-21T15:35:55 | 2016-01-25T22:59:24Z | mickare | val |
netty/netty/4760_4761 | netty/netty | netty/netty/4760 | netty/netty/4761 | [
"timestamp(timedelta=87.0, similarity=0.9265861370024806)"
] | c3e5604f59e0c6354dd6458fb62e5b83edadbda2 | 260c2cd3f2c1678e6a8b2b23556a2fb284ab3347 | [
"/cc @normanmaurer @nmittler @trustin \n",
"@trustin ping again\n"
] | [
"unused import ?\n",
"ReferenceCountUtil.safeRelease(...) ?\n",
"see above\n",
"I was just anticipating your next comments :wink: \n",
"I originally had this, but figured we could avoid the instanceof check and casting by the simple `try/catch` block.\n"
] | 2016-01-27T02:23:30Z | [
"defect"
] | CompositeByteBuf.addComponent ownership clarification | If all goes well `CompositeByteBuf.addComponent` will take "ownership" (will call `release()`) of the parameter. However there are cases where this is not the case. For example if the `CompositeByteBuf` has been released `addComponent` may throw an `IllegalReferenceCountException` and not release the parameter. At the ... | [
"buffer/src/main/java/io/netty/buffer/CompositeByteBuf.java"
] | [
"buffer/src/main/java/io/netty/buffer/CompositeByteBuf.java"
] | [] | diff --git a/buffer/src/main/java/io/netty/buffer/CompositeByteBuf.java b/buffer/src/main/java/io/netty/buffer/CompositeByteBuf.java
index 262b229c327..be2ce7917f5 100644
--- a/buffer/src/main/java/io/netty/buffer/CompositeByteBuf.java
+++ b/buffer/src/main/java/io/netty/buffer/CompositeByteBuf.java
@@ -33,6 +33,8 @@
... | null | train | train | 2016-01-29T08:00:46 | 2016-01-26T19:36:50Z | Scottmitch | val |
netty/netty/4573_4763 | netty/netty | netty/netty/4573 | netty/netty/4763 | [
"timestamp(timedelta=7.0, similarity=0.8969352858274092)"
] | ca305d86fb45a40ad03a2e7270d58da65eb4aa06 | 96a4cfe760f2d47958beeb1e16a6b8de096ca16c | [
"@louiscryan - makes sense.\n",
"@louiscryan - Any updates on this? It would be nice to get this in before the next release. I can take over if you don't have cycles.\n",
"@louiscryan - I'll take this over for now. We can improve tests later.\n",
"Sorry Scott. Let me dig up my PR tomorrow and at least send th... | [
"Why wouldn't we just increment by frame.size()? Is the padding not merged?\n",
"The padding is currently not necessarily additive when a merge occurs. It is currently taken as `max`.\n\nSee https://github.com/netty/netty/issues/4573 for details too.\n",
"@nmittler - PTAL. This is to address https://github.com... | 2016-01-27T02:25:35Z | [
"defect"
] | HTTP2 padding merging breaks flow control | @Scottmitch
@nmittler
In DefaultHttp2Controller.enqueueFrame we increment the pendingBytes based on the size of the frame passed regardless of whether it was merged. Since merging uses padding = max(padding, new.padding) the number of bytes added to the merged frame may be less than newFrame.size().
This eventually... | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionEncoder.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2RemoteFlowController.java"
] | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionEncoder.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2RemoteFlowController.java"
] | [
"codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2RemoteFlowControllerTest.java"
] | diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionEncoder.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionEncoder.java
index f3435061360..8c5718a3713 100644
--- a/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionEnco... | diff --git a/codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2RemoteFlowControllerTest.java b/codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2RemoteFlowControllerTest.java
index 58742311dd2..d7f26f58765 100644
--- a/codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2... | test | train | 2016-01-27T18:55:43 | 2015-12-16T02:53:22Z | louiscryan | val |
netty/netty/4755_4769 | netty/netty | netty/netty/4755 | netty/netty/4769 | [
"timestamp(timedelta=23.0, similarity=0.8896217346671011)"
] | ee2558bdf3a27871a3fb61a02b48aa6850bcb5ca | b2a5bf8a7fd28600f40d6d7f9ccf54c25a1cea02 | [
"@mrniko you are right... I will fix it. In the meantime just create a new instance everytime.\n",
"@mrniko PTAL https://github.com/netty/netty/pull/4769\n",
"@normanmaurer PTAL ? Sorry, what? :)\n",
"@mrniko Please take a look ;) \n",
"@mrniko actually only WebSocketClientCompressionHandler can be `@Sharab... | [
"What is the need for the `INSTANCE` member if it can't be reused and the constructor is public?\n",
"ups sorry missed to remove it ... \n"
] | 2016-01-27T08:06:13Z | [
"improvement"
] | Add @Sharable annotation to WebSocketClientCompressionHandler | Netty version: netty-4.1.0.CR1
Unable to use WebSocketServerCompressionHandler and WebSocketServerCompressionHandler handlers as single instances. Because of absence of @Sharable annotation.
| [
"codec-http/src/main/java/io/netty/handler/codec/http/websocketx/extensions/compression/WebSocketClientCompressionHandler.java",
"example/src/main/java/io/netty/example/http/websocketx/client/WebSocketClient.java"
] | [
"codec-http/src/main/java/io/netty/handler/codec/http/websocketx/extensions/compression/WebSocketClientCompressionHandler.java",
"example/src/main/java/io/netty/example/http/websocketx/client/WebSocketClient.java"
] | [] | diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/websocketx/extensions/compression/WebSocketClientCompressionHandler.java b/codec-http/src/main/java/io/netty/handler/codec/http/websocketx/extensions/compression/WebSocketClientCompressionHandler.java
index 3596ab658fa..bfd0375accf 100644
--- a/codec-htt... | null | train | train | 2016-01-28T08:55:28 | 2016-01-26T11:19:46Z | mrniko | val |
netty/netty/4705_4772 | netty/netty | netty/netty/4705 | netty/netty/4772 | [
"timestamp(timedelta=65338.0, similarity=0.8604314867155635)"
] | bed84dde7a0e174abe684ba3ba2e7270c64204ef | f25342cdb235661d5c51c6c8c4b4b815dd1c8e93 | [
"Fixed in #4706\n",
"Corresponding Jython bug: http://bugs.jython.org/issue2401 - we should be able to build shortly, then Nick can see if he reproduce in his environment\n",
"Can we also merge this into 4.0?\n",
"This will need a more general fix... Looking into it now.\n\nAs workaround you can add a task o ... | [] | 2016-01-27T14:27:35Z | [
"defect"
] | Race condition in SslHandler | Originally a thread on the mailing list: https://groups.google.com/forum/#!topic/netty/h2ulbfw3uF8
(using Netty 4.0.33, via jython 2.7.1)
I'm wondering if this is a race condition/bug within netty itself or perhaps just a misuse of netty. I'm seeing the following stack trace intermittently when dealing with ssl socke... | [
"src/main/java/org/jboss/netty/handler/ssl/SslHandler.java"
] | [
"src/main/java/org/jboss/netty/handler/ssl/SslHandler.java"
] | [] | diff --git a/src/main/java/org/jboss/netty/handler/ssl/SslHandler.java b/src/main/java/org/jboss/netty/handler/ssl/SslHandler.java
index 25ff7659f98..b5b1d1d6367 100644
--- a/src/main/java/org/jboss/netty/handler/ssl/SslHandler.java
+++ b/src/main/java/org/jboss/netty/handler/ssl/SslHandler.java
@@ -1005,8 +1005,9 @@ p... | null | train | train | 2015-10-13T12:09:11 | 2016-01-13T22:13:45Z | nickmbailey | val |
netty/netty/4746_4791 | netty/netty | netty/netty/4746 | netty/netty/4791 | [
"timestamp(timedelta=21.0, similarity=0.8585134029208575)"
] | a06708f81bc69ae6fbbe2638b25e7eee922f5efc | bd290e904f44553366085a4589f217302cff2c47 | [
"@jknair I think this is the same issue as :\n\nhttps://github.com/netty/netty/issues/4722\n\nLooking into it atm.\n",
"@jknair can you share a \"full\" reproducer ?\n",
"sorry for the delay, I will try to make one. Problem is I cant find any SNI enabled public host that will fail the handshake \n",
"@jknair ... | [] | 2016-01-29T19:43:07Z | [
"defect"
] | Enabling SNI, OpenSSL client from netty does not work | Netty version : 4.1 - ff11fe8 also tried with netty-4.1.0.Beta8
When trying to connect to a host with SNI enabled from the netty openssl client, handshake fails as :
```
OpenSSL error: error:14077410:SSL routines:SSL23_GET_SERVER_HELLO:sslv3 alert handshake failure
```
same issue when you use the openssl s_client :
... | [
"handler/src/main/java/io/netty/handler/ssl/OpenSslEngine.java",
"pom.xml"
] | [
"handler/src/main/java/io/netty/handler/ssl/OpenSslEngine.java",
"pom.xml"
] | [
"handler/src/test/java/io/netty/handler/ssl/SniClientTest.java"
] | diff --git a/handler/src/main/java/io/netty/handler/ssl/OpenSslEngine.java b/handler/src/main/java/io/netty/handler/ssl/OpenSslEngine.java
index d70c9525443..0644023ee7b 100644
--- a/handler/src/main/java/io/netty/handler/ssl/OpenSslEngine.java
+++ b/handler/src/main/java/io/netty/handler/ssl/OpenSslEngine.java
@@ -222... | diff --git a/handler/src/test/java/io/netty/handler/ssl/SniClientTest.java b/handler/src/test/java/io/netty/handler/ssl/SniClientTest.java
new file mode 100644
index 00000000000..2af2da48b12
--- /dev/null
+++ b/handler/src/test/java/io/netty/handler/ssl/SniClientTest.java
@@ -0,0 +1,104 @@
+/*
+ * Copyright 2016 The Ne... | train | train | 2016-02-02T21:43:38 | 2016-01-22T16:08:35Z | jknair | val |
netty/netty/4828_4843 | netty/netty | netty/netty/4828 | netty/netty/4843 | [
"timestamp(timedelta=36.0, similarity=0.8991627586810774)"
] | 027e8224e41f85cc125bf1d69f15c342c997ccac | 885dffa64cdc4e7aaa2402b81208ffeefb20d0a7 | [
"@floragunncom which java version and java brand ?\n",
"Oracle 1.8.0_45 on Mac OS Yosemite\n\njava version \"1.8.0_45\"\nJava(TM) SE Runtime Environment (build 1.8.0_45-b14)\nJava HotSpot(TM) 64-Bit Server VM (build 25.45-b02, mixed mode)\n\nI need to create a new Open SSL Engine and i do it with:\n\n<pre>\nsslCo... | [] | 2016-02-05T07:05:29Z | [
"defect"
] | OpenSslContext throws UnsupportedOperationException when Unsafe not available | Netty 4.0.34.Final on OS X, Unsafe not available due to SecurityManager and restrictive policy file.
So this warning is issued: "[io.netty.util.internal.PlatformDependent] Your platform does not provide complete low-level API for accessing direct buffers reliably. Unless explicitly requested, heap buffer will always b... | [
"handler/src/main/java/io/netty/handler/ssl/OpenSsl.java",
"handler/src/main/java/io/netty/handler/ssl/OpenSslContext.java",
"handler/src/main/java/io/netty/handler/ssl/OpenSslEngine.java"
] | [
"handler/src/main/java/io/netty/handler/ssl/OpenSsl.java",
"handler/src/main/java/io/netty/handler/ssl/OpenSslContext.java",
"handler/src/main/java/io/netty/handler/ssl/OpenSslEngine.java"
] | [] | diff --git a/handler/src/main/java/io/netty/handler/ssl/OpenSsl.java b/handler/src/main/java/io/netty/handler/ssl/OpenSsl.java
index 619768aa67a..4b67ead89fc 100644
--- a/handler/src/main/java/io/netty/handler/ssl/OpenSsl.java
+++ b/handler/src/main/java/io/netty/handler/ssl/OpenSsl.java
@@ -16,9 +16,11 @@
package i... | null | train | train | 2016-02-04T15:34:06 | 2016-02-03T18:47:57Z | floragunn | val |
netty/netty/4834_4844 | netty/netty | netty/netty/4834 | netty/netty/4844 | [
"timestamp(timedelta=19.0, similarity=0.8923300350807587)"
] | 75a2ddd61c3df0b7a1e6db1cc5c588177b24c3cf | 4198a453b43c1a19a0f1d968e27f25e627c65caf | [
"cc: @nmittler & @normanmaurer\n",
"Why not use a CHMv8 here? It seems the original concern was `AddressResolver` instantiation cost, but that's what `computeIfAbsent` is for. This would let us remove all the synchronized blocks.\n",
"Because it's java8 only... Will fix the race though\n\n> Am 03.02.2016 um 23:... | [] | 2016-02-05T07:06:20Z | [
"defect"
] | Race in AddressResolverGroup | https://github.com/netty/netty/blob/4.1/resolver/src/main/java/io/netty/resolver/AddressResolverGroup.java
Here, `resolvers` is synchronized when calling .get(), but not in the future callback `resolvers.remove(executor);`
| [
"resolver/src/main/java/io/netty/resolver/AddressResolverGroup.java"
] | [
"resolver/src/main/java/io/netty/resolver/AddressResolverGroup.java"
] | [] | diff --git a/resolver/src/main/java/io/netty/resolver/AddressResolverGroup.java b/resolver/src/main/java/io/netty/resolver/AddressResolverGroup.java
index 89b00dfa044..509475eb3ea 100644
--- a/resolver/src/main/java/io/netty/resolver/AddressResolverGroup.java
+++ b/resolver/src/main/java/io/netty/resolver/AddressResolv... | null | train | train | 2016-02-04T16:51:44 | 2016-02-03T21:44:39Z | carl-mastrangelo | val |
netty/netty/4835_4852 | netty/netty | netty/netty/4835 | netty/netty/4852 | [
"timestamp(timedelta=33.0, similarity=0.917887492488813)"
] | 61f812ea2a38fe20845ae72cbee8729606e01aa3 | 9180686bac28a7f5c64ffdd03f758e3b529d4015 | [
"sgtm\n",
"Fixed in #4852\n",
"Thanks for the patch @windie !\n"
] | [] | 2016-02-06T00:55:08Z | [
"defect"
] | CorsConfigBuilder allowNullOrigin method should be public instead of package private | Netty version: 4.1.0-CR1
Class:
io.netty.handler.codec.http.cors.CorsConfigBuilder
Method:
method "allowNullOrigin" should be public but it is package private (no modifier)
| [
"codec-http/src/main/java/io/netty/handler/codec/http/cors/CorsConfigBuilder.java"
] | [
"codec-http/src/main/java/io/netty/handler/codec/http/cors/CorsConfigBuilder.java"
] | [] | diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/cors/CorsConfigBuilder.java b/codec-http/src/main/java/io/netty/handler/codec/http/cors/CorsConfigBuilder.java
index 81e0a8a2137..52457b32317 100644
--- a/codec-http/src/main/java/io/netty/handler/codec/http/cors/CorsConfigBuilder.java
+++ b/codec-http/s... | null | val | train | 2016-02-05T23:39:55 | 2016-02-04T06:18:39Z | odbuser2 | val |
netty/netty/3435_4853 | netty/netty | netty/netty/3435 | netty/netty/4853 | [
"timestamp(timedelta=247.0, similarity=0.9668094919673911)"
] | a15ff32608f000b5b01ab00262f8b2df34b2d08c | 2649f999632d61d1b76b38f51652c9d22dbbedfa | [
"Thanks for capturing this issue @danbev!\n\nJust as #3271 added the ability to automatically combine and CSV escape values associated with the same header name; we should also add the ability to automatically unescape values returned by the accessor methods. For example `CharSequence get(Charsequence name)` in `D... | [
"++i would be better.\n",
"It doesn't look like the `or the value unchanged` is honored like in `escapeCsv`\n",
"Doesn't really matter. Javac generates the same bytes for both `i++` and `++i` if the return value is not used.\n",
"Fixed. Now just return the value if it's not escaped.\n",
"Remove the else\n",... | 2016-02-06T22:36:36Z | [
"improvement"
] | Add unescapeCsv method to StringUtil. | For the solution for #3237 involved adding a method named `escapeCsv` to StringUtil. We should also add the counter part of this, `unescapeCsv`, to StringUtil.
| [
"common/src/main/java/io/netty/util/internal/StringUtil.java"
] | [
"common/src/main/java/io/netty/util/internal/StringUtil.java"
] | [
"common/src/test/java/io/netty/util/internal/StringUtilTest.java"
] | diff --git a/common/src/main/java/io/netty/util/internal/StringUtil.java b/common/src/main/java/io/netty/util/internal/StringUtil.java
index 473ba597d1f..e60c734bb00 100644
--- a/common/src/main/java/io/netty/util/internal/StringUtil.java
+++ b/common/src/main/java/io/netty/util/internal/StringUtil.java
@@ -387,6 +387,... | diff --git a/common/src/test/java/io/netty/util/internal/StringUtilTest.java b/common/src/test/java/io/netty/util/internal/StringUtilTest.java
index 66229dacb17..3084094f00a 100644
--- a/common/src/test/java/io/netty/util/internal/StringUtilTest.java
+++ b/common/src/test/java/io/netty/util/internal/StringUtilTest.java... | test | train | 2016-02-08T06:23:29 | 2015-02-18T08:04:21Z | danbev | val |
netty/netty/4856_4857 | netty/netty | netty/netty/4856 | netty/netty/4857 | [
"timestamp(timedelta=10.0, similarity=0.9219346625170636)"
] | 36aa11937d661385461b4c1c488356347751e9f9 | 68bf2c1df4a87e8ac411c4d6383313dd96577624 | [
"@ejona86 - Thanks for reporting! See https://github.com/netty/netty/pull/4857\n"
] | [
"Wait ... is this right? I think we still need something here to make sure that the other endpoint doesn't know about the stream (see https://github.com/netty/netty/pull/4502). Or can we not get into `IDLE` via a remote-initiated stream?\n",
"#4502 was necessary because we used to queue the initial headers frames... | 2016-02-09T22:54:32Z | [
"defect"
] | http2: f990f99 broke sending RST_STREAM | In f990f99 (for #4758), Http2ConnectionHandler was changed from:
``` java
public ChannelFuture resetStream(...) {
...
if (stream.state() == IDLE || (connection().local().created(stream) && !stream.isHeaderSent())) {
// The other endpoint doesn't know about the stream yet, so we can't actually send
// the R... | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/Http2ConnectionHandler.java"
] | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/Http2ConnectionHandler.java"
] | [
"codec-http2/src/test/java/io/netty/handler/codec/http2/Http2ConnectionHandlerTest.java"
] | diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2ConnectionHandler.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2ConnectionHandler.java
index 8e98c3cfcd9..e8f92c14b70 100644
--- a/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2ConnectionHandler.java
+++ b/codec-... | diff --git a/codec-http2/src/test/java/io/netty/handler/codec/http2/Http2ConnectionHandlerTest.java b/codec-http2/src/test/java/io/netty/handler/codec/http2/Http2ConnectionHandlerTest.java
index 5dcd0ccbc18..c17cc4d8819 100644
--- a/codec-http2/src/test/java/io/netty/handler/codec/http2/Http2ConnectionHandlerTest.java
... | train | train | 2016-02-09T00:21:24 | 2016-02-09T19:52:25Z | ejona86 | val |
netty/netty/4838_4860 | netty/netty | netty/netty/4838 | netty/netty/4860 | [
"timestamp(timedelta=4.0, similarity=0.9871739659685546)"
] | cd56f87ca12664fdec3aba8b44ee425cac5cd4be | bf3a624cc5804be9e39e0f0805f4d11c4a06d3d3 | [
"@nmittler - FYI\n\nrelated to https://github.com/netty/netty/issues/4780#issuecomment-179849253\n",
"@Scottmitch yikes! Are you working on a patch?\n",
"@nmittler - I was planning on it, but haven't got around to it yet....does this one peek your interest?\n",
"pr pending\n"
] | [
"Why not just take a `ChannelPromise`?\n",
"Just curious ... not sure how Netty handles this case in general: what if `promise` is a void promise? If the caller tries to call `addListener` it will fail ... maybe we don't care, since they're the one that passed in the void promise?\n",
"Don't we have a light-wei... | 2016-02-10T23:51:03Z | [
"defect"
] | HTTP/2 codec may not always call Http2Connection$Listener.onStreamRemoved | If `Http2Connection$Listener.onStreamAdded` is called it is not always the case that `Http2Connection$Listener.onStreamRemoved` will be called. Some use cases (including `InboundHttp2ToHttpAdapter`) depend upon the `onStreamRemoved` method to be called in order to clean up allocated buffers.
[Http2ConnectionHandler.ch... | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2Connection.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/Http2Connection.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/Http2ConnectionHandler.java"
] | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2Connection.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/Http2Connection.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/Http2ConnectionHandler.java"
] | [
"codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionTest.java",
"codec-http2/src/test/java/io/netty/handler/codec/http2/Http2ConnectionHandlerTest.java"
] | diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2Connection.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2Connection.java
index 589546dbe1b..6dae971b4a5 100644
--- a/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2Connection.java
+++ b/codec-... | diff --git a/codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionTest.java b/codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionTest.java
index 2e68c39ff12..bb4ace388d9 100644
--- a/codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionTest.java
... | train | train | 2016-02-11T01:48:39 | 2016-02-04T13:58:06Z | Scottmitch | val |
netty/netty/4855_4862 | netty/netty | netty/netty/4855 | netty/netty/4862 | [
"timestamp(timedelta=44.0, similarity=0.8687496447467746)"
] | ccb08706003b4aed2a6a95d009f7fd736f723b23 | cac9134590198a9ea56fd275cd4730e5dac07ffb | [] | [
"maybe use some lower capacity as the default one ?\n",
"consider optimistically incrementing `i` here (`++i`) and decrement if found to be invalid `throw newInvalidEscapedCsvFieldException(value, i - 1);`\n"
] | 2016-02-11T04:33:14Z | [
"feature"
] | CombinedHttpHeaders unescape csv values | From https://github.com/netty/netty/issues/3435#issuecomment-74892285 (unescape was added by https://github.com/netty/netty/pull/4853) we should add unescape methods to [CombinedHttpHeaders](https://github.com/netty/netty/blob/4.1/codec-http/src/main/java/io/netty/handler/codec/http/CombinedHttpHeaders.java).
> Just a... | [
"codec-http/src/main/java/io/netty/handler/codec/http/CombinedHttpHeaders.java",
"common/src/main/java/io/netty/util/internal/StringUtil.java"
] | [
"codec-http/src/main/java/io/netty/handler/codec/http/CombinedHttpHeaders.java",
"common/src/main/java/io/netty/util/internal/StringUtil.java"
] | [
"codec-http/src/test/java/io/netty/handler/codec/http/CombinedHttpHeadersTest.java",
"common/src/test/java/io/netty/util/internal/StringUtilTest.java"
] | diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/CombinedHttpHeaders.java b/codec-http/src/main/java/io/netty/handler/codec/http/CombinedHttpHeaders.java
index 2c639176071..79c5fda97a0 100644
--- a/codec-http/src/main/java/io/netty/handler/codec/http/CombinedHttpHeaders.java
+++ b/codec-http/src/main/j... | diff --git a/codec-http/src/test/java/io/netty/handler/codec/http/CombinedHttpHeadersTest.java b/codec-http/src/test/java/io/netty/handler/codec/http/CombinedHttpHeadersTest.java
index 59ae6b544d9..6ec9bfaf36a 100644
--- a/codec-http/src/test/java/io/netty/handler/codec/http/CombinedHttpHeadersTest.java
+++ b/codec-htt... | test | train | 2016-02-15T05:37:37 | 2016-02-08T22:39:54Z | Scottmitch | val |
netty/netty/4881_4883 | netty/netty | netty/netty/4881 | netty/netty/4883 | [
"timestamp(timedelta=5583.0, similarity=0.8777541916621916)"
] | 41d0a816912f32ff0405882cca347682549a709d | 628cb284c87767ad377d75dfe43ed237fc0c6505 | [
"@marcuslinke because we not implemented it yet ;) I will take care... Thanks for reporting\n",
"Fixed by #4883\n"
] | [
"do we need this change ?\n",
"future -> promise\n",
"do we need this ?\n",
"do we need this ?\n",
"found another way, so don't need `public` anymore, fixed\n",
"done\n",
"no, fixed\n",
"no, fixed\n"
] | 2016-02-18T16:55:31Z | [
"feature"
] | 4.1.0.CR2: Missing shutdownOutput() method for EpollDomainSocketChannel | I wonder why there is no such public method? Is there any reason for that? I'm looking for an equivalent for `((NioSocketChannel)channel).shutdownOutput();`
See: https://github.com/docker-java/docker-java/issues/471
| [
"transport-native-epoll/src/main/java/io/netty/channel/epoll/AbstractEpollStreamChannel.java",
"transport-native-epoll/src/main/java/io/netty/channel/epoll/EpollSocketChannel.java",
"transport-native-epoll/src/main/java/io/netty/channel/unix/DomainSocketChannel.java",
"transport/src/main/java/io/netty/channel... | [
"transport-native-epoll/src/main/java/io/netty/channel/epoll/AbstractEpollStreamChannel.java",
"transport-native-epoll/src/main/java/io/netty/channel/epoll/EpollSocketChannel.java",
"transport-native-epoll/src/main/java/io/netty/channel/unix/DomainSocketChannel.java",
"transport/src/main/java/io/netty/channel... | [] | diff --git a/transport-native-epoll/src/main/java/io/netty/channel/epoll/AbstractEpollStreamChannel.java b/transport-native-epoll/src/main/java/io/netty/channel/epoll/AbstractEpollStreamChannel.java
index 612afce5efb..78aa2ef8009 100644
--- a/transport-native-epoll/src/main/java/io/netty/channel/epoll/AbstractEpollStre... | null | train | train | 2016-02-18T04:55:52 | 2016-02-18T15:45:48Z | marcuslinke | val |
netty/netty/4882_4883 | netty/netty | netty/netty/4882 | netty/netty/4883 | [
"timestamp(timedelta=7329.0, similarity=0.9337282066886308)"
] | 41d0a816912f32ff0405882cca347682549a709d | 628cb284c87767ad377d75dfe43ed237fc0c6505 | [
"@rtimush yes!\n",
"Duplicates https://github.com/netty/netty/issues/4881\n",
"Lets close this in favor of #4881 (reported first).\n"
] | [
"do we need this change ?\n",
"future -> promise\n",
"do we need this ?\n",
"do we need this ?\n",
"found another way, so don't need `public` anymore, fixed\n",
"done\n",
"no, fixed\n",
"no, fixed\n"
] | 2016-02-18T16:55:31Z | [
"duplicate"
] | shutdownOutput for EpollDomainSocketChannel | I see a protected `shutdownOutput0` method in `AbstractEpollStreamChannel` but there is no public `shutdownOutput` in `EpollDomainSocketChannel`.
I suppose `shutdownOutput` implementation from `EpollSocketChannel` can be moved to `AbstractEpollStreamChannel`:
``` java
@Override
public ChannelFuture shutdownO... | [
"transport-native-epoll/src/main/java/io/netty/channel/epoll/AbstractEpollStreamChannel.java",
"transport-native-epoll/src/main/java/io/netty/channel/epoll/EpollSocketChannel.java",
"transport-native-epoll/src/main/java/io/netty/channel/unix/DomainSocketChannel.java",
"transport/src/main/java/io/netty/channel... | [
"transport-native-epoll/src/main/java/io/netty/channel/epoll/AbstractEpollStreamChannel.java",
"transport-native-epoll/src/main/java/io/netty/channel/epoll/EpollSocketChannel.java",
"transport-native-epoll/src/main/java/io/netty/channel/unix/DomainSocketChannel.java",
"transport/src/main/java/io/netty/channel... | [] | diff --git a/transport-native-epoll/src/main/java/io/netty/channel/epoll/AbstractEpollStreamChannel.java b/transport-native-epoll/src/main/java/io/netty/channel/epoll/AbstractEpollStreamChannel.java
index 612afce5efb..78aa2ef8009 100644
--- a/transport-native-epoll/src/main/java/io/netty/channel/epoll/AbstractEpollStre... | null | train | train | 2016-02-18T04:55:52 | 2016-02-18T15:54:25Z | rtimush | val |
netty/netty/4892_4896 | netty/netty | netty/netty/4892 | netty/netty/4896 | [
"timestamp(timedelta=6182.0, similarity=0.9210339341556103)"
] | 5ce504070f20d6c8d356b92187f791e3eed0f8f4 | f31f158fbe0f4726a1a81bfb87cb825290cadbf9 | [
"@trustin will take care.\n",
"Thanks, @normanmaurer \n",
"Thank you very much!\n",
"@trustin and @normanmaurer I was trying to use the Snappy codec and it seems to me that the limit to the input `ByteBuf` is 36KB. Beyond this, the codec throws an `IndexOutOfBoundsException`. Is there an undocumented limit to... | [] | 2016-02-25T08:11:02Z | [
"feature"
] | Consider making Snappy class public | Maybe useful for users who want to use Snappy compression without handlers? (like Base64 in Netty)
https://groups.google.com/d/topic/netty/I8-M02b2ghg/discussion
| [
"codec/src/main/java/io/netty/handler/codec/compression/Snappy.java"
] | [
"codec/src/main/java/io/netty/handler/codec/compression/Snappy.java"
] | [] | diff --git a/codec/src/main/java/io/netty/handler/codec/compression/Snappy.java b/codec/src/main/java/io/netty/handler/codec/compression/Snappy.java
index df4e88a0821..9a02f3a0f3f 100644
--- a/codec/src/main/java/io/netty/handler/codec/compression/Snappy.java
+++ b/codec/src/main/java/io/netty/handler/codec/compression... | null | train | train | 2016-02-24T03:17:35 | 2016-02-23T09:57:56Z | trustin | val |
netty/netty/4909_4910 | netty/netty | netty/netty/4909 | netty/netty/4910 | [
"timestamp(timedelta=18.0, similarity=0.8591960005876418)"
] | 0bea10b0b064d7983a1422af792eeb70e511eac4 | 74de2411fad86255c149752d22479401e828c4d3 | [
"Sent a PR[1] to fix this.\n\n[1]. https://github.com/netty/netty/pull/4910\n",
"Fixed by https://github.com/netty/netty/pull/4910\n"
] | [] | 2016-02-28T08:34:29Z | [
"cleanup"
] | Build warning message due to missing paxexam version | Netty version: 4.1.0.CR4-SNAPSHOT
Context:
I have noticed below warning message[1] when building netty project.
[1].
[WARNING] Some problems were encountered while building the effective model for io.netty:netty-testsuite-osgi:jar:4.1.0.CR4-SNAPSHOT
[WARNING] 'build.plugins.plugin.version' for org.ops4j.pax.exam:mav... | [
"pom.xml"
] | [
"pom.xml"
] | [] | diff --git a/pom.xml b/pom.xml
index b38fb3b30f3..dd5aaf4a6bd 100644
--- a/pom.xml
+++ b/pom.xml
@@ -1009,6 +1009,11 @@
<artifactId>maven-resources-plugin</artifactId>
<version>2.6</version>
</plugin>
+ <plugin>
+ <groupId>org.ops4j.pax.exam</groupId>
+ <artifactI... | null | train | train | 2016-02-26T12:15:10 | 2016-02-28T08:25:12Z | cnapagoda | val |
netty/netty/3172_4931 | netty/netty | netty/netty/3172 | netty/netty/4931 | [
"timestamp(timedelta=16.0, similarity=0.9260823347012344)"
] | 0d3eda38e15582d1dac05920787f1c9f3a9f781e | ae0f43ea33fb4eb27d3a6b3b8ca0b51c436921c1 | [
"Fixed by https://github.com/netty/netty/pull/4931\n"
] | [] | 2016-03-04T07:08:09Z | [
"cleanup"
] | Print the full thread dump on test timeout | Otherwise it is sometimes difficult to analyze the test timeout reported by our CI server - e.g. #3138
We could write a JUnit `RunListener` that prints the full thread dump when the test fails with timeout, and also do some additional operations like triggering GC when running a leak test.
The Maven surefire plugin ... | [
"pom.xml"
] | [
"pom.xml"
] | [] | diff --git a/pom.xml b/pom.xml
index 0697eeb437a..8264f7f8d44 100644
--- a/pom.xml
+++ b/pom.xml
@@ -201,6 +201,7 @@
<properties>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
+ <netty.build.version>22</netty... | null | val | train | 2016-03-03T15:18:39 | 2014-11-21T23:02:58Z | trustin | val |
netty/netty/4771_4946 | netty/netty | netty/netty/4771 | netty/netty/4946 | [
"timestamp(timedelta=9.0, similarity=0.8698793937065923)"
] | d8658989e1a9a998373886738a17ba8cc9e270ae | abbc4ec1365929c8941dbc98f6ba06f37cb11d61 | [
"@trustin PTAL ....\n",
"I can help if @serphacker shares a reproducer.\n",
"@serphacker ping\n",
"Should be fixed by #4946 \n"
] | [] | 2016-03-07T02:19:16Z | [
"defect"
] | DnsNameResolverContext infinite loop | Got stuck there :
https://github.com/netty/netty/blob/netty-4.1.0.Beta8/resolver-dns/src/main/java/io/netty/resolver/dns/DnsNameResolverContext.java#L280
I think I did receive a response to another query but with the same id.
```
"dns-3-1" #12 prio=5 os_prio=0 tid=0x00007f87c442d800 nid=0x1401 runnable [0x00007f87a9... | [
"resolver-dns/src/main/java/io/netty/resolver/dns/DnsNameResolverContext.java"
] | [
"resolver-dns/src/main/java/io/netty/resolver/dns/DnsNameResolverContext.java"
] | [
"resolver-dns/src/test/java/io/netty/resolver/dns/DnsNameResolverTest.java"
] | diff --git a/resolver-dns/src/main/java/io/netty/resolver/dns/DnsNameResolverContext.java b/resolver-dns/src/main/java/io/netty/resolver/dns/DnsNameResolverContext.java
index 15add823202..8d42d041bf2 100644
--- a/resolver-dns/src/main/java/io/netty/resolver/dns/DnsNameResolverContext.java
+++ b/resolver-dns/src/main/ja... | diff --git a/resolver-dns/src/test/java/io/netty/resolver/dns/DnsNameResolverTest.java b/resolver-dns/src/test/java/io/netty/resolver/dns/DnsNameResolverTest.java
index 9218a0ce688..aef6fa76090 100644
--- a/resolver-dns/src/test/java/io/netty/resolver/dns/DnsNameResolverTest.java
+++ b/resolver-dns/src/test/java/io/net... | train | train | 2016-03-06T17:47:38 | 2016-01-27T08:50:33Z | noguespi | val |
netty/netty/4958_4963 | netty/netty | netty/netty/4958 | netty/netty/4963 | [
"timestamp(timedelta=91964.0, similarity=0.9663956059940177)"
] | bfbef036a8c1121083b485a98b9cb04a84e7dfea | 2565cf7a93daaae9a0aae998567f6289d8b1a85f | [
"@rkapsi I think we could do this. That said we would still need a finalizer for the `OpenSslEngine` itself as we never know what the user will do with it (or will use it at all after creating).\n",
"@normanmaurer Correct. It's meant to be an optimization for folks who don't want to wait for the GC. The finalizer... | [] | 2016-03-11T16:30:24Z | [] | Let OpenSslContext implement ReferenceCounted? | Hello,
would it make sense to let the `OpenSslContext` class implement the `ReferenceCounted` interface?
We have a dynamic and unbound set of OpenSslContext that are concurrently in use and it would be great if we can release the native resources in a timely manner. We're currently using a wrapper object that extends... | [
"handler/src/main/java/io/netty/handler/ssl/OpenSslContext.java"
] | [
"handler/src/main/java/io/netty/handler/ssl/OpenSslContext.java"
] | [] | diff --git a/handler/src/main/java/io/netty/handler/ssl/OpenSslContext.java b/handler/src/main/java/io/netty/handler/ssl/OpenSslContext.java
index 1dceb7885e8..810c22e5bad 100644
--- a/handler/src/main/java/io/netty/handler/ssl/OpenSslContext.java
+++ b/handler/src/main/java/io/netty/handler/ssl/OpenSslContext.java
@@ ... | null | test | train | 2016-03-11T16:42:30 | 2016-03-10T14:20:12Z | rkapsi | val |
netty/netty/4829_4974 | netty/netty | netty/netty/4829 | netty/netty/4974 | [
"timestamp(timedelta=22.0, similarity=0.8910680903060451)"
] | 404666d247504e1bbffbeb87445628735b9e2342 | bd3e9ebddb6d250d69d79fa17081266034b7606a | [
"Will check...\n",
"yep that's a possible race, but it doesn't really happen in practice and I think if it does nobody will notice or care :).\n\nIt may happen if two threads have the same arena's assigned to them, and those two threads need to concurrently allocate from two different tiny size classes and there ... | [] | 2016-03-13T22:20:47Z | [
"defect"
] | Race in PoolArena.allocate | It appears there might be a race in `io.netty.buffer.PoolArena.allocate`, where `allocationsTiny` is incremented. While the value is incremented under a lock, it also appears to be mutated elsewhere in the file without a lock. A race detector suggested the two places where the class accesses this field in an unsynchr... | [
"buffer/src/main/java/io/netty/buffer/PoolArena.java"
] | [
"buffer/src/main/java/io/netty/buffer/PoolArena.java"
] | [] | diff --git a/buffer/src/main/java/io/netty/buffer/PoolArena.java b/buffer/src/main/java/io/netty/buffer/PoolArena.java
index 4cb6af2b6a7..33445241b7b 100644
--- a/buffer/src/main/java/io/netty/buffer/PoolArena.java
+++ b/buffer/src/main/java/io/netty/buffer/PoolArena.java
@@ -57,8 +57,8 @@ enum SizeClass {
private... | null | test | train | 2016-03-11T23:24:45 | 2016-02-03T19:07:54Z | carl-mastrangelo | val |
netty/netty/4936_4977 | netty/netty | netty/netty/4936 | netty/netty/4977 | [
"timestamp(timedelta=14.0, similarity=0.9426395707392698)"
] | 35771dd1cdd20e291a4a1a15ef04da57329c41db | e6b1951ee42738be3894be5da1bd72dd8f93b520 | [
"@ejona86 - Good find ... seems like a bug. You went through all the work to find it ... do you want to submit the patch and get credit for the fix too?\n\nhttps://docs.oracle.com/javase/7/docs/api/java/security/AccessController.html#doPrivileged(java.security.PrivilegedAction)\n\n> If the action's run method throw... | [] | 2016-03-14T08:21:26Z | [
"defect"
] | NetUtil can prevent using Netty due to SecurityManager denial | @carl-mastrangelo and I recently encountered a regression when upgrading to 4.1.0-CR3 due to a51e2c87, with the same error as #3680 ("Unable to create Channel from class" caused by a `NoClassDefFoundError`). The exception was surprisingly unhelpful; we don't know why Java failed to include the additional cause.
After ... | [
"common/src/main/java/io/netty/util/NetUtil.java"
] | [
"common/src/main/java/io/netty/util/NetUtil.java"
] | [] | diff --git a/common/src/main/java/io/netty/util/NetUtil.java b/common/src/main/java/io/netty/util/NetUtil.java
index 5830435f7b7..fdadd53b0c7 100644
--- a/common/src/main/java/io/netty/util/NetUtil.java
+++ b/common/src/main/java/io/netty/util/NetUtil.java
@@ -245,28 +245,31 @@ public Integer run() {
/... | null | train | train | 2016-03-14T08:57:46 | 2016-03-04T23:34:08Z | ejona86 | val |
netty/netty/4182_4986 | netty/netty | netty/netty/4182 | netty/netty/4986 | [
"timestamp(timedelta=9.0, similarity=0.9107598067211391)"
] | c3c1b4a6d2bc66b7ae01a1731656d4bd6dc915b1 | 8d53638864c7f5d156e34e73ea672ff503055ac0 | [
"@longkerdandy we love contributions... Maybe you could submit a PR with a fix ?\n",
"Fixed by https://github.com/netty/netty/pull/4986\n"
] | [
"Only read this flag if the version is 3.1.1\n"
] | 2016-03-16T05:30:22Z | [
"improvement",
"feature"
] | netty-codec MqttDecoder should validate CONNECT reserved flag in variable header | The MQTT 3.1.1 Protocol Specification says:
> The Server MUST validate that the reserved flag in the CONNECT Control Packet is set to zero and disconnect the Client if it is not zero.
> MqttDecoder should validate and throw a exception if it not zero.
| [
"codec-mqtt/src/main/java/io/netty/handler/codec/mqtt/MqttDecoder.java"
] | [
"codec-mqtt/src/main/java/io/netty/handler/codec/mqtt/MqttDecoder.java"
] | [
"codec-mqtt/src/test/java/io/netty/handler/codec/mqtt/MqttCodecTest.java"
] | diff --git a/codec-mqtt/src/main/java/io/netty/handler/codec/mqtt/MqttDecoder.java b/codec-mqtt/src/main/java/io/netty/handler/codec/mqtt/MqttDecoder.java
index 70f0a41e7ba..7103bed6416 100644
--- a/codec-mqtt/src/main/java/io/netty/handler/codec/mqtt/MqttDecoder.java
+++ b/codec-mqtt/src/main/java/io/netty/handler/cod... | diff --git a/codec-mqtt/src/test/java/io/netty/handler/codec/mqtt/MqttCodecTest.java b/codec-mqtt/src/test/java/io/netty/handler/codec/mqtt/MqttCodecTest.java
index 705d071bfd8..5068a941390 100644
--- a/codec-mqtt/src/test/java/io/netty/handler/codec/mqtt/MqttCodecTest.java
+++ b/codec-mqtt/src/test/java/io/netty/handl... | val | train | 2016-03-16T11:55:19 | 2015-09-02T07:36:13Z | longkerdandy | val |
netty/netty/4972_4989 | netty/netty | netty/netty/4972 | netty/netty/4989 | [
"timestamp(timedelta=19.0, similarity=0.9087098129957565)"
] | 83c349ffa94d3992c4ee511d3625afc0c97c12bb | 254e1006b586a3b70a66139b083beb71cfb3cf9f | [
"@ejona86 agree... let me take care of it.\n",
"Fixed by https://github.com/netty/netty/pull/4989\n"
] | [] | 2016-03-16T07:49:08Z | [
"defect"
] | Remove misleading argument from HttpServerUpgradeHandler.UpgradeCodec.upgradeTo | `upgradeTo()` is currently passed `upgradeResponse`, but it doesn't appear like it can do anything useful with it since the response has already been sent. In addition, the [`upgradeTo()` documentation](https://github.com/netty/netty/blob/43ebbc3fa065155fa67732b0cbd7c12843b0f3f7/codec-http/src/main/java/io/netty/handle... | [
"codec-http/src/main/java/io/netty/handler/codec/http/HttpServerUpgradeHandler.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/Http2ServerUpgradeCodec.java"
] | [
"codec-http/src/main/java/io/netty/handler/codec/http/HttpServerUpgradeHandler.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/Http2ServerUpgradeCodec.java"
] | [] | diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/HttpServerUpgradeHandler.java b/codec-http/src/main/java/io/netty/handler/codec/http/HttpServerUpgradeHandler.java
index 691d37e7675..1c9f8cda850 100644
--- a/codec-http/src/main/java/io/netty/handler/codec/http/HttpServerUpgradeHandler.java
+++ b/codec-... | null | train | train | 2016-03-15T16:02:33 | 2016-03-13T02:36:15Z | ejona86 | val |
netty/netty/4971_4990 | netty/netty | netty/netty/4971 | netty/netty/4990 | [
"timestamp(timedelta=26.0, similarity=0.9355626188535049)"
] | ed9d6c79bca67c181b1325a5059af47d40952a01 | 02c5f00b56cdd6f5c01ca0a7fc15ad531eb6c518 | [
"Let me take care.\n",
"Fixed\n"
] | [
"not anything I changed so I would just keep it.\n",
"How about:\n\n```\nPerforms the preparatory steps required for performing a protocol update. This method returns a\nboolean value to proceed or abort the upgrade in progress. If {@code false} is returned, the\nupgrade is aborted and the {@code upgradeRequest} ... | 2016-03-16T07:50:36Z | [
"defect"
] | Change HttpServerUpgradeHandler.UpgradeCodec to allow aborting upgrade | I noticed that `Http2ServerUpgradeCodec.prepareUpgradeResponse()` [doesn't quite have the right behavior](https://github.com/netty/netty/blob/43ebbc3fa065155fa67732b0cbd7c12843b0f3f7/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2ServerUpgradeCodec.java#L95), since failures in the UPGRADE protocol generall... | [
"codec-http/src/main/java/io/netty/handler/codec/http/HttpServerUpgradeHandler.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/Http2ServerUpgradeCodec.java"
] | [
"codec-http/src/main/java/io/netty/handler/codec/http/HttpServerUpgradeHandler.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/Http2ServerUpgradeCodec.java"
] | [] | diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/HttpServerUpgradeHandler.java b/codec-http/src/main/java/io/netty/handler/codec/http/HttpServerUpgradeHandler.java
index 691d37e7675..47670bf14eb 100644
--- a/codec-http/src/main/java/io/netty/handler/codec/http/HttpServerUpgradeHandler.java
+++ b/codec-... | null | train | train | 2016-03-17T10:50:07 | 2016-03-13T02:36:04Z | ejona86 | val |
netty/netty/4994_4995 | netty/netty | netty/netty/4994 | netty/netty/4995 | [
"timestamp(timedelta=18.0, similarity=0.8741306225759525)"
] | ed9d6c79bca67c181b1325a5059af47d40952a01 | d61e4b1e6b92c5fb9fb110a520c4ba0b0339985a | [
"Fixed by https://github.com/netty/netty/pull/4995\n"
] | [
"actually I think the remove should still happen after the `initChannel(...)`\n",
"ensure you close the server and client channel.\n",
"ensure you close the server and client channel.\n",
"Also you can share most of the test-code and just use a different ChannelInitializer for each of them.\n"
] | 2016-03-16T16:26:20Z | [
"defect"
] | ChannelInitializer prevents propagation of channelRegistered event | If I understand Netty's event handling correctly, in general it doesn't (shouldn't?) matter whether a channel handler was added to the pipeline via `addFirst` or `addLast`, the rules of event propagation are the same. This is not the case though when the pipeline is modified within `ChannelInitializer::initChannel`. ... | [
"transport/src/main/java/io/netty/channel/ChannelInitializer.java"
] | [
"transport/src/main/java/io/netty/channel/ChannelInitializer.java"
] | [
"transport/src/test/java/io/netty/channel/ChannelInitializerTest.java"
] | diff --git a/transport/src/main/java/io/netty/channel/ChannelInitializer.java b/transport/src/main/java/io/netty/channel/ChannelInitializer.java
index 5db2c291805..a23b0712271 100644
--- a/transport/src/main/java/io/netty/channel/ChannelInitializer.java
+++ b/transport/src/main/java/io/netty/channel/ChannelInitializer.... | diff --git a/transport/src/test/java/io/netty/channel/ChannelInitializerTest.java b/transport/src/test/java/io/netty/channel/ChannelInitializerTest.java
new file mode 100644
index 00000000000..03d6f014e82
--- /dev/null
+++ b/transport/src/test/java/io/netty/channel/ChannelInitializerTest.java
@@ -0,0 +1,107 @@
+/*
+ * ... | train | train | 2016-03-17T10:50:07 | 2016-03-16T16:19:29Z | tbcs | val |
netty/netty/4418_5012 | netty/netty | netty/netty/4418 | netty/netty/5012 | [
"timestamp(timedelta=29.0, similarity=0.9550468039623317)"
] | 9ebb4b7164b39a6ef9719d6ac15624ba80597191 | e18c05cdb8f8df7fb7e5dd1c7b464a53e7fe1d1d | [
"tip for you: current slow-path calls 2x Thread.currentThread(). have fun\n",
"@normanmaurer - Any updates on this issue? Didn't have have a PR related to this?\n",
"Nope lost track on this one. Should pock it up again\n\n> Am 04.02.2016 um 12:57 schrieb Scott Mitchell notifications@github.com:\n> \n> @normanma... | [
"Modified to put the same data to jdkThreadLocals and fastThreadLocals.\n",
"`final` is the key of the improvement.\n",
"@windie thanks for highlight this!\n",
"+1\n",
"@trustin can you comment why you not did this before when implement this ? \n",
"@normanmaurer It's to prevent `slowThreadLocalMap` from ... | 2016-03-22T03:25:42Z | [
"improvement"
] | Improve performance of FastThreadLocal slow path | Issues #4402 and #4417 gave some indication that there might be room for performance improvement on the slow path of `FastThreadLocal`.
The performance on the slow path might be critical if a user of Netty plugs in an `Executor` that does not use `FastThreadLocalThreads`.
| [
"common/src/main/java/io/netty/util/internal/InternalThreadLocalMap.java",
"common/src/main/java/io/netty/util/internal/UnpaddedInternalThreadLocalMap.java",
"microbench/src/main/java/io/netty/microbench/concurrent/FastThreadLocalBenchmark.java",
"microbench/src/main/java/io/netty/microbench/util/AbstractMicr... | [
"common/src/main/java/io/netty/util/internal/InternalThreadLocalMap.java",
"common/src/main/java/io/netty/util/internal/UnpaddedInternalThreadLocalMap.java",
"microbench/src/main/java/io/netty/microbench/concurrent/FastThreadLocalFastPathBenchmark.java",
"microbench/src/main/java/io/netty/microbench/concurren... | [] | diff --git a/common/src/main/java/io/netty/util/internal/InternalThreadLocalMap.java b/common/src/main/java/io/netty/util/internal/InternalThreadLocalMap.java
index dbd4b3d6bdf..25bf5375563 100644
--- a/common/src/main/java/io/netty/util/internal/InternalThreadLocalMap.java
+++ b/common/src/main/java/io/netty/util/inte... | null | train | train | 2016-03-22T21:12:10 | 2015-10-29T20:53:36Z | buchgr | val |
netty/netty/5013_5020 | netty/netty | netty/netty/5013 | netty/netty/5020 | [
"timestamp(timedelta=26.0, similarity=0.9396069210120149)"
] | 9ebb4b7164b39a6ef9719d6ac15624ba80597191 | d1d2431e82a26184d893de72b91ceceb68d63415 | [
"Thanks for reporting. I will take care.\n"
] | [] | 2016-03-23T06:52:47Z | [
"cleanup"
] | Minor typo in DefaultStompFrame.toString() | Hi,
in current Netty 4.1.x, the DefaultStompFrame.toString() method writes a different class name (Default**Full**StompFrame) than it actually is... I think it's a minor typo, however for new users of the Stomp codec it's confusing when you cannot locate the class at first.
https://github.com/netty/netty/blob/4.1/co... | [
"codec-stomp/src/main/java/io/netty/handler/codec/stomp/DefaultStompFrame.java"
] | [
"codec-stomp/src/main/java/io/netty/handler/codec/stomp/DefaultStompFrame.java"
] | [] | diff --git a/codec-stomp/src/main/java/io/netty/handler/codec/stomp/DefaultStompFrame.java b/codec-stomp/src/main/java/io/netty/handler/codec/stomp/DefaultStompFrame.java
index f4009608a32..5295cb64157 100644
--- a/codec-stomp/src/main/java/io/netty/handler/codec/stomp/DefaultStompFrame.java
+++ b/codec-stomp/src/main/... | null | train | train | 2016-03-22T21:12:10 | 2016-03-22T09:58:40Z | ghost | val |
netty/netty/5029_5030 | netty/netty | netty/netty/5029 | netty/netty/5030 | [
"timestamp(timedelta=128.0, similarity=0.9100040757407813)"
] | 3d115349b51f86d7bd3506b0c079f8efe903a820 | 74e5d945a9a1db1476e1b4fd9b30a71219b3fd00 | [] | [] | 2016-03-23T19:29:16Z | [
"defect"
] | EpollChannelOption.TCP_QUICKACK is set as an Integer | Should be a Boolean.
Reported here:
https://github.com/netty/netty-tcnative/issues/128
| [
"transport-native-epoll/src/main/java/io/netty/channel/epoll/EpollChannelOption.java"
] | [
"transport-native-epoll/src/main/java/io/netty/channel/epoll/EpollChannelOption.java"
] | [] | diff --git a/transport-native-epoll/src/main/java/io/netty/channel/epoll/EpollChannelOption.java b/transport-native-epoll/src/main/java/io/netty/channel/epoll/EpollChannelOption.java
index 2598d53a1c0..261a6f7796e 100644
--- a/transport-native-epoll/src/main/java/io/netty/channel/epoll/EpollChannelOption.java
+++ b/tra... | null | train | train | 2016-03-23T18:06:38 | 2016-03-23T17:52:04Z | normanmaurer | val |
netty/netty/3095_5047 | netty/netty | netty/netty/3095 | netty/netty/5047 | [
"timestamp(timedelta=12.0, similarity=0.8956242991425641)"
] | 5d76daf33b645248a1cde150cbefbd3c24824f78 | cc84e1d3db3ac47d05163de87e4e3e3a4151d678 | [
"@trustin @normanmaurer - Not saying we have the bandwidth for this now, but WDYT?\n",
"@Scottmitch sounds good to me :+1: \n",
"@Scottmitch sounds good to me. I wonder it will change our internal logging API though.\n",
"Yeah we should be careful about this.\n-- \nNorman Maurer\n\nOn 3 Nov 2014 at 09:09:18, ... | [
"package private and final?\n",
"does `core` belong here, or should this just be optional and/or for testing?\n",
"It should be just for testing. Updated.\n",
" Make the \"logger\" logger private static fin... | 2016-03-26T06:26:14Z | [
"improvement"
] | Use Log4j2 for logging | Log4j2 came out a while ago an claims to have significant [performance benefits](http://logging.apache.org/log4j/2.x/manual/async.html#Performance) over SLF4j variants (logback). The new architecture claims to be much more asynchronous in nature and they are using the LMAX Disruptor to reduce contention in a multithre... | [
"common/pom.xml",
"pom.xml"
] | [
"common/pom.xml",
"common/src/main/java/io/netty/util/internal/logging/Log4J2Logger.java",
"common/src/main/java/io/netty/util/internal/logging/Log4J2LoggerFactory.java",
"pom.xml"
] | [
"common/src/test/java/io/netty/util/internal/logging/Log4J2LoggerFactoryTest.java",
"common/src/test/java/io/netty/util/internal/logging/Log4J2LoggerTest.java"
] | diff --git a/common/pom.xml b/common/pom.xml
index a9f9fda6186..876faf3e5b1 100644
--- a/common/pom.xml
+++ b/common/pom.xml
@@ -61,6 +61,16 @@
<artifactId>log4j</artifactId>
<optional>true</optional>
</dependency>
+ <dependency>
+ <groupId>org.apache.logging.log4j</groupId>
+ <artifactI... | diff --git a/common/src/test/java/io/netty/util/internal/logging/Log4J2LoggerFactoryTest.java b/common/src/test/java/io/netty/util/internal/logging/Log4J2LoggerFactoryTest.java
new file mode 100644
index 00000000000..e0db431e9d7
--- /dev/null
+++ b/common/src/test/java/io/netty/util/internal/logging/Log4J2LoggerFactory... | train | train | 2016-03-31T00:01:25 | 2014-11-03T01:34:39Z | Scottmitch | val |
netty/netty/5066_5077 | netty/netty | netty/netty/5066 | netty/netty/5077 | [
"timestamp(timedelta=473.0, similarity=0.9999999999999998)"
] | 516e4933c4044d6da3b66aebee567c7dc8712c9d | cd5633232f9f836292661441f3525e858f494414 | [
"thanks for reporting @rkapsi - let me take care\n",
"Fixed by https://github.com/netty/netty/pull/5077\n"
] | [
"LGTM but just to throw it out there... SslHandler could fire a SslHandshakeCompletionEvent with a reference to itself. It may or may not be \"cheaper\" than the `ctx.pipeline().get(SslHandler.class)` lookup.\n",
"IIUC this would require a change to `SslHandshakeCompletionEvent`. We can consider this as a followu... | 2016-04-04T20:40:06Z | [
"defect"
] | ApplicationProtocolNegotiationHandler doesn't work with SniHandler | Netty 4.1.0.Final-SNAPSHOT
The `ApplicationProtocolNegotiationHandler` is expecting the `SslHandler` to be present at pipeline construction time (see `#handlerAdded(...)`) and consequently fails with the `SniHandler` because it's adding it at a later point in time.
``` java
Caused by: java.lang.IllegalStateException:... | [
"handler/src/main/java/io/netty/handler/ssl/ApplicationProtocolNegotiationHandler.java"
] | [
"handler/src/main/java/io/netty/handler/ssl/ApplicationProtocolNegotiationHandler.java"
] | [
"handler/src/test/java/io/netty/handler/ssl/SniHandlerTest.java"
] | diff --git a/handler/src/main/java/io/netty/handler/ssl/ApplicationProtocolNegotiationHandler.java b/handler/src/main/java/io/netty/handler/ssl/ApplicationProtocolNegotiationHandler.java
index 7810d5aa4aa..0e3ea0f39a3 100644
--- a/handler/src/main/java/io/netty/handler/ssl/ApplicationProtocolNegotiationHandler.java
+++... | diff --git a/handler/src/test/java/io/netty/handler/ssl/SniHandlerTest.java b/handler/src/test/java/io/netty/handler/ssl/SniHandlerTest.java
index a6ae52345f7..0496e21e885 100644
--- a/handler/src/test/java/io/netty/handler/ssl/SniHandlerTest.java
+++ b/handler/src/test/java/io/netty/handler/ssl/SniHandlerTest.java
@@ ... | val | train | 2016-04-02T07:39:47 | 2016-04-01T22:54:59Z | rkapsi | val |
netty/netty/5084_5086 | netty/netty | netty/netty/5084 | netty/netty/5086 | [
"timestamp(timedelta=36.0, similarity=0.8938965835686057)"
] | 66ce0140749a9b3be5617369cbaa8268f0bc962a | 526078be1bfb9b3e3bec7146fb362c3ee80f946d | [
"@zhangkun83 sounds good. Thanks!\n",
"@zhangkun83 please ensure you sign our icla: http://netty.io/s/icla and use our commit message template http://netty.io/wiki/writing-a-commit-message.html when doing the pr :)\n",
"@zhangkun83 good catch!\n",
"The fix in this PR is a mistake. For just one example, it mea... | [
"@zhangkun83 could you add a \"TODO:\" here? Something like:\n\n`// TODO: Once we can break the API we should add ThreadGroup to the arguments of this method.`\n",
"@zhangkun83 sorry for be a PITA but I just noticed we are missing a null check for threadGroup here.\n\nPlease do:\n`this.threadGroup = ObjectUtil.ch... | 2016-04-06T04:08:17Z | [
"defect"
] | DefaultThreadFactory should stick to the thread group where it was constructed | We (gRPC) encountered a bug that was triggered by https://github.com/grpc/grpc-java/commit/d927180a63ac2df4fae0082b51d51e3836771bb1. After that commit, event loop threads are created per task by `NioEventLoopGroup`, and inherits the thread group of the caller, which in our case is an application-provided request-scope ... | [
"common/src/main/java/io/netty/util/concurrent/DefaultThreadFactory.java"
] | [
"common/src/main/java/io/netty/util/concurrent/DefaultThreadFactory.java"
] | [] | diff --git a/common/src/main/java/io/netty/util/concurrent/DefaultThreadFactory.java b/common/src/main/java/io/netty/util/concurrent/DefaultThreadFactory.java
index 84d72cdf242..48966839566 100644
--- a/common/src/main/java/io/netty/util/concurrent/DefaultThreadFactory.java
+++ b/common/src/main/java/io/netty/util/conc... | null | train | train | 2016-04-06T11:52:06 | 2016-04-05T20:12:08Z | zhangkun83 | val |
netty/netty/5069_5101 | netty/netty | netty/netty/5069 | netty/netty/5101 | [
"timestamp(timedelta=127889.0, similarity=0.8773950767919225)"
] | 562d8d220028fbb3d62028bc5879a121dff2fdbd | d1ba4f213e3e84e17fcd90fe8f46aae9967fb3ff | [
"If the EPOLL approach is acceptable this would be preferred as it would remove a volatile which is written to frequently in the event loop. The only hesitation is that [AbstractNioChannel](https://github.com/netty/netty/blob/4.1/transport/src/main/java/io/netty/channel/nio/AbstractNioChannel.java#L133) exposes `re... | [
"@Scottmitch why not just remove this and always call `setReadPendin(false)` ?\n",
"~~@normanmaurer - done~~\n",
"@normanmaurer - Of course this can be done but `clearReadPending` uses a cached Runnable `clearReadPendingRunnable` and `setReadPending` has been deprecated in favor of `clearReadPending`. If we don... | 2016-04-08T02:53:28Z | [
"improvement"
] | Make NIO and EPOLL autoReadClear consistent | [AbstractNioChannel readPending](https://github.com/netty/netty/blob/4.1/transport/src/main/java/io/netty/channel/nio/AbstractNioChannel.java#L64) is volatile because it is directly set when [autoRead is cleared](https://github.com/netty/netty/blob/4.1/transport/src/main/java/io/netty/channel/socket/nio/NioSocketChanne... | [
"transport/src/main/java/io/netty/channel/nio/AbstractNioChannel.java"
] | [
"transport/src/main/java/io/netty/channel/nio/AbstractNioChannel.java"
] | [] | diff --git a/transport/src/main/java/io/netty/channel/nio/AbstractNioChannel.java b/transport/src/main/java/io/netty/channel/nio/AbstractNioChannel.java
index 981f7c8b15f..d69358167b1 100644
--- a/transport/src/main/java/io/netty/channel/nio/AbstractNioChannel.java
+++ b/transport/src/main/java/io/netty/channel/nio/Abs... | null | train | train | 2016-04-07T18:42:17 | 2016-04-03T18:15:40Z | Scottmitch | val |
netty/netty/4929_5113 | netty/netty | netty/netty/4929 | netty/netty/5113 | [
"timestamp(timedelta=72.0, similarity=0.8471297436948142)"
] | a0b28d6c82abec5f953e6f5e8df829850756c7dd | be12a54835c1de8bae4460db27776a616b88ecaa | [
"@harbulot As a workaround, you can specify protocols, cipher suites and algorithm downstream, on each `SSLEngine` you get from `SslContext.newEngine`, before passing them to a `SslHandler`.\n\nFYI, that's how things are done in AsyncHttpClient.\n",
"> Another parameter that would be interesting to pass would be ... | [
"@trustin @Scottmitch asked if this is a breaking change but I think no as the constructor was package private. WDYT ?\n",
"Doesn't sound like a breaking change to me because there was no way for a user to extend this class.\n",
"- use -> Use\n- reference -> use\n",
"- use -> Use\n- reference -> use\n"
] | 2016-04-09T05:16:42Z | [
"improvement"
] | Adding ability to use more standard JSSE options when using JdkSslContext | (Please note the case difference between `SSLContext` and `SslContext` when reading this.)
I was trying to pass various SSL/TLS settings (checking the host name, setting a client certificate and a custom trust store) when using a `JdkSslClientContext` with Netty 4.0.29, when I realised it was actually quite difficult ... | [
"handler/src/main/java/io/netty/handler/ssl/JdkSslClientContext.java",
"handler/src/main/java/io/netty/handler/ssl/JdkSslContext.java",
"handler/src/main/java/io/netty/handler/ssl/JdkSslServerContext.java",
"handler/src/main/java/io/netty/handler/ssl/OpenSslContext.java",
"handler/src/main/java/io/netty/han... | [
"handler/src/main/java/io/netty/handler/ssl/JdkSslClientContext.java",
"handler/src/main/java/io/netty/handler/ssl/JdkSslContext.java",
"handler/src/main/java/io/netty/handler/ssl/JdkSslServerContext.java",
"handler/src/main/java/io/netty/handler/ssl/OpenSslContext.java",
"handler/src/main/java/io/netty/han... | [] | diff --git a/handler/src/main/java/io/netty/handler/ssl/JdkSslClientContext.java b/handler/src/main/java/io/netty/handler/ssl/JdkSslClientContext.java
index ed9e9a0a891..90e6914439b 100644
--- a/handler/src/main/java/io/netty/handler/ssl/JdkSslClientContext.java
+++ b/handler/src/main/java/io/netty/handler/ssl/JdkSslCl... | null | train | train | 2016-04-08T18:44:44 | 2016-03-03T14:27:23Z | harbulot | val |
netty/netty/5122_5126 | netty/netty | netty/netty/5122 | netty/netty/5126 | [
"timestamp(timedelta=21.0, similarity=0.8675625741371196)"
] | 718bf2fa459fd6f79a3c06d835faa180ef9604a1 | bef805259105589628c1e79705d2fdededf7d257 | [
"This one may be a little trickier because the current implementation of [Native](https://github.com/netty/netty/blob/4.1/transport-native-epoll/src/main/java/io/netty/channel/epoll/Native.java#L60) assumes that it will throw if the library fails to load, rather than just printing out a debug message and proceeding... | [
"e -> ignore\n",
"done.\n",
"nit: fix indentation of these params\n",
"done\n"
] | 2016-04-12T14:17:42Z | [
"feature"
] | Allow Netty-epoll use from preloaded System library | In the same vein as #5043, it would be really useful if there was some way to use Netty's epoll without it doing the library initialization itself. The fix would be pretty much the same as here: 379ad2c02ed0c0ae9f94e4081e3f910ece6380b7
cc: @nmittler
| [
"transport-native-epoll/src/main/java/io/netty/channel/epoll/Native.java"
] | [
"transport-native-epoll/src/main/java/io/netty/channel/epoll/Native.java"
] | [] | diff --git a/transport-native-epoll/src/main/java/io/netty/channel/epoll/Native.java b/transport-native-epoll/src/main/java/io/netty/channel/epoll/Native.java
index e4ba4ce2a70..d9244314fb2 100644
--- a/transport-native-epoll/src/main/java/io/netty/channel/epoll/Native.java
+++ b/transport-native-epoll/src/main/java/io... | null | train | train | 2016-04-12T16:27:02 | 2016-04-11T18:32:25Z | carl-mastrangelo | val |
netty/netty/1944_5138 | netty/netty | netty/netty/1944 | netty/netty/5138 | [
"timestamp(timedelta=13774.0, similarity=0.8475972724201017)"
] | cf07f984b16d95719a9ece8c39ed6c11d8c57829 | 0f47da0eed085b0d2ed7701dd7e9a8f4f6c1ec20 | [
"Another issue is the hierarchy. We have a too many implementations to allow for optimal inlining. Seems like the JIT can handle classes with 2 impls the best (when it comes to more then one impl). See also: http://www.cliffc.org/blog/2007/11/06/clone-or-not-clone/\n",
"Let me close this...\n"
] | [
"`{@link CharSequence}`\n",
"`{@link CharSequence}`\n",
"cruft or continuation from the previous line?\n",
" Complete the task associated to this TODO comment. [![rule](https://raw.githubusercontent.com/Sonar... | 2016-04-14T04:57:03Z | [
"improvement"
] | Optimize ByteBuf implementations | Our ByteBuf implementations have some great potential for improvements by reduce the sub-classing etc of them and remove abstract methods and so on.
This allows for better inlining. At the moment even if we are able to inline such an abstract method as in AbstractByteBuf offered we have the overhead of typechecks on ... | [
"buffer/src/main/java/io/netty/buffer/AbstractByteBuf.java",
"buffer/src/main/java/io/netty/buffer/AdvancedLeakAwareByteBuf.java",
"buffer/src/main/java/io/netty/buffer/AdvancedLeakAwareCompositeByteBuf.java",
"buffer/src/main/java/io/netty/buffer/ByteBuf.java",
"buffer/src/main/java/io/netty/buffer/ByteBuf... | [
"buffer/src/main/java/io/netty/buffer/AbstractByteBuf.java",
"buffer/src/main/java/io/netty/buffer/AdvancedLeakAwareByteBuf.java",
"buffer/src/main/java/io/netty/buffer/AdvancedLeakAwareCompositeByteBuf.java",
"buffer/src/main/java/io/netty/buffer/ByteBuf.java",
"buffer/src/main/java/io/netty/buffer/ByteBuf... | [] | diff --git a/buffer/src/main/java/io/netty/buffer/AbstractByteBuf.java b/buffer/src/main/java/io/netty/buffer/AbstractByteBuf.java
index e8dce970031..18281b90a7b 100644
--- a/buffer/src/main/java/io/netty/buffer/AbstractByteBuf.java
+++ b/buffer/src/main/java/io/netty/buffer/AbstractByteBuf.java
@@ -16,6 +16,7 @@
pack... | null | train | train | 2016-05-01T20:30:13 | 2013-10-22T12:29:55Z | normanmaurer | val |
netty/netty/5161_5166 | netty/netty | netty/netty/5161 | netty/netty/5166 | [
"timestamp(timedelta=25.0, similarity=0.911192041254265)"
] | 38d05abd84c2971c68230289aad14066218a6141 | 13e69dd23c6c8817f8124d399e26745212b696aa | [
"thanks for reporting @alugowski \n"
] | [] | 2016-04-20T17:51:27Z | [
"feature"
] | EpollEventLoopGroup missing Executor-based constructor | EpollEventLoop is sold as a drop-in replacement for NioEventLoop (at least on Linux), but EpollEventLoopGroup only has the ThreadFactory-based constructor, not the Executor-based constructor that NioEventLoopGroup also includes.
| [
"transport-native-epoll/src/main/java/io/netty/channel/epoll/EpollEventLoopGroup.java"
] | [
"transport-native-epoll/src/main/java/io/netty/channel/epoll/EpollEventLoopGroup.java"
] | [] | diff --git a/transport-native-epoll/src/main/java/io/netty/channel/epoll/EpollEventLoopGroup.java b/transport-native-epoll/src/main/java/io/netty/channel/epoll/EpollEventLoopGroup.java
index c151806c66b..6a7b3162bbf 100644
--- a/transport-native-epoll/src/main/java/io/netty/channel/epoll/EpollEventLoopGroup.java
+++ b/... | null | val | train | 2016-04-14T11:58:47 | 2016-04-18T23:03:20Z | alugowski | val |
netty/netty/5182_5189 | netty/netty | netty/netty/5182 | netty/netty/5189 | [
"timestamp(timedelta=16.0, similarity=0.8945548512951417)"
] | 9ce84dcb21168c45fe6714d3673c9253f35e5cd2 | f167b4ae22b1e6f81008a56425eeae3f4cca33b8 | [
"Should be pretty easy to contribute a fix :)\n",
"Included the unit test in the pr and added the fix for the issue\nhttps://github.com/netty/netty/pull/5189\nI will apply for clearance to participate in the project to be able to sign the CLA\n",
"Fixed by #5189\n"
] | [] | 2016-04-29T19:09:20Z | [
"defect"
] | HostsFileParser tries to resolve hostnames as case-sensitive | Netty version: 4.1.0.CR7
Context:
I am implementing a mail client in vert.x, which uses netty as network library, when trying to connect to LOCALHOST in upper case, the dns client gives an UnknownHostException.
The regular behaviour of the /etc/hosts resolution should be match the hostnames case insensitive
Steps to ... | [
"resolver/src/main/java/io/netty/resolver/DefaultHostsFileEntriesResolver.java",
"resolver/src/main/java/io/netty/resolver/HostsFileParser.java"
] | [
"resolver/src/main/java/io/netty/resolver/DefaultHostsFileEntriesResolver.java",
"resolver/src/main/java/io/netty/resolver/HostsFileParser.java"
] | [
"resolver/src/test/java/io/netty/resolver/DefaultHostsFileEntriesResolverTest.java",
"resolver/src/test/java/io/netty/resolver/HostsFileParserTest.java"
] | diff --git a/resolver/src/main/java/io/netty/resolver/DefaultHostsFileEntriesResolver.java b/resolver/src/main/java/io/netty/resolver/DefaultHostsFileEntriesResolver.java
index 3d19042e5cc..dbf5fb9ca8e 100644
--- a/resolver/src/main/java/io/netty/resolver/DefaultHostsFileEntriesResolver.java
+++ b/resolver/src/main/jav... | diff --git a/resolver/src/test/java/io/netty/resolver/DefaultHostsFileEntriesResolverTest.java b/resolver/src/test/java/io/netty/resolver/DefaultHostsFileEntriesResolverTest.java
new file mode 100644
index 00000000000..7fac11b2d5a
--- /dev/null
+++ b/resolver/src/test/java/io/netty/resolver/DefaultHostsFileEntriesResol... | train | train | 2016-05-09T22:24:46 | 2016-04-27T22:48:35Z | alexlehm | val |
Subsets and Splits
Java Code Detection in Problems
Identifies and categorizes entries in the dataset that are likely related to Java programming, providing insights into the prevalence and type of Java content in the problem statements.