instance_id stringlengths 17 39 | repo stringclasses 8
values | issue_id stringlengths 14 34 | pr_id stringlengths 14 34 | linking_methods listlengths 1 3 | base_commit stringlengths 40 40 | merge_commit stringlengths 0 40 ⌀ | hints_text listlengths 0 106 | resolved_comments listlengths 0 119 | created_at timestamp[ns, tz=UTC] | labeled_as listlengths 0 7 | problem_title stringlengths 7 174 | problem_statement stringlengths 0 55.4k | gold_files listlengths 0 10 | gold_files_postpatch listlengths 1 10 | test_files listlengths 0 60 | gold_patch stringlengths 220 5.83M | test_patch stringlengths 386 194k ⌀ | split_random stringclasses 3
values | split_time stringclasses 3
values | issue_start_time timestamp[ns] | issue_created_at timestamp[ns, tz=UTC] | issue_by_user stringlengths 3 21 | split_repo stringclasses 3
values |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
netty/netty/2275_2276 | netty/netty | netty/netty/2275 | netty/netty/2276 | [
"timestamp(timedelta=83.0, similarity=0.9042778390261851)"
] | d3ffa1b02b2ba112546070c16d8786f514d6be51 | 61847d860afd98a840c340a421d1b007d2835b0b | [
"@ngocdaothanh would you mind submitting a PR ?\n",
"Sure! I wanted to confirm if my guess was right.\n",
"I've sent pull requests for branch 4.0, 4.1, and master.\n"
] | [] | 2014-02-28T21:55:52Z | [] | %s WebSocket version %s server handshake | 1.
In https://github.com/netty/netty/blob/master/codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketServerHandshaker.java
``` java
logger.debug("%s WebSocket version %s server handshake", channel, version());
```
I guess it should be:
``` java
logger.debug("{} WebSocket version {} server hands... | [
"codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketServerHandshaker.java",
"codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketServerHandshaker07.java"
] | [
"codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketServerHandshaker.java",
"codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketServerHandshaker07.java"
] | [] | diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketServerHandshaker.java b/codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketServerHandshaker.java
index f94b4f79f3e..c2ca118d351 100644
--- a/codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSock... | null | train | train | 2014-02-27T13:28:37 | 2014-02-28T11:14:03Z | ngocdaothanh | val |
netty/netty/2275_2277 | netty/netty | netty/netty/2275 | netty/netty/2277 | [
"timestamp(timedelta=81.0, similarity=0.9042778390261851)"
] | bdedde1294590039e5ab57196053103b2024ca9f | c75f77e528881a3937e7ed5e33f1a51bdc5e0e33 | [
"@ngocdaothanh would you mind submitting a PR ?\n",
"Sure! I wanted to confirm if my guess was right.\n",
"I've sent pull requests for branch 4.0, 4.1, and master.\n"
] | [] | 2014-02-28T21:56:26Z | [] | %s WebSocket version %s server handshake | 1.
In https://github.com/netty/netty/blob/master/codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketServerHandshaker.java
``` java
logger.debug("%s WebSocket version %s server handshake", channel, version());
```
I guess it should be:
``` java
logger.debug("{} WebSocket version {} server hands... | [
"codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketServerHandshaker.java",
"codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketServerHandshaker07.java"
] | [
"codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketServerHandshaker.java",
"codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketServerHandshaker07.java"
] | [] | diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketServerHandshaker.java b/codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketServerHandshaker.java
index f94b4f79f3e..c2ca118d351 100644
--- a/codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSock... | null | test | train | 2014-02-27T11:44:06 | 2014-02-28T11:14:03Z | ngocdaothanh | val |
netty/netty/2275_2278 | netty/netty | netty/netty/2275 | netty/netty/2278 | [
"timestamp(timedelta=44.0, similarity=0.9042778390261851)"
] | 6efac6179e1e13e6caba2cec6109ce27862efc9a | 83c8389d787e7478d725afa8791976e5fa2c4e42 | [
"@ngocdaothanh would you mind submitting a PR ?\n",
"Sure! I wanted to confirm if my guess was right.\n",
"I've sent pull requests for branch 4.0, 4.1, and master.\n"
] | [] | 2014-02-28T21:57:11Z | [] | %s WebSocket version %s server handshake | 1.
In https://github.com/netty/netty/blob/master/codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketServerHandshaker.java
``` java
logger.debug("%s WebSocket version %s server handshake", channel, version());
```
I guess it should be:
``` java
logger.debug("{} WebSocket version {} server hands... | [
"codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketServerHandshaker.java",
"codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketServerHandshaker07.java"
] | [
"codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketServerHandshaker.java",
"codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketServerHandshaker07.java"
] | [] | diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketServerHandshaker.java b/codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketServerHandshaker.java
index f94b4f79f3e..c2ca118d351 100644
--- a/codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSock... | null | train | train | 2014-02-27T13:56:15 | 2014-02-28T11:14:03Z | ngocdaothanh | val |
netty/netty/2282_2299 | netty/netty | netty/netty/2282 | netty/netty/2299 | [
"timestamp(timedelta=51.0, similarity=0.8715944770161461)"
] | 3c7ef6ffce51021090ac3ab5685a1968d147136a | e2ddc61b36fa65feddb6adb2c67c20bfb9c79299 | [
"I was interested in the performance of this, so I ran a little JMH benchmark (disclaimer: I don't know the first thing about benchmarking) on my laptop (too lazy to connect to Azure :)). Well, this is what I got https://gist.github.com/bucjac/9401713 and here is the code https://gist.github.com/bucjac/9401700.\n\n... | [] | 2014-03-10T19:03:41Z | [
"improvement"
] | MultithreadEventExecutorGroup.next() should use bitwise operations when possible | At the moment MultithreadEventExecutorGroup.next() uses modulo operation to calculate the index of the next EventExecutor to use. This is slow compared to bitwise operations which can be used if the array is power of two.
So if the array is power of two we should better use bitwise otherwise use modulo for best perfo... | [
"common/src/main/java/io/netty/util/concurrent/MultithreadEventExecutorGroup.java"
] | [
"common/src/main/java/io/netty/util/concurrent/MultithreadEventExecutorGroup.java"
] | [] | diff --git a/common/src/main/java/io/netty/util/concurrent/MultithreadEventExecutorGroup.java b/common/src/main/java/io/netty/util/concurrent/MultithreadEventExecutorGroup.java
index 38efd4912ed..449598442a3 100644
--- a/common/src/main/java/io/netty/util/concurrent/MultithreadEventExecutorGroup.java
+++ b/common/src/m... | null | test | train | 2014-03-10T06:49:00 | 2014-03-03T11:52:31Z | normanmaurer | val |
netty/netty/2307_2310 | netty/netty | netty/netty/2307 | netty/netty/2310 | [
"timestamp(timedelta=166.0, similarity=0.8448387943046178)"
] | d4d2085377b4aa214619188335b657571c04b5f5 | 59b725b01c9145f07e78d7c280eac7ea381ca9c3 | [
"Let me check... maybe I can do something smart with an `AtomicReference`\n",
"@trustin I wonder why we even lazy start the Thread and add the task to the priority queue. Why not just do this in the constructor right away ?\n",
"A user could create relatively large executor group and then only register smaller ... | [
"`case ST_NOT_STARTED:` could also just fall-through.\n",
"Maybe like this?\n\n``` java\nfor (;;) {\n int oldState = state.get();\n if (oldState >= ST_SHUTTING_DOWN || state.compareAndSet(oldState, ST_SHUTTING_DOWN)) {\n break;\n }\n}\n```\n",
"Could we also use `PlatformDependent.newAtomicInteg... | 2014-03-13T07:06:26Z | [
"improvement"
] | Blocking in SingleThreadEventExecutor#startThread | Currently `io.netty.util.concurrent.SingleThreadEventExecutor#startThread` called every time when `SingleThreadEventExecutor#execute` is called.
This can cause unnecessary blocking because startThread contains synchronized block which called every time (performance penalty are small anyway, about 0.2% for my applicat... | [
"common/src/main/java/io/netty/util/concurrent/SingleThreadEventExecutor.java"
] | [
"common/src/main/java/io/netty/util/concurrent/SingleThreadEventExecutor.java"
] | [] | diff --git a/common/src/main/java/io/netty/util/concurrent/SingleThreadEventExecutor.java b/common/src/main/java/io/netty/util/concurrent/SingleThreadEventExecutor.java
index 37bf9808151..209e3beba03 100644
--- a/common/src/main/java/io/netty/util/concurrent/SingleThreadEventExecutor.java
+++ b/common/src/main/java/io/... | null | val | train | 2014-03-13T06:58:36 | 2014-03-12T19:01:13Z | valodzka | val |
netty/netty/2311_2335 | netty/netty | netty/netty/2311 | netty/netty/2335 | [
"timestamp(timedelta=25226.0, similarity=0.9999999999999998)"
] | 32ccdcdb189996211bff873b8cf2cd42f66f5a5e | 7d09f077b394c7196676e7b5c9a1d4ab9d402b1f | [
"I think that it may be closed too\n"
] | [] | 2014-03-23T10:05:46Z | [
"feature"
] | Allow specifying `SelectorProvider` when constructing an NIO channel | When constructing an `NioEventLoop(Group)` a user can specify his/her preferred `SelectorProvider`, but we do not allow doing that when constructing an NIO channel. For example, you cannot specify your preferred `SelectorProvider` when constructing an `NioSocketChannel`, which makes using an alternative `SelectorProvi... | [
"transport/src/main/java/io/netty/channel/socket/nio/NioDatagramChannel.java",
"transport/src/main/java/io/netty/channel/socket/nio/NioServerSocketChannel.java",
"transport/src/main/java/io/netty/channel/socket/nio/NioSocketChannel.java"
] | [
"transport/src/main/java/io/netty/channel/socket/nio/NioDatagramChannel.java",
"transport/src/main/java/io/netty/channel/socket/nio/NioServerSocketChannel.java",
"transport/src/main/java/io/netty/channel/socket/nio/NioSocketChannel.java"
] | [] | diff --git a/transport/src/main/java/io/netty/channel/socket/nio/NioDatagramChannel.java b/transport/src/main/java/io/netty/channel/socket/nio/NioDatagramChannel.java
index 3feef9283e1..aa71a8b7467 100644
--- a/transport/src/main/java/io/netty/channel/socket/nio/NioDatagramChannel.java
+++ b/transport/src/main/java/io/... | null | val | train | 2014-03-22T22:02:19 | 2014-03-13T08:04:18Z | trustin | val |
netty/netty/2339_2340 | netty/netty | netty/netty/2339 | netty/netty/2340 | [
"timestamp(timedelta=27.0, similarity=0.9606678489503532)"
] | 76d091a8846bb5d9480c7195a3178fccbc697119 | 26d94b32712a7940a5c7b3840e71ba5fcd974cb8 | [
"We love pull-requests ;)\n\n> Am 24.03.2014 um 13:26 schrieb Alexey notifications@github.com:\n> \n> Hi\n> \n> https://github.com/netty/netty/blob/4.0/codec/src/main/java/io/netty/handler/codec/protobuf/ProtobufVarint32LengthFieldPrepender.java\n> \n> Now we calculate headerLen for start, and some later create Cod... | [] | 2014-03-24T15:39:41Z | [
"improvement"
] | reduce memory usage in ProtobufVarint32LengthFieldPrepender.java | Hi
https://github.com/netty/netty/blob/4.0/codec/src/main/java/io/netty/handler/codec/protobuf/ProtobufVarint32LengthFieldPrepender.java
Now we calculate headerLen for start, and some later create CodedOutputStream with code
```
CodedOutputStream headerOut =
CodedOutputStream.newInstance(new ByteBufO... | [
"codec/src/main/java/io/netty/handler/codec/protobuf/ProtobufVarint32LengthFieldPrepender.java"
] | [
"codec/src/main/java/io/netty/handler/codec/protobuf/ProtobufVarint32LengthFieldPrepender.java"
] | [] | diff --git a/codec/src/main/java/io/netty/handler/codec/protobuf/ProtobufVarint32LengthFieldPrepender.java b/codec/src/main/java/io/netty/handler/codec/protobuf/ProtobufVarint32LengthFieldPrepender.java
index b9231781d80..9efd00ff269 100644
--- a/codec/src/main/java/io/netty/handler/codec/protobuf/ProtobufVarint32Lengt... | null | val | train | 2014-03-22T15:01:49 | 2014-03-24T12:26:00Z | xhumanoid | val |
netty/netty/2346_2347 | netty/netty | netty/netty/2346 | netty/netty/2347 | [
"timestamp(timedelta=54.0, similarity=0.8885609524883314)"
] | 5bec0c352a35acc320563a14774ce9da6d78d25a | 15d9a461dc16f35dc173762a231088997aee5360 | [] | [
"Maybe we should not throw an exception but delegate to not break existing apps?\n",
"Good point, let me fix that. Thanks\n\nsöndagen den 30:e mars 2014 skrev Norman Maurer notifications@github.com:\n\n> In\n> codec-http/src/main/java/io/netty/handler/codec/http/cors/CorsConfig.java:\n> \n> > @@ -228,15 +250,28 @... | 2014-03-30T07:50:18Z | [] | CORS should support a whilelist of origins | Currently the CORS support only handles a single origin, or a wildcard origin. This task should enhance Netty's CORS support to allow multiple origins to be specified.
| [
"codec-http/src/main/java/io/netty/handler/codec/http/cors/CorsConfig.java",
"codec-http/src/main/java/io/netty/handler/codec/http/cors/CorsHandler.java",
"example/src/main/java/io/netty/example/http/cors/HttpServerInitializer.java"
] | [
"codec-http/src/main/java/io/netty/handler/codec/http/cors/CorsConfig.java",
"codec-http/src/main/java/io/netty/handler/codec/http/cors/CorsHandler.java",
"example/src/main/java/io/netty/example/http/cors/HttpServerInitializer.java"
] | [
"codec-http/src/test/java/io/netty/handler/codec/http/cors/CorsConfigTest.java",
"codec-http/src/test/java/io/netty/handler/codec/http/cors/CorsHandlerTest.java"
] | diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/cors/CorsConfig.java b/codec-http/src/main/java/io/netty/handler/codec/http/cors/CorsConfig.java
index 5cd70046262..b7b2b0dcc0f 100644
--- a/codec-http/src/main/java/io/netty/handler/codec/http/cors/CorsConfig.java
+++ b/codec-http/src/main/java/io/netty... | diff --git a/codec-http/src/test/java/io/netty/handler/codec/http/cors/CorsConfigTest.java b/codec-http/src/test/java/io/netty/handler/codec/http/cors/CorsConfigTest.java
index e0dfed89622..3f091825abb 100644
--- a/codec-http/src/test/java/io/netty/handler/codec/http/cors/CorsConfigTest.java
+++ b/codec-http/src/test/j... | test | train | 2014-03-29T20:19:06 | 2014-03-30T05:56:33Z | danbev | val |
netty/netty/2377_2391 | netty/netty | netty/netty/2377 | netty/netty/2391 | [
"timestamp(timedelta=96.0, similarity=0.882593498387067)"
] | 15d11289b0406ae2d12b5e7337701cc676791a59 | 54aead2c158ec7be704b16baaf7f86368a5d4b40 | [
"Assigned to me... all the JNI fun for me :)\n"
] | [
"Use `{@code ...}` to signify parameter names, everywhere possible.\n",
"@trustin I think I could even remove the javadocs as these are on the interfaces anyway ?\n",
"`s/ / /` - Please fix anything like this everywhere.\n"
] | 2014-04-15T07:28:50Z | [
"feature"
] | Implement epoll datagram channels | In combination with #2376, it will give us hugh performance gain.
| [
"transport-native-epoll/src/main/c/io_netty_channel_epoll_Native.c",
"transport-native-epoll/src/main/c/io_netty_channel_epoll_Native.h",
"transport-native-epoll/src/main/java/io/netty/channel/epoll/AbstractEpollChannel.java",
"transport-native-epoll/src/main/java/io/netty/channel/epoll/EpollServerSocketChann... | [
"transport-native-epoll/src/main/c/io_netty_channel_epoll_Native.c",
"transport-native-epoll/src/main/c/io_netty_channel_epoll_Native.h",
"transport-native-epoll/src/main/java/io/netty/channel/epoll/AbstractEpollChannel.java",
"transport-native-epoll/src/main/java/io/netty/channel/epoll/EpollDatagramChannel.j... | [
"transport-native-epoll/src/test/java/io/netty/channel/epoll/EpollDatagramUnicastTest.java",
"transport-native-epoll/src/test/java/io/netty/channel/epoll/EpollSocketTestPermutation.java"
] | diff --git a/transport-native-epoll/src/main/c/io_netty_channel_epoll_Native.c b/transport-native-epoll/src/main/c/io_netty_channel_epoll_Native.c
index 6d7c407f74e..baedc825fac 100644
--- a/transport-native-epoll/src/main/c/io_netty_channel_epoll_Native.c
+++ b/transport-native-epoll/src/main/c/io_netty_channel_epoll_... | diff --git a/transport-native-epoll/src/test/java/io/netty/channel/epoll/EpollDatagramUnicastTest.java b/transport-native-epoll/src/test/java/io/netty/channel/epoll/EpollDatagramUnicastTest.java
new file mode 100644
index 00000000000..610cfb5d851
--- /dev/null
+++ b/transport-native-epoll/src/test/java/io/netty/channel... | train | train | 2014-04-15T07:03:13 | 2014-04-11T06:09:44Z | trustin | val |
netty/netty/2402_2403 | netty/netty | netty/netty/2402 | netty/netty/2403 | [
"timestamp(timedelta=27.0, similarity=0.9437644332585227)"
] | c66aae3539739c4cf4ef049f81b7b545491eb3d7 | 1ccdb6f4701174d429ed8cf31a159d62cd4802c5 | [
"There are a couple places where client/server context is important, so it might end up propagating itself anyway.\n\nFor example, push_promise setting should only be sent by the client, push promises should only be sent by the server. client vs server stream ids (already handled I think).\n\nThat said, I don't min... | [
"This is to prevent control from passing on if we're still reading the preface. Could probably change this to checking if any bytes are left in the incoming ByteBuf that haven't been consumed yet.\n",
"Note! Advice wanted.\n",
"nit accidental wildcard\n",
"IntelliJ keeps doing this automatically no matter w... | 2014-04-16T22:47:40Z | [] | HTTP2 server incorrectly sends preface string | We discovered this problem when we found the OkHttp client couldn't talk to the netty server.
https://tools.ietf.org/html/draft-ietf-httpbis-http2-10#section-3.5
The wording of the spec is slightly confusing, but only the client sends the magic preface string that begins with "PRI *".
The server connection header co... | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/draft10/Http2OrHttpChooser.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/draft10/connection/Http2ConnectionHandler.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/draft10/frame/decoder/Http2FrameDecoder.java",
"codec-http2... | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/draft10/Http2OrHttpChooser.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/draft10/connection/Http2ConnectionHandler.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/draft10/frame/decoder/Http2FrameDecoder.java",
"codec-http2... | [] | diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/draft10/Http2OrHttpChooser.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/draft10/Http2OrHttpChooser.java
index db51b7c8572..765a09c026e 100644
--- a/codec-http2/src/main/java/io/netty/handler/codec/http2/draft10/Http2OrHttpChooser.java
... | null | train | train | 2014-04-17T21:11:23 | 2014-04-16T21:55:15Z | dragonsinth | val |
netty/netty/2410_2411 | netty/netty | netty/netty/2410 | netty/netty/2411 | [
"timestamp(timedelta=22.0, similarity=0.856703916914292)"
] | 4d279155f86d0ff32714d21ec46cb49abecff3a3 | 0a3f98d415ef81d568b91c1c8accd5bf56aad263 | [
"Sure a fix would be awesome. We love contributions :)\n\n> Am 18.04.2014 um 20:30 schrieb mkrueger92 notifications@github.com:\n> \n> Netty version: 4.0.18.Final\n> \n> Context:\n> I am using snappy to send a compressed TCP data stream of arbitrary data. The peer application has spit out a warning that the stream ... | [] | 2014-04-19T19:00:34Z | [] | Snappy - wrong chunk type for stream identifier | Netty version: 4.0.18.Final
Context:
I am using snappy to send a compressed TCP data stream of arbitrary data. The peer application has spit out a warning that the stream started with the wrong chunk type. (0x80 instead of 0xff)
In my case this is not such a big problem because 0x80 frames are within the skippable ch... | [
"codec/src/main/java/io/netty/handler/codec/compression/SnappyFramedDecoder.java",
"codec/src/main/java/io/netty/handler/codec/compression/SnappyFramedEncoder.java"
] | [
"codec/src/main/java/io/netty/handler/codec/compression/SnappyFramedDecoder.java",
"codec/src/main/java/io/netty/handler/codec/compression/SnappyFramedEncoder.java"
] | [
"codec/src/test/java/io/netty/handler/codec/compression/SnappyFramedDecoderTest.java",
"codec/src/test/java/io/netty/handler/codec/compression/SnappyFramedEncoderTest.java"
] | diff --git a/codec/src/main/java/io/netty/handler/codec/compression/SnappyFramedDecoder.java b/codec/src/main/java/io/netty/handler/codec/compression/SnappyFramedDecoder.java
index a2db4488c62..f3dee9a8a02 100644
--- a/codec/src/main/java/io/netty/handler/codec/compression/SnappyFramedDecoder.java
+++ b/codec/src/main/... | diff --git a/codec/src/test/java/io/netty/handler/codec/compression/SnappyFramedDecoderTest.java b/codec/src/test/java/io/netty/handler/codec/compression/SnappyFramedDecoderTest.java
index 994369b4a17..5c8355fbd5a 100644
--- a/codec/src/test/java/io/netty/handler/codec/compression/SnappyFramedDecoderTest.java
+++ b/cod... | train | train | 2014-04-18T20:41:09 | 2014-04-18T18:30:54Z | mkrueger92 | val |
netty/netty/2400_2413 | netty/netty | netty/netty/2400 | netty/netty/2413 | [
"timestamp(timedelta=27.0, similarity=0.8576720900504698)"
] | 302d11672884ecdb784ac0a521144d27c3f096c0 | 54e2c4f28a73266344ce04d20a02948eff940ea0 | [
"@Teots can I see your \"dirty reflection hack\" ;) ?\n",
"Sure you can. Here we go:\n\n```\n// channel is passed into the function and is of type Channel\nif (channel instanceof LocalChannel) {\n Class<?> clazz = channel.getClass();\n Field stateField = clazz.getDeclaredField(\"state\");\n stateField.setAc... | [
"'Check if both peer and parent are non-null because this channel was created by a ..'\n\nI would always prefer 'because' to 'as' because it's less confusing to a reader.\n"
] | 2014-04-20T17:51:47Z | [
"defect"
] | ClosedChannelException in doRegister() of LocalChannel | Hi,
we try to move a LocalChannel for one EventLoopGroup to another. Therefore, we use the following (simplyfied) code. This piece of code is called from a thread of the EventLoopGroup, which is assigned to the LocalChannel by now. The auto read function of the channel is disabled. We are using Netty 4.0.18.Final. Do y... | [
"transport/src/main/java/io/netty/channel/local/LocalChannel.java"
] | [
"transport/src/main/java/io/netty/channel/local/LocalChannel.java"
] | [
"transport/src/test/java/io/netty/channel/local/LocalChannelTest.java"
] | diff --git a/transport/src/main/java/io/netty/channel/local/LocalChannel.java b/transport/src/main/java/io/netty/channel/local/LocalChannel.java
index 24eb2d78510..3aba344be48 100644
--- a/transport/src/main/java/io/netty/channel/local/LocalChannel.java
+++ b/transport/src/main/java/io/netty/channel/local/LocalChannel.... | diff --git a/transport/src/test/java/io/netty/channel/local/LocalChannelTest.java b/transport/src/test/java/io/netty/channel/local/LocalChannelTest.java
index adcec5f99d7..d72d9d31974 100644
--- a/transport/src/test/java/io/netty/channel/local/LocalChannelTest.java
+++ b/transport/src/test/java/io/netty/channel/local/L... | train | train | 2014-04-21T09:56:57 | 2014-04-16T14:17:38Z | Teots | val |
netty/netty/2476_2480 | netty/netty | netty/netty/2476 | netty/netty/2480 | [
"timestamp(timedelta=7073.0, similarity=0.8421856332718755)"
] | c62edc87a52e4dee7d02499a3ee5904ca59576c8 | 51adc8172975532cfbde4b52ff128ebf7373cc35 | [
"Forgot to mention that I used nightly build from oss.sonatype.org: netty-example-5.0.0.Alpha2-20140508.064249-382.jar and netty-all-5.0.0.Alpha2-20140508.064500-374.jar\n",
"@nmittler could you check ?\n",
"Yup, will take a look tomorrow. Should be easy enough to fix. Thanks for catching this @tatsuhiro-t \n... | [] | 2014-05-09T14:51:31Z | [] | Strange behavior of HTTP/2 example server | I ran nghttp HTTP/2 client (https://nghttp2.org) to HTTP/2 server (io.netty.example.http2.server). I noticed following strange behavior of the server:
1. Server rejects stream ID = 1
Stream ID = 1 initiated by client must be accepted according to the HTTP/2 specification.
The error message from the server:
... | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/AbstractHttp2ConnectionHandler.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2Connection.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2FrameReader.java",
"codec-http2/src/main/java/io/netty/handler... | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/AbstractHttp2ConnectionHandler.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2Connection.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2FrameReader.java",
"codec-http2/src/main/java/io/netty/handler... | [
"codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionTest.java",
"codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2FrameIOTest.java",
"codec-http2/src/test/java/io/netty/handler/codec/http2/DelegatingHttp2ConnectionHandlerTest.java",
"codec-http2/src/test/java/io/net... | diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/AbstractHttp2ConnectionHandler.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/AbstractHttp2ConnectionHandler.java
index fc05e1299fb..8b54bd2a38e 100644
--- a/codec-http2/src/main/java/io/netty/handler/codec/http2/AbstractHttp2ConnectionH... | diff --git a/codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionTest.java b/codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionTest.java
index 21526af9474..e3344c2f9c3 100644
--- a/codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionTest.java
... | train | train | 2014-05-09T15:43:00 | 2014-05-08T16:29:58Z | tatsuhiro-t | val |
netty/netty/2237_2494 | netty/netty | netty/netty/2237 | netty/netty/2494 | [
"timestamp(timedelta=42.0, similarity=0.9299720569086561)"
] | 856c89dd708fe13f5a8ed2d4fdff8af05580ca7e | bb47cdca801084979529b87361e4930b59e98b2b | [
"The following test demonstrates the problem. This is run with the netty 4.0.15.Final version of Netty.\n\n``` java\n\nimport io.netty.bootstrap.Bootstrap;\nimport io.netty.bootstrap.ServerBootstrap;\nimport io.netty.buffer.ByteBuf;\nimport io.netty.buffer.Unpooled;\nimport io.netty.channel.Channel;\nimport io.nett... | [] | 2014-05-13T12:21:50Z | [
"defect"
] | ChannelTrafficShapingHandler may corrupt inbound data stream | As can be seen from the code of channelRead in AbstractTrafficShapingHandler, inbound data may be passed to the next handler in a scheduled Runnable.
However, it is reason to believe that
inboud data that arrives later may be passed on before the Runnable is executed, and so the order in the inbound stream is not mai... | [
"handler/src/main/java/io/netty/handler/traffic/AbstractTrafficShapingHandler.java"
] | [
"handler/src/main/java/io/netty/handler/traffic/AbstractTrafficShapingHandler.java"
] | [] | diff --git a/handler/src/main/java/io/netty/handler/traffic/AbstractTrafficShapingHandler.java b/handler/src/main/java/io/netty/handler/traffic/AbstractTrafficShapingHandler.java
index 7492886e2f6..e4f016048af 100644
--- a/handler/src/main/java/io/netty/handler/traffic/AbstractTrafficShapingHandler.java
+++ b/handler/s... | null | train | train | 2014-05-13T07:25:26 | 2014-02-16T18:25:21Z | racorn | val |
netty/netty/2436_2531 | netty/netty | netty/netty/2436 | netty/netty/2531 | [
"timestamp(timedelta=87.0, similarity=0.8885360305547618)"
] | d0640a6686b735044b74ea3f31ac08da2f62093e | b57f6d833b0c188fb1a37642cb4f814f39aa7eef | [
"Yeah, I was quite lazy when writing this. Another food for thought is: do we really need a swapped buffer? Why don't we just add a little endian getters and setters into `ByteBuf`? It will make it a little bit crowded but it actually should simplify things.\n",
"@trustin lol :) What you mean with getter and se... | [] | 2014-06-04T05:09:43Z | [
"improvement"
] | ByteBuf implementation should only invert bytes if ByteOrder differ from native ByteOrder | @pavanka made me aware of an issue with how we handle native ByteOrder and endianess. Basically we always assume that native ByteOrder is BIG_ENDIAN and so we end up invert bytes when ByteOrder.LITTLE_ENDIAN is set on the ByteBuf and the native ByteOrder is LITTLE_ENDIAN.
We should change our implementation to act mor... | [
"buffer/src/main/java/io/netty/buffer/AbstractByteBuf.java",
"buffer/src/main/java/io/netty/buffer/PooledUnsafeDirectByteBuf.java",
"buffer/src/main/java/io/netty/buffer/SwappedByteBuf.java",
"buffer/src/main/java/io/netty/buffer/UnpooledUnsafeDirectByteBuf.java",
"microbench/pom.xml"
] | [
"buffer/src/main/java/io/netty/buffer/AbstractByteBuf.java",
"buffer/src/main/java/io/netty/buffer/PooledUnsafeDirectByteBuf.java",
"buffer/src/main/java/io/netty/buffer/SwappedByteBuf.java",
"buffer/src/main/java/io/netty/buffer/UnpooledUnsafeDirectByteBuf.java",
"buffer/src/main/java/io/netty/buffer/Unsaf... | [
"microbench/src/test/java/io/netty/microbench/buffer/SwappedByteBufBenchmark.java"
] | diff --git a/buffer/src/main/java/io/netty/buffer/AbstractByteBuf.java b/buffer/src/main/java/io/netty/buffer/AbstractByteBuf.java
index 1ec4afa71fa..92e4a471bdf 100644
--- a/buffer/src/main/java/io/netty/buffer/AbstractByteBuf.java
+++ b/buffer/src/main/java/io/netty/buffer/AbstractByteBuf.java
@@ -38,7 +38,7 @@ publi... | diff --git a/microbench/src/test/java/io/netty/microbench/buffer/SwappedByteBufBenchmark.java b/microbench/src/test/java/io/netty/microbench/buffer/SwappedByteBufBenchmark.java
new file mode 100644
index 00000000000..e359a6c23cf
--- /dev/null
+++ b/microbench/src/test/java/io/netty/microbench/buffer/SwappedByteBufBench... | test | train | 2014-06-03T20:23:44 | 2014-04-29T07:27:11Z | normanmaurer | val |
netty/netty/2565_2566 | netty/netty | netty/netty/2565 | netty/netty/2566 | [
"timestamp(timedelta=48801.0, similarity=0.8672136286651443)"
] | 7d37af5dfb33c9ca67c596f1371aec6bf54d46a9 | aa5e59da2cf9ac4fdb7cac5719151263d35c6564 | [
"@philbaxter thanks merged in :)\n"
] | [] | 2014-06-13T09:36:31Z | [] | sun imports should be marked optional | As per the title. sun.security.util and sun.security.x509 should be marked as optional in the manifest.
| [
"pom.xml"
] | [
"pom.xml"
] | [] | diff --git a/pom.xml b/pom.xml
index 7b742b346a4..a215f129fb8 100644
--- a/pom.xml
+++ b/pom.xml
@@ -766,7 +766,7 @@
<instructions>
<Export-Package>${project.groupId}.*</Export-Package>
<!-- enforce JVM vendor package as optional -->
- <Import-Package>sun.... | null | train | train | 2014-06-13T11:02:16 | 2014-06-13T08:07:54Z | philbaxter | val |
netty/netty/2588_2591 | netty/netty | netty/netty/2588 | netty/netty/2591 | [
"timestamp(timedelta=120.0, similarity=0.9140302153138531)"
] | 7162d96ed502f601fcaf7f16fa543caf2456b37a | f06056882c51c48db16f665fc1ddc44eb6ec55c9 | [
"@trustin so either we let ioBuffer() not use size of 0 as default or allow to configure it. I would prefer the first. WDYT ?\n",
"It's due to a historical reason - long time ago in the early days of 4.0.AlphaX, we allocated a buffer per handler. Having a non-zero capacity buffer from the beginning of the connec... | [] | 2014-06-23T05:06:19Z | [
"improvement"
] | MessageToByteEncoder always starts with ByteBuf that use initalCapacity == 0 | The problem is that we use ByteBufAllocator.ioBuffer() which returns a ByteBuf with intialCapacity of 0 when preferDirect is specified in the constructor.
| [
"buffer/src/main/java/io/netty/buffer/AbstractByteBufAllocator.java",
"buffer/src/main/java/io/netty/buffer/ByteBufAllocator.java",
"codec/src/main/java/io/netty/handler/codec/MessageToByteEncoder.java"
] | [
"buffer/src/main/java/io/netty/buffer/AbstractByteBufAllocator.java",
"buffer/src/main/java/io/netty/buffer/ByteBufAllocator.java",
"codec/src/main/java/io/netty/handler/codec/MessageToByteEncoder.java"
] | [] | diff --git a/buffer/src/main/java/io/netty/buffer/AbstractByteBufAllocator.java b/buffer/src/main/java/io/netty/buffer/AbstractByteBufAllocator.java
index 4d39bc29eed..34e5d2c6dd4 100644
--- a/buffer/src/main/java/io/netty/buffer/AbstractByteBufAllocator.java
+++ b/buffer/src/main/java/io/netty/buffer/AbstractByteBufAl... | null | train | train | 2014-06-21T12:19:49 | 2014-06-20T16:27:02Z | normanmaurer | val |
netty/netty/2607_2608 | netty/netty | netty/netty/2607 | netty/netty/2608 | [
"timestamp(timedelta=28887.0, similarity=0.8797419366114805)"
] | af042bb7d2afca348948a9dbada1f13da58a5fb7 | 5dabf809f27ecee7062f8fb7983e824b06f81512 | [
"Pull request accepted...issue closed.\n"
] | [] | 2014-06-26T19:06:31Z | [] | HTTP2 Client Example read losing data | The `onDataRead` method in `Http2ClientConnectionHandler.java` HTTP2 example is incorrectly re-allocating the bytebuf when it needs to be re-sized.
| [
"example/src/main/java/io/netty/example/http2/client/Http2ClientConnectionHandler.java"
] | [
"example/src/main/java/io/netty/example/http2/client/Http2ClientConnectionHandler.java"
] | [] | diff --git a/example/src/main/java/io/netty/example/http2/client/Http2ClientConnectionHandler.java b/example/src/main/java/io/netty/example/http2/client/Http2ClientConnectionHandler.java
index d9face6903c..e2c740a245b 100644
--- a/example/src/main/java/io/netty/example/http2/client/Http2ClientConnectionHandler.java
+++... | null | train | train | 2014-06-26T12:24:44 | 2014-06-26T18:58:28Z | Scottmitch | val |
netty/netty/2642_2645 | netty/netty | netty/netty/2642 | netty/netty/2645 | [
"timestamp(timedelta=35.0, similarity=1.0000000000000002)"
] | 696e355a7098dadb46edeb19148e2e222789d6e7 | 8db5346eda5aef86df47662a0363bf8b1b58e4c2 | [
"> roughly 1.79 GB or 1.40% of the GC pressure during performance testing\n\nOn a curious sidenote, what profiler do you use to get to these numbers?\n",
"@jakobbuchgraber you can use Java Mission Control for this.\n",
"@jakobbuchgraber I used Java Mission Control's Flight Record to get this data.\n"
] | [] | 2014-07-08T17:37:38Z | [
"improvement"
] | CompositeByteBuf.deallocate memory improvement | In profiling my application, I have noticed that `CompositeByteBuf.deallocate` generates `java.util.ArrayList$Itr` roughly 1.79 GB or 1.40% of the GC pressure during performance testing. This is due to it using the 'enhanced' for-loop. This can be resolved by converting to the old-style for loop as shown below:
From:... | [
"buffer/src/main/java/io/netty/buffer/CompositeByteBuf.java"
] | [
"buffer/src/main/java/io/netty/buffer/CompositeByteBuf.java"
] | [] | diff --git a/buffer/src/main/java/io/netty/buffer/CompositeByteBuf.java b/buffer/src/main/java/io/netty/buffer/CompositeByteBuf.java
index 818c97569f4..d5cf14c27da 100644
--- a/buffer/src/main/java/io/netty/buffer/CompositeByteBuf.java
+++ b/buffer/src/main/java/io/netty/buffer/CompositeByteBuf.java
@@ -1599,8 +1599,11... | null | test | train | 2014-07-07T09:44:50 | 2014-07-07T20:50:04Z | blucas | val |
netty/netty/2659_2676 | netty/netty | netty/netty/2659 | netty/netty/2676 | [
"timestamp(timedelta=41.0, similarity=0.9051057703458023)"
] | ea62455f628abe8e13ac1583d8ea7f0c511e19f8 | 50186fbcf53e5e9943bc9ce945d48d9f82323275 | [
"opinali@ thanks for the find! Do you think you could change the code to capture the state of the map when the assertion occurs?\n",
"@nmittler shouldn't be hard; let me try this.\n",
"well, it's being harder than expected... I have added code to dump the map state, but after redeploy, couldn't reproduce the e... | [
"Please use for (;;) as we use for(;;) for this kind of stuff everywhere in netty. Just for the sake of consistency\n",
"IllegalStateException ?\n",
"I think if we do v.equals(values[i]) we can eliminate the null check\n",
"return false if null is given as value\n",
"same as above\n",
"Please replace wit... | 2014-07-19T22:20:47Z | [
"defect"
] | Bug in the new IntObjectHashMap.java | "Should never happen" condition has happened :) This may be difficult to reproduce, I noticed two events like this spaced by ~5 minutes on a server processing 20Kqps.
22:59:04.632 [epollEventLoopGroup-3-3] WARN io.netty.channel.AbstractChannel - Failed to close a channel.
java.io.IOException: Error closing file desc... | [
"common/src/main/java/io/netty/util/collection/IntObjectHashMap.java"
] | [
"common/src/main/java/io/netty/util/collection/IntObjectHashMap.java"
] | [
"common/src/test/java/io/netty/util/collection/IntObjectHashMapTest.java"
] | diff --git a/common/src/main/java/io/netty/util/collection/IntObjectHashMap.java b/common/src/main/java/io/netty/util/collection/IntObjectHashMap.java
index da5dc9e834d..34480188d61 100644
--- a/common/src/main/java/io/netty/util/collection/IntObjectHashMap.java
+++ b/common/src/main/java/io/netty/util/collection/IntOb... | diff --git a/common/src/test/java/io/netty/util/collection/IntObjectHashMapTest.java b/common/src/test/java/io/netty/util/collection/IntObjectHashMapTest.java
index 7f50134ef85..ec291df8748 100644
--- a/common/src/test/java/io/netty/util/collection/IntObjectHashMapTest.java
+++ b/common/src/test/java/io/netty/util/coll... | train | train | 2014-07-19T14:42:11 | 2014-07-15T23:01:40Z | opinali | val |
netty/netty/2694_2701 | netty/netty | netty/netty/2694 | netty/netty/2701 | [
"timestamp(timedelta=38.0, similarity=0.8639139103559901)"
] | 7e362277b93bbf4d59fd80485f3fe534a3ed8bba | 1e7af3d3d002abb0e74baa9f06aea8e9c9984e5b | [
"@nmittler can you take care ?\n",
"Sure thing ... created PR #2701 \n",
"@Scottmitch1 FYI, I think you only need to follow the netty commit message rules for pull requests, not issues. When I first looked at this I thought it was a PR :)\n",
"@nmittler - That makes sense because I also confused @normanmaure... | [] | 2014-07-23T16:12:36Z | [] | HTTP/2 Codec remove compressed from method signatures | **Motivation**
HTTP/2 Draft-13 removed the explicit per frame gzip compression support present in previous drafts. The per frame compression concept was partially removed from the code base as part of updating to Draft-13. The concept still exists in some classes and method signatures related to the outbound message ... | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/AbstractHttp2ConnectionHandler.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2OutboundFlowController.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/DelegatingHttp2ConnectionHandler.java",
"codec-http2/src/main/... | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/AbstractHttp2ConnectionHandler.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2OutboundFlowController.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/DelegatingHttp2ConnectionHandler.java",
"codec-http2/src/main/... | [
"codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2OutboundFlowControllerTest.java",
"codec-http2/src/test/java/io/netty/handler/codec/http2/DelegatingHttp2ConnectionHandlerTest.java",
"codec-http2/src/test/java/io/netty/handler/codec/http2/Http2ConnectionRoundtripTest.java"
] | diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/AbstractHttp2ConnectionHandler.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/AbstractHttp2ConnectionHandler.java
index 92f43b5d65b..fba729c9f5a 100644
--- a/codec-http2/src/main/java/io/netty/handler/codec/http2/AbstractHttp2ConnectionH... | diff --git a/codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2OutboundFlowControllerTest.java b/codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2OutboundFlowControllerTest.java
index 5221fa99520..e96c372ee7c 100644
--- a/codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultH... | train | train | 2014-07-22T22:32:01 | 2014-07-22T20:40:40Z | Scottmitch | val |
netty/netty/2718_2725 | netty/netty | netty/netty/2718 | netty/netty/2725 | [
"timestamp(timedelta=17.0, similarity=0.8508248784792203)"
] | 7791fbf0e2c91616c51a4ddc7a0e7e79788df441 | 4986b7600e332e836b89a7f911da7bbef42f3a46 | [
"It's a bug. Key password must be respected. I would be more than happy if you are coming up with a patch!\n",
"And, here's the ICLA form: https://docs.google.com/spreadsheet/viewform?formkey=dHBjc1YzdWhsZERUQnhlSklsbG1KT1E6MQ\n",
"Alright, I filled in the ICLA form and will do my best to help.\n"
] | [
"Why not make this class final and add a private constructor? Seems like it only contains a static method anyway.\n",
"Add empty line \n",
"Also I think we can make it package private\n",
"After thinking a bit more about it maybe we could also just merge it into `JdkSslServerContext`. Or is there any reasons ... | 2014-08-02T10:47:22Z | [
"defect"
] | JdkSslContext ignores key password | I'm using **5.0.0.Alpha2-SNAPSHOT** with java 1.7.0_51 on OS X 10.9.3.
When `JdkSslContext` is initialized it creates a `java.security.spec.PKCS8EncodedKeySpec` from the `byte[]` read by `PemReader` which is passed to a `java.security.KeyFactory` in order to obtain a `java.security.PrivateKey`. This only works if the... | [
"handler/src/main/java/io/netty/handler/ssl/JdkSslServerContext.java"
] | [
"handler/src/main/java/io/netty/handler/ssl/JdkSslServerContext.java"
] | [
"handler/src/test/java/io/netty/handler/ssl/JdkSslServerContextTest.java",
"handler/src/test/resources/io/netty/handler/ssl/netty_test",
"handler/src/test/resources/io/netty/handler/ssl/netty_test.crt",
"handler/src/test/resources/io/netty/handler/ssl/netty_test_unencrypted"
] | diff --git a/handler/src/main/java/io/netty/handler/ssl/JdkSslServerContext.java b/handler/src/main/java/io/netty/handler/ssl/JdkSslServerContext.java
index 6fcd2445215..92ba7fa74b8 100644
--- a/handler/src/main/java/io/netty/handler/ssl/JdkSslServerContext.java
+++ b/handler/src/main/java/io/netty/handler/ssl/JdkSslSe... | diff --git a/handler/src/test/java/io/netty/handler/ssl/JdkSslServerContextTest.java b/handler/src/test/java/io/netty/handler/ssl/JdkSslServerContextTest.java
new file mode 100644
index 00000000000..eb0863002ad
--- /dev/null
+++ b/handler/src/test/java/io/netty/handler/ssl/JdkSslServerContextTest.java
@@ -0,0 +1,47 @@
... | val | train | 2014-08-04T08:01:19 | 2014-07-31T22:06:37Z | schulzp | val |
netty/netty/2693_2729 | netty/netty | netty/netty/2693 | netty/netty/2729 | [
"timestamp(timedelta=62530.0, similarity=0.8478815462737131)"
] | d0e4a8583031e57bbd43700dce0e336d088a2bea | d400afd56b37efdda2254f95a787f2d790675d39 | [
"[This build](https://secure.motd.kr/jenkins/job/netty-4.0/4803/) reduces the initial capacity of `ChannelOutboundBuffer` to 4. (commit: 7e362277b93bbf4d59fd80485f3fe534a3ed8bba)\n",
"@trustin I think we can close this ?\n",
"Nope. The second item was not resolved yet.\n",
"Ah got it\n\n> Am 23.07.2014 um 22:... | [
"This line should not be changed.\n",
"If this is not public, a user who extends `AbstractChannel` (and consequently `AbstractUnsafe`) will not be able to access the return value of `AbstractUnsafe.outboundBuffer()`.\n",
"Any reason this is not part of the interface?\n"
] | 2014-08-04T10:17:53Z | [
"improvement"
] | Reduce the memory consumption of ChannelOutboundBuffer | The initial capacity of a `ChannelOutboundBuffer` is 32, and it means each `ChannelOutboundBuffer` will end up with 32 entry objects as a channel lives on, even if the channel's maximum number of pending write requests is always 1.
We could do a few things to fix this:
- Reduce the initial capacity to a smaller value ... | [
"transport/src/main/java/io/netty/channel/AbstractChannel.java",
"transport/src/main/java/io/netty/channel/ChannelOutboundBuffer.java"
] | [
"transport/src/main/java/io/netty/channel/AbstractChannel.java",
"transport/src/main/java/io/netty/channel/ChannelOutboundBuffer.java"
] | [
"transport/src/test/java/io/netty/channel/ChannelOutboundBufferTest.java"
] | diff --git a/transport/src/main/java/io/netty/channel/AbstractChannel.java b/transport/src/main/java/io/netty/channel/AbstractChannel.java
index 5642f226554..e270a98acb7 100644
--- a/transport/src/main/java/io/netty/channel/AbstractChannel.java
+++ b/transport/src/main/java/io/netty/channel/AbstractChannel.java
@@ -83,... | diff --git a/transport/src/test/java/io/netty/channel/ChannelOutboundBufferTest.java b/transport/src/test/java/io/netty/channel/ChannelOutboundBufferTest.java
index 11c0f6a1415..296a0e7d131 100644
--- a/transport/src/test/java/io/netty/channel/ChannelOutboundBufferTest.java
+++ b/transport/src/test/java/io/netty/channe... | train | train | 2014-08-04T19:53:39 | 2014-07-22T18:53:12Z | trustin | val |
netty/netty/2709_2729 | netty/netty | netty/netty/2709 | netty/netty/2729 | [
"timestamp(timedelta=89.0, similarity=0.893472531598197)"
] | d0e4a8583031e57bbd43700dce0e336d088a2bea | d400afd56b37efdda2254f95a787f2d790675d39 | [
"Fixed in 3f3e66c31ae3da70c36cc125ca9bcac8215390e4\n"
] | [
"This line should not be changed.\n",
"If this is not public, a user who extends `AbstractChannel` (and consequently `AbstractUnsafe`) will not be able to access the return value of `AbstractUnsafe.outboundBuffer()`.\n",
"Any reason this is not part of the interface?\n"
] | 2014-08-04T10:17:53Z | [
"defect"
] | ChannelOutboundBuffer only be usable via AbstractChannel | We expose `ChannelOuboundBuffer` in `Channel.Unsafe` but make it impossible to create one instance without the usage of `AbstractChannel`. This makes it impossible to write a `Channel` implementation that not extends `AbstractChannel`.
| [
"transport/src/main/java/io/netty/channel/AbstractChannel.java",
"transport/src/main/java/io/netty/channel/ChannelOutboundBuffer.java"
] | [
"transport/src/main/java/io/netty/channel/AbstractChannel.java",
"transport/src/main/java/io/netty/channel/ChannelOutboundBuffer.java"
] | [
"transport/src/test/java/io/netty/channel/ChannelOutboundBufferTest.java"
] | diff --git a/transport/src/main/java/io/netty/channel/AbstractChannel.java b/transport/src/main/java/io/netty/channel/AbstractChannel.java
index 5642f226554..e270a98acb7 100644
--- a/transport/src/main/java/io/netty/channel/AbstractChannel.java
+++ b/transport/src/main/java/io/netty/channel/AbstractChannel.java
@@ -83,... | diff --git a/transport/src/test/java/io/netty/channel/ChannelOutboundBufferTest.java b/transport/src/test/java/io/netty/channel/ChannelOutboundBufferTest.java
index 11c0f6a1415..296a0e7d131 100644
--- a/transport/src/test/java/io/netty/channel/ChannelOutboundBufferTest.java
+++ b/transport/src/test/java/io/netty/channe... | val | train | 2014-08-04T19:53:39 | 2014-07-28T17:49:22Z | normanmaurer | val |
netty/netty/2649_2745 | netty/netty | netty/netty/2649 | netty/netty/2745 | [
"timestamp(timedelta=39985.0, similarity=0.9999999999999999)"
] | d5fd57262b9877a0f5b035a7c019d576ee1c60f3 | a6e3e455f410a35e217c982d0c11d2d13332d4b2 | [
"Do we also need something like getIntAndRemove(...) ?\n",
"@plucury thanks for all the work. This can be closed now. \n"
] | [
"maybe start with 2 ? Seems more likely then 4.\n",
"why is this even needed ?\n",
"Again I think we should use 2\n",
"Same as above\n",
"I don't think an exception is the right thing here. I would even say that we should better change the return type to Long everywhere and return null in the case that it i... | 2014-08-06T09:15:56Z | [
"feature"
] | Add TextHeaders.getAndRemove(...) | At the moment there is not way to get and remove a header with one call. This means you need to search the headers two times. We should add getAndRemove(...) to allow doing so with one call.
| [
"codec/src/main/java/io/netty/handler/codec/DefaultTextHeaders.java",
"codec/src/main/java/io/netty/handler/codec/EmptyTextHeaders.java",
"codec/src/main/java/io/netty/handler/codec/TextHeaders.java"
] | [
"codec/src/main/java/io/netty/handler/codec/DefaultTextHeaders.java",
"codec/src/main/java/io/netty/handler/codec/EmptyTextHeaders.java",
"codec/src/main/java/io/netty/handler/codec/TextHeaders.java"
] | [] | diff --git a/codec/src/main/java/io/netty/handler/codec/DefaultTextHeaders.java b/codec/src/main/java/io/netty/handler/codec/DefaultTextHeaders.java
index 9d36a957a01..a6d3504d777 100644
--- a/codec/src/main/java/io/netty/handler/codec/DefaultTextHeaders.java
+++ b/codec/src/main/java/io/netty/handler/codec/DefaultText... | null | train | train | 2014-08-06T07:03:31 | 2014-07-11T05:35:52Z | normanmaurer | val |
netty/netty/2750_2755 | netty/netty | netty/netty/2750 | netty/netty/2755 | [
"timestamp(timedelta=96494.0, similarity=0.8982404311961517)"
] | 220660e351b2a22112b19c4af45e403eab1f73ab | ac36de3b1c7c8ba28bb269685adf8b299a59769e | [
"Do `LZF` and `FastLZ` employ different compression algorithms? Also, could you explain why 6PACK is not suitable for Netty? For example, we could use an arbitrary file name like `data`?\n",
"I guess I know why:\n- too much overhead\n- 6pack is only provided as an example to show how to use FastLZ.\n\nHere's my f... | [] | 2014-08-11T23:14:17Z | [
"feature",
"won't fix"
] | FastLZ format | I'm trying to implement FastLZ compression codec for Netty.
Official web site: http://fastlz.org/
Official repo: https://code.google.com/p/fastlz/
Java port: https://code.google.com/p/jfastlz/
These resources doesn't have a format description so I read a source code.
FastLZ compressor (fastlz.c / JFastLZ.java) only co... | [
"NOTICE.txt"
] | [
"NOTICE.txt",
"codec/src/main/java/io/netty/handler/codec/compression/FastLz.java",
"codec/src/main/java/io/netty/handler/codec/compression/FastLzFramedDecoder.java",
"codec/src/main/java/io/netty/handler/codec/compression/FastLzFramedEncoder.java",
"license/LICENSE.jfastlz.txt"
] | [
"codec/src/test/java/io/netty/handler/codec/compression/FastLzIntegrationTest.java"
] | diff --git a/NOTICE.txt b/NOTICE.txt
index 74637c84a77..356556498d0 100644
--- a/NOTICE.txt
+++ b/NOTICE.txt
@@ -114,6 +114,14 @@ decoding data in LZF format, written by Tatu Saloranta. It can be obtained at:
* HOMEPAGE:
* https://github.com/ning/compress
+This product contains a modified portion of 'jfastlz'... | diff --git a/codec/src/test/java/io/netty/handler/codec/compression/FastLzIntegrationTest.java b/codec/src/test/java/io/netty/handler/codec/compression/FastLzIntegrationTest.java
new file mode 100644
index 00000000000..0df309372ac
--- /dev/null
+++ b/codec/src/test/java/io/netty/handler/codec/compression/FastLzIntegrat... | test | train | 2014-08-12T00:28:46 | 2014-08-07T21:59:54Z | idelpivnitskiy | val |
netty/netty/2741_2763 | netty/netty | netty/netty/2741 | netty/netty/2763 | [
"timestamp(timedelta=14.0, similarity=0.8792972262052686)"
] | f89907dba54bcd8d6d5d2c8f9badbec24b7e4ee0 | 45f407add67510ddda2dc7298da6505b13af1309 | [] | [
"no need for this.\n",
"just remove the @return and merge it with the previous line. Also please use {@code -1} to highlight it. \n",
"When there are two cases for return values, I find `@return` useful.\n\n```\nReturns the length of the input.\n@return the length of the input if the length of the input is know... | 2014-08-13T15:00:24Z | [
"feature"
] | Allow ChunkedInput to provide the progress information | Related issue: #2151
There is no way for `ChunkedWriteHandler` to know the progress of the transfer of a `ChannelInput`. Therefore, `ChannelProgressiveFutureListener` cannot get exact information about the progress of the transfer.
If you add a few methods that optionally provides the transfer progress to `ChannelI... | [
"codec-http/src/main/java/io/netty/handler/codec/http/HttpChunkedInput.java",
"codec-http/src/main/java/io/netty/handler/codec/http/multipart/HttpPostRequestEncoder.java",
"handler/src/main/java/io/netty/handler/stream/ChunkedFile.java",
"handler/src/main/java/io/netty/handler/stream/ChunkedInput.java",
"ha... | [
"codec-http/src/main/java/io/netty/handler/codec/http/HttpChunkedInput.java",
"codec-http/src/main/java/io/netty/handler/codec/http/multipart/HttpPostRequestEncoder.java",
"handler/src/main/java/io/netty/handler/stream/ChunkedFile.java",
"handler/src/main/java/io/netty/handler/stream/ChunkedInput.java",
"ha... | [
"handler/src/test/java/io/netty/handler/stream/ChunkedWriteHandlerTest.java"
] | diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/HttpChunkedInput.java b/codec-http/src/main/java/io/netty/handler/codec/http/HttpChunkedInput.java
index a6d317a1ff7..652ba6ae6fa 100644
--- a/codec-http/src/main/java/io/netty/handler/codec/http/HttpChunkedInput.java
+++ b/codec-http/src/main/java/io/ne... | diff --git a/handler/src/test/java/io/netty/handler/stream/ChunkedWriteHandlerTest.java b/handler/src/test/java/io/netty/handler/stream/ChunkedWriteHandlerTest.java
index 54879929384..204e140f4b5 100644
--- a/handler/src/test/java/io/netty/handler/stream/ChunkedWriteHandlerTest.java
+++ b/handler/src/test/java/io/netty... | test | train | 2014-08-13T16:40:34 | 2014-08-05T20:46:21Z | trustin | val |
netty/netty/2022_2790 | netty/netty | netty/netty/2022 | netty/netty/2790 | [
"timestamp(timedelta=16.0, similarity=0.9867336731736773)"
] | 075190f7114c734b515db7302b84b48952d748f5 | acbb12c257df2df732ec653ff678ea39bf85f3c5 | [
"@normanmaurer Maybe it is already done? It seems can be assigned by `ChannelConfig`. \n",
"@plucury this is used for all. I may need this per ChannelHandlerContext.\n",
"@normanmaurer Ah, I see. So we need keep a `ByteBufAllocator` instance in `AbstractChannelHandlerContext`, right?\n",
"I don't think we ... | [] | 2014-08-19T10:00:37Z | [
"feature"
] | Allow to set a specific ByteBufAllocator for a ChannelHandlerContext | Sometimes it would be useful to use a different ByteBufAllocator for different ChannelHandlerContext's (and so the handlers which are assigned to them).
Maybe we can make it possible.
| [
"transport/src/main/java/io/netty/channel/AbstractChannelHandlerContext.java",
"transport/src/main/java/io/netty/channel/ChannelHandlerContext.java"
] | [
"transport/src/main/java/io/netty/channel/AbstractChannelHandlerContext.java",
"transport/src/main/java/io/netty/channel/ChannelHandlerContext.java"
] | [] | diff --git a/transport/src/main/java/io/netty/channel/AbstractChannelHandlerContext.java b/transport/src/main/java/io/netty/channel/AbstractChannelHandlerContext.java
index ad914d05eed..9d5ddd437e0 100644
--- a/transport/src/main/java/io/netty/channel/AbstractChannelHandlerContext.java
+++ b/transport/src/main/java/io/... | null | val | train | 2014-08-18T19:07:49 | 2013-11-30T12:57:37Z | normanmaurer | val |
netty/netty/2779_2802 | netty/netty | netty/netty/2779 | netty/netty/2802 | [
"timestamp(timedelta=2429.0, similarity=0.9154252787991187)"
] | 21bc279700928a568f1c75940f88fb27c43b9421 | 226bc9d49bba81c3f0866530f7ffd8960f870f55 | [
"The HTTP/1.x translation layer needs to be notified when ever a node's parent changes. The interface for `Http2Connection.Listener.streamPriorityChanged` lends itself to this but is not invoked for all parent change events. Should this be invoked in a different spot(s)? For example is the `DefaultHttp2OutboundF... | [
"@nmittler - I could use some feedback/advice from you here.\n",
"I think we might need to notify the listener in 2 passes: once before we make the changes and once after the changes are complete.\n\nNotifying the listener before the changes allows the flow controller to properly decrement pendingBytes for a node... | 2014-08-21T05:34:35Z | [] | HTTP/2 Priority Tree Event Notification | Through investigation and discussion in PR https://github.com/netty/netty/pull/2775 there needs to be more investigation into the current implementation of the `Http2Connection.Listener` interface with respect to tree restructuring and listener notification.
| [
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2Connection.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2OutboundFlowController.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/Http2Connection.java",
"codec-http2/src/main/java/io/netty/handler/cod... | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2Connection.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2OutboundFlowController.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/Http2Connection.java",
"codec-http2/src/main/java/io/netty/handler/cod... | [
"codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionTest.java",
"codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2OutboundFlowControllerTest.java"
] | diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2Connection.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2Connection.java
index 8b4ec6f1feb..58dc6fe4285 100644
--- a/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2Connection.java
+++ b/codec-... | diff --git a/codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionTest.java b/codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionTest.java
index 827f947a1dc..46596cd3f96 100644
--- a/codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionTest.java
... | train | train | 2014-08-21T20:49:12 | 2014-08-17T17:30:28Z | Scottmitch | val |
netty/netty/2497_2805 | netty/netty | netty/netty/2497 | netty/netty/2805 | [
"timestamp(timedelta=25.0, similarity=0.9598137742447445)"
] | d3538dee2ecdcb7254f44e5974225ec7ce0655d3 | 91ba156f29024fc5f0b1a8dc4a2bb34a17c917e5 | [
"@nmittler is this still something we need ?\n",
"@normanmaurer yeah we're still out of spec WRT padding. It's low priority though and can wait until after we get draft 14 support.\n",
"Draft 14 is tracked in issue https://github.com/netty/netty/issues/2715. \n",
"Fixed by #2805\n"
] | [
"Isn't this still deferring all the padding until the last frame on the split?\n",
"I thought this was to address the TODO, but I see the PR description does not focus on addressing how to split padding. If this does not address the TODO then leave it in there until we cover it.\n",
"Should we open another iss... | 2014-08-21T20:49:28Z | [] | Add padding length to HTTP/2 flow control | We're currently out-of-spec with HTTP/2, which requires that any padding be included in the flow-controlled bytes.
| [
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2InboundFlowController.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2OutboundFlowController.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/Http2InboundFlowController.java"
] | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2InboundFlowController.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2OutboundFlowController.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/Http2InboundFlowController.java"
] | [
"codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2InboundFlowControllerTest.java",
"codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2OutboundFlowControllerTest.java"
] | diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2InboundFlowController.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2InboundFlowController.java
index 83bb670b11d..dd9c0427983 100644
--- a/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2Inboun... | diff --git a/codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2InboundFlowControllerTest.java b/codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2InboundFlowControllerTest.java
index d2bffd06843..d3b5d326de9 100644
--- a/codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHtt... | train | train | 2014-08-22T22:07:22 | 2014-05-13T22:11:17Z | nmittler | val |
netty/netty/2826_2827 | netty/netty | netty/netty/2826 | netty/netty/2827 | [
"timestamp(timedelta=50.0, similarity=0.8558067741127687)"
] | 6409a5a1d55b1922b9d40ac8ed6c05a6e2261f47 | 7838e01a96c9e126600b0788fa8790114f035370 | [
"PR https://github.com/netty/netty/pull/2827 addresses this issue\n",
"@Scottmitch cherry-picked your change. Thanks!\n"
] | [] | 2014-08-26T20:53:15Z | [
"cleanup"
] | .gitignore missing bin/ directory | The netty project's .gitignore is missing an entry for `bin/`. This directory is created by eclipse and maintained by eclipse. Even though the IDE of choice is intellij the .gitignore should have a `bin/` entry under the Eclipse section to exclude this directory.
| [
".gitignore"
] | [
".gitignore"
] | [] | diff --git a/.gitignore b/.gitignore
index 8a80d67d0d9..822e92dda03 100644
--- a/.gitignore
+++ b/.gitignore
@@ -2,6 +2,7 @@
.project
.classpath
.settings
+bin/
# IntelliJ IDEA project files and directories
*.iml
| null | train | train | 2014-08-26T21:02:05 | 2014-08-26T20:45:18Z | Scottmitch | val |
netty/netty/2848_2849 | netty/netty | netty/netty/2848 | netty/netty/2849 | [
"timestamp(timedelta=25.0, similarity=0.905243869713583)"
] | cc55a71b14fbe1342ae0109bf54143f7d775c40d | 9c7c26873eb7b327f87b344dcc6891589a636a98 | [
"Pull request #2849 has a proposed fix.\n",
"Was fixed \n"
] | [
"you should only check for `==`. `size` can never be greater than `maxCapacity`.\n",
"`testMaxCapacity` and add a link to your bug report please.\n",
"maybe wrap everything in a loop that tests this with a few random `maxCapacity` values between [1,1000).\n",
"Well, that was actually part of the issue. The or... | 2014-08-30T07:40:42Z | [
"defect"
] | Recycler maxCapcity can be ignored | If `maxCapcity` is not a power of two and greater than 256, it's completely ignored by `Recycler`. This allows caching an infinite number of `Recycler` objects until memory is exhausted.
`Recycler.Stack.push()` only checks against `maxCapacity` when the `elements` array is full. However, that array is reallocated in p... | [
"common/src/main/java/io/netty/util/Recycler.java"
] | [
"common/src/main/java/io/netty/util/Recycler.java"
] | [
"common/src/test/java/io/netty/util/RecyclerTest.java"
] | diff --git a/common/src/main/java/io/netty/util/Recycler.java b/common/src/main/java/io/netty/util/Recycler.java
index a56499cd7b8..0600f66d70f 100644
--- a/common/src/main/java/io/netty/util/Recycler.java
+++ b/common/src/main/java/io/netty/util/Recycler.java
@@ -96,6 +96,10 @@ public final boolean recycle(T o, Handle... | diff --git a/common/src/test/java/io/netty/util/RecyclerTest.java b/common/src/test/java/io/netty/util/RecyclerTest.java
index 5212e9b4df5..91114344b6a 100644
--- a/common/src/test/java/io/netty/util/RecyclerTest.java
+++ b/common/src/test/java/io/netty/util/RecyclerTest.java
@@ -15,6 +15,8 @@
*/
package io.netty.uti... | train | train | 2014-08-30T20:53:07 | 2014-08-30T07:33:03Z | kichik | val |
netty/netty/2719_2860 | netty/netty | netty/netty/2719 | netty/netty/2860 | [
"timestamp(timedelta=32.0, similarity=0.876096460955986)"
] | 6d1b96fb632026042b6e7009d39a8db7486944eb | 2fff75975674f9afc1bf134d393108a0b73a9c58 | [
"Added to 4.0, 4.1 and master \n"
] | [] | 2014-09-03T12:57:26Z | [
"feature"
] | Support gathering/scattering in EpollDatagramChannel | As @pcarrier pointed out on monday it is possible to do gathering writes even when using datagram/udp on linux. We should add support for it:
See http://man7.org/linux/man-pages/man2/send.2.html
| [
"transport-native-epoll/src/main/c/io_netty_channel_epoll_Native.c",
"transport-native-epoll/src/main/c/io_netty_channel_epoll_Native.h",
"transport-native-epoll/src/main/java/io/netty/channel/epoll/EpollDatagramChannel.java",
"transport-native-epoll/src/main/java/io/netty/channel/epoll/EpollSocketChannel.jav... | [
"transport-native-epoll/src/main/c/io_netty_channel_epoll_Native.c",
"transport-native-epoll/src/main/c/io_netty_channel_epoll_Native.h",
"transport-native-epoll/src/main/java/io/netty/channel/epoll/EpollDatagramChannel.java",
"transport-native-epoll/src/main/java/io/netty/channel/epoll/EpollSocketChannel.jav... | [
"testsuite/src/test/java/io/netty/testsuite/transport/socket/DatagramUnicastTest.java"
] | diff --git a/transport-native-epoll/src/main/c/io_netty_channel_epoll_Native.c b/transport-native-epoll/src/main/c/io_netty_channel_epoll_Native.c
index 52be419d943..5dc7eb5825d 100644
--- a/transport-native-epoll/src/main/c/io_netty_channel_epoll_Native.c
+++ b/transport-native-epoll/src/main/c/io_netty_channel_epoll_... | diff --git a/testsuite/src/test/java/io/netty/testsuite/transport/socket/DatagramUnicastTest.java b/testsuite/src/test/java/io/netty/testsuite/transport/socket/DatagramUnicastTest.java
index 0ab73a96136..07dd9ded4ca 100644
--- a/testsuite/src/test/java/io/netty/testsuite/transport/socket/DatagramUnicastTest.java
+++ b/... | train | train | 2014-09-09T06:36:40 | 2014-08-01T00:29:56Z | normanmaurer | val |
netty/netty/2862_2863 | netty/netty | netty/netty/2862 | netty/netty/2863 | [
"timestamp(timedelta=21.0, similarity=0.9999999999999999)"
] | fc45473e7975f18fc27dbbd147ab67828e72ad2d | 7b19ba508cc0f84702c0787409b7284f73290247 | [
"Addressed with aba28d4fef2e3bc7b5afe41662ad0672828d548d\n"
] | [
"replace `i * 2` with `i << 1`. Bit-shifting for the win ;)\n",
"Good call! Done.\n",
"This can be collapsed to else if (...)\n",
"Done.\n",
"Kill it or fill it ;)\n",
"I was sneaky on this one. Look at the below lines for the `<ul>...</ul>`. Is OK?\n",
"Ah sorry missed this.. Sounds good :)\n",
"Do... | 2014-09-04T10:59:21Z | [
"feature"
] | IPv6 address to string rfc5952 | The java docs/spec for [Inet6Address.getHostName](http://docs.oracle.com/javase/7/docs/api/java/net/InetAddress.html#getHostName%28%29) does not specify the RFC's recommended string representation (http://tools.ietf.org/html/rfc5952#section-4). Therefore implementations of this method may provide varying results. It ... | [
"common/src/main/java/io/netty/util/NetUtil.java"
] | [
"common/src/main/java/io/netty/util/NetUtil.java"
] | [
"common/src/test/java/io/netty/util/NetUtilTest.java",
"microbench/src/test/java/io/netty/microbenchmark/common/NetUtilBenchmark.java"
] | diff --git a/common/src/main/java/io/netty/util/NetUtil.java b/common/src/main/java/io/netty/util/NetUtil.java
index 307c5a3196b..3a1f1057e0c 100644
--- a/common/src/main/java/io/netty/util/NetUtil.java
+++ b/common/src/main/java/io/netty/util/NetUtil.java
@@ -27,6 +27,7 @@
import java.net.InetAddress;
import java.ne... | diff --git a/common/src/test/java/io/netty/util/NetUtilTest.java b/common/src/test/java/io/netty/util/NetUtilTest.java
index fa36514a8cc..1d9867bf0df 100644
--- a/common/src/test/java/io/netty/util/NetUtilTest.java
+++ b/common/src/test/java/io/netty/util/NetUtilTest.java
@@ -15,13 +15,20 @@
*/
package io.netty.util... | val | train | 2014-09-22T15:12:20 | 2014-09-04T08:00:13Z | Scottmitch | val |
netty/netty/2889_2890 | netty/netty | netty/netty/2889 | netty/netty/2890 | [
"timestamp(timedelta=249.0, similarity=0.902667567681132)"
] | c6b2c5a3201cfd2dbd9e4244a3577950b4e9e69c | 00c0938f16921e92e5aaf175b2f38227aa9f49ee | [
"Here is my sendmmsg from bits/socket.h\n\n> /\\* Send a VLEN messages as described by VMESSAGES to socket FD.\n> Return the number of datagrams successfully written or -1 for errors.\n> This function is a cancellation point and therefore not marked with\n> __THROW. */\n> extern int sendmmsg (int __fd, struc... | [] | 2014-09-12T19:31:17Z | [
"defect"
] | trasport/native/epoll build failure | Are their version requirements listed somewhere for netty's epoll? I'm getting a build failure in some of the native code involving type redefinitions.
**OS info**
Ubuntu 12.04
> $uname -a
> Linux <name> 3.2.0-67-generic #101-Ubuntu SMP Tue Jul 15 17:46:11 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
>
> $ mvn --version... | [
"transport-native-epoll/pom.xml",
"transport-native-epoll/src/main/c/io_netty_channel_epoll_Native.c"
] | [
"transport-native-epoll/pom.xml",
"transport-native-epoll/src/main/c/io_netty_channel_epoll_Native.c"
] | [] | diff --git a/transport-native-epoll/pom.xml b/transport-native-epoll/pom.xml
index de1d4727578..02902caf6c4 100644
--- a/transport-native-epoll/pom.xml
+++ b/transport-native-epoll/pom.xml
@@ -78,6 +78,9 @@
<platform>.</platform>
<forceConfigure>true</forceConfigure>
<forceA... | null | train | train | 2014-09-15T15:14:15 | 2014-09-12T17:40:00Z | Scottmitch | val |
netty/netty/2906_2907 | netty/netty | netty/netty/2906 | netty/netty/2907 | [
"timestamp(timedelta=15.0, similarity=0.9111227419072077)"
] | 764e6c3bb719b3542c3ae20db61cccec8122e0cb | 66c3073f21b60dd728f59cecc668ce74d012f155 | [
"@nmittler Do you see any issues with moving the `Http2InboundFlowController` from `AbstractHttp2ConnectionHandler` to `DefaultHttp2FrameReader`?\n\nIf this is OK then for consistency I may also doing the same thing for the `Http2OutboundFlowController` (moving it to `DefaultHttp2FrameWriter`)\n",
"@nmittler - On... | [
"Maybe we should have a base class called Http2FrameListenerDecorator? WDYT?\n",
"maybe just return here ... so no need for else?\n",
"Should we do this in a finally block?\n",
"May be just my personal preference, so feel free to ignore .... maybe consider if (stream == null ) return ... that way the rest of ... | 2014-09-17T22:44:31Z | [
"defect"
] | HTTP/2 Decompressor flow control interaction error | The `DecompressorHttp2FrameReader` is intercepting and decompressing `ByteBuf` objects before the `onDataRead` method is called. However the uncompressed size of the content is being counted against the flow control window instead of the compressed size (which was actually sent over the wire). This will result in `PR... | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/DecompressorHttp2FrameReader.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2FrameReader.java",
"example/src/main/java/io/netty/example/http2/client/Http2ClientInitializer.java"
] | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2FrameReader.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/DelegatingDecompressorFrameListener.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/Http2FrameListenerDecorator.java",
"example/src/main/java/io/netty/e... | [
"codec-http2/src/test/java/io/netty/handler/codec/http2/DataCompressionHttp2Test.java"
] | diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/DecompressorHttp2FrameReader.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/DecompressorHttp2FrameReader.java
deleted file mode 100644
index 5de289320f0..00000000000
--- a/codec-http2/src/main/java/io/netty/handler/codec/http2/Decompress... | diff --git a/codec-http2/src/test/java/io/netty/handler/codec/http2/DataCompressionHttp2Test.java b/codec-http2/src/test/java/io/netty/handler/codec/http2/DataCompressionHttp2Test.java
index e07baabee0d..53357f9b37e 100644
--- a/codec-http2/src/test/java/io/netty/handler/codec/http2/DataCompressionHttp2Test.java
+++ b/... | test | train | 2014-09-21T16:02:40 | 2014-09-17T18:46:02Z | Scottmitch | val |
netty/netty/2971_2972 | netty/netty | netty/netty/2971 | netty/netty/2972 | [
"timestamp(timedelta=6595.0, similarity=0.8875179716498717)"
] | 276b826b59bfa4536f6ca336bbb70e94b2b559aa | 4990817430e31bba920e1d7db7a5f2b962b46cad | [
"Fix is provided in #2972 \n"
] | [
"Nit: Consider saving a reference to the `(FullHttpResponse) msg` here to avoid casting multiple times.\n",
"done\n"
] | 2014-10-06T22:11:38Z | [
"defect"
] | WebSocketClientProtocolHandshakeHandler leaks | The new unit test in #2970 did not found the issue it intended to check but therefore it still detected that there's a leak somewhere. It seems to be in the WebSocketClientProtocolHandshakeHandler which does never release the received HTTP handshake response. The log which shows the leak is attached below:
```
05:39:... | [
"codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketClientProtocolHandshakeHandler.java"
] | [
"codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketClientProtocolHandshakeHandler.java"
] | [] | diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketClientProtocolHandshakeHandler.java b/codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketClientProtocolHandshakeHandler.java
index f9b8b40c314..bc832510819 100644
--- a/codec-http/src/main/java/io/netty/handler/c... | null | val | train | 2014-10-05T04:12:49 | 2014-10-06T22:05:00Z | Matthias247 | val |
netty/netty/2930_2979 | netty/netty | netty/netty/2930 | netty/netty/2979 | [
"timestamp(timedelta=24.0, similarity=0.8579470291274585)"
] | 276b826b59bfa4536f6ca336bbb70e94b2b559aa | 1cb403f5d63abc43437bc827f16c2a28fbb0b901 | [
"Problems associated with this issue (if it is possible we are missing exceptions):\n1. Not setting promise object failure clauses (and thus not completing them)\n2. Leaking buffers (i.e. https://github.com/netty/netty/blob/master/codec-http2/src/main/java/io/netty/handler/codec/http2/AbstractHttp2ConnectionHandler... | [
"@normanmaurer - Can you weigh in on this. `isOpen()` seems to be lower in the state hierarchy...should we be using this method?\n",
"remote -> local\n",
"@nmittler - The `onException` method is calling `toHttp2Exception` which seems to do some duplicate work as the `getEmbeddedHttp2Exception` method called h... | 2014-10-08T21:18:43Z | [
"defect"
] | HTTP/2 AbstractHttp2ConnectionHandler exception catching | @nmittler - Is it possible that other exception types are thrown in methods `AbstractHttp2ConnectionHandler` is calling that we are not catching? Should we be catching a more general exception type than `Http2Exception`? For example maybe just `Exception` or `Throwable`? What if an unchecked exception is thrown some... | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionDecoder.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionEncoder.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/Http2CodecUtil.java",
"codec-http2/src/main/java/io/netty/handler/co... | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionDecoder.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionEncoder.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/Http2CodecUtil.java",
"codec-http2/src/main/java/io/netty/handler/co... | [
"codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionDecoderTest.java",
"codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionEncoderTest.java",
"codec-http2/src/test/java/io/netty/handler/codec/http2/Http2ConnectionHandlerTest.java",
"codec-http2/src/test/java... | diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionDecoder.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionDecoder.java
index 3dea034e1be..310e10a8b48 100644
--- a/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionDeco... | diff --git a/codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionDecoderTest.java b/codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionDecoderTest.java
index d9c671b5c9b..9de6880a0e7 100644
--- a/codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2Connec... | test | train | 2014-10-05T04:12:49 | 2014-09-23T02:19:36Z | Scottmitch | val |
netty/netty/2986_2991 | netty/netty | netty/netty/2986 | netty/netty/2991 | [
"timestamp(timedelta=119735.0, similarity=0.9411294219327737)"
] | ce817e0d309c69e15d7773c52468838a6e6849b2 | 1db5b4b63005e443f2e26c26190781b1ca6b8d08 | [
"@nmittler I think @normanmaurer cherry-picked and closed your PR. Can this be closed?\n",
"I think so :)\n\n> Am 14.10.2014 um 22:39 schrieb Scott Mitchell notifications@github.com:\n> \n> @nmittler I think @normanmaurer cherry-picked and closed your PR. Can this be closed?\n> \n> —\n> Reply to this email direc... | [] | 2014-10-09T23:15:31Z | [
"cleanup"
] | Cleanup HTTP/2 GO_AWAY methods | Right now the determination of whether GO_AWAY was sent or received is a little confusing since each endpoint has a goAwayReceived() method. This means that to determine if GO_AWAY was sent we would have to call connection.remote().goAwayReceived() which is a little clumsy and strange.
It would probably be better to ... | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2Connection.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionDecoder.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/Http2Connection.java",
"codec-http2/src/main/java/io/netty/handler/codec/ht... | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2Connection.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionDecoder.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/Http2Connection.java",
"codec-http2/src/main/java/io/netty/handler/codec/ht... | [
"codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionDecoderTest.java",
"codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionTest.java"
] | diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2Connection.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2Connection.java
index c69cc5bec21..043c2b8d9d1 100644
--- a/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2Connection.java
+++ b/codec-... | diff --git a/codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionDecoderTest.java b/codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionDecoderTest.java
index 9de6880a0e7..b660542aadf 100644
--- a/codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2Connec... | train | train | 2014-10-10T00:13:57 | 2014-10-09T16:18:29Z | nmittler | val |
netty/netty/2998_3000 | netty/netty | netty/netty/2998 | netty/netty/3000 | [
"timestamp(timedelta=115825.0, similarity=0.9901557196938808)"
] | ce817e0d309c69e15d7773c52468838a6e6849b2 | 74109c0b5959a9e92506506b24878ffc7afd9999 | [
"Now I'm thinking this is an issue because our netty client example reliably times out in this case. The server (netty server example) prints that it sent everything, but the client hangs after processing the headers.\n\n**Server**\n\n``` bash\nSelected Protocol is HTTP_2\nOct 10, 2014 3:57:45 PM io.netty.handler.... | [] | 2014-10-10T22:36:01Z | [
"defect"
] | HTTP/2 server example not using flow controller | @nmittler - I'd like to get your input on the following. I have a non-netty server communicating with a netty client. All is well on this front ;). However I am trying to interact with my server from curl. I am having issues getting curl to read all data for multiple frames from my server and so naturally I tried n... | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/Http2ConnectionHandler.java",
"example/src/main/java/io/netty/example/http2/server/HelloWorldHttp2Handler.java"
] | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/Http2ConnectionHandler.java",
"example/src/main/java/io/netty/example/http2/server/HelloWorldHttp2Handler.java"
] | [] | diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2ConnectionHandler.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2ConnectionHandler.java
index 7d53e3cd093..19575ec2726 100644
--- a/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2ConnectionHandler.java
+++ b/codec-... | null | train | train | 2014-10-10T00:13:57 | 2014-10-10T19:47:21Z | Scottmitch | val |
netty/netty/3013_3016 | netty/netty | netty/netty/3013 | netty/netty/3016 | [
"timestamp(timedelta=13.0, similarity=0.864423459913442)"
] | 5904c473164bc6849d0b4b9e7094da214e80c684 | dfe06fcddffd5a5a741427d2d1eaa5655949a135 | [
"@nmittler fyi\n",
"@Scottmitch this is addressed by #3016\n"
] | [] | 2014-10-16T15:51:44Z | [] | New twitter hpack release | [0.9.1](https://github.com/twitter/hpack/releases/tag/v0.9.1) was released. We should pull this in for the http2 codec and examples.
| [
"codec-http2/pom.xml",
"pom.xml"
] | [
"codec-http2/pom.xml",
"pom.xml"
] | [] | diff --git a/codec-http2/pom.xml b/codec-http2/pom.xml
index 5f79e09c96a..b3710b63f18 100644
--- a/codec-http2/pom.xml
+++ b/codec-http2/pom.xml
@@ -43,7 +43,6 @@
<dependency>
<groupId>com.twitter</groupId>
<artifactId>hpack</artifactId>
- <version>0.9.0</version>
</dependency>
<depend... | null | val | train | 2014-10-16T10:57:10 | 2014-10-16T02:04:33Z | Scottmitch | val |
netty/netty/3027_3034 | netty/netty | netty/netty/3027 | netty/netty/3034 | [
"timestamp(timedelta=64.0, similarity=0.8550309335091857)"
] | 222d258d6e62b1b204c741d844033061a431ee75 | 30437db456b7f0be20cadb400d7197138995a83f | [
"@nmittler - FYI. There is some info in section [5.1.1](https://tools.ietf.org/html/draft-ietf-httpbis-http2-14#section-5.1.1) related to this condition.\n",
"For the writer portion of this it is also possible we put this responsibility on the users of the http2-codec? The http translation layer does allow user... | [
"@nmittler - Can you verify this change...I think this was a bug.\n",
"@nmittler - Note that I had an argument capture here to free the debug buffer but it is already freed.\n",
"@Scottmitch oof yeah I think you're right. Good catch!\n",
"I don't think we should catch it here. We should catch it in the enco... | 2014-10-22T00:17:15Z | [
"defect"
] | HTTP/2 stream id roll over behavior | It does not look like there is any code to handle the case where stream IDs roll over the largest number. What is the expected behavior in this condition? The client may want to open a new connection in this case to continue issuing requests.
Should this condition be checked for incoming and outgoing frames?
| [
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2Connection.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionEncoder.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/Http2ConnectionHandler.java",
"codec-http2/src/main/java/io/netty/handler/c... | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2Connection.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionEncoder.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/Http2ConnectionHandler.java",
"codec-http2/src/main/java/io/netty/handler/c... | [
"codec-http2/src/test/java/io/netty/handler/codec/http2/Http2ConnectionRoundtripTest.java"
] | diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2Connection.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2Connection.java
index 2775ed745fa..635d755dbc1 100644
--- a/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2Connection.java
+++ b/codec-... | diff --git a/codec-http2/src/test/java/io/netty/handler/codec/http2/Http2ConnectionRoundtripTest.java b/codec-http2/src/test/java/io/netty/handler/codec/http2/Http2ConnectionRoundtripTest.java
index 6aaf1682938..6491ced9015 100644
--- a/codec-http2/src/test/java/io/netty/handler/codec/http2/Http2ConnectionRoundtripTest... | train | train | 2014-10-22T15:26:31 | 2014-10-20T14:38:38Z | Scottmitch | val |
netty/netty/3017_3041 | netty/netty | netty/netty/3017 | netty/netty/3041 | [
"timestamp(timedelta=13446.0, similarity=0.9305338663498393)"
] | f8af84d5993456426a63ad0146479147b1a4a5e5 | 5e86822c08668b93f81131948f190ba30a3a95fc | [
"@trustin @nmittler @normanmaurer - This is more of a question at this point because I see that the existing JdkSslClientContext uses `null` for the `SSLContext.init(...)` calls for everything but the `TrustStore`. See [here](https://github.com/netty/netty/blob/master/handler/src/main/java/io/netty/handler/ssl/Jdk... | [] | 2014-10-22T17:38:43Z | [
"feature"
] | ssl mutual authentication (JDK provider) | I have a usecase that requires a client to do mutual authentication. I have seen a few stackoverflow posts related to achieving mutual auth by setting up the `SSLContext` manually, and then invoking `SSLEngine.setNeedClientAuth(true)` before putting this SSLEngine into the pipeline. I am using `SslContext.newClientCo... | [
"handler/src/main/java/io/netty/handler/ssl/JdkSslClientContext.java",
"handler/src/main/java/io/netty/handler/ssl/JdkSslContext.java",
"handler/src/main/java/io/netty/handler/ssl/JdkSslServerContext.java",
"handler/src/main/java/io/netty/handler/ssl/SslContext.java"
] | [
"handler/src/main/java/io/netty/handler/ssl/JdkSslClientContext.java",
"handler/src/main/java/io/netty/handler/ssl/JdkSslContext.java",
"handler/src/main/java/io/netty/handler/ssl/JdkSslServerContext.java",
"handler/src/main/java/io/netty/handler/ssl/SslContext.java"
] | [
"handler/src/test/java/io/netty/handler/ssl/JdkSslEngineTest.java",
"handler/src/test/java/io/netty/handler/ssl/JdkSslServerContextTest.java",
"handler/src/test/resources/io/netty/handler/ssl/test2.crt",
"handler/src/test/resources/io/netty/handler/ssl/test2_encrypted.pem",
"handler/src/test/resources/io/ne... | diff --git a/handler/src/main/java/io/netty/handler/ssl/JdkSslClientContext.java b/handler/src/main/java/io/netty/handler/ssl/JdkSslClientContext.java
index 7d4e7166c86..479bb24e570 100644
--- a/handler/src/main/java/io/netty/handler/ssl/JdkSslClientContext.java
+++ b/handler/src/main/java/io/netty/handler/ssl/JdkSslCl... | diff --git a/handler/src/test/java/io/netty/handler/ssl/JdkSslEngineTest.java b/handler/src/test/java/io/netty/handler/ssl/JdkSslEngineTest.java
index 3b3f60b59a7..41b2da74364 100644
--- a/handler/src/test/java/io/netty/handler/ssl/JdkSslEngineTest.java
+++ b/handler/src/test/java/io/netty/handler/ssl/JdkSslEngineTest.... | train | train | 2014-10-31T00:39:31 | 2014-10-16T16:32:49Z | Scottmitch | val |
netty/netty/3057_3058 | netty/netty | netty/netty/3057 | netty/netty/3058 | [
"timestamp(timedelta=3773.0, similarity=0.886181733809813)"
] | a9bd9699a49ee79602414e9ee9a88da42bcd371b | 204b45c8e1c61544283cdddc34fc70470d3f661f | [
"Hi @Lekanich and thanks for reaching out. We will need a few more details to narrow in on the issue:\n- What version of netty are you using?\n- What is your system configuration (`mvn --version`)?\n- Are you using openssl or JDK providers for SSL?\n- Where is the location in the code that the buffer is not being ... | [
"use `newDirectIn.internalNioBuffer(0, newDirectIn.readableBytes()` . This way you also not need to reset the reader index.\n",
"Good call. Done.\n"
] | 2014-10-27T17:49:49Z | [
"defect"
] | SslHandler - DirectByteBuffer - OutOfMemory | I tested the performance of my project with and without SSL (configuration: 25 threads that run 10 more threads (total 250) each of them refers to the server for download the file).
Test without Ssl completed without error, but the test with Ssl threw </code>OutOfMemoryError</code> when SslHandler trying to create the... | [
"handler/src/main/java/io/netty/handler/ssl/SslHandler.java"
] | [
"handler/src/main/java/io/netty/handler/ssl/SslHandler.java"
] | [] | diff --git a/handler/src/main/java/io/netty/handler/ssl/SslHandler.java b/handler/src/main/java/io/netty/handler/ssl/SslHandler.java
index 40ef0ce5637..9ea071d5292 100644
--- a/handler/src/main/java/io/netty/handler/ssl/SslHandler.java
+++ b/handler/src/main/java/io/netty/handler/ssl/SslHandler.java
@@ -436,6 +436,7 @@... | null | train | train | 2014-10-25T14:48:34 | 2014-10-27T14:07:32Z | Lekanich | val |
netty/netty/3072_3073 | netty/netty | netty/netty/3072 | netty/netty/3073 | [
"timestamp(timedelta=18.0, similarity=0.9003473515919903)"
] | 1914b77c71ff820b8c4ae0b5a3a06091b7fc82d1 | db05c5415aae3e61109b8fca439933ee9ee3fbc6 | [
"@normanmaurer and @trustin - Thoughts?\n",
"PR https://github.com/netty/netty/pull/3073 demonstrates using the `wantsDirectBuffer` variable to prevent requiring a direct byte buffer on every wrap. This could be a big savings if non-direct byte buffers are used and direct byte buffers are not required (i.e. JDK ... | [
"This sounds legit... @trustin agree ? \n"
] | 2014-10-29T18:13:18Z | [
"improvement"
] | SslHandler wrap unconditionally copying to direct buffer | In light of a recent bug fix (https://github.com/netty/netty/pull/3058) it became evident that the SslHander wrap method was (and is still) unconditionally requiring a direct ByteBuffer for the input buffer to the SSLEngine.wrap() operation [here](https://github.com/netty/netty/blob/4.0/handler/src/main/java/io/netty/h... | [
"handler/src/main/java/io/netty/handler/ssl/SslHandler.java"
] | [
"handler/src/main/java/io/netty/handler/ssl/SslHandler.java"
] | [] | diff --git a/handler/src/main/java/io/netty/handler/ssl/SslHandler.java b/handler/src/main/java/io/netty/handler/ssl/SslHandler.java
index 9ea071d5292..3b683ff1e0c 100644
--- a/handler/src/main/java/io/netty/handler/ssl/SslHandler.java
+++ b/handler/src/main/java/io/netty/handler/ssl/SslHandler.java
@@ -182,7 +182,7 @@... | null | train | train | 2014-10-29T11:48:40 | 2014-10-29T18:05:03Z | Scottmitch | val |
netty/netty/3084_3086 | netty/netty | netty/netty/3084 | netty/netty/3086 | [
"timestamp(timedelta=233.0, similarity=0.9226550345829467)"
] | 8235337d4e82ea8475e15e90789119caea48e159 | d7e145bd01d3bf81523233c4440039803225ccca | [
"@nmittler - FYI. This may be more general problem to whenever the windows sizes are used. We should be handling the case where they can be negative.\n",
"@Scottmitch yup, agreed. I'll take a look.\n",
"Opps sorry about stealing the assignment. I have a fix I think.\n",
"I'll submit a PR and we can go fro... | [] | 2014-10-31T18:14:13Z | [
"defect"
] | HTTP/2 outbound flow controller negative write size exception | We are not handling the case where the `writableWindow()` can be negative in the `DefaultHttp2OutboundFlowController` which is resulting in an `IllegalArgumentException` exception when trying to get a negatively sized buffer.
The `writableWindow()` is negative [here](https://github.com/netty/netty/blob/master/codec-ht... | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2OutboundFlowController.java"
] | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2OutboundFlowController.java"
] | [
"codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2OutboundFlowControllerTest.java"
] | diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2OutboundFlowController.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2OutboundFlowController.java
index e3d55cc7ce4..bfaa70327db 100644
--- a/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2Outb... | diff --git a/codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2OutboundFlowControllerTest.java b/codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2OutboundFlowControllerTest.java
index 3fe2e0b2092..b026243bbb3 100644
--- a/codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultH... | train | train | 2014-10-31T18:59:25 | 2014-10-31T15:46:11Z | Scottmitch | val |
netty/netty/3085_3088 | netty/netty | netty/netty/3085 | netty/netty/3088 | [
"timestamp(timedelta=72577.0, similarity=0.958106215902029)"
] | d5042baf58293db8429ef0c42137edc66c266020 | b9cfb62ea686911595f3c652c2a566216c233506 | [
"Good catch\n",
"Addressed by #3088\n",
"Cherry-picked by @nmittler \n"
] | [
"Wording is a bit awkward. Consider clarifying..\n\nReturns the most {@link ChannelFuture} -> Returns the {@link ChannelFuture}\n",
"What about continuation frames? Do we even send continuation frames or are we queuing up header writes until the endofstream happens somewhere?\n",
"Is this needed if you are on... | 2014-10-31T21:17:34Z | [
"defect"
] | HTTP/2 HEADERS frames need to stay in-place WRT DATA frames. | Since DATA frames are flow controlled and HEADERS are not, a HEADERS frame sent after DATA (e.g. trailers) can be sent out-of-order due to flow control restrictions. We need to preserve the original ordering.
| [
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionEncoder.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2OutboundFlowController.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/Http2OutboundFlowController.java"
] | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionEncoder.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2OutboundFlowController.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/Http2OutboundFlowController.java"
] | [
"codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionEncoderTest.java",
"codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2OutboundFlowControllerTest.java",
"codec-http2/src/test/java/io/netty/handler/codec/http2/Http2ConnectionRoundtripTest.java",
"codec-http2/src/te... | diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionEncoder.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionEncoder.java
index 70f2d6592e7..5e6be2a8a11 100644
--- a/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionEnco... | diff --git a/codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionEncoderTest.java b/codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionEncoderTest.java
index 1ca69bcb84a..8410ac2939b 100644
--- a/codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2Connec... | train | train | 2014-10-31T21:37:05 | 2014-10-31T15:59:45Z | nmittler | val |
netty/netty/2910_3090 | netty/netty | netty/netty/2910 | netty/netty/3090 | [
"timestamp(timedelta=45.0, similarity=0.8662422963744304)"
] | d5042baf58293db8429ef0c42137edc66c266020 | 9a0dcf8ef6cc8fd6e2a7bc1690b10c728d817243 | [
"`DefaultHttpHeaders` already implements the ascii checks (if the `validate` mode is turned on...which is exposed in the HTTP2 translation layer). I think all that needs to be done here is catch the exception that is thrown by this validation (`IllegalArgumentException`) when creating the HTTP headers object and r... | [
"Maybe you could use this utility method to help out here: https://github.com/netty/netty/blob/master/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2CodecUtil.java#L134\n",
"Good idea...done.\n"
] | 2014-11-01T20:43:20Z | [
"defect"
] | HTTP/2 binary headers requires additional validation for HTTP translation layer | As a result of issue #2786 the HTTP translation layer should be doing additional validation.
From @nmittler
> Just a note on the impact of this on the translation to HTTP/1.1 ... Section 10.3 of the spec touches on this: http://tools.ietf.org/html/draft-ietf-httpbis-http2-14#section-10.3
> So it sounds like requests... | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/HttpUtil.java"
] | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/HttpUtil.java"
] | [
"codec-http2/src/test/java/io/netty/handler/codec/http2/InboundHttp2ToHttpAdapterTest.java"
] | diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/HttpUtil.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/HttpUtil.java
index 7572fe46ebd..0dddd8b881f 100644
--- a/codec-http2/src/main/java/io/netty/handler/codec/http2/HttpUtil.java
+++ b/codec-http2/src/main/java/io/netty/handler/codec... | diff --git a/codec-http2/src/test/java/io/netty/handler/codec/http2/InboundHttp2ToHttpAdapterTest.java b/codec-http2/src/test/java/io/netty/handler/codec/http2/InboundHttp2ToHttpAdapterTest.java
index faa037269d1..7c0650e4e37 100644
--- a/codec-http2/src/test/java/io/netty/handler/codec/http2/InboundHttp2ToHttpAdapterT... | train | train | 2014-10-31T21:37:05 | 2014-09-19T02:11:06Z | Scottmitch | val |
netty/netty/2875_3106 | netty/netty | netty/netty/2875 | netty/netty/3106 | [
"timestamp(timedelta=12.0, similarity=0.9442379339087925)"
] | b33901c5a698e373ba6aa73abfe870bcb3f56629 | 3da3f527f9589e7aa4589084e55e99a415232fcb | [
"Note that https://github.com/netty/netty/pull/2907 was introduced to fix bugs in the original decompression code.\n",
"@nmittler - So I have looked at this briefly and have come up with the following options:\n1. Create a class which inherits from `DefaultHttp2OutboundFlowController` that overrides `writeData()`... | [
"@trustin - I think these got moved during the header back port (and then forward port). I think it is better to keep a common definition in the HttpHeaderValue class rather than an independent definition in http/2 and http codec (and potentially spdy). If you agree I will back port the portion related to this ch... | 2014-11-06T04:07:11Z | [
"feature"
] | HTTP/2 data write compression support | The HTTP/2 codec currently does not support compression on data writes. There should be an interface which facilitates compression in the native HTTP/2 codec and also supported by the HTTP/1.x translation layer.
After https://github.com/netty/netty/issues/2793 is resolved their will be an opportunity to follow existin... | [
"codec-http/src/main/java/io/netty/handler/codec/http/HttpContentDecompressor.java",
"codec-http/src/main/java/io/netty/handler/codec/http/HttpHeaderValues.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2Connection.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/Deleg... | [
"codec-http/src/main/java/io/netty/handler/codec/http/HttpContentDecompressor.java",
"codec-http/src/main/java/io/netty/handler/codec/http/HttpHeaderValues.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/CompressorHttp2ConnectionEncoder.java",
"codec-http2/src/main/java/io/netty/handler/codec/h... | [
"codec-http2/src/test/java/io/netty/handler/codec/http2/DataCompressionHttp2Test.java"
] | diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/HttpContentDecompressor.java b/codec-http/src/main/java/io/netty/handler/codec/http/HttpContentDecompressor.java
index 45344677cd0..5fea256a4c0 100644
--- a/codec-http/src/main/java/io/netty/handler/codec/http/HttpContentDecompressor.java
+++ b/codec-htt... | diff --git a/codec-http2/src/test/java/io/netty/handler/codec/http2/DataCompressionHttp2Test.java b/codec-http2/src/test/java/io/netty/handler/codec/http2/DataCompressionHttp2Test.java
index ca5fb29f8b2..876f824eac8 100644
--- a/codec-http2/src/test/java/io/netty/handler/codec/http2/DataCompressionHttp2Test.java
+++ b/... | test | train | 2014-11-06T05:32:26 | 2014-09-09T02:46:12Z | Scottmitch | val |
netty/netty/3157_3158 | netty/netty | netty/netty/3157 | netty/netty/3158 | [
"timestamp(timedelta=104.0, similarity=0.8532341873259105)"
] | c29e703275beffc3b9b127d4cbf5eaae8c5acd08 | 71b643b29e845e1c7bc8a60d9a58ac5f086d1983 | [
"@trustin Not trying to be picky or anything, but wouldn't it be better to call the enum `HttpStatus` or `HttpStatusType` or `HttpStatusCategory` or `HttpStatusGroup` instead of `HttpStatusClass`? Ending it with `Class` just feels weird to me. [Some other synonyms of classification/type](http://www.thesaurus.com/b... | [] | 2014-11-20T10:51:38Z | [
"feature"
] | Add the method that tells the class of HTTP status code to HttpResponseStatus | It should be convenient to have an easy way to classify an HttpResponseStatus based on the first digit of the HTTP status code, as defined in the RFC 2616:
- Information 1xx
- Success 2xx
- Redirection 3xx
- Client Error 4xx
- Server Error 5xx
| [
"codec-http/src/main/java/io/netty/handler/codec/http/HttpResponseStatus.java"
] | [
"codec-http/src/main/java/io/netty/handler/codec/http/HttpResponseStatus.java",
"codec-http/src/main/java/io/netty/handler/codec/http/HttpStatusClass.java"
] | [] | diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/HttpResponseStatus.java b/codec-http/src/main/java/io/netty/handler/codec/http/HttpResponseStatus.java
index 7e4fba3fc98..b5fffee57ae 100644
--- a/codec-http/src/main/java/io/netty/handler/codec/http/HttpResponseStatus.java
+++ b/codec-http/src/main/java... | null | test | train | 2014-11-20T12:41:09 | 2014-11-20T10:23:21Z | trustin | val |
netty/netty/3114_3165 | netty/netty | netty/netty/3114 | netty/netty/3165 | [
"timestamp(timedelta=128033.0, similarity=0.8549278665067631)"
] | 908b68da03eb9b5f20ac5b49ae721f8a8d845f14 | 1f706d0c372196631f6daf1f0ea6f450479587b2 | [
"@Scottmitch I created this based on your suggestion in review of #3098. I figured it made sense to assign to you since you've done the work on the HTTP layer.\n",
"@nmittler - Thanks. I don't think this is tied to the HTTP layer but it is related to other code I have done. I'll put something together after yo... | [] | 2014-11-21T00:31:07Z | [
"improvement"
] | Investigate use of HTTP/2 inbound flow control on decompressor listener | Once #3098 is cherry-picked, the DelegatingDecompressorFrameListener will have the ability to participate in application-level flow control. It currently just opts-out by returning all of the bytes as "processed". We should investigate whether or not it's worth while to make use of inbound flow control in this class.... | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/CompressorHttp2ConnectionEncoder.java"
] | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/CompressorHttp2ConnectionEncoder.java"
] | [
"codec-http2/src/test/java/io/netty/handler/codec/http2/DataCompressionHttp2Test.java"
] | diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/CompressorHttp2ConnectionEncoder.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/CompressorHttp2ConnectionEncoder.java
index 3548609eacb..5adc5e0af51 100644
--- a/codec-http2/src/main/java/io/netty/handler/codec/http2/CompressorHttp2Conne... | diff --git a/codec-http2/src/test/java/io/netty/handler/codec/http2/DataCompressionHttp2Test.java b/codec-http2/src/test/java/io/netty/handler/codec/http2/DataCompressionHttp2Test.java
index 756c2559215..41921516289 100644
--- a/codec-http2/src/test/java/io/netty/handler/codec/http2/DataCompressionHttp2Test.java
+++ b/... | test | train | 2014-11-21T00:42:18 | 2014-11-08T16:34:48Z | nmittler | val |
netty/netty/3079_3177 | netty/netty | netty/netty/3079 | netty/netty/3177 | [
"timestamp(timedelta=108306.0, similarity=0.8638679492524849)"
] | 198f8fa95e3b8e975e389f1b0c4fea90329b0f85 | 0c3b24bc7547c06d4e3580568f7af831a6d9ff2f | [
"@nmittler - FYI\n",
"@nmittler - I'm going to take a first pass at this...there are no framing changes.\n",
"See PR https://github.com/netty/netty/pull/3167\n",
"Cherry-picked updates.\n"
] | [] | 2014-11-24T23:39:28Z | [
"feature"
] | HTTP/2 draft 15 | Draft 15 is out http://tools.ietf.org/html/draft-ietf-httpbis-http2-15. The impacts need to be investigated and the http/2 codec needs to be updated.
| [
"codec-http2/src/main/java/io/netty/handler/codec/http2/Http2SecurityUtil.java"
] | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/Http2SecurityUtil.java"
] | [] | diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2SecurityUtil.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2SecurityUtil.java
index d5e68626aa9..792ebddf38c 100644
--- a/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2SecurityUtil.java
+++ b/codec-http2/src/main/... | null | val | train | 2014-11-24T02:45:47 | 2014-10-30T15:27:51Z | Scottmitch | val |
netty/netty/3129_3224 | netty/netty | netty/netty/3129 | netty/netty/3224 | [
"timestamp(timedelta=14.0, similarity=0.8448786730231798)"
] | 3c2b5c96fd68e4907a2c0f9cdd6dd539fc7972bd | 9ca26256f6a6ee4f053b40f59ce10c3f9f2e086b | [
"please review #3224\n",
"Fixed by #3224\n"
] | [
"`file = null;` in the `finally` block is evaluated even when `file` is `null`. I would move the null-check out of the try block and return early when `file` is `null`.\n"
] | 2014-12-09T20:41:00Z | [
"defect",
"improvement"
] | Support FileRegion without pre-initialized FileDescriptor | DefaultFileRegion requires a FileDescriptor in its constructor, which means we need to have an opened file handle. In super large workloads where we queue up a lot of file regions, this could lead to too many open files due to the way these file descriptors are cleaned.
In Spark we created a LazyFileRegion implementat... | [
"transport-native-epoll/src/main/c/io_netty_channel_epoll_Native.c",
"transport-native-epoll/src/main/c/io_netty_channel_epoll_Native.h",
"transport-native-epoll/src/main/java/io/netty/channel/epoll/Native.java",
"transport/src/main/java/io/netty/channel/DefaultFileRegion.java"
] | [
"transport-native-epoll/src/main/c/io_netty_channel_epoll_Native.c",
"transport-native-epoll/src/main/c/io_netty_channel_epoll_Native.h",
"transport-native-epoll/src/main/java/io/netty/channel/epoll/Native.java",
"transport/src/main/java/io/netty/channel/DefaultFileRegion.java"
] | [] | diff --git a/transport-native-epoll/src/main/c/io_netty_channel_epoll_Native.c b/transport-native-epoll/src/main/c/io_netty_channel_epoll_Native.c
index 2a06c2267cb..24092d03c9e 100644
--- a/transport-native-epoll/src/main/c/io_netty_channel_epoll_Native.c
+++ b/transport-native-epoll/src/main/c/io_netty_channel_epoll_... | null | test | train | 2014-12-09T19:29:37 | 2014-11-11T23:39:33Z | rxin | val |
netty/netty/3188_3238 | netty/netty | netty/netty/3188 | netty/netty/3238 | [
"timestamp(timedelta=61056.0, similarity=0.9268064321116396)"
] | 9a0be053c46c679e5536f19c44c5e5dd4525ec59 | 60cecbd4513b0358a8ab84c2a303e73603073720 | [
"I have looked at the diffs....here are some notes from my first pass.\n\nWe need some changes to be able to send/receive priority frames in any state. I have a question on the spec to clarify the state a bit https://github.com/http2/http2-spec/issues/667. I am looking into adding another `EndPoint.createStream(... | [] | 2014-12-12T13:43:13Z | [
"feature"
] | HTTP/2 Draft 16 | The new draft is out https://tools.ietf.org/html/draft-ietf-httpbis-http2-16.
| [
"codec-http2/src/main/java/io/netty/handler/codec/http2/Http2CodecUtil.java"
] | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/Http2CodecUtil.java"
] | [] | diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2CodecUtil.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2CodecUtil.java
index 3b0be13d598..b38aee2d6dd 100644
--- a/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2CodecUtil.java
+++ b/codec-http2/src/main/java/io/n... | null | test | train | 2014-12-12T10:01:36 | 2014-11-30T15:42:10Z | Scottmitch | val |
netty/netty/3235_3238 | netty/netty | netty/netty/3235 | netty/netty/3238 | [
"timestamp(timedelta=61083.0, similarity=0.855996269826361)"
] | 9a0be053c46c679e5536f19c44c5e5dd4525ec59 | 60cecbd4513b0358a8ab84c2a303e73603073720 | [
"Addressed as part of https://github.com/netty/netty/pull/3217\n"
] | [] | 2014-12-12T13:43:13Z | [
"feature"
] | HTTP/2 HPACK 10 | [HPACK 10](https://tools.ietf.org/html/draft-ietf-httpbis-header-compression-10) has been released. We should update our [twitter hpack](https://github.com/twitter/hpack) dependencies.
| [
"codec-http2/src/main/java/io/netty/handler/codec/http2/Http2CodecUtil.java"
] | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/Http2CodecUtil.java"
] | [] | diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2CodecUtil.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2CodecUtil.java
index 3b0be13d598..b38aee2d6dd 100644
--- a/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2CodecUtil.java
+++ b/codec-http2/src/main/java/io/n... | null | train | train | 2014-12-12T10:01:36 | 2014-12-11T21:56:03Z | Scottmitch | val |
netty/netty/3249_3253 | netty/netty | netty/netty/3249 | netty/netty/3253 | [
"timestamp(timedelta=17.0, similarity=0.9700502923967033)"
] | ff9a6e049905d9e4458dad314d19999d8fd9c641 | a261cc3794e4cd4d9a02f5de8b82bc2dffff9af6 | [
"@MichaelScofield sounds right... could you come up with PR ?\n",
"I've created a PR to branch 3.9: \n\nhttps://github.com/netty/netty/pull/3253\n",
"Fixed by #3253\n"
] | [] | 2014-12-16T07:44:38Z | [
"defect"
] | AbstractNioBossPool may initialize more than once? | The following code snippets are in 3.9.4.final.
In org.jboss.netty.channel.socket.nio.AbstractNioBossPool, method
```
protected void init() {
if (initialized) {
throw new IllegalStateException("initialized already");
}
initialized = true;
...
}
```
where the definition of variable "initializ... | [
"src/main/java/org/jboss/netty/channel/socket/nio/AbstractNioBossPool.java",
"src/main/java/org/jboss/netty/channel/socket/nio/AbstractNioWorkerPool.java"
] | [
"src/main/java/org/jboss/netty/channel/socket/nio/AbstractNioBossPool.java",
"src/main/java/org/jboss/netty/channel/socket/nio/AbstractNioWorkerPool.java"
] | [] | diff --git a/src/main/java/org/jboss/netty/channel/socket/nio/AbstractNioBossPool.java b/src/main/java/org/jboss/netty/channel/socket/nio/AbstractNioBossPool.java
index 90bdc2c591e..08179061be2 100644
--- a/src/main/java/org/jboss/netty/channel/socket/nio/AbstractNioBossPool.java
+++ b/src/main/java/org/jboss/netty/cha... | null | train | train | 2014-12-08T08:06:37 | 2014-12-15T10:07:03Z | MichaelScofield | val |
netty/netty/3194_3254 | netty/netty | netty/netty/3194 | netty/netty/3254 | [
"timestamp(timedelta=372.0, similarity=0.8748363603579907)"
] | 770126f7073603ef3ae96d9923029b5a4a91ebc9 | 001097507cd103a24dcfafcda8dd31dfb574ff5b | [
"@Scottmitch thanks for the heads-up buddy.\n",
"@normanmaurer - Sure I can take this, but I have some outstanding questions for the alpn-boot folks. They are not planning on back porting the alpn-boot bug fix because there was some updates in OpenJDK SSL related code (not related to this bug). Seems a bit lim... | [] | 2014-12-16T14:25:43Z | [
"feature"
] | Jetty alpn-boot new version | Due to https://github.com/jetty-project/jetty-alpn/issues/5 there will be a new alpn-boot release. The pom files should be updated to reflect this.
| [
"pom.xml"
] | [
"pom.xml"
] | [] | diff --git a/pom.xml b/pom.xml
index 0f64bb1e754..594f7699d61 100644
--- a/pom.xml
+++ b/pom.xml
@@ -108,9 +108,54 @@
<properties>
<!-- Our Javadoc has poor enough quality to fail the build thanks to JDK8 javadoc which got more strict. -->
<maven.javadoc.failOnError>false</maven.javadoc.failOnE... | null | train | train | 2014-12-16T12:34:01 | 2014-12-02T12:07:25Z | Scottmitch | val |
netty/netty/3112_3262 | netty/netty | netty/netty/3112 | netty/netty/3262 | [
"timestamp(timedelta=10.0, similarity=0.8847084238518407)"
] | ded37d889338875c1c025deebb1a8a9d44a798f7 | 706aaf08ed09a275594a7ec8ffe4b33a6fd2de3e | [
"See http://linux.die.net/man/7/tcp\n",
"Sounds awesome.\n",
"@normanmaurer would you log them or so?\n",
"@trustin working on it...\n\n@daschl nope just expose it on the EpollSocketChannel. You can do whatever you want to do with it\n"
] | [
"Because all the fields of TCP_INFO are unsigned, we should use wider types - int for u8, int for u16, long for u32.\n",
"good idea.\n",
"@trustin do we want to use byte for all u8 methods ? or better stick with int ?\n",
"Should be short or int.\n",
"Consistency: `JNIEnv* env`\n"
] | 2014-12-19T08:50:30Z | [
"feature"
] | Add support for TCP_INFO in native transport | It would be nice to support TCP_INFO in the native transport to get infos about the socket.
| [
"transport-native-epoll/src/main/c/io_netty_channel_epoll_Native.c",
"transport-native-epoll/src/main/c/io_netty_channel_epoll_Native.h",
"transport-native-epoll/src/main/java/io/netty/channel/epoll/EpollSocketChannel.java",
"transport-native-epoll/src/main/java/io/netty/channel/epoll/Native.java"
] | [
"transport-native-epoll/src/main/c/io_netty_channel_epoll_Native.c",
"transport-native-epoll/src/main/c/io_netty_channel_epoll_Native.h",
"transport-native-epoll/src/main/java/io/netty/channel/epoll/EpollSocketChannel.java",
"transport-native-epoll/src/main/java/io/netty/channel/epoll/EpollTcpInfo.java",
"t... | [
"transport-native-epoll/src/test/java/io/netty/channel/epoll/EpollSocketChannelTest.java"
] | diff --git a/transport-native-epoll/src/main/c/io_netty_channel_epoll_Native.c b/transport-native-epoll/src/main/c/io_netty_channel_epoll_Native.c
index 137187977de..3aa984559e6 100644
--- a/transport-native-epoll/src/main/c/io_netty_channel_epoll_Native.c
+++ b/transport-native-epoll/src/main/c/io_netty_channel_epoll_... | diff --git a/transport-native-epoll/src/test/java/io/netty/channel/epoll/EpollSocketChannelTest.java b/transport-native-epoll/src/test/java/io/netty/channel/epoll/EpollSocketChannelTest.java
new file mode 100644
index 00000000000..9637006217e
--- /dev/null
+++ b/transport-native-epoll/src/test/java/io/netty/channel/epo... | val | train | 2015-01-26T21:16:18 | 2014-11-06T19:58:41Z | normanmaurer | val |
netty/netty/3326_3330 | netty/netty | netty/netty/3326 | netty/netty/3330 | [
"timestamp(timedelta=75.0, similarity=0.8422273553057141)"
] | fb0c78885f1c9a1299357ced5e6d73941588c826 | 3935bc9c9055c5af526a5f2cc7d5044a9025581f | [
"@dittos I confirm.\nThe issue is in splitMultipartHeader where, once Content-Disposition is found, we split the data according to ';'. In this case, this is wrong.\nNothing prevents a filename to include a \";\" (even if ';' is really not compatible with most of OS like Linux).\nI do not have time right now to mak... | [] | 2015-01-15T08:39:12Z | [
"defect"
] | HTTP multipart request with filename containing ";" causes exception | Netty version: 3.10.0.Final
When I send HTTP request something like:
```
POST / HTTP/1.1
Content-Type: multipart/form-data; boundary=dLV9Wyq26L_-JQxk6ferf-RT153LhOO
--dLV9Wyq26L_-JQxk6ferf-RT153LhOO
Content-Disposition: form-data; name="file"; filename="tmp;0.txt"
Content-Type: image/gif
asdf
--dLV9Wyq26L_-JQxk6ferf... | [
"codec-http/src/main/java/io/netty/handler/codec/http/multipart/HttpPostMultipartRequestDecoder.java"
] | [
"codec-http/src/main/java/io/netty/handler/codec/http/multipart/HttpPostMultipartRequestDecoder.java"
] | [
"codec-http/src/test/java/io/netty/handler/codec/http/multipart/HttpPostRequestDecoderTest.java"
] | diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/multipart/HttpPostMultipartRequestDecoder.java b/codec-http/src/main/java/io/netty/handler/codec/http/multipart/HttpPostMultipartRequestDecoder.java
index 012cdb339cf..e242937ad0c 100644
--- a/codec-http/src/main/java/io/netty/handler/codec/http/multipar... | diff --git a/codec-http/src/test/java/io/netty/handler/codec/http/multipart/HttpPostRequestDecoderTest.java b/codec-http/src/test/java/io/netty/handler/codec/http/multipart/HttpPostRequestDecoderTest.java
index a6514df2932..9aa46337b11 100644
--- a/codec-http/src/test/java/io/netty/handler/codec/http/multipart/HttpPost... | train | train | 2015-01-13T10:14:47 | 2015-01-13T09:28:39Z | dittos | val |
netty/netty/3369_3371 | netty/netty | netty/netty/3369 | netty/netty/3371 | [
"timestamp(timedelta=44275.0, similarity=0.9544150316866737)"
] | 201d9ed9badaa70c941943268d974e61c4e84e9d | c0fdfc57689f1344eef7d503adb62f9d4dc5f8cd | [
"@sammychen105 sounds legit... would you mind open a PR with a fix ?\n",
"@normanmaurer ok, a PR(#3371) has been submit.\n",
"Fixed by #3371\n"
] | [] | 2015-01-29T08:30:50Z | [
"defect"
] | invalid refernece decrement in AbstractNioByteChannel | my test server is stop working today, and when i search the logs, i found the following exception:
`<[WARN ]2015-01-29 13:49:50,654,[NioEventLoop], Unexpected exception in the selector loop.
io.netty.util.IllegalReferenceCountException: refCnt: 0, decrement: 1
at io.netty.buffer.AbstractReferenceCountedByteBuf... | [
"transport/src/main/java/io/netty/channel/nio/AbstractNioByteChannel.java"
] | [
"transport/src/main/java/io/netty/channel/nio/AbstractNioByteChannel.java"
] | [] | diff --git a/transport/src/main/java/io/netty/channel/nio/AbstractNioByteChannel.java b/transport/src/main/java/io/netty/channel/nio/AbstractNioByteChannel.java
index ccf8f54a821..b4e5b190498 100644
--- a/transport/src/main/java/io/netty/channel/nio/AbstractNioByteChannel.java
+++ b/transport/src/main/java/io/netty/cha... | null | train | train | 2015-01-27T07:07:18 | 2015-01-29T06:19:40Z | sammychen105 | val |
netty/netty/3362_3379 | netty/netty | netty/netty/3362 | netty/netty/3379 | [
"timestamp(timedelta=67.0, similarity=0.9396625537231835)"
] | 6b8ec6b781b3413c3aa98c3e79a562598be83d2d | 5de6e1c517bb8d4f96949e9ff55f07b492f59d46 | [
"That does sound a bit fishy...I can't give history for why this was done but I'm guessing the intention was to send something to the other end (as opposed to relying on timeouts or other failure detection mechanisms)? No matter what the intention was I agree based upon your description it seems like we are not me... | [] | 2015-01-30T07:11:34Z | [] | Possible wrong behavior in `HttpResponseDecoder`/`HttpRequestDecoder` for large header/initline/content | ##### Netty Version
4.0, 4.1, 5.0
##### Description
[`HttpResponseDecoder`](https://github.com/netty/netty/blob/master/codec-http/src/main/java/io/netty/handler/codec/http/HttpResponseDecoder.java#L118) and [`HttpRequestDecoder`](https://github.com/netty/netty/blob/master/codec-http/src/main/java/io/netty/handler/cod... | [
"codec-http/src/main/java/io/netty/handler/codec/http/HttpRequestDecoder.java",
"codec-http/src/main/java/io/netty/handler/codec/http/HttpResponseDecoder.java",
"codec-http/src/main/java/io/netty/handler/codec/rtsp/RtspRequestDecoder.java",
"codec-http/src/main/java/io/netty/handler/codec/rtsp/RtspResponseDec... | [
"codec-http/src/main/java/io/netty/handler/codec/http/HttpRequestDecoder.java",
"codec-http/src/main/java/io/netty/handler/codec/http/HttpResponseDecoder.java",
"codec-http/src/main/java/io/netty/handler/codec/rtsp/RtspRequestDecoder.java",
"codec-http/src/main/java/io/netty/handler/codec/rtsp/RtspResponseDec... | [] | diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/HttpRequestDecoder.java b/codec-http/src/main/java/io/netty/handler/codec/http/HttpRequestDecoder.java
index bae740864f5..0fb0339e8ff 100644
--- a/codec-http/src/main/java/io/netty/handler/codec/http/HttpRequestDecoder.java
+++ b/codec-http/src/main/java... | null | train | train | 2015-01-30T06:51:34 | 2015-01-27T02:37:03Z | NiteshKant | val |
netty/netty/3382_3386 | netty/netty | netty/netty/3382 | netty/netty/3386 | [
"timestamp(timedelta=103.0, similarity=0.9495401364451412)"
] | cabecee127264e53acaa093ca45d3900b138b881 | f630793ec27d13591adfb0185c687311a6280af5 | [
"@nmittler - FYI.\n",
"Great initiative.\n",
"@Scottmitch good idea! I'll start looking at this today.\n",
"@nmittler - Thanks for taking care of this!\n",
"@Scottmitch After playing with this a bit locally, I believe we can get rid of all of these with the exception of `isResetSent`. We need to know if w... | [
"nit: Auto format?\n",
"I wanted to leave a comment on [line 233](https://github.com/netty/netty/pull/3386/files#diff-179f52a9de82166ed577701a1412b5a0R233)...but too far from modifications. If the stream state is HALF_CLOSED_REMOTE does it matter if we sent reset or not? The remote side shouldn't be sending dat... | 2015-02-02T18:25:33Z | [
"improvement"
] | Http2Stream state consolidation | Http2Stream has a few methods which represent state. There is the [state()](https://github.com/netty/netty/blob/master/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2Stream.java#L46) method which should be checked according to the rules defined in the HTTP/2 spec. There are also some other methods which ... | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2Connection.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionDecoder.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionEncoder.java",
"codec-http2/src/main/java/io/netty/ha... | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2Connection.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionDecoder.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionEncoder.java",
"codec-http2/src/main/java/io/netty/ha... | [
"codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionDecoderTest.java",
"codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionEncoderTest.java",
"codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2LocalFlowControllerTest.java"
] | diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2Connection.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2Connection.java
index 3f72d5743e9..bc3f6d8129a 100644
--- a/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2Connection.java
+++ b/codec-... | diff --git a/codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionDecoderTest.java b/codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionDecoderTest.java
index 1eb3926cb4e..0737811c378 100644
--- a/codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2Connec... | train | train | 2015-02-04T20:24:09 | 2015-01-30T19:45:50Z | Scottmitch | val |
netty/netty/3331_3399 | netty/netty | netty/netty/3331 | netty/netty/3399 | [
"timestamp(timedelta=26.0, similarity=0.9581606155234135)"
] | ca8b937c14c42ee0a2be2cffaf48d3e49caad316 | 02af1735d0aa559e432b02548350a0383f1d481a | [
"@ngocdaothanh we love PR's ;)\n"
] | [] | 2015-02-06T19:54:36Z | [] | Update Javassist from 3.18.0-GA to 3.19.0-GA | Javassist 3.19.0-GA released:
https://github.com/jboss-javassist/javassist/releases
| [
"pom.xml"
] | [
"pom.xml"
] | [] | diff --git a/pom.xml b/pom.xml
index 822c5463819..59122ad6349 100644
--- a/pom.xml
+++ b/pom.xml
@@ -31,7 +31,7 @@
<name>Netty</name>
<url>http://netty.io/</url>
<description>
- Netty is an asynchronous event-driven network application framework for
+ Netty is an asynchronous event-driven network applic... | null | test | train | 2015-02-06T19:31:37 | 2015-01-16T03:59:34Z | ngocdaothanh | val |
netty/netty/3066_3454 | netty/netty | netty/netty/3066 | netty/netty/3454 | [
"timestamp(timedelta=17.0, similarity=0.9305151939322108)"
] | b54857b9a0ec0456e5624b93e244b1d7a2c53ea9 | a07f4e1b09e8556ed9a3e5c55a99a76962ced3a4 | [
"I think it may also not be unregistering closed datagram sockets, but I haven't traced that.\n",
"Sounds like a bug... will investigate\n",
"Fixed... sorry for the delay.\n"
] | [] | 2015-02-27T20:23:17Z | [
"defect"
] | EpollDatagramChannel never calls fireChannelActive() after connect() | NioDatagramChannel extends AbstractNioChannel and AbstractNioUnsafe call fulfillConnectPromise(), which calls fireChannelActive()
AbstractEpollUnsafe and EpollDatagramChannel have no equivalent call, so channelActive() is never called on the pipeline.
| [
"transport-native-epoll/src/main/java/io/netty/channel/epoll/EpollDatagramChannel.java"
] | [
"transport-native-epoll/src/main/java/io/netty/channel/epoll/EpollDatagramChannel.java"
] | [] | diff --git a/transport-native-epoll/src/main/java/io/netty/channel/epoll/EpollDatagramChannel.java b/transport-native-epoll/src/main/java/io/netty/channel/epoll/EpollDatagramChannel.java
index f3809865c08..53465608bf0 100644
--- a/transport-native-epoll/src/main/java/io/netty/channel/epoll/EpollDatagramChannel.java
+++... | null | val | train | 2015-02-27T20:58:03 | 2014-10-28T17:17:10Z | shevek | val |
netty/netty/3488_3489 | netty/netty | netty/netty/3488 | netty/netty/3489 | [
"timestamp(timedelta=66.0, similarity=0.9479850702428534)"
] | 08b1438e7b2b7e129eb0bd2245af6a13dc7798cd | 62be2bca838c6d1e59bfab08b583ca3a70f03842 | [
"+1. Thanks @buchgr for taking this one on!\n"
] | [
"add `final`?\n",
"I removed it because, what's the point of a private final class? Nobody can extend it anyway.\n",
"I think the package private access _maybe_ for 2 reasons:\n1. Used in tests?\n2. Avoid synthetic method generation?\n\nSo I'm not sure we need the package private access but if we could make mor... | 2015-03-11T22:48:37Z | [
"improvement"
] | Remove Frame class from DefaultHttp2RemoteFlowController. | The Frame now just contains the payload and doesn't maintain any other state. To reduce GC pressure, we should probably discard this class and move it's methods to the FlowState.
| [
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2RemoteFlowController.java"
] | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2RemoteFlowController.java"
] | [] | diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2RemoteFlowController.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2RemoteFlowController.java
index 3cd72143f4d..62420691f51 100644
--- a/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2RemoteFl... | null | train | train | 2015-03-13T18:37:58 | 2015-03-11T17:19:24Z | nmittler | val |
netty/netty/3469_3491 | netty/netty | netty/netty/3469 | netty/netty/3491 | [
"timestamp(timedelta=84.0, similarity=0.8501745656004406)"
] | 93bcc6bbdef53e9249802e1bba72aca06f90ad45 | fda0e4e45f621b69d39e4675af099c3e8dcbf69e | [
"+1\n",
"Closing this since we decided to keep the current naming for the time being (in #3491)\n"
] | [] | 2015-03-12T19:54:09Z | [] | Rename HTTP/2 Stream methods indicating writability | The remoteSideOpen() and localSideOpen() are a little confusing. It would be clearer to have isWritable and isReadable.
| [
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2Connection.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionDecoder.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionEncoder.java",
"codec-http2/src/main/java/io/netty/ha... | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2Connection.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionDecoder.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionEncoder.java",
"codec-http2/src/main/java/io/netty/ha... | [
"codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionDecoderTest.java",
"codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionEncoderTest.java",
"codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionTest.java",
"codec-http2/src/test/java... | diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2Connection.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2Connection.java
index bc3f6d8129a..7a306e49edc 100644
--- a/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2Connection.java
+++ b/codec-... | diff --git a/codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionDecoderTest.java b/codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionDecoderTest.java
index 0737811c378..fd0a525b282 100644
--- a/codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2Connec... | test | train | 2015-03-11T03:21:58 | 2015-03-06T19:02:55Z | nmittler | val |
netty/netty/3451_3498 | netty/netty | netty/netty/3451 | netty/netty/3498 | [
"timestamp(timedelta=75.0, similarity=0.91124787193252)"
] | 6e894c411b0df52618791cedc6c0a2aa29e6b5fb | b61a83b07ac54c79544e5512fbc60c2934ee92f0 | [
"@nmittler - Do you have any suggestions to improve clarity? By `direction` do you mean local/remote? The only thing that may be tough is the Endpoint interface is agnostic to direction due to it serving as both remote/local.\n",
"@Scottmitch I haven't put much thought into it yet :). For push, we do clarify di... | [
"I think we have a naming disconnect between the `activate`/`deactivate` on the stream and `concurrent` on the endpoint. For example the stream still has `numActiveStreams()` and `activeStreams()` which is logically the same thing as the endpoint's `numConcurrentStreams()` but with a different name. Can make this ... | 2015-03-15T01:42:10Z | [
"improvement"
] | Clean up HTTP/2 MAX_CONCURRENT_STREAMS logic | There are several methods on `Http2Connection.Endpoint` that involve this parameter:
`acceptingNewStreams`
`createStream`
`reservePushStream`
`maxStreams` (getter and setter)
It is not always clear which direction the value applies to. It's probably worth a pass to:
1) Make sure we're actually using it correctly in... | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2Connection.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionDecoder.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionEncoder.java",
"codec-http2/src/main/java/io/netty/ha... | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2Connection.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionDecoder.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionEncoder.java",
"codec-http2/src/main/java/io/netty/ha... | [
"codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionDecoderTest.java",
"codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionEncoderTest.java",
"codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionTest.java",
"codec-http2/src/test/java... | diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2Connection.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2Connection.java
index bc3f6d8129a..f87e098d27a 100644
--- a/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2Connection.java
+++ b/codec-... | diff --git a/codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionDecoderTest.java b/codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionDecoderTest.java
index 0737811c378..5f1fa909438 100644
--- a/codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2Connec... | train | train | 2015-03-14T17:02:14 | 2015-02-27T18:22:18Z | nmittler | val |
netty/netty/2512_3506 | netty/netty | netty/netty/2512 | netty/netty/3506 | [
"timestamp(timedelta=730.0, similarity=0.8429262120825501)"
] | 4f13dee454079ce99c16c060d56875d25cbfb658 | 79374bcfc1a592b35ad60e7f1759b0c6525aeb71 | [
"I see a similar problem also in the spdy example.\n",
"@trustin for this we will need to make the toInternLogger() method public... wdyt ?\n",
"@trustin @normanmaurer is there any action that I can take on this currently? And if so, will it be backward compatible with 4.1?\n",
"@nmittler The thing is `Intern... | [
"Could we maybe add a javadoc comment telling this is for internal usage only ?\n",
"Done.\n"
] | 2015-03-17T14:53:32Z | [
"defect"
] | Hide InternalLogger from Http2FrameLogger | InternalLogger is intended for internal use only. We should hide it from users.
- Instead of `InternalLogLevel`, we can use io.netty.handler.logging.LogLevel`.
- Instead of accepting `InternalLogger`, we can accept `String` and `Class<?>` to create an `InternalLogger` in the constructor of `Http2FrameLogger`.
| [
"codec-http2/src/main/java/io/netty/handler/codec/http2/Http2FrameLogger.java",
"example/src/main/java/io/netty/example/http2/client/Http2ClientInitializer.java",
"example/src/main/java/io/netty/example/http2/server/HelloWorldHttp2Handler.java",
"handler/src/main/java/io/netty/handler/logging/LogLevel.java"
] | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/Http2FrameLogger.java",
"example/src/main/java/io/netty/example/http2/client/Http2ClientInitializer.java",
"example/src/main/java/io/netty/example/http2/server/HelloWorldHttp2Handler.java",
"handler/src/main/java/io/netty/handler/logging/LogLevel.java"
] | [] | diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2FrameLogger.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2FrameLogger.java
index 4a9d0834534..81b6024cb18 100644
--- a/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2FrameLogger.java
+++ b/codec-http2/src/main/jav... | null | train | train | 2015-03-17T07:30:17 | 2014-05-23T03:33:11Z | trustin | val |
netty/netty/3418_3524 | netty/netty | netty/netty/3418 | netty/netty/3524 | [
"timestamp(timedelta=126.0, similarity=0.9553155096245479)"
] | 2ebf07e62234d02804a6707957288f4292294f16 | 2bb4db2de769bd072f622b50a519f0298ad474af | [
"@nmittler @jpinner FYI.\n",
"HPACK-11 didn't last very long :) We now have draft 12.\n\nNote that the issue description and links have been updated.\n",
"@Scottmitch ha! ... thanks for keeping on top of this!\n",
"Will release hpack-1.0.0 once the spec gets published as an RFC. There will likely be minor AP... | [] | 2015-03-22T17:28:44Z | [
"feature"
] | HTTP/2 Draft 17 | New drafts are out. We should evaluate and make necessary updates.
https://tools.ietf.org/html/draft-ietf-httpbis-http2-17
~~https://tools.ietf.org/html/draft-ietf-httpbis-header-compression-11~~
https://tools.ietf.org/html/draft-ietf-httpbis-header-compression-12
We should coordinate with https://github.com/twitter... | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionDecoder.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2HeadersDecoder.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/Http2CodecUtil.java",
"codec-http2/src/main/java/io/netty/handler/codec... | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionDecoder.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2HeadersDecoder.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/Http2CodecUtil.java",
"codec-http2/src/main/java/io/netty/handler/codec... | [] | diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionDecoder.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionDecoder.java
index d96dd9e24f5..feff3c14bae 100644
--- a/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionDeco... | null | train | train | 2015-03-21T16:10:24 | 2015-02-11T16:57:59Z | Scottmitch | val |
netty/netty/3518_3543 | netty/netty | netty/netty/3518 | netty/netty/3543 | [
"timestamp(timedelta=45.0, similarity=0.9056461210732123)"
] | 9737cc6cc9436fcc032daef53e194da46b039ba5 | 59bb5c18842ef99e9a95f80b9aadf6fd4edd54f1 | [
"@nmittler - FYI.\n",
"We associate priority with the flow control window. Therefore we rely on both peers sharing a common view of the priority tree. However there seems to be some confusion (on my part or in the spec) with how to provide feedback when we don't accept a priority frame. We can't rely upon send... | [
"missing `.` on EOL\n",
"missing `.` on EOL\n",
"Done.\n",
"Done.\n",
"Boy, \"writable\" sure would be a good name .... (Nate giggles while sipping his tea) :)\n",
"maybe call this `isViableBranch()` which first checks `isViable()`?\n",
"Do we need 2 methods? Could `isViable` be recursive?\n",
"Hmm ..... | 2015-03-27T18:41:15Z | [
"defect"
] | HTTP/2 Priority Tree Management | We are currently removing streams from the priority tree as they are closed (maybe subject to a stream removal policy which is being removed as part of https://github.com/netty/netty/issues/3448). However we should not remove streams from the priority tree at least until they have no dependencies which are in states e... | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2Connection.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/Http2Stream.java"
] | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2Connection.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/Http2Stream.java"
] | [
"codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionTest.java",
"codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2RemoteFlowControllerTest.java"
] | diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2Connection.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2Connection.java
index cd507c953da..a10bc3f0cd1 100644
--- a/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2Connection.java
+++ b/codec-... | diff --git a/codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionTest.java b/codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionTest.java
index 6fe7c5a28f9..197be34baef 100644
--- a/codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionTest.java
... | train | train | 2015-03-31T18:18:26 | 2015-03-20T06:34:00Z | Scottmitch | val |
netty/netty/3530_3545 | netty/netty | netty/netty/3530 | netty/netty/3545 | [
"timestamp(timedelta=73.0, similarity=0.9107620806503808)"
] | 1e7eabc58c78217708cbb20e62095cf3c7750ac8 | f81a87a2005575552e8c9d24c15573c2c4023fae | [] | [
"This is the main ugly bit. A chicken and the egg problem ... handler needs the encoder/decoder and they need the handler. If you have a better solution, I'm all ears.\n",
"@nmittler could we just get rid of the builder altogether? It's only 5 arguments and we are not doing anything special in the builder. Why ... | 2015-03-27T22:38:45Z | [
"improvement"
] | Clean up use of builders in Http2ConnectionHandler | Currently Http2ConnectionHandler takes builders for the encoder and decoder, which makes it difficult to decorate them. We should look at getting rid of this.
| [
"codec-http2/src/main/java/io/netty/handler/codec/http2/CompressorHttp2ConnectionEncoder.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionDecoder.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionEncoder.java",
"codec-http2/src/main/java/i... | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/CompressorHttp2ConnectionEncoder.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/DecoratingHttp2ConnectionDecoder.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/DecoratingHttp2ConnectionEncoder.java",
"codec-http2/src/main/... | [
"codec-http2/src/test/java/io/netty/handler/codec/http2/DataCompressionHttp2Test.java",
"codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionDecoderTest.java",
"codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionEncoderTest.java",
"codec-http2/src/test/java/i... | diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/CompressorHttp2ConnectionEncoder.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/CompressorHttp2ConnectionEncoder.java
index 5adc5e0af51..04f01b93415 100644
--- a/codec-http2/src/main/java/io/netty/handler/codec/http2/CompressorHttp2Conne... | diff --git a/codec-http2/src/test/java/io/netty/handler/codec/http2/DataCompressionHttp2Test.java b/codec-http2/src/test/java/io/netty/handler/codec/http2/DataCompressionHttp2Test.java
index 66effe1cc3a..633ad61d1e5 100644
--- a/codec-http2/src/test/java/io/netty/handler/codec/http2/DataCompressionHttp2Test.java
+++ b/... | val | train | 2015-03-30T18:54:33 | 2015-03-24T18:31:40Z | nmittler | val |
netty/netty/3560_3563 | netty/netty | netty/netty/3560 | netty/netty/3563 | [
"timestamp(timedelta=57.0, similarity=0.9322689013154061)"
] | 2b3e0e675a62c8dfaaf735d4b57df17a45a46422 | ddece6dd2de094d33da3c1cd6daec016287402da | [] | [
"@nmittler why you changed this to public ? Was this by mistake ?\n",
"@nmittler - Correct me if I'm wrong but I'll take a shot...\n\n@normanmaurer - I think because before this change we only allowed access to the \"standard\" set of settings (only 6 of them) via the other public methods in this class (i.e. `max... | 2015-04-01T14:55:50Z | [
"defect"
] | HTTP/2 disallows non-standard settings | Currently the `Http2Settings` class disallows setting non-standard settings, which goes against the spec.
| [
"codec-http2/src/main/java/io/netty/handler/codec/http2/Http2CodecUtil.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/Http2Settings.java",
"common/src/main/java/io/netty/util/collection/IntObjectHashMap.java"
] | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/Http2CodecUtil.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/Http2Settings.java",
"common/src/main/java/io/netty/util/collection/IntObjectHashMap.java"
] | [
"codec-http2/src/test/java/io/netty/handler/codec/http2/Http2SettingsTest.java"
] | diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2CodecUtil.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2CodecUtil.java
index 308ac81ea6c..88bdd859ba8 100644
--- a/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2CodecUtil.java
+++ b/codec-http2/src/main/java/io/n... | diff --git a/codec-http2/src/test/java/io/netty/handler/codec/http2/Http2SettingsTest.java b/codec-http2/src/test/java/io/netty/handler/codec/http2/Http2SettingsTest.java
index 38e8d2ce7fd..06c25d7fa84 100644
--- a/codec-http2/src/test/java/io/netty/handler/codec/http2/Http2SettingsTest.java
+++ b/codec-http2/src/test/... | train | train | 2015-04-01T01:25:00 | 2015-04-01T14:18:14Z | nmittler | val |
netty/netty/3573_3581 | netty/netty | netty/netty/3573 | netty/netty/3581 | [
"timestamp(timedelta=25.0, similarity=0.943774633710981)"
] | e40c27d9ed1678207c1ca4554e70ed5e2534d93f | cdd35c2efd112e130312535fcbf69eb341fc14d3 | [
"PR pending for this....\n"
] | [] | 2015-04-03T21:39:26Z | [
"defect"
] | HTTP/2 RST_STREAM frame for an IDLE stream should result in connection error | http://http2.github.io/http2-spec/index.html#RST_STREAM
> RST_STREAM frames MUST NOT be sent for a stream in the "idle" state. If a RST_STREAM frame identifying an idle stream is received, the recipient MUST treat this as a connection error (Section 5.4.1) of type PROTOCOL_ERROR.
| [
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionDecoder.java"
] | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionDecoder.java"
] | [
"codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionDecoderTest.java"
] | diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionDecoder.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionDecoder.java
index f839e6d0390..714710a5722 100644
--- a/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionDeco... | diff --git a/codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionDecoderTest.java b/codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionDecoderTest.java
index 82319597145..c119dc94cd6 100644
--- a/codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2Connec... | test | train | 2015-04-03T20:57:31 | 2015-04-03T16:11:15Z | Scottmitch | val |
netty/netty/3572_3583 | netty/netty | netty/netty/3572 | netty/netty/3583 | [
"timestamp(timedelta=20.0, similarity=0.9411251524949779)"
] | e40c27d9ed1678207c1ca4554e70ed5e2534d93f | af2352c9ac4b9ce52811dd47bcc435879d73e55e | [
"The behavior should be the same as the PRIORITY frame. We should create the stream. So we need to move the set priority above the notification.\n"
] | [] | 2015-04-03T21:44:04Z | [
"defect"
] | HTTP/2 HEADERS stream dependency stream state | The specification does not provide explicit direction as how to what state the `Stream Dependency` stream is expected to be in, and how implementations should react if it is not in the OPEN (or other "created" states). The decoder may have to be updated by:
1. Move the `setPriority` above notification of the listener.... | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionDecoder.java"
] | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionDecoder.java"
] | [
"codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionDecoderTest.java"
] | diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionDecoder.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionDecoder.java
index f839e6d0390..06eeced4aa1 100644
--- a/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionDeco... | diff --git a/codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionDecoderTest.java b/codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionDecoderTest.java
index 82319597145..0591363d8d5 100644
--- a/codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2Connec... | train | train | 2015-04-03T20:57:31 | 2015-04-03T16:06:40Z | Scottmitch | val |
netty/netty/3448_3606 | netty/netty | netty/netty/3448 | netty/netty/3606 | [
"timestamp(timedelta=154.0, similarity=0.953447460037735)"
] | d556269810264870bbcb6c1aaa9a94a9d78c494c | dc36a08da874a184d82378bc4876b63f1d5bf9ff | [
"@Scottmitch WDYT?\n",
"We ignore these frames for non-existent streams if they are for stream Ids below the lastGoodStreamId\n",
"That seems like a reasonable default policy. \n\nI guess the question here is whether we need to continue to allow for a pluggable policy or just bake this behavior in. \n",
"@jpi... | [
"Kind of strange to say \"Default implementation\" as this is not an implementation of an interface.\n",
"@nmittler I think this comment is not right. Streams should be removed even if they have children, but the children should be reprioritised and get a new parent?\n",
"@buchgr I believe the comment accuratel... | 2015-04-10T16:36:22Z | [
"improvement"
] | Get rid of Http2StreamRemovalPolicy | The `DefaultHttp2StreamRemovalPolicy` by default waits 5 seconds after a stream has been closed before removing it from the connection. The reason for this is to support the following case from the HTTP2 spec (From [Section 5.1](https://tools.ietf.org/html/draft-ietf-httpbis-http2-17#section-5.1)):
```
"WINDOW_UPDATE... | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2Connection.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2StreamRemovalPolicy.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/Http2CodecUtil.java",
"codec-http2/src/main/java/io/netty/handler/codec/h... | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2Connection.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/Http2CodecUtil.java"
] | [] | diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2Connection.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2Connection.java
index a83436b6493..7c2fe828643 100644
--- a/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2Connection.java
+++ b/codec-... | null | train | train | 2015-04-13T20:00:15 | 2015-02-24T21:30:53Z | nmittler | val |
netty/netty/3501_3615 | netty/netty | netty/netty/3501 | netty/netty/3615 | [
"timestamp(timedelta=18.0, similarity=0.8650718977788289)"
] | 4d02c3a040d47e240fd9574bb6dd48b15b9b7779 | ef9e98143e3f1c84d3bd6d52c117c86eca99da1b | [
"+1. Thanks for reporting!\n",
"@nmittler - I'll take this one. As part of the resolution to https://github.com/netty/netty/issues/3550 I needed to do additional iteration over methods which use listeners and so I had to do something about this issue. My approach was to catch `RuntimeExceptions` and only throw ... | [
"Just noticed this dependency. @nmittler - Is there no other way? :)\n",
"Nooooo! Let's just use `AtomicReference` :-)\n",
"+1 for `AtomicReference` :)\n",
"Done :)\n",
"Fixed in this PR for simplicity\n"
] | 2015-04-10T23:12:08Z | [
"defect"
] | Investigate exception handling WRT Http2Connection.Listener notifications | We should take a closer look at how we notify the listeners of connection events and consider the proper course of action if a listener callback throws.
| [
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2Connection.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/Http2Connection.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/Http2ConnectionHandler.java"
] | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2Connection.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/Http2Connection.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/Http2ConnectionHandler.java"
] | [
"codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionTest.java"
] | diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2Connection.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2Connection.java
index 6b9b7059832..a83436b6493 100644
--- a/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2Connection.java
+++ b/codec-... | diff --git a/codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionTest.java b/codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionTest.java
index e0447b3e19e..e145b8eb42c 100644
--- a/codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionTest.java
... | test | train | 2015-04-13T09:02:10 | 2015-03-16T16:19:42Z | nmittler | val |
netty/netty/3594_3618 | netty/netty | netty/netty/3594 | netty/netty/3618 | [
"timestamp(timedelta=17.0, similarity=0.9976609011293613)"
] | e36c1436b80399175fad55d09848c9f29da2174e | dc1b86639cfcc1915609a2e12168b5358b964923 | [
"@nmittler @buchgr - FYI...I have a fix for this. Standby.\n",
"https://github.com/netty/netty/issues/3618 fixed this\n"
] | [
"maybe just call this `retain`?\n",
"Doesn't `removeStream` notify the listeners that the stream was removed?\n",
"if `oldParent != null`, isn't it an error condition if removal of the child from `oldParent` is null?\n",
"Isn't it an error condition if the `put` != null? Maybe we should throw if that's the ca... | 2015-04-10T23:21:37Z | [
"defect"
] | HTTP/2 Priority Tree circular link | There is an issue with the HTTP/2 priority tree algorithm where circular links can be created. The issue is if an exclusive dependency event described as `stream B should be an exclusive dependency of stream A` is requested and stream `B` is already a child of stream `A`...then we will add `B` to `B`'s own `children` ... | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2Connection.java"
] | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2Connection.java"
] | [
"codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionTest.java"
] | diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2Connection.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2Connection.java
index 7c2fe828643..6ddf71ee78e 100644
--- a/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2Connection.java
+++ b/codec-... | diff --git a/codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionTest.java b/codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionTest.java
index e145b8eb42c..2569d5d5c1c 100644
--- a/codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionTest.java
... | train | train | 2015-04-15T02:11:09 | 2015-04-07T01:38:14Z | Scottmitch | val |
netty/netty/2925_3624 | netty/netty | netty/netty/2925 | netty/netty/3624 | [
"timestamp(timedelta=18.0, similarity=0.8766544177695756)"
] | 418c81542b9a907af1e2cfabea78f8409525cac4 | 541301203862145d511f30d3d3311f10992e9b31 | [
"@garretwu thanks for reporting... I will check and fix it\n",
"@garretwu I'm right you say it should get the 7th cache bin(start from0) . right ?\n",
"you are right, @normanmaurer. That is what I mean.\n",
"Thanks for clarify!\n\n> Am 12.11.2014 um 03:52 schrieb garretwu notifications@github.com:\n> \n> you ... | [] | 2015-04-13T05:52:51Z | [
"defect"
] | NormalMemoryRegionCache's arraysize is over booked | When create NormalMemoryRegionCache for PoolThreadCache. The array size is decided by:
int max = Math.min(area.chunkSize, maxCachedBufferCapacity);
int arraySize = Math.max(1, max / area.pageSize);
So most likely it is decided by maxCachedBufferCapacity/area.pageSize, with maxCachedBufferCapacity=2M th... | [
"buffer/src/main/java/io/netty/buffer/PoolThreadCache.java"
] | [
"buffer/src/main/java/io/netty/buffer/PoolThreadCache.java"
] | [] | diff --git a/buffer/src/main/java/io/netty/buffer/PoolThreadCache.java b/buffer/src/main/java/io/netty/buffer/PoolThreadCache.java
index 755f1573ed7..fbcfaafffb1 100644
--- a/buffer/src/main/java/io/netty/buffer/PoolThreadCache.java
+++ b/buffer/src/main/java/io/netty/buffer/PoolThreadCache.java
@@ -129,7 +129,7 @@ pri... | null | train | train | 2015-04-12T13:38:20 | 2014-09-22T04:56:22Z | garretwu | val |
netty/netty/3637_3638 | netty/netty | netty/netty/3637 | netty/netty/3638 | [
"timestamp(timedelta=85.0, similarity=0.9592301228970215)"
] | 9e5dd21d23739bc8462c31a71bae3a9456ed67f2 | 30b20de0b985474755113d9a9626196f626c7276 | [
"Fixed by #3638\n"
] | [] | 2015-04-16T11:48:02Z | [
"defect"
] | AggregatedFullHttpMessage toString() behaviour | This is related to #3019, the previous problem persists:
Prior to v4.0.24-FINAL you could call .toString on the output of HttpObjectAggregator regardless of whether the resulting HttpMessage has been released or not, from v.4.0.24-FINAL onwards you will encounter an error similar to:
```
io.netty.util.IllegalReferenc... | [
"codec-http/src/main/java/io/netty/handler/codec/http/HttpObjectAggregator.java"
] | [
"codec-http/src/main/java/io/netty/handler/codec/http/HttpObjectAggregator.java"
] | [] | diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/HttpObjectAggregator.java b/codec-http/src/main/java/io/netty/handler/codec/http/HttpObjectAggregator.java
index 9a504669502..415e2a849d0 100644
--- a/codec-http/src/main/java/io/netty/handler/codec/http/HttpObjectAggregator.java
+++ b/codec-http/src/mai... | null | train | train | 2015-04-14T17:59:33 | 2015-04-16T11:45:13Z | d-t-w | val |
netty/netty/3668_3672 | netty/netty | netty/netty/3668 | netty/netty/3672 | [
"timestamp(timedelta=55.0, similarity=0.8928221867187973)"
] | 43d57ddd46f0cf5db92469219654c155bd982e05 | 9611860d7b66fdeefb9a62baf7ba0a1f512f9a61 | [
"Thanks @nmittler. I see you left this as a comment in https://github.com/netty/netty/pull/3616. Are you pulling together a separate PR for this?\n",
"I'm working on a PR to address this and history ... should have something ready shortly.\n",
"@nmittler - OK. I would like to get a consolidated understanding ... | [
"Do we have to do this? If we are forcing the unconsumed bytes to 0 in the connection listener, is that good enough...or is this method used while the stream is being closed before the listener is notified?\n",
"Was this intentional? I looked through the call path down to the FrameWriter and I don't see a null c... | 2015-04-20T23:04:29Z | [
"defect"
] | Removed HTTP/2 streams should consume all bytes | When a stream is removed from the connection, we should mark all of it's bytes as consumed so that the local flow controller will restore those bytes to the connection window. We'll also need to protect against the application trying to consume those bytes as well (probably just make it a no-op for closed streams).
| [
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2Connection.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2LocalFlowController.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/Http2LocalFlowController.java"
] | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2Connection.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2LocalFlowController.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/Http2LocalFlowController.java"
] | [
"codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2LocalFlowControllerTest.java"
] | diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2Connection.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2Connection.java
index 6ddf71ee78e..d6b333c32ad 100644
--- a/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2Connection.java
+++ b/codec-... | diff --git a/codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2LocalFlowControllerTest.java b/codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2LocalFlowControllerTest.java
index 1e324426d37..94d8b14d4d1 100644
--- a/codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2Lo... | train | train | 2015-04-20T10:45:43 | 2015-04-20T19:33:21Z | nmittler | val |
netty/netty/3671_3674 | netty/netty | netty/netty/3671 | netty/netty/3674 | [
"timestamp(timedelta=31.0, similarity=0.8934061479207374)"
] | f242bc5a1a8b961b54aa127230818cff845009d6 | 8cac1af2f7f123df9424346aae737286d2a78f32 | [
"@leogomes - Can you be more specific? I looks like you are implying the context that is generated by `build()` is reversed. However it looks to be correct https://github.com/netty/netty/blob/4d56028df5a7be31561442f45bc2141eb84aa5ad/handler/src/main/java/io/netty/handler/ssl/SslContextBuilder.java#L206.\n",
"Do... | [] | 2015-04-20T23:40:59Z | [
"defect"
] | SSLContextBuilder builds client context for server and vice-versa | Introduced with: https://github.com/netty/netty/issues/3531
SslContextBuilder constructor has a [boolean parameter `forServer`](https://github.com/netty/netty/blob/4d56028df5a7be31561442f45bc2141eb84aa5ad/handler/src/main/java/io/netty/handler/ssl/SslContextBuilder.java#L75), which is set to `false` in the [`forServer... | [
"handler/src/main/java/io/netty/handler/ssl/SslContextBuilder.java"
] | [
"handler/src/main/java/io/netty/handler/ssl/SslContextBuilder.java"
] | [] | diff --git a/handler/src/main/java/io/netty/handler/ssl/SslContextBuilder.java b/handler/src/main/java/io/netty/handler/ssl/SslContextBuilder.java
index e935e7c8b32..fcc840e6ca8 100644
--- a/handler/src/main/java/io/netty/handler/ssl/SslContextBuilder.java
+++ b/handler/src/main/java/io/netty/handler/ssl/SslContextBuil... | null | train | train | 2015-04-20T10:45:28 | 2015-04-20T22:38:27Z | leogomes | val |
netty/netty/3675_3684 | netty/netty | netty/netty/3675 | netty/netty/3684 | [
"timestamp(timedelta=47.0, similarity=0.9132557124718427)"
] | a8af0debcbf5033c8c0d90ff79c2ec87960816fc | d320c43e622fc837496e10d2a168d3f997622817 | [
"@gsoltis so it only happens when you call size() ?\n",
"So far, yes, that's the only place I've seen it. We have each event loop hooked up to a stats reporting module that reports the size of the task queue every few seconds. We noticed it because the stats stopped being reported, and it turns out the reporting ... | [
"Does the runtime type of `toList(..)` have to be `ArrayList<>`? Can you just change the signature of `toList(..)` to accept a `List<..>` since it is private? That way we don't have to duplicate the `16 is the default size` logic here. \n",
"@Scottmitch sorry but I not understand what you are proposing.. IF I ... | 2015-04-21T19:52:21Z | [
"defect"
] | Livelock issue in MpscLinkedQueue.java | Hi,
We've been running netty 4.0.27 in production for ~1 week, and recently we started noticing cases where calls to `SingleThreadEventExecutor.pendingTasks()` were never completing. We traced the issue down to `MpscLinkedQueue.peekNode()`, which appears to be just spinning.
Reading the contract at the top of the fi... | [
"common/src/main/java/io/netty/util/internal/MpscLinkedQueue.java"
] | [
"common/src/main/java/io/netty/util/internal/MpscLinkedQueue.java"
] | [] | diff --git a/common/src/main/java/io/netty/util/internal/MpscLinkedQueue.java b/common/src/main/java/io/netty/util/internal/MpscLinkedQueue.java
index 4baa5ac0fb2..c1b931a5628 100644
--- a/common/src/main/java/io/netty/util/internal/MpscLinkedQueue.java
+++ b/common/src/main/java/io/netty/util/internal/MpscLinkedQueue.... | null | test | train | 2015-05-04T04:52:05 | 2015-04-21T01:02:18Z | gsoltis | val |
netty/netty/3653_3693 | netty/netty | netty/netty/3653 | netty/netty/3693 | [
"timestamp(timedelta=12.0, similarity=0.9324330647973355)"
] | 891be30a28c6dc5a1edf1cb5a3690644cf4ff66e | bf68dc74f73384a56d21c97ab934cfe43c0d2480 | [
"@ejona86 - Thanks for brining my attention to this!\n\n@nmittler - FYI.\n",
"@nmittler - I think this means we can get away without keeping history for https://github.com/netty/netty/issues/3557. We can just send a connection error in these \"bad\" conditions and it is OK if state is \"invalid\" because we are ... | [
"What is the difference between `ctx.close()` and `ctx.channel().close()`?\n",
"The [AbstractChannelHandlerContext.close(..)](https://github.com/netty/netty/blob/master/transport/src/main/java/io/netty/channel/AbstractChannelHandlerContext.java#L440) does a bit of extra work related to the `invoker` to ensure you... | 2015-04-24T17:37:08Z | [
"defect"
] | HTTP/2 send goaway with error condition must close tcp connection | [section 5.4.1](https://tools.ietf.org/html/draft-ietf-httpbis-http2-17#section-5.4.1):
> After sending the GOAWAY frame for an error condition,
> the endpoint MUST close the TCP connection.
We should update the life cycle manager's `goAway` documentation such that upon successful go away the channel must be close... | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/Http2ConnectionHandler.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/Http2LifecycleManager.java"
] | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/Http2ConnectionHandler.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/Http2LifecycleManager.java"
] | [
"codec-http2/src/test/java/io/netty/handler/codec/http2/Http2ConnectionHandlerTest.java"
] | diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2ConnectionHandler.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2ConnectionHandler.java
index 668e4e798b0..0d996be0120 100644
--- a/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2ConnectionHandler.java
+++ b/codec-... | diff --git a/codec-http2/src/test/java/io/netty/handler/codec/http2/Http2ConnectionHandlerTest.java b/codec-http2/src/test/java/io/netty/handler/codec/http2/Http2ConnectionHandlerTest.java
index 899af813d4d..832ff66f401 100644
--- a/codec-http2/src/test/java/io/netty/handler/codec/http2/Http2ConnectionHandlerTest.java
... | test | train | 2015-04-29T08:43:06 | 2015-04-17T17:51:46Z | Scottmitch | val |
netty/netty/3680_3695 | netty/netty | netty/netty/3680 | netty/netty/3695 | [
"timestamp(timedelta=13.0, similarity=0.8939241132547782)"
] | a958e9b5d5d9d03b5c85a602c061d44ea25d7a52 | e4fa82b2a92aa5d8e74c60670b42cb3feb62218e | [
"@spinscale thanks for reporting. Let me fix this.\n",
"Actually the scope of this needs to be broaden as we need to also ensure property access works in the static initializer. So this will be a bigger change.\n",
"@trustin @Scottmitch FYI\n",
"@normanmaurer - Lets fix this one and any others we can think of... | [] | 2015-04-25T15:58:59Z | [
"defect"
] | Enabled SecurityManager results in ClassNotFoundError during io.netty.util.NetUtil initialization | Hey,
Netty version used: 4.0.27
Setup: An application that has the security manager enabled, spits an not really helpful `ClassNotFoundError` in case that the application is not allowed to read a file due to the security manager. The reason for this is the try to read the file `/proc/sys/net/core/somaxconn` in https:... | [
"common/src/main/java/io/netty/util/NetUtil.java"
] | [
"common/src/main/java/io/netty/util/NetUtil.java"
] | [] | diff --git a/common/src/main/java/io/netty/util/NetUtil.java b/common/src/main/java/io/netty/util/NetUtil.java
index 00958c45b27..436da329a10 100644
--- a/common/src/main/java/io/netty/util/NetUtil.java
+++ b/common/src/main/java/io/netty/util/NetUtil.java
@@ -28,6 +28,8 @@
import java.net.NetworkInterface;
import ja... | null | train | train | 2015-04-22T09:11:11 | 2015-04-21T11:32:33Z | spinscale | val |
netty/netty/3698_3708 | netty/netty | netty/netty/3698 | netty/netty/3708 | [
"timestamp(timedelta=57.0, similarity=0.8817081669286014)"
] | 55fbf007f04fbba7bf50028f3c8b35d6c5ea5947 | 753194b643a8d6643f6b61aca1acd4fb19a59bfa | [
"@benevans Current io.netty.channel.sctp.SctpMessage is hiding some controls and, it could have been done better. Initially it was designed to work with SIGTRAN protocols and I didn't include ordering/completeness flags, which were not used at that time. Please feel free to send your pull request.\n",
"@benevan... | [] | 2015-04-29T13:55:07Z | [
"feature"
] | Cannot use SCTP unordered flag | Some applications, e.g. SIP over SCTP ([RFC4168](https://tools.ietf.org/html/rfc4168#section-5.1)), require the use of SCTP's unordered delivery flag.
Currently in Netty there is no way to set the unordered flag on an outgoing message. I assume the place to do this would be in `io.netty.channel.sctp.SctpMessage`, alon... | [
"transport-sctp/src/main/java/io/netty/channel/sctp/SctpMessage.java",
"transport-sctp/src/main/java/io/netty/channel/sctp/nio/NioSctpChannel.java",
"transport-sctp/src/main/java/io/netty/channel/sctp/oio/OioSctpChannel.java",
"transport-sctp/src/main/java/io/netty/handler/codec/sctp/SctpMessageCompletionHand... | [
"transport-sctp/src/main/java/io/netty/channel/sctp/SctpMessage.java",
"transport-sctp/src/main/java/io/netty/channel/sctp/nio/NioSctpChannel.java",
"transport-sctp/src/main/java/io/netty/channel/sctp/oio/OioSctpChannel.java",
"transport-sctp/src/main/java/io/netty/handler/codec/sctp/SctpMessageCompletionHand... | [
"testsuite/src/main/java/io/netty/testsuite/transport/sctp/SctpEchoTest.java"
] | diff --git a/transport-sctp/src/main/java/io/netty/channel/sctp/SctpMessage.java b/transport-sctp/src/main/java/io/netty/channel/sctp/SctpMessage.java
index 6938f3bb3dd..f10f8eea56c 100644
--- a/transport-sctp/src/main/java/io/netty/channel/sctp/SctpMessage.java
+++ b/transport-sctp/src/main/java/io/netty/channel/sctp/... | diff --git a/testsuite/src/main/java/io/netty/testsuite/transport/sctp/SctpEchoTest.java b/testsuite/src/main/java/io/netty/testsuite/transport/sctp/SctpEchoTest.java
index 0b126b8a136..067d8e6a671 100644
--- a/testsuite/src/main/java/io/netty/testsuite/transport/sctp/SctpEchoTest.java
+++ b/testsuite/src/main/java/io/... | val | train | 2015-04-29T08:42:55 | 2015-04-28T10:10:53Z | benevans | val |
netty/netty/3717_3723 | netty/netty | netty/netty/3717 | netty/netty/3723 | [
"timestamp(timedelta=8946.0, similarity=1.0)"
] | 37dc6a41a6cbf5cfadf430a5773bb61bc6e2173b | 0fb3ab6469078b9891115a275aed8c369c367847 | [
"+1\n",
"SGTM. @louiscryan - are you working on a PR?\n",
"Not yet but feel free to assign to me.\n\nOn Fri, May 1, 2015 at 1:27 PM, Scott Mitchell notifications@github.com\nwrote:\n\n> SGTM. @louiscryan https://github.com/louiscryan - are you working on a\n> PR?\n> \n> —\n> Reply to this email directly or view... | [] | 2015-05-04T20:11:35Z | [
"feature"
] | Http2LocalFlowController.consumeBytes should indicate if write occurred | Calls to Http2LocalFlowController.consumeBytes can trigger the generation of a WINDOW_UPDATE to the remote side. Callers of this method need to know if they should flush because an update was sent
| [
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2LocalFlowController.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/DelegatingDecompressorFrameListener.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/Http2LocalFlowController.java",
"microbench/src/main/java/io... | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2LocalFlowController.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/DelegatingDecompressorFrameListener.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/Http2LocalFlowController.java",
"microbench/src/main/java/io... | [
"codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2LocalFlowControllerTest.java"
] | diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2LocalFlowController.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2LocalFlowController.java
index 6d6369b4927..30233bf0560 100644
--- a/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2LocalFlowC... | diff --git a/codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2LocalFlowControllerTest.java b/codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2LocalFlowControllerTest.java
index 5fc4e0df87b..06051a74a81 100644
--- a/codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2Lo... | train | train | 2015-05-04T07:30:30 | 2015-05-01T19:54:17Z | louiscryan | val |
netty/netty/3707_3732 | netty/netty | netty/netty/3707 | netty/netty/3732 | [
"timestamp(timedelta=32.0, similarity=0.8681261088636044)"
] | 59209f16bfd736f3d1dc8e7da68cb50a5d74c24f | c00586edcd965db677fdcfacb094fb410040726e | [
"@doom369 can you show me the code ?\n",
"@normanmaurer, sure.\n\nServer : \n\n```\n private static SslContext initSslContext(String serverCertPath, String serverKeyPath, String serverPass,\n String clientCertPath,\n SslPro... | [
"Use `@RunWith(Parameterized.class)` instead.\n",
"Use `@RunWith(Parameterized.class)` instead.\n",
"`\"keycertChainFile\"`\n",
"`\"keyCertChainFile is not a file: \"`\n",
"Do we need to support `SSL_AIDX_DSA` either?\n",
"Can you show me an example?\n\n> Am 06.05.2015 um 07:56 schrieb Trustin Lee notific... | 2015-05-05T20:29:03Z | [
"feature"
] | Mutual SSL with OpenSSL | Hi guys,
I tried to use OpenSSL provider for mutual SSL auth and getting error :
```
io.netty.handler.codec.DecoderException: javax.net.ssl.SSLException: error:140890B2:SSL routines:SSL3_GET_CLIENT_CERTIFICATE:no certificate returned
at io.netty.handler.codec.ByteToMessageDecoder.callDecode(ByteToMessageDecoder.... | [
"handler/src/main/java/io/netty/handler/ssl/JdkSslContext.java",
"handler/src/main/java/io/netty/handler/ssl/OpenSslClientContext.java",
"handler/src/main/java/io/netty/handler/ssl/OpenSslContext.java",
"handler/src/main/java/io/netty/handler/ssl/OpenSslEngine.java",
"handler/src/main/java/io/netty/handler/... | [
"handler/src/main/java/io/netty/handler/ssl/JdkSslContext.java",
"handler/src/main/java/io/netty/handler/ssl/OpenSslClientContext.java",
"handler/src/main/java/io/netty/handler/ssl/OpenSslContext.java",
"handler/src/main/java/io/netty/handler/ssl/OpenSslEngine.java",
"handler/src/main/java/io/netty/handler/... | [
"handler/src/test/java/io/netty/handler/ssl/JdkSslEngineTest.java",
"handler/src/test/java/io/netty/handler/ssl/OpenSslEngineTest.java",
"handler/src/test/java/io/netty/handler/ssl/SSLEngineTest.java"
] | diff --git a/handler/src/main/java/io/netty/handler/ssl/JdkSslContext.java b/handler/src/main/java/io/netty/handler/ssl/JdkSslContext.java
index e031bd54411..54ee2befbf6 100644
--- a/handler/src/main/java/io/netty/handler/ssl/JdkSslContext.java
+++ b/handler/src/main/java/io/netty/handler/ssl/JdkSslContext.java
@@ -16,... | diff --git a/handler/src/test/java/io/netty/handler/ssl/JdkSslEngineTest.java b/handler/src/test/java/io/netty/handler/ssl/JdkSslEngineTest.java
index 4df0fc00a8d..9482f2b4450 100644
--- a/handler/src/test/java/io/netty/handler/ssl/JdkSslEngineTest.java
+++ b/handler/src/test/java/io/netty/handler/ssl/JdkSslEngineTest.... | val | train | 2015-05-06T08:44:56 | 2015-04-29T09:59:02Z | doom369 | val |
netty/netty/3738_3741 | netty/netty | netty/netty/3738 | netty/netty/3741 | [
"timestamp(timedelta=2831.0, similarity=0.9376268990082014)"
] | 2ab9d659c77a4500123a30efce76a1fd7d669d26 | bbdb7395633b60a5ec0492400b34a296e84cbbb2 | [
"We love PR's ;)\n\n> Am 06.05.2015 um 03:40 schrieb Thomas notifications@github.com:\n> \n> in line 28,it writes '\\* A simple list which is reyclable.' ,i guess here should be recyclable. :p\n> \n> —\n> Reply to this email directly or view it on GitHub.\n",
"thanks @normanmaurer i just pulled it.:)\n"
] | [] | 2015-05-06T05:54:36Z | [] | [typo]it seems to be a typo 'reyclable' in RecyclableArrayList | in line 28,it writes '\* A simple list which is reyclable.' ,i guess here should be recyclable. :p
| [
"common/src/main/java/io/netty/util/internal/RecyclableArrayList.java"
] | [
"common/src/main/java/io/netty/util/internal/RecyclableArrayList.java"
] | [] | diff --git a/common/src/main/java/io/netty/util/internal/RecyclableArrayList.java b/common/src/main/java/io/netty/util/internal/RecyclableArrayList.java
index 9a4214f9a6a..38847bd2790 100644
--- a/common/src/main/java/io/netty/util/internal/RecyclableArrayList.java
+++ b/common/src/main/java/io/netty/util/internal/Recy... | null | val | train | 2015-05-06T06:53:56 | 2015-05-06T01:40:43Z | ThomasLau | val |
netty/netty/3775_3776 | netty/netty | netty/netty/3775 | netty/netty/3776 | [
"timestamp(timedelta=18.0, similarity=0.8593864041163389)"
] | d0c81604b6a3ed78961cda73ddb5ccb253202846 | a14f78a919680517a4c9c1a28cd0c181bfa2933a | [
"@ejona86 can you check ?\n",
"There should be a `SslContextBuilder.forServer(KeyManagerFactory)` but it is missing. Workaround is to provide any `File` (doesn't need to exist) to `forServer()` and then change the configuration.\n\n```\nSslContextBuilder.forServer(new File(\"foo\"), new File(\"foo\"))\n .keyMa... | [] | 2015-05-11T17:38:28Z | [
"defect"
] | SslContextBuilder has conflicting conditions in keyManager(...) | The `keyManager(File, ...)` and `keyManager(KeyManagerFactory)` methods have conflicting conditions for the server SslContextBuilder.
Or SslContextBuilder is missing an argument-less `forServer()` method.
```
SslContextBuilder.forServer(null, null)
.keyManager(myKeyManagerFactory)
.build();
```
```
java.lang... | [
"handler/src/main/java/io/netty/handler/ssl/SslContext.java",
"handler/src/main/java/io/netty/handler/ssl/SslContextBuilder.java"
] | [
"handler/src/main/java/io/netty/handler/ssl/SslContext.java",
"handler/src/main/java/io/netty/handler/ssl/SslContextBuilder.java"
] | [] | diff --git a/handler/src/main/java/io/netty/handler/ssl/SslContext.java b/handler/src/main/java/io/netty/handler/ssl/SslContext.java
index 890b36242bf..0865890f405 100644
--- a/handler/src/main/java/io/netty/handler/ssl/SslContext.java
+++ b/handler/src/main/java/io/netty/handler/ssl/SslContext.java
@@ -76,7 +76,7 @@
... | null | train | train | 2015-05-11T06:16:40 | 2015-05-11T15:14:51Z | rkapsi | val |
netty/netty/3765_3793 | netty/netty | netty/netty/3765 | netty/netty/3793 | [
"timestamp(timedelta=16.0, similarity=0.8551911949346422)"
] | 833b92a5aaca287f0f9ebdc74d15c6f0a5baef74 | 5966411b1a81db9576f1d3bbc7cd0b3119726e2f | [
"@bobymicroby - Thanks for reaching out!\n\nWhat flags are you starting chrome with? Are you starting the example with the `-Dssl` flag? What version of netty are you using?\n",
"@Scottmitch it's @bobymicroby ;)\n",
"In order for the example to work with chrome you will have to change Netty's http2 ALPN token... | [] | 2015-05-15T18:18:09Z | [
"defect"
] | HTTP/2 examples doesn't work with Chrome 42.0.2311.135 (64-bit) on OSX 10.10.3 , Java 1.8.0_45-b14 , Netty 5.0.0.Alpha3-SNAPSHOT | The request stays as "pending" forever
The debug output:
May 08, 2015 6:45:27 PM io.netty.handler.logging.LoggingHandler channelRead
INFO: [id: 0x4d9163c8, /0:0:0:0:0:0:0:0:8080] RECEIVED: [id: 0x2e91accb, /1... | [
"example/src/main/java/io/netty/example/http2/server/HelloWorldHttp1Handler.java",
"example/src/main/java/io/netty/example/http2/server/HelloWorldHttp2Handler.java",
"example/src/main/java/io/netty/example/http2/server/Http2OrHttpHandler.java",
"example/src/main/java/io/netty/example/http2/server/Http2ServerI... | [
"example/src/main/java/io/netty/example/http2/server/HelloWorldHttp1Handler.java",
"example/src/main/java/io/netty/example/http2/server/HelloWorldHttp2Handler.java",
"example/src/main/java/io/netty/example/http2/server/Http2OrHttpHandler.java",
"example/src/main/java/io/netty/example/http2/server/Http2ServerI... | [] | diff --git a/example/src/main/java/io/netty/example/http2/server/HelloWorldHttp1Handler.java b/example/src/main/java/io/netty/example/http2/server/HelloWorldHttp1Handler.java
index 009e8fa2131..aa8f1d29494 100644
--- a/example/src/main/java/io/netty/example/http2/server/HelloWorldHttp1Handler.java
+++ b/example/src/mai... | null | train | train | 2015-05-18T10:23:54 | 2015-05-08T15:48:32Z | bobymicroby | val |
netty/netty/3724_3793 | netty/netty | netty/netty/3724 | netty/netty/3793 | [
"timestamp(timedelta=104978.0, similarity=0.8452430653395315)"
] | 833b92a5aaca287f0f9ebdc74d15c6f0a5baef74 | 5966411b1a81db9576f1d3bbc7cd0b3119726e2f | [
"@nmittler @buchgr - I have a pending PR for this.\n",
"Fixed by https://github.com/netty/netty/pull/3733\n"
] | [] | 2015-05-15T18:18:09Z | [
"defect"
] | HTTP/2 headers with END_STREAM writes a RST_STREAM | If a headers frame is written with the END_STREAM flag sent we send a RST_STREAM frame. The remote flow controller should not generate a RST_STREAM in this case.
| [
"example/src/main/java/io/netty/example/http2/server/HelloWorldHttp1Handler.java",
"example/src/main/java/io/netty/example/http2/server/HelloWorldHttp2Handler.java",
"example/src/main/java/io/netty/example/http2/server/Http2OrHttpHandler.java",
"example/src/main/java/io/netty/example/http2/server/Http2ServerI... | [
"example/src/main/java/io/netty/example/http2/server/HelloWorldHttp1Handler.java",
"example/src/main/java/io/netty/example/http2/server/HelloWorldHttp2Handler.java",
"example/src/main/java/io/netty/example/http2/server/Http2OrHttpHandler.java",
"example/src/main/java/io/netty/example/http2/server/Http2ServerI... | [] | diff --git a/example/src/main/java/io/netty/example/http2/server/HelloWorldHttp1Handler.java b/example/src/main/java/io/netty/example/http2/server/HelloWorldHttp1Handler.java
index 009e8fa2131..aa8f1d29494 100644
--- a/example/src/main/java/io/netty/example/http2/server/HelloWorldHttp1Handler.java
+++ b/example/src/mai... | null | train | train | 2015-05-18T10:23:54 | 2015-05-04T22:21:01Z | Scottmitch | val |
netty/netty/3815_3873 | netty/netty | netty/netty/3815 | netty/netty/3873 | [
"timestamp(timedelta=41.0, similarity=0.9999999999999998)"
] | e72d04509f7d04d2a0a0e96cc5555728ac03aa29 | 88b5d162226c1c87de563a2790c922d86855d20b | [
"/cc @nmittler @Scottmitch \n",
"@trustin makes sense.\n",
"@trustin SGTM\n",
"+1\n",
"@trustin - Are you taking the assignment on this one?\n",
"I'm on a short travel right now, but will take care of the 3\nHTTP/2-related issues I filed once I'm back on Monday.\n",
"Thanks @trustin\n\n> Am 23.05.2015 ... | [
"nit: consider just inlining: `ch.pipeline().addLast(...)`;\n"
] | 2015-06-09T06:10:34Z | [
"improvement"
] | Do not use hard-coded handler names in HTTP/2 | Our HTTP/2 implementation sometimes uses hard-coded handler names when adding/removing a handler to/from a pipeline. It's not really a good idea because it can easily result in name clashes.
Unless there is a good reason, we need to use the reference to the handlers:
``` java
pipeline.addLast(handler1); // No name s... | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/Http2ClientUpgradeCodec.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/Http2ServerUpgradeCodec.java",
"example/src/main/java/io/netty/example/http2/helloworld/client/Http2ClientInitializer.java",
"example/src/main/java/io/netty/example/ht... | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/Http2ClientUpgradeCodec.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/Http2ServerUpgradeCodec.java",
"example/src/main/java/io/netty/example/http2/helloworld/client/Http2ClientInitializer.java",
"example/src/main/java/io/netty/example/ht... | [
"codec-http2/src/test/java/io/netty/handler/codec/http2/Http2FrameRoundtripTest.java",
"codec-http2/src/test/java/io/netty/handler/codec/http2/InboundHttp2ToHttpAdapterTest.java"
] | diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2ClientUpgradeCodec.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2ClientUpgradeCodec.java
index 9476e59161b..0cdb65b9416 100644
--- a/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2ClientUpgradeCodec.java
+++ b/cod... | diff --git a/codec-http2/src/test/java/io/netty/handler/codec/http2/Http2FrameRoundtripTest.java b/codec-http2/src/test/java/io/netty/handler/codec/http2/Http2FrameRoundtripTest.java
index ba7abd961db..077d48ae4d5 100644
--- a/codec-http2/src/test/java/io/netty/handler/codec/http2/Http2FrameRoundtripTest.java
+++ b/cod... | val | train | 2015-06-09T07:27:02 | 2015-05-21T08:13:53Z | trustin | val |
netty/netty/3883_3889 | netty/netty | netty/netty/3883 | netty/netty/3889 | [
"timestamp(timedelta=15.0, similarity=0.9305900770455292)"
] | f2796bae29ae729cb3f77e0a3e2711d6c1a184f4 | 60874e337df0d1ef6ab36e9a76d8f54bab950898 | [
"@edwinchoi thanks for the report... Will fix it\n",
"@edwinchoi can you verify the fix:\n\nhttps://github.com/netty/netty/pull/3889\n\nThanks!\n",
"@normanmaurer works as expected now, thanks!\n",
"Fixed\n"
] | [] | 2015-06-16T18:05:38Z | [
"defect"
] | OpenSSL SSLSession returns incorrect peer principal | According to the docs for `javax.net.ssl.SSLSession` (http://docs.oracle.com/javase/7/docs/api/javax/net/ssl/SSLSession.html#getPeerPrincipal()), `getPeerPrincipal` should be returning the identity of the peer.
The OpenSSL based implementation for Netty, however, is returning the identity of the issuer:
https://github... | [
"handler/src/main/java/io/netty/handler/ssl/OpenSslEngine.java"
] | [
"handler/src/main/java/io/netty/handler/ssl/OpenSslEngine.java"
] | [] | diff --git a/handler/src/main/java/io/netty/handler/ssl/OpenSslEngine.java b/handler/src/main/java/io/netty/handler/ssl/OpenSslEngine.java
index 53ef4334465..756c11fb163 100644
--- a/handler/src/main/java/io/netty/handler/ssl/OpenSslEngine.java
+++ b/handler/src/main/java/io/netty/handler/ssl/OpenSslEngine.java
@@ -144... | null | train | train | 2015-06-12T21:42:44 | 2015-06-12T00:22:22Z | edwinchoi | val |
netty/netty/3881_3890 | netty/netty | netty/netty/3881 | netty/netty/3890 | [
"timestamp(timedelta=15.0, similarity=0.9466935819050754)"
] | bb17071ea0cb532ce01d2352b4cd001ecc356e96 | 476bcf57211b932aa89868e9c14fe40b46200e51 | [
"@fratboy - Thanks for reporting!\n\n@normanmaurer - Seems legit. WDYT?\n",
"@Scottmitch yep, will fix\n",
"Fixed\n",
":+1: \n"
] | [] | 2015-06-16T18:11:22Z | [
"defect"
] | FixedChannelPool creates 1 more channel than maxConnections | Netty version: 4.0.10.Beta5
Context:
1 more channel was created, when I tried to acquire channel via `FixedChannelPool.acquire`
Steps to reproduct:
1. Create a `FixedChannelPool` with `N` `maxConnections`
2. Call `FixedChannelPool.acquire` from enough many thread
3. `N+1` channels is created.
Opinion:
It looks like... | [
"transport/src/main/java/io/netty/channel/pool/FixedChannelPool.java"
] | [
"transport/src/main/java/io/netty/channel/pool/FixedChannelPool.java"
] | [] | diff --git a/transport/src/main/java/io/netty/channel/pool/FixedChannelPool.java b/transport/src/main/java/io/netty/channel/pool/FixedChannelPool.java
index 1066358dd60..ddafebb8d3a 100644
--- a/transport/src/main/java/io/netty/channel/pool/FixedChannelPool.java
+++ b/transport/src/main/java/io/netty/channel/pool/Fixed... | null | train | train | 2015-06-16T20:10:08 | 2015-06-11T03:40:43Z | alexpark7712 | val |
netty/netty/3888_3891 | netty/netty | netty/netty/3888 | netty/netty/3891 | [
"timestamp(timedelta=117016.0, similarity=0.9135473161642038)"
] | 303cb535239a6f07cbe24a033ef965e2f55758eb | ddd7bdfb8f9d66923eb17e3a4bcdf9bd49ee45f8 | [
"@purplefox FYI\n",
"Fixed\n"
] | [] | 2015-06-16T18:28:09Z | [
"improvement"
] | Number of PoolArena's should be 2 * cores | We use 2 \* cores as the default number of EventLoop's for NIO and EPOLL, so we should do the same for the numbers of PoolArena's. This will reduce conditions.
jemalloc itself even use 4 \* cpus:
http://www.canonware.com/download/jemalloc/jemalloc-latest/doc/jemalloc.html
Related to:
https://groups.google.com/d/msg/... | [
"buffer/src/main/java/io/netty/buffer/PooledByteBufAllocator.java"
] | [
"buffer/src/main/java/io/netty/buffer/PooledByteBufAllocator.java"
] | [] | diff --git a/buffer/src/main/java/io/netty/buffer/PooledByteBufAllocator.java b/buffer/src/main/java/io/netty/buffer/PooledByteBufAllocator.java
index 1ea167883ff..148e6ec0d22 100644
--- a/buffer/src/main/java/io/netty/buffer/PooledByteBufAllocator.java
+++ b/buffer/src/main/java/io/netty/buffer/PooledByteBufAllocator.... | null | val | train | 2015-06-17T06:35:58 | 2015-06-16T12:10:23Z | normanmaurer | val |
netty/netty/3880_3894 | netty/netty | netty/netty/3880 | netty/netty/3894 | [
"timestamp(timedelta=71.0, similarity=0.9854607127688096)"
] | 1644d733ecd388b0b3ee6403118f0f84e1102fe9 | 416cf3b35f2c8cf3726bff4090a767e38a033142 | [] | [
"Can we move this logic into `PrefaceDecoder`? One of the reasons why `FrameDecoder` was introduced was to avoid having a conditional statement evaluate on every `decode` which will only be relevant for the first (or first couple) decode(s).\n",
"I think my previous comment still applies https://github.com/netty... | 2015-06-17T20:20:08Z | [
"improvement"
] | Need better error when first HTTP/2 frame is not SETTINGS | Right now if the protocol upgrade to HTTP/2 fails, the server may send an HTTP 1.1 response leading to a frame parsing error at the client (due to frame length). It would be helpful for receipt of the first frame to verify that the frame type is SETTINGS, if not fail with a better error.
| [
"codec-http2/src/main/java/io/netty/handler/codec/http2/Http2ConnectionHandler.java"
] | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/Http2ConnectionHandler.java"
] | [
"codec-http2/src/test/java/io/netty/handler/codec/http2/Http2ConnectionHandlerTest.java"
] | diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2ConnectionHandler.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2ConnectionHandler.java
index 4ce96fd0daa..042912eb6d2 100644
--- a/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2ConnectionHandler.java
+++ b/codec-... | diff --git a/codec-http2/src/test/java/io/netty/handler/codec/http2/Http2ConnectionHandlerTest.java b/codec-http2/src/test/java/io/netty/handler/codec/http2/Http2ConnectionHandlerTest.java
index 7f44126aadb..4dc3feb9781 100644
--- a/codec-http2/src/test/java/io/netty/handler/codec/http2/Http2ConnectionHandlerTest.java
... | val | train | 2015-06-17T06:36:28 | 2015-06-10T17:52:55Z | nmittler | val |
netty/netty/3915_3917 | netty/netty | netty/netty/3915 | netty/netty/3917 | [
"timestamp(timedelta=628.0, similarity=0.9322608455836241)"
] | b5337abe2aee8e20153900fb7024f989555cf142 | 29b79393ec7a19ba687d49691cab80161d40200d | [
"@louiscryan sounds like a bug... would you mind creating a PR with fix + unit test?\n",
"already in progress... :)\n",
"@louiscryan yay :) Ping me once ready for review\n",
"Cherry-picked, thanks!\n"
] | [] | 2015-06-26T21:45:47Z | [
"defect"
] | FixedCompositeByteBuf is broken copying bytes to direct buffers | @normanmaurer @trustin
In methods like
public ByteBuf getBytes(int index, ByteBuf dst, int dstIndex, int length) {
it uses
int localLength = Math.min(length, s.capacity() - (index - adjustment));
instead of
int localLength = Math.min(length, s.readableBytes() - (index - adjustment));
This looks like a rough c... | [
"buffer/src/main/java/io/netty/buffer/FixedCompositeByteBuf.java"
] | [
"buffer/src/main/java/io/netty/buffer/FixedCompositeByteBuf.java"
] | [
"buffer/src/test/java/io/netty/buffer/FixedCompositeByteBufTest.java"
] | diff --git a/buffer/src/main/java/io/netty/buffer/FixedCompositeByteBuf.java b/buffer/src/main/java/io/netty/buffer/FixedCompositeByteBuf.java
index 816c0b41de9..af28d682d8d 100644
--- a/buffer/src/main/java/io/netty/buffer/FixedCompositeByteBuf.java
+++ b/buffer/src/main/java/io/netty/buffer/FixedCompositeByteBuf.java... | diff --git a/buffer/src/test/java/io/netty/buffer/FixedCompositeByteBufTest.java b/buffer/src/test/java/io/netty/buffer/FixedCompositeByteBufTest.java
index 7dea5ebf567..812e140b25c 100644
--- a/buffer/src/test/java/io/netty/buffer/FixedCompositeByteBufTest.java
+++ b/buffer/src/test/java/io/netty/buffer/FixedComposite... | val | train | 2015-06-24T21:09:39 | 2015-06-26T19:37:21Z | louiscryan | val |
netty/netty/3922_3923 | netty/netty | netty/netty/3922 | netty/netty/3923 | [
"timestamp(timedelta=16218.0, similarity=0.8750788523995916)"
] | 46b2eff75701f6ffe3a12b926ccef6764b77d2cc | 8ac43e52e08c0c5e22448c606deb30ca70ba0efc | [
"@0mok - Should this be closed?\n",
"Yes.\n"
] | [] | 2015-06-29T14:24:38Z | [] | `OpenSslServerContext.setTicketKeys` does not works in 3.x | There are invalid check arguments in 'OpenSslServerContext.setTicketKeys'.
```
public void setTicketKeys(byte[] keys) {
if (keys != null) {
throw new NullPointerException("keys");
}
```
| [
"src/main/java/org/jboss/netty/handler/ssl/OpenSslServerContext.java"
] | [
"src/main/java/org/jboss/netty/handler/ssl/OpenSslServerContext.java"
] | [] | diff --git a/src/main/java/org/jboss/netty/handler/ssl/OpenSslServerContext.java b/src/main/java/org/jboss/netty/handler/ssl/OpenSslServerContext.java
index 15a15ac9656..f6e7b3ef7ab 100644
--- a/src/main/java/org/jboss/netty/handler/ssl/OpenSslServerContext.java
+++ b/src/main/java/org/jboss/netty/handler/ssl/OpenSslSe... | null | train | train | 2015-05-12T11:23:56 | 2015-06-29T14:19:35Z | 0mok | val |
netty/netty/3896_3930 | netty/netty | netty/netty/3896 | netty/netty/3930 | [
"timestamp(timedelta=48.0, similarity=0.8425013773895875)"
] | bb0b86ce50073a7de7f8f5918774b7c76bf4f99f | 4151eaa5b30fd96deaff7d2770f78e3451c58ee5 | [
"@sefler1987 I think you are right... We should call duplicate on the buffer first. Let me fix it\n",
"Thank you so much~\n",
"Fixed by https://github.com/netty/netty/pull/3930\n"
] | [] | 2015-07-03T12:14:17Z | [
"defect"
] | "ByteBuf copiedBuffer(ByteBuffer buffer)" in Netty 4.0.24 is NOT thread safe | I'm not sure why this static method is not thread safe, but it bothers me a lot during the development. As the following code shows, the method firstly copy the position out and then set it back after copying. If there are two threads doing the same thing, the position may be stained.
```
public static ByteBuf cop... | [
"buffer/src/main/java/io/netty/buffer/Unpooled.java"
] | [
"buffer/src/main/java/io/netty/buffer/Unpooled.java"
] | [] | diff --git a/buffer/src/main/java/io/netty/buffer/Unpooled.java b/buffer/src/main/java/io/netty/buffer/Unpooled.java
index 0c071071cbc..742c17f49cb 100644
--- a/buffer/src/main/java/io/netty/buffer/Unpooled.java
+++ b/buffer/src/main/java/io/netty/buffer/Unpooled.java
@@ -392,13 +392,11 @@ public static ByteBuf copiedB... | null | test | train | 2015-06-27T21:21:36 | 2015-06-18T04:59:02Z | seflerZ | val |
netty/netty/3780_3931 | netty/netty | netty/netty/3780 | netty/netty/3931 | [
"timestamp(timedelta=37.0, similarity=0.8435129399591724)"
] | 287ac6d328a23ae5dd098206dd7c8df9f0e2d0a1 | ff1bdda2bbb7226e2ebfd6e50bc30400fd2e5822 | [
"@zoowar the question is how we should propagate here as if initChannel(...) throws an exception chances are good that you will not have an handler in the pipeline that can handle the exception.\n",
"@normanmaurer When there is no exceptionCaught implemented by any of the pipeline handlers, the framework handles ... | [
"Instantiate this exception outside the channel scope so you can do `assertSame` at the end of the test?\n"
] | 2015-07-03T12:15:52Z | [
"defect"
] | ChannelInitializer does not propagate Exceptions | Netty version: 5.0.0.Alpha2 (but others as well)
Context:
When an exception occurs in a user defined initChannel, it is not propagated through the framework so that it can be handled with exceptionCaught. Instead, channelRegistered logs a warning and dumps a stack trace.
Steps to reproduce:
Throw a generic exception ... | [
"transport/src/main/java/io/netty/channel/ChannelInitializer.java"
] | [
"transport/src/main/java/io/netty/channel/ChannelInitializer.java"
] | [
"transport/src/test/java/io/netty/channel/DefaultChannelPipelineTest.java"
] | diff --git a/transport/src/main/java/io/netty/channel/ChannelInitializer.java b/transport/src/main/java/io/netty/channel/ChannelInitializer.java
index f346f553cda..5db2c291805 100644
--- a/transport/src/main/java/io/netty/channel/ChannelInitializer.java
+++ b/transport/src/main/java/io/netty/channel/ChannelInitializer.... | diff --git a/transport/src/test/java/io/netty/channel/DefaultChannelPipelineTest.java b/transport/src/test/java/io/netty/channel/DefaultChannelPipelineTest.java
index 40749b59db5..11503bd90fe 100644
--- a/transport/src/test/java/io/netty/channel/DefaultChannelPipelineTest.java
+++ b/transport/src/test/java/io/netty/cha... | test | train | 2015-07-07T08:47:18 | 2015-05-13T17:53:16Z | zoowar | val |
Subsets and Splits
Java Code Detection in Problems
Identifies and categorizes entries in the dataset that are likely related to Java programming, providing insights into the prevalence and type of Java content in the problem statements.