Datasets:
feedback-to-code
/
mozzarella

Dataset card Data Studio Files
xet
 Community
1
instance_id
stringlengths
17
39
repo
stringclasses
8 values
issue_id
stringlengths
14
34
pr_id
stringlengths
14
34
linking_methods
listlengths
1
3
base_commit
stringlengths
40
40
merge_commit
stringlengths
0
40
⌀
hints_text
listlengths
0
106
resolved_comments
listlengths
0
119
created_at
timestamp[ns, tz=UTC]
labeled_as
listlengths
0
7
problem_title
stringlengths
7
174
problem_statement
stringlengths
0
55.4k
gold_files
listlengths
0
10
gold_files_postpatch
listlengths
1
10
test_files
listlengths
0
60
gold_patch
stringlengths
220
5.83M
test_patch
stringlengths
386
194k
⌀
split_random
stringclasses
3 values
split_time
stringclasses
3 values
issue_start_time
timestamp[ns]
issue_created_at
timestamp[ns, tz=UTC]
issue_by_user
stringlengths
3
21
split_repo
stringclasses
3 values
netty/netty/9995_9999
netty/netty
netty/netty/9995
netty/netty/9999
[ "keyword_pr_to_issue" ]
56055f4404fbebeb6403165d352d62330a1bf81d
2a5118f824afefa53f1cd199cf56dee0746b8688
[ "We love love contributions so feel free to submit a PR if you have time. Otherwise it may take a bit before I will have a chance to do it \n\n> Am 05.02.2020 um 04:12 schrieb Ruwei <notifications@github.com>:\n> \n> \n> Expected behavior\n> \n> I'm writing a smtp client based on netty. SmtpCommand lacks the AUTH ...
[]
2020-02-06T08:37:35Z
[]
SmtpCommand lacks AUTH
### Expected behavior I'm writing a smtp client based on netty. SmtpCommand lacks the AUTH command. It is used to login to an SMTP server. See it in https://www.ietf.org/rfc/rfc4954.txt Is it possible to add it ? ### Actual behavior Can not create an AUTH command. ### Steps to reproduce ### Minimal yet c...
[ "codec-smtp/src/main/java/io/netty/handler/codec/smtp/SmtpCommand.java", "codec-smtp/src/main/java/io/netty/handler/codec/smtp/SmtpRequestEncoder.java", "codec-smtp/src/main/java/io/netty/handler/codec/smtp/SmtpRequests.java" ]
[ "codec-smtp/src/main/java/io/netty/handler/codec/smtp/SmtpCommand.java", "codec-smtp/src/main/java/io/netty/handler/codec/smtp/SmtpRequestEncoder.java", "codec-smtp/src/main/java/io/netty/handler/codec/smtp/SmtpRequests.java" ]
[ "codec-smtp/src/test/java/io/netty/handler/codec/smtp/SmtpRequestEncoderTest.java" ]
diff --git a/codec-smtp/src/main/java/io/netty/handler/codec/smtp/SmtpCommand.java b/codec-smtp/src/main/java/io/netty/handler/codec/smtp/SmtpCommand.java index 63ba3f5847f..a2c69b866df 100644 --- a/codec-smtp/src/main/java/io/netty/handler/codec/smtp/SmtpCommand.java +++ b/codec-smtp/src/main/java/io/netty/handler/cod...
diff --git a/codec-smtp/src/test/java/io/netty/handler/codec/smtp/SmtpRequestEncoderTest.java b/codec-smtp/src/test/java/io/netty/handler/codec/smtp/SmtpRequestEncoderTest.java index fb145149225..320bae4514d 100644 --- a/codec-smtp/src/test/java/io/netty/handler/codec/smtp/SmtpRequestEncoderTest.java +++ b/codec-smtp/s...
val
test
2020-02-06T09:02:31
2020-02-05T03:12:36Z
yuanrw
val
netty/netty/10067_10069
netty/netty
netty/netty/10067
netty/netty/10069
[ "keyword_pr_to_issue" ]
04532220152a69a04064537daffd9e57953b81c0
7fce06a0d1f76865b1494fde99697c31a8a1f92f
[]
[ "this is not correct (and also not the one above) as you will cause a `ClassCastException` later on if the `ChannelHandlerContext` does not wrap an `ChannelOutboundHandler`." ]
2020-02-29T06:34:18Z
[]
HttpContentCompressor doesn't work when put on an alternate EventExecutor
### Expected behavior The following isn't expected to mangle or lose the response content: pipeline.addLast(eventExecutor, new HttpContentCompressor()); ### Actual behavior The content may be mangled or completely lost. ### Steps to reproduce ` .addLast(compressorGroup, new ...
[ "transport/src/main/java/io/netty/channel/AbstractChannelHandlerContext.java", "transport/src/main/java/io/netty/channel/ChannelHandlerMask.java" ]
[ "transport/src/main/java/io/netty/channel/AbstractChannelHandlerContext.java", "transport/src/main/java/io/netty/channel/ChannelHandlerMask.java" ]
[ "codec-http/src/test/java/io/netty/handler/codec/http/HttpContentCompressorTest.java" ]
diff --git a/transport/src/main/java/io/netty/channel/AbstractChannelHandlerContext.java b/transport/src/main/java/io/netty/channel/AbstractChannelHandlerContext.java index ec4c9b45be0..92c912a5000 100644 --- a/transport/src/main/java/io/netty/channel/AbstractChannelHandlerContext.java +++ b/transport/src/main/java/io/...
diff --git a/codec-http/src/test/java/io/netty/handler/codec/http/HttpContentCompressorTest.java b/codec-http/src/test/java/io/netty/handler/codec/http/HttpContentCompressorTest.java index d0676fd907a..bb43b3c9380 100644 --- a/codec-http/src/test/java/io/netty/handler/codec/http/HttpContentCompressorTest.java +++ b/cod...
val
test
2020-03-02T08:38:45
2020-02-29T06:30:30Z
atcurtis
val
netty/netty/10072_10075
netty/netty
netty/netty/10072
netty/netty/10075
[ "keyword_pr_to_issue" ]
1b0e3d95f43b710261695b1731522ed3b6d29e0d
7b946a781e9ed78d9283f7907aeb4b8471dc9a3a
[ "And I'm happy to work on a patch once I get a 👍 that someone else agrees this is a problem.", "@bryce-anderson yes this sounds like a bug.", "so yep please work on a fix @bryce-anderson :)" ]
[ "This feels like something that almost certainly exists somewhere else.", "This change isn't strictly necessary for this patch but I spent a fair amount of time trying to read through this for the nth time and decided to clean it up so the control flow (when the method returns etc, _**not**_ H2 flow control) is m...
2020-03-02T20:32:27Z
[]
AbstractHttp2StreamChannel fails to flush window update under certain read patterns
### Expected behavior Window updates get flushed by `AbstractHttp2StreamChannel`. ### Actual behavior Under certain conditions that doesn't happen. ### Steps to reproduce ### Minimal yet complete reproducer code (or URL to code) I have a test case that is really ugly and should probably be condensed but...
[ "codec-http2/src/main/java/io/netty/handler/codec/http2/AbstractHttp2StreamChannel.java" ]
[ "codec-http2/src/main/java/io/netty/handler/codec/http2/AbstractHttp2StreamChannel.java" ]
[ "codec-http2/src/test/java/io/netty/handler/codec/http2/Http2MultiplexTest.java", "codec-http2/src/test/java/io/netty/handler/codec/http2/Http2TestUtil.java" ]
diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/AbstractHttp2StreamChannel.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/AbstractHttp2StreamChannel.java index 547d724f556..92abf19a246 100644 --- a/codec-http2/src/main/java/io/netty/handler/codec/http2/AbstractHttp2StreamChannel.java ...
diff --git a/codec-http2/src/test/java/io/netty/handler/codec/http2/Http2MultiplexTest.java b/codec-http2/src/test/java/io/netty/handler/codec/http2/Http2MultiplexTest.java index 8dcc579797c..c1207f686e0 100644 --- a/codec-http2/src/test/java/io/netty/handler/codec/http2/Http2MultiplexTest.java +++ b/codec-http2/src/te...
test
test
2020-03-03T14:34:51
2020-03-01T15:53:57Z
bryce-anderson
val
netty/netty/10123_10128
netty/netty
netty/netty/10123
netty/netty/10128
[ "keyword_pr_to_issue" ]
99aca1879fcd69e4beecd100dcff5bec61eb2b84
913cae6fef1f708238918cbdf3b25db03c805604
[ "Hi! \r\nI agree that the approach using the instrinsic is to be preferred, but I'm curious about the impact: do we have benchmarks that measure the benefit of replacing it on `PoolThreadCache` and mimic a real case usage?", "Originally I noticed the log2 method in a async profiler cpu framegraph for an applicati...
[]
2020-03-22T21:06:58Z
[]
Optimize log2 in PoolThreadCache
Optimize log2 in PoolThreadCache Currently io.netty.buffer.PoolThreadCache uses log2 implementation based on a shift loop. It is not a most efficient way: https://gist.github.com/netudima/e1e8206bf58ff0ab6e2d637a4362bfc2 ``` NettyLog2Benchmark.bits avgt 25 2.612 ± 0.009 ns/op NettyLog2Benchmark.c...
[ "buffer/src/main/java/io/netty/buffer/PoolThreadCache.java" ]
[ "buffer/src/main/java/io/netty/buffer/PoolThreadCache.java" ]
[]
diff --git a/buffer/src/main/java/io/netty/buffer/PoolThreadCache.java b/buffer/src/main/java/io/netty/buffer/PoolThreadCache.java index c1bf7e6d074..92e46a0f02d 100644 --- a/buffer/src/main/java/io/netty/buffer/PoolThreadCache.java +++ b/buffer/src/main/java/io/netty/buffer/PoolThreadCache.java @@ -42,6 +42,7 @@ fina...
null
val
test
2020-03-19T12:47:46
2020-03-21T08:48:34Z
netudima
val
netty/netty/10164_10175
netty/netty
netty/netty/10164
netty/netty/10175
[ "keyword_pr_to_issue" ]
b996bf2151fe99b5fc528b98ac5ea65681380e2f
37948bc9debb3646150365e21da5d38342bbb3c5
[ "@jrhee17 sure this sounds like something useful. Please provide a PR and I will review it :)", "@jrhee17 please let me know once you have a PR ...", "Apologies for the delay -- I was drafting a POC on the client-side library to get a better idea on how this encoder will be used. The PR has been opened 🍀 " ]
[ "shouldn't `address.length() > 108` be good enough ?", "As this one is `@Sharable` should we add a private constructor, mark it final and expose a static instance that the user can use ?", "why we dont write stuff directly to the `ByteBuf` ? We can use `out.writeCharSequence(...)`", "consider using a `switch`...
2020-04-08T14:08:31Z
[]
Consider adding support for HAProxyMessageEncoder
**Subject** Consider adding support for `HAProxyMessageEncoder` **Motivation** I am working on a [project](https://github.com/line/armeria) which offers server-side PROXY protocol support (using netty `HaProxyMessageDecoder` 💯 ) All works fine, but we have some limitations: 1) Sometimes, clients may want to...
[ "codec-haproxy/src/main/java/io/netty/handler/codec/haproxy/HAProxyConstants.java", "codec-haproxy/src/main/java/io/netty/handler/codec/haproxy/HAProxyMessage.java", "codec-haproxy/src/main/java/io/netty/handler/codec/haproxy/HAProxyMessageDecoder.java", "codec-haproxy/src/main/java/io/netty/handler/codec/hap...
[ "codec-haproxy/src/main/java/io/netty/handler/codec/haproxy/HAProxyConstants.java", "codec-haproxy/src/main/java/io/netty/handler/codec/haproxy/HAProxyMessage.java", "codec-haproxy/src/main/java/io/netty/handler/codec/haproxy/HAProxyMessageDecoder.java", "codec-haproxy/src/main/java/io/netty/handler/codec/hap...
[ "codec-haproxy/src/test/java/io/netty/handler/codec/haproxy/HAProxyIntegrationTest.java", "codec-haproxy/src/test/java/io/netty/handler/codec/haproxy/HaProxyMessageEncoderTest.java" ]
diff --git a/codec-haproxy/src/main/java/io/netty/handler/codec/haproxy/HAProxyConstants.java b/codec-haproxy/src/main/java/io/netty/handler/codec/haproxy/HAProxyConstants.java index c2a4e22c723..4a79b172d39 100644 --- a/codec-haproxy/src/main/java/io/netty/handler/codec/haproxy/HAProxyConstants.java +++ b/codec-haprox...
diff --git a/codec-haproxy/src/test/java/io/netty/handler/codec/haproxy/HAProxyIntegrationTest.java b/codec-haproxy/src/test/java/io/netty/handler/codec/haproxy/HAProxyIntegrationTest.java new file mode 100644 index 00000000000..8af8f45493e --- /dev/null +++ b/codec-haproxy/src/test/java/io/netty/handler/codec/haproxy/...
train
test
2020-04-14T14:23:45
2020-04-03T18:34:01Z
jrhee17
val
netty/netty/10181_10182
netty/netty
netty/netty/10181
netty/netty/10182
[ "connected" ]
2b14775446f3f3937ddd6eb6bd7b22686810908f
79ef0c4706b64bd0b6c3ce24516beb587a0c5f4a
[ "I think @ejona86 @nmittler did mention that Conscrypt only works on Java8 in general. This may be special for Android tho.. So yep I would be happy to review and merge a PR which special case Android @gnarea ", "I think we've been able to run Conscrypt with Java 7. I see Conscrypt itself is building with Java 7 ...
[]
2020-04-10T17:09:27Z
[]
Workaround to use Netty 4.1 with TLS on Android
We need to run a gRPC server on Android so we're planning to use Netty for that. Everything seems to work, but we had to change the following: https://github.com/netty/netty/blob/2b14775446f3f3937ddd6eb6bd7b22686810908f/handler/src/main/java/io/netty/handler/ssl/Conscrypt.java#L59 Because `PlatformDependent.javaV...
[ "handler/src/main/java/io/netty/handler/ssl/Conscrypt.java" ]
[ "handler/src/main/java/io/netty/handler/ssl/Conscrypt.java" ]
[]
diff --git a/handler/src/main/java/io/netty/handler/ssl/Conscrypt.java b/handler/src/main/java/io/netty/handler/ssl/Conscrypt.java index 9c9e2bba62c..c4c9182c41a 100644 --- a/handler/src/main/java/io/netty/handler/ssl/Conscrypt.java +++ b/handler/src/main/java/io/netty/handler/ssl/Conscrypt.java @@ -56,7 +56,8 @@ priva...
null
train
test
2020-04-08T12:04:48
2020-04-10T15:28:01Z
gnarea
val
netty/netty/10202_10207
netty/netty
netty/netty/10202
netty/netty/10207
[ "keyword_pr_to_issue" ]
5fa5ce34e1580932c54cde56dd51c207288edde3
4f72cdf2333f682410e23e1eb5d77bc66b186cf4
[ "@fabienrenaud we love contributions :) So if you are interested maybe you want to provide a PR", "PR: https://github.com/netty/netty/pull/10207" ]
[ "~let's not change the default values used here.~", "2020", "ah never mind... this is because we use the one configured by the system in `DnsNameResolver` then ", "@fabienrenaud I wonder if we should better do this as part of the builder ?", "Doable. \r\nBut I'd need to keep this `ndots >= 0 ? ndots : DEFAU...
2020-04-24T05:41:01Z
[]
DNS Resolver - Honor etc/resolv.conf options timeout, rotate and attempts
[/etc/resolv.conf](https://linux.die.net/man/5/resolv.conf) options support `timeout`, `rotate` and `attempts` but the [UnixResolverDnsServerAddressStreamProvider](https://github.com/netty/netty/blob/4.1/resolver-dns/src/main/java/io/netty/resolver/dns/UnixResolverDnsServerAddressStreamProvider.java#L292) ignores these...
[ "resolver-dns/src/main/java/io/netty/resolver/dns/DnsNameResolver.java", "resolver-dns/src/main/java/io/netty/resolver/dns/DnsNameResolverBuilder.java", "resolver-dns/src/main/java/io/netty/resolver/dns/UnixResolverDnsServerAddressStreamProvider.java" ]
[ "resolver-dns/src/main/java/io/netty/resolver/dns/DnsNameResolver.java", "resolver-dns/src/main/java/io/netty/resolver/dns/DnsNameResolverBuilder.java", "resolver-dns/src/main/java/io/netty/resolver/dns/UnixResolverDnsServerAddressStreamProvider.java", "resolver-dns/src/main/java/io/netty/resolver/dns/UnixRes...
[ "resolver-dns/src/test/java/io/netty/resolver/dns/UnixResolverDnsServerAddressStreamProviderTest.java" ]
diff --git a/resolver-dns/src/main/java/io/netty/resolver/dns/DnsNameResolver.java b/resolver-dns/src/main/java/io/netty/resolver/dns/DnsNameResolver.java index 67f85dcce6a..ca3668a6b7d 100644 --- a/resolver-dns/src/main/java/io/netty/resolver/dns/DnsNameResolver.java +++ b/resolver-dns/src/main/java/io/netty/resolver/...
diff --git a/resolver-dns/src/test/java/io/netty/resolver/dns/UnixResolverDnsServerAddressStreamProviderTest.java b/resolver-dns/src/test/java/io/netty/resolver/dns/UnixResolverDnsServerAddressStreamProviderTest.java index 6bb133a11aa..97e3d8a75fb 100644 --- a/resolver-dns/src/test/java/io/netty/resolver/dns/UnixResolv...
test
test
2020-04-27T13:59:01
2020-04-22T19:46:13Z
fabienrenaud
val
netty/netty/10200_10209
netty/netty
netty/netty/10200
netty/netty/10209
[ "keyword_pr_to_issue" ]
5fa5ce34e1580932c54cde56dd51c207288edde3
c354fa48e10de847cf17c10083a2cbc2c0a63a36
[]
[ "@fabienrenaud let's use `buf.retainedSlice()`", "right...\r\ndone!", "@fabienrenaud Can you add a comment that its only fine to not copy here as we will never call `undecodedChunk.writeBytes(...)` later on ?", "same comment as above ", "added", "added", "@fabienrenaud why this change ?", "the previou...
2020-04-24T08:19:04Z
[]
HttpPostRequestDecoder: copy-free implementation
`HttpPostRequestDecoder` decoder implementations (`HttpPostStandardRequestDecoder` and `HttpPostMultipartRequestDecoder`) both do a full copy of the `ByteBuf` before decoding. ``` public HttpPostStandardRequestDecoder offer(HttpContent content) { checkDestroyed(); // Maybe we should better ...
[ "codec-http/src/main/java/io/netty/handler/codec/http/multipart/HttpPostMultipartRequestDecoder.java", "codec-http/src/main/java/io/netty/handler/codec/http/multipart/HttpPostStandardRequestDecoder.java" ]
[ "codec-http/src/main/java/io/netty/handler/codec/http/multipart/HttpPostMultipartRequestDecoder.java", "codec-http/src/main/java/io/netty/handler/codec/http/multipart/HttpPostStandardRequestDecoder.java" ]
[ "codec-http/src/test/java/io/netty/handler/codec/http/multipart/HttpPostRequestDecoderTest.java" ]
diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/multipart/HttpPostMultipartRequestDecoder.java b/codec-http/src/main/java/io/netty/handler/codec/http/multipart/HttpPostMultipartRequestDecoder.java index 4d59e4d47e0..95079f25fd6 100644 --- a/codec-http/src/main/java/io/netty/handler/codec/http/multipar...
diff --git a/codec-http/src/test/java/io/netty/handler/codec/http/multipart/HttpPostRequestDecoderTest.java b/codec-http/src/test/java/io/netty/handler/codec/http/multipart/HttpPostRequestDecoderTest.java index 40771e017ad..7efdc55849e 100644 --- a/codec-http/src/test/java/io/netty/handler/codec/http/multipart/HttpPost...
train
test
2020-04-27T13:59:01
2020-04-21T16:48:21Z
fabienrenaud
val
netty/netty/10245_10247
netty/netty
netty/netty/10245
netty/netty/10247
[ "keyword_pr_to_issue" ]
cfcd7a4fdecde6173a1cddea9c1df703e9910895
c3db0391affb7eca0cd95a49d0b1063e3a2c3599
[ "Coworker reports that this NPE does not occur anymore after downgrading Netty to 4.1.34.Final, which is the last version before #8939.", "High throughput in sense of Bandwidth or Connections?", "Bandwidth. AIUI he had a simulator running that only created one connection but was sending messages constantly.", ...
[]
2020-05-05T03:02:37Z
[ "defect" ]
NPE in CompositeByteBuf when reading from channel
### Expected behavior There should not be a NullPointerException. ### Actual behavior A NullPointerException occurs: ``` io.netty.handler.codec.DecoderException: java.lang.NullPointerException at io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:280) ~[netty-all-4.1.45.Final.jar:...
[ "buffer/src/main/java/io/netty/buffer/CompositeByteBuf.java" ]
[ "buffer/src/main/java/io/netty/buffer/CompositeByteBuf.java" ]
[ "buffer/src/test/java/io/netty/buffer/AbstractCompositeByteBufTest.java", "buffer/src/test/java/io/netty/buffer/WrappedCompositeByteBufTest.java" ]
diff --git a/buffer/src/main/java/io/netty/buffer/CompositeByteBuf.java b/buffer/src/main/java/io/netty/buffer/CompositeByteBuf.java index 48a2006a9f5..f949a2e78c0 100644 --- a/buffer/src/main/java/io/netty/buffer/CompositeByteBuf.java +++ b/buffer/src/main/java/io/netty/buffer/CompositeByteBuf.java @@ -473,7 +473,12 @...
diff --git a/buffer/src/test/java/io/netty/buffer/AbstractCompositeByteBufTest.java b/buffer/src/test/java/io/netty/buffer/AbstractCompositeByteBufTest.java index d48b266a0ed..1c36be3b4ad 100644 --- a/buffer/src/test/java/io/netty/buffer/AbstractCompositeByteBufTest.java +++ b/buffer/src/test/java/io/netty/buffer/Abstr...
val
test
2020-04-29T17:52:43
2020-05-04T18:39:13Z
rdicroce
val
netty/netty/10261_10274
netty/netty
netty/netty/10261
netty/netty/10274
[ "keyword_pr_to_issue" ]
1c21733fb902ae40be29c11184cc712ddcc0a259
714dd00aabb414e6cfa931888328ad41d8f323e9
[ "Hi, I take a look " ]
[ "@amizurov unfortunately this is a a breaking change as it changes the method signature of some methods ", "Yes but this is only example, maybe you can advice another way ?", "ah sorry missed that... Changing an example is of course fine.", "hmm... is this really correct for the case where `msg` isn't an inst...
2020-05-12T09:52:29Z
[]
why stomp.js can not get the message body
### Expected behavior Expect the stomp.js can use netty stomp send a messge to a topic and other stomp.js can receive the message. ### Actual behavior when Iuse netty stomp send a messge to a topic and other stomp.js receive the message,I found the stomp.js client can not recevice the message the message body is em...
[ "example/src/main/java/io/netty/example/stomp/websocket/StompWebSocketProtocolCodec.java" ]
[ "example/src/main/java/io/netty/example/stomp/websocket/StompWebSocketFrameEncoder.java", "example/src/main/java/io/netty/example/stomp/websocket/StompWebSocketProtocolCodec.java" ]
[]
diff --git a/example/src/main/java/io/netty/example/stomp/websocket/StompWebSocketFrameEncoder.java b/example/src/main/java/io/netty/example/stomp/websocket/StompWebSocketFrameEncoder.java new file mode 100644 index 00000000000..68b92e6992f --- /dev/null +++ b/example/src/main/java/io/netty/example/stomp/websocket/Stom...
null
train
test
2020-05-12T08:48:54
2020-05-08T08:06:48Z
xiaozaiyuji
val
netty/netty/10284_10285
netty/netty
netty/netty/10284
netty/netty/10285
[ "keyword_pr_to_issue" ]
caf51b72840e12142b3a87355da63e33230b24b4
d5087deec63e0152b76d1564d3fa8ae31d84c6af
[]
[]
2020-05-13T16:42:26Z
[]
HttpPostStandardRequestDecoder not decoding `+` to whitespaces
The new `UrlDecoder` in `HttpPostStandardRequestDecoder` does not convert `+` to whitespaces, which `QueryStringDecoder.decodeComponent` used to do. https://github.com/netty/netty/pull/10209/files#diff-99f86aa293d9977ca3a310e1488d31c1R713
[ "codec-http/src/main/java/io/netty/handler/codec/http/multipart/HttpPostStandardRequestDecoder.java" ]
[ "codec-http/src/main/java/io/netty/handler/codec/http/multipart/HttpPostStandardRequestDecoder.java" ]
[ "codec-http/src/test/java/io/netty/handler/codec/http/multipart/HttpPostRequestDecoderTest.java" ]
diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/multipart/HttpPostStandardRequestDecoder.java b/codec-http/src/main/java/io/netty/handler/codec/http/multipart/HttpPostStandardRequestDecoder.java index 4cb82e678da..a71e2a14a2e 100644 --- a/codec-http/src/main/java/io/netty/handler/codec/http/multipart/...
diff --git a/codec-http/src/test/java/io/netty/handler/codec/http/multipart/HttpPostRequestDecoderTest.java b/codec-http/src/test/java/io/netty/handler/codec/http/multipart/HttpPostRequestDecoderTest.java index 7efdc55849e..02958d46aa1 100644 --- a/codec-http/src/test/java/io/netty/handler/codec/http/multipart/HttpPost...
test
test
2020-05-13T08:00:23
2020-05-13T16:35:52Z
fabienrenaud
val
netty/netty/10288_10289
netty/netty
netty/netty/10288
netty/netty/10289
[ "keyword_pr_to_issue" ]
caf51b72840e12142b3a87355da63e33230b24b4
20b8685c8b9a35b33f27c8b26900cf65e1575417
[ "cc @ejona86 \r\n\r\nI see 2 options:\r\n1) provide an explicit setter in `SslContextBuilder` and the value is then plumbed down to where it is used in `ReferenceCountedOpenSslContext`. \r\n2) `SslContextBuilder` will have some logic to automatically set this value (say if a custom `TrustManagerFactory` was used) a...
[]
2020-05-13T21:13:44Z
[]
useTasks should be set or settable per ReferenceCountedOpenSslContext
### Expected behavior Each `ReferenceCountedOpenSslContext` instance have its own setting for UseTasks ### Actual behavior Currently `USE_TASKS` is a global set from the system property `"io.netty.handler.ssl.openssl.useTasks"` so all `ReferenceCountedOpenSslContext` instances are forced to use that one value. ###...
[ "handler/src/main/java/io/netty/handler/ssl/ReferenceCountedOpenSslContext.java" ]
[ "handler/src/main/java/io/netty/handler/ssl/ReferenceCountedOpenSslContext.java" ]
[]
diff --git a/handler/src/main/java/io/netty/handler/ssl/ReferenceCountedOpenSslContext.java b/handler/src/main/java/io/netty/handler/ssl/ReferenceCountedOpenSslContext.java index bc72db4c218..27eb43574c0 100644 --- a/handler/src/main/java/io/netty/handler/ssl/ReferenceCountedOpenSslContext.java +++ b/handler/src/main/j...
null
test
test
2020-05-13T08:00:23
2020-05-13T17:34:24Z
sanjaypujare
val
netty/netty/10320_10321
netty/netty
netty/netty/10320
netty/netty/10321
[ "keyword_pr_to_issue" ]
0375e6e01b0b6412c2369a8d3e2a990f41a9edfa
de134da720d23909151d20e6af6eb2a96181bf03
[]
[ "you need to call `c.release();`", "nit: move the `;` one line up", "Done by `channel.releaseInbound()`", "Done", "Consider writing the full HTTP request (including one or two chunks + last (zero) chunk + some trailers) to make sure that decoder's state machine transitions to the correct state and handles t...
2020-05-27T01:19:13Z
[]
More values other than chunked defined in Transfer-Encoding header leads to decode failure
According to https://tools.ietf.org/html/rfc7230#page-29, people can specify multiple values for `Transfer-Encoding` HTTP header, like: `Transfer-Encoding: gzip, chunked`, but Netty does not recognize it as a chunked request in this case. ### Expected behavior There is no exception in server, and client should get...
[ "codec-http/src/main/java/io/netty/handler/codec/http/HttpContentDecoder.java", "codec-http/src/main/java/io/netty/handler/codec/http/HttpUtil.java" ]
[ "codec-http/src/main/java/io/netty/handler/codec/http/HttpContentDecoder.java", "codec-http/src/main/java/io/netty/handler/codec/http/HttpUtil.java" ]
[ "codec-http/src/test/java/io/netty/handler/codec/http/HttpContentDecoderTest.java" ]
diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/HttpContentDecoder.java b/codec-http/src/main/java/io/netty/handler/codec/http/HttpContentDecoder.java index d2513e4a5a8..686d03257e8 100644 --- a/codec-http/src/main/java/io/netty/handler/codec/http/HttpContentDecoder.java +++ b/codec-http/src/main/java...
diff --git a/codec-http/src/test/java/io/netty/handler/codec/http/HttpContentDecoderTest.java b/codec-http/src/test/java/io/netty/handler/codec/http/HttpContentDecoderTest.java index 24833a7f8d4..20f41eab49b 100644 --- a/codec-http/src/test/java/io/netty/handler/codec/http/HttpContentDecoderTest.java +++ b/codec-http/s...
train
test
2020-05-25T07:39:52
2020-05-27T01:06:20Z
gaol
val
netty/netty/10384_10387
netty/netty
netty/netty/10384
netty/netty/10387
[ "keyword_pr_to_issue" ]
523dc5c269fef07d3e9ceb1e7944118645b0717c
9893ac726fef12157c996bc827e2cdc840f7ef35
[ "/cc @bsideup ", "@normanmaurer well, it does read the file internally :) Consider either pre-loading it or adding `io.netty.handler.ssl.ReferenceCountedOpenSslClientContext$ExtendedTrustManagerVerifyCallback.verify` to the list of allowed methods", "@bsideup adding this extra method sounds like good enough... ...
[]
2020-07-02T10:08:15Z
[]
Blocking call in ReferenceCountedOpenSslClientContext$ExtendedTrustManagerVerifyCallback
### Expected behavior No blocking calls reported by BlockHound ### Actual behavior The exception below appears when BlockHound is installed ``` Caused by: reactor.blockhound.BlockingOperationError: Blocking call! java.io.FileInputStream#readBytes at java.base/java.io.FileInputStream.readBytes(FileInputStream...
[ "common/src/main/java/io/netty/util/internal/Hidden.java", "transport-blockhound-tests/pom.xml" ]
[ "common/src/main/java/io/netty/util/internal/Hidden.java", "transport-blockhound-tests/pom.xml" ]
[ "transport-blockhound-tests/src/test/java/io/netty/util/internal/NettyBlockHoundIntegrationTest.java", "transport-blockhound-tests/src/test/resources/io/netty/util/internal/localhost_server.key", "transport-blockhound-tests/src/test/resources/io/netty/util/internal/localhost_server.pem", "transport-blockhound...
diff --git a/common/src/main/java/io/netty/util/internal/Hidden.java b/common/src/main/java/io/netty/util/internal/Hidden.java index 9c1d46cb380..7fd6d083967 100644 --- a/common/src/main/java/io/netty/util/internal/Hidden.java +++ b/common/src/main/java/io/netty/util/internal/Hidden.java @@ -87,6 +87,10 @@ public void ...
diff --git a/transport-blockhound-tests/src/test/java/io/netty/util/internal/NettyBlockHoundIntegrationTest.java b/transport-blockhound-tests/src/test/java/io/netty/util/internal/NettyBlockHoundIntegrationTest.java index b34b6b2f856..58e9284370c 100644 --- a/transport-blockhound-tests/src/test/java/io/netty/util/intern...
train
test
2020-07-01T10:24:41
2020-06-30T18:49:31Z
violetagg
val
netty/netty/10051_10428
netty/netty
netty/netty/10051
netty/netty/10428
[ "keyword_pr_to_issue" ]
28e1fbd366602d8f4b50921afb2c9d5e41b94a2d
0601389766e2feec82c1d6d9e1834a3930c82caa
[ "please ensure you use the latest netty release and re-open if you still see issues. ", "Encountered the same error, also trying to use `grpc-netty-shaded`.", "As a work-around: `-Dio.netty.noUnsafe=true` added at run time (that is, if your built application is called `app`, it is `./app -Dio.netty.noUnsafe=tru...
[ "@rpuch can we merge this directly to `PlatformDependent0` ? Seems overkill to add this class just for exposing one method etc ", "Use `SystemPropertyUtils.`", "I've moved the code to `PlatformDependent0` and removed `GraalDetector` class. Please let me know if it is ok now.", "Done" ]
2020-07-26T15:04:12Z
[]
Failure to run a service that uses a Netty library having built it with Graal native-image
### Expected behavior Ability to build and run a service using Netty with GraalVM [native-image](https://www.graalvm.org/docs/reference-manual/native-image/). ### Actual behavior It seems like Netty already has some support for GraalVM, but there still some issues. I can't find any reference to this error below, s...
[ "common/src/main/java/io/netty/util/internal/PlatformDependent0.java" ]
[ "common/src/main/java/io/netty/util/internal/PlatformDependent0.java" ]
[]
diff --git a/common/src/main/java/io/netty/util/internal/PlatformDependent0.java b/common/src/main/java/io/netty/util/internal/PlatformDependent0.java index 44976f18cb8..d95aaa8cdb8 100644 --- a/common/src/main/java/io/netty/util/internal/PlatformDependent0.java +++ b/common/src/main/java/io/netty/util/internal/Platfor...
null
train
test
2020-07-17T07:12:11
2020-02-21T11:33:21Z
CremboC
val
netty/netty/10434_10457
netty/netty
netty/netty/10434
netty/netty/10457
[ "keyword_pr_to_issue" ]
5aea78950f6ee0b02169c9fec15901e8bc0c3888
54bfd21e525f5d197bbaff583a832ec0f3cb8735
[ "I don't think netty was ever intended to properly recover from OutOfMemoryError...it would be a nice addition but hard to recover from errors in every random place.", "> I don't think netty was ever intended to properly recover from OutOfMemoryError...it would be a nice addition but hard to recover from errors i...
[]
2020-08-07T06:58:16Z
[]
OutOfDirectMemoryError causes CPU 100% and fd is full
### Expected behavior Release connection ### Actual behavior Always occupy the connection ### Steps to reproduce see [# 10424](https://github.com/netty/netty/issues/10424) OOM Exception , OOM in netty 4.1.51.Final Fix，but OOM problem caused this problem. Should need to be fixed, because the next OOM will ap...
[ "transport-native-epoll/src/main/java/io/netty/channel/epoll/AbstractEpollStreamChannel.java", "transport-native-kqueue/src/main/java/io/netty/channel/kqueue/AbstractKQueueStreamChannel.java", "transport/src/main/java/io/netty/channel/nio/AbstractNioByteChannel.java", "transport/src/main/java/io/netty/channel...
[ "transport-native-epoll/src/main/java/io/netty/channel/epoll/AbstractEpollStreamChannel.java", "transport-native-kqueue/src/main/java/io/netty/channel/kqueue/AbstractKQueueStreamChannel.java", "transport/src/main/java/io/netty/channel/nio/AbstractNioByteChannel.java", "transport/src/main/java/io/netty/channel...
[]
diff --git a/transport-native-epoll/src/main/java/io/netty/channel/epoll/AbstractEpollStreamChannel.java b/transport-native-epoll/src/main/java/io/netty/channel/epoll/AbstractEpollStreamChannel.java index 95e31b380f7..8a5b79d4938 100644 --- a/transport-native-epoll/src/main/java/io/netty/channel/epoll/AbstractEpollStre...
null
train
test
2020-08-06T13:54:46
2020-07-30T06:37:01Z
wuxiansen
val
netty/netty/10416_10473
netty/netty
netty/netty/10416
netty/netty/10473
[ "keyword_pr_to_issue" ]
f58223982ce8d9ed056c3d127972222966d0ebd1
61b0fa97d7e5fee763e331b536345844640c092e
[ "@ejona86 can you have a look ?", "I'll send out a PR.\r\n\r\nThe `verifyStreamId()` check for `streamDependency` should be a `verifyStreamOrConnectionId()`:\r\nhttps://github.com/netty/netty/blob/f58223982ce8d9ed056c3d127972222966d0ebd1/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2FrameWrit...
[]
2020-08-11T15:32:36Z
[]
Http2: writing valid PRIORITY frame fails with misleading error message
### Expected behavior * Writing valid PRIORITY frame with `streamDependency=0` succeeds * PRIORITY frame validation message contains actual cause of error ### Actual behavior Writing PRIORITY frame with `streamDependency=0` ``` http2Handler.encoder() .writePriority(ctx, streamId, /*dependency*/ 0, weight...
[ "codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2FrameWriter.java" ]
[ "codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2FrameWriter.java" ]
[ "codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2FrameWriterTest.java" ]
diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2FrameWriter.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2FrameWriter.java index 71a6653437c..00a4fe42255 100644 --- a/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2FrameWriter.java +++ b/cod...
diff --git a/codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2FrameWriterTest.java b/codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2FrameWriterTest.java index 6d53c4087ea..7edb1eed516 100644 --- a/codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2FrameWriterTest.ja...
train
test
2020-08-11T14:00:08
2020-07-17T09:00:11Z
mostroverkhov
val
netty/netty/10485_10488
netty/netty
netty/netty/10485
netty/netty/10488
[ "keyword_pr_to_issue", "connected" ]
514d349e1fa5a057e815a5f3ac6a7e3f3aa19784
6150a0e3c5af100e35e5fda3a1d3e3b647bce6a4
[ "It's not clear to me why you want to change the log level, and if you want to change it to TRACE or INFO, or some other level? Log levels are normally hard-coded on the usage site, and the current code follows that convention.\r\n\r\nThis setting is about whether or not logging is enabled. Detail configuration of ...
[ "Should we use a `static` logger and so use `InternalLoggerFactory.getInstance(LoggingDnsQueryLifeCycleObserverFactory.class)` ?", "final ", "2020", "private ?", "![img](http://pa1.narvii.com/6187/d349302822f47c8ebb904fdcf971cfcaaefdb0c2_hq.gif)", "May be add `requireNonNull(classContext)`", "May be add...
2020-08-19T11:21:37Z
[]
Ability to change the logger and level used by DnsNameResolverBuilder#traceEnabled
### Expected behavior Ability to change the logger and level used by `DnsNameResolverBuilder#traceEnabled` ### Actual behavior When `DnsNameResolverBuilder#traceEnabled` is enabled, it uses always the logger and level below https://github.com/netty/netty/blob/46cb4015ff25ff2dd3d0dede5c3185ac498e56b0/resolver-dns/...
[ "resolver-dns/pom.xml", "resolver-dns/src/main/java/io/netty/resolver/dns/DnsNameResolver.java", "resolver-dns/src/main/java/io/netty/resolver/dns/DnsNameResolverBuilder.java", "resolver-dns/src/main/java/io/netty/resolver/dns/TraceDnsQueryLifecycleObserver.java", "resolver-dns/src/main/java/io/netty/resolv...
[ "resolver-dns/pom.xml", "resolver-dns/src/main/java/io/netty/resolver/dns/DnsNameResolver.java", "resolver-dns/src/main/java/io/netty/resolver/dns/DnsNameResolverBuilder.java", "resolver-dns/src/main/java/io/netty/resolver/dns/LoggingDnsQueryLifeCycleObserverFactory.java", "resolver-dns/src/main/java/io/net...
[ "resolver-dns/src/test/java/io/netty/resolver/dns/DnsNameResolverTest.java" ]
diff --git a/resolver-dns/pom.xml b/resolver-dns/pom.xml index 8a918c4b97b..18cb12778ae 100644 --- a/resolver-dns/pom.xml +++ b/resolver-dns/pom.xml @@ -63,6 +63,11 @@ <artifactId>netty-codec-dns</artifactId> <version>${project.version}</version> </dependency> + <dependency> + <groupId>${proj...
diff --git a/resolver-dns/src/test/java/io/netty/resolver/dns/DnsNameResolverTest.java b/resolver-dns/src/test/java/io/netty/resolver/dns/DnsNameResolverTest.java index f15df51e74f..3154f1808f0 100644 --- a/resolver-dns/src/test/java/io/netty/resolver/dns/DnsNameResolverTest.java +++ b/resolver-dns/src/test/java/io/net...
val
test
2020-08-18T19:01:09
2020-08-18T12:21:09Z
violetagg
val
netty/netty/10485_10490
netty/netty
netty/netty/10485
netty/netty/10490
[ "keyword_pr_to_issue" ]
32178fac7f0d46d9ed7059eeec4708ed3d70c6eb
0bbe4ce9fd2c531a777bdfa3e0d8bfcd1e93768a
[ "It's not clear to me why you want to change the log level, and if you want to change it to TRACE or INFO, or some other level? Log levels are normally hard-coded on the usage site, and the current code follows that convention.\r\n\r\nThis setting is about whether or not logging is enabled. Detail configuration of ...
[ "Is there any particular concern to use `checkNotNull ` instead of `requireNonNull`. The latter is used in the version for Netty 5.", "Because it not depends on java8!", "ops ... true ", "Netty 4.1 needs to support Java 6 at runtime where `requireNonNull` is not available." ]
2020-08-19T13:37:34Z
[]
Ability to change the logger and level used by DnsNameResolverBuilder#traceEnabled
### Expected behavior Ability to change the logger and level used by `DnsNameResolverBuilder#traceEnabled` ### Actual behavior When `DnsNameResolverBuilder#traceEnabled` is enabled, it uses always the logger and level below https://github.com/netty/netty/blob/46cb4015ff25ff2dd3d0dede5c3185ac498e56b0/resolver-dns/...
[ "resolver-dns/pom.xml", "resolver-dns/src/main/java/io/netty/resolver/dns/DnsNameResolver.java", "resolver-dns/src/main/java/io/netty/resolver/dns/DnsNameResolverBuilder.java", "resolver-dns/src/main/java/io/netty/resolver/dns/TraceDnsQueryLifecycleObserver.java", "resolver-dns/src/main/java/io/netty/resolv...
[ "resolver-dns/pom.xml", "resolver-dns/src/main/java/io/netty/resolver/dns/DnsNameResolver.java", "resolver-dns/src/main/java/io/netty/resolver/dns/DnsNameResolverBuilder.java", "resolver-dns/src/main/java/io/netty/resolver/dns/LoggingDnsQueryLifeCycleObserverFactory.java", "resolver-dns/src/main/java/io/net...
[]
diff --git a/resolver-dns/pom.xml b/resolver-dns/pom.xml index 0925c9f47de..84e1733a79b 100644 --- a/resolver-dns/pom.xml +++ b/resolver-dns/pom.xml @@ -63,6 +63,11 @@ <artifactId>netty-codec-dns</artifactId> <version>${project.version}</version> </dependency> + <dependency> + <groupId>${proj...
null
test
test
2020-08-18T19:00:08
2020-08-18T12:21:09Z
violetagg
val
netty/netty/10582_10583
netty/netty
netty/netty/10582
netty/netty/10583
[ "keyword_pr_to_issue" ]
79a7c157a3e122872321844b73c4881e412dba77
d01471917b94d15fbe8b3b2e0f0ed8f24ee2954a
[ "@Doyuni please open a PR with the fix and a testcase- ", "> @Doyuni please open a PR with the fix and a testcase-\r\n\r\nOkay I got it." ]
[ "`req.uri()` could be moved to a variable.", "All this should be done only in case of `serverConfig.checkStartsWith()`. In all other cases, we don't need to perform those checks.", "Okay, thank you for reviewing.", "So..what should I do? That logic could be moved to new method?", "Probably own method makes ...
2020-09-16T10:36:44Z
[]
Add validation check about websocket path
### Expected behavior If I add WebSocketServerProtocolHandler like below, ```java private final String WEBSOCKET_PATH = "/websocket"; // ~~ final ChannelPipeline p = ch.pipeline(); p.addLast(new WebSocketServerProtocolHandler(WEBSOCKET_PATH, true)); ``` I expected : `/websocket/a` : return true `/we...
[ "codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketServerProtocolHandshakeHandler.java" ]
[ "codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketServerProtocolHandshakeHandler.java" ]
[ "codec-http/src/test/java/io/netty/handler/codec/http/websocketx/WebSocketServerProtocolHandlerTest.java" ]
diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketServerProtocolHandshakeHandler.java b/codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketServerProtocolHandshakeHandler.java index ec9b4ff1049..f3f53327563 100644 --- a/codec-http/src/main/java/io/netty/handler/c...
diff --git a/codec-http/src/test/java/io/netty/handler/codec/http/websocketx/WebSocketServerProtocolHandlerTest.java b/codec-http/src/test/java/io/netty/handler/codec/http/websocketx/WebSocketServerProtocolHandlerTest.java index 69cda51f0b4..1ca29b0a5e6 100644 --- a/codec-http/src/test/java/io/netty/handler/codec/http/...
train
test
2020-09-16T09:40:42
2020-09-16T09:56:02Z
Doyuni
val
netty/netty/10508_10623
netty/netty
netty/netty/10508
netty/netty/10623
[ "keyword_pr_to_issue" ]
8b2ed77042b5a3023974d7a6d2f22fc0d3edef34
1c230405fd4f7c445773b662beeccebc18f85f98
[ "My 2 cents:\r\nFirst change:\r\n- Before, it was a `copy` which limits the max, \r\n- now is a `buf.alloc.buffer(...).writeByte(buf)` => Pooled buffer using the original ByteBufAllocator from the `buf`\r\n\r\nSecond change, which is probably the one you point out:\r\n- Before (2 places): `Unpooled.buffer(64)` (Un...
[ "@fredericBregier can you explain why setting an upper limit improves things here ?", "@normanmaurer \r\nI don't have any real clue, but it seems it does. That's why I'm asking you to look at this why. \r\n\r\nThe change is huge on performances in PARANOID mode (using the example test given by the final user), ab...
2020-09-30T09:16:13Z
[]
HttpPostMultipartRequestDecoder performance regression
### Expected behavior #10226 improves performance. ### Actual behavior The decoder is now at least 100x slower than before iff it is offered a direct buffer. If the decoder is offered a direct buffer it now creates a bunch of 64b direct buffers during parsing, where before it always used heap buffers. Usin...
[ "codec-http/src/main/java/io/netty/handler/codec/http/multipart/HttpPostMultipartRequestDecoder.java", "codec-http/src/main/java/io/netty/handler/codec/http/multipart/HttpPostStandardRequestDecoder.java" ]
[ "codec-http/src/main/java/io/netty/handler/codec/http/multipart/HttpPostMultipartRequestDecoder.java", "codec-http/src/main/java/io/netty/handler/codec/http/multipart/HttpPostStandardRequestDecoder.java", "microbench/src/main/java/io/netty/handler/codec/http/multipart/HttpPostMultipartRequestDecoderBenchmark.ja...
[ "codec-http/src/test/java/io/netty/handler/codec/http/multipart/HttpPostRequestDecoderTest.java" ]
diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/multipart/HttpPostMultipartRequestDecoder.java b/codec-http/src/main/java/io/netty/handler/codec/http/multipart/HttpPostMultipartRequestDecoder.java index a366bd31606..b125dfae0e7 100644 --- a/codec-http/src/main/java/io/netty/handler/codec/http/multipar...
diff --git a/codec-http/src/test/java/io/netty/handler/codec/http/multipart/HttpPostRequestDecoderTest.java b/codec-http/src/test/java/io/netty/handler/codec/http/multipart/HttpPostRequestDecoderTest.java index ba01e4d240b..45b8461ce72 100644 --- a/codec-http/src/test/java/io/netty/handler/codec/http/multipart/HttpPost...
val
test
2020-11-16T09:03:37
2020-08-27T08:53:35Z
zentol
val
netty/netty/10614_10659
netty/netty
netty/netty/10614
netty/netty/10659
[ "keyword_pr_to_issue" ]
9d457c3f0f883312c155a495b566f6c576d89a52
fd8c1874b4e24a18c562c7013efabcb155395459
[ "hi~ I not sure UnorderedThreadPoolEventExecutor#scheduleAtFixedRate should work as you expected ,but as you expected ,you can change the code as I already commit. " ]
[ "After this unblocks we should cancel the scheduled task via `future.cancel()`. Also we should shutdown the `executor`.", "nit: shutdownGracefully() ?", "Alright, done." ]
2020-10-08T14:11:08Z
[]
UnorderedThreadPoolEventExecutor#scheduleAtFixedRate not working as expected
### Expected behavior The runnable passed to scheduleAtFixedRate() should run multiple times, not just once. ### Actual behavior using UnorderedThreadPoolEventExecutor the runnable is executed just once, using directly the ScheduledThreadPoolExecutor or DefaultEventExecutorGroup the task is executed at fixed rate ...
[ "common/src/main/java/io/netty/util/concurrent/UnorderedThreadPoolEventExecutor.java" ]
[ "common/src/main/java/io/netty/util/concurrent/UnorderedThreadPoolEventExecutor.java" ]
[ "common/src/test/java/io/netty/util/concurrent/UnorderedThreadPoolEventExecutorTest.java", "transport-native-epoll/src/test/java/io/netty/channel/epoll/EpollSocketChannelConfigTest.java" ]
diff --git a/common/src/main/java/io/netty/util/concurrent/UnorderedThreadPoolEventExecutor.java b/common/src/main/java/io/netty/util/concurrent/UnorderedThreadPoolEventExecutor.java index 277c90322ad..dbf3f25fda6 100644 --- a/common/src/main/java/io/netty/util/concurrent/UnorderedThreadPoolEventExecutor.java +++ b/com...
diff --git a/common/src/test/java/io/netty/util/concurrent/UnorderedThreadPoolEventExecutorTest.java b/common/src/test/java/io/netty/util/concurrent/UnorderedThreadPoolEventExecutorTest.java index d96db3fcb07..2f4e02dc0ba 100644 --- a/common/src/test/java/io/netty/util/concurrent/UnorderedThreadPoolEventExecutorTest.ja...
train
test
2020-10-12T18:25:58
2020-09-26T12:18:54Z
matteobertozzi
val
netty/netty/10649_10683
netty/netty
netty/netty/10649
netty/netty/10683
[ "keyword_pr_to_issue" ]
1ca7d5db8167f904395d879b8851eb35d6f596f3
065c39611e0f65a3c6d4650638b395258e1fd8f2
[ "SHA-512 is an overkill and not useful for this purpose. SHA-256 or SHA-384 is the way to go.", "@trustin @normanmaurer What do you think?", "As far as I understand how `FingerprintTrustManagerFactory` is meant to be used, I think it's better to deprecate it, and add a new implementation that uses a stronger ha...
[ "Add method to add a List of `fingerprints`.", "Also add `@deprecated` javadoc tag", "also add `@deprecated` javadoc tag ", "should we call `MessageDigest.getInstance(algorithm)` once in the constructor now to ensure it will not fail later on ? ", "see above... I think it is very unlikely that the \"constru...
2020-10-14T08:26:24Z
[]
Better hash algorithm in FingerprintTrustManagerFactory
`FingerprintTrustManagerFactory` checks if a certificate is trusted by comparing its SHA-1 hash to a list of pre-configured ones: https://github.com/netty/netty/blob/0cde4d9cb4d19ddc0ecafc5be7c5f7c781a1f6e9/handler/src/main/java/io/netty/handler/ssl/util/FingerprintTrustManagerFactory.java#L85 Unfortunately, nowa...
[ "handler/src/main/java/io/netty/handler/ssl/util/FingerprintTrustManagerFactory.java" ]
[ "handler/src/main/java/io/netty/handler/ssl/util/FingerprintTrustManagerFactory.java", "handler/src/main/java/io/netty/handler/ssl/util/FingerprintTrustManagerFactoryBuilder.java" ]
[ "handler/src/test/java/io/netty/handler/ssl/Java8SslTestUtils.java", "handler/src/test/java/io/netty/handler/ssl/SslContextTrustManagerTest.java", "handler/src/test/java/io/netty/handler/ssl/util/FingerprintTrustManagerFactoryTest.java" ]
diff --git a/handler/src/main/java/io/netty/handler/ssl/util/FingerprintTrustManagerFactory.java b/handler/src/main/java/io/netty/handler/ssl/util/FingerprintTrustManagerFactory.java index 8a023d476e4..ff6772a695a 100644 --- a/handler/src/main/java/io/netty/handler/ssl/util/FingerprintTrustManagerFactory.java +++ b/han...
diff --git a/handler/src/test/java/io/netty/handler/ssl/Java8SslTestUtils.java b/handler/src/test/java/io/netty/handler/ssl/Java8SslTestUtils.java index 50fb935d9dc..dc3a2774bfe 100644 --- a/handler/src/test/java/io/netty/handler/ssl/Java8SslTestUtils.java +++ b/handler/src/test/java/io/netty/handler/ssl/Java8SslTestUt...
val
test
2020-10-17T09:49:44
2020-10-07T09:54:31Z
artem-smotrakov
val
netty/netty/10731_10737
netty/netty
netty/netty/10731
netty/netty/10737
[ "keyword_pr_to_issue" ]
9da336f2fc4d5e7aa761191c3eb5edff334c03c7
9a02832fdb10afbc09f144a462d604176fb11049
[ "@normanmaurer While having fun implementing this I've found something odd by adding this test to `AbstractByteBufTest`:\r\n```java\r\n @Test\r\n public void testEndiannessIndexOf() {\r\n buffer.clear();\r\n final int v = 1\r\n | (2 << 8)\r\n | (3 << 16)...
[ "you can do this as long pattern = (byteToFind & 0xFFL) * 0x101010101010101L", "Since you're doing a little endian check elsewhere, I would consider making little and big endian variants of this method, just because it makes it harder to mix and match", "This is 2KB, but if you change this to the multiplication...
2020-10-28T08:09:27Z
[ "improvement", "discussion" ]
Implement SWAR indexOf byte search
Currently Netty uses an expensive (GC-wise too) `ByteBufUtil::indexOf` implementation based on `ByteProcessor.IndexOfProcessor` to save bound-checks to happen: this could be changed into what @richardstartin has implemented on https://richardstartin.github.io/posts/finding-bytes. Same could be applied to `ByteBuf::...
[ "buffer/src/main/java/io/netty/buffer/AbstractByteBuf.java", "buffer/src/main/java/io/netty/buffer/ByteBufUtil.java" ]
[ "buffer/src/main/java/io/netty/buffer/AbstractByteBuf.java", "buffer/src/main/java/io/netty/buffer/ByteBufUtil.java", "microbench/src/main/java/io/netty/microbench/buffer/ByteBufIndexOfBenchmark.java" ]
[ "buffer/src/test/java/io/netty/buffer/AbstractByteBufTest.java" ]
diff --git a/buffer/src/main/java/io/netty/buffer/AbstractByteBuf.java b/buffer/src/main/java/io/netty/buffer/AbstractByteBuf.java index e7b514b7dd7..c13efdd0046 100644 --- a/buffer/src/main/java/io/netty/buffer/AbstractByteBuf.java +++ b/buffer/src/main/java/io/netty/buffer/AbstractByteBuf.java @@ -1251,43 +1251,9 @@ ...
diff --git a/buffer/src/test/java/io/netty/buffer/AbstractByteBufTest.java b/buffer/src/test/java/io/netty/buffer/AbstractByteBufTest.java index e68bac828c3..0c1bc7fa3c3 100644 --- a/buffer/src/test/java/io/netty/buffer/AbstractByteBufTest.java +++ b/buffer/src/test/java/io/netty/buffer/AbstractByteBufTest.java @@ -212...
train
test
2020-12-23T09:32:04
2020-10-26T05:34:23Z
franz1981
val
netty/netty/10748_10765
netty/netty
netty/netty/10748
netty/netty/10765
[ "keyword_pr_to_issue" ]
9da336f2fc4d5e7aa761191c3eb5edff334c03c7
08681a817d66e5a1a443ccb2b2b0e3d4a18d474b
[ "I think we need to add a custom frame to handle Push Promise Read.\r\n\r\n@normanmaurer WDYT?", "Maybe something like this.\r\n\r\n```java\r\npublic class PushPromiseRead implements Http2StreamFrame {\r\n\r\n private Http2FrameStream stream;\r\n private final int promisedStreamId;\r\n private final Http...
[ "Why `2`?", "It looks like we return the newly created stream id in two places: as the return value and as the newly populated `http2FrameStream.id` field. What do you think about making the return value of this method `void` and using the latter when it's necessary? To me, that avoids the ambiguity up higher as ...
2020-11-02T18:58:17Z
[]
Http2FrameCodec#onPushPromiseRead Support
### Expected behavior `Http2FrameCodec#onPushPromiseRead` should be supported. ### Actual behavior `Http2FrameCodec#onPushPromiseRead` is not yet supported. We cannot handle Push Promise Read. The stream is completely ignored. https://github.com/netty/netty/blob/e9b28e76a366dadaf6da4375c503f670ec3e3ae4/codec-ht...
[ "codec-http2/src/main/java/io/netty/handler/codec/http2/Http2FrameCodec.java" ]
[ "codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2PriorityFrame.java", "codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2PushPromiseFrame.java", "codec-http2/src/main/java/io/netty/handler/codec/http2/Http2FrameCodec.java", "codec-http2/src/main/java/io/netty/handler/codec/...
[ "codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2PushPromiseFrameTest.java" ]
diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2PriorityFrame.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2PriorityFrame.java new file mode 100644 index 00000000000..e131936e242 --- /dev/null +++ b/codec-http2/src/main/java/io/netty/handler/codec/http2/Defaul...
diff --git a/codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2PushPromiseFrameTest.java b/codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2PushPromiseFrameTest.java new file mode 100644 index 00000000000..7bc598d5570 --- /dev/null +++ b/codec-http2/src/test/java/io/netty/handler/code...
train
test
2020-12-23T09:32:04
2020-10-29T14:09:34Z
hyperxpro
val
netty/netty/10772_10773
netty/netty
netty/netty/10772
netty/netty/10773
[ "keyword_issue_to_pr", "keyword_pr_to_issue" ]
c6e2934357ca7284c474f9da2823b54936d3addc
23864d25b993e9f75cc910d6318d831a01730a83
[ "Thanks for reporting. #10773 PR will fix this.", "@hyandell doh! Thanks for catching this." ]
[]
2020-11-04T07:17:15Z
[]
Incorrect license id in NOTICE.txt
The NOTICE.txt file ends with: ``` This product contains the dnsinfo.h header file, that provides a way to retrieve the system DNS configuration on MacOS. This private header is also used by Apple's open source mDNSResponder (https://opensource.apple.com/tarballs/mDNSResponder/). * LICENSE: * license/LI...
[ "NOTICE.txt" ]
[ "NOTICE.txt" ]
[]
diff --git a/NOTICE.txt b/NOTICE.txt index b702bb72403..cd84a8afe20 100644 --- a/NOTICE.txt +++ b/NOTICE.txt @@ -243,6 +243,6 @@ This private header is also used by Apple's open source mDNSResponder (https://opensource.apple.com/tarballs/mDNSResponder/). * LICENSE: - * license/LICENSE.dnsinfo.txt (Apache Licen...
null
train
test
2020-11-03T21:12:29
2020-11-03T23:09:45Z
hyandell
val
netty/netty/10670_10775
netty/netty
netty/netty/10670
netty/netty/10775
[ "keyword_pr_to_issue" ]
b63e2dfb1baa7dbe3da381458f6d9ab004777090
027a68604273032f4cb6b181b40c47ced2108239
[ "@ejona86 this is the best I can think of as well... I guess this is \"good enough\" ? ", "I think it will be good enough. I'll work on a fix after I'm back in the office on the 26th.", "ok cool... ping me once I should review some code ", "I don't see a good way to update `incrementExpectedStreamId()` from `...
[]
2020-11-04T17:00:40Z
[]
http2: wrong Last-Stream-Id for connection error during header parsing
### Expected behavior A channel error occurring during HEADERS decoding triggers a GOAWAY that includes the stream id including the stream for the header being processed. ### Actual behavior Streams are allocated within `DefaultHttp2ConnectionDecoder.onHeadersRead()`. If a channel error occurs during header pa...
[ "codec-http2/src/main/java/io/netty/handler/codec/http2/Http2ConnectionHandler.java" ]
[ "codec-http2/src/main/java/io/netty/handler/codec/http2/Http2ConnectionHandler.java" ]
[ "codec-http2/src/test/java/io/netty/handler/codec/http2/Http2ConnectionHandlerTest.java", "codec-http2/src/test/java/io/netty/handler/codec/http2/Http2ControlFrameLimitEncoderTest.java" ]
diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2ConnectionHandler.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2ConnectionHandler.java index 4b7ad517644..cbb923f169d 100644 --- a/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2ConnectionHandler.java +++ b/codec-...
diff --git a/codec-http2/src/test/java/io/netty/handler/codec/http2/Http2ConnectionHandlerTest.java b/codec-http2/src/test/java/io/netty/handler/codec/http2/Http2ConnectionHandlerTest.java index 4f5af5411e4..da9b1221b3b 100644 --- a/codec-http2/src/test/java/io/netty/handler/codec/http2/Http2ConnectionHandlerTest.java ...
train
test
2020-11-04T14:01:08
2020-10-09T19:00:52Z
ejona86
val
netty/netty/10797_10799
netty/netty
netty/netty/10797
netty/netty/10799
[ "keyword_issue_to_pr", "keyword_pr_to_issue" ]
944a0205862e32f1020647bbf4ef4eca5587446e
80c28a3c332ad3c557f5853987b3f3d58c80de69
[ "Hi @ArjanSchouten.\r\n\r\nI tried to build your project and reproduced the problem. (Stangely enough, the build downloads GraalVM 20.2.0 on each run, aren't you aware of a way to make it cache the downloaded file? The download is pretty slow).\r\n\r\nTo be honest, I'm not an expert in GraalVM (nor its Native Build...
[]
2020-11-15T13:33:28Z
[]
Netty on GraalVM with substitutions not fully working as expected
### Expected behavior The `NetUtilSubstitutions` implement a set InetAddress, Inet4Address and Inet6Address dummy implementation. ### Actual behavior See logging with exceptions below. I expect no exceptions related to netty. ### Steps to reproduce Have a running docker engine since it uses the buildpacks from...
[ "common/src/main/java/io/netty/util/NetUtilSubstitutions.java", "pom.xml" ]
[ "common/src/main/java/io/netty/util/NetUtilSubstitutions.java", "pom.xml" ]
[ "testsuite-native-image-client-runtime-init/pom.xml", "testsuite-native-image-client-runtime-init/src/main/java/io/netty/testsuite/svm/client/NativeClientWithNettyInitAtRuntime.java", "testsuite-native-image-client-runtime-init/src/main/java/io/netty/testsuite/svm/client/package-info.java", "testsuite-native-...
diff --git a/common/src/main/java/io/netty/util/NetUtilSubstitutions.java b/common/src/main/java/io/netty/util/NetUtilSubstitutions.java index 9d9740392ca..7894037e4e9 100644 --- a/common/src/main/java/io/netty/util/NetUtilSubstitutions.java +++ b/common/src/main/java/io/netty/util/NetUtilSubstitutions.java @@ -45,6 +4...
diff --git a/testsuite-native-image-client-runtime-init/pom.xml b/testsuite-native-image-client-runtime-init/pom.xml new file mode 100644 index 00000000000..eb22b7aa33d --- /dev/null +++ b/testsuite-native-image-client-runtime-init/pom.xml @@ -0,0 +1,100 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- + ~ Copyright 2...
train
test
2020-11-11T06:47:51
2020-11-13T22:48:56Z
ArjanSchouten
val
netty/netty/10777_10807
netty/netty
netty/netty/10777
netty/netty/10807
[ "keyword_pr_to_issue" ]
8b2ed77042b5a3023974d7a6d2f22fc0d3edef34
3354c7b0bf977cabfd0097f80973a9175788a8a6
[ "Enable `DEBUG` log level.", "if you mean:\r\n\r\np.addLast(new LoggingHandler(LogLevel.DEBUG));\r\n\r\ndo not help. No information is printed. **(using non-serialized object - that dont work)**\r\n\r\n--------------------------------------------------------------------------------------------\r\n----------------...
[ "@chrisvest this doesn't work as this will block the eventloop. Use a `ChannelFutureListener` ", "please revert this change ^^" ]
2020-11-18T13:00:07Z
[]
suggestion: netty/example/objectecho inform about missing "implements Serializable" on client side
Hello, as new user i wanted to try Objectecho "Example", and was confused when i sent **Serializable Object** that were **containing** an **"non-serializable" Object** as some depth field(that i didnt notice earlier), it was not sent at all, and i received no information at all. It took me time to debug and notice t...
[ "example/src/main/java/io/netty/example/objectecho/ObjectEchoClientHandler.java" ]
[ "example/src/main/java/io/netty/example/objectecho/ObjectEchoClientHandler.java" ]
[]
diff --git a/example/src/main/java/io/netty/example/objectecho/ObjectEchoClientHandler.java b/example/src/main/java/io/netty/example/objectecho/ObjectEchoClientHandler.java index 07f2f6bcf01..314747180fb 100644 --- a/example/src/main/java/io/netty/example/objectecho/ObjectEchoClientHandler.java +++ b/example/src/main/j...
null
test
test
2020-11-16T09:03:37
2020-11-06T06:53:27Z
oxplay2
val
netty/netty/10816_10819
netty/netty
netty/netty/10816
netty/netty/10819
[ "keyword_pr_to_issue" ]
02cd85181aef2502c2f90b978453d210d08781ef
b27f0fccced002e700d8f3bb7a88c1349d83d8ee
[ "@normanmaurer I wrapped the `addListener` call in a try-catch to extract the stacktrace:\r\n\r\n```\r\n2020-11-30 12:54:06,441 ERROR [epollEventLoopGroup-3-5] io.netty.util.internal.logging.AbstractInternalLogger | Unexpected exception: \r\njava.lang.IllegalStateException: void future\r\n\tat io.netty.channel.Void...
[ "Based on the other tests I wanted to do something like this:\r\n```java\r\n verify(voidPromise, never()).addListener(any(GenericFutureListener.class));\r\n verify(ctx.channel(), times(1)).newPromise();\r\n verify(promise, times(1)).addListener(any(GenericFutureListener.class));\r\n```\r\nI'm n...
2020-11-24T11:03:07Z
[]
Cannot write/flush HTTP/2 with voidPromise
### Expected behavior Can `write` / `writeAndFlush` frames that may close the stream from a HTTP/2 context ### Actual behavior `Http2ConnectionHandler#closeStream` tries to `addListener` to the future even if it's void. If void, that will fail. ### Steps to reproduce `writeAndFlush` a Http2DataFrame to the con...
[ "codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionEncoder.java" ]
[ "codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionEncoder.java" ]
[ "codec-http2/src/test/java/io/netty/handler/codec/http2/Http2ConnectionHandlerTest.java" ]
diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionEncoder.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionEncoder.java index 97a7239fb86..d8611c71b8e 100644 --- a/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionEnco...
diff --git a/codec-http2/src/test/java/io/netty/handler/codec/http2/Http2ConnectionHandlerTest.java b/codec-http2/src/test/java/io/netty/handler/codec/http2/Http2ConnectionHandlerTest.java index da9b1221b3b..0eb34f47200 100644 --- a/codec-http2/src/test/java/io/netty/handler/codec/http2/Http2ConnectionHandlerTest.java ...
train
test
2020-11-23T19:20:18
2020-11-24T10:00:23Z
valerauko
val
netty/netty/10837_10844
netty/netty
netty/netty/10837
netty/netty/10844
[ "keyword_pr_to_issue" ]
44f85bba5f47df885dbbe5243d008220bfbab5ca
8a7c580bf679628617fde26c3913fa62f0895e18
[ "We tell block hound to permit blocking calls in `SSLEngine.wrap`: https://github.com/netty/netty/blob/4.1/common/src/main/java/io/netty/util/internal/Hidden.java#L108-L112\r\n\r\nDoes block hound also bark when you use a different `SSLEngine`, like `ReferenceCountedOpenSslEngine`?", "@chrisvest Isn't it related ...
[]
2020-12-06T11:59:35Z
[]
Blocking call found with Spring Webflux and r2dbc-mysql driver.
### Overview Hi, So I am using Spring Webflux 5.3.1(which internally uses Netty) and I am integrating it with a MySql R2DBC driver(r2dbc-mysql) to make a reactive application. It works fine and everything looks good. But when I tried to use BlockHound(a tool created by the Spring team to detect blocking calls), t...
[ "common/src/main/java/io/netty/util/internal/Hidden.java" ]
[ "common/src/main/java/io/netty/util/internal/Hidden.java" ]
[ "transport-blockhound-tests/src/test/java/io/netty/util/internal/NettyBlockHoundIntegrationTest.java" ]
diff --git a/common/src/main/java/io/netty/util/internal/Hidden.java b/common/src/main/java/io/netty/util/internal/Hidden.java index 5ce04918656..ac97323573e 100644 --- a/common/src/main/java/io/netty/util/internal/Hidden.java +++ b/common/src/main/java/io/netty/util/internal/Hidden.java @@ -111,6 +111,10 @@ public voi...
diff --git a/transport-blockhound-tests/src/test/java/io/netty/util/internal/NettyBlockHoundIntegrationTest.java b/transport-blockhound-tests/src/test/java/io/netty/util/internal/NettyBlockHoundIntegrationTest.java index 68858b127dd..ade2def4703 100644 --- a/transport-blockhound-tests/src/test/java/io/netty/util/intern...
test
test
2020-12-05T07:01:03
2020-12-03T14:49:02Z
theakshaypilania
val
netty/netty/10838_10846
netty/netty
netty/netty/10838
netty/netty/10846
[ "keyword_pr_to_issue" ]
abd5a7d922dadc24bcfc6f3f34802d7de115445d
05093de0d6fe5787447439836e2ca159e79c88bf
[ "Also for `CloseWebSocketFrame` constructors where you can provide directly `int` for the status code, I see that the status code is checked when reading the frame, but isn't it better to check it also when constructing `CloseWebSocketFrame`? (My Netty server was able to create and send such `CloseWebSocketFrame` ...
[]
2020-12-07T10:45:45Z
[]
Check for valid status codes should be done in CloseWebSocketFrame instead of WebSocketCloseStatus
According to the specification https://tools.ietf.org/html/rfc6455#section-7.4 ``` 1006 is a reserved value and MUST NOT be set as a status code in a Close control frame by an endpoint. It is designated for use in applications expecting a status code to indicate that the connection was closed abnormally, e.g., ...
[ "codec-http/src/main/java/io/netty/handler/codec/http/websocketx/CloseWebSocketFrame.java", "codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketCloseStatus.java" ]
[ "codec-http/src/main/java/io/netty/handler/codec/http/websocketx/CloseWebSocketFrame.java", "codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketCloseStatus.java" ]
[ "codec-http/src/test/java/io/netty/handler/codec/http/websocketx/CloseWebSocketFrameTest.java", "codec-http/src/test/java/io/netty/handler/codec/http/websocketx/WebSocketCloseStatusTest.java" ]
diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/websocketx/CloseWebSocketFrame.java b/codec-http/src/main/java/io/netty/handler/codec/http/websocketx/CloseWebSocketFrame.java index 7231bde8f4a..1703203902e 100644 --- a/codec-http/src/main/java/io/netty/handler/codec/http/websocketx/CloseWebSocketFrame...
diff --git a/codec-http/src/test/java/io/netty/handler/codec/http/websocketx/CloseWebSocketFrameTest.java b/codec-http/src/test/java/io/netty/handler/codec/http/websocketx/CloseWebSocketFrameTest.java new file mode 100644 index 00000000000..f1bcc3fc3d8 --- /dev/null +++ b/codec-http/src/test/java/io/netty/handler/codec...
train
test
2020-12-07T10:49:09
2020-12-03T17:15:08Z
violetagg
val
netty/netty/10851_10855
netty/netty
netty/netty/10851
netty/netty/10855
[ "keyword_pr_to_issue" ]
b4479353e2485aa2f0293bc748920560c0ddeaf2
c0674cff29ae017e9fd144b6728ac0521874e883
[ "Can you share the code to reproduce?", "Experiencing this as well\r\n\r\nIn this code:\r\n\r\n```\r\n private static int findDelimiter(ByteBuf undecodedChunk, String delimiter, int offset) {\r\n ....\r\n while (delimiterNotFound && newOffset + delimeterLength <= toRead) {\r\n```\r\n\r\n`newOffse...
[]
2020-12-09T20:16:13Z
[ "regression" ]
Netty Threads consume 100% of the CPU after update to the latest version
Hello, after the update: netty 4.1.54.Final -> 4.1.55.Final boring ssl 2.0.34.Final -> 2.0.35.Final During one of the test cases with file upload, we found netty epoll threads start consuming 100% of the CPU. Stack trace: ``` "epollEventLoopGroup-3-1" #20 prio=10 os_prio=0 cpu=597400.03ms elapsed=15396.13s ...
[ "codec-http/src/main/java/io/netty/handler/codec/http/multipart/HttpPostMultipartRequestDecoder.java" ]
[ "codec-http/src/main/java/io/netty/handler/codec/http/multipart/HttpPostMultipartRequestDecoder.java" ]
[ "codec-http/src/test/java/io/netty/handler/codec/http/multipart/HttpPostRequestDecoderTest.java" ]
diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/multipart/HttpPostMultipartRequestDecoder.java b/codec-http/src/main/java/io/netty/handler/codec/http/multipart/HttpPostMultipartRequestDecoder.java index b125dfae0e7..9e82ad7caf0 100644 --- a/codec-http/src/main/java/io/netty/handler/codec/http/multipar...
diff --git a/codec-http/src/test/java/io/netty/handler/codec/http/multipart/HttpPostRequestDecoderTest.java b/codec-http/src/test/java/io/netty/handler/codec/http/multipart/HttpPostRequestDecoderTest.java index 45b8461ce72..acbcf1219d3 100644 --- a/codec-http/src/test/java/io/netty/handler/codec/http/multipart/HttpPost...
train
test
2020-12-10T14:19:39
2020-12-09T14:42:38Z
doom369
val
netty/netty/10887_10893
netty/netty
netty/netty/10887
netty/netty/10893
[ "keyword_issue_to_pr" ]
4f6e62d50c434509a7c42e1080ad0c6d6795c63d
42145902a72da415c8505042285802c592ceb874
[ "@violetagg I wonder how we can archive this as we need to build on different platforms. Any idea ? ", "@normanmaurer I didn't have such issue till now, but is it possible to build first the artifacts and then to upload them all?\r\n\r\nOn the link below it is described how to deploy many files with different cla...
[]
2020-12-24T08:09:50Z
[]
Could not find netty-transport-native-epoll-4.1.57.Final-SNAPSHOT-linux-x86_64.jar
With the recent changes for Netty SNAPSHOTS deployment, the message below is thrown when one tries to build using Netty SNAPSHOTS ``` Could not find netty-transport-native-epoll-4.1.57.Final-SNAPSHOT-linux-x86_64.jar (io.netty:netty-transport-native-epoll:4.1.57.Final-SNAPSHOT:20201223.100457-23). Searched in the ...
[ ".github/workflows/ci-deploy.yml", "docker/docker-compose.centos-6.18.yaml", "docker/docker-compose.centos-7.yaml", "docker/docker-compose.yaml" ]
[ ".github/workflows/ci-deploy.yml", "docker/docker-compose.centos-6.18.yaml", "docker/docker-compose.centos-7.yaml", "docker/docker-compose.yaml" ]
[]
diff --git a/.github/workflows/ci-deploy.yml b/.github/workflows/ci-deploy.yml index 7208df32f5c..513dee25a2d 100644 --- a/.github/workflows/ci-deploy.yml +++ b/.github/workflows/ci-deploy.yml @@ -11,69 +11,75 @@ on: workflow_dispatch: jobs: - deploy-linux-x86_64: + stage-snapshot: runs-on: ubuntu-latest -...
null
test
test
2020-12-24T11:37:42
2020-12-23T13:22:52Z
violetagg
val
netty/netty/10929_10930
netty/netty
netty/netty/10929
netty/netty/10930
[ "keyword_pr_to_issue" ]
342f52e8130085648b676bfb86973310ebe6d03d
f54bf7aeb06c6a4cf9350482f7814c3fb9c4fd82
[]
[ "I think we need to keep the old as well as otherwise it will be a breaking change. ", "I think we need to keep the old method as well as otherwise this would be a breaking change", "I think we need to keep the old method as well as otherwise this would be a breaking change" ]
2021-01-13T15:56:04Z
[]
mqtt-codec: negative packet-ids
### Behavior It looks like it's not possible to create an mqtt message (with packetId) through the provided _builder classes_ in `io.netty.handler.codec.mqtt.MqttMessageBuilders` The reason why this is happening is because the internal representation of the packetId (in `PubAckBuilder`, `SubAckBuilder` and `UnsubAc...
[ "codec-mqtt/src/main/java/io/netty/handler/codec/mqtt/MqttMessageBuilders.java" ]
[ "codec-mqtt/src/main/java/io/netty/handler/codec/mqtt/MqttMessageBuilders.java" ]
[ "codec-mqtt/src/test/java/io/netty/handler/codec/mqtt/MqttMessageBuildersPacketIdTest.java" ]
diff --git a/codec-mqtt/src/main/java/io/netty/handler/codec/mqtt/MqttMessageBuilders.java b/codec-mqtt/src/main/java/io/netty/handler/codec/mqtt/MqttMessageBuilders.java index 8c854f0bf07..a2eea437740 100644 --- a/codec-mqtt/src/main/java/io/netty/handler/codec/mqtt/MqttMessageBuilders.java +++ b/codec-mqtt/src/main/j...
diff --git a/codec-mqtt/src/test/java/io/netty/handler/codec/mqtt/MqttMessageBuildersPacketIdTest.java b/codec-mqtt/src/test/java/io/netty/handler/codec/mqtt/MqttMessageBuildersPacketIdTest.java new file mode 100644 index 00000000000..c63e771f000 --- /dev/null +++ b/codec-mqtt/src/test/java/io/netty/handler/codec/mqtt/...
train
test
2021-01-15T16:47:49
2021-01-13T15:14:06Z
duke-bartholomew
val
netty/netty/10925_10935
netty/netty
netty/netty/10925
netty/netty/10935
[ "keyword_pr_to_issue" ]
a137ce204264e0b7411c5aa853e4459291e75b36
5b699b722c25a3c34656fc8bbb8e36bee27a5244
[ "@violetagg can you provide a PR ?", "@normanmaurer I was thinking for allowing blocking calls when loading `etcResolverFiles`, is that what you are thinking also?", "This sounds good " ]
[ "you need to also shutdown the executor ", "oops ... done" ]
2021-01-14T10:07:09Z
[]
Blocking call in UnixResolverDnsServerAddressStreamProvider.parse
### Expected behavior No blocking calls reported by BlockHound ### Actual behavior The exception below appears when BlockHound is installed ``` reactor.blockhound.BlockingOperationError: Blocking call! java.io.FileInputStream#readBytes at java.io.FileInputStream.readBytes(FileInputStream.java) ...
[ "common/src/main/java/io/netty/util/internal/Hidden.java", "transport-blockhound-tests/pom.xml" ]
[ "common/src/main/java/io/netty/util/internal/Hidden.java", "transport-blockhound-tests/pom.xml" ]
[ "transport-blockhound-tests/src/test/java/io/netty/util/internal/NettyBlockHoundIntegrationTest.java" ]
diff --git a/common/src/main/java/io/netty/util/internal/Hidden.java b/common/src/main/java/io/netty/util/internal/Hidden.java index ac97323573e..18a03c68ead 100644 --- a/common/src/main/java/io/netty/util/internal/Hidden.java +++ b/common/src/main/java/io/netty/util/internal/Hidden.java @@ -115,6 +115,10 @@ public voi...
diff --git a/transport-blockhound-tests/src/test/java/io/netty/util/internal/NettyBlockHoundIntegrationTest.java b/transport-blockhound-tests/src/test/java/io/netty/util/internal/NettyBlockHoundIntegrationTest.java index ade2def4703..2d5121a0781 100644 --- a/transport-blockhound-tests/src/test/java/io/netty/util/intern...
train
test
2021-01-13T11:28:54
2021-01-12T17:48:36Z
violetagg
val
netty/netty/10914_10942
netty/netty
netty/netty/10914
netty/netty/10942
[ "keyword_pr_to_issue" ]
5b699b722c25a3c34656fc8bbb8e36bee27a5244
bba0017d6e9f0fcf87284fd5618c153f45d8a9da
[ "What's wrong about it?", "` /**\r\n * Sets the value to uninitialized; a proceeding call to get() will trigger a call to initialValue().\r\n */\r\n public final void remove() {\r\n remove(InternalThreadLocalMap.getIfSet());\r\n }`\r\n\r\n@chrisvest,\r\nThe remove() method call to getIfSet...
[]
2021-01-15T10:17:58Z
[]
Wrong the comment for the remove method on FastThreadLocal class.
https://github.com/netty/netty/blob/0dc246eb129796313b58c1dbdd674aa289f72cad/common/src/main/java/io/netty/util/concurrent/FastThreadLocal.java#L234
[ "common/src/main/java/io/netty/util/concurrent/FastThreadLocal.java" ]
[ "common/src/main/java/io/netty/util/concurrent/FastThreadLocal.java" ]
[]
diff --git a/common/src/main/java/io/netty/util/concurrent/FastThreadLocal.java b/common/src/main/java/io/netty/util/concurrent/FastThreadLocal.java index 9b31dd4504e..750b12d8b49 100644 --- a/common/src/main/java/io/netty/util/concurrent/FastThreadLocal.java +++ b/common/src/main/java/io/netty/util/concurrent/FastThre...
null
test
test
2021-01-14T18:27:12
2021-01-08T06:30:26Z
andrewvo148
val
netty/netty/10792_10951
netty/netty
netty/netty/10792
netty/netty/10951
[ "keyword_pr_to_issue" ]
41e79835f20719ca368b23b7ebbbbc96e6b6b666
4fbbcf8702a98f4477cb0c733eab736eca988979
[ "Will provide a PR, probably next week.", "@slandelle any update ?", "@normanmaurer PTAL #10951" ]
[ "Does this need to be a `LinkedHashSet` ?", "is the default size of 64 good ?", "Parameters order is not supposed to be significant. Moreover, `extractExtensions` (in the same class) uses `HashMap` for the parsing side, so using one here too is consistent.", "The size greatly varies depending on the parameter...
2021-01-19T16:59:27Z
[]
WebSocketClientExtensionHandler doesn't check if extensions are already present in sec-websocket-extensions header
### Expected behavior Netty verifies that extensions are not already present in sec-websocket-extensions header before appending them. ### Actual behavior Netty doesn't check, possibly resulting in duplicated values. ### Steps to reproduce Just read existing code: https://github.com/netty/netty/blob/nett...
[ "codec-http/src/main/java/io/netty/handler/codec/http/websocketx/extensions/WebSocketClientExtensionHandler.java", "codec-http/src/main/java/io/netty/handler/codec/http/websocketx/extensions/WebSocketExtensionUtil.java", "codec-http/src/main/java/io/netty/handler/codec/http/websocketx/extensions/WebSocketServer...
[ "codec-http/src/main/java/io/netty/handler/codec/http/websocketx/extensions/WebSocketClientExtensionHandler.java", "codec-http/src/main/java/io/netty/handler/codec/http/websocketx/extensions/WebSocketExtensionUtil.java", "codec-http/src/main/java/io/netty/handler/codec/http/websocketx/extensions/WebSocketServer...
[ "codec-http/src/test/java/io/netty/handler/codec/http/websocketx/extensions/WebSocketExtensionUtilTest.java" ]
diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/websocketx/extensions/WebSocketClientExtensionHandler.java b/codec-http/src/main/java/io/netty/handler/codec/http/websocketx/extensions/WebSocketClientExtensionHandler.java index 165c1cdfc88..47073a7b234 100644 --- a/codec-http/src/main/java/io/netty/han...
diff --git a/codec-http/src/test/java/io/netty/handler/codec/http/websocketx/extensions/WebSocketExtensionUtilTest.java b/codec-http/src/test/java/io/netty/handler/codec/http/websocketx/extensions/WebSocketExtensionUtilTest.java index 12aa06ed660..eab3b3ba46c 100644 --- a/codec-http/src/test/java/io/netty/handler/codec...
test
test
2021-01-21T11:12:54
2020-11-11T13:25:27Z
slandelle
val
netty/netty/10792_10956
netty/netty
netty/netty/10792
netty/netty/10956
[ "keyword_pr_to_issue" ]
f54bf7aeb06c6a4cf9350482f7814c3fb9c4fd82
ccd01934f5a30c62f352fe888d45dbf7ad2352c8
[ "Will provide a PR, probably next week.", "@slandelle any update ?", "@normanmaurer PTAL #10951" ]
[ "@normanmaurer This was missing in the previous PR." ]
2021-01-21T13:45:52Z
[]
WebSocketClientExtensionHandler doesn't check if extensions are already present in sec-websocket-extensions header
### Expected behavior Netty verifies that extensions are not already present in sec-websocket-extensions header before appending them. ### Actual behavior Netty doesn't check, possibly resulting in duplicated values. ### Steps to reproduce Just read existing code: https://github.com/netty/netty/blob/nett...
[ "codec-http/src/main/java/io/netty/handler/codec/http/websocketx/extensions/WebSocketClientExtensionHandler.java", "codec-http/src/main/java/io/netty/handler/codec/http/websocketx/extensions/WebSocketExtensionUtil.java", "codec-http/src/main/java/io/netty/handler/codec/http/websocketx/extensions/WebSocketServer...
[ "codec-http/src/main/java/io/netty/handler/codec/http/websocketx/extensions/WebSocketClientExtensionHandler.java", "codec-http/src/main/java/io/netty/handler/codec/http/websocketx/extensions/WebSocketExtensionUtil.java", "codec-http/src/main/java/io/netty/handler/codec/http/websocketx/extensions/WebSocketServer...
[ "codec-http/src/test/java/io/netty/handler/codec/http/websocketx/extensions/WebSocketExtensionUtilTest.java" ]
diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/websocketx/extensions/WebSocketClientExtensionHandler.java b/codec-http/src/main/java/io/netty/handler/codec/http/websocketx/extensions/WebSocketClientExtensionHandler.java index 165c1cdfc88..47073a7b234 100644 --- a/codec-http/src/main/java/io/netty/han...
diff --git a/codec-http/src/test/java/io/netty/handler/codec/http/websocketx/extensions/WebSocketExtensionUtilTest.java b/codec-http/src/test/java/io/netty/handler/codec/http/websocketx/extensions/WebSocketExtensionUtilTest.java index 12aa06ed660..eab3b3ba46c 100644 --- a/codec-http/src/test/java/io/netty/handler/codec...
val
test
2021-01-21T14:40:45
2020-11-11T13:25:27Z
slandelle
val
netty/netty/10973_11001
netty/netty
netty/netty/10973
netty/netty/11001
[ "keyword_issue_to_pr" ]
a98293f08403961db8bf3eb8ba66a21cb86ecf08
1529ef1794e0a6654fa4334fd979b769d6940e61
[ "@fredericBregier It could be related to https://github.com/netty/netty/pull/10623 given that right now file isn't written until a delimiter is found?", "I think so too... I think we should never the commit in question for now as while it fixes some \"perf issues\" when running in with paranoid leak detection I ...
[ "Calling this method `findLineBreak` would read better with the capitalisation.\r\n\r\nI think calling it \"line break\" also makes sense for the parameters and variables in `findDelimiter`.", "```suggestion\r\n * Try to find the delimiter, with LF or CRLF in front of it (added as delimiters) if needed\r\n```...
2021-02-07T15:39:43Z
[]
OutOfDirectMemoryError for large uploads using HttpPostMultipartRequestDecoder
### Expected behavior With a `HttpDataFactory` that has `useDisk=true`, I thought files of any size could potentially be uploaded. ### Actual behavior Example error from below unit test: ``` io.netty.util.internal.OutOfDirectMemoryError: failed to allocate 4194304 byte(s) of direct memory (used: 62914560, ...
[ "codec-http/src/main/java/io/netty/handler/codec/http/multipart/AbstractMemoryHttpData.java", "codec-http/src/main/java/io/netty/handler/codec/http/multipart/HttpPostBodyUtil.java", "codec-http/src/main/java/io/netty/handler/codec/http/multipart/HttpPostMultipartRequestDecoder.java", "codec-http/src/main/java...
[ "codec-http/src/main/java/io/netty/handler/codec/http/multipart/AbstractMemoryHttpData.java", "codec-http/src/main/java/io/netty/handler/codec/http/multipart/HttpPostBodyUtil.java", "codec-http/src/main/java/io/netty/handler/codec/http/multipart/HttpPostMultipartRequestDecoder.java", "codec-http/src/main/java...
[ "codec-http/src/test/java/io/netty/handler/codec/http/multipart/HttpPostRequestDecoderTest.java" ]
diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/multipart/AbstractMemoryHttpData.java b/codec-http/src/main/java/io/netty/handler/codec/http/multipart/AbstractMemoryHttpData.java index 5cc6ec834ef..14071dad606 100644 --- a/codec-http/src/main/java/io/netty/handler/codec/http/multipart/AbstractMemoryHt...
diff --git a/codec-http/src/test/java/io/netty/handler/codec/http/multipart/HttpPostRequestDecoderTest.java b/codec-http/src/test/java/io/netty/handler/codec/http/multipart/HttpPostRequestDecoderTest.java index acbcf1219d3..93991c375a5 100644 --- a/codec-http/src/test/java/io/netty/handler/codec/http/multipart/HttpPost...
train
test
2021-02-11T21:35:36
2021-01-28T14:18:39Z
danielflower
val
netty/netty/11004_11009
netty/netty
netty/netty/11004
netty/netty/11009
[ "keyword_pr_to_issue" ]
ecd7dc3516b5a9fc612330f2dd617576569a256b
6808d7582a06dfb5038ac1dd8fa58190ab359d19
[ "Thanks @violetagg . [MyBlockHoundIntegration](https://github.com/aztosca/web-client-test/blob/master/src/main/java/org/app/webclienttest/MyBlockHoundIntegration.java) had another entry that allows reading the truststore. Was there any reason not to include this (or similar) in the PR? I understand some things shou...
[]
2021-02-09T08:58:21Z
[]
Unexpected WebClient blocks reported by BlockHound
I'm new to webflux so I posted a [question on stackoverflow](https://stackoverflow.com/questions/66091050/why-is-webclient-blocking-in-this-web-flux-app) thinking I was doing something wrong in my code, but after seeing [this issue](https://github.com/netty/netty/issues/10925) and related [pull request](https://github....
[ "common/src/main/java/io/netty/util/internal/Hidden.java", "resolver-dns/src/main/java/io/netty/resolver/dns/UnixResolverDnsServerAddressStreamProvider.java" ]
[ "common/src/main/java/io/netty/util/internal/Hidden.java", "resolver-dns/src/main/java/io/netty/resolver/dns/UnixResolverDnsServerAddressStreamProvider.java" ]
[ "transport-blockhound-tests/src/test/java/io/netty/util/internal/NettyBlockHoundIntegrationTest.java" ]
diff --git a/common/src/main/java/io/netty/util/internal/Hidden.java b/common/src/main/java/io/netty/util/internal/Hidden.java index 18a03c68ead..fab714d8ad6 100644 --- a/common/src/main/java/io/netty/util/internal/Hidden.java +++ b/common/src/main/java/io/netty/util/internal/Hidden.java @@ -119,6 +119,18 @@ public voi...
diff --git a/transport-blockhound-tests/src/test/java/io/netty/util/internal/NettyBlockHoundIntegrationTest.java b/transport-blockhound-tests/src/test/java/io/netty/util/internal/NettyBlockHoundIntegrationTest.java index 2d5121a0781..1b454a1802e 100644 --- a/transport-blockhound-tests/src/test/java/io/netty/util/intern...
train
test
2021-02-08T20:55:02
2021-02-08T03:06:03Z
aztosca
val
netty/netty/11021_11022
netty/netty
netty/netty/11021
netty/netty/11022
[ "keyword_pr_to_issue" ]
a98293f08403961db8bf3eb8ba66a21cb86ecf08
9cac18687d15be113cf869426f4bd1aca804b6b0
[]
[]
2021-02-12T10:59:17Z
[]
Doc incorrect at io.netty.util.concurrent.AbstractEventExecutor#lazyExecute
### Actual behavior ``` /** * Like {@link #execute(Runnable)} but does not guarantee the task will be run until either * a non-lazy task is executed or the executor is shut down. * * This is equivalent to submitting a {@link EventExecutor.LazyRunnable} to * {@link #execute(Runnable)}...
[ "common/src/main/java/io/netty/util/concurrent/AbstractEventExecutor.java" ]
[ "common/src/main/java/io/netty/util/concurrent/AbstractEventExecutor.java" ]
[]
diff --git a/common/src/main/java/io/netty/util/concurrent/AbstractEventExecutor.java b/common/src/main/java/io/netty/util/concurrent/AbstractEventExecutor.java index b1df38a81aa..e4ca3440960 100644 --- a/common/src/main/java/io/netty/util/concurrent/AbstractEventExecutor.java +++ b/common/src/main/java/io/netty/util/c...
null
train
test
2021-02-11T21:35:36
2021-02-12T10:58:50Z
horizonzy
val
netty/netty/11032_11033
netty/netty
netty/netty/11032
netty/netty/11033
[ "keyword_pr_to_issue" ]
28d4154fffc9c51f73b5969c64d74ca17ca4baba
a60825c3b425892af9be3e9284677aa8a58faa6b
[]
[]
2021-02-21T09:03:29Z
[]
Code clean at io.netty.buffer.AbstractByteBuf#adjustMarkers
https://github.com/netty/netty/blob/28d4154fffc9c51f73b5969c64d74ca17ca4baba/buffer/src/main/java/io/netty/buffer/AbstractByteBuf.java#L257-L271 It's unnecessary to create stack variable.
[ "buffer/src/main/java/io/netty/buffer/AbstractByteBuf.java" ]
[ "buffer/src/main/java/io/netty/buffer/AbstractByteBuf.java" ]
[]
diff --git a/buffer/src/main/java/io/netty/buffer/AbstractByteBuf.java b/buffer/src/main/java/io/netty/buffer/AbstractByteBuf.java index c13efdd0046..fb152502719 100644 --- a/buffer/src/main/java/io/netty/buffer/AbstractByteBuf.java +++ b/buffer/src/main/java/io/netty/buffer/AbstractByteBuf.java @@ -255,17 +255,15 @@ p...
null
train
test
2021-02-19T13:29:47
2021-02-21T08:49:21Z
horizonzy
val
netty/netty/10986_11037
netty/netty
netty/netty/10986
netty/netty/11037
[ "keyword_pr_to_issue" ]
a60825c3b425892af9be3e9284677aa8a58faa6b
dde82f62f07de5e794dda1c3324d8331ca522114
[ "Hmm... I can't see this. Can you make a screenshot ?", "like this.\r\n\r\n<img width=\"669\" alt=\"stack\" src=\"https://user-images.githubusercontent.com/12539730/107210938-d1300080-6a3f-11eb-8760-2e754935ea67.png\">\r\n\r\n\r\n\r\n", "@chrisvest can you have a look ?", "@normanmaurer Yeah, I'll try to spen...
[ "You can just extends `AtomicInteger` that would give you back `Unsafe` perf for free :)\r\n\r\nYeah I know that's bad design so you can ignore me ;)", "I considered it, but then I loose the field name which is quite awkward. Also, I think the JIT is able to trust the finals inside A\\*FUs these days, so they're ...
2021-02-25T14:11:30Z
[]
recycler has problems recycling objects in a multi-threaded environment
### Expected behavior An object is collected in a multi-threaded environment and only exists in one queue. ### Actual behavior An object is collected in multiple queues in a multithreaded environment. ### Steps to reproduce ``` public void testMultipleRecycleAtDifferentThread() throws InterruptedExcepti...
[ "common/src/main/java/io/netty/util/Recycler.java" ]
[ "common/src/main/java/io/netty/util/Recycler.java" ]
[ "common/src/test/java/io/netty/util/RecyclerTest.java" ]
diff --git a/common/src/main/java/io/netty/util/Recycler.java b/common/src/main/java/io/netty/util/Recycler.java index 9e81aa527d0..d64889488ee 100644 --- a/common/src/main/java/io/netty/util/Recycler.java +++ b/common/src/main/java/io/netty/util/Recycler.java @@ -27,6 +27,7 @@ import java.util.Map; import java.util....
diff --git a/common/src/test/java/io/netty/util/RecyclerTest.java b/common/src/test/java/io/netty/util/RecyclerTest.java index 1d711f5e4a4..0c2d0705606 100644 --- a/common/src/test/java/io/netty/util/RecyclerTest.java +++ b/common/src/test/java/io/netty/util/RecyclerTest.java @@ -18,6 +18,7 @@ import org.junit.Test; ...
val
test
2021-02-23T20:47:26
2021-02-02T13:47:59Z
xiaoheng1
val
netty/netty/11054_11061
netty/netty
netty/netty/11054
netty/netty/11061
[ "connected" ]
7d4aaa268b8a536f61fbc7711365147c58238745
0f12472b580bcbb34cbe84810077aa33c1091d14
[ "@Shoothzj sure... Maybe provide a PR that allows to configure the `SocketAddress` via the `DnsResolverBuilder` ?", "@normanmaurer I am new to Netty code contributing. How about java property `io.netty.dnsResolverListenAddress`", "I would prefer to make it configurable via the builder.. " ]
[ "This should be an `InetSocketAddress`. Also we will need to preserve the old constructor to not break things, which means you should add a new one (package-private)", "See below... pass in `null` for using the default. ", "See below... should be `SocketAddress`", "call `register` if the `bindAddress` is `nu...
2021-03-06T08:47:35Z
[]
Allow to config the listen address on DnsResolver
The DnsResolver default start address listen to "0.0.0.0", which may have some security risks. Can we allow to config the listen address on DnsResolver?
[ "resolver-dns/src/main/java/io/netty/resolver/dns/DnsNameResolver.java", "resolver-dns/src/main/java/io/netty/resolver/dns/DnsNameResolverBuilder.java" ]
[ "resolver-dns/src/main/java/io/netty/resolver/dns/DnsNameResolver.java", "resolver-dns/src/main/java/io/netty/resolver/dns/DnsNameResolverBuilder.java" ]
[]
diff --git a/resolver-dns/src/main/java/io/netty/resolver/dns/DnsNameResolver.java b/resolver-dns/src/main/java/io/netty/resolver/dns/DnsNameResolver.java index 3781bd4015b..bf594db0627 100644 --- a/resolver-dns/src/main/java/io/netty/resolver/dns/DnsNameResolver.java +++ b/resolver-dns/src/main/java/io/netty/resolver/...
null
train
test
2021-03-07T19:15:39
2021-03-03T08:12:48Z
shoothzj
val
netty/netty/11092_11093
netty/netty
netty/netty/11092
netty/netty/11093
[ "keyword_pr_to_issue" ]
654a54bbadad69031cb34cfdf6e5f6a6f6bbbfb1
56703b93ba2ab29b5ba076dc838c3b73a9389bda
[]
[]
2021-03-17T05:17:41Z
[]
IllegalReferenceCountException using compression if HttpResponse implements HttpContent and not LastHttpContent
This was originally reported in Quarkus as https://github.com/quarkusio/quarkus/issues/14695. Vert.x uses https://github.com/eclipse-vertx/vert.x/blob/master/src/main/java/io/vertx/core/http/impl/AssembledHttpResponse.java which implements both HttpResponse and HttpContent, but not LastHttpContent. This results in a...
[ "codec-http/src/main/java/io/netty/handler/codec/http/HttpContentEncoder.java" ]
[ "codec-http/src/main/java/io/netty/handler/codec/http/HttpContentEncoder.java" ]
[ "codec-http/src/test/java/io/netty/handler/codec/http/HttpContentCompressorTest.java" ]
diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/HttpContentEncoder.java b/codec-http/src/main/java/io/netty/handler/codec/http/HttpContentEncoder.java index a0d951a16c5..9f94e025873 100644 --- a/codec-http/src/main/java/io/netty/handler/codec/http/HttpContentEncoder.java +++ b/codec-http/src/main/java...
diff --git a/codec-http/src/test/java/io/netty/handler/codec/http/HttpContentCompressorTest.java b/codec-http/src/test/java/io/netty/handler/codec/http/HttpContentCompressorTest.java index c2bac013a10..901e424dd6a 100644 --- a/codec-http/src/test/java/io/netty/handler/codec/http/HttpContentCompressorTest.java +++ b/cod...
train
test
2021-03-18T17:54:06
2021-03-17T05:14:50Z
stuartwdouglas
val
netty/netty/10908_11100
netty/netty
netty/netty/10908
netty/netty/11100
[ "keyword_pr_to_issue" ]
bd62a9d6ffd9941d9e399cbbd73a10f06e38f217
9f242d27e05651a909571f232dd1f5afb1aed20c
[ "@srinidhibashyam I don't think byte discarding is intended to be used in conjunction with derived buffers (slices/duplicates) since it moves things around in the underlying buffer without derived buffers' knowledge. There should probably be a check to disallow those operations if the buffer's ref count is > 1 (as ...
[]
2021-03-18T13:49:07Z
[]
NullPointerException while accessing a readable slice of CompositeByteBuf after discarding some bytes
### Expected behavior After skipping and discarding some bytes using `skipBytes()` and `discardSomeReadBytes()` functions in a `CompositeByteBuf`, the readable bytes in the buffer should still be accessible. ### Actual behavior Throws NullPointerException. ``` Exception in thread "main" java.lang.NullPointer...
[ "buffer/src/main/java/io/netty/buffer/CompositeByteBuf.java" ]
[ "buffer/src/main/java/io/netty/buffer/CompositeByteBuf.java" ]
[ "buffer/src/test/java/io/netty/buffer/AbstractCompositeByteBufTest.java" ]
diff --git a/buffer/src/main/java/io/netty/buffer/CompositeByteBuf.java b/buffer/src/main/java/io/netty/buffer/CompositeByteBuf.java index 2b03b801cb1..6dc0a2cbf73 100644 --- a/buffer/src/main/java/io/netty/buffer/CompositeByteBuf.java +++ b/buffer/src/main/java/io/netty/buffer/CompositeByteBuf.java @@ -1601,6 +1601,10...
diff --git a/buffer/src/test/java/io/netty/buffer/AbstractCompositeByteBufTest.java b/buffer/src/test/java/io/netty/buffer/AbstractCompositeByteBufTest.java index 6991fabd539..4af2e2efbd4 100644 --- a/buffer/src/test/java/io/netty/buffer/AbstractCompositeByteBufTest.java +++ b/buffer/src/test/java/io/netty/buffer/Abstr...
val
test
2021-03-17T20:18:50
2021-01-04T01:21:09Z
srinidhibashyam
val
netty/netty/11101_11106
netty/netty
netty/netty/11101
netty/netty/11106
[ "keyword_pr_to_issue" ]
4f316b7cbd8af2bbf47319c82941a6f80afcb609
207108691976ac8ef646156b4289776d7966c4f7
[ "@alalag1 Oof! Nice catch. We'll take a look." ]
[ "So this means we may waste `directMemoryCacheAlignment` bytes in the worse case, correct ? ", "Should we better not make this static but create a new one in the test ? Otherwise we may end up with using more memory then we really need (due the fact that the ALLOCATOR will not be collected until the JVM dies).", ...
2021-03-22T16:38:12Z
[]
direct memory allocation error in PooledByteBufAllocator when setting directMemoryCacheAlignment to "1"
Define a `PooledByteBufAllocator` and set ·directMemoryCacheAlignment· to "1" and try to allocate some `ByteBuf` like ```java PooledByteBufAllocator pooledByteBufAllocator = new PooledByteBufAllocator( PlatformDependent.directBufferPreferred(), PooledByteBufAllocator.defaultNumHeapArena(), ...
[ "buffer/src/main/java/io/netty/buffer/PoolArena.java", "buffer/src/main/java/io/netty/buffer/PoolChunk.java", "buffer/src/main/java/io/netty/buffer/PooledByteBuf.java", "buffer/src/main/java/io/netty/buffer/PooledByteBufAllocator.java", "common/src/main/java/io/netty/util/internal/PlatformDependent.java", ...
[ "buffer/src/main/java/io/netty/buffer/PoolArena.java", "buffer/src/main/java/io/netty/buffer/PoolChunk.java", "buffer/src/main/java/io/netty/buffer/PooledByteBuf.java", "buffer/src/main/java/io/netty/buffer/PooledByteBufAllocator.java", "common/src/main/java/io/netty/util/internal/PlatformDependent.java", ...
[ "buffer/src/test/java/io/netty/buffer/AbstractPooledByteBufTest.java", "buffer/src/test/java/io/netty/buffer/AlignedPooledByteBufAllocatorTest.java", "buffer/src/test/java/io/netty/buffer/PoolArenaTest.java", "buffer/src/test/java/io/netty/buffer/PooledAlignedBigEndianDirectByteBufTest.java" ]
diff --git a/buffer/src/main/java/io/netty/buffer/PoolArena.java b/buffer/src/main/java/io/netty/buffer/PoolArena.java index cab3224760f..fba1127b5d7 100644 --- a/buffer/src/main/java/io/netty/buffer/PoolArena.java +++ b/buffer/src/main/java/io/netty/buffer/PoolArena.java @@ -41,7 +41,6 @@ enum SizeClass { final...
diff --git a/buffer/src/test/java/io/netty/buffer/AbstractPooledByteBufTest.java b/buffer/src/test/java/io/netty/buffer/AbstractPooledByteBufTest.java index f7c16661a67..54797b25647 100644 --- a/buffer/src/test/java/io/netty/buffer/AbstractPooledByteBufTest.java +++ b/buffer/src/test/java/io/netty/buffer/AbstractPooled...
train
test
2021-03-21T14:51:56
2021-03-19T12:14:19Z
alalag1
val
netty/netty/11143_11145
netty/netty
netty/netty/11143
netty/netty/11145
[ "keyword_pr_to_issue", "connected" ]
16b40d8a37937fd6e73858db2f05bd1e778a1d6f
93f021141d93e6529215601ba6b5938e44f499c8
[ "@jameskleeh \r\nFrom the beginning: https://github.com/fredericBregier/netty/blob/6daeb0cc51d8689805c1a657e61d395450afec47/codec-http/src/main/java/io/netty/handler/codec/http/multipart/HttpPostMultipartRequestDecoder.java#L1160\r\n\r\nIt tries to find out the `delimiter` in the full buffer (multiple chunks up to ...
[ "Why this change? There are a number of places in the code where we check if `byteBuf` is `null`. Also, when `delete` is called, the `byteBuf` is set to `null`.", "The English for these two comments reads weird. How about:\n\n> Note: this method will allocate a lot of memory, if the data is currently stored on th...
2021-04-07T06:52:01Z
[]
HttpPostMultipartRequestDecoder may not add content to an existing upload after being offered data
### Expected behavior Once a file upload object exists in the multipart request decoder, but not finished, offering more data to the decoder should populate the buffer of the file object ### Actual behavior The buffer is not created/updated ### Steps to reproduce - `git clone https://github.com/micronaut...
[ "codec-http/src/main/java/io/netty/handler/codec/http/multipart/AbstractMemoryHttpData.java", "codec-http/src/main/java/io/netty/handler/codec/http/multipart/DefaultHttpDataFactory.java", "codec-http/src/main/java/io/netty/handler/codec/http/multipart/HttpData.java", "codec-http/src/main/java/io/netty/handler...
[ "codec-http/src/main/java/io/netty/handler/codec/http/multipart/AbstractMemoryHttpData.java", "codec-http/src/main/java/io/netty/handler/codec/http/multipart/DefaultHttpDataFactory.java", "codec-http/src/main/java/io/netty/handler/codec/http/multipart/HttpData.java", "codec-http/src/main/java/io/netty/handler...
[ "codec-http/src/test/java/io/netty/handler/codec/http/multipart/HttpPostRequestDecoderTest.java" ]
diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/multipart/AbstractMemoryHttpData.java b/codec-http/src/main/java/io/netty/handler/codec/http/multipart/AbstractMemoryHttpData.java index 14071dad606..dc8dd02f1fa 100644 --- a/codec-http/src/main/java/io/netty/handler/codec/http/multipart/AbstractMemoryHt...
diff --git a/codec-http/src/test/java/io/netty/handler/codec/http/multipart/HttpPostRequestDecoderTest.java b/codec-http/src/test/java/io/netty/handler/codec/http/multipart/HttpPostRequestDecoderTest.java index 93991c375a5..40f2f400a4e 100644 --- a/codec-http/src/test/java/io/netty/handler/codec/http/multipart/HttpPost...
train
test
2021-04-15T17:18:54
2021-04-06T16:23:49Z
jameskleeh
val
netty/netty/11147_11150
netty/netty
netty/netty/11147
netty/netty/11150
[ "keyword_pr_to_issue" ]
6724786dcc9fa38ba516dab97a04e2bbc17e81d9
df53de5b687cd25ba1079b556318da2b773cf4f1
[ "`available()` only tells you how many bytes you can read without blocking; it doesn't tell if you're at the end of the stream.", "Actually it returns -1 or an error when at end of stream" ]
[]
2021-04-09T10:54:51Z
[]
ChunkedInputStream isEndOfInput blocks event loop
In all versions of netty the ChunkedInputStream isEndOfInput uses b.read() which is blocking. This should instead use available()
[ "handler/src/main/java/io/netty/handler/stream/ChunkedStream.java" ]
[ "handler/src/main/java/io/netty/handler/stream/ChunkedStream.java" ]
[ "transport-native-epoll/src/test/java/io/netty/channel/epoll/EpollSocketChannelConfigTest.java" ]
diff --git a/handler/src/main/java/io/netty/handler/stream/ChunkedStream.java b/handler/src/main/java/io/netty/handler/stream/ChunkedStream.java index 8f67df20f8d..86e3f5d5c71 100644 --- a/handler/src/main/java/io/netty/handler/stream/ChunkedStream.java +++ b/handler/src/main/java/io/netty/handler/stream/ChunkedStream....
diff --git a/transport-native-epoll/src/test/java/io/netty/channel/epoll/EpollSocketChannelConfigTest.java b/transport-native-epoll/src/test/java/io/netty/channel/epoll/EpollSocketChannelConfigTest.java index a859085aeae..299183d89d6 100644 --- a/transport-native-epoll/src/test/java/io/netty/channel/epoll/EpollSocketCh...
val
test
2021-04-01T12:50:23
2021-04-08T16:40:22Z
davydotcom
val
netty/netty/11142_11167
netty/netty
netty/netty/11142
netty/netty/11167
[ "keyword_pr_to_issue" ]
e2daae9ac8e4b5c0a04f47b163157445915b949a
d34212439068091bcec29a8fad4df82f0a82c638
[ "Is it possible to have a solution similar to the one for `localhost`?\r\n\r\nhttps://github.com/netty/netty/blob/6724786dcc9fa38ba516dab97a04e2bbc17e81d9/resolver-dns/src/main/java/io/netty/resolver/dns/DnsNameResolver.java#L684-L697", "@violetagg not sure what you are suggesting... can you maybe do a PR to show...
[ "Let add WINDOWS to the field name to make it clear this is only used on windows ", "done" ]
2021-04-19T18:49:52Z
[]
Netty DNS resolver fails to resolve computer's name on Windows
When running on a VM with Windows 10, Netty DNS resolver cannot resolve computer's name. ### Expected behavior When on Windows, Netty DNS resolver is able to resolve the computer's name ### Actual behavior The current implementation throws an exception when one tries to resolve the computer's name ``` Cause...
[ "resolver-dns/src/main/java/io/netty/resolver/dns/DnsNameResolver.java" ]
[ "resolver-dns/src/main/java/io/netty/resolver/dns/DnsNameResolver.java" ]
[ "resolver-dns/src/test/java/io/netty/resolver/dns/DnsNameResolverTest.java" ]
diff --git a/resolver-dns/src/main/java/io/netty/resolver/dns/DnsNameResolver.java b/resolver-dns/src/main/java/io/netty/resolver/dns/DnsNameResolver.java index bf594db0627..a3a514f2039 100644 --- a/resolver-dns/src/main/java/io/netty/resolver/dns/DnsNameResolver.java +++ b/resolver-dns/src/main/java/io/netty/resolver/...
diff --git a/resolver-dns/src/test/java/io/netty/resolver/dns/DnsNameResolverTest.java b/resolver-dns/src/test/java/io/netty/resolver/dns/DnsNameResolverTest.java index 3ba8f7aecae..bd16d47ba19 100644 --- a/resolver-dns/src/test/java/io/netty/resolver/dns/DnsNameResolverTest.java +++ b/resolver-dns/src/test/java/io/net...
test
test
2021-04-19T16:05:53
2021-04-05T16:29:40Z
violetagg
val
netty/netty/11184_11188
netty/netty
netty/netty/11184
netty/netty/11188
[ "keyword_pr_to_issue" ]
63352b135a2a49ec91b5cf0d183ef744aa53a7a6
e7330490e3ff29146b7658e1e2a23593edfb4d5e
[ "Related to #11174 \r\n\r\nA fix will be proposed soon\r\n" ]
[ "@fredericBregier can you do this change in a separate PR and also add a unit test ?", "@normanmaurer I'm not sure I can. Let me explain.\r\nFirst, this is already in place in HttpPostStandardRequestDecoder, so it should be also within Multipart too.\r\n\r\nI notice this during PR since the deploy was wrong due t...
2021-04-22T18:30:31Z
[]
Memleak
### Expected behavior ### Actual behavior ![image](https://user-images.githubusercontent.com/20749545/115715628-e8c62680-a3aa-11eb-9373-e2dea504a1f6.png) 2021-04-22 19:17:28 805[ERROR][ResourceLeakDetector.java-319][lettuce-epollEventLoop-22-4]-LEAK: ByteBuf.release() was not called before it's garbage-collected. ...
[ "codec-http/src/main/java/io/netty/handler/codec/http/multipart/HttpPostMultipartRequestDecoder.java", "codec-http/src/main/java/io/netty/handler/codec/http/multipart/HttpPostStandardRequestDecoder.java" ]
[ "codec-http/src/main/java/io/netty/handler/codec/http/multipart/HttpPostMultipartRequestDecoder.java", "codec-http/src/main/java/io/netty/handler/codec/http/multipart/HttpPostStandardRequestDecoder.java" ]
[ "codec-http/src/test/java/io/netty/handler/codec/http/multipart/HttpPostRequestDecoderTest.java" ]
diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/multipart/HttpPostMultipartRequestDecoder.java b/codec-http/src/main/java/io/netty/handler/codec/http/multipart/HttpPostMultipartRequestDecoder.java index 5099ee60ac4..490b1ffcc14 100644 --- a/codec-http/src/main/java/io/netty/handler/codec/http/multipar...
diff --git a/codec-http/src/test/java/io/netty/handler/codec/http/multipart/HttpPostRequestDecoderTest.java b/codec-http/src/test/java/io/netty/handler/codec/http/multipart/HttpPostRequestDecoderTest.java index 40f2f400a4e..665606fad83 100644 --- a/codec-http/src/test/java/io/netty/handler/codec/http/multipart/HttpPost...
train
test
2021-04-29T10:26:44
2021-04-22T12:42:13Z
jr981008
val
netty/netty/11175_11188
netty/netty
netty/netty/11175
netty/netty/11188
[ "keyword_issue_to_pr", "keyword_pr_to_issue" ]
63352b135a2a49ec91b5cf0d183ef744aa53a7a6
e7330490e3ff29146b7658e1e2a23593edfb4d5e
[ "There are some benchmarks within Netty that shows exactly the contrary (whatever Memory, Mixed or Disk Factory based).\r\nThe results are not using big file however, just 512KB but with more than 6 000 upload/s, so very quick, and about 3 GB/s.\r\nI've tested by changing size to 25 MB, increasing Factory size to 1...
[ "@fredericBregier can you do this change in a separate PR and also add a unit test ?", "@normanmaurer I'm not sure I can. Let me explain.\r\nFirst, this is already in place in HttpPostStandardRequestDecoder, so it should be also within Multipart too.\r\n\r\nI notice this during PR since the deploy was wrong due t...
2021-04-22T18:30:31Z
[]
File upload extremely slow
### Expected behavior Uploading a file should be almost instantaneous in a local environment ### Actual behavior Uploading a file is taking approximately 1 minute ### Steps to reproduce - `./gradlew run` - Upload a 25-30mb file (the project README has an example curl) ### Minimal yet complete reprodu...
[ "codec-http/src/main/java/io/netty/handler/codec/http/multipart/HttpPostMultipartRequestDecoder.java", "codec-http/src/main/java/io/netty/handler/codec/http/multipart/HttpPostStandardRequestDecoder.java" ]
[ "codec-http/src/main/java/io/netty/handler/codec/http/multipart/HttpPostMultipartRequestDecoder.java", "codec-http/src/main/java/io/netty/handler/codec/http/multipart/HttpPostStandardRequestDecoder.java" ]
[ "codec-http/src/test/java/io/netty/handler/codec/http/multipart/HttpPostRequestDecoderTest.java" ]
diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/multipart/HttpPostMultipartRequestDecoder.java b/codec-http/src/main/java/io/netty/handler/codec/http/multipart/HttpPostMultipartRequestDecoder.java index 5099ee60ac4..490b1ffcc14 100644 --- a/codec-http/src/main/java/io/netty/handler/codec/http/multipar...
diff --git a/codec-http/src/test/java/io/netty/handler/codec/http/multipart/HttpPostRequestDecoderTest.java b/codec-http/src/test/java/io/netty/handler/codec/http/multipart/HttpPostRequestDecoderTest.java index 40f2f400a4e..665606fad83 100644 --- a/codec-http/src/test/java/io/netty/handler/codec/http/multipart/HttpPost...
train
test
2021-04-29T10:26:44
2021-04-20T16:40:17Z
jameskleeh
val
netty/netty/11175_11207
netty/netty
netty/netty/11175
netty/netty/11207
[ "keyword_issue_to_pr" ]
3657805711668ff1249b4c19e227bedb94d55417
def8a3f17d875ac188ed1d3364618f559a0b59ce
[ "There are some benchmarks within Netty that shows exactly the contrary (whatever Memory, Mixed or Disk Factory based).\r\nThe results are not using big file however, just 512KB but with more than 6 000 upload/s, so very quick, and about 3 GB/s.\r\nI've tested by changing size to 25 MB, increasing Factory size to 1...
[]
2021-04-28T09:01:13Z
[]
File upload extremely slow
### Expected behavior Uploading a file should be almost instantaneous in a local environment ### Actual behavior Uploading a file is taking approximately 1 minute ### Steps to reproduce - `./gradlew run` - Upload a 25-30mb file (the project README has an example curl) ### Minimal yet complete reprodu...
[ "codec-http/src/main/java/io/netty/handler/codec/http/multipart/HttpPostMultipartRequestDecoder.java" ]
[ "codec-http/src/main/java/io/netty/handler/codec/http/multipart/HttpPostMultipartRequestDecoder.java" ]
[ "codec-http/src/test/java/io/netty/handler/codec/http/multipart/HttpPostMultiPartRequestDecoderTest.java" ]
diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/multipart/HttpPostMultipartRequestDecoder.java b/codec-http/src/main/java/io/netty/handler/codec/http/multipart/HttpPostMultipartRequestDecoder.java index af3b5022a23..5099ee60ac4 100644 --- a/codec-http/src/main/java/io/netty/handler/codec/http/multipar...
diff --git a/codec-http/src/test/java/io/netty/handler/codec/http/multipart/HttpPostMultiPartRequestDecoderTest.java b/codec-http/src/test/java/io/netty/handler/codec/http/multipart/HttpPostMultiPartRequestDecoderTest.java index 696c2cb20a9..419e93beb1d 100644 --- a/codec-http/src/test/java/io/netty/handler/codec/http/...
test
test
2021-04-27T16:37:37
2021-04-20T16:40:17Z
jameskleeh
val
netty/netty/11240_11245
netty/netty
netty/netty/11240
netty/netty/11245
[ "keyword_pr_to_issue" ]
d984d4422ca36aac4ddcdb54362f12b589e52f71
11e6a77fba9ec7184a558d869373d0ce506d7236
[ "@normanmaurer I can provide a PR for this.", "@hyperxpro sure lets do it :)" ]
[ "I think to be safe you want to use something like :\n\nreplaceAll(\"[^\\\\w.-]\", \"_\");", "With: `fqdn = fqdn.replaceFirst(\"\\\\*\", \"X\");`, Output: `X.shieldblaze.com`\r\nWith: `fqdn = fqdn.replaceAll(\"[^\\\\w.-]\", \"_\");`, Output: `_.shieldblaze.com`\r\n\r\nBoth are acceptable in terms of safety. Howev...
2021-05-11T16:10:17Z
[]
SelfSignedCertificate should use valid characters for file name
### Expected behavior `SelfSignedCertificate` should filter out asterisk `*` while saving certificate and private key file. ### Actual behavior `SelfSignedCertificate` creates a certificate and private key files and store them in a temporary directory. However, if the certificate uses a wildcard hostname that uses...
[ "handler/src/main/java/io/netty/handler/ssl/util/SelfSignedCertificate.java" ]
[ "handler/src/main/java/io/netty/handler/ssl/util/SelfSignedCertificate.java" ]
[ "handler/src/test/java/io/netty/handler/ssl/util/SelfSignedCertificateTest.java" ]
diff --git a/handler/src/main/java/io/netty/handler/ssl/util/SelfSignedCertificate.java b/handler/src/main/java/io/netty/handler/ssl/util/SelfSignedCertificate.java index 46a28d272f6..be57cd60caf 100644 --- a/handler/src/main/java/io/netty/handler/ssl/util/SelfSignedCertificate.java +++ b/handler/src/main/java/io/netty...
diff --git a/handler/src/test/java/io/netty/handler/ssl/util/SelfSignedCertificateTest.java b/handler/src/test/java/io/netty/handler/ssl/util/SelfSignedCertificateTest.java new file mode 100644 index 00000000000..59ca37635bc --- /dev/null +++ b/handler/src/test/java/io/netty/handler/ssl/util/SelfSignedCertificateTest.j...
train
test
2021-05-11T14:07:15
2021-05-11T09:11:56Z
hyperxpro
val
netty/netty/10834_11246
netty/netty
netty/netty/10834
netty/netty/11246
[ "keyword_pr_to_issue" ]
d984d4422ca36aac4ddcdb54362f12b589e52f71
fa8f7a3510d0dbb57488272cf5ba92cca8076794
[ "That seems none of Netty`s business, cause just connect 127.0.0.1:37655 successfully but not 127.0.1.1:37655", "@violetagg can you connect to the service via telnet on `127.0.1.1` ?", "> @violetagg can you connect to the service via telnet on `127.0.1.1` ?\r\n\r\n```\r\n# python -m SimpleHTTPServer 8000 &> /de...
[ "nit: you can remove the else as we return in the if.", "nit: should we use a different initial capacity ?", "please add javadocs", "imho it would be better to use `new ArrayList<InetAddress>(a.size() + (b == null ? 0 : b.size()));`. Otherwise you may need to expand the array after creation ", "imho its a b...
2021-05-11T18:25:27Z
[]
AnnotatedConnectException: Connection refused: localhost/127.0.1.1:37655
When there are more than one entries for localhost in `/etc/hosts`, connection is refused. This happens only when using `DnsAddressResolverGroup`. If `DefaultAddressResolverGroup` is used there is no problem with connection establishment. ``` # /etc/hosts 127.0.1.1 localhost 127.0.0.1 localhost ``` If `127.0...
[ "common/src/main/java/io/netty/util/internal/Hidden.java", "resolver-dns/src/main/java/io/netty/resolver/dns/DnsNameResolver.java", "resolver/src/main/java/io/netty/resolver/DefaultHostsFileEntriesResolver.java", "resolver/src/main/java/io/netty/resolver/HostsFileEntries.java", "resolver/src/main/java/io/ne...
[ "common/src/main/java/io/netty/util/internal/Hidden.java", "resolver-dns/src/main/java/io/netty/resolver/dns/DnsNameResolver.java", "resolver/src/main/java/io/netty/resolver/DefaultHostsFileEntriesResolver.java", "resolver/src/main/java/io/netty/resolver/HostsFileEntries.java", "resolver/src/main/java/io/ne...
[ "resolver/src/test/java/io/netty/resolver/DefaultHostsFileEntriesResolverTest.java", "resolver/src/test/java/io/netty/resolver/HostsFileEntriesProviderTest.java" ]
diff --git a/common/src/main/java/io/netty/util/internal/Hidden.java b/common/src/main/java/io/netty/util/internal/Hidden.java index abef31287cc..da64a8b1c21 100644 --- a/common/src/main/java/io/netty/util/internal/Hidden.java +++ b/common/src/main/java/io/netty/util/internal/Hidden.java @@ -128,7 +128,7 @@ public void...
diff --git a/resolver/src/test/java/io/netty/resolver/DefaultHostsFileEntriesResolverTest.java b/resolver/src/test/java/io/netty/resolver/DefaultHostsFileEntriesResolverTest.java index b3485f5978d..4a79cd2cdce 100644 --- a/resolver/src/test/java/io/netty/resolver/DefaultHostsFileEntriesResolverTest.java +++ b/resolver/...
train
test
2021-05-11T14:07:15
2020-12-03T10:51:50Z
violetagg
val
netty/netty/11263_11264
netty/netty
netty/netty/11263
netty/netty/11264
[ "keyword_pr_to_issue" ]
ccca3959fd64b133edca855925fb68d077c3a8a2
7c955a19dce2e7ea95e15a5c578e7e71d0d4a238
[]
[]
2021-05-17T23:08:19Z
[]
Remove dependency on log4J 1.x branch
Netty, and thus all downstream projects (e.g. vert.x, Quarkus etc) show a dependency on log4j-1.2.17 which as been flagged with CVE: 20-12-2019. From a vulnerability scan: > Severity: High > > CVE: 20-12-2019 > > Description: Included in Log4j 1.2 is a SocketServer class that is vulnerable to deserialization of ...
[ "common/pom.xml", "pom.xml" ]
[ "common/pom.xml", "pom.xml" ]
[]
diff --git a/common/pom.xml b/common/pom.xml index 15a5dc12679..a930b94f1bd 100644 --- a/common/pom.xml +++ b/common/pom.xml @@ -64,8 +64,8 @@ <optional>true</optional> </dependency> <dependency> - <groupId>log4j</groupId> - <artifactId>log4j</artifactId> + <groupId>org.apache.logging.lo...
null
train
test
2021-05-17T20:16:25
2021-05-17T22:05:05Z
Stwissel
val
netty/netty/11280_11281
netty/netty
netty/netty/11280
netty/netty/11281
[ "keyword_pr_to_issue" ]
bed04fc5975c305750ffbdabcd66b352616d0c1d
9747739962dc9ca620417568d4f4de4d5659547a
[]
[]
2021-05-19T03:07:24Z
[]
Method 'io.netty.util.internal.MathUtil#isOutOfBounds' needs to check the 'capacity' parameter
### Expected behavior As `io.netty.util.internal.MathUtil#isOutOfBounds` is a public utility method, it should pass all kinds of test cases. Like: ``` import io.netty.util.internal.MathUtil; public static void main(String[] args) { boolean isOutOfBounds = MathUtil.isOutOfBounds(1, 2, Integer.MIN_VALUE); ...
[ "common/src/main/java/io/netty/util/internal/MathUtil.java" ]
[ "common/src/main/java/io/netty/util/internal/MathUtil.java" ]
[ "common/src/test/java/io/netty/util/internal/MathUtilTest.java" ]
diff --git a/common/src/main/java/io/netty/util/internal/MathUtil.java b/common/src/main/java/io/netty/util/internal/MathUtil.java index 68777e6d8e2..fd8e165eccf 100644 --- a/common/src/main/java/io/netty/util/internal/MathUtil.java +++ b/common/src/main/java/io/netty/util/internal/MathUtil.java @@ -57,11 +57,11 @@ pub...
diff --git a/common/src/test/java/io/netty/util/internal/MathUtilTest.java b/common/src/test/java/io/netty/util/internal/MathUtilTest.java index 32628114dd9..2fd44ced4bc 100644 --- a/common/src/test/java/io/netty/util/internal/MathUtilTest.java +++ b/common/src/test/java/io/netty/util/internal/MathUtilTest.java @@ -68,...
train
test
2021-05-19T16:28:05
2021-05-19T02:28:26Z
laosijikaichele
val
netty/netty/11279_11281
netty/netty
netty/netty/11279
netty/netty/11281
[ "keyword_pr_to_issue" ]
bed04fc5975c305750ffbdabcd66b352616d0c1d
9747739962dc9ca620417568d4f4de4d5659547a
[]
[]
2021-05-19T03:07:24Z
[]
Docs of method 'io.netty.util.internal.MathUtil#isOutOfBounds' needs to be modified
### Expected behavior the docs about the 'retun value' of the method `io.netty.util.internal.MathUtil#isOutOfBounds`is not correct. It shoud be: > * @return {@code false} if the requested {@code index} and {@code length} will fit within {@code capacity}. > * {@code true} if this would result in an index o...
[ "common/src/main/java/io/netty/util/internal/MathUtil.java" ]
[ "common/src/main/java/io/netty/util/internal/MathUtil.java" ]
[ "common/src/test/java/io/netty/util/internal/MathUtilTest.java" ]
diff --git a/common/src/main/java/io/netty/util/internal/MathUtil.java b/common/src/main/java/io/netty/util/internal/MathUtil.java index 68777e6d8e2..fd8e165eccf 100644 --- a/common/src/main/java/io/netty/util/internal/MathUtil.java +++ b/common/src/main/java/io/netty/util/internal/MathUtil.java @@ -57,11 +57,11 @@ pub...
diff --git a/common/src/test/java/io/netty/util/internal/MathUtilTest.java b/common/src/test/java/io/netty/util/internal/MathUtilTest.java index 32628114dd9..2fd44ced4bc 100644 --- a/common/src/test/java/io/netty/util/internal/MathUtilTest.java +++ b/common/src/test/java/io/netty/util/internal/MathUtilTest.java @@ -68,...
test
test
2021-05-19T16:28:05
2021-05-19T02:27:28Z
laosijikaichele
val
netty/netty/11302_11317
netty/netty
netty/netty/11302
netty/netty/11317
[ "keyword_issue_to_pr" ]
0ff93519a43c7ef1e299f531461a5b665a85f143
f81149324ff42ee375d094b20ac481e40206f678
[ "@mariaccc let me fix this ... ", "Fixed by https://github.com/netty/netty/pull/11317 ... You can workaround it by using:\r\n\r\n```\r\n-Pboringssl\r\n```", "> Fixed by #11317 ... You can workaround it by using:\r\n> \r\n> ```\r\n> -Pboringssl\r\n> ```\r\n\r\nIt works!" ]
[]
2021-05-26T10:21:44Z
[]
Setting up development environment failed on Windows
### Expected behavior Setting up development environment on Windows ### Actual behavior Failure to find io.netty:netty-tcnative:jar:windows-x86_64:2.0.39.Final maven clean install failed ### Steps to reproduce maven clean install -X ### Minimal yet complete reproducer code (or URL to code) ``` [INFO] BUILD FAI...
[ "pom.xml" ]
[ "pom.xml" ]
[]
diff --git a/pom.xml b/pom.xml index fb63f491991..a1282890a47 100644 --- a/pom.xml +++ b/pom.xml @@ -361,6 +361,15 @@ <profile> <id>boringssl</id> + <activation> + <!-- + Automatically active on windows as we only release static boringssl version of + netty-tcnative for windo...
null
train
test
2021-05-26T12:12:11
2021-05-26T02:27:33Z
mariaccc
val
netty/netty/11334_11335
netty/netty
netty/netty/11334
netty/netty/11335
[ "keyword_pr_to_issue" ]
18e92304a700c1b3664f5a3cf24ee3ed58bafbdd
103f1d269ed0e4cb335241286e53973703574626
[ "@liubao68 I think I have found the reason.\r\n\r\n@normanmaurer except a check that was missing in the multipartDecoder, i've found a possible issue while debugging within `UnpooledUnsafeDirectByteBuf` (at least there).\r\nThe reason we did not get this issue before in the Junit test was because the underlying che...
[]
2021-05-29T10:59:02Z
[]
HttpPostMultipartRequestDecoder IndexOutOfBoundsException error with netty 4.1.65.Final
The problem happens when using latests vert.x version. see https://github.com/eclipse-vertx/vert.x/issues/3949 But I guess is a problem with netty. ### Expected behavior Uploading multiple form datas/files will success. ### Actual behavior Fails ramdomly. ### Steps to reproduce See original issue. I hav...
[ "codec-http/src/main/java/io/netty/handler/codec/http/multipart/HttpPostBodyUtil.java" ]
[ "codec-http/src/main/java/io/netty/handler/codec/http/multipart/HttpPostBodyUtil.java" ]
[ "codec-http/src/test/java/io/netty/handler/codec/http/multipart/HttpPostMultiPartRequestDecoderTest.java" ]
diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/multipart/HttpPostBodyUtil.java b/codec-http/src/main/java/io/netty/handler/codec/http/multipart/HttpPostBodyUtil.java index f174327d912..e93dfaf216a 100644 --- a/codec-http/src/main/java/io/netty/handler/codec/http/multipart/HttpPostBodyUtil.java +++ b/...
diff --git a/codec-http/src/test/java/io/netty/handler/codec/http/multipart/HttpPostMultiPartRequestDecoderTest.java b/codec-http/src/test/java/io/netty/handler/codec/http/multipart/HttpPostMultiPartRequestDecoderTest.java index d7d3ab8342b..fb7e08202dd 100644 --- a/codec-http/src/test/java/io/netty/handler/codec/http/...
train
test
2021-05-28T15:03:18
2021-05-29T02:21:26Z
liubao68
val
netty/netty/11357_11358
netty/netty
netty/netty/11357
netty/netty/11358
[ "keyword_pr_to_issue" ]
6621e4a60f24064e8e5757678179056b42a31436
9f8bfa348e5437417cdfce0cd9d5a3c8ecec71a9
[]
[ "Wrong annotation type\r\n```suggestion\r\n @Test\r\n```", "```suggestion\r\n @Test\r\n```" ]
2021-06-03T02:44:28Z
[]
IllegalReferenceCountException with compression enabled but not used if HttpResponse implements HttpContent and not LastHttpContent
Turns out my fix for https://github.com/netty/netty/issues/11092 was incomplete. It fixes the case where the content is compressed, but it will also fail if the client does not specify an Accept-Encoding.
[ "codec-http/src/main/java/io/netty/handler/codec/http/HttpContentEncoder.java" ]
[ "codec-http/src/main/java/io/netty/handler/codec/http/HttpContentEncoder.java" ]
[ "codec-http/src/test/java/io/netty/handler/codec/http/HttpContentCompressorTest.java" ]
diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/HttpContentEncoder.java b/codec-http/src/main/java/io/netty/handler/codec/http/HttpContentEncoder.java index e9c50260f34..49d263655de 100644 --- a/codec-http/src/main/java/io/netty/handler/codec/http/HttpContentEncoder.java +++ b/codec-http/src/main/java...
diff --git a/codec-http/src/test/java/io/netty/handler/codec/http/HttpContentCompressorTest.java b/codec-http/src/test/java/io/netty/handler/codec/http/HttpContentCompressorTest.java index 5663e62ca6e..43184b8b001 100644 --- a/codec-http/src/test/java/io/netty/handler/codec/http/HttpContentCompressorTest.java +++ b/cod...
train
test
2021-06-02T08:41:17
2021-06-03T02:39:29Z
stuartwdouglas
val
netty/netty/11391_11400
netty/netty
netty/netty/11391
netty/netty/11400
[ "keyword_pr_to_issue" ]
8d76f402b1d27eba44cf98877c86128280df4a0a
2abe20a6b5f53a5e8c508b6abb9eeed9562cb5d7
[ "@mostroverkhov SGTM, would you like to send a PR?" ]
[ "nit: using `if (args.length > 3)` will remove redundancy for common arguments:\r\n\r\n```java\r\nif (args.length > 3) {\r\n taskQueueFactory = (EventLoopTaskQueueFactory) args[3];\r\n}\r\nif (args.length > 4) {\r\n tailTaskQueueFactory = (EventLoopTaskQueueFactory) args[4];\r\n}\r\n```", "Javadoc?", "How...
2021-06-18T19:34:31Z
[]
Tail tasks queue: configure separately from tasks queue
IO transports (primarily epoll, but this also applies to kqueue, nio) cant be configured with separate `tail tasks` queue factory - instead single queue factory is used for both normal tasks and tail tasks. Their parent [SingleThreadEventLoop](https://github.com/netty/netty/blob/0d5774a82b470833c5f8a84fa4708142a480...
[ "transport-native-epoll/src/main/java/io/netty/channel/epoll/EpollEventLoop.java", "transport-native-epoll/src/main/java/io/netty/channel/epoll/EpollEventLoopGroup.java", "transport-native-kqueue/src/main/java/io/netty/channel/kqueue/KQueueEventLoop.java", "transport-native-kqueue/src/main/java/io/netty/chann...
[ "transport-native-epoll/src/main/java/io/netty/channel/epoll/EpollEventLoop.java", "transport-native-epoll/src/main/java/io/netty/channel/epoll/EpollEventLoopGroup.java", "transport-native-kqueue/src/main/java/io/netty/channel/kqueue/KQueueEventLoop.java", "transport-native-kqueue/src/main/java/io/netty/chann...
[ "transport-native-epoll/src/test/java/io/netty/channel/epoll/EpollEventLoopTest.java" ]
diff --git a/transport-native-epoll/src/main/java/io/netty/channel/epoll/EpollEventLoop.java b/transport-native-epoll/src/main/java/io/netty/channel/epoll/EpollEventLoop.java index c9cb838ed80..c3b2f6016ac 100644 --- a/transport-native-epoll/src/main/java/io/netty/channel/epoll/EpollEventLoop.java +++ b/transport-nativ...
diff --git a/transport-native-epoll/src/test/java/io/netty/channel/epoll/EpollEventLoopTest.java b/transport-native-epoll/src/test/java/io/netty/channel/epoll/EpollEventLoopTest.java index 02e55fd6aaa..f3d42ae3f24 100644 --- a/transport-native-epoll/src/test/java/io/netty/channel/epoll/EpollEventLoopTest.java +++ b/tra...
train
test
2021-06-30T16:17:57
2021-06-15T18:22:16Z
mostroverkhov
val
netty/netty/11398_11404
netty/netty
netty/netty/11398
netty/netty/11404
[ "keyword_pr_to_issue" ]
0c9a86db812573fbdc9f39b4ec4f29188248ff3a
956e1da2adb597164ff4a69aa19f97e0d7dde0be
[ "@dapengzhang0 ouch... that slipped through. Let me take care. ", "@pmlopes @vietj any idea on how to remove the usage of the annotations and just do everything with config files etc ?", "Also @trustin ", "@normanmaurer Oracle changed the artifact coordinates of the artifacts to https://search.maven.org/artif...
[]
2021-06-21T09:30:18Z
[]
Netty depends on GraalVM which is under GPL license
### Netty version 4.1.63.Final Because Netty started to [depend](https://github.com/netty/netty/blob/netty-4.1.63.Final/common/pom.xml#L42) on [GraalVM](https://search.maven.org/artifact/com.oracle.substratevm/svm/19.2.1/jar) under GPL license, although only annotations are used, we can not update netty version in ...
[ "common/pom.xml", "pom.xml" ]
[ "common/pom.xml", "pom.xml" ]
[ "testsuite-native-image-client-runtime-init/pom.xml", "testsuite-native-image-client/pom.xml", "testsuite-native-image/pom.xml" ]
diff --git a/common/pom.xml b/common/pom.xml index 8c9fd060b63..f812999b52f 100644 --- a/common/pom.xml +++ b/common/pom.xml @@ -39,7 +39,7 @@ <dependencies> <dependency> - <groupId>com.oracle.substratevm</groupId> + <groupId>org.graalvm.nativeimage</groupId> <artifactId>svm</artifactId> ...
diff --git a/testsuite-native-image-client-runtime-init/pom.xml b/testsuite-native-image-client-runtime-init/pom.xml index aaf9bf623f8..c29f9e2e116 100644 --- a/testsuite-native-image-client-runtime-init/pom.xml +++ b/testsuite-native-image-client-runtime-init/pom.xml @@ -59,7 +59,7 @@ <build> <plugins> ...
train
test
2021-06-21T08:54:58
2021-06-17T23:03:21Z
dapengzhang0
val
netty/netty/11393_11457
netty/netty
netty/netty/11393
netty/netty/11457
[ "keyword_pr_to_issue" ]
0b2e955aff1555616e0d5b1d5047f1737347bdfe
ede7a604f185cd716032ecbb356b6ea5130f7d0d
[ "Enum sounds like a good idea. \r\n\r\n@normanmaurer WDYT? I can do a PR.", "Following the pattern of `ApplicationProtocolNames`[1] will keep it consistent, i.e. define a class containing the constants for the names instead of a java enum.\r\n\r\n[1] https://github.com/netty/netty/blob/4.1/handler/src/main/java/i...
[ "I think we should add `@Deprecated` annotations on the protocols that aren't TLS v1.2 or TLS v1.3. Use of those older protocols is discouraged now a days, as far as I understand.", "Are there any of these that should be discouraged?", "Cipher comes below SSL/TLS protocols. If we deprecate them then ciphers wil...
2021-07-06T15:32:36Z
[]
No constant for ssl protocol selection
This is a minor issue but one that I think would be easy to fix. Please educate me if there's a complexity or nuance that I'm not seeing. Netty lets the user choose the tls version. ``` clientSslContext = SslContextBuilder .forClient() .protocols("TSLv1.3") ...
[ "handler/src/main/java/io/netty/handler/ssl/JdkSslContext.java", "handler/src/main/java/io/netty/handler/ssl/OpenSsl.java", "handler/src/main/java/io/netty/handler/ssl/OpenSslTlsv13X509ExtendedTrustManager.java", "handler/src/main/java/io/netty/handler/ssl/ReferenceCountedOpenSslEngine.java", "handler/src/m...
[ "handler/src/main/java/io/netty/handler/ssl/Ciphers.java", "handler/src/main/java/io/netty/handler/ssl/JdkSslContext.java", "handler/src/main/java/io/netty/handler/ssl/OpenSsl.java", "handler/src/main/java/io/netty/handler/ssl/OpenSslTlsv13X509ExtendedTrustManager.java", "handler/src/main/java/io/netty/hand...
[ "handler/src/test/java/io/netty/handler/ssl/CipherSuiteCanaryTest.java", "handler/src/test/java/io/netty/handler/ssl/CloseNotifyTest.java", "handler/src/test/java/io/netty/handler/ssl/DelegatingSslContextTest.java", "handler/src/test/java/io/netty/handler/ssl/JdkSslEngineTest.java", "handler/src/test/java/i...
diff --git a/handler/src/main/java/io/netty/handler/ssl/Ciphers.java b/handler/src/main/java/io/netty/handler/ssl/Ciphers.java new file mode 100644 index 00000000000..caa390a447e --- /dev/null +++ b/handler/src/main/java/io/netty/handler/ssl/Ciphers.java @@ -0,0 +1,758 @@ +/* + * Copyright 2021 The Netty Project + * + ...
diff --git a/handler/src/test/java/io/netty/handler/ssl/CipherSuiteCanaryTest.java b/handler/src/test/java/io/netty/handler/ssl/CipherSuiteCanaryTest.java index ff491d3a734..9b7398ba5ef 100644 --- a/handler/src/test/java/io/netty/handler/ssl/CipherSuiteCanaryTest.java +++ b/handler/src/test/java/io/netty/handler/ssl/Ci...
train
test
2021-07-07T08:26:27
2021-06-16T15:52:50Z
danielbaniel
val
netty/netty/11568_11569
netty/netty
netty/netty/11568
netty/netty/11569
[ "keyword_pr_to_issue" ]
3f8dab5ad00a718dc8ad6c00e27b740783ea23c5
056eba4db4c1b466d6b45d261642a6aa6134fe38
[ "Work around can be fond in #11267\r\nImplement your own `shouldHandleUpgradeRequest`, and check `connection` header there.", "@dpy1123 Yeah, a missing `isEmpty()` looks about right. Would you like to make a PR for this?" ]
[ "Add a call to `ReferenceCountUtil.release(req)` to prevent the contained buffer from leaking." ]
2021-08-11T08:41:42Z
[]
HttpServerUpgradeHandler causing StringIndexOutOfBoundsException
We are using netty as a proxy server. And added HttpServerUpgradeHandler incase client wants to talk in h2c. But with a normal http1 request, we see the following exceptions. ```io.netty.handler.codec.DecoderException: java.lang.StringIndexOutOfBoundsException: String index out of range: -1 at io.netty.handler.co...
[ "codec-http/src/main/java/io/netty/handler/codec/http/HttpServerUpgradeHandler.java" ]
[ "codec-http/src/main/java/io/netty/handler/codec/http/HttpServerUpgradeHandler.java" ]
[ "codec-http/src/test/java/io/netty/handler/codec/http/HttpServerUpgradeHandlerTest.java" ]
diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/HttpServerUpgradeHandler.java b/codec-http/src/main/java/io/netty/handler/codec/http/HttpServerUpgradeHandler.java index 88aa739b298..2aa6e157d56 100644 --- a/codec-http/src/main/java/io/netty/handler/codec/http/HttpServerUpgradeHandler.java +++ b/codec-...
diff --git a/codec-http/src/test/java/io/netty/handler/codec/http/HttpServerUpgradeHandlerTest.java b/codec-http/src/test/java/io/netty/handler/codec/http/HttpServerUpgradeHandlerTest.java index bc4552afb4f..a2e27e787f6 100644 --- a/codec-http/src/test/java/io/netty/handler/codec/http/HttpServerUpgradeHandlerTest.java ...
val
test
2021-08-10T19:53:15
2021-08-11T07:01:18Z
dpy1123
val
netty/netty/11567_11609
netty/netty
netty/netty/11567
netty/netty/11609
[ "keyword_pr_to_issue" ]
9d25bc8a4e222ae7b938f1d90829d29e12b810c4
5e7eb3748daaf68a85616bad283489a59b44c4b7
[ "@jameskleeh I am currently not sure how to do this as the user can either use `netty-tcnative` or `netty-tcnative-boringssl-static`. Or you are saying we should add both ?", "Yeah I think both", "@jameskleeh want to provide a PR ?", "Sure", "@jameskleeh ping me once something is ready for review ", "@jam...
[ "Should the `dependencyManagement` section here list all other artifacts produced by tcnative, like `netty-tcnative-openssl-static`, etc.? ", "Can netty use `netty-bom-ssl` instead of defining another constant for that?", "We only publish a static artifact for boringssl ", "I think this not works .. what exac...
2021-08-23T13:34:06Z
[]
Module compatibility
Netty 4.1.66 introduced a requirement on tc-native 2.0.40 with this commit https://github.com/netty/netty/commit/40fb6026efd2a9fc67049b437e4db5d6d81d688c This led to a user being confronted with an error after upgrading Micronaut (which includes 4.1.66) https://github.com/micronaut-projects/micronaut-core/issues/592...
[ "bom/pom.xml" ]
[ "bom/pom.xml" ]
[]
diff --git a/bom/pom.xml b/bom/pom.xml index 429c477cffe..e05844a8d51 100644 --- a/bom/pom.xml +++ b/bom/pom.xml @@ -253,6 +253,60 @@ <version>4.1.68.Final-SNAPSHOT</version> <classifier>osx-x86_64</classifier> </dependency> + + <!-- Add netty-tcnative* as well as users need to ensure they...
null
train
test
2021-08-20T19:10:54
2021-08-10T18:35:12Z
jameskleeh
val
netty/netty/11618_11621
netty/netty
netty/netty/11618
netty/netty/11621
[ "keyword_pr_to_issue" ]
6a7cccded07a46a0a7b50ac27ff3f86eb977859f
47bababfc718eaa676212f39d547dc8aefb1683b
[ "@violetagg sounds like a bug... want to provide a PR ?", "@normanmaurer yep let me do that" ]
[ "Looks like `diskAttribute.addContent()` may throw below in which case we may not release the `buffer`. I would suggest put a `try-catch(Exception)` in these methods before we assign `buffer` to an instance variable. This will make sure we release for any unexpected errors.", "mmm DiskAttribute itself releases?\r...
2021-08-26T12:14:27Z
[]
Memory leak in HttpPostMultipartRequestDecoder#loadDataMultipartOptimized
### Expected behavior No memory leak ### Actual behavior There is a memory leak in `io.netty.handler.codec.http.multipart.HttpPostMultipartRequestDecoder#loadDataMultipartOptimized` when the size exceeds `maxLimit`. Or the issue might be related to `io.netty.handler.codec.http.multipart.AbstractMemoryHttpData#add...
[ "codec-http/src/main/java/io/netty/handler/codec/http/multipart/AbstractMemoryHttpData.java", "codec-http/src/main/java/io/netty/handler/codec/http/multipart/DiskAttribute.java", "codec-http/src/main/java/io/netty/handler/codec/http/multipart/HttpData.java", "codec-http/src/main/java/io/netty/handler/codec/ht...
[ "codec-http/src/main/java/io/netty/handler/codec/http/multipart/AbstractMemoryHttpData.java", "codec-http/src/main/java/io/netty/handler/codec/http/multipart/DiskAttribute.java", "codec-http/src/main/java/io/netty/handler/codec/http/multipart/HttpData.java", "codec-http/src/main/java/io/netty/handler/codec/ht...
[ "codec-http/src/test/java/io/netty/handler/codec/http/multipart/HttpDataTest.java" ]
diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/multipart/AbstractMemoryHttpData.java b/codec-http/src/main/java/io/netty/handler/codec/http/multipart/AbstractMemoryHttpData.java index dc8dd02f1fa..f25801bd504 100644 --- a/codec-http/src/main/java/io/netty/handler/codec/http/multipart/AbstractMemoryHt...
diff --git a/codec-http/src/test/java/io/netty/handler/codec/http/multipart/HttpDataTest.java b/codec-http/src/test/java/io/netty/handler/codec/http/multipart/HttpDataTest.java new file mode 100644 index 00000000000..17f90e70fa3 --- /dev/null +++ b/codec-http/src/test/java/io/netty/handler/codec/http/multipart/HttpData...
train
test
2021-08-26T11:19:11
2021-08-25T19:00:19Z
violetagg
val
netty/netty/11360_11626
netty/netty
netty/netty/11360
netty/netty/11626
[ "keyword_pr_to_issue" ]
88fcb5124b6d2fbe117e5cad66a4b50ab46c4a7a
7b8050ae5348d9de2a8b27590994046552cd4916
[]
[]
2021-08-30T06:25:59Z
[]
Support for "RSASSA-PSS" algorithm
Hi, While we are trying to validate a user certificate that is generated using the RSASSA-PSS algorithm. Netty OpenSSL engine is throwing an exception "sun.security.validator.ValidatorException: Certificate signature algorithm disabled" ### Actual behavior As the OpenSSL is supporting this algorithm now. So in N...
[ "handler/src/main/java/io/netty/handler/ssl/ExtendedOpenSslSession.java" ]
[ "handler/src/main/java/io/netty/handler/ssl/ExtendedOpenSslSession.java", "handler/src/test/resources/io/netty/handler/ssl/rsapss-signing-ext.txt" ]
[ "handler/src/test/java/io/netty/handler/ssl/ConscryptOpenSslEngineInteropTest.java", "handler/src/test/java/io/netty/handler/ssl/ConscryptSslEngineTest.java", "handler/src/test/java/io/netty/handler/ssl/JdkConscryptSslEngineInteropTest.java", "handler/src/test/java/io/netty/handler/ssl/JdkOpenSslEngineInterop...
diff --git a/handler/src/main/java/io/netty/handler/ssl/ExtendedOpenSslSession.java b/handler/src/main/java/io/netty/handler/ssl/ExtendedOpenSslSession.java index 963a9b616ab..5924325893d 100644 --- a/handler/src/main/java/io/netty/handler/ssl/ExtendedOpenSslSession.java +++ b/handler/src/main/java/io/netty/handler/ssl...
diff --git a/handler/src/test/java/io/netty/handler/ssl/ConscryptOpenSslEngineInteropTest.java b/handler/src/test/java/io/netty/handler/ssl/ConscryptOpenSslEngineInteropTest.java index 8084220ca30..9800c21e76a 100644 --- a/handler/src/test/java/io/netty/handler/ssl/ConscryptOpenSslEngineInteropTest.java +++ b/handler/s...
test
test
2021-08-26T21:53:07
2021-06-03T05:11:21Z
kushalagrawal
val
netty/netty/11655_11656
netty/netty
netty/netty/11655
netty/netty/11656
[ "keyword_pr_to_issue" ]
21fb48e4d22b5d030b165200e663c11f545f5576
a329857ec20cc1b93ceead6307c6849f93b3f101
[]
[ "revert ?", "Not here... add it to `CipherSuiteConverter `", "sorry, didn't understand this point. Failure which I see in the last build is : \r\n```\r\nFailures: \r\n2021-09-04T19:13:09.0782449Z [ERROR] JdkOpenSslEngineInteroptTest.testMutualAuthDiffCerts:78->SSLEngineTest.testMutualAuthDiffCerts:633->SSLEng...
2021-09-04T11:09:12Z
[]
ability to CipherSuitesConverter outside of the io.netty.handler.ssl
In our use case, we are required to convert the java cipher suites are required to be converted to Openssl. I found that netty already has a `CipherSuitesConverter`. As we are already using netty, we could have reused the class if it was not made the package private. IMO it would be no harm if we make it public to be u...
[ "handler/src/main/java/io/netty/handler/ssl/CipherSuiteConverter.java" ]
[ "handler/src/main/java/io/netty/handler/ssl/CipherSuiteConverter.java" ]
[]
diff --git a/handler/src/main/java/io/netty/handler/ssl/CipherSuiteConverter.java b/handler/src/main/java/io/netty/handler/ssl/CipherSuiteConverter.java index 2dd81371adb..a9ac8307c1d 100644 --- a/handler/src/main/java/io/netty/handler/ssl/CipherSuiteConverter.java +++ b/handler/src/main/java/io/netty/handler/ssl/Ciphe...
null
test
test
2021-09-05T20:05:15
2021-09-04T10:57:07Z
kushalagrawal
val
netty/netty/11652_11663
netty/netty
netty/netty/11652
netty/netty/11663
[ "keyword_pr_to_issue" ]
a329857ec20cc1b93ceead6307c6849f93b3f101
a53eb80901b8bf678e2ff65e4715d25c4fec638c
[ "Sounds good . Will provide more feedback on the PR" ]
[]
2021-09-07T17:01:45Z
[]
Issues on UDS path binding
I think there are couple issues relate to the UDS path binding logic: 1. In the JNI `netty_unix_socket_bindDomainSocket` method, when the upper level passes in a [longer-than-limit UDS path](https://github.com/netty/netty/blob/d58d8a1df832a5185193368e589cb4a488709ffe/transport-native-unix-common/src/main/c/netty_uni...
[ "transport-native-unix-common/src/main/c/netty_unix_socket.c" ]
[ "transport-native-unix-common/src/main/c/netty_unix_socket.c" ]
[ "transport-native-epoll/src/test/java/io/netty/channel/epoll/LinuxSocketTest.java" ]
diff --git a/transport-native-unix-common/src/main/c/netty_unix_socket.c b/transport-native-unix-common/src/main/c/netty_unix_socket.c index 2524b412209..a6cd08f3086 100644 --- a/transport-native-unix-common/src/main/c/netty_unix_socket.c +++ b/transport-native-unix-common/src/main/c/netty_unix_socket.c @@ -764,12 +764...
diff --git a/transport-native-epoll/src/test/java/io/netty/channel/epoll/LinuxSocketTest.java b/transport-native-epoll/src/test/java/io/netty/channel/epoll/LinuxSocketTest.java index ff85d3ac12c..9f16b2bfbfe 100644 --- a/transport-native-epoll/src/test/java/io/netty/channel/epoll/LinuxSocketTest.java +++ b/transport-na...
val
test
2021-09-06T14:57:19
2021-09-02T23:10:55Z
ran-su
val
netty/netty/11637_11667
netty/netty
netty/netty/11637
netty/netty/11667
[ "keyword_pr_to_issue" ]
a0c9b2f9e15112cb52001f26fa3cb6772f53d674
4377ece51640fe0eb0b21fac512a86443cf409ab
[ "For the heap _in general_, the free memory on the heap is not the same as the amount of memory that could be freed if the GC was to do a run, so we can only realistically do this for direct memory where we have precise accounting of what memory is in use and what is not. But then there's also fragmentation; having...
[]
2021-09-08T14:10:42Z
[]
Add support getting the pooled memory size for each PooledByteBufAllocator instance
### Motivation Our server has its own implementation to decide whether to provide service for users according to the real-time total free memory of the heap memory and the direct memory (mainly the memory used by `io.netty.buffer.PooledByteBufAllocator` for our server). If our server detects it's running out of physic...
[ "buffer/src/main/java/io/netty/buffer/PoolArena.java", "buffer/src/main/java/io/netty/buffer/PoolChunk.java", "buffer/src/main/java/io/netty/buffer/PooledByteBufAllocator.java" ]
[ "buffer/src/main/java/io/netty/buffer/PoolArena.java", "buffer/src/main/java/io/netty/buffer/PoolChunk.java", "buffer/src/main/java/io/netty/buffer/PooledByteBufAllocator.java" ]
[ "buffer/src/test/java/io/netty/buffer/AbstractByteBufAllocatorTest.java", "buffer/src/test/java/io/netty/buffer/PooledByteBufAllocatorTest.java" ]
diff --git a/buffer/src/main/java/io/netty/buffer/PoolArena.java b/buffer/src/main/java/io/netty/buffer/PoolArena.java index fba1127b5d7..beff6e115bd 100644 --- a/buffer/src/main/java/io/netty/buffer/PoolArena.java +++ b/buffer/src/main/java/io/netty/buffer/PoolArena.java @@ -455,6 +455,22 @@ public long numActiveBytes...
diff --git a/buffer/src/test/java/io/netty/buffer/AbstractByteBufAllocatorTest.java b/buffer/src/test/java/io/netty/buffer/AbstractByteBufAllocatorTest.java index e2f3ab72ef3..e6e064b40cc 100644 --- a/buffer/src/test/java/io/netty/buffer/AbstractByteBufAllocatorTest.java +++ b/buffer/src/test/java/io/netty/buffer/Abstr...
test
test
2021-09-09T15:08:08
2021-08-31T20:26:19Z
JamesChenX
val
netty/netty/11700_11706
netty/netty
netty/netty/11700
netty/netty/11706
[ "keyword_issue_to_pr", "keyword_pr_to_issue" ]
23405e2000427e9cad104913e7071d8d08e91a3c
83278c50005cfa58762167505aa9be8f19814433
[ "Actually your this test has bug in line 26, 27.", "> Actually your this test has bug in line 26, 27.\r\n\r\n@forchid The test where line 26 and 27 are is passing. What bug does it have? The issue is that the other test is failing.", "> The test where line 26 and 27 are is passing. What bug does it have? The i...
[]
2021-09-23T11:47:19Z
[]
ByteBuf.order() seems to have wrong behavior
Found unexpected behavior when calling ```java Unpooled.buffer(1024).order(ByteOrder.LITTLE_ENDIAN).writeShortLE(message) ``` since netty 4.1.54.Final. The `order()` method has already been deprecated, but nevertheless it shouldn't be broken. ### Expected behavior Test passes ### Actual behavior Te...
[ "buffer/src/main/java/io/netty/buffer/ByteBufUtil.java", "buffer/src/main/java/io/netty/buffer/SwappedByteBuf.java", "handler/src/main/java/io/netty/handler/ssl/SslUtils.java" ]
[ "buffer/src/main/java/io/netty/buffer/ByteBufUtil.java", "buffer/src/main/java/io/netty/buffer/SwappedByteBuf.java", "handler/src/main/java/io/netty/handler/ssl/SslUtils.java" ]
[ "buffer/src/test/java/io/netty/buffer/AbstractByteBufTest.java", "buffer/src/test/java/io/netty/buffer/UnpooledTest.java" ]
diff --git a/buffer/src/main/java/io/netty/buffer/ByteBufUtil.java b/buffer/src/main/java/io/netty/buffer/ByteBufUtil.java index 7f7a4902cc3..68a0ab5aaa0 100644 --- a/buffer/src/main/java/io/netty/buffer/ByteBufUtil.java +++ b/buffer/src/main/java/io/netty/buffer/ByteBufUtil.java @@ -474,7 +474,7 @@ private static long...
diff --git a/buffer/src/test/java/io/netty/buffer/AbstractByteBufTest.java b/buffer/src/test/java/io/netty/buffer/AbstractByteBufTest.java index c61dd334d16..6a2c98fbdf6 100644 --- a/buffer/src/test/java/io/netty/buffer/AbstractByteBufTest.java +++ b/buffer/src/test/java/io/netty/buffer/AbstractByteBufTest.java @@ -594...
train
test
2021-09-22T08:39:24
2021-09-21T19:09:38Z
dapengzhang0
val
netty/netty/11701_11722
netty/netty
netty/netty/11701
netty/netty/11722
[ "keyword_pr_to_issue" ]
4a1297ffc2124b2266fbea295e406e31c2140993
f87abab779613cbe730fc0fa8fd32fa7c90609d1
[ "The binary compatibility baseline for our native code is the GLIBC version that's used on CentOS 6. The work-around is to use the Nio transport.\r\n\r\nIt's not clear from the error reports how this is really showing up. If it's an ABI problem, then I'm not sure what we can do to mitigate it. If we are calling gli...
[ "either we should rename the variable or rename the property", "nit: we could just move the whole `throw` in the if block that is contained in the while loop and so get rid of the boolean at all." ]
2021-09-29T17:32:58Z
[]
Throwing an exception in case glibc is missing instead of segfaulting the JVM
It seems Netty's native support depends on glibc (btw is this documented?). When glibc is missing (for example using vanilla Alpine), the JVM could end up with a crash (`SIGSEGV`), see details in this issue: https://github.com/micrometer-metrics/micrometer/issues/2776 It also seems that `Epoll.isAvailable()` return...
[ "transport-native-epoll/src/main/c/netty_epoll_native.c", "transport-native-epoll/src/main/java/io/netty/channel/epoll/Native.java", "transport-native-epoll/src/main/java/io/netty/channel/epoll/NativeStaticallyReferencedJniMethods.java" ]
[ "transport-native-epoll/src/main/c/netty_epoll_native.c", "transport-native-epoll/src/main/java/io/netty/channel/epoll/Native.java", "transport-native-epoll/src/main/java/io/netty/channel/epoll/NativeStaticallyReferencedJniMethods.java" ]
[]
diff --git a/transport-native-epoll/src/main/c/netty_epoll_native.c b/transport-native-epoll/src/main/c/netty_epoll_native.c index 5fed0889596..531d13879b8 100644 --- a/transport-native-epoll/src/main/c/netty_epoll_native.c +++ b/transport-native-epoll/src/main/c/netty_epoll_native.c @@ -326,6 +326,7 @@ static jint net...
null
val
test
2021-09-29T16:55:36
2021-09-22T02:15:46Z
jonatan-ivanov
val
netty/netty/11784_11793
netty/netty
netty/netty/11784
netty/netty/11793
[ "keyword_pr_to_issue" ]
77b7c1a56dcd4fc964137f21caf321a1ca19c0ed
3a1fb3f10df18eece68e88a86d4561fdd1b7723a
[ "Hi @wo883721 \r\n\r\nI read through the snippet you posted, but I don't see the issue. Can you explain a bit more?", "@chrisvest \r\nI don't understand，Why can this method change the value of `writerIndex`?\r\n\r\n`setCharSequence` method implementation\r\n```\r\n public int setCharSequence(int index, CharS...
[]
2021-10-25T08:51:56Z
[]
It has a problem that setCharSequence method description at ByteBuf.class
This is just a minor problem，I found that setCharSequence method description at ByteBuf.class。 ``` /** * Writes the specified {@link CharSequence} at the current {@code writerIndex} and increases * the {@code writerIndex} by the written bytes. * * @param index on which the sequence should ...
[ "buffer/src/main/java/io/netty/buffer/ByteBuf.java" ]
[ "buffer/src/main/java/io/netty/buffer/ByteBuf.java" ]
[]
diff --git a/buffer/src/main/java/io/netty/buffer/ByteBuf.java b/buffer/src/main/java/io/netty/buffer/ByteBuf.java index fef30f125ae..908e110a57f 100644 --- a/buffer/src/main/java/io/netty/buffer/ByteBuf.java +++ b/buffer/src/main/java/io/netty/buffer/ByteBuf.java @@ -1338,15 +1338,15 @@ public ByteBuf setDoubleLE(int ...
null
val
test
2021-10-15T15:18:48
2021-10-21T08:54:57Z
wo883721
val
netty/netty/10821_11858
netty/netty
netty/netty/10821
netty/netty/11858
[ "connected" ]
2b4ac369669116d152ec8893910a04cdf4d94c65
40196a6305f7bfb5a3490196360b0862c9a0470d
[ "Is this reproducible for you ?", "Also I wonder if there was another exception before this as well .", "We are not able to reproduce this behavior. There was no other exception thrown before this.", "I was not able to spot any bug yet :/ ", "We saw this issue re-occur with the same exact stack trace. There...
[ "why not using a mpsc unbounded queue from JCTools here?\r\n\r\n`claim()` is supposed to be called by the same thread (and its corresponding drain too), while filling it could happen from several threads; it looks an easy way to save using synchronization\r\n\r\n", "draining inbox would worth if there isn't anyth...
2021-11-24T17:06:09Z
[]
ArrayIndexOutOfBoundsException With PooledByteBufAllocator Recycler implementaion
### Issue Description While trying to write an HttpMessage using HTTP1 with HttpClientCodec i.e HttpObjectEncoder, Netty is throwing an ArrayIndexOutOfBounds Exception while trying to allocate buffer for headers. Exception seems to be happening in the PooledByteBufAllocator Recycler Implementation. ``` Caused b...
[ "common/src/main/java/io/netty/util/Recycler.java", "common/src/main/java/io/netty/util/internal/PlatformDependent.java" ]
[ "common/src/main/java/io/netty/util/Recycler.java", "common/src/main/java/io/netty/util/internal/PlatformDependent.java", "microbench/src/main/java/io/netty/microbench/util/RecyclerBenchmark.java" ]
[ "common/src/test/java/io/netty/util/RecyclerTest.java" ]
diff --git a/common/src/main/java/io/netty/util/Recycler.java b/common/src/main/java/io/netty/util/Recycler.java index eec543f2d22..373a79251b4 100644 --- a/common/src/main/java/io/netty/util/Recycler.java +++ b/common/src/main/java/io/netty/util/Recycler.java @@ -13,23 +13,18 @@ * License for the specific language g...
diff --git a/common/src/test/java/io/netty/util/RecyclerTest.java b/common/src/test/java/io/netty/util/RecyclerTest.java index 5d50e5981d1..76fdd465f32 100644 --- a/common/src/test/java/io/netty/util/RecyclerTest.java +++ b/common/src/test/java/io/netty/util/RecyclerTest.java @@ -28,6 +28,7 @@ import java.util.concurr...
val
test
2021-11-24T08:45:19
2020-11-24T23:44:44Z
patel-bhavik
val
netty/netty/11890_11891
netty/netty
netty/netty/11890
netty/netty/11891
[ "keyword_pr_to_issue" ]
1e189654f913b13be3616c552a04459465b752b3
d80a34ecf84bbe153b60123b059deabcc97a8935
[]
[ "```suggestion\r\n heapBuf = ctx.alloc().heapBuffer(len, len);\r\n```", "Please revert the formatting changes. ", "please revert formatting changes", "please revert formatting changes", "make this final and assign in the `if / else ` blocks", "Thank you; done.", "@normanmaurer ,\r\n> make...
2021-12-04T20:02:07Z
[]
JdkZlibEncoder: heap allocated arrays for deflater input generate memory pressure under load
### Expected behavior I am writing a high-throughput client for a custom protocol over TCP; the protocol has the option of compressing contents using zlib encoding, In order to reach performance targets I accumulate encoded frames into batches stored in off-heap pooled ByteBufs and then write the contents to the N...
[ "codec/src/main/java/io/netty/handler/codec/compression/JdkZlibEncoder.java" ]
[ "codec/src/main/java/io/netty/handler/codec/compression/JdkZlibEncoder.java" ]
[]
diff --git a/codec/src/main/java/io/netty/handler/codec/compression/JdkZlibEncoder.java b/codec/src/main/java/io/netty/handler/codec/compression/JdkZlibEncoder.java index 08292ef9546..892f6ccf3d3 100644 --- a/codec/src/main/java/io/netty/handler/codec/compression/JdkZlibEncoder.java +++ b/codec/src/main/java/io/netty/h...
null
train
test
2021-12-03T10:00:11
2021-12-04T19:54:48Z
dferstay
val
netty/netty/11661_11922
netty/netty
netty/netty/11661
netty/netty/11922
[ "keyword_pr_to_issue" ]
cccce01497db4ac33b412dfb60630fc5ab443ce1
ea6d48320a007d403c8245bc548c1dd9c5f54e11
[ "Sounds good! Can you do a PR?", "Careful with the current JDK `WatchService` as it will miss changes if the file is _bind mounted_. In container based productions this is likely `/etc/hosts` is bind mounted.\r\n\r\nI wrote a bit a few years ago : https://blog.arkey.fr/2019/09/13/watchservice-and-bind-mount/", ...
[ "Honestly I think every 10 seconds might be a bit aggressive... What about 60 seconds as default + maybe a system property to change it . ", "please don't use wildcard imports ", "all of these can be static ", "nit: remove the public keyword ", "I just wanted to add the question as a separate comment, didn'...
2021-12-14T15:40:39Z
[ "help wanted" ]
The resolver does not re-read /etc/hosts upon change
### Expected behavior When /etc/hosts is changed, the netty resolver should re-read it. ### Actual behavior io.netty.resolver.DefaultHostsFileEntriesResolver parses /etc/hosts only once, upon creation. ### Netty version 4.1.67 ### JVM version (e.g. `java -version`) any ### OS version (e.g. `uname -a`) ...
[ "resolver/src/main/java/io/netty/resolver/DefaultHostsFileEntriesResolver.java" ]
[ "resolver/src/main/java/io/netty/resolver/DefaultHostsFileEntriesResolver.java" ]
[ "resolver/src/test/java/io/netty/resolver/DefaultHostsFileEntriesResolverTest.java" ]
diff --git a/resolver/src/main/java/io/netty/resolver/DefaultHostsFileEntriesResolver.java b/resolver/src/main/java/io/netty/resolver/DefaultHostsFileEntriesResolver.java index 378fd98d87e..d48fe096c37 100644 --- a/resolver/src/main/java/io/netty/resolver/DefaultHostsFileEntriesResolver.java +++ b/resolver/src/main/jav...
diff --git a/resolver/src/test/java/io/netty/resolver/DefaultHostsFileEntriesResolverTest.java b/resolver/src/test/java/io/netty/resolver/DefaultHostsFileEntriesResolverTest.java index b9e8c25ea41..794d2566a0b 100644 --- a/resolver/src/test/java/io/netty/resolver/DefaultHostsFileEntriesResolverTest.java +++ b/resolver/...
val
test
2021-12-13T11:50:02
2021-09-07T13:38:33Z
gbrdead
val
netty/netty/11965_11966
netty/netty
netty/netty/11965
netty/netty/11966
[ "keyword_pr_to_issue" ]
9ab5e9180253e85eacdb978d436c087615c6e3b1
1cbd3afcdec9591b477ccddc3173afd7b30b7df5
[]
[ "```suggestion\r\n private boolean selfFiredChannelRead;\r\n```", "This is not needed at all. Please remove ", "```suggestion\r\n assertFalse(channel.writeInbound(Unpooled.wrappedBuffer(new byte[]{1})));\r\n```", "```suggestion\r\n assertEquals(0, interceptor.readsTriggered);\r\n asser...
2022-01-02T13:29:06Z
[]
WebSocket server loss one frame, maybe caused by ByteToMessageDecoder trigger a unexpected read() when readCompleted fired
We're creating a relay-like application with WebSocket. When the WebSocket client sends an upgrade request to the server, the server sets the channel's autoRead to false (or config child channel autoRead to false, and manually trigger first read()). When the upstream connection is ready (which is started by another typ...
[ "codec/src/main/java/io/netty/handler/codec/ByteToMessageDecoder.java" ]
[ "codec/src/main/java/io/netty/handler/codec/ByteToMessageDecoder.java" ]
[ "codec/src/test/java/io/netty/handler/codec/ByteToMessageDecoderTest.java" ]
diff --git a/codec/src/main/java/io/netty/handler/codec/ByteToMessageDecoder.java b/codec/src/main/java/io/netty/handler/codec/ByteToMessageDecoder.java index f83209855d9..523aa4700d6 100644 --- a/codec/src/main/java/io/netty/handler/codec/ByteToMessageDecoder.java +++ b/codec/src/main/java/io/netty/handler/codec/ByteT...
diff --git a/codec/src/test/java/io/netty/handler/codec/ByteToMessageDecoderTest.java b/codec/src/test/java/io/netty/handler/codec/ByteToMessageDecoderTest.java index 10d4f2f56cc..9f9dac49630 100644 --- a/codec/src/test/java/io/netty/handler/codec/ByteToMessageDecoderTest.java +++ b/codec/src/test/java/io/netty/handler...
train
test
2021-12-27T11:00:36
2022-01-02T11:38:50Z
alex-lx
val
netty/netty/11963_11970
netty/netty
netty/netty/11963
netty/netty/11970
[ "keyword_pr_to_issue" ]
bdcf3988c20c9c0dae92850b36ae63d5ddc5b502
195b84910644e51f2323a30d55704f0e361fdcd8
[ "Thanks for the report, preparing a fix.", "good", "this is `ByteBuf` feature,`readByte()` make readIndex + 1,so the first index is `P` rather than `+`." ]
[]
2022-01-05T00:59:30Z
[]
the result of `ByteBufUtil.indexOf(ByteBuf needle, ByteBuf haystack)` wrong
### Expected behavior ``` ByteBuf haystack = Unpooled.copiedBuffer("+PONG\r\n", CharsetUtil.UTF_8); ByteBuf needle = Unpooled.copiedBuffer("\r\n", CharsetUtil.UTF_8); haystack.readByte(); int index = ByteBufUtil.indexOf(needle ,haystack); System.out.println(index); ```...
[ "buffer/src/main/java/io/netty/buffer/ByteBufUtil.java" ]
[ "buffer/src/main/java/io/netty/buffer/ByteBufUtil.java" ]
[ "buffer/src/test/java/io/netty/buffer/ByteBufUtilTest.java" ]
diff --git a/buffer/src/main/java/io/netty/buffer/ByteBufUtil.java b/buffer/src/main/java/io/netty/buffer/ByteBufUtil.java index 68a0ab5aaa0..8636d539553 100644 --- a/buffer/src/main/java/io/netty/buffer/ByteBufUtil.java +++ b/buffer/src/main/java/io/netty/buffer/ByteBufUtil.java @@ -279,7 +279,7 @@ public static int i...
diff --git a/buffer/src/test/java/io/netty/buffer/ByteBufUtilTest.java b/buffer/src/test/java/io/netty/buffer/ByteBufUtilTest.java index c872b2c4e1d..fbf106c4e2b 100644 --- a/buffer/src/test/java/io/netty/buffer/ByteBufUtilTest.java +++ b/buffer/src/test/java/io/netty/buffer/ByteBufUtilTest.java @@ -132,13 +132,13 @@ p...
train
test
2022-01-04T21:43:18
2021-12-30T13:46:33Z
shichaoyuan
val
netty/netty/11981_11982
netty/netty
netty/netty/11981
netty/netty/11982
[ "keyword_pr_to_issue" ]
bd7e0f72bdcae09beccb42f0562a862caaf8c89e
d60ea595bcd2399530d8becbced45df0b9b22aa5
[]
[ "Can we just use no codec for this test ?", "Please follow the same structure for tests as the rest of the file. This ensures the test will be run for NIO,OIO,Epoll and Kqueue. I suspect the same fix will need to go there as well. ", "Like said above there is no need to use a codec here. ", "Use an CountdownL...
2022-01-08T12:47:10Z
[]
[bug] when SO_LINGGER is used in the TCP half-closed scenario, the client in the fin_wait2 state cannot receive the data sent from the server which is in the close_wait state
![SO_LINGERHalfClosureBug](https://user-images.githubusercontent.com/5794695/148641718-987a2774-6d10-4400-8d32-c14feaa0417b.png) as shown in the picture above。 **when `SO_LINGGER` is used in the client side**, and client call `NioSocketChannel#shutdownOutput()` to **half close** the tcp connection。 then server...
[ "transport/src/main/java/io/netty/channel/AbstractChannel.java" ]
[ "transport/src/main/java/io/netty/channel/AbstractChannel.java" ]
[ "testsuite/src/main/java/io/netty/testsuite/transport/socket/SocketHalfClosedTest.java" ]
diff --git a/transport/src/main/java/io/netty/channel/AbstractChannel.java b/transport/src/main/java/io/netty/channel/AbstractChannel.java index 5aa2ab92db0..887a3e3c66e 100644 --- a/transport/src/main/java/io/netty/channel/AbstractChannel.java +++ b/transport/src/main/java/io/netty/channel/AbstractChannel.java @@ -650...
diff --git a/testsuite/src/main/java/io/netty/testsuite/transport/socket/SocketHalfClosedTest.java b/testsuite/src/main/java/io/netty/testsuite/transport/socket/SocketHalfClosedTest.java index f2d6466dc6f..8e90217372a 100644 --- a/testsuite/src/main/java/io/netty/testsuite/transport/socket/SocketHalfClosedTest.java +++...
train
test
2022-01-07T13:58:14
2022-01-08T12:41:33Z
huibinliupush
val
netty/netty/11984_11990
netty/netty
netty/netty/11984
netty/netty/11990
[ "keyword_pr_to_issue" ]
d60ea595bcd2399530d8becbced45df0b9b22aa5
33247074a0becce08c1f48eec61e8da0c7bbe4c0
[ "@chrisvest can you have a look at this one ?", "I got the test running and showing the expected failure. It disappears if I add a `alloc.trimCurrentThreadCache();` after the `release()` loop. The accounting is done in a bad place, where we might either miss out on activity happening at the cache layer, or we'll ...
[ "```suggestion\r\n int result = PINNED_UPDATER.addAndGet(this, -delta);\r\n assert result >= 0;\r\n```", "nit: Not strong about this but we could also just use `AtomicInteger` directly here as I wouldn't expect a massive amount of these instances. That said I am not strong on it at all.", "nit: we...
2022-01-11T17:18:05Z
[]
PooledByteBufAllocator.pinnedDirectMemory is sometimes returning 0 even if some direct buffers are used
I'm trying to monitor the estimate of memory that is used by in-use direct buffers. To do so, I'm trying to use the PooledByteBufAllocator.pinnedDirectMemory() method but sometimes, it seems that this method is returning 0 even if some buffers are currently allocated and used (not yet released). ### Expected behavi...
[ "buffer/src/main/java/io/netty/buffer/PoolChunk.java", "buffer/src/main/java/io/netty/buffer/PooledByteBuf.java" ]
[ "buffer/src/main/java/io/netty/buffer/PoolChunk.java", "buffer/src/main/java/io/netty/buffer/PooledByteBuf.java" ]
[ "buffer/src/test/java/io/netty/buffer/PooledByteBufAllocatorTest.java" ]
diff --git a/buffer/src/main/java/io/netty/buffer/PoolChunk.java b/buffer/src/main/java/io/netty/buffer/PoolChunk.java index 70bc6419275..96df62ffed9 100644 --- a/buffer/src/main/java/io/netty/buffer/PoolChunk.java +++ b/buffer/src/main/java/io/netty/buffer/PoolChunk.java @@ -19,6 +19,7 @@ import java.util.ArrayDeque;...
diff --git a/buffer/src/test/java/io/netty/buffer/PooledByteBufAllocatorTest.java b/buffer/src/test/java/io/netty/buffer/PooledByteBufAllocatorTest.java index e2bf4672361..0a977ff0b71 100644 --- a/buffer/src/test/java/io/netty/buffer/PooledByteBufAllocatorTest.java +++ b/buffer/src/test/java/io/netty/buffer/PooledByteB...
test
test
2022-01-11T16:55:55
2022-01-09T20:17:28Z
pderop
val
netty/netty/11864_11996
netty/netty
netty/netty/11864
netty/netty/11996
[ "keyword_pr_to_issue" ]
c6e65cc006c4e0623e84ef96a88dc5bd5cb00a82
55cdaa75adfaff89c9929de9893c8ff7bd2891ae
[ "@chrisvest I think the following issue seems still exists in the newest 4.1.72.Final version.\r\n\r\n\"When thread2 is recycling objects which created by thread1, if thread1 was finished/terminated at this moment, then thread2 will still put the objects back to thread1's queue, which is not necessary.\"\r\n\r\nCor...
[ "Remove ?", "Removed." ]
2022-01-12T19:35:11Z
[]
Multithreading reclaiming objects in the Recycler object pool issue problem
### Netty version 4.1.70.final ### Issue The issue shown in the picture below，Thread 2 is recycling objects which belongs to stack1 created by thread 1。 If thread1 was GC'ed at this moment，i think thread2 does not need to add this object to the `weakOrderQueue node` which is in the `Stack1` any more。 because ...
[ "common/src/main/java/io/netty/util/Recycler.java" ]
[ "common/src/main/java/io/netty/util/Recycler.java" ]
[]
diff --git a/common/src/main/java/io/netty/util/Recycler.java b/common/src/main/java/io/netty/util/Recycler.java index b80c749df16..f518aaa09b4 100644 --- a/common/src/main/java/io/netty/util/Recycler.java +++ b/common/src/main/java/io/netty/util/Recycler.java @@ -102,7 +102,9 @@ protected LocalPool<T> initialValue() {...
null
test
test
2022-01-12T08:20:24
2021-11-26T07:32:24Z
huibinliupush
val
netty/netty/12017_12018
netty/netty
netty/netty/12017
netty/netty/12018
[ "keyword_pr_to_issue" ]
f984708d0b1e1b25b6534a79dc44c438d8a712d4
dbdd0d46622ec68b124d312722002be156adc533
[ "@MrEasy can you provide a PR ?", "> @MrEasy can you provide a PR ?\r\n\r\nSure, can do if you agree.\r\nWould do it for epoll and kqueue. Not for netty-transport-native-unix-common/linux-x86_64, since it does not ship a library, only sources as far as I see.", "@MrEasy yes sounds good... thanks!", "PR#12018 ...
[ "@MrEasy this doesn't look correct", "@MrEasy this doesn't look correct", "thx, of course - updated.", "thx, of course - updated.", "```suggestion\r\n <Fragment-Host>io.netty.resolver-dns-classes-macos</Fragment-Host>\r\n```", "```suggestion\r\n <Fragment-Host>io....
2022-01-18T15:11:40Z
[]
netty-transport-native-* Bundles missing a Fragment-Host
### Initial Position The netty-transport-native-epoll and -kqueue bundles ship native libraries, e.g. for linux_x86_64. The do declare this in their manifest via Bundle-NativeCode header to make it available in an OSGi environment. ### Actual behavior However, when the native library gets loaded via e.g. io.netty...
[ "resolver-dns-native-macos/pom.xml", "transport-native-epoll/pom.xml", "transport-native-kqueue/pom.xml" ]
[ "resolver-dns-native-macos/pom.xml", "transport-native-epoll/pom.xml", "transport-native-kqueue/pom.xml" ]
[]
diff --git a/resolver-dns-native-macos/pom.xml b/resolver-dns-native-macos/pom.xml index 536a4bf9396..82edc515075 100644 --- a/resolver-dns-native-macos/pom.xml +++ b/resolver-dns-native-macos/pom.xml @@ -107,6 +107,7 @@ </manifest> <manifestEntries> <Bun...
null
val
test
2022-01-19T09:06:31
2022-01-18T13:41:48Z
MrEasy
val
netty/netty/10801_12066
netty/netty
netty/netty/10801
netty/netty/12066
[ "keyword_pr_to_issue" ]
ac17a516d443f5087ac1bf0e51ef748d8314d0dc
77ed04330487e7b7f319c41dbe8dd96568d46ba2
[ "I will see this for sure.", "> I will see this for sure.\r\n\r\nsorry, is there any conclusion?", "HTTP/2 has chunked data frames already. Do you want some sort of automatic chunking of a big `ByteBuf` or `RandomFileAccess`?", "Yes, just something like the `ChunkedInput` for writing a large file.", "@Ech0F...
[ "```suggestion\r\npublic final class Http2DataChunkedInput implements ChunkedInput<Http2DataFrame> {\r\n```", "```suggestion\r\n return false;\r\n```", "We can optimize this a bit imho.\r\n\r\n```suggestion\r\n public Http2DataFrame readChunk(ByteBufAllocator allocator) throws Exception {\r\n ...
2022-02-02T06:45:57Z
[]
Considering supporting http2 chunked input
In Http1, we can use a `ChunkedWriteHandler` to write a `HttpChunkedInput`, but we can only use the `Http2DataWriter#writeData(xx)` to write a `ByteBuf` instance in Http2. Considering supporting `writeChunked(xx)` or a unity class (probably implemetated by `Http2RemoteFlowController#isWritable()` and `Http2Remot...
[]
[ "codec-http2/src/main/java/io/netty/handler/codec/http2/Http2DataChunkedInput.java", "example/src/main/java/io/netty/example/http2/file/Http2StaticFileServer.java", "example/src/main/java/io/netty/example/http2/file/Http2StaticFileServerHandler.java", "example/src/main/java/io/netty/example/http2/file/Http2St...
[ "codec-http2/src/test/java/io/netty/handler/codec/http2/Http2DataChunkedInputTest.java" ]
diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2DataChunkedInput.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2DataChunkedInput.java new file mode 100644 index 00000000000..ac382ffde63 --- /dev/null +++ b/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2DataChunk...
diff --git a/codec-http2/src/test/java/io/netty/handler/codec/http2/Http2DataChunkedInputTest.java b/codec-http2/src/test/java/io/netty/handler/codec/http2/Http2DataChunkedInputTest.java new file mode 100644 index 00000000000..26ea3fd05d9 --- /dev/null +++ b/codec-http2/src/test/java/io/netty/handler/codec/http2/Http2D...
train
test
2022-02-01T15:19:47
2020-11-16T08:53:51Z
Ech0Fan
val
netty/netty/12071_12079
netty/netty
netty/netty/12071
netty/netty/12079
[ "keyword_pr_to_issue" ]
fb4a3206ea49364b5a251029ea9618cd61549380
2ab9d653f6199c1438653e1d28c9948b7b9a541c
[ "@normanmaurer I created the Netty Discord server a few days back. Should we make it public so Netty people can engage with each other?", "I am just a (proud) Netty committer but I love the @hyperxpro idea 👍 \r\nI saw many people struggling to find the right place to share their experience/hints...and with Nett...
[]
2022-02-07T08:42:08Z
[]
Clarify how to engage with the community
_Note: this is kind of a meta-issue, as it is not related to the code_ I have been working with Netty 4 for the past two months and it has been a great experience. At times I would have liked to talk to someone about design choices and general questions about the library, but I wasn't able to find a place where Nett...
[ "README.md" ]
[ "README.md" ]
[]
diff --git a/README.md b/README.md index 887e3c3ce13..0bf67c3c409 100644 --- a/README.md +++ b/README.md @@ -10,6 +10,7 @@ Netty is an asynchronous event-driven network application framework for rapid de * [Downloads](https://netty.io/downloads.html) * [Documentation](https://netty.io/wiki/) * [@netty_project](https...
null
train
test
2022-02-04T17:09:25
2022-02-03T14:58:46Z
aochagavia
val
netty/netty/12080_12091
netty/netty
netty/netty/12080
netty/netty/12091
[ "keyword_pr_to_issue" ]
d1a8cd2dec422f3b8fbfd186ae1ec29e680ffd4e
86603872776e3ff5a60dea3c104358e486eed588
[ "@chrisvest WDYT ?", "@yawkat @normanmaurer In this PR, we would just be adding this protected do-nothing method, and call it in the right places, right? And then expect down-stream clients to use e.g. `ResourceLeakDetectorFactory` to install custom detectors that override this method? If that's the case, I think...
[ "You don't need to allocate a single huge array. You can instead allocate a large volume of smaller arrays, until the `GarbageCollectorMXBean`s tell you a GC cycle has occurred.", "Ok I've just tried this but can't get this to work reliably either.\r\n\r\nRelying on `GarbageCollectorMXBean` fails for two reasons:...
2022-02-10T08:56:23Z
[]
Allow attaching additional metadata to ResourceLeakTrackers
It would be useful to add an API to `ResourceLeakDetector` that allows subclasses to supply custom metadata on `DefaultResourceLeak` creation. This would make it easier to associate detected leaks with parameters of the code that caused the leak, e.g. the test case involved (or in my case, the fuzzer input). Right ...
[ "common/src/main/java/io/netty/util/ResourceLeakDetector.java" ]
[ "common/src/main/java/io/netty/util/ResourceLeakDetector.java" ]
[ "common/src/test/java/io/netty/util/ResourceLeakDetectorTest.java" ]
diff --git a/common/src/main/java/io/netty/util/ResourceLeakDetector.java b/common/src/main/java/io/netty/util/ResourceLeakDetector.java index be6845683d9..0408e39975a 100644 --- a/common/src/main/java/io/netty/util/ResourceLeakDetector.java +++ b/common/src/main/java/io/netty/util/ResourceLeakDetector.java @@ -255,12 ...
diff --git a/common/src/test/java/io/netty/util/ResourceLeakDetectorTest.java b/common/src/test/java/io/netty/util/ResourceLeakDetectorTest.java index 2a55da2ff78..3947d60f514 100644 --- a/common/src/test/java/io/netty/util/ResourceLeakDetectorTest.java +++ b/common/src/test/java/io/netty/util/ResourceLeakDetectorTest....
val
test
2022-02-09T10:45:34
2022-02-07T09:30:50Z
yawkat
val
netty/netty/12067_12109
netty/netty
netty/netty/12067
netty/netty/12109
[ "keyword_pr_to_issue" ]
cd0738aa02698a33e1deb30d997f3d0ef84f386e
4797b88d89304763fd92eeff73d077effa53685e
[ "Looking at the git history, this is guarding against issues with class-loaders in e.g. Tomcat containers.\r\n\r\nIf you only allocate from `FastThreadLocalThreads`, then it won't be a problem since those always clear out their thread-locals before terminating, which makes the `PoolThreadCache` free - from within t...
[]
2022-02-17T21:51:27Z
[]
PoolArenaMetric.numDeallocations seem to be wrong
PoolArenaMetric.numDeallocations seem to be wrong because counter are not updated when free comes from PoolThreadLocal GC. https://github.com/netty/netty/blob/1f357fc00e68091b320ada074d198b90a7c75377/buffer/src/main/java/io/netty/buffer/PoolArena.java#L246-L256
[ "buffer/src/main/java/io/netty/buffer/PooledByteBufAllocator.java" ]
[ "buffer/src/main/java/io/netty/buffer/PooledByteBufAllocator.java" ]
[ "buffer/src/test/java/io/netty/buffer/PooledByteBufAllocatorTest.java" ]
diff --git a/buffer/src/main/java/io/netty/buffer/PooledByteBufAllocator.java b/buffer/src/main/java/io/netty/buffer/PooledByteBufAllocator.java index d3445b524ea..4a55a469a88 100644 --- a/buffer/src/main/java/io/netty/buffer/PooledByteBufAllocator.java +++ b/buffer/src/main/java/io/netty/buffer/PooledByteBufAllocator....
diff --git a/buffer/src/test/java/io/netty/buffer/PooledByteBufAllocatorTest.java b/buffer/src/test/java/io/netty/buffer/PooledByteBufAllocatorTest.java index fd4c4d3cf0d..f79d8def0ab 100644 --- a/buffer/src/test/java/io/netty/buffer/PooledByteBufAllocatorTest.java +++ b/buffer/src/test/java/io/netty/buffer/PooledByteB...
test
test
2022-02-28T20:34:11
2022-02-03T01:06:47Z
xavier-b
val
netty/netty/12103_12118
netty/netty
netty/netty/12103
netty/netty/12118
[ "keyword_pr_to_issue" ]
ec0fc8fc725c1575be0bfabd79c663a8a60ebbb2
9c77e4021e3296ee445fe1512cf8b9c3ea3a7ab1
[ "@chrisvest what do you think... Not sure we want to expose just another public method. I guess we could do it tho", "@normanmaurer it's -1 to me, but I would like to understand why @Shoothzj need it/the exact use case", "@franz1981 It's started with https://github.com/apache/bookkeeper/pull/2989 when locating...
[]
2022-02-22T18:31:37Z
[ "feature", "discussion" ]
[feautre request] Add a util method to get maxDirectMemory
Netty's `PlatformDependent.maxDirectMemory()` is powerful and general. In other project, we want to read the `maxDirectMemory` too. But we can't directly use `PlatformDependent.maxDirectMemory()` , because it will wrong if user set `io.netty.maxDirectMemory` greater than zero. Instead of copy and paste netty's cod...
[ "common/src/main/java/io/netty/util/internal/PlatformDependent.java" ]
[ "common/src/main/java/io/netty/util/internal/PlatformDependent.java" ]
[]
diff --git a/common/src/main/java/io/netty/util/internal/PlatformDependent.java b/common/src/main/java/io/netty/util/internal/PlatformDependent.java index a116da2451f..d6b140988b4 100644 --- a/common/src/main/java/io/netty/util/internal/PlatformDependent.java +++ b/common/src/main/java/io/netty/util/internal/PlatformDe...
null
train
test
2022-02-21T12:23:27
2022-02-16T01:05:49Z
shoothzj
val
netty/netty/12129_12131
netty/netty
netty/netty/12129
netty/netty/12131
[ "keyword_pr_to_issue" ]
f650303911e308dfdf10761273c2b8e4436ea0a4
09dbf99ffaf9b00c1df8e55590d58a524ea639d2
[ "@devsprint I wonder if it would be better to write a `SLF4J ` implement for it and then just use the provided SLF4J implementation for netty ?", "To implement my current task, it is exactly what I did, but I was thinking of removing layers of indirections..." ]
[]
2022-02-28T15:35:40Z
[]
Internal Logging API - make MessageFormatter and FormattingTuple public
### Expected behavior While trying to use netty with ZIO 2.x Logging support I found out that I can't implement properly AbstractInternalLogger interface for integration with ZIO 2.x, relying on the optimised implementation of MessageFormatter. ### Actual behavior Should be able to add new Logging integrations. ...
[ "common/src/main/java/io/netty/util/internal/logging/FormattingTuple.java", "common/src/main/java/io/netty/util/internal/logging/MessageFormatter.java" ]
[ "common/src/main/java/io/netty/util/internal/logging/FormattingTuple.java", "common/src/main/java/io/netty/util/internal/logging/MessageFormatter.java" ]
[]
diff --git a/common/src/main/java/io/netty/util/internal/logging/FormattingTuple.java b/common/src/main/java/io/netty/util/internal/logging/FormattingTuple.java index 59862691c82..c18a3a3b2ca 100644 --- a/common/src/main/java/io/netty/util/internal/logging/FormattingTuple.java +++ b/common/src/main/java/io/netty/util/i...
null
train
test
2022-02-25T22:12:54
2022-02-28T12:11:18Z
devsprint
val
netty/netty/12123_12138
netty/netty
netty/netty/12123
netty/netty/12138
[ "keyword_pr_to_issue" ]
09dbf99ffaf9b00c1df8e55590d58a524ea639d2
4374612a4bedefd528d22daac5094e3c740baeb9
[ "Let me check... ", "I have another question about spliceTo(), when native splice returns EAGAIN, why not suspend spliceTask and resume it when EPOLLIN is triggered next time. Infinite calls to splice will fully load the CPU.", "@AriseFX I am happy to review PRs. Please open a PR with fixes if you have time :)...
[]
2022-03-02T12:15:18Z
[]
About the bug of spliceTo()
When I use splice for traffic transmissions, if I still go to epollInReady when EPOLLRDHUP occurs, this will cause me to not receive channelInactive() events ### Expected behavior when the other party closes the connection, I can receive channelinactive() ### Actual behavior Cannot receive channelinactive(),and...
[ "transport-classes-epoll/src/main/java/io/netty/channel/epoll/AbstractEpollStreamChannel.java" ]
[ "transport-classes-epoll/src/main/java/io/netty/channel/epoll/AbstractEpollStreamChannel.java" ]
[]
diff --git a/transport-classes-epoll/src/main/java/io/netty/channel/epoll/AbstractEpollStreamChannel.java b/transport-classes-epoll/src/main/java/io/netty/channel/epoll/AbstractEpollStreamChannel.java index 011b992b45f..0b7044bb8f3 100644 --- a/transport-classes-epoll/src/main/java/io/netty/channel/epoll/AbstractEpollS...
null
train
test
2022-03-01T11:32:18
2022-02-25T05:13:26Z
AriseFX
val
netty/netty/12175_12188
netty/netty
netty/netty/12175
netty/netty/12188
[ "keyword_pr_to_issue" ]
5cda0444187c6f7c54b03a97b1956c44a2f24ccc
40382fb1af275e931a765c5001f4b6bd8061991e
[ "The simple solution of just slapping in some random name (`io.netty.all`) is that this will cause the packages within this jar to be exported from more than one Java Module, and that will also cause problems.\r\n\r\nThe other fix is to remove the attribute from the manifest entirely.", "Netty-all is a pom-only d...
[ "wouldn't it be better to not define a module at all if it not ships any classes ? \r\n\r\n/cc @shs96c", "As long as this jar doesn't contain any classes, it'll be fine. The problems with the module system start when the same class is present in two or more jars: split packages (and therefore duplicate classes) a...
2022-03-17T01:11:40Z
[]
`io.netty:netty-all:4.1.75.Final` declares an empty automatic module name
### Expected behavior If the `Automatic-Module-Name` manifest property is present, it should be set to a meaningful value. This attribute is defined in the manifest for `io.netty:netty-all:4.1.75.Final` ### Actual behavior In `io.netty:netty-all:4.1.75.Final` (and earlier versions), this is declared but not se...
[ "all/pom.xml" ]
[ "all/pom.xml" ]
[]
diff --git a/all/pom.xml b/all/pom.xml index 7dcd227bd84..1265fe3d3de 100644 --- a/all/pom.xml +++ b/all/pom.xml @@ -29,6 +29,7 @@ <name>Netty/All-in-One</name> <properties> + <javaModuleName>io.netty.all</javaModuleName> <generatedSourceDir>${project.build.directory}/src</generatedSourceDir> <depe...
null
train
test
2022-03-16T12:36:01
2022-03-15T16:43:58Z
shs96c
val
netty/netty/12269_12270
netty/netty
netty/netty/12269
netty/netty/12270
[ "keyword_pr_to_issue" ]
34ae67a5b1fb1f119c1ed509f576c205d1e7fd78
960121db545f2d8aec7a87da8c54a9645fde266c
[]
[]
2022-04-03T01:05:18Z
[]
Allow explicitly choosing protocol family
### Expected behavior Netty should be able to bind to specific protocol family only (IPv4, IPv6) if requested by the caller. ### Actual behavior Netty uses `java.net.preferIPv4Stack` JVM property to determine whether to bind to IPv4 or IPv6 (possibly IPv6+IPv4 given by settings of IPV6_V6ONLY socket option). ...
[ "transport-classes-epoll/src/main/java/io/netty/channel/epoll/EpollDatagramChannel.java", "transport-classes-epoll/src/main/java/io/netty/channel/epoll/EpollServerSocketChannel.java", "transport-classes-epoll/src/main/java/io/netty/channel/epoll/EpollSocketChannel.java", "transport-classes-epoll/src/main/java...
[ "transport-classes-epoll/src/main/java/io/netty/channel/epoll/EpollDatagramChannel.java", "transport-classes-epoll/src/main/java/io/netty/channel/epoll/EpollServerSocketChannel.java", "transport-classes-epoll/src/main/java/io/netty/channel/epoll/EpollSocketChannel.java", "transport-classes-epoll/src/main/java...
[]
diff --git a/transport-classes-epoll/src/main/java/io/netty/channel/epoll/EpollDatagramChannel.java b/transport-classes-epoll/src/main/java/io/netty/channel/epoll/EpollDatagramChannel.java index 79e1fbfddc3..0ca449b6654 100644 --- a/transport-classes-epoll/src/main/java/io/netty/channel/epoll/EpollDatagramChannel.java ...
null
val
test
2022-03-31T22:48:23
2022-04-03T01:03:59Z
kvr000
val
netty/netty/11701_12272
netty/netty
netty/netty/11701
netty/netty/12272
[ "keyword_pr_to_issue" ]
92599a7ebbff6fcb5a8a2eab8f217ea51ad73f01
81e90785e8ef4596817748648540a52e3e681944
[ "The binary compatibility baseline for our native code is the GLIBC version that's used on CentOS 6. The work-around is to use the Nio transport.\r\n\r\nIt's not clear from the error reports how this is really showing up. If it's an ABI problem, then I'm not sure what we can do to mitigate it. If we are calling gli...
[]
2022-04-04T02:08:13Z
[]
Throwing an exception in case glibc is missing instead of segfaulting the JVM
It seems Netty's native support depends on glibc (btw is this documented?). When glibc is missing (for example using vanilla Alpine), the JVM could end up with a crash (`SIGSEGV`), see details in this issue: https://github.com/micrometer-metrics/micrometer/issues/2776 It also seems that `Epoll.isAvailable()` return...
[ "transport-native-epoll/pom.xml" ]
[ "transport-native-epoll/pom.xml" ]
[]
diff --git a/transport-native-epoll/pom.xml b/transport-native-epoll/pom.xml index 1dec5ca0dbc..7707b7b100e 100644 --- a/transport-native-epoll/pom.xml +++ b/transport-native-epoll/pom.xml @@ -32,8 +32,9 @@ <unix.common.lib.dir>${project.build.directory}/unix-common-lib</unix.common.lib.dir> <unix.common.lib....
null
test
test
2022-04-09T18:22:50
2021-09-22T02:15:46Z
jonatan-ivanov
val
netty/netty/12269_12281
netty/netty
netty/netty/12269
netty/netty/12281
[ "keyword_pr_to_issue" ]
e267958b4c91c214bb6810189b1a9acb65122018
243893082feaa26cd89fc0dbc099f63b56610456
[]
[]
2022-04-05T07:29:02Z
[]
Allow explicitly choosing protocol family
### Expected behavior Netty should be able to bind to specific protocol family only (IPv4, IPv6) if requested by the caller. ### Actual behavior Netty uses `java.net.preferIPv4Stack` JVM property to determine whether to bind to IPv4 or IPv6 (possibly IPv6+IPv4 given by settings of IPV6_V6ONLY socket option). ...
[ "transport-classes-epoll/src/main/java/io/netty5/channel/epoll/EpollDatagramChannel.java", "transport-classes-epoll/src/main/java/io/netty5/channel/epoll/EpollServerSocketChannel.java", "transport-classes-epoll/src/main/java/io/netty5/channel/epoll/EpollSocketChannel.java", "transport-classes-epoll/src/main/j...
[ "transport-classes-epoll/src/main/java/io/netty5/channel/epoll/EpollDatagramChannel.java", "transport-classes-epoll/src/main/java/io/netty5/channel/epoll/EpollServerSocketChannel.java", "transport-classes-epoll/src/main/java/io/netty5/channel/epoll/EpollSocketChannel.java", "transport-classes-epoll/src/main/j...
[]
diff --git a/transport-classes-epoll/src/main/java/io/netty5/channel/epoll/EpollDatagramChannel.java b/transport-classes-epoll/src/main/java/io/netty5/channel/epoll/EpollDatagramChannel.java index 70200462201..b702a2c8a10 100644 --- a/transport-classes-epoll/src/main/java/io/netty5/channel/epoll/EpollDatagramChannel.ja...
null
train
test
2022-04-05T08:46:29
2022-04-03T01:03:59Z
kvr000
val
netty/netty/11701_12313
netty/netty
netty/netty/11701
netty/netty/12313
[ "keyword_pr_to_issue" ]
f9e765e0ceddf30a5951e1f59ae6d9dece59819f
7be44fba673147ff881903bb994fbdbd112f19d5
[ "The binary compatibility baseline for our native code is the GLIBC version that's used on CentOS 6. The work-around is to use the Nio transport.\r\n\r\nIt's not clear from the error reports how this is really showing up. If it's an ABI problem, then I'm not sure what we can do to mitigate it. If we are calling gli...
[]
2022-04-19T15:28:46Z
[]
Throwing an exception in case glibc is missing instead of segfaulting the JVM
It seems Netty's native support depends on glibc (btw is this documented?). When glibc is missing (for example using vanilla Alpine), the JVM could end up with a crash (`SIGSEGV`), see details in this issue: https://github.com/micrometer-metrics/micrometer/issues/2776 It also seems that `Epoll.isAvailable()` return...
[ "transport-native-epoll/pom.xml" ]
[ "transport-native-epoll/pom.xml" ]
[]
diff --git a/transport-native-epoll/pom.xml b/transport-native-epoll/pom.xml index d2768a4d3d3..cad13b4b77b 100644 --- a/transport-native-epoll/pom.xml +++ b/transport-native-epoll/pom.xml @@ -34,8 +34,9 @@ <unix.common.lib.dir>${project.build.directory}/unix-common-lib</unix.common.lib.dir> <unix.common.lib....
null
train
test
2022-04-14T17:12:42
2021-09-22T02:15:46Z
jonatan-ivanov
val
netty/netty/12351_12358
netty/netty
netty/netty/12351
netty/netty/12358
[ "keyword_pr_to_issue" ]
8e8e9cc7b4e05b5bfd81a2aeba23b4e550466494
eb005907caab01256c1d8baf6d96b06beae95be4
[ "The test passes if I comment out `ShadingIT.testShadingNativeTransport()`, but why? Why does `testShadingTcnative()` pass? I can see the shaded native libraries are all there for my architecture (osx_aarch_64):\r\n\r\n```\r\n❯ find target/classes-shaded/ | grep META-INF/native/\r\ntarget/classes-shaded/META-INF/na...
[]
2022-05-04T09:39:11Z
[ "ci" ]
`ShadingIT` fails on macOS and Linux
### Expected behavior The following commands should succeed: ``` $ ./mvnw install -DskipTests $ cd testsuite-shading $ ../mvnw clean integration-test failsafe:verify ``` ### Actual behavior The above command fails with the following error: ``` [ERROR] Tests run: 2, Failures: 0, Errors: 1, Skipped: 0...
[ "common/src/main/java/io/netty/util/internal/NativeLibraryLoader.java", "docker/docker-compose.yaml", "pom.xml" ]
[ "common/src/main/java/io/netty/util/internal/NativeLibraryLoader.java", "docker/docker-compose.yaml", "pom.xml" ]
[ "testsuite-shading/pom.xml" ]
diff --git a/common/src/main/java/io/netty/util/internal/NativeLibraryLoader.java b/common/src/main/java/io/netty/util/internal/NativeLibraryLoader.java index 795ac28006a..826cc38d9b9 100644 --- a/common/src/main/java/io/netty/util/internal/NativeLibraryLoader.java +++ b/common/src/main/java/io/netty/util/internal/Nati...
diff --git a/testsuite-shading/pom.xml b/testsuite-shading/pom.xml index e3582786560..65a650263c7 100644 --- a/testsuite-shading/pom.xml +++ b/testsuite-shading/pom.xml @@ -34,7 +34,9 @@ <classesShadedDir>${project.build.directory}/classes-shaded</classesShadedDir> <classesShadedNativeDir>${classesShadedDir}/...
train
test
2022-05-04T08:53:08
2022-05-02T12:48:31Z
trustin
val
netty/netty/12411_12414
netty/netty
netty/netty/12411
netty/netty/12414
[ "keyword_pr_to_issue" ]
b61d7d40f40e3a797e8a60cd567f849a9799c771
cb35e4b13485c674ea6118e9ecf99fba913a4804
[ "This is only during the class initialisation. If you want to get past an automated check with blockhound, you'll have to move the `NetUtil` initialisation forward, and out of any event loop.", "> This is only during the class initialisation. If you want to get past an automated check with blockhound, you'll have...
[]
2022-05-18T23:29:01Z
[]
BlockHound detects blocking call with webflux webclient for simple http calling
I am on spring boot 2.6.7 Calling ``` webClient .get() .uri("/me", queryString) .exchangeToMono(clientResponse -> { if (clientResponse.statusCode().equals(HttpStatus.OK)) { return clientResponse.bodyToMono(FacebookAuth...
[ "common/src/main/java/io/netty/util/internal/Hidden.java" ]
[ "common/src/main/java/io/netty/util/internal/Hidden.java" ]
[]
diff --git a/common/src/main/java/io/netty/util/internal/Hidden.java b/common/src/main/java/io/netty/util/internal/Hidden.java index c233acdb2c4..78c45f715db 100644 --- a/common/src/main/java/io/netty/util/internal/Hidden.java +++ b/common/src/main/java/io/netty/util/internal/Hidden.java @@ -135,7 +135,7 @@ public void...
null
train
test
2022-05-17T12:24:48
2022-05-18T20:52:43Z
ilyas2016
val
netty/netty/12425_12435
netty/netty
netty/netty/12425
netty/netty/12435
[ "keyword_pr_to_issue" ]
871dd2e5730a477738a5a9b9af19be35244137d0
56f7c50d19125dad36b97ed33d9797da941a7591
[ "What does blockhound log? We'll need the stack trace for that blocking call.", "```\r\nreactor.blockhound.BlockingOperationError: Blocking call! java.io.FileInputStream#readBytes\r\n\r\n0 = {StackTraceElement@17697} \"java.base/java.io.FileInputStream.readBytes(FileInputStream.java)\"\r\n1 = {StackTraceElement@1...
[ "```suggestion\r\n List<String> ciphersNonTLSv13 = new ArrayList<String>(defaultCiphers);\r\n```", "```suggestion\r\n Set<String> suppertedCiphersNonTLSv13 = new LinkedHashSet<String>(supportedCiphers);\r\n```" ]
2022-05-31T22:58:36Z
[]
Jdk sslhandler have blocking call
I tried to integrate some reactive tests with miku-mysql and blockhound (which uses netty-handler under the hood), and noticed that there's a blocking call when using jdkssl implementation (leading to noclassdeffound in the end). With the netty version embedded in spring-boot-webflux 2.6.7 (tried to upgrade netty-handl...
[ "common/src/main/java/io/netty/util/internal/Hidden.java", "handler/src/main/java/io/netty/handler/ssl/JdkSslContext.java" ]
[ "common/src/main/java/io/netty/util/internal/Hidden.java", "handler/src/main/java/io/netty/handler/ssl/JdkSslContext.java" ]
[]
diff --git a/common/src/main/java/io/netty/util/internal/Hidden.java b/common/src/main/java/io/netty/util/internal/Hidden.java index 78c45f715db..5ebf8e780e2 100644 --- a/common/src/main/java/io/netty/util/internal/Hidden.java +++ b/common/src/main/java/io/netty/util/internal/Hidden.java @@ -108,6 +108,10 @@ public voi...
null
val
test
2022-05-27T08:22:49
2022-05-25T13:56:26Z
Tcharl
val
netty/netty/10757_12442
netty/netty
netty/netty/10757
netty/netty/12442
[ "keyword_pr_to_issue" ]
56f7c50d19125dad36b97ed33d9797da941a7591
c42a207f7242b2bdd170cc463b49bf50c7334165
[ "Is there any reason that JUnit 5 cannot be added to Netty 4.1?\r\n\r\nConsidering test artifacts are not exported as part of the build process, it doesn't seem like it should pose a compatibility issue.", "The testsuite is exposed so we can consume it . That said I would not consider this API\n\n> Am 30.10.2020 ...
[]
2022-06-03T00:30:43Z
[ "help wanted" ]
Migrating to JUnit 5
I propose that we start migrating the test suite for Netty 5 (the `master` branch) to JUnit 5. JUnit 5 is more expressive, extensible, and composable in many ways, and it's better able to run tests in parallel. It can also directly run JUnit 4 tests, using the vintage engine, which means we can do this in small ste...
[ "microbench/pom.xml", "pom.xml", "transport-native-unix-common-tests/pom.xml", "transport-native-unix-common-tests/src/main/java/io/netty/channel/unix/tests/SocketTest.java" ]
[ "microbench/pom.xml", "pom.xml", "transport-native-unix-common-tests/pom.xml", "transport-native-unix-common-tests/src/main/java/io/netty/channel/unix/tests/SocketTest.java" ]
[ "codec/src/test/resources/io/netty/handler/codec/xml/sample-04.xml", "testsuite-native/pom.xml", "testsuite-shading/pom.xml", "testsuite/pom.xml", "testsuite/src/main/java/io/netty/testsuite/transport/socket/DatagramUnicastIPv6Test.java", "testsuite/src/main/java/io/netty/testsuite/util/TestUtils.java" ]
diff --git a/microbench/pom.xml b/microbench/pom.xml index 18aca81bcaa..32a26bfb089 100644 --- a/microbench/pom.xml +++ b/microbench/pom.xml @@ -185,16 +185,6 @@ <artifactId>junit-jupiter-engine</artifactId> <scope>compile</scope> </dependency> - <dependency> - <groupId>org.junit.vintage</gro...
diff --git a/codec/src/test/resources/io/netty/handler/codec/xml/sample-04.xml b/codec/src/test/resources/io/netty/handler/codec/xml/sample-04.xml index 8a75afccd6b..22b9d702b31 100644 --- a/codec/src/test/resources/io/netty/handler/codec/xml/sample-04.xml +++ b/codec/src/test/resources/io/netty/handler/codec/xml/sampl...
train
test
2022-06-01T18:17:12
2020-10-30T15:10:12Z
chrisvest
val