instance_id stringlengths 17 39 | repo stringclasses 8
values | issue_id stringlengths 14 34 | pr_id stringlengths 14 34 | linking_methods listlengths 1 3 | base_commit stringlengths 40 40 | merge_commit stringlengths 0 40 ⌀ | hints_text listlengths 0 106 | resolved_comments listlengths 0 119 | created_at timestamp[ns, tz=UTC] | labeled_as listlengths 0 7 | problem_title stringlengths 7 174 | problem_statement stringlengths 0 55.4k | gold_files listlengths 0 10 | gold_files_postpatch listlengths 1 10 | test_files listlengths 0 60 | gold_patch stringlengths 220 5.83M | test_patch stringlengths 386 194k ⌀ | split_random stringclasses 3
values | split_time stringclasses 3
values | issue_start_time timestamp[ns] | issue_created_at timestamp[ns, tz=UTC] | issue_by_user stringlengths 3 21 | split_repo stringclasses 3
values |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
netty/netty/7947_7968 | netty/netty | netty/netty/7947 | netty/netty/7968 | [
"timestamp(timedelta=0.0, similarity=0.8568307862755823)"
] | b192bf12ad2af92bba0f32c9d3127b1192e54670 | 400ca8733427732e426d6fa0eb88fcfe7e06b06d | [
"There is a solid chance I'm just missing something, and if so, sorry for the noise.",
"@bryce-anderson basically you are asking to get access to stream 1 (upgrade stream) ?",
"@normanmaurer, yes, specifically as a client since I wasn't clear on that.",
"@bryce-anderson I think you are right (but I am a bit b... | [
"nit: remove ?",
"you can remove the `= null`",
"please enclose with `{}`",
"nit: remove",
"You could also just use `ChannelInboundHandlerAdapter` and so not need to declare an extra class .",
"2018",
"formatting ",
"nit: final",
"private ?",
"s/he/the/",
"can we come up with a better name than ... | 2018-05-24T19:53:12Z | [] | No way to get a Http2StreamChannel for a client h2c upgrade stream via Http2MultiplexCodec | ### Expected behavior
When using the `Http2MultiplexCodec` on a client after a h2c upgrade is performed, I expect to be able to get a handle on the `Http2StreamChannel` associated with the upgrade request when using the `Http2MultiplexCodec`.
### Actual behavior
There is no public API for surfacing a `Http2StreamC... | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/Http2FrameCodec.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/Http2MultiplexCodec.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/Http2MultiplexCodecBuilder.java"
] | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/Http2FrameCodec.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/Http2MultiplexCodec.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/Http2MultiplexCodecBuilder.java"
] | [
"codec-http2/src/test/java/io/netty/handler/codec/http2/Http2ClientUpgradeCodecTest.java",
"codec-http2/src/test/java/io/netty/handler/codec/http2/Http2MultiplexCodecClientUpgradeTest.java",
"codec-http2/src/test/java/io/netty/handler/codec/http2/Http2MultiplexCodecTest.java"
] | diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2FrameCodec.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2FrameCodec.java
index da2b27a1d7b..47f2533f3f8 100644
--- a/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2FrameCodec.java
+++ b/codec-http2/src/main/java/i... | diff --git a/codec-http2/src/test/java/io/netty/handler/codec/http2/Http2ClientUpgradeCodecTest.java b/codec-http2/src/test/java/io/netty/handler/codec/http2/Http2ClientUpgradeCodecTest.java
index cb774a94ca9..fcfdb4b75e5 100644
--- a/codec-http2/src/test/java/io/netty/handler/codec/http2/Http2ClientUpgradeCodecTest.ja... | train | val | 2018-06-04T20:40:08 | 2018-05-16T17:50:08Z | bryce-anderson | val |
netty/netty/7969_7976 | netty/netty | netty/netty/7969 | netty/netty/7976 | [
"timestamp(timedelta=0.0, similarity=0.9186618764462279)"
] | 9a3311506e5aa9ffd4bfa58c47ec22c37a0d5599 | f904c63a535ebfd51d6911cca28aac0eb23c8df0 | [
"@Bennett-Lynch let it extend `Http2StreamFrame` sounds like the correct thing to do. Would you be interested in proving a PR ?\r\n\r\nI think I would leave the `isEndStream` as it is and just use the `Http2Flags` for it.",
"@Bennett-Lynch I had a bit time this morning so I just did it myself and adding unit test... | [] | 2018-05-28T05:14:34Z | [] | Make Http2UnknownFrame extend Http2StreamFrame rather than Http2Frame | This is a follow-up issue regarding: https://github.com/netty/netty/issues/7860
### Expected behavior
Writing an `Http2UnknownFrame` to a child channel will be written to the parent channel and underlying HTTP/2 connection via `Http2MultiplexCodec`.
When `Http2MultiplexCodec` reads an `Http2UnknownFrame`, it w... | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/Http2UnknownFrame.java"
] | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/Http2UnknownFrame.java"
] | [
"codec-http2/src/test/java/io/netty/handler/codec/http2/Http2MultiplexCodecTest.java"
] | diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2UnknownFrame.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2UnknownFrame.java
index 51eeafaf0d9..41e578703a5 100644
--- a/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2UnknownFrame.java
+++ b/codec-http2/src/main/... | diff --git a/codec-http2/src/test/java/io/netty/handler/codec/http2/Http2MultiplexCodecTest.java b/codec-http2/src/test/java/io/netty/handler/codec/http2/Http2MultiplexCodecTest.java
index 7a0e8c6a3a0..f07b218e095 100644
--- a/codec-http2/src/test/java/io/netty/handler/codec/http2/Http2MultiplexCodecTest.java
+++ b/cod... | train | val | 2018-05-27T10:02:49 | 2018-05-24T22:02:57Z | Bennett-Lynch | val |
netty/netty/7860_7976 | netty/netty | netty/netty/7860 | netty/netty/7976 | [
"keyword_pr_to_issue"
] | 9a3311506e5aa9ffd4bfa58c47ec22c37a0d5599 | f904c63a535ebfd51d6911cca28aac0eb23c8df0 | [
"@Bennett-Lynch PTAL https://github.com/netty/netty/pull/7867",
"Fixed..",
"Thanks for the quick fix!",
"Np \n\n> Am 13.04.2018 um 17:33 schrieb Bennett Lynch <notifications@github.com>:\n> \n> Thanks for the quick fix!\n> \n> —\n> You are receiving this because you modified the open/close state.\n> Reply to ... | [] | 2018-05-28T05:14:34Z | [] | HTTP2 Multiplex API support for unknown/custom frames | ### Expected behavior
The HTTP/2 spec explicitly permits extension of the protocol in the form of new frame types:
http://httpwg.org/specs/rfc7540.html#rfc.section.5.5
I would like/expect to be able to write/read custom frame types using the HTTP2 Multiplex API. That is, if I write a Http2StreamFrame to a child... | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/Http2UnknownFrame.java"
] | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/Http2UnknownFrame.java"
] | [
"codec-http2/src/test/java/io/netty/handler/codec/http2/Http2MultiplexCodecTest.java"
] | diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2UnknownFrame.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2UnknownFrame.java
index 51eeafaf0d9..41e578703a5 100644
--- a/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2UnknownFrame.java
+++ b/codec-http2/src/main/... | diff --git a/codec-http2/src/test/java/io/netty/handler/codec/http2/Http2MultiplexCodecTest.java b/codec-http2/src/test/java/io/netty/handler/codec/http2/Http2MultiplexCodecTest.java
index 7a0e8c6a3a0..f07b218e095 100644
--- a/codec-http2/src/test/java/io/netty/handler/codec/http2/Http2MultiplexCodecTest.java
+++ b/cod... | train | val | 2018-05-27T10:02:49 | 2018-04-10T21:42:20Z | Bennett-Lynch | val |
netty/netty/7990_7994 | netty/netty | netty/netty/7990 | netty/netty/7994 | [
"timestamp(timedelta=0.0, similarity=0.8921366031300989)"
] | a4393831f0c95e4b89812238b9ac26ac4322e451 | 1611acf4cee4481b89a2cf024ccf821de2dbf13c | [
"@henrik-lindqvist yes this sounds like a bug...\r\n\r\n@carl-mastrangelo @ejona86 @Scottmitch @trustin What you think is the correct behaviour here ?",
"I agree there is inconsistency here, and it is not just with `convertToByte` but also with other `convertTo` methods that have a special case for `AsciiString`.... | [] | 2018-06-01T08:34:26Z | [] | CharSequenceValueConverter.convertToByte works differently for AsciiString vs String | ### Netty version
4.1
Looking at function CharSequenceValueConverter.convertToByte (CharSequence):
https://github.com/netty/netty/blob/4.1/codec/src/main/java/io/netty/handler/codec/CharSequenceValueConverter.java#L79
For AsciiString it takes the first byte, but for any other kind of CharSequence it parse the n... | [
"codec/src/main/java/io/netty/handler/codec/CharSequenceValueConverter.java"
] | [
"codec/src/main/java/io/netty/handler/codec/CharSequenceValueConverter.java"
] | [
"codec/src/test/java/io/netty/handler/codec/CharSequenceValueConverterTest.java"
] | diff --git a/codec/src/main/java/io/netty/handler/codec/CharSequenceValueConverter.java b/codec/src/main/java/io/netty/handler/codec/CharSequenceValueConverter.java
index b6510d1ff7e..1157af0623e 100644
--- a/codec/src/main/java/io/netty/handler/codec/CharSequenceValueConverter.java
+++ b/codec/src/main/java/io/netty/h... | diff --git a/codec/src/test/java/io/netty/handler/codec/CharSequenceValueConverterTest.java b/codec/src/test/java/io/netty/handler/codec/CharSequenceValueConverterTest.java
index 5543e2f9095..2347f0d0bf9 100644
--- a/codec/src/test/java/io/netty/handler/codec/CharSequenceValueConverterTest.java
+++ b/codec/src/test/jav... | train | val | 2018-05-30T22:07:42 | 2018-05-30T23:22:35Z | henrik-lindqvist | val |
netty/netty/7988_8001 | netty/netty | netty/netty/7988 | netty/netty/8001 | [
"timestamp(timedelta=0.0, similarity=0.842426538919858)"
] | 00786337029d48d2e5815ff5076284a46373062b | b192bf12ad2af92bba0f32c9d3127b1192e54670 | [
"@ejona86 @carl-mastrangelo @nmittler who would be the best to ping on your end ?",
"+ @flooey",
"Yep, that's probably just a bug in Conscrypt. Can you tell me what you're doing to trigger that?",
"Nevermind, I see through the stack trace that this is due to calling `wrap()` on a closed SSLEngine. That obvi... | [] | 2018-06-04T16:06:12Z | [] | NPE in testsuite logged when using Conscrypt. | Saw this during the build:
```
Running io.netty.handler.ssl.ConscryptJdkSslEngineInteropTest
18:01:39.304 [nioEventLoopGroup-676-3] DEBUG io.netty.buffer.PoolThreadCache - Freed 10 thread-local buffer(s) from thread: nioEventLoopGroup-676-3
18:01:39.304 [nioEventLoopGroup-676-2] DEBUG io.netty.buffer.PoolThreadCa... | [
"pom.xml"
] | [
"pom.xml"
] | [] | diff --git a/pom.xml b/pom.xml
index 4cb89d220c5..71e3e4b2da7 100644
--- a/pom.xml
+++ b/pom.xml
@@ -225,7 +225,7 @@
<tcnative.classifier>${os.detected.classifier}</tcnative.classifier>
<conscrypt.groupId>org.conscrypt</conscrypt.groupId>
<conscrypt.artifactId>conscrypt-openjdk-uber</conscrypt.artifactId... | null | test | val | 2018-06-04T18:09:42 | 2018-05-30T18:25:54Z | normanmaurer | val |
netty/netty/8002_8009 | netty/netty | netty/netty/8002 | netty/netty/8009 | [
"keyword_pr_to_issue"
] | b192bf12ad2af92bba0f32c9d3127b1192e54670 | abe77511b99b93a7ec98ddea78243ff6e6235107 | [
"@vsabella I guess we should just remove it completely. \r\n\r\n@carl-mastrangelo @ejona86 @Scottmitch thoughts ?",
"Also @mosesn @bryce-anderson WDYT ?",
"Looks like dead code to me and `Http2CodecUtil` is still tagged `@UnstableApi` so removing it seems like the right move.",
"@bryce-anderson sounds good...... | [] | 2018-06-06T21:47:16Z | [
"cleanup"
] | Http2CodecUtil.java - emptyPingBuf() is no longer needed (as writePing takes a long) | https://github.com/netty/netty/blob/b192bf12ad2af92bba0f32c9d3127b1192e54670/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2CodecUtil.java#L177
In https://github.com/netty/netty/commit/501662a77f8166382eefd18a8620983d27f59d4a - emptyPing data changed to long (instead of buffer data)
This should be ... | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/Http2CodecUtil.java"
] | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/Http2CodecUtil.java"
] | [] | diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2CodecUtil.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2CodecUtil.java
index 317ee48063d..7ebc8fd4888 100644
--- a/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2CodecUtil.java
+++ b/codec-http2/src/main/java/io/n... | null | train | val | 2018-06-04T20:40:08 | 2018-06-04T23:05:38Z | vsabella | val |
netty/netty/8041_8067 | netty/netty | netty/netty/8041 | netty/netty/8067 | [
"timestamp(timedelta=21445.0, similarity=0.8587414992007502)"
] | a214f2eb9692040cf45e20739a7dd319f47ff8c8 | 94e5676a1fd85653ac2f0cb11abf394718214718 | [
"A simple solution might be to add something like\r\n```java\r\n} else if (connection().goAwayReceived()) {\r\n ReferenceCountUtil.release(frame);\r\n promise.setFailure(Http2Exception.streamError(-1, Http2Error.REFUSED_STREAM, \"Received GOAWAY before stream was initialized.\")\r\n );\r\n return;\r\n}\... | [
"Would it be cleaner to instead set `nextReservationStreamId = -1` (or Integer.MIN_VALUE) in `goAwayReceived()`?",
"Perhaps. The connection between `nextReservationStreamId` and `nextStreamIdToCreate` is somewhat subtle, but it looks safe to me. I'm happy to change it if you like.",
"I wonder if we should inste... | 2018-06-27T16:49:08Z | [] | Http2MultiplexCodec in client mode can trigger a GOAWAY if it creates a stream after getting a GOAWAY | ### Expected behavior
When a client attempts to utilize a new stream channel using Http2MultiplexCodec _after_ receiving a GOAWAY, the client will gracefully fail the stream channel with an exception that signifies the stream wasn't processed, perhaps such a RST_STREAM(REFUSED_STREAM).
### Actual behavior
When... | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2Connection.java"
] | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2Connection.java"
] | [
"codec-http2/src/test/java/io/netty/handler/codec/http2/Http2FrameCodecTest.java"
] | diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2Connection.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2Connection.java
index 42513174572..4204945c323 100644
--- a/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2Connection.java
+++ b/codec-... | diff --git a/codec-http2/src/test/java/io/netty/handler/codec/http2/Http2FrameCodecTest.java b/codec-http2/src/test/java/io/netty/handler/codec/http2/Http2FrameCodecTest.java
index 21239860472..55d81bdbb98 100644
--- a/codec-http2/src/test/java/io/netty/handler/codec/http2/Http2FrameCodecTest.java
+++ b/codec-http2/src... | val | val | 2018-06-27T10:20:59 | 2018-06-20T22:39:07Z | bryce-anderson | val |
netty/netty/8107_8109 | netty/netty | netty/netty/8107 | netty/netty/8109 | [
"timestamp(timedelta=0.0, similarity=0.9327315514790757)"
] | cda4f88ca247d3a028deed52e6024cbf5a880b12 | 93d2807ff0eb6d886a4da8fc52a97ea7bbc056b5 | [
"@apimastery good catch... See https://github.com/netty/netty/pull/8109"
] | [] | 2018-07-09T12:39:13Z | [] | Log4J2 Auto-detection | Not sure if I'm missing something...
[#5047](https://github.com/netty/netty/pull/5047) added Log4J2LoggerFactory and Log4J2Logger. It appears that Log4J2 auto-detection in InternalLoggerFactory wasn't added?
https://github.com/netty/netty/blob/fef462c04333950201ddbfd505c0af730a0c2ffd/common/src/main/java/io/netty/u... | [
"common/src/main/java/io/netty/util/internal/logging/InternalLoggerFactory.java"
] | [
"common/src/main/java/io/netty/util/internal/logging/InternalLoggerFactory.java"
] | [] | diff --git a/common/src/main/java/io/netty/util/internal/logging/InternalLoggerFactory.java b/common/src/main/java/io/netty/util/internal/logging/InternalLoggerFactory.java
index 9f85e3646b4..12c1b5a4477 100644
--- a/common/src/main/java/io/netty/util/internal/logging/InternalLoggerFactory.java
+++ b/common/src/main/ja... | null | test | val | 2018-07-09T09:50:26 | 2018-07-09T00:08:32Z | apimastery | val |
netty/netty/8078_8110 | netty/netty | netty/netty/8078 | netty/netty/8110 | [
"timestamp(timedelta=0.0, similarity=0.9102304495225041)"
] | 97361fa2c89da57e88762aaca9e2b186e8c148f5 | d8e59ca638b8aa4fe4d18c52c70bd92a0150de58 | [
"Same goes for BufferedReader instances - same finalize problem. It's used in DNS and some other modules.",
"@leventov good catch... Check https://github.com/netty/netty/pull/8110"
] | [
"This looks like it leaks, since you need to close `RandomAccessFile`. The documentation for `getChannel()` does not say closing the channel closes the `RandomAccessFile`. The documentation for `RandomAccessFile.close()` notes the opposite, that closing the file closes the channel. Looking at the source, it seems t... | 2018-07-09T13:08:53Z | [
"improvement"
] | Avoid creating FileInputStream and FileOutputStream for obtaining FileChannel | There are multiple places in the production code of the project, e. g. in `ChunkedNioFile`, where `FileInputStream` or `FileOutputStream` are created solely to obtain a `FileChannel` from them. Until Netty projects bumps the compatibility level to Java 7 (where `FileChannel.open()` methods were added), it's better to o... | [
"codec-http/src/main/java/io/netty/handler/codec/http/multipart/AbstractDiskHttpData.java",
"codec-http/src/main/java/io/netty/handler/codec/http/multipart/AbstractMemoryHttpData.java",
"handler/src/main/java/io/netty/handler/stream/ChunkedNioFile.java"
] | [
"codec-http/src/main/java/io/netty/handler/codec/http/multipart/AbstractDiskHttpData.java",
"codec-http/src/main/java/io/netty/handler/codec/http/multipart/AbstractMemoryHttpData.java",
"handler/src/main/java/io/netty/handler/stream/ChunkedNioFile.java"
] | [
"buffer/src/test/java/io/netty/buffer/ReadOnlyDirectByteBufferBufTest.java",
"testsuite/src/main/java/io/netty/testsuite/transport/socket/SocketFileRegionTest.java"
] | diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/multipart/AbstractDiskHttpData.java b/codec-http/src/main/java/io/netty/handler/codec/http/multipart/AbstractDiskHttpData.java
index 544bc7c82da..94309186b41 100644
--- a/codec-http/src/main/java/io/netty/handler/codec/http/multipart/AbstractDiskHttpData... | diff --git a/buffer/src/test/java/io/netty/buffer/ReadOnlyDirectByteBufferBufTest.java b/buffer/src/test/java/io/netty/buffer/ReadOnlyDirectByteBufferBufTest.java
index 5af25396017..f92d5766824 100644
--- a/buffer/src/test/java/io/netty/buffer/ReadOnlyDirectByteBufferBufTest.java
+++ b/buffer/src/test/java/io/netty/buf... | val | val | 2019-08-16T15:18:17 | 2018-06-28T13:58:11Z | leventov | val |
netty/netty/8122_8124 | netty/netty | netty/netty/8122 | netty/netty/8124 | [
"timestamp(timedelta=0.0, similarity=0.870323260503237)"
] | 785473788f3f19531294802b727fb10a48938222 | 182ffdaf6d4c067514fc70b00c4a5abc67753531 | [
"sounds good.",
"Thanks for the PR. Looks good.",
"b109, should we be checking build too?",
"@johnou honestly I think we either should either just assume its ok if people use java8 (and if its not they should really upgrade) or only not use it for java9 and higher. /cc @hc-codersatlas WDYT ?",
"@normanmaure... | [
"Not a part of this commit, but is this commented out code necessary? Same above.",
"Optional: consider splitting the manual safepointer to make the inliner happy."
] | 2018-07-11T11:30:50Z | [
"cleanup"
] | Only apply copyMemoy safepoint for java <= 8 | Hi, as per https://bugs.openjdk.java.net/browse/JDK-8149596 (and the source code of Java.nio.Bits) safepoint polling is no longer required (or rather it shouldn't be done). It's included as part of Unsafe.copyMemory.
Can we add a check to PlatformDependent where this occurs for java version <= 8 so we don't essentia... | [
"common/src/main/java/io/netty/util/internal/PlatformDependent0.java"
] | [
"common/src/main/java/io/netty/util/internal/PlatformDependent0.java"
] | [] | diff --git a/common/src/main/java/io/netty/util/internal/PlatformDependent0.java b/common/src/main/java/io/netty/util/internal/PlatformDependent0.java
index c6ebb55131d..53e9ed7bdcf 100644
--- a/common/src/main/java/io/netty/util/internal/PlatformDependent0.java
+++ b/common/src/main/java/io/netty/util/internal/Platfor... | null | val | val | 2018-08-18T07:28:31 | 2018-07-11T04:17:06Z | re-thc | val |
netty/netty/8134_8136 | netty/netty | netty/netty/8134 | netty/netty/8136 | [
"timestamp(timedelta=88567.0, similarity=0.8846251840296907)"
] | be5b5a3b29806429103c088555b5e211efe9985f | cc246dc1cf3f9363555d0271ee300c19250ea966 | [
"Thanks for reporting but 4.0.x is EOL for over an year. Please upgrade to 4.1.x\n\n> Am 18.07.2018 um 16:59 schrieb Dmitry Shatov <notifications@github.com>:\n> \n> Expected behavior\n> \n> The work of EpollEventLoop without the appearance of any exceptions in the log.\n> \n> Actual behavior\n> \n> Occasionally, t... | [] | 2018-07-18T09:17:15Z | [] | Incorrect use of timerfd_settime system call in epoll-based backend. | ### Expected behavior
The work of EpollEventLoop without the appearance of any exceptions in the log.
### Actual behavior
Occasionally, this exception is logged:
```[NettyIO0] WARN i.netty.channel.epoll.EpollEventLoop - Unexpected exception in the selector loop.
io.netty.channel.ChannelException: timerfd_settime(... | [
"transport-native-epoll/src/main/java/io/netty/channel/epoll/EpollEventLoop.java"
] | [
"transport-native-epoll/src/main/java/io/netty/channel/epoll/EpollEventLoop.java"
] | [] | diff --git a/transport-native-epoll/src/main/java/io/netty/channel/epoll/EpollEventLoop.java b/transport-native-epoll/src/main/java/io/netty/channel/epoll/EpollEventLoop.java
index 4ab1e6d6387..53938f72bbf 100644
--- a/transport-native-epoll/src/main/java/io/netty/channel/epoll/EpollEventLoop.java
+++ b/transport-nativ... | null | train | val | 2018-02-12T18:31:57 | 2018-07-18T08:59:28Z | dshatov | val |
netty/netty/8144_8150 | netty/netty | netty/netty/8144 | netty/netty/8150 | [
"timestamp(timedelta=0.0, similarity=0.8447178205446683)"
] | 952eeb8e1e3706b09d4d3f32f16d7f0e5c540cb5 | 620dad0c2602440f2c457a5cb2a4c7a29e786bda | [
"interesting... Let me investigate ",
"@normanmaurer I have tested this case on netty 4.1.27.Final and netty-tcnative-boringssl-static 2.0.12.Final, the process would not crash any more. It seems that the latest version of boringssl have fixed this issue. Then the validation actually takes place in the io.netty.h... | [
"Is there an issue on tcnarive for this?",
"Not yet... will open one"
] | 2018-07-25T10:12:30Z | [
"defect"
] | Using underscore character('_') as part of SNI leads JVM crash | Hello guys, we use Netty as our network implementation of microservices framework. We plan to support https and thus enable authentication on both client side and server side. But we encounter a problem when we want to use underscore character('_') in TLS SNI.
### Steps to reproduce
#### 1. Netty Server implementat... | [
"handler/src/main/java/io/netty/handler/ssl/Java8SslUtils.java",
"handler/src/main/java/io/netty/handler/ssl/ReferenceCountedOpenSslEngine.java",
"handler/src/main/java/io/netty/handler/ssl/ReferenceCountedOpenSslServerContext.java"
] | [
"handler/src/main/java/io/netty/handler/ssl/Java8SslUtils.java",
"handler/src/main/java/io/netty/handler/ssl/ReferenceCountedOpenSslEngine.java",
"handler/src/main/java/io/netty/handler/ssl/ReferenceCountedOpenSslServerContext.java"
] | [
"handler/src/test/java/io/netty/handler/ssl/Java8SslTestUtils.java",
"handler/src/test/java/io/netty/handler/ssl/OpenSslEngineTest.java"
] | diff --git a/handler/src/main/java/io/netty/handler/ssl/Java8SslUtils.java b/handler/src/main/java/io/netty/handler/ssl/Java8SslUtils.java
index 583d4cf4986..b40c121748d 100644
--- a/handler/src/main/java/io/netty/handler/ssl/Java8SslUtils.java
+++ b/handler/src/main/java/io/netty/handler/ssl/Java8SslUtils.java
@@ -69,... | diff --git a/handler/src/test/java/io/netty/handler/ssl/Java8SslTestUtils.java b/handler/src/test/java/io/netty/handler/ssl/Java8SslTestUtils.java
index 32219ff155a..50fb935d9dc 100644
--- a/handler/src/test/java/io/netty/handler/ssl/Java8SslTestUtils.java
+++ b/handler/src/test/java/io/netty/handler/ssl/Java8SslTestUt... | train | val | 2018-07-25T06:32:28 | 2018-07-23T10:15:27Z | r9liucc | val |
netty/netty/8152_8153 | netty/netty | netty/netty/8152 | netty/netty/8153 | [
"timestamp(timedelta=0.0, similarity=0.9011044041844438)"
] | 952eeb8e1e3706b09d4d3f32f16d7f0e5c540cb5 | 9b08dbca00ffdcb37ec0be2100d868c7c2dd72b9 | [
"@nitsanw doh! I will look into it",
"It looks like the issue is still present in 4.0.\r\n\r\nI ran the tests from https://github.com/netty/netty/pull/8153/files#diff-21be031058403699535d72fa9ea7548fR242 against 4.0 (https://github.com/Gerrrr/netty/commit/69cefda98abf6afe7eaf35b7b0db0e95e28a7f19) and got are two ... | [] | 2018-07-26T07:26:36Z | [
"defect"
] | Leak detection combined with composite buffers results in incorrectly handled writerIndex | This is a nasty bug, which only manifests with leak detection, so would be very confusing in the wild. It was discovered in a test suite which validated with a range of buffer types and resulted in a flaky test. Fortunately composite buffers are not in common use, and leak detection is not permanently on, so the bug sh... | [
"buffer/src/main/java/io/netty/buffer/ByteBufUtil.java"
] | [
"buffer/src/main/java/io/netty/buffer/ByteBufUtil.java"
] | [
"buffer/src/test/java/io/netty/buffer/ByteBufUtilTest.java"
] | diff --git a/buffer/src/main/java/io/netty/buffer/ByteBufUtil.java b/buffer/src/main/java/io/netty/buffer/ByteBufUtil.java
index 0d1b3a9b89f..e7afab36728 100644
--- a/buffer/src/main/java/io/netty/buffer/ByteBufUtil.java
+++ b/buffer/src/main/java/io/netty/buffer/ByteBufUtil.java
@@ -498,7 +498,10 @@ public static int ... | diff --git a/buffer/src/test/java/io/netty/buffer/ByteBufUtilTest.java b/buffer/src/test/java/io/netty/buffer/ByteBufUtilTest.java
index 38e36e20db3..da9b344f406 100644
--- a/buffer/src/test/java/io/netty/buffer/ByteBufUtilTest.java
+++ b/buffer/src/test/java/io/netty/buffer/ByteBufUtilTest.java
@@ -238,6 +238,42 @@ pu... | val | val | 2018-07-25T06:32:28 | 2018-07-25T16:34:36Z | nitsanw | val |
netty/netty/8166_8167 | netty/netty | netty/netty/8166 | netty/netty/8167 | [
"timestamp(timedelta=33843.0, similarity=0.8526570227983766)"
] | 3ab7cac6209cfa3c2d13929123bb61903fe10f58 | 94396e195d816ce9826bd820e3742731ef406d7f | [
"@koo-taejin PTAL https://github.com/netty/netty/pull/8168"
] | [
"Just use\r\n\r\nreturn isSupported() && option instanceof NioChannelOption",
"I have corrected what you said. :)"
] | 2018-08-02T07:28:17Z | [] | In netty-4.1.28.Final version, an error occurs when running on jdk6. | ### Actual behavior
```
io.netty.channel.ChannelException: Unable to create Channel from class class io.netty.channel.socket.nio.NioSocketChannel
Caused by: java.lang.NoClassDefFoundError: java/nio/channels/NetworkChannel
at io.netty.channel.socket.nio.NioSocketChannel.<init>(NioSocketChannel.java:105)
at io.net... | [
"transport/src/main/java/io/netty/channel/socket/nio/NioSocketChannel.java"
] | [
"transport/src/main/java/io/netty/channel/socket/nio/NioSocketChannel.java"
] | [] | diff --git a/transport/src/main/java/io/netty/channel/socket/nio/NioSocketChannel.java b/transport/src/main/java/io/netty/channel/socket/nio/NioSocketChannel.java
index 74431791ce4..e6fec4861ec 100644
--- a/transport/src/main/java/io/netty/channel/socket/nio/NioSocketChannel.java
+++ b/transport/src/main/java/io/netty/... | null | train | val | 2018-08-01T08:31:31 | 2018-08-02T02:37:18Z | koo-taejin | val |
netty/netty/8170_8171 | netty/netty | netty/netty/8170 | netty/netty/8171 | [
"timestamp(timedelta=1.0, similarity=0.851378458133769)"
] | 3ab7cac6209cfa3c2d13929123bb61903fe10f58 | 44d3753c481d61a83097fbbee681512aa8833da8 | [
"Will try to check later today. "
] | [] | 2018-08-02T16:45:19Z | [] | NPE with BoringSSL when trying to init with unsupported Cipher | Trying to run the code from #8165 will NPE when a client attempts to connect.
```java
java.lang.NullPointerException: null
at io.netty.handler.ssl.ReferenceCountedOpenSslContext.destroy(ReferenceCountedOpenSslContext.java:489) ~[netty-all-4.1.28.Final.jar:4.1.28.Final]
at io.netty.handler.ssl.ReferenceCountedOp... | [
"handler/src/main/java/io/netty/handler/ssl/ReferenceCountedOpenSslContext.java"
] | [
"handler/src/main/java/io/netty/handler/ssl/ReferenceCountedOpenSslContext.java"
] | [
"handler/src/test/java/io/netty/handler/ssl/SslContextBuilderTest.java"
] | diff --git a/handler/src/main/java/io/netty/handler/ssl/ReferenceCountedOpenSslContext.java b/handler/src/main/java/io/netty/handler/ssl/ReferenceCountedOpenSslContext.java
index 4a020226776..18c86795744 100644
--- a/handler/src/main/java/io/netty/handler/ssl/ReferenceCountedOpenSslContext.java
+++ b/handler/src/main/j... | diff --git a/handler/src/test/java/io/netty/handler/ssl/SslContextBuilderTest.java b/handler/src/test/java/io/netty/handler/ssl/SslContextBuilderTest.java
index 752424cfb55..0a9429e9c1a 100644
--- a/handler/src/test/java/io/netty/handler/ssl/SslContextBuilderTest.java
+++ b/handler/src/test/java/io/netty/handler/ssl/Ss... | train | val | 2018-08-01T08:31:31 | 2018-08-02T15:35:55Z | rkapsi | val |
netty/netty/8196_8197 | netty/netty | netty/netty/8196 | netty/netty/8197 | [
"timestamp(timedelta=11.0, similarity=0.9039576643540869)",
"keyword_pr_to_issue"
] | 8255f85f24edab5316c0db3aa55bb9709448daa5 | 785473788f3f19531294802b727fb10a48938222 | [
"@vkostyukov thats a good point... We may want to \"replace\" the current implementation with an `AtomicInteger` that is updated . WDYT ?",
"@normanmaurer Yeah, that seems reasonable to me. Even if we won't be able to guarantee certain precision it should be totally fine for the sake of observability (provided we... | [
"I think all these changes should go into `EpollEventLoop` / `NioEventLoop` / `KQueueEventLoop` and the `SingleThreadEventExecutor` should not be changed. This is mainly because otherwise it may produce unexpected effects for people that extend the `SingleThreadEventExecutor`. ",
"This should be final btw."
] | 2018-08-15T17:31:07Z | [
"improvement"
] | (Nio|Epoll)EventLoop.pendingTasks should not block when called outside of event loop | ### Expected behavior
`EventLoop.pendingTasks` should be (reasonably) cheap to invoke so it can be used within observability.
### Actual behavior
We've been experimenting with overriding `EventExecutorChooserFactory` with more superior load balancing algorithms and found out that it might be quite non-trivial ... | [
"common/src/main/java/io/netty/util/concurrent/SingleThreadEventExecutor.java",
"transport-native-epoll/src/main/java/io/netty/channel/epoll/EpollEventLoop.java",
"transport-native-kqueue/src/main/java/io/netty/channel/kqueue/KQueueEventLoop.java",
"transport/src/main/java/io/netty/channel/nio/NioEventLoop.ja... | [
"common/src/main/java/io/netty/util/concurrent/SingleThreadEventExecutor.java",
"transport-native-epoll/src/main/java/io/netty/channel/epoll/EpollEventLoop.java",
"transport-native-kqueue/src/main/java/io/netty/channel/kqueue/KQueueEventLoop.java",
"transport/src/main/java/io/netty/channel/nio/NioEventLoop.ja... | [] | diff --git a/common/src/main/java/io/netty/util/concurrent/SingleThreadEventExecutor.java b/common/src/main/java/io/netty/util/concurrent/SingleThreadEventExecutor.java
index bb51d8f3962..be5814f5955 100644
--- a/common/src/main/java/io/netty/util/concurrent/SingleThreadEventExecutor.java
+++ b/common/src/main/java/io/... | null | train | val | 2018-08-15T20:07:56 | 2018-08-14T17:07:53Z | vkostyukov | val |
netty/netty/8201_8204 | netty/netty | netty/netty/8201 | netty/netty/8204 | [
"timestamp(timedelta=0.0, similarity=0.8970199075001212)"
] | 785473788f3f19531294802b727fb10a48938222 | 8679c5ef43d285b22ae603965bb8254164f1570e | [
"@jprante can you provide a PR ?\r\n\r\n",
"Method handles works just fine in Java 11, see https://github.com/apache/lucene-solr/blob/master/lucene/core/src/java/org/apache/lucene/store/MMapDirectory.java#L339",
"@johnou @jprante I think we should look into using handles... Can you open an issue ?",
"Fixed in... | [
"idle question: why not use PrivilegedExceptionAction ?",
"Could just catch a `Throwable`?",
"@trustin see https://github.com/netty/netty/issues/6096",
"Also honestly I think it will not make any difference. So maybe just keep it ?",
"I think there is not much advantage here.. We will need to unwrap then et... | 2018-08-18T11:55:54Z | [
"defect"
] | CleanerJava9 instantiation fails under SecurityManager | ### Expected behavior
When instantiating `io.netty.util.internal.CleanerJava9`, it should be possible when running under a SecurityManager.
### Actual behavior
`io.netty.util.internal.CleanerJava9` fails with `java.lang.ExceptionInInitializerError`
```
java.lang.ExceptionInInitializerError: null
at io.ne... | [
"common/src/main/java/io/netty/util/internal/CleanerJava9.java"
] | [
"common/src/main/java/io/netty/util/internal/CleanerJava9.java"
] | [] | diff --git a/common/src/main/java/io/netty/util/internal/CleanerJava9.java b/common/src/main/java/io/netty/util/internal/CleanerJava9.java
index d111a7e54a5..3a0c5854c38 100644
--- a/common/src/main/java/io/netty/util/internal/CleanerJava9.java
+++ b/common/src/main/java/io/netty/util/internal/CleanerJava9.java
@@ -21,... | null | val | val | 2018-08-18T07:28:31 | 2018-08-17T08:02:31Z | jprante | val |
netty/netty/8208_8211 | netty/netty | netty/netty/8208 | netty/netty/8211 | [
"timestamp(timedelta=0.0, similarity=0.862535738498586)"
] | 2bb9f64e16dbb5cbbf691e284a97d745378a7b8a | 6888af6ba57ab6b88ad95a9383ee3c3492efec96 | [
"@ramtech123 thanks.. Check https://github.com/netty/netty/pull/8211. This allows you to specify the charset to use while decoding. ",
"Based on my own testing with Windows Server 2016, it seems like Windows auto-detects the encoding. I tried with ANSI (ASCII), Unicode (UTF-16), and UTF-8 and they all worked. I s... | [] | 2018-08-21T16:28:26Z | [] | Support hosts file encoded in unicode format | ### Expected behavior
Netty should be able to resolve IP address from hosts file when the file is encoded in unicode format.
Java is able to resolve hostname from unicode encoded hosts file. Disabling Vertx (Netty) hostname resolution using `-Dvertx.disableDnsResolver=true` flag in our application was the workaroun... | [
"resolver/src/main/java/io/netty/resolver/DefaultHostsFileEntriesResolver.java",
"resolver/src/main/java/io/netty/resolver/HostsFileParser.java"
] | [
"resolver/src/main/java/io/netty/resolver/DefaultHostsFileEntriesResolver.java",
"resolver/src/main/java/io/netty/resolver/HostsFileParser.java"
] | [
"resolver/src/test/java/io/netty/resolver/HostsFileParserTest.java"
] | diff --git a/resolver/src/main/java/io/netty/resolver/DefaultHostsFileEntriesResolver.java b/resolver/src/main/java/io/netty/resolver/DefaultHostsFileEntriesResolver.java
index 7598a29200c..9051262eb1c 100644
--- a/resolver/src/main/java/io/netty/resolver/DefaultHostsFileEntriesResolver.java
+++ b/resolver/src/main/jav... | diff --git a/resolver/src/test/java/io/netty/resolver/HostsFileParserTest.java b/resolver/src/test/java/io/netty/resolver/HostsFileParserTest.java
index 6b908f57420..ac4e4b2eb69 100644
--- a/resolver/src/test/java/io/netty/resolver/HostsFileParserTest.java
+++ b/resolver/src/test/java/io/netty/resolver/HostsFileParserT... | test | val | 2018-08-23T11:07:09 | 2018-08-20T13:29:06Z | ramtech123 | val |
netty/netty/8220_8227 | netty/netty | netty/netty/8220 | netty/netty/8227 | [
"timestamp(timedelta=50.0, similarity=1.0)"
] | 6888af6ba57ab6b88ad95a9383ee3c3492efec96 | 3d3af5b6c7ce5708488e2affec4781223a793b14 | [] | [] | 2018-08-25T01:50:37Z | [
"defect"
] | Recycler will produce npe error when multiple recycled at different thread | Netty version: 4.1.29.Final-SNAPSHOT
public void testMultipleRecycleAtDifferentThread() {
Recycler<HandledObject> recycler = newRecycler(1024);
final HandledObject object = recycler.get();
final Thread thread1 = new Thread(new Runnable() {
@Override
public voi... | [
"common/src/main/java/io/netty/util/Recycler.java"
] | [
"common/src/main/java/io/netty/util/Recycler.java"
] | [
"common/src/test/java/io/netty/util/RecyclerTest.java"
] | diff --git a/common/src/main/java/io/netty/util/Recycler.java b/common/src/main/java/io/netty/util/Recycler.java
index 491464d9a31..5e7db4235b1 100644
--- a/common/src/main/java/io/netty/util/Recycler.java
+++ b/common/src/main/java/io/netty/util/Recycler.java
@@ -216,6 +216,11 @@ public void recycle(Object object) {
... | diff --git a/common/src/test/java/io/netty/util/RecyclerTest.java b/common/src/test/java/io/netty/util/RecyclerTest.java
index 6eeace5f001..e4bcbf1da46 100644
--- a/common/src/test/java/io/netty/util/RecyclerTest.java
+++ b/common/src/test/java/io/netty/util/RecyclerTest.java
@@ -81,6 +81,38 @@ public void testMultiple... | train | val | 2018-08-24T19:48:27 | 2018-08-24T13:12:33Z | zhaojigang | val |
netty/netty/8230_8232 | netty/netty | netty/netty/8230 | netty/netty/8232 | [
"timestamp(timedelta=1.0, similarity=0.9491979909819099)",
"keyword_pr_to_issue"
] | 8679c5ef43d285b22ae603965bb8254164f1570e | 79706357c73ded02615d0445db7503b646ff9547 | [] | [] | 2018-08-28T18:23:59Z | [
"defect"
] | Race condition in the NonStickyEventExecutorGroup class | ### Expected behavior
All `Runnable` tasks submitted through `NonStickyEventExecutorGroup` should get executed.
### Actual behavior
Occasionally the last task submitted is not getting executed.
### Steps to reproduce
The following unit-test has a non-zero chance of failure (about 1/2 of the time fail on my lap... | [
"common/src/main/java/io/netty/util/concurrent/NonStickyEventExecutorGroup.java"
] | [
"common/src/main/java/io/netty/util/concurrent/NonStickyEventExecutorGroup.java"
] | [
"common/src/test/java/io/netty/util/concurrent/NonStickyEventExecutorGroupTest.java"
] | diff --git a/common/src/main/java/io/netty/util/concurrent/NonStickyEventExecutorGroup.java b/common/src/main/java/io/netty/util/concurrent/NonStickyEventExecutorGroup.java
index ed3a5873eca..bcc4b829964 100644
--- a/common/src/main/java/io/netty/util/concurrent/NonStickyEventExecutorGroup.java
+++ b/common/src/main/ja... | diff --git a/common/src/test/java/io/netty/util/concurrent/NonStickyEventExecutorGroupTest.java b/common/src/test/java/io/netty/util/concurrent/NonStickyEventExecutorGroupTest.java
index 16035505e8a..b32df7eb4f7 100644
--- a/common/src/test/java/io/netty/util/concurrent/NonStickyEventExecutorGroupTest.java
+++ b/common... | train | val | 2018-08-28T16:32:29 | 2018-08-28T01:41:06Z | chtyim | val |
netty/netty/8217_8240 | netty/netty | netty/netty/8217 | netty/netty/8240 | [
"timestamp(timedelta=0.0, similarity=0.8585023550456583)"
] | c74b3f3a3b73fee125048b0f486fc9c19fb3bc14 | 3eec66a974f85bb154966750678348afdb694789 | [
"fwiw - we use OpenSSL in some integration tests. They have to run on Java 6. I end-up with implementing this nasty hack (test-code only):\r\n```java\r\n private static void patchOpenSslLogging() {\r\n InternalLoggerFactory originFactory = InternalLoggerFactory.getDefaultFactory();\r\n if (!originF... | [
"mismatch*"
] | 2018-08-30T05:55:29Z | [] | Log4J2LoggerFactory depends on a log4j2 version which does not work on Java 6 | ### Expected behavior
Netty logging works via log4j2 while on Java 6
### Actual behavior
Log4j2 2.4+ depends on Java 7. Netty depends on log4j2 methods which are present only in newer versions. When older log4j2 version is on a classpath then Netty fails to initialize itself due `AbstractMethodError` while logging... | [
"common/src/main/java/io/netty/util/internal/logging/Log4J2Logger.java"
] | [
"common/src/main/java/io/netty/util/internal/logging/Log4J2Logger.java"
] | [] | diff --git a/common/src/main/java/io/netty/util/internal/logging/Log4J2Logger.java b/common/src/main/java/io/netty/util/internal/logging/Log4J2Logger.java
index 36f28083753..5c3593f203a 100644
--- a/common/src/main/java/io/netty/util/internal/logging/Log4J2Logger.java
+++ b/common/src/main/java/io/netty/util/internal/l... | null | train | val | 2018-09-01T08:59:08 | 2018-08-23T16:15:14Z | jerrinot | val |
netty/netty/8273_8286 | netty/netty | netty/netty/8273 | netty/netty/8286 | [
"keyword_pr_to_issue"
] | 9eb124bb629163f4b22ad223f611ed8b4eaa74e8 | 2ab3e13f08e8549c6957aa263390ceb36539b999 | [
"@normanmaurer, please verify it or somebody else.",
"@amizurov merged... thanks"
] | [
"nit: You can remove the `else` here as you return in the if block.",
"@amizurov can you add comment that passing null into `contentEqualsIngoreCase` is fine ?",
"Thanks, done",
"If we passed null to ```contentEqulasIgnoreCase(...)``` this always return false, null safe method."
] | 2018-09-13T12:32:40Z | [] | Resolve charset from ContentType header for SOAP 1.2 requests | Hello, there is a problem with charset resolution from `ContentType` header for SOAP 1.2 using `io.netty.handler.codec.http.HttpUtils` class. SOAP 1.2 could have action parameter in `ContentType` header and method `getCharsetAsSequence(CharSequence contentTypeValue)` from `io.netty.handler.codec.http.HttpUtils` class j... | [
"codec-http/src/main/java/io/netty/handler/codec/http/HttpUtil.java"
] | [
"codec-http/src/main/java/io/netty/handler/codec/http/HttpUtil.java"
] | [
"codec-http/src/test/java/io/netty/handler/codec/http/HttpUtilTest.java"
] | diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/HttpUtil.java b/codec-http/src/main/java/io/netty/handler/codec/http/HttpUtil.java
index 5b6e90e9abd..94af7901fc4 100644
--- a/codec-http/src/main/java/io/netty/handler/codec/http/HttpUtil.java
+++ b/codec-http/src/main/java/io/netty/handler/codec/http/H... | diff --git a/codec-http/src/test/java/io/netty/handler/codec/http/HttpUtilTest.java b/codec-http/src/test/java/io/netty/handler/codec/http/HttpUtilTest.java
index 6ad08e6b4c8..31596067aef 100644
--- a/codec-http/src/test/java/io/netty/handler/codec/http/HttpUtilTest.java
+++ b/codec-http/src/test/java/io/netty/handler/... | val | val | 2018-09-11T20:34:37 | 2018-09-07T13:43:52Z | nikita-mishchenko | val |
netty/netty/8132_8293 | netty/netty | netty/netty/8132 | netty/netty/8293 | [
"timestamp(timedelta=129791.0, similarity=0.8804280547473731)"
] | 04001fdad1ca3c72625cddb1b1c7789381cb5f30 | 0ddc62cec0b4715ae37cef0e6a9f8c79d42d74e9 | [
"I dont think so... if the user requests renegotiation but the protocol does not allow it it should fail (which it does atm)."
] | [
"@carl-mastrangelo @ejona86 @ryanoneill @bryce-anderson @Scottmitch @trustin not sure about this one...",
"@carl-mastrangelo @ejona86 @ryanoneill @bryce-anderson @Scottmitch @trustin this needs to be fixed before merging as it may waste memory. ",
"Currently checking what to do best... ",
"Sounds kinda niche.... | 2018-09-17T13:53:04Z | [] | Do not use TLS renegotiation if TLS >= 1.3 | TLS 1.3 disables renegotiation . Need to check and guard against running the renegotiation code in the SSLHandler and other? places.
Noticed there's a pull request on Java 11 testing and TLS 1.3 is part of 11 (so might as well test it too). | [
"handler/src/main/java/io/netty/handler/ssl/CipherSuiteConverter.java",
"handler/src/main/java/io/netty/handler/ssl/JdkSslContext.java",
"handler/src/main/java/io/netty/handler/ssl/OpenSsl.java",
"handler/src/main/java/io/netty/handler/ssl/ReferenceCountedOpenSslClientContext.java",
"handler/src/main/java/i... | [
"handler/src/main/java/io/netty/handler/ssl/CipherSuiteConverter.java",
"handler/src/main/java/io/netty/handler/ssl/JdkSslContext.java",
"handler/src/main/java/io/netty/handler/ssl/OpenSsl.java",
"handler/src/main/java/io/netty/handler/ssl/ReferenceCountedOpenSslClientContext.java",
"handler/src/main/java/i... | [
"handler/src/test/java/io/netty/handler/ssl/CipherSuiteCanaryTest.java",
"handler/src/test/java/io/netty/handler/ssl/CipherSuiteConverterTest.java",
"handler/src/test/java/io/netty/handler/ssl/ConscryptJdkSslEngineInteropTest.java",
"handler/src/test/java/io/netty/handler/ssl/ConscryptSslEngineTest.java",
"... | diff --git a/handler/src/main/java/io/netty/handler/ssl/CipherSuiteConverter.java b/handler/src/main/java/io/netty/handler/ssl/CipherSuiteConverter.java
index 1fac36c1bca..deeeb0cfeb3 100644
--- a/handler/src/main/java/io/netty/handler/ssl/CipherSuiteConverter.java
+++ b/handler/src/main/java/io/netty/handler/ssl/Ciphe... | diff --git a/handler/src/test/java/io/netty/handler/ssl/CipherSuiteCanaryTest.java b/handler/src/test/java/io/netty/handler/ssl/CipherSuiteCanaryTest.java
index 22e5f43bf88..9c394ccf637 100644
--- a/handler/src/test/java/io/netty/handler/ssl/CipherSuiteCanaryTest.java
+++ b/handler/src/test/java/io/netty/handler/ssl/Ci... | train | val | 2018-10-16T07:05:45 | 2018-07-17T13:56:18Z | re-thc | val |
netty/netty/8299_8305 | netty/netty | netty/netty/8299 | netty/netty/8305 | [
"timestamp(timedelta=105685.0, similarity=0.8497947028522919)"
] | a80c49828f8d52b70e68b8a4c80f677ca44af0af | 9a3be347af35107201f7d4a72416e76cf6b39a82 | [
"Are you interested in providing a PR?",
"@swrdlgc ",
"@swrdlgc actually this can never happen as `deflate(...)` will return the number of bytes written to the output buffer which will be 0 if it was not writable.",
"The good thing is because of this bug report I think I spotted a bug which is unrelated to th... | [] | 2018-09-21T22:14:20Z | [] | Infinite loop in JdkZlibEncoder.deflate() | <pre>
private void deflate(ByteBuf out) {
int numBytes;
do {
int writerIndex = out.writerIndex();
numBytes = deflater.deflate(
out.array(), out.arrayOffset() + writerIndex, out.writableBytes(), Deflater.SYNC_FLUSH);
out.writerIndex(writerIndex + numBytes);
} w... | [
"codec/src/main/java/io/netty/handler/codec/compression/JdkZlibEncoder.java"
] | [
"codec/src/main/java/io/netty/handler/codec/compression/JdkZlibEncoder.java"
] | [] | diff --git a/codec/src/main/java/io/netty/handler/codec/compression/JdkZlibEncoder.java b/codec/src/main/java/io/netty/handler/codec/compression/JdkZlibEncoder.java
index f039fa66e84..276d7f86b0c 100644
--- a/codec/src/main/java/io/netty/handler/codec/compression/JdkZlibEncoder.java
+++ b/codec/src/main/java/io/netty/h... | null | test | val | 2018-09-21T17:04:24 | 2018-09-20T03:09:11Z | swrdlgc | val |
netty/netty/8331_8335 | netty/netty | netty/netty/8331 | netty/netty/8335 | [
"keyword_pr_to_issue"
] | 59973e93dd7da715eee709788573e3515cc50238 | 6138541033ee20fbef864dc5535bcd0db370593e | [
"@rkapsi doh... Want to send over a pr ?",
"@normanmaurer consider it done (hopefully tomorrow morning)"
] | [] | 2018-09-28T14:07:13Z | [
"cleanup"
] | EpollSocketChannelConfig is repeating the channel field 3x | The`EpollSocketChannelConfig` class is repeating the `channel` field 3x through inheritance. The field has also protected and package-private visibility in the super classes which is potentially bug-prone.
![screenshot from 2018-09-27 13-46-22](https://user-images.githubusercontent.com/191635/46164564-542fd200-c25c-... | [
"transport-native-epoll/src/main/java/io/netty/channel/epoll/EpollChannelConfig.java",
"transport-native-epoll/src/main/java/io/netty/channel/epoll/EpollDatagramChannelConfig.java",
"transport-native-epoll/src/main/java/io/netty/channel/epoll/EpollServerChannelConfig.java",
"transport-native-epoll/src/main/ja... | [
"transport-native-epoll/src/main/java/io/netty/channel/epoll/EpollChannelConfig.java",
"transport-native-epoll/src/main/java/io/netty/channel/epoll/EpollDatagramChannelConfig.java",
"transport-native-epoll/src/main/java/io/netty/channel/epoll/EpollServerChannelConfig.java",
"transport-native-epoll/src/main/ja... | [] | diff --git a/transport-native-epoll/src/main/java/io/netty/channel/epoll/EpollChannelConfig.java b/transport-native-epoll/src/main/java/io/netty/channel/epoll/EpollChannelConfig.java
index c0cceb255af..2d2610c0e27 100644
--- a/transport-native-epoll/src/main/java/io/netty/channel/epoll/EpollChannelConfig.java
+++ b/tra... | null | train | val | 2018-09-28T11:34:38 | 2018-09-27T17:53:14Z | rkapsi | val |
netty/netty/8348_8350 | netty/netty | netty/netty/8348 | netty/netty/8350 | [
"timestamp(timedelta=1.0, similarity=1.0000000000000002)"
] | 0e4186c5525eacf8fd1f3ce706c5908546c307ec | 5b3b8db07fdb66d05e1a44193ca7bcaa64420051 | [
"I can fill in some of the blanks about the environment where we've seen the issue:\r\n\r\n### JVM version (e.g. java -version)\r\n\r\n```\r\nopenjdk version \"1.8.0_181\"\r\nOpenJDK Runtime Environment (build 1.8.0_181-8u181-b13-1~deb9u1-b13)\r\nOpenJDK 64-Bit Server VM (build 25.181-b13, mixed mode)\r\n```\r\n\r\... | [] | 2018-10-11T10:55:55Z | [
"defect"
] | epoll_wait produces an EINVAL error since 4.1.30 | ### Expected behavior
epoll_wait should work in 4.1.30 like it did in 4.1.29
### Actual behavior
Since switching to 4.1.30, `EpollEventLoop`'s `handleLoopException` is triggered with
`io.netty.channel.ChannelException: timerfd_settime() failed: Invalid argument`, which points to `timerfd_settime`. This causes a... | [
"transport-native-epoll/src/main/java/io/netty/channel/epoll/EpollEventLoop.java"
] | [
"transport-native-epoll/src/main/java/io/netty/channel/epoll/EpollEventLoop.java"
] | [
"transport-native-epoll/src/test/java/io/netty/channel/epoll/EpollEventLoopTest.java"
] | diff --git a/transport-native-epoll/src/main/java/io/netty/channel/epoll/EpollEventLoop.java b/transport-native-epoll/src/main/java/io/netty/channel/epoll/EpollEventLoop.java
index a2707d96a99..33adf862796 100644
--- a/transport-native-epoll/src/main/java/io/netty/channel/epoll/EpollEventLoop.java
+++ b/transport-nativ... | diff --git a/transport-native-epoll/src/test/java/io/netty/channel/epoll/EpollEventLoopTest.java b/transport-native-epoll/src/test/java/io/netty/channel/epoll/EpollEventLoopTest.java
index ebf529f7328..4e51114422b 100644
--- a/transport-native-epoll/src/test/java/io/netty/channel/epoll/EpollEventLoopTest.java
+++ b/tra... | val | val | 2018-10-11T08:59:47 | 2018-10-11T09:43:34Z | simonbasle | val |
netty/netty/8384_8389 | netty/netty | netty/netty/8384 | netty/netty/8389 | [
"keyword_pr_to_issue"
] | 04001fdad1ca3c72625cddb1b1c7789381cb5f30 | 9eebe7ed742e4ebeca17913782f327412babcf38 | [
"@normanmaurer please let me know if I can send a PR",
"@slandelle I wonder if you would not be better of to just create your `SSLContext` (the java one) directly and then construct the `JdkSslContext` from it (we have a constructor that can wrap an existing `SSLContext`) ?\r\n\r\n",
"Oh right, I didn't notice ... | [
"@slandelle do we need to call `protocols.clone()` if these are not null ?",
"@slandelle maybe mark this constructor as `@deprecated` ?",
"sure",
"right, that would be consistent with SslContextBuilder",
"@slandelle please use java docs style via `{@link ... }`",
"crossing fingers checkstyle won't complai... | 2018-10-16T12:31:36Z | [] | Feature request: let one pass a SecureRandom instance when building SslContext | ### Expected behavior
When spawning multiple `JdkSslContext`, it should be possible to reuse a single SecureRandom instance and save allocations.
### Actual behavior
`SslContextBuilder` won't let one pass a SecureRandom instance.
Both `JdkSslServerContext#newSSLContext` and `JdkSslClientContext#newSSLContext`... | [
"handler/src/main/java/io/netty/handler/ssl/JdkSslContext.java"
] | [
"handler/src/main/java/io/netty/handler/ssl/JdkSslContext.java"
] | [] | diff --git a/handler/src/main/java/io/netty/handler/ssl/JdkSslContext.java b/handler/src/main/java/io/netty/handler/ssl/JdkSslContext.java
index 2b61391b491..6aef52a246f 100644
--- a/handler/src/main/java/io/netty/handler/ssl/JdkSslContext.java
+++ b/handler/src/main/java/io/netty/handler/ssl/JdkSslContext.java
@@ -140... | null | val | val | 2018-10-16T07:05:45 | 2018-10-15T11:31:15Z | slandelle | val |
netty/netty/8400_8403 | netty/netty | netty/netty/8400 | netty/netty/8403 | [
"timestamp(timedelta=1.0, similarity=0.9536387833107202)"
] | 3a4a0432d309dd17de86bd1cf4742030174fc190 | 69545aedc444a380729c3b4cf441cf5b438f939d | [
"@atcurtis thanks for reporting... Should be fixed by https://github.com/netty/netty/pull/8403. PTAL"
] | [] | 2018-10-18T13:16:34Z | [
"defect"
] | CompositeByteBuf.decompose() doesn't work as expected. | ### Expected behavior
It is expected that the arguments to CompositeByteBuf decompose() are the same as for slice()
### Actual behavior
We get random garbage at the start.
### Steps to reproduce
Call decompose with valid arguments.
### Minimal yet complete reproducer code (or URL to code)
ByteBufAl... | [
"buffer/src/main/java/io/netty/buffer/CompositeByteBuf.java"
] | [
"buffer/src/main/java/io/netty/buffer/CompositeByteBuf.java"
] | [
"buffer/src/test/java/io/netty/buffer/AbstractCompositeByteBufTest.java"
] | diff --git a/buffer/src/main/java/io/netty/buffer/CompositeByteBuf.java b/buffer/src/main/java/io/netty/buffer/CompositeByteBuf.java
index 85160c79a6e..f987e48681c 100644
--- a/buffer/src/main/java/io/netty/buffer/CompositeByteBuf.java
+++ b/buffer/src/main/java/io/netty/buffer/CompositeByteBuf.java
@@ -526,39 +526,31 ... | diff --git a/buffer/src/test/java/io/netty/buffer/AbstractCompositeByteBufTest.java b/buffer/src/test/java/io/netty/buffer/AbstractCompositeByteBufTest.java
index 22ca0546aa9..03e55913a06 100644
--- a/buffer/src/test/java/io/netty/buffer/AbstractCompositeByteBufTest.java
+++ b/buffer/src/test/java/io/netty/buffer/Abstr... | train | val | 2018-10-18T19:31:01 | 2018-10-18T04:37:58Z | atcurtis | val |
netty/netty/8398_8408 | netty/netty | netty/netty/8398 | netty/netty/8408 | [
"timestamp(timedelta=365.0, similarity=0.9060999842022229)"
] | 7f391426a2179d3c68e3a116567aa9a0aaf0524c | 25f0450bd9ccc9407e2f6721454c52d8e078c60f | [
"Here is a tentative fix for the described problem: https://github.com/lutovich/netty/commit/bb6b371f0e974814ce1175283c0c06e660180202. I can make it into a PR if the change is acceptable.",
"@lutovich I think this looks good from a quick look. Can you open a pr ?",
"Thanks, @normanmaurer. I created a PR.",
"F... | [
"@lutovich wouldn't that throw and exception when called from within the `EventLoop` as it may possible deadlock ?",
"This appears racy; more than one channel could see isEmpty() == true. So this should be trySuccess()",
"It looks like the previous code called awaitUninterruptibly.",
"Even when on the EventLo... | 2018-10-19T09:29:03Z | [] | FixedChannelPool#close() can return before idle channels are closed | ### Expected behavior
`FixedChannelPool#close()` should return only after all idle channels are closed. Such behavior is expected after https://github.com/netty/netty/pull/7927. Before this PR, method was asynchronous and provided no such guarantees.
### Actual behavior
`FixedChannelPool#close()` offloads actual c... | [
"transport/src/main/java/io/netty/channel/pool/FixedChannelPool.java",
"transport/src/main/java/io/netty/channel/pool/SimpleChannelPool.java"
] | [
"transport/src/main/java/io/netty/channel/pool/FixedChannelPool.java",
"transport/src/main/java/io/netty/channel/pool/SimpleChannelPool.java"
] | [
"transport/src/test/java/io/netty/channel/pool/FixedChannelPoolTest.java",
"transport/src/test/java/io/netty/channel/pool/SimpleChannelPoolTest.java"
] | diff --git a/transport/src/main/java/io/netty/channel/pool/FixedChannelPool.java b/transport/src/main/java/io/netty/channel/pool/FixedChannelPool.java
index 5ca376f88d2..af927dbf7dd 100644
--- a/transport/src/main/java/io/netty/channel/pool/FixedChannelPool.java
+++ b/transport/src/main/java/io/netty/channel/pool/Fixed... | diff --git a/transport/src/test/java/io/netty/channel/pool/FixedChannelPoolTest.java b/transport/src/test/java/io/netty/channel/pool/FixedChannelPoolTest.java
index bbf1debeac5..7b284f431cb 100644
--- a/transport/src/test/java/io/netty/channel/pool/FixedChannelPoolTest.java
+++ b/transport/src/test/java/io/netty/channe... | test | val | 2019-09-12T12:54:25 | 2018-10-17T15:02:56Z | lutovich | val |
netty/netty/8429_8448 | netty/netty | netty/netty/8429 | netty/netty/8448 | [
"timestamp(timedelta=167495.0, similarity=0.9443557595221874)"
] | d4b1202e62e52dc9b5619e666f5b0033d8a32bc9 | 2cdf28216a9cd3745b972f8b7ad250f81ce6173d | [
"@Bennett-Lynch that's a good question.. I like the idea of the `ChannelOption` but I would need to investigate if this is easily doable without breaking any API (I suspect it should be doable).",
"@Bennett-Lynch https://github.com/netty/netty/pull/8448 PTAL",
"@normanmaurer I would like to re-open this issue, ... | [] | 2018-10-31T08:15:05Z | [] | ChannelOption for FIRE_EXCEPTION_ON_FAILURE? | I want to be able to react to *any* outbound channel failure.
I can add a handler to the tail of my pipeline that will call `promise.addListener(ChannelFutureListener.FIRE_EXCEPTION_ON_FAILURE)` for every outbound event, but this is not sufficient.
Specifically, in the case of a `MessageToMessageEncoder` that out... | [
"transport/src/main/java/io/netty/channel/AbstractChannelHandlerContext.java",
"transport/src/main/java/io/netty/channel/ChannelOption.java",
"transport/src/main/java/io/netty/channel/DefaultChannelConfig.java",
"transport/src/main/java/io/netty/channel/DefaultChannelPipeline.java"
] | [
"transport/src/main/java/io/netty/channel/AbstractChannelHandlerContext.java",
"transport/src/main/java/io/netty/channel/ChannelOption.java",
"transport/src/main/java/io/netty/channel/DefaultChannelConfig.java",
"transport/src/main/java/io/netty/channel/DefaultChannelPipeline.java"
] | [] | diff --git a/transport/src/main/java/io/netty/channel/AbstractChannelHandlerContext.java b/transport/src/main/java/io/netty/channel/AbstractChannelHandlerContext.java
index 0a81bd6b0f5..1b3058e4e4d 100644
--- a/transport/src/main/java/io/netty/channel/AbstractChannelHandlerContext.java
+++ b/transport/src/main/java/io/... | null | test | val | 2018-10-30T19:38:02 | 2018-10-24T20:26:02Z | Bennett-Lynch | val |
netty/netty/8475_8476 | netty/netty | netty/netty/8475 | netty/netty/8476 | [
"keyword_pr_to_issue",
"timestamp(timedelta=0.0, similarity=0.8643144759902545)"
] | 11ec7d892e8eca8dc6e05062d02a9f59b6883dce | 845a65b31c93eadd86414e6d0a753cd7a93b04c1 | [
"@vietj thanks! Will provide a fix soon. "
] | [
"Add a bit of javadoc about the meaning of the returned boolean? (especially as we no longer delegate a call to the queue which could have effectively provided that information via its javadoc). Ditto the other `removeTask` methods.",
"Yes this makes things less racy. Why not use a CAS loop here to make even les... | 2018-11-07T13:38:31Z | [] | NioEventLoop task execution might throw UnsupportedOperationException on shutdown | ### Expected behavior
Execution instead throws `RejectedExecutionException`.
### Actual behavior
There is a racy `UnsupportedOperationException` instead because the task removal is delegated to `MpscChunkedArrayQueue` that does not support removal. This happens with `SingleThreadEventExecutor` that overrides the `... | [
"common/src/main/java/io/netty/util/concurrent/SingleThreadEventExecutor.java"
] | [
"common/src/main/java/io/netty/util/concurrent/SingleThreadEventExecutor.java"
] | [
"transport/src/test/java/io/netty/channel/nio/NioEventLoopTest.java"
] | diff --git a/common/src/main/java/io/netty/util/concurrent/SingleThreadEventExecutor.java b/common/src/main/java/io/netty/util/concurrent/SingleThreadEventExecutor.java
index 67959016152..dab7e9500d0 100644
--- a/common/src/main/java/io/netty/util/concurrent/SingleThreadEventExecutor.java
+++ b/common/src/main/java/io/... | diff --git a/transport/src/test/java/io/netty/channel/nio/NioEventLoopTest.java b/transport/src/test/java/io/netty/channel/nio/NioEventLoopTest.java
index d3412c2d996..15fcb212442 100644
--- a/transport/src/test/java/io/netty/channel/nio/NioEventLoopTest.java
+++ b/transport/src/test/java/io/netty/channel/nio/NioEventL... | train | val | 2018-11-14T08:19:06 | 2018-11-07T12:25:19Z | vietj | val |
netty/netty/8480_8482 | netty/netty | netty/netty/8480 | netty/netty/8482 | [
"timestamp(timedelta=0.0, similarity=0.9107569309733597)"
] | 8a24df88a4ff5519176767aee01bf6186015d471 | a140e6dcad0c95b8867f4c6ff1e14537d5fd6cab | [
"@bryce-anderson ouch... yes this is not good :( That said I suspect there will most likely not a lot of problems in real world use-cases as you either use SSL or not for all Channel (sharing between different parent Channels seems very unlikely).\r\n\r\nThat said we should fix. I guess an attribute on the parent c... | [
"nit: you can remove the `()`",
"nit: you can remove the `()`"
] | 2018-11-08T21:31:50Z | [] | Http2StreamFrameToHttpObjectCodec is marked @Sharable but is mutated by channel specific state | ### Expected behavior
The `Http2StreamFrameToHttpObjectCodec` is either _not_ `@Sharable` _or_ it doesn't mutate its `scheme` field when added to a pipeline as it currently does [here](https://github.com/netty/netty/blob/4.1/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2StreamFrameToHttpObjectCodec.jav... | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/Http2StreamFrameToHttpObjectCodec.java"
] | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/Http2StreamFrameToHttpObjectCodec.java"
] | [
"codec-http2/src/test/java/io/netty/handler/codec/http2/Http2StreamFrameToHttpObjectCodecTest.java"
] | diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2StreamFrameToHttpObjectCodec.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2StreamFrameToHttpObjectCodec.java
index 36a7fba1c0c..e13a45fe015 100644
--- a/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2StreamFrameTo... | diff --git a/codec-http2/src/test/java/io/netty/handler/codec/http2/Http2StreamFrameToHttpObjectCodecTest.java b/codec-http2/src/test/java/io/netty/handler/codec/http2/Http2StreamFrameToHttpObjectCodecTest.java
index 45e781c86c4..393a4060ef4 100644
--- a/codec-http2/src/test/java/io/netty/handler/codec/http2/Http2Strea... | test | val | 2018-11-08T15:22:33 | 2018-11-08T19:19:38Z | bryce-anderson | val |
netty/netty/8479_8486 | netty/netty | netty/netty/8479 | netty/netty/8486 | [
"timestamp(timedelta=0.0, similarity=0.9238030710950786)"
] | 8a24df88a4ff5519176767aee01bf6186015d471 | c0dfb568a2e13feb0872243e6d1a57c5dab15fd5 | [
"@tbrooks8 thanks... I will try to find some time to fix this or if you are interested in providing a PR I am happy to review as well :)",
"I might have time tomorrow to put together a PR. I'll let you know.",
"@tbrooks8 don't worry I am able to reproduce with a unit test... Seems to only happen on Java11 tho :... | [
"Could we include the condition under which we can expect this, specifically that the handshake must have already happened/started (and failed?) before the channelActive event was fired.",
"@bryce-anderson yep.. Let me update the comment"
] | 2018-11-09T14:20:46Z | [
"defect"
] | SSLHandler can fail if writes occur before `channelActive` fired | ### Expected behavior
Attempting to write to a channel with an SslHandler when the `channel.writeable.isWritable()` returns true should be allowed.
### Actual behavior
If you attempt to write to a channel with an `SslHandler` prior to `channelActive` being called you can hit an assertion. In particular - if yo... | [
"handler/src/main/java/io/netty/handler/ssl/SslHandler.java"
] | [
"handler/src/main/java/io/netty/handler/ssl/SslHandler.java"
] | [
"handler/src/test/java/io/netty/handler/ssl/SslHandlerTest.java"
] | diff --git a/handler/src/main/java/io/netty/handler/ssl/SslHandler.java b/handler/src/main/java/io/netty/handler/ssl/SslHandler.java
index f1de1360bfe..0e3db8d83a8 100644
--- a/handler/src/main/java/io/netty/handler/ssl/SslHandler.java
+++ b/handler/src/main/java/io/netty/handler/ssl/SslHandler.java
@@ -1745,9 +1745,16... | diff --git a/handler/src/test/java/io/netty/handler/ssl/SslHandlerTest.java b/handler/src/test/java/io/netty/handler/ssl/SslHandlerTest.java
index 75375008f78..ab7a63c908c 100644
--- a/handler/src/test/java/io/netty/handler/ssl/SslHandlerTest.java
+++ b/handler/src/test/java/io/netty/handler/ssl/SslHandlerTest.java
@@ ... | train | val | 2018-11-08T15:22:33 | 2018-11-08T19:15:29Z | Tim-Brooks | val |
netty/netty/8493_8494 | netty/netty | netty/netty/8493 | netty/netty/8494 | [
"timestamp(timedelta=0.0, similarity=0.9500296752188567)"
] | c0dfb568a2e13feb0872243e6d1a57c5dab15fd5 | 4c73d24ea8f1bc4d51d2cd85580edbb48aaef5bb | [
"The same is also true when `starttls` is used."
] | [] | 2018-11-11T18:43:56Z | [
"defect"
] | Handshake timeout may never be scheduled if handshake starts via a flush | Reported by @tbrooks8:
A client (like my case) initiates the handshake in a flush call. The client hello message is generated and flushed. The SSLEngine now returns a handshake status of NEED_UNWRAP.
The channelActive call happens, since the handshake status is not HandshakeStatus.NOT_HANDSHAKING (line 1740), the... | [
"handler/src/main/java/io/netty/handler/ssl/SslHandler.java"
] | [
"handler/src/main/java/io/netty/handler/ssl/SslHandler.java"
] | [
"handler/src/test/java/io/netty/handler/ssl/SslHandlerTest.java"
] | diff --git a/handler/src/main/java/io/netty/handler/ssl/SslHandler.java b/handler/src/main/java/io/netty/handler/ssl/SslHandler.java
index 0e3db8d83a8..4e73796e98c 100644
--- a/handler/src/main/java/io/netty/handler/ssl/SslHandler.java
+++ b/handler/src/main/java/io/netty/handler/ssl/SslHandler.java
@@ -767,6 +767,9 @@... | diff --git a/handler/src/test/java/io/netty/handler/ssl/SslHandlerTest.java b/handler/src/test/java/io/netty/handler/ssl/SslHandlerTest.java
index ab7a63c908c..772a15f9ebc 100644
--- a/handler/src/test/java/io/netty/handler/ssl/SslHandlerTest.java
+++ b/handler/src/test/java/io/netty/handler/ssl/SslHandlerTest.java
@@ ... | train | val | 2018-11-11T07:23:08 | 2018-11-11T06:25:14Z | normanmaurer | val |
netty/netty/8495_8497 | netty/netty | netty/netty/8495 | netty/netty/8497 | [
"keyword_pr_to_issue"
] | 4c73d24ea8f1bc4d51d2cd85580edbb48aaef5bb | 804e1fa9ccf426603e6d478f63c63bc00baae0fa | [
"@rkapsi so just to clarify... this only happens with 4.1.32.Final-SNAPSHOT correct ?",
"Correct, but I built the JAR myself instead of pulling it from maven central.",
"@rkapsi I wonder what happens if you revert: 6563f23a9b72e0efa3b3ededd3bc2ee9911f7402 ?",
"If this does not help my guess would be 44cca1a26... | [
"I think this would be easier to read like this:\r\n\r\n```\r\nByteBuf buffer = s == null ? buf : s;\r\nbuffer.release();\r\n```",
"Can you add a comment that using the PooledByteBufAllocator is important here ?",
"same as above",
"just use `composite.release()`",
"just use `buffer.release()`",
"@normanma... | 2018-11-12T23:08:37Z | [] | Some new leak/reference counting busted in 4.1.32 | I don't have much info yet and no local repro. I basically attempted to open up TLS 1.3 to a broader audience within our corp network and I started instantly getting `IllegalReferenceCountException` being thrown and and ERRORs from the `ResourceLeakDetector`. I don't think it's related to TLS 1.3 though.
1. I starte... | [
"buffer/src/main/java/io/netty/buffer/CompositeByteBuf.java"
] | [
"buffer/src/main/java/io/netty/buffer/CompositeByteBuf.java"
] | [
"buffer/src/test/java/io/netty/buffer/AbstractCompositeByteBufTest.java"
] | diff --git a/buffer/src/main/java/io/netty/buffer/CompositeByteBuf.java b/buffer/src/main/java/io/netty/buffer/CompositeByteBuf.java
index 77ba13fcaec..c9212d5c6e7 100644
--- a/buffer/src/main/java/io/netty/buffer/CompositeByteBuf.java
+++ b/buffer/src/main/java/io/netty/buffer/CompositeByteBuf.java
@@ -513,11 +513,11 ... | diff --git a/buffer/src/test/java/io/netty/buffer/AbstractCompositeByteBufTest.java b/buffer/src/test/java/io/netty/buffer/AbstractCompositeByteBufTest.java
index 363b25d8c74..8e0f148cdf0 100644
--- a/buffer/src/test/java/io/netty/buffer/AbstractCompositeByteBufTest.java
+++ b/buffer/src/test/java/io/netty/buffer/Abstr... | val | val | 2018-11-13T19:22:38 | 2018-11-12T16:26:57Z | rkapsi | val |
netty/netty/8501_8502 | netty/netty | netty/netty/8501 | netty/netty/8502 | [
"timestamp(timedelta=3652.0, similarity=0.8621364628325043)"
] | 88e4817cefb4b4d092e4f6a12f0599c54646db18 | 9d5f8035f269325ebdb87777d4ebf75c2d50ce2f | [
"This is not actually a bug, because the spec states that the method returns `null` if the channel is not connected:\r\n\r\n> {@code null} if this channel is not connected.\r\n\r\nBut could be an improvement because it is useful to have this information in some error handlers.",
"Agree. If `channelInactive` canno... | [] | 2018-11-13T07:29:17Z | [] | In case of connection issue channel.remoteAddress() returns null | ### Expected behavior
It should return the request address, which is correctly passed into the `AnnotatedConnectionException`:
`
protected final Throwable annotateConnectException(Throwable cause, SocketAddress remoteAddress) {
...
}
`
### Actual behavior
It returns `null` when trying to get it ... | [
"transport/src/main/java/io/netty/channel/nio/AbstractNioChannel.java"
] | [
"transport/src/main/java/io/netty/channel/nio/AbstractNioChannel.java"
] | [] | diff --git a/transport/src/main/java/io/netty/channel/nio/AbstractNioChannel.java b/transport/src/main/java/io/netty/channel/nio/AbstractNioChannel.java
index 01467b98361..74f798e7aca 100644
--- a/transport/src/main/java/io/netty/channel/nio/AbstractNioChannel.java
+++ b/transport/src/main/java/io/netty/channel/nio/Abs... | null | train | val | 2018-11-12T20:59:44 | 2018-11-13T07:24:17Z | Andremoniy | val |
netty/netty/8504_8505 | netty/netty | netty/netty/8504 | netty/netty/8505 | [
"timestamp(timedelta=357.0, similarity=0.907145332590514)"
] | 88e4817cefb4b4d092e4f6a12f0599c54646db18 | d42fee2b85d051e2dfd75539ee452cd1bcd04fd7 | [] | [] | 2018-11-13T11:07:38Z | [] | Expose requestedRemoteAddress in the Channel interface (improvement) | ### Expected behavior
Most part of Channel abstract implementations contain `requestedRemoteAddress` object variable, which might be useful for debug purposes. When channel fails to connect in certain circumstances we lose information about what has been requested connect to.
### Actual behavior
`Channel` inte... | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/Http2MultiplexCodec.java",
"transport-native-epoll/src/main/java/io/netty/channel/epoll/AbstractEpollChannel.java",
"transport-native-kqueue/src/main/java/io/netty/channel/kqueue/AbstractKQueueChannel.java",
"transport/src/main/java/io/netty/channel/Abst... | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/Http2MultiplexCodec.java",
"transport-native-epoll/src/main/java/io/netty/channel/epoll/AbstractEpollChannel.java",
"transport-native-kqueue/src/main/java/io/netty/channel/kqueue/AbstractKQueueChannel.java",
"transport/src/main/java/io/netty/channel/Abst... | [] | diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2MultiplexCodec.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2MultiplexCodec.java
index a7ca0bb8311..dabd0c1970a 100644
--- a/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2MultiplexCodec.java
+++ b/codec-http2/src... | null | val | val | 2018-11-12T20:59:44 | 2018-11-13T10:13:16Z | Andremoniy | val |
netty/netty/8566_8569 | netty/netty | netty/netty/8566 | netty/netty/8569 | [
"timestamp(timedelta=0.0, similarity=0.8615711780694038)"
] | 63dc1f5aaac474f0bac60db861bfd6089d7fb688 | 278b49b2a791968c6b80ed0995ef25771b3fd654 | [
"@qinliujie Please check https://github.com/netty/netty/pull/8569",
"@normanmaurer ok, thx~"
] | [
"fix indenting?"
] | 2018-11-16T16:58:11Z | [] | NioEventLoop selector crash and can't recover | ### Expected behavior
```
WARN [HSF-Worker-2-thread-5:t.h.remoting] [] [] [] Unexpected exception in the selector loop.
java.io.IOException: Broken pipe
at sun.nio.ch.EPollArrayWrapper.interrupt(Native Method)
at sun.nio.ch.EPollArrayWrapper.interrupt(EPollArrayWrapper.java:323)
at sun.nio.ch.EPollSelector... | [
"transport/src/main/java/io/netty/channel/nio/NioEventLoop.java"
] | [
"transport/src/main/java/io/netty/channel/nio/NioEventLoop.java"
] | [
"transport/src/test/java/io/netty/channel/nio/NioEventLoopTest.java"
] | diff --git a/transport/src/main/java/io/netty/channel/nio/NioEventLoop.java b/transport/src/main/java/io/netty/channel/nio/NioEventLoop.java
index 187e1ec1a0b..f1aed11bc46 100644
--- a/transport/src/main/java/io/netty/channel/nio/NioEventLoop.java
+++ b/transport/src/main/java/io/netty/channel/nio/NioEventLoop.java
@@ ... | diff --git a/transport/src/test/java/io/netty/channel/nio/NioEventLoopTest.java b/transport/src/test/java/io/netty/channel/nio/NioEventLoopTest.java
index 15fcb212442..8b176bc71c0 100644
--- a/transport/src/test/java/io/netty/channel/nio/NioEventLoopTest.java
+++ b/transport/src/test/java/io/netty/channel/nio/NioEventL... | train | val | 2018-11-16T17:22:03 | 2018-11-16T12:56:19Z | qinliujie | val |
netty/netty/8483_8595 | netty/netty | netty/netty/8483 | netty/netty/8595 | [
"keyword_issue_to_pr"
] | af636267772da6dcde43618b20c5e1be8e418d5f | f4e4147df85b4684cbc8800a8be5ff0fe8bfc58e | [
"Should be fixed by #8595"
] | [
"Presumably there's no need to also pass the args now? If so it would be better to pass null for the last arg to avoid varargs array allocation.",
"from other implementations I think you still should pass the args. ",
"I still don't follow (sorry I'm probably missing something) ... the additional args are only ... | 2018-11-26T12:55:22Z | [
"defect"
] | some problems with netty debug log | ### Expected behavior
netty can print rigth debug log with its parameter.
### Actual behavior
can not print its parameter.
[DEBUG][2018-11-08 16:26:58,872][io.netty.util.internal.logging.InternalLoggerFactory]Using SLF4J as the default logging framework
[DEBUG][2018-11-08 16:26:58,882][io.netty.channel.Multithread... | [
"common/src/main/java/io/netty/util/internal/logging/LocationAwareSlf4JLogger.java"
] | [
"common/src/main/java/io/netty/util/internal/logging/LocationAwareSlf4JLogger.java"
] | [
"common/src/test/java/io/netty/util/internal/logging/Slf4JLoggerFactoryTest.java"
] | diff --git a/common/src/main/java/io/netty/util/internal/logging/LocationAwareSlf4JLogger.java b/common/src/main/java/io/netty/util/internal/logging/LocationAwareSlf4JLogger.java
index 13073b02b41..33eb705a8f0 100644
--- a/common/src/main/java/io/netty/util/internal/logging/LocationAwareSlf4JLogger.java
+++ b/common/sr... | diff --git a/common/src/test/java/io/netty/util/internal/logging/Slf4JLoggerFactoryTest.java b/common/src/test/java/io/netty/util/internal/logging/Slf4JLoggerFactoryTest.java
index 6b3cd850158..8cb2f84f7a9 100644
--- a/common/src/test/java/io/netty/util/internal/logging/Slf4JLoggerFactoryTest.java
+++ b/common/src/test... | val | val | 2018-11-25T21:46:14 | 2018-11-09T01:56:08Z | strongmanwj | val |
netty/netty/6473_8611 | netty/netty | netty/netty/6473 | netty/netty/8611 | [
"keyword_pr_to_issue"
] | a0c3081d8264b3e16d98a87a90250f26c6d9ed53 | d05666ae2d2068da7ee031a8bfc1ca572dbcc3f8 | [
"thanks for reporting @ddossot !",
"@ddossot <3"
] | [
"@madgnome can we please keep the original constructor as well ?",
"please store this as non-mutable set ",
"You always use the opposite `!canBeCombined` so IMHO it would be better to have a `cantBeCombined` instead (I would expect IntelliJ to complain as well).",
"If I'm not missing something, this should be... | 2018-11-30T08:46:04Z | [
"defect"
] | CombinedHttpHeaders indiscriminately combines all headers | ### Expected behavior
`CombinedHttpHeaders` combines all headers per name, even if they shouldn't be combined, like for example the `Set-Cookie` header (per [RFC-7230, section 3.2.2](https://tools.ietf.org/html/rfc7230#section-3.2.2)). In fact, there's only a limited set of headers that can be combined (see this [SO... | [
"codec-http/src/main/java/io/netty/handler/codec/http/CombinedHttpHeaders.java"
] | [
"codec-http/src/main/java/io/netty/handler/codec/http/CombinedHttpHeaders.java"
] | [
"codec-http/src/test/java/io/netty/handler/codec/http/CombinedHttpHeadersTest.java"
] | diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/CombinedHttpHeaders.java b/codec-http/src/main/java/io/netty/handler/codec/http/CombinedHttpHeaders.java
index 2d43b7ad04a..ae494934d7c 100644
--- a/codec-http/src/main/java/io/netty/handler/codec/http/CombinedHttpHeaders.java
+++ b/codec-http/src/main/j... | diff --git a/codec-http/src/test/java/io/netty/handler/codec/http/CombinedHttpHeadersTest.java b/codec-http/src/test/java/io/netty/handler/codec/http/CombinedHttpHeadersTest.java
index e0433efb97c..c63c885a955 100644
--- a/codec-http/src/test/java/io/netty/handler/codec/http/CombinedHttpHeadersTest.java
+++ b/codec-htt... | test | val | 2018-11-29T19:45:52 | 2017-02-28T18:19:41Z | ddossot | val |
netty/netty/5761_8619 | netty/netty | netty/netty/5761 | netty/netty/8619 | [
"keyword_pr_to_issue"
] | aa3c57508b629ebc4aa26f2cf356b7d0a2cc727b | ffc3b2da72c09bb17fd1eb284e1b59bb4ed23b2a | [
"@buchgr thanks for having a look! I think I should write a maven plugin to do this as part of our build just as we do with the autobahn test suite (web sockets)\n",
"@normanmaurer ... and first fix all the errors 😜 \n",
"@buchgr great, thanks for looking at this! Yes ... fixing errors sgtm :stuck_out_tongue_... | [
"why this change ?",
"This will allocate a new Iterator on each loop. Consider using an old style for loop.",
"should we move this check above the for loop as the check is less expensive. ",
"toString() is not needed here.",
"use method chaining ?",
"should we maybe rename tis this `newHttp2HeadersWithPse... | 2018-12-04T02:20:57Z | [] | HTTP/2: Many specification compliancy issues | I ran [h2spec](https://github.com/summerwind/h2spec) against the hello world HTTP/2 server (4.1 branch, with removed HTTP upgrade logic). The result: 70 tests, 37 passed, 1 skipped, **32 failed**.
From skimming over the list of errors, the failed tests seem to be mostly due to Netty responding with wrong error codes.... | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/AbstractHttp2ConnectionHandlerBuilder.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionDecoder.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/HpackDecoder.java",
"codec-http2/src/main/java/io/netty/hand... | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/AbstractHttp2ConnectionHandlerBuilder.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionDecoder.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/HpackDecoder.java",
"codec-http2/src/main/java/io/netty/hand... | [
"codec-http2/src/test/java/io/netty/handler/codec/http2/DataCompressionHttp2Test.java",
"codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionDecoderTest.java",
"codec-http2/src/test/java/io/netty/handler/codec/http2/HpackDecoderTest.java",
"codec-http2/src/test/java/io/netty/handler/c... | diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/AbstractHttp2ConnectionHandlerBuilder.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/AbstractHttp2ConnectionHandlerBuilder.java
index f262b114f09..557341c1897 100644
--- a/codec-http2/src/main/java/io/netty/handler/codec/http2/AbstractHt... | diff --git a/codec-http2/src/test/java/io/netty/handler/codec/http2/DataCompressionHttp2Test.java b/codec-http2/src/test/java/io/netty/handler/codec/http2/DataCompressionHttp2Test.java
index 1d815a330cf..f3b5edffb9b 100644
--- a/codec-http2/src/test/java/io/netty/handler/codec/http2/DataCompressionHttp2Test.java
+++ b/... | train | val | 2019-10-25T20:15:34 | 2016-08-29T13:22:29Z | buchgr | val |
netty/netty/8616_8620 | netty/netty | netty/netty/8616 | netty/netty/8620 | [
"timestamp(timedelta=0.0, similarity=0.8848753518566707)"
] | 268035742317ced8e8d43b9998244f4f0e53316a | 8331248671b9c0ea07cf8dbdfa5d8d2f89fdf459 | [
"@atcurtis can you please try netty 4.1.32.Final and let me know if the same problem happens there as well? I think I remember that we fixed something related to this at some point. \r\n\r\nPlease let me know if after the upgrade the problem still persists.",
"I have tried with 4.1.32.Final and it fails exactly t... | [
"What's the point of this line? Wouldn't we only get here if `handlerRemoved()` was called? Is the concern that someone could override `handlerRemoved()`?",
"This will retain `ctx` until the channel is closed, even if `handlerRemoved()` is called. If this is a one-off initializer (not reused) then that could grea... | 2018-12-04T14:38:50Z | [
"defect"
] | ChannelInitializer.initChannel() executed more than once when used with context executor | ### Expected behavior
Expected ChannelInitializer.initChannel() to be executed one.
### Actual behavior
A subsequent execution causes exception to be thrown because it can't find itself or remove itself again.
```
2018-12-01 01:22:02,527 [WARN] [pool-2-thread-1] ChannelInitializer ? Failed to initialize a... | [
"transport/src/main/java/io/netty/channel/ChannelInitializer.java"
] | [
"transport/src/main/java/io/netty/channel/ChannelInitializer.java"
] | [
"transport/src/test/java/io/netty/channel/ChannelInitializerTest.java"
] | diff --git a/transport/src/main/java/io/netty/channel/ChannelInitializer.java b/transport/src/main/java/io/netty/channel/ChannelInitializer.java
index 9ea1b182219..18344d200fa 100644
--- a/transport/src/main/java/io/netty/channel/ChannelInitializer.java
+++ b/transport/src/main/java/io/netty/channel/ChannelInitializer.... | diff --git a/transport/src/test/java/io/netty/channel/ChannelInitializerTest.java b/transport/src/test/java/io/netty/channel/ChannelInitializerTest.java
index 26b5e4e9fcf..2ac1bcdefa9 100644
--- a/transport/src/test/java/io/netty/channel/ChannelInitializerTest.java
+++ b/transport/src/test/java/io/netty/channel/Channel... | val | val | 2018-12-04T15:26:05 | 2018-12-01T09:28:21Z | atcurtis | val |
netty/netty/8654_8656 | netty/netty | netty/netty/8654 | netty/netty/8656 | [
"timestamp(timedelta=0.0, similarity=0.9126785535287549)"
] | db6d94f82a0f860131392aa483f4d1e21dc74249 | a3844da10bb3ae788017b4c0699373284d60b058 | [
"@mrniko thanks for reporting... should be fixed by https://github.com/netty/netty/pull/8656"
] | [
"Optional: logging fine the the NamingExceptions was useful when developing gRPC's DNS support."
] | 2018-12-13T19:19:19Z | [
"defect",
"android"
] | NoClassDefFoundError on Android platform | ### Expected behavior
No exception
### Actual behavior
Exception arise during invocation DnsServerAddressStreamProviders.platformDefault method in Android application:
```java
java.lang.NoClassDefFoundError: Failed resolution of: Ljavax/naming/directory/InitialDirContext;
at io.netty.resolver.dns.De... | [
"resolver-dns/src/main/java/io/netty/resolver/dns/DefaultDnsServerAddressStreamProvider.java"
] | [
"resolver-dns/src/main/java/io/netty/resolver/dns/DefaultDnsServerAddressStreamProvider.java",
"resolver-dns/src/main/java/io/netty/resolver/dns/DirContextUtils.java"
] | [] | diff --git a/resolver-dns/src/main/java/io/netty/resolver/dns/DefaultDnsServerAddressStreamProvider.java b/resolver-dns/src/main/java/io/netty/resolver/dns/DefaultDnsServerAddressStreamProvider.java
index a5ca38d368b..00be0722952 100644
--- a/resolver-dns/src/main/java/io/netty/resolver/dns/DefaultDnsServerAddressStrea... | null | test | val | 2018-12-14T14:08:03 | 2018-12-13T10:12:41Z | mrniko | val |
netty/netty/8575_8660 | netty/netty | netty/netty/8575 | netty/netty/8660 | [
"timestamp(timedelta=20.0, similarity=0.9711539373903925)"
] | 873988676a2b1bb9cc6e5c1a80e5b27725b1d75c | 52891baae169a47997928b4b228eb0e0a74f93c1 | [
"@ssserj yes this looks like a bug... are you interested in providing a fix ?",
"@normanmaurer I still don’t known how to fix it. I need investigate problem, find proper fix and prepare PR. I’ll try..",
"@ssserj @normanmaurer Hi, could I ask for the state of this, as we sometimes also encounter this in our prod... | [
"can we also add a `assertEquals(0, req.refCnt());` after the `destroy()` call ?",
"use `CharsetUtil.UTF_8`",
"nit: `FullHttpRequest req = ...`",
"Most probably, should be assertEquals(1, req.refCnt()) ?",
"nit: please revert... we usually not do wildcard imports for this kind of things "
] | 2018-12-14T15:22:16Z | [] | Unexpected IllegalReferenceCountException on decode multipart request | ### Actual behavior
```
io.netty.util.IllegalReferenceCountException: refCnt: 0, decrement: 1
at io.netty.util.AbstractReferenceCounted.release0(AbstractReferenceCounted.java:87)
at io.netty.util.AbstractReferenceCounted.release(AbstractReferenceCounted.java:71)
at io.netty.handler.codec.http.multipart.MixedAtt... | [
"codec-http/src/main/java/io/netty/handler/codec/http/multipart/HttpPostMultipartRequestDecoder.java"
] | [
"codec-http/src/main/java/io/netty/handler/codec/http/multipart/HttpPostMultipartRequestDecoder.java"
] | [
"codec-http/src/test/java/io/netty/handler/codec/http/multipart/HttpPostRequestDecoderTest.java"
] | diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/multipart/HttpPostMultipartRequestDecoder.java b/codec-http/src/main/java/io/netty/handler/codec/http/multipart/HttpPostMultipartRequestDecoder.java
index a065b879e11..c3404d9780d 100644
--- a/codec-http/src/main/java/io/netty/handler/codec/http/multipar... | diff --git a/codec-http/src/test/java/io/netty/handler/codec/http/multipart/HttpPostRequestDecoderTest.java b/codec-http/src/test/java/io/netty/handler/codec/http/multipart/HttpPostRequestDecoderTest.java
index d29f6b3cd44..fc258cc8316 100644
--- a/codec-http/src/test/java/io/netty/handler/codec/http/multipart/HttpPost... | val | val | 2019-08-19T08:24:42 | 2018-11-20T09:59:30Z | ssserj | val |
netty/netty/8430_8671 | netty/netty | netty/netty/8430 | netty/netty/8671 | [
"timestamp(timedelta=33.0, similarity=0.8961730063417848)"
] | 26e14118976e37ecc3a6c0c52237fa4f68c54591 | 44b919b698889254959c7d94a327e495c5f8ad31 | [
"For the reference, this is us unsetting the limit in Finagle: https://github.com/twitter/finagle/commit/990c8650366e5374ea062c753a4628c5971fc40e",
"@bryce-anderson @vkostyukov agree... @Scottmitch also told me at some point he wanted to remove it. ",
"@bryce-anderson want to do a PR against the master branch ?... | [
"Aren't `chunkSize` already an `int`?",
"No, it's a `long`. The name is kind of misleading, it might be better as `remainingContent` or something, though that then becomes misleading for `transfer-encoding: chunked` content..."
] | 2018-12-18T17:23:07Z | [
"cleanup"
] | [Netty 5]: Remove the HttpObjectDecoder `maxChunkSize` parameter in Netty 5.x | This is a cleanup request for Netty 5.x. The family of HTTP codecs passes a parameter called `maxChunkSize` to `HttpObjectDecoder` which limits the size of chunks that decoder will emit. Note that this doesn't cause the HTTP dispatch to switch from a `FullHttpMessage` to a regular message or to avoid buffering data, it... | [
"codec-http/src/main/java/io/netty/handler/codec/http/HttpClientCodec.java",
"codec-http/src/main/java/io/netty/handler/codec/http/HttpObjectDecoder.java",
"codec-http/src/main/java/io/netty/handler/codec/http/HttpRequestDecoder.java",
"codec-http/src/main/java/io/netty/handler/codec/http/HttpResponseDecoder.... | [
"codec-http/src/main/java/io/netty/handler/codec/http/HttpClientCodec.java",
"codec-http/src/main/java/io/netty/handler/codec/http/HttpObjectDecoder.java",
"codec-http/src/main/java/io/netty/handler/codec/http/HttpRequestDecoder.java",
"codec-http/src/main/java/io/netty/handler/codec/http/HttpResponseDecoder.... | [
"codec-http/src/test/java/io/netty/handler/codec/http/HttpClientCodecTest.java",
"codec-http/src/test/java/io/netty/handler/codec/http/HttpContentDecoderTest.java",
"codec-http/src/test/java/io/netty/handler/codec/http/HttpRequestDecoderTest.java",
"codec-http/src/test/java/io/netty/handler/codec/http/HttpRes... | diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/HttpClientCodec.java b/codec-http/src/main/java/io/netty/handler/codec/http/HttpClientCodec.java
index dd1da34742b..8770202d0d1 100644
--- a/codec-http/src/main/java/io/netty/handler/codec/http/HttpClientCodec.java
+++ b/codec-http/src/main/java/io/netty... | diff --git a/codec-http/src/test/java/io/netty/handler/codec/http/HttpClientCodecTest.java b/codec-http/src/test/java/io/netty/handler/codec/http/HttpClientCodecTest.java
index 16a6eff29de..416e4d6749e 100644
--- a/codec-http/src/test/java/io/netty/handler/codec/http/HttpClientCodecTest.java
+++ b/codec-http/src/test/j... | train | val | 2018-12-19T12:56:14 | 2018-10-25T16:09:06Z | bryce-anderson | val |
netty/netty/8687_8691 | netty/netty | netty/netty/8687 | netty/netty/8691 | [
"timestamp(timedelta=0.0, similarity=0.8459687228988724)"
] | 6fdd7fcddbe964b2f30d7492a926f4f0bf0f083f | 82ec6ba815adcb3ab057ef8a65f6f620a1ad5611 | [
"@slggamerTrue thanks for reporting. Let me come up with a unit test and fix.",
"@slggamerTrue can you test https://github.com/netty/netty/pull/8691 ?",
"Thanks @normanmaurer. The fix is perfect. Looking forward to the new release. ",
"@slggamerTrue thanks for checking and reporting"
] | [
"Use `nameWithDot` and `mappingWithDot` here?"
] | 2018-12-27T07:49:17Z | [
"defect"
] | Dead Loop in DNS resolver | ### Problem
There is a dead loop in DnsResolveContext.onExpectedResponse when there is a loop in the CNAMES
We found this problem because one DNS meet the problem
![image](https://user-images.githubuserc... | [
"resolver-dns/src/main/java/io/netty/resolver/dns/DnsResolveContext.java"
] | [
"resolver-dns/src/main/java/io/netty/resolver/dns/DnsResolveContext.java"
] | [
"resolver-dns/src/test/java/io/netty/resolver/dns/DnsNameResolverTest.java"
] | diff --git a/resolver-dns/src/main/java/io/netty/resolver/dns/DnsResolveContext.java b/resolver-dns/src/main/java/io/netty/resolver/dns/DnsResolveContext.java
index e75f49c8d46..847bfb5b9f3 100644
--- a/resolver-dns/src/main/java/io/netty/resolver/dns/DnsResolveContext.java
+++ b/resolver-dns/src/main/java/io/netty/res... | diff --git a/resolver-dns/src/test/java/io/netty/resolver/dns/DnsNameResolverTest.java b/resolver-dns/src/test/java/io/netty/resolver/dns/DnsNameResolverTest.java
index 70c8b6b52e0..1326a7975e8 100644
--- a/resolver-dns/src/test/java/io/netty/resolver/dns/DnsNameResolverTest.java
+++ b/resolver-dns/src/test/java/io/net... | val | val | 2019-01-14T07:24:34 | 2018-12-26T01:56:12Z | slggamerTrue | val |
netty/netty/8700_8716 | netty/netty | netty/netty/8700 | netty/netty/8716 | [
"timestamp(timedelta=0.0, similarity=0.8804482505339712)"
] | c424599593b0feee6bb76735cd60ad8f151d21fb | 7988cfec0a32a44a879b60e65ad4a9cabfd3c4d7 | [
"Another somewhat related question.\r\n\r\nWhen using `HttpChunkedInput` with `ChunkedWriteHandler`, `lastHttpContent` would be written/flushed even in case write promise is already reported as a failed one. We rely on `endOfInput` [being](https://github.com/netty/netty/blob/fa84e2b3af45ec7fd47909eff0aa7d2be5a54972... | [
"do we also need to release the message ?",
"Not here, I think... I assume someone who resolved the promise (either with success or with failure) have already done this by calling `closeInput`. That's how the code is organized now. As we're not allocating any new chunks (calling `readChunk`), everything else shou... | 2019-01-14T12:05:56Z | [
"defect"
] | ChunkedWriteHandler may report a failed write as a successful one | ### Expected behavior
If the writing of the last chunk of the chunked input message failed, the corresponding promise should be failed with an appropriate exception.
### Actual behavior
`operationComplete` callback [reports success](https://github.com/netty/netty/blob/fa84e2b3af45ec7fd47909eff0aa7d2be5a54972/... | [
"handler/src/main/java/io/netty/handler/stream/ChunkedWriteHandler.java"
] | [
"handler/src/main/java/io/netty/handler/stream/ChunkedWriteHandler.java"
] | [
"handler/src/test/java/io/netty/handler/stream/ChunkedWriteHandlerTest.java"
] | diff --git a/handler/src/main/java/io/netty/handler/stream/ChunkedWriteHandler.java b/handler/src/main/java/io/netty/handler/stream/ChunkedWriteHandler.java
index b4805d98ef0..f39328dff7a 100644
--- a/handler/src/main/java/io/netty/handler/stream/ChunkedWriteHandler.java
+++ b/handler/src/main/java/io/netty/handler/str... | diff --git a/handler/src/test/java/io/netty/handler/stream/ChunkedWriteHandlerTest.java b/handler/src/test/java/io/netty/handler/stream/ChunkedWriteHandlerTest.java
index 66b69516fc0..5b03048ba69 100644
--- a/handler/src/test/java/io/netty/handler/stream/ChunkedWriteHandlerTest.java
+++ b/handler/src/test/java/io/netty... | train | val | 2019-01-15T08:38:13 | 2019-01-02T17:23:19Z | kachayev | val |
netty/netty/8727_8728 | netty/netty | netty/netty/8727 | netty/netty/8728 | [
"timestamp(timedelta=240.0, similarity=0.991717390100074)"
] | c893939bd89243a1d6423ed86419bcf7748659ec | 1e4481e551696a57c79d3f1acd588171e12e082b | [
"@yulianoifa-mobius thanks a lot for the patch :)"
] | [
"@yulianoifa-mobius please change to 2019",
"Add a CRLF.",
"i guess you meaned to remove CRLF"
] | 2019-01-17T20:08:51Z | [
"defect"
] | Allow IP_FREEBIND option for UDP epoll | ### Expected behavior
while adding IP_FREEBIND option to boostrap it should work with EpollDatagramChannel
### Actual behavior
notification is logged that IP_FREEBIND is unknown option for this type of channel
### Steps to reproduce
set EpollChannelOption.IP_FREEBIND to true on ConnectionlessBootstrap
### Minim... | [
"transport-native-epoll/src/main/java/io/netty/channel/epoll/EpollDatagramChannelConfig.java"
] | [
"transport-native-epoll/src/main/java/io/netty/channel/epoll/EpollDatagramChannelConfig.java"
] | [
"transport-native-epoll/src/test/java/io/netty/channel/epoll/EpollDatagramChannelConfigTest.java"
] | diff --git a/transport-native-epoll/src/main/java/io/netty/channel/epoll/EpollDatagramChannelConfig.java b/transport-native-epoll/src/main/java/io/netty/channel/epoll/EpollDatagramChannelConfig.java
index f3de6ac5947..778b555fa19 100644
--- a/transport-native-epoll/src/main/java/io/netty/channel/epoll/EpollDatagramChan... | diff --git a/transport-native-epoll/src/test/java/io/netty/channel/epoll/EpollDatagramChannelConfigTest.java b/transport-native-epoll/src/test/java/io/netty/channel/epoll/EpollDatagramChannelConfigTest.java
new file mode 100644
index 00000000000..39cf7acd064
--- /dev/null
+++ b/transport-native-epoll/src/test/java/io/n... | test | val | 2019-01-17T09:14:27 | 2019-01-17T19:58:56Z | yulianoifa-mobius | val |
netty/netty/8261_8731 | netty/netty | netty/netty/8261 | netty/netty/8731 | [
"keyword_issue_to_pr"
] | c893939bd89243a1d6423ed86419bcf7748659ec | df5eb060f729a18582d659f868f764edc9a7277e | [
"@johnjaylward would it be possible to try different netty versions and see at which point it breaks ? This would help me a lot. ",
"Are there any breaking points in the API between 4.1.13 and 4.1.20? If not, I don't see an issue with trying on my end.",
"@johnjaylward as the dns resolver is marked as unstable ... | [
"Why this change?",
"@ejona86 it made the test easier to adjust as it also change the number of queries :)",
"Ah. Makes sense."
] | 2019-01-18T13:28:29Z | [
"defect"
] | DNS resolver failing to find valid DNS record | ### Expected behavior
The DNS resolver should find valid DNS records.
### Actual behavior
Exception thrown:
```
Caused by: io.netty.resolver.dns.DnsNameResolverContext$SearchDomainUnknownHostException: Search domain query failed. Original hostname: 'host.toplevel' failed to resolve 'host.toplevel.search.domain' ... | [
"resolver-dns/src/main/java/io/netty/resolver/dns/DnsResolveContext.java"
] | [
"resolver-dns/src/main/java/io/netty/resolver/dns/DnsResolveContext.java"
] | [
"resolver-dns/src/test/java/io/netty/resolver/dns/DnsNameResolverTest.java"
] | diff --git a/resolver-dns/src/main/java/io/netty/resolver/dns/DnsResolveContext.java b/resolver-dns/src/main/java/io/netty/resolver/dns/DnsResolveContext.java
index 847bfb5b9f3..f625be975ce 100644
--- a/resolver-dns/src/main/java/io/netty/resolver/dns/DnsResolveContext.java
+++ b/resolver-dns/src/main/java/io/netty/res... | diff --git a/resolver-dns/src/test/java/io/netty/resolver/dns/DnsNameResolverTest.java b/resolver-dns/src/test/java/io/netty/resolver/dns/DnsNameResolverTest.java
index 1326a7975e8..d03ee870775 100644
--- a/resolver-dns/src/test/java/io/netty/resolver/dns/DnsNameResolverTest.java
+++ b/resolver-dns/src/test/java/io/net... | test | val | 2019-01-17T09:14:27 | 2018-09-04T18:47:33Z | johnjaylward | val |
netty/netty/8743_8744 | netty/netty | netty/netty/8743 | netty/netty/8744 | [
"timestamp(timedelta=1452.0, similarity=1.0)"
] | cf03ed0478c12a7ed400dc00670351d46e0c48e3 | b57364d86c763265639ae812469b3725e155bb75 | [] | [] | 2019-01-22T07:46:38Z | [] | Add logs for allocating large bytebuf in PooledByteBufAllocator | ### Expected behavior
Print logs for allocating large bytebuf in PooledByteBufAllocator, because many applications may care about the memory consumption, and want's to know more info about the memory allocation in case of OOM(for instance, Direct Memory OOM).
### Actual behavior
No logs
### Steps to reproduce
NA
... | [
"buffer/src/main/java/io/netty/buffer/PooledByteBufAllocator.java"
] | [
"buffer/src/main/java/io/netty/buffer/PooledByteBufAllocator.java"
] | [] | diff --git a/buffer/src/main/java/io/netty/buffer/PooledByteBufAllocator.java b/buffer/src/main/java/io/netty/buffer/PooledByteBufAllocator.java
index de6eee1d54d..440b42cef3c 100644
--- a/buffer/src/main/java/io/netty/buffer/PooledByteBufAllocator.java
+++ b/buffer/src/main/java/io/netty/buffer/PooledByteBufAllocator.... | null | test | val | 2019-01-21T13:26:44 | 2019-01-22T07:15:18Z | liupc | val |
netty/netty/8772_8793 | netty/netty | netty/netty/8772 | netty/netty/8793 | [
"keyword_pr_to_issue"
] | 948d4a9ec58aef092c84eb76e672fd06e81cc13c | 32563bfcc129ef9332f175c277e4f6b59fd37d8c | [
"@rkapsi hmmm good question. For me it sounds more like a bug. WDYT ?",
"@normanmaurer same, I'll create a PR"
] | [
"nit: remove empty line",
"assert return value",
"release message ",
"assert return value ",
"ensure to release stuff ",
"call `channel.finish()` and assert return value",
"call `channel.finish()` and assert return value",
"assert return value",
"release message",
"assert return value"
] | 2019-01-28T20:56:44Z | [] | HttpObjectAggregator w/ isStartMessage: Bug or Feature? | Let's say you want to be very selective when and if to aggregate HttpRequests and Responses. Say you want to only aggregate responses with a content-type of application/json. Naturally I went with this:
```java
public class MyHttpObjectAggregator extends HttpObjectAggregator {
public MyHttpObjectAggregator(i... | [
"codec/src/main/java/io/netty/handler/codec/MessageAggregator.java"
] | [
"codec/src/main/java/io/netty/handler/codec/MessageAggregator.java"
] | [
"codec-http/src/test/java/io/netty/handler/codec/http/HttpObjectAggregatorTest.java"
] | diff --git a/codec/src/main/java/io/netty/handler/codec/MessageAggregator.java b/codec/src/main/java/io/netty/handler/codec/MessageAggregator.java
index 2cdb880c993..ca43f1d797a 100644
--- a/codec/src/main/java/io/netty/handler/codec/MessageAggregator.java
+++ b/codec/src/main/java/io/netty/handler/codec/MessageAggrega... | diff --git a/codec-http/src/test/java/io/netty/handler/codec/http/HttpObjectAggregatorTest.java b/codec-http/src/test/java/io/netty/handler/codec/http/HttpObjectAggregatorTest.java
index 7dc0ac5a519..503c93339f0 100644
--- a/codec-http/src/test/java/io/netty/handler/codec/http/HttpObjectAggregatorTest.java
+++ b/codec-... | val | val | 2019-01-28T19:45:38 | 2019-01-23T20:19:21Z | rkapsi | val |
netty/netty/8796_8798 | netty/netty | netty/netty/8796 | netty/netty/8798 | [
"timestamp(timedelta=0.0, similarity=0.883875586006625)"
] | 948d4a9ec58aef092c84eb76e672fd06e81cc13c | a6e6a9151f09e48d92ed96df9b3f4437d78856dc | [
"@aimozg sounds like a bug... Can you submit a PR with a test and fix ?",
"@normanmaurer I'd rather someone more experienced with netty internals do it, really.\r\nI'm unsure how to fix it - \r\n1) Just return an min-size empty ASC?\r\n2) Allow 0-size in constructors? (Is that used somewhere)\r\n3) Something else... | [] | 2019-01-29T14:20:03Z | [
"defect"
] | AppendableCharSequence.subSequence throws instead of returning empty subsequence | I am writing message decoder using as a base approach of `HttpRequestDecoder` (`ByteBuf -> AppendableCharSequence`) and encountered following problem:
`AppendableCharSequence.subSequence(int start, int end);` violates the `CharSequence` interface contract when `start == end`.
### Expected behavior
Return an empty ... | [
"common/src/main/java/io/netty/util/internal/AppendableCharSequence.java"
] | [
"common/src/main/java/io/netty/util/internal/AppendableCharSequence.java"
] | [
"common/src/test/java/io/netty/util/internal/AppendableCharSequenceTest.java"
] | diff --git a/common/src/main/java/io/netty/util/internal/AppendableCharSequence.java b/common/src/main/java/io/netty/util/internal/AppendableCharSequence.java
index 408c32f3802..e8e6abf5661 100644
--- a/common/src/main/java/io/netty/util/internal/AppendableCharSequence.java
+++ b/common/src/main/java/io/netty/util/inte... | diff --git a/common/src/test/java/io/netty/util/internal/AppendableCharSequenceTest.java b/common/src/test/java/io/netty/util/internal/AppendableCharSequenceTest.java
index 2d7bab4ec84..9d08c3ee577 100644
--- a/common/src/test/java/io/netty/util/internal/AppendableCharSequenceTest.java
+++ b/common/src/test/java/io/net... | train | val | 2019-01-28T19:45:38 | 2019-01-29T12:45:31Z | aimozg | val |
netty/netty/8736_8799 | netty/netty | netty/netty/8736 | netty/netty/8799 | [
"timestamp(timedelta=1.0, similarity=0.9442260863139813)"
] | 948d4a9ec58aef092c84eb76e672fd06e81cc13c | 91d3920aa298ea536be7b196f16b32b6ddd27f8d | [] | [
"This flow is a bit convoluted. How about we remove the surrounding if and make it clear why the condition is there:\r\n\r\n```\r\nif (line.length() == 0 && this.trailer == null) {\r\n return LastHttpContent.EMPTY_LAST_CONTENT; // optimization\r\n}\r\n// everything from the if today\r\nLastHttpContent trailer = th... | 2019-01-29T15:29:55Z | [
"defect"
] | HttpObjectDecoder ignores HTTP trailer header. | Hi Netty team !
### Behavior
When I was writing test for https://github.com/netty/netty/pull/8721 in **io.netty.handler.codec.http.HttpContentDecoderTest** I encountered a problem with parsing trailer header using HttpObjectDecoder.
HttpObjectDecoder is not able to handle following bytes sequence
```java
asser... | [
"codec-http/src/main/java/io/netty/handler/codec/http/HttpObjectDecoder.java"
] | [
"codec-http/src/main/java/io/netty/handler/codec/http/HttpObjectDecoder.java"
] | [
"codec-http/src/test/java/io/netty/handler/codec/http/HttpResponseDecoderTest.java"
] | diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/HttpObjectDecoder.java b/codec-http/src/main/java/io/netty/handler/codec/http/HttpObjectDecoder.java
index af1d642a039..f8220cdb04e 100644
--- a/codec-http/src/main/java/io/netty/handler/codec/http/HttpObjectDecoder.java
+++ b/codec-http/src/main/java/io... | diff --git a/codec-http/src/test/java/io/netty/handler/codec/http/HttpResponseDecoderTest.java b/codec-http/src/test/java/io/netty/handler/codec/http/HttpResponseDecoderTest.java
index 017dbd5ff94..f062da2bf1f 100644
--- a/codec-http/src/test/java/io/netty/handler/codec/http/HttpResponseDecoderTest.java
+++ b/codec-htt... | train | val | 2019-01-28T19:45:38 | 2019-01-19T22:19:45Z | KowalczykBartek | val |
netty/netty/7756_8800 | netty/netty | netty/netty/7756 | netty/netty/8800 | [
"keyword_pr_to_issue",
"timestamp(timedelta=19.0, similarity=0.866272799167824)"
] | 8e72071d7648df705fc2372dc63b4840d33846f1 | 4b7e5c96b4e8f0ba5cabd6667fe203002f0390b2 | [
"Yes, this is the excellent feature. Also, I would like to have ElementType.TYPE_PARAMETER as well.\r\n\r\nThe main problem that netty currently support Java 6.",
"This makes perfect sense and we are planing to start work on the next major version of netty very soon which will hopefully be able to fix this.\r\n\r... | [
"2019",
"nit: final",
"nit: `new @Sharable ChannelHandlerAdapter() { };`",
"nit: `new ChannelHandlerAdapter() {};`",
"Is this correct? Child class could be nonsharable, while it extends `@Sharable`.\r\nI think explicit `@Sharable` annotation for sharable classes is a good idea.",
"@doom369 not sure I unde... | 2019-01-29T20:00:21Z | [] | @Sharable should also support @Target(ElementType.TYPE_USE) | ### Expected behavior
`@Sharable` should also be usable with anonymous inner types, so that it is no longer necessary to make named classes (top-level or nested) for sharable handlers. Since Java 8, this is possible with the new `ElementType` `TYPE_USE`.
The practical problem here is that either (a) Netty would have ... | [
"transport/src/main/java/io/netty/channel/ChannelHandler.java",
"transport/src/main/java/io/netty/channel/ChannelHandlerAdapter.java"
] | [
"transport/src/main/java/io/netty/channel/ChannelHandler.java",
"transport/src/main/java/io/netty/channel/ChannelHandlerAdapter.java"
] | [
"transport/src/test/java/io/netty/channel/ChannelHandlerAdapterTest.java"
] | diff --git a/transport/src/main/java/io/netty/channel/ChannelHandler.java b/transport/src/main/java/io/netty/channel/ChannelHandler.java
index aca5901a8b4..1efdca492cf 100644
--- a/transport/src/main/java/io/netty/channel/ChannelHandler.java
+++ b/transport/src/main/java/io/netty/channel/ChannelHandler.java
@@ -210,7 +... | diff --git a/transport/src/test/java/io/netty/channel/ChannelHandlerAdapterTest.java b/transport/src/test/java/io/netty/channel/ChannelHandlerAdapterTest.java
new file mode 100644
index 00000000000..06123dbb56d
--- /dev/null
+++ b/transport/src/test/java/io/netty/channel/ChannelHandlerAdapterTest.java
@@ -0,0 +1,47 @@
... | train | val | 2019-01-30T13:41:42 | 2018-03-01T00:03:09Z | raner | val |
netty/netty/8846_8848 | netty/netty | netty/netty/8846 | netty/netty/8848 | [
"timestamp(timedelta=1.0, similarity=0.9396118449762707)"
] | 737519314153f9146eaf532cd4e945a621cf3fa5 | c68e85b749b5433634dab59823a9748cea72fdf5 | [
"@arukshani sounds about right... Are you interested in providing a PR to fix it ? /cc @bryce-anderson ",
"Yup. Will send a PR with the fix @normanmaurer ",
"Sent the PR https://github.com/netty/netty/pull/8848 to fix this."
] | [
"This requires that Upgrade exists in the same Connection header value as requiredHeaders. But each value could be put in its own Connection header. It would be better to join all the values together with a `,` and then splitHeader(). @normanmaurer, is there not a utility to do that?",
"@ejona86 thats a good poin... | 2019-02-06T15:11:03Z | [
"defect"
] | When more than one connection header is present in h2c upgrade request, upgrade fails | ### Expected behavior
$subject occurs, with this change https://github.com/netty/netty/pull/7824. (@bryce-anderson and @normanmaurer )
Now that more than one connection header is allowed with this https://github.com/netty/netty/pull/7824,
line https://github.com/netty/netty/blob/737519314153f9146eaf532cd4e945a621... | [
"codec-http/src/main/java/io/netty/handler/codec/http/HttpServerUpgradeHandler.java"
] | [
"codec-http/src/main/java/io/netty/handler/codec/http/HttpServerUpgradeHandler.java"
] | [
"codec-http2/src/test/java/io/netty/handler/codec/http2/CleartextHttp2ServerUpgradeHandlerTest.java"
] | diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/HttpServerUpgradeHandler.java b/codec-http/src/main/java/io/netty/handler/codec/http/HttpServerUpgradeHandler.java
index f1f3efcb1de..2b54b0e4b21 100644
--- a/codec-http/src/main/java/io/netty/handler/codec/http/HttpServerUpgradeHandler.java
+++ b/codec-... | diff --git a/codec-http2/src/test/java/io/netty/handler/codec/http2/CleartextHttp2ServerUpgradeHandlerTest.java b/codec-http2/src/test/java/io/netty/handler/codec/http2/CleartextHttp2ServerUpgradeHandlerTest.java
index a544054b668..129f62d7574 100644
--- a/codec-http2/src/test/java/io/netty/handler/codec/http2/Cleartex... | train | val | 2019-02-04T19:07:42 | 2019-02-06T09:10:46Z | arukshani | val |
netty/netty/8862_8863 | netty/netty | netty/netty/8862 | netty/netty/8863 | [
"timestamp(timedelta=0.0, similarity=0.8443789738886954)"
] | c68e85b749b5433634dab59823a9748cea72fdf5 | f176384a729c1d9352c9ed878b9b967ca2f31bf8 | [
"+1"
] | [
"this will spuriously succeed on some machines won't it?",
"It does not matter what we pass here as I implement `AbstractUnsafe.connect(...)` which will just notify the promise. Remember this is no socket etc. "
] | 2019-02-12T23:58:47Z | [
"improvement"
] | Provide more information with the ClosedChannelException when fail operation with it | If we close a Channel because of a failed write we should store the "original" exception in the `ClosedChannelException` that will be used to fail further operations to make it easier to understand why the Channel was closed before.
This came up yesterday in a discussion with @Scottmitch @ejona86 @carl-mastrangelo . | [
"transport/src/main/java/io/netty/channel/AbstractChannel.java"
] | [
"transport/src/main/java/io/netty/channel/AbstractChannel.java",
"transport/src/main/java/io/netty/channel/ExtendedClosedChannelException.java"
] | [
"transport/src/test/java/io/netty/channel/AbstractChannelTest.java"
] | diff --git a/transport/src/main/java/io/netty/channel/AbstractChannel.java b/transport/src/main/java/io/netty/channel/AbstractChannel.java
index 11c14a9624b..8f8fe2f787a 100644
--- a/transport/src/main/java/io/netty/channel/AbstractChannel.java
+++ b/transport/src/main/java/io/netty/channel/AbstractChannel.java
@@ -44,... | diff --git a/transport/src/test/java/io/netty/channel/AbstractChannelTest.java b/transport/src/test/java/io/netty/channel/AbstractChannelTest.java
index fc5fb9b066d..9d5110ea8d8 100644
--- a/transport/src/test/java/io/netty/channel/AbstractChannelTest.java
+++ b/transport/src/test/java/io/netty/channel/AbstractChannelT... | train | val | 2019-02-12T17:05:30 | 2019-02-12T16:02:43Z | normanmaurer | val |
netty/netty/8875_8876 | netty/netty | netty/netty/8875 | netty/netty/8876 | [
"timestamp(timedelta=0.0, similarity=0.8729818833690185)"
] | f176384a729c1d9352c9ed878b9b967ca2f31bf8 | e609b5eeb7daba819f530fea500991c9cfc18412 | [
"@lutovich fix looks good. Please submit a PR :)",
"@normanmaurer done, thank you."
] | [
"please also call `channel.finish()` and assert return value.",
"replace by `writeOutbound(...)` and assert return value",
"replace by `writeOutbound(...)` ",
"please also call `channel.finish()` and assert return value.",
"nit: final",
"private",
"private ",
"private ",
"final ",
"@lutovich Can w... | 2019-02-19T15:49:30Z | [] | ChunkedWriteHandler does not close successful ChunkedInputs | ### Expected behavior
`ChunkedWriteHandler` invokes `ChunkedInput#close()` after the input is fully consumed and `ChunkedInput#isEndOfInput()` returns `true.`
### Actual behavior
`ChunkedInput#close()` is not invoked when the input completes successfully. This can result in resource leaks when the input is based o... | [
"handler/src/main/java/io/netty/handler/stream/ChunkedWriteHandler.java"
] | [
"handler/src/main/java/io/netty/handler/stream/ChunkedWriteHandler.java"
] | [
"handler/src/test/java/io/netty/handler/stream/ChunkedWriteHandlerTest.java"
] | diff --git a/handler/src/main/java/io/netty/handler/stream/ChunkedWriteHandler.java b/handler/src/main/java/io/netty/handler/stream/ChunkedWriteHandler.java
index f39328dff7a..1a1822b5973 100644
--- a/handler/src/main/java/io/netty/handler/stream/ChunkedWriteHandler.java
+++ b/handler/src/main/java/io/netty/handler/str... | diff --git a/handler/src/test/java/io/netty/handler/stream/ChunkedWriteHandlerTest.java b/handler/src/test/java/io/netty/handler/stream/ChunkedWriteHandlerTest.java
index 5b03048ba69..be6951d88bd 100644
--- a/handler/src/test/java/io/netty/handler/stream/ChunkedWriteHandlerTest.java
+++ b/handler/src/test/java/io/netty... | train | val | 2019-02-15T22:13:17 | 2019-02-19T15:25:39Z | lutovich | val |
netty/netty/8868_8885 | netty/netty | netty/netty/8868 | netty/netty/8885 | [
"timestamp(timedelta=0.0, similarity=0.9519903605496893)"
] | d02b51965f6b4906ca1f8f9648c2eb801df7b94a | 81e43d50880fbe007c27e897034fdfa0c844a88b | [
"@georgeOsdDev what you suggest we should do here ? You are saying we should check in the constructor that you do not construct something \"invalid\" ?",
"I'm not sure to check `count` in the constructor.\r\n`sun.nio.ch.FileChannelImpl` does not throws Exception even if `count ` is larger than real file size.\r\n... | [] | 2019-02-25T09:59:48Z | [
"defect"
] | DefaultFileRegion.transferTo with invalid count may cause hang | ### Expected behavior
`DefaultFileRegion.transferTo` will end successfully or throws Exception.
### Actual behavior
Thread will be hang and CPU usage increase to 100%
### Steps to reproduce
Initialize `DefaultFileRegion` with `count` larger than the actual `FileChannel ` size.
```
new DefaultFileRegi... | [
"transport-native-epoll/src/main/java/io/netty/channel/epoll/AbstractEpollStreamChannel.java",
"transport-native-kqueue/src/main/java/io/netty/channel/kqueue/AbstractKQueueStreamChannel.java",
"transport/src/main/java/io/netty/channel/AbstractChannel.java",
"transport/src/main/java/io/netty/channel/DefaultFil... | [
"transport-native-epoll/src/main/java/io/netty/channel/epoll/AbstractEpollStreamChannel.java",
"transport-native-kqueue/src/main/java/io/netty/channel/kqueue/AbstractKQueueStreamChannel.java",
"transport/src/main/java/io/netty/channel/AbstractChannel.java",
"transport/src/main/java/io/netty/channel/DefaultFil... | [
"testsuite/src/main/java/io/netty/testsuite/transport/socket/SocketFileRegionTest.java",
"transport/src/test/java/io/netty/channel/DefaultFileRegionTest.java"
] | diff --git a/transport-native-epoll/src/main/java/io/netty/channel/epoll/AbstractEpollStreamChannel.java b/transport-native-epoll/src/main/java/io/netty/channel/epoll/AbstractEpollStreamChannel.java
index 8d993b48e74..e2f2c88cb72 100644
--- a/transport-native-epoll/src/main/java/io/netty/channel/epoll/AbstractEpollStre... | diff --git a/testsuite/src/main/java/io/netty/testsuite/transport/socket/SocketFileRegionTest.java b/testsuite/src/main/java/io/netty/testsuite/transport/socket/SocketFileRegionTest.java
index 53deb6c6743..881acd1bcff 100644
--- a/testsuite/src/main/java/io/netty/testsuite/transport/socket/SocketFileRegionTest.java
+++... | train | val | 2019-02-25T08:55:55 | 2019-02-15T02:34:21Z | georgeOsdDev | val |
netty/netty/8883_8896 | netty/netty | netty/netty/8883 | netty/netty/8896 | [
"timestamp(timedelta=0.0, similarity=0.9404264630616554)"
] | f8c89e2e055aeb3070d05e6b9425bcff6a8013fd | ee351ef8bcd3d2ee3dcf957741a11429fd67b883 | [
"@kachayev this sounds good... Its also inline with what we do in SslHandler. ",
"@normanmaurer I'll do a PR for WebSockets first, as I know this code quite well. Will check `SslHandler` later ;) ",
"Sorry maybe I was not clear here... we have this kind of code already in SslHandler. I just wanted to mention it... | [
"why is this volatile ?",
"private final ?",
"remove public",
"why do you retain here ? This looks like a possible memory leak.",
"assert both return values",
"Previously, I had an API to change this value after a handshaker is already created. As far as I removed that, I can remove `volatile` either.",
... | 2019-02-27T22:09:27Z | [
"defect",
"improvement",
"feature"
] | Websocket client closing handshake to support "force close" after given timetout | RFC455 defines that, generally, a WebSocket client should not close a TCP connection as far as a server is the one who's responsible for doing that. In practice, when I do not control the server, this might lead to connections leak if the server does not comply with the RFC.
[RFC455#7.1.1](https://tools.ietf.org/htm... | [
"codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketClientHandshaker.java",
"codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketClientHandshaker00.java",
"codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketClientHandshaker07.java",
"codec-http/... | [
"codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketClientHandshaker.java",
"codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketClientHandshaker00.java",
"codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketClientHandshaker07.java",
"codec-http/... | [
"codec-http/src/test/java/io/netty/handler/codec/http/websocketx/WebSocketClientHandshakerTest.java",
"codec-http/src/test/java/io/netty/handler/codec/http/websocketx/WebSocketHandshakeHandOverTest.java"
] | diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketClientHandshaker.java b/codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketClientHandshaker.java
index 44c91445a2a..b293614c16d 100644
--- a/codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSock... | diff --git a/codec-http/src/test/java/io/netty/handler/codec/http/websocketx/WebSocketClientHandshakerTest.java b/codec-http/src/test/java/io/netty/handler/codec/http/websocketx/WebSocketClientHandshakerTest.java
index 2054af513f9..5cb1e0e7b62 100644
--- a/codec-http/src/test/java/io/netty/handler/codec/http/websocketx... | train | val | 2019-04-01T21:02:36 | 2019-02-23T01:58:30Z | kachayev | val |
netty/netty/9018_9019 | netty/netty | netty/netty/9018 | netty/netty/9019 | [
"keyword_pr_to_issue"
] | 4b83be1cebab96cbe99dadb1688068ae668969d2 | 4373a1fba245b3db03cdf3321712d292e2de508b | [
"Sounds good 👌 "
] | [
"final",
"final",
"`getBytes(CharsetUtil.US_ASCII)`",
"`getBytes(CharsetUtil.US_ASCII)`"
] | 2019-04-06T18:09:53Z | [] | SelfSignedCertificate fails with FIPS enabled causing OpenSsl to fail | ### Expected behavior
For compliance reasons, we have BouncyCastle FIPS mode enabled and use Netty's OpenSSL bindings for TLS termination.
I've noticed that Netty is failing to startup correctly since within `OpenSsl.java` static constructor it creates a `SelfSignedCertificate` with **1024** bits -- as such it is... | [
"handler/src/main/java/io/netty/handler/ssl/OpenSsl.java",
"handler/src/main/java/io/netty/handler/ssl/util/SelfSignedCertificate.java"
] | [
"handler/src/main/java/io/netty/handler/ssl/OpenSsl.java",
"handler/src/main/java/io/netty/handler/ssl/util/SelfSignedCertificate.java"
] | [] | diff --git a/handler/src/main/java/io/netty/handler/ssl/OpenSsl.java b/handler/src/main/java/io/netty/handler/ssl/OpenSsl.java
index 5d1dd2b7a0c..a12e5c7c94d 100644
--- a/handler/src/main/java/io/netty/handler/ssl/OpenSsl.java
+++ b/handler/src/main/java/io/netty/handler/ssl/OpenSsl.java
@@ -23,6 +23,7 @@
import io.ne... | null | val | val | 2019-04-08T15:20:14 | 2019-04-05T22:25:36Z | fzakaria | val |
netty/netty/8912_9020 | netty/netty | netty/netty/8912 | netty/netty/9020 | [
"keyword_issue_to_pr",
"keyword_pr_to_issue"
] | e63c596f24d2aa0a52f2a8132ad1283952b45aea | 51112e2b36ec5550a73d72bfc59f4523f7b8ec27 | [
"I mean the idleStateHandler triggers when a channel has not performed a read or write action([in the doc](https://netty.io/4.0/api/io/netty/handler/timeout/IdleStateHandler.html))!\r\n\r\nYou specify that when the channel is not read for 10 seconds then trigger and in the client, you only read all 10 seconds (with... | [
"private ?",
"nit you can remove the `else` as you return in the if block",
"nit you can remove the else as you return in the previous if block ",
"...if nothing was flushed before for the current message or there is no current message",
"Done",
"Done",
"Done",
"Done",
"I would perform the assignmen... | 2019-04-07T14:54:56Z | [] | Handling slow clients / detecting idleness | ### Expected behavior
When using `IdleStateHandler` with `observeOutput=true` the `IdleStateEvent.WRITER_IDLE` or `IdleStateEvent.ALL_IDLE` should not trigger because of slow clients.
This is same issue as in #6150.
### Actual behavior
The `IdleStateHandler` triggers `IdleStateEvent.WRITER_IDLE` or `IdleStateEv... | [
"handler/src/main/java/io/netty/handler/timeout/IdleStateHandler.java",
"transport/src/main/java/io/netty/channel/ChannelOutboundBuffer.java"
] | [
"handler/src/main/java/io/netty/handler/timeout/IdleStateHandler.java",
"transport/src/main/java/io/netty/channel/ChannelOutboundBuffer.java"
] | [
"handler/src/test/java/io/netty/handler/timeout/IdleStateHandlerTest.java"
] | diff --git a/handler/src/main/java/io/netty/handler/timeout/IdleStateHandler.java b/handler/src/main/java/io/netty/handler/timeout/IdleStateHandler.java
index 299e4c7ec79..ee80dcf7e0d 100644
--- a/handler/src/main/java/io/netty/handler/timeout/IdleStateHandler.java
+++ b/handler/src/main/java/io/netty/handler/timeout/I... | diff --git a/handler/src/test/java/io/netty/handler/timeout/IdleStateHandlerTest.java b/handler/src/test/java/io/netty/handler/timeout/IdleStateHandlerTest.java
index a27364f4393..668f3f1ea67 100644
--- a/handler/src/test/java/io/netty/handler/timeout/IdleStateHandlerTest.java
+++ b/handler/src/test/java/io/netty/handl... | train | val | 2019-04-09T09:44:23 | 2019-03-04T08:10:53Z | magnus-gustafsson | val |
netty/netty/9031_9034 | netty/netty | netty/netty/9031 | netty/netty/9034 | [
"keyword_pr_to_issue"
] | 6ed203b7baf4c5797a6692975059b05d26821402 | bedc8a6ea55af69eea382bb802b0b199bf1c9fad | [
"@Mr00Anderson ca. == approximately . So yep PRs welcome "
] | [] | 2019-04-11T19:55:18Z | [] | Typo Documentation - MessageSizeEstimator.class | https://github.com/netty/netty/blob/00afb19d7a37de21b35ce4f6cb3fa7f74809f2ab/transport/src/main/java/io/netty/channel/MessageSizeEstimator.java#L19
"Responsible to estimate size of a message. The size represent how much memory the message will ca. reserve in memory."
I was going through the source and trying to d... | [
"transport/src/main/java/io/netty/channel/MessageSizeEstimator.java"
] | [
"transport/src/main/java/io/netty/channel/MessageSizeEstimator.java"
] | [] | diff --git a/transport/src/main/java/io/netty/channel/MessageSizeEstimator.java b/transport/src/main/java/io/netty/channel/MessageSizeEstimator.java
index 5c84927781a..92f164dc5d5 100644
--- a/transport/src/main/java/io/netty/channel/MessageSizeEstimator.java
+++ b/transport/src/main/java/io/netty/channel/MessageSizeEs... | null | val | val | 2019-04-11T18:54:31 | 2019-04-11T17:14:39Z | Mr00Anderson | val |
netty/netty/9092_9098 | netty/netty | netty/netty/9092 | netty/netty/9098 | [
"keyword_pr_to_issue"
] | ec62af01c7af372d853bd1a2d2d981a897263b6d | 00a9a25f29cf07728794089affdd735af29209de | [
"Nope will look into it next week.\n\nDoes it work when calling channel.close() ?\n\n> Am 26.04.2019 um 14:40 schrieb Michael Nitschinger <notifications@github.com>:\n> \n> In one of my unit tests I have code like:\n> \n> final Throwable expectedCause = new Exception(\"something failed\");\n> EmbeddedChanne... | [] | 2019-04-27T10:44:21Z | [
"defect",
"regression"
] | EmbeddedChannel Close Regression with 4.1.35.Final | In one of my unit tests I have code like:
```java
final Throwable expectedCause = new Exception("something failed");
EmbeddedChannel channel = new EmbeddedChannel(new ChannelOutboundHandlerAdapter() {
@Override
public void close(ChannelHandlerContext ctx, ChannelPromise promise) {
pr... | [
"transport/src/main/java/io/netty/channel/AbstractChannelHandlerContext.java"
] | [
"transport/src/main/java/io/netty/channel/AbstractChannelHandlerContext.java"
] | [
"transport/src/test/java/io/netty/channel/embedded/EmbeddedChannelTest.java"
] | diff --git a/transport/src/main/java/io/netty/channel/AbstractChannelHandlerContext.java b/transport/src/main/java/io/netty/channel/AbstractChannelHandlerContext.java
index 7c68b507049..1ba26fc44ca 100644
--- a/transport/src/main/java/io/netty/channel/AbstractChannelHandlerContext.java
+++ b/transport/src/main/java/io/... | diff --git a/transport/src/test/java/io/netty/channel/embedded/EmbeddedChannelTest.java b/transport/src/test/java/io/netty/channel/embedded/EmbeddedChannelTest.java
index a5dae45afa4..7c715ef13a5 100644
--- a/transport/src/test/java/io/netty/channel/embedded/EmbeddedChannelTest.java
+++ b/transport/src/test/java/io/net... | val | val | 2019-04-26T01:26:08 | 2019-04-26T13:40:12Z | daschl | val |
netty/netty/9099_9103 | netty/netty | netty/netty/9099 | netty/netty/9103 | [
"keyword_issue_to_pr",
"keyword_pr_to_issue"
] | b9c4e17291a5e507877b9c8490e62d65426bce35 | cb85e03d728e8e24be6b9b05070643779948785a | [
"- Which version do you use?\r\n- -1 means no substring found.\r\n- 6 in array `bytes` of your method `test004()` is a byte which will be interpreted `\\u0006` in AsciiString, while \"6\" is a string whose ascii value is `\\u0036`. Combination of these two fact means the result is -1 even if the method `lastIndexO... | [] | 2019-04-29T07:14:15Z | [
"defect"
] | The public int lastIndexOf(CharSequence string) method of the AsciiString class always returns -1 | public int lastIndexOf(CharSequence string) {
// Use count instead of count - 1 so lastIndexOf("") answers count
return lastIndexOf(string, length());
}
@Test
public void test004(){
byte[] bytes = new byte[]{1,2,3,4,5,6,7,8,9,10};
AsciiString ascii = new AsciiString(byte... | [
"common/src/main/java/io/netty/util/AsciiString.java"
] | [
"common/src/main/java/io/netty/util/AsciiString.java"
] | [
"common/src/test/java/io/netty/util/AsciiStringCharacterTest.java"
] | diff --git a/common/src/main/java/io/netty/util/AsciiString.java b/common/src/main/java/io/netty/util/AsciiString.java
index 302b36e89bc..248ae88b214 100644
--- a/common/src/main/java/io/netty/util/AsciiString.java
+++ b/common/src/main/java/io/netty/util/AsciiString.java
@@ -742,7 +742,7 @@ public int indexOf(char ch,... | diff --git a/common/src/test/java/io/netty/util/AsciiStringCharacterTest.java b/common/src/test/java/io/netty/util/AsciiStringCharacterTest.java
index c2a835df660..deff4267d65 100644
--- a/common/src/test/java/io/netty/util/AsciiStringCharacterTest.java
+++ b/common/src/test/java/io/netty/util/AsciiStringCharacterTest.... | val | val | 2019-04-29T20:45:49 | 2019-04-28T08:36:48Z | xiaoheng1 | val |
netty/netty/9131_9132 | netty/netty | netty/netty/9131 | netty/netty/9132 | [
"keyword_pr_to_issue"
] | cb85e03d728e8e24be6b9b05070643779948785a | 3221bf6854dcf16329dffe1fa28c6be5e30269b5 | [
"Since ```ApplicationProtocolNegotiationHandler``` is just conceptually a special case of a ```Channelinitializer```, similar logic should be used when invoking ```configurePipeline()```, and patterns possible in ```ChannelInitializer``` should also be possible in ```ApplicationProtocolNegotiationHandler```. The on... | [
"can you add `{ ...}` to match our code style ? ",
"can you add `{ ...}` to match our code style ? ",
"please use `await(...)` and not `getCount`. if you really not want to call `await(...)` just replace the latch usage with an `AtomicBoolean`. ",
"I didn't want to use ```await(...)``` because it would introd... | 2019-05-07T12:38:52Z | [
"defect"
] | ApplicationProtocolNegotiationHandler loses its place in the context too soon | ### Expected behavior
```
@Override
protected void configurePipeline(ChannelHandlerContext ctx, String protocol)
throws Exception {
ctx.pipeline().replace(this, null, initializer);
// or
ctx.pipeline().addAfter(this, null, initializer);
// or
ctx.pipeline().addBefore(this, null, initializer);
... | [
"handler/src/main/java/io/netty/handler/ssl/ApplicationProtocolNegotiationHandler.java"
] | [
"handler/src/main/java/io/netty/handler/ssl/ApplicationProtocolNegotiationHandler.java"
] | [
"handler/src/test/java/io/netty/handler/ssl/SniHandlerTest.java"
] | diff --git a/handler/src/main/java/io/netty/handler/ssl/ApplicationProtocolNegotiationHandler.java b/handler/src/main/java/io/netty/handler/ssl/ApplicationProtocolNegotiationHandler.java
index 0e3ea0f39a3..3df8cf5cb46 100644
--- a/handler/src/main/java/io/netty/handler/ssl/ApplicationProtocolNegotiationHandler.java
+++... | diff --git a/handler/src/test/java/io/netty/handler/ssl/SniHandlerTest.java b/handler/src/test/java/io/netty/handler/ssl/SniHandlerTest.java
index 8d8003d745e..17d2a6e0e42 100644
--- a/handler/src/test/java/io/netty/handler/ssl/SniHandlerTest.java
+++ b/handler/src/test/java/io/netty/handler/ssl/SniHandlerTest.java
@@ ... | train | val | 2019-05-13T07:03:32 | 2019-05-07T08:50:59Z | RoganDawes | val |
netty/netty/9159_9160 | netty/netty | netty/netty/9159 | netty/netty/9160 | [
"keyword_pr_to_issue"
] | e348bd9217eb626aa20dfd15d7c8c860e1fd7596 | 52c53891900ad3d06d8556d5ad5876103fd9b3b2 | [
"PR submitted: https://github.com/netty/netty/pull/9160"
] | [
"2019",
"just use `assertEquals(expected.key(), actual.key()` .... same for the other lines ",
"call `expected.release()` and `actual.release()` in a finally block. ",
"2019",
"see above",
"see above",
"package-private ? \r\n\r\nplease add javadocs",
"Addressed",
"Addressed",
"Getting a ref count ... | 2019-05-19T23:40:26Z | [] | codec-memcache: copy, duplicate, replace not copying full request/response metadata | ### Expected behavior
Calling `copy()`, `duplicate()` or `replace()` on `FullBinaryMemcacheResponse` or `FullBinaryMemcacheRequest` instances should copy status, opCode, etc. that are defined in `AbstractBinaryMemcacheMessage`.
### Actual behavior
Calling these methods do not copy the data and status, opCode e... | [
"codec-memcache/src/main/java/io/netty/handler/codec/memcache/binary/AbstractBinaryMemcacheMessage.java",
"codec-memcache/src/main/java/io/netty/handler/codec/memcache/binary/DefaultBinaryMemcacheRequest.java",
"codec-memcache/src/main/java/io/netty/handler/codec/memcache/binary/DefaultBinaryMemcacheResponse.ja... | [
"codec-memcache/src/main/java/io/netty/handler/codec/memcache/binary/AbstractBinaryMemcacheMessage.java",
"codec-memcache/src/main/java/io/netty/handler/codec/memcache/binary/DefaultBinaryMemcacheRequest.java",
"codec-memcache/src/main/java/io/netty/handler/codec/memcache/binary/DefaultBinaryMemcacheResponse.ja... | [
"codec-memcache/src/test/java/io/netty/handler/codec/memcache/binary/DefaultFullBinaryMemcacheRequestTest.java",
"codec-memcache/src/test/java/io/netty/handler/codec/memcache/binary/DefaultFullBinaryMemcacheResponseTest.java"
] | diff --git a/codec-memcache/src/main/java/io/netty/handler/codec/memcache/binary/AbstractBinaryMemcacheMessage.java b/codec-memcache/src/main/java/io/netty/handler/codec/memcache/binary/AbstractBinaryMemcacheMessage.java
index c40ddf48d10..c9417e9730d 100644
--- a/codec-memcache/src/main/java/io/netty/handler/codec/mem... | diff --git a/codec-memcache/src/test/java/io/netty/handler/codec/memcache/binary/DefaultFullBinaryMemcacheRequestTest.java b/codec-memcache/src/test/java/io/netty/handler/codec/memcache/binary/DefaultFullBinaryMemcacheRequestTest.java
new file mode 100644
index 00000000000..6b7e98502d9
--- /dev/null
+++ b/codec-memcach... | test | val | 2019-05-22T09:23:09 | 2019-05-19T21:24:25Z | fabienrenaud | val |
netty/netty/9197_9202 | netty/netty | netty/netty/9197 | netty/netty/9202 | [
"keyword_pr_to_issue"
] | e1a881fa2b420866e1987e2ad2bce18e0d9c0b94 | ede7251ecb50b7b53a2fdd8a5152b2327e1ebf14 | [
"I could provide a PR. You can use set Length instead of delete in String Builder btw ",
"@SplotyCode please if you have time :)",
"@SplotyCode Thanks for your suggestion, it's much better."
] | [
"please keep old \"for loop\" style to reduce GC. ",
"Please keep using old \"for loop\" style to reduce GC"
] | 2019-05-30T17:49:30Z | [] | The method toString() of MqttSubscribePayload throw ArrayIndexOutOfBoundsException | ### Expected behavior
print MqttSubscribePayload correctly
### Actual behavior
ArrayIndexOutOfBoundsException was thrown
### Steps to reproduce
new a MqttSubscribePayload which has no topicSubscriptions(size of List<MqttTopicSubscription> is 0)
Though the MqttSubscribePayload couldn't be empty in MQTT protocol.... | [
"codec-mqtt/src/main/java/io/netty/handler/codec/mqtt/MqttSubscribePayload.java",
"codec-mqtt/src/main/java/io/netty/handler/codec/mqtt/MqttUnsubscribePayload.java"
] | [
"codec-mqtt/src/main/java/io/netty/handler/codec/mqtt/MqttSubscribePayload.java",
"codec-mqtt/src/main/java/io/netty/handler/codec/mqtt/MqttUnsubscribePayload.java"
] | [
"codec-mqtt/src/test/java/io/netty/handler/codec/mqtt/MqttConnectPayloadTest.java"
] | diff --git a/codec-mqtt/src/main/java/io/netty/handler/codec/mqtt/MqttSubscribePayload.java b/codec-mqtt/src/main/java/io/netty/handler/codec/mqtt/MqttSubscribePayload.java
index eb1b9c9c572..aa3a3244740 100644
--- a/codec-mqtt/src/main/java/io/netty/handler/codec/mqtt/MqttSubscribePayload.java
+++ b/codec-mqtt/src/mai... | diff --git a/codec-mqtt/src/test/java/io/netty/handler/codec/mqtt/MqttConnectPayloadTest.java b/codec-mqtt/src/test/java/io/netty/handler/codec/mqtt/MqttConnectPayloadTest.java
index 5a929dc1e5e..f1d9dc0db10 100644
--- a/codec-mqtt/src/test/java/io/netty/handler/codec/mqtt/MqttConnectPayloadTest.java
+++ b/codec-mqtt/s... | train | val | 2019-05-27T16:05:40 | 2019-05-29T17:13:21Z | xiangwangcheng | val |
netty/netty/9205_9206 | netty/netty | netty/netty/9205 | netty/netty/9206 | [
"keyword_pr_to_issue"
] | ac95ff8b631124f3e646a7550ea6b686cfcc092d | 3c36ce6b5ca859f8939f09309e248e41bc3ef2bb | [
"@slandelle will you provide a PR ?",
"FYI, it's currently very hard to workaround this issue by subclassing WebSocketClientHandshaker13: `expectedChallengeResponseString` is private, `WebSocketUtil` is package private.\r\n\r\nI would love to contribute a fix but I'd like your opinion:\r\n\r\n* is this too much o... | [
"we use 4 spaces...",
"can the constructors be package-private for now ?",
"It's very hard to break parameters lists with IntelliJ because it displays parameter names... It would be great to have a maven plugin for formatting the code automatically.",
"@normanmaurer Where can I find the formatting rules? I ca... | 2019-05-31T13:26:34Z | [] | WebSocketClientHandshaker13 doesn't work with HTTP proxies over clear HTTP | ### Expected behavior
When talking with an HTTP proxy over clear HTTP, a user agent should sent requests with an **absolute** url.
### Actual behavior
`WebSocketClientHandshaker13::newHandshakeRequest` generates a request with [relative url](https://github.com/netty/netty/blob/netty-4.1.36.Final/codec-http/src... | [
"codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketClientHandshaker.java",
"codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketClientHandshaker00.java",
"codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketClientHandshaker07.java",
"codec-http/... | [
"codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketClientHandshaker.java",
"codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketClientHandshaker00.java",
"codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketClientHandshaker07.java",
"codec-http/... | [
"codec-http/src/test/java/io/netty/handler/codec/http/websocketx/WebSocketClientHandshaker00Test.java",
"codec-http/src/test/java/io/netty/handler/codec/http/websocketx/WebSocketClientHandshaker07Test.java",
"codec-http/src/test/java/io/netty/handler/codec/http/websocketx/WebSocketClientHandshaker08Test.java",
... | diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketClientHandshaker.java b/codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketClientHandshaker.java
index 79d499d583e..1ec598bf4a4 100644
--- a/codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSock... | diff --git a/codec-http/src/test/java/io/netty/handler/codec/http/websocketx/WebSocketClientHandshaker00Test.java b/codec-http/src/test/java/io/netty/handler/codec/http/websocketx/WebSocketClientHandshaker00Test.java
index 33c6ce6847e..9b0432a1999 100644
--- a/codec-http/src/test/java/io/netty/handler/codec/http/websoc... | train | val | 2019-06-07T22:51:25 | 2019-05-31T12:38:12Z | slandelle | val |
netty/netty/9208_9211 | netty/netty | netty/netty/9208 | netty/netty/9211 | [
"keyword_issue_to_pr"
] | ec69da9afb8388c9ff7e25b2a6bc78c9bf91fb07 | b91889c3db5f1ad90d2061df003bb95fe7510de4 | [
"There is no `fireHandlerXXX` method in `ChannelHandlerContext`, only `fireChannelXXX` method. If you want to propagate handler Removed event, you can try `fireUserEventTriggered`.\r\n\r\n",
"My understanding of channelReadComplete () may not be sufficient.\r\n\r\nIf it is a valid specification that channelReadCo... | [] | 2019-06-01T16:31:27Z | [] | readComplete when handlerRemoved | ### Expected behavior
dont call fireChannelReadComplete
call fireHandlerRemoved or nothing
### Actual behavior
call fireChannelReadComplete
https://github.com/netty/netty/blob/a33200ca38990b88315a48637e5ac5da398b100d/codec/src/main/java/io/netty/handler/codec/ByteToMessageDecoder.java
line 255
>ctx.fireChann... | [
"codec/src/main/java/io/netty/handler/codec/ByteToMessageDecoder.java"
] | [
"codec/src/main/java/io/netty/handler/codec/ByteToMessageDecoder.java"
] | [] | diff --git a/codec/src/main/java/io/netty/handler/codec/ByteToMessageDecoder.java b/codec/src/main/java/io/netty/handler/codec/ByteToMessageDecoder.java
index bed1efc211c..0457a93abdc 100644
--- a/codec/src/main/java/io/netty/handler/codec/ByteToMessageDecoder.java
+++ b/codec/src/main/java/io/netty/handler/codec/ByteT... | null | train | val | 2019-05-31T07:04:03 | 2019-05-31T22:26:45Z | lifeinwild | val |
netty/netty/9105_9247 | netty/netty | netty/netty/9105 | netty/netty/9247 | [
"keyword_issue_to_pr"
] | 6381d0766ab8438b5702791cd826d79ade4adf52 | c9aaa93d83b5b571dbc733d2632232db82b3d884 | [
"@nitsanw FYI... ",
"AFAIK the only misbehaviours could happen by using offer of a single-producer JCTools queue or just relaxedPoll instead of poll.\r\nThe first one seems not the case here, while on consumer side just using a mix of relaxedPoll()/drain() with poll()/isEmpty() is enough to guarantee strict empty... | [] | 2019-06-17T15:21:22Z | [] | Support pluggable EventLoop task queue | The default task queue used by EPoll and NIO EventLoop implementations is provided by JCTools, and while it is efficient it has some undesirable properties. Specifically, it is not non-blocking, and can lead to the EventLoop busy-spinning waiting for a task that may not be provided promptly because the offering thread... | [
"common/src/main/java/io/netty/util/concurrent/SingleThreadEventExecutor.java",
"transport-native-epoll/src/main/java/io/netty/channel/epoll/EpollEventLoop.java",
"transport-native-epoll/src/main/java/io/netty/channel/epoll/EpollEventLoopGroup.java",
"transport-native-kqueue/src/main/java/io/netty/channel/kqu... | [
"common/src/main/java/io/netty/util/concurrent/SingleThreadEventExecutor.java",
"transport-native-epoll/src/main/java/io/netty/channel/epoll/EpollEventLoop.java",
"transport-native-epoll/src/main/java/io/netty/channel/epoll/EpollEventLoopGroup.java",
"transport-native-kqueue/src/main/java/io/netty/channel/kqu... | [
"transport-native-epoll/src/test/java/io/netty/channel/epoll/EpollEventLoopTest.java",
"transport/src/test/java/io/netty/channel/nio/NioEventLoopTest.java"
] | diff --git a/common/src/main/java/io/netty/util/concurrent/SingleThreadEventExecutor.java b/common/src/main/java/io/netty/util/concurrent/SingleThreadEventExecutor.java
index 92b648889e7..a7aee9a4c6b 100644
--- a/common/src/main/java/io/netty/util/concurrent/SingleThreadEventExecutor.java
+++ b/common/src/main/java/io/... | diff --git a/transport-native-epoll/src/test/java/io/netty/channel/epoll/EpollEventLoopTest.java b/transport-native-epoll/src/test/java/io/netty/channel/epoll/EpollEventLoopTest.java
index f250c272e64..71c56b6d863 100644
--- a/transport-native-epoll/src/test/java/io/netty/channel/epoll/EpollEventLoopTest.java
+++ b/tra... | train | val | 2019-06-19T20:50:27 | 2019-04-29T12:00:47Z | belliottsmith | val |
netty/netty/9201_9250 | netty/netty | netty/netty/9201 | netty/netty/9250 | [
"keyword_pr_to_issue"
] | 6381d0766ab8438b5702791cd826d79ade4adf52 | 712077cdef050bc9aa211d301a1bdc3e763b6097 | [
"@shevah yes this sounds like a bug... Would you be willing to create a PR to fix it ?",
"Yes"
] | [
"imho we should call `retain` as last method to ensure we can not leak ",
"`toString(...)` will never return null so this does not look correct. Maybe it should check if the buffer is empty ?",
"why not an `ArrayList` to reduce the GC ?",
"why not an `ArrayList` to reduce the GC ?",
"why not an `ArrayList` ... | 2019-06-17T16:20:31Z | [] | HAProxyMessage memory leak due unreleased TLVs | `HAProxyMessage` isn't a `ReferencedCounted` object.
A component consuming an `HAProxyMessage` object and not passing it further might not release it, while it should be released as it contains a list of TLVs created in the static function `readNextTLV`:
https://github.com/netty/netty/blob/00afb19d7a37de21b35ce4f6... | [
"codec-haproxy/src/main/java/io/netty/handler/codec/haproxy/HAProxyMessage.java"
] | [
"codec-haproxy/src/main/java/io/netty/handler/codec/haproxy/HAProxyMessage.java"
] | [
"codec-haproxy/src/test/java/io/netty/handler/codec/haproxy/HAProxyMessageDecoderTest.java"
] | diff --git a/codec-haproxy/src/main/java/io/netty/handler/codec/haproxy/HAProxyMessage.java b/codec-haproxy/src/main/java/io/netty/handler/codec/haproxy/HAProxyMessage.java
index b40bf42df26..bc623855915 100644
--- a/codec-haproxy/src/main/java/io/netty/handler/codec/haproxy/HAProxyMessage.java
+++ b/codec-haproxy/src/... | diff --git a/codec-haproxy/src/test/java/io/netty/handler/codec/haproxy/HAProxyMessageDecoderTest.java b/codec-haproxy/src/test/java/io/netty/handler/codec/haproxy/HAProxyMessageDecoderTest.java
index 2d4039de3d0..02ff285565c 100644
--- a/codec-haproxy/src/test/java/io/netty/handler/codec/haproxy/HAProxyMessageDecoderT... | train | val | 2019-06-19T20:50:27 | 2019-05-30T15:52:03Z | shevah | val |
netty/netty/9278_9280 | netty/netty | netty/netty/9278 | netty/netty/9280 | [
"keyword_pr_to_issue"
] | 039087ed47a482a08ded357b047850830b65e8b9 | 18b7bdff12afb3dd6c6d579d4ade7159079afd36 | [
"The issue is that on this line\r\n\r\nhttps://github.com/netty/netty/commit/8f7ef1cabb5442584e56a9e79bcb9696bc572a94#diff-006d8822b20e6bcf0e9f5f2470153807R166\r\n\r\nThe call to retrieve the method is returning `null` on GraalVM. The issue has a knock on effect as previous versions of Netty allows handlers to not ... | [] | 2019-06-25T06:12:12Z | [] | Micronaut Graal native-images doesn't work anymore with Netty 4.1.35+ | ### Expected behavior
I'm trying to upgrade Micronaut to use Netty 4.1.35 or later and it should be possible to build Micronaut GraalVM native-images with that Netty version.
I know that Netty introduced Graal support in 4.1.36 but it uses the old approach, meaning that it's compatible with Graal pre-19.0.0 version... | [
"transport/src/main/java/io/netty/channel/ChannelHandlerMask.java"
] | [
"transport/src/main/java/io/netty/channel/ChannelHandlerMask.java"
] | [] | diff --git a/transport/src/main/java/io/netty/channel/ChannelHandlerMask.java b/transport/src/main/java/io/netty/channel/ChannelHandlerMask.java
index ef384433280..526006a84e3 100644
--- a/transport/src/main/java/io/netty/channel/ChannelHandlerMask.java
+++ b/transport/src/main/java/io/netty/channel/ChannelHandlerMask.... | null | train | val | 2019-06-24T23:11:24 | 2019-06-24T15:34:21Z | ilopmar | val |
netty/netty/9301_9304 | netty/netty | netty/netty/9301 | netty/netty/9304 | [
"keyword_pr_to_issue"
] | 262ced7ce4a9254fb55046aee89f0ff4d15e17f1 | 4596f9e1397ffbc7d1a68b670e529dcf3a5d6036 | [
"This should be an issue. The way to find the remainder is either `length % 16` or `length & 15`. `length & 15` performs better.\r\n\r\n",
"@qeesung yes，i think so.",
"PR welcome\n\n> Am 29.06.2019 um 08:15 schrieb xiaoheng1 <notifications@github.com>:\n> \n> @qeesung yes，i think so.\n> \n> —\n> You are receivi... | [] | 2019-06-29T13:05:10Z | [] | ByteBufUtil.prettyHexDump may have a problem when calculating the initial capacity of StringBuilder | i use netty4.1.34
source code in netty4.1.34
```
private static String prettyHexDump(ByteBuf buffer, int offset, int length) {
if (length == 0) {
return StringUtil.EMPTY_STRING;
} else {
int rows = length / 16 + (length % 15 == 0? 0 : 1) + 4;
... | [
"buffer/src/main/java/io/netty/buffer/ByteBufUtil.java"
] | [
"buffer/src/main/java/io/netty/buffer/ByteBufUtil.java"
] | [] | diff --git a/buffer/src/main/java/io/netty/buffer/ByteBufUtil.java b/buffer/src/main/java/io/netty/buffer/ByteBufUtil.java
index ae8d9ed3ea2..b8fb5b446f7 100644
--- a/buffer/src/main/java/io/netty/buffer/ByteBufUtil.java
+++ b/buffer/src/main/java/io/netty/buffer/ByteBufUtil.java
@@ -1095,7 +1095,7 @@ private static St... | null | val | val | 2019-06-29T12:16:58 | 2019-06-29T03:21:41Z | xiaoheng1 | val |
netty/netty/9305_9306 | netty/netty | netty/netty/9305 | netty/netty/9306 | [
"keyword_issue_to_pr"
] | 262ced7ce4a9254fb55046aee89f0ff4d15e17f1 | f8c1f350dbe6424036693bf5c0a62dfa39512818 | [
"@xiaoheng1 good point... are you willing to open a PR ?",
"@normanmaurer I am glad to，i will open a PR.",
"#9306 Fix public int read() throws IOException method exceeds the limit of length"
] | [
"nit: merge both lines ",
"Call buf.release() and in.close()",
"Call buf2.release() and in2.close()",
"@normanmaurer ok, i add it."
] | 2019-06-29T17:34:06Z | [] | ByteBufInputStream.read() may have a problem | i use netty4.1.34
souce code:
```
public int read() throws IOException {
if (!buffer.isReadable()) {
return -1;
}
return buffer.readByte() & 0xff;
}
```
In my opinion, the buffer.isReadable() method should not be used here to judge, but the available() method should... | [
"buffer/src/main/java/io/netty/buffer/ByteBufInputStream.java"
] | [
"buffer/src/main/java/io/netty/buffer/ByteBufInputStream.java"
] | [
"buffer/src/test/java/io/netty/buffer/ByteBufStreamTest.java"
] | diff --git a/buffer/src/main/java/io/netty/buffer/ByteBufInputStream.java b/buffer/src/main/java/io/netty/buffer/ByteBufInputStream.java
index 038cd8db459..c0b116c1483 100644
--- a/buffer/src/main/java/io/netty/buffer/ByteBufInputStream.java
+++ b/buffer/src/main/java/io/netty/buffer/ByteBufInputStream.java
@@ -163,7 +... | diff --git a/buffer/src/test/java/io/netty/buffer/ByteBufStreamTest.java b/buffer/src/test/java/io/netty/buffer/ByteBufStreamTest.java
index 222ddcf7ee7..989e160b22a 100644
--- a/buffer/src/test/java/io/netty/buffer/ByteBufStreamTest.java
+++ b/buffer/src/test/java/io/netty/buffer/ByteBufStreamTest.java
@@ -212,4 +212,... | val | val | 2019-06-29T12:16:58 | 2019-06-29T15:59:41Z | xiaoheng1 | val |
netty/netty/8962_9311 | netty/netty | netty/netty/8962 | netty/netty/9311 | [
"keyword_pr_to_issue"
] | f8c1f350dbe6424036693bf5c0a62dfa39512818 | 18e412195256190f3d4a1d88c0f44608d4fce6ba | [
"I suspect it has to do with the maximal datagram packet size. Try to use `new FixedRecvByteBufAllocator(4096)` when you bootstrap your server. ",
"I tried this:\r\n```\r\nNioDatagramChannel channel = new NioDatagramChannel();\r\nchannel.config().setRecvByteBufAllocator(new FixedRecvByteBufAllocator(4096));\r\nBo... | [
"Package private ?",
"Package private",
"Package private",
"Package private",
"Done!",
"Done!",
"Done!",
"Done",
"use `compression.alloc().buffer(...)` to ensure the same allocator is used (which may be a pooled allocated) ",
"Done",
"nit: typo... should be \"uncompressed\"",
"nit: should be \... | 2019-07-01T16:50:53Z | [] | netty-resolver-dns "Got bad packet: bad label type" | I have built a simple DNS proxy server using the Netty DNS resolver library. [See the code here.](https://github.com/nzhenry/dns-proxy)
It works for most queries but not all. For example, when I try to query the A records for "www.apple.com" using nslookup or dig, it fails intermittently with this error:
```;; Got ... | [
"codec-dns/src/main/java/io/netty/handler/codec/dns/DefaultDnsRecordDecoder.java",
"codec-dns/src/main/java/io/netty/handler/codec/dns/DefaultDnsRecordEncoder.java"
] | [
"codec-dns/src/main/java/io/netty/handler/codec/dns/DefaultDnsRecordDecoder.java",
"codec-dns/src/main/java/io/netty/handler/codec/dns/DefaultDnsRecordEncoder.java",
"codec-dns/src/main/java/io/netty/handler/codec/dns/DnsCodecUtil.java"
] | [
"codec-dns/src/test/java/io/netty/handler/codec/dns/DefaultDnsRecordDecoderTest.java"
] | diff --git a/codec-dns/src/main/java/io/netty/handler/codec/dns/DefaultDnsRecordDecoder.java b/codec-dns/src/main/java/io/netty/handler/codec/dns/DefaultDnsRecordDecoder.java
index b4e50ff402e..e61d46cc204 100644
--- a/codec-dns/src/main/java/io/netty/handler/codec/dns/DefaultDnsRecordDecoder.java
+++ b/codec-dns/src/m... | diff --git a/codec-dns/src/test/java/io/netty/handler/codec/dns/DefaultDnsRecordDecoderTest.java b/codec-dns/src/test/java/io/netty/handler/codec/dns/DefaultDnsRecordDecoderTest.java
index 6de6ce5d724..a90acaa2833 100644
--- a/codec-dns/src/test/java/io/netty/handler/codec/dns/DefaultDnsRecordDecoderTest.java
+++ b/cod... | test | val | 2019-07-01T15:57:34 | 2019-03-20T23:37:47Z | nzhenry | val |
netty/netty/9134_9312 | netty/netty | netty/netty/9134 | netty/netty/9312 | [
"keyword_pr_to_issue"
] | b02ee1106f81a97334c076e5510d7f90d4f4e224 | be26f4e00fe1c7aeaec0356f4f16ea643ca2f6da | [
"@davydotcom do you have a reproducer ?",
"Use websocket client in netty in any way and it’s very easily reproduced code is wrong in handshaker\n\nSent from my iPhone\n\n> On May 8, 2019, at 3:12 AM, Norman Maurer <notifications@github.com> wrote:\n> \n> @davydotcom do you have a reproducer ?\n> \n> —\n> You are ... | [] | 2019-07-01T20:12:41Z | [] | WebSocketClientHandshaker13 Invalid Handshake | ### Expected behavior
Origin Header should be sent on handshake
### Actual behavior
Sec-WebSocket-Origin Header is sent instead which is not a client handshake but rather a server to client origin handshake per the Specification
| [
"codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketClientHandshaker13.java",
"codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketServerHandshaker13.java"
] | [
"codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketClientHandshaker13.java",
"codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketServerHandshaker13.java"
] | [
"codec-http/src/test/java/io/netty/handler/codec/http/websocketx/WebSocketClientHandshaker07Test.java",
"codec-http/src/test/java/io/netty/handler/codec/http/websocketx/WebSocketClientHandshaker13Test.java",
"codec-http/src/test/java/io/netty/handler/codec/http/websocketx/WebSocketRequestBuilder.java"
] | diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketClientHandshaker13.java b/codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketClientHandshaker13.java
index b3cf60432cc..f0ea38c0d89 100644
--- a/codec-http/src/main/java/io/netty/handler/codec/http/websocketx/Web... | diff --git a/codec-http/src/test/java/io/netty/handler/codec/http/websocketx/WebSocketClientHandshaker07Test.java b/codec-http/src/test/java/io/netty/handler/codec/http/websocketx/WebSocketClientHandshaker07Test.java
index 01acaf92b51..acc10d7c244 100644
--- a/codec-http/src/test/java/io/netty/handler/codec/http/websoc... | test | val | 2019-07-10T12:19:15 | 2019-05-07T20:56:15Z | davydotcom | val |
netty/netty/1802_9427 | netty/netty | netty/netty/1802 | netty/netty/9427 | [
"keyword_pr_to_issue"
] | 3f0f322562699a65b4133fdb328075da6670bec3 | 4db38b4e0c734b9cdaf0591dd0c5b3f4d4f11ea4 | [
"@trustin after thinking more about I think we should disallow to expand a duplicated buffer. WDYT ?\n",
"Please see issue #1800. Data loss can happen with others, as well, because currently only data from the reader index on is copied, even if a mark exists before that. I think that as long as you can arbitraril... | [
"Then why not use it ?",
"Was going to write the same...",
"Wouldn't it break subclasses that rely on the use of `allocateArray()` e.g. to [track buffer heap usage](https://github.com/netty/netty/blob/4.1/buffer/src/main/java/io/netty/buffer/UnpooledByteBufAllocator.java#L157) or impl [custom pooling](https://g... | 2019-08-05T05:57:25Z | [
"defect"
] | DuplicatedByteBuf not correctly expand capacity | The problem is that it delegate the call to the wrapped buffer which will use its own readerIndex to detect which data needs to get copied while expand it. Thus it leads to dataloss
| [
"buffer/src/main/java/io/netty/buffer/AbstractByteBuf.java",
"buffer/src/main/java/io/netty/buffer/PoolArena.java",
"buffer/src/main/java/io/netty/buffer/PooledByteBuf.java",
"buffer/src/main/java/io/netty/buffer/UnpooledDirectByteBuf.java",
"buffer/src/main/java/io/netty/buffer/UnpooledHeapByteBuf.java",
... | [
"buffer/src/main/java/io/netty/buffer/AbstractByteBuf.java",
"buffer/src/main/java/io/netty/buffer/PoolArena.java",
"buffer/src/main/java/io/netty/buffer/PooledByteBuf.java",
"buffer/src/main/java/io/netty/buffer/UnpooledDirectByteBuf.java",
"buffer/src/main/java/io/netty/buffer/UnpooledHeapByteBuf.java",
... | [] | diff --git a/buffer/src/main/java/io/netty/buffer/AbstractByteBuf.java b/buffer/src/main/java/io/netty/buffer/AbstractByteBuf.java
index 3a19f85c21a..254d40480ae 100644
--- a/buffer/src/main/java/io/netty/buffer/AbstractByteBuf.java
+++ b/buffer/src/main/java/io/netty/buffer/AbstractByteBuf.java
@@ -268,6 +268,13 @@ pr... | null | train | val | 2019-08-07T09:56:28 | 2013-08-30T09:19:08Z | normanmaurer | val |
netty/netty/9475_9477 | netty/netty | netty/netty/9475 | netty/netty/9477 | [
"keyword_pr_to_issue"
] | 97361fa2c89da57e88762aaca9e2b186e8c148f5 | 8a082532f2c9464aa23b4edfd6caa427cc4dd779 | [
"\r\n[asciistring.diff.gz](https://github.com/netty/netty/files/3511592/asciistring.diff.gz)\r\n",
"Thanks @atcurtis, good catch! Could you submit a PR with your fix and unit test?"
] | [] | 2019-08-17T03:25:10Z | [
"defect"
] | AsciiString contentEqualsIgnoreCase fails when arrayOffset is non-zero | ### Expected behavior
AsciiString.contentEqualsIgnoreCase is expected to work.
### Actual behavior
AsciiString.contentEqualsIgnoreCase may return true for non-matching strings of equal length
### Steps to reproduce
Create AsciiString with non-zero offset.
### Minimal yet complete reproducer code (or URL to ... | [
"common/src/main/java/io/netty/util/AsciiString.java"
] | [
"common/src/main/java/io/netty/util/AsciiString.java"
] | [
"common/src/test/java/io/netty/util/AsciiStringCharacterTest.java"
] | diff --git a/common/src/main/java/io/netty/util/AsciiString.java b/common/src/main/java/io/netty/util/AsciiString.java
index ad382482dfc..29ef6a3e145 100644
--- a/common/src/main/java/io/netty/util/AsciiString.java
+++ b/common/src/main/java/io/netty/util/AsciiString.java
@@ -532,7 +532,7 @@ public boolean contentEqual... | diff --git a/common/src/test/java/io/netty/util/AsciiStringCharacterTest.java b/common/src/test/java/io/netty/util/AsciiStringCharacterTest.java
index deff4267d65..7534bb40de3 100644
--- a/common/src/test/java/io/netty/util/AsciiStringCharacterTest.java
+++ b/common/src/test/java/io/netty/util/AsciiStringCharacterTest.... | train | val | 2019-08-16T15:18:17 | 2019-08-17T02:29:45Z | atcurtis | val |
netty/netty/9481_9484 | netty/netty | netty/netty/9481 | netty/netty/9484 | [
"keyword_pr_to_issue"
] | 9e2922b04d2901647b717232ed8fa1745bdbe0df | cb739b26194ebaf89f99d83bc6c573723a225173 | [
"@lwlee2608 Imho disable all non IO tasks is not going to work as there are situations when Netty need to run these. That said I would say we should most likely just use `99` if 100 is used to not make it behave like `0`.",
"Ah, all right. I'm not actually suggesting disabling non-IO tasks. But looking at the cal... | [] | 2019-08-20T06:55:33Z | [] | Setting IORatio to 100 |
I was reading into netty-transport code and stumble across the ioRatio https://github.com/netty/netty/blob/873988676a2b1bb9cc6e5c1a80e5b27725b1d75c/transport/src/main/java/io/netty/channel/nio/NioEventLoop.java#L515
By the look of it, the smaller the ioRatio, the longer time any non-I/O tasks can spend in the even... | [
"transport/src/main/java/io/netty/channel/nio/NioEventLoop.java"
] | [
"transport/src/main/java/io/netty/channel/nio/NioEventLoop.java"
] | [] | diff --git a/transport/src/main/java/io/netty/channel/nio/NioEventLoop.java b/transport/src/main/java/io/netty/channel/nio/NioEventLoop.java
index e4eb8019de4..8dd7609b41a 100644
--- a/transport/src/main/java/io/netty/channel/nio/NioEventLoop.java
+++ b/transport/src/main/java/io/netty/channel/nio/NioEventLoop.java
@@ ... | null | train | val | 2019-08-19T15:08:40 | 2019-08-19T09:49:27Z | lwlee2608 | val |
netty/netty/9495_9501 | netty/netty | netty/netty/9495 | netty/netty/9501 | [
"keyword_pr_to_issue"
] | 9fa974f6a5fa4d90fc13572c92d94e0681db4570 | 14e856ac722cab5060a273b007c7c577f9e13e14 | [
"@nizarm sounds like a bug yes... I would be happy to review a PR.",
"Thanks for confirming @normanmaurer - PR is ready for your review !"
] | [
"I wonder if we should make this more consistent with what we have on the server side:\r\n\r\nhttps://github.com/netty/netty/blob/4.1/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2ServerUpgradeCodec.java#L107\r\n\r\nBasically:\r\n\r\npublic Http2ClientUpgradeCodec(Http2FrameCodec http2Codec, ChannelHa... | 2019-08-22T17:42:24Z | [] | NullPointerException during Client Side ClearText Upgrade with new Http2MultiplexHandler.java | When cleartext upgrade is implemented in client side using **HttpClientUpgradeHandler** there is no way to pass the newly created **Http2MultiplexHandler**.
It seems like we need a way to correctly add Http2MultiplexHandler to the pipeline before calling Http2FrameCodec.onHttpClientUpgrade(...). Since this special ... | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/Http2ClientUpgradeCodec.java"
] | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/Http2ClientUpgradeCodec.java"
] | [
"codec-http2/src/test/java/io/netty/handler/codec/http2/Http2ClientUpgradeCodecTest.java"
] | diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2ClientUpgradeCodec.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2ClientUpgradeCodec.java
index 6028a6fcd15..43c6d5dddc6 100644
--- a/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2ClientUpgradeCodec.java
+++ b/cod... | diff --git a/codec-http2/src/test/java/io/netty/handler/codec/http2/Http2ClientUpgradeCodecTest.java b/codec-http2/src/test/java/io/netty/handler/codec/http2/Http2ClientUpgradeCodecTest.java
index 2d381e4f88b..f0b4a581c02 100644
--- a/codec-http2/src/test/java/io/netty/handler/codec/http2/Http2ClientUpgradeCodecTest.ja... | train | val | 2019-08-22T13:59:08 | 2019-08-22T07:12:24Z | nizarm | val |
netty/netty/9429_9512 | netty/netty | netty/netty/9429 | netty/netty/9512 | [
"keyword_pr_to_issue"
] | 1a22c126be73b6898caea5e59018f1c28ed86b11 | 491b1f428b00bba45a2c51d171cf819704b0fbe6 | [
"Netty 4.1.32\r\n\r\nClient (browser):\r\n`ws.send(\"\")`\r\nServer log:\r\n`io.netty.handler.codec.DecoderException: io.netty.handler.codec.CodecException: cannot read uncompressed buffer\r\n\tat io.netty.handler.codec.MessageToMessageDecoder.channelRead(MessageToMessageDecoder.java:98)\r\n\tat io.netty.channel.Ab... | [
"final ",
"maybe we can inline this into the condition where it is used?\r\n\r\n`if (readable && compositeDecompressedContent.numComponents() <= 0 && !EMPTY_DEFLATE_BLOCK.equals(msg.content())) {`",
"Done for both encoder/decoder",
"```\r\ndecoder.writeInbound(msg.content().retain());\r\n if (appendFra... | 2019-08-26T12:25:40Z | [] | Sending an empty String like "" causes an error | ### Expected behavior
### Actual behavior
### Steps to reproduce
### Minimal yet complete reproducer code (or URL to code)
### Netty version
### JVM version (e.g. `java -version`)
### OS version (e.g. `uname -a`)
| [
"codec-http/src/main/java/io/netty/handler/codec/http/websocketx/extensions/compression/DeflateDecoder.java",
"codec-http/src/main/java/io/netty/handler/codec/http/websocketx/extensions/compression/DeflateEncoder.java"
] | [
"codec-http/src/main/java/io/netty/handler/codec/http/websocketx/extensions/compression/DeflateDecoder.java",
"codec-http/src/main/java/io/netty/handler/codec/http/websocketx/extensions/compression/DeflateEncoder.java"
] | [
"codec-http/src/test/java/io/netty/handler/codec/http/websocketx/extensions/compression/PerMessageDeflateDecoderTest.java",
"codec-http/src/test/java/io/netty/handler/codec/http/websocketx/extensions/compression/PerMessageDeflateEncoderTest.java"
] | diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/websocketx/extensions/compression/DeflateDecoder.java b/codec-http/src/main/java/io/netty/handler/codec/http/websocketx/extensions/compression/DeflateDecoder.java
index 746032dbbcb..223e2e65201 100644
--- a/codec-http/src/main/java/io/netty/handler/codec... | diff --git a/codec-http/src/test/java/io/netty/handler/codec/http/websocketx/extensions/compression/PerMessageDeflateDecoderTest.java b/codec-http/src/test/java/io/netty/handler/codec/http/websocketx/extensions/compression/PerMessageDeflateDecoderTest.java
index fc872b1ecc4..fcd290ab9db 100644
--- a/codec-http/src/test... | train | val | 2019-08-26T08:54:45 | 2019-08-05T11:14:37Z | robot518 | val |
netty/netty/9553_9557 | netty/netty | netty/netty/9553 | netty/netty/9557 | [
"keyword_pr_to_issue"
] | 454cc80141172ec7c6fbc98b8e249ca7645fa27e | bcb0d0224895ea40d64d9de12263c6fcc85cde27 | [
"@wilkinsona sounds like a bug... are you interested in providing a PR ?",
"@normanmaurer Hi, problem that we handle only first `accept-encoding` header value, also we need to consider the q-value for each, or combine to one header-value by spec https://www.w3.org/Protocols/rfc2616/rfc2616-sec4.html#sec4.2",
"... | [
"nit: maybe we should make this:\r\n\r\n```java\r\nswitch (acceptedEncodingHeaders.size()) {\r\n case 0:\r\n acceptedEncoding = HttpContentDecoder.IDENTITY;\r\n break;\r\n case 1: \r\n acceptedEncoding = acceptEncodingHeaders.get(0);\r\n break;\r\n default:\r\n // Multipl... | 2019-09-09T14:51:10Z | [] | HttpContentEncoder does not handle multiple Accept-Encoding headers correctly | ### Expected behavior
When a request contains multiple `Accept-Encoding` headers, their values will be treated as if they had been sent as the comma-separated values of a single `Accept-Encoding` header.
### Actual behavior
Only the first `Accept-Encoding` header is considered and all subsequent `Accept-Encodi... | [
"codec-http/src/main/java/io/netty/handler/codec/http/HttpContentEncoder.java",
"common/src/main/java/io/netty/util/internal/StringUtil.java"
] | [
"codec-http/src/main/java/io/netty/handler/codec/http/HttpContentEncoder.java",
"common/src/main/java/io/netty/util/internal/StringUtil.java"
] | [
"codec-http/src/test/java/io/netty/handler/codec/http/HttpContentCompressorTest.java",
"common/src/test/java/io/netty/util/internal/StringUtilTest.java"
] | diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/HttpContentEncoder.java b/codec-http/src/main/java/io/netty/handler/codec/http/HttpContentEncoder.java
index 7be3b8b92e9..871caef5be2 100644
--- a/codec-http/src/main/java/io/netty/handler/codec/http/HttpContentEncoder.java
+++ b/codec-http/src/main/java... | diff --git a/codec-http/src/test/java/io/netty/handler/codec/http/HttpContentCompressorTest.java b/codec-http/src/test/java/io/netty/handler/codec/http/HttpContentCompressorTest.java
index a31bc5beb89..d0676fd907a 100644
--- a/codec-http/src/test/java/io/netty/handler/codec/http/HttpContentCompressorTest.java
+++ b/cod... | train | val | 2019-09-09T13:58:07 | 2019-09-09T08:31:42Z | wilkinsona | val |
netty/netty/8278_9616 | netty/netty | netty/netty/8278 | netty/netty/9616 | [
"keyword_issue_to_pr"
] | b39ffed042844adecaf0a4fc4e9a2f53edaa111d | 170e4deee6f78a564727dee18af7dd7ce322a35f | [
"I am not aware of anything like this @vkostyukov ",
"@vkostyukov did you find out anything ?",
"@normanmaurer Nope - we haven't really made any progress there yet. We've only seen this problem in our tests and were keeping an eye on complains coming from out users. Nobody really complained about slower shutdow... | [
"do we still need this sleep?",
"200ms seems a bit low, I see this failing on a loaded CI server.",
"@johnou I think so yes since it's how the graceful shutdown / quiet period is currently implemented. That said polling with `sleep` for this does seem unnecessarily cumbersome (as hinted by the TODO comment abov... | 2019-09-27T08:52:20Z | [
"discussion"
] | Native epoll channels/sockets take longer to shutdown/close? | This is neither a bug report nor feature request. I figured I use Github issues to solicit peoples experience and knowledge about Netty's native epoll transports. We've been running Finagle with native epoll (on Linux) for quite a while internally and finally decided to switch our OSS version to it.
To our surprise,... | [
"common/src/main/java/io/netty/util/concurrent/SingleThreadEventExecutor.java"
] | [
"common/src/main/java/io/netty/util/concurrent/SingleThreadEventExecutor.java"
] | [
"testsuite/src/main/java/io/netty/testsuite/transport/AbstractSingleThreadEventLoopTest.java",
"testsuite/src/main/java/io/netty/testsuite/transport/DefaultEventLoopTest.java",
"testsuite/src/main/java/io/netty/testsuite/transport/NioEventLoopTest.java",
"transport-native-epoll/src/test/java/io/netty/channel/... | diff --git a/common/src/main/java/io/netty/util/concurrent/SingleThreadEventExecutor.java b/common/src/main/java/io/netty/util/concurrent/SingleThreadEventExecutor.java
index 4d77da11a73..d2b9707f393 100644
--- a/common/src/main/java/io/netty/util/concurrent/SingleThreadEventExecutor.java
+++ b/common/src/main/java/io/... | diff --git a/testsuite/src/main/java/io/netty/testsuite/transport/AbstractSingleThreadEventLoopTest.java b/testsuite/src/main/java/io/netty/testsuite/transport/AbstractSingleThreadEventLoopTest.java
index e4306b3dc8e..fd58a5255bc 100644
--- a/testsuite/src/main/java/io/netty/testsuite/transport/AbstractSingleThreadEven... | train | val | 2019-09-27T09:59:25 | 2018-09-10T18:33:30Z | vkostyukov | val |
netty/netty/9634_9647 | netty/netty | netty/netty/9634 | netty/netty/9647 | [
"keyword_pr_to_issue"
] | bd8cea644a07890f5bada18ddff0a849b58cd861 | 2e5dd288008d4e674f53beaf8d323595813062fb | [
"@dziemba could you also try running it with `-Dio.netty.leakDetection.level=paranoid`?",
"@normanmaurer I think the problem might be here: https://github.com/netty/netty/blob/68673b652e422df6db462afb8c8f3ce9413c5c90/resolver-dns/src/main/java/io/netty/resolver/dns/DnsNameResolver.java#L1219\r\n\r\nUnless I'm mis... | [
"@njhill can we also verify that this line returns false (add a `assertFalse`):\r\nhttps://github.com/netty/netty/blob/a95d04bb2f6b5f9d000f22b4daa36b5b1f12935b/resolver-dns/src/test/java/io/netty/resolver/dns/DnsNameResolverTest.java#L2901",
"@normanmaurer do you mean that it should return true (no more refs left... | 2019-10-08T23:23:49Z | [
"defect"
] | DNS Resolver leaking direct memory | ### Expected behavior
DNS resolver does not leak direct memory when buffers are freed correctly.
### Actual behavior
Memory is leaked, JVM runs out of direct memory.
```
[error] Exception in thread "main" io.netty.resolver.dns.DnsNameResolverException: [/10.0.2.3:53] failed to send a query via UDP (no stac... | [
"resolver-dns/src/main/java/io/netty/resolver/dns/DnsNameResolver.java",
"resolver-dns/src/main/java/io/netty/resolver/dns/DnsQueryContext.java"
] | [
"resolver-dns/src/main/java/io/netty/resolver/dns/DnsNameResolver.java",
"resolver-dns/src/main/java/io/netty/resolver/dns/DnsQueryContext.java"
] | [
"resolver-dns/src/test/java/io/netty/resolver/dns/DnsNameResolverTest.java"
] | diff --git a/resolver-dns/src/main/java/io/netty/resolver/dns/DnsNameResolver.java b/resolver-dns/src/main/java/io/netty/resolver/dns/DnsNameResolver.java
index 4e84a475f81..c7551d8056c 100644
--- a/resolver-dns/src/main/java/io/netty/resolver/dns/DnsNameResolver.java
+++ b/resolver-dns/src/main/java/io/netty/resolver/... | diff --git a/resolver-dns/src/test/java/io/netty/resolver/dns/DnsNameResolverTest.java b/resolver-dns/src/test/java/io/netty/resolver/dns/DnsNameResolverTest.java
index 38a27ca4a1d..3e35e288a5b 100644
--- a/resolver-dns/src/test/java/io/netty/resolver/dns/DnsNameResolverTest.java
+++ b/resolver-dns/src/test/java/io/net... | train | val | 2019-10-09T15:12:52 | 2019-10-02T17:02:46Z | dziemba | val |
netty/netty/9668_9670 | netty/netty | netty/netty/9668 | netty/netty/9670 | [
"keyword_pr_to_issue"
] | 2e5dd288008d4e674f53beaf8d323595813062fb | e745ef0645cc63e017d0a6599610a59af22842f8 | [
"@normanmaurer thanks",
"Hi, @switchYello. I think this is expected behavior, see \r\n https://github.com/netty/netty/blob/2e5dd288008d4e674f53beaf8d323595813062fb/codec/src/main/java/io/netty/handler/codec/ByteToMessageDecoder.java#L432-L436",
"@amizurov \r\n\r\n\tI see that code annotation and iss,but i thin... | [
"nit: add whitespace after each `,`",
"You will need to call `release()` on each of the `ByteBuf` instances... Alternative you could change your decoder to just do:\r\n\r\n```\r\nout.add(in.readByte());\r\n```\r\n\r\nAnd then assert the returned `byte`.",
"nit: can we also add `assertFalse(buffer5.isReadable())... | 2019-10-15T13:15:10Z | [] | remove handler cause ByteToMessageDecoder out disorder | ### remove handler cause ByteToMessageDecoder out disorder
I input byte stream [1,2,3,4,5], when i read `4` then remove ByteToMessageDecoder,
the out is stream [1,2,3,5,4]
Here are the test cases，the cases will fail
```
@Test
public void testDisorder(){
ByteToMessageDecoder decoder = ... | [
"codec/src/main/java/io/netty/handler/codec/ByteToMessageDecoder.java"
] | [
"codec/src/main/java/io/netty/handler/codec/ByteToMessageDecoder.java"
] | [
"codec/src/test/java/io/netty/handler/codec/ByteToMessageDecoderTest.java"
] | diff --git a/codec/src/main/java/io/netty/handler/codec/ByteToMessageDecoder.java b/codec/src/main/java/io/netty/handler/codec/ByteToMessageDecoder.java
index 96cd7b3b99b..361863cbafa 100644
--- a/codec/src/main/java/io/netty/handler/codec/ByteToMessageDecoder.java
+++ b/codec/src/main/java/io/netty/handler/codec/ByteT... | diff --git a/codec/src/test/java/io/netty/handler/codec/ByteToMessageDecoderTest.java b/codec/src/test/java/io/netty/handler/codec/ByteToMessageDecoderTest.java
index 875de766625..cd9ee370831 100644
--- a/codec/src/test/java/io/netty/handler/codec/ByteToMessageDecoderTest.java
+++ b/codec/src/test/java/io/netty/handler... | test | val | 2019-10-14T16:10:15 | 2019-10-15T11:57:13Z | switchYello | val |
netty/netty/8554_9688 | netty/netty | netty/netty/8554 | netty/netty/9688 | [
"keyword_pr_to_issue"
] | 95230e01da5d9cf2447a9d09d4c42bf42eb7d479 | 8674ccfcd269382be993c23cebe4a72233e905fb | [
"@nicmunroe yeah this looks like a bug... Can you provide a fix ?",
"> @nicmunroe yeah this looks like a bug... Can you provide a fix ?\r\n\r\nPossibly - I'm working through CLA issues to make sure I'm cleared to contribute.",
"Thanks a lot !\n\n> Am 15.11.2018 um 00:22 schrieb Nic Munroe <notifications@github.... | [] | 2019-10-18T11:51:43Z | [] | StringIndexOutOfBoundsException thrown by HttpPostRequestDecoder.splitHeaderContentType() when Content-Type header starts with a semicolon | ### Expected behavior
I'm not sure what the desired behavior should be for `HttpPostRequestDecoder.splitHeaderContentType()` when it finds a Content-Type header that starts with a semicolon, but I'm assuming `StringIndexOutOfBoundsException` is not intentional.
### Actual behavior
`HttpPostRequestDecoder.splitHead... | [
"codec-http/src/main/java/io/netty/handler/codec/http/multipart/HttpPostRequestDecoder.java"
] | [
"codec-http/src/main/java/io/netty/handler/codec/http/multipart/HttpPostRequestDecoder.java"
] | [
"codec-http/src/test/java/io/netty/handler/codec/http/multipart/HttpPostRequestDecoderTest.java"
] | diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/multipart/HttpPostRequestDecoder.java b/codec-http/src/main/java/io/netty/handler/codec/http/multipart/HttpPostRequestDecoder.java
index 0c106264063..b430471248c 100644
--- a/codec-http/src/main/java/io/netty/handler/codec/http/multipart/HttpPostRequestD... | diff --git a/codec-http/src/test/java/io/netty/handler/codec/http/multipart/HttpPostRequestDecoderTest.java b/codec-http/src/test/java/io/netty/handler/codec/http/multipart/HttpPostRequestDecoderTest.java
index 6e6e3cbf359..2c3bfe7ed80 100644
--- a/codec-http/src/test/java/io/netty/handler/codec/http/multipart/HttpPost... | train | val | 2019-10-17T19:12:20 | 2018-11-13T18:38:16Z | nicmunroe | val |
netty/netty/8855_9701 | netty/netty | netty/netty/8855 | netty/netty/9701 | [
"keyword_pr_to_issue"
] | 247a4db470d58c5087fb4f2388a18be42b0ce9d0 | 7d6d953153697bd66c3b01ca8ec73c4494a81788 | [
"@slandelle WDYT ?",
"👍 I've been parsing URIs this way (HTML5's form-url-encoded) for many years in both AHC and Gatling and I don't recall anyone ever complaining that semi-colon wasn't interpreted as a parameter separator.",
"Note also that when encoding an URL with java URI.tostring(), semicolons are _not_... | [] | 2019-10-22T15:37:15Z | [] | Support semicolon as a normal character in URI (no longer a parameter separator) | ### Expected result
According to the 2014 W3C Recommendation, semicolon is now illegal as a parameter separator in a http URI.
`?foo=bar;baz` means the parameter `foo` will have the value `bar;baz`
see https://www.w3.org/TR/2014/REC-html5-20141028/forms.html#url-encoded-form-data
(thanks to https://stackoverflow.... | [
"codec-http/src/main/java/io/netty/handler/codec/http/QueryStringDecoder.java"
] | [
"codec-http/src/main/java/io/netty/handler/codec/http/QueryStringDecoder.java"
] | [
"codec-http/src/test/java/io/netty/handler/codec/http/QueryStringDecoderTest.java"
] | diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/QueryStringDecoder.java b/codec-http/src/main/java/io/netty/handler/codec/http/QueryStringDecoder.java
index a20126dbbb8..01b747b3f23 100644
--- a/codec-http/src/main/java/io/netty/handler/codec/http/QueryStringDecoder.java
+++ b/codec-http/src/main/java... | diff --git a/codec-http/src/test/java/io/netty/handler/codec/http/QueryStringDecoderTest.java b/codec-http/src/test/java/io/netty/handler/codec/http/QueryStringDecoderTest.java
index a0071c4a70f..5937d66bf24 100644
--- a/codec-http/src/test/java/io/netty/handler/codec/http/QueryStringDecoderTest.java
+++ b/codec-http/s... | train | val | 2019-10-22T15:39:43 | 2019-02-07T17:15:10Z | marcban | val |
netty/netty/9706_9707 | netty/netty | netty/netty/9706 | netty/netty/9707 | [
"keyword_pr_to_issue"
] | 844b82b986b42d76f29992fb7a0530784786b203 | 2f32e0b8adb63decd9031e26fa5dd4154d93ce97 | [
"@jasonstack want to provide a PR against 4.1 branch ?",
"@normanmaurer sure. I will submit a PR..",
"@jasonstack cool... please also ensure you sign the ICLA: https://netty.io/s/icla "
] | [] | 2019-10-24T14:09:08Z | [] | Netty SSL doesn't respect `-Djdk.tls.client.protocols` | ### Expected behavior
`-Djdk.tls.client.protocols` should control Netty's SSL protocols
### Actual behavior
Netty checks if `TLSv1, TLSv1.1, TLSv1.2` are [supported against JDK's supported protocols](https://github.com/netty/netty/blob/39cc7a673939dec96258ff27f5b1874671838af0/handler/src/main/java/io/netty/handl... | [
"handler/src/main/java/io/netty/handler/ssl/JdkSslContext.java"
] | [
"handler/src/main/java/io/netty/handler/ssl/JdkSslContext.java"
] | [] | diff --git a/handler/src/main/java/io/netty/handler/ssl/JdkSslContext.java b/handler/src/main/java/io/netty/handler/ssl/JdkSslContext.java
index eb128fe80e7..0e9a1273831 100644
--- a/handler/src/main/java/io/netty/handler/ssl/JdkSslContext.java
+++ b/handler/src/main/java/io/netty/handler/ssl/JdkSslContext.java
@@ -79,... | null | train | val | 2019-10-24T14:57:00 | 2019-10-24T06:55:54Z | jasonstack | val |
netty/netty/9293_9711 | netty/netty | netty/netty/9293 | netty/netty/9711 | [
"keyword_pr_to_issue"
] | 844b82b986b42d76f29992fb7a0530784786b203 | aba9b34a59a2ad1182330506c9e3f6a6f681ea75 | [
"@anuraaga this sounds like a good idea... I think we may also want to support varargs ... Maybe you want to provide an PR ?",
"@anuraaga interested in doing a pr ?",
"Yup - sorry for the delay have had some stuff lately but will be able to get to this by next week.",
"@anuraaga are you still interested ?"
] | [
"Probably not a big deal given it's unlikely to be called frequently, but would be nice to check for `instanceof Collection` and then use `.toArray(...)` directly instead of copying to new list."
] | 2019-10-25T06:04:41Z | [] | SSLContextBuilder should accept Iterable parameters too | ### Expected behavior
It is possible to pass parameters like SSL providers to `SslContextBuilder` without having to convert iterables to arrays, which is tedious.
### Actual behavior
Need to convert to arrays, except for the `ciphers` method.
Wanted to run this by everyone - if the API change makes sense I'... | [
"handler/src/main/java/io/netty/handler/ssl/SslContextBuilder.java"
] | [
"handler/src/main/java/io/netty/handler/ssl/SslContextBuilder.java"
] | [] | diff --git a/handler/src/main/java/io/netty/handler/ssl/SslContextBuilder.java b/handler/src/main/java/io/netty/handler/ssl/SslContextBuilder.java
index b0474265b0e..f17169238d9 100644
--- a/handler/src/main/java/io/netty/handler/ssl/SslContextBuilder.java
+++ b/handler/src/main/java/io/netty/handler/ssl/SslContextBuil... | null | test | val | 2019-10-24T14:57:00 | 2019-06-28T08:39:25Z | anuraaga | val |
netty/netty/9725_9729 | netty/netty | netty/netty/9725 | netty/netty/9729 | [
"keyword_pr_to_issue"
] | 8d99aa1235d07376f9df3ae3701692091117725a | 82376fd889b3f34af318bf48eb28673ef5789a31 | [
"processSelectedKey should be an hot path and very likely to be compiled at C2 level so I don't think it would make any difference perf-wise. For readability is fine, agree :)",
"@MrYangxf sounds good... Can you please submit a PR ?",
"@normanmaurer Of course :)"
] | [
"this `return` can be removed now. ",
"this seems to violate the original logic. The healthy channel may be closed when `eventLoop != this`",
"@MrYangxf not sure I understand your concern... With your change `return` is the last statement in the method which makes it redundant.. What I am missing ?",
"@norma... | 2019-10-30T02:29:46Z | [] | A redundant comparison operation | Hi, when I read the source code, I happened to notice this
https://github.com/netty/netty/blob/ff2a7929235257642d8f63edb1c580347307f3ee/transport/src/main/java/io/netty/channel/nio/NioEventLoop.java#L669-L674
The `eventLoop == null` is unnecessary. Although the c2 compiler optimizes it, c1 doesn’t seem to optimize it... | [
"transport/src/main/java/io/netty/channel/nio/NioEventLoop.java"
] | [
"transport/src/main/java/io/netty/channel/nio/NioEventLoop.java"
] | [] | diff --git a/transport/src/main/java/io/netty/channel/nio/NioEventLoop.java b/transport/src/main/java/io/netty/channel/nio/NioEventLoop.java
index ace430afc95..36a0b76ddc0 100644
--- a/transport/src/main/java/io/netty/channel/nio/NioEventLoop.java
+++ b/transport/src/main/java/io/netty/channel/nio/NioEventLoop.java
@@ ... | null | val | val | 2019-10-29T20:48:18 | 2019-10-29T09:18:38Z | MrYangxf | val |
netty/netty/9738_9742 | netty/netty | netty/netty/9738 | netty/netty/9742 | [
"keyword_issue_to_pr",
"keyword_pr_to_issue"
] | 656371ee733454f9cf7691f60d2d1acd16c41c9a | 369e667427dbadca95da935cbe8404b3691c68cb | [
"@bsideup can you have a look ? It works with all other JDK version that we use on the CI :/",
"@normanmaurer JDK13+ requires a flag ( `-XX:+AllowRedefinitionToAddDeleteMethod` ) to be set, see https://github.com/reactor/BlockHound/issues/33 for more details.\r\n\r\nWe're still investigating what to do about it, ... | [] | 2019-10-31T14:56:23Z | [] | NettyBlockHoundIntegrationTest.testBlockingCallsInNettyThreads fails with JDK 13 | ```
[INFO] --- xml-maven-plugin:1.0.1:check-format (check-style) @ netty-transport-blockhound-tests ---
[INFO]
[INFO] --- maven-dependency-plugin:2.10:get (get-jetty-alpn-agent) @ netty-transport-blockhound-tests ---
[INFO] Resolving org.mortbay.jetty.alpn:jetty-alpn-agent:jar:2.0.8 with transitive dependencies
[... | [
"transport-blockhound-tests/pom.xml"
] | [
"transport-blockhound-tests/pom.xml"
] | [] | diff --git a/transport-blockhound-tests/pom.xml b/transport-blockhound-tests/pom.xml
index 9105858435e..c0a0c8d3ddd 100644
--- a/transport-blockhound-tests/pom.xml
+++ b/transport-blockhound-tests/pom.xml
@@ -31,6 +31,18 @@
<name>Netty/Transport/BlockHound/Tests</name>
+ <profiles>
+ <profile>
+ <id>jav... | null | train | test | 2019-10-31T12:16:24 | 2019-10-31T09:44:33Z | normanmaurer | val |
netty/netty/8279_9804 | netty/netty | netty/netty/8279 | netty/netty/9804 | [
"keyword_pr_to_issue"
] | fb5e2cd3aa5644c294905fce3b45c2278f17e15d | 660611c4507def91ffd6bf13f294e21826b584a5 | [
"@rhenwood-arm if we can easily cross-compile there we could do it I guess.",
"@rhenwood-arm btw if you do so you may also be interested in providing a pr for netty-tcnative.",
"Thanks for the prompt response and guidance @normanmaurer !\r\n\r\nI'll spend some time looking into this in detail.",
"@rhenwood-ar... | [
"This complete plugin config is not needed anymore :) Just remove it",
"I don't know how to release the package. Any suggestion?",
"Done",
"@wangxiyuan can you make all the docker / docker-compose stuff consistent with what we have atm ? If you don't have time I can also do it tho.",
"I can but I don't know... | 2019-11-25T06:41:21Z | [] | aarch64 native bits. | Hi,
It is valuable for me to have native aarch64 bits included in the release artifacts. I see there has been interest in a cross-compile previously: https://github.com/netty/netty/issues/7459
It appears that the release is made on a RHEL 6 x86_64 compatible and I would like to explore making the necessary chang... | [
"all/pom.xml",
"docker/README.md",
"docker/docker-compose.yaml",
"transport-native-epoll/pom.xml",
"transport-native-unix-common/pom.xml"
] | [
"all/pom.xml",
"docker/Dockerfile.cross_compile_aarch64",
"docker/README.md",
"docker/docker-compose.yaml",
"transport-native-epoll/pom.xml",
"transport-native-unix-common/pom.xml"
] | [] | diff --git a/all/pom.xml b/all/pom.xml
index afbdcb2a052..ebf7d21dc42 100644
--- a/all/pom.xml
+++ b/all/pom.xml
@@ -57,6 +57,14 @@
<scope>compile</scope>
<optional>true</optional>
</dependency>
+ <dependency>
+ <groupId>${project.groupId}</groupId>
+ <artifactId>... | null | train | test | 2020-04-15T10:21:24 | 2018-09-10T20:13:38Z | rhenwood-arm | val |
netty/netty/7210_9856 | netty/netty | netty/netty/7210 | netty/netty/9856 | [
"keyword_pr_to_issue"
] | 15b6ed92a03ad8cd5e95bc0971f09afa5094f29c | 4138cba86138b390f934e615ad4f96bad621124d | [
"The fix can't just be to use a different Set implementation, the current equals/hashCode of io.netty.handler.codec.http.cookie.DefaultCookie will prevent any Set from ever holding multiple Cookies with the same name, because there is no path or domain to differentiate on. Ideally ServerCookieDecoder::decode would ... | [] | 2019-12-07T00:48:30Z | [] | ServerCookieDecoder does not support duplicate cookies | ### Expected behavior
According to [RFC-6265 (section 4.2.2)](https://tools.ietf.org/html/rfc6265#section-4.2.2), multiple cookie pairs with the same name are not explicitly excluded from happening. It is even hinted that it should be expected,
In particular, if the Cookie header contains two cookies with the... | [
"codec-http/src/main/java/io/netty/handler/codec/http/cookie/ServerCookieDecoder.java"
] | [
"codec-http/src/main/java/io/netty/handler/codec/http/cookie/ServerCookieDecoder.java"
] | [
"codec-http/src/test/java/io/netty/handler/codec/http/cookie/ServerCookieDecoderTest.java"
] | diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/cookie/ServerCookieDecoder.java b/codec-http/src/main/java/io/netty/handler/codec/http/cookie/ServerCookieDecoder.java
index cf5349b0863..f56fb919a80 100644
--- a/codec-http/src/main/java/io/netty/handler/codec/http/cookie/ServerCookieDecoder.java
+++ b/... | diff --git a/codec-http/src/test/java/io/netty/handler/codec/http/cookie/ServerCookieDecoderTest.java b/codec-http/src/test/java/io/netty/handler/codec/http/cookie/ServerCookieDecoderTest.java
index b157bc3c73b..b6b33655757 100644
--- a/codec-http/src/test/java/io/netty/handler/codec/http/cookie/ServerCookieDecoderTest... | val | test | 2019-12-07T01:27:03 | 2017-09-14T05:38:40Z | quidryan | val |
netty/netty/9861_9865 | netty/netty | netty/netty/9861 | netty/netty/9865 | [
"keyword_issue_to_pr"
] | 9a0ccf24f32ff8d5a9b3485cc379ae04ea1c0cd3 | 8494b046ec7e4f28dbd44bc699cc4c4c92251729 | [
"@ZeddYu I fixed 1) https://github.com/netty/netty/pull/9865 but I am not sure about 2) as netty is just a library so I think the user should verify the transfer-encoding as it also depends on what handlers are in the pipeline.",
"@normanmaurer But I test it with following code:\r\n```java\r\n HttpHead... | [
"Should we check the RFC test case?\r\n```\r\nContent-Length: 42, 42\r\n```",
"done",
"Maybe catch `NumberFormatException` (\"Content-Length: 42, 42\") and re throw with a meaningful message ?",
"I would prefer to just keep it as it is as it did throw the same type of exception before already ",
"OK, but it... | 2019-12-10T10:17:16Z | [] | Non-proper handling of Content-Length and Transfer-Encoding: chunked headers | ### Expected behavior
1.Only accept one Content-Length.RFC 7230 says `duplicate Content-Length header fields have been generated or combined by an upstream message processor, then the recipient MUST either reject the message as invalid or replace the duplicated field-values with a single valid Content-Length`.
2.Only... | [
"codec-http/src/main/java/io/netty/handler/codec/http/HttpObjectDecoder.java"
] | [
"codec-http/src/main/java/io/netty/handler/codec/http/HttpObjectDecoder.java"
] | [
"codec-http/src/test/java/io/netty/handler/codec/http/HttpRequestDecoderTest.java"
] | diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/HttpObjectDecoder.java b/codec-http/src/main/java/io/netty/handler/codec/http/HttpObjectDecoder.java
index 28f048252fe..768bd3b26f5 100644
--- a/codec-http/src/main/java/io/netty/handler/codec/http/HttpObjectDecoder.java
+++ b/codec-http/src/main/java/io... | diff --git a/codec-http/src/test/java/io/netty/handler/codec/http/HttpRequestDecoderTest.java b/codec-http/src/test/java/io/netty/handler/codec/http/HttpRequestDecoderTest.java
index 8a2345837fe..1e780b7959f 100644
--- a/codec-http/src/test/java/io/netty/handler/codec/http/HttpRequestDecoderTest.java
+++ b/codec-http/s... | train | test | 2019-12-12T16:18:27 | 2019-12-09T18:54:41Z | ZeddYu | val |
netty/netty/9867_9874 | netty/netty | netty/netty/9867 | netty/netty/9874 | [
"keyword_pr_to_issue"
] | a7c18d44b46e02dadfe3da225a06e5091f5f328e | 0992718f87bf0f0c23660489b1f7e697a24f2a4b | [
"Very good idea. Recently I had the same thoughts. Also, it would be cool to have size limited compression. So for small messages like < 20 bytes you don't need compression. ",
"@dvlato @doom369 if I'm not mistaken this should be already possible by just subclassing `HttpContentCompressor` and overriding `acceptO... | [] | 2019-12-12T11:53:59Z | [
"not a bug"
] | Make content compression configurable per content type | ### Expected behavior
Content compression can be enabled for specific content types. This mean we would like to configure ContentCompressor so we can define what content types should be compressed; in this case we wouldn't compress JPEG or GIF files as those formats are already compressed.
This PR tried to fix the ... | [
"codec-http/src/main/java/io/netty/handler/codec/http/HttpContentCompressor.java",
"codec-http/src/main/java/io/netty/handler/codec/http/HttpContentEncoder.java"
] | [
"codec-http/src/main/java/io/netty/handler/codec/http/HttpContentCompressor.java",
"codec-http/src/main/java/io/netty/handler/codec/http/HttpContentEncoder.java"
] | [
"codec-http/src/test/java/io/netty/handler/codec/http/HttpContentEncoderTest.java"
] | diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/HttpContentCompressor.java b/codec-http/src/main/java/io/netty/handler/codec/http/HttpContentCompressor.java
index e80469f26e4..b40fae66bc5 100644
--- a/codec-http/src/main/java/io/netty/handler/codec/http/HttpContentCompressor.java
+++ b/codec-http/src/... | diff --git a/codec-http/src/test/java/io/netty/handler/codec/http/HttpContentEncoderTest.java b/codec-http/src/test/java/io/netty/handler/codec/http/HttpContentEncoderTest.java
index 6301ee8c0b5..9bb88385a8c 100644
--- a/codec-http/src/test/java/io/netty/handler/codec/http/HttpContentEncoderTest.java
+++ b/codec-http/s... | train | test | 2019-12-11T15:49:07 | 2019-12-10T14:43:43Z | dvlato | val |
netty/netty/9911_9912 | netty/netty | netty/netty/9911 | netty/netty/9912 | [
"keyword_issue_to_pr",
"keyword_pr_to_issue"
] | 06a5173e8d700f5f431557f21f647f2199bb3d52 | 607bc05a2c1453323b2f8c67cbd4aff0d5b17531 | [
"Is there any other information I can give that would be helpful?",
"@cilki thanks for reporting, is this something that started in 4.1.44.Final?",
"@njhill Yes. I just tested 4.1.40.Final through 4.1.43.Final and they all work as expected.",
"Thanks @cilki, sorry this is my bad, I should have time to submit ... | [
"@normanmaurer I added this because I noticed that it fails when running the tests with `-Dio.netty.noUnsafe=true` (I think it's actually N/A in that case). Should we include test runs with Unsafe disabled in the CI?",
"@njhill yes will add it.",
"@njhill we need to call `src.release()` and `dst.release()` as w... | 2019-12-30T06:08:29Z | [
"defect"
] | BufferOverflowException with specific buffer sizes | When Netty reallocates pooled buffers that are approximately 256 to 1024 bytes, a `BufferOverflowException` can be thrown. **Furthermore, the exception is swallowed** and is not printed by `LoggingHandler` (I was only able to find it by capturing it from a debugger).
I'm on JDK 13 and therefore `Unsafe` isn't availa... | [
"buffer/src/main/java/io/netty/buffer/PooledByteBuf.java",
"buffer/src/main/java/io/netty/buffer/PooledDirectByteBuf.java"
] | [
"buffer/src/main/java/io/netty/buffer/PooledByteBuf.java",
"buffer/src/main/java/io/netty/buffer/PooledDirectByteBuf.java"
] | [
"buffer/src/test/java/io/netty/buffer/PoolArenaTest.java"
] | diff --git a/buffer/src/main/java/io/netty/buffer/PooledByteBuf.java b/buffer/src/main/java/io/netty/buffer/PooledByteBuf.java
index 9e33c0c5942..3ef1e26cba0 100644
--- a/buffer/src/main/java/io/netty/buffer/PooledByteBuf.java
+++ b/buffer/src/main/java/io/netty/buffer/PooledByteBuf.java
@@ -154,6 +154,8 @@ protected f... | diff --git a/buffer/src/test/java/io/netty/buffer/PoolArenaTest.java b/buffer/src/test/java/io/netty/buffer/PoolArenaTest.java
index 2c1bd12db32..3ad331ddb30 100644
--- a/buffer/src/test/java/io/netty/buffer/PoolArenaTest.java
+++ b/buffer/src/test/java/io/netty/buffer/PoolArenaTest.java
@@ -20,6 +20,8 @@
import org.j... | test | test | 2019-12-27T09:14:50 | 2019-12-29T19:30:23Z | cilki | val |
netty/netty/6168_9924 | netty/netty | netty/netty/6168 | netty/netty/9924 | [
"keyword_pr_to_issue"
] | 06a5173e8d700f5f431557f21f647f2199bb3d52 | 1543218d3e7afcb33a90b728b14370395a3deca0 | [
"@normanmaurer @jasobrown - FYI.",
"This should probably be reopened. My PR only fixes this for subclasses of ZlibDecoder; it does not fix this for any other compression algorithms."
] | [
"Can you add to the doc describing what `0` does?",
"same comment",
"can this be private/final? ",
"optional: check preferredSize is non-negative?",
"+1",
"nit: `else` block not needed",
"I think either the second `ensureWritable` param should be `false` or the return should be compared to `3` rather ... | 2020-01-07T19:28:51Z | [] | Compression/Decompression Codecs should enforce memory allocation size limits | ### Expected behavior
To protect against OOME the compression and decompression codecs should explicitly limit the amount of data they compress and decompress. We may be vulnerable to OOME from large or malicious input.
### Actual behavior
In light of https://github.com/netty/netty/pull/5997 most of the compressio... | [
"codec/src/main/java/io/netty/handler/codec/compression/JZlibDecoder.java",
"codec/src/main/java/io/netty/handler/codec/compression/JdkZlibDecoder.java",
"codec/src/main/java/io/netty/handler/codec/compression/ZlibDecoder.java"
] | [
"codec/src/main/java/io/netty/handler/codec/compression/JZlibDecoder.java",
"codec/src/main/java/io/netty/handler/codec/compression/JdkZlibDecoder.java",
"codec/src/main/java/io/netty/handler/codec/compression/ZlibDecoder.java"
] | [
"codec/src/test/java/io/netty/handler/codec/compression/JZlibTest.java",
"codec/src/test/java/io/netty/handler/codec/compression/JdkZlibTest.java",
"codec/src/test/java/io/netty/handler/codec/compression/ZlibCrossTest1.java",
"codec/src/test/java/io/netty/handler/codec/compression/ZlibCrossTest2.java",
"cod... | diff --git a/codec/src/main/java/io/netty/handler/codec/compression/JZlibDecoder.java b/codec/src/main/java/io/netty/handler/codec/compression/JZlibDecoder.java
index f87344ab599..6c65cd5fe6a 100644
--- a/codec/src/main/java/io/netty/handler/codec/compression/JZlibDecoder.java
+++ b/codec/src/main/java/io/netty/handler... | diff --git a/codec/src/test/java/io/netty/handler/codec/compression/JZlibTest.java b/codec/src/test/java/io/netty/handler/codec/compression/JZlibTest.java
index 28f3919c604..015559ed3b7 100644
--- a/codec/src/test/java/io/netty/handler/codec/compression/JZlibTest.java
+++ b/codec/src/test/java/io/netty/handler/codec/co... | val | test | 2019-12-27T09:14:50 | 2016-12-30T18:14:58Z | Scottmitch | val |
netty/netty/9919_9933 | netty/netty | netty/netty/9919 | netty/netty/9933 | [
"keyword_pr_to_issue"
] | 76fb4c894af15cd1e30495a91074b2d95940e451 | 41c47b41bf0caa2f0faffec901a374516fbd19f7 | [
"Same problem repeated once again on the same server. \r\n```\r\n\"epollEventLoopGroup-7-3\" #22 prio=10 os_prio=0 cpu=67508345.04ms elapsed=617139.89s tid=0x00007f5b68006000 nid=0x3de5 runnable [0x00007f5b59674000]\r\n java.lang.Thread.State: RUNNABLE\r\n at io.netty.buffer.AbstractByteBuf.checkIndex0(Ab... | [
"add `fail();` above",
"@normanmaurer done, I actually just copied the existing `testFallbackToDefaultContext()` as a starting point, which had this `fail()` commented out for some reason. So I've uncommented it there too since an exception does also get thrown in that case.",
"@njhill thanks... Lets see if thi... | 2020-01-09T23:01:58Z | [
"defect"
] | Event loop threads hang in SniHandler for SSL records with majorVersion != 3 | Under some unknown and rare circumstances 2 worker threads started to consume 100% CPU time of a single core each, permanently and indefinitely. It didn't prevent the app from its normal functioning, nevertheless excessive consumption of cpu is not a normal behaviour.
Noticed this behaviour once by now.
### Actual ... | [
"handler/src/main/java/io/netty/handler/ssl/AbstractSniHandler.java"
] | [
"handler/src/main/java/io/netty/handler/ssl/AbstractSniHandler.java"
] | [
"handler/src/test/java/io/netty/handler/ssl/SniHandlerTest.java"
] | diff --git a/handler/src/main/java/io/netty/handler/ssl/AbstractSniHandler.java b/handler/src/main/java/io/netty/handler/ssl/AbstractSniHandler.java
index 8cd9bf0f861..fa7e9059b9d 100644
--- a/handler/src/main/java/io/netty/handler/ssl/AbstractSniHandler.java
+++ b/handler/src/main/java/io/netty/handler/ssl/AbstractSni... | diff --git a/handler/src/test/java/io/netty/handler/ssl/SniHandlerTest.java b/handler/src/test/java/io/netty/handler/ssl/SniHandlerTest.java
index 8cd3d766cda..3f468db0dd8 100644
--- a/handler/src/test/java/io/netty/handler/ssl/SniHandlerTest.java
+++ b/handler/src/test/java/io/netty/handler/ssl/SniHandlerTest.java
@@ ... | train | test | 2020-01-09T15:08:49 | 2020-01-03T09:58:45Z | igor-lukyanov | val |
netty/netty/9944_9967 | netty/netty | netty/netty/9944 | netty/netty/9967 | [
"keyword_pr_to_issue"
] | 066a180a43186ee5a54afdcca9077ab07328ff6a | fb3ced28cf61f2dd8638a11fd0ede62b46cc2db7 | [
"Sounds Good \n\n> Am 11.01.2020 um 12:32 schrieb Dmitriy Dumanskiy <notifications@github.com>:\n> \n> \n> WebSocketCloseFrameHandler could be easily merged into WebSocketProtocolHandler and thus we don't need to add/hold an additional handler in the websockets pipeline. I think it would nice improvement for webso... | [
"@doom369 as this is package-private we can just remove the class imho. ",
"Removed"
] | 2020-01-25T23:06:37Z | [] | Merge WebSocketCloseFrameHandler into WebSocketProtocolHandler in order to minimize pipeline | `WebSocketCloseFrameHandler` could be easily merged into `WebSocketProtocolHandler` and thus we don't need to add/hold an additional handler in the websockets pipeline. I think it would nice improvement for websockets pipeline.
@normanmaurer @ursaj @amizurov WDYT? | [
"codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketClientProtocolHandler.java",
"codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketCloseFrameHandler.java",
"codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketProtocolHandler.java",
"codec-http... | [
"codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketClientProtocolHandler.java",
"codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketProtocolHandler.java",
"codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketServerProtocolHandler.java"
] | [] | diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketClientProtocolHandler.java b/codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketClientProtocolHandler.java
index 1b8928aae49..8fda6eb008b 100644
--- a/codec-http/src/main/java/io/netty/handler/codec/http/websocke... | null | train | test | 2020-01-24T15:40:39 | 2020-01-11T11:32:16Z | doom369 | val |
netty/netty/9971_9974 | netty/netty | netty/netty/9971 | netty/netty/9974 | [
"keyword_pr_to_issue"
] | 2023a4f60759772261280159bccb4869e63c14e7 | 663fbaa50661eb5576d88aa0d053f2ccc2fae317 | [
"https://github.com/netty/netty/pull/9972/commits/69b3089cd6fd173c0ea9348033ee3919af14ab15"
] | [
"How about `out.clear()` here too?",
"this should not be needed. "
] | 2020-01-28T13:40:43Z | [] | SslHandler.flush throws IllegalArgumentException on upstream write exception | ### Expected behavior
Did not expect flush to throw IllegalArgumentException
### Actual behavior
```
promise already done: DefaultChannelPromise@3d07c0a4(
io.netty.channel.AbstractChannelHandlerContext.isNotValidPromise - Line 910 (AbstractChannelHandlerContext.java)
io.netty.channel.AbstractChannelHandlerCon... | [
"handler/src/main/java/io/netty/handler/ssl/SslHandler.java"
] | [
"handler/src/main/java/io/netty/handler/ssl/SslHandler.java"
] | [] | diff --git a/handler/src/main/java/io/netty/handler/ssl/SslHandler.java b/handler/src/main/java/io/netty/handler/ssl/SslHandler.java
index bb76f9a246b..b180b0424e6 100644
--- a/handler/src/main/java/io/netty/handler/ssl/SslHandler.java
+++ b/handler/src/main/java/io/netty/handler/ssl/SslHandler.java
@@ -858,11 +858,25 ... | null | train | test | 2020-01-28T06:04:20 | 2020-01-27T21:19:35Z | atcurtis | val |
Subsets and Splits
Java Code Detection in Problems
Identifies and categorizes entries in the dataset that are likely related to Java programming, providing insights into the prevalence and type of Java content in the problem statements.