source large_stringclasses 2
values | subject large_stringclasses 112
values | code large_stringclasses 112
values | critique large_stringlengths 61 3.04M ⌀ | metadata dict |
|---|---|---|---|---|
lkml | [PATCHSET v3 sched_ext/for-6.20] sched_ext: Fix ops.dequeue() semantics | The callback ops.dequeue() is provided to let BPF schedulers observe when a
task leaves the scheduler, either because it is dispatched or due to a task
property change. However, this callback is currently unreliable and not
invoked systematically, which can result in missed ops.dequeue() events.
In particular, once a ... | On Mon, Feb 02, 2026 at 05:19:51AM -1000, Tejun Heo wrote:
Alright, it seems that the general consensus, based on your feedback and
Kuba's, is to treat SCX_DSQ_GLOBAL as a "terminal" DSQ for the purpose of
triggering ops.dequeue().
I'll update the logic to do the following:
- When a task is dispatched to SCX_DSQ_GLO... | {
"author": "Andrea Righi <arighi@nvidia.com>",
"date": "Mon, 2 Feb 2026 16:30:28 +0100",
"thread_id": "20260126084258.3798129-1-arighi@nvidia.com.mbox.gz"
} |
lkml | [PATCHSET v3 sched_ext/for-6.20] sched_ext: Fix ops.dequeue() semantics | The callback ops.dequeue() is provided to let BPF schedulers observe when a
task leaves the scheduler, either because it is dispatched or due to a task
property change. However, this callback is currently unreliable and not
invoked systematically, which can result in missed ops.dequeue() events.
In particular, once a ... | On Sun, Feb 01, 2026 at 07:43:33AM -1000, Tejun Heo wrote:
I like "terminal DSQ", if there's no objection I'll update the
documentation using this terminology.
Thanks,
-Andrea | {
"author": "Andrea Righi <arighi@nvidia.com>",
"date": "Mon, 2 Feb 2026 16:52:37 +0100",
"thread_id": "20260126084258.3798129-1-arighi@nvidia.com.mbox.gz"
} |
lkml | [PATCHSET v3 sched_ext/for-6.20] sched_ext: Fix ops.dequeue() semantics | The callback ops.dequeue() is provided to let BPF schedulers observe when a
task leaves the scheduler, either because it is dispatched or due to a task
property change. However, this callback is currently unreliable and not
invoked systematically, which can result in missed ops.dequeue() events.
In particular, once a ... | On Mon Feb 2, 2026 at 3:52 PM UTC, Andrea Righi wrote:
"Built-in" would also work and avoids introducing new terminology, but it
doesn't provide any insight into why these DSQs are special, whereas
"terminal" suggests there's some finality to inserting a task there.
I'm slightly leaning towards "terminal".
Thanks,
K... | {
"author": "Kuba Piecuch <jpiecuch@google.com>",
"date": "Mon, 02 Feb 2026 16:23:19 +0000",
"thread_id": "20260126084258.3798129-1-arighi@nvidia.com.mbox.gz"
} |
lkml | [PATCH 0/2] idpf: skip NULL pointers during deallocation. | In idpf txq and rxq error paths, some pointers are not allocated in the
first place. In the corresponding deallocation logic, we should not
deallocate them to prevent kernel panics.
Li Li (2):
idpf: skip deallocating bufq_sets from rx_qgrp if it is NULL.
idpf: skip deallocating txq group's txqs if it is NULL.
dr... | In idpf_rxq_group_alloc(), if rx_qgrp->splitq.bufq_sets failed to get
allocated:
rx_qgrp->splitq.bufq_sets = kcalloc(vport->num_bufqs_per_qgrp,
sizeof(struct idpf_bufq_set),
GFP_KERNEL);
if (!rx_qgrp->splitq.bufq_sets) {
err = -ENOMEM;
goto err_alloc;
}
idpf_rxq_group_rel() would attempt to d... | {
"author": "Li Li <boolli@google.com>",
"date": "Mon, 12 Jan 2026 23:09:43 +0000",
"thread_id": "20260112230944.3085309-3-boolli@google.com.mbox.gz"
} |
lkml | [PATCH 0/2] idpf: skip NULL pointers during deallocation. | In idpf txq and rxq error paths, some pointers are not allocated in the
first place. In the corresponding deallocation logic, we should not
deallocate them to prevent kernel panics.
Li Li (2):
idpf: skip deallocating bufq_sets from rx_qgrp if it is NULL.
idpf: skip deallocating txq group's txqs if it is NULL.
dr... | In idpf_txq_group_alloc(), if any txq group's txqs failed to
allocate memory:
for (j = 0; j < tx_qgrp->num_txq; j++) {
tx_qgrp->txqs[j] = kzalloc(sizeof(*tx_qgrp->txqs[j]),
GFP_KERNEL);
if (!tx_qgrp->txqs[j])
goto err_alloc;
}
It would cause a NULL ptr kernel panic in idpf_txq_group_rel():
for (j =... | {
"author": "Li Li <boolli@google.com>",
"date": "Mon, 12 Jan 2026 23:09:44 +0000",
"thread_id": "20260112230944.3085309-3-boolli@google.com.mbox.gz"
} |
lkml | [PATCH 0/2] idpf: skip NULL pointers during deallocation. | In idpf txq and rxq error paths, some pointers are not allocated in the
first place. In the corresponding deallocation logic, we should not
deallocate them to prevent kernel panics.
Li Li (2):
idpf: skip deallocating bufq_sets from rx_qgrp if it is NULL.
idpf: skip deallocating txq group's txqs if it is NULL.
dr... | Dear Li,
Thank you for your patch.
Am 13.01.26 um 00:09 schrieb Li Li via Intel-wired-lan:
Is it easy to reproduce?
(Just for the future, a blank in the “tag section” is uncommon.)
Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de>
Kind regards,
Paul | {
"author": "Paul Menzel <pmenzel@molgen.mpg.de>",
"date": "Tue, 13 Jan 2026 07:31:26 +0100",
"thread_id": "20260112230944.3085309-3-boolli@google.com.mbox.gz"
} |
lkml | [PATCH 0/2] idpf: skip NULL pointers during deallocation. | In idpf txq and rxq error paths, some pointers are not allocated in the
first place. In the corresponding deallocation logic, we should not
deallocate them to prevent kernel panics.
Li Li (2):
idpf: skip deallocating bufq_sets from rx_qgrp if it is NULL.
idpf: skip deallocating txq group's txqs if it is NULL.
dr... | Dear Li,
Thank you for your patch.
Am 13.01.26 um 00:09 schrieb Li Li:
The reproduction steps would be nice to have documented.
Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de>
Kind regards,
Paul | {
"author": "Paul Menzel <pmenzel@molgen.mpg.de>",
"date": "Tue, 13 Jan 2026 07:43:07 +0100",
"thread_id": "20260112230944.3085309-3-boolli@google.com.mbox.gz"
} |
lkml | [PATCH 0/2] idpf: skip NULL pointers during deallocation. | In idpf txq and rxq error paths, some pointers are not allocated in the
first place. In the corresponding deallocation logic, we should not
deallocate them to prevent kernel panics.
Li Li (2):
idpf: skip deallocating bufq_sets from rx_qgrp if it is NULL.
idpf: skip deallocating txq group's txqs if it is NULL.
dr... | Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com> | {
"author": "\"Loktionov, Aleksandr\" <aleksandr.loktionov@intel.com>",
"date": "Tue, 13 Jan 2026 07:34:09 +0000",
"thread_id": "20260112230944.3085309-3-boolli@google.com.mbox.gz"
} |
lkml | [PATCH 0/2] idpf: skip NULL pointers during deallocation. | In idpf txq and rxq error paths, some pointers are not allocated in the
first place. In the corresponding deallocation logic, we should not
deallocate them to prevent kernel panics.
Li Li (2):
idpf: skip deallocating bufq_sets from rx_qgrp if it is NULL.
idpf: skip deallocating txq group's txqs if it is NULL.
dr... | Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com> | {
"author": "\"Loktionov, Aleksandr\" <aleksandr.loktionov@intel.com>",
"date": "Tue, 13 Jan 2026 07:34:57 +0000",
"thread_id": "20260112230944.3085309-3-boolli@google.com.mbox.gz"
} |
lkml | [PATCH 0/2] idpf: skip NULL pointers during deallocation. | In idpf txq and rxq error paths, some pointers are not allocated in the
first place. In the corresponding deallocation logic, we should not
deallocate them to prevent kernel panics.
Li Li (2):
idpf: skip deallocating bufq_sets from rx_qgrp if it is NULL.
idpf: skip deallocating txq group's txqs if it is NULL.
dr... | On Mon, Jan 12, 2026 at 10:31 PM Paul Menzel <pmenzel@molgen.mpg.de> wrote:
In our internal environments, we have the idpf driver running on
machines with small RAM, and it's not uncommon for
them to run out of memory and encounter kalloc issues, especially in
kcallocs where we allocate higher order memory.
To reliab... | {
"author": "Li Li <boolli@google.com>",
"date": "Thu, 15 Jan 2026 12:07:12 -0800",
"thread_id": "20260112230944.3085309-3-boolli@google.com.mbox.gz"
} |
lkml | [PATCH v16 0/7] x509, pkcs7, crypto: Add ML-DSA signing | Hi Lukas, Ignat,
[Note this is based on Eric Bigger's libcrypto-next branch].
These patches add ML-DSA module signing signing:
(1) Add a crypto_sig interface for ML-DSA, verification only.
(2) Generate a SHA256 hash of the X.509 TBSCertificate and check that in
the blacklist. Direct-sign ML-DSA doesn't gene... | Add verify-only public key crypto support for ML-DSA so that the
X.509/PKCS#7 signature verification code, as used by module signing,
amongst other things, can make use of it through the common crypto_sig API.
Signed-off-by: David Howells <dhowells@redhat.com>
Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>
cc: Eric ... | {
"author": "David Howells <dhowells@redhat.com>",
"date": "Mon, 2 Feb 2026 17:02:06 +0000",
"thread_id": "20260202170216.2467036-3-dhowells@redhat.com.mbox.gz"
} |
lkml | [PATCH v16 0/7] x509, pkcs7, crypto: Add ML-DSA signing | Hi Lukas, Ignat,
[Note this is based on Eric Bigger's libcrypto-next branch].
These patches add ML-DSA module signing signing:
(1) Add a crypto_sig interface for ML-DSA, verification only.
(2) Generate a SHA256 hash of the X.509 TBSCertificate and check that in
the blacklist. Direct-sign ML-DSA doesn't gene... | Calculate the SHA256 hash for blacklisting purposes independently of the
signature hash (which may be something other than SHA256).
This is necessary because when ML-DSA is used, no digest is calculated.
Note that this represents a change of behaviour in that the hash used for
the blacklist check would previously hav... | {
"author": "David Howells <dhowells@redhat.com>",
"date": "Mon, 2 Feb 2026 17:02:07 +0000",
"thread_id": "20260202170216.2467036-3-dhowells@redhat.com.mbox.gz"
} |
lkml | [PATCH v16 0/7] x509, pkcs7, crypto: Add ML-DSA signing | Hi Lukas, Ignat,
[Note this is based on Eric Bigger's libcrypto-next branch].
These patches add ML-DSA module signing signing:
(1) Add a crypto_sig interface for ML-DSA, verification only.
(2) Generate a SHA256 hash of the X.509 TBSCertificate and check that in
the blacklist. Direct-sign ML-DSA doesn't gene... | Rename ->digest and ->digest_len to ->m and ->m_size to represent the input
to the signature verification algorithm, reflecting that ->digest may no
longer actually *be* a digest.
Signed-off-by: David Howells <dhowells@redhat.com>
Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>
cc: Lukas Wunner <lukas@wunner.de>
cc: ... | {
"author": "David Howells <dhowells@redhat.com>",
"date": "Mon, 2 Feb 2026 17:02:08 +0000",
"thread_id": "20260202170216.2467036-3-dhowells@redhat.com.mbox.gz"
} |
lkml | [PATCH v16 0/7] x509, pkcs7, crypto: Add ML-DSA signing | Hi Lukas, Ignat,
[Note this is based on Eric Bigger's libcrypto-next branch].
These patches add ML-DSA module signing signing:
(1) Add a crypto_sig interface for ML-DSA, verification only.
(2) Generate a SHA256 hash of the X.509 TBSCertificate and check that in
the blacklist. Direct-sign ML-DSA doesn't gene... | Allow the data to be verified in a PKCS#7 or CMS message to be passed
directly to an asymmetric cipher algorithm (e.g. ML-DSA) if it wants to do
whatever passes for hashing/digestion itself. The normal digestion of the
data is then skipped as that would be ignored unless another signed info in
the message has some oth... | {
"author": "David Howells <dhowells@redhat.com>",
"date": "Mon, 2 Feb 2026 17:02:09 +0000",
"thread_id": "20260202170216.2467036-3-dhowells@redhat.com.mbox.gz"
} |
lkml | [PATCH v16 0/7] x509, pkcs7, crypto: Add ML-DSA signing | Hi Lukas, Ignat,
[Note this is based on Eric Bigger's libcrypto-next branch].
These patches add ML-DSA module signing signing:
(1) Add a crypto_sig interface for ML-DSA, verification only.
(2) Generate a SHA256 hash of the X.509 TBSCertificate and check that in
the blacklist. Direct-sign ML-DSA doesn't gene... | Add support for ML-DSA keys and signatures to the CMS/PKCS#7 and X.509
implementations. ML-DSA-44, -65 and -87 are all supported. For X.509
certificates, the TBSCertificate is required to be signed directly; for
CMS, direct signing of the data is preferred, though use of SHA512 (and
only that) as an intermediate hash... | {
"author": "David Howells <dhowells@redhat.com>",
"date": "Mon, 2 Feb 2026 17:02:10 +0000",
"thread_id": "20260202170216.2467036-3-dhowells@redhat.com.mbox.gz"
} |
lkml | [PATCH v16 0/7] x509, pkcs7, crypto: Add ML-DSA signing | Hi Lukas, Ignat,
[Note this is based on Eric Bigger's libcrypto-next branch].
These patches add ML-DSA module signing signing:
(1) Add a crypto_sig interface for ML-DSA, verification only.
(2) Generate a SHA256 hash of the X.509 TBSCertificate and check that in
the blacklist. Direct-sign ML-DSA doesn't gene... | Allow ML-DSA module signing to be enabled.
Note that OpenSSL's CMS_*() function suite does not, as of OpenSSL-3.6,
support the use of CMS_NOATTR with ML-DSA, so the prohibition against using
signedAttrs with module signing has to be removed. The selected digest
then applies only to the algorithm used to calculate the... | {
"author": "David Howells <dhowells@redhat.com>",
"date": "Mon, 2 Feb 2026 17:02:11 +0000",
"thread_id": "20260202170216.2467036-3-dhowells@redhat.com.mbox.gz"
} |
lkml | [PATCH v16 0/7] x509, pkcs7, crypto: Add ML-DSA signing | Hi Lukas, Ignat,
[Note this is based on Eric Bigger's libcrypto-next branch].
These patches add ML-DSA module signing signing:
(1) Add a crypto_sig interface for ML-DSA, verification only.
(2) Generate a SHA256 hash of the X.509 TBSCertificate and check that in
the blacklist. Direct-sign ML-DSA doesn't gene... | Allow the rejection of authenticatedAttributes in PKCS#7 (signedAttrs in
CMS) to be waived in the kernel config for ML-DSA when used for module
signing. This reflects the issue that openssl < 4.0 cannot do this and
openssl-4 has not yet been released.
This does not permit RSA, ECDSA or ECRDSA to be so waived (behavio... | {
"author": "David Howells <dhowells@redhat.com>",
"date": "Mon, 2 Feb 2026 17:02:12 +0000",
"thread_id": "20260202170216.2467036-3-dhowells@redhat.com.mbox.gz"
} |
lkml | [PATCH 0/2] Add HPET NMI Watchdog support | The current NMI watchdog relies on performance counters and consistently
occupies one on each CPU. When running virtual machines, we want to pass
performance counters to virtual machines so they can make use of them.
In addition the host system wants to use performance counters to check
the system to identify when anyt... | To implement an HPET based NMI watchdog, the HPET code will need to
reconfigure an IOAPIC pin to NMI mode. Add a function that allows driver
code to configure an IOAPIC pin for NMI delivery mode.
The caller can choose whether to invoke NMIs on the BSP or broadcast on
all CPUs in the system.
(Disclaimer: Some of this ... | {
"author": "Alexander Graf <graf@amazon.com>",
"date": "Mon, 2 Feb 2026 17:48:02 +0000",
"thread_id": "20260202174803.66640-3-graf@amazon.com.mbox.gz"
} |
lkml | [PATCH 0/2] Add HPET NMI Watchdog support | The current NMI watchdog relies on performance counters and consistently
occupies one on each CPU. When running virtual machines, we want to pass
performance counters to virtual machines so they can make use of them.
In addition the host system wants to use performance counters to check
the system to identify when anyt... | The traditional NMI watchdog timer uses performance counters to trigger
periodic NMIs. But performance counters are a scarce resource that are
best used for actual performance counting. However, the HPET is another
timer source on most modern x86 systems that can inject NMI interrupts.
Add support for using HPET timer... | {
"author": "Alexander Graf <graf@amazon.com>",
"date": "Mon, 2 Feb 2026 17:48:03 +0000",
"thread_id": "20260202174803.66640-3-graf@amazon.com.mbox.gz"
} |
lkml | [PATCH v16 0/7] x509, pkcs7, crypto: Add ML-DSA signing | Hi Lukas, Ignat,
[Note this is based on Eric Bigger's libcrypto-next branch].
These patches add ML-DSA module signing signing:
(1) Add a crypto_sig interface for ML-DSA, verification only.
(2) Generate a SHA256 hash of the X.509 TBSCertificate and check that in
the blacklist. Direct-sign ML-DSA doesn't gene... | Add verify-only public key crypto support for ML-DSA so that the
X.509/PKCS#7 signature verification code, as used by module signing,
amongst other things, can make use of it through the common crypto_sig API.
Signed-off-by: David Howells <dhowells@redhat.com>
Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>
cc: Eric ... | {
"author": "David Howells <dhowells@redhat.com>",
"date": "Mon, 2 Feb 2026 17:02:06 +0000",
"thread_id": "20260202170216.2467036-5-dhowells@redhat.com.mbox.gz"
} |
lkml | [PATCH v16 0/7] x509, pkcs7, crypto: Add ML-DSA signing | Hi Lukas, Ignat,
[Note this is based on Eric Bigger's libcrypto-next branch].
These patches add ML-DSA module signing signing:
(1) Add a crypto_sig interface for ML-DSA, verification only.
(2) Generate a SHA256 hash of the X.509 TBSCertificate and check that in
the blacklist. Direct-sign ML-DSA doesn't gene... | Calculate the SHA256 hash for blacklisting purposes independently of the
signature hash (which may be something other than SHA256).
This is necessary because when ML-DSA is used, no digest is calculated.
Note that this represents a change of behaviour in that the hash used for
the blacklist check would previously hav... | {
"author": "David Howells <dhowells@redhat.com>",
"date": "Mon, 2 Feb 2026 17:02:07 +0000",
"thread_id": "20260202170216.2467036-5-dhowells@redhat.com.mbox.gz"
} |
lkml | [PATCH v16 0/7] x509, pkcs7, crypto: Add ML-DSA signing | Hi Lukas, Ignat,
[Note this is based on Eric Bigger's libcrypto-next branch].
These patches add ML-DSA module signing signing:
(1) Add a crypto_sig interface for ML-DSA, verification only.
(2) Generate a SHA256 hash of the X.509 TBSCertificate and check that in
the blacklist. Direct-sign ML-DSA doesn't gene... | Rename ->digest and ->digest_len to ->m and ->m_size to represent the input
to the signature verification algorithm, reflecting that ->digest may no
longer actually *be* a digest.
Signed-off-by: David Howells <dhowells@redhat.com>
Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>
cc: Lukas Wunner <lukas@wunner.de>
cc: ... | {
"author": "David Howells <dhowells@redhat.com>",
"date": "Mon, 2 Feb 2026 17:02:08 +0000",
"thread_id": "20260202170216.2467036-5-dhowells@redhat.com.mbox.gz"
} |
lkml | [PATCH v16 0/7] x509, pkcs7, crypto: Add ML-DSA signing | Hi Lukas, Ignat,
[Note this is based on Eric Bigger's libcrypto-next branch].
These patches add ML-DSA module signing signing:
(1) Add a crypto_sig interface for ML-DSA, verification only.
(2) Generate a SHA256 hash of the X.509 TBSCertificate and check that in
the blacklist. Direct-sign ML-DSA doesn't gene... | Allow the data to be verified in a PKCS#7 or CMS message to be passed
directly to an asymmetric cipher algorithm (e.g. ML-DSA) if it wants to do
whatever passes for hashing/digestion itself. The normal digestion of the
data is then skipped as that would be ignored unless another signed info in
the message has some oth... | {
"author": "David Howells <dhowells@redhat.com>",
"date": "Mon, 2 Feb 2026 17:02:09 +0000",
"thread_id": "20260202170216.2467036-5-dhowells@redhat.com.mbox.gz"
} |
lkml | [PATCH v16 0/7] x509, pkcs7, crypto: Add ML-DSA signing | Hi Lukas, Ignat,
[Note this is based on Eric Bigger's libcrypto-next branch].
These patches add ML-DSA module signing signing:
(1) Add a crypto_sig interface for ML-DSA, verification only.
(2) Generate a SHA256 hash of the X.509 TBSCertificate and check that in
the blacklist. Direct-sign ML-DSA doesn't gene... | Add support for ML-DSA keys and signatures to the CMS/PKCS#7 and X.509
implementations. ML-DSA-44, -65 and -87 are all supported. For X.509
certificates, the TBSCertificate is required to be signed directly; for
CMS, direct signing of the data is preferred, though use of SHA512 (and
only that) as an intermediate hash... | {
"author": "David Howells <dhowells@redhat.com>",
"date": "Mon, 2 Feb 2026 17:02:10 +0000",
"thread_id": "20260202170216.2467036-5-dhowells@redhat.com.mbox.gz"
} |
lkml | [PATCH v16 0/7] x509, pkcs7, crypto: Add ML-DSA signing | Hi Lukas, Ignat,
[Note this is based on Eric Bigger's libcrypto-next branch].
These patches add ML-DSA module signing signing:
(1) Add a crypto_sig interface for ML-DSA, verification only.
(2) Generate a SHA256 hash of the X.509 TBSCertificate and check that in
the blacklist. Direct-sign ML-DSA doesn't gene... | Allow ML-DSA module signing to be enabled.
Note that OpenSSL's CMS_*() function suite does not, as of OpenSSL-3.6,
support the use of CMS_NOATTR with ML-DSA, so the prohibition against using
signedAttrs with module signing has to be removed. The selected digest
then applies only to the algorithm used to calculate the... | {
"author": "David Howells <dhowells@redhat.com>",
"date": "Mon, 2 Feb 2026 17:02:11 +0000",
"thread_id": "20260202170216.2467036-5-dhowells@redhat.com.mbox.gz"
} |
lkml | [PATCH v16 0/7] x509, pkcs7, crypto: Add ML-DSA signing | Hi Lukas, Ignat,
[Note this is based on Eric Bigger's libcrypto-next branch].
These patches add ML-DSA module signing signing:
(1) Add a crypto_sig interface for ML-DSA, verification only.
(2) Generate a SHA256 hash of the X.509 TBSCertificate and check that in
the blacklist. Direct-sign ML-DSA doesn't gene... | Allow the rejection of authenticatedAttributes in PKCS#7 (signedAttrs in
CMS) to be waived in the kernel config for ML-DSA when used for module
signing. This reflects the issue that openssl < 4.0 cannot do this and
openssl-4 has not yet been released.
This does not permit RSA, ECDSA or ECRDSA to be so waived (behavio... | {
"author": "David Howells <dhowells@redhat.com>",
"date": "Mon, 2 Feb 2026 17:02:12 +0000",
"thread_id": "20260202170216.2467036-5-dhowells@redhat.com.mbox.gz"
} |
lkml | [PATCH 0/2] module: Remove SHA-1 support for module signing | SHA-1 is considered deprecated and insecure due to vulnerabilities that can
lead to hash collisions. Most distributions have already been using SHA-2
for module signing because of this. The default was also changed last year
from SHA-1 to SHA-512 in f3b93547b91a ("module: sign with sha512 instead of
sha1 by default"). ... | SHA-1 is considered deprecated and insecure due to vulnerabilities that can
lead to hash collisions. Most distributions have already been using SHA-2
for module signing because of this. The default was also changed last year
from SHA-1 to SHA-512 in commit f3b93547b91a ("module: sign with sha512
instead of sha1 by defa... | {
"author": "Petr Pavlu <petr.pavlu@suse.com>",
"date": "Tue, 11 Nov 2025 16:48:31 +0100",
"thread_id": "20251111154923.978181-3-petr.pavlu@suse.com.mbox.gz"
} |
lkml | [PATCH 0/2] module: Remove SHA-1 support for module signing | SHA-1 is considered deprecated and insecure due to vulnerabilities that can
lead to hash collisions. Most distributions have already been using SHA-2
for module signing because of this. The default was also changed last year
from SHA-1 to SHA-512 in f3b93547b91a ("module: sign with sha512 instead of
sha1 by default"). ... | The PKCS#7 code in sign-file allows for signing only with SHA-1. Since
SHA-1 support for module signing has been removed, drop PKCS#7 support in
favor of using only CMS.
The use of the PKCS#7 code is selected by the following:
#if defined(LIBRESSL_VERSION_NUMBER) || \
OPENSSL_VERSION_NUMBER < 0x10000000L || \
de... | {
"author": "Petr Pavlu <petr.pavlu@suse.com>",
"date": "Tue, 11 Nov 2025 16:48:32 +0100",
"thread_id": "20251111154923.978181-3-petr.pavlu@suse.com.mbox.gz"
} |
lkml | [PATCH 0/2] module: Remove SHA-1 support for module signing | SHA-1 is considered deprecated and insecure due to vulnerabilities that can
lead to hash collisions. Most distributions have already been using SHA-2
for module signing because of this. The default was also changed last year
from SHA-1 to SHA-512 in f3b93547b91a ("module: sign with sha512 instead of
sha1 by default"). ... | Hi Petr,
On Tue, Nov 11, 2025 at 7:49 AM Petr Pavlu <petr.pavlu@suse.com> wrote:
It looks like GKI just uses the defaults here. Overall, Android
doesn't rely on module signing for security, it's only used to
differentiate between module types. Dropping SHA-1 support sounds like
a good idea to me.
For the series:
R... | {
"author": "Sami Tolvanen <samitolvanen@google.com>",
"date": "Tue, 11 Nov 2025 08:22:34 -0800",
"thread_id": "20251111154923.978181-3-petr.pavlu@suse.com.mbox.gz"
} |
lkml | [PATCH 0/2] module: Remove SHA-1 support for module signing | SHA-1 is considered deprecated and insecure due to vulnerabilities that can
lead to hash collisions. Most distributions have already been using SHA-2
for module signing because of this. The default was also changed last year
from SHA-1 to SHA-512 in f3b93547b91a ("module: sign with sha512 instead of
sha1 by default"). ... | On Tue, 2025-11-11 at 16:48 +0100, Petr Pavlu wrote:
The change log is a bit alarmist. CMS really *is* PKCS7 and most
literature will refer to CMS as PKCS7. What you're really deprecating
is the use of the PKCS7_sign() API which can only produce SHA-1
Signatures ... openssl is fully capable of producing any hash PKC... | {
"author": "James Bottomley <James.Bottomley@HansenPartnership.com>",
"date": "Tue, 11 Nov 2025 11:53:34 -0500",
"thread_id": "20251111154923.978181-3-petr.pavlu@suse.com.mbox.gz"
} |
lkml | [PATCH 0/2] module: Remove SHA-1 support for module signing | SHA-1 is considered deprecated and insecure due to vulnerabilities that can
lead to hash collisions. Most distributions have already been using SHA-2
for module signing because of this. The default was also changed last year
from SHA-1 to SHA-512 in f3b93547b91a ("module: sign with sha512 instead of
sha1 by default"). ... | On Tue, Nov 11, 2025 at 04:48:31PM +0100, Petr Pavlu wrote:
Agreed.
Reviewed-by: Aaron Tomlin <atomlin@atomlin.com>
--
Aaron Tomlin | {
"author": "Aaron Tomlin <atomlin@atomlin.com>",
"date": "Tue, 11 Nov 2025 17:37:28 -0500",
"thread_id": "20251111154923.978181-3-petr.pavlu@suse.com.mbox.gz"
} |
lkml | [PATCH 0/2] module: Remove SHA-1 support for module signing | SHA-1 is considered deprecated and insecure due to vulnerabilities that can
lead to hash collisions. Most distributions have already been using SHA-2
for module signing because of this. The default was also changed last year
from SHA-1 to SHA-512 in f3b93547b91a ("module: sign with sha512 instead of
sha1 by default"). ... | On 11/11/25 5:53 PM, James Bottomley wrote:
Ok, I plan to update the description to the following in v2:
sign-file: Use only the OpenSSL CMS API for signing
The USE_PKCS7 code in sign-file utilizes PKCS7_sign(), which allows signing
only with SHA-1. Since SHA-1 support for module signing has been removed,
drop the u... | {
"author": "Petr Pavlu <petr.pavlu@suse.com>",
"date": "Wed, 12 Nov 2025 14:51:24 +0100",
"thread_id": "20251111154923.978181-3-petr.pavlu@suse.com.mbox.gz"
} |
lkml | [PATCH 0/2] module: Remove SHA-1 support for module signing | SHA-1 is considered deprecated and insecure due to vulnerabilities that can
lead to hash collisions. Most distributions have already been using SHA-2
for module signing because of this. The default was also changed last year
from SHA-1 to SHA-512 in f3b93547b91a ("module: sign with sha512 instead of
sha1 by default"). ... | On Wed, 2025-11-12 at 14:51 +0100, Petr Pavlu wrote:
Much better, thanks!
Regards,
James | {
"author": "James Bottomley <James.Bottomley@HansenPartnership.com>",
"date": "Wed, 12 Nov 2025 10:05:57 -0500",
"thread_id": "20251111154923.978181-3-petr.pavlu@suse.com.mbox.gz"
} |
lkml | [PATCH 0/2] module: Remove SHA-1 support for module signing | SHA-1 is considered deprecated and insecure due to vulnerabilities that can
lead to hash collisions. Most distributions have already been using SHA-2
for module signing because of this. The default was also changed last year
from SHA-1 to SHA-512 in f3b93547b91a ("module: sign with sha512 instead of
sha1 by default"). ... | Petr Pavlu <petr.pavlu@suse.com> wrote:
We're looking at moving to ML-DSA, and the CMS support there is slightly dodgy
at the moment, so we need to hold off a bit on this change.
Patch 1, removing the option to sign with SHA-1 from the kernel is fine, but
doesn't stop things that are signed with SHA-1 from being ver... | {
"author": "David Howells <dhowells@redhat.com>",
"date": "Wed, 12 Nov 2025 15:36:57 +0000",
"thread_id": "20251111154923.978181-3-petr.pavlu@suse.com.mbox.gz"
} |
lkml | [PATCH 0/2] module: Remove SHA-1 support for module signing | SHA-1 is considered deprecated and insecure due to vulnerabilities that can
lead to hash collisions. Most distributions have already been using SHA-2
for module signing because of this. The default was also changed last year
from SHA-1 to SHA-512 in f3b93547b91a ("module: sign with sha512 instead of
sha1 by default"). ... | On Wed, 2025-11-12 at 15:36 +0000, David Howells wrote:
How will removing PKCS7_sign, which can only do sha1 signatures affect
that? Is the dodginess that the PKCS7_... API is better than CMS_...
for PQS at the moment? In which case we could pretty much do a rip and
replace of the CMS_ API if necessary, but that woul... | {
"author": "James Bottomley <James.Bottomley@HansenPartnership.com>",
"date": "Wed, 12 Nov 2025 10:47:23 -0500",
"thread_id": "20251111154923.978181-3-petr.pavlu@suse.com.mbox.gz"
} |
lkml | [PATCH 0/2] module: Remove SHA-1 support for module signing | SHA-1 is considered deprecated and insecure due to vulnerabilities that can
lead to hash collisions. Most distributions have already been using SHA-2
for module signing because of this. The default was also changed last year
from SHA-1 to SHA-512 in f3b93547b91a ("module: sign with sha512 instead of
sha1 by default"). ... | James Bottomley <James.Bottomley@HansenPartnership.com> wrote:
OpenSSL-3.5.1's ML-DSA support isn't completely right - in particular
CMS_NOATTR is not currently supported. I believe there is a fix in the works
there, but I doubt it has made it to all the distributions yet. I'm only
asking that we hold off a cycle; ... | {
"author": "David Howells <dhowells@redhat.com>",
"date": "Wed, 12 Nov 2025 15:52:40 +0000",
"thread_id": "20251111154923.978181-3-petr.pavlu@suse.com.mbox.gz"
} |
lkml | [PATCH 0/2] module: Remove SHA-1 support for module signing | SHA-1 is considered deprecated and insecure due to vulnerabilities that can
lead to hash collisions. Most distributions have already been using SHA-2
for module signing because of this. The default was also changed last year
from SHA-1 to SHA-512 in f3b93547b91a ("module: sign with sha512 instead of
sha1 by default"). ... | On Wed, 2025-11-12 at 15:52 +0000, David Howells wrote:
I get that PQC in openssl-3.5 is highly experimental, but that merely
means we tell people not to use it for a while. However, what I don't
see is how this impacts PKCS7_sign removal. The CMS API can do a sha1
signature if that's what people want and keeping th... | {
"author": "James Bottomley <James.Bottomley@HansenPartnership.com>",
"date": "Wed, 12 Nov 2025 10:58:31 -0500",
"thread_id": "20251111154923.978181-3-petr.pavlu@suse.com.mbox.gz"
} |
lkml | [PATCH 0/2] module: Remove SHA-1 support for module signing | SHA-1 is considered deprecated and insecure due to vulnerabilities that can
lead to hash collisions. Most distributions have already been using SHA-2
for module signing because of this. The default was also changed last year
from SHA-1 to SHA-512 in f3b93547b91a ("module: sign with sha512 instead of
sha1 by default"). ... | On Tue, 11 Nov 2025 16:48:30 +0100, Petr Pavlu wrote:
Applied to modules-next, thanks!
[1/2] module: Remove SHA-1 support for module signing
commit: 148519a06304af4e6fbb82f20e1a4480e2c1b126
[2/2] sign-file: Use only the OpenSSL CMS API for signing
commit: d7afd65b4acc775df872af30948dd7c196587169
Best reg... | {
"author": "Sami Tolvanen <samitolvanen@google.com>",
"date": "Mon, 22 Dec 2025 20:24:17 +0000",
"thread_id": "20251111154923.978181-3-petr.pavlu@suse.com.mbox.gz"
} |
lkml | [PATCH 0/2] module: Remove SHA-1 support for module signing | SHA-1 is considered deprecated and insecure due to vulnerabilities that can
lead to hash collisions. Most distributions have already been using SHA-2
for module signing because of this. The default was also changed last year
from SHA-1 to SHA-512 in f3b93547b91a ("module: sign with sha512 instead of
sha1 by default"). ... | Here's an alternative patch that will allow PKCS#7 with the hash specified on
the command line, removing the SHA1 restriction.
David
---
sign-file, pkcs7: Honour the hash parameter to sign-file
Currently, the sign-file program rejects anything other than "sha1" as the
hash parameter if it is going to produce a PKCS#7... | {
"author": "David Howells <dhowells@redhat.com>",
"date": "Mon, 02 Feb 2026 11:24:22 +0000",
"thread_id": "20251111154923.978181-3-petr.pavlu@suse.com.mbox.gz"
} |
lkml | [PATCH 0/2] module: Remove SHA-1 support for module signing | SHA-1 is considered deprecated and insecure due to vulnerabilities that can
lead to hash collisions. Most distributions have already been using SHA-2
for module signing because of this. The default was also changed last year
from SHA-1 to SHA-512 in f3b93547b91a ("module: sign with sha512 instead of
sha1 by default"). ... | David Howells <dhowells@redhat.com> wrote:
Apologies, that line was so I could debug it and should've been removed.
David | {
"author": "David Howells <dhowells@redhat.com>",
"date": "Mon, 02 Feb 2026 11:27:39 +0000",
"thread_id": "20251111154923.978181-3-petr.pavlu@suse.com.mbox.gz"
} |
lkml | [PATCH 0/2] module: Remove SHA-1 support for module signing | SHA-1 is considered deprecated and insecure due to vulnerabilities that can
lead to hash collisions. Most distributions have already been using SHA-2
for module signing because of this. The default was also changed last year
from SHA-1 to SHA-512 in f3b93547b91a ("module: sign with sha512 instead of
sha1 by default"). ... | On 2/2/26 12:24 PM, David Howells wrote:
Is it worth keeping this sign-file code that uses the OpenSSL PKCS7 API
instead of having only one variant that uses the newer CMS API?
--
Thanks,
Petr | {
"author": "Petr Pavlu <petr.pavlu@suse.com>",
"date": "Mon, 2 Feb 2026 13:25:06 +0100",
"thread_id": "20251111154923.978181-3-petr.pavlu@suse.com.mbox.gz"
} |
lkml | [PATCH 0/2] module: Remove SHA-1 support for module signing | SHA-1 is considered deprecated and insecure due to vulnerabilities that can
lead to hash collisions. Most distributions have already been using SHA-2
for module signing because of this. The default was also changed last year
from SHA-1 to SHA-512 in f3b93547b91a ("module: sign with sha512 instead of
sha1 by default"). ... | On Mon, Feb 2, 2026 at 4:25 AM Petr Pavlu <petr.pavlu@suse.com> wrote:
I agree that keeping only the CMS variant makes more sense. However,
David, please let me know if you'd prefer that I drop the patch
removing PKCS7 support from sign-file for now. I assumed you had no
further objections since the discussion in the ... | {
"author": "Sami Tolvanen <samitolvanen@google.com>",
"date": "Mon, 2 Feb 2026 09:01:19 -0800",
"thread_id": "20251111154923.978181-3-petr.pavlu@suse.com.mbox.gz"
} |
lkml | [PATCH 0/3] jbd2/ext4/ocfs2: READ_ONCE for lockless jinode reads | This series adds READ_ONCE() for existing lockless reads of
jbd2_inode fields in jbd2 and filesystem callbacks used by ext4 and ocfs2.
This is based on Jan's suggestion in the review of the ext4 jinode
publication race fix. [1]
[1]: https://lore.kernel.org/all/4jxwogttddiaoqbstlgou5ox6zs27ngjjz5ukrxafm2z5ijxod@so4eqn... | jbd2_inode fields are updated under journal->j_list_lock, but some
paths read them without holding the lock (e.g. fast commit
helpers and the ordered truncate fast path).
Use READ_ONCE() for these lockless reads to correct the
concurrency assumptions.
Suggested-by: Jan Kara <jack@suse.com>
Signed-off-by: Li Chen <me@... | {
"author": "Li Chen <me@linux.beauty>",
"date": "Fri, 30 Jan 2026 11:12:30 +0800",
"thread_id": "20260130031232.60780-1-me@linux.beauty.mbox.gz"
} |
lkml | [PATCH 0/3] jbd2/ext4/ocfs2: READ_ONCE for lockless jinode reads | This series adds READ_ONCE() for existing lockless reads of
jbd2_inode fields in jbd2 and filesystem callbacks used by ext4 and ocfs2.
This is based on Jan's suggestion in the review of the ext4 jinode
publication race fix. [1]
[1]: https://lore.kernel.org/all/4jxwogttddiaoqbstlgou5ox6zs27ngjjz5ukrxafm2z5ijxod@so4eqn... | ext4 journal commit callbacks access jbd2_inode fields such as
i_transaction and i_dirty_start/end without holding journal->j_list_lock.
Use READ_ONCE() for these reads to correct the concurrency assumptions.
Suggested-by: Jan Kara <jack@suse.com>
Signed-off-by: Li Chen <me@linux.beauty>
---
fs/ext4/inode.c | 6 +++... | {
"author": "Li Chen <me@linux.beauty>",
"date": "Fri, 30 Jan 2026 11:12:31 +0800",
"thread_id": "20260130031232.60780-1-me@linux.beauty.mbox.gz"
} |
lkml | [PATCH 0/3] jbd2/ext4/ocfs2: READ_ONCE for lockless jinode reads | This series adds READ_ONCE() for existing lockless reads of
jbd2_inode fields in jbd2 and filesystem callbacks used by ext4 and ocfs2.
This is based on Jan's suggestion in the review of the ext4 jinode
publication race fix. [1]
[1]: https://lore.kernel.org/all/4jxwogttddiaoqbstlgou5ox6zs27ngjjz5ukrxafm2z5ijxod@so4eqn... | ocfs2 journal commit callback reads jbd2_inode dirty range fields without
holding journal->j_list_lock.
Use READ_ONCE() for these reads to correct the concurrency assumptions.
Suggested-by: Jan Kara <jack@suse.com>
Signed-off-by: Li Chen <me@linux.beauty>
---
fs/ocfs2/journal.c | 7 +++++--
1 file changed, 5 inserti... | {
"author": "Li Chen <me@linux.beauty>",
"date": "Fri, 30 Jan 2026 11:12:32 +0800",
"thread_id": "20260130031232.60780-1-me@linux.beauty.mbox.gz"
} |
lkml | [PATCH 0/3] jbd2/ext4/ocfs2: READ_ONCE for lockless jinode reads | This series adds READ_ONCE() for existing lockless reads of
jbd2_inode fields in jbd2 and filesystem callbacks used by ext4 and ocfs2.
This is based on Jan's suggestion in the review of the ext4 jinode
publication race fix. [1]
[1]: https://lore.kernel.org/all/4jxwogttddiaoqbstlgou5ox6zs27ngjjz5ukrxafm2z5ijxod@so4eqn... | On Fri, Jan 30, 2026 at 11:12:32AM +0800, Li Chen wrote:
I don't think this is the right solution to the problem. If it is,
there needs to be much better argumentation in the commit message.
As I understand it, jbd2_journal_file_inode() initialises jinode,
then adds it to the t_inode_list, then drops the j_list_lock... | {
"author": "Matthew Wilcox <willy@infradead.org>",
"date": "Fri, 30 Jan 2026 05:27:59 +0000",
"thread_id": "20260130031232.60780-1-me@linux.beauty.mbox.gz"
} |
lkml | [PATCH 0/3] jbd2/ext4/ocfs2: READ_ONCE for lockless jinode reads | This series adds READ_ONCE() for existing lockless reads of
jbd2_inode fields in jbd2 and filesystem callbacks used by ext4 and ocfs2.
This is based on Jan's suggestion in the review of the ext4 jinode
publication race fix. [1]
[1]: https://lore.kernel.org/all/4jxwogttddiaoqbstlgou5ox6zs27ngjjz5ukrxafm2z5ijxod@so4eqn... | Hi Matthew,
> On Fri, Jan 30, 2026 at 11:12:32AM +0800, Li Chen wrote:
> > ocfs2 journal commit callback reads jbd2_inode dirty range fields without
> > holding journal->j_list_lock.
> >
> > Use READ_ONCE() for these reads to correct the concurrency assumptions.
>
> I don't think this is the right solution to... | {
"author": "Li Chen <me@linux.beauty>",
"date": "Fri, 30 Jan 2026 20:26:40 +0800",
"thread_id": "20260130031232.60780-1-me@linux.beauty.mbox.gz"
} |
lkml | [PATCH 0/3] jbd2/ext4/ocfs2: READ_ONCE for lockless jinode reads | This series adds READ_ONCE() for existing lockless reads of
jbd2_inode fields in jbd2 and filesystem callbacks used by ext4 and ocfs2.
This is based on Jan's suggestion in the review of the ext4 jinode
publication race fix. [1]
[1]: https://lore.kernel.org/all/4jxwogttddiaoqbstlgou5ox6zs27ngjjz5ukrxafm2z5ijxod@so4eqn... | On Fri, Jan 30, 2026 at 08:26:40PM +0800, Li Chen wrote:
I think that's the only issue that exists ...
I don't think that's true. I think what you're asserting is that:
int *pi;
int **ppi;
spin_lock(&lock);
*pi = 1;
*ppi = pi;
spin_unlock(&lock);
that the store to *pi must be observed before the store to *... | {
"author": "Matthew Wilcox <willy@infradead.org>",
"date": "Fri, 30 Jan 2026 16:36:28 +0000",
"thread_id": "20260130031232.60780-1-me@linux.beauty.mbox.gz"
} |
lkml | [PATCH 0/3] jbd2/ext4/ocfs2: READ_ONCE for lockless jinode reads | This series adds READ_ONCE() for existing lockless reads of
jbd2_inode fields in jbd2 and filesystem callbacks used by ext4 and ocfs2.
This is based on Jan's suggestion in the review of the ext4 jinode
publication race fix. [1]
[1]: https://lore.kernel.org/all/4jxwogttddiaoqbstlgou5ox6zs27ngjjz5ukrxafm2z5ijxod@so4eqn... | Hi Matthew,
Thank you very much for the detailed explanation and for your patience.
On Sat, 31 Jan 2026 00:36:28 +0800,
Matthew Wilcox wrote:
Understood.
Yes, agreed $B!=(B thank you. I was implicitly assuming the reader had taken the same lock
at some point, which is not a valid assumption for a lockless reader... | {
"author": "Li Chen <me@linux.beauty>",
"date": "Sun, 01 Feb 2026 12:37:36 +0800",
"thread_id": "20260130031232.60780-1-me@linux.beauty.mbox.gz"
} |
lkml | [PATCH 0/3] jbd2/ext4/ocfs2: READ_ONCE for lockless jinode reads | This series adds READ_ONCE() for existing lockless reads of
jbd2_inode fields in jbd2 and filesystem callbacks used by ext4 and ocfs2.
This is based on Jan's suggestion in the review of the ext4 jinode
publication race fix. [1]
[1]: https://lore.kernel.org/all/4jxwogttddiaoqbstlgou5ox6zs27ngjjz5ukrxafm2z5ijxod@so4eqn... | On Fri 30-01-26 11:12:30, Li Chen wrote:
Just one nit below. With that fixed feel free to add:
Reviewed-by: Jan Kara <jack@suse.cz>
i_vfs_inode never changes so READ_ONCE is pointless here.
Honza
--
Jan Kara <jack@suse.com>
SUSE Labs, CR | {
"author": "Jan Kara <jack@suse.cz>",
"date": "Mon, 2 Feb 2026 17:40:45 +0100",
"thread_id": "20260130031232.60780-1-me@linux.beauty.mbox.gz"
} |
lkml | [PATCH 0/3] jbd2/ext4/ocfs2: READ_ONCE for lockless jinode reads | This series adds READ_ONCE() for existing lockless reads of
jbd2_inode fields in jbd2 and filesystem callbacks used by ext4 and ocfs2.
This is based on Jan's suggestion in the review of the ext4 jinode
publication race fix. [1]
[1]: https://lore.kernel.org/all/4jxwogttddiaoqbstlgou5ox6zs27ngjjz5ukrxafm2z5ijxod@so4eqn... | On Fri 30-01-26 11:12:31, Li Chen wrote:
Looks good. Feel free to add:
Reviewed-by: Jan Kara <jack@suse.cz>
Honza
--
Jan Kara <jack@suse.com>
SUSE Labs, CR | {
"author": "Jan Kara <jack@suse.cz>",
"date": "Mon, 2 Feb 2026 17:41:39 +0100",
"thread_id": "20260130031232.60780-1-me@linux.beauty.mbox.gz"
} |
lkml | [PATCH 0/3] jbd2/ext4/ocfs2: READ_ONCE for lockless jinode reads | This series adds READ_ONCE() for existing lockless reads of
jbd2_inode fields in jbd2 and filesystem callbacks used by ext4 and ocfs2.
This is based on Jan's suggestion in the review of the ext4 jinode
publication race fix. [1]
[1]: https://lore.kernel.org/all/4jxwogttddiaoqbstlgou5ox6zs27ngjjz5ukrxafm2z5ijxod@so4eqn... | On Mon 02-02-26 17:40:45, Jan Kara wrote:
One more note: I've realized that for this to work you also need to make
jbd2_journal_file_inode() use WRITE_ONCE() when updating i_dirty_start,
i_dirty_end and i_flags.
Honza
--
Jan Kara <jack@suse.com>
SUSE Labs, CR | {
"author": "Jan Kara <jack@suse.cz>",
"date": "Mon, 2 Feb 2026 17:52:30 +0100",
"thread_id": "20260130031232.60780-1-me@linux.beauty.mbox.gz"
} |
lkml | [PATCH 0/3] jbd2/ext4/ocfs2: READ_ONCE for lockless jinode reads | This series adds READ_ONCE() for existing lockless reads of
jbd2_inode fields in jbd2 and filesystem callbacks used by ext4 and ocfs2.
This is based on Jan's suggestion in the review of the ext4 jinode
publication race fix. [1]
[1]: https://lore.kernel.org/all/4jxwogttddiaoqbstlgou5ox6zs27ngjjz5ukrxafm2z5ijxod@so4eqn... | On Fri 30-01-26 16:36:28, Matthew Wilcox wrote:
Well, the above reasonably accurately describes the code making jinode
visible. The reader code is like:
spin_lock(&lock);
pi = *ppi;
spin_unlock(&lock);
work with pi
so it is guaranteed to see pi properly initialized. The problem is that
"work with pi" can... | {
"author": "Jan Kara <jack@suse.cz>",
"date": "Mon, 2 Feb 2026 18:17:49 +0100",
"thread_id": "20260130031232.60780-1-me@linux.beauty.mbox.gz"
} |
lkml | [PATCH v5 00/25] Clean and update tilcdc driver to support
DRM_BRIDGE_ATTACH_NO_CONNECTOR | The starting point for this work was adding support for the HDMI cape:
https://www.seeedstudio.com/Seeed-Studio-BeagleBone-Green-HDMI-Cape.html
This will be sent in a later series.
Initially, Miguel proposed modifying the ite-it66121 bridge to support
the legacy behavior without the DRM_BRIDGE_ATTACH_NO_CONNECTOR flag... | Convert the device tree binding documentation for tilcdc
from plain text to DT binding schema.
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Signed-off-by: Kory Maincent (TI.com) <kory.maincent@bootlin.com>
---
Change in v3:
- Rename binding file to ti,am33xx-tilcdc.yaml.
- Use generic node n... | {
"author": "\"Kory Maincent (TI.com)\" <kory.maincent@bootlin.com>",
"date": "Fri, 23 Jan 2026 17:12:19 +0100",
"thread_id": "DG4N39EA7RN5.NARFDHX3IXGE@bootlin.com.mbox.gz"
} |
lkml | [PATCH v5 00/25] Clean and update tilcdc driver to support
DRM_BRIDGE_ATTACH_NO_CONNECTOR | The starting point for this work was adding support for the HDMI cape:
https://www.seeedstudio.com/Seeed-Studio-BeagleBone-Green-HDMI-Cape.html
This will be sent in a later series.
Initially, Miguel proposed modifying the ite-it66121 bridge to support
the legacy behavior without the DRM_BRIDGE_ATTACH_NO_CONNECTOR flag... | The tilcdc hardware does not generate VESA-compliant sync signals. It
aligns the vertical sync (VS) on the second edge of the horizontal sync
(HS) instead of the first edge. To compensate for this hardware
behavior, the driver applies a timing adjustment in mode_fixup().
Previously, this adjustment was conditional bas... | {
"author": "\"Kory Maincent (TI.com)\" <kory.maincent@bootlin.com>",
"date": "Fri, 23 Jan 2026 17:12:21 +0100",
"thread_id": "DG4N39EA7RN5.NARFDHX3IXGE@bootlin.com.mbox.gz"
} |
lkml | [PATCH v5 00/25] Clean and update tilcdc driver to support
DRM_BRIDGE_ATTACH_NO_CONNECTOR | The starting point for this work was adding support for the HDMI cape:
https://www.seeedstudio.com/Seeed-Studio-BeagleBone-Green-HDMI-Cape.html
This will be sent in a later series.
Initially, Miguel proposed modifying the ite-it66121 bridge to support
the legacy behavior without the DRM_BRIDGE_ATTACH_NO_CONNECTOR flag... | To maintain backward compatibility while removing the deprecated
tilcdc_panel driver, add a tilcdc_panel_legacy subdriver that converts
the legacy "ti,tilcdc,panel" devicetree binding to the standard
panel-dpi binding at early boot.
The conversion uses an embedded device tree overlay that is applied and
modified durin... | {
"author": "\"Kory Maincent (TI.com)\" <kory.maincent@bootlin.com>",
"date": "Fri, 23 Jan 2026 17:12:23 +0100",
"thread_id": "DG4N39EA7RN5.NARFDHX3IXGE@bootlin.com.mbox.gz"
} |
lkml | [PATCH v5 00/25] Clean and update tilcdc driver to support
DRM_BRIDGE_ATTACH_NO_CONNECTOR | The starting point for this work was adding support for the HDMI cape:
https://www.seeedstudio.com/Seeed-Studio-BeagleBone-Green-HDMI-Cape.html
This will be sent in a later series.
Initially, Miguel proposed modifying the ite-it66121 bridge to support
the legacy behavior without the DRM_BRIDGE_ATTACH_NO_CONNECTOR flag... | Mark the ti,tilcdc,panel binding as deprecated in the documentation.
This legacy binding should no longer be used for new designs. Users
should migrate to the standard DRM panel bindings instead.
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Signed-off-by: Kory Maincent (TI.com) <kory.maincent@b... | {
"author": "\"Kory Maincent (TI.com)\" <kory.maincent@bootlin.com>",
"date": "Fri, 23 Jan 2026 17:12:20 +0100",
"thread_id": "DG4N39EA7RN5.NARFDHX3IXGE@bootlin.com.mbox.gz"
} |
lkml | [PATCH v5 00/25] Clean and update tilcdc driver to support
DRM_BRIDGE_ATTACH_NO_CONNECTOR | The starting point for this work was adding support for the HDMI cape:
https://www.seeedstudio.com/Seeed-Studio-BeagleBone-Green-HDMI-Cape.html
This will be sent in a later series.
Initially, Miguel proposed modifying the ite-it66121 bridge to support
the legacy behavior without the DRM_BRIDGE_ATTACH_NO_CONNECTOR flag... | Migrate CRTC mode configuration to use standard DRM bus flags in
preparation for removing the tilcdc_panel driver and its custom
tilcdc_panel_info structure.
Add support for DRM_BUS_FLAG_PIXDATA_DRIVE_NEGEDGE and
DRM_BUS_FLAG_SYNC_DRIVE_NEGEDGE flags to control pixel clock and sync
signal edge polarity, while maintain... | {
"author": "\"Kory Maincent (TI.com)\" <kory.maincent@bootlin.com>",
"date": "Fri, 23 Jan 2026 17:12:22 +0100",
"thread_id": "DG4N39EA7RN5.NARFDHX3IXGE@bootlin.com.mbox.gz"
} |
lkml | [PATCH v5 00/25] Clean and update tilcdc driver to support
DRM_BRIDGE_ATTACH_NO_CONNECTOR | The starting point for this work was adding support for the HDMI cape:
https://www.seeedstudio.com/Seeed-Studio-BeagleBone-Green-HDMI-Cape.html
This will be sent in a later series.
Initially, Miguel proposed modifying the ite-it66121 bridge to support
the legacy behavior without the DRM_BRIDGE_ATTACH_NO_CONNECTOR flag... | The tilcdc panel subdriver is a legacy, non-standard driver that has been
replaced by the standard panel-dpi driver and panel-simple infrastructure.
With the device tree bindings removed and all in-tree users migrated to
use panel-dpi, this driver no longer has any associated device tree
bindings or users. The panel-d... | {
"author": "\"Kory Maincent (TI.com)\" <kory.maincent@bootlin.com>",
"date": "Fri, 23 Jan 2026 17:12:24 +0100",
"thread_id": "DG4N39EA7RN5.NARFDHX3IXGE@bootlin.com.mbox.gz"
} |
lkml | [PATCH v5 00/25] Clean and update tilcdc driver to support
DRM_BRIDGE_ATTACH_NO_CONNECTOR | The starting point for this work was adding support for the HDMI cape:
https://www.seeedstudio.com/Seeed-Studio-BeagleBone-Green-HDMI-Cape.html
This will be sent in a later series.
Initially, Miguel proposed modifying the ite-it66121 bridge to support
the legacy behavior without the DRM_BRIDGE_ATTACH_NO_CONNECTOR flag... | The tilcdc driver previously used the component framework to bind
external encoder subdrivers (specifically the TDA998x HDMI encoder).
With the removal of these subdrivers in previous commits, the component
framework is no longer needed.
This commit removes all component framework infrastructure including:
- Component... | {
"author": "\"Kory Maincent (TI.com)\" <kory.maincent@bootlin.com>",
"date": "Fri, 23 Jan 2026 17:12:25 +0100",
"thread_id": "DG4N39EA7RN5.NARFDHX3IXGE@bootlin.com.mbox.gz"
} |
lkml | [PATCH v5 00/25] Clean and update tilcdc driver to support
DRM_BRIDGE_ATTACH_NO_CONNECTOR | The starting point for this work was adding support for the HDMI cape:
https://www.seeedstudio.com/Seeed-Studio-BeagleBone-Green-HDMI-Cape.html
This will be sent in a later series.
Initially, Miguel proposed modifying the ite-it66121 bridge to support
the legacy behavior without the DRM_BRIDGE_ATTACH_NO_CONNECTOR flag... | Remove the unnecessary #endif/#ifdef CONFIG_DEBUG_FS pair that splits
the debugfs code section. This keeps all debugfs-related code within a
single preprocessor conditional block, improving code readability.
Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
Signed-off-by: Kory Maincent (TI.com) <kory.maincent@boo... | {
"author": "\"Kory Maincent (TI.com)\" <kory.maincent@bootlin.com>",
"date": "Fri, 23 Jan 2026 17:12:27 +0100",
"thread_id": "DG4N39EA7RN5.NARFDHX3IXGE@bootlin.com.mbox.gz"
} |
lkml | [PATCH v5 00/25] Clean and update tilcdc driver to support
DRM_BRIDGE_ATTACH_NO_CONNECTOR | The starting point for this work was adding support for the HDMI cape:
https://www.seeedstudio.com/Seeed-Studio-BeagleBone-Green-HDMI-Cape.html
This will be sent in a later series.
Initially, Miguel proposed modifying the ite-it66121 bridge to support
the legacy behavior without the DRM_BRIDGE_ATTACH_NO_CONNECTOR flag... | Remove the tilcdc_panel_info structure and its associated helper
function as the structure contains only redundant or unused parameters.
Most panel configuration parameters in tilcdc_panel_info are either:
- Already represented by existing DRM mode flags (invert_pxl_clk,
sync_edge via DRM_BUS_FLAG_*), or
- Set to id... | {
"author": "\"Kory Maincent (TI.com)\" <kory.maincent@bootlin.com>",
"date": "Fri, 23 Jan 2026 17:12:26 +0100",
"thread_id": "DG4N39EA7RN5.NARFDHX3IXGE@bootlin.com.mbox.gz"
} |
lkml | [PATCH v5 00/25] Clean and update tilcdc driver to support
DRM_BRIDGE_ATTACH_NO_CONNECTOR | The starting point for this work was adding support for the HDMI cape:
https://www.seeedstudio.com/Seeed-Studio-BeagleBone-Green-HDMI-Cape.html
This will be sent in a later series.
Initially, Miguel proposed modifying the ite-it66121 bridge to support
the legacy behavior without the DRM_BRIDGE_ATTACH_NO_CONNECTOR flag... | The num_encoders/encoders and num_connectors/connectors arrays in
tilcdc_drm_private are never populated or used by the driver.
Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
Signed-off-by: Kory Maincent (TI.com) <kory.maincent@bootlin.com>
---
drivers/gpu/drm/tilcdc/tilcdc_drv.c | 3 +--
drivers/gpu/drm/tilc... | {
"author": "\"Kory Maincent (TI.com)\" <kory.maincent@bootlin.com>",
"date": "Fri, 23 Jan 2026 17:12:28 +0100",
"thread_id": "DG4N39EA7RN5.NARFDHX3IXGE@bootlin.com.mbox.gz"
} |
lkml | [PATCH v5 00/25] Clean and update tilcdc driver to support
DRM_BRIDGE_ATTACH_NO_CONNECTOR | The starting point for this work was adding support for the HDMI cape:
https://www.seeedstudio.com/Seeed-Studio-BeagleBone-Green-HDMI-Cape.html
This will be sent in a later series.
Initially, Miguel proposed modifying the ite-it66121 bridge to support
the legacy behavior without the DRM_BRIDGE_ATTACH_NO_CONNECTOR flag... | Remove the "external_" prefix from encoder and connector members in the
tilcdc driver. These are internal driver structures and the "external"
naming is misleading. The simpler names better reflect that these are
the primary encoder and connector managed by this driver.
Also rename tilcdc_attach_external_device() to t... | {
"author": "\"Kory Maincent (TI.com)\" <kory.maincent@bootlin.com>",
"date": "Fri, 23 Jan 2026 17:12:29 +0100",
"thread_id": "DG4N39EA7RN5.NARFDHX3IXGE@bootlin.com.mbox.gz"
} |
lkml | [PATCH v5 00/25] Clean and update tilcdc driver to support
DRM_BRIDGE_ATTACH_NO_CONNECTOR | The starting point for this work was adding support for the HDMI cape:
https://www.seeedstudio.com/Seeed-Studio-BeagleBone-Green-HDMI-Cape.html
This will be sent in a later series.
Initially, Miguel proposed modifying the ite-it66121 bridge to support
the legacy behavior without the DRM_BRIDGE_ATTACH_NO_CONNECTOR flag... | The tilcdc_external module describes the encoder part of the tilcdc
driver. Rename it to tilcdc_encoder for better clarity and to make
the naming more consistent with DRM subsystem conventions, where
encoder-related files typically use "encoder" in their names.
Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
Si... | {
"author": "\"Kory Maincent (TI.com)\" <kory.maincent@bootlin.com>",
"date": "Fri, 23 Jan 2026 17:12:30 +0100",
"thread_id": "DG4N39EA7RN5.NARFDHX3IXGE@bootlin.com.mbox.gz"
} |
lkml | [PATCH v5 00/25] Clean and update tilcdc driver to support
DRM_BRIDGE_ATTACH_NO_CONNECTOR | The starting point for this work was adding support for the HDMI cape:
https://www.seeedstudio.com/Seeed-Studio-BeagleBone-Green-HDMI-Cape.html
This will be sent in a later series.
Initially, Miguel proposed modifying the ite-it66121 bridge to support
the legacy behavior without the DRM_BRIDGE_ATTACH_NO_CONNECTOR flag... | The tilcdc driver previously supported a sub-module system where
external display drivers (panels, encoders) could register themselves
through tilcdc_module_init() and be automatically initialized through
a module list. This infrastructure became unused after the component
framework support and panel driver was removed... | {
"author": "\"Kory Maincent (TI.com)\" <kory.maincent@bootlin.com>",
"date": "Fri, 23 Jan 2026 17:12:31 +0100",
"thread_id": "DG4N39EA7RN5.NARFDHX3IXGE@bootlin.com.mbox.gz"
} |
lkml | [PATCH v5 00/25] Clean and update tilcdc driver to support
DRM_BRIDGE_ATTACH_NO_CONNECTOR | The starting point for this work was adding support for the HDMI cape:
https://www.seeedstudio.com/Seeed-Studio-BeagleBone-Green-HDMI-Cape.html
This will be sent in a later series.
Initially, Miguel proposed modifying the ite-it66121 bridge to support
the legacy behavior without the DRM_BRIDGE_ATTACH_NO_CONNECTOR flag... | Use the drm_module_platform_driver() helper macro to simplify driver
registration. This macro handles both the platform driver registration
and the drm_firmware_drivers_only() check, making the custom init/exit
functions unnecessary.
Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
Signed-off-by: Kory Maincent (... | {
"author": "\"Kory Maincent (TI.com)\" <kory.maincent@bootlin.com>",
"date": "Fri, 23 Jan 2026 17:12:32 +0100",
"thread_id": "DG4N39EA7RN5.NARFDHX3IXGE@bootlin.com.mbox.gz"
} |
lkml | [PATCH v5 00/25] Clean and update tilcdc driver to support
DRM_BRIDGE_ATTACH_NO_CONNECTOR | The starting point for this work was adding support for the HDMI cape:
https://www.seeedstudio.com/Seeed-Studio-BeagleBone-Green-HDMI-Cape.html
This will be sent in a later series.
Initially, Miguel proposed modifying the ite-it66121 bridge to support
the legacy behavior without the DRM_BRIDGE_ATTACH_NO_CONNECTOR flag... | Move tilcdc_init/fini functions adjacent to the probe and remove functions
in preparation for cleanup and modernization. This improves readability
for subsequent commits that will refactor these functions.
No functional changes, only code reorganization.
Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
Signed-o... | {
"author": "\"Kory Maincent (TI.com)\" <kory.maincent@bootlin.com>",
"date": "Fri, 23 Jan 2026 17:12:33 +0100",
"thread_id": "DG4N39EA7RN5.NARFDHX3IXGE@bootlin.com.mbox.gz"
} |
lkml | [PATCH v5 00/25] Clean and update tilcdc driver to support
DRM_BRIDGE_ATTACH_NO_CONNECTOR | The starting point for this work was adding support for the HDMI cape:
https://www.seeedstudio.com/Seeed-Studio-BeagleBone-Green-HDMI-Cape.html
This will be sent in a later series.
Initially, Miguel proposed modifying the ite-it66121 bridge to support
the legacy behavior without the DRM_BRIDGE_ATTACH_NO_CONNECTOR flag... | Refactor the driver initialization to use modern DRM managed resource
APIs, simplifying the code.
The tilcdc_init and tilcdc_fini wrapper functions are removed since they
served no purpose after the component framework was eliminated. Their
logic is integrated directly into probe and remove.
Key changes:
- Use devm_d... | {
"author": "\"Kory Maincent (TI.com)\" <kory.maincent@bootlin.com>",
"date": "Fri, 23 Jan 2026 17:12:34 +0100",
"thread_id": "DG4N39EA7RN5.NARFDHX3IXGE@bootlin.com.mbox.gz"
} |
lkml | [PATCH v5 00/25] Clean and update tilcdc driver to support
DRM_BRIDGE_ATTACH_NO_CONNECTOR | The starting point for this work was adding support for the HDMI cape:
https://www.seeedstudio.com/Seeed-Studio-BeagleBone-Green-HDMI-Cape.html
This will be sent in a later series.
Initially, Miguel proposed modifying the ite-it66121 bridge to support
the legacy behavior without the DRM_BRIDGE_ATTACH_NO_CONNECTOR flag... | The DRM core documentation recommends against using dev_private:
"Instead of using this pointer it is recommended that drivers use
embed the struct &drm_device in their larger per-device structure."
This patch refactors the tilcdc driver to follow this recommendation
by embedding struct drm_device within struct tilcdc... | {
"author": "\"Kory Maincent (TI.com)\" <kory.maincent@bootlin.com>",
"date": "Fri, 23 Jan 2026 17:12:35 +0100",
"thread_id": "DG4N39EA7RN5.NARFDHX3IXGE@bootlin.com.mbox.gz"
} |
lkml | [PATCH v5 00/25] Clean and update tilcdc driver to support
DRM_BRIDGE_ATTACH_NO_CONNECTOR | The starting point for this work was adding support for the HDMI cape:
https://www.seeedstudio.com/Seeed-Studio-BeagleBone-Green-HDMI-Cape.html
This will be sent in a later series.
Initially, Miguel proposed modifying the ite-it66121 bridge to support
the legacy behavior without the DRM_BRIDGE_ATTACH_NO_CONNECTOR flag... | Convert the tilcdc driver to use DRM managed resources (drmm_* APIs)
to eliminate resource lifetime issues, particularly in probe deferral
scenarios.
This conversion addresses potential use-after-free bugs by ensuring
proper cleanup ordering through the DRM managed resource framework.
The changes include:
- Replace dr... | {
"author": "\"Kory Maincent (TI.com)\" <kory.maincent@bootlin.com>",
"date": "Fri, 23 Jan 2026 17:12:36 +0100",
"thread_id": "DG4N39EA7RN5.NARFDHX3IXGE@bootlin.com.mbox.gz"
} |
lkml | [PATCH v5 00/25] Clean and update tilcdc driver to support
DRM_BRIDGE_ATTACH_NO_CONNECTOR | The starting point for this work was adding support for the HDMI cape:
https://www.seeedstudio.com/Seeed-Studio-BeagleBone-Green-HDMI-Cape.html
This will be sent in a later series.
Initially, Miguel proposed modifying the ite-it66121 bridge to support
the legacy behavior without the DRM_BRIDGE_ATTACH_NO_CONNECTOR flag... | Replace drm_of_find_panel_or_bridge() with the newer
devm_drm_of_get_bridge() helper which simplifies the code by:
- Automatically handling both panel and bridge cases internally
- Managing the panel-to-bridge conversion when needed
- Using devres for resource management, eliminating manual cleanup
This removes the ne... | {
"author": "\"Kory Maincent (TI.com)\" <kory.maincent@bootlin.com>",
"date": "Fri, 23 Jan 2026 17:12:38 +0100",
"thread_id": "DG4N39EA7RN5.NARFDHX3IXGE@bootlin.com.mbox.gz"
} |
lkml | [PATCH v5 00/25] Clean and update tilcdc driver to support
DRM_BRIDGE_ATTACH_NO_CONNECTOR | The starting point for this work was adding support for the HDMI cape:
https://www.seeedstudio.com/Seeed-Studio-BeagleBone-Green-HDMI-Cape.html
This will be sent in a later series.
Initially, Miguel proposed modifying the ite-it66121 bridge to support
the legacy behavior without the DRM_BRIDGE_ATTACH_NO_CONNECTOR flag... | Replace dev_* logging calls with their DRM equivalents.
This aligns with the DRM subsystem's logging infrastructure and provides
better integration with DRM debugging mechanisms. The drm_* helpers
automatically include device information and integrate with DRM's
debug category filtering.
Reviewed-by: Luca Ceresoli <lu... | {
"author": "\"Kory Maincent (TI.com)\" <kory.maincent@bootlin.com>",
"date": "Fri, 23 Jan 2026 17:12:37 +0100",
"thread_id": "DG4N39EA7RN5.NARFDHX3IXGE@bootlin.com.mbox.gz"
} |
lkml | [PATCH v5 00/25] Clean and update tilcdc driver to support
DRM_BRIDGE_ATTACH_NO_CONNECTOR | The starting point for this work was adding support for the HDMI cape:
https://www.seeedstudio.com/Seeed-Studio-BeagleBone-Green-HDMI-Cape.html
This will be sent in a later series.
Initially, Miguel proposed modifying the ite-it66121 bridge to support
the legacy behavior without the DRM_BRIDGE_ATTACH_NO_CONNECTOR flag... | The tilcdc driver no longer uses the component framework to bind the
tda998x bridge driver. The component bind/unbind operations and the
encoder initialization code are now dead code and can be safely removed.
Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
Signed-off-by: Kory Maincent (TI.com) <kory.maincent@b... | {
"author": "\"Kory Maincent (TI.com)\" <kory.maincent@bootlin.com>",
"date": "Fri, 23 Jan 2026 17:12:39 +0100",
"thread_id": "DG4N39EA7RN5.NARFDHX3IXGE@bootlin.com.mbox.gz"
} |
lkml | [PATCH v5 00/25] Clean and update tilcdc driver to support
DRM_BRIDGE_ATTACH_NO_CONNECTOR | The starting point for this work was adding support for the HDMI cape:
https://www.seeedstudio.com/Seeed-Studio-BeagleBone-Green-HDMI-Cape.html
This will be sent in a later series.
Initially, Miguel proposed modifying the ite-it66121 bridge to support
the legacy behavior without the DRM_BRIDGE_ATTACH_NO_CONNECTOR flag... | Now that tda998x_create and tda998x_destroy are called only in the probe
function, there is no need for separate functions.
Move the code into the tda998x_probe and tda998x_remove functions.
Rewrite the cleanup path using goto calls in probe and reorder it in the
remove function.
Reviewed-by: Luca Ceresoli <luca.ceres... | {
"author": "\"Kory Maincent (TI.com)\" <kory.maincent@bootlin.com>",
"date": "Fri, 23 Jan 2026 17:12:40 +0100",
"thread_id": "DG4N39EA7RN5.NARFDHX3IXGE@bootlin.com.mbox.gz"
} |
lkml | [PATCH v5 00/25] Clean and update tilcdc driver to support
DRM_BRIDGE_ATTACH_NO_CONNECTOR | The starting point for this work was adding support for the HDMI cape:
https://www.seeedstudio.com/Seeed-Studio-BeagleBone-Green-HDMI-Cape.html
This will be sent in a later series.
Initially, Miguel proposed modifying the ite-it66121 bridge to support
the legacy behavior without the DRM_BRIDGE_ATTACH_NO_CONNECTOR flag... | Use directly drm_connector_cleanup in the destroy ops instead of having
a custom function that does nothing more.
Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
Signed-off-by: Kory Maincent (TI.com) <kory.maincent@bootlin.com>
---
drivers/gpu/drm/bridge/tda998x_drv.c | 7 +------
1 file changed, 1 insertion(+... | {
"author": "\"Kory Maincent (TI.com)\" <kory.maincent@bootlin.com>",
"date": "Fri, 23 Jan 2026 17:12:41 +0100",
"thread_id": "DG4N39EA7RN5.NARFDHX3IXGE@bootlin.com.mbox.gz"
} |
lkml | [PATCH v5 00/25] Clean and update tilcdc driver to support
DRM_BRIDGE_ATTACH_NO_CONNECTOR | The starting point for this work was adding support for the HDMI cape:
https://www.seeedstudio.com/Seeed-Studio-BeagleBone-Green-HDMI-Cape.html
This will be sent in a later series.
Initially, Miguel proposed modifying the ite-it66121 bridge to support
the legacy behavior without the DRM_BRIDGE_ATTACH_NO_CONNECTOR flag... | Add support for the DRM_BRIDGE_ATTACH_NO_CONNECTOR flag to allow display
controller drivers to create their own connectors. This modernizes the
driver to work with the current DRM bridge framework.
The implementation includes:
- Refactoring detection and EDID reading into bridge-usable helpers
- Adding bridge operatio... | {
"author": "\"Kory Maincent (TI.com)\" <kory.maincent@bootlin.com>",
"date": "Fri, 23 Jan 2026 17:12:42 +0100",
"thread_id": "DG4N39EA7RN5.NARFDHX3IXGE@bootlin.com.mbox.gz"
} |
lkml | [PATCH v5 00/25] Clean and update tilcdc driver to support
DRM_BRIDGE_ATTACH_NO_CONNECTOR | The starting point for this work was adding support for the HDMI cape:
https://www.seeedstudio.com/Seeed-Studio-BeagleBone-Green-HDMI-Cape.html
This will be sent in a later series.
Initially, Miguel proposed modifying the ite-it66121 bridge to support
the legacy behavior without the DRM_BRIDGE_ATTACH_NO_CONNECTOR flag... | Convert the driver to use the DRM_BRIDGE_ATTACH_NO_CONNECTOR flag when
attaching bridges. This modernizes the driver by delegating connector
creation to the bridge subsystem through drm_bridge_connector_init()
instead of manually searching for connectors created by the bridge.
The custom tilcdc_encoder_find_connector(... | {
"author": "\"Kory Maincent (TI.com)\" <kory.maincent@bootlin.com>",
"date": "Fri, 23 Jan 2026 17:12:43 +0100",
"thread_id": "DG4N39EA7RN5.NARFDHX3IXGE@bootlin.com.mbox.gz"
} |
lkml | [PATCH v5 00/25] Clean and update tilcdc driver to support
DRM_BRIDGE_ATTACH_NO_CONNECTOR | The starting point for this work was adding support for the HDMI cape:
https://www.seeedstudio.com/Seeed-Studio-BeagleBone-Green-HDMI-Cape.html
This will be sent in a later series.
Initially, Miguel proposed modifying the ite-it66121 bridge to support
the legacy behavior without the DRM_BRIDGE_ATTACH_NO_CONNECTOR flag... | Hi Kory,
On Fri Jan 23, 2026 at 5:12 PM CET, Kory Maincent (TI.com) wrote:
I'm OK with this patch, based on the v4 discussion. I have a question
however, see below.
You are introducing a subtle difference here: while you pass the connector
type to devm_drm_panel_bridge_add_typed(), devm_drm_of_get_bridge() does
not... | {
"author": "\"Luca Ceresoli\" <luca.ceresoli@bootlin.com>",
"date": "Fri, 30 Jan 2026 20:31:11 +0100",
"thread_id": "DG4N39EA7RN5.NARFDHX3IXGE@bootlin.com.mbox.gz"
} |
lkml | [PATCH v5 00/25] Clean and update tilcdc driver to support
DRM_BRIDGE_ATTACH_NO_CONNECTOR | The starting point for this work was adding support for the HDMI cape:
https://www.seeedstudio.com/Seeed-Studio-BeagleBone-Green-HDMI-Cape.html
This will be sent in a later series.
Initially, Miguel proposed modifying the ite-it66121 bridge to support
the legacy behavior without the DRM_BRIDGE_ATTACH_NO_CONNECTOR flag... | On Fri, 30 Jan 2026 20:31:11 +0100
"Luca Ceresoli" <luca.ceresoli@bootlin.com> wrote:
...
The connector type should be set by the bridge or the panel driver.
https://elixir.bootlin.com/linux/v6.18.6/source/drivers/gpu/drm/bridge/panel.c#L397
* This function is deprecated and should not be used in new drivers. Use... | {
"author": "Kory Maincent <kory.maincent@bootlin.com>",
"date": "Mon, 2 Feb 2026 10:57:17 +0100",
"thread_id": "DG4N39EA7RN5.NARFDHX3IXGE@bootlin.com.mbox.gz"
} |
lkml | [PATCH v5 00/25] Clean and update tilcdc driver to support
DRM_BRIDGE_ATTACH_NO_CONNECTOR | The starting point for this work was adding support for the HDMI cape:
https://www.seeedstudio.com/Seeed-Studio-BeagleBone-Green-HDMI-Cape.html
This will be sent in a later series.
Initially, Miguel proposed modifying the ite-it66121 bridge to support
the legacy behavior without the DRM_BRIDGE_ATTACH_NO_CONNECTOR flag... | On Mon Feb 2, 2026 at 10:57 AM CET, Kory Maincent wrote:
Ah, right, so it means this patch might cause some regressions due to panel
drivers to be fixed. So it's fine as long as you are ready to handle such
regression, should any happen.
Also other patches did exactly the same, e.g.:
commit 6e1853589ea6 ("drm/lcdi... | {
"author": "\"Luca Ceresoli\" <luca.ceresoli@bootlin.com>",
"date": "Mon, 02 Feb 2026 18:07:45 +0100",
"thread_id": "DG4N39EA7RN5.NARFDHX3IXGE@bootlin.com.mbox.gz"
} |
lkml | [PATCH 1/1] mshv: Add comment about huge page mappings in guest physical address space | From: Michael Kelley <mhklinux@outlook.com>
Huge page mappings in the guest physical address space depend on having
matching alignment of the userspace address in the parent partition and
of the guest physical address. Add a comment that captures this
information. See the link to the mailing list thread.
No code or f... | On Mon, Feb 02, 2026 at 08:51:01AM -0800, mhkelley58@gmail.com wrote:
Thanks. However, I'd suggest to reduce this commet a lot and put the
details into the commit message instead. Also, why this place? Why not a
part of the function description instead, for example?
Thanks,
Stanislav | {
"author": "Stanislav Kinsburskii <skinsburskii@linux.microsoft.com>",
"date": "Mon, 2 Feb 2026 09:17:33 -0800",
"thread_id": "aYDcLRhxx9wXRXBG@skinsburskii.localdomain.mbox.gz"
} |
lkml | [PATCH v4 0/3] targeted TLB sync IPIs for lockless page table walkers | When freeing or unsharing page tables we send an IPI to synchronize with
concurrent lockless page table walkers (e.g. GUP-fast). Today we broadcast
that IPI to all CPUs, which is costly on large machines and hurts RT
workloads[1].
This series makes those IPIs targeted. We track which CPUs are currently
doing a lockles... | From: Lance Yang <lance.yang@linux.dev>
Now that we have tlb_remove_table_sync_mm(), convert callers from
tlb_remove_table_sync_one() to enable targeted IPIs instead of broadcast.
Three callers updated:
1) collapse_huge_page() - after flushing the old PMD, only IPIs CPUs
walking this mm instead of all CPUs.
2) t... | {
"author": "Lance Yang <lance.yang@linux.dev>",
"date": "Mon, 2 Feb 2026 15:45:56 +0800",
"thread_id": "be38af98-e344-4552-a77b-b5345135e382@intel.com.mbox.gz"
} |
lkml | [PATCH v4 0/3] targeted TLB sync IPIs for lockless page table walkers | When freeing or unsharing page tables we send an IPI to synchronize with
concurrent lockless page table walkers (e.g. GUP-fast). Today we broadcast
that IPI to all CPUs, which is costly on large machines and hurts RT
workloads[1].
This series makes those IPIs targeted. We track which CPUs are currently
doing a lockles... | From: Lance Yang <lance.yang@linux.dev>
Currently, tlb_remove_table_sync_one() broadcasts IPIs to all CPUs to wait
for any concurrent lockless page table walkers (e.g., GUP-fast). This is
inefficient on systems with many CPUs, especially for RT workloads[1].
This patch introduces a per-CPU tracking mechanism to recor... | {
"author": "Lance Yang <lance.yang@linux.dev>",
"date": "Mon, 2 Feb 2026 15:45:55 +0800",
"thread_id": "be38af98-e344-4552-a77b-b5345135e382@intel.com.mbox.gz"
} |
lkml | [PATCH v4 0/3] targeted TLB sync IPIs for lockless page table walkers | When freeing or unsharing page tables we send an IPI to synchronize with
concurrent lockless page table walkers (e.g. GUP-fast). Today we broadcast
that IPI to all CPUs, which is costly on large machines and hurts RT
workloads[1].
This series makes those IPIs targeted. We track which CPUs are currently
doing a lockles... | From: Lance Yang <lance.yang@linux.dev>
When the TLB flush path already sends IPIs (e.g. native without INVLPGB,
or KVM), tlb_remove_table_sync_mm() does not need to send another round.
Add a property on pv_mmu_ops so each paravirt backend can indicate whether
its flush_tlb_multi sends real IPIs; if so, tlb_remove_ta... | {
"author": "Lance Yang <lance.yang@linux.dev>",
"date": "Mon, 2 Feb 2026 15:45:57 +0800",
"thread_id": "be38af98-e344-4552-a77b-b5345135e382@intel.com.mbox.gz"
} |
lkml | [PATCH v4 0/3] targeted TLB sync IPIs for lockless page table walkers | When freeing or unsharing page tables we send an IPI to synchronize with
concurrent lockless page table walkers (e.g. GUP-fast). Today we broadcast
that IPI to all CPUs, which is costly on large machines and hurts RT
workloads[1].
This series makes those IPIs targeted. We track which CPUs are currently
doing a lockles... | On Mon, Feb 02, 2026 at 03:45:55PM +0800, Lance Yang wrote:
What architecture, and that is acceptable?
One thing to try is something like:
xchg(this_cpu_ptr(&active_lockless_pt_walk_mm), mm);
That *might* be a little better on x86_64, on anything else you really
don't want to use this_cpu_() ops when you *know* I... | {
"author": "Peter Zijlstra <peterz@infradead.org>",
"date": "Mon, 2 Feb 2026 10:42:45 +0100",
"thread_id": "be38af98-e344-4552-a77b-b5345135e382@intel.com.mbox.gz"
} |
lkml | [PATCH v4 0/3] targeted TLB sync IPIs for lockless page table walkers | When freeing or unsharing page tables we send an IPI to synchronize with
concurrent lockless page table walkers (e.g. GUP-fast). Today we broadcast
that IPI to all CPUs, which is costly on large machines and hurts RT
workloads[1].
This series makes those IPIs targeted. We track which CPUs are currently
doing a lockles... | On Mon, Feb 02, 2026 at 03:45:54PM +0800, Lance Yang wrote:
I'm confused. This only happens when !PT_RECLAIM, because if PT_RECLAIM
__tlb_remove_table_one() actually uses RCU.
So why are you making things more expensive for no reason? | {
"author": "Peter Zijlstra <peterz@infradead.org>",
"date": "Mon, 2 Feb 2026 10:54:14 +0100",
"thread_id": "be38af98-e344-4552-a77b-b5345135e382@intel.com.mbox.gz"
} |
lkml | [PATCH v4 0/3] targeted TLB sync IPIs for lockless page table walkers | When freeing or unsharing page tables we send an IPI to synchronize with
concurrent lockless page table walkers (e.g. GUP-fast). Today we broadcast
that IPI to all CPUs, which is costly on large machines and hurts RT
workloads[1].
This series makes those IPIs targeted. We track which CPUs are currently
doing a lockles... | On Mon, 2 Feb 2026 10:54:14 +0100, Peter Zijlstra wrote:
You're right that when CONFIG_PT_RECLAIM is set, __tlb_remove_table_one()
uses call_rcu() and we never call any sync there — this series doesn't
touch that path.
In the !PT_RECLAIM table-free path (same __tlb_remove_table_one() branch
that calls tlb_remove_tabl... | {
"author": "Lance Yang <lance.yang@linux.dev>",
"date": "Mon, 2 Feb 2026 19:00:16 +0800",
"thread_id": "be38af98-e344-4552-a77b-b5345135e382@intel.com.mbox.gz"
} |
lkml | [PATCH v4 0/3] targeted TLB sync IPIs for lockless page table walkers | When freeing or unsharing page tables we send an IPI to synchronize with
concurrent lockless page table walkers (e.g. GUP-fast). Today we broadcast
that IPI to all CPUs, which is costly on large machines and hurts RT
workloads[1].
This series makes those IPIs targeted. We track which CPUs are currently
doing a lockles... | Hi Peter,
Thanks for taking time to review!
On 2026/2/2 17:42, Peter Zijlstra wrote:
x86-64.
I ran ./gup_bench which spawns 60 threads, each doing 500k GUP-fast
operations (pinning 8 pages per call) via the gup_test ioctl.
Results for pin pages:
- Before: avg 1.489s (10 runs)
- After: avg 1.533s (10 runs)
Given ... | {
"author": "Lance Yang <lance.yang@linux.dev>",
"date": "Mon, 2 Feb 2026 20:14:32 +0800",
"thread_id": "be38af98-e344-4552-a77b-b5345135e382@intel.com.mbox.gz"
} |
lkml | [PATCH v4 0/3] targeted TLB sync IPIs for lockless page table walkers | When freeing or unsharing page tables we send an IPI to synchronize with
concurrent lockless page table walkers (e.g. GUP-fast). Today we broadcast
that IPI to all CPUs, which is costly on large machines and hurts RT
workloads[1].
This series makes those IPIs targeted. We track which CPUs are currently
doing a lockles... | On Mon, Feb 02, 2026 at 07:00:16PM +0800, Lance Yang wrote:
Right, but if we can use full RCU for PT_RECLAIM, why can't we do so
unconditionally and not add overhead? | {
"author": "Peter Zijlstra <peterz@infradead.org>",
"date": "Mon, 2 Feb 2026 13:50:30 +0100",
"thread_id": "be38af98-e344-4552-a77b-b5345135e382@intel.com.mbox.gz"
} |
lkml | [PATCH v4 0/3] targeted TLB sync IPIs for lockless page table walkers | When freeing or unsharing page tables we send an IPI to synchronize with
concurrent lockless page table walkers (e.g. GUP-fast). Today we broadcast
that IPI to all CPUs, which is costly on large machines and hurts RT
workloads[1].
This series makes those IPIs targeted. We track which CPUs are currently
doing a lockles... | On Mon, Feb 02, 2026 at 08:14:32PM +0800, Lance Yang wrote:
No it doesn't; this is not how memory barriers work. | {
"author": "Peter Zijlstra <peterz@infradead.org>",
"date": "Mon, 2 Feb 2026 13:51:46 +0100",
"thread_id": "be38af98-e344-4552-a77b-b5345135e382@intel.com.mbox.gz"
} |
lkml | [PATCH v4 0/3] targeted TLB sync IPIs for lockless page table walkers | When freeing or unsharing page tables we send an IPI to synchronize with
concurrent lockless page table walkers (e.g. GUP-fast). Today we broadcast
that IPI to all CPUs, which is costly on large machines and hurts RT
workloads[1].
This series makes those IPIs targeted. We track which CPUs are currently
doing a lockles... | On 2026/2/2 20:50, Peter Zijlstra wrote:
The sync (IPI) is mainly needed for unshare (e.g. hugetlb) and collapse
(khugepaged) paths, regardless of whether table free uses RCU, IIUC. | {
"author": "Lance Yang <lance.yang@linux.dev>",
"date": "Mon, 2 Feb 2026 20:58:59 +0800",
"thread_id": "be38af98-e344-4552-a77b-b5345135e382@intel.com.mbox.gz"
} |
lkml | [PATCH v4 0/3] targeted TLB sync IPIs for lockless page table walkers | When freeing or unsharing page tables we send an IPI to synchronize with
concurrent lockless page table walkers (e.g. GUP-fast). Today we broadcast
that IPI to all CPUs, which is costly on large machines and hurts RT
workloads[1].
This series makes those IPIs targeted. We track which CPUs are currently
doing a lockles... | On 2026/2/2 20:58, Lance Yang wrote:
In addition: We need the sync when we modify page tables (e.g. unshare,
collapse), not only when we free them. RCU can defer freeing but does
not prevent lockless walkers from seeing concurrent in-place
modifications, so we need the IPI to synchronize with those walkers
first. | {
"author": "Lance Yang <lance.yang@linux.dev>",
"date": "Mon, 2 Feb 2026 21:07:10 +0800",
"thread_id": "be38af98-e344-4552-a77b-b5345135e382@intel.com.mbox.gz"
} |
lkml | [PATCH v4 0/3] targeted TLB sync IPIs for lockless page table walkers | When freeing or unsharing page tables we send an IPI to synchronize with
concurrent lockless page table walkers (e.g. GUP-fast). Today we broadcast
that IPI to all CPUs, which is costly on large machines and hurts RT
workloads[1].
This series makes those IPIs targeted. We track which CPUs are currently
doing a lockles... | On 2026/2/2 20:51, Peter Zijlstra wrote:
Hmm... we need MB rather than RMB on the sync side. Is that correct?
Walker:
[W]active_lockless_pt_walk_mm = mm -> MB -> [L]page-tables
Sync:
[W]page-tables -> MB -> [L]active_lockless_pt_walk_mm
Thanks,
Lance | {
"author": "Lance Yang <lance.yang@linux.dev>",
"date": "Mon, 2 Feb 2026 21:23:07 +0800",
"thread_id": "be38af98-e344-4552-a77b-b5345135e382@intel.com.mbox.gz"
} |
lkml | [PATCH v4 0/3] targeted TLB sync IPIs for lockless page table walkers | When freeing or unsharing page tables we send an IPI to synchronize with
concurrent lockless page table walkers (e.g. GUP-fast). Today we broadcast
that IPI to all CPUs, which is costly on large machines and hurts RT
workloads[1].
This series makes those IPIs targeted. We track which CPUs are currently
doing a lockles... | On Mon, Feb 02, 2026 at 09:07:10PM +0800, Lance Yang wrote:
Currently PT_RECLAIM=y has no IPI; are you saying that is broken? If
not, then why do we need this at all? | {
"author": "Peter Zijlstra <peterz@infradead.org>",
"date": "Mon, 2 Feb 2026 14:37:13 +0100",
"thread_id": "be38af98-e344-4552-a77b-b5345135e382@intel.com.mbox.gz"
} |
lkml | [PATCH v4 0/3] targeted TLB sync IPIs for lockless page table walkers | When freeing or unsharing page tables we send an IPI to synchronize with
concurrent lockless page table walkers (e.g. GUP-fast). Today we broadcast
that IPI to all CPUs, which is costly on large machines and hurts RT
workloads[1].
This series makes those IPIs targeted. We track which CPUs are currently
doing a lockles... | On Mon, Feb 02, 2026 at 09:23:07PM +0800, Lance Yang wrote:
This can work -- but only if the walker and sync touch the same
page-table address.
Now, typically I would imagine they both share the p4d/pud address at
the very least, right? | {
"author": "Peter Zijlstra <peterz@infradead.org>",
"date": "Mon, 2 Feb 2026 14:42:33 +0100",
"thread_id": "be38af98-e344-4552-a77b-b5345135e382@intel.com.mbox.gz"
} |
lkml | [PATCH v4 0/3] targeted TLB sync IPIs for lockless page table walkers | When freeing or unsharing page tables we send an IPI to synchronize with
concurrent lockless page table walkers (e.g. GUP-fast). Today we broadcast
that IPI to all CPUs, which is costly on large machines and hurts RT
workloads[1].
This series makes those IPIs targeted. We track which CPUs are currently
doing a lockles... | On 2026/2/2 21:42, Peter Zijlstra wrote:
Thanks. I think I see the confusion ...
To be clear, the goal is not to make the walker see page-table writes
through the
MB pairing, but to wait for any concurrent lockless page table walkers
to finish.
The flow is:
1) Page tables are modified
2) TLB flush is done
3) Read... | {
"author": "Lance Yang <lance.yang@linux.dev>",
"date": "Mon, 2 Feb 2026 22:28:47 +0800",
"thread_id": "be38af98-e344-4552-a77b-b5345135e382@intel.com.mbox.gz"
} |
lkml | [PATCH v4 0/3] targeted TLB sync IPIs for lockless page table walkers | When freeing or unsharing page tables we send an IPI to synchronize with
concurrent lockless page table walkers (e.g. GUP-fast). Today we broadcast
that IPI to all CPUs, which is costly on large machines and hurts RT
workloads[1].
This series makes those IPIs targeted. We track which CPUs are currently
doing a lockles... | On 2026/2/2 21:37, Peter Zijlstra wrote:
PT_RECLAIM=y does have IPI for unshare/collapse — those paths call
tlb_flush_unshared_tables() (for hugetlb unshare) and collapse_huge_page()
(in khugepaged collapse), which already send IPIs today (broadcast to all
CPUs via tlb_remove_table_sync_one()).
What PT_RECLAIM=y does... | {
"author": "Lance Yang <lance.yang@linux.dev>",
"date": "Mon, 2 Feb 2026 22:37:39 +0800",
"thread_id": "be38af98-e344-4552-a77b-b5345135e382@intel.com.mbox.gz"
} |
lkml | [PATCH v4 0/3] targeted TLB sync IPIs for lockless page table walkers | When freeing or unsharing page tables we send an IPI to synchronize with
concurrent lockless page table walkers (e.g. GUP-fast). Today we broadcast
that IPI to all CPUs, which is costly on large machines and hurts RT
workloads[1].
This series makes those IPIs targeted. We track which CPUs are currently
doing a lockles... | On Mon, Feb 02, 2026 at 10:37:39PM +0800, Lance Yang wrote:
Oh bah, reading is hard. I had missed they had more table_sync_one() calls,
rather than remove_table_one().
So you *can* replace table_sync_one() with rcu_sync(), that will provide
the same guarantees. Its just a 'little' bit slower on the update side,
but d... | {
"author": "Peter Zijlstra <peterz@infradead.org>",
"date": "Mon, 2 Feb 2026 16:09:57 +0100",
"thread_id": "be38af98-e344-4552-a77b-b5345135e382@intel.com.mbox.gz"
} |
lkml | [PATCH v4 0/3] targeted TLB sync IPIs for lockless page table walkers | When freeing or unsharing page tables we send an IPI to synchronize with
concurrent lockless page table walkers (e.g. GUP-fast). Today we broadcast
that IPI to all CPUs, which is costly on large machines and hurts RT
workloads[1].
This series makes those IPIs targeted. We track which CPUs are currently
doing a lockles... | On 2026/2/2 23:09, Peter Zijlstra wrote:
Yep, we could replace the IPI with synchronize_rcu() on the sync side:
- Currently: TLB flush → send IPI → wait for walkers to finish
- With synchronize_rcu(): TLB flush → synchronize_rcu() -> waits for
grace period
Lockless walkers (e.g. GUP-fast) use local_irq_disable();
... | {
"author": "Lance Yang <lance.yang@linux.dev>",
"date": "Mon, 2 Feb 2026 23:52:31 +0800",
"thread_id": "be38af98-e344-4552-a77b-b5345135e382@intel.com.mbox.gz"
} |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.