data_type large_stringclasses 3
values | source large_stringclasses 29
values | code large_stringlengths 98 49.4M | filepath large_stringlengths 5 161 ⌀ | message large_stringclasses 234
values | commit large_stringclasses 234
values | subject large_stringclasses 418
values | critique large_stringlengths 101 1.26M ⌀ | metadata dict |
|---|---|---|---|---|---|---|---|---|
lkml_critique | netdev | This is part 2 of the qcom-ethqos series, part 1 has now been merged.
This part of the series focuses on the generic PHY driver, but these
changes have dependencies on the ethernet driver, hence why
it will need to go via net-next. Furthermore, subsequent changes
depend on these patches.
The underlying ideas here are... | null | null | null | [PATCH net-next 0/9] net: stmmac: qcom-ethqos: further serdes
reorganisation | Now that the qcom-ethqos driver has migrated to use phy_set_mode_ext()
rather than phy_set_speed() to configure the SerDes, the support for
phy_set_speed() is now obsolete. Remove support for this method.
Using the MAC speed for the SerDes is never correct due to the PCS
encoding. For SGMII and 2500BASE-X, the PCS use... | {
"author": "\"Russell King (Oracle)\" <rmk+kernel@armlinux.org.uk>",
"date": "Wed, 25 Feb 2026 10:59:22 +0000",
"is_openbsd": false,
"thread_id": "aaGgDfaOBHNY6xL2@vaman.mbox.gz"
} |
lkml_critique | netdev | This is part 2 of the qcom-ethqos series, part 1 has now been merged.
This part of the series focuses on the generic PHY driver, but these
changes have dependencies on the ethernet driver, hence why
it will need to go via net-next. Furthermore, subsequent changes
depend on these patches.
The underlying ideas here are... | null | null | null | [PATCH net-next 0/9] net: stmmac: qcom-ethqos: further serdes
reorganisation | As established in the previous commit, using SPEED_1000 and SPEED_2500
does not make sense for a SerDes due to the PCS encoding that is used
over the SerDes link, which inflates the data rate at the SerDes. Thus,
the use of these constants in a SerDes driver is incorrect.
Since qcom-sgmii-eth no longer implements phy_... | {
"author": "\"Russell King (Oracle)\" <rmk+kernel@armlinux.org.uk>",
"date": "Wed, 25 Feb 2026 10:59:28 +0000",
"is_openbsd": false,
"thread_id": "aaGgDfaOBHNY6xL2@vaman.mbox.gz"
} |
lkml_critique | netdev | This is part 2 of the qcom-ethqos series, part 1 has now been merged.
This part of the series focuses on the generic PHY driver, but these
changes have dependencies on the ethernet driver, hence why
it will need to go via net-next. Furthermore, subsequent changes
depend on these patches.
The underlying ideas here are... | null | null | null | [PATCH net-next 0/9] net: stmmac: qcom-ethqos: further serdes
reorganisation | Now that qcom_dwmac_sgmii_phy_interface() only serves to validate the
passed interface mode, combine it with qcom_dwmac_sgmii_phy_validate(),
and use qcom_dwmac_sgmii_phy_validate() to validate the mode in
qcom_dwmac_sgmii_phy_set_mode().
Tested-by: Mohd Ayaan Anwar <mohd.anwar@oss.qualcomm.com>
Signed-off-by: Russell... | {
"author": "\"Russell King (Oracle)\" <rmk+kernel@armlinux.org.uk>",
"date": "Wed, 25 Feb 2026 10:59:33 +0000",
"is_openbsd": false,
"thread_id": "aaGgDfaOBHNY6xL2@vaman.mbox.gz"
} |
lkml_critique | netdev | This is part 2 of the qcom-ethqos series, part 1 has now been merged.
This part of the series focuses on the generic PHY driver, but these
changes have dependencies on the ethernet driver, hence why
it will need to go via net-next. Furthermore, subsequent changes
depend on these patches.
The underlying ideas here are... | null | null | null | [PATCH net-next 0/9] net: stmmac: qcom-ethqos: further serdes
reorganisation | Allow any order of the .power_on() and .set_mode*() methods as per the
recent discussion. This means phy_power_on() with this SerDes will now
restore the previous setup without requiring a subsequent
phy_set_mode*() call.
Tested-by: Mohd Ayaan Anwar <mohd.anwar@oss.qualcomm.com>
Signed-off-by: Russell King (Oracle) <r... | {
"author": "\"Russell King (Oracle)\" <rmk+kernel@armlinux.org.uk>",
"date": "Wed, 25 Feb 2026 10:59:38 +0000",
"is_openbsd": false,
"thread_id": "aaGgDfaOBHNY6xL2@vaman.mbox.gz"
} |
lkml_critique | netdev | This is part 2 of the qcom-ethqos series, part 1 has now been merged.
This part of the series focuses on the generic PHY driver, but these
changes have dependencies on the ethernet driver, hence why
it will need to go via net-next. Furthermore, subsequent changes
depend on these patches.
The underlying ideas here are... | null | null | null | [PATCH net-next 0/9] net: stmmac: qcom-ethqos: further serdes
reorganisation | On 25-02-26, 10:59, Russell King (Oracle) wrote:
Acked-by: Vinod Koul <vkoul@kernel.org>
--
~Vinod | {
"author": "Vinod Koul <vkoul@kernel.org>",
"date": "Fri, 27 Feb 2026 19:12:57 +0530",
"is_openbsd": false,
"thread_id": "aaGgDfaOBHNY6xL2@vaman.mbox.gz"
} |
lkml_critique | netdev | This is part 2 of the qcom-ethqos series, part 1 has now been merged.
This part of the series focuses on the generic PHY driver, but these
changes have dependencies on the ethernet driver, hence why
it will need to go via net-next. Furthermore, subsequent changes
depend on these patches.
The underlying ideas here are... | null | null | null | [PATCH net-next 0/9] net: stmmac: qcom-ethqos: further serdes
reorganisation | On 25-02-26, 09:02, Russell King (Oracle) wrote:
This lgtm, can we get signed tag so that we can pull this into phy tree
as well
Thanks
--
~Vinod | {
"author": "Vinod Koul <vkoul@kernel.org>",
"date": "Fri, 27 Feb 2026 19:17:05 +0530",
"is_openbsd": false,
"thread_id": "aaGgDfaOBHNY6xL2@vaman.mbox.gz"
} |
lkml_critique | netdev | This is part 2 of the qcom-ethqos series, part 1 has now been merged.
This part of the series focuses on the generic PHY driver, but these
changes have dependencies on the ethernet driver, hence why
it will need to go via net-next. Furthermore, subsequent changes
depend on these patches.
The underlying ideas here are... | null | null | null | [PATCH net-next 0/9] net: stmmac: qcom-ethqos: further serdes
reorganisation | Hi Vinod,
On Fri, Feb 27, 2026 at 07:17:05PM +0530, Vinod Koul wrote:
I think this series is obsolete. It has been superseded in the netdev
patchwork by:
[PATCH RESEND2 net-next 0/8] net: stmmac: qcom-ethqos: further serdes reorganisation
├─>[PATCH RESEND2 net-next 1/8] net: stmmac: qcom-ethqos: move ethqos_set_serd... | {
"author": "Vladimir Oltean <olteanv@gmail.com>",
"date": "Fri, 27 Feb 2026 17:27:07 +0200",
"is_openbsd": false,
"thread_id": "aaGgDfaOBHNY6xL2@vaman.mbox.gz"
} |
lkml_critique | netdev | This is part 2 of the qcom-ethqos series, part 1 has now been merged.
This part of the series focuses on the generic PHY driver, but these
changes have dependencies on the ethernet driver, hence why
it will need to go via net-next. Furthermore, subsequent changes
depend on these patches.
The underlying ideas here are... | null | null | null | [PATCH net-next 0/9] net: stmmac: qcom-ethqos: further serdes
reorganisation | On Fri, Feb 27, 2026 at 05:27:07PM +0200, Vladimir Oltean wrote:
No need. Looking at PW, it seems patch 7 has AI review issues, so will
need to be re-sent - although I can't fathom what the AI found in patch
7. I've already added Vinod's acks (since they were just resends to fix
botched sending, no actual changes in t... | {
"author": "\"Russell King (Oracle)\" <linux@armlinux.org.uk>",
"date": "Fri, 27 Feb 2026 15:30:56 +0000",
"is_openbsd": false,
"thread_id": "aaGgDfaOBHNY6xL2@vaman.mbox.gz"
} |
lkml_critique | netdev | For idpf:
Li Li moves the check for software marker to occur after incrementing
next to clean to avoid re-encountering the same packet. He also adds a
couple of checks to prevent NULL pointer dereferences and NULLs rss_key,
after free, in error path so that later checks are properly evaluated.
Brian Vazquez adjusts IR... | null | null | null | [PATCH net v2 00/12][pull request] Intel Wired LAN Driver Updates 2026-02-19 (idpf, ice, i40e, ixgbevf, e1000e) | From: Li Li <boolli@google.com>
In idpf_rxq_group_alloc(), if rx_qgrp->splitq.bufq_sets failed to get
allocated:
rx_qgrp->splitq.bufq_sets = kcalloc(vport->num_bufqs_per_qgrp,
sizeof(struct idpf_bufq_set),
GFP_KERNEL);
if (!rx_qgrp->splitq.bufq_sets) {
err = -ENOMEM;
goto err_alloc;
}
idpf_r... | {
"author": "Tony Nguyen <anthony.l.nguyen@intel.com>",
"date": "Wed, 25 Feb 2026 13:15:33 -0800",
"is_openbsd": false,
"thread_id": "20260225211546.1949260-3-anthony.l.nguyen@intel.com.mbox.gz"
} |
lkml_critique | netdev | For idpf:
Li Li moves the check for software marker to occur after incrementing
next to clean to avoid re-encountering the same packet. He also adds a
couple of checks to prevent NULL pointer dereferences and NULLs rss_key,
after free, in error path so that later checks are properly evaluated.
Brian Vazquez adjusts IR... | null | null | null | [PATCH net v2 00/12][pull request] Intel Wired LAN Driver Updates 2026-02-19 (idpf, ice, i40e, ixgbevf, e1000e) | From: Li Li <boolli@google.com>
Currently, in idpf_wait_for_sw_marker_completion(), when an
IDPF_TXD_COMPLT_SW_MARKER packet is found, the routine breaks out of
the for loop and does not increment the next_to_clean counter. This
causes the subsequent NAPI polls to run into the same
IDPF_TXD_COMPLT_SW_MARKER packet aga... | {
"author": "Tony Nguyen <anthony.l.nguyen@intel.com>",
"date": "Wed, 25 Feb 2026 13:15:32 -0800",
"is_openbsd": false,
"thread_id": "20260225211546.1949260-3-anthony.l.nguyen@intel.com.mbox.gz"
} |
lkml_critique | netdev | For idpf:
Li Li moves the check for software marker to occur after incrementing
next to clean to avoid re-encountering the same packet. He also adds a
couple of checks to prevent NULL pointer dereferences and NULLs rss_key,
after free, in error path so that later checks are properly evaluated.
Brian Vazquez adjusts IR... | null | null | null | [PATCH net v2 00/12][pull request] Intel Wired LAN Driver Updates 2026-02-19 (idpf, ice, i40e, ixgbevf, e1000e) | From: Li Li <boolli@google.com>
In idpf_txq_group_alloc(), if any txq group's txqs failed to
allocate memory:
for (j = 0; j < tx_qgrp->num_txq; j++) {
tx_qgrp->txqs[j] = kzalloc(sizeof(*tx_qgrp->txqs[j]),
GFP_KERNEL);
if (!tx_qgrp->txqs[j])
goto err_alloc;
}
It would cause a NULL ptr kernel panic in... | {
"author": "Tony Nguyen <anthony.l.nguyen@intel.com>",
"date": "Wed, 25 Feb 2026 13:15:34 -0800",
"is_openbsd": false,
"thread_id": "20260225211546.1949260-3-anthony.l.nguyen@intel.com.mbox.gz"
} |
lkml_critique | netdev | For idpf:
Li Li moves the check for software marker to occur after incrementing
next to clean to avoid re-encountering the same packet. He also adds a
couple of checks to prevent NULL pointer dereferences and NULLs rss_key,
after free, in error path so that later checks are properly evaluated.
Brian Vazquez adjusts IR... | null | null | null | [PATCH net v2 00/12][pull request] Intel Wired LAN Driver Updates 2026-02-19 (idpf, ice, i40e, ixgbevf, e1000e) | From: Li Li <boolli@google.com>
rss_data->rss_key needs to be nullified after it is freed.
Checks like "if (!rss_data->rss_key)" in the code could fail
if it is not nullified.
Tested: built and booted the kernel.
Fixes: 83f38f210b85 ("idpf: Fix RSS LUT NULL pointer crash on early ethtool operations")
Signed-off-by: ... | {
"author": "Tony Nguyen <anthony.l.nguyen@intel.com>",
"date": "Wed, 25 Feb 2026 13:15:35 -0800",
"is_openbsd": false,
"thread_id": "20260225211546.1949260-3-anthony.l.nguyen@intel.com.mbox.gz"
} |
lkml_critique | netdev | For idpf:
Li Li moves the check for software marker to occur after incrementing
next to clean to avoid re-encountering the same packet. He also adds a
couple of checks to prevent NULL pointer dereferences and NULLs rss_key,
after free, in error path so that later checks are properly evaluated.
Brian Vazquez adjusts IR... | null | null | null | [PATCH net v2 00/12][pull request] Intel Wired LAN Driver Updates 2026-02-19 (idpf, ice, i40e, ixgbevf, e1000e) | From: Brian Vazquez <brianvv@google.com>
The code uses the vidx for the IRQ name but that doesn't match ethtool
reporting nor netdev naming, this makes it hard to tune the device and
associate queues with IRQs. Sequentially requesting irqs starting from
'0' makes the output consistent.
This commit changes the interru... | {
"author": "Tony Nguyen <anthony.l.nguyen@intel.com>",
"date": "Wed, 25 Feb 2026 13:15:36 -0800",
"is_openbsd": false,
"thread_id": "20260225211546.1949260-3-anthony.l.nguyen@intel.com.mbox.gz"
} |
lkml_critique | netdev | For idpf:
Li Li moves the check for software marker to occur after incrementing
next to clean to avoid re-encountering the same packet. He also adds a
couple of checks to prevent NULL pointer dereferences and NULLs rss_key,
after free, in error path so that later checks are properly evaluated.
Brian Vazquez adjusts IR... | null | null | null | [PATCH net v2 00/12][pull request] Intel Wired LAN Driver Updates 2026-02-19 (idpf, ice, i40e, ixgbevf, e1000e) | From: Aaron Ma <aaron.ma@canonical.com>
Fix IRDMA hardware initialization timeout (-110) after resume by
separating VSI-dependent configuration from RDMA resource allocation,
ensuring VSI is rebuilt before IRDMA accesses it.
After resume from suspend, IRDMA hardware initialization fails:
ice: IRDMA hardware initial... | {
"author": "Tony Nguyen <anthony.l.nguyen@intel.com>",
"date": "Wed, 25 Feb 2026 13:15:38 -0800",
"is_openbsd": false,
"thread_id": "20260225211546.1949260-3-anthony.l.nguyen@intel.com.mbox.gz"
} |
lkml_critique | netdev | For idpf:
Li Li moves the check for software marker to occur after incrementing
next to clean to avoid re-encountering the same packet. He also adds a
couple of checks to prevent NULL pointer dereferences and NULLs rss_key,
after free, in error path so that later checks are properly evaluated.
Brian Vazquez adjusts IR... | null | null | null | [PATCH net v2 00/12][pull request] Intel Wired LAN Driver Updates 2026-02-19 (idpf, ice, i40e, ixgbevf, e1000e) | From: Michal Schmidt <mschmidt@redhat.com>
Since the conversion of ice to page pool, the ethtool loopback test
crashes:
BUG: kernel NULL pointer dereference, address: 000000000000000c
#PF: supervisor write access in kernel mode
#PF: error_code(0x0002) - not-present page
PGD 1100f1067 P4D 0
Oops: Oops: 0002 [#1] ... | {
"author": "Tony Nguyen <anthony.l.nguyen@intel.com>",
"date": "Wed, 25 Feb 2026 13:15:39 -0800",
"is_openbsd": false,
"thread_id": "20260225211546.1949260-3-anthony.l.nguyen@intel.com.mbox.gz"
} |
lkml_critique | netdev | For idpf:
Li Li moves the check for software marker to occur after incrementing
next to clean to avoid re-encountering the same packet. He also adds a
couple of checks to prevent NULL pointer dereferences and NULLs rss_key,
after free, in error path so that later checks are properly evaluated.
Brian Vazquez adjusts IR... | null | null | null | [PATCH net v2 00/12][pull request] Intel Wired LAN Driver Updates 2026-02-19 (idpf, ice, i40e, ixgbevf, e1000e) | From: Sreedevi Joshi <sreedevi.joshi@intel.com>
When deleting a flow rule using "ethtool -N <dev> delete <location>",
idpf_sideband_action_ena() incorrectly validates fsp->ring_cookie even
though ethtool doesn't populate this field for delete operations. The
uninitialized ring_cookie may randomly match RX_CLS_FLOW_DIS... | {
"author": "Tony Nguyen <anthony.l.nguyen@intel.com>",
"date": "Wed, 25 Feb 2026 13:15:37 -0800",
"is_openbsd": false,
"thread_id": "20260225211546.1949260-3-anthony.l.nguyen@intel.com.mbox.gz"
} |
lkml_critique | netdev | For idpf:
Li Li moves the check for software marker to occur after incrementing
next to clean to avoid re-encountering the same packet. He also adds a
couple of checks to prevent NULL pointer dereferences and NULLs rss_key,
after free, in error path so that later checks are properly evaluated.
Brian Vazquez adjusts IR... | null | null | null | [PATCH net v2 00/12][pull request] Intel Wired LAN Driver Updates 2026-02-19 (idpf, ice, i40e, ixgbevf, e1000e) | From: Thomas Gleixner <tglx@kernel.org>
Using get_cpu() in the tracepoint assignment causes an obvious preempt
count leak because nothing invokes put_cpu() to undo it:
softirq: huh, entered softirq 3 NET_RX with preempt_count 00000100, exited with 00000101?
This clearly has seen a lot of testing in the last 3+ yea... | {
"author": "Tony Nguyen <anthony.l.nguyen@intel.com>",
"date": "Wed, 25 Feb 2026 13:15:40 -0800",
"is_openbsd": false,
"thread_id": "20260225211546.1949260-3-anthony.l.nguyen@intel.com.mbox.gz"
} |
lkml_critique | netdev | For idpf:
Li Li moves the check for software marker to occur after incrementing
next to clean to avoid re-encountering the same packet. He also adds a
couple of checks to prevent NULL pointer dereferences and NULLs rss_key,
after free, in error path so that later checks are properly evaluated.
Brian Vazquez adjusts IR... | null | null | null | [PATCH net v2 00/12][pull request] Intel Wired LAN Driver Updates 2026-02-19 (idpf, ice, i40e, ixgbevf, e1000e) | From: Vitaly Lifshits <vitaly.lifshits@intel.com>
Add new board type for Panther Lake devices for separating device-specific
features and flows.
Additionally, remove the deprecated device IDs 0x57B5 and 0x57B6, which
are not used by any existing devices.
Signed-off-by: Vitaly Lifshits <vitaly.lifshits@intel.com>
Test... | {
"author": "Tony Nguyen <anthony.l.nguyen@intel.com>",
"date": "Wed, 25 Feb 2026 13:15:42 -0800",
"is_openbsd": false,
"thread_id": "20260225211546.1949260-3-anthony.l.nguyen@intel.com.mbox.gz"
} |
lkml_critique | netdev | For idpf:
Li Li moves the check for software marker to occur after incrementing
next to clean to avoid re-encountering the same packet. He also adds a
couple of checks to prevent NULL pointer dereferences and NULLs rss_key,
after free, in error path so that later checks are properly evaluated.
Brian Vazquez adjusts IR... | null | null | null | [PATCH net v2 00/12][pull request] Intel Wired LAN Driver Updates 2026-02-19 (idpf, ice, i40e, ixgbevf, e1000e) | From: Jedrzej Jagielski <jedrzej.jagielski@intel.com>
It may happen that VF spawned for E610 adapter has problem with setting
link up. This happens when ixgbevf supporting mailbox API 1.6 cooperates
with PF driver which doesn't support this version of API, and hence
doesn't support new approach for getting PF link dat... | {
"author": "Tony Nguyen <anthony.l.nguyen@intel.com>",
"date": "Wed, 25 Feb 2026 13:15:41 -0800",
"is_openbsd": false,
"thread_id": "20260225211546.1949260-3-anthony.l.nguyen@intel.com.mbox.gz"
} |
lkml_critique | netdev | For idpf:
Li Li moves the check for software marker to occur after incrementing
next to clean to avoid re-encountering the same packet. He also adds a
couple of checks to prevent NULL pointer dereferences and NULLs rss_key,
after free, in error path so that later checks are properly evaluated.
Brian Vazquez adjusts IR... | null | null | null | [PATCH net v2 00/12][pull request] Intel Wired LAN Driver Updates 2026-02-19 (idpf, ice, i40e, ixgbevf, e1000e) | From: Vitaly Lifshits <vitaly.lifshits@intel.com>
Panther Lake systems introduced an autonomous power gating feature for
the integrated Gigabit Ethernet in shutdown state (S5) state. As part of
it, the reset value of DPG_EN bit was changed to 1. Clear this bit after
performing hardware reset to avoid errors such as Tx... | {
"author": "Tony Nguyen <anthony.l.nguyen@intel.com>",
"date": "Wed, 25 Feb 2026 13:15:43 -0800",
"is_openbsd": false,
"thread_id": "20260225211546.1949260-3-anthony.l.nguyen@intel.com.mbox.gz"
} |
lkml_critique | netdev | For idpf:
Li Li moves the check for software marker to occur after incrementing
next to clean to avoid re-encountering the same packet. He also adds a
couple of checks to prevent NULL pointer dereferences and NULLs rss_key,
after free, in error path so that later checks are properly evaluated.
Brian Vazquez adjusts IR... | null | null | null | [PATCH net v2 00/12][pull request] Intel Wired LAN Driver Updates 2026-02-19 (idpf, ice, i40e, ixgbevf, e1000e) | This is an AI-generated review of your patch. The human sending this
email has considered the AI review valid, or at least plausible.
For local reproduction steps see https://netdev-ai.bots.linux.dev/ai-local.html
---
idpf: skip deallocating bufq_sets from rx_qgrp if it is NULL
This patch adds a NULL check for rx_qgr... | {
"author": "Jakub Kicinski <kuba@kernel.org>",
"date": "Thu, 26 Feb 2026 19:56:25 -0800",
"is_openbsd": false,
"thread_id": "20260225211546.1949260-3-anthony.l.nguyen@intel.com.mbox.gz"
} |
lkml_critique | netdev | struct sysctl_fib_multipath_hash_seed contains two u32 fields (user_seed
and mp_seed), making it an 8-byte structure with a 4-byte alignment requirement.
In fib_multipath_hash_from_keys(), the code evaluates the entire struct
atomically via READ_ONCE():
mp_seed = READ_ONCE(net->ipv4.sysctl_fib_multipath_hash_seed).mp... | null | null | null | [PATCH] net: ipv6: fix ARM64 alignment fault in fib_multipath_hash_from_keys() | On Thu, Feb 26, 2026 at 12:18 PM Yung Chih Su <yuuchihsu@gmail.com> wrote:
What about proc_fib_multipath_hash_set_seed() ?
It has :
WRITE_ONCE(net->ipv4.sysctl_fib_multipath_hash_seed, new);
Which is IMO strange, regardless of ARM64 clang and whats not. | {
"author": "Eric Dumazet <edumazet@google.com>",
"date": "Thu, 26 Feb 2026 13:02:31 +0100",
"is_openbsd": false,
"thread_id": "CAPAzCqE3k9PehK9gec7pcfq-Tnjsx-reD63GUaO+MEnP8LZ0Vg@mail.gmail.com.mbox.gz"
} |
lkml_critique | netdev | struct sysctl_fib_multipath_hash_seed contains two u32 fields (user_seed
and mp_seed), making it an 8-byte structure with a 4-byte alignment requirement.
In fib_multipath_hash_from_keys(), the code evaluates the entire struct
atomically via READ_ONCE():
mp_seed = READ_ONCE(net->ipv4.sysctl_fib_multipath_hash_seed).mp... | null | null | null | [PATCH] net: ipv6: fix ARM64 alignment fault in fib_multipath_hash_from_keys() | Eric Dumazet <edumazet@google.com> 於 2026年2月26日週四 下午8:02寫道：
Hi Eric,
Thank you for taking a look and catching this!
You are absolutely right. If READ_ONCE() on this 4-byte aligned struct
causes an unaligned load-acquire (ldar) fault on ARM64, the
WRITE_ONCE() in proc_fib_multipath_hash_set_seed() will inevitably
cau... | {
"author": "Sam Su <yuuchihsu@gmail.com>",
"date": "Thu, 26 Feb 2026 22:49:51 +0800",
"is_openbsd": false,
"thread_id": "CAPAzCqE3k9PehK9gec7pcfq-Tnjsx-reD63GUaO+MEnP8LZ0Vg@mail.gmail.com.mbox.gz"
} |
lkml_critique | netdev | struct sysctl_fib_multipath_hash_seed contains two u32 fields (user_seed
and mp_seed), making it an 8-byte structure with a 4-byte alignment requirement.
In fib_multipath_hash_from_keys(), the code evaluates the entire struct
atomically via READ_ONCE():
mp_seed = READ_ONCE(net->ipv4.sysctl_fib_multipath_hash_seed).mp... | null | null | null | [PATCH] net: ipv6: fix ARM64 alignment fault in fib_multipath_hash_from_keys() | On Thu, Feb 26, 2026 at 3:50 PM Sam Su <yuuchihsu@gmail.com> wrote:
SGTM, but please add this part as well:
diff --git a/net/ipv4/sysctl_net_ipv4.c b/net/ipv4/sysctl_net_ipv4.c
index 643763bc214279047c90b5b92a9ba9be6c24a443..1974b826bd9451fd9d8054e1db811760ff4b5a9f
100644
--- a/net/ipv4/sysctl_net_ipv4.c
+++ b/net/ipv... | {
"author": "Eric Dumazet <edumazet@google.com>",
"date": "Thu, 26 Feb 2026 16:00:31 +0100",
"is_openbsd": false,
"thread_id": "CAPAzCqE3k9PehK9gec7pcfq-Tnjsx-reD63GUaO+MEnP8LZ0Vg@mail.gmail.com.mbox.gz"
} |
lkml_critique | netdev | struct sysctl_fib_multipath_hash_seed contains two u32 fields (user_seed
and mp_seed), making it an 8-byte structure with a 4-byte alignment requirement.
In fib_multipath_hash_from_keys(), the code evaluates the entire struct
atomically via READ_ONCE():
mp_seed = READ_ONCE(net->ipv4.sysctl_fib_multipath_hash_seed).mp... | null | null | null | [PATCH] net: ipv6: fix ARM64 alignment fault in fib_multipath_hash_from_keys() | On Thu, 26 Feb 2026 19:17:21 +0800 Yung Chih Su wrote:
Please use the traditional abbreviated format of the Fixes tag | {
"author": "Jakub Kicinski <kuba@kernel.org>",
"date": "Thu, 26 Feb 2026 17:14:01 -0800",
"is_openbsd": false,
"thread_id": "CAPAzCqE3k9PehK9gec7pcfq-Tnjsx-reD63GUaO+MEnP8LZ0Vg@mail.gmail.com.mbox.gz"
} |
lkml_critique | netdev | struct sysctl_fib_multipath_hash_seed contains two u32 fields (user_seed
and mp_seed), making it an 8-byte structure with a 4-byte alignment requirement.
In fib_multipath_hash_from_keys(), the code evaluates the entire struct
atomically via READ_ONCE():
mp_seed = READ_ONCE(net->ipv4.sysctl_fib_multipath_hash_seed).mp... | null | null | null | [PATCH] net: ipv6: fix ARM64 alignment fault in fib_multipath_hash_from_keys() | Jakub Kicinski <kuba@kernel.org> 於 2026年2月27日週五 上午9:14寫道：
Hi Jakub,
Got it, my apologies for the formatting mistake.
I will format it strictly as 12-char abbreviated without brackets in
the upcoming v2 patch:
Fixes: 4ee2a8cace3f ("net: ipv4: Add a sysctl to set multipath hash seed")
I am currently preparing the v2 p... | {
"author": "Sam Su <yuuchihsu@gmail.com>",
"date": "Fri, 27 Feb 2026 15:12:58 +0800",
"is_openbsd": false,
"thread_id": "CAPAzCqE3k9PehK9gec7pcfq-Tnjsx-reD63GUaO+MEnP8LZ0Vg@mail.gmail.com.mbox.gz"
} |
lkml_critique | netdev | The GF stats periodic query is used as mechanism to monitor HWC health
check. If this HWC command times out, it is a strong indication that
the device/SoC is in a faulty state and requires recovery.
Today, when a timeout is detected, the driver marks
hwc_timeout_occurred, clears cached stats, and stops rescheduling th... | null | null | null | [PATCH, net-next] net: mana: Trigger VF reset/recovery on health
check failure due to HWC timeout | This is an AI-generated review of your patch. The human sending this
email has considered the AI review valid, or at least plausible.
For local reproduction steps see https://netdev-ai.bots.linux.dev/ai-local.html
---
net: mana: Trigger VF reset/recovery on health check failure due to HWC timeout
The GF stats periodi... | {
"author": "Simon Horman <horms@kernel.org>",
"date": "Tue, 24 Feb 2026 08:26:41 +0000",
"is_openbsd": false,
"thread_id": "aaFRbSrKFkZXAfIT@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net.mbox.gz"
} |
lkml_critique | netdev | The GF stats periodic query is used as mechanism to monitor HWC health
check. If this HWC command times out, it is a strong indication that
the device/SoC is in a faulty state and requires recovery.
Today, when a timeout is detected, the driver marks
hwc_timeout_occurred, clears cached stats, and stops rescheduling th... | null | null | null | [PATCH, net-next] net: mana: Trigger VF reset/recovery on health
check failure due to HWC timeout | On Tue, Feb 24, 2026 at 08:26:41AM +0000, Simon Horman wrote:
ACK.
ACK.
ACK.
Thanks Simon, I am addressing these in v2.
Regards | {
"author": "Dipayaan Roy <dipayanroy@linux.microsoft.com>",
"date": "Fri, 27 Feb 2026 00:07:00 -0800",
"is_openbsd": false,
"thread_id": "aaFRbSrKFkZXAfIT@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net.mbox.gz"
} |
lkml_critique | netdev | The GF stats periodic query is used as mechanism to monitor HWC health
check. If this HWC command times out, it is a strong indication that
the device/SoC is in a faulty state and requires recovery.
Today, when a timeout is detected, the driver marks
hwc_timeout_occurred, clears cached stats, and stops rescheduling th... | null | null | null | [PATCH, net-next] net: mana: Trigger VF reset/recovery on health
check failure due to HWC timeout | On Thu, Feb 26, 2026 at 07:48:31PM +0000, Long Li wrote:
yes it makes sense to clear it here.
Regards | {
"author": "Dipayaan Roy <dipayanroy@linux.microsoft.com>",
"date": "Fri, 27 Feb 2026 00:10:21 -0800",
"is_openbsd": false,
"thread_id": "aaFRbSrKFkZXAfIT@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net.mbox.gz"
} |
lkml_critique | netdev | skmsg (and probably other layers) are changing these pointers
while other cpus might read them concurrently.
Add corresponding READ_ONCE()/WRITE_ONCE() annotations
for UDP, TCP and AF_UNIX.
Fixes: 604326b41a6f ("bpf, sockmap: convert to generic sk_msg interface")
Reported-by: syzbot+87f770387a9e5dc6b79b@syzkaller.app... | null | null | null | [PATCH net] net: annotate data-races around sk->sk_{data_ready,write_space} | On Wed, Feb 25, 2026 at 5:15 AM Eric Dumazet <edumazet@google.com> wrote:
Reviewed-by: Kuniyuki Iwashima <kuniyu@google.com> | {
"author": "Kuniyuki Iwashima <kuniyu@google.com>",
"date": "Thu, 26 Feb 2026 14:13:44 -0800",
"is_openbsd": false,
"thread_id": "177216361129.1960351.7747994191402885743.git-patchwork-notify@kernel.org.mbox.gz"
} |
lkml_critique | netdev | skmsg (and probably other layers) are changing these pointers
while other cpus might read them concurrently.
Add corresponding READ_ONCE()/WRITE_ONCE() annotations
for UDP, TCP and AF_UNIX.
Fixes: 604326b41a6f ("bpf, sockmap: convert to generic sk_msg interface")
Reported-by: syzbot+87f770387a9e5dc6b79b@syzkaller.app... | null | null | null | [PATCH net] net: annotate data-races around sk->sk_{data_ready,write_space} | Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Wed, 25 Feb 2026 13:15:47 +0000 you wrote:
Here is the summary with links:
- [net] net: annotate data-races around sk->sk_{data_ready,write_space}
https://git.kernel.org/netdev/net/c/2ef2b20cf4e0
You are awesome, th... | {
"author": "patchwork-bot+netdevbpf@kernel.org",
"date": "Fri, 27 Feb 2026 03:40:11 +0000",
"is_openbsd": false,
"thread_id": "177216361129.1960351.7747994191402885743.git-patchwork-notify@kernel.org.mbox.gz"
} |
lkml_critique | netdev | From: Zhi Li <lizhi2@eswincomputing.com>
v1 -> v2:
- Update eswin,eic7700-eth.yaml:
- Drop the vendor-specific properties eswin,rx-clk-invert and
eswin,tx-clk-invert.
- Introduce a distinct compatible string
"eswin,eic7700-qos-eth-clk-inversion" to describe MAC instances that
require intern... | null | null | null | [PATCH v2 0/2] net: stmmac: eic7700: fix EIC7700 eth1 RX sampling timing | From: Zhi Li <lizhi2@eswincomputing.com>
The second Ethernet controller (eth1) on the EIC7700 SoC may experience
RX data sampling issues at high speed due to EIC7700-specific receive
clock to data skew at the MAC input.
On the EIC7700 SoC, the second Ethernet controller (eth1) requires
inversion of the internal RGMII... | {
"author": "lizhi2@eswincomputing.com",
"date": "Mon, 9 Feb 2026 17:48:01 +0800",
"is_openbsd": false,
"thread_id": "5f99968ec561631852bfa72aea95a100dcad5324.camel@ziswiler.com.mbox.gz"
} |
lkml_critique | netdev | From: Zhi Li <lizhi2@eswincomputing.com>
v1 -> v2:
- Update eswin,eic7700-eth.yaml:
- Drop the vendor-specific properties eswin,rx-clk-invert and
eswin,tx-clk-invert.
- Introduce a distinct compatible string
"eswin,eic7700-qos-eth-clk-inversion" to describe MAC instances that
require intern... | null | null | null | [PATCH v2 0/2] net: stmmac: eic7700: fix EIC7700 eth1 RX sampling timing | From: Zhi Li <lizhi2@eswincomputing.com>
The second Ethernet controller (eth1) on the Eswin EIC7700 SoC may fail
to sample RX data correctly at Gigabit speed due to EIC7700-specific
receive clock to data skew at the MAC input in the silicon.
The existing internal delay configuration does not provide sufficient
adjust... | {
"author": "lizhi2@eswincomputing.com",
"date": "Mon, 9 Feb 2026 17:48:29 +0800",
"is_openbsd": false,
"thread_id": "5f99968ec561631852bfa72aea95a100dcad5324.camel@ziswiler.com.mbox.gz"
} |
lkml_critique | netdev | From: Zhi Li <lizhi2@eswincomputing.com>
v1 -> v2:
- Update eswin,eic7700-eth.yaml:
- Drop the vendor-specific properties eswin,rx-clk-invert and
eswin,tx-clk-invert.
- Introduce a distinct compatible string
"eswin,eic7700-qos-eth-clk-inversion" to describe MAC instances that
require intern... | null | null | null | [PATCH v2 0/2] net: stmmac: eic7700: fix EIC7700 eth1 RX sampling timing | multipleOf: 20
Also, 2400 / 20 = 120. Is the real maximum 127 * 20 = 2540?
I would not include them in the example. You are going to get
developers blindly copying this into real DT. A well designed board
should not need delays.
Andrew | {
"author": "Andrew Lunn <andrew@lunn.ch>",
"date": "Mon, 9 Feb 2026 14:21:33 +0100",
"is_openbsd": false,
"thread_id": "5f99968ec561631852bfa72aea95a100dcad5324.camel@ziswiler.com.mbox.gz"
} |
lkml_critique | netdev | From: Zhi Li <lizhi2@eswincomputing.com>
v1 -> v2:
- Update eswin,eic7700-eth.yaml:
- Drop the vendor-specific properties eswin,rx-clk-invert and
eswin,tx-clk-invert.
- Introduce a distinct compatible string
"eswin,eic7700-qos-eth-clk-inversion" to describe MAC instances that
require intern... | null | null | null | [PATCH v2 0/2] net: stmmac: eic7700: fix EIC7700 eth1 RX sampling timing | No point initialising ret if the first thing you do is assign to it.
regmap_set_bits(dwc->eic7700_hsp_regmap, dwc->eth_phy_ctrl_offset,
EIC7700_ETH_TX_CLK_SEL | EIC7700_ETH_PHY_INTF_SELI);
returning ret here seems pointless. You already know it is 0.
If the value it too big, please return -EINVAL. You have lis... | {
"author": "Andrew Lunn <andrew@lunn.ch>",
"date": "Mon, 9 Feb 2026 14:34:31 +0100",
"is_openbsd": false,
"thread_id": "5f99968ec561631852bfa72aea95a100dcad5324.camel@ziswiler.com.mbox.gz"
} |
lkml_critique | netdev | From: Zhi Li <lizhi2@eswincomputing.com>
v1 -> v2:
- Update eswin,eic7700-eth.yaml:
- Drop the vendor-specific properties eswin,rx-clk-invert and
eswin,tx-clk-invert.
- Introduce a distinct compatible string
"eswin,eic7700-qos-eth-clk-inversion" to describe MAC instances that
require intern... | null | null | null | [PATCH v2 0/2] net: stmmac: eic7700: fix EIC7700 eth1 RX sampling timing | On Mon, Feb 09, 2026 at 05:46:28PM +0800, lizhi2@eswincomputing.com wrote:
For version 3, please include a patch to the SoC .dtsi file adding the
Ethernet nodes. We like to see users of code being added.
Andrew | {
"author": "Andrew Lunn <andrew@lunn.ch>",
"date": "Mon, 9 Feb 2026 14:36:11 +0100",
"is_openbsd": false,
"thread_id": "5f99968ec561631852bfa72aea95a100dcad5324.camel@ziswiler.com.mbox.gz"
} |
lkml_critique | netdev | From: Zhi Li <lizhi2@eswincomputing.com>
v1 -> v2:
- Update eswin,eic7700-eth.yaml:
- Drop the vendor-specific properties eswin,rx-clk-invert and
eswin,tx-clk-invert.
- Introduce a distinct compatible string
"eswin,eic7700-qos-eth-clk-inversion" to describe MAC instances that
require intern... | null | null | null | [PATCH v2 0/2] net: stmmac: eic7700: fix EIC7700 eth1 RX sampling timing | On Mon, Feb 09, 2026 at 02:36:11PM +0100, Andrew Lunn wrote:
In addition to Andrew's comments, before posting another series, please
review https://docs.kernel.org/process/maintainer-netdev.html,
particularly sections 1.4 and 1.6.1.
Thanks.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP ... | {
"author": "\"Russell King (Oracle)\" <linux@armlinux.org.uk>",
"date": "Mon, 9 Feb 2026 14:31:28 +0000",
"is_openbsd": false,
"thread_id": "5f99968ec561631852bfa72aea95a100dcad5324.camel@ziswiler.com.mbox.gz"
} |
lkml_critique | netdev | From: Zhi Li <lizhi2@eswincomputing.com>
v1 -> v2:
- Update eswin,eic7700-eth.yaml:
- Drop the vendor-specific properties eswin,rx-clk-invert and
eswin,tx-clk-invert.
- Introduce a distinct compatible string
"eswin,eic7700-qos-eth-clk-inversion" to describe MAC instances that
require intern... | null | null | null | [PATCH v2 0/2] net: stmmac: eic7700: fix EIC7700 eth1 RX sampling timing | Thanks for the comments.
The v3 patch will target the net git tree.
We will add the ethernet nodes and the corresponding clock node to
eic7700.dtsi and eic7700-hifive-premier-p550.dts in v3 patch.
Please note that the EIC7700 clock controller binding and driver are not
yet merged upstream, so the clock nodes will n... | {
"author": "=?UTF-8?B?5p2O5b+X?= <lizhi2@eswincomputing.com>",
"date": "Tue, 10 Feb 2026 18:21:40 +0800 (GMT+08:00)",
"is_openbsd": false,
"thread_id": "5f99968ec561631852bfa72aea95a100dcad5324.camel@ziswiler.com.mbox.gz"
} |
lkml_critique | netdev | From: Zhi Li <lizhi2@eswincomputing.com>
v1 -> v2:
- Update eswin,eic7700-eth.yaml:
- Drop the vendor-specific properties eswin,rx-clk-invert and
eswin,tx-clk-invert.
- Introduce a distinct compatible string
"eswin,eic7700-qos-eth-clk-inversion" to describe MAC instances that
require intern... | null | null | null | [PATCH v2 0/2] net: stmmac: eic7700: fix EIC7700 eth1 RX sampling timing | Hi,
On Tue, Feb 10, 2026 at 06:21:40PM +0800, 李志 wrote:
While it may be a fix, given that:
I don't see much point to putting it in the net tree - you're addressing
problems with a driver that is currently not in a usable state in
mainline, so there's no need to rush to have this change in mainline.
I think the net-... | {
"author": "\"Russell King (Oracle)\" <linux@armlinux.org.uk>",
"date": "Tue, 10 Feb 2026 12:30:30 +0000",
"is_openbsd": false,
"thread_id": "5f99968ec561631852bfa72aea95a100dcad5324.camel@ziswiler.com.mbox.gz"
} |
lkml_critique | netdev | From: Zhi Li <lizhi2@eswincomputing.com>
v1 -> v2:
- Update eswin,eic7700-eth.yaml:
- Drop the vendor-specific properties eswin,rx-clk-invert and
eswin,tx-clk-invert.
- Introduce a distinct compatible string
"eswin,eic7700-qos-eth-clk-inversion" to describe MAC instances that
require intern... | null | null | null | [PATCH v2 0/2] net: stmmac: eic7700: fix EIC7700 eth1 RX sampling timing | Hi Zhi Li
Sorry, to steal this thread, but I do have a quick question concerning Ethernet on the EIC7700. Every time I
enable gmac0 in the device tree my EBC7700 stops booting (e.g. SD card is no longer detected) while Ethernet
does seem to at least get detected. This has been seen using next-20260219, stable v6.19.2 ... | {
"author": "Marcel Ziswiler <marcel@ziswiler.com>",
"date": "Fri, 20 Feb 2026 19:37:57 +0100",
"is_openbsd": false,
"thread_id": "5f99968ec561631852bfa72aea95a100dcad5324.camel@ziswiler.com.mbox.gz"
} |
lkml_critique | netdev | From: Zhi Li <lizhi2@eswincomputing.com>
v1 -> v2:
- Update eswin,eic7700-eth.yaml:
- Drop the vendor-specific properties eswin,rx-clk-invert and
eswin,tx-clk-invert.
- Introduce a distinct compatible string
"eswin,eic7700-qos-eth-clk-inversion" to describe MAC instances that
require intern... | null | null | null | [PATCH v2 0/2] net: stmmac: eic7700: fix EIC7700 eth1 RX sampling timing | Hi Marcel,
Thanks for sharing the details.
1. I checked your log and noticed that the kernel cmdline already includes
"clk_ignore_unused". Therefore, your issue does not appear to be the
same as the one previously reported by Bo Gan.
2. I also verified that v6.19.2 already contains the two eMMC fix patches:
... | {
"author": "=?UTF-8?B?5p2O5b+X?= <lizhi2@eswincomputing.com>",
"date": "Thu, 26 Feb 2026 11:20:02 +0800 (GMT+08:00)",
"is_openbsd": false,
"thread_id": "5f99968ec561631852bfa72aea95a100dcad5324.camel@ziswiler.com.mbox.gz"
} |
lkml_critique | netdev | From: Zhi Li <lizhi2@eswincomputing.com>
v1 -> v2:
- Update eswin,eic7700-eth.yaml:
- Drop the vendor-specific properties eswin,rx-clk-invert and
eswin,tx-clk-invert.
- Introduce a distinct compatible string
"eswin,eic7700-qos-eth-clk-inversion" to describe MAC instances that
require intern... | null | null | null | [PATCH v2 0/2] net: stmmac: eic7700: fix EIC7700 eth1 RX sampling timing | Hi Zhi Li
On Thu, 2026-02-26 at 11:20 +0800, 李志 wrote:
Yes, that actually came from ESWIN's hifive-premier-p550_defconfig which I disabled now.
Yes.
Ah, that one helped (;-p).
BTW: For CPU frequency scaling to actually work one may additionally need CONFIG_RISCV_SBI_CPUIDLE=y.
Yes, I also changed that from =m ... | {
"author": "Marcel Ziswiler <marcel@ziswiler.com>",
"date": "Fri, 27 Feb 2026 10:52:55 +0100",
"is_openbsd": false,
"thread_id": "5f99968ec561631852bfa72aea95a100dcad5324.camel@ziswiler.com.mbox.gz"
} |
lkml_critique | netdev | The current SMC-R implementation relies on global per-device CQs
and manual polling within tasklets, which introduces severe
scalability bottlenecks due to global lock contention and tasklet
scheduling overhead, resulting in poor performance as concurrency
increases.
Refactor the completion handling to utilize the ib_... | null | null | null | [PATCH net-next] net/smc: transition to RDMA core CQ pooling | This is an AI-generated review of your patch. The human sending this
email has considered the AI review valid, or at least plausible.
For local reproduction steps see https://netdev-ai.bots.linux.dev/ai-local.html
---
net/smc: transition to RDMA core CQ pooling
This commit refactors SMC-R completion handling to use t... | {
"author": "Jakub Kicinski <kuba@kernel.org>",
"date": "Thu, 26 Feb 2026 19:53:00 -0800",
"is_openbsd": false,
"thread_id": "20260225024513.7861-1-alibuda@linux.alibaba.com.mbox.gz"
} |
lkml_critique | netdev | The current SMC-R implementation relies on global per-device CQs
and manual polling within tasklets, which introduces severe
scalability bottlenecks due to global lock contention and tasklet
scheduling overhead, resulting in poor performance as concurrency
increases.
Refactor the completion handling to utilize the ib_... | null | null | null | [PATCH net-next] net/smc: transition to RDMA core CQ pooling | On Thu, Feb 26, 2026 at 07:53:00PM -0800, Jakub Kicinski wrote:
Nice catch! It should indeed be pnd_snd.compl_requested here since tx_pend has been zeroed.
Will fix in v2.
Will fix in v2. Thanks.
D. Wythe | {
"author": "\"D. Wythe\" <alibuda@linux.alibaba.com >",
"date": "Fri, 27 Feb 2026 17:33:54 +0800",
"is_openbsd": false,
"thread_id": "20260225024513.7861-1-alibuda@linux.alibaba.com.mbox.gz"
} |
lkml_critique | netdev | Introduce bpf_xdp_metadata_rx_checksum() kfunc in order to load the HW
RX cheksum results in the eBPF program binded to the NIC.
Implement xmo_rx_checksum callback for veth and ice drivers.
If the hardware detects a wrong/failed checksum, it will report
CHECKSUM_NONE in the packet metadata. Moreover, CHECKSUM_NONE wil... | null | null | null | [PATCH bpf-next v3 0/5] Add the the capability to load HW RX
checsum in eBPF programs | Introduce XDP RX checksum capability to XDP metadata specs. XDP RX
checksum will be use by devices capable of exposing receive checksum
result via bpf_xdp_metadata_rx_checksum().
Moreover, introduce xmo_rx_checksum netdev callback in order to allow
the eBPF program bound to the device to retrieve the RX checksum result... | {
"author": "Lorenzo Bianconi <lorenzo@kernel.org>",
"date": "Tue, 17 Feb 2026 09:33:56 +0100",
"is_openbsd": false,
"thread_id": "aaGaaExy63bGa7Or@lore-desk.mbox.gz"
} |
lkml_critique | netdev | Introduce bpf_xdp_metadata_rx_checksum() kfunc in order to load the HW
RX cheksum results in the eBPF program binded to the NIC.
Implement xmo_rx_checksum callback for veth and ice drivers.
If the hardware detects a wrong/failed checksum, it will report
CHECKSUM_NONE in the packet metadata. Moreover, CHECKSUM_NONE wil... | null | null | null | [PATCH bpf-next v3 0/5] Add the the capability to load HW RX
checsum in eBPF programs | Implement xmo_rx_checksum callback in veth driver to report RX checksum
result to the eBPF program bounded to the veth device.
Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
---
drivers/net/veth.c | 29 +++++++++++++++++++++++++++++
1 file changed, 29 insertions(+)
diff --git a/drivers/net/veth.c b/drivers/net... | {
"author": "Lorenzo Bianconi <lorenzo@kernel.org>",
"date": "Tue, 17 Feb 2026 09:33:57 +0100",
"is_openbsd": false,
"thread_id": "aaGaaExy63bGa7Or@lore-desk.mbox.gz"
} |
lkml_critique | netdev | Introduce bpf_xdp_metadata_rx_checksum() kfunc in order to load the HW
RX cheksum results in the eBPF program binded to the NIC.
Implement xmo_rx_checksum callback for veth and ice drivers.
If the hardware detects a wrong/failed checksum, it will report
CHECKSUM_NONE in the packet metadata. Moreover, CHECKSUM_NONE wil... | null | null | null | [PATCH bpf-next v3 0/5] Add the the capability to load HW RX
checsum in eBPF programs | Implement xmo_rx_checksum callback in ice driver to report RX checksum
result to the eBPF program bounded to the NIC.
Introduce ice_get_rx_csum utility routine in order to make the rx checksum
code reusable from ice_rx_csum()
Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
---
drivers/net/ethernet/intel/ice/ice_... | {
"author": "Lorenzo Bianconi <lorenzo@kernel.org>",
"date": "Tue, 17 Feb 2026 09:33:58 +0100",
"is_openbsd": false,
"thread_id": "aaGaaExy63bGa7Or@lore-desk.mbox.gz"
} |
lkml_critique | netdev | Introduce bpf_xdp_metadata_rx_checksum() kfunc in order to load the HW
RX cheksum results in the eBPF program binded to the NIC.
Implement xmo_rx_checksum callback for veth and ice drivers.
If the hardware detects a wrong/failed checksum, it will report
CHECKSUM_NONE in the packet metadata. Moreover, CHECKSUM_NONE wil... | null | null | null | [PATCH bpf-next v3 0/5] Add the the capability to load HW RX
checsum in eBPF programs | Introduce support to xdp_metadata selftest for bpf_xdp_metadata_rx_checksum
kfunc.
Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
---
tools/testing/selftests/bpf/prog_tests/xdp_metadata.c | 6 ++++++
tools/testing/selftests/bpf/progs/xdp_metadata.... | {
"author": "Lorenzo Bianconi <lorenzo@kernel.org>",
"date": "Tue, 17 Feb 2026 09:33:59 +0100",
"is_openbsd": false,
"thread_id": "aaGaaExy63bGa7Or@lore-desk.mbox.gz"
} |
lkml_critique | netdev | Introduce bpf_xdp_metadata_rx_checksum() kfunc in order to load the HW
RX cheksum results in the eBPF program binded to the NIC.
Implement xmo_rx_checksum callback for veth and ice drivers.
If the hardware detects a wrong/failed checksum, it will report
CHECKSUM_NONE in the packet metadata. Moreover, CHECKSUM_NONE wil... | null | null | null | [PATCH bpf-next v3 0/5] Add the the capability to load HW RX
checsum in eBPF programs | Introduce the capability to dump HW rx checksum in xdp_hw_metadata
program via bpf_xdp_metadata_rx_checksum() kfunc.
Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
---
.../testing/selftests/bpf/progs/xdp_hw_metadata.c | 8 +++++++
tools/testing/selftests/bpf/xdp_hw_metadata.c | 25 ++++++++++++++++++++++
... | {
"author": "Lorenzo Bianconi <lorenzo@kernel.org>",
"date": "Tue, 17 Feb 2026 09:34:00 +0100",
"is_openbsd": false,
"thread_id": "aaGaaExy63bGa7Or@lore-desk.mbox.gz"
} |
lkml_critique | netdev | Introduce bpf_xdp_metadata_rx_checksum() kfunc in order to load the HW
RX cheksum results in the eBPF program binded to the NIC.
Implement xmo_rx_checksum callback for veth and ice drivers.
If the hardware detects a wrong/failed checksum, it will report
CHECKSUM_NONE in the packet metadata. Moreover, CHECKSUM_NONE wil... | null | null | null | [PATCH bpf-next v3 0/5] Add the the capability to load HW RX
checsum in eBPF programs | [ ... ]
The ip_summed field is __u8 (1 byte), but bpf_xdp_metadata_rx_checksum()
takes an enum xdp_checksum * argument, which is 4 bytes.
In the BPF program:
[ ... ]
The cast here passes a pointer to a 1-byte field where the kfunc will
perform a 4-byte store. On little-endian this happens to work because
the va... | {
"author": "bot+bpf-ci@kernel.org",
"date": "Tue, 17 Feb 2026 09:17:48 +0000 (UTC)",
"is_openbsd": false,
"thread_id": "aaGaaExy63bGa7Or@lore-desk.mbox.gz"
} |
lkml_critique | netdev | Introduce bpf_xdp_metadata_rx_checksum() kfunc in order to load the HW
RX cheksum results in the eBPF program binded to the NIC.
Implement xmo_rx_checksum callback for veth and ice drivers.
If the hardware detects a wrong/failed checksum, it will report
CHECKSUM_NONE in the packet metadata. Moreover, CHECKSUM_NONE wil... | null | null | null | [PATCH bpf-next v3 0/5] Add the the capability to load HW RX
checsum in eBPF programs | On 02/17, Lorenzo Bianconi wrote:
The only thing I'm still not sure about is the csum_level and whether
we need to export it or just start with csum_level=0 and extend later
when needed. The rest looks good.
Jesper, Lorenzo mentioned that you might need it? Can you clarify? | {
"author": "Stanislav Fomichev <stfomichev@gmail.com>",
"date": "Tue, 17 Feb 2026 17:01:07 -0800",
"is_openbsd": false,
"thread_id": "aaGaaExy63bGa7Or@lore-desk.mbox.gz"
} |
lkml_critique | netdev | Introduce bpf_xdp_metadata_rx_checksum() kfunc in order to load the HW
RX cheksum results in the eBPF program binded to the NIC.
Implement xmo_rx_checksum callback for veth and ice drivers.
If the hardware detects a wrong/failed checksum, it will report
CHECKSUM_NONE in the packet metadata. Moreover, CHECKSUM_NONE wil... | null | null | null | [PATCH bpf-next v3 0/5] Add the the capability to load HW RX
checsum in eBPF programs | On 18/02/2026 02.01, Stanislav Fomichev wrote:
At Cloudflare our load-balancer Unimog[1] does GUE (Generic UDP
Encapsulation) when XDP_TX'ing packets to neighboring servers.
Thus, I assume we want to know the csum_level, as this is for
encapsulated packets, right?
Cc Jesse, as he knows more about the hardware and csu... | {
"author": "Jesper Dangaard Brouer <hawk@kernel.org>",
"date": "Wed, 18 Feb 2026 11:58:52 +0100",
"is_openbsd": false,
"thread_id": "aaGaaExy63bGa7Or@lore-desk.mbox.gz"
} |
lkml_critique | netdev | Introduce bpf_xdp_metadata_rx_checksum() kfunc in order to load the HW
RX cheksum results in the eBPF program binded to the NIC.
Implement xmo_rx_checksum callback for veth and ice drivers.
If the hardware detects a wrong/failed checksum, it will report
CHECKSUM_NONE in the packet metadata. Moreover, CHECKSUM_NONE wil... | null | null | null | [PATCH bpf-next v3 0/5] Add the the capability to load HW RX
checsum in eBPF programs | On Tue, 17 Feb 2026 09:33:56 +0100 Lorenzo Bianconi wrote:
It's fairly common for NICs to report both csum complete and
unnecessary. Which one should the driver return in that case?
What if the user prefers the other one?.. | {
"author": "Jakub Kicinski <kuba@kernel.org>",
"date": "Wed, 18 Feb 2026 17:47:42 -0800",
"is_openbsd": false,
"thread_id": "aaGaaExy63bGa7Or@lore-desk.mbox.gz"
} |
lkml_critique | netdev | Introduce bpf_xdp_metadata_rx_checksum() kfunc in order to load the HW
RX cheksum results in the eBPF program binded to the NIC.
Implement xmo_rx_checksum callback for veth and ice drivers.
If the hardware detects a wrong/failed checksum, it will report
CHECKSUM_NONE in the packet metadata. Moreover, CHECKSUM_NONE wil... | null | null | null | [PATCH bpf-next v3 0/5] Add the the capability to load HW RX
checsum in eBPF programs | Do you mean what is value for cksum_meta if we do not report csum_level for
XDP_CHECKSUM_UNNECESSARY/CHECKSUM_UNNECESSARY use-case? (as suggested by
Stanislav).
My original idea is:
- if the hw reports CHECKSUM_COMPLETE:
- ip_summed = XDP_CHECKSUM_COMPLETE
- cksum_meta contains the checksum computed by the hw
- if... | {
"author": "Lorenzo Bianconi <lorenzo@kernel.org>",
"date": "Thu, 19 Feb 2026 12:04:56 +0100",
"is_openbsd": false,
"thread_id": "aaGaaExy63bGa7Or@lore-desk.mbox.gz"
} |
lkml_critique | netdev | Introduce bpf_xdp_metadata_rx_checksum() kfunc in order to load the HW
RX cheksum results in the eBPF program binded to the NIC.
Implement xmo_rx_checksum callback for veth and ice drivers.
If the hardware detects a wrong/failed checksum, it will report
CHECKSUM_NONE in the packet metadata. Moreover, CHECKSUM_NONE wil... | null | null | null | [PATCH bpf-next v3 0/5] Add the the capability to load HW RX
checsum in eBPF programs | On Thu, 19 Feb 2026 12:04:56 +0100 Lorenzo Bianconi wrote:
More fundamentally whether the API is right.
Off the top of my head drivers prefer reporting UNNECESSARY when they
have both, and reserve COMPLETE for cases where L4 could not be found
or is incorrect. Why don't we report both? We're using 3 args, we still
h... | {
"author": "Jakub Kicinski <kuba@kernel.org>",
"date": "Thu, 19 Feb 2026 09:13:44 -0800",
"is_openbsd": false,
"thread_id": "aaGaaExy63bGa7Or@lore-desk.mbox.gz"
} |
lkml_critique | netdev | Introduce bpf_xdp_metadata_rx_checksum() kfunc in order to load the HW
RX cheksum results in the eBPF program binded to the NIC.
Implement xmo_rx_checksum callback for veth and ice drivers.
If the hardware detects a wrong/failed checksum, it will report
CHECKSUM_NONE in the packet metadata. Moreover, CHECKSUM_NONE wil... | null | null | null | [PATCH bpf-next v3 0/5] Add the the capability to load HW RX
checsum in eBPF programs | Ack, thx for the explanation. Just for sake of understanding, is there
any NIC capable of reporting both csum_value and csum for the same packet
in the DMA descriptor? Or is this change needed to be future-proof?
At the moment there is no way to store the csum value we got running
bpf_xdp_metadata_rx_checksum() in or... | {
"author": "Lorenzo Bianconi <lorenzo@kernel.org>",
"date": "Mon, 23 Feb 2026 18:11:54 +0100",
"is_openbsd": false,
"thread_id": "aaGaaExy63bGa7Or@lore-desk.mbox.gz"
} |
lkml_critique | netdev | Introduce bpf_xdp_metadata_rx_checksum() kfunc in order to load the HW
RX cheksum results in the eBPF program binded to the NIC.
Implement xmo_rx_checksum callback for veth and ice drivers.
If the hardware detects a wrong/failed checksum, it will report
CHECKSUM_NONE in the packet metadata. Moreover, CHECKSUM_NONE wil... | null | null | null | [PATCH bpf-next v3 0/5] Add the the capability to load HW RX
checsum in eBPF programs | On Mon, 23 Feb 2026 18:11:54 +0100 Lorenzo Bianconi wrote:
Both nfp and fbnic definitely can. Off the top of my head - mlx5 also
can, but I haven't double checked.
I think the scope here is much narrower than the xdp_buf to xdp_frame
to skb conversion. We are just pass information between the program and
driver whic... | {
"author": "Jakub Kicinski <kuba@kernel.org>",
"date": "Mon, 23 Feb 2026 15:18:45 -0800",
"is_openbsd": false,
"thread_id": "aaGaaExy63bGa7Or@lore-desk.mbox.gz"
} |
lkml_critique | netdev | Introduce bpf_xdp_metadata_rx_checksum() kfunc in order to load the HW
RX cheksum results in the eBPF program binded to the NIC.
Implement xmo_rx_checksum callback for veth and ice drivers.
If the hardware detects a wrong/failed checksum, it will report
CHECKSUM_NONE in the packet metadata. Moreover, CHECKSUM_NONE wil... | null | null | null | [PATCH bpf-next v3 0/5] Add the the capability to load HW RX
checsum in eBPF programs | ack, thx for pointing this out, I was not aware of it. I will modify the APIs
in order to add the capability to report both cksum and csum_level for a given
packet.
IIUC, for the CSUM_COMPLETE case, we want to add a kfunc used to update (or
invalidate) the checksum value (if the packet has been modified by the eBPF
p... | {
"author": "Lorenzo Bianconi <lorenzo@kernel.org>",
"date": "Fri, 27 Feb 2026 14:21:44 +0100",
"is_openbsd": false,
"thread_id": "aaGaaExy63bGa7Or@lore-desk.mbox.gz"
} |
lkml_critique | netdev | The NETC IP has one external master MDIO interface (eMDIO) for managing
external PHYs, all ENETC ports share this eMDIO. The EMDIO function and
the ENETC port MDIO are the virtual ports of this eMDIO, ENETC can use
these virtual ports to access their PHYs. The difference is that EMDIO
function is a 'global port', it ca... | null | null | null | [PATCH v3 net-next 0/3] net: enetc: add port MDIO support for both i.MX94 and i.MX95 | The ENETC supports managing its own external PHY through its port MDIO
functionality. To use this function, the PHY address needs be set in the
corresponding LaBCR register in the Integrated Endpoint Register Block
(IERB), which is used for pre-boot initialization of NETC PCIe functions.
The port MDIO can only work pro... | {
"author": "Wei Fang <wei.fang@nxp.com>",
"date": "Wed, 19 Nov 2025 18:25:55 +0800",
"is_openbsd": false,
"thread_id": "20251119102557.1041881-1-wei.fang@nxp.com.mbox.gz"
} |
lkml_critique | netdev | The NETC IP has one external master MDIO interface (eMDIO) for managing
external PHYs, all ENETC ports share this eMDIO. The EMDIO function and
the ENETC port MDIO are the virtual ports of this eMDIO, ENETC can use
these virtual ports to access their PHYs. The difference is that EMDIO
function is a 'global port', it ca... | null | null | null | [PATCH v3 net-next 0/3] net: enetc: add port MDIO support for both i.MX94 and i.MX95 | NETC IP has only one external master MDIO interface (eMDIO) for managing
the external PHYs. ENETC can use the interfaces provided by the EMDIO
function or its port MDIO to access and manage its external PHY. Both
the EMDIO function and the port MDIO are all virtual ports of the eMDIO.
The difference is that the EMDIO ... | {
"author": "Wei Fang <wei.fang@nxp.com>",
"date": "Wed, 19 Nov 2025 18:25:56 +0800",
"is_openbsd": false,
"thread_id": "20251119102557.1041881-1-wei.fang@nxp.com.mbox.gz"
} |
lkml_critique | netdev | The NETC IP has one external master MDIO interface (eMDIO) for managing
external PHYs, all ENETC ports share this eMDIO. The EMDIO function and
the ENETC port MDIO are the virtual ports of this eMDIO, ENETC can use
these virtual ports to access their PHYs. The difference is that EMDIO
function is a 'global port', it ca... | null | null | null | [PATCH v3 net-next 0/3] net: enetc: add port MDIO support for both i.MX94 and i.MX95 | Each ENETC has a set of external MDIO registers to access its external
PHY based on its port EMDIO bus, these registers are used for MDIO bus
access, such as setting the PHY address, PHY register address and value,
read or write operations, C22 or C45 format, etc. The base address of
this set of registers has been modi... | {
"author": "Wei Fang <wei.fang@nxp.com>",
"date": "Wed, 19 Nov 2025 18:25:57 +0800",
"is_openbsd": false,
"thread_id": "20251119102557.1041881-1-wei.fang@nxp.com.mbox.gz"
} |
lkml_critique | netdev | The NETC IP has one external master MDIO interface (eMDIO) for managing
external PHYs, all ENETC ports share this eMDIO. The EMDIO function and
the ENETC port MDIO are the virtual ports of this eMDIO, ENETC can use
these virtual ports to access their PHYs. The difference is that EMDIO
function is a 'global port', it ca... | null | null | null | [PATCH v3 net-next 0/3] net: enetc: add port MDIO support for both i.MX94 and i.MX95 | On 11/19/25 11:25 AM, Wei Fang wrote:
Andrew, it's not clear to me if you are with the current patch version,
could you please chime-in?
Thanks,
Paolo | {
"author": "Paolo Abeni <pabeni@redhat.com>",
"date": "Tue, 25 Nov 2025 11:05:06 +0100",
"is_openbsd": false,
"thread_id": "20251119102557.1041881-1-wei.fang@nxp.com.mbox.gz"
} |
lkml_critique | netdev | The NETC IP has one external master MDIO interface (eMDIO) for managing
external PHYs, all ENETC ports share this eMDIO. The EMDIO function and
the ENETC port MDIO are the virtual ports of this eMDIO, ENETC can use
these virtual ports to access their PHYs. The difference is that EMDIO
function is a 'global port', it ca... | null | null | null | [PATCH v3 net-next 0/3] net: enetc: add port MDIO support for both i.MX94 and i.MX95 | On Tue, Nov 25, 2025 at 11:05:06AM +0100, Paolo Abeni wrote:
I say merge it. I'm not sure it is the best of architectures, but i
don't have time to dig into all the details in order to suggest
something better.
Andrew | {
"author": "Andrew Lunn <andrew@lunn.ch>",
"date": "Tue, 25 Nov 2025 17:19:58 +0100",
"is_openbsd": false,
"thread_id": "20251119102557.1041881-1-wei.fang@nxp.com.mbox.gz"
} |
lkml_critique | netdev | The NETC IP has one external master MDIO interface (eMDIO) for managing
external PHYs, all ENETC ports share this eMDIO. The EMDIO function and
the ENETC port MDIO are the virtual ports of this eMDIO, ENETC can use
these virtual ports to access their PHYs. The difference is that EMDIO
function is a 'global port', it ca... | null | null | null | [PATCH v3 net-next 0/3] net: enetc: add port MDIO support for both i.MX94 and i.MX95 | Hello:
This series was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Wed, 19 Nov 2025 18:25:54 +0800 you wrote:
Here is the summary with links:
- [v3,net-next,1/3] net: enetc: set the external PHY address in IERB for port MDIO usage
https://git.kernel.org/netdev/net-next/c/6633d... | {
"author": "patchwork-bot+netdevbpf@kernel.org",
"date": "Wed, 26 Nov 2025 03:00:21 +0000",
"is_openbsd": false,
"thread_id": "20251119102557.1041881-1-wei.fang@nxp.com.mbox.gz"
} |
lkml_critique | netdev | The NETC IP has one external master MDIO interface (eMDIO) for managing
external PHYs, all ENETC ports share this eMDIO. The EMDIO function and
the ENETC port MDIO are the virtual ports of this eMDIO, ENETC can use
these virtual ports to access their PHYs. The difference is that EMDIO
function is a 'global port', it ca... | null | null | null | [PATCH v3 net-next 0/3] net: enetc: add port MDIO support for both i.MX94 and i.MX95 | Hi,
sorry for the very late reply. I didn't get the chance to boot our
i.MX95 based board (TQMa95xxSA) in the meantime.
Am Mittwoch, 19. November 2025, 11:25:55 CET schrieb Wei Fang:
If there is no 'mdio' node below enetc_portX node, then 0 is returned...
... which will break here if there is an Ethernet PHY using... | {
"author": "Alexander Stein <alexander.stein@ew.tq-group.com>",
"date": "Fri, 27 Feb 2026 14:41:40 +0100",
"is_openbsd": false,
"thread_id": "20251119102557.1041881-1-wei.fang@nxp.com.mbox.gz"
} |
lkml_critique | netdev | The stmmac core supports two interrupt modes, controlled by the
flag STMMAC_FLAG_MULTI_MSI_EN:
- When the flag is set, the driver uses multi-channel IRQ mode (Multi-IRQ).
- Otherwise, a single IRQ line is requested (aka MAC-IRQ):
static int stmmac_request_irq(struct net_device *dev)
{
/* Request the IRQ lines... | null | null | null | [PATCH v7 0/5] Support multi-channel IRQs in stmmac platform
drivers | From: "Jan Petrous (OSS)" <jan.petrous@oss.nxp.com>
The stmmac driver contains similar pattern for processing queue-based
arrays, ie. interrupt lines, etc. Factor out the for loop and provide
a macro STMMAC_FOREACH_MTL_QUEUE(var, limit).
Signed-off-by: Jan Petrous (OSS) <jan.petrous@oss.nxp.com>
---
drivers/net/ethe... | {
"author": "Jan Petrous via B4 Relay <devnull+jan.petrous.oss.nxp.com@kernel.org>",
"date": "Thu, 26 Feb 2026 09:54:06 +0100",
"is_openbsd": false,
"thread_id": "20260226-dwmac_multi_irq-v7-0-f8fe3b945bb4@oss.nxp.com.mbox.gz"
} |
lkml_critique | netdev | The stmmac core supports two interrupt modes, controlled by the
flag STMMAC_FLAG_MULTI_MSI_EN:
- When the flag is set, the driver uses multi-channel IRQ mode (Multi-IRQ).
- Otherwise, a single IRQ line is requested (aka MAC-IRQ):
static int stmmac_request_irq(struct net_device *dev)
{
/* Request the IRQ lines... | null | null | null | [PATCH v7 0/5] Support multi-channel IRQs in stmmac platform
drivers | From: "Jan Petrous (OSS)" <jan.petrous@oss.nxp.com>
Read IRQ resources for all rx/tx channels, to allow Multi-IRQ mode
for platform glue drivers.
Reviewed-by: Matthias Brugger <mbrugger@suse.com>
Signed-off-by: Jan Petrous (OSS) <jan.petrous@oss.nxp.com>
---
.../net/ethernet/stmicro/stmmac/stmmac_platform.c | 46 ++... | {
"author": "Jan Petrous via B4 Relay <devnull+jan.petrous.oss.nxp.com@kernel.org>",
"date": "Thu, 26 Feb 2026 09:54:07 +0100",
"is_openbsd": false,
"thread_id": "20260226-dwmac_multi_irq-v7-0-f8fe3b945bb4@oss.nxp.com.mbox.gz"
} |
lkml_critique | netdev | The stmmac core supports two interrupt modes, controlled by the
flag STMMAC_FLAG_MULTI_MSI_EN:
- When the flag is set, the driver uses multi-channel IRQ mode (Multi-IRQ).
- Otherwise, a single IRQ line is requested (aka MAC-IRQ):
static int stmmac_request_irq(struct net_device *dev)
{
/* Request the IRQ lines... | null | null | null | [PATCH v7 0/5] Support multi-channel IRQs in stmmac platform
drivers | From: "Jan Petrous (OSS)" <jan.petrous@oss.nxp.com>
The GMAC Ethernet controller found on S32G2/S32G3 and S32R45
contains up to 5 RX and 5 TX channels.
It can operate in two interrupt modes:
1) Sharing IRQ mode: only MAC IRQ line is used
for all channels.
2) Multiple IRQ mode: every channel uses two IRQ lin... | {
"author": "Jan Petrous via B4 Relay <devnull+jan.petrous.oss.nxp.com@kernel.org>",
"date": "Thu, 26 Feb 2026 09:54:08 +0100",
"is_openbsd": false,
"thread_id": "20260226-dwmac_multi_irq-v7-0-f8fe3b945bb4@oss.nxp.com.mbox.gz"
} |
lkml_critique | netdev | The stmmac core supports two interrupt modes, controlled by the
flag STMMAC_FLAG_MULTI_MSI_EN:
- When the flag is set, the driver uses multi-channel IRQ mode (Multi-IRQ).
- Otherwise, a single IRQ line is requested (aka MAC-IRQ):
static int stmmac_request_irq(struct net_device *dev)
{
/* Request the IRQ lines... | null | null | null | [PATCH v7 0/5] Support multi-channel IRQs in stmmac platform
drivers | From: "Jan Petrous (OSS)" <jan.petrous@oss.nxp.com>
The DWMAC IP on NXP S32G/R SoCs has connected queue-based IRQ lines,
set them to allow using Multi-IRQ mode.
Reviewed-by: Matthias Brugger <mbrugger@suse.com>
Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
Signed-off-by: Jan Petrous (OSS) <jan.petrous@oss.nxp.com>... | {
"author": "Jan Petrous via B4 Relay <devnull+jan.petrous.oss.nxp.com@kernel.org>",
"date": "Thu, 26 Feb 2026 09:54:09 +0100",
"is_openbsd": false,
"thread_id": "20260226-dwmac_multi_irq-v7-0-f8fe3b945bb4@oss.nxp.com.mbox.gz"
} |
lkml_critique | netdev | The stmmac core supports two interrupt modes, controlled by the
flag STMMAC_FLAG_MULTI_MSI_EN:
- When the flag is set, the driver uses multi-channel IRQ mode (Multi-IRQ).
- Otherwise, a single IRQ line is requested (aka MAC-IRQ):
static int stmmac_request_irq(struct net_device *dev)
{
/* Request the IRQ lines... | null | null | null | [PATCH v7 0/5] Support multi-channel IRQs in stmmac platform
drivers | From: "Jan Petrous (OSS)" <jan.petrous@oss.nxp.com>
Based on previous changes in platform driver, the vendor
glue driver can enable Multi-IRQ mode, if needed.
To get enabled Multi-IRQ mode for dwmac-s32, the driver checks:
1) property of 'snps,mtl-xx-config' subnode
defines 'snps,xx-queues-to-use' bigger then... | {
"author": "Jan Petrous via B4 Relay <devnull+jan.petrous.oss.nxp.com@kernel.org>",
"date": "Thu, 26 Feb 2026 09:54:10 +0100",
"is_openbsd": false,
"thread_id": "20260226-dwmac_multi_irq-v7-0-f8fe3b945bb4@oss.nxp.com.mbox.gz"
} |
lkml_critique | netdev | The stmmac core supports two interrupt modes, controlled by the
flag STMMAC_FLAG_MULTI_MSI_EN:
- When the flag is set, the driver uses multi-channel IRQ mode (Multi-IRQ).
- Otherwise, a single IRQ line is requested (aka MAC-IRQ):
static int stmmac_request_irq(struct net_device *dev)
{
/* Request the IRQ lines... | null | null | null | [PATCH v7 0/5] Support multi-channel IRQs in stmmac platform
drivers | On Thu, Feb 26, 2026 at 09:54:07AM +0100, Jan Petrous via B4 Relay wrote:
You've missed that there are two separate definitions for tx and rx
queues - while they are currently the same number, code shouldn't
make that assumption.
I'm not happy with this method of combining the two loops.
Maybe instead:
static int ... | {
"author": "\"Russell King (Oracle)\" <linux@armlinux.org.uk>",
"date": "Thu, 26 Feb 2026 19:10:22 +0000",
"is_openbsd": false,
"thread_id": "20260226-dwmac_multi_irq-v7-0-f8fe3b945bb4@oss.nxp.com.mbox.gz"
} |
lkml_critique | netdev | The stmmac core supports two interrupt modes, controlled by the
flag STMMAC_FLAG_MULTI_MSI_EN:
- When the flag is set, the driver uses multi-channel IRQ mode (Multi-IRQ).
- Otherwise, a single IRQ line is requested (aka MAC-IRQ):
static int stmmac_request_irq(struct net_device *dev)
{
/* Request the IRQ lines... | null | null | null | [PATCH v7 0/5] Support multi-channel IRQs in stmmac platform
drivers | On Thu, Feb 26, 2026 at 07:10:22PM +0000, Russell King (Oracle) wrote:
Oh, yes. My fault. Next time I shall review my code better.
Agree, your code looks better. Applied in v8 :) Thanks.
BTW, I would prefer to use sizeof() instead of constant for array size,
but this is the style used in stmmac, so I reuse the same... | {
"author": "Jan Petrous <jan.petrous@oss.nxp.com>",
"date": "Fri, 27 Feb 2026 13:27:43 +0100",
"is_openbsd": false,
"thread_id": "20260226-dwmac_multi_irq-v7-0-f8fe3b945bb4@oss.nxp.com.mbox.gz"
} |
lkml_critique | netdev | In the current implementation, flushing multicast entries in MAC mode
incorrectly deletes entries for all ports instead of only the target port,
disrupting multicast traffic on other ports. The cause is adding multicast
entries by setting only host port bit, and not setting the MAC port bits.
Fix this by setting the M... | null | null | null | [PATCH net v2] net: ethernet: ti: am65-cpsw-nuss/cpsw-ale: Fix multicast entry handling in ALE table | On Tue, Feb 24, 2026 at 11:43:59PM +0530, Chintan Vankar wrote:
Reviewed-by: Simon Horman <horms@kernel.org>
... | {
"author": "Simon Horman <horms@kernel.org>",
"date": "Thu, 26 Feb 2026 19:54:14 +0000",
"is_openbsd": false,
"thread_id": "177216420905.1962692.4647985394308297951.git-patchwork-notify@kernel.org.mbox.gz"
} |
lkml_critique | netdev | In the current implementation, flushing multicast entries in MAC mode
incorrectly deletes entries for all ports instead of only the target port,
disrupting multicast traffic on other ports. The cause is adding multicast
entries by setting only host port bit, and not setting the MAC port bits.
Fix this by setting the M... | null | null | null | [PATCH net v2] net: ethernet: ti: am65-cpsw-nuss/cpsw-ale: Fix multicast entry handling in ALE table | Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Tue, 24 Feb 2026 23:43:59 +0530 you wrote:
Here is the summary with links:
- [net,v2] net: ethernet: ti: am65-cpsw-nuss/cpsw-ale: Fix multicast entry handling in ALE table
https://git.kernel.org/netdev/net/c/be11a537... | {
"author": "patchwork-bot+netdevbpf@kernel.org",
"date": "Fri, 27 Feb 2026 03:50:09 +0000",
"is_openbsd": false,
"thread_id": "177216420905.1962692.4647985394308297951.git-patchwork-notify@kernel.org.mbox.gz"
} |
lkml_critique | netdev | The MT7628 has a fixed-link PHY and does not expose MAC control
registers. Writes to these registers only corrupt the ESW VLAN
configuration.
This patch explicitly registers no-op phylink_mac_ops for MT7628, as
after removing the invalid register accesses, the existing
phylink_mac_ops effectively become no-ops.
This ... | null | null | null | [PATCH v4] net: ethernet: mtk_eth_soc: avoid writing to ESW registers on MT7628 | On Thu, Feb 26, 2026 at 03:45:18PM +0000, Joris Vaisvila wrote:
Reviewed-by: Daniel Golle <daniel@makrotpia.org>
Cc: Stefan Roese <sr@denx.de> | {
"author": "Daniel Golle <daniel@makrotopia.org>",
"date": "Thu, 26 Feb 2026 16:06:00 +0000",
"is_openbsd": false,
"thread_id": "79a0ba8c-91a8-47e0-81fa-275f15ede96f@mailbox.org.mbox.gz"
} |
lkml_critique | netdev | The MT7628 has a fixed-link PHY and does not expose MAC control
registers. Writes to these registers only corrupt the ESW VLAN
configuration.
This patch explicitly registers no-op phylink_mac_ops for MT7628, as
after removing the invalid register accesses, the existing
phylink_mac_ops effectively become no-ops.
This ... | null | null | null | [PATCH v4] net: ethernet: mtk_eth_soc: avoid writing to ESW registers on MT7628 | On 2/26/26 17:06, Daniel Golle wrote:
Reviewed-by: Stefan Roese <stefan.roese@mailbox.org>
Thanks,
Stefan | {
"author": "Stefan Roese <stefan.roese@mailbox.org>",
"date": "Fri, 27 Feb 2026 09:03:53 +0100",
"is_openbsd": false,
"thread_id": "79a0ba8c-91a8-47e0-81fa-275f15ede96f@mailbox.org.mbox.gz"
} |
lkml_critique | netdev | Commit 31a7a0bbeb00 ("dpaa2-switch: add bounds check for if_id in IRQ
handler") introduces a range check for if_id to avoid an out-of-bounds
access. If an out-of-bounds if_id is detected, the interrupt status is
not cleared. This may result in an interrupt storm.
Clear the interrupt status after detecting an out-of-bo... | null | null | null | [PATCH] dpaa2-switch: Fix interrupt storm after receiving bad if_id in IRQ handler | On Thu, Feb 26, 2026 at 09:58:12PM -0800, Guenter Roeck wrote:
Reviewed-by: Ioana Ciornei <ioana.ciornei@nxp.com> | {
"author": "Ioana Ciornei <ioana.ciornei@nxp.com>",
"date": "Fri, 27 Feb 2026 14:40:38 +0200",
"is_openbsd": false,
"thread_id": "y4dfxt6udovy6mev52lcoxb4m42dukighazitapqivp7jtievq@s4hrbeemzii3.mbox.gz"
} |
lkml_critique | netdev | Now that the pp fields in net_iov have no users, remove them from
net_iov and clean up.
Signed-off-by: Byungchul Park <byungchul@sk.com>
---
The original post was:
https://lore.kernel.org/all/20251121040047.71921-1-byungchul@sk.com/
1/3 was covered by Pavel's patch:
commit f0243d2b86b97 ("io_uring/zcrx: convert... | null | null | null | [RESEND PATCH net-next] netmem: remove the pp fields from net_iov | On Tue, Feb 24, 2026 at 03:14:24PM +0900, Byungchul Park wrote:
Reviewed-by: Simon Horman <horms@kernel.org> | {
"author": "Simon Horman <horms@kernel.org>",
"date": "Wed, 25 Feb 2026 09:14:38 +0000",
"is_openbsd": false,
"thread_id": "177216480555.1965102.13851630546170350105.git-patchwork-notify@kernel.org.mbox.gz"
} |
lkml_critique | netdev | Now that the pp fields in net_iov have no users, remove them from
net_iov and clean up.
Signed-off-by: Byungchul Park <byungchul@sk.com>
---
The original post was:
https://lore.kernel.org/all/20251121040047.71921-1-byungchul@sk.com/
1/3 was covered by Pavel's patch:
commit f0243d2b86b97 ("io_uring/zcrx: convert... | null | null | null | [RESEND PATCH net-next] netmem: remove the pp fields from net_iov | On 2/24/26 06:14, Byungchul Park wrote:
Looks good, it's great to get rid of all this aliasing.
Reviewed-by: Pavel Begunkov <asml.silence@gmail.com>
--
Pavel Begunkov | {
"author": "Pavel Begunkov <asml.silence@gmail.com>",
"date": "Wed, 25 Feb 2026 09:25:20 +0000",
"is_openbsd": false,
"thread_id": "177216480555.1965102.13851630546170350105.git-patchwork-notify@kernel.org.mbox.gz"
} |
lkml_critique | netdev | Now that the pp fields in net_iov have no users, remove them from
net_iov and clean up.
Signed-off-by: Byungchul Park <byungchul@sk.com>
---
The original post was:
https://lore.kernel.org/all/20251121040047.71921-1-byungchul@sk.com/
1/3 was covered by Pavel's patch:
commit f0243d2b86b97 ("io_uring/zcrx: convert... | null | null | null | [RESEND PATCH net-next] netmem: remove the pp fields from net_iov | On Mon, Feb 23, 2026 at 10:14 PM Byungchul Park <byungchul@sk.com> wrote:
Probably better to retain an assert that netmem_desc is the first
field in struct net_iov, no?
There technically is no assert that netmem_desc is the first field of
struct page, but it's generally well understood that the memory
descriptor type... | {
"author": "Mina Almasry <almasrymina@google.com>",
"date": "Wed, 25 Feb 2026 09:57:17 -0800",
"is_openbsd": false,
"thread_id": "177216480555.1965102.13851630546170350105.git-patchwork-notify@kernel.org.mbox.gz"
} |
lkml_critique | netdev | Now that the pp fields in net_iov have no users, remove them from
net_iov and clean up.
Signed-off-by: Byungchul Park <byungchul@sk.com>
---
The original post was:
https://lore.kernel.org/all/20251121040047.71921-1-byungchul@sk.com/
1/3 was covered by Pavel's patch:
commit f0243d2b86b97 ("io_uring/zcrx: convert... | null | null | null | [RESEND PATCH net-next] netmem: remove the pp fields from net_iov | On Wed, Feb 25, 2026 at 09:57:17AM -0800, Mina Almasry wrote:
What is the assert for? Can you give an example that might lead wrong
without the assert?
Byungchul | {
"author": "Byungchul Park <byungchul@sk.com>",
"date": "Thu, 26 Feb 2026 09:21:27 +0900",
"is_openbsd": false,
"thread_id": "177216480555.1965102.13851630546170350105.git-patchwork-notify@kernel.org.mbox.gz"
} |
lkml_critique | netdev | Now that the pp fields in net_iov have no users, remove them from
net_iov and clean up.
Signed-off-by: Byungchul Park <byungchul@sk.com>
---
The original post was:
https://lore.kernel.org/all/20251121040047.71921-1-byungchul@sk.com/
1/3 was covered by Pavel's patch:
commit f0243d2b86b97 ("io_uring/zcrx: convert... | null | null | null | [RESEND PATCH net-next] netmem: remove the pp fields from net_iov | Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Tue, 24 Feb 2026 15:14:24 +0900 you wrote:
Here is the summary with links:
- [RESEND,net-next] netmem: remove the pp fields from net_iov
https://git.kernel.org/netdev/net-next/c/fd6dad4e1ae2
You are awesome, th... | {
"author": "patchwork-bot+netdevbpf@kernel.org",
"date": "Fri, 27 Feb 2026 04:00:05 +0000",
"is_openbsd": false,
"thread_id": "177216480555.1965102.13851630546170350105.git-patchwork-notify@kernel.org.mbox.gz"
} |
lkml_critique | netdev | Hello,
syzbot found the following issue on:
HEAD commit: 2b38afce25c4 Merge tag 'turbostat-2025.09.09' of git://git..
git tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
console output: https://syzkaller.appspot.com/x/log.txt?x=142f4af0580000
kernel config: https://syzkaller... | null | null | null | [syzbot] [libertas?] INFO: task hung in lbs_remove_card | syzbot has found a reproducer for the following issue on:
HEAD commit: bb375c251ab4 dt-bindings: usb: st,st-ohci-300x: convert to..
git tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
console output: https://syzkaller.appspot.com/x/log.txt?x=1141755a580000
kernel config: http... | {
"author": "syzbot <syzbot+c99d17aa44dbdba16ad2@syzkaller.appspotmail.com>",
"date": "Fri, 27 Feb 2026 03:22:26 -0800",
"is_openbsd": false,
"thread_id": "69a17e72.050a0220.305b49.00de.GAE@google.com.mbox.gz"
} |
lkml_critique | netdev | Add compatible string for 5.40a version that can avoid to define some
platform data in the glue layer.
Signed-off-by: Inochi Amaoto <inochiama@gmail.com>
---
drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c ... | null | null | null | [PATCH net-next v4 2/3] net: stmmac: platform: Add snps,dwmac-5.40a IP compatible string | The ethernet controller on Spacemit K3 SoC is Synopsys DesignWare
MAC (version 5.40a), with the following special points:
1. The rate of the tx clock line is auto changed when the mac speed
rate is changed, and no need for changing the input tx clock.
2. This controller require a extra syscon device to configure the... | {
"author": "Inochi Amaoto <inochiama@gmail.com>",
"date": "Fri, 30 Jan 2026 10:27:04 +0800",
"is_openbsd": false,
"thread_id": "aaFOeQ0deTKVW0_N@inochi.infowork.mbox.gz"
} |
lkml_critique | netdev | Add compatible string for 5.40a version that can avoid to define some
platform data in the glue layer.
Signed-off-by: Inochi Amaoto <inochiama@gmail.com>
---
drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c ... | null | null | null | [PATCH net-next v4 2/3] net: stmmac: platform: Add snps,dwmac-5.40a IP compatible string | Add initial support for ethernet controller of the Spacemit K3 SoC.
This ethernet controller is almost a standard Synopsys DesignWare
MAC (version 5.40a). This controller require a syscon device to
configure some basic features, like interface type and internal delay.
Change from v3:
- https://lore.kernel.org/netdev/2... | {
"author": "Inochi Amaoto <inochiama@gmail.com>",
"date": "Fri, 30 Jan 2026 10:27:01 +0800",
"is_openbsd": false,
"thread_id": "aaFOeQ0deTKVW0_N@inochi.infowork.mbox.gz"
} |
lkml_critique | netdev | Add compatible string for 5.40a version that can avoid to define some
platform data in the glue layer.
Signed-off-by: Inochi Amaoto <inochiama@gmail.com>
---
drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c ... | null | null | null | [PATCH net-next v4 2/3] net: stmmac: platform: Add snps,dwmac-5.40a IP compatible string | The GMAC IP on Spacemit K3 is almost a standard Synopsys DesignWare
MAC (version 5.40a) with some extra clock.
Add necessary compatible string for this device.
Signed-off-by: Inochi Amaoto <inochiama@gmail.com>
---
.../devicetree/bindings/net/snps,dwmac.yaml | 2 +
.../bindings/net/spacemit,k3-dwmac.yaml |... | {
"author": "Inochi Amaoto <inochiama@gmail.com>",
"date": "Fri, 30 Jan 2026 10:27:02 +0800",
"is_openbsd": false,
"thread_id": "aaFOeQ0deTKVW0_N@inochi.infowork.mbox.gz"
} |
lkml_critique | netdev | Add compatible string for 5.40a version that can avoid to define some
platform data in the glue layer.
Signed-off-by: Inochi Amaoto <inochiama@gmail.com>
---
drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c ... | null | null | null | [PATCH net-next v4 2/3] net: stmmac: platform: Add snps,dwmac-5.40a IP compatible string | On Fri, Jan 30, 2026 at 10:27:02AM +0800, Inochi Amaoto wrote:
If you know what this is in terms of dwmac databook clock terms, it
would be helpful to use it here. I suspect "application clock" would
probably summarise it, that being the clock for the bus interfaces
that dwmac provides to the host.
--
RMK's Patch sy... | {
"author": "\"Russell King (Oracle)\" <linux@armlinux.org.uk>",
"date": "Tue, 3 Feb 2026 17:39:06 +0000",
"is_openbsd": false,
"thread_id": "aaFOeQ0deTKVW0_N@inochi.infowork.mbox.gz"
} |
lkml_critique | netdev | Add compatible string for 5.40a version that can avoid to define some
platform data in the glue layer.
Signed-off-by: Inochi Amaoto <inochiama@gmail.com>
---
drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c ... | null | null | null | [PATCH net-next v4 2/3] net: stmmac: platform: Add snps,dwmac-5.40a IP compatible string | On Fri, Jan 30, 2026 at 10:27:04AM +0800, Inochi Amaoto wrote:
Thanks for updating these.
I would suggest that this is split into two parts - first, this is
renamed and reduced to just controlling CTRL_WAKE_IRQ_EN.
Next, a function hooked into plat_dat->set_phy_intf_sel which sets
the CTRL_PHY_INTF_RGMII and CTRL_P... | {
"author": "\"Russell King (Oracle)\" <linux@armlinux.org.uk>",
"date": "Tue, 3 Feb 2026 17:48:00 +0000",
"is_openbsd": false,
"thread_id": "aaFOeQ0deTKVW0_N@inochi.infowork.mbox.gz"
} |
lkml_critique | netdev | Add compatible string for 5.40a version that can avoid to define some
platform data in the glue layer.
Signed-off-by: Inochi Amaoto <inochiama@gmail.com>
---
drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c ... | null | null | null | [PATCH net-next v4 2/3] net: stmmac: platform: Add snps,dwmac-5.40a IP compatible string | On Tue, Feb 03, 2026 at 05:48:00PM +0000, Russell King (Oracle) wrote:
Thanks for your detailed guide, I will try to switch to these helper
apis in the next version.
Regards,
Inochi | {
"author": "Inochi Amaoto <inochiama@gmail.com>",
"date": "Wed, 4 Feb 2026 10:14:47 +0800",
"is_openbsd": false,
"thread_id": "aaFOeQ0deTKVW0_N@inochi.infowork.mbox.gz"
} |
lkml_critique | netdev | Add compatible string for 5.40a version that can avoid to define some
platform data in the glue layer.
Signed-off-by: Inochi Amaoto <inochiama@gmail.com>
---
drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c ... | null | null | null | [PATCH net-next v4 2/3] net: stmmac: platform: Add snps,dwmac-5.40a IP compatible string | On Tue, Feb 03, 2026 at 05:39:06PM +0000, Russell King (Oracle) wrote:
That's a good point, In fact, I have no dwmac databook now. So if you
think it is fine, I will change this description to the "application
clock". Thanks.
Regards,
Inochi | {
"author": "Inochi Amaoto <inochiama@gmail.com>",
"date": "Wed, 4 Feb 2026 10:11:36 +0800",
"is_openbsd": false,
"thread_id": "aaFOeQ0deTKVW0_N@inochi.infowork.mbox.gz"
} |
lkml_critique | netdev | Add compatible string for 5.40a version that can avoid to define some
platform data in the glue layer.
Signed-off-by: Inochi Amaoto <inochiama@gmail.com>
---
drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c ... | null | null | null | [PATCH net-next v4 2/3] net: stmmac: platform: Add snps,dwmac-5.40a IP compatible string | On Fri, 30 Jan 2026 10:27:02 +0800, Inochi Amaoto wrote:
Reviewed-by: Rob Herring (Arm) <robh@kernel.org> | {
"author": "\"Rob Herring (Arm)\" <robh@kernel.org>",
"date": "Mon, 9 Feb 2026 11:55:14 -0600",
"is_openbsd": false,
"thread_id": "aaFOeQ0deTKVW0_N@inochi.infowork.mbox.gz"
} |
lkml_critique | netdev | Add compatible string for 5.40a version that can avoid to define some
platform data in the glue layer.
Signed-off-by: Inochi Amaoto <inochiama@gmail.com>
---
drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c ... | null | null | null | [PATCH net-next v4 2/3] net: stmmac: platform: Add snps,dwmac-5.40a IP compatible string | Quoting Inochi Amaoto (2026-01-30 03:27:01)
Hi Inochi,
Do you have a tree that includes the dt entries?
Otherwise how are we going to test this?
/Emil | {
"author": "Emil Renner Berthing <emil.renner.berthing@gmail.com>",
"date": "Tue, 17 Feb 2026 10:00:29 -0600",
"is_openbsd": false,
"thread_id": "aaFOeQ0deTKVW0_N@inochi.infowork.mbox.gz"
} |
lkml_critique | netdev | Add compatible string for 5.40a version that can avoid to define some
platform data in the glue layer.
Signed-off-by: Inochi Amaoto <inochiama@gmail.com>
---
drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c ... | null | null | null | [PATCH net-next v4 2/3] net: stmmac: platform: Add snps,dwmac-5.40a IP compatible string | On Tue, Feb 17, 2026 at 10:00:29AM -0600, Emil Renner Berthing wrote:
Yes, I have one, but it is not opened as I was requested.
I will send the DTS patch, once the clock, gpio, and pinctrl
device is available. At least for now, I had no way to post
my DTS patch.
Regards,
Inochi | {
"author": "Inochi Amaoto <inochiama@gmail.com>",
"date": "Fri, 27 Feb 2026 16:01:07 +0800",
"is_openbsd": false,
"thread_id": "aaFOeQ0deTKVW0_N@inochi.infowork.mbox.gz"
} |
lkml_critique | netdev | From: Bobby Eshleman <bobbyeshleman@meta.com>
binding->dev is protected on the write-side in
mp_dmabuf_devmem_uninstall() against concurrent writes, but due to the
concurrent bare read in net_devmem_get_binding() it should be wrapped in
a READ_ONCE/WRITE_ONCE pair to make sure no compiler optimizations play
with the u... | null | null | null | [PATCH net] net: devmem: use READ_ONCE/WRITE_ONCE on binding->dev | On Wed, Feb 25, 2026 at 09:31:48AM -0800, Mina Almasry wrote:
I also noticed in tools/memory-model/Documentation/access-marking.txt
section "Lock-Protected Writes With Lockless Reads" it is recommended to
also use ASSERT_EXCLUSIVE_WRITER(), with explanation:
"The purpose of the ASSERT_EXCLUSIVE_WRITER() is to allow K... | {
"author": "Bobby Eshleman <bobbyeshleman@gmail.com>",
"date": "Fri, 27 Feb 2026 08:13:50 -0800",
"is_openbsd": false,
"thread_id": "aaHCvoskaft4KVL6@devvm11784.nha0.facebook.com.mbox.gz"
} |
lkml_critique | netdev | Hi Laurent,
I'm testing the latest openwrt state and found an issue probably
caused by your usb mtu limit patch :-)
I'm talking about this one:
662dc80a5e86 ("usbnet: limit max_mtu based on device's hard_mtu")
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=v6.12.74&id=662dc80a5e86b35bbf33... | null | null | null | commit 662dc80a5e86 breaks rmnet over usb | On 2/23/26 13:04, Koen Vandeputte wrote:
Hi Koen,
It's weird to be able to set an MTU that is not supported by the hardware.
To restore performance I think the rx_usb_size should be decoupled from MTU max in qmi_wwan.
Could you try something like:
diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan... | {
"author": "Laurent Vivier <lvivier@redhat.com>",
"date": "Mon, 23 Feb 2026 15:08:41 +0100",
"is_openbsd": false,
"thread_id": "CAGRyCJFDKv+U4004bPKVGGq292nNiOxuovOc0magetRCJ8vNaQ@mail.gmail.com.mbox.gz"
} |
lkml_critique | netdev | Hi Laurent,
I'm testing the latest openwrt state and found an issue probably
caused by your usb mtu limit patch :-)
I'm talking about this one:
662dc80a5e86 ("usbnet: limit max_mtu based on device's hard_mtu")
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=v6.12.74&id=662dc80a5e86b35bbf33... | null | null | null | commit 662dc80a5e86 breaks rmnet over usb | On Mon, 23 Feb 2026 15:08:41 +0100
Laurent Vivier <lvivier@redhat.com> wrote:
...
A lot of 'usbnet' drivers support usb packets that contain multiple ethernet frames.
IIRC (I looked at this code quite a few years ago) some (all?) lie very badly
about the skb 'true_size' of receive packets - putting in the frame size
... | {
"author": "David Laight <david.laight.linux@gmail.com>",
"date": "Mon, 23 Feb 2026 15:13:58 +0000",
"is_openbsd": false,
"thread_id": "CAGRyCJFDKv+U4004bPKVGGq292nNiOxuovOc0magetRCJ8vNaQ@mail.gmail.com.mbox.gz"
} |
lkml_critique | netdev | Hi Laurent,
I'm testing the latest openwrt state and found an issue probably
caused by your usb mtu limit patch :-)
I'm talking about this one:
662dc80a5e86 ("usbnet: limit max_mtu based on device's hard_mtu")
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=v6.12.74&id=662dc80a5e86b35bbf33... | null | null | null | commit 662dc80a5e86 breaks rmnet over usb | Hello,
Il giorno lun 23 feb 2026 alle ore 15:08 Laurent Vivier
<lvivier@redhat.com> ha scritto:
So far userspace tools (e.g. also the most important one which is
ModemManager) rely on changing the rx_urb_size by changing the MTU: I
know this is ugly, but it is a behavior that has been there since a
lot of time, not s... | {
"author": "Daniele Palmas <dnlplm@gmail.com>",
"date": "Wed, 25 Feb 2026 08:19:46 +0100",
"is_openbsd": false,
"thread_id": "CAGRyCJFDKv+U4004bPKVGGq292nNiOxuovOc0magetRCJ8vNaQ@mail.gmail.com.mbox.gz"
} |
lkml_critique | netdev | Hi Laurent,
I'm testing the latest openwrt state and found an issue probably
caused by your usb mtu limit patch :-)
I'm talking about this one:
662dc80a5e86 ("usbnet: limit max_mtu based on device's hard_mtu")
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=v6.12.74&id=662dc80a5e86b35bbf33... | null | null | null | commit 662dc80a5e86 breaks rmnet over usb | On 2/25/26 08:19, Daniele Palmas wrote:
Hello Daniele,
And there is no intermediate driver (qmi_wwan or rmnet) that can define a max_mtu higher
than that defined by usbnet?
Thanks,
Laurent | {
"author": "Laurent Vivier <lvivier@redhat.com>",
"date": "Wed, 25 Feb 2026 08:48:08 +0100",
"is_openbsd": false,
"thread_id": "CAGRyCJFDKv+U4004bPKVGGq292nNiOxuovOc0magetRCJ8vNaQ@mail.gmail.com.mbox.gz"
} |
lkml_critique | netdev | Hi Laurent,
I'm testing the latest openwrt state and found an issue probably
caused by your usb mtu limit patch :-)
I'm talking about this one:
662dc80a5e86 ("usbnet: limit max_mtu based on device's hard_mtu")
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=v6.12.74&id=662dc80a5e86b35bbf33... | null | null | null | commit 662dc80a5e86 breaks rmnet over usb | On 2/25/26 08:48, Laurent Vivier wrote:
Perhaps we can remove the change from usbnet and move it to the device bind function?
diff --git a/drivers/net/usb/cdc_ether.c b/drivers/net/usb/cdc_ether.c
index a032c1ded406..836915e4abad 100644
--- a/drivers/net/usb/cdc_ether.c
+++ b/drivers/net/usb/cdc_ether.c
@@ -235,6 +23... | {
"author": "Laurent Vivier <lvivier@redhat.com>",
"date": "Wed, 25 Feb 2026 12:04:03 +0100",
"is_openbsd": false,
"thread_id": "CAGRyCJFDKv+U4004bPKVGGq292nNiOxuovOc0magetRCJ8vNaQ@mail.gmail.com.mbox.gz"
} |
lkml_critique | netdev | Hi Laurent,
I'm testing the latest openwrt state and found an issue probably
caused by your usb mtu limit patch :-)
I'm talking about this one:
662dc80a5e86 ("usbnet: limit max_mtu based on device's hard_mtu")
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=v6.12.74&id=662dc80a5e86b35bbf33... | null | null | null | commit 662dc80a5e86 breaks rmnet over usb | Hello Laurent,
Il giorno mer 25 feb 2026 alle ore 12:04 Laurent Vivier
<lvivier@redhat.com> ha scritto:
Both solutions look good to me.
If you think that your change provides benefit to other usbnet users,
then keeping qmi_wwan the exception is probably better.
Thanks,
Daniele | {
"author": "Daniele Palmas <dnlplm@gmail.com>",
"date": "Wed, 25 Feb 2026 15:14:36 +0100",
"is_openbsd": false,
"thread_id": "CAGRyCJFDKv+U4004bPKVGGq292nNiOxuovOc0magetRCJ8vNaQ@mail.gmail.com.mbox.gz"
} |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.