data_type large_stringclasses 3
values | source large_stringclasses 29
values | code large_stringlengths 98 49.4M | filepath large_stringlengths 5 161 ⌀ | message large_stringclasses 234
values | commit large_stringclasses 234
values | subject large_stringclasses 418
values | critique large_stringlengths 101 1.26M ⌀ | metadata dict |
|---|---|---|---|---|---|---|---|---|
lkml_critique | netdev | This is part 2 of the qcom-ethqos series, part 1 has now been merged.
This part of the series focuses on the generic PHY driver, but these
changes have dependencies on the ethernet driver, hence why
it will need to go via net-next. Furthermore, subsequent changes
depend on these patches.
The underlying ideas here are... | null | null | null | [PATCH RESEND2 net-next 0/8] net: stmmac: qcom-ethqos: further
serdes reorganisation | On Thu, Feb 26, 2026 at 11:07:16PM +0000, Russell King (Oracle) wrote:
Reiterating Vinod's request to netdev maintainers from here, just
because it's easy to get lost in the multiple patch versions:
https://lore.kernel.org/netdev/aaGgWUpM2A5y11Wh@vaman/
Can we please get a tag to pull into linux-phy when this gets me... | {
"author": "Vladimir Oltean <olteanv@gmail.com>",
"date": "Fri, 27 Feb 2026 17:48:50 +0200",
"is_openbsd": false,
"thread_id": "20260227153901.qor4rtvtxur2zywh@skbuf.mbox.gz"
} |
lkml_critique | netdev | When bridged ports and standalone ports share a VLAN, e.g. via VLAN
uppers, or untagged traffic with a vlan unaware bridge, the ASIC will
still try to forward traffic to known FDB entries on standalone ports.
But since the port VLAN masks prevent forwarding to bridged ports, this
traffic will be dropped.
This e.g. can... | null | null | null | [PATCH net] net: dsa: b53: prevent standalone from trying to forward to other ports | On 5/8/25 11:14 AM, Jonas Gorski wrote:
@Florian, could you please have a look at this one, too?
Thanks,
Paolo | {
"author": "Paolo Abeni <pabeni@redhat.com>",
"date": "Tue, 13 May 2025 12:28:00 +0200",
"is_openbsd": false,
"thread_id": "CACna6ry9B9LiPbWdXzi7FCcaU1YC+HPkor53AiSEaRSNUMcLwQ@mail.gmail.com.mbox.gz"
} |
lkml_critique | netdev | When bridged ports and standalone ports share a VLAN, e.g. via VLAN
uppers, or untagged traffic with a vlan unaware bridge, the ASIC will
still try to forward traffic to known FDB entries on standalone ports.
But since the port VLAN masks prevent forwarding to bridged ports, this
traffic will be dropped.
This e.g. can... | null | null | null | [PATCH net] net: dsa: b53: prevent standalone from trying to forward to other ports | On 5/8/2025 11:14 AM, Jonas Gorski wrote:
Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
--
Florian | {
"author": "Florian Fainelli <florian.fainelli@broadcom.com>",
"date": "Tue, 13 May 2025 14:43:05 +0200",
"is_openbsd": false,
"thread_id": "CACna6ry9B9LiPbWdXzi7FCcaU1YC+HPkor53AiSEaRSNUMcLwQ@mail.gmail.com.mbox.gz"
} |
lkml_critique | netdev | When bridged ports and standalone ports share a VLAN, e.g. via VLAN
uppers, or untagged traffic with a vlan unaware bridge, the ASIC will
still try to forward traffic to known FDB entries on standalone ports.
But since the port VLAN masks prevent forwarding to bridged ports, this
traffic will be dropped.
This e.g. can... | null | null | null | [PATCH net] net: dsa: b53: prevent standalone from trying to forward to other ports | On Thu, May 08, 2025 at 11:14:24AM +0200, Jonas Gorski wrote:
Reviewed-by: Vladimir Oltean <olteanv@gmail.com> | {
"author": "Vladimir Oltean <olteanv@gmail.com>",
"date": "Tue, 13 May 2025 15:55:16 +0300",
"is_openbsd": false,
"thread_id": "CACna6ry9B9LiPbWdXzi7FCcaU1YC+HPkor53AiSEaRSNUMcLwQ@mail.gmail.com.mbox.gz"
} |
lkml_critique | netdev | When bridged ports and standalone ports share a VLAN, e.g. via VLAN
uppers, or untagged traffic with a vlan unaware bridge, the ASIC will
still try to forward traffic to known FDB entries on standalone ports.
But since the port VLAN masks prevent forwarding to bridged ports, this
traffic will be dropped.
This e.g. can... | null | null | null | [PATCH net] net: dsa: b53: prevent standalone from trying to forward to other ports | Hello:
This patch was applied to netdev/net.git (main)
by Paolo Abeni <pabeni@redhat.com>:
On Thu, 8 May 2025 11:14:24 +0200 you wrote:
Here is the summary with links:
- [net] net: dsa: b53: prevent standalone from trying to forward to other ports
https://git.kernel.org/netdev/net/c/4227ea91e265
You are awes... | {
"author": "patchwork-bot+netdevbpf@kernel.org",
"date": "Tue, 13 May 2025 13:50:29 +0000",
"is_openbsd": false,
"thread_id": "CACna6ry9B9LiPbWdXzi7FCcaU1YC+HPkor53AiSEaRSNUMcLwQ@mail.gmail.com.mbox.gz"
} |
lkml_critique | netdev | When bridged ports and standalone ports share a VLAN, e.g. via VLAN
uppers, or untagged traffic with a vlan unaware bridge, the ASIC will
still try to forward traffic to known FDB entries on standalone ports.
But since the port VLAN masks prevent forwarding to bridged ports, this
traffic will be dropped.
This e.g. can... | null | null | null | [PATCH net] net: dsa: b53: prevent standalone from trying to forward to other ports | W dniu 8.05.2025 o 11:14, Jonas Gorski pisze:
This change broke standalone ports (those not being part of bridge) on Northstar (BCM5301X) devices. We got reports from users about WAN ports on routers not working anymore:
https://github.com/openwrt/openwrt/issues/21187
https://github.com/openwrt/openwrt/issues/21349
C... | {
"author": "=?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= <zajec5@gmail.com>",
"date": "Thu, 26 Feb 2026 21:24:59 +0100",
"is_openbsd": false,
"thread_id": "CACna6ry9B9LiPbWdXzi7FCcaU1YC+HPkor53AiSEaRSNUMcLwQ@mail.gmail.com.mbox.gz"
} |
lkml_critique | netdev | When bridged ports and standalone ports share a VLAN, e.g. via VLAN
uppers, or untagged traffic with a vlan unaware bridge, the ASIC will
still try to forward traffic to known FDB entries on standalone ports.
But since the port VLAN masks prevent forwarding to bridged ports, this
traffic will be dropped.
This e.g. can... | null | null | null | [PATCH net] net: dsa: b53: prevent standalone from trying to forward to other ports | On 2/26/26 12:24, Rafał Miłecki wrote:
Checking the BCM5301X datasheet, the register definitions look correct.
The first report appears to be for a Netgear R7000 which AFAICT would
utilize port 8 of the switch as the CPU port, which would be correct.
The other report is for a Netgear R6250 where port 5 would be act... | {
"author": "Florian Fainelli <florian.fainelli@broadcom.com>",
"date": "Thu, 26 Feb 2026 13:26:06 -0800",
"is_openbsd": false,
"thread_id": "CACna6ry9B9LiPbWdXzi7FCcaU1YC+HPkor53AiSEaRSNUMcLwQ@mail.gmail.com.mbox.gz"
} |
lkml_critique | netdev | When bridged ports and standalone ports share a VLAN, e.g. via VLAN
uppers, or untagged traffic with a vlan unaware bridge, the ASIC will
still try to forward traffic to known FDB entries on standalone ports.
But since the port VLAN masks prevent forwarding to bridged ports, this
traffic will be dropped.
This e.g. can... | null | null | null | [PATCH net] net: dsa: b53: prevent standalone from trying to forward to other ports | czw., 26 lut 2026 o 22:26 Florian Fainelli
<florian.fainelli@broadcom.com> napisał(a):
On my Luxul XWR-3150 (it uses gmac0 and port 5) the value of
B53_MGMT_PAGE (0x02) / B53_GLOBAL_CONFIG (0x00) is 0xc2. Nothing to
set there I suppose?
--
Rafał | {
"author": "=?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= <zajec5@gmail.com>",
"date": "Fri, 27 Feb 2026 13:23:14 +0100",
"is_openbsd": false,
"thread_id": "CACna6ry9B9LiPbWdXzi7FCcaU1YC+HPkor53AiSEaRSNUMcLwQ@mail.gmail.com.mbox.gz"
} |
lkml_critique | netdev | When bridged ports and standalone ports share a VLAN, e.g. via VLAN
uppers, or untagged traffic with a vlan unaware bridge, the ASIC will
still try to forward traffic to known FDB entries on standalone ports.
But since the port VLAN masks prevent forwarding to bridged ports, this
traffic will be dropped.
This e.g. can... | null | null | null | [PATCH net] net: dsa: b53: prevent standalone from trying to forward to other ports | pt., 27 lut 2026 o 13:23 Rafał Miłecki <zajec5@gmail.com> napisał(a):
I tried other possible values:
0x02
0x82
0x42
None affected my switch / wan / lan ports.
--
Rafał | {
"author": "=?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= <zajec5@gmail.com>",
"date": "Fri, 27 Feb 2026 14:32:32 +0100",
"is_openbsd": false,
"thread_id": "CACna6ry9B9LiPbWdXzi7FCcaU1YC+HPkor53AiSEaRSNUMcLwQ@mail.gmail.com.mbox.gz"
} |
lkml_critique | netdev | Currently, master devices (bonding, bridge, team) manually call
netdev_compute_master_upper_features() scattered throughout their port
add/remove operations. This approach requires each driver to remember
to update features at the right times and leads to code duplication.
The series adds a new ndo_update_offloads cal... | null | null | null | [RFC PATCH net-next 0/3] net: add ndo_update_offloads for offload computation | Add a new ndo_update_offloads callback to net_device_ops that allows
devices to compute and update their offload features during feature
updates.
This callback enabling master devices to recompute their features
based on current slave device configuration. This is particularly
useful for bonding, bridging, team, and f... | {
"author": "Hangbin Liu <liuhangbin@gmail.com>",
"date": "Thu, 26 Feb 2026 11:42:06 +0000",
"is_openbsd": false,
"thread_id": "aaFNilMyFaD9cA2u@fedora.mbox.gz"
} |
lkml_critique | netdev | Currently, master devices (bonding, bridge, team) manually call
netdev_compute_master_upper_features() scattered throughout their port
add/remove operations. This approach requires each driver to remember
to update features at the right times and leads to code duplication.
The series adds a new ndo_update_offloads cal... | null | null | null | [RFC PATCH net-next 0/3] net: add ndo_update_offloads for offload computation | Convert bonding, bridge, and team drivers to use the new
ndo_update_offloads callback instead of manually calling
netdev_compute_master_upper_features() during port add/remove operations.
This change centralizes the feature computation flow:
Before:
- netdev_compute_master_upper_features()
- compute offload feature... | {
"author": "Hangbin Liu <liuhangbin@gmail.com>",
"date": "Thu, 26 Feb 2026 11:42:07 +0000",
"is_openbsd": false,
"thread_id": "aaFNilMyFaD9cA2u@fedora.mbox.gz"
} |
lkml_critique | netdev | Currently, master devices (bonding, bridge, team) manually call
netdev_compute_master_upper_features() scattered throughout their port
add/remove operations. This approach requires each driver to remember
to update features at the right times and leads to code duplication.
The series adds a new ndo_update_offloads cal... | null | null | null | [RFC PATCH net-next 0/3] net: add ndo_update_offloads for offload computation | Convert net_failover to use the new ndo_update_offloads callback
instead of manually calling netdev_compute_master_upper_features()
during slave registration/unregistration.
This simplifies the failover code significantly by removing the custom
feature computation logic and relying on the centralized feature update
me... | {
"author": "Hangbin Liu <liuhangbin@gmail.com>",
"date": "Thu, 26 Feb 2026 11:42:08 +0000",
"is_openbsd": false,
"thread_id": "aaFNilMyFaD9cA2u@fedora.mbox.gz"
} |
lkml_critique | netdev | Currently, master devices (bonding, bridge, team) manually call
netdev_compute_master_upper_features() scattered throughout their port
add/remove operations. This approach requires each driver to remember
to update features at the right times and leads to code duplication.
The series adds a new ndo_update_offloads cal... | null | null | null | [RFC PATCH net-next 0/3] net: add ndo_update_offloads for offload computation | On Thu, Feb 26, 2026 at 11:42:08AM +0000, Hangbin Liu wrote:
Oh, forgot to fix this. Maybe we can use MASTER_UPPER_DEV_VLAN_FEATURES to
replace it?
drivers/net/net_failover.c: In function ‘net_failover_create’:
drivers/net/net_failover.c:687:37: error: ‘FAILOVER_VLAN_FEATURES’ undeclared (first use in this function)
... | {
"author": "Hangbin Liu <liuhangbin@gmail.com>",
"date": "Thu, 26 Feb 2026 12:48:27 +0000",
"is_openbsd": false,
"thread_id": "aaFNilMyFaD9cA2u@fedora.mbox.gz"
} |
lkml_critique | netdev | Currently, master devices (bonding, bridge, team) manually call
netdev_compute_master_upper_features() scattered throughout their port
add/remove operations. This approach requires each driver to remember
to update features at the right times and leads to code duplication.
The series adds a new ndo_update_offloads cal... | null | null | null | [RFC PATCH net-next 0/3] net: add ndo_update_offloads for offload computation | On Thu, Feb 26, 2026 at 11:42:07AM +0000, Hangbin Liu wrote:
Another benefit for this change is, after calling netdev_change_features() here,
the later netdev_sync_lower_features() will disable LRO automatically.
So we don't need to call dev_disable_lro() manually in
bonding/bridge/team/VLAN. I will add this patch in ... | {
"author": "Hangbin Liu <liuhangbin@gmail.com>",
"date": "Fri, 27 Feb 2026 07:53:46 +0000",
"is_openbsd": false,
"thread_id": "aaFNilMyFaD9cA2u@fedora.mbox.gz"
} |
lkml_critique | netdev | This series refactors the ZL3073x chip variant handling and adds die
temperature reporting for chips that support it.
Patch 1 replaces the five per-variant chip_info structures and their
exported symbols with a single consolidated lookup table. The chip
variant is now detected at runtime from the chip ID register rat... | null | null | null | [PATCH net-next 0/2] dpll: zl3073x: consolidate chip info and add temperature reporting | Replace the five per-variant zl3073x_chip_info structures and their
exported symbol definitions with a single consolidated chip ID lookup
table. The chip variant is now detected at runtime by reading the chip
ID register from hardware and looking it up in the table, rather than
being selected at compile time via the bu... | {
"author": "Ivan Vecera <ivecera@redhat.com>",
"date": "Fri, 27 Feb 2026 11:52:59 +0100",
"is_openbsd": false,
"thread_id": "20260227105300.710272-3-ivecera@redhat.com.mbox.gz"
} |
lkml_critique | netdev | This series refactors the ZL3073x chip variant handling and adds die
temperature reporting for chips that support it.
Patch 1 replaces the five per-variant chip_info structures and their
exported symbols with a single consolidated lookup table. The chip
variant is now detected at runtime from the chip ID register rat... | null | null | null | [PATCH net-next 0/2] dpll: zl3073x: consolidate chip info and add temperature reporting | Some zl3073x chip variants (0x1Exx, 0x2Exx and 0x3FC4) provide a die
temperature status register with 0.1 C resolution.
Add a ZL3073X_FLAG_DIE_TEMP chip flag to identify these variants and
implement zl3073x_dpll_temp_get() as the dpll_device_ops.temp_get
callback. The register value is converted from 0.1 C units to
mi... | {
"author": "Ivan Vecera <ivecera@redhat.com>",
"date": "Fri, 27 Feb 2026 11:53:00 +0100",
"is_openbsd": false,
"thread_id": "20260227105300.710272-3-ivecera@redhat.com.mbox.gz"
} |
lkml_critique | netdev | From: Alice Mikityanska <alice@isovalent.com>
This series is a follow-up to "BIG TCP without HBH in IPv6", and it adds
support for BIG TCP IPv4/IPv6 workloads in vxlan and geneve. Now that
IPv6 BIG TCP doesn't require stripping the HBH in all various
combinations in tunneled traffic, adding BIG TCP becomes feasible.
... | null | null | null | [PATCH net-next v2 00/12] BIG TCP for UDP tunnels | From: Alice Mikityanska <alice@isovalent.com>
Similar to commit add641e7dee3 ("sched: act_csum: don't mangle TCP and
UDP GSO packets"), UDP tunnel GSO packets going through act_csum
shouldn't have their checksum calculated at this point, because it will
be done after segmentation. Setting the checksum in act_csum modi... | {
"author": "Alice Mikityanska <alice.kernel@fastmail.im>",
"date": "Thu, 26 Feb 2026 22:15:49 +0200",
"is_openbsd": false,
"thread_id": "20260226201600.222044-1-alice.kernel@fastmail.im.mbox.gz"
} |
lkml_critique | netdev | From: Alice Mikityanska <alice@isovalent.com>
This series is a follow-up to "BIG TCP without HBH in IPv6", and it adds
support for BIG TCP IPv4/IPv6 workloads in vxlan and geneve. Now that
IPv6 BIG TCP doesn't require stripping the HBH in all various
combinations in tunneled traffic, adding BIG TCP becomes feasible.
... | null | null | null | [PATCH net-next v2 00/12] BIG TCP for UDP tunnels | From: Alice Mikityanska <alice@isovalent.com>
Taking further the idea of commit b10b446ce7ad ("udp: gso: Use single
MSS length in UDP header for GSO_PARTIAL"), simplify the implementation
and fix the checksum (apparently ignored by hardware anyway).
The mentioned commit started using msslen for uh->len, but still use... | {
"author": "Alice Mikityanska <alice.kernel@fastmail.im>",
"date": "Thu, 26 Feb 2026 22:15:50 +0200",
"is_openbsd": false,
"thread_id": "20260226201600.222044-1-alice.kernel@fastmail.im.mbox.gz"
} |
lkml_critique | netdev | From: Alice Mikityanska <alice@isovalent.com>
This series is a follow-up to "BIG TCP without HBH in IPv6", and it adds
support for BIG TCP IPv4/IPv6 workloads in vxlan and geneve. Now that
IPv6 BIG TCP doesn't require stripping the HBH in all various
combinations in tunneled traffic, adding BIG TCP becomes feasible.
... | null | null | null | [PATCH net-next v2 00/12] BIG TCP for UDP tunnels | From: Alice Mikityanska <alice@isovalent.com>
GRO_LEGACY_MAX_SIZE = 65536; total_len being 65536 is too big to fit
into a u16. As can be seen in skb_gro_receive, packets bigger or equal
to gro_max_size (or GRO_LEGACY_MAX_SIZE) are dropped with -E2BIG. Apply
the same boundary to geneve_post_decap_hint to avoid writing ... | {
"author": "Alice Mikityanska <alice.kernel@fastmail.im>",
"date": "Thu, 26 Feb 2026 22:15:51 +0200",
"is_openbsd": false,
"thread_id": "20260226201600.222044-1-alice.kernel@fastmail.im.mbox.gz"
} |
lkml_critique | netdev | From: Alice Mikityanska <alice@isovalent.com>
This series is a follow-up to "BIG TCP without HBH in IPv6", and it adds
support for BIG TCP IPv4/IPv6 workloads in vxlan and geneve. Now that
IPv6 BIG TCP doesn't require stripping the HBH in all various
combinations in tunneled traffic, adding BIG TCP becomes feasible.
... | null | null | null | [PATCH net-next v2 00/12] BIG TCP for UDP tunnels | From: Alice Mikityanska <alice@isovalent.com>
Since BIG TCP for UDP tunnels will start using len=0 in the UDP header
as an indicator of a GSO packet bigger than 65535 bytes, this commit
introduces the following getter and setters to use tree-wide, in order
to explicitly mark places where len=0 may be expected, and han... | {
"author": "Alice Mikityanska <alice.kernel@fastmail.im>",
"date": "Thu, 26 Feb 2026 22:15:52 +0200",
"is_openbsd": false,
"thread_id": "20260226201600.222044-1-alice.kernel@fastmail.im.mbox.gz"
} |
lkml_critique | netdev | From: Alice Mikityanska <alice@isovalent.com>
This series is a follow-up to "BIG TCP without HBH in IPv6", and it adds
support for BIG TCP IPv4/IPv6 workloads in vxlan and geneve. Now that
IPv6 BIG TCP doesn't require stripping the HBH in all various
combinations in tunneled traffic, adding BIG TCP becomes feasible.
... | null | null | null | [PATCH net-next v2 00/12] BIG TCP for UDP tunnels | From: Alice Mikityanska <alice@isovalent.com>
skb_segment is called for partial GSO, when netif_needs_gso returns true
in validate_xmit_skb. Partial GSO is needed, for example, when
segmentation of tunneled traffic is offloaded to a NIC that only
supports inner checksum offload.
Currently, skb_segment clamps the segm... | {
"author": "Alice Mikityanska <alice.kernel@fastmail.im>",
"date": "Thu, 26 Feb 2026 22:15:53 +0200",
"is_openbsd": false,
"thread_id": "20260226201600.222044-1-alice.kernel@fastmail.im.mbox.gz"
} |
lkml_critique | netdev | From: Alice Mikityanska <alice@isovalent.com>
This series is a follow-up to "BIG TCP without HBH in IPv6", and it adds
support for BIG TCP IPv4/IPv6 workloads in vxlan and geneve. Now that
IPv6 BIG TCP doesn't require stripping the HBH in all various
combinations in tunneled traffic, adding BIG TCP becomes feasible.
... | null | null | null | [PATCH net-next v2 00/12] BIG TCP for UDP tunnels | From: Alice Mikityanska <alice@isovalent.com>
Currently, gro_max_size and gro_ipv4_max_size can be set to values
bigger than 65536, and GRO will happily aggregate UDP to the configured
size (for example, with TCP traffic in VXLAN tunnels). However,
udp_gro_complete uses the 16-bit length field in the UDP header to sto... | {
"author": "Alice Mikityanska <alice.kernel@fastmail.im>",
"date": "Thu, 26 Feb 2026 22:15:54 +0200",
"is_openbsd": false,
"thread_id": "20260226201600.222044-1-alice.kernel@fastmail.im.mbox.gz"
} |
lkml_critique | netdev | From: Alice Mikityanska <alice@isovalent.com>
This series is a follow-up to "BIG TCP without HBH in IPv6", and it adds
support for BIG TCP IPv4/IPv6 workloads in vxlan and geneve. Now that
IPv6 BIG TCP doesn't require stripping the HBH in all various
combinations in tunneled traffic, adding BIG TCP becomes feasible.
... | null | null | null | [PATCH net-next v2 00/12] BIG TCP for UDP tunnels | From: Alice Mikityanska <alice@isovalent.com>
Wherever a GSO packet can occur, and its length is used to fill the UDP
header, use udp_set_len that assigns 0 if the length doesn't fit 16
bits, so that the packet can be properly parsed and segmented later,
instead of having truncated length.
Signed-off-by: Alice Mikity... | {
"author": "Alice Mikityanska <alice.kernel@fastmail.im>",
"date": "Thu, 26 Feb 2026 22:15:55 +0200",
"is_openbsd": false,
"thread_id": "20260226201600.222044-1-alice.kernel@fastmail.im.mbox.gz"
} |
lkml_critique | netdev | From: Alice Mikityanska <alice@isovalent.com>
This series is a follow-up to "BIG TCP without HBH in IPv6", and it adds
support for BIG TCP IPv4/IPv6 workloads in vxlan and geneve. Now that
IPv6 BIG TCP doesn't require stripping the HBH in all various
combinations in tunneled traffic, adding BIG TCP becomes feasible.
... | null | null | null | [PATCH net-next v2 00/12] BIG TCP for UDP tunnels | From: Alice Mikityanska <alice@isovalent.com>
In the previous commit we started using uh->len = 0 as a marker of a GRO
packet bigger than 65536 bytes. To prevent abuse by maliciously crafted
packets, check the length in the UDP header in udp_gro_receive.
Note that a similar check was present in udp_gro_receive_segmen... | {
"author": "Alice Mikityanska <alice.kernel@fastmail.im>",
"date": "Thu, 26 Feb 2026 22:15:56 +0200",
"is_openbsd": false,
"thread_id": "20260226201600.222044-1-alice.kernel@fastmail.im.mbox.gz"
} |
lkml_critique | netdev | From: Alice Mikityanska <alice@isovalent.com>
This series is a follow-up to "BIG TCP without HBH in IPv6", and it adds
support for BIG TCP IPv4/IPv6 workloads in vxlan and geneve. Now that
IPv6 BIG TCP doesn't require stripping the HBH in all various
combinations in tunneled traffic, adding BIG TCP becomes feasible.
... | null | null | null | [PATCH net-next v2 00/12] BIG TCP for UDP tunnels | From: Alice Mikityanska <alice@isovalent.com>
skb->len may be bigger than 65535 in UDP-based tunnels that have BIG TCP
enabled. If GSO aggregates packets that large, set the length in the UDP
header to 0, so that tcpdump can print such packets properly (treating
them as RFC 2675 jumbograms). Later in the pipeline, __u... | {
"author": "Alice Mikityanska <alice.kernel@fastmail.im>",
"date": "Thu, 26 Feb 2026 22:15:57 +0200",
"is_openbsd": false,
"thread_id": "20260226201600.222044-1-alice.kernel@fastmail.im.mbox.gz"
} |
lkml_critique | netdev | From: Alice Mikityanska <alice@isovalent.com>
This series is a follow-up to "BIG TCP without HBH in IPv6", and it adds
support for BIG TCP IPv4/IPv6 workloads in vxlan and geneve. Now that
IPv6 BIG TCP doesn't require stripping the HBH in all various
combinations in tunneled traffic, adding BIG TCP becomes feasible.
... | null | null | null | [PATCH net-next v2 00/12] BIG TCP for UDP tunnels | From: Alice Mikityanska <alice@isovalent.com>
In Cilium we do support BIG TCP, but so far the latter has only been
enabled for direct routing use-cases. A lot of users rely on Cilium
with vxlan/geneve tunneling though. The underlying kernel infra for
tunneling has not been supporting BIG TCP up to this point.
Given w... | {
"author": "Alice Mikityanska <alice.kernel@fastmail.im>",
"date": "Thu, 26 Feb 2026 22:15:58 +0200",
"is_openbsd": false,
"thread_id": "20260226201600.222044-1-alice.kernel@fastmail.im.mbox.gz"
} |
lkml_critique | netdev | From: Alice Mikityanska <alice@isovalent.com>
This series is a follow-up to "BIG TCP without HBH in IPv6", and it adds
support for BIG TCP IPv4/IPv6 workloads in vxlan and geneve. Now that
IPv6 BIG TCP doesn't require stripping the HBH in all various
combinations in tunneled traffic, adding BIG TCP becomes feasible.
... | null | null | null | [PATCH net-next v2 00/12] BIG TCP for UDP tunnels | From: Alice Mikityanska <alice@isovalent.com>
From: Daniel Borkmann <daniel@iogearbox.net>
In Cilium we do support BIG TCP, but so far the latter has only been
enabled for direct routing use-cases. A lot of users rely on Cilium
with vxlan/geneve tunneling though. The underlying kernel infra for
tunneling has not been... | {
"author": "Alice Mikityanska <alice.kernel@fastmail.im>",
"date": "Thu, 26 Feb 2026 22:15:59 +0200",
"is_openbsd": false,
"thread_id": "20260226201600.222044-1-alice.kernel@fastmail.im.mbox.gz"
} |
lkml_critique | netdev | From: Alice Mikityanska <alice@isovalent.com>
This series is a follow-up to "BIG TCP without HBH in IPv6", and it adds
support for BIG TCP IPv4/IPv6 workloads in vxlan and geneve. Now that
IPv6 BIG TCP doesn't require stripping the HBH in all various
combinations in tunneled traffic, adding BIG TCP becomes feasible.
... | null | null | null | [PATCH net-next v2 00/12] BIG TCP for UDP tunnels | From: Alice Mikityanska <alice@isovalent.com>
The test sets up VXLAN and GENEVE tunnels over IPv4 and IPv6 and runs
IPv4 and IPv6 traffic through them with BIG TCP enabled. It checks that
a non-negligible amount of big aggregated packets are seen in tcpdump.
Signed-off-by: Alice Mikityanska <alice@isovalent.com>
---
... | {
"author": "Alice Mikityanska <alice.kernel@fastmail.im>",
"date": "Thu, 26 Feb 2026 22:16:00 +0200",
"is_openbsd": false,
"thread_id": "20260226201600.222044-1-alice.kernel@fastmail.im.mbox.gz"
} |
lkml_critique | netdev | From: Alice Mikityanska <alice@isovalent.com>
This series is a follow-up to "BIG TCP without HBH in IPv6", and it adds
support for BIG TCP IPv4/IPv6 workloads in vxlan and geneve. Now that
IPv6 BIG TCP doesn't require stripping the HBH in all various
combinations in tunneled traffic, adding BIG TCP becomes feasible.
... | null | null | null | [PATCH net-next v2 00/12] BIG TCP for UDP tunnels | On Thu, 26 Feb 2026 at 22:16, Alice Mikityanska
<alice.kernel@fastmail.im> wrote:
I went over all usages of uh->len.
I think, last time I missed the fraglist case in udp4_gro_complete,
where we should use udp_set_len too. I chose places where udp_set_len is
necessary, according to my best discretion. In addition to U... | {
"author": "Alice Mikityanska <alice@isovalent.com>",
"date": "Thu, 26 Feb 2026 22:19:16 +0200",
"is_openbsd": false,
"thread_id": "20260226201600.222044-1-alice.kernel@fastmail.im.mbox.gz"
} |
lkml_critique | netdev | From: Alice Mikityanska <alice@isovalent.com>
This series is a follow-up to "BIG TCP without HBH in IPv6", and it adds
support for BIG TCP IPv4/IPv6 workloads in vxlan and geneve. Now that
IPv6 BIG TCP doesn't require stripping the HBH in all various
combinations in tunneled traffic, adding BIG TCP becomes feasible.
... | null | null | null | [PATCH net-next v2 00/12] BIG TCP for UDP tunnels | On Thu, 26 Feb 2026 at 22:16, Alice Mikityanska
<alice.kernel@fastmail.im> wrote:
Paolo, when I was looking at the surrounding code, I got a question
about your patch [1].
len = skb->len - gro_hint->nested_nh_offset;
This len is calculated as pseudo header len for checksum purposes. The
pseudo header len includes th... | {
"author": "Alice Mikityanska <alice@isovalent.com>",
"date": "Thu, 26 Feb 2026 22:20:16 +0200",
"is_openbsd": false,
"thread_id": "20260226201600.222044-1-alice.kernel@fastmail.im.mbox.gz"
} |
lkml_critique | netdev | From: Alice Mikityanska <alice@isovalent.com>
This series is a follow-up to "BIG TCP without HBH in IPv6", and it adds
support for BIG TCP IPv4/IPv6 workloads in vxlan and geneve. Now that
IPv6 BIG TCP doesn't require stripping the HBH in all various
combinations in tunneled traffic, adding BIG TCP becomes feasible.
... | null | null | null | [PATCH net-next v2 00/12] BIG TCP for UDP tunnels | On Thu, 26 Feb 2026 22:16:00 +0200 Alice Mikityanska wrote:
I'm assuming you want to suppress both stdout and stderr?
shellcheck points out this won't work, then. 2>&1 has to be last
--
pw-bot: cr | {
"author": "Jakub Kicinski <kuba@kernel.org>",
"date": "Thu, 26 Feb 2026 17:30:36 -0800",
"is_openbsd": false,
"thread_id": "20260226201600.222044-1-alice.kernel@fastmail.im.mbox.gz"
} |
lkml_critique | netdev | From: Alice Mikityanska <alice@isovalent.com>
This series is a follow-up to "BIG TCP without HBH in IPv6", and it adds
support for BIG TCP IPv4/IPv6 workloads in vxlan and geneve. Now that
IPv6 BIG TCP doesn't require stripping the HBH in all various
combinations in tunneled traffic, adding BIG TCP becomes feasible.
... | null | null | null | [PATCH net-next v2 00/12] BIG TCP for UDP tunnels | On Fri, 27 Feb 2026 at 03:30, Jakub Kicinski <kuba@kernel.org> wrote:
I think I only wanted to suppress stdout (speed stats, etc.), but
still see any possible errors from stderr. To be honest, I don't
remember why I had the stderr>stdout redirect then (I see I don't have
it with the netperf client). Thanks for pointin... | {
"author": "Alice Mikityanska <alice@isovalent.com>",
"date": "Fri, 27 Feb 2026 11:35:30 +0200",
"is_openbsd": false,
"thread_id": "20260226201600.222044-1-alice.kernel@fastmail.im.mbox.gz"
} |
lkml_critique | netdev | Add initial support for ethernet controller of the Spacemit K3 SoC.
This ethernet controller is almost a standard Synopsys DesignWare
MAC (version 5.40a). This controller require a syscon device to
configure some basic features, like interface type and internal delay.
Change from v4:
- https://lore.kernel.org/netdev/2... | null | null | null | [PATCH net-next v5 0/3] riscv: spacemit: Add ethernet support for K3 | The GMAC IP on Spacemit K3 is almost a standard Synopsys DesignWare
MAC (version 5.40a) with some extra clock.
Add necessary compatible string for this device.
Signed-off-by: Inochi Amaoto <inochiama@gmail.com>
Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
---
.../devicetree/bindings/net/snps,dwmac.yaml | 2 +... | {
"author": "Inochi Amaoto <inochiama@gmail.com>",
"date": "Fri, 27 Feb 2026 15:57:15 +0800",
"is_openbsd": false,
"thread_id": "20260227075718.2243818-1-inochiama@gmail.com.mbox.gz"
} |
lkml_critique | netdev | Add initial support for ethernet controller of the Spacemit K3 SoC.
This ethernet controller is almost a standard Synopsys DesignWare
MAC (version 5.40a). This controller require a syscon device to
configure some basic features, like interface type and internal delay.
Change from v4:
- https://lore.kernel.org/netdev/2... | null | null | null | [PATCH net-next v5 0/3] riscv: spacemit: Add ethernet support for K3 | Add compatible string for 5.40a version that can avoid to define some
platform data in the glue layer.
Signed-off-by: Inochi Amaoto <inochiama@gmail.com>
---
drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c ... | {
"author": "Inochi Amaoto <inochiama@gmail.com>",
"date": "Fri, 27 Feb 2026 15:57:16 +0800",
"is_openbsd": false,
"thread_id": "20260227075718.2243818-1-inochiama@gmail.com.mbox.gz"
} |
lkml_critique | netdev | Add initial support for ethernet controller of the Spacemit K3 SoC.
This ethernet controller is almost a standard Synopsys DesignWare
MAC (version 5.40a). This controller require a syscon device to
configure some basic features, like interface type and internal delay.
Change from v4:
- https://lore.kernel.org/netdev/2... | null | null | null | [PATCH net-next v5 0/3] riscv: spacemit: Add ethernet support for K3 | The ethernet controller on Spacemit K3 SoC is Synopsys DesignWare
MAC (version 5.40a), with the following special points:
1. The rate of the tx clock line is auto changed when the mac speed
rate is changed, and no need for changing the input tx clock.
2. This controller require a extra syscon device to configure the... | {
"author": "Inochi Amaoto <inochiama@gmail.com>",
"date": "Fri, 27 Feb 2026 15:57:17 +0800",
"is_openbsd": false,
"thread_id": "20260227075718.2243818-1-inochiama@gmail.com.mbox.gz"
} |
lkml_critique | netdev | From: Zefir Kurtisi <zefir.kurtisi@westermo.com>
The fsl_enetc driver experiences soft-IRQ storms on LS1028A systems
where up to 500k interrupts/sec are generated, completely saturating
one CPU core. When running with a single core, this causes watchdog
timeouts and system reboots.
Root cause:
The driver was writing ... | null | null | null | [PATCH] net: enetc: fix sirq-storm by clearing IDR registers | Hi Zefir,
On Fri, Feb 20, 2026 at 02:29:30PM +0100, Zefir Kurtisi wrote:
Thank you for your patch and for debugging.
I am not sure whether your interpretation of the documentation is
correct. I have asked a colleague familiar with the hardware design and
will come back when I am 100% sure.
Superficially, I believe ... | {
"author": "Vladimir Oltean <vladimir.oltean@nxp.com>",
"date": "Mon, 23 Feb 2026 18:32:27 +0200",
"is_openbsd": false,
"thread_id": "53f850f9-8f05-49ba-9247-ef2f823cc2b2@gmail.com.mbox.gz"
} |
lkml_critique | netdev | From: Zefir Kurtisi <zefir.kurtisi@westermo.com>
The fsl_enetc driver experiences soft-IRQ storms on LS1028A systems
where up to 500k interrupts/sec are generated, completely saturating
one CPU core. When running with a single core, this causes watchdog
timeouts and system reboots.
Root cause:
The driver was writing ... | null | null | null | [PATCH] net: enetc: fix sirq-storm by clearing IDR registers | On Mon, Feb 23, 2026 at 06:32:27PM +0200, Vladimir Oltean wrote:
I got confirmation that clearing ring interrupts through the
SITXIDR/SIRXIDR registers is fine, which is contrary to the main claim
of this patch. | {
"author": "Vladimir Oltean <vladimir.oltean@nxp.com>",
"date": "Thu, 26 Feb 2026 14:00:58 +0200",
"is_openbsd": false,
"thread_id": "53f850f9-8f05-49ba-9247-ef2f823cc2b2@gmail.com.mbox.gz"
} |
lkml_critique | netdev | From: Zefir Kurtisi <zefir.kurtisi@westermo.com>
The fsl_enetc driver experiences soft-IRQ storms on LS1028A systems
where up to 500k interrupts/sec are generated, completely saturating
one CPU core. When running with a single core, this causes watchdog
timeouts and system reboots.
Root cause:
The driver was writing ... | null | null | null | [PATCH] net: enetc: fix sirq-storm by clearing IDR registers | Hi Vladimir,
On 2/23/26 17:32, Vladimir Oltean wrote:
Thank you for the feedback and clarifications.
The statement that SITXIDR/SIRXIDR bits are directly linked to
TBaIDR/RBaIDR is missing in the reference manual, i.e. it states that
the former represent a summary of the latter, but not that W1C-ing the
bits in S... | {
"author": "Zefir Kurtisi <zefir.kurtisi@gmail.com>",
"date": "Thu, 26 Feb 2026 20:28:53 +0100",
"is_openbsd": false,
"thread_id": "53f850f9-8f05-49ba-9247-ef2f823cc2b2@gmail.com.mbox.gz"
} |
lkml_critique | netdev | From: Zefir Kurtisi <zefir.kurtisi@westermo.com>
The fsl_enetc driver experiences soft-IRQ storms on LS1028A systems
where up to 500k interrupts/sec are generated, completely saturating
one CPU core. When running with a single core, this causes watchdog
timeouts and system reboots.
Root cause:
The driver was writing ... | null | null | null | [PATCH] net: enetc: fix sirq-storm by clearing IDR registers | On Thu, Feb 26, 2026 at 08:28:53PM +0100, Zefir Kurtisi wrote:
If I understand correctly, this patch should resolve your issue?
From: Vladimir Oltean <vladimir.oltean@nxp.com>
Date: Thu, 26 Feb 2026 21:50:13 +0200
Subject: [PATCH] net: enetc: avoid sending too short Ethernet frames
Signed-off-by: Vladimir Oltean <vl... | {
"author": "Vladimir Oltean <vladimir.oltean@nxp.com>",
"date": "Thu, 26 Feb 2026 21:51:58 +0200",
"is_openbsd": false,
"thread_id": "53f850f9-8f05-49ba-9247-ef2f823cc2b2@gmail.com.mbox.gz"
} |
lkml_critique | netdev | From: Zefir Kurtisi <zefir.kurtisi@westermo.com>
The fsl_enetc driver experiences soft-IRQ storms on LS1028A systems
where up to 500k interrupts/sec are generated, completely saturating
one CPU core. When running with a single core, this causes watchdog
timeouts and system reboots.
Root cause:
The driver was writing ... | null | null | null | [PATCH] net: enetc: fix sirq-storm by clearing IDR registers | On 2/26/26 20:51, Vladimir Oltean wrote:
Hi Vladimir,
yes, that fixes it.
I expected identifying invalid frames with all corner-cases to be
difficult, not realizing that making them valid is way easier. Thank you
for that insight.
Tested-by: Zefir Kurtisi <zefir.kurtisi@westermo.com>
While I was debugging the i... | {
"author": "Zefir Kurtisi <zefir.kurtisi@gmail.com>",
"date": "Fri, 27 Feb 2026 12:28:17 +0100",
"is_openbsd": false,
"thread_id": "53f850f9-8f05-49ba-9247-ef2f823cc2b2@gmail.com.mbox.gz"
} |
lkml_critique | netdev | From: Zefir Kurtisi <zefir.kurtisi@westermo.com>
The fsl_enetc driver experiences soft-IRQ storms on LS1028A systems
where up to 500k interrupts/sec are generated, completely saturating
one CPU core. When running with a single core, this causes watchdog
timeouts and system reboots.
Root cause:
The driver was writing ... | null | null | null | [PATCH] net: enetc: fix sirq-storm by clearing IDR registers | On Fri, Feb 27, 2026 at 12:28:17PM +0100, Zefir Kurtisi wrote:
We'll perform our own investigation of what is happening when
transmitting short frames. It will take some time.
But I'm not sure I understand what you mean about processing a BD ring
when its interrupt is active. NAPI (Documentation/networking/napi.rst)
... | {
"author": "Vladimir Oltean <vladimir.oltean@nxp.com>",
"date": "Fri, 27 Feb 2026 13:57:08 +0200",
"is_openbsd": false,
"thread_id": "53f850f9-8f05-49ba-9247-ef2f823cc2b2@gmail.com.mbox.gz"
} |
lkml_critique | netdev | From: Zefir Kurtisi <zefir.kurtisi@westermo.com>
The fsl_enetc driver experiences soft-IRQ storms on LS1028A systems
where up to 500k interrupts/sec are generated, completely saturating
one CPU core. When running with a single core, this causes watchdog
timeouts and system reboots.
Root cause:
The driver was writing ... | null | null | null | [PATCH] net: enetc: fix sirq-storm by clearing IDR registers | On 2/27/26 12:57, Vladimir Oltean wrote:
The change proposed does in no way change how and when interrupts are
re-enabled or NAPI is re-scheduled. What it does is:
assume there are completed RX frames, but no completed TX frames:
SIRXIDR=0x0001, SITXIDR=0x0000
enetc_poll today does:
* enetc_clean_tx_ring(0) -> nop
... | {
"author": "Zefir Kurtisi <zefir.kurtisi@gmail.com>",
"date": "Fri, 27 Feb 2026 14:03:54 +0100",
"is_openbsd": false,
"thread_id": "53f850f9-8f05-49ba-9247-ef2f823cc2b2@gmail.com.mbox.gz"
} |
lkml_critique | netdev | The code was originally written using no_64bit_msi, which restricts the
device to 32-bit MSI addresses.
Since msi_addr_mask is introduced, use DMA_BIT_MASK(dma_bits) instead of
DMA_BIT_MASK(32) here for msi_addr_mask, describing the restriction more
precisely and allowing these devices to work on platforms with MSI
do... | null | null | null | [PATCH v4 3/4] drm/radeon: Raise msi_addr_mask to dma_bits | The code was originally written using no_64bit_msi, which restricts the
device to 32-bit MSI addresses.
Since msi_addr_mask is introduced, use DMA_BIT_MASK(dma_bits) instead of
DMA_BIT_MASK(32) here for msi_addr_mask, describing the restriction more
precisely and allowing these devices to work on platforms with MSI
do... | {
"author": "Vivian Wang <wangruikang@iscas.ac.cn>",
"date": "Thu, 29 Jan 2026 09:56:09 +0800",
"is_openbsd": false,
"thread_id": "6391499b-d665-466a-a4df-b3d0b4921e28@nvidia.com.mbox.gz"
} |
lkml_critique | netdev | The code was originally written using no_64bit_msi, which restricts the
device to 32-bit MSI addresses.
Since msi_addr_mask is introduced, use DMA_BIT_MASK(dma_bits) instead of
DMA_BIT_MASK(32) here for msi_addr_mask, describing the restriction more
precisely and allowing these devices to work on platforms with MSI
do... | null | null | null | [PATCH v4 3/4] drm/radeon: Raise msi_addr_mask to dma_bits | The Sophgo SG2042 is a cursed machine in more ways than one.
The one way relevant to this patch series is that its PCIe controller
has neither INTx nor a low-address MSI doorbell wired up. Instead, the
only usable MSI doorbell is a SoC one at 0x7030010300, which is above
the 32-bit limit.
Currently, the no_64bit_msi ... | {
"author": "Vivian Wang <wangruikang@iscas.ac.cn>",
"date": "Thu, 29 Jan 2026 09:56:05 +0800",
"is_openbsd": false,
"thread_id": "6391499b-d665-466a-a4df-b3d0b4921e28@nvidia.com.mbox.gz"
} |
lkml_critique | netdev | The code was originally written using no_64bit_msi, which restricts the
device to 32-bit MSI addresses.
Since msi_addr_mask is introduced, use DMA_BIT_MASK(dma_bits) instead of
DMA_BIT_MASK(32) here for msi_addr_mask, describing the restriction more
precisely and allowing these devices to work on platforms with MSI
do... | null | null | null | [PATCH v4 3/4] drm/radeon: Raise msi_addr_mask to dma_bits | Instead of a 32-bit/64-bit dichotomy, check the MSI address against
msi_addr_mask.
This allows platforms with an MSI doorbell address above the 32-bit
limit to work with devices without full 64-bit MSI address support, as
long as the doorbell is within the addressable range of MSI of the
device.
Reviewed-by: Thomas G... | {
"author": "Vivian Wang <wangruikang@iscas.ac.cn>",
"date": "Thu, 29 Jan 2026 09:56:07 +0800",
"is_openbsd": false,
"thread_id": "6391499b-d665-466a-a4df-b3d0b4921e28@nvidia.com.mbox.gz"
} |
lkml_critique | netdev | The code was originally written using no_64bit_msi, which restricts the
device to 32-bit MSI addresses.
Since msi_addr_mask is introduced, use DMA_BIT_MASK(dma_bits) instead of
DMA_BIT_MASK(32) here for msi_addr_mask, describing the restriction more
precisely and allowing these devices to work on platforms with MSI
do... | null | null | null | [PATCH v4 3/4] drm/radeon: Raise msi_addr_mask to dma_bits | Some PCI devices have PCI_MSI_FLAGS_64BIT in the MSI capability, but
implement less than 64 address bits. This breaks on platforms where such
a device is assigned an MSI address higher than what's reachable.
Currently, the no_64bit_msi bit is set for these devices, meaning that
only 32-bit MSI addresses are allowed fo... | {
"author": "Vivian Wang <wangruikang@iscas.ac.cn>",
"date": "Thu, 29 Jan 2026 09:56:06 +0800",
"is_openbsd": false,
"thread_id": "6391499b-d665-466a-a4df-b3d0b4921e28@nvidia.com.mbox.gz"
} |
lkml_critique | netdev | The code was originally written using no_64bit_msi, which restricts the
device to 32-bit MSI addresses.
Since msi_addr_mask is introduced, use DMA_BIT_MASK(dma_bits) instead of
DMA_BIT_MASK(32) here for msi_addr_mask, describing the restriction more
precisely and allowing these devices to work on platforms with MSI
do... | null | null | null | [PATCH v4 3/4] drm/radeon: Raise msi_addr_mask to dma_bits | On Thu, Jan 29 2026 at 09:56, Vivian Wang wrote:
I'm happy to take the first two right away.
I can pick up the driver specific ones as well if there are no
objections; they both have been looked at by the relevant maintainers
and they obviously depend on the first ones so they have either to go
together or postponed ... | {
"author": "Thomas Gleixner <tglx@kernel.org>",
"date": "Thu, 29 Jan 2026 22:51:12 +0100",
"is_openbsd": false,
"thread_id": "6391499b-d665-466a-a4df-b3d0b4921e28@nvidia.com.mbox.gz"
} |
lkml_critique | netdev | The code was originally written using no_64bit_msi, which restricts the
device to 32-bit MSI addresses.
Since msi_addr_mask is introduced, use DMA_BIT_MASK(dma_bits) instead of
DMA_BIT_MASK(32) here for msi_addr_mask, describing the restriction more
precisely and allowing these devices to work on platforms with MSI
do... | null | null | null | [PATCH v4 3/4] drm/radeon: Raise msi_addr_mask to dma_bits | Hello:
This series was applied to riscv/linux.git (fixes)
by Thomas Gleixner <tglx@kernel.org>:
On Thu, 29 Jan 2026 09:56:05 +0800 you wrote:
Here is the summary with links:
- [v4,1/4] PCI/MSI: Conservatively generalize no_64bit_msi into msi_addr_mask
https://git.kernel.org/riscv/c/386ced19e9a3
- [v4,2/4] PC... | {
"author": "patchwork-bot+linux-riscv@kernel.org",
"date": "Fri, 20 Feb 2026 04:10:40 +0000",
"is_openbsd": false,
"thread_id": "6391499b-d665-466a-a4df-b3d0b4921e28@nvidia.com.mbox.gz"
} |
lkml_critique | netdev | The code was originally written using no_64bit_msi, which restricts the
device to 32-bit MSI addresses.
Since msi_addr_mask is introduced, use DMA_BIT_MASK(dma_bits) instead of
DMA_BIT_MASK(32) here for msi_addr_mask, describing the restriction more
precisely and allowing these devices to work on platforms with MSI
do... | null | null | null | [PATCH v4 3/4] drm/radeon: Raise msi_addr_mask to dma_bits | On 29/01/2026 3:56, Vivian Wang wrote:
Hey Vivian,
We are seeing issues while reloading mlx5 on a PPC64 platform.
We see the following messages in dmesg:
mlx5_core 0000:00:08.0: mlx5_load:1266:(pid 1283): Failed to alloc IRQs
mlx5_core 0000:00:08.0: E-Switch: cleanup
mlx5_core 0000:00:08.0: probe_one:1959:(pid 1283)... | {
"author": "Mark Bloch <mbloch@nvidia.com>",
"date": "Thu, 26 Feb 2026 20:25:35 +0200",
"is_openbsd": false,
"thread_id": "6391499b-d665-466a-a4df-b3d0b4921e28@nvidia.com.mbox.gz"
} |
lkml_critique | netdev | The code was originally written using no_64bit_msi, which restricts the
device to 32-bit MSI addresses.
Since msi_addr_mask is introduced, use DMA_BIT_MASK(dma_bits) instead of
DMA_BIT_MASK(32) here for msi_addr_mask, describing the restriction more
precisely and allowing these devices to work on platforms with MSI
do... | null | null | null | [PATCH v4 3/4] drm/radeon: Raise msi_addr_mask to dma_bits | On 2/27/26 02:25, Mark Bloch wrote:
Mea culpa. There's a fix on the list [1] since last Friday. I'm not sure
why it hasn't moved yet, but please take a look.
Vivian "dramforever" Wang
[1]: https://lore.kernel.org/all/20260220070239.1693303-1-nilay@linux.ibm.com/ | {
"author": "Vivian Wang <wangruikang@iscas.ac.cn>",
"date": "Fri, 27 Feb 2026 13:25:03 +0800",
"is_openbsd": false,
"thread_id": "6391499b-d665-466a-a4df-b3d0b4921e28@nvidia.com.mbox.gz"
} |
lkml_critique | netdev | The code was originally written using no_64bit_msi, which restricts the
device to 32-bit MSI addresses.
Since msi_addr_mask is introduced, use DMA_BIT_MASK(dma_bits) instead of
DMA_BIT_MASK(32) here for msi_addr_mask, describing the restriction more
precisely and allowing these devices to work on platforms with MSI
do... | null | null | null | [PATCH v4 3/4] drm/radeon: Raise msi_addr_mask to dma_bits | On 27/02/2026 7:25, Vivian Wang wrote:
Thanks! I've looked at the patch, it seems fine and should fix the issue we
are seeing.
Mark | {
"author": "Mark Bloch <mbloch@nvidia.com>",
"date": "Fri, 27 Feb 2026 10:16:00 +0200",
"is_openbsd": false,
"thread_id": "6391499b-d665-466a-a4df-b3d0b4921e28@nvidia.com.mbox.gz"
} |
lkml_critique | netdev | This series adds ethtool get/set support for the RSS hash key in the igb
driver.
- `ethtool -x <dev>` to display the RSS key
- `ethtool -X <dev> hkey <key>` to configure the RSS key
Without patch:
# ethtool -x $DEV | grep key -A1
RSS hash key:
Operation not supported
# ethtool -X $DEV hkey 00:00:00:00:00:00:00:00:00:... | null | null | null | [PATCH iwl-next v6 0/3] igb: add RSS key get/set support | Store the RSS key inside struct igb_adapter and introduce the
igb_write_rss_key() helper function. This allows the driver to program
the E1000 registers using a persistent RSS key, instead of using a
stack-local buffer in igb_setup_mrqc().
Reviewed-by: Simon Horman <horms@kernel.org>
Reviewed-by: Piotr Kwapulinski <pi... | {
"author": "Takashi Kozu <takkozu@amazon.com>",
"date": "Tue, 3 Feb 2026 21:54:11 +0900",
"is_openbsd": false,
"thread_id": "20260203125417.37285-8-takkozu@amazon.com.mbox.gz"
} |
lkml_critique | netdev | This series adds ethtool get/set support for the RSS hash key in the igb
driver.
- `ethtool -x <dev>` to display the RSS key
- `ethtool -X <dev> hkey <key>` to configure the RSS key
Without patch:
# ethtool -x $DEV | grep key -A1
RSS hash key:
Operation not supported
# ethtool -X $DEV hkey 00:00:00:00:00:00:00:00:00:... | null | null | null | [PATCH iwl-next v6 0/3] igb: add RSS key get/set support | Implement igb_get_rxfh_key_size() and extend
igb_get_rxfh() to return the RSS key to userspace.
This can be tested using `ethtool -x <dev>`.
Reviewed-by: Simon Horman <horms@kernel.org>
Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
Signed-off-by: Takashi Kozu <takkozu@amazon.com>
---
drivers/net/e... | {
"author": "Takashi Kozu <takkozu@amazon.com>",
"date": "Tue, 3 Feb 2026 21:54:12 +0900",
"is_openbsd": false,
"thread_id": "20260203125417.37285-8-takkozu@amazon.com.mbox.gz"
} |
lkml_critique | netdev | This series adds ethtool get/set support for the RSS hash key in the igb
driver.
- `ethtool -x <dev>` to display the RSS key
- `ethtool -X <dev> hkey <key>` to configure the RSS key
Without patch:
# ethtool -x $DEV | grep key -A1
RSS hash key:
Operation not supported
# ethtool -X $DEV hkey 00:00:00:00:00:00:00:00:00:... | null | null | null | [PATCH iwl-next v6 0/3] igb: add RSS key get/set support | Change igb_set_rxfh() to accept and save a userspace-provided
RSS key. When a key is provided, store it in the adapter and write the
E1000 registers accordingly.
This can be tested using `ethtool -X <dev> hkey <key>`.
Reviewed-by: Simon Horman <horms@kernel.org>
Signed-off-by: Takashi Kozu <takkozu@amazon.com>
---
d... | {
"author": "Takashi Kozu <takkozu@amazon.com>",
"date": "Tue, 3 Feb 2026 21:54:13 +0900",
"is_openbsd": false,
"thread_id": "20260203125417.37285-8-takkozu@amazon.com.mbox.gz"
} |
lkml_critique | netdev | This series adds ethtool get/set support for the RSS hash key in the igb
driver.
- `ethtool -x <dev>` to display the RSS key
- `ethtool -X <dev> hkey <key>` to configure the RSS key
Without patch:
# ethtool -x $DEV | grep key -A1
RSS hash key:
Operation not supported
# ethtool -X $DEV hkey 00:00:00:00:00:00:00:00:00:... | null | null | null | [PATCH iwl-next v6 0/3] igb: add RSS key get/set support | On Tue, 3 Feb 2026 21:54:13 +0900, Takashi Kozu wrote:
Tested-by: Kohei Enju <kohei@enjuk.jp>
The details of testing:
https://lore.kernel.org/intel-wired-lan/20260128072908.50245-1-kohei@enjuk.jp/ | {
"author": "Kohei Enju <kohei@enjuk.jp>",
"date": "Tue, 3 Feb 2026 13:52:49 +0000",
"is_openbsd": false,
"thread_id": "20260203125417.37285-8-takkozu@amazon.com.mbox.gz"
} |
lkml_critique | netdev | This series adds ethtool get/set support for the RSS hash key in the igb
driver.
- `ethtool -x <dev>` to display the RSS key
- `ethtool -X <dev> hkey <key>` to configure the RSS key
Without patch:
# ethtool -x $DEV | grep key -A1
RSS hash key:
Operation not supported
# ethtool -X $DEV hkey 00:00:00:00:00:00:00:00:00:... | null | null | null | [PATCH iwl-next v6 0/3] igb: add RSS key get/set support | igb_write_rss_key() helper function. This allows the driver to program the E1000 registers using a persistent RSS key, instead of using a stack-local buffer in igb_setup_mrqc().
Tested-by: Rinitha S <sx.rinitha@intel.com> (A Contingent worker at Intel) | {
"author": "\"Rinitha, SX\" <sx.rinitha@intel.com>",
"date": "Fri, 27 Feb 2026 09:53:44 +0000",
"is_openbsd": false,
"thread_id": "20260203125417.37285-8-takkozu@amazon.com.mbox.gz"
} |
lkml_critique | netdev | This series adds ethtool get/set support for the RSS hash key in the igb
driver.
- `ethtool -x <dev>` to display the RSS key
- `ethtool -X <dev> hkey <key>` to configure the RSS key
Without patch:
# ethtool -x $DEV | grep key -A1
RSS hash key:
Operation not supported
# ethtool -X $DEV hkey 00:00:00:00:00:00:00:00:00:... | null | null | null | [PATCH iwl-next v6 0/3] igb: add RSS key get/set support | igb_get_rxfh() to return the RSS key to userspace.
Tested-by: Rinitha S <sx.rinitha@intel.com> (A Contingent worker at Intel) | {
"author": "\"Rinitha, SX\" <sx.rinitha@intel.com>",
"date": "Fri, 27 Feb 2026 09:55:27 +0000",
"is_openbsd": false,
"thread_id": "20260203125417.37285-8-takkozu@amazon.com.mbox.gz"
} |
lkml_critique | netdev | Utilize READ_ONCE and WRITE_ONCE APIs to prevent compiler
optimization and reordering. Ensure IO queue OUT/IN_CNT
registers are flushed. Relocate IQ/OQ IN/OUT_CNTS updates
to occur before NAPI completion, and replace napi_complete
with napi_complete_done.
Vimlesh Kumar (4):
octeon_ep: Relocate counter updates before... | null | null | null | [PATCH net v2 0/4] avoid compiler and IQ/OQ reordering | Utilize READ_ONCE and WRITE_ONCE APIs for IO queue Tx/Rx
variable access to prevent compiler optimization and reordering.
Additionally, ensure IO queue OUT/IN_CNT registers are flushed
by performing a read-back after writing.
The compiler could reorder reads/writes to pkts_pending, last_pkt_count,
etc., causing stale ... | {
"author": "Vimlesh Kumar <vimleshk@marvell.com>",
"date": "Fri, 27 Feb 2026 09:13:58 +0000",
"is_openbsd": false,
"thread_id": "20260227091402.1773833-5-vimleshk@marvell.com.mbox.gz"
} |
lkml_critique | netdev | Utilize READ_ONCE and WRITE_ONCE APIs to prevent compiler
optimization and reordering. Ensure IO queue OUT/IN_CNT
registers are flushed. Relocate IQ/OQ IN/OUT_CNTS updates
to occur before NAPI completion, and replace napi_complete
with napi_complete_done.
Vimlesh Kumar (4):
octeon_ep: Relocate counter updates before... | null | null | null | [PATCH net v2 0/4] avoid compiler and IQ/OQ reordering | Utilize READ_ONCE and WRITE_ONCE APIs for IO queue Tx/Rx
variable access to prevent compiler optimization and reordering.
Additionally, ensure IO queue OUT/IN_CNT registers are flushed
by performing a read-back after writing.
The compiler could reorder reads/writes to pkts_pending, last_pkt_count,
etc., causing stale ... | {
"author": "Vimlesh Kumar <vimleshk@marvell.com>",
"date": "Fri, 27 Feb 2026 09:14:00 +0000",
"is_openbsd": false,
"thread_id": "20260227091402.1773833-5-vimleshk@marvell.com.mbox.gz"
} |
lkml_critique | netdev | Utilize READ_ONCE and WRITE_ONCE APIs to prevent compiler
optimization and reordering. Ensure IO queue OUT/IN_CNT
registers are flushed. Relocate IQ/OQ IN/OUT_CNTS updates
to occur before NAPI completion, and replace napi_complete
with napi_complete_done.
Vimlesh Kumar (4):
octeon_ep: Relocate counter updates before... | null | null | null | [PATCH net v2 0/4] avoid compiler and IQ/OQ reordering | Relocate IQ/OQ IN/OUT_CNTS updates to occur before NAPI completion,
and replace napi_complete with napi_complete_done.
Moving the IQ/OQ counter updates before napi_complete_done ensures
1. Counter registers are updated before re-enabling interrupts.
2. Prevents a race where new packets arrive but counters aren't prope... | {
"author": "Vimlesh Kumar <vimleshk@marvell.com>",
"date": "Fri, 27 Feb 2026 09:13:57 +0000",
"is_openbsd": false,
"thread_id": "20260227091402.1773833-5-vimleshk@marvell.com.mbox.gz"
} |
lkml_critique | netdev | Utilize READ_ONCE and WRITE_ONCE APIs to prevent compiler
optimization and reordering. Ensure IO queue OUT/IN_CNT
registers are flushed. Relocate IQ/OQ IN/OUT_CNTS updates
to occur before NAPI completion, and replace napi_complete
with napi_complete_done.
Vimlesh Kumar (4):
octeon_ep: Relocate counter updates before... | null | null | null | [PATCH net v2 0/4] avoid compiler and IQ/OQ reordering | Relocate IQ/OQ IN/OUT_CNTS updates to occur before NAPI completion.
Moving the IQ/OQ counter updates before napi_complete_done ensures
1. Counter registers are updated before re-enabling interrupts.
2. Prevents a race where new packets arrive but counters aren't properly
synchronized.
Fixes: 1cd3b407977c3 ("octeon_... | {
"author": "Vimlesh Kumar <vimleshk@marvell.com>",
"date": "Fri, 27 Feb 2026 09:13:59 +0000",
"is_openbsd": false,
"thread_id": "20260227091402.1773833-5-vimleshk@marvell.com.mbox.gz"
} |
lkml_critique | netdev | From: Cedric Jehasse <cedric.jehasse@luminex.be>
This patch adds partial Ternary Content Addressable Memory (TCAM) for
the mv88e6390 and mv88e6393 family of switches. TCAM entries allow the
switch to match the first 48 or 96 bytes of a frame and take actions on
matched frames.
This patch introduces a subset of the av... | null | null | null | [PATCH net-next v4] net: dsa: mv88e6xxx: Add partial support for
TCAM entries | This is an AI-generated review of your patch. The human sending this
email has considered the AI review valid, or at least plausible.
For local reproduction steps see https://netdev-ai.bots.linux.dev/ai-local.html
---
net: dsa: mv88e6xxx: Add partial support for TCAM entries
This patch adds partial Ternary Content Ad... | {
"author": "Jakub Kicinski <kuba@kernel.org>",
"date": "Thu, 26 Feb 2026 19:55:37 -0800",
"is_openbsd": false,
"thread_id": "f6885957-998c-4793-93a0-d3cf957ba702@lunn.ch.mbox.gz"
} |
lkml_critique | netdev | From: Cedric Jehasse <cedric.jehasse@luminex.be>
This patch adds partial Ternary Content Addressable Memory (TCAM) for
the mv88e6390 and mv88e6393 family of switches. TCAM entries allow the
switch to match the first 48 or 96 bytes of a frame and take actions on
matched frames.
This patch introduces a subset of the av... | null | null | null | [PATCH net-next v4] net: dsa: mv88e6xxx: Add partial support for
TCAM entries | Here's the reply i gave to the ai-review on the v3 version of the patch:
I don't think this is an issue. For entries that are successfully moved the
hw_idx points to the new index. And for entries that haven't successfully
moved it's still pointing to the old index. Hence the hw_idx field for every
list entry should st... | {
"author": "Cedric Jehasse <cedric.jehasse@luminex.be>",
"date": "Fri, 27 Feb 2026 09:44:54 +0000",
"is_openbsd": false,
"thread_id": "f6885957-998c-4793-93a0-d3cf957ba702@lunn.ch.mbox.gz"
} |
lkml_critique | netdev | From: Cedric Jehasse <cedric.jehasse@luminex.be>
This patch adds partial Ternary Content Addressable Memory (TCAM) for
the mv88e6390 and mv88e6393 family of switches. TCAM entries allow the
switch to match the first 48 or 96 bytes of a frame and take actions on
matched frames.
This patch introduces a subset of the av... | null | null | null | [PATCH net-next v4] net: dsa: mv88e6xxx: Add partial support for
TCAM entries | Can we get replies to previous versions of the patch series included
into the context that the AI is using to perform reviews? This has
been explained once as being safe.
Andrew | {
"author": "Andrew Lunn <andrew@lunn.ch>",
"date": "Fri, 27 Feb 2026 15:06:35 +0100",
"is_openbsd": false,
"thread_id": "f6885957-998c-4793-93a0-d3cf957ba702@lunn.ch.mbox.gz"
} |
lkml_critique | netdev | This series addresses several compiler warnings found when building the
kernel for RISC-V.
The first patch fixes unused variable warnings in the NFS client (including
nfs4proc and flexfilelayout) that occur in certain build configurations.
The second patch fixes a format-truncation warning in the MACB ethernet
driver... | null | null | null | [PATCH v4 0/2] Fix warnings for RISC-V builds | On Fri, Feb 27, 2026, at 10:26 AM, Sean Chang wrote:
Seems obviously good to me.
Reviewed-by: Chuck Lever <chuck.lever@oracle.com>
--
Chuck Lever | {
"author": "\"Chuck Lever\" <cel@kernel.org>",
"date": "Fri, 27 Feb 2026 10:58:26 -0500",
"is_openbsd": false,
"thread_id": "20260227152624.164964-1-seanwascoding@gmail.com.mbox.gz"
} |
lkml_critique | netdev | This series addresses several compiler warnings found when building the
kernel for RISC-V.
The first patch fixes unused variable warnings in the NFS client (including
nfs4proc and flexfilelayout) that occur in certain build configurations.
The second patch fixes a format-truncation warning in the MACB ethernet
driver... | null | null | null | [PATCH v4 0/2] Fix warnings for RISC-V builds | On Fri, Feb 27, 2026 at 11:26:23PM +0800, Sean Chang wrote:
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew | {
"author": "Andrew Lunn <andrew@lunn.ch>",
"date": "Fri, 27 Feb 2026 17:00:13 +0100",
"is_openbsd": false,
"thread_id": "20260227152624.164964-1-seanwascoding@gmail.com.mbox.gz"
} |
lkml_critique | netdev | BPF cgroup/sock_release hooks can be useful for performing cleanup,
map maintenance, or other bookkeeping when sockets are released. Cilium
uses cgroup/sock_release hooks to do just that, cleaning up maps keyed
by socket destination addresses. This works fine for TCP and connected
UDP sockets when they're closed gracef... | null | null | null | [PATCH net-next v1 0/2] Preserve UDP socket addresses on abort | Currently, udp_abort() invokes __udp_disconnect() which clears out
socket fields like inet_daddr and inet_dport. This makes fields like
dst_ip4, dst_ip6, and dst_port useless inside cgroup/sock_release BPF
hooks following an abort on a connected UDP socket, since they'll always
equal zero. This differs from the behavio... | {
"author": "Jordan Rife <jrife@google.com>",
"date": "Tue, 24 Feb 2026 19:04:45 +0000",
"is_openbsd": false,
"thread_id": "20260224190516.2102048-3-jrife@google.com.mbox.gz"
} |
lkml_critique | netdev | BPF cgroup/sock_release hooks can be useful for performing cleanup,
map maintenance, or other bookkeeping when sockets are released. Cilium
uses cgroup/sock_release hooks to do just that, cleaning up maps keyed
by socket destination addresses. This works fine for TCP and connected
UDP sockets when they're closed gracef... | null | null | null | [PATCH net-next v1 0/2] Preserve UDP socket addresses on abort | Ensure that sock_release hooks see the original dst_ip4, dst_ip6, and
dst_port values for connected UDP and TCP sockets following a socket
abort.
Signed-off-by: Jordan Rife <jrife@google.com>
---
.../bpf/prog_tests/sock_destroy_release.c | 135 ++++++++++++++++++
.../bpf/progs/sock_destroy_release.c | 5... | {
"author": "Jordan Rife <jrife@google.com>",
"date": "Tue, 24 Feb 2026 19:04:46 +0000",
"is_openbsd": false,
"thread_id": "20260224190516.2102048-3-jrife@google.com.mbox.gz"
} |
lkml_critique | netdev | BPF cgroup/sock_release hooks can be useful for performing cleanup,
map maintenance, or other bookkeeping when sockets are released. Cilium
uses cgroup/sock_release hooks to do just that, cleaning up maps keyed
by socket destination addresses. This works fine for TCP and connected
UDP sockets when they're closed gracef... | null | null | null | [PATCH net-next v1 0/2] Preserve UDP socket addresses on abort | This is an AI-generated review of your patch. The human sending this
email has considered the AI review valid, or at least plausible.
For local reproduction steps see https://netdev-ai.bots.linux.dev/ai-local.html
---
selftests/bpf: Ensure dst addr/port are preserved after socket abort
Ensure that sock_release hooks ... | {
"author": "Jakub Kicinski <kuba@kernel.org>",
"date": "Thu, 26 Feb 2026 19:36:58 -0800",
"is_openbsd": false,
"thread_id": "20260224190516.2102048-3-jrife@google.com.mbox.gz"
} |
lkml_critique | netdev | Expose the GEM MAC's EEE Low Power Idle hardware counters through
ethtool -S:
- rx_lpi_transitions: number of RX LPI entry events
- rx_lpi_time: cumulative time spent in RX LPI
- tx_lpi_transitions: number of TX LPI entry events (TXLPIEN 0->1)
- tx_lpi_time: cumulative time in TX LPI
These are clear-on-read hardware ... | null | null | null | [PATCH 2/5] net: cadence: macb: add EEE LPI statistics counters | Implement ethtool get_eee and set_eee operations for the Cadence GEM
MAC, delegating to phylink for PHY-level EEE negotiation state.
The MAC-level LPI control (TXLPIEN) is not manipulated directly in the
ethtool ops - phylink manages the full EEE lifecycle through the
mac_enable_tx_lpi / mac_disable_tx_lpi callbacks.
... | {
"author": "Nicolai Buchwitz <nb@tipi-net.de>",
"date": "Wed, 25 Feb 2026 10:15:57 +0100",
"is_openbsd": false,
"thread_id": "DGPTL3ER0WFH.FA79BTCTCWDO@bootlin.com.mbox.gz"
} |
lkml_critique | netdev | Expose the GEM MAC's EEE Low Power Idle hardware counters through
ethtool -S:
- rx_lpi_transitions: number of RX LPI entry events
- rx_lpi_time: cumulative time spent in RX LPI
- tx_lpi_transitions: number of TX LPI entry events (TXLPIEN 0->1)
- tx_lpi_time: cumulative time in TX LPI
These are clear-on-read hardware ... | null | null | null | [PATCH 2/5] net: cadence: macb: add EEE LPI statistics counters | Implement Energy Efficient Ethernet TX Low Power Idle using phylink's
managed EEE framework. The Cadence GEM MAC has no built-in idle timer
— TXLPIEN (NCR bit 19) immediately blocks all TX when set and the MAC
does NOT auto-wake — so the driver uses a software delayed_work timer
for idle detection.
The TX LPI lifecycl... | {
"author": "Nicolai Buchwitz <nb@tipi-net.de>",
"date": "Wed, 25 Feb 2026 10:15:56 +0100",
"is_openbsd": false,
"thread_id": "DGPTL3ER0WFH.FA79BTCTCWDO@bootlin.com.mbox.gz"
} |
lkml_critique | netdev | Expose the GEM MAC's EEE Low Power Idle hardware counters through
ethtool -S:
- rx_lpi_transitions: number of RX LPI entry events
- rx_lpi_time: cumulative time spent in RX LPI
- tx_lpi_transitions: number of TX LPI entry events (TXLPIEN 0->1)
- tx_lpi_time: cumulative time in TX LPI
These are clear-on-read hardware ... | null | null | null | [PATCH 2/5] net: cadence: macb: add EEE LPI statistics counters | Add Energy Efficient Ethernet (IEEE 802.3az) support to the Cadence GEM
(macb) driver using phylink's managed EEE framework. The GEM MAC has
hardware LPI registers but no built-in idle timer, so the driver
implements software-managed TX LPI using a delayed_work timer while
delegating EEE negotiation and ethtool state t... | {
"author": "Nicolai Buchwitz <nb@tipi-net.de>",
"date": "Wed, 25 Feb 2026 10:15:53 +0100",
"is_openbsd": false,
"thread_id": "DGPTL3ER0WFH.FA79BTCTCWDO@bootlin.com.mbox.gz"
} |
lkml_critique | netdev | Expose the GEM MAC's EEE Low Power Idle hardware counters through
ethtool -S:
- rx_lpi_transitions: number of RX LPI entry events
- rx_lpi_time: cumulative time spent in RX LPI
- tx_lpi_transitions: number of TX LPI entry events (TXLPIEN 0->1)
- tx_lpi_time: cumulative time in TX LPI
These are clear-on-read hardware ... | null | null | null | [PATCH 2/5] net: cadence: macb: add EEE LPI statistics counters | Add register and bitfield definitions for the Cadence GEM MAC's
IEEE 802.3az Energy Efficient Ethernet (EEE) support:
- LPI statistics counter registers (GEM_RXLPI, GEM_RXLPITIME,
GEM_TXLPI, GEM_TXLPITIME) at offsets 0x270-0x27c
- TX LPI enable bitfield (GEM_TXLPIEN) in the NCR register (bit 19),
which directly as... | {
"author": "Nicolai Buchwitz <nb@tipi-net.de>",
"date": "Wed, 25 Feb 2026 10:15:54 +0100",
"is_openbsd": false,
"thread_id": "DGPTL3ER0WFH.FA79BTCTCWDO@bootlin.com.mbox.gz"
} |
lkml_critique | netdev | Expose the GEM MAC's EEE Low Power Idle hardware counters through
ethtool -S:
- rx_lpi_transitions: number of RX LPI entry events
- rx_lpi_time: cumulative time spent in RX LPI
- tx_lpi_transitions: number of TX LPI entry events (TXLPIEN 0->1)
- tx_lpi_time: cumulative time in TX LPI
These are clear-on-read hardware ... | null | null | null | [PATCH 2/5] net: cadence: macb: add EEE LPI statistics counters | Enable IEEE 802.3az Energy Efficient Ethernet on the Raspberry Pi 5's
RP1 southbridge by adding MACB_CAPS_EEE to its platform config.
The RP1 contains a Cadence GEM_GXL MAC (revision 0x00070109) paired
with a Broadcom BCM54213PE PHY, both of which support EEE at
1000BASE-T and 100BASE-TX.
Signed-off-by: Nicolai Buchw... | {
"author": "Nicolai Buchwitz <nb@tipi-net.de>",
"date": "Wed, 25 Feb 2026 10:15:58 +0100",
"is_openbsd": false,
"thread_id": "DGPTL3ER0WFH.FA79BTCTCWDO@bootlin.com.mbox.gz"
} |
lkml_critique | netdev | Expose the GEM MAC's EEE Low Power Idle hardware counters through
ethtool -S:
- rx_lpi_transitions: number of RX LPI entry events
- rx_lpi_time: cumulative time spent in RX LPI
- tx_lpi_transitions: number of TX LPI entry events (TXLPIEN 0->1)
- tx_lpi_time: cumulative time in TX LPI
These are clear-on-read hardware ... | null | null | null | [PATCH 2/5] net: cadence: macb: add EEE LPI statistics counters | On 25.2.2026 10:15, Nicolai Buchwitz wrote:
Apologies for the missing subject prefix and version tags on this
series - should have been [PATCH net-next v3]. I'm still fairly new
to the kernel mailing list workflow and building up the muscle memory
around git-format-patch/send-email. I'll resend as v4 with the proper
t... | {
"author": "Nicolai Buchwitz <nb@tipi-net.de>",
"date": "Wed, 25 Feb 2026 11:56:28 +0100",
"is_openbsd": false,
"thread_id": "DGPTL3ER0WFH.FA79BTCTCWDO@bootlin.com.mbox.gz"
} |
lkml_critique | netdev | Expose the GEM MAC's EEE Low Power Idle hardware counters through
ethtool -S:
- rx_lpi_transitions: number of RX LPI entry events
- rx_lpi_time: cumulative time spent in RX LPI
- tx_lpi_transitions: number of TX LPI entry events (TXLPIEN 0->1)
- tx_lpi_time: cumulative time in TX LPI
These are clear-on-read hardware ... | null | null | null | [PATCH 2/5] net: cadence: macb: add EEE LPI statistics counters | Hello Nicolai,
On Wed Feb 25, 2026 at 10:15 AM CET, Nicolai Buchwitz wrote:
nit: could this patch be squashed into [3/5]?
Would the capability flag deserve to be added to any other compatible?
Thanks,
--
Théo Lebrun, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com | {
"author": "=?utf-8?q?Th=C3=A9o_Lebrun?= <theo.lebrun@bootlin.com>",
"date": "Wed, 25 Feb 2026 18:26:18 +0100",
"is_openbsd": false,
"thread_id": "DGPTL3ER0WFH.FA79BTCTCWDO@bootlin.com.mbox.gz"
} |
lkml_critique | netdev | Expose the GEM MAC's EEE Low Power Idle hardware counters through
ethtool -S:
- rx_lpi_transitions: number of RX LPI entry events
- rx_lpi_time: cumulative time spent in RX LPI
- tx_lpi_transitions: number of TX LPI entry events (TXLPIEN 0->1)
- tx_lpi_time: cumulative time in TX LPI
These are clear-on-read hardware ... | null | null | null | [PATCH 2/5] net: cadence: macb: add EEE LPI statistics counters | On Wed Feb 25, 2026 at 10:15 AM CET, Nicolai Buchwitz wrote:
[...]
[...]
Should this be protected by a bp->eee_active condition? It could go
in macb_tx_lpi_wake(). We avoid a spinlock acquire per xmit for most
platforms. Probably negligeable though.
For the full series:
Reviewed-by: Théo Lebrun <theo.lebrun@boot... | {
"author": "=?utf-8?q?Th=C3=A9o_Lebrun?= <theo.lebrun@bootlin.com>",
"date": "Wed, 25 Feb 2026 18:42:08 +0100",
"is_openbsd": false,
"thread_id": "DGPTL3ER0WFH.FA79BTCTCWDO@bootlin.com.mbox.gz"
} |
lkml_critique | netdev | Expose the GEM MAC's EEE Low Power Idle hardware counters through
ethtool -S:
- rx_lpi_transitions: number of RX LPI entry events
- rx_lpi_time: cumulative time spent in RX LPI
- tx_lpi_transitions: number of TX LPI entry events (TXLPIEN 0->1)
- tx_lpi_time: cumulative time in TX LPI
These are clear-on-read hardware ... | null | null | null | [PATCH 2/5] net: cadence: macb: add EEE LPI statistics counters | On Wed, Feb 25, 2026 at 06:42:08PM +0100, Tho Lebrun wrote:
It will read the register, find the bit clear, and then return if
EEE is already disabled.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last! | {
"author": "\"Russell King (Oracle)\" <linux@armlinux.org.uk>",
"date": "Wed, 25 Feb 2026 17:50:12 +0000",
"is_openbsd": false,
"thread_id": "DGPTL3ER0WFH.FA79BTCTCWDO@bootlin.com.mbox.gz"
} |
lkml_critique | netdev | Expose the GEM MAC's EEE Low Power Idle hardware counters through
ethtool -S:
- rx_lpi_transitions: number of RX LPI entry events
- rx_lpi_time: cumulative time spent in RX LPI
- tx_lpi_transitions: number of TX LPI entry events (TXLPIEN 0->1)
- tx_lpi_time: cumulative time in TX LPI
These are clear-on-read hardware ... | null | null | null | [PATCH 2/5] net: cadence: macb: add EEE LPI statistics counters | On Wed, 25 Feb 2026 18:26:18 +0100 Théo Lebrun wrote:
Maybe split into two in fact, the relevant part squashed into patch 2
and the rest in patch 3? | {
"author": "Jakub Kicinski <kuba@kernel.org>",
"date": "Wed, 25 Feb 2026 17:49:22 -0800",
"is_openbsd": false,
"thread_id": "DGPTL3ER0WFH.FA79BTCTCWDO@bootlin.com.mbox.gz"
} |
lkml_critique | netdev | Expose the GEM MAC's EEE Low Power Idle hardware counters through
ethtool -S:
- rx_lpi_transitions: number of RX LPI entry events
- rx_lpi_time: cumulative time spent in RX LPI
- tx_lpi_transitions: number of TX LPI entry events (TXLPIEN 0->1)
- tx_lpi_time: cumulative time in TX LPI
These are clear-on-read hardware ... | null | null | null | [PATCH 2/5] net: cadence: macb: add EEE LPI statistics counters | On 25.2.2026 18:32, Sai Krishna Gajula wrote:
[...]
The 50us delay is required by IEEE 802.3az. After clearing TXLPIEN the
PHY needs time to exit LPI and re-establish normal operation before the
MAC can transmit. This is defined as Tw_sys_tx - approximately 16.5us
for 1000BASE-T and 30us for 100BASE-TX. We use a con... | {
"author": "Nicolai Buchwitz <nb@tipi-net.de>",
"date": "Thu, 26 Feb 2026 09:01:03 +0100",
"is_openbsd": false,
"thread_id": "DGPTL3ER0WFH.FA79BTCTCWDO@bootlin.com.mbox.gz"
} |
lkml_critique | netdev | Expose the GEM MAC's EEE Low Power Idle hardware counters through
ethtool -S:
- rx_lpi_transitions: number of RX LPI entry events
- rx_lpi_time: cumulative time spent in RX LPI
- tx_lpi_transitions: number of TX LPI entry events (TXLPIEN 0->1)
- tx_lpi_time: cumulative time in TX LPI
These are clear-on-read hardware ... | null | null | null | [PATCH 2/5] net: cadence: macb: add EEE LPI statistics counters | On Wed Feb 25, 2026 at 6:50 PM CET, Russell King (Oracle) wrote:
Yes I agree with your sentence, sorry my point was unclear. I was not
describing a bug but rather a performance optimisation.
We would look up bp->eee_active to know if we can avoid calling
macb_tx_lpi_set(), to avoid grabbing bp->lock once per xmit.
Th... | {
"author": "=?utf-8?q?Th=C3=A9o_Lebrun?= <theo.lebrun@bootlin.com>",
"date": "Thu, 26 Feb 2026 10:52:42 +0100",
"is_openbsd": false,
"thread_id": "DGPTL3ER0WFH.FA79BTCTCWDO@bootlin.com.mbox.gz"
} |
lkml_critique | netdev | Expose the GEM MAC's EEE Low Power Idle hardware counters through
ethtool -S:
- rx_lpi_transitions: number of RX LPI entry events
- rx_lpi_time: cumulative time spent in RX LPI
- tx_lpi_transitions: number of TX LPI entry events (TXLPIEN 0->1)
- tx_lpi_time: cumulative time in TX LPI
These are clear-on-read hardware ... | null | null | null | [PATCH 2/5] net: cadence: macb: add EEE LPI statistics counters | On 26.2.2026 10:52, Théo Lebrun wrote:
So you're suggesting to revert to the v2 approach?
https://patchwork.kernel.org/project/netdevbpf/patch/20260224091821.47671-4-nb@tipi-net.de/
Nicolai | {
"author": "Nicolai Buchwitz <nb@tipi-net.de>",
"date": "Thu, 26 Feb 2026 11:49:39 +0100",
"is_openbsd": false,
"thread_id": "DGPTL3ER0WFH.FA79BTCTCWDO@bootlin.com.mbox.gz"
} |
lkml_critique | netdev | Expose the GEM MAC's EEE Low Power Idle hardware counters through
ethtool -S:
- rx_lpi_transitions: number of RX LPI entry events
- rx_lpi_time: cumulative time spent in RX LPI
- tx_lpi_transitions: number of TX LPI entry events (TXLPIEN 0->1)
- tx_lpi_time: cumulative time in TX LPI
These are clear-on-read hardware ... | null | null | null | [PATCH 2/5] net: cadence: macb: add EEE LPI statistics counters | On Thu Feb 26, 2026 at 11:49 AM CET, Nicolai Buchwitz wrote:
I discovered this series at its V3.
It seems like I was suggesting a mix of both V2 & V3 approaches.
// V2 was:
static void macb_tx_lpi_wake(struct macb *bp)
{
if (!bp->eee_active)
return;
macb_tx_lpi_set(bp, false);
cancel_delayed_work(&bp->tx_lpi_wo... | {
"author": "=?utf-8?q?Th=C3=A9o_Lebrun?= <theo.lebrun@bootlin.com>",
"date": "Thu, 26 Feb 2026 14:50:42 +0100",
"is_openbsd": false,
"thread_id": "DGPTL3ER0WFH.FA79BTCTCWDO@bootlin.com.mbox.gz"
} |
lkml_critique | netdev | Expose the GEM MAC's EEE Low Power Idle hardware counters through
ethtool -S:
- rx_lpi_transitions: number of RX LPI entry events
- rx_lpi_time: cumulative time spent in RX LPI
- tx_lpi_transitions: number of TX LPI entry events (TXLPIEN 0->1)
- tx_lpi_time: cumulative time in TX LPI
These are clear-on-read hardware ... | null | null | null | [PATCH 2/5] net: cadence: macb: add EEE LPI statistics counters | On 26.2.2026 14:50, Théo Lebrun wrote:
Tthanks for testing! Since you have the hardware at hand, would you be
willing to add MACB_CAPS_EEE to eyeq5_config as well? I'm happy to
include it in the series if you can confirm it works correctly.
Nicolai | {
"author": "Nicolai Buchwitz <nb@tipi-net.de>",
"date": "Fri, 27 Feb 2026 10:00:57 +0100",
"is_openbsd": false,
"thread_id": "DGPTL3ER0WFH.FA79BTCTCWDO@bootlin.com.mbox.gz"
} |
lkml_critique | netdev | Expose the GEM MAC's EEE Low Power Idle hardware counters through
ethtool -S:
- rx_lpi_transitions: number of RX LPI entry events
- rx_lpi_time: cumulative time spent in RX LPI
- tx_lpi_transitions: number of TX LPI entry events (TXLPIEN 0->1)
- tx_lpi_time: cumulative time in TX LPI
These are clear-on-read hardware ... | null | null | null | [PATCH 2/5] net: cadence: macb: add EEE LPI statistics counters | Hello Nicolai,
On Fri Feb 27, 2026 at 10:00 AM CET, Nicolai Buchwitz wrote:
Tested-by: Théo Lebrun <theo.lebrun@bootlin.com>
Tested using a hardware loopback and a net namespace.
# ip netns add netns_eth1
# ip link set eth1 netns netns_eth1
# ip -n netns_eth1 a add 10.0.0.2/24 dev eth1
# ip -n netns_eth1 link set e... | {
"author": "=?utf-8?q?Th=C3=A9o_Lebrun?= <theo.lebrun@bootlin.com>",
"date": "Fri, 27 Feb 2026 15:39:09 +0100",
"is_openbsd": false,
"thread_id": "DGPTL3ER0WFH.FA79BTCTCWDO@bootlin.com.mbox.gz"
} |
lkml_critique | netdev | Let's say we bind() an UDP socket to the wildcard address with a
non-zero port, connect() it to an address, and disconnect it from
the address.
bind() sets SOCK_BINDPORT_LOCK on sk->sk_userlocks (but not
SOCK_BINDADDR_LOCK), and connect() calls udp_lib_hash4() to put
the socket into the 4-tuple hash table.
Then, __ud... | null | null | null | [PATCH v1 net] udp: Unhash auto-bound connected sk from 4-tuple hash
table when disconnected. | This is an AI-generated review of your patch. The human sending this
email has considered the AI review valid, or at least plausible.
For local reproduction steps see https://netdev-ai.bots.linux.dev/ai-local.html
---
udp: Unhash auto-bound connected sk from 4-tuple hash table when disconnected.
This commit fixes a b... | {
"author": "Jakub Kicinski <kuba@kernel.org>",
"date": "Thu, 26 Feb 2026 19:40:56 -0800",
"is_openbsd": false,
"thread_id": "20260225002709.156882-1-kuniyu@google.com.mbox.gz"
} |
lkml_critique | netdev | Let's say we bind() an UDP socket to the wildcard address with a
non-zero port, connect() it to an address, and disconnect it from
the address.
bind() sets SOCK_BINDPORT_LOCK on sk->sk_userlocks (but not
SOCK_BINDADDR_LOCK), and connect() calls udp_lib_hash4() to put
the socket into the 4-tuple hash table.
Then, __ud... | null | null | null | [PATCH v1 net] udp: Unhash auto-bound connected sk from 4-tuple hash
table when disconnected. | On Thu, Feb 26, 2026 at 7:40 PM Jakub Kicinski <kuba@kernel.org> wrote:
Exactly, this needs to be moved later.
Will fix it in v2.
Thanks! | {
"author": "Kuniyuki Iwashima <kuniyu@google.com>",
"date": "Thu, 26 Feb 2026 19:51:03 -0800",
"is_openbsd": false,
"thread_id": "20260225002709.156882-1-kuniyu@google.com.mbox.gz"
} |
lkml_critique | netdev | Fix some kernel-doc warnings in openvswitch.h:
Mark enum placeholders that are not used as "private" so that kernel-doc
comments are not needed for them.
Correct names for 2 enum values:
Warning: include/uapi/linux/openvswitch.h:300 Excess enum value
'@OVS_VPORT_UPCALL_SUCCESS' description in 'ovs_vport_upcall_attr'... | null | null | null | [PATCH -net] net: openvswitch: clean up some kernel-doc warnings | On 2/26/26 11:10 PM, Randy Dunlap wrote:
Hi, Randy. Thanks for the fixes!
If the private/public is the style to follow, it sounds good to me,
though there seem to be an inconsistency in how the kernel-only
attributes are marked. I see the OVS_SAMPLE_ATTR_ARG is in the
private section, but OVS_CHECK_PKT_LEN_ATTR_ARG... | {
"author": "Ilya Maximets <i.maximets@ovn.org>",
"date": "Thu, 26 Feb 2026 23:57:04 +0100",
"is_openbsd": false,
"thread_id": "c304a58d-2f07-4bdf-983f-9d92b13fdcbe@ovn.org.mbox.gz"
} |
lkml_critique | netdev | Fix some kernel-doc warnings in openvswitch.h:
Mark enum placeholders that are not used as "private" so that kernel-doc
comments are not needed for them.
Correct names for 2 enum values:
Warning: include/uapi/linux/openvswitch.h:300 Excess enum value
'@OVS_VPORT_UPCALL_SUCCESS' description in 'ovs_vport_upcall_attr'... | null | null | null | [PATCH -net] net: openvswitch: clean up some kernel-doc warnings | On Thu, 26 Feb 2026 14:10:54 -0800 Randy Dunlap wrote:
Hm, can't quickly grep the relevant guidance but I always thought that
the comment is supposed to pretend to be a label. IOW not be indented:
enum ovs_datapath_attr {
/* private: */
OVS_DP_ATTR_UNSPEC,
/* public: */
OVS_DP_ATTR_NAME, /* name of dp_ifindex... | {
"author": "Jakub Kicinski <kuba@kernel.org>",
"date": "Thu, 26 Feb 2026 16:56:29 -0800",
"is_openbsd": false,
"thread_id": "c304a58d-2f07-4bdf-983f-9d92b13fdcbe@ovn.org.mbox.gz"
} |
lkml_critique | netdev | Fix some kernel-doc warnings in openvswitch.h:
Mark enum placeholders that are not used as "private" so that kernel-doc
comments are not needed for them.
Correct names for 2 enum values:
Warning: include/uapi/linux/openvswitch.h:300 Excess enum value
'@OVS_VPORT_UPCALL_SUCCESS' description in 'ovs_vport_upcall_attr'... | null | null | null | [PATCH -net] net: openvswitch: clean up some kernel-doc warnings | On 2/26/26 4:56 PM, Jakub Kicinski wrote:
I don't think there is any relevant guidance unless you consider an example
in Documentation/doc-guide/kernel-doc.rst to be guidance, where the example
does agree with your comment.
But kernel-doc doesn't have any _requirement_ that these comments begin
in column 1.
--
~Ra... | {
"author": "Randy Dunlap <rdunlap@infradead.org>",
"date": "Thu, 26 Feb 2026 17:31:35 -0800",
"is_openbsd": false,
"thread_id": "c304a58d-2f07-4bdf-983f-9d92b13fdcbe@ovn.org.mbox.gz"
} |
lkml_critique | netdev | Fix some kernel-doc warnings in openvswitch.h:
Mark enum placeholders that are not used as "private" so that kernel-doc
comments are not needed for them.
Correct names for 2 enum values:
Warning: include/uapi/linux/openvswitch.h:300 Excess enum value
'@OVS_VPORT_UPCALL_SUCCESS' description in 'ovs_vport_upcall_attr'... | null | null | null | [PATCH -net] net: openvswitch: clean up some kernel-doc warnings | On 2/26/26 2:57 PM, Ilya Maximets wrote:
I documented them and made them all public:.
I didn't follow the "it doesn't start with /**", but I made it private:.
I ended up adding comments for several enums, but you might want to correct
a few of them.
I hope that I fixed that.
I'll send v2 after 24++ hours.
thank... | {
"author": "Randy Dunlap <rdunlap@infradead.org>",
"date": "Thu, 26 Feb 2026 21:42:18 -0800",
"is_openbsd": false,
"thread_id": "c304a58d-2f07-4bdf-983f-9d92b13fdcbe@ovn.org.mbox.gz"
} |
lkml_critique | netdev | Fix some kernel-doc warnings in openvswitch.h:
Mark enum placeholders that are not used as "private" so that kernel-doc
comments are not needed for them.
Correct names for 2 enum values:
Warning: include/uapi/linux/openvswitch.h:300 Excess enum value
'@OVS_VPORT_UPCALL_SUCCESS' description in 'ovs_vport_upcall_attr'... | null | null | null | [PATCH -net] net: openvswitch: clean up some kernel-doc warnings | On 2/27/26 1:56 AM, Jakub Kicinski wrote:
FWIW, it looks like ynl puts the private tag on the same indentation
level as the max enum member, which we can see in the generated headers:
https://lore.kernel.org/all/20230727163001.3952878-4-sdf@google.com/
But I also do not have a strong opinion on how it should look l... | {
"author": "Ilya Maximets <i.maximets@ovn.org>",
"date": "Fri, 27 Feb 2026 11:09:56 +0100",
"is_openbsd": false,
"thread_id": "c304a58d-2f07-4bdf-983f-9d92b13fdcbe@ovn.org.mbox.gz"
} |
lkml_critique | netdev | Fix some kernel-doc warnings in openvswitch.h:
Mark enum placeholders that are not used as "private" so that kernel-doc
comments are not needed for them.
Correct names for 2 enum values:
Warning: include/uapi/linux/openvswitch.h:300 Excess enum value
'@OVS_VPORT_UPCALL_SUCCESS' description in 'ovs_vport_upcall_attr'... | null | null | null | [PATCH -net] net: openvswitch: clean up some kernel-doc warnings | On 2/27/26 6:42 AM, Randy Dunlap wrote:
OK.
The point was that the comment for the 'enum ovs_check_pkt_len_attr'
starts with the regular '/*' and not the kernel-doc standard '/**'.
So I assumed that's the reason why it was missed.
Looking more closely, the same applies also to the
'struct ovs_action_push_eth', that... | {
"author": "Ilya Maximets <i.maximets@ovn.org>",
"date": "Fri, 27 Feb 2026 11:20:00 +0100",
"is_openbsd": false,
"thread_id": "c304a58d-2f07-4bdf-983f-9d92b13fdcbe@ovn.org.mbox.gz"
} |
lkml_critique | netdev | This short series adds support for VLANs in macsec devices when offload
mode is enabled. This allows VLAN netdevs on top of macsec netdevs to
function, which accidentally used to be the case in the past, but was
broken. This series adds back proper support.
netdevsim was extended to support VLANs and there's also a se... | null | null | null | [PATCH net-next v2 0/3] macsec: Add support for VLAN filtering in offload mode | Add support for storing the list of VLANs in nsim devices, together with
ops for adding/removing them and a debug file to show them.
This will be used in upcoming tests.
Signed-off-by: Cosmin Ratiu <cratiu@nvidia.com>
---
drivers/net/netdevsim/netdev.c | 59 +++++++++++++++++++++++++++++--
drivers/net/netdevsim/n... | {
"author": "Cosmin Ratiu <cratiu@nvidia.com>",
"date": "Fri, 27 Feb 2026 11:02:25 +0200",
"is_openbsd": false,
"thread_id": "20260227065833.36edcc6c@kernel.org.mbox.gz"
} |
lkml_critique | netdev | This short series adds support for VLANs in macsec devices when offload
mode is enabled. This allows VLAN netdevs on top of macsec netdevs to
function, which accidentally used to be the case in the past, but was
broken. This series adds back proper support.
netdevsim was extended to support VLANs and there's also a se... | null | null | null | [PATCH net-next v2 0/3] macsec: Add support for VLAN filtering in offload mode | Add macsec offload VLAN tests using the netsim VLAN support just added.
In case that VLAN support is missing (e.g. when running these tests on
older kernels), the VLAN tests are simply skipped.
Signed-off-by: Cosmin Ratiu <cratiu@nvidia.com>
---
.../drivers/net/netdevsim/ethtool-common.sh | 5 +-
.../drivers/net/n... | {
"author": "Cosmin Ratiu <cratiu@nvidia.com>",
"date": "Fri, 27 Feb 2026 11:02:26 +0200",
"is_openbsd": false,
"thread_id": "20260227065833.36edcc6c@kernel.org.mbox.gz"
} |
lkml_critique | netdev | This short series adds support for VLANs in macsec devices when offload
mode is enabled. This allows VLAN netdevs on top of macsec netdevs to
function, which accidentally used to be the case in the past, but was
broken. This series adds back proper support.
netdevsim was extended to support VLANs and there's also a se... | null | null | null | [PATCH net-next v2 0/3] macsec: Add support for VLAN filtering in offload mode | VLAN-filtering is done through two netdev features
(NETIF_F_HW_VLAN_CTAG_FILTER and NETIF_F_HW_VLAN_STAG_FILTER) and two
netdev ops (ndo_vlan_rx_add_vid and ndo_vlan_rx_kill_vid).
Implement these and advertise the features if the lower device supports
them. This allows proper VLAN filtering to work on top of macsec
de... | {
"author": "Cosmin Ratiu <cratiu@nvidia.com>",
"date": "Fri, 27 Feb 2026 11:02:27 +0200",
"is_openbsd": false,
"thread_id": "20260227065833.36edcc6c@kernel.org.mbox.gz"
} |
lkml_critique | netdev | This short series adds support for VLANs in macsec devices when offload
mode is enabled. This allows VLAN netdevs on top of macsec netdevs to
function, which accidentally used to be the case in the past, but was
broken. This series adds back proper support.
netdevsim was extended to support VLANs and there's also a se... | null | null | null | [PATCH net-next v2 0/3] macsec: Add support for VLAN filtering in offload mode | On Fri, 27 Feb 2026 11:02:26 +0200 Cosmin Ratiu wrote:
You have to enable macsec in the config file for netdevsim selftests
--
pw-bot: cr | {
"author": "Jakub Kicinski <kuba@kernel.org>",
"date": "Fri, 27 Feb 2026 06:58:33 -0800",
"is_openbsd": false,
"thread_id": "20260227065833.36edcc6c@kernel.org.mbox.gz"
} |
lkml_critique | netdev | This short series adds support for VLANs in macsec devices when offload
mode is enabled. This allows VLAN netdevs on top of macsec netdevs to
function, which accidentally used to be the case in the past, but was
broken. This series adds back proper support.
netdevsim was extended to support VLANs and there's also a se... | null | null | null | [PATCH net-next v2 0/3] macsec: Add support for VLAN filtering in offload mode | On Fri, 27 Feb 2026 11:02:27 +0200 Cosmin Ratiu wrote:
AI says:
This commit implements VLAN-filtering support for macsec devices by
adding ndo_vlan_rx_add_vid and ndo_vlan_rx_kill_vid callbacks and
advertising the appropriate netdev features when the lower device
supports VLAN filtering.
Does the error path properl... | {
"author": "Jakub Kicinski <kuba@kernel.org>",
"date": "Fri, 27 Feb 2026 06:59:08 -0800",
"is_openbsd": false,
"thread_id": "20260227065833.36edcc6c@kernel.org.mbox.gz"
} |
lkml_critique | netdev | This is part 2 of the qcom-ethqos series, part 1 has now been merged.
This part of the series focuses on the generic PHY driver, but these
changes have dependencies on the ethernet driver, hence why
it will need to go via net-next. Furthermore, subsequent changes
depend on these patches.
The underlying ideas here are... | null | null | null | [PATCH net-next 0/9] net: stmmac: qcom-ethqos: further serdes
reorganisation | Note: only 8 patches in this series, not 9 as the subject line says,
as the set_clk_tx_rate() patch became part of the first series.
On Wed, Feb 25, 2026 at 09:00:41AM +0000, Russell King (Oracle) wrote:
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent... | {
"author": "\"Russell King (Oracle)\" <linux@armlinux.org.uk>",
"date": "Wed, 25 Feb 2026 09:02:49 +0000",
"is_openbsd": false,
"thread_id": "aaGgDfaOBHNY6xL2@vaman.mbox.gz"
} |
lkml_critique | netdev | This is part 2 of the qcom-ethqos series, part 1 has now been merged.
This part of the series focuses on the generic PHY driver, but these
changes have dependencies on the ethernet driver, hence why
it will need to go via net-next. Furthermore, subsequent changes
depend on these patches.
The underlying ideas here are... | null | null | null | [PATCH net-next 0/9] net: stmmac: qcom-ethqos: further serdes
reorganisation | qcom-sgmii-eth is an Ethernet SerDes supporting only Ethernet mode
using SGMII, 1000BASE-X and 2500BASE-X.
Add an implementation of the .set_mode() method, which can be used
instead of or as well as the .set_speed() method. The Ethernet
interface modes mentioned above all have a fixed data rate, so
setting the mode is... | {
"author": "\"Russell King (Oracle)\" <rmk+kernel@armlinux.org.uk>",
"date": "Wed, 25 Feb 2026 10:59:17 +0000",
"is_openbsd": false,
"thread_id": "aaGgDfaOBHNY6xL2@vaman.mbox.gz"
} |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.