data_type
large_stringclasses
3 values
source
large_stringclasses
29 values
code
large_stringlengths
98
49.4M
filepath
large_stringlengths
5
161
message
large_stringclasses
234 values
commit
large_stringclasses
234 values
subject
large_stringclasses
418 values
critique
large_stringlengths
101
1.26M
metadata
dict
lkml_critique
netdev
Christian said [1] to "just do it" when I proposed this, so here we are! For historical reasons, the inode->i_ino field is an unsigned long, which means that it's 32 bits on 32 bit architectures. This has caused a number of filesystems to implement hacks to hash a 64-bit identifier into a 32-bit field, and deprives us...
null
null
null
[PATCH 00/61] vfs: change inode->i_ino from unsigned long to u64
With i_ino now u64, CIFS/SMB can store the full 64-bit uniqueid in i_ino without the XOR-folding hack previously needed on 32-bit architectures. - Simplify cifs_uniqueid_to_ino_t() to return u64 directly - Update hash variable type in cifs_get_inode_info() - Update format strings from %lu to %llu Signed-off-by: Jeff ...
{ "author": "Jeff Layton <jlayton@kernel.org>", "date": "Thu, 26 Feb 2026 10:55:15 -0500", "is_openbsd": false, "thread_id": "20260227-herab-wolken-c52d560f40d5@brauner.mbox.gz" }
lkml_critique
netdev
Christian said [1] to "just do it" when I proposed this, so here we are! For historical reasons, the inode->i_ino field is an unsigned long, which means that it's 32 bits on 32 bit architectures. This has caused a number of filesystems to implement hacks to hash a 64-bit identifier into a 32-bit field, and deprives us...
null
null
null
[PATCH 00/61] vfs: change inode->i_ino from unsigned long to u64
Now that i_ino is u64, cifs_uniqueid_to_ino_t() is a trivial identity function. Remove it and use fattr->cf_uniqueid directly at both call sites. Also remove the now-unused #include <linux/hash.h>, which was only needed for the old XOR-folding logic. Signed-off-by: Jeff Layton <jlayton@kernel.org> --- fs/smb/client/...
{ "author": "Jeff Layton <jlayton@kernel.org>", "date": "Thu, 26 Feb 2026 10:55:16 -0500", "is_openbsd": false, "thread_id": "20260227-herab-wolken-c52d560f40d5@brauner.mbox.gz" }
lkml_critique
netdev
Christian said [1] to "just do it" when I proposed this, so here we are! For historical reasons, the inode->i_ino field is an unsigned long, which means that it's 32 bits on 32 bit architectures. This has caused a number of filesystems to implement hacks to hash a 64-bit identifier into a 32-bit field, and deprives us...
null
null
null
[PATCH 00/61] vfs: change inode->i_ino from unsigned long to u64
Update the seq_printf format string in lock_get_status() from %lu to %llu for printing inode->i_ino, since i_ino is now u64. Signed-off-by: Jeff Layton <jlayton@kernel.org> --- fs/locks.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/fs/locks.c b/fs/locks.c index d13ec930b7bb03905df50bdce3...
{ "author": "Jeff Layton <jlayton@kernel.org>", "date": "Thu, 26 Feb 2026 10:55:17 -0500", "is_openbsd": false, "thread_id": "20260227-herab-wolken-c52d560f40d5@brauner.mbox.gz" }
lkml_critique
netdev
Christian said [1] to "just do it" when I proposed this, so here we are! For historical reasons, the inode->i_ino field is an unsigned long, which means that it's 32 bits on 32 bit architectures. This has caused a number of filesystems to implement hacks to hash a 64-bit identifier into a 32-bit field, and deprives us...
null
null
null
[PATCH 00/61] vfs: change inode->i_ino from unsigned long to u64
Update the local ino variable type from unsigned long to u64, and change the format string from %lu to %llu when printing it. The variable is assigned from inode->i_ino which is now u64. Signed-off-by: Jeff Layton <jlayton@kernel.org> --- fs/proc/fd.c | 2 +- fs/proc/task_mmu.c | 4 ++-- 2 files changed, 3 inse...
{ "author": "Jeff Layton <jlayton@kernel.org>", "date": "Thu, 26 Feb 2026 10:55:18 -0500", "is_openbsd": false, "thread_id": "20260227-herab-wolken-c52d560f40d5@brauner.mbox.gz" }
lkml_critique
netdev
Christian said [1] to "just do it" when I proposed this, so here we are! For historical reasons, the inode->i_ino field is an unsigned long, which means that it's 32 bits on 32 bit architectures. This has caused a number of filesystems to implement hacks to hash a 64-bit identifier into a 32-bit field, and deprives us...
null
null
null
[PATCH 00/61] vfs: change inode->i_ino from unsigned long to u64
Update nilfs2 trace events and filesystem code for u64 i_ino: - Change __field(ino_t, ...) to __field(u64, ...) in trace events - Update format strings from %lu to %llu - Cast to (unsigned long long) in TP_printk Signed-off-by: Jeff Layton <jlayton@kernel.org> --- fs/nilfs2/alloc.c | 10 +++++----- fs/ni...
{ "author": "Jeff Layton <jlayton@kernel.org>", "date": "Thu, 26 Feb 2026 10:55:19 -0500", "is_openbsd": false, "thread_id": "20260227-herab-wolken-c52d560f40d5@brauner.mbox.gz" }
lkml_critique
netdev
Christian said [1] to "just do it" when I proposed this, so here we are! For historical reasons, the inode->i_ino field is an unsigned long, which means that it's 32 bits on 32 bit architectures. This has caused a number of filesystems to implement hacks to hash a 64-bit identifier into a 32-bit field, and deprives us...
null
null
null
[PATCH 00/61] vfs: change inode->i_ino from unsigned long to u64
Update format strings and local variable types in 9p for the i_ino type change from unsigned long to u64. Signed-off-by: Jeff Layton <jlayton@kernel.org> --- fs/9p/vfs_addr.c | 4 ++-- fs/9p/vfs_inode.c | 6 +++--- fs/9p/vfs_inode_dotl.c | 6 +++--- 3 files changed, 8 insertions(+), 8 deletions(-) diff --...
{ "author": "Jeff Layton <jlayton@kernel.org>", "date": "Thu, 26 Feb 2026 10:55:20 -0500", "is_openbsd": false, "thread_id": "20260227-herab-wolken-c52d560f40d5@brauner.mbox.gz" }
lkml_critique
netdev
Christian said [1] to "just do it" when I proposed this, so here we are! For historical reasons, the inode->i_ino field is an unsigned long, which means that it's 32 bits on 32 bit architectures. This has caused a number of filesystems to implement hacks to hash a 64-bit identifier into a 32-bit field, and deprives us...
null
null
null
[PATCH 00/61] vfs: change inode->i_ino from unsigned long to u64
Update format strings and local variable types in affs for the i_ino type change from unsigned long to u64. Signed-off-by: Jeff Layton <jlayton@kernel.org> --- fs/affs/amigaffs.c | 8 ++++---- fs/affs/bitmap.c | 2 +- fs/affs/dir.c | 2 +- fs/affs/file.c | 20 ++++++++++---------- fs/affs/inode.c | 1...
{ "author": "Jeff Layton <jlayton@kernel.org>", "date": "Thu, 26 Feb 2026 10:55:21 -0500", "is_openbsd": false, "thread_id": "20260227-herab-wolken-c52d560f40d5@brauner.mbox.gz" }
lkml_critique
netdev
Christian said [1] to "just do it" when I proposed this, so here we are! For historical reasons, the inode->i_ino field is an unsigned long, which means that it's 32 bits on 32 bit architectures. This has caused a number of filesystems to implement hacks to hash a 64-bit identifier into a 32-bit field, and deprives us...
null
null
null
[PATCH 00/61] vfs: change inode->i_ino from unsigned long to u64
Update format strings and local variable types in afs for the i_ino type change from unsigned long to u64. Signed-off-by: Jeff Layton <jlayton@kernel.org> --- fs/afs/dir.c | 10 +++++----- fs/afs/dir_search.c | 2 +- fs/afs/dynroot.c | 2 +- fs/afs/inode.c | 2 +- 4 files changed, 8 insertions(+), 8...
{ "author": "Jeff Layton <jlayton@kernel.org>", "date": "Thu, 26 Feb 2026 10:55:22 -0500", "is_openbsd": false, "thread_id": "20260227-herab-wolken-c52d560f40d5@brauner.mbox.gz" }
lkml_critique
netdev
Christian said [1] to "just do it" when I proposed this, so here we are! For historical reasons, the inode->i_ino field is an unsigned long, which means that it's 32 bits on 32 bit architectures. This has caused a number of filesystems to implement hacks to hash a 64-bit identifier into a 32-bit field, and deprives us...
null
null
null
[PATCH 00/61] vfs: change inode->i_ino from unsigned long to u64
Update format strings and local variable types in autofs for the i_ino type change from unsigned long to u64. Signed-off-by: Jeff Layton <jlayton@kernel.org> --- fs/autofs/inode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/autofs/inode.c b/fs/autofs/inode.c index c53dc551053ba53fa7c85ca57e...
{ "author": "Jeff Layton <jlayton@kernel.org>", "date": "Thu, 26 Feb 2026 10:55:23 -0500", "is_openbsd": false, "thread_id": "20260227-herab-wolken-c52d560f40d5@brauner.mbox.gz" }
lkml_critique
netdev
Christian said [1] to "just do it" when I proposed this, so here we are! For historical reasons, the inode->i_ino field is an unsigned long, which means that it's 32 bits on 32 bit architectures. This has caused a number of filesystems to implement hacks to hash a 64-bit identifier into a 32-bit field, and deprives us...
null
null
null
[PATCH 00/61] vfs: change inode->i_ino from unsigned long to u64
Update format strings and local variable types in befs for the i_ino type change from unsigned long to u64. Signed-off-by: Jeff Layton <jlayton@kernel.org> --- fs/befs/linuxvfs.c | 28 ++++++++++++++-------------- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/fs/befs/linuxvfs.c b/fs/befs/linuxvfs.c ...
{ "author": "Jeff Layton <jlayton@kernel.org>", "date": "Thu, 26 Feb 2026 10:55:24 -0500", "is_openbsd": false, "thread_id": "20260227-herab-wolken-c52d560f40d5@brauner.mbox.gz" }
lkml_critique
netdev
Christian said [1] to "just do it" when I proposed this, so here we are! For historical reasons, the inode->i_ino field is an unsigned long, which means that it's 32 bits on 32 bit architectures. This has caused a number of filesystems to implement hacks to hash a 64-bit identifier into a 32-bit field, and deprives us...
null
null
null
[PATCH 00/61] vfs: change inode->i_ino from unsigned long to u64
Update format strings and local variable types in bfs for the i_ino type change from unsigned long to u64. Signed-off-by: Jeff Layton <jlayton@kernel.org> --- fs/bfs/dir.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/bfs/dir.c b/fs/bfs/dir.c index c375e22c4c0c15ba27307d266adfe3f093b90ab8...
{ "author": "Jeff Layton <jlayton@kernel.org>", "date": "Thu, 26 Feb 2026 10:55:25 -0500", "is_openbsd": false, "thread_id": "20260227-herab-wolken-c52d560f40d5@brauner.mbox.gz" }
lkml_critique
netdev
Christian said [1] to "just do it" when I proposed this, so here we are! For historical reasons, the inode->i_ino field is an unsigned long, which means that it's 32 bits on 32 bit architectures. This has caused a number of filesystems to implement hacks to hash a 64-bit identifier into a 32-bit field, and deprives us...
null
null
null
[PATCH 00/61] vfs: change inode->i_ino from unsigned long to u64
Update format strings and local variable types in cachefiles for the i_ino type change from unsigned long to u64. Signed-off-by: Jeff Layton <jlayton@kernel.org> --- fs/cachefiles/io.c | 6 +++--- fs/cachefiles/namei.c | 12 ++++++------ fs/cachefiles/xattr.c | 2 +- 3 files changed, 10 insertions(+), 10 deletio...
{ "author": "Jeff Layton <jlayton@kernel.org>", "date": "Thu, 26 Feb 2026 10:55:26 -0500", "is_openbsd": false, "thread_id": "20260227-herab-wolken-c52d560f40d5@brauner.mbox.gz" }
lkml_critique
netdev
Christian said [1] to "just do it" when I proposed this, so here we are! For historical reasons, the inode->i_ino field is an unsigned long, which means that it's 32 bits on 32 bit architectures. This has caused a number of filesystems to implement hacks to hash a 64-bit identifier into a 32-bit field, and deprives us...
null
null
null
[PATCH 00/61] vfs: change inode->i_ino from unsigned long to u64
Update format strings and local variable types in ceph for the i_ino type change from unsigned long to u64. Signed-off-by: Jeff Layton <jlayton@kernel.org> --- fs/ceph/crypto.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/ceph/crypto.c b/fs/ceph/crypto.c index f3de43ccb470ddbd7945426d79f...
{ "author": "Jeff Layton <jlayton@kernel.org>", "date": "Thu, 26 Feb 2026 10:55:27 -0500", "is_openbsd": false, "thread_id": "20260227-herab-wolken-c52d560f40d5@brauner.mbox.gz" }
lkml_critique
netdev
Christian said [1] to "just do it" when I proposed this, so here we are! For historical reasons, the inode->i_ino field is an unsigned long, which means that it's 32 bits on 32 bit architectures. This has caused a number of filesystems to implement hacks to hash a 64-bit identifier into a 32-bit field, and deprives us...
null
null
null
[PATCH 00/61] vfs: change inode->i_ino from unsigned long to u64
Update format strings and local variable types in coda for the i_ino type change from unsigned long to u64. Signed-off-by: Jeff Layton <jlayton@kernel.org> --- fs/coda/dir.c | 2 +- fs/coda/inode.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/coda/dir.c b/fs/coda/dir.c index c64b8cd8156...
{ "author": "Jeff Layton <jlayton@kernel.org>", "date": "Thu, 26 Feb 2026 10:55:28 -0500", "is_openbsd": false, "thread_id": "20260227-herab-wolken-c52d560f40d5@brauner.mbox.gz" }
lkml_critique
netdev
Christian said [1] to "just do it" when I proposed this, so here we are! For historical reasons, the inode->i_ino field is an unsigned long, which means that it's 32 bits on 32 bit architectures. This has caused a number of filesystems to implement hacks to hash a 64-bit identifier into a 32-bit field, and deprives us...
null
null
null
[PATCH 00/61] vfs: change inode->i_ino from unsigned long to u64
Update format strings and local variable types in cramfs for the i_ino type change from unsigned long to u64. Signed-off-by: Jeff Layton <jlayton@kernel.org> --- fs/cramfs/inode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/cramfs/inode.c b/fs/cramfs/inode.c index e0ba9cd640dcfe86e0976344b3...
{ "author": "Jeff Layton <jlayton@kernel.org>", "date": "Thu, 26 Feb 2026 10:55:29 -0500", "is_openbsd": false, "thread_id": "20260227-herab-wolken-c52d560f40d5@brauner.mbox.gz" }
lkml_critique
netdev
Christian said [1] to "just do it" when I proposed this, so here we are! For historical reasons, the inode->i_ino field is an unsigned long, which means that it's 32 bits on 32 bit architectures. This has caused a number of filesystems to implement hacks to hash a 64-bit identifier into a 32-bit field, and deprives us...
null
null
null
[PATCH 00/61] vfs: change inode->i_ino from unsigned long to u64
Update format strings and local variable types in ecryptfs for the i_ino type change from unsigned long to u64. Signed-off-by: Jeff Layton <jlayton@kernel.org> --- fs/ecryptfs/crypto.c | 6 +++--- fs/ecryptfs/file.c | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/fs/ecryptfs/crypto.c b/fs/ecr...
{ "author": "Jeff Layton <jlayton@kernel.org>", "date": "Thu, 26 Feb 2026 10:55:30 -0500", "is_openbsd": false, "thread_id": "20260227-herab-wolken-c52d560f40d5@brauner.mbox.gz" }
lkml_critique
netdev
Christian said [1] to "just do it" when I proposed this, so here we are! For historical reasons, the inode->i_ino field is an unsigned long, which means that it's 32 bits on 32 bit architectures. This has caused a number of filesystems to implement hacks to hash a 64-bit identifier into a 32-bit field, and deprives us...
null
null
null
[PATCH 00/61] vfs: change inode->i_ino from unsigned long to u64
Update format strings and local variable types in efs for the i_ino type change from unsigned long to u64. Signed-off-by: Jeff Layton <jlayton@kernel.org> --- fs/efs/inode.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/fs/efs/inode.c b/fs/efs/inode.c index 28407578f83ad5db1b8a7b082fa3e990...
{ "author": "Jeff Layton <jlayton@kernel.org>", "date": "Thu, 26 Feb 2026 10:55:31 -0500", "is_openbsd": false, "thread_id": "20260227-herab-wolken-c52d560f40d5@brauner.mbox.gz" }
lkml_critique
netdev
Christian said [1] to "just do it" when I proposed this, so here we are! For historical reasons, the inode->i_ino field is an unsigned long, which means that it's 32 bits on 32 bit architectures. This has caused a number of filesystems to implement hacks to hash a 64-bit identifier into a 32-bit field, and deprives us...
null
null
null
[PATCH 00/61] vfs: change inode->i_ino from unsigned long to u64
Update format strings and local variable types in exportfs for the i_ino type change from unsigned long to u64. Signed-off-by: Jeff Layton <jlayton@kernel.org> --- fs/exportfs/expfs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/exportfs/expfs.c b/fs/exportfs/expfs.c index 6c9be60a3e48dc...
{ "author": "Jeff Layton <jlayton@kernel.org>", "date": "Thu, 26 Feb 2026 10:55:32 -0500", "is_openbsd": false, "thread_id": "20260227-herab-wolken-c52d560f40d5@brauner.mbox.gz" }
lkml_critique
netdev
Christian said [1] to "just do it" when I proposed this, so here we are! For historical reasons, the inode->i_ino field is an unsigned long, which means that it's 32 bits on 32 bit architectures. This has caused a number of filesystems to implement hacks to hash a 64-bit identifier into a 32-bit field, and deprives us...
null
null
null
[PATCH 00/61] vfs: change inode->i_ino from unsigned long to u64
Update format strings and local variable types in ext2 for the i_ino type change from unsigned long to u64. Signed-off-by: Jeff Layton <jlayton@kernel.org> --- fs/ext2/dir.c | 10 +++++----- fs/ext2/ialloc.c | 9 +++++---- fs/ext2/inode.c | 2 +- fs/ext2/xattr.c | 14 +++++++------- 4 files changed, 18 inserti...
{ "author": "Jeff Layton <jlayton@kernel.org>", "date": "Thu, 26 Feb 2026 10:55:33 -0500", "is_openbsd": false, "thread_id": "20260227-herab-wolken-c52d560f40d5@brauner.mbox.gz" }
lkml_critique
netdev
Christian said [1] to "just do it" when I proposed this, so here we are! For historical reasons, the inode->i_ino field is an unsigned long, which means that it's 32 bits on 32 bit architectures. This has caused a number of filesystems to implement hacks to hash a 64-bit identifier into a 32-bit field, and deprives us...
null
null
null
[PATCH 00/61] vfs: change inode->i_ino from unsigned long to u64
Update format strings and local variable types in freevxfs for the i_ino type change from unsigned long to u64. Signed-off-by: Jeff Layton <jlayton@kernel.org> --- fs/freevxfs/vxfs_bmap.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/freevxfs/vxfs_bmap.c b/fs/freevxfs/vxfs_bmap.c index 26...
{ "author": "Jeff Layton <jlayton@kernel.org>", "date": "Thu, 26 Feb 2026 10:55:34 -0500", "is_openbsd": false, "thread_id": "20260227-herab-wolken-c52d560f40d5@brauner.mbox.gz" }
lkml_critique
netdev
Christian said [1] to "just do it" when I proposed this, so here we are! For historical reasons, the inode->i_ino field is an unsigned long, which means that it's 32 bits on 32 bit architectures. This has caused a number of filesystems to implement hacks to hash a 64-bit identifier into a 32-bit field, and deprives us...
null
null
null
[PATCH 00/61] vfs: change inode->i_ino from unsigned long to u64
Update format strings and local variable types in hfs for the i_ino type change from unsigned long to u64. Signed-off-by: Jeff Layton <jlayton@kernel.org> --- fs/hfs/catalog.c | 2 +- fs/hfs/extent.c | 4 ++-- fs/hfs/inode.c | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/fs/hfs/catalog.c ...
{ "author": "Jeff Layton <jlayton@kernel.org>", "date": "Thu, 26 Feb 2026 10:55:35 -0500", "is_openbsd": false, "thread_id": "20260227-herab-wolken-c52d560f40d5@brauner.mbox.gz" }
lkml_critique
netdev
Christian said [1] to "just do it" when I proposed this, so here we are! For historical reasons, the inode->i_ino field is an unsigned long, which means that it's 32 bits on 32 bit architectures. This has caused a number of filesystems to implement hacks to hash a 64-bit identifier into a 32-bit field, and deprives us...
null
null
null
[PATCH 00/61] vfs: change inode->i_ino from unsigned long to u64
Update format strings and local variable types in hfsplus for the i_ino type change from unsigned long to u64. Signed-off-by: Jeff Layton <jlayton@kernel.org> --- fs/hfsplus/attributes.c | 10 +++++----- fs/hfsplus/catalog.c | 2 +- fs/hfsplus/dir.c | 6 +++--- fs/hfsplus/extents.c | 6 +++--- fs/hfsp...
{ "author": "Jeff Layton <jlayton@kernel.org>", "date": "Thu, 26 Feb 2026 10:55:36 -0500", "is_openbsd": false, "thread_id": "20260227-herab-wolken-c52d560f40d5@brauner.mbox.gz" }
lkml_critique
netdev
Christian said [1] to "just do it" when I proposed this, so here we are! For historical reasons, the inode->i_ino field is an unsigned long, which means that it's 32 bits on 32 bit architectures. This has caused a number of filesystems to implement hacks to hash a 64-bit identifier into a 32-bit field, and deprives us...
null
null
null
[PATCH 00/61] vfs: change inode->i_ino from unsigned long to u64
Update format strings and local variable types in hpfs for the i_ino type change from unsigned long to u64. Signed-off-by: Jeff Layton <jlayton@kernel.org> --- fs/hpfs/dir.c | 4 ++-- fs/hpfs/dnode.c | 4 ++-- fs/hpfs/ea.c | 4 ++-- fs/hpfs/inode.c | 4 ++-- 4 files changed, 8 insertions(+), 8 deletions(-) diff...
{ "author": "Jeff Layton <jlayton@kernel.org>", "date": "Thu, 26 Feb 2026 10:55:37 -0500", "is_openbsd": false, "thread_id": "20260227-herab-wolken-c52d560f40d5@brauner.mbox.gz" }
lkml_critique
netdev
Christian said [1] to "just do it" when I proposed this, so here we are! For historical reasons, the inode->i_ino field is an unsigned long, which means that it's 32 bits on 32 bit architectures. This has caused a number of filesystems to implement hacks to hash a 64-bit identifier into a 32-bit field, and deprives us...
null
null
null
[PATCH 00/61] vfs: change inode->i_ino from unsigned long to u64
Update format strings and local variable types in isofs for the i_ino type change from unsigned long to u64. Signed-off-by: Jeff Layton <jlayton@kernel.org> --- fs/isofs/compress.c | 2 +- fs/isofs/dir.c | 2 +- fs/isofs/inode.c | 6 +++--- fs/isofs/namei.c | 2 +- 4 files changed, 6 insertions(+), 6 delet...
{ "author": "Jeff Layton <jlayton@kernel.org>", "date": "Thu, 26 Feb 2026 10:55:38 -0500", "is_openbsd": false, "thread_id": "20260227-herab-wolken-c52d560f40d5@brauner.mbox.gz" }
lkml_critique
netdev
Christian said [1] to "just do it" when I proposed this, so here we are! For historical reasons, the inode->i_ino field is an unsigned long, which means that it's 32 bits on 32 bit architectures. This has caused a number of filesystems to implement hacks to hash a 64-bit identifier into a 32-bit field, and deprives us...
null
null
null
[PATCH 00/61] vfs: change inode->i_ino from unsigned long to u64
Update format strings and local variable types in jffs2 for the i_ino type change from unsigned long to u64. Signed-off-by: Jeff Layton <jlayton@kernel.org> --- fs/jffs2/dir.c | 4 ++-- fs/jffs2/file.c | 4 ++-- fs/jffs2/fs.c | 18 +++++++++--------- 3 files changed, 13 insertions(+), 13 deletions(-) diff --git...
{ "author": "Jeff Layton <jlayton@kernel.org>", "date": "Thu, 26 Feb 2026 10:55:39 -0500", "is_openbsd": false, "thread_id": "20260227-herab-wolken-c52d560f40d5@brauner.mbox.gz" }
lkml_critique
netdev
Christian said [1] to "just do it" when I proposed this, so here we are! For historical reasons, the inode->i_ino field is an unsigned long, which means that it's 32 bits on 32 bit architectures. This has caused a number of filesystems to implement hacks to hash a 64-bit identifier into a 32-bit field, and deprives us...
null
null
null
[PATCH 00/61] vfs: change inode->i_ino from unsigned long to u64
Update format strings and local variable types in jfs for the i_ino type change from unsigned long to u64. Signed-off-by: Jeff Layton <jlayton@kernel.org> --- fs/jfs/inode.c | 2 +- fs/jfs/jfs_imap.c | 2 +- fs/jfs/jfs_metapage.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/fs/jfs...
{ "author": "Jeff Layton <jlayton@kernel.org>", "date": "Thu, 26 Feb 2026 10:55:40 -0500", "is_openbsd": false, "thread_id": "20260227-herab-wolken-c52d560f40d5@brauner.mbox.gz" }
lkml_critique
netdev
Christian said [1] to "just do it" when I proposed this, so here we are! For historical reasons, the inode->i_ino field is an unsigned long, which means that it's 32 bits on 32 bit architectures. This has caused a number of filesystems to implement hacks to hash a 64-bit identifier into a 32-bit field, and deprives us...
null
null
null
[PATCH 00/61] vfs: change inode->i_ino from unsigned long to u64
Update format strings and local variable types in minix for the i_ino type change from unsigned long to u64. Signed-off-by: Jeff Layton <jlayton@kernel.org> --- fs/minix/inode.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/fs/minix/inode.c b/fs/minix/inode.c index 99541c6a5bbf13f3be2...
{ "author": "Jeff Layton <jlayton@kernel.org>", "date": "Thu, 26 Feb 2026 10:55:41 -0500", "is_openbsd": false, "thread_id": "20260227-herab-wolken-c52d560f40d5@brauner.mbox.gz" }
lkml_critique
netdev
Christian said [1] to "just do it" when I proposed this, so here we are! For historical reasons, the inode->i_ino field is an unsigned long, which means that it's 32 bits on 32 bit architectures. This has caused a number of filesystems to implement hacks to hash a 64-bit identifier into a 32-bit field, and deprives us...
null
null
null
[PATCH 00/61] vfs: change inode->i_ino from unsigned long to u64
Update format strings and local variable types in nsfs for the i_ino type change from unsigned long to u64. Signed-off-by: Jeff Layton <jlayton@kernel.org> --- fs/nsfs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/nsfs.c b/fs/nsfs.c index db91de2086456bb9fe0547be7dbbd2de87c97ca7..eac326...
{ "author": "Jeff Layton <jlayton@kernel.org>", "date": "Thu, 26 Feb 2026 10:55:42 -0500", "is_openbsd": false, "thread_id": "20260227-herab-wolken-c52d560f40d5@brauner.mbox.gz" }
lkml_critique
netdev
Christian said [1] to "just do it" when I proposed this, so here we are! For historical reasons, the inode->i_ino field is an unsigned long, which means that it's 32 bits on 32 bit architectures. This has caused a number of filesystems to implement hacks to hash a 64-bit identifier into a 32-bit field, and deprives us...
null
null
null
[PATCH 00/61] vfs: change inode->i_ino from unsigned long to u64
Update format strings and local variable types in ntfs3 for the i_ino type change from unsigned long to u64. Signed-off-by: Jeff Layton <jlayton@kernel.org> --- fs/ntfs3/super.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/ntfs3/super.c b/fs/ntfs3/super.c index 174a7cb202a08c550b3b8497cdf610...
{ "author": "Jeff Layton <jlayton@kernel.org>", "date": "Thu, 26 Feb 2026 10:55:43 -0500", "is_openbsd": false, "thread_id": "20260227-herab-wolken-c52d560f40d5@brauner.mbox.gz" }
lkml_critique
netdev
Christian said [1] to "just do it" when I proposed this, so here we are! For historical reasons, the inode->i_ino field is an unsigned long, which means that it's 32 bits on 32 bit architectures. This has caused a number of filesystems to implement hacks to hash a 64-bit identifier into a 32-bit field, and deprives us...
null
null
null
[PATCH 00/61] vfs: change inode->i_ino from unsigned long to u64
Update format strings and local variable types in ocfs2 for the i_ino type change from unsigned long to u64. Signed-off-by: Jeff Layton <jlayton@kernel.org> --- fs/ocfs2/alloc.c | 2 +- fs/ocfs2/aops.c | 4 ++-- fs/ocfs2/dir.c | 8 ++++---- fs/ocfs2/dlmfs/dlmfs.c | 10 +++++----- fs/ocfs2/...
{ "author": "Jeff Layton <jlayton@kernel.org>", "date": "Thu, 26 Feb 2026 10:55:44 -0500", "is_openbsd": false, "thread_id": "20260227-herab-wolken-c52d560f40d5@brauner.mbox.gz" }
lkml_critique
netdev
Christian said [1] to "just do it" when I proposed this, so here we are! For historical reasons, the inode->i_ino field is an unsigned long, which means that it's 32 bits on 32 bit architectures. This has caused a number of filesystems to implement hacks to hash a 64-bit identifier into a 32-bit field, and deprives us...
null
null
null
[PATCH 00/61] vfs: change inode->i_ino from unsigned long to u64
Update format strings and local variable types in orangefs for the i_ino type change from unsigned long to u64. Signed-off-by: Jeff Layton <jlayton@kernel.org> --- fs/orangefs/inode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/orangefs/inode.c b/fs/orangefs/inode.c index 2d4710d0e05e195855...
{ "author": "Jeff Layton <jlayton@kernel.org>", "date": "Thu, 26 Feb 2026 10:55:45 -0500", "is_openbsd": false, "thread_id": "20260227-herab-wolken-c52d560f40d5@brauner.mbox.gz" }
lkml_critique
netdev
Christian said [1] to "just do it" when I proposed this, so here we are! For historical reasons, the inode->i_ino field is an unsigned long, which means that it's 32 bits on 32 bit architectures. This has caused a number of filesystems to implement hacks to hash a 64-bit identifier into a 32-bit field, and deprives us...
null
null
null
[PATCH 00/61] vfs: change inode->i_ino from unsigned long to u64
Update format strings and local variable types in overlayfs for the i_ino type change from unsigned long to u64. Signed-off-by: Jeff Layton <jlayton@kernel.org> --- fs/overlayfs/export.c | 2 +- fs/overlayfs/namei.c | 4 ++-- fs/overlayfs/util.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git ...
{ "author": "Jeff Layton <jlayton@kernel.org>", "date": "Thu, 26 Feb 2026 10:55:46 -0500", "is_openbsd": false, "thread_id": "20260227-herab-wolken-c52d560f40d5@brauner.mbox.gz" }
lkml_critique
netdev
Christian said [1] to "just do it" when I proposed this, so here we are! For historical reasons, the inode->i_ino field is an unsigned long, which means that it's 32 bits on 32 bit architectures. This has caused a number of filesystems to implement hacks to hash a 64-bit identifier into a 32-bit field, and deprives us...
null
null
null
[PATCH 00/61] vfs: change inode->i_ino from unsigned long to u64
Update format strings and local variable types in qnx4 for the i_ino type change from unsigned long to u64. Signed-off-by: Jeff Layton <jlayton@kernel.org> --- fs/qnx4/inode.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/qnx4/inode.c b/fs/qnx4/inode.c index 8aeb63d397cfd6c87b7862f0dc7a34...
{ "author": "Jeff Layton <jlayton@kernel.org>", "date": "Thu, 26 Feb 2026 10:55:47 -0500", "is_openbsd": false, "thread_id": "20260227-herab-wolken-c52d560f40d5@brauner.mbox.gz" }
lkml_critique
netdev
Christian said [1] to "just do it" when I proposed this, so here we are! For historical reasons, the inode->i_ino field is an unsigned long, which means that it's 32 bits on 32 bit architectures. This has caused a number of filesystems to implement hacks to hash a 64-bit identifier into a 32-bit field, and deprives us...
null
null
null
[PATCH 00/61] vfs: change inode->i_ino from unsigned long to u64
Update format strings and local variable types in qnx6 for the i_ino type change from unsigned long to u64. Signed-off-by: Jeff Layton <jlayton@kernel.org> --- fs/qnx6/inode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/qnx6/inode.c b/fs/qnx6/inode.c index c4049bb8bd60d47f9edd3d724a5d5be6b5...
{ "author": "Jeff Layton <jlayton@kernel.org>", "date": "Thu, 26 Feb 2026 10:55:48 -0500", "is_openbsd": false, "thread_id": "20260227-herab-wolken-c52d560f40d5@brauner.mbox.gz" }
lkml_critique
netdev
Christian said [1] to "just do it" when I proposed this, so here we are! For historical reasons, the inode->i_ino field is an unsigned long, which means that it's 32 bits on 32 bit architectures. This has caused a number of filesystems to implement hacks to hash a 64-bit identifier into a 32-bit field, and deprives us...
null
null
null
[PATCH 00/61] vfs: change inode->i_ino from unsigned long to u64
Update format strings and local variable types in ubifs for the i_ino type change from unsigned long to u64. Signed-off-by: Jeff Layton <jlayton@kernel.org> --- fs/ubifs/debug.c | 8 ++++---- fs/ubifs/dir.c | 28 ++++++++++++++-------------- fs/ubifs/file.c | 28 ++++++++++++++-------------- fs/ubifs/journa...
{ "author": "Jeff Layton <jlayton@kernel.org>", "date": "Thu, 26 Feb 2026 10:55:49 -0500", "is_openbsd": false, "thread_id": "20260227-herab-wolken-c52d560f40d5@brauner.mbox.gz" }
lkml_critique
netdev
Christian said [1] to "just do it" when I proposed this, so here we are! For historical reasons, the inode->i_ino field is an unsigned long, which means that it's 32 bits on 32 bit architectures. This has caused a number of filesystems to implement hacks to hash a 64-bit identifier into a 32-bit field, and deprives us...
null
null
null
[PATCH 00/61] vfs: change inode->i_ino from unsigned long to u64
Update format strings and local variable types in udf for the i_ino type change from unsigned long to u64. Signed-off-by: Jeff Layton <jlayton@kernel.org> --- fs/udf/directory.c | 18 +++++++++--------- fs/udf/file.c | 2 +- fs/udf/inode.c | 12 ++++++------ fs/udf/namei.c | 8 ++++---- fs/udf/super.c ...
{ "author": "Jeff Layton <jlayton@kernel.org>", "date": "Thu, 26 Feb 2026 10:55:50 -0500", "is_openbsd": false, "thread_id": "20260227-herab-wolken-c52d560f40d5@brauner.mbox.gz" }
lkml_critique
netdev
Christian said [1] to "just do it" when I proposed this, so here we are! For historical reasons, the inode->i_ino field is an unsigned long, which means that it's 32 bits on 32 bit architectures. This has caused a number of filesystems to implement hacks to hash a 64-bit identifier into a 32-bit field, and deprives us...
null
null
null
[PATCH 00/61] vfs: change inode->i_ino from unsigned long to u64
Update format strings and local variable types in ufs for the i_ino type change from unsigned long to u64. Signed-off-by: Jeff Layton <jlayton@kernel.org> --- fs/ufs/balloc.c | 6 +++--- fs/ufs/dir.c | 10 +++++----- fs/ufs/ialloc.c | 6 +++--- fs/ufs/inode.c | 18 +++++++++--------- fs/ufs/ufs_fs.h | 6 +++---...
{ "author": "Jeff Layton <jlayton@kernel.org>", "date": "Thu, 26 Feb 2026 10:55:51 -0500", "is_openbsd": false, "thread_id": "20260227-herab-wolken-c52d560f40d5@brauner.mbox.gz" }
lkml_critique
netdev
Christian said [1] to "just do it" when I proposed this, so here we are! For historical reasons, the inode->i_ino field is an unsigned long, which means that it's 32 bits on 32 bit architectures. This has caused a number of filesystems to implement hacks to hash a 64-bit identifier into a 32-bit field, and deprives us...
null
null
null
[PATCH 00/61] vfs: change inode->i_ino from unsigned long to u64
Update format strings and local variable types in zonefs for the i_ino type change from unsigned long to u64. Signed-off-by: Jeff Layton <jlayton@kernel.org> --- fs/zonefs/super.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/fs/zonefs/super.c b/fs/zonefs/super.c index e83b2ec5e49f81674b...
{ "author": "Jeff Layton <jlayton@kernel.org>", "date": "Thu, 26 Feb 2026 10:55:52 -0500", "is_openbsd": false, "thread_id": "20260227-herab-wolken-c52d560f40d5@brauner.mbox.gz" }
lkml_critique
netdev
Christian said [1] to "just do it" when I proposed this, so here we are! For historical reasons, the inode->i_ino field is an unsigned long, which means that it's 32 bits on 32 bit architectures. This has caused a number of filesystems to implement hacks to hash a 64-bit identifier into a 32-bit field, and deprives us...
null
null
null
[PATCH 00/61] vfs: change inode->i_ino from unsigned long to u64
Update %lu/%ld to %llu/%lld in security audit logging functions that print inode->i_ino, since i_ino is now u64. Files updated: apparmor/apparmorfs.c, integrity/integrity_audit.c, ipe/audit.c, lsm_audit.c. Signed-off-by: Jeff Layton <jlayton@kernel.org> --- security/apparmor/apparmorfs.c | 4 ++-- security/in...
{ "author": "Jeff Layton <jlayton@kernel.org>", "date": "Thu, 26 Feb 2026 10:55:53 -0500", "is_openbsd": false, "thread_id": "20260227-herab-wolken-c52d560f40d5@brauner.mbox.gz" }
lkml_critique
netdev
Christian said [1] to "just do it" when I proposed this, so here we are! For historical reasons, the inode->i_ino field is an unsigned long, which means that it's 32 bits on 32 bit architectures. This has caused a number of filesystems to implement hacks to hash a 64-bit identifier into a 32-bit field, and deprives us...
null
null
null
[PATCH 00/61] vfs: change inode->i_ino from unsigned long to u64
Update %lu to %llu in drm_info() calls that print inode->i_ino, since i_ino is now u64. Signed-off-by: Jeff Layton <jlayton@kernel.org> --- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c b/drivers/gpu/drm/am...
{ "author": "Jeff Layton <jlayton@kernel.org>", "date": "Thu, 26 Feb 2026 10:55:54 -0500", "is_openbsd": false, "thread_id": "20260227-herab-wolken-c52d560f40d5@brauner.mbox.gz" }
lkml_critique
netdev
Christian said [1] to "just do it" when I proposed this, so here we are! For historical reasons, the inode->i_ino field is an unsigned long, which means that it's 32 bits on 32 bit architectures. This has caused a number of filesystems to implement hacks to hash a 64-bit identifier into a 32-bit field, and deprives us...
null
null
null
[PATCH 00/61] vfs: change inode->i_ino from unsigned long to u64
Update %lx to %llx in inotify and fanotify fdinfo output for printing inode->i_ino, since i_ino is now u64. Signed-off-by: Jeff Layton <jlayton@kernel.org> --- fs/notify/fdinfo.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/notify/fdinfo.c b/fs/notify/fdinfo.c index 9cc7eb863643774b83da8...
{ "author": "Jeff Layton <jlayton@kernel.org>", "date": "Thu, 26 Feb 2026 10:55:55 -0500", "is_openbsd": false, "thread_id": "20260227-herab-wolken-c52d560f40d5@brauner.mbox.gz" }
lkml_critique
netdev
Christian said [1] to "just do it" when I proposed this, so here we are! For historical reasons, the inode->i_ino field is an unsigned long, which means that it's 32 bits on 32 bit architectures. This has caused a number of filesystems to implement hacks to hash a 64-bit identifier into a 32-bit field, and deprives us...
null
null
null
[PATCH 00/61] vfs: change inode->i_ino from unsigned long to u64
Update %lu to %llu in sockfs_dname() for printing i_ino, since i_ino is now u64. Signed-off-by: Jeff Layton <jlayton@kernel.org> --- net/socket.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/socket.c b/net/socket.c index 7aa94fce7a8b3d6beec7594e311e73fb52f371cc..3f4d2a867aa15b2d2aec1c9dfa00...
{ "author": "Jeff Layton <jlayton@kernel.org>", "date": "Thu, 26 Feb 2026 10:55:56 -0500", "is_openbsd": false, "thread_id": "20260227-herab-wolken-c52d560f40d5@brauner.mbox.gz" }
lkml_critique
netdev
Christian said [1] to "just do it" when I proposed this, so here we are! For historical reasons, the inode->i_ino field is an unsigned long, which means that it's 32 bits on 32 bit architectures. This has caused a number of filesystems to implement hacks to hash a 64-bit identifier into a 32-bit field, and deprives us...
null
null
null
[PATCH 00/61] vfs: change inode->i_ino from unsigned long to u64
Update %lx to %llx in uprobe warning messages for printing inode->i_ino, since i_ino is now u64. Signed-off-by: Jeff Layton <jlayton@kernel.org> --- kernel/events/uprobes.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/events/uprobes.c b/kernel/events/uprobes.c index 923b24b321cc0fbde...
{ "author": "Jeff Layton <jlayton@kernel.org>", "date": "Thu, 26 Feb 2026 10:55:57 -0500", "is_openbsd": false, "thread_id": "20260227-herab-wolken-c52d560f40d5@brauner.mbox.gz" }
lkml_critique
netdev
Christian said [1] to "just do it" when I proposed this, so here we are! For historical reasons, the inode->i_ino field is an unsigned long, which means that it's 32 bits on 32 bit architectures. This has caused a number of filesystems to implement hacks to hash a 64-bit identifier into a 32-bit field, and deprives us...
null
null
null
[PATCH 00/61] vfs: change inode->i_ino from unsigned long to u64
Update %lu to %llu in debugfs seq_printf for printing i_ino, since i_ino is now u64. Signed-off-by: Jeff Layton <jlayton@kernel.org> --- drivers/dma-buf/dma-buf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/dma-buf/dma-buf.c b/drivers/dma-buf/dma-buf.c index 11711874a325b954940fb289f09...
{ "author": "Jeff Layton <jlayton@kernel.org>", "date": "Thu, 26 Feb 2026 10:55:58 -0500", "is_openbsd": false, "thread_id": "20260227-herab-wolken-c52d560f40d5@brauner.mbox.gz" }
lkml_critique
netdev
Christian said [1] to "just do it" when I proposed this, so here we are! For historical reasons, the inode->i_ino field is an unsigned long, which means that it's 32 bits on 32 bit architectures. This has caused a number of filesystems to implement hacks to hash a 64-bit identifier into a 32-bit field, and deprives us...
null
null
null
[PATCH 00/61] vfs: change inode->i_ino from unsigned long to u64
Update format strings from %lu to %llu for inode->i_ino now that i_ino is u64 instead of unsigned long. Signed-off-by: Jeff Layton <jlayton@kernel.org> --- fs/crypto/crypto.c | 2 +- fs/crypto/hooks.c | 2 +- fs/crypto/keysetup.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/fs/crypto/cr...
{ "author": "Jeff Layton <jlayton@kernel.org>", "date": "Thu, 26 Feb 2026 10:55:59 -0500", "is_openbsd": false, "thread_id": "20260227-herab-wolken-c52d560f40d5@brauner.mbox.gz" }
lkml_critique
netdev
Christian said [1] to "just do it" when I proposed this, so here we are! For historical reasons, the inode->i_ino field is an unsigned long, which means that it's 32 bits on 32 bit architectures. This has caused a number of filesystems to implement hacks to hash a 64-bit identifier into a 32-bit field, and deprives us...
null
null
null
[PATCH 00/61] vfs: change inode->i_ino from unsigned long to u64
Update format string from %lu to %llu for inode->i_ino now that i_ino is u64 instead of unsigned long. Signed-off-by: Jeff Layton <jlayton@kernel.org> --- fs/verity/init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/verity/init.c b/fs/verity/init.c index d6520660858386d3b7d69b20a459dc27d801...
{ "author": "Jeff Layton <jlayton@kernel.org>", "date": "Thu, 26 Feb 2026 10:56:00 -0500", "is_openbsd": false, "thread_id": "20260227-herab-wolken-c52d560f40d5@brauner.mbox.gz" }
lkml_critique
netdev
Christian said [1] to "just do it" when I proposed this, so here we are! For historical reasons, the inode->i_ino field is an unsigned long, which means that it's 32 bits on 32 bit architectures. This has caused a number of filesystems to implement hacks to hash a 64-bit identifier into a 32-bit field, and deprives us...
null
null
null
[PATCH 00/61] vfs: change inode->i_ino from unsigned long to u64
Update format string from %lu to %llu for inode->i_ino now that i_ino is u64 instead of unsigned long. Signed-off-by: Jeff Layton <jlayton@kernel.org> --- fs/iomap/ioend.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/iomap/ioend.c b/fs/iomap/ioend.c index 4d1ef8a2cee90b91591d387f8e1c3f75350c...
{ "author": "Jeff Layton <jlayton@kernel.org>", "date": "Thu, 26 Feb 2026 10:56:01 -0500", "is_openbsd": false, "thread_id": "20260227-herab-wolken-c52d560f40d5@brauner.mbox.gz" }
lkml_critique
netdev
Christian said [1] to "just do it" when I proposed this, so here we are! For historical reasons, the inode->i_ino field is an unsigned long, which means that it's 32 bits on 32 bit architectures. This has caused a number of filesystems to implement hacks to hash a 64-bit identifier into a 32-bit field, and deprives us...
null
null
null
[PATCH 00/61] vfs: change inode->i_ino from unsigned long to u64
Update format strings from %ld to %lld and 0L literals to 0LL in x25, netrom, and rose proc output, now that i_ino is u64 instead of unsigned long. Signed-off-by: Jeff Layton <jlayton@kernel.org> --- net/netrom/af_netrom.c | 4 ++-- net/rose/af_rose.c | 4 ++-- net/x25/x25_proc.c | 4 ++-- 3 files changed, 6 ...
{ "author": "Jeff Layton <jlayton@kernel.org>", "date": "Thu, 26 Feb 2026 10:56:02 -0500", "is_openbsd": false, "thread_id": "20260227-herab-wolken-c52d560f40d5@brauner.mbox.gz" }
lkml_critique
netdev
Christian said [1] to "just do it" when I proposed this, so here we are! For historical reasons, the inode->i_ino field is an unsigned long, which means that it's 32 bits on 32 bit architectures. This has caused a number of filesystems to implement hacks to hash a 64-bit identifier into a 32-bit field, and deprives us...
null
null
null
[PATCH 00/61] vfs: change inode->i_ino from unsigned long to u64
Update format strings from %lu/%lx to %llu/%llx and 0UL literal to 0ULL in pipe, dcache, fserror, and eventpoll, now that i_ino is u64 instead of unsigned long. Signed-off-by: Jeff Layton <jlayton@kernel.org> --- fs/dcache.c | 4 ++-- fs/eventpoll.c | 2 +- fs/fserror.c | 2 +- fs/pipe.c | 2 +- 4 files cha...
{ "author": "Jeff Layton <jlayton@kernel.org>", "date": "Thu, 26 Feb 2026 10:56:03 -0500", "is_openbsd": false, "thread_id": "20260227-herab-wolken-c52d560f40d5@brauner.mbox.gz" }
lkml_critique
netdev
Christian said [1] to "just do it" when I proposed this, so here we are! For historical reasons, the inode->i_ino field is an unsigned long, which means that it's 32 bits on 32 bit architectures. This has caused a number of filesystems to implement hacks to hash a 64-bit identifier into a 32-bit field, and deprives us...
null
null
null
[PATCH 00/61] vfs: change inode->i_ino from unsigned long to u64
On Thu, Feb 26, 2026 at 10:56:01AM -0500, Jeff Layton wrote: Looks fine to me, though I'm a bit sad there's no xfs_inode::i_ino -> inode::i_ino conversion patch... ;) Reviewed-by: "Darrick J. Wong" <djwong@kernel.org> --D
{ "author": "\"Darrick J. Wong\" <djwong@kernel.org>", "date": "Thu, 26 Feb 2026 08:21:15 -0800", "is_openbsd": false, "thread_id": "20260227-herab-wolken-c52d560f40d5@brauner.mbox.gz" }
lkml_critique
netdev
Christian said [1] to "just do it" when I proposed this, so here we are! For historical reasons, the inode->i_ino field is an unsigned long, which means that it's 32 bits on 32 bit architectures. This has caused a number of filesystems to implement hacks to hash a 64-bit identifier into a 32-bit field, and deprives us...
null
null
null
[PATCH 00/61] vfs: change inode->i_ino from unsigned long to u64
On Thu, Feb 26, 2026 at 10:56:03AM -0500, Jeff Layton wrote: Acked-by: "Darrick J. Wong" <djwong@kernel.org> --D
{ "author": "\"Darrick J. Wong\" <djwong@kernel.org>", "date": "Thu, 26 Feb 2026 08:22:22 -0800", "is_openbsd": false, "thread_id": "20260227-herab-wolken-c52d560f40d5@brauner.mbox.gz" }
lkml_critique
netdev
Christian said [1] to "just do it" when I proposed this, so here we are! For historical reasons, the inode->i_ino field is an unsigned long, which means that it's 32 bits on 32 bit architectures. This has caused a number of filesystems to implement hacks to hash a 64-bit identifier into a 32-bit field, and deprives us...
null
null
null
[PATCH 00/61] vfs: change inode->i_ino from unsigned long to u64
On Thu, Feb 26, 2026 at 10:55:21AM -0500, Jeff Layton wrote: Acked-by: David Sterba <dsterba@suse.com>
{ "author": "David Sterba <dsterba@suse.cz>", "date": "Thu, 26 Feb 2026 17:49:15 +0100", "is_openbsd": false, "thread_id": "20260227-herab-wolken-c52d560f40d5@brauner.mbox.gz" }
lkml_critique
netdev
Christian said [1] to "just do it" when I proposed this, so here we are! For historical reasons, the inode->i_ino field is an unsigned long, which means that it's 32 bits on 32 bit architectures. This has caused a number of filesystems to implement hacks to hash a 64-bit identifier into a 32-bit field, and deprives us...
null
null
null
[PATCH 00/61] vfs: change inode->i_ino from unsigned long to u64
On Thu, Feb 26, 2026 at 10:55:02AM -0500, Jeff Layton wrote: Why are the format strings all done as separate patches? Don't we get bisection hazards by splitting it apart this way?
{ "author": "Matthew Wilcox <willy@infradead.org>", "date": "Thu, 26 Feb 2026 16:49:26 +0000", "is_openbsd": false, "thread_id": "20260227-herab-wolken-c52d560f40d5@brauner.mbox.gz" }
lkml_critique
netdev
Christian said [1] to "just do it" when I proposed this, so here we are! For historical reasons, the inode->i_ino field is an unsigned long, which means that it's 32 bits on 32 bit architectures. This has caused a number of filesystems to implement hacks to hash a 64-bit identifier into a 32-bit field, and deprives us...
null
null
null
[PATCH 00/61] vfs: change inode->i_ino from unsigned long to u64
On Thu 26-02-26 10:55:03, Jeff Layton wrote: Looks good. Feel free to add: Reviewed-by: Jan Kara <jack@suse.cz> Honza -- Jan Kara <jack@suse.com> SUSE Labs, CR
{ "author": "Jan Kara <jack@suse.cz>", "date": "Thu, 26 Feb 2026 18:00:36 +0100", "is_openbsd": false, "thread_id": "20260227-herab-wolken-c52d560f40d5@brauner.mbox.gz" }
lkml_critique
netdev
Christian said [1] to "just do it" when I proposed this, so here we are! For historical reasons, the inode->i_ino field is an unsigned long, which means that it's 32 bits on 32 bit architectures. This has caused a number of filesystems to implement hacks to hash a 64-bit identifier into a 32-bit field, and deprives us...
null
null
null
[PATCH 00/61] vfs: change inode->i_ino from unsigned long to u64
On Thu, 2026-02-26 at 16:49 +0000, Matthew Wilcox wrote: One big patch would be Yuuuuge. We could certainly do it that way, but it'll be nightmare if we ever do have to revert part of it. What do you suggest? -- Jeff Layton <jlayton@kernel.org>
{ "author": "Jeff Layton <jlayton@kernel.org>", "date": "Thu, 26 Feb 2026 12:01:42 -0500", "is_openbsd": false, "thread_id": "20260227-herab-wolken-c52d560f40d5@brauner.mbox.gz" }
lkml_critique
netdev
Christian said [1] to "just do it" when I proposed this, so here we are! For historical reasons, the inode->i_ino field is an unsigned long, which means that it's 32 bits on 32 bit architectures. This has caused a number of filesystems to implement hacks to hash a 64-bit identifier into a 32-bit field, and deprives us...
null
null
null
[PATCH 00/61] vfs: change inode->i_ino from unsigned long to u64
On Thu 26-02-26 10:55:05, Jeff Layton wrote: ... No need for explicit typing to ULL? And here as well? And many times below as well... Honza -- Jan Kara <jack@suse.com> SUSE Labs, CR
{ "author": "Jan Kara <jack@suse.cz>", "date": "Thu, 26 Feb 2026 18:11:06 +0100", "is_openbsd": false, "thread_id": "20260227-herab-wolken-c52d560f40d5@brauner.mbox.gz" }
lkml_critique
netdev
Christian said [1] to "just do it" when I proposed this, so here we are! For historical reasons, the inode->i_ino field is an unsigned long, which means that it's 32 bits on 32 bit architectures. This has caused a number of filesystems to implement hacks to hash a 64-bit identifier into a 32-bit field, and deprives us...
null
null
null
[PATCH 00/61] vfs: change inode->i_ino from unsigned long to u64
On Thu, Feb 26, 2026 at 10:55:59AM -0500, Jeff Layton wrote: check_for_busy_inodes() needs to be updated too. It copies i_ino to a local variable of type 'unsigned long', then prints it with %lu. Seems that there needs to be a search for other code that copies i_ino to a local variable, as this issue is unlikely to ...
{ "author": "Eric Biggers <ebiggers@kernel.org>", "date": "Thu, 26 Feb 2026 09:10:36 -0800", "is_openbsd": false, "thread_id": "20260227-herab-wolken-c52d560f40d5@brauner.mbox.gz" }
lkml_critique
netdev
Christian said [1] to "just do it" when I proposed this, so here we are! For historical reasons, the inode->i_ino field is an unsigned long, which means that it's 32 bits on 32 bit architectures. This has caused a number of filesystems to implement hacks to hash a 64-bit identifier into a 32-bit field, and deprives us...
null
null
null
[PATCH 00/61] vfs: change inode->i_ino from unsigned long to u64
On Thu 26-02-26 18:00:36, Jan Kara wrote: Thinking some more about this (and also seeing the discussion about patch 2) - maybe instead of using explicit u64 we should typedef kino_t as u64 and use that? Honza -- Jan Kara <jack@suse.com> SUSE Labs, CR
{ "author": "Jan Kara <jack@suse.cz>", "date": "Thu, 26 Feb 2026 18:14:45 +0100", "is_openbsd": false, "thread_id": "20260227-herab-wolken-c52d560f40d5@brauner.mbox.gz" }
lkml_critique
netdev
Christian said [1] to "just do it" when I proposed this, so here we are! For historical reasons, the inode->i_ino field is an unsigned long, which means that it's 32 bits on 32 bit architectures. This has caused a number of filesystems to implement hacks to hash a 64-bit identifier into a 32-bit field, and deprives us...
null
null
null
[PATCH 00/61] vfs: change inode->i_ino from unsigned long to u64
On Thu, 26 Feb 2026 10:55:05 -0500 Jeff Layton <jlayton@kernel.org> wrote: Hmm, on 32 bit systems, this will likely cause "holes" in a lot of these events. There was already a 2 byte hole here, but that's not a big deal. Might be better to reorder any of these that have int first. u64 inode; int obj; Will b...
{ "author": "Steven Rostedt <rostedt@goodmis.org>", "date": "Thu, 26 Feb 2026 12:48:42 -0500", "is_openbsd": false, "thread_id": "20260227-herab-wolken-c52d560f40d5@brauner.mbox.gz" }
lkml_critique
netdev
Christian said [1] to "just do it" when I proposed this, so here we are! For historical reasons, the inode->i_ino field is an unsigned long, which means that it's 32 bits on 32 bit architectures. This has caused a number of filesystems to implement hacks to hash a 64-bit identifier into a 32-bit field, and deprives us...
null
null
null
[PATCH 00/61] vfs: change inode->i_ino from unsigned long to u64
On Thu, 2026-02-26 at 18:11 +0100, Jan Kara wrote: Good catch. I'll clean those up. Thanks, -- Jeff Layton <jlayton@kernel.org>
{ "author": "Jeff Layton <jlayton@kernel.org>", "date": "Thu, 26 Feb 2026 12:53:42 -0500", "is_openbsd": false, "thread_id": "20260227-herab-wolken-c52d560f40d5@brauner.mbox.gz" }
lkml_critique
netdev
Christian said [1] to "just do it" when I proposed this, so here we are! For historical reasons, the inode->i_ino field is an unsigned long, which means that it's 32 bits on 32 bit architectures. This has caused a number of filesystems to implement hacks to hash a 64-bit identifier into a 32-bit field, and deprives us...
null
null
null
[PATCH 00/61] vfs: change inode->i_ino from unsigned long to u64
On Thu, 2026-02-26 at 10:55 -0500, Jeff Layton wrote: Looks good. Reviewed-by: Viacheslav Dubeyko <slava@dubeyko.com> Thanks, Slava.
{ "author": "Viacheslav Dubeyko <Slava.Dubeyko@ibm.com>", "date": "Thu, 26 Feb 2026 19:33:37 +0000", "is_openbsd": false, "thread_id": "20260227-herab-wolken-c52d560f40d5@brauner.mbox.gz" }
lkml_critique
netdev
Christian said [1] to "just do it" when I proposed this, so here we are! For historical reasons, the inode->i_ino field is an unsigned long, which means that it's 32 bits on 32 bit architectures. This has caused a number of filesystems to implement hacks to hash a 64-bit identifier into a 32-bit field, and deprives us...
null
null
null
[PATCH 00/61] vfs: change inode->i_ino from unsigned long to u64
On Thu, 2026-02-26 at 10:55 -0500, Jeff Layton wrote: Looks good. Reviewed-by: Viacheslav Dubeyko <Slava.Dubeyko@ibm.com> Thanks, Slava.
{ "author": "Viacheslav Dubeyko <Slava.Dubeyko@ibm.com>", "date": "Thu, 26 Feb 2026 19:37:12 +0000", "is_openbsd": false, "thread_id": "20260227-herab-wolken-c52d560f40d5@brauner.mbox.gz" }
lkml_critique
netdev
Christian said [1] to "just do it" when I proposed this, so here we are! For historical reasons, the inode->i_ino field is an unsigned long, which means that it's 32 bits on 32 bit architectures. This has caused a number of filesystems to implement hacks to hash a 64-bit identifier into a 32-bit field, and deprives us...
null
null
null
[PATCH 00/61] vfs: change inode->i_ino from unsigned long to u64
On Thu, 2026-02-26 at 10:55 -0500, Jeff Layton wrote: I think you missed 'inode=%lu' here. Ditto. You missed 'inode=%lu' here. Thanks, Slava.
{ "author": "Viacheslav Dubeyko <Slava.Dubeyko@ibm.com>", "date": "Thu, 26 Feb 2026 19:46:35 +0000", "is_openbsd": false, "thread_id": "20260227-herab-wolken-c52d560f40d5@brauner.mbox.gz" }
lkml_critique
netdev
Christian said [1] to "just do it" when I proposed this, so here we are! For historical reasons, the inode->i_ino field is an unsigned long, which means that it's 32 bits on 32 bit architectures. This has caused a number of filesystems to implement hacks to hash a 64-bit identifier into a 32-bit field, and deprives us...
null
null
null
[PATCH 00/61] vfs: change inode->i_ino from unsigned long to u64
On 2/26/26 10:55 AM, Jeff Layton wrote: Suggestion: Let's use the %llu format specifier consistently for inode->i_ino, which is unsigned. Reviewed-by: Chuck Lever <chuck.lever@oracle.com> -- Chuck Lever
{ "author": "Chuck Lever <chuck.lever@oracle.com>", "date": "Thu, 26 Feb 2026 14:48:28 -0500", "is_openbsd": false, "thread_id": "20260227-herab-wolken-c52d560f40d5@brauner.mbox.gz" }
lkml_critique
netdev
Christian said [1] to "just do it" when I proposed this, so here we are! For historical reasons, the inode->i_ino field is an unsigned long, which means that it's 32 bits on 32 bit architectures. This has caused a number of filesystems to implement hacks to hash a 64-bit identifier into a 32-bit field, and deprives us...
null
null
null
[PATCH 00/61] vfs: change inode->i_ino from unsigned long to u64
On Thu, 2026-02-26 at 19:46 +0000, Viacheslav Dubeyko wrote: That is actually the placeholder for this: (unsigned long)le64_to_cpu(p->inode) ...which is not inode->i_ino. I do agree that the cast probably no longer makes sense with this change, but I'd probably leave that to a later cleanup so we can keep this s...
{ "author": "Jeff Layton <jlayton@kernel.org>", "date": "Thu, 26 Feb 2026 15:06:03 -0500", "is_openbsd": false, "thread_id": "20260227-herab-wolken-c52d560f40d5@brauner.mbox.gz" }
lkml_critique
netdev
Christian said [1] to "just do it" when I proposed this, so here we are! For historical reasons, the inode->i_ino field is an unsigned long, which means that it's 32 bits on 32 bit architectures. This has caused a number of filesystems to implement hacks to hash a 64-bit identifier into a 32-bit field, and deprives us...
null
null
null
[PATCH 00/61] vfs: change inode->i_ino from unsigned long to u64
On Thu, 2026-02-26 at 14:48 -0500, Chuck Lever wrote: Good plan. I'll have claude do a pass for that in the next set. -- Jeff Layton <jlayton@kernel.org>
{ "author": "Jeff Layton <jlayton@kernel.org>", "date": "Thu, 26 Feb 2026 15:06:36 -0500", "is_openbsd": false, "thread_id": "20260227-herab-wolken-c52d560f40d5@brauner.mbox.gz" }
lkml_critique
netdev
Christian said [1] to "just do it" when I proposed this, so here we are! For historical reasons, the inode->i_ino field is an unsigned long, which means that it's 32 bits on 32 bit architectures. This has caused a number of filesystems to implement hacks to hash a 64-bit identifier into a 32-bit field, and deprives us...
null
null
null
[PATCH 00/61] vfs: change inode->i_ino from unsigned long to u64
On Thu, 2026-02-26 at 15:06 -0500, Jeff Layton wrote: I see your point. Makes sense. The rest looks good. Reviewed-by: Viacheslav Dubeyko <slava@dubeyko.com> Thanks, Slava.
{ "author": "Viacheslav Dubeyko <Slava.Dubeyko@ibm.com>", "date": "Thu, 26 Feb 2026 20:09:23 +0000", "is_openbsd": false, "thread_id": "20260227-herab-wolken-c52d560f40d5@brauner.mbox.gz" }
lkml_critique
netdev
Christian said [1] to "just do it" when I proposed this, so here we are! For historical reasons, the inode->i_ino field is an unsigned long, which means that it's 32 bits on 32 bit architectures. This has caused a number of filesystems to implement hacks to hash a 64-bit identifier into a 32-bit field, and deprives us...
null
null
null
[PATCH 00/61] vfs: change inode->i_ino from unsigned long to u64
On Thu, Feb 26, 2026 at 11:06 AM Jeff Layton <jlayton@kernel.org> wrote: ... Everything in security/lsm_audit.c looks okay. Additionally, later in this function there are pr_notice_ratelimited() and pr_warn() calls that print inode numbers and need to be updated. -- paul-moore.com
{ "author": "Paul Moore <paul@paul-moore.com>", "date": "Thu, 26 Feb 2026 16:11:41 -0500", "is_openbsd": false, "thread_id": "20260227-herab-wolken-c52d560f40d5@brauner.mbox.gz" }
lkml_critique
netdev
Christian said [1] to "just do it" when I proposed this, so here we are! For historical reasons, the inode->i_ino field is an unsigned long, which means that it's 32 bits on 32 bit architectures. This has caused a number of filesystems to implement hacks to hash a 64-bit identifier into a 32-bit field, and deprives us...
null
null
null
[PATCH 00/61] vfs: change inode->i_ino from unsigned long to u64
On 2/27/26 00:55, Jeff Layton wrote: Acked-by: Damien Le Moal <dlemoal@kernel.org> -- Damien Le Moal Western Digital Research
{ "author": "Damien Le Moal <dlemoal@kernel.org>", "date": "Fri, 27 Feb 2026 07:45:32 +0900", "is_openbsd": false, "thread_id": "20260227-herab-wolken-c52d560f40d5@brauner.mbox.gz" }
lkml_critique
netdev
Christian said [1] to "just do it" when I proposed this, so here we are! For historical reasons, the inode->i_ino field is an unsigned long, which means that it's 32 bits on 32 bit architectures. This has caused a number of filesystems to implement hacks to hash a 64-bit identifier into a 32-bit field, and deprives us...
null
null
null
[PATCH 00/61] vfs: change inode->i_ino from unsigned long to u64
On 2/27/26 00:55, Jeff Layton wrote: [...] Do we really need this cast here ? (same comment for the following events). Other than this, this looks OK to me. Reviewed-by: Damien Le Moal <dlemoal@kernel.org> -- Damien Le Moal Western Digital Research
{ "author": "Damien Le Moal <dlemoal@kernel.org>", "date": "Fri, 27 Feb 2026 07:51:43 +0900", "is_openbsd": false, "thread_id": "20260227-herab-wolken-c52d560f40d5@brauner.mbox.gz" }
lkml_critique
netdev
Christian said [1] to "just do it" when I proposed this, so here we are! For historical reasons, the inode->i_ino field is an unsigned long, which means that it's 32 bits on 32 bit architectures. This has caused a number of filesystems to implement hacks to hash a 64-bit identifier into a 32-bit field, and deprives us...
null
null
null
[PATCH 00/61] vfs: change inode->i_ino from unsigned long to u64
On 2/27/26 00:55, Jeff Layton wrote: [...] Hmmm. the type of ino in struct inode is changed in patch 2, not this patch. So this feels incorrect. Why not just squash patch 2 in here ? While at it, maybe you could change this to use pr_debug() too ? -- Damien Le Moal Western Digital Research
{ "author": "Damien Le Moal <dlemoal@kernel.org>", "date": "Fri, 27 Feb 2026 07:56:18 +0900", "is_openbsd": false, "thread_id": "20260227-herab-wolken-c52d560f40d5@brauner.mbox.gz" }
lkml_critique
netdev
Christian said [1] to "just do it" when I proposed this, so here we are! For historical reasons, the inode->i_ino field is an unsigned long, which means that it's 32 bits on 32 bit architectures. This has caused a number of filesystems to implement hacks to hash a 64-bit identifier into a 32-bit field, and deprives us...
null
null
null
[PATCH 00/61] vfs: change inode->i_ino from unsigned long to u64
On 2/26/26 16:55, Jeff Layton wrote: Sounds reasonable to me, should get_next_ino() also be changed to return an 64bit ino? Currently it is always only 32bit and we have workarounds for that in DMA-buf for example. Thanks, Christian.
{ "author": "=?UTF-8?Q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>", "date": "Fri, 27 Feb 2026 10:30:57 +0100", "is_openbsd": false, "thread_id": "20260227-herab-wolken-c52d560f40d5@brauner.mbox.gz" }
lkml_critique
netdev
Christian said [1] to "just do it" when I proposed this, so here we are! For historical reasons, the inode->i_ino field is an unsigned long, which means that it's 32 bits on 32 bit architectures. This has caused a number of filesystems to implement hacks to hash a 64-bit identifier into a 32-bit field, and deprives us...
null
null
null
[PATCH 00/61] vfs: change inode->i_ino from unsigned long to u64
On Thu, Feb 26, 2026 at 10:55:02AM -0500, Jeff Layton wrote: I'm working under the assumption that we have crossed the threshold and people send patches they did completely themselves and also patches that were done with the help of or almost completely by a tool. You have to defend it one way or the other. Frankly, ...
{ "author": "Christian Brauner <brauner@kernel.org>", "date": "Fri, 27 Feb 2026 11:06:39 +0100", "is_openbsd": false, "thread_id": "20260227-herab-wolken-c52d560f40d5@brauner.mbox.gz" }
lkml_critique
netdev
Christian said [1] to "just do it" when I proposed this, so here we are! For historical reasons, the inode->i_ino field is an unsigned long, which means that it's 32 bits on 32 bit architectures. This has caused a number of filesystems to implement hacks to hash a 64-bit identifier into a 32-bit field, and deprives us...
null
null
null
[PATCH 00/61] vfs: change inode->i_ino from unsigned long to u64
On Fri, 2026-02-27 at 10:30 +0100, Christian König wrote: I'm not opposed to doing that, but I'd probably leave that for a follow-on cleanup. Just doing the i_ino conversion is already making for a huge patchset. -- Jeff Layton <jlayton@kernel.org>
{ "author": "Jeff Layton <jlayton@kernel.org>", "date": "Fri, 27 Feb 2026 06:52:16 -0500", "is_openbsd": false, "thread_id": "20260227-herab-wolken-c52d560f40d5@brauner.mbox.gz" }
lkml_critique
netdev
The current SMC-R implementation relies on global per-device CQs and manual polling within tasklets, which introduces severe scalability bottlenecks due to global lock contention and tasklet scheduling overhead, resulting in poor performance as concurrency increases. Refactor the completion handling to utilize the ib_...
null
null
null
[PATCH RFC net-next] net/smc: transition to RDMA core CQ pooling
On Mon, Feb 02, 2026 at 05:48:00PM +0800, D. Wythe wrote: Thanks for the conversion, it looks great. I just wonder, why did you mark this as an RFC? Thanks
{ "author": "Leon Romanovsky <leon@kernel.org>", "date": "Mon, 2 Feb 2026 14:30:32 +0200", "is_openbsd": false, "thread_id": "20260227092931.GA129122@j66a10360.sqa.eu95.mbox.gz" }
lkml_critique
netdev
The current SMC-R implementation relies on global per-device CQs and manual polling within tasklets, which introduces severe scalability bottlenecks due to global lock contention and tasklet scheduling overhead, resulting in poor performance as concurrency increases. Refactor the completion handling to utilize the ib_...
null
null
null
[PATCH RFC net-next] net/smc: transition to RDMA core CQ pooling
On Mon, Feb 02, 2026 at 02:30:32PM +0200, Leon Romanovsky wrote: I usually mark patches involving complex changes as RFC first to solicit early feedback from the community. No other reason. Best regards, D. Wythe
{ "author": "\"D. Wythe\" <alibuda@linux.alibaba.com >", "date": "Tue, 3 Feb 2026 17:24:37 +0800", "is_openbsd": false, "thread_id": "20260227092931.GA129122@j66a10360.sqa.eu95.mbox.gz" }
lkml_critique
netdev
The current SMC-R implementation relies on global per-device CQs and manual polling within tasklets, which introduces severe scalability bottlenecks due to global lock contention and tasklet scheduling overhead, resulting in poor performance as concurrency increases. Refactor the completion handling to utilize the ib_...
null
null
null
[PATCH RFC net-next] net/smc: transition to RDMA core CQ pooling
On 02/02/26 3:18 pm, D. Wythe wrote: I applied your patch to the latest kernel(6.19-rc8) & saw below Performance results: 1) In my evaluation, I ran several *uperf* based workloads using a request/response (RR) pattern, and I observed performance *degradation* ranging from *4%* to *59%*, depending on the specific rea...
{ "author": "Mahanta Jambigi <mjambigi@linux.ibm.com>", "date": "Fri, 6 Feb 2026 16:58:23 +0530", "is_openbsd": false, "thread_id": "20260227092931.GA129122@j66a10360.sqa.eu95.mbox.gz" }
lkml_critique
netdev
The current SMC-R implementation relies on global per-device CQs and manual polling within tasklets, which introduces severe scalability bottlenecks due to global lock contention and tasklet scheduling overhead, resulting in poor performance as concurrency increases. Refactor the completion handling to utilize the ib_...
null
null
null
[PATCH RFC net-next] net/smc: transition to RDMA core CQ pooling
On Fri, Feb 06, 2026 at 04:58:23PM +0530, Mahanta Jambigi wrote: The only setting I changed was net.smc.smcr_max_conns_per_lgr = 32, all other parameters were left at their default values. redis-benchmark is a classic Request/Response (RR) workload, which contradicts your test results. Since I'm unable to reproduce yo...
{ "author": "\"D. Wythe\" <alibuda@linux.alibaba.com >", "date": "Mon, 9 Feb 2026 15:53:38 +0800", "is_openbsd": false, "thread_id": "20260227092931.GA129122@j66a10360.sqa.eu95.mbox.gz" }
lkml_critique
netdev
The current SMC-R implementation relies on global per-device CQs and manual polling within tasklets, which introduces severe scalability bottlenecks due to global lock contention and tasklet scheduling overhead, resulting in poor performance as concurrency increases. Refactor the completion handling to utilize the ib_...
null
null
null
[PATCH RFC net-next] net/smc: transition to RDMA core CQ pooling
On 2026-02-02 17:48:00, D. Wythe wrote: Excellent ! Some comments below. The initialized in smcibdev has no references now, it's better to remove it. How about index -> idx. Other index fields use idx abbr in SMC. I think this isn't unlikey, we haven't signal the RDMA WRITE wr, so it shouldn't have CQEs when w...
{ "author": "Dust Li <dust.li@linux.alibaba.com>", "date": "Wed, 11 Feb 2026 20:51:30 +0800", "is_openbsd": false, "thread_id": "20260227092931.GA129122@j66a10360.sqa.eu95.mbox.gz" }
lkml_critique
netdev
The current SMC-R implementation relies on global per-device CQs and manual polling within tasklets, which introduces severe scalability bottlenecks due to global lock contention and tasklet scheduling overhead, resulting in poor performance as concurrency increases. Refactor the completion handling to utilize the ib_...
null
null
null
[PATCH RFC net-next] net/smc: transition to RDMA core CQ pooling
On Wed, Feb 11, 2026 at 08:51:30PM +0800, Dust Li wrote: Nice catch, I mixed this up with the rwwi version. Looks like I accidentally deleted this code, I will restore it in the next version. Sounds reasonable, I'll implement this in the next version. Additionally, other items like removing redundant fields and re...
{ "author": "\"D. Wythe\" <alibuda@linux.alibaba.com >", "date": "Thu, 12 Feb 2026 17:35:37 +0800", "is_openbsd": false, "thread_id": "20260227092931.GA129122@j66a10360.sqa.eu95.mbox.gz" }
lkml_critique
netdev
The current SMC-R implementation relies on global per-device CQs and manual polling within tasklets, which introduces severe scalability bottlenecks due to global lock contention and tasklet scheduling overhead, resulting in poor performance as concurrency increases. Refactor the completion handling to utilize the ib_...
null
null
null
[PATCH RFC net-next] net/smc: transition to RDMA core CQ pooling
On 09/02/26 1:23 pm, D. Wythe wrote: I used a simple client–server setup connected via 25 Gb/s RoCE_Express2 adapters on the same LAN(connection established via SMC-R v1). After running the commands shown below, I observed a performance degradation of up to 59%. Server: smc_run uperf -s Client: smc_run uperf -m rr1c-...
{ "author": "Mahanta Jambigi <mjambigi@linux.ibm.com>", "date": "Fri, 13 Feb 2026 16:53:28 +0530", "is_openbsd": false, "thread_id": "20260227092931.GA129122@j66a10360.sqa.eu95.mbox.gz" }
lkml_critique
netdev
The current SMC-R implementation relies on global per-device CQs and manual polling within tasklets, which introduces severe scalability bottlenecks due to global lock contention and tasklet scheduling overhead, resulting in poor performance as concurrency increases. Refactor the completion handling to utilize the ib_...
null
null
null
[PATCH RFC net-next] net/smc: transition to RDMA core CQ pooling
On 02/02/26 3:18 pm, D. Wythe wrote: This new struct is used for recv only. May I know if we need to have the same for send(struct smc_ib_send_wr)? e.g struct smc_ib_send_wr *wr_tx_ibs member in struct smc_link? This should be an unsigned int, as seen in ib_cq_pool_put(2nd arg). My suggestion would be to have a co...
{ "author": "Mahanta Jambigi <mjambigi@linux.ibm.com>", "date": "Mon, 23 Feb 2026 18:01:38 +0530", "is_openbsd": false, "thread_id": "20260227092931.GA129122@j66a10360.sqa.eu95.mbox.gz" }
lkml_critique
netdev
The current SMC-R implementation relies on global per-device CQs and manual polling within tasklets, which introduces severe scalability bottlenecks due to global lock contention and tasklet scheduling overhead, resulting in poor performance as concurrency increases. Refactor the completion handling to utilize the ib_...
null
null
null
[PATCH RFC net-next] net/smc: transition to RDMA core CQ pooling
On Fri, Feb 13, 2026 at 04:53:28PM +0530, Mahanta Jambigi wrote: Using the exact same XML profile you provided, I tested this on a 25Gb NIC. I observed no degradation. Instead, performance improved significantly: Original: ~1.08 Gb/s Patched: ~5.1 Gb/s I suspect the 59% drop might be due to connections falling back ...
{ "author": "\"D. Wythe\" <alibuda@linux.alibaba.com >", "date": "Tue, 24 Feb 2026 10:19:24 +0800", "is_openbsd": false, "thread_id": "20260227092931.GA129122@j66a10360.sqa.eu95.mbox.gz" }
lkml_critique
netdev
The current SMC-R implementation relies on global per-device CQs and manual polling within tasklets, which introduces severe scalability bottlenecks due to global lock contention and tasklet scheduling overhead, resulting in poor performance as concurrency increases. Refactor the completion handling to utilize the ib_...
null
null
null
[PATCH RFC net-next] net/smc: transition to RDMA core CQ pooling
On Mon, Feb 23, 2026 at 06:01:38PM +0530, Mahanta Jambigi wrote: I placed the send ib_cqe in smc_wr_tx_pend in this version. However, I agree that introducing a symmetric smc_ib_send_wr is much more reasonable. I'll update this in the next version. Take it. Good point. But to support different polling contexts (like...
{ "author": "\"D. Wythe\" <alibuda@linux.alibaba.com >", "date": "Tue, 24 Feb 2026 14:56:24 +0800", "is_openbsd": false, "thread_id": "20260227092931.GA129122@j66a10360.sqa.eu95.mbox.gz" }
lkml_critique
netdev
The current SMC-R implementation relies on global per-device CQs and manual polling within tasklets, which introduces severe scalability bottlenecks due to global lock contention and tasklet scheduling overhead, resulting in poor performance as concurrency increases. Refactor the completion handling to utilize the ib_...
null
null
null
[PATCH RFC net-next] net/smc: transition to RDMA core CQ pooling
On 24/02/26 7:49 am, D. Wythe wrote: I have checked this. The connection was successful using *SMCR* Mode itself. Also I have confirmed this via 'smcr -d stats' command which shows 0 count for TCP fallback.
{ "author": "Mahanta Jambigi <mjambigi@linux.ibm.com>", "date": "Fri, 27 Feb 2026 10:11:38 +0530", "is_openbsd": false, "thread_id": "20260227092931.GA129122@j66a10360.sqa.eu95.mbox.gz" }
lkml_critique
netdev
The current SMC-R implementation relies on global per-device CQs and manual polling within tasklets, which introduces severe scalability bottlenecks due to global lock contention and tasklet scheduling overhead, resulting in poor performance as concurrency increases. Refactor the completion handling to utilize the ib_...
null
null
null
[PATCH RFC net-next] net/smc: transition to RDMA core CQ pooling
On Fri, Feb 27, 2026 at 10:11:38AM +0530, Mahanta Jambigi wrote: Given that fallback is ruled out, and a 59% drop is quite massive, especially since I'm seeing a significant improvement on my end. Since I am unable to reproduce this locally, I would suggest analyzing the CPU consumption and perf profiles in your envi...
{ "author": "\"D. Wythe\" <alibuda@linux.alibaba.com >", "date": "Fri, 27 Feb 2026 17:29:31 +0800", "is_openbsd": false, "thread_id": "20260227092931.GA129122@j66a10360.sqa.eu95.mbox.gz" }
lkml_critique
netdev
This is part 2 of the qcom-ethqos series, part 1 has now been merged. This part of the series focuses on the generic PHY driver, but these changes have dependencies on the ethernet driver, hence why it will need to go via net-next. Furthermore, subsequent changes depend on these patches. The underlying ideas here are...
null
null
null
[PATCH RESEND2 net-next 0/8] net: stmmac: qcom-ethqos: further serdes reorganisation
Combine ethqos_set_serdes_speed() with ethqos_mac_finish_serdes() to simplify the code. Reviewed-by: Mohd Ayaan Anwar <mohd.anwar@oss.qualcomm.com> Tested-by: Mohd Ayaan Anwar <mohd.anwar@oss.qualcomm.com> Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk> --- .../stmicro/stmmac/dwmac-qcom-ethqos.c ...
{ "author": "\"Russell King (Oracle)\" <rmk+kernel@armlinux.org.uk>", "date": "Thu, 26 Feb 2026 23:09:22 +0000", "is_openbsd": false, "thread_id": "20260227153901.qor4rtvtxur2zywh@skbuf.mbox.gz" }
lkml_critique
netdev
This is part 2 of the qcom-ethqos series, part 1 has now been merged. This part of the series focuses on the generic PHY driver, but these changes have dependencies on the ethernet driver, hence why it will need to go via net-next. Furthermore, subsequent changes depend on these patches. The underlying ideas here are...
null
null
null
[PATCH RESEND2 net-next 0/8] net: stmmac: qcom-ethqos: further serdes reorganisation
qcom-sgmii-eth is an Ethernet SerDes supporting only Ethernet mode using SGMII, 1000BASE-X and 2500BASE-X. Add an implementation of the .set_mode() method, which can be used instead of or as well as the .set_speed() method. The Ethernet interface modes mentioned above all have a fixed data rate, so setting the mode is...
{ "author": "\"Russell King (Oracle)\" <rmk+kernel@armlinux.org.uk>", "date": "Thu, 26 Feb 2026 23:09:27 +0000", "is_openbsd": false, "thread_id": "20260227153901.qor4rtvtxur2zywh@skbuf.mbox.gz" }
lkml_critique
netdev
This is part 2 of the qcom-ethqos series, part 1 has now been merged. This part of the series focuses on the generic PHY driver, but these changes have dependencies on the ethernet driver, hence why it will need to go via net-next. Furthermore, subsequent changes depend on these patches. The underlying ideas here are...
null
null
null
[PATCH RESEND2 net-next 0/8] net: stmmac: qcom-ethqos: further serdes reorganisation
qcom-sgmii-eth now accepts the phy_set_mode*() calls to configure the SerDes, taking a PHY interface mode rather than a speed. This allows the elimination of the interface mode to speed conversion in ethqos_mac_finish_serdes(). Tested-by: Mohd Ayaan Anwar <mohd.anwar@oss.qualcomm.com> Signed-off-by: Russell King (Orac...
{ "author": "\"Russell King (Oracle)\" <rmk+kernel@armlinux.org.uk>", "date": "Thu, 26 Feb 2026 23:09:32 +0000", "is_openbsd": false, "thread_id": "20260227153901.qor4rtvtxur2zywh@skbuf.mbox.gz" }
lkml_critique
netdev
This is part 2 of the qcom-ethqos series, part 1 has now been merged. This part of the series focuses on the generic PHY driver, but these changes have dependencies on the ethernet driver, hence why it will need to go via net-next. Furthermore, subsequent changes depend on these patches. The underlying ideas here are...
null
null
null
[PATCH RESEND2 net-next 0/8] net: stmmac: qcom-ethqos: further serdes reorganisation
Now that the qcom-ethqos driver has migrated to use phy_set_mode_ext() rather than phy_set_speed() to configure the SerDes, the support for phy_set_speed() is now obsolete. Remove support for this method. Using the MAC speed for the SerDes is never correct due to the PCS encoding. For SGMII and 2500BASE-X, the PCS use...
{ "author": "\"Russell King (Oracle)\" <rmk+kernel@armlinux.org.uk>", "date": "Thu, 26 Feb 2026 23:09:37 +0000", "is_openbsd": false, "thread_id": "20260227153901.qor4rtvtxur2zywh@skbuf.mbox.gz" }
lkml_critique
netdev
This is part 2 of the qcom-ethqos series, part 1 has now been merged. This part of the series focuses on the generic PHY driver, but these changes have dependencies on the ethernet driver, hence why it will need to go via net-next. Furthermore, subsequent changes depend on these patches. The underlying ideas here are...
null
null
null
[PATCH RESEND2 net-next 0/8] net: stmmac: qcom-ethqos: further serdes reorganisation
As established in the previous commit, using SPEED_1000 and SPEED_2500 does not make sense for a SerDes due to the PCS encoding that is used over the SerDes link, which inflates the data rate at the SerDes. Thus, the use of these constants in a SerDes driver is incorrect. Since qcom-sgmii-eth no longer implements phy_...
{ "author": "\"Russell King (Oracle)\" <rmk+kernel@armlinux.org.uk>", "date": "Thu, 26 Feb 2026 23:09:42 +0000", "is_openbsd": false, "thread_id": "20260227153901.qor4rtvtxur2zywh@skbuf.mbox.gz" }
lkml_critique
netdev
This is part 2 of the qcom-ethqos series, part 1 has now been merged. This part of the series focuses on the generic PHY driver, but these changes have dependencies on the ethernet driver, hence why it will need to go via net-next. Furthermore, subsequent changes depend on these patches. The underlying ideas here are...
null
null
null
[PATCH RESEND2 net-next 0/8] net: stmmac: qcom-ethqos: further serdes reorganisation
Now that qcom_dwmac_sgmii_phy_interface() only serves to validate the passed interface mode, combine it with qcom_dwmac_sgmii_phy_validate(), and use qcom_dwmac_sgmii_phy_validate() to validate the mode in qcom_dwmac_sgmii_phy_set_mode(). Tested-by: Mohd Ayaan Anwar <mohd.anwar@oss.qualcomm.com> Signed-off-by: Russell...
{ "author": "\"Russell King (Oracle)\" <rmk+kernel@armlinux.org.uk>", "date": "Thu, 26 Feb 2026 23:09:47 +0000", "is_openbsd": false, "thread_id": "20260227153901.qor4rtvtxur2zywh@skbuf.mbox.gz" }
lkml_critique
netdev
This is part 2 of the qcom-ethqos series, part 1 has now been merged. This part of the series focuses on the generic PHY driver, but these changes have dependencies on the ethernet driver, hence why it will need to go via net-next. Furthermore, subsequent changes depend on these patches. The underlying ideas here are...
null
null
null
[PATCH RESEND2 net-next 0/8] net: stmmac: qcom-ethqos: further serdes reorganisation
Allow any order of the .power_on() and .set_mode*() methods as per the recent discussion. This means phy_power_on() with this SerDes will now restore the previous setup without requiring a subsequent phy_set_mode*() call. Tested-by: Mohd Ayaan Anwar <mohd.anwar@oss.qualcomm.com> Signed-off-by: Russell King (Oracle) <r...
{ "author": "\"Russell King (Oracle)\" <rmk+kernel@armlinux.org.uk>", "date": "Thu, 26 Feb 2026 23:09:52 +0000", "is_openbsd": false, "thread_id": "20260227153901.qor4rtvtxur2zywh@skbuf.mbox.gz" }
lkml_critique
netdev
This is part 2 of the qcom-ethqos series, part 1 has now been merged. This part of the series focuses on the generic PHY driver, but these changes have dependencies on the ethernet driver, hence why it will need to go via net-next. Furthermore, subsequent changes depend on these patches. The underlying ideas here are...
null
null
null
[PATCH RESEND2 net-next 0/8] net: stmmac: qcom-ethqos: further serdes reorganisation
The call to phy_set_mode_ext() after phy_power_on() was a work-around for the qcom-sgmii-eth SerDes driver that only re-enabled its clocks on phy_power_on() but did not configure the PHY. Now that the SerDes driver fully configures the SerDes at phy_power_on(), there is no need to call phy_set_mode_ext() immediately af...
{ "author": "\"Russell King (Oracle)\" <rmk+kernel@armlinux.org.uk>", "date": "Thu, 26 Feb 2026 23:09:57 +0000", "is_openbsd": false, "thread_id": "20260227153901.qor4rtvtxur2zywh@skbuf.mbox.gz" }
lkml_critique
netdev
This is part 2 of the qcom-ethqos series, part 1 has now been merged. This part of the series focuses on the generic PHY driver, but these changes have dependencies on the ethernet driver, hence why it will need to go via net-next. Furthermore, subsequent changes depend on these patches. The underlying ideas here are...
null
null
null
[PATCH RESEND2 net-next 0/8] net: stmmac: qcom-ethqos: further serdes reorganisation
On Thu, 26 Feb 2026 23:07:16 +0000 Russell King (Oracle) wrote: The only exception to the 24h rule is if a reviewer _asks_ you to repost ASAP. Maintainers also wait, there are no exceptions. Please don't do this again. Having to deal with multi-tier system of privileges and rules will make our (maintainers) job even ...
{ "author": "Jakub Kicinski <kuba@kernel.org>", "date": "Thu, 26 Feb 2026 17:26:42 -0800", "is_openbsd": false, "thread_id": "20260227153901.qor4rtvtxur2zywh@skbuf.mbox.gz" }
lkml_critique
netdev
This is part 2 of the qcom-ethqos series, part 1 has now been merged. This part of the series focuses on the generic PHY driver, but these changes have dependencies on the ethernet driver, hence why it will need to go via net-next. Furthermore, subsequent changes depend on these patches. The underlying ideas here are...
null
null
null
[PATCH RESEND2 net-next 0/8] net: stmmac: qcom-ethqos: further serdes reorganisation
On Thu, Feb 26, 2026 at 11:09:57PM +0000, Russell King (Oracle) wrote: Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>
{ "author": "Vladimir Oltean <olteanv@gmail.com>", "date": "Fri, 27 Feb 2026 17:31:15 +0200", "is_openbsd": false, "thread_id": "20260227153901.qor4rtvtxur2zywh@skbuf.mbox.gz" }
lkml_critique
netdev
This is part 2 of the qcom-ethqos series, part 1 has now been merged. This part of the series focuses on the generic PHY driver, but these changes have dependencies on the ethernet driver, hence why it will need to go via net-next. Furthermore, subsequent changes depend on these patches. The underlying ideas here are...
null
null
null
[PATCH RESEND2 net-next 0/8] net: stmmac: qcom-ethqos: further serdes reorganisation
On Thu, Feb 26, 2026 at 11:09:52PM +0000, Russell King (Oracle) wrote: Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>
{ "author": "Vladimir Oltean <olteanv@gmail.com>", "date": "Fri, 27 Feb 2026 17:37:41 +0200", "is_openbsd": false, "thread_id": "20260227153901.qor4rtvtxur2zywh@skbuf.mbox.gz" }
lkml_critique
netdev
This is part 2 of the qcom-ethqos series, part 1 has now been merged. This part of the series focuses on the generic PHY driver, but these changes have dependencies on the ethernet driver, hence why it will need to go via net-next. Furthermore, subsequent changes depend on these patches. The underlying ideas here are...
null
null
null
[PATCH RESEND2 net-next 0/8] net: stmmac: qcom-ethqos: further serdes reorganisation
On Thu, Feb 26, 2026 at 11:09:37PM +0000, Russell King (Oracle) wrote: Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>
{ "author": "Vladimir Oltean <olteanv@gmail.com>", "date": "Fri, 27 Feb 2026 17:39:01 +0200", "is_openbsd": false, "thread_id": "20260227153901.qor4rtvtxur2zywh@skbuf.mbox.gz" }
lkml_critique
netdev
This is part 2 of the qcom-ethqos series, part 1 has now been merged. This part of the series focuses on the generic PHY driver, but these changes have dependencies on the ethernet driver, hence why it will need to go via net-next. Furthermore, subsequent changes depend on these patches. The underlying ideas here are...
null
null
null
[PATCH RESEND2 net-next 0/8] net: stmmac: qcom-ethqos: further serdes reorganisation
On Thu, Feb 26, 2026 at 11:09:42PM +0000, Russell King (Oracle) wrote: Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>
{ "author": "Vladimir Oltean <olteanv@gmail.com>", "date": "Fri, 27 Feb 2026 17:40:26 +0200", "is_openbsd": false, "thread_id": "20260227153901.qor4rtvtxur2zywh@skbuf.mbox.gz" }
lkml_critique
netdev
This is part 2 of the qcom-ethqos series, part 1 has now been merged. This part of the series focuses on the generic PHY driver, but these changes have dependencies on the ethernet driver, hence why it will need to go via net-next. Furthermore, subsequent changes depend on these patches. The underlying ideas here are...
null
null
null
[PATCH RESEND2 net-next 0/8] net: stmmac: qcom-ethqos: further serdes reorganisation
On Thu, Feb 26, 2026 at 11:09:47PM +0000, Russell King (Oracle) wrote: Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>
{ "author": "Vladimir Oltean <olteanv@gmail.com>", "date": "Fri, 27 Feb 2026 17:42:24 +0200", "is_openbsd": false, "thread_id": "20260227153901.qor4rtvtxur2zywh@skbuf.mbox.gz" }