data_type large_stringclasses 3
values | source large_stringclasses 29
values | code large_stringlengths 98 49.4M | filepath large_stringlengths 5 161 ⌀ | message large_stringclasses 234
values | commit large_stringclasses 234
values | subject large_stringclasses 418
values | critique large_stringlengths 101 1.26M ⌀ | metadata dict |
|---|---|---|---|---|---|---|---|---|
lkml_critique | bpf | Changelog:
v4: https://lore.kernel.org/all/20260224212535.1165151-1-puranjay@kernel.org/
Changes in v4 -> v5:
- Base the commits over bpf/master and not bpf-next/master
- Rename KF_FORBID_SLEEP to KF_FORBID_FAULT: mmap_lock is a sleeping
lock (rw_semaphore), so the actual constraint is about faulting (which
would ... | null | null | null | [PATCH bpf v5 0/8] Introduce KF_FORBID_FAULT modifier for acquire/release kfuncs | The sleepable context check for global function calls in
check_func_call() open-codes the same checks that in_sleepable_context()
already performs. Replace the open-coded check with a call to
in_sleepable_context() and use non_sleepable_context_description() for
the error message, consistent with check_helper_call() an... | {
"author": "Puranjay Mohan <puranjay@kernel.org>",
"date": "Thu, 26 Feb 2026 08:14:53 -0800",
"is_openbsd": false,
"thread_id": "20260226161500.775715-4-puranjay@kernel.org.mbox.gz"
} |
lkml_critique | bpf | Changelog:
v4: https://lore.kernel.org/all/20260224212535.1165151-1-puranjay@kernel.org/
Changes in v4 -> v5:
- Base the commits over bpf/master and not bpf-next/master
- Rename KF_FORBID_SLEEP to KF_FORBID_FAULT: mmap_lock is a sleeping
lock (rw_semaphore), so the actual constraint is about faulting (which
would ... | null | null | null | [PATCH bpf v5 0/8] Introduce KF_FORBID_FAULT modifier for acquire/release kfuncs | With KF_ACQUIRE support for iterators in place, we need a way to tell
the verifier that holding a particular acquired reference forbids
faulting. For example, task_vma's _next holds mmap_lock, so any
operation that might trigger a page fault between _next and _release
must be rejected to avoid deadlocking on mmap_lock ... | {
"author": "Puranjay Mohan <puranjay@kernel.org>",
"date": "Thu, 26 Feb 2026 08:14:54 -0800",
"is_openbsd": false,
"thread_id": "20260226161500.775715-4-puranjay@kernel.org.mbox.gz"
} |
lkml_critique | bpf | Changelog:
v4: https://lore.kernel.org/all/20260224212535.1165151-1-puranjay@kernel.org/
Changes in v4 -> v5:
- Base the commits over bpf/master and not bpf-next/master
- Rename KF_FORBID_SLEEP to KF_FORBID_FAULT: mmap_lock is a sleeping
lock (rw_semaphore), so the actual constraint is about faulting (which
would ... | null | null | null | [PATCH bpf v5 0/8] Introduce KF_FORBID_FAULT modifier for acquire/release kfuncs | The current implementation of task_vma iterator takes the mmap_lock in
the _new() function and holds it for the entire duration of the
iterator. The next commits will allow releasing the lock in the middle
of the iteration and it would mean that the _next() call should re-take
the mmap_lock.
Move the mmap_lock setup t... | {
"author": "Puranjay Mohan <puranjay@kernel.org>",
"date": "Thu, 26 Feb 2026 08:14:55 -0800",
"is_openbsd": false,
"thread_id": "20260226161500.775715-4-puranjay@kernel.org.mbox.gz"
} |
lkml_critique | bpf | Changelog:
v4: https://lore.kernel.org/all/20260224212535.1165151-1-puranjay@kernel.org/
Changes in v4 -> v5:
- Base the commits over bpf/master and not bpf-next/master
- Rename KF_FORBID_SLEEP to KF_FORBID_FAULT: mmap_lock is a sleeping
lock (rw_semaphore), so the actual constraint is about faulting (which
would ... | null | null | null | [PATCH bpf v5 0/8] Introduce KF_FORBID_FAULT modifier for acquire/release kfuncs | Wire up the task_vma iterator to use the KF_ACQUIRE/KF_RELEASE and
KF_FORBID_FAULT infrastructure from the previous commits.
Annotate bpf_iter_task_vma_next with KF_ACQUIRE | KF_FORBID_FAULT so
each returned VMA pointer becomes a tracked reference that prevents
faulting. Add bpf_iter_task_vma_release(it__iter) with KF... | {
"author": "Puranjay Mohan <puranjay@kernel.org>",
"date": "Thu, 26 Feb 2026 08:14:56 -0800",
"is_openbsd": false,
"thread_id": "20260226161500.775715-4-puranjay@kernel.org.mbox.gz"
} |
lkml_critique | bpf | Changelog:
v4: https://lore.kernel.org/all/20260224212535.1165151-1-puranjay@kernel.org/
Changes in v4 -> v5:
- Base the commits over bpf/master and not bpf-next/master
- Rename KF_FORBID_SLEEP to KF_FORBID_FAULT: mmap_lock is a sleeping
lock (rw_semaphore), so the actual constraint is about faulting (which
would ... | null | null | null | [PATCH bpf v5 0/8] Introduce KF_FORBID_FAULT modifier for acquire/release kfuncs | Add runtime and verifier tests for the split task_vma iteration model.
The runtime tests are:
- iter_task_vma_release_and_copy: iterates VMAs, saves vm_start,
releases mmap_lock via bpf_iter_task_vma_release(), then calls
bpf_copy_from_user() on the saved address.
- iter_task_vma_nested: two nested task_vma iterat... | {
"author": "Puranjay Mohan <puranjay@kernel.org>",
"date": "Thu, 26 Feb 2026 08:14:57 -0800",
"is_openbsd": false,
"thread_id": "20260226161500.775715-4-puranjay@kernel.org.mbox.gz"
} |
lkml_critique | bpf | Changelog:
v4: https://lore.kernel.org/all/20260224212535.1165151-1-puranjay@kernel.org/
Changes in v4 -> v5:
- Base the commits over bpf/master and not bpf-next/master
- Rename KF_FORBID_SLEEP to KF_FORBID_FAULT: mmap_lock is a sleeping
lock (rw_semaphore), so the actual constraint is about faulting (which
would ... | null | null | null | [PATCH bpf v5 0/8] Introduce KF_FORBID_FAULT modifier for acquire/release kfuncs | On Thu, 2026-02-26 at 08:14 -0800, Puranjay Mohan wrote:
Acked-by: Eduard Zingerman <eddyz87@gmail.com>
[...] | {
"author": "Eduard Zingerman <eddyz87@gmail.com>",
"date": "Thu, 26 Feb 2026 10:36:55 -0800",
"is_openbsd": false,
"thread_id": "20260226161500.775715-4-puranjay@kernel.org.mbox.gz"
} |
lkml_critique | bpf | Changelog:
v4: https://lore.kernel.org/all/20260224212535.1165151-1-puranjay@kernel.org/
Changes in v4 -> v5:
- Base the commits over bpf/master and not bpf-next/master
- Rename KF_FORBID_SLEEP to KF_FORBID_FAULT: mmap_lock is a sleeping
lock (rw_semaphore), so the actual constraint is about faulting (which
would ... | null | null | null | [PATCH bpf v5 0/8] Introduce KF_FORBID_FAULT modifier for acquire/release kfuncs | On Thu, Feb 26, 2026 at 8:15 AM Puranjay Mohan <puranjay@kernel.org> wrote:
This hunk looks generic since it acts on PTR_TO_STACK,
but it's extremely specific for one kfunc that is KF_RELEASE,
and in this patchset it happens to be bpf_iter_task_vma_release(),
but any future kfunc that accepts ptr_to_stack will fall in... | {
"author": "Alexei Starovoitov <alexei.starovoitov@gmail.com>",
"date": "Thu, 26 Feb 2026 16:46:45 -0800",
"is_openbsd": false,
"thread_id": "20260226161500.775715-4-puranjay@kernel.org.mbox.gz"
} |
lkml_critique | bpf | Previously we have attempted to allow BPF users to attach tens of bytes of
arbitrary data to packets by making XDP/skb metadata area persist across
netstack layers [1].
This approach turned out to be unsuccessful. It would require us to
restrict the layout of skb headroom and patch call sites which modify the
headroom... | null | null | null | [PATCH RFC bpf-next 0/5] skb extension for BPF local storage | BPF local storage exists for sk, task, cgroup, and inode objects, but not
for sk_buff. Add per-packet local storage so BPF programs can associate
key-value data with individual packets as they traverse the network stack.
Back the storage with a new skb extension (SKB_EXT_BPF_STORAGE) that holds
a bpf_local_storage poi... | {
"author": "Jakub Sitnicki <jakub@cloudflare.com>",
"date": "Thu, 26 Feb 2026 22:12:52 +0100",
"is_openbsd": false,
"thread_id": "20260226-skb-local-storage-v1-3-4ca44f0dd9d1@cloudflare.com.mbox.gz"
} |
lkml_critique | bpf | Previously we have attempted to allow BPF users to attach tens of bytes of
arbitrary data to packets by making XDP/skb metadata area persist across
netstack layers [1].
This approach turned out to be unsuccessful. It would require us to
restrict the layout of skb headroom and patch call sites which modify the
headroom... | null | null | null | [PATCH RFC bpf-next 0/5] skb extension for BPF local storage | bpf_cast_to_kern_ctx() returns a trusted PTR_TO_BTF_ID pointing to the
kernel-side context struct (e.g., sk_buff for TC programs). Passing this
pointer to a kfunc that expects KF_ARG_PTR_TO_CTX fails verification,
because the check accepts only PTR_TO_CTX.
Relax the check to also accept a trusted PTR_TO_BTF_ID whose b... | {
"author": "Jakub Sitnicki <jakub@cloudflare.com>",
"date": "Thu, 26 Feb 2026 22:12:53 +0100",
"is_openbsd": false,
"thread_id": "20260226-skb-local-storage-v1-3-4ca44f0dd9d1@cloudflare.com.mbox.gz"
} |
lkml_critique | bpf | Previously we have attempted to allow BPF users to attach tens of bytes of
arbitrary data to packets by making XDP/skb metadata area persist across
netstack layers [1].
This approach turned out to be unsuccessful. It would require us to
restrict the layout of skb headroom and patch call sites which modify the
headroom... | null | null | null | [PATCH RFC bpf-next 0/5] skb extension for BPF local storage | sock_ops programs receive bpf_sock_ops_kern as their kernel context, which
holds a pointer to the sk_buff being processed. Mark bpf_sock_ops_kern->skb
as BTF_TYPE_SAFE_TRUSTED_OR_NULL so that BPF programs can dereference it
and pass it to kfuncs expecting a trusted sk_buff pointer, such as
bpf_skb_storage_get().
Signe... | {
"author": "Jakub Sitnicki <jakub@cloudflare.com>",
"date": "Thu, 26 Feb 2026 22:12:54 +0100",
"is_openbsd": false,
"thread_id": "20260226-skb-local-storage-v1-3-4ca44f0dd9d1@cloudflare.com.mbox.gz"
} |
lkml_critique | bpf | Previously we have attempted to allow BPF users to attach tens of bytes of
arbitrary data to packets by making XDP/skb metadata area persist across
netstack layers [1].
This approach turned out to be unsuccessful. It would require us to
restrict the layout of skb headroom and patch call sites which modify the
headroom... | null | null | null | [PATCH RFC bpf-next 0/5] skb extension for BPF local storage | Cover verifier checks for the bpf_skb_storage_get and
bpf_skb_storage_delete kfuncs.
Negative tests verify argument validation:
- not_a_map_on_{get,delete}: a non-map pointer as the first argument is
rejected
- wrong_map_type_on_{get,delete}: passing a BPF_MAP_TYPE_HASH map instead
of BPF_MAP_TYPE_SKB_STORAGE is r... | {
"author": "Jakub Sitnicki <jakub@cloudflare.com>",
"date": "Thu, 26 Feb 2026 22:12:55 +0100",
"is_openbsd": false,
"thread_id": "20260226-skb-local-storage-v1-3-4ca44f0dd9d1@cloudflare.com.mbox.gz"
} |
lkml_critique | bpf | Previously we have attempted to allow BPF users to attach tens of bytes of
arbitrary data to packets by making XDP/skb metadata area persist across
netstack layers [1].
This approach turned out to be unsuccessful. It would require us to
restrict the layout of skb headroom and patch call sites which modify the
headroom... | null | null | null | [PATCH RFC bpf-next 0/5] skb extension for BPF local storage | Exercise skb local storage across program types and hook boundaries.
1. skb_storage_ops: Unit test for the kfunc API - create, read,
delete, and re-create with an initial value. Runs as a socket
filter via BPF_PROG_TEST_RUN.
2. tc_clone_redirect: Store from TC egress on lo, bpf_clone_redirect
to a dummy devi... | {
"author": "Jakub Sitnicki <jakub@cloudflare.com>",
"date": "Thu, 26 Feb 2026 22:12:56 +0100",
"is_openbsd": false,
"thread_id": "20260226-skb-local-storage-v1-3-4ca44f0dd9d1@cloudflare.com.mbox.gz"
} |
lkml_critique | bpf | Previously we have attempted to allow BPF users to attach tens of bytes of
arbitrary data to packets by making XDP/skb metadata area persist across
netstack layers [1].
This approach turned out to be unsuccessful. It would require us to
restrict the layout of skb headroom and patch call sites which modify the
headroom... | null | null | null | [PATCH RFC bpf-next 0/5] skb extension for BPF local storage | On Thu, Feb 26, 2026 at 1:16 PM Jakub Sitnicki <jakub@cloudflare.com> wrote:
And that list of local storages ends with a solid period.
We're not going to add new local storages.
Not for skb and not for anything else.
We rejected it for cred, bdev and other things.
The path forward for such "local storage" like use ca... | {
"author": "Alexei Starovoitov <alexei.starovoitov@gmail.com>",
"date": "Thu, 26 Feb 2026 13:56:12 -0800",
"is_openbsd": false,
"thread_id": "20260226-skb-local-storage-v1-3-4ca44f0dd9d1@cloudflare.com.mbox.gz"
} |
lkml_critique | bpf | struct bpf_plt contains a u64 'target' field. The BPF JIT allocator
was using an alignment of 4 bytes (sizeof(u32)), which could lead
to the 'target' field being misaligned in the JIT buffer.
Increase the alignment requirement to 8 bytes (sizeof(u64)) in
bpf_jit_binary_pack_alloc() to guarantee proper alignment for
st... | null | null | null | [PATCH] arm64: bpf: Fix UBSAN misaligned access in BPF JIT | struct bpf_plt contains a u64 'target' field. The BPF JIT allocator
was using an alignment of 4 bytes (sizeof(u32)), which could lead
to the 'target' field being misaligned in the JIT buffer.
Increase the alignment requirement to 8 bytes (sizeof(u64)) in
bpf_jit_binary_pack_alloc() to guarantee proper alignment for
st... | {
"author": "Fuad Tabba <tabba@google.com>",
"date": "Tue, 24 Feb 2026 09:31:28 +0000",
"is_openbsd": false,
"thread_id": "8b7050b7-f2ad-4237-890c-76fc13dc0189@huaweicloud.com.mbox.gz"
} |
lkml_critique | bpf | struct bpf_plt contains a u64 'target' field. The BPF JIT allocator
was using an alignment of 4 bytes (sizeof(u32)), which could lead
to the 'target' field being misaligned in the JIT buffer.
Increase the alignment requirement to 8 bytes (sizeof(u64)) in
bpf_jit_binary_pack_alloc() to guarantee proper alignment for
st... | null | null | null | [PATCH] arm64: bpf: Fix UBSAN misaligned access in BPF JIT | On Tue, Feb 24, 2026 at 09:29:15AM +0000, Fuad Tabba wrote:
Did you see a functional issue with this or are you just trying to squash
a UBSAN splat? I can't see an issue with the code and it seems a bit
over-the-top to over-align the whole JIT buffer just because of structure
alignment rules that don't really make sen... | {
"author": "Will Deacon <will@kernel.org>",
"date": "Tue, 24 Feb 2026 22:11:18 +0000",
"is_openbsd": false,
"thread_id": "8b7050b7-f2ad-4237-890c-76fc13dc0189@huaweicloud.com.mbox.gz"
} |
lkml_critique | bpf | struct bpf_plt contains a u64 'target' field. The BPF JIT allocator
was using an alignment of 4 bytes (sizeof(u32)), which could lead
to the 'target' field being misaligned in the JIT buffer.
Increase the alignment requirement to 8 bytes (sizeof(u64)) in
bpf_jit_binary_pack_alloc() to guarantee proper alignment for
st... | null | null | null | [PATCH] arm64: bpf: Fix UBSAN misaligned access in BPF JIT | On 2/24/2026 5:31 PM, Fuad Tabba wrote:
Good catch. build_plt pads NOP instructions to ensure a 64-bit relative offset for
plt target, but it misses the alignment check for image base itself.
Acked-by: Xu Kuohai <xukuohai@huaweicloud.com>
nit: Add check for base alignment in build_plt, or a comment to clarify? | {
"author": "Xu Kuohai <xukuohai@huaweicloud.com>",
"date": "Wed, 25 Feb 2026 09:43:12 +0800",
"is_openbsd": false,
"thread_id": "8b7050b7-f2ad-4237-890c-76fc13dc0189@huaweicloud.com.mbox.gz"
} |
lkml_critique | bpf | struct bpf_plt contains a u64 'target' field. The BPF JIT allocator
was using an alignment of 4 bytes (sizeof(u32)), which could lead
to the 'target' field being misaligned in the JIT buffer.
Increase the alignment requirement to 8 bytes (sizeof(u64)) in
bpf_jit_binary_pack_alloc() to guarantee proper alignment for
st... | null | null | null | [PATCH] arm64: bpf: Fix UBSAN misaligned access in BPF JIT | Hi Will,
On Tue, 24 Feb 2026 at 22:11, Will Deacon <will@kernel.org> wrote:
I didn't see a functional issue. I was debugging something else, and
ran into the UBSAN splat.
It does. It drops the compiler's alignment assumption silencing the
UBSAN warning without touching the allocator, and the generated
assembly is i... | {
"author": "Fuad Tabba <tabba@google.com>",
"date": "Wed, 25 Feb 2026 09:07:36 +0000",
"is_openbsd": false,
"thread_id": "8b7050b7-f2ad-4237-890c-76fc13dc0189@huaweicloud.com.mbox.gz"
} |
lkml_critique | bpf | struct bpf_plt contains a u64 'target' field. The BPF JIT allocator
was using an alignment of 4 bytes (sizeof(u32)), which could lead
to the 'target' field being misaligned in the JIT buffer.
Increase the alignment requirement to 8 bytes (sizeof(u64)) in
bpf_jit_binary_pack_alloc() to guarantee proper alignment for
st... | null | null | null | [PATCH] arm64: bpf: Fix UBSAN misaligned access in BPF JIT | Hi Xu,
On Wed, 25 Feb 2026 at 01:43, Xu Kuohai <xukuohai@huaweicloud.com> wrote:
Thanks for the having a look and for the Ack.
You're right that build_plt() assumes 64-bit alignment when
calculating the NOP padding. However, Will pointed out, over-aligning
the entire JIT buffer just to satisfy the C standard is some... | {
"author": "Fuad Tabba <tabba@google.com>",
"date": "Wed, 25 Feb 2026 09:08:10 +0000",
"is_openbsd": false,
"thread_id": "8b7050b7-f2ad-4237-890c-76fc13dc0189@huaweicloud.com.mbox.gz"
} |
lkml_critique | bpf | struct bpf_plt contains a u64 'target' field. The BPF JIT allocator
was using an alignment of 4 bytes (sizeof(u32)), which could lead
to the 'target' field being misaligned in the JIT buffer.
Increase the alignment requirement to 8 bytes (sizeof(u64)) in
bpf_jit_binary_pack_alloc() to guarantee proper alignment for
st... | null | null | null | [PATCH] arm64: bpf: Fix UBSAN misaligned access in BPF JIT | On 2/25/2026 5:08 PM, Fuad Tabba wrote:
Interesting, I think the plt target should be 64-bit aligned to ensure
atomic reading on arm64. It can be updated concurrently by WRITE_ONCE
in the bpf_arch_text_poke function while the ldr instruction in the plt is
executed. If it is not aligned correctly, the ldr may read a ha... | {
"author": "Xu Kuohai <xukuohai@huaweicloud.com>",
"date": "Wed, 25 Feb 2026 17:46:52 +0800",
"is_openbsd": false,
"thread_id": "8b7050b7-f2ad-4237-890c-76fc13dc0189@huaweicloud.com.mbox.gz"
} |
lkml_critique | bpf | struct bpf_plt contains a u64 'target' field. The BPF JIT allocator
was using an alignment of 4 bytes (sizeof(u32)), which could lead
to the 'target' field being misaligned in the JIT buffer.
Increase the alignment requirement to 8 bytes (sizeof(u64)) in
bpf_jit_binary_pack_alloc() to guarantee proper alignment for
st... | null | null | null | [PATCH] arm64: bpf: Fix UBSAN misaligned access in BPF JIT | Hi Xu,
On Wed, 25 Feb 2026 at 09:46, Xu Kuohai <xukuohai@huaweicloud.com> wrote:
You're right. I missed that target is concurrently updated via
bpf_arch_text_poke() and read by ldr. If target crosses an 8-byte
boundary, we lose the single-copy atomicity guarantee, risking a torn
read. So I guess that this isn't just ... | {
"author": "Fuad Tabba <tabba@google.com>",
"date": "Wed, 25 Feb 2026 11:00:31 +0000",
"is_openbsd": false,
"thread_id": "8b7050b7-f2ad-4237-890c-76fc13dc0189@huaweicloud.com.mbox.gz"
} |
lkml_critique | bpf | struct bpf_plt contains a u64 'target' field. The BPF JIT allocator
was using an alignment of 4 bytes (sizeof(u32)), which could lead
to the 'target' field being misaligned in the JIT buffer.
Increase the alignment requirement to 8 bytes (sizeof(u64)) in
bpf_jit_binary_pack_alloc() to guarantee proper alignment for
st... | null | null | null | [PATCH] arm64: bpf: Fix UBSAN misaligned access in BPF JIT | On Wed, Feb 25, 2026 at 05:46:52PM +0800, Xu Kuohai wrote:
Thanks for pointing that out; I hadn't realised that we patched live
PLTs!
Makes sense to me.
Will | {
"author": "Will Deacon <will@kernel.org>",
"date": "Wed, 25 Feb 2026 17:47:58 +0000",
"is_openbsd": false,
"thread_id": "8b7050b7-f2ad-4237-890c-76fc13dc0189@huaweicloud.com.mbox.gz"
} |
lkml_critique | bpf | struct bpf_plt contains a u64 'target' field. The BPF JIT allocator
was using an alignment of 4 bytes (sizeof(u32)), which could lead
to the 'target' field being misaligned in the JIT buffer.
Increase the alignment requirement to 8 bytes (sizeof(u64)) in
bpf_jit_binary_pack_alloc() to guarantee proper alignment for
st... | null | null | null | [PATCH] arm64: bpf: Fix UBSAN misaligned access in BPF JIT | Hi Will,
On Wed, 25 Feb 2026 at 17:48, Will Deacon <will@kernel.org> wrote:
As I noted in my reply to Xu, and keeping in mind that this is very
new to me (so take it with a huge pinch of salt), I don't think this
is correct, but that my original patch is probably the best fix:
Cheers,
/fuad | {
"author": "Fuad Tabba <tabba@google.com>",
"date": "Wed, 25 Feb 2026 17:53:18 +0000",
"is_openbsd": false,
"thread_id": "8b7050b7-f2ad-4237-890c-76fc13dc0189@huaweicloud.com.mbox.gz"
} |
lkml_critique | bpf | struct bpf_plt contains a u64 'target' field. The BPF JIT allocator
was using an alignment of 4 bytes (sizeof(u32)), which could lead
to the 'target' field being misaligned in the JIT buffer.
Increase the alignment requirement to 8 bytes (sizeof(u64)) in
bpf_jit_binary_pack_alloc() to guarantee proper alignment for
st... | null | null | null | [PATCH] arm64: bpf: Fix UBSAN misaligned access in BPF JIT | On Wed, Feb 25, 2026 at 05:53:18PM +0000, Fuad Tabba wrote:
[...]
Aha, so this handles the case where we have an odd number of instructions
and need to chuck out a NOP to align the PLT target. So, yes, I agree
that aligning the entire region to 8 bytes seems to be the expected
behaviour, otherwise that NOP could act... | {
"author": "Will Deacon <will@kernel.org>",
"date": "Wed, 25 Feb 2026 18:22:46 +0000",
"is_openbsd": false,
"thread_id": "8b7050b7-f2ad-4237-890c-76fc13dc0189@huaweicloud.com.mbox.gz"
} |
lkml_critique | bpf | struct bpf_plt contains a u64 'target' field. The BPF JIT allocator
was using an alignment of 4 bytes (sizeof(u32)), which could lead
to the 'target' field being misaligned in the JIT buffer.
Increase the alignment requirement to 8 bytes (sizeof(u64)) in
bpf_jit_binary_pack_alloc() to guarantee proper alignment for
st... | null | null | null | [PATCH] arm64: bpf: Fix UBSAN misaligned access in BPF JIT | On 2/25/2026 7:00 PM, Fuad Tabba wrote:
Right, I missed it causing ctx->idx to diverge. Thanks for the
explanation!
Makes sense to me. | {
"author": "Xu Kuohai <xukuohai@huaweicloud.com>",
"date": "Thu, 26 Feb 2026 09:34:04 +0800",
"is_openbsd": false,
"thread_id": "8b7050b7-f2ad-4237-890c-76fc13dc0189@huaweicloud.com.mbox.gz"
} |
lkml_critique | bpf | struct bpf_plt contains a u64 'target' field. The BPF JIT allocator
was using an alignment of 4 bytes (sizeof(u32)), which could lead
to the 'target' field being misaligned in the JIT buffer.
Increase the alignment requirement to 8 bytes (sizeof(u64)) in
bpf_jit_binary_pack_alloc() to guarantee proper alignment for
st... | null | null | null | [PATCH] arm64: bpf: Fix UBSAN misaligned access in BPF JIT | struct bpf_plt contains a u64 target field. Currently, the BPF JIT
allocator requests an alignment of 4 bytes (sizeof(u32)) for the JIT
buffer.
Because the base address of the JIT buffer can be 4-byte aligned (e.g.,
ending in 0x4 or 0xc), the relative padding logic in build_plt() fails
to ensure that target lands on a... | {
"author": "Fuad Tabba <tabba@google.com>",
"date": "Thu, 26 Feb 2026 07:55:25 +0000",
"is_openbsd": false,
"thread_id": "8b7050b7-f2ad-4237-890c-76fc13dc0189@huaweicloud.com.mbox.gz"
} |
lkml_critique | bpf | struct bpf_plt contains a u64 'target' field. The BPF JIT allocator
was using an alignment of 4 bytes (sizeof(u32)), which could lead
to the 'target' field being misaligned in the JIT buffer.
Increase the alignment requirement to 8 bytes (sizeof(u64)) in
bpf_jit_binary_pack_alloc() to guarantee proper alignment for
st... | null | null | null | [PATCH] arm64: bpf: Fix UBSAN misaligned access in BPF JIT | On Thu, Feb 26, 2026 at 07:55:25AM +0000, Fuad Tabba wrote:
Acked-by: Will Deacon <will@kernel.org>
Will | {
"author": "Will Deacon <will@kernel.org>",
"date": "Thu, 26 Feb 2026 18:28:32 +0000",
"is_openbsd": false,
"thread_id": "8b7050b7-f2ad-4237-890c-76fc13dc0189@huaweicloud.com.mbox.gz"
} |
lkml_critique | bpf | struct bpf_plt contains a u64 'target' field. The BPF JIT allocator
was using an alignment of 4 bytes (sizeof(u32)), which could lead
to the 'target' field being misaligned in the JIT buffer.
Increase the alignment requirement to 8 bytes (sizeof(u64)) in
bpf_jit_binary_pack_alloc() to guarantee proper alignment for
st... | null | null | null | [PATCH] arm64: bpf: Fix UBSAN misaligned access in BPF JIT | Hello:
This patch was applied to bpf/bpf.git (master)
by Alexei Starovoitov <ast@kernel.org>:
On Thu, 26 Feb 2026 07:55:25 +0000 you wrote:
Here is the summary with links:
- [v3] arm64: bpf: Force 8-byte alignment for JIT buffer to prevent atomic tearing
https://git.kernel.org/bpf/bpf/c/ef06fd16d487
You are a... | {
"author": "patchwork-bot+netdevbpf@kernel.org",
"date": "Thu, 26 Feb 2026 19:30:19 +0000",
"is_openbsd": false,
"thread_id": "8b7050b7-f2ad-4237-890c-76fc13dc0189@huaweicloud.com.mbox.gz"
} |
lkml_critique | bpf | There exists a race across various map types where the freeing of
special fields (tw, timer, wq, kptr, etc.) can be done eagerly when a
logical delete operation is done on a map value, such that the program
which continues to have access to such a map value can recreate the
fields and cause them to leak.
The set conta... | null | null | null | [PATCH bpf v2 0/5] Close race in freeing special fields and map value | There is a race window where BPF hash map elements can leak special
fields if the program with access to the map value recreates these
special fields between the check_and_free_fields done on the map value
and its eventual return to the memory allocator.
Several ways were explored prior to this patch, most notably [0]... | {
"author": "Kumar Kartikeya Dwivedi <memxor@gmail.com>",
"date": "Thu, 26 Feb 2026 21:20:27 -0800",
"is_openbsd": false,
"thread_id": "CAMB2axPbDpzmDgOteFkCMw55ss=0gTi+_mw4Em_f63G5CxTHVw@mail.gmail.com.mbox.gz"
} |
lkml_critique | bpf | There exists a race across various map types where the freeing of
special fields (tw, timer, wq, kptr, etc.) can be done eagerly when a
logical delete operation is done on a map value, such that the program
which continues to have access to such a map value can recreate the
fields and cause them to leak.
The set conta... | null | null | null | [PATCH bpf v2 0/5] Close race in freeing special fields and map value | BPF hash map may now use the map_check_btf() callback to decide whether
to set a dtor on its bpf_mem_alloc or not. Unlike C++ where members can
opt out of const-ness using mutable, we must lose the const qualifier on
the callback such that we can avoid the ugly cast. Make the change and
adjust all existing users, and l... | {
"author": "Kumar Kartikeya Dwivedi <memxor@gmail.com>",
"date": "Thu, 26 Feb 2026 21:20:28 -0800",
"is_openbsd": false,
"thread_id": "CAMB2axPbDpzmDgOteFkCMw55ss=0gTi+_mw4Em_f63G5CxTHVw@mail.gmail.com.mbox.gz"
} |
lkml_critique | bpf | There exists a race across various map types where the freeing of
special fields (tw, timer, wq, kptr, etc.) can be done eagerly when a
logical delete operation is done on a map value, such that the program
which continues to have access to such a map value can recreate the
fields and cause them to leak.
The set conta... | null | null | null | [PATCH bpf v2 0/5] Close race in freeing special fields and map value | Currently, when use_kmalloc_nolock is false, the freeing of fields for a
local storage selem is done eagerly before waiting for the RCU or RCU
tasks trace grace period to elapse. This opens up a window where the
program which has access to the selem can recreate the fields after the
freeing of fields is done eagerly, c... | {
"author": "Kumar Kartikeya Dwivedi <memxor@gmail.com>",
"date": "Thu, 26 Feb 2026 21:20:29 -0800",
"is_openbsd": false,
"thread_id": "CAMB2axPbDpzmDgOteFkCMw55ss=0gTi+_mw4Em_f63G5CxTHVw@mail.gmail.com.mbox.gz"
} |
lkml_critique | bpf | There exists a race across various map types where the freeing of
special fields (tw, timer, wq, kptr, etc.) can be done eagerly when a
logical delete operation is done on a map value, such that the program
which continues to have access to such a map value can recreate the
fields and cause them to leak.
The set conta... | null | null | null | [PATCH bpf v2 0/5] Close race in freeing special fields and map value | This assumption will always hold going forward, hence just remove the
various checks and assume it is true with a comment for the uninformed
reader.
Reviewed-by: Paul E. McKenney <paulmck@kernel.org>
Signed-off-by: Kumar Kartikeya Dwivedi <memxor@gmail.com>
---
kernel/bpf/bpf_local_storage.c | 37 +++++++++++++++++---... | {
"author": "Kumar Kartikeya Dwivedi <memxor@gmail.com>",
"date": "Thu, 26 Feb 2026 21:20:30 -0800",
"is_openbsd": false,
"thread_id": "CAMB2axPbDpzmDgOteFkCMw55ss=0gTi+_mw4Em_f63G5CxTHVw@mail.gmail.com.mbox.gz"
} |
lkml_critique | bpf | There exists a race across various map types where the freeing of
special fields (tw, timer, wq, kptr, etc.) can be done eagerly when a
logical delete operation is done on a map value, such that the program
which continues to have access to such a map value can recreate the
fields and cause them to leak.
The set conta... | null | null | null | [PATCH bpf v2 0/5] Close race in freeing special fields and map value | Add a couple of tests to ensure that the refcount drops to zero when we
exercise the race where creation of a special field succeeds the logical
bpf_obj_free_fields done when deleting an element. Prior to previous
changes, the fields would be freed eagerly and repopulate and end up
leaking, causing the reference to not... | {
"author": "Kumar Kartikeya Dwivedi <memxor@gmail.com>",
"date": "Thu, 26 Feb 2026 21:20:31 -0800",
"is_openbsd": false,
"thread_id": "CAMB2axPbDpzmDgOteFkCMw55ss=0gTi+_mw4Em_f63G5CxTHVw@mail.gmail.com.mbox.gz"
} |
lkml_critique | bpf | There exists a race across various map types where the freeing of
special fields (tw, timer, wq, kptr, etc.) can be done eagerly when a
logical delete operation is done on a map value, such that the program
which continues to have access to such a map value can recreate the
fields and cause them to leak.
The set conta... | null | null | null | [PATCH bpf v2 0/5] Close race in freeing special fields and map value | [ ... ]
The smap field is declared as __rcu in struct bpf_local_storage_data:
struct bpf_local_storage_map __rcu *smap;
Here it is read directly twice without rcu_dereference_check,
once for the NULL check and once for the ->map.record access.
The sibling function bpf_selem_free_rcu() in the same file
handles ... | {
"author": "bot+bpf-ci@kernel.org",
"date": "Fri, 27 Feb 2026 06:00:47 +0000 (UTC)",
"is_openbsd": false,
"thread_id": "CAMB2axPbDpzmDgOteFkCMw55ss=0gTi+_mw4Em_f63G5CxTHVw@mail.gmail.com.mbox.gz"
} |
lkml_critique | bpf | There exists a race across various map types where the freeing of
special fields (tw, timer, wq, kptr, etc.) can be done eagerly when a
logical delete operation is done on a map value, such that the program
which continues to have access to such a map value can recreate the
fields and cause them to leak.
The set conta... | null | null | null | [PATCH bpf v2 0/5] Close race in freeing special fields and map value | On Thu, Feb 26, 2026 at 10:00 PM <bot+bpf-ci@kernel.org> wrote:
AI is right, but the rest looks good to me.
Reviewed-by: Amery Hung <ameryhung@gmail.com> | {
"author": "Amery Hung <ameryhung@gmail.com>",
"date": "Thu, 26 Feb 2026 23:25:18 -0800",
"is_openbsd": false,
"thread_id": "CAMB2axPbDpzmDgOteFkCMw55ss=0gTi+_mw4Em_f63G5CxTHVw@mail.gmail.com.mbox.gz"
} |
lkml_critique | bpf | There exists a race across various map types where the freeing of
special fields (tw, timer, wq, kptr, etc.) can be done eagerly when a
logical delete operation is done on a map value, such that the program
which continues to have access to such a map value can recreate the
fields and cause them to leak.
The set conta... | null | null | null | [PATCH bpf v2 0/5] Close race in freeing special fields and map value | On Thu, Feb 26, 2026 at 9:20 PM Kumar Kartikeya Dwivedi
<memxor@gmail.com> wrote:
Reviewed-by: Amery Hung <ameryhung@gmail.com> | {
"author": "Amery Hung <ameryhung@gmail.com>",
"date": "Thu, 26 Feb 2026 23:26:25 -0800",
"is_openbsd": false,
"thread_id": "CAMB2axPbDpzmDgOteFkCMw55ss=0gTi+_mw4Em_f63G5CxTHVw@mail.gmail.com.mbox.gz"
} |
lkml_critique | bpf | There exists a race across various map types where the freeing of
special fields (tw, timer, wq, kptr, etc.) can be done eagerly when a
logical delete operation is done on a map value, such that the program
which continues to have access to such a map value can recreate the
fields and cause them to leak.
The set conta... | null | null | null | [PATCH bpf v2 0/5] Close race in freeing special fields and map value | On Thu, Feb 26, 2026 at 9:21 PM Kumar Kartikeya Dwivedi
<memxor@gmail.com> wrote:
Reviewed-by: Amery Hung <ameryhung@gmail.com> | {
"author": "Amery Hung <ameryhung@gmail.com>",
"date": "Thu, 26 Feb 2026 23:32:27 -0800",
"is_openbsd": false,
"thread_id": "CAMB2axPbDpzmDgOteFkCMw55ss=0gTi+_mw4Em_f63G5CxTHVw@mail.gmail.com.mbox.gz"
} |
lkml_critique | bpf | This series refactors qdisc drop reason handling by introducing a dedicated
enum qdisc_drop_reason and trace_qdisc_drop tracepoint, providing qdisc
layer drop diagnostics with direct qdisc context visibility.
Background:
-----------
Identifying which qdisc dropped a packet via skb_drop_reason is difficult.
Normally, t... | null | null | null | [PATCH net-next v5 0/5] net: sched: refactor qdisc drop reasons into
dedicated tracepoint | Create new enum qdisc_drop_reason and trace_qdisc_drop tracepoint
for qdisc layer drop diagnostics with direct qdisc context visibility.
The new tracepoint includes qdisc handle, parent, kind (name), and
device information. Existing SKB_DROP_REASON_QDISC_DROP is retained
for backwards compatibility via kfree_skb_reaso... | {
"author": "Jesper Dangaard Brouer <hawk@kernel.org>",
"date": "Thu, 26 Feb 2026 14:44:12 +0100",
"is_openbsd": false,
"thread_id": "177211345946.3011628.12770616071857185664.stgit@firesoul.mbox.gz"
} |
lkml_critique | bpf | This series refactors qdisc drop reason handling by introducing a dedicated
enum qdisc_drop_reason and trace_qdisc_drop tracepoint, providing qdisc
layer drop diagnostics with direct qdisc context visibility.
Background:
-----------
Identifying which qdisc dropped a packet via skb_drop_reason is difficult.
Normally, t... | null | null | null | [PATCH net-next v5 0/5] net: sched: refactor qdisc drop reasons into
dedicated tracepoint | Convert SFQ to use the new qdisc-specific drop reason infrastructure.
This patch demonstrates how to convert a flow-based qdisc to use the
new enum qdisc_drop_reason. As part of this conversion:
- Add QDISC_DROP_MAXFLOWS for flow table exhaustion
- Rename FQ_FLOW_LIMIT to generic FLOW_LIMIT, now shared by FQ and SFQ
... | {
"author": "Jesper Dangaard Brouer <hawk@kernel.org>",
"date": "Thu, 26 Feb 2026 14:44:19 +0100",
"is_openbsd": false,
"thread_id": "177211345946.3011628.12770616071857185664.stgit@firesoul.mbox.gz"
} |
lkml_critique | bpf | This series refactors qdisc drop reason handling by introducing a dedicated
enum qdisc_drop_reason and trace_qdisc_drop tracepoint, providing qdisc
layer drop diagnostics with direct qdisc context visibility.
Background:
-----------
Identifying which qdisc dropped a packet via skb_drop_reason is difficult.
Normally, t... | null | null | null | [PATCH net-next v5 0/5] net: sched: refactor qdisc drop reasons into
dedicated tracepoint | Rename FQ-specific drop reasons to generic names:
- QDISC_DROP_FQ_BAND_LIMIT -> QDISC_DROP_BAND_LIMIT
- QDISC_DROP_FQ_HORIZON_LIMIT -> QDISC_DROP_HORIZON_LIMIT
This follows the principle that drop reasons should describe the drop
mechanism rather than being tied to a specific qdisc implementation.
These concepts (prio... | {
"author": "Jesper Dangaard Brouer <hawk@kernel.org>",
"date": "Thu, 26 Feb 2026 14:44:29 +0100",
"is_openbsd": false,
"thread_id": "177211345946.3011628.12770616071857185664.stgit@firesoul.mbox.gz"
} |
lkml_critique | bpf | This series refactors qdisc drop reason handling by introducing a dedicated
enum qdisc_drop_reason and trace_qdisc_drop tracepoint, providing qdisc
layer drop diagnostics with direct qdisc context visibility.
Background:
-----------
Identifying which qdisc dropped a packet via skb_drop_reason is difficult.
Normally, t... | null | null | null | [PATCH net-next v5 0/5] net: sched: refactor qdisc drop reasons into
dedicated tracepoint | Rename QDISC_DROP_CAKE_FLOOD to QDISC_DROP_FLOOD_PROTECTION to use a
generic name without embedding the qdisc name. This follows the
principle that drop reasons should describe the drop mechanism rather
than being tied to a specific qdisc implementation.
The flood protection drop reason is used by qdiscs implementing
... | {
"author": "Jesper Dangaard Brouer <hawk@kernel.org>",
"date": "Thu, 26 Feb 2026 14:44:35 +0100",
"is_openbsd": false,
"thread_id": "177211345946.3011628.12770616071857185664.stgit@firesoul.mbox.gz"
} |
lkml_critique | bpf | This series refactors qdisc drop reason handling by introducing a dedicated
enum qdisc_drop_reason and trace_qdisc_drop tracepoint, providing qdisc
layer drop diagnostics with direct qdisc context visibility.
Background:
-----------
Identifying which qdisc dropped a packet via skb_drop_reason is difficult.
Normally, t... | null | null | null | [PATCH net-next v5 0/5] net: sched: refactor qdisc drop reasons into
dedicated tracepoint | DualPI2 drops packets during dequeue but was using kfree_skb_reason()
directly, bypassing trace_qdisc_drop. Convert to qdisc_dequeue_drop()
and add QDISC_DROP_L4S_STEP_NON_ECN to the qdisc drop reason enum.
- Set TCQ_F_DEQUEUE_DROPS flag in dualpi2_init()
- Use enum qdisc_drop_reason in drop_and_retry()
- Replace kfre... | {
"author": "Jesper Dangaard Brouer <hawk@kernel.org>",
"date": "Thu, 26 Feb 2026 14:45:19 +0100",
"is_openbsd": false,
"thread_id": "177211345946.3011628.12770616071857185664.stgit@firesoul.mbox.gz"
} |
lkml_critique | bpf |
[Resending because I don't think the message reached bpf@vger]
Hello.
I would like to propose an activity for the BPF track at LSFMMBPF.
As in previous editions, the purpose of the activity is to do a quick
recap of the current BPF support in both GCC and clang/LLVM and where we
stand, to discuss and clarify any pa... | null | null | null | [LSF/MM/BPF TOPIC] Compiled BPF | Hello.
I would like to propose an activity for the BPF track at LSFMMBPF.
As in previous editions, the purpose of the activity is to do a quick
recap of the current BPF support in both GCC and clang/LLVM and where we
stand, to discuss and clarify any particular issue that may be relevant
to either compiler, and to co... | {
"author": "\"Jose E. Marchesi\" <jose.marchesi@oracle.com>",
"date": "Thu, 09 Jan 2025 10:20:06 +0100",
"is_openbsd": false,
"thread_id": "87tsv3sn2h.fsf@gnu.org.mbox.gz"
} |
lkml_critique | bpf |
[Resending because I don't think the message reached bpf@vger]
Hello.
I would like to propose an activity for the BPF track at LSFMMBPF.
As in previous editions, the purpose of the activity is to do a quick
recap of the current BPF support in both GCC and clang/LLVM and where we
stand, to discuss and clarify any pa... | null | null | null | [LSF/MM/BPF TOPIC] Compiled BPF | Hello people!
[Turns out I forgot to send the topic proposal to the mailing list once
the topic was proposed (in time) via the google form. But better late
than never..]
Work on GCC BPF (also binutils, etc) is progressing at a good pace and
there are a lot of updates and topics that would benefit from having
some ... | {
"author": "\"Jose E. Marchesi\" <jemarch@gnu.org>",
"date": "Thu, 26 Feb 2026 14:16:15 +0100",
"is_openbsd": false,
"thread_id": "87tsv3sn2h.fsf@gnu.org.mbox.gz"
} |
lkml_critique | bpf | Hi,
This series adds support for high order pages when io_uring/devmem
zero copy is used.
See detailed description by Dragos below.
Regards,
Tariq
The first patches are moving code around to allow using queue specific
parameters that are not just for XSK. They are a bit large as they touch
a lot of functions.
The... | null | null | null | [PATCH net-next 00/15] net/mlx5e: SHAMPO, Allow high order pages in zerocopy mode | From: Dragos Tatulea <dtatulea@nvidia.com>
This structure is used under different names: rq_param, rq_params,
param, rqp. Refactor the code to use a single name: rq_param.
This patch has no functional change.
Signed-off-by: Dragos Tatulea <dtatulea@nvidia.com>
Signed-off-by: Tariq Toukan <tariqt@nvidia.com>
---
dri... | {
"author": "Tariq Toukan <tariqt@nvidia.com>",
"date": "Mon, 23 Feb 2026 22:41:41 +0200",
"is_openbsd": false,
"thread_id": "177210064179.1142974.16555075271250106665.git-patchwork-notify@kernel.org.mbox.gz"
} |
lkml_critique | bpf | Hi,
This series adds support for high order pages when io_uring/devmem
zero copy is used.
See detailed description by Dragos below.
Regards,
Tariq
The first patches are moving code around to allow using queue specific
parameters that are not just for XSK. They are a bit large as they touch
a lot of functions.
The... | null | null | null | [PATCH net-next 00/15] net/mlx5e: SHAMPO, Allow high order pages in zerocopy mode | From: Dragos Tatulea <dtatulea@nvidia.com>
Calculating parameters for striding rq is large enough
to deserve its own function. As the names are also very long
it is very easy to hit on the 80 char limitation every time
a change is made. This is an additional sign that it should
be extracted into its own function.
Thi... | {
"author": "Tariq Toukan <tariqt@nvidia.com>",
"date": "Mon, 23 Feb 2026 22:41:42 +0200",
"is_openbsd": false,
"thread_id": "177210064179.1142974.16555075271250106665.git-patchwork-notify@kernel.org.mbox.gz"
} |
lkml_critique | bpf | Hi,
This series adds support for high order pages when io_uring/devmem
zero copy is used.
See detailed description by Dragos below.
Regards,
Tariq
The first patches are moving code around to allow using queue specific
parameters that are not just for XSK. They are a bit large as they touch
a lot of functions.
The... | null | null | null | [PATCH net-next 00/15] net/mlx5e: SHAMPO, Allow high order pages in zerocopy mode | From: Dragos Tatulea <dtatulea@nvidia.com>
Calculating max_xsk_wqebbs seems large enough to deserve its own
function. It will make upcoming changes easier.
This patch has no functional changes.
Signed-off-by: Dragos Tatulea <dtatulea@nvidia.com>
Reviewed-by: Cosmin Ratiu <cratiu@nvidia.com>
Signed-off-by: Tariq Touk... | {
"author": "Tariq Toukan <tariqt@nvidia.com>",
"date": "Mon, 23 Feb 2026 22:41:43 +0200",
"is_openbsd": false,
"thread_id": "177210064179.1142974.16555075271250106665.git-patchwork-notify@kernel.org.mbox.gz"
} |
lkml_critique | bpf | Hi,
This series adds support for high order pages when io_uring/devmem
zero copy is used.
See detailed description by Dragos below.
Regards,
Tariq
The first patches are moving code around to allow using queue specific
parameters that are not just for XSK. They are a bit large as they touch
a lot of functions.
The... | null | null | null | [PATCH net-next 00/15] net/mlx5e: SHAMPO, Allow high order pages in zerocopy mode | From: Dragos Tatulea <dtatulea@nvidia.com>
mlx5e_build_xsk_cparam() is meant to be the alternative
to mlx5e_build_channel_param(). It calculates only the parameters
that it requires using the previously configured mlx5e_xsk_param.
Move this function to params.c to be alongside
mlx5e_build_channel_param() and give it ... | {
"author": "Tariq Toukan <tariqt@nvidia.com>",
"date": "Mon, 23 Feb 2026 22:41:44 +0200",
"is_openbsd": false,
"thread_id": "177210064179.1142974.16555075271250106665.git-patchwork-notify@kernel.org.mbox.gz"
} |
lkml_critique | bpf | Hi,
This series adds support for high order pages when io_uring/devmem
zero copy is used.
See detailed description by Dragos below.
Regards,
Tariq
The first patches are moving code around to allow using queue specific
parameters that are not just for XSK. They are a bit large as they touch
a lot of functions.
The... | null | null | null | [PATCH net-next 00/15] net/mlx5e: SHAMPO, Allow high order pages in zerocopy mode | From: Dragos Tatulea <dtatulea@nvidia.com>
Currently the allocation and filling of the xsk channel
parameters was done in mlx5e_open_xsk().
Move this responsibility out of mlx5e_open_xsk() and have
the function take an already filled mlx5e_channel_param.
mlx5e_open_channel() already allocates channel parameters.
The... | {
"author": "Tariq Toukan <tariqt@nvidia.com>",
"date": "Mon, 23 Feb 2026 22:41:45 +0200",
"is_openbsd": false,
"thread_id": "177210064179.1142974.16555075271250106665.git-patchwork-notify@kernel.org.mbox.gz"
} |
lkml_critique | bpf | Hi,
This series adds support for high order pages when io_uring/devmem
zero copy is used.
See detailed description by Dragos below.
Regards,
Tariq
The first patches are moving code around to allow using queue specific
parameters that are not just for XSK. They are a bit large as they touch
a lot of functions.
The... | null | null | null | [PATCH net-next 00/15] net/mlx5e: SHAMPO, Allow high order pages in zerocopy mode | From: Dragos Tatulea <dtatulea@nvidia.com>
The channel parameters from struct mlx5_qmgmt_data are
built in mlx5e_queue_mem_alloc() but are not used.
mlx5e_open_channel() builds the channel parameters internally and those
parameters will be the ones that are used when opening the queue.
This patch drops the unused pa... | {
"author": "Tariq Toukan <tariqt@nvidia.com>",
"date": "Mon, 23 Feb 2026 22:41:47 +0200",
"is_openbsd": false,
"thread_id": "177210064179.1142974.16555075271250106665.git-patchwork-notify@kernel.org.mbox.gz"
} |
lkml_critique | bpf | Hi,
This series adds support for high order pages when io_uring/devmem
zero copy is used.
See detailed description by Dragos below.
Regards,
Tariq
The first patches are moving code around to allow using queue specific
parameters that are not just for XSK. They are a bit large as they touch
a lot of functions.
The... | null | null | null | [PATCH net-next 00/15] net/mlx5e: SHAMPO, Allow high order pages in zerocopy mode | From: Dragos Tatulea <dtatulea@nvidia.com>
Adapt the rx path in SHAMPO mode to calculate page size based on
configured page_shift when dealing with payload data.
This is necessary as an upcoming patch will add support for using
different page sizes.
This change has no functional changes.
Signed-off-by: Dragos Tatul... | {
"author": "Tariq Toukan <tariqt@nvidia.com>",
"date": "Mon, 23 Feb 2026 22:41:48 +0200",
"is_openbsd": false,
"thread_id": "177210064179.1142974.16555075271250106665.git-patchwork-notify@kernel.org.mbox.gz"
} |
lkml_critique | bpf | Hi,
This series adds support for high order pages when io_uring/devmem
zero copy is used.
See detailed description by Dragos below.
Regards,
Tariq
The first patches are moving code around to allow using queue specific
parameters that are not just for XSK. They are a bit large as they touch
a lot of functions.
The... | null | null | null | [PATCH net-next 00/15] net/mlx5e: SHAMPO, Allow high order pages in zerocopy mode | From: Dragos Tatulea <dtatulea@nvidia.com>
The xsk parameter configuration (struct mlx5e_xsk_param) is passed
around many places during parameter calculation. It is used to contain
channel specific information (as opposed to the global info from
struct mlx5e_params).
Upcoming changes will need to push similar channel... | {
"author": "Tariq Toukan <tariqt@nvidia.com>",
"date": "Mon, 23 Feb 2026 22:41:46 +0200",
"is_openbsd": false,
"thread_id": "177210064179.1142974.16555075271250106665.git-patchwork-notify@kernel.org.mbox.gz"
} |
lkml_critique | bpf | Hi,
This series adds support for high order pages when io_uring/devmem
zero copy is used.
See detailed description by Dragos below.
Regards,
Tariq
The first patches are moving code around to allow using queue specific
parameters that are not just for XSK. They are a bit large as they touch
a lot of functions.
The... | null | null | null | [PATCH net-next 00/15] net/mlx5e: SHAMPO, Allow high order pages in zerocopy mode | From: Dragos Tatulea <dtatulea@nvidia.com>
Instead of unconditionally setting the page_pool to 0, calculate it from
page_shift for MPWQE case.
Signed-off-by: Dragos Tatulea <dtatulea@nvidia.com>
Reviewed-by: Cosmin Ratiu <cratiu@nvidia.com>
Signed-off-by: Tariq Toukan <tariqt@nvidia.com>
---
drivers/net/ethernet/mel... | {
"author": "Tariq Toukan <tariqt@nvidia.com>",
"date": "Mon, 23 Feb 2026 22:41:49 +0200",
"is_openbsd": false,
"thread_id": "177210064179.1142974.16555075271250106665.git-patchwork-notify@kernel.org.mbox.gz"
} |
lkml_critique | bpf | Hi,
This series adds support for high order pages when io_uring/devmem
zero copy is used.
See detailed description by Dragos below.
Regards,
Tariq
The first patches are moving code around to allow using queue specific
parameters that are not just for XSK. They are a bit large as they touch
a lot of functions.
The... | null | null | null | [PATCH net-next 00/15] net/mlx5e: SHAMPO, Allow high order pages in zerocopy mode | From: Dragos Tatulea <dtatulea@nvidia.com>
An upcoming patch will allow setting the page order for RX
pages to be greater than 0. Make sure that the drop page will
also be allocated with the right size when that happens.
Take extra care when calculating the drop page size to
account for page_shift < PAGE_SHIFT which ... | {
"author": "Tariq Toukan <tariqt@nvidia.com>",
"date": "Mon, 23 Feb 2026 22:41:50 +0200",
"is_openbsd": false,
"thread_id": "177210064179.1142974.16555075271250106665.git-patchwork-notify@kernel.org.mbox.gz"
} |
lkml_critique | bpf | Hi,
This series adds support for high order pages when io_uring/devmem
zero copy is used.
See detailed description by Dragos below.
Regards,
Tariq
The first patches are moving code around to allow using queue specific
parameters that are not just for XSK. They are a bit large as they touch
a lot of functions.
The... | null | null | null | [PATCH net-next 00/15] net/mlx5e: SHAMPO, Allow high order pages in zerocopy mode | From: Dragos Tatulea <dtatulea@nvidia.com>
The formula uses the system page size but does not account
for high order pages.
One way to fix this would be to adapt the formula to take
into account the pool order. This would require calculating it
for every allocation or adding an additional rq struct member to
hold the... | {
"author": "Tariq Toukan <tariqt@nvidia.com>",
"date": "Mon, 23 Feb 2026 22:41:51 +0200",
"is_openbsd": false,
"thread_id": "177210064179.1142974.16555075271250106665.git-patchwork-notify@kernel.org.mbox.gz"
} |
lkml_critique | bpf | Hi,
This series adds support for high order pages when io_uring/devmem
zero copy is used.
See detailed description by Dragos below.
Regards,
Tariq
The first patches are moving code around to allow using queue specific
parameters that are not just for XSK. They are a bit large as they touch
a lot of functions.
The... | null | null | null | [PATCH net-next 00/15] net/mlx5e: SHAMPO, Allow high order pages in zerocopy mode | From: Dragos Tatulea <dtatulea@nvidia.com>
If set, take rx_page_size into consideration when calculating
the page shift in Multi Packet WQE mode.
The queue config is saved in the mlx5e_rq_opt_param struct which is
added to the mlx5e_channel_param struct. Now the configuration can be
read from the struct instead of ad... | {
"author": "Tariq Toukan <tariqt@nvidia.com>",
"date": "Mon, 23 Feb 2026 22:41:53 +0200",
"is_openbsd": false,
"thread_id": "177210064179.1142974.16555075271250106665.git-patchwork-notify@kernel.org.mbox.gz"
} |
lkml_critique | bpf | Hi,
This series adds support for high order pages when io_uring/devmem
zero copy is used.
See detailed description by Dragos below.
Regards,
Tariq
The first patches are moving code around to allow using queue specific
parameters that are not just for XSK. They are a bit large as they touch
a lot of functions.
The... | null | null | null | [PATCH net-next 00/15] net/mlx5e: SHAMPO, Allow high order pages in zerocopy mode | From: Dragos Tatulea <dtatulea@nvidia.com>
This function will be necessary to determine the upper limit of
rx-page-size.
Signed-off-by: Dragos Tatulea <dtatulea@nvidia.com>
Signed-off-by: Tariq Toukan <tariqt@nvidia.com>
---
drivers/net/ethernet/mellanox/mlx5/core/en/params.c | 12 ++++++++++++
drivers/net/ethernet/... | {
"author": "Tariq Toukan <tariqt@nvidia.com>",
"date": "Mon, 23 Feb 2026 22:41:54 +0200",
"is_openbsd": false,
"thread_id": "177210064179.1142974.16555075271250106665.git-patchwork-notify@kernel.org.mbox.gz"
} |
lkml_critique | bpf | Hi,
This series adds support for high order pages when io_uring/devmem
zero copy is used.
See detailed description by Dragos below.
Regards,
Tariq
The first patches are moving code around to allow using queue specific
parameters that are not just for XSK. They are a bit large as they touch
a lot of functions.
The... | null | null | null | [PATCH net-next 00/15] net/mlx5e: SHAMPO, Allow high order pages in zerocopy mode | From: Dragos Tatulea <dtatulea@nvidia.com>
Allow high order pages only when SHAMPO mode is enabled (hw-gro) and the
queue is used for zerocopy (has memory provider ops set). The limit is
128K and it was chosen for the following reasons:
- 256K size requires a special case during MTT calculation to split the
page in ... | {
"author": "Tariq Toukan <tariqt@nvidia.com>",
"date": "Mon, 23 Feb 2026 22:41:55 +0200",
"is_openbsd": false,
"thread_id": "177210064179.1142974.16555075271250106665.git-patchwork-notify@kernel.org.mbox.gz"
} |
lkml_critique | bpf | Hi,
This series adds support for high order pages when io_uring/devmem
zero copy is used.
See detailed description by Dragos below.
Regards,
Tariq
The first patches are moving code around to allow using queue specific
parameters that are not just for XSK. They are a bit large as they touch
a lot of functions.
The... | null | null | null | [PATCH net-next 00/15] net/mlx5e: SHAMPO, Allow high order pages in zerocopy mode | From: Dragos Tatulea <dtatulea@nvidia.com>
For now allow only PAGE_SIZE. A subsequent patch will add support for
high order pages in zero-copy mode.
Signed-off-by: Dragos Tatulea <dtatulea@nvidia.com>
Signed-off-by: Tariq Toukan <tariqt@nvidia.com>
---
.../net/ethernet/mellanox/mlx5/core/en_main.c | 19 +++++++++++++... | {
"author": "Tariq Toukan <tariqt@nvidia.com>",
"date": "Mon, 23 Feb 2026 22:41:52 +0200",
"is_openbsd": false,
"thread_id": "177210064179.1142974.16555075271250106665.git-patchwork-notify@kernel.org.mbox.gz"
} |
lkml_critique | bpf | Hi,
This series adds support for high order pages when io_uring/devmem
zero copy is used.
See detailed description by Dragos below.
Regards,
Tariq
The first patches are moving code around to allow using queue specific
parameters that are not just for XSK. They are a bit large as they touch
a lot of functions.
The... | null | null | null | [PATCH net-next 00/15] net/mlx5e: SHAMPO, Allow high order pages in zerocopy mode | Hello:
This series was applied to netdev/net-next.git (main)
by Paolo Abeni <pabeni@redhat.com>:
On Mon, 23 Feb 2026 22:41:40 +0200 you wrote:
Here is the summary with links:
- [net-next,01/15] net/mlx5e: Make mlx5e_rq_param naming consistent
https://git.kernel.org/netdev/net-next/c/376cf4227401
- [net-next,... | {
"author": "patchwork-bot+netdevbpf@kernel.org",
"date": "Thu, 26 Feb 2026 10:10:41 +0000",
"is_openbsd": false,
"thread_id": "177210064179.1142974.16555075271250106665.git-patchwork-notify@kernel.org.mbox.gz"
} |
lkml_critique | bpf | This allows BTF parsing to proceed even if we do not know the
kind. Fall back to base BTF layout if layout information is
not in split BTF.
Signed-off-by: Alan Maguire <alan.maguire@oracle.com>
---
tools/lib/bpf/btf.c | 46 ++++++++++++++++++++++++++++++++++++---------
1 file changed, 37 insertions(+), 9 deletions(-... | null | null | null | [PATCH v9 bpf-next 03/10] libbpf: use layout to compute an unknown kind size | Support encoding of BTF layout data via btf__new_empty_opts().
Current supported opts are base_btf and add_layout.
Layout information is maintained in btf.c in the layouts[] array;
when BTF is created with the add_layout option in represents the
current view of supported BTF kinds.
Signed-off-by: Alan Maguire <alan.... | {
"author": "Alan Maguire <alan.maguire@oracle.com>",
"date": "Thu, 26 Feb 2026 08:56:18 +0000",
"is_openbsd": false,
"thread_id": "20260226085624.1909682-11-alan.maguire@oracle.com.mbox.gz"
} |
lkml_critique | bpf | This allows BTF parsing to proceed even if we do not know the
kind. Fall back to base BTF layout if layout information is
not in split BTF.
Signed-off-by: Alan Maguire <alan.maguire@oracle.com>
---
tools/lib/bpf/btf.c | 46 ++++++++++++++++++++++++++++++++++++---------
1 file changed, 37 insertions(+), 9 deletions(-... | null | null | null | [PATCH v9 bpf-next 03/10] libbpf: use layout to compute an unknown kind size | verify btf__new_empty_opts() adds layouts for all kinds supported,
and after adding kind-related types for an unknown kind, ensure that
parsing uses this info when that kind is encountered rather than
giving up.
Signed-off-by: Alan Maguire <alan.maguire@oracle.com>
---
.../selftests/bpf/prog_tests/btf_kind.c | ... | {
"author": "Alan Maguire <alan.maguire@oracle.com>",
"date": "Thu, 26 Feb 2026 08:56:21 +0000",
"is_openbsd": false,
"thread_id": "20260226085624.1909682-11-alan.maguire@oracle.com.mbox.gz"
} |
lkml_critique | bpf | This allows BTF parsing to proceed even if we do not know the
kind. Fall back to base BTF layout if layout information is
not in split BTF.
Signed-off-by: Alan Maguire <alan.maguire@oracle.com>
---
tools/lib/bpf/btf.c | 46 ++++++++++++++++++++++++++++++++++++---------
1 file changed, 37 insertions(+), 9 deletions(-... | null | null | null | [PATCH v9 bpf-next 03/10] libbpf: use layout to compute an unknown kind size | BTF parsing can use layout to navigate unknown kinds, so
btf_validate_type() should take layout information into
account to avoid failure when an unrecognized kind is met.
Signed-off-by: Alan Maguire <alan.maguire@oracle.com>
---
tools/lib/bpf/btf.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff ... | {
"author": "Alan Maguire <alan.maguire@oracle.com>",
"date": "Thu, 26 Feb 2026 08:56:19 +0000",
"is_openbsd": false,
"thread_id": "20260226085624.1909682-11-alan.maguire@oracle.com.mbox.gz"
} |
lkml_critique | bpf | This allows BTF parsing to proceed even if we do not know the
kind. Fall back to base BTF layout if layout information is
not in split BTF.
Signed-off-by: Alan Maguire <alan.maguire@oracle.com>
---
tools/lib/bpf/btf.c | 46 ++++++++++++++++++++++++++++++++++++---------
1 file changed, 37 insertions(+), 9 deletions(-... | null | null | null | [PATCH v9 bpf-next 03/10] libbpf: use layout to compute an unknown kind size | Validate layout if present, but because the kernel must be
strict in what it accepts, reject BTF with unsupported kinds,
even if they are in the layout information.
Signed-off-by: Alan Maguire <alan.maguire@oracle.com>
---
kernel/bpf/btf.c | 96 ++++++++++++++++++++++++++++++++++++++----------
1 file changed, 76 inse... | {
"author": "Alan Maguire <alan.maguire@oracle.com>",
"date": "Thu, 26 Feb 2026 08:56:20 +0000",
"is_openbsd": false,
"thread_id": "20260226085624.1909682-11-alan.maguire@oracle.com.mbox.gz"
} |
lkml_critique | bpf | This allows BTF parsing to proceed even if we do not know the
kind. Fall back to base BTF layout if layout information is
not in split BTF.
Signed-off-by: Alan Maguire <alan.maguire@oracle.com>
---
tools/lib/bpf/btf.c | 46 ++++++++++++++++++++++++++++++++++++---------
1 file changed, 37 insertions(+), 9 deletions(-... | null | null | null | [PATCH v9 bpf-next 03/10] libbpf: use layout to compute an unknown kind size | Provide a way to dump BTF metadata info via bpftool; this
consists of BTF size, header fields and layout info
(if available); for example
$ bpftool btf dump file vmlinux format meta
size 6516862
magic 0xeb9f
version 1
flags 0x0
hdr_len 32
type_len 3929096
type_off 0
str_len 2587654
str_off 3929176
layout_len 80
layout... | {
"author": "Alan Maguire <alan.maguire@oracle.com>",
"date": "Thu, 26 Feb 2026 08:56:22 +0000",
"is_openbsd": false,
"thread_id": "20260226085624.1909682-11-alan.maguire@oracle.com.mbox.gz"
} |
lkml_critique | bpf | This allows BTF parsing to proceed even if we do not know the
kind. Fall back to base BTF layout if layout information is
not in split BTF.
Signed-off-by: Alan Maguire <alan.maguire@oracle.com>
---
tools/lib/bpf/btf.c | 46 ++++++++++++++++++++++++++++++++++++---------
1 file changed, 37 insertions(+), 9 deletions(-... | null | null | null | [PATCH v9 bpf-next 03/10] libbpf: use layout to compute an unknown kind size | ...and provide an example of output.
Signed-off-by: Alan Maguire <alan.maguire@oracle.com>
---
.../bpf/bpftool/Documentation/bpftool-btf.rst | 28 +++++++++++++++++--
1 file changed, 26 insertions(+), 2 deletions(-)
diff --git a/tools/bpf/bpftool/Documentation/bpftool-btf.rst b/tools/bpf/bpftool/Documentation/bpftoo... | {
"author": "Alan Maguire <alan.maguire@oracle.com>",
"date": "Thu, 26 Feb 2026 08:56:23 +0000",
"is_openbsd": false,
"thread_id": "20260226085624.1909682-11-alan.maguire@oracle.com.mbox.gz"
} |
lkml_critique | bpf | This allows BTF parsing to proceed even if we do not know the
kind. Fall back to base BTF layout if layout information is
not in split BTF.
Signed-off-by: Alan Maguire <alan.maguire@oracle.com>
---
tools/lib/bpf/btf.c | 46 ++++++++++++++++++++++++++++++++++++---------
1 file changed, 37 insertions(+), 9 deletions(-... | null | null | null | [PATCH v9 bpf-next 03/10] libbpf: use layout to compute an unknown kind size | The "layout" feature will add metadata about BTF kinds to the
generated BTF; its absence in pahole will not trigger an error so it
is safe to add unconditionally as it will simply be ignored if pahole
does not support it.
Signed-off-by: Alan Maguire <alan.maguire@oracle.com>
---
scripts/Makefile.btf | 2 ++
1 file ch... | {
"author": "Alan Maguire <alan.maguire@oracle.com>",
"date": "Thu, 26 Feb 2026 08:56:24 +0000",
"is_openbsd": false,
"thread_id": "20260226085624.1909682-11-alan.maguire@oracle.com.mbox.gz"
} |
lkml_critique | bpf | This allows BTF parsing to proceed even if we do not know the
kind. Fall back to base BTF layout if layout information is
not in split BTF.
Signed-off-by: Alan Maguire <alan.maguire@oracle.com>
---
tools/lib/bpf/btf.c | 46 ++++++++++++++++++++++++++++++++++++---------
1 file changed, 37 insertions(+), 9 deletions(-... | null | null | null | [PATCH v9 bpf-next 03/10] libbpf: use layout to compute an unknown kind size | Update struct btf_header to add a new "layout" section containing
a description of how to parse the BTF kinds known about at BTF
encoding time. This provides the opportunity for tools that might
not know all of these kinds - as is the case when older tools run
on more newly-generated BTF - to still parse the BTF provi... | {
"author": "Alan Maguire <alan.maguire@oracle.com>",
"date": "Thu, 26 Feb 2026 08:56:14 +0000",
"is_openbsd": false,
"thread_id": "20260226085624.1909682-11-alan.maguire@oracle.com.mbox.gz"
} |
lkml_critique | bpf | This allows BTF parsing to proceed even if we do not know the
kind. Fall back to base BTF layout if layout information is
not in split BTF.
Signed-off-by: Alan Maguire <alan.maguire@oracle.com>
---
tools/lib/bpf/btf.c | 46 ++++++++++++++++++++++++++++++++++++---------
1 file changed, 37 insertions(+), 9 deletions(-... | null | null | null | [PATCH v9 bpf-next 03/10] libbpf: use layout to compute an unknown kind size | BTF kind layouts provide information to parse BTF kinds. By separating
parsing BTF from using all the information it provides, we allow BTF
to encode new features even if they cannot be used by readers. This
will be helpful in particular for cases where older tools are used
to parse newer BTF with kinds the older tools... | {
"author": "Alan Maguire <alan.maguire@oracle.com>",
"date": "Thu, 26 Feb 2026 08:56:15 +0000",
"is_openbsd": false,
"thread_id": "20260226085624.1909682-11-alan.maguire@oracle.com.mbox.gz"
} |
lkml_critique | bpf | This allows BTF parsing to proceed even if we do not know the
kind. Fall back to base BTF layout if layout information is
not in split BTF.
Signed-off-by: Alan Maguire <alan.maguire@oracle.com>
---
tools/lib/bpf/btf.c | 46 ++++++++++++++++++++++++++++++++++++---------
1 file changed, 37 insertions(+), 9 deletions(-... | null | null | null | [PATCH v9 bpf-next 03/10] libbpf: use layout to compute an unknown kind size | Support reading in layout fixing endian issues on reading;
also support writing layout section to raw BTF object.
There is not yet an API to populate the layout with meaningful
information.
As part of this, we need to consider multiple valid BTF header
sizes; the original or the layout-extended headers.
So to support ... | {
"author": "Alan Maguire <alan.maguire@oracle.com>",
"date": "Thu, 26 Feb 2026 08:56:16 +0000",
"is_openbsd": false,
"thread_id": "20260226085624.1909682-11-alan.maguire@oracle.com.mbox.gz"
} |
lkml_critique | bpf | This allows BTF parsing to proceed even if we do not know the
kind. Fall back to base BTF layout if layout information is
not in split BTF.
Signed-off-by: Alan Maguire <alan.maguire@oracle.com>
---
tools/lib/bpf/btf.c | 46 ++++++++++++++++++++++++++++++++++++---------
1 file changed, 37 insertions(+), 9 deletions(-... | null | null | null | [PATCH v9 bpf-next 03/10] libbpf: use layout to compute an unknown kind size | [ ... ]
Should these kind lines include the "flags" field? Looking at
dump_btf_meta() in btf.c, the printf for the plain text output is:
printf("kind %-4u %-10s info_sz %-4d elem_sz %-4d flags %-4d\n",
i, i < NR_BTF_KINDS ? btf_kind_str[i] : "?",
l[i].info_sz, l[i].elem_sz, l[i].flags);
T... | {
"author": "bot+bpf-ci@kernel.org",
"date": "Thu, 26 Feb 2026 10:05:39 +0000 (UTC)",
"is_openbsd": false,
"thread_id": "20260226085624.1909682-11-alan.maguire@oracle.com.mbox.gz"
} |
lkml_critique | bpf | This allows BTF parsing to proceed even if we do not know the
kind. Fall back to base BTF layout if layout information is
not in split BTF.
Signed-off-by: Alan Maguire <alan.maguire@oracle.com>
---
tools/lib/bpf/btf.c | 46 ++++++++++++++++++++++++++++++++++++---------
1 file changed, 37 insertions(+), 9 deletions(-... | null | null | null | [PATCH v9 bpf-next 03/10] libbpf: use layout to compute an unknown kind size | [ ... ]
In the v8 review, Andrii suggested simplifying this to a single return
statement without the intermediate size variable:
return sizeof(struct btf_type) + l[kind].info_sz + vlen * l[kind].elem_sz;
The size variable is initialized at declaration and only modified at
the very end, so it could be dropped. ... | {
"author": "bot+bpf-ci@kernel.org",
"date": "Thu, 26 Feb 2026 10:05:42 +0000 (UTC)",
"is_openbsd": false,
"thread_id": "20260226085624.1909682-11-alan.maguire@oracle.com.mbox.gz"
} |
lkml_critique | bpf | This allows BTF parsing to proceed even if we do not know the
kind. Fall back to base BTF layout if layout information is
not in split BTF.
Signed-off-by: Alan Maguire <alan.maguire@oracle.com>
---
tools/lib/bpf/btf.c | 46 ++++++++++++++++++++++++++++++++++++---------
1 file changed, 37 insertions(+), 9 deletions(-... | null | null | null | [PATCH v9 bpf-next 03/10] libbpf: use layout to compute an unknown kind size | [ ... ]
^^^^^^^^^^^^^^
The other offset fields in this same JSON header object use the "_off"
suffix to match the struct btf_header field names:
jsonw_uint_field(json_wtr, "type_off", hdr->type_off);
jsonw_uint_field(json_wtr, "str_off", hdr->str_off);
The plain... | {
"author": "bot+bpf-ci@kernel.org",
"date": "Thu, 26 Feb 2026 10:05:46 +0000 (UTC)",
"is_openbsd": false,
"thread_id": "20260226085624.1909682-11-alan.maguire@oracle.com.mbox.gz"
} |
lkml_critique | bpf | This allows BTF parsing to proceed even if we do not know the
kind. Fall back to base BTF layout if layout information is
not in split BTF.
Signed-off-by: Alan Maguire <alan.maguire@oracle.com>
---
tools/lib/bpf/btf.c | 46 ++++++++++++++++++++++++++++++++++++---------
1 file changed, 37 insertions(+), 9 deletions(-... | null | null | null | [PATCH v9 bpf-next 03/10] libbpf: use layout to compute an unknown kind size | [ ... ]
^
Should this be <= instead of < ? If the layout section has exactly
N entries, layout_len is N * sizeof(struct btf_layout). For the
last covered kind (K = N - 1), this computes:
(K + 1) * sizeof(struct btf_layout) == layout_len
With < that evaluates to false, so... | {
"author": "bot+bpf-ci@kernel.org",
"date": "Thu, 26 Feb 2026 10:05:50 +0000 (UTC)",
"is_openbsd": false,
"thread_id": "20260226085624.1909682-11-alan.maguire@oracle.com.mbox.gz"
} |
lkml_critique | bpf | This allows BTF parsing to proceed even if we do not know the
kind. Fall back to base BTF layout if layout information is
not in split BTF.
Signed-off-by: Alan Maguire <alan.maguire@oracle.com>
---
tools/lib/bpf/btf.c | 46 ++++++++++++++++++++++++++++++++++++---------
1 file changed, 37 insertions(+), 9 deletions(-... | null | null | null | [PATCH v9 bpf-next 03/10] libbpf: use layout to compute an unknown kind size | There is a typo in the commit message: "in represents" should be
"it represents".
[ ... ]
In v8, Andrii Nakryiko asked why this is an option rather than
always emitting layout unconditionally:
https://lore.kernel.org/bpf/CAEf4BzZuFB6zvMjdqKDumUAT4vr5MeA3LBqTh5xRZmAQ5KC10g@mail.gmail.com/
Was there a reason the su... | {
"author": "bot+bpf-ci@kernel.org",
"date": "Thu, 26 Feb 2026 10:05:53 +0000 (UTC)",
"is_openbsd": false,
"thread_id": "20260226085624.1909682-11-alan.maguire@oracle.com.mbox.gz"
} |
lkml_critique | bpf | This allows BTF parsing to proceed even if we do not know the
kind. Fall back to base BTF layout if layout information is
not in split BTF.
Signed-off-by: Alan Maguire <alan.maguire@oracle.com>
---
tools/lib/bpf/btf.c | 46 ++++++++++++++++++++++++++++++++++++---------
1 file changed, 37 insertions(+), 9 deletions(-... | null | null | null | [PATCH v9 bpf-next 03/10] libbpf: use layout to compute an unknown kind size | [ ... ]
[ ... ]
[ ... ]
The memcpy here correctly caps the copy at sizeof(struct btf_header),
but btf->hdr.hdr_len retains the original value from the raw data.
If the input BTF has a future-extended header where hdr_len exceeds
sizeof(struct btf_header), only sizeof(struct btf_header) bytes are
stored, yet hdr_l... | {
"author": "bot+bpf-ci@kernel.org",
"date": "Thu, 26 Feb 2026 10:05:58 +0000 (UTC)",
"is_openbsd": false,
"thread_id": "20260226085624.1909682-11-alan.maguire@oracle.com.mbox.gz"
} |
lkml_critique | bpf | This allows BTF parsing to proceed even if we do not know the
kind. Fall back to base BTF layout if layout information is
not in split BTF.
Signed-off-by: Alan Maguire <alan.maguire@oracle.com>
---
tools/lib/bpf/btf.c | 46 ++++++++++++++++++++++++++++++++++++---------
1 file changed, 37 insertions(+), 9 deletions(-... | null | null | null | [PATCH v9 bpf-next 03/10] libbpf: use layout to compute an unknown kind size | [ ... struct btf_layout addition ... ]
Adding layout_off and layout_len to struct btf_header changes
sizeof(struct btf_header) from 24 to 32 bytes. Existing libbpf
code in tools/lib/bpf/btf.c uses sizeof(struct btf_header) in two
checks inside btf_parse_hdr() that will regress at this point in the
series:
The minim... | {
"author": "bot+bpf-ci@kernel.org",
"date": "Thu, 26 Feb 2026 10:06:01 +0000 (UTC)",
"is_openbsd": false,
"thread_id": "20260226085624.1909682-11-alan.maguire@oracle.com.mbox.gz"
} |
lkml_critique | bpf | This allows BTF parsing to proceed even if we do not know the
kind. Fall back to base BTF layout if layout information is
not in split BTF.
Signed-off-by: Alan Maguire <alan.maguire@oracle.com>
---
tools/lib/bpf/btf.c | 46 ++++++++++++++++++++++++++++++++++++---------
1 file changed, 37 insertions(+), 9 deletions(-... | null | null | null | [PATCH v9 bpf-next 03/10] libbpf: use layout to compute an unknown kind size | On 26/02/2026 10:05, bot+bpf-ci@kernel.org wrote:
There was a reason; how would this sanitization happen for kernel BTF?
Program BTF can be sanitized in userspace prior to loading, but kernel BTF
cannot unless we stable-backported a kernel change that could handle presence of kind
layout. That was rejected as an app... | {
"author": "Alan Maguire <alan.maguire@oracle.com>",
"date": "Thu, 26 Feb 2026 14:46:59 +0000",
"is_openbsd": false,
"thread_id": "20260226085624.1909682-11-alan.maguire@oracle.com.mbox.gz"
} |
lkml_critique | bpf | This allows BTF parsing to proceed even if we do not know the
kind. Fall back to base BTF layout if layout information is
not in split BTF.
Signed-off-by: Alan Maguire <alan.maguire@oracle.com>
---
tools/lib/bpf/btf.c | 46 ++++++++++++++++++++++++++++++++++++---------
1 file changed, 37 insertions(+), 9 deletions(-... | null | null | null | [PATCH v9 bpf-next 03/10] libbpf: use layout to compute an unknown kind size | On 26/02/2026 10:05, bot+bpf-ci@kernel.org wrote:
looking at this again, is it worth making the distinction between a kind
that's in the BTF layout but unknown to the kernel versus one that is
not in the BTF layout and unknown to the kernel? In both cases we reject
the BTF, and given that the kernel cannot be in the b... | {
"author": "Alan Maguire <alan.maguire@oracle.com>",
"date": "Thu, 26 Feb 2026 16:25:54 +0000",
"is_openbsd": false,
"thread_id": "20260226085624.1909682-11-alan.maguire@oracle.com.mbox.gz"
} |
lkml_critique | bpf | This allows BTF parsing to proceed even if we do not know the
kind. Fall back to base BTF layout if layout information is
not in split BTF.
Signed-off-by: Alan Maguire <alan.maguire@oracle.com>
---
tools/lib/bpf/btf.c | 46 ++++++++++++++++++++++++++++++++++++---------
1 file changed, 37 insertions(+), 9 deletions(-... | null | null | null | [PATCH v9 bpf-next 03/10] libbpf: use layout to compute an unknown kind size | On Thu, Feb 26, 2026 at 8:26 AM Alan Maguire <alan.maguire@oracle.com> wrote:
"unknown but required kind" means that the kernel doesn't understand
the kind, but its layout is described in BTF?
If so the sentence is odd, since presence in kind_layout doesn't mean
it's actually used. Here the check is when the kind is p... | {
"author": "Alexei Starovoitov <alexei.starovoitov@gmail.com>",
"date": "Thu, 26 Feb 2026 08:34:32 -0800",
"is_openbsd": false,
"thread_id": "20260226085624.1909682-11-alan.maguire@oracle.com.mbox.gz"
} |
lkml_critique | bpf | This allows BTF parsing to proceed even if we do not know the
kind. Fall back to base BTF layout if layout information is
not in split BTF.
Signed-off-by: Alan Maguire <alan.maguire@oracle.com>
---
tools/lib/bpf/btf.c | 46 ++++++++++++++++++++++++++++++++++++---------
1 file changed, 37 insertions(+), 9 deletions(-... | null | null | null | [PATCH v9 bpf-next 03/10] libbpf: use layout to compute an unknown kind size | On 26/02/2026 16:34, Alexei Starovoitov wrote:
yeah, looking at this again it's leftovers from the flags stuff which makes
it confusing. I'll revert to original error messaging since it's irrelevant
to the kernel if the kind is in the layout if the kernel doesn't know about
that kind - we can't blindly trust the layou... | {
"author": "Alan Maguire <alan.maguire@oracle.com>",
"date": "Thu, 26 Feb 2026 16:39:06 +0000",
"is_openbsd": false,
"thread_id": "20260226085624.1909682-11-alan.maguire@oracle.com.mbox.gz"
} |
lkml_critique | bpf | Hey,
I'm in the process of adding "universal truths" bpf lsm programs to
systemd that implement and enforce core system assumptions.
One aspect of this will be advanced namespace management so we can have
things like systemd-nsresourced tightly manage namespaces it allocates
and implement advanced access policies for... | null | null | null | [PATCH 0/4] bpf: add a few hooks for sandboxing | On Fri, Feb 27, 2026 at 2:28 AM Christian Brauner <brauner@kernel.org> wrote:
[...]
Good point on having ns_common initialized. Besides inum, we
should also pass ns_type and ops into the hook.
OTOH, shall we have the hook before proc_alloc_inum()? With
this change, the hook can block the operation before it causes
an... | {
"author": "Song Liu <song@kernel.org>",
"date": "Fri, 27 Feb 2026 08:38:48 -0800",
"is_openbsd": false,
"thread_id": "20260220-work-bpf-namespace-v1-0-866207db7b83@kernel.org.mbox.gz"
} |
lkml_critique | bpf | When libbpf attaches kprobe.session programs with exact function names
(the common case: SEC("kprobe.session/vfs_read")), the current code path
has two independent performance bottlenecks:
1. Userspace (libbpf): attach_kprobe_session() always parses
/proc/kallsyms to resolve function names, even when the name is exac... | null | null | null | [RFC PATCH bpf-next v2 0/3] Optimize kprobe.session attachment for exact function names | Extend existing kprobe_multi_test subtests to validate the
kprobe.session exact function name optimization:
In kprobe_multi_session.c, add test_kprobe_syms which attaches a
kprobe.session program to an exact function name (bpf_fentry_test1)
exercising the fast syms[] path that bypasses kallsyms parsing. It
calls sess... | {
"author": "Andrey Grodzovsky <andrey.grodzovsky@crowdstrike.com>",
"date": "Thu, 26 Feb 2026 12:33:42 -0500",
"is_openbsd": false,
"thread_id": "20260226173342.3565919-1-andrey.grodzovsky@crowdstrike.com.mbox.gz"
} |
lkml_critique | bpf | When libbpf attaches kprobe.session programs with exact function names
(the common case: SEC("kprobe.session/vfs_read")), the current code path
has two independent performance bottlenecks:
1. Userspace (libbpf): attach_kprobe_session() always parses
/proc/kallsyms to resolve function names, even when the name is exac... | null | null | null | [RFC PATCH bpf-next v2 0/3] Optimize kprobe.session attachment for exact function names | Implement dual-path optimization in attach_kprobe_session():
- Fast path: Use syms[] array for exact function names
(no kallsyms parsing)
- Slow path: Use pattern matching with kallsyms only for
wildcards
This avoids expensive kallsyms file parsing (~150ms) when function names
are specified exactly, improving atta... | {
"author": "Andrey Grodzovsky <andrey.grodzovsky@crowdstrike.com>",
"date": "Thu, 26 Feb 2026 12:33:40 -0500",
"is_openbsd": false,
"thread_id": "20260226173342.3565919-1-andrey.grodzovsky@crowdstrike.com.mbox.gz"
} |
lkml_critique | bpf | When libbpf attaches kprobe.session programs with exact function names
(the common case: SEC("kprobe.session/vfs_read")), the current code path
has two independent performance bottlenecks:
1. Userspace (libbpf): attach_kprobe_session() always parses
/proc/kallsyms to resolve function names, even when the name is exac... | null | null | null | [RFC PATCH bpf-next v2 0/3] Optimize kprobe.session attachment for exact function names | When ftrace_lookup_symbols() is called with a single symbol (cnt == 1),
use kallsyms_lookup_name() for O(log N) binary search instead of the
full linear scan via kallsyms_on_each_symbol().
ftrace_lookup_symbols() was designed for batch resolution of many
symbols in a single pass. For large cnt this is efficient: a si... | {
"author": "Andrey Grodzovsky <andrey.grodzovsky@crowdstrike.com>",
"date": "Thu, 26 Feb 2026 12:33:41 -0500",
"is_openbsd": false,
"thread_id": "20260226173342.3565919-1-andrey.grodzovsky@crowdstrike.com.mbox.gz"
} |
lkml_critique | bpf | When libbpf attaches kprobe.session programs with exact function names
(the common case: SEC("kprobe.session/vfs_read")), the current code path
has two independent performance bottlenecks:
1. Userspace (libbpf): attach_kprobe_session() always parses
/proc/kallsyms to resolve function names, even when the name is exac... | null | null | null | [RFC PATCH bpf-next v2 0/3] Optimize kprobe.session attachment for exact function names | [ ... ]
Is "or for module symbols" accurate here as a separate failure case?
kallsyms_lookup_name() falls back to module_kallsyms_lookup_name()
when the vmlinux lookup fails:
kernel/kallsyms.c:kallsyms_lookup_name() {
...
ret = kallsyms_lookup_names(name, &i, NULL);
if (!ret)
return kallsyms_sym... | {
"author": "bot+bpf-ci@kernel.org",
"date": "Thu, 26 Feb 2026 18:24:40 +0000 (UTC)",
"is_openbsd": false,
"thread_id": "20260226173342.3565919-1-andrey.grodzovsky@crowdstrike.com.mbox.gz"
} |
lkml_critique | bpf | We're hitting an invariant violation in Cilium that sometimes leads to
BPF programs being rejected and Cilium failing to start [1]. As far as
I know this is the first case of invariant violation found in a real
program (i.e., not by a fuzzer). The following extract from verifier
logs shows what's happening:
from 201... | null | null | null | [PATCH v2 bpf 0/4] Fix invariant violation for single-value tnums | From: Harishankar Vishwanathan <harishankar.vishwanathan@gmail.com>
This commit introduces tnum_step(), a function that, when given t, and a
number z returns the smallest member of t larger than z. The number z
must be greater or equal to the smallest member of t and less than the
largest member of t.
The first step ... | {
"author": "Paul Chaignon <paul.chaignon@gmail.com>",
"date": "Fri, 20 Feb 2026 14:56:08 +0100",
"is_openbsd": false,
"thread_id": "da102d447848a34cf13b2f490eded8d6afa056aa.camel@gmail.com.mbox.gz"
} |
lkml_critique | bpf | We're hitting an invariant violation in Cilium that sometimes leads to
BPF programs being rejected and Cilium failing to start [1]. As far as
I know this is the first case of invariant violation found in a real
program (i.e., not by a fuzzer). The following extract from verifier
logs shows what's happening:
from 201... | null | null | null | [PATCH v2 bpf 0/4] Fix invariant violation for single-value tnums | We're hitting an invariant violation in Cilium that sometimes leads to
BPF programs being rejected and Cilium failing to start [1]. The
following extract from verifier logs shows what's happening:
from 201 to 236: R1=0 R6=ctx() R7=1 R9=scalar(smin=umin=smin32=umin32=3584,smax=umax=smax32=umax32=3840,var_off=(0xe00; ... | {
"author": "Paul Chaignon <paul.chaignon@gmail.com>",
"date": "Fri, 20 Feb 2026 14:57:01 +0100",
"is_openbsd": false,
"thread_id": "da102d447848a34cf13b2f490eded8d6afa056aa.camel@gmail.com.mbox.gz"
} |
lkml_critique | bpf | We're hitting an invariant violation in Cilium that sometimes leads to
BPF programs being rejected and Cilium failing to start [1]. As far as
I know this is the first case of invariant violation found in a real
program (i.e., not by a fuzzer). The following extract from verifier
logs shows what's happening:
from 201... | null | null | null | [PATCH v2 bpf 0/4] Fix invariant violation for single-value tnums | This patch introduces selftests to cover the new bounds refinement
logic introduced in the previous patch. Without the previous patch,
the first two tests fail because of the invariant violation they
trigger. The last test fails because the R10 access is not detected as
dead code. In addition, all tests fail because of... | {
"author": "Paul Chaignon <paul.chaignon@gmail.com>",
"date": "Fri, 20 Feb 2026 14:57:54 +0100",
"is_openbsd": false,
"thread_id": "da102d447848a34cf13b2f490eded8d6afa056aa.camel@gmail.com.mbox.gz"
} |
lkml_critique | bpf | We're hitting an invariant violation in Cilium that sometimes leads to
BPF programs being rejected and Cilium failing to start [1]. As far as
I know this is the first case of invariant violation found in a real
program (i.e., not by a fuzzer). The following extract from verifier
logs shows what's happening:
from 201... | null | null | null | [PATCH v2 bpf 0/4] Fix invariant violation for single-value tnums | The reg_bounds_crafted tests validate the verifier's range analysis
logic. They focus on the actual ranges and thus ignore the tnum. As a
consequence, they carry the assumption that the tested cases can be
reproduced in userspace without using the tnum information.
Unfortunately, the previous change the refinement log... | {
"author": "Paul Chaignon <paul.chaignon@gmail.com>",
"date": "Fri, 20 Feb 2026 14:58:32 +0100",
"is_openbsd": false,
"thread_id": "da102d447848a34cf13b2f490eded8d6afa056aa.camel@gmail.com.mbox.gz"
} |
lkml_critique | bpf | We're hitting an invariant violation in Cilium that sometimes leads to
BPF programs being rejected and Cilium failing to start [1]. As far as
I know this is the first case of invariant violation found in a real
program (i.e., not by a fuzzer). The following extract from verifier
logs shows what's happening:
from 201... | null | null | null | [PATCH v2 bpf 0/4] Fix invariant violation for single-value tnums | ^^^^^^^
The tnum_step() comment in tnum.c and the header in tnum.h both say
"returns the smallest member of t larger than z." Should "largest" be
"smallest" here?
---
AI reviewed your patch. Please fix the bug or email reply why it's not a bug.
See: https://github.com/kernel-patches/vmtest/blob/master/ci/claude/READ... | {
"author": "bot+bpf-ci@kernel.org",
"date": "Fri, 20 Feb 2026 14:29:08 +0000 (UTC)",
"is_openbsd": false,
"thread_id": "da102d447848a34cf13b2f490eded8d6afa056aa.camel@gmail.com.mbox.gz"
} |
lkml_critique | bpf | We're hitting an invariant violation in Cilium that sometimes leads to
BPF programs being rejected and Cilium failing to start [1]. As far as
I know this is the first case of invariant violation found in a real
program (i.e., not by a fuzzer). The following extract from verifier
logs shows what's happening:
from 201... | null | null | null | [PATCH v2 bpf 0/4] Fix invariant violation for single-value tnums | On Fri, Feb 20, 2026 at 02:55:04PM +0100, Paul Chaignon wrote:
I have tested this patchset (v2) on an ARM64 system (NanoPi R76S / RK3588)
running Void Linux (glibc) with Kernel 6.18.13.
Before applying the patches, I was hitting the "REG INVARIANTS VIOLATION"
stack trace and BPF program rejections during Cilium 1.19.... | {
"author": "Marco Schirrmeister <mschirrmeister@gmail.com>",
"date": "Fri, 20 Feb 2026 20:45:11 +0100",
"is_openbsd": false,
"thread_id": "da102d447848a34cf13b2f490eded8d6afa056aa.camel@gmail.com.mbox.gz"
} |
lkml_critique | bpf | We're hitting an invariant violation in Cilium that sometimes leads to
BPF programs being rejected and Cilium failing to start [1]. As far as
I know this is the first case of invariant violation found in a real
program (i.e., not by a fuzzer). The following extract from verifier
logs shows what's happening:
from 201... | null | null | null | [PATCH v2 bpf 0/4] Fix invariant violation for single-value tnums | On Fri, 2026-02-20 at 14:57 +0100, Paul Chaignon wrote:
Acked-by: Eduard Zingerman <eddyz87@gmail.com>
[...] | {
"author": "Eduard Zingerman <eddyz87@gmail.com>",
"date": "Fri, 20 Feb 2026 15:27:03 -0800",
"is_openbsd": false,
"thread_id": "da102d447848a34cf13b2f490eded8d6afa056aa.camel@gmail.com.mbox.gz"
} |
lkml_critique | bpf | We're hitting an invariant violation in Cilium that sometimes leads to
BPF programs being rejected and Cilium failing to start [1]. As far as
I know this is the first case of invariant violation found in a real
program (i.e., not by a fuzzer). The following extract from verifier
logs shows what's happening:
from 201... | null | null | null | [PATCH v2 bpf 0/4] Fix invariant violation for single-value tnums | On Fri, 2026-02-20 at 14:57 +0100, Paul Chaignon wrote:
Hi Paul,
I have a few nitpicks, sorry for not commenting about it in v1.
Nit: make this `r10 = 0;`, just like in the last test?
(and in the next test).
Also, the test works the same if I replace 0xe00 -> 0xe, 0xf00 -> 0xf.
Maybe pick the smaller constant... | {
"author": "Eduard Zingerman <eddyz87@gmail.com>",
"date": "Fri, 20 Feb 2026 16:20:55 -0800",
"is_openbsd": false,
"thread_id": "da102d447848a34cf13b2f490eded8d6afa056aa.camel@gmail.com.mbox.gz"
} |
lkml_critique | bpf | We're hitting an invariant violation in Cilium that sometimes leads to
BPF programs being rejected and Cilium failing to start [1]. As far as
I know this is the first case of invariant violation found in a real
program (i.e., not by a fuzzer). The following extract from verifier
logs shows what's happening:
from 201... | null | null | null | [PATCH v2 bpf 0/4] Fix invariant violation for single-value tnums | On Fri, 2026-02-20 at 14:58 +0100, Paul Chaignon wrote:
The change seem to preserve the original test case intent.
Acked-by: Eduard Zingerman <eddyz87@gmail.com>
[...] | {
"author": "Eduard Zingerman <eddyz87@gmail.com>",
"date": "Fri, 20 Feb 2026 16:34:14 -0800",
"is_openbsd": false,
"thread_id": "da102d447848a34cf13b2f490eded8d6afa056aa.camel@gmail.com.mbox.gz"
} |
lkml_critique | bpf | We're hitting an invariant violation in Cilium that sometimes leads to
BPF programs being rejected and Cilium failing to start [1]. As far as
I know this is the first case of invariant violation found in a real
program (i.e., not by a fuzzer). The following extract from verifier
logs shows what's happening:
from 201... | null | null | null | [PATCH v2 bpf 0/4] Fix invariant violation for single-value tnums | On Fri, Feb 20, 2026 at 04:20:55PM -0800, Eduard Zingerman wrote:
Hi Eduard,
Sorry for the late answer, I've been travelling.
No worries. The AI bot also found a new small thing :')
I noticed you haven't acked the first patch. I think it's a bit thougher
to follow, so is there anything we could do to ease review?
... | {
"author": "Paul Chaignon <paul.chaignon@gmail.com>",
"date": "Wed, 25 Feb 2026 11:21:46 +0100",
"is_openbsd": false,
"thread_id": "da102d447848a34cf13b2f490eded8d6afa056aa.camel@gmail.com.mbox.gz"
} |
lkml_critique | bpf | We're hitting an invariant violation in Cilium that sometimes leads to
BPF programs being rejected and Cilium failing to start [1]. As far as
I know this is the first case of invariant violation found in a real
program (i.e., not by a fuzzer). The following extract from verifier
logs shows what's happening:
from 201... | null | null | null | [PATCH v2 bpf 0/4] Fix invariant violation for single-value tnums | On Wed, 2026-02-25 at 11:21 +0100, Paul Chaignon wrote:
It made sense on the first pass, comments help.
Let me re-read it tomorrow, but I assume this patch works.
You mean that min/max logic for 'r0 == 0xe' will adjust the range, right?
Makes sense, no changes necessary then.
Wellp, that's a bit embarrassing, sorr... | {
"author": "Eduard Zingerman <eddyz87@gmail.com>",
"date": "Thu, 26 Feb 2026 01:27:23 -0800",
"is_openbsd": false,
"thread_id": "da102d447848a34cf13b2f490eded8d6afa056aa.camel@gmail.com.mbox.gz"
} |
lkml_critique | bpf | v1: https://lore.kernel.org/bpf/cover.1771605821.git.josef@toxicpanda.com/
v2: https://lore.kernel.org/bpf/cover.1771616227.git.josef@toxicpanda.com/
v3: https://lore.kernel.org/bpf/cover.1771622266.git.josef@toxicpanda.com/
v4: https://lore.kernel.org/bpf/cover.1771625484.git.josef@toxicpanda.com/
v1->v2:
- Added a b... | null | null | null | [PATCH v5 0/3] libbpf/bpftool: support merging split BTFs | btf__add_btf() currently rejects split BTF sources with -ENOTSUP.
This prevents merging types from multiple kernel module BTFs that
are all split against the same vmlinux base.
Extend btf__add_btf() to handle split BTF sources by:
- Replacing the blanket -ENOTSUP with a validation that src and dst
share the same ba... | {
"author": "Josef Bacik <josef@toxicpanda.com>",
"date": "Tue, 24 Feb 2026 11:40:52 -0500",
"is_openbsd": false,
"thread_id": "a8f149ea-2b96-43b8-8cc4-8a3e58c230d9@qmon.net.mbox.gz"
} |
lkml_critique | bpf | v1: https://lore.kernel.org/bpf/cover.1771605821.git.josef@toxicpanda.com/
v2: https://lore.kernel.org/bpf/cover.1771616227.git.josef@toxicpanda.com/
v3: https://lore.kernel.org/bpf/cover.1771622266.git.josef@toxicpanda.com/
v4: https://lore.kernel.org/bpf/cover.1771625484.git.josef@toxicpanda.com/
v1->v2:
- Added a b... | null | null | null | [PATCH v5 0/3] libbpf/bpftool: support merging split BTFs | Add support for specifying multiple file sources in 'bpftool btf dump'
to generate a single C header containing types from vmlinux plus
multiple kernel modules:
bpftool btf dump file /sys/kernel/btf/mod1 file /sys/kernel/btf/mod2 format c
This is useful for BPF programs that need to access types defined in
kernel m... | {
"author": "Josef Bacik <josef@toxicpanda.com>",
"date": "Tue, 24 Feb 2026 11:40:53 -0500",
"is_openbsd": false,
"thread_id": "a8f149ea-2b96-43b8-8cc4-8a3e58c230d9@qmon.net.mbox.gz"
} |
lkml_critique | bpf | v1: https://lore.kernel.org/bpf/cover.1771605821.git.josef@toxicpanda.com/
v2: https://lore.kernel.org/bpf/cover.1771616227.git.josef@toxicpanda.com/
v3: https://lore.kernel.org/bpf/cover.1771622266.git.josef@toxicpanda.com/
v4: https://lore.kernel.org/bpf/cover.1771625484.git.josef@toxicpanda.com/
v1->v2:
- Added a b... | null | null | null | [PATCH v5 0/3] libbpf/bpftool: support merging split BTFs | Add a test that verifies btf__add_btf() correctly handles merging
multiple split BTF objects that share the same base BTF. The test
creates two sibling split BTFs on a common base, merges them into
a combined split BTF, and validates that base type references are
preserved while split type references are properly remap... | {
"author": "Josef Bacik <josef@toxicpanda.com>",
"date": "Tue, 24 Feb 2026 11:40:54 -0500",
"is_openbsd": false,
"thread_id": "a8f149ea-2b96-43b8-8cc4-8a3e58c230d9@qmon.net.mbox.gz"
} |
lkml_critique | bpf | v1: https://lore.kernel.org/bpf/cover.1771605821.git.josef@toxicpanda.com/
v2: https://lore.kernel.org/bpf/cover.1771616227.git.josef@toxicpanda.com/
v3: https://lore.kernel.org/bpf/cover.1771622266.git.josef@toxicpanda.com/
v4: https://lore.kernel.org/bpf/cover.1771625484.git.josef@toxicpanda.com/
v1->v2:
- Added a b... | null | null | null | [PATCH v5 0/3] libbpf/bpftool: support merging split BTFs | The commit message says vmlinux is "skipped with a warning" but the
code filters vmlinux entries silently. In do_dump(), the first file
is filtered with:
if (strcmp(*argv, sysfs_vmlinux) != 0)
files[nr_files++] = *argv;
and subsequent files with:
if (strcmp(*argv, sysfs_vmlinux) == 0) {
NEXT... | {
"author": "bot+bpf-ci@kernel.org",
"date": "Tue, 24 Feb 2026 17:18:33 +0000 (UTC)",
"is_openbsd": false,
"thread_id": "a8f149ea-2b96-43b8-8cc4-8a3e58c230d9@qmon.net.mbox.gz"
} |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.