data_type large_stringclasses 3
values | source large_stringclasses 29
values | code large_stringlengths 98 49.4M | filepath large_stringlengths 5 161 ⌀ | message large_stringclasses 234
values | commit large_stringclasses 234
values | subject large_stringclasses 418
values | critique large_stringlengths 101 1.26M ⌀ | metadata dict |
|---|---|---|---|---|---|---|---|---|
lkml_critique | bpf | When a kernel module exports a symbol with the same name as an existing
vmlinux symbol, kprobe attachment via bpf_program__attach_kprobe_opts()
fails with EADDRNOTAVAIL (perf_event_open path) or EINVAL (legacy
tracefs path).
This series implements a fallback mechanism that, on such failures,
resolves the vmlinux addre... | null | null | null | [RFC PATCH bpf-next v2 0/2] libbpf: Handle duplicate kprobe symbols | Hey Emil, sorry for sending this twice. My reply was dropped
from bpf@vger.kernel.org due to formatting issues.
I looked into this.
I confirmed it happens for data symbols - zero-sized lock_class_key
objects produce many duplicate name+address entries in
kallsyms:
ffffffff96307908 __key.0
ffffffff96307908 __key.1
f... | {
"author": "Andrey Grodzovsky <andrey.grodzovsky@crowdstrike.com>",
"date": "Tue, 24 Feb 2026 15:42:03 -0500",
"is_openbsd": false,
"thread_id": "20260224172340.1704618-1-andrey.grodzovsky@crowdstrike.com.mbox.gz"
} |
lkml_critique | bpf | When a kernel module exports a symbol with the same name as an existing
vmlinux symbol, kprobe attachment via bpf_program__attach_kprobe_opts()
fails with EADDRNOTAVAIL (perf_event_open path) or EINVAL (legacy
tracefs path).
This series implements a fallback mechanism that, on such failures,
resolves the vmlinux addre... | null | null | null | [RFC PATCH bpf-next v2 0/2] libbpf: Handle duplicate kprobe symbols | On Tue Feb 24, 2026 at 12:23 PM EST, Andrey Grodzovsky wrote:
Looks reasonable, after making the change below feel free to add:
Reviewed-by: Emil Tsalapatis <emil@etsalapatis.com>
AFAICT This is kinda ugly but necessary since we can't really include test_progs.h.
Would be nice if there was an alternative.
Can we... | {
"author": "\"Emil Tsalapatis\" <emil@etsalapatis.com>",
"date": "Thu, 26 Feb 2026 21:17:56 -0500",
"is_openbsd": false,
"thread_id": "20260224172340.1704618-1-andrey.grodzovsky@crowdstrike.com.mbox.gz"
} |
lkml_critique | bpf | Introduces a way to override the standard io_uring_enter syscall
execution with an extendible event loop, which can be controlled
by BPF via new io_uring struct_ops or from within the kernel.
There are multiple use cases I want to cover with this:
- Syscall avoidance. Instead of returning to the userspace for
CQE p... | null | null | null | [PATCH v10 0/4] BPF controlled io_uring | The io_uring_enter() has a fixed order of execution: it submits
requests, waits for completions, and returns to the user. Allow to
optionally replace it with a custom loop driven by a callback called
loop_step. The basic requirements to the callback is that it should be
able to submit requests, wait for completions, pa... | {
"author": "Pavel Begunkov <asml.silence@gmail.com>",
"date": "Thu, 26 Feb 2026 12:48:38 +0000",
"is_openbsd": false,
"thread_id": "cover.1772109579.git.asml.silence@gmail.com.mbox.gz"
} |
lkml_critique | bpf | Introduces a way to override the standard io_uring_enter syscall
execution with an extendible event loop, which can be controlled
by BPF via new io_uring struct_ops or from within the kernel.
There are multiple use cases I want to cover with this:
- Syscall avoidance. Instead of returning to the userspace for
CQE p... | null | null | null | [PATCH v10 0/4] BPF controlled io_uring | Introduce io_uring BPF struct ops implementing the loop_step callback,
which will allow BPF to overwrite the default io_uring event loop logic.
The callback takes an io_uring context, the main role of which is to be
passed to io_uring kfuncs. The other argument is a struct iou_loop_params,
which BPF can use to request... | {
"author": "Pavel Begunkov <asml.silence@gmail.com>",
"date": "Thu, 26 Feb 2026 12:48:39 +0000",
"is_openbsd": false,
"thread_id": "cover.1772109579.git.asml.silence@gmail.com.mbox.gz"
} |
lkml_critique | bpf | Introduces a way to override the standard io_uring_enter syscall
execution with an extendible event loop, which can be controlled
by BPF via new io_uring struct_ops or from within the kernel.
There are multiple use cases I want to cover with this:
- Syscall avoidance. Instead of returning to the userspace for
CQE p... | null | null | null | [PATCH v10 0/4] BPF controlled io_uring | Add two kfuncs that should cover most of the needs:
1. bpf_io_uring_submit_sqes(), which allows to submit io_uring requests.
It mirrors the normal user space submission path and follows all
related io_uring_enter(2) rules. i.e. SQEs are taken from the SQ
according to head/tail values. In case of IORING_SETUP_... | {
"author": "Pavel Begunkov <asml.silence@gmail.com>",
"date": "Thu, 26 Feb 2026 12:48:40 +0000",
"is_openbsd": false,
"thread_id": "cover.1772109579.git.asml.silence@gmail.com.mbox.gz"
} |
lkml_critique | bpf | Introduces a way to override the standard io_uring_enter syscall
execution with an extendible event loop, which can be controlled
by BPF via new io_uring struct_ops or from within the kernel.
There are multiple use cases I want to cover with this:
- Syscall avoidance. Instead of returning to the userspace for
CQE p... | null | null | null | [PATCH v10 0/4] BPF controlled io_uring | Implement BPF struct ops registration. It's registered off the BPF
path, and can be removed by BPF as well as io_uring. To protect it,
introduce a global lock synchronising registration. ctx->uring_lock can
be nested under it. ctx->bpf_ops is write protected by both locks and
so it's safe to read it under either of the... | {
"author": "Pavel Begunkov <asml.silence@gmail.com>",
"date": "Thu, 26 Feb 2026 12:48:41 +0000",
"is_openbsd": false,
"thread_id": "cover.1772109579.git.asml.silence@gmail.com.mbox.gz"
} |
lkml_critique | bpf | get_upper_ifindexes() iterates over all upper devices and writes their
indices into an array without checking bounds.
Also the callers assume that the max number of upper devices is
MAX_NEST_DEV and allocate excluded_devices[1+MAX_NEST_DEV] on the stack,
but that assumption is not correct and the number of upper devic... | null | null | null | [PATCH v4 bpf] bpf: devmap: fix stack-out-of-bounds write in get_upper_ifindexes() | Hello:
This patch was applied to bpf/bpf.git (master)
by Alexei Starovoitov <ast@kernel.org>:
On Wed, 25 Feb 2026 05:34:44 +0000 you wrote:
Here is the summary with links:
- [v4,bpf] bpf: devmap: fix stack-out-of-bounds write in get_upper_ifindexes()
https://git.kernel.org/bpf/bpf/c/b7bf516c3ecd
You are aweso... | {
"author": "patchwork-bot+netdevbpf@kernel.org",
"date": "Thu, 26 Feb 2026 19:30:21 +0000",
"is_openbsd": false,
"thread_id": "177213422104.1808439.4101803762888860972.git-patchwork-notify@kernel.org.mbox.gz"
} |
lkml_critique | bpf | test_progs run with ASAN reported [1]:
==126==ERROR: LeakSanitizer: detected memory leaks
Direct leak of 32 byte(s) in 1 object(s) allocated from:
#0 0x7f1ff3cfa340 in calloc ../../../../src/libsanitizer/asan/asan_malloc_linux.cpp:77
#1 0x5610c15bb520 in bpf_program_attach_fd /codebuild/output/src6859... | null | null | null | [PATCH bpf v1] selftests/bpf: Fix a memory leak in xdp_flowtable test | On 2026-02-25 at 06:03:51, Ihor Solodrai (ihor.solodrai@linux.dev) wrote:
Reviewed-by: Subbaraya Sundeep <sbhatta@marvell.com>
Thanks,
Sundeep | {
"author": "Subbaraya Sundeep <sbhatta@marvell.com>",
"date": "Wed, 25 Feb 2026 16:33:38 +0530",
"is_openbsd": false,
"thread_id": "177213422254.1808439.1401384174214570976.git-patchwork-notify@kernel.org.mbox.gz"
} |
lkml_critique | bpf | test_progs run with ASAN reported [1]:
==126==ERROR: LeakSanitizer: detected memory leaks
Direct leak of 32 byte(s) in 1 object(s) allocated from:
#0 0x7f1ff3cfa340 in calloc ../../../../src/libsanitizer/asan/asan_malloc_linux.cpp:77
#1 0x5610c15bb520 in bpf_program_attach_fd /codebuild/output/src6859... | null | null | null | [PATCH bpf v1] selftests/bpf: Fix a memory leak in xdp_flowtable test | Hello:
This patch was applied to bpf/bpf.git (master)
by Alexei Starovoitov <ast@kernel.org>:
On Tue, 24 Feb 2026 16:33:51 -0800 you wrote:
Here is the summary with links:
- [bpf,v1] selftests/bpf: Fix a memory leak in xdp_flowtable test
https://git.kernel.org/bpf/bpf/c/60e3cbef3500
You are awesome, thank you... | {
"author": "patchwork-bot+netdevbpf@kernel.org",
"date": "Thu, 26 Feb 2026 19:30:22 +0000",
"is_openbsd": false,
"thread_id": "177213422254.1808439.1401384174214570976.git-patchwork-notify@kernel.org.mbox.gz"
} |
lkml_critique | bpf | Hello,
I am pursuing my quest to convert standalone bpf tests (from
tools/testing/selftests/bpf) into the test_progs framework so they can
be executed automatically by the CI tooling.
I would like to continue on the bpftool tests, especially
test_bpftool.py ([1]). This one involves quite a lot of json parsing on
bpfto... | null | null | null | [Question] json parsing and bpf selftests dependencies | Alexis Lothoré <alexis.lothore@bootlin.com> writes:
Can we please make that test_progs can be built without json deps and
run tests that do not require them, it's useful because we build tests
in a restricted container image, where adding a new library may be
undesirable (I'm not talking about github CI). | {
"author": "Mykyta Yatsenko <mykyta.yatsenko5@gmail.com>",
"date": "Thu, 26 Feb 2026 15:01:47 +0000",
"is_openbsd": false,
"thread_id": "DGPKHPMDRQXL.3ARKDNHT1FB4O@bootlin.com.mbox.gz"
} |
lkml_critique | bpf | Hello,
I am pursuing my quest to convert standalone bpf tests (from
tools/testing/selftests/bpf) into the test_progs framework so they can
be executed automatically by the CI tooling.
I would like to continue on the bpftool tests, especially
test_bpftool.py ([1]). This one involves quite a lot of json parsing on
bpfto... | null | null | null | [Question] json parsing and bpf selftests dependencies | On Thu, Feb 26, 2026 at 2:36 AM Alexis Lothoré
<alexis.lothore@bootlin.com> wrote:
I think it outlived itself long ago.
Just delete it.
Any new bpftool features can be tested through test_progs.
No need to test json output specifically.
It's diminishing returns. | {
"author": "Alexei Starovoitov <alexei.starovoitov@gmail.com>",
"date": "Thu, 26 Feb 2026 09:21:55 -0800",
"is_openbsd": false,
"thread_id": "DGPKHPMDRQXL.3ARKDNHT1FB4O@bootlin.com.mbox.gz"
} |
lkml_critique | bpf | Hello,
I am pursuing my quest to convert standalone bpf tests (from
tools/testing/selftests/bpf) into the test_progs framework so they can
be executed automatically by the CI tooling.
I would like to continue on the bpftool tests, especially
test_bpftool.py ([1]). This one involves quite a lot of json parsing on
bpfto... | null | null | null | [Question] json parsing and bpf selftests dependencies | On Thu Feb 26, 2026 at 6:21 PM CET, Alexei Starovoitov wrote:
Ok. That's a doubt I had while converting the first round of tests
(bpf_metadata, bpftool_map_access), whether we really want to test exact
bpftool CLI output, or if test_progs->libbpf testing was fine.
I'll remote this test_bpftool.py then, thanks for the... | {
"author": "=?utf-8?q?Alexis_Lothor=C3=A9?= <alexis.lothore@bootlin.com>",
"date": "Fri, 27 Feb 2026 08:31:34 +0100",
"is_openbsd": false,
"thread_id": "DGPKHPMDRQXL.3ARKDNHT1FB4O@bootlin.com.mbox.gz"
} |
lkml_critique | bpf | The test_bpftool.sh script runs a python unittest script checking
bpftool json output on different commands. As part of the ongoing effort
to get rid of any standalone test, this script should either be
converted to test_progs or removed.
As validating bpftool json output does not bring much value to the test
base (an... | null | null | null | [PATCH bpf-next] selftests/bpf: drop test_bpftool.sh | 2026-02-27 09:08 UTC+0100 ~ "Alexis Lothoré (eBPF Foundation)"
<alexis.lothore@bootlin.com>
Acked-by: Quentin Monnet <qmo@kernel.org>
Regarding the discussion on JSON: If you need to check bpftool's output
in other tests, it's probably OK to simply look at the plain output.
We've been discouraging people to parse th... | {
"author": "Quentin Monnet <qmo@kernel.org>",
"date": "Fri, 27 Feb 2026 09:31:41 +0000",
"is_openbsd": false,
"thread_id": "DGPNYNB5YCQJ.J5LKKGGGTB83@bootlin.com.mbox.gz"
} |
lkml_critique | bpf | The test_bpftool.sh script runs a python unittest script checking
bpftool json output on different commands. As part of the ongoing effort
to get rid of any standalone test, this script should either be
converted to test_progs or removed.
As validating bpftool json output does not bring much value to the test
base (an... | null | null | null | [PATCH bpf-next] selftests/bpf: drop test_bpftool.sh | Hello Quentin,
On Fri Feb 27, 2026 at 10:31 AM CET, Quentin Monnet wrote:
ACK, thanks for your input, I'll keep that in mind for the next tests to
convert (I still have some test_bpftool_synctypes that I did not check
yet).
Alexis
--
Alexis Lothoré, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.... | {
"author": "=?utf-8?q?Alexis_Lothor=C3=A9?= <alexis.lothore@bootlin.com>",
"date": "Fri, 27 Feb 2026 11:14:44 +0100",
"is_openbsd": false,
"thread_id": "DGPNYNB5YCQJ.J5LKKGGGTB83@bootlin.com.mbox.gz"
} |
lkml_critique | bpf | Adding bpftool maintainer.
On Tue, Feb 24, 2026 at 12:16:40PM +0000, Leo Yan wrote:
> GCC-15 release claims [1]:
>
> {0} initializer in C or C++ for unions no longer guarantees clearing
> of the whole union (except for static storage duration initialization),
> it just initializes the first union member to zero... | null | null | null | Re: [PATCH RESEND v2] tools build: Use -fzero-init-padding-bits=all | 2026-02-26 10:38 UTC-0800 ~ Namhyung Kim <namhyung@kernel.org>
Thank you Namhyung for the Cc.
I built bpftool with the patch, with gcc 13 (which didn't get the flag,
as expected) and gcc 15, and it's fine with both. As far as I can tell,
bpftool does not initialise any union with "{0}" anyway.
One potential concern... | {
"author": "Quentin Monnet <qmo@kernel.org>",
"date": "Thu, 26 Feb 2026 22:52:01 +0000",
"is_openbsd": false,
"thread_id": "c886c8c9-d336-4ec3-94c0-c4869dee7e7f@kernel.org.mbox.gz"
} |
lkml_critique | bpf | Adding bpftool maintainer.
On Tue, Feb 24, 2026 at 12:16:40PM +0000, Leo Yan wrote:
> GCC-15 release claims [1]:
>
> {0} initializer in C or C++ for unions no longer guarantees clearing
> of the whole union (except for static storage duration initialization),
> it just initializes the first union member to zero... | null | null | null | Re: [PATCH RESEND v2] tools build: Use -fzero-init-padding-bits=all | On Thu, Feb 26, 2026 at 10:52:01PM +0000, Quentin Monnet wrote:
Thanks a lot for testing!
To avoid confusion, we can use EXTRA_CFLAGS and HOST_EXTRACFLAGS instead
in Makefile.include:
-----
# cc-option
# Usage: CFLAGS += $(call cc-option,-march=winchip-c6,-march=i586)
cc-option = $(call try-run, \
$(CC) -We... | {
"author": "Leo Yan <leo.yan@arm.com>",
"date": "Fri, 27 Feb 2026 10:36:11 +0000",
"is_openbsd": false,
"thread_id": "c886c8c9-d336-4ec3-94c0-c4869dee7e7f@kernel.org.mbox.gz"
} |
lkml_critique | bpf | Adding bpftool maintainer.
On Tue, Feb 24, 2026 at 12:16:40PM +0000, Leo Yan wrote:
> GCC-15 release claims [1]:
>
> {0} initializer in C or C++ for unions no longer guarantees clearing
> of the whole union (except for static storage duration initialization),
> it just initializes the first union member to zero... | null | null | null | Re: [PATCH RESEND v2] tools build: Use -fzero-init-padding-bits=all | 2026-02-27 10:36 UTC+0000 ~ Leo Yan <leo.yan@arm.com>
This sounds like it should work for bpftool as long as we += and don't
overwrite the EXTRA_CFLAGS passed from command line. In bpftool's
Makefile we'd have to move HOST_CFLAGS's CFLAGS-based defintion higher
up, before we add the EXTRA_CFLAGS to CFLAGS; and if any... | {
"author": "Quentin Monnet <qmo@kernel.org>",
"date": "Fri, 27 Feb 2026 11:52:38 +0000",
"is_openbsd": false,
"thread_id": "c886c8c9-d336-4ec3-94c0-c4869dee7e7f@kernel.org.mbox.gz"
} |
lkml_critique | bpf |
I'd like to propose the idea of adding support for optional userspace
JIT engines to the eBPF subsystem. I have a promising prototype already,
but I’d like to discuss the broader implications and open questions
around this idea before moving forward.
Motivation
==========
In modern systems, eBPF is often used as a... | null | null | null | [LSF/MM/BPF TOPIC] Userspace JIT for eBPF | On Thu, Jan 22, 2026 at 10:43 AM Gladyshev Ilya
<gladyshev.ilya1@h-partners.com> wrote:
The work on a register allocator has already started. It's very early,
but yeah we do expect nice performance benefits on arm64.
That's actually what was happening for years now.
There are several issues with external JIT.
1. I... | {
"author": "Alexei Starovoitov <alexei.starovoitov@gmail.com>",
"date": "Wed, 28 Jan 2026 19:00:31 -0800",
"is_openbsd": false,
"thread_id": "738a358c-e695-44f9-8288-a20d917dc26c@huawei.com.mbox.gz"
} |
lkml_critique | bpf |
I'd like to propose the idea of adding support for optional userspace
JIT engines to the eBPF subsystem. I have a promising prototype already,
but I’d like to discuss the broader implications and open questions
around this idea before moving forward.
Motivation
==========
In modern systems, eBPF is often used as a... | null | null | null | [LSF/MM/BPF TOPIC] Userspace JIT for eBPF | On 1/29/2026 6:00 AM, Alexei Starovoitov wrote:
For any performance gains you will also need stack maps for memory to
register promotion. Also see below
Right now in-kernel compiler is sophisticated only in terms of code
complexity...
To replicate LLVM, you would need to perform very complex control-flow
analysis... | {
"author": "Gladyshev Ilya <gladyshev.ilya1@h-partners.com>",
"date": "Thu, 29 Jan 2026 10:33:09 +0300",
"is_openbsd": false,
"thread_id": "738a358c-e695-44f9-8288-a20d917dc26c@huawei.com.mbox.gz"
} |
lkml_critique | bpf |
I'd like to propose the idea of adding support for optional userspace
JIT engines to the eBPF subsystem. I have a promising prototype already,
but I’d like to discuss the broader implications and open questions
around this idea before moving forward.
Motivation
==========
In modern systems, eBPF is often used as a... | null | null | null | [LSF/MM/BPF TOPIC] Userspace JIT for eBPF | On Wed, Jan 28, 2026 at 11:33 PM Gladyshev Ilya
<gladyshev.ilya1@h-partners.com> wrote:
See https://github.com/OrderLab/ePass
It converts bpf insns into SSA, does some passes, then register allocator
and lowers back to bpf ISA.
All of that is done in the kernel.
Right. It was discussed at LPC. If the compiler is tru... | {
"author": "Alexei Starovoitov <alexei.starovoitov@gmail.com>",
"date": "Sat, 31 Jan 2026 19:26:54 -0800",
"is_openbsd": false,
"thread_id": "738a358c-e695-44f9-8288-a20d917dc26c@huawei.com.mbox.gz"
} |
lkml_critique | bpf |
I'd like to propose the idea of adding support for optional userspace
JIT engines to the eBPF subsystem. I have a promising prototype already,
but I’d like to discuss the broader implications and open questions
around this idea before moving forward.
Motivation
==========
In modern systems, eBPF is often used as a... | null | null | null | [LSF/MM/BPF TOPIC] Userspace JIT for eBPF | Hi,
Looks interesting, in terms of getting latest available machine-code optimizations into eBPF quickly, w/o kernel update.
We have several production scenarios, that might get benefit from that.
It’s clear that Linux kernel can eventually get these optimizations in future, but now we have lots of machines with some... | {
"author": "Stepanov Anatoly <stepanov.anatoly@huawei.com>",
"date": "Thu, 26 Feb 2026 14:38:36 +0300",
"is_openbsd": false,
"thread_id": "738a358c-e695-44f9-8288-a20d917dc26c@huawei.com.mbox.gz"
} |
lkml_critique | bpf | When CONFIG_DEBUG_INFO_BTF_MODULES is enabled and vmlinux is available,
Makefilefile.modfinal and gen-btf.sh will try to use resolve_btfids
on the module .ko. install-extmod-build currently does not package
resolve_btfids, so that step fails.
Also package resolve_btfids if it may get used.
Signed-off-by: Thomas Weißs... | null | null | null | [PATCH] kbuild: install-extmod-build: Package resolve_btfids if
necessary | On Thu, Feb 26, 2026 at 08:41:48AM +0100, Thomas Weischuh wrote:
Heh, ironic that I was just looking in that area yesterday and I had
thought that this would be necessary if vmlinux is available but then
never followed up... Thanks for this.
Nicolas, can I take this as a fix? | {
"author": "Nathan Chancellor <nathan@kernel.org>",
"date": "Thu, 26 Feb 2026 13:37:58 -0700",
"is_openbsd": false,
"thread_id": "aaCxa33uB2JvS9qg@levanger.mbox.gz"
} |
lkml_critique | bpf | When CONFIG_DEBUG_INFO_BTF_MODULES is enabled and vmlinux is available,
Makefilefile.modfinal and gen-btf.sh will try to use resolve_btfids
on the module .ko. install-extmod-build currently does not package
resolve_btfids, so that step fails.
Also package resolve_btfids if it may get used.
Signed-off-by: Thomas Weißs... | null | null | null | [PATCH] kbuild: install-extmod-build: Package resolve_btfids if
necessary | On Thu, Feb 26, 2026 at 01:37:58PM -0700, Nathan Chancellor wrote:
yes, please.
Reviewed-by: Nicolas Schier <nsc@kernel.org>
--
Nicolas | {
"author": "Nicolas Schier <nsc@kernel.org>",
"date": "Thu, 26 Feb 2026 21:47:39 +0100",
"is_openbsd": false,
"thread_id": "aaCxa33uB2JvS9qg@levanger.mbox.gz"
} |
lkml_critique | qemu-devel | As a part of the confidential guest reset process, the existing encrypted guest
state must be made mutable since it would be discarded after reset. A new
encrypted and locked guest state must be established after the reset. To this
end, a new boolean member per confidential guest support class
(eg, tdx or sev-snp) is a... | null | null | null | [PATCH v6 02/35] accel/kvm: add confidential class member to indicate
guest rebuild capability | Various subsystems might need to take some steps before the KVM file descriptor
for a virtual machine is changed. So a new boolean attribute is added to the
vmfd_notifier structure which is passed to the notifier callbacks.
vmfd_notifer.pre is true for pre-notification of vmfd change and false for
post notification. No... | {
"author": "Ani Sinha <anisinha@redhat.com>",
"date": "Wed, 25 Feb 2026 09:19:13 +0530",
"is_openbsd": false,
"thread_id": "1D3E88B6-D89D-4067-B014-11DDF68C4B8A@redhat.com.mbox.gz"
} |
lkml_critique | qemu-devel | As a part of the confidential guest reset process, the existing encrypted guest
state must be made mutable since it would be discarded after reset. A new
encrypted and locked guest state must be established after the reset. To this
end, a new boolean member per confidential guest support class
(eg, tdx or sev-snp) is a... | null | null | null | [PATCH v6 02/35] accel/kvm: add confidential class member to indicate
guest rebuild capability | kvm_filter_msr() does not check if an msr entry is already present in the
msr_handlers table and installs a new handler unconditionally. If the function
is called again with the same MSR, it will result in duplicate entries in the
table and multiple such calls will fill up the table needlessly. Fix that.
Signed-off-by... | {
"author": "Ani Sinha <anisinha@redhat.com>",
"date": "Wed, 25 Feb 2026 09:19:06 +0530",
"is_openbsd": false,
"thread_id": "1D3E88B6-D89D-4067-B014-11DDF68C4B8A@redhat.com.mbox.gz"
} |
lkml_critique | qemu-devel | As a part of the confidential guest reset process, the existing encrypted guest
state must be made mutable since it would be discarded after reset. A new
encrypted and locked guest state must be established after the reset. To this
end, a new boolean member per confidential guest support class
(eg, tdx or sev-snp) is a... | null | null | null | [PATCH v6 02/35] accel/kvm: add confidential class member to indicate
guest rebuild capability | When the kvm file descriptor changes as a part of confidential guest reset,
some architecture specific setups including SEV/SEV-SNP/TDX specific setups
needs to be redone. These changes are implemented as a part of the
kvm_arch_on_vmfd_change() callback which was introduced previously.
Signed-off-by: Ani Sinha <anisin... | {
"author": "Ani Sinha <anisinha@redhat.com>",
"date": "Wed, 25 Feb 2026 09:19:15 +0530",
"is_openbsd": false,
"thread_id": "1D3E88B6-D89D-4067-B014-11DDF68C4B8A@redhat.com.mbox.gz"
} |
lkml_critique | qemu-devel | As a part of the confidential guest reset process, the existing encrypted guest
state must be made mutable since it would be discarded after reset. A new
encrypted and locked guest state must be established after the reset. To this
end, a new boolean member per confidential guest support class
(eg, tdx or sev-snp) is a... | null | null | null | [PATCH v6 02/35] accel/kvm: add confidential class member to indicate
guest rebuild capability | After the guest KVM file descriptor has changed as a part of the process of
confidential guest reset mechanism, existing memory needs to be reattached to
the new file descriptor. This change adds a helper function ram_block_rebind()
for this purpose. The next patch will make use of this function.
Signed-off-by: Ani Si... | {
"author": "Ani Sinha <anisinha@redhat.com>",
"date": "Wed, 25 Feb 2026 09:19:09 +0530",
"is_openbsd": false,
"thread_id": "1D3E88B6-D89D-4067-B014-11DDF68C4B8A@redhat.com.mbox.gz"
} |
lkml_critique | qemu-devel | As a part of the confidential guest reset process, the existing encrypted guest
state must be made mutable since it would be discarded after reset. A new
encrypted and locked guest state must be established after the reset. To this
end, a new boolean member per confidential guest support class
(eg, tdx or sev-snp) is a... | null | null | null | [PATCH v6 02/35] accel/kvm: add confidential class member to indicate
guest rebuild capability | When IGVM is not being used by the confidential guest, the guest firmware has
to be reloaded explicitly again into memory. This is because, the memory into
which the firmware was loaded before reset was encrypted and is thus lost
upon reset. When IGVM is used, it is expected that the IGVM will contain the
guest firmwar... | {
"author": "Ani Sinha <anisinha@redhat.com>",
"date": "Wed, 25 Feb 2026 09:19:19 +0530",
"is_openbsd": false,
"thread_id": "1D3E88B6-D89D-4067-B014-11DDF68C4B8A@redhat.com.mbox.gz"
} |
lkml_critique | qemu-devel | As a part of the confidential guest reset process, the existing encrypted guest
state must be made mutable since it would be discarded after reset. A new
encrypted and locked guest state must be established after the reset. To this
end, a new boolean member per confidential guest support class
(eg, tdx or sev-snp) is a... | null | null | null | [PATCH v6 02/35] accel/kvm: add confidential class member to indicate
guest rebuild capability | When the KVM VM file descriptor has changed and a new one created, the guest
state is no longer in protected state. Mark it as such.
The guest state becomes protected again when TDX and SEV-ES and SEV-SNP mark
it as such.
Signed-off-by: Ani Sinha <anisinha@redhat.com>
---
accel/kvm/kvm-all.c | 3 +++
1 file changed, ... | {
"author": "Ani Sinha <anisinha@redhat.com>",
"date": "Wed, 25 Feb 2026 09:19:11 +0530",
"is_openbsd": false,
"thread_id": "1D3E88B6-D89D-4067-B014-11DDF68C4B8A@redhat.com.mbox.gz"
} |
lkml_critique | qemu-devel | As a part of the confidential guest reset process, the existing encrypted guest
state must be made mutable since it would be discarded after reset. A new
encrypted and locked guest state must be established after the reset. To this
end, a new boolean member per confidential guest support class
(eg, tdx or sev-snp) is a... | null | null | null | [PATCH v6 02/35] accel/kvm: add confidential class member to indicate
guest rebuild capability | During reset, when the VM file descriptor is changed, the TDX state needs to be
re-initialized. A notifier callback is implemented to reset the old
state and free memory before the new state is initialized post VM file
descriptor change.
Signed-off-by: Ani Sinha <anisinha@redhat.com>
---
target/i386/kvm/tdx.c | 31 ++... | {
"author": "Ani Sinha <anisinha@redhat.com>",
"date": "Wed, 25 Feb 2026 09:19:23 +0530",
"is_openbsd": false,
"thread_id": "1D3E88B6-D89D-4067-B014-11DDF68C4B8A@redhat.com.mbox.gz"
} |
lkml_critique | qemu-devel | As a part of the confidential guest reset process, the existing encrypted guest
state must be made mutable since it would be discarded after reset. A new
encrypted and locked guest state must be established after the reset. To this
end, a new boolean member per confidential guest support class
(eg, tdx or sev-snp) is a... | null | null | null | [PATCH v6 02/35] accel/kvm: add confidential class member to indicate
guest rebuild capability | When the confidential virtual machine KVM file descriptor changes due to the
guest reset, some TDX specific setup steps needs to be done again. This
includes finalizing the initial guest launch state again. This change
re-executes some parts of the TDX setup during the device reset phaze using a
resettable interface. T... | {
"author": "Ani Sinha <anisinha@redhat.com>",
"date": "Wed, 25 Feb 2026 09:19:22 +0530",
"is_openbsd": false,
"thread_id": "1D3E88B6-D89D-4067-B014-11DDF68C4B8A@redhat.com.mbox.gz"
} |
lkml_critique | qemu-devel | As a part of the confidential guest reset process, the existing encrypted guest
state must be made mutable since it would be discarded after reset. A new
encrypted and locked guest state must be established after the reset. To this
end, a new boolean member per confidential guest support class
(eg, tdx or sev-snp) is a... | null | null | null | [PATCH v6 02/35] accel/kvm: add confidential class member to indicate
guest rebuild capability | sev_launch_finish() and sev_snp_launch_finish() could be called multiple times
when the confidential guest is being reset/rebooted. The migration
blockers should not be added multiple times, once per invocation. This change
makes sure that the migration blockers are added only one time by adding the
migration blockers ... | {
"author": "Ani Sinha <anisinha@redhat.com>",
"date": "Wed, 25 Feb 2026 09:19:24 +0530",
"is_openbsd": false,
"thread_id": "1D3E88B6-D89D-4067-B014-11DDF68C4B8A@redhat.com.mbox.gz"
} |
lkml_critique | qemu-devel | As a part of the confidential guest reset process, the existing encrypted guest
state must be made mutable since it would be discarded after reset. A new
encrypted and locked guest state must be established after the reset. To this
end, a new boolean member per confidential guest support class
(eg, tdx or sev-snp) is a... | null | null | null | [PATCH v6 02/35] accel/kvm: add confidential class member to indicate
guest rebuild capability | For confidential guests, bios image must be reinitialized upon reset. This
is because bios memory is encrypted and hence once the old confidential
kvm context is destroyed, it cannot be decrypted. It needs to be reinitilized.
Towards that, this change refactors x86_bios_rom_init() code so that
parts of it can be called... | {
"author": "Ani Sinha <anisinha@redhat.com>",
"date": "Wed, 25 Feb 2026 09:19:17 +0530",
"is_openbsd": false,
"thread_id": "1D3E88B6-D89D-4067-B014-11DDF68C4B8A@redhat.com.mbox.gz"
} |
lkml_critique | qemu-devel | As a part of the confidential guest reset process, the existing encrypted guest
state must be made mutable since it would be discarded after reset. A new
encrypted and locked guest state must be established after the reset. To this
end, a new boolean member per confidential guest support class
(eg, tdx or sev-snp) is a... | null | null | null | [PATCH v6 02/35] accel/kvm: add confidential class member to indicate
guest rebuild capability | A new helper function is introduced that refactors all firmware memory
initialization code into a separate function. No functional change.
Signed-off-by: Ani Sinha <anisinha@redhat.com>
---
target/i386/kvm/tdx.c | 73 ++++++++++++++++++++++++-------------------
1 file changed, 40 insertions(+), 33 deletions(-)
diff ... | {
"author": "Ani Sinha <anisinha@redhat.com>",
"date": "Wed, 25 Feb 2026 09:19:21 +0530",
"is_openbsd": false,
"thread_id": "1D3E88B6-D89D-4067-B014-11DDF68C4B8A@redhat.com.mbox.gz"
} |
lkml_critique | qemu-devel | As a part of the confidential guest reset process, the existing encrypted guest
state must be made mutable since it would be discarded after reset. A new
encrypted and locked guest state must be established after the reset. To this
end, a new boolean member per confidential guest support class
(eg, tdx or sev-snp) is a... | null | null | null | [PATCH v6 02/35] accel/kvm: add confidential class member to indicate
guest rebuild capability | The various notifiers that are used needs to be installed only once not on
every initialization. This includes the vm state change notifier and others.
This change uses 'cgs->ready' flag to install the notifiers only one time,
the first time.
Signed-off-by: Ani Sinha <anisinha@redhat.com>
---
target/i386/sev.c | 36 +... | {
"author": "Ani Sinha <anisinha@redhat.com>",
"date": "Wed, 25 Feb 2026 09:19:25 +0530",
"is_openbsd": false,
"thread_id": "1D3E88B6-D89D-4067-B014-11DDF68C4B8A@redhat.com.mbox.gz"
} |
lkml_critique | qemu-devel | As a part of the confidential guest reset process, the existing encrypted guest
state must be made mutable since it would be discarded after reset. A new
encrypted and locked guest state must be established after the reset. To this
end, a new boolean member per confidential guest support class
(eg, tdx or sev-snp) is a... | null | null | null | [PATCH v6 02/35] accel/kvm: add confidential class member to indicate
guest rebuild capability | On confidential guests when the KVM virtual machine file descriptor changes as
a part of the reset process, event file descriptors needs to be reassociated
with the new KVM VM file descriptor. This is achieved with the help of a
callback handler that gets called when KVM VM file descriptor changes during
the confidenti... | {
"author": "Ani Sinha <anisinha@redhat.com>",
"date": "Wed, 25 Feb 2026 09:19:32 +0530",
"is_openbsd": false,
"thread_id": "1D3E88B6-D89D-4067-B014-11DDF68C4B8A@redhat.com.mbox.gz"
} |
lkml_critique | qemu-devel | As a part of the confidential guest reset process, the existing encrypted guest
state must be made mutable since it would be discarded after reset. A new
encrypted and locked guest state must be established after the reset. To this
end, a new boolean member per confidential guest support class
(eg, tdx or sev-snp) is a... | null | null | null | [PATCH v6 02/35] accel/kvm: add confidential class member to indicate
guest rebuild capability | We need to make sure that synic CPU feature is not already enabled. If it is,
trying to enable it again will result in the following assertion:
Unexpected error in object_property_try_add() at ../qom/object.c:1268:
qemu-system-x86_64: attempt to add duplicate property 'synic' to object (type 'host-x86_64-cpu')
So ena... | {
"author": "Ani Sinha <anisinha@redhat.com>",
"date": "Wed, 25 Feb 2026 09:19:31 +0530",
"is_openbsd": false,
"thread_id": "1D3E88B6-D89D-4067-B014-11DDF68C4B8A@redhat.com.mbox.gz"
} |
lkml_critique | qemu-devel | As a part of the confidential guest reset process, the existing encrypted guest
state must be made mutable since it would be discarded after reset. A new
encrypted and locked guest state must be established after the reset. To this
end, a new boolean member per confidential guest support class
(eg, tdx or sev-snp) is a... | null | null | null | [PATCH v6 02/35] accel/kvm: add confidential class member to indicate
guest rebuild capability | Cosmetic - no new functionality added. Xen initialisation code is refactored
into its own function.
Signed-off-by: Ani Sinha <anisinha@redhat.com>
---
target/i386/kvm/kvm.c | 31 +++++++++++++++++++------------
1 file changed, 19 insertions(+), 12 deletions(-)
diff --git a/target/i386/kvm/kvm.c b/target/i386/kvm/kvm... | {
"author": "Ani Sinha <anisinha@redhat.com>",
"date": "Wed, 25 Feb 2026 09:19:16 +0530",
"is_openbsd": false,
"thread_id": "1D3E88B6-D89D-4067-B014-11DDF68C4B8A@redhat.com.mbox.gz"
} |
lkml_critique | qemu-devel | As a part of the confidential guest reset process, the existing encrypted guest
state must be made mutable since it would be discarded after reset. A new
encrypted and locked guest state must be established after the reset. To this
end, a new boolean member per confidential guest support class
(eg, tdx or sev-snp) is a... | null | null | null | [PATCH v6 02/35] accel/kvm: add confidential class member to indicate
guest rebuild capability | Normally the vfio pseudo device file descriptor lives for the life of the VM.
However, when the kvm VM file descriptor changes, a new file descriptor
for the pseudo device needs to be generated against the new kvm VM descriptor.
Other existing vfio descriptors needs to be reattached to the new pseudo device
descriptor.... | {
"author": "Ani Sinha <anisinha@redhat.com>",
"date": "Wed, 25 Feb 2026 09:19:28 +0530",
"is_openbsd": false,
"thread_id": "1D3E88B6-D89D-4067-B014-11DDF68C4B8A@redhat.com.mbox.gz"
} |
lkml_critique | qemu-devel | As a part of the confidential guest reset process, the existing encrypted guest
state must be made mutable since it would be discarded after reset. A new
encrypted and locked guest state must be established after the reset. To this
end, a new boolean member per confidential guest support class
(eg, tdx or sev-snp) is a... | null | null | null | [PATCH v6 02/35] accel/kvm: add confidential class member to indicate
guest rebuild capability | When the KVM VM file descriptor changes as a part of the confidential guest
reset mechanism, it necessary to create a new confidential guest context and
re-encrypt the VM memory. This happens for SEV-ES and SEV-SNP virtual machines
as a part of SEV_LAUNCH_FINISH, SEV_SNP_LAUNCH_FINISH operations.
A new resettable inte... | {
"author": "Ani Sinha <anisinha@redhat.com>",
"date": "Wed, 25 Feb 2026 09:19:27 +0530",
"is_openbsd": false,
"thread_id": "1D3E88B6-D89D-4067-B014-11DDF68C4B8A@redhat.com.mbox.gz"
} |
lkml_critique | qemu-devel | As a part of the confidential guest reset process, the existing encrypted guest
state must be made mutable since it would be discarded after reset. A new
encrypted and locked guest state must be established after the reset. To this
end, a new boolean member per confidential guest support class
(eg, tdx or sev-snp) is a... | null | null | null | [PATCH v6 02/35] accel/kvm: add confidential class member to indicate
guest rebuild capability | When new vcpu file descriptors are created and bound to the new kvm file
descriptor as a part of the confidential guest reset mechanism, various
subsystems needs to know about it. This change adds notifiers so that various
subsystems can take appropriate actions when vcpu fds change by registering
their handlers to thi... | {
"author": "Ani Sinha <anisinha@redhat.com>",
"date": "Wed, 25 Feb 2026 09:19:35 +0530",
"is_openbsd": false,
"thread_id": "1D3E88B6-D89D-4067-B014-11DDF68C4B8A@redhat.com.mbox.gz"
} |
lkml_critique | qemu-devel | As a part of the confidential guest reset process, the existing encrypted guest
state must be made mutable since it would be discarded after reset. A new
encrypted and locked guest state must be established after the reset. To this
end, a new boolean member per confidential guest support class
(eg, tdx or sev-snp) is a... | null | null | null | [PATCH v6 02/35] accel/kvm: add confidential class member to indicate
guest rebuild capability | This change introduces support for confidential guests
(SEV-ES, SEV-SNP and TDX) to reset/reboot just like other non-confidential
guests. Currently, a reboot intiated from the confidential guest results
in termination of the QEMU hypervisor as the CPUs are not resettable. As the
initial state of the guest including pri... | {
"author": "Ani Sinha <anisinha@redhat.com>",
"date": "Wed, 25 Feb 2026 09:19:05 +0530",
"is_openbsd": false,
"thread_id": "1D3E88B6-D89D-4067-B014-11DDF68C4B8A@redhat.com.mbox.gz"
} |
lkml_critique | qemu-devel | As a part of the confidential guest reset process, the existing encrypted guest
state must be made mutable since it would be discarded after reset. A new
encrypted and locked guest state must be established after the reset. To this
end, a new boolean member per confidential guest support class
(eg, tdx or sev-snp) is a... | null | null | null | [PATCH v6 02/35] accel/kvm: add confidential class member to indicate
guest rebuild capability | Confidential guests needs to generate a new KVM file descriptor upon virtual
machine reset. Existing VCPUs needs to be reattached to this new
KVM VM file descriptor. As a part of this, new VCPU file descriptors against
this new KVM VM file descriptor needs to be created and re-initialized.
Resources allocated against t... | {
"author": "Ani Sinha <anisinha@redhat.com>",
"date": "Wed, 25 Feb 2026 09:19:20 +0530",
"is_openbsd": false,
"thread_id": "1D3E88B6-D89D-4067-B014-11DDF68C4B8A@redhat.com.mbox.gz"
} |
lkml_critique | qemu-devel | As a part of the confidential guest reset process, the existing encrypted guest
state must be made mutable since it would be discarded after reset. A new
encrypted and locked guest state must be established after the reset. To this
end, a new boolean member per confidential guest support class
(eg, tdx or sev-snp) is a... | null | null | null | [PATCH v6 02/35] accel/kvm: add confidential class member to indicate
guest rebuild capability | This change adds common kvm specific support to handle KVM VM file descriptor
change. KVM VM file descriptor can change as a part of confidential guest reset
mechanism. A new function api kvm_arch_on_vmfd_change() per
architecture platform is added in order to implement architecture specific
changes required to support... | {
"author": "Ani Sinha <anisinha@redhat.com>",
"date": "Wed, 25 Feb 2026 09:19:10 +0530",
"is_openbsd": false,
"thread_id": "1D3E88B6-D89D-4067-B014-11DDF68C4B8A@redhat.com.mbox.gz"
} |
lkml_critique | qemu-devel | As a part of the confidential guest reset process, the existing encrypted guest
state must be made mutable since it would be discarded after reset. A new
encrypted and locked guest state must be established after the reset. To this
end, a new boolean member per confidential guest support class
(eg, tdx or sev-snp) is a... | null | null | null | [PATCH v6 02/35] accel/kvm: add confidential class member to indicate
guest rebuild capability | Confidential guest smust reload their bios rom upon reset. This is because
bios memory is encrypted and upon reset, the contents of the old bios memory
is lost and cannot be re-used. To this end, export a new x86 function
x86_bios_rom_reload() to reload the bios again. This function will be used in
the subsequent patch... | {
"author": "Ani Sinha <anisinha@redhat.com>",
"date": "Wed, 25 Feb 2026 09:19:18 +0530",
"is_openbsd": false,
"thread_id": "1D3E88B6-D89D-4067-B014-11DDF68C4B8A@redhat.com.mbox.gz"
} |
lkml_critique | qemu-devel | As a part of the confidential guest reset process, the existing encrypted guest
state must be made mutable since it would be discarded after reset. A new
encrypted and locked guest state must be established after the reset. To this
end, a new boolean member per confidential guest support class
(eg, tdx or sev-snp) is a... | null | null | null | [PATCH v6 02/35] accel/kvm: add confidential class member to indicate
guest rebuild capability | A new functional test is added that exercises the code changes related to
closing of the old KVM VM file descriptor and opening a new one upon VM reset.
This normally happens when confidential guests are reset but for
non-confidential guests, we use a special machine specific debug/test parameter
'x-change-vmfd-on-rese... | {
"author": "Ani Sinha <anisinha@redhat.com>",
"date": "Wed, 25 Feb 2026 09:19:38 +0530",
"is_openbsd": false,
"thread_id": "1D3E88B6-D89D-4067-B014-11DDF68C4B8A@redhat.com.mbox.gz"
} |
lkml_critique | qemu-devel | As a part of the confidential guest reset process, the existing encrypted guest
state must be made mutable since it would be discarded after reset. A new
encrypted and locked guest state must be established after the reset. To this
end, a new boolean member per confidential guest support class
(eg, tdx or sev-snp) is a... | null | null | null | [PATCH v6 02/35] accel/kvm: add confidential class member to indicate
guest rebuild capability | For confidential guests during the reset process, the old KVM VM file
descriptor is closed and a new one is created. When a new file descriptor is
created, a new openpic device needs to be created against this new KVM VM file
descriptor as well. Additionally, existing memory region needs to be reattached
to this new op... | {
"author": "Ani Sinha <anisinha@redhat.com>",
"date": "Wed, 25 Feb 2026 09:19:34 +0530",
"is_openbsd": false,
"thread_id": "1D3E88B6-D89D-4067-B014-11DDF68C4B8A@redhat.com.mbox.gz"
} |
lkml_critique | qemu-devel | As a part of the confidential guest reset process, the existing encrypted guest
state must be made mutable since it would be discarded after reset. A new
encrypted and locked guest state must be established after the reset. To this
end, a new boolean member per confidential guest support class
(eg, tdx or sev-snp) is a... | null | null | null | [PATCH v6 02/35] accel/kvm: add confidential class member to indicate
guest rebuild capability | Through the new 'confidential-guest-reset' property, control plane should be
able to detect if the hypervisor supports x86 confidential guest resets. Older
hypervisors that do not support resets will not have this property populated.
Suggested-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Markus Armbruster... | {
"author": "Ani Sinha <anisinha@redhat.com>",
"date": "Wed, 25 Feb 2026 09:19:39 +0530",
"is_openbsd": false,
"thread_id": "1D3E88B6-D89D-4067-B014-11DDF68C4B8A@redhat.com.mbox.gz"
} |
lkml_critique | qemu-devel | As a part of the confidential guest reset process, the existing encrypted guest
state must be made mutable since it would be discarded after reset. A new
encrypted and locked guest state must be established after the reset. To this
end, a new boolean member per confidential guest support class
(eg, tdx or sev-snp) is a... | null | null | null | [PATCH v6 02/35] accel/kvm: add confidential class member to indicate
guest rebuild capability | We will re-register smram listeners after the VM file descriptors has changed.
We need to unregister them first to make sure addresses and reference counters
work properly.
Signed-off-by: Ani Sinha <anisinha@redhat.com>
---
target/i386/kvm/kvm.c | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
diff --git a/t... | {
"author": "Ani Sinha <anisinha@redhat.com>",
"date": "Wed, 25 Feb 2026 09:19:14 +0530",
"is_openbsd": false,
"thread_id": "1D3E88B6-D89D-4067-B014-11DDF68C4B8A@redhat.com.mbox.gz"
} |
lkml_critique | qemu-devel | As a part of the confidential guest reset process, the existing encrypted guest
state must be made mutable since it would be discarded after reset. A new
encrypted and locked guest state must be established after the reset. To this
end, a new boolean member per confidential guest support class
(eg, tdx or sev-snp) is a... | null | null | null | [PATCH v6 02/35] accel/kvm: add confidential class member to indicate
guest rebuild capability | A new machine specific option 'x-change-vmfd-on-reset' is introduced for
debugging and testing only (hence the 'x-' prefix). This option when enabled
will force KVM VM file descriptor to be changed upon guest reset like
in the case of confidential guests. This can be used to exercise the code
changes that are specific ... | {
"author": "Ani Sinha <anisinha@redhat.com>",
"date": "Wed, 25 Feb 2026 09:19:37 +0530",
"is_openbsd": false,
"thread_id": "1D3E88B6-D89D-4067-B014-11DDF68C4B8A@redhat.com.mbox.gz"
} |
lkml_critique | qemu-devel | As a part of the confidential guest reset process, the existing encrypted guest
state must be made mutable since it would be discarded after reset. A new
encrypted and locked guest state must be established after the reset. To this
end, a new boolean member per confidential guest support class
(eg, tdx or sev-snp) is a... | null | null | null | [PATCH v6 02/35] accel/kvm: add confidential class member to indicate
guest rebuild capability | A confidential guest reset involves closing the old virtual machine KVM file
descriptor and opening a new one. Since its a new KVM fd, PIT needs to be
re-initialized again. This is done with the help of a notifier which is invoked
upon KVM vm file descriptor change during the confidential guest reset process.
Signed-o... | {
"author": "Ani Sinha <anisinha@redhat.com>",
"date": "Wed, 25 Feb 2026 09:19:30 +0530",
"is_openbsd": false,
"thread_id": "1D3E88B6-D89D-4067-B014-11DDF68C4B8A@redhat.com.mbox.gz"
} |
lkml_critique | qemu-devel | As a part of the confidential guest reset process, the existing encrypted guest
state must be made mutable since it would be discarded after reset. A new
encrypted and locked guest state must be established after the reset. To this
end, a new boolean member per confidential guest support class
(eg, tdx or sev-snp) is a... | null | null | null | [PATCH v6 02/35] accel/kvm: add confidential class member to indicate
guest rebuild capability | If there is existing launch update data and kernel hashes data, they need to be
freed when initialization code is executed. This is important for resettable
confidential guests where the initialization happens once every reset.
Signed-off-by: Ani Sinha <anisinha@redhat.com>
---
target/i386/sev.c | 12 ++++++++++++
1 ... | {
"author": "Ani Sinha <anisinha@redhat.com>",
"date": "Wed, 25 Feb 2026 09:19:26 +0530",
"is_openbsd": false,
"thread_id": "1D3E88B6-D89D-4067-B014-11DDF68C4B8A@redhat.com.mbox.gz"
} |
lkml_critique | qemu-devel | As a part of the confidential guest reset process, the existing encrypted guest
state must be made mutable since it would be discarded after reset. A new
encrypted and locked guest state must be established after the reset. To this
end, a new boolean member per confidential guest support class
(eg, tdx or sev-snp) is a... | null | null | null | [PATCH v6 02/35] accel/kvm: add confidential class member to indicate
guest rebuild capability | On confidential guests KVM virtual machine file descriptor changes as a
part of the guest reset process. Xen capabilities needs to be re-initialized in
KVM against the new file descriptor.
Signed-off-by: Ani Sinha <anisinha@redhat.com>
---
target/i386/kvm/xen-emu.c | 38 +++++++++++++++++++++++++++++++++++++-
1 file ... | {
"author": "Ani Sinha <anisinha@redhat.com>",
"date": "Wed, 25 Feb 2026 09:19:33 +0530",
"is_openbsd": false,
"thread_id": "1D3E88B6-D89D-4067-B014-11DDF68C4B8A@redhat.com.mbox.gz"
} |
lkml_critique | qemu-devel | As a part of the confidential guest reset process, the existing encrypted guest
state must be made mutable since it would be discarded after reset. A new
encrypted and locked guest state must be established after the reset. To this
end, a new boolean member per confidential guest support class
(eg, tdx or sev-snp) is a... | null | null | null | [PATCH v6 02/35] accel/kvm: add confidential class member to indicate
guest rebuild capability | The initialization code will be used again by VM file descriptor change
notifier callback in a subsequent change. So refactor common code into a new
helper function.
Signed-off-by: Ani Sinha <anisinha@redhat.com>
---
hw/i386/kvm/i8254.c | 68 +++++++++++++++++++++++++--------------------
1 file changed, 38 insertions... | {
"author": "Ani Sinha <anisinha@redhat.com>",
"date": "Wed, 25 Feb 2026 09:19:29 +0530",
"is_openbsd": false,
"thread_id": "1D3E88B6-D89D-4067-B014-11DDF68C4B8A@redhat.com.mbox.gz"
} |
lkml_critique | qemu-devel | As a part of the confidential guest reset process, the existing encrypted guest
state must be made mutable since it would be discarded after reset. A new
encrypted and locked guest state must be established after the reset. To this
end, a new boolean member per confidential guest support class
(eg, tdx or sev-snp) is a... | null | null | null | [PATCH v6 02/35] accel/kvm: add confidential class member to indicate
guest rebuild capability | A notifier callback can be used by various subsystems to perform actions when
KVM file descriptor for a virtual machine changes as a part of confidential
guest reset process. This change adds this notifier mechanism. Subsequent
patches will add specific implementations for various notifier callbacks
corresponding to va... | {
"author": "Ani Sinha <anisinha@redhat.com>",
"date": "Wed, 25 Feb 2026 09:19:12 +0530",
"is_openbsd": false,
"thread_id": "1D3E88B6-D89D-4067-B014-11DDF68C4B8A@redhat.com.mbox.gz"
} |
lkml_critique | qemu-devel | As a part of the confidential guest reset process, the existing encrypted guest
state must be made mutable since it would be discarded after reset. A new
encrypted and locked guest state must be established after the reset. To this
end, a new boolean member per confidential guest support class
(eg, tdx or sev-snp) is a... | null | null | null | [PATCH v6 02/35] accel/kvm: add confidential class member to indicate
guest rebuild capability | When a confidential virtual machine is reset, a new guest context in the
accelerator must be generated post reset. Therefore, the old accelerator guest
file handle must be closed and a new one created. To this end, a per-accelerator
callback, "rebuild_guest" is introduced that would get called when a confidential
guest... | {
"author": "Ani Sinha <anisinha@redhat.com>",
"date": "Wed, 25 Feb 2026 09:19:08 +0530",
"is_openbsd": false,
"thread_id": "1D3E88B6-D89D-4067-B014-11DDF68C4B8A@redhat.com.mbox.gz"
} |
lkml_critique | qemu-devel | As a part of the confidential guest reset process, the existing encrypted guest
state must be made mutable since it would be discarded after reset. A new
encrypted and locked guest state must be established after the reset. To this
end, a new boolean member per confidential guest support class
(eg, tdx or sev-snp) is a... | null | null | null | [PATCH v6 02/35] accel/kvm: add confidential class member to indicate
guest rebuild capability | Currently the code that adds a migration blocker does not check if the same
blocker already exists. Return an EEXIST error code if there is an attempt to
add the same migration blocker again. This way the same migration blocker will
not get added twice.
Suggested-by: Prasad Pandit <pjp@fedoraproject.org>
Signed-off-by... | {
"author": "Ani Sinha <anisinha@redhat.com>",
"date": "Wed, 25 Feb 2026 09:19:40 +0530",
"is_openbsd": false,
"thread_id": "1D3E88B6-D89D-4067-B014-11DDF68C4B8A@redhat.com.mbox.gz"
} |
lkml_critique | qemu-devel | As a part of the confidential guest reset process, the existing encrypted guest
state must be made mutable since it would be discarded after reset. A new
encrypted and locked guest state must be established after the reset. To this
end, a new boolean member per confidential guest support class
(eg, tdx or sev-snp) is a... | null | null | null | [PATCH v6 02/35] accel/kvm: add confidential class member to indicate
guest rebuild capability | Confidential guests change the KVM VM file descriptor upon reset and also create
new VCPU file descriptors against the new KVM VM file descriptor. We need to
save the clock state from kvm before KVM VM file descriptor changes and restore
it after. Also after VCPU file descriptors changed, we must call
KVM_KVMCLOCK_CTRL... | {
"author": "Ani Sinha <anisinha@redhat.com>",
"date": "Wed, 25 Feb 2026 09:19:36 +0530",
"is_openbsd": false,
"thread_id": "1D3E88B6-D89D-4067-B014-11DDF68C4B8A@redhat.com.mbox.gz"
} |
lkml_critique | qemu-devel | As a part of the confidential guest reset process, the existing encrypted guest
state must be made mutable since it would be discarded after reset. A new
encrypted and locked guest state must be established after the reset. To this
end, a new boolean member per confidential guest support class
(eg, tdx or sev-snp) is a... | null | null | null | [PATCH v6 02/35] accel/kvm: add confidential class member to indicate
guest rebuild capability | On Wed, 25 Feb 2026 at 09:23, Ani Sinha <anisinha@redhat.com> wrote:
* Looks okay.
Reviewed-by: Prasad Pandit <pjp@fedoraproject.org>
Thank you.
---
- Prasad | {
"author": "Prasad Pandit <ppandit@redhat.com>",
"date": "Wed, 25 Feb 2026 11:35:15 +0530",
"is_openbsd": false,
"thread_id": "1D3E88B6-D89D-4067-B014-11DDF68C4B8A@redhat.com.mbox.gz"
} |
lkml_critique | qemu-devel | As a part of the confidential guest reset process, the existing encrypted guest
state must be made mutable since it would be discarded after reset. A new
encrypted and locked guest state must be established after the reset. To this
end, a new boolean member per confidential guest support class
(eg, tdx or sev-snp) is a... | null | null | null | [PATCH v6 02/35] accel/kvm: add confidential class member to indicate
guest rebuild capability | On Wed, Feb 25, 2026 at 11:35:15AM +0530, Prasad Pandit wrote:
This method has an '**errp' parameter.....
.... so using -errno for return values is not appropriate - it must
set 'errp' and return -1.
With regards,
Daniel
--
|: https://berrange.com ~~ https://hachyderm.io/@berrange :|
|: https://lib... | {
"author": "Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= <berrange@redhat.com>",
"date": "Wed, 25 Feb 2026 09:07:28 +0000",
"is_openbsd": false,
"thread_id": "1D3E88B6-D89D-4067-B014-11DDF68C4B8A@redhat.com.mbox.gz"
} |
lkml_critique | qemu-devel | As a part of the confidential guest reset process, the existing encrypted guest
state must be made mutable since it would be discarded after reset. A new
encrypted and locked guest state must be established after the reset. To this
end, a new boolean member per confidential guest support class
(eg, tdx or sev-snp) is a... | null | null | null | [PATCH v6 02/35] accel/kvm: add confidential class member to indicate
guest rebuild capability | Daniel P. Berrangé <berrange@redhat.com> writes:
Yes, it must set @errp on failure. Returning -1 would be wrong,
because:
int migrate_add_blocker_modes(Error **reasonp, unsigned modes, Error **errp)
{
if (is_only_migratable(reasonp, modes, errp)) {
return -EACCES;
} else if (is_b... | {
"author": "Markus Armbruster <armbru@redhat.com>",
"date": "Wed, 25 Feb 2026 10:32:51 +0100",
"is_openbsd": false,
"thread_id": "1D3E88B6-D89D-4067-B014-11DDF68C4B8A@redhat.com.mbox.gz"
} |
lkml_critique | qemu-devel | As a part of the confidential guest reset process, the existing encrypted guest
state must be made mutable since it would be discarded after reset. A new
encrypted and locked guest state must be established after the reset. To this
end, a new boolean member per confidential guest support class
(eg, tdx or sev-snp) is a... | null | null | null | [PATCH v6 02/35] accel/kvm: add confidential class member to indicate
guest rebuild capability | I see functions migrate_add_blocker_modes() or migrate_add_blocker_internal() that do not do this. This is why I thought it was ok to just return -errno here. | {
"author": "Ani Sinha <anisinha@redhat.com>",
"date": "Wed, 25 Feb 2026 15:04:27 +0530",
"is_openbsd": false,
"thread_id": "1D3E88B6-D89D-4067-B014-11DDF68C4B8A@redhat.com.mbox.gz"
} |
lkml_critique | qemu-devel | As a part of the confidential guest reset process, the existing encrypted guest
state must be made mutable since it would be discarded after reset. A new
encrypted and locked guest state must be established after the reset. To this
end, a new boolean member per confidential guest support class
(eg, tdx or sev-snp) is a... | null | null | null | [PATCH v6 02/35] accel/kvm: add confidential class member to indicate
guest rebuild capability | On Wed, Feb 25, 2026 at 03:04:27PM +0530, Ani Sinha wrote:
Yes they all set 'errp', but indirectly:
if (is_only_migratable(reasonp, modes, errp)) {
return -EACCES;
} else if (is_busy(reasonp, errp)) {
return -EBUSY;
}
In this case 'is_busy' and 'is_only_migratable' will be setting 'errp'.... | {
"author": "Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= <berrange@redhat.com>",
"date": "Wed, 25 Feb 2026 09:41:04 +0000",
"is_openbsd": false,
"thread_id": "1D3E88B6-D89D-4067-B014-11DDF68C4B8A@redhat.com.mbox.gz"
} |
lkml_critique | qemu-devel | As a part of the confidential guest reset process, the existing encrypted guest
state must be made mutable since it would be discarded after reset. A new
encrypted and locked guest state must be established after the reset. To this
end, a new boolean member per confidential guest support class
(eg, tdx or sev-snp) is a... | null | null | null | [PATCH v6 02/35] accel/kvm: add confidential class member to indicate
guest rebuild capability | Ok so just
diff --git a/migration/migration.c b/migration/migration.c
index 1eb75fb7fb..dc75d2eeb6 100644
--- a/migration/migration.c
+++ b/migration/migration.c
@@ -1704,6 +1704,8 @@ static int add_blockers(Error **reasonp, unsigned modes, Error **errp)
if (modes & BIT(mode)) {
if (g_slist_index... | {
"author": "Ani Sinha <anisinha@redhat.com>",
"date": "Wed, 25 Feb 2026 15:15:08 +0530",
"is_openbsd": false,
"thread_id": "1D3E88B6-D89D-4067-B014-11DDF68C4B8A@redhat.com.mbox.gz"
} |
lkml_critique | qemu-devel | As a part of the confidential guest reset process, the existing encrypted guest
state must be made mutable since it would be discarded after reset. A new
encrypted and locked guest state must be established after the reset. To this
end, a new boolean member per confidential guest support class
(eg, tdx or sev-snp) is a... | null | null | null | [PATCH v6 02/35] accel/kvm: add confidential class member to indicate
guest rebuild capability | On Wed, Feb 25, 2026 at 10:32:51AM +0100, Markus Armbruster wrote:
AFAICT there is only 1 caller that cares
spapr_mce_req_event tries to block migration while handling machine
check exceptions, and if seeing EBUSY it will report a warning
message. I'm not convinced it should be checking for EBUSY at all.
If -only-m... | {
"author": "Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= <berrange@redhat.com>",
"date": "Wed, 25 Feb 2026 10:04:00 +0000",
"is_openbsd": false,
"thread_id": "1D3E88B6-D89D-4067-B014-11DDF68C4B8A@redhat.com.mbox.gz"
} |
lkml_critique | qemu-devel | As a part of the confidential guest reset process, the existing encrypted guest
state must be made mutable since it would be discarded after reset. A new
encrypted and locked guest state must be established after the reset. To this
end, a new boolean member per confidential guest support class
(eg, tdx or sev-snp) is a... | null | null | null | [PATCH v6 02/35] accel/kvm: add confidential class member to indicate
guest rebuild capability | Hi, Ani,
On Wed, Feb 25, 2026 at 09:19:40AM +0530, Ani Sinha wrote:
Could you help explain why it will inject two identical errors in the first
place, and why the caller cannot make sure it won't be injected twice?
Thanks,
--
Peter Xu | {
"author": "Peter Xu <peterx@redhat.com>",
"date": "Wed, 25 Feb 2026 12:29:58 -0500",
"is_openbsd": false,
"thread_id": "1D3E88B6-D89D-4067-B014-11DDF68C4B8A@redhat.com.mbox.gz"
} |
lkml_critique | qemu-devel | As a part of the confidential guest reset process, the existing encrypted guest
state must be made mutable since it would be discarded after reset. A new
encrypted and locked guest state must be established after the reset. To this
end, a new boolean member per confidential guest support class
(eg, tdx or sev-snp) is a... | null | null | null | [PATCH v6 02/35] accel/kvm: add confidential class member to indicate
guest rebuild capability | Likely due to a bug in the code. For example if the init function that adds the blocker is called again and the caller does not handle the second init call properly.
This came up as a part of the coco reset work where migration blockers are added in init methods. They need not be added again when init methods are again... | {
"author": "Ani Sinha <anisinha@redhat.com>",
"date": "Thu, 26 Feb 2026 09:16:43 +0530",
"is_openbsd": false,
"thread_id": "1D3E88B6-D89D-4067-B014-11DDF68C4B8A@redhat.com.mbox.gz"
} |
lkml_critique | qemu-devel | As a part of the confidential guest reset process, the existing encrypted guest
state must be made mutable since it would be discarded after reset. A new
encrypted and locked guest state must be established after the reset. To this
end, a new boolean member per confidential guest support class
(eg, tdx or sev-snp) is a... | null | null | null | [PATCH v6 02/35] accel/kvm: add confidential class member to indicate
guest rebuild capability | On Thu, Feb 26, 2026 at 09:16:43AM +0530, Ani Sinha wrote:
IMHO if we want to make it more robust, we shouldn't return an error
because the caller may not always check for errors.
Would assertion suites more here? Because migration blockers are not
something the user can manipulate, so it's a solid bug to fix when
t... | {
"author": "Peter Xu <peterx@redhat.com>",
"date": "Thu, 26 Feb 2026 08:08:21 -0500",
"is_openbsd": false,
"thread_id": "1D3E88B6-D89D-4067-B014-11DDF68C4B8A@redhat.com.mbox.gz"
} |
lkml_critique | qemu-devel | As a part of the confidential guest reset process, the existing encrypted guest
state must be made mutable since it would be discarded after reset. A new
encrypted and locked guest state must be established after the reset. To this
end, a new boolean member per confidential guest support class
(eg, tdx or sev-snp) is a... | null | null | null | [PATCH v6 02/35] accel/kvm: add confidential class member to indicate
guest rebuild capability | On 2/26/26 04:46, Ani Sinha wrote:
Since this is the last patch, is it okay to remove it at least for now?
Can the situation actually happen?
If not and it's a programming error, even an abort() is okay.
Paolo | {
"author": "Paolo Bonzini <pbonzini@redhat.com>",
"date": "Thu, 26 Feb 2026 18:23:38 +0100",
"is_openbsd": false,
"thread_id": "1D3E88B6-D89D-4067-B014-11DDF68C4B8A@redhat.com.mbox.gz"
} |
lkml_critique | qemu-devel | As a part of the confidential guest reset process, the existing encrypted guest
state must be made mutable since it would be discarded after reset. A new
encrypted and locked guest state must be established after the reset. To this
end, a new boolean member per confidential guest support class
(eg, tdx or sev-snp) is a... | null | null | null | [PATCH v6 02/35] accel/kvm: add confidential class member to indicate
guest rebuild capability | Yes you can drop this patch for now. When we get consensus if/what needs to be done, I can send another fix. | {
"author": "Ani Sinha <anisinha@redhat.com>",
"date": "Fri, 27 Feb 2026 08:49:45 +0530",
"is_openbsd": false,
"thread_id": "1D3E88B6-D89D-4067-B014-11DDF68C4B8A@redhat.com.mbox.gz"
} |
lkml_critique | qemu-devel | As a part of the confidential guest reset process, the existing encrypted guest
state must be made mutable since it would be discarded after reset. A new
encrypted and locked guest state must be established after the reset. To this
end, a new boolean member per confidential guest support class
(eg, tdx or sev-snp) is a... | null | null | null | [PATCH v6 02/35] accel/kvm: add confidential class member to indicate
guest rebuild capability | On 2/25/26 04:49, Ani Sinha wrote:
In case you resend, may be change this part to return -errno at first
error. Seems best.
And return 0 here. Which means 'ret' is now unused.
Thanks,
C. | {
"author": "=?UTF-8?Q?C=C3=A9dric_Le_Goater?= <clg@redhat.com>",
"date": "Fri, 27 Feb 2026 08:02:36 +0100",
"is_openbsd": false,
"thread_id": "1D3E88B6-D89D-4067-B014-11DDF68C4B8A@redhat.com.mbox.gz"
} |
lkml_critique | qemu-devel | The following changes since commit afe653676dc6dfd49f0390239ff90b2f0052c2b8:
Merge tag 'audio-pull-request' of https://gitlab.com/marcandre.lureau/qemu into staging (2026-02-23 14:03:50 +0000)
are available in the Git repository at:
https://gitlab.com/jsnow/qemu.git tags/python-pull-request
for you to f... | null | null | null | [PULL v2 00/19] Python patches | Each group ensured by the mkvenv script will create an empty timestamp
file named {groupname}.group which can be used to conditionally trigger
dependency installation from various scripts and build machinery.
Reviewed-by: Thomas Huth <thuth@redhat.com>
Message-ID: <20260218213416.674483-3-jsnow@redhat.com>
Signed-off-... | {
"author": "John Snow <jsnow@redhat.com>",
"date": "Tue, 24 Feb 2026 13:14:20 -0500",
"is_openbsd": false,
"thread_id": "20260224181440.832943-1-jsnow@redhat.com.mbox.gz"
} |
lkml_critique | qemu-devel | The following changes since commit afe653676dc6dfd49f0390239ff90b2f0052c2b8:
Merge tag 'audio-pull-request' of https://gitlab.com/marcandre.lureau/qemu into staging (2026-02-23 14:03:50 +0000)
are available in the Git repository at:
https://gitlab.com/jsnow/qemu.git tags/python-pull-request
for you to f... | null | null | null | [PULL v2 00/19] Python patches | Currently, we "implicitly" install the local 'qemu' python package for
'make check-venv' with some logic inside tests/Makefile.include. I would
like to make this installation explicit in pythondeps.toml instead.
This patch adds a path constraint that can be used in lieu of version
constraints to specify that a package... | {
"author": "John Snow <jsnow@redhat.com>",
"date": "Tue, 24 Feb 2026 13:14:23 -0500",
"is_openbsd": false,
"thread_id": "20260224181440.832943-1-jsnow@redhat.com.mbox.gz"
} |
lkml_critique | qemu-devel | The following changes since commit afe653676dc6dfd49f0390239ff90b2f0052c2b8:
Merge tag 'audio-pull-request' of https://gitlab.com/marcandre.lureau/qemu into staging (2026-02-23 14:03:50 +0000)
are available in the Git repository at:
https://gitlab.com/jsnow/qemu.git tags/python-pull-request
for you to f... | null | null | null | [PULL v2 00/19] Python patches | Modify the iotests environment preparation so that it can detect when it
is being run outside of the configure-time virtual environment and give
a warning to the user, suggesting the use of the meson run script
instead.
As a bonus, since the test executor itself does not actually rely on
anything in the configure-time... | {
"author": "John Snow <jsnow@redhat.com>",
"date": "Tue, 24 Feb 2026 13:14:26 -0500",
"is_openbsd": false,
"thread_id": "20260224181440.832943-1-jsnow@redhat.com.mbox.gz"
} |
lkml_critique | qemu-devel | The following changes since commit afe653676dc6dfd49f0390239ff90b2f0052c2b8:
Merge tag 'audio-pull-request' of https://gitlab.com/marcandre.lureau/qemu into staging (2026-02-23 14:03:50 +0000)
are available in the Git repository at:
https://gitlab.com/jsnow/qemu.git tags/python-pull-request
for you to f... | null | null | null | [PULL v2 00/19] Python patches | 'tooling' contains depedencies required to run various tools (like
qmp-shell) as well as dependencies required to run "make check", and as
such, we promise that these dependencies can be sourced from the user's
distribution repository or from vendored packages so that "make check"
can be executed offline in an isolated... | {
"author": "John Snow <jsnow@redhat.com>",
"date": "Tue, 24 Feb 2026 13:14:22 -0500",
"is_openbsd": false,
"thread_id": "20260224181440.832943-1-jsnow@redhat.com.mbox.gz"
} |
lkml_critique | qemu-devel | The following changes since commit afe653676dc6dfd49f0390239ff90b2f0052c2b8:
Merge tag 'audio-pull-request' of https://gitlab.com/marcandre.lureau/qemu into staging (2026-02-23 14:03:50 +0000)
are available in the Git repository at:
https://gitlab.com/jsnow/qemu.git tags/python-pull-request
for you to f... | null | null | null | [PULL v2 00/19] Python patches | Alongside meson, always ensure our in-tree tooling group and its
out-of-tree dependency, qemu.qmp, is always installed.
As a result, several "check-venv" invocations can be removed from
various testing scripts.
Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Message-I... | {
"author": "John Snow <jsnow@redhat.com>",
"date": "Tue, 24 Feb 2026 13:14:33 -0500",
"is_openbsd": false,
"thread_id": "20260224181440.832943-1-jsnow@redhat.com.mbox.gz"
} |
lkml_critique | qemu-devel | The following changes since commit afe653676dc6dfd49f0390239ff90b2f0052c2b8:
Merge tag 'audio-pull-request' of https://gitlab.com/marcandre.lureau/qemu into staging (2026-02-23 14:03:50 +0000)
are available in the Git repository at:
https://gitlab.com/jsnow/qemu.git tags/python-pull-request
for you to f... | null | null | null | [PULL v2 00/19] Python patches | add the "pyvenv_functests_group" target to meson. This target will
invoke mkvenv.py to install the associated dependency group to the
build/pyvenv directory.
A "pyvenv_tooling_group" is not included here as it is the plan to
always install this group by default, so it will not need an on-demand
trigger.
Reviewed-by: ... | {
"author": "John Snow <jsnow@redhat.com>",
"date": "Tue, 24 Feb 2026 13:14:24 -0500",
"is_openbsd": false,
"thread_id": "20260224181440.832943-1-jsnow@redhat.com.mbox.gz"
} |
lkml_critique | qemu-devel | The following changes since commit afe653676dc6dfd49f0390239ff90b2f0052c2b8:
Merge tag 'audio-pull-request' of https://gitlab.com/marcandre.lureau/qemu into staging (2026-02-23 14:03:50 +0000)
are available in the Git repository at:
https://gitlab.com/jsnow/qemu.git tags/python-pull-request
for you to f... | null | null | null | [PULL v2 00/19] Python patches | Now that qmp has to be installed and isn't local, we can no longer offer
a simple forwarder for these scripts (nor path hacks) and hope that it
works. Encourage users to use the 'run' script to use these scripts
instead.
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Message-ID: <20260218213416.674483-18-jsnow@... | {
"author": "John Snow <jsnow@redhat.com>",
"date": "Tue, 24 Feb 2026 13:14:35 -0500",
"is_openbsd": false,
"thread_id": "20260224181440.832943-1-jsnow@redhat.com.mbox.gz"
} |
lkml_critique | qemu-devel | The following changes since commit afe653676dc6dfd49f0390239ff90b2f0052c2b8:
Merge tag 'audio-pull-request' of https://gitlab.com/marcandre.lureau/qemu into staging (2026-02-23 14:03:50 +0000)
are available in the Git repository at:
https://gitlab.com/jsnow/qemu.git tags/python-pull-request
for you to f... | null | null | null | [PULL v2 00/19] Python patches | Update to latest lcitool master and refresh tests. Fedora is upgraded to
Fedora 43 and Alpine from 3.21 to 3.23 as a result.
This is being done in this series primarily to ensure that MacOS
installs python-setuptools, which is now separate from the core python
package, and which is needed for this series to work corre... | {
"author": "John Snow <jsnow@redhat.com>",
"date": "Tue, 24 Feb 2026 13:14:28 -0500",
"is_openbsd": false,
"thread_id": "20260224181440.832943-1-jsnow@redhat.com.mbox.gz"
} |
lkml_critique | qemu-devel | The following changes since commit afe653676dc6dfd49f0390239ff90b2f0052c2b8:
Merge tag 'audio-pull-request' of https://gitlab.com/marcandre.lureau/qemu into staging (2026-02-23 14:03:50 +0000)
are available in the Git repository at:
https://gitlab.com/jsnow/qemu.git tags/python-pull-request
for you to f... | null | null | null | [PULL v2 00/19] Python patches | Note that only the thorough group requires the extra testing
dependencies; the quick group will run with just the "tooling" group,
which we intend to install by default at configure time in a forthcoming
commit.
Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Message-I... | {
"author": "John Snow <jsnow@redhat.com>",
"date": "Tue, 24 Feb 2026 13:14:31 -0500",
"is_openbsd": false,
"thread_id": "20260224181440.832943-1-jsnow@redhat.com.mbox.gz"
} |
lkml_critique | qemu-devel | The following changes since commit afe653676dc6dfd49f0390239ff90b2f0052c2b8:
Merge tag 'audio-pull-request' of https://gitlab.com/marcandre.lureau/qemu into staging (2026-02-23 14:03:50 +0000)
are available in the Git repository at:
https://gitlab.com/jsnow/qemu.git tags/python-pull-request
for you to f... | null | null | null | [PULL v2 00/19] Python patches | Instead of invoking python from the configure venv manually, instruct
developers to use the "run" script instead. Change the test invocation
to be a good example going forward.
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Message-ID: <20260218213416.674483-10-jsnow@... | {
"author": "John Snow <jsnow@redhat.com>",
"date": "Tue, 24 Feb 2026 13:14:27 -0500",
"is_openbsd": false,
"thread_id": "20260224181440.832943-1-jsnow@redhat.com.mbox.gz"
} |
lkml_critique | qemu-devel | The following changes since commit afe653676dc6dfd49f0390239ff90b2f0052c2b8:
Merge tag 'audio-pull-request' of https://gitlab.com/marcandre.lureau/qemu into staging (2026-02-23 14:03:50 +0000)
are available in the Git repository at:
https://gitlab.com/jsnow/qemu.git tags/python-pull-request
for you to f... | null | null | null | [PULL v2 00/19] Python patches | First up, use the newest v0.0.5 instead of the older v0.0.3.
Secondly, the use of a period in the key name does not behave as
expected when installing and checking for dependencies, so quote this
string instead.
Reviewed-by: Thomas Huth <thuth@redhat.com>
Message-ID: <20260218213416.674483-4-jsnow@redhat.com>
Signed-... | {
"author": "John Snow <jsnow@redhat.com>",
"date": "Tue, 24 Feb 2026 13:14:21 -0500",
"is_openbsd": false,
"thread_id": "20260224181440.832943-1-jsnow@redhat.com.mbox.gz"
} |
lkml_critique | qemu-devel | The following changes since commit afe653676dc6dfd49f0390239ff90b2f0052c2b8:
Merge tag 'audio-pull-request' of https://gitlab.com/marcandre.lureau/qemu into staging (2026-02-23 14:03:50 +0000)
are available in the Git repository at:
https://gitlab.com/jsnow/qemu.git tags/python-pull-request
for you to f... | null | null | null | [PULL v2 00/19] Python patches | With the qemu.qmp and qemu.machine dependencies now installed by default
at configure time and additional dependencies required by functional
testing installed on demand, we do not need the explicit "check-venv" target.
...However, to facilitate running VM tests without running configure, we
move some of the former lo... | {
"author": "John Snow <jsnow@redhat.com>",
"date": "Tue, 24 Feb 2026 13:14:34 -0500",
"is_openbsd": false,
"thread_id": "20260224181440.832943-1-jsnow@redhat.com.mbox.gz"
} |
lkml_critique | qemu-devel | The following changes since commit afe653676dc6dfd49f0390239ff90b2f0052c2b8:
Merge tag 'audio-pull-request' of https://gitlab.com/marcandre.lureau/qemu into staging (2026-02-23 14:03:50 +0000)
are available in the Git repository at:
https://gitlab.com/jsnow/qemu.git tags/python-pull-request
for you to f... | null | null | null | [PULL v2 00/19] Python patches | Installing local dependencies while offline, without PyPI access,
requires the python3-setuptools and python3-wheel packages. Most
distributions have these available anyway for one reason or another, but
not all of them.
If you are asking yourself "Wait, aren't these packages guaranteed via
installation of pip, via th... | {
"author": "John Snow <jsnow@redhat.com>",
"date": "Tue, 24 Feb 2026 13:14:29 -0500",
"is_openbsd": false,
"thread_id": "20260224181440.832943-1-jsnow@redhat.com.mbox.gz"
} |
lkml_critique | qemu-devel | The following changes since commit afe653676dc6dfd49f0390239ff90b2f0052c2b8:
Merge tag 'audio-pull-request' of https://gitlab.com/marcandre.lureau/qemu into staging (2026-02-23 14:03:50 +0000)
are available in the Git repository at:
https://gitlab.com/jsnow/qemu.git tags/python-pull-request
for you to f... | null | null | null | [PULL v2 00/19] Python patches | In anticipation of deleting the python/qemu/qmp source from the tree,
add a vendored version of the qemu.qmp package to ensure that "make
check" can be run in isolated build environments, offline.
Acked-by: Thomas Huth <thuth@redhat.com>
Message-ID: <20260218213416.674483-13-jsnow@redhat.com>
Signed-off-by: John Snow ... | {
"author": "John Snow <jsnow@redhat.com>",
"date": "Tue, 24 Feb 2026 13:14:30 -0500",
"is_openbsd": false,
"thread_id": "20260224181440.832943-1-jsnow@redhat.com.mbox.gz"
} |
lkml_critique | qemu-devel | The following changes since commit afe653676dc6dfd49f0390239ff90b2f0052c2b8:
Merge tag 'audio-pull-request' of https://gitlab.com/marcandre.lureau/qemu into staging (2026-02-23 14:03:50 +0000)
are available in the Git repository at:
https://gitlab.com/jsnow/qemu.git tags/python-pull-request
for you to f... | null | null | null | [PULL v2 00/19] Python patches | Add the local python package group into pythondeps.toml for the tooling
group. This makes qemu.qmp, qemu.machine and qemu.utils packages
unconditionally available for tests and scripts.
Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Message-ID: <20260218213416.674483-... | {
"author": "John Snow <jsnow@redhat.com>",
"date": "Tue, 24 Feb 2026 13:14:32 -0500",
"is_openbsd": false,
"thread_id": "20260224181440.832943-1-jsnow@redhat.com.mbox.gz"
} |
lkml_critique | qemu-devel | The following changes since commit afe653676dc6dfd49f0390239ff90b2f0052c2b8:
Merge tag 'audio-pull-request' of https://gitlab.com/marcandre.lureau/qemu into staging (2026-02-23 14:03:50 +0000)
are available in the Git repository at:
https://gitlab.com/jsnow/qemu.git tags/python-pull-request
for you to f... | null | null | null | [PULL v2 00/19] Python patches | It is no longer simply possible to just use this directory as if it were
an installed package now that it has dependencies, so update the README
to reflect this.
Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Message-ID: <20260218213416.674483-20-jsnow@redhat.com>
Sig... | {
"author": "John Snow <jsnow@redhat.com>",
"date": "Tue, 24 Feb 2026 13:14:37 -0500",
"is_openbsd": false,
"thread_id": "20260224181440.832943-1-jsnow@redhat.com.mbox.gz"
} |
lkml_critique | qemu-devel | The following changes since commit afe653676dc6dfd49f0390239ff90b2f0052c2b8:
Merge tag 'audio-pull-request' of https://gitlab.com/marcandre.lureau/qemu into staging (2026-02-23 14:03:50 +0000)
are available in the Git repository at:
https://gitlab.com/jsnow/qemu.git tags/python-pull-request
for you to f... | null | null | null | [PULL v2 00/19] Python patches | Add setuptools and wheel packages to ease installation burden when
internet access is allowed. When internet access is not allowed, this
functions as a configure-time check ensuring that our environment has
the necessary minimum viable versions for these packaging tools
available.
For detailed information on Python ec... | {
"author": "John Snow <jsnow@redhat.com>",
"date": "Tue, 24 Feb 2026 13:14:38 -0500",
"is_openbsd": false,
"thread_id": "20260224181440.832943-1-jsnow@redhat.com.mbox.gz"
} |
lkml_critique | qemu-devel | The following changes since commit afe653676dc6dfd49f0390239ff90b2f0052c2b8:
Merge tag 'audio-pull-request' of https://gitlab.com/marcandre.lureau/qemu into staging (2026-02-23 14:03:50 +0000)
are available in the Git repository at:
https://gitlab.com/jsnow/qemu.git tags/python-pull-request
for you to f... | null | null | null | [PULL v2 00/19] Python patches | Start relying on the external python-qemu-qmp dependency instead, to
prevent desync between the internal and external libraries.
This library is now entirely independent; to contribute changes, see
https://gitlab.com/qemu-project/python-qemu-qmp/
Reviewed-by: Thomas Huth <thuth@redhat.com>
Message-ID: <20260218213416... | {
"author": "John Snow <jsnow@redhat.com>",
"date": "Tue, 24 Feb 2026 13:14:36 -0500",
"is_openbsd": false,
"thread_id": "20260224181440.832943-1-jsnow@redhat.com.mbox.gz"
} |
lkml_critique | qemu-devel | The following changes since commit afe653676dc6dfd49f0390239ff90b2f0052c2b8:
Merge tag 'audio-pull-request' of https://gitlab.com/marcandre.lureau/qemu into staging (2026-02-23 14:03:50 +0000)
are available in the Git repository at:
https://gitlab.com/jsnow/qemu.git tags/python-pull-request
for you to f... | null | null | null | [PULL v2 00/19] Python patches | use the configured python (and the pyvenv) to run iotests instead of the
system default python3 interpreter. Use the new "run" script in the
build directory to execute the command inside the meson developer
environment, templated in qemu.git/run.in.
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Th... | {
"author": "John Snow <jsnow@redhat.com>",
"date": "Tue, 24 Feb 2026 13:14:25 -0500",
"is_openbsd": false,
"thread_id": "20260224181440.832943-1-jsnow@redhat.com.mbox.gz"
} |
lkml_critique | qemu-devel | The following changes since commit afe653676dc6dfd49f0390239ff90b2f0052c2b8:
Merge tag 'audio-pull-request' of https://gitlab.com/marcandre.lureau/qemu into staging (2026-02-23 14:03:50 +0000)
are available in the Git repository at:
https://gitlab.com/jsnow/qemu.git tags/python-pull-request
for you to f... | null | null | null | [PULL v2 00/19] Python patches | On Tue, 24 Feb 2026 at 18:14, John Snow <jsnow@redhat.com> wrote:
Applied, thanks.
Please update the changelog at https://wiki.qemu.org/ChangeLog/11.0
for any user-visible changes.
-- PMM | {
"author": "Peter Maydell <peter.maydell@linaro.org>",
"date": "Wed, 25 Feb 2026 13:42:11 +0000",
"is_openbsd": false,
"thread_id": "20260224181440.832943-1-jsnow@redhat.com.mbox.gz"
} |
lkml_critique | qemu-devel | The following changes since commit afe653676dc6dfd49f0390239ff90b2f0052c2b8:
Merge tag 'audio-pull-request' of https://gitlab.com/marcandre.lureau/qemu into staging (2026-02-23 14:03:50 +0000)
are available in the Git repository at:
https://gitlab.com/jsnow/qemu.git tags/python-pull-request
for you to f... | null | null | null | [PULL v2 00/19] Python patches | On Tue, 24 Feb 2026 at 18:14, John Snow <jsnow@redhat.com> wrote:
Hi -- it looks like this pullreq may have broken the "coverity" job
that (run on a separate schedule from main CI) does a QEMU build to
upload to the coverity scan service:
https://gitlab.com/qemu-project/qemu/-/jobs/13264087007
It fails during QEMU c... | {
"author": "Peter Maydell <peter.maydell@linaro.org>",
"date": "Thu, 26 Feb 2026 10:44:58 +0000",
"is_openbsd": false,
"thread_id": "20260224181440.832943-1-jsnow@redhat.com.mbox.gz"
} |
lkml_critique | qemu-devel | The following changes since commit afe653676dc6dfd49f0390239ff90b2f0052c2b8:
Merge tag 'audio-pull-request' of https://gitlab.com/marcandre.lureau/qemu into staging (2026-02-23 14:03:50 +0000)
are available in the Git repository at:
https://gitlab.com/jsnow/qemu.git tags/python-pull-request
for you to f... | null | null | null | [PULL v2 00/19] Python patches | On Thu, Feb 26, 2026 at 10:44:58AM +0000, Peter Maydell wrote:
Do we really need to be hardcoding configure options ?
It is a pretty random subset of options, compared to what gets
enabled in the build.
Originally we had the hand-built Dockerfile, but now nearly all
our dockerfiles are auto-generated by lcitool, so ... | {
"author": "Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= <berrange@redhat.com>",
"date": "Thu, 26 Feb 2026 11:16:04 +0000",
"is_openbsd": false,
"thread_id": "20260224181440.832943-1-jsnow@redhat.com.mbox.gz"
} |
lkml_critique | qemu-devel | The following changes since commit afe653676dc6dfd49f0390239ff90b2f0052c2b8:
Merge tag 'audio-pull-request' of https://gitlab.com/marcandre.lureau/qemu into staging (2026-02-23 14:03:50 +0000)
are available in the Git repository at:
https://gitlab.com/jsnow/qemu.git tags/python-pull-request
for you to f... | null | null | null | [PULL v2 00/19] Python patches | On Thu, 26 Feb 2026 at 11:16, Daniel P. Berrangé <berrange@redhat.com> wrote:
The comment in scripts/coverity-scan/run-coverity-scan gives the
rationale:
# We configure with a fixed set of enables here to ensure that we don't
# accidentally reduce the scope of the analysis by doing the build on
# the system that's mi... | {
"author": "Peter Maydell <peter.maydell@linaro.org>",
"date": "Thu, 26 Feb 2026 11:22:44 +0000",
"is_openbsd": false,
"thread_id": "20260224181440.832943-1-jsnow@redhat.com.mbox.gz"
} |
lkml_critique | qemu-devel | The following changes since commit afe653676dc6dfd49f0390239ff90b2f0052c2b8:
Merge tag 'audio-pull-request' of https://gitlab.com/marcandre.lureau/qemu into staging (2026-02-23 14:03:50 +0000)
are available in the Git repository at:
https://gitlab.com/jsnow/qemu.git tags/python-pull-request
for you to f... | null | null | null | [PULL v2 00/19] Python patches | Sorry, I was not aware of any build problems so far and as I wrote Peter earlier I was some time out of Qemu development, but that changed recently.
Is there a reason why Ronnie’s patch never went upstream? Surely, it was incomplete without the fix in the build scripts.
I do not see any issue with both patches. If th... | {
"author": "Peter Lieven <pl@dlhnet.de>",
"date": "Thu, 26 Feb 2026 12:39:28 +0100",
"is_openbsd": false,
"thread_id": "20260224181440.832943-1-jsnow@redhat.com.mbox.gz"
} |
lkml_critique | qemu-devel | The following changes since commit afe653676dc6dfd49f0390239ff90b2f0052c2b8:
Merge tag 'audio-pull-request' of https://gitlab.com/marcandre.lureau/qemu into staging (2026-02-23 14:03:50 +0000)
are available in the Git repository at:
https://gitlab.com/jsnow/qemu.git tags/python-pull-request
for you to f... | null | null | null | [PULL v2 00/19] Python patches | On 26/02/2026 12.39, Peter Lieven wrote:
Searching for the subject of that patch in my qemu-devel folder, I don't get
any results. So I guess that patch has never been posted to the qemu-devel
mailing list?
Thomas | {
"author": "Thomas Huth <thuth@redhat.com>",
"date": "Thu, 26 Feb 2026 13:41:23 +0100",
"is_openbsd": false,
"thread_id": "20260224181440.832943-1-jsnow@redhat.com.mbox.gz"
} |
lkml_critique | qemu-devel | The following changes since commit afe653676dc6dfd49f0390239ff90b2f0052c2b8:
Merge tag 'audio-pull-request' of https://gitlab.com/marcandre.lureau/qemu into staging (2026-02-23 14:03:50 +0000)
are available in the Git repository at:
https://gitlab.com/jsnow/qemu.git tags/python-pull-request
for you to f... | null | null | null | [PULL v2 00/19] Python patches | That might explain it. I meanwhile had a chance to look into the source of libnfs v6 it seems that patch is wrong.
It writes bytes number of bytes to the address auf iov->iov[0].iov_base. If bytes is greater than the iov->iov[0] buffer, it writes beyond the end of the buffer.
I cannot see at a glance if that’s potenti... | {
"author": "Peter Lieven <pl@dlhnet.de>",
"date": "Thu, 26 Feb 2026 14:06:01 +0100",
"is_openbsd": false,
"thread_id": "20260224181440.832943-1-jsnow@redhat.com.mbox.gz"
} |
lkml_critique | qemu-devel | The following changes since commit afe653676dc6dfd49f0390239ff90b2f0052c2b8:
Merge tag 'audio-pull-request' of https://gitlab.com/marcandre.lureau/qemu into staging (2026-02-23 14:03:50 +0000)
are available in the Git repository at:
https://gitlab.com/jsnow/qemu.git tags/python-pull-request
for you to f... | null | null | null | [PULL v2 00/19] Python patches | Peter Maydell <peter.maydell@linaro.org> writes:
[...]
Plan A: somebody does that.
Plan B.
I recommend to execute on of them in this development cycle. We can
always un-deprecate if somebody updates it during the deprecation grace
period. | {
"author": "Markus Armbruster <armbru@redhat.com>",
"date": "Fri, 27 Feb 2026 13:14:21 +0100",
"is_openbsd": false,
"thread_id": "20260224181440.832943-1-jsnow@redhat.com.mbox.gz"
} |
lkml_critique | qemu-devel | The following changes since commit afe653676dc6dfd49f0390239ff90b2f0052c2b8:
Merge tag 'audio-pull-request' of https://gitlab.com/marcandre.lureau/qemu into staging (2026-02-23 14:03:50 +0000)
are available in the Git repository at:
https://gitlab.com/jsnow/qemu.git tags/python-pull-request
for you to f... | null | null | null | [PULL v2 00/19] Python patches | On Fri, 27 Feb 2026 at 13:37, Peter Lieven <pl@dlhnet.de> wrote:
Yes, just about. Softfreeze starts on the 10th March and
changes are supposed to be in pull requests before that.
If the required changes turn out to be fairly minor then
we can probably let it get in even if it's a little bit
behind on that schedule.
-... | {
"author": "Peter Maydell <peter.maydell@linaro.org>",
"date": "Fri, 27 Feb 2026 13:49:18 +0000",
"is_openbsd": false,
"thread_id": "20260224181440.832943-1-jsnow@redhat.com.mbox.gz"
} |
lkml_critique | qemu-devel | The following changes since commit afe653676dc6dfd49f0390239ff90b2f0052c2b8:
Merge tag 'audio-pull-request' of https://gitlab.com/marcandre.lureau/qemu into staging (2026-02-23 14:03:50 +0000)
are available in the Git repository at:
https://gitlab.com/jsnow/qemu.git tags/python-pull-request
for you to f... | null | null | null | [PULL v2 00/19] Python patches | On 27/02/2026 14.37, Peter Lieven wrote:
Yes, soft freeze date is March 10th:
https://wiki.qemu.org/Planning/11.0
HTH,
Thomas | {
"author": "Thomas Huth <thuth@redhat.com>",
"date": "Fri, 27 Feb 2026 14:52:00 +0100",
"is_openbsd": false,
"thread_id": "20260224181440.832943-1-jsnow@redhat.com.mbox.gz"
} |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.