data_type large_stringclasses 3
values | source large_stringclasses 29
values | code large_stringlengths 98 49.4M | filepath large_stringlengths 5 161 ⌀ | message large_stringclasses 234
values | commit large_stringclasses 234
values | subject large_stringclasses 418
values | critique large_stringlengths 101 1.26M ⌀ | metadata dict |
|---|---|---|---|---|---|---|---|---|
lkml_critique | bpf | v1: https://lore.kernel.org/bpf/cover.1771605821.git.josef@toxicpanda.com/
v2: https://lore.kernel.org/bpf/cover.1771616227.git.josef@toxicpanda.com/
v3: https://lore.kernel.org/bpf/cover.1771622266.git.josef@toxicpanda.com/
v4: https://lore.kernel.org/bpf/cover.1771625484.git.josef@toxicpanda.com/
v1->v2:
- Added a b... | null | null | null | [PATCH v5 0/3] libbpf/bpftool: support merging split BTFs | 2026-02-24 17:18 UTC+0000 ~ bot+bpf-ci@kernel.org
And the question still stands :)
The rest of the bpftool patch looks good to me, thank you for the changes. | {
"author": "Quentin Monnet <qmo@qmon.net>",
"date": "Thu, 26 Feb 2026 13:47:04 +0000",
"is_openbsd": false,
"thread_id": "a8f149ea-2b96-43b8-8cc4-8a3e58c230d9@qmon.net.mbox.gz"
} |
lkml_critique | bpf | We don't check if cookies are available on the kprobe_multi link
before accessing them in show_fdinfo callback, we should.
Cc: stable@vger.kernel.org
Fixes: da7e9c0a7fbc ("bpf: Add show_fdinfo for kprobe_multi")
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
---
kernel/trace/bpf_trace.c | 4 +++-
1 file changed, 3 inser... | null | null | null | [PATCH bpf] bpf: Fix kprobe_multi cookies access in show_fdinfo callback | Hello:
This patch was applied to bpf/bpf.git (master)
by Alexei Starovoitov <ast@kernel.org>:
On Wed, 25 Feb 2026 12:12:49 +0100 you wrote:
Here is the summary with links:
- [bpf] bpf: Fix kprobe_multi cookies access in show_fdinfo callback
https://git.kernel.org/bpf/bpf/c/ad6fface76da
You are awesome, thank ... | {
"author": "patchwork-bot+netdevbpf@kernel.org",
"date": "Thu, 26 Feb 2026 19:30:16 +0000",
"is_openbsd": false,
"thread_id": "177213421655.1808439.14823705396024215144.git-patchwork-notify@kernel.org.mbox.gz"
} |
lkml_critique | bpf |
*** The history ***
Nowadays, UEFI PE bootable images are becoming increasingly popular
among distributions. Currently, we have several kinds of image format
parsers in user space (kexec-tools). However, this approach breaks the
integrity protection of the images. To address this integrity protection
concern, several... | null | null | null | [PATCHv6 00/13] kexec: Use BPF lskel to enable kexec to load PE format boot image | In the security kexec_file_load case, the buffer holding the kernel
image should not be accessible from userspace.
Typically, BPF data flow occurs between user space and kernel space in
either direction. However, the above case presents a unique scenario
where the kernel, instead of a user task, reads data from a file... | {
"author": "Pingfan Liu <piliu@redhat.com>",
"date": "Mon, 19 Jan 2026 11:24:12 +0800",
"is_openbsd": false,
"thread_id": "CAF+s44RxsvVEKSg=OZpbq1YTp4qi4j-+ZnS=BK5dcHW5Q61W7w@mail.gmail.com.mbox.gz"
} |
lkml_critique | bpf |
*** The history ***
Nowadays, UEFI PE bootable images are becoming increasingly popular
among distributions. Currently, we have several kinds of image format
parsers in user space (kexec-tools). However, this approach breaks the
integrity protection of the images. To address this integrity protection
concern, several... | null | null | null | [PATCHv6 00/13] kexec: Use BPF lskel to enable kexec to load PE format boot image | Move the signature validation at the head of the function, so the image
can be unfold and handled later.
Signed-off-by: Pingfan Liu <piliu@redhat.com>
Cc: Baoquan He <bhe@redhat.com>
Cc: Dave Young <dyoung@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Philipp Rudo <prudo@redhat.com>
To: kexec@lists.inf... | {
"author": "Pingfan Liu <piliu@redhat.com>",
"date": "Mon, 19 Jan 2026 11:24:13 +0800",
"is_openbsd": false,
"thread_id": "CAF+s44RxsvVEKSg=OZpbq1YTp4qi4j-+ZnS=BK5dcHW5Q61W7w@mail.gmail.com.mbox.gz"
} |
lkml_critique | bpf |
*** The history ***
Nowadays, UEFI PE bootable images are becoming increasingly popular
among distributions. Currently, we have several kinds of image format
parsers in user space (kexec-tools). However, this approach breaks the
integrity protection of the images. To address this integrity protection
concern, several... | null | null | null | [PATCHv6 00/13] kexec: Use BPF lskel to enable kexec to load PE format boot image | The incoming patches need to handle UEFI format image, which is in PE
format. Hence introducing some routines here.
Signed-off-by: Pingfan Liu <piliu@redhat.com>
Cc: Baoquan He <bhe@redhat.com>
Cc: Dave Young <dyoung@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Philipp Rudo <prudo@redhat.com>
To: kexe... | {
"author": "Pingfan Liu <piliu@redhat.com>",
"date": "Mon, 19 Jan 2026 11:24:14 +0800",
"is_openbsd": false,
"thread_id": "CAF+s44RxsvVEKSg=OZpbq1YTp4qi4j-+ZnS=BK5dcHW5Q61W7w@mail.gmail.com.mbox.gz"
} |
lkml_critique | bpf |
*** The history ***
Nowadays, UEFI PE bootable images are becoming increasingly popular
among distributions. Currently, we have several kinds of image format
parsers in user space (kexec-tools). However, this approach breaks the
integrity protection of the images. To address this integrity protection
concern, several... | null | null | null | [PATCHv6 00/13] kexec: Use BPF lskel to enable kexec to load PE format boot image | As UEFI becomes popular, a few architectures support to boot a PE format
kernel image directly. But the internal of PE format varies, which means
each parser for each format.
This patch (with the rest in this series) introduces a common skeleton
to all parsers, and leave the format parsing in
bpf-prog, so the kernel c... | {
"author": "Pingfan Liu <piliu@redhat.com>",
"date": "Mon, 19 Jan 2026 11:24:15 +0800",
"is_openbsd": false,
"thread_id": "CAF+s44RxsvVEKSg=OZpbq1YTp4qi4j-+ZnS=BK5dcHW5Q61W7w@mail.gmail.com.mbox.gz"
} |
lkml_critique | bpf |
*** The history ***
Nowadays, UEFI PE bootable images are becoming increasingly popular
among distributions. Currently, we have several kinds of image format
parsers in user space (kexec-tools). However, this approach breaks the
integrity protection of the images. To address this integrity protection
concern, several... | null | null | null | [PATCHv6 00/13] kexec: Use BPF lskel to enable kexec to load PE format boot image | The KEXE PE format parser needs the kernel built-in decompressor to
decompress the kernel image. So moving the decompressor out of __init
sections.
Signed-off-by: Pingfan Liu <piliu@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
To: linux-kernel@vger.kernel.org
---
include/linux/decompress/mm.h | 8 +++++++... | {
"author": "Pingfan Liu <piliu@redhat.com>",
"date": "Mon, 19 Jan 2026 11:24:16 +0800",
"is_openbsd": false,
"thread_id": "CAF+s44RxsvVEKSg=OZpbq1YTp4qi4j-+ZnS=BK5dcHW5Q61W7w@mail.gmail.com.mbox.gz"
} |
lkml_critique | bpf |
*** The history ***
Nowadays, UEFI PE bootable images are becoming increasingly popular
among distributions. Currently, we have several kinds of image format
parsers in user space (kexec-tools). However, this approach breaks the
integrity protection of the images. To address this integrity protection
concern, several... | null | null | null | [PATCHv6 00/13] kexec: Use BPF lskel to enable kexec to load PE format boot image | On arm64, there is no boot-time decompression for the kernel image.
Therefore, when a compressed kernel image is loaded, it must be
decompressed.
It is impractical to implement the complex decompression methods in BPF
bytecode. However, decompression routines exist in the kernel. This
patch bridges the compressed dat... | {
"author": "Pingfan Liu <piliu@redhat.com>",
"date": "Mon, 19 Jan 2026 11:24:17 +0800",
"is_openbsd": false,
"thread_id": "CAF+s44RxsvVEKSg=OZpbq1YTp4qi4j-+ZnS=BK5dcHW5Q61W7w@mail.gmail.com.mbox.gz"
} |
lkml_critique | bpf |
*** The history ***
Nowadays, UEFI PE bootable images are becoming increasingly popular
among distributions. Currently, we have several kinds of image format
parsers in user space (kexec-tools). However, this approach breaks the
integrity protection of the images. To address this integrity protection
concern, several... | null | null | null | [PATCHv6 00/13] kexec: Use BPF lskel to enable kexec to load PE format boot image | Copying the bpf code parsing result to the proper place:
image->kernel_buf, initrd_buf, cmdline_buf.
Signed-off-by: Pingfan Liu <piliu@redhat.com>
Cc: Baoquan He <bhe@redhat.com>
Cc: Dave Young <dyoung@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Philipp Rudo <prudo@redhat.com>
To: kexec@lists.infrade... | {
"author": "Pingfan Liu <piliu@redhat.com>",
"date": "Mon, 19 Jan 2026 11:24:18 +0800",
"is_openbsd": false,
"thread_id": "CAF+s44RxsvVEKSg=OZpbq1YTp4qi4j-+ZnS=BK5dcHW5Q61W7w@mail.gmail.com.mbox.gz"
} |
lkml_critique | bpf |
*** The history ***
Nowadays, UEFI PE bootable images are becoming increasingly popular
among distributions. Currently, we have several kinds of image format
parsers in user space (kexec-tools). However, this approach breaks the
integrity protection of the images. To address this integrity protection
concern, several... | null | null | null | [PATCHv6 00/13] kexec: Use BPF lskel to enable kexec to load PE format boot image | Analague to kernel/bpf/preload/iterators/Makefile,
this Makefile is not invoked by the Kbuild system. It needs to be
invoked manually when kexec_pe_parser_bpf.c is changed so that
kexec_pe_parser_bpf.lskel.h can be re-generated by the command "bpftool
gen skeleton -L kexec_pe_parser_bpf.o".
kexec_pe_parser_bpf.lskel.h... | {
"author": "Pingfan Liu <piliu@redhat.com>",
"date": "Mon, 19 Jan 2026 11:24:19 +0800",
"is_openbsd": false,
"thread_id": "CAF+s44RxsvVEKSg=OZpbq1YTp4qi4j-+ZnS=BK5dcHW5Q61W7w@mail.gmail.com.mbox.gz"
} |
lkml_critique | bpf |
*** The history ***
Nowadays, UEFI PE bootable images are becoming increasingly popular
among distributions. Currently, we have several kinds of image format
parsers in user space (kexec-tools). However, this approach breaks the
integrity protection of the images. To address this integrity protection
concern, several... | null | null | null | [PATCHv6 00/13] kexec: Use BPF lskel to enable kexec to load PE format boot image | The routine to search a symbol in ELF can be shared, so split it out.
Signed-off-by: Pingfan Liu <piliu@redhat.com>
Cc: Baoquan He <bhe@redhat.com>
Cc: Dave Young <dyoung@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Philipp Rudo <prudo@redhat.com>
To: kexec@lists.infradead.org
---
kernel/kexec_file.c... | {
"author": "Pingfan Liu <piliu@redhat.com>",
"date": "Mon, 19 Jan 2026 11:24:20 +0800",
"is_openbsd": false,
"thread_id": "CAF+s44RxsvVEKSg=OZpbq1YTp4qi4j-+ZnS=BK5dcHW5Q61W7w@mail.gmail.com.mbox.gz"
} |
lkml_critique | bpf |
*** The history ***
Nowadays, UEFI PE bootable images are becoming increasingly popular
among distributions. Currently, we have several kinds of image format
parsers in user space (kexec-tools). However, this approach breaks the
integrity protection of the images. To address this integrity protection
concern, several... | null | null | null | [PATCHv6 00/13] kexec: Use BPF lskel to enable kexec to load PE format boot image | All kexec PE bpf prog should align with the interface exposed by the
light skeleton
four maps:
struct bpf_map_desc ringbuf_1;
struct bpf_map_desc ringbuf_2;
struct bpf_map_desc ringbuf_3;
struct bpf_map_desc ringbuf_4;
four sections... | {
"author": "Pingfan Liu <piliu@redhat.com>",
"date": "Mon, 19 Jan 2026 11:24:21 +0800",
"is_openbsd": false,
"thread_id": "CAF+s44RxsvVEKSg=OZpbq1YTp4qi4j-+ZnS=BK5dcHW5Q61W7w@mail.gmail.com.mbox.gz"
} |
lkml_critique | bpf |
*** The history ***
Nowadays, UEFI PE bootable images are becoming increasingly popular
among distributions. Currently, we have several kinds of image format
parsers in user space (kexec-tools). However, this approach breaks the
integrity protection of the images. To address this integrity protection
concern, several... | null | null | null | [PATCHv6 00/13] kexec: Use BPF lskel to enable kexec to load PE format boot image | Now everything is ready for kexec PE image parser. Select it on arm64
for zboot and UKI image support.
Signed-off-by: Pingfan Liu <piliu@redhat.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Will Deacon <will@kernel.org>
To: linux-arm-kernel@lists.infradead.org
---
arch/arm64/Kconfig | 1 +
1 file changed, 1 ... | {
"author": "Pingfan Liu <piliu@redhat.com>",
"date": "Mon, 19 Jan 2026 11:24:22 +0800",
"is_openbsd": false,
"thread_id": "CAF+s44RxsvVEKSg=OZpbq1YTp4qi4j-+ZnS=BK5dcHW5Q61W7w@mail.gmail.com.mbox.gz"
} |
lkml_critique | bpf |
*** The history ***
Nowadays, UEFI PE bootable images are becoming increasingly popular
among distributions. Currently, we have several kinds of image format
parsers in user space (kexec-tools). However, this approach breaks the
integrity protection of the images. To address this integrity protection
concern, several... | null | null | null | [PATCHv6 00/13] kexec: Use BPF lskel to enable kexec to load PE format boot image | This BPF program aligns with the convention defined in the kernel file
kexec_pe_parser_bpf.lskel.h. This can be easily achieved by include
"template.c", which includes:
four maps:
struct bpf_map_desc ringbuf_1;
struct bpf_map_desc ringbuf_2;
struct bpf_map... | {
"author": "Pingfan Liu <piliu@redhat.com>",
"date": "Mon, 19 Jan 2026 11:24:23 +0800",
"is_openbsd": false,
"thread_id": "CAF+s44RxsvVEKSg=OZpbq1YTp4qi4j-+ZnS=BK5dcHW5Q61W7w@mail.gmail.com.mbox.gz"
} |
lkml_critique | bpf |
*** The history ***
Nowadays, UEFI PE bootable images are becoming increasingly popular
among distributions. Currently, we have several kinds of image format
parsers in user space (kexec-tools). However, this approach breaks the
integrity protection of the images. To address this integrity protection
concern, several... | null | null | null | [PATCHv6 00/13] kexec: Use BPF lskel to enable kexec to load PE format boot image | The objcopy binary can append a section to a PE file, but it disregards
the DOS header. However, the zboot format carries important information
in the DOS header: payload offset and size.
To track this information and append a new PE section, here a dedicated
binary tool is introduced to build zboot images. The payloa... | {
"author": "Pingfan Liu <piliu@redhat.com>",
"date": "Mon, 19 Jan 2026 11:24:24 +0800",
"is_openbsd": false,
"thread_id": "CAF+s44RxsvVEKSg=OZpbq1YTp4qi4j-+ZnS=BK5dcHW5Q61W7w@mail.gmail.com.mbox.gz"
} |
lkml_critique | bpf |
*** The history ***
Nowadays, UEFI PE bootable images are becoming increasingly popular
among distributions. Currently, we have several kinds of image format
parsers in user space (kexec-tools). However, this approach breaks the
integrity protection of the images. To address this integrity protection
concern, several... | null | null | null | [PATCHv6 00/13] kexec: Use BPF lskel to enable kexec to load PE format boot image | Hi Pingfan,
kernel test robot noticed the following build warnings:
[auto build test WARNING on bpf-next/net]
[also build test WARNING on bpf-next/master bpf/master akpm-mm/mm-nonmm-unstable linus/master v6.19-rc6 next-20260116]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitti... | {
"author": "kernel test robot <lkp@intel.com>",
"date": "Mon, 19 Jan 2026 16:23:31 +0800",
"is_openbsd": false,
"thread_id": "CAF+s44RxsvVEKSg=OZpbq1YTp4qi4j-+ZnS=BK5dcHW5Q61W7w@mail.gmail.com.mbox.gz"
} |
lkml_critique | bpf |
*** The history ***
Nowadays, UEFI PE bootable images are becoming increasingly popular
among distributions. Currently, we have several kinds of image format
parsers in user space (kexec-tools). However, this approach breaks the
integrity protection of the images. To address this integrity protection
concern, several... | null | null | null | [PATCHv6 00/13] kexec: Use BPF lskel to enable kexec to load PE format boot image | [ ... ]
The kernel_len parameter is declared but never used in this function.
Should this validate that mz->peaddr is within bounds of kernel_len before
accessing pe->magic? If mz->peaddr is larger than the buffer size, this
would read out of bounds.
[ ... ]
pe_get_section() has no buffer size parameter. The valu... | {
"author": "bot+bpf-ci@kernel.org",
"date": "Mon, 19 Jan 2026 18:45:32 +0000 (UTC)",
"is_openbsd": false,
"thread_id": "CAF+s44RxsvVEKSg=OZpbq1YTp4qi4j-+ZnS=BK5dcHW5Q61W7w@mail.gmail.com.mbox.gz"
} |
lkml_critique | bpf |
*** The history ***
Nowadays, UEFI PE bootable images are becoming increasingly popular
among distributions. Currently, we have several kinds of image format
parsers in user space (kexec-tools). However, this approach breaks the
integrity protection of the images. To address this integrity protection
concern, several... | null | null | null | [PATCHv6 00/13] kexec: Use BPF lskel to enable kexec to load PE format boot image | ^^^
Should this condition also include KEEP_DECOMPRESSOR?
In kernel/Kconfig.kexec, KEXEC_BPF has:
depends on DEBUG_INFO_BTF && BPF_SYSCALL && KEEP_DECOMPRESSOR
Since Kconfig's select statement forces a symbol's value without visiting
the dependencies, this select will enable KEXEC_BPF even when
KEEP_DECOMPRESSO... | {
"author": "bot+bpf-ci@kernel.org",
"date": "Mon, 19 Jan 2026 18:45:34 +0000 (UTC)",
"is_openbsd": false,
"thread_id": "CAF+s44RxsvVEKSg=OZpbq1YTp4qi4j-+ZnS=BK5dcHW5Q61W7w@mail.gmail.com.mbox.gz"
} |
lkml_critique | bpf |
*** The history ***
Nowadays, UEFI PE bootable images are becoming increasingly popular
among distributions. Currently, we have several kinds of image format
parsers in user space (kexec-tools). However, this approach breaks the
integrity protection of the images. To address this integrity protection
concern, several... | null | null | null | [PATCHv6 00/13] kexec: Use BPF lskel to enable kexec to load PE format boot image | [ ... ]
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
The elf_size parameter is declared but never used in this function. The
pointer calculations at ehdr->e_shoff, shdr[sym->st_shndx], and
dst_shdr->sh_offset + sym->st_value could all access memory beyond the
ELF buffer if the ELF... | {
"author": "bot+bpf-ci@kernel.org",
"date": "Mon, 19 Jan 2026 18:45:36 +0000 (UTC)",
"is_openbsd": false,
"thread_id": "CAF+s44RxsvVEKSg=OZpbq1YTp4qi4j-+ZnS=BK5dcHW5Q61W7w@mail.gmail.com.mbox.gz"
} |
lkml_critique | bpf |
*** The history ***
Nowadays, UEFI PE bootable images are becoming increasingly popular
among distributions. Currently, we have several kinds of image format
parsers in user space (kexec-tools). However, this approach breaks the
integrity protection of the images. To address this integrity protection
concern, several... | null | null | null | [PATCHv6 00/13] kexec: Use BPF lskel to enable kexec to load PE format boot image | [ ... ]
This function returns int and can return -1 on error, but the caller stores
the result in a uint32_t without checking for errors (see below).
[ ... ]
^^^^^^^^^^^^^^^^
Are payload_sect_idx and payload_sect_off intentionally left uninitialized
here? If the loop below never finds a matching... | {
"author": "bot+bpf-ci@kernel.org",
"date": "Mon, 19 Jan 2026 18:45:38 +0000 (UTC)",
"is_openbsd": false,
"thread_id": "CAF+s44RxsvVEKSg=OZpbq1YTp4qi4j-+ZnS=BK5dcHW5Q61W7w@mail.gmail.com.mbox.gz"
} |
lkml_critique | bpf |
*** The history ***
Nowadays, UEFI PE bootable images are becoming increasingly popular
among distributions. Currently, we have several kinds of image format
parsers in user space (kexec-tools). However, this approach breaks the
integrity protection of the images. To address this integrity protection
concern, several... | null | null | null | [PATCHv6 00/13] kexec: Use BPF lskel to enable kexec to load PE format boot image | [ ... ]
[ ... ]
Should this bounds check also verify that payload_offset + payload_size
does not exceed image_sz? The current check only validates that payload_size
fits, but if payload_offset is large (e.g., near image_sz), the read below
could extend past the end of the kernel buffer.
For example, with payload_o... | {
"author": "bot+bpf-ci@kernel.org",
"date": "Mon, 19 Jan 2026 18:45:40 +0000 (UTC)",
"is_openbsd": false,
"thread_id": "CAF+s44RxsvVEKSg=OZpbq1YTp4qi4j-+ZnS=BK5dcHW5Q61W7w@mail.gmail.com.mbox.gz"
} |
lkml_critique | bpf |
*** The history ***
Nowadays, UEFI PE bootable images are becoming increasingly popular
among distributions. Currently, we have several kinds of image format
parsers in user space (kexec-tools). However, this approach breaks the
integrity protection of the images. To address this integrity protection
concern, several... | null | null | null | [PATCHv6 00/13] kexec: Use BPF lskel to enable kexec to load PE format boot image | Does this reordering break signature verification? The kimage_validate_signature()
function calls kexec_image_verify_sig(), which accesses image->fops->verify_sig:
static int kexec_image_verify_sig(struct kimage *image, void *buf,
unsigned long buf_len)
{
if (!image->fops ... | {
"author": "bot+bpf-ci@kernel.org",
"date": "Mon, 19 Jan 2026 18:45:45 +0000 (UTC)",
"is_openbsd": false,
"thread_id": "CAF+s44RxsvVEKSg=OZpbq1YTp4qi4j-+ZnS=BK5dcHW5Q61W7w@mail.gmail.com.mbox.gz"
} |
lkml_critique | bpf |
*** The history ***
Nowadays, UEFI PE bootable images are becoming increasingly popular
among distributions. Currently, we have several kinds of image format
parsers in user space (kexec-tools). However, this approach breaks the
integrity protection of the images. To address this integrity protection
concern, several... | null | null | null | [PATCHv6 00/13] kexec: Use BPF lskel to enable kexec to load PE format boot image | [ ... ]
[ ... ]
ctx->buf is NULL here from kzalloc.
[ ... ]
If bpf_buffer_parser() is called multiple times on the same context, does
this leak the previous parser_buf and its backing vmalloc buffer? The
assignment to context->buf overwrites any existing pointer without first
freeing it.
release_bpf_parser_cont... | {
"author": "bot+bpf-ci@kernel.org",
"date": "Mon, 19 Jan 2026 18:45:43 +0000 (UTC)",
"is_openbsd": false,
"thread_id": "CAF+s44RxsvVEKSg=OZpbq1YTp4qi4j-+ZnS=BK5dcHW5Q61W7w@mail.gmail.com.mbox.gz"
} |
lkml_critique | bpf |
*** The history ***
Nowadays, UEFI PE bootable images are becoming increasingly popular
among distributions. Currently, we have several kinds of image format
parsers in user space (kexec-tools). However, this approach breaks the
integrity protection of the images. To address this integrity protection
concern, several... | null | null | null | [PATCHv6 00/13] kexec: Use BPF lskel to enable kexec to load PE format boot image | [ ... ]
The *_sz fields here are int, but image->kernel_buf_len and related fields
are unsigned long. Could this cause truncation issues for buffers larger
than INT_MAX?
[ ... ]
With the placeholder arm_bpf_prog/disarm_bpf_prog functions that do nothing,
if an image has a .bpf section, won't this loop iterate fore... | {
"author": "bot+bpf-ci@kernel.org",
"date": "Mon, 19 Jan 2026 18:45:41 +0000 (UTC)",
"is_openbsd": false,
"thread_id": "CAF+s44RxsvVEKSg=OZpbq1YTp4qi4j-+ZnS=BK5dcHW5Q61W7w@mail.gmail.com.mbox.gz"
} |
lkml_critique | bpf |
*** The history ***
Nowadays, UEFI PE bootable images are becoming increasingly popular
among distributions. Currently, we have several kinds of image format
parsers in user space (kexec-tools). However, this approach breaks the
integrity protection of the images. To address this integrity protection
concern, several... | null | null | null | [PATCHv6 00/13] kexec: Use BPF lskel to enable kexec to load PE format boot image | [ ... ]
Should decompress_mem_allocator_fini() also free the individual chunks stored
in chunk_base_addr[0..next_idx-1]? On the success path, merge_decompressed_data()
frees them, but on error paths (decompressor failure or merge failure), the
chunks appear to be leaked since only the array pointer is freed here.
[ ... | {
"author": "bot+bpf-ci@kernel.org",
"date": "Mon, 19 Jan 2026 18:45:47 +0000 (UTC)",
"is_openbsd": false,
"thread_id": "CAF+s44RxsvVEKSg=OZpbq1YTp4qi4j-+ZnS=BK5dcHW5Q61W7w@mail.gmail.com.mbox.gz"
} |
lkml_critique | bpf |
*** The history ***
Nowadays, UEFI PE bootable images are becoming increasingly popular
among distributions. Currently, we have several kinds of image format
parsers in user space (kexec-tools). However, this approach breaks the
integrity protection of the images. To address this integrity protection
concern, several... | null | null | null | [PATCHv6 00/13] kexec: Use BPF lskel to enable kexec to load PE format boot image | Hi Pingfan,
please excuse my late reply. I've looked through the series and all in
all it looks fine to me. I've got two comments/questions in addition to
what the bpf-bot found. In general the findings from the bpf-bot look
valid to me. But fixing them should be rather straight forward. Only
for the first finding, wh... | {
"author": "Philipp Rudo <prudo@redhat.com>",
"date": "Thu, 26 Feb 2026 14:36:28 +0100",
"is_openbsd": false,
"thread_id": "CAF+s44RxsvVEKSg=OZpbq1YTp4qi4j-+ZnS=BK5dcHW5Q61W7w@mail.gmail.com.mbox.gz"
} |
lkml_critique | bpf |
*** The history ***
Nowadays, UEFI PE bootable images are becoming increasingly popular
among distributions. Currently, we have several kinds of image format
parsers in user space (kexec-tools). However, this approach breaks the
integrity protection of the images. To address this integrity protection
concern, several... | null | null | null | [PATCHv6 00/13] kexec: Use BPF lskel to enable kexec to load PE format boot image | Hi Pingfan,
On Mon, 19 Jan 2026 11:24:13 +0800
Pingfan Liu <piliu@redhat.com> wrote:
besides what the bpf-bot already mentioned.
What do you want to achieve by moving signature verification in front
of probing the image? Do you want to avoid calling
arch_kexec_kernel_image_probe twice? It would be great if you coul... | {
"author": "Philipp Rudo <prudo@redhat.com>",
"date": "Thu, 26 Feb 2026 14:37:10 +0100",
"is_openbsd": false,
"thread_id": "CAF+s44RxsvVEKSg=OZpbq1YTp4qi4j-+ZnS=BK5dcHW5Q61W7w@mail.gmail.com.mbox.gz"
} |
lkml_critique | bpf |
*** The history ***
Nowadays, UEFI PE bootable images are becoming increasingly popular
among distributions. Currently, we have several kinds of image format
parsers in user space (kexec-tools). However, this approach breaks the
integrity protection of the images. To address this integrity protection
concern, several... | null | null | null | [PATCHv6 00/13] kexec: Use BPF lskel to enable kexec to load PE format boot image | Hi Pingfan,
On Mon, 19 Jan 2026 11:24:15 +0800
Pingfan Liu <piliu@redhat.com> wrote:
[...]
I'm not sure this works as intended. In case a .bpf section exists but
bpf_sz is 0, the function will skip arming the bpf-prog but still
continue. That doesn't look right to me. IIUC a zero size bpf-prog
should be an error. O... | {
"author": "Philipp Rudo <prudo@redhat.com>",
"date": "Thu, 26 Feb 2026 14:37:43 +0100",
"is_openbsd": false,
"thread_id": "CAF+s44RxsvVEKSg=OZpbq1YTp4qi4j-+ZnS=BK5dcHW5Q61W7w@mail.gmail.com.mbox.gz"
} |
lkml_critique | bpf |
*** The history ***
Nowadays, UEFI PE bootable images are becoming increasingly popular
among distributions. Currently, we have several kinds of image format
parsers in user space (kexec-tools). However, this approach breaks the
integrity protection of the images. To address this integrity protection
concern, several... | null | null | null | [PATCHv6 00/13] kexec: Use BPF lskel to enable kexec to load PE format boot image | On Thu, Feb 26, 2026 at 9:37 PM Philipp Rudo <prudo@redhat.com> wrote:
Here I made a mistake. I think the UKI case and the convention case
should be handled separately. For the UKI case, signature verification
should be applied to the UKI envelope but skipped for the unpacked
kernel image since it has no signature.
T... | {
"author": "Pingfan Liu <piliu@redhat.com>",
"date": "Fri, 27 Feb 2026 10:33:24 +0800",
"is_openbsd": false,
"thread_id": "CAF+s44RxsvVEKSg=OZpbq1YTp4qi4j-+ZnS=BK5dcHW5Q61W7w@mail.gmail.com.mbox.gz"
} |
lkml_critique | bpf |
*** The history ***
Nowadays, UEFI PE bootable images are becoming increasingly popular
among distributions. Currently, we have several kinds of image format
parsers in user space (kexec-tools). However, this approach breaks the
integrity protection of the images. To address this integrity protection
concern, several... | null | null | null | [PATCHv6 00/13] kexec: Use BPF lskel to enable kexec to load PE format boot image | On Thu, Feb 26, 2026 at 9:37 PM Philipp Rudo <prudo@redhat.com> wrote:
Yes, you are right. It's better to treat a zero bpf_sz as an invalid format.
Thanks,
Pingfan | {
"author": "Pingfan Liu <piliu@redhat.com>",
"date": "Fri, 27 Feb 2026 10:40:13 +0800",
"is_openbsd": false,
"thread_id": "CAF+s44RxsvVEKSg=OZpbq1YTp4qi4j-+ZnS=BK5dcHW5Q61W7w@mail.gmail.com.mbox.gz"
} |
lkml_critique | bpf |
*** The history ***
Nowadays, UEFI PE bootable images are becoming increasingly popular
among distributions. Currently, we have several kinds of image format
parsers in user space (kexec-tools). However, this approach breaks the
integrity protection of the images. To address this integrity protection
concern, several... | null | null | null | [PATCHv6 00/13] kexec: Use BPF lskel to enable kexec to load PE format boot image | Hi Philipp,
Thank you for taking the time to look into this.
On Thu, Feb 26, 2026 at 9:36 PM Philipp Rudo <prudo@redhat.com> wrote:
A race condition exists: when bpf_buffer_parser() is called multiple
times on ctx, later calls overwrite the previous ctx->buf without
releasing it. While re-entrancy is uncommon in thi... | {
"author": "Pingfan Liu <piliu@redhat.com>",
"date": "Fri, 27 Feb 2026 14:03:42 +0800",
"is_openbsd": false,
"thread_id": "CAF+s44RxsvVEKSg=OZpbq1YTp4qi4j-+ZnS=BK5dcHW5Q61W7w@mail.gmail.com.mbox.gz"
} |
lkml_critique | bpf | Enable pointer modification with constant offsets accumulated in the
register for PTR_TO_CTX for programs where it won't be rewritten. See
patches for details.
Kumar Kartikeya Dwivedi (2):
bpf: Relax fixed offset check for PTR_TO_CTX
selftests/bpf: Add tests for ctx fixed offset support
kernel/bpf/verifier.c ... | null | null | null | [PATCH bpf-next v1 0/2] Allow fixed offsets for PTR_TO_CTX | The limitation on fixed offsets stems from the fact that certain program
types rewrite the accesses to the context structure and translate them
to accesses to the real underlying type. Technically, in the past, we
could have stashed the register offset in insn_aux and made rewrites
work, but we've never needed it in th... | {
"author": "Kumar Kartikeya Dwivedi <memxor@gmail.com>",
"date": "Thu, 26 Feb 2026 16:57:24 -0800",
"is_openbsd": false,
"thread_id": "DGPCZB864GLP.2WMKZWOWZOH2K@etsalapatis.com.mbox.gz"
} |
lkml_critique | bpf | Enable pointer modification with constant offsets accumulated in the
register for PTR_TO_CTX for programs where it won't be rewritten. See
patches for details.
Kumar Kartikeya Dwivedi (2):
bpf: Relax fixed offset check for PTR_TO_CTX
selftests/bpf: Add tests for ctx fixed offset support
kernel/bpf/verifier.c ... | null | null | null | [PATCH bpf-next v1 0/2] Allow fixed offsets for PTR_TO_CTX | Add tests to ensure PTR_TO_CTX supports fixed offsets for program types
that don't rewrite accesses to it. Ensure that variable offsets and
negative offsets are still rejected. An extra test also checks writing
into ctx with modified offset for syscall progs. Other program types do
not support writes (notably, writable... | {
"author": "Kumar Kartikeya Dwivedi <memxor@gmail.com>",
"date": "Thu, 26 Feb 2026 16:57:25 -0800",
"is_openbsd": false,
"thread_id": "DGPCZB864GLP.2WMKZWOWZOH2K@etsalapatis.com.mbox.gz"
} |
lkml_critique | bpf | Enable pointer modification with constant offsets accumulated in the
register for PTR_TO_CTX for programs where it won't be rewritten. See
patches for details.
Kumar Kartikeya Dwivedi (2):
bpf: Relax fixed offset check for PTR_TO_CTX
selftests/bpf: Add tests for ctx fixed offset support
kernel/bpf/verifier.c ... | null | null | null | [PATCH bpf-next v1 0/2] Allow fixed offsets for PTR_TO_CTX | On Thu Feb 26, 2026 at 7:57 PM EST, Kumar Kartikeya Dwivedi wrote:
Reviewed-by: Emil Tsalapatis <emil@etsalapatis.com> | {
"author": "\"Emil Tsalapatis\" <emil@etsalapatis.com>",
"date": "Thu, 26 Feb 2026 20:38:24 -0500",
"is_openbsd": false,
"thread_id": "DGPCZB864GLP.2WMKZWOWZOH2K@etsalapatis.com.mbox.gz"
} |
lkml_critique | bpf | From: Feng Yang <yangfeng@kylinos.cn>
Calling bpf_lwt_xmit_push_encap will not cause a crash when dst is missing.
Signed-off-by: Feng Yang <yangfeng@kylinos.cn>
---
.../selftests/bpf/progs/verifier_lwt.c | 19 +++++++++++++++++++
1 file changed, 19 insertions(+)
diff --git a/tools/testing/selftests/bpf/progs... | null | null | null | [PATCH v7 bpf-next 2/2] selftests/bpf: Add selftests for the invocation of bpf_lwt_xmit_push_encap | From: Feng Yang <yangfeng@kylinos.cn>
Fix the null pointer dereference issue in bpf_lwt_xmit_push_encap
Changes in v7:
- Use ip6_null_entry to avoid. Thanks, Martin KaFai Lau.
Changes in v6:
- Modify the bpf_lwt_xmit_push_encap function and add selftests for it.
Thanks, Martin KaFai Lau.
- Link to v5: https://lore.... | {
"author": "Feng Yang <yangfeng59949@163.com>",
"date": "Thu, 26 Feb 2026 17:51:54 +0800",
"is_openbsd": false,
"thread_id": "20260226095156.117996-1-yangfeng59949@163.com.mbox.gz"
} |
lkml_critique | bpf | From: Feng Yang <yangfeng@kylinos.cn>
Calling bpf_lwt_xmit_push_encap will not cause a crash when dst is missing.
Signed-off-by: Feng Yang <yangfeng@kylinos.cn>
---
.../selftests/bpf/progs/verifier_lwt.c | 19 +++++++++++++++++++
1 file changed, 19 insertions(+)
diff --git a/tools/testing/selftests/bpf/progs... | null | null | null | [PATCH v7 bpf-next 2/2] selftests/bpf: Add selftests for the invocation of bpf_lwt_xmit_push_encap | From: Feng Yang <yangfeng@kylinos.cn>
The bpf_lwt_xmit_push_encap helper needs to access skb_dst(skb)->dev to
calculate the needed headroom:
err = skb_cow_head(skb,
len + LL_RESERVED_SPACE(skb_dst(skb)->dev));
But skb->_skb_refdst may not be initialized when the skb is set up by
bpf_prog_test_run_skb function... | {
"author": "Feng Yang <yangfeng59949@163.com>",
"date": "Thu, 26 Feb 2026 17:51:55 +0800",
"is_openbsd": false,
"thread_id": "20260226095156.117996-1-yangfeng59949@163.com.mbox.gz"
} |
lkml_critique | bpf | From: Feng Yang <yangfeng@kylinos.cn>
Calling bpf_lwt_xmit_push_encap will not cause a crash when dst is missing.
Signed-off-by: Feng Yang <yangfeng@kylinos.cn>
---
.../selftests/bpf/progs/verifier_lwt.c | 19 +++++++++++++++++++
1 file changed, 19 insertions(+)
diff --git a/tools/testing/selftests/bpf/progs... | null | null | null | [PATCH v7 bpf-next 2/2] selftests/bpf: Add selftests for the invocation of bpf_lwt_xmit_push_encap | Should this set ret to an error code before goto out? At this point
ret is 0 from the earlier convert___skb_to_skb() success path, so the
function returns 0 to the bpf() syscall without ever running the BPF
program.
Every other early exit in bpf_prog_test_run_skb() assigns a negative
errno before goto out, for exampl... | {
"author": "bot+bpf-ci@kernel.org",
"date": "Thu, 26 Feb 2026 10:41:44 +0000 (UTC)",
"is_openbsd": false,
"thread_id": "20260226095156.117996-1-yangfeng59949@163.com.mbox.gz"
} |
lkml_critique | bpf | Hello,
syzbot found the following issue on:
HEAD commit: 32a92f8c8932 Convert more 'alloc_obj' cases to default GFP..
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=10f64152580000
kernel config: https://syzkaller.appspot.com/x/.config?x=2208a171312e89b7
dashboard link: https://... | null | null | null | [syzbot] [bpf?] [trace?] KASAN: slab-use-after-free Read in
bpf_trace_run3 (2) | #syz test
diff --git a/kernel/bpf/syscall.c b/kernel/bpf/syscall.c
index 2d14fb6d0ed0..038bf4436959 100644
--- a/kernel/bpf/syscall.c
+++ b/kernel/bpf/syscall.c
@@ -3783,6 +3783,8 @@ static void bpf_raw_tp_link_release(struct bpf_link *link)
bpf_probe_unregister(raw_tp->btp, raw_tp);
bpf_put_raw_tracepoint(raw_t... | {
"author": "Qing Wang <wangqing7171@gmail.com>",
"date": "Fri, 27 Feb 2026 11:53:41 +0800",
"is_openbsd": false,
"thread_id": "69a13b16.050a0220.305b49.009c.GAE@google.com.mbox.gz"
} |
lkml_critique | bpf | Hello,
syzbot found the following issue on:
HEAD commit: 32a92f8c8932 Convert more 'alloc_obj' cases to default GFP..
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=10f64152580000
kernel config: https://syzkaller.appspot.com/x/.config?x=2208a171312e89b7
dashboard link: https://... | null | null | null | [syzbot] [bpf?] [trace?] KASAN: slab-use-after-free Read in
bpf_trace_run3 (2) | Hello,
syzbot has tested the proposed patch but the reproducer is still triggering an issue:
KASAN: slab-use-after-free Read in bpf_trace_run3
==================================================================
BUG: KASAN: slab-use-after-free in __bpf_trace_run kernel/trace/bpf_trace.c:2075 [inline]
BUG: KASAN: slab-u... | {
"author": "syzbot <syzbot+9ea7c90be2b24e189592@syzkaller.appspotmail.com>",
"date": "Thu, 26 Feb 2026 20:12:02 -0800",
"is_openbsd": false,
"thread_id": "69a13b16.050a0220.305b49.009c.GAE@google.com.mbox.gz"
} |
lkml_critique | bpf | Hello,
syzbot found the following issue on:
HEAD commit: 32a92f8c8932 Convert more 'alloc_obj' cases to default GFP..
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=10f64152580000
kernel config: https://syzkaller.appspot.com/x/.config?x=2208a171312e89b7
dashboard link: https://... | null | null | null | [syzbot] [bpf?] [trace?] KASAN: slab-use-after-free Read in
bpf_trace_run3 (2) | #syz test
diff --git a/kernel/bpf/syscall.c b/kernel/bpf/syscall.c
index 2d14fb6d0ed0..f7a0116c7e46 100644
--- a/kernel/bpf/syscall.c
+++ b/kernel/bpf/syscall.c
@@ -3783,6 +3783,8 @@ static void bpf_raw_tp_link_release(struct bpf_link *link)
bpf_probe_unregister(raw_tp->btp, raw_tp);
bpf_put_raw_tracepoint(raw_t... | {
"author": "Qing Wang <wangqing7171@gmail.com>",
"date": "Fri, 27 Feb 2026 14:17:59 +0800",
"is_openbsd": false,
"thread_id": "69a13b16.050a0220.305b49.009c.GAE@google.com.mbox.gz"
} |
lkml_critique | bpf | Hello,
syzbot found the following issue on:
HEAD commit: 32a92f8c8932 Convert more 'alloc_obj' cases to default GFP..
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=10f64152580000
kernel config: https://syzkaller.appspot.com/x/.config?x=2208a171312e89b7
dashboard link: https://... | null | null | null | [syzbot] [bpf?] [trace?] KASAN: slab-use-after-free Read in
bpf_trace_run3 (2) | Hello,
syzbot has tested the proposed patch but the reproducer is still triggering an issue:
lost connection to test machine
Tested on:
commit: a75cb869 Merge tag 'v7.0-rc1-ksmbd-server-fixes' of gi..
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=12e650ba580000
kernel c... | {
"author": "syzbot <syzbot+9ea7c90be2b24e189592@syzkaller.appspotmail.com>",
"date": "Thu, 26 Feb 2026 22:35:02 -0800",
"is_openbsd": false,
"thread_id": "69a13b16.050a0220.305b49.009c.GAE@google.com.mbox.gz"
} |
lkml_critique | bpf | There exists a race across various map types where the freeing of
special fields (tw, timer, wq, kptr, etc.) can be done eagerly when a
logical delete operation is done on a map value, such that the program
which continues to have access to such a map value can recreate the
fields and cause them to leak.
The set conta... | null | null | null | [PATCH bpf-next v1 0/4] Close race in freeing special fields and map value | There is a race window where BPF hash map elements can leak special
fields if the program with access to the map value recreates these
special fields between the check_and_free_fields done on the map value
and its eventual return to the memory allocator.
Several ways were explored prior to this patch, most notably [0]... | {
"author": "Kumar Kartikeya Dwivedi <memxor@gmail.com>",
"date": "Wed, 25 Feb 2026 10:51:18 -0800",
"is_openbsd": false,
"thread_id": "69a0940c.050a0220.3a55be.0008.GAE@google.com.mbox.gz"
} |
lkml_critique | bpf | There exists a race across various map types where the freeing of
special fields (tw, timer, wq, kptr, etc.) can be done eagerly when a
logical delete operation is done on a map value, such that the program
which continues to have access to such a map value can recreate the
fields and cause them to leak.
The set conta... | null | null | null | [PATCH bpf-next v1 0/4] Close race in freeing special fields and map value | Currently, when use_kmalloc_nolock is false, the freeing of fields for a
local storage selem is done eagerly before waiting for the RCU or RCU
tasks trace grace period to elapse. This opens up a window where the
program which has access to the selem can recreate the fields after the
freeing of fields is done eagerly, c... | {
"author": "Kumar Kartikeya Dwivedi <memxor@gmail.com>",
"date": "Wed, 25 Feb 2026 10:51:19 -0800",
"is_openbsd": false,
"thread_id": "69a0940c.050a0220.3a55be.0008.GAE@google.com.mbox.gz"
} |
lkml_critique | bpf | There exists a race across various map types where the freeing of
special fields (tw, timer, wq, kptr, etc.) can be done eagerly when a
logical delete operation is done on a map value, such that the program
which continues to have access to such a map value can recreate the
fields and cause them to leak.
The set conta... | null | null | null | [PATCH bpf-next v1 0/4] Close race in freeing special fields and map value | This assumption will always hold going forward, hence just remove the
various checks and assume it is true with a comment for the uninformed
reader.
Cc: Paul E. McKenney <paulmck@kernel.org>
Signed-off-by: Kumar Kartikeya Dwivedi <memxor@gmail.com>
---
kernel/bpf/bpf_local_storage.c | 37 +++++++++++++++++------------... | {
"author": "Kumar Kartikeya Dwivedi <memxor@gmail.com>",
"date": "Wed, 25 Feb 2026 10:51:20 -0800",
"is_openbsd": false,
"thread_id": "69a0940c.050a0220.3a55be.0008.GAE@google.com.mbox.gz"
} |
lkml_critique | bpf | There exists a race across various map types where the freeing of
special fields (tw, timer, wq, kptr, etc.) can be done eagerly when a
logical delete operation is done on a map value, such that the program
which continues to have access to such a map value can recreate the
fields and cause them to leak.
The set conta... | null | null | null | [PATCH bpf-next v1 0/4] Close race in freeing special fields and map value | Add a couple of tests to ensure that the refcount drops to zero when we
exercise the race where creation of a special field succeeds the logical
bpf_obj_free_fields done when deleting an element. Prior to previous
changes, the fields would be freed eagerly and repopulate and end up
leaking, causing the reference to not... | {
"author": "Kumar Kartikeya Dwivedi <memxor@gmail.com>",
"date": "Wed, 25 Feb 2026 10:51:21 -0800",
"is_openbsd": false,
"thread_id": "69a0940c.050a0220.3a55be.0008.GAE@google.com.mbox.gz"
} |
lkml_critique | bpf | There exists a race across various map types where the freeing of
special fields (tw, timer, wq, kptr, etc.) can be done eagerly when a
logical delete operation is done on a map value, such that the program
which continues to have access to such a map value can recreate the
fields and cause them to leak.
The set conta... | null | null | null | [PATCH bpf-next v1 0/4] Close race in freeing special fields and map value | On Wed, Feb 25, 2026 at 10:51:20AM -0800, Kumar Kartikeya Dwivedi wrote:
Reviewed-by: Paul E. McKenney <paulmck@kernel.org>
Just be *very* careful with backports. ;-)
Thanx, Paul | {
"author": "\"Paul E. McKenney\" <paulmck@kernel.org>",
"date": "Wed, 25 Feb 2026 10:55:01 -0800",
"is_openbsd": false,
"thread_id": "69a0940c.050a0220.3a55be.0008.GAE@google.com.mbox.gz"
} |
lkml_critique | bpf | There exists a race across various map types where the freeing of
special fields (tw, timer, wq, kptr, etc.) can be done eagerly when a
logical delete operation is done on a map value, such that the program
which continues to have access to such a map value can recreate the
fields and cause them to leak.
The set conta... | null | null | null | [PATCH bpf-next v1 0/4] Close race in freeing special fields and map value | [ ... ]
The smap field is declared __rcu in struct bpf_local_storage_data:
struct bpf_local_storage_map __rcu *smap;
Should this use rcu_dereference_check() to be consistent with the
existing pattern in bpf_selem_free_rcu()?
smap = rcu_dereference_check(SDATA(selem)->smap, 1);
if (smap)
bpf... | {
"author": "bot+bpf-ci@kernel.org",
"date": "Wed, 25 Feb 2026 19:31:45 +0000 (UTC)",
"is_openbsd": false,
"thread_id": "69a0940c.050a0220.3a55be.0008.GAE@google.com.mbox.gz"
} |
lkml_critique | bpf | There exists a race across various map types where the freeing of
special fields (tw, timer, wq, kptr, etc.) can be done eagerly when a
logical delete operation is done on a map value, such that the program
which continues to have access to such a map value can recreate the
fields and cause them to leak.
The set conta... | null | null | null | [PATCH bpf-next v1 0/4] Close race in freeing special fields and map value | syzbot ci has tested the following series
[v1] Close race in freeing special fields and map value
https://lore.kernel.org/all/20260225185121.2057388-1-memxor@gmail.com
* [PATCH bpf-next v1 1/4] bpf: Register dtor for freeing special fields
* [PATCH bpf-next v1 2/4] bpf: Delay freeing fields in local storage
* [PATCH b... | {
"author": "syzbot ci <syzbot+ci3826af8b4f91bf97@syzkaller.appspotmail.com>",
"date": "Thu, 26 Feb 2026 01:31:53 -0800",
"is_openbsd": false,
"thread_id": "69a0940c.050a0220.3a55be.0008.GAE@google.com.mbox.gz"
} |
lkml_critique | bpf | There exists a race across various map types where the freeing of
special fields (tw, timer, wq, kptr, etc.) can be done eagerly when a
logical delete operation is done on a map value, such that the program
which continues to have access to such a map value can recreate the
fields and cause them to leak.
The set conta... | null | null | null | [PATCH bpf-next v1 0/4] Close race in freeing special fields and map value | On Thu, 26 Feb 2026 at 10:31, syzbot ci
<syzbot+ci3826af8b4f91bf97@syzkaller.appspotmail.com> wrote:
This is because the 'ma' is embedded in map struct, so we have an
optimization to speed up map destruction without waiting for pending
callbacks' rcu_barrier() by copying it out. Typically no callbacks are
in progress ... | {
"author": "Kumar Kartikeya Dwivedi <memxor@gmail.com>",
"date": "Thu, 26 Feb 2026 16:05:22 +0100",
"is_openbsd": false,
"thread_id": "69a0940c.050a0220.3a55be.0008.GAE@google.com.mbox.gz"
} |
lkml_critique | bpf | There exists a race across various map types where the freeing of
special fields (tw, timer, wq, kptr, etc.) can be done eagerly when a
logical delete operation is done on a map value, such that the program
which continues to have access to such a map value can recreate the
fields and cause them to leak.
The set conta... | null | null | null | [PATCH bpf-next v1 0/4] Close race in freeing special fields and map value | #syz test
---
diff --git a/include/linux/bpf_mem_alloc.h b/include/linux/bpf_mem_alloc.h
index 7517eaf94ac9..4ce0d27f8ea2 100644
--- a/include/linux/bpf_mem_alloc.h
+++ b/include/linux/bpf_mem_alloc.h
@@ -14,7 +14,7 @@ struct bpf_mem_alloc {
struct obj_cgroup *objcg;
bool percpu;
struct work_struct work;
- void ... | {
"author": "Kumar Kartikeya Dwivedi <memxor@gmail.com>",
"date": "Thu, 26 Feb 2026 09:36:57 -0800",
"is_openbsd": false,
"thread_id": "69a0940c.050a0220.3a55be.0008.GAE@google.com.mbox.gz"
} |
lkml_critique | bpf | There exists a race across various map types where the freeing of
special fields (tw, timer, wq, kptr, etc.) can be done eagerly when a
logical delete operation is done on a map value, such that the program
which continues to have access to such a map value can recreate the
fields and cause them to leak.
The set conta... | null | null | null | [PATCH bpf-next v1 0/4] Close race in freeing special fields and map value | #syz test:
diff --git a/include/linux/bpf_mem_alloc.h b/include/linux/bpf_mem_alloc.h
index 7517eaf94ac9..4ce0d27f8ea2 100644
--- a/include/linux/bpf_mem_alloc.h
+++ b/include/linux/bpf_mem_alloc.h
@@ -14,7 +14,7 @@ struct bpf_mem_alloc {
struct obj_cgroup *objcg;
bool percpu;
struct work_struct work;
- void (*d... | {
"author": "Kumar Kartikeya Dwivedi <memxor@gmail.com>",
"date": "Thu, 26 Feb 2026 10:28:22 -0800",
"is_openbsd": false,
"thread_id": "69a0940c.050a0220.3a55be.0008.GAE@google.com.mbox.gz"
} |
lkml_critique | bpf | There exists a race across various map types where the freeing of
special fields (tw, timer, wq, kptr, etc.) can be done eagerly when a
logical delete operation is done on a map value, such that the program
which continues to have access to such a map value can recreate the
fields and cause them to leak.
The set conta... | null | null | null | [PATCH bpf-next v1 0/4] Close race in freeing special fields and map value | Main things to remember:
-dtor is set fro m map_check_btf because record cannot be inspected in
alloc.
-set dtor for each cache individually.
-free ctx after callbacks are done running.
Signed-off-by: Kumar Kartikeya Dwivedi <memxor@gmail.com>
---
#syz test
include/linux/bpf_mem_alloc.h | 6 ++-
kernel/bpf/hashtab.... | {
"author": "Kumar Kartikeya Dwivedi <memxor@gmail.com>",
"date": "Thu, 26 Feb 2026 10:36:53 -0800",
"is_openbsd": false,
"thread_id": "69a0940c.050a0220.3a55be.0008.GAE@google.com.mbox.gz"
} |
lkml_critique | bpf | Currently, the condition 'page->pp_magic == PP_SIGNATURE' is used to
determine if a page belongs to a page pool. However, with the planned
removal of @pp_magic, we should instead leverage the page_type in struct
page, such as PGTY_netpp, for this purpose.
Introduce and use the page type APIs e.g. PageNetpp(), __SetPa... | null | null | null | [PATCH v4] mm: introduce a new page type for page pool in page type | On Tue, Feb 24, 2026 at 02:13:47PM +0900, Byungchul Park wrote:
Acked-by: Mike Rapoport (Microsoft) <rppt@kernel.org>
--
Sincerely yours,
Mike. | {
"author": "Mike Rapoport <rppt@kernel.org>",
"date": "Wed, 25 Feb 2026 09:19:21 +0200",
"is_openbsd": false,
"thread_id": "aaCVzc2lexW0TiPf@cmpxchg.org.mbox.gz"
} |
lkml_critique | bpf | Currently, the condition 'page->pp_magic == PP_SIGNATURE' is used to
determine if a page belongs to a page pool. However, with the planned
removal of @pp_magic, we should instead leverage the page_type in struct
page, such as PGTY_netpp, for this purpose.
Introduce and use the page type APIs e.g. PageNetpp(), __SetPa... | null | null | null | [PATCH v4] mm: introduce a new page type for page pool in page type | On Tue, Feb 24, 2026 at 02:13:47PM +0900, Byungchul Park wrote:
You can gate that on is_check_pages_enabled(), to avoid a new branch
in the !debug case.
Otherwise, the MM bits look good to me!
Acked-by: Johannes Weiner <hannes@cmpxchg.org> | {
"author": "Johannes Weiner <hannes@cmpxchg.org>",
"date": "Thu, 26 Feb 2026 13:49:49 -0500",
"is_openbsd": false,
"thread_id": "aaCVzc2lexW0TiPf@cmpxchg.org.mbox.gz"
} |
lkml_critique | bpf | Fix the warning recently exploited by commit 4ab17e762b34 ("LoongArch:
BPF: Use BPF prog pack allocator"):
BUG: using smp_processor_id() in preemptible [00000000] code: systemd/1
caller is larch_insn_text_copy+0x40/0xf0
Simply changing it to raw_smp_processor_id() is not enough: if preempt
and CPU hotplug hap... | null | null | null | [PATCH] LoongArch: Fix calling smp_processor_id() in preemptible code | Hi, Ruoyao,
On Wed, Feb 25, 2026 at 10:15 PM Xi Ruoyao <xry111@xry111.site> wrote:
I think we should keep the old function here, because it can help
others to catch new bugs if the code is refactored in future.
Huacai | {
"author": "Huacai Chen <chenhuacai@kernel.org>",
"date": "Thu, 26 Feb 2026 17:08:28 +0800",
"is_openbsd": false,
"thread_id": "CAAhV-H5k435VV31F1BBjJ_9tVY_0JdEnUVwJC-cD6Y6rrztsEw@mail.gmail.com.mbox.gz"
} |
lkml_critique | bpf | Fix the warning recently exploited by commit 4ab17e762b34 ("LoongArch:
BPF: Use BPF prog pack allocator"):
BUG: using smp_processor_id() in preemptible [00000000] code: systemd/1
caller is larch_insn_text_copy+0x40/0xf0
Simply changing it to raw_smp_processor_id() is not enough: if preempt
and CPU hotplug hap... | null | null | null | [PATCH] LoongArch: Fix calling smp_processor_id() in preemptible code | On Thu, 2026-02-26 at 17:08 +0800, Huacai Chen wrote:
Hmm, IIUC using smp_processor_id will still trigger the warning as we've
only acquired the cpu hotplug lock, instead of disabling the preemption
completely.
How about adding a lockdep_assert_cpus_held() in this function with an
explanatory comment?
--
Xi Ruoyao ... | {
"author": "Xi Ruoyao <xry111@xry111.site>",
"date": "Thu, 26 Feb 2026 17:31:58 +0800",
"is_openbsd": false,
"thread_id": "CAAhV-H5k435VV31F1BBjJ_9tVY_0JdEnUVwJC-cD6Y6rrztsEw@mail.gmail.com.mbox.gz"
} |
lkml_critique | bpf | Fix the warning recently exploited by commit 4ab17e762b34 ("LoongArch:
BPF: Use BPF prog pack allocator"):
BUG: using smp_processor_id() in preemptible [00000000] code: systemd/1
caller is larch_insn_text_copy+0x40/0xf0
Simply changing it to raw_smp_processor_id() is not enough: if preempt
and CPU hotplug hap... | null | null | null | [PATCH] LoongArch: Fix calling smp_processor_id() in preemptible code | On Thu, Feb 26, 2026 at 5:32 PM Xi Ruoyao <xry111@xry111.site> wrote:
Does this context really need preemption disabled? Why
lockdep_assert_cpus_held() can silence the warning?
Huacai | {
"author": "Huacai Chen <chenhuacai@kernel.org>",
"date": "Thu, 26 Feb 2026 17:49:04 +0800",
"is_openbsd": false,
"thread_id": "CAAhV-H5k435VV31F1BBjJ_9tVY_0JdEnUVwJC-cD6Y6rrztsEw@mail.gmail.com.mbox.gz"
} |
lkml_critique | bpf | Fix the warning recently exploited by commit 4ab17e762b34 ("LoongArch:
BPF: Use BPF prog pack allocator"):
BUG: using smp_processor_id() in preemptible [00000000] code: systemd/1
caller is larch_insn_text_copy+0x40/0xf0
Simply changing it to raw_smp_processor_id() is not enough: if preempt
and CPU hotplug hap... | null | null | null | [PATCH] LoongArch: Fix calling smp_processor_id() in preemptible code | On Thu, 2026-02-26 at 17:49 +0800, Huacai Chen wrote:
I don't think we really need to disable preemption here. If a
preemption happens here we'll just invoke stop_machine from a different
cpu, and it will still work as long as copy.cpu doesn't get hot removed
(this is guaranteed by the cpus read lock).
If my underst... | {
"author": "Xi Ruoyao <xry111@xry111.site>",
"date": "Thu, 26 Feb 2026 18:05:13 +0800",
"is_openbsd": false,
"thread_id": "CAAhV-H5k435VV31F1BBjJ_9tVY_0JdEnUVwJC-cD6Y6rrztsEw@mail.gmail.com.mbox.gz"
} |
lkml_critique | bpf | Fix the warning recently exploited by commit 4ab17e762b34 ("LoongArch:
BPF: Use BPF prog pack allocator"):
BUG: using smp_processor_id() in preemptible [00000000] code: systemd/1
caller is larch_insn_text_copy+0x40/0xf0
Simply changing it to raw_smp_processor_id() is not enough: if preempt
and CPU hotplug hap... | null | null | null | [PATCH] LoongArch: Fix calling smp_processor_id() in preemptible code | On Thu, Feb 26, 2026 at 6:05 PM Xi Ruoyao <xry111@xry111.site> wrote:
Yes, I think so.
I don't like the RISC-V version, it is hard to understand.
OK, then please add a lockdep_assert_cpus_held().
Huacai | {
"author": "Huacai Chen <chenhuacai@kernel.org>",
"date": "Thu, 26 Feb 2026 18:16:23 +0800",
"is_openbsd": false,
"thread_id": "CAAhV-H5k435VV31F1BBjJ_9tVY_0JdEnUVwJC-cD6Y6rrztsEw@mail.gmail.com.mbox.gz"
} |
lkml_critique | bpf | Global subprogs are currently not allowed to return void. Adjust
verifier logic to allow global functions with a void return type.
Exception callbacks are excluded from this change, and still require
a scalar return type.
Adding additional logic for void globals significantly complicates
check_return_code(), mainly b... | null | null | null | [PATCH bpf-next v4 0/4] bpf: Allow void return type for global subprogs | Factor the return value range calculation logic in check_return_code
out of the function in preparation for separating the return value
validation logic for BPF_EXIT and bpf_throw().
Signed-off-by: Emil Tsalapatis <emil@etsalapatis.com>
---
kernel/bpf/verifier.c | 205 +++++++++++++++++++++++-------------------
1 fil... | {
"author": "Emil Tsalapatis <emil@etsalapatis.com>",
"date": "Tue, 24 Feb 2026 22:33:53 -0500",
"is_openbsd": false,
"thread_id": "DGP6JAD9617O.1TN5OOID1E4Z@etsalapatis.com.mbox.gz"
} |
lkml_critique | bpf | Global subprogs are currently not allowed to return void. Adjust
verifier logic to allow global functions with a void return type.
Exception callbacks are excluded from this change, and still require
a scalar return type.
Adding additional logic for void globals significantly complicates
check_return_code(), mainly b... | null | null | null | [PATCH bpf-next v4 0/4] bpf: Allow void return type for global subprogs | Both bpf_throw() and BPF_EXIT use the same return value validation
function, even though their validation logic is slightly different.
Using the same code path for both complicates the logic and makes
it difficult to follow, so create a new check_throw_return_code()
function just for bpf_throw()-based exits. Also facto... | {
"author": "Emil Tsalapatis <emil@etsalapatis.com>",
"date": "Tue, 24 Feb 2026 22:33:54 -0500",
"is_openbsd": false,
"thread_id": "DGP6JAD9617O.1TN5OOID1E4Z@etsalapatis.com.mbox.gz"
} |
lkml_critique | bpf | Global subprogs are currently not allowed to return void. Adjust
verifier logic to allow global functions with a void return type.
Exception callbacks are excluded from this change, and still require
a scalar return type.
Adding additional logic for void globals significantly complicates
check_return_code(), mainly b... | null | null | null | [PATCH bpf-next v4 0/4] bpf: Allow void return type for global subprogs | Global subprogs are currently not allowed to return void. Adjust
verifier logic to allow global functions with a void return type.
Signed-off-by: Emil Tsalapatis <emil@etsalapatis.com>
---
kernel/bpf/btf.c | 7 ++-
kernel/bpf/verifier.c | 59 +++++++++++++++++--
.... | {
"author": "Emil Tsalapatis <emil@etsalapatis.com>",
"date": "Tue, 24 Feb 2026 22:33:55 -0500",
"is_openbsd": false,
"thread_id": "DGP6JAD9617O.1TN5OOID1E4Z@etsalapatis.com.mbox.gz"
} |
lkml_critique | bpf | Global subprogs are currently not allowed to return void. Adjust
verifier logic to allow global functions with a void return type.
Exception callbacks are excluded from this change, and still require
a scalar return type.
Adding additional logic for void globals significantly complicates
check_return_code(), mainly b... | null | null | null | [PATCH bpf-next v4 0/4] bpf: Allow void return type for global subprogs | Add additional testing for void global functions. The tests
ensure that calls to void global functions properly keep
R0 invalid. Also make sure that exception callbacks still
require a return value.
Signed-off-by: Emil Tsalapatis <emil@etsalapatis.com>
---
.../selftests/bpf/prog_tests/exceptions.c | 1 +
.../sel... | {
"author": "Emil Tsalapatis <emil@etsalapatis.com>",
"date": "Tue, 24 Feb 2026 22:33:56 -0500",
"is_openbsd": false,
"thread_id": "DGP6JAD9617O.1TN5OOID1E4Z@etsalapatis.com.mbox.gz"
} |
lkml_critique | bpf | Global subprogs are currently not allowed to return void. Adjust
verifier logic to allow global functions with a void return type.
Exception callbacks are excluded from this change, and still require
a scalar return type.
Adding additional logic for void globals significantly complicates
check_return_code(), mainly b... | null | null | null | [PATCH bpf-next v4 0/4] bpf: Allow void return type for global subprogs | [ ... ]
Is the comment above this condition a bit misleading? It describes
why BPF_LSM_CGROUP programs need validation, but the condition
itself handles the opposite case -- non-CGROUP void LSM programs
that skip validation.
A reader would naturally associate the comment with the code that
follows it, and could be ... | {
"author": "bot+bpf-ci@kernel.org",
"date": "Wed, 25 Feb 2026 04:23:34 +0000 (UTC)",
"is_openbsd": false,
"thread_id": "DGP6JAD9617O.1TN5OOID1E4Z@etsalapatis.com.mbox.gz"
} |
lkml_critique | bpf | Global subprogs are currently not allowed to return void. Adjust
verifier logic to allow global functions with a void return type.
Exception callbacks are excluded from this change, and still require
a scalar return type.
Adding additional logic for void globals significantly complicates
check_return_code(), mainly b... | null | null | null | [PATCH bpf-next v4 0/4] bpf: Allow void return type for global subprogs | On Tue, 2026-02-24 at 22:33 -0500, Emil Tsalapatis wrote:
I like this refactoring, thank you! The logic seem to be preserved.
A few nits below.
Acked-by: Eduard Zingerman <eddyz87@gmail.com>
Nit: maybe make this function bool?
It does not seem to return any errors.
Tangential to this refactoring. Looking at ... | {
"author": "Eduard Zingerman <eddyz87@gmail.com>",
"date": "Wed, 25 Feb 2026 15:31:48 -0800",
"is_openbsd": false,
"thread_id": "DGP6JAD9617O.1TN5OOID1E4Z@etsalapatis.com.mbox.gz"
} |
lkml_critique | bpf | Global subprogs are currently not allowed to return void. Adjust
verifier logic to allow global functions with a void return type.
Exception callbacks are excluded from this change, and still require
a scalar return type.
Adding additional logic for void globals significantly complicates
check_return_code(), mainly b... | null | null | null | [PATCH bpf-next v4 0/4] bpf: Allow void return type for global subprogs | On Tue Feb 24, 2026 at 11:23 PM EST, bot+bpf-ci wrote:
I mildly disagree with the AI here, I think it's a small leap from
reading that BPF_LSM_CGROUP void programs must still be verified to
understanding why we only return 0 for non-BPF_LSM_CGROUP programs. We
also refer to return_retval_range() for a more definitive ... | {
"author": "\"Emil Tsalapatis\" <emil@etsalapatis.com>",
"date": "Wed, 25 Feb 2026 20:48:23 -0500",
"is_openbsd": false,
"thread_id": "DGP6JAD9617O.1TN5OOID1E4Z@etsalapatis.com.mbox.gz"
} |
lkml_critique | bpf | Global subprogs are currently not allowed to return void. Adjust
verifier logic to allow global functions with a void return type.
Exception callbacks are excluded from this change, and still require
a scalar return type.
Adding additional logic for void globals significantly complicates
check_return_code(), mainly b... | null | null | null | [PATCH bpf-next v4 0/4] bpf: Allow void return type for global subprogs | On Tue, 2026-02-24 at 22:33 -0500, Emil Tsalapatis wrote:
I think I suggested the wrong split.
A better border would be between checking return code for subprograms
and for programs. Wdyt about the following branch:
https://github.com/eddyz87/bpf/tree/check-subprogram-return-code
(fexit_bpf2bpf/freplace_void fails,
b... | {
"author": "Eduard Zingerman <eddyz87@gmail.com>",
"date": "Wed, 25 Feb 2026 20:56:23 -0800",
"is_openbsd": false,
"thread_id": "DGP6JAD9617O.1TN5OOID1E4Z@etsalapatis.com.mbox.gz"
} |
lkml_critique | bpf | Global subprogs are currently not allowed to return void. Adjust
verifier logic to allow global functions with a void return type.
Exception callbacks are excluded from this change, and still require
a scalar return type.
Adding additional logic for void globals significantly complicates
check_return_code(), mainly b... | null | null | null | [PATCH bpf-next v4 0/4] bpf: Allow void return type for global subprogs | On Wed Feb 25, 2026 at 11:56 PM EST, Eduard Zingerman wrote:
I see, yeah this split avoids duplication and removes the constant
is_subprog checks. I'm going through the two patches rn and will
send out the new version with them. | {
"author": "\"Emil Tsalapatis\" <emil@etsalapatis.com>",
"date": "Thu, 26 Feb 2026 15:35:22 -0500",
"is_openbsd": false,
"thread_id": "DGP6JAD9617O.1TN5OOID1E4Z@etsalapatis.com.mbox.gz"
} |
lkml_critique | bpf | Global subprogs are currently not allowed to return void. Adjust
verifier logic to allow global functions with a void return type.
Exception callbacks are excluded from this change, and still require
a scalar return type.
Adding additional logic for void globals significantly complicates
check_return_code(), mainly b... | null | null | null | [PATCH bpf-next v4 0/4] bpf: Allow void return type for global subprogs | On Wed Feb 25, 2026 at 6:31 PM EST, Eduard Zingerman wrote:
Annoyingly, there is a _single_ -EOPNOTSUPP for TRACING programs that do
not have one of 6 attach types (FENTRY/FEXIT/FSESSION/RAW_TP/MODIFY_RETURN/TRACE_ITER).
IIUC This is actually an exhaustive list of all attach types for a TRACING program, so the
-EOPN... | {
"author": "\"Emil Tsalapatis\" <emil@etsalapatis.com>",
"date": "Thu, 26 Feb 2026 16:17:01 -0500",
"is_openbsd": false,
"thread_id": "DGP6JAD9617O.1TN5OOID1E4Z@etsalapatis.com.mbox.gz"
} |
lkml_critique | bpf | This small set implements fsession support for LoongArch.
Patch 1 introduces a helper named emit_store_stack_imm64().
Patch 2 implements fsession support.
Patch 3 enable fsession selftests on LoongArch.
Hengqi Chen (3):
LoongArch: BPF: Introduce emit_store_stack_imm64() helper
LoongArch: BPF: Add fsession support... | null | null | null | [PATCH 0/3] bpf: fsession support for LoongArch | Introduce a helper to store 64-bit immediate on the trampoline stack.
The helper will be used in the next patch. Also refactor the existing
code to use this helper.
Signed-off-by: Hengqi Chen <hengqi.chen@gmail.com>
---
arch/loongarch/net/bpf_jit.c | 24 +++++++++++++-----------
1 file changed, 13 insertions(+), 11 d... | {
"author": "Hengqi Chen <hengqi.chen@gmail.com>",
"date": "Thu, 26 Feb 2026 06:59:49 +0000",
"is_openbsd": false,
"thread_id": "20260226065952.4082859-1-hengqi.chen@gmail.com.mbox.gz"
} |
lkml_critique | bpf | This small set implements fsession support for LoongArch.
Patch 1 introduces a helper named emit_store_stack_imm64().
Patch 2 implements fsession support.
Patch 3 enable fsession selftests on LoongArch.
Hengqi Chen (3):
LoongArch: BPF: Introduce emit_store_stack_imm64() helper
LoongArch: BPF: Add fsession support... | null | null | null | [PATCH 0/3] bpf: fsession support for LoongArch | Implement BPF_TRACE_FSESSION support in LoongArch BPF JIT.
The logic here is almost identical to what has been done in
RISC-V JIT.
The key changes are:
- Allocate stack space for function meta and session cookies
- Introduce invoke_bpf() as a wrapper around invoke_bpf_prog()
that populates session cookies befo... | {
"author": "Hengqi Chen <hengqi.chen@gmail.com>",
"date": "Thu, 26 Feb 2026 06:59:50 +0000",
"is_openbsd": false,
"thread_id": "20260226065952.4082859-1-hengqi.chen@gmail.com.mbox.gz"
} |
lkml_critique | bpf | This small set implements fsession support for LoongArch.
Patch 1 introduces a helper named emit_store_stack_imm64().
Patch 2 implements fsession support.
Patch 3 enable fsession selftests on LoongArch.
Hengqi Chen (3):
LoongArch: BPF: Introduce emit_store_stack_imm64() helper
LoongArch: BPF: Add fsession support... | null | null | null | [PATCH 0/3] bpf: fsession support for LoongArch | Now that the LoongArch JIT supports BPF_TRACE_FSESSION, allow
the fsession-related tests to run on LoongArch.
$ ./test_progs -a fsession_test,get_func_args_test,get_func_ip_test
#136/1 fsession_test/fsession_test:OK
#136/2 fsession_test/fsession_reattach:OK
#136/3 fsession_test/fsession_cookie:OK... | {
"author": "Hengqi Chen <hengqi.chen@gmail.com>",
"date": "Thu, 26 Feb 2026 06:59:51 +0000",
"is_openbsd": false,
"thread_id": "20260226065952.4082859-1-hengqi.chen@gmail.com.mbox.gz"
} |
lkml_critique | bpf | This small set implements fsession support for LoongArch.
Patch 1 introduces a helper named emit_store_stack_imm64().
Patch 2 implements fsession support.
Patch 3 enable fsession selftests on LoongArch.
Hengqi Chen (3):
LoongArch: BPF: Introduce emit_store_stack_imm64() helper
LoongArch: BPF: Add fsession support... | null | null | null | [PATCH 0/3] bpf: fsession support for LoongArch | On Wed, Feb 25, 2026 at 11:00 PM Hengqi Chen <hengqi.chen@gmail.com> wrote:
[root@fedora bpf]# ./test_progs -a
fsession_test,get_func_args_test,get_func_ip_test
#135/1 fsession_test/fsession_test:OK
#135/2 fsession_test/fsession_reattach:OK
#135/3 fsession_test/fsession_cookie:OK
#135 fsession_test:OK
#138 ... | {
"author": "Vincent Li <vincent.mc.li@gmail.com>",
"date": "Thu, 26 Feb 2026 17:59:44 -0800",
"is_openbsd": false,
"thread_id": "20260226065952.4082859-1-hengqi.chen@gmail.com.mbox.gz"
} |
lkml_critique | bpf | This patchset performs two changes in the bpf_fib_lookup() helper:
1. Patch #6: Aligns IPv6 with IPv4 with regards to output route lookups
(i.e., BPF_FIB_LOOKUP_OUTPUT) so that it always resolves a route whose
nexthop device matches the specified oif.
2. Patch #8: Allows output route lookups for IPv6 link-local addre... | null | null | null | [RFC PATCH bpf-next 0/9] bpf: fib_lookup: IPv6 output routes enhancements | Subsequent patches will add tests for output routes (i.e.,
BPF_FIB_LOOKUP_OUTPUT). In these tests, the bpf_fib_lookup() helper will
be called with different interface indexes to make sure it is resolving
the correct route. Make it easier to add such tests by predetermining
the interface indexes.
Reviewed-by: Petr Mach... | {
"author": "Ido Schimmel <idosch@nvidia.com>",
"date": "Thu, 26 Feb 2026 09:59:55 +0200",
"is_openbsd": false,
"thread_id": "bf293e1c-b2d9-4ef8-87c5-579e523d74de@gmail.com.mbox.gz"
} |
lkml_critique | bpf | This patchset performs two changes in the bpf_fib_lookup() helper:
1. Patch #6: Aligns IPv6 with IPv4 with regards to output route lookups
(i.e., BPF_FIB_LOOKUP_OUTPUT) so that it always resolves a route whose
nexthop device matches the specified oif.
2. Patch #8: Allows output route lookups for IPv6 link-local addre... | null | null | null | [RFC PATCH bpf-next 0/9] bpf: fib_lookup: IPv6 output routes enhancements | Currently, the bpf_fib_lookup() helper is only called with the ifindex
of veth1. In preparation for calling the bpf_fib_lookup() helper with
the ifindex of veth2, enable forwarding on this device.
Reviewed-by: Petr Machata <petrm@nvidia.com>
Signed-off-by: Ido Schimmel <idosch@nvidia.com>
---
tools/testing/selftests/... | {
"author": "Ido Schimmel <idosch@nvidia.com>",
"date": "Thu, 26 Feb 2026 09:59:56 +0200",
"is_openbsd": false,
"thread_id": "bf293e1c-b2d9-4ef8-87c5-579e523d74de@gmail.com.mbox.gz"
} |
lkml_critique | bpf | This patchset performs two changes in the bpf_fib_lookup() helper:
1. Patch #6: Aligns IPv6 with IPv4 with regards to output route lookups
(i.e., BPF_FIB_LOOKUP_OUTPUT) so that it always resolves a route whose
nexthop device matches the specified oif.
2. Patch #8: Allows output route lookups for IPv6 link-local addre... | null | null | null | [RFC PATCH bpf-next 0/9] bpf: fib_lookup: IPv6 output routes enhancements | Currently, the ifindex passed to the bpf_fib_lookup() helper is always
that of veth1. In preparation for output route tests, allow test cases
to specify an alternative ifindex. Default to that of veth1 when ifindex
is not specified.
Reviewed-by: Petr Machata <petrm@nvidia.com>
Signed-off-by: Ido Schimmel <idosch@nvidi... | {
"author": "Ido Schimmel <idosch@nvidia.com>",
"date": "Thu, 26 Feb 2026 09:59:57 +0200",
"is_openbsd": false,
"thread_id": "bf293e1c-b2d9-4ef8-87c5-579e523d74de@gmail.com.mbox.gz"
} |
lkml_critique | bpf | This patchset performs two changes in the bpf_fib_lookup() helper:
1. Patch #6: Aligns IPv6 with IPv4 with regards to output route lookups
(i.e., BPF_FIB_LOOKUP_OUTPUT) so that it always resolves a route whose
nexthop device matches the specified oif.
2. Patch #8: Allows output route lookups for IPv6 link-local addre... | null | null | null | [RFC PATCH bpf-next 0/9] bpf: fib_lookup: IPv6 output routes enhancements | In preparation for output route tests, allow test cases to specify an
expected ifindex and verify that it matches the ifindex of the nexthop
device. Default to not verifying the ifindex.
Reviewed-by: Petr Machata <petrm@nvidia.com>
Signed-off-by: Ido Schimmel <idosch@nvidia.com>
---
tools/testing/selftests/bpf/prog_t... | {
"author": "Ido Schimmel <idosch@nvidia.com>",
"date": "Thu, 26 Feb 2026 09:59:58 +0200",
"is_openbsd": false,
"thread_id": "bf293e1c-b2d9-4ef8-87c5-579e523d74de@gmail.com.mbox.gz"
} |
lkml_critique | bpf | This patchset performs two changes in the bpf_fib_lookup() helper:
1. Patch #6: Aligns IPv6 with IPv4 with regards to output route lookups
(i.e., BPF_FIB_LOOKUP_OUTPUT) so that it always resolves a route whose
nexthop device matches the specified oif.
2. Patch #8: Allows output route lookups for IPv6 link-local addre... | null | null | null | [RFC PATCH bpf-next 0/9] bpf: fib_lookup: IPv6 output routes enhancements | When the BPF_FIB_LOOKUP_OUTPUT flag is passed to the bpf_fib_lookup()
helper the expectation is that the helper will resolve the most specific
route whose nexthop device matches the specified ifindex. This is useful
when we already know the nexthop device, but need the helper to resolve
the destination MAC.
Add test c... | {
"author": "Ido Schimmel <idosch@nvidia.com>",
"date": "Thu, 26 Feb 2026 09:59:59 +0200",
"is_openbsd": false,
"thread_id": "bf293e1c-b2d9-4ef8-87c5-579e523d74de@gmail.com.mbox.gz"
} |
lkml_critique | bpf | This patchset performs two changes in the bpf_fib_lookup() helper:
1. Patch #6: Aligns IPv6 with IPv4 with regards to output route lookups
(i.e., BPF_FIB_LOOKUP_OUTPUT) so that it always resolves a route whose
nexthop device matches the specified oif.
2. Patch #8: Allows output route lookups for IPv6 link-local addre... | null | null | null | [RFC PATCH bpf-next 0/9] bpf: fib_lookup: IPv6 output routes enhancements | Currently, output route lookups behave differently between IPv4 and IPv6
when performed via the bpf_fib_lookup() helper with the
BPF_FIB_LOOKUP_OUTPUT flag.
IPv4 honors the oif and resolves the most specific route whose nexthop
device matches the oif. If no such route exists, an error is returned.
On the other hand, ... | {
"author": "Ido Schimmel <idosch@nvidia.com>",
"date": "Thu, 26 Feb 2026 10:00:00 +0200",
"is_openbsd": false,
"thread_id": "bf293e1c-b2d9-4ef8-87c5-579e523d74de@gmail.com.mbox.gz"
} |
lkml_critique | bpf | This patchset performs two changes in the bpf_fib_lookup() helper:
1. Patch #6: Aligns IPv6 with IPv4 with regards to output route lookups
(i.e., BPF_FIB_LOOKUP_OUTPUT) so that it always resolves a route whose
nexthop device matches the specified oif.
2. Patch #8: Allows output route lookups for IPv6 link-local addre... | null | null | null | [RFC PATCH bpf-next 0/9] bpf: fib_lookup: IPv6 output routes enhancements | In a similar fashion to the IPv4 output route tests, add equivalent IPv6
tests.
Output without "bpf: fib_lookup: Honor oif in IPv6 output route
lookups":
# ./test_progs -a fib_lookup
[...]
Testing IPv6 output route, without source, via second device test_fib_lookup:PASS:bpf_prog_test_run_opts 0 nsec
test_fib_look... | {
"author": "Ido Schimmel <idosch@nvidia.com>",
"date": "Thu, 26 Feb 2026 10:00:01 +0200",
"is_openbsd": false,
"thread_id": "bf293e1c-b2d9-4ef8-87c5-579e523d74de@gmail.com.mbox.gz"
} |
lkml_critique | bpf | This patchset performs two changes in the bpf_fib_lookup() helper:
1. Patch #6: Aligns IPv6 with IPv4 with regards to output route lookups
(i.e., BPF_FIB_LOOKUP_OUTPUT) so that it always resolves a route whose
nexthop device matches the specified oif.
2. Patch #8: Allows output route lookups for IPv6 link-local addre... | null | null | null | [RFC PATCH bpf-next 0/9] bpf: fib_lookup: IPv6 output routes enhancements | Currently, the bpf_fib_lookup() helper returns an error when IPv6
link-local addresses are used. This is the correct behavior from input
perspective as such packets should not be forwarded, but the helper can
also be used to perform a lookup from output perspective (i.e., with
BPF_FIB_LOOKUP_OUTPUT). In this case, pass... | {
"author": "Ido Schimmel <idosch@nvidia.com>",
"date": "Thu, 26 Feb 2026 10:00:02 +0200",
"is_openbsd": false,
"thread_id": "bf293e1c-b2d9-4ef8-87c5-579e523d74de@gmail.com.mbox.gz"
} |
lkml_critique | bpf | This patchset performs two changes in the bpf_fib_lookup() helper:
1. Patch #6: Aligns IPv6 with IPv4 with regards to output route lookups
(i.e., BPF_FIB_LOOKUP_OUTPUT) so that it always resolves a route whose
nexthop device matches the specified oif.
2. Patch #8: Allows output route lookups for IPv6 link-local addre... | null | null | null | [RFC PATCH bpf-next 0/9] bpf: fib_lookup: IPv6 output routes enhancements | Add tests that verify that bpf_fib_lookup() is able to resolve the
destination MAC for an IPv6 link-local address when specifying the
BPF_FIB_LOOKUP_OUTPUT flag.
Output without "bpf: fib_lookup: Allow output lookups for IPv6
link-local addresses":
# ./test_progs -a fib_lookup
[...]
Testing IPv6 output route, link-... | {
"author": "Ido Schimmel <idosch@nvidia.com>",
"date": "Thu, 26 Feb 2026 10:00:03 +0200",
"is_openbsd": false,
"thread_id": "bf293e1c-b2d9-4ef8-87c5-579e523d74de@gmail.com.mbox.gz"
} |
lkml_critique | bpf | This patchset performs two changes in the bpf_fib_lookup() helper:
1. Patch #6: Aligns IPv6 with IPv4 with regards to output route lookups
(i.e., BPF_FIB_LOOKUP_OUTPUT) so that it always resolves a route whose
nexthop device matches the specified oif.
2. Patch #8: Allows output route lookups for IPv6 link-local addre... | null | null | null | [RFC PATCH bpf-next 0/9] bpf: fib_lookup: IPv6 output routes enhancements | The fix itself looks correct. Since this addresses a bug that has been
present since the original bpf_fib_lookup helper was introduced, should
this carry a Fixes tag?
Fixes: 87f5fc7e48dd ("bpf: Provide helper to do forwarding lookups in kernel FIB table")
---
AI reviewed your patch. Please fix the bug or email reply... | {
"author": "bot+bpf-ci@kernel.org",
"date": "Thu, 26 Feb 2026 08:41:16 +0000 (UTC)",
"is_openbsd": false,
"thread_id": "bf293e1c-b2d9-4ef8-87c5-579e523d74de@gmail.com.mbox.gz"
} |
lkml_critique | bpf | This patchset performs two changes in the bpf_fib_lookup() helper:
1. Patch #6: Aligns IPv6 with IPv4 with regards to output route lookups
(i.e., BPF_FIB_LOOKUP_OUTPUT) so that it always resolves a route whose
nexthop device matches the specified oif.
2. Patch #8: Allows output route lookups for IPv6 link-local addre... | null | null | null | [RFC PATCH bpf-next 0/9] bpf: fib_lookup: IPv6 output routes enhancements | On Thu, Feb 26, 2026 at 12:00 AM Ido Schimmel <idosch@nvidia.com> wrote:
tbh I would send the whole thing through bpf or net trees. | {
"author": "Alexei Starovoitov <alexei.starovoitov@gmail.com>",
"date": "Thu, 26 Feb 2026 09:14:51 -0800",
"is_openbsd": false,
"thread_id": "bf293e1c-b2d9-4ef8-87c5-579e523d74de@gmail.com.mbox.gz"
} |
lkml_critique | bpf | The probe_user selftest attaches ksyscall hooks for connect() (and
socketcall() on s390). Historically it could corrupt other tests
calling connect() in parallel, causing flaky failures.
This series confines the instrumentation to the current test process only,
and then drops the serial restriction and removes the sta... | null | null | null | [PATCH v2 0/2] selftests/bpf: make probe_user safe for parallel runs | The test installs a kprobe on __sys_connect and checks that
bpf_probe_write_user() can modify the syscall argument. However, any
concurrent thread in any other test that calls connect() will also
trigger the kprobe and have its sockaddr silently overwritten, causing
flaky failures in unrelated tests.
Constrain the hoo... | {
"author": "Sun Jian <sun.jian.kdev@gmail.com>",
"date": "Thu, 26 Feb 2026 17:31:31 +0800",
"is_openbsd": false,
"thread_id": "20260226093132.437206-3-sun.jian.kdev@gmail.com.mbox.gz"
} |
lkml_critique | bpf | The probe_user selftest attaches ksyscall hooks for connect() (and
socketcall() on s390). Historically it could corrupt other tests
calling connect() in parallel, causing flaky failures.
This series confines the instrumentation to the current test process only,
and then drops the serial restriction and removes the sta... | null | null | null | [PATCH v2 0/2] selftests/bpf: make probe_user safe for parallel runs | Patch 1/2 added PID filtering to the probe_user BPF program to avoid
cross-test interference from the global connect() hooks.
With the interference removed, drop the serial_ prefix and remove the
stale TODO comment so the test can run in parallel.
Tested:
./test_progs -t probe_user -v
./test_progs -j$(nproc) -t p... | {
"author": "Sun Jian <sun.jian.kdev@gmail.com>",
"date": "Thu, 26 Feb 2026 17:31:32 +0800",
"is_openbsd": false,
"thread_id": "20260226093132.437206-3-sun.jian.kdev@gmail.com.mbox.gz"
} |
lkml_critique | bpf | check_helper_call() prints the error message for every
env->cur_state->active* element when calling a sleepable helper.
Consolidate all of them into a single print statement.
The check for env->cur_state->active_locks was not part of the removed
print statements and will not be triggered with the consolidated print
as... | null | null | null | [PATCH bpf-next 1/2] bpf: Consolidate sleepable checks in check_helper_call() | check_kfunc_call() has multiple scattered checks that reject sleepable
kfuncs in various non-sleepable contexts (RCU, preempt-disabled, IRQ-
disabled). These are the same conditions already checked by
in_sleepable_context(), so replace them with a single consolidated
check.
This also simplifies the preempt lock tracki... | {
"author": "Puranjay Mohan <puranjay@kernel.org>",
"date": "Wed, 25 Feb 2026 05:49:49 -0800",
"is_openbsd": false,
"thread_id": "4729132fbd2544cbe3269ae0ae32610a4a0fca81.camel@gmail.com.mbox.gz"
} |
lkml_critique | bpf | check_helper_call() prints the error message for every
env->cur_state->active* element when calling a sleepable helper.
Consolidate all of them into a single print statement.
The check for env->cur_state->active_locks was not part of the removed
print statements and will not be triggered with the consolidated print
as... | null | null | null | [PATCH bpf-next 1/2] bpf: Consolidate sleepable checks in check_helper_call() | Puranjay Mohan <puranjay@kernel.org> writes:
nit: it may be a little bit more readable if we put this check
separately, not in else if, so we get the next structure:
```
if (rcu_lock) {
} else if (rcu_unlock) {
} else if (preempt_disable) {
} else if (preempt_enable) {
}
if (sleepable && !in_sleepable_context(env... | {
"author": "Mykyta Yatsenko <mykyta.yatsenko5@gmail.com>",
"date": "Wed, 25 Feb 2026 18:54:21 +0000",
"is_openbsd": false,
"thread_id": "4729132fbd2544cbe3269ae0ae32610a4a0fca81.camel@gmail.com.mbox.gz"
} |
lkml_critique | bpf | check_helper_call() prints the error message for every
env->cur_state->active* element when calling a sleepable helper.
Consolidate all of them into a single print statement.
The check for env->cur_state->active_locks was not part of the removed
print statements and will not be triggered with the consolidated print
as... | null | null | null | [PATCH bpf-next 1/2] bpf: Consolidate sleepable checks in check_helper_call() | On Wed, 2026-02-25 at 05:49 -0800, Puranjay Mohan wrote:
[...]
A few checks above there is:
if (!in_sleepable(env) && fn->might_sleep) {
verbose(env, "helper call might sleep in a non-sleepable prog\n");
return -EINVAL;
}
'fn->might_sleep && !in_sleepable_context(env)' covers this case,
do we want to remove ... | {
"author": "Eduard Zingerman <eddyz87@gmail.com>",
"date": "Thu, 26 Feb 2026 01:12:09 -0800",
"is_openbsd": false,
"thread_id": "4729132fbd2544cbe3269ae0ae32610a4a0fca81.camel@gmail.com.mbox.gz"
} |
lkml_critique | bpf | check_helper_call() prints the error message for every
env->cur_state->active* element when calling a sleepable helper.
Consolidate all of them into a single print statement.
The check for env->cur_state->active_locks was not part of the removed
print statements and will not be triggered with the consolidated print
as... | null | null | null | [PATCH bpf-next 1/2] bpf: Consolidate sleepable checks in check_helper_call() | On Wed, 2026-02-25 at 05:49 -0800, Puranjay Mohan wrote:
Acked-by: Eduard Zingerman <eddyz87@gmail.com>
[...] | {
"author": "Eduard Zingerman <eddyz87@gmail.com>",
"date": "Thu, 26 Feb 2026 01:18:27 -0800",
"is_openbsd": false,
"thread_id": "4729132fbd2544cbe3269ae0ae32610a4a0fca81.camel@gmail.com.mbox.gz"
} |
lkml_critique | bpf | From: Jiayuan Chen <jiayuan.chen@shopee.com>
xdp_master_redirect() dereferences the master device pointer and calls
ndo_xdp_get_xmit_slave() without checking whether the master is valid
or running. When a bond device in round-robin mode has never been brought
up, bond->rr_tx_counter is not allocated (only allocated in... | null | null | null | [PATCH bpf v1 1/2] net/bpf: fix null-ptr-deref in xdp_master_redirect() for bonding | syzkaller reported a kernel panic [1] with the following crash stack:
Call Trace:
BUG: unable to handle page fault for address: ffff8ebd08580000
PF: supervisor write access in kernel mode
PF: error_code(0x0002) - not-present page
PGD 11f201067 P4D 11f201067 PUD 0
Oops: Oops: 0002 [#1] SMP PTI
CPU: 2 UID: 0 PID: 451 Co... | {
"author": "Jiayuan Chen <jiayuan.chen@linux.dev>",
"date": "Tue, 24 Feb 2026 19:25:40 +0800",
"is_openbsd": false,
"thread_id": "77167c3125d7db5daa958c30e24e87dae308d7b6@linux.dev.mbox.gz"
} |
lkml_critique | bpf | From: Jiayuan Chen <jiayuan.chen@shopee.com>
xdp_master_redirect() dereferences the master device pointer and calls
ndo_xdp_get_xmit_slave() without checking whether the master is valid
or running. When a bond device in round-robin mode has never been brought
up, bond->rr_tx_counter is not allocated (only allocated in... | null | null | null | [PATCH bpf v1 1/2] net/bpf: fix null-ptr-deref in xdp_master_redirect() for bonding | From: Jiayuan Chen <jiayuan.chen@shopee.com>
Add a selftest that verifies xdp_master_redirect() does not crash when
the bond master device has never been brought up. The test reproduces
the null-ptr-deref in bond_rr_gen_slave_id() by:
1. Creating bond0 (active-backup, UP) with native XDP attached to
enable the glo... | {
"author": "Jiayuan Chen <jiayuan.chen@linux.dev>",
"date": "Tue, 24 Feb 2026 19:25:42 +0800",
"is_openbsd": false,
"thread_id": "77167c3125d7db5daa958c30e24e87dae308d7b6@linux.dev.mbox.gz"
} |
lkml_critique | bpf | From: Jiayuan Chen <jiayuan.chen@shopee.com>
xdp_master_redirect() dereferences the master device pointer and calls
ndo_xdp_get_xmit_slave() without checking whether the master is valid
or running. When a bond device in round-robin mode has never been brought
up, bond->rr_tx_counter is not allocated (only allocated in... | null | null | null | [PATCH bpf v1 1/2] net/bpf: fix null-ptr-deref in xdp_master_redirect() for bonding | On 2026-02-24 19:25:41 [+0800], Jiayuan Chen wrote:
I'm not sure this check belongs here as this is not bond specific, is
it? Also nothing stops the admin to put the device right after the
netif_running() check so it fails later but the race window is not as
wide as it is now.
The per-CPU memory could be allocated wh... | {
"author": "Sebastian Andrzej Siewior <bigeasy@linutronix.de>",
"date": "Thu, 26 Feb 2026 10:58:59 +0100",
"is_openbsd": false,
"thread_id": "77167c3125d7db5daa958c30e24e87dae308d7b6@linux.dev.mbox.gz"
} |
lkml_critique | bpf | From: Jiayuan Chen <jiayuan.chen@shopee.com>
xdp_master_redirect() dereferences the master device pointer and calls
ndo_xdp_get_xmit_slave() without checking whether the master is valid
or running. When a bond device in round-robin mode has never been brought
up, bond->rr_tx_counter is not allocated (only allocated in... | null | null | null | [PATCH bpf v1 1/2] net/bpf: fix null-ptr-deref in xdp_master_redirect() for bonding | 2026/2/26 17:58, "Sebastian Andrzej Siewior" <bigeasy@linutronix.de mailto:bigeasy@linutronix.de?to=%22Sebastian%20Andrzej%20Siewior%22%20%3Cbigeasy%40linutronix.de%3E > wrote:
I agree with your points, especially allocating
rr_tx_counter unconditionally at device creation time in bond_setup().
This eliminates the ... | {
"author": "\"Jiayuan Chen\" <jiayuan.chen@linux.dev>",
"date": "Thu, 26 Feb 2026 12:57:40 +0000",
"is_openbsd": false,
"thread_id": "77167c3125d7db5daa958c30e24e87dae308d7b6@linux.dev.mbox.gz"
} |
lkml_critique | bpf | Dmabuf name allocations can be less than DMA_BUF_NAME_LEN characters,
but bpf_probe_read_kernel always tries to read exactly that many bytes.
If a name is less than DMA_BUF_NAME_LEN characters,
bpf_probe_read_kernel will read past the end. bpf_probe_read_kernel_str
stops at the first NUL terminator so use it instead, l... | null | null | null | [PATCH bpf] selftests/bpf: Fix OOB read in dmabuf_collector | On Tue, Feb 24, 2026 at 4:35 PM T.J. Mercier <tjmercier@google.com> wrote:
Sukadev just let me know that Jerome Lee <jaewookl@quicinc.com> should
actually be the reporter here. | {
"author": "\"T.J. Mercier\" <tjmercier@google.com>",
"date": "Tue, 24 Feb 2026 17:41:57 -0800",
"is_openbsd": false,
"thread_id": "177213421804.1808439.320626533267956186.git-patchwork-notify@kernel.org.mbox.gz"
} |
lkml_critique | bpf | Dmabuf name allocations can be less than DMA_BUF_NAME_LEN characters,
but bpf_probe_read_kernel always tries to read exactly that many bytes.
If a name is less than DMA_BUF_NAME_LEN characters,
bpf_probe_read_kernel will read past the end. bpf_probe_read_kernel_str
stops at the first NUL terminator so use it instead, l... | null | null | null | [PATCH bpf] selftests/bpf: Fix OOB read in dmabuf_collector | Hello:
This patch was applied to bpf/bpf.git (master)
by Alexei Starovoitov <ast@kernel.org>:
On Tue, 24 Feb 2026 16:33:48 -0800 you wrote:
Here is the summary with links:
- [bpf] selftests/bpf: Fix OOB read in dmabuf_collector
https://git.kernel.org/bpf/bpf/c/6881af27f9ea
You are awesome, thank you!
--
Deet... | {
"author": "patchwork-bot+netdevbpf@kernel.org",
"date": "Thu, 26 Feb 2026 19:30:18 +0000",
"is_openbsd": false,
"thread_id": "177213421804.1808439.320626533267956186.git-patchwork-notify@kernel.org.mbox.gz"
} |
lkml_critique | bpf | When a kernel module exports a symbol with the same name as an existing
vmlinux symbol, kprobe attachment via bpf_program__attach_kprobe_opts()
fails with EADDRNOTAVAIL (perf_event_open path) or EINVAL (legacy
tracefs path).
This series implements a fallback mechanism that, on such failures,
resolves the vmlinux addre... | null | null | null | [RFC PATCH bpf-next v2 0/2] libbpf: Handle duplicate kprobe symbols | Add test_attach_probe_dup_sym() which loads bpf_testmod_dup_sym.ko to
create a duplicate symbol scenario, then verifies kprobe and kretprobe
attachment succeeds across default, legacy, perf_event, and link modes.
Signed-off-by: Andrey Grodzovsky <andrey.grodzovsky@crowdstrike.com>
---
tools/testing/selftests/bpf/Make... | {
"author": "Andrey Grodzovsky <andrey.grodzovsky@crowdstrike.com>",
"date": "Tue, 24 Feb 2026 12:23:40 -0500",
"is_openbsd": false,
"thread_id": "20260224172340.1704618-1-andrey.grodzovsky@crowdstrike.com.mbox.gz"
} |
lkml_critique | bpf | When a kernel module exports a symbol with the same name as an existing
vmlinux symbol, kprobe attachment via bpf_program__attach_kprobe_opts()
fails with EADDRNOTAVAIL (perf_event_open path) or EINVAL (legacy
tracefs path).
This series implements a fallback mechanism that, on such failures,
resolves the vmlinux addre... | null | null | null | [RFC PATCH bpf-next v2 0/2] libbpf: Handle duplicate kprobe symbols | When attaching a kprobe to a function that has duplicate symbols in
kallsyms (e.g. same name in vmlinux and a module), the kernel returns
EADDRNOTAVAIL (or EINVAL via the legacy path). Detect this and retry
by resolving the vmlinux address through kallsyms, skipping module
symbols, and using the absolute address for pr... | {
"author": "Andrey Grodzovsky <andrey.grodzovsky@crowdstrike.com>",
"date": "Tue, 24 Feb 2026 12:23:39 -0500",
"is_openbsd": false,
"thread_id": "20260224172340.1704618-1-andrey.grodzovsky@crowdstrike.com.mbox.gz"
} |
lkml_critique | bpf | When a kernel module exports a symbol with the same name as an existing
vmlinux symbol, kprobe attachment via bpf_program__attach_kprobe_opts()
fails with EADDRNOTAVAIL (perf_event_open path) or EINVAL (legacy
tracefs path).
This series implements a fallback mechanism that, on such failures,
resolves the vmlinux addre... | null | null | null | [RFC PATCH bpf-next v2 0/2] libbpf: Handle duplicate kprobe symbols | On Tue Feb 24, 2026 at 12:23 PM EST, Andrey Grodzovsky wrote:
Hello,
looks much better!
Sorry for the delay, picking this up from the last version: If the
name length is not available from a header and we'd have to hardcode it
then this is fine. sym_name[500] above seems to be hardcoded too.
Nit: Missing ne... | {
"author": "\"Emil Tsalapatis\" <emil@etsalapatis.com>",
"date": "Tue, 24 Feb 2026 12:55:07 -0500",
"is_openbsd": false,
"thread_id": "20260224172340.1704618-1-andrey.grodzovsky@crowdstrike.com.mbox.gz"
} |
lkml_critique | bpf | When a kernel module exports a symbol with the same name as an existing
vmlinux symbol, kprobe attachment via bpf_program__attach_kprobe_opts()
fails with EADDRNOTAVAIL (perf_event_open path) or EINVAL (legacy
tracefs path).
This series implements a fallback mechanism that, on such failures,
resolves the vmlinux addre... | null | null | null | [RFC PATCH bpf-next v2 0/2] libbpf: Handle duplicate kprobe symbols | [ ... ]
[ ... ]
The comment says "override the offset to be the desired function
KADDR" but the code does offset += kaddr_ctx.kaddr rather than a
straight assignment. When the caller passes a non-zero offset (e.g.
to probe inside a function), the result is kaddr + user_offset, which
is the right thing to do.
Shou... | {
"author": "bot+bpf-ci@kernel.org",
"date": "Tue, 24 Feb 2026 18:10:16 +0000 (UTC)",
"is_openbsd": false,
"thread_id": "20260224172340.1704618-1-andrey.grodzovsky@crowdstrike.com.mbox.gz"
} |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.