data_type large_stringclasses 3
values | source large_stringclasses 29
values | code large_stringlengths 98 49.4M | filepath large_stringlengths 5 161 ⌀ | message large_stringclasses 234
values | commit large_stringclasses 234
values | subject large_stringclasses 418
values | critique large_stringlengths 101 1.26M ⌀ | metadata dict |
|---|---|---|---|---|---|---|---|---|
lkml_critique | qemu-devel | replace blank table with a new one:
[000h 0000 4] Signature : "WDAT" [Watchdog Action Table]
[004h 0004 4] Table Length : 00000104
[008h 0008 1] Revision : 01
[009h 0009 1] Checksum : EB
[00Ah 0010 6] Oem ID :... | null | null | null | [PATCH 11/11] tests: acpi: arm/virt: update expected WDAT blob | On Fri, 6 Feb 2026 at 13:14, Igor Mammedov <imammedo@redhat.com> wrote:
The sbsa-ref machine already implements an sbsa-gwdt watchdog...
-- PMM | {
"author": "Peter Maydell <peter.maydell@linaro.org>",
"date": "Wed, 18 Feb 2026 19:10:02 +0000",
"is_openbsd": false,
"thread_id": "CAFEAcA-DtSE4MsN2XcBkOk5t3Xbe_Kz_MtUwfCkas4Q7R7CFnw@mail.gmail.com.mbox.gz"
} |
lkml_critique | qemu-devel | replace blank table with a new one:
[000h 0000 4] Signature : "WDAT" [Watchdog Action Table]
[004h 0004 4] Table Length : 00000104
[008h 0008 1] Revision : 01
[009h 0009 1] Checksum : EB
[00Ah 0010 6] Oem ID :... | null | null | null | [PATCH 11/11] tests: acpi: arm/virt: update expected WDAT blob | On Wed, 18 Feb 2026 19:08:36 +0000
Peter Maydell <peter.maydell@linaro.org> wrote:
It's possible,
but we probably should not enable it if acpi variant was requested,
to avoid confusion on guest side.
For Windows it doesn't really mater, for linux it does.
on x86 linux guest uses a quirk to disable native iTCO watchd... | {
"author": "Igor Mammedov <imammedo@redhat.com>",
"date": "Thu, 19 Feb 2026 13:17:51 +0100",
"is_openbsd": false,
"thread_id": "CAFEAcA-DtSE4MsN2XcBkOk5t3Xbe_Kz_MtUwfCkas4Q7R7CFnw@mail.gmail.com.mbox.gz"
} |
lkml_critique | qemu-devel | replace blank table with a new one:
[000h 0000 4] Signature : "WDAT" [Watchdog Action Table]
[004h 0004 4] Table Length : 00000104
[008h 0008 1] Revision : 01
[009h 0009 1] Checksum : EB
[00Ah 0010 6] Oem ID :... | null | null | null | [PATCH 11/11] tests: acpi: arm/virt: update expected WDAT blob | On Wed, 18 Feb 2026 19:10:02 +0000
Peter Maydell <peter.maydell@linaro.org> wrote:
yep, but not exposed as WDAT one. Hence the question.
It also would need clock-frequency tweak if we are expose it via ACPI.
PS:
I don't even see DT mapping for it,
looks like sbsa-gwdt is just wired for the sake of compliance with th... | {
"author": "Igor Mammedov <imammedo@redhat.com>",
"date": "Thu, 19 Feb 2026 13:27:29 +0100",
"is_openbsd": false,
"thread_id": "CAFEAcA-DtSE4MsN2XcBkOk5t3Xbe_Kz_MtUwfCkas4Q7R7CFnw@mail.gmail.com.mbox.gz"
} |
lkml_critique | qemu-devel | replace blank table with a new one:
[000h 0000 4] Signature : "WDAT" [Watchdog Action Table]
[004h 0004 4] Table Length : 00000104
[008h 0008 1] Revision : 01
[009h 0009 1] Checksum : EB
[00Ah 0010 6] Oem ID :... | null | null | null | [PATCH 11/11] tests: acpi: arm/virt: update expected WDAT blob | On Thu, 19 Feb 2026 at 12:17, Igor Mammedov <imammedo@redhat.com> wrote:
Why? Almost every other device on this board we advertise
via DTB for device tree guests and via ACPI for ACPI guests.
(The exceptions are things like the CXL handling that really
only has an ACPI representation and can't be described in the DTB... | {
"author": "Peter Maydell <peter.maydell@linaro.org>",
"date": "Thu, 19 Feb 2026 13:00:13 +0000",
"is_openbsd": false,
"thread_id": "CAFEAcA-DtSE4MsN2XcBkOk5t3Xbe_Kz_MtUwfCkas4Q7R7CFnw@mail.gmail.com.mbox.gz"
} |
lkml_critique | qemu-devel | replace blank table with a new one:
[000h 0000 4] Signature : "WDAT" [Watchdog Action Table]
[004h 0004 4] Table Length : 00000104
[008h 0008 1] Revision : 01
[009h 0009 1] Checksum : EB
[00Ah 0010 6] Oem ID :... | null | null | null | [PATCH 11/11] tests: acpi: arm/virt: update expected WDAT blob | On Thu, 19 Feb 2026 at 12:27, Igor Mammedov <imammedo@redhat.com> wrote:
The way the sbsa-ref board works is that it's supposed to be a reference
system and software stack that behaves like a real hardware system would.
So the "dtb" is not a proper DTB, it's just a way to tell the firmware
a few key details (that on r... | {
"author": "Peter Maydell <peter.maydell@linaro.org>",
"date": "Thu, 19 Feb 2026 14:05:53 +0000",
"is_openbsd": false,
"thread_id": "CAFEAcA-DtSE4MsN2XcBkOk5t3Xbe_Kz_MtUwfCkas4Q7R7CFnw@mail.gmail.com.mbox.gz"
} |
lkml_critique | qemu-devel | replace blank table with a new one:
[000h 0000 4] Signature : "WDAT" [Watchdog Action Table]
[004h 0004 4] Table Length : 00000104
[008h 0008 1] Revision : 01
[009h 0009 1] Checksum : EB
[00Ah 0010 6] Oem ID :... | null | null | null | [PATCH 11/11] tests: acpi: arm/virt: update expected WDAT blob | On Thu, 19 Feb 2026 13:00:13 +0000
Peter Maydell <peter.maydell@linaro.org> wrote:
If we expose both guest may try to load both drivers causing conflict or misbehavior.
(
that's what x86 solved by quirk on guest side preferring WDAT watchdog
instead of native one.
)
I can try and see what arm kernel would do in presen... | {
"author": "Igor Mammedov <imammedo@redhat.com>",
"date": "Thu, 19 Feb 2026 15:55:38 +0100",
"is_openbsd": false,
"thread_id": "CAFEAcA-DtSE4MsN2XcBkOk5t3Xbe_Kz_MtUwfCkas4Q7R7CFnw@mail.gmail.com.mbox.gz"
} |
lkml_critique | qemu-devel | replace blank table with a new one:
[000h 0000 4] Signature : "WDAT" [Watchdog Action Table]
[004h 0004 4] Table Length : 00000104
[008h 0008 1] Revision : 01
[009h 0009 1] Checksum : EB
[00Ah 0010 6] Oem ID :... | null | null | null | [PATCH 11/11] tests: acpi: arm/virt: update expected WDAT blob | On Thu, 19 Feb 2026 at 14:55, Igor Mammedov <imammedo@redhat.com> wrote:
Huh? A guest will do one of:
1 read the ACPI tables, and load the driver based on the ACPI data
2 read the DTB, and load the driver based on the DTB
Nothing tries to read both at once, or it would get totally
confused.
We know already that ... | {
"author": "Peter Maydell <peter.maydell@linaro.org>",
"date": "Thu, 19 Feb 2026 16:04:37 +0000",
"is_openbsd": false,
"thread_id": "CAFEAcA-DtSE4MsN2XcBkOk5t3Xbe_Kz_MtUwfCkas4Q7R7CFnw@mail.gmail.com.mbox.gz"
} |
lkml_critique | qemu-devel | replace blank table with a new one:
[000h 0000 4] Signature : "WDAT" [Watchdog Action Table]
[004h 0004 4] Table Length : 00000104
[008h 0008 1] Revision : 01
[009h 0009 1] Checksum : EB
[00Ah 0010 6] Oem ID :... | null | null | null | [PATCH 11/11] tests: acpi: arm/virt: update expected WDAT blob | On Thu, 19 Feb 2026 16:04:37 +0000
Peter Maydell <peter.maydell@linaro.org> wrote:
To some degree only (GWDT is wired to use different frequency
depending if it's configured for native or WDAT usecase)
correct way would be for QEMU to ship following:
1. DTB + watchdog descriptor in GTDT ACPI table for native watc... | {
"author": "Igor Mammedov <imammedo@redhat.com>",
"date": "Mon, 23 Feb 2026 10:28:40 +0100",
"is_openbsd": false,
"thread_id": "CAFEAcA-DtSE4MsN2XcBkOk5t3Xbe_Kz_MtUwfCkas4Q7R7CFnw@mail.gmail.com.mbox.gz"
} |
lkml_critique | qemu-devel | replace blank table with a new one:
[000h 0000 4] Signature : "WDAT" [Watchdog Action Table]
[004h 0004 4] Table Length : 00000104
[008h 0008 1] Revision : 01
[009h 0009 1] Checksum : EB
[00Ah 0010 6] Oem ID :... | null | null | null | [PATCH 11/11] tests: acpi: arm/virt: update expected WDAT blob | On Thu, Feb 19, 2026 at 04:04:37PM +0000, Peter Maydell wrote:
The watchdog is different though as the ACPI WDAT table is not
describing the underlying piece of hardware. Instead it is
describing an interface for controlling watchdog functionality,
such that the guest does not have any awareness of what the
underlying... | {
"author": "Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= <berrange@redhat.com>",
"date": "Wed, 25 Feb 2026 15:11:03 +0000",
"is_openbsd": false,
"thread_id": "CAFEAcA-DtSE4MsN2XcBkOk5t3Xbe_Kz_MtUwfCkas4Q7R7CFnw@mail.gmail.com.mbox.gz"
} |
lkml_critique | qemu-devel | replace blank table with a new one:
[000h 0000 4] Signature : "WDAT" [Watchdog Action Table]
[004h 0004 4] Table Length : 00000104
[008h 0008 1] Revision : 01
[009h 0009 1] Checksum : EB
[00Ah 0010 6] Oem ID :... | null | null | null | [PATCH 11/11] tests: acpi: arm/virt: update expected WDAT blob | On Thu, Feb 19, 2026 at 01:17:51PM +0100, Igor Mammedov wrote:
Right, if there was a case where we were already using -device to
create the watchdog, then I would suggest having a simple
'wadt=on|off' property as standard for any watchdog wanting that
ACPI abstraction wrapper.
That could (hypothetically) be the case ... | {
"author": "Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= <berrange@redhat.com>",
"date": "Wed, 25 Feb 2026 15:19:56 +0000",
"is_openbsd": false,
"thread_id": "CAFEAcA-DtSE4MsN2XcBkOk5t3Xbe_Kz_MtUwfCkas4Q7R7CFnw@mail.gmail.com.mbox.gz"
} |
lkml_critique | qemu-devel | replace blank table with a new one:
[000h 0000 4] Signature : "WDAT" [Watchdog Action Table]
[004h 0004 4] Table Length : 00000104
[008h 0008 1] Revision : 01
[009h 0009 1] Checksum : EB
[00Ah 0010 6] Oem ID :... | null | null | null | [PATCH 11/11] tests: acpi: arm/virt: update expected WDAT blob | On Wed, 25 Feb 2026 15:19:56 +0000
Daniel P. Berrangé <berrange@redhat.com> wrote:
CCin Markus since it touches QAPI stuff.
For respin, I've went ahead with a bit more generic approach
(as a user, I wouldn't really care what kind of built-in watchdog board ships,
and having 1 property instead total instead of machin... | {
"author": "Igor Mammedov <imammedo@redhat.com>",
"date": "Thu, 26 Feb 2026 13:56:48 +0100",
"is_openbsd": false,
"thread_id": "CAFEAcA-DtSE4MsN2XcBkOk5t3Xbe_Kz_MtUwfCkas4Q7R7CFnw@mail.gmail.com.mbox.gz"
} |
lkml_critique | qemu-devel | replace blank table with a new one:
[000h 0000 4] Signature : "WDAT" [Watchdog Action Table]
[004h 0004 4] Table Length : 00000104
[008h 0008 1] Revision : 01
[009h 0009 1] Checksum : EB
[00Ah 0010 6] Oem ID :... | null | null | null | [PATCH 11/11] tests: acpi: arm/virt: update expected WDAT blob | Igor Mammedov <imammedo@redhat.com> writes:
Adds the property to abstract base type "machine", i.e. every machine
has it.
Fundamentally assumes there is at most one onboard watchdog of interest.
I'm lacking context, please bear with me: who or what is going to set
this property, and for what purpose?
As far as I ... | {
"author": "Markus Armbruster <armbru@redhat.com>",
"date": "Fri, 27 Feb 2026 08:24:42 +0100",
"is_openbsd": false,
"thread_id": "CAFEAcA-DtSE4MsN2XcBkOk5t3Xbe_Kz_MtUwfCkas4Q7R7CFnw@mail.gmail.com.mbox.gz"
} |
lkml_critique | qemu-devel | replace blank table with a new one:
[000h 0000 4] Signature : "WDAT" [Watchdog Action Table]
[004h 0004 4] Table Length : 00000104
[008h 0008 1] Revision : 01
[009h 0009 1] Checksum : EB
[00Ah 0010 6] Oem ID :... | null | null | null | [PATCH 11/11] tests: acpi: arm/virt: update expected WDAT blob | On Thu, 26 Feb 2026 18:08:09 +0100
Philippe Mathieu-Daudé <philmd@linaro.org> wrote:
I do check it when I build wdat specific files.
Anyways, this part has been reworked see my reply in
8/11 thread with new more generic 'watchdog' option. | {
"author": "Igor Mammedov <imammedo@redhat.com>",
"date": "Fri, 27 Feb 2026 09:23:47 +0100",
"is_openbsd": false,
"thread_id": "CAFEAcA-DtSE4MsN2XcBkOk5t3Xbe_Kz_MtUwfCkas4Q7R7CFnw@mail.gmail.com.mbox.gz"
} |
lkml_critique | qemu-devel | replace blank table with a new one:
[000h 0000 4] Signature : "WDAT" [Watchdog Action Table]
[004h 0004 4] Table Length : 00000104
[008h 0008 1] Revision : 01
[009h 0009 1] Checksum : EB
[00Ah 0010 6] Oem ID :... | null | null | null | [PATCH 11/11] tests: acpi: arm/virt: update expected WDAT blob | On Fri, Feb 27, 2026 at 08:24:42AM +0100, Markus Armbruster wrote:
Libvirt generally wants to work with & express the exact hardware
and not rely on "auto" settings in QEMU.
So in terms of the built-in watchdog for Q35 we currently express
this explicitly via
<watchdog model='itco' />
Adding "WADT" is not expre... | {
"author": "Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= <berrange@redhat.com>",
"date": "Fri, 27 Feb 2026 09:01:25 +0000",
"is_openbsd": false,
"thread_id": "CAFEAcA-DtSE4MsN2XcBkOk5t3Xbe_Kz_MtUwfCkas4Q7R7CFnw@mail.gmail.com.mbox.gz"
} |
lkml_critique | qemu-devel | replace blank table with a new one:
[000h 0000 4] Signature : "WDAT" [Watchdog Action Table]
[004h 0004 4] Table Length : 00000104
[008h 0008 1] Revision : 01
[009h 0009 1] Checksum : EB
[00Ah 0010 6] Oem ID :... | null | null | null | [PATCH 11/11] tests: acpi: arm/virt: update expected WDAT blob | On Fri, 27 Feb 2026 08:24:42 +0100
Markus Armbruster <armbru@redhat.com> wrote:
in past (which might be different from now 'policies'), we used to add
a property to abstract machine when there is more than 1 board/target
that consumes it. This follows that trend.
If that is not desirable now, I can move it specific b... | {
"author": "Igor Mammedov <imammedo@redhat.com>",
"date": "Fri, 27 Feb 2026 10:42:27 +0100",
"is_openbsd": false,
"thread_id": "CAFEAcA-DtSE4MsN2XcBkOk5t3Xbe_Kz_MtUwfCkas4Q7R7CFnw@mail.gmail.com.mbox.gz"
} |
lkml_critique | qemu-devel | replace blank table with a new one:
[000h 0000 4] Signature : "WDAT" [Watchdog Action Table]
[004h 0004 4] Table Length : 00000104
[008h 0008 1] Revision : 01
[009h 0009 1] Checksum : EB
[00Ah 0010 6] Oem ID :... | null | null | null | [PATCH 11/11] tests: acpi: arm/virt: update expected WDAT blob | On Fri, 27 Feb 2026 09:01:25 +0000
Daniel P. Berrangé <berrange@redhat.com> wrote:
not specifying above libvirt doesn't make itco go away on qemu side,
it's still there regardless of above.
but that said, I can work with it and add
q35.wdat -> itco.wdat alias to toggle it
for gwdt it's more than just adding extra... | {
"author": "Igor Mammedov <imammedo@redhat.com>",
"date": "Fri, 27 Feb 2026 11:01:25 +0100",
"is_openbsd": false,
"thread_id": "CAFEAcA-DtSE4MsN2XcBkOk5t3Xbe_Kz_MtUwfCkas4Q7R7CFnw@mail.gmail.com.mbox.gz"
} |
lkml_critique | qemu-devel | replace blank table with a new one:
[000h 0000 4] Signature : "WDAT" [Watchdog Action Table]
[004h 0004 4] Table Length : 00000104
[008h 0008 1] Revision : 01
[009h 0009 1] Checksum : EB
[00Ah 0010 6] Oem ID :... | null | null | null | [PATCH 11/11] tests: acpi: arm/virt: update expected WDAT blob | On Fri, Feb 27, 2026 at 11:01:25AM +0100, Igor Mammedov wrote:
That is fine. Libvirt will synthesize a <watchdog> device to
represent & track the built-in default hardware, if the mgmt
app did not specify it explicitly.
That doesn't really sound that different to me. If enabling WADT
implies disabling GTDT that's... | {
"author": "Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= <berrange@redhat.com>",
"date": "Fri, 27 Feb 2026 10:18:25 +0000",
"is_openbsd": false,
"thread_id": "CAFEAcA-DtSE4MsN2XcBkOk5t3Xbe_Kz_MtUwfCkas4Q7R7CFnw@mail.gmail.com.mbox.gz"
} |
lkml_critique | qemu-devel | replace blank table with a new one:
[000h 0000 4] Signature : "WDAT" [Watchdog Action Table]
[004h 0004 4] Table Length : 00000104
[008h 0008 1] Revision : 01
[009h 0009 1] Checksum : EB
[00Ah 0010 6] Oem ID :... | null | null | null | [PATCH 11/11] tests: acpi: arm/virt: update expected WDAT blob | On Fri, 27 Feb 2026 10:18:25 +0000
Daniel P. Berrangé <berrange@redhat.com> wrote:
with wdat enabled not only GTDT part but also a corresponding DT node should
be hidden from guest as they assume gwdt running at different frequency.
As for exposing both GTDT along with DT node when wdat is disabled,
quick test shows... | {
"author": "Igor Mammedov <imammedo@redhat.com>",
"date": "Fri, 27 Feb 2026 12:41:05 +0100",
"is_openbsd": false,
"thread_id": "CAFEAcA-DtSE4MsN2XcBkOk5t3Xbe_Kz_MtUwfCkas4Q7R7CFnw@mail.gmail.com.mbox.gz"
} |
lkml_critique | qemu-devel | replace blank table with a new one:
[000h 0000 4] Signature : "WDAT" [Watchdog Action Table]
[004h 0004 4] Table Length : 00000104
[008h 0008 1] Revision : 01
[009h 0009 1] Checksum : EB
[00Ah 0010 6] Oem ID :... | null | null | null | [PATCH 11/11] tests: acpi: arm/virt: update expected WDAT blob | Igor Mammedov <imammedo@redhat.com> writes:
I didn't mean to object to adding it to all machines. I don't have an
opinion there :)
I figure when the board doesn't have a watchdog, then the only available
choices are 'off' and 'auto', which is 'auto' also 'off'.
Defaulting to a valid value is good.
The larger pr... | {
"author": "Markus Armbruster <armbru@redhat.com>",
"date": "Fri, 27 Feb 2026 13:10:21 +0100",
"is_openbsd": false,
"thread_id": "CAFEAcA-DtSE4MsN2XcBkOk5t3Xbe_Kz_MtUwfCkas4Q7R7CFnw@mail.gmail.com.mbox.gz"
} |
lkml_critique | qemu-devel | replace blank table with a new one:
[000h 0000 4] Signature : "WDAT" [Watchdog Action Table]
[004h 0004 4] Table Length : 00000104
[008h 0008 1] Revision : 01
[009h 0009 1] Checksum : EB
[00Ah 0010 6] Oem ID :... | null | null | null | [PATCH 11/11] tests: acpi: arm/virt: update expected WDAT blob | On Fri, 27 Feb 2026 at 12:10, Markus Armbruster <armbru@redhat.com> wrote:
I think it also will appear if you run e.g.
qemu-system-arm -M virt,help
(which produces a list of all properties with their short descriptions)
For board-specific properties, we should be documenting these in
the manual page for the board. ... | {
"author": "Peter Maydell <peter.maydell@linaro.org>",
"date": "Fri, 27 Feb 2026 13:14:26 +0000",
"is_openbsd": false,
"thread_id": "CAFEAcA-DtSE4MsN2XcBkOk5t3Xbe_Kz_MtUwfCkas4Q7R7CFnw@mail.gmail.com.mbox.gz"
} |
lkml_critique | qemu-devel | replace blank table with a new one:
[000h 0000 4] Signature : "WDAT" [Watchdog Action Table]
[004h 0004 4] Table Length : 00000104
[008h 0008 1] Revision : 01
[009h 0009 1] Checksum : EB
[00Ah 0010 6] Oem ID :... | null | null | null | [PATCH 11/11] tests: acpi: arm/virt: update expected WDAT blob | Peter Maydell <peter.maydell@linaro.org> writes:
You're right!
Every board should have such a page. Even if it's just a placeholder.
Placeholders would remind us where the gaps are.
We should do this. | {
"author": "Markus Armbruster <armbru@redhat.com>",
"date": "Fri, 27 Feb 2026 15:51:26 +0100",
"is_openbsd": false,
"thread_id": "CAFEAcA-DtSE4MsN2XcBkOk5t3Xbe_Kz_MtUwfCkas4Q7R7CFnw@mail.gmail.com.mbox.gz"
} |
lkml_critique | qemu-devel | replace blank table with a new one:
[000h 0000 4] Signature : "WDAT" [Watchdog Action Table]
[004h 0004 4] Table Length : 00000104
[008h 0008 1] Revision : 01
[009h 0009 1] Checksum : EB
[00Ah 0010 6] Oem ID :... | null | null | null | [PATCH 11/11] tests: acpi: arm/virt: update expected WDAT blob | On Fri, 27 Feb 2026 at 14:51, Markus Armbruster <armbru@redhat.com> wrote:
I agree. For Arm I believe every board should already have a docs page,
even if a very minimal one. (Some closely related boards get
described on a single page that covers that whole family of boards.)
The full list of pages is here:
https://w... | {
"author": "Peter Maydell <peter.maydell@linaro.org>",
"date": "Fri, 27 Feb 2026 15:01:28 +0000",
"is_openbsd": false,
"thread_id": "CAFEAcA-DtSE4MsN2XcBkOk5t3Xbe_Kz_MtUwfCkas4Q7R7CFnw@mail.gmail.com.mbox.gz"
} |
lkml_critique | qemu-devel | a15mpcore.c doesn't need to include the target-specific 'kvm_arm.h'
header, it only lacks the qemu_get_cpu() declaration which comes
from 'hw/core/cpu.h'. Include the latter and build as common object.
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
hw/cpu/a15mpcore.c | 2 +-
hw/cpu/meson.build | 2 +-
... | null | null | null | [PATCH] hw/cpu: Build a15mpcore.c once as common object | On 2/25/26 14:44, Philippe Mathieu-Daudé wrote:
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~ | {
"author": "Richard Henderson <richard.henderson@linaro.org>",
"date": "Wed, 25 Feb 2026 15:41:29 +1100",
"is_openbsd": false,
"thread_id": "CAFEAcA-U5FdcNC-RQL1rkdPsVBWuk8-4B_JFtPMWS0eZid8L4g@mail.gmail.com.mbox.gz"
} |
lkml_critique | qemu-devel | a15mpcore.c doesn't need to include the target-specific 'kvm_arm.h'
header, it only lacks the qemu_get_cpu() declaration which comes
from 'hw/core/cpu.h'. Include the latter and build as common object.
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
hw/cpu/a15mpcore.c | 2 +-
hw/cpu/meson.build | 2 +-
... | null | null | null | [PATCH] hw/cpu: Build a15mpcore.c once as common object | On Wed, 25 Feb 2026 at 03:44, Philippe Mathieu-Daudé <philmd@linaro.org> wrote:
Applied to target-arm.next, thanks (and now in master, looks like
I forgot to hit 'send' on this mail...).
-- PMM | {
"author": "Peter Maydell <peter.maydell@linaro.org>",
"date": "Fri, 27 Feb 2026 13:36:03 +0000",
"is_openbsd": false,
"thread_id": "CAFEAcA-U5FdcNC-RQL1rkdPsVBWuk8-4B_JFtPMWS0eZid8L4g@mail.gmail.com.mbox.gz"
} |
lkml_critique | qemu-devel | Signed-off-by: John Snow <jsnow@redhat.com>
---
configure | 4 ++--
python/setup.cfg | 3 ++-
2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/configure b/configure
index c4837eba2b1..d44e9e86148 100755
--- a/configure
+++ b/configure
@@ -527,8 +527,8 @@ first_python=
if test -z "${PYTHON}"; then... | null | null | null | [PATCH v2 4/4] python: add formal python3.14 support and testing | Avocado-framework is no longer used for anything, so it can be removed.
Signed-off-by: John Snow <jsnow@redhat.com>
---
python/README.rst | 2 --
python/avocado.cfg | 13 -------------
python/setup.cfg | 1 -
python/tests/flake8.sh | 3 ---
python/tests/iotests-mypy.s... | {
"author": "John Snow <jsnow@redhat.com>",
"date": "Wed, 25 Feb 2026 14:28:07 -0500",
"is_openbsd": false,
"thread_id": "20260225192808.957477-1-jsnow@redhat.com.mbox.gz"
} |
lkml_critique | qemu-devel | Signed-off-by: John Snow <jsnow@redhat.com>
---
configure | 4 ++--
python/setup.cfg | 3 ++-
2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/configure b/configure
index c4837eba2b1..d44e9e86148 100755
--- a/configure
+++ b/configure
@@ -527,8 +527,8 @@ first_python=
if test -z "${PYTHON}"; then... | null | null | null | [PATCH v2 4/4] python: add formal python3.14 support and testing | This patchset drops avocado for the python tests, which fixes the
optional python-check-tox GitLab CI test, and adds formal testing and
support for Python3.14 to QEMU.
v2:
- Also search for Python3.14 during configure
- Rebase on top of master now that qemu.qmp is dropped
John Snow (4):
python: pin 'whee... | {
"author": "John Snow <jsnow@redhat.com>",
"date": "Wed, 25 Feb 2026 14:28:04 -0500",
"is_openbsd": false,
"thread_id": "20260225192808.957477-1-jsnow@redhat.com.mbox.gz"
} |
lkml_critique | qemu-devel | Signed-off-by: John Snow <jsnow@redhat.com>
---
configure | 4 ++--
python/setup.cfg | 3 ++-
2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/configure b/configure
index c4837eba2b1..d44e9e86148 100755
--- a/configure
+++ b/configure
@@ -527,8 +527,8 @@ first_python=
if test -z "${PYTHON}"; then... | null | null | null | [PATCH v2 4/4] python: add formal python3.14 support and testing | With recent python packaging ecosystem updates, the latest 'wheel' is no
longer compatible with older packages - and was somehow still compatible
with our Python 3.9 environment. Pin wheel to an older version (Version
based on Debian 11's available wheel package) to remove warnings during
the minreqs test.
Signed-off-... | {
"author": "John Snow <jsnow@redhat.com>",
"date": "Wed, 25 Feb 2026 14:28:05 -0500",
"is_openbsd": false,
"thread_id": "20260225192808.957477-1-jsnow@redhat.com.mbox.gz"
} |
lkml_critique | qemu-devel | Signed-off-by: John Snow <jsnow@redhat.com>
---
configure | 4 ++--
python/setup.cfg | 3 ++-
2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/configure b/configure
index c4837eba2b1..d44e9e86148 100755
--- a/configure
+++ b/configure
@@ -527,8 +527,8 @@ first_python=
if test -z "${PYTHON}"; then... | null | null | null | [PATCH v2 4/4] python: add formal python3.14 support and testing | Following suit with the rest of this repository, drop avocado and
replace it with the Python standard "pytest" package.
In this case, we do not truly need pytest as all we are using it for is
running other python processes formerly launched by shell scripts, but
this matches how the standalone python-qemu-qmp package ... | {
"author": "John Snow <jsnow@redhat.com>",
"date": "Wed, 25 Feb 2026 14:28:06 -0500",
"is_openbsd": false,
"thread_id": "20260225192808.957477-1-jsnow@redhat.com.mbox.gz"
} |
lkml_critique | qemu-devel | Signed-off-by: John Snow <jsnow@redhat.com>
---
configure | 4 ++--
python/setup.cfg | 3 ++-
2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/configure b/configure
index c4837eba2b1..d44e9e86148 100755
--- a/configure
+++ b/configure
@@ -527,8 +527,8 @@ first_python=
if test -z "${PYTHON}"; then... | null | null | null | [PATCH v2 4/4] python: add formal python3.14 support and testing | On Wed, Feb 25, 2026 at 02:28:08PM -0500, John Snow wrote:
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com ~~ https://hachyderm.io/@berrange :|
|: https://libvirt.org ~~ https://entangle-photo.org :|
|: https://pixelfed.art/berrang... | {
"author": "Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= <berrange@redhat.com>",
"date": "Thu, 26 Feb 2026 14:06:08 +0000",
"is_openbsd": false,
"thread_id": "20260225192808.957477-1-jsnow@redhat.com.mbox.gz"
} |
lkml_critique | qemu-devel | Signed-off-by: John Snow <jsnow@redhat.com>
---
configure | 4 ++--
python/setup.cfg | 3 ++-
2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/configure b/configure
index c4837eba2b1..d44e9e86148 100755
--- a/configure
+++ b/configure
@@ -527,8 +527,8 @@ first_python=
if test -z "${PYTHON}"; then... | null | null | null | [PATCH v2 4/4] python: add formal python3.14 support and testing | On Wed, Feb 25, 2026 at 02:28:05PM -0500, John Snow wrote:
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com ~~ https://hachyderm.io/@berrange :|
|: https://libvirt.org ~~ https://entangle-photo.org :|
|: https://pixelfed.art/berrang... | {
"author": "Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= <berrange@redhat.com>",
"date": "Thu, 26 Feb 2026 14:04:38 +0000",
"is_openbsd": false,
"thread_id": "20260225192808.957477-1-jsnow@redhat.com.mbox.gz"
} |
lkml_critique | qemu-devel | Signed-off-by: John Snow <jsnow@redhat.com>
---
configure | 4 ++--
python/setup.cfg | 3 ++-
2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/configure b/configure
index c4837eba2b1..d44e9e86148 100755
--- a/configure
+++ b/configure
@@ -527,8 +527,8 @@ first_python=
if test -z "${PYTHON}"; then... | null | null | null | [PATCH v2 4/4] python: add formal python3.14 support and testing | On Wed, Feb 25, 2026 at 02:28:07PM -0500, John Snow wrote:
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com ~~ https://hachyderm.io/@berrange :|
|: https://libvirt.org ~~ https://entangle-photo.org :|
|: https://pixelfed.art/berrang... | {
"author": "Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= <berrange@redhat.com>",
"date": "Thu, 26 Feb 2026 14:18:40 +0000",
"is_openbsd": false,
"thread_id": "20260225192808.957477-1-jsnow@redhat.com.mbox.gz"
} |
lkml_critique | qemu-devel | Signed-off-by: John Snow <jsnow@redhat.com>
---
configure | 4 ++--
python/setup.cfg | 3 ++-
2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/configure b/configure
index c4837eba2b1..d44e9e86148 100755
--- a/configure
+++ b/configure
@@ -527,8 +527,8 @@ first_python=
if test -z "${PYTHON}"; then... | null | null | null | [PATCH v2 4/4] python: add formal python3.14 support and testing | On Wed, Feb 25, 2026 at 02:28:06PM -0500, John Snow wrote:
any more than we want avocado. The desire is for "meson" to be
the test harness.
If this use of a pytest is just a temporary stepping stone
towards fully integrating with meson, then that's acceptable
but lets note that this is a temporary solution in the com... | {
"author": "Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= <berrange@redhat.com>",
"date": "Thu, 26 Feb 2026 14:26:13 +0000",
"is_openbsd": false,
"thread_id": "20260225192808.957477-1-jsnow@redhat.com.mbox.gz"
} |
lkml_critique | qemu-devel | Signed-off-by: John Snow <jsnow@redhat.com>
---
configure | 4 ++--
python/setup.cfg | 3 ++-
2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/configure b/configure
index c4837eba2b1..d44e9e86148 100755
--- a/configure
+++ b/configure
@@ -527,8 +527,8 @@ first_python=
if test -z "${PYTHON}"; then... | null | null | null | [PATCH v2 4/4] python: add formal python3.14 support and testing | On Thu, Feb 26, 2026 at 9:26 AM Daniel P. Berrangé <berrange@redhat.com> wrote:
Admittedly I wasn't thinking about just using meson directly, so I
suppose this *is* just a stepping stone. My only question for meson
integration is how can I set up the deps so that "make check" will try
to install the linting deps and r... | {
"author": "John Snow <jsnow@redhat.com>",
"date": "Thu, 26 Feb 2026 12:51:46 -0500",
"is_openbsd": false,
"thread_id": "20260225192808.957477-1-jsnow@redhat.com.mbox.gz"
} |
lkml_critique | qemu-devel | Signed-off-by: John Snow <jsnow@redhat.com>
---
configure | 4 ++--
python/setup.cfg | 3 ++-
2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/configure b/configure
index c4837eba2b1..d44e9e86148 100755
--- a/configure
+++ b/configure
@@ -527,8 +527,8 @@ first_python=
if test -z "${PYTHON}"; then... | null | null | null | [PATCH v2 4/4] python: add formal python3.14 support and testing | On Thu, Feb 26, 2026 at 12:51:46PM -0500, John Snow wrote:
I didn't handle the complexity of venvs in my old series. IIRC I just
blindly used the host python tools, since it was just PoC quality not
a mergable series.
When doing it for real, we'd end up wanting a selection of different
meson suites. Perhaps a default... | {
"author": "Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= <berrange@redhat.com>",
"date": "Fri, 27 Feb 2026 11:29:20 +0000",
"is_openbsd": false,
"thread_id": "20260225192808.957477-1-jsnow@redhat.com.mbox.gz"
} |
lkml_critique | qemu-devel | Hey everyone,
This is v5 of performant CXL type 3 regions set:
v4 -> v5: Fixed some minor patch style like missing trailing whilespace and such.
v3 -> v4: 1) Tear down path changed, given that it is done differently than
setup.
2) Dropped Gregory's tested-by tag due to tear down changes.
v2 -> v3:... | null | null | null | [PATCH v5 0/3] hw/cxl: Add a performant (and correct) path for the
non interleaved cases | This function will shortly be used to help find if there is a route to a
device, serving an HPA, under a particular fixed memory window. Rather than
having that new use case subtract the base address in the caller, only to
add it again in cxl_cfmws_find_device(), push the responsibility for
calculating the HPA to the c... | {
"author": "Alireza Sanaee via qemu development <qemu-devel@nongnu.org>",
"date": "Wed, 25 Feb 2026 18:07:16 +0000",
"is_openbsd": false,
"thread_id": "20260225180718.480-1-alireza.sanaee@huawei.com.mbox.gz"
} |
lkml_critique | qemu-devel | Hey everyone,
This is v5 of performant CXL type 3 regions set:
v4 -> v5: Fixed some minor patch style like missing trailing whilespace and such.
v3 -> v4: 1) Tear down path changed, given that it is done differently than
setup.
2) Dropped Gregory's tested-by tag due to tear down changes.
v2 -> v3:... | null | null | null | [PATCH v5 0/3] hw/cxl: Add a performant (and correct) path for the
non interleaved cases | Extend cxl_cfmws_find_device() with a parameter that filters on whether the
address lies in an interleaved range. For now all callers accept
interleave configurations so no functional changes.
Signed-off-by: Alireza Sanaee <alireza.sanaee@huawei.com>
---
hw/cxl/cxl-host.c | 33 ++++++++++++++++++++++++++-------
1 fil... | {
"author": "Alireza Sanaee via qemu development <qemu-devel@nongnu.org>",
"date": "Wed, 25 Feb 2026 18:07:17 +0000",
"is_openbsd": false,
"thread_id": "20260225180718.480-1-alireza.sanaee@huawei.com.mbox.gz"
} |
lkml_critique | qemu-devel | Hey everyone,
This is v5 of performant CXL type 3 regions set:
v4 -> v5: Fixed some minor patch style like missing trailing whilespace and such.
v3 -> v4: 1) Tear down path changed, given that it is done differently than
setup.
2) Dropped Gregory's tested-by tag due to tear down changes.
v2 -> v3:... | null | null | null | [PATCH v5 0/3] hw/cxl: Add a performant (and correct) path for the
non interleaved cases | The CXL address to device decoding logic is complex because of the need to
correctly decode fine grained interleave. The current implementation
prevents use with KVM where executed instructions may reside in that memory
and gives very slow performance even in TCG.
In many real cases non interleaved memory configuratio... | {
"author": "Alireza Sanaee via qemu development <qemu-devel@nongnu.org>",
"date": "Wed, 25 Feb 2026 18:07:18 +0000",
"is_openbsd": false,
"thread_id": "20260225180718.480-1-alireza.sanaee@huawei.com.mbox.gz"
} |
lkml_critique | qemu-devel | Hey everyone,
This is v5 of performant CXL type 3 regions set:
v4 -> v5: Fixed some minor patch style like missing trailing whilespace and such.
v3 -> v4: 1) Tear down path changed, given that it is done differently than
setup.
2) Dropped Gregory's tested-by tag due to tear down changes.
v2 -> v3:... | null | null | null | [PATCH v5 0/3] hw/cxl: Add a performant (and correct) path for the
non interleaved cases | On Wed, Feb 25, 2026 at 06:07:18PM +0000, Alireza Sanaee via qemu development wrote:
kreview flagged this, seems reasonable given other examples in the tree
The other commits looked ok, I'll try to get around to testing this soon.
~Gregory
---
Reported-by: kreview-8842242
The alias parameters (target MR, offset, ... | {
"author": "Gregory Price <gourry@gourry.net>",
"date": "Wed, 25 Feb 2026 15:34:27 -0500",
"is_openbsd": false,
"thread_id": "20260225180718.480-1-alireza.sanaee@huawei.com.mbox.gz"
} |
lkml_critique | qemu-devel | Hey everyone,
This is v5 of performant CXL type 3 regions set:
v4 -> v5: Fixed some minor patch style like missing trailing whilespace and such.
v3 -> v4: 1) Tear down path changed, given that it is done differently than
setup.
2) Dropped Gregory's tested-by tag due to tear down changes.
v2 -> v3:... | null | null | null | [PATCH v5 0/3] hw/cxl: Add a performant (and correct) path for the
non interleaved cases | On Wed, 25 Feb 2026 15:34:27 -0500
Gregory Price <gourry@gourry.net> wrote:
Hi Gregory,
This was actually my question as well, but I tested with a scenario in which I
created a region with its alias. Then I torn down that region so that the alias
goes away, and finally reinitialized the same region to reuse the de... | {
"author": "Alireza Sanaee via qemu development <qemu-devel@nongnu.org>",
"date": "Thu, 26 Feb 2026 00:14:05 +0000",
"is_openbsd": false,
"thread_id": "20260225180718.480-1-alireza.sanaee@huawei.com.mbox.gz"
} |
lkml_critique | qemu-devel | Hey everyone,
This is v5 of performant CXL type 3 regions set:
v4 -> v5: Fixed some minor patch style like missing trailing whilespace and such.
v3 -> v4: 1) Tear down path changed, given that it is done differently than
setup.
2) Dropped Gregory's tested-by tag due to tear down changes.
v2 -> v3:... | null | null | null | [PATCH v5 0/3] hw/cxl: Add a performant (and correct) path for the
non interleaved cases | On Thu, 26 Feb 2026 00:14:05 +0000
Alireza Sanaee <alireza.sanaee@huawei.com> wrote:
It is more elegant (and keeps the introspection stuff reporting correctly)
to unparent the object on delete. To test this you'd need to bring it up in a different
cfmws so the parent changes. So this is good feedback.
There is a se... | {
"author": "Jonathan Cameron via qemu development <qemu-devel@nongnu.org>",
"date": "Fri, 27 Feb 2026 10:36:20 +0000",
"is_openbsd": false,
"thread_id": "20260225180718.480-1-alireza.sanaee@huawei.com.mbox.gz"
} |
lkml_critique | qemu-devel | M4/M5 Macs support SME2, and HVF exposes this functionality in its
public API.
Add support for it in QEMU.
This was tested by running an SME2 benchmark from Arm [0]. savevm and
loadvm during the benchmark's run were used to verify migration works.
[0]:
https://learn.arm.com/learning-paths/cross-platform/multiplying-... | null | null | null | [PATCH v5 0/2] arm/hvf: Add SME2 support | Starting from M4 cores and MacOS 15.2 SDK, HVF can virtualise FEAT_SME2.
Signed-off-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
---
target/arm/hvf/hvf.c | 29 +++++++++++++++++------------
1 file changed, 17 insertions(+), 12 deletions(-)
diff --git a/target/arm/hvf/hvf.c b/target/arm/hvf/hvf.c
index 3d... | {
"author": "Manos Pitsidianakis <manos.pitsidianakis@linaro.org>",
"date": "Fri, 27 Feb 2026 10:56:47 +0200",
"is_openbsd": false,
"thread_id": "20260227-sme2-hvf-v5-2-1c60a92910c8@linaro.org.mbox.gz"
} |
lkml_critique | qemu-devel | M4/M5 Macs support SME2, and HVF exposes this functionality in its
public API.
Add support for it in QEMU.
This was tested by running an SME2 benchmark from Arm [0]. savevm and
loadvm during the benchmark's run were used to verify migration works.
[0]:
https://learn.arm.com/learning-paths/cross-platform/multiplying-... | null | null | null | [PATCH v5 0/2] arm/hvf: Add SME2 support | SME2 support adds the following state for HVF guests:
- Vector registers Z0, ... , Z31 (introduced by FEAT_SVE but HVF does
not support it)
- Predicate registers P0, .., P15 (also FEAT_SVE)
- ZA register
- ZT0 register
- PSTATE.{SM,ZA} bits (SVCR pseudo-register)
- SMPRI_EL1 which handles the PE's priority in the SM... | {
"author": "Manos Pitsidianakis <manos.pitsidianakis@linaro.org>",
"date": "Fri, 27 Feb 2026 10:56:46 +0200",
"is_openbsd": false,
"thread_id": "20260227-sme2-hvf-v5-2-1c60a92910c8@linaro.org.mbox.gz"
} |
lkml_critique | qemu-devel | When loading a subset, its name is checked for the parent prefix. The
following bug may occur here:
Let's say there is a vmstate named "virtio-blk", it has a subsection
named "virtio-blk/subsection", and it also has another vmstate named
"virtio" in the fields.
Then, during the migration, when trying to load this subs... | null | null | null | [PATCH v1] vmstate: fix subsection load name check | On Fri, Feb 20, 2026 at 03:26:29PM +0500, Alexandr Moshkov wrote:
Checking versus '\' looks reasonable, however I'm still confused on the
example given, and what problem you hit.
Here, your concern seems to be that vmstate_subsection_load() can
accidentally load a FIELD of the parent VMSD whose name is exactly the na... | {
"author": "Peter Xu <peterx@redhat.com>",
"date": "Mon, 23 Feb 2026 13:58:51 -0500",
"is_openbsd": false,
"thread_id": "8614c317-8643-4243-abe4-9653e40149a2@yandex-team.ru.mbox.gz"
} |
lkml_critique | qemu-devel | When loading a subset, its name is checked for the parent prefix. The
following bug may occur here:
Let's say there is a vmstate named "virtio-blk", it has a subsection
named "virtio-blk/subsection", and it also has another vmstate named
"virtio" in the fields.
Then, during the migration, when trying to load this subs... | null | null | null | [PATCH v1] vmstate: fix subsection load name check | On 2/23/26 23:58, Peter Xu wrote:
Thanks for reply,
vmstate_subsection_load() while trying to load a FIELD (whose name is
prefix of parent name) of the parent VMSD will try to load parent
subsection.
Here is code example:
```
static const VMStateDescription vmstate_vhost_user_virtio_blk_inflight = {
.name = "vi... | {
"author": "Alexandr Moshkov <dtalexundeer@yandex-team.ru>",
"date": "Tue, 24 Feb 2026 12:10:20 +0500",
"is_openbsd": false,
"thread_id": "8614c317-8643-4243-abe4-9653e40149a2@yandex-team.ru.mbox.gz"
} |
lkml_critique | qemu-devel | When loading a subset, its name is checked for the parent prefix. The
following bug may occur here:
Let's say there is a vmstate named "virtio-blk", it has a subsection
named "virtio-blk/subsection", and it also has another vmstate named
"virtio" in the fields.
Then, during the migration, when trying to load this subs... | null | null | null | [PATCH v1] vmstate: fix subsection load name check | On Tue, Feb 24, 2026 at 12:10:20PM +0500, Alexandr Moshkov wrote:
Thanks for the details. However it didn't resolve my confusion. Let me
ask more explicitly.
In this case, VMSTATE_VIRTIO_DEVICE will be a single field in the parent
vmsd of "virtio-blk". Meanwhile, "virtio-blk/inflight" will be the only
subsection.
... | {
"author": "Peter Xu <peterx@redhat.com>",
"date": "Tue, 24 Feb 2026 11:13:52 -0500",
"is_openbsd": false,
"thread_id": "8614c317-8643-4243-abe4-9653e40149a2@yandex-team.ru.mbox.gz"
} |
lkml_critique | qemu-devel | When loading a subset, its name is checked for the parent prefix. The
following bug may occur here:
Let's say there is a vmstate named "virtio-blk", it has a subsection
named "virtio-blk/subsection", and it also has another vmstate named
"virtio" in the fields.
Then, during the migration, when trying to load this subs... | null | null | null | [PATCH v1] vmstate: fix subsection load name check | On 2/24/26 21:13, Peter Xu wrote:
Yes, and it will return -ENOENT. This causes an error in upper function.
Error in destination qemu logs will looks like this:
[... load virtio field ...]
vmstate_subsection_load_bad virtio: virtio-blk/inflight/(lookup)
qemu-system-x86_64: Failed to load virtio-blk:virtio
vmstate_loa... | {
"author": "Alexandr Moshkov <dtalexundeer@yandex-team.ru>",
"date": "Wed, 25 Feb 2026 11:04:40 +0500",
"is_openbsd": false,
"thread_id": "8614c317-8643-4243-abe4-9653e40149a2@yandex-team.ru.mbox.gz"
} |
lkml_critique | qemu-devel | When loading a subset, its name is checked for the parent prefix. The
following bug may occur here:
Let's say there is a vmstate named "virtio-blk", it has a subsection
named "virtio-blk/subsection", and it also has another vmstate named
"virtio" in the fields.
Then, during the migration, when trying to load this subs... | null | null | null | [PATCH v1] vmstate: fix subsection load name check | On Wed, Feb 25, 2026 at 11:04:40AM +0500, Alexandr Moshkov wrote:
Yes, this implies vmstate_get_subsection() failure.
This implies the above failure happened in a nested load of
"virtio-blk:virtio", rather than the top "virtio-blk".
Here virtio_load invokes two vmstate_load_state on vdc->vmsd,
vmstate_virtio.
If t... | {
"author": "Peter Xu <peterx@redhat.com>",
"date": "Wed, 25 Feb 2026 12:23:38 -0500",
"is_openbsd": false,
"thread_id": "8614c317-8643-4243-abe4-9653e40149a2@yandex-team.ru.mbox.gz"
} |
lkml_critique | qemu-devel | When loading a subset, its name is checked for the parent prefix. The
following bug may occur here:
Let's say there is a vmstate named "virtio-blk", it has a subsection
named "virtio-blk/subsection", and it also has another vmstate named
"virtio" in the fields.
Then, during the migration, when trying to load this subs... | null | null | null | [PATCH v1] vmstate: fix subsection load name check | On 2/25/26 22:23, Peter Xu wrote:
Yes, looks like it happens because migration stream for "virtio-blk"
looks like this:
[virtio-blk header] [virtio-blk fields] [virtio-blk subsections]
"virtio-blk" contains "virtio" field, so migration stream is:
[virtio-blk header] [virtio header] [virtio fields] [virtio subsecti... | {
"author": "Alexandr Moshkov <dtalexundeer@yandex-team.ru>",
"date": "Thu, 26 Feb 2026 12:47:55 +0500",
"is_openbsd": false,
"thread_id": "8614c317-8643-4243-abe4-9653e40149a2@yandex-team.ru.mbox.gz"
} |
lkml_critique | qemu-devel | When loading a subset, its name is checked for the parent prefix. The
following bug may occur here:
Let's say there is a vmstate named "virtio-blk", it has a subsection
named "virtio-blk/subsection", and it also has another vmstate named
"virtio" in the fields.
Then, during the migration, when trying to load this subs... | null | null | null | [PATCH v1] vmstate: fix subsection load name check | On Thu, Feb 26, 2026 at 12:47:55PM +0500, Alexandr Moshkov wrote:
OK I see, thanks for the details.
I think I missed one important thing, that we don't treat
trace_vmstate_subsection_load_bad("(prefix)") as errors.. instead we
fallback to the upper layer by returning zero.
Could you put most of above reply into the ... | {
"author": "Peter Xu <peterx@redhat.com>",
"date": "Thu, 26 Feb 2026 10:20:34 -0500",
"is_openbsd": false,
"thread_id": "8614c317-8643-4243-abe4-9653e40149a2@yandex-team.ru.mbox.gz"
} |
lkml_critique | qemu-devel | ---
hw/riscv/boot.c | 19 +++++++++++++++++--
1 file changed, 17 insertions(+), 2 deletions(-)
diff --git a/hw/riscv/boot.c b/hw/riscv/boot.c
index e5490beda0..dc9f8a7327 100644
--- a/hw/riscv/boot.c
+++ b/hw/riscv/boot.c
@@ -31,6 +31,7 @@
#include "system/qtest.h"
#include "system/kvm.h"
#include "system/reset.h"... | null | null | null | [PATCH v2 05/16] hw/riscv: Ensure bootrom has correct endianess | From: djtodoro <djordje.todorovic@htecgroup.com>
RISC-V instructions are always little-endian. Use translator_ldl_end
and translator_lduw_end with MO_LE instead of tswap on translator_ldl
results.
---
target/riscv/translate.c | 15 ++++++---------
1 file changed, 6 insertions(+), 9 deletions(-)
diff --git a/target/r... | {
"author": "Djordje Todorovic <Djordje.Todorovic@htecgroup.com>",
"date": "Wed, 25 Feb 2026 10:20:29 +0000",
"is_openbsd": false,
"thread_id": "74977a25-e92e-46d9-b522-50b8fe2d00cc@htecgroup.com.mbox.gz"
} |
lkml_critique | qemu-devel | ---
hw/riscv/boot.c | 19 +++++++++++++++++--
1 file changed, 17 insertions(+), 2 deletions(-)
diff --git a/hw/riscv/boot.c b/hw/riscv/boot.c
index e5490beda0..dc9f8a7327 100644
--- a/hw/riscv/boot.c
+++ b/hw/riscv/boot.c
@@ -31,6 +31,7 @@
#include "system/qtest.h"
#include "system/kvm.h"
#include "system/reset.h"... | null | null | null | [PATCH v2 05/16] hw/riscv: Ensure bootrom has correct endianess | From: djtodoro <djordje.todorovic@htecgroup.com>
Define MSTATUS_SBE (bit 36) and MSTATUS_MBE (bit 37) and set them alongside MSTATUS_UBE at CPU reset for big-endian targets.
---
target/riscv/cpu.c | 2 +-
target/riscv/cpu_bits.h | 2 ++
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/target/riscv/c... | {
"author": "Djordje Todorovic <Djordje.Todorovic@htecgroup.com>",
"date": "Wed, 25 Feb 2026 10:20:28 +0000",
"is_openbsd": false,
"thread_id": "74977a25-e92e-46d9-b522-50b8fe2d00cc@htecgroup.com.mbox.gz"
} |
lkml_critique | qemu-devel | ---
hw/riscv/boot.c | 19 +++++++++++++++++--
1 file changed, 17 insertions(+), 2 deletions(-)
diff --git a/hw/riscv/boot.c b/hw/riscv/boot.c
index e5490beda0..dc9f8a7327 100644
--- a/hw/riscv/boot.c
+++ b/hw/riscv/boot.c
@@ -31,6 +31,7 @@
#include "system/qtest.h"
#include "system/kvm.h"
#include "system/reset.h"... | null | null | null | [PATCH v2 05/16] hw/riscv: Ensure bootrom has correct endianess | load_elf_ram_sym has a `big_endian` paramater that notifies
it if the loaded elf file is expected to be LE or BE. This
paramater needs to be set based on target endianess to ensure
proper elf loading.
---
hw/riscv/boot.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/hw/riscv/boot.c b/hw/r... | {
"author": "Djordje Todorovic <Djordje.Todorovic@htecgroup.com>",
"date": "Wed, 25 Feb 2026 10:20:26 +0000",
"is_openbsd": false,
"thread_id": "74977a25-e92e-46d9-b522-50b8fe2d00cc@htecgroup.com.mbox.gz"
} |
lkml_critique | qemu-devel | ---
hw/riscv/boot.c | 19 +++++++++++++++++--
1 file changed, 17 insertions(+), 2 deletions(-)
diff --git a/hw/riscv/boot.c b/hw/riscv/boot.c
index e5490beda0..dc9f8a7327 100644
--- a/hw/riscv/boot.c
+++ b/hw/riscv/boot.c
@@ -31,6 +31,7 @@
#include "system/qtest.h"
#include "system/kvm.h"
#include "system/reset.h"... | null | null | null | [PATCH v2 05/16] hw/riscv: Ensure bootrom has correct endianess | Add options to compile riscv64be-softmmu and riscv32be-softmmu
---
meson.build | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/meson.build b/meson.build
index 8c6c0a9a32..41ad38d184 100644
--- a/meson.build
+++ b/meson.build
@@ -55,6 +55,11 @@ supported_cpus = ['ppc64', 's390x', 'riscv64', 'x... | {
"author": "Djordje Todorovic <Djordje.Todorovic@htecgroup.com>",
"date": "Wed, 25 Feb 2026 10:20:25 +0000",
"is_openbsd": false,
"thread_id": "74977a25-e92e-46d9-b522-50b8fe2d00cc@htecgroup.com.mbox.gz"
} |
lkml_critique | qemu-devel | ---
hw/riscv/boot.c | 19 +++++++++++++++++--
1 file changed, 17 insertions(+), 2 deletions(-)
diff --git a/hw/riscv/boot.c b/hw/riscv/boot.c
index e5490beda0..dc9f8a7327 100644
--- a/hw/riscv/boot.c
+++ b/hw/riscv/boot.c
@@ -31,6 +31,7 @@
#include "system/qtest.h"
#include "system/kvm.h"
#include "system/reset.h"... | null | null | null | [PATCH v2 05/16] hw/riscv: Ensure bootrom has correct endianess | From: djtodoro <djordje.todorovic@htecgroup.com>
Use tswap32/tswap64 instead of hardcoded cpu_to_le32/le64 for PTE
atomic compare-and-swap updates, so the encoding matches how PTEs
are read via address_space_ldl/ldq (target endian).
---
target/riscv/cpu_helper.c | 9 +++++----
1 file changed, 5 insertions(+), 4 delet... | {
"author": "Djordje Todorovic <Djordje.Todorovic@htecgroup.com>",
"date": "Wed, 25 Feb 2026 10:20:29 +0000",
"is_openbsd": false,
"thread_id": "74977a25-e92e-46d9-b522-50b8fe2d00cc@htecgroup.com.mbox.gz"
} |
lkml_critique | qemu-devel | ---
hw/riscv/boot.c | 19 +++++++++++++++++--
1 file changed, 17 insertions(+), 2 deletions(-)
diff --git a/hw/riscv/boot.c b/hw/riscv/boot.c
index e5490beda0..dc9f8a7327 100644
--- a/hw/riscv/boot.c
+++ b/hw/riscv/boot.c
@@ -31,6 +31,7 @@
#include "system/qtest.h"
#include "system/kvm.h"
#include "system/reset.h"... | null | null | null | [PATCH v2 05/16] hw/riscv: Ensure bootrom has correct endianess | From: djtodoro <djordje.todorovic@htecgroup.com>
The virtio-mmio transport registers are always little-endian per spec.
DEVICE_NATIVE_ENDIAN caused a double byte-swap on BE targets, making
the kernel see a swapped magic value.
---
hw/virtio/virtio-mmio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --g... | {
"author": "Djordje Todorovic <Djordje.Todorovic@htecgroup.com>",
"date": "Wed, 25 Feb 2026 10:20:29 +0000",
"is_openbsd": false,
"thread_id": "74977a25-e92e-46d9-b522-50b8fe2d00cc@htecgroup.com.mbox.gz"
} |
lkml_critique | qemu-devel | ---
hw/riscv/boot.c | 19 +++++++++++++++++--
1 file changed, 17 insertions(+), 2 deletions(-)
diff --git a/hw/riscv/boot.c b/hw/riscv/boot.c
index e5490beda0..dc9f8a7327 100644
--- a/hw/riscv/boot.c
+++ b/hw/riscv/boot.c
@@ -31,6 +31,7 @@
#include "system/qtest.h"
#include "system/kvm.h"
#include "system/reset.h"... | null | null | null | [PATCH v2 05/16] hw/riscv: Ensure bootrom has correct endianess | From: djtodoro <djordje.todorovic@htecgroup.com>
---
linux-user/riscv/target_elf.h | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/linux-user/riscv/target_elf.h b/linux-user/riscv/target_elf.h
index dbbfdf54d3..6f416ac3e2 100644
--- a/linux-user/riscv/target_elf.h
+++ b/linux-user/riscv... | {
"author": "Djordje Todorovic <Djordje.Todorovic@htecgroup.com>",
"date": "Wed, 25 Feb 2026 10:20:28 +0000",
"is_openbsd": false,
"thread_id": "74977a25-e92e-46d9-b522-50b8fe2d00cc@htecgroup.com.mbox.gz"
} |
lkml_critique | qemu-devel | ---
hw/riscv/boot.c | 19 +++++++++++++++++--
1 file changed, 17 insertions(+), 2 deletions(-)
diff --git a/hw/riscv/boot.c b/hw/riscv/boot.c
index e5490beda0..dc9f8a7327 100644
--- a/hw/riscv/boot.c
+++ b/hw/riscv/boot.c
@@ -31,6 +31,7 @@
#include "system/qtest.h"
#include "system/kvm.h"
#include "system/reset.h"... | null | null | null | [PATCH v2 05/16] hw/riscv: Ensure bootrom has correct endianess | Add new RISCV softmmu targets that define TARGET_BIG_ENDIAN=1
---
configs/targets/riscv32be-softmmu.mak | 8 ++++++++
configs/targets/riscv64be-softmmu.mak | 8 ++++++++
2 files changed, 16 insertions(+)
create mode 100644 configs/targets/riscv32be-softmmu.mak
create mode 100644 configs/targets/riscv64be-softmmu.mak... | {
"author": "Djordje Todorovic <Djordje.Todorovic@htecgroup.com>",
"date": "Wed, 25 Feb 2026 10:20:25 +0000",
"is_openbsd": false,
"thread_id": "74977a25-e92e-46d9-b522-50b8fe2d00cc@htecgroup.com.mbox.gz"
} |
lkml_critique | qemu-devel | ---
hw/riscv/boot.c | 19 +++++++++++++++++--
1 file changed, 17 insertions(+), 2 deletions(-)
diff --git a/hw/riscv/boot.c b/hw/riscv/boot.c
index e5490beda0..dc9f8a7327 100644
--- a/hw/riscv/boot.c
+++ b/hw/riscv/boot.c
@@ -31,6 +31,7 @@
#include "system/qtest.h"
#include "system/kvm.h"
#include "system/reset.h"... | null | null | null | [PATCH v2 05/16] hw/riscv: Ensure bootrom has correct endianess | From: djtodoro <djordje.todorovic@htecgroup.com>
---
configs/targets/riscv32be-linux-user.mak | 4 ++++
configs/targets/riscv64be-linux-user.mak | 4 ++++
2 files changed, 8 insertions(+)
diff --git a/configs/targets/riscv32be-linux-user.mak b/configs/targets/riscv32be-linux-user.mak
index bca84945d9..4654eb41ed 100... | {
"author": "Djordje Todorovic <Djordje.Todorovic@htecgroup.com>",
"date": "Wed, 25 Feb 2026 10:20:28 +0000",
"is_openbsd": false,
"thread_id": "74977a25-e92e-46d9-b522-50b8fe2d00cc@htecgroup.com.mbox.gz"
} |
lkml_critique | qemu-devel | ---
hw/riscv/boot.c | 19 +++++++++++++++++--
1 file changed, 17 insertions(+), 2 deletions(-)
diff --git a/hw/riscv/boot.c b/hw/riscv/boot.c
index e5490beda0..dc9f8a7327 100644
--- a/hw/riscv/boot.c
+++ b/hw/riscv/boot.c
@@ -31,6 +31,7 @@
#include "system/qtest.h"
#include "system/kvm.h"
#include "system/reset.h"... | null | null | null | [PATCH v2 05/16] hw/riscv: Ensure bootrom has correct endianess | This series adds big-endian (BE) RISC-V target support to QEMU,
covering both softmmu and linux-user emulation for riscv32be and
riscv64be.
The RISC-V ISA supports big-endian operation via the mstatus SBE/MBE/UBE
bits. While instructions are always little-endian, data accesses follow
the configured endianness. This s... | {
"author": "Djordje Todorovic <Djordje.Todorovic@htecgroup.com>",
"date": "Wed, 25 Feb 2026 10:20:24 +0000",
"is_openbsd": false,
"thread_id": "74977a25-e92e-46d9-b522-50b8fe2d00cc@htecgroup.com.mbox.gz"
} |
lkml_critique | qemu-devel | ---
hw/riscv/boot.c | 19 +++++++++++++++++--
1 file changed, 17 insertions(+), 2 deletions(-)
diff --git a/hw/riscv/boot.c b/hw/riscv/boot.c
index e5490beda0..dc9f8a7327 100644
--- a/hw/riscv/boot.c
+++ b/hw/riscv/boot.c
@@ -31,6 +31,7 @@
#include "system/qtest.h"
#include "system/kvm.h"
#include "system/reset.h"... | null | null | null | [PATCH v2 05/16] hw/riscv: Ensure bootrom has correct endianess | With the insroduction of BE RISCV target, instruction fetching
needs to always expect instructions to be LE encoded as specified
by the RISCV specification.
---
target/riscv/translate.c | 17 ++++++++++-------
1 file changed, 10 insertions(+), 7 deletions(-)
diff --git a/target/riscv/translate.c b/target/riscv/transl... | {
"author": "Djordje Todorovic <Djordje.Todorovic@htecgroup.com>",
"date": "Wed, 25 Feb 2026 10:20:26 +0000",
"is_openbsd": false,
"thread_id": "74977a25-e92e-46d9-b522-50b8fe2d00cc@htecgroup.com.mbox.gz"
} |
lkml_critique | qemu-devel | ---
hw/riscv/boot.c | 19 +++++++++++++++++--
1 file changed, 17 insertions(+), 2 deletions(-)
diff --git a/hw/riscv/boot.c b/hw/riscv/boot.c
index e5490beda0..dc9f8a7327 100644
--- a/hw/riscv/boot.c
+++ b/hw/riscv/boot.c
@@ -31,6 +31,7 @@
#include "system/qtest.h"
#include "system/kvm.h"
#include "system/reset.h"... | null | null | null | [PATCH v2 05/16] hw/riscv: Ensure bootrom has correct endianess | When the RISC-V target is built as big-endian, ensure that is signaled
in mstatus via UBE bit.
---
target/riscv/cpu.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c
index e95eea0249..0e24f2cbcd 100644
--- a/target/riscv/cpu.c
+++ b/target/riscv/cpu.c
@@ -716,6 +716,9 @@ ... | {
"author": "Djordje Todorovic <Djordje.Todorovic@htecgroup.com>",
"date": "Wed, 25 Feb 2026 10:20:27 +0000",
"is_openbsd": false,
"thread_id": "74977a25-e92e-46d9-b522-50b8fe2d00cc@htecgroup.com.mbox.gz"
} |
lkml_critique | qemu-devel | ---
hw/riscv/boot.c | 19 +++++++++++++++++--
1 file changed, 17 insertions(+), 2 deletions(-)
diff --git a/hw/riscv/boot.c b/hw/riscv/boot.c
index e5490beda0..dc9f8a7327 100644
--- a/hw/riscv/boot.c
+++ b/hw/riscv/boot.c
@@ -31,6 +31,7 @@
#include "system/qtest.h"
#include "system/kvm.h"
#include "system/reset.h"... | null | null | null | [PATCH v2 05/16] hw/riscv: Ensure bootrom has correct endianess | From: djtodoro <djordje.todorovic@htecgroup.com>
---
qapi/machine.json | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/qapi/machine.json b/qapi/machine.json
index 907cb25f75..b62b8a1896 100644
--- a/qapi/machine.json
+++ b/qapi/machine.json
@@ -38,7 +38,8 @@
'data' : [ 'aarch64', 'alpha', 'ar... | {
"author": "Djordje Todorovic <Djordje.Todorovic@htecgroup.com>",
"date": "Wed, 25 Feb 2026 10:20:29 +0000",
"is_openbsd": false,
"thread_id": "74977a25-e92e-46d9-b522-50b8fe2d00cc@htecgroup.com.mbox.gz"
} |
lkml_critique | qemu-devel | ---
hw/riscv/boot.c | 19 +++++++++++++++++--
1 file changed, 17 insertions(+), 2 deletions(-)
diff --git a/hw/riscv/boot.c b/hw/riscv/boot.c
index e5490beda0..dc9f8a7327 100644
--- a/hw/riscv/boot.c
+++ b/hw/riscv/boot.c
@@ -31,6 +31,7 @@
#include "system/qtest.h"
#include "system/kvm.h"
#include "system/reset.h"... | null | null | null | [PATCH v2 05/16] hw/riscv: Ensure bootrom has correct endianess | For riscvbe target, the fields for OpenSBI's fw_payload
need to be in target endian.
---
hw/riscv/boot.c | 14 ++++++++++++++
include/hw/riscv/boot.h | 5 +++++
2 files changed, 19 insertions(+)
diff --git a/hw/riscv/boot.c b/hw/riscv/boot.c
index 6dab521a6b..f13264a87f 100644
--- a/hw/riscv/boot.c
+++ b/hw/... | {
"author": "Djordje Todorovic <Djordje.Todorovic@htecgroup.com>",
"date": "Wed, 25 Feb 2026 10:20:27 +0000",
"is_openbsd": false,
"thread_id": "74977a25-e92e-46d9-b522-50b8fe2d00cc@htecgroup.com.mbox.gz"
} |
lkml_critique | qemu-devel | ---
hw/riscv/boot.c | 19 +++++++++++++++++--
1 file changed, 17 insertions(+), 2 deletions(-)
diff --git a/hw/riscv/boot.c b/hw/riscv/boot.c
index e5490beda0..dc9f8a7327 100644
--- a/hw/riscv/boot.c
+++ b/hw/riscv/boot.c
@@ -31,6 +31,7 @@
#include "system/qtest.h"
#include "system/kvm.h"
#include "system/reset.h"... | null | null | null | [PATCH v2 05/16] hw/riscv: Ensure bootrom has correct endianess | Add new configs for BE RISCV softmmu targets.
---
configs/devices/riscv32be-softmmu/default.mak | 15 +++++++++++++++
configs/devices/riscv64be-softmmu/default.mak | 16 ++++++++++++++++
2 files changed, 31 insertions(+)
create mode 100644 configs/devices/riscv32be-softmmu/default.mak
create mode 100644 configs/devi... | {
"author": "Djordje Todorovic <Djordje.Todorovic@htecgroup.com>",
"date": "Wed, 25 Feb 2026 10:20:25 +0000",
"is_openbsd": false,
"thread_id": "74977a25-e92e-46d9-b522-50b8fe2d00cc@htecgroup.com.mbox.gz"
} |
lkml_critique | qemu-devel | ---
hw/riscv/boot.c | 19 +++++++++++++++++--
1 file changed, 17 insertions(+), 2 deletions(-)
diff --git a/hw/riscv/boot.c b/hw/riscv/boot.c
index e5490beda0..dc9f8a7327 100644
--- a/hw/riscv/boot.c
+++ b/hw/riscv/boot.c
@@ -31,6 +31,7 @@
#include "system/qtest.h"
#include "system/kvm.h"
#include "system/reset.h"... | null | null | null | [PATCH v2 05/16] hw/riscv: Ensure bootrom has correct endianess | This commit adds necessary tagets to build Qemu for RISC-V userspace
emulation.
---
configs/targets/riscv32be-linux-user.mak | 7 +++++++
configs/targets/riscv64be-linux-user.mak | 7 +++++++
2 files changed, 14 insertions(+)
create mode 100644 configs/targets/riscv32be-linux-user.mak
create mode 100644 configs/targ... | {
"author": "Djordje Todorovic <Djordje.Todorovic@htecgroup.com>",
"date": "Wed, 25 Feb 2026 10:20:27 +0000",
"is_openbsd": false,
"thread_id": "74977a25-e92e-46d9-b522-50b8fe2d00cc@htecgroup.com.mbox.gz"
} |
lkml_critique | qemu-devel | ---
hw/riscv/boot.c | 19 +++++++++++++++++--
1 file changed, 17 insertions(+), 2 deletions(-)
diff --git a/hw/riscv/boot.c b/hw/riscv/boot.c
index e5490beda0..dc9f8a7327 100644
--- a/hw/riscv/boot.c
+++ b/hw/riscv/boot.c
@@ -31,6 +31,7 @@
#include "system/qtest.h"
#include "system/kvm.h"
#include "system/reset.h"... | null | null | null | [PATCH v2 05/16] hw/riscv: Ensure bootrom has correct endianess | On 25/02/2026 11.20, Djordje Todorovic wrote:
I really dislike the idea of having yet another target like mips where we
have 4 different flavours (32/64 bits x big/little endian). That increases
the compile- and testing time a lot. Couldn't you do it the ppc64 way? The
ppc64-softmmu target can handle both, big and ... | {
"author": "Thomas Huth <thuth@redhat.com>",
"date": "Wed, 25 Feb 2026 11:39:50 +0100",
"is_openbsd": false,
"thread_id": "74977a25-e92e-46d9-b522-50b8fe2d00cc@htecgroup.com.mbox.gz"
} |
lkml_critique | qemu-devel | ---
hw/riscv/boot.c | 19 +++++++++++++++++--
1 file changed, 17 insertions(+), 2 deletions(-)
diff --git a/hw/riscv/boot.c b/hw/riscv/boot.c
index e5490beda0..dc9f8a7327 100644
--- a/hw/riscv/boot.c
+++ b/hw/riscv/boot.c
@@ -31,6 +31,7 @@
#include "system/qtest.h"
#include "system/kvm.h"
#include "system/reset.h"... | null | null | null | [PATCH v2 05/16] hw/riscv: Ensure bootrom has correct endianess | Hello,
There’s no Linux RISC-V big endian. Maybe the right thing to do is to not
support it unless we’re sure that it can get to Linux upstream (for the linux-user mode)?
Thank you,
-Mohamed | {
"author": "Mohamed Mediouni <mohamed@unpredictable.fr>",
"date": "Wed, 25 Feb 2026 12:39:14 +0100",
"is_openbsd": false,
"thread_id": "74977a25-e92e-46d9-b522-50b8fe2d00cc@htecgroup.com.mbox.gz"
} |
lkml_critique | qemu-devel | ---
hw/riscv/boot.c | 19 +++++++++++++++++--
1 file changed, 17 insertions(+), 2 deletions(-)
diff --git a/hw/riscv/boot.c b/hw/riscv/boot.c
index e5490beda0..dc9f8a7327 100644
--- a/hw/riscv/boot.c
+++ b/hw/riscv/boot.c
@@ -31,6 +31,7 @@
#include "system/qtest.h"
#include "system/kvm.h"
#include "system/reset.h"... | null | null | null | [PATCH v2 05/16] hw/riscv: Ensure bootrom has correct endianess | On Wed, Feb 25, 2026 at 11:39:50AM +0100, Thomas Huth wrote:
+1
Additionally, since upstream Linux does not yet support big-endian
RISC-V, I'd suggest focusing on the softmmu big-endian implementation
within the existing riscv32/riscv64 targets first.
Thanks,
Chao | {
"author": "Chao Liu <chao.liu.zevorn@gmail.com>",
"date": "Wed, 25 Feb 2026 20:05:29 +0800",
"is_openbsd": false,
"thread_id": "74977a25-e92e-46d9-b522-50b8fe2d00cc@htecgroup.com.mbox.gz"
} |
lkml_critique | qemu-devel | ---
hw/riscv/boot.c | 19 +++++++++++++++++--
1 file changed, 17 insertions(+), 2 deletions(-)
diff --git a/hw/riscv/boot.c b/hw/riscv/boot.c
index e5490beda0..dc9f8a7327 100644
--- a/hw/riscv/boot.c
+++ b/hw/riscv/boot.c
@@ -31,6 +31,7 @@
#include "system/qtest.h"
#include "system/kvm.h"
#include "system/reset.h"... | null | null | null | [PATCH v2 05/16] hw/riscv: Ensure bootrom has correct endianess | On Wed, Feb 25, 2026 at 10:20:25AM +0000, Djordje Todorovic wrote:
The suibject says its adding "BE" targets, but this is also adding
a 32-bit little endian target.
Does KVM, actually support running riscv32 guests on a riscv64
host ? If so, this change to add 32-bit KVM should likely be
done as its own commit separ... | {
"author": "Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= <berrange@redhat.com>",
"date": "Wed, 25 Feb 2026 12:27:19 +0000",
"is_openbsd": false,
"thread_id": "74977a25-e92e-46d9-b522-50b8fe2d00cc@htecgroup.com.mbox.gz"
} |
lkml_critique | qemu-devel | ---
hw/riscv/boot.c | 19 +++++++++++++++++--
1 file changed, 17 insertions(+), 2 deletions(-)
diff --git a/hw/riscv/boot.c b/hw/riscv/boot.c
index e5490beda0..dc9f8a7327 100644
--- a/hw/riscv/boot.c
+++ b/hw/riscv/boot.c
@@ -31,6 +31,7 @@
#include "system/qtest.h"
#include "system/kvm.h"
#include "system/reset.h"... | null | null | null | [PATCH v2 05/16] hw/riscv: Ensure bootrom has correct endianess | On Wed, Feb 25, 2026 at 11:39:50AM +0100, Thomas Huth wrote:
Also with the ongoing work to make a single QEMU binary that can
support any target, it feels like any problems with handling big
and little endian in a single binary will need to be solved
regardless, so if practical we should align with that direction
from... | {
"author": "Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= <berrange@redhat.com>",
"date": "Wed, 25 Feb 2026 12:30:42 +0000",
"is_openbsd": false,
"thread_id": "74977a25-e92e-46d9-b522-50b8fe2d00cc@htecgroup.com.mbox.gz"
} |
lkml_critique | qemu-devel | ---
hw/riscv/boot.c | 19 +++++++++++++++++--
1 file changed, 17 insertions(+), 2 deletions(-)
diff --git a/hw/riscv/boot.c b/hw/riscv/boot.c
index e5490beda0..dc9f8a7327 100644
--- a/hw/riscv/boot.c
+++ b/hw/riscv/boot.c
@@ -31,6 +31,7 @@
#include "system/qtest.h"
#include "system/kvm.h"
#include "system/reset.h"... | null | null | null | [PATCH v2 05/16] hw/riscv: Ensure bootrom has correct endianess | On Wed, Feb 25, 2026 at 10:30 PM Daniel P. Berrangé <berrange@redhat.com> wrote:
We really don't want a 32-bit KVM target at all
Exactly. We are working towards a single RISC-V binary for all bit
lengths. Big endian would have to start out included in the existing
builds
Alistair | {
"author": "Alistair Francis <alistair23@gmail.com>",
"date": "Fri, 27 Feb 2026 09:26:58 +1000",
"is_openbsd": false,
"thread_id": "74977a25-e92e-46d9-b522-50b8fe2d00cc@htecgroup.com.mbox.gz"
} |
lkml_critique | qemu-devel | ---
hw/riscv/boot.c | 19 +++++++++++++++++--
1 file changed, 17 insertions(+), 2 deletions(-)
diff --git a/hw/riscv/boot.c b/hw/riscv/boot.c
index e5490beda0..dc9f8a7327 100644
--- a/hw/riscv/boot.c
+++ b/hw/riscv/boot.c
@@ -31,6 +31,7 @@
#include "system/qtest.h"
#include "system/kvm.h"
#include "system/reset.h"... | null | null | null | [PATCH v2 05/16] hw/riscv: Ensure bootrom has correct endianess | On Wed, Feb 25, 2026 at 9:39 PM Mohamed Mediouni
<mohamed@unpredictable.fr> wrote:
Agreed. We really need upstream Linux support before user mode
How are you testing this?
Alistair | {
"author": "Alistair Francis <alistair23@gmail.com>",
"date": "Fri, 27 Feb 2026 09:30:00 +1000",
"is_openbsd": false,
"thread_id": "74977a25-e92e-46d9-b522-50b8fe2d00cc@htecgroup.com.mbox.gz"
} |
lkml_critique | qemu-devel | ---
hw/riscv/boot.c | 19 +++++++++++++++++--
1 file changed, 17 insertions(+), 2 deletions(-)
diff --git a/hw/riscv/boot.c b/hw/riscv/boot.c
index e5490beda0..dc9f8a7327 100644
--- a/hw/riscv/boot.c
+++ b/hw/riscv/boot.c
@@ -31,6 +31,7 @@
#include "system/qtest.h"
#include "system/kvm.h"
#include "system/reset.h"... | null | null | null | [PATCH v2 05/16] hw/riscv: Ensure bootrom has correct endianess | On Wed, Feb 25, 2026 at 8:20 PM Djordje Todorovic
<Djordje.Todorovic@htecgroup.com> wrote:
This will need to be done without adding any TARGET_BIG_ENDIAN macros.
We don't want to have custom built binaries
Alistair | {
"author": "Alistair Francis <alistair23@gmail.com>",
"date": "Fri, 27 Feb 2026 09:32:33 +1000",
"is_openbsd": false,
"thread_id": "74977a25-e92e-46d9-b522-50b8fe2d00cc@htecgroup.com.mbox.gz"
} |
lkml_critique | qemu-devel | ---
hw/riscv/boot.c | 19 +++++++++++++++++--
1 file changed, 17 insertions(+), 2 deletions(-)
diff --git a/hw/riscv/boot.c b/hw/riscv/boot.c
index e5490beda0..dc9f8a7327 100644
--- a/hw/riscv/boot.c
+++ b/hw/riscv/boot.c
@@ -31,6 +31,7 @@
#include "system/qtest.h"
#include "system/kvm.h"
#include "system/reset.h"... | null | null | null | [PATCH v2 05/16] hw/riscv: Ensure bootrom has correct endianess | On Wed, Feb 25, 2026 at 8:20 PM Djordje Todorovic
<Djordje.Todorovic@htecgroup.com> wrote:
Why?
Alistair | {
"author": "Alistair Francis <alistair23@gmail.com>",
"date": "Fri, 27 Feb 2026 09:33:19 +1000",
"is_openbsd": false,
"thread_id": "74977a25-e92e-46d9-b522-50b8fe2d00cc@htecgroup.com.mbox.gz"
} |
lkml_critique | qemu-devel | ---
hw/riscv/boot.c | 19 +++++++++++++++++--
1 file changed, 17 insertions(+), 2 deletions(-)
diff --git a/hw/riscv/boot.c b/hw/riscv/boot.c
index e5490beda0..dc9f8a7327 100644
--- a/hw/riscv/boot.c
+++ b/hw/riscv/boot.c
@@ -31,6 +31,7 @@
#include "system/qtest.h"
#include "system/kvm.h"
#include "system/reset.h"... | null | null | null | [PATCH v2 05/16] hw/riscv: Ensure bootrom has correct endianess | On Fri, Feb 27, 2026 at 09:30:00AM +1000, Alistair Francis wrote:
On that front, Ben posted patches for it and Linus was really really not
enthused when he became aware of it:
https://lore.kernel.org/linux-riscv/066d70c7-b0a7-45e5-9337-17901bc95664@codethink.co.uk
Even without Linus' take, I feel like there's absolute... | {
"author": "Conor Dooley <conor@kernel.org>",
"date": "Thu, 26 Feb 2026 23:47:23 +0000",
"is_openbsd": false,
"thread_id": "74977a25-e92e-46d9-b522-50b8fe2d00cc@htecgroup.com.mbox.gz"
} |
lkml_critique | qemu-devel | ---
hw/riscv/boot.c | 19 +++++++++++++++++--
1 file changed, 17 insertions(+), 2 deletions(-)
diff --git a/hw/riscv/boot.c b/hw/riscv/boot.c
index e5490beda0..dc9f8a7327 100644
--- a/hw/riscv/boot.c
+++ b/hw/riscv/boot.c
@@ -31,6 +31,7 @@
#include "system/qtest.h"
#include "system/kvm.h"
#include "system/reset.h"... | null | null | null | [PATCH v2 05/16] hw/riscv: Ensure bootrom has correct endianess | On Fri, Feb 27, 2026 at 9:47 AM Conor Dooley <conor@kernel.org> wrote:
Yeah... I saw that.
A few thoughts, just because Linus doesn't like it doesn't mean QEMU
can't support it. But I am hesitant to support BE considering the lack
of ecosystem support everywhere else.
There are a bunch of changes in this series that... | {
"author": "Alistair Francis <alistair23@gmail.com>",
"date": "Fri, 27 Feb 2026 10:56:45 +1000",
"is_openbsd": false,
"thread_id": "74977a25-e92e-46d9-b522-50b8fe2d00cc@htecgroup.com.mbox.gz"
} |
lkml_critique | qemu-devel | ---
hw/riscv/boot.c | 19 +++++++++++++++++--
1 file changed, 17 insertions(+), 2 deletions(-)
diff --git a/hw/riscv/boot.c b/hw/riscv/boot.c
index e5490beda0..dc9f8a7327 100644
--- a/hw/riscv/boot.c
+++ b/hw/riscv/boot.c
@@ -31,6 +31,7 @@
#include "system/qtest.h"
#include "system/kvm.h"
#include "system/reset.h"... | null | null | null | [PATCH v2 05/16] hw/riscv: Ensure bootrom has correct endianess | On 27/02/2026 01.56, Alistair Francis wrote:
FWIW, have a look at the changes that Philippe did in target/microblaze/ in
the past two years, he merged the both endianness flavours there so it can
now be handled in one binary! If you do something similar with riscv, it
hopefully should not be too intrusive.
Thoma... | {
"author": "Thomas Huth <thuth@redhat.com>",
"date": "Fri, 27 Feb 2026 10:27:45 +0100",
"is_openbsd": false,
"thread_id": "74977a25-e92e-46d9-b522-50b8fe2d00cc@htecgroup.com.mbox.gz"
} |
lkml_critique | qemu-devel | ---
hw/riscv/boot.c | 19 +++++++++++++++++--
1 file changed, 17 insertions(+), 2 deletions(-)
diff --git a/hw/riscv/boot.c b/hw/riscv/boot.c
index e5490beda0..dc9f8a7327 100644
--- a/hw/riscv/boot.c
+++ b/hw/riscv/boot.c
@@ -31,6 +31,7 @@
#include "system/qtest.h"
#include "system/kvm.h"
#include "system/reset.h"... | null | null | null | [PATCH v2 05/16] hw/riscv: Ensure bootrom has correct endianess | On 2/27/26 10:27, Thomas Huth wrote:
Hi Thomas,
Yes, sure, thanks for the advice, I will try to follow that part for
riscv as well!
Thanks a lot!
Djordje | {
"author": "Djordje Todorovic <Djordje.Todorovic@htecgroup.com>",
"date": "Fri, 27 Feb 2026 12:28:32 +0000",
"is_openbsd": false,
"thread_id": "74977a25-e92e-46d9-b522-50b8fe2d00cc@htecgroup.com.mbox.gz"
} |
lkml_critique | qemu-devel | ---
hw/riscv/boot.c | 19 +++++++++++++++++--
1 file changed, 17 insertions(+), 2 deletions(-)
diff --git a/hw/riscv/boot.c b/hw/riscv/boot.c
index e5490beda0..dc9f8a7327 100644
--- a/hw/riscv/boot.c
+++ b/hw/riscv/boot.c
@@ -31,6 +31,7 @@
#include "system/qtest.h"
#include "system/kvm.h"
#include "system/reset.h"... | null | null | null | [PATCH v2 05/16] hw/riscv: Ensure bootrom has correct endianess | On 2/27/26 00:30, Alistair Francis wrote:
Hi Alistair,
Thanks for your comments!
Even though the SW ecosystem is not complete/mature, there is
pretty decent support in GNU toolchain for riscv big-endian already.
GNU GCC, binutils, etc. are pretty okay. I am now working on the
upstreaming process of ... | {
"author": "Djordje Todorovic <Djordje.Todorovic@htecgroup.com>",
"date": "Fri, 27 Feb 2026 12:40:20 +0000",
"is_openbsd": false,
"thread_id": "74977a25-e92e-46d9-b522-50b8fe2d00cc@htecgroup.com.mbox.gz"
} |
lkml_critique | qemu-devel | ---
hw/riscv/boot.c | 19 +++++++++++++++++--
1 file changed, 17 insertions(+), 2 deletions(-)
diff --git a/hw/riscv/boot.c b/hw/riscv/boot.c
index e5490beda0..dc9f8a7327 100644
--- a/hw/riscv/boot.c
+++ b/hw/riscv/boot.c
@@ -31,6 +31,7 @@
#include "system/qtest.h"
#include "system/kvm.h"
#include "system/reset.h"... | null | null | null | [PATCH v2 05/16] hw/riscv: Ensure bootrom has correct endianess | On 2/27/26 01:56, Alistair Francis wrote:
Please be aware that MIPS will ship hardware based on riscv BE
soon: https://mips.com/products/hardware/i8500/
Thanks,
Djordje | {
"author": "Djordje Todorovic <Djordje.Todorovic@htecgroup.com>",
"date": "Fri, 27 Feb 2026 12:42:21 +0000",
"is_openbsd": false,
"thread_id": "74977a25-e92e-46d9-b522-50b8fe2d00cc@htecgroup.com.mbox.gz"
} |
lkml_critique | qemu-devel | ---
hw/riscv/boot.c | 19 +++++++++++++++++--
1 file changed, 17 insertions(+), 2 deletions(-)
diff --git a/hw/riscv/boot.c b/hw/riscv/boot.c
index e5490beda0..dc9f8a7327 100644
--- a/hw/riscv/boot.c
+++ b/hw/riscv/boot.c
@@ -31,6 +31,7 @@
#include "system/qtest.h"
#include "system/kvm.h"
#include "system/reset.h"... | null | null | null | [PATCH v2 05/16] hw/riscv: Ensure bootrom has correct endianess | On Fri, Feb 27, 2026 at 12:42:21PM +0000, Djordje Todorovic wrote:
Not the meaning of "hardware" I was using, as this appears to be a core
complex IP rather than physical hardware? Do you know of any devices,
outside of a MIPS test chip or w/e, that are going to use this IP?
On the linux support front, the devils adv... | {
"author": "Conor Dooley <conor@kernel.org>",
"date": "Fri, 27 Feb 2026 12:56:26 +0000",
"is_openbsd": false,
"thread_id": "74977a25-e92e-46d9-b522-50b8fe2d00cc@htecgroup.com.mbox.gz"
} |
lkml_critique | qemu-devel | ---
hw/riscv/boot.c | 19 +++++++++++++++++--
1 file changed, 17 insertions(+), 2 deletions(-)
diff --git a/hw/riscv/boot.c b/hw/riscv/boot.c
index e5490beda0..dc9f8a7327 100644
--- a/hw/riscv/boot.c
+++ b/hw/riscv/boot.c
@@ -31,6 +31,7 @@
#include "system/qtest.h"
#include "system/kvm.h"
#include "system/reset.h"... | null | null | null | [PATCH v2 05/16] hw/riscv: Ensure bootrom has correct endianess | On 2/27/26 13:56, Conor Dooley wrote:
Yes, you are right, the i8500 is an IP. And I can share for now that
QEMU and FPGA
board with the i8500 bitfile are the targets for testing of RISC-V BE
software.
Best regards,
Djordje | {
"author": "Djordje Todorovic <Djordje.Todorovic@htecgroup.com>",
"date": "Fri, 27 Feb 2026 14:24:38 +0000",
"is_openbsd": false,
"thread_id": "74977a25-e92e-46d9-b522-50b8fe2d00cc@htecgroup.com.mbox.gz"
} |
lkml_critique | qemu-devel | We only receive ram into the colo cache here and don't touch anything
else, so the BQL is not needed here.
Move cpu_synchronize_all_states() downwards, before we apply the received
checkpoint. It turns out that qemu_system_reset() already calls it
for us.
Reviewed-by: Peter Xu <peterx@redhat.com>
Signed-off-by: Lukas... | null | null | null | [PATCH v10 12/19] colo: Do not hold the BQL while receiving ram state. | I am ready to maintain it.
Reviewed-by: Peter Xu <peterx@redhat.com>
Reviewed-by: Zhang Chen <zhangckid@gmail.com>
Signed-off-by: Lukas Straub <lukasstraub2@web.de>
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index e0c481e2125d81298a52caf7f7b51c3e4f026d85..2458241e3cd... | {
"author": "Lukas Straub <lukasstraub2@web.de>",
"date": "Fri, 20 Feb 2026 20:51:23 +0100",
"is_openbsd": false,
"thread_id": "20260227124903.241af498@penguin.mbox.gz"
} |
lkml_critique | qemu-devel | We only receive ram into the colo cache here and don't touch anything
else, so the BQL is not needed here.
Move cpu_synchronize_all_states() downwards, before we apply the received
checkpoint. It turns out that qemu_system_reset() already calls it
for us.
Reviewed-by: Peter Xu <peterx@redhat.com>
Signed-off-by: Lukas... | null | null | null | [PATCH v10 12/19] colo: Do not hold the BQL while receiving ram state. | Since
121ccedc2b migration: block incoming colo when capability is disabled
x-colo capability needs to be always enabled on the incoming side.
So migration_incoming_colo_enabled() and migrate_colo() are equivalent
with migrate_colo() being easier to reason about since it is always true
during the whole migration.
Use... | {
"author": "Lukas Straub <lukasstraub2@web.de>",
"date": "Fri, 20 Feb 2026 20:51:25 +0100",
"is_openbsd": false,
"thread_id": "20260227124903.241af498@penguin.mbox.gz"
} |
lkml_critique | qemu-devel | We only receive ram into the colo cache here and don't touch anything
else, so the BQL is not needed here.
Move cpu_synchronize_all_states() downwards, before we apply the received
checkpoint. It turns out that qemu_system_reset() already calls it
for us.
Reviewed-by: Peter Xu <peterx@redhat.com>
Signed-off-by: Lukas... | null | null | null | [PATCH v10 12/19] colo: Do not hold the BQL while receiving ram state. | We only enter colo state after the precopy migration is finished
so this if is always taken.
Reviewed-by: Fabiano Rosas <farosas@suse.de>
Reviewed-by: Peter Xu <peterx@redhat.com>
Signed-off-by: Lukas Straub <lukasstraub2@web.de>
---
migration/ram.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
di... | {
"author": "Lukas Straub <lukasstraub2@web.de>",
"date": "Fri, 20 Feb 2026 20:51:28 +0100",
"is_openbsd": false,
"thread_id": "20260227124903.241af498@penguin.mbox.gz"
} |
lkml_critique | qemu-devel | We only receive ram into the colo cache here and don't touch anything
else, so the BQL is not needed here.
Move cpu_synchronize_all_states() downwards, before we apply the received
checkpoint. It turns out that qemu_system_reset() already calls it
for us.
Reviewed-by: Peter Xu <peterx@redhat.com>
Signed-off-by: Lukas... | null | null | null | [PATCH v10 12/19] colo: Do not hold the BQL while receiving ram state. | His last email to the mailing list is from December 2021:
https://lore.kernel.org/qemu-devel/20211214075424.6920-1-zhanghailiang@xfusion.com/
Reviewed-by: Peter Xu <peterx@redhat.com>
Reviewed-by: Zhang Chen <zhangckid@gmail.com>
Signed-off-by: Lukas Straub <lukasstraub2@web.de>
---
MAINTAINERS | 1 -
1 file changed,... | {
"author": "Lukas Straub <lukasstraub2@web.de>",
"date": "Fri, 20 Feb 2026 20:51:24 +0100",
"is_openbsd": false,
"thread_id": "20260227124903.241af498@penguin.mbox.gz"
} |
lkml_critique | qemu-devel | We only receive ram into the colo cache here and don't touch anything
else, so the BQL is not needed here.
Move cpu_synchronize_all_states() downwards, before we apply the received
checkpoint. It turns out that qemu_system_reset() already calls it
for us.
Reviewed-by: Peter Xu <peterx@redhat.com>
Signed-off-by: Lukas... | null | null | null | [PATCH v10 12/19] colo: Do not hold the BQL while receiving ram state. | I have so far contributed 61 commits to the colo project, waranting
the addition of my copyright to this file.
Reviewed-by: Zhang Chen <zhangckid@gmail.com>
Reviewed-by: Fabiano Rosas <farosas@suse.de>
Signed-off-by: Lukas Straub <lukasstraub2@web.de>
---
docs/system/qemu-colo.rst | 1 +
1 file changed, 1 insertion(+... | {
"author": "Lukas Straub <lukasstraub2@web.de>",
"date": "Fri, 20 Feb 2026 20:51:38 +0100",
"is_openbsd": false,
"thread_id": "20260227124903.241af498@penguin.mbox.gz"
} |
lkml_critique | qemu-devel | We only receive ram into the colo cache here and don't touch anything
else, so the BQL is not needed here.
Move cpu_synchronize_all_states() downwards, before we apply the received
checkpoint. It turns out that qemu_system_reset() already calls it
for us.
Reviewed-by: Peter Xu <peterx@redhat.com>
Signed-off-by: Lukas... | null | null | null | [PATCH v10 12/19] colo: Do not hold the BQL while receiving ram state. | qemu_savevm_state_complete_precopy() requires that BQL is held.
This fixes a crash when running with TCG accel.
Reviewed-by: Peter Xu <peterx@redhat.com>
Signed-off-by: Lukas Straub <lukasstraub2@web.de>
---
migration/colo.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/migration/colo.c b/m... | {
"author": "Lukas Straub <lukasstraub2@web.de>",
"date": "Fri, 20 Feb 2026 20:51:33 +0100",
"is_openbsd": false,
"thread_id": "20260227124903.241af498@penguin.mbox.gz"
} |
lkml_critique | qemu-devel | We only receive ram into the colo cache here and don't touch anything
else, so the BQL is not needed here.
Move cpu_synchronize_all_states() downwards, before we apply the received
checkpoint. It turns out that qemu_system_reset() already calls it
for us.
Reviewed-by: Peter Xu <peterx@redhat.com>
Signed-off-by: Lukas... | null | null | null | [PATCH v10 12/19] colo: Do not hold the BQL while receiving ram state. | Like in the normal ram_load() path, put the received pages into the
colo cache and mark the pages in the bitmap so that they will be
flushed to the guest later.
Multifd with COLO is useful to reduce the VM pause time during checkpointing
for latency sensitive workloads. In such workloads the worst-case latency
is espe... | {
"author": "Lukas Straub <lukasstraub2@web.de>",
"date": "Fri, 20 Feb 2026 20:51:30 +0100",
"is_openbsd": false,
"thread_id": "20260227124903.241af498@penguin.mbox.gz"
} |
lkml_critique | qemu-devel | We only receive ram into the colo cache here and don't touch anything
else, so the BQL is not needed here.
Move cpu_synchronize_all_states() downwards, before we apply the received
checkpoint. It turns out that qemu_system_reset() already calls it
for us.
Reviewed-by: Peter Xu <peterx@redhat.com>
Signed-off-by: Lukas... | null | null | null | [PATCH v10 12/19] colo: Do not hold the BQL while receiving ram state. | qemu_file_get_return_path() can not fail (See also commit 3f9d6e77b)
so always open the return path socket on the source. This allows
us to reuse the return path in other parts like colo. Also take
the proper locks in colo while we're at it.
This fixes a crash due to a race between migrate_cancel() and
the colo thread... | {
"author": "Lukas Straub <lukasstraub2@web.de>",
"date": "Fri, 20 Feb 2026 20:51:41 +0100",
"is_openbsd": false,
"thread_id": "20260227124903.241af498@penguin.mbox.gz"
} |
lkml_critique | qemu-devel | We only receive ram into the colo cache here and don't touch anything
else, so the BQL is not needed here.
Move cpu_synchronize_all_states() downwards, before we apply the received
checkpoint. It turns out that qemu_system_reset() already calls it
for us.
Reviewed-by: Peter Xu <peterx@redhat.com>
Signed-off-by: Lukas... | null | null | null | [PATCH v10 12/19] colo: Do not hold the BQL while receiving ram state. | When a send thread encounters an error (as is the case with yank),
it sets multifd_send_state->exiting and the other threads exit too.
This races with multifd_send_sync_main() which now hangs at
qemu_sem_wait(&p->sem_sync) in multifd_send_sync_main() line 647
as it waits for threads that have exited.
Fix this by kicki... | {
"author": "Lukas Straub <lukasstraub2@web.de>",
"date": "Fri, 20 Feb 2026 20:51:40 +0100",
"is_openbsd": false,
"thread_id": "20260227124903.241af498@penguin.mbox.gz"
} |
lkml_critique | qemu-devel | We only receive ram into the colo cache here and don't touch anything
else, so the BQL is not needed here.
Move cpu_synchronize_all_states() downwards, before we apply the received
checkpoint. It turns out that qemu_system_reset() already calls it
for us.
Reviewed-by: Peter Xu <peterx@redhat.com>
Signed-off-by: Lukas... | null | null | null | [PATCH v10 12/19] colo: Do not hold the BQL while receiving ram state. | Reviewed-by: Fabiano Rosas <farosas@suse.de>
Reviewed-by: Zhang Chen <zhangckid@gmail.com>
Signed-off-by: Lukas Straub <lukasstraub2@web.de>
---
docs/system/qemu-colo.rst | 35 ++++++++++++++++++-----------------
1 file changed, 18 insertions(+), 17 deletions(-)
diff --git a/docs/system/qemu-colo.rst b/docs/system/qe... | {
"author": "Lukas Straub <lukasstraub2@web.de>",
"date": "Fri, 20 Feb 2026 20:51:37 +0100",
"is_openbsd": false,
"thread_id": "20260227124903.241af498@penguin.mbox.gz"
} |
lkml_critique | qemu-devel | We only receive ram into the colo cache here and don't touch anything
else, so the BQL is not needed here.
Move cpu_synchronize_all_states() downwards, before we apply the received
checkpoint. It turns out that qemu_system_reset() already calls it
for us.
Reviewed-by: Peter Xu <peterx@redhat.com>
Signed-off-by: Lukas... | null | null | null | [PATCH v10 12/19] colo: Do not hold the BQL while receiving ram state. | Hello everyone,
This has some cleanups for and adds multifd support and migration unit tests
for COLO migration.
Regards,
Lukas
Signed-off-by: Lukas Straub <lukasstraub2@web.de>
---
Changes in v10:
- multifd: always kick the main thread
- always open the return path socket on source
- Link to v9: https://lore.kernel.... | {
"author": "Lukas Straub <lukasstraub2@web.de>",
"date": "Fri, 20 Feb 2026 20:51:22 +0100",
"is_openbsd": false,
"thread_id": "20260227124903.241af498@penguin.mbox.gz"
} |
lkml_critique | qemu-devel | We only receive ram into the colo cache here and don't touch anything
else, so the BQL is not needed here.
Move cpu_synchronize_all_states() downwards, before we apply the received
checkpoint. It turns out that qemu_system_reset() already calls it
for us.
Reviewed-by: Peter Xu <peterx@redhat.com>
Signed-off-by: Lukas... | null | null | null | [PATCH v10 12/19] colo: Do not hold the BQL while receiving ram state. | On the primary side we don't actually need the replication
block driver, since it only passes trough all IO.
So simplify the setup and also use 'blockdev-add' instead of
'human-monitor-command'.
This is how my clients use colo in production.
Signed-off-by: Lukas Straub <lukasstraub2@web.de>
---
docs/system/qemu-colo... | {
"author": "Lukas Straub <lukasstraub2@web.de>",
"date": "Fri, 20 Feb 2026 20:51:39 +0100",
"is_openbsd": false,
"thread_id": "20260227124903.241af498@penguin.mbox.gz"
} |
lkml_critique | qemu-devel | We only receive ram into the colo cache here and don't touch anything
else, so the BQL is not needed here.
Move cpu_synchronize_all_states() downwards, before we apply the received
checkpoint. It turns out that qemu_system_reset() already calls it
for us.
Reviewed-by: Peter Xu <peterx@redhat.com>
Signed-off-by: Lukas... | null | null | null | [PATCH v10 12/19] colo: Do not hold the BQL while receiving ram state. | Reviewed-by: Fabiano Rosas <farosas@suse.de>
Reviewed-by: Zhang Chen <zhangckid@gmail.com>
Signed-off-by: Lukas Straub <lukasstraub2@web.de>
---
MAINTAINERS | 2 +-
docs/COLO-FT.txt | 334 ------------------------------------------
docs/system/index.rst | 1 +
docs/system/qemu-colo.rst |... | {
"author": "Lukas Straub <lukasstraub2@web.de>",
"date": "Fri, 20 Feb 2026 20:51:36 +0100",
"is_openbsd": false,
"thread_id": "20260227124903.241af498@penguin.mbox.gz"
} |
lkml_critique | qemu-devel | We only receive ram into the colo cache here and don't touch anything
else, so the BQL is not needed here.
Move cpu_synchronize_all_states() downwards, before we apply the received
checkpoint. It turns out that qemu_system_reset() already calls it
for us.
Reviewed-by: Peter Xu <peterx@redhat.com>
Signed-off-by: Lukas... | null | null | null | [PATCH v10 12/19] colo: Do not hold the BQL while receiving ram state. | With colo we load device vmstate during each checkpoint, on top of
a vm that was already running. Some devices expect a reset before
loading vmstate on such a previously running vm.
This fixes a crash when using COLO with Q35 machine.
The reset adds 10-20ms overhead to the checkpointing proces in my
testing.
Reviewe... | {
"author": "Lukas Straub <lukasstraub2@web.de>",
"date": "Fri, 20 Feb 2026 20:51:32 +0100",
"is_openbsd": false,
"thread_id": "20260227124903.241af498@penguin.mbox.gz"
} |
lkml_critique | qemu-devel | We only receive ram into the colo cache here and don't touch anything
else, so the BQL is not needed here.
Move cpu_synchronize_all_states() downwards, before we apply the received
checkpoint. It turns out that qemu_system_reset() already calls it
for us.
Reviewed-by: Peter Xu <peterx@redhat.com>
Signed-off-by: Lukas... | null | null | null | [PATCH v10 12/19] colo: Do not hold the BQL while receiving ram state. | Add a COLO migration test for COLO migration and failover.
Reviewed-by: Fabiano Rosas <farosas@suse.de>
Tested-by: Fabiano Rosas <farosas@suse.de>
Reviewed-by: Peter Xu <peterx@redhat.com>
Signed-off-by: Lukas Straub <lukasstraub2@web.de>
---
MAINTAINERS | 1 +
tests/qtest/meson.build ... | {
"author": "Lukas Straub <lukasstraub2@web.de>",
"date": "Fri, 20 Feb 2026 20:51:35 +0100",
"is_openbsd": false,
"thread_id": "20260227124903.241af498@penguin.mbox.gz"
} |
lkml_critique | qemu-devel | We only receive ram into the colo cache here and don't touch anything
else, so the BQL is not needed here.
Move cpu_synchronize_all_states() downwards, before we apply the received
checkpoint. It turns out that qemu_system_reset() already calls it
for us.
Reviewed-by: Peter Xu <peterx@redhat.com>
Signed-off-by: Lukas... | null | null | null | [PATCH v10 12/19] colo: Do not hold the BQL while receiving ram state. | This is in preparation for the next patch.
Reviewed-by: Peter Xu <peterx@redhat.com>
Reviewed-by: Fabiano Rosas <farosas@suse.de>
Signed-off-by: Lukas Straub <lukasstraub2@web.de>
---
migration/multifd.c | 11 ++++++++++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/migration/multifd.c b/migration/mu... | {
"author": "Lukas Straub <lukasstraub2@web.de>",
"date": "Fri, 20 Feb 2026 20:51:29 +0100",
"is_openbsd": false,
"thread_id": "20260227124903.241af498@penguin.mbox.gz"
} |
lkml_critique | qemu-devel | We only receive ram into the colo cache here and don't touch anything
else, so the BQL is not needed here.
Move cpu_synchronize_all_states() downwards, before we apply the received
checkpoint. It turns out that qemu_system_reset() already calls it
for us.
Reviewed-by: Peter Xu <peterx@redhat.com>
Signed-off-by: Lukas... | null | null | null | [PATCH v10 12/19] colo: Do not hold the BQL while receiving ram state. | No need for it anymore now that x-colo capability is required
on incoming side. There is also no need to send it for backwards
compatibility since we only support COLO with the same version on
both sides.
We mark the command code as deprecated and now error out if such
a unhandled command is encountered in loadvm_proc... | {
"author": "Lukas Straub <lukasstraub2@web.de>",
"date": "Fri, 20 Feb 2026 20:51:27 +0100",
"is_openbsd": false,
"thread_id": "20260227124903.241af498@penguin.mbox.gz"
} |
lkml_critique | qemu-devel | We only receive ram into the colo cache here and don't touch anything
else, so the BQL is not needed here.
Move cpu_synchronize_all_states() downwards, before we apply the received
checkpoint. It turns out that qemu_system_reset() already calls it
for us.
Reviewed-by: Peter Xu <peterx@redhat.com>
Signed-off-by: Lukas... | null | null | null | [PATCH v10 12/19] colo: Do not hold the BQL while receiving ram state. | The multifd threads still may access the colo cache, so release it
only after they terminate.
Reviewed-by: Fabiano Rosas <farosas@suse.de>
Reviewed-by: Peter Xu <peterx@redhat.com>
Signed-off-by: Lukas Straub <lukasstraub2@web.de>
---
migration/colo.c | 3 ---
migration/migration.c | 3 +++
2 files changed, 3 in... | {
"author": "Lukas Straub <lukasstraub2@web.de>",
"date": "Fri, 20 Feb 2026 20:51:31 +0100",
"is_openbsd": false,
"thread_id": "20260227124903.241af498@penguin.mbox.gz"
} |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.