repo
stringclasses
15 values
fix_commit
stringlengths
40
40
buggy_commit
stringlengths
40
40
message
stringlengths
3
64.3k
files
listlengths
1
300
timestamp
timestamp[s]date
2013-03-13 20:45:00
2026-04-11 07:48:46
vercel/next.js
97ba91097dfbe10b75e105a0c605a756b8015e3a
4ba64e2e0b045f39de4ce9c07a5d14b1c896c478
Support passing a relative string to pushState/replaceState (#58438) Follow-up to #58335. Fixes https://github.com/vercel/next.js/discussions/48110#discussioncomment-7565394 As reported in the discussion passing a origin-relative string didn't work as `new URL` will throw an error. This ensures the `origin` p...
[ { "path": "packages/next/src/client/components/app-router.tsx", "patch": "@@ -232,6 +232,7 @@ const originalReplaceState =\n : null\n \n function copyNextJsInternalHistoryState(data: any) {\n+ if (data == null) data = {}\n const currentState = window.history.state\n const __NA = currentState?.__NA\...
2023-11-16T21:11:14
rust-lang/rust
0e05f58e6284da68f68412fc6dee00d32517f17b
e52666380f6f03fb1211138171e0ef626ceb468d
Fix guess renamed macro braces
[ { "path": "src/tools/rust-analyzer/crates/ide-completion/src/render/macro_.rs", "patch": "@@ -46,12 +46,17 @@ fn render(\n ctx.source_range()\n };\n \n- let (name, escaped_name) =\n- (name.as_str(), name.display(ctx.db(), completion.edition).to_smolstr());\n+ let orig_name = macro_....
2025-08-12T03:40:37
electron/electron
257f6b142f6e726dae1f767727e7255cbc2162b0
f5a75c4e87a73a802c41e9fb3608e10772dbe600
Add spec for remote setter not surfacing error
[ { "path": "spec/api-ipc-spec.js", "patch": "@@ -187,6 +187,18 @@ describe('ipc module', function () {\n property.property = 1127\n })\n \n+ it('rethrows errors getting/setting properties', function () {\n+ const foo = remote.require(path.join(fixtures, 'module', 'error-properties.js'))\n+\...
2017-04-03T16:09:37
golang/go
b71ca76065823af0908ff469f603c0b38a7c4177
efa357ce3c1a8ef0ce94347fef533c87673a598a
debug/buildinfo: remove redundant type conversion Change-Id: Ia8ffc9a17646ad2c74f633610aaf34fef006c023 GitHub-Last-Rev: 6ab0d107393c9bdfeaed5c539efb452942c00394 GitHub-Pull-Request: golang/go#54856 Reviewed-on: https://go-review.googlesource.com/c/go/+/428235 Auto-Submit: Ian Lance Taylor <iant@google.com> Reviewed-by...
[ { "path": "src/debug/buildinfo/buildinfo.go", "patch": "@@ -394,13 +394,13 @@ type xcoffExe struct {\n \n func (x *xcoffExe) ReadData(addr, size uint64) ([]byte, error) {\n \tfor _, sect := range x.f.Sections {\n-\t\tif uint64(sect.VirtualAddress) <= addr && addr <= uint64(sect.VirtualAddress+sect.Size-1) {...
2022-09-03T20:08:12
vercel/next.js
637ead09e238d256b5eea9a934a46499ac8f9ee1
ce973905a9731cb83b5877e7eaec302d8be80215
Update 04-metadata.mdx (#58535) Update wrong link
[ { "path": "docs/02-app/01-building-your-application/06-optimizing/04-metadata.mdx", "patch": "@@ -121,7 +121,7 @@ These special files are available for metadata:\n \n You can use these for static metadata, or you can programmatically generate these files with code.\n \n-For implementation and examples, see ...
2023-11-16T17:56:02
nodejs/node
7baaab014b5427a326689aebc7ce9846882c5af5
56bdec44a8ab447edafbd7a31116650cd0cf138b
deps: V8: cherry-pick 3f8dc4b2e5ba Original commit message: [intl] Remove soon-to-be removed getAllFieldPositions Needed to land ICU67.1 soon. Bug: v8:10393 Change-Id: I3c7737ca600d6ccfdc46ffaddfb318ce60bc7618 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2136489 Reviewed-b...
[ { "path": "common.gypi", "patch": "@@ -36,7 +36,7 @@\n \n # Reset this number to 0 on major V8 upgrades.\n # Increment by one for each non-official patch applied to deps/v8.\n- 'v8_embedder_string': '-node.10',\n+ 'v8_embedder_string': '-node.11',\n \n ##### V8 defaults for Node.js #####\n...
2020-05-05T07:26:33
electron/electron
d1212d4a43a15dc1d501365cda513e7dcee51353
50c99e4507d3a9f06c66d52754c977d24eea347c
Fix JS style
[ { "path": "spec/modules-spec.js", "patch": "@@ -136,7 +136,7 @@ describe('require', () => {\n describe('when loaded URL is not file: protocol', () => {\n it('searches for module under app directory', async () => {\n const w = new BrowserWindow({\n- show: false,\n+ show: false\n ...
2017-04-03T11:23:36
golang/go
60ef4b2c1e931069d81f053358a4023e09359e7f
e3885c4ee5f35a7012fa11d8fc84a27c3c1177a0
runtime: in traceback, only jump stack if M doesn't change CL 424257 modified gentraceback to switch gp when jumping from a system stack to a user stack to simplify reasoning through the rest of the function. This has the unintended side-effect of also switching all references to gp.m. The vast majority of the time, g...
[ { "path": "src/runtime/traceback.go", "patch": "@@ -159,7 +159,10 @@ func gentraceback(pc0, sp0, lr0 uintptr, gp *g, skip int, pcbuf *uintptr, max in\n \t\tif frame.fp == 0 {\n \t\t\t// Jump over system stack transitions. If we're on g0 and there's a user\n \t\t\t// goroutine, try to jump. Otherwise this is...
2022-09-06T15:42:12
rust-lang/rust
3aa0ac0a8af32f2c5da106c5e89bd9712d5a9655
fa733909edadf390cde8c36c303bce42d37f7a3b
Tweak trait modifier errors
[ { "path": "compiler/rustc_parse/messages.ftl", "patch": "@@ -869,10 +869,10 @@ parse_trait_alias_cannot_be_auto = trait aliases cannot be `auto`\n parse_trait_alias_cannot_be_const = trait aliases cannot be `const`\n parse_trait_alias_cannot_be_unsafe = trait aliases cannot be `unsafe`\n \n-parse_trait_impl...
2025-07-30T23:00:53
vercel/next.js
3cd9264abc6d481ef19854dac05c34e28e1c2379
d6d6d56133da9d61f7476889d90d855b76081c27
tweak cache + revalidate fetch warning (#58505) ### What? When using a `Request` object with fetch, we'll log a warning indicating that using the `cache` property in addition to `revalidate` is unsupported. ### Why? `Request` sets some defaults on the request init, such as `cache: "default"`. This makes the warning c...
[ { "path": "packages/next/src/server/lib/patch-fetch.ts", "patch": "@@ -266,9 +266,13 @@ export function patchFetch({\n typeof _cache === 'string' &&\n typeof curRevalidate !== 'undefined'\n ) {\n- Log.warn(\n- `fetch for ${fetchUrl} on ${staticGenerationStore....
2023-11-16T15:57:26
nodejs/node
56bdec44a8ab447edafbd7a31116650cd0cf138b
0d50ba5d482a7d5e3f94df3bbc182813d3fb28e4
deps: V8: cherry-pick e1eac1b16c96 Original commit message: Fix compilation error with devtoolset-8 We are compiling V8 using devtoolset-8 and it is generating a new compilation error related to String Truncation: error: ‘char* strncpy(char*, const char*, size_t)’ output truncated copying between 1 ...
[ { "path": "common.gypi", "patch": "@@ -36,7 +36,7 @@\n \n # Reset this number to 0 on major V8 upgrades.\n # Increment by one for each non-official patch applied to deps/v8.\n- 'v8_embedder_string': '-node.9',\n+ 'v8_embedder_string': '-node.10',\n \n ##### V8 defaults for Node.js #####\n ...
2020-04-21T17:16:53
facebook/react
6406183f7805bd1ee67f626440f8773ee5c284c7
5476f9168beadda74506d37fd779e7e4bca0bc1c
Support `ms` vendor prefix when generating markup
[ { "path": "src/browser/ui/dom/CSSPropertyOperations.js", "patch": "@@ -23,11 +23,11 @@ var CSSProperty = require('CSSProperty');\n \n var dangerousStyleValue = require('dangerousStyleValue');\n var escapeTextForBrowser = require('escapeTextForBrowser');\n-var hyphenate = require('hyphenate');\n+var hyphenat...
2014-03-28T05:46:02
golang/go
a89c3d76ba3c8f75663ebb83ebdbe8432582e9d2
32f68b5ab7b4f2a5a87497816260d9b671f6c74e
debug: use strings.Builder Change-Id: I59db11212758b478248f34c031501a167335348c Reviewed-on: https://go-review.googlesource.com/c/go/+/428257 Auto-Submit: Ian Lance Taylor <iant@google.com> Reviewed-by: Ian Lance Taylor <iant@google.com> Run-TryBot: Ian Lance Taylor <iant@google.com> Reviewed-by: Robert Griesemer <gri...
[ { "path": "src/debug/buildinfo/buildinfo_test.go", "patch": "@@ -80,13 +80,13 @@ func TestReadFile(t *testing.T) {\n \t\tcmd := exec.Command(testenv.GoToolPath(t), \"build\", \"-o=\"+outPath, \"-buildmode=\"+buildmode)\n \t\tcmd.Dir = dir\n \t\tcmd.Env = append(os.Environ(), \"GO111MODULE=on\", \"GOOS=\"+go...
2022-09-04T09:31:08
vercel/next.js
d6d6d56133da9d61f7476889d90d855b76081c27
b0172610479c55180546dff6f5bf92f9021d7b9e
Remove client only dynamic chunks from edge bundle (#56761) ### Issue In the client components world, when you're using `next/dynamic` with `ssr: false` to split chunks in pages of edge runtime, you could get the dynamic imported module still bundled in the server bundle for edge runtime. This could easily hit the b...
[ { "path": "packages/next-swc/crates/core/src/lib.rs", "patch": "@@ -230,7 +230,7 @@ where\n Some(config) if config.truthy() => match config {\n // Always enable the Server Components mode for both\n // server and client layers.\n- re...
2023-11-16T15:10:28
nodejs/node
0d50ba5d482a7d5e3f94df3bbc182813d3fb28e4
54ae041309b0f8934b45b4fd73efcfc1bcb1842b
deps: fix V8 8.3 on SmartOS PR-URL: https://github.com/nodejs/node/pull/32831 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
[ { "path": "common.gypi", "patch": "@@ -36,7 +36,7 @@\n \n # Reset this number to 0 on major V8 upgrades.\n # Increment by one for each non-official patch applied to deps/v8.\n- 'v8_embedder_string': '-node.8',\n+ 'v8_embedder_string': '-node.9',\n \n ##### V8 defaults for Node.js #####\n "...
2020-04-17T15:24:15
facebook/react
65d16883a5719453b1edd512490fc9d84030227e
858fd2e4e2cbab092e0020fa98d9339076d7a009
Fix hasOwnProperty check typo in mixStaticSpecIntoComponent
[ { "path": "src/core/ReactCompositeComponent.js", "patch": "@@ -505,7 +505,7 @@ function mixStaticSpecIntoComponent(ConvenienceConstructor, statics) {\n for (var name in statics) {\n var property = statics[name];\n if (!statics.hasOwnProperty(name)) {\n- return;\n+ continue;\n }\n \n ...
2014-03-27T19:21:12
rust-lang/rust
fa733909edadf390cde8c36c303bce42d37f7a3b
39c5d6d1cac012095771902d4782908ae0df4789
Move trait impl modifier errors to parsing This is a technically a breaking change for what can be parsed in `#[cfg(false)]`.
[ { "path": "compiler/rustc_ast_passes/messages.ftl", "patch": "@@ -175,11 +175,6 @@ ast_passes_generic_default_trailing = generic parameters with a default must be\n ast_passes_incompatible_features = `{$f1}` and `{$f2}` are incompatible, using them at the same time is not allowed\n .help = remove one of...
2025-07-30T21:33:59
golang/go
a60a3dc5bc0336bd6b499bc7e1feb459b1e4a4bc
8a323542190ec3ba8f0ff0ec057e75e25ad1f408
Revert "runtime: convert local var stop,ready at TestDebugCallUnsafePoint to atomic type" This reverts https://go.dev/cl/427135. Reason for revert: broke the test it modified on linux-amd64-noopt. --- FAIL: TestDebugCallUnsafePoint (0.00s) debug_test.go:265: want "call not at safe point", got %!s(<nil>) ...
[ { "path": "src/runtime/debug_test.go", "patch": "@@ -224,16 +224,16 @@ func TestDebugCallGrowStack(t *testing.T) {\n }\n \n //go:nosplit\n-func debugCallUnsafePointWorker(gpp **runtime.G, ready, stop *atomic.Bool) {\n+func debugCallUnsafePointWorker(gpp **runtime.G, ready, stop *uint32) {\n \t// The nosplit...
2022-09-05T08:30:02
vercel/next.js
c26c7713b5078e9e362d9a73e51550a82e6d3c09
24b2ff16abaa973d695247a9c1ac4e229640d4ca
fix: set `x-forwarded-host` based on request (#58500) Co-authored-by: @BRKalow <bryce@clerk.dev> ### What? A number of our customers have been experiencing issues stemming from an `x-forwarded-host` header that doesn't match the `host` header. ### Why? [This PR](https://github.com/vercel/next.js/pull/5781...
[ { "path": "packages/next/src/server/base-server.ts", "patch": "@@ -910,7 +910,7 @@ export default abstract class Server<ServerOptions extends Options = Options> {\n )\n }\n \n- req.headers['x-forwarded-host'] ??= `${this.hostname}:${this.port}`\n+ req.headers['x-forwarded-host'] ??= ...
2023-11-16T11:00:41
nodejs/node
54ae041309b0f8934b45b4fd73efcfc1bcb1842b
e9a6ba0a4c144585f58a78e36692a4f6d0fb82ea
deps: patch V8 to run on Xcode 8 Patch V8 (wasm/wasm-module.cc) to remove const qualifier from type passed to template call of `OwnedVector::Of`. Xcode 8 can't convert 'OwnedVector<unsigned char>' to 'OwnedVector<const unsigned char>' when returning from a function (which is likely a bug on Xcode, considering this wor...
[ { "path": "common.gypi", "patch": "@@ -36,7 +36,7 @@\n \n # Reset this number to 0 on major V8 upgrades.\n # Increment by one for each non-official patch applied to deps/v8.\n- 'v8_embedder_string': '-node.7',\n+ 'v8_embedder_string': '-node.8',\n \n ##### V8 defaults for Node.js #####\n "...
2020-03-10T23:58:15
rust-lang/rust
c8c483df27180b6e8013088de986da8cbd74314d
a5469b8b4a29c4c57d3c5833a2f946537666d898
Account for new `assert!` desugaring in `!condition` suggestion `rustc` is going to change the desugaring of `assert!` to be ```rust match condition { true => {} _ => panic!(), } ``` which will make the edge-case of `condition` being `impl Not<Output = bool>` while not being `bool` itself no longer a straight...
[ { "path": "clippy_lints/src/bool_assert_comparison.rs", "patch": "@@ -130,18 +130,22 @@ impl<'tcx> LateLintPass<'tcx> for BoolAssertComparison {\n \n let mut suggestions = vec![(name_span, non_eq_mac.to_string()), (lit_span, String::new())];\n \n- if bool_value ^ eq_macro {\n-...
2025-08-11T21:36:35
electron/electron
22035e2d6d2b3d1132ea26719d9165e52fc81054
d18b34d55f784d157e1bc013718183b63ab6789c
Fix cpplint: at least two spaces between code and comments.
[ { "path": "brightray/browser/browser_client.cc", "patch": "@@ -23,7 +23,7 @@ namespace {\n \n BrowserClient* g_browser_client;\n \n-} // namespace\n+} // namespace\n \n BrowserClient* BrowserClient::Get() {\n return g_browser_client;", "additions": 1, "deletions": 1, "language": "Unknown" }...
2017-03-31T18:18:20
golang/go
1c50484335ff8c752f872cf730f262b66280b5be
4c1ca42aa295d68b6172b7f49e4fb4fd14d86475
Revert "internal/poll: drop redundant ENOSYS and EXDEV error checks in CopyFileRange()" This reverts https://go.dev/cl/425881. Reason for revert: broke make.bash on linux/amd64 with Linux 5.19.6. [...] Building Go toolchain2 using go_bootstrap and Go toolchain1. go install internal/unsafeheader: copying /tmp/go-b...
[ { "path": "src/internal/poll/copy_file_range_linux.go", "patch": "@@ -41,9 +41,25 @@ func CopyFileRange(dst, src *FD, remain int64) (written int64, handled bool, err\n \t\t}\n \t\tn, err := copyFileRange(dst, src, int(max))\n \t\tswitch err {\n-\t\tcase syscall.EINVAL, syscall.EIO, syscall.EOPNOTSUPP, sysca...
2022-09-05T08:37:48
facebook/react
3cdef1a86ac9c7e11056b91341b300a9ac36fd63
5476f9168beadda74506d37fd779e7e4bca0bc1c
Fix docstring arg order in createDOMComponentClass
[ { "path": "src/browser/ReactDOM.js", "patch": "@@ -35,8 +35,8 @@ var mapObject = require('mapObject');\n * The `style` property functions differently from the DOM API. It accepts an\n * object mapping of style properties to values.\n *\n- * @param {string} tag Tag name (e.g. `div`).\n * @param {boolean}...
2014-03-27T18:27:19
vercel/next.js
24b2ff16abaa973d695247a9c1ac4e229640d4ca
8d4f4fcd389866482250f08e207385440a4503ba
remove optimistic navigation behavior when prefetch is false (#58413) ### What? When navigating between pages (via `prefetch: false`) within a dynamic segment, the shared layout is re-rendered. This can cause unexpected behavior like layout data changing when navigating between child segments. ### Why? When pr...
[ { "path": "packages/next/src/client/components/app-router.tsx", "patch": "@@ -204,15 +204,14 @@ function useChangeByServerResponse(\n \n function useNavigate(dispatch: React.Dispatch<ReducerActions>): RouterNavigate {\n return useCallback(\n- (href, navigateType, forceOptimisticNavigation, shouldScroll...
2023-11-16T10:58:17
nodejs/node
32be677f49b6415ce08842fe78288637f300041d
9dfaf49b84ff13f83dbe9755ac2eb934719792df
deps: make v8.h compatible with VS2015 There is a bug in the most recent version of VS2015 that affects v8.h and therefore prevents compilation of addons. Refs: https://stackoverflow.com/q/38378693 PR-URL: https://github.com/nodejs/node/pull/32831 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël...
[ { "path": "common.gypi", "patch": "@@ -36,7 +36,7 @@\n \n # Reset this number to 0 on major V8 upgrades.\n # Increment by one for each non-official patch applied to deps/v8.\n- 'v8_embedder_string': '-node.5',\n+ 'v8_embedder_string': '-node.6',\n \n ##### V8 defaults for Node.js #####\n "...
2019-11-01T07:39:18
golang/go
40ced0c00b04a5b9832bb5b47c995c82854f26ae
af7f417665fb1612eb9865c7ab4992bf095148e2
internal/poll: drop redundant ENOSYS and EXDEV error checks in CopyFileRange() The initial CL 229101 didn't limit the kernel version, but relies on error checking to ensure the kernel version >= 4.5 or >= 5.3 when it's calling copy_file_range(2) to copy data across file systems. Since we have now put the kernel versi...
[ { "path": "src/internal/poll/copy_file_range_linux.go", "patch": "@@ -41,25 +41,9 @@ func CopyFileRange(dst, src *FD, remain int64) (written int64, handled bool, err\n \t\t}\n \t\tn, err := copyFileRange(dst, src, int(max))\n \t\tswitch err {\n-\t\tcase syscall.ENOSYS:\n-\t\t\t// copy_file_range(2) was intr...
2022-08-27T02:44:25
facebook/react
5476f9168beadda74506d37fd779e7e4bca0bc1c
09333a3819a8e1e6606536f9b572d9042a9426cb
Repair spacebar textInput Browsers that natively support the `textInput` event appear to have a bug: when preventing default behavior for a `textInput` event occurring for a spacebar keypress, the character is prevented from being inserted **but the browser scrolls down**. Minimal repro example: http://jsfiddle.net/s...
[ { "path": "src/browser/eventPlugins/BeforeInputEventPlugin.js", "patch": "@@ -26,12 +26,15 @@ var SyntheticInputEvent = require('SyntheticInputEvent');\n \n var keyOf = require('keyOf');\n \n-var useBeforeInputEvent = (\n+var canUseTextInputEvent = (\n ExecutionEnvironment.canUseDOM &&\n 'TextEvent' in ...
2014-03-25T19:32:42
rust-lang/rust
86853b375809caf75ce321e1297ff509e4993fcf
577166503aee7290e09374da21f4045c455acfd5
Account for new `assert!` desugaring in `!condition` suggestion `rustc` is going to change the desugaring of `assert!` to be ```rust match condition { true => {} _ => panic!(), } ``` which will make the edge-case of `condition` being `impl Not<Output = bool>` while not being `bool` itself no longer a straight...
[ { "path": "src/tools/clippy/clippy_lints/src/bool_assert_comparison.rs", "patch": "@@ -130,18 +130,22 @@ impl<'tcx> LateLintPass<'tcx> for BoolAssertComparison {\n \n let mut suggestions = vec![(name_span, non_eq_mac.to_string()), (lit_span, String::new())];\n \n- if bool_valu...
2025-08-11T21:36:35
vercel/next.js
8d4f4fcd389866482250f08e207385440a4503ba
02103feb296759d5b873b64ad4fca4e3030ad063
revalidate APIs should make route handlers dynamic (#58466) ### What? Using `revalidateTag` or `revalidatePath` in a route handler will not currently opt the handler into dynamic behavior. This means that if you use these APIs and don't opt into dynamic behavior by some other means, the revalidation call won't do ...
[ { "path": "packages/next/src/server/web/spec-extension/revalidate-tag.ts", "patch": "@@ -2,6 +2,7 @@ import type {\n StaticGenerationAsyncStorage,\n StaticGenerationStore,\n } from '../../../client/components/static-generation-async-storage.external'\n+import { staticGenerationBailout } from '../../../c...
2023-11-16T10:57:55
nodejs/node
55f7ae6386eafa10012e1a7ccf3149becb3b5288
6b5ea2efa23d5e6206ea8db2bba54995c20c6597
deps: V8: patch register-arm64.h Fixes a compilation issue on some platforms PR-URL: https://github.com/nodejs/node/pull/32831 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail....
[ { "path": "common.gypi", "patch": "@@ -36,7 +36,7 @@\n \n # Reset this number to 0 on major V8 upgrades.\n # Increment by one for each non-official patch applied to deps/v8.\n- 'v8_embedder_string': '-node.3',\n+ 'v8_embedder_string': '-node.4',\n \n ##### V8 defaults for Node.js #####\n "...
2019-05-22T15:33:02
electron/electron
f0d447cd681c276acc4ab560650770a270b030c0
96407d9c177feff1b4b9322b852df70ab94b3441
Pass `uploadToServer` to windows crash reporter
[ { "path": "atom/common/crash_reporter/crash_reporter_win.cc", "patch": "@@ -179,7 +179,7 @@ void CrashReporterWin::InitBreakpad(const std::string& product_name,\n google_breakpad::ExceptionHandler::HANDLER_ALL,\n kSmallDumpType,\n pipe_name.c_str(),\n- GetCustomInfo(product_name, vers...
2017-03-29T12:16:27
golang/go
357b9225174fa227b47246e57f61a1bf66c1354c
4e7e7ae1406c70d9cc0809ec11105a55a60a0b70
runtime: convert local var stop,ready at TestDebugCallUnsafePoint to atomic type For #53821 Change-Id: Id972d4ccadc72de69dea46f8be146c9843d1d095 Reviewed-on: https://go-review.googlesource.com/c/go/+/427135 Reviewed-by: Michael Knyszek <mknyszek@google.com> Run-TryBot: xie cui <523516579@qq.com> Reviewed-by: Heschi K...
[ { "path": "src/runtime/debug_test.go", "patch": "@@ -224,16 +224,16 @@ func TestDebugCallGrowStack(t *testing.T) {\n }\n \n //go:nosplit\n-func debugCallUnsafePointWorker(gpp **runtime.G, ready, stop *uint32) {\n+func debugCallUnsafePointWorker(gpp **runtime.G, ready, stop *atomic.Bool) {\n \t// The nosplit...
2022-09-02T02:18:51
facebook/react
09333a3819a8e1e6606536f9b572d9042a9426cb
edc0fa4c3f542c1bc806004c8b1481d4e27a30d2
Remove last uses of {' '} in docs and tests Whitespace fix is in, so no need for {' '} anymore.
[ { "path": "src/browser/ui/dom/components/__tests__/ReactDOMInput-test.js", "patch": "@@ -145,8 +145,8 @@ describe('ReactDOMInput', function() {\n render: function() {\n return (\n <div>\n- <input ref=\"a\" type=\"radio\" name=\"fruit\" checked={true} />A{' '}\n- ...
2014-03-25T19:31:45
rust-lang/rust
bec53460384238b124d320a5964069e76b2c42be
a5469b8b4a29c4c57d3c5833a2f946537666d898
fix clippy test
[ { "path": "tests/ui/crashes/ice-96721.stderr", "patch": "@@ -3,6 +3,8 @@ error: malformed `path` attribute input\n |\n LL | #[path = foo!()]\n | ^^^^^^^^^^^^^^^^ help: must be of the form: `#[path = \"file\"]`\n+ |\n+ = note: for more information, visit <https://doc.rust-lang.org/reference/items/m...
2025-08-11T20:04:27
vercel/next.js
02103feb296759d5b873b64ad4fca4e3030ad063
2b0288912b90ae6f18de6022fd4f0f6fa5053211
onHeaders updates for App Pages (#58410) This serves to address a few problems as it relates to headers handling within the App Page render pipeline. 1. During static generation, we should not write to the response directly as the revalidation for static responses is performed out of band from the actual request/resp...
[ { "path": "packages/next/src/export/routes/app-page.ts", "patch": "@@ -184,7 +184,7 @@ export async function exportAppPage(\n )\n }\n \n- const headers = { ...metadata.extraHeaders }\n+ const headers = { ...metadata.headers }\n \n if (fetchTags) {\n headers[NEXT_CACHE_TAGS_HEADER] ...
2023-11-16T05:44:58
golang/go
4e7e7ae1406c70d9cc0809ec11105a55a60a0b70
a295890c5c8ebae9cba8f01ddcee2bded7dad404
net/http: don't time out idle server connections after ReadHeaderTimeout Consistently wait for idle connections to become readable before starting the ReadHeaderTimeout timer. Previously, connections with no idle timeout skipped directly to reading headers, so the ReadHeaderTimeout also included time spent idle. Fixe...
[ { "path": "src/net/http/serve_test.go", "patch": "@@ -5843,6 +5843,58 @@ func TestServerCancelsReadTimeoutWhenIdle(t *testing.T) {\n \t})\n }\n \n+// Issue 54784: test that the Server's ReadHeaderTimeout only starts once the\n+// beginning of a request has been received, rather than including time the\n+// ...
2022-08-31T19:16:18
nodejs/node
c3866a1b3e9de7b19753d822b313509f43266c42
a48928836a930ecdc894e9c684a675bde1508109
deps: V8: un-cherry-pick bd019bd Original commit message: [testrunner] delete ancient junit compatible format support Testrunner has ancient support for JUnit compatible XML output. This CL removes this old feature. R=mstarzinger@chromium.org,jgruber@chromium.org,jkummerow@chromium.org CC=​mach...
[ { "path": "common.gypi", "patch": "@@ -36,7 +36,7 @@\n \n # Reset this number to 0 on major V8 upgrades.\n # Increment by one for each non-official patch applied to deps/v8.\n- 'v8_embedder_string': '-node.1',\n+ 'v8_embedder_string': '-node.2',\n \n ##### V8 defaults for Node.js #####\n "...
2019-03-27T14:32:10
facebook/react
89a21579149723c5db3a7f7472e33344e8584207
f0eae5086b0062bdf8f8e466803e061814486634
Only stop if the transition on this element ended This way it doesn't end when some random element elsewhere on the page has an ending transition. It must be noted that this is not a complete fix. If you have multiple transitions on the element, it still ends when the first ends. I ran into this not working (the...
[ { "path": "src/addons/transitions/ReactCSSTransitionGroupChild.js", "patch": "@@ -55,6 +55,9 @@ var ReactCSSTransitionGroupChild = React.createClass({\n var noEventTimeout = null;\n \n var endListener = function() {\n+ if (e.target !== node) {\n+ return;\n+ }\n if (__DEV__) {\...
2014-03-25T14:02:12
rust-lang/rust
928dd114377f5a0c9db521d85987f0df73ca254d
adccb8d214d7e4a7e87554f289b077fe5fb972ef
fix clippy test
[ { "path": "src/tools/clippy/tests/ui/crashes/ice-96721.stderr", "patch": "@@ -3,6 +3,8 @@ error: malformed `path` attribute input\n |\n LL | #[path = foo!()]\n | ^^^^^^^^^^^^^^^^ help: must be of the form: `#[path = \"file\"]`\n+ |\n+ = note: for more information, visit <https://doc.rust-lang.org/...
2025-08-11T20:04:27
vercel/next.js
f163dd097f2dad9a7a56e8d67646a89b9032729e
70389d0cfd0cc2f3b42ce09db52be52588fd5573
examples: fix unhandled runtime error for forms (#56600) Co-authored-by: Lee Robinson <me@leerob.io>
[ { "path": "examples/next-forms/app/actions.ts", "patch": "@@ -13,10 +13,16 @@ export async function createTodo(prevState: any, formData: FormData) {\n const schema = z.object({\n todo: z.string().min(1),\n })\n- const data = schema.parse({\n+ const parse = schema.safeParse({\n todo: formData.g...
2023-11-16T05:13:23
electron/electron
c8951d0d4d419766fb47a12d4c10c971ab9ddc98
76529b50653df31736283f468407656f35a5c32a
Upgrade libcc for ffmpeg linking fix
[ { "path": "script/lib/config.py", "patch": "@@ -9,7 +9,7 @@\n BASE_URL = os.getenv('LIBCHROMIUMCONTENT_MIRROR') or \\\n 'https://s3.amazonaws.com/github-janky-artifacts/libchromiumcontent'\n LIBCHROMIUMCONTENT_COMMIT = os.getenv('LIBCHROMIUMCONTENT_COMMIT') or \\\n- 'dd95b11e52f1e5596184d83d91c91d7b0...
2017-03-29T16:19:21
golang/go
a73506cff560c4d95ac604f4f76d58386ca29ed9
2392b7061cfc71dcdaefeb027dcce0951f697658
internal/syscall/unix: consolidate kernelVersion implementations Currently, there are 3 functions returning Linux kernel version numbers. Two of them are identical: - in net, initially added by commit 0a9dd47dd817904e; - in internal/poll, initially added by commit 1c7650aa93bd53; (both were later fixed by commit 6...
[ { "path": "src/internal/poll/copy_file_range_linux.go", "patch": "@@ -17,46 +17,11 @@ var (\n \n const maxCopyFileRangeRound = 1 << 30\n \n-func kernelVersion() (major int, minor int) {\n-\tvar uname syscall.Utsname\n-\tif err := syscall.Uname(&uname); err != nil {\n-\t\treturn\n-\t}\n-\n-\trl := uname.Rele...
2022-08-18T20:43:47
nodejs/node
12b3e0c1acb937d919fe03f27499a9775ef05bbf
86f8f47cc346c3aa386919b239bd10f58bcfb351
doc: fix typo in n-api.md This commit fixes what I think is a typo, even though the section in question does talk about a environment (env). PR-URL: https://github.com/nodejs/node/pull/33319 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@g...
[ { "path": "doc/api/n-api.md", "patch": "@@ -369,7 +369,7 @@ Native addons may need to allocate global state of which they make use during\n their entire life cycle such that the state must be unique to each instance of\n the addon.\n \n-To this env, N-API provides a way to allocate data such that its life c...
2020-05-09T04:20:26
vercel/next.js
c6d30da39407d1a0af10df35e5fa4003acf5ba3a
6d29fc1bfd87cb05b745e42dfcca0d4e2889ae75
examples: fix typo for component (#58330)
[ { "path": "examples/app-dir-i18n-routing/app/[lang]/components/counter.tsx", "patch": "@@ -13,7 +13,7 @@ export default function Counter({\n const [count, setCount] = useState(0)\n return (\n <p>\n- This compoment is rendered on client:\n+ This component is rendered on client:\n <but...
2023-11-16T05:00:27
golang/go
a0f05823e4953d137310de164b2544e41dd767d2
32964f9dce9615f7c1072e5ead9e11e6db5d2237
syscall: fix skipping some tests on Linux The kernel knob /proc/sys/kernel/unprivileged_userns_clone is only available in Debian (and Ubuntu) kernels, so if the tests are run on e.g. Fedora, skipUnprivilegedUserClone() skips a lot of tests. Modify it to treat ENOENT as "it should work". Change-Id: I959201ede139ede98...
[ { "path": "src/syscall/exec_linux_test.go", "patch": "@@ -65,6 +65,10 @@ func skipUnprivilegedUserClone(t *testing.T) {\n \t// Skip the test if the sysctl that prevents unprivileged user\n \t// from creating user namespaces is enabled.\n \tdata, errRead := os.ReadFile(\"/proc/sys/kernel/unprivileged_userns_...
2022-07-15T02:40:23
nodejs/node
86f8f47cc346c3aa386919b239bd10f58bcfb351
5ded044deaad44ea4b87b321e02190cdb12fe33a
src: fix typo in comment in async_wrap.cc PR-URL: https://github.com/nodejs/node/pull/33350 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Juan José Arboleda <soyjuana...
[ { "path": "src/async_wrap.cc", "patch": "@@ -702,7 +702,7 @@ AsyncWrap::AsyncWrap(Environment* env, Local<Object> object)\n \n // This method is necessary to work around one specific problem:\n // Before the init() hook runs, if there is one, the BaseObject() constructor\n-// registers this object with the ...
2020-05-11T09:45:20
rust-lang/rust
32ee26c625e8fbb7a3aa56788cbb352f04491964
413ca5d9f0868f5d91a8b773ce60d70d5205c3f3
Add more docs to templates for attrs with incorrect arguments
[ { "path": "compiler/rustc_attr_parsing/src/attributes/cfg.rs", "patch": "@@ -16,7 +16,10 @@ use crate::{\n CfgMatchesLintEmitter, fluent_generated, parse_version, session_diagnostics, try_gate_cfg,\n };\n \n-pub const CFG_TEMPLATE: AttributeTemplate = template!(List: &[\"predicate\"]);\n+pub const CFG_T...
2025-08-11T17:02:32
facebook/react
5aaf4dbae95f8b41a1f16c260e03124c25a6fe9f
ecea2918cf59dc4c465cb060aaa2adf218b25bd1
Fix a minor typo in the `update()` docs
[ { "path": "docs/docs/09.6-update.md", "patch": "@@ -40,7 +40,7 @@ var newData = extend(myData, {\n \n While this is fairly performant (since it only shallow copies `log n` objects and reuses the rest), it's a big pain to write. Look at all the repetition! This is not only annoying, but also provides a large...
2014-03-19T22:33:43
vercel/next.js
6d29fc1bfd87cb05b745e42dfcca0d4e2889ae75
f5f0767ee54f4eccf777fb95a289c3cce29ce59f
examples: Fix hydration error in headers example (#58383)
[ { "path": "examples/headers/pages/index.tsx", "patch": "@@ -24,7 +24,7 @@ export default function Index() {\n <ul className={styles.list}>\n <li>\n <a href=\"/about\">\n- <a>Visit /about (it contains a X-About-Custom-Header)</a>\n+ Visit /abo...
2023-11-16T04:59:07
rust-lang/rust
a0306bfa314ba328ddb22123fe021c0ca90a0dec
3e77562b7d1325ee667a53a7364b463d655ab756
Update debugging/profiling bootstrap page
[ { "path": "src/doc/rustc-dev-guide/src/building/bootstrapping/debugging-bootstrap.md", "patch": "@@ -1,120 +1,100 @@\n # Debugging bootstrap\n \n-There are two main ways to debug bootstrap itself. The first is through println logging, and the second is through the `tracing` feature.\n-\n-> FIXME: this secti...
2025-08-11T16:10:29
nodejs/node
5ded044deaad44ea4b87b321e02190cdb12fe33a
b04e88439acca6915ffae4c6b9515ff896ad2cec
test: fix test-net-throttle Repeat writes until data is queued in memory, rather than assuming that it will happen by a certain point. Fixes: https://github.com/nodejs/node/issues/33135 PR-URL: https://github.com/nodejs/node/pull/33329 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Juan José Arboleda <...
[ { "path": "test/pummel/test-net-throttle.js", "patch": "@@ -23,44 +23,53 @@\n require('../common');\n const assert = require('assert');\n const net = require('net');\n+const debuglog = require('util').debuglog('test');\n \n-const N = 1024 * 1024;\n-const part_N = N / 3;\n let chars_recved = 0;\n let npauses...
2020-05-09T18:01:51
facebook/react
b95fbbe4a27809d25d19e24cc8090128158efe58
e505e47e0159b3990503826cad86fe276344f38a
Silence tests unsupported in PhantomJS. These tests can still be run in the browser using `grunt test --debug`. This is a repeat of 42f8d155f8f240c457c969ac683d8b25876708ee. For posterity, we do this because Phantom has a problem with Object.freeze and the test runner can't do __DEV__ right (because we get rid of tha...
[ { "path": "src/vendor/immutable/__tests__/ImmutableObject-test.js", "patch": "@@ -141,6 +141,7 @@ describe('ImmutableObject', function() {\n testDevAndProd(\n 'should create distinct object with shallow field insertion',\n function() {\n+ if (window.callPhantom) return;\n var beforeStru...
2014-03-19T00:48:16
golang/go
b226cc5ca025635175031d3ffb9596614b66bdaf
0fda8b19328edbfab880be6cb4033ff6c81eca6d
cmd/internal/obj/riscv: fix comment typo Change-Id: Ica74977898f0af8c9abf42a003d8f02dbdc03d34 Reviewed-on: https://go-review.googlesource.com/c/go/+/427994 TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Joel Sing <joel@sing.id.au> Run-TryBot: Wayne Zuo <wdvxdr@golangcn.org> Reviewed-by: Cherry Mui <cherry...
[ { "path": "src/cmd/internal/obj/riscv/obj.go", "patch": "@@ -1715,7 +1715,7 @@ func instructionsForOpImmediate(p *obj.Prog, as obj.As, rs int16) []*instruction\n \t}\n \n \t// LUI $high, TMP\n-\t// ADDI $low, TMP, TMP\n+\t// ADDIW $low, TMP, TMP\n \t// <op> TMP, REG, TO\n \tinsLUI := &instruction{as: ALUI, ...
2022-09-02T14:26:05
vercel/next.js
72267460518ce235c4230950f48b15a21becfb0d
8d9282ce9d568c8719fe9452e9eb72bd2c14c2a6
docs: fix filename when it should be dynamic route (#58032)
[ { "path": "docs/02-app/01-building-your-application/02-data-fetching/02-patterns.mdx", "patch": "@@ -63,7 +63,7 @@ If you have nested components, and each component fetches its own data, then dat\n \n For example, the `Playlists` component will only start fetching data once the `Artist` component has finish...
2023-11-16T04:56:39
electron/electron
ff745e1a823b059c243aa39895e7160b69a7a0b6
8d8c7ce6ad37ce0b512d0775b297c2880e401927
Use prefix increment in for loops.
[ { "path": "atom/browser/browser_mac.mm", "patch": "@@ -64,7 +64,7 @@\n // On macOS, we can't query the default, but the handlers list seems to put\n // Apple's defaults first, so we'll use the first option that isn't our bundle\n CFStringRef other = nil;\n- for (CFIndex i = 0; i < CFArrayGetCount(bun...
2017-03-30T20:56:21
nodejs/node
b04e88439acca6915ffae4c6b9515ff896ad2cec
8a6fab02adab2de05f6e864847f96b0924be0840
http: don't destroy completed request Calling destroy() on a completed ClientRequest, i.e. once 'close' will be emitted should be a noop. Also before emitting 'close' destroyed === true. Fixes: https://github.com/nodejs/node/issues/32851 PR-URL: https://github.com/nodejs/node/pull/33120 Reviewed-By: Matteo Collina <...
[ { "path": "lib/_http_client.js", "patch": "@@ -415,6 +415,8 @@ function socketCloseListener() {\n // the `socketOnData`.\n const parser = socket.parser;\n const res = req.res;\n+\n+ req.destroyed = true;\n if (res) {\n // Socket closed before we emitted 'end' below.\n // TOOD(ronag): res.de...
2020-04-28T11:57:32
facebook/react
22057ef61c6efb485b2374afe0fe3a3b2ecbc249
0278f01d9511ba9000f4bf5d112b01ff1446b3a8
don't try to use Object.prototype methods as transfer strategies in ReactPropTransferer.mergeProps While looking up a detail of how `transferPropsTo()` works I noticed that we never check `TransferStrategies.hasOwnProperty(thisKey)` when merging props, just `newProps.hasOwnProperty(thisKey)` and a truthy test for `Tra...
[ { "path": "src/core/ReactPropTransferer.js", "patch": "@@ -95,7 +95,7 @@ var ReactPropTransferer = {\n \n var transferStrategy = TransferStrategies[thisKey];\n \n- if (transferStrategy) {\n+ if (transferStrategy && TransferStrategies.hasOwnProperty(thisKey)) {\n transferStrategy(prop...
2014-03-18T21:55:08
golang/go
0fda8b19328edbfab880be6cb4033ff6c81eca6d
55ca6a20afb718972f0625ce971081f78efe10bf
go/types, types2: consistently write "x | y" rather than "x|y" for unions Use the same spacing convention ("x | y") for union terms everythere, matching the gofmt precedent. Fixes #53279. Change-Id: Ic3ccd7433b5f62402ba41cf05a75f9a1d99a8086 Reviewed-on: https://go-review.googlesource.com/c/go/+/410955 Reviewed-by: R...
[ { "path": "src/cmd/compile/internal/types2/api_test.go", "patch": "@@ -358,27 +358,27 @@ func TestTypesInfo(t *testing.T) {\n \t\t// issue 50093\n \t\t{`package u0a; func _[_ interface{int}]() {}`, `int`, `int`},\n \t\t{`package u1a; func _[_ interface{~int}]() {}`, `~int`, `~int`},\n-\t\t{`package u2a; fun...
2022-09-02T17:24:53
vercel/next.js
8d9282ce9d568c8719fe9452e9eb72bd2c14c2a6
f8343e80dd17fbf3fcbe1b567dc9cc3bee63bec8
docs: fix grammar issue in "Data Fetching Patterns" (#58056)
[ { "path": "docs/02-app/01-building-your-application/02-data-fetching/02-patterns.mdx", "patch": "@@ -137,7 +137,7 @@ This will prevent the whole route from being blocked by data fetching, and the u\n >\n > An alternative approach to prevent waterfalls is to fetch data globally, at the root of your applicati...
2023-11-16T04:55:19
electron/electron
424078cfdba3d36dae3df4428014e2c6402eb2d3
bd5c53c2f70029d3ef862f51702cb39c0b69173f
Fix namespace comments.
[ { "path": "brightray/browser/browser_client.cc", "patch": "@@ -23,7 +23,7 @@ namespace {\n \n BrowserClient* g_browser_client;\n \n-}\n+} // namespace\n \n BrowserClient* BrowserClient::Get() {\n return g_browser_client;", "additions": 1, "deletions": 1, "language": "Unknown" }, { "pat...
2017-03-28T19:06:02
nodejs/node
8a6fab02adab2de05f6e864847f96b0924be0840
cbf2fa63d7ffb6f7e129086c2d85b306ef247186
http: emit 'error' on aborted server request Server requests aka. IncomingMessage emits 'aborted' instead of 'error' which causes confusion when the object is used as a regular stream, i.e. if functions working on streams are passed a server request object they might not work properly unless they take this into accoun...
[ { "path": "doc/api/http.md", "patch": "@@ -333,9 +333,8 @@ Until the data is consumed, the `'end'` event will not fire. Also, until\n the data is read it will consume memory that can eventually lead to a\n 'process out of memory' error.\n \n-Unlike the `request` object, if the response closes prematurely, t...
2020-04-30T18:29:35
golang/go
511cd9b8af10de9cad86be38a22e5eb2e5d4cd8d
f00fa0b98da9f4353839da99e6f6f7f109f9954f
runtime: switch gp when jumping stacks during traceback Currently, when traceback jumps from the system stack to a user stack (e.g., during profiling tracebacks), it leaves gp pointing at the g0. This is currently harmless since it's only used during profiling, so the code paths in gentraceback that care about gp aren...
[ { "path": "src/runtime/traceback.go", "patch": "@@ -167,20 +167,22 @@ func gentraceback(pc0, sp0, lr0 uintptr, gp *g, skip int, pcbuf *uintptr, max in\n \t\t\t\t\t// This keeps morestack() from showing up in the backtrace,\n \t\t\t\t\t// but that makes some sense since it'll never be returned\n \t\t\t\t\t//...
2022-07-12T20:35:26
vercel/next.js
f8343e80dd17fbf3fcbe1b567dc9cc3bee63bec8
bdbc30f14a96bd306df5445a738a00559728cc89
docs: Fix grammar in Dynamic Rendering section (#58062)
[ { "path": "docs/02-app/01-building-your-application/03-rendering/01-server-components.mdx", "patch": "@@ -78,7 +78,7 @@ Dynamic rendering is useful when a route has data that is personalized to the us\n \n > **Dynamic Routes with Cached Data**\n >\n-> In most websites, routes are not fully static or fully d...
2023-11-16T04:54:42
facebook/react
d889a01cafd749a99ea5b6d67f8913cc21b451d1
04f9887f0e2a078625e6d8e27c28dd1ec5ffd645
Fix ref behavior for remounting I'm thinking that setting up `this.refs` in `mountComponent` is better than `construct`. Followed the same pattern as `ReactComponent.Mixin` and nulling out the value in `construct` and setting it to its initial value in `mountComponent`.
[ { "path": "src/core/ReactCompositeComponent.js", "patch": "@@ -978,7 +978,6 @@ var ReactCompositeComponentMixin = {\n this._renderedComponent = null;\n \n ReactComponent.Mixin.unmountComponent.call(this);\n- ReactOwner.Mixin.unmountComponent.call(this);\n \n // Some existing components rely o...
2014-03-17T04:55:12
nodejs/node
2fa86b818bb85d0aade89d4dcd4765e439ce7a01
34d92b78ab93e86168a2ddfe633eea42958bdd9d
lib: fix typo in timers insert function comment PR-URL: https://github.com/nodejs/node/pull/33301 Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <rub...
[ { "path": "lib/internal/timers.js", "patch": "@@ -338,7 +338,7 @@ function insertGuarded(item, refed, start) {\n }\n \n function insert(item, msecs, start = getLibuvNow()) {\n- // Truncate so that accuracy of sub-milisecond timers is not assumed.\n+ // Truncate so that accuracy of sub-millisecond timers i...
2020-05-08T06:21:50
golang/go
5b1fbfba1c00be5f2e9fd9e75fb7530f218fca40
34f0029a85af054787b279761e89db410621f1d7
cmd/compile: rewrite >>c<<c to &^(1<<c-1) Fixes #54496 Change-Id: I3c2ed8cd55836d5b07c8cdec00d3b584885aca79 Reviewed-on: https://go-review.googlesource.com/c/go/+/424856 Reviewed-by: Keith Randall <khr@google.com> Reviewed-by: Heschi Kreinick <heschi@google.com> Run-TryBot: Martin Möhrmann <martin@golang.org> TryBot-...
[ { "path": "src/cmd/compile/internal/ssa/gen/generic.rules", "patch": "@@ -443,6 +443,17 @@\n (Rsh32Ux64 (Rsh32x64 x _) (Const64 <t> [31])) => (Rsh32Ux64 x (Const64 <t> [31]))\n (Rsh64Ux64 (Rsh64x64 x _) (Const64 <t> [63])) => (Rsh64Ux64 x (Const64 <t> [63]))\n \n+// Convert x>>c<<c to x&^(1<<c-1)\n+(Lsh64x6...
2022-08-17T20:09:12
vercel/next.js
bdbc30f14a96bd306df5445a738a00559728cc89
1d5c78b92596a9229b4dbd070e086c1c8ae5a555
docs: Fix grammar in Client Components section (#58065)
[ { "path": "docs/02-app/01-building-your-application/03-rendering/02-client-components.mdx", "patch": "@@ -54,7 +54,7 @@ export default function Counter() {\n }\n ```\n \n-The diagram below shows nested components, using `onClick` and `useState` in `toggle.js` will cause an error if the `\"use client\"` dire...
2023-11-16T04:54:21
facebook/react
04f9887f0e2a078625e6d8e27c28dd1ec5ffd645
9b427a322f87f2fd2f3c7227e04f848bbbcc622e
More actionable error message for <tbody> and nested <p> This bites people all of the time. Until we have a better solution, let's just make the error message more actionable (most people don't know how the DOM gets unexpectedly mutated).
[ { "path": "src/browser/ui/ReactMount.js", "patch": "@@ -618,8 +618,10 @@ var ReactMount = {\n invariant(\n false,\n 'findComponentRoot(..., %s): Unable to find element. This probably ' +\n- 'means the DOM was unexpectedly mutated (e.g., by the browser). ' +\n- 'Try inspecting the c...
2014-03-17T04:55:01
electron/electron
b3cf00a19aa57c32774e60eb2a0b70c0f25aef1e
57edc28b0d26934aba91a903f549188ea3e7c48f
Fix net module to accept non-string header values This is required to be compatible with node.js http module.
[ { "path": "docs/api/client-request.md", "patch": "@@ -158,17 +158,18 @@ internally buffered inside Electron process memory.\n #### `request.setHeader(name, value)`\n \n * `name` String - An extra HTTP header name.\n-* `value` String - An extra HTTP header value.\n+* `value` Object - An extra HTTP header val...
2017-03-30T16:24:40
rust-lang/rust
413ca5d9f0868f5d91a8b773ce60d70d5205c3f3
6bb29af766caa678bd47ef0e6e3e429c8bd3fbd8
fix tests
[ { "path": "tests/ui/attributes/lint_on_root.stderr", "patch": "@@ -11,7 +11,7 @@ LL | #![inline = \"\"]\n error: aborting due to 1 previous error\n \n Future incompatibility report: Future breakage diagnostic:\n-error: valid forms for the attribute are `#[inline(always|never)]` and `#[inline]`\n+error: vali...
2025-08-11T16:05:02
nodejs/node
34d92b78ab93e86168a2ddfe633eea42958bdd9d
18584727de5df6bf7332e746b9caee0adb278b98
src: remove unnecessary Isolate::GetCurrent() calls These calls are unnecessary in Release mode but would still have been included, so move them to the `DebugSealHandleScope` constructor. PR-URL: https://github.com/nodejs/node/pull/33298 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Colin Ihri...
[ { "path": "src/node_internals.h", "patch": "@@ -243,9 +243,9 @@ class InternalCallbackScope {\n \n class DebugSealHandleScope {\n public:\n- explicit inline DebugSealHandleScope(v8::Isolate* isolate)\n+ explicit inline DebugSealHandleScope(v8::Isolate* isolate = nullptr)\n #ifdef DEBUG\n- : actual_sco...
2020-05-08T03:56:31
golang/go
553f02c6ae9d9dc124559b6711a47cb3e99c6348
6605686e3b503a1d82a526e3970ce4c93f7e2106
debug/macho: use saferio to allocate load command slice Avoid allocating large amounts of memory for corrupt input. No test case because the problem can only happen for invalid data. Let the fuzzer find cases like this. Fixes #54780 Change-Id: Icdacb16bef7d29ef431da52e6d1da4e883a3e050 Reviewed-on: https://go-review...
[ { "path": "src/debug/macho/file.go", "patch": "@@ -249,8 +249,8 @@ func NewFile(r io.ReaderAt) (*File, error) {\n \tif f.Magic == Magic64 {\n \t\toffset = fileHeaderSize64\n \t}\n-\tdat := make([]byte, f.Cmdsz)\n-\tif _, err := r.ReadAt(dat, offset); err != nil {\n+\tdat, err := saferio.ReadDataAt(r, uint64...
2022-09-01T08:48:58
vercel/next.js
1d5c78b92596a9229b4dbd070e086c1c8ae5a555
05374d3a0c245a9cfaeef3dd11af5c524a6f9519
docs: Fix grammar in Styling section (#58071)
[ { "path": "docs/02-app/01-building-your-application/05-styling/04-sass.mdx", "patch": "@@ -15,7 +15,7 @@ npm install --save-dev sass\n \n > **Good to know**:\n >\n-> Sass supports [two different syntax](https://sass-lang.com/documentation/syntax), each with their own extension.\n+> Sass supports [two differ...
2023-11-16T04:53:10
facebook/react
9b427a322f87f2fd2f3c7227e04f848bbbcc622e
7bbdcdba9615e5a1f6704e9a07a44b2bc5530487
Fix some invalid uses of instances Breaking this out of the other code mod.
[ { "path": "src/browser/server/ReactServerRendering.js", "patch": "@@ -75,7 +75,8 @@ function renderComponentToStaticMarkup(component) {\n transaction = ReactServerRenderingTransaction.getPooled(true);\n \n return transaction.perform(function() {\n- return component.mountComponent(id, transactio...
2014-03-13T23:23:47
electron/electron
bd935b213f2c9a9aa1807aefecb33d8c47aaead1
a7565f0d5704c1c5a12ec24a3ee669358efc413b
Fix compilation against macOS 10.10 SDK
[ { "path": "atom/browser/native_window_mac.mm", "patch": "@@ -336,6 +336,14 @@ - (id)initWithURL:(NSURL*)url title:(NSString*)title {\n \n @end\n \n+enum {\n+ NSWindowTabbingModeDisallowed = 2\n+};\n+@interface NSWindow (SierraSDK)\n+- (void)setTabbingMode:(NSInteger)mode;\n+- (void)setTabbingIdentifier:(NS...
2017-03-30T13:13:49
rust-lang/rust
6bb29af766caa678bd47ef0e6e3e429c8bd3fbd8
625143bac3e2917adb59314a408b17e8d2f9bd65
Add link to invalid `repr` error
[ { "path": "compiler/rustc_attr_parsing/messages.ftl", "patch": "@@ -132,6 +132,7 @@ attr_parsing_unknown_version_literal =\n attr_parsing_unrecognized_repr_hint =\n unrecognized representation hint\n .help = valid reprs are `Rust` (default), `C`, `align`, `packed`, `transparent`, `simd`, `i8`, `u8`,...
2025-08-11T04:39:55
nodejs/node
36b2e25b4a20a40ad54046e36c584285d0a24581
c252f6c93f2e1a01d0d479158ec494c0ceac52cb
tools: add eslint rule to only pass through 'test' to debuglog This makes sure all usages of `util.debuglog()` must contain the string 'test' as argument. PR-URL: https://github.com/nodejs/node/pull/32161 Refs: https://github.com/nodejs/node/pull/32078 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M S...
[ { "path": "test/.eslintrc.yaml", "patch": "@@ -11,6 +11,42 @@ rules:\n prefer-const: error\n symbol-description: off\n \n+ no-restricted-syntax:\n+ # Config copied from .eslintrc.js\n+ - error\n+ - selector: \"CallExpression:matches([callee.name='deepStrictEqual'], [callee.property.name='deepS...
2020-03-09T20:53:03
golang/go
6605686e3b503a1d82a526e3970ce4c93f7e2106
19a48048543098a05efe48adb1cf8f01bfce75f1
cmd/compile: new inline heuristic for struct compares This CL changes the heuristic used to determine whether we can inline a struct equality check or if we must generate a function and call that function for equality. The old method was to count struct fields, but this can lead to poor in lining decisions. We should...
[ { "path": "src/cmd/compile/internal/compare/compare.go", "patch": "@@ -79,10 +79,93 @@ func EqCanPanic(t *types.Type) bool {\n \t}\n }\n \n+// EqStructCost returns the cost of an equality comparison of two structs.\n+//\n+// The cost is determined using an algorithm which takes into consideration\n+// the s...
2022-08-30T21:48:17
vercel/next.js
ee99c9f6e5f5f1b0de3e5cd5fb694a21e8f9578b
dd4593b937dcd24445cb45db11c3d59bc936f994
docs: fix grammar in revalidateTag docs (#58210)
[ { "path": "docs/02-app/01-building-your-application/04-caching/index.mdx", "patch": "@@ -504,7 +504,7 @@ There are two places you can use `revalidateTag`, depending on what you're tryin\n \n ### `revalidatePath`\n \n-`revalidatePath` allows you manually revalidate data **and** re-render the route segments b...
2023-11-16T04:51:10
facebook/react
3c9b797d21b5bec1c3db49f0ea2b9def59270183
b0f9f73e918f544601b97df52709ce83067e91a2
fix `(`
[ { "path": "docs/docs/01-why-react.zh-CN.md", "patch": "@@ -14,7 +14,7 @@ React 是一个 Facebook 和 Instagram 用来创建用户界面的 JavaScript \n \n 仅仅只要表达出你的应用程序在任一个时间点应该长的样子,然后当底层的数据变了,React 会自动更新所有UI的变化。\n \n-### 表达能力(Declarative)\n+### 表达能力 (Declarative)\n \n 当数据变化了,React 概念上是类似点击了更新的按钮,但仅会更新变化的部分。\n ", "additions": ...
2014-03-13T13:00:25
electron/electron
99293dd57ffd152e68cf549041680145c495da24
637bdc239b8f613fec7295e119aa86a753c51d0d
Fix namespace comments.
[ { "path": "atom/browser/auto_updater_mac.mm", "patch": "@@ -27,7 +27,7 @@\n bool g_update_available = false;\n std::string update_url_ = \"\";\n \n-}\n+} // namespace\n \n std::string AutoUpdater::GetFeedURL() {\n return update_url_;", "additions": 1, "deletions": 1, "language": "Objective-C++...
2017-03-29T18:47:41
rust-lang/rust
189f264926ff70b58c8907473de60766477e7dd6
577166503aee7290e09374da21f4045c455acfd5
Allow attr entries to declare list of alternatives for `List` and `NamedValueStr` Modify `AttributeTemplate` to support list of alternatives for list and name value attribute styles. Suggestions now provide more correct suggested code: ``` error[E0805]: malformed `used` attribute input --> $DIR/used_with_multi_arg...
[ { "path": "compiler/rustc_attr_parsing/src/attributes/allow_unstable.rs", "patch": "@@ -15,7 +15,7 @@ impl<S: Stage> CombineAttributeParser<S> for AllowInternalUnstableParser {\n type Item = (Symbol, Span);\n const CONVERT: ConvertFn<Self::Item> =\n |items, span| AttributeKind::AllowInternal...
2025-08-11T01:46:34
nodejs/node
1182539307be70eefe25940ddc1de60991fd35a3
94e5b5c77dade0d8f7358c66144b75c369679cab
perf_hooks: fix error message for invalid entryTypes Will now print a more meaningful value instead of always [object Object] PR-URL: https://github.com/nodejs/node/pull/33285 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> R...
[ { "path": "lib/perf_hooks.js", "patch": "@@ -341,19 +341,20 @@ class PerformanceObserver extends AsyncResource {\n if (typeof options !== 'object' || options === null) {\n throw new ERR_INVALID_ARG_TYPE('options', 'Object', options);\n }\n- if (!ArrayIsArray(options.entryTypes)) {\n- t...
2020-05-07T18:23:56
facebook/react
29abe53924de336ab8c0df677df23adf06c9c2a3
6fd53815cde8e6196c617711809cc73fab83ed4f
Update jasmine-support.js fix typo in multiple error messages.
[ { "path": "vendor/jasmine/jasmine-support.js", "patch": "@@ -13,7 +13,7 @@ jasmine.getEnv().beforeEach(function() {\n \n lastCalledWith: function() {\n if (this.actual.mock === undefined) {\n- throw Error('toBeCalled() should be used on a mock function');\n+ throw Error('lastCalledWi...
2014-03-12T18:39:14
golang/go
19a48048543098a05efe48adb1cf8f01bfce75f1
121344ac338ef21d87eee4f64a60d0ae8a7f6fe3
runtime: support MADV_DONTNEED on the BSDs and Solaris/Illumos Like on Linux, use GODEBUG=madvdontneed=1 to enable madvise with MADV_DONTNEED instead of MADV_FREE. Based on previous work by Marcelo Araujo in CL 181498. Fixes #32519 Change-Id: Ib49faf05c42a65591b90e75f663146f213030529 Reviewed-on: https://go-review....
[ { "path": "src/runtime/defs1_netbsd_386.go", "patch": "@@ -20,7 +20,8 @@ const (\n \t_MAP_PRIVATE = 0x2\n \t_MAP_FIXED = 0x10\n \n-\t_MADV_FREE = 0x6\n+\t_MADV_DONTNEED = 0x4\n+\t_MADV_FREE = 0x6\n \n \t_SA_SIGINFO = 0x40\n \t_SA_RESTART = 0x2", "additions": 2, "deletions": 1, "language": ...
2022-08-29T11:29:43
vercel/next.js
e5bdc426212cc890be04f37e2b307214d55a9843
9f9c74b69e9edc5766cf996b0ef480c25ed3ad9d
docs: fix unnecessary capitalization (#58141)
[ { "path": "docs/02-app/01-building-your-application/02-data-fetching/02-patterns.mdx", "patch": "@@ -59,7 +59,7 @@ When fetching data inside React components, you need to be aware of two data fet\n \n #### Sequential Data Fetching\n \n-If you have nested components, and each component fetches its own data, ...
2023-11-16T04:45:25
golang/go
f45c2d7e47e6dcfb69876092037257562813cc37
274528eca1ebbb3aa5203e77152925ca1de98601
go/types,types2: move notinheap tests to fixedbugs directory So they can be added to ignored list, since the tests now require cgo.Incomplete, which is not recognized by go/types and types2. Updates #46731 Change-Id: I9f24e3c8605424d1f5f42ae4409437198f4c1326 Reviewed-on: https://go-review.googlesource.com/c/go/+/427...
[ { "path": "src/cmd/compile/internal/types2/stdlib_test.go", "patch": "@@ -206,6 +206,8 @@ func TestStdFixed(t *testing.T) {\n \t\t\"issue42076.go\",\n \t\t\"issue46903.go\",\n \t\t\"issue51733.go\",\n+\t\t\"notinheap2.go\",\n+\t\t\"notinheap3.go\",\n \t)\n }\n ", "additions": 2, "deletions": 0, ...
2022-09-02T06:32:40
rust-lang/rust
6c3c620e6b65a130a6996cca14cb9e19cc8ea65c
1b5dbd9dfadd1019fc4447d602eda706fbf7fcdd
fix: Panic while trying to clear old diagnostics while there's nothing
[ { "path": "src/tools/rust-analyzer/crates/rust-analyzer/src/diagnostics.rs", "patch": "@@ -105,7 +105,7 @@ impl DiagnosticCollection {\n flycheck_id: usize,\n generation: DiagnosticsGeneration,\n ) {\n- if self.check[flycheck_id].generation < generation {\n+ if self.check.g...
2025-08-11T15:24:44
facebook/react
c6a59c0ae63834b90f854f32f0b3ebdf2acbe3e9
c3948483d975f57af4e2fedb426969f7c8d61563
fix some translation error
[ { "path": "docs/docs/01-why-react.zh-CN.md", "patch": "@@ -20,9 +20,7 @@ React 是一个 Facebook 和 Instagram 用来创建用户界面的 JavaScript \n \n ## 构建可组合的组件\n \n-React is all about building reusable components. In fact, with React the *only* thing you do is build components. Since they're so encapsulated, components make...
2014-03-11T09:42:03
vercel/next.js
52e8c4d10b030512804ff166df7ca3150094bac0
4cbfe7d7e859f07b0fd3ab343e6784695dd5e1e5
turbopack: Don't error with legacy server actions boolean (#58416) ### What? This stops Turbopack from erroring out when trying to parse apps using NextConfig's legacy `experimental.serverActions` boolean value. ### Why? Old apps may not have removed the legacy boolean flag, but should still run. ### How? At firs...
[ { "path": "packages/next-swc/crates/next-core/src/next_config.rs", "patch": "@@ -442,7 +442,7 @@ pub struct ExperimentalConfig {\n pub optimize_css: Option<serde_json::Value>,\n pub next_script_workers: Option<bool>,\n pub web_vitals_attribution: Option<Vec<String>>,\n- pub server_actions: Op...
2023-11-15T04:33:14
golang/go
5befb24bb5cbd8ae6210b4d6a88a4437eec6fb0b
321a220d506fe1445302706f1725017a42fc1510
go/types: use function name position for init errors This seems more sensible than the func keyword. With this change, go/types uses the same error position as types2 and we can narrow the error tolerance a bit. (The types2 change doesn't change its position, but it makes the code clearer and symmetric to go/types.) ...
[ { "path": "src/cmd/compile/internal/types2/check_test.go", "patch": "@@ -299,7 +299,7 @@ func TestManual(t *testing.T) {\n \n func TestCheck(t *testing.T) {\n \tDefPredeclaredTestFuncs()\n-\ttestDirFiles(t, \"../../../../internal/types/testdata/check\", 55, false) // TODO(gri) narrow column tolerance\n+\tte...
2022-09-02T03:47:41
electron/electron
e885e33b75799f7cc338d7604374efb35b08e2a3
4e473897b7dd168996d951c8d45c15c21ec5ffbe
Fix choise -> choice
[ { "path": "docs/api/window-open.md", "patch": "@@ -45,7 +45,7 @@ origin preference.\n ### Use Native `window.open()`\n \n If you want to use native `window.open()` implementation, pass `useNativeWindowOpen: true` in `webPreferences` option.\n-Native `window.open()` allows synchronous access to opened window...
2017-03-28T10:50:00
facebook/react
69767d4b792d2192ccd0e5b2cbfa29b401d798fd
c3948483d975f57af4e2fedb426969f7c8d61563
fix some translation error
[ { "path": "docs/docs/01-why-react.zh-CN.md", "patch": "@@ -20,9 +20,7 @@ React 是一个 Facebook 和 Instagram 用来创建用户界面的 JavaScript \n \n ## 构建可组合的组件\n \n-React is all about building reusable components. In fact, with React the *only* thing you do is build components. Since they're so encapsulated, components make...
2014-03-11T09:42:03
vercel/next.js
4cbfe7d7e859f07b0fd3ab343e6784695dd5e1e5
375d85d95e96df7be09f37eb620f977ae1cfd850
fix incorrect fetch cache handling (#58460) ### What? When `FetchCache` is used, cache gets were incorrectly bailing. This would result in unexpected behavior, like continuously revalidating a cache key, as described in #57978. ### Why? #57902 introduced a refactor to the `FileSystemCache` and changed the interface o...
[ { "path": "packages/next/src/server/lib/incremental-cache/fetch-cache.ts", "patch": "@@ -142,19 +142,13 @@ export default class FetchCache implements CacheHandler {\n }\n }\n \n- public async get(\n- key: string,\n- ctx: {\n- tags?: string[]\n- softTags?: string[]\n- fetchCache?:...
2023-11-15T01:24:08
golang/go
321a220d506fe1445302706f1725017a42fc1510
202b7e7e76128f524142ac7d328fe8458a096dbf
cmd/link: only add dummy XCOFF reference if the symbol exists On AIX when external linking, for some symbols we need to add dummy references to prevent the external linker from discarding them. Currently we add the reference unconditionally. But if the symbol doesn't exist, the linking fails in a later stage for gener...
[ { "path": "src/cmd/link/internal/ld/symtab.go", "patch": "@@ -684,8 +684,12 @@ func (ctxt *Link) symtab(pcln *pclntab) []sym.SymKind {\n \t\t// Add R_XCOFFREF relocation to prevent ld's garbage collection of\n \t\t// the following symbols. They might not be referenced in the program.\n \t\taddRef := func(na...
2022-09-01T23:31:04
rust-lang/rust
bcf87e4172416b96e24be998e18d81a8af183356
9a8facbe535e6197f4d2dfee03df11ccb902c73d
Update error message
[ { "path": "compiler/rustc_passes/messages.ftl", "patch": "@@ -669,8 +669,8 @@ passes_rustc_std_internal_symbol =\n .label = not a function or static\n \n passes_rustc_unstable_feature_bound =\n- attribute should be applied to `impl` or free function outside of any `impl` or trait\n- .label = not a...
2025-08-11T13:27:46
facebook/react
280ff2e5a78d2bc32309685749e57e5aa79dfe5d
5ede7fb6191c7c587cf7099d044746d1607cd8d5
Unbreak JSX comment comma fix
[ { "path": "vendor/fbtransform/transforms/react.js", "patch": "@@ -130,17 +130,26 @@ function visitReactTag(traverse, object, path, state) {\n var childrenToRender = object.children.filter(function(child) {\n return !(child.type === Syntax.Literal\n && typeof child.value === 'string'\n- ...
2014-03-10T23:31:59
electron/electron
2ef1b70897cbc86afe4cde7350fe6d2a801c4966
637bdc239b8f613fec7295e119aa86a753c51d0d
Fix crash happened in UvRunOnce
[ { "path": "atom/common/node_bindings.cc", "patch": "@@ -232,6 +232,12 @@ void NodeBindings::RunMessageLoop() {\n void NodeBindings::UvRunOnce() {\n node::Environment* env = uv_env();\n \n+ // When doing navigation without restarting renderer process, it may happen\n+ // that the node environment is dest...
2017-03-28T08:19:14
nodejs/node
ff6535a4331d611bf0d205ee23d88e100dce92b2
ae34e4737a67f58cfd67f61bc0521b37805a9cfc
http: return this from IncomingMessage#destroy() This commit updates IncomingMessage#destroy() to return `this` for consistency with other readable streams. PR-URL: https://github.com/nodejs/node/pull/32789 Fixes: https://github.com/nodejs/node/issues/32772 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: An...
[ { "path": "doc/api/http.md", "patch": "@@ -1847,9 +1847,15 @@ const req = http.request({\n ### `message.destroy([error])`\n <!-- YAML\n added: v0.3.0\n+changes:\n+ - version: REPLACEME\n+ pr-url: https://github.com/nodejs/node/pull/32789\n+ description: The function returns `this` for consistency wit...
2020-04-11T20:06:43