repo
stringclasses
15 values
fix_commit
stringlengths
40
40
buggy_commit
stringlengths
40
40
message
stringlengths
3
64.3k
files
listlengths
1
300
timestamp
timestamp[s]date
2013-03-13 20:45:00
2026-04-11 07:48:46
vercel/next.js
375d85d95e96df7be09f37eb620f977ae1cfd850
44613dc04599de61f63da24183eec22406e13ce0
fix: ensure batch values are sharable (#58315) Previously, the incremental cache returned objects with a readable stream (that were consumed). These can't be shared. Instead, this modifies the cache to instead return strings which are sharable. This also fixes a bug related to revalidation when writing an updated pre...
[ { "path": "packages/next/src/export/routes/app-page.ts", "patch": "@@ -15,6 +15,7 @@ import {\n import { isDynamicUsageError } from '../helpers/is-dynamic-usage-error'\n import {\n NEXT_CACHE_TAGS_HEADER,\n+ NEXT_META_SUFFIX,\n RSC_PREFETCH_SUFFIX,\n RSC_SUFFIX,\n } from '../../lib/constants'\n@@ -20...
2023-11-15T00:20:35
golang/go
202b7e7e76128f524142ac7d328fe8458a096dbf
ec2ea40b315e8b1a3d1dc8f7987584c4e2a00ef4
encoding/asn1: fix doc for BitString.At's return value Fixes #53287 Change-Id: If983ae34850d9b1b29764156a38628fa53897573 Reviewed-on: https://go-review.googlesource.com/c/go/+/411134 TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Heschi Kreinick <heschi@google.com> Run-TryBot: hopehook <hopehook@golangcn...
[ { "path": "src/encoding/asn1/asn1.go", "patch": "@@ -162,7 +162,7 @@ type BitString struct {\n }\n \n // At returns the bit at the given index. If the index is out of range it\n-// returns false.\n+// returns 0.\n func (b BitString) At(i int) int {\n \tif i < 0 || i >= b.BitLength {\n \t\treturn 0", "ad...
2022-06-08T16:42:26
nodejs/node
ae34e4737a67f58cfd67f61bc0521b37805a9cfc
38853eb84a0cf764182fa37dfdcca1c792969ce5
src: fix compiler warning in async_wrap.cc ../src/async_wrap.cc: In function ‘uint16_t node::ToAsyncHooksType(v8::PromiseHookType)’: ../src/async_wrap.cc:313:1: error: control reaches end of non-void function [-Werror=return-type] } Refs: https://github.com/nodejs/node/pull/32891 PR-URL: https://github....
[ { "path": "src/async_wrap.cc", "patch": "@@ -310,6 +310,7 @@ static uint16_t ToAsyncHooksType(PromiseHookType type) {\n case PromiseHookType::kAfter: return AsyncHooks::kAfter;\n case PromiseHookType::kResolve: return AsyncHooks::kPromiseResolve;\n }\n+ UNREACHABLE();\n }\n \n // Simplified Jav...
2020-05-09T06:12:10
vercel/next.js
e4158f6cec77fc6afa9a072b2b81267fcb88e18c
d6f1d94f2f3294aaaf17a1ac6ee6d657f00fca4b
fix: Don't reset shallow URL updates on prefetch (#58297) ## Description Between 14.0.2-canary.6 and 14.0.2-canary.7, a change was introduced in vercel/next.js#56497 that turned the Redux store state into a Promise, rather than a synchronous state update. This caused the `sync` function -- used to send state updates...
[ { "path": "packages/next/src/client/components/app-router.tsx", "patch": "@@ -35,7 +35,7 @@ import {\n PrefetchKind,\n } from './router-reducer/router-reducer-types'\n import type {\n- PushRef,\n+ AppRouterState,\n ReducerActions,\n RouterChangeByServerResponse,\n RouterNavigate,\n@@ -49,6 +49,7 @...
2023-11-14T19:29:18
golang/go
ec2ea40b315e8b1a3d1dc8f7987584c4e2a00ef4
134cd34c07862aa8618e25d1d1279b4fd127c512
cmd/compile: restrict //go:notinheap to runtime/internal/sys So it won't be visible outside of runtime package. There are changes to make tests happy: - For test/directive*.go files, using "go:noinline" for testing misplaced directives instead. - Restrict test/fixedbugs/bug515.go for gccgo only. - For test/notinh...
[ { "path": "src/cmd/compile/internal/noder/noder.go", "patch": "@@ -344,6 +344,9 @@ func (p *noder) pragma(pos syntax.Pos, blankLine bool, text string, old syntax.P\n \t\tif flag == 0 && !allowedStdPragmas[verb] && base.Flag.Std {\n \t\t\tp.error(syntax.Error{Pos: pos, Msg: fmt.Sprintf(\"//%s is not allowed ...
2022-08-07T18:10:18
facebook/react
3171436d979a61f55e997ac74915b94726fcbe7b
9ce7ecc3d9ceaebffc9428adaca9822892ae55e1
Switched from browserify to pure-cjs bundler. Optimizations and fix for JSXTransformer build. Dropped dependency on emulation of Node.js native modules. Added deamdify step for JSXTransformer build.
[ { "path": "grunt/config/browserify.js", "patch": "@@ -3,6 +3,7 @@\n \n 'use strict';\n \n+var deamdify = require('deamdify');\n var envify = require('envify/custom');\n var es3ify = require('es3ify');\n var grunt = require('grunt');\n@@ -81,6 +82,7 @@ var transformer = {\n outfile: './build/JSXTransformer...
2014-03-08T14:33:58
electron/electron
3028bffa736f0e22b1fd4106d36fd012c64bb139
9249228ac3ce772c2fcd98a379cef78bece9f2d8
Upgrade libcc for webview dnd fix
[ { "path": "script/lib/config.py", "patch": "@@ -9,7 +9,7 @@\n BASE_URL = os.getenv('LIBCHROMIUMCONTENT_MIRROR') or \\\n 'https://s3.amazonaws.com/github-janky-artifacts/libchromiumcontent'\n LIBCHROMIUMCONTENT_COMMIT = os.getenv('LIBCHROMIUMCONTENT_COMMIT') or \\\n- '44448acf6a21024b9adb7140ffef6402a...
2017-03-27T18:40:52
nodejs/node
ea465faf4ab39b923d5a975f30800a8edf2777ee
1aa491a88fdaf8695dc49ede67fce82ee44e53b6
tls: reset secureConnecting on client socket secureConnecting is never set to false on client TLS sockets. So if Http2Session constructor (in lib/internal/http2/core.js) is called after secureConnect is emitted, then it will wrongly wait for a secureConnect event. This fix sets secureConnecting to false when a client...
[ { "path": "lib/_tls_wrap.js", "patch": "@@ -1512,11 +1512,13 @@ function onConnectSecure() {\n debug('client emit secureConnect. rejectUnauthorized: %s, ' +\n 'authorizationError: %s', options.rejectUnauthorized,\n this.authorizationError);\n+ this.secureConnecting = false...
2020-05-02T06:42:26
rust-lang/rust
7daaa4ee01f4c4d026293a6e3a90e4c8b4f5aa12
6bb9af0eeb944611c3c87adca77afe86eda193d0
hotfix: Update flycheck diagnostics generation
[ { "path": "src/tools/rust-analyzer/crates/rust-analyzer/src/diagnostics.rs", "patch": "@@ -134,6 +134,7 @@ impl DiagnosticCollection {\n if self.check[flycheck_id].generation > generation {\n return;\n }\n+ self.check[flycheck_id].generation = generation;\n let dia...
2025-08-11T09:18:55
vercel/next.js
d6f1d94f2f3294aaaf17a1ac6ee6d657f00fca4b
1ee50b8e57c0473c78b8f208324baddf2917b91e
Revert "fix hmr event, and avoid RSC fetch on any message" (#58452) Reverts vercel/next.js#58403 Seems to be resulting in consistent CI failures [x-ref](https://github.com/vercel/next.js/actions/runs/6856034177/job/18658084460) [x-ref](https://github.com/vercel/next.js/actions/runs/6864944315/job/18667863954)
[ { "path": "packages/next/src/client/components/react-dev-overlay/hot-reloader-client.tsx", "patch": "@@ -338,16 +338,14 @@ function processMessage(\n })\n )\n \n- if (!process.env.TURBOPACK) {\n- const isHotUpdate =\n- obj.action !== HMR_ACTIONS_SENT_TO_BROWSER.SYNC &&\n- ...
2023-11-14T18:51:44
golang/go
8e35910640bd190103d99d994d54b738e619c858
ccab2fbc30b0553fce54646a4da0a8645eda40a3
math/rand: document that Source returned by NewSource implements Source64 Fixes #44488 Change-Id: I570950799788678b9dc6e9ddad894973b4611e09 Reviewed-on: https://go-review.googlesource.com/c/go/+/425974 Reviewed-by: Daniel Martí <mvdan@mvdan.cc> Reviewed-by: Joseph Tsai <joetsai@digital-static.net> TryBot-Result: Goph...
[ { "path": "src/math/rand/rand.go", "patch": "@@ -40,7 +40,12 @@ type Source64 interface {\n // NewSource returns a new pseudo-random Source seeded with the given value.\n // Unlike the default Source used by top-level functions, this source is not\n // safe for concurrent use by multiple goroutines.\n+// Th...
2022-08-26T19:10:32
nodejs/node
be7fd2d517abd852d9ee3cf099fb007370af1910
28e6626ce7020b490438e3ee8a8188a59c5f856f
fs: add .ref() and .unref() methods to watcher classes PR-URL: https://github.com/nodejs/node/pull/33134 Fixes: https://github.com/nodejs/node/issues/33096 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
[ { "path": "doc/api/fs.md", "patch": "@@ -579,6 +579,72 @@ added: v0.5.8\n Stop watching for changes on the given `fs.FSWatcher`. Once stopped, the\n `fs.FSWatcher` object is no longer usable.\n \n+### `watcher.ref()`\n+<!-- YAML\n+added: REPLACEME\n+-->\n+\n+* Returns: {fs.FSWatcher}\n+\n+When called, reque...
2020-04-28T18:00:35
vercel/next.js
a52512184879b606112c7b6b67b18796441d8bad
9450777c50c5755e667c8ae8d86efd42da0192b9
Turbopack: Implement structured styled text and use it in issue descriptions (vercel/turbo#6388) This implements a basic structure representing styled text and uses it in issue descriptions. This can be used by the cli and web-based error reporting. Tested with an upcoming Next.js PR --------- Co-authored-by: Tobia...
[ { "path": "crates/turbo-tasks-fetch/src/lib.rs", "patch": "@@ -5,7 +5,7 @@\n use anyhow::Result;\n use turbo_tasks::Vc;\n use turbo_tasks_fs::FileSystemPath;\n-use turbopack_core::issue::{Issue, IssueSeverity};\n+use turbopack_core::issue::{Issue, IssueSeverity, StyledString};\n \n pub fn register() {\n ...
2023-11-14T17:41:03
golang/go
57ade1fd0bc58e726e287efc9d8e1e87c5afa5ce
e2d2d3a4a6edf1e571a5aca1eaaf55ffcc4d6eba
go/types, types2: move shared tests into internal/types/testdata This CL moves the directories check, examples, fixedbugs, and spec from inside go/types/testdata to internal/types/testdata. Except for the directory adjustments to check_test.go files, this is a pure file move. With this CL, both type checkers now shar...
[ { "path": "src/cmd/compile/internal/types2/check_test.go", "patch": "@@ -299,12 +299,14 @@ func TestManual(t *testing.T) {\n \n func TestCheck(t *testing.T) {\n \tDefPredeclaredTestFuncs()\n-\ttestDirFiles(t, \"../../../../go/types/testdata/check\", 55, false) // TODO(gri) narrow column tolerance\n+\ttestDi...
2022-09-02T01:38:08
facebook/react
9766ed579746e6d3886ad6fd3477f18fcb211048
1d209248ef038d3cbd2ea81b2ff3a070db4e01c3
Bring back `grunt test --debug`
[ { "path": "Gruntfile.js", "patch": "@@ -179,7 +179,13 @@ module.exports = function(grunt) {\n 'test:webdriver:phantomjs',\n 'coverage:parse'\n ]);\n- grunt.registerTask('test', ['build:test', 'build:basic', 'test:webdriver:phantomjs']);\n+ grunt.registerTask('test', function() {\n+ if (grunt....
2014-03-07T06:11:25
vercel/next.js
bcd0cb8948f1599e0d965494cabbaf681dbd76a6
21480779e00b0f765249730854f56796b8ee037c
fix branch name (#58132) fix the branch name of the workflow
[ { "path": ".github/workflows/update-turbopack-test-manifest.yml", "patch": "@@ -36,7 +36,7 @@ jobs:\n run: node scripts/automated-update-workflow.js\n env:\n GITHUB_TOKEN: ${{ secrets.GH_TOKEN_PULL_REQUESTS }}\n- BRANCH_NAME: fonts-data\n+ BRANCH_NAME: turbopack-m...
2023-11-14T10:23:02
nodejs/node
96faea137e7d591cab5fa15f4c5fd7cb28da35ee
d8a380e13665ef06ffbfa220cb3a7aaaaa17c9fd
http: expose http.validate-header-name/value The use-case is for any framework that provides user mw a response replacement, that collects the desired response state, and applies them only on conclusion. As such a framework, I'd want to validate the header names and values as soon as the user-code provides them. This ...
[ { "path": "doc/api/http.md", "patch": "@@ -2469,6 +2469,76 @@ events will be emitted in the following order:\n Setting the `timeout` option or using the `setTimeout()` function will\n not abort the request or do anything besides add a `'timeout'` event.\n \n+## `http.validateHeaderName(name)`\n+<!-- YAML\n+...
2020-04-28T09:30:20
golang/go
29e360274a3b73bb77633cf68897072e8240e367
9649a4119c7954618ea891e71c09cb51940f39a7
cmd/compile/internal/types2: use go/types/testdata/fixedbugs tests Since the fixedbugs tests are now identical between the two type checkers, remove the local copy of the fixedbugs tests and (for now) use the tests in go/types/testdata/fixedbugs instead. Eventually we may decide to move all tests out of the type check...
[ { "path": "src/cmd/compile/internal/types2/check_test.go", "patch": "@@ -301,9 +301,11 @@ func TestCheck(t *testing.T) {\n \tDefPredeclaredTestFuncs()\n \ttestDirFiles(t, \"../../../../go/types/testdata/check\", 55, false) // TODO(gri) narrow column tolerance\n }\n-func TestSpec(t *testing.T) { testDir...
2022-09-01T00:06:29
facebook/react
21e06196cd47e396b74119ad3e30fab9ead71482
af1b63456eef13c5957879bdcfecb6f97ffdffe1
Fix removing DOM property with mapped name
[ { "path": "src/browser/ui/dom/DOMPropertyOperations.js", "patch": "@@ -162,7 +162,7 @@ var DOMPropertyOperations = {\n var propName = DOMProperty.getPropertyName[name];\n var defaultValue = DOMProperty.getDefaultValueForProperty(\n node.nodeName,\n- name\n+ propNa...
2014-03-06T08:30:40
vercel/next.js
21480779e00b0f765249730854f56796b8ee037c
82821c7942c5a2e7e8902b4a084a0dfb40a09c2b
fix hmr event, and avoid RSC fetch on any message (#58403) ### What? notify `__NEXT_HMR_CB` only when the RSC HMR update rerendered ### Why? the event was too early
[ { "path": "packages/next/src/client/components/react-dev-overlay/hot-reloader-client.tsx", "patch": "@@ -338,14 +338,16 @@ function processMessage(\n })\n )\n \n- const isHotUpdate =\n- obj.action !== HMR_ACTIONS_SENT_TO_BROWSER.SYNC &&\n- (!window.__NEXT_DATA__ || window.__...
2023-11-14T10:22:17
nodejs/node
d8a380e13665ef06ffbfa220cb3a7aaaaa17c9fd
b8ed2a07d39785880647c2f4adfb95a7322600cb
zlib: reject windowBits=8 when mode=GZIP It's also handled in C++ land now, per the previous commit, but intercepting it in JS land makes for prettier error messages. PR-URL: https://github.com/nodejs/node/pull/33045 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.d...
[ { "path": "lib/zlib.js", "patch": "@@ -613,9 +613,11 @@ function Zlib(opts, mode) {\n mode === UNZIP)) {\n windowBits = 0;\n } else {\n+ // `{ windowBits: 8 }` is valid for deflate but not gzip.\n+ const min = Z_MIN_WINDOWBITS + (mode === GZIP ? 1 : 0);\n windowBits = chec...
2020-04-24T19:12:32
facebook/react
4b569475609cf882ebe4078a3e8867a8f1355bb5
554b677e60b3882fe26e086896767578f59484e8
included link to React devtools in tooling-integration. fixes #791
[ { "path": "docs/docs/08-tooling-integration.md", "patch": "@@ -48,3 +48,7 @@ The open-source community has built tools that integrate JSX with several build\n that support `*.tmLanguage`.\n * Linting provides accurate line numbers after compiling without sourcemaps.\n * Elements use standard scoping so ...
2014-03-06T21:00:48
golang/go
9649a4119c7954618ea891e71c09cb51940f39a7
1be8fcdcdce01ca7cffb1fd90c1cd706c3ea4ee4
go/types, types2: consolidate testdata/fixedbugs test files Use the go/types version of testdata/fixedbugs tests where diffs are only in the error positions (the types2 test harness allows for some position tolerance). Consolidate files where there are other minor differences. Add files to respective directories if t...
[ { "path": "src/cmd/compile/internal/types2/check_test.go", "patch": "@@ -303,7 +303,7 @@ func TestCheck(t *testing.T) {\n }\n func TestSpec(t *testing.T) { testDirFiles(t, \"../../../../go/types/testdata/spec\", 0, false) }\n func TestExamples(t *testing.T) { testDirFiles(t, \"../../../../go/types/tes...
2022-08-31T23:56:17
vercel/next.js
4fe968bb71d5e3f074297e8c6ee9131c1dc67eb7
dc59d3cca9e09e5386317217278dc9f116654cf4
Fix: expected "catch all routes" are not matched in “parallel routes" (#58368) <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you'r...
[ { "path": "packages/next/src/build/normalize-catchall-routes.ts", "patch": "@@ -12,15 +12,21 @@ export function normalizeCatchAllRoutes(\n normalizer = new AppPathnameNormalizer()\n ) {\n const catchAllRoutes = [\n- ...new Set(Object.values(appPaths).flat().filter(isCatchAllRoute)),\n+ ...new Set(...
2023-11-13T22:26:45
facebook/react
aa70419f9da827683954a6562104cc9ebfbde7ab
7d0e6c6c0b9e97067b941a376c194479b3c867b9
Fix empty JSX expressions sometimes emitting erroneous commas
[ { "path": "vendor/fbtransform/transforms/react.js", "patch": "@@ -130,7 +130,9 @@ function visitReactTag(traverse, object, path, state) {\n var childrenToRender = object.children.filter(function(child) {\n return !(child.type === Syntax.Literal\n && typeof child.value === 'string'\n- ...
2014-03-05T10:12:56
nodejs/node
b8ed2a07d39785880647c2f4adfb95a7322600cb
3226731dec5a82fc2276b571e8c4024b6154de1e
src: fix invalid windowBits=8 gzip segfault `{ windowBits: 8 }` is legal for deflate streams but not gzip streams. Fix a nullptr dereference when formatting the error message. Bug introduced in commit c34eae5f88 ("zlib: refactor zlib internals") from September 2018. PR-URL: https://github.com/nodejs/node/pull/33045 ...
[ { "path": "src/node_zlib.cc", "patch": "@@ -111,7 +111,12 @@ enum node_zlib_mode {\n \n struct CompressionError {\n CompressionError(const char* message, const char* code, int err)\n- : message(message), code(code), err(err) {}\n+ : message(message),\n+ code(code),\n+ err(err) {\n+ ...
2020-04-24T19:12:32
golang/go
1be8fcdcdce01ca7cffb1fd90c1cd706c3ea4ee4
d98bf7d0151c3feeceba6348519bb5c16e8ddc3f
cmd/compile/internal/syntax: more strict parsing of type instances Report a syntax error if the first element of a type instance is not actually a type (but some other expression), rather then relying on the type checker error in this case. This matches the behavior of go/parser. Adjust the corresponding types2 test c...
[ { "path": "src/cmd/compile/internal/syntax/parser.go", "patch": "@@ -1117,7 +1117,7 @@ loop:\n \t\t\t\t\tp.syntaxError(\"expected operand\")\n \t\t\t\t\ti = p.badExpr()\n \t\t\t\t} else {\n-\t\t\t\t\ti, comma = p.typeList()\n+\t\t\t\t\ti, comma = p.typeList(false)\n \t\t\t\t}\n \t\t\t\tif comma || p.tok == ...
2022-08-31T22:54:28
vercel/next.js
dc59d3cca9e09e5386317217278dc9f116654cf4
1eee93cc94255ed17d853f64904752d4c840a9b1
Update CLI version for deploy examples job (#58318) Fixes: https://github.com/vercel/next.js/actions/runs/6830557044/job/18578715963
[ { "path": ".github/workflows/build_and_deploy.yml", "patch": "@@ -450,7 +450,7 @@ jobs:\n with:\n fetch-depth: 25\n - name: Install Vercel CLI\n- run: npm i -g vercel@28.16.15\n+ run: npm i -g vercel@latest\n - name: Deploy preview examples\n if: ${{ needs...
2023-11-13T19:36:51
nodejs/node
3226731dec5a82fc2276b571e8c4024b6154de1e
13c5a1629cd025ba560f34f6d3190b2f38d184d4
meta: add issue template for API reference docs Prior to this commit, there was no GitHub issue template guiding users to open issues about gaps in the API reference docs. Refs: https://github.com/nodejs/node/pull/31123 PR-URL: https://github.com/nodejs/node/pull/32944 Fixes: https://github.com/nodejs/nodejs.org/issu...
[ { "path": ".github/ISSUE_TEMPLATE/3-api-ref-docs-problem.md", "patch": "@@ -0,0 +1,54 @@\n+---\n+name: \"\\U0001F4D7 Open an issue regarding the Node.js API reference docs\"\n+about: Let us know about any problematic API reference documents\n+title: \"doc: \"\n+labels: doc\n+---\n+\n+# 📗 API Reference Docs...
2020-04-20T13:56:25
golang/go
d98bf7d0151c3feeceba6348519bb5c16e8ddc3f
4e32472e79e393675ba8489968539db5dc0ab650
go/types, types2: consolidate testdata/fixedbugs/issue46404.go Rename .../issue46404.go1 to .../issue46404.go so that it is not skipped anymore when running tests, and copy for types2. Disable the code for now due to a difference in error reporting due to the slightly different handling of index expressions. This all...
[ { "path": "src/cmd/compile/internal/types2/testdata/fixedbugs/issue46404.go", "patch": "@@ -4,5 +4,7 @@\n \n package issue46404\n \n+// TODO(gri) re-enable this test with matching errors\n+// between go/types and types2\n // Check that we don't type check t[_] as an instantiation.\n-type t [t /* E...
2022-08-31T22:05:23
rust-lang/rust
538299a6f5fb34239bd4992786a19e5bd728737c
3b52678b5f077442ff82d51448c0a00d4c5aa623
fix grammar
[ { "path": "src/doc/rustc-dev-guide/src/git.md", "patch": "@@ -344,7 +344,7 @@ Here is some general advice about how to keep your local repo\n up-to-date with upstream changes:\n \n Using `git pull upstream master` while on your local master branch regularly\n-will keep it up-to-date. You will also want to r...
2025-08-11T07:20:01
electron/electron
4e1b237649ab47be976d7df6598f63f32b207c19
79346f1ac56c4cb7837947ce1025db47d6550036
Fix translation error
[ { "path": "docs-translations/zh-CN/tutorial/electron-versioning.md", "patch": "@@ -5,7 +5,7 @@\n 版本号使用参照以下规则:\n \n * 主要版本: 适用于 Electron API 的突破性变更 - 如果您从 `0.37.0` 升级到 `1.0.0`, 您将需要升级您的应用程序。\n-* 次要版本: 适用于 Chrome 主要版本 和 Node 次要版本升级; 或重大的 Electron 变动 - 如果您从 `0.37.0` 升级到 `1.0.0`, 您的应用程序仍然可以正常运行, 但你可能需要解决一些小幅的变动...
2017-03-26T23:42:07
vercel/next.js
c030631948f3e088d1698d03125f56183f4d54ae
a21180f5e8f24375465d4e79d9b2fdaa5300a0fd
fix encoding of chunks, fix chunk (re)loading for css (vercel/turbo#6424) ### Description We need to be consistent with url encoding Look for existing link tags when loading CSS allow querystring when detection existing chunks ### Testing Instructions <!-- Give a quick description of steps to test your c...
[ { "path": "crates/turbopack-ecmascript-runtime/js/src/dev/runtime/base/runtime-base.ts", "patch": "@@ -1290,7 +1290,10 @@ function getOrInstantiateRuntimeModule(\n * Returns the URL relative to the origin where a chunk can be fetched from.\n */\n function getChunkRelativeUrl(chunkPath: ChunkPath): string ...
2023-11-13T16:57:31
rust-lang/rust
a43e386280f5fe5e49210cdb6db169d62eaa0733
7dd3ecb1f94efe8539d4ec34187c4c65be1225a5
Adjust `declare_interior_mutable_const` lint's category Per the root readme, `clippy::style` is a category with > code that should be written in a more idiomatic way description. The code this lint guards from may be much worse than badly styled: ```rs use std::sync::LazyLock; // `const` instead of `static` cause...
[ { "path": "clippy_lints/src/non_copy_const.rs", "patch": "@@ -92,7 +92,7 @@ declare_clippy_lint! {\n /// ```\n #[clippy::version = \"pre 1.29.0\"]\n pub DECLARE_INTERIOR_MUTABLE_CONST,\n- style,\n+ suspicious,\n \"declaring `const` with interior mutability\"\n }\n ", "additions": 1...
2025-08-11T07:11:41
nodejs/node
2c3c9f5a3f6d54230dcc65efacb5b57d0979b462
d005f490a8de7c4136acdb4d1cd1dc2a7b5e3535
module: better error for named exports from cjs We do not support importing named exports from a CJS module. This change decorates the error message for missing named exports in the case where the module being imported is expected to be CJS by the ESM loader. Signed-off-by: Myles Borins <myles.borins@gmail.com> PR-U...
[ { "path": "lib/internal/modules/esm/module_job.js", "patch": "@@ -1,10 +1,14 @@\n 'use strict';\n \n const {\n+ ArrayPrototypeJoin,\n ObjectSetPrototypeOf,\n PromiseAll,\n SafeSet,\n SafePromise,\n+ StringPrototypeIncludes,\n+ StringPrototypeMatch,\n+ StringPrototypeSplit,\n } = primordials;\n \...
2020-05-05T20:16:13
golang/go
4e32472e79e393675ba8489968539db5dc0ab650
d394f99f49aa9249324f7c3ef3bc77a7cc1cebf7
go/parser: match syntax parser error for unnamed type parameters For #54511. Change-Id: I1ae391b5f157bf688f9f31b1577c90e681b6df26 Reviewed-on: https://go-review.googlesource.com/c/go/+/426655 Reviewed-by: Robert Griesemer <gri@google.com> Run-TryBot: Robert Griesemer <gri@google.com> Reviewed-by: Robert Findley <rfin...
[ { "path": "src/go/parser/parser.go", "patch": "@@ -897,7 +897,7 @@ func (p *parser) parseParameterList(name0 *ast.Ident, typ0 ast.Expr, closing tok\n \t\t\t}\n \t\t}\n \t\tif tparams {\n-\t\t\tp.error(pos, \"all type parameters must be named\")\n+\t\t\tp.error(pos, \"type parameters must be named\")\n \t\t}...
2022-08-31T21:23:07
vercel/next.js
1eee93cc94255ed17d853f64904752d4c840a9b1
797fecb0c642be9db0d7586bcc54b4a2fe3b7653
Update 08-parallel-routes.mdx (#58393) Fixed Typo <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contri...
[ { "path": "docs/02-app/01-building-your-application/01-routing/08-parallel-routes.mdx", "patch": "@@ -115,7 +115,7 @@ On reload, Next.js will first try to render the unmatched slot's `default.js` fi\n \n ## `useSelectedLayoutSegment(s)`\n \n-Both [`useSelectedLayoutSegment`](/docs/app/api-reference/function...
2023-11-13T16:55:28
nodejs/node
bcdbd57134558e3bea730f8963881e8865040f6f
fdfb98b61987679c24700bcfbc5710f651b89332
wasi: fix poll_oneoff memory interface The WASM memory interfacing logic was wrong (particularly around the size of __wasi_subscription_t). This commit fixes the logic. PR-URL: https://github.com/nodejs/node/pull/33250 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
[ { "path": "src/node_wasi.cc", "patch": "@@ -1456,21 +1456,21 @@ void WASI::PollOneoff(const FunctionCallbackInfo<Value>& args) {\n }\n \n for (uint32_t i = 0; i < nsubscriptions; ++i) {\n- uvwasi_subscription_t sub = in[i];\n- wasi->readUInt64(memory, &sub.userdata, in_ptr);\n- wasi->readUInt8(...
2020-05-05T14:09:39
golang/go
a31c062c9fbf212b244fbece6295a2a4279459e0
042f051c03d35fb0adcb0b6a7e2d78a35342ae98
go/parser: parse import specs the same way as the syntax parser This results in better error recovery and allows us to use the same tests for go/types and types2. For #54511. Change-Id: Ic11a9dafb8c62e0cb952b3924d55a28b438241c6 Reviewed-on: https://go-review.googlesource.com/c/go/+/427154 Run-TryBot: Robert Grieseme...
[ { "path": "src/go/parser/parser.go", "patch": "@@ -2425,20 +2425,27 @@ func (p *parser) parseImportSpec(doc *ast.CommentGroup, _ token.Pos, _ token.Tok\n \n \tvar ident *ast.Ident\n \tswitch p.tok {\n+\tcase token.IDENT:\n+\t\tident = p.parseIdent()\n \tcase token.PERIOD:\n \t\tident = &ast.Ident{NamePos: p...
2022-08-31T18:26:43
vercel/next.js
76da32e43fc5aafc9787f53a772458e828febbcd
2e82ca81114f40c12dcdff52c0b264d46f29fc5f
fix(WellKnownErrorsPlugin): avoid compilation warnings array with empty items (#57768) Currently, when a webpack compilation warning is processed by `WellKnownErrorsPlugin` and it's indeed a well know error that should be bypassed, the warning item is simply deleted from the array, which will produce an array with ...
[ { "path": "packages/next/src/build/webpack/plugins/wellknown-errors-plugin/index.ts", "patch": "@@ -14,7 +14,7 @@ export class WellKnownErrorsPlugin {\n warn.name === 'ModuleDependencyWarning' &&\n warn.module.context?.includes('node_modules')\n ) {\n- ...
2023-11-13T11:48:44
nodejs/node
fdfb98b61987679c24700bcfbc5710f651b89332
d135b508e907585bfe699e4edbe2c3c6d1785dcd
src: clean up large pages code * Initialize structure members. * Factor out common `Debug()` prefix. * Remove unused `text_region` field. Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com> PR-URL: https://github.com/nodejs/node/pull/33255 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Anna Hen...
[ { "path": "src/large_pages/node_large_page.cc", "patch": "@@ -106,18 +106,18 @@ namespace node {\n namespace {\n \n struct text_region {\n- char* from;\n- char* to;\n- int total_hugepages;\n- bool found_text_region;\n+ char* from = nullptr;\n+ char* to = nullptr;\n+ bool found_text_region = false;...
2020-05-05T18:24:43
facebook/react
9c87aef67f874afc24b3ebaa6f9b71f5fb85dc9b
1d27770b406c950af1ba6275f4625c1a9a6c8671
Fix stale usage of emptyObject in cloneWithProps-test. After we run `require('mock-modules').dumpCache()`, the object exported by the `emptyObject` module will no longer be identical to previously exported objects, so tests like `expect(component.refs).toBe(emptyObject)` will fail. Note that this behavior only manife...
[ { "path": "src/utils/__tests__/cloneWithProps-test.js", "patch": "@@ -24,19 +24,20 @@ require('mock-modules').dontMock('cloneWithProps');\n var mocks = require('mocks');\n \n var cloneWithProps = require('cloneWithProps');\n-var emptyObject = require('emptyObject');\n \n var React;\n var ReactTestUtils;\n \...
2014-03-04T17:59:55
vercel/next.js
2e82ca81114f40c12dcdff52c0b264d46f29fc5f
a01beafddd291936395c167c7c3a263486e2e4a3
fix: import antd from es in modularizeImports (#57968) ### Fixing a bug Currently any imports from antd will be replaced with `lib`, which will cause context not the same. Ref: https://github.com/ant-design/ant-design/issues/45567
[ { "path": "packages/next/src/server/config.ts", "patch": "@@ -792,7 +792,7 @@ function assignDefaults(\n },\n },\n antd: {\n- transform: 'antd/lib/{{kebabCase member}}',\n+ transform: 'antd/es/{{kebabCase member}}',\n },\n ahooks: {\n transform: {", "additions": 1, ...
2023-11-13T03:31:29
golang/go
042f051c03d35fb0adcb0b6a7e2d78a35342ae98
cb357835d9c62232e70f7bf0eb7b105a2901bd1a
go/types, types2: consolidate a test file with different syntax errors For #54511. Change-Id: I317c5f9beed7f1de4979ec12c6ec8d5de71bac1c Reviewed-on: https://go-review.googlesource.com/c/go/+/426554 Reviewed-by: Robert Findley <rfindley@google.com> Run-TryBot: Robert Griesemer <gri@google.com> TryBot-Result: Gopher Ro...
[ { "path": "src/cmd/compile/internal/types2/testdata/fixedbugs/issue51658.go", "patch": "@@ -2,21 +2,25 @@\n // Use of this source code is governed by a BSD-style\n // license that can be found in the LICENSE file.\n \n+// This test checks syntax errors which differ between\n+// go/parser and the syntax pack...
2022-08-30T00:27:22
electron/electron
aa5c778ca23182085c331e098175c5c13ac3dec9
d95114016dea559872a06fb2fcedfaa564f66b63
Generic doc fixes
[ { "path": "docs/api/client-request.md", "patch": "@@ -65,6 +65,8 @@ Returns:\n * `port` Integer\n * `realm` String\n * `callback` Function\n+ * `username` String\n+ * `password` String\n \n Emitted when an authenticating proxy is asking for user credentials.\n ", "additions": 2, "deletions": 0...
2017-03-25T01:37:07
facebook/react
c3cfcf073dab2e6fff1ebf32ef2bbacc37a57992
1d27770b406c950af1ba6275f4625c1a9a6c8671
Remove custom attrs properly when setting to null I don't think this particular codepath was exercised at all (because all the callers call deleteValueForProperty) but this fixes a bug here nonetheless.
[ { "path": "src/browser/ui/dom/DOMPropertyOperations.js", "patch": "@@ -136,7 +136,7 @@ var DOMPropertyOperations = {\n }\n } else if (DOMProperty.isCustomAttribute(name)) {\n if (value == null) {\n- node.removeAttribute(DOMProperty.getAttributeName[name]);\n+ node.removeAttribu...
2014-02-27T05:32:20
nodejs/node
d135b508e907585bfe699e4edbe2c3c6d1785dcd
ab22d2cdcbf5fa193a5e237200dd3e17c7084b49
doc: correct description of `decipher.setAuthTag` in crypto.md Calling `decipher.setAuthTag` after `decipher.update` will result in an error like `Unsupported state or unable to authenticate data`. The example code in [CCM mode](https://nodejs.org/docs/latest-v14.x/api/crypto.html#crypto_ccm_mode) is correct, but to d...
[ { "path": "doc/api/crypto.md", "patch": "@@ -520,8 +520,9 @@ cipher text should be discarded due to failed authentication. If the tag length\n is invalid according to [NIST SP 800-38D][] or does not match the value of the\n `authTagLength` option, `decipher.setAuthTag()` will throw an error.\n \n-The `decip...
2020-04-27T16:19:30
golang/go
cb357835d9c62232e70f7bf0eb7b105a2901bd1a
6b555dc29e98ca756eb3f10edc4b8a17a72b1258
cmd/compile/internal/types2: match go/types error for invalid instantiations Also: add a missing test. For #54511. Change-Id: Ie9828c6ba5186feb5a79db0d58beb2cda2beae56 Reviewed-on: https://go-review.googlesource.com/c/go/+/426478 Reviewed-by: Robert Findley <rfindley@google.com> Reviewed-by: Robert Griesemer <gri@go...
[ { "path": "src/cmd/compile/internal/types2/signature.go", "patch": "@@ -130,7 +130,7 @@ func (check *Checker) funcType(sig *Signature, recvPar *syntax.Field, tparams []\n \t\t\t\t// Also: Don't report an error via genericType since it will be reported\n \t\t\t\t// again when we type-check the signatur...
2022-08-29T23:40:31
vercel/next.js
44ec398d4b9c9a01e2af8e7c97e345387f5a56ff
022cb256409b054a51a641928a6b93650137e494
chore(docs): fix typo (#58344) Fix typo in markdown link in "Environment variables" docs article <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the...
[ { "path": "docs/02-app/01-building-your-application/07-configuring/03-environment-variables.mdx", "patch": "@@ -158,7 +158,7 @@ export default function Component() {\n \n **Good to know:**\n \n-- You can run code on server startup using the `[register` function](/docs/app/building-your-application/optimizin...
2023-11-12T18:15:21
facebook/react
1d27770b406c950af1ba6275f4625c1a9a6c8671
4c4446d283552f9280305eaeda26be97680ff454
Fix verion-check to look in right place for React.js
[ { "path": "grunt/tasks/version-check.js", "patch": "@@ -10,7 +10,7 @@ var reactVersionExp = /\\bReact\\.version\\s*=\\s*['\"]([^'\"]+)['\"];/;\n \n module.exports = function() {\n var reactVersion = reactVersionExp.exec(\n- grunt.file.read('./src/browser/React.js')\n+ grunt.file.read('./src/browser/...
2014-03-03T23:34:37
electron/electron
d95114016dea559872a06fb2fcedfaa564f66b63
32f278d92bfbd03c3acf2092a572842ef1fb344d
V8 dev resources (#9008) * Adding V8 documentation links * Removing extra space * use electron markdown conventions * cross-link v8 and chromium dev docs * fix v8 link
[ { "path": "docs/README.md", "patch": "@@ -105,3 +105,4 @@ an issue:\n * [Documentation Styleguide](styleguide.md)\n * [Updating Chrome](development/updating-chrome.md)\n * [Chromium Development](development/chromium-development.md)\n+* [V8 Development](development/v8-development.md)", "additions": 1, ...
2017-03-24T22:40:23
nodejs/node
df8db42082cd81f4c9f94a1d51fb99652a2dd438
4d4e3c3674b4f52ce9b59fecdf1f8d5f75112d59
test: skip some console tests on dumb terminal Add capabilities to common test module to detect and skip tests on dumb terminals. In some of our build environments, like s390x, the terminal is a dumb terminal meaning it has very rudimentary capabilities. These in turn prevent some of the tests from completing with er...
[ { "path": "test/common/README.md", "patch": "@@ -223,6 +223,10 @@ Platform check for Advanced Interactive eXecutive (AIX).\n \n Attempts to 'kill' `pid`\n \n+### `isDumbTerminal`\n+\n+* [&lt;boolean>][]\n+\n ### `isFreeBSD`\n \n * [&lt;boolean>][]\n@@ -385,6 +389,10 @@ will not be run.\n \n Logs '1..0 # Ski...
2020-04-30T10:42:34
facebook/react
3fe9f9f336255bcf67f5a6551317545d35b4b283
e39c19423a6daff70f33d268e0cccd9d33d50dc1
Fix ReactPropTypesTest children should never be defined as propType, so changing the test to use an actual prop.
[ { "path": "src/core/__tests__/ReactPropTypes-test.js", "patch": "@@ -445,36 +445,23 @@ describe('Component Type', function() {\n \n var Component = React.createClass({\n propTypes: {\n- children: Props.component.isRequired\n+ label: Props.component.isRequired\n },\n \n render: functi...
2014-03-03T17:38:48
vercel/next.js
022cb256409b054a51a641928a6b93650137e494
a794e1f32e3e3ab720608ca4e65973635e7f8748
fix(eslint): `next/script` `beforeInteractive` gives warning on appDir (#51148) ## Issue The `context.getFilename()` gets the absolute path of the files, and the if statement to filter `/src` and `/app` was not working since #46609. ## Expected Do not show a lint warning if use `beforeInteractive` inside `appDir`....
[ { "path": "packages/eslint-plugin-next/src/rules/no-before-interactive-script-outside-document.ts", "patch": "@@ -4,10 +4,8 @@ import * as path from 'path'\n const url =\n 'https://nextjs.org/docs/messages/no-before-interactive-script-outside-document'\n \n-const startsWithUsingCorrectSeparators = (str: s...
2023-11-12T09:30:10
golang/go
6b555dc29e98ca756eb3f10edc4b8a17a72b1258
0592ce5f69f4149da643b61e6bb1163e6046401c
go/types: use singular in version error messages This matches the majority use case as well as types2. For #54511. Change-Id: If800afc35db8d32cca8329ed9d6a80b4a15c4878 Reviewed-on: https://go-review.googlesource.com/c/go/+/426477 Reviewed-by: Robert Griesemer <gri@google.com> TryBot-Result: Gopher Robot <gobot@golan...
[ { "path": "src/go/types/resolver.go", "patch": "@@ -383,7 +383,7 @@ func (check *Checker) collectObjects() {\n \t\t\t\t}\n \t\t\tcase typeDecl:\n \t\t\t\tif d.spec.TypeParams.NumFields() != 0 && !check.allowVersion(pkg, 1, 18) {\n-\t\t\t\t\tcheck.softErrorf(d.spec.TypeParams.List[0], _UnsupportedFeature, \"...
2022-08-29T23:10:03
electron/electron
095df457b23a0308ba14c08c0de6e5da6c458008
46aed5ff6f4f2e27222dc197f67c48106cf817c8
fix docs for thumbnailSize
[ { "path": "docs/api/desktop-capturer.md", "patch": "@@ -60,8 +60,9 @@ The `desktopCapturer` module has the following methods:\n * `options` Object\n * `types` String[] - An array of Strings that lists the types of desktop sources\n to be captured, available types are `screen` and `window`.\n- * `thum...
2017-03-24T18:14:43
nodejs/node
4d4e3c3674b4f52ce9b59fecdf1f8d5f75112d59
d6913dc1f0ce8318b35b8a71e422f01993ad78c4
lib: fix grammar in internal/bootstrap/loaders.js PR-URL: https://github.com/nodejs/node/pull/33211 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
[ { "path": "lib/internal/bootstrap/node.js", "patch": "@@ -7,7 +7,7 @@\n // This file is expected not to perform any asynchronous operations itself\n // when being executed - those should be done in either\n // `lib/internal/bootstrap/pre_execution.js` or in main scripts. The majority\n-// of the code here f...
2020-05-02T13:45:54
facebook/react
6203e53d16be80db5661f5bd51947fec0dc083fb
88a4a566aeff77c9fe1997825e32f5755870dd0d
Fix IE8 disabled input throwing on focus When IE8 focuses a disabled item, it throws This makes sure the we're not focusing the item during selection restoration/autofocus when the element's disabled.
[ { "path": "src/browser/ReactInputSelection.js", "patch": "@@ -21,6 +21,7 @@\n var ReactDOMSelection = require('ReactDOMSelection');\n \n var containsNode = require('containsNode');\n+var focusNode = require('focusNode');\n var getActiveElement = require('getActiveElement');\n \n function isInDocument(node) ...
2014-03-03T17:36:58
golang/go
b2110bcdde636b77412778a8c1eab6e50163ca1c
1280ae7856d5226a7a4135621a6292240faa7657
types2: use strings.Builder in errors.go Permissible now because go1.17 is used for bootstrapping. Change-Id: Ia6f314f9314eda1cc42002dcbdfa551196df76f0 Reviewed-on: https://go-review.googlesource.com/c/go/+/427554 TryBot-Result: Gopher Robot <gobot@golang.org> Auto-Submit: Robert Griesemer <gri@google.com> Reviewed-b...
[ { "path": "src/cmd/compile/internal/types2/errors.go", "patch": "@@ -300,8 +300,7 @@ func posFor(at poser) syntax.Pos {\n \n // stripAnnotations removes internal (type) annotations from s.\n func stripAnnotations(s string) string {\n-\t// Would like to use strings.Builder but it's not available in Go 1.4.\n...
2022-09-01T13:40:08
vercel/next.js
b425b40aac9e627a9d9adf56e914ff14cb96ced4
00f5b5e789feec3683dace078493b0d1dd44eba7
Replace custom Thenable type with native Promises (#58337) Next.js's implementation includes a custom Thenable type based on a similar one used in React's codebase. It was used to implement a userspace equivalent of the React.use API before that API became stable, by throwing a promise-like object and tracking the ...
[ { "path": "packages/next/src/client/components/layout-router.tsx", "patch": "@@ -27,7 +27,6 @@ import { RedirectBoundary } from './redirect-boundary'\n import { NotFoundBoundary } from './not-found-boundary'\n import { getSegmentValue } from './router-reducer/reducers/get-segment-value'\n import { createRou...
2023-11-12T07:45:43
electron/electron
21956071e63013788b7aa2294ee20e79f202ebcd
49ef4e326f602564e9d1b2c10075b5284ffbce81
Fix compilation issue
[ { "path": "brightray/browser/views/inspectable_web_contents_view_views.cc", "patch": "@@ -173,7 +173,7 @@ void InspectableWebContentsViewViews::SetIsDocked(bool docked) {\n devtools_window_web_view_ = new views::WebView(NULL);\n devtools_window_delegate_ = new DevToolsWindowDelegate(\n this,...
2017-03-24T16:52:37
rust-lang/rust
6dcc8617d342d7e3a007c4e57e64ee06a07fb707
18eeac04fc5c2a4c4a8020dbdf1c652077ad0e4e
Fix doc-comment.
[ { "path": "compiler/rustc_span/src/span_encoding.rs", "patch": "@@ -74,9 +74,8 @@ use crate::{BytePos, SPAN_TRACK, SpanData};\n /// because `parent` isn't currently used by default.\n ///\n /// In order to reliably use parented spans in incremental compilation,\n-/// the dependency to the parent definitio...
2025-08-04T23:36:05
nodejs/node
3f1e65dd7be9c55a879ec9d7190de5c7401c66e0
5424f1b8443c639145fb9d8c76d6d8358a2c1fd8
doc: fix md issue in src/README.md PR-URL: https://github.com/nodejs/node/pull/33224 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
[ { "path": "src/README.md", "patch": "@@ -395,7 +395,7 @@ void Initialize(Local<Object> target,\n NODE_MODULE_CONTEXT_AWARE_INTERNAL(cares_wrap, Initialize)\n ```\n \n-<a id=\"per-binding-state\">\n+<a id=\"per-binding-state\"></a>\n #### Per-binding state\n \n Some internal bindings, such as the HTTP parser...
2020-05-03T23:43:52
facebook/react
2f6656e3e9512c0e547828f73c3cadf5dfadcabc
a0ecf472421937545ff5843b5fee6ba5e6991685
fix
[ { "path": "docs/docs/examples.md", "patch": "@@ -13,7 +13,7 @@ prev: complementary-tools.html\n * **[Khan Academy](http://khanacademy.org/)** uses React for most new JS development.\n * **[Shirtstarter](https://www.shirtstarter.com/)** is 100% built on React.\n * **[Sberbank](http://sberbank.ru/moscow/ru/pe...
2014-03-03T18:39:41
vercel/next.js
d1fe4d01c42c64154022a3156ea1b2ebe5fc4d54
ff257800fc94e97c5c6c41c49a8424b741497ebc
[Docs] remove example for router.events as it does not exist (#58286) Removed router.events example from the document because it does not exist. URL: https://nextjs.org/docs/pages/api-reference/functions/use-router#routerevents <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure ...
[ { "path": "docs/03-pages/02-api-reference/02-functions/use-router.mdx", "patch": "@@ -360,13 +360,6 @@ export default function Page() {\n \n ### router.events\n \n-<details>\n- <summary>Examples</summary>\n-\n-- [With a page loading indicator](https://github.com/vercel/next.js/tree/canary/examples/with-loa...
2023-11-10T15:21:26
golang/go
1280ae7856d5226a7a4135621a6292240faa7657
a74d46d8ff44abe409282bf1a9a9ab1b0b2cdaa0
go/parser: leave checking of LHS in short var decls to type checker Instead of checking at parse-time that the LHS of a short variable declaration contains only identifiers, leave the check to the the type checker which tests this already. This removes a duplicate error and matches the behavior of the syntax package....
[ { "path": "src/cmd/compile/internal/syntax/parser.go", "patch": "@@ -2487,8 +2487,6 @@ func (p *parser) commClause() *CommClause {\n \t\t//\n \t\t// All these (and more) are recognized by simpleStmt and invalid\n \t\t// syntax trees are flagged later, during type checking.\n-\t\t// TODO(gri) eventually may ...
2022-08-29T22:45:35
electron/electron
6a7b4feb35ad46b71aea0ffd74c91d248660269e
9e471d8f1cce79626491cea4be21be3b30cd6c2e
Fixed for linting
[ { "path": "spec/api-menu-spec.js", "patch": "@@ -455,8 +455,8 @@ describe('menu module', function () {\n })\n })\n \n- describe('MenuItem editMenu', function() {\n- it('includes a default submenu layout when submenu is empty', function() {\n+ describe('MenuItem editMenu', function () {\n+ it('...
2017-03-24T11:31:49
rust-lang/rust
00d000ce74f8e3bed8abc4cff382f62dcca0d8d5
802fa9255b59c8787d679f5da1f5534f9c0580b0
Fix minor things
[ { "path": "src/tools/rust-analyzer/crates/ide/src/file_structure.rs", "patch": "@@ -213,7 +213,6 @@ fn structure_node(node: &SyntaxNode, config: &FileStructureConfig) -> Option<Str\n detail: it.ty().map(|ty| ty.to_string()),\n deprecated: false,\n };\n...
2025-08-10T15:02:34
facebook/react
6b78cfb0f405433bccb909de48a1751ad5ac239e
237adacc3ad435ffc531a35193f88871339b100c
Fix docstring typo for pure render mixin
[ { "path": "src/addons/ReactComponentWithPureRenderMixin.js", "patch": "@@ -29,7 +29,7 @@ var shallowEqual = require('shallowEqual');\n *\n * Example:\n *\n- * var ReactComponentWithPureRender =\n+ * var ReactComponentWithPureRenderMixin =\n * require('ReactComponentWithPureRenderMixin');\n * ...
2014-03-02T22:18:10
nodejs/node
8607f9ec5c2a488f5df7f9eb3e5f5c7dfa0b492a
3662b0c2c75b670599c363be8322064a3359e432
stream: make from read one at a time Currently from will eagerly buffer up items which means that errors are also eagerly encountered and items which are buffer when an error occurs will be discarded, which is inconsistent with how generators work. Fixes: https://github.com/nodejs/node/issues/29428 PR-URL: https://g...
[ { "path": "lib/internal/streams/from.js", "patch": "@@ -33,6 +33,8 @@ function from(Readable, iterable, opts) {\n \n const readable = new Readable({\n objectMode: true,\n+ highWaterMark: 1,\n+ // TODO(ronag): What options should be allowed?\n ...opts\n });\n ", "additions": 2, "del...
2020-05-01T21:02:42
golang/go
a74d46d8ff44abe409282bf1a9a9ab1b0b2cdaa0
489f508ccfb7f0648852e0fea882b204a5776573
go/parser: check that go/defer expressions are not parenthesized Logic matches the code in the syntax package. This error was missing from go/parser and go/types. Added some tests. For #54511. Change-Id: I418de4bd4c7169457b424366caae70227a92a761 Reviewed-on: https://go-review.googlesource.com/c/go/+/425795 Auto-Subm...
[ { "path": "src/go/parser/parser.go", "patch": "@@ -1928,6 +1928,10 @@ func (p *parser) checkAssignStmt(as *ast.AssignStmt) {\n \n func (p *parser) parseCallExpr(callType string) *ast.CallExpr {\n \tx := p.parseRhs() // could be a conversion: (some type)(x)\n+\tif t := unparen(x); t != x {\n+\t\tp.error(x.Po...
2022-08-26T04:10:36
vercel/next.js
ff257800fc94e97c5c6c41c49a8424b741497ebc
e50782829b8167b0d85abcbc29291239c9e703de
Remove copying of request headers to response (#58304) <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Cont...
[ { "path": "examples/with-strict-csp/middleware.js", "patch": "@@ -28,7 +28,6 @@ export function middleware(request) {\n )\n \n const response = NextResponse.next({\n- headers: requestHeaders,\n request: {\n headers: requestHeaders,\n },", "additions": 0, "deletions": 1, "lan...
2023-11-10T15:14:54
electron/electron
be0c0e278a36487fd991ef9678c60235c975d246
1d42073ceb493f2c592d1e461f57dad70a58cb14
Remove cpplint errors
[ { "path": "brightray/browser/linux/libnotify_loader.h", "patch": "@@ -4,10 +4,10 @@\n #ifndef BRIGHTRAY_BROWSER_LINUX_LIBNOTIFY_LOADER_H_\n #define BRIGHTRAY_BROWSER_LINUX_LIBNOTIFY_LOADER_H_\n \n-#include <string>\n-\n #include <libnotify/notify.h>\n \n+#include <string>\n+\n class LibNotifyLoader {\n pub...
2017-03-23T19:48:22
rust-lang/rust
e9609abda42e8d88cf1f07946362cd81516792da
18eeac04fc5c2a4c4a8020dbdf1c652077ad0e4e
Account for macros when trying to point at inference cause Do not point at macro invocation which expands to an inference error. Avoid the following: ``` error[E0308]: mismatched types --> $DIR/does-not-have-iter-interpolated.rs:12:5 | LL | quote!($($nonrep)*); | ^^^^^^^^^^^^^^^^^^^ | | | ...
[ { "path": "compiler/rustc_hir_typeck/src/demand.rs", "patch": "@@ -698,7 +698,7 @@ impl<'a, 'tcx> FnCtxt<'a, 'tcx> {\n ) {\n match (self.tcx.parent_hir_node(expr.hir_id), error) {\n (hir::Node::LetStmt(hir::LetStmt { ty: Some(ty), init: Some(init), .. }), _)\n- if init...
2025-08-10T21:47:52
facebook/react
42444f6bb9a001096cfd95306a1e720eb1ed537e
298a05517e71e9f18ad55f906e020e1272ac30b9
Add polygon tag to transform Fixes #1144.
[ { "path": "vendor/fbtransform/transforms/xjs.js", "patch": "@@ -106,6 +106,7 @@ var knownTags = {\n p: true,\n param: true,\n path: true,\n+ polygon: true,\n polyline: true,\n pre: true,\n progress: true,", "additions": 1, "deletions": 0, "language": "JavaScript" } ]
2014-02-27T20:31:56
nodejs/node
3662b0c2c75b670599c363be8322064a3359e432
548439a530c797eb1be877978d5a03f1ee90bc7c
doc: update napi_async_init documentation Fixes: https://github.com/nodejs/node/issues/33153 Change documentation to make async_resource required as opposed to optional in napi-async_init. Changes over time mean this parameter is required for proper operation of async hooks (which are still experimental). This chang...
[ { "path": "doc/api/n-api.md", "patch": "@@ -4672,8 +4672,13 @@ napi_status napi_async_init(napi_env env,\n ```\n \n * `[in] env`: The environment that the API is invoked under.\n-* `[in] async_resource`: An optional object associated with the async work\n+* `[in] async_resource`: Object associated with the ...
2020-04-30T22:47:10
golang/go
489f508ccfb7f0648852e0fea882b204a5776573
330282a3a96099894ac0b6daceee19a483c12bbd
cmd/compile: avoid "not used" errors due to bad go/defer statements The syntax for go and defer specifies an arbitrary expression, not a call; the call requirement is spelled out in prose. Don't to the call check in the parser; instead move it to the type checker. This is simpler and also allows the type checker to ch...
[ { "path": "src/cmd/compile/internal/syntax/parser.go", "patch": "@@ -953,20 +953,6 @@ func (p *parser) callStmt() *CallStmt {\n \t\tx = t\n \t}\n \n-\t// TODO(gri) Now that we don't store a CallExpr in a CallStmt anymore\n-\t// we might as well leave this check to the type checker.\n-\t// ...
2022-08-26T03:32:27
rust-lang/rust
0885f660a5bc4b31d0f7a869be589d81c08eecda
ca77504943887037504c7fc0b9bf06dab3910373
Fix macro infinite recursion test to not trigger warning about semicolon in expr The test cases for issue 41731 are about infinite macro recursion that incorporates `print!` and `println!`. However, they also included trailing semicolons despite expanding to expressions; that isn't what these particular test cases are...
[ { "path": "tests/ui/infinite/issue-41731-infinite-macro-print.rs", "patch": "@@ -5,7 +5,7 @@\n fn main() {\n macro_rules! stack {\n ($overflow:expr) => {\n- print!(stack!($overflow));\n+ print!(stack!($overflow))\n //~^ ERROR recursion limit reached while expand...
2025-08-10T21:04:07
facebook/react
a6c1b91c7d36bb59d900a66329bbe1baa3887cb7
f34f0d2912ce61905fc6d71772d6ac5ce61b1d71
fix typo in community round-up #17
[ { "path": "docs/_posts/2014-02-24-community-roundup-17.md", "patch": "@@ -5,7 +5,7 @@ author: Jonas Gebhardt\n ---\n \n \n-It's exciting to see the number of real-world React applications and components skyrocket over the pasts months! This community round-up features a few examples of inspiring React appli...
2014-02-24T23:25:17
nodejs/node
548439a530c797eb1be877978d5a03f1ee90bc7c
1dc006ef1990d4dcb67a9521bc643638aeba248b
doc: doc and test URLSearchParams discrepancy The WHATWG URL spec is not going to change this behavior so let's document it Signed-off-by: James M Snell <jasnell@gmail.com> Fixes: https://github.com/nodejs/node/issues/33037 PR-URL: https://github.com/nodejs/node/pull/33236 Reviewed-By: Luigi Pinca <luigipinca@gmail...
[ { "path": "doc/api/url.md", "patch": "@@ -472,9 +472,27 @@ and [`url.format()`][] methods would produce.\n * {URLSearchParams}\n \n Gets the [`URLSearchParams`][] object representing the query parameters of the\n-URL. This property is read-only; to replace the entirety of query parameters of\n-the URL, use ...
2020-05-04T17:33:51
facebook/react
61c287c5eac00d987644076afd95810448c33774
7bba8c32576aadd90aad005b8ce34522ebca18cd
[docs] Fix version in lifecycle argument note Fixes #1163.
[ { "path": "docs/docs/ref-03-component-specs.md", "patch": "@@ -127,7 +127,7 @@ If you want to integrate with other JavaScript frameworks, set timers using `set\n \n > Note:\n >\n-> Prior to v0.6, the DOM node was passed in as the last argument. If you were using this, you can still access the DOM node by ca...
2014-02-24T00:49:27
golang/go
bbaf0a514e3b0a5f432746d538a2b04110fa211f
aa5ff29dabbfdda036b8a1f5c5a80f239b876abc
go/types, types2: consolidate testdata/check test files Use the go/types version of testdata/check tests where the diffs are only in the error positions (the types2 test harness allows for some position tolerance). Consolidate files where there are other minor differences. Comment out a couple of tests that are diffe...
[ { "path": "src/cmd/compile/internal/types2/testdata/check/builtins0.go", "patch": "@@ -25,11 +25,11 @@ func append1() {\n \t_ = append(s, b)\n \t_ = append(s, x /* ERROR cannot use x */ )\n \t_ = append(s, s /* ERROR cannot use s */ )\n-\t_ = append(s /* ERROR not enough arguments */ ...)\n-\t_ = append(s, ...
2022-08-26T00:20:07
nodejs/node
26f150022f9b4d4709c1d4ad450c6f9e9fce8d0e
c17dcb32533aa007dfbf507d22c28ef3c7c11c29
http: fixes memory retention issue with FreeList and HTTPParser Fixes: https://github.com/nodejs/node/issues/29394 Refs: https://github.com/nodejs/node/pull/33167#issuecomment-622102450 PR-URL: https://github.com/nodejs/node/pull/33190 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Luigi Pinca <luigipinca@...
[ { "path": "lib/_http_common.js", "patch": "@@ -161,12 +161,10 @@ const parsers = new FreeList('parsers', 1000, function parsersCb() {\n \n cleanParser(parser);\n \n- parser.onIncoming = null;\n parser[kOnHeaders] = parserOnHeaders;\n parser[kOnHeadersComplete] = parserOnHeadersComplete;\n parser[kO...
2020-05-01T06:14:25
facebook/react
2f0507f73030d95dac77b7dd2af61cbc9e5e0115
e2b006f9aee7f30f099c3ed911838858df96d8a2
Remove TodoMVCs from examples/ Fixes #1154. Added a README to point to TodoMVC's site instead.
[ { "path": "examples/README.md", "patch": "@@ -0,0 +1,5 @@\n+# React Examples\n+\n+Here are some demo usages of React, with optional [JSX](http://facebook.github.io/react/docs/jsx-in-depth.html) and third-party integration.\n+\n+For more fully-featured examples, check out [React TodoMVC](http://todomvc.com/a...
2014-02-21T22:21:42
electron/electron
a5eef516a793b01f3eed2e8586fe7e459142ee42
5ee6205c0a5eac585d10d878b8200e40f7c79168
Fix indent in api-crash-reporter-spec.js
[ { "path": "spec/api-crash-reporter-spec.js", "patch": "@@ -16,83 +16,83 @@ describe('crashReporter module', function () {\n }\n var fixtures = path.resolve(__dirname, 'fixtures')\n const generateSpecs = (description, browserWindowOpts) => {\n- describe(description, function () {\n- var w = null\n- ...
2017-03-21T13:53:17
nodejs/node
c17dcb32533aa007dfbf507d22c28ef3c7c11c29
39ff64756bd5bc7147236b36ee9444ceddb3e6d2
doc: fix style and grammer in buffer.md PR-URL: https://github.com/nodejs/node/pull/33194 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
[ { "path": "doc/api/buffer.md", "patch": "@@ -569,7 +569,7 @@ Array entries outside that range will be truncated to fit into it.\n const buf = Buffer.from([0x62, 0x75, 0x66, 0x66, 0x65, 0x72]);\n ```\n \n-A `TypeError` will be thrown if `array` is not an `Array` or other type\n+A `TypeError` will be thrown i...
2020-05-01T11:40:13
vercel/next.js
b2c926f7c2686dd630102d8999ffbc41a67a57da
af2c3f71bf6d736000f04188cd3223846c5caae6
fix(turbopack): support middleware in src (#58218) ### What? We previously marked `/src/middleware` as a missing page Fixes #42921 Closes PACK-1926 --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
[ { "path": "packages/next/src/server/lib/router-utils/setup-dev-bundler.ts", "patch": "@@ -1198,7 +1198,7 @@ async function startWatcher(opts: SetupOpts) {\n }\n \n const overlayMiddleware = getOverlayMiddleware(project)\n- const turbopackHotReloader: NextJsHotReloaderInterface = {\n+ hotReload...
2023-11-10T13:48:20
electron/electron
5ee6205c0a5eac585d10d878b8200e40f7c79168
3a97cfc359e009caf1a42b00d7a7df27439849a6
Run the crash reporter specs with sandbox option. - Create a function that accepts BrowserWindow options and generates a suite that contains the renderer-specific tests. - Run the function twice to execute the tests with and without sandbox option.
[ { "path": "spec/api-crash-reporter-spec.js", "patch": "@@ -11,15 +11,20 @@ const {remote} = require('electron')\n const {app, BrowserWindow, crashReporter} = remote.require('electron')\n \n describe('crashReporter module', function () {\n+ if (process.mas) {\n+ return\n+ }\n var fixtures = path.resol...
2017-03-21T13:48:36
nodejs/node
027e1c706d25be75a790eb744835a0ebdc65452f
bde5f9baf7af4efeec1a0ea1d53b70152e23428f
http: ensure client request emits close If socket creation failed then an error would be emitted on the client request object, but not 'close' nor would destroyed be set to true. PR-URL: https://github.com/nodejs/node/pull/33178 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@...
[ { "path": "lib/_http_agent.js", "patch": "@@ -242,7 +242,12 @@ Agent.prototype.addRequest = function addRequest(req, options, port/* legacy */,\n } else if (sockLen < this.maxSockets) {\n debug('call onSocket', sockLen, freeLen);\n // If we are under maxSockets create a new one.\n- this.createS...
2020-04-30T21:36:19
facebook/react
8aaf5fdbf4d484dd81f55ee35517073d427f98ab
445611f3e6d1a94d08ca2ebab2f5d7e694976646
incorrect include in css transition group example? TransitionGroup maps to ReactTransitionGroup, shouldn't it be a ReactCSSTransitionGroup?
[ { "path": "docs/docs/09.1-animation.md", "patch": "@@ -20,7 +20,7 @@ React provides a `ReactTransitionGroup` addon component as a low-level API for a\n ```javascript{22-24}\n /** @jsx React.DOM */\n \n-var ReactCSSTransitionGroup = React.addons.TransitionGroup;\n+var ReactCSSTransitionGroup = React.addons.C...
2014-02-21T02:26:56
vercel/next.js
25bc6afa1f46920ae852d810356f46e2e5eda569
8eba72f30bc1d8eb8ab6cda808381b73d618275c
fix(ci): exclusion regex now actually works instead of ignoring all tests (#58259)
[ { "path": "run-tests.js", "patch": "@@ -435,7 +435,7 @@ ${ENDGROUP}`)\n ? []\n : [\n '--testNamePattern',\n- `^(?!${test.excludedCases.map(escapeRegexp).join('|')})$`,\n+ `^(?!(?:${test.excludedCases.map(escapeRegexp).join('|')})$).`,\n ...
2023-11-09T20:43:35
golang/go
aa5ff29dabbfdda036b8a1f5c5a80f239b876abc
c801e4b10f708c180a3708bcf39881338691287c
go/parser: adjustments to error messages - Use "expected X" rather then "expecting X". - Report a better error when a type argument list is expected. - Adjust various tests. For #54511. Change-Id: I0c5ca66ecbbdcae1a8f67377682aae6b0b6ab89a Reviewed-on: https://go-review.googlesource.com/c/go/+/425734 TryBot-Result: G...
[ { "path": "src/cmd/compile/internal/syntax/parser.go", "patch": "@@ -190,7 +190,7 @@ func (p *parser) got(tok token) bool {\n \n func (p *parser) want(tok token) {\n \tif !p.got(tok) {\n-\t\tp.syntaxError(\"expecting \" + tokstring(tok))\n+\t\tp.syntaxError(\"expected \" + tokstring(tok))\n \t\tp.advance()\...
2022-08-25T23:41:35
electron/electron
3a97cfc359e009caf1a42b00d7a7df27439849a6
bf756e3c00c79f4f7886dd7ea4d3c27eb5fbfcb0
Expose `crashReporter` to sandbox
[ { "path": "lib/sandboxed_renderer/api/exports/electron.js", "patch": "@@ -11,6 +11,12 @@ Object.defineProperties(exports, {\n return require('../../../renderer/api/remote')\n }\n },\n+ crashReporter: {\n+ enumerable: true,\n+ get: function () {\n+ return require('../../../common/api/...
2017-03-21T13:47:18
facebook/react
2900997b5f1df0fac6ba06c891b92b08eed62783
7eb33ef176a458679b032f40540ae466a8a03efe
Fix transaction test comments Probably got copy/pasted in.
[ { "path": "src/utils/__tests__/Transaction-test.js", "patch": "@@ -98,9 +98,9 @@ describe('Transaction', function() {\n */\n var TestTransaction = function() {\n this.reinitializeTransaction();\n- this.firstCloseParam = INIT_ERRORED; // WON'T be set to something else\n+ this.first...
2014-02-21T00:00:05
nodejs/node
8f87d252fa9ff071a8edf941d431b6efd6cb9727
d799c0f17921797eb61088f6740b25b70d54571e
esm: improve commonjs hint on module not found Run CommonJS resolver only if `error.code` is ERR_MODULE_NOT_FOUND. Avoid using absolute paths in hint by: * using a parent-relative path if the specifier is a relative path * using a `pkg/x.js` format if the specifier is bare (e.g. `pkg/x`) PR-URL: https://github.com/no...
[ { "path": "lib/internal/modules/esm/resolve.js", "patch": "@@ -2,17 +2,22 @@\n \n const {\n ArrayIsArray,\n+ ArrayPrototypeJoin,\n+ ArrayPrototypeShift,\n JSONParse,\n JSONStringify,\n ObjectFreeze,\n ObjectGetOwnPropertyNames,\n ObjectPrototypeHasOwnProperty,\n+ RegExp,\n SafeMap,\n Safe...
2020-03-21T15:38:45
vercel/next.js
fd534fb69692fd7fcec4cf82db5cdfbfdbf237c1
a628e6344efe926f1eeb5a9277956d1f0372f794
Update 02-app-router-migration.mdx (#58253) Corrected a link that linked to the wrong page. <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the cha...
[ { "path": "docs/02-app/01-building-your-application/09-upgrading/02-app-router-migration.mdx", "patch": "@@ -472,7 +472,7 @@ In addition, the new `useRouter` hook has the following changes:\n - The `locale`, `locales`, `defaultLocales`, `domainLocales` values have been removed because built-in i18n Next.js ...
2023-11-09T17:09:31
golang/go
c801e4b10f708c180a3708bcf39881338691287c
9b80d3d3db126bda3eb976778cca4eb03a5a229b
cmd/compile/internal/syntax: use BadExpr instead of fake CallExpr in bad go/defer If the go/defer syntax is bad, using a fake CallExpr may produce a follow-on error in the type checker. Instead store a BadExpr in the syntax tree (since an error has already been reported). Adjust various tests. For #54511. Change-Id...
[ { "path": "src/cmd/compile/internal/syntax/nodes.go", "patch": "@@ -385,7 +385,7 @@ type (\n \n \tCallStmt struct {\n \t\tTok token // Go or Defer\n-\t\tCall *CallExpr\n+\t\tCall Expr\n \t\tstmt\n \t}\n ", "additions": 1, "deletions": 1, "language": "Go" }, { "path": "src/cmd/compile/in...
2022-08-25T23:14:43
electron/electron
e1aebef57c00bd254b64c813e388eaeea53c6e5f
46aed5ff6f4f2e27222dc197f67c48106cf817c8
Make sandbox APIs more compatible with normal renderers - Expose remote shortcuts for the `fs`, `os` and `child_process` modules. - Expose the `url` and `timers` modules(the browserify versions) - Add `process.crash` and `process.platform`
[ { "path": "atom/renderer/atom_sandboxed_renderer_client.cc", "patch": "@@ -9,6 +9,7 @@\n #include \"atom_natives.h\" // NOLINT: This file is generated with js2c\n \n #include \"atom/common/api/api_messages.h\"\n+#include \"atom/common/api/atom_bindings.h\"\n #include \"atom/common/native_mate_converters/st...
2017-03-21T13:41:23
facebook/react
5545887a48468ccc8b16c88713a8eb870ba209e6
e29584b49b9fdb602bf7ec1dbd940626aea56690
Allow rendering markup string without checksum and React ID This fixes https://github.com/facebook/react/pull/994. Also fixes https://github.com/facebook/react/issues/1079. Server-rendering without ID/checksum now works. Also won't call didMount.
[ { "path": "src/browser/ReactDOMComponent.js", "patch": "@@ -99,7 +99,7 @@ ReactDOMComponent.Mixin = {\n *\n * @internal\n * @param {string} rootID The root DOM ID for this node.\n- * @param {ReactReconcileTransaction} transaction\n+ * @param {ReactReconcileTransaction|ReactServerRenderingTransa...
2014-02-20T23:31:11
nodejs/node
53eb264cb16f5c1815d4ccfda585b462f9fac92a
b0aba53195530a95688c9d5f274f854fd423da5c
doc: fix a typo in crypto.generateKeyPairSync() PR-URL: https://github.com/nodejs/node/pull/33187 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
[ { "path": "doc/api/crypto.md", "patch": "@@ -2222,8 +2222,8 @@ behaves as if [`keyObject.export()`][] had been called on its result. Otherwise,\n the respective part of the key is returned as a [`KeyObject`][].\n \n When encoding public keys, it is recommended to use `'spki'`. When encoding\n-private keys, ...
2020-05-01T05:19:45