repo
stringclasses
15 values
fix_commit
stringlengths
40
40
buggy_commit
stringlengths
40
40
message
stringlengths
3
64.3k
files
listlengths
1
300
timestamp
timestamp[s]date
2013-03-13 20:45:00
2026-04-11 07:48:46
vercel/next.js
a628e6344efe926f1eeb5a9277956d1f0372f794
e2f3059b48a779c2a755c21da26570d251305c01
avoid key conflict (#58249) ### What? gives all elements in the array unique keys should fix #57709 and fix #57743
[ { "path": "packages/next/src/server/app-render/get-layer-assets.tsx", "patch": "@@ -97,7 +97,7 @@ export function getLayerAssets({\n ? scriptTags.map((href, index) => {\n const fullSrc = `${ctx.assetPrefix}/_next/${href}`\n \n- return <script src={fullSrc} async={true} key={index} />\n+ ...
2023-11-09T16:44:06
golang/go
5bc8fa74f5186dc7898126487c31283d0766a5b4
b5b2cf519fe332891c165077f3723ee74932a647
cmd/go: support long commands in asm and cgo We have supported passing lists of arguments to the compiler and linker for some time, since https://go.dev/issue/18468 was fixed. The reason behind it is that some systems like Windows have relatively small limits for commands, and some Go packages contain many source file...
[ { "path": "src/cmd/asm/internal/flags/flags.go", "patch": "@@ -73,8 +73,7 @@ func Usage() {\n }\n \n func Parse() {\n-\tflag.Usage = Usage\n-\tflag.Parse()\n+\tobjabi.Flagparse(Usage)\n \tif flag.NArg() == 0 {\n \t\tflag.Usage()\n \t}", "additions": 1, "deletions": 2, "language": "Go" }, { ...
2022-08-31T13:25:11
facebook/react
1de77f1fbe56047998c53999b06b0751001d7807
e59daa8ed8b07068bbd06e260009d80ed6360477
Ensure className={false} turns into string 'false' Fixes inconsistency shown by http://jsfiddle.net/zpao/qeXLm/.
[ { "path": "src/browser/dom/DefaultDOMPropertyConfig.js", "patch": "@@ -186,17 +186,6 @@ var DefaultDOMPropertyConfig = {\n radioGroup: 'radiogroup',\n spellCheck: 'spellcheck',\n srcDoc: 'srcdoc'\n- },\n- DOMMutationMethods: {\n- /**\n- * Setting `className` to null may cause it to be s...
2014-02-14T02:27:05
nodejs/node
e9518254d79645c3c060ea8d7f4898f8e12af9bb
0413accc6b6e2b81784ab959b400236e4588b123
doc: fix the spelling error in stream.md Change `64kb` to `64KB` in `stream.md` PR-URL: https://github.com/nodejs/node/pull/31561 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
[ { "path": "doc/api/stream.md", "patch": "@@ -1442,7 +1442,7 @@ If the loop terminates with a `break` or a `throw`, the stream will be\n destroyed. In other terms, iterating over a stream will consume the stream\n fully. The stream will be read in chunks of size equal to the `highWaterMark`\n option. In the ...
2020-02-01T13:36:36
vercel/next.js
4024b25e8cc0d76d832efb14858d65718a24211e
b740fe8fa4cec0e3733aa21d16e985b04fb25111
parallel routes: fix catch all route support (#58215) This PR fixes a bug where parallel routes would not apply appropriately on navigation when used within slots. The following scenarios: ``` /foo /bar /@slot /[...catchAll] ``` or ``` /foo /[...catchAll] /@slot /bar ``` will now function corr...
[ { "path": "packages/next/src/build/entries.ts", "patch": "@@ -60,6 +60,7 @@ import {\n import { isStaticMetadataRouteFile } from '../lib/metadata/is-metadata-route'\n import { RouteKind } from '../server/future/route-kind'\n import { encodeToBase64 } from './webpack/loaders/utils'\n+import { normalizeCatchA...
2023-11-09T10:11:06
golang/go
b5b2cf519fe332891c165077f3723ee74932a647
91ef076562dfcf783074dbd84ad7c6db60fdd481
go/types,types2: exclude tests that need cgo.Incomplete Since when go/types,types2 do not know about build constraints, and runtime/cgo.Incomplete is only available on platforms that support cgo. These tests are also failing on aix with failure from linker, so disable them on aix to make builder green. The fix for ai...
[ { "path": "src/cmd/compile/internal/types2/stdlib_test.go", "patch": "@@ -197,6 +197,15 @@ func TestStdFixed(t *testing.T) {\n \t\t\"issue48230.go\", // go/types doesn't check validity of //go:xxx directives\n \t\t\"issue49767.go\", // go/types does not have constraints on channel element size\n \t\t\"iss...
2022-09-01T03:32:20
facebook/react
36e97bac21642f73c15d45176dbd304fff327c5a
9f9ee697f3c52d1e0e907b3385ef1324582c201b
Simulate synthetic events using ReactTestUtils Most of the time this is what you want to do, so I've renamed what was Simulate to be SimulateNative. Now Simulate.change does what you expect, so this fixes #517 and fixes #519.
[ { "path": "src/browser/ReactEventEmitter.js", "patch": "@@ -318,6 +318,8 @@ var ReactEventEmitter = merge(ReactEventEmitterMixin, {\n }\n },\n \n+ eventNameDispatchConfigs: EventPluginHub.eventNameDispatchConfigs,\n+\n registrationNameModules: EventPluginHub.registrationNameModules,\n \n putListe...
2014-01-19T00:44:15
electron/electron
71c3e97e81f790b6b9087edfa7f087f248aba761
0287f23e3b546bd8c7f334b3b8ea9a469cd0da58
Fix docs lint warnings
[ { "path": "docs/tutorial/multithreading.md", "patch": "@@ -44,7 +44,7 @@ loads no native modules after the Web Workers get started.\n process.dlopen = () => {\n throw new Error('Load native module is not safe')\n }\n-new Worker('script.js')\n+let worker = new Worker('script.js')\n ```\n \n [web-workers]: ...
2017-03-16T11:18:16
nodejs/node
0413accc6b6e2b81784ab959b400236e4588b123
d5e1795f5320567a91da9162558dbd95804803c8
http: set default timeout in agent keepSocketAlive Previous location of setting the timeout would override behaviour of custom HttpAgents' keepSocketAlive. Moving it into the default keepSocketAlive allows it to interoperate with custom agents. Fixes: https://github.com/nodejs/node/issues/33111 PR-URL: https://githu...
[ { "path": "lib/_http_agent.js", "patch": "@@ -138,11 +138,6 @@ function Agent(options) {\n socket._httpMessage = null;\n this.removeSocket(socket, options);\n \n- const agentTimeout = this.options.timeout || 0;\n- if (socket.timeout !== agentTimeout) {\n- socket.setTimeout(agentTimeout);\...
2020-04-28T15:42:34
golang/go
91ef076562dfcf783074dbd84ad7c6db60fdd481
64b260dbdefcd2205e74d236a7f33d0e6b8f48cb
reflect: fix Value.SetIterXXX to check for the read-only bit v.SetIterXXX(i) is semantically identical to v.Set(i.XXX()). If the latter panics for unexported values, so should the former. This change may breaking some programs, but the change is justified under the "Go 1 and the Future of Go Programs" document becaus...
[ { "path": "src/reflect/all_test.go", "patch": "@@ -8001,6 +8001,17 @@ func TestSetIter(t *testing.T) {\n \tif got := *y.Interface().(*int); got != b {\n \t\tt.Errorf(\"pointer incorrect: got %d want %d\", got, b)\n \t}\n+\n+\t// Make sure we panic assigning from an unexported field.\n+\tm = ValueOf(struct{ ...
2022-08-24T02:10:45
vercel/next.js
8b93b31d5f53036afe6f2683a39b252bbc837d29
121be7cc067faa134d23a1cbafe028978326ff54
reenable perf optimization, fix race condition (vercel/turbo#6405) ### Description fixes a race condition with task dependencies This was the problem: There is a method that marks a task a dirty (e. g. when something has changed). This method changes the task state to dirty/scheduled and clears all depende...
[ { "path": "crates/turbo-tasks-memory/src/memory_backend.rs", "patch": "@@ -13,7 +13,7 @@ use std::{\n };\n \n use anyhow::{bail, Result};\n-use auto_hash_map::{AutoMap, AutoSet};\n+use auto_hash_map::AutoMap;\n use dashmap::{mapref::entry::Entry, DashMap};\n use rustc_hash::FxHasher;\n use tokio::task::futu...
2023-11-09T06:53:05
rust-lang/rust
1aa5668d20d53976860d141a66aa727e425e1079
18eeac04fc5c2a4c4a8020dbdf1c652077ad0e4e
Point at the `Fn()` or `FnMut()` bound that coerced a closure, which caused a move error When encountering a move error involving a closure because the captured value isn't `Copy`, and the obligation comes from a bound on a type parameter that requires `Fn` or `FnMut`, we point at it and explain that an `FnOnce` would...
[ { "path": "compiler/rustc_borrowck/src/diagnostics/move_errors.rs", "patch": "@@ -9,7 +9,7 @@ use rustc_middle::bug;\n use rustc_middle::mir::*;\n use rustc_middle::ty::{self, Ty, TyCtxt};\n use rustc_mir_dataflow::move_paths::{LookupResult, MovePathIndex};\n-use rustc_span::{BytePos, ExpnKind, MacroKind, S...
2025-07-28T02:01:46
facebook/react
c2904b978ed95515479fdc52c32c71fc42fb8e81
8122cadeb492b7bbd4014eb13e23654530ef1290
fix docs
[ { "path": "docs/docs/09.4-test-utils.md", "patch": "@@ -7,11 +7,11 @@ prev: class-name-manipulation.html\n next: examples.html\n ---\n \n-`React.addons.TestUtils` makes it easy to test React components in the testing framework of your choice (we use [Jasmine](http://pivotal.github.io/jasmine/)). All functio...
2014-02-19T06:57:41
electron/electron
0287f23e3b546bd8c7f334b3b8ea9a469cd0da58
40b35a991f415973b7f35ad106d735002e989cf7
Fix cpplint warning
[ { "path": "atom/renderer/atom_renderer_client.cc", "patch": "@@ -12,8 +12,8 @@\n #include \"atom/common/api/api_messages.h\"\n #include \"atom/common/api/atom_bindings.h\"\n #include \"atom/common/api/event_emitter_caller.h\"\n-#include \"atom/common/atom_constants.h\"\n #include \"atom/common/asar/asar_uti...
2017-03-16T11:14:16
rust-lang/rust
a71b024c893abb51335f55023fbfe43787ac9857
18eeac04fc5c2a4c4a8020dbdf1c652077ad0e4e
Fix typo with paren rustc_llvm/build.rs
[ { "path": "compiler/rustc_llvm/build.rs", "patch": "@@ -255,7 +255,7 @@ fn main() {\n println!(\"cargo:rustc-link-lib=kstat\");\n }\n \n- if (target.starts_with(\"arm\") && !target.contains(\"freebsd\")) && !target.contains(\"ohos\")\n+ if (target.starts_with(\"arm\") && !target.contains(\...
2025-08-10T19:22:13
vercel/next.js
bbb730e5ef10115ed76434f250379f6f53efe998
fd7ea115b5c6d4b5a2816403dfcf87f19f984e7a
[Docs]: Fix CLI link to server actions size limit docs (#58174) This PR fixes the terminal link to server actions size limitations for body size limit. The link is wrong and sending people to a 404
[ { "path": "packages/next/src/server/app-render/action-handler.ts", "patch": "@@ -490,7 +490,7 @@ export async function handleAction({\n throw new ApiError(\n 413,\n `Body exceeded ${readableLimit} limit.\n-To configure the body size limit for Server Actions, see: http...
2023-11-09T02:51:14
golang/go
ca634fa2c550cd85a1a2cc03c208304ee38c6a82
e4b624eae5fa3c51b8ca808da29442d3e3aaef04
cmd/compile: reject not-in-heap types as type arguments After running the types2 type checker, walk info.Instances to reject any not-in-heap type arguments. This is feasible to check using the types2 API now, thanks to #46731. Fixes #54765. Change-Id: Idd2acc124d102d5a76f128f13c21a6e593b6790b Reviewed-on: https://go...
[ { "path": "src/cmd/compile/internal/noder/helpers.go", "patch": "@@ -256,3 +256,28 @@ func isTypeParam(t types2.Type) bool {\n \t_, ok := t.(*types2.TypeParam)\n \treturn ok\n }\n+\n+// isNotInHeap reports whether typ is or contains an element of type\n+// runtime/internal/sys.NotInHeap.\n+func isNotInHeap(...
2022-08-31T22:48:35
facebook/react
ea803c47ba2bc1ed5df8df87319fc82ec97935db
42c837e4ddc32550b0a7f59401f4a3f4a3731445
docs fixes
[ { "path": "docs/docs/09.1-animation.md", "patch": "@@ -94,11 +94,11 @@ You can disable animating `enter` or `leave` animations if you want. For example\n \n ### `componentWillEnter(callback)`\n \n-This is called at the same time as `componentDidMount()`. It will block other animations from occurring until `...
2014-02-19T06:51:51
electron/electron
40b35a991f415973b7f35ad106d735002e989cf7
940d77b9a0e990315894d3fd881e4b6df2c2d755
Fix js lint
[ { "path": "spec/chromium-spec.js", "patch": "@@ -600,7 +600,7 @@ describe('chromium feature', function () {\n })\n \n it('Worker has node integration with nodeIntegrationInWorker', function (done) {\n- let webview = new WebView\n+ let webview = new WebView()\n webview.addEventListene...
2017-03-16T10:51:43
rust-lang/rust
464a6b1b4af28f7b2d1adf051bad3f182e23b88e
18eeac04fc5c2a4c4a8020dbdf1c652077ad0e4e
Detect struct construction with private field in field with default When trying to construct a struct that has a public field of a private type, suggest using `..` if that field has a default value. ``` error[E0603]: struct `Priv1` is private --> $DIR/non-exhaustive-ctor.rs:25:39 | LL | let _ = S { field: ()...
[ { "path": "compiler/rustc_metadata/src/rmeta/decoder/cstore_impl.rs", "patch": "@@ -395,6 +395,7 @@ provide! { tcx, def_id, other, cdata,\n \n crate_extern_paths => { cdata.source().paths().cloned().collect() }\n expn_that_defined => { cdata.get_expn_that_defined(def_id.index, tcx.sess) }\n+ defa...
2025-01-21T21:07:20
nodejs/node
d84f1312915fe45fe0febe888db692c74894c382
5f2c4ce74f33cf7da5628f6a28c2c06841e16c90
stream: fix stream.finished on Duplex finished would incorrectly believe that a Duplex is already closed if either the readable or writable side has completed. Fixes: https://github.com/nodejs/node/issues/33130 PR-URL: https://github.com/nodejs/node/pull/33133 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewe...
[ { "path": "lib/internal/streams/end-of-stream.js", "patch": "@@ -147,17 +147,25 @@ function eos(stream, opts, callback) {\n if (opts.error !== false) stream.on('error', onerror);\n stream.on('close', onclose);\n \n- const closed = (wState && wState.closed) || (rState && rState.closed) ||\n- (wState ...
2020-04-28T17:36:23
golang/go
5f5c018ca46b6634da9372f5af759cb36fcaed5f
69aed4712d73c9c1b70be3e2e222eb55391e2fb0
cmd/compile: redo mknode.go The current mknode has a few problems: 1) It tends not to run successfully if the tree is in a broken state. 2) It requires that it be run by the go tool in the tree (somewhat related to 1) 3) It requires setting GOROOT 4) It imports code outside the tree (x/packages) This makes mknode.go ...
[ { "path": "src/cmd/compile/internal/ir/mini.go", "patch": "@@ -2,8 +2,7 @@\n // Use of this source code is governed by a BSD-style\n // license that can be found in the LICENSE file.\n \n-//go:generate go run -mod=mod mknode.go\n-// Note: see comment at top of mknode.go\n+//go:generate go run mknode.go\n \n...
2022-07-19T18:09:01
vercel/next.js
bcef6d6ab6ba096a5599584c5dd75d4e4ed251b8
c47c2feb015a10ea02f028bf0aa9de29b1759247
fix ppr test flake (#58232) Wraps this test in a `check` since the experimental log seems to occasionally come in late ([x-ref](https://github.com/vercel/next.js/actions/runs/6805954994/job/18506429726#step:27:410))
[ { "path": "test/e2e/app-dir/ppr/ppr.test.ts", "patch": "@@ -1,4 +1,5 @@\n import { createNextDescribe } from 'e2e-utils'\n+import { check } from 'next-test-utils'\n \n createNextDescribe(\n 'ppr',\n@@ -7,9 +8,13 @@ createNextDescribe(\n skipDeployment: true,\n },\n ({ next, isNextDev, isNextStart ...
2023-11-09T02:13:21
rust-lang/rust
23946b7f902d7cfa774aa38089553a8cc9e6fafb
18eeac04fc5c2a4c4a8020dbdf1c652077ad0e4e
Fix Cargo cross-compilation (take two)
[ { "path": "src/bootstrap/src/core/build_steps/tool.rs", "patch": "@@ -857,7 +857,9 @@ impl Step for Cargo {\n fn run(self, builder: &Builder<'_>) -> ToolBuildResult {\n builder.build.require_submodule(\"src/tools/cargo\", None);\n \n+ builder.std(self.build_compiler, builder.host_target);...
2025-08-10T18:58:39
facebook/react
e0dbca116887ff93e2093be54fb8cb72aad9de74
792d8aca86611027ae969358cab9eb6918b8052c
Don't break if no attribute value Fixes the transformation of things like `<button disabled>`.
[ { "path": "npm-jsx_whitespace_transformer/package.json", "patch": "@@ -1,7 +1,7 @@\n {\n \"name\": \"jsx_whitespace_transformer\",\n \"description\": \"A utility to update your JSX to behave identically in React 0.8 and React 0.9.\",\n- \"version\": \"1.0.0\",\n+ \"version\": \"1.0.1\",\n \"main\": ...
2014-02-19T02:09:44
electron/electron
940d77b9a0e990315894d3fd881e4b6df2c2d755
033aa16e04ef9e29087961a06658e5ad7ee0ce3d
Fix typos and adjust sentences
[ { "path": "atom/renderer/atom_renderer_client.cc", "patch": "@@ -441,7 +441,6 @@ void AtomRendererClient::AddSupportedKeySystems(\n \n void AtomRendererClient::DidInitializeWorkerContextOnWorkerThread(\n v8::Local<v8::Context> context) {\n- LOG(ERROR) << \"DidInitializeWorkerContextOnWorkerThread\";\n ...
2017-03-16T08:41:25
nodejs/node
5f2c4ce74f33cf7da5628f6a28c2c06841e16c90
0bd24a6e563f92e67f582dbd470355acc74f7792
vm: fix vm.measureMemory() and introduce execution option https://github.com/nodejs/node-v8/pull/147 broke the `vm.measureMemory()` API. It only created a `MeasureMemoryDelegate` and without actually calling `v8::Isolate::MeasureMemory()` so the returned promise will never resolve. This was not caught by the tests bec...
[ { "path": "doc/api/vm.md", "patch": "@@ -303,44 +303,70 @@ added: v13.10.0\n \n > Stability: 1 - Experimental\n \n-Measure the memory known to V8 and used by the current execution context\n-or a specified context.\n+Measure the memory known to V8 and used by all contexts known to the\n+current V8 isolate, o...
2020-04-22T02:28:20
golang/go
69aed4712d73c9c1b70be3e2e222eb55391e2fb0
af7f067e0d7f92bcf4d0938d093725a0ac6366b1
cmd/compile: use better splitting condition for string binary search Currently we use a full cmpstring to do the comparison for each split in the binary search for a string switch. Instead, split by comparing a single byte of the input string with a constant. That will give us a much faster split (although it might b...
[ { "path": "src/cmd/compile/internal/walk/switch.go", "patch": "@@ -190,10 +190,6 @@ func (s *exprSwitch) flush() {\n \t\t}\n \t\truns = append(runs, cc[start:])\n \n-\t\tif len(runs) == 1 {\n-\t\t\ts.search(runs[0], &s.done)\n-\t\t\treturn\n-\t\t}\n \t\t// We have strings of more than one length. Generate a...
2022-06-25T18:11:07
nodejs/node
2e441e152fdda36a8ae9d97e2a312e024494456f
a7ae7aab597a874cb0087e8e333e8f7765ded88c
tools: fix redundant-move warning in inspector Currently, the following warning is generated from the inspector protocol: /out/Release/obj/gen/src/node/inspector/protocol/Protocol.cpp: In member function ‘virtual std::unique_ptr<node::inspector::protocol::Value> node::inspector::protocol::ListValue::clone() const’...
[ { "path": "tools/inspector_protocol/lib/Values_cpp.template", "patch": "@@ -606,7 +606,7 @@ std::unique_ptr<Value> DictionaryValue::clone() const\n DCHECK(value != m_data.cend() && value->second);\n result->setValue(key, value->second->clone());\n }\n- return std::move(result);\n+ ...
2020-04-06T12:21:08
golang/go
59b15726d113324d0c91d8aae559e9fb7cb04495
ebc75ac1c6f056d5911286368d11022204e55947
cmd/asm: fix condition check to work on ppc64 A condition check was added to parse.go in CL 405542 to prevent usage of scaled operands on ppc64. However while trying to improve the error notification message, an if-condition was left out by oversight. This CL corrects that. Change-Id: I8cef3dd194c75343354ffe888b5e639...
[ { "path": "src/cmd/asm/internal/asm/parse.go", "patch": "@@ -1017,9 +1017,7 @@ func (p *Parser) registerIndirect(a *obj.Addr, prefix rune) {\n \t\t\tif scale != 0 && scale != 1 && (p.arch.Family == sys.ARM64 ||\n \t\t\t\tp.arch.Family == sys.PPC64) {\n \t\t\t\t// Support (R1)(R2) (no scaling) and (R1)(R2*1)...
2022-08-31T09:06:45
vercel/next.js
db275073d47769efca8c98704ee74239fc36df51
b50090bf964d9a74abf69c8ea9a51d3162798ad9
pass postpone through staticGenerationStore (#58229) Instead of requiring React in `maybePostpone` (which is susceptible to referencing the wrong version of React during build time, such as in the case where the static worker patches fetch within an app-route, which doesn't have an experimental runtime), this provides...
[ { "path": "packages/next/src/build/utils.ts", "patch": "@@ -1294,7 +1294,8 @@ export async function buildAppStaticPaths({\n supportsDynamicHTML: true,\n isRevalidate: false,\n isBot: false,\n- experimental: { ppr },\n+ // building static paths should never postpone\n+ ...
2023-11-09T00:59:05
nodejs/node
a7ae7aab597a874cb0087e8e333e8f7765ded88c
8698dd98bbc53ca8da90697e6fbd04a0d04a9580
build: add --error-on-warn configure flag This commit adds a configuration time flag named error-on-warn: $ ./configure --help | grep -A1 error-on-warn --error-on-warn Turn compiler warnings into errors for node core sources. The motivation for this is that CI jobs can use this flag to...
[ { "path": "common.gypi", "patch": "@@ -26,6 +26,7 @@\n 'uv_library%': 'static_library',\n \n 'clang%': 0,\n+ 'error_on_warn%': 'false',\n \n 'openssl_fips%': '',\n 'openssl_no_asm%': 0,\n@@ -218,7 +219,14 @@\n # Forcibly disable -Werror. We support a wide range of compilers, it's\n ...
2020-04-06T12:17:57
electron/electron
88f062958f420dd610be265e77c3a281444a9b0a
3af9f572ac952dc2ff6327e350d66ee858ad3217
Fix option doc
[ { "path": "docs/api/browser-window.md", "patch": "@@ -295,7 +295,7 @@ It creates a new `BrowserWindow` with native properties as set by the `options`.\n 'Electron Isolated Context' entry in the combo box at the top of the\n Console tab. **Note:** This option is currently experimental and may\n ...
2017-03-19T11:21:03
vercel/next.js
121be7cc067faa134d23a1cbafe028978326ff54
d2cc941f9ff5f00b0a41e5861e397f70fa11e808
performance improvement and fixes (vercel/turbo#6394) ### Description some small performance improvements and a little fix where collectibles are not removed when a task becomes dirty during execution ### Testing Instructions <!-- Give a quick description of steps to test your changes. -->
[ { "path": "crates/turbo-tasks-memory/src/aggregation_tree/bottom_tree.rs", "patch": "@@ -1,7 +1,7 @@\n use std::{hash::Hash, ops::ControlFlow, sync::Arc};\n \n use nohash_hasher::{BuildNoHashHasher, IsEnabled};\n-use parking_lot::{RwLock, RwLockWriteGuard};\n+use parking_lot::{RwLock, RwLockReadGuard, RwLoc...
2023-11-08T23:10:24
golang/go
bc0a033266eeaed189a5c77becd45b861fd245f5
fa0e3bffb494fb9f97c241d6579daa443fbcbb06
runtime: fix comment typo in mpagealloc.go leve --> level Change-Id: Ia5ff46c79c4dda2df426ec75d69e8fcede909b47 GitHub-Last-Rev: e57cad22d99b74c7e220f4d5a7b03a830544aea9 GitHub-Pull-Request: golang/go#54788 Reviewed-on: https://go-review.googlesource.com/c/go/+/426974 Run-TryBot: Daniel Martí <mvdan@mvdan.cc> Reviewed...
[ { "path": "src/runtime/mpagealloc.go", "patch": "@@ -676,7 +676,7 @@ nextLevel:\n \n \t\t// Determine j0, the first index we should start iterating from.\n \t\t// The searchAddr may help us eliminate iterations if we followed the\n-\t\t// searchAddr on the previous level or we're on the root leve, in which\...
2022-08-31T08:28:13
facebook/react
112a20ce738813ddb5ef1f885c14c358abc4dee9
8ac5975ad819602a09b1b058e29d902511a7ca26
Add media element attributes Fixes #1124. I didn't add `volume` because it requires more complicated logic to control properly and I didn't add `paused` because to set it we need to call play() or pause() -- perhaps a mutation method is appropriate.
[ { "path": "src/browser/dom/DefaultDOMPropertyConfig.js", "patch": "@@ -59,6 +59,7 @@ var DefaultDOMPropertyConfig = {\n contentEditable: null,\n contextMenu: MUST_USE_ATTRIBUTE,\n controls: MUST_USE_PROPERTY | HAS_BOOLEAN_VALUE,\n+ crossOrigin: null,\n data: null, // For `<object />` acts...
2014-02-18T20:30:14
nodejs/node
8698dd98bbc53ca8da90697e6fbd04a0d04a9580
ff38ec0471f075e3f9c08ac5b803649f6e7e4ac2
test: fix out-of-bound reads from invalid sizeof usage `sizeof(data)` does not return the correct result here, as it measures the size of the `data` variable, not what it points to. PR-URL: https://github.com/nodejs/node/pull/33115 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail...
[ { "path": "test/addons/worker-buffer-callback/binding.cc", "patch": "@@ -30,7 +30,7 @@ void Initialize(Local<Object> exports,\n node::Buffer::New(\n isolate,\n data,\n- sizeof(data),\n+ sizeof(char),\n ...
2020-04-28T02:53:52
golang/go
3486735bf2ca08dcd84bb820fdcb0dea8102cf82
3680b5e9c4f42fcf9155aa42b3b344d1fbe19571
net/http/pprof: link docs to runtime/pprof And add some documentation for the debug query param. Fixes #27737 Fixes #53971 Change-Id: I629aaa2d4a43175381eb04872f1caad238519a41 Reviewed-on: https://go-review.googlesource.com/c/go/+/421635 Run-TryBot: Cherry Mui <cherryyz@google.com> Reviewed-by: Than McIntosh <thanm@...
[ { "path": "src/net/http/pprof/pprof.go", "patch": "@@ -21,10 +21,15 @@\n //\t\tlog.Println(http.ListenAndServe(\"localhost:6060\", nil))\n //\t}()\n //\n+// By default, all the profiles listed in [runtime/pprof.Profile] are\n+// available (via [Handler]), in addition to the [Cmdline], [Profile], [Symbol],\n...
2022-08-06T12:54:28
vercel/next.js
4a80b590a2e15670cedf366083d8c5c731b3d920
952e4376822b6f25863497ca4a462e12e08a0860
small minor fixes (vercel/turbo#6403) ### Description some cleanup fixes ### Testing Instructions <!-- Give a quick description of steps to test your changes. --> Closes PACK-1917
[ { "path": "crates/turbo-tasks-fs/src/rope.rs", "patch": "@@ -107,12 +107,12 @@ impl Rope {\n \n /// Returns a String instance of all bytes.\n pub fn to_str(&self) -> Result<Cow<'_, str>> {\n- self.data.to_str()\n+ self.data.to_str(self.length)\n }\n \n /// Returns a slice of al...
2023-11-08T23:09:40
electron/electron
3af9f572ac952dc2ff6327e350d66ee858ad3217
2c21d3b3fa82865f0ec1906f1fe55369401ea903
Fix spec description
[ { "path": "spec/api-browser-window-spec.js", "patch": "@@ -1070,7 +1070,7 @@ describe('BrowserWindow module', function () {\n })\n })\n \n- describe('useNativeWindowOpen option', () => {\n+ describe('nativeWindowOpen option', () => {\n it('allows synchronous access to window opened by ...
2017-03-19T11:10:25
facebook/react
57953769614ab767ab4b1bf47313f7a689b63492
9e160df86806c2746735492263401aac725281af
Strip calls to warning() in __DEV__ Fixes #1120.
[ { "path": "package.json", "patch": "@@ -73,6 +73,6 @@\n },\n \"preferGlobal\": true,\n \"commonerConfig\": {\n- \"version\": 3\n+ \"version\": 4\n }\n }", "additions": 1, "deletions": 1, "language": "JSON" }, { "path": "src/vendor/core/invariant.js", "patch": "@@ -16,6 ...
2014-02-18T01:28:38
nodejs/node
2cd79700c028f99f76f5b124b30009a838019b2b
e7b99e027b2fe2fc0834bf2df9daf6d94b27f02b
stream: add null check in Readable.from Throws `ERR_STREAM_NULL_VALUES` error if a null value is passed to `Readable.from`. Also added docs for the same. Co-Authored-By: 扩散性百万甜面包 <himself65@outlook.com> Fixes: https://github.com/nodejs/node/issues/32845 PR-URL: https://github.com/nodejs/node/pull/32873 Reviewed-By: R...
[ { "path": "doc/api/stream.md", "patch": "@@ -1700,7 +1700,8 @@ added:\n -->\n \n * `iterable` {Iterable} Object implementing the `Symbol.asyncIterator` or\n- `Symbol.iterator` iterable protocol.\n+ `Symbol.iterator` iterable protocol. Emits an 'error' event if a null\n+ value is passed.\n * `options` {O...
2020-04-16T00:37:47
golang/go
3680b5e9c4f42fcf9155aa42b3b344d1fbe19571
d2e0587f77e1cbbd5c7966242c85edba83b37157
cmd/compile: teach prove about bitwise OR operation Fixes #45928. Change-Id: Ifbb0effbca4ab7c0eb56069fee40edb564553c35 Reviewed-on: https://go-review.googlesource.com/c/go/+/410336 Reviewed-by: Cuong Manh Le <cuong.manhle.vn@gmail.com> Run-TryBot: Wayne Zuo <wdvxdr@golangcn.org> Reviewed-by: David Chase <drchase@goog...
[ { "path": "src/cmd/compile/internal/ssa/prove.go", "patch": "@@ -842,6 +842,9 @@ func prove(f *Func) {\n \t\t\tcase OpAnd64, OpAnd32, OpAnd16, OpAnd8:\n \t\t\t\tft.update(b, v, v.Args[1], unsigned, lt|eq)\n \t\t\t\tft.update(b, v, v.Args[0], unsigned, lt|eq)\n+\t\t\tcase OpOr64, OpOr32, OpOr16, OpOr8:\n+\t\...
2022-06-05T05:22:29
vercel/next.js
d422aeb5dc7941474edbe1ff5084e86948f533f3
67656c3fec4b1a44440e5e988dd2314ea7458ae8
tweak postpone error copy & fix link (#58219) Fixes a broken link, shortens the title, and adds another possible way to resolve the error. Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
[ { "path": "errors/ppr-postpone-error.mdx", "patch": "@@ -1,5 +1,5 @@\n ---\n-title: Understanding the postpone error triggered during static generation\n+title: Static Generation Postpone Error\n ---\n \n ## Why This Error Occurred\n@@ -8,6 +8,6 @@ When Partial Prerendering (PPR) is enabled, using APIs that...
2023-11-08T21:13:21
electron/electron
2c21d3b3fa82865f0ec1906f1fe55369401ea903
afdf52b05369aafdf2132f72639de065da5e6884
Fix JavaScript in docs
[ { "path": "docs/api/window-open.md", "patch": "@@ -51,7 +51,7 @@ The creation of the `BrowserWindow` is customizable in `WebContents`'s `new-wind\n \n ```javascript\n mainWindow.webContents.on('new-window', (event, url, frameName, disposition, options, additionalFeatures) => {\n- if (url.endsWith(\"modal.h...
2017-03-19T11:09:52
rust-lang/rust
bc14ad38a394df0e74eb6e204d75038a8cf6ef99
dc0bae1db725fbba8524f195f74f680995fd549e
strip prefix of temporary file names when it exceeds filesystem name length limit When doing lto, rustc generates filenames that are concatenating many information. In the case of this testcase, it is concatenating crate name and rust file name, plus some hash, and the extension. In some other cases it will concatena...
[ { "path": "compiler/rustc_session/src/config.rs", "patch": "@@ -16,10 +16,11 @@ use std::{cmp, fmt, fs, iter};\n \n use externs::{ExternOpt, split_extern_opt};\n use rustc_data_structures::fx::{FxHashSet, FxIndexMap};\n-use rustc_data_structures::stable_hasher::{StableOrd, ToStableHashKey};\n+use rustc_data...
2025-08-06T14:18:25
vercel/next.js
952e4376822b6f25863497ca4a462e12e08a0860
c91de671eb44c9b5faeb79804b6b6d2268743cd1
improve count hash set edge case handling, fix negative bottom connection counting (vercel/turbo#6393) ### Description There are some bugs when counting negative entries ### Testing Instructions <!-- Give a quick description of steps to test your changes. -->
[ { "path": "crates/turbo-tasks-memory/src/aggregation_tree/bottom_connection.rs", "patch": "@@ -44,11 +44,23 @@ impl<T: IsEnabled + Eq + Hash + Clone> DistanceCountMap<T> {\n \n pub fn add_clonable(&mut self, item: &T, distance: u8) -> bool {\n match self.map.raw_entry_mut(item) {\n- R...
2023-11-08T19:06:15
rust-lang/rust
ba350ff9110de2c75dab1e9530b63898bdc10154
7f7b8ef27d86c865a7ab20c7c42f50811c6a914d
fix: re-enable self-assignment
[ { "path": "compiler/rustc_passes/src/dead.rs", "patch": "@@ -172,7 +172,6 @@ impl<'tcx> MarkSymbolVisitor<'tcx> {\n }\n }\n \n- #[allow(dead_code)] // FIXME(81658): should be used + lint reinstated after #83171 relands.\n fn handle_assign(&mut self, expr: &'tcx hir::Expr<'tcx>) {\n ...
2025-08-10T13:50:14
electron/electron
f3ce93f1bb1ac38aa68d0d2673a5502bafde043e
076427673e5b2126668defe51a0a68824cc043ac
Fix C++ style
[ { "path": "atom/browser/atom_browser_client.cc", "patch": "@@ -96,7 +96,8 @@ bool AtomBrowserClient::ShouldCreateNewSiteInstance(\n return false;\n \n int process_id = current_instance->GetProcess()->GetID();\n- if (!(IsRendererSandboxed(process_id) || RendererUsesNativeWindowOpen(process_id)))\n+ i...
2017-03-19T09:24:05
facebook/react
ae7e44ec84b656213b546fb0596adb266427e76a
9e160df86806c2746735492263401aac725281af
Add download and hrefLang attributes Fixes #1115.
[ { "path": "src/browser/dom/DefaultDOMPropertyConfig.js", "patch": "@@ -64,6 +64,7 @@ var DefaultDOMPropertyConfig = {\n defer: HAS_BOOLEAN_VALUE,\n dir: null,\n disabled: MUST_USE_ATTRIBUTE | HAS_BOOLEAN_VALUE,\n+ download: null,\n draggable: null,\n encType: null,\n form: MUST_US...
2014-02-17T23:12:57
golang/go
d2e0587f77e1cbbd5c7966242c85edba83b37157
6b113c0fecd62b57ee88757c3ca80e9bdd11150d
cmd/compile: derive relation between x+delta and x in prove If x+delta cannot overflow/underflow, we can derive: x+delta < x if delta<0 (this CL included) x+delta > x if delta>0 (this CL not included due to a recursive stack overflow) Remove 95 bounds checks during ./make.bat Fixes #51622 Change-Id: I60d9bd84...
[ { "path": "src/cmd/compile/internal/ssa/prove.go", "patch": "@@ -463,15 +463,23 @@ func (ft *factsTable) update(parent *Block, v, w *Value, d domain, r relation) {\n \t\t\tif parent.Func.pass.debug > 1 {\n \t\t\t\tparent.Func.Warnl(parent.Pos, \"x+d %s w; x:%v %v delta:%v w:%v d:%v\", r, x, parent.String(),...
2022-05-13T15:52:48
nodejs/node
ef85bd1908e9550e59dbfa16372b79c1a95ea2a8
11bc30d5cc000614b9168d7989082e8c1a69be28
worker: unify custom error creation Mostly, this introduces a pattern that makes sure that if a custom error is reported, `stopped_` will be set to `true` correctly in every cast, which was previously missing for the `NewContext().IsEmpty()` case (which led to a hard crash from the `Worker` destructor). This also lea...
[ { "path": "src/node_worker.cc", "patch": "@@ -131,9 +131,7 @@ class WorkerThreadData {\n if (ret != 0) {\n char err_buf[128];\n uv_err_name_r(ret, err_buf, sizeof(err_buf));\n- w->custom_error_ = \"ERR_WORKER_INIT_FAILED\";\n- w->custom_error_str_ = err_buf;\n- w->stopped_ = t...
2020-04-27T01:36:23
facebook/react
2f0bb69708e224fb7b6eb90766578841112a22d2
9e160df86806c2746735492263401aac725281af
Prevent error thrown when removing event target Fixes #1105.
[ { "path": "src/browser/ReactEventTopLevelCallback.js", "patch": "@@ -49,6 +49,9 @@ function findParent(node) {\n return parent;\n }\n \n+// Used to store ancestor hierarchy in top level callback\n+var topLevelCallbackReusableArray = [];\n+\n /**\n * Top-level callback creator used to implement event hand...
2014-02-17T09:24:54
vercel/next.js
536d2dbc4451f26c0fa51deb1439e8ef08d021fe
a6a8c8422ccaddb2c1cf31533df3ecca4b03bcad
interception routes: fix interception for dynamic routes (#58198) This PR fixes the bug in which interception routes of the form `(.)[param]` would not intercept navigations. The bug happened because we would not create a dynamic route matcher for the intercepted route, so we would never match the correct dynamic rou...
[ { "path": "packages/next/src/lib/create-client-router-filter.ts", "patch": "@@ -4,6 +4,10 @@ import { isDynamicRoute } from '../shared/lib/router/utils'\n import { removeTrailingSlash } from '../shared/lib/router/utils/remove-trailing-slash'\n import type { Redirect } from './load-custom-routes'\n import { ...
2023-11-08T18:57:57
golang/go
6b113c0fecd62b57ee88757c3ca80e9bdd11150d
2f103873c5081c7013cadfecb9b1c051d7c5520a
cmd/compile: avoid excessive libfuzzer instrumentation of int compares Do not intercept integer compares that are used to increment libFuzzer's 8-bit counters. This is unnecessary and has a negative impact on the fuzzing performance. This fixes #53760. Change-Id: Id22efac968b18014eedabb6f0762e1456897024e GitHub-Last-...
[ { "path": "src/cmd/compile/internal/walk/compare.go", "patch": "@@ -116,7 +116,7 @@ func walkCompare(n *ir.BinaryExpr, init *ir.Nodes) ir.Node {\n \n \tswitch t.Kind() {\n \tdefault:\n-\t\tif base.Debug.Libfuzzer != 0 && t.IsInteger() {\n+\t\tif base.Debug.Libfuzzer != 0 && t.IsInteger() && (n.X.Name() == n...
2022-07-11T15:56:37
electron/electron
076427673e5b2126668defe51a0a68824cc043ac
6bbfe89f96bc418bd7cd26d4168763df123ec94e
Fix JavaScript style
[ { "path": "lib/browser/guest-window-manager.js", "patch": "@@ -243,7 +243,9 @@ ipcMain.on('ELECTRON_GUEST_WINDOW_MANAGER_INTERNAL_WINDOW_OPEN', function (event\n additionalFeatures, postData) {\n options = mergeBrowserWindowOptions(event.se...
2017-03-19T09:20:10
facebook/react
827c44fcd332443d8ac615d7f70895c6edda1b10
0d4213001b654d52c03c5385be52342fd9a84090
Fix docs for React.Children.map, .forEach, .only.
[ { "path": "docs/docs/ref-01-top-level-api.md", "patch": "@@ -18,26 +18,26 @@ next: component-api.html\n #### React.Children.map\n \n ```javascript\n-array React.Children.map(object children, function fn [, object context])\n+object React.Children.map(object children, function fn [, object context])\n ```\n ...
2014-02-16T20:27:17
rust-lang/rust
d528a49fd7c0447cc51406908fb13fe055d273aa
1a6d6363d090961a1efe513d413f5b51ecd81ab8
Fix panic if an item does not have a body
[ { "path": "src/librustdoc/html/render/span_map.rs", "patch": "@@ -2,7 +2,7 @@ use std::path::{Path, PathBuf};\n \n use rustc_data_structures::fx::{FxHashMap, FxIndexMap};\n use rustc_hir::def::{DefKind, Res};\n-use rustc_hir::def_id::{DefId, LOCAL_CRATE};\n+use rustc_hir::def_id::{DefId, LOCAL_CRATE, LocalD...
2025-05-04T17:08:23
electron/electron
319a7759d0610eb507e4e5a5544c922625645ac7
2c7343293a8489fd067ff0e12b1b71a6b0546c94
Fix ELECTRON_GUEST_WINDOW_MANAGER_INTERNAL_WINDOW_OPEN handler
[ { "path": "lib/browser/guest-window-manager.js", "patch": "@@ -242,12 +242,16 @@ ipcMain.on('ELECTRON_GUEST_WINDOW_MANAGER_INTERNAL_WINDOW_OPEN', function (event\n disposition, options,\n ...
2017-03-19T08:52:39
vercel/next.js
d05b817e3d1acdb1e2b89bec0fc62fc2f6fc5cd3
5dc2572dc711722a884051639b7c946b0baa13de
fix docs link for ISR (#58207) x-ref: https://github.com/vercel/next.js/pull/58206#issuecomment-1802174076
[ { "path": "docs/03-pages/01-building-your-application/02-rendering/05-client-side-rendering.mdx", "patch": "@@ -6,7 +6,7 @@ related:\n links:\n - pages/building-your-application/rendering/server-side-rendering\n - pages/building-your-application/rendering/static-site-generation\n- - pages/build...
2023-11-08T16:31:55
golang/go
3c6a5cdb9a29c0e3b12cdaa8ab81ba22d989e3b0
f21514c7f8c972ce2291d41cf5b6263f0eb350c7
cmd/go/internal/imports: recognize "unix" build tag For #20322 For #51572 Fixes #54712 Change-Id: I22fcfa820e83323bfdf1a40deee7286240f02b3e GitHub-Last-Rev: cd2c6536b0298baf3c54e5bdbc456a814545cff4 GitHub-Pull-Request: golang/go#54716 Reviewed-on: https://go-review.googlesource.com/c/go/+/426296 Run-TryBot: Heschi Kr...
[ { "path": "src/cmd/dist/build.go", "patch": "@@ -939,7 +939,8 @@ func packagefile(pkg string) string {\n }\n \n // unixOS is the set of GOOS values matched by the \"unix\" build tag.\n-// This is the same list as in go/build/syslist.go.\n+// This is the same list as in go/build/syslist.go and\n+// cmd/go/in...
2022-08-29T23:29:48
nodejs/node
393f6914df3431b194f49fbb4fb9ee2430f8807c
a9b8f707662d4c564f4439b150229635da007ae7
doc: improve worker pool example In the worker pool example, the 'kWorkerFreedEvent' should be emitted in case of error as well. After adding new worker in the error handler, the pending tasks should be notified of an available worker. PR-URL: https://github.com/nodejs/node/pull/33082 Reviewed-By: Anna Henningsen <an...
[ { "path": "doc/api/async_hooks.md", "patch": "@@ -820,6 +820,7 @@ class WorkerPool extends EventEmitter {\n });\n this.workers.push(worker);\n this.freeWorkers.push(worker);\n+ this.emit(kWorkerFreedEvent);\n }\n \n runTask(task, callback) {", "additions": 1, "deletions": 0, "...
2020-04-26T22:43:57
facebook/react
47ae8654281874b7e30859876bc05d984d3b8d68
0d4213001b654d52c03c5385be52342fd9a84090
Make ReactWebWorker-test.js less flaky. Two improvements: make sure we set `done = true` when an error message is received, so that the test output contains the error message instead of eventually timing out and displaying nothing useful; and increase the timeout for this particular test from 5000ms (the default) to 2...
[ { "path": "src/browser/__tests__/ReactWebWorker-test.js", "patch": "@@ -31,6 +31,7 @@ describe('ReactWebWorker', function() {\n var data = JSON.parse(e.data);\n if (data.type == 'error') {\n error = data.message + \"\\n\" + data.stack;\n+ done = true;\n } else if (data.type ...
2014-02-16T17:54:40
electron/electron
8060b0966fcc93bbf64da0edbe586f210cb11411
487a195320c8f33f5e441f4b8ece8af882ae6b6b
:bug: #8919 - fix typo
[ { "path": "docs/development/build-instructions-linux.md", "patch": "@@ -117,7 +117,7 @@ To clean the build files:\n $ npm run clean\n ```\n \n-To clean only `out` and `dir` directories:\n+To clean only `out` and `dist` directories:\n \n ```bash\n $ npm run clean-build", "additions": 1, "deletions": ...
2017-03-17T18:47:20
golang/go
f21514c7f8c972ce2291d41cf5b6263f0eb350c7
ddc93a536faf4576d182cd3197b116d61d05c484
cmd/compile: only inline method wrapper if method don't contain closures CL 327871 changes methodWrapper to always perform inlining after global escape analysis. However, inlining the method may reveal closures, which require walking all function bodies to decide whether to capture free variables by value or by ref. ...
[ { "path": "src/cmd/compile/internal/reflectdata/reflect.go", "patch": "@@ -1904,14 +1904,14 @@ func methodWrapper(rcvr *types.Type, method *types.Field, forItab bool) *obj.LSy\n \t// the TOC to the appropriate value for that module. But if it returns\n \t// directly to the wrapper's caller, nothing will res...
2022-08-29T03:48:28
nodejs/node
a9b8f707662d4c564f4439b150229635da007ae7
5c91a75acb02d989c89e1d8fa8127c9ab91210e9
doc: some grammar fixes PR-URL: https://github.com/nodejs/node/pull/33081 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
[ { "path": "doc/guides/backporting-to-release-lines.md", "patch": "@@ -31,9 +31,9 @@ release line. All commands will use the `v10.x-staging` branch as the target\n branch. In order to submit a backport pull request to another branch, simply\n replace that with the staging branch for the targeted release line...
2020-04-26T23:03:12
vercel/next.js
fe0d947a66d22bec2ffdbeb834fd76f49a6351e1
c26c10f4c34ae92e2e2b735ada3bed86c7820863
ensure experimental warning shows up when using PPR (#58206) Fixes a bug where when `config.experimental.ppr` was set, we didn't show the proper warning indicator that the feature is experimental.
[ { "path": "packages/next/src/server/config-shared.ts", "patch": "@@ -790,6 +790,7 @@ export const defaultConfig: NextConfig = {\n typedRoutes: false,\n instrumentationHook: false,\n bundlePagesExternals: false,\n+ ppr: false,\n },\n }\n ", "additions": 1, "deletions": 0, "langua...
2023-11-08T16:20:02
facebook/react
0d4213001b654d52c03c5385be52342fd9a84090
1e7bdc79e1f76678ee15b19d40545fc5ac64158d
Fix typo in latest round-up
[ { "path": "docs/_posts/2014-02-15-community-roundup-16.md", "patch": "@@ -47,7 +47,7 @@ It's great to see the React community expand internationally. [This site](http:/\n \n ### React tutorial series\n \n-[Christopher Pitt](https://medium.com/@followchrisp) explains [React Components](https://medium.com/rea...
2014-02-16T06:53:42
electron/electron
487a195320c8f33f5e441f4b8ece8af882ae6b6b
713e2568436e99c21243a39958838933d8dbf131
:bug: #8919 - add new command to the docs
[ { "path": "README.md", "patch": "@@ -1,6 +1,3 @@\n-Attempting to add full kiosk mode functionality on windows 7\n-==\n-\n [![Electron Logo](https://electron.atom.io/images/electron-logo.svg)](https://electron.atom.io/)\n \n [![Travis Build Status](https://travis-ci.org/electron/electron.svg?branch=master)](...
2017-03-17T18:44:18
nodejs/node
eebf52d27950afc271ede949b2ea055c83e1867f
ed87433970438f6597fa125b398c7ef1c3d1caef
n-api: simplify uv_idle wrangling uv_idle_init(), uv_idle_start() and uv_idle_stop() always succeed. Remove the superfluous error handling. Refs: https://github.com/libuv/libuv/pull/2803 PR-URL: https://github.com/nodejs/node/pull/32997 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: David Carlier <devnexe...
[ { "path": "src/node_api.cc", "patch": "@@ -250,8 +250,8 @@ class ThreadSafeFunction : public node::AsyncResource {\n if (max_queue_size > 0) {\n cond = std::make_unique<node::ConditionVariable>();\n }\n- if ((max_queue_size == 0 || cond) &&\n- uv_idle_init(loop, &idle) == 0...
2020-04-22T08:50:08
golang/go
ddc93a536faf4576d182cd3197b116d61d05c484
c22865fcfa1ec434e5655c652c6376fa2d0eb821
cmd/compile: fix unified IR shapifying recursive instantiated types Shape-based stenciling in unified IR is done by converting type argument to its underlying type. So it agressively check that type argument is not a TFORW. However, for recursive instantiated type argument, it may still be a TFORW when shapifying happ...
[ { "path": "src/cmd/compile/internal/base/debug.go", "patch": "@@ -35,6 +35,7 @@ type DebugFlags struct {\n \tPCTab string `help:\"print named pc-value table\\nOne of: pctospadj, pctofile, pctoline, pctoinline, pctopcdata\"`\n \tPanic int `help:\"show all compiler panics\"`\n...
2022-08-29T10:25:32
vercel/next.js
b4ee33e3ec1d42211644a8bedc88f506b2e415dd
cf8a733f6a3ff7ab420b3f5f0eac7e57bd6ca64b
docs: fix typo in composition patterns section (#58197)
[ { "path": "docs/02-app/01-building-your-application/03-rendering/03-composition-patterns.mdx", "patch": "@@ -552,5 +552,5 @@ With this approach, `<ClientComponent>` and `<ServerComponent>` are decoupled an\n \n > **Good to know:**\n >\n-> - The pattern of \"lifting content up\" has been used to avoid re-ren...
2023-11-08T15:30:25
facebook/react
1e7bdc79e1f76678ee15b19d40545fc5ac64158d
d3c12487fd456f79b96c3985fbfbac95a518887c
Upgrade Commoner dependency to v0.9.1 to fix mkdirP bug.
[ { "path": "package.json", "patch": "@@ -32,7 +32,7 @@\n \"url\": \"https://github.com/facebook/react\"\n },\n \"dependencies\": {\n- \"commoner\": \"~0.9.0\",\n+ \"commoner\": \"~0.9.1\",\n \"esprima-fb\": \"~3001.1.0-dev-harmony-fb\",\n \"jstransform\": \"~3.0.0\"\n },", "additi...
2014-02-16T01:49:17
electron/electron
818738ce840be9e6c0463fe43dd40d392b5f6168
85d66d241339351d2d3519cce0153519e9cdd460
:bug: Add toString support to remote functions
[ { "path": "lib/renderer/api/remote.js", "patch": "@@ -175,6 +175,9 @@ const proxyFunctionProperties = function (remoteMemberFunction, metaId, name) {\n return true\n },\n get: (target, property, receiver) => {\n+ if (property === 'toString' && typeof target.toString === 'function') {\n+ ...
2017-03-17T15:21:37
golang/go
67d85ad00f9d9be0cc2bb1bb96d01c3d40dcb376
4381c61c58315dbdb8004bf56e54a5d2aa5d0498
cmd/asm: add new classification for index memory operands on PPC64 When a base+displacement kind of operand is given in an index-mode instruction, the assembler does not flag it as an invalid instruction causing the user to get an incorrect encoding of that instruction leading to incorrect execution of the program. En...
[ { "path": "src/cmd/asm/internal/asm/operand_test.go", "patch": "@@ -473,7 +473,7 @@ var ppc64OperandTests = []operandTest{\n \t{\"(R4)\", \"(R4)\"},\n \t{\"(R5)\", \"(R5)\"},\n \t{\"(R5)(R6*1)\", \"(R5)(R6*1)\"},\n-\t{\"(R5+R6)\", \"(R5)(R6*1)\"}, // Old syntax.\n+\t{\"(R5+R6)\", \"(R5)(R6)\"},\n \t{\"-1(R4...
2022-05-11T15:48:48
nodejs/node
ed87433970438f6597fa125b398c7ef1c3d1caef
37b93256367c7323d3f972d0873f400853121718
doc: fix markdown parsing on doc/api/os.md PR-URL: https://github.com/nodejs/node/pull/33067 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
[ { "path": "doc/api/os.md", "patch": "@@ -389,7 +389,7 @@ operating system response.\n \n Throws a [`SystemError`][] if a user has no `username` or `homedir`.\n \n-## `os.version()`\n+## `os.version()`\n <!-- YAML\n added: v13.11.0\n -->", "additions": 1, "deletions": 1, "language": "Markdown" ...
2020-04-25T22:30:37
vercel/next.js
9d3b94b449e46b820ee91d19efb8bdc306934edd
0563fa77490631911dfed4d20736a441d4089d37
update turbopack (#58172) * https://github.com/vercel/turbo/pull/6376 <!-- OJ Kwon - feat(turbopack): support url rewrite behavior options --> * https://github.com/vercel/turbo/pull/6386 <!-- OJ Kwon - feat(turbopack-ecmascript): support relative url asset ref --> * https://github.com/vercel/turbo/pull/6382 <!-- T...
[ { "path": "Cargo.lock", "patch": "@@ -322,7 +322,7 @@ dependencies = [\n [[package]]\n name = \"auto-hash-map\"\n version = \"0.1.0\"\n-source = \"git+https://github.com/vercel/turbo.git?tag=turbopack-231107.2#c73edeb2fc1eb1ce98193e21b3860a7b178cc156\"\n+source = \"git+https://github.com/vercel/turbo.git?ta...
2023-11-08T07:54:36
golang/go
629ae1cee673c66dd540b424c9e86a4ce3aaf9e3
47f8db368cbb1971f386717ae7c76a1891a6130c
cmd/compile: fix wrong position when rewriting to OpArg/OpArgXXX When spilling arg to stack or register, if it's a newly created value, the arg position should be preserved. Otherwise, we may end up using position information from deadcode lines. This fixes the minimized test case in #54625 by mdempsky@, and make bui...
[ { "path": "src/cmd/compile/internal/ssa/expand_calls.go", "patch": "@@ -1742,7 +1742,7 @@ func (x *expandState) newArgToMemOrRegs(baseArg, toReplace *Value, offset int64,\n \t\t\ttoReplace.Type = t\n \t\t\tw = toReplace\n \t\t} else {\n-\t\t\tw = baseArg.Block.NewValue0IA(pos, OpArg, t, auxInt, aux)\n+\t\t\...
2022-08-26T05:19:50
facebook/react
2013db23d3d75dc9a50caebe5a07d793d4fd8258
e872cd0a7c0e88fa29b0e23f46717c6741c01000
Fix comma splice
[ { "path": "src/vendor/core/invariant.js", "patch": "@@ -30,7 +30,7 @@\n function invariant(condition) {\n if (!condition) {\n var error = new Error(\n- 'Minified exception occured, use the non-minified dev environment for ' +\n+ 'Minified exception occured; use the non-minified dev environme...
2014-02-15T21:58:57
nodejs/node
f68428b695468f9e3159ea7eea1f87be73ae0de1
38146e717fed2fabe3aacb6540d839475e0ce1c6
console: support console constructor groupIndentation option PR-URL: https://github.com/nodejs/node/pull/32964 Fixes: https://github.com/nodejs/node/issues/32947 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
[ { "path": "doc/api/console.md", "patch": "@@ -81,16 +81,19 @@ const { Console } = console;\n ### `new Console(options)`\n <!-- YAML\n changes:\n- - version: v8.0.0\n- pr-url: https://github.com/nodejs/node/pull/9744\n- description: The `ignoreErrors` option was introduced.\n+ - version: REPLACEME\n+...
2020-04-21T09:51:25
vercel/next.js
c91de671eb44c9b5faeb79804b6b6d2268743cd1
dc849bc811c3e7a5c5806b5f68a65235916ca773
refactor and fix CssEmbed for url() (vercel/turbo#6382) ### Description Simplifies CssEmbed and fix the chunking to include references from embedded chunk items ### Testing Instructions <!-- Give a quick description of steps to test your changes. -->
[ { "path": "crates/turbopack-core/src/chunk/mod.rs", "patch": "@@ -150,16 +150,18 @@ pub trait OutputChunk: Asset {\n Copy, Default, Clone, Hash, TraceRawVcs, Serialize, Deserialize, Eq, PartialEq, ValueDebugFormat,\n )]\n pub enum ChunkingType {\n- /// Asset is placed in the same chunk group and is l...
2023-11-08T07:09:01
electron/electron
713e2568436e99c21243a39958838933d8dbf131
3b265747fef74682c26909570181a1673bddccfd
:bug: #8919 - add new command that cleans only out & dist dirs
[ { "path": "package.json", "patch": "@@ -30,6 +30,7 @@\n \"bump-version\": \"./script/bump-version.py\",\n \"build\": \"python ./script/build.py -c D\",\n \"clean\": \"python ./script/clean.py\",\n+ \"clean-build\": \"python ./script/clean-build.py\",\n \"coverage\": \"npm run instrument-c...
2017-03-16T11:34:53
golang/go
7b689dcbefbe5442b8b59a56efc1eced4fce233c
2113fefe7d4ac5634a5b0597ef1b465684c73076
cmd/go/internal/modfetch: distinguish "unsupported" errors from RecentTag CL 426079 started checking errors from RecentTag. Unfortunately, we forgot to run "-longtest" SlowBots, and it turns out to have broken non-short tests for non-git VCS implementations, because those don't implement the RecentTag method. Updates...
[ { "path": "src/cmd/go/internal/modfetch/codehost/codehost.go", "patch": "@@ -201,6 +201,19 @@ func (noCommitsError) Is(err error) bool {\n \treturn err == fs.ErrNotExist\n }\n \n+// ErrUnsupported indicates that a requested operation cannot be performed,\n+// because it is unsupported. This error indicates ...
2022-08-29T20:27:00
nodejs/node
38146e717fed2fabe3aacb6540d839475e0ce1c6
0694401da3b647b6089e5dd96e58f25530fd3b10
crypto: check DiffieHellman p and g params It's possible to pass in the prime and generator params as buffers but that mode of input wasn't as rigorously checked as numeric input. PR-URL: https://github.com/nodejs/node/pull/32739 Fixes: https://github.com/nodejs/node/issues/32738 Reviewed-By: Colin Ihrig <cjihrig@gma...
[ { "path": "src/node_crypto.cc", "patch": "@@ -5136,6 +5136,14 @@ bool DiffieHellman::Init(int primeLength, int g) {\n \n bool DiffieHellman::Init(const char* p, int p_len, int g) {\n dh_.reset(DH_new());\n+ if (p_len <= 0) {\n+ BNerr(BN_F_BN_GENERATE_PRIME_EX, BN_R_BITS_TOO_SMALL);\n+ return false;...
2020-04-10T10:42:22
vercel/next.js
ccd6c4b2df5484baf0b0176ae8b806b7d0f06ee4
7e368c2e1f1d4294086e9e71b688dc3f6ae333cd
Fix resume stream handling (#58159) Ensures we don't await un-necessarily.
[ { "path": "packages/next/src/server/app-render/app-render.tsx", "patch": "@@ -611,12 +611,11 @@ async function renderToHTMLOrFlightImpl(\n \n const hasPostponed = typeof renderOpts.postponed === 'string'\n \n- let stringifiedFlightPayloadPromise =\n- isStaticGeneration || hasPostponed\n- ? genera...
2023-11-08T02:36:11
facebook/react
f66f8f03102d6af083890d11dbeff7dd02db093e
9ba014fbf10c4720a1f329a5929ec801e6588982
Pull in syranides jsx whitespace codemod transform fixes
[ { "path": "npm-jsx_whitespace_transform/transforms/react.js", "patch": "@@ -18,35 +18,31 @@\n var Syntax = require('esprima-fb').Syntax;\n var utils = require('jstransform/src/utils');\n \n-var renderXJSExpressionContainer =\n- require('./xjs').renderXJSExpressionContainer;\n-var renderXJSLiteral = require...
2014-02-15T19:20:32
electron/electron
2e0e4e69bba270c05ea793442546312eed47e95c
6175ee05e23619be2e7a3d98a7f5bf396fb28f05
Drop on prefix from property names
[ { "path": "docs/api/touch-bar-scrubber.md", "patch": "@@ -1,16 +1,16 @@\n ## Class: TouchBarScrubber\n \n-> Create a scrubber (a scrollablbe selector)\n+> Create a scrubber (a scrollable selector)\n \n Process: [Main](../tutorial/quick-start.md#main-process)\n \n ### `new TouchBarScrubber(options)`\n \n * `...
2017-03-14T21:02:48
golang/go
36d1f236610a436bcbceca11e040a65593f1f253
f3a1f9220a8a5265842f5cb877c4dc6d08f75c68
debug/macho: use saferio to allocate Load and Symbol slices Avoid allocating large amounts of memory for corrupt input. No test case because the problem can only happen for invalid data. Let the fuzzer find cases like this. Change-Id: I2d1745200611f0af06ca58adcc3e2309ad6742d8 Reviewed-on: https://go-review.googlesou...
[ { "path": "src/debug/macho/file.go", "patch": "@@ -253,9 +253,13 @@ func NewFile(r io.ReaderAt) (*File, error) {\n \tif _, err := r.ReadAt(dat, offset); err != nil {\n \t\treturn nil, err\n \t}\n-\tf.Loads = make([]Load, f.Ncmd)\n+\tc := saferio.SliceCap([]Load{}, uint64(f.Ncmd))\n+\tif c < 0 {\n+\t\treturn...
2022-08-27T03:12:26
nodejs/node
0694401da3b647b6089e5dd96e58f25530fd3b10
6fdced46db1e86728705b525dc0d2d49c214494e
crypto: generator must be int32 in DiffieHellman() Validate the generator argument in `crypto.createDiffieHellman(key, g)`. When it's a number, it should be an int32. Fixes: https://github.com/nodejs/node/issues/32748 PR-URL: https://github.com/nodejs/node/pull/32739 Fixes: https://github.com/nodejs/node/issues/3273...
[ { "path": "lib/internal/crypto/diffiehellman.js", "patch": "@@ -77,7 +77,9 @@ function DiffieHellman(sizeOrKey, keyEncoding, generator, genEncoding) {\n \n if (!generator)\n generator = DH_GENERATOR;\n- else if (typeof generator !== 'number')\n+ else if (typeof generator === 'number')\n+ validate...
2020-04-10T10:42:22
vercel/next.js
baf0b2419c66913c968679ab2ab50469d3cecd27
fe99b53d7f2ea8c2f2abcae9d9707de99aa6cc15
fix: rsc normalization fixes (#58145) Co-authored-by: Zack Tanner <1939140+ztanner@users.noreply.github.com>
[ { "path": "packages/next/src/server/base-server.ts", "patch": "@@ -405,10 +405,10 @@ export default abstract class Server<ServerOptions extends Options = Options> {\n protected readonly localeNormalizer?: LocaleRouteNormalizer\n \n protected readonly normalizers: {\n- readonly postponed: PostponedPat...
2023-11-08T01:50:39
facebook/react
d71736b3ed665d1ffcd0c34a55510ce266a30eb2
529c971db335f24480e238612d477fa33c9607c0
include mixin keys whose values are falsy the previous behavior is to skip mixin keys whose values are `undefined`, `null`, `''` and (this is a bug) 0. Now, every key is included.
[ { "path": "src/core/ReactCompositeComponent.js", "patch": "@@ -445,7 +445,7 @@ function mixSpecIntoComponent(ConvenienceConstructor, spec) {\n var proto = Constructor.prototype;\n for (var name in spec) {\n var property = spec[name];\n- if (!spec.hasOwnProperty(name) || !property) {\n+ if (!sp...
2014-02-14T23:36:04
golang/go
f3a1f9220a8a5265842f5cb877c4dc6d08f75c68
c108a682ff4571d1fd45e9c05cfad7b9a6c86a3d
testing: explain using a _test package The existing documentation did not explain the difference between placing a _test.go file in the same package as what is being tested vs. adding it to a separate _test package. This explains the distinction and adds an example. Concept is explained well here: https://stackoverf...
[ { "path": "src/testing/testing.go", "patch": "@@ -14,12 +14,19 @@\n // Within these functions, use the Error, Fail or related methods to signal failure.\n //\n // To write a new test suite, create a file whose name ends _test.go that\n-// contains the TestXxx functions as described here. Put the file in the...
2022-08-27T23:02:31
vercel/next.js
9aefe525bf5ba7aa128ee6e4cb51e3e88c0ed841
d3756fac5d51d3fede59c28f9e607568a397f8ae
fix PPR build output logs (#58149) Fixes two build output logs: - A page that uses `generateStaticParams` & postpones should be marked as partially prerendered - Assume pages that contain dynamic segments will postpone when PPR is enabled even though it won't be determined until request time
[ { "path": "packages/next/src/build/index.ts", "patch": "@@ -2301,6 +2301,13 @@ export default async function build(\n hasEmptyPrelude,\n })\n \n+ // update the page (eg /blog/[slug]) to also have the postpone metadata\n+ pageInfos.set(page, {\n+ ...
2023-11-07T22:09:55
golang/go
dbd0ce84d7c1da2e788c516c72fef44d5b760337
59bdbb3effe3e61f85e336a52323024bafaf44bd
debug/elf: validate offset and file size ranges Change-Id: Iebe31b91c6e81438120f50a8089a8efca3d5339d Reviewed-on: https://go-review.googlesource.com/c/go/+/426115 Run-TryBot: Dan Kortschak <dan@kortschak.io> Run-TryBot: Ian Lance Taylor <iant@google.com> Reviewed-by: Ian Lance Taylor <iant@google.com> Reviewed-by: Hes...
[ { "path": "src/debug/elf/file.go", "patch": "@@ -377,6 +377,12 @@ func NewFile(r io.ReaderAt) (*File, error) {\n \t\t\t\tAlign: ph.Align,\n \t\t\t}\n \t\t}\n+\t\tif int64(p.Off) < 0 {\n+\t\t\treturn nil, &FormatError{off, \"invalid program header offset\", p.Off}\n+\t\t}\n+\t\tif int64(p.Filesz) < 0 {\n+\t...
2022-08-27T03:25:43
facebook/react
b65f5a4d3091cce5838e1eefcc94dc3a336c3ca9
67c5d76321ad04058003ede164eca04817be5bd0
fix tests
[ { "path": "src/addons/transitions/__tests__/ReactCSSTransitionGroup-test.js", "patch": "@@ -58,7 +58,15 @@ describe('ReactCSSTransitionGroup', function() {\n expect(a.getDOMNode().childNodes[1].id).toBe('one');\n \n console.warn = mocks.getMockFunction();\n- setTimeout.mock.calls[2][0]();\n+\n+ ...
2014-02-14T20:55:03
vercel/next.js
9b4b0847ed4a1025e73bec16a9ee11766e632e14
503e1a8c5f3e86072c4225bbc1cd68b82863f7b0
typo: changed from next/server to next/og (#58143) ### Change the `next/server` to `next/og` to support the upgrade to Next 14 - Next 14 users will experience a deprecation warning when trying to import from `next/server` - Not the biggest change, but it caused some confusion while reading <!-- Thanks for ope...
[ { "path": "docs/02-app/02-api-reference/02-file-conventions/01-metadata/opengraph-image.mdx", "patch": "@@ -87,7 +87,7 @@ Generate a route segment's shared image by creating an `opengraph-image` or `twi\n > - By default, generated images are [**statically optimized**](/docs/app/building-your-application/ren...
2023-11-07T17:38:57
golang/go
5cfeaed4dec52c8edb3f33bb9cf8ec98d846c50b
4029124cf4e79ed6f1c6d4cc0a19331eeddd58a6
cmd/go/internal/modfetch: report error on failing to derive pseudo version from recent tag The current implementation ignores the error when it tries to get the recent tag on revisions, which results in incorrect pseudo version (v0.0.0-) is derived. Fixes #53935 Change-Id: I153d851eb913fb7e40051e194c92b9ca5bf0e906 G...
[ { "path": "src/cmd/go/internal/modfetch/coderepo.go", "patch": "@@ -607,7 +607,10 @@ func (r *codeRepo) convert(info *codehost.RevInfo, statVers string) (*RevInfo, e\n \t\treturn !isRetracted(v)\n \t}\n \tif pseudoBase == \"\" {\n-\t\ttag, _ := r.code.RecentTag(info.Name, tagPrefix, tagAllowed)\n+\t\ttag, e...
2022-08-27T02:42:52
facebook/react
123ed1f4425230aa336a7ea616064e8cdbd9dfd9
31bc18d39e1c194fcd451e48964c9813b9993d27
Fix IE8 bug during unitless CSS props creation IE8 goes into an infinite loop if we add props to the obj we're iterating through.
[ { "path": "src/browser/dom/CSSProperty.js", "patch": "@@ -53,11 +53,14 @@ function prefixKey(prefix, key) {\n * of vendor prefixes.\n */\n var prefixes = ['Webkit', 'ms', 'Moz', 'O'];\n-for (var k in isUnitlessNumber) {\n+\n+// Using Object.keys here, or else the vanilla for-in loop makes IE8 go into an\n...
2014-02-14T20:04:00
electron/electron
b67c81226c05856b09cef9b5066a0d74e23ff424
85c48a23368317bc134c938876d5515abab17349
fix linting
[ { "path": "docs/api/remote.md", "patch": "@@ -159,7 +159,7 @@ project/\n ```js\n // main process: main/index.js\n const { app } = require('electron')\n-app.on('ready', () => {/* ... */})\n+app.on('ready', () => { /* ... */ })\n ```\n \n ```js", "additions": 1, "deletions": 1, "language": "Markdo...
2017-03-14T17:48:44
vercel/next.js
e65d4a1be3212f99fc322233742239c9dbe850d4
c370c179b50fb09c6cb1f2a3b2c81c3302504c2b
fix(next-core): correct assets url reference condition (#58101) ### What Corrects how urlassetreference reads its assets path to allow to resolve image assets correctly. There is a test failure in the integration/url still, that involves probably larger refactoring so making this PR first to enable baseline, ensure ...
[ { "path": "packages/next-swc/crates/next-core/src/next_shared/transforms/mod.rs", "patch": "@@ -23,23 +23,29 @@ use turbopack_binding::turbopack::{\n \n use crate::next_image::{module::BlurPlaceholderMode, StructuredImageModuleType};\n \n-/// Returns a rule which applies the Next.js dynamic transform.\n pub...
2023-11-07T16:12:41