instance_id stringlengths 21 53 | repo stringclasses 188
values | language stringclasses 1
value | pull_number int64 20 148k | title stringlengths 6 144 | body stringlengths 0 83.4k | created_at stringdate 2015-09-25 03:17:17 2025-07-10 16:50:35 | problem_statement stringlengths 188 240k | hints_text stringlengths 0 145k | resolved_issues listlengths 1 6 | base_commit stringlengths 40 40 | commit_to_review dict | reference_review_comments listlengths 1 62 | merged_commit stringlengths 40 40 | merged_patch stringlengths 297 9.87M | metadata dict |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
cookiecutter__cookiecutter-django-3043@002b3ea | cookiecutter/cookiecutter-django | Python | 3,043 | Update to Django 3.1 | ## Description
Django dependencies upgrade.
Checklist:
- [X] I've made sure that `tests/test_cookiecutter_generation.py` is updated accordingly (especially if adding or updating a template option)
- [X] I've updated the documentation or confirm that my change doesn't require any updates
## Rationale
Fix... | 2021-02-04T14:43:56Z | Django 3.1
I haven't seen anyone asked this question yet. So I'll go first. Is it ok now to upgrade to django 3.1.x?
Another newbie question: beside the tests that I wrote, is there any other test that I could run to make sure the django-cookiecutter on my computer works with django 3.1.1?
Thank you. | I did some research. The very first one was djangorestframework only supports upto django 3.0. Case closed. Sorry about this.
https://www.django-rest-framework.org
Seems latest DRF support Django 3.1. Any plan for go with Django 3.1?
@browniebroke
many packages already update to Django 3.1 support, can regenerate t... | [
{
"body": "I haven't seen anyone asked this question yet. So I'll go first. Is it ok now to upgrade to django 3.1.x?\r\n\r\nAnother newbie question: beside the tests that I wrote, is there any other test that I could run to make sure the django-cookiecutter on my computer works with django 3.1.1?\r\n\r\nThank y... | e4ce5c5f2a66957bb0237f4b9f5038e3ab9f8fc9 | {
"head_commit": "002b3eaf4100c02d9045f5953157754699e60777",
"head_commit_message": "Update Django 3.0.11 to 3.1.6",
"patch_to_review": "diff --git a/tests/test_docker.sh b/tests/test_docker.sh\nindex 740f8fc223..f6df6b8ab1 100755\n--- a/tests/test_docker.sh\n+++ b/tests/test_docker.sh\n@@ -30,4 +30,4 @@ docker-c... | [
{
"diff_hunk": "@@ -29,7 +29,7 @@ uvicorn[standard]==0.13.3 # https://github.com/encode/uvicorn\n \n # Django\n # ------------------------------------------------------------------------------\n-django==3.0.11 # pyup: < 3.1 # https://www.djangoproject.com/\n+django==3.1.6 # pyup: < 3.1 # https://www.django... | 4e96b6426108793571181743a42492e52169ef15 | diff --git a/README.rst b/README.rst
index dbc510a477..ae86995037 100644
--- a/README.rst
+++ b/README.rst
@@ -40,7 +40,7 @@ production-ready Django projects quickly.
Features
---------
-* For Django 3.0
+* For Django 3.1
* Works with Python 3.8
* Renders Django projects with 100% starting test coverage
* Twitte... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Dependency Updates & Env Compatibility"
} |
ccxt__ccxt-18502@c8cfcb5 | ccxt/ccxt | Python | 18,502 | Bybit: fetchMarkets, add ETH and SOL option markets | Added support for ETH and SOL option markets to Bybit fetchMarkets:
fixes: #18471
```
bybit.fetchMarkets ()
2023-07-09T04:25:46.480Z iteration 0 passed in 855 ms
id | symbol | base | quote | settle | baseId | quoteId | settleId | type | spot | margin | sw... | 2023-07-09T04:45:16Z | Bybit USDC options: ETH and SOL
###
Programming Language version: Python 3.11
CCXT version: 4.0.8
Hi,
I would like to get informations from USDC options on Bybit.
So I set `exchange.options['defaultType'] = 'option'` and after I get markets with `exchange.load_markets()`
When I list markets `exchange.marke... | Another thing, for the initialization of the Bybit object, defaultType doesn't work:
```
import ccxt.asyncio as ccxt
ccxt.bybit({'apiKey': APIKEY', 'secret': SECRET', 'defaultType': 'option', })
```
When you call `options['defaultType']`, it's `swap`
But if you set the defaultType after initialization, it works.
... | [
{
"body": "### \n\nProgramming Language version: Python 3.11\r\nCCXT version: 4.0.8\r\n\r\nHi, \r\n\r\nI would like to get informations from USDC options on Bybit.\r\nSo I set `exchange.options['defaultType'] = 'option'` and after I get markets with `exchange.load_markets()`\r\nWhen I list markets `exchange.ma... | ecba150f10d1c0a156650ccde4f02ab00d020d19 | {
"head_commit": "c8cfcb5fb0cc194f47abd279d0fae5744a1c4dc3",
"head_commit_message": "add 'loadExpiredOptions' setting\n\nAdded a loadExpiredOptions setting to load expired options contracts when it is set to true",
"patch_to_review": "diff --git a/ts/src/bybit.ts b/ts/src/bybit.ts\nindex 5232dc4f20bb0..ca13c1c6e3... | [
{
"diff_hunk": "@@ -1766,6 +1711,192 @@ export default class bybit extends Exchange {\n return result;\n }\n \n+ async fetchOptionMarkets (params) {\n+ const request = {\n+ 'category': 'option',\n+ };\n+ const response = await this.publicGetV5MarketInstrumentsInfo ... | d5a7c12ebc11070524ebb2d485451eb63714bfec | diff --git a/ts/src/bybit.ts b/ts/src/bybit.ts
index 5232dc4f20bb0..86bc49b9408be 100644
--- a/ts/src/bybit.ts
+++ b/ts/src/bybit.ts
@@ -1091,6 +1091,8 @@ export default class bybit extends Exchange {
'recvWindow': 5 * 1000, // 5 sec default
'timeDifference': 0, // the difference betwe... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
cookiecutter__cookiecutter-django-2920@21b78d1 | cookiecutter/cookiecutter-django | Python | 2,920 | Fix docs service and add RTD support | <!-- Thank you for helping us out: your efforts mean a great deal to the project and the community as a whole! -->
Fixes #2733
Closes #2878
Closes #2674
Supersedes #2754
## Description
Fix docs service. Added `DATABASE_URL` environment variable inside `conf.py` to force `django.setup()` in both local an... | 2020-11-01T05:05:08Z | RTD Support
## Description
ReadTheDocs support
## Rationale
Hosting an open-source website with documentation
Also somewhat of a bug report because you need a .readthedocs.yml (I think) file in order to pip install the local.txt packages.
## Use case(s) / visualization(s)
Developers for an open-sourc... | More details on the `.readthedocs.yml` file:
https://docs.readthedocs.io/en/stable/config-file/v2.html
Agree that we need to at least configure the requirement file to use, and probably also the python version. Not sure if we can set environment variables to avoid similar issues as in #2674
~~Hm so long as .envs/... | [
{
"body": "## Description\r\n\r\nReadTheDocs support\r\n\r\n## Rationale\r\n\r\nHosting an open-source website with documentation \r\n\r\nAlso somewhat of a bug report because you need a .readthedocs.yml (I think) file in order to pip install the local.txt packages.\r\n\r\n## Use case(s) / visualization(s)\r\n\... | 4b97071cfe83c6ef48b5c383b14b8bbbe15c0cb4 | {
"head_commit": "21b78d15ddaa2cfdfc369355aace21c5d50b48f0",
"head_commit_message": "Move readthedocs config in the right folder",
"patch_to_review": "diff --git a/docs/document.rst b/docs/document.rst\nindex 15a5396e19..a6e6b72f4e 100644\n--- a/docs/document.rst\n+++ b/docs/document.rst\n@@ -15,15 +15,30 @@ If y... | [
{
"diff_hunk": "@@ -14,12 +14,20 @@\n import sys\n import django\n \n-{% if cookiecutter.use_docker == 'y' %}\n-sys.path.insert(0, os.path.abspath(\"/app\"))\n-os.environ.setdefault(\"DATABASE_URL\", \"\")\n-{% else %}\n-sys.path.insert(0, os.path.abspath(\"..\"))\n+if os.getenv(\"READTHEDOCS\", default=False) ... | bd5e459f3eb6cfca07b55d7166953308025efe56 | diff --git a/docs/document.rst b/docs/document.rst
index 15a5396e19..a30979094b 100644
--- a/docs/document.rst
+++ b/docs/document.rst
@@ -15,15 +15,30 @@ If you set up your project to `develop locally with docker`_, run the following
Navigate to port 7000 on your host to see the documentation. This will be opened a... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Documentation Updates"
} |
ccxt__ccxt-18023@7550f73 | ccxt/ccxt | Python | 18,023 | fix(coinex): watchTickers - new watchTickers implementation | There are two issues with the current watchTickers implementation
- it can hit amaximum recursion depth error (Fix #18015)
- if a user calls watchTickers (['BTC/USDT']) and watchTickers (['BTC/USDT', ETH/USDT']) and a new BTC/USDT ticker is received only the first ticker will resolve, when I believe on userland it ... | 2023-05-25T18:03:02Z | CoinEx watchTicker(): maximum recursion depth exceeded while calling a Python object
### Operating System
Ubuntu 20.04.5 LTS
### Programming Languages
python
### CCXT Version
3.1.6
### Description
The problem may occur a few minutes or a few hours after starting the program:
```
2023-05-25 11:37:39,543 ERROR... | [
{
"body": "### Operating System\n\nUbuntu 20.04.5 LTS\n\n### Programming Languages\n\npython\n\n### CCXT Version\n\n3.1.6\n\n### Description\n\nThe problem may occur a few minutes or a few hours after starting the program:\r\n\r\n```\r\n2023-05-25 11:37:39,543 ERROR maximum recursion depth exceeded while callin... | 934173bd4b4ae4426224544b9fa01c6044de34c4 | {
"head_commit": "7550f73fb422ed65633c8f39f40254c4aff96ef2",
"head_commit_message": "new updates fixes",
"patch_to_review": "diff --git a/ts/src/base/Exchange.ts b/ts/src/base/Exchange.ts\nindex 9d4cace870260..54ca210a588d4 100644\n--- a/ts/src/base/Exchange.ts\n+++ b/ts/src/base/Exchange.ts\n@@ -1358,6 +1358,18 ... | [
{
"diff_hunk": "@@ -141,10 +141,21 @@ export default class coinex extends coinexRest {\n const symbol = this.safeSymbol (marketId, undefined, undefined, defaultType);\n const market = this.safeMarket (marketId, undefined, undefined, defaultType);\n const parsedTicker = this.p... | f8555aec42f65dc2cdd783e94499c95a3501bf74 | diff --git a/ts/src/base/Exchange.ts b/ts/src/base/Exchange.ts
index 9d4cace870260..54ca210a588d4 100644
--- a/ts/src/base/Exchange.ts
+++ b/ts/src/base/Exchange.ts
@@ -1358,6 +1358,18 @@ export default class Exchange {
// ------------------------------------------------------------------------
// METHODS BEL... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} | |
cookiecutter__cookiecutter-django-2683@20986ba | cookiecutter/cookiecutter-django | Python | 2,683 | Update requirements to include django-cors-headers with DRF [PR #2650] | ## Description
[//]: # (What's it you're proposing?)
Adding `django_cors_headers` as a part of requirements when a project includes Django REST Framework (DRF). This was brought up in issue #2650.
## Rationale
[//]: # (Why does the project need that?)
Data from DRF usually requires CORS to be consumed.... | 2020-07-17T14:07:02Z | Adding django-cors-headers to requirements if drf selected
## Description
[//]: # (What's it you're proposing? How should it be implemented?)
Adding django-cors-headers to requirements/base.txt if drf is selected in the setup process, having it setup in the settings.
## Rationale
[//]: # (Why should this ... | Would this be adding `django-cors-headers` when `use_drf` is true in `{{cookiecutter.project_slug}}/requirements.base.txt` or would there be more steps involved? I'd like to take this if it's open.
I think that's all we need to do, yes.
Okay, I'll take a look at the guidelines and make a PR. Thanks!
Created a PR here:... | [
{
"body": "## Description\r\n\r\n[//]: # (What's it you're proposing? How should it be implemented?)\r\nAdding django-cors-headers to requirements/base.txt if drf is selected in the setup process, having it setup in the settings.\r\n\r\n\r\n\r\n## Rationale\r\n\r\n[//]: # (Why should this feature be implemented... | d326b219f4d997aa67cde731bf35e72085e44ece | {
"head_commit": "20986bafb7c83a8939c3fbd6bbe7bc1d58b6f032",
"head_commit_message": "Fix style error with quotes",
"patch_to_review": "diff --git a/CONTRIBUTORS.rst b/CONTRIBUTORS.rst\nindex bba9554af4..875ece2eca 100644\n--- a/CONTRIBUTORS.rst\n+++ b/CONTRIBUTORS.rst\n@@ -44,6 +44,7 @@ Listed in alphabetical ord... | [
{
"diff_hunk": "@@ -321,6 +325,12 @@\n ),\n \"DEFAULT_PERMISSION_CLASSES\": (\"rest_framework.permissions.IsAuthenticated\",),\n }\n+\n+# django-cors-headers - https://github.com/adamchainz/django-cors-headers#setup\n+CORS_URLS_REGEX = {\n+ r\"^/api.*$\",\n+}",
"line": null,
"original_line": ... | ff69126087fadc479c50b27d1b1ec3b6b747e68d | diff --git a/CONTRIBUTORS.rst b/CONTRIBUTORS.rst
index bba9554af4..875ece2eca 100644
--- a/CONTRIBUTORS.rst
+++ b/CONTRIBUTORS.rst
@@ -44,6 +44,7 @@ Listed in alphabetical order.
18 `@dezoito`_
2O4 `@2O4`_
a7p `@a7p`_
+ Aadith PM `... | {
"difficulty": "low",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
cookiecutter__cookiecutter-django-2539@25cd8ea | cookiecutter/cookiecutter-django | Python | 2,539 | Add Docker support to Travis and GitLab CI | [//]: # (Thank you for helping us out: your efforts mean great deal to the project and the community as a whole!)
[//]: # (Before you proceed:)
[//]: # (1. Make sure to add yourself to `CONTRIBUTORS.rst` through this PR provided you're contributing here for the first time)
[//]: # (2. Don't forget to update the ... | 2020-04-14T15:54:01Z | Travis + Docker result in broken build on CI
## What happened?
Try to generate a project with Docker and Tarvis enabled, the tarvis config is not suitable and fails the build:
<details>
<summary>Build logs</summary>
```
[0Ktravis_fold:end:install
[0Ktravis_time:start:183a4568
[0K$ pytest
Tracebac... | I reverted the database config referenced by @wandering-tales on #1541.
And added this to .travis.yml
```
before_script:
- psql -c 'create database {{cookiecutter.project_slug}};' -U postgres
```
After making these changes my travis build passed.
I have a version of this that works for gitlab ci. Not su... | [
{
"body": "## What happened?\r\n\r\nTry to generate a project with Docker and Tarvis enabled, the tarvis config is not suitable and fails the build:\r\n\r\n\r\n<details>\r\n <summary>Build logs</summary>\r\n \r\n```\r\n\u001b[0Ktravis_fold:end:install\r\n\u001b[0Ktravis_time:start:183a4568\r\n\u001b[0K$ pytes... | 53b6692b33b2047317348b03c8a3d97bc51b78e6 | {
"head_commit": "25cd8ea72b8dd3e017ddac738373ab64ce934524",
"head_commit_message": "Update beat start files with better? SQL statement",
"patch_to_review": "diff --git a/tests/test_cookiecutter_generation.py b/tests/test_cookiecutter_generation.py\nindex 2c7e6dc43b..8785d7ce19 100755\n--- a/tests/test_cookiecutt... | [
{
"diff_hunk": "@@ -181,7 +181,15 @@ def test_travis_invokes_pytest(cookies, context):\n \n with open(f\"{result.project}/.travis.yml\", \"r\") as travis_yml:\n try:\n- assert yaml.load(travis_yml, Loader=yaml.FullLoader)[\"script\"] == [\"pytest\"]\n+ yml = yaml.load(travis_ym... | d249158444d1cb0f32cbc9cdd6dc868dcc2210d7 | diff --git a/tests/test_cookiecutter_generation.py b/tests/test_cookiecutter_generation.py
index 2c7e6dc43b..ecd08ea0c8 100755
--- a/tests/test_cookiecutter_generation.py
+++ b/tests/test_cookiecutter_generation.py
@@ -170,8 +170,12 @@ def test_black_passes(cookies, context_override):
pytest.fail(e.stdout.deco... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "Test Suite / CI Enhancements"
} |
ccxt__ccxt-17688@0eec3b1 | ccxt/ccxt | Python | 17,688 | woo: update watchOrders price & filled ccxt/ccxt#17652 | fix ccxt/ccxt#17652 | 2023-04-27T10:32:57Z | WooX parse_ws_order incorrect filled quantity
### Operating System
Ubuntu 22.04.1 LTS
### Programming Languages
Python
### CCXT Version
3.0.73
### Description
Here is a quick example from what I received from the watch_orders method (don't mind the json formatting):
```
{
"info": {
"sym... | Additional info:
```
{'info': {'symbol': 'PERP_ETH_USDT', 'clientOrderId': 7056249211750191104, 'orderId': 299266282, 'type': 'LIMIT', 'side': 'BUY', 'quantity': 0.034, 'price': 1850.2, 'tradeId': 276909453, 'executedPrice': 1850.2, 'executedQuantity': 0.02, 'fee': 0.0148016, 'feeAsset': 'USDT', 'totalExecutedQuant... | [
{
"body": "### Operating System\r\n\r\nUbuntu 22.04.1 LTS\r\n\r\n### Programming Languages\r\n\r\nPython\r\n\r\n### CCXT Version\r\n\r\n3.0.73\r\n\r\n### Description\r\n\r\nHere is a quick example from what I received from the watch_orders method (don't mind the json formatting):\r\n\r\n```\r\n{\r\n \"info\": ... | a18852b9eabe6ec6a841fbc4dfd3b34d75bef295 | {
"head_commit": "0eec3b1d78e43fd5d6facf9f290865d7a382bf00",
"head_commit_message": "woo: update watchOrders price & filled",
"patch_to_review": "diff --git a/ts/src/pro/woo.ts b/ts/src/pro/woo.ts\nindex bd34f44558e6c..289aa22cb9163 100644\n--- a/ts/src/pro/woo.ts\n+++ b/ts/src/pro/woo.ts\n@@ -517,11 +517,15 @@ e... | [
{
"diff_hunk": "@@ -517,11 +517,15 @@ export default class woo extends wooRest {\n 'cost': cost,\n 'currency': this.safeString (order, 'feeAsset'),\n };\n- const price = this.safeFloat (order, 'price');\n+ let price = this.safeFloat (order, 'price');",
"line": n... | f4fb29eca6ce69bb5374aef4a2d9ac88c8a6ec4f | diff --git a/ts/src/pro/woo.ts b/ts/src/pro/woo.ts
index bd34f44558e6c..87c83e691b7d2 100644
--- a/ts/src/pro/woo.ts
+++ b/ts/src/pro/woo.ts
@@ -517,11 +517,15 @@ export default class woo extends wooRest {
'cost': cost,
'currency': this.safeString (order, 'feeAsset'),
};
- cons... | {
"difficulty": "low",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
django-cms__django-cms-6380@a079a12 | django-cms/django-cms | Python | 6,380 | Fixed #3734 -- Automated check that PlaceholderFields use Placeholder… | Fixed #3734 -- Automated check that PlaceholderFields use PlaceholderAdminMixin
### Summary
ModelAdmin instances that are using PlaceholderField fields should be also a subclass of PlaceholderAdminMixin
| 2018-05-20T19:44:38Z | Automated check that PlaceholderFields use PlaceholderAdminMixin
Haven't looked into the feasibility of this but would like for the checks framework to detect all models with PlaceholderField, if any of those models are also registered in the admin that the admin class inherits from PlaceholderAdminMixin. It's an error... | That would be a nice addition.
It's definitely feasible by getting all the models with the Django API, checking if any field is a PlaceholderField and then getting the related model from the admin registry and checking the mro() method result
@jsma would you be able to open a pull request that addresses this issue? | [
{
"body": "Haven't looked into the feasibility of this but would like for the checks framework to detect all models with PlaceholderField, if any of those models are also registered in the admin that the admin class inherits from PlaceholderAdminMixin. It's an error to ever do otherwise, so would like this to b... | ede01176a979dbf71a84c28248868e04eeeafa3a | {
"head_commit": "a079a12e8dcf717ef9d2d275b4235c5bbeb3b412",
"head_commit_message": "Fixed #3734 -- Automated check that PlaceholderFields use PlaceholderAdminMixin",
"patch_to_review": "diff --git a/cms/tests/test_check.py b/cms/tests/test_check.py\nindex 4ef57b530c6..18cf890362c 100644\n--- a/cms/tests/test_che... | [
{
"diff_hunk": "@@ -343,6 +343,35 @@ def get_class(method_name, model):\n 'https://django-cms.readthedocs.io/en/latest/extending_cms/extending_page_title.html#handling-relations.') # noqa\n \n \n+@define_check\n+def check_placeholder_mixin(output):\n+ \"\"\"\n+ ModelAdm... | a8e658dd2ce5cb4dae302bfcdfe6fc188af7a572 | diff --git a/cms/tests/test_check.py b/cms/tests/test_check.py
index 0305d9dc546..715aa13a4ae 100644
--- a/cms/tests/test_check.py
+++ b/cms/tests/test_check.py
@@ -3,6 +3,7 @@
from django.conf import settings
from django.core.exceptions import ImproperlyConfigured
from django.test import TestCase
+from django.test.... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Test Suite / CI Enhancements"
} |
ccxt__ccxt-18674@8408c95 | ccxt/ccxt | Python | 18,674 | ContractUnavailable error type | fixes: #10256
- add `ContractUnavailable` error type which extends `InvalidOrder`
- export error type `NoChange` from errors
- change error type to `ContractUnavailable` for okx errors with codes `51030` (Funding fee is being settled), 51021, 51022, 51027, 51028, and 51029 | 2023-07-27T00:05:48Z | [okex] incorrect error mapping
`BadSymbol: okex5 {"code":"1","data":[{"clOrdId":"ddd","ordId":"","sCode":"51030","sMsg":"Funding fee is being settled.","tag":""}],"msg":""}`
When placing a futures order during the settlement period I see the following error. I don't think BadSymbol is quite right, though I'm sure s... | @npomfret this is probably a new class of exceptions under InvalidOrder, because it's not really a maintenance thing, it's a settlement thing, we will think of how to handle it better or what would be a better exception type for it. Your suggestions are welcome:
- https://github.com/ccxt/ccxt/blob/master/js/base/err... | [
{
"body": "`BadSymbol: okex5 {\"code\":\"1\",\"data\":[{\"clOrdId\":\"ddd\",\"ordId\":\"\",\"sCode\":\"51030\",\"sMsg\":\"Funding fee is being settled.\",\"tag\":\"\"}],\"msg\":\"\"}`\r\n\r\nWhen placing a futures order during the settlement period I see the following error. I don't think BadSymbol is quite ri... | 38084a9dcea71022b234acb169dd85d7184bc2ea | {
"head_commit": "8408c956c2826767d9f8003f3cf6f3f7c78ba5ad",
"head_commit_message": "add ContractSettled error",
"patch_to_review": "diff --git a/ts/src/base/errorHierarchy.ts b/ts/src/base/errorHierarchy.ts\nindex 23356c4624727..7d2f2e55a874f 100644\n--- a/ts/src/base/errorHierarchy.ts\n+++ b/ts/src/base/errorHi... | [
{
"diff_hunk": "@@ -553,7 +553,7 @@ export default class okx extends Exchange {\n '51027': BadSymbol, // Contract expired\n '51028': BadSymbol, // Contract under delivery\n '51029': BadSymbol, // Contract is being settled\n- '51030':... | 7646a0c647a0453fbfeb19c9e2008c08ded7024a | diff --git a/ts/src/base/errorHierarchy.ts b/ts/src/base/errorHierarchy.ts
index 23356c4624727..c1b88c16637ff 100644
--- a/ts/src/base/errorHierarchy.ts
+++ b/ts/src/base/errorHierarchy.ts
@@ -26,6 +26,7 @@ const errorHierarchy = {
'OrderImmediatelyFillable': {},
'OrderNotFillable': {}... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
ccxt__ccxt-17219@d1901ed | ccxt/ccxt | Python | 17,219 | parseDepositAddresses undefined result fix [ci deploy] | fixes: #17209
fixes: #17216
**TypeScript**
```
% huobi fetchDepositAddress USDT
2023-03-16T19:24:14.209Z
Node.js: v18.9.0
CCXT v3.0.15
huobi.fetchDepositAddress (USDT)
2023-03-16T19:24:19.882Z iteration 0 passed in 397 ms
{
currency: 'USDT',
address: 'TFqAnCgT6aHJNUUWGMMpdj5jAnqCgHPe... | 2023-03-16T19:53:20Z | [huobi, okx] Can't fetch deposit address
### Operating System
linux, windows
### Programming Languages
JS
### CCXT Version
3.0.11
### Description
Dear fellows,
since around 2.9.16 a few exchanges can't get deposit addresses.
Please take a look, thanks!
### Code
```Javascript
this.exchange = new ccxt[thi... | [
{
"body": "### Operating System\n\nlinux, windows\n\n### Programming Languages\n\nJS\n\n### CCXT Version\n\n3.0.11\n\n### Description\n\nDear fellows,\r\nsince around 2.9.16 a few exchanges can't get deposit addresses.\r\n\r\nPlease take a look, thanks!\r\n\n\n### Code\n\n```Javascript\r\nthis.exchange = new cc... | 52e1aeb36db1541aadd47f37beb5d8949e28d906 | {
"head_commit": "d1901ede241eb034ee3148d89ed1fddf38d6aed1",
"head_commit_message": "parseDepositAddresses undefined result fix",
"patch_to_review": "diff --git a/ts/src/base/Exchange.ts b/ts/src/base/Exchange.ts\nindex 0e997acc83e15..638d3d4d4982a 100644\n--- a/ts/src/base/Exchange.ts\n+++ b/ts/src/base/Exchange... | [
{
"diff_hunk": "@@ -3566,16 +3566,15 @@ export default class Exchange {\n }\n \n parseDepositAddresses (addresses, codes = undefined, indexed = true, params = {}) {\n- let result = undefined;\n+ let result: any[] | {} = [];",
"line": null,
"original_line": 3569,
"original_start... | 3cf0612f672c4bd3c5286b08d2bc1e5a735f4879 | diff --git a/ts/src/base/Exchange.ts b/ts/src/base/Exchange.ts
index 0e997acc83e15..c3a7f6dbe249e 100644
--- a/ts/src/base/Exchange.ts
+++ b/ts/src/base/Exchange.ts
@@ -3566,15 +3566,17 @@ export default class Exchange {
}
parseDepositAddresses (addresses, codes = undefined, indexed = true, params = {}) {
-... | {
"difficulty": "low",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
cookiecutter__cookiecutter-django-2457@ebbdb16 | cookiecutter/cookiecutter-django | Python | 2,457 | Add option to serve media files locally using nginx | ## Description
This PR proposes an example solution to issue #2449.
It allows selecting a local nginx instance to serve media files.
This is just a bare bones implementation that could serve as a base for serving media files.
I added an nginx container. This container has a volume mapped where django stores ... | 2020-02-23T00:46:07Z | Serving media files without an external service
## Description
Currently, in order to serve media files, you need an external file storage service. Setting up an external file storage service introduces some complexity (especially for people who do not already use these services), as well as potentially extra costs. E... | Hello how about just setting up whitenoise to serve your files? Its more simpler as compared to coming up with an inbuilt configuration.
Are we talking about static files or media files? These are 2 different things, static files are part of your code while media files are more the one that are created in the lifetime ... | [
{
"body": "## Description\r\nCurrently, in order to serve media files, you need an external file storage service. Setting up an external file storage service introduces some complexity (especially for people who do not already use these services), as well as potentially extra costs. Even though it is a proper w... | 52bdda5bc05a35f8b0c326b1f2a4fbd4f212f2bf | {
"head_commit": "ebbdb1655722cca11b4e33881c055995650dc084",
"head_commit_message": "Use nginx to serve media files if cloud provider is None",
"patch_to_review": "diff --git a/README.md b/README.md\nindex 0697862c5b..8eb3fbe19c 100644\n--- a/README.md\n+++ b/README.md\n@@ -29,7 +29,7 @@ production-ready Django p... | [
{
"diff_hunk": "@@ -492,10 +492,6 @@ def main():\n )\n \n if \"{{ cookiecutter.cloud_provider }}\" == \"None\":\n- print(\n- WARNING + \"You chose not to use a cloud provider, \"\n- \"media files won't be served in production.\" + TERMINATOR\n- )",
"line": nul... | 68880392be42d87e205de4e5bfe23fa4285a45bf | diff --git a/README.md b/README.md
index 7ab0b7e152..aaeb25828b 100644
--- a/README.md
+++ b/README.md
@@ -31,7 +31,7 @@ production-ready Django projects quickly.
- Optional basic ASGI setup for Websockets
- Optional custom static build using Gulp or Webpack
- Send emails via [Anymail](https://github.com/anyma... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
ccxt__ccxt-17100@dc043ab | ccxt/ccxt | Python | 17,100 | Bybit: update stopLoss and takeProfit | Updated createContractV3Order and createUnifiedAccountOrder, stopLoss and takeProfit orders to follow the current recommended schema:
#13822
fixes: #16856
### stop type 1:
```
node examples/js/cli bybit createOrder ETH/USDT:USDT limit buy 0.03 1800 '{"stopPrice":1900}'
{
info: { orderId: 'a46bd231-c63e-4d4... | 2023-03-09T03:49:06Z | TakeProfit and StopLoss are not working
###
OS = Win 10
LANGUAGE = PYTHON
CCXT version = i didn't really understand how to get it
My question is, what's the proper way to set stop loss and take profit?
exchange = bybit
also why all the attributes of the dictionary order are none?
Thx in advance
... | Look at https://github.com/ccxt/ccxt/issues/13822
hi, i have a same problem,
TakeProfit and StopLoss are not working in bybit when create order
> hi, i have a same problem, TakeProfit and StopLoss are not working in bybit when create order
@Dan-krm It looks like you added bybit takeProfit and stopLoss (https://g... | [
{
"body": "### \r\n\r\nOS = Win 10\r\n\r\nLANGUAGE = PYTHON\r\n\r\nCCXT version = i didn't really understand how to get it \r\n\r\nMy question is, what's the proper way to set stop loss and take profit?\r\n\r\nexchange = bybit\r\n\r\nalso why all the attributes of the dictionary order are none?\r\n\r\nThx in a... | 25ce517b655cb91c7324b59c2d3657542da3e7ef | {
"head_commit": "dc043abef3cc898abb98d15a5021716d136e609a",
"head_commit_message": "feat(Bybit): update createContractV3Order and createUnifiedAccountOrder stopLoss and takeProfit orders with current unified approach\n\nUpdated createContractV3Order and createUnifiedAccountOrder, stopLoss and takeProfit orders to ... | [
{
"diff_hunk": "@@ -3718,20 +3734,36 @@ module.exports = class bybit extends Exchange {\n } else if (timeInForce === 'ioc') {\n request['timeInForce'] = 'ImmediateOrCancel';\n }\n- const triggerPrice = this.safeValue2 (params, 'stopPrice', 'triggerPrice');\n- const stop... | 8bf9f30a7a0e5b1d5ebf222892a627af8b8eb7a5 | diff --git a/js/bybit.js b/js/bybit.js
index 0d99e4346b68f..a88fa8e19a6c5 100644
--- a/js/bybit.js
+++ b/js/bybit.js
@@ -3362,6 +3362,10 @@ module.exports = class bybit extends Exchange {
* @method
* @name bybit#createOrder
* @description create a trade order
+ * @see https://bybit... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ccxt__ccxt-16729@284cdce | ccxt/ccxt | Python | 16,729 | huobi - fix balance | fix #16543 | 2023-02-03T07:57:12Z | Huobi fetchBalance of linear error 4002
### Operating System
Windows 10
### Programming Languages
JS
### CCXT Version
2.2.62
### Description
I am trying to fetch Huobi futures account balance and catch error
`
ExchangeError: Huobi {"status":"error","err_code":4002,"err_msg":"The merged cross an... | Hello @Mnemon1k, can you please share a verbose (request+response) complete log?
This?
```
/Users/alex/dev/bot/node_modules/ccxt/js/huobi.js:5742
throw new ExchangeError (feedback);
^
ExchangeError: huobi {"status":"error","err_code":4002,"err_msg":"The merged cross and iso... | [
{
"body": "### Operating System\r\n\r\nWindows 10\r\n\r\n### Programming Languages\r\n\r\nJS\r\n\r\n### CCXT Version\r\n\r\n2.2.62\r\n\r\n### Description\r\n\r\nI am trying to fetch Huobi futures account balance and catch error\r\n\r\n`\r\nExchangeError: Huobi {\"status\":\"error\",\"err_code\":4002,\"err_msg\"... | ec5909917e8ca741c3b44762b28bbb85a315b772 | {
"head_commit": "284cdceed38f569f8670db7bc561eeecf4727efa",
"head_commit_message": "move lines",
"patch_to_review": "diff --git a/js/huobi.js b/js/huobi.js\nindex 23aa527ee5ade..2966bb7cb0ebc 100644\n--- a/js/huobi.js\n+++ b/js/huobi.js\n@@ -2929,7 +2929,6 @@ module.exports = class huobi extends Exchange {\n ... | [
{
"diff_hunk": "@@ -2943,23 +2942,20 @@ module.exports = class huobi extends Exchange {\n params = this.omit (params, [ 'defaultSubType', 'subType' ]);\n const isolated = (marginMode === 'isolated');\n const cross = (marginMode === 'cross');\n- if (spot) {\n- if (isolat... | 4353dd95daa635fbaec2ff51a5221191e25c1980 | diff --git a/js/huobi.js b/js/huobi.js
index 23aa527ee5ade..8e997da94320f 100644
--- a/js/huobi.js
+++ b/js/huobi.js
@@ -2929,7 +2929,6 @@ module.exports = class huobi extends Exchange {
const options = this.safeValue (this.options, 'fetchBalance', {});
const request = {};
let method = undefi... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ccxt__ccxt-16619@e6aa060 | ccxt/ccxt | Python | 16,619 | kucoinfutures stopPrice order bug fix | Previously trigger orders were being triggered immediately, because the parameter `stop` was set to the opposite value that it should have been set to
fixes: #16442
----------------------------------
## Testing
```
% kucoinfutures createOrder BTC/USDT:USDT market buy 1 undefined '{"stopPrice": "22951"}'
D... | 2023-01-24T17:07:24Z | Kucoin Futures - 'stopPrice'/'triggerPrice' argument not working
### Operating System
Windows 10
### Programming Languages
python
### CCXT Version
2.5.89
### Description
Currently I am unable to place a stop market order, as the code below when either using "stopPrice" or "triggerPrice" it immediat... | [
{
"body": "### Operating System\r\n\r\nWindows 10\r\n\r\n### Programming Languages\r\n\r\npython\r\n\r\n### CCXT Version\r\n\r\n2.5.89\r\n\r\n### Description\r\n\r\nCurrently I am unable to place a stop market order, as the code below when either using \"stopPrice\" or \"triggerPrice\" it immediately triggers t... | 00a098fe08771ab63736bb381e5b56604c9a82da | {
"head_commit": "e6aa060866db7e99e82499d20bf47c263c0f9edc",
"head_commit_message": "kucoinfutures stopPrice order bug fix, fixes: #16442",
"patch_to_review": "diff --git a/js/kucoinfutures.js b/js/kucoinfutures.js\nindex cdb0bcbd60e0a..6f0ea65009609 100644\n--- a/js/kucoinfutures.js\n+++ b/js/kucoinfutures.js\n@... | [
{
"diff_hunk": "@@ -1068,28 +1068,20 @@ module.exports = class kucoinfutures extends kucoin {\n const takeProfitPrice = this.safeValue (params, 'takeProfitPrice');\n const isStopLoss = stopLossPrice !== undefined;\n const isTakeProfit = takeProfitPrice !== undefined;\n- const stop... | 14a95d1f3e445f043f6ce9273b0dac16c2dc561c | diff --git a/js/kucoinfutures.js b/js/kucoinfutures.js
index cdb0bcbd60e0a..640819a53bdc4 100644
--- a/js/kucoinfutures.js
+++ b/js/kucoinfutures.js
@@ -1030,18 +1030,18 @@ module.exports = class kucoinfutures extends kucoin {
* @param {float} amount the amount of currency to trade
* @param {float} ... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} | |
cookiecutter__cookiecutter-django-2252@9fffafc | cookiecutter/cookiecutter-django | Python | 2,252 | Fix #2249 -- Broken static files with whitenoise=n & cloud_prov… | [//]: # (Thank you for helping us out: your efforts mean great deal to the project and the community as a whole!)
[//]: # (Before you proceed:)
[//]: # (1. Make sure to add yourself to `CONTRIBUTORS.rst` through this PR provided you're contributing here for the first time)
[//]: # (2. Don't forget to update the ... | 2019-10-02T15:07:08Z | Broken static files with whitenoise=n & cloud_provider=none
## What happened?
If the user chooses `use_whitenoise=n` & `cloud_provider=None`, then the static files are not served properly.
## What should've happened instead?
This combination should not be allowed and show an error when trying to generate the p... | To fix that, I think we should implement a check in one of the hooks, show an error to the user and not generate anything.
The tests will need to be updated to:
1. Cover only the working combination in the main fixture:
https://github.com/pydanny/cookiecutter-django/blob/63453b6e51faae64c872059cb4d90dd38d4... | [
{
"body": "## What happened?\r\n\r\nIf the user chooses `use_whitenoise=n` & `cloud_provider=None`, then the static files are not served properly.\r\n\r\n## What should've happened instead?\r\n\r\nThis combination should not be allowed and show an error when trying to generate the project.\r\n",
"number": 2... | 8e1211580f0fbc77dd3394c4c6b91913a45d8c44 | {
"head_commit": "9fffafc0950e214db263be797249005c35ef7db7",
"head_commit_message": "Add docstring",
"patch_to_review": "diff --git a/hooks/pre_gen_project.py b/hooks/pre_gen_project.py\nindex 91332f144f..7f9bd3eac2 100644\n--- a/hooks/pre_gen_project.py\n+++ b/hooks/pre_gen_project.py\n@@ -59,3 +59,12 @@\n ... | [
{
"diff_hunk": "@@ -157,3 +162,11 @@ def test_invalid_slug(cookies, context, slug):\n \n assert result.exit_code != 0\n assert isinstance(result.exception, FailedHookException)\n+\n+\n+def test_no_whitenoise_and_no_cloud_provider(cookies, context):\n+ \"\"\"It should not generate project if neither w... | 4f8834c0ebcf67d55fa8ed74b753ab665440d7b4 | diff --git a/hooks/pre_gen_project.py b/hooks/pre_gen_project.py
index 91332f144f..7f9bd3eac2 100644
--- a/hooks/pre_gen_project.py
+++ b/hooks/pre_gen_project.py
@@ -59,3 +59,12 @@
)
+ TERMINATOR
)
+
+if (
+ "{{ cookiecutter.use_whitenoise }}".lower() == "n... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
cookiecutter__cookiecutter-django-2435@c839862 | cookiecutter/cookiecutter-django | Python | 2,435 | Add all supported Anymail Providers | [//]: # (Thank you for helping us out: your efforts mean great deal to the project and the community as a whole!)
[//]: # (Before you proceed:)
[//]: # (1. Make sure to add yourself to `CONTRIBUTORS.rst` through this PR provided you're contributing here for the first time)
[//]: # (2. Don't forget to update the ... | 2020-02-06T20:24:38Z | Add an option to choose default email backend (AWS SES or Mailgun)
## Description
Add an option to choose default email backend (AWS SES or Mailgun)
## Rationale
Currently Mailgun is set as a default email backend.
In my opinion it would be nice to add an option to choose default email backend (AWS SES or Mai... | Why add only SES and not any [other ESP](https://anymail.readthedocs.io/en/stable/esps/) provided by `django-anymail`? Should we allow no ESP too? That could make the template a fair bit more complex I think.
I'm a bit on the fence on this, but if you put together a pull request, that might convince me :)
@browniebr... | [
{
"body": "## Description\r\n\r\nAdd an option to choose default email backend (AWS SES or Mailgun)\r\n\r\n## Rationale\r\n\r\nCurrently Mailgun is set as a default email backend.\r\nIn my opinion it would be nice to add an option to choose default email backend (AWS SES or Mailgun).\r\n\r\n## Use case(s) / vis... | 6d0a187addb1fb616568859f268ab503870d2d00 | {
"head_commit": "c839862aefded2e2f09f51afd448c8a3d015c409",
"head_commit_message": "Testing mail service does not raise KeyError\n* KeyError raised when cloud_provider was used twice in mark parametrization.\n* Tox isn't working properly for me (collecting 17,000 files; obviously neglecting tox.ini and/or pytest.i... | [
{
"diff_hunk": "@@ -182,16 +182,89 @@ class MediaRootGoogleCloudStorage(GoogleCloudStorage):\n # Django Admin URL regex.\n ADMIN_URL = env(\"DJANGO_ADMIN_URL\")\n \n-# Anymail (Mailgun)\n+# Anymail\n # ------------------------------------------------------------------------------\n # https://anymail.readthedocs... | 5e1d1dd1c39b92bae280ae071b3e20cad1c88ae2 | diff --git a/CONTRIBUTORS.rst b/CONTRIBUTORS.rst
index 86804b69d3..7a8ce13eb8 100644
--- a/CONTRIBUTORS.rst
+++ b/CONTRIBUTORS.rst
@@ -56,6 +56,7 @@ Listed in alphabetical order.
Andreas Meistad `@ameistad`_
Andres Gonzalez `@andresgz`_
Andrew Mikhnevich `@zcho`_
+ Andrew Chen Wang ... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
ccxt__ccxt-16487@e31e561 | ccxt/ccxt | Python | 16,487 | Coinbase: fetchTicker, fetchTickers | Added fetchTicker and fetchTickers advanced trade support:
fixes: #16476
### fetchTicker:
```
coinbase.fetchTicker (BTC/USDT)
2023-01-14T03:42:27.405Z iteration 0 passed in 530 ms
{
symbol: 'BTC/USDT',
timestamp: 1673667747404,
datetime: '2023-01-14T03:42:27.404Z',
bid: undefined,
ask: undefine... | 2023-01-14T04:03:38Z | Coinbase new version load markets and fetch tickers show different trading pairs.
### Operating System
Windows 10
### Programming Languages
JS
### CCXT Version
2.6.7
### Description
Hello:
As Coinbase will phrase out old API and migrate to Coinbase advanced trade with new API, I tested latest version of CCXT (v... | Hello @zydjohnHotmail, we're gradually upgrading to the new API and will try to do it as fast as possible.
cc/ @Dan-krm
Thanks for your quick reply.
Please let me know when the updating is done. | [
{
"body": "### Operating System\n\nWindows 10\n\n### Programming Languages\n\nJS\n\n### CCXT Version\n\n2.6.7\n\n### Description\n\nHello:\r\nAs Coinbase will phrase out old API and migrate to Coinbase advanced trade with new API, I tested latest version of CCXT (version 2.6.7), I can see the load markets funct... | 34372cfd1e19a4eaec369e2f5e76853a00c758f8 | {
"head_commit": "e31e5616c29c47c131809f35262c484e701d3c66",
"head_commit_message": "Coinbase: fetchTicker, fetchTickers\n\nAdded fetchTicker and fetchTickers advanced trade support:\n### fetchTicker:\n```\ncoinbase.fetchTicker (BTC/USDT)\n2023-01-14T03:42:27.405Z iteration 0 passed in 530 ms\n\n{\n symbol: 'BTC/U... | [
{
"diff_hunk": "@@ -1093,33 +1088,79 @@ module.exports = class coinbase extends Exchange {\n return this.parseTicker ([ spot, buy, sell ], market);\n }\n \n- parseTicker (ticker, market = undefined) {\n+ async fetchTickerV3 (symbol, params = {}) {\n+ await this.loadMarkets ();\n+ ... | 49f33f3c6fbe2598790da7ae0318b9de1e24945b | diff --git a/js/coinbase.js b/js/coinbase.js
index 04665f49fc745..7bdc7ff1f0577 100644
--- a/js/coinbase.js
+++ b/js/coinbase.js
@@ -263,6 +263,8 @@ module.exports = class coinbase extends Exchange {
],
'advanced': true, // set to true if using any v3 endpoints from the advanced trade ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
cookiecutter__cookiecutter-django-2031@c041453 | cookiecutter/cookiecutter-django | Python | 2,031 | Cloud provider docs update | [//]: # (Thank you for helping us out: your efforts mean great deal to the project and the community as a whole!)
[//]: # (Before you proceed:)
[//]: # (1. Make sure to add yourself to `CONTRIBUTORS.rst` through this PR provided you're contributing here for the first time)
[//]: # (2. Don't forget to update the ... | 2019-04-14T17:13:29Z | Documentation needs to be updated to add details on Google Cloud Storage
## Description
The documentation needs to be updated to reflect that Google Cloud Storage is now an option, in addition to S3.
[//]: # (What's it you're proposing? How should it be implemented?)
Update the relevant files
## Rationale... | Could I knock this out? I would love to contribute back to a project I have used alot.
Absolutely. Tag me if you need any help. | [
{
"body": "## Description\r\n\r\nThe documentation needs to be updated to reflect that Google Cloud Storage is now an option, in addition to S3.\r\n\r\n[//]: # (What's it you're proposing? How should it be implemented?)\r\n\r\nUpdate the relevant files\r\n\r\n\r\n## Rationale\r\n\r\n[//]: # (Why should this fea... | 589dfeae41aae1a0ea98567e869b63b34484869d | {
"head_commit": "c041453bef94930c658edffe3f009b799d459a7d",
"head_commit_message": "Updated project-generation-options.rst to provide helpful links in case a user needs to decide between AWS s3 and GCS and added myself to contributors.rst",
"patch_to_review": "diff --git a/CONTRIBUTORS.rst b/CONTRIBUTORS.rst\nin... | [
{
"diff_hunk": "@@ -63,6 +63,12 @@ js_task_runner:\n 1. None\n 2. Gulp_\n \n+cloud_provider:\n+ Select a cloud provider for static files. The choices are:",
"line": null,
"original_line": 67,
"original_start_line": null,
"path": "docs/project-generation-options.rst",
"start_line":... | cd13ab4c823e3c9619c9deac5ca368b9af477a9a | diff --git a/CONTRIBUTORS.rst b/CONTRIBUTORS.rst
index 9486b3a007..ded1606b20 100644
--- a/CONTRIBUTORS.rst
+++ b/CONTRIBUTORS.rst
@@ -177,6 +177,7 @@ Listed in alphabetical order.
Travis McNeill `@Travistock`_ @tavistock_esq
Tubo Shi `@Tubo`_
Umair Ashraf `@... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "Documentation Updates"
} |
ccxt__ccxt-19100@7c2a53a | ccxt/ccxt | Python | 19,100 | fix(php8) - promise interface & react update | reactphp-promise is now of v3.0.0 version, where `then()` has signature of: https://github.com/reactphp/promise/blob/3.x/src/PromiseInterface.php#L40
while we had older signature:
https://github.com/ccxt/ccxt/blob/master/php/pro/Future.php#L15
which caused an issue ( fix #19087 fix #19310 ). | 2023-09-04T13:09:18Z | Composer v2.6.1 install fatal error
### Operating System
Ubuntu 20.04.6 LTS
### Programming Languages
PHP
### CCXT Version
4.0.80
### Description
When I run `composer install --verbose --prefer-dist --no-progress --no-interaction --no-dev --optimize-autoloader` on my production server I get a PHP f... | i'll get to this soon, thanks for the report
can you please share your composer.json (just other dependencies excluded and sensitive details hidden) and also which PHP version do you use specifically
I've reproduced the issue, working on a fix. | [
{
"body": "### Operating System\r\n\r\nUbuntu 20.04.6 LTS\r\n\r\n### Programming Languages\r\n\r\nPHP\r\n\r\n### CCXT Version\r\n\r\n4.0.80\r\n\r\n### Description\r\n\r\nWhen I run `composer install --verbose --prefer-dist --no-progress --no-interaction --no-dev --optimize-autoloader` on my production server I ... | 3002e48db44a2b3e66723b2791f72205511633c7 | {
"head_commit": "7c2a53a76e1f65385460f7e6e5b20a5b54791eab",
"head_commit_message": "-",
"patch_to_review": "diff --git a/composer.json b/composer.json\nindex 6d5831307edea..cb28a50b96ef2 100644\n--- a/composer.json\n+++ b/composer.json\n@@ -240,7 +240,7 @@\n \"ratchet/pawl\": \">=0.4.1\",\n \"rea... | [
{
"diff_hunk": "@@ -240,7 +240,7 @@\n \"ratchet/pawl\": \">=0.4.1\",\n \"react/http\": \">=1.6.0\",\n \"react/async\": \"^4.0.0\",\n- \"react/promise\": \"^2.9.0\",\n+ \"react/promise\": \">=3.0.0\",",
"line": null,
"original_line": 243,
"original_start_line": n... | a7c3f44b35342e767a69d7ac80ad6d3c42d5c81d | diff --git a/composer.json b/composer.json
index 272c53bb1f7cb..619cb57d0999f 100644
--- a/composer.json
+++ b/composer.json
@@ -239,12 +239,19 @@
"pear/console_table": "1.3.1",
"react/http": ">=1.6.0",
"react/async": "^4.0.0",
- "react/promise": "^2.9.0",
+ "react/promise": "^3... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ccxt__ccxt-16292@c6b45d7 | ccxt/ccxt | Python | 16,292 | binance: update currency code when fetch fiat transactions ccxt/ccxt#16224 | fix: ccxt/ccxt#16224
The currency code of USD is BUSD when get fiat orders. Added a map for this, in case binance use another currency for other fiat. | 2023-01-02T08:05:50Z | binance can't fetch all fiat deposits
- Programming Language version: js
- CCXT version: 2.4.64
`fetchDeposits` in `binance` exchange is not able to get all fiat deposits. If I do not specify the `code` parameter all crypto deposits are returned. To fetch fiat deposits I have to iterate over all fiat currencies. Is... | [
{
"body": "- Programming Language version: js\r\n- CCXT version: 2.4.64\r\n\r\n`fetchDeposits` in `binance` exchange is not able to get all fiat deposits. If I do not specify the `code` parameter all crypto deposits are returned. To fetch fiat deposits I have to iterate over all fiat currencies. Is this a bug o... | 5ec52438caee0a8a213b7d9c8fdfbf1bd98427d0 | {
"head_commit": "c6b45d7dac2f81ce11d586ecd1893c1760a08169",
"head_commit_message": "binance: update parseTransaction",
"patch_to_review": "diff --git a/js/binance.js b/js/binance.js\nindex 19f46e61e570c..303fbe5736cea 100644\n--- a/js/binance.js\n+++ b/js/binance.js\n@@ -1146,6 +1146,9 @@ module.exports = class ... | [
{
"diff_hunk": "@@ -1146,6 +1146,9 @@ module.exports = class binance extends Exchange {\n 'JPY': true,\n 'NZD': true,\n },\n+ 'reverseCurrencyToLeagalMoney': {",
"line": null,
"original_line": 1149,
"original_start_line": null,
... | 9c10abe95a69fd4ce1945aae2d09cd37af7557c4 | diff --git a/js/binance.js b/js/binance.js
index 19f46e61e570c..6163ff51b16ae 100644
--- a/js/binance.js
+++ b/js/binance.js
@@ -1146,6 +1146,9 @@ module.exports = class binance extends Exchange {
'JPY': true,
'NZD': true,
},
+ 'legalMoneyCurrenc... | {
"difficulty": "medium",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} | |
cookiecutter__cookiecutter-django-1482@417517b | cookiecutter/cookiecutter-django | Python | 1,482 | Move to the python:alpine docker image | Fixes #498
- Switch the base images for local and production to alpine
- Install extra dependencies for psycopg2, Pillow and cffi
- Change shebang for shell scripts to use sh instead of bash, as bash isn't installed
- Remove `function` keyword from shell scripts, it is unsupported in sh
- Migrate `django` group... | 2018-02-05T19:27:51Z | Move to the python:alpine docker image
The default image we are currently using is super fat (around 700MB) as it is based on a full fletched debian. There's a lot of movement to images based on alpine going on and the official image now supports that too.
Alpine uses musl libc instead of glibc, so that might be a pro... | I'll take care of this
Per @jayfk: https://github.com/frol/docker-alpine-python3/issues/1 may prove helpful. Probably will need a Dockerfile that specifies dependency on glibc and the dependencies listed in the link (you may very well know this, but just in case)
@mjsisley: There is currently an official alpine image... | [
{
"body": "The default image we are currently using is super fat (around 700MB) as it is based on a full fletched debian. There's a lot of movement to images based on alpine going on and the official image now supports that too.\n\nAlpine uses musl libc instead of glibc, so that might be a problem for packages ... | f4cadeec97ef9f00652c27b7f8caff53e31e1ce9 | {
"head_commit": "417517bfa674f2e42c16006add975c6301197f1b",
"head_commit_message": "Move to the python:alpine docker image\n\n- Remove `function` keyword, unsupported in shell",
"patch_to_review": "diff --git a/{{cookiecutter.project_slug}}/compose/local/django/Dockerfile b/{{cookiecutter.project_slug}}/compose/... | [
{
"diff_hunk": "@@ -1,9 +1,18 @@\n-FROM python:3.5\n+FROM python:3.5-alpine",
"line": null,
"original_line": 1,
"original_start_line": null,
"path": "{{cookiecutter.project_slug}}/compose/production/django/Dockerfile",
"start_line": null,
"text": "@user1:\nMake it `FROM python:3.6-alpine... | b85636e8a34c44ea81f09f42c34b1f84032d15d1 | diff --git a/tests/test_docker.sh b/tests/test_docker.sh
index 137694d7a6..d80a091e43 100755
--- a/tests/test_docker.sh
+++ b/tests/test_docker.sh
@@ -19,3 +19,6 @@ docker-compose -f local.yml run django python manage.py test
# return non-zero status code if there are migrations that have not been created
docker-co... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Dependency Updates & Env Compatibility"
} |
ccxt__ccxt-15885@fd281b4 | ccxt/ccxt | Python | 15,885 | huobi - rework for networks | @carlosmiei
I've been working to redesigning of network-related functionality for huobi, because existing implementation was too much "custom" and based on occasional "if/else" clauses to handle the networks.
I've made a complete rework and this seems correct (a bit complex though) approach to unify networks parsi... | 2022-11-30T08:48:49Z | Withdrawal from Huobi problem
Hello. I test withdrawals from Huobi to Kucoin and I got some problems.
First, when I try to do this: `huobi.withdraw("USDT", 15, my_address, tag=None, params={"network": "ERC20"})`
I got
`ccxt.base.errors.BadRequest: huobipro {"status":"error","err-code":"base-currency-chain-error","er... | And question #3. Now I am trying to withdraw from Kucoin. First, it gives me error Kucoin needs to have a number for withdraw with only 6 decimal numbers after "." Ok, done it, but now with this code:
```
exchangeA = exchangeA
coin = coin
amount = exchangeA.fetch_balance()["free"][coin]
if exchangeA==self.kucoin:
... | [
{
"body": "Hello. I test withdrawals from Huobi to Kucoin and I got some problems.\r\nFirst, when I try to do this: `huobi.withdraw(\"USDT\", 15, my_address, tag=None, params={\"network\": \"ERC20\"})`\r\nI got\r\n`ccxt.base.errors.BadRequest: huobipro {\"status\":\"error\",\"err-code\":\"base-currency-chain-er... | 2496b2f5e20e29a717f6f65c3c99ee963fe67194 | {
"head_commit": "fd281b4b98c676d04c70e64c4fc61a1b7af89ed7",
"head_commit_message": "lint",
"patch_to_review": "diff --git a/js/base/Exchange.js b/js/base/Exchange.js\nindex b8f113358ece0..da847c550042a 100644\n--- a/js/base/Exchange.js\n+++ b/js/base/Exchange.js\n@@ -126,6 +126,7 @@ module.exports = class Exchan... | [
{
"diff_hunk": "@@ -2845,6 +2872,33 @@ module.exports = class huobi extends Exchange {\n return result;\n }\n \n+ networkIdToCode (networkId, currencyCode = undefined) {\n+ // here network-id is provided as a pair of currency & chain (i.e. trc20usdt)\n+ if (currencyCode === undefine... | 92b57f0b70fbb6ea2c0a6e2ad2145ad88ab3fc72 | diff --git a/js/base/Exchange.js b/js/base/Exchange.js
index b8f113358ece0..bdc48d9628117 100644
--- a/js/base/Exchange.js
+++ b/js/base/Exchange.js
@@ -126,6 +126,7 @@ module.exports = class Exchange {
'fetchTradingLimits': undefined,
'fetchTransactions': undefined,
'... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
ccxt__ccxt-15862@a8a89fb | ccxt/ccxt | Python | 15,862 | gemini - fetchMarketsFromApi | fixes: #16036
- Change nonce to use seconds. Even though docs recommend using milliseconds it was returning in the following error: `gemini Nonce '1669661118488' is not within 30 seconds of server time '1669661120''`
- Change default fetchMarkets to use API, web version was failing to fetch.
- Add calls for fetch... | 2022-11-28T18:54:22Z | Gemini get exchange balance got errors
- OS: Windows 10 PRO (22H2)
- Programming Language version: Node.js (Ver 19.2.0)
- CCXT version: 2.2.91
```js
const ccxt = require('ccxt');
console.log(ccxt.version);
let exchange = new ccxt.gemini({
apiKey: 'My_Account_API_Key',
secret: 'My_Account_Secret_Key'... | [
{
"body": "- OS: Windows 10 PRO (22H2)\r\n- Programming Language version: Node.js (Ver 19.2.0)\r\n- CCXT version: 2.2.91\r\n\r\n```js\r\nconst ccxt = require('ccxt');\r\nconsole.log(ccxt.version);\r\n\r\nlet exchange = new ccxt.gemini({\r\n apiKey: 'My_Account_API_Key',\r\n secret: 'My_Account_Secret_Key'... | 1660ebec34cf7b762d64b8fab552c3dcddbf668e | {
"head_commit": "a8a89fbfa8dfc169530c8239f354d76e36047ed7",
"head_commit_message": "gemini - fetchMarketsFromApi",
"patch_to_review": "diff --git a/js/gemini.js b/js/gemini.js\nindex 7fe6229d81250..a7c23fe828ba4 100644\n--- a/js/gemini.js\n+++ b/js/gemini.js\n@@ -232,7 +232,7 @@ module.exports = class gemini ext... | [
{
"diff_hunk": "@@ -381,14 +392,37 @@ module.exports = class gemini extends Exchange {\n // ]\n //\n const result = [];\n+ let promises = [];\n for (let i = 0; i < response.length; i++) {\n- const marketId = response[i];\n- const market = marketId... | 20c19f4673316eaabd72c53f5e69d690883ff8c9 | diff --git a/js/gemini.js b/js/gemini.js
index 7fe6229d81250..0041137a75c2c 100644
--- a/js/gemini.js
+++ b/js/gemini.js
@@ -233,6 +233,11 @@ module.exports = class gemini extends Exchange {
},
'options': {
'fetchMarketsMethod': 'fetch_markets_from_web',
+ 'fetc... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
ccxt__ccxt-15402@7ed12db | ccxt/ccxt | Python | 15,402 | bybit - v1 update to v3 | updated spot [v1](https://bybit-exchange.github.io/docs/spot/v1/#t-balance) endpoints to [v3](https://bybit-exchange.github.io/docs/spot/v3/#t-balance)
(edit: unfortunately, even though I've updated api version to v3 endpoints, 'trigger' orders are still unavailable through API as [their support says](https://t.me/... | 2022-10-25T12:46:23Z | exchange.transfer is not working with on bybit exchange
Transfering funds from "spot" to "funding" accounts works fine on binance exchange, but not with bybit.
Maybe I'm missing some arguments in my request ?
- OS: Win 10 x64
- Programming Language version: Node.js 18
- CCXT version: 2.0.25
```
// Transfering... | @danieltorscho
It turns out the funding wasn't account type they supported (https://bybit-exchange.github.io/docs/account_asset/#t-enums).
The supported account types:
* CONTRACT
* SPOT
* INVESTMENT - ByFi Account
* OPTION - USDC Account
* UNIFIED
@sc0Vu please leave this issue open for a while, I will t... | [
{
"body": "Transfering funds from \"spot\" to \"funding\" accounts works fine on binance exchange, but not with bybit.\r\nMaybe I'm missing some arguments in my request ?\r\n\r\n- OS: Win 10 x64\r\n- Programming Language version: Node.js 18\r\n- CCXT version: 2.0.25\r\n\r\n```\r\n// Transfering 2 USDT from spot... | 1fa34c765e3d6e9a7493a6ce3526fee3a23c85e2 | {
"head_commit": "7ed12dbabd8562f4f70f6e40d1c88019fbab7ce8",
"head_commit_message": "fetchDepositAddress - rework",
"patch_to_review": "diff --git a/js/bybit.js b/js/bybit.js\nindex 8983cf46c37b7..76f9f59330d65 100644\n--- a/js/bybit.js\n+++ b/js/bybit.js\n@@ -17,8 +17,6 @@ module.exports = class bybit extends Ex... | [
{
"diff_hunk": "@@ -3685,22 +4094,52 @@ module.exports = class bybit extends Exchange {\n method = isConditional ? 'privateGetV2PrivateStopOrder' : 'privateGetV2PrivateOrder';\n }\n } else if (type === 'spot') {\n- method = 'privateGetSpotV1OpenOrders';\n+ ... | 5faaf1ff76cf9f926d3f552a59163472d2c96184 | diff --git a/js/bybit.js b/js/bybit.js
index 8983cf46c37b7..aa40266aad10f 100644
--- a/js/bybit.js
+++ b/js/bybit.js
@@ -17,8 +17,6 @@ module.exports = class bybit extends Exchange {
'countries': [ 'VG' ], // British Virgin Islands
'version': 'v2',
'userAgent': undefined,
- ... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
ccxt__ccxt-16227@92e6de8 | ccxt/ccxt | Python | 16,227 | Binance :: unify symbols in a backwards compatible way [WIP] | fixes: https://github.com/ccxt/ccxt/issues/11121
- both market Ids and unified symbols can be used (as long as default type is correct)
- legacy support for `type = future` and `type = delivery`
- small fix on `safeMarket`
Demo:
```
n binanceusdm fetchTicker "BTCUSDT" --sandbox
binanceusdm.fetchTicker (B... | 2022-12-27T18:02:34Z | Uniform `market["type"]` field semantics
The `market["type"]` field returned by `Exchange.fetch_markets()` seems to have different semantics across exchanges.
Here is a comparison of the market type literals across 4 exchanges:
| Exchange | Spot | Margin | Delivery futures | Perpetual swaps | Options |
|---... | > Is there a plan to make the market type part of the public API?
Yes, working on that now: https://github.com/ccxt/ccxt/issues/10931
> Is there an exchange-independent way to determine if a symbol is a delivery future or a swap?
We will unify the `type` values and will add that to the docs.
I'd suggest we cal... | [
{
"body": "The `market[\"type\"]` field returned by `Exchange.fetch_markets()` seems to have different semantics across exchanges.\r\n\r\nHere is a comparison of the market type literals across 4 exchanges:\r\n\r\n| Exchange | Spot | Margin | Delivery futures | Perpetual swaps | Options |\r\n|----------|--... | 5f742086e397bae821e73d9751655bd385419afb | {
"head_commit": "92e6de8282405e31fb99985959b480a97eb4e083",
"head_commit_message": "add support for aliases",
"patch_to_review": "diff --git a/js/binance.js b/js/binance.js\nindex aaa63fd177bb2..0cf947fe948f2 100644\n--- a/js/binance.js\n+++ b/js/binance.js\n@@ -1,4 +1,3 @@\n-'use strict';\n \n // -------------... | [
{
"diff_hunk": "@@ -1984,6 +1984,26 @@ module.exports = class binance extends Exchange {\n return result;\n }\n \n+ setMarkets (markets, currencies = undefined) {\n+ super.setMarkets (markets, currencies);\n+ const values = Object.values (this.markets);\n+ let hasSpot = false... | d0808b595821670bfea3c2a1e77426b9213921a7 | diff --git a/js/binance.js b/js/binance.js
index 64d1f2b5dcc54..1fd2374d1ee19 100644
--- a/js/binance.js
+++ b/js/binance.js
@@ -792,7 +792,7 @@ module.exports = class binance extends Exchange {
'taker': this.parseNumber ('0.001'),
'maker': this.parseNumber ('0.001'),
... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
ccxt__ccxt-14902@0d33bde | ccxt/ccxt | Python | 14,902 | binance - precisions | binance's internal functionality related to currencies (i.e. `transfer`) does not work, because `currencyToPrecision` is not available (because the currency-wide precision is `undefined` at this moment)
fix #14344
fix #15691
etc. | 2022-09-07T22:57:02Z | binance currency_to_precision won't work - code precision is None
Hi,
I'm using ccxt version 1.79.94.
It appears that recently the currency_to_precision stopped working properly.
Looking into it, I have found that the self.currencies[code]["precision"] entry is always None (even though I'm using a valid API ke... | Binance
On Thu, Jul 14, 2022, 09:10 Sam Germain ***@***.***> wrote:
> what exchange are you using?
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/ccxt/ccxt/issues/14344#issuecomment-1184036069>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AGM3H6YT3WEYE4G3IXK6R6... | [
{
"body": "Hi,\r\n\r\nI'm using ccxt version 1.79.94.\r\n\r\nIt appears that recently the currency_to_precision stopped working properly.\r\n\r\nLooking into it, I have found that the self.currencies[code][\"precision\"] entry is always None (even though I'm using a valid API key pair) so the currency_to_precis... | 3a3fb212c88c52eec1ce3c8a64bcbfd9c78b273f | {
"head_commit": "0d33bde2cd436ebdb379b80d57a3f2dc17f1ba5c",
"head_commit_message": "decimal precisions",
"patch_to_review": "diff --git a/js/binance.js b/js/binance.js\nindex 13d2fb9a61461..096540d66e7c1 100644\n--- a/js/binance.js\n+++ b/js/binance.js\n@@ -1311,88 +1311,105 @@ module.exports = class binance ext... | [
{
"diff_hunk": "@@ -1412,14 +1429,24 @@ module.exports = class binance extends Exchange {\n if (isDefault || (fee === undefined)) {\n fee = withdrawFee;\n }\n+ const precisionTick = this.safeString (networkItem, 'withdrawIntegerMultiple');\n+ ... | 06d1d4719900dfbca83e26db77d4196bb0d62c10 | diff --git a/js/binance.js b/js/binance.js
index 13d2fb9a61461..f9bab8db28f1b 100644
--- a/js/binance.js
+++ b/js/binance.js
@@ -1311,88 +1311,105 @@ module.exports = class binance extends Exchange {
const result = {};
for (let i = 0; i < response.length; i++) {
//
- // {
-... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ccxt__ccxt-14834@125df32 | ccxt/ccxt | Python | 14,834 | Bitmex :: protect convertValue | - protect code against inexistent markets
- fixes https://github.com/ccxt/ccxt/issues/14823#event-7294155471
| 2022-08-31T18:23:10Z | TypeError: can only concatenate str (not "NoneType") to str
S: Ubuntu 18.04 LTS within WSL of Windows 10
Programming Language version: 3.8.10
CCXT version: 1.92.88
Exchange: Bitmex
Method: fetch_positions
>>>print(exchange.fetch_positions())
Traceback (most recent call last):
File "<stdin>", line 1, in <modu... | Hi @ViktorKov, thanks for reporting it, can you please share with us a verbose log? (you just need to set `exchange.verbose=True`before calling fetch_positions)
Hi Carlos,
Here you are the verbose:
>>> exchange.verbose=True
>>> print(exchange.fetch_positions())
fetch Request: bitmex GET https://testnet.bit... | [
{
"body": "S: Ubuntu 18.04 LTS within WSL of Windows 10\r\nProgramming Language version: 3.8.10\r\nCCXT version: 1.92.88\r\nExchange: Bitmex\r\nMethod: fetch_positions\r\n\r\n>>>print(exchange.fetch_positions())\r\nTraceback (most recent call last):\r\n File \"<stdin>\", line 1, in <module>\r\n File \"/iquant... | ab15e7dd30deaaa8df16e0da43b8b60f9d807b5d | {
"head_commit": "125df326f1abb120efc996f5dbde36905d121298",
"head_commit_message": "protect code against inexistent markets",
"patch_to_review": "diff --git a/js/bitmex.js b/js/bitmex.js\nindex 0cd9d9ef168bb..c4897d470f4a0 100644\n--- a/js/bitmex.js\n+++ b/js/bitmex.js\n@@ -2202,12 +2202,17 @@ module.exports = c... | [
{
"diff_hunk": "@@ -2202,12 +2202,17 @@ module.exports = class bitmex extends Exchange {\n } else if (market['quote'] === 'USDT') {\n resultValue = Precise.stringMul (value, '0.000001');\n } else {\n- const currency = this.currency (market['quote']);\n+ let curr... | 5c539260d35c0dc4b6d60b13548447952110a84d | diff --git a/js/bitmex.js b/js/bitmex.js
index 0cd9d9ef168bb..bbd5ab1145ecd 100644
--- a/js/bitmex.js
+++ b/js/bitmex.js
@@ -2202,12 +2202,17 @@ module.exports = class bitmex extends Exchange {
} else if (market['quote'] === 'USDT') {
resultValue = Precise.stringMul (value, '0.000001');
}... | {
"difficulty": "low",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ccxt__ccxt-14830@1d1701f | ccxt/ccxt | Python | 14,830 | poloniex: fix ccxt/ccxt#14829 | fix ccxt/ccxt#14829
It turns out `fmod` returns float type, and we compare result and types: `fmod (i % 2) === 0`, that's why `fetch_order_book` didn't work in php. | 2022-08-31T05:17:07Z | Poloniex fetch order book doesnt work
- Programming Language version: PHP
- CCXT version: latest
After update to latest PHP and latest ccxt i have problem with order book at poloniex (other functions are working fine I can place\cancel order and fetch order data but order book is always empty without any errors)
... | @Showgofar oh, it looks like a bug, we'll fix soon. | [
{
"body": "- Programming Language version: PHP \r\n- CCXT version: latest\r\n\r\nAfter update to latest PHP and latest ccxt i have problem with order book at poloniex (other functions are working fine I can place\\cancel order and fetch order data but order book is always empty without any errors)\r\nAnd I don'... | 225db92c70dc292053708da7b50a5f187bf7f6ee | {
"head_commit": "1d1701fab41fc95aabc1a4c1ae9b54c2ba228006",
"head_commit_message": "poloniex: fix ccxt/ccxt#14829",
"patch_to_review": "diff --git a/js/poloniex.js b/js/poloniex.js\nindex 8887211e2abcb..dc21ef7df32b5 100644\n--- a/js/poloniex.js\n+++ b/js/poloniex.js\n@@ -1353,14 +1353,14 @@ module.exports = cla... | [
{
"diff_hunk": "@@ -1353,14 +1353,14 @@ module.exports = class poloniex extends Exchange {\n const asksResult = [];\n const bidsResult = [];\n for (let i = 0; i < asks.length; i++) {\n- if ((i % 2) === 0) {\n+ if (i % 2) {",
"line": null,
"original_line": 13... | 2cb53bb329cfad612ad11c934caf774d1ab9515c | diff --git a/js/poloniex.js b/js/poloniex.js
index 8887211e2abcb..2d1632c2030e1 100644
--- a/js/poloniex.js
+++ b/js/poloniex.js
@@ -1353,14 +1353,14 @@ module.exports = class poloniex extends Exchange {
const asksResult = [];
const bidsResult = [];
for (let i = 0; i < asks.length; i++) {
- ... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "Bug Fixes"
} |
ccxt__ccxt-15812@a04c355 | ccxt/ccxt | Python | 15,812 | safeStringLower and safeStringUpper convert defaultValue to lowercase and uppercase | # Updates
- for `safeStringUpper(dict, 'value', 'default')`, the default value is returned as `DEFAULT` and vice versa for `safeStringLower`
-------------
# Testing
# JavaScript
## dict = {"test":"","test2":"10"}
`safe_string_lower (dict, 'test')`: `undefined`
`safe_string_upper (dict, 'test')`: `un... | 2022-11-23T21:40:57Z | Withdrawal from Huobi problem
Hello. I test withdrawals from Huobi to Kucoin and I got some problems.
First, when I try to do this: `huobi.withdraw("USDT", 15, my_address, tag=None, params={"network": "ERC20"})`
I got
`ccxt.base.errors.BadRequest: huobipro {"status":"error","err-code":"base-currency-chain-error","er... | And question #3. Now I am trying to withdraw from Kucoin. First, it gives me error Kucoin needs to have a number for withdraw with only 6 decimal numbers after "." Ok, done it, but now with this code:
```
exchangeA = exchangeA
coin = coin
amount = exchangeA.fetch_balance()["free"][coin]
if exchangeA==self.kucoin:
... | [
{
"body": "Hello. I test withdrawals from Huobi to Kucoin and I got some problems.\r\nFirst, when I try to do this: `huobi.withdraw(\"USDT\", 15, my_address, tag=None, params={\"network\": \"ERC20\"})`\r\nI got\r\n`ccxt.base.errors.BadRequest: huobipro {\"status\":\"error\",\"err-code\":\"base-currency-chain-er... | 26a30cd161ace323a7ed29db3e54277024c0f121 | {
"head_commit": "a04c35571f9da10a676a647c325da044c340a421",
"head_commit_message": "python exchange.get_object_value_from_key_list minor fix",
"patch_to_review": "diff --git a/js/base/functions/type.js b/js/base/functions/type.js\nindex 4b29f927d3a5f..ed68de1666da9 100644\n--- a/js/base/functions/type.js\n+++ b/... | [
{
"diff_hunk": "@@ -853,7 +869,7 @@ def safe_value_n(dictionary, key_list, default_value=None):\n \n @staticmethod\n def get_object_value_from_key_list(dictionary, key_list):\n- filtered_list = list(filter(lambda el: el in dictionary, key_list))\n+ filtered_list = list(filter(lambda el: el... | 40ca2b879f2c4b540eb2d921896773902a4940f4 | diff --git a/js/base/functions/type.js b/js/base/functions/type.js
index 4b29f927d3a5f..ed68de1666da9 100644
--- a/js/base/functions/type.js
+++ b/js/base/functions/type.js
@@ -59,8 +59,8 @@ module.exports = {
, safeTimestamp: (o, k, $default, n = asFloat (prop (o, k))) => (isNumber (n) ? ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ccxt__ccxt-14582@83f50a7 | ccxt/ccxt | Python | 14,582 | base - undefined string in findBroadlyMatchedKey exception | fix #12698
this PR depends on another PR: https://github.com/ccxt/ccxt/pull/14808 | 2022-08-03T12:55:43Z | ccxt/base/exchange.py find_broadly_matched_key not catching some exceptions, fix in body
You should add "string = str(string)" to the top of find_broadly_matched_key(self, string, key) in the title file, otherwise an unknown exchange error throwing an exception will crash with "NoneType has no attribute 'find' ". Code ... | [
{
"body": "You should add \"string = str(string)\" to the top of find_broadly_matched_key(self, string, key) in the title file, otherwise an unknown exchange error throwing an exception will crash with \"NoneType has no attribute 'find' \". Code is on another computer, sorry for the lack of replicability. \r\n"... | a5f2015d2ba1e7c2655956be3c8bcd4503897e3a | {
"head_commit": "83f50a72c692360dc393354bea2ac003e9743ec3",
"head_commit_message": "base - undefined string in broad exceptions",
"patch_to_review": "diff --git a/js/base/Exchange.js b/js/base/Exchange.js\nindex de32453a8fea5..630fdbb41a5fb 100644\n--- a/js/base/Exchange.js\n+++ b/js/base/Exchange.js\n@@ -2087,8... | [
{
"diff_hunk": "@@ -2087,8 +2087,10 @@ module.exports = class Exchange {\n const keys = Object.keys (broad);\n for (let i = 0; i < keys.length; i++) {\n const key = keys[i];\n- if (string.indexOf (key) >= 0) {\n- return key;\n+ if (string !== unde... | 49dc03b66554d6d67ca834fd5d392e1c6ece487c | diff --git a/js/base/Exchange.js b/js/base/Exchange.js
index de32453a8fea5..2dd03d209567a 100644
--- a/js/base/Exchange.js
+++ b/js/base/Exchange.js
@@ -2087,8 +2087,10 @@ module.exports = class Exchange {
const keys = Object.keys (broad);
for (let i = 0; i < keys.length; i++) {
const key... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} | |
ccxt__ccxt-22913@64515a9 | ccxt/ccxt | Python | 22,913 | feat(binance) - margin field in fetchCurrencies & margin data in fetchMarkets | fixes #8695 | 2024-06-27T14:58:57Z | Binance: Exchange Error {"code":-3028,"msg":"Not a valid margin pair."}
Hi ccxt team!
I am getting constant `{"code":-3028,"msg":"Not a valid margin pair."}` errors from Binance when executing market orders on them even tho I am using the 'margin' defaultType on initialization .
- OS: macOS
- Programming Langua... | @strikeout thx for your report, we will investigate and will be back to you asap.
Small update:
I've checked the binance Website and API directly and it seems that, at least the above mentioned pair `ENJ/BTC`, does in fact allow margin trading, but only on *isolated* margin.
I have not found any indication or diffe... | [
{
"body": "Hi ccxt team!\r\n\r\nI am getting constant `{\"code\":-3028,\"msg\":\"Not a valid margin pair.\"}` errors from Binance when executing market orders on them even tho I am using the 'margin' defaultType on initialization .\r\n\r\n- OS: macOS\r\n- Programming Language version: node 12.x\r\n- CCXT versio... | c394c03a3a9b845c461138563447be6449516c5e | {
"head_commit": "64515a9f8334ceba5b4b9d78f7b48ae96aaf7964",
"head_commit_message": "Update binance.ts",
"patch_to_review": "diff --git a/ts/src/binance.ts b/ts/src/binance.ts\nindex ceceba5548e5e..c62f3f3a482df 100644\n--- a/ts/src/binance.ts\n+++ b/ts/src/binance.ts\n@@ -2626,6 +2626,7 @@ export default class b... | [
{
"diff_hunk": "@@ -2855,10 +2878,21 @@ export default class binance extends Exchange {\n }\n const promises = await Promise.all (promisesRaw);\n let markets = [];\n+ this.options['crossMarginPairsData'] = {};\n+ this.options['isolatedMarginPairsData'] = {};\n for (... | d6b8b06832e398daca5c65217a4461a62bfbbf0c | diff --git a/build/transpile.js b/build/transpile.js
index c179b264aaa68..2eb757a3e11e5 100644
--- a/build/transpile.js
+++ b/build/transpile.js
@@ -797,6 +797,7 @@ class Transpiler {
'MarginModification': /-> MarginModification:/,
'Market': /(-> Market:|: Market)/,
'MarketInterfa... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
ccxt__ccxt-11034@acbba71 | ccxt/ccxt | Python | 11,034 | Fix currency in 'fetchTransactions' | - Fix currencies in fetchTransactions
- Replaced a commented lines with correct commenting
[ fixes #11027 ] | 2021-12-27T18:35:57Z | [bitfinex2] Currency always None in transactions
- OS: Ubuntu 21.10
- Programming Language version: Python 3.9
- CCXT version: 1.65.23
The `currency` key is always set to `None` in the transactions returned by `fetch_transactions()`. The `currency` key in `fee` is also `None`.
On a side note, fetching currencie... | [
{
"body": "- OS: Ubuntu 21.10\r\n- Programming Language version: Python 3.9\r\n- CCXT version: 1.65.23\r\n\r\nThe `currency` key is always set to `None` in the transactions returned by `fetch_transactions()`. The `currency` key in `fee` is also `None`.\r\n\r\nOn a side note, fetching currencies by currency code... | dfe0a3e17154ba61767848f1066e07bc49a138f5 | {
"head_commit": "acbba710047d0f75d17d7117b044912a0e62073e",
"head_commit_message": "indent fix in commented response",
"patch_to_review": "diff --git a/js/bitfinex2.js b/js/bitfinex2.js\nindex c9636faf17405..8554dfac56804 100644\n--- a/js/bitfinex2.js\n+++ b/js/bitfinex2.js\n@@ -1401,12 +1401,12 @@ module.export... | [
{
"diff_hunk": "@@ -1440,8 +1440,15 @@ module.exports = class bitfinex2 extends bitfinex {\n }\n tag = this.safeString (data, 3);\n type = 'withdrawal';\n- } else {\n+ } else if (transactionLength === 22) {\n id = this.safeString (transaction, 0);\n+... | 2049564fbff9f906c87291e6641a49ccd6f33df6 | diff --git a/js/bitfinex2.js b/js/bitfinex2.js
index c9636faf17405..c6c6d4bb6c117 100644
--- a/js/bitfinex2.js
+++ b/js/bitfinex2.js
@@ -1401,12 +1401,12 @@ module.exports = class bitfinex2 extends bitfinex {
// -0.00135, // FEES
// null,
// null,
- // '... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
ccxt__ccxt-15210@d6b84bc | ccxt/ccxt | Python | 15,210 | bybit: integrate derivatives v3 | Bybit have released derivatives v3 recently, and separate two parts (unified margin and contract v3). In this PR, I'll integrate derivatives v3 for bybit.
##### For unified margin
- [x] fetchOrderBook
- [x] fetchOHLCV
- [x] fetchMarketLeverageTiers
- [x] fetchOpenInterestHistory
- [x] fetchTrades
- [x] fetch... | 2022-10-07T06:26:36Z | bybit can't use fetchOrder by id after created
I tried to search a lot on issues tab but no one report about this, I also tried to look at fetchOpenOrders and fetchClosedOrders and other endpoints tried using a custom id did not work too, closed:True. Everything I could find I tried
- OS: Mac OS 12.6
- Programming ... | [
{
"body": "I tried to search a lot on issues tab but no one report about this, I also tried to look at fetchOpenOrders and fetchClosedOrders and other endpoints tried using a custom id did not work too, closed:True. Everything I could find I tried\r\n\r\n- OS: Mac OS 12.6\r\n- Programming Language version: Pyth... | 36cde8f13f7753026a75286ef0d8f9f1ab4529f6 | {
"head_commit": "d6b84bcbbe3515f4c52a3289d1628e6de90582a5",
"head_commit_message": "bybit: refactor fetchOHLCV",
"patch_to_review": "diff --git a/js/bybit.js b/js/bybit.js\nindex e99579b4b56da..b2add3c211c9e 100644\n--- a/js/bybit.js\n+++ b/js/bybit.js\n@@ -50,7 +50,7 @@ module.exports = class bybit extends Exch... | [
{
"diff_hunk": "@@ -1627,74 +1804,147 @@ module.exports = class bybit extends Exchange {\n if (limit !== undefined) {\n request['limit'] = limit; // max 200, default 200\n }\n- let method = undefined;\n- let intervalKey = 'interval';\n- let sinceKey = 'from';\n- ... | 14466ab0a987c4e3a0e1b00e18306eb01ff5c62d | diff --git a/js/bybit.js b/js/bybit.js
index 4b9ece891de87..7af79917dbeb8 100644
--- a/js/bybit.js
+++ b/js/bybit.js
@@ -15,7 +15,7 @@ module.exports = class bybit extends Exchange {
'id': 'bybit',
'name': 'Bybit',
'countries': [ 'VG' ], // British Virgin Islands
- 'ver... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} | |
ccxt__ccxt-10909@d1655f9 | ccxt/ccxt | Python | 10,909 | Bitfinex v2 fetchTransactions / movements endpoint issue fix | This specific endpoint ( https://docs.bitfinex.com/reference#rest-auth-movements ) requires the currency code without prepended chars.
( Also, I've added a temporary reference link to the partial code i've stared, but atm cant proceed with it, and will return to it later. )
[ fixes #10172 ] | 2021-12-15T17:47:33Z | bitfinex2 throws currency: invalid on fetchTransactions
- OS: MacOS
- Programming Language version: node v16.8.0
- CCXT version: ccxt@1.57.68
Basically `bitfinex2` fetchTransactions does not seem to work.
```js
const exchange = new ccxt.bitfinex2({
// ...
})
const currencies = await exchange.fetchCurrenc... | ```JavaScript
const exchange = new ccxt.bitfinex2({
// ...
})
const currencies = await exchange.fetchCurrencies()
for (const currency in currencies) {
const code = currencies[currency].code
await exchange.fetch(code, since, limit) // <- this line looks wrong to me, no fetchTransactions here
}
```
@steebche... | [
{
"body": "- OS: MacOS\r\n- Programming Language version: node v16.8.0\r\n- CCXT version: ccxt@1.57.68\r\n\r\nBasically `bitfinex2` fetchTransactions does not seem to work. \r\n\r\n```js\r\nconst exchange = new ccxt.bitfinex2({\r\n // ...\r\n})\r\nconst currencies = await exchange.fetchCurrencies()\r\nfor (con... | abb38cbb1fee00e89529238095555150132f3ad5 | {
"head_commit": "d1655f92ff26dc44784636f3ebaf26186ca3efcd",
"head_commit_message": "typo",
"patch_to_review": "diff --git a/js/bitfinex2.js b/js/bitfinex2.js\nindex 23dc78f1ac640..ad12381406951 100644\n--- a/js/bitfinex2.js\n+++ b/js/bitfinex2.js\n@@ -361,7 +361,7 @@ module.exports = class bitfinex2 extends bitf... | [
{
"diff_hunk": "@@ -1491,7 +1491,7 @@ module.exports = class bitfinex2 extends bitfinex {\n let method = 'privatePostAuthRMovementsHist';\n if (code !== undefined) {\n currency = this.currency (code);\n- request['currency'] = currency['id'];\n+ request['currency... | d8bc017b566b2a8a326f13a080ce160f4d0d3380 | diff --git a/js/bitfinex2.js b/js/bitfinex2.js
index 23dc78f1ac640..1a8402cdcb3ba 100644
--- a/js/bitfinex2.js
+++ b/js/bitfinex2.js
@@ -361,7 +361,7 @@ module.exports = class bitfinex2 extends bitfinex {
}
async fetchMarkets (params = {}) {
- // todo drop v1 in favor of v2 configs
+ // todo d... | {
"difficulty": "medium",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
ccxt__ccxt-5095@c7b624e | ccxt/ccxt | Python | 5,095 | Fix Coinegg loadMarkets and fetchTickers | This fixes #5086 . Note that this is a breaking change since IDs are now using the identifiers returned by CoinEgg (`base_quote` as opposed to `basequote`). | 2019-05-10T13:21:51Z | CoinEgg LoadMarkets Unknown Markets
OS: Ubuntu 18.03
Programming Language version: Node v10
CCXT version: Latest
Exchange: CoinEgg
Method: LoadMarkets
```
Exchange Name: coinegg
Exchange Markets: [
'0/BTC', '1/BTC', '2/BTC', '3/BTC',
'4/BTC', ... | If you check their verbose responses, it looks like they have changed the way they serve markets.
```
mbp:ccxt igorkroitor$ node examples/js/cli coinegg symbols --verbose
fetch:
coinegg GET https://www.coinegg.com/coin/btc/allcoin?t=1557407713046
Request:
{}
undefined
handleRestResponse:
coinegg GET ht... | [
{
"body": "OS: Ubuntu 18.03\r\nProgramming Language version: Node v10\r\nCCXT version: Latest\r\nExchange: CoinEgg\r\nMethod: LoadMarkets\r\n\r\n```\r\nExchange Name: coinegg\r\nExchange Markets: [\r\n '0/BTC', '1/BTC', '2/BTC', '3/BTC',\r\n '4/BTC', ... | 842f3a79abc8a5629d95015c854164c783f61cf5 | {
"head_commit": "c7b624e2ef25c81b5c133fe2e1d4f95c6c07c179",
"head_commit_message": "Change URL for fetching markets",
"patch_to_review": "diff --git a/js/coinegg.js b/js/coinegg.js\nindex e67bc429c771e..80fac31eae7cc 100644\n--- a/js/coinegg.js\n+++ b/js/coinegg.js\n@@ -23,7 +23,7 @@ module.exports = class coine... | [
{
"diff_hunk": "@@ -258,36 +255,14 @@ module.exports = class coinegg extends Exchange {\n \n async fetchTickers (symbols = undefined, params = {}) {\n await this.loadMarkets ();\n- let quoteIds = this.options['quoteIds'];\n+ const markets = Object.values (this.markets_by_id);\n ... | ed4d5a657234ecc9d99c8da15cfc8788f2163058 | diff --git a/js/coinegg.js b/js/coinegg.js
index e67bc429c771e..7e8328c6df609 100644
--- a/js/coinegg.js
+++ b/js/coinegg.js
@@ -18,12 +18,12 @@ module.exports = class coinegg extends Exchange {
'fetchOrders': true,
'fetchOpenOrders': 'emulated',
'fetchMyTrades': true,... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
comfyanonymous__ComfyUI-6300@5ed0989 | comfyanonymous/ComfyUI | Python | 6,300 | Convert `latents_ubyte` to 8-bit unsigned int before converting to CPU | Hello, not sure if this is the best solution, but looks like it fixes the issue described in #3539 for most people, me included, so I'll go ahead and submit this PR.
Fixes #3539 | 2024-12-31T21:15:48Z | Cannot handle this data type: (1, 1, 3), <f4
Hi,
After 2 days without using, I updated comfyUI and now I get this error when I try to sample anything, seemingly happens when it tries to show a preview:
!!! Exception during processing!!! Cannot handle this data type: (1, 1, 3), <f4
Traceback (most recent call las... | After investigating a little the file latent_preview.py, function decode_latent_to_preview, which was modified a few days ago, the values are transformed into [0.0, 255.0], but the dtype stays torch.float32 instead of becoming torch.uint8.
For some reason the "to" method doesn't do the type change unless you do it a... | [
{
"body": "Hi,\r\n\r\nAfter 2 days without using, I updated comfyUI and now I get this error when I try to sample anything, seemingly happens when it tries to show a preview:\r\n\r\n!!! Exception during processing!!! Cannot handle this data type: (1, 1, 3), <f4\r\nTraceback (most recent call last):\r\n File \"... | 1c99734e5abe0bb8169027155c62c54b9eb9ea47 | {
"head_commit": "5ed09898bbe44bbc05bded85a9b952428f816b38",
"head_commit_message": "Convert latents_ubyte to 8-bit unsigned int before converting to CPU",
"patch_to_review": "diff --git a/latent_preview.py b/latent_preview.py\nindex 07f9cc68e97c..b099e4f984fd 100644\n--- a/latent_preview.py\n+++ b/latent_preview... | [
{
"diff_hunk": "@@ -12,7 +12,9 @@\n def preview_to_image(latent_image):\n latents_ubyte = (((latent_image + 1.0) / 2.0).clamp(0, 1) # change scale from -1..1 to 0..1\n .mul(0xFF) # to 0..255\n- ).to(device=\"cpu\", dtype=torch.uint8, non_blocking=... | 79c526f5c092b7e867cc4a860d9329d9bec766cd | diff --git a/latent_preview.py b/latent_preview.py
index 07f9cc68e97c..95d3cb7338ea 100644
--- a/latent_preview.py
+++ b/latent_preview.py
@@ -12,7 +12,10 @@
def preview_to_image(latent_image):
latents_ubyte = (((latent_image + 1.0) / 2.0).clamp(0, 1) # change scale from -1..1 to 0..1
... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
dagster-io__dagster-25368@d51e7bd | dagster-io/dagster | Python | 25,368 | explicitly include asset check selection on backfill runs | ## Summary & Motivation
Fixes https://github.com/dagster-io/dagster/issues/25328.
Currently, when asset backfills launch, all the checks for the selected assets are executed. However, these checks aren't explicitly included on the `asset_check_selection` property of the `DagsterRun`. A consequence of this is tha... | 2024-10-18T16:30:03Z | Error when re-executing asset check from backfill run
### Reproduction
Use this code location:
```python
from dagster import BackfillPolicy, DailyPartitionsDefinition, Definitions, asset, asset_check
pdef = DailyPartitionsDefinition("2024-10-01")
@asset(partitions_def=pdef, backfill_policy=BackfillPolicy.sin... | [
{
"body": "### Reproduction\r\nUse this code location:\r\n\r\n```python\r\nfrom dagster import BackfillPolicy, DailyPartitionsDefinition, Definitions, asset, asset_check\r\n\r\npdef = DailyPartitionsDefinition(\"2024-10-01\")\r\n\r\n@asset(partitions_def=pdef, backfill_policy=BackfillPolicy.single_run())\r\ndef... | 7dc624df9e35723b9ca0a0022cc3972269650e29 | {
"head_commit": "d51e7bdd18e5bc0bea69f2c76b8d1debf2df371b",
"head_commit_message": "add efficient override for get_check_keys_for_assets",
"patch_to_review": "diff --git a/python_modules/dagster/dagster/_core/definitions/automation_tick_evaluation_context.py b/python_modules/dagster/dagster/_core/definitions/aut... | [
{
"diff_hunk": "@@ -445,6 +445,16 @@ def _asset_check_nodes_by_asset_key(self) -> Mapping[AssetKey, Sequence[RemoteAs\n def get_checks_for_asset(self, asset_key: AssetKey) -> Sequence[RemoteAssetCheckNode]:\n return self._asset_check_nodes_by_asset_key.get(asset_key, [])\n \n+ def get_check_keys_... | 7848bd4e7cc2709a1081e9e6cc75e16ab8109cb4 | diff --git a/python_modules/dagster/dagster/_core/definitions/automation_tick_evaluation_context.py b/python_modules/dagster/dagster/_core/definitions/automation_tick_evaluation_context.py
index 2dbe9169e5a0e..c6bdc353e0006 100644
--- a/python_modules/dagster/dagster/_core/definitions/automation_tick_evaluation_context... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
dagster-io__dagster-22626@80fcf42 | dagster-io/dagster | Python | 22,626 | Quote table identifiers for row count query in dbt integration | ## Summary & Motivation
Fixes: #22625
Dbt integration fails to add row count materialization metadata when the asset's table
contains characters which require it to be quoted.
## How I Tested These Changes
Modified code and ran locally on asset that is failing with current code from `master`
I would have ad... | 2024-06-20T21:02:56Z | dbt row count breaks on identifier which need quoting
### Dagster version
1.7.10
### What's the issue?
When using the dbt integration and collecting row counts, the query fails if part of the relation identifier requires quoting.
```
An error occurred while fetching row count for model.rv.pixellog. Row count... | [
{
"body": "### Dagster version\r\n\r\n1.7.10\r\n\r\n### What's the issue?\r\n\r\nWhen using the dbt integration and collecting row counts, the query fails if part of the relation identifier requires quoting.\r\n```\r\nAn error occurred while fetching row count for model.rv.pixellog. Row count metadata will not ... | cf4b548cc355624f3340acd747a09a03a488e3f2 | {
"head_commit": "80fcf42cbe0e4285a1ea16b18903fc4209bcd013",
"head_commit_message": "Quote table identifiers for row count query in dbt integration",
"patch_to_review": "diff --git a/python_modules/libraries/dagster-dbt/dagster_dbt/core/resources_v2.py b/python_modules/libraries/dagster-dbt/dagster_dbt/core/resou... | [
{
"diff_hunk": "@@ -1030,7 +1030,13 @@ def _fetch_row_count_metadata(\n \n unique_id = dbt_resource_props[\"unique_id\"]\n logger.debug(\"Fetching row count for %s\", unique_id)\n- table_str = f\"{dbt_resource_props['database']}.{dbt_resource_props['schema']}.{dbt_resource_props['name']}\"\n+ tabl... | be1b00de51a656ac13eb2ce248a9d1690307983e | diff --git a/python_modules/libraries/dagster-dbt/dagster_dbt/core/resources_v2.py b/python_modules/libraries/dagster-dbt/dagster_dbt/core/resources_v2.py
index d980a9a12c976..0dab2b9790a52 100644
--- a/python_modules/libraries/dagster-dbt/dagster_dbt/core/resources_v2.py
+++ b/python_modules/libraries/dagster-dbt/dags... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} | |
dmlc__dgl-6924@ecd809b | dmlc/dgl | Python | 6,924 | [GraphBolt][CUDA] Dataloader `num_workers > 0` fix. | ## Description
Fixes #6921. We defer calling `is_pinned` to avoid initializing torch cuda internals by forcing the user to provide the `nodes` tensor on the GPU to be able to use pinned graph sampling via UVA. If the `nodes` or `index` tensor is not on the GPU, then we don't need to check if the graph is pinned or not... | 2024-01-09T19:01:11Z | [GraphBolt] `RuntimeError: CUDA error: initialization error` in `sample_neighbors()` when num_workers > 0
## 🐛 Bug
<!-- A clear and concise description of what the bug is. -->
## To Reproduce
Steps to reproduce the behavior:
1. build CUDA version upon DGL 2.0.x branch or install latest nightly build DGL.
... | cpu only DGL works well with `num_workers>0, --device cpu`.
adding `mp.set_start_method("spawn")` at the top of `main()` resolves this crash
Probably related: https://pytorch.org/docs/master/notes/multiprocessing.html#cuda-in-multiprocessing
I don't know if there is a way to stop CUDA from being initialized when not u... | [
{
"body": "## 🐛 Bug\r\n\r\n<!-- A clear and concise description of what the bug is. -->\r\n\r\n## To Reproduce\r\n\r\nSteps to reproduce the behavior:\r\n\r\n1. build CUDA version upon DGL 2.0.x branch or install latest nightly build DGL.\r\n2. run `DGL_HOME=/home/ubuntu/workspace/dgl_0 DGL_LIBRARY_PATH=$DGL_H... | 4323986b25ce5c6d0ced0a6db5550402740aeb99 | {
"head_commit": "ecd809b368c913e0b639f5ed5d41da76b50c72c8",
"head_commit_message": "fix UVA index select as well.",
"patch_to_review": "diff --git a/graphbolt/src/fused_csc_sampling_graph.cc b/graphbolt/src/fused_csc_sampling_graph.cc\nindex 36a3993ecff4..8432d8a2da01 100644\n--- a/graphbolt/src/fused_csc_sampli... | [
{
"diff_hunk": "@@ -19,6 +19,13 @@ inline bool is_accessible_from_gpu(torch::Tensor tensor) {\n return tensor.is_pinned() || tensor.device().type() == c10::DeviceType::CUDA;\n }\n \n+/**\n+ * @brief Checks whether the tensor is stored on the GPU.\n+ */\n+inline bool is_on_gpu(torch::Tensor tensor) {\n+ retur... | d22d6472ded10e346f036e6c38ad02f671077441 | diff --git a/graphbolt/src/fused_csc_sampling_graph.cc b/graphbolt/src/fused_csc_sampling_graph.cc
index 36a3993ecff4..8432d8a2da01 100644
--- a/graphbolt/src/fused_csc_sampling_graph.cc
+++ b/graphbolt/src/fused_csc_sampling_graph.cc
@@ -274,9 +274,8 @@ FusedCSCSamplingGraph::GetState() const {
c10::intrusive_ptr<F... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
dmlc__dgl-5979@2734756 | dmlc/dgl | Python | 5,979 | [Graphbolt] Add pickle serialization support for Graphbolt SampledSubgraph | ## Description
Implemented `__setstate__` and `__getstate__` function for `SampledSubgraph` which enables pickle to dump it.
Resolve #5953.
[Updated] Added unit test.
## Checklist
Please feel free to remove inapplicable items for your PR.
- [x] The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc],... | 2023-07-11T03:57:41Z | [GraphBolt] GraphBolt objects cannot be serialized during multiprocessing
## 🐛 Bug
It seems that GraphBolt objects like `SampledSubgraph` cannot be passed around in multiprocessing due to lack of serialization method.
## To Reproduce
```python
import dgl.graphbolt
import torch
import multiprocessing as mp
... | [
{
"body": "## 🐛 Bug\r\n\r\nIt seems that GraphBolt objects like `SampledSubgraph` cannot be passed around in multiprocessing due to lack of serialization method.\r\n\r\n## To Reproduce\r\n\r\n```python\r\nimport dgl.graphbolt\r\nimport torch\r\nimport multiprocessing as mp\r\nimport scipy.sparse as sp\r\n\r\nd... | f7f4e73a46223379a32e83d52115915f9c85b52d | {
"head_commit": "273475637932607f78f4918a51b4a3840f88b1df",
"head_commit_message": "Fix lint issue",
"patch_to_review": "diff --git a/graphbolt/include/graphbolt/sampled_subgraph.h b/graphbolt/include/graphbolt/sampled_subgraph.h\nindex 49ebb4651f88..ab958545e9b0 100644\n--- a/graphbolt/include/graphbolt/sampled... | [
{
"diff_hunk": "@@ -113,6 +113,24 @@ struct SampledSubgraph : torch::CustomClassHolder {\n * subgraph.\n */\n torch::optional<torch::Tensor> type_per_edge;\n+\n+ /**\n+ * @brief Version number to indicate graph version in serialization and\n+ * deserialization.\n+ */\n+ static constexpr int64_t ... | eee0bf22af3e50998600134a4cc8a09ffdaf4935 | diff --git a/graphbolt/include/graphbolt/sampled_subgraph.h b/graphbolt/include/graphbolt/sampled_subgraph.h
index 49ebb4651f88..84c36330daae 100644
--- a/graphbolt/include/graphbolt/sampled_subgraph.h
+++ b/graphbolt/include/graphbolt/sampled_subgraph.h
@@ -113,6 +113,18 @@ struct SampledSubgraph : torch::CustomClassH... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} | |
dmlc__dgl-5945@ef03743 | dmlc/dgl | Python | 5,945 | [Bugfix] Update dgl function `random_walk_pe` to be compatible with latest scipy | ## Description
This is to fix https://github.com/dmlc/dgl/issues/5943.
Due to this PR: https://github.com/scipy/scipy/pull/18508, scipy changes the output of divide (sparse, dense) from dense to sparse format. As a result, it would break the function `random_walk_pe`, as follows:https://github.com/dmlc/dgl/blob/4b5... | 2023-07-03T22:31:44Z | [Bug] Unit test failed due to a recent update of scipy package (scipy >1.11.0)
## 🐛 Bug
DGL transform function `random_walk_pe` breaks due to recent update of scipy package, which results in an unit test failing (`python/common -k "test_module_random_walk_pe"`).
## To Reproduce
Install scipy with later version... | [
{
"body": "## 🐛 Bug\r\n\r\nDGL transform function `random_walk_pe` breaks due to recent update of scipy package, which results in an unit test failing (`python/common -k \"test_module_random_walk_pe\"`).\r\n\r\n## To Reproduce\r\nInstall scipy with later version `pip install scipy==1.11` and then `python3 -m ... | 4b585ba068b67f10a25eada64532c09da6561d10 | {
"head_commit": "ef03743645336502816ed3d063c1ff24086ad75e",
"head_commit_message": "Fix lint",
"patch_to_review": "diff --git a/python/dgl/transforms/functional.py b/python/dgl/transforms/functional.py\nindex fafb2ed32afb..9d79e50aedfa 100644\n--- a/python/dgl/transforms/functional.py\n+++ b/python/dgl/transform... | [
{
"diff_hunk": "@@ -3589,7 +3589,12 @@ def random_walk_pe(g, k, eweight_name=None):\n shape=(N, N),\n )\n A = A.multiply(W)\n- RW = np.array(A / (A.sum(1) + 1e-30)) # 1-step transition probability\n+ # 1-step transition probability\n+ if scipy.__version__ < \"1.11.0\":\n+ ... | 90666759c84a6d8d72b35aa715280737350789fc | diff --git a/python/dgl/transforms/functional.py b/python/dgl/transforms/functional.py
index fafb2ed32afb..82be4a2795d4 100644
--- a/python/dgl/transforms/functional.py
+++ b/python/dgl/transforms/functional.py
@@ -22,6 +22,7 @@
import numpy as np
import scipy.sparse as sparse
import scipy.sparse.linalg
+from packag... | {
"difficulty": "medium",
"estimated_review_effort": 2,
"problem_domain": "Dependency Updates & Env Compatibility"
} | |
dmlc__dgl-5411@7fa5cca | dmlc/dgl | Python | 5,411 | [Dataloading] Ignore edge types without reverse types in edge dataloader | ## Description
Fixes https://github.com/dmlc/dgl/issues/5410
## Checklist
Please feel free to remove inapplicable items for your PR.
- [x] The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])
- [x] I've leverage the [tools](https://docs.google.com/document/d/1iHyj7zlmygKSk5gBPsqIqL5A... | 2023-03-01T23:23:16Z | [DGL] Edge sampler failures with mixed reverses.
## 🐛 Bug
Edge prediction sampler fails when some edges have reverses and others do not.
## To Reproduce
```
import dgl
import torch
data_dict = {('A','AB','B'): (torch.tensor([0,1]),torch.tensor([0,1])),
('B','BA','A'): (torch.tensor([0,1]),tor... | This could be solved by performing a get check on the dictionary being accessed:
https://github.com/dmlc/dgl/blob/325e795a18bec66595bca59708b42b726c8f8d22/python/dgl/dataloading/base.py#L276 | [
{
"body": "## 🐛 Bug\r\n\r\nEdge prediction sampler fails when some edges have reverses and others do not.\r\n\r\n## To Reproduce\r\n\r\n```\r\nimport dgl\r\nimport torch\r\ndata_dict = {('A','AB','B'): (torch.tensor([0,1]),torch.tensor([0,1])),\r\n ('B','BA','A'): (torch.tensor([0,1]),torch.tensor(... | 1313067e9a39389ed6246ea1d258bfa917856b84 | {
"head_commit": "7fa5cca8bb4bab9a7a53249d3fc16e00ab16816f",
"head_commit_message": "Merge branch 'master' into fix-reverse-etypes",
"patch_to_review": "diff --git a/python/dgl/dataloading/base.py b/python/dgl/dataloading/base.py\nindex d34702290511..5fcb70b87ff7 100644\n--- a/python/dgl/dataloading/base.py\n+++ ... | [
{
"diff_hunk": "@@ -622,6 +622,36 @@ def test_edge_dataloader_excludes(\n break\n \n \n+def test_edge_dataloader_exclusion_without_all_reverses():\n+ data_dict = {('A','AB','B'): (torch.tensor([0,1]),torch.tensor([0,1])),\n+ ('B','BA','A'): (torch.tensor([0,1]),torch.tensor([0,1])),\n... | c3dd57ca4a3d7bcc833714a352520a5140003acc | diff --git a/python/dgl/dataloading/base.py b/python/dgl/dataloading/base.py
index d34702290511..5fcb70b87ff7 100644
--- a/python/dgl/dataloading/base.py
+++ b/python/dgl/dataloading/base.py
@@ -280,7 +280,11 @@ def _find_exclude_eids_with_reverse_types(g, eids, reverse_etype_map):
for k, v in reverse_etype_ma... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ccxt__ccxt-14915@50b019e | ccxt/ccxt | Python | 14,915 | bybit createSpotOrder & parseLedgerEntry string math | ```
% bybit createSpotOrder ADA/USDT market buy 8 0.45
2022-09-08T23:58:43.169Z
Node.js: v18.4.0
CCXT v1.93.14
(node:15269) ExperimentalWarning: The Fetch API is an experimental feature. This feature could change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
bybit.createSpot... | 2022-09-09T00:06:48Z | Bybit: Incorrect cost calculation. How to calculate cost properly
- OS: MacOS Monterey 12.6
- Programming Language version: node js 16
- CCXT version: 1.93.105
I'm always getting 0.1% slippage when making market BUY order (I request order within 5ms after getting quote). It's incorrect. I want to buy EXACT amount ... | [
{
"body": "- OS: MacOS Monterey 12.6\r\n- Programming Language version: node js 16\r\n- CCXT version: 1.93.105\r\n\r\nI'm always getting 0.1% slippage when making market BUY order (I request order within 5ms after getting quote). It's incorrect. I want to buy EXACT amount of crypto with MARKET order. I tried ju... | 70e48d43e0962aa660b1c392f2942e9fe0738abd | {
"head_commit": "50b019ed3117dcd9a80ddd03e25b5e2599b09516",
"head_commit_message": "bybit createSpotOrder & parseLedgerEntry string math",
"patch_to_review": "diff --git a/js/bybit.js b/js/bybit.js\nindex 3ca2e14189210..25c286836d16d 100644\n--- a/js/bybit.js\n+++ b/js/bybit.js\n@@ -2729,7 +2729,10 @@ module.exp... | [
{
"diff_hunk": "@@ -4287,13 +4292,13 @@ module.exports = class bybit extends Exchange {\n //\n const currencyId = this.safeString (item, 'coin');\n const code = this.safeCurrencyCode (currencyId, currency);\n- const amount = this.safeNumber (item, 'amount');\n- const after ... | 3080afc9eb7493483d5aee205d2b357af02a9d68 | diff --git a/js/bybit.js b/js/bybit.js
index 00d47c3cc50ee..530411054ba51 100644
--- a/js/bybit.js
+++ b/js/bybit.js
@@ -2755,7 +2755,10 @@ module.exports = class bybit extends Exchange {
if (price === undefined && cost === undefined) {
throw new InvalidOrder (this.id + " createOrd... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
dmlc__dgl-5091@5ef7198 | dmlc/dgl | Python | 5,091 | [Example][Refactor] Multi-gpu graphsage link prediction example refactor | ## Description
This PR partly resolves https://github.com/dmlc/dgl/issues/5052 by refactoring the example in a similar style as other multi-gpu examples https://github.com/dmlc/dgl/pull/4430.
## Checklist
Please feel free to remove inapplicable items for your PR.
- [x] The PR title starts with [$CATEGORY] (such a... | 2022-12-29T20:30:11Z | [Refactor][Example] Refactor `examples/pytorch/graphsage/advanced`
## 🔨Work Item
- [x] Refactor `examples/pytorch/graphsage/advanced/train_sampling_unsupervised.py` to follow the latest dataloader interface and move it to `examples/pytorch/multigpu/multi_gpu_link_prediction.py`.
- [x] Remove `examples/pytorch/grap... | [
{
"body": "## 🔨Work Item\r\n\r\n- [x] Refactor `examples/pytorch/graphsage/advanced/train_sampling_unsupervised.py` to follow the latest dataloader interface and move it to `examples/pytorch/multigpu/multi_gpu_link_prediction.py`.\r\n- [x] Remove `examples/pytorch/graphsage/advanced/pure_gpu_node_classificatio... | 9169fc35414f7da16e2449ef2f7ec57b91fbd8a6 | {
"head_commit": "5ef719898dcc6880212279409accc8b78cc6bd36",
"head_commit_message": "Merge branch 'master' into refactor-multi-gpu-linkpred",
"patch_to_review": "diff --git a/examples/pytorch/graphsage/advanced/README.md b/examples/pytorch/graphsage/advanced/README.md\nindex 341d860573c6..20a0c37a6fe9 100644\n---... | [
{
"diff_hunk": "@@ -49,3 +51,23 @@ python3 multi_gpu_node_classification.py\n ```\n Test Accuracy: ~0.7632\n ```\n+\n+### Link prediction\n+\n+\n+Run with following (available dataset: \"ogbn-products\", \"reddit\")\n+\n+```bash\n+python3 multi_gpu_link_prediction.py --dataset ogbn-products\n+```\n+\n+#### __Re... | 9e626a1666c18cf871510fac064487368ba08bbb | diff --git a/examples/pytorch/graphsage/advanced/README.md b/examples/pytorch/graphsage/advanced/README.md
index 341d860573c6..20a0c37a6fe9 100644
--- a/examples/pytorch/graphsage/advanced/README.md
+++ b/examples/pytorch/graphsage/advanced/README.md
@@ -1,39 +1,12 @@
More Examples for Training GraphSAGE
============... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Code Refactoring / Architectural Improvement"
} | |
dmlc__dgl-5005@eb750d2 | dmlc/dgl | Python | 5,005 | [Bugfix] Fix empty tensors may being treated as pinned | ## Description
Fix #5004.
The root causes are two aspects:
1. Empty tensors might be treated as pinned though they're not.
2. When an empty CSR matrix is pinned, it has the `is_pinned=true` flag, but the underlying `indices` could be not pinned (empty). We should avoid calling `cudaHostGetDevicePointer` on it.
... | 2022-12-08T09:32:52Z | [Bug] `edge_subgraph` would fail with UVA when there're empty relations
## 🐛 Bug
`edge_subgraph`/`khop_in_subgraph`/`khop_out_subgraph` would fail with UVA when there're empty relations in the graph.
## To Reproduce
```python
import dgl
import torch
def create_test_heterograph2(idtype):
"""test hete... | [
{
"body": "## 🐛 Bug\r\n\r\n`edge_subgraph`/`khop_in_subgraph`/`khop_out_subgraph` would fail with UVA when there're empty relations in the graph.\r\n\r\n## To Reproduce\r\n\r\n```python\r\nimport dgl\r\nimport torch\r\n\r\ndef create_test_heterograph2(idtype):\r\n \"\"\"test heterograph from the docstring, ... | e28f07812bae274f5ba49d26629de5541c9cff60 | {
"head_commit": "eb750d29456f3df3f9ca3205b5a5f62597697df4",
"head_commit_message": "avoid calling cudaHostGetDevicePointer on nullptr",
"patch_to_review": "diff --git a/include/dgl/aten/macro.h b/include/dgl/aten/macro.h\nindex 9a0b612e0228..6d2bc8d55fc4 100644\n--- a/include/dgl/aten/macro.h\n+++ b/include/dgl/... | [
{
"diff_hunk": "@@ -33,9 +27,13 @@ NDArray IndexSelect(NDArray array, IdArray index) {\n \n // use index->ctx for pinned array\n NDArray ret = NDArray::Empty(shape, array->dtype, index->ctx);\n- if (len == 0) return ret;\n+ if (len == 0 || arr_len == 0) return ret;",
"line": null,
"original_line":... | 707b7da0353a36b65032a2bf8cd27b8c42617e78 | diff --git a/include/dgl/aten/macro.h b/include/dgl/aten/macro.h
index 9a0b612e0228..f103863fc0f4 100644
--- a/include/dgl/aten/macro.h
+++ b/include/dgl/aten/macro.h
@@ -309,7 +309,9 @@
});
#define CHECK_VALID_CONTEXT(VAR1, VAR2) \
- CHECK(((VAR1)->ctx == (VAR2)->ctx) || (VAR1).IsPinned... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} | |
dmlc__dgl-4989@7c06ecd | dmlc/dgl | Python | 4,989 | [Refactor] Replace third_party/nccl with PyTorch's NCCL backend | ## Description
Resolve #4590.
Removing our own version of NCCL will simplify code as we can use the existing communicator created by torch.disrtibuted, reduce build times, and decrease the likely-hood of conflicts of two versions of the libraries (and possibly multiple communicators).
### Performance
Traini... | 2022-12-06T03:51:42Z | Replace third_party/nccl with PyTorch's NCCL backend
## 🚀 Feature
Starting in PyTorch 1.11, `send` and `recv` are supported by `torch.distributed`, which largely means we no longer need direct access to NCCL.
To do this, we should change python/dgl/cuda/nccl.py to use `torch.distributed`, and remove `src/runtime/c... | After some investigation, `send` and `recv` have been added to `ProcessGroupNCCL` since PyTorch 1.8 https://github.com/pytorch/pytorch/pull/44921. The update of the support chart was delayed to 1.11.
So it should be safe to use `torch.distributed` since DGL is supporting PyTorch 1.9+.
This issue has been automatical... | [
{
"body": "## 🚀 Feature\r\nStarting in PyTorch 1.11, `send` and `recv` are supported by `torch.distributed`, which largely means we no longer need direct access to NCCL.\r\n\r\nTo do this, we should change python/dgl/cuda/nccl.py to use `torch.distributed`, and remove `src/runtime/cuda/nccl_api.h` and `src/run... | 73a508e15602b102d338cf60464dc8ceb50452b0 | {
"head_commit": "7c06ecd344a763cd6051f9b5b8cd221e19af5ff1",
"head_commit_message": "fix lint",
"patch_to_review": "diff --git a/.gitmodules b/.gitmodules\nindex 59686925fb99..22a0f0aae34b 100644\n--- a/.gitmodules\n+++ b/.gitmodules\n@@ -22,9 +22,6 @@\n [submodule \"third_party/nanoflann\"]\n \tpath = third_part... | [
{
"diff_hunk": "@@ -161,7 +141,9 @@ def __init__(\n )\n \n # create local tensors for the weights\n- local_size = self._partition.local_size(self._comm.rank())\n+ local_size = self._partition.local_size(\n+ self._rank if self._rank > 0 else 0",
... | f04ab6db1f2c4750219b591bf0eec5709abf32dc | diff --git a/.gitmodules b/.gitmodules
index 59686925fb99..22a0f0aae34b 100644
--- a/.gitmodules
+++ b/.gitmodules
@@ -22,9 +22,6 @@
[submodule "third_party/nanoflann"]
path = third_party/nanoflann
url = https://github.com/jlblancoc/nanoflann
-[submodule "third_party/nccl"]
- path = third_party/nccl
- url = https:... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Code Refactoring / Architectural Improvement"
} |
dmlc__dgl-4930@b5d2cd7 | dmlc/dgl | Python | 4,930 | [Dist] enable to chunk node/edge data into arbitrary number of chunks | ## Description
<!-- Brief description. Refer to the related issues if existed.
It'll be great if relevant reviewers can be assigned as well.-->
for #4888
## Checklist
Please feel free to remove inapplicable items for your PR.
- [ ] The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])... | 2022-11-22T06:19:22Z | Decouple size of the features files (for nodes and edges data) from nodes_per_chunk and edges_per_chunk entries in the metadata json for Graph Partitioning Piepline
## 🚀 Feature
<!-- A brief description of the feature proposal -->
Currently, in the distributed graph partitioning pipeline we use
nodes_per_chunk... | For large dataset, it is highly possible that we break a feature storage into tens or hundreds of files. So it is unlikely to ask every user to write a pre-processing script which will create node/edge feature files matches edges_per_chunk and nodes_per_chunk. | [
{
"body": "## 🚀 Feature\r\n<!-- A brief description of the feature proposal -->\r\n\r\nCurrently, in the distributed graph partitioning pipeline we use \r\n\r\nnodes_per_chunk\r\nedges_per_chunk\r\n\r\nto indicate the number of nodes/edges per node (or process). \r\n\r\nIn addition to this constraint, we also ... | 354a211038b669b14e7fa0d1519577996ccaf300 | {
"head_commit": "b5d2cd75c0aac809588ba5ee649857f95dfb8ed2",
"head_commit_message": "remove unnecessary shuffle data",
"patch_to_review": "diff --git a/tests/tools/create_chunked_dataset.py b/tests/tools/create_chunked_dataset.py\ndeleted file mode 100644\nindex 95d581739b47..000000000000\n--- a/tests/tools/creat... | [
{
"diff_hunk": "@@ -147,28 +260,51 @@ def get_dataset(input_dir, graph_name, rank, world_size, num_parts, schema_map):\n assert (feat_data[constants.STR_FORMAT][constants.STR_NAME]\n in [constants.STR_NUMPY, constants.STR_PARQUET])\n # It is guaranteed that num_ch... | cdc8b776a2bf6821add4b4e41a5dac1e36f81921 | diff --git a/tests/scripts/task_distributed_test.sh b/tests/scripts/task_distributed_test.sh
index 58e1c27be3e6..92fcdeb84aa2 100644
--- a/tests/scripts/task_distributed_test.sh
+++ b/tests/scripts/task_distributed_test.sh
@@ -38,4 +38,4 @@ export DMLC_LOG_DEBUG=1
python3 -m pytest -v --capture=tee-sys --junitxml=py... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
dmlc__dgl-5350@53d1737 | dmlc/dgl | Python | 5,350 | [DistDGL] add log when load graph and data | ## Description
<!-- Brief description. Refer to the related issues if existed.
It'll be great if relevant reviewers can be assigned as well.-->
fix for https://github.com/dmlc/dgl/issues/5295
## Checklist
Please feel free to remove inapplicable items for your PR.
- [ ] The PR title starts with [$CATEGORY] (such a... | 2023-02-21T07:03:41Z | Fix print statements in distDGL
## 📚 Documentation /Development
### Misleading print statements
1. When training on large graphs, distDGL takes a while to load the dataset and convert it to different storage formats (up to 1.5 hours in my experience). It does not show any log in the mean time which makes the user t... | confirmed. thanks for reporting this...
Also, I think the current code prints too many optional messages like padding info (`Pad nids from 69525 to 69524`), partition info (`part 0, train: 69525, val: 8685, test: 5506`), etc. Most of the messages should be printed only if a user turns on the verbose mode.
I changed t... | [
{
"body": "## 📚 Documentation /Development\r\n### Misleading print statements\r\n1. When training on large graphs, distDGL takes a while to load the dataset and convert it to different storage formats (up to 1.5 hours in my experience). It does not show any log in the mean time which makes the user think that... | 1313067e9a39389ed6246ea1d258bfa917856b84 | {
"head_commit": "53d1737056e02224f2f5ba66fa06258986739da3",
"head_commit_message": "fix lint",
"patch_to_review": "diff --git a/python/dgl/distributed/dist_graph.py b/python/dgl/distributed/dist_graph.py\nindex c8690f0eb64b..1925fa9dce55 100644\n--- a/python/dgl/distributed/dist_graph.py\n+++ b/python/dgl/distri... | [
{
"diff_hunk": "@@ -294,10 +301,24 @@ def load_partition_feats(\n ), \"the partition does not contain edge feature.\"\n node_feats = None\n if load_nodes:\n- node_feats = load_tensors(relative_to_config(part_files[\"node_feats\"]))\n+ feat_path = relative_to_config(part_files[\"node_fe... | 4736583a42cef795590317430e773f38f124f216 | diff --git a/python/dgl/distributed/dist_graph.py b/python/dgl/distributed/dist_graph.py
index c8690f0eb64b..1925fa9dce55 100644
--- a/python/dgl/distributed/dist_graph.py
+++ b/python/dgl/distributed/dist_graph.py
@@ -391,8 +391,13 @@ def __init__(
self.client_g.edata[k], dtype
... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
dmlc__dgl-4791@c58ba34 | dmlc/dgl | Python | 4,791 | [Dist] Create <graph_name>_stats.txt file if it does not exist before ParMETIS execution | ## Description
<!-- Brief description. Refer to the related issues if existed.
It'll be great if relevant reviewers can be assigned as well.-->
Here, we check if the <graph_name>_stats.txt does not exist then creates one in the current directory.
<graph_name>_stats.txt file has one single line with 3 columns (num_... | 2022-11-01T19:34:16Z | Check if <graph_name>_stats.txt exists and if not create one.
## 🐛 Bug
<!-- A clear and concise description of what the bug is. -->
We cannot expect use to provide "<graph_name>_stats.txt" with the dataset.
If this file does not exist then the pipeline will create one (in the current working directory).
This... | [
{
"body": "## 🐛 Bug\r\n\r\n<!-- A clear and concise description of what the bug is. -->\r\n\r\nWe cannot expect use to provide \"<graph_name>_stats.txt\" with the dataset. \r\nIf this file does not exist then the pipeline will create one (in the current working directory). \r\nThis file is needed for ParMETIS ... | c5e83757dea5b2ac1c3d1e1b03f47d47d43d1369 | {
"head_commit": "c58ba3450010a704194ba95a7782151e23e9784a",
"head_commit_message": "check if stats file exists, if not create one before parmetis run",
"patch_to_review": "diff --git a/tools/distpartitioning/parmetis_preprocess.py b/tools/distpartitioning/parmetis_preprocess.py\nindex 4f250d20b7bc..8ea3d4adab60 ... | [
{
"diff_hunk": "@@ -287,6 +287,36 @@ def gen_parmetis_input_args(params, schema_map):\n schema_map[constants.STR_NUM_NODES_PER_CHUNK],\n )\n \n+ # Check if <graph-name>_stats.txt exists, if not create one using metadata.\n+ # Here stats file will be created in the current directory. \n+ # N... | d829c6ddff8e048fa3ece05a230f61a514ecbb86 | diff --git a/tools/distpartitioning/parmetis_preprocess.py b/tools/distpartitioning/parmetis_preprocess.py
index 4f250d20b7bc..5a0bcdf63530 100644
--- a/tools/distpartitioning/parmetis_preprocess.py
+++ b/tools/distpartitioning/parmetis_preprocess.py
@@ -287,6 +287,36 @@ def gen_parmetis_input_args(params, schema_map):... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
dmlc__dgl-4933@95155e7 | dmlc/dgl | Python | 4,933 | [Feature] Add parquet support for node/edge features in chunked data | ## Description
Support node/edge features with parquet format in chunked data when doing data pre-processing. The provided parquet files are assumed to store only one NdArray, and its dim is default to 2 if not explicitly specified in the file.
## Checklist
Please feel free to remove inapplicable items for your P... | 2022-11-22T07:56:23Z | [Feature request] tools/distpartitioning/data_proc_pipeline.py need to support loading edge or node features in Parquet format.
## 🚀 Feature
The data_proc_pipeline.py, which combines ParMetis output with node and edge features, should support loading edge and node features stored in Parquet format. This is important ... | [
{
"body": "## 🚀 Feature\r\nThe data_proc_pipeline.py, which combines ParMetis output with node and edge features, should support loading edge and node features stored in Parquet format. This is important as it is common to use Spark to preprocess the graph data.\r\n\r\n## Motivation\r\n\r\n<!-- Please outline ... | 566d231a4ca5ff1cc5be31b7cf7c37fafb233d2f | {
"head_commit": "95155e78c94d90f88403478872d3cd988df1cb10",
"head_commit_message": "add e2e test for parquet",
"patch_to_review": "diff --git a/tests/tools/create_chunked_dataset.py b/tests/tools/create_chunked_dataset.py\nindex c5021d6ff1a2..95d581739b47 100644\n--- a/tests/tools/create_chunked_dataset.py\n+++ ... | [
{
"diff_hunk": "@@ -126,10 +128,13 @@ def get_dataset(input_dir, graph_name, rank, world_size, schema_map):\n if not os.path.isabs(nfeat_file):\n nfeat_file = os.path.join(input_dir, nfeat_file)\n logging.info(f'Loading node feature[{feat_name}] of... | 4945d89442cf2987f223271279f3f74744e219c5 | diff --git a/tests/tools/create_chunked_dataset.py b/tests/tools/create_chunked_dataset.py
index c5021d6ff1a2..95d581739b47 100644
--- a/tests/tools/create_chunked_dataset.py
+++ b/tests/tools/create_chunked_dataset.py
@@ -15,7 +15,7 @@
def create_chunked_dataset(
- root_dir, num_chunks, include_masks=False
+ ... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
dmlc__dgl-4790@1e12fa2 | dmlc/dgl | Python | 4,790 | [DIST] Message size to retrieve SHUFFLE_GLOBAL_NIDs is resulting in very large messages and resulting in killed process | ## Description
<!-- Brief description. Refer to the related issues if existed.
It'll be great if relevant reviewers can be assigned as well.-->
When retrieving SHUFFLE_GLOBAL_NID's for src and dst end points of the local edges in the current graph partition we used to send both the source and destination end points ... | 2022-11-01T18:41:20Z | Memory optimizations for Fe-Large graph when reading large files using pyarrow
## 🐛 Bug
<!-- A clear and concise description of what the bug is. -->
Reading large csv files using pyarrow is resulting in very large memory footprint for the python pipeline process. Even after the reading is complete this memory is... | [
{
"body": "## 🐛 Bug\r\n\r\n<!-- A clear and concise description of what the bug is. -->\r\n\r\nReading large csv files using pyarrow is resulting in very large memory footprint for the python pipeline process. Even after the reading is complete this memory is lingering around and not getting released back to t... | c5e83757dea5b2ac1c3d1e1b03f47d47d43d1369 | {
"head_commit": "1e12fa21a480260a72f8a08f9a8c2e777f00b4a1",
"head_commit_message": "Update function signature for allgather_sizes function call.",
"patch_to_review": "diff --git a/tools/distpartitioning/globalids.py b/tools/distpartitioning/globalids.py\nindex ca7236c6d869..c3698b9e7559 100644\n--- a/tools/distp... | [
{
"diff_hunk": "@@ -86,13 +86,47 @@ def lookup_shuffle_global_nids_edges(rank, world_size, edge_data, id_lookup, nod\n dictionary where keys are column names and values are numpy arrays representing all the\n edges present in the current graph partition\n '''\n+ # Make sure that the outgo... | 3856ec9ea17d75e62abf5be65eea4452d3d90131 | diff --git a/tools/distpartitioning/globalids.py b/tools/distpartitioning/globalids.py
index ca7236c6d869..f48d2534b7fb 100644
--- a/tools/distpartitioning/globalids.py
+++ b/tools/distpartitioning/globalids.py
@@ -86,13 +86,43 @@ def lookup_shuffle_global_nids_edges(rank, world_size, edge_data, id_lookup, nod
... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "Performance Optimizations"
} | |
dmlc__dgl-4704@789da75 | dmlc/dgl | Python | 4,704 | Multiple dist dl sampler | ## Description
<!-- Brief description. Refer to the related issues if existed.
It'll be great if relevant reviewers can be assigned as well.-->
This PR aims to enable the `custom pool` could be shared/used by any number of `DistDataLoaders`. This feature is required when try to inference during train. see more detai... | 2022-10-12T02:41:22Z | DistDGL doesn't allow running inference inside the training loop.
## 🐛 Bug
If we run distributed inference inside the training loop with num_sampler > 0, we will get the following error.
```
Client[6] in group[0] is exiting...
0it [00:01, ?it/s]
Traceback (most recent call last):
File "m5gnn_lp_huggingface.p... | What's behind `model.module.dist_inference`?
The root cause is all dataloaders are using the same sampler pool. I will try to figure out a way to support it.
@zheng-da @jermainewang I have just figured out a way to fix this issue with a quite simple fix. Please help review it. And pls let me re-estimate the pure effor... | [
{
"body": "## 🐛 Bug\r\n\r\nIf we run distributed inference inside the training loop with num_sampler > 0, we will get the following error.\r\n```\r\nClient[6] in group[0] is exiting...\r\n0it [00:01, ?it/s]\r\nTraceback (most recent call last):\r\n File \"m5gnn_lp_huggingface.py\", line 26, in <module>\r\n ... | ea48ce7a3742c5d4ee7c37279be741db6b45bf50 | {
"head_commit": "789da756729da7774e106ad44d6d78e2a2a2d3ee",
"head_commit_message": "fix lint",
"patch_to_review": "diff --git a/python/dgl/distributed/dist_context.py b/python/dgl/distributed/dist_context.py\nindex cea433b05d8a..ec5b4da89361 100644\n--- a/python/dgl/distributed/dist_context.py\n+++ b/python/dgl/... | [
{
"diff_hunk": "@@ -167,16 +172,20 @@ def submit_task_to_all_workers(self, func, args):\n \n def get_result(self, dataloader_name, timeout=1800):\n \"\"\"Get result from result queue\"\"\"\n- result_dataloader_name, result = self.result_queue.get(timeout=timeout)\n- assert result_datal... | d33c534da1df5f3f1ffaaf78bff2f1c00189bea2 | diff --git a/python/dgl/distributed/dist_context.py b/python/dgl/distributed/dist_context.py
index cea433b05d8a..b0ecd554d81d 100644
--- a/python/dgl/distributed/dist_context.py
+++ b/python/dgl/distributed/dist_context.py
@@ -12,6 +12,7 @@
from enum import Enum
from .. import utils
+from ..base import DGLError
fr... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
dmlc__dgl-4524@16da7d4 | dmlc/dgl | Python | 4,524 | Move mock version of dgl_sparse library to DGL main repo | ## Description
Resolves issue https://github.com/dmlc/dgl/issues/4489
This PR is a duplicate of [PR #4500](https://github.com/dmlc/dgl/pull/4500). The old PR was created on the base repo `dmlc/dgl` (not on a forked repo) by mistake.
## Checklist
Please feel free to remove inapplicable items for your PR.
- [ ] ... | 2022-09-07T17:49:10Z | Sparse Ops: Move code from temporary repo to DGL main repo
Move the codes developed in the temporary repo to DGL main repo (`python/dgl/mock_sparse`) and setup:
- Unit test & CI
- Pass lint check
- Doc
The subpackage shall NOT be imported by the main package by default to avoid breaking existing logics. | [
{
"body": "Move the codes developed in the temporary repo to DGL main repo (`python/dgl/mock_sparse`) and setup:\r\n- Unit test & CI\r\n- Pass lint check\r\n- Doc\r\n\r\nThe subpackage shall NOT be imported by the main package by default to avoid breaking existing logics.",
"number": 4489,
"title": "Spa... | 701c6fe75442918916d2a075323c90668ecfa222 | {
"head_commit": "16da7d47eb0a9b4008943538755b987ee5ddd0cd",
"head_commit_message": "rm docstring for attributes for api doc",
"patch_to_review": "diff --git a/docs/source/api/python/dgl.sparse_v0.rst b/docs/source/api/python/dgl.sparse_v0.rst\nnew file mode 100644\nindex 000000000000..149cc474e736\n--- /dev/null... | [
{
"diff_hunk": "@@ -0,0 +1,76 @@\n+import numpy as np\n+import pytest\n+import dgl\n+import dgl.backend as F\n+import torch\n+import numpy\n+import operator\n+from dgl.mock_dgl_sparse.python import elementwise_sparse\n+from dgl.mock_dgl_sparse.python.sp_matrix import SparseMatrix\n+parametrize_idtype = pytest.m... | 32430f9ab312acd71f25a1af6810acb8ba7f2b9f | diff --git a/docs/source/api/python/dgl.sparse_v0.rst b/docs/source/api/python/dgl.sparse_v0.rst
new file mode 100644
index 000000000000..98d7f3f0523d
--- /dev/null
+++ b/docs/source/api/python/dgl.sparse_v0.rst
@@ -0,0 +1,16 @@
+.. _apibackend:
+
+dgl.mock_sparse
+=================================
+
+`dgl_sparse` is a... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Code Refactoring / Architectural Improvement"
} | |
dmlc__dgl-4218@c00d0ab | dmlc/dgl | Python | 4,218 | [Example][Bugfix] Fix arma example | ## Description
To fix #4202, the crash due to in-place operations for one variable needed for backward propagation.
## Checklist
Please feel free to remove inapplicable items for your PR.
- [x] The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])
- [x] Changes are complete (i.e. I fini... | 2022-07-06T21:43:51Z | [Example][Bug] Running error on the example case: example/pytorch/arma
## 🐛 Bug
Example of using DGL to implement GNN with convolutional ARMA filters failed.
## To Reproduce
`python citation.py --gpu 0`
<!-- If you have a code sample, error messages, stack traces, please provide it here as well -->
```
T... | [
{
"body": "## 🐛 Bug\r\n\r\nExample of using DGL to implement GNN with convolutional ARMA filters failed.\r\n\r\n## To Reproduce\r\n\r\n`python citation.py --gpu 0`\r\n\r\n<!-- If you have a code sample, error messages, stack traces, please provide it here as well -->\r\n```\r\nTraceback (most recent call last)... | e3b6ac8e6c44d44028997d0913748f5adf911b87 | {
"head_commit": "c00d0abf13966c520522ba7b9333d0a2a4170b6f",
"head_commit_message": "Fix arma example",
"patch_to_review": "diff --git a/examples/pytorch/arma/model.py b/examples/pytorch/arma/model.py\nindex b3fd5a04fabd..ef6ab5bf534b 100644\n--- a/examples/pytorch/arma/model.py\n+++ b/examples/pytorch/arma/model... | [
{
"diff_hunk": "@@ -88,13 +89,14 @@ def forward(self, g, feats):\n \n if self.activation is not None:\n feats = self.activation(feats)\n- \n- if output is None:\n- output = feats\n+\n+ ... | a5cd0e530d820e03a4fd323cead7cbf808b8faea | diff --git a/examples/pytorch/arma/model.py b/examples/pytorch/arma/model.py
index b3fd5a04fabd..ff8025796ab9 100644
--- a/examples/pytorch/arma/model.py
+++ b/examples/pytorch/arma/model.py
@@ -64,7 +64,7 @@ def forward(self, g, feats):
# assume that the graphs are undirected and graph.in_degrees() is the... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
dmlc__dgl-4298@58079c6 | dmlc/dgl | Python | 4,298 | [Example][Bugfix] Fix infograph example | ## Description
To fix https://github.com/dmlc/dgl/issues/3975, the issue is due to this PR: https://github.com/dmlc/dgl/pull/3351
It crashed because of the checking condition `if len(F.shape(graph_feat)) == 1`, which indicates input feature is a 1-dim vector.
However, 1-dim vector of `graph_feat` may be attri... | 2022-07-26T01:28:08Z | InfoGraph example fails on GPU
## 🐛 Bug
Running the InfoGraph example on GPU fails.
```
return th.repeat_interleave(input, repeats, dim) # PyTorch 1.1
RuntimeError: repeats must have the same size as input along dim
```
All I did is run:
```
python infograph/semisupervised.py --gpu 0 --target mu
`... | I tried with `dgl-cu102=0.6.1, PIP, torch=1.10.1+cu102` on Ubuntu18.04 and it works well.
have you tried to train with CPU? does it work well on cpu?
It is actually the same issue on CPU as well. When trying other examples like gcn, ...etc. Both modes, CPU and GPU work.
I just find the same issue is hit in `dgl-cu10... | [
{
"body": "## 🐛 Bug\r\n\r\nRunning the InfoGraph example on GPU fails.\r\n\r\n```\r\n return th.repeat_interleave(input, repeats, dim) # PyTorch 1.1\r\nRuntimeError: repeats must have the same size as input along dim\r\n```\r\n\r\nAll I did is run:\r\n\r\n```\r\n python infograph/semisupervised.py --gpu 0 --... | 14a77c86468237ffdd5454f3ccbcd40ef47e79d3 | {
"head_commit": "58079c65d1bdf5b74b388f810ba176d5b8925953",
"head_commit_message": "Update",
"patch_to_review": "diff --git a/python/dgl/readout.py b/python/dgl/readout.py\nindex 5492afcdacd0..d52a73a273ec 100644\n--- a/python/dgl/readout.py\n+++ b/python/dgl/readout.py\n@@ -1,7 +1,7 @@\n \"\"\"Classes and funct... | [
{
"diff_hunk": "@@ -417,8 +417,9 @@ def broadcast_nodes(graph, graph_feat, *, ntype=None):\n broadcast_edges\n \"\"\"\n if (F.shape(graph_feat)[0] != graph.batch_size and graph.batch_size == 1):\n- dgl_warning('If single graph, please make sure the batching dimension is added'\n- ... | aae7d765e4a25fa3d748f316602948e252c7624e | diff --git a/python/dgl/readout.py b/python/dgl/readout.py
index 5492afcdacd0..698e50bf0be5 100644
--- a/python/dgl/readout.py
+++ b/python/dgl/readout.py
@@ -1,7 +1,7 @@
"""Classes and functions for batching multiple graphs together."""
from __future__ import absolute_import
-from .base import DGLError
+from .base... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
dmlc__dgl-3892@98afbd1 | dmlc/dgl | Python | 3,892 | [Feature] Enable UVA sampling with CPU indices | ## Description
This PR enables specifying indices on CPU for UVA sampling to avoid duplicating the indices for every GPU.
It also adds a utility function `dgl.multiprocessing.call_once_and_share()` which calls a function in a single process and share the result to other processes. Requires using `dgl.multiprocessi... | 2022-03-29T15:02:52Z | Allow UVA sampling where train_nid/train_eid is provided on the CPU
## 🚀 Feature
For many sampling techniques, the number of input nodes is much larger than the number of output nodes. As a result the cost of copying the output_nodes in a mini-batch to the GPU is relatively negligible (especially since intermediate l... | I don't quite get it :( Could you give an example showing the problem?
Right now, to use UVA sampling, a user must copy train_id to the GPU:
```
train_id = train_id.to(dev_id)
dataloader.DataLoader(g, train_id, ...)
```
For multi-GPU runs, this is even trickier, as the user must manually partition the ids bef... | [
{
"body": "## 🚀 Feature\r\nFor many sampling techniques, the number of input nodes is much larger than the number of output nodes. As a result the cost of copying the output_nodes in a mini-batch to the GPU is relatively negligible (especially since intermediate layer seed nodes will be produced on the GPU in ... | 0d878ff8ef063e80d437c3a0535a92fd3d96d225 | {
"head_commit": "98afbd1be62ae4989d383de5b628605af19a1541",
"head_commit_message": "Merge branch 'fix-cpu-uva' of github.com:BarclayII/dgl into fix-cpu-uva",
"patch_to_review": "diff --git a/docs/source/api/python/dgl.multiprocessing.rst b/docs/source/api/python/dgl.multiprocessing.rst\nindex 879d5bcda97d..05974... | [
{
"diff_hunk": "@@ -63,8 +63,8 @@ def inference(self, g, device, batch_size, num_workers, buffer_device=None):\n train_idx, valid_idx, test_idx = split_idx['train'], split_idx['valid'], split_idx['test']\n \n device = 'cuda'\n-train_idx = train_idx.to(device)\n-valid_idx = valid_idx.to(device)\n+#train_idx = tr... | 22417009a939e9c0ca2702b0538a57c1ce33b440 | diff --git a/docs/source/api/python/dgl.multiprocessing.rst b/docs/source/api/python/dgl.multiprocessing.rst
index 879d5bcda97d..46f277310386 100644
--- a/docs/source/api/python/dgl.multiprocessing.rst
+++ b/docs/source/api/python/dgl.multiprocessing.rst
@@ -12,3 +12,11 @@ additional documentation.
In addition, if y... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
dmlc__dgl-3870@a1e0fc9 | dmlc/dgl | Python | 3,870 | [Bug] Fix multiple issues in distributed multi-GPU GraphSAGE example | * Previously running the GraphSAGE example with multi-GPU multi-machine will throw device mismatch error.
* Removed `pad_data` and try `torch.distributed.algorithms.join.Join` to deal with uneven training set sizes. | 2022-03-22T07:31:35Z | Bug in DistDGL when the batch size is small
## 🐛 Bug
The problem appears when the used batch size is small. This results in different trainers to have different number of batches and while training some trainers will finish earlier than other. The result is that the other trainers will be stuck at synchronization.
... | Thanks for reporting. This is also the problem for pure PyTorch distributed training, that number of batches should be the same for all the trainer, otherwise the barrier operation will be blocked. Our current solution is to manually truncate the larger num batches into the same number for all the traininer
I made a sa... | [
{
"body": "## 🐛 Bug\r\n\r\nThe problem appears when the used batch size is small. This results in different trainers to have different number of batches and while training some trainers will finish earlier than other. The result is that the other trainers will be stuck at synchronization.\r\n\r\n## To Reproduc... | 16409ff8523df3bb69258c1773f3221c0ba906b3 | {
"head_commit": "a1e0fc9560ed55be45d65a78c19c2b7553060c3a",
"head_commit_message": "update version requirement in README",
"patch_to_review": "diff --git a/examples/pytorch/graphsage/dist/README.md b/examples/pytorch/graphsage/dist/README.md\nindex 7d5b05d32e88..7d6bb4e77d2f 100644\n--- a/examples/pytorch/graphs... | [
{
"diff_hunk": "@@ -233,43 +204,46 @@ def run(args, device, data):\n # Loop over the dataloader to sample the computation dependency graph as a list of\n # blocks.\n step_time = []\n- for step, blocks in enumerate(dataloader):\n- tic_step = time.time()\n- sam... | fc951eb600e711befa828802617b540b1eeb4cfc | diff --git a/docs/source/guide/distributed.rst b/docs/source/guide/distributed.rst
index 3dd443767325..c9d92a22b1fb 100644
--- a/docs/source/guide/distributed.rst
+++ b/docs/source/guide/distributed.rst
@@ -53,14 +53,15 @@ are the same as :ref:`mini-batch training <guide-minibatch>`.
# training loop
for epo... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
dmlc__dgl-3862@b31f346 | dmlc/dgl | Python | 3,862 | [Bugfix] Fix UVA sampling with lazy feature slicing | Fixes #3847 .
@jermainewang I might need your opinion on the behavior addition on lazy feature slicing. Now if a graph is previously in CPU pinned memory and a subgraph (`sample_neighbors`) is taken, the new graph's features will be on GPU. Previously it was on CPU. This further complicates the code in `Column.da... | 2022-03-18T14:46:58Z | GraphSAGE UVA sampling code crashes when not specifying feature prefetching
## 🐛 Bug
See below.
## To Reproduce
Steps to reproduce the behavior:
1. Delete `prefetch_node_feats` and `prefetch_labels` argument in `examples/pytorch/graphsage/node_classification.py`.
2. Run and it crashes with the following e... | [
{
"body": "## 🐛 Bug\r\n\r\nSee below.\r\n\r\n## To Reproduce\r\n\r\nSteps to reproduce the behavior:\r\n\r\n1. Delete `prefetch_node_feats` and `prefetch_labels` argument in `examples/pytorch/graphsage/node_classification.py`.\r\n2. Run and it crashes with the following error:\r\n ```\r\n dgl._ffi.base.DGL... | 223a3da5aede2ec555289af760888e4b50fd2de4 | {
"head_commit": "b31f3461893a835a66182d960e2d992714885b44",
"head_commit_message": "fix uva sampling with features",
"patch_to_review": "diff --git a/python/dgl/dataloading/dataloader.py b/python/dgl/dataloading/dataloader.py\nindex 10852d9c0be3..af1bd2815298 100644\n--- a/python/dgl/dataloading/dataloader.py\n+... | [
{
"diff_hunk": "@@ -5,21 +5,22 @@\n from .tensor import BaseTensorStorage\n from ..utils import gather_pinned_tensor_rows\n \n-def _fetch_cpu(indices, tensor, feature_shape, device, pin_memory):\n+def _fetch_cpu(indices, tensor, feature_shape, device, pin_memory, **kwargs):\n result = torch.empty(\n ... | 479234117165c08f6dc7b4953885be0f1264067f | diff --git a/python/dgl/dataloading/base.py b/python/dgl/dataloading/base.py
index 8d70097ea341..3b73b2637ea5 100644
--- a/python/dgl/dataloading/base.py
+++ b/python/dgl/dataloading/base.py
@@ -1,5 +1,5 @@
"""Base classes and functionalities for dataloaders"""
-from collections import Mapping
+from collections.abc im... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} | |
dmlc__dgl-4826@53f5f5c | dmlc/dgl | Python | 4,826 | [Model] Add `dgl.nn.CuGraphRelGraphConv` model | ## Description
<!-- Brief description. Refer to the related issues if existed.
It'll be great if relevant reviewers can be assigned as well.-->
This PR adds a RGCN model, `dgl.nn.CuGraphRelGraphConv`, that uses the accelerated sparse aggregation primitives in cugraph-ops. The model requires `pylibcugraphops>=22.12... | 2022-11-07T02:37:46Z | [FEA] Create RGCN model using cugraph-ops aggregators
## 🚀 Feature
This integration creates an accelerated R-GCN model that uses the aggregation functions from `pylibcugraphops`, a Python wrapper around cugraph-ops aggregators.
Per our previous discussion, this new model `dgl.contrib.cugraph.nn.RelGraphConv` shoul... | This issue has been automatically marked as stale due to lack of activity. It will be closed if no further activity occurs. Thank you | [
{
"body": "## 🚀 Feature\r\nThis integration creates an accelerated R-GCN model that uses the aggregation functions from `pylibcugraphops`, a Python wrapper around cugraph-ops aggregators.\r\n\r\nPer our previous discussion, this new model `dgl.contrib.cugraph.nn.RelGraphConv` should mimic the interface of exis... | 2caef17eb8481ea42503a9843aad77af2710b425 | {
"head_commit": "53f5f5c0708646a5bd7b52ca74c72865a2743683",
"head_commit_message": "update docs",
"patch_to_review": "diff --git a/docs/source/api/python/nn-pytorch.rst b/docs/source/api/python/nn-pytorch.rst\nindex c550e5444c61..fffbe527f6f3 100644\n--- a/docs/source/api/python/nn-pytorch.rst\n+++ b/docs/source... | [
{
"diff_hunk": "@@ -0,0 +1,388 @@\n+\"\"\"Torch Module for Relational graph convolution layer using the\n+aggregation primitives in cugraph-ops\"\"\"\n+# pylint: disable=no-member, arguments-differ, invalid-name, too-many-arguments\n+import math\n+\n+import torch as th\n+from torch import nn\n+\n+try:\n+ fro... | 400423958179597700970578beb5205c1b805d22 | diff --git a/docs/source/api/python/nn-pytorch.rst b/docs/source/api/python/nn-pytorch.rst
index c550e5444c61..fffbe527f6f3 100644
--- a/docs/source/api/python/nn-pytorch.rst
+++ b/docs/source/api/python/nn-pytorch.rst
@@ -14,6 +14,7 @@ Conv Layers
~dgl.nn.pytorch.conv.GraphConv
~dgl.nn.pytorch.conv.EdgeWeigh... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
dmlc__dgl-2428@d34bbb8 | dmlc/dgl | Python | 2,428 | [hotfix] Make USE_AVX a flag in cmake to avoid compilation error for arm user | ## Description
To fix #2424 .
## Checklist
Please feel free to remove inapplicable items for your PR.
- [x] The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])
- [x] Changes are complete (i.e. I finished coding on this PR)
- [x] All changes have test coverage
- [x] Code is well-docu... | 2020-12-17T05:28:17Z | Compilation on osx-arm64 apple silicon m1
## 🐛 Bug
Trying to compile from source on the new macbook air with arm64e.
## To Reproduce
mkdir build
cd build
cmake ..
make -j 8
```
/Users/yingzhu/dgl/include/intel/cpu_support.h:70:16: error: no type named 'Reg64' in namespace 'Xbyak'
const Xbyak::Reg64... | Yes that's related to intel-specific optimizations (use AVX instructions, see #2309 ). Actually we should only include this header when a intel CPU with avx support is detected, I'll fix it soon.
@yzh119 thanks keep me posted. sorry for being dense but setting `DGL_CPU_INTEL_KERNEL_ENABLED=0` doesn't work for me - any ... | [
{
"body": "## 🐛 Bug\r\n\r\nTrying to compile from source on the new macbook air with arm64e. \r\n\r\n## To Reproduce\r\n\r\nmkdir build\r\ncd build\r\ncmake ..\r\nmake -j 8\r\n\r\n```\r\n/Users/yingzhu/dgl/include/intel/cpu_support.h:70:16: error: no type named 'Reg64' in namespace 'Xbyak'\r\n const Xbyak::Re... | 50f1f4ae780677374db79af5b91a6b043bbebf54 | {
"head_commit": "d34bbb8ed915455c386f800d853c9669cc13739e",
"head_commit_message": "upd",
"patch_to_review": "diff --git a/CMakeLists.txt b/CMakeLists.txt\nindex 0abcd52fe732..9af440317ad6 100644\n--- a/CMakeLists.txt\n+++ b/CMakeLists.txt\n@@ -24,6 +24,7 @@ endif()\n # Alernatively, use cmake -DOPTION=VALUE thr... | [
{
"diff_hunk": "@@ -13,8 +13,10 @@\n #include <memory>\n #include \"spmm_binary_ops.h\"\n #if !defined(_WIN32)\n+#ifdef WITH_AVX\n #include \"intel/cpu_support.h\"\n #endif\n+#endif",
"line": null,
"original_line": 19,
"original_start_line": null,
"path": "src/array/cpu/spmm.h",
"start_line"... | 2d5fa9af911ee6b72b1219fb91ec430391fcf384 | diff --git a/CMakeLists.txt b/CMakeLists.txt
index 0abcd52fe732..0e23c3dc24a5 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -24,6 +24,7 @@ endif()
# Alernatively, use cmake -DOPTION=VALUE through command-line.
dgl_option(USE_CUDA "Build with CUDA" OFF)
dgl_option(USE_OPENMP "Build with OpenMP" ON)
+dgl_option(... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
dmlc__dgl-1323@b39404e | dmlc/dgl | Python | 1,323 | [Bugfix] Allows node types with no inbound/outbound edges | ## Description
This fixes #1320 by adding new ctor:
```c++
CreateHeteroGraph(meta_graph, rel_graphs, num_nodes_per_type)
```
where the third argument is a `std::vector` containing the number of nodes for each node type.
## Checklist
Please feel free to remove inapplicable items for your PR.
- [x] The PR title... | 2020-03-06T14:59:17Z | [BUG] dgl.heterograph() not supporting node types with no inbound/outbound edges
## 🐛 Bug
See below:
## To Reproduce
```
In [2]: g = dgl.heterograph({('A', 'AB', 'B'): [(0, 1), (1, 2)]}, num_nodes_dict={'A': 3, 'B': 3, 'C': 3})
In [3]: g
Out[3]:
Graph(num_nodes={'A': 3, 'B': 3},
num_edges={('A',... | Maybe you can write like :
```python
g = dgl.heterograph({('A', 'AB', 'B'): [(0, 1), (1, 2)], ('C','_','C'):[]},
num_nodes_dict={'A': 3, 'B': 3, 'C': 3})
```
> Maybe you can write like :
>
> ```python
> g = dgl.heterograph({('A', 'AB', 'B'): [(0, 1), (1, 2)], ('C','_','C'):[]}... | [
{
"body": "## 🐛 Bug\r\n\r\nSee below:\r\n\r\n## To Reproduce\r\n\r\n```\r\nIn [2]: g = dgl.heterograph({('A', 'AB', 'B'): [(0, 1), (1, 2)]}, num_nodes_dict={'A': 3, 'B': 3, 'C': 3})\r\n\r\nIn [3]: g\r\nOut[3]: \r\nGraph(num_nodes={'A': 3, 'B': 3},\r\n num_edges={('A', 'AB', 'B'): 2},\r\n metagraph=[(... | ac74233c8c2789a6d051b90059e5a5bc236b7672 | {
"head_commit": "b39404ee108ad9e26007755bc110574bc55993b4",
"head_commit_message": "remove function with rvalue reference",
"patch_to_review": "diff --git a/include/dgl/base_heterograph.h b/include/dgl/base_heterograph.h\nindex 237cbea5c797..139c6f506ab8 100644\n--- a/include/dgl/base_heterograph.h\n+++ b/includ... | [
{
"diff_hunk": "@@ -547,6 +553,15 @@ DGL_DEFINE_OBJECT_REF(FlattenedHeteroGraphRef, FlattenedHeteroGraph);\n HeteroGraphPtr CreateHeteroGraph(\n GraphPtr meta_graph, const std::vector<HeteroGraphPtr>& rel_graphs);\n \n+/*!\n+ * \\brief Create a heterograph from meta graph and a list of bipartite graph,\n+ *... | 01b18e6791b0991d04bfda924fc8130e7fe6fe0b | diff --git a/include/dgl/base_heterograph.h b/include/dgl/base_heterograph.h
index 237cbea5c797..1baa1bbe5bf8 100644
--- a/include/dgl/base_heterograph.h
+++ b/include/dgl/base_heterograph.h
@@ -125,6 +125,12 @@ class BaseHeteroGraph : public runtime::Object {
/*! \return the number of vertices in the graph.*/
vi... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
dmlc__dgl-320@d0b5f19 | dmlc/dgl | Python | 320 | [Bugfix] Fix multiple send recv | ## Description
This PR fixes #75 and other small bugs (see below) and supports multiple recv after send.
Previously, each recv call clears message graph so following recv won't see any message. This PR fix the bug by removing message graph and put message in edge space (but still in a separate message frame). Now m... | 2018-12-17T22:49:39Z | [BUG] Consecutive sends without recv
Here's the test I was running on `cpp` branch.
```python
def test_send_twice():
g = DGLGraph()
g.add_nodes(2)
g.add_edge(0, 1)
def _message_a(src, edge):
return {'a': src['a']}
def _message_b(src, edge):
return {'b': src['b']}
def _r... | The issue is because we didn't check whether the edges have been triggered or not. I think it's a good time to think about the case thoroughly (suppose we still want to keep the send/recv flexibility here):
* If the given edges have been triggered before, we should use `update_rows` instead of `append` to save the mes... | [
{
"body": "Here's the test I was running on `cpp` branch.\r\n```python\r\ndef test_send_twice():\r\n g = DGLGraph()\r\n g.add_nodes(2)\r\n g.add_edge(0, 1)\r\n def _message_a(src, edge):\r\n return {'a': src['a']}\r\n def _message_b(src, edge):\r\n return {'b': src['b']}\r\n def ... | 896dc50e70f541157643edca32d1ada401ff1f8f | {
"head_commit": "d0b5f19185912fd6bd495dae585ac6bd61c2165f",
"head_commit_message": "test multi-send-recv after conversion",
"patch_to_review": "diff --git a/python/dgl/frame.py b/python/dgl/frame.py\nindex 4451c8fcdcb2..0d5374a61800 100644\n--- a/python/dgl/frame.py\n+++ b/python/dgl/frame.py\n@@ -366,6 +366,20 ... | [
{
"diff_hunk": "@@ -188,10 +188,14 @@ def __init__(self,\n self._edge_frame = FrameRef(Frame(num_rows=self.number_of_edges()))\n else:\n self._edge_frame = edge_frame\n- # msg graph & frame\n- self._msg_graph = create_graph_index(multigraph=multigraph)\n- sel... | 90182b9c3346dfb971f9c70e0b054ba68cc7d7d7 | diff --git a/python/dgl/backend/backend.py b/python/dgl/backend/backend.py
index 568c984174b9..ecddaa5a1407 100644
--- a/python/dgl/backend/backend.py
+++ b/python/dgl/backend/backend.py
@@ -618,7 +618,7 @@ def unique(input):
"""
pass
-def full_1d(length, fill_value):
+def full_1d(length, fill_value, dtype,... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
dmlc__dgl-1305@03783e8 | dmlc/dgl | Python | 1,305 | [Feature] Automatically determine the backend of dgl.nn | ## Description
Fixes #1292 .
`import dgl` no longer imports `dgl.nn` automatically. | 2020-03-04T02:59:18Z | AttributeError: module 'dgl.nn' has no attribute 'pytorch'
## 🐛 Bug
When I try to use some of the predefined modules of dgl by the following code, I encounter an error: AttributeError: module 'dgl.nn' has no attribute 'pytorch'.
Similar problems also happen to other backends, including TensorFlow and MXNet.
#... | > Add 3 lines of code like `from . import pytorch` into file `dgl/nn/__init__.py` for PyTorch and the other 2 backends.
> It is better to automatically detect the backend library and import the correct sub-directory.
I would prefer the latter solution. The former solution would require all backends to be installed... | [
{
"body": "## 🐛 Bug\r\n\r\nWhen I try to use some of the predefined modules of dgl by the following code, I encounter an error: AttributeError: module 'dgl.nn' has no attribute 'pytorch'.\r\n\r\nSimilar problems also happen to other backends, including TensorFlow and MXNet.\r\n\r\n## To Reproduce\r\n\r\nSteps ... | 93ac29ce3446ff5d82f9ec91eb597ca236cbd8fb | {
"head_commit": "03783e863a9c4eee15f059a35c2790a078ae3542",
"head_commit_message": "rename load_backend to private",
"patch_to_review": "diff --git a/python/dgl/__init__.py b/python/dgl/__init__.py\nindex a2df8416b893..890a80552399 100644\n--- a/python/dgl/__init__.py\n+++ b/python/dgl/__init__.py\n@@ -8,7 +8,6 ... | [
{
"diff_hunk": "@@ -1 +1,12 @@\n \"\"\"Package for neural network common components.\"\"\"\n+import os\n+import importlib\n+import sys\n+\n+def _load_backend(mod_name):\n+ mod = importlib.import_module('.%s' % mod_name, __name__)\n+ thismod = sys.modules[__name__]\n+ for api, obj in mod.__dict__.items(... | a198111ba5187e31aecaa96c87ae65f3eb46df5f | diff --git a/python/dgl/__init__.py b/python/dgl/__init__.py
index dd3d4e51ffd8..2eb84b5bd78d 100644
--- a/python/dgl/__init__.py
+++ b/python/dgl/__init__.py
@@ -8,7 +8,6 @@
from .backend import load_backend
from . import function
-from . import nn
from . import contrib
from . import container
from . import ran... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
dmlc__dgl-4620@5297d27 | dmlc/dgl | Python | 4,620 | [Dist] enable to partition many chunks into less partitions via pipeline | ## Description
<!-- Brief description. Refer to the related issues if existed.
It'll be great if relevant reviewers can be assigned as well.-->
`num_chunks` could be larger/equal than `num_parts`. Target for https://github.com/dmlc/dgl/issues/4362
## Checklist
Please feel free to remove inapplicable items for your... | 2022-09-22T07:52:26Z | Support the input graph split into many files. Decouple number of data chunks & number of partitions
## 🚀 Feature
<!-- A brief description of the feature proposal -->
## Motivation
<!-- Please outline the motivation for the proposal. Is your feature request
related to a problem? e.g., I'm always frustrated whe... | [
{
"body": "## 🚀 Feature\r\n<!-- A brief description of the feature proposal -->\r\n\r\n## Motivation\r\n\r\n<!-- Please outline the motivation for the proposal. Is your feature request\r\nrelated to a problem? e.g., I'm always frustrated when [...]. If this is\r\nrelated to another GitHub issue, please link he... | 6c1500d49fdb3feb704b0693ce9dd9a1a9aa2f2b | {
"head_commit": "5297d27ef2adda24403d6d2544368e4a0d120a8e",
"head_commit_message": "[Dist] enable to partition many chunks into less partitions via pipeline",
"patch_to_review": "diff --git a/tests/tools/test_dist_part.py b/tests/tools/test_dist_part.py\nindex 9aee9d1462b8..13c3e6935199 100644\n--- a/tests/tools... | [
{
"diff_hunk": "@@ -387,6 +381,8 @@ def get_idranges(names, counts):\n list of node/edge types as strings\n counts : list of lists\n each list contains no. of nodes/edges in a given chunk\n+ expected_num_chunks : expected number of returned chunks\n+ chunks are collapsed according ... | 5f245c898f115bc19334a91249a12a219397b885 | diff --git a/tests/tools/test_dist_part.py b/tests/tools/test_dist_part.py
index f0f3aedb9ccd..ecb094412557 100644
--- a/tests/tools/test_dist_part.py
+++ b/tests/tools/test_dist_part.py
@@ -1,23 +1,26 @@
-import argparse
-import dgl
import json
import numpy as np
import os
-import sys
import tempfile
import torch... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
dmlc__dgl-4623@edc9361 | dmlc/dgl | Python | 4,623 | Edge Feature support for input graph datasets for dist. graph partitioning pipeline | ## Description
<!-- Brief description. Refer to the related issues if existed.
It'll be great if relevant reviewers can be assigned as well.-->
## Checklist
Please feel free to remove inapplicable items for your PR.
- [ ] The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])
- [X] Chan... | 2022-09-22T21:05:11Z | Support graphs with edge features
## 🚀 Feature
<!-- A brief description of the feature proposal -->
## Motivation
<!-- Please outline the motivation for the proposal. Is your feature request
related to a problem? e.g., I'm always frustrated when [...]. If this is
related to another GitHub issue, please link h... | [
{
"body": "## 🚀 Feature\r\n<!-- A brief description of the feature proposal -->\r\n\r\n## Motivation\r\n\r\n<!-- Please outline the motivation for the proposal. Is your feature request\r\nrelated to a problem? e.g., I'm always frustrated when [...]. If this is\r\nrelated to another GitHub issue, please link he... | 72cfb9342f0bf53f50d928008a808a9d39c116b9 | {
"head_commit": "edc936165c128fabc538136dd7fe549bda81e9cc",
"head_commit_message": "Addressing CI review comments.",
"patch_to_review": "diff --git a/tests/tools/test_edges_with_features.py b/tests/tools/test_edges_with_features.py\nnew file mode 100644\nindex 000000000000..b62ad5f68356\n--- /dev/null\n+++ b/tes... | [
{
"diff_hunk": "@@ -172,7 +172,7 @@ def exchange_edge_data(rank, world_size, edge_data):\n edge_data.pop(constants.OWNER_PROCESS)\n return edge_data\n \n-def exchange_node_features(rank, world_size, node_feature_tids, ntype_gnid_map, id_lookup, node_features):\n+def exchange_node_features(rank, world_si... | edc7de589c777421a41dc85cbb20121e44f30bbc | diff --git a/tests/tools/create_chunked_dataset.py b/tests/tools/create_chunked_dataset.py
new file mode 100644
index 000000000000..fa093ee1a111
--- /dev/null
+++ b/tests/tools/create_chunked_dataset.py
@@ -0,0 +1,214 @@
+import argparse
+import json
+import logging
+import os
+import platform
+import sys
+import tempf... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
dmlc__dgl-2035@de45b33 | dmlc/dgl | Python | 2,035 | [Bugfix] Fix batching isolated node types | This fixes #1837 where `dgl.batch()` discards node types with no relations. | 2020-08-17T09:12:49Z | Number of nodes wrong when batching blocks
## 🐛 Bug
See the following reproduction code
## To Reproduce
```python
plays_spmat = ssp.coo_matrix(([1, 1, 1, 1], ([0, 1, 2, 1], [0, 0, 1, 1])))
wishes_nx = nx.DiGraph()
wishes_nx.add_nodes_from(['u0', 'u1', 'u2'], bipartite=0)
wishes_nx.add_nodes_from(['g0', 'g... | It seems batching of block is not well tested
I also came across a batching problem, directly with heterographs:
```
g0 = dgl.heterograph({
('user', 'plays', 'game'): [(0, 0), (1, 0), (1, 1), (2, 1)],
}, num_nodes_dict={"foo":1, "user":3, "game":2})
g1 = dgl.heterograph({
('user', 'plays', 'game'):... | [
{
"body": "## 🐛 Bug\r\n\r\nSee the following reproduction code\r\n\r\n## To Reproduce\r\n\r\n```python\r\nplays_spmat = ssp.coo_matrix(([1, 1, 1, 1], ([0, 1, 2, 1], [0, 0, 1, 1])))\r\nwishes_nx = nx.DiGraph()\r\nwishes_nx.add_nodes_from(['u0', 'u1', 'u2'], bipartite=0)\r\nwishes_nx.add_nodes_from(['g0', 'g1'],... | be444e52d99ef94052c9b5a574c4c41ac41f8868 | {
"head_commit": "de45b3303d73ca0153906d8685060bc000a80532",
"head_commit_message": "Merge branch 'fix-1837' of https://github.com/BarclayII/dgl into fix-1837",
"patch_to_review": "diff --git a/python/dgl/batch.py b/python/dgl/batch.py\nindex 6bfba4125383..3676e35eda81 100644\n--- a/python/dgl/batch.py\n+++ b/pyt... | [
{
"diff_hunk": "@@ -105,3 +105,31 @@ def random_bipartite(size_src, size_dst):\n def random_block(size):\n g = dgl.graph(nx.erdos_renyi_graph(size, 0.1))\n return dgl.to_block(g, np.unique(F.zerocopy_to_numpy(g.edges()[1])))\n+\n+@register_case(['two_hetero_batch'])\n+def two_hetero_batch():\n+ g1 = ... | 30716d97bbca00dd22fd72399a52bba22520e90b | diff --git a/python/dgl/batch.py b/python/dgl/batch.py
index 7d3c4041ea55..b81f031cfd5b 100644
--- a/python/dgl/batch.py
+++ b/python/dgl/batch.py
@@ -1,5 +1,6 @@
"""Utilities for batching/unbatching graphs."""
from collections.abc import Mapping
+from collections import defaultdict
from . import backend as F
fro... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
explosion__spaCy-11745@13a6324 | explosion/spaCy | Python | 11,745 | Revert disable/disabled merging behavior | ## Description
<!--- Use this section to describe your changes. If your changes required
testing, include information about the testing environment and the tests you
ran. If your test fixes a bug reported in an issue, don't forget to include the
issue number. If your PR is still a work in progress, that's totally f... | 2022-11-03T12:36:09Z | UserWarning W123 printed on console after upgrading to 3.4.2
After upgrading to `3.4.2` I see this warning on the console when a model is loaded. How to fix or silence this?
> spacy/language.py:1895: UserWarning: [W123] Argument disable with value [] is used instead of ['senter'] as specified in the config. Be aware... | Thanks for the heads-up, I confirmed this behavior. It's probably related to #11459.
This only happens for me when using the `en_core_web_sm.load()` style of loading - there's no warning with `spacy.load()`.
We'll take a look at this, but it should be safe to ignore if the behavior it warns about is what you wa... | [
{
"body": "After upgrading to `3.4.2` I see this warning on the console when a model is loaded. How to fix or silence this?\r\n\r\n> spacy/language.py:1895: UserWarning: [W123] Argument disable with value [] is used instead of ['senter'] as specified in the config. Be aware that this might affect other componen... | 40e1000db08858e8c928efacab8f710e027dde61 | {
"head_commit": "13a6324673fc7e846fb72a68627ac71e4f92630e",
"head_commit_message": "Merge disable with disabled. Adjust warnings, errors and tests.",
"patch_to_review": "diff --git a/spacy/errors.py b/spacy/errors.py\nindex e0628819dc9..5e17053cf70 100644\n--- a/spacy/errors.py\n+++ b/spacy/errors.py\n@@ -212,8 ... | [
{
"diff_hunk": "@@ -615,20 +615,18 @@ def test_enable_disable_conflict_with_config():\n \n with make_tempdir() as tmp_dir:\n nlp.to_disk(tmp_dir)\n- # Expected to fail, as config and arguments conflict.\n- with pytest.raises(ValueError):\n- spacy.load(\n- tmp_... | 4f526ebd1a419e93f73ab5d0c30bf3268b0b84c9 | diff --git a/spacy/errors.py b/spacy/errors.py
index e0628819dc9..5e17053cf70 100644
--- a/spacy/errors.py
+++ b/spacy/errors.py
@@ -212,8 +212,8 @@ class Warnings(metaclass=ErrorsWithCodes):
W121 = ("Attempting to trace non-existent method '{method}' in pipe '{pipe}'")
W122 = ("Couldn't trace method '{method... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
explosion__spaCy-11506@de97dac | explosion/spaCy | Python | 11,506 | Remove side effects from Doc.__init__() | ## Description
The existing version of `Doc.__init__()` changes `sent_starts` and `ents` lists passed as parameters. This PR removes these side effects.
Closes [#11499.](https://github.com/explosion/spaCy/issues/11499)
### Types of change
Bugfix
## Checklist
<!--- Before you submit the PR, go over this chec... | 2022-09-15T08:27:15Z | Doc.init changes input to is_sent_start to List[int]
Hey,
I just stumbled accross the following behaviour, when creating a Doc manually. Is this intended behaviour?
## How to reproduce the behaviour
import spacy
from spacy.tokens import Doc
nlp = spacy.blank("xx")
words_1 = ["This","is","the",... | Thanks for letting us know about this, I'll have a look at fixing it. | [
{
"body": "Hey,\r\n\r\nI just stumbled accross the following behaviour, when creating a Doc manually. Is this intended behaviour?\r\n\r\n## How to reproduce the behaviour\r\n import spacy\r\n from spacy.tokens import Doc\r\n nlp = spacy.blank(\"xx\")\r\n words_1 = [\"This\",\"is\",\"the\",\"first\",... | 7c98245c0c0f9c6c0c4a523c0bf1a75690e58620 | {
"head_commit": "de97dac2aee3097c6efe3cbc60803062b95e4cd0",
"head_commit_message": "Remove side effects from Doc.__init__()",
"patch_to_review": "diff --git a/spacy/tests/doc/test_doc_api.py b/spacy/tests/doc/test_doc_api.py\nindex a64ab2ba89b..0cfea24a782 100644\n--- a/spacy/tests/doc/test_doc_api.py\n+++ b/spa... | [
{
"diff_hunk": "@@ -285,27 +285,27 @@ cdef class Doc:\n heads = [0] * len(deps)\n if heads and not deps:\n raise ValueError(Errors.E1017)\n+ _sent_starts: Optional[List[int]] = [] if sent_starts is not None else None",
"line": null,
"original_line": 288,
"origi... | beb4b7a69a7208bbdfcd0221153a8aa28b36f7d3 | diff --git a/spacy/tests/doc/test_doc_api.py b/spacy/tests/doc/test_doc_api.py
index a64ab2ba89b..38003dea9eb 100644
--- a/spacy/tests/doc/test_doc_api.py
+++ b/spacy/tests/doc/test_doc_api.py
@@ -82,6 +82,21 @@ def test_issue2396(en_vocab):
assert (span.get_lca_matrix() == matrix).all()
+@pytest.mark.issue(11... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
dmlc__dgl-4483@6b7ca7c | dmlc/dgl | Python | 4,483 | [DataLoader] Allow batch_size=None for GraphDataLoader | Fixes #3358. | 2022-08-30T07:07:25Z | Support `batch_size = None` for GraphDataLoader
## 🚀 Feature
Supporting `None` batch size for unbatched parallel data loading, as the PyTorch DataLoader supports.
## Motivation
Currently, when passing None as `batch_size` for GraphDataLoader, it will give an error
```
...
File "dgl/dataloading/dataloader.p... | Actually in DGL a single graph always has a batch size of 1. So you don't have to do manual unbatching. Setting batch size to 1 and then directly do stuff on the sampled minibatch should work.
We have graph level data, such as graph classification labels. | [
{
"body": "## 🚀 Feature\r\nSupporting `None` batch size for unbatched parallel data loading, as the PyTorch DataLoader supports.\r\n\r\n## Motivation\r\nCurrently, when passing None as `batch_size` for GraphDataLoader, it will give an error\r\n```\r\n ...\r\n File \"dgl/dataloading/dataloader.py\", line 823,... | e296c468b2962339fdc94300e41608dc82508e3d | {
"head_commit": "6b7ca7c09ac62e6b3af89b7be472745d611e15bb",
"head_commit_message": "Update dataloader.py",
"patch_to_review": "diff --git a/python/dgl/dataloading/dataloader.py b/python/dgl/dataloading/dataloader.py\nindex 4eed99587c6f..478c135f20d5 100644\n--- a/python/dgl/dataloading/dataloader.py\n+++ b/pytho... | [
{
"diff_hunk": "@@ -1197,17 +1197,18 @@ def __init__(self, dataset, collate_fn=None, use_ddp=False, ddp_seed=0, **kwargs\n else:\n dataloader_kwargs[k] = v\n \n- if collate_fn is None:\n- self.collate = GraphCollator(**collator_kwargs).collate\n- else:\n- ... | a795f5207080927e4acec344334b8b2775e45e3d | diff --git a/python/dgl/dataloading/dataloader.py b/python/dgl/dataloading/dataloader.py
index e3e74080c0a9..a26775e42e47 100644
--- a/python/dgl/dataloading/dataloader.py
+++ b/python/dgl/dataloading/dataloader.py
@@ -1124,17 +1124,15 @@ def __init__(self, dataset, collate_fn=None, use_ddp=False, ddp_seed=0, **kwargs
... | {
"difficulty": "medium",
"estimated_review_effort": 2,
"problem_domain": "New Feature Additions"
} |
explosion__spaCy-10981@68ccfec | explosion/spaCy | Python | 10,981 | Addition of min_max quantifier in matcher {n,m} | <!--- Provide a general summary of your changes in the title. -->
## Description
<!--- Use this section to describe your changes. If your changes required
testing, include information about the testing environment and the tests you
ran. If your test fixes a bug reported in an issue, don't forget to include the
i... | 2022-06-18T07:12:47Z | Is it possible to support quantifier (n,m) for rule matching?
```
! | Negate the pattern, by requiring it to match exactly 0 times.
-- | --
? | Make the pattern optional, by allowing it to match 0 or 1 times.
+ | Require the pattern to match 1 or more times.
* | Allow the pattern to match zero or mo
```
In ad... | If you have a simple pattern with one quantifier in the middle like `A * B`, then we'd suggest using the `on_match` callback to filter matches based on length.
Since the `Matcher` doesn't support capturing groups, this is not going to help for more complicated patterns with multiple quantifiers, though.
Labeling th... | [
{
"body": "\r\n```\r\n! | Negate the pattern, by requiring it to match exactly 0 times.\r\n-- | --\r\n? | Make the pattern optional, by allowing it to match 0 or 1 times.\r\n+ | Require the pattern to match 1 or more times.\r\n* | Allow the pattern to match zero or mo\r\n```\r\nIn addition to the operators abov... | 4c058eb40a1843191352a1501bead0dc99526bed | {
"head_commit": "68ccfec1a1586079e557ae1247697f66a7eb20d5",
"head_commit_message": "formatting",
"patch_to_review": "diff --git a/spacy/matcher/matcher.pyx b/spacy/matcher/matcher.pyx\nindex 981c5cdd265..5105f69edb8 100644\n--- a/spacy/matcher/matcher.pyx\n+++ b/spacy/matcher/matcher.pyx\n@@ -86,10 +86,14 @@ cde... | [
{
"diff_hunk": "@@ -17,6 +17,8 @@\n # Bad patterns flagged outside of Matcher\n ([{\"_\": {\"foo\": \"bar\", \"baz\": {\"IN\": \"foo\"}}}], 2, 0), # prev: (1, 0)\n # Bad patterns not flagged with minimal checks\n+ ([{\"TEXT\": \"foo\", \"OP\": \"{,}\"}], 1, 1),\n+ ([{\"TEXT\": \"foo\", \"OP\"... | efba1912fe2198782eda7b47f94ad52807edb30c | diff --git a/spacy/matcher/matcher.pyx b/spacy/matcher/matcher.pyx
index 981c5cdd265..5105f69edb8 100644
--- a/spacy/matcher/matcher.pyx
+++ b/spacy/matcher/matcher.pyx
@@ -86,10 +86,14 @@ cdef class Matcher:
is a dictionary mapping attribute IDs to values, and optionally a
quantifier operator under t... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
explosion__spaCy-10779@103bf99 | explosion/spaCy | Python | 10,779 | Ignore overrides for pipe names in config argument | ## Goals
Resolves https://github.com/explosion/spaCy/issues/10766 by ignoring name overrides in pipes' `config` argument.
<!--- Provide a general summary of your changes in the title. -->
## Description
<!--- Use this section to describe your changes. If your changes required
testing, include information abo... | 2022-05-10T09:57:03Z | Overriding `name` argument of Pipe via config has inconsistent behavior once model is serialized and loaded back.
The `name` parameter of a `Pipe` is different once model is serialized to disk and loaded back if overridden via the config. While it is useless in most use case to specify a name for a pipe and then overri... | Thanks for reporting this, @narayanacharya6! Looks like a bug indeed (also in the current v3.3). We'll look into it. | [
{
"body": "The `name` parameter of a `Pipe` is different once model is serialized to disk and loaded back if overridden via the config. While it is useless in most use case to specify a name for a pipe and then override it via the config as well but I believe the name should remain the same when a model is buil... | 290435968566d1ce0aff89cecee548b92b657bb2 | {
"head_commit": "103bf996ac0dc447cd78d880f63f100e9a5f336b",
"head_commit_message": "Pipe name override in config: added check with warning, added removal of name override from config, extended tests.",
"patch_to_review": "diff --git a/spacy/errors.py b/spacy/errors.py\nindex b01afcb802f..bff8e7414fc 100644\n--- ... | [
{
"diff_hunk": "@@ -141,12 +142,13 @@ def __call__(self, doc: Doc) -> Doc:\n nlp.add_pipe(name)\n with pytest.raises(ConfigValidationError): # invalid config\n nlp.add_pipe(name, config={\"value1\": \"10\", \"value2\": \"hello\"})\n- nlp.add_pipe(name, config={\"value1\": 10, \"value2\":... | 843d20b8ce3bb8f0f502ff77a1778ceaaadb5f93 | diff --git a/spacy/errors.py b/spacy/errors.py
index b01afcb802f..bff8e7414fc 100644
--- a/spacy/errors.py
+++ b/spacy/errors.py
@@ -199,6 +199,7 @@ class Warnings(metaclass=ErrorsWithCodes):
W118 = ("Term '{term}' not found in glossary. It may however be explained in documentation "
"for the corpora ... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
explosion__spaCy-10877@0b7ca4c | explosion/spaCy | Python | 10,877 | Detect cycle during projectivize | <!--- Provide a general summary of your changes in the title. -->
## Description
Attempting to detect cycles during `projectivize` step in `get_aligned_parse`. Fixes #10859.
### Types of change
Small bugfix
## Checklist
- [x] I confirm that I have the right to submit this contribution under the project's ... | 2022-05-30T09:53:19Z | Parser initialization hangs on parses with cycles
<!-- NOTE: For questions or install related issues, please open a Discussion instead. -->
## How to reproduce the behaviour
<!-- Include a code example or the steps that led to the problem. Please try to be as specific as possible. -->
`projectivize` hangs when t... | [
{
"body": "<!-- NOTE: For questions or install related issues, please open a Discussion instead. -->\r\n\r\n## How to reproduce the behaviour\r\n<!-- Include a code example or the steps that led to the problem. Please try to be as specific as possible. -->\r\n\r\n`projectivize` hangs when there are cycles in th... | 709d6d91148350a72b8ae2d8e0f077df61aa2c98 | {
"head_commit": "0b7ca4cecb77e67d59893212bed3eab4a7d347ef",
"head_commit_message": "Remove unused error code",
"patch_to_review": "diff --git a/spacy/pipeline/_parser_internals/nonproj.hh b/spacy/pipeline/_parser_internals/nonproj.hh\nnew file mode 100644\nindex 00000000000..071fd57b4d8\n--- /dev/null\n+++ b/spa... | [
{
"diff_hunk": "@@ -48,76 +47,54 @@ def contains_cycle(heads):\n \n def is_nonproj_arc(tokenid, heads):\n cdef vector[int] c_heads = _heads_to_c(heads)\n- is_nonproj = _is_nonproj_arc(tokenid, c_heads)\n- if is_nonproj.second:\n- raise ValueError(Errors.E1038.format(heads=heads))\n- return i... | dadb55a5c72681cd6fbff798a3400193a75cb57c | diff --git a/MANIFEST.in b/MANIFEST.in
index b7826e456ba..8ded6f80899 100644
--- a/MANIFEST.in
+++ b/MANIFEST.in
@@ -1,4 +1,4 @@
-recursive-include spacy *.pyi *.pyx *.pxd *.txt *.cfg *.jinja *.toml
+recursive-include spacy *.pyi *.pyx *.pxd *.txt *.cfg *.jinja *.toml *.hh
include LICENSE
include README.md
include p... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} | |
explosion__spaCy-10864@f1bb2f6 | explosion/spaCy | Python | 10,864 | Avoid pickling `Doc` inputs passed to `Language.pipe()` | ## Description
<!--- Use this section to describe your changes. If your changes required
testing, include information about the testing environment and the tests you
ran. If your test fixes a bug reported in an issue, don't forget to include the
issue number. If your PR is still a work in progress, that's totally f... | 2022-05-27T16:33:23Z | Pipe() process time is very slow with as_tuples attribute
When I set `as_tuples=True` attribute to the `.pipe` method, the process time is very very slow.
Results without tuples :
```
0:00:02.997644 Starting pipe
text processed
[...]
text processed
Pipe finished in 0:00:13.833113
```
Results with tuples :
... | Thanks for the report and the code sample! I'm able to reproduce the slow down on my end (on Linux) as well. Looks like the code spends an inordinate amount of time serializing and deserializing data during IPC (inter-process communication). | [
{
"body": "When I set `as_tuples=True` attribute to the `.pipe` method, the process time is very very slow.\r\n\r\nResults without tuples :\r\n```\r\n0:00:02.997644 Starting pipe\r\ntext processed\r\n[...]\r\ntext processed\r\nPipe finished in 0:00:13.833113\r\n```\r\n\r\nResults with tuples :\r\n```\r\n0:00:02... | 8387ce4c01db48d92ac5638e18316c0f1fc8861e | {
"head_commit": "f1bb2f6832de9bf4ffaa78cc049cb77dba29c27f",
"head_commit_message": "Remove superfluous comma",
"patch_to_review": "diff --git a/spacy/errors.py b/spacy/errors.py\nindex c82ffe8824b..8df5edee809 100644\n--- a/spacy/errors.py\n+++ b/spacy/errors.py\n@@ -919,6 +919,7 @@ class Errors(metaclass=Errors... | [
{
"diff_hunk": "@@ -1597,8 +1601,21 @@ def _multiprocessing_pipe(\n n_process: int,\n batch_size: int,\n ) -> Iterator[Doc]:\n+ def prepare_doc(",
"line": null,
"original_line": 1604,
"original_start_line": null,
"path": "spacy/language.py",
"start_line": null,
... | 3647be52656c15ea26757b140a4f461997defe85 | diff --git a/spacy/errors.py b/spacy/errors.py
index 75e24789fb6..1112300d29a 100644
--- a/spacy/errors.py
+++ b/spacy/errors.py
@@ -926,6 +926,7 @@ class Errors(metaclass=ErrorsWithCodes):
"could not be aligned to token boundaries.")
E1040 = ("Doc.from_json requires all tokens to have the same attri... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Performance Optimizations"
} |
explosion__spaCy-10707@a54b611 | explosion/spaCy | Python | 10,707 | Fix: De/Serialize `SpanGroups` including the SpanGroup keys | ## Description
Fixes #10685
This de/serializes `SpanGroups` objects as dicts, so that the keys corresponding to `SpanGroup`s are included.
This prevents the loss of `SpanGroup`s that have the same `.name` as other `SpanGroup`s within the same `SpanGroups` object (upon de/serialization of the `SpanGroups`).
... | 2022-04-25T19:46:14Z | SpanGroup()s of a SpanGroups() are lost upon de/serialization--if having the same .name
## Problem:
If a `SpanGroup.name` conflicts with another SpanGroup.name in a `SpanGroups` object--but the `SpanGroup`s are values of different keys of the SpanGroups object--then when the SpanGroups object is serialized and then ... | Thanks for the report, that does look like a bug. We'll look into it! | [
{
"body": "## Problem:\r\n\r\nIf a `SpanGroup.name` conflicts with another SpanGroup.name in a `SpanGroups` object--but the `SpanGroup`s are values of different keys of the SpanGroups object--then when the SpanGroups object is serialized and then deserialized, only 1 of the `SpanGroup`s will be present in the `... | cb06309ed81262b35def950b9978650c60ddab31 | {
"head_commit": "a54b61120601478bd18e932131e26f3fc2f624a4",
"head_commit_message": "Add more SpanGroups serialization tests\n\nTest that serialized SpanGroups maintain their Span order",
"patch_to_review": "diff --git a/spacy/errors.py b/spacy/errors.py\nindex bff8e7414fc..341923d70f9 100644\n--- a/spacy/errors.... | [
{
"diff_hunk": "@@ -0,0 +1,160 @@\n+import pytest\n+\n+from spacy.tokens import Span, SpanGroup\n+from spacy.tokens._dict_proxies import SpanGroups\n+\n+\n+@pytest.mark.issue(10685)\n+def test_issue10685(en_tokenizer):\n+ \"\"\"Test `SpanGroups` de/serialization\"\"\"\n+ # Start with a Doc with no SpanGro... | edbc793941b3690988cea895549c670526dbddb0 | diff --git a/spacy/errors.py b/spacy/errors.py
index bff8e7414fc..341923d70f9 100644
--- a/spacy/errors.py
+++ b/spacy/errors.py
@@ -200,6 +200,11 @@ class Warnings(metaclass=ErrorsWithCodes):
"for the corpora used to train the language. Please check "
"`nlp.meta[\"sources\"]` for any relevant... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
explosion__spaCy-10079@a05dfb6 | explosion/spaCy | Python | 10,079 | Determine labels by factory name in debug data |
<!--- Provide a general summary of your changes in the title. -->
## Description
<!--- Use this section to describe your changes. If your changes required
testing, include information about the testing environment and the tests you
ran. If your test fixes a bug reported in an issue, don't forget to include th... | 2022-01-18T14:08:04Z | Depending on a model's name in config `spacy debug data` behaves differently
## How to reproduce the behavior
I have two identical config files with `transformer+ner` pipelines. If my NER component (not custom, absolutely tutorial rip-off) is called `entity_recognizer` (or anything else, I checked) and not `ner`, runn... | Thanks for the report, that does look like a bug! The messages about having a good amount of examples in both outputs should be correct, since this is looking at `doc.ents` and not the pipeline config, but there's clearly a bug in code that looks up the labels by component name.
Hello, @adrianeboyd @tomateit I want to... | [
{
"body": "## How to reproduce the behavior\r\nI have two identical config files with `transformer+ner` pipelines. If my NER component (not custom, absolutely tutorial rip-off) is called `entity_recognizer` (or anything else, I checked) and not `ner`, running `spacy debug data` with respective parameters produc... | c28e33637bf7c7beef8658db7bfc33182adeca87 | {
"head_commit": "a05dfb674f9143b45d5b2871f15b553a398a6d4f",
"head_commit_message": "Refactor for typing",
"patch_to_review": "diff --git a/spacy/cli/debug_data.py b/spacy/cli/debug_data.py\nindex 688b07a9ba4..862edb1275b 100644\n--- a/spacy/cli/debug_data.py\n+++ b/spacy/cli/debug_data.py\n@@ -14,7 +14,7 @@\n fr... | [
{
"diff_hunk": "@@ -699,8 +699,33 @@ def _get_examples_without_label(data: Sequence[Example], label: str) -> int:\n return count\n \n \n-def _get_labels_from_model(nlp: Language, pipe_name: str) -> Set[str]:\n- if pipe_name not in nlp.pipe_names:\n- return set()\n- pipe = nlp.get_pipe(pipe_name... | 23de491dc82bbf2038a293bf88ee1980f8432da6 | diff --git a/spacy/cli/debug_data.py b/spacy/cli/debug_data.py
index 688b07a9ba4..b9831fe0cbc 100644
--- a/spacy/cli/debug_data.py
+++ b/spacy/cli/debug_data.py
@@ -14,7 +14,7 @@
from ..schemas import ConfigSchemaTraining
from ..pipeline._parser_internals import nonproj
from ..pipeline._parser_internals.nonproj impo... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
camel-ai__camel-1726@f672ea9 | camel-ai/camel | Python | 1,726 | feat: Link memory to agent with id | ## Description
- Adds an agent_id to every memory record.
- Updates ChatHistoryBlock to retrieve only the memories associated with the specified agent.
- Creates this interface for ChatAgent to save, load and clear memories:
```
agent = ChatAgent(`system_message`="you are a helpful assistant", agent_id="001") # ... | 2025-03-06T13:26:04Z | Agent ID associated with memories for better tracking and organization.
```
agent = ChatAgent(`system_message`="you are a helpful assistant", agent_id="001") # The agent is could be generated randomly is not specified.
agent.save_memory(path: str) -> save `AgentMemory` with `agent_id` presisitently
agent.load_memory(me... | [
{
"body": "```\nagent = ChatAgent(`system_message`=\"you are a helpful assistant\", agent_id=\"001\") # The agent is could be generated randomly is not specified.\nagent.save_memory(path: str) -> save `AgentMemory` with `agent_id` presisitently\nagent.load_memory(memory: AgentMemory)\nagent.load_memory_from_pat... | bfd79bb6c86c8d841d0e11a1830cc22881796ed2 | {
"head_commit": "f672ea9d84c58c2709ee1d4597428f21715ea3db",
"head_commit_message": "fix: merge conflict error_info",
"patch_to_review": "diff --git a/camel/agents/chat_agent.py b/camel/agents/chat_agent.py\nindex 9452bb4df6..de453d92a4 100644\n--- a/camel/agents/chat_agent.py\n+++ b/camel/agents/chat_agent.py\n@... | [
{
"diff_hunk": "@@ -321,9 +337,77 @@ def update_memory(\n role (OpenAIBackendRole): The backend role type.\n \"\"\"\n self.memory.write_record(\n- MemoryRecord(message=message, role_at_backend=role)\n+ MemoryRecord(\n+ message=message,\n+ ... | 523983e03533e68b1307fc002eedc9f9e573c3e6 | diff --git a/camel/agents/chat_agent.py b/camel/agents/chat_agent.py
index c8952fb2ed..54d7fd91d8 100644
--- a/camel/agents/chat_agent.py
+++ b/camel/agents/chat_agent.py
@@ -16,7 +16,10 @@
import json
import logging
import textwrap
+import uuid
from collections import defaultdict
+from datetime import datetime
+fr... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
explosion__spaCy-9869@77fb438 | explosion/spaCy | Python | 9,869 | Span/SpanGroup: wrap SpanC in shared_ptr | <!--- Provide a general summary of your changes in the title. -->
## Description
<!--- Use this section to describe your changes. If your changes required
testing, include information about the testing environment and the tests you
ran. If your test fixes a bug reported in an issue, don't forget to include the
i... | 2021-12-15T15:48:48Z | SpanGroup doesn't allow access to original spans
## How to reproduce the behaviour
<!-- Include a code example or the steps that led to the problem. Please try to be as specific as possible. -->
Use case: I use a custom entity ruler to populate `doc.spans`, a `SpanGroup` per entity label, to allow overlapping spans ... | Thanks for the detailed explanation of your use case. You are correct that this is the way the SpanGroup works at the moment. In particular, it's correct the easiest way to change values is to recreate the SpanGroup.
I need to check to be sure but I think it works this way for efficiency or serialization related rea... | [
{
"body": "## How to reproduce the behaviour\r\n<!-- Include a code example or the steps that led to the problem. Please try to be as specific as possible. -->\r\nUse case: I use a custom entity ruler to populate `doc.spans`, a `SpanGroup` per entity label, to allow overlapping spans between different entity t... | d8a3012539cdf3cea8b1d9a0ea5aafe87c3016c3 | {
"head_commit": "77fb438f117cc92a1205345821ec0bac05a66275",
"head_commit_message": "Style fix: pointer types",
"patch_to_review": "diff --git a/spacy/pipeline/_parser_internals/ner.pyx b/spacy/pipeline/_parser_internals/ner.pyx\nindex 3edeff19a01..87410de0f19 100644\n--- a/spacy/pipeline/_parser_internals/ner.py... | [
{
"diff_hunk": "@@ -149,13 +150,13 @@ cdef class SpanGroup:\n # l: int32_t\n output[\"spans\"].append(struct.pack(\n \">QQQllll\",\n- span.id,\n- span.kb_id,\n- span.label,\n- span.start,\n- span.e... | d95adfc95cca4b25faf857ba1e3702e97187178e | diff --git a/spacy/pipeline/_parser_internals/ner.pyx b/spacy/pipeline/_parser_internals/ner.pyx
index 3edeff19a01..87410de0f19 100644
--- a/spacy/pipeline/_parser_internals/ner.pyx
+++ b/spacy/pipeline/_parser_internals/ner.pyx
@@ -1,6 +1,8 @@
import os
import random
from libc.stdint cimport int32_t
+from libcpp.me... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
explosion__spaCy-7075@99b84d3 | explosion/spaCy | Python | 7,075 | Add warning about GPU selection in Jupyter notebooks |
<!--- Provide a general summary of your changes in the title. -->
## Description
<!--- Use this section to describe your changes. If your changes required
testing, include information about the testing environment and the tests you
ran. If your test fixes a bug reported in an issue, don't forget to include th... | 2021-02-15T15:24:46Z | Error when GPU initialization and model loading are in different notebook cells
## How to reproduce the behaviour
<!-- Include a code example or the steps that led to the problem. Please try to be as specific as possible. -->
Installed the latest version following the instruction
```
pip install -U pip setuptools w... | Hi, can you check that you also have the latest version of `spacy-transformers` (`pip install -U spacy-transformers`)?
> Hi, can you check that you also have the latest version of `spacy-transformers` (`pip install -U spacy-transformers`)?
Yes, I do have the latest version of 'spacy-transformers'. I did `pip insta... | [
{
"body": "## How to reproduce the behaviour\r\n<!-- Include a code example or the steps that led to the problem. Please try to be as specific as possible. -->\r\nInstalled the latest version following the instruction\r\n```\r\npip install -U pip setuptools wheel\r\npip install -U spacy[cuda110]\r\npython -m sp... | 1e3a326e5362eee73b0b7dacb89994a2507390b7 | {
"head_commit": "99b84d32e8068f6fb2a6748bd6cb695b48a928fa",
"head_commit_message": "Initial warning",
"patch_to_review": "diff --git a/spacy/errors.py b/spacy/errors.py\nindex 79a15fbaa41..b8de8f5b3cf 100644\n--- a/spacy/errors.py\n+++ b/spacy/errors.py\n@@ -147,6 +147,11 @@ class Warnings:\n \"will ... | [
{
"diff_hunk": "@@ -1615,6 +1615,11 @@ def from_config(\n or lang_cls is not cls\n ):\n raise ValueError(Errors.E943.format(value=type(lang_cls)))\n+ # Warn about require_gpu if a jupyter notebook + cupy is detected\n+ if is_in_jupyter():\n+ f... | 0c7d5460738bc9fa6a6b3b00b7d820c211ab31f9 | diff --git a/spacy/errors.py b/spacy/errors.py
index 79a15fbaa41..b8de8f5b3cf 100644
--- a/spacy/errors.py
+++ b/spacy/errors.py
@@ -147,6 +147,11 @@ class Warnings:
"will be included in the results. For better results, token "
"patterns should return matches that are each exactly one token "
... | {
"difficulty": "low",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
explosion__spaCy-9649@e7ba70a | explosion/spaCy | Python | 9,649 | Add ENT_IOB key to Matcher | <!--- Provide a general summary of your changes in the title. -->
## Description
<!--- Use this section to describe your changes. If your changes required
testing, include information about the testing environment and the tests you
ran. If your test fixes a bug reported in an issue, don't forget to include the
i... | 2021-11-09T12:02:19Z | ENT_IOB as a token pattern key
## Feature description
Adding `ENT_IOB` attribute as one of the pattern key. Currently, it has not been integrated into entity ruler pipeline.
### Example
```
import spacy
from spacy.pipeline import EntityRuler
nlp = spacy.load('en')
ruler = EntityRuler(nlp, overwrite_ents=True... | Fair point, although the `ENT_IOB` values currently have pretty obscure semantics, which makes usability a bit difficult. The field takes a numeric value with the following interpretation:
0: Missing
1: I -- In
2: O -- Out
3: B -- Begin
@honnibal I guess we could also have it take the strings `I`, `O` and `B` and... | [
{
"body": "## Feature description\r\nAdding `ENT_IOB` attribute as one of the pattern key. Currently, it has not been integrated into entity ruler pipeline.\r\n\r\n### Example\r\n```\r\nimport spacy\r\nfrom spacy.pipeline import EntityRuler\r\n\r\nnlp = spacy.load('en')\r\nruler = EntityRuler(nlp, overwrite_ent... | a4c43e5c577d7a143ef7e2fd74ccea33aace96b7 | {
"head_commit": "e7ba70ac5225b1713ad2f0610ab810478fe730d4",
"head_commit_message": "add IOB vals to schema",
"patch_to_review": "diff --git a/spacy/matcher/matcher.pyx b/spacy/matcher/matcher.pyx\nindex 745d7cf437b..8c2cf665676 100644\n--- a/spacy/matcher/matcher.pyx\n+++ b/spacy/matcher/matcher.pyx\n@@ -18,7 +1... | [
{
"diff_hunk": "@@ -68,3 +68,20 @@ def test_pattern_errors(en_vocab):\n # error if subpattern attribute isn't recognized and processed\n with pytest.raises(MatchPatternError):\n matcher.add(\"TEST2\", [[{\"TEXT\": {\"XX\": \"xx\"}}]])\n+\n+\n+def test_iob_keys_invalid_value_no_validation(en_voca... | 9a04da8e9684ab640a3837da33da6697a0b27095 | diff --git a/spacy/matcher/matcher.pyx b/spacy/matcher/matcher.pyx
index 745d7cf437b..6aa58f0e3e9 100644
--- a/spacy/matcher/matcher.pyx
+++ b/spacy/matcher/matcher.pyx
@@ -18,7 +18,7 @@ from ..tokens.doc cimport Doc, get_token_attr_for_matcher
from ..tokens.span cimport Span
from ..tokens.token cimport Token
from .... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
camel-ai__camel-1734@5d222c9 | camel-ai/camel | Python | 1,734 | refactor Seed Dataset to improve compatibility and simplify usage | ## Description
This PR solves:
https://github.com/camel-ai/camel/issues/1732
https://github.com/camel-ai/camel/issues/1733
## Checklist
Go over all the following points, and put an `x` in all the boxes that apply.
- [x] I have read the [CONTRIBUTION](https://github.com/camel-ai/camel/blob/master/CONTRIBUT... | 2025-03-07T13:52:21Z | Seed Dataset has unexpected behavior
Seed Dataset has a setup function, which is unusual for dataset classes.
Seed Dataset has compatibility issues
It should be possible to initialize it from Huggingface & Pytorch Datasets as well as JSON files and list of dicts, not just list of dicts. | [
{
"body": "Seed Dataset has a setup function, which is unusual for dataset classes.",
"number": 1732,
"title": "Seed Dataset has unexpected behavior"
},
{
"body": "It should be possible to initialize it from Huggingface & Pytorch Datasets as well as JSON files and list of dicts, not just list of... | 83b7c322f95d780a5081c0e25027e436512f8246 | {
"head_commit": "5d222c9af764ce321aa57b4c183d54ef7d518ece",
"head_commit_message": "fix: Adjust code to utilize self._length in\ngetitem and cast len(data) to a Sized to pass mypy\ntests",
"patch_to_review": "diff --git a/camel/datasets/base.py b/camel/datasets/base.py\nindex e085eeb462..df49bfdc5e 100644\n--- a... | [
{
"diff_hunk": "@@ -386,7 +388,9 @@ def __init__(\n self._raw_data = [dict(item) for item in data]\n elif isinstance(data, Dataset):\n try:\n- self._raw_data = [dict(data[i]) for i in range(len(data))]\n+ self._raw_data = [\n+ dict... | 54c19dafb4b9122072923932680a96d7bbdf17c2 | diff --git a/camel/datasets/base.py b/camel/datasets/base.py
index e085eeb462..bcacd0e348 100644
--- a/camel/datasets/base.py
+++ b/camel/datasets/base.py
@@ -12,14 +12,17 @@
# limitations under the License.
# ========= Copyright 2023-2024 @ CAMEL-AI.org. All Rights Reserved. =========
+import json
import os
impo... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} | |
explosion__spaCy-5531@609f649 | explosion/spaCy | Python | 5,531 | Spanish tokenizer exception and examples improvement | Fixes #5530 Adds to #3056
## Enhancement to lang/es tokenizer_exceptions.py and added Example sentences to lang/es/examples.py
File: spacy/lang/es/tokenizer_exceptions.py
Currently the lines 7-10 contain
```
_exc = {
"pal": [{ORTH: "pa", LEMMA: "para"}, {ORTH: "l", LEMMA: "el", NORM: "el"}],
"p... | 2020-06-01T15:13:07Z | Enhancement to Spanish tokenizer_exceptions.py
## Enhancement to lang/es tokenizer_exceptions.py
File: spacy/lang/es/tokenizer_exceptions.py
Currently the lines 7-10 contain
```
_exc = {
"pal": [{ORTH: "pa", LEMMA: "para"}, {ORTH: "l", LEMMA: "el", NORM: "el"}],
"pala": [{ORTH: "pa", LEMMA: "para"},... | [
{
"body": "## Enhancement to lang/es tokenizer_exceptions.py\r\n\r\nFile: spacy/lang/es/tokenizer_exceptions.py\r\n\r\nCurrently the lines 7-10 contain\r\n\r\n```\r\n_exc = {\r\n \"pal\": [{ORTH: \"pa\", LEMMA: \"para\"}, {ORTH: \"l\", LEMMA: \"el\", NORM: \"el\"}],\r\n \"pala\": [{ORTH: \"pa\", LEMMA: \"... | 67af3a32b0358ba3eef2a168b67f66c81a947e20 | {
"head_commit": "609f6494d6d49d8a5122552a67c64ca70d7a84bd",
"head_commit_message": "Spanish tokenizer exception additions. Added Spanish question examples",
"patch_to_review": "diff --git a/spacy/lang/es/examples.py b/spacy/lang/es/examples.py\nindex 0e31b56af1e..7ab0a7dfe0c 100644\n--- a/spacy/lang/es/examples.... | [
{
"diff_hunk": "@@ -4,22 +4,33 @@\n from ...symbols import ORTH, LEMMA, NORM, PRON_LEMMA\n \n \n-_exc = {\n+# Not used by default as they are only used in certains regional speech modes, left here for completeness\n+_slang_exc = {",
"line": null,
"original_line": 8,
"original_start_line": null,
... | 4aff039007e2476a3df23262c5f0d766236c78d3 | diff --git a/spacy/lang/es/examples.py b/spacy/lang/es/examples.py
index 0e31b56af1e..7ab0a7dfe0c 100644
--- a/spacy/lang/es/examples.py
+++ b/spacy/lang/es/examples.py
@@ -18,5 +18,9 @@
"El gato come pescado.",
"Veo al hombre con el telescopio.",
"La araña come moscas.",
- "El pingüino incuba en su n... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Code Refactoring / Architectural Improvement"
} | |
explosion__spaCy-5396@0a5ad45 | explosion/spaCy | Python | 5,396 | Limiting noun_chunks for specific languages | Limiting noun_chunks for specific languages as a fix to #5226
## Description
Enabled noun_chunks to raise Value Error when Doc is not parsed for specific languages.
Added New tests to cover the change.
### Types of change
Enhancement
New tests added
## Checklist
<!--- Before you submit the PR, go over th... | 2020-05-03T17:41:46Z | Can this error raising be lifted?
In doc.pyx' s line 590:
```
if not self.is_parsed:
raise ValueError(Errors.E029)
```
I can still do a good job of chunking by tokenization and pos tagging only, without the full parse. Also in some languages parse isn't available. This will leave more flexibiliti... | I think it would be fine to move this check into each individual noun chunks iterator rather than having it in `Doc.noun_chunks`.
Would you like to submit a PR to make this change? It looks like there are 9 languages that would need to be modified.
How to submit a PR? Have never done that and thanks.
You can find s... | [
{
"body": "In doc.pyx' s line 590:\r\n\r\n```\r\n if not self.is_parsed:\r\n raise ValueError(Errors.E029)\r\n```\r\n\r\nI can still do a good job of chunking by tokenization and pos tagging only, without the full parse. Also in some languages parse isn't available. This will leave more flexibilitie... | c045a9c7f637f85f7beccdae48a4cb765516d558 | {
"head_commit": "0a5ad45241eb9366f769cc77e76be563ca54f634",
"head_commit_message": "Limiting noun_chunks for specific languages\n\nContributor Agreement",
"patch_to_review": "diff --git a/.github/contributors/vishnupriyavr.md b/.github/contributors/vishnupriyavr.md\nnew file mode 100644\nindex 00000000000..73657... | [
{
"diff_hunk": "@@ -0,0 +1,28 @@\n+# coding: utf-8\n+from __future__ import unicode_literals\n+\n+import pytest\n+from spacy.language import Language\n+from spacy.vocab import Vocab\n+from spacy.tokens import Doc\n+\n+\n+@pytest.fixture\n+def nlp():\n+ return Language()\n+\n+\n+def test_noun_chunks_is_parsed... | 03a31f543ae77946bbcf7c84d937a5babd045769 | diff --git a/.github/contributors/vishnupriyavr.md b/.github/contributors/vishnupriyavr.md
new file mode 100644
index 00000000000..73657a7729b
--- /dev/null
+++ b/.github/contributors/vishnupriyavr.md
@@ -0,0 +1,106 @@
+# spaCy contributor agreement
+
+This spaCy Contributor Agreement (**"SCA"**) is based on the
+[Orac... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
explosion__spaCy-7039@278e9ea | explosion/spaCy | Python | 7,039 | Fix listener architecture with empty doc in batch | Fixes #7029
## Description
The listener returns some random data with a valid shape for shape inference, when `doc.tensor` isn't set. However using `all` for this check, means that it will hit also if we have an empty document in the batch - effectively wiping the previously calculated `tok2vec` results for the no... | 2021-02-11T20:03:30Z | POS will be all "ADP" when the inputs have empty string when using .pipe()
## How to reproduce the behaviour
When I use `spacy_model.pipe()` to process documents in parallel, the POS tagging will give wrong result if there is any empty string int the documents.
For example:
(1) Normally:
```
docs=["Hello world!","... | Thanks for the report! I can reproduce this and it definitely looks like a bug. We will look into it!
Hi @adrianeboyd , anyone working on this? I would like to contribute.
Hi @PradipNichite ,
If you want to have a look at this, please do go ahead! It's possible Adriane is looking into it as well but it's almost the ... | [
{
"body": "## How to reproduce the behaviour\r\nWhen I use `spacy_model.pipe()` to process documents in parallel, the POS tagging will give wrong result if there is any empty string int the documents.\r\nFor example:\r\n(1) Normally:\r\n```\r\ndocs=[\"Hello world!\",\"How are you?\"]\r\nspacy_docs=spacy_model.p... | 26bf642afd6ddb496846dad9283b195897afe30b | {
"head_commit": "278e9eaa148799a3d92eaec8684267e3a10603f0",
"head_commit_message": "remove ner",
"patch_to_review": "diff --git a/spacy/pipeline/tok2vec.py b/spacy/pipeline/tok2vec.py\nindex 61ba498c9f4..4a396eaeb26 100644\n--- a/spacy/pipeline/tok2vec.py\n+++ b/spacy/pipeline/tok2vec.py\n@@ -291,7 +291,7 @@ def... | [
{
"diff_hunk": "@@ -291,7 +291,7 @@ def forward(model: Tok2VecListener, inputs, is_train: bool):\n # of data.\n # When the components batch differently, we don't receive a matching\n # prediction from the upstream, so we can't predict.\n- if not all(doc.tensor.size for doc in inpu... | 03b4ec7d7fac8d3c2e5360d50075eddf0478396b | diff --git a/spacy/pipeline/tok2vec.py b/spacy/pipeline/tok2vec.py
index 61ba498c9f4..26a4c998c43 100644
--- a/spacy/pipeline/tok2vec.py
+++ b/spacy/pipeline/tok2vec.py
@@ -291,14 +291,16 @@ def forward(model: Tok2VecListener, inputs, is_train: bool):
# of data.
# When the components batch differently... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
explosion__spaCy-5315@e7ba0c4 | explosion/spaCy | Python | 5,315 | Fixes #5413 | (Fixes #5314 )
Fixes change of format `{lang}wiki-latest-pages-articles.xml.bz2` which makes the `bin.entity_linking.wikipedia_processor._process_wp_text` not parse any article.
## Description
The code removes everything within the `<text >` tag before extracting the text.
### Types of change
Bug fix
## C... | 2020-04-16T07:43:01Z | wikidata_pretrain_kb.py fails to process wiki articles due to change {lang}wiki-latest-pages-articles.xml.bz2
The format of {lang}wiki-latest-pages-articles.xml.bz2 has changed.
The text tag previous looked like this `<text xml:space="preserve">` but now look like this `<text bytes="{NUMBER}" xml:space="preserve">`
... | [
{
"body": "The format of {lang}wiki-latest-pages-articles.xml.bz2 has changed.\r\n\r\nThe text tag previous looked like this `<text xml:space=\"preserve\">` but now look like this `<text bytes=\"{NUMBER}\" xml:space=\"preserve\">`\r\n\r\nThus, the function `bin.entity_linking.wikipedia_processor._process_wp_tex... | 1ca32d8f9c800eb36e912dc1fa7b173edf7f2c3c | {
"head_commit": "e7ba0c4e76d316e795d97d5a2729b83adeb51b43",
"head_commit_message": "Add contributor",
"patch_to_review": "diff --git a/.github/contributors/elben10 b/.github/contributors/elben10\nnew file mode 100644\nindex 00000000000..1eb4656dc81\n--- /dev/null\n+++ b/.github/contributors/elben10\n@@ -0,0 +1,1... | [
{
"diff_hunk": "@@ -0,0 +1,10 @@\n+from bin.wiki_entity_linking.wikipedia_processor import _process_wp_text\n+\n+title = \"Arkæologi\"\n+\n+text = \"\"\"<text bytes=\"11456\" xml:space=\"preserve\">[[Fil:Archäologie schichtengrabung.jpg|thumb|Arkæologisk [[udgravning]] med profil.]] '''Arkæologi''' er studiet a... | 02a016fc5cc4f0d54ff4374feb1b89c949f12f74 | diff --git a/.github/contributors/elben10 b/.github/contributors/elben10
new file mode 100644
index 00000000000..1eb4656dc81
--- /dev/null
+++ b/.github/contributors/elben10
@@ -0,0 +1,106 @@
+# spaCy contributor agreement
+
+This spaCy Contributor Agreement (**"SCA"**) is based on the
+[Oracle Contributor Agreement](h... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
deepset-ai__haystack-9338@f9910f7 | deepset-ai/haystack | Python | 9,338 | fix: make `SentenceSplitter` QUOTE_SPANS_RE regex ReDoS-safe | ### Related Issues
- fixes #9315
### Proposed Changes:
Replaced the vulnerable regular expression pattern in QUOTE_SPANS_RE inside SentenceSplitter with a ReDoS-safe alternative.
### How did you test it?
- Ran unit tests locally using hatch run test:unit
- Ensured that all pre-commit hooks passed
##... | 2025-05-02T13:13:16Z | Potential REDoS Vulnerability in Haystack SentenceSplitter
We found a REDoS vulnerability in Haystack's `SentenceSplitter`.
- Problematic regex: `QUOTE_SPANS_RE` (`\W(\"+|\'+).*?\1`)
- Issue: Specially crafted input can cause catastrophic backtracking, leading to a potential DoS.
Reproduction:
```python
import time
f... | Hello @waiveyk The pattern is used in a controlled context within the SentenceSplitter component, which is primarily used for document splitting and text processing. The input to this component typically comes from document content rather than user input. That means the 500 million 'A’ characters in the example above w... | [
{
"body": "We found a REDoS vulnerability in Haystack's `SentenceSplitter`.\n\n- Problematic regex: `QUOTE_SPANS_RE` (`\\W(\\\"+|\\'+).*?\\1`)\n- Issue: Specially crafted input can cause catastrophic backtracking, leading to a potential DoS.\n\nReproduction:\n```python\nimport time\nfrom haystack.components.pre... | e5255d906155476c38577fae37ba99e4fbd1c37e | {
"head_commit": "f9910f79dab1a3df9f67a9aa6ec2a5e04b3db7f4",
"head_commit_message": "Update test/components/preprocessors/test_sentence_tokenizer.py\n\nCo-authored-by: Stefano Fiorucci <stefanofiorucci@gmail.com>",
"patch_to_review": "diff --git a/haystack/components/preprocessors/sentence_tokenizer.py b/haystack... | [
{
"diff_hunk": "@@ -65,3 +67,48 @@ def test_read_abbreviations_missing_file(caplog: LogCaptureFixture):\n result = SentenceSplitter._read_abbreviations(\"pt\")\n assert result == []\n assert \"No abbreviations file found for pt. Using default abbreviations.\" in caplog.text\n+\n+\n+def t... | ad288e2dc8e26a66a377e4e84c6ea02dc53128eb | diff --git a/haystack/components/preprocessors/sentence_tokenizer.py b/haystack/components/preprocessors/sentence_tokenizer.py
index 2cb77347d3..6d38d14ec7 100644
--- a/haystack/components/preprocessors/sentence_tokenizer.py
+++ b/haystack/components/preprocessors/sentence_tokenizer.py
@@ -40,7 +40,7 @@
"ml": "mal... | {
"difficulty": "low",
"estimated_review_effort": 3,
"problem_domain": "Security Patches / Vulnerability Fixes"
} |
deepset-ai__haystack-9406@6dd96fd | deepset-ai/haystack | Python | 9,406 | feat: Extend AnswerBuilder for Agent | ## Why:
Enhances the AnswerBuilder component to preserve conversation history when processing Agent outputs.
- fixes https://github.com/deepset-ai/haystack/issues/9330
- Addresses the need to maintain agent message context in GeneratedAnswer objects
- Enables seamless integration between Agent components and th... | 2025-05-18T17:09:43Z | Extend AnswerBuilder to convert only last message for agentic pipelines
**Is your feature request related to a problem? Please describe.**
As most agents are expected to be run as a Chat application, returning exactly one answer per interaction/request/pipeline.run seems to be a defacto pattern.
The current `Agent` alw... | Maybe an alternative or in addition to this could be to add an additional output to the Agent called final_message of type ChatMessage which always contains the last message?
@bilgeyucel also mentioned for standalone uses of Agent that this would be helpful.
Agree with @sjrl here. Additionally, Haystack users don't ... | [
{
"body": "**Is your feature request related to a problem? Please describe.**\nAs most agents are expected to be run as a Chat application, returning exactly one answer per interaction/request/pipeline.run seems to be a defacto pattern.\nThe current `Agent` always returns all messages that have been accumulated... | f253db3e14ccbb66fc1ed1ea31a60c40d60cd218 | {
"head_commit": "6dd96fd772937c3889e1b23b5901c7a29e33f721",
"head_commit_message": "Add a better unit test",
"patch_to_review": "diff --git a/haystack/components/builders/answer_builder.py b/haystack/components/builders/answer_builder.py\nindex 9a465cafc3..20f3754611 100644\n--- a/haystack/components/builders/an... | [
{
"diff_hunk": "@@ -278,7 +320,56 @@ def test_run_with_chat_message_no_meta_with_meta_set_at_run_time(self):\n answers = output[\"answers\"]\n assert len(answers) == 1\n assert answers[0].data == \"AnswerString\"\n- assert answers[0].meta == {\"test\": \"meta\"}\n+\n+ # Che... | 7a1615cb3e8c3c7e698ed2520bb3319ea49aa365 | diff --git a/haystack/components/builders/answer_builder.py b/haystack/components/builders/answer_builder.py
index 9a465cafc3..623a071c3b 100644
--- a/haystack/components/builders/answer_builder.py
+++ b/haystack/components/builders/answer_builder.py
@@ -31,7 +31,9 @@ class AnswerBuilder:
```
"""
- def _... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
deepset-ai__haystack-9322@bab570f | deepset-ai/haystack | Python | 9,322 | feat: validation function for `run()` and `run_async()` parameters signature for (custom) components | ### Related Issues
- fixes #9308
### Proposed Changes:
Component signature validation mismatches between `run` and `run_async` method signatures, this is bound to happen with custom components as all haystack core and integration components by design don't have this issue.
- new function `_compare_method_s... | 2025-04-29T11:40:00Z | Validation for matching parameters on run and run_async should report which parameters don't match
**Is your feature request related to a problem? Please describe.**
For components that implement a run and run_async method we validate that their signatures match. We had an issue at a hackathon where this consistently f... | @mathislucka can you point to the component or components you've found where the parameters are not the same?
I just went through all these files/components, which implement both `run()` and `run_async()`, and both have the same exact signature:
- haystack/components/retrievers/in_memory/embedding_retriever.py
- hayst... | [
{
"body": "**Is your feature request related to a problem? Please describe.**\nFor components that implement a run and run_async method we validate that their signatures match. We had an issue at a hackathon where this consistently failed but it was hard to figure out what the actual mismatch was because the er... | ed6176a8cb51712e0604473add3e053378b0c4b8 | {
"head_commit": "bab570fcb6442d7d61ba2af2469d032fbbd36dd5",
"head_commit_message": "adding release notes",
"patch_to_review": "diff --git a/haystack/core/component/component.py b/haystack/core/component/component.py\nindex 2e389363e9..fb2534b118 100644\n--- a/haystack/core/component/component.py\n+++ b/haystack/... | [
{
"diff_hunk": "@@ -326,6 +329,48 @@ def _component_run_has_kwargs(component_cls: Type) -> bool:\n )\n \n \n+def _compare_method_signatures(run_sig: inspect.Signature, async_run_sig: inspect.Signature) -> str:",
"line": null,
"original_line": 332,
"original_start_line": null,
"path": "ha... | 35f9137016208df88173b25b0b5a0ecae0d3e255 | diff --git a/haystack/core/component/component.py b/haystack/core/component/component.py
index 2e389363e9..9d985312bd 100644
--- a/haystack/core/component/component.py
+++ b/haystack/core/component/component.py
@@ -256,7 +256,10 @@ def inner(method, sockets):
async_run_sig = inner(async_run, async_run_sock... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
camel-ai__camel-1699@20c7a3c | camel-ai/camel | Python | 1,699 | feat: simplify creating agent using str, add examples | ## Description
Close #1681.
## Checklist
Go over all the following points, and put an `x` in all the boxes that apply.
- [x] I have read the [CONTRIBUTION](https://github.com/camel-ai/camel/blob/master/CONTRIBUTING.md) guide (**required**)
- [x] I have linked this PR to an issue using the Development secti... | 2025-03-04T11:02:16Z | Support `str` like behaviour for `ModelPlatformType` like `ModelType` to simplify interface
The goal is to simplify interface to enable creating a `ChatAgent` with one line of code.
The currect interface for create a `ChatAgent` with a model is like this:
```
from camel.models import ModelFactory
from camel.types impo... | [
{
"body": "The goal is to simplify interface to enable creating a `ChatAgent` with one line of code.\n\nThe currect interface for create a `ChatAgent` with a model is like this:\n```\nfrom camel.models import ModelFactory\nfrom camel.types import ModelPlatformType, ModelType\nfrom camel.agents import ChatAgent\... | 3dc1ca34ac62661cb8755e04fe64c3f506116044 | {
"head_commit": "20c7a3c4367e54611ac1e005e97521d7fb3426ef",
"head_commit_message": "create agent using str, add examples",
"patch_to_review": "diff --git a/camel/agents/chat_agent.py b/camel/agents/chat_agent.py\nindex 6946ec0f4a..abfdc28e6e 100644\n--- a/camel/agents/chat_agent.py\n+++ b/camel/agents/chat_agent... | [
{
"diff_hunk": "",
"line": null,
"original_line": null,
"original_start_line": null,
"path": "examples/agent/create_agent_one_line.py",
"start_line": null,
"text": "@user1:\nCan we also support\r\n```\r\nfrom camel.agents import ChatAgent\r\nfrom camel.types import ModelPlatformType, Mod... | c127d797337e9d0d82a07aaf7927bb8c579f9174 | diff --git a/camel/agents/chat_agent.py b/camel/agents/chat_agent.py
index c2d6c66456..2df0620f15 100644
--- a/camel/agents/chat_agent.py
+++ b/camel/agents/chat_agent.py
@@ -28,6 +28,7 @@
List,
Optional,
Set,
+ Tuple,
Type,
Union,
)
@@ -78,7 +79,6 @@
if TYPE_CHECKING:
from camel.term... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
deepset-ai__haystack-9290@3f511f6 | deepset-ai/haystack | Python | 9,290 | feat: enable streaming ToolCall/Result from Agent | ### Related Issues
- fixes #9179
### Proposed Changes:
- Stream `tool_call` from the Agent to notify which tool is being invoked along with its parameters.
- Introduce `stream_tool_result` parameter: When set to True, the `Agent` will emit the `tool_result` using the provided `streaming_callback` after the t... | 2025-04-23T08:44:24Z | Investigate how to stream output from Tool calls in Agents
As @mathislucka has worked with Agents he has found that streaming Tool calls to be extremely helpful for transparency and visibility. It allows users to see what is happening while they wait for a final answer and can make it easier to debug by seeing where th... | I would love to see this get implemented. Especially when Agent is doing multiple tool calls, giving visibility and feedback to the user about each tool execution would be great! | [
{
"body": "As @mathislucka has worked with Agents he has found that streaming Tool calls to be extremely helpful for transparency and visibility. It allows users to see what is happening while they wait for a final answer and can make it easier to debug by seeing where the Agent may have made an incorrect decis... | 7db719981d230e08de526526d46b18379c5b9f02 | {
"head_commit": "3f511f64ca8b301bb2063ae4024148857ec4472d",
"head_commit_message": "Fix linting",
"patch_to_review": "diff --git a/haystack/components/agents/agent.py b/haystack/components/agents/agent.py\nindex ebebcae34b..b28a0303a3 100644\n--- a/haystack/components/agents/agent.py\n+++ b/haystack/components/a... | [
{
"diff_hunk": "@@ -406,6 +421,14 @@ def run(self, messages: List[ChatMessage], state: Optional[State] = None) -> Dic\n # 2) Invoke the tool\n try:\n tool_result = tool_to_invoke.invoke(**final_args)\n+ if streaming_callback is not None:\n+ ... | 4c8cab937e05f147530f2a8ed4085c5f7e849d6b | diff --git a/haystack/components/agents/agent.py b/haystack/components/agents/agent.py
index ebebcae34b..7d978ef5a8 100644
--- a/haystack/components/agents/agent.py
+++ b/haystack/components/agents/agent.py
@@ -15,7 +15,7 @@
from haystack.dataclasses import ChatMessage
from haystack.dataclasses.state import State, _s... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
deepset-ai__haystack-9271@ac6a67f | deepset-ai/haystack | Python | 9,271 | feat: Add support for multiple outputs in ConditionalRouter | ### Related Issues
- fixes #9238
### Proposed Changes:
- updated output field valdation and input to allow multiple values
### How did you test it?
- added unit tests
- fixed breaking tests in test_conditional_router.py
### Notes for the reviewer
<!-- E.g. point out section where the reviewer -->
... | 2025-04-20T07:43:22Z | Allow `ConditionalRouter` to have multiple outputs per condition
**Is your feature request related to a problem? Please describe.**
ConditionalRouter is very useful and quite powerful for switching between branches in a pipeline. However, there are times where I would like to route multiple things through one connectio... | [
{
"body": "**Is your feature request related to a problem? Please describe.**\nConditionalRouter is very useful and quite powerful for switching between branches in a pipeline. However, there are times where I would like to route multiple things through one connection. This makes it easier to see the flow of th... | c4bb854d7c5b290e0609974c57c8a8fbdb4be3ad | {
"head_commit": "ac6a67f9ccf2d693fe26d72eef9312954a50e7e8",
"head_commit_message": "feat: Add support for multiple outputs in ConditionalRouter",
"patch_to_review": "diff --git a/haystack/components/routers/conditional_router.py b/haystack/components/routers/conditional_router.py\nindex 8f94882b26..59fc36a6f2 10... | [
{
"diff_hunk": "@@ -347,9 +373,23 @@ def _validate_routes(self, routes: List[Dict]):\n raise ValueError(\n f\"Route must contain 'condition', 'output', 'output_type' and 'output_name' fields: {route}\"\n )\n- for field in [\"condition\", \"output\"]... | 6f95812626ea32b4fcaee6512bc7fc18389ae7e4 | diff --git a/haystack/components/routers/conditional_router.py b/haystack/components/routers/conditional_router.py
index 8f94882b26..917b57ed71 100644
--- a/haystack/components/routers/conditional_router.py
+++ b/haystack/components/routers/conditional_router.py
@@ -203,11 +203,19 @@ def __init__( # pylint: disable=to... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
deepset-ai__haystack-9242@a3cdb7d | deepset-ai/haystack | Python | 9,242 | feat: allow SuperComponent to Include outputs from non leaf pipeline components | ### Related Issues
- fixes #9231
### Proposed Changes:
- map nonleaf pipelines outputs to the supercomponenets output
### How did you test it?
- added unit test
### Notes for the reviewer
<!-- E.g. point out section where the reviewer -->
### Checklist
- I have read the [contributors guidel... | 2025-04-15T18:19:37Z | Allow SuperComponent to include outputs from already-connected components
Currently SuperComponent can only have outputs from Components that don't have their output connected.
A workaround for this is to connect the component you would also like the output of to an isolated Joiner which you can then connect to the o... | [
{
"body": "Currently SuperComponent can only have outputs from Components that don't have their output connected. \n\nA workaround for this is to connect the component you would also like the output of to an isolated Joiner which you can then connect to the output. \n\nI believe a better solution would be to:\n... | cdc53cae78d080d67ecaa184ff16a83dba13a010 | {
"head_commit": "a3cdb7d250ce0234459cb7f245b575ca0a622be7",
"head_commit_message": "add rn",
"patch_to_review": "diff --git a/haystack/core/super_component/super_component.py b/haystack/core/super_component/super_component.py\nindex 0cb5a80830..a47d6de7cb 100644\n--- a/haystack/core/super_component/super_compone... | [
{
"diff_hunk": "@@ -129,7 +129,7 @@ def __init__(\n self._original_input_mapping = input_mapping\n \n # Set output types based on pipeline and mapping\n- pipeline_outputs = self.pipeline.outputs()\n+ pipeline_outputs = self.pipeline.outputs(include_components_with_connected_outputs... | 8f647bd7439dcf25c328bfc77c5886c244c881d0 | diff --git a/haystack/core/super_component/super_component.py b/haystack/core/super_component/super_component.py
index 0cb5a80830..b2408c0e24 100644
--- a/haystack/core/super_component/super_component.py
+++ b/haystack/core/super_component/super_component.py
@@ -129,12 +129,14 @@ def __init__(
self._original_i... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
deepset-ai__haystack-9230@22739a9 | deepset-ai/haystack | Python | 9,230 | fix: Allow Agent to run with no tools | ### Related Issues
- fixes https://github.com/deepset-ai/haystack/issues/9220
### Proposed Changes:
<!--- In case of a bug: Describe what caused the issue and how you solved it -->
<!--- In case of a feature: Describe what did you add and how it works -->
Updates the init and run logic of Agent to truly al... | 2025-04-14T09:47:12Z | Agent component has an Optional 'tools' init param, but fails if no tool is provided
**Describe the bug**
Hey there! Not sure it's a bug, but I need some clarifications.
If I simply do:
```python
import os
os.environ["AZURE_OPENAI_API_KEY"] = "***"
os.environ["AZURE_OPENAI_ENDPOINT"] = "***"
from haystack.components... | Hey @danielescaramuzzi thanks for catching this! You're right this is a bug, just trying to think if it makes sense to allow Tools to be optional or not. My impression is that if you are running an agent with no Tools then probably it's best to use a ChatGenerator directly at that point.
But it could easily be set up... | [
{
"body": "**Describe the bug**\nHey there! Not sure it's a bug, but I need some clarifications. \nIf I simply do:\n\n```python\nimport os\nos.environ[\"AZURE_OPENAI_API_KEY\"] = \"***\"\nos.environ[\"AZURE_OPENAI_ENDPOINT\"] = \"***\"\n\nfrom haystack.components.generators.chat import AzureOpenAIChatGenerator\... | 185e1c79c9f15ac90226282e44f75699c38428fc | {
"head_commit": "22739a99e0301ec72525a0cbb43d4ce625b35b43",
"head_commit_message": "Update docstring and warning message",
"patch_to_review": "diff --git a/haystack/components/agents/agent.py b/haystack/components/agents/agent.py\nindex dce17d6a8f..64afae46f5 100644\n--- a/haystack/components/agents/agent.py\n++... | [
{
"diff_hunk": "@@ -30,6 +30,9 @@ class Agent:\n The component processes messages and executes tools until a exit_condition condition is met.\n The exit_condition can be triggered either by a direct text response or by invoking a specific designated tool.\n \n+ When you call an Agent without any tool... | d117bb15fa10a8c7e80cef93291391f842853c73 | diff --git a/haystack/components/agents/agent.py b/haystack/components/agents/agent.py
index a976ca2d7e..fbfc1cd5e5 100644
--- a/haystack/components/agents/agent.py
+++ b/haystack/components/agents/agent.py
@@ -31,6 +31,8 @@ class Agent:
The component processes messages and executes tools until a exit_condition co... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
deepset-ai__haystack-9275@7b9d4d9 | deepset-ai/haystack | Python | 9,275 | feat: return common type in SuperComponent type compatibility check | ### Related Issues
- fixes #9076
### Proposed Changes:
- modified _types_are_compatible to return Tuple[bool, Optional[T]]
- updated super_component.py to use the common type returned by _types_are_compatible
### How did you test it?
- added unit tests
### Notes for the reviewer
<!-- E.g. point o... | 2025-04-21T17:35:42Z | In SuperComponent utils update `_is_compatible(type1, type2)` to return the common type
In SuperComponents during the validation of an `input_mapping` provided by a user we check if the types of the combined inputs are compatible using the `_is_compatible` utility function. `_is_compatible` works by checking if the two... | [
{
"body": "In SuperComponents during the validation of an `input_mapping` provided by a user we check if the types of the combined inputs are compatible using the `_is_compatible` utility function. `_is_compatible` works by checking if the two types have some overlapping common type rather than using strict typ... | e6a53b9dcaeab7521084c6b4af620971b3c2953e | {
"head_commit": "7b9d4d9f6e884788b84cc0ef9b498b13d587a732",
"head_commit_message": "fix test_utils",
"patch_to_review": "diff --git a/haystack/core/super_component/super_component.py b/haystack/core/super_component/super_component.py\nindex fd4027eec5..4864b40e1d 100644\n--- a/haystack/core/super_component/super... | [
{
"diff_hunk": "@@ -53,34 +59,72 @@ def _types_are_compatible(type1: T, type2: T) -> bool:\n return _check_non_union_compatibility(type1, type2, type1_origin, type2_origin)\n \n \n-def _check_union_compatibility(type1: T, type2: T, type1_origin: Any, type2_origin: Any) -> bool:\n+def _check_union_compatibil... | e0e4d228ade426d059a08b51c1d05d5211b63565 | diff --git a/haystack/core/super_component/super_component.py b/haystack/core/super_component/super_component.py
index b0c401bc5e..95a0a32f47 100644
--- a/haystack/core/super_component/super_component.py
+++ b/haystack/core/super_component/super_component.py
@@ -211,16 +211,20 @@ def _resolve_input_types_from_mapping(
... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
deepset-ai__haystack-8997@5389093 | deepset-ai/haystack | Python | 8,997 | feat: Improve type validation for bare types | ### Related Issues
- fixes #8874
### Proposed Changes:
- Treat bare types (e.g., List, Dict) as generic types with Any arguments during type compatibility checks.
### How did you test it?
- added unit tests
### Notes for the reviewer
<!-- E.g. point out section where the reviewer -->
### Che... | 2025-03-06T18:00:10Z | Improve type validation to handle bare typing objects
**Is your feature request related to a problem? Please describe.**
Our current type validation used when validating pipeline connections doesn't support comparison of bare types. For example, `List[Any]` does not get matched to `List` even though it should.
**Descr... | Here are some tests (not exhaustive) we can use while developing this
```python
@pytest.mark.parametrize(
"sender_type,receiver_type",
[
pytest.param(List[int], List, id="list-of-primitive-to-bare-list"),
pytest.param(Dict[str, int], Dict, id="dict-of-primitive-to-bare-dict"),
pytest.pa... | [
{
"body": "**Is your feature request related to a problem? Please describe.**\nOur current type validation used when validating pipeline connections doesn't support comparison of bare types. For example, `List[Any]` does not get matched to `List` even though it should.\n\n**Describe the solution you'd like**\nU... | c037052581a1caef3287332635ca73bcd3bb07ea | {
"head_commit": "538909333cd75f6af12c1d50b6ccb03330dbe936",
"head_commit_message": "address review comments",
"patch_to_review": "diff --git a/haystack/core/type_utils.py b/haystack/core/type_utils.py\nindex 4b84c74dc0..834577bc89 100644\n--- a/haystack/core/type_utils.py\n+++ b/haystack/core/type_utils.py\n@@ -... | [
{
"diff_hunk": "@@ -2,6 +2,7 @@\n #\n # SPDX-License-Identifier: Apache-2.0\n \n+import collections.abc",
"line": null,
"original_line": 5,
"original_start_line": null,
"path": "haystack/core/type_utils.py",
"start_line": null,
"text": "@user1:\n```suggestion\r\n```"
}
] | 88ac958f19416b2859fed17f2d759dd7b05711d3 | diff --git a/haystack/core/type_utils.py b/haystack/core/type_utils.py
index 4b84c74dc0..162fcc759f 100644
--- a/haystack/core/type_utils.py
+++ b/haystack/core/type_utils.py
@@ -64,6 +64,12 @@ def _strict_types_are_compatible(sender, receiver): # pylint: disable=too-many-
# Compare generic type arguments
se... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
deepset-ai__haystack-9067@195aa7e | deepset-ai/haystack | Python | 9,067 | feat: adding `AutoMergingRetriever` and `HierarchicalDocumentSplitter` | ### Related Issues
- fixes [#241](https://github.com/deepset-ai/haystack-experimental/issues/241)
### Proposed Changes:
- Moving `AutoMergingRetriever` and `HierarchicalDocumentSplitter` from experimental
### How did you test it?
- unit tests, integration tests, manual verification, instructions for manu... | 2025-03-19T10:47:54Z | Move AutoMergingRetriever and HierarchicalDocumentSplitter to Haystack core
**Steps for Moving an Experiment to Haystack Core or Integrations**
- [x] Make sure the latest Haystack release or an integration release contains the merged experiment
- [x] Update import statements in example cookbook, remove experimental tag... | [
{
"body": "**Steps for Moving an Experiment to Haystack Core or Integrations**\n- [x] Make sure the latest Haystack release or an integration release contains the merged experiment\n- [x] Update import statements in example cookbook, remove experimental tag from cookbook, update blogpost etc.\n- [x] Close discu... | 9a046ed431721aab9255247a23af7d0f30ff7ad5 | {
"head_commit": "195aa7e5d01a47886eb3cae5c237f131c0e3118e",
"head_commit_message": "adding renamed file",
"patch_to_review": "diff --git a/haystack/components/preprocessors/__init__.py b/haystack/components/preprocessors/__init__.py\nindex ee60c5eac7..81df1c6fb0 100644\n--- a/haystack/components/preprocessors/__... | [
{
"diff_hunk": "@@ -0,0 +1,169 @@\n+# SPDX-FileCopyrightText: 2022-present deepset GmbH <info@deepset.ai>\n+#\n+# SPDX-License-Identifier: Apache-2.0\n+\n+from collections import defaultdict\n+from typing import Any, Dict, List\n+\n+from haystack import Document, component, default_to_dict\n+from haystack.core.... | 37298db9deb908a72c39dadbd3759296f05c2699 | diff --git a/docs/pydoc/config/preprocessors_api.yml b/docs/pydoc/config/preprocessors_api.yml
index a578b73fdc..19710cf530 100644
--- a/docs/pydoc/config/preprocessors_api.yml
+++ b/docs/pydoc/config/preprocessors_api.yml
@@ -1,7 +1,14 @@
loaders:
- type: haystack_pydoc_tools.loaders.CustomPythonLoader
search... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
canonical__microk8s-4714@e66351f | canonical/microk8s | Python | 4,714 | fix non sudo enable community addon |
<!--
Thank you for making MicroK8s better. Please fill the template below
with more details.
-->
#### Summary
This PR fixes issues when non-root user in non-strict environment tries to enable community addons.
Closes #4574
#### Changes
added temporary setting to git to ingnore
<!-- Please expl... | 2024-10-22T15:10:07Z | Error enabling community addon in MicroK8s 1.30.1
#### Summary
I encountered an error when trying to enable the community addon in MicroK8s version 1.30.1. The error message suggests an issue with repository ownership and permissions. This issue did not occur in MicroK8s version 1.29, where the same command worked fin... | Thank you for reporting this @JosePedro90 . While we are working on a fix, can you try `sudo microk8s enable community` ?
I tried using sudo and the issue remained
Got the same error. Running the suggested command fixes the problem:
```
git config --global --add safe.directory /snap/microk8s/current/addons/community... | [
{
"body": "#### Summary\r\nI encountered an error when trying to enable the community addon in MicroK8s version 1.30.1. The error message suggests an issue with repository ownership and permissions. This issue did not occur in MicroK8s version 1.29, where the same command worked fine.\r\n\r\n#### What Should Ha... | ee4558ad793e2e96cb316097df04e8ee51e3b9ec | {
"head_commit": "e66351f7c455a323e7ef77e30f129a0506b8e15d",
"head_commit_message": "hardcode gitconfig",
"patch_to_review": "diff --git a/microk8s-resources/gitconfig b/microk8s-resources/gitconfig\nnew file mode 100644\nindex 0000000000..370c6b79df\n--- /dev/null\n+++ b/microk8s-resources/gitconfig\n@@ -0,0 +1,... | [
{
"diff_hunk": "@@ -250,6 +250,7 @@ parts:\n cp client.config.template \"${SNAPCRAFT_PART_INSTALL}/client.config.template\"\n cp kubelet.config.template \"${SNAPCRAFT_PART_INSTALL}/kubelet.config.template\"\n cp client-x509.config.template \"${SNAPCRAFT_PART_INSTALL}/client-x509.config.templat... | 985d81a38a6249da6a479ebbe8e09c23755d948f | diff --git a/microk8s-resources/default-args/git/.gitconfig b/microk8s-resources/default-args/git/.gitconfig
new file mode 100644
index 0000000000..370c6b79df
--- /dev/null
+++ b/microk8s-resources/default-args/git/.gitconfig
@@ -0,0 +1,3 @@
+[safe]
+ directory = /snap/microk8s/current/addons/community/.git
+ ... | {
"difficulty": "low",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
deepset-ai__haystack-9001@be018c3 | deepset-ai/haystack | Python | 9,001 | feat: time extension for ChatPromptBuilder | ### Related Issues
- fixes [#8985
](https://github.com/deepset-ai/haystack/issues/8985)
### Proposed Changes:
<!--- In case of a bug: Describe what caused the issue and how you solved it -->
<!--- In case of a feature: Describe what did you add and how it works -->
### How did you test it?
<!-- unit te... | 2025-03-07T16:17:40Z | Add Jinja2TimeExtension to ChatPromptBuilder
**Is your feature request related to a problem? Please describe.**
In the PromptBuilder, we use the Jinja2TimeExtension if it is available to allow users to inject the current date into the prompt. The same should be possible for the ChatPromptBuilder.
**Describe the soluti... | [
{
"body": "**Is your feature request related to a problem? Please describe.**\nIn the PromptBuilder, we use the Jinja2TimeExtension if it is available to allow users to inject the current date into the prompt. The same should be possible for the ChatPromptBuilder.\n\n**Describe the solution you'd like**\n- Add ... | 3c101cdfd6027d74ac24edc3f6d0a9348d09a190 | {
"head_commit": "be018c36da0c3836dfa53ddc8c5f31011802aea1",
"head_commit_message": "chore: release notes",
"patch_to_review": "diff --git a/haystack/components/builders/chat_prompt_builder.py b/haystack/components/builders/chat_prompt_builder.py\nindex 33e2feda2d..b8d4acdfac 100644\n--- a/haystack/components/bui... | [
{
"diff_hunk": "@@ -124,7 +125,13 @@ def __init__(\n self.required_variables = required_variables or []\n self.template = template\n variables = variables or []\n- self._env = SandboxedEnvironment()\n+ try:\n+ # The Jinja2TimeExtension needs an optional dependenc... | 8eb0801747c8434d00f21762a48acc3ae0c76eb9 | diff --git a/haystack/components/builders/chat_prompt_builder.py b/haystack/components/builders/chat_prompt_builder.py
index a097c93194..21a90f785c 100644
--- a/haystack/components/builders/chat_prompt_builder.py
+++ b/haystack/components/builders/chat_prompt_builder.py
@@ -10,6 +10,7 @@
from haystack import compone... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
deepset-ai__haystack-9034@3cc8416 | deepset-ai/haystack | Python | 9,034 | feat: LinkContentFetcher - replace requests with httpx, add async and http/2 | ### Why:
Enhances the `LinkContentFetcher` functionality by introducing asynchronous content fetching capabilities and optional HTTP/2 support, replacing `requests` with `httpx` to improve performance and reliability.
- fixes https://github.com/deepset-ai/haystack/issues/9000
### What:
- Added asynchronous meth... | 2025-03-13T01:13:06Z | Migrate `LinkContentFetcher` from `requests` to `httpx` and add async run
The `LinkContentFetcher` currently relies on the `requests` dependency and we should use `httpx` instead.
HTTPX supports async out of the box and also HTTP/2. It's already a Haystack dependency through openai-python.
As part of this issue we sho... | [
{
"body": "The `LinkContentFetcher` currently relies on the `requests` dependency and we should use `httpx` instead.\nHTTPX supports async out of the box and also HTTP/2. It's already a Haystack dependency through openai-python.\n\nAs part of this issue we should also add an async run implementation, which shou... | 4773d576bcb6181abd02794aa11dda27cef2114f | {
"head_commit": "3cc84166f3a95e2fd550ecb2f12b688ccd879133",
"head_commit_message": "LinkContentFetcher - replace requests with httpx, add async and http/2",
"patch_to_review": "diff --git a/haystack/components/fetchers/link_content.py b/haystack/components/fetchers/link_content.py\nindex fb85d11485..b93d3d345e 1... | [
{
"diff_hunk": "@@ -72,14 +76,30 @@ class LinkContentFetcher:\n assert streams[0].meta == {'content_type': 'text/html', 'url': 'https://www.google.com'}\n assert streams[0].data\n ```\n+\n+ For async usage:\n+\n+ ```python\n+ import asyncio\n+ from haystack.components.fetchers.link_conte... | e34544d5051da6602670298d1216b1bf31a25d19 | diff --git a/haystack/components/fetchers/link_content.py b/haystack/components/fetchers/link_content.py
index fb85d11485..4416e424ef 100644
--- a/haystack/components/fetchers/link_content.py
+++ b/haystack/components/fetchers/link_content.py
@@ -2,20 +2,24 @@
#
# SPDX-License-Identifier: Apache-2.0
+import asyncio... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
canonical__microk8s-3418@93ed48c | canonical/microk8s | Python | 3,418 | Clean up Calico virtual interfaces on uninstall (#2903) | #### Summary
This PR cleans up Calico interfaces that are left after uninstalling microk8s as described in #2903.
The first part is deleting the vxlan interface that is used for nodes - the change here is actually fixing a typo, the deletion was already intended and present in the code, however the interface name... | 2022-08-30T12:45:36Z | Calico virtual network interfaces not cleaned up on uninstall
Uninstalling the microk8s snap does not clean up any network interfaces created by Calico. Occured after uninstalling `v1.23.3` using `snap`.
```
~
$ ip a
...
66: cali2b0ba0cec00@if3: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1440 qdisc noqueue state UP g... | Thank you for reporting this @simskij
We will probably need to take care these interfaces in the remove hook [1]. Special care should be taken when MicroK8s runs on lxc so we do not destroy interfaces used by other containers.
[1] https://github.com/ubuntu/microk8s/blob/master/snap/hooks/remove
Hey, i would like... | [
{
"body": "Uninstalling the microk8s snap does not clean up any network interfaces created by Calico. Occured after uninstalling `v1.23.3` using `snap`.\r\n\r\n```\r\n~\r\n$ ip a\r\n...\r\n66: cali2b0ba0cec00@if3: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1440 qdisc noqueue state UP group default \r\n link/ether... | 314d845827ede0159015e6a68f64d1b775c37bca | {
"head_commit": "93ed48c4ae17288a226b9d203f54367dd9356a11",
"head_commit_message": "fix(calico): Remove unsupported flag",
"patch_to_review": "diff --git a/microk8s-resources/default-hooks/remove.d/10-cni-link b/microk8s-resources/default-hooks/remove.d/10-cni-link\nindex 3c80d81d15..3e4be2df28 100755\n--- a/mic... | [
{
"diff_hunk": "@@ -11,8 +11,8 @@ then\n \"${SNAP}/sbin/ip\" link delete \"${link}\" || true\n fi\n done\n- for calink in $(\"${SNAP}/sbin/ip\" -j --pretty link show |\\\n- awk '/cali/ {print $2}' | tr -d '\",')\n+ for calink in $(\"${SNAP}/sbin/ip\" -j link show |\\\n+ ... | 1a7dd3fb820a184ffff97c8ed2c97f3dc9a0bbcf | diff --git a/microk8s-resources/default-hooks/remove.d/10-cni-link b/microk8s-resources/default-hooks/remove.d/10-cni-link
index 3c80d81d15..628e924a93 100755
--- a/microk8s-resources/default-hooks/remove.d/10-cni-link
+++ b/microk8s-resources/default-hooks/remove.d/10-cni-link
@@ -4,11 +4,15 @@
if ! is_strict || (i... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
cython__cython-6943@b15ad19 | cython/cython | Python | 6,943 | Make 'depfile' generation recognise 'cython.cimports.*' dependencies and Unicode names | Fixes https://github.com/cython/cython/issues/6938 | 2025-06-05T13:30:42Z | [BUG] PXD dependencies are not listed in the depfiles for pure python code.
### Describe the bug
If you have two equivalent cython files, one in cython and one in pure python, only the cython version will output correct dependency information when compiled with `cython -M`. This happens even when including pxd files o... | Thanks for the report. The depfile generation hadn't caught up with the features yet, it seems. | [
{
"body": "### Describe the bug\n\nIf you have two equivalent cython files, one in cython and one in pure python, only the cython version will output correct dependency information when compiled with `cython -M`. This happens even when including pxd files outside the standard library.\n\n### Code to reproduce t... | 5db24d91392342900494326ebba606ae3f235a46 | {
"head_commit": "b15ad19a241143bfbc25313c4aa9c9f01f1ddabb",
"head_commit_message": "Fix test on Windows.",
"patch_to_review": "diff --git a/Cython/Build/Dependencies.py b/Cython/Build/Dependencies.py\nindex 477ff586fee..5714f6b6537 100644\n--- a/Cython/Build/Dependencies.py\n+++ b/Cython/Build/Dependencies.py\n@... | [
{
"diff_hunk": "@@ -392,13 +392,17 @@ def parse_code(start: cython.Py_ssize_t, in_fstring: cython.bint = False) -> cyt\n # We need to allow spaces to allow for conditional compilation like\n # IF ...:\n # cimport ...\n-dependency_regex = re.compile(r\"(?:^\\s*from +([0-9a-zA-Z_.]+) +cimport)|\"\n- ... | b5990e807efe35054b30bd1f26be9ab594b48368 | diff --git a/Cython/Build/Dependencies.py b/Cython/Build/Dependencies.py
index 477ff586fee..02298a9124f 100644
--- a/Cython/Build/Dependencies.py
+++ b/Cython/Build/Dependencies.py
@@ -392,14 +392,18 @@ def parse_code(start: cython.Py_ssize_t, in_fstring: cython.bint = False) -> cyt
# We need to allow spaces to allow ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
Subsets and Splits
Review Test Instances
Retrieves basic metadata about code review instances but doesn't provide any analytical insights or patterns beyond raw data access.