instance_id stringlengths 21 53 | repo stringclasses 188
values | language stringclasses 1
value | pull_number int64 20 148k | title stringlengths 6 144 | body stringlengths 0 83.4k | created_at stringdate 2015-09-25 03:17:17 2025-07-10 16:50:35 | problem_statement stringlengths 188 240k | hints_text stringlengths 0 145k | resolved_issues listlengths 1 6 | base_commit stringlengths 40 40 | commit_to_review dict | reference_review_comments listlengths 1 62 | merged_commit stringlengths 40 40 | merged_patch stringlengths 297 9.87M | metadata dict |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
apache__airflow-33637@914eebf | apache/airflow | Python | 33,637 | Use a trimmed version of README.md for PyPI | closes: #33505
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"... | 2023-08-23T02:37:37Z | Trim down the PyPI readme
### Body
The PyPI README is far too long for the PyPI page. Just basic summary is needed and links to documentation, changelog,GitHub page.
We have now dedicated Changelog page and there should be a "project-url" pointing to it (same as in Providers).
Some images (AWS) are broken an... | I could try working on this if that sounds okay
Feel free.
> Just basic summary is needed and links to documentation, changelog, GitHub page.
I don’t think we even need the links? They are already available in the sidebar on the left anyway.
> > Just basic summary is needed and links to documentation, changelog, Git... | [
{
"body": "### Body\r\n\r\nThe PyPI README is far too long for the PyPI page. Just basic summary is needed and links to documentation, changelog,GitHub page.\r\n\r\nWe have now dedicated Changelog page and there should be a \"project-url\" pointing to it (same as in Providers). \r\n\r\nSome images (AWS) are br... | 794bd43aa870c08d68488ad7597576f6ad0ed02c | {
"head_commit": "914eebf4910844f8189a0efaacea5462a656b18d",
"head_commit_message": "Try a change",
"patch_to_review": "diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml\nindex 60a4a68304f68..8725670806a43 100644\n--- a/.pre-commit-config.yaml\n+++ b/.pre-commit-config.yaml\n@@ -137,7 +137,7 @@ repos... | [
{
"diff_hunk": "@@ -132,3 +132,6 @@ chart/*.iml\n \n # Sha files\n .*sha256\n+\n+# Generated PyPI README file\n+generated/PYPI_README.md",
"line": null,
"original_line": 137,
"original_start_line": null,
"path": ".rat-excludes",
"start_line": null,
"text": "@user1:\n```suggestion\r\n./ge... | 886c3d945d86aba54a08728bfdf37386585b2d64 | diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
index 60a4a68304f68..b1988fcd1061f 100644
--- a/.pre-commit-config.yaml
+++ b/.pre-commit-config.yaml
@@ -761,6 +761,12 @@ repos:
exclude: ^tests/system/providers/google/cloud/bigquery/example_bigquery_queries\.py$
pass_filenames: true
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Code Refactoring / Architectural Improvement"
} |
apache__airflow-31113@57bf5c1 | apache/airflow | Python | 31,113 | Render DAGCode in the Grid View as a tab | closes: #29858
Using REST API to render DAG Code in the grid view as a tab when a user has no tasks selected.
<!--
Thank you for contributing! Please make sure that your code changes
are covered w... | 2023-05-06T17:38:27Z | Migrate DAG Code page to Grid Details
- [ ] Use REST API to render DAG Code in the grid view as a tab when a user has no runs/tasks selected
- [ ] Redirect all urls to new code
- [ ] delete the old code view | Hello @bbovenzi, Can I take a stab at this one?
Feel free.
@bbovenzi @potiuk Can you please help me point to any additional details around this request to get me started? Thanks for your time!
What do you miss? Generally we expect anyone who takes on the tasks to be pretty self-sufficient using our code and documentati... | [
{
"body": "- [ ] Use REST API to render DAG Code in the grid view as a tab when a user has no runs/tasks selected\r\n- [ ] Redirect all urls to new code \r\n- [ ] delete the old code view",
"number": 29858,
"title": "Migrate DAG Code page to Grid Details"
}
] | 6713fb29237d3f890d9067f9a71490ce1535a925 | {
"head_commit": "57bf5c153c69caf9a2b8f1964237ba6d333161b7",
"head_commit_message": "Removed console.log",
"patch_to_review": "diff --git a/airflow/www/package.json b/airflow/www/package.json\nindex b15568593cc84..15d9279740895 100644\n--- a/airflow/www/package.json\n+++ b/airflow/www/package.json\n@@ -41,6 +41,7... | [
{
"diff_hunk": "@@ -0,0 +1,98 @@\n+/*!\n+ * Licensed to the Apache Software Foundation (ASF) under one\n+ * or more contributor license agreements. See the NOTICE file\n+ * distributed with this work for additional information\n+ * regarding copyright ownership. The ASF licenses this file\n+ * to you under th... | 1c11044709caadee9d38c441585a97af18a610a2 | diff --git a/airflow/www/package.json b/airflow/www/package.json
index b15568593cc84..15d9279740895 100644
--- a/airflow/www/package.json
+++ b/airflow/www/package.json
@@ -41,6 +41,7 @@
"@types/color": "^3.0.3",
"@types/react": "^18.0.12",
"@types/react-dom": "^18.0.5",
+ "@types/react-syntax-highlig... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
apache__airflow-29772@06813d3 | apache/airflow | Python | 29,772 | Support deleting the local log files when using remote logging | closes: #16142
---
In this PR, I add a new parameter `delete_local_copy` for `S3TaskHandler`, `GCSTaskHandler` and `OSSTaskHandler` (`WasbTaskHandler` already has it), to support deleting the local copy of logs after uploading it to remote logging location.
To avoid adding unnecessary extra dependency between th... | 2023-02-26T02:28:11Z | Delete local logs when choosing remote logging
<!--
Welcome to Apache Airflow! For a smooth issue process, try to answer the following questions.
Don't worry if they're not all applicable; just try to include what you can :-)
If you need to include code snippets or logs, please put them in fenced code
blocks. ... | Hey @JPonte - thanks! Would you like to submit PR for that?
@potiuk Yes, I'll see what I can do.
Is it an option to put this behind a flag? We also use remote logging but are in favor of keeping our logs locally as well. In the case our remote logging solution becomes unavailable, we still have the local logs for debug... | [
{
"body": "<!--\r\n\r\nWelcome to Apache Airflow! For a smooth issue process, try to answer the following questions.\r\nDon't worry if they're not all applicable; just try to include what you can :-)\r\n\r\nIf you need to include code snippets or logs, please put them in fenced code\r\nblocks. If they're supe... | 4a9e1e8a1fcf76c0bd9e2c501b0da0466223f6ac | {
"head_commit": "06813d32a9e32e9175da562be3c822caeebbdca3",
"head_commit_message": "fix spelling",
"patch_to_review": "diff --git a/airflow/config_templates/airflow_local_settings.py b/airflow/config_templates/airflow_local_settings.py\nindex 39d809e5167ed..86482d3d05468 100644\n--- a/airflow/config_templates/ai... | [
{
"diff_hunk": "@@ -606,6 +606,14 @@ logging:\n type: string\n example: ~\n default: \"\"\n+ delete_local_logs:\n+ description: |\n+ Whether the local log files for GCS, S3, WASB and OSS remote logging should be deleted after\n+ they are uploaded to remote location",
... | a4f40b31e405e8a949dee7bf920f578c68ceb315 | diff --git a/airflow/config_templates/airflow_local_settings.py b/airflow/config_templates/airflow_local_settings.py
index 39d809e5167ed..86482d3d05468 100644
--- a/airflow/config_templates/airflow_local_settings.py
+++ b/airflow/config_templates/airflow_local_settings.py
@@ -203,6 +203,7 @@
# WASB buckets should ... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
apache__airflow-24570@886bb06 | apache/airflow | Python | 24,570 | Add parameter to turn off SQL query logging | <!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
r... | 2022-06-20T20:45:34Z | Support to turn off the sql echo at logging in dbapi_hook
**Description**
through the parameter, like `mute=True`,
can turn off not to echo the SQL query
**Use case / motivation**
I hope we can turn on or off the option to echo or not echo of SQL query
First, if the query is too long, the log becomes unne... | Thanks for opening your first issue here! Be sure to follow the issue template!
Related: https://github.com/apache/airflow/pull/9671
CC: @kaxil @davido912 @madison-ookla
Is this somethign we should inclue in 2.0 @mik-laj ? WDYT? Shall we remove the milestone from it?
I removed the milestone because this looks like a... | [
{
"body": "\r\n**Description**\r\n\r\nthrough the parameter, like `mute=True`, \r\ncan turn off not to echo the SQL query\r\n\r\n**Use case / motivation**\r\n\r\nI hope we can turn on or off the option to echo or not echo of SQL query\r\nFirst, if the query is too long, the log becomes unnecessarily heavy\r\nAn... | 4f4f37c855d58f99c9b999fa0f19e0c0505274f4 | {
"head_commit": "886bb065630720b6639debf193210ef8eef0a13b",
"head_commit_message": "Update docstring\n\nCo-authored-by: Tzu-ping Chung <uranusjr@gmail.com>",
"patch_to_review": "diff --git a/airflow/hooks/dbapi.py b/airflow/hooks/dbapi.py\nindex 0b9ce4377be23..e9f5882b6eec1 100644\n--- a/airflow/hooks/dbapi.py\n... | [
{
"diff_hunk": "@@ -69,7 +70,7 @@ class DbApiHook(BaseHook):\n # Override with db-specific query to check connection\n _test_connection_sql = \"select 1\"\n \n- def __init__(self, *args, schema: Optional[str] = None, **kwargs):\n+ def __init__(self, *args, schema: Optional[str] = None, log_sql: Op... | 830bd9d0cd231540b24f1d84972117f63973524a | diff --git a/airflow/hooks/dbapi.py b/airflow/hooks/dbapi.py
index 0b9ce4377be23..d3d3fa5fc8972 100644
--- a/airflow/hooks/dbapi.py
+++ b/airflow/hooks/dbapi.py
@@ -56,6 +56,7 @@ class DbApiHook(BaseHook):
:param schema: Optional DB schema that overrides the schema specified in the connection. Make sure that
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
apache__airflow-24084@0966e5f | apache/airflow | Python | 24,084 | Adding fnmatch type regex to SFTPSensor | Adding the ability of regex match ([fnmatch](https://docs.python.org/3/library/fnmatch.html) style regex) to `SFTPSensor`.
This change to the sensor will make it wait for the first available file, based on the given pattern, and then continue working on this file as usual.
My assumption is that `SFTPSensor` should... | 2022-06-01T16:50:05Z | SftpSensor w/ possibility to use RegEx or fnmatch
**Description**
SmartSftpSensor with possibility to search for patterns (RegEx or UNIX fnmatch) in filenames or folders
**Use case / motivation**
I would like to have the possibility to use wildcards and/or regular expressions to look for certain files when usi... | You can use the wildcard in SFTPSensor
Hey @blcksrx would you mind giving some more details on how to use them? If I simply use the wildcard written above with Airflow's built-in SFTPSensor, it doesn't capture anything..
Thanks in advance!!
it sounds for *nix OS that provides shell. it's convenient to use wildcards li... | [
{
"body": "**Description**\r\n\r\nSmartSftpSensor with possibility to search for patterns (RegEx or UNIX fnmatch) in filenames or folders\r\n\r\n**Use case / motivation**\r\n\r\nI would like to have the possibility to use wildcards and/or regular expressions to look for certain files when using an SftpSensor. ... | 8d6f4ed87bbb8e71ca34a7ff7a3464d677d7fb93 | {
"head_commit": "0966e5f8cb3e7353aefc347a9e49be7797ff6af9",
"head_commit_message": "Merge branch 'main' into add_fnmatch_type_matching_to_sftp_sensor",
"patch_to_review": "diff --git a/airflow/providers/sftp/hooks/sftp.py b/airflow/providers/sftp/hooks/sftp.py\nindex 58c820b838386..d436d091b5ba6 100644\n--- a/ai... | [
{
"diff_hunk": "@@ -34,6 +34,7 @@ class SFTPSensor(BaseSensorOperator):\n Waits for a file or directory to be present on SFTP.\n \n :param path: Remote file or directory path\n+ :param file_pattern: The regex pattern that will be used to match the file (fnmatch format)",
"line": null,
"origin... | cb2f13b34bdf8963f934f3f45250b7a6be89e606 | diff --git a/airflow/providers/sftp/hooks/sftp.py b/airflow/providers/sftp/hooks/sftp.py
index 58c820b838386..d436d091b5ba6 100644
--- a/airflow/providers/sftp/hooks/sftp.py
+++ b/airflow/providers/sftp/hooks/sftp.py
@@ -19,6 +19,7 @@
import datetime
import stat
import warnings
+from fnmatch import fnmatch
from typ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
apache__airflow-22849@4bf298f | apache/airflow | Python | 22,849 | Allow using mapped upstream's aggregated XCom | Fix #22833.
This needs two changes. First, when the upstream pushes the return value to XCom, we need to identify that the pushed value is not used on its own, but only aggregated with other return values from other mapped task instances. Fortunately, this is actually the only possible case right now, since we have ... | 2022-04-08T04:38:14Z | Allow mapped Task as input to another mapped task
This dag
```python
with DAG(dag_id="simple_mapping", start_date=pendulum.DateTime(2022, 4, 6), catchup=True) as d3:
@task(email='a@b.com')
def add_one(x: int):
return x + 1
two_three_four = add_one.expand(x=[1, 2, 3])
three_four_five = a... | (I edited the example code to fix what I think is the correct input.)
Whoops, yes. It's right now. | [
{
"body": "This dag\r\n\r\n```python\r\nwith DAG(dag_id=\"simple_mapping\", start_date=pendulum.DateTime(2022, 4, 6), catchup=True) as d3:\r\n @task(email='a@b.com')\r\n def add_one(x: int):\r\n return x + 1\r\n\r\n two_three_four = add_one.expand(x=[1, 2, 3])\r\n three_four_five = add_one.expa... | 5ec0bab053434319f066a6da25d58bdfef67bc6c | {
"head_commit": "4bf298f2679141b8dcc32de569d7dd52a8918a02",
"head_commit_message": "fixup! Fix tests -- lazily initialize the DB result set",
"patch_to_review": "diff --git a/airflow/models/mappedoperator.py b/airflow/models/mappedoperator.py\nindex 2114c2b4ab93c..99d153338b499 100644\n--- a/airflow/models/mappe... | [
{
"diff_hunk": "@@ -295,6 +299,71 @@ def clear_task_instances(\n dr.start_date = None\n \n \n+class _LazyXComAccessIterator(collections.abc.Iterator):\n+ __slots__ = ['_cm', '_it']\n+\n+ def __init__(self, cm: ContextManager[Query]):\n+ self._cm = cm\n+ self._it = None\n+\n+ ... | ab1339462b30071e5d36dec00897277865c141fb | diff --git a/airflow/models/mappedoperator.py b/airflow/models/mappedoperator.py
index 2114c2b4ab93c..99d153338b499 100644
--- a/airflow/models/mappedoperator.py
+++ b/airflow/models/mappedoperator.py
@@ -509,6 +509,7 @@ def _get_expansion_kwargs(self) -> Dict[str, "Mappable"]:
def _get_map_lengths(self, run_id: s... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
apache__airflow-46017@a6a7da4 | apache/airflow | Python | 46,017 | Handle future dates cases in Backfill | Closes: https://github.com/apache/airflow/issues/46012
This PR fixes the below behaviors
1. Ensure dates which are in future with run_backwards=true are not inserted in backfilldagrun table
2. Raise 422 when all dates are in the future.
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful d... | 2025-01-24T16:40:07Z | backfill should not create runs for future dates
### Body
backfill shouldn't be created for future dates I believe but if I pass run_backwards=true then its creating backfill for future date also
reverse block is missing the condition if x.data_interval.end < now
Also we can reuse the infos in the reverse block
def ... | [
{
"body": "### Body\n\n\n backfill shouldn't be created for future dates I believe but if I pass run_backwards=true then its creating backfill for future date also\nreverse block is missing the condition if x.data_interval.end < now\nAlso we can reuse the infos in the reverse block\ndef _get_info_list(\n *,\... | dddc97973dc2d31f97ea3fd14507f8085b06027f | {
"head_commit": "a6a7da4e3df83141530e86f59fa66f25a3a32762",
"head_commit_message": "fix backills future date behaviour",
"patch_to_review": "diff --git a/airflow/api_fastapi/core_api/routes/public/backfills.py b/airflow/api_fastapi/core_api/routes/public/backfills.py\nindex 78f0391fec975..7c4dc9d32a2d0 100644\n-... | [
{
"diff_hunk": "@@ -215,6 +223,8 @@ def _validate_backfill_params(dag, reverse, reprocess_behavior: ReprocessBehavio\n \"DAG has tasks for which depends_on_past=True. \"\n \"You must set reprocess behavior to reprocess completed or reprocess failed.\"\n )\n+ if fro... | a0ce044c7604f0264f889b4c543b4f1b57938841 | diff --git a/airflow/api_fastapi/core_api/routes/public/backfills.py b/airflow/api_fastapi/core_api/routes/public/backfills.py
index 78f0391fec975..7c4dc9d32a2d0 100644
--- a/airflow/api_fastapi/core_api/routes/public/backfills.py
+++ b/airflow/api_fastapi/core_api/routes/public/backfills.py
@@ -46,6 +46,7 @@
Back... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
apache__airflow-24663@259c193 | apache/airflow | Python | 24,663 | Adding generic SqlToSlackOperator | This PR is adding a generic `SqlToSlackOperator`, meaning everything that uses `DbApiHook` and implements `get_pandas_df` will now be able to send the results to Slack.
As part of this PR, I've also deprecated the current `PrestoToSlackOperator` and `SnowflakeToSlackOperator` - they now inherit from `SqlToSlackOperato... | 2022-06-26T07:17:53Z | Create `SqlToSlackOperator`
### Body
Currently we have `SnowflakeToSlackOperator` & `PrestoToSlackOperator`.
This task is to create a generic `SqlToSlackOperator` to be compatible with all hooks that has `get_pandas_df` function.
The new operator should be in `providers/slack/transfers/sql_to_slack.py`, once compl... | I'm willing to take this one :)
Hopefully, I could manage my way around this issue :)
assigned you | [
{
"body": "### Body\r\n\r\nCurrently we have `SnowflakeToSlackOperator` & `PrestoToSlackOperator`.\r\nThis task is to create a generic `SqlToSlackOperator` to be compatible with all hooks that has `get_pandas_df` function.\r\nThe new operator should be in `providers/slack/transfers/sql_to_slack.py`, once comple... | 45b11d4ed1412c00ebf32a03ab5ea3a06274f208 | {
"head_commit": "259c193fd227f3b8deae048e58c474e3352ac552",
"head_commit_message": "adding SqlToSlackOperator",
"patch_to_review": "diff --git a/airflow/providers/presto/transfers/presto_to_slack.py b/airflow/providers/presto/transfers/presto_to_slack.py\nindex 6dd0ecb3ab137..647a8d1ce7d58 100644\n--- a/airflow/... | [
{
"diff_hunk": "@@ -0,0 +1,55 @@\n+#\n+# Licensed to the Apache Software Foundation (ASF) under one\n+# or more contributor license agreements. See the NOTICE file\n+# distributed with this work for additional information\n+# regarding copyright ownership. The ASF licenses this file\n+# to you under the Apach... | efd07a59159b4be94988b174b99af93557fad8ba | diff --git a/airflow/providers/presto/transfers/presto_to_slack.py b/airflow/providers/presto/transfers/presto_to_slack.py
index 6dd0ecb3ab137..bcf2c3177a6a5 100644
--- a/airflow/providers/presto/transfers/presto_to_slack.py
+++ b/airflow/providers/presto/transfers/presto_to_slack.py
@@ -15,21 +15,13 @@
# specific lan... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
apache__airflow-18627@da521bd | apache/airflow | Python | 18,627 | Add default weight rule configuration option | closes: https://github.com/apache/airflow/issues/12807
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, refer... | 2021-09-30T07:20:49Z | add default weight_rule to airflow.cfg
**Description**
It would be nice if the weight_rule default value could be managed by a global config
suggested config:
```
# Weighting method used for the effective total priority weight of the task.
# Options are: { downstream | upstream | absolute } default is
defaul... | >In some pipeline, you really need to have absolute weight, and then you have to add a line in each task definition which is annoying
Why not define it once in `default_args`?
Then it needs to be done in each dag, right?
> Then it needs to be done in each dag, right?
Yes
Guess that is the point of issue!
On Th... | [
{
"body": "**Description**\r\n\r\nIt would be nice if the weight_rule default value could be managed by a global config\r\n\r\nsuggested config:\r\n```\r\n# Weighting method used for the effective total priority weight of the task. \r\n# Options are: { downstream | upstream | absolute } default is\r\ndefault_we... | b8ce5f0f8726d25a16ec5d5c95823c7f1489a5af | {
"head_commit": "da521bd820ead09cfd6fa1d1b8f1c73f16a66c78",
"head_commit_message": "Add configuration validation",
"patch_to_review": "diff --git a/airflow/config_templates/config.yml b/airflow/config_templates/config.yml\nindex 42d9bca822d13..4c7cfa89dbee0 100644\n--- a/airflow/config_templates/config.yml\n+++ ... | [
{
"diff_hunk": "@@ -229,6 +234,14 @@ def validate(self):\n \n self.is_validated = True\n \n+ def _validate_enums(self):\n+ \"\"\"Validate that enum type config has an accepted value\"\"\"\n+ for setting, enum_class in self.enums.items():\n+ if self.has_option('core', setting)... | 192a6f80c16d397131e8bb245020e23a2aa24766 | diff --git a/airflow/config_templates/config.yml b/airflow/config_templates/config.yml
index 42d9bca822d13..4c7cfa89dbee0 100644
--- a/airflow/config_templates/config.yml
+++ b/airflow/config_templates/config.yml
@@ -354,6 +354,13 @@
type: string
example: ~
default: "0"
+ - name: default_task_we... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
apache__airflow-18054@79dc130 | apache/airflow | Python | 18,054 | Advises the kernel to not cache log files generated by Airflow | Extends the standard python logging.FileHandler with advise to the
Kernel to not cache the file in PageCache when it is written. While
there is nothing wrong with such cache (it will be cleaned when memory
is needed), it causes ever-growing memory usage when scheduler is
running as it keeps on writing new log files... | 2021-09-07T10:41:10Z | Scheduler Memory Leak in Airflow 2.0.1
**Apache Airflow version**: 2.0.1
**Kubernetes version (if you are using kubernetes)** (use `kubectl version`): v1.17.4
**Environment**: Dev
- **OS** (e.g. from /etc/os-release): RHEL7
**What happened**:
After running fine for some time my airflow tasks got stuck in s... | Thanks for opening your first issue here! Be sure to follow the issue template!
i have same problem. i looked for all the channels and methods but did not solve it！
Thanks for your question and let me know what the problem is.
I have to use crontab script to restart scheduler process regularly. But this is stupid.... | [
{
"body": "**Apache Airflow version**: 2.0.1\r\n\r\n**Kubernetes version (if you are using kubernetes)** (use `kubectl version`): v1.17.4\r\n\r\n**Environment**: Dev\r\n- **OS** (e.g. from /etc/os-release): RHEL7\r\n\r\n**What happened**:\r\n\r\nAfter running fine for some time my airflow tasks got stuck in sch... | 0dba2e0d644ab0bd2512144231b56463218a3b74 | {
"head_commit": "79dc1309ee0806c8b28f7ac7f795c4e127614e67",
"head_commit_message": "Advises the kernel to not cache log files generated by Airflow\n\nExtends the standard python logging.FileHandler with advise to the\nKernel to not cache the file in PageCache when it is written. While\nthere is nothing wrong with ... | [
{
"diff_hunk": "@@ -0,0 +1,46 @@\n+# Licensed to the Apache Software Foundation (ASF) under one\n+# or more contributor license agreements. See the NOTICE file\n+# distributed with this work for additional information\n+# regarding copyright ownership. The ASF licenses this file\n+# to you under the Apache Li... | 6ddd8e8d5336d5281a31965ec03fdc64afff9fc2 | diff --git a/airflow/utils/cli.py b/airflow/utils/cli.py
index acdb2910da78f..64156765930b6 100644
--- a/airflow/utils/cli.py
+++ b/airflow/utils/cli.py
@@ -34,6 +34,7 @@
from airflow import settings
from airflow.exceptions import AirflowException
from airflow.utils import cli_action_loggers
+from airflow.utils.log.... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Performance Optimizations"
} |
apache__airflow-17941@a06c329 | apache/airflow | Python | 17,941 | Enable multiple cors url & doc | Close: https://github.com/apache/airflow/issues/17869
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, refere... | 2021-08-31T12:12:26Z | More than one url in cors header
**Description**
Enabled list of cors headers origin allowed
**Use case / motivation**
I'm currently developping Django application working with apache airflow for some external work through api. From Django, user run dag and a js request wait for dag end. By this way, I enabled... | Thanks for opening your first issue here! Be sure to follow the issue template!
Would you be willing to work on this and make a PR?
Yes sure, I could work on it within next week
Hi, I switched to my pro account. I've just create a PR: https://github.com/apache/airflow/pull/17941. Feel free if you have some comments | [
{
"body": "**Description**\r\n\r\nEnabled list of cors headers origin allowed\r\n\r\n**Use case / motivation**\r\n\r\nI'm currently developping Django application working with apache airflow for some external work through api. From Django, user run dag and a js request wait for dag end. By this way, I enabled c... | 5350cc2791b780a8ce721e565c235921a63565c1 | {
"head_commit": "a06c32966501d3c4f1fc42c17bff1a58900352a1",
"head_commit_message": "Adding backward",
"patch_to_review": "diff --git a/airflow/config_templates/config.yml b/airflow/config_templates/config.yml\nindex 4e5241dd0b823..8a135fef8bf11 100644\n--- a/airflow/config_templates/config.yml\n+++ b/airflow/con... | [
{
"diff_hunk": "@@ -172,6 +172,7 @@ class AirflowConfigParser(ConfigParser):\n ('core', 'default_pool_task_slot_count'): ('core', 'non_pooled_task_slot_count', '1.10.4'),\n ('core', 'max_active_tasks_per_dag'): ('core', 'dag_concurrency', '2.2.0'),\n ('logging', 'worker_log_server_port')... | 88052d4cefbbc076dd68868f004e42ce1a1d8184 | diff --git a/airflow/config_templates/config.yml b/airflow/config_templates/config.yml
index 4e5241dd0b823..e8302001f8b3b 100644
--- a/airflow/config_templates/config.yml
+++ b/airflow/config_templates/config.yml
@@ -817,9 +817,10 @@
version_added: ~
example: ~
default: ""
- - name: access_contr... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
apache__airflow-26766@cf0c9a6 | apache/airflow | Python | 26,766 | Allow xcom sidecar container image to be configurable | Closes #10605.
Adding a configurable *image* value to the `KubernetesHook` which is used by `PodDefaults.SIDECAR_CONTAINER.image` will allow both:
1. Images hosted on private repositories.
2. Overriding the default `alpine:latest` image with a specific tag. | 2022-09-29T01:01:08Z | Use private docker repository with K8S operator and XCOM sidecar container
**Use private docker repository with K8S operator and XCOM sidecar container**
An extra parameter to KubernetesPodOperator: docker_repository, this allows to specify the repository where the sidecar container is located
**My company force ... | Thanks for opening your first issue here! Be sure to follow the issue template!
would you like to add this feature @mickaelgervais ? I am happy to review it
Hi @potiuk ,
I've submitted a PR, do nopt hesitate to add comment or if I've implemented this badly.
The sidecar container declaration is low level in K8S o... | [
{
"body": "**Use private docker repository with K8S operator and XCOM sidecar container**\r\n\r\nAn extra parameter to KubernetesPodOperator: docker_repository, this allows to specify the repository where the sidecar container is located\r\n\r\n**My company force docker proxy usage for K8S**\r\n\r\nI need to us... | 9c73b3f7fc1d18925d0ed09e8719f53b8147b0f2 | {
"head_commit": "cf0c9a64ef6956ea73377302981119615d5f0201",
"head_commit_message": "added unit tests",
"patch_to_review": "diff --git a/airflow/config_templates/config.yml b/airflow/config_templates/config.yml\nindex b20fea7ff2641..e5bf8dece18bd 100644\n--- a/airflow/config_templates/config.yml\n+++ b/airflow/co... | [
{
"diff_hunk": "@@ -54,6 +56,9 @@ def add_xcom_sidecar(pod: k8s.V1Pod) -> k8s.V1Pod:\n pod_cp.spec.volumes.insert(0, PodDefaults.VOLUME)\n pod_cp.spec.containers[0].volume_mounts = pod_cp.spec.containers[0].volume_mounts or []\n pod_cp.spec.containers[0].volume_mounts.insert(0, PodDefaults.VOLUME_MO... | 540c2d2304669f8c5a49b440bfb19d079ae4ebbe | diff --git a/airflow/providers/cncf/kubernetes/hooks/kubernetes.py b/airflow/providers/cncf/kubernetes/hooks/kubernetes.py
index 27064e6b5abe3..d1c0cca8d2c62 100644
--- a/airflow/providers/cncf/kubernetes/hooks/kubernetes.py
+++ b/airflow/providers/cncf/kubernetes/hooks/kubernetes.py
@@ -91,6 +91,9 @@ def get_connectio... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
apache__airflow-17695@97d2385 | apache/airflow | Python | 17,695 | Fix sqlite hook - insert and replace functions | closes: #17632
override _generate_insert_sql() in sqlite hook to use '?' instead of the standard '%' for replacing.
Added unit tests and example of insert/replace in example dag. | 2021-08-18T18:46:33Z | SqliteHook invalid insert syntax
<!--
Welcome to Apache Airflow!
Please complete the next sections or the issue will be closed.
-->
**Apache Airflow version**: 2.1.0
<!-- AIRFLOW VERSION IS MANDATORY -->
**OS**: Raspbian GNU/Linux 10 (buster)
<!-- MANDATORY! You can get it via `cat /etc/oss-release` fo... | Thanks for opening your first issue here! Be sure to follow the issue template!
Would you be willing to provide a fix for that @bart-art ? That sounds like rather easy fix - good for first-time contribution. Happy to help with it if needed.
@Bart-art if you are not working on it, please let me know I can also take it ... | [
{
"body": "<!--\r\nWelcome to Apache Airflow!\r\n\r\nPlease complete the next sections or the issue will be closed.\r\n-->\r\n\r\n**Apache Airflow version**: 2.1.0\r\n\r\n<!-- AIRFLOW VERSION IS MANDATORY -->\r\n\r\n**OS**: Raspbian GNU/Linux 10 (buster)\r\n\r\n<!-- MANDATORY! You can get it via `cat /etc/oss-r... | 986381159ee3abf3442ff496cb553d2db004e6c4 | {
"head_commit": "97d2385ac7dc84bd6d7870ad53faff6cef6ddde4",
"head_commit_message": "Merge branch 'master' of github.com:subkanthi/airflow into fix_sqlite_doc_typo",
"patch_to_review": "diff --git a/airflow/hooks/dbapi.py b/airflow/hooks/dbapi.py\nindex 4156500085ada..f0bd85fdabfef 100644\n--- a/airflow/hooks/dba... | [
{
"diff_hunk": "@@ -324,6 +324,7 @@ def insert_rows(self, table, rows, target_fields=None, commit_every=1000, replac\n lst.append(self._serialize_cell(cell, conn))\n values = tuple(lst)\n sql = self._generate_insert_sql(table, values, target_fields... | 6a36c776522bb876e2c90c67d86cdf555e4625ec | diff --git a/airflow/hooks/dbapi.py b/airflow/hooks/dbapi.py
index 4156500085ada..3c51e6f8a3572 100644
--- a/airflow/hooks/dbapi.py
+++ b/airflow/hooks/dbapi.py
@@ -324,6 +324,7 @@ def insert_rows(self, table, rows, target_fields=None, commit_every=1000, replac
lst.append(self._serialize_cell(c... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
apache__airflow-17839@ea92dd2 | apache/airflow | Python | 17,839 | Add DAG run abort endpoint | Fixes #15888
The new endpoint will set the DAG run state and all of the task instances' state to FAILED
I couldn't find any tests for the endpoints directly, so did not add a unit test... Please let me know if I missed their location and I'll happily add them! | 2021-08-26T00:44:03Z | Abort a DAG Run
**Description**
It would be great having a option to abort a DAG Runs through the REST API.
**Use case / motivation**
The proposed input params would be:
- DAG_ID
- DAG_RUN_ID
The DAG Run should abort all its tasks running and mark them as "failed".
**Are you willing to submit a PR?**... | I still can't believe this hasn't been implemented yet, seems like a no brainer.
I am currently in need of this feature, and the only workaround i found is modifying the DB and marking the relevant task instances as failed. Seems like overkill for such a small task.
Hi @alexing,
We tried a different approach thro... | [
{
"body": "**Description**\r\n\r\nIt would be great having a option to abort a DAG Runs through the REST API.\r\n\r\n**Use case / motivation**\r\n\r\nThe proposed input params would be:\r\n - DAG_ID\r\n - DAG_RUN_ID\r\n\r\nThe DAG Run should abort all its tasks running and mark them as \"failed\".\r\n\r\n**Are ... | bec006e418706f11d92271d0b9f2a46afccc80e2 | {
"head_commit": "ea92dd26697511f7a3617681c0424374cda92053",
"head_commit_message": "fix tests and remove schema load",
"patch_to_review": "diff --git a/airflow/api_connexion/endpoints/dag_run_endpoint.py b/airflow/api_connexion/endpoints/dag_run_endpoint.py\nindex feb6d24cf3247..9d4e554313c88 100644\n--- a/airfl... | [
{
"diff_hunk": "@@ -104,6 +104,14 @@ def autofill(self, data, **kwargs):\n return data\n \n \n+class SetDagRunStateFormSchema(Schema):\n+ \"\"\"Schema for handling the request of setting state of DAG run\"\"\"\n+\n+ run_id = auto_field(data_key='dag_run_id')\n+ dag_id = auto_field(dump_only=Tru... | b4408b6400d360d3c2328a68c1e6c65e6d309681 | diff --git a/airflow/api_connexion/endpoints/dag_run_endpoint.py b/airflow/api_connexion/endpoints/dag_run_endpoint.py
index feb6d24cf3247..e816aac27e157 100644
--- a/airflow/api_connexion/endpoints/dag_run_endpoint.py
+++ b/airflow/api_connexion/endpoints/dag_run_endpoint.py
@@ -14,6 +14,8 @@
# KIND, either express o... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
apache__airflow-19981@140b831 | apache/airflow | Python | 19,981 | Add a retry with wait interval for SSH operator #14489 |
closes: #14489
Retry attempts are added if there are any errors connecting or establishing SSH session.
This will NOT retry failures like wrong host, auth errors, socket timeouts. | 2021-12-02T16:21:37Z | Add a retry with wait interval for SSH operator
<!--
Welcome to Apache Airflow! For a smooth issue process, try to answer the following questions.
Don't worry if they're not all applicable; just try to include what you can :-)
If you need to include code snippets or logs, please put them in fenced code
blocks.... | SGTM. GoogleCompute retry authorizations, so generic
hook can also do it.
@mik-laj can you elaborate on the generic hook thing? I was thinking to modify the existing hook and add an option for this.
We have 2 hooks that allows us to connect to SSH server. Second hook have retry mechanism. See: https://github.com/a... | [
{
"body": "<!--\r\n\r\nWelcome to Apache Airflow! For a smooth issue process, try to answer the following questions.\r\nDon't worry if they're not all applicable; just try to include what you can :-)\r\n\r\nIf you need to include code snippets or logs, please put them in fenced code\r\nblocks. If they're supe... | cdd9ea66208e3d70d1cf2a34530ba69bc3c58a50 | {
"head_commit": "140b83183fc48ebca3387050818e759d438fa0d3",
"head_commit_message": "Add a retry with wait interval for SSH operator #14489",
"patch_to_review": "diff --git a/airflow/providers/ssh/CHANGELOG.rst b/airflow/providers/ssh/CHANGELOG.rst\nindex 8a6182cb598c3..cfdf47bba0815 100644\n--- a/airflow/provide... | [
{
"diff_hunk": "@@ -257,58 +259,74 @@ def get_conn(self) -> paramiko.SSHClient:\n :rtype: paramiko.client.SSHClient\n \"\"\"\n self.log.debug('Creating SSH client for conn_id: %s', self.ssh_conn_id)\n- client = paramiko.SSHClient()\n \n- if not self.allow_host_key_change:\n... | 2d263dd9ea0d617fa5b7853a8e2ac3b604b1d4ae | diff --git a/airflow/providers/ssh/CHANGELOG.rst b/airflow/providers/ssh/CHANGELOG.rst
index 8a6182cb598c3..cfdf47bba0815 100644
--- a/airflow/providers/ssh/CHANGELOG.rst
+++ b/airflow/providers/ssh/CHANGELOG.rst
@@ -19,6 +19,17 @@
Changelog
---------
+2.4.0
+.....
+
+Features
+~~~~~~~~
+
+* ``Add a retry with wait... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
apache__airflow-17382@e22969a | apache/airflow | Python | 17,382 | Add new LocalFilesystemToS3Operator under Amazon provider (#17168) | Add new LocalFilesystemToS3Operator under Amazon provider (#17168)
Currently, an S3Hook exists that allows transfer of files to S3 via `load_file()`, however there is no operator associated with it. The LocalFilesystemToS3Operator would wrap the S3 Hook, so it is not used directly.
Seeing as to upload a local fil... | 2021-08-02T16:32:16Z | Add LocalFilesystemtoS3Operator
**Description**
Currently, an S3Hook exists that allows transfer of files to S3 via `load_file()`, however there is no operator associated with it. The S3Load Operator would wrap the S3 Hook, so it is not used directly.
**Use case / motivation**
Seeing as to upload a local file ... | Thanks for opening your first issue here! Be sure to follow the issue template!
Yeah we can have an operator to load from local to S3 (like the equivalent from GCP ) https://github.com/apache/airflow/blob/45a49e0f81cc592a4e6a95aa230560530d88a5c8/airflow/providers/google/cloud/transfers/local_to_gcs.py#L28
assigned ... | [
{
"body": "**Description**\r\n\r\nCurrently, an S3Hook exists that allows transfer of files to S3 via `load_file()`, however there is no operator associated with it. The S3Load Operator would wrap the S3 Hook, so it is not used directly.\r\n\r\n**Use case / motivation**\r\n\r\nSeeing as to upload a local file t... | dec1e9d0ee9fab4688e2bd60c2e23946f645cd4c | {
"head_commit": "e22969ae9fda6bb1597e75b40bba7297faa4e7b9",
"head_commit_message": "Add new LocalFilesystemToS3Operator under Amazon provider (#17168)\n\nFix `airflow celery stop` to accept the pid file. (#17278)\n\nFix isort (#17330)\n\nFix failing celery test (#17337)\n\nThis change fixes failing test due to moc... | [
{
"diff_hunk": "@@ -0,0 +1,40 @@\n+# Licensed to the Apache Software Foundation (ASF) under one\n+# or more contributor license agreements. See the NOTICE file\n+# distributed with this work for additional information\n+# regarding copyright ownership. The ASF licenses this file\n+# to you under the Apache Li... | c1c58b5e8921d5b185f3e8dcaa899c8ca73bfbce | diff --git a/airflow/providers/amazon/aws/example_dags/example_local_to_s3.py b/airflow/providers/amazon/aws/example_dags/example_local_to_s3.py
new file mode 100644
index 0000000000000..29ee771ec87e9
--- /dev/null
+++ b/airflow/providers/amazon/aws/example_dags/example_local_to_s3.py
@@ -0,0 +1,42 @@
+# Licensed to th... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
apache__airflow-17322@2a24e30 | apache/airflow | Python | 17,322 | Added print statements for clarity in provider yaml checks | closes: #17316
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
... | 2021-07-29T18:46:57Z | Docs validation function - Add meaningful errors
The following function just prints right/left error which is not very meaningful and very difficult to troubleshoot.
```python
def check_doc_files(yaml_files: Dict[str, Dict]):
print("Checking doc files")
current_doc_urls = []
current_logo_urls = []
... | [
{
"body": "The following function just prints right/left error which is not very meaningful and very difficult to troubleshoot.\r\n\r\n```python\r\ndef check_doc_files(yaml_files: Dict[str, Dict]):\r\n print(\"Checking doc files\")\r\n current_doc_urls = []\r\n current_logo_urls = []\r\n for provide... | 7bff44fba83933de1b420fbb4fc3655f28769bd0 | {
"head_commit": "2a24e30c328ca3cfa35450f909330ccd22de999e",
"head_commit_message": "Revert back change of renaming neo4j.rst",
"patch_to_review": "diff --git a/scripts/ci/pre_commit/pre_commit_check_provider_yaml_files.py b/scripts/ci/pre_commit/pre_commit_check_provider_yaml_files.py\nindex 24d963bedef2b..4906b... | [
{
"diff_hunk": "@@ -119,13 +119,13 @@ def assert_sets_equal(set1, set2):\n \n lines = []\n if difference1:\n- lines.append('Items in the first set but not the second:')\n+ lines.append(' -- Items in the left set but not the right:')\n for item in sorted(difference1):\n- ... | 80080138ac0265367c0f4b2b508c7f35c3b6d25a | diff --git a/scripts/ci/pre_commit/pre_commit_check_provider_yaml_files.py b/scripts/ci/pre_commit/pre_commit_check_provider_yaml_files.py
index 24d963bedef2b..c6c0584021c35 100755
--- a/scripts/ci/pre_commit/pre_commit_check_provider_yaml_files.py
+++ b/scripts/ci/pre_commit/pre_commit_check_provider_yaml_files.py
@@ ... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "New Feature Additions"
} | |
apache__airflow-16771@6015466 | apache/airflow | Python | 16,771 | Update AWS Base hook to use refreshable credentials (#16770) | Update AWS Base hook to use refreshable credentials when doing assume_role or similar (#16770)
TODO: Unit tests [DONE]
I've already tested in my proper Airflow environment and it works as expected.
I'm submitting this to CI so long so I can find issues more easily.
closes: #16770
| 2021-07-02T08:56:10Z | AWS hook should automatically refresh credentials when using temporary credentials
**Apache Airflow version**: 1.10.8 (Patched with latest AWS Hook)
**Environment**:
- **Cloud provider or hardware configuration**: 4 VCPU 8GB RAM VM
- **OS** (e.g. from /etc/os-release): RHEL 7.7
- **Kernel** (e.g. `uname -a`): L... | [
{
"body": "**Apache Airflow version**: 1.10.8 (Patched with latest AWS Hook)\r\n\r\n**Environment**:\r\n\r\n- **Cloud provider or hardware configuration**: 4 VCPU 8GB RAM VM\r\n- **OS** (e.g. from /etc/os-release): RHEL 7.7\r\n- **Kernel** (e.g. `uname -a`): Linux 3.10.0-957.el7.x86_64\r\n- **Install tools**:\r... | b251d22fffad63124eec5246b80035408b543704 | {
"head_commit": "601546695bf4385e7ee5a4e04f2c5f8d3879042b",
"head_commit_message": "Update AWS Base hook to use refreshable credentials when doing assume_role or similar (#16770)",
"patch_to_review": "diff --git a/airflow/providers/amazon/aws/hooks/base_aws.py b/airflow/providers/amazon/aws/hooks/base_aws.py\nin... | [
{
"diff_hunk": "@@ -97,57 +99,61 @@ def _create_basic_session(self, session_kwargs: Dict[str, Any]) -> boto3.session\n **session_kwargs,\n )\n \n- def _impersonate_to_role(\n- self, role_arn: str, session: boto3.session.Session, session_kwargs: Dict[str, Any]\n- ) -> boto3.sessi... | 93c1edaf06f0f18a43f268a64b75ffb97bd5719e | diff --git a/airflow/providers/amazon/aws/hooks/base_aws.py b/airflow/providers/amazon/aws/hooks/base_aws.py
index a1b7e7c2509ab..f64d447952780 100644
--- a/airflow/providers/amazon/aws/hooks/base_aws.py
+++ b/airflow/providers/amazon/aws/hooks/base_aws.py
@@ -58,6 +58,8 @@ def __init__(self, conn: Connection, region_n... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} | |
apache__airflow-16461@5dda2ca | apache/airflow | Python | 16,461 | [#16460]: Fixed typos in task regex param | Backfill should not create a DagRun in case there is no any task that matches the regex.
closes: #16460
| 2021-06-15T14:22:16Z | Typos in Backfill's `task-regex` param
Example:
DAG structure:
```
default_args = {
'owner': 'dimon',
'depends_on_past': False,
'start_date': datetime(2021, 1, 10)
}
dag = DAG(
'dummy-dag',
schedule_interval='21 2 * * *',
catchup=False,
default_args=default_args
)
DagContex... | [
{
"body": "Example:\r\nDAG structure:\r\n```\r\ndefault_args = {\r\n 'owner': 'dimon',\r\n 'depends_on_past': False,\r\n 'start_date': datetime(2021, 1, 10)\r\n}\r\n\r\ndag = DAG(\r\n 'dummy-dag',\r\n schedule_interval='21 2 * * *',\r\n catchup=False,\r\n default_args=default_args\r\n)\r\n\... | 608dd0ddf65dac7f7eee2cb54628a93805b7ad66 | {
"head_commit": "5dda2ca23338e5ef00b63c4dd16658ba681b4f95",
"head_commit_message": "[#16460]: Fixed pre-commit issue",
"patch_to_review": "diff --git a/airflow/cli/commands/dag_command.py b/airflow/cli/commands/dag_command.py\nindex fe2f329fef5db..319652e634895 100644\n--- a/airflow/cli/commands/dag_command.py\n... | [
{
"diff_hunk": "@@ -78,6 +78,10 @@ def dag_backfill(args, dag=None):\n dag = dag.partial_subset(\n task_ids_or_regex=args.task_regex, include_upstream=not args.ignore_dependencies\n )\n+ if not dag.task_dict:\n+ raise AirflowException(\n+ f\"There is ... | 39be8c908ffe58ee7151ce359cf1b5af3f24a1ee | diff --git a/airflow/cli/commands/dag_command.py b/airflow/cli/commands/dag_command.py
index fe2f329fef5db..e739162540fb4 100644
--- a/airflow/cli/commands/dag_command.py
+++ b/airflow/cli/commands/dag_command.py
@@ -78,6 +78,10 @@ def dag_backfill(args, dag=None):
dag = dag.partial_subset(
task_i... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "Bug Fixes"
} | |
apache__airflow-16732@8ec4f26 | apache/airflow | Python | 16,732 | Update chain() and cross_downstream() to support XComArgs | - Added support for `XComArgs` in `chain()` helper function
- Updated type annotations for `XComArg` in `cross_downstream()` helper function
- Added additional tests in `test_baseoperator.py`
Closes: #16635
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in... | 2021-06-30T15:04:23Z | Update `airflow.models.baseoperator.chain()` function to support XComArgs
**Description**
The `airflow.models.baseoperator.chain()` is a very useful and convenient way to add sequential task dependencies in DAGs but the function only supports tasks of a `BaseOperator` type.
**Use case / motivation**
Users who crea... | [
{
"body": "**Description**\r\nThe `airflow.models.baseoperator.chain()` is a very useful and convenient way to add sequential task dependencies in DAGs but the function only supports tasks of a `BaseOperator` type.\r\n\r\n**Use case / motivation**\r\nUsers who create tasks via the `@task` decorator will not be ... | df06a71bfc5e637fda38d555864b791ab5f0ad7d | {
"head_commit": "8ec4f26230b33bf9ba19fd2b6649c4da6d30b024",
"head_commit_message": "Fixing static check errors - part 2",
"patch_to_review": "diff --git a/airflow/models/baseoperator.py b/airflow/models/baseoperator.py\nindex 17ad7a7057d7b..d1f4043c7fec6 100644\n--- a/airflow/models/baseoperator.py\n+++ b/airflo... | [
{
"diff_hunk": "@@ -1566,36 +1567,41 @@ def chain(*tasks: Union[BaseOperator, Sequence[BaseOperator]]):\n t4.set_downstream(t6)\n t5.set_downstream(t6)\n \n- :param tasks: List of tasks or List[airflow.models.BaseOperator] to set dependencies\n- :type tasks: List[airflow.models.BaseOperato... | ce3db5239ff2e41414b5a3f7aaea163093b392eb | diff --git a/airflow/models/baseoperator.py b/airflow/models/baseoperator.py
index 17ad7a7057d7b..2949590dfa24a 100644
--- a/airflow/models/baseoperator.py
+++ b/airflow/models/baseoperator.py
@@ -74,6 +74,7 @@
from airflow.utils.weight_rule import WeightRule
if TYPE_CHECKING:
+ from airflow.models.xcom_arg impo... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
apache__airflow-16160@603d66f | apache/airflow | Python | 16,160 | Fix: GCS To BigQuery source_object | Fixes https://github.com/apache/airflow/issues/16008 GCS To BigQuery Operator's parameter `source_object` to accept both str and list
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
... | 2021-05-29T15:19:20Z | GoogleCloudStorageToBigQueryOperator reads string as a list in parameter source_objects
**Apache Airflow version**:1.10.12
**Environment**: google cloud composer
**What happened**:
When using GoogleCloudStorageToBigQueryOperator and providing string as parameter source_objects, the process is iterating on a the st... | Thanks for opening your first issue here! Be sure to follow the issue template!
`GoogleCloudStorageToBigQueryOperator` is deprecated. Please use `GCSToBigQueryOperator` from providers.
Note that `source_objects` expect `list` not `str`. You should set `source_objects = ['abc']`
@eladkal seems like the behaviour is th... | [
{
"body": "**Apache Airflow version**:1.10.12\r\n**Environment**: google cloud composer\r\n\r\n**What happened**:\r\nWhen using GoogleCloudStorageToBigQueryOperator and providing string as parameter source_objects, the process is iterating on a the string as a valid list.\r\nFor example - \r\n`cloud_storage_to_... | 2bca8a5425c234b04fdf32d6c50ae3a91cd08262 | {
"head_commit": "603d66f3c6b1d216eda8acefca51bf6cf2ee9d48",
"head_commit_message": "Fix: GCS To BigQuery source_object #16008\n\nFix GCS To BigQuery source_object to accept both str and list",
"patch_to_review": "diff --git a/airflow/providers/google/cloud/transfers/gcs_to_bigquery.py b/airflow/providers/google/... | [
{
"diff_hunk": "@@ -286,7 +286,7 @@ def execute(self, context):\n else:\n schema_fields = self.schema_fields\n \n- source_uris = [f'gs://{self.bucket}/{source_object}' for source_object in self.source_objects]\n+ source_uris = [f'gs://{self.bucket}/{source_object}' for source_o... | 07dad74e0a900ca253f7fd31f3221ac67c6ad0a5 | diff --git a/airflow/providers/google/cloud/transfers/gcs_to_bigquery.py b/airflow/providers/google/cloud/transfers/gcs_to_bigquery.py
index b9251100ed999..cef0d7157c9e6 100644
--- a/airflow/providers/google/cloud/transfers/gcs_to_bigquery.py
+++ b/airflow/providers/google/cloud/transfers/gcs_to_bigquery.py
@@ -42,9 +4... | {
"difficulty": "medium",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
apache__airflow-16080@ecc1272 | apache/airflow | Python | 16,080 | Configurable resources for git-sync sidecar | Add configurable resources for the `git-sync` sidecar.
closes: #16056
| 2021-05-26T08:17:49Z | [Helm] Resources for the git-sync sidecar
**Description**
It would be nice to be able to specify resources for the `git-sync` sidecar in the helm chart values.
**Use case / motivation**
I don't want to use keda for autoscaling and would like to setup a HPA myself. However this is currently not possible since i... | Thanks for opening your first issue here! Be sure to follow the issue template!
Go for it @CyberHippo | [
{
"body": "**Description**\r\n\r\nIt would be nice to be able to specify resources for the `git-sync` sidecar in the helm chart values.\r\n\r\n**Use case / motivation**\r\n\r\nI don't want to use keda for autoscaling and would like to setup a HPA myself. However this is currently not possible since it is not po... | 15b1243e8ce334e138430da14fb43312a76b3225 | {
"head_commit": "ecc1272d3fcd8502097983f4fb382b32d5fe67fd",
"head_commit_message": "Feat: configurable resources for git-sync sidecar",
"patch_to_review": "diff --git a/chart/templates/_helpers.yaml b/chart/templates/_helpers.yaml\nindex d8bae0bfe0135..ab1553d9f66eb 100644\n--- a/chart/templates/_helpers.yaml\n+... | [
{
"diff_hunk": "@@ -148,3 +148,29 @@ def test_should_add_env(self):\n assert {\"name\": \"FOO\", \"value\": \"bar\"} in jmespath.search(\n \"spec.template.spec.containers[1].env\", docs[0]\n )\n+\n+ def test_resources_are_configurable(self):\n+ docs = render_chart(\n+ ... | c452da739ec1650558a81dcc0dc89461ef694814 | diff --git a/chart/templates/_helpers.yaml b/chart/templates/_helpers.yaml
index d8bae0bfe0135..ab1553d9f66eb 100644
--- a/chart/templates/_helpers.yaml
+++ b/chart/templates/_helpers.yaml
@@ -193,6 +193,7 @@ If release name contains chart name it will be used as a full name.
- name: {{ $config.name }}
valu... | {
"difficulty": "low",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
apache__airflow-15680@e91d698 | apache/airflow | Python | 15,680 | MongoToS3Operator failed when running with a single query (not aggregate pipeline) | Remove invalid `allowDiskUse` argument when calling `find`. This method does not expect that argument according to official documentation [here](https://pymongo.readthedocs.io/en/stable/api/pymongo/collection.html?highlight=allowDiskUse#pymongo.collection.Collection.find).
closes #15679 | 2021-05-05T17:14:15Z | MongoToS3Operator failed when running with a single query (not aggregate pipeline)
**Apache Airflow version**: 2.0.2
**What happened**:
`MongoToS3Operator` failed when running with a single query (not aggregate pipeline):
```sh
Traceback (most recent call last):
File "/home/airflow//bin/airflow", line 8, i... | This seems related to https://github.com/apache/airflow/pull/12033
I'll take a look ASAP
There’s already a PR proposed in #15680 so please take a look at that as well. | [
{
"body": "**Apache Airflow version**: 2.0.2\r\n\r\n**What happened**:\r\n\r\n`MongoToS3Operator` failed when running with a single query (not aggregate pipeline):\r\n\r\n```sh\r\nTraceback (most recent call last):\r\n File \"/home/airflow//bin/airflow\", line 8, in <module>\r\n sys.exit(main())\r\n File \... | 30eeac7b7ed4ab5ea191691a3b713e3d66c0baff | {
"head_commit": "e91d6982695b033777d60afc2a65a9a900224136",
"head_commit_message": "Remove allowDiskUse argument from mongo hook find",
"patch_to_review": "diff --git a/airflow/providers/amazon/aws/transfers/mongo_to_s3.py b/airflow/providers/amazon/aws/transfers/mongo_to_s3.py\nindex f5dd7262e6ebf..9bd5a8f5fa11... | [
{
"diff_hunk": "@@ -49,8 +49,8 @@ class MongoToS3Operator(BaseOperator):\n :type mongo_db: str\n :param replace: whether or not to replace the file in S3 if it previously existed\n :type replace: bool\n- :param allow_disk_use: in the case you are retrieving a lot of data, you may have\n- t... | f6f4bca23669ef11e1e3533c7ae09939d3e32f5a | diff --git a/airflow/providers/amazon/aws/transfers/mongo_to_s3.py b/airflow/providers/amazon/aws/transfers/mongo_to_s3.py
index f5dd7262e6ebf..b88036d6fb160 100644
--- a/airflow/providers/amazon/aws/transfers/mongo_to_s3.py
+++ b/airflow/providers/amazon/aws/transfers/mongo_to_s3.py
@@ -40,7 +40,7 @@ class MongoToS3Op... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
apache__airflow-15454@3fed673 | apache/airflow | Python | 15,454 | Breeze should load local tmux configuration in 'breeze start-airflow' | closes #15416
---
**Description**
Currently, when we run
`
breeze start-airflow
`
**breeze** doesn't load local tmux configuration file **.tmux.conf** and we get default tmux configuration inside the containers.
**PR effect**
After this change developers will be able to put their **.tmux.conf** fil... | 2021-04-20T13:58:02Z | breeze should load local tmux configuration in 'breeze start-airflow'
**Description**
Currently, when we run
`
breeze start-airflow
`
**breeze** doesn't load local tmux configuration file **.tmux.conf** and we get default tmux configuration inside the containers.
**Use case / motivation**
Breeze must ... | SGTM. Can you submit a PR?
I wondered about this a while ago (mostly because I don’t want to repeatedly `set mouse on`). The problem is any slightly sophisticated local tmux setup would contain a lot of dependencies and it’s not realistic to pull them all into the container. So maybe a better approach would be have a d... | [
{
"body": "**Description**\r\n\r\nCurrently, when we run \r\n\r\n`\r\nbreeze start-airflow\r\n`\r\n\r\n**breeze** doesn't load local tmux configuration file **.tmux.conf** and we get default tmux configuration inside the containers.\r\n\r\n**Use case / motivation**\r\n\r\nBreeze must load local **tmux configura... | 9299f13b0f60fe641d17f1dc19fda17d1ef45c8b | {
"head_commit": "3fed6735bb23a635085cfbcdc7d16079c45a46dd",
"head_commit_message": "#15416 - Docs changed",
"patch_to_review": "diff --git a/BREEZE.rst b/BREEZE.rst\nindex 4916b4ef63faf..7e626935d279c 100644\n--- a/BREEZE.rst\n+++ b/BREEZE.rst\n@@ -258,11 +258,16 @@ You should set up the autocomplete option auto... | [
{
"diff_hunk": "@@ -48,3 +49,20 @@ else\n echo \"In it to make breeze source the variables automatically for you\"\n echo\n fi\n+\n+\n+if [[ -d \"${AIRFLOW_BREEZE_CONFIG_DIR}\" && \\\n+ -f \"${AIRFLOW_BREEZE_CONFIG_DIR}/${TMUX_CONF_FILE}\" ]]; then\n+ pushd \"${AIRFLOW_BREEZE_CONFIG_DIR}\" >/dev/n... | 9e13ab4358f405fa834f72ad5c3e243419db6602 | diff --git a/BREEZE.rst b/BREEZE.rst
index 4916b4ef63faf..ae0356e413ef6 100644
--- a/BREEZE.rst
+++ b/BREEZE.rst
@@ -258,11 +258,26 @@ You should set up the autocomplete option automatically by running:
You get the auto-completion working when you re-enter the shell.
+Customize your environment
+------------------... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
apache__airflow-15615@96e5451 | apache/airflow | Python | 15,615 | Feature qubole hook support headers | <!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
How to write a go... | 2021-04-30T18:35:56Z | Qubole Hook Does Not Support 'include_headers'
**Description**
Qubole Hook and Operator do not support `include_header` param for getting results with headers
Add Support for `include_header` get_results(... arguments=[True])
**Use case / motivation**
It's very hard to work with CSV results from db without ... | Thanks for opening your first issue here! Be sure to follow the issue template!
@levyitay assigned to you | [
{
"body": "\r\n\r\n**Description**\r\n\r\nQubole Hook and Operator do not support `include_header` param for getting results with headers\r\nAdd Support for `include_header` get_results(... arguments=[True])\r\n**Use case / motivation**\r\n\r\nIt's very hard to work with CSV results from db without headers. \r\... | d7a14a8925d16ab904215d9311bec799200e6814 | {
"head_commit": "96e5451352fc7f38973dcf94cae19a2d89fdf4cf",
"head_commit_message": "Added missing issue number",
"patch_to_review": "diff --git a/airflow/providers/qubole/CHANGELOG.rst b/airflow/providers/qubole/CHANGELOG.rst\nindex eac8d8e171110..3512f3d873380 100644\n--- a/airflow/providers/qubole/CHANGELOG.rs... | [
{
"diff_hunk": "@@ -250,9 +250,9 @@ def on_kill(self, ti=None) -> None:\n else:\n self.get_hook().kill(ti)\n \n- def get_results(self, ti=None, fp=None, inline: bool = True, delim=None, fetch: bool = True) -> str:\n+ def get_results(self, ti=None, fp=None, inline: bool = True, delim=No... | a53c82159f7e6da697c3c2309cbdbd8c540a304a | diff --git a/airflow/providers/qubole/CHANGELOG.rst b/airflow/providers/qubole/CHANGELOG.rst
index eac8d8e171110..3512f3d873380 100644
--- a/airflow/providers/qubole/CHANGELOG.rst
+++ b/airflow/providers/qubole/CHANGELOG.rst
@@ -19,6 +19,15 @@
Changelog
---------
+1.0.3
+.....
+
+Features
+~~~~~~~~
+
+* ``Feature ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
apache__airflow-15674@3842f8a | apache/airflow | Python | 15,674 | New UI: Add Timezone select | Add a timezone select dropdown to the new UI. Closes #14807
This is a frontend only toggle, it does not change any backend Airflow config.
Also includes a custom implementation of `react-select` that uses the Chakra theme and component library.
<img width="317" alt="Screen Shot 2021-05-05 at 11 34 39 AM" src="... | 2021-05-05T15:38:03Z | Design/build timezone switcher modal
- Once we have the current user's preference set and available in Context, add a modal that allows the preferred display timezone to be changed.
- Modal will be triggered by clicking the time/TZ in the global navigation. | [
{
"body": "- Once we have the current user's preference set and available in Context, add a modal that allows the preferred display timezone to be changed.\r\n- Modal will be triggered by clicking the time/TZ in the global navigation.",
"number": 14807,
"title": "Design/build timezone switcher modal"
... | 13faa6912f7cd927737a1dc15630d3bbaf2f5d4d | {
"head_commit": "3842f8afc65d95cc1db46fdd966f465972e876a0",
"head_commit_message": "check if timezone exists in a group",
"patch_to_review": "diff --git a/airflow/ui/package.json b/airflow/ui/package.json\nindex 8788aa2f25425..011a3032dde93 100644\n--- a/airflow/ui/package.json\n+++ b/airflow/ui/package.json\n@@... | [
{
"diff_hunk": "@@ -0,0 +1,88 @@\n+/*!\n+ * Licensed to the Apache Software Foundation (ASF) under one\n+ * or more contributor license agreements. See the NOTICE file\n+ * distributed with this work for additional information\n+ * regarding copyright ownership. The ASF licenses this file\n+ * to you under th... | 7a13877926243b54e319f49523859ed3b21c5310 | diff --git a/airflow/ui/package.json b/airflow/ui/package.json
index 8788aa2f25425..d7e7857b53892 100644
--- a/airflow/ui/package.json
+++ b/airflow/ui/package.json
@@ -9,10 +9,11 @@
"lint": "eslint --format codeframe --ext mjs,jsx,js,tsx,ts src test && tsc"
},
"dependencies": {
- "@chakra-ui/react": "^1.... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
apache__airflow-15290@3d02084 | apache/airflow | Python | 15,290 | Rename nteract-scrapbook to scrapbook | <!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
r... | 2021-04-08T20:03:51Z | reporting deprecated warnings saw in breeze
when working with breeze I saw these warnings many times in the logs:
```
=============================== warnings summary ===============================
tests/providers/amazon/aws/log/test_cloudwatch_task_handler.py::TestCloudwatchTaskHandler::test_close_prevents_d... | [
{
"body": "when working with breeze I saw these warnings many times in the logs:\r\n\r\n ```\r\n =============================== warnings summary ===============================\r\n tests/providers/amazon/aws/log/test_cloudwatch_task_handler.py::TestCloudwatchTaskHandler::test_close_prevents_duplicate_calls\r\... | f62e68e989a0f0fbd29d141c48e35307a872df0d | {
"head_commit": "3d02084cbe0176cd075216b685ce56ebb0f6c1bc",
"head_commit_message": "Rename nteract-scrapbook to scrapbook",
"patch_to_review": "diff --git a/setup.py b/setup.py\nindex 9441b6bdd96ff..9ad48c4c13efa 100644\n--- a/setup.py\n+++ b/setup.py\n@@ -384,8 +384,8 @@ def get_sphinx_theme_version() -> str:\n... | [
{
"diff_hunk": "@@ -384,8 +384,8 @@ def get_sphinx_theme_version() -> str:\n 'pdpyras>=4.1.2,<5',\n ]\n papermill = [\n- 'nteract-scrapbook[all]>=0.3.1',\n 'papermill[all]>=1.2.1',\n+ 'scrapbook[all]>=0.3.1',",
"line": null,
"original_line": 388,
"original_start_line": null,
"path"... | ac201cf3dc35380589de2b86614a3635b84d0abb | diff --git a/setup.py b/setup.py
index 9441b6bdd96ff..4c87cd6cbc50a 100644
--- a/setup.py
+++ b/setup.py
@@ -384,8 +384,8 @@ def get_sphinx_theme_version() -> str:
'pdpyras>=4.1.2,<5',
]
papermill = [
- 'nteract-scrapbook[all]>=0.3.1',
'papermill[all]>=1.2.1',
+ 'scrapbook[all]',
]
password = [
... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "Dependency Updates & Env Compatibility"
} | |
apache__airflow-14836@e9f6cb4 | apache/airflow | Python | 14,836 | Pre commit new UI | Add pre-commit hook to lint and test the new react UI.
Closes #14726
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Impr... | 2021-03-16T15:59:01Z | Add precommit linting and testing to the new /ui
**Description**
We just initialized the new UI for AIP-38 under `/airflow/ui`. To continue development, it would be best to add a pre-commit hook to run the linting and testing commands for the new project.
**Use case / motivation**
The new UI already has lintin... | Thanks for opening your first issue here! Be sure to follow the issue template! | [
{
"body": "**Description**\r\n\r\nWe just initialized the new UI for AIP-38 under `/airflow/ui`. To continue development, it would be best to add a pre-commit hook to run the linting and testing commands for the new project.\r\n\r\n**Use case / motivation**\r\n\r\nThe new UI already has linting and testing setu... | 9cb6553935c247fbfe23c7584dd4d9f579c6bf55 | {
"head_commit": "e9f6cb49aa88a1f3541907d4cb3f6d2b99e0e35d",
"head_commit_message": "move pre-commit back to main repo config",
"patch_to_review": "diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml\nindex e586c8ce34edf..ce3407e004d9a 100644\n--- a/.pre-commit-config.yaml\n+++ b/.pre-commit-config.yam... | [
{
"diff_hunk": "@@ -563,6 +563,10 @@ repos:\n language_version: python3\n additional_dependencies: ['flynt']\n files: \\.py$\n+ - id: ui-lint-test\n+ name: Lint and test React UI\n+ language: system\n+ entry: ./scripts/ci/pre_commit/pre_commit_ui_lint_test.sh",
... | 32360c6fe32f4905f88b3b2495f01db3631b97a3 | diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
index e586c8ce34edf..176d466696eee 100644
--- a/.pre-commit-config.yaml
+++ b/.pre-commit-config.yaml
@@ -563,6 +563,18 @@ repos:
language_version: python3
additional_dependencies: ['flynt']
files: \.py$
+ - id: ui-lint
+ ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Test Suite / CI Enhancements"
} |
apache__airflow-15250@ecf6a46 | apache/airflow | Python | 15,250 | #15245 - passing custom image family name to the DataProcClusterCreateoperator | Closes: #15245
This is my first PR. I tried to follow the CONTRIBUTING guide step by step. It passed all the pre-commit tests.
My PR adds a new argument to **DataprocCreateClusterOperator** which allows user to pass **custom image family** while creating **GCP DataProc** cluster. any advice or suggestions are w... | 2021-04-07T11:32:45Z | Passing Custom Image Family Name to the DataprocClusterCreateOperator()
**Description**
Currently, we can only pass custom Image name to **DataprocClusterCreateOperator(),**
as the custom image expires after 60 days, we either need to update the image or we need to pass the expiration token.
Functionality is alre... | Thanks for opening your first issue here! Be sure to follow the issue template!
I will work on this, please let me know any suggestions or comments.
There is workaround to this, we can just pass **family/<family_name>** in custom_image parameter to DataprocClusterCreateOperator(), taking advantage of because the way *... | [
{
"body": "**Description**\r\nCurrently, we can only pass custom Image name to **DataprocClusterCreateOperator(),**\r\nas the custom image expires after 60 days, we either need to update the image or we need to pass the expiration token.\r\n\r\nFunctionality is already available in **gcloud** and **REST**.\r\n... | 99ec208024933d790272a09a6f20b241410a7df7 | {
"head_commit": "ecf6a4655fdc9e1457ce54df5e0ff9b1ad01253e",
"head_commit_message": "[Airflow-15245] - sanity check added for image_version and custom_image_family.",
"patch_to_review": "diff --git a/airflow/providers/google/cloud/operators/dataproc.py b/airflow/providers/google/cloud/operators/dataproc.py\nindex... | [
{
"diff_hunk": "@@ -346,6 +358,16 @@ def _build_cluster_data(self):\n if not self.single_node:\n cluster_data['worker_config']['image_uri'] = custom_image_url\n \n+ elif self.custom_image_family:\n+ project_id = self.custom_image_project_id or self.project_id\n+ ... | 2f1045468615b8458fce1657bc285f24dff174e8 | diff --git a/airflow/providers/google/cloud/operators/dataproc.py b/airflow/providers/google/cloud/operators/dataproc.py
index d578565b06526..39fe40ca2a937 100644
--- a/airflow/providers/google/cloud/operators/dataproc.py
+++ b/airflow/providers/google/cloud/operators/dataproc.py
@@ -75,6 +75,10 @@ class ClusterGenerat... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
apache__airflow-14191@30cc953 | apache/airflow | Python | 14,191 | Add new operator gdrive to local | I have added new operator, but I noticed that there are no return value in execute function. I understand that this is not finished version, but I need help and review and what can be next step.
closes: #10126
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. An... | 2021-02-11T14:31:04Z | Add download function at gdrive hook
**Description**
Right now the GoogleDriveHook class from: airflow/airflow/providers/google/suite/hooks/drive.py has only a upload function, it would be nice if a download function was also provided.
**Use case / motivation**
This is useful for example if a lot of data is ke... | Thanks for opening your first issue here! Be sure to follow the issue template!
@SaladBreaker would you like to implement it? I'm happy to help with it, let me know if you need any guidance 🚀
Thanks, I'll try it.
any update on this?
Hello, can I implement this feature?
@Scuall1992 assigned to you.
Just mentioning t... | [
{
"body": "**Description**\r\n\r\nRight now the GoogleDriveHook class from: airflow/airflow/providers/google/suite/hooks/drive.py has only a upload function, it would be nice if a download function was also provided.\r\n\r\n**Use case / motivation**\r\n\r\nThis is useful for example if a lot of data is keep in ... | cb4a60e9d059eeeae02909bb56a348272a55c233 | {
"head_commit": "30cc95344db65274df218a39b8f21e720cad5323",
"head_commit_message": "Add gdrive to local test",
"patch_to_review": "diff --git a/airflow/providers/google/cloud/example_dags/example_gdrive_to_local.py b/airflow/providers/google/cloud/example_dags/example_gdrive_to_local.py\nnew file mode 100644\nin... | [
{
"diff_hunk": "@@ -0,0 +1,38 @@\n+#\n+# Licensed to the Apache Software Foundation (ASF) under one\n+# or more contributor license agreements. See the NOTICE file\n+# distributed with this work for additional information\n+# regarding copyright ownership. The ASF licenses this file\n+# to you under the Apach... | 5517e7314b11d7bbb0da1f1df469829dc2740b80 | diff --git a/airflow/providers/google/cloud/example_dags/example_gdrive_to_local.py b/airflow/providers/google/cloud/example_dags/example_gdrive_to_local.py
new file mode 100644
index 0000000000000..94fca91105231
--- /dev/null
+++ b/airflow/providers/google/cloud/example_dags/example_gdrive_to_local.py
@@ -0,0 +1,49 @@... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
apache__airflow-14400@5aa90dd | apache/airflow | Python | 14,400 | Add conf not importable from airflow rule | This rule checks to ensure user properly imports "conf" to be compatible with Airflow 2.0
closes: https://github.com/apache/airflow/issues/13945
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the do... | 2021-02-23T20:20:51Z | Add conf not importable from airflow rule
**Description**
A new rule should be added to Airflow upgrade check to verify that users import `conf` from proper place and their code will work with 2.0.
**Use case / motivation**
In 1.10 users can do:
```py
In [1]: from airflow import conf
In [2]: conf
Out[2... | Hey @turbaszek, I am interested in making a PR for this.
I see you tagged this with good first issue. I am still a novice when it comes to airflow, so if you could help me with the review I think we can accomplish this together.
hey @turbaszek, struggling to get started with this PR. Could you elaborate more on "Airf... | [
{
"body": "**Description**\r\n\r\nA new rule should be added to Airflow upgrade check to verify that users import `conf` from proper place and their code will work with 2.0.\r\n\r\n**Use case / motivation**\r\n\r\nIn 1.10 users can do:\r\n\r\n```py\r\nIn [1]: from airflow import conf\r\n\r\nIn [2]: conf\r\nOut[... | e6475938727941f24926c0d85f4d03a2b7064f2a | {
"head_commit": "5aa90dd71b82f86d1c1fd05296956a7f7f50ce58",
"head_commit_message": "Add conf not importable from airflow rule #13945",
"patch_to_review": "diff --git a/airflow/upgrade/rules/fix_conf_not_importable_from_airflow.py b/airflow/upgrade/rules/fix_conf_not_importable_from_airflow.py\nnew file mode 1006... | [
{
"diff_hunk": "@@ -0,0 +1,64 @@\n+\n+# Licensed to the Apache Software Foundation (ASF) under one\n+# or more contributor license agreements. See the NOTICE file\n+# distributed with this work for additional information\n+# regarding copyright ownership. The ASF licenses this file\n+# to you under the Apache... | e7e2affa2cdb3db6ae79028da5d6e84bb715d8e6 | diff --git a/airflow/upgrade/rules/fix_conf_not_importable_from_airflow.py b/airflow/upgrade/rules/fix_conf_not_importable_from_airflow.py
new file mode 100644
index 0000000000000..88dd41f089071
--- /dev/null
+++ b/airflow/upgrade/rules/fix_conf_not_importable_from_airflow.py
@@ -0,0 +1,60 @@
+# Licensed to the Apache ... | {
"difficulty": "medium",
"estimated_review_effort": 2,
"problem_domain": "New Feature Additions"
} |
apache__airflow-14323@a7cf76c | apache/airflow | Python | 14,323 | Scheduler should not fail when invalid executor_config is passed | closes https://github.com/apache/airflow/issues/14182
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, refe... | 2021-02-19T21:12:16Z | Scheduler dies if executor_config isnt passed a dict when using K8s executor
**Apache Airflow version**: 2.0.1
**Kubernetes version (if you are using kubernetes)** (use `kubectl version`): 1.15
**Environment**:
- **Cloud provider or hardware configuration**: k8s on bare metal
- **OS** (e.g. from /etc/os-rel... | Hi @fjmacagno so if I'm understanding the issue: rather than killing the entire scheduler when this happens, a better result would be for this to return a task failure with the error upon run?
@kaxil @jhtimmins @ephraimbuddy this would be a good start k8sexecutor bug if you're interested. Glad to help you find the s... | [
{
"body": "**Apache Airflow version**: 2.0.1\r\n\r\n\r\n**Kubernetes version (if you are using kubernetes)** (use `kubectl version`): 1.15\r\n\r\n**Environment**:\r\n\r\n- **Cloud provider or hardware configuration**: k8s on bare metal\r\n- **OS** (e.g. from /etc/os-release): \r\n- **Kernel** (e.g. `uname -a`):... | 5061077dc31c967d2c1c6bcded626096f5b6e940 | {
"head_commit": "a7cf76c57f244d07d67788b0b8b9308744877952",
"head_commit_message": "Scheduler should not fail when invalid executor_config is passed\n\ncloses https://github.com/apache/airflow/issues/14182",
"patch_to_review": "diff --git a/airflow/executors/kubernetes_executor.py b/airflow/executors/kubernetes_... | [
{
"diff_hunk": "@@ -490,7 +490,13 @@ def execute_async(\n ) -> None:\n \"\"\"Executes task asynchronously\"\"\"\n self.log.info('Add task %s with command %s with executor_config %s', key, command, executor_config)\n- kube_executor_config = PodGenerator.from_obj(executor_config)\n+ ... | 09eac354b4518fb849951781600929f345516979 | diff --git a/airflow/executors/kubernetes_executor.py b/airflow/executors/kubernetes_executor.py
index 88e26be885932..fd5c6faca2278 100644
--- a/airflow/executors/kubernetes_executor.py
+++ b/airflow/executors/kubernetes_executor.py
@@ -490,7 +490,13 @@ def execute_async(
) -> None:
"""Executes task async... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
apache__airflow-13990@82e1e8b | apache/airflow | Python | 13,990 | Fix the AttributeError with text field in TelegramOperator | closes: #13989 | 2021-01-30T19:26:45Z | AttributeError: 'TelegramOperator' object has no attribute 'text'
Hi there 👋
I was playing with the **TelegramOperator** and stumbled upon a bug with the `text` field. It is supposed to be a template field but in reality the instance of the **TelegramOperator** does not have this attribute thus every time I try to ... | [
{
"body": "Hi there 👋\r\n\r\nI was playing with the **TelegramOperator** and stumbled upon a bug with the `text` field. It is supposed to be a template field but in reality the instance of the **TelegramOperator** does not have this attribute thus every time I try to execute code I get the error:\r\n\r\n> Attr... | 25d68a7a9e0b4481486552ece9e77bcaabfa4de2 | {
"head_commit": "82e1e8bba076302df536de6c22d532a046b89189",
"head_commit_message": "Fix the AttributeError with text field \n\ntext now is a template field",
"patch_to_review": "diff --git a/airflow/providers/telegram/operators/telegram.py b/airflow/providers/telegram/operators/telegram.py\nindex ae01be8434013..... | [
{
"diff_hunk": "@@ -63,9 +63,10 @@ def __init__(\n self.chat_id = chat_id\n self.token = token\n self.telegram_kwargs = telegram_kwargs or {}\n+ self.text = text\n \n- if text is not None:\n- self.telegram_kwargs['text'] = text\n+ if self.text is not None:... | 705868334bc4c2f72f3f56263aaac0a346b6e83e | diff --git a/airflow/providers/telegram/operators/telegram.py b/airflow/providers/telegram/operators/telegram.py
index ae01be8434013..113a3e4ed56a9 100644
--- a/airflow/providers/telegram/operators/telegram.py
+++ b/airflow/providers/telegram/operators/telegram.py
@@ -63,9 +63,7 @@ def __init__(
self.chat_id =... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} | |
apache__airflow-13773@459d363 | apache/airflow | Python | 13,773 | add acl_policy to S3CopyObjectOperator | resolves https://github.com/apache/airflow/issues/13774 | 2021-01-19T21:51:26Z | add acl_policy to S3CopyObjectOperator
<!--
Welcome to Apache Airflow! For a smooth issue process, try to answer the following questions.
Don't worry if they're not all applicable; just try to include what you can :-)
If you need to include code snippets or logs, please put them in fenced code
blocks. If they... | [
{
"body": "<!--\r\n\r\nWelcome to Apache Airflow! For a smooth issue process, try to answer the following questions.\r\nDon't worry if they're not all applicable; just try to include what you can :-)\r\n\r\nIf you need to include code snippets or logs, please put them in fenced code\r\nblocks. If they're supe... | 18d9320c2619dc569485a29fc71a62c26d29b3c9 | {
"head_commit": "459d363da32c65ca30200ee8f2c4f2c71e98ba7a",
"head_commit_message": "add acl_policy to S3CopyObjectOperator",
"patch_to_review": "diff --git a/airflow/providers/amazon/aws/operators/s3_copy_object.py b/airflow/providers/amazon/aws/operators/s3_copy_object.py\nindex 052c9adfb1b3f..841bf7feddbf2 100... | [
{
"diff_hunk": "@@ -89,6 +92,7 @@ def __init__(\n self.source_version_id = source_version_id\n self.aws_conn_id = aws_conn_id\n self.verify = verify\n+ self.acl_policy acl_policy",
"line": null,
"original_line": 95,
"original_start_line": null,
"path": "airflow/pro... | d3780925fed02b6b955ae5ed81b4ea9b417a89c6 | diff --git a/airflow/providers/amazon/aws/operators/s3_copy_object.py b/airflow/providers/amazon/aws/operators/s3_copy_object.py
index 052c9adfb1b3f..48bc52bc194ff 100644
--- a/airflow/providers/amazon/aws/operators/s3_copy_object.py
+++ b/airflow/providers/amazon/aws/operators/s3_copy_object.py
@@ -63,6 +63,9 @@ class... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "New Feature Additions"
} | |
apache__airflow-12905@16a9fb6 | apache/airflow | Python | 12,905 | Make xcom_pull results order deterministic | closes https://github.com/apache/airflow/issues/11858
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, refe... | 2020-12-08T02:21:32Z | Xcom_pull results order is not deterministic
For xcoms pushed from different tasks, having the same execution_date and in the same Dag, the result of the xcom_pull with key set as None is not deterministic in its order
**Apache Airflow version**: 2.0
**Kubernetes version (if you are using kubernetes)** (use `ku... | Hmm, can you elaborate more on this @ephraimbuddy . For example if the XCom hasn't been pushed yet, you will get None. So the order of task that pushes XCom value does matter
This example dag below gives inconsistent results:
```
#
# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor... | [
{
"body": "For xcoms pushed from different tasks, having the same execution_date and in the same Dag, the result of the xcom_pull with key set as None is not deterministic in its order\r\n\r\n**Apache Airflow version**: 2.0\r\n\r\n\r\n**Kubernetes version (if you are using kubernetes)** (use `kubectl version`):... | 5e0a2d772b2b095de277bedcaafce8dd98805d48 | {
"head_commit": "16a9fb608c478c74c66331e56543e17eed74bfce",
"head_commit_message": "Make Xcom_pull results order deterministic\n\ncloses https://github.com/apache/airflow/issues/11858",
"patch_to_review": "diff --git a/airflow/models/taskinstance.py b/airflow/models/taskinstance.py\nindex 82bfc6647734f..da646094... | [
{
"diff_hunk": "@@ -1883,16 +1883,24 @@ def xcom_pull( # pylint: disable=inconsistent-return-statements\n task_ids=task_ids,\n include_prior_dates=include_prior_dates,\n session=session,\n- ).with_entities(XCom.value)\n+ )\n \n # Since we're only fetchi... | 499765930bf0f82f7e19edd339889f2467797cda | diff --git a/airflow/models/taskinstance.py b/airflow/models/taskinstance.py
index 82bfc6647734f..f8d126e44b69f 100644
--- a/airflow/models/taskinstance.py
+++ b/airflow/models/taskinstance.py
@@ -1883,16 +1883,21 @@ def xcom_pull( # pylint: disable=inconsistent-return-statements
task_ids=task_ids,
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
apache__airflow-13297@9615040 | apache/airflow | Python | 13,297 | Use DAG context manager in examples (#12894) | closes: #12894
Please let me know if I need to make any changes!
| 2020-12-24T04:00:15Z | Use DAG context in dag examples
The current code of dag examples is in the form of:
```
dag = DAG(whatever)
task_1 = Operator(task_id='dfsa',
dag=dag)
```
As it is said in the docs (or in some article written by a commiter somewhere) it is better to have:
`with DAG(whatever):
... | I have some time now, I could work on this.
@jmelot assigned to you | [
{
"body": "The current code of dag examples is in the form of:\r\n```\r\ndag = DAG(whatever)\r\n\r\ntask_1 = Operator(task_id='dfsa', \r\n dag=dag)\r\n```\r\n\r\nAs it is said in the docs (or in some article written by a commiter somewhere) it is better to have:\r\n`with DAG(whatev... | d4c4492a10f5e269f80067b724aa2c345bf97ee0 | {
"head_commit": "96150401c1344e818d91084da057824afd630781",
"head_commit_message": "Add dedent to improve alignment of example dags in documentation (#12894)",
"patch_to_review": "diff --git a/airflow/example_dags/example_bash_operator.py b/airflow/example_dags/example_bash_operator.py\nindex 1c22fff546451..d66b... | [
{
"diff_hunk": "@@ -99,32 +99,32 @@ def load(**kwargs):\n python_callable=extract,\n )\n extract_task.doc_md = \"\"\"\\",
"line": null,
"original_line": 101,
"original_start_line": null,
"path": "airflow/example_dags/tutorial_etl_dag.py",
"start_line": null,
"text": "@use... | 1db1710a02ca51498ff9adf6b7a9b6a459570e05 | diff --git a/airflow/example_dags/example_bash_operator.py b/airflow/example_dags/example_bash_operator.py
index 1c22fff546451..0665971db2847 100644
--- a/airflow/example_dags/example_bash_operator.py
+++ b/airflow/example_dags/example_bash_operator.py
@@ -29,7 +29,7 @@
'owner': 'airflow',
}
-dag = DAG(
+with D... | {
"difficulty": "low",
"estimated_review_effort": 3,
"problem_domain": "Code Refactoring / Architectural Improvement"
} |
apache__airflow-11964@caa8c38 | apache/airflow | Python | 11,964 | Add new datetime branch operator | closes: #11929
This PR includes a new datetime branching operator: the current date and time, as given by `datetime.datetime.now` is compared against target `datetime` attributes, like `year` or `hour`, to decide which task id branch to take.
No tests were written yet as this is intended as a POC to allow us to ... | 2020-10-30T08:57:40Z | add DateTimeBranchOperator
**Use case / motivation**
Airflow have `BranchSQLOperator` and `BranchPythonOperator`.
Airflow also have `DateTimeSensor`.
I find it very useful to have `DateTimeBranchOperator` that will allow to branch workflow based on specific DateTime
Sometimes in DAGs you want to do another se... | Hello 👋
I've been using Airflow for a while now and would love to get involved with the project and contribute some code. If nobody's working on this I'd like to open a PR. Just wanted to clarify a few questions:
* Should `DateTimeBranchOperator` support comparisons with partial dates? For example: branching ba... | [
{
"body": "\r\n**Use case / motivation**\r\n\r\nAirflow have `BranchSQLOperator` and `BranchPythonOperator`.\r\nAirflow also have `DateTimeSensor`.\r\n\r\nI find it very useful to have `DateTimeBranchOperator` that will allow to branch workflow based on specific DateTime\r\nSometimes in DAGs you want to do anot... | 91edde6b00a44888827e129f8e8bba2484f88a2e | {
"head_commit": "caa8c38a94c42b9ed6a2ea8f1f8c50a3baad61b2",
"head_commit_message": "Update example dag description",
"patch_to_review": "diff --git a/airflow/example_dags/example_datetime_branch_operator.py b/airflow/example_dags/example_datetime_branch_operator.py\nnew file mode 100644\nindex 0000000000000..58b... | [
{
"diff_hunk": "@@ -0,0 +1,101 @@\n+# Licensed to the Apache Software Foundation (ASF) under one\n+# or more contributor license agreements. See the NOTICE file\n+# distributed with this work for additional information\n+# regarding copyright ownership. The ASF licenses this file\n+# to you under the Apache L... | 8253b4a895b1334e5423e6551c89c52bacbc56f4 | diff --git a/airflow/example_dags/example_datetime_branch_operator.py b/airflow/example_dags/example_datetime_branch_operator.py
new file mode 100644
index 0000000000000..58b1a0a5fc579
--- /dev/null
+++ b/airflow/example_dags/example_datetime_branch_operator.py
@@ -0,0 +1,83 @@
+#
+# Licensed to the Apache Software Fou... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
apache__airflow-11802@630f69d | apache/airflow | Python | 11,802 | Add Kubernetes cleanup-pods CLI command for Helm Chart | closes: https://github.com/apache/airflow/issues/11146
Adds a CLI command `airflow kubernetes cleanup-pods --namespace NAMESPACE`
to Clean up Kubernetes pods in evicted/failed/succeeded states for the Helm Chart
cc @alikhtag
<!--
Thank you for contributing! Please make sure that your code changes
are cover... | 2020-10-24T00:24:38Z | Cleanup CronJob fails
**Apache Airflow version**: 1.10.12
**Kubernetes version** : 1.17.9
**Environment**:
- **Cloud provider or hardware configuration**: Azure Kubernetes Service
- **OS** (e.g. from /etc/os-release): Linux
- **Install tools**: Helm chart (/chart in repo)
- **Others**:
**What happened**... | Thanks for opening your first issue here! Be sure to follow the issue template!
Found something in `github`, I assume these scripts were not migrated when `Helm` chart was donated by `Astronomer` ?
https://github.com/astronomer/astronomer-airflow-scripts
Is it possible to add them? If not, then this `CronJob` may h... | [
{
"body": "**Apache Airflow version**: 1.10.12\r\n\r\n**Kubernetes version** : 1.17.9\r\n\r\n**Environment**:\r\n\r\n- **Cloud provider or hardware configuration**: Azure Kubernetes Service\r\n- **OS** (e.g. from /etc/os-release): Linux\r\n- **Install tools**: Helm chart (/chart in repo) \r\n- **Others**:\r\n\r... | 081ba616ada089bd2a2de72a77fbb57c0a2a7557 | {
"head_commit": "630f69db5089e8106593b4dfc05879c34d450d49",
"head_commit_message": "Add Kubernetes cleanup-pods CLI command for Helm Chart\n\ncloses: https://github.com/apache/airflow/issues/11146\n\nAdds a CLI command `airflow kubernetes cleanup-pods --namespace NAMESPACE`\nto Clean up Kubernetes pods in evicted/... | [
{
"diff_hunk": "@@ -61,3 +63,64 @@ def generate_pod_yaml(args):\n sanitized_pod = api_client.sanitize_for_serialization(pod)\n output.write(yaml.dump(sanitized_pod))\n print(f\"YAML output can be found at {yaml_output_path}/airflow_yaml_output/\")\n+\n+\n+@cli_utils.action_logging\n+... | 5e4a0785ea10d2cb9295423959e53f91b8a5469d | diff --git a/airflow/cli/cli_parser.py b/airflow/cli/cli_parser.py
index aa4d3b6eb6993..842b23233a0b0 100644
--- a/airflow/cli/cli_parser.py
+++ b/airflow/cli/cli_parser.py
@@ -759,6 +759,12 @@ def positive_int(value):
help="The option name",
)
+# kubernetes cleanup-pods
+ARG_NAMESPACE = Arg(
+ ("--namespace... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
apache__airflow-19729@056a4c8 | apache/airflow | Python | 19,729 | Local kubernetes executor | LocalKubernetesExecutor similar to CeleryKubernetesExecutor.
Tested by running webserver, scheduler and connecting to minikube k8s cluster.
Note: This PR does not update the helm charts.
closes: #16185
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case o... | 2021-11-21T03:52:12Z | Combined Executor - KubernetesExecutor + LocalExecutor
**Description**
In short: There exists already combined executor support for Celery + Kubernetes, I think that also adding Local + Kubernetes
would be warmly welcomed.
**Use case / motivation**
Many tasks are low-resource intensive tasks on the airflow pod,... | Thanks for opening your first issue here! Be sure to follow the issue template!
Worth looking at creating it !
@potiuk Can I grab this issue? If yes, where I can start looking?
Take a look at ``CeleryKubernetesExecutor``. Although this one would require a little more intrinsic knowledge of Airflow - so please take a ... | [
{
"body": "**Description**\r\nIn short: There exists already combined executor support for Celery + Kubernetes, I think that also adding Local + Kubernetes\r\nwould be warmly welcomed.\r\n\r\n**Use case / motivation**\r\n\r\nMany tasks are low-resource intensive tasks on the airflow pod, It makes sense to keep ... | 43907e9192fe7a658209238de2c3fdf919f7ced4 | {
"head_commit": "056a4c8dbc36a7a567eb64d6e71bc9ffd84c143c",
"head_commit_message": "[16185] Added LocalKubernetesExecutor to breeze supported executors",
"patch_to_review": "diff --git a/airflow/config_templates/config.yml b/airflow/config_templates/config.yml\nindex 0e56875738a5c..253f5bcf3fa22 100644\n--- a/ai... | [
{
"diff_hunk": "@@ -0,0 +1,30 @@\n+ .. Licensed to the Apache Software Foundation (ASF) under one\n+ or more contributor license agreements. See the NOTICE file\n+ distributed with this work for additional information\n+ regarding copyright ownership. The ASF licenses this file\n+ to you under the... | 3c95d568aa3dc969e014b9a9c8bbfd980152f024 | diff --git a/BREEZE.rst b/BREEZE.rst
index 3fa459f218130..dacc1b60c4a21 100644
--- a/BREEZE.rst
+++ b/BREEZE.rst
@@ -2469,6 +2469,7 @@ This is the current syntax for `./breeze <./breeze>`_:
One of:
KubernetesExecutor CeleryExecutor LocalExecutor CeleryKubernetesExecutor
+ ... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
apache__airflow-17236@7f5e66d | apache/airflow | Python | 17,236 | [Airflow 16364] Add conn_timeout and cmd_timeout params to SSHOperator; add conn_timeout param to SSHHook | closes #16364 (Timeout is ambiguous in SSHHook and SSHOperator)
Add conn_timeout and cmd_timeout params to SSHOperator. Add conn_timeout param to SSHHook. The legacy timeout param remains but is marked as deprecated. The new params take precedence over the legacy timeout one if both/all are provided.
---
Read th... | 2021-07-26T17:47:17Z | Timeout is ambiguous in SSHHook and SSHOperator
In SSHHook the timeout argument of the constructor is used to set a connection timeout. This is fine.
But in SSHOperator the timeout argument of the constructor is used for *both* the timeout of the SSHHook *and* the timeout of the command itself (see paramiko's ssh cl... | I feel Option 2 is clearer regardless, since it is still quite confusing if `SSHHook(timeout=...)` and `SSHOperator(timeout=...)` mean two different things. It’s probably better to be explicit about what the timeout is for:
1. Create `conn_timeout` and pass it to `SSHCHook(timeout)`.
2. Create `cmd_timeout` for the... | [
{
"body": "In SSHHook the timeout argument of the constructor is used to set a connection timeout. This is fine.\r\n\r\nBut in SSHOperator the timeout argument of the constructor is used for *both* the timeout of the SSHHook *and* the timeout of the command itself (see paramiko's ssh client exec_command use of ... | 6acb9e1ac1dd7705d9bfcfd9810451dbb549af97 | {
"head_commit": "7f5e66d619541ad27fbbcff2be553be2d78d56e7",
"head_commit_message": "Merge branch 'apache:main' into airflow-16364",
"patch_to_review": "diff --git a/airflow/providers/ssh/hooks/ssh.py b/airflow/providers/ssh/hooks/ssh.py\nindex a8994bdece1b7..5f9c637b9d18b 100644\n--- a/airflow/providers/ssh/hook... | [
{
"diff_hunk": "@@ -56,8 +56,10 @@ class SSHHook(BaseHook):\n :type key_file: str\n :param port: port of remote host to connect (Default is paramiko SSH_PORT)\n :type port: int\n- :param timeout: timeout for the attempt to connect to the remote_host.\n+ :param timeout: (Deprecated). timeout fo... | 99bcf65680dbdad9081d34f8b79f380292beebea | diff --git a/airflow/providers/ssh/hooks/ssh.py b/airflow/providers/ssh/hooks/ssh.py
index a8994bdece1b7..eda5990288290 100644
--- a/airflow/providers/ssh/hooks/ssh.py
+++ b/airflow/providers/ssh/hooks/ssh.py
@@ -34,6 +34,8 @@
except ImportError:
from getpass import getuser
+TIMEOUT_DEFAULT = 10
+
class SSHH... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Code Refactoring / Architectural Improvement"
} |
apache__airflow-9631@b7d3c97 | apache/airflow | Python | 9,631 | Add function to get current context | Support for getting current context at any codelocation that runs under the scope of BaseOperator.execute function. This functionality is part of AIP-31
closes: #8058
Work based on @jonathanshir PR #8651
---
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides contex... | 2020-07-02T14:56:21Z | [AIP-31] Add lazy way to get Airflow context from a wrapped function
**Description**
Currently the only way to access the context object from a PythonOperator wrapped function is by setting `provide_context=True` in the Operator. That loads it into the kwargs. This makes the signature of the function become difficul... | Just a comment, provide_context is no longer requires in Master: https://github.com/apache/airflow/pull/5990/files/a5d99ed3f3c7b1a815bd2617d3b935bed499f3f7
I see, I still think we should implement this lazy resolved context. Using the current approach from master means that signatures can mismatch op_args/op_kwargs and... | [
{
"body": "**Description**\r\n\r\nCurrently the only way to access the context object from a PythonOperator wrapped function is by setting `provide_context=True` in the Operator. That loads it into the kwargs. This makes the signature of the function become difficult to argue about.\r\n\r\nAdding a way to lazy ... | 496ed6f1b279dc5ca560dec0044c8373531565f4 | {
"head_commit": "b7d3c977f35ec2d2821845f8a904145744a91a40",
"head_commit_message": "Add function to get current context\n\nSupport for getting current context at any codelocation that runs\nunder the scope of BaseOperator.execute function. This functionality\nis part of AIP-31",
"patch_to_review": "diff --git a/... | [
{
"diff_hunk": "@@ -0,0 +1,69 @@\n+# Licensed to the Apache Software Foundation (ASF) under one",
"line": null,
"original_line": 1,
"original_start_line": null,
"path": "airflow/task/context/current.py",
"start_line": null,
"text": "@user1:\nHmm.. I feel this is wrong place for this func... | aa8291c6d78f34902b6d20939ee0286b75d16acf | diff --git a/airflow/example_dags/example_xcomargs.py b/airflow/example_dags/example_xcomargs.py
index 870030371cacc..019b1bd7baa99 100644
--- a/airflow/example_dags/example_xcomargs.py
+++ b/airflow/example_dags/example_xcomargs.py
@@ -17,20 +17,30 @@
# under the License.
"""Example DAG demonstrating the usage of ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
apache__airflow-9843@874bcf8 | apache/airflow | Python | 9,843 | Add Snowflake support to SQL operator and sensor | Add Snowflake as supported database backend for SQL operator and sensor. This is primarily an update to the `allowed_conn_type` sets for the corresponding classes.
Closes #9548
---
Make sure to mark the boxes below before creating PR: [x]
- [X] Description above provides context of the change
- [x] Unit tests... | 2020-07-15T18:52:06Z | Add support for snowflake on the sql_sensor
**Description**
Enable the support for Snowflake on the SqlSensor.
**Use case**
Currently, the `SqlSensor` supports only the following connection types,
- google_cloud_platform
- jdbc
- mssql
- mysql
- oracle
- postgres
- presto
- sqlite
- vertica
At th... | Thanks for opening your first issue here! Be sure to follow the issue template!
Hi, I would like to pick up this issue if it is a good feature to come in.
@KumarManoj-S I assigned you. to this ticket. This change seems sensible. We should not have lists of approved classes in the code, but we should rely on interfaces... | [
{
"body": "**Description**\r\n\r\nEnable the support for Snowflake on the SqlSensor.\r\n\r\n**Use case**\r\n\r\nCurrently, the `SqlSensor` supports only the following connection types,\r\n\r\n- google_cloud_platform\r\n- jdbc\r\n- mssql\r\n- mysql\r\n- oracle\r\n- postgres\r\n- presto\r\n- sqlite\r\n- vertica\r... | 770de53eb57bd57ffc555ad15b18f0c058dbebe7 | {
"head_commit": "874bcf8cdcd027191a65de43009fb2fa49f0e791",
"head_commit_message": "Add test for conn_type to valid hook mapping",
"patch_to_review": "diff --git a/airflow/models/connection.py b/airflow/models/connection.py\nindex 7144bcba79007..75174c41784cc 100644\n--- a/airflow/models/connection.py\n+++ b/air... | [
{
"diff_hunk": "@@ -533,3 +534,7 @@ def test_enforce_alphabetical_order(self):\n expected_keys = sorted(current_keys)\n \n self.assertEqual(expected_keys, current_keys)\n+\n+ def test_hooks_importable(self):\n+ for conn_type in CONN_TYPE_TO_HOOK:\n+ self.assertTrue(issubclas... | dbe3dabc12ab147ad6fcf8e514a1b4ae22c57bfe | diff --git a/airflow/models/connection.py b/airflow/models/connection.py
index 7144bcba79007..75174c41784cc 100644
--- a/airflow/models/connection.py
+++ b/airflow/models/connection.py
@@ -72,7 +72,7 @@
"jira": ("airflow.providers.jira.hooks.jira.JiraHook", "jira_conn_id"),
"kubernetes": ("airflow.providers.c... | {
"difficulty": "medium",
"estimated_review_effort": 2,
"problem_domain": "New Feature Additions"
} |
apache__airflow-9590@147aaad | apache/airflow | Python | 9,590 | Improve idempotency of BigQueryInsertJobOperator | Closes #8903
This operator work in the following way:
- it calculates unique hash of the job using job's configuration or uuid if ``force_rerun`` is True
- creates ``job_id`` in form of
``[provide_job_id | airflow_{dag_id}_{task_id}_{exec_date}]_{uniqueness_suffix}``
- submits a BigQuery job using the ``job_id... | 2020-06-30T13:43:43Z | BigQueryHook refactor + deterministic BQ Job ID
<!--
Welcome to Apache Airflow! For a smooth issue process, try to answer the following questions.
Don't worry if they're not all applicable; just try to include what you can :-)
If you need to include code snippets or logs, please put them in fenced code
blocks.... | Thanks for opening your first issue here! Be sure to follow the issue template!
Hi @albertocalderari, I'm curently workining on refactor of BQ integration. I decided to abandon custom "run" and use `insert_job` method which will accept `job_id`:
https://github.com/PolideaInternal/airflow/blob/71328b19be73ff0e4820be... | [
{
"body": "<!--\r\n\r\nWelcome to Apache Airflow! For a smooth issue process, try to answer the following questions.\r\nDon't worry if they're not all applicable; just try to include what you can :-)\r\n\r\nIf you need to include code snippets or logs, please put them in fenced code\r\nblocks. If they're supe... | f02ad50814f1af8be5f111e23a62f12bab61d7a8 | {
"head_commit": "147aaadddbd2ab8c873060ea9254006b6784dc88",
"head_commit_message": "Update airflow/providers/google/cloud/operators/bigquery.py\n\nCo-authored-by: Jacob Ferriero <jferriero@google.com>",
"patch_to_review": "diff --git a/airflow/providers/google/cloud/hooks/bigquery.py b/airflow/providers/google/c... | [
{
"diff_hunk": "@@ -1666,6 +1684,8 @@ def __init__(\n project_id: Optional[str] = None,\n location: Optional[str] = None,\n job_id: Optional[str] = None,\n+ force_rerun: bool = False,",
"line": null,
"original_line": 1687,
"original_start_line": null,
"path": "airf... | 7dd582dd7cc824221d60ffaad2887827fb84e003 | diff --git a/airflow/providers/google/cloud/hooks/bigquery.py b/airflow/providers/google/cloud/hooks/bigquery.py
index 1ec27fe3114a5..6a9650c7b4603 100644
--- a/airflow/providers/google/cloud/hooks/bigquery.py
+++ b/airflow/providers/google/cloud/hooks/bigquery.py
@@ -49,6 +49,8 @@
log = logging.getLogger(__name__)
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Code Refactoring / Architectural Improvement"
} |
apache__airflow-15574@04750aa | apache/airflow | Python | 15,574 | Add means to Duplicate connections from UI | closes: #12401
---
**Description**
* This change allows users to duplicate connections via UI.
* user can also create duplicates of multiple connections.
* A descriptive flash message will be shown regarding the success or error in any of the connection duplication.
| 2021-04-28T14:36:45Z | Duplicate connections UI
In the UI it would be nice to duplicate the selected connection, in the menu "With Selected".
The copy would be set with the same name plus some suffix (_copy, _1, whatever) and it is useful for when you have a connection with all equal fields except something in a particular one. | Sound good to me. Can I assign you to this ticket?
> Sound good to me. Can I assign you to this ticket?
I have no clue how to approach this and right now I don't have time to investigate, sorry
I would like to work on this task, Should I add a new permission or use the can_create permission?
`airflow/www/templates/... | [
{
"body": "In the UI it would be nice to duplicate the selected connection, in the menu \"With Selected\". \r\n\r\nThe copy would be set with the same name plus some suffix (_copy, _1, whatever) and it is useful for when you have a connection with all equal fields except something in a particular one. ",
"n... | 6236e7e205f3dcff3b1f003b7897ba3f549454be | {
"head_commit": "04750aafaa04e57edc5935f074038fb2327e2335",
"head_commit_message": "12401 - test added",
"patch_to_review": "diff --git a/airflow/www/views.py b/airflow/www/views.py\nindex 21d4a820489e1..c35103ce948b4 100644\n--- a/airflow/www/views.py\n+++ b/airflow/www/views.py\n@@ -21,6 +21,7 @@\n import json... | [
{
"diff_hunk": "@@ -270,6 +270,73 @@ def test_prefill_form_null_extra(self):\n cmv.prefill_form(form=mock_form, pk=1)\n \n \n+class TestMultiDuplicateConnectionModelView(TestBase):",
"line": null,
"original_line": 273,
"original_start_line": null,
"path": "tests/www/test_views.py",
"... | ac6841cd74fcb04c69c908eacbc4dfcab03b2d3b | diff --git a/airflow/www/views.py b/airflow/www/views.py
index a1e61721f28ae..907c103fad509 100644
--- a/airflow/www/views.py
+++ b/airflow/www/views.py
@@ -22,6 +22,7 @@
import json
import logging
import math
+import re
import socket
import sys
import traceback
@@ -78,6 +79,7 @@
from pygments import highlight, ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
apache__airflow-8560@df1e721 | apache/airflow | Python | 8,560 | Allow to define custom XCom class | All details can be found in the following issue:
closes: #8059
---
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Target Github ISSUE in description if exists
-... | 2020-04-25T19:53:26Z | [AIP-31] Enable arbitrary XCom class
**Description**
- Enable custom XCom backend functionality for custom serialization/deserialization.
- XCom backend can be set from airflow.cfg and defaults to existing `airflow.models.XCom`.
**Use case / motivation**
This comes from a discussion with @turbaszek .... | Thanks @casassg for putting this into an issue!
The idea comes from DAGs where we have two operators OP1 >> OP2:
- OP1 downloads from API and upload file on GCS
- OP2 downloads the previous file from GCS and does something
Abstracting this layer of writing to and reading from persistent storage will make writ... | [
{
"body": "\r\n**Description**\r\n\r\n\r\n\r\n- Enable custom XCom backend functionality for custom serialization/deserialization.\r\n- XCom backend can be set from airflow.cfg and defaults to existing `airflow.models.XCom`. \r\n\r\n\r\n\r\n**Use case / motivation**\r\nThis comes from a discussion with @turbasz... | c1fb28230fa0d36ef86c452c70254b253a113f9c | {
"head_commit": "df1e721e5f02bb8daba50d4bd1fb10d19bcafb92",
"head_commit_message": "fixup! fixup! fixup! Allow to define custom XCom class",
"patch_to_review": "diff --git a/airflow/config_templates/config.yml b/airflow/config_templates/config.yml\nindex 201af0c3e1150..4a4c248cf516d 100644\n--- a/airflow/config_... | [
{
"diff_hunk": "@@ -229,3 +229,16 @@ def deserialize_value(result) -> Any:\n \"for XCOM, then you need to enable pickle \"\n \"support for XCOM in your airflow config.\")\n raise\n+\n+\n+def resolve_xcom_backend():\n+ \"\"\"Resolves custom XCom class\"\... | 35df2efdc898325a40d10ba1402a33049962e816 | diff --git a/airflow/config_templates/config.yml b/airflow/config_templates/config.yml
index 201af0c3e1150..4a4c248cf516d 100644
--- a/airflow/config_templates/config.yml
+++ b/airflow/config_templates/config.yml
@@ -359,6 +359,13 @@
type: string
example: ~
default: "True"
+ - name: xcom_backend... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
apache__airflow-8749@161c96c | apache/airflow | Python | 8,749 | add AWS StepFunctions integrations to the aws provider | ---
Closes: https://github.com/apache/airflow/issues/8748
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Target Github ISSUE in description if exists
- [x] Commi... | 2020-05-06T21:26:05Z | Implement AWS StepFunctions integrations for the aws provider
**Description**
Add an integration to the AWS provider to execute and monitor AWS Step Function State Machines
**Use case / motivation**
Would like to be able to execute, monitor, and retrieve results from AWS Step Functions State Machines within ... | Thanks for opening your first issue here! Be sure to follow the issue template! | [
{
"body": "**Description**\r\n\r\nAdd an integration to the AWS provider to execute and monitor AWS Step Function State Machines\r\n\r\n\r\n**Use case / motivation**\r\n\r\nWould like to be able to execute, monitor, and retrieve results from AWS Step Functions State Machines within a DAG. This integration would... | bd29ee3ad1ebe96533759494c9b39bb504af6e14 | {
"head_commit": "161c96c698bc76411ead1cacc2e68bf4c439f826",
"head_commit_message": "fixed pylint error: line too long after refactor",
"patch_to_review": "diff --git a/airflow/providers/amazon/aws/hooks/step_function.py b/airflow/providers/amazon/aws/hooks/step_function.py\nnew file mode 100644\nindex 0000000000... | [
{
"diff_hunk": "@@ -0,0 +1,79 @@\n+# Licensed to the Apache Software Foundation (ASF) under one\n+# or more contributor license agreements. See the NOTICE file\n+# distributed with this work for additional information\n+# regarding copyright ownership. The ASF licenses this file\n+# to you under the Apache Li... | e10608a5957fe01f2f43e0c6f988f7da0d438e8b | diff --git a/airflow/providers/amazon/aws/hooks/step_function.py b/airflow/providers/amazon/aws/hooks/step_function.py
new file mode 100644
index 0000000000000..f0e10400d95ee
--- /dev/null
+++ b/airflow/providers/amazon/aws/hooks/step_function.py
@@ -0,0 +1,79 @@
+# Licensed to the Apache Software Foundation (ASF) unde... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
apache__airflow-8085@a00d4c2 | apache/airflow | Python | 8,085 | Add support for custom task runner | https://github.com/apache/airflow/issues/8067
I'm not sure if anyone will use it, but it can stimulate community creativity.
---
Make sure to mark the boxes below before creating PR: [x]
- [X] Description above provides context of the change
- [X] Unit tests coverage for changes (not needed for documentation ... | 2020-04-03T04:01:14Z | Allow Custom Task Runner via plugins
**Description**
Airflow provides a plugin manager to integrate external features. However, there is no configuration available to have custom task runner as part of plugins.
**Use case / motivation**
Enabling custom task runner integration with Airflow will help users in confi... | It looks trivial. Do you want to work on it? I think this should not be configured by plugins, but the configuration option. Similar to the executor.
Please look at https://github.com/apache/airflow/pull/7563
How would you like to use it? Do you have any special task runner already implemented? I wonder if it woul... | [
{
"body": "**Description**\r\nAirflow provides a plugin manager to integrate external features. However, there is no configuration available to have custom task runner as part of plugins.\r\n\r\n**Use case / motivation**\r\n Enabling custom task runner integration with Airflow will help users in configuring run... | 94480a731d141df4dd7ed91b4b93952d8e07c5c4 | {
"head_commit": "a00d4c25197f8b1acc9b3bc1738da9c6fde7b811",
"head_commit_message": "Add support for custom task runner",
"patch_to_review": "diff --git a/airflow/config_templates/config.yml b/airflow/config_templates/config.yml\nindex 5033c342e503d..bcfbf3f15e507 100644\n--- a/airflow/config_templates/config.yml... | [
{
"diff_hunk": "@@ -35,10 +46,12 @@ def get_task_runner(local_task_job):\n :return: The task runner to use to run the task.\n :rtype: airflow.task.task_runner.base_task_runner.BaseTaskRunner\n \"\"\"\n- if _TASK_RUNNER == \"StandardTaskRunner\":\n- return StandardTaskRunner(local_task_job)... | fcb22e52adc38a7ba89c391ba91752e81a5c77fe | diff --git a/airflow/config_templates/config.yml b/airflow/config_templates/config.yml
index 5033c342e503d..bcfbf3f15e507 100644
--- a/airflow/config_templates/config.yml
+++ b/airflow/config_templates/config.yml
@@ -54,6 +54,7 @@
description: |
The executor class that airflow should use. Choices includ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
apache__airflow-9029@414ee66 | apache/airflow | Python | 9,029 | Remove Hive/Hadoop/Java dependency from unit tests | CI takes way too long to build and uses too much memory. This removes Hive and Hadoop as dependencies from CI, and replaces direct access with mocks in unit tests.
Fixes #8783 (though differently to proposed, via mocking instead of separate docker image)
---
Make sure to mark the boxes below before creating PR: [x... | 2020-05-26T20:39:09Z | Move Hadoop distro out of CI image
**Description**
Hadoop distro is unnecessarily part of the CI image. It should be moved out and used separately
**Use case / motivation**
Download and install Hadoop image only when needed not as part of the CI image (as separate integration). This will make the image smaller... | [
{
"body": "**Description**\r\n\r\nHadoop distro is unnecessarily part of the CI image. It should be moved out and used separately\r\n\r\n**Use case / motivation**\r\n\r\nDownload and install Hadoop image only when needed not as part of the CI image (as separate integration). This will make the image smaller and... | 67379d1d9e0f19fa10020e37d12e407fb07f21bc | {
"head_commit": "414ee66f02d0965a36acb6a2f811fdcc9e18c803",
"head_commit_message": "Add back Java to dockerfile.",
"patch_to_review": "diff --git a/Dockerfile.ci b/Dockerfile.ci\nindex 6ab3c1fa876fd..b16b4242e9775 100644\n--- a/Dockerfile.ci\n+++ b/Dockerfile.ci\n@@ -41,7 +41,7 @@ ENV DEBIAN_FRONTEND=noninteract... | [
{
"diff_hunk": "@@ -121,14 +121,14 @@ RUN adduser airflow \\\n # https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=863199\n RUN mkdir -pv /usr/share/man/man1 \\\n && mkdir -pv /usr/share/man/man7 \\\n- # && curl -fsSL https://adoptopenjdk.jfrog.io/adoptopenjdk/api/gpg/key/public | apt-key add - \\\n- ... | b10ae8a2161cf25dfcfc0803499a316dd0abc1d5 | diff --git a/Dockerfile.ci b/Dockerfile.ci
index 1d040aefbfdb1..770da345eb0cc 100644
--- a/Dockerfile.ci
+++ b/Dockerfile.ci
@@ -41,7 +41,7 @@ ENV DEBIAN_FRONTEND=noninteractive LANGUAGE=C.UTF-8 LANG=C.UTF-8 LC_ALL=C.UTF-8
LC_CTYPE=C.UTF-8 LC_MESSAGES=C.UTF-8
# By increasing this number we can do force build of... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Performance Optimizations"
} | |
ansible__ansible-78563@cfa706b | ansible/ansible | Python | 78,563 | update link for RH customers in docs banner | ##### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
Fixes https://github.com/ansible/ansible/issues/78556
##### ISSUE TYPE
<!--- Pick one below and delete the rest -->
- Docs Pull Request
##### CO... | 2022-08-16T19:52:34Z | Banner about 2.9 on latest docs is misleading
### Summary
Feeback: - the line "Red Hat subscribers, select 2.9 in the version selection to the left for the most recent Red Hat release." is confusing, because 2.9 is not the latest release but rather the most recent release prior to the core/collections split.
##... | Fix should be to use the same wording and link that is on the 2.9 EOL docs, something like:
For Red Hat customers, see [the Red Hat AAP platform lifecycle](https://access.redhat.com/support/policy/updates/ansible-automation-platform). | [
{
"body": "### Summary\n\nFeeback: - the line \"Red Hat subscribers, select 2.9 in the version selection to the left for the most recent Red Hat release.\" is confusing, because 2.9 is not the latest release but rather the most recent release prior to the core/collections split. \r\n\r\n\n\n### Issue Type\n\nD... | ccf1a631585149c612250f466044f88b43518393 | {
"head_commit": "cfa706b47874ebd514bf37db2dfe6dbe8a67c079",
"head_commit_message": "update link for RH customers in docs banner",
"patch_to_review": "diff --git a/docs/docsite/.templates/banner.html b/docs/docsite/.templates/banner.html\nindex 3288eb8e8a1411..2145acf5b832d3 100644\n--- a/docs/docsite/.templates/... | [
{
"diff_hunk": "@@ -46,7 +46,7 @@\n /* temp extra banner to advertise AnsibeFest2021 */\n banner += extra_banner;\n \n- msg += 'You are reading the <b>latest</b> (stable) community version of the Ansible documentation. Red Hat subscribers, select <b>2.9</b> in the version selection to the... | 684b6cd046167986cd3b0564f7b23bfcc186bf82 | diff --git a/docs/docsite/.templates/banner.html b/docs/docsite/.templates/banner.html
index 3288eb8e8a1411..57c104d9da4505 100644
--- a/docs/docsite/.templates/banner.html
+++ b/docs/docsite/.templates/banner.html
@@ -46,7 +46,7 @@
/* temp extra banner to advertise AnsibeFest2021 */
banner += extra_b... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "Documentation Updates"
} |
ansible__ansible-73961@8a46adc | ansible/ansible | Python | 73,961 | Find fix | Closes #50070
Fixes #50067
##### ISSUE TYPE
<!--- Pick one below and delete the rest -->
- Bugfix Pull Request
##### COMPONENT NAME
<!--- Write the short name of the module, plugin, task or feature below -->
find | 2021-03-19T15:27:49Z | find: regex excludes without pattern raises internal errors by default
##### SUMMARY
Something like the following to just strip an entry
```
- hosts: all
tasks:
- name: Find all Open Stack source repos used by this job
find:
paths:
- github.com
file_type: directory
... | Files identified in the description:
* [lib/ansible/modules/files/find.py](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/files/find.py)
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot command.
[click here for bot help](https:... | [
{
"body": "##### SUMMARY\r\n\r\nSomething like the following to just strip an entry\r\n\r\n```\r\n- hosts: all\r\n tasks:\r\n\r\n - name: Find all Open Stack source repos used by this job\r\n find:\r\n paths:\r\n - github.com\r\n file_type: directory\r\n depth: 2\r\n ... | 48c0fbd1cb92943b992b8a522e40ae6fe668e648 | {
"head_commit": "8a46adcd1a63866ebab66dc13f6674f291b63663",
"head_commit_message": "moved change to new location\nadded changelog",
"patch_to_review": "diff --git a/changelogs/fragments/fix_find_default.yml b/changelogs/fragments/fix_find_default.yml\nnew file mode 100644\nindex 00000000000000..85c640ae958ce6\n-... | [
{
"diff_hunk": "@@ -41,6 +41,7 @@\n - This parameter expects a list, which can be either comma separated or YAML. If any of the\n patterns contain a comma, make sure to put them in a list to avoid splitting the patterns\n in undesirable ways.\n+ - Defaults to '... | 492deab3e909927841fbdcd8b5df630d649e4ef4 | diff --git a/changelogs/fragments/fix_find_default.yml b/changelogs/fragments/fix_find_default.yml
new file mode 100644
index 00000000000000..85c640ae958ce6
--- /dev/null
+++ b/changelogs/fragments/fix_find_default.yml
@@ -0,0 +1,2 @@
+bugfixes:
+ - find module, fix default pattern when use_regex is true.
diff --git a... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-78496@5bf2fdd | ansible/ansible | Python | 78,496 | Fix apt making changes in check mode | ##### SUMMARY
Fixes https://github.com/ansible/ansible/issues/66413
Supersedes https://github.com/ansible/ansible/pull/45575
Don't update the cache or mark packages as manually installed in check mode
##### ISSUE TYPE
<!--- Pick one below and delete the rest -->
- Bugfix Pull Request
##### COMPONENT NAME
... | 2022-08-10T20:10:41Z | apt module touches package states when run in check mode
<!--- Verify first that your issue is not already reported on GitHub -->
<!--- Also test if the latest release and devel branch are affected too -->
<!--- Complete *all* sections as described, this form is processed automatically -->
##### SUMMARY
<!--- Exp... | Files identified in the description:
* [`lib/ansible/modules/packaging/os/apt.py`](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/packaging/os/apt.py)
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot command.
[click here for bo... | [
{
"body": "<!--- Verify first that your issue is not already reported on GitHub -->\r\n<!--- Also test if the latest release and devel branch are affected too -->\r\n<!--- Complete *all* sections as described, this form is processed automatically -->\r\n\r\n##### SUMMARY\r\n<!--- Explain the problem briefly bel... | 3f1838bf918a055b491ab25d6caee2e5022db3c1 | {
"head_commit": "5bf2fdd3270eb2c1628559bd912feda2158e24cc",
"head_commit_message": "changelog",
"patch_to_review": "diff --git a/changelogs/fragments/78496-fix-apt-check-mode.yml b/changelogs/fragments/78496-fix-apt-check-mode.yml\nnew file mode 100644\nindex 00000000000000..25d6ae84666f19\n--- /dev/null\n+++ b/... | [
{
"diff_hunk": "@@ -98,7 +112,9 @@\n - name: verify update_cache\n assert:\n that:\n+ - apt_update_cache_1_check_mode is change",
"line": null,
"original_line": 115,
"original_start_line": null,
"path": "test/integration/targets/apt/tasks/apt.yml",
"start_line": null,
"text": ... | 616fd09cc1a36bbb982a6c3a00928d476d9865a6 | diff --git a/changelogs/fragments/78496-fix-apt-check-mode.yml b/changelogs/fragments/78496-fix-apt-check-mode.yml
new file mode 100644
index 00000000000000..25d6ae84666f19
--- /dev/null
+++ b/changelogs/fragments/78496-fix-apt-check-mode.yml
@@ -0,0 +1,3 @@
+bugfixes:
+ - apt - don't actually update the cache in chec... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-73821@c804f06 | ansible/ansible | Python | 73,821 | Add umask option to user module | ##### SUMMARY
Fixes: #40359
##### ISSUE TYPE
- Feature Pull Request
##### COMPONENT NAME
user
##### ADDITIONAL INFORMATION
This has been opened previously on https://github.com/ansible/ansible/pull/71469. | 2021-03-08T12:53:19Z | Option to set UMASK with USER module.
<!---
Verify first that your issue/request is not already reported on GitHub.
THIS FORM WILL BE READ BY A MACHINE, COMPLETE ALL SECTIONS AS DESCRIBED.
Also test if the latest release, and devel branch are affected too.
ALWAYS add information AFTER (OUTSIDE) these html comments... | Files identified in the description:
* [lib/ansible/modules/system/user.py](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/system/user.py)
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot command.
[click here for bot help](http... | [
{
"body": "<!---\r\nVerify first that your issue/request is not already reported on GitHub.\r\nTHIS FORM WILL BE READ BY A MACHINE, COMPLETE ALL SECTIONS AS DESCRIBED.\r\nAlso test if the latest release, and devel branch are affected too.\r\nALWAYS add information AFTER (OUTSIDE) these html comments.\r\nOtherwi... | 212837defcb917e2b5613be0966a5374b3c27536 | {
"head_commit": "c804f06bfa92747fa8894942c0f6d959eb44602b",
"head_commit_message": "Remove created users in integration test at last",
"patch_to_review": "diff --git a/changelogs/fragments/73821-user-add_umask_option.yaml b/changelogs/fragments/73821-user-add_umask_option.yaml\nnew file mode 100644\nindex 000000... | [
{
"diff_hunk": "@@ -250,6 +250,14 @@\n - Supported on Linux only.\n type: int\n version_added: \"2.11\"\n+ umask:\n+ description:\n+ - Sets the umask of the user.\n+ - Does nothing when used with other platforms.\n+ - Currently supported on ... | 234b03f1bd9753f775c3bcd1d795e684d2a8f43e | diff --git a/changelogs/fragments/73821-user-add_umask_option.yaml b/changelogs/fragments/73821-user-add_umask_option.yaml
new file mode 100644
index 00000000000000..46364bae308e52
--- /dev/null
+++ b/changelogs/fragments/73821-user-add_umask_option.yaml
@@ -0,0 +1,3 @@
+---
+minor_changes:
+ - user - Add ``umask`` op... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
ansible__ansible-43678@dac7082 | ansible/ansible | Python | 43,678 | Add module parameter to control Puppet agent noop switch | @emonty
Current module overrides puppet.conf noop setting by forcing '--no-noop' switch which may not be expected or desired.
Adds parameter to allow user to control noop mode, or honour local puppet agent configuration.
`noop: None` - Use agent configuration
`noop: true` - Add --noop switch to cmd
`noop... | 2018-08-05T11:05:11Z | Add module parameter to control Puppet agent noop switch
##### SUMMARY
Current puppet module overrides `puppet.conf` noop setting by forcing '--no-noop' switch which may not be expected or desired.
Add a parameter to allow user to control noop mode, or honour local puppet agent configuration.
noop: Undefined - ... | [
{
"body": "##### SUMMARY\r\nCurrent puppet module overrides `puppet.conf` noop setting by forcing '--no-noop' switch which may not be expected or desired.\r\n\r\nAdd a parameter to allow user to control noop mode, or honour local puppet agent configuration.\r\n\r\nnoop: Undefined - Use agent configuration\r\nno... | e576acf6e4fae23de7100fea920a9addf72a3c10 | {
"head_commit": "dac7082e785826e22c00781e0014f95b1cb068c5",
"head_commit_message": "Puppet agent noop switch\n\n Add module parameter to control noop switch\n\n Current module overrides puppet.conf noop setting by forcing '--no-noop' switch which may not be expected or desired.\n\n Add parameter to allow... | [
{
"diff_hunk": "@@ -32,6 +32,13 @@\n manifest:\n description:\n - Path to the manifest file to run puppet apply on.\n+ noop:\n+ description:\n+ - Override puppet.conf noop mode.\n+ - Undefined, use default or puppet.conf value if defined.\n+ - true, Run puppet agent with --noop sw... | 3ba239f2a637dcf675a59532df1e78837fd666fe | diff --git a/lib/ansible/modules/system/puppet.py b/lib/ansible/modules/system/puppet.py
index ddd0dd7c4cb36a..e2f177440fe738 100644
--- a/lib/ansible/modules/system/puppet.py
+++ b/lib/ansible/modules/system/puppet.py
@@ -32,6 +32,13 @@
manifest:
description:
- Path to the manifest file to run puppet ap... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
ansible__ansible-26709@e42ac7c | ansible/ansible | Python | 26,709 | ipa_dnsrecord: Allow for PTR Records (supporting reverse DNS) | ##### SUMMARY
This pull request allows one to manually add a pointer record to support reverse DNS. After discussion, I would like to discuss the possibility of us supporting the ability to auto-create reverse DNS records as well, but I figured this would be a good first step towards the ideal.
Fixes #26702
##... | 2017-07-12T16:18:02Z | ipa-dnsrecord: unable to support reverse DNS
<!---
Verify first that your issue/request is not already reported on GitHub.
Also test if the latest release, and master branch are affected too.
-->
##### ISSUE TYPE
- Bug Report
##### COMPONENT NAME
ipa_dnsrecord
##### ANSIBLE VERSION
<!--- Paste verbatim ... | cc @Nosmoht
[click here for bot help](https://github.com/ansible/ansibullbot/blob/master/ISSUE_HELP.md)
<!--- boilerplate: notify ---> | [
{
"body": "<!---\r\nVerify first that your issue/request is not already reported on GitHub.\r\nAlso test if the latest release, and master branch are affected too.\r\n-->\r\n\r\n##### ISSUE TYPE\r\n - Bug Report\r\n\r\n##### COMPONENT NAME\r\nipa_dnsrecord\r\n\r\n##### ANSIBLE VERSION\r\n<!--- Paste verbatim ou... | 31b6ac896d0ca9db5dc9e026f1e0c5197a7b563a | {
"head_commit": "e42ac7c3f7022c83105dcfbf89107b6368bbe4b3",
"head_commit_message": "Adds patch to allow for PTR records",
"patch_to_review": "diff --git a/lib/ansible/modules/identity/ipa/ipa_dnsrecord.py b/lib/ansible/modules/identity/ipa/ipa_dnsrecord.py\nindex 8e3ff794af1762..7e72509d518a9c 100644\n--- a/lib/... | [
{
"diff_hunk": "@@ -99,6 +99,16 @@\n record_type: 'AAAA'\n record_ip: '::1'\n \n+# Ensure a PTR record is present\n+- ipa_dnsrecord:\n+ ipa_host: spider.example.com\n+ ipa_pass: Passw0rd!\n+ state: present\n+ zone_name: 2.168.192.in-addr.arpa\n+ record_name: 5\n+ record_type: 'PTR'\n+ ... | 5c8bdf5a02f881aaab9eff5c6a389828e4ab411a | diff --git a/lib/ansible/modules/identity/ipa/ipa_dnsrecord.py b/lib/ansible/modules/identity/ipa/ipa_dnsrecord.py
index 8e3ff794af1762..a3bf2d49f3d646 100644
--- a/lib/ansible/modules/identity/ipa/ipa_dnsrecord.py
+++ b/lib/ansible/modules/identity/ipa/ipa_dnsrecord.py
@@ -45,13 +45,15 @@
record_type:
descript... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-31562@f2b1998 | ansible/ansible | Python | 31,562 | Add new filter to parse xml output for network use cases |
##### SUMMARY
<!--- Describe the change, including rationale and design decisions -->
Fixes #31026
* Add parse_xml filter
* Add documentation for parse_xml filter
<!---
If you are fixing an existing issue, please include "Fixes #nnn" in your
commit message and your description; but you should still explain w... | 2017-10-11T07:33:42Z | Add parse xml filter which returns a json object [XML_FILTER]
<!---
Verify first that your issue/request is not already reported on GitHub.
Also test if the latest release, and master branch are affected too.
-->
##### ISSUE TYPE
<!--- Pick one below and delete the rest: -->
- Feature Idea
##### COMPONENT N... | cc @Qalthos @gundalow @privateip @rcarrillocruz @trishnaguha
[click here for bot help](https://github.com/ansible/ansibullbot/blob/master/ISSUE_HELP.md)
<!--- boilerplate: notify --->
cc @kedarX
[click here for bot help](https://github.com/ansible/ansibullbot/blob/master/ISSUE_HELP.md)
<!--- boilerplate: notify ---> | [
{
"body": "<!---\r\nVerify first that your issue/request is not already reported on GitHub.\r\nAlso test if the latest release, and master branch are affected too.\r\n-->\r\n\r\n##### ISSUE TYPE\r\n<!--- Pick one below and delete the rest: -->\r\n - Feature Idea\r\n\r\n##### COMPONENT NAME\r\n<!--- Name of the ... | 48ab1a1334d1c5273691398ae2629dc0b7ec52a8 | {
"head_commit": "f2b19983c65c4afb8b0aaad5a13cd8e0fa2010e1",
"head_commit_message": "Fix unit test failures",
"patch_to_review": "diff --git a/docs/docsite/rst/playbooks_filters.rst b/docs/docsite/rst/playbooks_filters.rst\nindex 329c0fc75b6603..f4384182112a59 100644\n--- a/docs/docsite/rst/playbooks_filters.rst\... | [
{
"diff_hunk": "@@ -340,7 +340,7 @@ output, use the ``parse_cli`` filter::\n {{ output | parse_cli('path/to/spec') }}\n \n The ``parse_cli`` filter will load the spec file and pass the command output\n-through, it returning JSON output. The spec file is a YAML yaml that defines\n+through, it returning JSON o... | 29089e898cd48262b3e2efe97c0696636e0879c5 | diff --git a/docs/docsite/rst/playbooks_filters.rst b/docs/docsite/rst/playbooks_filters.rst
index 329c0fc75b6603..a4abda352375a9 100644
--- a/docs/docsite/rst/playbooks_filters.rst
+++ b/docs/docsite/rst/playbooks_filters.rst
@@ -340,8 +340,7 @@ output, use the ``parse_cli`` filter::
{{ output | parse_cli('path/to/... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
bridgecrewio__checkov-2138@bce5e09 | bridgecrewio/checkov | Python | 2,138 | Fix loading git modules with git@github.com | Resolves https://github.com/bridgecrewio/checkov/issues/2136
This fix prevents the module source `git::ssh://git@github.com/<<org>>>/<<repo>>...`
To become the following command: `git clone -v --depth=1 ssh://github.com/<<org>>>/<<repo>>`
and enforce it to be the following: `git clone -v --depth=1 ssh://git@github.... | 2021-12-22T09:33:23Z | git fatal: Could not read from remote repository when using private git repository for terraform modules
**Describe the bug**
git fatal: Could not read from remote repository when using private git repository for terraform modules.
**To Reproduce**
Steps to reproduce the behavior:
```terraform
module "sample_... | the bug is even a bit more specific, it only affects git URLs with sub directories in the source path. | [
{
"body": "**Describe the bug**\r\ngit fatal: Could not read from remote repository when using private git repository for terraform modules. \r\n\r\n**To Reproduce**\r\nSteps to reproduce the behavior:\r\n\r\n```terraform\r\nmodule \"sample_bucket\" {\r\n source = \"git::ssh://git@github.com/<<org>>>/<<repo>... | b5df2f4d0b4c0f8ada19a7b5a97364ac2ea0b78d | {
"head_commit": "bce5e09532a94092e88dd1c92892a336a7fbdf55",
"head_commit_message": "avoid removing git username",
"patch_to_review": "diff --git a/checkov/terraform/module_loading/loaders/git_loader.py b/checkov/terraform/module_loading/loaders/git_loader.py\nindex e34c66ea86..00daa46bbf 100644\n--- a/checkov/te... | [
{
"diff_hunk": "@@ -75,7 +75,7 @@ def _parse_module_source(self) -> ModuleSource:\n \n username = re.match(re.compile(r\"^(.*?@).*\"), root_module)\n if username:",
"line": null,
"original_line": 77,
"original_start_line": null,
"path": "checkov/terraform/module_loading/loaders/g... | b62eca39a4b7ff24a21ee46d8f7a6297bf2af782 | diff --git a/checkov/terraform/module_loading/loaders/git_loader.py b/checkov/terraform/module_loading/loaders/git_loader.py
index e34c66ea86..c8f2978fd9 100644
--- a/checkov/terraform/module_loading/loaders/git_loader.py
+++ b/checkov/terraform/module_loading/loaders/git_loader.py
@@ -74,7 +74,7 @@ def _parse_module_s... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
bridgecrewio__checkov-1922@8f16848 | bridgecrewio/checkov | Python | 1,922 | Parallelize module download | By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Took a detour - instead of modifying the existing modules, I download them beforehand and leverage a cache to have the results accessible
| 2021-11-10T11:55:47Z | Thread Pools
**Is your feature request related to a problem? Please describe.**
Checkov v2 does not successfully execute on our largest terraform root module. It is highly complex with many provider configurations and countable modules across multiple provider regions.
It appears that Checkov is entirely single-t... | Interesting. I love the suggestion. What should be our benchmark for performance or a test terraform repo we can try?
@schosterbarak - how about Cloudposse's Terraform modules? Lots of Terraform code lol and since it's public we can specify external modules which should give us a maximum slowdown scenario to measure a... | [
{
"body": "**Is your feature request related to a problem? Please describe.**\r\n\r\nCheckov v2 does not successfully execute on our largest terraform root module. It is highly complex with many provider configurations and countable modules across multiple provider regions.\r\n\r\nIt appears that Checkov is ent... | 2628c6f28a5604efe3877d6eacc3044d2b66b7b1 | {
"head_commit": "8f168488dabd0b4369dd1bfa262adcb9a87d6385",
"head_commit_message": "Revert unnecessary changes",
"patch_to_review": "diff --git a/checkov/common/runners/runner_registry.py b/checkov/common/runners/runner_registry.py\nindex 03871554bf..7fda6be3bc 100644\n--- a/checkov/common/runners/runner_registr... | [
{
"diff_hunk": "@@ -30,14 +30,14 @@ def _load_module(self) -> ModuleContent:\n git_getter = GitGetter(module_source, create_clone_and_result_dirs=False)\n git_getter.temp_dir = self.dest_dir\n git_getter.do_get()\n-\n- return_dir = self.dest_dir\n- if se... | 8627b54bc3eb2d381eefb3723ea18bb475a2c295 | diff --git a/checkov/common/runners/runner_registry.py b/checkov/common/runners/runner_registry.py
index 03871554bf..7fda6be3bc 100644
--- a/checkov/common/runners/runner_registry.py
+++ b/checkov/common/runners/runner_registry.py
@@ -55,10 +55,14 @@ def run(
repo_root_for_plan_enrichment: Optional[List[Union[... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
deepspeedai__DeepSpeed-7302@92d30de | deepspeedai/DeepSpeed | Python | 7,302 | Fix: Update grad norm calculation for CPU offload | ## Description
This PR fixes an issue where gradient clipping modifications are not reflected in the global gradient norm calculation when CPU offloading is enabled. The issue occurs because the `averaged_gradients` are not being updated with the clipped gradients when CPU offloading is active.
## Problem
When usi... | 2025-05-22T06:33:51Z | Question about `safe_set_local_grad` and `safe_get_local_grad`
deepspeed==0.16.7
I'm using zero stage-3
I write a custom Trainer to do some custom grad clipping after `backward()` is called and before `step()`. I use `safe_get_local_grad` and `safe_set_local_grad` to do the custom grad clipping. After clipping, I call... | @breaddaerb, thanks for your question. You are correct in that we don't propagate the update gradient back into `.global_grad_norm`. Are you able to provide a PR for this?
I take a closer look at `DeepSpeedZeroOptimizer_Stage3`. The `_global_grad_norm` is calculated in the `step()` by calling ` _get_norm_groups()` firs... | [
{
"body": "deepspeed==0.16.7\nI'm using zero stage-3\n\nI write a custom Trainer to do some custom grad clipping after `backward()` is called and before `step()`. I use `safe_get_local_grad` and `safe_set_local_grad` to do the custom grad clipping. After clipping, I call `safe_get_local_grad` again, and the res... | d4032ec7d17d7260094644f254fc4756adfade07 | {
"head_commit": "92d30de324586d927af0d78fe02a5e3e5fb6af56",
"head_commit_message": "Fix: Update grad norm calculation for CPU offload",
"patch_to_review": "diff --git a/deepspeed/runtime/zero/stage3.py b/deepspeed/runtime/zero/stage3.py\nindex f37c6c271009..a13aaf7ba263 100644\n--- a/deepspeed/runtime/zero/stage... | [
{
"diff_hunk": "@@ -1148,11 +1148,20 @@ def independent_gradient_partition_epilogue(self):\n self.__param_id_to_grad_partition[param.ds_id]\n if param.requires_grad else torch.zeros_like(param.ds_tensor) for param in sub_group\n ]\n- # this method g... | cb9e723796da584103614fd957c990dec518adf7 | diff --git a/deepspeed/runtime/zero/stage3.py b/deepspeed/runtime/zero/stage3.py
index f37c6c271009..abc6c7e99a2d 100644
--- a/deepspeed/runtime/zero/stage3.py
+++ b/deepspeed/runtime/zero/stage3.py
@@ -2451,6 +2451,10 @@ def set_local_grad_for_param(self, value, param):
# fp32_grad = self.fp32_partitioned... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
aio-libs__aiohttp-5095@fcc6de6 | aio-libs/aiohttp | Python | 5,095 | Add keepalive_timeout parameter to web.run_app | <!-- Thank you for your contribution! -->
## What do these changes do?
Add keepalive_timeout parameter to web.run_app. Closes #5094.
<!-- Please give a short brief about these changes. -->
## Are there changes in behavior for the user?
Unlikely.
<!-- Outline any notable behaviour for the end users. --... | 2020-10-20T08:24:44Z | Allow configuring the keepalive timeout in web.run_app
🐣 **Is your feature request related to a problem? Please describe.**
<!-- A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] -->
Adjusting the keepalive timeout is not possible without copy-pasting a lot of boilerplate c... | [
{
"body": "🐣 **Is your feature request related to a problem? Please describe.**\r\n<!-- A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] -->\r\nAdjusting the keepalive timeout is not possible without copy-pasting a lot of boilerplate code usually supplied by the `web... | a8d9ec3f1667463e80545b1cacc7833d1ff305e9 | {
"head_commit": "fcc6de6123e8d999f58515202d1bbf6176e0e443",
"head_commit_message": "Fix call_args usage for Python < 3.8",
"patch_to_review": "diff --git a/CHANGES/5094.feature b/CHANGES/5094.feature\nnew file mode 100644\nindex 00000000000..2d140f175e9\n--- /dev/null\n+++ b/CHANGES/5094.feature\n@@ -0,0 +1 @@\n... | [
{
"diff_hunk": "@@ -685,6 +686,24 @@ async def on_startup(app):\n exc_handler.assert_called_with(patched_loop, msg)\n \n \n+def test_run_app_keepalive_timeout(patched_loop):\n+ new_timeout = 1234\n+ base_runner_init_mock = mock.MagicMock()\n+ base_runner_init_orig = BaseRunner.__init__\n+\n+ def... | 4dda2788ca23804b41e5289212a28a9d02de4499 | diff --git a/CHANGES/5094.feature b/CHANGES/5094.feature
new file mode 100644
index 00000000000..2d140f175e9
--- /dev/null
+++ b/CHANGES/5094.feature
@@ -0,0 +1 @@
+Add keepalive_timeout parameter to web.run_app.
diff --git a/CONTRIBUTORS.txt b/CONTRIBUTORS.txt
index 50aefb5826d..7cabbbf12b7 100644
--- a/CONTRIBUTORS.t... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "New Feature Additions"
} | |
apache__airflow-10261@23472db | apache/airflow | Python | 10,261 | 10166 : Add capability to specify gunicorn access log format for airflow | Added capability to specify airflow webserver access log format. The format can be specified in airflow.cfg file or passed as argument to airflow webserver command.
Close: #10166 | 2020-08-09T13:00:03Z | Add capability to specify gunicorn access log format for airflow webserver
**Description**
Currently gunicorn access logs don't include response time. In gunicorn we can specify access-logformat to include response time. When running airflow webserver we should be able to specify this format by either defining it in... | Thanks for opening your first issue here! Be sure to follow the issue template!
Hi. Would you like to prepare a PR to implement this feature? I will gladly support you if you have any questions.
Hi @mik-laj , I have made the required changes. Could you please guide how I can test it?
I have run integration tests ... | [
{
"body": "**Description**\r\n\r\nCurrently gunicorn access logs don't include response time. In gunicorn we can specify access-logformat to include response time. When running airflow webserver we should be able to specify this format by either defining it in airflow.cfg or passing as argument in airflow webse... | 5e8b537b85ce6aa355966df08df5c1846adb4cd6 | {
"head_commit": "23472db69ff7e6a5c1aeae08179ce78a8500a002",
"head_commit_message": "10166 : Unit tests",
"patch_to_review": "diff --git a/airflow/cli/cli_parser.py b/airflow/cli/cli_parser.py\nindex 5c043ccff1d04..bf2471e5585eb 100644\n--- a/airflow/cli/cli_parser.py\n+++ b/airflow/cli/cli_parser.py\n@@ -504,6 +... | [
{
"diff_hunk": "@@ -861,6 +861,13 @@\n type: string\n example: ~\n default: \"-\"\n+ - name: access_logformat\n+ description: |\n+ Access log format for gunicorn webserver\n+ version_added: ~\n+ type: string\n+ example: ~\n+ default: \"%%(h)s %%(l)s %%(u)s %%... | 4115f1f3e5e7e967bdb636d8ebd29097dfca36a5 | diff --git a/airflow/cli/cli_parser.py b/airflow/cli/cli_parser.py
index c9dbfec837ca8..5a7787070a068 100644
--- a/airflow/cli/cli_parser.py
+++ b/airflow/cli/cli_parser.py
@@ -460,6 +460,11 @@ def positive_int(value):
default=conf.get('webserver', 'ERROR_LOGFILE'),
help="The logfile to store the webserver er... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
apache__airflow-47946@90b4d49 | apache/airflow | Python | 47,946 | Move Secrets Backend for Variables & Connections support to Task SDK | closes https://github.com/apache/airflow/issues/45435
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the ... | 2025-03-19T08:11:09Z | Move Secrets Backend for Variables & Connections support to Task SDK
Currently, the Task Execution API server handles secrets backend logic, which is ideal for scenarios such as:
>Deploying tasks in transient or ephemeral environments (e.g., GPU cloud services) where secrets need to be retrieved dynamically via the AP... | Do we need to limit worker/client to only env var, or could we allow it to use any secret store if it's configured?
i.e. the full resolution order could be
- worker env vars
- worker secret backend
- API server env vars
- API server secret backend
- API server database lookup
Look at `get_connection_from_secrets` in ... | [
{
"body": "Currently, the Task Execution API server handles secrets backend logic, which is ideal for scenarios such as:\n\n>Deploying tasks in transient or ephemeral environments (e.g., GPU cloud services) where secrets need to be retrieved dynamically via the API.\n\nHowever, there is a complementary use case... | c2a67df7fb66a7defdb1ff07ef1dc894920e6caa | {
"head_commit": "90b4d49d915cbf914b442c71cba80518c75bd791",
"head_commit_message": "adding support for variables too",
"patch_to_review": "diff --git a/airflow/configuration.py b/airflow/configuration.py\nindex 239d887bcacbf..3d80752952c97 100644\n--- a/airflow/configuration.py\n+++ b/airflow/configuration.py\n@... | [
{
"diff_hunk": "@@ -52,3 +57,38 @@ def get(cls, key: str, default: Any = NOTSET, deserialize_json: bool = False):\n if e.error.error == ErrorType.VARIABLE_NOT_FOUND and default is not NOTSET:\n return default\n raise\n+\n+ @classmethod\n+ def get_variable_from_secre... | e7fe68578270fd0dcc28d2d58d988937ae8eb3bb | diff --git a/airflow/config_templates/config.yml b/airflow/config_templates/config.yml
index e771f0ffabff7..c7f61653f6aaf 100644
--- a/airflow/config_templates/config.yml
+++ b/airflow/config_templates/config.yml
@@ -1416,6 +1416,29 @@ api:
version_added: 2.7.0
example: ~
default: "False"
+workers:... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "Code Refactoring / Architectural Improvement"
} |
encode__starlette-1685@f02a895 | encode/starlette | Python | 1,685 | Add more TestClient examples | Fixes #1677 | 2022-06-11T07:57:08Z | Document how to send files using `TestClient`
Currently, people need to rely on lost issues to understand how to send files using the `TestClient`. I guess we'd want to document how to do that. Even adding a reference to `requests` would be already helpful here. | [
{
"body": "Currently, people need to rely on lost issues to understand how to send files using the `TestClient`. I guess we'd want to document how to do that. Even adding a reference to `requests` would be already helpful here.",
"number": 1677,
"title": "Document how to send files using `TestClient`"
... | dec10cab89008bb560574d104976fdaaa018fbd8 | {
"head_commit": "f02a895f4ac7397d4b3f651e411d051dc6ebf940",
"head_commit_message": "add multiple files example",
"patch_to_review": "diff --git a/docs/testclient.md b/docs/testclient.md\nindex a214715fe..a3963f9b8 100644\n--- a/docs/testclient.md\n+++ b/docs/testclient.md\n@@ -26,6 +26,35 @@ function calls, not ... | [
{
"diff_hunk": "@@ -26,6 +26,35 @@ function calls, not awaitables.\n You can use any of `requests` standard API, such as authentication, session\n cookies handling, or file uploads.\n \n+For example, to set headers on the TestClient you can do:\n+\n+```python\n+client = TestClient(app)\n+\n+# Set headers on the... | 393d2fbbf24a74451039d364ea17ede18d64a824 | diff --git a/docs/testclient.md b/docs/testclient.md
index a214715fe..f42093030 100644
--- a/docs/testclient.md
+++ b/docs/testclient.md
@@ -26,6 +26,37 @@ function calls, not awaitables.
You can use any of `requests` standard API, such as authentication, session
cookies handling, or file uploads.
+For example, to ... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "Documentation Updates"
} | |
deepspeedai__DeepSpeed-6797@4271737 | deepspeedai/DeepSpeed | Python | 6,797 | Fix uneven head sequence parallelism bug (#6774) | Here `gather_idx < 2` represents `is_first_all2all`. During the first all2all, `uneven_head_all2all` will be called if either `num_heads % seq_world_size != 0` or `get_num_kv_heads() is None`.
During the second all2all, it'll return return `uneven_head_all2all` if and only if `get_num_kv_heads() is None` which is a... | 2024-11-27T17:25:06Z | [BUG] [Fix Suggestion] Uneven head sequence parallelism
**Describe the bug**
deepspeed 0.15.4 will think you are using unevenhead SP even though you aren't and raise the following assert:
`assert num_heads > seq_world_size, f"Number of heads ({num_heads}) must be larger than sequence parallel size ({seq_world_size})"`... | Thank you @Eugene29 , yes, your analysis is correct. Would you mind sending a patch to fix it?
Commit explanation:
Here `gather_idx < 2` represents `is_first_all2all`. During the first all2all, `uneven_head_all2all` will be called if either `num_heads % seq_world_size != 0` or `get_num_kv_heads() is None`.
During th... | [
{
"body": "**Describe the bug**\n\ndeepspeed 0.15.4 will think you are using unevenhead SP even though you aren't and raise the following assert:\n`assert num_heads > seq_world_size, f\"Number of heads ({num_heads}) must be larger than sequence parallel size ({seq_world_size})\"`\n\nThis happens because during ... | 1b58ba5ec04493a112fae10d9cc9c824dfbd40ca | {
"head_commit": "42717372d362e3c127012527d91345544897c6c1",
"head_commit_message": "Fix uneven head sequence parallelism bug (#6774)",
"patch_to_review": "diff --git a/deepspeed/sequence/layer.py b/deepspeed/sequence/layer.py\nindex 8fd3ca918433..7a16592cbf30 100644\n--- a/deepspeed/sequence/layer.py\n+++ b/deep... | [
{
"diff_hunk": "@@ -155,7 +155,7 @@ def single_all_to_all(input, scatter_idx, gather_idx, batch_dim_idx, group, asyn\n # we only need num_heads once\n num_heads = input.shape[2]\n \n- if get_num_kv_heads() is not None or num_heads % seq_world_size != 0:\n+ if get_num_kv_heads() is not None or (num... | 4fe7f577c1aeb687211b0d578f943a48f5bda328 | diff --git a/deepspeed/sequence/layer.py b/deepspeed/sequence/layer.py
index 3dfe149057e9..ccc43fdf7164 100644
--- a/deepspeed/sequence/layer.py
+++ b/deepspeed/sequence/layer.py
@@ -184,7 +184,7 @@ def single_all_to_all(input, scatter_idx, gather_idx, batch_dim_idx, group, asyn
# we only need num_heads once
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
deepspeedai__DeepSpeed-6863@9562b3e | deepspeedai/DeepSpeed | Python | 6,863 | Fix --enable_each_rank_log when used with PDSH multi-node runner | This PR addresses fixes https://github.com/microsoft/DeepSpeed/issues/6859 by threading this argument into the deepspeed launcher command build by PDSHRunner. | 2024-12-13T04:41:26Z | [BUG] deepspeed --enable_each_rank_log does not work in multi-node (PDSH) runs
**Describe the bug**
In a single-node training run, the command `deepspeed --enable_each_rank_log logdir <training command here>` will cause each rank to write its stderr/stdout to a unique file in logdir/
However, in a multinode training ... | The issue appears to me that in the PDSHRunner e.g. https://github.com/microsoft/DeepSpeed/blob/91829476a8fd4d0d9268c03c1d56795d20a51c12/deepspeed/launcher/multinode_runner.py#L99 we are reconstructing launcher args from the runner args, but several of the runner's args are not handled here (although they are supported... | [
{
"body": "**Describe the bug**\n\nIn a single-node training run, the command `deepspeed --enable_each_rank_log logdir <training command here>` will cause each rank to write its stderr/stdout to a unique file in logdir/\n\nHowever, in a multinode training run using the default launcher (PDSH) e.g. `deepspeed --... | da771ed42e41a44d5047813ca4672f1cfe9d1731 | {
"head_commit": "9562b3ed6611d7fa773d86a9b96bf8d82adcd8bc",
"head_commit_message": "fix",
"patch_to_review": "diff --git a/deepspeed/launcher/multinode_runner.py b/deepspeed/launcher/multinode_runner.py\nindex ce58deadc281..f584763e2e7d 100644\n--- a/deepspeed/launcher/multinode_runner.py\n+++ b/deepspeed/launch... | [
{
"diff_hunk": "@@ -104,6 +104,8 @@ def get_cmd(self, environment, active_resources):\n deepspeed_launch.append(\"--no_local_rank\")\n if self.args.save_pid:\n deepspeed_launch += [\"--save_pid\", f\"{os.getpid()}\"]\n+ if self.args.enable_each_rank_log:\n+ deep... | 1f95dde42bcbf5607483032e6355173492d84769 | diff --git a/deepspeed/launcher/multinode_runner.py b/deepspeed/launcher/multinode_runner.py
index 74d20a6d53e5..fe2fa1b476be 100644
--- a/deepspeed/launcher/multinode_runner.py
+++ b/deepspeed/launcher/multinode_runner.py
@@ -104,6 +104,8 @@ def get_cmd(self, environment, active_resources):
deepspeed_laun... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
deepspeedai__DeepSpeed-6976@a65d20c | deepspeedai/DeepSpeed | Python | 6,976 | Improve overflow handling in ZeRO | Fix #5241: Improve overflow handling
- [x] ZeRO 1
- [x] ZeRO 2
- [ ] ZeRO 3
- [ ] BF16Optimizer
Enable pydantic configuration for mixed precision
- [x] bf16
- [x] fp16
| 2025-01-28T21:24:04Z | [BUG] Zero2 offload overflow
**Describe the bug**
I have been able to run my model successfully in Zero Stage 3 without any problems. However, when I attempt to run the same model in Zero Stage 2, I encounter an error:
10.223.17.15: File "/opt/conda/envs/progen/lib/python3.8/site-packages/deepspeed/runtime/zero/sta... | Hi, can you please add a title?
I've encountered this bug too. After inspection, it feels to me the following implementation in the current stable release is related:
```python
#In deepspeed/runtime/zero/stage_1_and_2.py
def complete_grad_norm_calculation_for_cpu_offload(self, params):
total_norm = ... | [
{
"body": "**Describe the bug**\r\nI have been able to run my model successfully in Zero Stage 3 without any problems. However, when I attempt to run the same model in Zero Stage 2, I encounter an error:\r\n10.223.17.15: File \"/opt/conda/envs/progen/lib/python3.8/site-packages/deepspeed/runtime/zero/stage_1_... | bb293aea5d61198327f8d8956925ab754b747f44 | {
"head_commit": "a65d20c994d9e153b54bb66e5ce3e2462b70acb3",
"head_commit_message": "Merge branch 'master' into olruwase/ds_5241",
"patch_to_review": "diff --git a/deepspeed/runtime/bf16_optimizer.py b/deepspeed/runtime/bf16_optimizer.py\nindex 6b63efbb23f7..ba97e336a2bb 100644\n--- a/deepspeed/runtime/bf16_optim... | [
{
"diff_hunk": "@@ -80,7 +80,7 @@ def new_inference_container(self, orig_layer, policy_cls, layer_id):\n \n if self._config.fp16_enabled:",
"line": null,
"original_line": 81,
"original_start_line": null,
"path": "deepspeed/runtime/hybrid_engine.py",
"start_line": null,
"text": "@... | 99f356dddf23a39ab00ab8c73dddd791e2a2fde2 | diff --git a/deepspeed/runtime/bf16_optimizer.py b/deepspeed/runtime/bf16_optimizer.py
index c9337a795aea..cd00e9e43b00 100644
--- a/deepspeed/runtime/bf16_optimizer.py
+++ b/deepspeed/runtime/bf16_optimizer.py
@@ -37,6 +37,7 @@ class BF16_Optimizer(ZeROOptimizer):
def __init__(self,
init_optimiz... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
deepspeedai__DeepSpeed-4192@217911a | deepspeedai/DeepSpeed | Python | 4,192 | Allow modification of zero partitioned parameters | Utilities for flexible modification of partitioned fp32 parameters and optimizer states.
Fix #3830 | 2023-08-22T13:52:17Z | How to modify weights during training in a deepspeed stage 3 model
This issue is more of a general question than a bug report: we are working with deepspeed stage 3 and model parallelization (training 10+ billion params LLMs). We need to be able to modify weights every N steps during training, but outside of the regula... | @lucasosouza, thanks for your question. We have recently added supporting for examining various weight and optimizer state values, documented [here](https://deepspeed.readthedocs.io/en/latest/zero3.html#debugging). It sounds like you want the inverse functionality that can modify these values. Is that correct?
You mig... | [
{
"body": "This issue is more of a general question than a bug report: we are working with deepspeed stage 3 and model parallelization (training 10+ billion params LLMs). We need to be able to modify weights every N steps during training, but outside of the regular optimization process. \r\n\r\nI've seen multip... | 194b0043a9362e64e2de57c90f5e1e43805e0c7d | {
"head_commit": "217911a960ee7bfa13113d9566e89a59bdb0bee7",
"head_commit_message": "Merge branch 'master' into olruwase/ds_3830",
"patch_to_review": "diff --git a/deepspeed/runtime/zero/stage3.py b/deepspeed/runtime/zero/stage3.py\nindex 91524ba6cfb8..5dad5273a87d 100644\n--- a/deepspeed/runtime/zero/stage3.py\n... | [
{
"diff_hunk": "@@ -2122,36 +2123,57 @@ def get_fp32_grad_for_param(self, param) -> Tensor:\n \n if self.offload_optimizer:\n group_idx, dest_offset, num_elements = self.grad_position[self.get_param_id(param)]\n- fp32_grad = self.fp32_partitioned_groups_flat[group_idx].grad.narrow... | cee50aae76000a27627eb430db1546292cf33bc5 | diff --git a/deepspeed/runtime/zero/stage3.py b/deepspeed/runtime/zero/stage3.py
index bc581dc2215e..a4d79697a111 100644
--- a/deepspeed/runtime/zero/stage3.py
+++ b/deepspeed/runtime/zero/stage3.py
@@ -2101,16 +2101,17 @@ def get_fp32_grad_partitions(self) -> Dict[int, Dict[int, Tensor]]:
return grad_dict
... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
deepspeedai__DeepSpeed-4084@6448c51 | deepspeedai/DeepSpeed | Python | 4,084 | Fix Issue 4083 | Fix #4083 | 2023-08-03T19:02:42Z | [BUG] BF16 training with FP32 gradient accumulation - Zero Stage 1 CPU - DeepSpeedCPUAdam
I am trying to train a model with bf16, fp32 gradient accumulation and zero stage 1. Using DeepSpeedCPUAdam as optimizer.
**Config**
```json
{
"steps_per_print":10000,
"wall_clock_breakdown":true,
"train_ba... | [
{
"body": "I am trying to train a model with bf16, fp32 gradient accumulation and zero stage 1. Using DeepSpeedCPUAdam as optimizer. \r\n\r\n\r\n**Config**\r\n```json\r\n{\r\n \"steps_per_print\":10000,\r\n \"wall_clock_breakdown\":true,\r\n \"train_batch_size\": 1024,\r\n \"gradient_accumulation_s... | 975bcbc0bdec3df7830f95f54906d904aa8add78 | {
"head_commit": "6448c514baca73a85356637c09374ba518918d98",
"head_commit_message": "removing bad check",
"patch_to_review": "diff --git a/deepspeed/runtime/engine.py b/deepspeed/runtime/engine.py\nindex cc25ce69802c..0b2a713921bc 100644\n--- a/deepspeed/runtime/engine.py\n+++ b/deepspeed/runtime/engine.py\n@@ -1... | [
{
"diff_hunk": "@@ -1137,10 +1137,6 @@ def _do_optimizer_sanity_check(self, basic_optimizer):\n \n if self.global_rank == 0:\n logger.warning(\"**** You are using ZeRO with an untested optimizer, proceed with caution *****\")\n-\n- if model_dtype == torch.bfloat16 ... | 42c5381d1a16c6bdf0fbc56175c2a9f23f6f0b78 | diff --git a/deepspeed/runtime/engine.py b/deepspeed/runtime/engine.py
index cc25ce69802c..5e5f97283267 100644
--- a/deepspeed/runtime/engine.py
+++ b/deepspeed/runtime/engine.py
@@ -1137,9 +1137,8 @@ def _do_optimizer_sanity_check(self, basic_optimizer):
if self.global_rank == 0:
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
deepspeedai__DeepSpeed-5811@20caf04 | deepspeedai/DeepSpeed | Python | 5,811 | Update linear.py compatible with torch 2.4.0 | deepspeed/runtime/zero/linear.py:67: FutureWarning: `torch.cuda.amp.custom_bwd(args...)` is deprecated. Please use `torch.amp.custom_bwd(args..., device_type='cuda')` instead.
Fixes: #5682 | 2024-07-30T13:43:20Z | [BUG] Logs full of FutureWarning when training with nightly PyTorch
**Describe the bug**
When training with nightly PyTorch, the logs are full of deprecation warnings like this:
```
/home/alyssavance/miniforge3/envs/brr/lib/python3.10/site-packages/deepspeed/runtime/zero/linear.py:49: FutureWarn\
ing: `torch.cuda... | Thanks @rosario-purple, we will take a look at these | [
{
"body": "**Describe the bug**\r\nWhen training with nightly PyTorch, the logs are full of deprecation warnings like this:\r\n\r\n```\r\n/home/alyssavance/miniforge3/envs/brr/lib/python3.10/site-packages/deepspeed/runtime/zero/linear.py:49: FutureWarn\\\r\ning: `torch.cuda.amp.custom_fwd(args...)` is deprecate... | 01fe65b300c665567d365646effe490f3316fdf4 | {
"head_commit": "20caf0414a6eebfe2f620b6955f8378367fe5a9e",
"head_commit_message": "Merge branch 'master' into torch2.4.0-amp-futurewarning-patch",
"patch_to_review": "diff --git a/deepspeed/runtime/zero/linear.py b/deepspeed/runtime/zero/linear.py\nindex e9dd78864cde..7091371cebe0 100644\n--- a/deepspeed/runtim... | [
{
"diff_hunk": "@@ -33,8 +34,8 @@ def print_rank_0(message, debug=False, force=False):\n \n \n try:\n- autocast_custom_fwd = get_accelerator().amp().custom_fwd\n- autocast_custom_bwd = get_accelerator().amp().custom_bwd\n+ autocast_custom_fwd = functools.partial(torch.amp.custom_fwd, device_type=get_ac... | a9f7ae294f7ad9cebda47f05369ce0e7285671e1 | diff --git a/deepspeed/runtime/zero/linear.py b/deepspeed/runtime/zero/linear.py
index e9dd78864cde..8c8db60768eb 100644
--- a/deepspeed/runtime/zero/linear.py
+++ b/deepspeed/runtime/zero/linear.py
@@ -16,6 +16,7 @@
#when implemented outside of torch.autograd.Function
import math
+import functools
import torch
... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
encode__starlette-1388@17fa3b8 | encode/starlette | Python | 1,388 | Add `WebSocketRoute` docs in `Routing` | Closes #764 .
Currently we have two examples of `WebSocketRoute` in applications and endpoints, but they don't document the `WebSocketRoute`.
I've included the `endpoint` argument in the docs and pointed general features like Path Parameters, Reverse URL Lookups and etc. to the Route docs.
| 2021-12-28T10:27:09Z | WebSocketRoute undocumented
The "routing" docs page doesn't mention that `Route()` is for HTTP only and `WebSocketRoute()` is required for websocket endpoints. I found `WebSocketRoute` through examples on other pages but it woudl be good if it was fully described on the "routing" page. | [
{
"body": "The \"routing\" docs page doesn't mention that `Route()` is for HTTP only and `WebSocketRoute()` is required for websocket endpoints. I found `WebSocketRoute` through examples on other pages but it woudl be good if it was fully described on the \"routing\" page.",
"number": 764,
"title": "Web... | 9a55ac891d7399a305cbea3facd9f232be05e9e1 | {
"head_commit": "17fa3b8065a18772ac215db7b33b1c4b9372b3fa",
"head_commit_message": "Add WebSocketRoute docs",
"patch_to_review": "diff --git a/docs/routing.md b/docs/routing.md\nindex f19c57b70..10cd04724 100644\n--- a/docs/routing.md\n+++ b/docs/routing.md\n@@ -1,3 +1,5 @@\n+## HTTP Routing\n+\n Starlette has a... | [
{
"diff_hunk": "@@ -262,3 +263,42 @@ app = Router(routes=[\n ])\n ])\n ```\n+\n+## WebSocket Routing\n+\n+When working with WebSocket endpoints, you should use `WebSocketRoute`\n+instead of the usual `Route`.\n+\n+Path parameters, and reverse URL lookups for `WebSocketRoute` work the the same\n+as HTTP `Rou... | 60a7bb325702534adc23b7b8cb3c6ea14d7aeb68 | diff --git a/docs/routing.md b/docs/routing.md
index f19c57b70..f0b672d8a 100644
--- a/docs/routing.md
+++ b/docs/routing.md
@@ -1,3 +1,5 @@
+## HTTP Routing
+
Starlette has a simple but capable request routing system. A routing table
is defined as a list of routes, and passed when instantiating the application.
@@... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "Documentation Updates"
} | |
deepspeedai__DeepSpeed-3399@09919e3 | deepspeedai/DeepSpeed | Python | 3,399 | Add ZeRO 1 support to PP for BF16. | Addressing issue #2994 | 2023-04-27T20:43:14Z | [BUG] Does bf16 support Zero stage 1 with pipeline?
**Describe the bug**
I'm using Deepspeed-Megatron although, using pipeline parallelism and setting
```
"bf16": {
"enabled": "auto"
}
```
will step into the `NotImplementedError` in
```python
#/opt/conda/lib/python3.8/site-packages/deepspeed/runtime/p... | @lyj201002, thanks for reporting this bug. We are working on a fix. | [
{
"body": "**Describe the bug**\r\nI'm using Deepspeed-Megatron although, using pipeline parallelism and setting \r\n```\r\n\"bf16\": {\r\n \"enabled\": \"auto\"\r\n }\r\n```\r\nwill step into the `NotImplementedError` in \r\n```python\r\n#/opt/conda/lib/python3.8/site-packages/deepspeed/runtime/pipe/engin... | 52d7e80aace514fa22dcc596fcdc0c37162b003b | {
"head_commit": "09919e343aeb696ffa99dd836c077f467238d27d",
"head_commit_message": "Add ZeRO 1 support to PP for BF16.",
"patch_to_review": "diff --git a/deepspeed/runtime/pipe/engine.py b/deepspeed/runtime/pipe/engine.py\nindex f3370cd0e908..d9d04675b84b 100644\n--- a/deepspeed/runtime/pipe/engine.py\n+++ b/dee... | [
{
"diff_hunk": "@@ -241,11 +241,10 @@ def _exec_reduce_grads(self):\n self._force_grad_boundary = True\n if self.pipeline_enable_backward_allreduce:\n if self.bfloat16_enabled():\n- if self.zero_optimization_stage() == 0:\n+ if self.zero_optimization_sta... | aab125ffb8957d1f0d94b2964a9785cc95cac869 | diff --git a/deepspeed/runtime/pipe/engine.py b/deepspeed/runtime/pipe/engine.py
index 7923313eeb28..367932a95d28 100644
--- a/deepspeed/runtime/pipe/engine.py
+++ b/deepspeed/runtime/pipe/engine.py
@@ -15,6 +15,7 @@
from ..engine import DeepSpeedEngine, MEMORY_OPT_ALLREDUCE_SIZE
from ..utils import PartitionedTensor... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
encode__starlette-1366@b13d841 | encode/starlette | Python | 1,366 | fix: pass usedforsecurity to hashlib.md5 to fix error on FIPS-enabled systems | Closes #1365 | 2021-12-15T15:50:58Z | ETag checksum fails on FIPS-enabled systems when using MD5
### Checklist
<!-- Please make sure you check all these items before submitting your bug report. -->
- [x] The bug is reproducible against the latest release and/or `master`.
- [x] There are no similar issues or pull requests to fix it yet.
### Descri... | `nginx` uses the following logic:
> Unit’s ETag response header fields use the `MTIME-FILESIZE` format, where `MTIME` stands for file modification timestamp and `FILESIZE` stands for file size in bytes, both in hexadecimal.
Ref.: https://unit.nginx.org/configuration/#static-files
I've found [this](http://blog.... | [
{
"body": "### Checklist\r\n\r\n<!-- Please make sure you check all these items before submitting your bug report. -->\r\n\r\n- [x] The bug is reproducible against the latest release and/or `master`.\r\n- [x] There are no similar issues or pull requests to fix it yet.\r\n\r\n### Describe the bug\r\n\r\nThe ETag... | 58a104e481fbb2ee562c686d5f3a9148c51452ac | {
"head_commit": "b13d8411f07c19af692d3068e394f245571f3e7f",
"head_commit_message": "Merge branch 'master' into 1365-use-usedforsecurity-parameter",
"patch_to_review": "diff --git a/starlette/_crypto.py b/starlette/_crypto.py\nnew file mode 100644\nindex 000000000..a9a36a1b2\n--- /dev/null\n+++ b/starlette/_crypt... | [
{
"diff_hunk": "@@ -12,6 +11,7 @@\n \n import anyio\n \n+from starlette._crypto import md5_hexdigest",
"line": null,
"original_line": 14,
"original_start_line": null,
"path": "starlette/responses.py",
"start_line": null,
"text": "@author:\nI made this a \"private\" module. I know there i... | 7a050f4097c21b6b2a0e2948f56d0c6f1a81c17a | diff --git a/starlette/_compat.py b/starlette/_compat.py
new file mode 100644
index 000000000..82aa72f38
--- /dev/null
+++ b/starlette/_compat.py
@@ -0,0 +1,26 @@
+import hashlib
+
+# Compat wrapper to always include the `usedforsecurity=...` parameter,
+# which is only added from Python 3.9 onwards.
+# We use this fla... | {
"difficulty": "low",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
encode__starlette-1349@54d89af | encode/starlette | Python | 1,349 | Raise a more obvious exception when form data is missing "boundary". | The best strategy is to let KeyError raise when parsing request with missing boundary parameter, so end-user can process KeyError exception in their code.
Closes #1125
Related to #1303 | 2021-11-29T17:48:41Z | Insufficient input validation of content-type 'multipart/form-data'
### Checklist
- [x] The bug is reproducible against the latest release and/or `master`.
- [x] There are no similar issues or pull requests to fix it yet.
### Describe the bug
Not actually a bug, but insufficient input validation.
### To re... | I think this can be considered a bug, because we send 500 instead of 4xx, and you're right: this is actually a client error.
I'd want to see **how other known web frameworks are handling this**, if possible, but the PR is welcome.
Flask uses werkzeug's FormDataParser with the following code:
```python
bou... | [
{
"body": "### Checklist\r\n\r\n- [x] The bug is reproducible against the latest release and/or `master`.\r\n- [x] There are no similar issues or pull requests to fix it yet.\r\n\r\n### Describe the bug\r\n\r\nNot actually a bug, but insufficient input validation.\r\n\r\n### To reproduce\r\n\r\nProvide POST inp... | f12c92a21500d484b3d48f965bb605c1bbe193bc | {
"head_commit": "54d89af28b8a3dad3f83e21aa6cdef871caf8c6d",
"head_commit_message": "Linting fix.",
"patch_to_review": "diff --git a/starlette/formparsers.py b/starlette/formparsers.py\nindex decaf0bfd..fd1949229 100644\n--- a/starlette/formparsers.py\n+++ b/starlette/formparsers.py\n@@ -159,7 +159,7 @@ async def... | [
{
"diff_hunk": "@@ -386,3 +388,20 @@ def test_user_safe_decode_helper():\n def test_user_safe_decode_ignores_wrong_charset():\n result = _user_safe_decode(b\"abc\", \"latin-8\")\n assert result == \"abc\"\n+\n+\n+def test_missing_boundary_parameter(test_client_factory):\n+ client = test_client_factor... | cc0daefee73f667daca58954fd98d870d9ee4232 | diff --git a/starlette/formparsers.py b/starlette/formparsers.py
index decaf0bfd..fd1949229 100644
--- a/starlette/formparsers.py
+++ b/starlette/formparsers.py
@@ -159,7 +159,7 @@ async def parse(self) -> FormData:
charset = params.get(b"charset", "utf-8")
if type(charset) == bytes:
char... | {
"difficulty": "medium",
"estimated_review_effort": 2,
"problem_domain": "Security Patches / Vulnerability Fixes"
} |
deepspeedai__DeepSpeed-1637@f40e230 | deepspeedai/DeepSpeed | Python | 1,637 | Fix cpu-adam AVX performance | This fixes https://github.com/microsoft/DeepSpeed/issues/1635 | 2021-12-14T22:43:22Z | [BUG] CPU adam too slow even with AVX512
**Describe the bug**
Optimizer step is taking unexpectedly long. I am running a GPT-like model with 1.35B parameters with ZeRO-3, optimizer CPU offload enabled.
I have added extra timers to measure exact timing for optimizer step:
```
time (ms) | update_optims: 21766.25... | I meet the same problem in DeepSpeedExamples
https://github.com/microsoft/DeepSpeedExamples/issues/151
Hi @PeiqiWang, @nobellant215
Thanks for reporting this issue. I will look into this.
@PeiqiWang, can I ask what model-size you were using in your experiments?
@nobellant215, the difference that you mentione... | [
{
"body": "**Describe the bug**\r\nOptimizer step is taking unexpectedly long. I am running a GPT-like model with 1.35B parameters with ZeRO-3, optimizer CPU offload enabled.\r\n\r\nI have added extra timers to measure exact timing for optimizer step:\r\n\r\n```\r\n time (ms) | update_optims: 21766.25 | unscale... | 082f392a939896e2fef782eabee2200b5e340902 | {
"head_commit": "f40e23083c3d59763f147a7f0c07bd9a2a4b0154",
"head_commit_message": "fixing the loop-unrolling for the avx operations",
"patch_to_review": "diff --git a/csrc/includes/simd.h b/csrc/includes/simd.h\nindex 216d281a2672..44c4da83e01c 100644\n--- a/csrc/includes/simd.h\n+++ b/csrc/includes/simd.h\n@@ ... | [
{
"diff_hunk": "@@ -146,6 +146,31 @@ def _transpose_for_context(x):\n (hidden_size_per_partition,)\n return x.view(*new_x_layer_shape)\n \n+ def backup_attention(mixed_query, key_layer, value_layer, input_mask):",
"line": null,
"original_line": 14... | 80b184e7a8ec8d43100f705363f20fb809056c22 | diff --git a/csrc/includes/simd.h b/csrc/includes/simd.h
index 216d281a2672..44c4da83e01c 100644
--- a/csrc/includes/simd.h
+++ b/csrc/includes/simd.h
@@ -60,7 +60,7 @@ union AVX_Data {
template <int span>
inline void simd_store(float* dst, AVX_Data* src, bool half_precision)
{
-#pragma omp parallel for
+#pragma unr... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Performance Optimizations"
} |
encode__starlette-1345@254b66f | encode/starlette | Python | 1,345 | Change default chunk size from 4Kb to 64Kb | - Closes https://github.com/encode/starlette/issues/1100
@tomchristie On that issue, you said that "httpx uses 64k read size", but I couldn't find that. Do you mind pointing me out what did you mean? | 2021-11-27T15:03:48Z | Make FileResponse.chunk_size variable
`FileResponse.chunk_size` is currently hardcoded to 4096. I was testing file transfer and noticed rather slow speeds compared to using scp to get the file. I increased the chunk_size and saw the speeds I was expecting. This should be configurable from `FileResponse.__init__`. | Rather than making it configurable, I'd suggest we start by just improving the default. HTTPX uses 64k read sizes, which we selected based on actual download speed data. That's probably a better starting point for Starlette's file responses too.
Hi, I found the same issue when I'm using FastAPI. Do you have a plan to c... | [
{
"body": "`FileResponse.chunk_size` is currently hardcoded to 4096. I was testing file transfer and noticed rather slow speeds compared to using scp to get the file. I increased the chunk_size and saw the speeds I was expecting. This should be configurable from `FileResponse.__init__`.",
"number": 1100,
... | 10529a3b39e2db21b03600991117c564332f31d2 | {
"head_commit": "254b66fb2ba70fc231367e2da09a8ee6a7cb3720",
"head_commit_message": "Merge branch 'master' into change-default-chunk-size",
"patch_to_review": "diff --git a/starlette/responses.py b/starlette/responses.py\nindex 9dbe03beb..a4f750677 100644\n--- a/starlette/responses.py\n+++ b/starlette/responses.p... | [
{
"diff_hunk": "@@ -248,7 +248,7 @@ async def wrap(func: typing.Callable[[], typing.Coroutine]) -> None:\n \n \n class FileResponse(Response):\n- chunk_size = 4096\n+ chunk_size = 65536",
"line": null,
"original_line": 251,
"original_start_line": null,
"path": "starlette/responses.py",
... | ded8d206f953298509837671327b1475e733ee77 | diff --git a/starlette/responses.py b/starlette/responses.py
index 9dbe03beb..1f9c43a21 100644
--- a/starlette/responses.py
+++ b/starlette/responses.py
@@ -248,7 +248,7 @@ async def wrap(func: typing.Callable[[], typing.Coroutine]) -> None:
class FileResponse(Response):
- chunk_size = 4096
+ chunk_size = 64... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "Performance Optimizations"
} |
encode__starlette-1218@1e375b4 | encode/starlette | Python | 1,218 | Make Jinja2Templates.get_env private & rename | Closes #1194. | 2021-06-26T06:35:57Z | Consider making `starlette.templating.Jinja2Templates.get_env` "protected"
Hi,
Thank you very much for your project! We are using it intensively through FastAPI.
While I was exploring the code base and looking how to use `Jinja2Templates`, I noticed the method `get_env`. At first I thought it was a getter for the e... | [
{
"body": "Hi,\r\nThank you very much for your project! We are using it intensively through FastAPI.\r\n\r\nWhile I was exploring the code base and looking how to use `Jinja2Templates`, I noticed the method `get_env`. At first I thought it was a getter for the environment, but eventually realized it is only cal... | 66266369bba14613295f5320e4ab01b1524d4b83 | {
"head_commit": "1e375b4d10e3b07ae713515dfe32d109cbc9c19b",
"head_commit_message": "make-jinja2-get-env-internal",
"patch_to_review": "diff --git a/starlette/templating.py b/starlette/templating.py\nindex 64fdbd14f..d80f31673 100644\n--- a/starlette/templating.py\n+++ b/starlette/templating.py\n@@ -56,9 +56,9 @@... | [
{
"diff_hunk": "@@ -56,9 +56,9 @@ class Jinja2Templates:\n \n def __init__(self, directory: str) -> None:\n assert jinja2 is not None, \"jinja2 must be installed to use Jinja2Templates\"\n- self.env = self.get_env(directory)\n+ self.env = self._get_env(directory)\n \n- def get_env(s... | 4878ba1a48d9db1593bc93b5adabd61e60e96d73 | diff --git a/starlette/templating.py b/starlette/templating.py
index 64fdbd14f..36f613fdf 100644
--- a/starlette/templating.py
+++ b/starlette/templating.py
@@ -56,9 +56,9 @@ class Jinja2Templates:
def __init__(self, directory: str) -> None:
assert jinja2 is not None, "jinja2 must be installed to use Ji... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "Code Refactoring / Architectural Improvement"
} | |
deepspeedai__DeepSpeed-2727@6acbd53 | deepspeedai/DeepSpeed | Python | 2,727 | Enable tensor fragments for zero 2 & 3 | Enable tensor fragmentation in zero stage 2 & 3
Fix #2290
TODO:
test w/ offload (at least cpu to start with)
test w/o offload | 2023-01-20T01:18:21Z | [REQUEST] individual tensor `.grad` getter/setter for flattened tensors
As we know DS flattens individual tensors by optim groups so that each tensor and its attributes can't be accessed by the user once the ds engine takes over.
As @tjruwase is working on the API used by the universal checkpoint to get/set fragment... | [
{
"body": "As we know DS flattens individual tensors by optim groups so that each tensor and its attributes can't be accessed by the user once the ds engine takes over.\r\n\r\nAs @tjruwase is working on the API used by the universal checkpoint to get/set fragments of data/grads/optim states across multiple gpus... | da84e60d98d2e90f6f2094a219c98c8b41582eb9 | {
"head_commit": "6acbd537e48c5419ea024c916ef1072738a31b8e",
"head_commit_message": "Update deepspeed/utils/tensor_fragment.py\n\nCo-authored-by: Stas Bekman <stas00@users.noreply.github.com>",
"patch_to_review": "diff --git a/deepspeed/runtime/zero/stage_1_and_2.py b/deepspeed/runtime/zero/stage_1_and_2.py\ninde... | [
{
"diff_hunk": "@@ -58,9 +61,59 @@ def get_full_hp_param(self, optim_state_key=None):\n return reduce_buffer.reshape_as(self)\n \n \n+def safe_get_full_fp32_param(param):\n+ if hasattr(param, '_hp_mapping'):\n+ return param.get_full_hp_param()\n+ return None\n+\n+\n+def safe_get_full_optimizer_... | 84450f3a1140aa04b544cb3b2208cb4bbeb1c147 | diff --git a/deepspeed/runtime/bf16_optimizer.py b/deepspeed/runtime/bf16_optimizer.py
index 49c51fa7c91f..f667d279ca54 100644
--- a/deepspeed/runtime/bf16_optimizer.py
+++ b/deepspeed/runtime/bf16_optimizer.py
@@ -79,6 +79,7 @@ def __init__(self,
# Maintain different fp32 gradients views for convenience
... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
deepspeedai__DeepSpeed-896@5002e49 | deepspeedai/DeepSpeed | Python | 896 | fix cpu_adam memory leak on deepspeed re-use in the same process | As reported in https://github.com/microsoft/DeepSpeed/issues/879 currently deepspeed leaks some 8GB general RAM when re-running `deepspeed.initialize` in the same process (notebook or pytest worker). There is no problem with one `deepspeed.initialize` per process, since the memory is reclaimed on process exit.
Wit... | 2021-03-27T04:39:25Z | memory leak in an environment like notebook
In HF/DS tests I use a notebook-like environment for some of the tests, which means I don't fork a new process for each deepspeed run, but emulate the distributed env in the process and repeatedly run deepspeed. This makes it much easier/faster to test the values of the weigh... | [
{
"body": "In HF/DS tests I use a notebook-like environment for some of the tests, which means I don't fork a new process for each deepspeed run, but emulate the distributed env in the process and repeatedly run deepspeed. This makes it much easier/faster to test the values of the weights.\r\n\r\nThere must be ... | 6d94afb5487be2861e948d1198f42fcbdeab36e4 | {
"head_commit": "5002e499f63ba51ab48d744bebdef18e54de9746",
"head_commit_message": "receivet the optimizer Id from client side when running step (Default=0)",
"patch_to_review": "diff --git a/csrc/adam/cpu_adam.cpp b/csrc/adam/cpu_adam.cpp\nindex d425dc3169ef..bb6bd13c0c77 100644\n--- a/csrc/adam/cpu_adam.cpp\n+... | [
{
"diff_hunk": "@@ -96,7 +96,7 @@ def __setstate__(self, state):\n group.setdefault('amsgrad', False)\r\n \r\n @torch.no_grad()\r\n- def step(self, closure=None, fp16_param_groups=None):\r\n+ def step(self, optId=0, closure=None, fp16_param_groups=None):\r",
"line": null,
"original... | a4bbadfea5c368b02b68d63ce421146e24990a66 | diff --git a/csrc/adam/cpu_adam.cpp b/csrc/adam/cpu_adam.cpp
index d425dc3169ef..6726b895f12c 100644
--- a/csrc/adam/cpu_adam.cpp
+++ b/csrc/adam/cpu_adam.cpp
@@ -672,6 +672,13 @@ int ds_adam_step_plus_copy(int optimizer_id,
return 0;
}
+int destroy_adam_optimizer(int optimizer_id)
+{
+ s_optimizers.era... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
deepspeedai__DeepSpeed-608@af733a9 | deepspeedai/DeepSpeed | Python | 608 | Ability to initialize distributed backend outside deepspeed runtime | * Refactor mpi and aml patching into deepspeed.utils.distributed
* Support calling `deepspeed.init_distributed()` outside deepspeed.initialize runtime. This is required to support building models that require torch distributed (e.g., model-parallelism). Currently running a model like megatron will break if using an mp... | 2020-12-17T19:33:17Z | WarmupDecayLR.params.total_num_steps - total or per gpu?
We are having a bit of hard time getting `total_num_steps` to pass to `WarmupDecayLR` at init time - it's a bit too early for the logic as these points are configured once ddp/ds has started - we found a workaround, but it doesn't take into the account the number... | [
{
"body": "We are having a bit of hard time getting `total_num_steps` to pass to `WarmupDecayLR` at init time - it's a bit too early for the logic as these points are configured once ddp/ds has started - we found a workaround, but it doesn't take into the account the number of gpus.\r\n\r\nI wanted to check tha... | fd2f970bdfd3eada289b4e19a3adcf2c352a4d8f | {
"head_commit": "af733a9292ff80da18627f336811b897d210c786",
"head_commit_message": "fix warnings in cluster install script",
"patch_to_review": "diff --git a/DeepSpeedExamples b/DeepSpeedExamples\nindex abb270641ca8..78d69cb2f89a 160000\n--- a/DeepSpeedExamples\n+++ b/DeepSpeedExamples\n@@ -1 +1 @@\n-Subproject ... | [
{
"diff_hunk": "@@ -0,0 +1,122 @@\n+'''\n+Copyright 2020 The Microsoft DeepSpeed Team\n+'''\n+import os\n+import torch\n+\n+from .logging import logger\n+from ..constants import TORCH_DISTRIBUTED_DEFAULT_PORT\n+\n+\n+def init_distributed(dist_backend=\"nccl\",\n+ auto_mpi_discovery=True,\n+ ... | 2df5aa94fae7c118bf8487b519393b7ae2d2be31 | diff --git a/DeepSpeedExamples b/DeepSpeedExamples
index abb270641ca8..78d69cb2f89a 160000
--- a/DeepSpeedExamples
+++ b/DeepSpeedExamples
@@ -1 +1 @@
-Subproject commit abb270641ca8c33476282bde29916c395a060ae9
+Subproject commit 78d69cb2f89a27b1e9b072df8c3e47d00c024fdc
diff --git a/deepspeed/__init__.py b/deepspeed/__... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Documentation Updates"
} | |
encode__starlette-1198@48bc30d | encode/starlette | Python | 1,198 | 🔥 Remove GraphQL support | This PR removes GraphQL entirely. I've assumed that we don't need to document the removal, just the CHANGELOG is enough (correct me otherwise).
The idea is to merge this PR before 1.0. There's no hurry on this, once we fulfill the other requirements, we can come back to this PR.
## Related issues
- Moving forwar... | 2021-06-11T18:21:43Z | GraphQL support should be a third party application.
I'd like our graphql support to move out into being a third party package.
We should then document:
* The third party package it's been moved to.
* Links to ASGI implementations with ariadne, tartiflette, strawberry.
Questions:
* Which of Ariadne, Tartif... | * Ariadne ASGI app: https://ariadnegraphql.org/docs/asgi
* Tatiflette: https://github.com/tartiflette/tartiflette-starlette
`strawberry` asgi app:
* https://github.com/strawberry-graphql/strawberry/blob/master/docs/05_integrations/asgi.md
> `strawberry` asgi app:
> * https://github.com/strawberry-graphql/strawberry... | [
{
"body": "I'd like our graphql support to move out into being a third party package.\r\n\r\nWe should then document:\r\n\r\n* The third party package it's been moved to.\r\n* Links to ASGI implementations with ariadne, tartiflette, strawberry.\r\n\r\nQuestions:\r\n\r\n* Which of Ariadne, Tartiflette & Strawber... | 6c556f6c5e4aa70173a84f6e6854390241231021 | {
"head_commit": "48bc30d11977c65c98d312ab7fc17c8ecfe86a60",
"head_commit_message": "Remove graphene dependency and add docs",
"patch_to_review": "diff --git a/README.md b/README.md\nindex 8eedea952..a7d94904d 100644\n--- a/README.md\n+++ b/README.md\n@@ -28,7 +28,6 @@ It is production-ready, and gives you the fo... | [
{
"diff_hunk": "@@ -24,8 +24,8 @@ xfail_strict=True\n filterwarnings=\n # Turn warnings that aren't filtered into exceptions\n error\n- # Deprecated GraphQL (including https://github.com/graphql-python/graphene/issues/1055)\n- ignore: GraphQLApp is deprecated and will be removed in a future releas... | 850c4559ed7f16cb7f41aff1367f7b90a32a3cc1 | diff --git a/README.md b/README.md
index 8eedea952..a7d94904d 100644
--- a/README.md
+++ b/README.md
@@ -28,7 +28,6 @@ It is production-ready, and gives you the following:
* Seriously impressive performance.
* WebSocket support.
-* GraphQL support.
* In-process background tasks.
* Startup and shutdown events.
* ... | {
"difficulty": "low",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
encode__starlette-867@c63f22f | encode/starlette | Python | 867 | Ignore malformed cookie | Fixes #866 | 2020-03-18T07:42:23Z | [bug] Invalid cookie name leads to exception
When handling a request with an invalid cookie name (does not conform to RFC2109) starlette raises an exception. i.e iam/cookiename
This is because Starlette uses Python's stdlib cookie library, which is very strict.
I do understand the strictness, but in real life scenari... | I’m always a bit wary of encouraging broken behaviors... Eg even Django just ignores invalid cookies, preventing developers from processing them: https://github.com/django/django/commit/30bdabb2b0
Can you solve your use case with a custom middleware that converts the broken cookie into a valid one?
> I’m always a bit ... | [
{
"body": "When handling a request with an invalid cookie name (does not conform to RFC2109) starlette raises an exception. i.e iam/cookiename\r\nThis is because Starlette uses Python's stdlib cookie library, which is very strict.\r\nI do understand the strictness, but in real life scenarios you receive such ma... | 0cb2d909a2a6d21219c66f8eec75a95f4b6d1c53 | {
"head_commit": "c63f22fecbdcb308fe55c3c824f8a798f7208f10",
"head_commit_message": "ignore malformed cookie instead of raising an exception",
"patch_to_review": "diff --git a/docs/requests.md b/docs/requests.md\nindex f0ffc66bf..a72cb75dc 100644\n--- a/docs/requests.md\n+++ b/docs/requests.md\n@@ -73,6 +73,8 @@ ... | [
{
"diff_hunk": "@@ -285,6 +285,23 @@ def test_request_cookies():\n assert response.text == \"Hello, cookies!\"\n \n \n+def test_invalid_cookie():\n+ async def app(scope, receive, send):\n+ request = Request(scope, receive)\n+ if not request.cookies:\n+ response = Response(\"ok\",... | 73225c3acce2c93dbbbca2e4d2acb9729f7d8e98 | diff --git a/docs/requests.md b/docs/requests.md
index f0ffc66bf..a72cb75dc 100644
--- a/docs/requests.md
+++ b/docs/requests.md
@@ -73,6 +73,8 @@ Cookies are exposed as a regular dictionary interface.
For example: `request.cookies.get('mycookie')`
+Cookies are ignored in case of an invalid cookie. (RFC2109)
+
##... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
ccxt__ccxt-26331@a67e804 | ccxt/ccxt | Python | 26,331 | fix(bitstamp): ws orders parsing | fix #26298 | 2025-07-02T15:11:55Z | Bitstamp: order updates are not handled and normalised correctly
### Operating System
_No response_
### Programming Languages
_No response_
### CCXT Version
4.4.91
### Description
I created a limit order and listening on watch_orders() separately. However, none of the fields `filled, remaining, status` ever bein... | [
{
"body": "### Operating System\n\n_No response_\n\n### Programming Languages\n\n_No response_\n\n### CCXT Version\n\n4.4.91\n\n### Description\n\nI created a limit order and listening on watch_orders() separately. However, none of the fields `filled, remaining, status` ever being populated irrespective if orde... | 1706586a9dcbcddc8d3be4dd353136039bf53f98 | {
"head_commit": "a67e804e3df4ecc9f6101bf1ed195aae32858fb2",
"head_commit_message": "fix(bitstamp): ws orders parsing",
"patch_to_review": "diff --git a/ts/src/pro/bitstamp.ts b/ts/src/pro/bitstamp.ts\nindex 9439a00bb4ce6..bd861267d226e 100644\n--- a/ts/src/pro/bitstamp.ts\n+++ b/ts/src/pro/bitstamp.ts\n@@ -6,6 +... | [
{
"diff_hunk": "@@ -330,30 +332,61 @@ export default class bitstamp extends bitstampRest {\n const subscription = this.safeValue (client.subscriptions, channel);\n const symbol = this.safeString (subscription, 'symbol');\n const market = this.market (symbol);\n+ order['event'] = t... | c9df67c0ca7c8517c71f3cdcce338ab6eeb0b94d | diff --git a/ts/src/pro/bitstamp.ts b/ts/src/pro/bitstamp.ts
index 9439a00bb4ce6..3b2f6f1556f8d 100644
--- a/ts/src/pro/bitstamp.ts
+++ b/ts/src/pro/bitstamp.ts
@@ -6,6 +6,7 @@ import { ArgumentsRequired, AuthenticationError } from '../base/errors.js';
import { ArrayCache, ArrayCacheBySymbolById } from '../base/ws/Cac... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
ccxt__ccxt-24347@981d95f | ccxt/ccxt | Python | 24,347 | feat(hyperliquid): update precision | - Applies the significant_digits rule to the market object price precision
- Prepares for the next hyperliquid network upgrade (see commented lines)
- Fixes #23516 | 2024-11-22T15:01:53Z | Hyperliquid decimal_to_precision not working properly
### Operating System
Linux, Windows
### Programming Languages
Python
### CCXT Version
4.3.87
### Description
Hello,
I think decimal_to_precision is not working properly with hyperliquid.
### Code
```
e = ccxt.hyperliquid()
await e.load_markets()
prin... | Hi @gaardiolor
`decimalToPrecision` is a unified method in the exchange, but you'll need to set the precision mode manually when using this function. I suggest using `amountToPrecision` or `priceToPrecision` for amount/price precision, as we've already used these in other functions.
Yeah, I'm passing it as a paramet... | [
{
"body": "### Operating System\n\nLinux, Windows\n\n### Programming Languages\n\nPython\n\n### CCXT Version\n\n4.3.87\n\n### Description\n\nHello, \r\n\r\nI think decimal_to_precision is not working properly with hyperliquid.\n\n### Code\n\n```\r\ne = ccxt.hyperliquid()\r\nawait e.load_markets()\r\nprint(e.pre... | 27635ce74b8deb1c8fe89f85ff3f25c1d7a4216a | {
"head_commit": "981d95f491b884ec45b2d81247f87cc1c0cb3350",
"head_commit_message": "Removed network upgrade comments\nRemoved unnecessary variable declaration",
"patch_to_review": "diff --git a/ts/src/hyperliquid.ts b/ts/src/hyperliquid.ts\nindex 96fbe0f1395a8..7722c3b120254 100644\n--- a/ts/src/hyperliquid.ts\n... | [
{
"diff_hunk": "@@ -1053,10 +1098,16 @@ export default class hyperliquid extends Exchange {\n \n priceToPrecision (symbol: string, price): string {\n const market = this.market (symbol);\n- // https://hyperliquid.gitbook.io/hyperliquid-docs/for-developers/api/tick-and-lot-size\n- const... | 6b805953d62facf7fad3c813d99f5f0cfd2e7887 | diff --git a/ts/src/hyperliquid.ts b/ts/src/hyperliquid.ts
index 96fbe0f1395a8..6fb0d2a38a851 100644
--- a/ts/src/hyperliquid.ts
+++ b/ts/src/hyperliquid.ts
@@ -2,7 +2,7 @@
// ---------------------------------------------------------------------------
import Exchange from './abstract/hyperliquid.js';
-import { Exc... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
deepspeedai__DeepSpeed-2847@f6f3672 | deepspeedai/DeepSpeed | Python | 2,847 | ZeRO Gradient Accumulation Dtype. | Fix #2352
Adding configurable gradient accumulation data type to all ZeRO stages.
Added two gradient attributes to the parameter object:
1. `param.grad_reduc`: Used only as a pointer to reference which gradient tensor should be used in reduction. The tensor object pointed to by this attribute is used in all reducti... | 2023-02-17T02:40:23Z | [REQUEST] BF16 mixed precision => grad accum in fp32
**Is your feature request related to a problem? Please describe.**
We have proven with the BLOOM training that BF16 is by far more superior for mixed precision training than FP16, using Megatron-Deepspeed
But the latter is very complex, it'd be much easier for ... | @tjruwase, would it be possible to implement this? We are ready to start using ZeRO-3/bf16 for the multi-modal training.
Thank you very much!
@stas00, is it better to close this or #2768? They are the same thing, right?
Hi Tunji - you're the owner so it's up to you to decide. The new one is a duplicate of this one,... | [
{
"body": "**Is your feature request related to a problem? Please describe.**\r\n\r\nWe have proven with the BLOOM training that BF16 is by far more superior for mixed precision training than FP16, using Megatron-Deepspeed\r\n\r\nBut the latter is very complex, it'd be much easier for folks to use standalone Ze... | c79a104cf589b5353f00b02bb06a1352c85148d6 | {
"head_commit": "f6f3672411ca3d4d63afd8d36e807858ef99c12c",
"head_commit_message": "Merge branch 'master' into jomayeri/new-zero-accum",
"patch_to_review": "diff --git a/deepspeed/runtime/engine.py b/deepspeed/runtime/engine.py\nindex 86daf283301b..875490ae4632 100644\n--- a/deepspeed/runtime/engine.py\n+++ b/de... | [
{
"diff_hunk": "@@ -833,6 +850,64 @@ def increment_value(dictionary, key):\n def overlapping_partition_gradients_reduce_epilogue(self):\n self.independent_gradient_partition_epilogue()\n \n+ # Set the accum grad pointer to the correct tensor\n+ def set_grad_accum(self, param):\n+ # Simp... | 8492da7de505d7c2ea3cfc724b4b7b2fd10ec704 | diff --git a/deepspeed/runtime/engine.py b/deepspeed/runtime/engine.py
index c28b7777efc4..0fda4c5406b3 100644
--- a/deepspeed/runtime/engine.py
+++ b/deepspeed/runtime/engine.py
@@ -1142,10 +1142,6 @@ def _do_optimizer_sanity_check(self, basic_optimizer):
if model_dtype == torch.bfloat16 and grad_accum_dt... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
ccxt__ccxt-23317@b907a68 | ccxt/ccxt | Python | 23,317 | feat(yobit) - fetchTickers all | fix #5519
this exchange was exceptional and was a burden to get all tickers, so like we have `paginateAll` for convenience. takes some time to fetch all of them, but is still a helpful for users whoever use this exchange
(can't add static tests because of multiple url requested) | 2024-08-03T08:31:49Z | YoBit fetchTickers() & fetchOrderBooks() returning "empty pair list"
- CCXT version: 1.18.941
- Exchange: YoBit
- Method: fetchOrderBooks
YoBit accepts multiple pairs when accessing the depth endpoint, but the number of pairs accepted seems undefined. When calling fetchOrderBooks with up to 40 pairs, YoBit returns... | I have the same problem with the `fetch_tickers()` method.
I'm using custom `MyYoBit` class and this approach should work for `fetchOrderBooks()` too.
Maybe it can be implemented in ccxt library to improve unification.
```
from ccxt import yobit
class MyYoBit(yobit):
def __init__(self):
yobit... | [
{
"body": "- CCXT version: 1.18.941\r\n- Exchange: YoBit\r\n- Method: fetchOrderBooks\r\n\r\nYoBit accepts multiple pairs when accessing the depth endpoint, but the number of pairs accepted seems undefined. When calling fetchOrderBooks with up to 40 pairs, YoBit returns the orderbook with no problems. If reques... | fdb6587f05220ab46beab3047b40916a077877e5 | {
"head_commit": "b907a687faf6e89f05affa0ae9e5be409799520a",
"head_commit_message": "rename to avoid a clash in php",
"patch_to_review": "diff --git a/ts/src/test/static/request/yobit.json b/ts/src/test/static/request/yobit.json\nindex 0c7ffbb220654..26420308a156e 100644\n--- a/ts/src/test/static/request/yobit.js... | [
{
"diff_hunk": "@@ -127,6 +127,18 @@\n \"ETH/USDT\"\n ]\n ]\n+ },\n+ {\n+ \"disabled\": true,\n+ \"description\": \"all tickers\",\n+ \"method\": \"fetchTickers\",",
"line": null,
... | 23d97a9c684ce8cf59e1f00c077af063c20cc1d3 | diff --git a/ts/src/yobit.ts b/ts/src/yobit.ts
index 34b956d1d6a29..111b8ad51bb3e 100644
--- a/ts/src/yobit.ts
+++ b/ts/src/yobit.ts
@@ -555,6 +555,23 @@ export default class yobit extends Exchange {
}, market);
}
+ async fetchTickersHelper (idsString: string, params = {}): Promise<Tickers> {
+ ... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
ccxt__ccxt-23244@68d48cf | ccxt/ccxt | Python | 23,244 | fix(hyperliquid): set default limit to 5000 | fix ccxt/ccxt#23243
@carlosmiei The source data would sort by timestamp ascending order. Hdyt we cut the data by the limit first and call parseOHLCVS in hyperliquid? In this PR, I increase the default limit to 5000.
eg.
```
# the limit is 100
[
// 4900 OHLCV
// cut from here
// the latest 100 OHLCV
]... | 2024-07-29T03:13:14Z | Hyperliquid fetch_ohlcv limit issue
### Operating System
N/A
### Programming Languages
Python
### CCXT Version
4.3.67
### Description
Hello,
The Hyperliquid api returns the most recent 5000 candles. However, in ccxt `hyperliquid.py` the default limit is set to 500, which makes it output the first 500 of the m... | @gaardiolor Thanks for the report. I think they update documentation and api quickly https://web.archive.org/web/20240321075443/https://hyperliquid.gitbook.io/hyperliquid-docs/for-developers/api/info-endpoint#retrieve-a-users-fills (didn't mention a couple of months ago), the data was cut. The limit probably worked be... | [
{
"body": "### Operating System\n\nN/A\n\n### Programming Languages\n\nPython\n\n### CCXT Version\n\n4.3.67\n\n### Description\n\nHello,\r\n\r\nThe Hyperliquid api returns the most recent 5000 candles. However, in ccxt `hyperliquid.py` the default limit is set to 500, which makes it output the first 500 of the ... | fe6e5f994246dab8fd3a2f5f6ef068cc046a10f3 | {
"head_commit": "68d48cf500e0ee10b234260aebf19deeb99d4f01",
"head_commit_message": "fix(hyperliquid): set default limit to 5000",
"patch_to_review": "diff --git a/ts/src/hyperliquid.ts b/ts/src/hyperliquid.ts\nindex 43d8a3f0df2a4..92859c21ef7f8 100644\n--- a/ts/src/hyperliquid.ts\n+++ b/ts/src/hyperliquid.ts\n@@... | [
{
"diff_hunk": "@@ -848,7 +848,8 @@ export default class hyperliquid extends Exchange {\n since = 0;\n }\n if (limit === undefined) {\n- limit = 500;\n+ // Only the most recent 5000 candles are available\n+ limit = 5000;",
"line": null,
"origi... | 811b2c623edc265072d1531cebfcbd4fa4a6823d | diff --git a/ts/src/hyperliquid.ts b/ts/src/hyperliquid.ts
index 43d8a3f0df2a4..61916394a6760 100644
--- a/ts/src/hyperliquid.ts
+++ b/ts/src/hyperliquid.ts
@@ -847,9 +847,6 @@ export default class hyperliquid extends Exchange {
if (since === undefined) {
since = 0;
}
- if (limit =... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
ccxt__ccxt-22679@d6fcd92 | ccxt/ccxt | Python | 22,679 | fix(kraken): div trading fee by 100 | fix: ccxt/ccxt#22675
In this PR, I divide current fee by 100 in kraken.
> Note: I always got this error from kraken `{"error":["EAPI:Invalid nonce"]}`. Could someone have working key try this PR? | 2024-05-31T02:32:31Z | Kraken: trading fee is returned as percentage and not as ratio
### Operating System
Ubuntu
### Programming Languages
JavaScript
### CCXT Version
4.3.30
### Description
When loading the trading fees using fetchTradingFee() on Kraken, the fees are returned as percentages and not divided by 100. For a normalized ex... | [
{
"body": "### Operating System\n\nUbuntu\n\n### Programming Languages\n\nJavaScript\n\n### CCXT Version\n\n4.3.30\n\n### Description\n\nWhen loading the trading fees using fetchTradingFee() on Kraken, the fees are returned as percentages and not divided by 100. For a normalized experience I believe the rates s... | e0b01345708841b4a942477c7a4827b343721f2a | {
"head_commit": "d6fcd92df42e18697d01781aed74e51c5ffbeaf0",
"head_commit_message": "fix(kraken): div trading fee by 100",
"patch_to_review": "diff --git a/ts/src/kraken.ts b/ts/src/kraken.ts\nindex 42f962a930392..f9ca26f1422aa 100644\n--- a/ts/src/kraken.ts\n+++ b/ts/src/kraken.ts\n@@ -767,8 +767,8 @@ export def... | [
{
"diff_hunk": "@@ -767,8 +767,8 @@ export default class kraken extends Exchange {\n return {\n 'info': response,\n 'symbol': market['symbol'],\n- 'maker': this.safeNumber (symbolMakerFee, 'fee'),\n- 'taker': this.safeNumber (symbolTakerFee, 'fee'),\n+ ... | dfe42110db0d1e29ce30bf93e81b58515e9042d1 | diff --git a/ts/src/kraken.ts b/ts/src/kraken.ts
index 42f962a930392..fb6c12628d2bd 100644
--- a/ts/src/kraken.ts
+++ b/ts/src/kraken.ts
@@ -767,8 +767,8 @@ export default class kraken extends Exchange {
return {
'info': response,
'symbol': market['symbol'],
- 'maker': this... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} | |
ccxt__ccxt-22786@5420d03 | ccxt/ccxt | Python | 22,786 | fix(bitmex): guard handleOrderBook | fix: ccxt/ccxt#22769 | 2024-06-11T13:35:14Z | BitMEX - watch_order_book error once a day - safe_string default value NoneType and operation of return is to append a string
### Operating System
Ubuntu 20.04
### Programming Languages
Python
### CCXT Version
4.3.6
### Description
We are running a long-lived websocket connection for fetching the o... | Hi @ryanmccoy, thanks, it looks like the symbol is `None` (the filter could be empty dict). I'll run it and see what the message is.
Which limit did you use? | [
{
"body": "### Operating System\r\n\r\nUbuntu 20.04\r\n\r\n### Programming Languages\r\n\r\nPython\r\n\r\n### CCXT Version\r\n\r\n4.3.6\r\n\r\n### Description\r\n\r\nWe are running a long-lived websocket connection for fetching the orderbook prices for XBTUSD on BitMEX. At least once a day, like clockwork, we g... | 1ff62b590657f2a786d8872143607f52c5421798 | {
"head_commit": "5420d03c6f46fe7d555eb307a2239e0d7821baa3",
"head_commit_message": "fix(bitmex): guard handleOrderBook",
"patch_to_review": "diff --git a/ts/src/pro/bitmex.ts b/ts/src/pro/bitmex.ts\nindex 85f9079848f20..55f9d24daa6ad 100644\n--- a/ts/src/pro/bitmex.ts\n+++ b/ts/src/pro/bitmex.ts\n@@ -1573,6 +157... | [
{
"diff_hunk": "@@ -1573,6 +1573,9 @@ export default class bitmex extends bitmexRest {\n } else if (table === 'orderBook10') {\n this.orderbooks[symbol] = this.indexedOrderBook ({}, 10);\n }\n+ if (table === undefined || symbol === undefined) {",
"line": nu... | d4dd04e50a0cd7bfe77bc6fa5bd98d507ee40b18 | diff --git a/ts/src/pro/bitmex.ts b/ts/src/pro/bitmex.ts
index 85f9079848f20..634dc9fca8977 100644
--- a/ts/src/pro/bitmex.ts
+++ b/ts/src/pro/bitmex.ts
@@ -1559,11 +1559,17 @@ export default class bitmex extends bitmexRest {
//
const action = this.safeString (message, 'action');
const table ... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
ccxt__ccxt-22443@2f4bc89 | ccxt/ccxt | Python | 22,443 | fix(phemex) - funding fees | fix #22434 | 2024-05-09T12:13:25Z | Phemex: fetchFundingHistory -> amount: null
### Operating System
Debian 12
### Programming Languages
Python
### CCXT Version
4.3.18
### Description
Moin,
Method fetchFundingHistory gives "amount: null" on Phemex.
Seems wrong for me.
### Code
```
print(exchange.fetchFundingHistory('BTC/USDT:USDT'))
```
E... | I think amount should be value of "execFeeRv"
@egabosh I think we've added in this commit https://github.com/ccxt/ccxt/commit/c47df4ffd86, could you upgrade and try again?
@sc0Vu Didn't change. Amount is still null/None
did a fresh
git clone https://github.com/ccxt/ccxt.git --depth 1
Is this enough?
Don't understand... | [
{
"body": "### Operating System\n\nDebian 12\n\n### Programming Languages\n\nPython\n\n### CCXT Version\n\n4.3.18\n\n### Description\n\nMoin,\r\n\r\nMethod fetchFundingHistory gives \"amount: null\" on Phemex.\r\nSeems wrong for me.\n\n### Code\n\n```\r\nprint(exchange.fetchFundingHistory('BTC/USDT:USDT'))\r\n`... | e4581cd6a34f9db7d43da9f89a2828c8d2fc42bd | {
"head_commit": "2f4bc8926e9700f3f857d36c76e1c0c376bd40b6",
"head_commit_message": "comments",
"patch_to_review": "diff --git a/ts/src/phemex.ts b/ts/src/phemex.ts\nindex 47ac568952a74..a2306759fbd77 100644\n--- a/ts/src/phemex.ts\n+++ b/ts/src/phemex.ts\n@@ -3837,6 +3837,7 @@ export default class phemex extends... | [
{
"diff_hunk": "@@ -3837,6 +3837,7 @@ export default class phemex extends Exchange {\n request['limit'] = limit;\n }\n let response = undefined;\n+ this.verbose = true;",
"line": null,
"original_line": 3840,
"original_start_line": null,
"path": "ts/src/phemex.t... | bffef288ce3b46f40ea9a5fa7a284b6a74811b08 | diff --git a/ts/src/phemex.ts b/ts/src/phemex.ts
index 47ac568952a74..db7abdd9ddff0 100644
--- a/ts/src/phemex.ts
+++ b/ts/src/phemex.ts
@@ -3837,7 +3837,8 @@ export default class phemex extends Exchange {
request['limit'] = limit;
}
let response = undefined;
- if (market['settle']... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
django-cms__django-cms-8181@15d2a74 | django-cms/django-cms | Python | 8,181 | fix: child restrictions cached despite children have cache_parent_classes set to False | ## Description
This PR fixes #8180.
This seems to be a long-standing flaw in caching plugin restrictions. The fix is necessary for django CMS 5, since plugin restrictions are now cached globally (i.e. not on a per request-basis) and a wrong cache is easily noticeable. It should also be ported back to django CMS... | 2025-03-16T07:48:14Z | bug: Cannot add form fields indirectly to a form (e.g., below row/col)
## Issue
djangocms-form-builder customizes plugin restrictions such that form fields only can be added as indirect children of a form plugin, e.g.,
* Form
* Textarea
or
* Form
* Row
* Col
* Textarea
* Col
* Textarea ... | Hi @fsbraun, I’m looking into this issue but could use a bit more detail to reproduce the behavior. Whenever you have a moment, could you provide some additional information on the ticket? I’d really appreciate it. Thanks!
Hi @amandasavluchinske ! Sure! The supposed behavior should be:
1. Add a "Form" plugin to start ... | [
{
"body": "## Issue\n\ndjangocms-form-builder customizes plugin restrictions such that form fields only can be added as indirect children of a form plugin, e.g.,\n\n* Form\n * Textarea\n\nor\n\n* Form\n * Row\n * Col\n * Textarea \n * Col\n * Textarea \n\nTo this end it sets the `cache_p... | ada585d3f3580691f7c14c7bf0115f55cdca87f2 | {
"head_commit": "15d2a74b6b2346db9e91e92134b5fafedc01fefc",
"head_commit_message": "fix: child restrictions cached despite children have cache_parent_classes set to False",
"patch_to_review": "diff --git a/cms/plugin_base.py b/cms/plugin_base.py\nindex d8cb75ff83a..187f7a51233 100644\n--- a/cms/plugin_base.py\n+... | [
{
"diff_hunk": "@@ -206,14 +198,18 @@ def get_plugin_restrictions(plugin, page=None, restrictions_cache=None):\n try:\n child_classes = children_cache[plugin_type]\n except KeyError:\n+ cache_child_classes = plugin_class.cache_child_classes\n child_classes = plugin_class.get_child... | 0541cd76af6baac9c259b33241293f168510dfbc | diff --git a/cms/models/pluginmodel.py b/cms/models/pluginmodel.py
index 7a23b0c194a..5d3c517d07a 100644
--- a/cms/models/pluginmodel.py
+++ b/cms/models/pluginmodel.py
@@ -268,12 +268,12 @@ def get_plugin_info(self, children=None, parents=None):
return {
'type': 'plugin',
'position':... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ccxt__ccxt-22034@47c5ac1 | ccxt/ccxt | Python | 22,034 | fix(mexc): stop infinite loop caused by fetchLeverageTiers | It looks like `riskIncrVol` is only undefined if the market is scheduled to be delisted and can't have an order placed in it.
I wasn't really sure what a solution to this would be, because this might still be useful information if you are in a position or want to know some history, but nonetheless, it's not informat... | 2024-04-02T21:39:45Z | an endless loop after using fetch_leverage_tiers in mexc
### Operating System
Ubuntu 22.04
### Programming Languages
Python
### CCXT Version
4.1.1
### Description
hello
exchange=MEXC
When I used the “**fetch_leverage_tiers**” in mexc.py, I encountered an endless loop and found that it was a prob... | @Nuokaqiao, I think you're right, will fix this asap. | [
{
"body": "### Operating System\r\n\r\nUbuntu 22.04\r\n\r\n### Programming Languages\r\n\r\nPython\r\n\r\n### CCXT Version\r\n\r\n4.1.1\r\n\r\n### Description\r\n\r\nhello\r\nexchange=MEXC\r\nWhen I used the “**fetch_leverage_tiers**” in mexc.py, I encountered an endless loop and found that it was a problem in... | 9711f6629c5acf14f235996635f535337b0b7e24 | {
"head_commit": "47c5ac1f461fa10ee114bfdda7f4b8522ff5c736",
"head_commit_message": "fix(mexc): stop infinite loop caused by fetchLeverageTiers, fixes: #22017",
"patch_to_review": "diff --git a/ts/src/mexc.ts b/ts/src/mexc.ts\nindex 5c9793262e64f..98e6c34b7602d 100644\n--- a/ts/src/mexc.ts\n+++ b/ts/src/mexc.ts\n... | [
{
"diff_hunk": "@@ -4366,6 +4401,19 @@ export default class mexc extends Exchange {\n let floor = '0';\n const tiers = [];\n const quoteId = this.safeString (info, 'quoteCoin');\n+ if (riskIncrVol === '0') {\n+ return [\n+ {\n+ 'tier': ... | 447b35124a7ee979ffce67dfdcca94ce2347e5dc | diff --git a/ts/src/mexc.ts b/ts/src/mexc.ts
index 5c9793262e64f..7aa39714dd126 100644
--- a/ts/src/mexc.ts
+++ b/ts/src/mexc.ts
@@ -4295,8 +4295,9 @@ export default class mexc extends Exchange {
/**
* @method
* @name mexc#fetchLeverageTiers
- * @description retrieve information on ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ccxt__ccxt-21943@7dd596d | ccxt/ccxt | Python | 21,943 | bybit: update parsePosition | fix: ccxt/ccxt#21941
```BASH
$ n bybit fetchPositions '["BTC/USD:BTC"]' --test
symbol | timestamp | datetime | initialMargin | maintenanceMargin | notional | leverage | contracts | contractSize | markPrice | collateral | marginMode | stopLossPrice | takeProfitPrice
---------------------... | 2024-03-27T07:40:37Z | Bybit - marginMode key not defined in position response.
### Operating System
_No response_
### Programming Languages
Python
### CCXT Version
4.2.82
### Description
Hello,
I updated CCXT a couple of days ago and found out the marginMode key is not set anymore in the response from fetch_positions... | @germangar the value was set to undefined because of this issue ccxt/ccxt#21079. I try the isolated / cross position, the tradeMode is 0. Which order did you create? Could you provide example?
I did nothing special. This is the vervose output from my order:
```
fetch Request: bybit POST https://api-testnet.bybit.c... | [
{
"body": "### Operating System\r\n\r\n_No response_\r\n\r\n### Programming Languages\r\n\r\nPython\r\n\r\n### CCXT Version\r\n\r\n4.2.82\r\n\r\n### Description\r\n\r\nHello,\r\n\r\nI updated CCXT a couple of days ago and found out the marginMode key is not set anymore in the response from fetch_positions calls... | b66f33b16987aab4eb83ca51cf202852a5054676 | {
"head_commit": "7dd596d84f6825e9749967d8c837bfb0e272e940",
"head_commit_message": "Merge branch 'master' of github.com:ccxt/ccxt into update-bybit-parse-position",
"patch_to_review": "diff --git a/ts/src/bybit.ts b/ts/src/bybit.ts\nindex 7c2e2c0aef6ee..f7c453a2268d6 100644\n--- a/ts/src/bybit.ts\n+++ b/ts/src/b... | [
{
"diff_hunk": "@@ -6315,6 +6315,12 @@ export default class bybit extends Exchange {\n if (timestamp === undefined) {\n timestamp = this.safeIntegerN (position, [ 'updatedTime', 'updatedAt' ]);\n }\n+ const tradeMode = this.safeInteger (position, 'tradeMode', 0);\n+ let... | 2ebf4f3889a5a9548a2a01a6bdcb37540f0a3e07 | diff --git a/ts/src/bybit.ts b/ts/src/bybit.ts
index 7c2e2c0aef6ee..e851c8926f018 100644
--- a/ts/src/bybit.ts
+++ b/ts/src/bybit.ts
@@ -6315,6 +6315,12 @@ export default class bybit extends Exchange {
if (timestamp === undefined) {
timestamp = this.safeIntegerN (position, [ 'updatedTime', 'update... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
cookiecutter__cookiecutter-django-5621@924e421 | cookiecutter/cookiecutter-django | Python | 5,621 | Add justfile for use with docker | <!-- Thank you for helping us out: your efforts mean a great deal to the project and the community as a whole! -->
## Description
Set up [just](https://github.com/casey/just) to simplify calling docker commands.
Checklist:
- [x] I've made sure that tests are updated accordingly (especially if adding or upda... | 2025-01-03T12:03:34Z | Convenient script for rapid development
## Description
This ticket is a suggestion (since I personally follow and I have seen in some non-Django based projects.
While working on some projects, using Django cookie-cutter, I had to refer to the cookie-cutter documentation for a number of commands (especially when ... | Your suggestion sounds like #1879, is that correct?
@foarsitter Correct, the only difference is I am using shell scripts instead of makefiles.
Since many of us use some such scripts, the suggestion is to let the core developers finalize it.
For example, for a new project, I generally start with something like this... | [
{
"body": "## Description\r\n\r\nThis ticket is a suggestion (since I personally follow and I have seen in some non-Django based projects. \r\n\r\nWhile working on some projects, using Django cookie-cutter, I had to refer to the cookie-cutter documentation for a number of commands (especially when working with ... | 3ef84f1a2671954c03b913fe79ba2f0b3bd51b34 | {
"head_commit": "924e421ec986991aa54dea441156abcee17ee696",
"head_commit_message": "Add justfile for use with docker",
"patch_to_review": "diff --git a/hooks/post_gen_project.py b/hooks/post_gen_project.py\nindex ca1ffad329..1eee7ef6de 100644\n--- a/hooks/post_gen_project.py\n+++ b/hooks/post_gen_project.py\n@@ ... | [
{
"diff_hunk": "@@ -0,0 +1,33 @@\n+export COMPOSE_FILE := \"docker-compose.local.yml\"\n+\n+# Default command to list all available commands.\n+default:\n+ @just --list\n+\n+# build: Build python image.\n+build:\n+ @echo \"Building python image...\"\n+ @docker-compose build",
"line": null,
"ori... | 6c9c616ec7b9332a043577e51fa041521d02cdc2 | diff --git a/docs/2-local-development/developing-locally-docker.rst b/docs/2-local-development/developing-locally-docker.rst
index 05e188e527..07969e5b6c 100644
--- a/docs/2-local-development/developing-locally-docker.rst
+++ b/docs/2-local-development/developing-locally-docker.rst
@@ -242,6 +242,41 @@ The stack comes ... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "New Feature Additions"
} |
ccxt__ccxt-21769@3a5b916 | ccxt/ccxt | Python | 21,769 | feat(coinbase): add pagination in fetchLedger | fix: ccxt/ccxt#21756
Test:
```BASH
# should fetch all history
$ n coinbase fetchLedger USDT 1673986028000 100 '{"paginate": true,"account_id":"0e2b7cd9-ce67-53f3-92f2-d61c9410a9f6"}'
$ n coinbase fetchLedger USDT 1673986028000 1 '{"paginate": true,"account_id":"0e2b7cd9-ce67-53f3-92f2-d61c9410a9f6"}'
# shou... | 2024-03-18T02:18:30Z | Coinbase fetch_ledger unable to increase limit or paginate results - stuck receiving 25 results?
### Operating System
ubuntu and mac
### Programming Languages
Python
### CCXT Version
4.2.65
### Description
Can't figure out how to enable pagination using ccxt, coinbase.fetch_ledger() method. Anyone have example?... | @jtashiro before we wrap pagination in this function, you can set `'starting_after':'value_next_after'` manually. The value would be `"pagination.next_starting_after"`
Can you provide an example? I'm not clear where and how I set those properties.
Actually am seeing this problem across a number of the v2 APIs where... | [
{
"body": "### Operating System\n\nubuntu and mac\n\n### Programming Languages\n\nPython\n\n### CCXT Version\n\n4.2.65\n\n### Description\n\nCan't figure out how to enable pagination using ccxt, coinbase.fetch_ledger() method. Anyone have example?\r\n\r\nIf I set \r\nparams = { 'paginate': True } \r\nI get an ... | 6c74bbfd60dd3b1294eaacad1ae3fae73d854893 | {
"head_commit": "3a5b91614c35c3d661e0e261aa5744d862fd2c0a",
"head_commit_message": "feat(coinbase): add pagination in fetchLedger",
"patch_to_review": "diff --git a/ts/src/coinbase.ts b/ts/src/coinbase.ts\nindex 989c99836d456..3c05cea3a9679 100644\n--- a/ts/src/coinbase.ts\n+++ b/ts/src/coinbase.ts\n@@ -1897,9 +... | [
{
"diff_hunk": "@@ -1897,9 +1897,15 @@ export default class coinbase extends Exchange {\n * @param {int} [since] timestamp in ms of the earliest ledger entry, default is undefined\n * @param {int} [limit] max number of ledger entrys to return, default is undefined\n * @param {object} ... | 3b520ff0b833a26b9969d660aedcfde949525dba | diff --git a/ts/src/coinbase.ts b/ts/src/coinbase.ts
index 989c99836d456..ec3e629104e78 100644
--- a/ts/src/coinbase.ts
+++ b/ts/src/coinbase.ts
@@ -1339,7 +1339,7 @@ export default class coinbase extends Exchange {
* @returns {object} an associative dictionary of currencies
*/
const respon... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
django-cms__django-cms-6968@bf38ccf | django-cms/django-cms | Python | 6,968 | Fix: Bad Title.path in Multilanguage sites if parent slug is created or modified | ## Description
Fix #6622 Bad Title.path in Multilanguage sites if parent slug is created or modified
Just a reopening of PR #6965
## Related resources
First bug:
In 'en','fr' site
Create /en/en-1/ page
Create from this page a subpage with slug "en-1-1"
Create "fr" translation with slug "fr... | 2021-01-22T15:16:48Z | The slugs of child pages are built incorrectly and return a 404 error when a user adds a custom slug for another language of the parent page
### Summary
The slugs of child pages are breaking when a user adds a custom slug for another language of the parent page, this leads to incorrect urls being displayed and the c... | I just experienced the same issue on a 3.5.3 installation. Glad I found this report, was quite worried for a moment ;)
A prerequisite for reproducing this is that at least one of the parent's (i.e. parent-(en|de)) ancestors (including the root page) does not have a German translation. If all pages in the chain have a G... | [
{
"body": "### Summary\r\n\r\nThe slugs of child pages are breaking when a user adds a custom slug for another language of the parent page, this leads to incorrect urls being displayed and the correct urls return a 404 error.\r\n\r\n### Actual behaviour\r\n\r\n1. Create an empty website with 2 languages - Engli... | ee3af05e70e23bdbc8e4bdf1dead5baf87bf7994 | {
"head_commit": "bf38ccf1d14599bb1e5ce728d08f6ccc706d3cd5",
"head_commit_message": "Merge remote-tracking branch 'origin/fp-test-before-fix6622' into fp-fix6622",
"patch_to_review": "diff --git a/CHANGELOG.rst b/CHANGELOG.rst\nindex 1d38f6a3006..b345e72fda4 100644\n--- a/CHANGELOG.rst\n+++ b/CHANGELOG.rst\n@@ -2... | [
{
"diff_hunk": "@@ -0,0 +1,62 @@\n+# -*- coding: utf-8 -*-\n+from cms.api import create_page, create_title, publish_pages\n+from cms.test_utils.testcases import (CMSTestCase)\n+\n+\n+class TitlePathTestCase(CMSTestCase):\n+\n+ def test0001_translated_subpage_title_path(self):\n+ \"\"\"\n+ Test ... | 98c8e2f95b52d736ed3600aaf4fab3add929ec49 | diff --git a/CHANGELOG.rst b/CHANGELOG.rst
index b51738e1475..c4b8c411039 100644
--- a/CHANGELOG.rst
+++ b/CHANGELOG.rst
@@ -8,6 +8,7 @@ Unreleased
* Fixed builds on RTD
* Enforce use of coverage > 4 for python 3.8 support
+* Fixed 66622 bad Title.path in multilingual sites when parent slug is created or modified
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ccxt__ccxt-21513@c661f32 | ccxt/ccxt | Python | 21,513 | fix(bitget) - fetchOHLCV reorganization | dozen details/fixes
https://www.bitget.com/api-doc/contract/market/Get-Candle-Data#description
https://www.bitget.com/api-doc/spot/market/Get-Candle-Data
fix #21189 | 2024-03-04T13:36:45Z | Bitget fetchOHLCV 1d issue after updated from 4.2.31 to 4.2.40
### Operating System
_No response_
### Programming Languages
Typescript
### CCXT Version
_No response_
### Description
Bitget returns ExchangeError when fetchOHLCV futures with '1d' interval.
### Code
```
bitget.fetchOHLCV(symb... | Hi @x1i4b1x2
It works for me. Can you paste the verbose log?
<img width="1286" alt="Screenshot 2024-02-11 at 11 20 02 AM" src="https://github.com/ccxt/ccxt/assets/100806945/cba52251-168a-4924-9a75-f745636b5d0e">
Hi @x1i4b1x2
The default endTime is `now()`, which exceeds the 90 days limit in bitget. This would w... | [
{
"body": "### Operating System\r\n\r\n_No response_\r\n\r\n### Programming Languages\r\n\r\nTypescript\r\n\r\n### CCXT Version\r\n\r\n_No response_\r\n\r\n### Description\r\n\r\nBitget returns ExchangeError when fetchOHLCV futures with '1d' interval.\r\n\r\n### Code\r\n\r\n```\r\n bitget.fetchOHLCV(symbol, '1... | 63c6c0b80cd28cb80938c82adbb830b8c53a44dc | {
"head_commit": "c661f32ce85d054be846939fc65ea5789ee9ff5b",
"head_commit_message": "static tests upd2",
"patch_to_review": "diff --git a/ts/src/bitget.ts b/ts/src/bitget.ts\nindex 48875aa5f8ba7..7074e39fd647a 100644\n--- a/ts/src/bitget.ts\n+++ b/ts/src/bitget.ts\n@@ -3278,10 +3278,11 @@ export default class bit... | [
{
"diff_hunk": "@@ -3294,51 +3295,96 @@ export default class bitget extends Exchange {\n const marketType = market['spot'] ? 'spot' : 'swap';\n const timeframes = this.options['timeframes'][marketType];\n const selectedTimeframe = this.safeString (timeframes, timeframe, timeframe);\n+ ... | 4bcd23435a3c217c6b045f78c0e654385cd9e7be | diff --git a/ts/src/bitget.ts b/ts/src/bitget.ts
index 48875aa5f8ba7..f64947abf36af 100644
--- a/ts/src/bitget.ts
+++ b/ts/src/bitget.ts
@@ -1342,6 +1342,23 @@ export default class bitget extends Exchange {
'swap': {
'method': 'publicMixGetV2MixMarketCandles', // or publicM... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
cookiecutter__cookiecutter-django-3967@89d2f3b | cookiecutter/cookiecutter-django | Python | 3,967 | Add Azure Storage as an option to serve static and media files | ## Description
Add Azure Storage as an option to serve static and media files
Checklist:
- [X] I've made sure that tests are updated accordingly (especially if adding or updating a template option)
- [X] I've updated the documentation or confirm that my change doesn't require any updates
## Rationale
Fix #230... | 2022-11-26T18:54:13Z | Add Blob Storage as an option for static and media files
## Description
[//]: # (What's it you're proposing? How should it be implemented?)
Can I add Blob Storage (Microsoft Azure) as an option to serve static and media files?
## Rationale
[//]: # (Why should this feature be implemented?)
I always use Am... | Not sure how I didn't get around to reply, but yes, this would be a welcomed addition. PR welcome 👍🏻
@Jeanluis019: I know it has been a while but are you still interested in this? We could collaborate on a PR.
I am doing something naive like looking at GCP (for an example) and seeing what could need changing. It ... | [
{
"body": "## Description\r\n\r\n[//]: # (What's it you're proposing? How should it be implemented?)\r\nCan I add Blob Storage (Microsoft Azure) as an option to serve static and media files?\r\n\r\n\r\n\r\n## Rationale\r\n\r\n[//]: # (Why should this feature be implemented?)\r\nI always use Amazon S3 for servin... | fd45bb18ea992423c79a2878d02620e190b1ac2e | {
"head_commit": "89d2f3b433d27b3300a3f9af82dc92ccfaa98d76",
"head_commit_message": "Add Azure Storage as an option to serve static and media files",
"patch_to_review": "diff --git a/README.md b/README.md\nindex 9f2af6d37e..27fc6e0e1f 100644\n--- a/README.md\n+++ b/README.md\n@@ -29,7 +29,7 @@ production-ready Dj... | [
{
"diff_hunk": "@@ -27,6 +27,7 @@\n \"cloud_provider\": [\n \"AWS\",\n \"GCP\",\n+ \"AZURE\",",
"line": null,
"original_line": 30,
"original_start_line": null,
"path": "cookiecutter.json",
"start_line": null,
"text": "@user1:\nThe other 2 (AWS and GCP) are in capital letters... | 251760300905493108e9f9a7ae5894459d163499 | diff --git a/README.md b/README.md
index 9f2af6d37e..27fc6e0e1f 100644
--- a/README.md
+++ b/README.md
@@ -29,7 +29,7 @@ production-ready Django projects quickly.
- Optional basic ASGI setup for Websockets
- Optional custom static build using Gulp and livereload
- Send emails via [Anymail](https://github.com/a... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
cookiecutter__cookiecutter-django-4367@17d646e | cookiecutter/cookiecutter-django | Python | 4,367 | Add translations for Brazilian Portuguese | <!-- Thank you for helping us out: your efforts mean a great deal to the project and the community as a whole! -->
## Description
Adding translations for the default messages present in any brand-new project.
Checklist:
- [x] I've made sure that tests are updated accordingly (especially if adding or updatin... | 2023-06-04T21:50:10Z | Offer translation to strings collected by makemessages
## Description
The newly created projects could have the translation to strings by default.
## Rationale
I frequently create projects supporting multiple languages, and there's always the need to translate these strings manually.
I'd happily provide t... | That's an interesting suggestion. I understand the problem you're describing, and appreciate the pain to translated the same strings over and over.
For context, by default, [we ship with American English only](https://github.com/cookiecutter/cookiecutter-django/blob/00b22bc02d6c1668972cf61a6632dbbb200b8a86/%7B%7Bcoo... | [
{
"body": "## Description\r\n\r\nThe newly created projects could have the translation to strings by default. \r\n\r\n## Rationale\r\n\r\nI frequently create projects supporting multiple languages, and there's always the need to translate these strings manually. \r\n\r\nI'd happily provide the PT-BR (Brazillian... | d085363ae9e0d8bc596c777d45b8be7bf05d3532 | {
"head_commit": "17d646e28bb2094c4c47f7a9a3669d40df59894f",
"head_commit_message": "Merge branch 'master' into add_i18n_strings",
"patch_to_review": "diff --git a/{{cookiecutter.project_slug}}/config/settings/base.py b/{{cookiecutter.project_slug}}/config/settings/base.py\nindex c0ca31f368..487669e0a9 100644\n--... | [
{
"diff_hunk": "@@ -0,0 +1,321 @@\n+# SOME DESCRIPTIVE TITLE.\n+# Copyright (C) YEAR THE PACKAGE'S COPYRIGHT HOLDER\n+# This file is distributed under the same license as the PACKAGE package.\n+# FIRST AUTHOR <EMAIL@ADDRESS>, YEAR.\n+#\n+#, fuzzy\n+msgid \"\"\n+msgstr \"\"\n+\"Project-Id-Version: PACKAGE VERSIO... | e04361ab8fa9f8360e115413cef6716d6be127fa | diff --git a/{{cookiecutter.project_slug}}/config/settings/base.py b/{{cookiecutter.project_slug}}/config/settings/base.py
index c0ca31f368..487669e0a9 100644
--- a/{{cookiecutter.project_slug}}/config/settings/base.py
+++ b/{{cookiecutter.project_slug}}/config/settings/base.py
@@ -26,6 +26,12 @@
TIME_ZONE = "{{ cooki... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "New Feature Additions"
} |
cookiecutter__cookiecutter-django-3528@d4d115a | cookiecutter/cookiecutter-django | Python | 3,528 | Avoid docker image/volume collision by prefixing with project slug | <!-- Thank you for helping us out: your efforts mean a great deal to the project and the community as a whole! -->
## Description
Hi, it's my first contribution ever, this pull request is related to issue #3254 and issue #2849.
The problem happens when we create a second django-cookiecutter project on our dev... | 2022-01-11T20:09:51Z | The container name "/postgres" is already in use by container "*"
## What happened?
When I tried to create and run a new project with docker-compose I got these errors:
```
ERROR: for postgres Cannot create container for service postgres: Conflict. The container name "/postgres" is already in use by container "..."... | When you remove the container name definition for the docker-compose services, the current folders name is used as prefix for the container name.
By default this is the project slug.
Removing the container names would also allow to pass the `--project-name` option to docker-compose to setup several environments (due ... | [
{
"body": "## What happened?\r\nWhen I tried to create and run a new project with docker-compose I got these errors:\r\n```\r\nERROR: for postgres Cannot create container for service postgres: Conflict. The container name \"/postgres\" is already in use by container \"...\". You have to remove (or rename) that... | b3fb4f9a0f77424e5eeb597f994a357644ed3663 | {
"head_commit": "d4d115a8e6a33108899ecca756ff035ac8edaaef",
"head_commit_message": "Prefix volumes with project slug to avoid conflicts",
"patch_to_review": "diff --git a/docs/developing-locally-docker.rst b/docs/developing-locally-docker.rst\nindex 17e47bfb44..e0b522c8ce 100644\n--- a/docs/developing-locally-do... | [
{
"diff_hunk": "@@ -33,16 +33,16 @@ services:\n context: .\n dockerfile: ./compose/production/postgres/Dockerfile\n image: {{ cookiecutter.project_slug }}_production_postgres\n- container_name: postgres\n+ container_name: {{ cookiecutter.project_slug }}_production_postgres",
"line": nu... | d8d5ca23dbf5cf768983d699909ecde1ff9446e5 | diff --git a/docs/developing-locally-docker.rst b/docs/developing-locally-docker.rst
index 17e47bfb44..e0b522c8ce 100644
--- a/docs/developing-locally-docker.rst
+++ b/docs/developing-locally-docker.rst
@@ -167,16 +167,18 @@ docker
The ``container_name`` from the yml file can be used to check on containers with dock... | {
"difficulty": "low",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
cookiecutter__cookiecutter-django-3515@a64800d | cookiecutter/cookiecutter-django | Python | 3,515 | Add UserSignupForm and UserSocialSignupForm | Add UserSignupForm and UserSocialSignupForm
And docstrings clarifying how to use Custom User Model and Signup Forms.
<!-- Thank you for helping us out: your efforts mean a great deal to the project and the community as a whole! -->
## Description
<!-- What's it you're proposing? -->
The proposal is based... | 2022-01-05T10:09:01Z | Adding fields to the User model
Please excuse me if the answer to my question is painfully obvious but I'm new to Django and I'm not very familiar with custom user models.
If I wanted to add another field to the user model (for example, "department" - the users are employees), where would I add it?
I figured I could ... | Nope, not painfully obvious. I've yet to fix problems with the admin change user form, in that it's using the stock Django one. One of these days, if I have free time...
I just found myself in the same boat as OP (and glad I read it here).
Pydanny, best option then is to scratch the custom user app and use Django's d... | [
{
"body": "Please excuse me if the answer to my question is painfully obvious but I'm new to Django and I'm not very familiar with custom user models.\n\nIf I wanted to add another field to the user model (for example, \"department\" - the users are employees), where would I add it?\n\nI figured I could add a `... | 6157607f3fc6bae516940eca0cacb78045224fbb | {
"head_commit": "a64800d4146c5bb94476c9f5e652a79df3f2a35b",
"head_commit_message": "Add UserSignupForm and UserSocialSignupForm\nAnd docstrings clarifying how to use Custom User Model and Signup Forms.",
"patch_to_review": "diff --git a/{{cookiecutter.project_slug}}/config/settings/base.py b/{{cookiecutter.proje... | [
{
"diff_hunk": "@@ -11,9 +13,56 @@ class Meta(admin_forms.UserChangeForm.Meta):\n \n \n class UserCreationForm(admin_forms.UserCreationForm):",
"line": null,
"original_line": 15,
"original_start_line": null,
"path": "{{cookiecutter.project_slug}}/{{cookiecutter.project_slug}}/users/forms.py",
... | 1db935d939ea0d2c149e9e8c1c0049f628526fd5 | diff --git a/{{cookiecutter.project_slug}}/config/settings/base.py b/{{cookiecutter.project_slug}}/config/settings/base.py
index 021dd7491e..5177c92fa9 100644
--- a/{{cookiecutter.project_slug}}/config/settings/base.py
+++ b/{{cookiecutter.project_slug}}/config/settings/base.py
@@ -306,8 +306,12 @@
ACCOUNT_EMAIL_VERIF... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
ccxt__ccxt-18672@ce6c989 | ccxt/ccxt | Python | 18,672 | fix(binance) - editOrder for spot | currently this does not work:
```
const o1 = await e.createOrder('ADA/USDT', 'limit', 'buy', 50, 0.2);
const o2 = await e.editOrder(o1.id, 'ADA/USDT', 'limit', 'buy', 50, 0.21);
```
PR seems to fix it, but @pcriadoperez I see that you were working on WS orders & related things in last month, so you could know this... | 2023-07-26T19:55:41Z | [binance] editOrder recieved error "Mandatory parameter 'type' was not sent"
### Operating System
MacOS
### Programming Languages
JavaScript
### CCXT Version
4.0.38
### Description
when call editOrder with params (id, symbol, type, side, amount, price), I got the response error blow this.
```
B... | I've reproduced the issue and working on it atm | [
{
"body": "### Operating System\r\n\r\nMacOS\r\n\r\n### Programming Languages\r\n\r\nJavaScript\r\n\r\n### CCXT Version\r\n\r\n4.0.38\r\n\r\n### Description\r\n\r\nwhen call editOrder with params (id, symbol, type, side, amount, price), I got the response error blow this.\r\n\r\n```\r\nBadRequest: binance {\"co... | 4b55f3d5d525a0ecb3bd833d8efa8fbc85286a1d | {
"head_commit": "ce6c98941051c6fca72d87ab8a9a09c795a74c56",
"head_commit_message": "fix(binance) - editOrder for spot",
"patch_to_review": "diff --git a/ts/src/binance.ts b/ts/src/binance.ts\nindex ee5c5e49e60cd..0a7635f130cae 100644\n--- a/ts/src/binance.ts\n+++ b/ts/src/binance.ts\n@@ -3677,15 +3677,16 @@ expo... | [
{
"diff_hunk": "@@ -3677,15 +3677,16 @@ export default class binance extends Exchange {\n if (!market['spot']) {\n throw new NotSupported (this.id + ' editSpotOrder() does not support ' + market['type'] + ' orders');\n }\n- const request = {\n- 'symbol': market['id'... | 13b2b4293a4009f8d751603ddc8d073cef2d0d0d | diff --git a/ts/src/binance.ts b/ts/src/binance.ts
index ee5c5e49e60cd..06e9883e0e10c 100644
--- a/ts/src/binance.ts
+++ b/ts/src/binance.ts
@@ -3665,10 +3665,11 @@ export default class binance extends Exchange {
* @see https://binance-docs.github.io/apidocs/spot/en/#cancel-an-existing-order-and-send-a-new-or... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
Subsets and Splits
Review Test Instances
Retrieves basic metadata about code review instances but doesn't provide any analytical insights or patterns beyond raw data access.