instance_id stringlengths 21 53 | repo stringclasses 188
values | language stringclasses 1
value | pull_number int64 20 148k | title stringlengths 6 144 | body stringlengths 0 83.4k | created_at stringdate 2015-09-25 03:17:17 2025-07-10 16:50:35 | problem_statement stringlengths 188 240k | hints_text stringlengths 0 145k | resolved_issues listlengths 1 6 | base_commit stringlengths 40 40 | commit_to_review dict | reference_review_comments listlengths 1 62 | merged_commit stringlengths 40 40 | merged_patch stringlengths 297 9.87M | metadata dict |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
ansible__ansible-35988@ef28275 | ansible/ansible | Python | 35,988 | fix nxos_interface_ospf issues | ##### SUMMARY
<!--- Describe the change, including rationale and design decisions -->
Fixes #35987
<!---
If you are fixing an existing issue, please include "Fixes #nnn" in your
commit message and your description; but you should still explain what
the change does.
-->
##### ISSUE TYPE
<!--- Pick one below ... | 2018-02-09T22:03:46Z | nxos_interface_ospf issues
<!---
Verify first that your issue/request is not already reported on GitHub.
Also test if the latest release, and devel branch are affected too.
-->
##### ISSUE TYPE
<!--- Pick one below and delete the rest -->
- Bug Report
##### COMPONENT NAME
<!---
Name of the module, plugin,... | [
{
"body": "<!---\r\nVerify first that your issue/request is not already reported on GitHub.\r\nAlso test if the latest release, and devel branch are affected too.\r\n-->\r\n\r\n##### ISSUE TYPE\r\n<!--- Pick one below and delete the rest -->\r\n - Bug Report\r\n\r\n##### COMPONENT NAME\r\n<!---\r\nName of the m... | fd33dc6cd124d4c3e2fa8d0bed02b8379cf7e8b8 | {
"head_commit": "ef2827584ec3b8057ec69c8e084c41ba645e0aa9",
"head_commit_message": "fix nxos_interface_ospf issues",
"patch_to_review": "diff --git a/lib/ansible/modules/network/nxos/nxos_interface_ospf.py b/lib/ansible/modules/network/nxos/nxos_interface_ospf.py\nindex 8de0fbac67f0d8..952cfc0c363997 100644\n---... | [
{
"diff_hunk": "@@ -95,14 +95,14 @@\n message_digest_algorithm_type:\n description:\n - Algorithm used for authentication among neighboring routers\n- within an area. Valid values is 'md5'.\n+ within an area. Valid values are 'md5' and 'default'.\n required: false\n choices: ['... | 9dd5a28b70644df8d196c037a253c0066d7bea16 | diff --git a/lib/ansible/modules/network/nxos/nxos_interface_ospf.py b/lib/ansible/modules/network/nxos/nxos_interface_ospf.py
index 8de0fbac67f0d8..6061c6f0d38173 100644
--- a/lib/ansible/modules/network/nxos/nxos_interface_ospf.py
+++ b/lib/ansible/modules/network/nxos/nxos_interface_ospf.py
@@ -95,16 +95,16 @@
me... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
ansible__awx-7270@4de7de3 | ansible/awx | Python | 7,270 | Prevent exception for Non value | ##### SUMMARY
<!--- Describe the change, including rationale and design decisions -->
Fixes #7267
<!---
If you are fixing an existing issue, please include "related #nnn" in your
commit message and your description; but you should still explain what
the change does.
-->
##### ISSUE TYPE
<!--- Pick one below ... | 2020-06-05T17:37:38Z | Tower settings fails with stacktrace - expected to exit gracefully
##### ISSUE TYPE
- Bug Report
##### SUMMARY
Running awx.awx.settings module throws `AttributeError: 'NoneType' object has no attribute 'startswith'`
##### ENVIRONMENT
* AWX version: 11.2.0
* AWX install method: setup.sh
* Ansible version: 2... | You are using module incorrecly. See documentation at the top of module source.
Either `name + value` or `settings` properties should be used.
Perhaps, you mean:
```
tower_settings:
- name: AWX_TASK_ENV
value: "{'GIT_SSL_NO_VERIFY': 'True'}"
```
or
```
tower_settings:
- settings:
AWX_TASK_... | [
{
"body": "##### ISSUE TYPE\r\n - Bug Report\r\n\r\n##### SUMMARY\r\nRunning awx.awx.settings module throws `AttributeError: 'NoneType' object has no attribute 'startswith'`\r\n\r\n##### ENVIRONMENT\r\n* AWX version: 11.2.0\r\n* AWX install method: setup.sh\r\n* Ansible version: 2.9.7\r\n* Operating System: To... | e6b1e552740e7ceb072c7907502932dc484fefe8 | {
"head_commit": "4de7de3ce9b92a546832edd8e8af97c20a4d2a0a",
"head_commit_message": "Prevent exception for Non value",
"patch_to_review": "diff --git a/awx_collection/plugins/modules/tower_settings.py b/awx_collection/plugins/modules/tower_settings.py\nindex b7ecde45ef87..a66acadf44c7 100644\n--- a/awx_collection... | [
{
"diff_hunk": "@@ -82,6 +82,10 @@\n \n \n def coerce_type(module, value):\n+ # If our value is already None we can just return directly\n+ if value == None:",
"line": null,
"original_line": 86,
"original_start_line": null,
"path": "awx_collection/plugins/modules/tower_settings.py",
"s... | b457c8f1336c36cefa0c72fd1e413c2feec0be26 | diff --git a/awx_collection/plugins/modules/tower_settings.py b/awx_collection/plugins/modules/tower_settings.py
index b7ecde45ef87..ef4dcd9b1b1a 100644
--- a/awx_collection/plugins/modules/tower_settings.py
+++ b/awx_collection/plugins/modules/tower_settings.py
@@ -82,6 +82,10 @@
def coerce_type(module, value):
+... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-35737@78e1f82 | ansible/ansible | Python | 35,737 | fix nxos_vpc_interface peer_link idempotence | ##### SUMMARY
<!--- Describe the change, including rationale and design decisions -->
Fixes #35736
<!---
If you are fixing an existing issue, please include "Fixes #nnn" in your
commit message and your description; but you should still explain what
the change does.
-->
##### ISSUE TYPE
<!--- Pick one below a... | 2018-02-05T17:45:20Z | nxos_vpc_interface peer_link is not idempotent
<!---
Verify first that your issue/request is not already reported on GitHub.
Also test if the latest release, and master branch are affected too.
-->
##### ISSUE TYPE
<!--- Pick one below and delete the rest -->
- Bug Report
##### COMPONENT NAME
<!---
Name o... | [
{
"body": "<!---\r\nVerify first that your issue/request is not already reported on GitHub.\r\nAlso test if the latest release, and master branch are affected too.\r\n-->\r\n\r\n##### ISSUE TYPE\r\n<!--- Pick one below and delete the rest -->\r\n - Bug Report\r\n\r\n##### COMPONENT NAME\r\n<!---\r\nName of the ... | e3b6b40d884c3ea2086e6563e5da3a35a7ef40ee | {
"head_commit": "78e1f82542ef4ac776403722cf1606e691f1e8b6",
"head_commit_message": "fix peer_link idempotence",
"patch_to_review": "diff --git a/lib/ansible/modules/network/nxos/nxos_vpc_interface.py b/lib/ansible/modules/network/nxos/nxos_vpc_interface.py\nindex cbf445d110c608..c228456fbc7285 100644\n--- a/lib/... | [
{
"diff_hunk": "@@ -194,11 +194,14 @@ def get_commands_to_config_vpc_interface(portchannel, delta, config_value, exist\n commands = []\n \n if delta.get('peer-link') is False and existing.get('peer-link') is True:",
"line": null,
"original_line": 196,
"original_start_line": null,
"path":... | 64567acdd931213bb326a191a4cd8f171f735423 | diff --git a/lib/ansible/modules/network/nxos/nxos_vpc_interface.py b/lib/ansible/modules/network/nxos/nxos_vpc_interface.py
index cbf445d110c608..def6947c3387e0 100644
--- a/lib/ansible/modules/network/nxos/nxos_vpc_interface.py
+++ b/lib/ansible/modules/network/nxos/nxos_vpc_interface.py
@@ -193,12 +193,15 @@ def get... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
ansible__ansible-35564@349abce | ansible/ansible | Python | 35,564 | * adds commit replace with config file for iosxr | * fixes dci failure in iosxr_logging
##### SUMMARY
<!--- Describe the change, including rationale and design decisions -->
fixes #32061
##### ISSUE TYPE
<!--- Pick one below and delete the rest: -->
- Bugfix Pull Request
##### COMPONENT NAME
iosxr_config
iosxr_logging
##### ANSIBLE VERSION
<!--... | 2018-01-31T16:57:45Z | iosxr_config src parameter does not do what is expected.
##### ISSUE TYPE
- Bug Report
##### COMPONENT NAME
- iosxr_config module
##### ANSIBLE VERSION
```
$ ansible --version
ansible 2.3.0.0
config file = /etc/ansible/ansible.cfg
configured module search path = Default w/o overrides
python versio... | cc @Qalthos @ganeshrn @gundalow @kedarX @privateip @rcarrillocruz @trishnaguha
[click here for bot help](https://github.com/ansible/ansibullbot/blob/master/ISSUE_HELP.md)
<!--- boilerplate: notify --->
Docs should be backported to `2.4` as well
Any update?
@kedarX can you please verify this is fixed. If it is, please u... | [
{
"body": "##### ISSUE TYPE\r\n - Bug Report\r\n\r\n##### COMPONENT NAME\r\n - iosxr_config module\r\n\r\n##### ANSIBLE VERSION\r\n```\r\n$ ansible --version\r\nansible 2.3.0.0\r\n config file = /etc/ansible/ansible.cfg\r\n configured module search path = Default w/o overrides\r\n python version = 2.7.6 (def... | 2479b6d635be1a5f93fef0f7d40e272731a8147a | {
"head_commit": "349abcef97caf3e10d55d967340debe8bd745cb1",
"head_commit_message": "* adds commit replace with config file for iosxr\n* fixes dci failure in iosxr_logging",
"patch_to_review": "diff --git a/lib/ansible/module_utils/network/iosxr/iosxr.py b/lib/ansible/module_utils/network/iosxr/iosxr.py\nindex 11... | [
{
"diff_hunk": "@@ -415,7 +416,14 @@ def load_config(module, command_filter, commit=False, replace=False,\n if module._diff:\n diff = get_config_diff(module)\n \n- if commit:\n+ if replace:\n+ cmd = {'command': 'commit replace',\n+ 'prompt': 'This c... | 9c556ba25a4f6dbd030686d75b478d5cea8212dc | diff --git a/lib/ansible/module_utils/network/iosxr/iosxr.py b/lib/ansible/module_utils/network/iosxr/iosxr.py
index 114f848132066e..e37a0d84855edf 100644
--- a/lib/ansible/module_utils/network/iosxr/iosxr.py
+++ b/lib/ansible/module_utils/network/iosxr/iosxr.py
@@ -29,6 +29,7 @@
import json
from difflib import Diffe... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-35592@2e5ebe8 | ansible/ansible | Python | 35,592 | Fixes #34913: azure_rm_loadbalance should accpet a list of rules instead of one | ##### SUMMARY
<!--- Describe the change, including rationale and design decisions -->
Fixes #34913
<!---
If you are fixing an existing issue, please include "Fixes #nnn" in your
commit message and your description; but you should still explain what
the change does.
-->
##### ISSUE TYPE
<!--- Pick one below... | 2018-02-01T08:24:29Z | azure_rm_loadbalance should accpet a list of rules instead of one
<!---
Verify first that your issue/request is not already reported on GitHub.
Also test if the latest release, and master branch are affected too.
-->
##### ISSUE TYPE
<!--- Pick one below and delete the rest -->
- Bug Report
##### COMPONENT ... | @yuwzho , could you please look at it? Thanks.
!component =lib/ansible/modules/cloud/azure/azure_rm_loadbalancer.py
cc @tstringer
[click here for bot help](https://github.com/ansible/ansibullbot/blob/master/ISSUE_HELP.md)
<!--- boilerplate: notify --->
I m working on this issue!
cc @haroldwongms @nitzmahone @trstringer... | [
{
"body": "<!---\r\nVerify first that your issue/request is not already reported on GitHub.\r\nAlso test if the latest release, and master branch are affected too.\r\n-->\r\n\r\n##### ISSUE TYPE\r\n<!--- Pick one below and delete the rest -->\r\n - Bug Report\r\n\r\n##### COMPONENT NAME\r\nazure_rm_loadbalance\... | 8a22b517557b2f61a50b35ba5e500f8136485a73 | {
"head_commit": "2e5ebe8c9b93f342f0b8815594d0530a3a8e9822",
"head_commit_message": "fix",
"patch_to_review": "diff --git a/lib/ansible/modules/cloud/azure/azure_rm_loadbalancer.py b/lib/ansible/modules/cloud/azure/azure_rm_loadbalancer.py\nindex 8b8e7bd5a1216d..d34f7c2effa84a 100755\n--- a/lib/ansible/modules/cl... | [
{
"diff_hunk": "@@ -61,89 +61,248 @@\n - Valid azure location. Defaults to location of the resource group.\n default: resource_group location\n required: false\n+ frontend_ip_configurations:\n+ description: Object representing the frontend IPs to be used for the load balanc... | 0b528ad77b7868ed10457c326beff40f692c3521 | diff --git a/lib/ansible/modules/cloud/azure/azure_rm_loadbalancer.py b/lib/ansible/modules/cloud/azure/azure_rm_loadbalancer.py
index 8b8e7bd5a1216d..b0231c23b7965e 100755
--- a/lib/ansible/modules/cloud/azure/azure_rm_loadbalancer.py
+++ b/lib/ansible/modules/cloud/azure/azure_rm_loadbalancer.py
@@ -1,22 +1,6 @@
#!/... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
apache__airflow-52265@c656f94 | apache/airflow | Python | 52,265 | Build python from source for CI | closes: #52106
Builds python from source, also installs
golang from official distribution. Does
both of these for the ci image only.
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional inform... | 2025-06-25T18:49:30Z | Change sources of our docker images
### Body
The "official" Python images are far less official than we thought. They are built by the community and while they are somewhat supervised by the "official Docker image program" there is really little control over the build and release process.
We should change the way we ... | Also we should add optional golang installation when we build the image.
Currently we are building our images by passing it image it should be build from
The command is similar to:
```
docker buildx build --load --builder default --progress=auto --cache-from=ghcr.io/apache/airflow/v2-11-test/ci/python3.9:cache-linux-... | [
{
"body": "### Body\n\nThe \"official\" Python images are far less official than we thought. They are built by the community and while they are somewhat supervised by the \"official Docker image program\" there is really little control over the build and release process.\n\nWe should change the way we build our... | 83348cda3aa95df1157bb09f7d88bdd574f4a5cb | {
"head_commit": "c656f94f1b86518fa263a3804f9616594bf45421",
"head_commit_message": "Updates path",
"patch_to_review": "diff --git a/Dockerfile.ci b/Dockerfile.ci\nindex 65907e3e4cee8..cdc54d44a1acd 100644\n--- a/Dockerfile.ci\n+++ b/Dockerfile.ci\n@@ -16,13 +16,13 @@\n #\n # WARNING: THIS DOCKERFILE IS NOT INTEN... | [
{
"diff_hunk": "@@ -0,0 +1,166 @@\n+#!/usr/bin/env bash\n+# Licensed to the Apache Software Foundation (ASF) under one\n+# or more contributor license agreements. See the NOTICE file\n+# distributed with this work for additional information\n+# regarding copyright ownership. The ASF licenses this file\n+# to ... | dcf109de7784dc63f18d0a1c192e7619e84f955d | diff --git a/.dockerignore b/.dockerignore
index c50ed5ae24ee6..75e6291445ab6 100644
--- a/.dockerignore
+++ b/.dockerignore
@@ -38,6 +38,7 @@
!providers/
!task-sdk/
!airflow-ctl/
+!go-sdk/
# Add all "test" distributions
!tests
diff --git a/.github/workflows/basic-tests.yml b/.github/workflows/basic-tests.yml
in... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Code Refactoring / Architectural Improvement"
} |
ansible__awx-1489@982b83c | ansible/awx | Python | 1,489 | Implemented new workflow node prompting | ##### SUMMARY
Workflow node prompting exists currently but is a much different user experience from the new launch/schedule prompting. This PR brings workflow node creation/editing in line with schedule prompting.
Part of primary feature dev for https://github.com/ansible/awx/issues/169
Should also fix https://gi... | 2018-03-08T23:52:29Z | Console traceback; 'replace' undefined when launching prompt for extra vars JT
##### ISSUE TYPE
<!--- Pick one below and delete the rest: -->
- Bug Report
##### COMPONENT NAME
<!-- Pick the area of AWX for this issue, you can have multiple, delete the rest: -->
- UI
##### SUMMARY
Console traceback when lau... | [
{
"body": "##### ISSUE TYPE\r\n<!--- Pick one below and delete the rest: -->\r\n - Bug Report\r\n\r\n##### COMPONENT NAME\r\n<!-- Pick the area of AWX for this issue, you can have multiple, delete the rest: -->\r\n - UI\r\n\r\n##### SUMMARY\r\nConsole traceback when launching JT with prompt for extra vars.\r\n\... | 8a25342ce588b8260d136893363ca61c72963cc1 | {
"head_commit": "982b83c2d3e51e9f9cc03159cb1a8b9cd5fe831a",
"head_commit_message": "Fixed several workflow prompting and edge type bugs",
"patch_to_review": "diff --git a/awx/ui/client/src/scheduler/schedulerEdit.controller.js b/awx/ui/client/src/scheduler/schedulerEdit.controller.js\nindex c73d7739c093..9e6c54f... | [
{
"diff_hunk": "@@ -798,114 +731,114 @@ angular.module('templates', [surveyMaker.name, jobTemplates.name, labels.name, p\n }\n };\n \n- inventoryLookup = {\n- searchPrefix: 'inventory',\n- name: 'templates.editWorkflowJobTe... | 9873bab45185926f52d98ef62f239838c4f9065e | diff --git a/awx/ui/client/src/scheduler/schedulerEdit.controller.js b/awx/ui/client/src/scheduler/schedulerEdit.controller.js
index c73d7739c093..9e6c54fb7cce 100644
--- a/awx/ui/client/src/scheduler/schedulerEdit.controller.js
+++ b/awx/ui/client/src/scheduler/schedulerEdit.controller.js
@@ -349,7 +349,7 @@ function(... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} | |
ansible__awx-1378@06bacd7 | ansible/awx | Python | 1,378 | disallow changing token-app | ##### SUMMARY
Fixes: https://github.com/ansible/awx/issues/1376
Blocks changing the application field on a token via PUT or PATCH as this field should be immutable.
##### ISSUE TYPE
<!--- Pick one below and delete the rest: -->
- Bugfix Pull Request
##### COMPONENT NAME
<!--- Name of the module/plug... | 2018-02-27T18:42:30Z | Able to PATCH a token to make its application None
##### ISSUE TYPE
- Bug Report
##### COMPONENT NAME
- API
##### SUMMARY
Able to remove application from token
##### ENVIRONMENT
* AWX version: 1.0.4-73
* AWX install method: docker for mac
* Ansible version: N/A
* Operating System:
* Web Browser:
... | [
{
"body": "##### ISSUE TYPE\r\n - Bug Report\r\n\r\n##### COMPONENT NAME\r\n - API\r\n\r\n##### SUMMARY\r\nAble to remove application from token\r\n\r\n##### ENVIRONMENT\r\n* AWX version: 1.0.4-73\r\n* AWX install method: docker for mac\r\n* Ansible version: N/A\r\n* Operating System:\r\n* Web Browser:\r\n\r\n... | 3605dbfd730c392d3620ccd964015d8ecc77b7e3 | {
"head_commit": "06bacd7bdcd5c430ec5389503261725592be4217",
"head_commit_message": "add serializer for token detail",
"patch_to_review": "diff --git a/awx/api/serializers.py b/awx/api/serializers.py\nindex 0057c69bd95a..1e8fdc8f12d0 100644\n--- a/awx/api/serializers.py\n+++ b/awx/api/serializers.py\n@@ -939,7 +9... | [
{
"diff_hunk": "@@ -1105,6 +1104,20 @@ def create(self, validated_data):\n )\n return obj\n \n+ \n+class OAuth2TokenDetailSerializer(OAuth2TokenSerializer):\n+\n+ refresh_token = serializers.SerializerMethodField()\n+ token = serializers.SerializerMethodField()\n+\n+ ... | 91c0f2da6f1d4a52fda12112f0d5d9e72e848058 | diff --git a/awx/api/serializers.py b/awx/api/serializers.py
index 0057c69bd95a..431c2bb19e18 100644
--- a/awx/api/serializers.py
+++ b/awx/api/serializers.py
@@ -939,7 +939,6 @@ class Meta:
'expires', 'scope', 'application',
)
read_only_fields = ('user', 'token', 'expires')
- read... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
ansible__ansible-35375@813bd18 | ansible/ansible | Python | 35,375 | Fix edit_config multiline commands on IOS | ##### SUMMARY
The current code for multiline commands in IOS is broken: If you
pass a dict containing a command, prompt and answer it is seen
later as unicode string, but if you do a json.loads it fails
as the keys/values are enclosed in single quotes but JSON requires
double quotes.
Fixes #23539
<!--- Des... | 2018-01-25T23:25:07Z | ios_config: multi-line command failure
<!---
Verify first that your issue/request is not already reported on GitHub.
Also test if the latest release, and master branch are affected too.
-->
##### ISSUE TYPE
- Bug Report
##### COMPONENT NAME
<!--- Name of the module/plugin/task/feature -->
ios_config
##### A... | cc @privateip @rcarrillocruz
[click here for bot help](https://github.com/ansible/ansibullbot/blob/master/ISSUE_HELP.md)
<!--- boilerplate: notify --->
Hi,
Issue 3591 on Ansible module score in 2016 already stated that commands (such as "no username") requiring multilines input were not supported by ios_config. This i... | [
{
"body": "<!---\r\nVerify first that your issue/request is not already reported on GitHub.\r\nAlso test if the latest release, and master branch are affected too.\r\n-->\r\n\r\n##### ISSUE TYPE\r\n - Bug Report\r\n##### COMPONENT NAME\r\n<!--- Name of the module/plugin/task/feature -->\r\nios_config\r\n##### A... | 73f3b36fb1beef0479fe54d4ef94f29c0f2cb820 | {
"head_commit": "813bd185943a9213a5c074860fad949c7028203d",
"head_commit_message": "Fix pep8",
"patch_to_review": "diff --git a/lib/ansible/plugins/cliconf/ios.py b/lib/ansible/plugins/cliconf/ios.py\nindex eee65794dd2c59..6a6fc64dc53c80 100644\n--- a/lib/ansible/plugins/cliconf/ios.py\n+++ b/lib/ansible/plugins... | [
{
"diff_hunk": "@@ -70,13 +70,13 @@ def get_config(self, source='running', flags=None):\n @enable_mode\n def edit_config(self, command):\n for cmd in chain(['configure terminal'], to_list(command), ['end']):\n- try:\n- cmd = json.loads(cmd)\n+ if cmd[0] == '{... | 3fd3cc8f537b4958d1ca9a49b843a28d79605c55 | diff --git a/lib/ansible/plugins/cliconf/ios.py b/lib/ansible/plugins/cliconf/ios.py
index eee65794dd2c59..e21ad4945890d5 100644
--- a/lib/ansible/plugins/cliconf/ios.py
+++ b/lib/ansible/plugins/cliconf/ios.py
@@ -19,6 +19,7 @@
from __future__ import (absolute_import, division, print_function)
__metaclass__ = type
... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-35326@8a102df | ansible/ansible | Python | 35,326 | win_disk_facts: Prefix facts with ansible_ and use raw values | ##### SUMMARY
This fixes #35325
This fixes #35329
##### ISSUE TYPE
- Bugfix Pull Request
##### COMPONENT NAME
win_disk_facts
##### ANSIBLE VERSION
v2.5 | 2018-01-25T02:20:05Z | win_disk_facts: facts are not being ansible_ namespaced
##### ISSUE TYPE
- Bug Report
##### COMPONENT NAME
win_disk_facts
##### ANSIBLE VERSION
v2.5
##### SUMMARY
So we established that facts need to be namespaced using a `ansible_` prefix. If not they may be conflicting/overriding user variables. Since t... | Files identified in the description:
* [lib/ansible/modules/windows/win_disk_facts.ps1](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/windows/win_disk_facts.ps1)
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot command.
[click... | [
{
"body": "##### ISSUE TYPE\r\n - Bug Report\r\n\r\n##### COMPONENT NAME\r\nwin_disk_facts\r\n\r\n##### ANSIBLE VERSION\r\nv2.5\r\n\r\n##### SUMMARY\r\nSo we established that facts need to be namespaced using a `ansible_` prefix. If not they may be conflicting/overriding user variables. Since this module is exp... | dd949c5b65c6ad95c4064c33ffe0307956f3f81a | {
"head_commit": "8a102dfff1f3f6bf6c06e748aa9494c7d6205e6a",
"head_commit_message": "win_disk_facts: Prefix facts with ansible_",
"patch_to_review": "diff --git a/lib/ansible/modules/windows/win_disk_facts.ps1 b/lib/ansible/modules/windows/win_disk_facts.ps1\nindex ac3f642769f7a1..67e877e6589b78 100644\n--- a/lib... | [
{
"diff_hunk": "@@ -39,7 +36,7 @@ try {\n Fail-Json -obj $result -message \"Failed to search the disks on the target: $($_.Exception.Message)\"\n }\n [int32]$diskcount = $disks | Measure-Object | Select-Object -ExpandProperty Count\n-$result.ansible_facts.total_disks = $diskcount\n+#$result.ansible_facts.t... | 747438d32afb6c796516bd30d297098f77fd6d89 | diff --git a/lib/ansible/modules/windows/win_disk_facts.ps1 b/lib/ansible/modules/windows/win_disk_facts.ps1
index ac3f642769f7a1..e41f29de7c20c0 100644
--- a/lib/ansible/modules/windows/win_disk_facts.ps1
+++ b/lib/ansible/modules/windows/win_disk_facts.ps1
@@ -8,28 +8,25 @@
$ErrorActionPreference = "Stop"
Set-Stric... | {
"difficulty": "low",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-34331@921cef2 | ansible/ansible | Python | 34,331 | windows become - info about blank passwords | ##### SUMMARY
Add info to the become docs for how to become a Windows account that does not have a password.
Fixes https://github.com/ansible/ansible/issues/34214
##### ISSUE TYPE
- Docs Pull Request
##### COMPONENT NAME
windows become
##### ANSIBLE VERSION
```
2.5
``` | 2018-01-01T22:23:44Z | Windows become fails for passwordless users
##### ISSUE TYPE
- Bug Report
- Feature Idea
##### COMPONENT NAME
windows
##### ANSIBLE VERSION
v2.5
##### SUMMARY
Not sure whether this is a bug report or a feature request. At least it is a known issue ;-)
Currently `become` on Windows does not work for p... | Files identified in the description:
* [test/integration/targets/win_become/aliases](https://github.com/ansible/ansible/blob/devel/test/integration/targets/win_become/aliases)
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot command.
[click here ... | [
{
"body": "##### ISSUE TYPE\r\n - Bug Report\r\n - Feature Idea\r\n\r\n##### COMPONENT NAME\r\nwindows\r\n\r\n##### ANSIBLE VERSION\r\nv2.5\r\n\r\n##### SUMMARY\r\nNot sure whether this is a bug report or a feature request. At least it is a known issue ;-)\r\n\r\nCurrently `become` on Windows does not work for ... | 32929f916af106aebac9757298e7eccf000f31d3 | {
"head_commit": "921cef2ef5904e568cbfe35a7dda2a45d0a1ea58",
"head_commit_message": "windows become - info about blank passwords",
"patch_to_review": "diff --git a/docs/docsite/rst/become.rst b/docs/docsite/rst/become.rst\nindex 32b12cd5f9882c..38c98d1950f525 100644\n--- a/docs/docsite/rst/become.rst\n+++ b/docs/... | [
{
"diff_hunk": "@@ -420,6 +420,38 @@ Because local service accounts do not have passwords, the\n ``ansible_become_password`` parameter is not required and is ignored if\n specified.\n \n+Accounts without a Password\n+---------------------------\n+\n+.. Warning:: Not setting a password for a Windows account is n... | 6057bf7c04121de8de1f424e751b56d603678681 | diff --git a/docs/docsite/rst/become.rst b/docs/docsite/rst/become.rst
index 32b12cd5f9882c..f7b69ee2d1da08 100644
--- a/docs/docsite/rst/become.rst
+++ b/docs/docsite/rst/become.rst
@@ -420,6 +420,35 @@ Because local service accounts do not have passwords, the
``ansible_become_password`` parameter is not required and... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "Bug Fixes"
} |
apache__airflow-51237@6dd1634 | apache/airflow | Python | 51,237 | Automatically classify test changes as SKIPPED while preparing providers | <!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may ... | 2025-05-30T11:41:39Z | Exclude changes on tests from provider release tagging proccess
### Body
PRs that modify only tests can be tagged automatically as skipped no need to ask release manager to tag them
### Committer
- [x] I acknowledge that I am a maintainer/committer of the Apache Airflow project. | @eladkal I am self assigning this one. Will get to it as soon as possible!
I think this one we can automate this with labels, probably when PR gets opened scan the pr in gh workflow and if changes are only under something like `*/tests/* ` then add label to PR skip-changelog? i believe this will skip from the release p... | [
{
"body": "### Body\n\nPRs that modify only tests can be tagged automatically as skipped no need to ask release manager to tag them\n\n\n### Committer\n\n- [x] I acknowledge that I am a maintainer/committer of the Apache Airflow project.",
"number": 51132,
"title": "Exclude changes on tests from provide... | a8054bf7c0ccbf34b654ad6dbbc1c0a757328673 | {
"head_commit": "6dd1634f71b99802df1fe2892a3d4b659fe640d7",
"head_commit_message": "Automatically classify test changes as SKIPPED while preparing providers",
"patch_to_review": "diff --git a/dev/breeze/doc/images/output_release-management_prepare-provider-documentation.svg b/dev/breeze/doc/images/output_release... | [
{
"diff_hunk": "@@ -715,13 +716,51 @@ def _update_commits_rst(\n )\n \n \n+def _is_test_only_changes(pr_number: str, github_token: str | None = None) -> bool:",
"line": null,
"original_line": 719,
"original_start_line": null,
"path": "dev/breeze/src/airflow_breeze/prepare_providers/provider_... | b021d1a8570824f264f16ae40f8df0182cfd7e7f | diff --git a/dev/breeze/src/airflow_breeze/prepare_providers/provider_documentation.py b/dev/breeze/src/airflow_breeze/prepare_providers/provider_documentation.py
index 844b3c1790f93..280b837c05f63 100644
--- a/dev/breeze/src/airflow_breeze/prepare_providers/provider_documentation.py
+++ b/dev/breeze/src/airflow_breeze... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Code Refactoring / Architectural Improvement"
} |
ansible__ansible-33958@d8a870e | ansible/ansible | Python | 33,958 | win_iis_webbinding rewrite | ##### SUMMARY
<!--- Describe the change, including rationale and design decisions -->
<!---
If you are fixing an existing issue, please include "Fixes #nnn" in your
commit message and your description; but you should still explain what
the change does.
-->
I'm expecting that this will probably fail the Shipp... | 2017-12-15T19:33:06Z | windows: ansible fails to connect after IIS binding with SNI enabled is added
<!---
Verify first that your issue/request is not already reported on GitHub.
Also test if the latest release, and master branch are affected too.
-->
##### ISSUE TYPE
<!--- Pick one below and delete the rest: -->
- Bug Report
#... | Files identified in the description:
* [lib/ansible/plugins/connection](https://github.com/ansible/ansible/blob/devel/lib/ansible/plugins/connection)
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot command.
[click here for bot help](https://gith... | [
{
"body": "<!---\r\nVerify first that your issue/request is not already reported on GitHub.\r\nAlso test if the latest release, and master branch are affected too.\r\n-->\r\n\r\n##### ISSUE TYPE\r\n<!--- Pick one below and delete the rest: -->\r\n - Bug Report\r\n\r\n\r\n##### COMPONENT NAME\r\n<!--- Name of th... | c2ac9d08318d838e4571587e153338f66eb22b0d | {
"head_commit": "d8a870e522f859dcd1fcb0976439ab4ba3b91eda",
"head_commit_message": "updated test to remove tests as filters",
"patch_to_review": "diff --git a/lib/ansible/modules/windows/win_iis_webbinding.ps1 b/lib/ansible/modules/windows/win_iis_webbinding.ps1\nindex 9b212ff968f3e1..8f020c31961709 100644\n--- ... | [
{
"diff_hunk": "@@ -28,74 +15,58 @@\n ---\n module: win_iis_webbinding\n version_added: \"2.0\"\n-short_description: Configures a IIS Web site.\n+short_description: Configures a IIS Web site binding.\n description:\n - Creates, Removes and configures a binding to an existing IIS Web site\n options:\n nam... | 5ddfe298951ee81685d5d0ced4383ec3f263c04d | diff --git a/lib/ansible/modules/windows/win_iis_webbinding.ps1 b/lib/ansible/modules/windows/win_iis_webbinding.ps1
index 9b212ff968f3e1..8f020c31961709 100644
--- a/lib/ansible/modules/windows/win_iis_webbinding.ps1
+++ b/lib/ansible/modules/windows/win_iis_webbinding.ps1
@@ -1,131 +1,454 @@
#!powershell
-# (c) 20... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-33909@d516d5b | ansible/ansible | Python | 33,909 | Cliconf and Netconf refactoring iosxr_interface | ##### SUMMARY
refactor cliconf and add netconf support
fixes #33324
##### ISSUE TYPE
<!--- Pick one below and delete the rest: -->
- Feature Pull Request
##### COMPONENT NAME
iosxr_interface
##### ANSIBLE VERSION
<!--- Paste verbatim output from "ansible --version" between quotes below -->
```
2.5.0
... | 2017-12-14T11:33:25Z | [NETCONF] Refactor IOSXR modules to support netconf plugin
##### ISSUE TYPE
<!--- Pick one below and delete the rest: -->
- Feature Idea
##### COMPONENT NAME
iosxr
##### ANSIBLE VERSION
<!--- Paste verbatim output from "ansible --version" between quotes below -->
```
2.5
```
##### OS / ENVIRONMEN... | Files identified in the description:
* [lib/ansible/module_utils/iosxr.py](https://github.com/ansible/ansible/blob/devel/lib/ansible/module_utils/iosxr.py)
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot command.
[click here for bot help](https:... | [
{
"body": "##### ISSUE TYPE\r\n<!--- Pick one below and delete the rest: -->\r\n - Feature Idea\r\n\r\n\r\n##### COMPONENT NAME\r\niosxr\r\n\r\n##### ANSIBLE VERSION\r\n<!--- Paste verbatim output from \"ansible --version\" between quotes below -->\r\n```\r\n2.5\r\n```\r\n\r\n\r\n\r\n##### OS / ENVIRONMENT\r\nm... | 5578193ae4f6caa5a28c831449911645eef12e68 | {
"head_commit": "d516d5b17d7546ac288890ada958ae24d5247b03",
"head_commit_message": "adds `xml` key and related changes for netconf output",
"patch_to_review": "diff --git a/lib/ansible/module_utils/network/common/netconf.py b/lib/ansible/module_utils/network/common/netconf.py\nindex 218bedc79f983b..234d125830e85... | [
{
"diff_hunk": "@@ -17,34 +17,47 @@\n ---\n module: iosxr_interface\n version_added: \"2.4\"\n-author: \"Ganesh Nalawade (@ganeshrn)\"\n+author:\n+ - \"Ganesh Nalawade (@ganeshrn)\"\n+ - \"Kedar Kekan (@kedarX)\"\n short_description: Manage Interface on Cisco IOS XR network devices\n description:\n - Th... | acb18579cff10920f78ded1756d57b35469015ec | diff --git a/lib/ansible/module_utils/network/common/netconf.py b/lib/ansible/module_utils/network/common/netconf.py
index 218bedc79f983b..234d125830e855 100644
--- a/lib/ansible/module_utils/network/common/netconf.py
+++ b/lib/ansible/module_utils/network/common/netconf.py
@@ -77,7 +77,11 @@ def parse_rpc_error(self, ... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Code Refactoring / Architectural Improvement"
} |
ansible__ansible-33889@8614eb5 | ansible/ansible | Python | 33,889 | Fix vyos sending `'None'` to device | ##### SUMMARY
<!--- Describe the change, including rationale and design decisions -->
<!---
If you are fixing an existing issue, please include "Fixes #nnn" in your
commit message and your description; but you should still explain what
the change does.
-->
Fixes #33804
##### ISSUE TYPE
<!--- Pick one below... | 2017-12-13T21:52:22Z | vyos_facts: Invalid command: [None]
##### ISSUE TYPE
- Bug Report
##### COMPONENT NAME
vyos_facts
##### ANSIBLE VERSION
```
ansible 2.5.0 (devel ff525ab3d1) last updated 2017/12/12 09:41:06 (GMT +100)
```
##### SUMMARY
<!--- Explain the problem briefly -->
##### STEPS TO REPRODUCE
```yaml
[vyos]
... | Files identified in the description:
* [lib/ansible/modules/network/vyos/vyos_facts.py](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/network/vyos/vyos_facts.py)
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot command.
[click... | [
{
"body": "##### ISSUE TYPE\r\n - Bug Report\r\n\r\n##### COMPONENT NAME\r\nvyos_facts\r\n\r\n##### ANSIBLE VERSION\r\n```\r\nansible 2.5.0 (devel ff525ab3d1) last updated 2017/12/12 09:41:06 (GMT +100)\r\n\r\n```\r\n\r\n##### SUMMARY\r\n<!--- Explain the problem briefly -->\r\n\r\n##### STEPS TO REPRODUCE\r\n`... | 98260f9884fd265ea1037e3d58acf3cc50d2981a | {
"head_commit": "8614eb53f21195b91cc127eecfbd1798e33964ac",
"head_commit_message": "Fix vyos sending `'None'` to device",
"patch_to_review": "diff --git a/lib/ansible/plugins/cliconf/vyos.py b/lib/ansible/plugins/cliconf/vyos.py\nindex 84c137f9cfb255..9386298d9b8ac3 100644\n--- a/lib/ansible/plugins/cliconf/vyos... | [
{
"diff_hunk": "@@ -59,7 +59,13 @@ def edit_config(self, command):\n self.send_command(cmd)\n \n def get(self, command, prompt=None, answer=None, sendonly=False):\n- return self.send_command(to_bytes(command), prompt=to_bytes(prompt), answer=to_bytes(answer), sendonly=sendonly)\n+ ... | 8ae8007ea0c405394097c3e71fa87df3b6582b9e | diff --git a/lib/ansible/plugins/cliconf/__init__.py b/lib/ansible/plugins/cliconf/__init__.py
index da2f442d566644..8faccc16f1fa8d 100644
--- a/lib/ansible/plugins/cliconf/__init__.py
+++ b/lib/ansible/plugins/cliconf/__init__.py
@@ -25,6 +25,7 @@
from functools import wraps
from ansible.errors import AnsibleError... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-33792@659e82f | ansible/ansible | Python | 33,792 | Handle duplicate headers in the uri module | ##### SUMMARY
...and make it easier for users to use cookies by providing a pre-built string
FIxes #33325
##### ISSUE TYPE
- Bugfix Pull Request
##### COMPONENT NAME
uri
##### ANSIBLE VERSION
<!--- Paste verbatim output from "ansible --version" between quotes below -->
```
devel
```
##### ADDITI... | 2017-12-11T22:25:21Z | uri module doesn’t handle multiple cookies with same name
<!---
Verify first that your issue/request is not already reported on GitHub.
Also test if the latest release, and master branch are affected too.
-->
##### ISSUE TYPE
<!--- Pick one below and delete the rest: -->
- Bug Report
- Feature Idea
- Docum... | If there are two cookies with the same name, the last one should replace the first one. URI modules set cookies keep both of them.
Please fill out the template with actionable information
needs_info
cc @romeotheriault
[click here for bot help](https://github.com/ansible/ansibullbot/blob/master/ISSUE_HELP.md)
<!--- ... | [
{
"body": "<!---\r\nVerify first that your issue/request is not already reported on GitHub.\r\nAlso test if the latest release, and master branch are affected too.\r\n-->\r\n\r\n##### ISSUE TYPE\r\n<!--- Pick one below and delete the rest: -->\r\n - Bug Report\r\n - Feature Idea\r\n - Documentation Report\r\n\r... | 6300e71903ef02212f792b09c9b6720a55bfdf24 | {
"head_commit": "659e82f72e5fd1ef48ea2289c14bf2cf9c61212c",
"head_commit_message": "Add some notes in test code",
"patch_to_review": "diff --git a/lib/ansible/module_utils/urls.py b/lib/ansible/module_utils/urls.py\nindex 1470367f5d2961..9d4c17cfefd0c3 100644\n--- a/lib/ansible/module_utils/urls.py\n+++ b/lib/an... | [
{
"diff_hunk": "@@ -1049,11 +1049,36 @@ def fetch_url(module, url, data=None, headers=None, method=None,\n url_password=password, http_agent=http_agent, force_basic_auth=force_basic_auth,\n follow_redirects=follow_redirects, client_cert=client_cert,\n ... | 8ff4ad42b392973ccc472a1681cc332f2d62e3f9 | diff --git a/lib/ansible/module_utils/urls.py b/lib/ansible/module_utils/urls.py
index 1470367f5d2961..c3d8ae9b9fc56d 100644
--- a/lib/ansible/module_utils/urls.py
+++ b/lib/ansible/module_utils/urls.py
@@ -51,6 +51,9 @@
import ansible.module_utils.six.moves.http_cookiejar as cookiejar
import ansible.module_utils.six... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-33624@28d30a5 | ansible/ansible | Python | 33,624 | fix failure `got multiple values for keyword argument id` | ##### SUMMARY
<!--- Describe the change, including rationale and design decisions -->
This is a bug due to API change from new Azure SDK
<!---
If you are fixing an existing issue, please include "Fixes #nnn" in your
commit message and your description; but you should still explain what
the change does.
-->
##... | 2017-12-06T09:44:37Z | azure_rm_securitygroup.py has some problem when creating security group in china region
<!---
Verify first that your issue/request is not already reported on GitHub.
Also test if the latest release, and master branch are affected too.
-->
##### ISSUE TYPE
<!--- Pick one below and delete the rest: -->
- Bug Rep... | [
{
"body": "<!---\r\nVerify first that your issue/request is not already reported on GitHub.\r\nAlso test if the latest release, and master branch are affected too.\r\n-->\r\n\r\n##### ISSUE TYPE\r\n<!--- Pick one below and delete the rest: -->\r\n - Bug Report\r\nansible azrure module cannot create security gro... | a28eb94f1a37d0293e05e289b95835ea47832e73 | {
"head_commit": "28d30a54404fa7413aaccfd6ea80a5ad078e1ce4",
"head_commit_message": "fix test case failure",
"patch_to_review": "diff --git a/lib/ansible/modules/cloud/azure/azure_rm_securitygroup.py b/lib/ansible/modules/cloud/azure/azure_rm_securitygroup.py\nindex b6008ef5e51bf6..32c14da1a8c313 100644\n--- a/li... | [
{
"diff_hunk": "@@ -447,10 +447,10 @@ def create_rule_instance(rule):\n '''\n return SecurityRule(\n rule['protocol'],\n- rule['source_address_prefix'],\n- rule['destination_address_prefix'],\n rule['access'],\n rule['direction'],\n+ source_address_prefix=rul... | 1ed2008f3c191b66e9e44f441e83d4222dc7482d | diff --git a/lib/ansible/modules/cloud/azure/azure_rm_securitygroup.py b/lib/ansible/modules/cloud/azure/azure_rm_securitygroup.py
index b6008ef5e51bf6..8f502a6948d5f2 100644
--- a/lib/ansible/modules/cloud/azure/azure_rm_securitygroup.py
+++ b/lib/ansible/modules/cloud/azure/azure_rm_securitygroup.py
@@ -446,11 +446,1... | {
"difficulty": "medium",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} | |
ansible__ansible-33223@ab07b73 | ansible/ansible | Python | 33,223 | Fix #33114: vmss has parameter load balancer | ##### SUMMARY
<!--- Describe the change, including rationale and design decisions -->
Fix #33114
<!---
If you are fixing an existing issue, please include "Fixes #nnn" in your
commit message and your description; but you should still explain what
the change does.
-->
Azure virtual machine scale set can h... | 2017-11-23T10:32:30Z | azure_rm_virtualmachine_scaleset should support Azure Azure Load Balancer with inbound NAT rules
<!---
Verify first that your issue/request is not already reported on GitHub.
Also test if the latest release, and master branch are affected too.
-->
##### ISSUE TYPE
<!--- Pick one below and delete the rest: -->
... | @yaweiw @zikalino
cc @sozercan
[click here for bot help](https://github.com/ansible/ansibullbot/blob/master/ISSUE_HELP.md)
<!--- boilerplate: notify ---> | [
{
"body": "<!---\r\nVerify first that your issue/request is not already reported on GitHub.\r\nAlso test if the latest release, and master branch are affected too.\r\n-->\r\n\r\n##### ISSUE TYPE\r\n<!--- Pick one below and delete the rest: -->\r\n - Feature Idea\r\n\r\n##### COMPONENT NAME\r\n<!--- Name of the ... | 7adf91997d457c496315d00d85bea1e4786b1586 | {
"head_commit": "ab07b733e403bd4dd79b9eb5028ca5dc9bb3c237",
"head_commit_message": "fix indent",
"patch_to_review": "diff --git a/lib/ansible/modules/cloud/azure/azure_rm_virtualmachine_scaleset.py b/lib/ansible/modules/cloud/azure/azure_rm_virtualmachine_scaleset.py\nindex 776c7340dd8136..558dca77985522 100644\... | [
{
"diff_hunk": "@@ -678,6 +700,13 @@ def get_subnet(self, vnet_name, subnet_name):\n str(exc)))\n return subnet\n \n+ def get_load_balancer(self, id):\n+ id_dict = parse_resource_id(id)\n+ try:\n+ return self.network_client.load_balancers.get(id_dict.get('reso... | f26e21255a01743b8cd73852bd2c110e7e8e8443 | diff --git a/lib/ansible/modules/cloud/azure/azure_rm_virtualmachine_scaleset.py b/lib/ansible/modules/cloud/azure/azure_rm_virtualmachine_scaleset.py
index 776c7340dd8136..b1d893a2b0f521 100644
--- a/lib/ansible/modules/cloud/azure/azure_rm_virtualmachine_scaleset.py
+++ b/lib/ansible/modules/cloud/azure/azure_rm_virt... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
ansible__ansible-32734@355e123 | ansible/ansible | Python | 32,734 | python3 support for letsencrypt module (fixes #30690) | * decorate fetch_url to upsert lowercase representation of the header names returned in info-dict
* initialize result to a dict in some methods to prevent 'NoneType is not iterable' TypeError
* use dict.get() to retrieve values from info dict to prevent KeyError
* convert to/from text/bytes using _text... | 2017-11-09T12:09:53Z | Lets Encrypt module appears to fail with Python 3
<!---
Verify first that your issue/request is not already reported on GitHub.
Also test if the latest release, and master branch are affected too.
-->
This appears to be the only report
##### ISSUE TYPE
- Bug Report
##### COMPONENT NAME
lib/ansible/modu... | cc @dagwieers
[click here for bot help](https://github.com/ansible/ansibullbot/blob/master/ISSUE_HELP.md)
<!--- boilerplate: notify --->
\cc @mgruener bug in the letsencrypt module | [
{
"body": "<!---\r\nVerify first that your issue/request is not already reported on GitHub.\r\nAlso test if the latest release, and master branch are affected too.\r\n-->\r\n\r\nThis appears to be the only report\r\n\r\n##### ISSUE TYPE\r\n - Bug Report\r\n\r\n##### COMPONENT NAME\r\n\r\nlib/ansible/modules/web... | 446463578709af20a602fee66663386361cc02a5 | {
"head_commit": "355e12327a8cb66d69cfb5c21e3ace29fd559c7d",
"head_commit_message": "fix dict comprehension sytax error in py2.6",
"patch_to_review": "diff --git a/lib/ansible/modules/web_infrastructure/letsencrypt.py b/lib/ansible/modules/web_infrastructure/letsencrypt.py\nindex c1496cac78d519..3f7a39f85f6e9e 10... | [
{
"diff_hunk": "@@ -168,24 +168,39 @@\n import traceback\n from datetime import datetime\n \n+from functools import wraps\n from ansible.module_utils.basic import AnsibleModule\n-from ansible.module_utils._text import to_native\n+from ansible.module_utils._text import to_native, to_text, to_bytes\n from ansible... | fcd8d6b61dddc82c31942ba11c6ce0942ac356b0 | diff --git a/lib/ansible/modules/web_infrastructure/letsencrypt.py b/lib/ansible/modules/web_infrastructure/letsencrypt.py
index c1496cac78d519..cd9339234671d1 100644
--- a/lib/ansible/modules/web_infrastructure/letsencrypt.py
+++ b/lib/ansible/modules/web_infrastructure/letsencrypt.py
@@ -169,8 +169,22 @@
from dateti... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-32614@debcf29 | ansible/ansible | Python | 32,614 | Fixes #30863: support update source_address_prefix in azure_rm_securitygroup | ##### SUMMARY
<!--- Describe the change, including rationale and design decisions -->
Fixes #30863
Fix the security group cannot update source data prefix problem
<!---
If you are fixing an existing issue, please include "Fixes #nnn" in your
commit message and your description; but you should still explain wh... | 2017-11-07T08:48:20Z | Try to update azure_rm_securitygroup : source_address_prefix
<!---
Verify first that your issue/request is not already reported on GitHub.
Also test if the latest release, and master branch are affected too.
-->
##### ISSUE TYPE
- Bug Report
##### COMPONENT NAME
<!--- Name of the module/plugin/task/feature ... | cc @haroldwongms @nitzmahone @tstringer
[click here for bot help](https://github.com/ansible/ansibullbot/blob/master/ISSUE_HELP.md)
<!--- boilerplate: notify --->
cc @chouseknecht
[click here for bot help](https://github.com/ansible/ansibullbot/blob/master/ISSUE_HELP.md)
<!--- boilerplate: notify ---> | [
{
"body": "<!---\r\nVerify first that your issue/request is not already reported on GitHub.\r\nAlso test if the latest release, and master branch are affected too.\r\n-->\r\n\r\n##### ISSUE TYPE\r\n - Bug Report\r\n\r\n##### COMPONENT NAME\r\n<!--- Name of the module/plugin/task/feature -->\r\n\r\n`azure_rm_sec... | a2d34e914e169d08956ea807aab4d5539d31e8ce | {
"head_commit": "debcf29f4f6f7cbfb537565fdf022ae24c78b544",
"head_commit_message": "compare source address prefix",
"patch_to_review": "diff --git a/lib/ansible/modules/cloud/azure/azure_rm_securitygroup.py b/lib/ansible/modules/cloud/azure/azure_rm_securitygroup.py\nindex c934eddb27b603..9a4653f59fed98 100644\n... | [
{
"diff_hunk": "@@ -41,30 +41,35 @@\n resource_group: \"{{ resource_group }}\"\n name: mysecgroup\n rules:\n- - name: DenySSH\n+ - name: 'AllowSSH'",
"line": null,
"original_line": 44,
"original_start_line": null,
"path": "test/integration/targets/azure_rm_sec... | 95f409f046c7d17db58e8af2794af079221c0dcb | diff --git a/lib/ansible/modules/cloud/azure/azure_rm_securitygroup.py b/lib/ansible/modules/cloud/azure/azure_rm_securitygroup.py
index c934eddb27b603..9a4653f59fed98 100644
--- a/lib/ansible/modules/cloud/azure/azure_rm_securitygroup.py
+++ b/lib/ansible/modules/cloud/azure/azure_rm_securitygroup.py
@@ -426,6 +426,9 ... | {
"difficulty": "medium",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-32589@74df838 | ansible/ansible | Python | 32,589 | Add azure image module support create and delete | ##### SUMMARY
<!--- Describe the change, including rationale and design decisions -->
Add Azure Image module support
It supports
- Create an image from an existing VM.
- Create an image from OS disk and data disk with OS type specific, where the disk can be a disk, blob uri or snapshot.
- Delete an existing image... | 2017-11-06T10:55:35Z | Azure module for Managed Images
It would be greate if a module for Azure could be writting to interact with Managed Images. Currently, Azure supports two methonds for interacting with images. 1. Images from the Marketplace that someone else builds and maintains. 2. Managed Images that I'm responsible for building and m... | cc @dharmabumstead @jwhitbeck
[click here for bot help](https://github.com/ansible/ansibullbot/blob/master/ISSUE_HELP.md)
<!--- boilerplate: notify --->
Hi @codyja, there are currently 2 PR's available that will add these features. If you have any time it would be good if you could test them out and give your feedback ... | [
{
"body": "It would be greate if a module for Azure could be writting to interact with Managed Images. Currently, Azure supports two methonds for interacting with images. 1. Images from the Marketplace that someone else builds and maintains. 2. Managed Images that I'm responsible for building and maintaining, a... | dc40efc13f2b344235ff668a2c3c6b235219f239 | {
"head_commit": "74df838f2fab1086099119fe6902d00168ec70a9",
"head_commit_message": "update for python3",
"patch_to_review": "diff --git a/lib/ansible/module_utils/azure_rm_common.py b/lib/ansible/module_utils/azure_rm_common.py\nindex f40ddfcc8eaa89..3a4607b24dbd38 100644\n--- a/lib/ansible/module_utils/azure_rm... | [
{
"diff_hunk": "@@ -0,0 +1,372 @@\n+#!/usr/bin/python\n+#\n+# Copyright (c) 2017 Yuwei Zhou, <yuwzho@microsoft.com>\n+#\n+# GNU General Public License v3.0+ (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt)\n+\n+from __future__ import absolute_import, division, print_function\n+__metaclass__ = type\n+\n... | fe9084ae422bf477bf8cbc16bf1b9641771f89a7 | diff --git a/lib/ansible/module_utils/azure_rm_common.py b/lib/ansible/module_utils/azure_rm_common.py
index f40ddfcc8eaa89..3a4607b24dbd38 100644
--- a/lib/ansible/module_utils/azure_rm_common.py
+++ b/lib/ansible/module_utils/azure_rm_common.py
@@ -110,6 +110,7 @@
try:
from enum import Enum
from msrestazur... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
ansible__ansible-32135@7b6d2a8 | ansible/ansible | Python | 32,135 | Avoid default inventory proccessing for pull | ##### SUMMARY
- now pull's own special inventory processing should work correctly
- also removed ineffective set_defaults
fixes #31449
##### ISSUE TYPE
<!--- Pick one below and delete the rest: -->
- Bugfix Pull Request
##### COMPONENT NAME
<!--- Name of the module/plugin/module/task -->
pull
##### A... | 2017-10-25T12:48:03Z | ansible-pull broke fully after update from 2.3 to 2.4
##### ISSUE TYPE
- Bug Report
##### COMPONENT NAME
ansible-pull
##### ANSIBLE VERSION
```
~> ansible --version
ansible 2.4.0.0
config file = /home/klaus/.ansible.cfg
configured module search path = [u'/home/klaus/.ansible/plugins/modules', u'/usr/s... | I found some hints.
If I create a static `/root/hosts` file, just having the hostname in it, I get the following:
```
~> ANSIBLE_FORCE_COLOR=true ansible-pull --url=git@tschil:ansible --inventory=hosts --private-key=/root/.ssh/ansible.key --full --force site.yaml
Starting Ansible Pull at 2017-10-08 17:54:35
/us... | [
{
"body": "##### ISSUE TYPE\r\n - Bug Report\r\n\r\n##### COMPONENT NAME\r\nansible-pull\r\n\r\n##### ANSIBLE VERSION\r\n```\r\n~> ansible --version\r\nansible 2.4.0.0\r\n config file = /home/klaus/.ansible.cfg\r\n configured module search path = [u'/home/klaus/.ansible/plugins/modules', u'/usr/share/ansible/... | ca115b0a8e96ad571a597420b093a4103e77b809 | {
"head_commit": "7b6d2a85463701706c4110de13f7eeac0d86d38e",
"head_commit_message": "Avoid default inventory proccessing for pull\n\n- now pull's own special inventory processing should work correctly\n- also removed ineffective set_defaults\n\nfixes #31449",
"patch_to_review": "diff --git a/lib/ansible/cli/__ini... | [
{
"diff_hunk": "@@ -605,8 +604,8 @@ def parse(self):\n skip_tags.add(tag.strip())\n self.options.skip_tags = list(skip_tags)\n \n- # process inventory options\n- if hasattr(self.options, 'inventory'):\n+ # process inventory options except for CLIs that requir... | fd34574da91ae37716f4e20bdcc630a1fbe60fd2 | diff --git a/lib/ansible/cli/__init__.py b/lib/ansible/cli/__init__.py
index 7aef18e8b48846..6be28d5762e513 100644
--- a/lib/ansible/cli/__init__.py
+++ b/lib/ansible/cli/__init__.py
@@ -112,6 +112,7 @@ class CLI(with_metaclass(ABCMeta, object)):
# -F (quit-if-one-screen) -R (allow raw ansi control chars)
# -... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-31452@e69f156 | ansible/ansible | Python | 31,452 | replace - fixed combined before and after usage | ##### SUMMARY
Combined usage of `before` and `after` options should select a subsection after the `after`, and before the `before`. Currently, it does the opposite. (Singular use of each option works as expected, though docs were poorly written.)
Additionally, subsection replacement should use start and end indic... | 2017-10-08T16:43:33Z | replace module before/after wrong way around
##### ISSUE TYPE
- Bug Report
##### COMPONENT NAME
files/replace module
##### ANSIBLE VERSION
```
2.4.0.0
```
##### CONFIGURATION
N/A
##### OS / ENVIRONMENT
N/A
##### SUMMARY
Simply try to use the replace module with either "before:" or "after:"... | cc @EvanK
[click here for bot help](https://github.com/ansible/ansibullbot/blob/master/ISSUE_HELP.md)
<!--- boilerplate: notify --->
The `before`/`after` options were added in [cd39ff9](https://github.com/ansible/ansible/commit/cd39ff9996e5449aa5e777537edf0b17897fc94d) by @j-carl, and definitely should have been tested... | [
{
"body": "##### ISSUE TYPE\r\n - Bug Report\r\n\r\n##### COMPONENT NAME\r\nfiles/replace module\r\n\r\n##### ANSIBLE VERSION\r\n\r\n```\r\n2.4.0.0\r\n```\r\n\r\n##### CONFIGURATION\r\n\r\nN/A\r\n##### OS / ENVIRONMENT\r\n\r\nN/A\r\n\r\n##### SUMMARY\r\n\r\nSimply try to use the replace module with either \"bef... | 2a65c72a6ad2606eed634706d19dedb944b0bb5f | {
"head_commit": "e69f156f9dea1e81b0afef43bcdbcdb9895fc178",
"head_commit_message": "Cleaned up a rebase flub",
"patch_to_review": "diff --git a/lib/ansible/modules/files/replace.py b/lib/ansible/modules/files/replace.py\nindex c816d64de13c8e..8b5c0ef4a9047d 100644\n--- a/lib/ansible/modules/files/replace.py\n+++... | [
{
"diff_hunk": "@@ -57,21 +57,25 @@\n - The string to replace regexp matches.\n - May contain backreferences that will get expanded with the regexp capture groups if the regexp matches.\n - If not set, matches are removed entirely.\n+ - Backreferences can be used ambiguously like C(\\\\1)... | dee4b7fbbded300d00e3c1cab04d069064568838 | diff --git a/changelogs/fragments/replace-before-after.yaml b/changelogs/fragments/replace-before-after.yaml
new file mode 100644
index 00000000000000..a50d238932f331
--- /dev/null
+++ b/changelogs/fragments/replace-before-after.yaml
@@ -0,0 +1,2 @@
+bugfixes:
+ - replace - fix behavior when ``before`` and ``after`` a... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-31642@5d3898b | ansible/ansible | Python | 31,642 | fix documentation to match default/required status of 'state' | ##### SUMMARY
simple docfix. Fixes #31639.
##### ISSUE TYPE
- Docs Pull Request
##### COMPONENT NAME
cloud/amazon/cloudformation
##### ANSIBLE VERSION
devel head | 2017-10-12T15:55:05Z | [cloudformation] 'state' is not a required option
The `cloudformation` doc specifies that the `state` option is **required**. But that is not the case in the argument spec in code -
> state=dict(default='present', choices=['present', 'absent'])
So either the doc needs to be fixed or we need to enforce the presenc... | cc @jsmartin @ryansb @tedder
[click here for bot help](https://github.com/ansible/ansibullbot/blob/master/ISSUE_HELP.md)
<!--- boilerplate: notify --->
Yeah, default + required is kinda silly. I'll remove required. | [
{
"body": "The `cloudformation` doc specifies that the `state` option is **required**. But that is not the case in the argument spec in code -\r\n\r\n> state=dict(default='present', choices=['present', 'absent'])\r\n\r\nSo either the doc needs to be fixed or we need to enforce the presence of the `state` option... | 402b095841d901b012f20e9473bdee6b0f43a398 | {
"head_commit": "5d3898b5c6f9af3654beaae38b170642c92f744f",
"head_commit_message": "fix documentation to match default/required status of 'state'",
"patch_to_review": "diff --git a/lib/ansible/modules/cloud/amazon/cloudformation.py b/lib/ansible/modules/cloud/amazon/cloudformation.py\nindex b6f65413ab1ffe..33c99... | [
{
"diff_hunk": "@@ -47,7 +47,8 @@\n description:\n - If state is \"present\", stack will be created. If state is \"present\" and if stack exists and template has changed, it will be updated.\n If state is \"absent\", stack will be removed.\n- required: true\n+ default: present\n+ req... | 95d8effead985d323b17c2eae08f373c082db2bf | diff --git a/lib/ansible/modules/cloud/amazon/cloudformation.py b/lib/ansible/modules/cloud/amazon/cloudformation.py
index b6f65413ab1ffe..cba467cab4740b 100644
--- a/lib/ansible/modules/cloud/amazon/cloudformation.py
+++ b/lib/ansible/modules/cloud/amazon/cloudformation.py
@@ -47,7 +47,9 @@
description:
- ... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-31313@1a2e5ab | ansible/ansible | Python | 31,313 | Properly handle user selection of `None` as vars_files | In a playbook, if a user has a playbook like:
```
- hosts: localhost
connection: local
vars_files:
tasks:
- ....
```
Then `vars_files` will be none, and cause a `TypeError` in vars-manager when it
tries to iterate over them. To avoid this, I changed the getter to either send
back the vars files fr... | 2017-10-04T13:36:26Z | Unexpected Exception, this is probably a bug: 'NoneType' object is not iterable
<!---
Verify first that your issue/request is not already reported on GitHub.
Also test if the latest release, and master branch are affected too.
-->
##### ISSUE TYPE
<!--- Pick one below and delete the rest: -->
- Bug Report
#... | The workaround here is, of course, to supply an empty list instead of a `None`. I notice that the vars file attributes are defaulted to `[]`, but won't override if the use supplies `None` which we could definitely handle more gracefully. | [
{
"body": "<!---\r\nVerify first that your issue/request is not already reported on GitHub.\r\nAlso test if the latest release, and master branch are affected too.\r\n-->\r\n\r\n##### ISSUE TYPE\r\n<!--- Pick one below and delete the rest: -->\r\n - Bug Report\r\n\r\n##### COMPONENT NAME\r\n<!--- Name of the mo... | a9942353fe0e9a1e54972ba87b38d967e496b02f | {
"head_commit": "1a2e5ab08c78ceacb17192434e6739552f07313f",
"head_commit_message": "Catch error when vars_files isn't iterable",
"patch_to_review": "diff --git a/lib/ansible/playbook/play.py b/lib/ansible/playbook/play.py\nindex 2fe4a9020def71..ccd3b323a1d7ef 100644\n--- a/lib/ansible/playbook/play.py\n+++ b/lib... | [
{
"diff_hunk": "@@ -345,7 +345,12 @@ def plugins_by_groups():\n if play:\n all_vars = combine_vars(all_vars, play.get_vars())\n \n- for vars_file_item in play.get_vars_files():\n+ vars_files = play.get_vars_files()\n+ if not hasattr(vars_files, '__iter__'):",... | 98a01d95fcb33f2a612c0818021ffe7dd9eb4f00 | diff --git a/lib/ansible/playbook/play.py b/lib/ansible/playbook/play.py
index 2fe4a9020def71..ccd3b323a1d7ef 100644
--- a/lib/ansible/playbook/play.py
+++ b/lib/ansible/playbook/play.py
@@ -277,6 +277,8 @@ def get_vars(self):
return self.vars.copy()
def get_vars_files(self):
+ if self.vars_files... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-30823@9fdd4cb | ansible/ansible | Python | 30,823 | Improve cloudwatchevent_rule exception handling | ##### SUMMARY
Fix broken exception handling and improve non-existent exception handling
This PR is designed as three commits. The first of them should be backported to 2.4, the other two are additional improvements for devel
Fixes #30806
##### ISSUE TYPE
- Bugfix Pull Request
##### COMPONENT NAME
clou... | 2017-09-25T02:02:58Z | Ansible 2.4.0 complains "NameError: global name 'botocore' is not defined" in cloudwatchevent_rule module
##### ISSUE TYPE
- Bug Report
##### COMPONENT NAME
AWS cloudwatchevent_rule
##### ANSIBLE VERSION
2.4.0.0
After installing 2.4, creating CloudWatch Rules had this error message.
```
The full traceba... | @fengchen8 Greetings! Thanks for taking the time to open this issue. In order for the community to handle your issue effectively, we need a bit more information.
Here are the items we could not find in your description:
- issue type
- ansible version
- component name
Please set the description of this issue with thi... | [
{
"body": "##### ISSUE TYPE\r\n - Bug Report\r\n\r\n##### COMPONENT NAME\r\nAWS cloudwatchevent_rule\r\n\r\n##### ANSIBLE VERSION\r\n2.4.0.0\r\n\r\nAfter installing 2.4, creating CloudWatch Rules had this error message. \r\n```\r\nThe full traceback is:\r\nTraceback (most recent call last):\r\n File \"/var/fol... | cb5f2c7ac37c341fde95542d7fe9248c1c63d2c4 | {
"head_commit": "9fdd4cb7001e90cf50d3964f1d99fb602290971d",
"head_commit_message": "PEP8 tidy up",
"patch_to_review": "diff --git a/lib/ansible/modules/cloud/amazon/cloudwatchevent_rule.py b/lib/ansible/modules/cloud/amazon/cloudwatchevent_rule.py\nindex cc2ae97f372b36..08d42d25bfb1b1 100644\n--- a/lib/ansible/m... | [
{
"diff_hunk": "@@ -116,13 +116,12 @@\n ''' # NOQA\n \n try:\n- import boto3.exception\n- import botocore.exceptions\n+ import botocore\n except ImportError:\n # module_utils.ec2.HAS_BOTO3 will do the right thing\n pass\n \n-from ansible.module_utils.basic import AnsibleModule\n+from ansible.m... | 5cff50ac8471f7df89e28155491c4040a4c98e42 | diff --git a/lib/ansible/modules/cloud/amazon/cloudwatchevent_rule.py b/lib/ansible/modules/cloud/amazon/cloudwatchevent_rule.py
index cc2ae97f372b36..bb16223524e275 100644
--- a/lib/ansible/modules/cloud/amazon/cloudwatchevent_rule.py
+++ b/lib/ansible/modules/cloud/amazon/cloudwatchevent_rule.py
@@ -107,24 +107,27 @@... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-30743@8133039 | ansible/ansible | Python | 30,743 | fix(tasks: synchronize): wrap in sshpass if ssh password was provided | ##### SUMMARY
> The action plugin detects the inventory data and connection type then juggles the connection to local and sets the remote host args for rsync. If the remote host required a password for auth and the user gave a password via the available methods, we would wrap ssh calls with sshpass. However, we comp... | 2017-09-22T10:19:25Z | sychronize module could wrap rsync with sshpass in certain cases
##### ISSUE TYPE
Feature Idea
##### COMPONENT NAME
core
##### ANSIBLE VERSION
```
2.2
```
##### CONFIGURATION
N/A
##### OS / ENVIRONMENT
N/A
##### SUMMARY
The action plugin detects the inventory data and connection type then juggles the connection to... | This approach sounds good to me FWIW.
Linking for future review on this topic: https://github.com/ritzk/ansible/commit/f7b50a2a2889b67fe09fbb7b48b448ddf9eac7ef
Any ideas if this could get developed anytime soon?
Yes. Just submit a pull request.
> Yes. Just submit a pull request.
@tima your suggestion seems to be ... | [
{
"body": "##### ISSUE TYPE\nFeature Idea\n\n##### COMPONENT NAME\ncore\n\n##### ANSIBLE VERSION\n```\n2.2\n```\n\n##### CONFIGURATION\nN/A\n\n##### OS / ENVIRONMENT\nN/A\n\n##### SUMMARY\nThe action plugin detects the inventory data and connection type then juggles the connection to local and sets the remote h... | a7bf5054746fbb1d4b6bc4b02ca45ddb134605db | {
"head_commit": "8133039afa8412e0637cc804d1b0ebed808ba05a",
"head_commit_message": "fix(tasks: synchronize): pass rsync password to sshpass via fd",
"patch_to_review": "diff --git a/lib/ansible/modules/files/synchronize.py b/lib/ansible/modules/files/synchronize.py\nindex 616cfcbdee2164..af0df272a8b5bc 100644\n-... | [
{
"diff_hunk": "@@ -414,6 +419,19 @@ def main():\n rsync = module.get_bin_path(rsync, required=True)\n \n cmd = [rsync, '--delay-updates', '-F']\n+ _sshpass_pipe = None\n+ if rsync_password:\n+ try:\n+ proc = subprocess.Popen(\n+ [\"sshpass\"], stdin=subprocess... | b4eeca74e6d444b634b8fac937b43d2f3c4b398e | diff --git a/lib/ansible/module_utils/basic.py b/lib/ansible/module_utils/basic.py
index 98fd25f55d721b..3d3ae8ce05b959 100644
--- a/lib/ansible/module_utils/basic.py
+++ b/lib/ansible/module_utils/basic.py
@@ -2681,7 +2681,7 @@ def _clean_args(self, args):
def run_command(self, args, check_rc=False, close_fds=T... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
ansible__ansible-29112@cf27d71 | ansible/ansible | Python | 29,112 | document the required variables for using Windows certificates | ##### SUMMARY
As originally stated in [this issue](https://github.com/ansible/ansible/issues/16243), there is no documentation on the variables to use when authenticating to Windows via WinRM using certificates.
There is also a long run-on sentence that I simplified.
Fixes #16243
##### ISSUE TYPE
- Docs... | 2017-09-07T23:00:28Z | Client certificate authentication with WinRM needs documentation
<!--- Verify first that your issue/request is not already reported in GitHub -->
##### ISSUE TYPE
<!--- Pick one below and delete the rest: -->
- Bug Report
##### ANSIBLE VERSION
<!--- Paste verbatim output from “ansible --version” between quotes below ... | Ansible/pywinrm cert auth are working just fine:
hosts
```
[win]
winclient-cert ansible_host=winclient.ansible.vagrant
[win:vars]
ansible_connection=winrm
ansible_winrm_transport=certificate
ansible_winrm_cert_pem=/Users/mdavis/Downloads/testguy_cert.pem
ansible_winrm_cert_key_pem=/Users/mdavis/Downloads/testguy_key... | [
{
"body": "<!--- Verify first that your issue/request is not already reported in GitHub -->\n##### ISSUE TYPE\n\n<!--- Pick one below and delete the rest: -->\n- Bug Report\n##### ANSIBLE VERSION\n\n<!--- Paste verbatim output from “ansible --version” between quotes below -->\n\nv2.1\n##### CONFIGURATION\n\n<!-... | 52f2edf19d2750eff58eae18083160da4f3799f6 | {
"head_commit": "cf27d71c017b03b1370e1b25923cae1c550430f4",
"head_commit_message": "document the required variables for using certificates when authenticating to Windows",
"patch_to_review": "diff --git a/docs/docsite/rst/intro_windows.rst b/docs/docsite/rst/intro_windows.rst\nindex 1e639c1abcd91d..6b757b7d5a851... | [
{
"diff_hunk": "@@ -94,8 +94,12 @@ You can specify which authentication option you wish to use by setting it to the\n Certificate\n +++++++++++\n \n-Certificate authentication is similar to SSH where a certificate is assigned to a local user and instead of using a password to authenticate a certificate is used ... | f3c93a1a5b1a66b62a2f2004ef170d156a6411f2 | diff --git a/docs/docsite/rst/intro_windows.rst b/docs/docsite/rst/intro_windows.rst
index 1e639c1abcd91d..5962d64bdca6d4 100644
--- a/docs/docsite/rst/intro_windows.rst
+++ b/docs/docsite/rst/intro_windows.rst
@@ -94,8 +94,12 @@ You can specify which authentication option you wish to use by setting it to the
Certific... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "Documentation Updates"
} |
ansible__ansible-28898@bd0f334 | ansible/ansible | Python | 28,898 | Rel240/fix nxos interface ospf | ##### SUMMARY
Fixes https://github.com/ansible/ansible/issues/28897
-->
##### ISSUE TYPE
- Bugfix Pull Request
##### COMPONENT NAME
nxos_interface_ospf
##### ANSIBLE VERSION
```
ansible 2.4.0 (rel240/fix_nxos_interface_ospf d5930c22b3) last updated 2017/08/31 15:04:42 (GMT -400)
config file = /Users/... | 2017-08-31T19:35:49Z | nxos_interface_ospf port-channel and loopback ints not idempotent
##### ISSUE TYPE
- Bug Report
##### COMPONENT NAME
- nxos_interface_ospf
##### NXOS VERSION
All
##### ANSIBLE VERSION
```
ansible 2.4.0 (rel240/fix_nxos_interface_ospf d5930c22b3) last updated 2017/08/31 15:04:42 (GMT -400)
config file... | cc @GGabriele @jedelman8 @privateip @rahushen @rcarrillocruz @trishnaguha
[click here for bot help](https://github.com/ansible/ansibullbot/blob/master/ISSUE_HELP.md)
<!--- boilerplate: notify ---> | [
{
"body": "##### ISSUE TYPE\r\n - Bug Report\r\n\r\n##### COMPONENT NAME\r\n - nxos_interface_ospf\r\n\r\n##### NXOS VERSION\r\nAll\r\n\r\n##### ANSIBLE VERSION\r\n```\r\nansible 2.4.0 (rel240/fix_nxos_interface_ospf d5930c22b3) last updated 2017/08/31 15:04:42 (GMT -400)\r\n config file = /Users/mwiebe/Projec... | 252efcebf5ff6b4918c01e6986b643635715f30a | {
"head_commit": "bd0f3345fd472a5929cb262c3d77d70af36d1f01",
"head_commit_message": "Handle all characters upper or lower with tests",
"patch_to_review": "diff --git a/lib/ansible/modules/network/nxos/nxos_interface_ospf.py b/lib/ansible/modules/network/nxos/nxos_interface_ospf.py\nindex f135d7fb13dcbf..ae936d79c... | [
{
"diff_hunk": "@@ -394,7 +394,16 @@ def main():\n 'message_digest_password']],\n supports_check_mode=True)\n \n- if not module.params['interface'].startswith('loopback') and not module.params['interface'].startswith('port-channel'):\n... | cbe60fb9cb2ed29819a526979b5d6b9bde0c06cd | diff --git a/lib/ansible/modules/network/nxos/nxos_interface_ospf.py b/lib/ansible/modules/network/nxos/nxos_interface_ospf.py
index f135d7fb13dcbf..63f42ba0d1b3e3 100644
--- a/lib/ansible/modules/network/nxos/nxos_interface_ospf.py
+++ b/lib/ansible/modules/network/nxos/nxos_interface_ospf.py
@@ -394,7 +394,15 @@ def ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-28885@7fe416f | ansible/ansible | Python | 28,885 | ec2: fixes #19521, fixes #29456 - create instance-store AMI instances with correct shutdown behavior | ##### SUMMARY
Termination is the required shutdown behavior of instance-store AMIs. The ec2 module option for the shutdown behavior defaults to 'stop' so I added a try/except to account for non-EBS-backed images and allow the default to be corrected. Added a note to the module option. Fixes #19521
##### ISSUE TYPE
... | 2017-08-31T15:58:44Z | ec2 module: instance_initiated_shutdown_behavior is invalid for instance-store backed AMIs
<!---
Verify first that your issue/request is not already reported on GitHub.
Also test if the latest release, and master branch are affected too.
-->
##### ISSUE TYPE
<!--- Pick one below and delete the rest: -->
- Bug ... | +1 Is there a workaround for this issue, a flag I can explicitly set to get past the error?
Actually found in the docs and module: instance_initiated_shutdown_behavior is the param - default is stop. I think terminate is the one we want for instance-store instances
Much appreciated, looks like it was added in 2.2 acc... | [
{
"body": "<!---\r\nVerify first that your issue/request is not already reported on GitHub.\r\nAlso test if the latest release, and master branch are affected too.\r\n-->\r\n\r\n##### ISSUE TYPE\r\n<!--- Pick one below and delete the rest: -->\r\n - Bug Report\r\n\r\n##### COMPONENT NAME\r\nec2\r\n\r\n##### ANS... | 503bfaf38bbc5c48fd743624555f21fdb220de11 | {
"head_commit": "7fe416fbc97b315777d1d09c9297ddd976a6ea46",
"head_commit_message": "Create instance-store AMI instances with 'terminate' as the shutdown behavior since it is required.",
"patch_to_review": "diff --git a/lib/ansible/modules/cloud/amazon/ec2.py b/lib/ansible/modules/cloud/amazon/ec2.py\nindex b64ab... | [
{
"diff_hunk": "@@ -1193,7 +1194,15 @@ def create_instances(module, ec2, vpc, override_count=None):\n # (the default) or 'terminate' here.\n params['instance_initiated_shutdown_behavior'] = instance_initiated_shutdown_behavior or 'stop'\n \n- res = ec2.run_instance... | 648405506d16ec4db735c62b82f301af33c0905b | diff --git a/lib/ansible/modules/cloud/amazon/ec2.py b/lib/ansible/modules/cloud/amazon/ec2.py
index b64abd3a46ea80..982443426ca0bc 100644
--- a/lib/ansible/modules/cloud/amazon/ec2.py
+++ b/lib/ansible/modules/cloud/amazon/ec2.py
@@ -227,7 +227,8 @@
instance_initiated_shutdown_behavior:
version_added: "2.2"
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-28782@319f685 | ansible/ansible | Python | 28,782 | Fixes #28779 eth_mode key error | ##### SUMMARY
Fixes https://github.com/ansible/ansible/issues/28779
##### ISSUE TYPE
- Bugfix Pull Request
##### COMPONENT NAME
nxos_interface
##### ANSIBLE VERSION
```
ansible 2.4.0 (240/fix_nxos_interface 319f685dd8) last updated 2017/08/29 11:45:53 (GMT -400)
config file = None
configured module... | 2017-08-29T15:51:09Z | nxos_interface errors out with KeyError: 'eth_mode'
##### ISSUE TYPE
- Bug Report
##### COMPONENT NAME
- nxos_interface
##### NXOS VERSION
7.0(3)I2(5)
##### ANSIBLE VERSION
```
ansible 2.4.0 (devel 3251aecd95) last updated 2017/08/29 09:19:59 (GMT -400)
config file = None
configured module search... | [
{
"body": "##### ISSUE TYPE\r\n - Bug Report\r\n\r\n##### COMPONENT NAME\r\n - nxos_interface\r\n\r\n##### NXOS VERSION\r\n7.0(3)I2(5)\r\n\r\n##### ANSIBLE VERSION\r\n```\r\nansible 2.4.0 (devel 3251aecd95) last updated 2017/08/29 09:19:59 (GMT -400)\r\n config file = None\r\n configured module search path = ... | 142869d2661b77d5b9778fb5aa75d0134b49a4bb | {
"head_commit": "319f685dd8ec160c2233394de36c8f5ee5391b8f",
"head_commit_message": "Fixes #28779 eth_mode key error",
"patch_to_review": "diff --git a/lib/ansible/modules/network/nxos/nxos_interface.py b/lib/ansible/modules/network/nxos/nxos_interface.py\nindex c6c94e2d9aa4e1..294bb2d04938b6 100644\n--- a/lib/an... | [
{
"diff_hunk": "@@ -701,7 +701,7 @@ def main():\n end_state, is_default = smart_existing(module, intf_type,\n normalized_interface)\n else:\n- end_state = get_interfaces_dict(module)[interface_type]\n+ ... | 15df44ae314bae6aaf91ee11bc245b13c8e47416 | diff --git a/lib/ansible/modules/network/nxos/nxos_interface.py b/lib/ansible/modules/network/nxos/nxos_interface.py
index c6c94e2d9aa4e1..a27f61bcac58ec 100644
--- a/lib/ansible/modules/network/nxos/nxos_interface.py
+++ b/lib/ansible/modules/network/nxos/nxos_interface.py
@@ -141,7 +141,7 @@
sample: ["interface ... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} | |
bridgecrewio__checkov-5795@313f864 | bridgecrewio/checkov | Python | 5,795 | fix(bicep): Update AppServiceHttps20Enabled to consider newer ApiVersion | **By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.**
[//]: # "
# PR Title
Be aware that we use the title to create changelog automatically and therefore only allow specific prefixes
- break: to indicate a breaking change, this supers... | 2023-11-23T16:18:21Z | CKV_AZURE_18 still detecting
**Describe the issue**
We are adding the `http20Enabled` marker to the site config but checkov is still giving the error
the error message is:
```Ensure that 'HTTP Version' is the latest if used to run the web app```
**Examples**
```
resource _webApplication 'Microsoft.Web/sites@2... | [
{
"body": "**Describe the issue**\r\nWe are adding the `http20Enabled` marker to the site config but checkov is still giving the error\r\n\r\nthe error message is:\r\n```Ensure that 'HTTP Version' is the latest if used to run the web app```\r\n\r\n**Examples**\r\n```\r\nresource _webApplication 'Microsoft.Web/s... | ea3dda1aef395b20bd241917a04a07fe8ea72c33 | {
"head_commit": "313f864bbb3996f084cac79b6835c717f39bb697",
"head_commit_message": "Fixed the check",
"patch_to_review": "diff --git a/checkov/arm/checks/resource/AppServiceHttps20Enabled.py b/checkov/arm/checks/resource/AppServiceHttps20Enabled.py\nindex 411a2486e1..899979cbc3 100644\n--- a/checkov/arm/checks/r... | [
{
"diff_hunk": "@@ -1,23 +1,33 @@\n+from __future__ import annotations\n+\n from typing import Any\n \n-from checkov.arm.base_resource_value_check import BaseResourceValueCheck\n-from checkov.common.models.enums import CheckCategories\n+from checkov.arm.base_resource_check import BaseResourceCheck\n+from checko... | 9d74100e42c338b3149a466610261c11742cec28 | diff --git a/checkov/arm/checks/resource/AppServiceHttps20Enabled.py b/checkov/arm/checks/resource/AppServiceHttps20Enabled.py
index 411a2486e1..ae77eae9b8 100644
--- a/checkov/arm/checks/resource/AppServiceHttps20Enabled.py
+++ b/checkov/arm/checks/resource/AppServiceHttps20Enabled.py
@@ -1,10 +1,15 @@
+from __future_... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
bridgecrewio__checkov-5322@bc1e504 | bridgecrewio/checkov | Python | 5,322 | fix(terraform): CKV_AWS_342 - managed rules have predefined actions | **By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.**
[//]: # "
# PR Title
Be aware that we use the title to create changelog automatically and therefore only allow specific prefixes
- break: to indicate a breaking change, this supers... | 2023-07-11T10:28:51Z | CKV_AWS_342 Ensure WAF rule has any actions should not consider a managed rule group
**Describe the issue**
CKV_AWS_342 currently will flag a WAFv2 WebACL that uses only managed rule groups. Managed rule groups have AWS-defined behavior regarding the actions that are taken (and some, like bot control, are not possib... | [
{
"body": "**Describe the issue**\r\n\r\nCKV_AWS_342 currently will flag a WAFv2 WebACL that uses only managed rule groups. Managed rule groups have AWS-defined behavior regarding the actions that are taken (and some, like bot control, are not possible to express with the rule syntax), so you don't specify an a... | d92323fb4788eb24d6a663f4d8a4f98745c4195a | {
"head_commit": "bc1e504ef641049e5aef70545dd556c3e5683670",
"head_commit_message": "managed rules have predefined actions",
"patch_to_review": "diff --git a/checkov/terraform/checks/resource/aws/WAFRuleHasAnyActions.py b/checkov/terraform/checks/resource/aws/WAFRuleHasAnyActions.py\nindex ef68f2a133..8f34714604 ... | [
{
"diff_hunk": "@@ -1,3 +1,36 @@\n+resource \"aws_wafv2_web_acl\" \"pass_managed\" {\n+ name = var.name\n+ description = \"Managed by Terraform, do not edit in the console\"\n+ scope = \"REGIONAL\"\n+ token_domains = [var.dns.fqdn, aws_lb.this.dns_name]\n+\n+ default_action {\n+ allow... | ff44a7a945e9d33c35f4dd3b2469de73973df8a1 | diff --git a/checkov/terraform/checks/resource/aws/WAFRuleHasAnyActions.py b/checkov/terraform/checks/resource/aws/WAFRuleHasAnyActions.py
index ef68f2a133..7e97c5dd4c 100644
--- a/checkov/terraform/checks/resource/aws/WAFRuleHasAnyActions.py
+++ b/checkov/terraform/checks/resource/aws/WAFRuleHasAnyActions.py
@@ -1,9 +... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
ansible__ansible-27975@3d9966e | ansible/ansible | Python | 27,975 | Cause copy module to fail on empty string as source | ##### SUMMARY
Cause `copy` to fail rather than copying the content of the current working directory if an empty string is specified as the source. Fixes #27363
Cleaned up formatting on integration tests.
Added integration test for this specific case.
##### ISSUE TYPE
<!--- Pick one below and delete the res... | 2017-08-09T18:58:11Z | copy module copies contents of CWD when src=""
##### ISSUE TYPE
<!--- Pick one below and delete the rest: -->
- Bug Report / Question
##### COMPONENT NAME
<!--- Name of the module/plugin/task/feature -->
plugin/module: copy
##### ANSIBLE VERSION
<!--- Paste verbatim output from “ansible --version” between q... | IMO this is a bug (probably a behavior of `_find_needle` that we should paper over by ensuring the source path is not empty in the action plugin). | [
{
"body": "##### ISSUE TYPE\r\n<!--- Pick one below and delete the rest: -->\r\n - Bug Report / Question\r\n\r\n##### COMPONENT NAME\r\n<!--- Name of the module/plugin/task/feature -->\r\nplugin/module: copy\r\n\r\n##### ANSIBLE VERSION\r\n<!--- Paste verbatim output from “ansible --version” between quotes belo... | 8a69706037da7fa04fadb63b254b3a10e869e54d | {
"head_commit": "3d9966e66db8e521385f8f0234c1fb8457d7f751",
"head_commit_message": "Add test for empty string as source",
"patch_to_review": "diff --git a/lib/ansible/plugins/action/copy.py b/lib/ansible/plugins/action/copy.py\nindex 55aba4dc179ce9..638f943fcbd500 100644\n--- a/lib/ansible/plugins/action/copy.py... | [
{
"diff_hunk": "@@ -407,7 +407,7 @@ def run(self, tmp=None, task_vars=None):\n local_follow = boolean(self._task.args.get('local_follow', True), strict=False)\n \n result['failed'] = True\n- if (source is None and content is None) or dest is None:\n+ if ((not source or source is No... | 02d334110b7348c202e694d0dae886c58da3a8a0 | diff --git a/lib/ansible/plugins/action/copy.py b/lib/ansible/plugins/action/copy.py
index 55aba4dc179ce9..f760e4447a439a 100644
--- a/lib/ansible/plugins/action/copy.py
+++ b/lib/ansible/plugins/action/copy.py
@@ -407,12 +407,14 @@ def run(self, tmp=None, task_vars=None):
local_follow = boolean(self._task.arg... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
apache__airflow-49236@ec745f5 | apache/airflow | Python | 49,236 | Feature/aip 38 add dag warning | closes: https://github.com/apache/airflow/issues/47430
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the... | 2025-04-14T16:34:20Z | AIP-38 | Add Dag Warning banner to Dag Details page
### Body
Use the `public/dagWarnings` API endpoint to see if there are any warnings for a dag_id and display a banner on that Dag's detail page
### Committer
- [x] I acknowledge that I am a maintainer/committer of the Apache Airflow project. | I want to work on this issue if I could be assigned it. I am looking for a first-issue contribution to an OSS software project and am a senior CS student
@prchoward Go for it. Let me know if you have any questions
I would appreciate the opportunity to work on this issue if it can be assigned to me. As a senior Computer... | [
{
"body": "### Body\n\nUse the `public/dagWarnings` API endpoint to see if there are any warnings for a dag_id and display a banner on that Dag's detail page\n\n### Committer\n\n- [x] I acknowledge that I am a maintainer/committer of the Apache Airflow project.",
"number": 47430,
"title": "AIP-38 | Add ... | 20f8af546e63c6178df19166acbda8f768c21bf0 | {
"head_commit": "ec745f51c32005b60b76e2584b0b24548faa2dc5",
"head_commit_message": "Updated warning to be in a modal",
"patch_to_review": "diff --git a/airflow-core/src/airflow/ui/src/components/WarningAlert.tsx b/airflow-core/src/airflow/ui/src/components/WarningAlert.tsx\nnew file mode 100644\nindex 0000000000... | [
{
"diff_hunk": "@@ -90,7 +97,28 @@ export const DetailsLayout = ({ children, error, isLoading, tabs }: Props) => {\n <Panel defaultSize={dagView === \"graph\" ? 30 : 80} minSize={20}>\n <Box display=\"flex\" flexDirection=\"column\" h=\"100%\">\n {children}\n- <E... | 9770301a5e98f3c11a1cfed048c9ba92d03eff1b | diff --git a/airflow-core/src/airflow/ui/src/components/WarningAlert.tsx b/airflow-core/src/airflow/ui/src/components/WarningAlert.tsx
new file mode 100644
index 0000000000000..69cbe4e418611
--- /dev/null
+++ b/airflow-core/src/airflow/ui/src/components/WarningAlert.tsx
@@ -0,0 +1,39 @@
+/*!
+ * Licensed to the Apache ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
ansible__ansible-27869@fb2137e | ansible/ansible | Python | 27,869 | fixes Traceback generated by nxos_igmp module | fixes #27488 | 2017-08-08T00:54:29Z | (P1)nxos_igmp: module fails with traceback
<!---
Verify first that your issue/request is not already reported on GitHub.
Also test if the latest release, and master branch are affected too.
-->
##### ISSUE TYPE
<!--- Pick one below and delete the rest: -->
- Bug Report
##### COMPONENT NAME
<!--- Name of th... | cc @GGabriele @jedelman8 @mikewiebe @privateip @rcarrillocruz @trishnaguha
[click here for bot help](https://github.com/ansible/ansibullbot/blob/master/ISSUE_HELP.md)
<!--- boilerplate: notify ---> | [
{
"body": "<!---\r\nVerify first that your issue/request is not already reported on GitHub.\r\nAlso test if the latest release, and master branch are affected too.\r\n-->\r\n\r\n##### ISSUE TYPE\r\n<!--- Pick one below and delete the rest: -->\r\n - Bug Report\r\n\r\n##### COMPONENT NAME\r\n<!--- Name of the mo... | e4a997c97ed2dee2a84d58be0e311d61c4460328 | {
"head_commit": "fb2137ec4153e6eaf7cbce28716e9bf9a922848a",
"head_commit_message": "update module code to reflect review comments",
"patch_to_review": "diff --git a/lib/ansible/modules/network/nxos/nxos_igmp.py b/lib/ansible/modules/network/nxos/nxos_igmp.py\nindex debc3388d4320b..ccb6416b1e70e8 100644\n--- a/li... | [
{
"diff_hunk": "@@ -206,53 +131,43 @@ def main():\n check_args(module, warnings)\n \n \n- state = module.params['state']\n- restart = module.params['restart']\n-\n- if (state == 'default' and (module.params['flush_routes'] is not None or\n- module.params['enforce_rtr_alert'] is not None)... | 8bfd56bf2e45a0f2db8ef85e349034d6c1e8fa6e | diff --git a/lib/ansible/modules/network/nxos/nxos_igmp.py b/lib/ansible/modules/network/nxos/nxos_igmp.py
index debc3388d4320b..d32a6eb08f7645 100644
--- a/lib/ansible/modules/network/nxos/nxos_igmp.py
+++ b/lib/ansible/modules/network/nxos/nxos_igmp.py
@@ -84,106 +84,29 @@
'''
RETURN = '''
-proposed:
- descrip... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-27518@dee2c81 | ansible/ansible | Python | 27,518 | cloudformation: fix changeset_name bug fix #27487 | ##### SUMMARY
<!--- Describe the change, including rationale and design decisions -->
bug fix #27487
<!---
If you are fixing an existing issue, please include "Fixes #nnn" in your
commit message and your description; but you should still explain what
the change does.
-->
##### ISSUE TYPE
<!--- Pick one belo... | 2017-07-31T19:01:49Z | Its impossible use changeset_name parameter in cloudformation module
<!---
Verify first that your issue/request is not already reported on GitHub.
Also test if the latest release, and master branch are affected too.
-->
##### ISSUE TYPE
<!--- Pick one below and delete the rest: -->
- Bug Report
##### COMPON... | The fix is simple. I tried to push the fix but I get 403 error.
How can I contribute the fix to project ?
cc @jsmartin @ryansb @tedder
[click here for bot help](https://github.com/ansible/ansibullbot/blob/master/ISSUE_HELP.md)
<!--- boilerplate: notify --->
Hi- thanks for trying to fix! You'll need to clone the Ansib... | [
{
"body": "<!---\r\nVerify first that your issue/request is not already reported on GitHub.\r\nAlso test if the latest release, and master branch are affected too.\r\n-->\r\n\r\n##### ISSUE TYPE\r\n<!--- Pick one below and delete the rest: -->\r\n - Bug Report\r\n\r\n##### COMPONENT NAME\r\n<!--- Name of the mo... | bc3c315bc8ffac677cbba74ea067ef069d920172 | {
"head_commit": "dee2c81a726f58da31c9efd19bb3e10a84880bc3",
"head_commit_message": "bug fix #27487",
"patch_to_review": "diff --git a/lib/ansible/modules/cloud/amazon/cloudformation.py b/lib/ansible/modules/cloud/amazon/cloudformation.py\nindex 2ec41e5e833812..69d9cfa43eb02b 100644\n--- a/lib/ansible/modules/clo... | [
{
"diff_hunk": "@@ -333,6 +333,9 @@ def create_changeset(module, stack_params, cfn):\n \n changeset_name = 'Ansible-' + stack_params['StackName'] + '-' + sha1(to_bytes(json_params, errors='surrogate_or_strict')).hexdigest()\n stack_params['ChangeSetName'] = changeset_name\n+ else:... | e0421f1a47862fc8d4b9945ced68161589d154a6 | diff --git a/lib/ansible/modules/cloud/amazon/cloudformation.py b/lib/ansible/modules/cloud/amazon/cloudformation.py
index 2ec41e5e833812..86f4874897ef18 100644
--- a/lib/ansible/modules/cloud/amazon/cloudformation.py
+++ b/lib/ansible/modules/cloud/amazon/cloudformation.py
@@ -333,6 +333,9 @@ def create_changeset(modu... | {
"difficulty": "medium",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
bridgecrewio__checkov-4656@8f511c9 | bridgecrewio/checkov | Python | 4,656 | feat(terraform): support provider blocks yaml policy checks | **By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.**
## Description
*Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.*
... | 2023-03-13T13:50:24Z | Ability to write custom checks on provider block in Yaml
While checkov allows us to write custom checks involving various resource types in terraform, am not sure if there is a way to add custom checks for the provider block in terraform. The default check that runs for the provider block does scan for secrets, however... | hey @rannaladasu thanks for reaching out.
Sounds like a good feature request. We currently only support `resource`, `module` and `data` blocks.
You can write this check easily enough already in python for a provider what you cant do is write a yaml check for providers - see the draft https://github.com/bridgecrewio/... | [
{
"body": "While checkov allows us to write custom checks involving various resource types in terraform, am not sure if there is a way to add custom checks for the provider block in terraform. The default check that runs for the provider block does scan for secrets, however, am looking to check if the provider ... | f3ba4f3a8e89dbc31726121ef5319ccfaea746c7 | {
"head_commit": "8f511c970e8b64ae1743820b9b7158d7dc57cb52",
"head_commit_message": "add whitespaces",
"patch_to_review": "diff --git a/checkov/common/checks_infra/checks_parser.py b/checkov/common/checks_infra/checks_parser.py\nindex 3792516fca..d1a63453d5 100644\n--- a/checkov/common/checks_infra/checks_parser.... | [
{
"diff_hunk": "@@ -228,6 +229,8 @@ def _parse_raw_check(self, raw_check: Dict[str, Any], resources_types: Optional[\n or (isinstance(resource_type, list) and resource_type[0].lower() == \"all\")\n ):\n check.resource_types = resources_types or []\n+ el... | c2f8ae5c0709e7b04280733995345c1a3d5f902d | diff --git a/checkov/common/checks_infra/checks_parser.py b/checkov/common/checks_infra/checks_parser.py
index 3792516fca..56d0d0b20e 100644
--- a/checkov/common/checks_infra/checks_parser.py
+++ b/checkov/common/checks_infra/checks_parser.py
@@ -185,8 +185,9 @@ def validate_check_config(self, file_path: str, raw_check... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
ansible__ansible-27435@da1a331 | ansible/ansible | Python | 27,435 | elb_classic_lb_facts: port to boto3 - also fixes #25075 and #25000 | ##### SUMMARY
This module was mistakenly using AWSRetry (which only works on boto3 exceptions). Updated to use camel_dict_to_snake_dict instead of specifying the result casing manually. Remove unnecessary use of class, also added another option to module_utils.ec2 paging() since there is such discrepancy on how mark... | 2017-07-28T17:53:10Z | ec2_elb_facts - ELBs beyond initial 400 are not found
##### ISSUE TYPE
- Bug Report
##### COMPONENT NAME
- ec2_elb_facts
##### ANSIBLE VERSION
```
ansible 2.3.0.0
config file =
configured module search path = Default w/o overrides
python version = 2.7.13 (default, Dec 18 2016, 07:03:39) [GCC 4.2.1... | This issue is fixed in Pull Request https://github.com/ansible/ansible/pull/25002
cc @mjschultz
[click here for bot help](https://github.com/ansible/ansibullbot/blob/master/ISSUE_HELP.md)
<!--- boilerplate: notify --->
cc @nand0p
[click here for bot help](https://github.com/ansible/ansibullbot/blob/master/ISSUE_HELP.md... | [
{
"body": "##### ISSUE TYPE\r\n - Bug Report\r\n\r\n##### COMPONENT NAME\r\n - ec2_elb_facts\r\n\r\n##### ANSIBLE VERSION\r\n```\r\nansible 2.3.0.0\r\n config file = \r\n configured module search path = Default w/o overrides\r\n python version = 2.7.13 (default, Dec 18 2016, 07:03:39) [GCC 4.2.1 Compatible A... | c714da7fac136c84cfbba57a801c48d874234cff | {
"head_commit": "da1a331704d851bcdea7ad6c6b5441b071333f90",
"head_commit_message": "Add RETURN docs for elb_classic_lb_facts",
"patch_to_review": "diff --git a/lib/ansible/modules/cloud/amazon/elb_classic_lb_facts.py b/lib/ansible/modules/cloud/amazon/elb_classic_lb_facts.py\nindex 036af42a1660bc..31605c754dc307... | [
{
"diff_hunk": "@@ -231,29 +203,29 @@ def main():\n names={'default': [], 'type': 'list'}\n )\n )\n- module = AnsibleModule(argument_spec=argument_spec,\n- supports_check_mode=True)\n+ module = AnsibleAWSModule(argument_spec=argument_spec,\n+ ... | 9ceea147af267f9f3e76cfb27e02a5b0774a8cd6 | diff --git a/lib/ansible/modules/cloud/amazon/elb_classic_lb_facts.py b/lib/ansible/modules/cloud/amazon/elb_classic_lb_facts.py
index 036af42a1660bc..73756f9030ca2e 100644
--- a/lib/ansible/modules/cloud/amazon/elb_classic_lb_facts.py
+++ b/lib/ansible/modules/cloud/amazon/elb_classic_lb_facts.py
@@ -38,6 +38,9 @@
ex... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-27352@5a3fd1d | ansible/ansible | Python | 27,352 | aws_kms: don't append to unicode - fixes #25786 | ##### SUMMARY
The statement may not have a principal, and if there is only one AWS principal it will not be a list as expected. Fixes #25786. Also added the exception message to the exception handling for more transparency and fixed changed always showing False.
##### ISSUE TYPE
- Bugfix Pull Request
##### COM... | 2017-07-26T22:10:36Z | aws_kms cannot append role_name/role_arn to key
<!---
Verify first that your issue/request is not already reported on GitHub.
Also test if the latest release, and master branch are affected too.
-->
##### ISSUE TYPE
<!--- Pick one below and delete the rest: -->
- Bug Report
##### COMPONENT NAME
aws_kms
... | cc @willthames
[click here for bot help](https://github.com/ansible/ansibullbot/blob/master/ISSUE_HELP.md)
<!--- boilerplate: notify ---> | [
{
"body": "<!---\r\nVerify first that your issue/request is not already reported on GitHub.\r\nAlso test if the latest release, and master branch are affected too.\r\n-->\r\n\r\n##### ISSUE TYPE\r\n<!--- Pick one below and delete the rest: -->\r\n - Bug Report\r\n\r\n##### COMPONENT NAME\r\naws_kms\r\n\r\n#####... | bfdf85e002447a9b9360a26d26c1b67259f27924 | {
"head_commit": "5a3fd1d557d0b5ef85f25d33bdf54687d1d16195",
"head_commit_message": "remove len(), only catch exception in function for json.dumps() failure",
"patch_to_review": "diff --git a/lib/ansible/modules/cloud/amazon/aws_kms.py b/lib/ansible/modules/cloud/amazon/aws_kms.py\nindex 81e36e3dfa890b..477860929... | [
{
"diff_hunk": "@@ -197,12 +203,12 @@ def do_grant(kms, keyarn, role_arn, granttypes, mode='grant', dry_run=True, clea\n try:\n if len(changes_needed) and not dry_run:\n policy_json_string = json.dumps(policy)\n- kms.put_key_policy(KeyId=keyarn, PolicyName='default', Policy=po... | 4812e8d48f2edd963bec3614c12a205dc9c0e6bc | diff --git a/lib/ansible/modules/cloud/amazon/aws_kms.py b/lib/ansible/modules/cloud/amazon/aws_kms.py
index 81e36e3dfa890b..4faf3822eadc83 100644
--- a/lib/ansible/modules/cloud/amazon/aws_kms.py
+++ b/lib/ansible/modules/cloud/amazon/aws_kms.py
@@ -165,12 +165,18 @@ def do_grant(kms, keyarn, role_arn, granttypes, mod... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-27257@6ae73e8 | ansible/ansible | Python | 27,257 | Port cs_facts to the ansible 2.4 facts API | Fixes #27256
References #27254
##### SUMMARY
The facts API has changed in 2.4. Need to port cs_facts to the new API as it calls facts to figure out dhcp leases.
This is also needed for enabling pylint tests for undefined varialbes.
##### ISSUE TYPE
- Bugfix Pull Request
##### COMPONENT NAME
<!--- Name... | 2017-07-25T05:06:11Z | cs_facts needs porting to the new facts API
<!---
Verify first that your issue/request is not already reported on GitHub.
Also test if the latest release, and master branch are affected too.
-->
##### ISSUE TYPE
<!--- Pick one below and delete the rest: -->
- Bug Report
##### COMPONENT NAME
<!--- Name of t... | @alikins are you able to look into this? There's only a few problems left before we can enable the pylint tests.
cc @resmo
[click here for bot help](https://github.com/ansible/ansibullbot/blob/master/ISSUE_HELP.md)
<!--- boilerplate: notify ---> | [
{
"body": "<!---\r\nVerify first that your issue/request is not already reported on GitHub.\r\nAlso test if the latest release, and master branch are affected too.\r\n-->\r\n\r\n##### ISSUE TYPE\r\n<!--- Pick one below and delete the rest: -->\r\n - Bug Report\r\n\r\n##### COMPONENT NAME\r\n<!--- Name of the mo... | 035be94271699be34dbc1e3d3642841c36064c20 | {
"head_commit": "6ae73e8b7df0b5a4ea433102cd2b3df9b3b56e27",
"head_commit_message": "Port cs_facts to the ansible 2.4 facts API\n\nFixes #27256\nReferenes #27254",
"patch_to_review": "diff --git a/lib/ansible/modules/cloud/cloudstack/cs_facts.py b/lib/ansible/modules/cloud/cloudstack/cs_facts.py\nindex b6056e724e... | [
{
"diff_hunk": "@@ -121,7 +121,12 @@\n class CloudStackFacts(object):\n \n def __init__(self):\n- self.facts = ansible_facts(module)\n+ collector = ansible_collector.get_ansible_collector(all_collector_classes=default_collectors.collectors,\n+ ... | d8bb88c91d37e837bf828e38bd53c9c8144d047a | diff --git a/lib/ansible/modules/cloud/cloudstack/cs_facts.py b/lib/ansible/modules/cloud/cloudstack/cs_facts.py
index b6056e724ef8f2..34e51007f1583a 100644
--- a/lib/ansible/modules/cloud/cloudstack/cs_facts.py
+++ b/lib/ansible/modules/cloud/cloudstack/cs_facts.py
@@ -106,7 +106,7 @@
import os
from ansible.module_u... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Code Refactoring / Architectural Improvement"
} |
bridgecrewio__checkov-4476@86563e9 | bridgecrewio/checkov | Python | 4,476 | fix(cloudformation): Updated AWS_CKV_7 to not require rotation on asymmetric keys | **By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.**
[//]: # "
# PR Title
Be aware that we use the title to create changelog automatically and therefore only allow specific prefixes
- break: to indicate a breaking change, this supers... | 2023-02-10T19:24:32Z | AWS_CKV_7 False Positive on assymetric key check in Cloudformation
**Describe the issue**
In terraform, the check avoids false positives with an extra check against symmetric keys before checking whether rotation is enabled. This same check hasn't been configured for cloudformation:
```
def scan_resource_conf(sel... | [
{
"body": "**Describe the issue**\r\nIn terraform, the check avoids false positives with an extra check against symmetric keys before checking whether rotation is enabled. This same check hasn't been configured for cloudformation:\r\n\r\n```\r\ndef scan_resource_conf(self, conf):\r\n # Only symmetric ke... | 9a5f7310408ddeea53d7a005e79aab26537f2b83 | {
"head_commit": "86563e98fda2987c307f314a2839ccb771e6e35b",
"head_commit_message": "Fixing some extraneous stuff spotted in PR review",
"patch_to_review": "diff --git a/checkov/cloudformation/checks/resource/aws/KMSRotation.py b/checkov/cloudformation/checks/resource/aws/KMSRotation.py\nindex 2a76f73b5b..2843cff... | [
{
"diff_hunk": "@@ -16,7 +16,7 @@ def get_inspected_key(self):\n def scan_resource_conf(self, conf):\n # Only symmetric keys support auto rotation. The attribute is optional and defaults to symmetric.\n spec = conf.get('customer_master_key_spec')\n- if not spec or 'SYMMETRIC_DEFAULT' ... | 1a5558a643b2f7f4270c38b77d03237d1b807982 | diff --git a/checkov/cloudformation/checks/resource/aws/KMSRotation.py b/checkov/cloudformation/checks/resource/aws/KMSRotation.py
index 2a76f73b5b..fee8674b78 100644
--- a/checkov/cloudformation/checks/resource/aws/KMSRotation.py
+++ b/checkov/cloudformation/checks/resource/aws/KMSRotation.py
@@ -1,4 +1,4 @@
-from che... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
ansible__ansible-26156@c8ca9a9 | ansible/ansible | Python | 26,156 | fix for nxos_acl_interface idempotency | ##### SUMMARY
Fixes https://github.com/ansible/ansible/issues/26155
- The nxos_acl_interface component is using "show ip access-list summary" for checking if the acl_interface is existing already. This is not correct.
- Whenever an ip access-group is configured, it will be listed in "show running-config aclmgr"... | 2017-06-27T18:45:28Z | nxos_acl_interface not idempotent
##### ISSUE TYPE
- Bug Report
##### COMPONENT NAME
nxos_acl_interface
##### ANSIBLE VERSION
```ansible 2.4.0 (devel 1e8c58519e) last updated 2017/06/26 16:21:06 (GMT -400)
config file = None
configured module search path = [u'/root/.ansible/plugins/modules', u'/usr/shar... | cc @jedelman8 @GGabriele @rahushen @privateip @rcarrillocruz @mikewiebe @trishnaguha
[click here for bot help](https://github.com/ansible/ansibullbot/blob/master/ISSUE_HELP.md)
<!--- boilerplate: notify ---> | [
{
"body": "##### ISSUE TYPE\r\n - Bug Report\r\n\r\n##### COMPONENT NAME\r\nnxos_acl_interface\r\n\r\n##### ANSIBLE VERSION\r\n```ansible 2.4.0 (devel 1e8c58519e) last updated 2017/06/26 16:21:06 (GMT -400)\r\n config file = None\r\n configured module search path = [u'/root/.ansible/plugins/modules', u'/usr/s... | e49f15d6e4d735ba6f58e3e15b2353e4781c7e6b | {
"head_commit": "c8ca9a904f877f2c29e86156bdcfac8448e29c12",
"head_commit_message": "Review comment fixes",
"patch_to_review": "diff --git a/lib/ansible/modules/network/nxos/nxos_acl_interface.py b/lib/ansible/modules/network/nxos/nxos_acl_interface.py\nindex b47d796b877dd2..bea4e9d2905cd5 100644\n--- a/lib/ansib... | [
{
"diff_hunk": "@@ -86,29 +86,18 @@\n \n \n def check_for_acl_int_present(module, name, intf, direction):\n- command = ['show running-config aclmgr']\n+ # Need to Captitalize the interface name as the nxos\n+ # output has capitalization\n+ command = ['show running-config aclmgr | section {0}'.format... | 3210bc23035f7e341002ee33bf96cd16071b27e4 | diff --git a/lib/ansible/modules/network/nxos/nxos_acl_interface.py b/lib/ansible/modules/network/nxos/nxos_acl_interface.py
index b47d796b877dd2..df597c897bd11f 100644
--- a/lib/ansible/modules/network/nxos/nxos_acl_interface.py
+++ b/lib/ansible/modules/network/nxos/nxos_acl_interface.py
@@ -85,83 +85,19 @@
from ans... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
apache__airflow-48969@469e05f | apache/airflow | Python | 48,969 | Make default as time.now() for TriggerDagRunOperator | closes: https://github.com/apache/airflow/issues/48412
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improv... | 2025-04-08T18:39:54Z | Manually triggered dags should have default logical_date and run_after of "right now"
### Body
As part of the AIP-83 amendment process we decided to make logical_date nullable, and to make it default null for manually triggered dags.
We got some feedback that this will suck for users.
So we want to keep the airlfow ... | Three scenarios we need to account for are:
1. Manually triggering DAG Run via UI
2. Triggering Dag Run via API
3. Trigger Dag Run Operator usage
@vatsrahul1001 talk to me / constance to confirm requirements i was going to review the slack thread again
@dstandish / @cmarteepants Currently, logical_date is a required fi... | [
{
"body": "### Body\n\nAs part of the AIP-83 amendment process we decided to make logical_date nullable, and to make it default null for manually triggered dags.\n\nWe got some feedback that this will suck for users.\n\nSo we want to keep the airlfow 2 behavior where logical_date is `now()` by default, but the ... | 278224ffdd71a53a15ab9be9c2a12bc41fd62707 | {
"head_commit": "469e05fb785ae2f667d2f4464637a4a374b4cdb2",
"head_commit_message": "fix sdk tests",
"patch_to_review": "diff --git a/providers/standard/src/airflow/providers/standard/operators/trigger_dagrun.py b/providers/standard/src/airflow/providers/standard/operators/trigger_dagrun.py\nindex 24b9a59b49a45..... | [
{
"diff_hunk": "@@ -190,10 +190,12 @@ def __init__(\n self.logical_date = logical_date\n \n def execute(self, context: Context):\n- if self.logical_date is None or isinstance(self.logical_date, datetime.datetime):\n+ if isinstance(self.logical_date, datetime.datetime):\n pa... | 465bf46129cdb8d2d6e419a7a55ba17d947a8060 | diff --git a/providers/standard/src/airflow/providers/standard/operators/trigger_dagrun.py b/providers/standard/src/airflow/providers/standard/operators/trigger_dagrun.py
index 24b9a59b49a45..2057ee178fc2b 100644
--- a/providers/standard/src/airflow/providers/standard/operators/trigger_dagrun.py
+++ b/providers/standar... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
ansible__ansible-25749@ad141f5 | ansible/ansible | Python | 25,749 | ec2.py: add region to the aws_connect_kwargs before creating vpc connection Fixes #25673 | ##### SUMMARY
Fix vpc connection defaulting to us-east-1. Fixes #25673
Edit:
Simple reproducer (use any region except us-east-1 to create a new ec2 instance):
```
---
- hosts: localhost
connection: local
tasks:
- name: create ec2 instance in west 2
ec2:
# Using region or ec2_url fails... | 2017-06-15T13:47:11Z | ec2.py now fails with "subnet ID does not exist"
##### ISSUE TYPE
- Bug Report
##### COMPONENT NAME
module/cloud/amazon/ec2.py
##### ANSIBLE VERSION
```
ansible 2.4.0 (devel cf30b162a9) last updated 2017/06/14 11:24:28 (GMT +1300)
config file = /Users/jmorgan/git/sovereign/ansible/ansible.cfg
configu... | @darknessnz Thanks for filing the bug report! Sorry this is breaking for you. I'm having a hard time generating the error with your reproducer. Can you run this and see if the subnet is correctly found? (I'm wondering if could it be in another region)
```
---
- hosts: localhost
connection: local
gather_facts: ... | [
{
"body": "##### ISSUE TYPE\r\n - Bug Report\r\n\r\n\r\n##### COMPONENT NAME\r\nmodule/cloud/amazon/ec2.py\r\n\r\n##### ANSIBLE VERSION\r\n```\r\nansible 2.4.0 (devel cf30b162a9) last updated 2017/06/14 11:24:28 (GMT +1300)\r\n config file = /Users/jmorgan/git/sovereign/ansible/ansible.cfg\r\n configured modu... | 8ad04d63487d8f55bc67e9f84b5c0b4575e9ce83 | {
"head_commit": "ad141f5234d35f9fe3207d6bdd7817fb5c420570",
"head_commit_message": "add region to the aws_connect_kwargs before creating vpc connection",
"patch_to_review": "diff --git a/lib/ansible/modules/cloud/amazon/ec2.py b/lib/ansible/modules/cloud/amazon/ec2.py\nindex a1530a8c8c73a9..73f3d008300a8a 100644... | [
{
"diff_hunk": "@@ -629,6 +629,7 @@\n import boto.ec2\n from boto.ec2.blockdevicemapping import BlockDeviceType, BlockDeviceMapping\n from boto.exception import EC2ResponseError\n+ from boto.vpc import VPCConnection",
"line": null,
"original_line": 632,
"original_start_line": null,
... | 3dc424a2278989448a30d67f10f3db28f04b05b0 | diff --git a/lib/ansible/modules/cloud/amazon/ec2.py b/lib/ansible/modules/cloud/amazon/ec2.py
index a1530a8c8c73a9..c983c3eb8728b9 100644
--- a/lib/ansible/modules/cloud/amazon/ec2.py
+++ b/lib/ansible/modules/cloud/amazon/ec2.py
@@ -1642,12 +1642,15 @@ def main():
module.fail_json(msg='boto required for this... | {
"difficulty": "medium",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-25723@b57840e | ansible/ansible | Python | 25,723 | s3_bucket: policy comparison - fixes #25428 | ##### SUMMARY
fixes #25428
Since policy statements are a list of dicts and values of said dicts may be identical except different types, comparison is faulty. Before this fix listing a single resource as a list in a policy always results in changed == True (because boto or the S3 API "fixes" this and removes unnecess... | 2017-06-14T21:52:25Z | s3_module bug when specifying IAM principle in bucket policy
<!---
Verify first that your issue/request is not already reported on GitHub.
Also test if the latest release, and master branch are affected too.
-->
##### ISSUE TYPE
<!--- Pick one below and delete the rest: -->
- Bug Report
##### COMPONENT NA... | Hi @shdobxr, thanks for opening the issue. Are you using the s3 module or s3_bucket module?
Hey there, s3_bucket module.
Dan
On Thu, Jun 8, 2017 at 8:18 AM, Sloane Hertel <notifications@github.com>
wrote:
> Hi @shdobxr <https://github.com/shdobxr>, thanks for opening the issue.
> Are you using the s3 module or s3_bu... | [
{
"body": "<!---\r\nVerify first that your issue/request is not already reported on GitHub.\r\nAlso test if the latest release, and master branch are affected too.\r\n-->\r\n\r\n##### ISSUE TYPE\r\n<!--- Pick one below and delete the rest: -->\r\n - Bug Report\r\n\r\n\r\n##### COMPONENT NAME\r\n<!--- Name of th... | 91c1d8d8e2bd2c310f66a119a39886a36fd5db4d | {
"head_commit": "b57840e8a78fbcfb3c3931fc0e244b80ee44b4de",
"head_commit_message": "abbreviate example and logic",
"patch_to_review": "diff --git a/lib/ansible/modules/cloud/amazon/s3_bucket.py b/lib/ansible/modules/cloud/amazon/s3_bucket.py\nindex 1e2243705e8c46..92fcb9d9b5c271 100644\n--- a/lib/ansible/modules... | [
{
"diff_hunk": "@@ -155,6 +156,60 @@ def create_tags_container(tags):\n return tags_obj\n \n \n+def hashable_policy(policy, policy_list):\n+ \"\"\"\n+ Takes a policy and returns a list, the contents of which are all hashable and sorted.\n+ Example input policy:\n+ {'Version': '2012-1... | ebabbdd8f0cad66aba51e765b9045615944b3446 | diff --git a/lib/ansible/modules/cloud/amazon/s3_bucket.py b/lib/ansible/modules/cloud/amazon/s3_bucket.py
index 1e2243705e8c46..c7c341fd86a963 100644
--- a/lib/ansible/modules/cloud/amazon/s3_bucket.py
+++ b/lib/ansible/modules/cloud/amazon/s3_bucket.py
@@ -120,6 +120,7 @@
import ansible.module_utils.six.moves.urll... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
bridgecrewio__checkov-4155@48ecaf7 | bridgecrewio/checkov | Python | 4,155 | feat(azure): Add check - azure keyvalut public network access | **By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.**
[//]: # "
# PR Title
Be aware that we use the title to create changelog automatically and therefore only allow specific prefixes
- break: to indicate a breaking change, this supers... | 2022-12-27T09:00:29Z | Ensure that Public Network Access is disabled for Azure Key Vault
**Describe the issue**
It seems that there are no Checkov checks related to the best practice of not allowing Public Network Access to Azure Key Vault
It should be either:
- A list of pre-approved ip_rules in a network_acls block
- A private endpoi... | hey @tdefise thanks for reaching out. Nice find 💪 this sounds like a good addition. Are you interested in contributing this check to `checkov`?
Hi @gruebel,
Yes, I will read how to correctly contribute to Checkov and do it in the coming days.
(I will need a bit of time as it will be the first time)
Hopes it's ... | [
{
"body": "**Describe the issue**\r\nIt seems that there are no Checkov checks related to the best practice of not allowing Public Network Access to Azure Key Vault\r\nIt should be either:\r\n\r\n- A list of pre-approved ip_rules in a network_acls block\r\n- A private endpoint\r\n\r\n**Examples**\r\n\r\n````hcl... | a9f7b28ad9385a42d95377800195e48cd657384b | {
"head_commit": "48ecaf71ef87aa9a9a9fa800a47df7bc72a21a20",
"head_commit_message": "update test",
"patch_to_review": "diff --git a/checkov/terraform/checks/resource/azure/KeyVaultDisablesPublicNetworkAccess.py b/checkov/terraform/checks/resource/azure/KeyVaultDisablesPublicNetworkAccess.py\nnew file mode 100644\... | [
{
"diff_hunk": "@@ -0,0 +1,38 @@\n+from checkov.common.models.enums import CheckCategories, CheckResult\n+from checkov.terraform.checks.resource.base_resource_value_check import BaseResourceValueCheck\n+\n+\n+class KeyVaultDisablesPublicNetworkAccess(BaseResourceValueCheck):\n+ def __init__(self):\n+ ... | eaffb0016c7c0b662d6c35ba307acadb30716a77 | diff --git a/checkov/terraform/checks/resource/azure/KeyVaultDisablesPublicNetworkAccess.py b/checkov/terraform/checks/resource/azure/KeyVaultDisablesPublicNetworkAccess.py
new file mode 100644
index 0000000000..c3f2152f2d
--- /dev/null
+++ b/checkov/terraform/checks/resource/azure/KeyVaultDisablesPublicNetworkAccess.p... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Security Patches / Vulnerability Fixes"
} |
ansible__ansible-24768@5558949 | ansible/ansible | Python | 24,768 | vmware_guest: Various fixes to VM customizations (from template) | ##### SUMMARY
This patch implements:
- Add support for `type` (could be `dhcp` or `static`)
- Avoid VM network customizations when there's only a `name`/`vlan`, `device_type` or `mac` entry
- New find_obj() function from vmware.py replacing get_obj()
- Implement proper resource_pool selection (using provided `reso... | 2017-05-18T08:12:08Z | vmware_guest: Clone from template results in fault.NicSettingMismatch.summary
<!---
Verify first that your issue/request is not already reported on GitHub.
Also test if the latest release, and master branch are affected too.
-->
##### ISSUE TYPE
<!--- Pick one below and delete the rest: -->
- Bug Report
###... | cc @jctanner
[click here for bot help](https://github.com/ansible/ansibullbot/blob/master/ISSUE_HELP.md)
<!--- boilerplate: notify --->
@nerzhul Have you seen this before ? I cannot wrap my head around this one :-/
did saw this error before, it's a VMWare API error ?
https://www.vmware.com/support/developer/vc-sdk/visd... | [
{
"body": "<!---\r\nVerify first that your issue/request is not already reported on GitHub.\r\nAlso test if the latest release, and master branch are affected too.\r\n-->\r\n\r\n##### ISSUE TYPE\r\n<!--- Pick one below and delete the rest: -->\r\n - Bug Report\r\n\r\n##### COMPONENT NAME\r\n<!--- Name of the mo... | f39fa7fd228f556ee973315bb904269ba685bbbc | {
"head_commit": "55589493f2c87cfd6b1a545fd4ef313e10292309",
"head_commit_message": "Various fixes to VM customizations (from template)\n\nThis patch implements:\r\n- New find_obj() function from vmware.py replacing get_obj()\r\n- Implement proper resource_pool selection\r\n- Fix productId implementation (was not w... | [
{
"diff_hunk": "@@ -789,52 +794,59 @@ def customize_vm(self, vm_obj):\n ident = vim.vm.customization.Sysprep()\n \n ident.userData = vim.vm.customization.UserData()\n+\n+ # Setting hostName, orgName and fullName is mandatory, so we set some default when missing\n i... | 7728db3c6d7e391568733174734769dd8737fc23 | diff --git a/lib/ansible/module_utils/vmware.py b/lib/ansible/module_utils/vmware.py
index 592d35d05e1758..3a0acc85fafbf9 100644
--- a/lib/ansible/module_utils/vmware.py
+++ b/lib/ansible/module_utils/vmware.py
@@ -52,6 +52,30 @@ def wait_for_task(task):
time.sleep(15)
+def find_obj(content, vimtype, n... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-24596@2b4ebaa | ansible/ansible | Python | 24,596 | Fixes #24578: ROLLBACK_COMPLETE is a failure state | ##### SUMMARY
Fixes #24578. When CloudFormation fails to create stack and ends up in ROLLBACK_COMPLETED status, should be a failure state for this module.
##### ISSUE TYPE
- Bugfix Pull Request
##### COMPONENT NAME
cloudformation
##### ANSIBLE VERSION
```
ansible 2.3.0.0
config file = /Users/jose.arme... | 2017-05-14T16:32:00Z | Ansible should fail when CloudFormation ends up in a `ROLLBACK_COMPLETE` status
##### ISSUE TYPE
- Bug Report
##### COMPONENT NAME
cloudformation
##### ANSIBLE VERSION
```
ansible 2.3.0.0
config file = /Users/jose.armesto/.ansible.cfg
configured module search path = Default w/o overrides
python vers... | cc @tedder @ryansb
[click here for bot help](https://github.com/ansible/ansibullbot/blob/master/ISSUE_HELP.md)
<!--- boilerplate: notify --->
It seems like in the boto3 rewrite, [the case when the stack status was ROLLBACK_COMPLETE was forgotten](https://github.com/ansible/ansible-modules-core/commit/f040d63403f6c459a2... | [
{
"body": "##### ISSUE TYPE\r\n - Bug Report\r\n\r\n##### COMPONENT NAME\r\ncloudformation\r\n\r\n##### ANSIBLE VERSION\r\n```\r\nansible 2.3.0.0\r\n config file = /Users/jose.armesto/.ansible.cfg\r\n configured module search path = Default w/o overrides\r\n python version = 2.7.13 (default, Feb 7 2017, 22:... | fdcad0f44d0a10470be7270196765bf1f46864d4 | {
"head_commit": "2b4ebaa8d937259f3967ca9c278a4f69164cd1af",
"head_commit_message": "ROLLBACK_COMPLETE is a failure state\n\nFixes #24578",
"patch_to_review": "diff --git a/lib/ansible/modules/cloud/amazon/cloudformation.py b/lib/ansible/modules/cloud/amazon/cloudformation.py\nindex 6f8a6e2984250f..3bb407f847e109... | [
{
"diff_hunk": "@@ -343,7 +343,7 @@ def stack_operation(cfn, stack_name, operation):\n else:\n ret.update({'changed': False, 'failed': True, 'output' : 'Stack not found.'})\n return ret\n- elif stack['StackStatus'].endswith('_ROLLBACK_COMPLETE'):\n+ elif... | cc57cd6846046377e4505c29a7fb3d2af3abbc48 | diff --git a/lib/ansible/modules/cloud/amazon/cloudformation.py b/lib/ansible/modules/cloud/amazon/cloudformation.py
index 6f8a6e2984250f..7b5c5b26c0baeb 100644
--- a/lib/ansible/modules/cloud/amazon/cloudformation.py
+++ b/lib/ansible/modules/cloud/amazon/cloudformation.py
@@ -343,8 +343,10 @@ def stack_operation(cfn,... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
bridgecrewio__checkov-4172@621f986 | bridgecrewio/checkov | Python | 4,172 | feat(general): Skip check in json file | **By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.**
[//]: # "
# PR Title
Be aware that we use the title to create changelog automatically and therefore only allow specific prefixes
- break: to indicate a breaking change, this supers... | 2022-12-29T20:08:30Z | Skip checks by directory/path/glob
**Describe the issue**
The secrets scanner is detecting possible secrets in JSON files, but false positives can't be ignored because JSON files don't allow for comments. Excluding the check `CKV_SECRET_6` for the entire directory scanned is too broad of an exclusion.
It would be r... | [
{
"body": "**Describe the issue**\r\nThe secrets scanner is detecting possible secrets in JSON files, but false positives can't be ignored because JSON files don't allow for comments. Excluding the check `CKV_SECRET_6` for the entire directory scanned is too broad of an exclusion.\r\n\r\nIt would be really nice... | ab681287bc5a2c2072be815b65a13221dbb1836e | {
"head_commit": "621f98612d783e43da5d37ac829b30c90c405c44",
"head_commit_message": "Remove redundant comment",
"patch_to_review": "diff --git a/README.md b/README.md\nindex ddac4898b0..b6edd54381 100644\n--- a/README.md\n+++ b/README.md\n@@ -203,7 +203,11 @@ The `--workdir /tf` flag is optional to change the wor... | [
{
"diff_hunk": "@@ -241,13 +242,16 @@ def search_for_suppression(\n bc_check_id: str,\n severity: Severity | None,\n secret: PotentialSecret,\n- runner_filter: RunnerFilter\n+ runner_filter: RunnerFilter,\n+ root_folder: str | None\n ) -> ... | da01c6a725838c6caf69df2fc7a6b63dda895a26 | diff --git a/README.md b/README.md
index ddac4898b0..b6edd54381 100644
--- a/README.md
+++ b/README.md
@@ -203,7 +203,11 @@ The `--workdir /tf` flag is optional to change the working directory to the moun
### Running or skipping checks
By using command line flags, you can specify to run only named checks (allow li... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
ansible__ansible-24509@8175091 | ansible/ansible | Python | 24,509 | elasticache_parameter_group: fix KeyError bug #24475 | ##### SUMMARY
Some parameters don't have a list of allowed values or a current value. This wasn't taken into account, so when the key didn't exist would get KeyError exception. Also fixed yes/no values for parameters being interpreted as truthy so changed doesn't always show as True when modifying those. Used to_text.... | 2017-05-11T15:29:14Z | elasticache_parameter_group fails with KeyError: 'AllowedValues'
##### ISSUE TYPE
- Bug Report
##### COMPONENT NAME
elasticache_parameter_group
##### ANSIBLE VERSION
```
$ ansible --version
ansible 2.3.0.0
config file = /home/tessa/.ansible.cfg
configured module search path = Default w/o overrides
... | cc @s-hertel
[click here for bot help](https://github.com/ansible/ansibullbot/blob/master/ISSUE_HELP.md)
<!--- boilerplate: notify ---> | [
{
"body": "##### ISSUE TYPE\r\n - Bug Report\r\n\r\n##### COMPONENT NAME\r\nelasticache_parameter_group\r\n\r\n##### ANSIBLE VERSION\r\n```\r\n$ ansible --version\r\nansible 2.3.0.0\r\n config file = /home/tessa/.ansible.cfg\r\n configured module search path = Default w/o overrides\r\n python version = 2.7.1... | fc3cc73b73a39b0ab629ba76ac4f9ca65cc38eee | {
"head_commit": "817509162a75d44f0053d9e1304a3ba0b3e4cfb9",
"head_commit_message": "Fix KeyError bug by appending None if key doesn't exist\n\nensure value is the expected type; if if expecting something parsed as truthy try to turn it back into the desired value - fixes result showing always changed since bool co... | [
{
"diff_hunk": "@@ -156,8 +156,10 @@ def make_current_modifiable_param_dict(module, conn, name):\n modifiable_params = {}\n \n for param in parameters:\n- if param[\"IsModifiable\"] and (\"AllowedValues\" and \"ParameterValue\") in param:\n- modifiable_params[param[\"ParameterName\"]] ... | adff358de2a0c1a68153a38813ec9e6afa53dcbc | diff --git a/lib/ansible/modules/cloud/amazon/elasticache_parameter_group.py b/lib/ansible/modules/cloud/amazon/elasticache_parameter_group.py
index 46a73ef3396d70..4f28acbcadf4b2 100644
--- a/lib/ansible/modules/cloud/amazon/elasticache_parameter_group.py
+++ b/lib/ansible/modules/cloud/amazon/elasticache_parameter_gr... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-24025@b1079b5 | ansible/ansible | Python | 24,025 | Allow win_scheduled_task to support adding and removing task paths | ##### SUMMARY
Fixes #23471 by allowing tasks to be created in non-existent task paths when state is present, creating the task path in the process, and will attempt to remove the task path when state is absent. Child tasks and folders must not exist in order for the task path to be removed under the latter scenario.
... | 2017-04-26T15:44:49Z | win_scheduled_task: Adding tasks in non-existing path fails
<!---
Verify first that your issue/request is not already reported on GitHub.
Also test if the latest release, and master branch are affected too.
-->
##### ISSUE TYPE
<!--- Pick one below and delete the rest: -->
- Bug Report
##### COMPONENT NAME
... | cc @petemounce
[click here for bot help](https://github.com/ansible/ansibullbot/blob/master/ISSUE_HELP.md)
<!--- boilerplate: notify ---> | [
{
"body": "<!---\r\nVerify first that your issue/request is not already reported on GitHub.\r\nAlso test if the latest release, and master branch are affected too.\r\n-->\r\n\r\n##### ISSUE TYPE\r\n<!--- Pick one below and delete the rest: -->\r\n - Bug Report\r\n\r\n##### COMPONENT NAME\r\n<!--- Name of the mo... | 86a63cfcd7f0c5fc2dd6969a9df2e62bc94f6c58 | {
"head_commit": "b1079b538ca7b8cef7e294db586031977063a77e",
"head_commit_message": "added integration tests for path creation and removal",
"patch_to_review": "diff --git a/lib/ansible/modules/windows/win_scheduled_task.ps1 b/lib/ansible/modules/windows/win_scheduled_task.ps1\nindex d949561492254c..091cbdc04acff... | [
{
"diff_hunk": "@@ -73,9 +116,18 @@ try {\n $exists = $true\n }\n elseif ( ($measure.count -eq 0) -and ($state -eq \"absent\") ){\n- # Nothing to do\n+ # Nothing to do for the task\n $result.exists = $false\n $result.msg = \"Task does not exist\"\n+\n+ # Remo... | b1804fb7355a62dad1d7042ac61e74121f09cede | diff --git a/lib/ansible/modules/windows/win_scheduled_task.ps1 b/lib/ansible/modules/windows/win_scheduled_task.ps1
index d949561492254c..06cfb3c38b2baf 100644
--- a/lib/ansible/modules/windows/win_scheduled_task.ps1
+++ b/lib/ansible/modules/windows/win_scheduled_task.ps1
@@ -26,13 +26,55 @@ $result = @{
changed... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
bridgecrewio__checkov-3497@d155ef6 | bridgecrewio/checkov | Python | 3,497 | feat(general): add flag for summary position | **By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.**
[//]: # "
# PR Title
Be aware that we use the title to create changelog automatically and therefore only allow specific prefixes
- break: to indicate a breaking change, this supers... | 2022-09-12T11:29:26Z | Move CLI output summary to the bottom of the output
**Describe the issue**
If you have more than a few failed checks, it can be difficult to scroll to the top to see the summary or in a terminal, it may even be cut off. Can we move the summary to the bottom after the policy violations? | Sensational! I love this.
The relevant part of our code that needs to be refactored:
https://github.com/bridgecrewio/checkov/blob/5fdaf23e404b247f686ce6e07ec8f98032380a2d/checkov/common/output/report.py#L245
Would appreciate a contribution here!
Needs to be a flag, default for bottom, as if you run it in ci you don... | [
{
"body": "**Describe the issue**\r\nIf you have more than a few failed checks, it can be difficult to scroll to the top to see the summary or in a terminal, it may even be cut off. Can we move the summary to the bottom after the policy violations?",
"number": 3222,
"title": "Move CLI output summary to ... | 5d1558298eb55617e69d0e16d6acc8ebd2fe0f5a | {
"head_commit": "d155ef6c1aad86371cac6b449efecdc5a3a60616",
"head_commit_message": "rerun failed test",
"patch_to_review": "diff --git a/checkov/common/output/report.py b/checkov/common/output/report.py\nindex ac9870d67b..b9b1e6fd4d 100644\n--- a/checkov/common/output/report.py\n+++ b/checkov/common/output/repor... | [
{
"diff_hunk": "@@ -574,6 +574,8 @@ def add_parser_args(parser: ArgumentParser) -> None:\n env_var='CKV_SECRETS_SCAN_BLACK_LIST',\n action='append',\n help='black file list to filter out from the secret scanner')\n+ parser.add('--summary-position-bottom', action='... | 35ab7c0c326925667bbad248245dc3e32f24663d | diff --git a/checkov/common/output/report.py b/checkov/common/output/report.py
index ac9870d67b..79483a3757 100644
--- a/checkov/common/output/report.py
+++ b/checkov/common/output/report.py
@@ -178,6 +178,7 @@ def print_console(
created_baseline_path: str | None = None,
baseline: Baseline | None = No... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "New Feature Additions"
} |
ansible__ansible-24472@a345464 | ansible/ansible | Python | 24,472 | add any_errors_fatal global config | ##### SUMMARY
<!--- Describe the change, including rationale and design decisions -->
fixes #22340
##### ISSUE TYPE
<!--- Pick one below and delete the rest: -->
- Feature Pull Request
##### COMPONENT NAME
<!--- Name of the module/plugin/module/task -->
plays
##### ANSIBLE VERSION
<!--- Paste verbat... | 2017-05-10T22:21:56Z | Feature Idea: globally configurable any_errors_fatal in ansible.cfg
<!---
Verify first that your issue/request is not already reported on GitHub.
Also test if the latest release, and master branch are affected too.
-->
##### ISSUE TYPE
<!--- Pick one below and delete the rest: -->
- Feature Idea
##### COMPO... | I just wanted to say that this is a brilliant idea and I would have much more faith in my CD pipelines with this implemented.
I'd prefer to be able to set the default value of `any_errors_fatal` in ansible.cfg as well. It can be false for compatibility and to match existing behavior.
We use ansible inside tooling c... | [
{
"body": "<!---\r\nVerify first that your issue/request is not already reported on GitHub.\r\nAlso test if the latest release, and master branch are affected too.\r\n-->\r\n\r\n##### ISSUE TYPE\r\n<!--- Pick one below and delete the rest: -->\r\n - Feature Idea\r\n\r\n##### COMPONENT NAME\r\n<!--- Name of the ... | 29f5fe3ddda64dcac4de5e1bc14c3232b20f3702 | {
"head_commit": "a3454647954019a79ac9f564fce63cfa507ba941",
"head_commit_message": "add any_errors_fatal global config",
"patch_to_review": "diff --git a/examples/ansible.cfg b/examples/ansible.cfg\nindex dc8d8b7443a380..674c5d3333c848 100644\n--- a/examples/ansible.cfg\n+++ b/examples/ansible.cfg\n@@ -310,6 +31... | [
{
"diff_hunk": "@@ -180,6 +180,16 @@ ANSIBLE_SSH_RETRIES:\n value_type: integer\n vars: []\n yaml: {key: ssh_connection.retries}\n+ANY_ERRORS_FATAL:\n+ default: False\n+ env:\n+ - name: ANSIBLE_ANY_ERRORS_FATAL\n+ ini:\n+ - section: defauls",
"line": null,
"original_line": 188,... | eb65de2dd4617c0962817e7fe9aca3398b932c9a | diff --git a/examples/ansible.cfg b/examples/ansible.cfg
index dc8d8b7443a380..674c5d3333c848 100644
--- a/examples/ansible.cfg
+++ b/examples/ansible.cfg
@@ -310,6 +310,9 @@
# ENABLING THIS COULD BE A SECURITY RISK
#allow_unsafe_lookups = False
+# set default errors for all plays
+#any_errors_fatal = False
+
[pri... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
ansible__ansible-23967@f97e4c5 | ansible/ansible | Python | 23,967 | ec2_vpc_dhcp_options_facts: if tags don't exist set them to default list instead of crashing - fixes #23825 | ##### SUMMARY
Set tags to an default list rather than crashing if they don't exist. If there are no tags boto doesn't return the default Name tag and its empty value. Fixes #23825
##### ISSUE TYPE
- Bugfix Pull Request
##### COMPONENT NAME
lib/ansible/modules/cloud/amazon/ec2_vpc_dhcp_options_facts.py
####... | 2017-04-25T12:55:42Z | ec2_vpc_dhcp_options_facts
<!---
Verify first that your issue/request is not already reported on GitHub.
Also test if the latest release, and master branch are affected too.
-->
##### ISSUE TYPE
<!--- Pick one below and delete the rest: -->
- Bug Report
##### COMPONENT NAME
<!--- Name of the module/plugin... | cc @naslanidis
[click here for bot help](https://github.com/ansible/ansibullbot/blob/master/ISSUE_HELP.md)
<!--- boilerplate: notify ---> | [
{
"body": "<!---\r\nVerify first that your issue/request is not already reported on GitHub.\r\nAlso test if the latest release, and master branch are affected too.\r\n-->\r\n\r\n##### ISSUE TYPE\r\n<!--- Pick one below and delete the rest: -->\r\n - Bug Report\r\n\r\n##### COMPONENT NAME\r\n<!--- Name of the mo... | 3959597f7de04ead8fbec07d4cb48540bb3b67b2 | {
"head_commit": "f97e4c5a142ffee270b4b20e3358aee7d4a9927c",
"head_commit_message": "dhcp_option will always have a name tag",
"patch_to_review": "diff --git a/lib/ansible/modules/cloud/amazon/ec2_vpc_dhcp_options_facts.py b/lib/ansible/modules/cloud/amazon/ec2_vpc_dhcp_options_facts.py\nindex 143c6f45076d58..3b7... | [
{
"diff_hunk": "@@ -98,6 +98,8 @@\n \n \n def get_dhcp_options_info(dhcp_option):\n+ if 'Tags' not in dhcp_option:\n+ dhcp_option['Tags'] = [{'Value': '', 'Key': 'Name'}]\n dhcp_option_info = {'DhcpOptionsId': dhcp_option['DhcpOptionsId'],\n 'DhcpConfigurations': dhcp_optio... | 2d4c500de3ccc0c3e630d60ab9e8e8143a09ef00 | diff --git a/lib/ansible/modules/cloud/amazon/ec2_vpc_dhcp_options_facts.py b/lib/ansible/modules/cloud/amazon/ec2_vpc_dhcp_options_facts.py
index 143c6f45076d58..96f166c2b65631 100644
--- a/lib/ansible/modules/cloud/amazon/ec2_vpc_dhcp_options_facts.py
+++ b/lib/ansible/modules/cloud/amazon/ec2_vpc_dhcp_options_facts.... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-23742@a10b1d5 | ansible/ansible | Python | 23,742 | keep unsafe .. unsafe | ##### SUMMARY
fixes #23734, which was broken in previous fix that allowed non string types to be templated
##### ISSUE TYPE
<!--- Pick one below and delete the rest: -->
- Bugfix Pull Request
##### COMPONENT NAME
<!--- Name of the module/plugin/module/task -->
templating
##### ANSIBLE VERSION
<!--- Past... | 2017-04-19T13:31:39Z | !unsafe broken in Ansible 2.3.0.0?
<!---
Verify first that your issue/request is not already reported on GitHub.
Also test if the latest release, and master branch are affected too.
-->
##### ISSUE TYPE
<!--- Pick one below and delete the rest: -->
- Bug Report
##### COMPONENT NAME
<!--- Name of the modu... | I can confirm this also affects 2.2.2.0 but is working in 2.2.1.0
Do you have yaml playbook file?
need_info
I didn't reproduce with this playbook with or w/o $ sign in $labels:
```
- hosts: localhost
connection: local
gather_facts: no
vars:
labels:
instance: "test"
job: "test"
a:... | [
{
"body": "<!---\r\nVerify first that your issue/request is not already reported on GitHub.\r\nAlso test if the latest release, and master branch are affected too.\r\n-->\r\n\r\n##### ISSUE TYPE\r\n<!--- Pick one below and delete the rest: -->\r\n - Bug Report\r\n\r\n\r\n##### COMPONENT NAME\r\n<!--- Name of th... | ffa92485b4e8f958347029c6d701c1e53cec14df | {
"head_commit": "a10b1d5ac51accab95ee22265cd758be15d66e8f",
"head_commit_message": "keep unsafe .. unsafe\n\nfixes #23734, which was broken in previous fix that allowed non string types to be templated\nuse new 'is_template' function vs bastardizing others\nrefactored clean_data to allow for arbitrary data structu... | [
{
"diff_hunk": "@@ -482,6 +499,16 @@ def template(self, variable, convert_bare=False, preserve_trailing_newlines=True\n else:\n return variable\n \n+ def is_template(self, data):\n+ ''' lets us know if data has a template'''\n+ try:\n+ new = self.template(... | 09168c98b96ff6b6e0c4da364d587c302247bfa0 | diff --git a/lib/ansible/playbook/conditional.py b/lib/ansible/playbook/conditional.py
index 0681482e7d9af6..c4650a39f52ec7 100644
--- a/lib/ansible/playbook/conditional.py
+++ b/lib/ansible/playbook/conditional.py
@@ -139,7 +139,7 @@ def _check_conditional(self, conditional, templar, all_vars):
if conditional... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-23498@a4bcd3c | ansible/ansible | Python | 23,498 | rds: do not update multi-az unless specified - fixes #23385 | ##### SUMMARY
multi_zone [defaults to False](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/cloud/amazon/rds.py#L1084) rather than [None as the documentation states](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/cloud/amazon/rds.py#L108) so [this line](https://github.com/ansible/... | 2017-04-11T17:18:59Z | rds.py reverts multi-AZ RDS back to single-AZ on any 'modify' action where 'multi_zone' is not specified
##### ISSUE TYPE
- Bug Report
##### COMPONENT NAME
rds.py
##### ANSIBLE VERSION
```
ansible 2.3.0.0 (stable-2.3 0fe53eda86) last updated 2017/04/06 22:20:16 (GMT -500)
config file =
configured modu... | cc @bpennypacker @willthames
[click here for bot help](https://github.com/ansible/ansibullbot/blob/master/ISSUE_HELP.md)
<!--- boilerplate: notify --->
Confirming this. [multi_zone defaults to False](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/cloud/amazon/rds.py#L1084) rather than None so this li... | [
{
"body": "##### ISSUE TYPE\r\n - Bug Report\r\n\r\n##### COMPONENT NAME\r\nrds.py\r\n\r\n##### ANSIBLE VERSION\r\n```\r\nansible 2.3.0.0 (stable-2.3 0fe53eda86) last updated 2017/04/06 22:20:16 (GMT -500)\r\n config file = \r\n configured module search path = Default w/o overrides\r\n python version = 2.7.1... | 2f64e2c7fb37837daecffd876b9c16b5246e910c | {
"head_commit": "a4bcd3ccc5d9277abeb261b06e701d701192c5fa",
"head_commit_message": "allow multi_az to be unmodified if not explicitly specified with command: modify",
"patch_to_review": "diff --git a/lib/ansible/modules/cloud/amazon/rds.py b/lib/ansible/modules/cloud/amazon/rds.py\nindex e8d33d297b7603..0ca1cfba... | [
{
"diff_hunk": "@@ -1124,6 +1124,9 @@ def main():\n 'restore': restore_db_instance,\n }\n \n+ if module.params.['command'] != 'modify' and module.params.['multi_zone'] is None:",
"line": null,
"original_line": 1127,
"original_start_line": null,
"path": "lib/ansible/modules/cloud/a... | a93c9bf6e5357c0aa7f5efa5d961429326a553c5 | diff --git a/lib/ansible/modules/cloud/amazon/rds.py b/lib/ansible/modules/cloud/amazon/rds.py
index e8d33d297b7603..007dcbf5fa19a3 100644
--- a/lib/ansible/modules/cloud/amazon/rds.py
+++ b/lib/ansible/modules/cloud/amazon/rds.py
@@ -340,7 +340,7 @@
except ImportError:
has_rds2 = False
-DEFAULT_PORTS= {
+DEFAU... | {
"difficulty": "medium",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
bridgecrewio__checkov-3058@d4ce7a1 | bridgecrewio/checkov | Python | 3,058 | Support skip comment in yaml runners | **By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.**
## Description
Supporting skipping via comment for all yaml runners
Fixes [# (2986)](https://github.com/bridgecrewio/checkov/issues/2986)
## New/Edited policies (Delete if not relevant)
... | 2022-06-06T10:21:01Z | Skipping via comment in .gitlab-ci not working for CKV_GITLABCI_2
**Describe the issue**
The check CKV_GITLABCI_2 is giving me a false positive. So I like to skip it as below, but this is not working. I tried different variants but only `checkov --skip-check CKV_GITLABCI_2` is actually working but globally disabling... | We'll take two approaches. Adding skips but also fixing the FP. Sit tight. | [
{
"body": "**Describe the issue**\r\n\r\nThe check CKV_GITLABCI_2 is giving me a false positive. So I like to skip it as below, but this is not working. I tried different variants but only `checkov --skip-check CKV_GITLABCI_2` is actually working but globally disabling the check.\r\n\r\n**Examples**\r\n\r\n```y... | bcbe033d26be012b81f03d12ea81efa6598bc10b | {
"head_commit": "d4ce7a189192340d15999699ff7290c357178f3e",
"head_commit_message": "fix tests",
"patch_to_review": "diff --git a/checkov/common/runners/object_runner.py b/checkov/common/runners/object_runner.py\nindex f858456d01..31c5ddd1c8 100644\n--- a/checkov/common/runners/object_runner.py\n+++ b/checkov/com... | [
{
"diff_hunk": "@@ -102,7 +102,7 @@ def _scan_yaml(\n results: Dict[str, Any],\n ) -> None:\n for check in checks:\n- skip_info = ([x for x in skipped_checks if x[\"id\"] == check.id] or [{}])[0]\n+ skip_info = ([x for x in skipped_checks if (x[\"id\"] == check.id a... | 3decd065e6f53c51e35e231ead223cf1e3ac433c | diff --git a/checkov/common/runners/object_runner.py b/checkov/common/runners/object_runner.py
index f858456d01..31c5ddd1c8 100644
--- a/checkov/common/runners/object_runner.py
+++ b/checkov/common/runners/object_runner.py
@@ -10,6 +10,7 @@
from checkov.common.parallelizer.parallel_runner import parallel_runner
from ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
bridgecrewio__checkov-3052@ed08897 | bridgecrewio/checkov | Python | 3,052 | output baseline skipped in results | **By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.**
## Description
added boolean flag `--output-baseline-as-skipped` to output skipped checks due to baseline in the results report.
Fixes [#1502](https://github.com/bridgecrewio/checkov/issues/15... | 2022-06-04T20:17:16Z | Add option to output checks skipped from baseline
**Is your feature request related to a problem? Please describe.**
Yes. We've inherited a terraform repo with a lot of legacy problems. We've introduced checkov to ensure new config going
forward meets our standards. We've also generated baseline files for all of ... | Sounds very interesting. We're open for contributions here, should be implemented somewhere near this:
https://github.com/bridgecrewio/checkov/blob/ca2673633080910d69ae5a6c8133eefdaeb36787/checkov/common/output/baseline.py#L13
I'm interested in giving this a try. Has anyone worked on this issue yet?
Our team at my c... | [
{
"body": "**Is your feature request related to a problem? Please describe.**\r\nYes. We've inherited a terraform repo with a lot of legacy problems. We've introduced checkov to ensure new config going \r\nforward meets our standards. We've also generated baseline files for all of the existing legacy terrafo... | fe2b394d9794bfab7d21e5ab6c3968bcec149877 | {
"head_commit": "ed088977a2f3a0d9678aadda4a35a5d21e966558",
"head_commit_message": "output baseline skipped in results",
"patch_to_review": "diff --git a/checkov/common/output/baseline.py b/checkov/common/output/baseline.py\nindex 7a72cc0496..ca16ecdd4e 100644\n--- a/checkov/common/output/baseline.py\n+++ b/chec... | [
{
"diff_hunk": "@@ -497,6 +497,9 @@ def add_parser_args(parser: ArgumentParser) -> None:\n parser.add('--skip-cve-package',\n help='filter scan to run on all packages but a specific package identifier (denylist), You can '\n 'specify this argument multiple times to skip mu... | bf0347b29a23603f7824bdba26dd219e2d794d53 | diff --git a/checkov/common/output/baseline.py b/checkov/common/output/baseline.py
index 7a72cc0496..9f4a422e68 100644
--- a/checkov/common/output/baseline.py
+++ b/checkov/common/output/baseline.py
@@ -2,6 +2,7 @@
import json
from collections import defaultdict
+from checkov.common.models.enums import CheckResult
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
bridgecrewio__checkov-3007@958f2e0 | bridgecrewio/checkov | Python | 3,007 | fix CKV_AZURE_116 to reflect changes in v2.97.0 of Terraform Azure provider | fixes #3006
Unfortunately, I couldn't find the place to update the docs at https://docs.bridgecrew.io/docs/ensure-that-aks-uses-azure-policies-add-on. If someone can point me to the corresponding place, I will also update the docs.
By submitting this pull request, I confirm that my contribution is made under the... | 2022-05-24T16:39:28Z | CKV_AZURE_116 fails with Terraform Azure provider >= v.2.97.0
**Describe the issue**
This issue is regarding CKV_AZURE_116.
Since v2.97.0 of the Azure Terraform provider, the Azure policies add-on is enabled by setting
```terraform
azure_policy_enabled = true
```
as a top-level property in a `azurerm_kubernet... | [
{
"body": "**Describe the issue**\r\nThis issue is regarding CKV_AZURE_116.\r\nSince v2.97.0 of the Azure Terraform provider, the Azure policies add-on is enabled by setting\r\n\r\n```terraform\r\nazure_policy_enabled = true\r\n```\r\n\r\nas a top-level property in a `azurerm_kubernetes_cluster` resource defini... | 85344715cac779b67cc0e9782591ba22e0220520 | {
"head_commit": "958f2e0f9fdf9cfeda88eae9200d81eb45e83761",
"head_commit_message": "fix CKV_AZURE_116 to reflect changes in v2.97.0 of Terraform Azure provider",
"patch_to_review": "diff --git a/checkov/terraform/checks/resource/azure/AKSUsesAzurePoliciesAddon.py b/checkov/terraform/checks/resource/azure/AKSUses... | [
{
"diff_hunk": "@@ -1,17 +1,31 @@\n-from checkov.common.models.enums import CheckCategories\n-from checkov.terraform.checks.resource.base_resource_value_check import BaseResourceValueCheck\n+from typing import Dict, List, Any\n \n+from checkov.common.models.enums import CheckCategories, CheckResult\n+from check... | c48845ad1be99a8e018ce20f2a40491c6f1766b6 | diff --git a/checkov/terraform/checks/resource/azure/AKSUsesAzurePoliciesAddon.py b/checkov/terraform/checks/resource/azure/AKSUsesAzurePoliciesAddon.py
index 5132754c7c..83d9b415e5 100644
--- a/checkov/terraform/checks/resource/azure/AKSUsesAzurePoliciesAddon.py
+++ b/checkov/terraform/checks/resource/azure/AKSUsesAzu... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
ansible__ansible-22865@fcb9460 | ansible/ansible | Python | 22,865 | Fix incorrect command-line parameters for Solaris | ##### SUMMARY
<!--- Describe the change, including rationale and design decisions -->
Solaris 'mount' command does not have flag to point to fstab file.
So no such flags should be passed to the command.
Fixes #22135
<!---
If you are fixing an existing issue, please include "Fixes #nnn" in your
commit message an... | 2017-03-22T11:12:00Z | Mount module: incorrect command-line arguments used for Solaris.
<!---
Verify first that your issue/request is not already reported on GitHub.
Also test if the latest release, and master branch are affected too.
-->
##### ISSUE TYPE
<!--- Pick one below and delete the rest: -->
- Bug Report
##### COMPONENT... | @AlexZolotarenko would you be able to submit a pullrequest for that patch?
needs_info
@AlexZolotarenko This issue is waiting for your response. Please respond or the issue will be closed.
[click here for bot help](https://github.com/ansible/ansibullbot/blob/master/ISSUE_HELP.md)
<!--- boilerplate: needs_info_base -... | [
{
"body": "<!---\r\nVerify first that your issue/request is not already reported on GitHub.\r\nAlso test if the latest release, and master branch are affected too.\r\n-->\r\n\r\n##### ISSUE TYPE\r\n<!--- Pick one below and delete the rest: -->\r\n - Bug Report\r\n\r\n##### COMPONENT NAME\r\n<!--- Name of the mo... | 98c98125f06f6903bf8f12ab76b5794c72a1f37c | {
"head_commit": "fcb9460103c162a879848e4ea26910df4e3cf1de",
"head_commit_message": "Fix incorrect command-line parameters for Solaris",
"patch_to_review": "diff --git a/lib/ansible/modules/system/mount.py b/lib/ansible/modules/system/mount.py\nindex e775e8fdabe979..4573dfbcdcbf26 100644\n--- a/lib/ansible/module... | [
{
"diff_hunk": "@@ -327,7 +327,7 @@ def unset_mount(module, args):\n def _set_fstab_args(fstab_file):\n result = []\n \n- if fstab_file and fstab_file != '/etc/fstab':\n+ if fstab_file and fstab_file != '/etc/fstab' and get_platform().lower() != 'sunos':",
"line": null,
"original_line": 330,
... | a80fb84acdb29f265b646db4324dd115a3ad6b3f | diff --git a/lib/ansible/modules/system/mount.py b/lib/ansible/modules/system/mount.py
index e775e8fdabe979..1661485a5cf683 100644
--- a/lib/ansible/modules/system/mount.py
+++ b/lib/ansible/modules/system/mount.py
@@ -327,7 +327,10 @@ def unset_mount(module, args):
def _set_fstab_args(fstab_file):
result = []
... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
bridgecrewio__checkov-2761@ccd21d4 | bridgecrewio/checkov | Python | 2,761 | Fix mypy issues for json runner and yaml runner | By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Fixes #2761 | 2022-04-04T19:37:36Z | Fix type hint issues in json_doc and yaml_doc
**Describe the issue**
For better code quality and reducing errors, which can be found via statical type checking the `json_doc` and `yaml_doc` code base needs to be checked for correct type hint definition.
**Additional context**
the current output from `mypy` after r... | [
{
"body": "**Describe the issue**\r\nFor better code quality and reducing errors, which can be found via statical type checking the `json_doc` and `yaml_doc` code base needs to be checked for correct type hint definition.\r\n\r\n**Additional context**\r\nthe current output from `mypy` after removing `json_doc` ... | 102f5ad4765918bfb848c89f7e86264457083880 | {
"head_commit": "ccd21d468136f2990ca67c92cd58237bad137e55",
"head_commit_message": "Fix annotation",
"patch_to_review": "diff --git a/checkov/common/checks/base_check.py b/checkov/common/checks/base_check.py\nindex 7f1918dd1f..23fd586eab 100644\n--- a/checkov/common/checks/base_check.py\n+++ b/checkov/common/che... | [
{
"diff_hunk": "@@ -134,14 +138,17 @@ def parse_vulns_to_records(self, report, result, rootless_file_path, runner_filt\n report.add_record(record)\n \n def find_scannable_files(\n- self, root_path: Optional[Path], files: Optional[List[str]], excluded_paths: Set[str], exclude_package_json:... | 95f6836ea1b8c7c5811175e447a616e33bde2092 | diff --git a/checkov/common/checks/base_check.py b/checkov/common/checks/base_check.py
index 7f1918dd1f..23fd586eab 100644
--- a/checkov/common/checks/base_check.py
+++ b/checkov/common/checks/base_check.py
@@ -14,6 +14,8 @@ class BaseCheck(metaclass=MultiSignatureMeta):
name = ""
categories: "Iterable[CheckC... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Code Refactoring / Architectural Improvement"
} | |
ansible__ansible-22611@8d74625 | ansible/ansible | Python | 22,611 | win_scheduled_task: Added frequency: once and check_mode support | ##### SUMMARY
<!--- Describe the change, including rationale and design decisions -->
<!---
If you are fixing an existing issue, please include "Fixes #nnn" in your
commit message and your description; but you should still explain what
the change does.
-->
This patch includes:
- Renamed `execute:` parameter t... | 2017-03-14T15:04:44Z | win_scheduled_task
<!---
Verify first that your issue/request is not already reported on GitHub.
Also test if the latest release, and master branch are affected too.
-->
##### ISSUE TYPE
<!--- Pick one below and delete the rest: -->
- Bug Report
- Feature Idea
- Documentation Report
##### COMPONENT NAME... | cc @petemounce
[click here for bot help](https://github.com/ansible/ansibullbot/blob/master/ISSUE_HELP.md)
<!--- boilerplate: notify --->
I don't use scheduled tasks myself but would you be able to put the shutdown command you want to run inside a .ps1 or .bat file and then schedule running the .bat or .ps1 file instea... | [
{
"body": "<!---\r\nVerify first that your issue/request is not already reported on GitHub.\r\nAlso test if the latest release, and master branch are affected too.\r\n-->\r\n\r\n##### ISSUE TYPE\r\n<!--- Pick one below and delete the rest: -->\r\n - Bug Report\r\n - Feature Idea\r\n - Documentation Report\r\n\r... | 9755d2dbbcecf016dff1329e57b60ef502386b3d | {
"head_commit": "8d74625d44876defa96458cac9737f0079d6a901",
"head_commit_message": "Improve the integration test structure\n\nI think this is a great way to test normal mode and check-mode from the same playbook.",
"patch_to_review": "diff --git a/lib/ansible/modules/windows/win_scheduled_task.ps1 b/lib/ansible/... | [
{
"diff_hunk": "@@ -96,69 +85,77 @@ try {\n Fail-Json $result \"$($measure.count) scheduled tasks found\"\n }\n \n- Set-Attr $result \"exists\" \"$exists\"\n+ $result.exists = $exists\n \n if ($frequency){\n- if ($frequency -eq \"daily\") {\n- $trigger = New-ScheduledTas... | c3f2f4e574712bcc1fedafea6e017168046a1851 | diff --git a/lib/ansible/modules/windows/win_scheduled_task.ps1 b/lib/ansible/modules/windows/win_scheduled_task.ps1
index 8804028345f8df..d949561492254c 100644
--- a/lib/ansible/modules/windows/win_scheduled_task.ps1
+++ b/lib/ansible/modules/windows/win_scheduled_task.ps1
@@ -22,47 +22,35 @@ $ErrorActionPreference = ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-21500@73eb575 | ansible/ansible | Python | 21,500 | adding 'version_added' field for environment_variables option in lambda.py | ##### ISSUE TYPE
- Docs Pull Request
##### COMPONENT NAME
lib/ansible/modules/cloud/amazon/lambda.py
##### ANSIBLE VERSION
```
ansible 2.3.0 (lambda-env-var-version-added 73eb575753) last updated 2017/02/15 17:35:53 (GMT -400)
config file =
configured module search path = Default w/o overrides
```
... | 2017-02-15T22:39:27Z | Lambda: unsupported parameter for module: environment_variable
<!---
Verify first that your issue/request is not already reported on GitHub.
Also test if the latest release, and master branch are affected too.
-->
##### ISSUE TYPE
<!--- Pick one below and delete the rest: -->
- Documentation Bug Report
####... | It looks like the environment_variables parameter was added in 2.3 (we're about to enter feature freeze for 2.3). I'll change this to a documentation bug to make sure that's noted in the module docs. | [
{
"body": "<!---\r\nVerify first that your issue/request is not already reported on GitHub.\r\nAlso test if the latest release, and master branch are affected too.\r\n-->\r\n\r\n##### ISSUE TYPE\r\n<!--- Pick one below and delete the rest: -->\r\n - Documentation Bug Report\r\n\r\n##### COMPONENT NAME\r\n<!--- ... | 9baf95bcc43dae04e6d92ed70e53f45767c564a6 | {
"head_commit": "73eb57575334fd40a96903a170cfa915e8a89b31",
"head_commit_message": "Adding 'version_added' field for environment_variables option",
"patch_to_review": "diff --git a/lib/ansible/modules/cloud/amazon/lambda.py b/lib/ansible/modules/cloud/amazon/lambda.py\nindex d42999e009470d..729e2de8ec2d6b 100644... | [
{
"diff_hunk": "@@ -102,6 +102,7 @@\n required: false\n default: None\n aliases: [ 'environment' ]\n+ version_added: 2.3",
"line": null,
"original_line": null,
"original_start_line": null,
"path": "lib/ansible/modules/cloud/amazon/lambda.py",
"start_line": null,
"text": "@... | 68264d2174bbbab7464fde0fe0d8f6330efa2825 | diff --git a/lib/ansible/modules/cloud/amazon/lambda.py b/lib/ansible/modules/cloud/amazon/lambda.py
index d42999e009470d..c1d94bfaef7a61 100644
--- a/lib/ansible/modules/cloud/amazon/lambda.py
+++ b/lib/ansible/modules/cloud/amazon/lambda.py
@@ -102,6 +102,7 @@
required: false
default: None
aliases: [ '... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-21320@0552de1 | ansible/ansible | Python | 21,320 | Ensure that s3_bucket versioning is correctly enabled | ##### ISSUE TYPE
- Bugfix Pull Request
##### COMPONENT NAME
s3_bucket
##### ANSIBLE VERSION
```
ansible 2.3.0 (devel a6cb377420) last updated 2017/02/13 10:23:20 (GMT +1000)
config file = /etc/ansible/ansible.cfg
configured module search path = Default w/o overrides
```
##### SUMMARY
If versioning... | 2017-02-13T00:42:26Z | Module s3_bucket do not enable versioning
##### ISSUE TYPE
- Bug Report
##### COMPONENT NAME
Module s3_bucket
##### ANSIBLE VERSION
```
ansible 2.2.0.0
config file =
configured module search path = Default w/o overrides
```
##### CONFIGURATION
None
##### OS / ENVIRONMENT
Ubuntu 16.04 LTS
... | cc @wimnat
[click here for bot help](https://github.com/ansible/ansibullbot/blob/master/ISSUE_HELP.md)
<!--- boilerplate: notify --->
+1 affected by this bug | [
{
"body": "##### ISSUE TYPE\r\n - Bug Report\r\n\r\n##### COMPONENT NAME\r\nModule s3_bucket\r\n\r\n##### ANSIBLE VERSION\r\n```\r\nansible 2.2.0.0\r\n config file = \r\n configured module search path = Default w/o overrides\r\n\r\n```\r\n\r\n##### CONFIGURATION\r\nNone\r\n\r\n##### OS / ENVIRONMENT\r\nUbuntu... | a6cb3774207104d8817effe7b96b5f5f4a07358e | {
"head_commit": "0552de12d61d3e3960df479db7f8a1dbd6900b50",
"head_commit_message": "Ensure that s3_bucket versioning is correctly enabled\n\nIf versioning is not enabled, then `get_bucket_versioning`\ncan return an empty dict.\n\nIf that happens, the code to enable versioning should still\nrun!\n\nThe logic for su... | [
{
"diff_hunk": "@@ -168,22 +168,21 @@ def _create_or_update_bucket(connection, module, location):\n \n # Versioning\n versioning_status = bucket.get_versioning_status()\n- if versioning_status:\n- if versioning is not None:\n- if versioning and versioning_status['Versioning'] != \"E... | 0307b0d1900da913443d3ffc3788af56c6b6c22a | diff --git a/lib/ansible/modules/cloud/amazon/s3_bucket.py b/lib/ansible/modules/cloud/amazon/s3_bucket.py
index ae6811a9566038..2c375c9bd1bdff 100755
--- a/lib/ansible/modules/cloud/amazon/s3_bucket.py
+++ b/lib/ansible/modules/cloud/amazon/s3_bucket.py
@@ -49,11 +49,13 @@
aliases: [ S3_URL ]
ceph:
descri... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-20646@f695114 | ansible/ansible | Python | 20,646 | Modifying how optional parameters are handled in rds.py. Fixes #20370 | Allowing options to be set to false/no. Previously ignored unless set to true/yes.
Added a conditional for invalid parameters since the default is false instead of null for some options (e.g. force_failover, apply_immediately, upgrade).
##### ISSUE TYPE
- Bugfix Pull Request
##### COMPONENT NAME
lib/ansible... | 2017-01-25T16:20:35Z | RDS module fails to modify instance multi_az from 'yes' to 'no'
<!---
Verify first that your issue/request is not already reported on GitHub.
Also test if the latest release, and master branch are affected too.
-->
##### ISSUE TYPE
<!--- Pick one below and delete the rest: -->
- Bug Report
##### COMPONENT N... | cc @bpennypacker @willthames
[click here for bot help](https://github.com/ansible/ansibullbot/blob/master/ISSUE_HELP.md)
<!--- boilerplate: notify ---> | [
{
"body": "<!---\r\nVerify first that your issue/request is not already reported on GitHub.\r\nAlso test if the latest release, and master branch are affected too.\r\n-->\r\n\r\n##### ISSUE TYPE\r\n<!--- Pick one below and delete the rest: -->\r\n - Bug Report\r\n\r\n##### COMPONENT NAME\r\nrds\r\nansible/lib/a... | 28e39ca42f30373c0500282e77c622c45fa1f783 | {
"head_commit": "f695114736f7f7e4e00138b08806d1d2a232fd23",
"head_commit_message": "Modifying how optional parameters are handled in rds.py. Fixes #20370\n\nAllowing options to be set to false/no. Previously ignored unless set to true/yes.\n\nAdded a conditional for invalid parameters since the default is false in... | [
{
"diff_hunk": "@@ -1001,11 +1001,14 @@ def validate_parameters(required_vars, valid_vars, module):\n \n params = {}\n for (k, v) in optional_params.items():\n- if module.params.get(k) and k not in required_vars:\n+ if module.params.get(k) in [True, False] and k not in required_vars:",
... | cf48e5863135d954421c089050a35fbb0f644043 | diff --git a/lib/ansible/modules/cloud/amazon/rds.py b/lib/ansible/modules/cloud/amazon/rds.py
index d12593f3201d3a..60fe3cae455862 100644
--- a/lib/ansible/modules/cloud/amazon/rds.py
+++ b/lib/ansible/modules/cloud/amazon/rds.py
@@ -1001,11 +1001,14 @@ def validate_parameters(required_vars, valid_vars, module):
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
bridgecrewio__checkov-2750@34a7aee | bridgecrewio/checkov | Python | 2,750 | Ensure security group has stateless ingress security rules | By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
resolved #1972
added check to ensure OCI Network Security Groups (NSG) has stateless security rules | 2022-04-03T12:16:14Z | Add OCI TF check - OCI Network Security Groups (NSG) has stateful security rules
Equivalent RQL query
config from cloud.resource where cloud.type = 'oci' AND api.name = 'oci-networking-nsg' AND json.rule = securityRules[?any( direction equals INGRESS and (isStateless does not exist or isStateless is false) )] exists | Note that RQL queries are spotting the error while “Checkov logic wish to find the Desired state” use the referance below in order to get more data for the check needed -
_This policy identifies the OCI Network Security Groups (NSG) security rules that have stateful ingress rules configured. It is recommended that N... | [
{
"body": "Equivalent RQL query\r\n\r\nconfig from cloud.resource where cloud.type = 'oci' AND api.name = 'oci-networking-nsg' AND json.rule = securityRules[?any( direction equals INGRESS and (isStateless does not exist or isStateless is false) )] exists",
"number": 1972,
"title": "Add OCI TF check - OC... | f05dab67f59e7aacce039ca5dfe32ab78f7eb8a6 | {
"head_commit": "34a7aee9f225a8a41bafac35559f1339df2b85b5",
"head_commit_message": "Update test_SecurityGroupsIngressStatelessSecurityRules.py",
"patch_to_review": "diff --git a/checkov/terraform/checks/resource/oci/SecurityGroupsIngressStatelessSecurityRules.py b/checkov/terraform/checks/resource/oci/SecurityGr... | [
{
"diff_hunk": "@@ -0,0 +1,23 @@\n+from checkov.common.models.enums import CheckCategories, CheckResult\n+from checkov.terraform.checks.resource.base_resource_check import BaseResourceCheck\n+\n+\n+class SecurityGroupsIngressStatelessSecurityRules(BaseResourceCheck):\n+ def __init__(self):\n+ name = \... | 52babcac7b2d19dc432490588b0cb29e7243a120 | diff --git a/checkov/terraform/checks/resource/oci/SecurityGroupsIngressStatelessSecurityRules.py b/checkov/terraform/checks/resource/oci/SecurityGroupsIngressStatelessSecurityRules.py
new file mode 100644
index 0000000000..8c85cdfd35
--- /dev/null
+++ b/checkov/terraform/checks/resource/oci/SecurityGroupsIngressStatel... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
bridgecrewio__checkov-2749@4c8839e | bridgecrewio/checkov | Python | 2,749 | Ensure no security groups rules allow ingress from 0.0.0.0:0 to port … | By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
resolved #1973
OCI security group doesn't allow unrestricted ingress access to port 22 | 2022-04-03T12:10:41Z | Add OCI TF check - OCI security group allows unrestricted ingress access to port 22
Equivalent RQL query
config from cloud.resource where cloud.type = 'oci' AND api.name = 'oci-networking-nsg' AND json.rule = (securityRules[?any((((*.destinationPortRange.min == 22 or *.destinationPortRange.max == 22) or (*.destinatio... | Note that RQL queries are spotting the error while “Checkov logic wish to find the Desired state” use the referance below in order to get more data for the check needed -
_Note that RQL queries are spotting the error while “Checkov logic wish to find the Desired state” use the referance below in order to get more da... | [
{
"body": "Equivalent RQL query \r\nconfig from cloud.resource where cloud.type = 'oci' AND api.name = 'oci-networking-nsg' AND json.rule = (securityRules[?any((((*.destinationPortRange.min == 22 or *.destinationPortRange.max == 22) or (*.destinationPortRange.min < 22 and *.destinationPortRange.max > 22)) or (p... | f05dab67f59e7aacce039ca5dfe32ab78f7eb8a6 | {
"head_commit": "4c8839e8451f6c7f8e678fcca7158f42bcbb35a8",
"head_commit_message": "Update checkov/terraform/checks/resource/oci/AbsSecurityGroupUnrestrictedIngress.py\n\nCo-authored-by: Anton Grübel <anton.gruebel@gmail.com>",
"patch_to_review": "diff --git a/checkov/terraform/checks/resource/oci/AbsSecurityGro... | [
{
"diff_hunk": "@@ -0,0 +1,33 @@\n+from checkov.common.models.enums import CheckResult, CheckCategories\n+from checkov.terraform.checks.resource.base_resource_check import BaseResourceCheck\n+\n+\n+class AbsSecurityGroupUnrestrictedIngress(BaseResourceCheck):\n+ def __init__(self, check_id: str, port: int) -... | b6a3a73bdd8ba902bf6d77ad3c47e3f8acd38e17 | diff --git a/checkov/terraform/checks/resource/oci/AbsSecurityGroupUnrestrictedIngress.py b/checkov/terraform/checks/resource/oci/AbsSecurityGroupUnrestrictedIngress.py
new file mode 100644
index 0000000000..4c0e99c309
--- /dev/null
+++ b/checkov/terraform/checks/resource/oci/AbsSecurityGroupUnrestrictedIngress.py
@@ -... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
bridgecrewio__checkov-2710@76a8ad5 | bridgecrewio/checkov | Python | 2,710 | [OCI TF] administrator users are associated with api key | By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
resolves #1976
Added an OCI terraform check that will enforce that administrator users will be associated with an API key.
* I do need an ID to assign to this check | 2022-03-29T15:15:57Z | Add OCI TF check - OCI tenancy administrator users are associated with API keys
Equivalent RQL query
config from cloud.resource where cloud.type = 'oci' AND api.name = 'oci-iam-group' as X; config from cloud.resource where api.name = 'oci-iam-user' as Y; filter '($.X.name equals Administrators) and ($.X.groupMembers... | [
{
"body": "Equivalent RQL query\r\n\r\nconfig from cloud.resource where cloud.type = 'oci' AND api.name = 'oci-iam-group' as X; config from cloud.resource where api.name = 'oci-iam-user' as Y; filter '($.X.name equals Administrators) and ($.X.groupMembers[*].userId contains $.Y.id) and ($.Y.apiKeys[*] size grea... | 89f1c0a331dd3edacc45ac4e9c19944f2f67ae16 | {
"head_commit": "76a8ad5641c79ef481b7838233682f0287afff56",
"head_commit_message": "modify test case tldr",
"patch_to_review": "diff --git a/checkov/terraform/checks/graph_checks/oci/AdministratorUserAssociatedWithAPIKey.yaml b/checkov/terraform/checks/graph_checks/oci/AdministratorUserAssociatedWithAPIKey.yaml\... | [
{
"diff_hunk": "@@ -0,0 +1,65 @@\n+metadata:\n+ id: \"PLACEHOLDER\"",
"line": null,
"original_line": 2,
"original_start_line": null,
"path": "checkov/terraform/checks/graph_checks/oci/AdministratorUserAssociatedWithAPIKey.yaml",
"start_line": null,
"text": "@user2:\n@user1-Turgeman does... | 8442c6bc1260e1fdfbddf995099d6cdc416cb8c2 | diff --git a/checkov/terraform/checks/graph_checks/oci/AdministratorUserNotAssociatedWithAPIKey.yaml b/checkov/terraform/checks/graph_checks/oci/AdministratorUserNotAssociatedWithAPIKey.yaml
new file mode 100644
index 0000000000..35f23f99bd
--- /dev/null
+++ b/checkov/terraform/checks/graph_checks/oci/AdministratorUser... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
ansible__ansible-18288@6c2b6a2 | ansible/ansible | Python | 18,288 | aix network facts: Separate out the uname call to reduce total calls | ##### ISSUE TYPE
- Bugfix Pull Request
##### COMPONENT NAME
facts.py module util
##### ANSIBLE VERSION
<!--- Paste verbatim output from “ansible --version” between quotes below -->
```
2.3
```
##### SUMMARY
Fixes #11289
| 2016-11-01T19:26:32Z | AIX WPAR handling is inefficient and possibly buggy
The `lib/ansible/module_utils/facts.py:AIXNetwork.get_interfaces_info` method is structured like:
```
rc, out, err = module.run_command([ifconfig_path, '-a'])
for line in out.split('\n'):
...
uname_path = module.get_bin_path('uname')
if uname_path:
... | The code in devel (2.3) still has this inefficient behavior. I'm guessing it was just a mistaken indentation? https://github.com/ansible/ansible/pull/11290 was never merged and I suspect will never get rebased.
I don't have access to a machine to test this against anymore. | [
{
"body": "The `lib/ansible/module_utils/facts.py:AIXNetwork.get_interfaces_info` method is structured like:\n\n```\nrc, out, err = module.run_command([ifconfig_path, '-a'])\nfor line in out.split('\\n'):\n ...\n uname_path = module.get_bin_path('uname')\n if uname_path:\n rc, out, err = module.... | 88970bcfb24864c5773c8d913c45db3e7355a74d | {
"head_commit": "6c2b6a2b93e8e81e10fddbff583c1c889d09cf67",
"head_commit_message": "aix network facts: Separate out the uname call to reduce total calls",
"patch_to_review": "diff --git a/lib/ansible/module_utils/facts.py b/lib/ansible/module_utils/facts.py\nindex 9c98f796f96ff5..3a98ca23d6f22c 100644\n--- a/lib... | [
{
"diff_hunk": "@@ -2866,12 +2874,12 @@ def get_interfaces_info(self, ifconfig_path, ifconfig_options='-a'):\n self.parse_inet6_line(words, current_if, ips)\n else:\n self.parse_unknown_line(words, current_if, ips)\n- uname_path = self.module.ge... | c91aad8c7feae0d125fd1005db3f0c9b5cb62c31 | diff --git a/lib/ansible/module_utils/facts.py b/lib/ansible/module_utils/facts.py
index 9c98f796f96ff5..f788ce8634fb52 100644
--- a/lib/ansible/module_utils/facts.py
+++ b/lib/ansible/module_utils/facts.py
@@ -2837,6 +2837,14 @@ def get_interfaces_info(self, ifconfig_path, ifconfig_options='-a'):
all_ipv4... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Performance Optimizations"
} |
bridgecrewio__checkov-2747@76051f5 | bridgecrewio/checkov | Python | 2,747 | removed code blocks in compact json output | By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
resolves #2713
| 2022-04-03T08:18:25Z | Add --compact behaviour to json output
**Describe the issue**
For the json output, it would be nice to have the possibility of using the '--compact' option as for the CLI.
As for the CLI, maybe we only want to know the "file_path" and the "file_line_range" without having the code itself.
The "code_block" in the ... | [
{
"body": "**Describe the issue**\r\n\r\nFor the json output, it would be nice to have the possibility of using the '--compact' option as for the CLI.\r\n\r\nAs for the CLI, maybe we only want to know the \"file_path\" and the \"file_line_range\" without having the code itself.\r\nThe \"code_block\" in the json... | f05dab67f59e7aacce039ca5dfe32ab78f7eb8a6 | {
"head_commit": "76051f5b26100b2e9088953deaf4708386a8320f",
"head_commit_message": "removed code blocks in compact json output",
"patch_to_review": "diff --git a/checkov/common/runners/runner_registry.py b/checkov/common/runners/runner_registry.py\nindex 429889e6c9..6884bfe6ed 100644\n--- a/checkov/common/runner... | [
{
"diff_hunk": "@@ -283,3 +285,13 @@ def get_enriched_resources(repo_roots: List[Union[str, os.PathLike]]) -> Dict[st\n \"skipped_checks\": skipped_checks,\n }\n return enriched_resources\n+\n+ @staticmethod\n+ def strip_code_blocks_from_... | e361343938ea8545cd9cec080b1c9004209e5ade | diff --git a/checkov/common/runners/runner_registry.py b/checkov/common/runners/runner_registry.py
index 429889e6c9..9195b45685 100644
--- a/checkov/common/runners/runner_registry.py
+++ b/checkov/common/runners/runner_registry.py
@@ -165,6 +165,8 @@ def print_reports(
if output_formats:
p... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
ansible__ansible-21529@32bf856 | ansible/ansible | Python | 21,529 | using Boto3 in s3.py | ##### ISSUE TYPE
- Feature Pull Request
##### COMPONENT NAME
lib/ansible/modules/cloud/amazon/s3.py
##### ANSIBLE VERSION
```
ansible 2.3.0 (boto3-s3 13631c256d) last updated 2017/02/16 13:36:21 (GMT -400)
config file =
configured module search path = Default w/o overrides
```
##### SUMMARY
Updati... | 2017-02-16T18:48:50Z | Ansible 2.3 - S3 module - Bucket not found
##### ISSUE TYPE
- Bug Report
##### COMPONENT NAME
- s3 module
##### ANSIBLE VERSION
```
ansible 2.3.0.0
config file = /home/jchampseix/provisionning-cloud/ansible.cfg
configured module search path = Default w/o overrides
python version = 2.7.10 (default, ... | I can download the file from S3 bucket.
Thanks for opening this issue @JulienChampseix. It looks like a [boto problem](https://github.com/boto/boto/issues/2741). This should be fixed by #21529 which will support Sigv4.
@s-hertel thanks for your feedback. I overwrote my modules/cloud/amazon/s3.py from https://raw.github... | [
{
"body": "##### ISSUE TYPE\r\n - Bug Report\r\n\r\n##### COMPONENT NAME\r\n - s3 module\r\n\r\n##### ANSIBLE VERSION\r\n```\r\nansible 2.3.0.0\r\n config file = /home/jchampseix/provisionning-cloud/ansible.cfg\r\n configured module search path = Default w/o overrides\r\n python version = 2.7.10 (default, Oc... | 2276c5f2060a46d556268b846e6ef30950d992cc | {
"head_commit": "32bf85639f8805bc2459db9088d97d403d1a5d0e",
"head_commit_message": "Wrap call to paginated_list in a try/except\n\nAlso remembered to allow marker/prefix/max_keys to modify what keys are listed",
"patch_to_review": "diff --git a/lib/ansible/modules/cloud/amazon/s3.py b/lib/ansible/modules/cloud/a... | [
{
"diff_hunk": "@@ -272,131 +240,150 @@\n import traceback\n from ansible.module_utils.six.moves.urllib.parse import urlparse\n from ssl import SSLError\n+from ansible.module_utils.basic import AnsibleModule, to_text, to_native\n+from ansible.module_utils.ec2 import ec2_argument_spec, camel_dict_to_snake_dict, ... | c69d003f63e57d5486edd45b32cc6feeafdc7e5d | diff --git a/lib/ansible/modules/cloud/amazon/s3.py b/lib/ansible/modules/cloud/amazon/s3.py
index 03006d8787329a..6979f613a54e98 100644
--- a/lib/ansible/modules/cloud/amazon/s3.py
+++ b/lib/ansible/modules/cloud/amazon/s3.py
@@ -24,128 +24,100 @@
module: s3
short_description: manage objects in S3.
description:
- ... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
bridgecrewio__checkov-2380@877790a | bridgecrewio/checkov | Python | 2,380 | CKV2_GCP_8 - GCP public key ring check | By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
This PR adds a graph .yaml check for public `GCP Cloud KMS Key Rings`. This code is modeled after the already existing check `CKV2_GCP_6` For Cloud KMS crypto keys.
Closes #2381 | 2022-02-09T17:01:11Z | CKV2_GCP_8 - GCP public key ring check
**Describe the issue**
This issue is to track the creation of a new GCP terraform checkov check for public Cloud KMS key rings. Public KMS key rings will set ALL keys inside the key ring to public.
**Examples**
```
# This configuration is fine because it is not public (user:... | [
{
"body": "**Describe the issue**\r\nThis issue is to track the creation of a new GCP terraform checkov check for public Cloud KMS key rings. Public KMS key rings will set ALL keys inside the key ring to public.\r\n\r\n**Examples**\r\n```\r\n# This configuration is fine because it is not public (user:jane@examp... | 078f1582cf3a87233585bd450b5ce6764fb3df48 | {
"head_commit": "877790a37b8e07e88571ff992fbc974cd8a6c37a",
"head_commit_message": "copy/paste fix",
"patch_to_review": "diff --git a/checkov/terraform/checks/graph_checks/gcp/GCPKMSKeyRingsAreNotPubliclyAccessible.yaml b/checkov/terraform/checks/graph_checks/gcp/GCPKMSKeyRingsAreNotPubliclyAccessible.yaml\nnew ... | [
{
"diff_hunk": "@@ -0,0 +1,64 @@\n+metadata:\n+ id: \"CKV2_GCP_8\"\n+ name: \"Ensure that Cloud KMS Key Rings are not anonymously or publicly accessible\"\n+ category: \"ENCRYPTION\"\n+definition:\n+ and:\n+ - cond_type: filter\n+ attribute: resource_type\n+ value:\n+ - google_kms_key_ri... | 3659e6ec538928f3d347f2b1d4c344ed4d9c1dbe | diff --git a/checkov/terraform/checks/graph_checks/gcp/GCPKMSKeyRingsAreNotPubliclyAccessible.yaml b/checkov/terraform/checks/graph_checks/gcp/GCPKMSKeyRingsAreNotPubliclyAccessible.yaml
new file mode 100644
index 0000000000..9dde63cc11
--- /dev/null
+++ b/checkov/terraform/checks/graph_checks/gcp/GCPKMSKeyRingsAreNotP... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
bridgecrewio__checkov-2216@180c738 | bridgecrewio/checkov | Python | 2,216 | support check suppression via CFN Metadata | By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Fixes #2194
Fixes #1931
Extended the graph to also store the CloudFormation `Metadata` and added the possibility to actually add the skip comment that section. Added an example to the docs. | 2022-01-16T17:25:46Z | Allow suppression to be done in Metadata properties of the AWS CloudFormation template and/or resources
Allow suppression to be done in Metadata properties of the template and/or resources
CKV_AWS_116: DLQ applies only to async invocations
**Describe the issue**
CKV_AWS_116: "Ensure that AWS Lambda function is config... | hi, actually the DLQ is for asynchronous Lambda invokes not synchronous. We already have an open issue talking about extending the check to allow different configuration via event invoke config #1795
Since we don't know, how a user will use the Lambda, we give recommendation what should be configured, but if it doesn'... | [
{
"body": "Allow suppression to be done in Metadata properties of the template and/or resources",
"number": 1931,
"title": "Allow suppression to be done in Metadata properties of the AWS CloudFormation template and/or resources"
},
{
"body": "**Describe the issue**\r\nCKV_AWS_116: \"Ensure that ... | f4f8caead6aa2f1824ae1cc88cd1816b12211629 | {
"head_commit": "180c7383045da97a497e9c13b11dc7186b4e8703",
"head_commit_message": "add CDK example",
"patch_to_review": "diff --git a/checkov/cloudformation/cfn_utils.py b/checkov/cloudformation/cfn_utils.py\nindex d976c6bb3d..e4ec933e55 100644\n--- a/checkov/cloudformation/cfn_utils.py\n+++ b/checkov/cloudform... | [
{
"diff_hunk": "@@ -130,6 +131,28 @@ def collect_skip_comments(entity_code_lines: List[Tuple[int, str]]) -> List[_Ski\n skipped_check[\"bc_id\"] = ckv_to_bc_id_mapping.get(skipped_check[\"id\"])\n \n skipped_checks.append(skipped_check)\n+ if resource_config:\n+ ... | cd9a43ac6853d5a16e6d9cab1b46881e359ef369 | diff --git a/checkov/cloudformation/cfn_utils.py b/checkov/cloudformation/cfn_utils.py
index d976c6bb3d..e4ec933e55 100644
--- a/checkov/cloudformation/cfn_utils.py
+++ b/checkov/cloudformation/cfn_utils.py
@@ -152,7 +152,10 @@ def build_definitions_context(
{"start_line": start_line, "end_... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
bridgecrewio__checkov-2665@9ef4733 | bridgecrewio/checkov | Python | 2,665 | add Bicep graph | By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Fixes #2632
- Changed `CKV_AZURE_23` to a graph check, didn't last long to be a Python check 😄
- the current Bicep Graph supports YAML checks and connections, but not, if they are inside an interp... | 2022-03-22T22:59:04Z | Bicep false CKV_AZURE_23
Hi,
I get CKV_AZURE_23 on this simple bicep file:
`
@description('SQL Logical server.')
param sqlLogicalServer object
@description('The SQL Logical Server password.')
@secure()
param password string
param tags object
var defaultAuditActionsAndGroups = [
'SUCCESSFUL_DATABASE_... | hi @acorbos thanks for creating this issue and I'm happy that you gave the Bicep runner a try. It is still in an early stage and I'm improving it step by step.
@gruebel thanks for looking into it, I couldn't find the code. Is it somehow converting to ARM and then using the ARM checks?
I'm asking because I wanted to sw... | [
{
"body": "Hi,\r\nI get CKV_AZURE_23 on this simple bicep file:\r\n\r\n`\r\n@description('SQL Logical server.')\r\nparam sqlLogicalServer object\r\n\r\n@description('The SQL Logical Server password.')\r\n@secure()\r\nparam password string\r\n\r\nparam tags object\r\n\r\nvar defaultAuditActionsAndGroups = [\r\n ... | b583cabcbb2df551924b97dddd34091a1cdd8d30 | {
"head_commit": "9ef473312ea20dac08d0210c187f93849588ae31",
"head_commit_message": "add Bicep graph",
"patch_to_review": "diff --git a/Pipfile b/Pipfile\nindex cba398da2a..9a8edeb9aa 100644\n--- a/Pipfile\n+++ b/Pipfile\n@@ -67,7 +67,7 @@ aiomultiprocess = \"*\"\n jsonpath_ng = \"*\"\n jsonschema = \"~=3.0\"\n p... | [
{
"diff_hunk": "@@ -1,57 +1,105 @@\n from __future__ import annotations\n \n-import re\n+import logging\n from pathlib import Path\n-from typing import cast\n+from typing import cast, Type, TYPE_CHECKING\n \n+from pycep.typing import BicepJson\n from typing_extensions import Literal\n \n from checkov.bicep.chec... | 226b6ebe96965fb5915700122b95033cf69c8559 | diff --git a/Pipfile b/Pipfile
index cba398da2a..9a8edeb9aa 100644
--- a/Pipfile
+++ b/Pipfile
@@ -67,7 +67,7 @@ aiomultiprocess = "*"
jsonpath_ng = "*"
jsonschema = "~=3.0"
prettytable = ">=3.0.0"
-pycep-parser = "==0.3.2"
+pycep-parser = "==0.3.3"
charset-normalizer = "*"
[requires]
diff --git a/Pipfile.lock b... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
bridgecrewio__checkov-2330@4a03068 | bridgecrewio/checkov | Python | 2,330 | Pass ECR Policy with conditional constraint | By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Fixes #1582
Issue 1582 - Allow an AWS ECR Policy to pass with a wildcarded Prinicipal if there is a Principal Org ID constraint conditional statement.
| 2022-02-03T03:39:47Z | BC_AWS_PUBLIC_1 does not take Conditions into account
**Describe the bug**
BC_AWS_PUBLIC_1 seems to only look for the principal in a ECR Resource Policy. If you want to control access to a repo based on the pricipals AWS Organization ID, you have to do this using a condition instead of a Principal. It seems like check... | [
{
"body": "**Describe the bug**\r\nBC_AWS_PUBLIC_1 seems to only look for the principal in a ECR Resource Policy. If you want to control access to a repo based on the pricipals AWS Organization ID, you have to do this using a condition instead of a Principal. It seems like checkov does not take this into accoun... | a048f996a34ebace32e819e409683d512d8e8071 | {
"head_commit": "4a030684be7f6b1878ae5bf3ade5e855661dcc6a",
"head_commit_message": "Pass ECR Policy with conditional constraint",
"patch_to_review": "diff --git a/checkov/cloudformation/checks/resource/aws/ECRPolicy.py b/checkov/cloudformation/checks/resource/aws/ECRPolicy.py\nindex 3b4e2f216e..bcaaa76ba8 100644... | [
{
"diff_hunk": "@@ -27,13 +27,25 @@ def scan_resource_conf(self, conf):\n statement = policy['Statement'][0]\n if statement['Principal'] and type(statement['Principal']) is str:\n principal = statement['Principal']\n- if principal == \"*\":\... | 1168de1afabf8525b74e1e7c62925c68693d2994 | diff --git a/checkov/cloudformation/checks/resource/aws/ECRPolicy.py b/checkov/cloudformation/checks/resource/aws/ECRPolicy.py
index 3b4e2f216e..600551ba6f 100644
--- a/checkov/cloudformation/checks/resource/aws/ECRPolicy.py
+++ b/checkov/cloudformation/checks/resource/aws/ECRPolicy.py
@@ -31,9 +31,22 @@ def scan_resou... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
bridgecrewio__checkov-1327@62fc52f | bridgecrewio/checkov | Python | 1,327 | Add --hard-fail-on and --soft-fail-on flags | By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
This PR adds 2 new flags:
- `--soft-fail-on`
- `--hard-fail-on`
Behavior:
- The flags give the user the ability to define a list of check-ids that would hard-fail or soft-fail the build.
- `--so... | 2021-06-24T23:39:41Z | Add --warn option similar to --check
There are many great checks that come with Checkov that allow me to block deployments of insecure, noncompliant resources. The problem is, there are many cases where I want devs to be AWARE of a potential security misconfig without entirely blocking their deployment. For example, I ... | [
{
"body": "There are many great checks that come with Checkov that allow me to block deployments of insecure, noncompliant resources. The problem is, there are many cases where I want devs to be AWARE of a potential security misconfig without entirely blocking their deployment. For example, I wouldn't want to b... | 71e11093407e88160ba8b912bd0032b9a1e422ff | {
"head_commit": "62fc52fe820c52026e0a95a990bff579ca6daeb0",
"head_commit_message": "Fix typos",
"patch_to_review": "diff --git a/checkov/common/output/report.py b/checkov/common/output/report.py\nindex 56879d3561..effd4f9e16 100644\n--- a/checkov/common/output/report.py\n+++ b/checkov/common/output/report.py\n@@... | [
{
"diff_hunk": "@@ -139,6 +139,11 @@ def run(banner=checkov_banner, argv=sys.argv[1:]):\n external_checks_dir = get_external_checks_dir(config)\n url = None\n created_baseline_path = None\n+\n+ if sum(arg is not None for arg in [config.soft_fail, config.soft_fail_on, config.hard_fail_on]) > 1:\n+... | 6ea5ba997c6f2438739b5d6245cff7ec6fb0283f | diff --git a/checkov/common/output/report.py b/checkov/common/output/report.py
index 56879d3561..863a38a8ee 100644
--- a/checkov/common/output/report.py
+++ b/checkov/common/output/report.py
@@ -1,6 +1,6 @@
import json
from collections import defaultdict
-from typing import List, Dict, Union, Any
+from typing import ... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
bridgecrewio__checkov-671@d665f72 | bridgecrewio/checkov | Python | 671 | Terraform parser & variable evaluation rework | ⚠️ This is a big change, please review carefully. Some development and testing is still ongoing, so it is currently a draft PR. All feedback is welcome! ⚠️
This PR is an overhaul of the parsing and evaluation logic for Terraform. It brings number of new abilities and improvements:
- `.tfvars` support (`terraform... | 2020-11-12T23:29:43Z | Support for .tfvars
We use .tfvars files to assign values to variables. Currently it looks like there is no support for files with a .tfvars extension. This is a great tool and adding this support would greatly benefit The terraform community. | Thank you @ymohamme for reporting this one. We are working on it. We do see it as part of a larger task that will enable deep-assignment of variables. We have estimated in a few weeks of work and @rotemavni is working hard on this one.
@schosterbarak - I have an implementation (outside checkov) that I can contribute a... | [
{
"body": "We use .tfvars files to assign values to variables. Currently it looks like there is no support for files with a .tfvars extension. This is a great tool and adding this support would greatly benefit The terraform community. ",
"number": 386,
"title": "Support for .tfvars"
}
] | 80d1bf3605f431d1af5365847a0c037567299b7f | {
"head_commit": "d665f7214b0078f1bb219fe9b2ed000ea0df9745",
"head_commit_message": "Test case to ensure quote in quote syntax doesn't explode\n\nFixes: #446",
"patch_to_review": "diff --git a/HomebrewFormula/checkov.rb b/HomebrewFormula/checkov.rb\nindex 90aae7617a..57d4bebc14 100644\n--- a/HomebrewFormula/check... | [
{
"diff_hunk": "@@ -0,0 +1,695 @@\n+import json\n+import logging\n+import os\n+import re\n+from pathlib import Path\n+from typing import Mapping, Optional, Dict, Any, List, Callable, Tuple\n+\n+import deep_merge\n+import hcl2\n+import jmespath\n+\n+from checkov.common.runners.base_runner import filter_ignored_d... | ac46c9e544b8708f0f877d370c0609a34a2426e7 | diff --git a/HomebrewFormula/checkov.rb b/HomebrewFormula/checkov.rb
index 90aae7617a..57d4bebc14 100644
--- a/HomebrewFormula/checkov.rb
+++ b/HomebrewFormula/checkov.rb
@@ -38,6 +38,11 @@ class Checkov < Formula
sha256 "e96da0d330793e2cb9485e9ddfd918d456036c7149416295932478192f4436a1"
end
+ resource "deep_... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
bridgecrewio__checkov-925@5719009 | bridgecrewio/checkov | Python | 925 | Correct regex determining if a value if var dependant. | Fixes: #924
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
| 2021-02-26T00:01:20Z | BaseResourceValueCheck._is_variable_dependant incorrect
**Describe the bug**
BaseResourceValueCheck is supposed to ignore values that have unresolved data, but its pattern matching isn't looking for the correct thing, so it doesn't work. For example, these values won't cause the check to be skipped: `${var.whatever}`,... | [
{
"body": "**Describe the bug**\r\nBaseResourceValueCheck is supposed to ignore values that have unresolved data, but its pattern matching isn't looking for the correct thing, so it doesn't work. For example, these values won't cause the check to be skipped: `${var.whatever}`, `something-${local.whatever}`.\r\n... | c3303a1140d50e5c834d9abbf6ef3ce6f1338c41 | {
"head_commit": "5719009895b91a2974fae354a05115f5ed351f1a",
"head_commit_message": "Correct regex determining if a value if var dependant.\n\nFixes: #924",
"patch_to_review": "diff --git a/checkov/terraform/checks/resource/base_resource_value_check.py b/checkov/terraform/checks/resource/base_resource_value_check... | [
{
"diff_hunk": "@@ -6,7 +6,7 @@\n from checkov.common.models.consts import ANY_VALUE\n from checkov.common.util.type_forcers import force_list\n \n-VARIABLE_DEPENDANT_REGEX = r'(?:local|var)\\.[^\\s]+'\n+VARIABLE_DEPENDANT_REGEX = re.compile(r'\\${([^{}]+?)}')",
"line": null,
"original_line": 9,
"or... | 2dc35bf58c97b87e02a557a6ee02154ce536f0ff | diff --git a/checkov/terraform/checks/resource/base_resource_value_check.py b/checkov/terraform/checks/resource/base_resource_value_check.py
index d312b4e1ac..755c32d153 100644
--- a/checkov/terraform/checks/resource/base_resource_value_check.py
+++ b/checkov/terraform/checks/resource/base_resource_value_check.py
@@ -5... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
bridgecrewio__checkov-648@4850d00 | bridgecrewio/checkov | Python | 648 | Exclude NLBs from CKV_AWS_2 HTTPS check | By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Closes #424
CloudFormation config may need to be verified too - I haven't worked with it before (I'm more of a TF dude).
I wanted to add protocols to exclude from the check, as opposed to only ch... | 2020-11-03T13:37:52Z | Cloudformation NLB Listener Rules are incorrectly detected as ALB rules and fail the HTTPS expectation
**Describe the bug**
NLB listeners are evaluated as ALB listeners, and fail because they don't use HTTPS
**To Reproduce**
1. Create a Cloudformation template with NLB listeners (e.g. TCP)
2. Run default tests
3... | Hi @luckymike !
Please note the configuration does not distinguish NLBs and ALBs. If this is not a duplicate of #375 and I believe the reasoning is the same. Let me know your thoughts there, and feel free to reopen #375 if you disagree!
@nimrodkor I guess the confusion here is that the rule inaccurately identifies the... | [
{
"body": "**Describe the bug**\r\nNLB listeners are evaluated as ALB listeners, and fail because they don't use HTTPS\r\n\r\n**To Reproduce**\r\n1. Create a Cloudformation template with NLB listeners (e.g. TCP)\r\n2. Run default tests\r\n3. Tests will fail with `\"AWS::ElasticLoadBalancingV2::Listener.<listene... | 51fb076c5dee8f96201961a6f6780b34a5a983cc | {
"head_commit": "4850d0088642e56d4234e96f62a2bf4430bd12dd",
"head_commit_message": "Exclude NLBs from CKV_AWS_2 HTTPS check",
"patch_to_review": "diff --git a/checkov/cloudformation/checks/resource/aws/ALBListenerHTTPS.py b/checkov/cloudformation/checks/resource/aws/ALBListenerHTTPS.py\nindex a26144506c..1034c9c... | [
{
"diff_hunk": "@@ -23,6 +23,12 @@ def scan_resource_conf(self, conf):\n conf[key] == [\"HTTPS\"]\n or\n conf[key] == [\"TLS\"]\n+ or\n+ conf[key] == [\"TCP\"]\n+ or\n+ conf[key] == [\"UDP\"]\n+ ... | 0d8d79ea75f8450cbc2b67846311d6240cbda845 | diff --git a/checkov/cloudformation/checks/resource/aws/ALBListenerHTTPS.py b/checkov/cloudformation/checks/resource/aws/ALBListenerHTTPS.py
index a26144506c..1034c9cfe4 100644
--- a/checkov/cloudformation/checks/resource/aws/ALBListenerHTTPS.py
+++ b/checkov/cloudformation/checks/resource/aws/ALBListenerHTTPS.py
@@ -2... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
bridgecrewio__checkov-489@553f865 | bridgecrewio/checkov | Python | 489 | Fix NSGRulePortAccessRestricted crashing on a terraform dynamic block | Fixes #488
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
| 2020-08-08T15:31:10Z | Checkov crashes when evaluating a Terraform dynamic block in NSGRulePortAccessRestricted.py
**Describe the bug**
When checking azure_security_group_rule, azurerm_network_security_rule or azurerm_network_security_group Terraform resource types, NSGRulePortAccessRestricted.py throws a "TypeError: string indices must be ... | [
{
"body": "**Describe the bug**\r\nWhen checking azure_security_group_rule, azurerm_network_security_rule or azurerm_network_security_group Terraform resource types, NSGRulePortAccessRestricted.py throws a \"TypeError: string indices must be integers\" error whenever there's a dynamic block.\r\n\r\n**To Reprodu... | eb64c8e8a7e247fac791b536daa0dc5117bff969 | {
"head_commit": "553f8651594d1bfed084d017760bfc582664fb90",
"head_commit_message": "One more try...\n\nLooking at the rest of the code, seems CheckResult.UNKNOWN is probably more suitable.",
"patch_to_review": "diff --git a/checkov/terraform/checks/resource/azure/NSGRulePortAccessRestricted.py b/checkov/terrafor... | [
{
"diff_hunk": "@@ -26,6 +26,9 @@ def is_port_in_range(self, conf):\n return False\n \n def scan_resource_conf(self, conf):\n+ if any(\"dynamic\" in s for s in conf):",
"line": null,
"original_line": 29,
"original_start_line": null,
"path": "checkov/terraform/checks/resource/a... | 9b0444970276e4b18736c3ea7703a47bfc22834c | diff --git a/checkov/terraform/checks/resource/azure/NSGRulePortAccessRestricted.py b/checkov/terraform/checks/resource/azure/NSGRulePortAccessRestricted.py
index 6b09a00414..2b15f79fd8 100644
--- a/checkov/terraform/checks/resource/azure/NSGRulePortAccessRestricted.py
+++ b/checkov/terraform/checks/resource/azure/NSGR... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} | |
apache__airflow-47790@b44b67e | apache/airflow | Python | 47,790 | Adds validation on backfill dryrun | Adds some date checks before triggering backfill dryrun
Fixes: #47698
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
... | 2025-03-14T15:13:54Z | AIP-38 Add validation to Run Backfill modal
### Body
On the Run Backfill modal. We should add a few more checks before allowiing a user to submit.
- Max Active Runs: Form should have a min of 1 and a max of dag.max_active_runs. We should default the user to 1
- Date range from and to should both be valid dates
- One ... | @bbovenzi currently we only show backfill count from dry run. It would be good if we can show dates as well.
@vatsrahul1001 we already have the date being selected in the form? So is there a need to re-display the same value?
I'm also confused. @vatsrahul1001 could you explain more?
@bbovenzi currently from dry_run en... | [
{
"body": "### Body\n\nOn the Run Backfill modal. We should add a few more checks before allowiing a user to submit.\n\n- Max Active Runs: Form should have a min of 1 and a max of dag.max_active_runs. We should default the user to 1\n- Date range from and to should both be valid dates\n- One reprocessor behavio... | fce966e440122bd8389b7a56d8b8e29c5a7a1f27 | {
"head_commit": "b44b67e1955302aad62f40ab8fbacab1296e80f6",
"head_commit_message": "Review comments handled",
"patch_to_review": "diff --git a/airflow/ui/src/components/DagActions/RunBackfillForm.tsx b/airflow/ui/src/components/DagActions/RunBackfillForm.tsx\nindex a5da47640d5a0..c696efcf1e9a1 100644\n--- a/airf... | [
{
"diff_hunk": "@@ -50,7 +50,7 @@ export const useCreateBackfill = ({ onSuccessConfirm }: { onSuccessConfirm: () =\n const dataIntervalEnd = new Date(data.requestBody.to_date);\n const dagId = data.requestBody.dag_id;\n \n- if (!Boolean(dataIntervalStart) || !Boolean(dataIntervalEnd)) {\n+ if (isN... | 4198f4f6c8bce3e7f1e424340503671667e86da6 | diff --git a/airflow/ui/src/components/DagActions/RunBackfillForm.tsx b/airflow/ui/src/components/DagActions/RunBackfillForm.tsx
index 6acdbf25148c6..1bbacf6dcede2 100644
--- a/airflow/ui/src/components/DagActions/RunBackfillForm.tsx
+++ b/airflow/ui/src/components/DagActions/RunBackfillForm.tsx
@@ -45,11 +45,11 @@ con... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
apache__airflow-46627@44b6c66 | apache/airflow | Python | 46,627 | AIP-84 Add login endpoint to the public url | part 2 of: https://github.com/apache/airflow/issues/44884
closes: https://github.com/apache/airflow/issues/44884
After a 401, we call the `/login` endpoint that will retrieve the auth_manager login URL and redirect us to it.
Tested both with `SimpleAuthManager` and `FABAuthManager`
- [x] Need tests.
- [x] ... | 2025-02-10T16:10:44Z | AIP-38 JWT Flow
Implement the JWT flow in the front-end:
- [x] retrieve the JWT from the homepage URL after login (or any page actually)
- [x] persist it in the local storage
- [x] provide the Token in all requests
- [x] eventually clear on 401 expiration (no refresh flow implemented yet)
### Committer
- [X] I acknow... | Related : https://github.com/apache/airflow/pull/45765 | [
{
"body": "Implement the JWT flow in the front-end:\n- [x] retrieve the JWT from the homepage URL after login (or any page actually)\n- [x] persist it in the local storage\n- [x] provide the Token in all requests\n- [x] eventually clear on 401 expiration (no refresh flow implemented yet)\n\n### Committer\n\n- [... | c2efb867b93feba81bcf054e2cb4b21dffbdb7dc | {
"head_commit": "44b6c664697a1a7bf26e21da0fbc4443373d5f14",
"head_commit_message": "Add login endpoint to the public url",
"patch_to_review": "diff --git a/airflow/api_fastapi/app.py b/airflow/api_fastapi/app.py\nindex 4323fcd5017ca..bc04e15e355b5 100644\n--- a/airflow/api_fastapi/app.py\n+++ b/airflow/api_fasta... | [
{
"diff_hunk": "@@ -0,0 +1,36 @@\n+# Licensed to the Apache Software Foundation (ASF) under one\n+# or more contributor license agreements. See the NOTICE file\n+# distributed with this work for additional information\n+# regarding copyright ownership. The ASF licenses this file\n+# to you under the Apache Li... | f597db46c85338603ce28e93815afbf2f78361c9 | diff --git a/airflow/api_fastapi/app.py b/airflow/api_fastapi/app.py
index 4323fcd5017ca..bc04e15e355b5 100644
--- a/airflow/api_fastapi/app.py
+++ b/airflow/api_fastapi/app.py
@@ -133,6 +133,7 @@ def init_auth_manager(app: FastAPI | None = None) -> BaseAuthManager:
if app and (auth_manager_fastapi_app := am.get... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
apache__airflow-47212@4642d4f | apache/airflow | Python | 47,212 | [Helm Chart] Grant Airflow API Server Permission to Read Pod Logs | During KE testing with helm we noticed API Server was unable to fetch logs from Kubernetes pods due to missing RBAC permissions.
**Now:**
**Before**
![image](https://github.com/user-attachments/assets/af86c8e9-6938-493b-b... | 2025-02-28T13:35:58Z | Not able to view task logs with KE when deployed using helm chart
**Apache Airflow version**
3.0.0b1
**If "Other Airflow 2 version" selected, which one?**
No response
**What happened?**
**How to reproduce**
1. Create a deployment using breeze k8s
2. Try running dags
3. Check tasks logs
**Logs**
```
*** Attemp... | [
{
"body": "**Apache Airflow version**\n3.0.0b1\n\n**If \"Other Airflow 2 version\" selected, which one?**\nNo response\n\n**What happened?**\n\n\n**How to reproduce**\n\n1. Create a deployment using breeze k8s \n2. Try running dags\n3. Check tasks logs\n\n\n**Logs** \n```\n\n*** Attempting to fetch logs from po... | 10da1a02f30713e1a29a34f881334b25f498f017 | {
"head_commit": "4642d4f81c96e73e8b61401dcefd28fefccc3ec5",
"head_commit_message": "ensure apiserver have access to read pods logs",
"patch_to_review": "diff --git a/chart/templates/rbac/pod-log-reader-rolebinding.yaml b/chart/templates/rbac/pod-log-reader-rolebinding.yaml\nindex 33b030789c92a..9f715c1c2af71 100... | [
{
"diff_hunk": "@@ -60,6 +60,11 @@ subjects:\n name: {{ include \"webserver.serviceAccountName\" . }}\n namespace: \"{{ .Release.Namespace }}\"\n {{- end }}\n+ {{- if .Values.apiServer.allowPodLogReading }}",
"line": null,
"original_line": 63,
"original_start_line": null,
"path": "cha... | 4b7a9bebb8f56e0dffcc492368b03c3abe902a7c | diff --git a/chart/templates/rbac/pod-log-reader-rolebinding.yaml b/chart/templates/rbac/pod-log-reader-rolebinding.yaml
index 33b030789c92a..ba770b20c5b75 100644
--- a/chart/templates/rbac/pod-log-reader-rolebinding.yaml
+++ b/chart/templates/rbac/pod-log-reader-rolebinding.yaml
@@ -20,7 +20,7 @@
####################... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} | |
apache__airflow-46926@4ee8c9c | apache/airflow | Python | 46,926 | AIP-72: Port over executor_config for K8sExecutor when using task sdk | <!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may ... | 2025-02-20T10:59:45Z | Port over `executor_config` for K8sExecutor using task sdk
### Body
This issue tracks the task for K8sExecutor now that its ported to use task sdk
### Committer
- [x] I acknowledge that I am a maintainer/committer of the Apache Airflow project. | [
{
"body": "### Body\n\nThis issue tracks the task for K8sExecutor now that its ported to use task sdk\n\n### Committer\n\n- [x] I acknowledge that I am a maintainer/committer of the Apache Airflow project.",
"number": 46949,
"title": "Port over `executor_config` for K8sExecutor using task sdk"
}
] | a5bb34fa5607bbb7e66d5a80a58c0d015f1b4011 | {
"head_commit": "4ee8c9caec9627f220de97b135008d852640cd6d",
"head_commit_message": "Merge branch 'main' into AIP72-K8sExecutor-executor_config",
"patch_to_review": "diff --git a/airflow/example_dags/example_kubernetes_executor.py b/airflow/example_dags/example_kubernetes_executor.py\nindex 395398ee93c8f..27ffb4c... | [
{
"diff_hunk": "@@ -291,8 +291,7 @@ def _process_workloads(self, workloads: list[workloads.All]) -> None:\n key = w.ti.key # type: ignore[union-attr]\n queue = w.ti.queue # type: ignore[union-attr]\n \n- # TODO: will be handled by https://github.com/apache/airflow/issues/468... | 45a4cc08aba8049bbda2eace026dd03730780545 | diff --git a/airflow/example_dags/example_kubernetes_executor.py b/airflow/example_dags/example_kubernetes_executor.py
index 395398ee93c8f..27ffb4cdad6d7 100644
--- a/airflow/example_dags/example_kubernetes_executor.py
+++ b/airflow/example_dags/example_kubernetes_executor.py
@@ -149,18 +149,6 @@ def non_root_task():
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
apache__airflow-46501@010d23b | apache/airflow | Python | 46,501 | Add `lock` to `BaseDagBundle` and use it in `GitDagBundle` | `initialize` and `refresh` need to be safe to call from different threads/processes, so this adds a simple `lock` context manager that bundles can use if the underlying implementation doesn't allow for that.
For example, `GitDagBundle` is the first taker.
closes: #46444 | 2025-02-06T05:28:05Z | Add locking for bundle initialize on workers
### Body
Right now it's possible for more than one task to be trying to initialize a bundle at the same time, which can lead to git failing, for example.
We need to use lock files, like we are building for ttl, to also serialize this.
### Committer
- [x] I acknowledge th... | [
{
"body": "### Body\n\nRight now it's possible for more than one task to be trying to initialize a bundle at the same time, which can lead to git failing, for example.\n\nWe need to use lock files, like we are building for ttl, to also serialize this.\n\n### Committer\n\n- [x] I acknowledge that I am a maintain... | ea4b6c2ee755db4c3b7e0e1c48a768ab7d7aa977 | {
"head_commit": "010d23b216de4f4d484fa473e36dc43427f5b9f7",
"head_commit_message": "Add `lock` to `BaseDagBundle` and use it in `GitDagBundle`\n\n`initialize` and `refresh` need to be safe to call from different\nthreads/processes, so this adds a simple `lock` context manager that\nbundles can use if the underlyin... | [
{
"diff_hunk": "@@ -112,3 +125,22 @@ def view_url(self, version: str | None = None) -> str | None:\n :param version: Version to view\n :return: URL to view the bundle\n \"\"\"\n+\n+ @contextmanager\n+ def lock(self):\n+ if self._locked:\n+ yield\n+ retu... | 87b42a44e30c3c5ddf4e1c16ff6663a92d7cd31a | diff --git a/airflow/dag_processing/bundles/base.py b/airflow/dag_processing/bundles/base.py
index 81bf38d373677..3d86f398c73cb 100644
--- a/airflow/dag_processing/bundles/base.py
+++ b/airflow/dag_processing/bundles/base.py
@@ -17,8 +17,10 @@
from __future__ import annotations
+import fcntl
import tempfile
from... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
apache__airflow-46613@e84ab9e | apache/airflow | Python | 46,613 | AIP-72: Improving Operator Links Interface to Prevent User Code Execution in Webserver | <!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may ... | 2025-02-10T09:22:13Z | Get Operator Extra Links working again
Operator links do not work in Airflow 3.
- The plan is to change the interface in a way that webserver doesn't have to execute the user code: `get_link`
- We will push an xcom during task runtime to the XCOM backend. The key will be as defined in the operator link
- While reading... | >We will push an xcom during task runtime to the XCOM backend. The key will be as defined in the operator link
How is this going to work when user created several extra links for the same operator?
We will be adding "xcom_key" at the interface level for operator links. For example:
```
class DummyTestOperator(BaseOper... | [
{
"body": "Operator links do not work in Airflow 3.\n\n- The plan is to change the interface in a way that webserver doesn't have to execute the user code: `get_link`\n- We will push an xcom during task runtime to the XCOM backend. The key will be as defined in the operator link\n- While reading from the webser... | 8f05f99e0ed28293c6755c6eadca6eb66c14af46 | {
"head_commit": "e84ab9ec1a430a58b88b3afca355bc701f5674fc",
"head_commit_message": "harder review comments: moved the get_extra_links to serialisedBaseOperator, some refactoring, signature of GOL to BOL",
"patch_to_review": "diff --git a/airflow/models/abstractoperator.py b/airflow/models/abstractoperator.py\nin... | [
{
"diff_hunk": "@@ -1166,6 +1166,25 @@ def __init__(self, *args, **kwargs):\n self.template_fields = BaseOperator.template_fields\n self.operator_extra_links = BaseOperator.operator_extra_links\n \n+ def get_extra_links(self, ti: TaskInstance, link_name: str) -> str | None:\n+ \"\"\"\n... | 153c7e53b06b7e4e4a45bcd1aeb2f0687e073d2f | diff --git a/airflow/models/abstractoperator.py b/airflow/models/abstractoperator.py
index 98fd977c59128..e1d909faa87bd 100644
--- a/airflow/models/abstractoperator.py
+++ b/airflow/models/abstractoperator.py
@@ -18,15 +18,12 @@
from __future__ import annotations
import datetime
-import inspect
from collections.ab... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "Code Refactoring / Architectural Improvement"
} |
apache__airflow-42758@2f64e19 | apache/airflow | Python | 42,758 | Include Selective Check to Ping Maintainer about Legacy WWW and API Changes |
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you ma... | 2024-10-04T23:59:41Z | Fail the PR if it modifies old "ui"
In case PR contains changes to the "old" uI ("airflow/www") and the PR does not have the "legacy UI" label set by the maintainer, the PR should fail. This is in order to limit changes that are implemented in the old UI to only bugfixes and necessary changes to enable "new UI" in Airf... | Depends on a consensus in https://lists.apache.org/thread/db69p9fyt34d5tgo8pywpsp8ybjvflry
> Depends on a consensus in https://lists.apache.org/thread/db69p9fyt34d5tgo8pywpsp8ybjvflry
Yes depending on the outcome we might also want to add the `api_connexion` folder as we will also most likely migrate public endpoint... | [
{
"body": "In case PR contains changes to the \"old\" uI (\"airflow/www\") and the PR does not have the \"legacy UI\" label set by the maintainer, the PR should fail. This is in order to limit changes that are implemented in the old UI to only bugfixes and necessary changes to enable \"new UI\" in Airflow 3.0.\... | 5973c9cce1a51042298e198df2097a94fd48ac5d | {
"head_commit": "2f64e19f45a5a4bd4b2efb24fbdf9ba9a328c4ad",
"head_commit_message": "Include new check in selective_checks.py for checking PR labels to ping maintainers about updating legacy ui or legacy api code piece",
"patch_to_review": "diff --git a/dev/breeze/src/airflow_breeze/utils/selective_checks.py b/de... | [
{
"diff_hunk": "@@ -157,6 +160,10 @@ def __hash__(self):\n r\"^airflow/api_connexion/openapi/v1\\.yaml\",\n r\"^clients/gen\",\n ],\n+ FileGroupForCi.LEGACY_API_FILES: [\n+ r\"^airflow/api/\",",
"line": null,
"original_line": 164,
"original_start_lin... | 8558b5a2b432dc1131e499abf9fd3b899fbf0e4b | diff --git a/dev/breeze/src/airflow_breeze/utils/selective_checks.py b/dev/breeze/src/airflow_breeze/utils/selective_checks.py
index 3b3408d06cfc2..b5bea53d8b682 100644
--- a/dev/breeze/src/airflow_breeze/utils/selective_checks.py
+++ b/dev/breeze/src/airflow_breeze/utils/selective_checks.py
@@ -76,6 +76,8 @@
FULL_TES... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Test Suite / CI Enhancements"
} |
apache__airflow-46814@2d59263 | apache/airflow | Python | 46,814 | AIP-84 Adding logging actions | closes: https://github.com/apache/airflow/issues/44057
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more informati... | 2025-02-17T04:01:17Z | AIP-84 Log User Actions / Server Accesses
### Body
Similarly to the legacy API, the new FastAPI API should also Log user actions in the `Log` table.
Like the `action_logging` decorator or a Middleware to implement similar behavior.
### Committer
- [X] I acknowledge that I am a maintainer/committer of the ... | @pierrejeambrun I would like to work on this. Assigned myself cc: @pierrejeambrun | [
{
"body": "### Body\r\n\r\nSimilarly to the legacy API, the new FastAPI API should also Log user actions in the `Log` table.\r\n\r\n\r\nLike the `action_logging` decorator or a Middleware to implement similar behavior.\r\n\r\n### Committer\r\n\r\n- [X] I acknowledge that I am a maintainer/committer of the Apach... | a5bb34fa5607bbb7e66d5a80a58c0d015f1b4011 | {
"head_commit": "2d59263c5c859a5c0b972ee1ba4689294eb55fad",
"head_commit_message": "implement review comments",
"patch_to_review": "diff --git a/airflow/api_fastapi/core_api/routes/public/assets.py b/airflow/api_fastapi/core_api/routes/public/assets.py\nindex 335110282992c..50232d0dfde7c 100644\n--- a/airflow/ap... | [
{
"diff_hunk": "@@ -98,7 +100,15 @@ def _check_last_log(session, dag_id, event, logical_date, expected_extra=None):\n assert len(logs) >= 1\n assert logs[0].extra\n if expected_extra:\n+ print(f\"json.loads(logs[0].extra) is {json.loads(logs[0].extra)}\")\n+ print(f\"expected_extra is ... | 8d64a9e13edba48d99259d6cb915377f1fbe4390 | diff --git a/airflow/api_fastapi/core_api/routes/public/assets.py b/airflow/api_fastapi/core_api/routes/public/assets.py
index 335110282992c..50232d0dfde7c 100644
--- a/airflow/api_fastapi/core_api/routes/public/assets.py
+++ b/airflow/api_fastapi/core_api/routes/public/assets.py
@@ -232,6 +232,7 @@ def get_asset_event... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
apache__airflow-44383@08f4a67 | apache/airflow | Python | 44,383 | AIP84: Check standalone_dag_processor config in get_airflow_health() and update health endpoint | closes: https://github.com/apache/airflow/issues/44253
### Motivation
Right now the UI has to check the scheduler config for standalone_dag_processor in order to determine if the dag_processor health check should be rendered.
This PR does that check-in get_airflow_health() and also handles this inthe ` public/... | 2024-11-26T11:03:21Z | Check standalone_dag_processor config in get_airflow_health()
Right now the UI has to check the scheduler config for `standalone_dag_processor` in order to determin if the dag_processor health check should be rendered.
It would be better if we checked for `standalone_dag_processor` in the backend and simply not ret... | @bbovenzi would like to work on this. Can I assign it to myself?
@vatsrahul1001 all yours! | [
{
"body": "Right now the UI has to check the scheduler config for `standalone_dag_processor` in order to determin if the dag_processor health check should be rendered.\r\n\r\nIt would be better if we checked for `standalone_dag_processor` in the backend and simply not return a `dag_processor` object as part of... | b882246702ccb040243db803c08d2097d67283a5 | {
"head_commit": "08f4a678885049f8ebfecc560cff281f17754ca8",
"head_commit_message": "Merge branch 'AIP84-health-endpoint-skip-dag-processor' of github.com:astronomer/airflow into AIP84-health-endpoint-skip-dag-processor",
"patch_to_review": "diff --git a/airflow/api/common/airflow_health.py b/airflow/api/common/a... | [
{
"diff_hunk": "@@ -27,4 +27,4 @@\n @monitor_router.get(\"/health\")\n def get_health() -> HealthInfoSchema:\n airflow_health_status = get_airflow_health()\n- return HealthInfoSchema.model_validate(airflow_health_status)\n+ return HealthInfoSchema.model_validate(airflow_health_status, from_attributes=... | c1440627238455c2019c21a35047fc231ffa2879 | diff --git a/airflow/api/common/airflow_health.py b/airflow/api/common/airflow_health.py
index 5d37de540a498..043557fa0dbe3 100644
--- a/airflow/api/common/airflow_health.py
+++ b/airflow/api/common/airflow_health.py
@@ -18,6 +18,7 @@
from typing import Any
+from airflow.configuration import conf
from airflow.job... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Code Refactoring / Architectural Improvement"
} |
apache__airflow-42394@781fd86 | apache/airflow | Python | 42,394 | Add slack notification for canary build failures | closes: https://github.com/apache/airflow/issues/42203
this PR should send message to this slack channel https://apache-airflow.slack.com/archives/C07MWFASWJ1 if the CI is failed.
after verification on the main branch we need to change the alerts to be sent to the internal-ci-cd channel.
<img width="350" alt="... | 2024-09-21T10:40:03Z | Inform when "canary" build fails
When our "canary" build fails in main, we only see it failed in actions: ( "scheduled" run currently) and some PRs
We should have a way to notify the committers that main is faling and needs fixing (Slack?/ Devlist?) | [
{
"body": "When our \"canary\" build fails in main, we only see it failed in actions: ( \"scheduled\" run currently) and some PRs\n\nWe should have a way to notify the committers that main is faling and needs fixing (Slack?/ Devlist?)",
"number": 42203,
"title": "Inform when \"canary\" build fails"
}
... | b0234cbaf73bdf28640b77e2f1c378d5c489b26a | {
"head_commit": "781fd868f28e3b3d6bbf4ee24b26482f5f476083",
"head_commit_message": "fix static checks",
"patch_to_review": "diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml\nindex 14fe0bbe4baa9..eb63fdd0c76bf 100644\n--- a/.github/workflows/ci.yml\n+++ b/.github/workflows/ci.yml\n@@ -39,6 +39,7 @... | [
{
"diff_hunk": "@@ -669,3 +670,32 @@ jobs:\n include-success-outputs: ${{ needs.build-info.outputs.include-success-outputs }}\n docker-cache: ${{ needs.build-info.outputs.docker-cache }}\n canary-run: ${{ needs.build-info.outputs.canary-run }}\n+\n+ notify-slack-failure:\n+ name: \"Notify ... | cc8c15f68541eb51ce46dc11e6147a5afc3b8149 | diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 14fe0bbe4baa9..8625aee73d9e1 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -39,6 +39,7 @@ env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
GITHUB_USERNAME: ${{ github.actor }}
IMAGE_TAG: "${{ github.event.pull_reques... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Test Suite / CI Enhancements"
} | |
apache__airflow-40588@b939d36 | apache/airflow | Python | 40,588 | Add exit clause suggesting --clean-build if toctree contains nonexisting _api/* reference | <!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may ... | 2024-07-03T15:14:43Z | Handle toctree contains reference to nonexisting document `_api/` errors better when building docs
### Body
When building documentation (`breeze build-docs`) and you press ctrl-c in-between, the autoapi docs might remain empty and they cause
```
toctree contains reference to nonexisting document '_api/*` errors b... | @potiuk I would like to try this. Could you please assign this to me?
Feel free to work on this | [
{
"body": "### Body\n\nWhen building documentation (`breeze build-docs`) and you press ctrl-c in-between, the autoapi docs might remain empty and they cause\r\n\r\n```\r\ntoctree contains reference to nonexisting document '_api/*` errors better when building docs\r\n```\r\n\r\nCurrently the way to fix it is to ... | 3583329c1b53530c4c2e551e37affe78761ed3e5 | {
"head_commit": "b939d3622e8a09aa047e6ec93adae931960f2ec0",
"head_commit_message": "Adding a suggestion to use --clean-build if toctree contains reference to a nonexisting doc",
"patch_to_review": "diff --git a/docs/build_docs.py b/docs/build_docs.py\nindex 7520c247c6a52..47749f56607ca 100755\n--- a/docs/build_d... | [
{
"diff_hunk": "@@ -450,6 +450,14 @@ def main():\n for pkg in sorted(available_packages):\n console.print(f\" - {pkg}\")\n \n+ for package in available_packages:\n+ api_dir = os.path.join(DOCS_DIR, package, \"_api\")\n+ if os.path.exists(api_dir):\n+ console.print... | dca2e0c330a5aeed29874ff9a0f68154e263c634 | diff --git a/docs/build_docs.py b/docs/build_docs.py
index 7520c247c6a52..f856d6828e8ed 100755
--- a/docs/build_docs.py
+++ b/docs/build_docs.py
@@ -450,6 +450,15 @@ def main():
for pkg in sorted(available_packages):
console.print(f" - {pkg}")
+ for package in available_packages:
+ api... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Documentation Updates"
} |
apache__airflow-45790@ef543ba | apache/airflow | Python | 45,790 | Connect Trigger UI Conf with the flexible form | This PR is the continuation of [#45270](https://github.com/apache/airflow/pull/45270) by @jscheffl
Future Work (Not decided, might need discussion):
1. Introduce a reset button
2. Have a asterisk on the accordion item which contains a required field inside.
3. If we face error when Trigger button when clicked... | 2025-01-19T18:15:29Z | Streamline trigger dag UX
Problem:
Triggering a dag run is a relatively simple process conceptually yet a user is run through multiple different redirects and views. This results in a clunky experience that is slower, causes one to lose context and even end up on a page where they didn't even start on.
Solution:
... | I can work on this if this is still relevant
Assigned you @maxnathaniel. I think checking it should be the first thing to do and if you find it's fixed, making a comment about it would be useful as well, so that we can close the ticket :).
@maxnathaniel We should be merging [this](https://github.com/apache/airflow/pul... | [
{
"body": "Problem:\r\n\r\nTriggering a dag run is a relatively simple process conceptually yet a user is run through multiple different redirects and views. This results in a clunky experience that is slower, causes one to lose context and even end up on a page where they didn't even start on.\r\n\r\nSolution:... | 961ee6e8e73213bb174d83f5585ec236b3a541e1 | {
"head_commit": "ef543ba1f1a4c413377953f102566275dd7e3dc2",
"head_commit_message": "accordion css",
"patch_to_review": "diff --git a/airflow/ui/package.json b/airflow/ui/package.json\nindex 4c2a71d3302b7..6cec2a49e3ccc 100644\n--- a/airflow/ui/package.json\n+++ b/airflow/ui/package.json\n@@ -45,7 +45,8 @@\n ... | [
{
"diff_hunk": "@@ -32,24 +33,37 @@ const labelLookup = (key: string, valuesDisplay: Record<string, string> | undefi\n };\n const enumTypes = [\"string\", \"number\", \"integer\"];\n \n-export const FieldDropdown = ({ name, param }: FlexibleFormElementProps) => {\n+export const FieldDropdown = ({ name }: Flexib... | cca09fc2f86a7800bfcbc8e8693eb0c6a81b9b60 | diff --git a/airflow/ui/package.json b/airflow/ui/package.json
index a2dd20065256c..0526f20d4d040 100644
--- a/airflow/ui/package.json
+++ b/airflow/ui/package.json
@@ -46,7 +46,8 @@
"react-syntax-highlighter": "^15.5.6",
"remark-gfm": "^4.0.0",
"use-debounce": "^10.0.3",
- "usehooks-ts": "^3.1.0"
+ ... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
apache__airflow-42689@0bda802 | apache/airflow | Python | 42,689 | Add basic support for git and local dag bundles | This is a first pass at git and local dag bundles, and the bundle interface. These will certainly be expanded on (e.g. to support non-public repos).
Related: #42286
Closes: #42287
Closes: #42288 | 2024-10-02T22:15:23Z | Create Local DAG bundle backend
### Body
We need a local DAG bundle backend, which will be used for backcompat with the DAG folder and for local dev. It will not support versioning.
### Committer
- [x] I acknowledge that I am a maintainer/committer of the Apache Airflow project.
Create git DAG bundle backend
### Bo... | [
{
"body": "### Body\n\nWe need a local DAG bundle backend, which will be used for backcompat with the DAG folder and for local dev. It will not support versioning.\n\n### Committer\n\n- [x] I acknowledge that I am a maintainer/committer of the Apache Airflow project.",
"number": 42287,
"title": "Create ... | ccb18abdba26978c31db6bd3407689c73322273c | {
"head_commit": "0bda802440db575ececcc661ea5509798af28c25",
"head_commit_message": "Remove `cleanup` method; update docstrings a bit\n\nWe will add cleanup back when we implement that functionality.",
"patch_to_review": "diff --git a/airflow/config_templates/config.yml b/airflow/config_templates/config.yml\ninde... | [
{
"diff_hunk": "@@ -28,6 +28,14 @@ core:\n type: string\n example: ~\n default: \"{AIRFLOW_HOME}/dags\"\n+ dag_bundle_storage_path:\n+ description: |\n+ The folder where Airflow will store DAG bundles locally.\n+ By default, this will be ``tempfile.gettempdir()/airflow``.... | 3b3cc57a8616b68a18fe676538144f586b3a38b0 | diff --git a/airflow/config_templates/config.yml b/airflow/config_templates/config.yml
index 837fedfac2b77..25efa9ba77f34 100644
--- a/airflow/config_templates/config.yml
+++ b/airflow/config_templates/config.yml
@@ -28,6 +28,14 @@ core:
type: string
example: ~
default: "{AIRFLOW_HOME}/dags"
+ d... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
apache__airflow-37066@6cb1a13 | apache/airflow | Python | 37,066 | Add `task_acks_late` configuration to Celery Executor | <!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may ... | 2024-01-29T12:15:54Z | Confusing log for long running tasks: "dependency 'Task Instance Not Running' FAILED: Task is in the running state"
**Apache Airflow version**: 1.10.* / 2.0.* / 2.1.*
**Kubernetes version (if you are using kubernetes)** (use `kubectl version`): Any
**Environment**:
- **Cloud provider or hardware configuratio... | I bumped into this issue and I misunderstood until now 😅
thanks for pointing out it's okay to wait
After some more investigation, it's very likely we see this log appearing an hour after a long running task started because of the default `visibility_timeout` setting in Celery. This code in default_celery.py sets `vi... | [
{
"body": "**Apache Airflow version**: 1.10.* / 2.0.* / 2.1.*\r\n\r\n\r\n**Kubernetes version (if you are using kubernetes)** (use `kubectl version`): Any\r\n\r\n**Environment**:\r\n\r\n- **Cloud provider or hardware configuration**: Any\r\n- **OS** (e.g. from /etc/os-release): Any\r\n- **Kernel** (e.g. `uname ... | 41ebf28103007d4894d86783dbcdc3afc16ec2f6 | {
"head_commit": "6cb1a13bdd779dc05f74fff461812663aa5dface",
"head_commit_message": "Update airflow/providers/celery/provider.yaml",
"patch_to_review": "diff --git a/airflow/providers/celery/executors/default_celery.py b/airflow/providers/celery/executors/default_celery.py\nindex eaaf0fd0b4f31..01b13b1c5a8af 1006... | [
{
"diff_hunk": "@@ -276,6 +276,21 @@ config:\n type: float\n example: ~\n default: \"1.0\"\n+ task_acks_late:\n+ description: |\n+ If an Airflow task's execution time exceeds the visibility_timeout, Celery will re-assign the\n+ task to a Celery worker, even ... | 9be5a5e6d628d6de919502f607e2295308dd7aa1 | diff --git a/airflow/providers/celery/executors/default_celery.py b/airflow/providers/celery/executors/default_celery.py
index eaaf0fd0b4f31..01b13b1c5a8af 100644
--- a/airflow/providers/celery/executors/default_celery.py
+++ b/airflow/providers/celery/executors/default_celery.py
@@ -72,7 +72,7 @@ def _broker_supports_... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
apache__airflow-36226@e54ab78 | apache/airflow | Python | 36,226 | Modify SmtpNotifier to accept template with defaults | <!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may ... | 2023-12-14T16:50:54Z | Extend Notifier interface
### Body
Notifiers is a really cool feature. I have been using it for a while and it's simplify the use case for writing callable functions for alerts.
But... it has also one big drawback.
When I do:
`BashOperator(task_id="mytask",bash_command="fail",on_failure_callback=SmtpNotifier(... | I confirm that most Airflow users create subclasses to add their default values to the official classes, and there are no problems with that, especially for the users who need to customize the notifications
However, for common needs, creating some ready-to-use notifiers in Airflow is a good idea. Still, maybe we sho... | [
{
"body": "### Body\r\n\r\nNotifiers is a really cool feature. I have been using it for a while and it's simplify the use case for writing callable functions for alerts.\r\n\r\nBut... it has also one big drawback.\r\nWhen I do:\r\n\r\n`BashOperator(task_id=\"mytask\",bash_command=\"fail\",on_failure_callback=Sm... | 148233a19ea68f424a7077d3bba6e6ca81679c10 | {
"head_commit": "e54ab7824a6fbf45d5b450d27391b7a32da10888",
"head_commit_message": "Add TemplatedSmtpNotifier",
"patch_to_review": "diff --git a/airflow/providers/smtp/notifications/templated_smtp.py b/airflow/providers/smtp/notifications/templated_smtp.py\nnew file mode 100644\nindex 0000000000000..e52d93112357... | [
{
"diff_hunk": "@@ -0,0 +1,51 @@\n+# Licensed to the Apache Software Foundation (ASF) under one\n+# or more contributor license agreements. See the NOTICE file\n+# distributed with this work for additional information\n+# regarding copyright ownership. The ASF licenses this file\n+# to you under the Apache Li... | ba583a00c6a48cbcc1b0f435d271027ca3f18a40 | diff --git a/airflow/providers/smtp/notifications/smtp.py b/airflow/providers/smtp/notifications/smtp.py
index 88262dc876836..ce977152e2aeb 100644
--- a/airflow/providers/smtp/notifications/smtp.py
+++ b/airflow/providers/smtp/notifications/smtp.py
@@ -18,8 +18,10 @@
from __future__ import annotations
from functool... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
apache__airflow-34004@a0903ec | apache/airflow | Python | 34,004 | Allowing short package names in build-docs breeze command | <!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may ... | 2023-09-01T11:30:40Z | Replace `--package-filter` usage for docs breeze command with short package names
### Body
The `--package-filter` while nice in theory to specify which packages to build, has quite bad UX (lots of repetitions when specifying multiple packages, long package names. We practically (except `--package-filter apache-airflow... | cc: @amoghrajesh -> maybe another task for you :) ?
Nice nice. Can you assign this to me?
I'd love to approach this!
I would even prefer listing providers as: `microsoft.azure cncf.kubernetes`
rather than `apache-airflow-providers-microsoft-azure apache-airflow-providers-cncf-kubernetes`
mainly because` breeze r... | [
{
"body": "### Body\n\nThe `--package-filter` while nice in theory to specify which packages to build, has quite bad UX (lots of repetitions when specifying multiple packages, long package names. We practically (except `--package-filter apache-airflow-providers-*` never use the functionality of the filter with ... | 0d93cc5cab8cef56faf3be1705ec6784e2d8a74a | {
"head_commit": "a0903ec9542f7a5649478b29aa7dc2dcbeb86cd0",
"head_commit_message": "re working to support as args",
"patch_to_review": "diff --git a/BREEZE.rst b/BREEZE.rst\nindex b28a490aed76b..148cda18c23cd 100644\n--- a/BREEZE.rst\n+++ b/BREEZE.rst\n@@ -467,6 +467,9 @@ instance, for using it with Amazon, the ... | [
{
"diff_hunk": "@@ -357,6 +358,7 @@ def start_airflow(\n @main.command(name=\"build-docs\")\n @click.option(\"-d\", \"--docs-only\", help=\"Only build documentation.\", is_flag=True)\n @click.option(\"-s\", \"--spellcheck-only\", help=\"Only run spell checking.\", is_flag=True)\n+@argument_packages_plus_all_pro... | d4783e2f206f775734e59ff6ef3389ccd9b86d94 | diff --git a/BREEZE.rst b/BREEZE.rst
index b28a490aed76b..148cda18c23cd 100644
--- a/BREEZE.rst
+++ b/BREEZE.rst
@@ -467,6 +467,9 @@ instance, for using it with Amazon, the command would be:
breeze build-docs --package-filter apache-airflow-providers-amazon
+You can also use shorthand names as arguments inste... | {
"difficulty": "medium",
"estimated_review_effort": 2,
"problem_domain": "New Feature Additions"
} |
apache__airflow-32366@52228da | apache/airflow | Python | 32,366 | Support Pydantic 2 | Fix https://github.com/apache/airflow/issues/32311 eventually. For CI only at the moment. | 2023-07-05T08:43:55Z | Pydantic 2.0.0 support for Airflow
### Body
Currently Pydantic 2.0.0 released on 30th of June 2023 breaks Airflow CI - building providers and running Kubernetes tests.
Therefore we limit Pydantic to < 2.0.0 in setup.cfg for now.
This should be fixed, especially that 2.0.0 brings a number of speed improvements.... | Do we have a way to identify incompatibilities so they can be fixed? Maybe a CI job for example?
It's enough to remove the limit and set `full-tests-needed` for the PR and fix the problems. No need for special job.
Feel free to pick it up if you want :)
Ah right, will do that
It seems that some of our dependencies hav... | [
{
"body": "### Body\r\n\r\nCurrently Pydantic 2.0.0 released on 30th of June 2023 breaks Airflow CI - building providers and running Kubernetes tests.\r\n\r\nTherefore we limit Pydantic to < 2.0.0 in setup.cfg for now.\r\n\r\nThis should be fixed, especially that 2.0.0 brings a number of speed improvements.\r\n... | 7722b6f226e9db3a89b01b89db5fdb7a1ab2256f | {
"head_commit": "52228da5114227c296a2c6e9a292954147c4123e",
"head_commit_message": "Use base datetime class for Pydantic",
"patch_to_review": "diff --git a/Dockerfile b/Dockerfile\nindex 35afca6672a77..f89293c5a6f52 100644\n--- a/Dockerfile\n+++ b/Dockerfile\n@@ -385,7 +385,8 @@ function install_airflow_dependen... | [
{
"diff_hunk": "@@ -51,7 +51,8 @@ function install_airflow_dependencies_from_branch_tip() {\n pip install --root-user-action ignore \\\n ${ADDITIONAL_PIP_INSTALL_FLAGS} \\\n \"https://github.com/${AIRFLOW_REPO}/archive/${AIRFLOW_BRANCH}.tar.gz#egg=apache-airflow[${AIRFLOW_EXTRAS}]\" \\\n- -... | a952ea1460cfb0ea47f4b2ca9c40b668d8aacf5e | diff --git a/airflow/serialization/pydantic/dag_run.py b/airflow/serialization/pydantic/dag_run.py
index a5ae6b4a22b52..1e1528eb35641 100644
--- a/airflow/serialization/pydantic/dag_run.py
+++ b/airflow/serialization/pydantic/dag_run.py
@@ -18,7 +18,6 @@
from datetime import datetime
from typing import List, Optional... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Dependency Updates & Env Compatibility"
} |
apache__airflow-43231@28f06f3 | apache/airflow | Python | 43,231 | ISSUE-43043 | AIP-38 | Add more sort options to Dags List | Add more sort options to Dags List `"dag_display_name","next_dagrun", "last_run_state", "last_run_start_date"`
closes: #43043
Updated UI:
https://github.com/user-attachments/assets/a75156b5-10ac-47bc-a9e1-50232d997a74
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful descri... | 2024-10-21T19:08:01Z | AIP-38 | Add more sort options to Dags List
In our fastapi endpoint, we only sort the
Right now, we only sort by `dag_id`. Let's swap that for display_name. Also, let's add `"next_dagrun", "last_run_state", "last_run_start_date"` as other sort options.
Since not all of these fields are currently columns in the dags ... | Could you please assign this to me. | [
{
"body": "In our fastapi endpoint, we only sort the \n\nRight now, we only sort by `dag_id`. Let's swap that for display_name. Also, let's add `\"next_dagrun\", \"last_run_state\", \"last_run_start_date\"` as other sort options.\n\nSince not all of these fields are currently columns in the dags list response, ... | 1bd061df6e4409c5330d258d11fb7633e861a622 | {
"head_commit": "28f06f36d285a11dc07369ed4f85f5fc8128550e",
"head_commit_message": "reviews",
"patch_to_review": "diff --git a/airflow/ui/src/pages/DagsList/DagsList.tsx b/airflow/ui/src/pages/DagsList/DagsList.tsx\nindex 9d5b01e20f73c..9259d6df82961 100644\n--- a/airflow/ui/src/pages/DagsList/DagsList.tsx\n+++ ... | [
{
"diff_hunk": "@@ -200,21 +200,31 @@ export const DagsList = () => {\n <Heading py={3} size=\"md\">\n {pluralize(\"DAG\", data?.total_entries)}\n </Heading>\n- {display === \"card\" ? (",
"line": null,
"original_line": 234,
"original_start_line": null,
"... | 33559e724d194a03d0620c36e508bee2db83f690 | diff --git a/airflow/ui/src/constants/sortParams.ts b/airflow/ui/src/constants/sortParams.ts
new file mode 100644
index 0000000000000..3dd2785bd1ace
--- /dev/null
+++ b/airflow/ui/src/constants/sortParams.ts
@@ -0,0 +1,38 @@
+/*!
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor lic... | {
"difficulty": "medium",
"estimated_review_effort": 2,
"problem_domain": "New Feature Additions"
} |
apache__airflow-31806@58b343a | apache/airflow | Python | 31,806 | New gantt tab | New Gantt Chart in grid new tabs
Closes: [#19940](https://github.com/apache/airflow/issues/19940)
Sync scrolling with grid:
Support task groups and sync with grid:
![Jun-08-2023 17-11-01](https://gi... | 2023-06-08T21:14:25Z | Create a new gantt chart in React
The Gantt chart could become far more useful to see how a dag is performing. We should make it a first class citizen by integrating it with the tree view.
The gantt rows can be lined up with the tree view to keep context.
It would be easy to explore different runs by selecting sepa... | [
{
"body": "The Gantt chart could become far more useful to see how a dag is performing. We should make it a first class citizen by integrating it with the tree view.\r\n\r\nThe gantt rows can be lined up with the tree view to keep context.\r\nIt would be easy to explore different runs by selecting separate colu... | 15d42b4320d535cf54743929f134e36f59c615bb | {
"head_commit": "58b343a064d6c8a36af07eca6258798cd161ede6",
"head_commit_message": "fix www tests",
"patch_to_review": "diff --git a/airflow/www/package.json b/airflow/www/package.json\nindex cad6a6320a154..9767558c9afe8 100644\n--- a/airflow/www/package.json\n+++ b/airflow/www/package.json\n@@ -129,7 +129,7 @@\... | [
{
"diff_hunk": "@@ -262,6 +295,16 @@ const Details = ({ openGroupIds, onToggleGroups, hoveredTaskState }: Props) => {\n hoveredTaskState={hoveredTaskState}\n />\n </TabPanel>\n+ {run && (\n+ <TabPanel p={0} height=\"100%\">\n+ <Gantt\n+ ... | 85e856a911884e14d5d7ee66f4e84c4044a8168b | diff --git a/airflow/www/package.json b/airflow/www/package.json
index cad6a6320a154..9767558c9afe8 100644
--- a/airflow/www/package.json
+++ b/airflow/www/package.json
@@ -129,7 +129,7 @@
"nvd3": "^1.8.6",
"react": "^18.0.0",
"react-dom": "^18.0.0",
- "react-icons": "^4.3.1",
+ "react-icons": "^4.... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
Subsets and Splits
Review Test Instances
Retrieves basic metadata about code review instances but doesn't provide any analytical insights or patterns beyond raw data access.