instance_id stringlengths 21 53 | repo stringclasses 188
values | language stringclasses 1
value | pull_number int64 20 148k | title stringlengths 6 144 | body stringlengths 0 83.4k | created_at stringdate 2015-09-25 03:17:17 2025-07-10 16:50:35 | problem_statement stringlengths 188 240k | hints_text stringlengths 0 145k | resolved_issues listlengths 1 6 | base_commit stringlengths 40 40 | commit_to_review dict | reference_review_comments listlengths 1 62 | merged_commit stringlengths 40 40 | merged_patch stringlengths 297 9.87M | metadata dict |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
getredash__redash-1873@aacc4b7 | getredash/redash | Python | 1,873 | Custom JS code chart improvements | This PR introduces some fixes and changes to custom code chart visualization.
1. Fix: Currently, custom js code textarea does not load the saved code properly. This fixes the issue by setting the textarea contents only if the content is undefined.
2. Fix: Any update of the graph in editor causes appended trace. T... | 2017-07-11T01:48:12Z | Loading custom JS chart into editor fails.
### Issue Summary
Saved custom JS chart visualization does not load in editor.
### Steps to Reproduce
1. Select Custom Plotly chart and select xAxis and a yAxis.
I chose `select ID, org_id from events LIMIT 10` from Redash metadata.
2. Paste the following to Cust... | [
{
"body": "### Issue Summary\r\n\r\nSaved custom JS chart visualization does not load in editor.\r\n\r\n### Steps to Reproduce\r\n\r\n1. Select Custom Plotly chart and select xAxis and a yAxis.\r\n I chose `select ID, org_id from events LIMIT 10` from Redash metadata.\r\n\r\n2. Paste the following to Custom Cod... | 5bb5f46c022e8f2fb51f198c1d2567e580efbc16 | {
"head_commit": "aacc4b7b4624c15e7eea265cc5c5c4089027e544",
"head_commit_message": "Fix: Custom code keeps appending trace per refresh",
"patch_to_review": "diff --git a/client/app/assets/css/superflat_redash.css b/client/app/assets/css/superflat_redash.css\nindex b30dd11a64..b39b72bf74 100644\n--- a/client/app/... | [
{
"diff_hunk": "@@ -499,6 +499,9 @@ const CustomPlotlyChart = (clientConfig) => {\n return;\n }\n const refresh = () => {\n+ // Clear existing data\n+ element[0].children[0].calcdata = [];\n+ element[0].children[0].data = [];",
"line": null,
"original_line": 504,... | 1a8078ab0345108ef91ca5a17835b3c6816f15ba | diff --git a/client/app/assets/css/superflat_redash.css b/client/app/assets/css/superflat_redash.css
index b30dd11a64..b39b72bf74 100644
--- a/client/app/assets/css/superflat_redash.css
+++ b/client/app/assets/css/superflat_redash.css
@@ -1781,6 +1781,9 @@ fieldset[disabled] .form-control {
textarea.form-control {
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
getredash__redash-3952@8c627f0 | getredash/redash | Python | 3,952 | Support multi-select in parameters | ## What type of PR is this? (check all applicable)
<!-- Please leave only what's applicable -->
- [x] Feature
## Description
This one is to add an option to allow multiple values in Dropdown parameters (see preview below :)).
- [x] Make 'quote each value' an option (and let the user customize the separator?)
... | 2019-07-04T14:40:59Z | Support for multi select in parameters
When using a Dropdown List type of parameter, the user should be able to define the parameter to take multiple values.
This will require some additional configuration of how to serialize the values. We can probably do away with adding a checkbox for "quote each value". | [
{
"body": "When using a Dropdown List type of parameter, the user should be able to define the parameter to take multiple values.\r\n\r\nThis will require some additional configuration of how to serialize the values. We can probably do away with adding a checkbox for \"quote each value\".",
"number": 3053,
... | 8ad08a566adf1ce6fd461bf7cf11b51f12b3a48f | {
"head_commit": "8c627f01d30f10eacdb371393a312ba0e4f666df",
"head_commit_message": "Allow multi-select for Query dropdown parameters",
"patch_to_review": "diff --git a/client/app/components/EditParameterSettingsDialog.jsx b/client/app/components/EditParameterSettingsDialog.jsx\nindex 1805f9ed6c..0566302bdf 10064... | [
{
"diff_hunk": "@@ -92,6 +99,12 @@ def _is_date_range(obj):\n return False\n \n \n+def _is_dropdown_value_valid(value, dropdown_options):",
"line": null,
"original_line": 102,
"original_start_line": null,
"path": "redash/models/parameterized_query.py",
"start_line": null,
"text":... | 52523c0feb7a555c9783e29ff29dc9ccb30186ee | diff --git a/client/app/components/EditParameterSettingsDialog.jsx b/client/app/components/EditParameterSettingsDialog.jsx
index 503e5ae477..7db1ee3003 100644
--- a/client/app/components/EditParameterSettingsDialog.jsx
+++ b/client/app/components/EditParameterSettingsDialog.jsx
@@ -2,6 +2,7 @@
import { includes, words... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
getredash__redash-2756@92b989a | getredash/redash | Python | 2,756 | Dashboard Parameters | 1. Split `Add Widget` button (and modal) into two buttons (and modals): `Add Widget` and `Add Textbox`.
2. Implement new logic of mapping query parameters to dashboard parameters (as described in issue).
Screenshots:
![image](https://user-images.githubusercontent.com/12139186/44398630-44cab400-a54d-11e8-9ec4-c8... | 2018-08-21T11:22:07Z | Parameters with the same name cause a conflict in dashboards
### Issue Summary
If you have a dashboard that references two or more queries that each have a non-global parameter with the same name one parameter's value will overwrite the others'.
### Steps to Reproduce
1. Create Query1 and Query2 each with a no... | By template you mean parameter?
Yes-my bad-parameter. Updated issue.
This is related: add ability to add viz to dashboard from query page https://github.com/getredash/redash/pull/2656
This is also a great opportunity to improve the Add Widget modal and make it nicer.
<img width="802" alt="screenshot 2018-07-13 17 44 43... | [
{
"body": "### Issue Summary\r\n\r\nIf you have a dashboard that references two or more queries that each have a non-global parameter with the same name one parameter's value will overwrite the others'.\r\n\r\n### Steps to Reproduce\r\n\r\n1. Create Query1 and Query2 each with a non-global template named \"a_pa... | d68a4dce5f95b62c6d506e0067ad4e7b4d50282f | {
"head_commit": "92b989aa2e78f2233455c1022ceeaefb0a9483e6",
"head_commit_message": "Use Ant's Select component instead on <select> tags",
"patch_to_review": "diff --git a/client/.eslintrc.js b/client/.eslintrc.js\nindex 10fae2b4c6..17552fcd15 100644\n--- a/client/.eslintrc.js\n+++ b/client/.eslintrc.js\n@@ -26,6... | [
{
"diff_hunk": "@@ -0,0 +1,267 @@\n+/* eslint react/no-multi-comp: 0 */\n+\n+import { extend, map, includes, findIndex, find, fromPairs } from 'lodash';\n+import React from 'react';\n+import PropTypes from 'prop-types';\n+import { Select } from 'antd';",
"line": null,
"original_line": 6,
"original_s... | 8c77bebf647dde5ea359365f0c3db1103850a2c2 | diff --git a/client/.eslintrc.js b/client/.eslintrc.js
index 10fae2b4c6..17552fcd15 100644
--- a/client/.eslintrc.js
+++ b/client/.eslintrc.js
@@ -26,6 +26,7 @@ module.exports = {
"no-lonely-if": "off",
"consistent-return": "off",
"no-control-regex": "off",
+ "no-script-url": "off", // some <a> tags s... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
goauthentik__authentik-14718@25f4eb7 | goauthentik/authentik | Python | 14,718 | sources/ldap: add forward deletion option | Closes #1644
---
## Checklist
- [x] Local tests pass (`ak test authentik/`)
- [x] The code has been formatted (`make lint-fix`)
If an API change has been made
- [x] The API schema has been updated (`make gen-build`)
If changes to the frontend have been made
- [x] The code has been formatt... | 2025-05-27T11:09:28Z | LDAP Users and groups not removed from Authentik when removed from LDAP
**Describe the bug**
Users and groups continue to exist after deleting them from LDAP
**To Reproduce**
Steps to reproduce the behavior:
1. Create User in LDAP
2. Sync LDAP source
3. Delete User in LDAP
4. Sync LDAP source again
**Expect... | This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Any update about this ?
Is this by design? Is the LDAP synchronization only a one-time import process?
> Is this by design? Is the LDAP synchroni... | [
{
"body": "**Describe the bug**\r\nUsers and groups continue to exist after deleting them from LDAP\r\n\r\n**To Reproduce**\r\nSteps to reproduce the behavior:\r\n1. Create User in LDAP\r\n2. Sync LDAP source\r\n3. Delete User in LDAP\r\n4. Sync LDAP source again\r\n\r\n**Expected behavior**\r\nUser and or Grou... | 61fc1dc1fbbe5671f6b787d93d19beae22b966d6 | {
"head_commit": "25f4eb7eade3255cd5babc1b1b49e6f33fb23531",
"head_commit_message": "sources/ldap: add forward deletion option",
"patch_to_review": "diff --git a/authentik/sources/ldap/api.py b/authentik/sources/ldap/api.py\nindex 167bb2059aa1..cc37ef77ef8e 100644\n--- a/authentik/sources/ldap/api.py\n+++ b/authe... | [
{
"diff_hunk": "@@ -77,6 +77,12 @@ def get_objects(self, **kwargs) -> Generator:\n \"\"\"Get objects from LDAP, implemented in subclass\"\"\"\n raise NotImplementedError()\n \n+ def get_identifier(self, object):\n+ attributes = object.get(\"attributes\", {})\n+ if not attributes... | 825da1b5abac38e937cc577654d847f5a18b72f4 | diff --git a/authentik/sources/ldap/api.py b/authentik/sources/ldap/api.py
index 167bb2059aa1..cc37ef77ef8e 100644
--- a/authentik/sources/ldap/api.py
+++ b/authentik/sources/ldap/api.py
@@ -111,6 +111,7 @@ class Meta:
"sync_parent_group",
"connectivity",
"lookup_groups_from_user"... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
goauthentik__authentik-14507@5789f9a | goauthentik/authentik | Python | 14,507 | core: remove `OldAuthenticatedSession` content type | Fixes #14437 | 2025-05-14T11:29:43Z | When adding Can view Authenticated Session as a global permission to a role, authentik returns 405
**Describe the bug**
When adding Can view Authenticated Session as a global permission to a role, authentik returns 405
**To Reproduce**
Steps to reproduce the behavior:
1. Create a role
2. Go to the roles settings
3. A... | I can't seem to replicate this on my test deployments. Could you please provide the whole request/response pair so that we can investigate further?
```
Traceback (most recent call last):
File "/ak-root/.venv/lib/python3.12/site-packages/asgiref/sync.py", line 518, in thread_handler
raise exc_info[1]
File "/ak-r... | [
{
"body": "**Describe the bug**\nWhen adding Can view Authenticated Session as a global permission to a role, authentik returns 405\n\n**To Reproduce**\nSteps to reproduce the behavior:\n\n1. Create a role\n2. Go to the roles settings\n3. Add global permission for Can view Authenticated Session\n4. Response ret... | d0dc14d84d84d0b6d49f12abe7df5f13b1acad8d | {
"head_commit": "5789f9ac6778f91d437783785c125f186ac6f6bd",
"head_commit_message": "remove stale content types in `repair_permissions`\n\nCo-authored-by: Jens Langhammer <jens@goauthentik.io>",
"patch_to_review": "diff --git a/authentik/core/management/commands/repair_permissions.py b/authentik/core/management/c... | [
{
"diff_hunk": "@@ -14,6 +15,11 @@ class Command(BaseCommand):\n @no_translations\n def handle(self, *args, **options):\n \"\"\"Check permissions for all apps\"\"\"\n+\n+ # Remove potential lingering old permissions\n+ # See https://code.djangoproject.com/ticket/28417\n+ cal... | 8ad79ff1421409a1c0bf7db3124bebcd47409d8e | diff --git a/authentik/core/management/commands/repair_permissions.py b/authentik/core/management/commands/repair_permissions.py
index 3dfa9b8d7d07..dada3e6772ec 100644
--- a/authentik/core/management/commands/repair_permissions.py
+++ b/authentik/core/management/commands/repair_permissions.py
@@ -2,6 +2,7 @@
from d... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
goauthentik__authentik-13602@50ea3f3 | goauthentik/authentik | Python | 13,602 | events: add configurable headers to webhooks | <!--
👋 Hi there! Welcome.
Please check the Contributing guidelines: https://docs.goauthentik.io/docs/developer-docs/#how-can-i-contribute
-->
## Details
closes #4875
TODO:
- API
- WebUI
- Rename `webhook_mapping` to `webhook_mapping_body`?
---
## Checklist
- [ ] Local tests pass (`ak test a... | 2025-03-20T17:16:45Z | GET for notification webhooks and POST request template
As of now, only POST webhooks can be set in the notification transport. These webhooks are not configurable and send a predefined JSON, would be nice to be able to template that to support different notification queues systems (ntfy uhm)
Moreover, it would be g... | The data within the webhook can be customized using a property mapping; see https://docs.goauthentik.io/docs/events/transports#generic-webhook
Hello,
also a big <3 from me, been using authentik for some time now and its only gettting better.
Can we get the ability to send a Header as well? | [
{
"body": "As of now, only POST webhooks can be set in the notification transport. These webhooks are not configurable and send a predefined JSON, would be nice to be able to template that to support different notification queues systems (ntfy uhm)\r\n\r\nMoreover, it would be great if a simple GET would be all... | ab7338b50ed71e35b2fb8885ac8ad56613946f3f | {
"head_commit": "50ea3f3aeee2832421fabe31c3a24bfb5250f071",
"head_commit_message": "make it a full thing\n\nSigned-off-by: Jens Langhammer <jens@goauthentik.io>",
"patch_to_review": "diff --git a/authentik/events/api/notification_transports.py b/authentik/events/api/notification_transports.py\nindex 3838d2fa8c93... | [
{
"diff_hunk": "@@ -0,0 +1,42 @@\n+# Generated by Django 5.0.13 on 2025-03-20 19:54\n+\n+import django.db.models.deletion\n+from django.db import migrations, models\n+\n+\n+class Migration(migrations.Migration):\n+\n+ dependencies = [\n+ (\"authentik_events\", \"0008_event_authentik_e_expires_8c73a8_i... | 4cb58c8f6bb2e28464f8fc947195f7832d76bd1e | diff --git a/authentik/events/api/notification_transports.py b/authentik/events/api/notification_transports.py
index 3838d2fa8c93..990fb89e4cdb 100644
--- a/authentik/events/api/notification_transports.py
+++ b/authentik/events/api/notification_transports.py
@@ -50,7 +50,8 @@ class Meta:
"mode",
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
huggingface__datasets-7616@4dfff64 | huggingface/datasets | Python | 7,616 | Torchcodec decoding | Closes #7607
## New signatures
### Audio
```python
Audio(sampling_rate: Optional[int] = None, mono: bool = True, decode: bool = True, stream_index: Optional[int] = None)
Audio.encode_example(self, value: Union[str, bytes, bytearray, dict, "AudioDecoder"]) -> dict
Audio.decode_example(self, value: dict, token_... | 2025-06-13T19:06:07Z | Video and audio decoding with torchcodec
### Feature request
Pytorch is migrating video processing to torchcodec and it's pretty cool. It would be nice to migrate both the audio and video features to use torchcodec instead of torchaudio/video.
### Motivation
My use case is I'm working on a multimodal AV model, and w... | Good idea ! let me know if you have any question or if I can help
@lhoestq Almost finished, but I'm having trouble understanding this test case.
This is how it looks originally. The `map` function is called, and then `with_format` is called. According to the test case example["video"] is supposed to be a VideoReader. H... | [
{
"body": "### Feature request\n\nPytorch is migrating video processing to torchcodec and it's pretty cool. It would be nice to migrate both the audio and video features to use torchcodec instead of torchaudio/video.\n\n### Motivation\n\nMy use case is I'm working on a multimodal AV model, and what's nice about... | b7819cd9f7a51a83389d435c5a8ffe450890a3bb | {
"head_commit": "4dfff647cc3fdedbfdad4fbb009a9c79d36836f9",
"head_commit_message": "Merge branch 'main' into torchcodec-decoding",
"patch_to_review": "diff --git a/docs/source/about_dataset_features.mdx b/docs/source/about_dataset_features.mdx\nindex fd3f9e1d560..4e5b182b7ed 100644\n--- a/docs/source/about_datas... | [
{
"diff_hunk": "@@ -55,16 +59,14 @@ class Audio:\n >>> ds = load_dataset(\"PolyAI/minds14\", name=\"en-US\", split=\"train\")\n >>> ds = ds.cast_column(\"audio\", Audio(sampling_rate=16000))\n >>> ds[0][\"audio\"]\n- {'array': array([ 2.3443763e-05, 2.1729663e-04, 2.2145823e-04, ...,\n- ... | 4a637bd963557bca42d3a2d8c54200fccb7ab91e | diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index d299ceb4f2b..a4a9041fd28 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -44,15 +44,17 @@ jobs:
- uses: actions/checkout@v4
with:
fetch-depth: 0
+ - name: Setup FFmpeg
+ if: ${{ matrix.o... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
home-assistant__core-142705@ab029b6 | home-assistant/core | Python | 142,705 | Support Body Composition Scale S400 in xiaomi_ble | <!--
You are amazing! Thanks for contributing to our project!
Please, DO NOT DELETE ANY TEXT from this template! (unless instructed).
-->
## Proposed change
<!--
Describe the big picture of your changes here to communicate to the
maintainers why we should accept this pull request. If it fixes a bug
or... | 2025-04-10T22:22:30Z | Can not integrate Xiaomi Body Composition Scale S400 (MJTZC01YM) over Xiaomi BLE
### The problem
It is not possibme to integrate the Xiaomi Body Composition Scale S400 (MJTZC01YM) over Xiaomi BLE.
It seems only the old Xiaomi scales are working.
### What version of Home Assistant Core has the issue?
core-2025.3.4
... | Hey there @jc2k, @ernst79, mind taking a look at this issue as it has been labeled with an integration (`xiaomi_ble`) you are listed as a [code owner](https://github.com/home-assistant/core/blob/dev/CODEOWNERS#L1751) for? Thanks!
<details>
<summary>Code owner commands</summary>
Code owners of `xiaomi_ble` can trigge... | [
{
"body": "### The problem\n\nIt is not possibme to integrate the Xiaomi Body Composition Scale S400 (MJTZC01YM) over Xiaomi BLE.\nIt seems only the old Xiaomi scales are working.\n\n### What version of Home Assistant Core has the issue?\n\ncore-2025.3.4\n\n### What was the last working version of Home Assista... | 6737c51fcab133c767b649bb69e6b12a267c8f25 | {
"head_commit": "ab029b68435fe87d67dc49e660a235be24b77a3e",
"head_commit_message": "Merge remote-tracking branch 'upstream/dev' into xiaomi_scale_s400",
"patch_to_review": "diff --git a/homeassistant/components/xiaomi_ble/sensor.py b/homeassistant/components/xiaomi_ble/sensor.py\nindex 57dfaead2329b3..c79cd96e30... | [
{
"diff_hunk": "@@ -177,6 +177,27 @@\n native_unit_of_measurement=UnitOfTime.MINUTES,\n state_class=SensorStateClass.MEASUREMENT,\n ),\n+ # Low frequency impedance sensor (ohm)\n+ (ExtendedSensorDeviceClass.IMPEDANCE_LOW, Units.OHM): SensorEntityDescription(\n+ key=str(ExtendedS... | 055c0874a6d55bce7a82aa71e7e4cab22f317a63 | diff --git a/homeassistant/components/xiaomi_ble/sensor.py b/homeassistant/components/xiaomi_ble/sensor.py
index 57dfaead2329b3..0fcae1925bb752 100644
--- a/homeassistant/components/xiaomi_ble/sensor.py
+++ b/homeassistant/components/xiaomi_ble/sensor.py
@@ -177,6 +177,25 @@
native_unit_of_measurement=UnitOfTi... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
home-assistant__core-142977@fa60db7 | home-assistant/core | Python | 142,977 | Fix Automation/Script: sequence within a parallel ignoring enabled flag | <!--
You are amazing! Thanks for contributing to our project!
Please, DO NOT DELETE ANY TEXT from this template! (unless instructed).
-->
## Proposed change
<!--
Fix an issue where a "sequence" within a "parallel" could not be disabled as the enabled flag was not checked.
Added test to ensure this issue do... | 2025-04-15T07:18:24Z | Scripts/Automations - Sequence inside Parallel ignoring being disabled
### The problem
first noticed this in 2024.8 and remains in 2024.9.
running haos on a HA yellow
if you have a parallel building block that has sequence building blocks inside it then the sequences ignore "enabled: false" and run
so you hav... | Hey there @home-assistant/core, mind taking a look at this issue as it has been labeled with an integration (`automation`) you are listed as a [code owner](https://github.com/home-assistant/core/blob/dev/CODEOWNERS#L166) for? Thanks!
<details>
<summary>Code owner commands</summary>
Code owners of `automation` can tr... | [
{
"body": "### The problem\r\n\r\nfirst noticed this in 2024.8 and remains in 2024.9.\r\nrunning haos on a HA yellow\r\n\r\nif you have a parallel building block that has sequence building blocks inside it then the sequences ignore \"enabled: false\" and run\r\n\r\nso you have\r\n\r\nparallel block\r\n> Sequenc... | e7994b3da118fa5ccf35cf2d30b0739abf178dda | {
"head_commit": "fa60db7e551da296518aabeb03b13822abf300ae",
"head_commit_message": "add test for ensuring sequence inside parallel follows enabled tag",
"patch_to_review": "diff --git a/homeassistant/helpers/script.py b/homeassistant/helpers/script.py\nindex 43429bdb1d26da..08af68742db1f8 100644\n--- a/homeassis... | [
{
"diff_hunk": "@@ -653,6 +653,10 @@ async def async_run_with_trace(idx: int, script: Script) -> None:\n \"\"\"Run a script with a trace path.\"\"\"\n trace_path_stack_cv.set(copy(trace_path_stack_cv.get()))\n with trace_path([str(idx), \"sequence\"]):\n+ if no... | a4e150af0ae477739e640ae98f511ae5ee061118 | diff --git a/homeassistant/helpers/script.py b/homeassistant/helpers/script.py
index 43429bdb1d26d..2b4da38b15efb 100644
--- a/homeassistant/helpers/script.py
+++ b/homeassistant/helpers/script.py
@@ -629,6 +629,10 @@ async def _async_run_script(
self, script: Script, *, parallel: bool = False
) -> None:
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
home-assistant__core-142561@75b68ec | home-assistant/core | Python | 142,561 | Fix Quickmode handling in ViCare integration | <!--
You are amazing! Thanks for contributing to our project!
Please, DO NOT DELETE ANY TEXT from this template! (unless instructed).
-->
## Proposed change
<!--
Describe the big picture of your changes here to communicate to the
maintainers why we should accept this pull request. If it fixes a bug
or... | 2025-04-08T21:55:00Z | No longer able to set fan speed starting with Home Assistant 2025.3.0 (vitovent 300-W, but most likely this is the same for all)
### The problem
Since home assistant version 2025.3, setting the fan speed throws an error
### What version of Home Assistant Core has the issue?
core-2025.3.0
### What was the last worki... | Hey there @cfenner, mind taking a look at this issue as it has been labeled with an integration (`vicare`) you are listed as a [code owner](https://github.com/home-assistant/core/blob/dev/CODEOWNERS#L1658) for? Thanks!
<details>
<summary>Code owner commands</summary>
Code owners of `vicare` can trigger bot actions b... | [
{
"body": "### The problem\n\nSince home assistant version 2025.3, setting the fan speed throws an error\n\n### What version of Home Assistant Core has the issue?\n\ncore-2025.3.0\n\n### What was the last working version of Home Assistant Core?\n\ncore-2025.2.4\n\n### What type of installation are you running?\... | 5d8c90ae0de5701ca52fcff51ec5b32e65f380d6 | {
"head_commit": "75b68ece1abab64217ada7769a304a490597e3fc",
"head_commit_message": "update snapshot",
"patch_to_review": "diff --git a/homeassistant/components/vicare/fan.py b/homeassistant/components/vicare/fan.py\nindex d84b2038ddef58..d1d63b2c560f45 100644\n--- a/homeassistant/components/vicare/fan.py\n+++ b/... | [
{
"diff_hunk": "@@ -196,26 +197,24 @@ def update(self) -> None:\n @property\n def is_on(self) -> bool | None:\n \"\"\"Return true if the entity is on.\"\"\"\n- if (\n- self._attr_supported_features & FanEntityFeature.TURN_OFF\n- and self._api.getVentilationQuickmode(... | 31912a2fd101ccfc70a65822bd4f13bef2134cd5 | diff --git a/homeassistant/components/vicare/fan.py b/homeassistant/components/vicare/fan.py
index d84b2038ddef5..88d42503a0324 100644
--- a/homeassistant/components/vicare/fan.py
+++ b/homeassistant/components/vicare/fan.py
@@ -127,6 +127,7 @@ class ViCareFan(ViCareEntity, FanEntity):
_attr_speed_count = len(OR... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
huggingface__datasets-7434@5341540 | huggingface/datasets | Python | 7,434 | Refactor `Dataset.map` to reuse cache files mapped with different `num_proc` | Fixes #7433
This refactor unifies `num_proc is None or num_proc == 1` and `num_proc > 1`; instead of handling them completely separately where one uses a list of kwargs and shards and the other just uses a single set of kwargs and `self`, by wrapping the `num_proc == 1` case in a list and making the difference just ... | 2025-03-04T06:12:37Z | `Dataset.map` ignores existing caches and remaps when ran with different `num_proc`
### Describe the bug
If you `map` a dataset and save it to a specific `cache_file_name` with a specific `num_proc`, and then call map again with that same existing `cache_file_name` but a different `num_proc`, the dataset will be re-ma... | This feels related: https://github.com/huggingface/datasets/issues/3044
@lhoestq This comment specifically, I agree:
* https://github.com/huggingface/datasets/issues/3044#issuecomment-1239877570
> Almost a year later and I'm in a similar boat. Using custom fingerprints and when using multiprocessing the cached datase... | [
{
"body": "### Describe the bug\n\nIf you `map` a dataset and save it to a specific `cache_file_name` with a specific `num_proc`, and then call map again with that same existing `cache_file_name` but a different `num_proc`, the dataset will be re-mapped.\n\n### Steps to reproduce the bug\n\n1. Download a datase... | 491d8082e2f062a1cf4734c2b88940a496f9892e | {
"head_commit": "534154006cc4c4ab909fc490bd2adf80b4f6319a",
"head_commit_message": "Refactor Dataset.map to reuse cache files mapped with different num_proc\n\nFixes #7433\n\nThis refactor unifies num_proc is None or num_proc == 1 and num_proc > 1; instead of handling them completely separately where one uses a li... | [
{
"diff_hunk": "@@ -3056,64 +3063,98 @@ def load_processed_shard_from_cache(shard_kwargs):\n return Dataset.from_file(shard_kwargs[\"cache_file_name\"], info=info, split=shard.split)\n raise NonExistentDatasetError\n \n- num_shards = num_proc if num_proc is not None else 1... | 87b468bb2fdfca38765a7d60ee7c635d0ad554c2 | diff --git a/setup.py b/setup.py
index d162780c19f..e66a3c4236c 100644
--- a/setup.py
+++ b/setup.py
@@ -185,7 +185,7 @@
"zstandard",
"polars[timezone]>=0.20.0",
"torchvision",
- "pyav",
+ "av",
]
diff --git a/src/datasets/arrow_dataset.py b/src/datasets/arrow_dataset.py
index 9b4ad016692..c4e... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
huggingface__datasets-7069@e4148ae | huggingface/datasets | Python | 7,069 | Fix push_to_hub by not calling create_branch if PR branch | Fix push_to_hub by not calling create_branch if PR branch (e.g. `refs/pr/1`).
Note that currently create_branch raises a 400 Bad Request error if the user passes a PR branch (e.g. `refs/pr/1`).
EDIT:
~~Fix push_to_hub by not calling create_branch if branch exists.~~
Note that currently create_branch raises a ... | 2024-07-25T07:50:04Z | Convert_to_parquet fails for datasets with multiple configs
If the dataset has multiple configs, when using the `datasets-cli convert_to_parquet` command to avoid issues with the data viewer caused by loading scripts, the conversion process only successfully converts the data corresponding to the first config. When it ... | Many users have encountered the same issue, which has caused inconvenience.
https://discuss.huggingface.co/t/convert-to-parquet-fails-for-datasets-with-multiple-configs/86733
Thanks for reporting.
I will make the code more robust.
I have opened an issue in the huggingface-hub repo:
- https://github.com/hugging... | [
{
"body": "If the dataset has multiple configs, when using the `datasets-cli convert_to_parquet` command to avoid issues with the data viewer caused by loading scripts, the conversion process only successfully converts the data corresponding to the first config. When it starts converting the second config, it t... | baea190799dfa22493621fe06584b006b57f16ce | {
"head_commit": "e4148aebb2212386965764054ff5401b99e20f6e",
"head_commit_message": "Reword comment",
"patch_to_review": "diff --git a/src/datasets/arrow_dataset.py b/src/datasets/arrow_dataset.py\nindex 779091a75af..c24345d1e1e 100644\n--- a/src/datasets/arrow_dataset.py\n+++ b/src/datasets/arrow_dataset.py\n@@ ... | [
{
"diff_hunk": "@@ -5620,7 +5620,8 @@ def push_to_hub(\n )\n repo_id = repo_url.repo_id\n \n- if revision is not None:\n+ if revision is not None and not api.revision_exists(repo_id, revision, repo_type=\"dataset\", token=token):",
"line": null,
"original_line": 5623,
"... | cf9f2b857b9f1c0084463af7f1990a4d94514116 | diff --git a/src/datasets/arrow_dataset.py b/src/datasets/arrow_dataset.py
index 5ac987e3f9b..3060f5feb07 100644
--- a/src/datasets/arrow_dataset.py
+++ b/src/datasets/arrow_dataset.py
@@ -5677,7 +5677,8 @@ def push_to_hub(
)
repo_id = repo_url.repo_id
- if revision is not None:
+ if r... | {
"difficulty": "medium",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
huggingface__datasets-7019@bb6baf5 | huggingface/datasets | Python | 7,019 | Support pyarrow large_list | Allow Polars round trip by supporting pyarrow large list.
Fix #6834, fix #6984.
Supersede and close #4800, close #6835, close #6986. | 2024-07-02T09:52:52Z | largelisttype not supported (.from_polars())
### Describe the bug
The following code fails because LargeListType is not supported.
This is especially a problem for .from_polars since polars uses LargeListType.
### Steps to reproduce the bug
```python
import datasets
import polars as pl
df = pl.DataFram... | Hi ! Thanks for reporting :)
We don't support `large_list` yet, though it should be added to `Sequence` IMO (maybe with a parameter `large=True` ?) | [
{
"body": "### Describe the bug\r\n\r\nThe following code fails because LargeListType is not supported.\r\nThis is especially a problem for .from_polars since polars uses LargeListType.\r\n\r\n\r\n### Steps to reproduce the bug\r\n\r\n```python\r\nimport datasets\r\nimport polars as pl\r\n\r\ndf = pl.DataFrame(... | baea190799dfa22493621fe06584b006b57f16ce | {
"head_commit": "bb6baf56ccbe4e1e66770448225d7b9ca4d61437",
"head_commit_message": "Add LargeList to main classes docs",
"patch_to_review": "diff --git a/docs/source/package_reference/main_classes.mdx b/docs/source/package_reference/main_classes.mdx\nindex 9c964bc56d5..86257f624b4 100644\n--- a/docs/source/packa... | [
{
"diff_hunk": "@@ -1988,24 +1997,34 @@ def cast_array_to_feature(\n elif pa.types.is_struct(array.type):\n # feature must be a dict or Sequence(subfeatures_dict)\n if isinstance(feature, Sequence) and isinstance(feature.feature, dict):\n- feature = {\n- name: Seque... | 431694feddbfb98b44204bd6f8ce39022d3460f5 | diff --git a/docs/source/package_reference/main_classes.mdx b/docs/source/package_reference/main_classes.mdx
index 9c964bc56d5..86257f624b4 100644
--- a/docs/source/package_reference/main_classes.mdx
+++ b/docs/source/package_reference/main_classes.mdx
@@ -211,11 +211,13 @@ Dictionary with split names as keys ('train',... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
goauthentik__authentik-9959@95b00b9 | goauthentik/authentik | Python | 9,959 | stages/captcha: rework | <!--
👋 Hi there! Welcome.
Please check the Contributing guidelines: https://goauthentik.io/developer-docs/#how-can-i-contribute
-->
## Details
Adds a bunch of very dearly needed functionality to the captcha stage
- Score Min/Max threshold (by default set to match recaptcha recommendation)
- Continue/stop ... | 2024-06-03T15:32:20Z | How to use reCaptcha v3 with authentik
**Describe your question/**
How do I protect user login with a captcha ?
**Relevant infos**
I tried to protect user logins with a captcha. Therefore I created a new captcha stage and added the stage to the default-login-flow. However I was only able to create a reCaptcha Enterp... | [
{
"body": "**Describe your question/**\r\nHow do I protect user login with a captcha ?\r\n**Relevant infos**\r\nI tried to protect user logins with a captcha. Therefore I created a new captcha stage and added the stage to the default-login-flow. However I was only able to create a reCaptcha Enterpreise api key ... | 578ff1386869f9521850d05edacc3ae44688b5e5 | {
"head_commit": "95b00b942908170b71b5548dcf016b92c53997ef",
"head_commit_message": "stages/captcha: rework\n\nSigned-off-by: Jens Langhammer <jens@goauthentik.io>",
"patch_to_review": "diff --git a/authentik/stages/captcha/api.py b/authentik/stages/captcha/api.py\nindex 8d833197cdac..bd83c59f74d5 100644\n--- a/a... | [
{
"diff_hunk": "@@ -78,6 +78,40 @@ export class CaptchaStageForm extends BaseStageForm<CaptchaStage> {\n )}\n </p>\n </ak-form-element-horizontal>\n+ <ak-form-element-horizontal\n+ label=${msg(\"Sco... | e8ca1a3701bf597dc0807bebf4685f3a839bc437 | diff --git a/authentik/stages/captcha/api.py b/authentik/stages/captcha/api.py
index 8d833197cdac..bd83c59f74d5 100644
--- a/authentik/stages/captcha/api.py
+++ b/authentik/stages/captcha/api.py
@@ -12,7 +12,15 @@ class CaptchaStageSerializer(StageSerializer):
class Meta:
model = CaptchaStage
- f... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Documentation Updates"
} | |
huggingface__datasets-6754@fc151ec | huggingface/datasets | Python | 6,754 | Fix cache path to snakecase for `CachedDatasetModuleFactory` and `Cache` | Fix https://github.com/huggingface/datasets/issues/6750#issuecomment-2016678729
I didn't find a guideline on how to run the tests, so i just run the following steps to make sure that this bug is fixed.
1. `python test.py`,
2. then `HF_DATASETS_OFFLINE=1 python test.py`
The `test.py` is
```
import datasets
... | 2024-03-24T06:59:15Z | `load_dataset` requires a network connection for local download?
### Describe the bug
Hi all - I see that in the past a network dependency has been mistakenly introduced into `load_dataset` even for local loads. Is it possible this has happened again?
### Steps to reproduce the bug
```
>>> import datasets
>>> da... | Are you using `HF_DATASETS_OFFLINE=1` ?
> Are you using `HF_DATASETS_OFFLINE=1` ?
This doesn't work for me. `datasets=2.18.0`
`test.py`:
```
import datasets
datasets.utils.logging.set_verbosity_info()
ds = datasets.load_dataset('C-MTEB/AFQMC', revision='b44c3b011063adb25877c13823db83bb193913c4')
print(... | [
{
"body": "### Describe the bug\n\nHi all - I see that in the past a network dependency has been mistakenly introduced into `load_dataset` even for local loads. Is it possible this has happened again?\r\n\n\n### Steps to reproduce the bug\n\n```\r\n>>> import datasets\r\n>>> datasets.load_dataset(\"hh-rlhf\")\r... | a3bc89d8bfd47c2a175c3ce16d92b7307cdeafd6 | {
"head_commit": "fc151eca97fe4ad48b0cf04c09745b135d586bda",
"head_commit_message": "fix cache path snakecase",
"patch_to_review": "diff --git a/src/datasets/load.py b/src/datasets/load.py\nindex c08ad274acf..6e4849322b8 100644\n--- a/src/datasets/load.py\n+++ b/src/datasets/load.py\n@@ -1608,7 +1608,10 @@ def _g... | [
{
"diff_hunk": "@@ -1608,7 +1608,10 @@ def _get_modification_time(module_hash):\n }\n return DatasetModule(module_path, hash, builder_kwargs, importable_file_path=importable_file_path)\n cache_dir = os.path.expanduser(str(self.cache_dir or config.HF_DATASETS_CACHE))\n- cac... | 2528eae7e63e422568649b20f28d1705131d46f0 | diff --git a/src/datasets/load.py b/src/datasets/load.py
index 73068e153d2..6e3ebdcb1b7 100644
--- a/src/datasets/load.py
+++ b/src/datasets/load.py
@@ -1608,7 +1608,10 @@ def _get_modification_time(module_hash):
}
return DatasetModule(module_path, hash, builder_kwargs, importable_file_path=im... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
huggingface__datasets-6710@7c1ed43 | huggingface/datasets | Python | 6,710 | Persist IterableDataset epoch in workers | Use shared memory for the IterableDataset epoch.
This way calling `ds.set_epoch()` in the main process will update the epoch in the DataLoader workers as well.
This is useful especially because the epoch is used to compute the `effective_seed` used for shuffling.
I used torch's shared memory in case users want t... | 2024-03-02T12:08:50Z | IterableDataset `set_epoch` is ignored when DataLoader `persistent_workers=True`
### Describe the bug
When persistent workers are enabled, the epoch that's set via the IterableDataset instance held by the training process is ignored by the workers as they are disconnected across processes.
PyTorch samplers for no... | [
{
"body": "### Describe the bug\r\n\r\nWhen persistent workers are enabled, the epoch that's set via the IterableDataset instance held by the training process is ignored by the workers as they are disconnected across processes.\r\n\r\nPyTorch samplers for non-iterable datasets have a mechanism to sync this, dat... | 5cab892dcd26fb51938634e13e300c6611ab66e0 | {
"head_commit": "7c1ed43752eaa3ff4919900cf193f8b81f46ba18",
"head_commit_message": "Merge branch 'main' into persist-iterable-dataset-epoch-in-workers",
"patch_to_review": "diff --git a/src/datasets/iterable_dataset.py b/src/datasets/iterable_dataset.py\nindex 3d0b3ce1cf3..5e07ab23483 100644\n--- a/src/datasets/... | [
{
"diff_hunk": "@@ -1841,18 +1856,24 @@ def __getstate__(self):\n \n def __setstate__(self, d):\n self.__dict__ = d\n+ # Re-add torch shared memory, since shared mrmory are not always kept when pickling",
"line": null,
"original_line": 1859,
"original_start_line": null,
"path"... | a26470958d5f4a52f80862a94e7fce5efc1401f5 | diff --git a/src/datasets/iterable_dataset.py b/src/datasets/iterable_dataset.py
index 3d0b3ce1cf3..c23f45570b4 100644
--- a/src/datasets/iterable_dataset.py
+++ b/src/datasets/iterable_dataset.py
@@ -7,7 +7,7 @@
from dataclasses import dataclass
from functools import partial
from itertools import cycle, islice
-fro... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} | |
home-assistant__core-145515@172a6df | home-assistant/core | Python | 145,515 | Add support for HeatIt Thermostat TF056 to homee | <!--
You are amazing! Thanks for contributing to our project!
Please, DO NOT DELETE ANY TEXT from this template! (unless instructed).
-->
## Breaking change
## Proposed change
<!--
Describe the big picture of your changes here to communicate to the
maintainers why we should accept this pull request. I... | 2025-05-23T14:06:05Z | homee Integration - Heatit Thermostat TF056 is missing entities
### The problem
The Thermostat is missing the Thermostat entity and several sensors and configuration controls.
The homee yttributes for these are:
- TEMPERATURE_REPORT_INTERVAL
- EXTERNAL_TEMPERATURE
- FLOOR_TEMPERATURE
- EXTERNAL_TEMPERATURE_OFFSET
- FL... | [homee documentation](https://www.home-assistant.io/integrations/homee)
[homee source](https://github.com/home-assistant/core/tree/dev/homeassistant/components/homee) | [
{
"body": "### The problem\n\nThe Thermostat is missing the Thermostat entity and several sensors and configuration controls.\nThe homee yttributes for these are:\n- TEMPERATURE_REPORT_INTERVAL\n- EXTERNAL_TEMPERATURE\n- FLOOR_TEMPERATURE\n- EXTERNAL_TEMPERATURE_OFFSET\n- FLOOR_TEMPERATURE_OFFSET\n- DISPLAY_BRI... | 46dcc91510a4634d6ceab4418eb4b41e9f314c6e | {
"head_commit": "172a6df68d93a1c6da778bc2e7efde0b2c86e09f",
"head_commit_message": "Fix sentence case",
"patch_to_review": "diff --git a/homeassistant/components/homee/climate.py b/homeassistant/components/homee/climate.py\nindex 3411d31461c05..ef408d7e43713 100644\n--- a/homeassistant/components/homee/climate.p... | [
{
"diff_hunk": "@@ -83,15 +83,18 @@ def hvac_mode(self) -> HVACMode:\n if ClimateEntityFeature.TURN_OFF in self.supported_features and (\n self._heating_mode is not None\n ):\n- if self._heating_mode.current_value == 0:\n+ if self._heating_mode.current_value == ... | 437613fa1a20a68ee760994ad9ef2d325b39274b | diff --git a/homeassistant/components/homee/climate.py b/homeassistant/components/homee/climate.py
index 3411d31461c05a..f6027522243a29 100644
--- a/homeassistant/components/homee/climate.py
+++ b/homeassistant/components/homee/climate.py
@@ -83,7 +83,7 @@ def hvac_mode(self) -> HVACMode:
if ClimateEntityFeatu... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
goauthentik__authentik-9713@65dde8c | goauthentik/authentik | Python | 9,713 | website/integrations: add cloudflare access | <!--
👋 Hi there! Welcome.
Please check the Contributing guidelines: https://goauthentik.io/developer-docs/#how-can-i-contribute
-->
## Details
<!--
Explain what this PR changes, what the rationale behind the change is, if any new requirements are introduced or any breaking changes caused by this PR.
Ide... | 2024-05-13T22:39:17Z | Cloudflare Access Guide
**Is your feature request related to a problem? Please describe.**
A part of my selfhosted applications are running on Cloudflare Tunnels which allow easy protection with Access. Unfortunately, Authentik does not provide a guide on how to setup an "application" for CF Access.
**Describe the ... | [
{
"body": "**Is your feature request related to a problem? Please describe.**\r\nA part of my selfhosted applications are running on Cloudflare Tunnels which allow easy protection with Access. Unfortunately, Authentik does not provide a guide on how to setup an \"application\" for CF Access.\r\n\r\n**Describe t... | fd66be9fa2f40652200e13693f2c6a29c2faed3b | {
"head_commit": "65dde8caea9b48a86574746db284816855416472",
"head_commit_message": "Merge branch 'goauthentik:main' into docs/cf-access-service-setup",
"patch_to_review": "diff --git a/website/integrations/services/cloudflare-access/index.mdx b/website/integrations/services/cloudflare-access/index.mdx\nnew file ... | [
{
"diff_hunk": "@@ -0,0 +1,64 @@\n+---\n+title: Cloudflare Access\n+---\n+\n+<span class=\"badge badge--secondary\">Support level: Community</span>\n+\n+## What is Cloudflare Access\n+\n+> Cloudflare Access is a secure, cloud-based zero-trust solution for managing and authenticating user access to internal appl... | 8ee578503110e31ca403c8ff6edb078c7863be01 | diff --git a/website/integrations/services/cloudflare-access/index.mdx b/website/integrations/services/cloudflare-access/index.mdx
new file mode 100644
index 000000000000..cb34dcd96d4d
--- /dev/null
+++ b/website/integrations/services/cloudflare-access/index.mdx
@@ -0,0 +1,64 @@
+---
+title: Cloudflare Access
+---
+
+<... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "Documentation Updates"
} | |
goauthentik__authentik-5246@6dc9810 | goauthentik/authentik | Python | 5,246 | website/docs: separate docker steps | Separated the steps for generating a password and then writing it to the .env file. The steps were not working on a Mac when all together.
Resolves #5186
| 2023-04-13T20:34:54Z | Docs: make the password generation section in the Docker install docs more clear for Mac users
The current code block for installing a password generator, then generating a key and writing it to the .env file, is best broken into separate steps on a Mac. | [
{
"body": "The current code block for installing a password generator, then generating a key and writing it to the .env file, is best broken into separate steps on a Mac.",
"number": 5186,
"title": "Docs: make the password generation section in the Docker install docs more clear for Mac users"
}
] | c08c849fec800ca122c1317b532b272491761bfa | {
"head_commit": "6dc9810dd91b882ccf00b10c964d7c9e8faf6800",
"head_commit_message": "fixed formatting harder",
"patch_to_review": "diff --git a/website/docs/installation/docker-compose.md b/website/docs/installation/docker-compose.md\nindex 8185f335c28e..bb4787efbc60 100644\n--- a/website/docs/installation/docker... | [
{
"diff_hunk": "@@ -14,13 +14,18 @@ This installation method is for test-setups and small-scale production setups.\n \n Download the latest `docker-compose.yml` from [here](https://goauthentik.io/docker-compose.yml). Place it in a directory of your choice.\n \n-If this is a fresh authentik install run the follo... | a08b57718602697f29bdf439d26d5c7c69853d3a | diff --git a/website/docs/installation/docker-compose.md b/website/docs/installation/docker-compose.md
index 8185f335c28e..f7715ca3e0ec 100644
--- a/website/docs/installation/docker-compose.md
+++ b/website/docs/installation/docker-compose.md
@@ -14,20 +14,29 @@ This installation method is for test-setups and small-sca... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Documentation Updates"
} | |
goauthentik__authentik-9341@76789ca | goauthentik/authentik | Python | 9,341 | web: fix locale prioritization scheme | web: fix locale prioritization scheme
## Details
The locale priority algorithm had two problems: first, the order was incorrect, allowing the global default from globalAK() to override a lot of more precise settings; second, the algorithm would take outside locale overrides from the event handler, which was not n... | 2024-04-18T18:09:11Z | Locale Auto-detect doesn't work
**Describe the bug**
Using a browser configured in French, but Authentik is in English when locale is "Auto-detect".
**To Reproduce**
Steps to reproduce the behavior:
1. Got to Authentik with a French browser
2. View Authentik UI in English
**Expected behavior**
Authentik UI i... | Can you run `navigator.language || navigator.userLanguage` in the browser's developer console and post the output?
In Firefox:
"fr"
In Chrome:
'fr-FR'
same problem for me with 2023.2
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity ... | [
{
"body": "**Describe the bug**\r\nUsing a browser configured in French, but Authentik is in English when locale is \"Auto-detect\".\r\n\r\n**To Reproduce**\r\nSteps to reproduce the behavior:\r\n1. Got to Authentik with a French browser\r\n2. View Authentik UI in English\r\n\r\n**Expected behavior**\r\nAuthent... | 0932622567af5c9264c230cee41f9bbe830fc0b6 | {
"head_commit": "76789cab1994f6dd5fbb0ec9923656ea990f1401",
"head_commit_message": "web: fix locale prioritization scheme\n\nThe locale priority algorithm had two problems: first, the order was incorrect, allowing the global\ndefault from globalAK() to override a lot of more precise settings; second, the algorithm... | [
{
"diff_hunk": "@@ -59,8 +63,11 @@ export class LocaleContext extends LitElement {\n \n connectedCallback() {\n super.connectedCallback();\n- const localeRequest = autoDetectLanguage(this.locale);\n- this.updateLocale(localeRequest);\n+ new CoreApi(DEFAULT_CONFIG)\n+ ... | ace574db9c93444cf418554a1947c18bfd201199 | diff --git a/web/src/elements/ak-locale-context/ak-locale-context.ts b/web/src/elements/ak-locale-context/ak-locale-context.ts
index 810b001999e2..17e67d5e1fd2 100644
--- a/web/src/elements/ak-locale-context/ak-locale-context.ts
+++ b/web/src/elements/ak-locale-context/ak-locale-context.ts
@@ -1,18 +1,15 @@
-import { E... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
home-assistant__core-141783@3b77d48 | home-assistant/core | Python | 141,783 | Set and check unique id of config in NUT | <!--
You are amazing! Thanks for contributing to our project!
Please, DO NOT DELETE ANY TEXT from this template! (unless instructed).
-->
## Proposed change
<!--
Describe the big picture of your changes here to communicate to the
maintainers why we should accept this pull request. If it fixes a bug
or... | 2025-03-30T04:48:20Z | Can't create second NUT instance
### The problem
I have a problem adding a second UPS.
My setup is as follows :
I have 2 identical UPS's, one is connected to the HA instance, named myups, using the nut add on
The second UPS is connected to a linux box, and named myups3. Both UPS's are connected using USB
In the nu... | Hey there @bdraco, @ollo69, @pestevez, @tdfountain, mind taking a look at this issue as it has been labeled with an integration (`nut`) you are listed as a [code owner](https://github.com/home-assistant/core/blob/dev/CODEOWNERS#L1056) for? Thanks!
<details>
<summary>Code owner commands</summary>
Code owners of `nut`... | [
{
"body": "### The problem\n\nI have a problem adding a second UPS.\n\nMy setup is as follows : \n\nI have 2 identical UPS's, one is connected to the HA instance, named myups, using the nut add on\nThe second UPS is connected to a linux box, and named myups3. Both UPS's are connected using USB\n\nIn the nut int... | 3ab2cd3fb7c29f11fc09506cd62834a0f27b882b | {
"head_commit": "3b77d48e3176287fa8ad1ca89124870ba693a013",
"head_commit_message": "Add unique ID check to config flow step for UPS",
"patch_to_review": "diff --git a/homeassistant/components/nut/__init__.py b/homeassistant/components/nut/__init__.py\nindex dc260dffe9657a..375c38b3e2a398 100644\n--- a/homeassist... | [
{
"diff_hunk": "@@ -122,6 +122,9 @@ async def async_update_data() -> dict[str, str]:\n if unique_id is None:\n unique_id = entry.entry_id\n \n+ if entry.unique_id is None:",
"line": null,
"original_line": 125,
"original_start_line": null,
"path": "homeassistant/components/nut/__in... | c1b4e4bdf78a053dc359c993b650fc8dcc2e3920 | diff --git a/homeassistant/components/nut/__init__.py b/homeassistant/components/nut/__init__.py
index e9d6f41f8d862..3c67b28196a31 100644
--- a/homeassistant/components/nut/__init__.py
+++ b/homeassistant/components/nut/__init__.py
@@ -121,6 +121,9 @@ async def async_update_data() -> dict[str, str]:
if unique_id ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
huggingface__datasets-5859@718ede6 | huggingface/datasets | Python | 5,859 | Raise TypeError when indexing a dataset with bool | Fix #5858. | 2023-05-15T08:08:42Z | Throw an error when dataset improperly indexed
### Describe the bug
Pandas-style subset indexing on dataset does not throw an error, when maybe it should. Instead returns the first instance of the dataset regardless of index condition.
### Steps to reproduce the bug
Steps to reproduce the behavior:
1. `squad = da... | Thanks for reporting, @sarahwie.
Please note that in `datasets` we do not have vectorized operation like `pandas`. Therefore, your equality comparisons above are `False`:
- For example: `squad['question']` returns a `list`, and this list is not equal to `"Who was the Norse leader?"`
The `False` value is equivale... | [
{
"body": "### Describe the bug\n\nPandas-style subset indexing on dataset does not throw an error, when maybe it should. Instead returns the first instance of the dataset regardless of index condition.\n\n### Steps to reproduce the bug\n\nSteps to reproduce the behavior:\r\n\r\n1. `squad = datasets.load_datase... | db56f7f0d2f0b99af4da17d388c205152504c7d9 | {
"head_commit": "718ede64b5f7072f200399575d9148766eca300a",
"head_commit_message": "Remove sequence of bool from signature",
"patch_to_review": "diff --git a/src/datasets/arrow_dataset.py b/src/datasets/arrow_dataset.py\nindex 93637e2d839..9b1d86310cb 100644\n--- a/src/datasets/arrow_dataset.py\n+++ b/src/datase... | [
{
"diff_hunk": "@@ -2742,10 +2743,12 @@ def prepare_for_task(self, task: Union[str, TaskTemplate], id: int = 0) -> \"Data\n dataset = dataset.cast(features=template.features)\n return dataset\n \n- def _getitem(self, key: Union[int, slice, str], **kwargs) -> Union[Dict, List]:\n+ def _geti... | 999f46090de7b44dc980dbba0398443f9c5b3c91 | diff --git a/src/datasets/arrow_dataset.py b/src/datasets/arrow_dataset.py
index 93637e2d839..ad4a6f712e6 100644
--- a/src/datasets/arrow_dataset.py
+++ b/src/datasets/arrow_dataset.py
@@ -115,7 +115,7 @@
from .utils.py_utils import Literal, asdict, convert_file_size_to_int, iflatmap_unordered, unique_values
from .ut... | {
"difficulty": "medium",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
goauthentik__authentik-2818@56183fd | goauthentik/authentik | Python | 2,818 | Addition of form_post OIDC response mode | # Details
Resolves #2748
## Changes
### New Features
* Adds support for form_post response mode, required for Azure-compatibility
### Breaking Changes
None
## Additional Details
-
| 2022-05-06T05:45:03Z | FR: Support for response_mode: form_post
**Is your feature request related to a problem? Please describe.**
We have a client application that is meant to use Azure as an IDP, and I've managed to customize most of the authentik flow to be able to use Authentik as a provider. The last part of this is that the OpenID Con... | After looking at it for a bit, would maybe @BeryJu be able to provide a (very brief) representation of how the OIDC-flow, mostly the latter stages moves through the code?
My thinking at the moment is I'd have to amend the ResponseMode in providers/oauth2/models.py with form_post, modifying OauthFulfillmentStage pro... | [
{
"body": "**Is your feature request related to a problem? Please describe.**\r\nWe have a client application that is meant to use Azure as an IDP, and I've managed to customize most of the authentik flow to be able to use Authentik as a provider. The last part of this is that the OpenID Connect/Oauth2-provider... | 8f861d8ecbdbd77b4911fc94004869c4eb63e924 | {
"head_commit": "56183fdfb5c0be7032c65fbd59bf290caddd5327",
"head_commit_message": "Added class OauthPostFulfillmentStage\r\nCheck response_mode in initialization",
"patch_to_review": "diff --git a/authentik/providers/oauth2/models.py b/authentik/providers/oauth2/models.py\nindex 28a7ac91cbb1..f85887662ddb 10064... | [
{
"diff_hunk": "@@ -238,6 +256,131 @@ def create_code(self, request: HttpRequest) -> AuthorizationCode:\n \n return code\n \n+class OAuthPostFulfillmentStage(ChallengeStageView):",
"line": null,
"original_line": 259,
"original_start_line": null,
"path": "authentik/providers/oauth2/views/... | df2ebed8aa7c9134cc4ae9ed47465a0c8b284523 | diff --git a/authentik/providers/oauth2/models.py b/authentik/providers/oauth2/models.py
index 28a7ac91cbb1..f85887662ddb 100644
--- a/authentik/providers/oauth2/models.py
+++ b/authentik/providers/oauth2/models.py
@@ -50,6 +50,7 @@ class ResponseMode(models.TextChoices):
QUERY = "query"
FRAGMENT = "fragmen... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
goauthentik__authentik-2406@cd38ea8 | goauthentik/authentik | Python | 2,406 | added example for custom user attributes | <!--
👋 Hello there! Welcome.
Please check the [Contributing guidelines](https://github.com/goauthentik/authentik/blob/master/CONTRIBUTING.md#how-can-i-contribute).
-->
# Details
* **Does this resolve an issue?**
Resolves #2405
## Changes
### New Features
* extend documentation
### Breaking Changes
... | 2022-02-28T09:37:41Z | Custom User attribute in Scope Mapping
**Is your feature request related to a problem? Please describe.**
We wanted to add a custom attribute to the access token. Unfortunately we searched for a long time because we could not find an example in the documentation.
We created a pull request for the documentation.
... | [
{
"body": "**Is your feature request related to a problem? Please describe.**\r\nWe wanted to add a custom attribute to the access token. Unfortunately we searched for a long time because we could not find an example in the documentation.\r\n\r\nWe created a pull request for the documentation.\r\n\r\n**Describe... | a3df414f24b0ce66d32600405ee674edba7c6bf6 | {
"head_commit": "cd38ea89c1b48c1328b822777888a22c8a729a8f",
"head_commit_message": "added example for custom user attributes",
"patch_to_review": "diff --git a/website/docs/expressions/_user.md b/website/docs/expressions/_user.md\nnew file mode 100644\nindex 000000000000..1b372a2ffa9a\n--- /dev/null\n+++ b/websi... | [
{
"diff_hunk": "@@ -0,0 +1,10 @@\n+- `user`: The current user. This may be `None` if there is no contextual user. See ([User](../user-group/user.md#object-attributes))\n+\n+Example:\n+\n+```python\n+if not 'custom_attribute' in request.user.attributes:\n+ return {'custom_attribute': 'default'}\n+\n+return {\"c... | 4c7c57038c5841429e14f1a4b7ecdb9346b0df55 | diff --git a/website/docs/expressions/_user.md b/website/docs/expressions/_user.md
new file mode 100644
index 000000000000..aab77387fc19
--- /dev/null
+++ b/website/docs/expressions/_user.md
@@ -0,0 +1,9 @@
+- `user`: The current user. This may be `None` if there is no contextual user. See ([User](../user-group/user.md... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "Documentation Updates"
} | |
huggingface__datasets-5516@dbccc74 | huggingface/datasets | Python | 5,516 | Reload features from Parquet metadata | Resolves #5482.
Attaches feature metadata to parquet files serialised using `Dataset.to_parquet`.
This allows retrieving data with "rich" feature types (e.g., `datasets.features.image.Image` or `datasets.features.audio.Audio`) from parquet files without cumbersome casting (for an example, see #5482).
@lhoest... | 2023-02-09T10:52:15Z | Reload features from Parquet metadata
The idea would be to allow this :
```python
ds.to_parquet("my_dataset/ds.parquet")
reloaded = load_dataset("my_dataset")
assert ds.features == reloaded.features
```
And it should also work with Image and Audio types (right now they're reloaded as a dict type)
This can be... | I'd be happy to have a look, if nobody else has started working on this yet @lhoestq.
It seems to me that for the `arrow` format features are currently attached as metadata [in `datasets.arrow_writer`](https://github.com/huggingface/datasets/blob/5f810b7011a8a4ab077a1847c024d2d9e267b065/src/datasets/arrow_writer.py... | [
{
"body": "The idea would be to allow this :\r\n```python \r\nds.to_parquet(\"my_dataset/ds.parquet\")\r\nreloaded = load_dataset(\"my_dataset\")\r\nassert ds.features == reloaded.features \r\n```\r\nAnd it should also work with Image and Audio types (right now they're reloaded as a dict type)\r\n\r\nThis can b... | b065547654efa0ec633cf373ac1512884c68b2e1 | {
"head_commit": "dbccc743aeb83b7a979d0b0f4174a4af36626aa0",
"head_commit_message": "removed unused import",
"patch_to_review": "diff --git a/src/datasets/io/parquet.py b/src/datasets/io/parquet.py\nindex 357c77e9105..b5e62a09b8c 100644\n--- a/src/datasets/io/parquet.py\n+++ b/src/datasets/io/parquet.py\n@@ -1,7 ... | [
{
"diff_hunk": "@@ -130,3 +132,20 @@ def test_parquer_write(dataset, tmp_path):\n pf = pq.ParquetFile(tmp_path / \"foo.parquet\")\n output_table = pf.read()\n assert dataset.data.table == output_table\n+\n+\n+@require_pil\n+def test_dataset_to_parquet_keeps_features(shared_datadir, tmp_path):\n+ ... | 6a25f717030de10d8673c10bd9c38ea42d21f2b1 | diff --git a/src/datasets/io/parquet.py b/src/datasets/io/parquet.py
index 357c77e9105..b5e62a09b8c 100644
--- a/src/datasets/io/parquet.py
+++ b/src/datasets/io/parquet.py
@@ -1,7 +1,6 @@
import os
from typing import BinaryIO, Optional, Union
-import pyarrow as pa
import pyarrow.parquet as pq
from .. import Da... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
huggingface__datasets-5515@416369b | huggingface/datasets | Python | 5,515 | Unify `load_from_cache_file` type and logic | * Updating type annotations for #`load_from_cache_file`
* Added logic for cache checking if needed
* Updated documentation following the wording of `Dataset.map` | 2023-02-09T10:04:46Z | Improve inconsistency of `Dataset.map` interface for `load_from_cache_file`
### Feature request
1. Replace the `load_from_cache_file` default value to `True`.
2. Remove or alter checks from `is_caching_enabled` logic.
### Motivation
I stumbled over an inconsistency in the `Dataset.map` interface. The documentati... | Hi, thanks for noticing this! We can't just remove the cache control as this allows us to control where the arrow files generated by the ops are written (cached on disk if enabled or a temporary directory if disabled). The right way to address this inconsistency would be by having `load_from_cache_file=None` by default... | [
{
"body": "### Feature request\n\n\r\n1. Replace the `load_from_cache_file` default value to `True`. \r\n2. Remove or alter checks from `is_caching_enabled` logic.\n\n### Motivation\n\nI stumbled over an inconsistency in the `Dataset.map` interface. The documentation (and source) states for the parameter `load_... | 004bba88db03fb87d57252e38a4d7abdb0a5f0a9 | {
"head_commit": "416369b4ef477fa1b528010e43f8fc0803a14822",
"head_commit_message": "* Updating type annotations for `load_from_cache_file`\n* Added logic for cache checking if needed\n* Updated documentation following the wording of `Dataset.map`",
"patch_to_review": "diff --git a/src/datasets/arrow_dataset.py b... | [
{
"diff_hunk": "@@ -2960,7 +2960,7 @@ def _map_single(\n drop_last_batch: bool = False,\n remove_columns: Optional[List[str]] = None,\n keep_in_memory: bool = False,\n- load_from_cache_file: bool = None,\n+ load_from_cache_file: Optional[bool] = None,",
"line": null,
... | fceac09381fecca17689eec6d6116faf8d809135 | diff --git a/src/datasets/arrow_dataset.py b/src/datasets/arrow_dataset.py
index 6d017dd6765..0ee90d5b94e 100644
--- a/src/datasets/arrow_dataset.py
+++ b/src/datasets/arrow_dataset.py
@@ -1837,7 +1837,7 @@ def cast(
features: Features,
batch_size: Optional[int] = 1000,
keep_in_memory: bool =... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Code Refactoring / Architectural Improvement"
} |
goauthentik__authentik-4822@ea01e3a | goauthentik/authentik | Python | 4,822 | stages/prompt: Add Radio Button Group, Dropdown and Text Area prompt fields | <!--
👋 Hello there! Welcome.
Please check the [Contributing guidelines](https://github.com/goauthentik/authentik/blob/main/CONTRIBUTING.md#how-can-i-contribute).
-->
# Details
* **Does this resolve an issue?**
Resolves #4352
Resolves #2521
Resolves #4841
## Changes
### New Features
* Adds radio-butto... | 2023-03-01T19:00:13Z | Additional prompt field types
**Is your feature request related to a problem? Please describe.**
Not really.
**Describe the solution you'd like**
Some additional field types would make the user experience nicer and allow for new possibilities, in particular:
- List with options for checkboxes, dropdown, radio b... | After recreating my recovery flow, I now have a need for a dropdown, combobox, or similar, so that users can pick what MFA they want to recover with. I currently use strings emitted with a policy as well.
Related: #2521 | [
{
"body": "**Is your feature request related to a problem? Please describe.**\r\nNot really.\r\n\r\n**Describe the solution you'd like**\r\nSome additional field types would make the user experience nicer and allow for new possibilities, in particular:\r\n\r\n- List with options for checkboxes, dropdown, radio ... | 63e3f6545bd0d3cf036e56d93d30add9f57ceaa0 | {
"head_commit": "ea01e3a75062618988789419704971495ce3223d",
"head_commit_message": "Add text-area prompts",
"patch_to_review": "diff --git a/authentik/policies/password/tests/test_flows.py b/authentik/policies/password/tests/test_flows.py\nindex 42e1ae5587b2..bdf661b46a2d 100644\n--- a/authentik/policies/passwor... | [
{
"diff_hunk": "@@ -115,8 +136,46 @@ def serializer(self) -> Type[BaseSerializer]:\n \n return PromptSerializer\n \n+ def get_choices(\n+ self, prompt_context: dict, user: User, request: HttpRequest\n+ ) -> Optional[tuple[dict[str, Any]]]:\n+ \"\"\"Get fully interpolated list of choi... | 2dda02a2700199bc4f4da94cb1f4f22400ee91d2 | diff --git a/authentik/policies/password/tests/test_flows.py b/authentik/policies/password/tests/test_flows.py
index 42e1ae5587b2..bdf661b46a2d 100644
--- a/authentik/policies/password/tests/test_flows.py
+++ b/authentik/policies/password/tests/test_flows.py
@@ -54,6 +54,7 @@ def test_prompt_data(self):
co... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
huggingface__datasets-5410@78dca62 | huggingface/datasets | Python | 5,410 | Map-style Dataset to IterableDataset | Added `ds.to_iterable()` to get an iterable dataset from a map-style arrow dataset.
It also has a `num_shards` argument to split the dataset before converting to an iterable dataset. Sharding is important to enable efficient shuffling and parallel loading of iterable datasets.
TODO:
- [x] tests
- [x] docs
Fi... | 2023-01-05T18:12:17Z | Get an IterableDataset from a map-style Dataset
This is useful to leverage iterable datasets specific features like:
- fast approximate shuffling
- lazy map, filter etc.
Iterating over the resulting iterable dataset should be at least as fast at iterating over the map-style dataset.
Here are some ideas regardin... | I think `stream` could be misleading since the data is not being streamed from remote endpoints (one could think that's the case when they see `load_dataset` followed by `stream`). Hence, I prefer the second option.
PS: When we resolve https://github.com/huggingface/datasets/issues/4542, we could add `as_tf_dataset`... | [
{
"body": "This is useful to leverage iterable datasets specific features like:\r\n- fast approximate shuffling\r\n- lazy map, filter etc.\r\n\r\nIterating over the resulting iterable dataset should be at least as fast at iterating over the map-style dataset.\r\n\r\nHere are some ideas regarding the API:\r\n```... | 053f51a3e2adb762236eb29dd02791307f45f02f | {
"head_commit": "78dca62e8aaddb9e0cf0212841f2c8d861fe74c8",
"head_commit_message": "style",
"patch_to_review": "diff --git a/docs/source/_toctree.yml b/docs/source/_toctree.yml\nindex 0d2fe5c7ac5..adfbc7637b2 100644\n--- a/docs/source/_toctree.yml\n+++ b/docs/source/_toctree.yml\n@@ -95,6 +95,8 @@\n title: D... | [
{
"diff_hunk": "@@ -4643,6 +4672,120 @@ def extra_nbytes_visitor(array, feature):\n dataset_nbytes = dataset_nbytes * len(self._indices) / len(self.data)\n return dataset_nbytes\n \n+ @staticmethod\n+ def _iter_shards(shards: List[\"Dataset\"]):\n+ for shard in shards:\n+ ... | cd7877892aa48a2470b01f52013390c54aca8a49 | diff --git a/docs/source/_toctree.yml b/docs/source/_toctree.yml
index 0d2fe5c7ac5..adfbc7637b2 100644
--- a/docs/source/_toctree.yml
+++ b/docs/source/_toctree.yml
@@ -95,6 +95,8 @@
title: Datasets 🤝 Arrow
- local: about_cache
title: The cache
+ - local: about_mapstyle_vs_iterable
+ title: Dataset or... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
goauthentik__authentik-7410@fbd1ab0 | goauthentik/authentik | Python | 7,410 | core: add user settable token durations | ## Details
This PR enables users to specify a non default lifetime for users created app application token. By the way, it enforces expires value on API side.
Closes #5881
Current limitation : maximum duration is currently not enforce in the UI but only on API side. This is because I haven't find yet an easy ... | 2023-11-02T02:15:34Z | Allow end users to create app passwords with longer (or no) expiry
**Is your feature request related to a problem? Please describe.**
So I have calibre-web authenticating to authentik via LDAP (for it's OPDS function). With MFA enabled, ideally that would use an app password. However, user created app passwords have a... | I second this, having no way to extend the expiration past 30 minutes makes App Passwords unusable for purposes other than evaluation.
Also if it's not too much trouble, I think it would be a good idea to have a configurable policy for this where administrators can set min/max/default expiration time. Maybe for Toke... | [
{
"body": "**Is your feature request related to a problem? Please describe.**\r\nSo I have calibre-web authenticating to authentik via LDAP (for it's OPDS function). With MFA enabled, ideally that would use an app password. However, user created app passwords have a (fixed?) lifetime of 30 minutes which is not ... | 633028c8ff40a32a49c03a857b30ecbd3e91f490 | {
"head_commit": "fbd1ab0c428d73adcd17c9c45256abc295f22fe1",
"head_commit_message": "lint-fix\n\nSigned-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>",
"patch_to_review": "diff --git a/authentik/core/api/tokens.py b/authentik/core/api/tokens.py\nindex 9c94992c5706..5fb185cacb64 100644\n--- a/authentik... | [
{
"diff_hunk": "@@ -624,12 +643,17 @@ class Meta:\n class ExpiringModel(models.Model):\n \"\"\"Base Model which can expire, and is automatically cleaned up.\"\"\"\n \n- expires = models.DateTimeField(default=default_token_duration)\n+ expires = models.DateTimeField(default=None, null=True)\n expir... | 12736d043930867b0507ec6dacb986f346099f13 | diff --git a/authentik/core/api/tokens.py b/authentik/core/api/tokens.py
index 9c94992c5706..5fb185cacb64 100644
--- a/authentik/core/api/tokens.py
+++ b/authentik/core/api/tokens.py
@@ -20,9 +20,18 @@
from authentik.core.api.used_by import UsedByMixin
from authentik.core.api.users import UserSerializer
from authent... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
huggingface__datasets-5169@a9e32e4 | huggingface/datasets | Python | 5,169 | Add "ipykernel" to list of `co_filename`s to remove | Should resolve #5157 | 2022-10-27T05:56:17Z | Consistent caching between python and jupyter
### Feature request
I hope this is not my mistake, currently if I use `load_dataset` from a python session on a custom dataset to do the preprocessing, it will be saved in the cache and in other python sessions it will be loaded from the cache, however calling the same fro... | Hi ! Maybe it's possible to have a consistent hash for a function defined in `__main__` and a function define in a notebook.
However for functions imported from another location, pickle uses the location to identify the code, so in that case we can't do much I believe.
Would it be ok for you if we only try to do ... | [
{
"body": "### Feature request\n\nI hope this is not my mistake, currently if I use `load_dataset` from a python session on a custom dataset to do the preprocessing, it will be saved in the cache and in other python sessions it will be loaded from the cache, however calling the same from a jupyter notebook does... | ff5bd84fac270095f908eae36faf5dcec496567a | {
"head_commit": "a9e32e45c143fbe98a858f0dd54ada28f0ea841a",
"head_commit_message": "add ipykernel to co_filename to ignore",
"patch_to_review": "diff --git a/src/datasets/utils/py_utils.py b/src/datasets/utils/py_utils.py\nindex c4b7152307e..ca86ab4b117 100644\n--- a/src/datasets/utils/py_utils.py\n+++ b/src/dat... | [
{
"diff_hunk": "@@ -657,7 +657,9 @@ def _save_code(pickler, obj):\n #\n # Only those two lines are different from the original implementation:\n co_filename = (\n- \"\" if obj.co_filename.startswith(\"<\") or obj.co_name == \"<lambda>\" else os.path.basename(obj.co_filename)\n+ \"\"\n+... | 434df72080efc5f460afdafa689e9ea8a36119b4 | diff --git a/src/datasets/features/audio.py b/src/datasets/features/audio.py
index 69ab8625596..b257331c350 100644
--- a/src/datasets/features/audio.py
+++ b/src/datasets/features/audio.py
@@ -18,6 +18,9 @@
from .features import FeatureType
+_ffmpeg_warned, _librosa_warned, _audioread_warned = False, False, Fa... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "New Feature Additions"
} |
home-assistant__core-140135@1fad630 | home-assistant/core | Python | 140,135 | Delete subscription on shutdown of SmartThings | <!--
You are amazing! Thanks for contributing to our project!
Please, DO NOT DELETE ANY TEXT from this template! (unless instructed).
-->
## Proposed change
<!--
Describe the big picture of your changes here to communicate to the
maintainers why we should accept this pull request. If it fixes a bug
or... | 2025-03-08T17:18:53Z | Smartthing entities stopped updating
### The problem
Since the last HA core release the smart things zigbee temp sensor stopped updating its temp. same with switches, when turned switch on/off in HA, it turned on in real, but no status (on/off) updates from smartthings. Probably it stopped polling ST entities auto for... | Hey there @joostlek, mind taking a look at this issue as it has been labeled with an integration (`smartthings`) you are listed as a [code owner](https://github.com/home-assistant/core/blob/dev/CODEOWNERS#L1404) for? Thanks!
<details>
<summary>Code owner commands</summary>
Code owners of `smartthings` can trigger bo... | [
{
"body": "### The problem\n\nSince the last HA core release the smart things zigbee temp sensor stopped updating its temp. same with switches, when turned switch on/off in HA, it turned on in real, but no status (on/off) updates from smartthings. Probably it stopped polling ST entities auto for state changes\n... | 8edecd8671b033edf44d9cf99700397a9b66a717 | {
"head_commit": "1fad6302c00fd71263bcade4fecbc76cb46ed501",
"head_commit_message": "Fix",
"patch_to_review": "diff --git a/homeassistant/components/smartthings/__init__.py b/homeassistant/components/smartthings/__init__.py\nindex 3e0e66e890f56..d7c26e3a51d98 100644\n--- a/homeassistant/components/smartthings/__i... | [
{
"diff_hunk": "@@ -100,16 +103,44 @@ async def _refresh_token() -> str:\n \n client.refresh_token_function = _refresh_token\n \n+ def _handle_new_subscription_url(url: str) -> None:\n+ \"\"\"Handle a new subscription URL.\"\"\"\n+ hass.config_entries.async_update_entry(\n+ entry... | 0ac8bb9e64fbe6fec932b47e2080fd32385852ab | diff --git a/homeassistant/components/smartthings/__init__.py b/homeassistant/components/smartthings/__init__.py
index 9b9494dd9c5363..f95719a8d0211f 100644
--- a/homeassistant/components/smartthings/__init__.py
+++ b/homeassistant/components/smartthings/__init__.py
@@ -16,12 +16,18 @@
Scene,
SmartThings,
... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
huggingface__datasets-5142@561dbd1 | huggingface/datasets | Python | 5,142 | Deprecate num_proc parameter in DownloadManager.extract | fixes #5132 : Deprecated the `num_proc` parameter in `DownloadManager.extract` by passing `num_proc` parameter to `map_nested` . | 2022-10-20T09:52:52Z | Depracate `num_proc` parameter in `DownloadManager.extract`
The `num_proc` parameter is only present in `DownloadManager.extract` but not in `StreamingDownloadManager.extract`, making it impossible to support streaming in the dataset scripts that use it (`openwebtext` and `the_pile_stack_exchange`). We can avoid this s... | I can take this! #self-assign
#self-assign
@lazarust i'm already working on this issue :smile:
#self-assign | [
{
"body": "The `num_proc` parameter is only present in `DownloadManager.extract` but not in `StreamingDownloadManager.extract`, making it impossible to support streaming in the dataset scripts that use it (`openwebtext` and `the_pile_stack_exchange`). We can avoid this situation by deprecating this parameter an... | cd55ad067a8937650b89a90c672de29b49de1897 | {
"head_commit": "561dbd1834fa1ad4a5344d57d96cac2ff686eeac",
"head_commit_message": "deprecate num_proc",
"patch_to_review": "diff --git a/src/datasets/download/download_manager.py b/src/datasets/download/download_manager.py\nindex ef06e6a7fe3..06f7534fcaa 100644\n--- a/src/datasets/download/download_manager.py\n... | [
{
"diff_hunk": "@@ -377,7 +377,7 @@ def iter_files(self, paths: Union[str, List[str]]):\n \"\"\"\n return FilesIterable.from_paths(paths)\n \n- def extract(self, path_or_paths, num_proc=None):\n+ def extract(self, path_or_paths):",
"line": null,
"original_line": 380,
"original_... | 3523f4e0c3113425970a095078c8d77055ebead1 | diff --git a/src/datasets/download/download_manager.py b/src/datasets/download/download_manager.py
index ef06e6a7fe3..5da652c88dd 100644
--- a/src/datasets/download/download_manager.py
+++ b/src/datasets/download/download_manager.py
@@ -20,6 +20,7 @@
import os
import posixpath
import tarfile
+import warnings
from d... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Code Refactoring / Architectural Improvement"
} |
huggingface__datasets-4971@f7d909a | huggingface/datasets | Python | 4,971 | Preserve non-`input_colums` in `Dataset.map` if `input_columns` are specified | Currently, if the `input_columns` list in `Dataset.map` is specified, the columns not in that list are dropped after the `map` transform.
This makes the behavior inconsistent with `IterableDataset.map`.
(It seems this issue was introduced by mistake in https://github.com/huggingface/datasets/pull/2246)
Fix h... | 2022-09-12T18:08:24Z | map() function removes columns when input_columns is not None
## Describe the bug
The map function, removes features from the dataset that are not present in the _input_columns_ list of columns, despite the columns being removed not mentioned in the _remove_columns_ argument.
## Steps to reproduce the bug
```python
... | [
{
"body": "## Describe the bug\r\nThe map function, removes features from the dataset that are not present in the _input_columns_ list of columns, despite the columns being removed not mentioned in the _remove_columns_ argument.\r\n## Steps to reproduce the bug\r\n```python\r\nfrom datasets import Dataset\r\nds... | acf02e74be95e19bc214afe1b39fa03e52f4d0f2 | {
"head_commit": "f7d909a408a32ac3951f3765b22e471b0c7d416f",
"head_commit_message": "Remove unnecessary assert",
"patch_to_review": "diff --git a/src/datasets/arrow_dataset.py b/src/datasets/arrow_dataset.py\nindex edca235535a..9f2f0403dd5 100644\n--- a/src/datasets/arrow_dataset.py\n+++ b/src/datasets/arrow_data... | [
{
"diff_hunk": "@@ -1341,6 +1341,18 @@ def func(example):\n )\n self.assertListEqual(dset_test[0][\"tensor\"], [1, 2, 3])\n \n+ def test_map_input_columns(self, in_memory):\n+ with tempfile.TemporaryDirectory() as tmp_dir:\n+ with self._create_dummy_d... | 94fbb21280856a3bf93cc429016e1e3b85511e81 | diff --git a/src/datasets/arrow_dataset.py b/src/datasets/arrow_dataset.py
index edca235535a..0e2fe0cb472 100644
--- a/src/datasets/arrow_dataset.py
+++ b/src/datasets/arrow_dataset.py
@@ -2666,7 +2666,7 @@ def apply_function_on_filtered_inputs(inputs, indices, check_same_num_examples=F
validate_functi... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
iterative__dvc-10749@bc093c5 | iterative/dvc | Python | 10,749 | feat: ignore files not in remote when push is false | Fixes #10317
Enables opt-in to remove `push: false` stage outputs from `not_in_remote` data status results.
Notable changes:
- Add `outs_no_push` to `dvc.stage.utils.fill_stage_outputs` keys, to facilitate making outputs with `push: false`.
- In `status`, when flag enabled, filter through files reported as `no... | 2025-05-22T11:24:01Z | data status returns files as "Not in remote" even though they are marked as push: false in pipeline
# Bug Report
<!--
## data status: incorrectly marks files as "Not in remote"
-->
## Description
`dvc data status --not-in-remote` is used to determine if some files haven't been pushed up to remote storage. In... | This affects us as well. Has there been any progress on this?
I've started drafting a PR for this. Will update when/if I have the time.
Update: #10749 is now ready for review. | [
{
"body": "# Bug Report\r\n\r\n<!--\r\n## data status: incorrectly marks files as \"Not in remote\"\r\n-->\r\n\r\n## Description\r\n\r\n`dvc data status --not-in-remote` is used to determine if some files haven't been pushed up to remote storage. In a CI/CD context it is a useful check before accepting a PR. If... | c7c7ba69fbe093b0889228119964f357653e6973 | {
"head_commit": "bc093c50434e70bd87756b271bfe5257aaaa2339",
"head_commit_message": "Refactor test to use convention",
"patch_to_review": "diff --git a/dvc/repo/data.py b/dvc/repo/data.py\nindex bc727c88c7..6387587f7e 100644\n--- a/dvc/repo/data.py\n+++ b/dvc/repo/data.py\n@@ -4,6 +4,7 @@\n from typing import TYP... | [
{
"diff_hunk": "@@ -234,10 +251,21 @@ def status(repo: \"Repo\", untracked_files: str = \"no\", **kwargs: Any) -> Status:\n git_info = _git_info(repo.scm, untracked_files=untracked_files)\n untracked = git_info.get(\"untracked\", [])\n untracked = _transform_git_paths_to_dvc(repo, untracked)\n+\n+ ... | b6b18ef4d7084ac49acf7644cb2b45b8d73a192c | diff --git a/dvc/repo/data.py b/dvc/repo/data.py
index bc727c88c7..b31d43da72 100644
--- a/dvc/repo/data.py
+++ b/dvc/repo/data.py
@@ -4,6 +4,7 @@
from typing import TYPE_CHECKING, Any, TypedDict, Union
from dvc.fs.callbacks import DEFAULT_CALLBACK
+from dvc.repo.worktree import worktree_view
from dvc.ui import ui... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
huggingface__datasets-4926@a1df085 | huggingface/datasets | Python | 4,926 | Dataset infos in yaml | To simplify the addition of new datasets, we'd like to have the dataset infos in the YAML and deprecate the dataset_infos.json file. YAML is readable and easy to edit, and the YAML metadata of the readme already contain dataset metadata so we would have everything in one place.
To be more specific, I moved these fie... | 2022-09-02T16:10:05Z | Remove dataset_infos.json
**Is your feature request related to a problem? Please describe.**
As discussed, there are infos in the `dataset_infos.json` which are redundant and we could have them only in the README file.
Others could be migrated to the README, like: "dataset_size", "size_in_bytes", "download_size", "... | also @osanseviero @Pierrci @SBrandeis potentially
Love this in principle 🚀
Let's keep in mind users might rely on `dataset_infos.json` already.
I'm not convinced by the two-syntax solution, wouldn't it be simpler to have only one syntax with a `default` config for datasets with only one config? ie, always havin... | [
{
"body": "**Is your feature request related to a problem? Please describe.**\r\nAs discussed, there are infos in the `dataset_infos.json` which are redundant and we could have them only in the README file.\r\n\r\nOthers could be migrated to the README, like: \"dataset_size\", \"size_in_bytes\", \"download_size... | 7a8a79ab1af0b68aff1c7b5c43f273b3f583b5e9 | {
"head_commit": "a1df085241034c3a7baab795b38d724983b17f68",
"head_commit_message": "fix utf-8 yaml dump",
"patch_to_review": "diff --git a/.github/PULL_REQUEST_TEMPLATE/add_dataset.md b/.github/PULL_REQUEST_TEMPLATE/add_dataset.md\nindex e569839d829..38269e2456d 100644\n--- a/.github/PULL_REQUEST_TEMPLATE/add_da... | [
{
"diff_hunk": "@@ -50,7 +50,9 @@ def register_subcommand(parser: ArgumentParser):\n help=\"Can be used to specify a manual directory to get the files from.\",\n )\n test_parser.add_argument(\"--all_configs\", action=\"store_true\", help=\"Test all dataset configurations\")\n- ... | 60bbac563dfeb055ea3643f34e7a2104f121b1bb | diff --git a/.github/PULL_REQUEST_TEMPLATE/add_dataset.md b/.github/PULL_REQUEST_TEMPLATE/add_dataset.md
index e569839d829..11630da8bbf 100644
--- a/.github/PULL_REQUEST_TEMPLATE/add_dataset.md
+++ b/.github/PULL_REQUEST_TEMPLATE/add_dataset.md
@@ -6,11 +6,9 @@
### Checkbox
-- [ ] Create the dataset script `/datas... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Code Refactoring / Architectural Improvement"
} |
huggingface__datasets-4516@6a22591 | huggingface/datasets | Python | 4,516 | Fix hashing for python 3.9 | In python 3.9, pickle hashes the `glob_ids` dictionary in addition to the `globs` of a function.
Therefore the test at `tests/test_fingerprint.py::RecurseDumpTest::test_recurse_dump_for_function_with_shuffled_globals` is currently failing for python 3.9
To make hashing deterministic when the globals are not in th... | 2022-06-16T16:42:31Z | Failure to hash (and cache) a `.map(...)` (almost always) - using this method can produce incorrect results
## Describe the bug
Sometimes I get messages about not being able to hash a method:
`Parameter 'function'=<function StupidDataModule._separate_speaker_id_from_dialogue at 0x7f1b27180d30> of the transform datase... | Important info:
As hashes are generated randomly for functions, it leads to **false identifying some results as already hashed** (mapping function is not executed after a method update) when there's a `pytorch_lightning.seed_everything(123)`
@lhoestq
seems like quite critical stuff for me, if I'm not making a mista... | [
{
"body": "## Describe the bug\r\nSometimes I get messages about not being able to hash a method:\r\n`Parameter 'function'=<function StupidDataModule._separate_speaker_id_from_dialogue at 0x7f1b27180d30> of the transform datasets.arrow_dataset.Dataset.\r\n_map_single couldn't be hashed properly, a random hash w... | aa555a299ad73c65e3f997a764e9d211675ab05d | {
"head_commit": "6a22591d5f4fdfe111564555a562d6728d80792d",
"head_commit_message": "fix hashing for python 3.9",
"patch_to_review": "diff --git a/src/datasets/utils/py_utils.py b/src/datasets/utils/py_utils.py\nindex 2f20ac2e38a..4adc56270d8 100644\n--- a/src/datasets/utils/py_utils.py\n+++ b/src/datasets/utils/... | [
{
"diff_hunk": "@@ -818,6 +818,22 @@ def save_function(pickler, obj):\n else:\n globs = {\"__name__\": obj.__module__}\n \n+ # DONE: modified here for huggingface/datasets\n+ # - globs is a dictionary with keys = var names (str) and values = python objec... | 9d8f689da7aec094bf003f19ed93cee30851ee38 | diff --git a/src/datasets/utils/py_utils.py b/src/datasets/utils/py_utils.py
index 2f20ac2e38a..b6656b7f6bf 100644
--- a/src/datasets/utils/py_utils.py
+++ b/src/datasets/utils/py_utils.py
@@ -725,7 +725,7 @@ def save_function(pickler, obj):
# therefore we have to sort the keys to make deterministic.
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
gradio-app__gradio-11421@373a603 | gradio-app/gradio | Python | 11,421 | Preserve value in reload mode | We had a regression where values of compnents were not preserved in reload mode, so when you edited the source file, values would be reset to empty. This is fixed.
Previously, state was not preserved in reload mode either, a separate bug. Also fixed.
Fixes: #8855
Fixes: https://github.com/gradio-app/gradio/iss... | 2025-06-19T23:56:28Z | Reload mode should preserve the selected tab
Gradio's reload mode currently preserves some selected values, such as a the selected radio button. However, it doesn't preserve the selected tab, which makes it frustrating to use in applications with multiple tabs, i.e. if you are working on the content for the second tab,... | reload mode disapproves of our tabs, maybe it will start working when we redesign them.
Yeah, this issue I feel needs to be taken seriously, and it becomes important when I have a lot of tabs.
Then getting this issue may needs to be looked at in conjunction with #10282
I have a practice I'm using that can solve both... | [
{
"body": "Gradio's reload mode currently preserves some selected values, such as a the selected radio button. However, it doesn't preserve the selected tab, which makes it frustrating to use in applications with multiple tabs, i.e. if you are working on the content for the second tab, then you'll need to keep ... | 4de716919873336939a212be96c2f359cd565a68 | {
"head_commit": "373a603c1a9b02fc1c79d7118d7e8f75b74a6182",
"head_commit_message": "add changeset",
"patch_to_review": "diff --git a/.changeset/metal-tables-beg.md b/.changeset/metal-tables-beg.md\nnew file mode 100644\nindex 0000000000..e1bde23b54\n--- /dev/null\n+++ b/.changeset/metal-tables-beg.md\n@@ -0,0 +1... | [
{
"diff_hunk": "@@ -391,11 +391,15 @@\n \t\t\t\t});\n \t\t\t\tstream.addEventListener(\"reload\", async (event) => {\n \t\t\t\t\tapp.close();\n-\t\t\t\t\tapp = await Client.connect(api_url, {\n-\t\t\t\t\t\tstatus_callback: handle_status,\n-\t\t\t\t\t\twith_null_state: true,\n-\t\t\t\t\t\tevents: [\"data\", \"lo... | 48def4c712dedd7763e701e1c8b204688609a6d4 | diff --git a/.changeset/metal-tables-beg.md b/.changeset/metal-tables-beg.md
new file mode 100644
index 0000000000..e1bde23b54
--- /dev/null
+++ b/.changeset/metal-tables-beg.md
@@ -0,0 +1,9 @@
+---
+"@gradio/client": patch
+"@gradio/core": patch
+"@self/app": patch
+"@self/spa": patch
+"gradio": patch
+---
+
+fix:Pres... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
iterative__dvc-10316@81c7c3b | iterative/dvc | Python | 10,316 | dvc.api for dataset | On top of #10287. Closes #10313.
### Usage
```python
from dvc.api import get_dataset
get_dataset("<dataset_name>")
```
The `get_dataset()` API returns a dict with values depending on the type of dataset.
## Examples:
### dvcx
```python
from dvc.api import get_dataset
from dvcx.query import DatasetQue... | 2024-02-23T05:44:39Z | `dvc.api.dataset`
API for new `datasets` feature
- [x] DVCX (highest priority) - return name, version
- [x] DVC (next priority) - return URL, path, sha
- [x] Cloud-versioned (nice to have) - return URL, version ID for each file
Needs spec | [
{
"body": "API for new `datasets` feature\r\n\r\n- [x] DVCX (highest priority) - return name, version\r\n- [x] DVC (next priority) - return URL, path, sha\r\n- [x] Cloud-versioned (nice to have) - return URL, version ID for each file\r\n\r\nNeeds spec",
"number": 10313,
"title": "`dvc.api.dataset`"
}
... | 34d80fbfce31800557c38a3ad33962055a63566b | {
"head_commit": "81c7c3b4dc4e596577f0e8300f6166cc31fae319",
"head_commit_message": "add support for tracking remote dataset\n\nThis adds support for virtually tracking a\ndataset such as dvcx dataset, dataset from remote dvc/git\nregistries, and cloud-versioned remotes.\n\nThis PR introduces two different commands... | [
{
"diff_hunk": "@@ -0,0 +1,61 @@\n+from typing import Literal, TypedDict, Union\n+\n+\n+class DVCXDataset(TypedDict):\n+ type: Literal[\"dvcx\"]\n+ name: str\n+ version: int\n+\n+\n+class DVCDataset(TypedDict):\n+ type: Literal[\"dvc\"]\n+ url: str\n+ path: str\n+ sha: str",
"line": 14,... | 7ee1e6af6b40298a03cc618cb51d0323815ea1e8 | diff --git a/dvc/api/__init__.py b/dvc/api/__init__.py
index 5af192deaf..3bc5634f8d 100644
--- a/dvc/api/__init__.py
+++ b/dvc/api/__init__.py
@@ -2,6 +2,7 @@
from .artifacts import artifacts_show
from .data import get_url, open, read
+from .dataset import get as get_dataset
from .experiments import exp_save, exp_... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
huggingface__datasets-4433@43a3326 | huggingface/datasets | Python | 4,433 | Fix script fetching and local path handling in `inspect_dataset` and `inspect_metric` | Fix #4348 | 2022-06-01T12:09:56Z | `inspect` functions can't fetch dataset script from the Hub
The `inspect_dataset` and `inspect_metric` functions are unable to retrieve a dataset or metric script from the Hub and store it locally at the specified `local_path`:
```py
>>> from datasets import inspect_dataset
>>> inspect_dataset('rotten_tomatoes', l... | Hi, thanks for reporting! `git bisect` points to #2986 as the PR that introduced the bug. Since then, there have been some additional changes to the loading logic, and in the current state, `force_local_path` (set via `local_path`) forbids pulling a script from the internet instead of downloading it: https://github.com... | [
{
"body": "The `inspect_dataset` and `inspect_metric` functions are unable to retrieve a dataset or metric script from the Hub and store it locally at the specified `local_path`:\r\n\r\n```py\r\n>>> from datasets import inspect_dataset\r\n>>> inspect_dataset('rotten_tomatoes', local_path='path/to/my/local/folde... | a442dfc883c3952fe0cc28bc8ac05011f83cd346 | {
"head_commit": "43a3326deae218a14296c60630c0198059098fac",
"head_commit_message": "Iterate on copy when deleting list items",
"patch_to_review": "diff --git a/src/datasets/download/download_manager.py b/src/datasets/download/download_manager.py\nindex 3783fc2c178..8ba7434180a 100644\n--- a/src/datasets/download... | [
{
"diff_hunk": "@@ -118,13 +123,24 @@ def inspect_dataset(path: str, local_path: str, download_config: Optional[Downlo\n **download_kwargs (additional keyword arguments): Optional arguments for [`DownloadConfig`] which will override\n the attributes of `download_config` if supplied.\n \"... | 5206cd7bcdfb761202e26fa7dfcdc64f9211f48f | diff --git a/src/datasets/download/download_manager.py b/src/datasets/download/download_manager.py
index 3783fc2c178..a8b4f3101da 100644
--- a/src/datasets/download/download_manager.py
+++ b/src/datasets/download/download_manager.py
@@ -128,10 +128,9 @@ def _iter_from_paths(cls, urlpaths: Union[str, List[str]]) -> Gene... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
huggingface__datasets-4530@c905c1b | huggingface/datasets | Python | 4,530 | Add AudioFolder packaged loader | will close #3964
AudioFolder is almost identical to ImageFolder except for inferring labels is not the default behavior (`drop_labels` is set to True in config), the option of inferring them is preserved though.
The weird thing is happening with the `test_data_files_with_metadata_and_archives` when `streaming` i... | 2022-06-20T12:54:02Z | Add default Audio Loader
**Is your feature request related to a problem? Please describe.**
Writing a custom loading dataset script might be a bit challenging for users.
**Describe the solution you'd like**
Add default Audio loader (analogous to ImageFolder) for small datasets with standard directory structure.
... | [
{
"body": "**Is your feature request related to a problem? Please describe.**\r\nWriting a custom loading dataset script might be a bit challenging for users.\r\n\r\n**Describe the solution you'd like**\r\nAdd default Audio loader (analogous to ImageFolder) for small datasets with standard directory structure.\... | fdcb8b144ce3ef241410281e125bd03e87b8caa1 | {
"head_commit": "c905c1bbfd3a79198c0c38785a6dfa4ad8485779",
"head_commit_message": "patch autofolder for streaming manually",
"patch_to_review": "diff --git a/datasets/audiofolder/README.md b/datasets/audiofolder/README.md\nnew file mode 100644\nindex 00000000000..7ab03192318\n--- /dev/null\n+++ b/datasets/audio... | [
{
"diff_hunk": "@@ -112,3 +112,9 @@ def extend_dataset_builder_for_streaming(builder: \"DatasetBuilder\"):\n internal_import_name = imports[1]\n internal_module_name = \".\".join(builder.__module__.split(\".\")[:-1] + [internal_import_name])\n extend_module_for_st... | fbef2b012b97dac6a156b40eaa23097c9959e97d | diff --git a/datasets/audiofolder/README.md b/datasets/audiofolder/README.md
new file mode 100644
index 00000000000..7ab03192318
--- /dev/null
+++ b/datasets/audiofolder/README.md
@@ -0,0 +1,4 @@
+
+### Contributions
+
+Thanks to [@polinaeterna](https://github.com/polinaeterna), [@nateraw](https://github.com/nateraw), ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
goauthentik__authentik-10454@39cdf10 | goauthentik/authentik | Python | 10,454 | policies: add GeoIP policy | Closes #4433
Introduces the new GeoIP policy with the functionality to match client ASN or country (for now).
~Opening a draft of this for a high-level overview. There are still many details to iron out like~
- [x] Back-end tests
- [x] Handle disabled geoip
- [x] Handle IP missing in geoip database
-... | 2024-07-11T12:20:47Z | Dedicated GeoIP/ASN policy
**Is your feature request related to a problem? Please describe.**
Since the GeoIP DB is now bundled with authentik and is available out of the box, it is logical to assume that even more users will want to take advantage of what GeoIP can offer.
However, currently the only way to use th... | [
{
"body": "**Is your feature request related to a problem? Please describe.**\r\nSince the GeoIP DB is now bundled with authentik and is available out of the box, it is logical to assume that even more users will want to take advantage of what GeoIP can offer. \r\n\r\nHowever, currently the only way to use the ... | c8ca6721e2e882ce82551cf5bfbf66aed5b38932 | {
"head_commit": "39cdf10614968b6ea82a28875c9584b0a5e4d335",
"head_commit_message": "fix translations\n\nwhoops",
"patch_to_review": "diff --git a/authentik/policies/geoip/__init__.py b/authentik/policies/geoip/__init__.py\nnew file mode 100644\nindex 000000000000..e69de29bb2d1\ndiff --git a/authentik/policies/ge... | [
{
"diff_hunk": "@@ -0,0 +1,170 @@\n+import { BasePolicyForm } from \"@goauthentik/admin/policies/BasePolicyForm\";\n+import { DEFAULT_CONFIG } from \"@goauthentik/common/api/config\";\n+import { first } from \"@goauthentik/common/utils\";\n+import \"@goauthentik/elements/forms/FormGroup\";\n+import \"@goauthent... | 063a55aceead30eb6bb067c01f197bad499cef2c | diff --git a/authentik/policies/geoip/__init__.py b/authentik/policies/geoip/__init__.py
new file mode 100644
index 000000000000..e69de29bb2d1
diff --git a/authentik/policies/geoip/api.py b/authentik/policies/geoip/api.py
new file mode 100644
index 000000000000..5ea0b1e4aaa9
--- /dev/null
+++ b/authentik/policies/geoip... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
huggingface__datasets-4412@4bf2948 | huggingface/datasets | Python | 4,412 | Skip hidden files/directories in data files resolution and `iter_files` | Fix #4115 | 2022-05-26T12:10:28Z | ImageFolder add option to ignore some folders like '.ipynb_checkpoints'
**Is your feature request related to a problem? Please describe.**
I sometimes like to peek at the dataset images from jupyterlab. thus '.ipynb_checkpoints' folder appears where my dataset is and (just realized) leads to accidental duplicate image... | Maybe it would be nice to ignore private dirs like this one (ones starting with `.`) by default.
CC @mariosasko
Maybe we can add a `ignore_hidden_files` flag to the builder configs of our packaged loaders (to be consistent across all of them), wdyt @lhoestq @albertvillanova?
I think they should always ignore them... | [
{
"body": "**Is your feature request related to a problem? Please describe.**\r\nI sometimes like to peek at the dataset images from jupyterlab. thus '.ipynb_checkpoints' folder appears where my dataset is and (just realized) leads to accidental duplicate image additions. I think this is an easy enough thing to... | 0bb47271910c8a0b628dba157988372307fca1d2 | {
"head_commit": "4bf2948538088a4f4d05e2d0150c7f20082e1103",
"head_commit_message": "Remove minor optimization",
"patch_to_review": "diff --git a/src/datasets/data_files.py b/src/datasets/data_files.py\nindex dcbe2458963..bda19ddad69 100644\n--- a/src/datasets/data_files.py\n+++ b/src/datasets/data_files.py\n@@ -... | [
{
"diff_hunk": "@@ -483,3 +483,26 @@ def zip_image_path(image_path, tmp_path_factory):\n f.write(image_path, arcname=os.path.basename(image_path))\n f.write(image_path, arcname=os.path.basename(image_path).replace(\".jpg\", \"2.jpg\"))\n return path\n+\n+\n+@pytest.fixture(scope=\"session\")... | 05f21aaa9a908ff18f39cdcc274754793079d726 | diff --git a/src/datasets/data_files.py b/src/datasets/data_files.py
index dcbe2458963..bda19ddad69 100644
--- a/src/datasets/data_files.py
+++ b/src/datasets/data_files.py
@@ -122,7 +122,7 @@ def _resolve_single_pattern_locally(
matched_paths = [
Path(filepath).resolve()
for filepath in glob_ite... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
iterative__dvc-10074@0be99a8 | iterative/dvc | Python | 10,074 | studio: Add Studio authentication to DVC | * [x] ❗ I have followed the [Contributing to DVC](https://dvc.org/doc/user-guide/contributing/core) checklist.
* [x] 📖 If this PR requires [documentation](https://dvc.org/doc) updates, I have created a separate PR (or issue, at least) in [dvc.org](https://github.com/iterative/dvc.org) and linked it here.
Adds a ... | 2023-11-08T12:48:53Z | Studio token: make it global, make it easier to setup
Since token is being also used by VS Code we need to come up with a single way to manage it. I think it should be done in a way similar to `gh` app and not via DVC config per repo.
We have now a bit broken experience since we have it in two places and managed dif... | @shcheklein I added it to #9074.
Unless I'm mistaken, it's already possible to make it global via `dvc config --global` (see #9213), so I think this is just about making it easy to set that up via some command that would automatically write to that global config, right?
Somewhat related to #9217. If we have some... | [
{
"body": "Since token is being also used by VS Code we need to come up with a single way to manage it. I think it should be done in a way similar to `gh` app and not via DVC config per repo.\r\n\r\nWe have now a bit broken experience since we have it in two places and managed differently.\r\n\r\ncc @mattseddon... | ee35ec10a2916a7ee55b4ed42f27ebdb702449b3 | {
"head_commit": "0be99a8d3400607663e29fc2253610510edd77a8",
"head_commit_message": "Update DVC Studio components and simplify authentication process\n\nThis commit modifies several parts of the ‘dvc/commands/studio.py’ and updates DVC Studio Client's version in 'pyproject.toml' for compatibility with the changes.\... | [
{
"diff_hunk": "@@ -66,7 +66,7 @@ def notify_refs(\n try:\n r = post(\"webhook/dvc\", token, data, base_url=base_url)\n except requests.RequestException as e:\n- logger.trace(\"\", exc_info=True)\n+ logger.trace(\"\", exc_info=True) # type: ignore[attr-defined]",
"line": null,... | 46c525025fdbff986fb1c61c7e34459c0211918e | diff --git a/dvc/cli/parser.py b/dvc/cli/parser.py
index 88a60d1c2a..31e68ad4d0 100644
--- a/dvc/cli/parser.py
+++ b/dvc/cli/parser.py
@@ -42,6 +42,7 @@
repro,
root,
stage,
+ studio,
unprotect,
update,
version,
@@ -93,6 +94,7 @@
check_ignore,
data,
artifacts,
+ studio,... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
home-assistant__core-137603@fd06b6a | home-assistant/core | Python | 137,603 | Add option to specify Reolink Basic Service Port | <!--
You are amazing! Thanks for contributing to our project!
Please, DO NOT DELETE ANY TEXT from this template! (unless instructed).
-->
## Breaking change
<!--
If your PR contains a breaking change for existing users, it is important
to tell them what breaks, how to make it work again and why we did th... | 2025-02-06T20:39:25Z | Baichuan Error with Custom (non 9000) port for Basic Service Port
**Describe the bug**
Starting around the time of the commit dated to October 17, 2024, I began to get regular disconnects in Home Assistant where I would need to re-authenticate my cameras. I assumed it would iron itself out given enough time, and found ... | Today, I noticed another similar error that may be relevant but unrelated to the port number (as I left it at 9000 for the time being):
```
Logger: reolink_aio.baichuan.baichuan
Source: components/reolink/host.py:539
First occurred: 4:03:16 PM (1 occurrences)
Last logged: 4:03:16 PM
Baichuan host ***.***.*.**: keepal... | [
{
"body": "**Describe the bug**\nStarting around the time of the commit dated to October 17, 2024, I began to get regular disconnects in Home Assistant where I would need to re-authenticate my cameras. I assumed it would iron itself out given enough time, and found similar issues, but lately I realized the issu... | c8bafe9c461e4be6e3416514f1258c10e6f26f84 | {
"head_commit": "fd06b6a582c1f4f2cf7fe489609d5245e8b18ff0",
"head_commit_message": "Add tests",
"patch_to_review": "diff --git a/homeassistant/components/reolink/__init__.py b/homeassistant/components/reolink/__init__.py\nindex 71ca54287404b..2489133841aed 100644\n--- a/homeassistant/components/reolink/__init__.... | [
{
"diff_hunk": "@@ -8,13 +8,15 @@\n \"host\": \"[%key:common::config_flow::data::host%]\",\n \"port\": \"[%key:common::config_flow::data::port%]\",\n \"use_https\": \"Enable HTTPS\",\n+ \"baichuan_port\": \"Basic Service Port\",",
"line": null,
"original_line": 11,... | cabf36fd7465f74fbe880cc6bddee809803a9be9 | diff --git a/homeassistant/components/reolink/__init__.py b/homeassistant/components/reolink/__init__.py
index 71ca54287404b..2489133841aed 100644
--- a/homeassistant/components/reolink/__init__.py
+++ b/homeassistant/components/reolink/__init__.py
@@ -28,7 +28,7 @@
from homeassistant.helpers.typing import ConfigType
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
iterative__dvc-9846@8a17b53 | iterative/dvc | Python | 9,846 | exp: make run/save less noisy | Closes #9239
Not sure if we need additional tests for this
| 2023-08-15T16:12:34Z | exp run: less verbose output
The current output of `dvc exp run` seems unnecessarily verbose:
```bash
$ dvc exp run -S prepare.split=0.25
Couldn't find a valid Studio Repo URL.
You can try manually setting the environment variable `STUDIO_REPO_URL`.
'data/data.xml.dvc' didn't change, skipping
Running stage 'pre... | [
{
"body": "The current output of `dvc exp run` seems unnecessarily verbose:\r\n\r\n```bash\r\n$ dvc exp run -S prepare.split=0.25\r\nCouldn't find a valid Studio Repo URL.\r\nYou can try manually setting the environment variable `STUDIO_REPO_URL`.\r\n'data/data.xml.dvc' didn't change, skipping\r\nRunning stage ... | 27c548575ca26581154163441976c04be00a9662 | {
"head_commit": "8a17b53da1b736db68f63942a5775b14f9ebb307",
"head_commit_message": "exp: make run/save less noisy",
"patch_to_review": "diff --git a/dvc/commands/experiments/save.py b/dvc/commands/experiments/save.py\nindex 227aa0f90a..d81f1579b5 100644\n--- a/dvc/commands/experiments/save.py\n+++ b/dvc/commands... | [
{
"diff_hunk": "@@ -418,7 +418,7 @@ def test_experiments_remove_invalid(dvc, scm, mocker, capsys, caplog):\n )\n \n \n-def test_experiments_save(dvc, scm, mocker):\n+def test_experiments_save(dvc, scm, mocker, caplog):",
"line": null,
"original_line": 421,
"original_start_line": null,
"path"... | 9a2e961475197f5ac412ca681629a85589de8dbb | diff --git a/dvc/commands/experiments/save.py b/dvc/commands/experiments/save.py
index 227aa0f90a..d81f1579b5 100644
--- a/dvc/commands/experiments/save.py
+++ b/dvc/commands/experiments/save.py
@@ -27,10 +27,6 @@ def run(self):
else:
name = self.repo.experiments.get_exact_name([ref])[ref]
... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Code Refactoring / Architectural Improvement"
} | |
gradio-app__gradio-11151@c0a0f61 | gradio-app/gradio | Python | 11,151 | Fix builtin functions for gr.State value | ## Description
Small bug fix. Alternative is to not allow builtins at all.
Closes: #10653
## 🎯 PRs Should Target Issues
Before your create a PR, please check to see if there is [an existing issue](https://github.com/gradio-app/gradio/issues) for this change. If not, please create an issue before you create... | 2025-05-05T12:57:55Z | Setting gr.State value to a builtin causes error in inspection
### Describe the bug
Setting gr.State value to a dict or bool causes error in inspection. The workaround is to set the value to a function which returns a dict object.
This worked in previous versions of gradio
### Have you searched existing issues? 🔎... | [
{
"body": "### Describe the bug\n\nSetting gr.State value to a dict or bool causes error in inspection. The workaround is to set the value to a function which returns a dict object.\n\nThis worked in previous versions of gradio\n\n### Have you searched existing issues? 🔎\n\n- [x] I have searched and found no... | d5ddd85d4d5088cce154b1cd50a4a2db179ac227 | {
"head_commit": "c0a0f61562ec677e733832aadd5ec6d1ca626b15",
"head_commit_message": "Merge branch 'main' into fix-dict-callable",
"patch_to_review": "diff --git a/.changeset/smooth-turkeys-notice.md b/.changeset/smooth-turkeys-notice.md\nnew file mode 100644\nindex 0000000000..2f76520b85\n--- /dev/null\n+++ b/.ch... | [
{
"diff_hunk": "@@ -1308,7 +1308,10 @@ def get_function_params(func: Callable) -> list[tuple[str, bool, Any, Any]]:\n Excludes *args and **kwargs, as well as args that are Gradio-specific, such as gr.Request, gr.EventData, gr.OAuthProfile, and gr.OAuthToken.\n \"\"\"\n params_info = []\n- signatu... | 0cf22effba3dd4baea5b2f89e6b37c7d5b4fdf1d | diff --git a/.changeset/smooth-turkeys-notice.md b/.changeset/smooth-turkeys-notice.md
new file mode 100644
index 0000000000..2f76520b85
--- /dev/null
+++ b/.changeset/smooth-turkeys-notice.md
@@ -0,0 +1,5 @@
+---
+"gradio": patch
+---
+
+fix:Fix builtin functions for gr.State value
diff --git a/gradio/utils.py b/gradi... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} | |
home-assistant__core-138663@115c28f | home-assistant/core | Python | 138,663 | Add sensor platform to backup integration | <!--
You are amazing! Thanks for contributing to our project!
Please, DO NOT DELETE ANY TEXT from this template! (unless instructed).
-->
## Proposed change
<!--
Describe the big picture of your changes here to communicate to the
maintainers why we should accept this pull request. If it fixes a bug
or... | 2025-02-16T18:17:50Z | I cant found any Sensor for BackUp Status
### The problem
New BackUp - brilliant. But, i cant found any Sensor for plase to Lovelas Card with Status BackUp....
### What version of Home Assistant Core has the issue?
2025.2.1
### What was the last working version of Home Assistant Core?
_No response_
### What type ... | I came here looking for the same. There should be a "backups stale" sensor that turns on after 24 hours or something similar, so you know that the backups have failed or are failing. The google drive backup add_on provides this.
Hey there @home-assistant/core, mind taking a look at this issue as it has been labeled wi... | [
{
"body": "### The problem\n\nNew BackUp - brilliant. But, i cant found any Sensor for plase to Lovelas Card with Status BackUp....\n\n### What version of Home Assistant Core has the issue?\n\n2025.2.1\n\n### What was the last working version of Home Assistant Core?\n\n_No response_\n\n### What type of installa... | 59cab7cd588d677f01d32738e4d9074020fab9db | {
"head_commit": "115c28f6928b848ffe2f26396cd459c56f0fef5f",
"head_commit_message": "add sensor platform to backup integration",
"patch_to_review": "diff --git a/homeassistant/components/backup/__init__.py b/homeassistant/components/backup/__init__.py\nindex 71a4f5ea41ab90..fdb4d511a7d9e4 100644\n--- a/homeassist... | [
{
"diff_hunk": "@@ -18,5 +18,24 @@\n \"name\": \"Create automatic backup\",\n \"description\": \"Creates a new backup with automatic backup settings.\"\n }\n+ },\n+ \"entity\": {\n+ \"sensor\": {\n+ \"backup_manager_state\": {\n+ \"name\": \"Backup Manager State\",\n+ \"s... | 4efa7f844f6fa0b4fa1309bda130dd10b73abd98 | diff --git a/homeassistant/components/backup/__init__.py b/homeassistant/components/backup/__init__.py
index d9d1c3cc2fe1fd..124ce8b872caa1 100644
--- a/homeassistant/components/backup/__init__.py
+++ b/homeassistant/components/backup/__init__.py
@@ -1,7 +1,9 @@
"""The Backup integration."""
+from homeassistant.conf... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
gradio-app__gradio-11098@2a8abcd | gradio-app/gradio | Python | 11,098 | Fix #10281: Dragging image replaces existing instead of opening new tab | ## Description of the problem
In Gradio 5.x.x, dragging a second image onto an already populated `<gr.Image>` component did **not** replace the existing image—instead, the browser opened the dropped file in a new tab. Previously, the `<div class="upload-container">` had **no** `on:dragover` or `on:drop` handlers, so t... | 2025-04-29T13:04:28Z | Dragging in an image a second time will not replace the original image, it will open in a new tab
### Describe the bug
Dragging in an image a second time will not replace the original image, it will open in a new tab
### Have you searched existing issues? 🔎
- [X] I have searched and found no existing issues
### R... | Not sure if this intentional or not, cc @hannahblair @pngwn but it seems reasonable to support
When I use gradio 4.x.x I can replace the image with the newly dragged in image when it already exists in the gr.Image() interactive interface, but with gradio 5.x.x the newly dragged in image will be displayed in the new tab... | [
{
"body": "### Describe the bug\n\nDragging in an image a second time will not replace the original image, it will open in a new tab\n\n### Have you searched existing issues? 🔎\n\n- [X] I have searched and found no existing issues\n\n### Reproduction\n\n```python\r\nimport gradio as gr\r\n\r\n \r\nwith gr.... | 1efc9c9bb94da599fc35241f5df21298cf02eecb | {
"head_commit": "2a8abcd59160c647ccb638166c8b667f74c4e503",
"head_commit_message": "Fix #10281: Dragging image replaces existing instead of opening new tab\nI updated the drag and drop event handlers in the imageUploader\ncomponent (on_drag_over and on_drop) to clear the\nexisting image before processing the newly... | [
{
"diff_hunk": "@@ -240,6 +240,39 @@\n \t\t\tdispatch(\"load\", files_to_load);\n \t\t}\n \t}\n+\n+\texport async function loadFilesFromDrop(e: DragEvent): Promise<void> {",
"line": null,
"original_line": 244,
"original_start_line": null,
"path": "js/upload/src/Upload.svelte",
"start_line": ... | e8a25bb560515e2ba67632e962b121ac40f70bdb | diff --git a/.changeset/loose-paths-burn.md b/.changeset/loose-paths-burn.md
new file mode 100644
index 0000000000..5240375464
--- /dev/null
+++ b/.changeset/loose-paths-burn.md
@@ -0,0 +1,7 @@
+---
+"@gradio/image": patch
+"@gradio/upload": patch
+"gradio": patch
+---
+
+fix:Fix #10281: Dragging image replaces existin... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
huggingface__datasets-4322@974b6dd | huggingface/datasets | Python | 4,322 | Added stratify option to train_test_split function. | This PR adds `stratify` option to `train_test_split` method. I took reference from scikit-learn's `StratifiedShuffleSplit` class for implementing stratified split and integrated the changes as were suggested by @lhoestq.
It fixes #3452.
@lhoestq Please review and let me know, if any changes are required.
| 2022-05-12T08:00:31Z | why the stratify option is omitted from test_train_split function?
why the stratify option is omitted from test_train_split function?
is there any other way implement the stratify option while splitting the dataset? as it is important point to be considered while splitting the dataset. | Hi ! It's simply not added yet :)
If someone wants to contribute to add the `stratify` parameter I'd be happy to give some pointers.
In the meantime, I guess you can use `sklearn` or other tools to do a stratified train/test split over the **indices** of your dataset and then do
```
train_dataset = dataset.sele... | [
{
"body": "why the stratify option is omitted from test_train_split function?\r\n\r\nis there any other way implement the stratify option while splitting the dataset? as it is important point to be considered while splitting the dataset.",
"number": 3452,
"title": "why the stratify option is omitted fro... | c1dce72ff259d3e7abee34900e48578ec685fb00 | {
"head_commit": "974b6ddd10ec702cc7ad6d7c95a09f4dacc29ffe",
"head_commit_message": "Fix test cases according to ClassLabel class",
"patch_to_review": "diff --git a/src/datasets/arrow_dataset.py b/src/datasets/arrow_dataset.py\nindex 01ee0ef9064..c65111e68e9 100644\n--- a/src/datasets/arrow_dataset.py\n+++ b/src/... | [
{
"diff_hunk": "@@ -3436,15 +3459,26 @@ def train_test_split(\n ),\n }\n )\n-\n if not shuffle:\n+ if stratify is not None:\n+ raise ValueError(\"Stratified train/test split is not implemented for shuffle=False\")",
... | 48fe48edc247430ef23e21d6c07b8207357b13c8 | diff --git a/src/datasets/arrow_dataset.py b/src/datasets/arrow_dataset.py
index c6e16208311..e6b033ec37c 100644
--- a/src/datasets/arrow_dataset.py
+++ b/src/datasets/arrow_dataset.py
@@ -93,6 +93,7 @@
from .utils.file_utils import _retry, estimate_dataset_size
from .utils.info_utils import is_small_dataset
from .u... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
iterative__dvc-9308@abf097c | iterative/dvc | Python | 9,308 | exp push: improve ui | Closes https://github.com/iterative/dvc/issues/9280. | 2023-04-05T11:22:12Z | exp push: clarify in UI what has been pushed to DVC and Git remotes
`dvc exp push` is doing a lot, potentially pushing multiple experiments to Git, a DVC remote, and Studio. The output doesn't always make clear what happened, what was successful, and what failed.
**Example 1**: When the dvc push fails, the command e... | [
{
"body": "`dvc exp push` is doing a lot, potentially pushing multiple experiments to Git, a DVC remote, and Studio. The output doesn't always make clear what happened, what was successful, and what failed.\r\n\r\n**Example 1**: When the dvc push fails, the command errors out with no additional info even though... | 35648134f7818fe76cce0674d94a371afa114cd4 | {
"head_commit": "abf097c0571a8c1ae37f155a0863eb89f603ce85",
"head_commit_message": "exp push: improve ui",
"patch_to_review": "diff --git a/dvc/commands/experiments/push.py b/dvc/commands/experiments/push.py\nindex 239971a371..c5bad388ca 100644\n--- a/dvc/commands/experiments/push.py\n+++ b/dvc/commands/experime... | [
{
"diff_hunk": "@@ -18,34 +19,60 @@ def raise_error_if_all_disabled(self):\n \"`--rev` or `--all-commits` flag.\"\n )\n \n- def run(self):\n+ @staticmethod\n+ def log_result(result: Dict[str, Any], remote: str):\n from dvc.utils import humanize\n \n- self.rais... | a1596d9e6fea9f15ff78f11c105a214496206710 | diff --git a/dvc/commands/experiments/push.py b/dvc/commands/experiments/push.py
index 239971a371..b76ad8d8a0 100644
--- a/dvc/commands/experiments/push.py
+++ b/dvc/commands/experiments/push.py
@@ -1,5 +1,6 @@
import argparse
import logging
+from typing import Any, Dict
from dvc.cli import completion
from dvc.cl... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
goauthentik__authentik-8675@06723cb | goauthentik/authentik | Python | 8,675 | root: support running authentik in subpath | <!--
👋 Hi there! Welcome.
Please check the Contributing guidelines: https://goauthentik.io/developer-docs/#how-can-i-contribute
-->
## Details
closes #4509
---
## Checklist
- [ ] Local tests pass (`ak test authentik/`)
- [ ] The code has been formatted (`make lint-fix`)
If an API change has... | 2024-02-24T19:22:17Z | Run Authentik in subfolder behind Traefik Proxy
**Describe your question/**
Due to various reasons I can't run authentik as subdomain (e.g. `auth.example.com`). I wan't to use authentik as a subfolder under my domain, e.g. `example.com/auth/`. Additionally I run authentik behind a traefik proxy like I do with many oth... | I have the same problem with Apache 2.4.
From `.env`:
```
COMPOSE_PORT_HTTP=8001
COMPOSE_PORT_HTTPS=9001
```
From `site.conf`:
```
<Location /auth>
ProxyPass http://localhost:8001
</Location>
```
Result: requests to /auth get correctly proxied to authentik, but then the client is incorrectly sent to... | [
{
"body": "**Describe your question/**\r\nDue to various reasons I can't run authentik as subdomain (e.g. `auth.example.com`). I wan't to use authentik as a subfolder under my domain, e.g. `example.com/auth/`. Additionally I run authentik behind a traefik proxy like I do with many other services, also with subf... | 6c1ad982a1eceb6859f8a9d9e1ec10f6ba9bac3c | {
"head_commit": "06723cb621376acaf146ccfe8df5f322caee2508",
"head_commit_message": "set cookie path\n\nSigned-off-by: Jens Langhammer <jens@goauthentik.io>",
"patch_to_review": "diff --git a/authentik/brands/api.py b/authentik/brands/api.py\nindex a856cee4858f..bb449a10e86b 100644\n--- a/authentik/brands/api.py\... | [
{
"diff_hunk": "@@ -14,6 +14,7 @@ type Config struct {\n \t// Config for both core and outposts\n \tDebug bool `yaml:\"debug\" env:\"AUTHENTIK_DEBUG, overwrite\"`\n \tListen ListenConfig `yaml:\"listen\" env:\", prefix=AUTHENTIK_LISTEN__\"`\n+\tWeb WebConfig `yaml:\"web\" env:\", prefix=AUTHENTIK... | ebcf4b61a9b103be2a5d9fda115147cc93ec2e38 | diff --git a/authentik/brands/api.py b/authentik/brands/api.py
index 2f0486a688ed..5f730e040380 100644
--- a/authentik/brands/api.py
+++ b/authentik/brands/api.py
@@ -84,8 +84,8 @@ class CurrentBrandSerializer(PassiveSerializer):
matched_domain = CharField(source="domain")
branding_title = CharField()
- ... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
gradio-app__gradio-10995@c0736f9 | gradio-app/gradio | Python | 10,995 | ensure the image editor background respects the theme mode | ## Description
We weren't handling dark mode, now we are!
<img width="619" alt="Screenshot 2025-04-10 at 12 58 43" src="https://github.com/user-attachments/assets/01612f05-d857-4612-8aac-46a0839c9196" />
Closes: #10978
| 2025-04-10T12:01:02Z | [ImageEditor] - background disrespects dark mode
### Describe the bug
very disrespectful
### Have you searched existing issues? 🔎
- [x] I have searched and found no existing issues
### Reproduction
```python
print("i am very disrepsectful")
```
### Screenshot
_No response_
### Logs
```shell
```
### Syste... | [
{
"body": "### Describe the bug\n\nvery disrespectful\n\n### Have you searched existing issues? 🔎\n\n- [x] I have searched and found no existing issues\n\n### Reproduction\n\n```python\nprint(\"i am very disrepsectful\")\n\n```\n\n\n### Screenshot\n\n_No response_\n\n### Logs\n\n```shell\n\n```\n\n### System ... | 0db230f5c2f19d9b3b455adb1b30ed9374ae1791 | {
"head_commit": "c0736f9ec02481dc0c8c8d2e7e83a4a018553318",
"head_commit_message": "Merge branch 'main' into 10978-imed-darkmode",
"patch_to_review": "diff --git a/.changeset/small-moose-join.md b/.changeset/small-moose-join.md\nnew file mode 100644\nindex 0000000000..0a571cea2e\n--- /dev/null\n+++ b/.changeset/... | [
{
"diff_hunk": "@@ -1166,7 +1169,11 @@ export class ImageEditor {\n \t\t\twidth: container_box.width,\n \t\t\theight: container_box.height,\n \t\t\tbackgroundAlpha: this.dark ? 0 : 1,\n-\t\t\tbackgroundColor: this.dark ? 0x333333 : 0xffffff,\n+\t\t\tbackgroundColor: this.dark",
"line": null,
"original_l... | 77480dab06481db009905eb52cf61b2ddfa8fae2 | diff --git a/.changeset/small-moose-join.md b/.changeset/small-moose-join.md
new file mode 100644
index 0000000000..0a571cea2e
--- /dev/null
+++ b/.changeset/small-moose-join.md
@@ -0,0 +1,6 @@
+---
+"@gradio/imageeditor": patch
+"gradio": patch
+---
+
+fix:ensure the image editor background respects the theme mode
dif... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
huggingface__datasets-3740@71aa41c | huggingface/datasets | Python | 3,740 | Support streaming for pubmed | This PR makes some minor changes to the `pubmed` dataset to allow for `streaming=True`. Fixes #3739.
Basically, I followed the C4 dataset which works in streaming mode as an example, and made the following changes:
* Change URL prefix from `ftp://` to `https://`
* Explicilty `open` the filename and pass the XML ... | 2022-02-17T00:18:22Z | Pubmed dataset does not work in streaming mode
## Describe the bug
Trying to use the `pubmed` dataset with `streaming=True` fails.
## Steps to reproduce the bug
```python
import datasets
pubmed_train = datasets.load_dataset('pubmed', split='train', streaming=True)
print (next(iter(pubmed_train)))
```
## Exp... | [
{
"body": "## Describe the bug\r\nTrying to use the `pubmed` dataset with `streaming=True` fails.\r\n\r\n## Steps to reproduce the bug\r\n```python\r\nimport datasets\r\npubmed_train = datasets.load_dataset('pubmed', split='train', streaming=True)\r\nprint (next(iter(pubmed_train)))\r\n```\r\n\r\n## Expected re... | edc97be7de00f7282a8998933177164caa4ad96a | {
"head_commit": "71aa41caee3d2e9fde981cacc4a5fbddec58250d",
"head_commit_message": "update hardcoded exception",
"patch_to_review": "diff --git a/datasets/pubmed/pubmed.py b/datasets/pubmed/pubmed.py\nindex 4f12617f6ff..4d71bb58e7d 100644\n--- a/datasets/pubmed/pubmed.py\n+++ b/datasets/pubmed/pubmed.py\n@@ -39,... | [
{
"diff_hunk": "@@ -358,28 +358,29 @@ def _generate_examples(self, filenames):\n \"\"\"Yields examples.\"\"\"\n id_ = 0\n for filename in filenames:\n- try:\n- tree = etree.parse(filename)\n- root = tree.getroot()\n- xmldict = self.... | a15d864813cf06ef01419166a7060f458c64d819 | diff --git a/datasets/pubmed/pubmed.py b/datasets/pubmed/pubmed.py
index 4f12617f6ff..6bbe121159a 100644
--- a/datasets/pubmed/pubmed.py
+++ b/datasets/pubmed/pubmed.py
@@ -16,7 +16,7 @@
import copy
-import xml.etree.ElementTree as etree
+import xml.etree.ElementTree as ET
import datasets
@@ -39,7 +39,7 @@
#... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
goauthentik__authentik-12630@7fed46f | goauthentik/authentik | Python | 12,630 | stages/authenticator_email: Email OTP | <!--
👋 Hi there! Welcome.
Please check the Contributing guidelines: https://docs.goauthentik.io/docs/developer-docs/#how-can-i-contribute
-->
## Details
<!--
Explain what this PR changes, what the rationale behind the change is, if any new requirements are introduced or any breaking changes caused by this ... | 2025-01-10T09:10:43Z | Email OTP
**Is your feature request related to a problem? Please describe.**
Authentik does not currently support sending OTP to email.
**Describe the solution you'd like**
The emergence of a new OTP stage, where a temporary password is sent to the user by email.
**Describe alternatives you've considered**
N/A... | Seems like a 'nice to have' idea to me
Not sure about the feasability of this, but having a custom email template with a TOTP code as a variable in it _might be_ doable. (Not sure, I have yet to try this)
+1 for this, would you be open to a PR?
This is vital to my use case. I've been trying to hack it in with Polici... | [
{
"body": "**Is your feature request related to a problem? Please describe.**\r\nAuthentik does not currently support sending OTP to email.\r\n\r\n**Describe the solution you'd like**\r\nThe emergence of a new OTP stage, where a temporary password is sent to the user by email.\r\n\r\n**Describe alternatives you... | 98f3b9ae972193fcd43d75a10d096729c9455079 | {
"head_commit": "7fed46f616813c96615aaae43645eedf3a5e9d47",
"head_commit_message": "Add email connection settings to the Email authenticator stage configuration UI",
"patch_to_review": "diff --git a/authentik/root/settings.py b/authentik/root/settings.py\nindex 8a8438b19b46..66a9aeee8a0a 100644\n--- a/authentik/... | [
{
"diff_hunk": "@@ -0,0 +1,193 @@\n+from os import R_OK, access\n+from pathlib import Path\n+\n+from django.conf import settings\n+from django.contrib.auth import get_user_model\n+from django.core.mail.backends.base import BaseEmailBackend\n+from django.core.mail.backends.smtp import EmailBackend\n+from django.... | 086ecda66b9a4d4ca24aac761def6c28638fe8de | diff --git a/authentik/lib/utils/email.py b/authentik/lib/utils/email.py
new file mode 100644
index 000000000000..1ee9adb1272b
--- /dev/null
+++ b/authentik/lib/utils/email.py
@@ -0,0 +1,54 @@
+"""Email utility functions"""
+
+
+def mask_email(email: str | None) -> str | None:
+ """Mask email address for privacy
+
+... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
huggingface__datasets-3699@1683214 | huggingface/datasets | Python | 3,699 | Add dev-only config to Natural Questions dataset | As suggested by @lhoestq and @thomwolf, a new config has been added to Natural Questions dataset, so that only dev split can be downloaded.
Fix #413. | 2022-02-10T14:42:24Z | Is there a way to download only NQ dev?
Maybe I missed that in the docs, but is there a way to only download the dev set of natural questions (~1 GB)?
As we want to benchmark QA models on different datasets, I would like to avoid downloading the 41GB of training data.
I tried
```
dataset = nlp.load_dataset('nat... | Unfortunately it's not possible to download only the dev set of NQ.
I think we could add a way to download only the test set by adding a custom configuration to the processing script though.
Ok, got it. I think this could be a valuable feature - especially for large datasets like NQ, but potentially also others.
F... | [
{
"body": "Maybe I missed that in the docs, but is there a way to only download the dev set of natural questions (~1 GB)? \r\nAs we want to benchmark QA models on different datasets, I would like to avoid downloading the 41GB of training data. \r\n\r\nI tried\r\n```\r\ndataset = nlp.load_dataset('natural_questi... | 36db39c75179a0a491c69a4491f7ae7e4615e66f | {
"head_commit": "168321463bcd74a937806e5110ec248f39512c63",
"head_commit_message": "Update dataset card",
"patch_to_review": "diff --git a/datasets/natural_questions/README.md b/datasets/natural_questions/README.md\nindex ea4ca276741..849d75b1f47 100644\n--- a/datasets/natural_questions/README.md\n+++ b/datasets... | [
{
"diff_hunk": "@@ -104,9 +120,10 @@ The data fields are the same among all splits.\n \n ### Data Splits\n \n-| name |train |validation|\n-|-------|-----:|---------:|\n-|default|307373| 7830|\n+| name | train |validation|\n+|---------|-------:|---------:|\n+| default | 307373 | 7830|\n+| dev ... | 8adc5a54b5fe27fd3e5b678fd124d9c3cbf49785 | diff --git a/datasets/natural_questions/README.md b/datasets/natural_questions/README.md
index ea4ca276741..6ad89802823 100644
--- a/datasets/natural_questions/README.md
+++ b/datasets/natural_questions/README.md
@@ -1,11 +1,27 @@
---
+annotations_creators:
+- no-annotation
+language_creators:
+- crowdsourced
languag... | {
"difficulty": "medium",
"estimated_review_effort": 2,
"problem_domain": "New Feature Additions"
} |
huggingface__datasets-3695@7ab44ad | huggingface/datasets | Python | 3,695 | Fix ClassLabel to/from dict when passed names_file | Currently, `names_file` is a field of the data class `ClassLabel`, thus appearing when transforming it to dict (when saving infos). Afterwards, when trying to read it from infos, it conflicts with the other field `names`.
This PR, removes `names_file` as a field of the data class `ClassLabel`.
- it is only used at ... | 2022-02-10T09:47:10Z | Labels conflict when loading a local CSV file.
## Describe the bug
I am trying to load a local CSV file with a separate file containing label names. It is successfully loaded for the first time, but when I try to load it again, there is a conflict between provided labels and the cached dataset info. Disabling caching ... | [
{
"body": "## Describe the bug\r\nI am trying to load a local CSV file with a separate file containing label names. It is successfully loaded for the first time, but when I try to load it again, there is a conflict between provided labels and the cached dataset info. Disabling caching globally and/or using `dow... | 36db39c75179a0a491c69a4491f7ae7e4615e66f | {
"head_commit": "7ab44adad5b49d7522a6065f2d2c5f8f2124c851",
"head_commit_message": "Fix ClassLabel to/from dict with names_file",
"patch_to_review": "diff --git a/src/datasets/features/features.py b/src/datasets/features/features.py\nindex 05212b718db..fab4e531e3d 100644\n--- a/src/datasets/features/features.py\... | [
{
"diff_hunk": "@@ -761,7 +761,7 @@ class ClassLabel:\n \n num_classes: int = None\n names: List[str] = None\n- names_file: Optional[str] = None\n+ names_file: InitVar[Optional[str]] = None",
"line": null,
"original_line": 764,
"original_start_line": null,
"path": "src/datasets/fea... | 4dd2b5b0f6224d502fcfc77d164113fcd8101897 | diff --git a/src/datasets/features/features.py b/src/datasets/features/features.py
index 05212b718db..8d55203db66 100644
--- a/src/datasets/features/features.py
+++ b/src/datasets/features/features.py
@@ -19,7 +19,7 @@
import re
import sys
from collections.abc import Iterable
-from dataclasses import _asdict_inner, ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
home-assistant__core-136263@4bf8a8c | home-assistant/core | Python | 136,263 | Fix slave id equal to 0 | <!--
You are amazing! Thanks for contributing to our project!
Please, DO NOT DELETE ANY TEXT from this template! (unless instructed).
-->
## Breaking change
<!--
If your PR contains a breaking change for existing users, it is important
to tell them what breaks, how to make it work again and why we did th... | 2025-01-22T15:36:16Z | Modbus Integration Error for Slave ID 0 After Upgrade to Home Assistant 2025.1
### The problem
After upgrading to Home Assistant version 2025.1, the Modbus integration started failing for a specific device with slave ID 0. Other Modbus devices configured in Home Assistant continue to work without issues. The following... | [modbus documentation](https://www.home-assistant.io/integrations/modbus)
[modbus source](https://github.com/home-assistant/core/tree/dev/homeassistant/components/modbus)
I believe I am having somewhat of a similar issue with a custom modbus integration.
All of a sudden after installing 2025.1.0 my sensors are no lo... | [
{
"body": "### The problem\n\nAfter upgrading to Home Assistant version 2025.1, the Modbus integration started failing for a specific device with slave ID 0. Other Modbus devices configured in Home Assistant continue to work without issues. The following error is logged:\r\n\r\n```\r\n2025-01-04 13:43:35.328 ER... | 507239c661058ef348d90d7aa3cabd4c15bef709 | {
"head_commit": "4bf8a8c43bf21a85df819490b7db3169dede806c",
"head_commit_message": "fix default 1",
"patch_to_review": "diff --git a/homeassistant/components/modbus/entity.py b/homeassistant/components/modbus/entity.py\nindex 03bcc98de40ec..80fd45cd4035d 100644\n--- a/homeassistant/components/modbus/entity.py\n+... | [
{
"diff_hunk": "@@ -79,7 +79,7 @@ def __init__(\n \"\"\"Initialize the Modbus binary sensor.\"\"\"\n \n self._hub = hub\n- self._slave = entry.get(CONF_SLAVE) or entry.get(CONF_DEVICE_ADDRESS, 0)\n+ self._slave = entry.get(CONF_SLAVE) or entry.get(CONF_DEVICE_ADDRESS, 1)",
"lin... | 8f20418a7d27cb8b2e38069ea2840cd0a8b59671 | diff --git a/homeassistant/components/modbus/entity.py b/homeassistant/components/modbus/entity.py
index b3d7a10a94a154..2d99d8f382c6ab 100644
--- a/homeassistant/components/modbus/entity.py
+++ b/homeassistant/components/modbus/entity.py
@@ -80,7 +80,10 @@ def __init__(
"""Initialize the Modbus binary sensor.... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
gradio-app__gradio-10923@d072eb3 | gradio-app/gradio | Python | 10,923 | Add `rtl` to `gr.Radio` | ## Description
Adds a `rtl` param to gr.Radio.
Closes: #7539
## 🎯 PRs Should Target Issues
Before your create a PR, please check to see if there is [an existing issue](https://github.com/gradio-app/gradio/issues) for this change. If not, please create an issue before you create this PR, unless the fix is ... | 2025-04-01T15:17:05Z | RTL for the radio component
- [x] I have searched to see if a similar issue already exists.
**Is your feature request related to a problem? Please describe.**
I want to align the label of a radio elemnt rtl.
**Describe the solution you'd like**
Label of radio componemt aligend rtl for Arabic text.
**A... | Makes sense, we do support rtl for some other components, like `gr.Textbox` and `gr.Markdown`, but not `gr.Radio`. @zaidalyafeai would you like to open a PR for this? | [
{
"body": "- [x] I have searched to see if a similar issue already exists.\r\n\r\n\r\n**Is your feature request related to a problem? Please describe.** \r\nI want to align the label of a radio elemnt rtl.\r\n\r\n**Describe the solution you'd like** \r\nLabel of radio componemt aligend rtl for Arabic text. \r... | 01b88c7fdedb413ba92ef6191967a8aed25e185f | {
"head_commit": "d072eb3133745b5889e1c91ea06dad0fff49339f",
"head_commit_message": "add changeset",
"patch_to_review": "diff --git a/.changeset/stale-bottles-tap.md b/.changeset/stale-bottles-tap.md\nnew file mode 100644\nindex 0000000000..653ed7eb18\n--- /dev/null\n+++ b/.changeset/stale-bottles-tap.md\n@@ -0,0... | [
{
"diff_hunk": "@@ -46,6 +46,7 @@ def __init__(\n elem_classes: list[str] | str | None = None,\n render: bool = True,\n key: int | str | None = None,\n+ rtl: Literal[\"ltr\", \"rtl\"] = \"ltr\",",
"line": null,
"original_line": 49,
"original_start_line": null,
"pat... | bcc685b30f13750b6adce20cce5b84d0a9c099c5 | diff --git a/.changeset/stale-bottles-tap.md b/.changeset/stale-bottles-tap.md
new file mode 100644
index 0000000000..653ed7eb18
--- /dev/null
+++ b/.changeset/stale-bottles-tap.md
@@ -0,0 +1,7 @@
+---
+"@gradio/atoms": minor
+"@gradio/radio": minor
+"gradio": minor
+---
+
+feat:Add `rtl` to `gr.Radio`
diff --git a/gra... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
huggingface__datasets-3575@aa0c682 | huggingface/datasets | Python | 3,575 | Add Arrow type casting to struct for Image and Audio + Support nested casting | ## Intro
1. Currently, it's not possible to have nested features containing Audio or Image.
2. Moreover one can keep an Arrow array as a StringArray to store paths to images, but such arrays can't be directly concatenated to another image array if it's stored an another Arrow type (typically, a StructType).
3... | 2022-01-13T15:36:59Z | Changing sampling rate in audio dataset and subsequently mapping with `num_proc > 1` leads to weird bug
Running:
```python
from datasets import load_dataset, DatasetDict
import datasets
from transformers import AutoFeatureExtractor
raw_datasets = DatasetDict()
raw_datasets["train"] = load_dataset("common_v... | Same error occures when using max samples with https://github.com/huggingface/transformers/blob/master/examples/pytorch/speech-recognition/run_speech_recognition_seq2seq.py
I'm seeing this too, when using preprocessing_num_workers with
https://github.com/huggingface/transformers/blob/master/examples/pytorch/speech-re... | [
{
"body": "Running: \r\n\r\n```python\r\nfrom datasets import load_dataset, DatasetDict\r\nimport datasets\r\nfrom transformers import AutoFeatureExtractor\r\n\r\nraw_datasets = DatasetDict()\r\n\r\nraw_datasets[\"train\"] = load_dataset(\"common_voice\", \"ab\", split=\"train\")\r\n\r\nfeature_extractor = Auto... | b3607371ac9b90e7b9e494dd8a715a7deb929323 | {
"head_commit": "aa0c6826021ab27422fe4f2f60675356d661167e",
"head_commit_message": "whoops forgot one line",
"patch_to_review": "diff --git a/.circleci/config.yml b/.circleci/config.yml\nindex 15735f0da93..f525d3f439f 100644\n--- a/.circleci/config.yml\n+++ b/.circleci/config.yml\n@@ -11,6 +11,7 @@ jobs:\n ... | [
{
"diff_hunk": "@@ -226,12 +92,14 @@ def decode_example(self, value):\n raise ImportError(\"To support decoding images, please install 'Pillow'.\")\n \n if isinstance(value, str):\n- path, bytes_ = value, None\n+ path, bytes_ = value, None # TODO(QL, Mario): remove thi... | 6e209345fffaab608ae2637c199a5c7aaab3bcab | diff --git a/.circleci/config.yml b/.circleci/config.yml
index 15735f0da93..f525d3f439f 100644
--- a/.circleci/config.yml
+++ b/.circleci/config.yml
@@ -11,6 +11,7 @@ jobs:
resource_class: medium
steps:
- checkout
+ - run: sudo apt-get -y update && sudo apt-get install -y libsn... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
huggingface__datasets-3565@7386fe0 | huggingface/datasets | Python | 3,565 | Add parameter `preserve_index` to `from_pandas` | Added optional parameter, so that user can get rid of useless index preserving. [Issue](https://github.com/huggingface/datasets/issues/3563) | 2022-01-11T15:26:37Z | Dataset.from_pandas preserves useless index
## Describe the bug
Let's say that you want to create a Dataset object from pandas dataframe. Most likely you will write something like this:
```
import pandas as pd
from datasets import Dataset
df = pd.read_csv('some_dataset.csv')
# Some DataFrame preprocessing c... | Hi! That makes sense. Sure, feel free to open a PR! Just a small suggestion: let's make `preserve_index` a parameter of `Dataset.from_pandas` (which we then pass to `InMemoryTable.from_pandas`) with `None` as a default value to not have this as a breaking change. | [
{
"body": "## Describe the bug\r\nLet's say that you want to create a Dataset object from pandas dataframe. Most likely you will write something like this:\r\n\r\n```\r\nimport pandas as pd\r\nfrom datasets import Dataset\r\n\r\n\r\ndf = pd.read_csv('some_dataset.csv')\r\n# Some DataFrame preprocessing code...\... | 30b0524a9cb384c20def08772678f69716f4cfdd | {
"head_commit": "7386fe0d97f053999de24be28344e6238b38dc38",
"head_commit_message": "black codestyle (hopefully good now)",
"patch_to_review": "diff --git a/src/datasets/arrow_dataset.py b/src/datasets/arrow_dataset.py\nindex 0681016991d..27be15a96d8 100644\n--- a/src/datasets/arrow_dataset.py\n+++ b/src/datasets... | [
{
"diff_hunk": "@@ -760,6 +761,7 @@ def from_pandas(\n features (:class:`Features`, optional): Dataset features.\n info (:class:`DatasetInfo`, optional): Dataset information, like description, citation, etc.\n split (:class:`NamedSplit`, optional): Name of the dataset split.\... | ee58b053acb2cb9f4be266ab6fc64d13f90778ba | diff --git a/src/datasets/arrow_dataset.py b/src/datasets/arrow_dataset.py
index 0681016991d..af0d356dfb7 100644
--- a/src/datasets/arrow_dataset.py
+++ b/src/datasets/arrow_dataset.py
@@ -742,6 +742,7 @@ def from_pandas(
features: Optional[Features] = None,
info: Optional[DatasetInfo] = None,
... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
huggingface__datasets-3654@4872f0f | huggingface/datasets | Python | 3,654 | Better TQDM output | This PR does the following:
* if `dataset_infos.json` exists for a dataset, uses `num_examples` to print the total number of examples that needs to be generated (in `builder.py`)
* fixes `tqdm` + multiprocessing in Jupyter Notebook/Colab (the issue stems from this commit in the `tqdm` repo: https://github.com/tqdm/tq... | 2022-01-31T17:22:43Z | Progress bars are not properly rendered in Jupyter notebook
## Describe the bug
The progress bars are not Jupyter widgets; regular progress bars appear (like in a terminal).
## Steps to reproduce the bug
```python
ds.map(tokenize, num_proc=10)
```
## Expected results
Jupyter widgets displaying the progress b... | To add my experience when trying to debug this issue:
Seems like previously the workaround given [here](https://github.com/tqdm/tqdm/issues/485#issuecomment-473338308) worked around this issue. But with the latest version of jupyter/tqdm I still get terminal warnings that IPython tried to send a message from a forke... | [
{
"body": "## Describe the bug\r\nThe progress bars are not Jupyter widgets; regular progress bars appear (like in a terminal).\r\n\r\n## Steps to reproduce the bug\r\n```python\r\nds.map(tokenize, num_proc=10)\r\n```\r\n\r\n## Expected results\r\nJupyter widgets displaying the progress bars.\r\n\r\n## Actual r... | 4c417d52def6e20359ca16c6723e0a2855e5c3fd | {
"head_commit": "4872f0f58de27932313fa66ac00e686041921156",
"head_commit_message": "Add more precise descriptions to download",
"patch_to_review": "diff --git a/src/datasets/arrow_dataset.py b/src/datasets/arrow_dataset.py\nindex 89a68fb57bd..401d2b9115f 100644\n--- a/src/datasets/arrow_dataset.py\n+++ b/src/dat... | [
{
"diff_hunk": "@@ -200,18 +200,18 @@ def _single_map_nested(args):\n logging.set_verbosity_warning()\n # Print at least one thing to fix tqdm in notebooks in multiprocessing\n # see https://github.com/tqdm/tqdm/issues/485#issuecomment-473338308\n- if rank is not None and not disable_tqdm and... | 8dccf33796bddf8d30a0f92d71b96dae551c6b9a | diff --git a/src/datasets/arrow_dataset.py b/src/datasets/arrow_dataset.py
index 89a68fb57bd..67f38266b6f 100644
--- a/src/datasets/arrow_dataset.py
+++ b/src/datasets/arrow_dataset.py
@@ -2096,7 +2096,7 @@ def decorated(item, *args, **kwargs):
f"num_proc must be <= {len(self)}. Reducing num_proc to {n... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
gradio-app__gradio-10847@e1d3ba1 | gradio-app/gradio | Python | 10,847 | Babylon update for model3D | ## Description
Update Babylon.js dependency from 7.25.1 to 7.54.0. Use Babylon viewer as a ES module to reduce .js size.
No change to supported file formats (obj, gtlf,...)
Closes: #10846
## Changes
- Replace Babylon.js core and loader with Babylon Viewer
- Use engine version 7.54.0 instead of 7.25.1
- Us... | 2025-03-20T17:04:34Z | Model3D: Use Babylon Viewer ESM
model3D uses Babylon.js as UMD module. Update to ESM to allow tree-shaking and reduced size.
Also, Babylon.js new viewer can help make the code smaller. It can come with UI elements like loading bars, animation controls, etc.
Current Canvas3D size : 4.6Mb
Updated Canvas3D size: 1.2Mb | [
{
"body": "model3D uses Babylon.js as UMD module. Update to ESM to allow tree-shaking and reduced size.\nAlso, Babylon.js new viewer can help make the code smaller. It can come with UI elements like loading bars, animation controls, etc.\n\nCurrent Canvas3D size : 4.6Mb\nUpdated Canvas3D size: 1.2Mb",
"numb... | 727401a0cc32b8533273a71b66d996aa11826654 | {
"head_commit": "e1d3ba1e2185a48efa18f2426a4c04956159d77a",
"head_commit_message": "add changeset",
"patch_to_review": "diff --git a/.changeset/old-lamps-wash.md b/.changeset/old-lamps-wash.md\nnew file mode 100644\nindex 0000000000..20e608abbc\n--- /dev/null\n+++ b/.changeset/old-lamps-wash.md\n@@ -0,0 +1,6 @@\... | [
{
"diff_hunk": "@@ -52,176 +42,91 @@\n \n \t/* BabylonJS engine and scene management */\n \tlet canvas: HTMLCanvasElement;\n-\tlet scene: BABYLON.Scene;\n-\tlet engine: BABYLON.Engine;\n-\tlet point_cloud_system: BABYLON.PointsCloudSystem | null = null;\n+\tlet viewer: BABYLON_VIEWER.Viewer;\n+\tlet viewerDetai... | 4cb75619ffbb5f09ac4c29795ff1e7d06c3ce3ca | diff --git a/.changeset/old-lamps-wash.md b/.changeset/old-lamps-wash.md
new file mode 100644
index 0000000000..0d51d40eb0
--- /dev/null
+++ b/.changeset/old-lamps-wash.md
@@ -0,0 +1,7 @@
+---
+"@gradio/image": patch
+"@gradio/model3d": patch
+"gradio": patch
+---
+
+feat:Babylon update for model3D
diff --git a/js/imag... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Performance Optimizations"
} | |
huggingface__datasets-3556@cdcf197 | huggingface/datasets | Python | 3,556 | Preserve encoding/decoding with features in `Iterable.map` call | As described in https://github.com/huggingface/datasets/issues/3505#issuecomment-1004755657, this PR uses a generator expression to encode/decode examples with `features` (which are set to None in `map`) before applying a map transform.
Fix #3505 | 2022-01-10T13:32:20Z | cast_column function not working with map function in streaming mode for Audio features
## Describe the bug
I am trying to use Audio class for loading audio features using custom dataset. I am able to cast 'audio' feature into 'Audio' format with cast_column function. On using map function, I am not getting 'Audio' ca... | Hi! This is probably due to the fact that `IterableDataset.map` sets `features` to `None` before mapping examples. We can fix the issue by passing the old `features` dict to the map generator and performing encoding/decoding there (before calling the map transform function). | [
{
"body": "## Describe the bug\r\nI am trying to use Audio class for loading audio features using custom dataset. I am able to cast 'audio' feature into 'Audio' format with cast_column function. On using map function, I am not getting 'Audio' casted feature but getting path of audio file only.\r\nI am getting f... | bb3e6012609df6d45231729c78d7b0806ed41c6c | {
"head_commit": "cdcf197a205e9bd9a8463b3ebc33bf9bbae680ee",
"head_commit_message": "Add test",
"patch_to_review": "diff --git a/src/datasets/iterable_dataset.py b/src/datasets/iterable_dataset.py\nindex 25144b515eb..a8375bbc84d 100644\n--- a/src/datasets/iterable_dataset.py\n+++ b/src/datasets/iterable_dataset.p... | [
{
"diff_hunk": "@@ -164,7 +182,11 @@ def shuffle_data_sources(self, seed: Optional[int]) -> \"RandomlyCyclingMultiSour\n \n class MappedExamplesIterable(_BaseExamplesIterable):\n def __init__(\n- self, ex_iterable: _BaseExamplesIterable, function: Callable, batched: bool = False, batch_size: int = 10... | 0da0db4461680c9b6a92507a4420ad5abde3dfa8 | diff --git a/src/datasets/combine.py b/src/datasets/combine.py
index 911e56b7dbf..b7c3fe5d8f8 100644
--- a/src/datasets/combine.py
+++ b/src/datasets/combine.py
@@ -174,14 +174,15 @@ def _interleave_iterable_datasets(
"""
from .iterable_dataset import (
CyclingMultiSourcesExamplesIterable,
- M... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
gradio-app__gradio-10814@e8ea7bf | gradio-app/gradio | Python | 10,814 | Adds a watermark parameter to `gr.Chatbot` that is added to copied text | In the spirit of letting developers easily build "good ml apps" that follow relevant regulations (see https://github.com/gradio-app/gradio/issues/10756), this PR adds a `watermark` parameter to `gr.Chatbot` analogous to https://github.com/gradio-app/gradio/pull/8900
Closes: https://github.com/gradio-app/gradio/issue... | 2025-03-16T09:20:34Z | Add a `watermark` parameter to `gr.Chatbot` that is added to copied text
When a user copies the text generated by the LLM, this triggers the event ChatBot.copy, which is great. But the listener only gives you the copied text, and does not let you modify it.
In order to comply with the EU AI Act, chatbots should give ... | Hi @surak yes it's not possible to modify the clipboard value in the `.copy()` method. I suppose you could do something like this:
```py
import gradio as gr
value = """
Hi <span style="display:none">Generated by AI</span>
"""
with gr.Blocks() as demo:
c = gr.Chatbot([(value, value)], show_copy_button=True)
demo... | [
{
"body": "When a user copies the text generated by the LLM, this triggers the event ChatBot.copy, which is great. But the listener only gives you the copied text, and does not let you modify it.\n\nIn order to comply with the EU AI Act, chatbots should give a kind of watermark on generated content. For text, a... | 4fa8e00c31812797d1a73d18f1e0ce7cdf17ab27 | {
"head_commit": "e8ea7bff301fcbfffbe23bade1ef3b83a93f48fc",
"head_commit_message": "test",
"patch_to_review": "diff --git a/.changeset/fifty-yaks-trade.md b/.changeset/fifty-yaks-trade.md\nnew file mode 100644\nindex 0000000000..64dc245556\n--- /dev/null\n+++ b/.changeset/fifty-yaks-trade.md\n@@ -0,0 +1,6 @@\n+-... | [
{
"diff_hunk": "@@ -225,6 +225,7 @@ def __init__(\n rtl: bool = False,\n show_share_button: bool | None = None,\n show_copy_button: bool = False,\n+ watermark: str | None = None, # New parameter for watermark text",
"line": null,
"original_line": 228,
"original_start_... | 1a917bb0f5bf8fc0fad08ece5edf64b44308e0b9 | diff --git a/.changeset/fifty-yaks-trade.md b/.changeset/fifty-yaks-trade.md
new file mode 100644
index 0000000000..64dc245556
--- /dev/null
+++ b/.changeset/fifty-yaks-trade.md
@@ -0,0 +1,6 @@
+---
+"@gradio/chatbot": minor
+"gradio": minor
+---
+
+feat:Adds a watermark parameter to `gr.Chatbot` that is added to copie... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
gradio-app__gradio-10692@fae3202 | gradio-app/gradio | Python | 10,692 | Add a demo for highlighting text in a pdf file for LLM RAG purposes | ## Description
Add a demo for highlighting text in a pdf file for LLM RAG purposes
Closes: #10691
## 🎯 PRs Should Target Issues
Before your create a PR, please check to see if there is [an existing issue](https://github.com/gradio-app/gradio/issues) for this change. If not, please create an issue before yo... | 2025-02-27T15:13:09Z | Demo for highlighting text in a pdf file for LLM RAG purposes
- [x] I have searched to see if a similar issue already exists.
**Is your feature request related to a problem? Please describe.**
I wanted a way to simply show a PDF with highlighted text at the right page (for LLM RAG purposes).
**Describe the solution... | [
{
"body": "- [x] I have searched to see if a similar issue already exists.\n\n**Is your feature request related to a problem? Please describe.** \nI wanted a way to simply show a PDF with highlighted text at the right page (for LLM RAG purposes).\n\n**Describe the solution you'd like** \nA demo to build such ... | 2b3842066bc625518afeb182d65d2ef37a3e835e | {
"head_commit": "fae320267f0bfe64acce15fc6aac2c108dcde607",
"head_commit_message": "Merge branch 'main' into demo-rag-pdf",
"patch_to_review": "diff --git a/demo/llm_rag_text_highlight_pdf/Lorem_ipsum.pdf b/demo/llm_rag_text_highlight_pdf/Lorem_ipsum.pdf\nnew file mode 100644\nindex 0000000000..186e9010b4\nBinar... | [
{
"diff_hunk": "@@ -0,0 +1,52 @@\n+import gradio as gr\n+from gradio_pdf import PDF\n+import pymupdf\n+import os\n+from pathlib import Path\n+\n+current_dir = Path(os.path.abspath(''))\n+\n+def highlight_text_in_pdf(pdf_file: Path, highlight_text: str):\n+ page_number = 0\n+ doc = pymupdf.open(pdf_file)\n... | dffd23a63075ca5d83ea863307396c505331645b | diff --git a/demo/highlight_pdf/Lorem_ipsum.pdf b/demo/highlight_pdf/Lorem_ipsum.pdf
new file mode 100644
index 0000000000..186e9010b4
Binary files /dev/null and b/demo/highlight_pdf/Lorem_ipsum.pdf differ
diff --git a/demo/highlight_pdf/requirements.txt b/demo/highlight_pdf/requirements.txt
new file mode 100644
index ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
huggingface__datasets-3277@880f7b0 | huggingface/datasets | Python | 3,277 | f-string formatting | **Fix #3257**
Replaced _.format()_ and _%_ by f-strings in the following modules :
- [x] **tests**
- [x] **metrics**
- [x] **benchmarks**
- [x] **utils**
- [x] **templates**
- [x] **src/Datasets/\*.py**
Modules in **_src/Datasets/_**:
- [x] **commands**
- [x] **features**
- [x] **formatting**
- [x] **... | 2021-11-15T21:37:05Z | Use f-strings for string formatting
f-strings offer better readability/performance than `str.format` and `%`, so we should use them in all places in our codebase unless there is good reason to keep the older syntax.
> **NOTE FOR CONTRIBUTORS**: To avoid large PRs and possible merge conflicts, do 1-3 modules per PR.... | Hi, I would be glad to help with this. Is there anyone else working on it?
Hi, I would be glad to work on this too.
#self-assign | [
{
"body": "f-strings offer better readability/performance than `str.format` and `%`, so we should use them in all places in our codebase unless there is good reason to keep the older syntax.\r\n\r\n> **NOTE FOR CONTRIBUTORS**: To avoid large PRs and possible merge conflicts, do 1-3 modules per PR. Also, feel fr... | d8a998cf2deb18fe0b55361ec4218f91ffdb8be9 | {
"head_commit": "880f7b0c40aaed1956b3af239e10a4a9cbcba2bb",
"head_commit_message": "make style on edited files",
"patch_to_review": "diff --git a/benchmarks/format.py b/benchmarks/format.py\nindex b834b74c414..7ab2a564ff2 100644\n--- a/benchmarks/format.py\n+++ b/benchmarks/format.py\n@@ -24,12 +24,12 @@ def for... | [
{
"diff_hunk": "@@ -320,7 +320,7 @@ def test_sort(self):\n self.assertListEqual(list(dsets.keys()), list(sorted_dsets_1.keys()))\n self.assertListEqual(\n [f.split(\"_\")[-1] for f in sorted_dsets_1[\"train\"][\"filename\"]],\n- sorted(\"{:03d}\".format(x) ... | 36f2ca73abf3a221d4ded4d6579f24f3e81ce540 | diff --git a/benchmarks/format.py b/benchmarks/format.py
index b834b74c414..7ab2a564ff2 100644
--- a/benchmarks/format.py
+++ b/benchmarks/format.py
@@ -24,12 +24,12 @@ def format_json_to_md(input_json_file, output_md_file):
old_val = metric_vals.get("old", None)
dif_val = metric_vals.get("dif... | {
"difficulty": "low",
"estimated_review_effort": 3,
"problem_domain": "Code Style, Linting, Formatting Fixes"
} |
home-assistant__core-134063@e9543f8 | home-assistant/core | Python | 134,063 | Change SimpliSafe websocket reconnection log to `DEBUG`-level | <!--
You are amazing! Thanks for contributing to our project!
Please, DO NOT DELETE ANY TEXT from this template! (unless instructed).
-->
## Proposed change
<!--
Describe the big picture of your changes here to communicate to the
maintainers why we should accept this pull request. If it fixes a bug
or... | 2024-12-26T21:53:26Z | SimpliSafe - Reconnecting to websocket
### The problem
Receiving the below warning in the Core logs - is this a known issue or is there a fix?
Logger: homeassistant.components.simplisafe
Source: components/simplisafe/__init__.py:488
integration: SimpliSafe (documentation, issues)
First occurred: October 15, 2024... | Hey there @bachya, mind taking a look at this issue as it has been labeled with an integration (`simplisafe`) you are listed as a [code owner](https://github.com/home-assistant/core/blob/dev/CODEOWNERS#L1336) for? Thanks!
<details>
<summary>Code owner commands</summary>
Code owners of `simplisafe` can trigger bot ac... | [
{
"body": "### The problem\n\nReceiving the below warning in the Core logs - is this a known issue or is there a fix?\r\n\r\nLogger: homeassistant.components.simplisafe\r\nSource: components/simplisafe/__init__.py:488\r\nintegration: SimpliSafe (documentation, issues)\r\nFirst occurred: October 15, 2024 at 8:54... | a9ff5b80073eea785a3c616c8959a8ed0b0d777f | {
"head_commit": "e9543f8d20117f51b7cb1189ffb224f614e8a213",
"head_commit_message": "Change SimpliSafe websocket reconnection log to `DEBUG`-level",
"patch_to_review": "diff --git a/homeassistant/components/simplisafe/__init__.py b/homeassistant/components/simplisafe/__init__.py\nindex b72519f973480..df434e0a775c... | [
{
"diff_hunk": "@@ -248,7 +248,7 @@ def _async_register_base_station(\n \n # Check for an old system ID format and remove it:\n if old_base_station := device_registry.async_get_device(\n- identifiers={(DOMAIN, system.system_id)} # type: ignore[arg-type]",
"line": null,
"original_line": 2... | 396aa11409f83cf751417d9f25ee75a1d0fdf6fd | diff --git a/homeassistant/components/simplisafe/__init__.py b/homeassistant/components/simplisafe/__init__.py
index b72519f9734808..2f19c5117a41ab 100644
--- a/homeassistant/components/simplisafe/__init__.py
+++ b/homeassistant/components/simplisafe/__init__.py
@@ -485,7 +485,7 @@ async def _async_start_websocket_loop... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "Bug Fixes"
} |
iterative__dvc-7687@9f5cb58 | iterative/dvc | Python | 7,687 | Fail on sync when there is no match for glob. | Closes #7492
* [x] ❗ I have followed the [Contributing to DVC](https://dvc.org/doc/user-guide/contributing/core) checklist.
* [x] 📖 If this PR requires [documentation](https://dvc.org/doc) updates, I have created a separate PR (or issue, at least) in [dvc.org](https://github.com/iterative/dvc.org) and linked it... | 2022-05-03T12:23:58Z | push/pull: globs that match no targets should fail
When using `--glob` with `push` or `pull`, a glob that matches no targets will instead act on all targets. In other words, `dvc push/pull --glob 'nomatches*'` will be the same as `dvc push/pull/repro` without any target argument.
```
$ mkdir repo
$ mkdir dvcremote... | See https://github.com/iterative/dvc/issues/7462#issuecomment-1070954669
I have created https://github.com/iterative/dvc/pull/7687 to raise an exception when there is no match for glob in push/pull. | [
{
"body": "When using `--glob` with `push` or `pull`, a glob that matches no targets will instead act on all targets. In other words, `dvc push/pull --glob 'nomatches*'` will be the same as `dvc push/pull/repro` without any target argument.\r\n\r\n```\r\n$ mkdir repo\r\n$ mkdir dvcremote\r\n$ cd repo\r\n$ git i... | 5067e1f5bc3335431c50b670282b1c85f11f3d3e | {
"head_commit": "9f5cb58693e4afe1527143c13f00db52fb67df02",
"head_commit_message": "Update tests/func/test_data_cloud.py\n\nCo-authored-by: David de la Iglesia Castro <daviddelaiglesiacastro@gmail.com>",
"patch_to_review": "diff --git a/dvc/exceptions.py b/dvc/exceptions.py\nindex 127d46362d..26afde5858 100644\n... | [
{
"diff_hunk": "@@ -349,3 +349,9 @@ def __init__(self, dep, a, b):\n class PrettyDvcException(DvcException):\n def __pretty_exc__(self, **kwargs):\n \"\"\"Print prettier exception message.\"\"\"\n+\n+\n+class GlobDoesNotMatchError(DvcException):\n+ def __init__(self, glob):\n+ msg = f\"Glo... | b7c9a9f86e59419c57b19cc8524e9fdddd6ded41 | diff --git a/dvc/utils/__init__.py b/dvc/utils/__init__.py
index 81157ed997..05e3545f6b 100644
--- a/dvc/utils/__init__.py
+++ b/dvc/utils/__init__.py
@@ -476,17 +476,25 @@ def is_exec(mode):
def glob_targets(targets, glob=True, recursive=True):
+ from ..exceptions import DvcException
+
if not glob:
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
huggingface__datasets-3030@07e399a | huggingface/datasets | Python | 3,030 | Add `remove_columns` to `IterableDataset` | Fixes #2944
WIP
* Not tested yet.
* We might want to allow batched remove for efficiency.
@lhoestq Do you think it should have `batched=` and `batch_size=`? | 2021-10-05T14:58:33Z | Add `remove_columns` to `IterableDataset `
**Is your feature request related to a problem? Please describe.**
A clear and concise description of what the problem is.
```python
from datasets import load_dataset
dataset = load_dataset("c4", 'realnewslike', streaming =True, split='train')
dataset = dataset.remove... | Hi ! Good idea :)
If you are interested in contributing, feel free to give it a try and open a Pull Request. Also let me know if I can help you with this or if you have questions | [
{
"body": "**Is your feature request related to a problem? Please describe.**\r\nA clear and concise description of what the problem is.\r\n\r\n```python\r\nfrom datasets import load_dataset\r\ndataset = load_dataset(\"c4\", 'realnewslike', streaming =True, split='train')\r\ndataset = dataset.remove_columns('ur... | 83bc8a2f01a993233b7d7806c3bda5b6a657ef40 | {
"head_commit": "07e399aa7333ff20dcc51fe9b9334387952f48ad",
"head_commit_message": "Add missing import",
"patch_to_review": "diff --git a/src/datasets/iterable_dataset.py b/src/datasets/iterable_dataset.py\nindex b1df83dfcf1..4594af9bd56 100644\n--- a/src/datasets/iterable_dataset.py\n+++ b/src/datasets/iterable... | [
{
"diff_hunk": "@@ -471,6 +471,29 @@ def take(self, n) -> \"IterableDataset\":\n shuffling=copy.deepcopy(self._shuffling),\n )\n \n+ def remove_columns(self, column_names: Union[str, List[str]]) -> \"IterableDataset\":\n+ \"\"\"\n+ Remove one or several column(s) in the data... | bcc75564a7698ec603d5000f324e14afd02bb602 | diff --git a/docs/source/package_reference/main_classes.rst b/docs/source/package_reference/main_classes.rst
index e7e9bf27a4c..d51f36e1f33 100644
--- a/docs/source/package_reference/main_classes.rst
+++ b/docs/source/package_reference/main_classes.rst
@@ -69,6 +69,7 @@ The base class :class:`datasets.IterableDataset` ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
gradio-app__gradio-10403@4b52dbd | gradio-app/gradio | Python | 10,403 | Fix event triggers and recent regressions related to `gr.DataFrame` | Fixes a few things that were broken or broke as a result of recent PRs
* Does not fire .change() and .input() events when the page first loads (closes: #8231 and adds a test)
* Fixes .input() event to fire when a user inputs data (because of a recent regression, it was not firing at all)
* Fixes the cell selection... | 2025-01-22T01:06:23Z | The `.input()` and `.change()` events in gr.Dataframe are also triggered at function updates and at app start
### Describe the bug
The input event of the dataframe should only be triggered, when the user makes inputs but it is also triggered at app startup and when a function makes changes.
### Have you searched exis... | Hi, apologies for the late follow up. We haven't had a chance to look into this issue yet, but the Gradio codebase has changed quite significantly since this issue was created, particularly with the release of Gradio 5. Could you let us know if this is still an issue in the latest version of Gradio (`pip install --upgr... | [
{
"body": "### Describe the bug\n\nThe input event of the dataframe should only be triggered, when the user makes inputs but it is also triggered at app startup and when a function makes changes.\n\n### Have you searched existing issues? 🔎\n\n- [X] I have searched and found no existing issues\n\n### Reproduct... | 9dc5d157aaf002f7699d3b2c1652f49d47e53e80 | {
"head_commit": "4b52dbdad48bb2bad71d29a2237bee48023a879e",
"head_commit_message": "changes",
"patch_to_review": "diff --git a/.changeset/sixty-impalas-bathe.md b/.changeset/sixty-impalas-bathe.md\nnew file mode 100644\nindex 0000000000..d04a93a42e\n--- /dev/null\n+++ b/.changeset/sixty-impalas-bathe.md\n@@ -0,0... | [
{
"diff_hunk": "@@ -144,34 +144,42 @@\n \t}\n \n \tlet _headers = make_headers(headers);\n-\tlet old_headers: string[] | undefined;\n+\tlet old_headers: string[] = headers;\n \n \t$: {\n \t\tif (!dequal(headers, old_headers)) {\n-\t\t\ttrigger_headers();\n+\t\t\t_headers = make_headers(headers);\n+\t\t\told_hea... | 215b9e933f9804ac80da3631da16d1c221172271 | diff --git a/.changeset/sixty-impalas-bathe.md b/.changeset/sixty-impalas-bathe.md
new file mode 100644
index 0000000000..d04a93a42e
--- /dev/null
+++ b/.changeset/sixty-impalas-bathe.md
@@ -0,0 +1,6 @@
+---
+"@gradio/dataframe": patch
+"gradio": patch
+---
+
+fix:Fix event triggers and recent regressions related to `g... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
gradio-app__gradio-10433@2f2c281 | gradio-app/gradio | Python | 10,433 | Allow building multipage Gradio apps | Closes: https://github.com/gradio-app/gradio/issues/2654
Implemented multipage. This is the syntax:
```python
import gradio as gr
with gr.Blocks() as demo:
name = gr.Textbox(label="Name")
...
with demo.route("Test", "/test"):
num = gr.Number()
....
demo.launch()
```
See `demo/mul... | 2025-01-24T16:07:15Z | Support multiple pages in a gradio app
- [x] I have searched to see if a similar issue already exists.
**Is your feature request related to a problem? Please describe.**
It would be good to distinct pages for different parts of a gradio app, including the ability to navigate directly to that page using the url.... | Besides direct URLs, what functionality does a `gr.Page()` allow that a `gr.Tab()` doesn't? All sorts of interesting cases pop up with pages -- e.g. can pages be nested inside other pages similar to tabs? Can you `.load()` a Space with pages inside of another Gradio app? We could implement it but I'm not sure if the va... | [
{
"body": "- [x] I have searched to see if a similar issue already exists.\r\n\r\n\r\n**Is your feature request related to a problem? Please describe.** \r\nIt would be good to distinct pages for different parts of a gradio app, including the ability to navigate directly to that page using the url. This featur... | 35fda36de9745757298cafb3d8b91cbc1a4358c9 | {
"head_commit": "2f2c28139365582374711381e893dac78a288803",
"head_commit_message": "chagnes",
"patch_to_review": "diff --git a/.changeset/large-beans-retire.md b/.changeset/large-beans-retire.md\nnew file mode 100644\nindex 0000000000..5c34ae4ac6\n--- /dev/null\n+++ b/.changeset/large-beans-retire.md\n@@ -0,0 +1... | [
{
"diff_hunk": "@@ -51,6 +51,9 @@\n \texport let max_file_size: number | undefined = undefined;\n \texport let initial_layout: ComponentMeta | undefined = undefined;\n \texport let css: string | null | undefined = null;\n+\texport let pages: [string, string][] = [];\n+\texport let current_page: string = \"\";",... | 1fb08530e719e073c9741898d6923c51d2b3f547 | diff --git a/.changeset/large-beans-retire.md b/.changeset/large-beans-retire.md
new file mode 100644
index 0000000000..099398ea7c
--- /dev/null
+++ b/.changeset/large-beans-retire.md
@@ -0,0 +1,10 @@
+---
+"@gradio/client": minor
+"@gradio/core": minor
+"@gradio/lite": minor
+"@self/app": minor
+"@self/spa": minor
+"g... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
huggingface__datasets-3129@3d35ada | huggingface/datasets | Python | 3,129 | Support Audio feature for TAR archives in sequential access | Add Audio feature support for TAR archived files in sequential access.
Fix #3128. | 2021-10-21T08:56:51Z | Support Audio feature for TAR archives in sequential access
Currently, Audio feature accesses each audio file by their file path.
However, streamed TAR archive files do not allow random access to their archived files.
Therefore, we should enhance the Audio feature to support TAR archived files in sequential acces... | [
{
"body": "Currently, Audio feature accesses each audio file by their file path.\r\n\r\nHowever, streamed TAR archive files do not allow random access to their archived files.\r\n\r\nTherefore, we should enhance the Audio feature to support TAR archived files in sequential access.",
"number": 3128,
"tit... | ed1b4921a126ce007e6d2bb859730eb6a0fedbb8 | {
"head_commit": "3d35adac5162d0b3679bfa317023fb27c3f41897",
"head_commit_message": "Enhance Audio.decode_example to accept a string",
"patch_to_review": "diff --git a/src/datasets/features/audio.py b/src/datasets/features/audio.py\nindex c2261b40344..1bac3f33ac1 100644\n--- a/src/datasets/features/audio.py\n+++ ... | [
{
"diff_hunk": "@@ -23,24 +33,51 @@ class Audio:\n _type: str = field(default=\"Audio\", init=False, repr=False)\n \n def __call__(self):\n- return pa.string()\n+ return pa.struct({\"path\": pa.string(), \"bytes\": pa.binary()})\n+\n+ def encode_example(self, value):\n+ \"\"\"Enc... | 2468e2e592adecdba8c55a4ca00fdba522237675 | diff --git a/.github/workflows/test-audio.yml b/.github/workflows/test-audio.yml
index fa9764145c7..68e0b8f0b3b 100644
--- a/.github/workflows/test-audio.yml
+++ b/.github/workflows/test-audio.yml
@@ -1,9 +1,6 @@
name: Test audio
on:
- push:
- branches:
- - master
pull_request:
branches:
- maste... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
home-assistant__core-134816@3e99393 | home-assistant/core | Python | 134,816 | Rework velbus services to deprecated the interface parameter | ## Proposed change
<!--
Describe the big picture of your changes here to communicate to the
maintainers why we should accept this pull request. If it fixes a bug
or resolves a feature request, be sure to link to that issue in the
additional information section.
-->
Currently the velbus services use a i... | 2025-01-05T18:02:09Z | [Velbus] Set_memo_text not working in HA 2025.1
### The problem
set_memo_text does not display any text anymore on module VMBELO since HA2025.1
### What version of Home Assistant Core has the issue?
2025.1.0
### What was the last working version of Home Assistant Core?
2024.12.5
### What type of insta... | [
{
"body": "### The problem\r\n\r\nset_memo_text does not display any text anymore on module VMBELO since HA2025.1\r\n\r\n### What version of Home Assistant Core has the issue?\r\n\r\n2025.1.0\r\n\r\n### What was the last working version of Home Assistant Core?\r\n\r\n2024.12.5\r\n\r\n### What type of installati... | e67a131bd905b8faafdc429eab9414c171ee35d0 | {
"head_commit": "3e993936fbc2a8f605b130c3d6e26545fa28ca0b",
"head_commit_message": "Rework velbus services to deprecated the interface parameter",
"patch_to_review": "diff --git a/homeassistant/components/velbus/const.py b/homeassistant/components/velbus/const.py\nindex 2d9f6e98a4cd7..b40f64e860793 100644\n--- a... | [
{
"diff_hunk": "@@ -32,58 +35,76 @@ def setup_services(hass: HomeAssistant) -> None:\n \"\"\"Register the velbus services.\"\"\"\n \n def check_entry_id(interface: str) -> str:\n+ \"\"\"Check the config_entry for a specific interface.\"\"\"\n for config_entry in hass.config_entries.async_... | c230b1a5b0416dd2b3529366a1872be0df69bfe8 | diff --git a/homeassistant/components/velbus/const.py b/homeassistant/components/velbus/const.py
index 2d9f6e98a4cd7..b40f64e860793 100644
--- a/homeassistant/components/velbus/const.py
+++ b/homeassistant/components/velbus/const.py
@@ -11,6 +11,7 @@
DOMAIN: Final = "velbus"
+CONF_CONFIG_ENTRY: Final = "config_ent... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
huggingface__datasets-2986@87e2ab7 | huggingface/datasets | Python | 2,986 | Refac module factory + avoid etag requests for hub datasets | ## Refactor the module factory
When trying to extend the `data_files` logic to avoid doing unnecessary ETag requests, I noticed that the module preparation mechanism needed a refactor:
- the function was 600 lines long
- it was not readable
- it contained many different cases that made it complex to maintain
- i... | 2021-09-29T10:42:00Z | Loading allenai/c4 in streaming mode does too many HEAD requests
This does 60,000+ HEAD requests to get all the ETags of all the data files:
```python
from datasets import load_dataset
load_dataset("allenai/c4", streaming=True)
```
It makes loading the dataset completely impractical.
The ETags are used to compu... | https://github.com/huggingface/datasets/blob/6c766f9115d686182d76b1b937cb27e099c45d68/src/datasets/builder.py#L179-L186 | [
{
"body": "This does 60,000+ HEAD requests to get all the ETags of all the data files:\r\n```python\r\nfrom datasets import load_dataset\r\nload_dataset(\"allenai/c4\", streaming=True)\r\n```\r\nIt makes loading the dataset completely impractical.\r\n\r\nThe ETags are used to compute the config id (it must depe... | a766a3877cecd9f8d80e80a394e7c42198b3cad4 | {
"head_commit": "87e2ab7e034cedadbf7d1d0a86d96f1688fa60c4",
"head_commit_message": "style",
"patch_to_review": "diff --git a/metrics/comet/comet.py b/metrics/comet/comet.py\nindex 7655eb09675..a2005c4d7e4 100644\n--- a/metrics/comet/comet.py\n+++ b/metrics/comet/comet.py\n@@ -35,7 +35,7 @@\n ```\n \"\"\"\n \n-fr... | [
{
"diff_hunk": "@@ -226,604 +236,1042 @@ def get_imports(file_path: str):\n return imports\n \n \n-def _resolve_data_files_locally_or_by_urls(\n- base_path: str, patterns: Union[str, List[str], Dict], allowed_extensions: Optional[list] = None\n-) -> Union[List[Path], Dict]:\n+def _download_additional_mod... | 9fc18b9d873c90e050e19c49c5a2a49054caad75 | diff --git a/metrics/comet/comet.py b/metrics/comet/comet.py
index 7655eb09675..a2005c4d7e4 100644
--- a/metrics/comet/comet.py
+++ b/metrics/comet/comet.py
@@ -35,7 +35,7 @@
```
"""
-from comet.models import download_model # From: unbabel-comet
+import comet.models # From: unbabel-comet
import datasets
@@ -... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Performance Optimizations"
} |
huggingface__datasets-2975@de47722 | huggingface/datasets | Python | 2,975 | ignore dummy folder and dataset_infos.json | Fixes #2877
Added the `dataset_infos.json` to the ignored files list and also added check to ignore files which have parent directory as `dummy`.
Let me know if it is correct. Thanks :) | 2021-09-27T18:09:03Z | Don't keep the dummy data folder or dataset_infos.json when resolving data files
When there's no dataset script, all the data files of a folder or a repository on the Hub are loaded as data files.
There are already a few exceptions:
- files starting with "." are ignored
- the dataset card "README.md" is ignored
-... | Hi @lhoestq I am new to huggingface datasets, I would like to work on this issue! | [
{
"body": "When there's no dataset script, all the data files of a folder or a repository on the Hub are loaded as data files.\r\n\r\nThere are already a few exceptions:\r\n- files starting with \".\" are ignored\r\n- the dataset card \"README.md\" is ignored\r\n- any file named \"config.json\" is ignored (curr... | 332004ebf95c912a964cff1273b6508493b3071b | {
"head_commit": "de47722e7a76ca6093ab95631e71897dc5776c7c",
"head_commit_message": "ignore dummy folder and dataset_infos.json",
"patch_to_review": "diff --git a/src/datasets/load.py b/src/datasets/load.py\nindex e58e9e0737b..dd8c7125d7d 100644\n--- a/src/datasets/load.py\n+++ b/src/datasets/load.py\n@@ -233,7 +... | [
{
"diff_hunk": "@@ -245,7 +245,10 @@ def _resolve_data_files_locally_or_by_urls(\n matched_paths = [\n filepath.resolve()\n for filepath in glob_iter\n- if filepath.name not in data_files_ignore and not filepath.name.startswith(\".\") and filepath.is_file()\n+ ... | f3880134ac441a183513ac3d799fa30eca79a7b0 | diff --git a/src/datasets/load.py b/src/datasets/load.py
index e58e9e0737b..1549abdf09c 100644
--- a/src/datasets/load.py
+++ b/src/datasets/load.py
@@ -233,7 +233,7 @@ def _resolve_data_files_locally_or_by_urls(
Return the absolute paths to all the files that match the given patterns.
It also supports absolu... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Code Refactoring / Architectural Improvement"
} |
home-assistant__core-133159@c0110d6 | home-assistant/core | Python | 133,159 | Fix strptime in python_script | <!--
You are amazing! Thanks for contributing to our project!
Please, DO NOT DELETE ANY TEXT from this template! (unless instructed).
-->
## Proposed change
<!--
Describe the big picture of your changes here to communicate to the
maintainers why we should accept this pull request. If it fixes a bug
or... | 2024-12-13T16:06:56Z | Python Scripts : strptime no longer works
### The problem
Converting string to datetime using strptime now produces error `Error executing script (KeyError): '__import__' when running the script.)`
example:
`bookingdate = datetime.datetime.strptime("2024-04-01", "%Y-%m-%d")`
### What version of Home Assistant C... | I think you might need to import datetime first instead of using directly.
[pyscript documentation](https://www.home-assistant.io/integrations/pyscript)
[pyscript source](https://github.com/home-assistant/core/tree/dev/homeassistant/components/pyscript)
> I think you might need to import datetime first instead of using... | [
{
"body": "### The problem\r\n\r\nConverting string to datetime using strptime now produces error `Error executing script (KeyError): '__import__' when running the script.)`\r\nexample:\r\n`bookingdate = datetime.datetime.strptime(\"2024-04-01\", \"%Y-%m-%d\")`\r\n\r\n### What version of Home Assistant Core has... | a812b594aac3f274b9ba660b7d778e62d8b9d389 | {
"head_commit": "c0110d6c3196187c78fa236620d3022c82e885ba",
"head_commit_message": "Fix strptime in python_script",
"patch_to_review": "diff --git a/homeassistant/components/python_script/__init__.py b/homeassistant/components/python_script/__init__.py\nindex 70e9c5b0d29a78..806278724f439f 100644\n--- a/homeassi... | [
{
"diff_hunk": "@@ -688,3 +688,27 @@ async def test_prohibited_augmented_assignment_operations(\n hass.async_add_executor_job(execute, hass, \"aug_assign_prohibited.py\", case, {})\n await hass.async_block_till_done(wait_background_tasks=True)\n assert error in caplog.text\n+\n+\n+async def test_imp... | e91f0f16f5f22439337fd6a625b2b87044e63fe6 | diff --git a/homeassistant/components/python_script/__init__.py b/homeassistant/components/python_script/__init__.py
index 70e9c5b0d29a78..af7732780293d9 100644
--- a/homeassistant/components/python_script/__init__.py
+++ b/homeassistant/components/python_script/__init__.py
@@ -1,5 +1,6 @@
"""Component to allow runnin... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
gradio-app__gradio-10203@4578d7a | gradio-app/gradio | Python | 10,203 | Allow editing chatbot messages | Adds the ability to edit chatbot messages. See below:
In a followup PR, I still need to:
- Allow editing non-text messages (images, etc.)
- Add editing to ChatInterface by default
- When messages ... | 2024-12-15T20:43:18Z | Allow editing of messages in Chatbot
- [x] I have searched to see if a similar issue already exists.
**Is your feature request related to a problem? Please describe.**
It would be nice if we could add an option to allow people to edit both their and a chatbot's message.
**Describe the solution you'd like** ... | Can you describe the use case for this a bit?
Sure! Would be nice for data collection, data editing, data review, etc as well as steerable writing (ie to help write blog posts/essays/etc)
I see, wouldn't a `gr.Textbox` output be more useful for these use cases? It seems a bit cumbersome to edit an essay within a Chatbo... | [
{
"body": "- [x] I have searched to see if a similar issue already exists.\r\n\r\n\r\n**Is your feature request related to a problem? Please describe.** \r\nIt would be nice if we could add an option to allow people to edit both their and a chatbot's message.\r\n\r\n**Describe the solution you'd like** \r\nAd... | 9c6d83d12e4b67c5638ba67281c6f018052c5b3e | {
"head_commit": "4578d7a7d7d0041461f300c192bd8b7386153412",
"head_commit_message": "changes",
"patch_to_review": "diff --git a/.changeset/angry-times-float.md b/.changeset/angry-times-float.md\nnew file mode 100644\nindex 0000000000..e9bd59032b\n--- /dev/null\n+++ b/.changeset/angry-times-float.md\n@@ -0,0 +1,6 ... | [
{
"diff_hunk": "@@ -371,6 +371,38 @@ def __init__(self, target: Block | None, data: Any):\n \"\"\"\n \n \n+@document()\n+class EditData(EventData):\n+ \"\"\"\n+ The gr.UndoData class is a subclass of gr.Event data that specifically carries information about the `.edit()` event. When gr.EditData",
... | 3c7a6885eabf1171b59c125703c2cf627938cf64 | diff --git a/.changeset/angry-times-float.md b/.changeset/angry-times-float.md
new file mode 100644
index 0000000000..e9bd59032b
--- /dev/null
+++ b/.changeset/angry-times-float.md
@@ -0,0 +1,6 @@
+---
+"@gradio/chatbot": minor
+"gradio": minor
+---
+
+feat:Allow editing chatbot messages
diff --git a/demo/chatbot_edita... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
huggingface__datasets-2731@ef9a7bb | huggingface/datasets | Python | 2,731 | Adding to_tf_dataset method | Oh my **god** do not merge this yet, it's just a draft.
I've added a method (via a mixin) to the `arrow_dataset.Dataset` class that automatically converts our Dataset classes to TF Dataset classes ready for training. It hopefully has most of the features we want, including streaming from disk (no need to load the wh... | 2021-07-29T18:10:25Z | Mutable columns argument breaks set_format
## Describe the bug
If you pass a mutable list to the `columns` argument of `set_format` and then change the list afterwards, the returned columns also change.
## Steps to reproduce the bug
```python
from datasets import load_dataset
dataset = load_dataset("glue", "cola... | [
{
"body": "## Describe the bug\r\nIf you pass a mutable list to the `columns` argument of `set_format` and then change the list afterwards, the returned columns also change.\r\n\r\n## Steps to reproduce the bug\r\n```python\r\nfrom datasets import load_dataset\r\ndataset = load_dataset(\"glue\", \"cola\")\r\n\r... | 03d958d3f64d4a0ffe5a0d3a80b2ad33a1e1dfbf | {
"head_commit": "ef9a7bb211841c37a8a22c5b44a2a81dffd65b06",
"head_commit_message": "Fix issues with passing a mutable list to columns argument",
"patch_to_review": "diff --git a/src/datasets/arrow_dataset.py b/src/datasets/arrow_dataset.py\nindex 5361c54664c..96e32131e43 100644\n--- a/src/datasets/arrow_dataset.... | [
{
"diff_hunk": "@@ -159,6 +159,252 @@ def version(self):\n return self._info.version\n \n \n+class TensorflowDatasetMixIn:\n+ def __init__(self):\n+ pass\n+\n+ @staticmethod\n+ def _get_output_signature(dataset, cols_to_retain, test_batch, batch_size):\n+ if config.TF_AVAILABLE:\n... | 397bcb72ca4789d25f0bce07e43a23580812b7d2 | diff --git a/src/datasets/arrow_dataset.py b/src/datasets/arrow_dataset.py
index 07915094229..cefc848eb00 100644
--- a/src/datasets/arrow_dataset.py
+++ b/src/datasets/arrow_dataset.py
@@ -44,7 +44,7 @@
from . import config, utils
from .arrow_reader import ArrowReader
from .arrow_writer import ArrowWriter, Optimized... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} | |
gradio-app__gradio-10225@7c4dc47 | gradio-app/gradio | Python | 10,225 | Dataframe support in Chatbot | ## Description
Add Dataframe component support in chatbot. Test with `chatbot_core_components` demo.
Closes: #8657
## 🎯 PRs Should Target Issues
Before your create a PR, please check... | 2024-12-19T00:21:12Z | gr.Chatbot cannot use gr.Markdown / gr.DataFrame while showing the results
- [y] I have searched to see if a similar issue already exists.
**Is your feature request related to a problem? Please describe.**
I want to use gr.DataFrame in output of chatbot.
**Describe the solution you'd like**
Show the result ... | I believe `gr.Markdown` is supported but `gr.DataFrame` is not supported. @dawoodkhan82 can you confirm? Also we should have a helpful error if an unsupported component is used in the output.
> I believe `gr.Markdown` is supported but `gr.DataFrame` is not supported. @dawoodkhan82 can you confirm? Also we should have ... | [
{
"body": "- [y] I have searched to see if a similar issue already exists.\r\n\r\n**Is your feature request related to a problem? Please describe.** \r\nI want to use gr.DataFrame in output of chatbot.\r\n\r\n**Describe the solution you'd like** \r\nShow the result of gr.DataFrame as a table inside chatbot re... | 45df1b1978e597546a208ecbf5b3aca56137edc5 | {
"head_commit": "7c4dc47f3ec4d40b2927da2835f812e75d84d837",
"head_commit_message": "add changeset",
"patch_to_review": "diff --git a/.changeset/long-months-wave.md b/.changeset/long-months-wave.md\nnew file mode 100644\nindex 0000000000..adfcda1fe6\n--- /dev/null\n+++ b/.changeset/long-months-wave.md\n@@ -0,0 +1... | [
{
"diff_hunk": "@@ -27,6 +34,27 @@\n \t\tfixed_height={1}\n \t\ton:load\n \t/>\n+{:else if type === \"dataframe\"}\n+\t<svelte:component\n+\t\tthis={components[type]}\n+\t\t{value}\n+\t\tshow_label={false}\n+\t\t{i18n}\n+\t\tlabel=\"\"\n+\t\t{_fetch}\n+\t\tallow_preview={false}\n+\t\tinteractive={false}\n+\t\tm... | 2ceb373d8d9e5e2e25d7ad1c2c815b81368e0707 | diff --git a/.changeset/long-months-wave.md b/.changeset/long-months-wave.md
new file mode 100644
index 0000000000..adfcda1fe6
--- /dev/null
+++ b/.changeset/long-months-wave.md
@@ -0,0 +1,6 @@
+---
+"@gradio/chatbot": minor
+"gradio": minor
+---
+
+feat:Dataframe support in Chatbot
diff --git a/demo/chatbot_core_compo... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
gradio-app__gradio-10169@54a2956 | gradio-app/gradio | Python | 10,169 | Group chatbot messages by default | ## Description
Closes: #8850
By default, consecutive messages are displayed in the same bubble. This is controlled by the new `display_consecutive_in_same_bubble` param of Chatbot.
## 🎯 PRs Should Tar... | 2024-12-10T18:39:48Z | Be able to control grouping of chatbot messages
- [ ] I have searched to see if a similar issue already exists.
**Is your feature request related to a problem? Please describe.**
By default, consecutive messages with the same role are grouped in the same bubble. Some people may want to control the grouping beha... | Consecutive messages are no longer grouped by default as of version 5.0 | [
{
"body": "- [ ] I have searched to see if a similar issue already exists.\r\n\r\n\r\n**Is your feature request related to a problem? Please describe.** \r\nBy default, consecutive messages with the same role are grouped in the same bubble. Some people may want to control the grouping behavior / opt out of it.... | b4004e37ae2e4c61c25012802a9d7aa559a2e690 | {
"head_commit": "54a2956fd4169cb9cdb3fa05a1ddce3462f433a0",
"head_commit_message": "Revert \"remove thought css\"\n\nThis reverts commit f1ea8f88f6ced9dc8e8897abdfd529952f851954.",
"patch_to_review": "diff --git a/.changeset/solid-hands-nail.md b/.changeset/solid-hands-nail.md\nnew file mode 100644\nindex 000000... | [
{
"diff_hunk": "@@ -198,6 +198,7 @@ def __init__(\n examples: list[ExampleMessage] | None = None,\n show_copy_all_button=False,\n allow_file_downloads=True,\n+ display_consecutive_in_same_bubble: bool = True,",
"line": null,
"original_line": 201,
"original_start_line":... | c5e4d46c5c47779fdc6751496095a2ec5af83f45 | diff --git a/.changeset/solid-hands-nail.md b/.changeset/solid-hands-nail.md
new file mode 100644
index 0000000000..d9ee961e3c
--- /dev/null
+++ b/.changeset/solid-hands-nail.md
@@ -0,0 +1,6 @@
+---
+"@gradio/chatbot": minor
+"gradio": minor
+---
+
+feat:By default, consecutive messages are displayed in the same bubble... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
huggingface__datasets-2887@99158ed | huggingface/datasets | Python | 2,887 | #2837 Use cache folder for lockfile | Fixes #2837
Use a cache folder directory to store the FileLock.
The issue was that the lock file was in a readonly folder.
| 2021-09-09T19:55:56Z | prepare_module issue when loading from read-only fs
## Describe the bug
When we use prepare_module from a readonly file system, we create a FileLock using the `local_path`.
This path is not necessarily writable.
`lock_path = local_path + ".lock"`
## Steps to reproduce the bug
Run `load_dataset` on a read... | Hello, I opened #2887 to fix this. | [
{
"body": "## Describe the bug\r\n\r\nWhen we use prepare_module from a readonly file system, we create a FileLock using the `local_path`.\r\nThis path is not necessarily writable.\r\n\r\n`lock_path = local_path + \".lock\"`\r\n\r\n\r\n## Steps to reproduce the bug\r\n\r\nRun `load_dataset` on a readonly python... | 83bc8a2f01a993233b7d7806c3bda5b6a657ef40 | {
"head_commit": "99158edc5d370779b38bc951f8cff6d80d67a944",
"head_commit_message": "#2837 Fix according to review",
"patch_to_review": "diff --git a/src/datasets/load.py b/src/datasets/load.py\nindex d00aedc0823..d36e7bd002e 100644\n--- a/src/datasets/load.py\n+++ b/src/datasets/load.py\n@@ -671,8 +671,10 @@ def... | [
{
"diff_hunk": "@@ -671,8 +671,10 @@ def _get_modification_time(module_hash):\n local_file_path = os.path.join(hash_folder_path, name)\n dataset_infos_path = os.path.join(hash_folder_path, config.DATASETDICT_INFOS_FILENAME)\n \n+ # Create the lock file where we know we have write permissions.\n+ l... | 65c0b1102bfcc3a3445f242f880bfb520a448376 | diff --git a/src/datasets/load.py b/src/datasets/load.py
index 568c5823d92..b652900eeb6 100644
--- a/src/datasets/load.py
+++ b/src/datasets/load.py
@@ -711,8 +711,10 @@ def _get_modification_time(module_hash):
local_file_path = os.path.join(hash_folder_path, name)
dataset_infos_path = os.path.join(hash_folde... | {
"difficulty": "low",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
iterative__dvc-6848@715d199 | iterative/dvc | Python | 6,848 | exp run: add experiment name check. | fix #6674 and fix #6652
1. Add experiment name check (https://git-scm.com/docs/git-check-ref-format)
2. Add duplicate exp name check.
3. Add some unit test for it.
* [x] ❗ I have followed the [Contributing to DVC](https://dvc.org/doc/user-guide/contributing/core) checklist.
* [x] 📖 If this PR requires [doc... | 2021-10-21T09:37:20Z | exp run: Results cannot be found if experiment name includes space
# Bug Report
## Description
When running an experiment with white space in the name, the resulting experiment does not show up in `exp show` later.
### Reproduce
1. `dvc exp run --name "some name": Experiments runs as expected.
2. `dvc exp s... | For reference, the intended behavior is:
> dvc exp run should refuse to assign names with white space in them,
Experiment names must be valid Git ref/branch names and cannot contain whitespace (https://git-scm.com/docs/git-check-ref-format)
related: https://github.com/iterative/dvc/issues/6652
We need to valid... | [
{
"body": "# Bug Report\r\n\r\n## Description \r\nWhen running an experiment with white space in the name, the resulting experiment does not show up in `exp show` later.\r\n\r\n### Reproduce\r\n\r\n1. `dvc exp run --name \"some name\": Experiments runs as expected.\r\n2. `dvc exp show`: Experiment is not listed... | e2d705fd76771c184f85a477f8d73aea40a96cab | {
"head_commit": "715d1998bbccfb851bb15088e623220f698bf987",
"head_commit_message": "Some bug fix",
"patch_to_review": "diff --git a/dvc/repo/experiments/__init__.py b/dvc/repo/experiments/__init__.py\nindex 30b9a5d55e..19f7891f18 100644\n--- a/dvc/repo/experiments/__init__.py\n+++ b/dvc/repo/experiments/__init__... | [
{
"diff_hunk": "@@ -25,3 +26,22 @@ def test_resolve_exp_ref(tmp_dir, scm, git_upstream, name_only, use_url):\n remote_ref_info = resolve_exp_ref(scm, \"foo\" if name_only else ref, remote)\n assert isinstance(remote_ref_info, ExpRefInfo)\n assert str(remote_ref_info) == ref\n+\n+\n+def test_run_chec... | 3f79e7b5a0d36805c62b7018b90dc44cfd3a63c1 | diff --git a/dvc/repo/experiments/__init__.py b/dvc/repo/experiments/__init__.py
index 30b9a5d55e..43d1f1db1c 100644
--- a/dvc/repo/experiments/__init__.py
+++ b/dvc/repo/experiments/__init__.py
@@ -473,6 +473,17 @@ def _log_reproduced(self, revs: Iterable[str], tmp_dir: bool = False):
"\tdvc exp branch <e... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
huggingface__datasets-2747@4bdb131 | huggingface/datasets | Python | 2,747 | add multi-proc in `to_json` | Closes #2663. I've tried adding multiprocessing in `to_json`. Here's some benchmarking I did to compare the timings of current version (say v1) and multi-proc version (say v2). I did this with `cpu_count` 4 (2015 Macbook Air)
1. Dataset name: `ascent_kb` - 8.9M samples (all samples were used, reporting this for a si... | 2021-08-03T08:30:13Z | [`to_json`] add multi-proc sharding support
As discussed on slack it appears that `to_json` is quite slow on huge datasets like OSCAR.
I implemented sharded saving, which is much much faster - but the tqdm bars all overwrite each other, so it's hard to make sense of the progress, so if possible ideally this multi-pr... | Hi @stas00,
I want to work on this issue and I was thinking why don't we use `imap` [in this loop](https://github.com/huggingface/datasets/blob/440b14d0dd428ae1b25881aa72ba7bbb8ad9ff84/src/datasets/io/json.py#L99)? This way, using offset (which is being used to slice the pyarrow table) we can convert pyarrow table t... | [
{
"body": "As discussed on slack it appears that `to_json` is quite slow on huge datasets like OSCAR.\r\n\r\nI implemented sharded saving, which is much much faster - but the tqdm bars all overwrite each other, so it's hard to make sense of the progress, so if possible ideally this multi-proc support could be i... | 9a2dff69289dd50fe19ac47d77da223908b7e9aa | {
"head_commit": "4bdb13173272f1bcb38563365b14c55c0eddfa35",
"head_commit_message": "flake8 datasets",
"patch_to_review": "diff --git a/src/datasets/arrow_dataset.py b/src/datasets/arrow_dataset.py\nindex 86a8e75b9a6..08028d5fa5a 100644\n--- a/src/datasets/arrow_dataset.py\n+++ b/src/datasets/arrow_dataset.py\n@@... | [
{
"diff_hunk": "@@ -63,49 +64,89 @@ def __init__(\n dataset: Dataset,\n path_or_buf: Union[PathLike, BinaryIO],\n batch_size: Optional[int] = None,\n+ num_proc: Optional[int] = None,\n **to_json_kwargs,\n ):\n self.dataset = dataset\n self.path_or_buf =... | f6c3e12230cd08ac24f5a474b67916504161e501 | diff --git a/src/datasets/arrow_dataset.py b/src/datasets/arrow_dataset.py
index 6b31e9be9ac..fe673952e4a 100644
--- a/src/datasets/arrow_dataset.py
+++ b/src/datasets/arrow_dataset.py
@@ -2856,6 +2856,7 @@ def to_json(
self,
path_or_buf: Union[PathLike, BinaryIO],
batch_size: Optional[int] =... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
huggingface__datasets-2662@eaa1371 | huggingface/datasets | Python | 2,662 | Load Dataset from the Hub (NO DATASET SCRIPT) | ## Load the data from any Dataset repository on the Hub
This PR adds support for loading datasets from any dataset repository on the hub, without requiring any dataset script.
As a user it's now possible to create a repo and upload some csv/json/text/parquet files, and then be able to load the data in one line. H... | 2021-07-16T17:21:58Z | Load datasets from the Hub without requiring a dataset script
As a user I would like to be able to upload my csv/json/text/parquet/etc. files in a dataset repository on the Hugging Face Hub and be able to load this dataset with `load_dataset` without having to implement a dataset script.
Moreover I would like to be ... | This is so cool, let us know if we can help with anything on the hub side (@Pierrci @elishowk) 🎉 | [
{
"body": "As a user I would like to be able to upload my csv/json/text/parquet/etc. files in a dataset repository on the Hugging Face Hub and be able to load this dataset with `load_dataset` without having to implement a dataset script.\r\n\r\nMoreover I would like to be able to specify which file goes into wh... | 374e171a77374e2c7c12ae47e252043329793dfd | {
"head_commit": "eaa13710b677e3c1d49d6a0a235f36ed2c80f27b",
"head_commit_message": "style",
"patch_to_review": "diff --git a/docs/source/loading_datasets.rst b/docs/source/loading_datasets.rst\nindex 02bb5a8c7bc..f5392c57705 100644\n--- a/docs/source/loading_datasets.rst\n+++ b/docs/source/loading_datasets.rst\n... | [
{
"diff_hunk": "@@ -158,22 +158,52 @@ Apart from :obj:`name` and :obj:`split`, the :func:`datasets.load_dataset` metho\n \n The use of these arguments is discussed in the :ref:`load_dataset_cache_management` section below. You can also find the full details on these arguments on the package reference page for :... | 0a96b16744427e4a1909c9d0f4a0891b199db13f | diff --git a/docs/source/index.rst b/docs/source/index.rst
index e57b5f762e9..47c783d6de0 100644
--- a/docs/source/index.rst
+++ b/docs/source/index.rst
@@ -59,8 +59,8 @@ The documentation is organized in six parts:
:maxdepth: 2
:caption: Adding new datasets/metrics
- add_dataset
share_dataset
+ ... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
gradio-app__gradio-10097@cba7463 | gradio-app/gradio | Python | 10,097 | Fix: Added support for show_api in mount_gradio_app | Fix: Added support for show_api in mount_gradio_app
## Description
The `mount_gradio_app` function did not previously support the `show_api` parameter, which caused the "Use via API" button to always appear, regardless of the user's intent.
### Changes
- Added logic to handle `show_api` in `mount_gradio_app`.
... | 2024-12-02T22:58:05Z | Cannot set show_api to False in mount_gradio_app
### Describe the bug
I create a gradio app using mount_gradio_app so I don't need to user the launch function call. I want to hide the "Use via API" on the footer. I try to add app_kwargs={"show_api": False} when calling the mount_gradio_app() and the "Use via API" mess... | Would you like to submit a PR for this @canytam-krystal ? | [
{
"body": "### Describe the bug\n\nI create a gradio app using mount_gradio_app so I don't need to user the launch function call. I want to hide the \"Use via API\" on the footer. I try to add app_kwargs={\"show_api\": False} when calling the mount_gradio_app() and the \"Use via API\" message still shown on the... | d5b299cfb253cadd22c554d70b0bc20f33111e6c | {
"head_commit": "cba7463a905f5ef6d0fd3e5d855b84641024835a",
"head_commit_message": "3rd Fix: show_api in mount_gradio_app",
"patch_to_review": "diff --git a/.changeset/two-ghosts-punch.md b/.changeset/two-ghosts-punch.md\nnew file mode 100644\nindex 0000000000..2cfa0184ca\n--- /dev/null\n+++ b/.changeset/two-gho... | [
{
"diff_hunk": "@@ -1578,6 +1580,7 @@ def read_main():\n )\n \n blocks.dev_mode = False\n+ blocks.show_api = show_api",
"line": null,
"original_line": 1583,
"original_start_line": null,
"path": "gradio/routes.py",
"start_line": null,
"text": "@user1:\n```suggestion\r\n ... | c0dfe5fd58b0e3dbad416e6552ef35e11d7ece52 | diff --git a/.changeset/two-ghosts-punch.md b/.changeset/two-ghosts-punch.md
new file mode 100644
index 0000000000..2cfa0184ca
--- /dev/null
+++ b/.changeset/two-ghosts-punch.md
@@ -0,0 +1,5 @@
+---
+"gradio": patch
+---
+
+fix:Fix: Added support for show_api in mount_gradio_app
diff --git a/gradio/routes.py b/gradio/r... | {
"difficulty": "medium",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
iterative__dvc-6799@773c29a | iterative/dvc | Python | 6,799 | Exp show md | * [X] ❗ I have followed the [Contributing to DVC](https://dvc.org/doc/user-guide/contributing/core) checklist.
* [x] 📖 If this PR requires [documentation](https://dvc.org/doc) updates, I have created a separate PR (or issue, at least) in [dvc.org](https://github.com/iterative/dvc.org) and linked it here.
Close #... | 2021-10-13T12:25:53Z | exp show: --show-md for experiment tables
We want to be able to display tables of our experiments in markdown documents similar to how we can do it with dvc params and metrics.
Our use case is that we are conducting hyperparameter tuning jobs in CML, and would like to easily format a table of the results in PR comme... | Good idea, @mattlbeck!
I'm curious if you see benefits beyond ease of use for doing this over inserting the output directly as a code block like:
````
echo '```' >> report.md
dvc exp show >> report.md
echo '```' >> report.md
````
@dberenbaum Honestly hadn't thought of placing inside of a code block. Presumabl... | [
{
"body": "We want to be able to display tables of our experiments in markdown documents similar to how we can do it with dvc params and metrics.\r\n\r\nOur use case is that we are conducting hyperparameter tuning jobs in CML, and would like to easily format a table of the results in PR comments.\r\n\r\nI appre... | 259d59052750537e7c9a0b20adb2aa2ef4f90108 | {
"head_commit": "773c29a52fc16e4f0de5f5d747dfa4c355316248",
"head_commit_message": "Apply suggestions from code review\n\nCo-authored-by: Saugat Pachhai <suagatchhetri@outlook.com>",
"patch_to_review": "diff --git a/dvc/command/experiments.py b/dvc/command/experiments.py\nindex 7e99377558..d7042872ec 100644\n---... | [
{
"diff_hunk": "@@ -20,6 +20,8 @@ def _id_gen(val) -> str:\n ([\"experiments\", \"diff\", \"--show-md\"], \"markdown\"),\n ([\"experiments\", \"show\", \"--show-json\"], \"json\"),\n ([\"experiments\", \"show\", \"--show-csv\"], \"csv\"),\n+ ([\"experiments\", \"show\", \"--show-m... | 63a350ae998ee0501d9d1a935acb8d0d584f5cc6 | diff --git a/dvc/command/experiments.py b/dvc/command/experiments.py
index 7e99377558..d7042872ec 100644
--- a/dvc/command/experiments.py
+++ b/dvc/command/experiments.py
@@ -382,7 +382,12 @@ def baseline_styler(typ):
def show_experiments(
- all_experiments, pager=True, no_timestamp=False, csv=False, **kwargs
+... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
huggingface__datasets-2830@46a6f0e | huggingface/datasets | Python | 2,830 | Add imagefolder dataset | A generic imagefolder dataset inspired by `torchvision.datasets.ImageFolder`.
Resolves #2508
---
Example Usage:
[](https://colab.research.google.com/gist/nateraw/954fa8cba4ff806f6147a782fa9efd1a/imagefolder-official-example.ipynb) | 2021-08-23T23:34:06Z | Load Image Classification Dataset from Local
**Is your feature request related to a problem? Please describe.**
Yes - we would like to load an image classification dataset with datasets without having to write a custom data loader.
**Describe the solution you'd like**
Given a folder structure with images of eac... | Hi ! Is this folder structure a standard, a bit like imagenet ?
In this case maybe we can consider having a dataset loader for cifar-like, imagenet-like, squad-like, conll-like etc. datasets ?
```python
from datasets import load_dataset
my_custom_cifar = load_dataset("cifar_like", data_dir="path/to/data/dir")
``... | [
{
"body": "**Is your feature request related to a problem? Please describe.**\r\nYes - we would like to load an image classification dataset with datasets without having to write a custom data loader.\r\n\r\n**Describe the solution you'd like**\r\n\r\nGiven a folder structure with images of each class in each f... | bf2ba9923d9133bd6e0be2c4ec20e422fc32f08a | {
"head_commit": "46a6f0ebfeb67c03b5dc486159fbeaf1572fa98f",
"head_commit_message": ":lipstick: style",
"patch_to_review": "diff --git a/datasets/imagefolder/README.md b/datasets/imagefolder/README.md\nnew file mode 100644\nindex 00000000000..e69de29bb2d\ndiff --git a/datasets/imagefolder/dummy/0.0.0/dummy_data.z... | [
{
"diff_hunk": "@@ -0,0 +1,53 @@\n+from dataclasses import dataclass\n+from pathlib import Path\n+from typing import List, Optional\n+\n+import pyarrow as pa\n+\n+import datasets\n+\n+\n+logger = datasets.utils.logging.get_logger(__name__)\n+\n+\n+@dataclass\n+class ImageFolderConfig(datasets.BuilderConfig):\n+... | 1c21a68c5ad143e959b55f4647e1b384fb8f8e68 | diff --git a/datasets/imagefolder/README.md b/datasets/imagefolder/README.md
new file mode 100644
index 00000000000..c61fc47e6ee
--- /dev/null
+++ b/datasets/imagefolder/README.md
@@ -0,0 +1,4 @@
+
+### Contributions
+
+Thanks to [@nateraw](https://github.com/nateraw), [@lhoestq](https://github.com/lhoestq) and [@mario... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
huggingface__datasets-2509@67fee53 | huggingface/datasets | Python | 2,509 | Fix fingerprint when moving cache dir | The fingerprint of a dataset changes if the cache directory is moved.
I fixed that by setting the fingerprint to be the hash of:
- the relative cache dir (dataset_name/version/config_id)
- the requested split
Close #2496
I had to fix an issue with the filelock filename that was too long (>255). It prevented t... | 2021-06-16T16:45:09Z | Dataset fingerprint changes after moving the cache directory, which prevent cache reload when using `map`
`Dataset.map` uses the dataset fingerprint (a hash) for caching.
However the fingerprint seems to change when someone moves the cache directory of the dataset.
This is because it uses the default fingerprint ge... | [
{
"body": "`Dataset.map` uses the dataset fingerprint (a hash) for caching.\r\nHowever the fingerprint seems to change when someone moves the cache directory of the dataset.\r\n\r\nThis is because it uses the default fingerprint generation:\r\n1. the dataset path is used to get the fingerprint\r\n2. the modific... | 7f7ac9200a305659abed039a74ddcfff95dd10e3 | {
"head_commit": "67fee53d4e016085dc914f7d99bbbebb7f65c12c",
"head_commit_message": "fix windows path",
"patch_to_review": "diff --git a/src/datasets/builder.py b/src/datasets/builder.py\nindex 36b68210ba7..4e818611503 100644\n--- a/src/datasets/builder.py\n+++ b/src/datasets/builder.py\n@@ -41,7 +41,7 @@\n from ... | [
{
"diff_hunk": "@@ -96,6 +104,24 @@ def __str__(self):\n return temp\n \n \n+# Helpers\n+# ------------------------------------------------\n+\n+\n+MAX_LOCK_FILENAME_LENGTH = 255\n+\n+\n+def hash_filename_if_too_long(path: str, max_length=MAX_LOCK_FILENAME_LENGTH) -> str:",
"line": null,
"origin... | 57c8d6c9d4d2b1cac73d999cafcce43a1edd7357 | diff --git a/src/datasets/builder.py b/src/datasets/builder.py
index 36b68210ba7..f5720ce2c85 100644
--- a/src/datasets/builder.py
+++ b/src/datasets/builder.py
@@ -381,7 +381,7 @@ def builder_configs(cls):
def cache_dir(self):
return self._cache_dir
- def _relative_data_dir(self, with_version=True, ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
gradio-app__gradio-9950@6398d01 | gradio-app/gradio | Python | 9,950 | Add ability to read and write from LocalStorage | I've added a component `gr.BrowserState()`, which acts similarly to `gr.State()` but any value written to it is saved to the browser's local storage, so it is preserved across page loads. The value is encrypted with a key, which means that one Gradio app will not be able to read the local state value of another Gradio ... | 2024-11-12T22:37:53Z | Support session state across multiple pages or page refresh (e.g. with LocalStorage)
Right now, the session state is either global shared between users or local within a page. We are seeing the needs to support session state across multiple pages.
E.g., we host a service on Hugging Face spaces, and we ask users to l... | @abidlabs is this something that's on the roadmap?
We’re planning on tackling it but probably not anytime soon as we have competing priorities at the moment
Hi, abidlabs, Is there a workaround to keep chat histroy in `gr.Chatbot` after refreshing a page?
@abidlabs ^ that is my use case as well; curious what your recomm... | [
{
"body": "Right now, the session state is either global shared between users or local within a page. We are seeing the needs to support session state across multiple pages.\r\n\r\nE.g., we host a service on Hugging Face spaces, and we ask users to login with token first before using the spaces. The ideal case ... | eae345e5fde39aea220b57c6a954cd7d72ff32d5 | {
"head_commit": "6398d0142b8b193cae31ceaad2756e3c203bcb12",
"head_commit_message": "types",
"patch_to_review": "diff --git a/.changeset/tricky-glasses-share.md b/.changeset/tricky-glasses-share.md\nnew file mode 100644\nindex 0000000000..79bdb03afb\n--- /dev/null\n+++ b/.changeset/tricky-glasses-share.md\n@@ -0,... | [
{
"diff_hunk": "@@ -30,6 +30,7 @@\n \t\tstylesheets?: string[];\n \t\tpath: string;\n \t\tapp_id?: string;\n+\t\tbrowser_state_secret?: string;",
"line": null,
"original_line": 33,
"original_start_line": null,
"path": "js/app/src/routes/[...catchall]/+page.svelte",
"start_line": null,
"t... | ec2e569baa8a9b69674ad542c99a1ddface86286 | diff --git a/.changeset/tricky-glasses-share.md b/.changeset/tricky-glasses-share.md
new file mode 100644
index 0000000000..79bdb03afb
--- /dev/null
+++ b/.changeset/tricky-glasses-share.md
@@ -0,0 +1,12 @@
+---
+"@gradio/client": minor
+"@gradio/core": minor
+"@gradio/browserstate": minor
+"@gradio/utils": minor
+"@se... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
huggingface__datasets-2182@748e2e9 | huggingface/datasets | Python | 2,182 | Set default in-memory value depending on the dataset size | Set a default value for `in_memory` depending on the size of the dataset to be loaded.
Close #2179.
TODO:
- [x] Add a section in the docs about this.
- ~Add a warning if someone tries to specify `cache_file_name=` in `map`, `filter` etc. on a dataset that is in memory, since the computation is not going to be c... | 2021-04-07T13:00:18Z | Load small datasets in-memory instead of using memory map
Currently all datasets are loaded using memory mapping by default in `load_dataset`.
However this might not be necessary for small datasets. If a dataset is small enough, then it can be loaded in-memory and:
- its memory footprint would be small so it's ok
- ... | [
{
"body": "Currently all datasets are loaded using memory mapping by default in `load_dataset`.\r\nHowever this might not be necessary for small datasets. If a dataset is small enough, then it can be loaded in-memory and:\r\n- its memory footprint would be small so it's ok\r\n- in-memory computations/queries wo... | a0aef983f5351c46cf0559df55cb9a5467423d0a | {
"head_commit": "748e2e9bffeea7aab68182bfe6c6f71d4305e1c4",
"head_commit_message": "Revert \"tmp\"\n\nThis reverts commit 8a1af5acec2372db854bbcd4b5988411bd55e78b.",
"patch_to_review": "diff --git a/docs/source/loading_datasets.rst b/docs/source/loading_datasets.rst\nindex 8d418eb01a0..d4840ed2d81 100644\n--- a/... | [
{
"diff_hunk": "@@ -652,6 +656,7 @@ def load_from_disk(dataset_path: str, fs=None, keep_in_memory=False) -> \"Dataset\n with open(Path(dataset_path, DATASET_INFO_FILENAME).as_posix(), \"r\", encoding=\"utf-8\") as dataset_info_file:\n dataset_info = DatasetInfo.from_dict(json.load(dataset_in... | 985ed3589c26ed960b77f7f5f0ea530d29afe67b | diff --git a/docs/source/loading_datasets.rst b/docs/source/loading_datasets.rst
index 8d418eb01a0..e393091fb46 100644
--- a/docs/source/loading_datasets.rst
+++ b/docs/source/loading_datasets.rst
@@ -28,15 +28,15 @@ All the datasets currently available on the `Hub <https://huggingface.co/dataset
656
>>> prin... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Performance Optimizations"
} | |
iterative__dvc-6471@59165f2 | iterative/dvc | Python | 6,471 | Clean up remotes's exps | fix #6006
1. add a new argument `--git-remote` to `dvc exp remove`
2. add some tests for it
* [x] ❗ I have followed the [Contributing to DVC](https://dvc.org/doc/user-guide/contributing/core) checklist.
* [x] 📖 If this PR requires [documentation](https://dvc.org/doc) updates, I have created a separate PR (o... | 2021-08-23T10:47:15Z | Remove pushed experiment from git remote
Push an experiment to a git remote:
```
$ dvc exp push origin myexpe
```
Then:
```
$ dvc exp list origin
master:
myexpe
```
Currently, only local experiment can be removed with:
```
$ dvc exp remove myexpe
```
but `dvc exp list origin` still shows `m... | For now you can just use git and directly remove experiment refs with `git push -d` in the same way that you remove remote branches
```shell
# get list of exps pushed to origin
$ git ls-remote origin "refs/exps/*"
# remove one of the listed refs
$ git push -d origin refs/exps/path/to/ref
```
@pmrowla Do you t... | [
{
"body": "Push an experiment to a git remote:\r\n\r\n```\r\n$ dvc exp push origin myexpe\r\n```\r\n\r\nThen:\r\n\r\n```\r\n$ dvc exp list origin\r\nmaster:\r\n myexpe\r\n```\r\n\r\nCurrently, only local experiment can be removed with:\r\n\r\n```\r\n$ dvc exp remove myexpe\r\n```\r\n\r\nbut `dvc exp list orig... | 13d1276a12975625774fc9a802dc07f6144d0792 | {
"head_commit": "59165f27cde956c6654641d649c1a34f5cc8a4ac",
"head_commit_message": "Clean up remotes's exps\n\nfix #6006\n1. add a new argument `--git-remote` to `dvc exp remove`\n2. add some tests for it",
"patch_to_review": "diff --git a/dvc/command/experiments.py b/dvc/command/experiments.py\nindex e1fa5d83f1... | [
{
"diff_hunk": "@@ -1249,6 +1250,12 @@ def add_parser(subparsers, parent_parser):\n action=\"store_true\",\n help=\"Remove all committed experiments.\",\n )\n+ remove_group.add_argument(\n+ \"-r\",\n+ \"--git-remote\",\n+ metavar=\"<git_remote>\",\n+ help=\"Nam... | 95fbb7f9fc05901cd010d4527504e214521759f1 | diff --git a/dvc/command/experiments.py b/dvc/command/experiments.py
index e1fa5d83f1..10c50691f6 100644
--- a/dvc/command/experiments.py
+++ b/dvc/command/experiments.py
@@ -750,6 +750,7 @@ def run(self):
exp_names=self.args.experiment,
queue=self.args.queue,
clear_all=self.args.... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
gradio-app__gradio-10032@5f0c7d8 | gradio-app/gradio | Python | 10,032 | add `webcam_height` and `webcam_width` to specify the resolution of the Webcam | ## Description
try to add `webcam_height` and `webcam_width` to specify the resolution of the Webcam.
The following code can be executed correctly.
```python
import gradio as gr
with gr.Blocks() as demo:
image = gr.Image(label="Input", sources="webcam", webcam_height=720, webcam_width=1280)
demo.lau... | 2024-11-25T06:45:52Z | I want to specify the resolution of the Webcam
- [x] I have searched to see if a similar issue already exists.
**Is your feature request related to a problem? Please describe.**
Currently the resolution is hardcoded.
gradio/js/image/shared/stream_utils.ts
```gradio/js/image/shared/stream_utils.ts
export as... | i get it, i'll try for it. | [
{
"body": "- [x] I have searched to see if a similar issue already exists.\r\n\r\n\r\n**Is your feature request related to a problem? Please describe.** \r\nCurrently the resolution is hardcoded.\r\n\r\ngradio/js/image/shared/stream_utils.ts\r\n```gradio/js/image/shared/stream_utils.ts\r\nexport async function... | ec10aa3b9b42d8c3fe930aff9465c469626992d4 | {
"head_commit": "5f0c7d87b29ff6c38f3b1630b073871d8a1d263a",
"head_commit_message": "add webcam_height and webcam_width",
"patch_to_review": "diff --git a/gradio/components/image.py b/gradio/components/image.py\nindex a5fa53cd1e..7ba4da9201 100644\n--- a/gradio/components/image.py\n+++ b/gradio/components/image.... | [
{
"diff_hunk": "@@ -102,6 +102,8 @@ def __init__(\n show_share_button: bool | None = None,\n placeholder: str | None = None,\n show_fullscreen_button: bool = True,\n+ webcam_height: int = 1440,",
"line": null,
"original_line": 105,
"original_start_line": null,
"pat... | 0806ce74bf96b78698b632391eaf24825c1891e8 | diff --git a/.changeset/sharp-towns-play.md b/.changeset/sharp-towns-play.md
new file mode 100644
index 0000000000..0cc58f69c1
--- /dev/null
+++ b/.changeset/sharp-towns-play.md
@@ -0,0 +1,7 @@
+---
+"@gradio/image": minor
+"@gradio/video": minor
+"gradio": minor
+---
+
+feat:add `webcam_height` and `webcam_width` to ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
home-assistant__core-131588@fb72632 | home-assistant/core | Python | 131,588 | Create MQTT device referenced by via device | <!--
You are amazing! Thanks for contributing to our project!
Please, DO NOT DELETE ANY TEXT from this template! (unless instructed).
-->
## Proposed change
<!--
Describe the big picture of your changes here to communicate to the
maintainers why we should accept this pull request. If it fixes a bug
or... | 2024-11-25T23:18:33Z | MQTT discovery via_device not recognized
### The problem
When sending a MQTT discovery message including via_device is sent, when the via_device is not available (yet), the device is not shown connected, after the via_device is sent at a later time.
Moreover, if the first discovery message is sent again, with the ... | Hey there @emontnemery, @jbouwh, @bdraco, mind taking a look at this issue as it has been labeled with an integration (`mqtt`) you are listed as a [code owner](https://github.com/home-assistant/core/blob/dev/CODEOWNERS#L954) for? Thanks!
<details>
<summary>Code owner commands</summary>
Code owners of `mqtt` can trig... | [
{
"body": "### The problem\n\nWhen sending a MQTT discovery message including via_device is sent, when the via_device is not available (yet), the device is not shown connected, after the via_device is sent at a later time.\r\n\r\nMoreover, if the first discovery message is sent again, with the via_device availa... | c2d6599736e7ae5482b9308b8eb9b6f3ef88ad95 | {
"head_commit": "fb72632b3dd4322613223078de32fd70f07fa36a",
"head_commit_message": "Fix tests - do not mutate tests constants",
"patch_to_review": "diff --git a/homeassistant/components/mqtt/entity.py b/homeassistant/components/mqtt/entity.py\nindex 46b2c9e1d42b5e..f7a49482627743 100644\n--- a/homeassistant/comp... | [
{
"diff_hunk": "@@ -1185,6 +1185,24 @@ def device_info_from_specifications(\n return info\n \n \n+@callback\n+def ensure_via_device_exists(\n+ hass: HomeAssistant, device_info: DeviceInfo | None, config_entry: ConfigEntry\n+) -> None:\n+ \"\"\"Ensore the via device is in the device registry.\"\"\"\n+ ... | 11116c3601c7faee9a89831ff85e5ea35ce470cd | diff --git a/homeassistant/components/mqtt/entity.py b/homeassistant/components/mqtt/entity.py
index 46b2c9e1d42b5..c73e1975a68c1 100644
--- a/homeassistant/components/mqtt/entity.py
+++ b/homeassistant/components/mqtt/entity.py
@@ -1185,6 +1185,33 @@ def device_info_from_specifications(
return info
+@callback... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
gradio-app__gradio-9897@55b21b4 | gradio-app/gradio | Python | 9,897 | Allow datetime value to be null | ## Description
The clear button wasn't working in datetime because we weren't allowing the value to be null.
Closes: #9259
## 🎯 PRs Should Target Issues
Before your create a PR, please check to see if there is [an existing issue](https://github.com/gradio-app/gradio/issues) for this change. If not, please create ... | 2024-11-04T18:27:02Z | DateTime component's "Clear" button doesn't work
### Describe the bug
I tried to clear previously picked date by using the left bottom "clear" button and it won't work, i.e., the value is still there.
Clearing input didn't work either.
Please advise.
```
```
### Have you searched existing issues? 🔎
- [... | The same bug is present in Gradio 5.3.0 | [
{
"body": "### Describe the bug\n\nI tried to clear previously picked date by using the left bottom \"clear\" button and it won't work, i.e., the value is still there.\r\nClearing input didn't work either.\r\n\r\nPlease advise.\r\n\r\n```\r\n\r\n\r\n```\n\n### Have you searched existing issues? 🔎\n\n- [X] I h... | b5eaba1d6d6938197f105e5906a07fe2b2bba704 | {
"head_commit": "55b21b45745a53ab775ddb0d13076a8e71fffa6a",
"head_commit_message": "add changeset",
"patch_to_review": "diff --git a/.changeset/empty-humans-invite.md b/.changeset/empty-humans-invite.md\nnew file mode 100644\nindex 0000000000..9e2120d839\n--- /dev/null\n+++ b/.changeset/empty-humans-invite.md\n@... | [
{
"diff_hunk": "@@ -54,7 +54,7 @@ class Dataframe(Component):\n Demos: filter_records, matrix_transpose, tax_calculator, sort_records\n \"\"\"\n \n- EVENTS = [Events.change, Events.input, Events.select]",
"line": null,
"original_line": 57,
"original_start_line": null,
"path": "gradio/... | 4b62a6b39ea780b33620d3df70091fc83140760d | diff --git a/.changeset/empty-humans-invite.md b/.changeset/empty-humans-invite.md
new file mode 100644
index 0000000000..9e2120d839
--- /dev/null
+++ b/.changeset/empty-humans-invite.md
@@ -0,0 +1,6 @@
+---
+"@gradio/datetime": patch
+"gradio": patch
+---
+
+fix:Allow datetime value to be null
diff --git a/js/datetim... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
huggingface__datasets-2111@9a66cee | huggingface/datasets | Python | 2,111 | Compute WER metric iteratively | Compute WER metric iteratively to avoid MemoryError.
Fix #2078. | 2021-03-25T16:06:48Z | MemoryError when computing WER metric
Hi, I'm trying to follow the ASR example to try Wav2Vec. This is the code that I use for WER calculation:
```
wer = load_metric("wer")
print(wer.compute(predictions=result["predicted"], references=result["target"]))
```
However, I receive the following exception:
`Trace... | Hi ! Thanks for reporting.
We're indeed using `jiwer` to compute the WER.
Maybe instead of calling `jiwer.wer` once for all the preditions/references we can compute the WER iteratively to avoid memory issues ? I'm not too familial with `jiwer` but this must be possible.
Currently the code to compute the WER is d... | [
{
"body": "Hi, I'm trying to follow the ASR example to try Wav2Vec. This is the code that I use for WER calculation:\r\n\r\n```\r\nwer = load_metric(\"wer\")\r\nprint(wer.compute(predictions=result[\"predicted\"], references=result[\"target\"]))\r\n```\r\n\r\nHowever, I receive the following exception:\r\n\r\n`... | 67574a8d74796bc065a8b9b49ec02f7b1200c172 | {
"head_commit": "9a66cee541d603c25a6ef9480537682b54828116",
"head_commit_message": "Fix style",
"patch_to_review": "diff --git a/metrics/wer/wer.py b/metrics/wer/wer.py\nindex 624e729f956..0c69f768a41 100644\n--- a/metrics/wer/wer.py\n+++ b/metrics/wer/wer.py\n@@ -14,7 +14,7 @@\n # limitations under the License.... | [
{
"diff_hunk": "@@ -91,4 +91,10 @@ def _info(self):\n )\n \n def _compute(self, predictions, references):\n- return wer(references, predictions)\n+ incorrect = 0\n+ total = 0\n+ for prediction, reference in zip(predictions, references):\n+ measures = compute_me... | 52f1125c48d4394a650591779d48043272cb6aa3 | diff --git a/metrics/wer/wer.py b/metrics/wer/wer.py
index 624e729f956..2b47a74b062 100644
--- a/metrics/wer/wer.py
+++ b/metrics/wer/wer.py
@@ -14,7 +14,7 @@
# limitations under the License.
""" Word Error Ratio (WER) metric. """
-from jiwer import wer
+from jiwer import compute_measures
import datasets
@@ -5... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
iterative__dvc-6273@03b738b | iterative/dvc | Python | 6,273 | doctor: show versions for fs requirements | Resolves #6248
Previous output:
```
DVC version: 2.4.3+ce45ec
---------------------------------
Platform: Python 3.8.5+ on Linux-5.4.0-77-generic-x86_64-with-glibc2.29
Supports: s3, gs, http
Cache types: <https://error.dvc.org/no-dvc-cache>
Caches: local
Remotes: https
Workspace directory: ext4 on /dev/sda7
... | 2021-07-02T10:29:19Z | doctor: should dvc doctor show remote-required dependency versions
Something that we've been experiencing lately is asking for an extra question regarding the version of their used remote dependency. We could try to annotate the dvc doctor's output with the stuff that we can get (optional). Something like this
```
$... | CC: @iterative/dvc
This would be amazing! :fire: Should we bump the priority?
One thing that is a bit problematic is when the all remotes are installed. Normally instead of listing everything, DVC only prints All remotes;
```
$ dvc doctor
DVC version: 2.4.3+ce45ec.mod
---------------------------------
Platform:... | [
{
"body": "Something that we've been experiencing lately is asking for an extra question regarding the version of their used remote dependency. We could try to annotate the dvc doctor's output with the stuff that we can get (optional). Something like this\r\n```\r\n $ dvc doctor\r\nDVC version: 2.4.2+f1bf10.mod... | 2485779d59143799d4a489b42294ee6b7ce52a80 | {
"head_commit": "03b738b1dedf00ab40b4ad79b4e37676850bfedc",
"head_commit_message": "doctor: show versions for fs requirements",
"patch_to_review": "diff --git a/dvc/fs/http.py b/dvc/fs/http.py\nindex a05c4112f0..c265db2064 100644\n--- a/dvc/fs/http.py\n+++ b/dvc/fs/http.py\n@@ -31,6 +31,7 @@ class HTTPFileSystem... | [
{
"diff_hunk": "@@ -20,14 +21,19 @@\n else:\n package = f\"({PKG})\"\n \n+if sys.version_info < (3, 8):\n+ import importlib_metadata\n+else:\n+ import importlib.metadata as importlib_metadata\n+\n \n def get_dvc_info():\n info = [\n f\"DVC version: {__version__} {package}\",\n \"--... | 1a8fc6ed8495e0ce13f35235f8dd082470b28521 | diff --git a/dvc/fs/http.py b/dvc/fs/http.py
index a05c4112f0..c265db2064 100644
--- a/dvc/fs/http.py
+++ b/dvc/fs/http.py
@@ -31,6 +31,7 @@ class HTTPFileSystem(BaseFileSystem): # pylint:disable=abstract-method
PATH_CLS = HTTPURLInfo
PARAM_CHECKSUM = "etag"
CAN_TRAVERSE = False
+ REQUIRES = {"reques... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
gradio-app__gradio-9225@286b6dd | gradio-app/gradio | Python | 9,225 | Add a 'None' option to the gradio.Image component to disable image_m… | Add a 'None' option to the gradio.Image component to disable image_mode conversion. This commit will avoid convert behavior in prepress phase forcefully.
Closes: https://github.com/gradio-app/gradio/issues/9222 | 2024-08-30T18:45:41Z | I don't want to convert uploaded image to image_mode forcedly when using Gradio.Image
Gradio.Image component has image_mode parameters to force uploaded image to convert RGB\RGBA and etc, if I want to keep raw image mode, how should I do? if image_mode can add a option, I think it is useful. | Thanks @GeeMoose, this makes sense to me. We could allow `image_mode` to take a `None` value in which case its inferred from the file itself. Would you like to open a PR for this?
if gradio organization allows, I am glad to do it.
Yes, please go for it! Happy to review once the PR is open
The main file to edit would b... | [
{
"body": "Gradio.Image component has image_mode parameters to force uploaded image to convert RGB\\RGBA and etc, if I want to keep raw image mode, how should I do? if image_mode can add a option, I think it is useful.",
"number": 9222,
"title": "I don't want to convert uploaded image to image_mode forc... | 284fafb2152abf314a226cebcf1f6dd813a57b25 | {
"head_commit": "286b6dd35dfdce5c576aa143157ae9942cbeaf90",
"head_commit_message": " Add a 'None' option to the gradio.Image component to disable image_mode conversion behavior",
"patch_to_review": "diff --git a/gradio/components/image.py b/gradio/components/image.py\nindex 695949b819..b756de6f63 100644\n--- a/g... | [
{
"diff_hunk": "@@ -51,7 +51,7 @@ def __init__(\n height: int | str | None = None,\n width: int | str | None = None,\n image_mode: Literal[\n- \"1\", \"L\", \"P\", \"RGB\", \"RGBA\", \"CMYK\", \"YCbCr\", \"LAB\", \"HSV\", \"I\", \"F\"\n+ \"1\", \"L\", \"P\", \"RGB\"... | e2eb41187efb8b4d97024c21b1637b34b9ddc4cb | diff --git a/.changeset/nice-berries-end.md b/.changeset/nice-berries-end.md
new file mode 100644
index 0000000000..e7d5bdc8d2
--- /dev/null
+++ b/.changeset/nice-berries-end.md
@@ -0,0 +1,5 @@
+---
+"gradio": minor
+---
+
+feat: Add a 'None' option to the gradio.Image component to disable image_m…
diff --git a/gradio/... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "New Feature Additions"
} |
huggingface__datasets-1626@bc964e9 | huggingface/datasets | Python | 1,626 | Fix dataset_dict.shuffle with single seed | Fix #1610
I added support for single integer used in `DatasetDict.shuffle`. Previously only a dictionary of seed was allowed.
Moreover I added the missing `seed` parameter. Previously only `seeds` was allowed. | 2020-12-23T14:33:36Z | shuffle does not accept seed
Hi
I need to shuffle the dataset, but this needs to be based on epoch+seed to be consistent across the cores, when I pass seed to shuffle, this does not accept seed, could you assist me with this? thanks @lhoestq | Hi, did you check the doc on `shuffle`?
https://huggingface.co/docs/datasets/package_reference/main_classes.html?datasets.Dataset.shuffle#datasets.Dataset.shuffle
Hi Thomas
thanks for reponse, yes, I did checked it, but this does not work for me please see
```
(internship) rkarimi@italix17:/idiap/user/rkarimi/de... | [
{
"body": "Hi\r\nI need to shuffle the dataset, but this needs to be based on epoch+seed to be consistent across the cores, when I pass seed to shuffle, this does not accept seed, could you assist me with this? thanks @lhoestq\r\n ",
"number": 1610,
"title": "shuffle does not accept seed "
}
] | 14fe19185b20d0882fb3cdd015a9d186f781abd9 | {
"head_commit": "bc964e92ad7462c0897c1f30b64e606525c1b475",
"head_commit_message": "missing test",
"patch_to_review": "diff --git a/src/datasets/dataset_dict.py b/src/datasets/dataset_dict.py\nindex 1f7127b2a4d..12766afa95a 100644\n--- a/src/datasets/dataset_dict.py\n+++ b/src/datasets/dataset_dict.py\n@@ -420,7... | [
{
"diff_hunk": "@@ -434,10 +435,11 @@ def shuffle(\n You can either supply a NumPy BitGenerator to use, or a seed to initiate NumPy's default random generator (PCG64).\n \n Args:\n- seeds (Optional `Dict[str, int]`): A seed to initialize the default BitGenerator if ``generator=None``.... | 189f96788214af2f9d5bc43a543b15d63c969d1f | diff --git a/src/datasets/dataset_dict.py b/src/datasets/dataset_dict.py
index 1f7127b2a4d..b7117a2b53f 100644
--- a/src/datasets/dataset_dict.py
+++ b/src/datasets/dataset_dict.py
@@ -420,7 +420,8 @@ def sort(
def shuffle(
self,
- seeds: Optional[Dict[str, int]] = None,
+ seeds: Optional[... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
huggingface__datasets-653@e71e8af | huggingface/datasets | Python | 653 | handle data alteration when trying type | Fix #649
The bug came from the type inference that didn't handle a weird case in Pyarrow.
Indeed this code runs without error but alters the data in arrow:
```python
import pyarrow as pa
type = pa.struct({"a": pa.struct({"b": pa.string()})})
array_with_altered_data = pa.array([{"a": {"b": "foo", "c": "bar"}}... | 2020-09-21T10:41:49Z | Inconsistent behavior in map
I'm observing inconsistent behavior when applying .map(). This happens specifically when I'm incrementally adding onto a feature that is a nested dictionary. Here's a simple example that reproduces the problem.
```python
import datasets
# Dataset with a single feature called 'field' ... | Thanks for reporting !
This issue must have appeared when we refactored type inference in `nlp`
By default the library tries to keep the same feature types when applying `map` but apparently it has troubles with nested structures. I'll try to fix that next week | [
{
"body": "I'm observing inconsistent behavior when applying .map(). This happens specifically when I'm incrementally adding onto a feature that is a nested dictionary. Here's a simple example that reproduces the problem.\r\n\r\n```python\r\nimport datasets\r\n\r\n# Dataset with a single feature called 'field' ... | b6f3cb1e112d30761fd171076bdc0dbd3d2e34cc | {
"head_commit": "e71e8afcebef2a341cfaf9f4cf035a8e5e33ba87",
"head_commit_message": "handle data alteration when trying type",
"patch_to_review": "diff --git a/src/datasets/arrow_writer.py b/src/datasets/arrow_writer.py\nindex 17ac8ada6b6..a9fdfab2c81 100644\n--- a/src/datasets/arrow_writer.py\n+++ b/src/datasets... | [
{
"diff_hunk": "@@ -94,9 +94,12 @@ def __arrow_array__(self, type=None):\n type = self.type\n try:\n if isinstance(type, _ArrayXDExtensionType):\n- return pa.ExtensionArray.from_storage(type, pa.array(self.data, type.storage_dtype))\n+ out = pa.Exten... | c6cad0c3f49ed15960ef94a62e9046e1457118d5 | diff --git a/src/datasets/arrow_writer.py b/src/datasets/arrow_writer.py
index 17ac8ada6b6..ecd067334fb 100644
--- a/src/datasets/arrow_writer.py
+++ b/src/datasets/arrow_writer.py
@@ -94,9 +94,14 @@ def __arrow_array__(self, type=None):
type = self.type
try:
if isinstance(type, _Arra... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
huggingface__datasets-586@034c1c0 | huggingface/datasets | Python | 586 | Better message when data files is empty | Fix #581 | 2020-09-07T15:59:57Z | Better error message when input file does not exist
In the following scenario, when `data_files` is an empty list, the stack trace and error message could be improved. This can probably be solved by checking for each file whether it actually exists and/or whether the argument is not false-y.
```python
dataset = loa... | [
{
"body": "In the following scenario, when `data_files` is an empty list, the stack trace and error message could be improved. This can probably be solved by checking for each file whether it actually exists and/or whether the argument is not false-y.\r\n\r\n```python\r\ndataset = load_dataset(\"text\", data_fi... | a82052fad3264c04bc65eddaafdcae9269a3fb8c | {
"head_commit": "034c1c00cbf750766b0cb8825fb107a0d911057d",
"head_commit_message": "allow writer to write empty tables",
"patch_to_review": "diff --git a/datasets/csv/csv.py b/datasets/csv/csv.py\nindex 27e42b04174..8e5d884bf1c 100644\n--- a/datasets/csv/csv.py\n+++ b/datasets/csv/csv.py\n@@ -56,6 +56,7 @@ def _... | [
{
"diff_hunk": "@@ -11,6 +11,7 @@ def _split_generators(self, dl_manager):\n If str or List[str], then the dataset returns only the 'train' split.\n If dict, then keys should be from the `nlp.Split` enum.\n \"\"\"\n+ assert bool(self.config.data_files), \"At least one data... | e44f110b1163cf32a2a9ffefd0395182f91c0d4f | diff --git a/datasets/csv/csv.py b/datasets/csv/csv.py
index 27e42b04174..84e09a005db 100644
--- a/datasets/csv/csv.py
+++ b/datasets/csv/csv.py
@@ -56,6 +56,8 @@ def _info(self):
def _split_generators(self, dl_manager):
""" We handle string, list and dicts in datafiles
"""
+ if not self.c... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
Subsets and Splits
Review Test Instances
Retrieves basic metadata about code review instances but doesn't provide any analytical insights or patterns beyond raw data access.