instance_id stringlengths 21 53 | repo stringclasses 188
values | language stringclasses 1
value | pull_number int64 20 148k | title stringlengths 6 144 | body stringlengths 0 83.4k | created_at stringdate 2015-09-25 03:17:17 2025-07-10 16:50:35 | problem_statement stringlengths 188 240k | hints_text stringlengths 0 145k | resolved_issues listlengths 1 6 | base_commit stringlengths 40 40 | commit_to_review dict | reference_review_comments listlengths 1 62 | merged_commit stringlengths 40 40 | merged_patch stringlengths 297 9.87M | metadata dict |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
huggingface__datasets-1826@0761e0a | huggingface/datasets | Python | 1,826 | Print error message with filename when malformed CSV | Print error message specifying filename when malformed CSV file.
Close #1821 | 2021-02-05T11:07:59Z | Provide better exception message when one of many files results in an exception
I find when I process many files, i.e.
```
train_files = glob.glob('rain*.csv')
validation_files = glob.glob(validation*.csv')
datasets = load_dataset("csv", data_files=dict(train=train_files, validation=validation_files))
```
I s... | Hi!
Thank you for reporting this issue. I agree that the information about the exception should be more clear and explicit.
I could take on this issue.
On the meantime, as you can see from the exception stack trace, HF Datasets uses pandas to read the CSV files. You can pass arguments to `pandas.read_csv` by p... | [
{
"body": "I find when I process many files, i.e.\r\n\r\n```\r\ntrain_files = glob.glob('rain*.csv')\r\nvalidation_files = glob.glob(validation*.csv')\r\ndatasets = load_dataset(\"csv\", data_files=dict(train=train_files, validation=validation_files))\r\n```\r\n\r\nI sometimes encounter an error due to one of t... | 8a6a69e54d549f70716d81ee9d64866c70c96ed6 | {
"head_commit": "0761e0a0b81c453be84028804765813066946b57",
"head_commit_message": "Print error message with filename when malformed CSV",
"patch_to_review": "diff --git a/src/datasets/packaged_modules/csv/csv.py b/src/datasets/packaged_modules/csv/csv.py\nindex f010f6dfecd..c298fc7672b 100644\n--- a/src/dataset... | [
{
"diff_hunk": "@@ -126,9 +126,15 @@ def _generate_tables(self, files):\n float_precision=self.config.float_precision,\n chunksize=self.config.chunksize,\n )\n- for batch_idx, df in enumerate(csv_file_reader):\n- pa_table = pa.Table.from_pand... | 130e771267a29b75d5183e804d289f92e1691cc1 | diff --git a/src/datasets/packaged_modules/csv/csv.py b/src/datasets/packaged_modules/csv/csv.py
index f010f6dfecd..58a2cd7f4c2 100644
--- a/src/datasets/packaged_modules/csv/csv.py
+++ b/src/datasets/packaged_modules/csv/csv.py
@@ -126,9 +126,14 @@ def _generate_tables(self, files):
float_precision=se... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
huggingface__datasets-284@6507523 | huggingface/datasets | Python | 284 | Fix manual download instructions | This PR replaces the static `DatasetBulider` variable `MANUAL_DOWNLOAD_INSTRUCTIONS` by a property function `manual_download_instructions()`.
Some datasets like XTREME and all WMT need the manual data dir only for a small fraction of the possible configs.
After some brainstorming with @mariamabarham and @lhoestq... | 2020-06-18T15:59:57Z | How can I load/find WMT en-romanian?
I believe it is from `wmt16`
When I run
```python
wmt = nlp.load_dataset('wmt16')
```
I get:
```python
AssertionError: The dataset wmt16 with config cs-en requires manual data.
Please follow the manual download instructions: Some of the wmt configs here, require a ma... | I will take a look :-) | [
{
"body": "I believe it is from `wmt16`\r\n\r\nWhen I run\r\n\r\n```python\r\nwmt = nlp.load_dataset('wmt16')\r\n```\r\nI get:\r\n```python\r\nAssertionError: The dataset wmt16 with config cs-en requires manual data. \r\n Please follow the manual download instructions: Some of the wmt configs here, require a ... | 90366ecf2cafb7ea5a278bb78cd7985a813ba8aa | {
"head_commit": "65075233112d007c52bec6655aaa2399e7aef821",
"head_commit_message": "fix xtreme",
"patch_to_review": "diff --git a/datasets/c4/c4.py b/datasets/c4/c4.py\nindex 2ec2515f6a2..fb04e095966 100644\n--- a/datasets/c4/c4.py\n+++ b/datasets/c4/c4.py\n@@ -126,15 +126,6 @@ def __init__(self, language, cc_ve... | [
{
"diff_hunk": "@@ -107,6 +96,19 @@ class Wikihow(nlp.GeneratorBasedBuilder):\n WikihowConfig(name=\"sep\", filename=\"wikihowSep.csv\", description=\"use each paragraph and its summary.\"),\n ]\n \n+ @property\n+ def manual_download_instructions(self):\n+ return \"\"\"\\\n+ You need t... | 89f0cfdb49cc6b0b2334032070136443361e9cfd | diff --git a/datasets/c4/c4.py b/datasets/c4/c4.py
index 2ec2515f6a2..e8e984b1092 100644
--- a/datasets/c4/c4.py
+++ b/datasets/c4/c4.py
@@ -126,15 +126,6 @@ def __init__(self, language, cc_versions=None, clean=True, realnewslike=False, w
class C4(nlp.BeamBasedBuilder):
"""C4 dataset based on Common Crawl."""
-... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
huggingface__datasets-266@1c00dab | huggingface/datasets | Python | 266 | Add sort, shuffle, test_train_split and select methods | Add a bunch of methods to reorder/split/select rows in a dataset:
- `dataset.select(indices)`: Create a new dataset with rows selected following the list/array of indices (which can have a different size than the dataset and contain duplicated indices, the only constrain is that all the integers in the list must be sm... | 2020-06-11T16:22:20Z | Error with sklearn train_test_split
It would be nice if we could use sklearn `train_test_split` to quickly generate subsets from the dataset objects returned by `nlp.load_dataset`. At the moment the code:
```python
data = nlp.load_dataset('imdb', cache_dir=data_cache)
f_half, s_half = train_test_split(data['train'... | Indeed. Probably we will want to have a similar method directly in the library
Related: #166 | [
{
"body": "It would be nice if we could use sklearn `train_test_split` to quickly generate subsets from the dataset objects returned by `nlp.load_dataset`. At the moment the code:\r\n\r\n```python\r\ndata = nlp.load_dataset('imdb', cache_dir=data_cache)\r\nf_half, s_half = train_test_split(data['train'], test_s... | 5353490e9bceb25b662a2c5c407c087baca37028 | {
"head_commit": "1c00dab8d856fd8bb918a39876c80ecfcb1c1a65",
"head_commit_message": "index, sort, shuffle, train_test_split",
"patch_to_review": "diff --git a/src/nlp/arrow_dataset.py b/src/nlp/arrow_dataset.py\nindex 02fc3bc7513..259edf79dd4 100644\n--- a/src/nlp/arrow_dataset.py\n+++ b/src/nlp/arrow_dataset.py\... | [
{
"diff_hunk": "@@ -689,25 +689,87 @@ def map_function(batch, *args):\n # return map function\n return self.map(map_function, batched=True, with_indices=with_indices, arrow_schema=arrow_schema, **kwargs)\n \n+\n+ def index(",
"line": null,
"original_line": 693,
"original_start_lin... | e0a4be38fe5ef8fcfc0fd452ef083626aa7d8151 | diff --git a/src/nlp/arrow_dataset.py b/src/nlp/arrow_dataset.py
index 02fc3bc7513..6c89d46b2ad 100644
--- a/src/nlp/arrow_dataset.py
+++ b/src/nlp/arrow_dataset.py
@@ -21,6 +21,7 @@
import os
from collections import defaultdict
from collections.abc import Mapping
+from math import ceil, floor
from typing import An... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
iterative__dvc-5720@8d5aa8f | iterative/dvc | Python | 5,720 | exp show: Allow for wildcard patterns in include and exclude params/m… | …etrics
Fixes #5642
* [X] ❗ I have followed the [Contributing to DVC](https://dvc.org/doc/user-guide/contributing/core) checklist.
* [X] 📖 If this PR requires [documentation](https://dvc.org/doc) updates, I have created a separate PR (or issue, at least) in [dvc.org](https://github.com/iterative/dvc.org) and ... | 2021-03-28T18:12:51Z | Allow for wildcard patterns in include and exclude params/metrics with dvc exp show
When using the `dvc exp show` command, you have the possibility to include and exclude both parameters and metrics using the arguments:
```
--include-params
--exclude-params
--include-metrics
--exclude-metrics
```
Instead of ju... | [
{
"body": "When using the `dvc exp show` command, you have the possibility to include and exclude both parameters and metrics using the arguments:\r\n```\r\n--include-params\r\n--exclude-params\r\n--include-metrics\r\n--exclude-metrics\r\n```\r\n\r\nInstead of just providing an explicit list of parameters or me... | 6be2efc9cf7b0a7df81dfe50d9f2370cc8391e13 | {
"head_commit": "8d5aa8f7e9e9d84cc0d9d49c080ee9abd4ee47d2",
"head_commit_message": "pre-commit",
"patch_to_review": "diff --git a/dvc/command/experiments.py b/dvc/command/experiments.py\nindex b8180a1c9d..2960ce51bd 100644\n--- a/dvc/command/experiments.py\n+++ b/dvc/command/experiments.py\n@@ -3,7 +3,7 @@\n fro... | [
{
"diff_hunk": "@@ -27,32 +27,23 @@ def _filter_name(names, label, filter_strs):\n \n for filter_s in filter_strs:\n path, _, name = filter_s.rpartition(\":\")\n- path_filters[path].append(tuple(name.split(\".\")))\n+ path_filters[path].append(name)\n \n for path, filters in path_f... | 1d8759ea2959e456694ecb370a237b261694f9cd | diff --git a/dvc/command/experiments.py b/dvc/command/experiments.py
index b8180a1c9d..bb91fa7fa4 100644
--- a/dvc/command/experiments.py
+++ b/dvc/command/experiments.py
@@ -3,7 +3,7 @@
from collections import Counter, OrderedDict, defaultdict
from collections.abc import Mapping
from datetime import date, datetime
... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
iterative__dvc-5548@e7d5359 | iterative/dvc | Python | 5,548 | setup: rename azure.indentity to azure-identity | Fixes #5547
* [x] ❗ I have followed the [Contributing to DVC](https://dvc.org/doc/user-guide/contributing/core) checklist.
* [x] 📖 If this PR requires [documentation](https://dvc.org/doc) updates, I have created a separate PR (or issue, at least) in [dvc.org](https://github.com/iterative/dvc.org) and linked it h... | 2021-03-04T22:32:45Z | Easy-install entry-scripts broken at init using `load_entry_point`
# Bug Report
I have a cli entry-point. I somewhere import the `dvc` cli in my code. It fails at init because the 'azure.identity` package is not written properly in the `setup.py` propagating to the METADATA file when installed.
## Description
``... | [
{
"body": "# Bug Report\r\n\r\nI have a cli entry-point. I somewhere import the `dvc` cli in my code. It fails at init because the 'azure.identity` package is not written properly in the `setup.py` propagating to the METADATA file when installed.\r\n\r\n## Description\r\n```\r\n# EASY-INSTALL-ENTRY-SCRIPT: 'eec... | 1e7df0c27eba64f5e78a9e9fe8046b6bf9e9f90d | {
"head_commit": "e7d53596ed6f88f2e6a68f3f477b4621e22a4804",
"head_commit_message": "simple like that",
"patch_to_review": "diff --git a/dvc/version.py b/dvc/version.py\nindex 51515a4aab..1c6d1d8d83 100644\n--- a/dvc/version.py\n+++ b/dvc/version.py\n@@ -6,7 +6,7 @@\n import os\n import subprocess\n \n-_BASE_VERS... | [
{
"diff_hunk": "@@ -6,7 +6,7 @@\n import os\n import subprocess\n \n-_BASE_VERSION = \"2.0.1\"\n+_BASE_VERSION = \"2.0.2\"",
"line": null,
"original_line": 9,
"original_start_line": null,
"path": "dvc/version.py",
"start_line": null,
"text": "@user1:\n```suggestion\r\n_BASE_VERSION = \"2... | df300f95be8133ab180c5faf81a25b53c86ff905 | diff --git a/setup.py b/setup.py
index 809fe0935e..a256e04d7a 100644
--- a/setup.py
+++ b/setup.py
@@ -97,7 +97,7 @@ def run(self):
gs = ["gcsfs>=0.7.2"]
gdrive = ["pydrive2>=1.7.3", "six >= 1.13.0"]
s3 = ["boto3>=1.9.201"]
-azure = ["adlfs>=0.6.3", "azure.identity>=1.4.0", "knack"]
+azure = ["adlfs>=0.6.3", "azure-... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "Dependency Updates & Env Compatibility"
} | |
gradio-app__gradio-9023@d67c72e | gradio-app/gradio | Python | 9,023 | Add height param to gr.JSON | ## Description
I initially implemented `height` as a param but we have a `lines` param in gr.Code, so it makes some sense to keep them fairly consistent.
I also added the lines param description in gr.Code that was missing, and added a tiny css tweak to handle big line numbers.
Closes: #8982
## 🎯 PRs Shou... | 2024-08-06T08:16:20Z | The gr.JSON requires the lines parameter.
- [ Yes] I have searched to see if a similar issue already exists.
Is it possible to configure gr.JSON() with lines to ensure that content overflow does not occur? Previously, I tried using gr.Textbox(inputs=gr.JSON()), but doing this loses the interactive functionality of J... | I think this is fixed in version 4.40.0 - the json component will no longer overflow horizontally or vertically
My current version is already 4.40. Currently, the JSON is too long and automatically adapts to be particularly long (as shown in the first image). However, I would like to restrict it within a specified box ... | [
{
"body": "- [ Yes] I have searched to see if a similar issue already exists.\r\n\r\nIs it possible to configure gr.JSON() with lines to ensure that content overflow does not occur? Previously, I tried using gr.Textbox(inputs=gr.JSON()), but doing this loses the interactive functionality of JSON.\r\n",
"num... | d6dc3846fd94fe03658f0fa8219d68ddf1f7aa64 | {
"head_commit": "d67c72eda13cb421738d974972b5b484015d3958",
"head_commit_message": "fix test",
"patch_to_review": "diff --git a/gradio/components/code.py b/gradio/components/code.py\nindex 0368be1f0d..75eb913816 100644\n--- a/gradio/components/code.py\n+++ b/gradio/components/code.py\n@@ -122,6 +122,7 @@ def __i... | [
{
"diff_hunk": "@@ -67,6 +68,7 @@ def __init__(\n key: if assigned, will be used to assume identity across a re-render. Components that have the same key across a re-render will have their value preserved.\n open: If True, all JSON nodes will be expanded when rendered. By default, node l... | 6f28d395ea709c5efb5e9a99a901774a6ccc1dcd | diff --git a/.changeset/little-trams-wait.md b/.changeset/little-trams-wait.md
new file mode 100644
index 0000000000..801abf547d
--- /dev/null
+++ b/.changeset/little-trams-wait.md
@@ -0,0 +1,6 @@
+---
+"@gradio/json": minor
+"gradio": minor
+---
+
+feat:Add height param to gr.JSON
diff --git a/gradio/components/code.p... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
gradio-app__gradio-9013@360c7d4 | gradio-app/gradio | Python | 9,013 | Add copy all messages button to chatbot | ## Description
Adds a copy all button (via a `show_copy_all_button` param) similar to gr.JSON and other components. I'm curious to know if we think this should look more unique to the other copy buttons in Chatbot 🤔
~Having other messages with copy buttons will look confusing, and scrolling will look terrible i... | 2024-08-05T22:43:36Z | Chatbot copy all messages
for gradio.Chatbot(...) create a 'show_copy_all_messages_button' parameter. It would copy the entire chat history onto clipboard. This is a useful feature because copying all the messages manually can be difficult given the scrolling nature of the interface. Currently there are two parameters... | Thanks @mberco-quandl for creating this issue. Yes we've heard versions of this issue quite a bit, and I think what you're describing makes sense. cc @dawoodkhan82!
I would love to see this enhancement added as well. | [
{
"body": "for gradio.Chatbot(...) create a 'show_copy_all_messages_button' parameter. It would copy the entire chat history onto clipboard. This is a useful feature because copying all the messages manually can be difficult given the scrolling nature of the interface. Currently there are two parameters 'show_... | 62ed369efa6befac9a0eac736edcfa87a8d87a43 | {
"head_commit": "360c7d490791678dbdc70c7a0e879085695bcf30",
"head_commit_message": "Merge branch 'main' into chatbot-copy-msgs",
"patch_to_review": "diff --git a/gradio/components/chatbot.py b/gradio/components/chatbot.py\nindex fd629c6cd5..74caf6ae3d 100644\n--- a/gradio/components/chatbot.py\n+++ b/gradio/comp... | [
{
"diff_hunk": "@@ -0,0 +1,78 @@\n+<script lang=\"ts\">\n+\timport { onDestroy } from \"svelte\";\n+\timport { Copy, Check } from \"@gradio/icons\";\n+\timport type { NormalisedMessage } from \"../types\";\n+\n+\tlet copied = false;\n+\texport let value: NormalisedMessage[] | null;\n+\n+\tlet timer: NodeJS.Time... | 37141e9807203a720acfc0e4193936ec6f15cec6 | diff --git a/.changeset/new-masks-retire.md b/.changeset/new-masks-retire.md
new file mode 100644
index 0000000000..178d38a110
--- /dev/null
+++ b/.changeset/new-masks-retire.md
@@ -0,0 +1,7 @@
+---
+"@gradio/chatbot": minor
+"@gradio/code": minor
+"gradio": minor
+---
+
+feat:Add copy all messages button to chatbot
di... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
gradio-app__gradio-8733@4e0fcd9 | gradio-app/gradio | Python | 8,733 | Improvements to `gr.Examples`: adds events as attributes and documents, them, adds `sample_labels`, and `visible` properties | Makes several enhancements to `gr.Examples`:
* Adds `load_input_event` and `cache_event` as public attributes and documents them (closes: #8710)
* Adds `visible` prop (closes: https://github.com/gradio-app/gradio/issues/6390)
* Adds `example_labels` prop (closes: https://github.com/gradio-app/gradio/issues/4268) | 2024-07-10T00:02:12Z | gr.Examples Enable for each example to have a label and a value
- [yes ] I have searched to see if a similar issue already exists.
For example I would like the gr.Examples to display the example as "Person 1" and when it is clicked, to populate the linked component with "John Doe".
Support `visible` option in `g... | The way I'm thinking to implement this is to add a `labels` parameter to `gr.Examples()` (and an `examples_labels` parameter to `gr.Interface()`) which is a list of the same length as `examples`. If provided, these text labels appear instead of the original examples, but clicking on the labels populates the inputs in t... | [
{
"body": "- [yes ] I have searched to see if a similar issue already exists.\r\n\r\nFor example I would like the gr.Examples to display the example as \"Person 1\" and when it is clicked, to populate the linked component with \"John Doe\". \r\n",
"number": 4268,
"title": "gr.Examples Enable for each ex... | d15ada9a1c270dd86e1751b1846510a70dc48510 | {
"head_commit": "4e0fcd97fe6b7070dbb96b8941841e69e6a4b600",
"head_commit_message": "changes",
"patch_to_review": "diff --git a/.changeset/slow-candles-fail.md b/.changeset/slow-candles-fail.md\nnew file mode 100644\nindex 0000000000..6ac84418ed\n--- /dev/null\n+++ b/.changeset/slow-candles-fail.md\n@@ -0,0 +1,7 ... | [
{
"diff_hunk": "@@ -121,6 +129,8 @@ def __init__(\n postprocess: if True, postprocesses the example output after running the prediction function and before caching. Only applies if `cache_examples` is not False.\n api_name: Defines how the event associated with clicking on the examples a... | f9d31cd15c783f747253934990591a1d9a04212a | diff --git a/.changeset/slow-candles-fail.md b/.changeset/slow-candles-fail.md
new file mode 100644
index 0000000000..6ac84418ed
--- /dev/null
+++ b/.changeset/slow-candles-fail.md
@@ -0,0 +1,7 @@
+---
+"@gradio/dataset": minor
+"gradio": minor
+"website": minor
+---
+
+feat:Improvements to `gr.Examples`: adds events a... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
gradio-app__gradio-8677@13adb7e | gradio-app/gradio | Python | 8,677 | Allow supplying custom `gr.Chatbot` with events to `gr.ChatInterface` | Fixes: https://github.com/gradio-app/gradio/issues/8675 so that now you can put a `gr.ChatInterface` inside a `gr.Blocks` with a custom `gr.Chatbot` and attach events, like this:
```py
import gradio as gr
def vote(data: gr.LikeData):
print(data.value)
if data.liked:
print("You upvoted this res... | 2024-07-01T12:57:22Z | Error when passing in a custom chatbot to add like/dislike feature to Chatinterface
how can I add a like/dislike function to Chatinterface?
this is possible with blocks but I can't add to a Chatinterface.
import gradio as gr
def greet(history, input):
return history + [(input, "Hello, " + input)]
def vote(da... | Hi @sajjadmosaheb to do this, you can pass in a custom `gr.Chatbot` object into the `chatbot` argument of `gr.ChatInterface` as described here: https://www.gradio.app/guides/creating-a-chatbot-fast#customizing-your-chatbot, and then attach a `.like` event to it.
Hi @abidlabs ,
but when I attach the .like() event like... | [
{
"body": "how can I add a like/dislike function to Chatinterface?\r\nthis is possible with blocks but I can't add to a Chatinterface.\r\n\r\nimport gradio as gr\r\n\r\ndef greet(history, input):\r\nreturn history + [(input, \"Hello, \" + input)]\r\n\r\ndef vote(data: gr.LikeData):\r\nif data.liked:\r\nprint(\"... | 9e0d6774b841ea0420ad5dbaeb516f1ad3b494c2 | {
"head_commit": "13adb7eb44862db70e0cad33ab145060b89ff3fe",
"head_commit_message": "add changeset",
"patch_to_review": "diff --git a/.changeset/soft-months-behave.md b/.changeset/soft-months-behave.md\nnew file mode 100644\nindex 0000000000..688cfd78b0\n--- /dev/null\n+++ b/.changeset/soft-months-behave.md\n@@ -... | [
{
"diff_hunk": "@@ -136,6 +136,25 @@ gr.ChatInterface(\n \n The placeholder appears vertically and horizontally centered in the chatbot.\n \n+If you would like to attach event listeners to your custom chatbot, wrap the chatbot as well as the `gr.ChatInterface` inside of a `gr.Blocks` like this:",
"line": nu... | 65dc93b2bdc1eca41daa08cbca588de1f0c10b8b | diff --git a/.changeset/soft-months-behave.md b/.changeset/soft-months-behave.md
new file mode 100644
index 0000000000..21ccb51550
--- /dev/null
+++ b/.changeset/soft-months-behave.md
@@ -0,0 +1,6 @@
+---
+"gradio": patch
+"website": patch
+---
+
+fix:Allow supplying custom `gr.Chatbot` with events to `gr.ChatInterface... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
home-assistant__core-128996@97a3454 | home-assistant/core | Python | 128,996 | Reduce the number of API calls in Twitch integration | I follow almost 200 people. This reduces the number of API calls from around 800 to around 404.
<!--
You are amazing! Thanks for contributing to our project!
Please, DO NOT DELETE ANY TEXT from this template! (unless instructed).
-->
## Breaking change
<!--
If your PR contains a breaking change for exis... | 2024-10-22T18:08:53Z | Twitch integration uses excessive API requests
### The problem
Many of the Helix API requests (e.g. `get-streams`, `get-channel-followers`, and `get-followed-channels`) offer pagination. I follow about 120 channels, which ends up being somewhere in the area of 500 API requests and takes about 3 minutes to update ev... | I'm wrong about `get_streams`; it would need to switch to `get_followed_streams` to get pagination (`get_streams` works on all streams on the platform and removing `broadcaster_id` there would just be a massive list).
I took a crack at this, but async Python breaks my brain and I gave up. Taking `get_channel_follow... | [
{
"body": "### The problem\r\n\r\nMany of the Helix API requests (e.g. `get-streams`, `get-channel-followers`, and `get-followed-channels`) offer pagination. I follow about 120 channels, which ends up being somewhere in the area of 500 API requests and takes about 3 minutes to update every channel.\r\n\r\nFor ... | f91a1363cb6a0e9f78e9648701a5f8c24d2ee81c | {
"head_commit": "97a34546d64920e87f92e7241775f4cbf66f48c7",
"head_commit_message": "Make tests pass after Twitch API reduction changes.",
"patch_to_review": "diff --git a/homeassistant/components/twitch/coordinator.py b/homeassistant/components/twitch/coordinator.py\nindex 5e3de4c4ec8ea..6390ca45e867d 100644\n--... | [
{
"diff_hunk": "@@ -83,11 +83,23 @@ async def _async_update_data(self) -> dict[str, TwitchUpdate]:\n False,\n )\n data = {}\n+ streams: list[Stream] = [\n+ s\n+ async for s in self.twitch.get_followed_streams(\n+ user_id=self.current_user.i... | 2a8fcfe5d4c6e284ebfc24d33de66d73b97dde9f | diff --git a/homeassistant/components/twitch/coordinator.py b/homeassistant/components/twitch/coordinator.py
index 00e36781ee7b39..c34eeaa5325bf0 100644
--- a/homeassistant/components/twitch/coordinator.py
+++ b/homeassistant/components/twitch/coordinator.py
@@ -4,7 +4,7 @@
from datetime import datetime, timedelta
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Performance Optimizations"
} |
iterative__dvc-5275@2a08985 | iterative/dvc | Python | 5,275 | tree: Introduce the new .ls() API | Resolves #5274
Introduces a new `Tree.ls()` API for listings
master:
```
Importing 's3://dvc-temp/import-url' -> 'import-url'
To track the changes with git, run:
git add import-url.dvc
dvc import-url s3://dvc-temp/import-url 57,20s user 2,65s system 27% cpu 3:37,47 total
```
t... | 2021-01-15T14:09:37Z | tree, import-url: Introduce a new .ls() API for faster dir_info generation (including collection of hash_infos for entries)
Currently, we list files and then fetch every file individually to get their e-tag, which is very costly both in terms of time and the number of API requests we do, so instead, we can retrieve bot... | [
{
"body": "Currently, we list files and then fetch every file individually to get their e-tag, which is very costly both in terms of time and the number of API requests we do, so instead, we can retrieve both `size` and `e_tag` directly on the listing (object summaries) and reduce them the amount of requests we... | fc77618ad1eb9d0bb306a85e4f750660b5285318 | {
"head_commit": "2a08985649d6a2286adc1a12afd7fbb7eaeb4657",
"head_commit_message": "assert recursive",
"patch_to_review": "diff --git a/dvc/tree/azure.py b/dvc/tree/azure.py\nindex b80ad74c35..c84d5f61c9 100644\n--- a/dvc/tree/azure.py\n+++ b/dvc/tree/azure.py\n@@ -23,6 +23,8 @@ class AzureTree(BaseTree):\n ... | [
{
"diff_hunk": "@@ -227,6 +228,20 @@ def walk_files(self, path_info, **kwargs):\n \n yield path_info.replace(path=fname)\n \n+ def ls(self, path_info, recursive=False, detail=False):\n+ assert recursive\n+\n+ with self._get_bucket(path_info.bucket) as bucket:\n+ for obj_s... | db956391f071c48c37f8c6534cd6d41f9c2808c0 | diff --git a/dvc/tree/azure.py b/dvc/tree/azure.py
index b80ad74c35..5791b6f5b3 100644
--- a/dvc/tree/azure.py
+++ b/dvc/tree/azure.py
@@ -23,6 +23,8 @@ class AzureTree(BaseTree):
"knack": "knack",
}
PARAM_CHECKSUM = "etag"
+ DETAIL_FIELDS = frozenset(("etag", "size"))
+
COPY_POLL_SECONDS = 5... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
iterative__dvc-5236@a7b42c4 | iterative/dvc | Python | 5,236 | cli: remove: fix error message for the case when file is not under control (#4497) | Partially fix #4497
* [x] ❗ I have followed the [Contributing to DVC](https://dvc.org/doc/user-guide/contributing/core) checklist.
* [x] 📖 If this PR requires [documentation](https://dvc.org/doc) updates, I have created a separate PR (or issue, at least) in [dvc.org](https://github.com/iterative/dvc.org) and li... | 2021-01-07T22:33:34Z | remove one of many stage outputs: misleading error message
Users cannot remove a data file if it is only one output of many for a stage. It is a valid behavior that needs a better error message:
```
$ dvc remove model.h5
ERROR: failed to remove 'model.h5' - "Stage 'model.h5' not found inside 'dvc.yaml' file"
```
... | Also, formatting issues:
1. The prefix ` failed to remove 'model.h5' -` is not needed. Too obvious.
2. Quoted error message `"Stage 'model.h5' not ..."`
@dmpetrov, we don't support removing a `.dvc` file by its output name yet. The target should be either a `.dvc` file or a name of the stage.
Another user ran into it... | [
{
"body": "Users cannot remove a data file if it is only one output of many for a stage. It is a valid behavior that needs a better error message:\r\n\r\n```\r\n$ dvc remove model.h5\r\nERROR: failed to remove 'model.h5' - \"Stage 'model.h5' not found inside 'dvc.yaml' file\"\r\n```\r\n\r\nThe pipeline:\r\n```\... | 1ab1abf62a8b7811d08ce17434a1e5cca382f709 | {
"head_commit": "a7b42c4c47f2657675a0c1769f76f2f1de9aaba8",
"head_commit_message": "cli: remove: fix error message for the case when file is not under control (#4497)\n\n2nd round of fixes after code review",
"patch_to_review": "diff --git a/dvc/command/remove.py b/dvc/command/remove.py\nindex c2dab5e7a1..8b2ef4... | [
{
"diff_hunk": "@@ -80,7 +80,7 @@ def __init__(self, missing_files):\n super().__init__(msg)\n \n \n-class StageNotFound(KeyError, DvcException):\n+class StageNotFound(DvcException):",
"line": null,
"original_line": 83,
"original_start_line": null,
"path": "dvc/stage/exceptions.py",
... | 2e1666866bc17dd5ef962cb9272fddc5d0e905e4 | diff --git a/dvc/command/remove.py b/dvc/command/remove.py
index c2dab5e7a1..8b2ef4d8d7 100644
--- a/dvc/command/remove.py
+++ b/dvc/command/remove.py
@@ -13,8 +13,8 @@ def run(self):
for target in self.args.targets:
try:
self.repo.remove(target, outs=self.args.outs)
- ... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
iterative__dvc-5163@393fa20 | iterative/dvc | Python | 5,163 | checkout: fix partial file checkouts in the same directory | Resolves #5158 | 2020-12-26T13:28:16Z | pull/checkout: pulling multiple files consecutively from a folder checks out only first
# Bug Report
## Description
When attempting to pull individual files from dvc tracked folder, only the first pull creates file links. Similar behavior with `checkout` unless `--relink` is used.
### Reproduce
0. (git + dvc ... | I'd like to propose a patch for this if no one else already prepared something (cc: @efiop) [have a working demo, no tests yet though] | [
{
"body": "# Bug Report\r\n\r\n## Description\r\n\r\nWhen attempting to pull individual files from dvc tracked folder, only the first pull creates file links. Similar behavior with `checkout` unless `--relink` is used.\r\n\r\n### Reproduce\r\n0. (git + dvc init)\r\n\r\n1. mkdir db\r\n2. touch db/a.txt && touch ... | 40bd838c11c23649e7bdb39590699740c0401bff | {
"head_commit": "393fa204ed34afb151c759121b630bffdc353927",
"head_commit_message": "Update dvc/cache/base.py\n\nCo-authored-by: Ruslan Kuprieiev <kupruser@gmail.com>",
"patch_to_review": "diff --git a/dvc/cache/base.py b/dvc/cache/base.py\nindex 1f8ce26b91..eae344cd84 100644\n--- a/dvc/cache/base.py\n+++ b/dvc/c... | [
{
"diff_hunk": "@@ -89,7 +89,26 @@ def load_dir_cache(self, hash_info):\n \n return DirInfo.from_list(d)\n \n- def changed(self, path_info, hash_info):\n+ def _get_filtered_hash_info(self, filter_info, hash_info, path_info):\n+ dir_info = self.get_dir_cache(hash_info)\n+ hash_key = f... | 5552f09a0c33258392c38cda0fbace44b8adee56 | diff --git a/dvc/cache/base.py b/dvc/cache/base.py
index 1f8ce26b91..b79a826f67 100644
--- a/dvc/cache/base.py
+++ b/dvc/cache/base.py
@@ -89,7 +89,29 @@ def load_dir_cache(self, hash_info):
return DirInfo.from_list(d)
- def changed(self, path_info, hash_info):
+ def _filter_hash_info(self, hash_info... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
gradio-app__gradio-8594@9733002 | gradio-app/gradio | Python | 8,594 | chatbot component tweaks | ## Description
Please include a concise summary, in clear English, of the changes in this pull request. If it closes an issue, please mention it here.
Closes #8544
## 🎯 PRs Should Target Issues
Before your create a PR, please check to see if there is [an existing issue](https://github.com/gradio-app/gradi... | 2024-06-21T18:04:47Z | chatbot components
### Describe the bug
- if you make the screen small, you can't see the plots properly
- the gallery has a gap at the bottom
- you can't select a different gallery image, it just full screens everything
- the thumb up/ down buttons overlap some of the components
- the autoscrolling sometimes does... | [
{
"body": "### Describe the bug\n\n- if you make the screen small, you can't see the plots properly\r\n- the gallery has a gap at the bottom\r\n- you can't select a different gallery image, it just full screens everything\r\n- the thumb up/ down buttons overlap some of the components\r\n- the autoscrolling some... | d35c290aadcb85113ee7ceea96a7ed7dc894b1d2 | {
"head_commit": "97330029c2780581a08436099cc08dcb2699edc9",
"head_commit_message": "remove comment",
"patch_to_review": "diff --git a/.changeset/clear-cloths-dream.md b/.changeset/clear-cloths-dream.md\nnew file mode 100644\nindex 0000000000..f0a8c644c4\n--- /dev/null\n+++ b/.changeset/clear-cloths-dream.md\n@@ ... | [
{
"diff_hunk": "@@ -22,14 +24,35 @@\n \t\t}\n \t}\n \n-\tafterUpdate(() => {\n+\tafterUpdate(async () => {\n \t\tload_plotly_css();\n+\n \t\tlet plotObj = JSON.parse(plot);\n+\n+\t\t// the docs aren't very good but this works\n+\t\tplotObj.config = plotObj.config || {};\n+\t\tplotObj.config.responsive = true;\n... | 4dcfdac49485babe06fb18613b33b09d27b8fa35 | diff --git a/.changeset/clear-cloths-dream.md b/.changeset/clear-cloths-dream.md
new file mode 100644
index 0000000000..f0a8c644c4
--- /dev/null
+++ b/.changeset/clear-cloths-dream.md
@@ -0,0 +1,13 @@
+---
+"@gradio/audio": patch
+"@gradio/chatbot": patch
+"@gradio/gallery": patch
+"@gradio/icons": patch
+"@gradio/imag... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} | |
iterative__dvc-4978@82715d5 | iterative/dvc | Python | 4,978 | dvc: more explict error during init when .dvc is ignored by git | Fixes #3738
* [X] ❗ I have followed the [Contributing to DVC](https://dvc.org/doc/user-guide/contributing/core) checklist.
* [X] 📖 If this PR requires [documentation](https://dvc.org/doc) updates, I have created a separate PR (or issue, at least) in [dvc.org](https://github.com/iterative/dvc.org) and linked it h... | 2020-11-26T17:55:56Z | dvc init fails when .dvc directory is git-ignored
Tested on Windows (binary & pip install) in Windows Terminal (Powershell) and in Git Bash.
**Issue**
I tried to run "dvc init" in a repository that had an ".*" entry in its .gitignore. With -v flag, it fails with the following message:
```
Traceback (most recent c... | Discord Context: https://discordapp.com/channels/485586884165107732/485596304961962003/706846820172824679 | [
{
"body": "Tested on Windows (binary & pip install) in Windows Terminal (Powershell) and in Git Bash.\r\n\r\n**Issue**\r\nI tried to run \"dvc init\" in a repository that had an \".*\" entry in its .gitignore. With -v flag, it fails with the following message:\r\n```\r\nTraceback (most recent call last):\r\n F... | 6d745eb4f0fc4578e3abea25a9becaf2c9da1612 | {
"head_commit": "82715d53b8d8324ecfd30c03d62a8ae900a29bfe",
"head_commit_message": "dvc: more explict error during init when .dvc is ignored by git\n\nFixes #3738",
"patch_to_review": "diff --git a/.gitignore b/.gitignore\nindex 6333faa59d..91becd9ad1 100644\n--- a/.gitignore\n+++ b/.gitignore\n@@ -5,6 +5,7 @@ n... | [
{
"diff_hunk": "@@ -51,6 +52,16 @@ def init(root_dir=os.curdir, no_scm=False, force=False, subdir=False):\n \"repository.\".format(repo=root_dir)\n )\n \n+ if isinstance(scm, Git):\n+ if scm.is_ignored(dvc_dir):\n+ raise InitError(\n+ \"{dvc_dir} is ignore... | c336fe124a0ff060c7c47c22155d70127b826daa | diff --git a/.gitignore b/.gitignore
index 6333faa59d..91becd9ad1 100644
--- a/.gitignore
+++ b/.gitignore
@@ -5,6 +5,7 @@ neatlynx/__pycache__
*.pyc
.env/
.env2.7/
+.python-version
.dvc.conf.lock
.DS_Store
diff --git a/dvc/repo/init.py b/dvc/repo/init.py
index 2712b2279a..87b5549ecc 100644
--- a/dvc/repo/init.p... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
iterative__dvc-5148@c009a1e | iterative/dvc | Python | 5,148 | remove: delete .gitignore file if empty | modified behavior to unlink empty .gitignore files.
added corresponding unit & func test cases.
updated failing test cases.
no failing tests
Fixes #4962
* [x] ❗ I have followed the [Contributing to DVC](https://dvc.org/doc/user-guide/contributing/core) checklist.
* [] 📖 If this PR requires [documentation](... | 2020-12-22T07:18:50Z | remove: delete .gitignore file if empty
Just like `dvc remove` deletes dvc.yaml and dvc.lock if they're empty after the removal, should it do the same to .gitignore? Currently it's left there even if empty, which shows up as a change in git (so it's pretty obvious). | I am exploring DVC. Can I be assigned this one ?
@devramx Sure! Thanks for looking into it! :pray: | [
{
"body": "Just like `dvc remove` deletes dvc.yaml and dvc.lock if they're empty after the removal, should it do the same to .gitignore? Currently it's left there even if empty, which shows up as a change in git (so it's pretty obvious).",
"number": 4962,
"title": "remove: delete .gitignore file if empt... | 76cc70a86ba49b4f55e2b98d9c03249a38025234 | {
"head_commit": "c009a1ea5a823048571ca5737d235b52d1a9945c",
"head_commit_message": "fix failing lint checks",
"patch_to_review": "diff --git a/dvc/scm/git/__init__.py b/dvc/scm/git/__init__.py\nindex d01e675d1b..158a1545e2 100644\n--- a/dvc/scm/git/__init__.py\n+++ b/dvc/scm/git/__init__.py\n@@ -165,6 +165,10 @@... | [
{
"diff_hunk": "@@ -279,3 +279,36 @@ def test_list_all_commits(tmp_dir, scm):\n scm.set_ref(\"refs/foo/bar\", rev_c)\n \n assert {rev_a, rev_b} == set(scm.list_all_commits())\n+\n+\n+def test_ignore_remove_empty(tmp_dir, scm):\n+ from dvc.scm.git import Git\n+\n+ git_ = Git(os.fspath(tmp_dir))",
... | 4ebb15f158435ee905e44d41a4f2df55eef3e65f | diff --git a/dvc/scm/git/__init__.py b/dvc/scm/git/__init__.py
index d01e675d1b..158a1545e2 100644
--- a/dvc/scm/git/__init__.py
+++ b/dvc/scm/git/__init__.py
@@ -165,6 +165,10 @@ def ignore_remove(self, path):
filtered = list(filter(lambda x: x.strip() != entry.strip(), lines))
+ if not filtered:
+... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
gradio-app__gradio-8446@61aab74 | gradio-app/gradio | Python | 8,446 | state.change listener with deep hash check | state.change event listeners now do "deep checks", by deep hashing the old value. This makes @gr.render logic much cleaner. See demo/todo_list changes to see how much simpler the code is now because state values can be edited directly to induce a change.
Closes: https://github.com/gradio-app/gradio/issues/8436 | 2024-06-04T06:17:34Z | How to modify State(list) to trigger State.change()
It seems that state.change() can only be triggered when variables' id changes, such as int, str, etc. For a list, if only the elements in the list are modified, state.change() cannot be triggered unless a new copy of the list is copied and returned. However, copying t... | We're looking into a solution for this! cc @aliabid94 | [
{
"body": "It seems that state.change() can only be triggered when variables' id changes, such as int, str, etc. For a list, if only the elements in the list are modified, state.change() cannot be triggered unless a new copy of the list is copied and returned. However, copying the list every time can waste a lo... | 33c8081aa967ffc6fec68e15946b9bce2e848ee2 | {
"head_commit": "61aab74d911a90c0ad6845d4c7a36f272572d4bb",
"head_commit_message": "changes",
"patch_to_review": "diff --git a/.changeset/young-lamps-press.md b/.changeset/young-lamps-press.md\nnew file mode 100644\nindex 0000000000..710cab5226\n--- /dev/null\n+++ b/.changeset/young-lamps-press.md\n@@ -0,0 +1,5 ... | [
{
"diff_hunk": "@@ -51,7 +51,7 @@ $demo_todo_list\n \n Note that almost the entire app is inside a single `gr.render` that reacts to the tasks `gr.State` variable. This variable is a nested list, which presents some complexity. If you design a `gr.render` to react to a list or dict structure, ensure you do the ... | 18ae92782cf6061a6ac1055698779537e9e17b34 | diff --git a/.changeset/young-lamps-press.md b/.changeset/young-lamps-press.md
new file mode 100644
index 0000000000..710cab5226
--- /dev/null
+++ b/.changeset/young-lamps-press.md
@@ -0,0 +1,5 @@
+---
+"gradio": minor
+---
+
+feat:state.change listener with deep hash check
diff --git a/demo/audio_mixer/run.ipynb b/dem... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Code Refactoring / Architectural Improvement"
} |
iterative__dvc-4977@f6fa37b | iterative/dvc | Python | 4,977 | New option `jobs` for `dvc import` | Fixes #4838
* [x] ❗ I have followed the [Contributing to DVC](https://dvc.org/doc/user-guide/contributing/core) checklist.
* [x] 📖 If this PR requires [documentation](https://dvc.org/doc) updates, I have created a separate PR (or issue, at least) in [dvc.org](https://github.com/iterative/dvc.org) and linked it h... | 2020-11-26T14:34:43Z | import: `--jobs` option
`dvc import` Provides an easy way to reuse files or directories tracked in any DVC repository. This external tracked data might be stored in a remote DVC repository. In this situation `--job` which controls the parallelism level for DVC to download data from remote storage would be a useful opti... | @efiop
Excuse me,
What is the difference between `BaseTree.download` and `RepoTree.get_dir_hash`?
In the first one, `jobs` is read from a config file while in the second, it was passed as a parameter.
And in
https://github.com/iterative/dvc/blob/6d745eb4f0fc4578e3abea25a9becaf2c9da1612/dvc/dependency/repo.py#L... | [
{
"body": "`dvc import` Provides an easy way to reuse files or directories tracked in any DVC repository. This external tracked data might be stored in a remote DVC repository. In this situation `--job` which controls the parallelism level for DVC to download data from remote storage would be a useful option.",... | 6d745eb4f0fc4578e3abea25a9becaf2c9da1612 | {
"head_commit": "f6fa37b65ae9fc6f9bddbfdaf2046f48465c0223",
"head_commit_message": "Pass `jobs` to `run` and remove some pylint",
"patch_to_review": "diff --git a/dvc/command/imp.py b/dvc/command/imp.py\nindex 9528282a09..6b896c59b8 100644\n--- a/dvc/command/imp.py\n+++ b/dvc/command/imp.py\n@@ -19,6 +19,7 @@ de... | [
{
"diff_hunk": "@@ -12,3 +12,4 @@ class StageParams:\n PARAM_METRICS = \"metrics\"\n PARAM_PLOTS = \"plots\"\n PARAM_DESC = \"desc\"\n+ PARAM_JOBS = \"jobs\"",
"line": null,
"original_line": 15,
"original_start_line": null,
"path": "dvc/stage/params.py",
"start_line": null,
... | 498e94e722956c221a529578d23da7cbb85d68e9 | diff --git a/dvc/command/imp.py b/dvc/command/imp.py
index 9528282a09..6b896c59b8 100644
--- a/dvc/command/imp.py
+++ b/dvc/command/imp.py
@@ -19,6 +19,7 @@ def run(self):
rev=self.args.rev,
no_exec=self.args.no_exec,
desc=self.args.desc,
+ jobs=self.arg... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
iterative__dvc-4832@e81b4ea | iterative/dvc | Python | 4,832 | utils/fs: checking files ownership in 'move' (#4348) | Files are checked for ownership by trying to `chmod` them before moving them around; if fail, return a verbose exception.
Previous behavior: moving files to a temp folder and then do the check; when fail, files seemed to be missing.
Should fix #4348 and maybe fix #2992.
* [x] ❗ I have followed the [Contributing ... | 2020-11-03T10:20:09Z | better message when trying to link from files that belong to another user
**Please provide information about your setup**
DVC version(i.e. `dvc --version`), Platform and method of installation (pip, homebrew, pkg Mac, exe (Windows), DEB(Linux), RPM(Linux))
DVC version: 0.77.3, Platform linux, method of installation: ... | @qiuwei that's sounds really bad, but it's not exactly clear what's happening here - could you please give us a little bit more details?
> Our team has a shared data directory
is it `/gendata`? do you use the same dir for the DVC cache? is DVC cache set to be shared as well?
> DVC doesn't support shared repos... | [
{
"body": "**Please provide information about your setup**\r\nDVC version(i.e. `dvc --version`), Platform and method of installation (pip, homebrew, pkg Mac, exe (Windows), DEB(Linux), RPM(Linux))\r\nDVC version: 0.77.3, Platform linux, method of installation: anaconda\r\n\r\nProblem:\r\nOur team has a shared d... | 6a9ab9cdfbf8ddd5ccb647b072cc36955a69a0e1 | {
"head_commit": "e81b4eae56d7f212024c4369b0c23c2c4129b7d1",
"head_commit_message": "utils/fs: checking files ownership in 'move' (#4348)",
"patch_to_review": "diff --git a/dvc/utils/fs.py b/dvc/utils/fs.py\nindex d80bce6ede..975ab9c1f5 100644\n--- a/dvc/utils/fs.py\n+++ b/dvc/utils/fs.py\n@@ -95,15 +95,19 @@ def... | [
{
"diff_hunk": "@@ -95,15 +95,19 @@ def move(src, dst, mode=None):\n dst = os.path.abspath(dst)\n tmp = f\"{dst}.{uuid()}\"\n \n+ try:\n+ if mode is not None:\n+ os.chmod(src, mode)\n+ except OSError:\n+ # File not owned by us, raise exception",
"line": null,
"orig... | 314f49eb49b0a6ec2da313e540f7e0c3469117f0 | diff --git a/dvc/exceptions.py b/dvc/exceptions.py
index 17b4a87eda..b793dad2a3 100644
--- a/dvc/exceptions.py
+++ b/dvc/exceptions.py
@@ -218,6 +218,11 @@ def __init__(self, path, hint=None):
)
+class FileOwnershipError(DvcException):
+ def __init__(self, path):
+ super().__init__(f"file '{path}... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
iterative__dvc-4778@9b77273 | iterative/dvc | Python | 4,778 | add: fix issue when adding already tracked symlinked files | * [x] ❗ I have followed the [Contributing to DVC](https://dvc.org/doc/user-guide/contributing/core) checklist.
* [x] 📖 If this PR requires [documentation](https://dvc.org/doc) updates, I have created a separate PR (or issue, at least) in [dvc.org](https://github.com/iterative/dvc.org) and linked it here.
Thank y... | 2020-10-23T09:40:04Z | Cannot dvc add an already tracked file that lies in a folder
## Bug Report
**dvc version:** 1.8.0
----**Use case problem**----
So I have folder that looks like that:
```
.
├── Annotations.json -> /media/newhdd/data/ki67_er_pr/data/dvc_cache/44/7b62afed38955cb2a2f4ca35c5133c
├── Annotations.json.dvc
└── anno... | Hi @lefos99 !
Could you show the contents of `annotator/Annotation_0_hotspot_0.json.dvc`, please?
Hi @efiop
Which file do you mean? I don't have such a file in this directory.
**Update:**
Sorry now I saw the confusion, I fixed my initial comment. (Sorry I had to hide some sensitive information)
@lefos99 Tha... | [
{
"body": "## Bug Report\r\n\r\n**dvc version:** 1.8.0\r\n\r\n----**Use case problem**----\r\nSo I have folder that looks like that:\r\n```\r\n.\r\n├── Annotations.json -> /media/newhdd/data/ki67_er_pr/data/dvc_cache/44/7b62afed38955cb2a2f4ca35c5133c\r\n├── Annotations.json.dvc\r\n└── annotator\r\n ├── ki67_... | f8ba5daae23ffc5c2135f86670bd562d6ce654d7 | {
"head_commit": "9b77273f223fd702c062822a7574f8297cbe7feb",
"head_commit_message": "update tests",
"patch_to_review": "diff --git a/dvc/utils/__init__.py b/dvc/utils/__init__.py\nindex fc324211d8..ddd4dacdaf 100644\n--- a/dvc/utils/__init__.py\n+++ b/dvc/utils/__init__.py\n@@ -353,7 +353,9 @@ def resolve_paths(r... | [
{
"diff_hunk": "@@ -364,15 +366,18 @@ def resolve_paths(repo, out):\n if os.name == \"nt\" and scheme == abspath.drive[0].lower():\n # urlparse interprets windows drive letters as URL scheme\n scheme = \"\"\n- if (\n- not scheme\n- and abspath.isin_or_eq(repo.root_dir)\n- ... | c830aea2bff20e0ea907466ffa1171c4488e0265 | diff --git a/dvc/utils/__init__.py b/dvc/utils/__init__.py
index fc324211d8..fbf75637b5 100644
--- a/dvc/utils/__init__.py
+++ b/dvc/utils/__init__.py
@@ -353,7 +353,9 @@ def resolve_paths(repo, out):
from urllib.parse import urlparse
from ..dvcfile import DVC_FILE_SUFFIX
+ from ..exceptions import DvcEx... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
iterative__dvc-4801@2187878 | iterative/dvc | Python | 4,801 | add: warn on cache link errors instead of failing | * [x] ❗ I have followed the [Contributing to DVC](https://dvc.org/doc/user-guide/contributing/core) checklist.
* [x] 📖 If this PR requires [documentation](https://dvc.org/doc) updates, I have created a separate PR (or issue, at least) in [dvc.org](https://github.com/iterative/dvc.org) and linked it here.
Thank y... | 2020-10-29T03:34:07Z | dvc add deletes file when cache type fails on Windows
### Setup
* Windows client, where support for symlinks clearly didn't get applied. This has happened on all our Windows machines. It may have something to do with the way our corporate IT has set up Windows.
* Shared dvc cache on a samba mount. Samba server happen... | So in this case what's probably happening is that technically the data is not lost since the files are properly moved into the cache (on your SMB share). However, due to our `cache.save` behavior we end up making it look like a loss of data because of the symlink failure (and we don't provide any useful information for... | [
{
"body": "### Setup\r\n* Windows client, where support for symlinks clearly didn't get applied. This has happened on all our Windows machines. It may have something to do with the way our corporate IT has set up Windows.\r\n* Shared dvc cache on a samba mount. Samba server happens to be 3000 miles away from cl... | 9b136f0c3f06575562dc740e45ae2927920346a0 | {
"head_commit": "218787809ddd6b43f2ebd1e2bb893564055e592f",
"head_commit_message": "add test case",
"patch_to_review": "diff --git a/dvc/cache/base.py b/dvc/cache/base.py\nindex 7d2509bc5d..5dca5a0963 100644\n--- a/dvc/cache/base.py\n+++ b/dvc/cache/base.py\n@@ -8,6 +8,7 @@\n \n import dvc.prompt as prompt\n fro... | [
{
"diff_hunk": "@@ -338,3 +338,18 @@ def __init__(self, target, file):\n \n class MergeError(DvcException):\n pass\n+\n+\n+class CacheLinkError(DvcException):\n+ SUPPORT_LINK = \"See {} for more information.\".format(\n+ format_link(\n+ \"https://dvc.org/doc/user-guide/\" \"troubleshoot... | b13f38cd96f940bd37949c9aa02dccf2972a5bbd | diff --git a/dvc/cache/base.py b/dvc/cache/base.py
index 7d2509bc5d..5dca5a0963 100644
--- a/dvc/cache/base.py
+++ b/dvc/cache/base.py
@@ -8,6 +8,7 @@
import dvc.prompt as prompt
from dvc.exceptions import (
+ CacheLinkError,
CheckoutError,
ConfirmRemoveError,
DvcException,
@@ -192,7 +193,7 @@ def... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
iterative__dvc-4536@b99299e | iterative/dvc | Python | 4,536 | Print dvc version info for debugging | fix #4095
1. separate info from DVC version.
2. print DVC version info when some unexpected error occurred.
* [x] ❗ I have followed the [Contributing to DVC](https://dvc.org/doc/user-guide/contributing/core) checklist.
* [ ] 📖 If this PR requires [documentation](https://dvc.org/doc) updates, I have created a s... | 2020-09-06T10:09:23Z | dvc: print `dvc version` to debug
That would be useful when researching error logs provided by users.
Could also consider including `dvc version` output into the "Having any troubles?" footer or, instead, asking to run that command again in `-v` mode. | Let's prioritize it? It's very simple to implement and can save a lot of time. | [
{
"body": "That would be useful when researching error logs provided by users.\r\n\r\nCould also consider including `dvc version` output into the \"Having any troubles?\" footer or, instead, asking to run that command again in `-v` mode.",
"number": 4095,
"title": "dvc: print `dvc version` to debug"
}... | 636a019289ffcde30c7d94b8516bccb3c65bf47c | {
"head_commit": "b99299e93778d6c299aad3842e7e475d0bc02cc2",
"head_commit_message": "Psutil NoneType error",
"patch_to_review": "diff --git a/dvc/command/version.py b/dvc/command/version.py\nindex aa37106c0e..3396e34437 100644\n--- a/dvc/command/version.py\n+++ b/dvc/command/version.py\n@@ -1,153 +1,18 @@\n impor... | [
{
"diff_hunk": "@@ -3,3 +3,8 @@\n from .build import PKG # noqa, pylint:disable=unused-import\n except ImportError:\n PKG = None\n+\n+if PKG is None:\n+ package = \"\"\n+else:\n+ package = f\"({PKG})\"",
"line": null,
"original_line": 10,
"original_start_line": 6,
"path": "dvc/uti... | 3666a8aa8ddd80036967826e987b94e7425b5e3d | diff --git a/dvc/command/version.py b/dvc/command/version.py
index aa37106c0e..3396e34437 100644
--- a/dvc/command/version.py
+++ b/dvc/command/version.py
@@ -1,153 +1,18 @@
import argparse
-import itertools
import logging
-import os
-import pathlib
-import platform
-import uuid
from dvc.command.base import CmdBas... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
home-assistant__core-126133@df7a8de | home-assistant/core | Python | 126,133 | Update Aseko to support new API | <!--
You are amazing! Thanks for contributing to our project!
Please, DO NOT DELETE ANY TEXT from this template! (unless instructed).
-->
## Breaking change
<!--
If your PR contains a breaking change for existing users, it is important
to tell them what breaks, how to make it work again and why we did th... | 2024-09-17T15:32:18Z | Add support for ASIN AQUA Home after major update.
### The problem
This morning Aseko Pool Live was update to a new platform and the old seems to have beem immediately shut down without any transition phase.
### What version of Home Assistant Core has the issue?
core-2024.9.1
### What was the last working version o... | Hey there @milanmeu, mind taking a look at this issue as it has been labeled with an integration (`aseko_pool_live`) you are listed as a [code owner](https://github.com/home-assistant/core/blob/dev/CODEOWNERS#L142) for? Thanks!
<details>
<summary>Code owner commands</summary>
Code owners of `aseko_pool_live` can tri... | [
{
"body": "### The problem\n\nThis morning Aseko Pool Live was update to a new platform and the old seems to have beem immediately shut down without any transition phase.\n\n### What version of Home Assistant Core has the issue?\n\ncore-2024.9.1\n\n### What was the last working version of Home Assistant Core?\n... | b262e1518fbea19679957dd5123977dc0ef864ac | {
"head_commit": "df7a8de59c974725a8dd2036a5b1e4c7695e181c",
"head_commit_message": "Update Aseko to support new API",
"patch_to_review": "diff --git a/homeassistant/components/aseko_pool_live/__init__.py b/homeassistant/components/aseko_pool_live/__init__.py\nindex 5773b3eb5b9137..a1d5d28913ac66 100644\n--- a/ho... | [
{
"diff_hunk": "@@ -55,33 +47,25 @@ async def async_setup_entry(\n async_add_entities: AddEntitiesCallback,\n ) -> None:\n \"\"\"Set up the Aseko Pool Live binary sensors.\"\"\"\n- data: list[tuple[Unit, AsekoDataUpdateCoordinator]] = hass.data[DOMAIN][\n+ data: tuple[str, AsekoDataUpdateCoordinat... | b7ab486cad5a93f7285fcc553b1c557c55b7f981 | diff --git a/homeassistant/components/aseko_pool_live/__init__.py b/homeassistant/components/aseko_pool_live/__init__.py
index 5773b3eb5b9137..5985af4d02346a 100644
--- a/homeassistant/components/aseko_pool_live/__init__.py
+++ b/homeassistant/components/aseko_pool_live/__init__.py
@@ -4,13 +4,12 @@
import logging
... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
iterative__dvc-4480@fe66013 | iterative/dvc | Python | 4,480 | s3: provide more helpful messages on common errors | Fix #4478
* [x] ❗ I have followed the [Contributing to DVC](https://dvc.org/doc/user-guide/contributing/core) checklist.
* [x] 📖 If this PR requires [documentation](https://dvc.org/doc) updates, I have created a separate PR (or issue, at least) in [dvc.org](https://github.com/iterative/dvc.org) and linked it her... | 2020-08-27T00:24:07Z | s3: better error on missing credentials
A colleague was recently onboarding to our dvc project and received this error:
```
$ dvc pull
ERROR: unexpected error - Unable to locate credentials
```
I believe that if this was a better error message, they may have figured it out on their own. It wasn't clear that the... | @colllin Thanks for the feedback! Indeed, we could just wrap that exception and present something nicer. Let me see, should be able to provide a quick fix... | [
{
"body": "A colleague was recently onboarding to our dvc project and received this error:\r\n```\r\n$ dvc pull\r\nERROR: unexpected error - Unable to locate credentials\r\n```\r\n\r\nI believe that if this was a better error message, they may have figured it out on their own. It wasn't clear that they were mi... | 334556f07dc511927543218d4a2a1a1c1c83ed65 | {
"head_commit": "fe660132a56a8b646a1c2db89b77ae571f0b9188",
"head_commit_message": "fix tests",
"patch_to_review": "diff --git a/dvc/config.py b/dvc/config.py\nindex 685be624e3..0f1bafac67 100644\n--- a/dvc/config.py\n+++ b/dvc/config.py\n@@ -162,7 +162,7 @@ class RelPath(str):\n \"endpointur... | [
{
"diff_hunk": "@@ -75,24 +72,49 @@ def s3(self):\n \n session = boto3.session.Session(**session_opts)\n \n- return session.client(\n+ return session.resource(\n \"s3\", endpoint_url=self.endpoint_url, use_ssl=self.use_ssl\n )\n \n- @classmethod\n- def get_etag(cl... | 8670abc31251547ebe54bc3321ad5bb91245633f | diff --git a/dvc/config.py b/dvc/config.py
index 685be624e3..0f1bafac67 100644
--- a/dvc/config.py
+++ b/dvc/config.py
@@ -162,7 +162,7 @@ class RelPath(str):
"endpointurl": str,
"access_key_id": str,
"secret_access_key": str,
- Optional(... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
iterative__dvc-4382@6c8246c | iterative/dvc | Python | 4,382 | ui: '-j' option now mentions docs | Fixes #1310
* [x] ❗ I have followed the [Contributing to DVC](https://dvc.org/doc/user-guide/contributing/core) checklist.
* [ ] 📖 If this PR requires [documentation](https://dvc.org/doc) updates, I have created a separate PR (or issue, at least) in [dvc.org](https://github.com/iterative/dvc.org) and linked it ... | 2020-08-12T18:15:02Z | Improve `-j` help messages
For example, `dvc gc -j N`. There are also other DVC commands that have this option.
`-j` specifies parallelism level for the command.
It should specify that default number depends on a remote type and that to get defaults one should refer to docs. | It now reads "Number of jobs to run simultaneously." Is that better?
And is this a `p3`?
@jorgeorpinel I think the idea was to include something like "Refer to docs to get default value that depends on the remote type" (better written).
1. As far as I understand default value depends not only on remote type but als... | [
{
"body": "For example, `dvc gc -j N`. There are also other DVC commands that have this option.\r\n\r\n`-j` specifies parallelism level for the command. \r\n\r\nIt should specify that default number depends on a remote type and that to get defaults one should refer to docs.",
"number": 1310,
"title": "I... | 64f038fda83c2400263b335fca6bb4f63f6ecf0f | {
"head_commit": "6c8246c7519bb127d2a4946b374d627df3535a22",
"head_commit_message": "ui: '-j' option now mentions docs",
"patch_to_review": "diff --git a/dvc/command/data_sync.py b/dvc/command/data_sync.py\nindex 5b931177ec..e00b411ab8 100644\n--- a/dvc/command/data_sync.py\n+++ b/dvc/command/data_sync.py\n@@ -97... | [
{
"diff_hunk": "@@ -97,7 +97,8 @@ def shared_parent_parser():\n \"-j\",\n \"--jobs\",\n type=int,\n- help=\"Number of jobs to run simultaneously.\",\n+ help=\"Number of jobs to run simultaneously. \"\n+ \"Refer to docs to get default value.\",",
"line": null,
... | f9dfe7ab06667c9bd3bf1e2109010036a1d756dd | diff --git a/dvc/command/data_sync.py b/dvc/command/data_sync.py
index 5b931177ec..a6f810c836 100644
--- a/dvc/command/data_sync.py
+++ b/dvc/command/data_sync.py
@@ -97,7 +97,11 @@ def shared_parent_parser():
"-j",
"--jobs",
type=int,
- help="Number of jobs to run simultaneously.",
+ ... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "Documentation Updates"
} |
iterative__dvc-4479@4d0b554 | iterative/dvc | Python | 4,479 | version: improve link type detection fall back | Create temporary file in cache dir. And use it to detect the supported cache types. Clear after cache type detection.
Fixes #2788 | 2020-08-26T18:04:40Z | version: improve link type detection fall back
**To reproduce:**
`dvc version` outside of any DVC repo.
**Output:**
```WARNING: Unable to detect supported link types, as cache directory '.dvc/cache' doesn't exist. It is usually auto-created by commands such as `dvc add/fetch/pull/run/import`, but you could cre... | @shcheklein , I couldn't reproduce the issue with the following script:
```bash
mkdir /tmp/example
cd /tmp/example
python3.7 -m venv .venv
source .venv/bin/activate
pip install dvc
dvc version
```
@ptrcklv , could you provide a reproduction script?
@mroutis me neither! And from the code perspective I don't... | [
{
"body": "**To reproduce:**\r\n\r\n`dvc version` outside of any DVC repo.\r\n\r\n**Output:**\r\n\r\n```WARNING: Unable to detect supported link types, as cache directory '.dvc/cache' doesn't exist. It is usually auto-created by commands such as `dvc add/fetch/pull/run/import`, but you could create it manually ... | 8a270329edee43864c4846fda6b3604362f62359 | {
"head_commit": "4d0b5545716726a8413cbfcf08127321cf2239e4",
"head_commit_message": "version: improve link type detection fall back\n\nIf failed to determine cache type print link to related web page.\n\nFixes #2788",
"patch_to_review": "diff --git a/dvc/command/version.py b/dvc/command/version.py\nindex 79452c6d... | [
{
"diff_hunk": "@@ -59,12 +59,8 @@ def run(self):\n fs_type = self.get_fs_type(repo.cache.local.cache_dir)\n info.append(f\"Cache directory: {fs_type}\")\n else:\n- logger.warning(\n- \"Unable to detect supported link types, a... | 0f9a48c8215aca0a8916da0ac507e2dec87e18d2 | diff --git a/dvc/command/version.py b/dvc/command/version.py
index 79452c6d33..aa37106c0e 100644
--- a/dvc/command/version.py
+++ b/dvc/command/version.py
@@ -10,7 +10,7 @@
from dvc.exceptions import DvcException, NotDvcRepoError
from dvc.scm.base import SCMError
from dvc.system import System
-from dvc.utils import ... | {
"difficulty": "medium",
"estimated_review_effort": 2,
"problem_domain": "Code Refactoring / Architectural Improvement"
} |
home-assistant__core-125765@891f82e | home-assistant/core | Python | 125,765 | Make acknowledge requests from LCN modules optional | <!--
You are amazing! Thanks for contributing to our project!
Please, DO NOT DELETE ANY TEXT from this template! (unless instructed).
-->
## Proposed change
LCN hardware modules offer the possibility to send acknowledge messages for each command, to ensure the command has been received. As the bandwidth of the... | 2024-09-11T16:20:32Z | dyn text leads to dimmable leds to spike
Hi there,
I'm using dyn.text service to display outside temperature taken from external service on lcn panels. Whenever 5 parts of the dyn text are reaching the bus then dimmable gu10 bulbs are spiking (those which are connected to UPP together with lcd panel). Any ideas how ... | I just took a brief look at the code.
https://github.com/alengwenus/pypck/blob/e0264103d46a49ed1a13117403c0187928252aba/pypck/module.py#L604
any reason for not breaking the loop here if **part** is empty?
```
text = " "
encoded_text = text.encode("utf-8")
parts = [encoded_text[12 * part : 12 * part + 12] for pa... | [
{
"body": "Hi there,\r\n\r\nI'm using dyn.text service to display outside temperature taken from external service on lcn panels. Whenever 5 parts of the dyn text are reaching the bus then dimmable gu10 bulbs are spiking (those which are connected to UPP together with lcd panel). Any ideas how to prevent this? \... | 6d212ea24e1a4aa24a55355a993290d38843e2e3 | {
"head_commit": "891f82ec1300ec9b1dd0cd274f45feee4078a4a6",
"head_commit_message": "Add data_description to strings.json",
"patch_to_review": "diff --git a/homeassistant/components/lcn/__init__.py b/homeassistant/components/lcn/__init__.py\nindex 96ffaddfb9356..a8d75fe56352a 100644\n--- a/homeassistant/component... | [
{
"diff_hunk": "@@ -125,3 +125,24 @@ async def test_async_setup_from_configuration_yaml(hass: HomeAssistant) -> None:\n await setup_component(hass)\n \n assert async_setup_entry.await_count == 2\n+\n+\n+@patch(\"homeassistant.components.lcn.PchkConnectionManager\", MockPchkConnectionManager)\n+a... | 3ccc476d2b377ddea69d42e75e75f938f5f5014f | diff --git a/homeassistant/components/lcn/__init__.py b/homeassistant/components/lcn/__init__.py
index 96ffaddfb93563..a8d75fe56352a2 100644
--- a/homeassistant/components/lcn/__init__.py
+++ b/homeassistant/components/lcn/__init__.py
@@ -22,6 +22,7 @@
from .const import (
ADD_ENTITIES_CALLBACKS,
+ CONF_ACKN... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
iterative__dvc-4224@e800d53 | iterative/dvc | Python | 4,224 | S3: Use key_id and key_secret directly | Fixes https://github.com/iterative/dvc/issues/4175
@efiop
| 2020-07-17T05:04:39Z | s3: provide a way to use key id and key secret directly
For now the only way to pass credentials to S3 is using credentials file and the env var. This is very inconvenient when trying to use dvc as a library. For now I hacked it like:
```python
def pull(repo):
# In memory config update to avoid validation
... | @Suor Have you considered changing the env for that call?
Also, I suppose your request is only about internal api, right?
Changing env for the process will leak it to other threads and also may leak to subsequent calls. Starting a new process is a solution, but a heavy one.
I am using `repo.cloud.pull()`, but `re... | [
{
"body": "For now the only way to pass credentials to S3 is using credentials file and the env var. This is very inconvenient when trying to use dvc as a library. For now I hacked it like:\r\n\r\n```python\r\ndef pull(repo):\r\n # In memory config update to avoid validation\r\n repo.config[\"core\"][\"re... | a56c8bbab662c3792ae12aa7db6c40a42a23de50 | {
"head_commit": "e800d534e806e4a2af877a003c823771c33b7fb7",
"head_commit_message": "remove redundant default\n\nCo-authored-by: Ruslan Kuprieiev <kupruser@gmail.com>",
"patch_to_review": "diff --git a/dvc/config.py b/dvc/config.py\nindex a43cb16f2f..058a698970 100644\n--- a/dvc/config.py\n+++ b/dvc/config.py\n@@... | [
{
"diff_hunk": "@@ -6,6 +6,8 @@\n bucket_name = \"bucket-name\"\n prefix = \"some/prefix\"\n url = f\"s3://{bucket_name}/{prefix}\"\n+key_id = \"key_id\"\n+key_secret = \"key_secret\"",
"line": null,
"original_line": 10,
"original_start_line": 9,
"path": "tests/unit/remote/test_s3.py",
"star... | 8d289eb31011c23c5f7cbd963b3b4249d3524821 | diff --git a/dvc/config.py b/dvc/config.py
index a43cb16f2f..193bb73321 100644
--- a/dvc/config.py
+++ b/dvc/config.py
@@ -149,6 +149,8 @@ class RelPath(str):
"profile": str,
"credentialpath": str,
"endpointurl": str,
+ "access_key_id": s... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
iterative__dvc-4166@a9e6783 | iterative/dvc | Python | 4,166 | Add more tests according to gitignore | fix #4103
* [x] ❗ I have followed the [Contributing to DVC](https://dvc.org/doc/user-guide/contributing/core) checklist.
* [x] 📖 If this PR requires [documentation](https://dvc.org/doc) updates, I have created a separate PR (or issue, at least) in [dvc.org](https://github.com/iterative/dvc.org) and linked it her... | 2020-07-04T07:07:26Z | .dvcignore is broken on negation when blacklisting all
## Bug Report
### Please provide information about your setup
I am not sure how far this extends to, but a lot of trials for `.dvcignore` failed when I blacklisted all and tried to whitelist some:
```
*
!scripts
```
```
*
!/scripts
```
```
/*
... | CC @pared is this expected?
Considering that we have been designing `.dvcignore` to comply with `.gitignore`, I will refer to original:
It seems to me that we have some disrepancies in behaviour between `git` and `dvc`. I prepared a script to illustrate that:
```
#!/bin/bash
rm -rf repo
mkdir repo
pushd repo
... | [
{
"body": "## Bug Report\r\n\r\n### Please provide information about your setup\r\n\r\nI am not sure how far this extends to, but a lot of trials for `.dvcignore` failed when I blacklisted all and tried to whitelist some:\r\n\r\n```\r\n*\r\n!scripts\r\n```\r\n\r\n```\r\n*\r\n!/scripts\r\n```\r\n\r\n```\r\n/*\r\... | 520e01f11305aba1994df354adef86e6d90180de | {
"head_commit": "a9e678353c5eea86da11a775c764735f50481b1a",
"head_commit_message": "Add one tests",
"patch_to_review": "diff --git a/dvc/ignore.py b/dvc/ignore.py\nindex c9257e5204..35d7ede2d4 100644\n--- a/dvc/ignore.py\n+++ b/dvc/ignore.py\n@@ -44,11 +44,11 @@ def __init__(self, ignore_file_path, tree):\n \n ... | [
{
"diff_hunk": "@@ -173,3 +173,58 @@ def test_ignore_blank_line(tmp_dir, dvc):\n tmp_dir.gen(DvcIgnore.DVCIGNORE_FILE, \"foo\\n\\ndir/ignored\")\n \n assert _files_set(\"dir\", dvc.tree) == {\"dir/other\"}\n+\n+\n+# It is not possible to re-include a file if a parent directory of\n+# that file is exclud... | 255faab11787be6cb8df40b6f8954e4d89024d57 | diff --git a/dvc/ignore.py b/dvc/ignore.py
index c9257e5204..35d7ede2d4 100644
--- a/dvc/ignore.py
+++ b/dvc/ignore.py
@@ -44,11 +44,11 @@ def __init__(self, ignore_file_path, tree):
def __call__(self, root, dirs, files):
files = [f for f in files if not self.matches(root, f)]
- dirs = [d for d i... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
home-assistant__core-124495@c2629b3 | home-assistant/core | Python | 124,495 | Fix device class for motion_light blueprint | Fixes #124353
<!--
You are amazing! Thanks for contributing to our project!
Please, DO NOT DELETE ANY TEXT from this template! (unless instructed).
-->
## Breaking change
<!--
If your PR contains a breaking change for existing users, it is important
to tell them what breaks, how to make it work again ... | 2024-08-23T15:37:09Z | Motion Light blueprint has wrong device_class
### The problem
The motion_light.yaml blueprint excludes all my motion sensors, as it uses device class motion. All my motion sensors are now in device class occupancy. Old automations use a device that I can no longer select.
Replace
```
device_class:
- motion... | Feel free to open a PR
Hey I would like to work on it! Some hint on where should I start.. | [
{
"body": "### The problem\n\nThe motion_light.yaml blueprint excludes all my motion sensors, as it uses device class motion. All my motion sensors are now in device class occupancy. Old automations use a device that I can no longer select. \r\n\r\nReplace \r\n\r\n```\r\ndevice_class:\r\n - motion\r\n```\r\nwi... | 106559371c111eb9746d87da5d9d1340a99a5229 | {
"head_commit": "c2629b34a71aa9be446b642facadef4383110617",
"head_commit_message": "Fix device class for motion_light blueprint.\nFixes #124353",
"patch_to_review": "diff --git a/homeassistant/components/automation/blueprints/motion_light.yaml b/homeassistant/components/automation/blueprints/motion_light.yaml\ni... | [
{
"diff_hunk": "@@ -10,7 +10,7 @@ blueprint:\n selector:\n entity:\n filter:\n- device_class: motion\n+ device_class: occupancy",
"line": null,
"original_line": 13,
"original_start_line": null,
"path": "homeassistant/components/automation/blueprints/... | a3f21842c79d539fdfa8e34772fd59d2c18df1a9 | diff --git a/homeassistant/components/automation/blueprints/motion_light.yaml b/homeassistant/components/automation/blueprints/motion_light.yaml
index 8f5d3f957f990a..ad9c6f0286b551 100644
--- a/homeassistant/components/automation/blueprints/motion_light.yaml
+++ b/homeassistant/components/automation/blueprints/motion_... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
iterative__dvc-4075@e89c537 | iterative/dvc | Python | 4,075 | add --no-exec mode to import url | fix #3513
* [x] ❗ I have followed the [Contributing to DVC](https://dvc.org/doc/user-guide/contributing/core) checklist.
* [x] 📖 If this PR requires [documentation](https://dvc.org/doc) updates, I have created a separate PR (or issue, at least) in [dvc.org](https://github.com/iterative/dvc.org) and linked it her... | 2020-06-20T02:43:19Z | Implement `--no-exec` option for `import-url` command
`dvc import-url` creates new `.dvc` file, just as `dvc run`. Sometimes files which would be imported are already present locally and it's quite inconvenient that they should be downloaded again in order to create a pipeline step.
Because of that it would be great... | Context: https://discordapp.com/channels/485586884165107732/485596304961962003/690194007816798243
taking a look | [
{
"body": "`dvc import-url` creates new `.dvc` file, just as `dvc run`. Sometimes files which would be imported are already present locally and it's quite inconvenient that they should be downloaded again in order to create a pipeline step.\r\n\r\nBecause of that it would be great to add `--no-exec` option: we ... | a2f1367a9a75849ef6ad7ee23a5bacc18580f102 | {
"head_commit": "e89c537493e3cc18176459663d7eec1e143f54f1",
"head_commit_message": "Merge remote-tracking branch 'origin/master' into fix3513",
"patch_to_review": "diff --git a/dvc/command/imp_url.py b/dvc/command/imp_url.py\nindex 18591891b0..aaed48a34a 100644\n--- a/dvc/command/imp_url.py\n+++ b/dvc/command/im... | [
{
"diff_hunk": "@@ -103,3 +103,12 @@ def test_import_stage_accompanies_target(tmp_dir, dvc, erepo_dir):\n def test_import_url_nonexistent(dvc, erepo_dir):\n with pytest.raises(DependencyDoesNotExistError):\n dvc.imp_url(os.fspath(erepo_dir / \"non-existent\"))\n+\n+\n+def test_import_url_with_no_exe... | 7b00da1a980f5017915e8ec519192058b94fad70 | diff --git a/dvc/command/imp_url.py b/dvc/command/imp_url.py
index 18591891b0..aaed48a34a 100644
--- a/dvc/command/imp_url.py
+++ b/dvc/command/imp_url.py
@@ -12,7 +12,10 @@ class CmdImportUrl(CmdBase):
def run(self):
try:
self.repo.imp_url(
- self.args.url, out=self.args.out, ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
iterative__dvc-4074@ef3501f | iterative/dvc | Python | 4,074 | remove: clean gitignore content | Fixes #4013
* [x] ❗ I have followed the [Contributing to DVC](https://dvc.org/doc/user-guide/contributing/core) checklist.
* [ ] 📖 If this PR requires [documentation](https://dvc.org/doc) updates, I have created a separate PR (or issue, at least) in [dvc.org](https://github.com/iterative/dvc.org) and linked it ... | 2020-06-19T15:36:30Z | dvc remove'd folder stays in gitignore
## Bug Report
### Please provide information about your setup
The removed folder's name is still in `.gitignore`. Not sure if that's intentional or not
**Output of `dvc version`:**
```console
$ dvc version
DVC version: 0.93.0
Python version: 3.7.5
Platform: Darwin-19... | Hi @ammarasmro !
Indeed, this is a bug on our side. The issue is that we just unprotect the outputs in https://github.com/iterative/dvc/blob/1.0.0a10/dvc/stage/__init__.py#L288 by default, but we really should also remove the output from the gitignore.
Thanks for the feedback!
Just a small suggestion. The first t... | [
{
"body": "## Bug Report\r\n\r\n### Please provide information about your setup\r\nThe removed folder's name is still in `.gitignore`. Not sure if that's intentional or not\r\n**Output of `dvc version`:**\r\n\r\n```console\r\n$ dvc version\r\n\r\nDVC version: 0.93.0\r\nPython version: 3.7.5\r\nPlatform: Darwin-... | 02b147b6f4a355271043548877b7ba8c0b8f42a2 | {
"head_commit": "ef3501f07b77a8fbc784ab1907cf063981a9698d",
"head_commit_message": "remove: refactor: using ignore_remove in remove",
"patch_to_review": "diff --git a/dvc/output/base.py b/dvc/output/base.py\nindex 37d30a210c..20f97842c5 100644\n--- a/dvc/output/base.py\n+++ b/dvc/output/base.py\n@@ -239,6 +239,1... | [
{
"diff_hunk": "@@ -337,7 +343,7 @@ def remove(self, ignore_remove=False):\n return\n \n if ignore_remove and self.use_scm_ignore:",
"line": null,
"original_line": 345,
"original_start_line": null,
"path": "dvc/output/base.py",
"start_line": null,
"text": "@user1:\n``... | fa3b36b38f2af199cbca306c73907e19dd3a4e44 | diff --git a/dvc/output/base.py b/dvc/output/base.py
index 37d30a210c..97edd60fa2 100644
--- a/dvc/output/base.py
+++ b/dvc/output/base.py
@@ -239,6 +239,12 @@ def ignore(self):
self.repo.scm.ignore(self.fspath)
+ def ignore_remove(self):
+ if not self.use_scm_ignore:
+ return
+
+ ... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
home-assistant__core-123489@f73f5f3 | home-assistant/core | Python | 123,489 | Add favorite position buttons to Motion Blinds | <!--
You are amazing! Thanks for contributing to our project!
Please, DO NOT DELETE ANY TEXT from this template! (unless instructed).
-->
## Breaking change
<!--
If your PR contains a breaking change for existing users, it is important
to tell them what breaks, how to make it work again and why we did th... | 2024-08-09T19:13:00Z | Favorite position function
Hi,
Sorry if this is not the right way to do this.
I use the motion-blinds intergration in Home-Assistant in combination with my Brel hub and rollerblinds.
In the brel application on my phone I can sent the command "favorite possition" and the blinds wil go to the present position. Just ... | @jrstaal I indeed did not add the option to go to the favorite possition (to HomeAssistant).
This because in HomeAssistant you can set the rollerblind to a specific position % using the `service: cover.set_cover_position`.
Therefore it is really easy to make a button in the frontend or as part of a automation or scri... | [
{
"body": "Hi,\r\n\r\nSorry if this is not the right way to do this.\r\nI use the motion-blinds intergration in Home-Assistant in combination with my Brel hub and rollerblinds.\r\nIn the brel application on my phone I can sent the command \"favorite possition\" and the blinds wil go to the present position. Jus... | ec9944b92ae41c503932bde0d40c3e8b6d6b9ed6 | {
"head_commit": "f73f5f3f53c63ae32812d5d5dbc8ce885bc062df",
"head_commit_message": "Merge remote-tracking branch 'upstream/dev' into motion_favorite",
"patch_to_review": "diff --git a/homeassistant/components/motion_blinds/button.py b/homeassistant/components/motion_blinds/button.py\nnew file mode 100644\nindex ... | [
{
"diff_hunk": "@@ -0,0 +1,66 @@\n+\"\"\"Support for Motionblinds button entity using their WLAN API.\"\"\"\n+\n+from __future__ import annotations\n+\n+from motionblinds.motion_blinds import LimitStatus\n+\n+from homeassistant.components.button import ButtonEntity\n+from homeassistant.config_entries import Con... | 76efd76a7b880058543c01ee7080cea6ff06e8df | diff --git a/homeassistant/components/motion_blinds/button.py b/homeassistant/components/motion_blinds/button.py
new file mode 100644
index 00000000000000..30f1cd53e6fa9e
--- /dev/null
+++ b/homeassistant/components/motion_blinds/button.py
@@ -0,0 +1,71 @@
+"""Support for Motionblinds button entity using their WLAN API... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
iterative__dvc-4018@2211865 | iterative/dvc | Python | 4,018 | tests: cover run cache with functional tests | Also, I tried to fix #4016, and also fix discrepancies in push/fetch counts.
* [x] ❗ I have followed the [Contributing to DVC](https://dvc.org/doc/user-guide/contributing/core) checklist.
* [x] 📖 If this PR requires [documentation](https://dvc.org/doc) updates, I have created a separate PR (or issue, at least) i... | 2020-06-11T10:51:47Z | run cache: push/pull is broken
## Bug Report
### Please provide information about your setup
#### Setup:
```console
cd $(mktemp -d)
mkdir {remote,repo}
cd repo
dvc init --no-scm
echo "foo" > foo
dvc run -n copy-foo-bar -d foo -o bar "cp foo bar"
dvc remote add -d remote ../remote
```
Output:
```conso... | Here's a test that I have been writing:
```python
def test_push_pull(tmp_dir, dvc, erepo_dir, run_copy, setup_remote):
tmp_dir.gen("foo", "foo")
run_copy("foo", "bar", name="copy-foo-bar")
url = setup_remote(dvc)
dvc.push(run_cache=True) # fails here already
setup_remote(erepo_dir.dvc, url)
... | [
{
"body": "## Bug Report\r\n\r\n### Please provide information about your setup\r\n\r\n#### Setup:\r\n```console\r\ncd $(mktemp -d)\r\nmkdir {remote,repo}\r\ncd repo\r\ndvc init --no-scm\r\necho \"foo\" > foo\r\ndvc run -n copy-foo-bar -d foo -o bar \"cp foo bar\"\r\ndvc remote add -d remote ../remote\r\n```\r\... | 87276faef2574dc4119f5fa6a079a81ea9f197f0 | {
"head_commit": "2211865fc37aebc97d8760d7babf2058d1bf00e8",
"head_commit_message": "tests: cover run cache with functional tests",
"patch_to_review": "diff --git a/dvc/repo/fetch.py b/dvc/repo/fetch.py\nindex dcab08ec47..fe3cd9c6f6 100644\n--- a/dvc/repo/fetch.py\n+++ b/dvc/repo/fetch.py\n@@ -72,7 +72,7 @@ def _... | [
{
"diff_hunk": "@@ -177,11 +177,15 @@ def _transfer(func, from_remote, to_remote):\n \n def push(self, remote):\n remote = self.repo.cloud.get_remote(remote)\n- return self._transfer(remote.upload, self.repo.cache.local, remote)\n+ return self._transfer(\n+ remote.tree.uploa... | 6ecf49286814f20cb1a0a4c98ecd7fa821bc1c83 | diff --git a/dvc/repo/fetch.py b/dvc/repo/fetch.py
index dcab08ec47..fe3cd9c6f6 100644
--- a/dvc/repo/fetch.py
+++ b/dvc/repo/fetch.py
@@ -72,7 +72,7 @@ def _fetch(
if failed:
raise DownloadError(failed)
- return downloaded
+ return downloaded + len(used_run_cache)
def _fetch_external(self, r... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
home-assistant__core-122101@c52577b | home-assistant/core | Python | 122,101 | Update wled to 0.19.2 | <!--
You are amazing! Thanks for contributing to our project!
Please, DO NOT DELETE ANY TEXT from this template! (unless instructed).
-->
## Breaking change
<!--
If your PR contains a breaking change for existing users, it is important
to tell them what breaks, how to make it work again and why we did th... | 2024-07-17T19:46:31Z | Cannot add WLED because it supposedly uses CCT
### The problem
When trying to add a new WLED integration I get an error message telling me "This WLED device uses CCT channels, which is not supported by this integration".
This is definitely not the case. I verified through the direct interface that the LED choice is... | Hey there @frenck, mind taking a look at this issue as it has been labeled with an integration (`wled`) you are listed as a [code owner](https://github.com/home-assistant/core/blob/dev/CODEOWNERS#L1445) for? Thanks!
<details>
<summary>Code owner commands</summary>
Code owners of `wled` can trigger bot actions by com... | [
{
"body": "### The problem\n\nWhen trying to add a new WLED integration I get an error message telling me \"This WLED device uses CCT channels, which is not supported by this integration\".\r\n\r\nThis is definitely not the case. I verified through the direct interface that the LED choice is WS281x with GRB col... | 55cee893924108b1817d54e28fcf45baefa72482 | {
"head_commit": "c52577b593a771ffe1d694866ba57d0811d8581f",
"head_commit_message": "Update wled to 0.19.2",
"patch_to_review": "diff --git a/homeassistant/components/wled/__init__.py b/homeassistant/components/wled/__init__.py\nindex ba87fb5812225..b483434769440 100644\n--- a/homeassistant/components/wled/__init... | [
{
"diff_hunk": "@@ -101,17 +109,40 @@ async def close_websocket(_: Event) -> None:\n async def _async_update_data(self) -> WLEDDevice:\n \"\"\"Fetch data from WLED.\"\"\"\n try:\n- device = await self.wled.update(full_update=not self.last_update_success)\n+ device = awa... | d820a517ee8a3187a7b2fc2ec0337b05bb960ceb | diff --git a/homeassistant/components/wled/__init__.py b/homeassistant/components/wled/__init__.py
index ba87fb5812225d..b4834347694403 100644
--- a/homeassistant/components/wled/__init__.py
+++ b/homeassistant/components/wled/__init__.py
@@ -5,9 +5,12 @@
from homeassistant.config_entries import ConfigEntry
from home... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
iterative__dvc-3794@505b69f | iterative/dvc | Python | 3,794 | Add a new rename command | fixed #3599
1. add new command `dvc remote rename <old> <new>`.
2. add tests for this new command.
* [x] ❗ I have followed the [Contributing to DVC](https://dvc.org/doc/user-guide/contributing/core) checklist.
* [x] 📖 If this PR requires [documentation](https://dvc.org/doc) updates, I have created a separate P... | 2020-05-13T14:06:51Z | remote modify: add `name` param?
So you can change the name of a remote e.g.
```console
$ dvc remote add myremote some/path
$ dvc remote list
myremote some/path
$ dvc remote modify myremote name supercoolremote
$ dvc remote list
supercoolremote some/path
```
The workaround rn is to just add the remote agai... | BTW if you actually run my example command to modify the inexistent `name` param, it gets written to .dvc/config, which causes an error output whenever you try to change the config later:
```
ERROR: configuration error - config file error:
extra keys not allowed @ data['remote']['myremote']['name']
```
You hav... | [
{
"body": "So you can change the name of a remote e.g.\r\n\r\n```console\r\n$ dvc remote add myremote some/path\r\n$ dvc remote list\r\nmyremote some/path\r\n$ dvc remote modify myremote name supercoolremote\r\n$ dvc remote list\r\nsupercoolremote some/path\r\n```\r\n\r\nThe workaround rn is to just add the rem... | d81b56978fd2206c6e7e7056ac18ab350cb9a6c8 | {
"head_commit": "505b69fd8b0c2150370a0c1740e4188514e9b271",
"head_commit_message": "fixed #3599\n\n1. add new command `dvc remote rename <old> <new>`.\n2. add tests for this new command.",
"patch_to_review": "diff --git a/dvc/command/remote.py b/dvc/command/remote.py\nindex c5f46a1a08..4afc66776a 100644\n--- a/d... | [
{
"diff_hunk": "@@ -108,6 +108,34 @@ def run(self):\n return 0\n \n \n+class CmdRemoteRename(CmdRemote):\n+ def run(self):\n+ conf = self.config.load_one(self.args.level)\n+ self._check_exists(conf)\n+\n+ all_config = self.config.load_config_to_level(\"all\")\n+ if self.ar... | 55a4320736cc60eb29b399dff175c11a9e2cb9d5 | diff --git a/dvc/command/remote.py b/dvc/command/remote.py
index c5f46a1a08..2dfaf80d7f 100644
--- a/dvc/command/remote.py
+++ b/dvc/command/remote.py
@@ -108,6 +108,35 @@ def run(self):
return 0
+class CmdRemoteRename(CmdRemote):
+ def _rename_default(self, conf):
+ if conf["core"].get("remote")... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
iterative__dvc-3760@c4a4ab6 | iterative/dvc | Python | 3,760 | update: --recursive flag | Fixes #3511
> * [x] 📖 If this PR requires [documentation](https://dvc.org/doc) updates, I have created a separate PR (or issue, at least) in [dvc.org](https://github.com/iterative/dvc.org) and linked it here. If the CLI API is changed, I have updated [tab completion scripts](https://github.com/iterative/dvc/tree/m... | 2020-05-07T17:23:44Z | update: add `-R, --recursive` flag
`dvc update -R/--recursive` should recursively find & update all DVC-files which are updateable (and be incompatible with `--rev`).
Allows replacing:
```
dvc update <long list of files> && dvc repro -P
```
with:
```
dvc update -R && dvc repro -P
``` | Let's not take `-a`, as we use it for `--all-branches` in othe rplaces already. Let's just use `--all` for now.
It'd be symmetrical with push/pull/add if we used `--recursive/-R` instead.
I'd like to implement it. May I?
في ثلاثاء، 5 مايو، 2020 في 1:05 م، كتب nik123 <notifications@github.com>:
> I'd like to implement ... | [
{
"body": "`dvc update -R/--recursive` should recursively find & update all DVC-files which are updateable (and be incompatible with `--rev`).\r\n\r\nAllows replacing:\r\n```\r\ndvc update <long list of files> && dvc repro -P\r\n```\r\nwith:\r\n```\r\ndvc update -R && dvc repro -P\r\n```",
"number": 3511,
... | fc42ca721c25bdd24875c999e37fb4f589ecd63c | {
"head_commit": "c4a4ab6d3b8a7e996854bb1dfccf4a8444e68c1b",
"head_commit_message": "refactor: applied isort changes to dvc/repo/update.py",
"patch_to_review": "diff --git a/dvc/command/update.py b/dvc/command/update.py\nindex c3ef60ec9c..718f08cdae 100644\n--- a/dvc/command/update.py\n+++ b/dvc/command/update.py... | [
{
"diff_hunk": "@@ -1,14 +1,20 @@\n+from ..dvcfile import Dvcfile\n from . import locked\n \n \n @locked\n-def update(self, target, rev=None):\n- from ..dvcfile import Dvcfile\n+def update(self, targets=None, rev=None, recursive=False):\n+ if not targets:\n+ stages = self.collect(targets, recursive... | 3b19d47e955468dc46b08a7fa0a397604c97df81 | diff --git a/dvc/command/update.py b/dvc/command/update.py
index c3ef60ec9c..718f08cdae 100644
--- a/dvc/command/update.py
+++ b/dvc/command/update.py
@@ -10,12 +10,15 @@
class CmdUpdate(CmdBase):
def run(self):
ret = 0
- for target in self.args.targets:
- try:
- self.rep... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
gradio-app__gradio-8200@3807ee2 | gradio-app/gradio | Python | 8,200 | Support custom components in gr.load | ## Description
Closes: #8124
## 🎯 PRs Should Target Issues
Before your create a PR, please check to see if there is [an existing issue](https://github.com/gradio-app/gradio/issues) for this change. If not, please create an issue before you create this PR, unless the fix is very small.
Not adhering to this... | 2024-05-02T19:38:20Z | [Custom Components] support custom components in gr.load
- [x] I have searched to see if a similar issue already exists.
**Is your feature request related to a problem? Please describe.**
I have a space with custom components, but `gr.load` is not working properly.
**Describe the solution you'd like**
Suppo... | Makes sense — could you link to the Space you are trying to load or provide us a quick repro?
> Makes sense — could you link to the Space you are trying to load or provide us a quick repro?
Reproduce repo: https://huggingface.co/spaces/Coloring/gradio_load_test | [
{
"body": "- [x] I have searched to see if a similar issue already exists.\r\n\r\n**Is your feature request related to a problem? Please describe.** \r\nI have a space with custom components, but `gr.load` is not working properly.\r\n\r\n**Describe the solution you'd like** \r\nSupport custom components in `g... | 5671ff129a3ad488b307f71fffe9566bd4f7f52a | {
"head_commit": "3807ee28f835ae459b3375c6cc2f16eb03716d51",
"head_commit_message": "Fix tests",
"patch_to_review": "diff --git a/.changeset/fuzzy-mirrors-scream.md b/.changeset/fuzzy-mirrors-scream.md\nnew file mode 100644\nindex 0000000000..e38fd74e6f\n--- /dev/null\n+++ b/.changeset/fuzzy-mirrors-scream.md\n@@... | [
{
"diff_hunk": "@@ -0,0 +1,23 @@\n+---\n+\"gradio\": feat",
"line": null,
"original_line": 2,
"original_start_line": null,
"path": ".changeset/fuzzy-mirrors-scream.md",
"start_line": null,
"text": "@user1:\nis this supposed to be patch?\r\n```suggestion\r\n\"gradio\": patch\r\n```"
},
... | 57039896c6ae2b3352310f0296d5e47385387394 | diff --git a/.changeset/fuzzy-mirrors-scream.md b/.changeset/fuzzy-mirrors-scream.md
new file mode 100644
index 0000000000..62538b52ff
--- /dev/null
+++ b/.changeset/fuzzy-mirrors-scream.md
@@ -0,0 +1,25 @@
+---
+"gradio": patch
+"gradio_client": patch
+---
+
+highlight:
+
+#### Support custom components in gr.load
+
+... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
iterative__dvc-3702@0db3e68 | iterative/dvc | Python | 3,702 | setup: relax python-dateutil pip version constraint to include v2.8.2. #3701 | [WIP]. Attempt to relax upper constraints on the version of python-dateutil, to include 2.8.1 and 2.8.2.
The original constraint was:
"python-dateutil<2.8.1,>=2.1", # Consolidates azure-blob-storage and boto3
Requesting to do a CI run, see if new version constraint still works.
Fixes #3701 | 2020-04-29T18:43:03Z | Relax pip dependency versions constraints for python-dateutil
Description of the problem:
ERROR: dvc 0.93.0 has requirement python-dateutil **<2.8.1** ,>=2.1, but you'll have python-dateutil 2.8.1 which is incompatible.
It'd be good to remove or relax upper constraints on python-dateutil, to include 2.8.1 and 2.8.2... | Hi @dchichkov !
Mind submitting a PR to remove it? https://github.com/iterative/dvc/blob/master/setup.py#L50 It is an old sync requirement that is probably no longer needed. We'll see in the PR CI tests. | [
{
"body": "Description of the problem:\r\nERROR: dvc 0.93.0 has requirement python-dateutil **<2.8.1** ,>=2.1, but you'll have python-dateutil 2.8.1 which is incompatible.\r\n\r\nIt'd be good to remove or relax upper constraints on python-dateutil, to include 2.8.1 and 2.8.2. Is there a good reason why these a... | 907853b98598094caef4d0c45c4f0f54573af6e4 | {
"head_commit": "0db3e68e1ad71fe988ab452c5a7302c79b5706ad",
"head_commit_message": "Relax python-dateutil pip version constraint to include v2.8.2. #3701\n\n[WIP]. Attempt to relax upper constraints on the version of python-dateutil, to include 2.8.1 and 2.8.2. \r\n\r\nOriginal constraint was:\r\n \"python-dat... | [
{
"diff_hunk": "@@ -47,7 +47,7 @@ def run(self):\n \n \n install_requires = [\n- \"python-dateutil<2.8.1,>=2.1\", # Consolidates azure-blob-storage and boto3\n+ \"python-dateutil<=2.8.2,>=2.1\", # Consolidates azure-blob-storage and boto3",
"line": null,
"original_line": 50,
"original_start_... | ea3930b9d01f55e19e0a9c6246b8ba43f47a838f | diff --git a/setup.py b/setup.py
index 27da6e4b1c..a77f5b767d 100644
--- a/setup.py
+++ b/setup.py
@@ -47,7 +47,6 @@ def run(self):
install_requires = [
- "python-dateutil<2.8.1,>=2.1", # Consolidates azure-blob-storage and boto3
"ply>=3.9", # See https://github.com/pyinstaller/pyinstaller/issues/1945
... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "Dependency Updates & Env Compatibility"
} |
gradio-app__gradio-8197@863247f | gradio-app/gradio | Python | 8,197 | Add support for passing keyword args to `data` in JS client | ## Description
This PR adds support for passing keyword arguments as well as positional args to the `data` param in the JS client. This is backwards compatible, so the two usages will work:
```
const result = await app.predict("/predict", ["Chewbacca"]);
```
```
const result = await app.predict("/predict", { ... | 2024-05-02T13:08:01Z | Add support for key-word arguments in JS client
This is already supported in the Python Client, e.g.
```py
from gradio_client import Client, file
client = Client("abidlabs/whisper")
client.predict(
audio=file("audio_sample.wav")
)
```
```
>> "This is a test of the whisper speech recognition model."
... | [
{
"body": "This is already supported in the Python Client, e.g.\r\n\r\n```py\r\nfrom gradio_client import Client, file\r\n\r\nclient = Client(\"abidlabs/whisper\")\r\n\r\nclient.predict(\r\n audio=file(\"audio_sample.wav\")\r\n)\r\n```\r\n```\r\n>> \"This is a test of the whisper speech recognition model.\"\... | d62a48b18311b458372ff017aed9aecdcd478f51 | {
"head_commit": "863247f4065b6f07c509fbd73404db3abde904bb",
"head_commit_message": "Merge branch 'main' into js-client-kwargs",
"patch_to_review": "diff --git a/.changeset/sad-sides-sing.md b/.changeset/sad-sides-sing.md\nnew file mode 100644\nindex 0000000000..57a48a313b\n--- /dev/null\n+++ b/.changeset/sad-sid... | [
{
"diff_hunk": "@@ -298,3 +298,72 @@ export function handle_message(\n \n \treturn { type: \"none\", status: { stage: \"error\", queue } };\n }\n+\n+/**\n+ * Maps the provided `data` to the parameters defined by the `/info` endpoint response.\n+ * This allows us to support both positional and keyword arguments ... | bdd46e939181c30b67e55df1ce696932ab662b19 | diff --git a/.changeset/sad-sides-sing.md b/.changeset/sad-sides-sing.md
new file mode 100644
index 0000000000..57a48a313b
--- /dev/null
+++ b/.changeset/sad-sides-sing.md
@@ -0,0 +1,7 @@
+---
+"@gradio/app": minor
+"@gradio/client": minor
+"gradio": minor
+---
+
+feat:Add support for passing keyword args to `data` in ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
iterative__dvc-3562@5bea0d0 | iterative/dvc | Python | 3,562 | remote: ADD sock attribute and pass it to SSHConnection constructor | The sock attribute is set to a `paramiko.ProxyCommand` object
if 'ProxyCommand' exists in config to `None` other-wise
(which is the default option in `paramiko.client.SSHClient.connect()`).
FIXES #3560
No tests added, but passes all current tests.
* [x] ❗ I have followed the [Contributing to DVC](https://dvc.o... | 2020-03-31T14:05:54Z | ssh remote: Pass `ProxyCommand` to paramiko
If you want to set a ssh remote to a private server you should be able to do so by doing a proxy jump using the `ProxyCommand` option in your ssh config file, e.g:
```
Host <ON-PREMISES-SERVER>
User <USER>
ProxyCommand ssh -W %h:%p <PUBLIC-SERVER>
Host ... | Discord context https://discordapp.com/channels/485586884165107732/485596304961962003/694489311164235854 | [
{
"body": "If you want to set a ssh remote to a private server you should be able to do so by doing a proxy jump using the `ProxyCommand` option in your ssh config file, e.g:\r\n```\r\nHost <ON-PREMISES-SERVER>\r\n User <USER>\r\n ProxyCommand ssh -W %h:%p <PUBLIC-SERVER>\r\n\r\nHost <PUBLIC-SERVE... | d2ea180a9a5dea34bcf93382aaa0a4d5b34922d5 | {
"head_commit": "5bea0d033567587162a82ab2389a16da4c76f04e",
"head_commit_message": "remote: ADD sock attribute and pass it to SSHConnection constructor\n\nThe sock attribute is set to a `paramiko.ProxyCommand` object\nif 'ProxyCommand' exists in config to `None` other-wise\n(which is the default option in `paramik... | [
{
"diff_hunk": "@@ -10,6 +10,7 @@\n from urllib.parse import urlparse\n \n from funcy import memoize, wrap_with, silent, first\n+import paramiko",
"line": null,
"original_line": 13,
"original_start_line": null,
"path": "dvc/remote/ssh/__init__.py",
"start_line": null,
"text": "@user1:\nL... | dd7eb230184f0616d0db9cc94283e575e7229254 | diff --git a/dvc/remote/ssh/__init__.py b/dvc/remote/ssh/__init__.py
index 703617b2af..ee4ad891cd 100644
--- a/dvc/remote/ssh/__init__.py
+++ b/dvc/remote/ssh/__init__.py
@@ -85,6 +85,13 @@ def __init__(self, repo, config):
self.password = config.get("password", None)
self.ask_password = config.get("a... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
home-assistant__core-121178@b09b3b5 | home-assistant/core | Python | 121,178 | Fix `pulse counter frequency` sensors for Shelly Plus Uni | <!--
You are amazing! Thanks for contributing to our project!
Please, DO NOT DELETE ANY TEXT from this template! (unless instructed).
-->
## Breaking change
<!--
If your PR contains a breaking change for existing users, it is important
to tell them what breaks, how to make it work again and why we did th... | 2024-07-04T08:48:48Z | Shelly PlusUni Output switches lose connection after Core Update 2024.7.0
### The problem
I have a Shelly Plus Uni that I use its Outputs for to open the door of my apartment building every day.
Right after todays core update to 2024.7.0 the Outputs can be toggled on, but not toggled off, as they become unavailable... | Hey there @balloob, @bieniu, @thecode, @chemelli74, @bdraco, mind taking a look at this issue as it has been labeled with an integration (`shelly`) you are listed as a [code owner](https://github.com/home-assistant/core/blob/dev/CODEOWNERS#L1263) for? Thanks!
<details>
<summary>Code owner commands</summary>
Code own... | [
{
"body": "### The problem\n\nI have a Shelly Plus Uni that I use its Outputs for to open the door of my apartment building every day.\r\n\r\nRight after todays core update to 2024.7.0 the Outputs can be toggled on, but not toggled off, as they become unavailable right after turning them on.\r\n\r\nReverting ba... | 869f24df4978f43fd53dab16201a56da79ecb6bc | {
"head_commit": "b09b3b556ef3b0bca9dd963c50b0ea13707e17d0",
"head_commit_message": "Fix Pulse counter frequency sensors for Shelly Uni",
"patch_to_review": "diff --git a/homeassistant/components/shelly/sensor.py b/homeassistant/components/shelly/sensor.py\nindex 743c7c7ff01e3..b41cb090b9827 100644\n--- a/homeass... | [
{
"diff_hunk": "@@ -991,20 +991,18 @@ class RestSensorDescription(RestEntityDescription, SensorEntityDescription):\n ),\n \"counter_frequency\": RpcSensorDescription(\n key=\"input\",\n- sub_key=\"counts\",\n+ sub_key=\"freq\",\n name=\"Pulse counter frequency\",\n ... | b2a36defb543c6c179b4063256b871c71c4835d3 | diff --git a/homeassistant/components/shelly/sensor.py b/homeassistant/components/shelly/sensor.py
index 743c7c7ff01e30..5a6f03fd90c8c1 100644
--- a/homeassistant/components/shelly/sensor.py
+++ b/homeassistant/components/shelly/sensor.py
@@ -960,14 +960,18 @@ class RestSensorDescription(RestEntityDescription, SensorEn... | {
"difficulty": "medium",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
iterative__dvc-3650@cea9229 | iterative/dvc | Python | 3,650 | metrics diff error message in --no-scm projects | * [x] ❗ I have followed the [Contributing to DVC](https://dvc.org/doc/user-guide/contributing/core) checklist.
* [x] 📖 If this PR requires [documentation](https://dvc.org/doc) updates, I have created a separate PR (or issue, at least) in [dvc.org](https://github.com/iterative/dvc.org) and linked it here. If the CLI... | 2020-04-19T03:34:15Z | metrics diff: cryptic error in --no-scm projects [qa]
```console
λ dvc version
DVC version: 0.92.0
Python version: 3.7.5
Platform: Windows-10-10.0.18362-SP0
Binary: True
Package: exe
λ dvc metrics diff
ERROR: unexpected error - 'NoSCM' object has no attribute 'resolve_rev'
```
Run in a --no-scm DVC projec... | [
{
"body": "```console\r\nλ dvc version\r\nDVC version: 0.92.0\r\nPython version: 3.7.5\r\nPlatform: Windows-10-10.0.18362-SP0\r\nBinary: True\r\nPackage: exe\r\n\r\nλ dvc metrics diff\r\nERROR: unexpected error - 'NoSCM' object has no attribute 'resolve_rev'\r\n```\r\n\r\nRun in a --no-scm DVC project. Compare ... | 224b0fc2ce4cdf761cf879ae9e69d4c9e658fff6 | {
"head_commit": "cea9229bdf9f4af640a7e89dd824da7f4db3df89",
"head_commit_message": "Updated error msg",
"patch_to_review": "diff --git a/dvc/repo/brancher.py b/dvc/repo/brancher.py\nindex 67a3b19b36..702ed9dc97 100644\n--- a/dvc/repo/brancher.py\n+++ b/dvc/repo/brancher.py\n@@ -1,6 +1,7 @@\n from funcy import gr... | [
{
"diff_hunk": "@@ -24,6 +24,16 @@ class RevError(SCMError):\n pass\n \n \n+class NOSCMError(SCMError):\n+ def __init__(self):\n+ msg = (\n+ \"only supported for Git repositories. If you had\\n already \"\n+ \"initialized a git repo, this may be caused by dvc configuration. \... | 55d451b2d7c2ba2190f956bad8f8acb5f76f648b | diff --git a/dvc/repo/diff.py b/dvc/repo/diff.py
index d18389e05c..5a83ed8008 100644
--- a/dvc/repo/diff.py
+++ b/dvc/repo/diff.py
@@ -1,8 +1,6 @@
import os
-from dvc.exceptions import DvcException
from dvc.repo import locked
-from dvc.scm.git import Git
from dvc.scm.tree import is_working_tree
@@ -15,8 +13,6 ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
iterative__dvc-3428@b8cf72c | iterative/dvc | Python | 3,428 | add: do not verify hardlink if file is empty | Fixes #3390
* [x] ❗ Have you followed the guidelines in the [Contributing to DVC](https://dvc.org/doc/user-guide/contributing/core) list?
* [x] 📖 Check this box if this PR **does not** require [documentation](https://dvc.org/doc) updates, or if it does **and** you have created a separate PR in [dvc.org](https://... | 2020-03-02T07:26:34Z | add: empty files add broken when cache mode is hardlinks
## DVC Version
```
DVC version: 0.86.5+f67314.mod
Python version: 3.7.6
Platform: Darwin-18.2.0-x86_64-i386-64bit
Binary: False
Package: None
Cache: reflink - supported, hardlink - supported, symlink - supported
Filesystem type (cache directory): ('ap... | Found the root cause of this. This happens because of the optimization that we do if the file is empty (i.e. 0 bytes size). We never create a hardlink for the file with 0 bytes size and therefore it fails when we try to verify if the hardlink was created.
https://github.com/iterative/dvc/blob/a9bc65ee1f0446de766db59... | [
{
"body": "## DVC Version\r\n\r\n\r\n```\r\nDVC version: 0.86.5+f67314.mod\r\nPython version: 3.7.6\r\nPlatform: Darwin-18.2.0-x86_64-i386-64bit\r\nBinary: False\r\nPackage: None\r\nCache: reflink - supported, hardlink - supported, symlink - supported\r\nFilesystem type (cache directory): ('apfs', '/dev/disk1s1... | ea981ae955c1212eaed52dc84f225731bc516785 | {
"head_commit": "b8cf72cd0db0b1077dfd122717645ea5a1935739",
"head_commit_message": "add: do not verify hardlink if file is empty\n\nFixes #3390",
"patch_to_review": "diff --git a/dvc/remote/local.py b/dvc/remote/local.py\nindex 24725c526d..3e62e0628e 100644\n--- a/dvc/remote/local.py\n+++ b/dvc/remote/local.py\n... | [
{
"diff_hunk": "@@ -662,3 +662,39 @@ def test_not_raises_on_re_add(tmp_dir, dvc):\n \n tmp_dir.gen({\"file2\": \"file2 content\", \"file\": \"modified file\"})\n dvc.add([\"file2\", \"file\"])\n+\n+\n+@pytest.mark.parametrize(\"link\", [\"hardlink\", \"symlink\", \"copy\"])\n+def test_add_empty_files(tm... | c0c2793cd3d12cf43f3f21fe6d176ffb1b08319e | diff --git a/dvc/remote/local.py b/dvc/remote/local.py
index 24725c526d..3e62e0628e 100644
--- a/dvc/remote/local.py
+++ b/dvc/remote/local.py
@@ -92,6 +92,12 @@ def already_cached(self, path_info):
return not self.changed_cache(current_md5)
+ def _verify_link(self, path_info, link_type):
+ if li... | {
"difficulty": "low",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
gradio-app__gradio-7518@b447184 | gradio-app/gradio | Python | 7,518 | Adds a `gr.DownloadButton` component | After https://github.com/gradio-app/gradio/pull/7528, I wanted to go through the process of creating a new component with the new approach of working with the files, i.e. setting the URLs in the backend using `serve_static_file()` to mimic the work that a custom component developer would have to do.
I decided to add... | 2024-02-23T02:54:23Z | a `gr.DownloadButton` that lets you download a file with a button click
- [x] I have searched to see if a similar issue already exists.
**Is your feature request related to a problem? Please describe.**
Is possible to directly download file with a button click, rather using the `gr.File` component. Directly dow... | Hi @hyer we don't have a `gr.DownloadButton` component -- we could create a component like this in the future. The other possibility would be to use the `link` attribute of the `gr.Button()` to point to the filepath. Something like this:
```py
import gradio as gr
with gr.Blocks() as demo:
gr.Button(link="/f... | [
{
"body": "- [x] I have searched to see if a similar issue already exists.\r\n\r\n\r\n**Is your feature request related to a problem? Please describe.** \r\nIs possible to directly download file with a button click, rather using the `gr.File` component. Directly download will be more intuitive, and using the g... | 65f114a117b351f5935424fa78c830a58bafc44f | {
"head_commit": "b447184fd6a03f2ba9f6172f165769a90a9dc34f",
"head_commit_message": "notebooks",
"patch_to_review": "diff --git a/.changeset/weak-ducks-clean.md b/.changeset/weak-ducks-clean.md\nnew file mode 100644\nindex 0000000000..7d88fba8a4\n--- /dev/null\n+++ b/.changeset/weak-ducks-clean.md\n@@ -0,0 +1,8 @... | [
{
"diff_hunk": "",
"line": null,
"original_line": null,
"original_start_line": null,
"path": "demo/fake_gan/files/cheetah1.jpg",
"start_line": null,
"text": "@author:\nUnused file"
}
] | 3a94fad9a48b48e38312c9aba9b46018079d392e | diff --git a/.changeset/weak-ducks-clean.md b/.changeset/weak-ducks-clean.md
new file mode 100644
index 0000000000..7d88fba8a4
--- /dev/null
+++ b/.changeset/weak-ducks-clean.md
@@ -0,0 +1,8 @@
+---
+"@gradio/app": minor
+"@gradio/downloadbutton": minor
+"@gradio/uploadbutton": minor
+"gradio": minor
+---
+
+feat:Adds ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
gradio-app__gradio-7909@1912a8d | gradio-app/gradio | Python | 7,909 | Add `max_file_size` parameter to `launch()` that limits the size of files that can be uploaded in the Gradio app | ## Description
Closes: #7825
Closes: #6700
`max_file_size` is a block level component set in launch.
Developers can set this parameter as an int (like `1024` to specify 1 kb or as a string like "1kb"). Validation happens before the file is uploaded both for the app and the python client. The `upload` route w... | 2024-04-01T22:02:02Z | Allow users to close error tag and get back to the component
- [x] I have searched to see if a similar issue already exists.
**Is your feature request related to a problem? Please describe.**
Sometimes the same component is an input and an output. If something errors out, the component gets in a state of error an... | Minimal reproduction
```py
import gradio as gr
def crop_image(image):
#Simulate error with cropping or the uploaded image
raise gr.Error("Test")
with gr.Blocks() as demo:
image = gr.Image(label="Name")
image.upload(fn=crop_image, inputs=image, outputs=image)
if __name__ == "__main__":
... | [
{
"body": "- [x] I have searched to see if a similar issue already exists.\r\n\r\n**Is your feature request related to a problem? Please describe.** \r\nSometimes the same component is an input and an output. If something errors out, the component gets in a state of error and you can't fix it because it was al... | 72f4ca88ab569aae47941b3fb0609e57f2e13a27 | {
"head_commit": "1912a8d925fc434f91d0dd74e6f564d38ade4ed6",
"head_commit_message": "Fix i18n in storybook",
"patch_to_review": "diff --git a/.changeset/tiny-cars-spend.md b/.changeset/tiny-cars-spend.md\nnew file mode 100644\nindex 0000000000..5ae1213e0d\n--- /dev/null\n+++ b/.changeset/tiny-cars-spend.md\n@@ -0... | [
{
"diff_hunk": "@@ -452,6 +455,21 @@\n \n \t$: set_status($loading_status);\n \n+\tfunction update_status(\n+\t\tid: int,",
"line": null,
"original_line": 459,
"original_start_line": null,
"path": "js/app/src/Blocks.svelte",
"start_line": null,
"text": "@user1:\nNo `int` type in javascri... | 0fead3854e4aca130a782826dceaaa8cbf075764 | diff --git a/.changeset/tiny-cars-spend.md b/.changeset/tiny-cars-spend.md
new file mode 100644
index 0000000000..5ae1213e0d
--- /dev/null
+++ b/.changeset/tiny-cars-spend.md
@@ -0,0 +1,68 @@
+---
+"@gradio/app": minor
+"@gradio/audio": minor
+"@gradio/chatbot": minor
+"@gradio/checkbox": minor
+"@gradio/checkboxgroup"... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
iterative__dvc-3401@839fbcb | iterative/dvc | Python | 3,401 | checkout: show summary by default and introduce --show-changes flag | * [x] ❗ Have you followed the guidelines in the [Contributing to DVC](https://dvc.org/doc/user-guide/contributing/core) list?
* [x] 📖 Check this box if this PR **does not** require [documentation](https://dvc.org/doc) updates, or if it does **and** you have created a separate PR in [dvc.org](https://github.com/iter... | 2020-02-25T11:44:30Z | checkout/add: change warning messages to regular/info if behavior is expected
```
$ dvc -V
0.75.0
```
```
$ dvc checkout
WARNING: data 'newfile.txt' exists. Removing before checkout.
WARNING: data 'ttt.txt' exists. Removing before checkout.
```
EDITED 12/18/19: The message is actually wrong! The files were... | I think it's a duplicate of this https://github.com/iterative/dvc/issues/2329 ?
Also, yet another evidence (as many others) that loggers are not meant to be used as a mechanism to built UI/UX on top - https://github.com/iterative/dvc/issues/1930. In this specific case, for example, the priority is already set to INF... | [
{
"body": "```\r\n$ dvc -V\r\n0.75.0\r\n```\r\n\r\n```\r\n$ dvc checkout\r\nWARNING: data 'newfile.txt' exists. Removing before checkout.\r\nWARNING: data 'ttt.txt' exists. Removing before checkout.\r\n```\r\n\r\nEDITED 12/18/19: The message is actually wrong! The files were not removed - they were replaced by ... | 7f94518008fe2004ecd4d5f23300e8e16249cd59 | {
"head_commit": "839fbcb022c18f1dad1df7de28484f1f9906a2b7",
"head_commit_message": "checkout: implement --show-changes flag to show detailed checkout details\nShow summary by default on checkout\n\ncheckout: show directory modified even when files are removed from inside it\n\ncheckout: refactor template logic\n\n... | [
{
"diff_hunk": "@@ -1,18 +1,94 @@\n import argparse\n+import logging\n+\n+import colorama\n \n from dvc.command.base import append_doc_link\n from dvc.command.base import CmdBase\n+from dvc.exceptions import CheckoutError\n+\n+logger = logging.getLogger(__name__)\n+\n+\n+def _human_join(words=None):",
"line... | b80a44b8035af5153e81c55d348c1d1a9eb9ba5f | diff --git a/dvc/command/checkout.py b/dvc/command/checkout.py
index 0e2a533ec5..323e349977 100644
--- a/dvc/command/checkout.py
+++ b/dvc/command/checkout.py
@@ -1,18 +1,86 @@
import argparse
+import logging
+
+import colorama
from dvc.command.base import append_doc_link
from dvc.command.base import CmdBase
+from... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
gradio-app__gradio-7783@fd81627 | gradio-app/gradio | Python | 7,783 | Fix accidental bug that prevented custom textboxes from being passed to chatinterface | ## Description
Closes: #7781
## 🎯 PRs Should Target Issues
Before your create a PR, please check to see if there is [an existing issue](https://github.com/gradio-app/gradio/issues) for this change. If not, please create an issue before you create this PR, unless the fix is very small.
Not adhering to this... | 2024-03-21T15:37:25Z | Gradio gr.TextBox customization stopped working in gr.ChatInterface
### Describe the bug
The way to customize the textbox in gr.ChatInterface has stopped working since the new update.
The error I get is
```
Traceback (most recent call last):
File "Test", line 268, in <module>
c1 = gr.ChatInterface(chat,
... | Simple mistake @Rivridis - will have a fix soon | [
{
"body": "### Describe the bug\n\nThe way to customize the textbox in gr.ChatInterface has stopped working since the new update.\r\nThe error I get is\r\n```\r\nTraceback (most recent call last):\r\n File \"Test\", line 268, in <module>\r\n c1 = gr.ChatInterface(chat,\r\n ^^^^^^^^^^^^^^^^^^^^^^\r\n... | dd3e363261ae63823fb1672443ff2d31c63d656f | {
"head_commit": "fd816276b0692ac1dfbf3a6ce25cf3c95735004c",
"head_commit_message": "add changeset",
"patch_to_review": "diff --git a/.changeset/gold-suns-hang.md b/.changeset/gold-suns-hang.md\nnew file mode 100644\nindex 0000000000..01f196a48a\n--- /dev/null\n+++ b/.changeset/gold-suns-hang.md\n@@ -0,0 +1,5 @@\... | [
{
"diff_hunk": "@@ -206,7 +206,7 @@ def __init__(\n textbox.container = False\n textbox.show_label = False\n textbox_ = textbox.render()\n- if not isinstance(textbox_, Textbox) or not isinstance(\n+ ... | 44d9f0db66d13c76addd5b46013dbfd02c18f49d | diff --git a/.changeset/gold-suns-hang.md b/.changeset/gold-suns-hang.md
new file mode 100644
index 0000000000..01f196a48a
--- /dev/null
+++ b/.changeset/gold-suns-hang.md
@@ -0,0 +1,5 @@
+---
+"gradio": patch
+---
+
+fix:Fix accidental bug that prevented custom textboxes from being passed to chatinterface
diff --git a... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
iterative__dvc-3208@5dfcda5 | iterative/dvc | Python | 3,208 | tests: replace spy() with pytest-mock spy | After I'd started, @pared pointed out that it would be best to convert the tests to plain functions as opposed to classes, to better utilise the `mocker` fixture. I ended up having to create a bunch of wrappers just to use this fixture. Let me know if you'd like me to go ahead and convert all of the classes that were u... | 2020-01-21T14:49:37Z | Remove spy method
In some places, we use `tests/utils/spy` method to mock spied method so that we can observe how particular actions interact with the target method/function. Current implementation:
```
def spy(method_to_decorate):
mock = MagicMock()
def wrapper(self, *args, **kwargs):
mock(*args... | @pawel, there's a `mocker.spy` already: https://pypi.org/project/pytest-mock/
maybe we could move to that one?
@mroutis Thanks for pointing that out! Renaming the issue.
Hey there! I'm on this one :)
@fabiosantoscode
Sure, I just would like to note that most use cases of our spy are in UnitTest style tests, so remo... | [
{
"body": "In some places, we use `tests/utils/spy` method to mock spied method so that we can observe how particular actions interact with the target method/function. Current implementation:\r\n```\r\ndef spy(method_to_decorate):\r\n mock = MagicMock()\r\n\r\n def wrapper(self, *args, **kwargs):\r\n ... | 6958901d98c316340b46be08e959593f40129b8a | {
"head_commit": "5dfcda54f923a8994b47ec56c6a9f90eb69685e4",
"head_commit_message": "tests: replace spy() with pytest-mock spy\n\nFixes #3198",
"patch_to_review": "diff --git a/tests/func/test_add.py b/tests/func/test_add.py\nindex 1c885ead76..824fce4afd 100644\n--- a/tests/func/test_add.py\n+++ b/tests/func/test... | [
{
"diff_hunk": "@@ -245,9 +244,15 @@ def test_dir(self):\n self.assertEqual(ret, 0)\n \n \n-class TestShouldUpdateStateEntryForFileAfterAdd(TestDvc):\n+class TestDvcWithMocker(TestDvc):\n+ @pytest.fixture(autouse=True)\n+ def use_mocker(self, mocker):\n+ self.mocker = mocker\n+\n+\n+class T... | fc922661141c63f67986c7dd8d480cff3a12359c | diff --git a/tests/func/test_add.py b/tests/func/test_add.py
index 1c885ead76..cdd43f9cc3 100644
--- a/tests/func/test_add.py
+++ b/tests/func/test_add.py
@@ -9,7 +9,7 @@
import pytest
from mock import patch
-import dvc
+import dvc as dvc_module
from dvc.cache import Cache
from dvc.exceptions import DvcException
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Code Refactoring / Architectural Improvement"
} |
iterative__dvc-2866@5316336 | iterative/dvc | Python | 2,866 | remote: s3: adjust jobs number basing on file descriptors number | * [x] ❗ Have you followed the guidelines in the [Contributing to DVC](https://dvc.org/doc/user-guide/contributing/core) list?
* [ ] 📖 Check this box if this PR **does not** require [documentation](https://dvc.org/doc) updates, or if it does **and** you have created a separate PR in [dvc.org](https://github.com/iter... | 2019-11-29T08:20:36Z | 'Errno 24 - Too many open files' on dvc push
### Version information
* DVC version: 0.58.1
* Platform: MacOS 10.14.6
* Method of installation: pip within a conda environment
### Description
When pushing to S3 a directory of ~100 files that have been added to DVC, I observe an Errno 24 error from the dvc process.... | Hi @ChrisHowlin !
Thank you for reporting this! :slightly_smiling_face:
Could you post full log, please?
It is 100 files, right? Not 100K? Just making sure I understand you correctly. If it is 100, we might be leaking fds :slightly_frowning_face: Mind also trying dvc version 0.56.0, to see if that work? We've... | [
{
"body": "### Version information\r\n* DVC version: 0.58.1\r\n* Platform: MacOS 10.14.6\r\n* Method of installation: pip within a conda environment\r\n\r\n### Description\r\nWhen pushing to S3 a directory of ~100 files that have been added to DVC, I observe an Errno 24 error from the dvc process.\r\n\r\nIt loo... | bdfeba8f9be3de53ccb6a419099e84cf9e0969f8 | {
"head_commit": "53163366b6ca19b5bd4cc3aee636d027156a9052",
"head_commit_message": "remote: s3: revert jobs adjustment, pass OSError to main",
"patch_to_review": "diff --git a/dvc/main.py b/dvc/main.py\nindex 86e1a9e0df..0b4f95344a 100644\n--- a/dvc/main.py\n+++ b/dvc/main.py\n@@ -1,6 +1,7 @@\n \"\"\"Main entry ... | [
{
"diff_hunk": "@@ -64,6 +65,10 @@ def main(argv=None):\n \"unicode is not supported in DVC for Python 2 \"\n \"(end-of-life January 1, 2020), please upgrade to Python 3\"\n )\n+ elif isinstance(exc, OSError) and exc.errno == errno.EMFILE:\n+ logger.... | ab548470f8032d37e759aab8a120208bb442e336 | diff --git a/dvc/main.py b/dvc/main.py
index 86e1a9e0df..89c9dc775e 100644
--- a/dvc/main.py
+++ b/dvc/main.py
@@ -1,6 +1,7 @@
"""Main entry point for dvc CLI."""
from __future__ import unicode_literals
+import errno
import logging
from dvc import analytics
@@ -64,6 +65,10 @@ def main(argv=None):
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
home-assistant__core-118521@c1e72b2 | home-assistant/core | Python | 118,521 | Fix snmp doing blocking I/O in the event loop | ## Proposed change
<!--
Describe the big picture of your changes here to communicate to the
maintainers why we should accept this pull request. If it fixes a bug
or resolves a feature request, be sure to link to that issue in the
additional information section.
-->
Fix snmp doing blocking I/O in the even... | 2024-05-30T22:47:09Z | Detected blocking call to open with args ('/usr/local/lib/python3.12/site-packages/pysnmp/smi/mibs/instances/__SNMPv2-MIB.py', 'r')
### The problem
Since Home Assistant 2024.6.0b0, the below warnings appear. It is unclear to me which integration is causing this.
### What version of Home Assistant Core has the issue?
... | Looking at the name of the package I would guess `snmp`
Could be, but i've not installed the snmp integration.
Might have the same root cause as this one? https://github.com/home-assistant/core/issues/118424
Hey there @nmaggioni, mind taking a look at this issue as it has been labeled with an integration (`snmp`) you ... | [
{
"body": "### The problem\n\nSince Home Assistant 2024.6.0b0, the below warnings appear. It is unclear to me which integration is causing this.\n\n### What version of Home Assistant Core has the issue?\n\ncore-2024.6.0b0\n\n### What was the last working version of Home Assistant Core?\n\ncore-2024.5.5\n\n### W... | 0d6c7d097348ecf86f0d0cb6db2ba5b1803b1978 | {
"head_commit": "c1e72b288d3d6b4eda14970bd22d75ebcc473446",
"head_commit_message": "testing fixes",
"patch_to_review": "diff --git a/homeassistant/components/snmp/device_tracker.py b/homeassistant/components/snmp/device_tracker.py\nindex 5d4f9e5e0d935b..d336838117f864 100644\n--- a/homeassistant/components/snmp/... | [
{
"diff_hunk": "@@ -0,0 +1,65 @@\n+\"\"\"Support for displaying collected data over SNMP.\"\"\"\n+\n+from __future__ import annotations\n+\n+from functools import cache\n+\n+from pysnmp.hlapi.asyncio import (\n+ CommunityData,\n+ ContextData,\n+ ObjectIdentity,\n+ ObjectType,\n+ SnmpEngine,\n+ ... | 443f114e8f7967e7317ca55bc8e5acf7276dba04 | diff --git a/homeassistant/components/snmp/__init__.py b/homeassistant/components/snmp/__init__.py
index a4c922877f336f..4a049ee1553558 100644
--- a/homeassistant/components/snmp/__init__.py
+++ b/homeassistant/components/snmp/__init__.py
@@ -1 +1,5 @@
"""The snmp component."""
+
+from .util import async_get_snmp_engi... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
home-assistant__core-118661@6daa206 | home-assistant/core | Python | 118,661 | Add select platform to myuplink | <!--
You are amazing! Thanks for contributing to our project!
Please, DO NOT DELETE ANY TEXT from this template! (unless instructed).
-->
## Proposed change
<!--
Describe the big picture of your changes here to communicate to the
maintainers why we should accept this pull request. If it fixes a bug
or... | 2024-06-02T20:51:11Z | Myuplink integration handles enum-controls incorrect
### The problem
Myuplink integration do not handle writable enum-controls correct.
When the response from Myuplink contains a enum-control that is writable the integration do not handle the response as expected. It should create a writable-control with the enum ... | Hey there @pajzo, @astrandb, mind taking a look at this issue as it has been labeled with an integration (`myuplink`) you are listed as a [code owner](https://github.com/home-assistant/core/blob/dev/CODEOWNERS#L901) for? Thanks!
<details>
<summary>Code owner commands</summary>
Code owners of `myuplink` can trigger b... | [
{
"body": "### The problem\n\nMyuplink integration do not handle writable enum-controls correct.\r\n\r\nWhen the response from Myuplink contains a enum-control that is writable the integration do not handle the response as expected. It should create a writable-control with the enum values. Instead it creates a ... | ffea72f866fc0441c74cb8ed45d2250d005ccb8e | {
"head_commit": "6daa206a6e2634178e24bbe4f0b555c77fcfd2d9",
"head_commit_message": "Address more comments",
"patch_to_review": "diff --git a/homeassistant/components/myuplink/__init__.py b/homeassistant/components/myuplink/__init__.py\nindex a8307cf8c6c8c..d801f27817d59 100644\n--- a/homeassistant/components/myu... | [
{
"diff_hunk": "@@ -0,0 +1,117 @@\n+\"\"\"Tests for myuplink select module.\"\"\"\n+\n+from unittest.mock import MagicMock\n+\n+from aiohttp import ClientError\n+import pytest\n+\n+from homeassistant.const import (\n+ ATTR_ENTITY_ID,\n+ ATTR_OPTION,\n+ SERVICE_SELECT_OPTION,\n+ Platform,\n+)\n+from ... | 5eab785328e844f5bbdd7f5c2ef654448ebe74da | diff --git a/homeassistant/components/myuplink/__init__.py b/homeassistant/components/myuplink/__init__.py
index a8307cf8c6c8cf..d801f27817d59c 100644
--- a/homeassistant/components/myuplink/__init__.py
+++ b/homeassistant/components/myuplink/__init__.py
@@ -25,6 +25,7 @@
PLATFORMS: list[Platform] = [
Platform.BI... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
iterative__dvc-3156@02a73a0 | iterative/dvc | Python | 3,156 | get: implement --show-url to display only url/path to remote | Closes #2994.
From the product requirements, it deviates on the following issue:
1. For now, it does not support showing URLs for multiple paths.
So, we can only do `dvc get <url> <path> --show-url` for a single path, so as
to make it compatible with `dvc get`.
2. It also does not support specifying remo... | 2020-01-15T12:39:44Z | get: show url to cache
In some cases, users need a direct link to a data file in the cloud. It might be just a matter of convenience or when DVC is used from automation tools like CD4ML scenarios. We need to provide a way to get a direct link.
I suggest creating a new command `dvc resolve`. Other options can be also... | @dmpetrov Sounds like some automation helper, that can be worked around by simply reading the dvc file, extracting the checksum and then accessing the remote. Sounds like that wouldn't be a problem for anyone needing this for some automation script, not sure it is useful enough for many users though.
> Sounds like som... | [
{
"body": "In some cases, users need a direct link to a data file in the cloud. It might be just a matter of convenience or when DVC is used from automation tools like CD4ML scenarios. We need to provide a way to get a direct link.\r\n\r\nI suggest creating a new command `dvc resolve`. Other options can be also... | 1f1fb03138318e0aa0c0b1c3353ebfcd4eca1df8 | {
"head_commit": "02a73a0d9b0d40112b8111dd462f9fc76cd14316",
"head_commit_message": "unit: test: check output of get --show-url command",
"patch_to_review": "diff --git a/dvc/api.py b/dvc/api.py\nindex 9d6a321d9e..85c5c07775 100644\n--- a/dvc/api.py\n+++ b/dvc/api.py\n@@ -10,7 +10,7 @@\n from voluptuous import Sc... | [
{
"diff_hunk": "@@ -14,3 +14,19 @@ def test_get(mocker):\n assert cmd.run() == 0\n \n m.assert_called_once_with(\"repo_url\", path=\"src\", out=\"out\", rev=\"version\")\n+\n+\n+def test_get_url(mocker, caplog):\n+ cli_args = parse_args(\n+ [\"get\", \"repo_url\", \"src\", \"--rev\", \"version... | 98f6d56e8c82cefa112ec6942c2844565e669c8e | diff --git a/dvc/api.py b/dvc/api.py
index 9d6a321d9e..85c5c07775 100644
--- a/dvc/api.py
+++ b/dvc/api.py
@@ -10,7 +10,7 @@
from voluptuous import Schema, Required, Invalid
from dvc.repo import Repo
-from dvc.exceptions import DvcException
+from dvc.exceptions import DvcException, NotDvcRepoError
from dvc.externa... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
home-assistant__core-119862@c07e79b | home-assistant/core | Python | 119,862 | Add support to consider device holiday and summer mode in AVM Fritz!Smarthome | <!--
You are amazing! Thanks for contributing to our project!
Please, DO NOT DELETE ANY TEXT from this template! (unless instructed).
-->
## Proposed change
<!--
Describe the big picture of your changes here to communicate to the
maintainers why we should accept this pull request. If it fixes a bug
or... | 2024-06-17T21:09:10Z | FRITZ!DECT 301 vacation mode
### The problem
Hello, I own the radiator thermostats FRITZ!DECT 301 from AVM. The Fritzbox allows you to activate a vacation periode switch during this period, the manual switching of the thermostats is deactivated, it would be nice if HomeAssistant would recognize this setting and it wou... | Hey there @mib1185, @flabbamann, mind taking a look at this issue as it has been labeled with an integration (`fritzbox`) you are listed as a [code owner](https://github.com/home-assistant/core/blob/dev/CODEOWNERS#L480) for? Thanks!
<details>
<summary>Code owner commands</summary>
Code owners of `fritzbox` can trigg... | [
{
"body": "### The problem\n\nHello, I own the radiator thermostats FRITZ!DECT 301 from AVM. The Fritzbox allows you to activate a vacation periode switch during this period, the manual switching of the thermostats is deactivated, it would be nice if HomeAssistant would recognize this setting and it would not b... | 325a49e8ff0702c4c2c28ef6e3a41c6f3d8db9fb | {
"head_commit": "c07e79b97a40c28e956a373ec098c28353094019",
"head_commit_message": "add preset modes, improve hvac mode handling",
"patch_to_review": "diff --git a/homeassistant/components/fritzbox/climate.py b/homeassistant/components/fritzbox/climate.py\nindex cfaa7a298ad6a..b4d0c147ea68e 100644\n--- a/homeass... | [
{
"diff_hunk": "@@ -68,8 +70,8 @@ async def test_setup(hass: HomeAssistant, fritz: Mock) -> None:\n assert state.attributes[ATTR_PRESET_MODE] is None\n assert state.attributes[ATTR_PRESET_MODES] == [PRESET_ECO, PRESET_COMFORT]\n assert state.attributes[ATTR_STATE_BATTERY_LOW] is True\n- assert st... | 3a690e7a16481809bca460dab3bfc850318c5d0d | diff --git a/homeassistant/components/fritzbox/climate.py b/homeassistant/components/fritzbox/climate.py
index cfaa7a298ad6a6..5288682c38878b 100644
--- a/homeassistant/components/fritzbox/climate.py
+++ b/homeassistant/components/fritzbox/climate.py
@@ -19,6 +19,7 @@
UnitOfTemperature,
)
from homeassistant.core... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
gradio-app__gradio-7402@7f557bf | gradio-app/gradio | Python | 7,402 | Use updated component in `postprocess()` | This fixes: https://github.com/gradio-app/gradio/issues/7382 but if this fix is correct, I don't know how anything was working before. It seems we were using the original component instead of the updated component when running `.postprocess()`
Am I missing something @aliabid94 @freddyaboulton?
In particular, it s... | 2024-02-12T19:48:48Z | Setting Dropdown value to an updated (but valid) choice produces warning
### Describe the bug
# The bug is as follows
#A dropdown object is filled with a list
# a hidden Textbox is filled with a string variable of the first list item in the dropbox to carry over the variable. It is also filled if the dropdown select... | I've been wracking my brains over this issue @DRomatzki. Providing a simpler repro as I continue to look into it:
```py
import gradio as gr
# Define choices for the dropdown
my_choices = ["Option 1", "Option 2", "Option 3"]
def update_dropdown_choices():
d2 = gr.Dropdown(choices=my_choices)
print(d2.... | [
{
"body": "### Describe the bug\n\n# The bug is as follows\r\n#A dropdown object is filled with a list\r\n# a hidden Textbox is filled with a string variable of the first list item in the dropbox to carry over the variable. It is also filled if the dropdown selects another variable from the list. One could use ... | 5b1ab3727ce14479b164dd52d86e8015ef54b57a | {
"head_commit": "7f557bfa71eee06d09f8b5b79429be1deb4dbcf3",
"head_commit_message": "lint",
"patch_to_review": "diff --git a/.changeset/blue-walls-flash.md b/.changeset/blue-walls-flash.md\nnew file mode 100644\nindex 0000000000..d08fb044c1\n--- /dev/null\n+++ b/.changeset/blue-walls-flash.md\n@@ -0,0 +1,5 @@\n+-... | [
{
"diff_hunk": "@@ -823,6 +823,31 @@ def run(min, num):\n \"error\" not in session_1.json()\n ) # no error because sesssion 1 block config was lost when session 3 was added\n \n+ def test_state_holder_is_used_in_postprocess(self):",
"line": null,
"original_line": 826,
"origin... | 218368f803732a53bde356f746ac4ac2293a5886 | diff --git a/.changeset/blue-walls-flash.md b/.changeset/blue-walls-flash.md
new file mode 100644
index 0000000000..d08fb044c1
--- /dev/null
+++ b/.changeset/blue-walls-flash.md
@@ -0,0 +1,5 @@
+---
+"gradio": patch
+---
+
+fix:Use updated component in `postprocess()`
diff --git a/gradio/blocks.py b/gradio/blocks.py
in... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
iterative__dvc-2809@934850f | iterative/dvc | Python | 2,809 | GS progress for push & pull | - [x] upload with progress
- [x] download with progress
- [x] add totals, filenames, disable, etc
- [x] test
- fixes #1566 | 2019-11-17T23:01:36Z | gs: support progress callback
I may have missed an issue concerning this, but when I am `dvc push`ing to a google cloud remote, the progress bars that are currently displayed don't get updated progressively (They go from 0 when starting to 100 when finished).
It would be nice to have a dynamic progressbar with uploa... | Hi @mhham !
Indeed, callback for google cloud storate push/pull is not implemented yet. Let's keep this issue open as a reminder. Thank you for the feedback! 🙂
Problem is there's no current API.
`google.cloud.storage.bucket.Bucket.`:
- [`copy_blob`](https://googleapis.github.io/google-cloud-python/latest/stora... | [
{
"body": "I may have missed an issue concerning this, but when I am `dvc push`ing to a google cloud remote, the progress bars that are currently displayed don't get updated progressively (They go from 0 when starting to 100 when finished).\r\n\r\nIt would be nice to have a dynamic progressbar with upload speed... | 38c210068ba5aeb70ad92a8c22e85832640d8ebd | {
"head_commit": "934850f23c707e33e2c7ff68f22df12af132fac8",
"head_commit_message": "neaten default chunks\n\nFixes https://github.com/iterative/dvc/pull/2809#discussion_r347178103",
"patch_to_review": "diff --git a/dvc/remote/gs.py b/dvc/remote/gs.py\nindex c2fb4efc1c..3091c628dc 100644\n--- a/dvc/remote/gs.py\n... | [
{
"diff_hunk": "@@ -20,35 +23,47 @@ def dynamic_chunk_size(func):\n @wraps(func)\n def wrapper(*args, **kwargs):\n import requests\n- from google.cloud.storage.blob import Blob, _DEFAULT_CHUNKSIZE\n+ from google.cloud.storage.blob import _DEFAULT_CHUNKSIZE\n \n- # Default ch... | b2f7c841ef674f67c77dd2ed0ebb8797cfccd986 | diff --git a/dvc/remote/gs.py b/dvc/remote/gs.py
index c2fb4efc1c..0ba106dbdb 100644
--- a/dvc/remote/gs.py
+++ b/dvc/remote/gs.py
@@ -1,14 +1,17 @@
-from __future__ import unicode_literals
+from __future__ import unicode_literals, division
import logging
from datetime import timedelta
from functools import wraps
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
iterative__dvc-2759@48d16f6 | iterative/dvc | Python | 2,759 | get/import: more meaningful message on NoRemoteError | * [x] ❗ Have you followed the guidelines in the [Contributing to DVC](https://dvc.org/doc/user-guide/contributing/core) list?
* [x] 📖 Check this box if this PR **does not** require [documentation](https://dvc.org/doc) updates, or if it does **and** you have created a separate PR in [dvc.org](https://github.com/iter... | 2019-11-08T16:49:34Z | get/import: improve error message on no default remote
Since we allow importing/getting files that are not cached this error does not make much sense:
```
failed to import 'model.pkl' from '../test-import/'. - config file error: no remote specified. Setup default remote with
```
in a lot of cases. | So is this just a wrong error message?
I would say it's in a wrong place. We need to raise this only when we try to import a cached object and no default remote is specified.
@shcheklein, @Suor I found out I could not run `dvc import` if the source repo has no default remote set. Also, the error I got (see below) con... | [
{
"body": "Since we allow importing/getting files that are not cached this error does not make much sense:\r\n\r\n```\r\nfailed to import 'model.pkl' from '../test-import/'. - config file error: no remote specified. Setup default remote with\r\n```\r\n\r\nin a lot of cases.\r\n",
"number": 2711,
"title"... | cfc579929c75a85aceb10b130493ed988bc59926 | {
"head_commit": "48d16f6cc5194773f5256b346a11d17b21eb397a",
"head_commit_message": "Update dvc/exceptions.py\n\nCo-Authored-By: Ruslan Kuprieiev <kupruser@gmail.com>",
"patch_to_review": "diff --git a/dvc/exceptions.py b/dvc/exceptions.py\nindex 07a0ce8061..45322bbe57 100644\n--- a/dvc/exceptions.py\n+++ b/dvc/e... | [
{
"diff_hunk": "@@ -19,7 +21,10 @@ def external_repo(url=None, rev=None, rev_lock=None, cache_dir=None):\n \n path = _external_repo(url=url, rev=rev_lock or rev, cache_dir=cache_dir)\n repo = Repo(path)\n- yield repo\n+ try:\n+ yield repo\n+ except NoRemoteError:\n+ raise RemoteNo... | 4a6a1b662dda5dff46e9a74b9aad96353548a751 | diff --git a/dvc/exceptions.py b/dvc/exceptions.py
index 07a0ce8061..2916066146 100644
--- a/dvc/exceptions.py
+++ b/dvc/exceptions.py
@@ -328,3 +328,13 @@ def __init__(self, target_infos):
class CollectCacheError(DvcException):
pass
+
+
+class RemoteNotSpecifiedInExternalRepoError(DvcException):
+ def __ini... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
gradio-app__gradio-7350@54203d3 | gradio-app/gradio | Python | 7,350 | Fix `gr.load` for file-based Spaces | There were two separate issues going on:
1. We weren't handling URLs correctly in the Client. In particular, we would transform any string that was a valid URL to a dictionary consisting of a path regardless of whether the value corresponded to a file-based component. Now, we check to see if the component is a file... | 2024-02-08T00:08:01Z | A Space loaded with `gr.load()` is not functional
### Describe the bug
While embedding the private space into the public one, UI is transitioned, but is completely unfunctional, although the private space by itself works perfectly. Dropdowns can't be clicked, buttons don't do anything, one can only fill a text field s... | Hi @vitaliy-sharandin do you see any errors in the logs?
As I've written before, no error logs are shown, it just silently doesn't work, there are dropdowns/video upload/buttons failing and from what I've seen in the HF forums, some users experienced troubles with data in loading spaces as well. Again, when private on... | [
{
"body": "### Describe the bug\n\nWhile embedding the private space into the public one, UI is transitioned, but is completely unfunctional, although the private space by itself works perfectly. Dropdowns can't be clicked, buttons don't do anything, one can only fill a text field successfully. Also, no error l... | b25f76c5df100719a364b6b822e9ba3c98b02460 | {
"head_commit": "54203d3a89f4e9e22a5320bb32d5155ea5c7f769",
"head_commit_message": "add changeset",
"patch_to_review": "diff --git a/.changeset/tender-lamps-shout.md b/.changeset/tender-lamps-shout.md\nnew file mode 100644\nindex 0000000000..5ae5385e0a\n--- /dev/null\n+++ b/.changeset/tender-lamps-shout.md\n@@ -... | [
{
"diff_hunk": "@@ -77,20 +77,23 @@ def __init__(\n auth: tuple[str, str] | None = None,\n *,\n headers: dict[str, str] | None = None,\n+ deserialize: bool = True,",
"line": null,
"original_line": 80,
"original_start_line": null,
"path": "client/python/gradio_clien... | fa3d844abf06eabc283de322b13161c651b120ac | diff --git a/.changeset/tender-lamps-shout.md b/.changeset/tender-lamps-shout.md
new file mode 100644
index 0000000000..5ae5385e0a
--- /dev/null
+++ b/.changeset/tender-lamps-shout.md
@@ -0,0 +1,6 @@
+---
+"gradio": patch
+"gradio_client": patch
+---
+
+fix:Fix `gr.load` for file-based Spaces
diff --git a/client/python... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
iterative__dvc-2660@94cfb84 | iterative/dvc | Python | 2,660 | ssh credential prompt before progress | - fixes #2653 | 2019-10-24T00:11:53Z | "dvc pull" shows progress bar too early
**Information about setup**
DVC version: 0.63.4
Method of installation: pip
Platform: Ubuntu Linux 16.04
**Description:**
I access my dvc remote via ssh. Whenever I execute `dvc pull` command dvc asks for passphrase for my RSA key and immediately shows progress bar befo... | @casperdcl could you take a look please?
ah, the bar might actually be showing before the prompt, but it's just drawn below all text (including the prompt). | [
{
"body": "**Information about setup**\r\n\r\nDVC version: 0.63.4\r\nMethod of installation: pip\r\nPlatform: Ubuntu Linux 16.04\r\n\r\n**Description:**\r\nI access my dvc remote via ssh. Whenever I execute `dvc pull` command dvc asks for passphrase for my RSA key and immediately shows progress bar before I've ... | 7879c7cb31eba8d1f82455953c63fabe6e0d319f | {
"head_commit": "94cfb840a25292cf72e558242cd294023a01f17c",
"head_commit_message": "ssh credential prompt before progress",
"patch_to_review": "diff --git a/dvc/remote/ssh/__init__.py b/dvc/remote/ssh/__init__.py\nindex 75a2a6f980..168d1eff3b 100644\n--- a/dvc/remote/ssh/__init__.py\n+++ b/dvc/remote/ssh/__init_... | [
{
"diff_hunk": "@@ -306,6 +308,10 @@ def cache_exists(self, checksums, jobs=None, name=None):\n if not self.no_traverse:\n return list(set(checksums) & set(self.all()))\n \n+ # possibly prompt for credentials before \"Querying\" progress output\n+ path_info = self.checksum_to_p... | 9237f18c89050097cee90c9a9ac8394104c1da57 | diff --git a/dvc/remote/ssh/__init__.py b/dvc/remote/ssh/__init__.py
index 75a2a6f980..572f7d7de0 100644
--- a/dvc/remote/ssh/__init__.py
+++ b/dvc/remote/ssh/__init__.py
@@ -115,9 +115,10 @@ def _try_get_ssh_config_keyfile(user_ssh_config):
return identity_file[0]
return None
- def ssh(self,... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
iterative__dvc-2375@8233f95 | iterative/dvc | Python | 2,375 | remote: gs/s3: remove batch_exists | * [x] Have you followed the guidelines in our
[Contributing document](https://dvc.org/doc/user-guide/contributing)?
* [x] Does your PR affect documented changes or does it add new functionality
that should be documented? If yes, have you created a PR for
[dvc.org](https://github.com/iterative/dv... | 2019-08-07T10:35:26Z | Collecting information from remote cache very slow
**Please provide information about your setup**
DVC version(i.e. `dvc --version`), Platform and method of installation (pip, homebrew, pkg Mac, exe (Windows), DEB(Linux), RPM(Linux))
Running under Windows 10 wsl as well as debian stretch with an azure blob storage ... | @JohanMollevik Thanks for repoting that! That seems like bug, let us investigate.
@pared noticed a typo in my original issue, edited it and corrected it
@JohanMollevik well, its not a bug, rather lack of optimization for azure. During pull we need to verify that checksum of your dataset (stored in '*.dvc' file) exists ... | [
{
"body": "**Please provide information about your setup**\r\nDVC version(i.e. `dvc --version`), Platform and method of installation (pip, homebrew, pkg Mac, exe (Windows), DEB(Linux), RPM(Linux))\r\n\r\nRunning under Windows 10 wsl as well as debian stretch with an azure blob storage as remote\r\n\r\n$ dvc --v... | a063f408a27622d67a4140d30f0eabf15aaca6ee | {
"head_commit": "8233f959c795ab6b0d2582dc1e8c45376f6364c8",
"head_commit_message": "remote: ssh: reintroduce batch_exists",
"patch_to_review": "diff --git a/dvc/remote/azure.py b/dvc/remote/azure.py\nindex 0b8330ae3c..6e37545edb 100644\n--- a/dvc/remote/azure.py\n+++ b/dvc/remote/azure.py\n@@ -6,6 +6,8 @@\n impo... | [
{
"diff_hunk": "@@ -644,15 +637,10 @@ def cache_exists(self, checksums, jobs=None):\n \"\"\"\n progress_callback = ProgressCallback(len(checksums))\n \n- def exists_with_progress(chunks):\n- return self.batch_exists(chunks, callback=progress_callback)",
"line": 648,
"or... | 06d347178f352f4b318d35b439b4325182c3b3d7 | diff --git a/dvc/remote/azure.py b/dvc/remote/azure.py
index 0b8330ae3c..6e37545edb 100644
--- a/dvc/remote/azure.py
+++ b/dvc/remote/azure.py
@@ -6,6 +6,8 @@
import logging
from datetime import datetime, timedelta
+from funcy import cached_property
+
from dvc.scheme import Schemes
try:
@@ -71,29 +73,27 @@ def ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Performance Optimizations"
} |
iterative__dvc-2493@0935930 | iterative/dvc | Python | 2,493 | output: prevent stage file from being used as output | * [x] Have you followed the guidelines in our
[Contributing document](https://dvc.org/doc/user-guide/contributing)?
* [x] Does your PR affect documented changes or does it add new functionality
that should be documented? If yes, have you created a PR for
[dvc.org](https://github.com/iterative/dv... | 2019-09-12T13:35:44Z | run: warning/exception when dependency is a dvc-file
It doesn't make a lot of sense to depend on a dvc-file, however, the interface is not intuitive enough to prevent this.
If we want to allow this behavior, it should be with a warning. | As a first step we might just add a check that dependency is not a dvc file and throw an error. Having it as a feature also sounds quite neat, so one could do `-d my.dvc` which would mean "depend on all outputs of my.dvc". Not sure if that feature is desirable though, since it might be used by accident causing some obs... | [
{
"body": "It doesn't make a lot of sense to depend on a dvc-file, however, the interface is not intuitive enough to prevent this.\r\n\r\nIf we want to allow this behavior, it should be with a warning.",
"number": 2345,
"title": "run: warning/exception when dependency is a dvc-file"
}
] | 6d16227bc1a95b33a0440382f68fadb36366b999 | {
"head_commit": "0935930f46c3399ad7b1c4b61a5fd7296a3b4ba5",
"head_commit_message": "output: prevent stage file from being used as output",
"patch_to_review": "diff --git a/dvc/dependency/base.py b/dvc/dependency/base.py\nindex f76f4e022e..3fba3960d5 100644\n--- a/dvc/dependency/base.py\n+++ b/dvc/dependency/base... | [
{
"diff_hunk": "@@ -15,11 +15,19 @@ def __init__(self, path):\n super(DependencyIsNotFileOrDirError, self).__init__(msg)\n \n \n+class DependencyIsStageFileError(DvcException):\n+ def __init__(self, path):\n+ super(DependencyIsStageFileError, self).__init__(\n+ \"Stage file '{}' can... | 53f6aead951735a92451f08f5543e65960f416ec | diff --git a/dvc/dependency/base.py b/dvc/dependency/base.py
index f76f4e022e..4f52bf5d05 100644
--- a/dvc/dependency/base.py
+++ b/dvc/dependency/base.py
@@ -15,11 +15,19 @@ def __init__(self, path):
super(DependencyIsNotFileOrDirError, self).__init__(msg)
+class DependencyIsStageFileError(DvcException):
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
home-assistant__core-116726@90d3710 | home-assistant/core | Python | 116,726 | Update unique_id to string in Honeywell | <!--
You are amazing! Thanks for contributing to our project!
Please, DO NOT DELETE ANY TEXT from this template! (unless instructed).
-->
## Proposed change
<!--
Describe the big picture of your changes here to communicate to the
maintainers why we should accept this pull request. If it fixes a bug
... | 2024-05-03T18:59:03Z | Non-string unique Id in honeywell integration
### The problem
I just upgraded to 2024.5.0 and seeing these messages in the log:
ERROR:homeassistant.helpers.entity_registry:'climate' from integration
honeywell has a non string unique_id '8080320', please create a bug
report
I assume this is all the information... | Hey there @rdfurman, @mkmer, mind taking a look at this issue as it has been labeled with an integration (`honeywell`) you are listed as a [code owner](https://github.com/home-assistant/core/blob/dev/CODEOWNERS#L608) for? Thanks!
<details>
<summary>Code owner commands</summary>
Code owners of `honeywell` can trigger... | [
{
"body": "### The problem\n\nI just upgraded to 2024.5.0 and seeing these messages in the log:\r\n\r\nERROR:homeassistant.helpers.entity_registry:'climate' from integration\r\nhoneywell has a non string unique_id '8080320', please create a bug\r\nreport \r\n\r\nI assume this is all the information that is need... | 9b4099950c374ea67f2d2b57a64b54f7c1844289 | {
"head_commit": "90d371059c9a3485a321f1d4df476ae761aefdd4",
"head_commit_message": "Update unique_id to string",
"patch_to_review": "diff --git a/homeassistant/components/honeywell/climate.py b/homeassistant/components/honeywell/climate.py\nindex ff63d66230da6c..7f618e4e25c50f 100644\n--- a/homeassistant/compone... | [
{
"diff_hunk": "@@ -161,7 +178,8 @@ def __init__(\n self._away = False\n self._retry = 0\n \n- self._attr_unique_id = device.deviceid\n+ self._attr_unique_id = f\"{device.deviceid}\"",
"line": null,
"original_line": 181,
"original_start_line": null,
"path": "homeass... | 8e2bb94f7fea4f892eff537e60d3ba9276635be8 | diff --git a/homeassistant/components/honeywell/climate.py b/homeassistant/components/honeywell/climate.py
index ff63d66230da6c..f9a1cc54c7ae76 100644
--- a/homeassistant/components/honeywell/climate.py
+++ b/homeassistant/components/honeywell/climate.py
@@ -35,7 +35,11 @@
from homeassistant.const import ATTR_TEMPERAT... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
iterative__dvc-2596@37847e7 | iterative/dvc | Python | 2,596 | Replace hyphen with underscore for command auto-completion | Fixes #2279
Although I found one potential bug in auto-completion.
This is happening because of `${!options_list}` as `-h` is passed as `option_list`. Since, its variable ... | 2019-10-10T21:18:15Z | completion: support import-url and get-url
Add support for `dvc import-url` and `dvc get-url` into bash auto-completion script.
**What should be done:**
As to `import-url` and `get-url`, you would need to convert on `${COMP_WORDS[1]}` first that would replace all `-` with `_`, so that `option_list` becomes `_dvc_... | Context https://github.com/iterative/dvc/pull/2226#issuecomment-511155421
@shcheklein Shall I take up this issue?
@algomaster99 Sure! | [
{
"body": "Add support for `dvc import-url` and `dvc get-url` into bash auto-completion script.\r\n\r\n**What should be done:**\r\n\r\nAs to `import-url` and `get-url`, you would need to convert on `${COMP_WORDS[1]}` first that would replace all `-` with `_`, so that `option_list` becomes `_dvc_import_url` and ... | 44264857c3994a67219a4a0c1b1fd67057abe3ca | {
"head_commit": "37847e7c1c2831e2581cecfda202718adf950f8d",
"head_commit_message": "Write function to replace hyphen and check for flags",
"patch_to_review": "diff --git a/scripts/completion/dvc.bash b/scripts/completion/dvc.bash\nindex d9f2babf99..abe5d98c65 100644\n--- a/scripts/completion/dvc.bash\n+++ b/scri... | [
{
"diff_hunk": "@@ -82,13 +86,21 @@ _dvc () {\n *) COMPREPLY=($(compgen -W \"$_dvc_commands\" -- \"$word\")) ;;\n esac\n elif [ \"${COMP_CWORD}\" -eq 2 ]; then\n- local options_list=\"_dvc_${COMP_WORDS[1]}\"\n+ if [[ ${COMP_WORDS[1]:0:1} == \"-\" ]]; then\n+ return 0\n+ else\n+ l... | 2dfe3901aa31f052dcac22ba614e8c6eaf2eaca4 | diff --git a/scripts/completion/dvc.bash b/scripts/completion/dvc.bash
index d9f2babf99..95693042be 100644
--- a/scripts/completion/dvc.bash
+++ b/scripts/completion/dvc.bash
@@ -72,6 +72,10 @@ _dvc_version=''
# ${!x} -> ${hello} -> "world"
#
_dvc () {
+ replace_hyphen () {
+ echo $(echo $1 | sed 's/-/_/... | {
"difficulty": "low",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
iterative__dvc-2358@5754e5b | iterative/dvc | Python | 2,358 | remote: base: don't checkout existing file | * [x] Have you followed the guidelines in our
[Contributing document](https://dvc.org/doc/user-guide/contributing)?
* [x] Does your PR affect documented changes or does it add new functionality
that should be documented? If yes, have you created a PR for
[dvc.org](https://github.com/iterative/dv... | 2019-08-02T14:43:06Z | Misleading warning (Removing before checkout)
During a manual update of a file, I've faced the following message:
>WARNING: data 'foo' exists. Removing before checkout.
It puzzled me, I thought it would overwrite my file, since checkout restores the file based on current DVC file.
I don't know why the file was rep... | Discord context: https://discordapp.com/channels/485586884165107732/485596304961962003/579053609271164929
Also when running `dvc run -o metrics.txt "echo 0.9643 > metrics.txt"` twice or if metrics.txt is already in cache.
Need to make sure this also works properly for directories. | [
{
"body": "During a manual update of a file, I've faced the following message:\r\n>WARNING: data 'foo' exists. Removing before checkout.\r\n\r\nIt puzzled me, I thought it would overwrite my file, since checkout restores the file based on current DVC file.\r\nI don't know why the file was replaced by the same f... | 74bd7d59cf275601729d6719d9f750a385ab20d7 | {
"head_commit": "5754e5b23c10a4f679b7ca0f631ac74654f69280",
"head_commit_message": "test: checkout: move repeated add tests",
"patch_to_review": "diff --git a/dvc/remote/base.py b/dvc/remote/base.py\nindex 619b4799d2..1f782057fe 100644\n--- a/dvc/remote/base.py\n+++ b/dvc/remote/base.py\n@@ -680,20 +680,33 @@ de... | [
{
"diff_hunk": "@@ -493,21 +498,21 @@ def _unprotect_file(path):\n \n os.chmod(path, os.stat(path).st_mode | stat.S_IWRITE)\n \n- def _unprotect_dir(self, path):\n+ def _unprotect_dir(self, path, allow_copy=True):\n for fname in walk_files(path, self.repo.dvcignore):\n- RemoteLO... | 50e2bf90389b5d96a2543ee90f4850f20f711fab | diff --git a/dvc/remote/base.py b/dvc/remote/base.py
index 619b4799d2..973718cb21 100644
--- a/dvc/remote/base.py
+++ b/dvc/remote/base.py
@@ -680,20 +680,45 @@ def safe_remove(self, path_info, force=False):
self.remove(path_info)
def _checkout_file(
- self, path_info, checksum, force, progress_c... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
iterative__dvc-2338@297b02d | iterative/dvc | Python | 2,338 | dvc: hooks only act in branches where dvc active | In a branch where DVC hasn't been initialized (as detected by `git ls-files .dvc` not listing any files), don't invoke dvc in the git hooks. This avoids trouble when switching between branches with and without dvc initialized.
Fixes #2208
* [x] Have you followed the guidelines in our
[Contributing document... | 2019-07-29T00:45:48Z | post-checkout hook breaks checkout and rebase when adopting DVC in a branch
When adopting DVC in an existing repository with PR code-review workflow, it will be landing in a branch that isn't master. This branch then has problematic interactions where work continues on master before the dvc adoption lands there.
Spe... | > Not sure whether that check is as simple as checking existence of .dvc
Hm, probably not that, because git-ignored stuff under `.dvc` _should_ stick around even when you checkout a branch outside of dvc control. But maybe `git ls-files -- .dvc`?
With very minimal testing this post-checkout hook seems to fix at lea... | [
{
"body": "When adopting DVC in an existing repository with PR code-review workflow, it will be landing in a branch that isn't master. This branch then has problematic interactions where work continues on master before the dvc adoption lands there.\r\n\r\nSpecifically, once you've done `dvc init`, committed tha... | 32425e90691bfd4988eb0a2d70cdc4fdba910f49 | {
"head_commit": "297b02d3adb0251a762a5330801d318114a6d24c",
"head_commit_message": "dvc: hooks only act in branches where dvc active\n\nIn a branch where DVC hasn't been initialized (as detected by\n`git ls-files .dvc` not listing any files), don't invoke dvc in the git hooks.\nThis avoids trouble when switching b... | [
{
"diff_hunk": "@@ -217,17 +217,28 @@ def list_tags(self):\n \n def _install_hook(self, name, cmd):\n command = \"dvc {}\".format(cmd)",
"line": null,
"original_line": 219,
"original_start_line": null,
"path": "dvc/scm/git/__init__.py",
"start_line": null,
"text": "@user1:\nW... | e6969745cd5811f19d0fe8cb28eb7917e5d4b5ff | diff --git a/dvc/scm/git/__init__.py b/dvc/scm/git/__init__.py
index c0592e896b..883c75afd0 100644
--- a/dvc/scm/git/__init__.py
+++ b/dvc/scm/git/__init__.py
@@ -216,19 +216,17 @@ def list_tags(self):
return [t.name for t in self.git.tags]
def _install_hook(self, name, cmd):
- command = "dvc {}"... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
gradio-app__gradio-7337@53533be | gradio-app/gradio | Python | 7,337 | Improve File Explorer performance | Previously we would load the entire directory structure at the root directory and send that to the frontend when the fileexplorer component loaded. This could be prohibitively expensive for higher level directories to crawl through all the nested subdirectories, taking on the order of minutes to load. Now the API call ... | 2024-02-07T05:14:46Z | Updating the root parameter in the fileexplorer component does not change the front-end display of the file directory.
### Describe the bug
The gr.fileexplorer() object changes the root parameter when used as a callback function, but it does not actually change the root directory of the component for file searches.
I... | Hi @lifeisgoodcdj is this still an issue in the latest version of Gradio (4.15.0)? I believe we’ve fixed it
The issue still exists. I have tried the 4.15.0 version of gradio, but I still cannot update or switch directories actually
cc @aliabid94
i also need to update root dir ~
Hi @lifeisgoodcdj - the `root` paramet... | [
{
"body": "### Describe the bug\n\nThe gr.fileexplorer() object changes the root parameter when used as a callback function, but it does not actually change the root directory of the component for file searches.\r\nI want to know how to change the root directory of gr.fileexplorer() \n\n### Have you searched e... | 547517b74edc4536450b9dc64aecf68d7a0da561 | {
"head_commit": "53533be03502700ede5f3010d3fc9a1d0cceb6cc",
"head_commit_message": "changes",
"patch_to_review": "diff --git a/.changeset/chatty-rules-press.md b/.changeset/chatty-rules-press.md\nnew file mode 100644\nindex 0000000000..dcec9ee9ec\n--- /dev/null\n+++ b/.changeset/chatty-rules-press.md\n@@ -0,0 +1... | [
{
"diff_hunk": "@@ -10,22 +10,18 @@\n choices=[str(base_root / \"dir1\"), str(base_root / \"dir2\"),\n str(base_root / \"dir3\")])\n with gr.Group():\n- dir_only_glob = gr.Checkbox(label=\"Show only directories\", value=False)\n- ... | 712a7fd4f92f71521d324e0eb6fd0db8824638b8 | diff --git a/.changeset/chatty-rules-press.md b/.changeset/chatty-rules-press.md
new file mode 100644
index 0000000000..dcec9ee9ec
--- /dev/null
+++ b/.changeset/chatty-rules-press.md
@@ -0,0 +1,6 @@
+---
+"@gradio/fileexplorer": patch
+"gradio": patch
+---
+
+fix:Improve File Explorer performance
diff --git a/demo/fil... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
gradio-app__gradio-7141@b1408b6 | gradio-app/gradio | Python | 7,141 | Few File component drag and drop | ## Description
- Fixes Drag and Drop for types of the first element in file_types
- Added playwright playwright tests for drag & drop
Closes: #7094
## 🎯 PRs Should Target Issues
Before your create a PR, please check to see if there is [an existing issue](https://github.com/gradio-app/gradio/issues) for this... | 2024-01-24T19:51:50Z | gr.File only supports Drag and Drop for types of the first element in file_types
### Describe the bug
gr.File( file_types = [ 'image', 'video' ] ) only supports Drag and Drop for image file but not video file. (However, clicking interface to select file to upload is both support for the two. )
gr.File( file_types = [... | I thought we fixed this? @dawoodkhan82 can we add some functional tests to prevent this issue from reoccurring
Seems like an edge case that I didn't test for. I fixed it for specific file types, and added functional tests for those. But not generic file types like "image" and "video". Will fix! | [
{
"body": "### Describe the bug\n\ngr.File( file_types = [ 'image', 'video' ] ) only supports Drag and Drop for image file but not video file. (However, clicking interface to select file to upload is both support for the two. )\r\ngr.File( file_types = [ 'file' ] ) can support all types to Drag and Drop but...\... | 68a54a7a310d8d7072fdae930bf1cfdf12c45a7f | {
"head_commit": "b1408b6427367ffed09f3fd1a95dfe65da9bc93c",
"head_commit_message": "test fixes",
"patch_to_review": "diff --git a/.changeset/puny-clowns-invent.md b/.changeset/puny-clowns-invent.md\nnew file mode 100644\nindex 0000000000..b6fd1252ce\n--- /dev/null\n+++ b/.changeset/puny-clowns-invent.md\n@@ -0,0... | [
{
"diff_hunk": "@@ -20,7 +20,7 @@\n \tlabel={label || \"File\"}\n />\n \n-{#if value && (Array.isArray(value) ? value.length > 0 : true)}\n+{#if (Array.isArray(value) && value.length > 0) || value !== null}",
"line": null,
"original_line": 23,
"original_start_line": null,
"path": "js/file/shared... | 16659563a4c1e477ed986d67089d0f56d2006d2e | diff --git a/.changeset/puny-clowns-invent.md b/.changeset/puny-clowns-invent.md
new file mode 100644
index 0000000000..2997aad0d5
--- /dev/null
+++ b/.changeset/puny-clowns-invent.md
@@ -0,0 +1,6 @@
+---
+"@gradio/upload": patch
+"gradio": patch
+---
+
+fix:Few File component drag and drop
diff --git a/demo/file_compo... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
iterative__dvc-2268@5e773f2 | iterative/dvc | Python | 2,268 | disable analytics warning message on init if disabled globally/system… | …-wide
Fixes #2267 by only printing an analytics warning message on `dvc init` if
`dvc.analytics.Analytics._is_enabled()` returns `True`.
Maybe a message that analytics is disabled should be printed too.
| 2019-07-14T18:06:02Z | `dvc init` prints analytics warning even if has been disabled
**When** a new repository is initialized and the `core.analytics` has been set to `False` either globally or system-wide
**Then** a the analytics warning message is still printed
**Causing** a bit of irritation and actually checking the code what's really ... | [
{
"body": "**When** a new repository is initialized and the `core.analytics` has been set to `False` either globally or system-wide\r\n**Then** a the analytics warning message is still printed\r\n**Causing** a bit of irritation and actually checking the code what's really going on \r\n\r\nSeems like the `_welco... | 94fe86afe8564648c41e30cdf7d4fa122b0b7ac7 | {
"head_commit": "5e773f2e393dc80f6a7a59c38ead64be03278fa4",
"head_commit_message": "disable analytics warning message on init if disabled globally/system-wide",
"patch_to_review": "diff --git a/dvc/repo/init.py b/dvc/repo/init.py\nindex 6fefbad8f3..1233cba68f 100644\n--- a/dvc/repo/init.py\n+++ b/dvc/repo/init.p... | [
{
"diff_hunk": "@@ -7,21 +7,23 @@\n from dvc.config import Config\n from dvc.exceptions import InitError\n from dvc.utils import boxify, relpath, remove\n+from dvc.analytics import Analytics\n \n logger = logging.getLogger(__name__)\n \n \n def _welcome_message():\n- logger.info(\n- boxify(\n- ... | e247678f90a53291a5ffd69bc28296e109dc04b1 | diff --git a/dvc/analytics.py b/dvc/analytics.py
index d9805bfd18..6643db7684 100644
--- a/dvc/analytics.py
+++ b/dvc/analytics.py
@@ -213,10 +213,20 @@ def _is_enabled_config(config):
return core.get(Config.SECTION_CORE_ANALYTICS, True)
@staticmethod
- def _is_enabled(cmd=None):
+ def _get_curren... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} | |
iterative__dvc-2017@ac50ece | iterative/dvc | Python | 2,017 | Coalesce `requirements.txt` into `setup.py` | * [x] Have you followed the guidelines in our
[Contributing document](https://dvc.org/doc/user-guide/contributing)?
* [x] Does your PR affect documented changes or does it add new functionality
that should be documented? If yes, have you created a PR for
[dvc.org](https://github.com/iterative/dv... | 2019-05-18T14:22:12Z | dvc: unify requirements files and setup.py
We have duplication between `requirements.txt` and `setup.py` `install_requires`. We also use three `pip install` lines in docs to set things up. Ideally we would just say:
```bash
pip install -e .[tests]
# or
pip install -e .[all,tests] # for all remotes
```
So this co... | [
{
"body": "We have duplication between `requirements.txt` and `setup.py` `install_requires`. We also use three `pip install` lines in docs to set things up. Ideally we would just say:\r\n```bash\r\npip install -e .[tests]\r\n# or\r\npip install -e .[all,tests] # for all remotes\r\n```\r\nSo this contains sever... | 29fd8e2e41d0741b0a7870cbbe133c724ebe1fe6 | {
"head_commit": "ac50ece81eea9130283b6ef46ae28a098c9b1080",
"head_commit_message": "Append extra dependenices in test_requirements in setup.py",
"patch_to_review": "diff --git a/requirements.txt b/requirements.txt\ndeleted file mode 100644\nindex 6bf6bb725b..0000000000\n--- a/requirements.txt\n+++ /dev/null\n@@ ... | [
{
"diff_hunk": "@@ -69,6 +69,34 @@ def run(self):\n ssh = [\"paramiko>=2.4.1\"]\n all_remotes = gs + s3 + azure + ssh + oss\n \n+# Extra dependecies to run tests\n+tests_requirements = [\n+ \"PyInstaller==3.4\",\n+ \"wheel>=0.31.1\",\n+ 'futures>=3.2.0; python_version == \"2.7\"',\n+ \"pydot>=1.2.4\... | bec92664ef01d96a84c1692a6aeb29d8d23fa52d | diff --git a/.appveyor.yml b/.appveyor.yml
index efdcc6b032..f498c8f230 100644
--- a/.appveyor.yml
+++ b/.appveyor.yml
@@ -47,7 +47,7 @@ install:
- cinst gsutil
- cinst openssl.light --version 1.1.1
- python -m pip install -U pip setuptools wheel
- - pip install -r requirements.txt
+ - pip install -e .[all]
... | {
"difficulty": "low",
"estimated_review_effort": 3,
"problem_domain": "Code Refactoring / Architectural Improvement"
} | |
iterative__dvc-810@ebee3ce | iterative/dvc | Python | 810 | Optional dependencies for cache strategies | An attempt to fix #348. | 2018-06-26T21:30:05Z | allow installing and running only without all cloud dependencies
DVC has dependencies on multiple cloud services (aws, google), though a typical instalation will only use one of them
is it possible to make the package not use or require unneeded packages?
in runtime, it's usually possible to do 'lazy' imports, th... | Hi @ophiry
It is a good idea. But it might confuse some users - after changing a cloud in config DVC can start crashing. From `pip` point of view, we might (in theory) separate dvc package into a few packages: `dvc`, `dvc-aws`, `dvc-gcp`. This approach has advantages as well as disadvantages. We should think about ... | [
{
"body": "DVC has dependencies on multiple cloud services (aws, google), though a typical instalation will only use one of them\r\n\r\nis it possible to make the package not use or require unneeded packages?\r\n\r\nin runtime, it's usually possible to do 'lazy' imports, that will be called only when the specif... | 97a1f0ba99e30f38a6b8be0a7a8c20aa2bb8af16 | {
"head_commit": "ebee3ceae1aa01ef51fb3a85aeaf915cf67480b8",
"head_commit_message": "Add dependency checking as config validation",
"patch_to_review": "diff --git a/dvc/remote/__init__.py b/dvc/remote/__init__.py\nindex 40a44b5d3d..1648e1ec8d 100644\n--- a/dvc/remote/__init__.py\n+++ b/dvc/remote/__init__.py\n@@ ... | [
{
"diff_hunk": "@@ -33,14 +33,16 @@ def __init__(self, msg):\n \n class RemoteBase(object):\n REGEX = None\n+ REQUIRES = []\n \n def __init__(self, project, config):\n pass\n \n @classmethod\n- def supported(cls, config):\n+ def supported(cls, config, check_dependencies=False):",
... | 8da7bf663877e0ef0f84513d2568bfd118f29f2c | diff --git a/dvc/remote/base.py b/dvc/remote/base.py
index 6fb0a791f2..41c5e56372 100644
--- a/dvc/remote/base.py
+++ b/dvc/remote/base.py
@@ -33,14 +33,18 @@ def __init__(self, msg):
class RemoteBase(object):
REGEX = None
+ REQUIRES = []
def __init__(self, project, config):
pass
@clas... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Dependency Updates & Env Compatibility"
} |
gradio-app__gradio-7030@9c66fb6 | gradio-app/gradio | Python | 7,030 | add autodocs | ## Description
This is the bulk of the work for autodocumenting custom components. To test this you will need to install `gradio_paramviewer` from pip.
I will be moving this component into gradio core, so we don't need an additional dependency but I haven't quite got round to that.
I also had to remove the re... | 2024-01-15T22:45:39Z | Autogenerate docs for custom components
It would be nice to document a few things for custom components:
* How to import them and use them in a Gradio app (e.g. `from gradio_richtextbox import RichTextbox`)
* What parameters the custom component supports
* What events the custom component supports
This could be... | Maybe the build command can autodocument by default and it can be disabled with an optional argument
Dupe of #6648 | [
{
"body": "It would be nice to document a few things for custom components:\r\n\r\n* How to import them and use them in a Gradio app (e.g. `from gradio_richtextbox import RichTextbox`)\r\n* What parameters the custom component supports\r\n* What events the custom component supports\r\n\r\nThis could be included... | 9201f86450c377f78a77ac003a5d5ff009a8894c | {
"head_commit": "9c66fb63053a2964278d8285886f07f20896fcd9",
"head_commit_message": "add changeset",
"patch_to_review": "diff --git a/.changeset/eager-grapes-relate.md b/.changeset/eager-grapes-relate.md\nnew file mode 100644\nindex 0000000000..87fe2e8325\n--- /dev/null\n+++ b/.changeset/eager-grapes-relate.md\n@... | [
{
"diff_hunk": "@@ -0,0 +1,747 @@\n+import inspect\n+import json\n+import re\n+import types\n+import typing\n+from subprocess import PIPE, Popen\n+\n+\n+def find_first_non_return_key(some_dict):\n+ \"\"\"Finds the first key in a dictionary that is not \"return\".\"\"\"\n+ for key, value in some_dict.items... | bef36f27690b77de5a4857eba269f21c9774976f | diff --git a/.changeset/eager-grapes-relate.md b/.changeset/eager-grapes-relate.md
new file mode 100644
index 0000000000..87fe2e8325
--- /dev/null
+++ b/.changeset/eager-grapes-relate.md
@@ -0,0 +1,7 @@
+---
+"@gradio/app": minor
+"@gradio/paramviewer": minor
+"gradio": minor
+---
+
+feat:add autodocs
diff --git a/grad... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "Documentation Updates"
} |
gradio-app__gradio-6885@f033d16 | gradio-app/gradio | Python | 6,885 | Fix issue with Webcam Recording | ## Description
Fix issue with no video being passed to backend when recording with webcam.
Closes: #6872
## 🎯 PRs Should Target Issues
Before your create a PR, please check to see if there is [an existing issue](https://github.com/gradio-app/gradio/issues) for this change. If not, please create an issue befo... | 2023-12-26T21:33:38Z | gr.Video output showing empty
### Describe the bug
**Problem statment:**
Trying to use gradio Video feature to allow apps to capture video from webcam, when clicking on record and submit video button a function process_video() get trigger, this function takes video as input and process further, looks like the gr.V... | Hi @abidlabs Can you please help on this?. Thanks
I can repro this issue, we'll take a look! | [
{
"body": "### Describe the bug\r\n\r\n**Problem statment:**\r\nTrying to use gradio Video feature to allow apps to capture video from webcam, when clicking on record and submit video button a function process_video() get trigger, this function takes video as input and process further, looks like the gr.Video i... | 3a0a11cf42fd8a5eae80599035ac618f8ff34404 | {
"head_commit": "f033d16adc4494f22634518203d8fbb1df81d36d",
"head_commit_message": "add changeset",
"patch_to_review": "diff --git a/.changeset/few-toes-clap.md b/.changeset/few-toes-clap.md\nnew file mode 100644\nindex 0000000000..5c3451c1f7\n--- /dev/null\n+++ b/.changeset/few-toes-clap.md\n@@ -0,0 +1,7 @@\n+-... | [
{
"diff_hunk": "@@ -88,15 +91,14 @@\n \t\t\tmedia_recorder.stop();\n \t\t\tlet video_blob = new Blob(recorded_blobs, { type: mimeType });\n \t\t\tlet ReaderObj = new FileReader();\n-\t\t\tReaderObj.onload = function (e): void {\n+\t\t\tReaderObj.onload = async function (e): Promise<void> {\n \t\t\t\tif (e.targe... | 04c10fb3da91d392e64c07f23d26c37dbbecc465 | diff --git a/.changeset/few-toes-clap.md b/.changeset/few-toes-clap.md
new file mode 100644
index 0000000000..48db5e0a30
--- /dev/null
+++ b/.changeset/few-toes-clap.md
@@ -0,0 +1,8 @@
+---
+"@gradio/image": patch
+"@gradio/imageeditor": patch
+"@gradio/video": patch
+"gradio": patch
+---
+
+fix:Fix issue with Webcam R... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
gradio-app__gradio-6803@cd1a11e | gradio-app/gradio | Python | 6,803 | Fixes issue 5781: Enables specifying a caching directory for Examples | ## Description
Please include a concise summary, in clear English, of the changes in this pull request. If it closes an issue, please mention it here.
Closes: #5781
## 🎯 PRs Should Target Issues
Before your create a PR, please check to see if there is [an existing issue](https://github.com/gradio-app/grad... | 2023-12-15T04:23:22Z | Specify Example Caching Directory
- [x] I have searched to see if a similar issue already exists.
**Is your feature request related to a problem? Please describe.**
Would be great to specify the directory gradio uses to cache examples. This would allow developers to save the cache to persistent storage on HF Sp... | Heya, could you please elaborate your request. I'm interested on working on this but need some guidance. thank you <3
@freddyaboulton Why is this request only examples related? I think Gradio is using Python's `tempfile` module. You can actual specifiy the directory via ENV if this is what you are looking for. From my ... | [
{
"body": "- [x] I have searched to see if a similar issue already exists.\r\n\r\n\r\n**Is your feature request related to a problem? Please describe.** \r\nWould be great to specify the directory gradio uses to cache examples. This would allow developers to save the cache to persistent storage on HF Spaces.\r... | 50496f967f8209032b753912a4379eb9cea66627 | {
"head_commit": "cd1a11e4c5775945b5fa28cab997513719646805",
"head_commit_message": "backend formatted",
"patch_to_review": "diff --git a/gradio/helpers.py b/gradio/helpers.py\nindex 53fdc799e2..cd8c56aee8 100644\n--- a/gradio/helpers.py\n+++ b/gradio/helpers.py\n@@ -33,7 +33,10 @@\n if TYPE_CHECKING: # Only imp... | [
{
"diff_hunk": "@@ -33,7 +33,10 @@\n if TYPE_CHECKING: # Only import for type checking (to avoid circular imports).\n from gradio.components import Component\n \n-CACHED_FOLDER = \"gradio_cached_examples\"\n+CACHED_FOLDER = str(\n+ Path(os.environ.get(\"GRADIO_EXAMPLES_CACHE\") or \"gradio_cached_exampl... | ba57787f2c9dd683d5e989cfaab2a61ea8eeda73 | diff --git a/.changeset/spicy-wings-thank.md b/.changeset/spicy-wings-thank.md
new file mode 100644
index 0000000000..3cf89b5488
--- /dev/null
+++ b/.changeset/spicy-wings-thank.md
@@ -0,0 +1,5 @@
+---
+"gradio": minor
+---
+
+feat:Fixes issue 5781: Enables specifying a caching directory for Examples
diff --git a/gradi... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "New Feature Additions"
} |
gradio-app__gradio-6826@8cc9d2c | gradio-app/gradio | Python | 6,826 | Add sample rate config option to `gr.Audio()` | ## Description
Closes: #6567
See Issue for background.
Note: Normally the sample rate should be the same as the source audio, but since I did not find an easy way to get the sampled audio of the source audio, set it to 44100Hz for now.
## 🎯 PRs Should Target Issues
Before your create a PR, please check to... | 2023-12-18T12:19:37Z | Trimming audio changes the sample rate
### Describe the bug
When using the trimming feature on an uploaded audio file, the sample rate is changed to 8 kHz for a 44.1 kHz file.
### Have you searched existing issues? 🔎
- [X] I have searched and found no existing issues
### Reproduction
```
import librosa
import... | @hannahblair
I have also encountered this strange problem. I am in the process of doing so, but will report the results of my investigation.
The audio trimming function is implemented on the JavaScript (Svelte) side by sourcing the AudioBuffer obtained from WaveSurfer.js.
However, if the sample rate is not specifie... | [
{
"body": "### Describe the bug\n\nWhen using the trimming feature on an uploaded audio file, the sample rate is changed to 8 kHz for a 44.1 kHz file. \n\n### Have you searched existing issues? 🔎\n\n- [X] I have searched and found no existing issues\n\n### Reproduction\n\n```\r\nimport librosa\r\nimport gradi... | 44c53d9bde7cab605b7dbd16331683d13cae029e | {
"head_commit": "8cc9d2c85e6632fa1c95a95fc933ec5ffdf52f9f",
"head_commit_message": "Merge branch 'main' into main",
"patch_to_review": "diff --git a/.changeset/weak-streets-check.md b/.changeset/weak-streets-check.md\nnew file mode 100644\nindex 0000000000..991d94d657\n--- /dev/null\n+++ b/.changeset/weak-street... | [
{
"diff_hunk": "@@ -104,7 +104,8 @@\n \t\tdragToSeek: true,\n \t\tnormalize: true,\n \t\tminPxPerSec: 20,\n-\t\tmediaControls: waveform_options.show_controls\n+\t\tmediaControls: waveform_options.show_controls,\n+\t\tsampleRate: 44100",
"line": null,
"original_line": 108,
"original_start_line": null... | 0b2e602f5e5a42055f67e5487276a3168a9294bf | diff --git a/.changeset/weak-streets-check.md b/.changeset/weak-streets-check.md
new file mode 100644
index 0000000000..4ba7eac331
--- /dev/null
+++ b/.changeset/weak-streets-check.md
@@ -0,0 +1,6 @@
+---
+"@gradio/audio": minor
+"gradio": minor
+---
+
+fix:Add sample rate config option to `gr.Audio()`
diff --git a/gra... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
gradio-app__gradio-6436@a7ff556 | gradio-app/gradio | Python | 6,436 | Custom Component CLI Improvements | ## Description
Closes: #6354
Closes: #6349
Summary of changes:
* The `gradio cc create` command now asks users to specify some project metadata as suggested in #6354. There's a cli flag to disable this and answering the questions is optional. Adding the keywords will help with custom component discoverability... | 2023-11-15T16:54:18Z | Improve the custom component deploy dockerfile
- [ ] I have searched to see if a similar issue already exists.
We should add the following lines to the `Dockerfile` used in custom component demos so that developers can download transformers models without getting an error that the cache is not set.
```
RUN mkdir... | Thanks @duerrsimon ! I like the idea of optionally setting more config via the cli.
BTW `publish` already supports accounts with 2fa. Use the username `__token__` and the password is your API key. Will make this clearer. | [
{
"body": "- [ ] I have searched to see if a similar issue already exists.\r\n\r\nWe should add the following lines to the `Dockerfile` used in custom component demos so that developers can download transformers models without getting an error that the cache is not set.\r\n\r\n```\r\nRUN mkdir -p /tmp/cache/\r\... | f816136a039fa6011be9c4fb14f573e4050a681a | {
"head_commit": "a7ff5563403fe1840a82c2ef7d3061232721693c",
"head_commit_message": "Fix link:",
"patch_to_review": "diff --git a/.changeset/long-ways-switch.md b/.changeset/long-ways-switch.md\nnew file mode 100644\nindex 0000000000..187d7f6488\n--- /dev/null\n+++ b/.changeset/long-ways-switch.md\n@@ -0,0 +1,6 @... | [
{
"diff_hunk": "@@ -1,5 +1,7 @@\n export const redirects = {\n-\t\"/guides/creating-a-new-component\": \"/guides/five-minute-guide\",\n+\t\"/guides/creating-a-new-component\":\n+\t\t\"/guides/custom-components-in-five-minutes\",\n+\t\"/guides/five-minute-guide\": \"/guides/custom-components-in-five-minutes\",",... | 7d3187de621a39a3ee0e8c3ca698993b729f2869 | diff --git a/.changeset/long-ways-switch.md b/.changeset/long-ways-switch.md
new file mode 100644
index 0000000000..187d7f6488
--- /dev/null
+++ b/.changeset/long-ways-switch.md
@@ -0,0 +1,6 @@
+---
+"gradio": minor
+"website": minor
+---
+
+feat:Custom Component CLI Improvements
diff --git a/gradio/cli/commands/compon... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Code Refactoring / Architectural Improvement"
} |
gradio-app__gradio-6344@6dc1b11 | gradio-app/gradio | Python | 6,344 | PDF component custom component guide | ## Description
Closes #2031
We should have a series of step-by-step guides for creating custom components.
Rendering a PDF in js is actually tricky. So we should have easier guides too and order them by difficulty.
## 🎯 PRs Should Target Issues
Before your create a PR, please check to see if there is [an ... | 2023-11-08T21:42:54Z | PDF display in a block
- I have searched to see if a similar issue already exists but I can't find any solution.
- I am working on a dashboard to demo a model that classifies articles and output tags, and I need the users to correct the results/output of the model.
**Solution**
I would like to have a feature... | Thanks @BouzidiImen for the suggestion. Agree that this would be a useful component!
https://github.com/vinodnimbalkar/svelte-pdf could be a good candidate for integration
Any thoughts on this @abidlabs ?
Hi! We've now made it possible for Gradio users to create their own custom components -- meaning that you can write... | [
{
"body": "- I have searched to see if a similar issue already exists but I can't find any solution.\r\n- I am working on a dashboard to demo a model that classifies articles and output tags, and I need the users to correct the results/output of the model. \r\n\r\n\r\n**Solution** \r\nI would like to have a fe... | 4d3aad33a0b66639dbbb2928f305a79fb7789b2d | {
"head_commit": "6dc1b1147374ebd8bf22429223c3bfc11d95b1af",
"head_commit_message": "format",
"patch_to_review": "diff --git a/.changeset/dirty-wasps-divide.md b/.changeset/dirty-wasps-divide.md\nnew file mode 100644\nindex 0000000000..a27b8528ed\n--- /dev/null\n+++ b/.changeset/dirty-wasps-divide.md\n@@ -0,0 +1,... | [
{
"diff_hunk": "@@ -0,0 +1,672 @@\n+# Case Study: A Component to Display PDFs\n+\n+Let's work through an example of building a custom gradio component for displaying PDF files.\n+This component will come in handy for showcasing [document question answering](https://huggingface.co/models?pipeline_tag=document-qu... | 6effb86d8bd318afb6328a4e7232112d416ad973 | diff --git a/.changeset/dirty-wasps-divide.md b/.changeset/dirty-wasps-divide.md
new file mode 100644
index 0000000000..a27b8528ed
--- /dev/null
+++ b/.changeset/dirty-wasps-divide.md
@@ -0,0 +1,5 @@
+---
+"website": minor
+---
+
+feat:PDF component custom component guide
diff --git a/guides/05_custom-components/07_pdf... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
huggingface__trl-2606@8efb4be | huggingface/trl | Python | 2,606 | 🏆 Custom reward function for GRPO and shiny doc | # What does this PR do?
<!--
Congratulations! You've made it this far! You're not quite done yet though.
Once merged, your PR is going to appear in the release notes with the title you set, so make sure it's a great title that fully reflects the extent of your awesome contribution.
Then, please replace this w... | 2025-01-22T16:57:10Z | Add the training method for DeepSeek-R1
### Feature request
The pure RL method that has been used in training DeepSeek-R1 seems very cool and i think the community will apprechiate it if we can have our hands on it.
### Motivation
DeepSeek-R1 is better in a lot of areas
### Your contribution
If there is something ... | The training method for DeepSeek-R1 is GRPO, right?
> The training method for DeepSeek-R1 is GRPO, right?
Yeah, but they don't use a reward model. | [
{
"body": "### Feature request\n\nThe pure RL method that has been used in training DeepSeek-R1 seems very cool and i think the community will apprechiate it if we can have our hands on it.\n\n### Motivation\n\nDeepSeek-R1 is better in a lot of areas\n\n### Your contribution\n\nIf there is something i can help ... | 949db2357e62d2f0a34decfc5e87eeeea0c6d72c | {
"head_commit": "8efb4be2ebfdd2a25147cd3d2d7d695381f8e2b2",
"head_commit_message": "it's probably the best of both worlds [ci skip]",
"patch_to_review": "diff --git a/docs/source/grpo_trainer.md b/docs/source/grpo_trainer.md\nindex 59abe04356..a304f52610 100644\n--- a/docs/source/grpo_trainer.md\n+++ b/docs/sour... | [
{
"diff_hunk": "@@ -51,22 +48,89 @@\n \n \n class GRPOTrainer(Trainer):\n+ \"\"\"\n+ Trainer for the Group Relative Policy Optimization (GRPO) method. This algorithm was initially proposed in the\n+ paper [DeepSeekMath: Pushing the Limits of Mathematical Reasoning in Open Language Models](https://huggi... | be78d9f2215bb66993de249304e7750dc868c94e | diff --git a/.github/workflows/build_pr_documentation.yml b/.github/workflows/build_pr_documentation.yml
index bf72dc7c1e..acc8d16d35 100644
--- a/.github/workflows/build_pr_documentation.yml
+++ b/.github/workflows/build_pr_documentation.yml
@@ -9,7 +9,7 @@ concurrency:
jobs:
build:
- uses: huggingface/doc-bu... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
huggingface__trl-2426@c0ed5dd | huggingface/trl | Python | 2,426 | 🧑🍳 Add precompute batch size argument in `DPOTrainer` for reference model | # What does this PR do?
<!--
Congratulations! You've made it this far! You're not quite done yet though.
Once merged, your PR is going to appear in the release notes with the title you set, so make sure it's a great title that fully reflects the extent of your awesome contribution.
Then, please replace this w... | 2024-12-02T14:17:51Z | Adding precompute batch size argument in DPOTrainer for reference model
### Feature request
Proposing adding a new configuration parameter `precompute_ref_batch_size` to allow users to specify a different (likely larger) batch size specifically for the reference model precomputation phase. This would:
1. Speed up t... | Thanks for this suggestion @SwayamInSync!
Do you have any idea of the gain in speed?
If you've a working implementation, feel free to submit a PR so that we can test and discuss the code
> Thanks for this suggestion @SwayamInSync! Do you have any idea of the gain in speed? If you've a working implementation, feel fre... | [
{
"body": "### Feature request\n\nProposing adding a new configuration parameter `precompute_ref_batch_size` to allow users to specify a different (likely larger) batch size specifically for the reference model precomputation phase. This would:\r\n\r\n1. Speed up the precomputation phase by processing more exam... | 148b5923135e6eaa1e1dfd2c53ce45b274ec3127 | {
"head_commit": "c0ed5dd3540967662b5f131791e19168382ea48b",
"head_commit_message": "Update trl/trainer/dpo_config.py\n\nCo-authored-by: Quentin Gallouédec <45557362+qgallouedec@users.noreply.github.com>",
"patch_to_review": "diff --git a/tests/test_dpo_trainer.py b/tests/test_dpo_trainer.py\nindex 1e6e8e67ad..ea... | [
{
"diff_hunk": "@@ -94,6 +94,10 @@ class DPOConfig(TrainingArguments):\n precompute_ref_log_probs (`bool`, *optional*, defaults to `False`):\n Whether to precompute reference model log probabilities for training and evaluation datasets. This is\n useful when training without the ... | 251bdb2a535eeacbcc21eb2100587b161066c5d8 | diff --git a/tests/test_dpo_trainer.py b/tests/test_dpo_trainer.py
index 1e6e8e67ad..ea9c916d76 100644
--- a/tests/test_dpo_trainer.py
+++ b/tests/test_dpo_trainer.py
@@ -350,6 +350,40 @@ def test_dpo_trainer_with_ref_model_is_model(self):
train_dataset=dummy_dataset["train"],
)
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
huggingface__trl-2951@bd9f43b | huggingface/trl | Python | 2,951 | 📇 GRPO: print completions to console and update docs | # What does this PR do?
- Update `GRPOConfig` to replace `log_completions` with `log_completions_steps`
- Add `print_prompt_completions_sample()` utility function for rich console logging
- Modify `GRPOTrainer` to additionally print 5 random prompt-completion pairs every log_completions_steps steps
Fixes #2948 ... | 2025-02-24T20:39:04Z | GPRO: Expand log_completions logic or update docs
### Feature request
Currently, the GRPOConfig docstring for `log_completions` is:
> log_completions (bool, optional, defaults to False) — Whether to log the completions during training.
Which is a bit misleading, given that these are only logged when Weights and Biase... | Cool! WDYT of
```python
from rich.console import Console
from rich.panel import Panel
from rich.table import Table
from rich.text import Text
def print_output_sample(prompts: list[str], completions: list[str], step: int) -> None:
"""Print out a sample of model completions."""
console = Console()
table =... | [
{
"body": "### Feature request\n\nCurrently, the GRPOConfig docstring for `log_completions` is:\n> log_completions (bool, optional, defaults to False) — Whether to log the completions during training.\n\nWhich is a bit misleading, given that these are only logged when Weights and Biases is active.\n\nSuggestion... | 4e0cf01aefc583d80c709ea461244d413699e3ef | {
"head_commit": "bd9f43bfdcf1408a3551ee34bd40e38073159138",
"head_commit_message": "Add rich availability check and use fallback in print_prompt_completions_sample when rich is not available",
"patch_to_review": "diff --git a/trl/trainer/grpo_config.py b/trl/trainer/grpo_config.py\nindex 8386098982..fc4d2cbb92 1... | [
{
"diff_hunk": "@@ -839,22 +846,34 @@ def _generate_and_score_completions(\n self._metrics[mode][\"reward_std\"].append(std_grouped_rewards.mean().item())\n \n if (\n- self.log_completions\n- and self.state.global_step % self.args.logging_steps == 0\n- and \"wand... | 8e15c0879e4307356d8717ac47514d6fbc845f88 | diff --git a/trl/trainer/grpo_config.py b/trl/trainer/grpo_config.py
index 8386098982..c4220d6d72 100644
--- a/trl/trainer/grpo_config.py
+++ b/trl/trainer/grpo_config.py
@@ -112,9 +112,9 @@ class GRPOConfig(TrainingArguments):
set `sync_ref_model=True`.
> Parameters that control the logging
-
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Documentation Updates"
} |
huggingface__trl-2344@7e682fc | huggingface/trl | Python | 2,344 | 📉 Add PEFT support for `PPOTrainer` | # What does this PR do?
This PR provides an initial implementation of PEFT support for PPOTrainer, targeted towards the policy model. The existing functionality remains fully intact and unaffected by these modifications.
The following tasks have been completed:
- Add `peft_config` for `PPOTrainer`
- Add unit test... | 2024-11-11T07:42:01Z | How to Add PEFT to PPO Trainer or PPO Config
I am trying to realize RLHF through PPO.
May I ask how can I realize PEFT in RLHF/PPO. I can see this parameter in DPOTrainer. However, I cannot see that in PPOTrainer. | PPO does not yet support PEFT. But it may be a good enhancement.
Hi @qgallouedec, I'd love to contribute to this enhancement! I noticed that this issue has been open for three months, and I'd like to help bring it forward.
Is there anything specific I should be mindful of as I start on this? Any guidance or notes on... | [
{
"body": "I am trying to realize RLHF through PPO.\r\n\r\nMay I ask how can I realize PEFT in RLHF/PPO. I can see this parameter in DPOTrainer. However, I cannot see that in PPOTrainer.\r\n",
"number": 1916,
"title": "How to Add PEFT to PPO Trainer or PPO Config"
}
] | 21d5baf338be52e21af95d8d0c6cbc4968238181 | {
"head_commit": "7e682fc0f73663176cabda54dcd4dc1c68fb7050",
"head_commit_message": "Merge branch 'main' into feature-ppo-peft",
"patch_to_review": "diff --git a/examples/scripts/ppo/ppo.py b/examples/scripts/ppo/ppo.py\nindex 19036ca7c1..e0dd07bb5a 100644\n--- a/examples/scripts/ppo/ppo.py\n+++ b/examples/script... | [
{
"diff_hunk": "@@ -125,7 +132,32 @@ def __init__(\n )\n self.policy.generation_config.pad_token_id = None # generate tokens without truncation / padding\n \n- self.ref_policy = ref_policy\n+ # peft support\n+ if not is_peft_available() and peft_config is not None:\n+ ... | 4dc7e6fe83016da355db305560f71d2504c499d0 | diff --git a/examples/scripts/ppo/ppo.py b/examples/scripts/ppo/ppo.py
index 19036ca7c1..e0dd07bb5a 100644
--- a/examples/scripts/ppo/ppo.py
+++ b/examples/scripts/ppo/ppo.py
@@ -14,6 +14,7 @@
import shutil
+import torch
from accelerate import PartialState
from datasets import load_dataset
from transformers imp... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
huggingface__trl-2474@8febff8 | huggingface/trl | Python | 2,474 | 🧑🤝🧑 Proper metrics gathering across ranks before logging | according to https://github.com/huggingface/trl/issues/2468
# What does this PR do?
<!--
Congratulations! You've made it this far! You're not quite done yet though.
Once merged, your PR is going to appear in the release notes with the title you set, so make sure it's a great title that fully reflects the exte... | 2024-12-13T17:29:23Z | DPOTrainer log metrics are not gathered and meaned across ranks
### Feature request
synchronize and average metrics across ranks.
### Motivation
current metrics reported are only numbers on rank 0.
```python
metrics[f"{prefix}rewards/chosen"] = chosen_rewards.mean().cpu()
metrics[f"{prefix}rewar... | That's a good point! Feel free to open a PR to fix this. I don't think adding a unittest for this is relevant. If possible, add plots (eg, with wandb) before/after to ensure that we aren't introducing a regression
Ofcourse!
here... | [
{
"body": "### Feature request\n\nsynchronize and average metrics across ranks.\n\n### Motivation\n\ncurrent metrics reported are only numbers on rank 0.\r\n\r\n```python\r\n metrics[f\"{prefix}rewards/chosen\"] = chosen_rewards.mean().cpu()\r\n metrics[f\"{prefix}rewards/rejected\"] = rejected_re... | 52d213173ff844bc2ac5369c22ce35110a2bbe9b | {
"head_commit": "8febff8000da9dafa7dba5ac03a7e32fb3f46d56",
"head_commit_message": "dpo_trainer gather metrics across ranks before logging\n\naccording to https://github.com/huggingface/trl/issues/2468",
"patch_to_review": "diff --git a/trl/trainer/dpo_trainer.py b/trl/trainer/dpo_trainer.py\nindex 7ed0ac387f..f... | [
{
"diff_hunk": "@@ -1424,7 +1424,11 @@ def log(self, logs: dict[str, float], start_time: Optional[float] = None) -> Non\n train_eval = \"train\" if \"loss\" in logs else \"eval\"\n # Add averaged stored metrics to logs\n for key, metrics in self._stored_metrics[train_eval].items():\n- ... | 382c6815f164726f01bd1725d8a6a582aa7d6256 | diff --git a/trl/trainer/bco_trainer.py b/trl/trainer/bco_trainer.py
index 1016c124e6..bdb16b92fb 100644
--- a/trl/trainer/bco_trainer.py
+++ b/trl/trainer/bco_trainer.py
@@ -1238,24 +1238,36 @@ def get_batch_loss_metrics(
chosen_embeddings,
rejected_embeddings,
)
- metrics["de... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
huggingface__trl-2528@1c4e9ed | huggingface/trl | Python | 2,528 | 🫷 Include stop token in policy model's generation_config | Another approach to fix #2387
<!--
Congratulations! You've made it this far! You're not quite done yet though.
Once merged, your PR is going to appear in the release notes with the title you set, so make sure it's a great title that fully reflects the extent of your awesome contribution.
Then, please replace ... | 2024-12-28T13:34:07Z | eos_token config in PPOTrainer
### Feature request
It appears that the generation config in PPOTrainer does not set an eos_token, resulting in each generation process continuing until it reaches the maximum length before stopping, which is quite time-consuming.
### Motivation
If the `eos_token` is set, it will sign... | Thanks for reporting it. Would you like to open a PR to fix it?
@kechunFIVE, @qgallouedec, @dame-cell Seems that current code is inspired by https://iclr-blogposts.github.io/2024/blog/the-n-implementation-details-of-rlhf-with-ppo/, section *General implementation details*, 4.2. Authors tried to recreate results from ... | [
{
"body": "### Feature request\n\nIt appears that the generation config in PPOTrainer does not set an eos_token, resulting in each generation process continuing until it reaches the maximum length before stopping, which is quite time-consuming.\n\n### Motivation\n\nIf the `eos_token` is set, it will significan... | d4222a1e08def2be56572eb2973ef3bf50143a4f | {
"head_commit": "1c4e9edfce5ecce9609dd023f7cb8cc4ffd4ca23",
"head_commit_message": "Fix formatting",
"patch_to_review": "diff --git a/trl/trainer/ppo_trainer.py b/trl/trainer/ppo_trainer.py\nindex 51897eeb44..723c3d8132 100644\n--- a/trl/trainer/ppo_trainer.py\n+++ b/trl/trainer/ppo_trainer.py\n@@ -138,10 +138,1... | [
{
"diff_hunk": "@@ -138,10 +138,18 @@ def __init__(\n if data_collator is None:\n data_collator = DataCollatorWithPadding(self.processing_class)\n \n- self.policy_model.generation_config.eos_token_id = (\n- None # disable `pad_token_id` and `eos_token_id` because we just w... | 6d78514a70dbaba87524a4a3f526c3dc9d785ad0 | diff --git a/trl/trainer/ppo_trainer.py b/trl/trainer/ppo_trainer.py
index ef29461a70..83926cfd6a 100644
--- a/trl/trainer/ppo_trainer.py
+++ b/trl/trainer/ppo_trainer.py
@@ -138,10 +138,18 @@ def __init__(
if data_collator is None:
data_collator = DataCollatorWithPadding(self.processing_class)
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
gradio-app__gradio-5602@6189fb7 | gradio-app/gradio | Python | 5,602 | Ensure `HighlightedText` with `merge_elements` loads without a value | ## Description
`merge_elements()` was trying to run on initial load even when `value` was empty, resulting in an error on load. I've added a flag to check that `value` isn't empty before we run that func.
demo
```
import gradio as gr
with gr.Blocks() as demo:
ht = gr.HighlightedText(
combine_a... | 2023-09-19T12:22:07Z | Stuck with `HighlightedText` when using `combine_adjacent` without a `value`
### Describe the bug
There is a bug in the `gr.HighlightedText` component when using the `combine_adjacent=True` parameter without providing a `value`. When these parameters are used, the application becomes stuck on "Loading...".
### Have y... | I did some investigation and found that the issue may be caused by the following code in `merge_elements` function from the file [js/highlightedtext/utils.ts](https://github.com/gradio-app/gradio/blob/52f7831751b432411e109bd41add4ab286023a8e/js/highlightedtext/utils.ts#L53). Specifically, the following code does not ha... | [
{
"body": "### Describe the bug\n\nThere is a bug in the `gr.HighlightedText` component when using the `combine_adjacent=True` parameter without providing a `value`. When these parameters are used, the application becomes stuck on \"Loading...\".\n\n### Have you searched existing issues? 🔎\n\n- [X] I have sea... | ff6f5250a7c5cf2a2fe5c9585689dcd70c5c18ad | {
"head_commit": "6189fb72bbbb2e2fc745f641baa00ea041f069fc",
"head_commit_message": "add changeset",
"patch_to_review": "diff --git a/.changeset/chubby-hounds-itch.md b/.changeset/chubby-hounds-itch.md\nnew file mode 100644\nindex 0000000000..5421f67bdf\n--- /dev/null\n+++ b/.changeset/chubby-hounds-itch.md\n@@ -... | [
{
"diff_hunk": "@@ -45,29 +45,32 @@ export function correct_color_map(\n export function merge_elements(\n \tvalue: HighlightValueType[],\n \tmergeMode: \"empty\" | \"equal\"\n-): HighlightValueType[] {\n-\tlet result: HighlightValueType[] = [];\n-\tlet tempStr: string | null = null;\n-\tlet tempVal: string | n... | fef27e53a84e4901eb3084784159a495224fab78 | diff --git a/.changeset/chubby-hounds-itch.md b/.changeset/chubby-hounds-itch.md
new file mode 100644
index 0000000000..2991835cfd
--- /dev/null
+++ b/.changeset/chubby-hounds-itch.md
@@ -0,0 +1,6 @@
+---
+"@gradio/highlightedtext": patch
+"gradio": patch
+---
+
+fix:Ensure `HighlightedText` with `merge_elements` loads... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
hpcaitech__ColossalAI-6059@802df11 | hpcaitech/ColossalAI | Python | 6,059 | [fp8] Disable all_gather intranode. Disable Redundant all_gather fp8 | ## 📌 Checklist before creating the PR
- [x] I have created an issue for this PR for traceability
- [x] The title follows the standard format: `[doc/gemini/tensor/...]: A concise description`
- [x] I have added relevant tags if possible for us to better distinguish different PRs
- [x] I have installed pre-commit:... | 2024-09-11T09:37:11Z | [BUG]: Disable all_gather intranode. Disable Redundant all_gather fp8
### Is there an existing issue for this bug?
- [X] I have searched the existing issues
### 🐛 Describe the bug
Disable all_gather intranode. Disable Redundant all_gather fp8
### Environment
_No response_ | [
{
"body": "### Is there an existing issue for this bug?\r\n\r\n- [X] I have searched the existing issues\r\n\r\n### 🐛 Describe the bug\r\n\r\nDisable all_gather intranode. Disable Redundant all_gather fp8\r\n\r\n### Environment\r\n\r\n_No response_",
"number": 6058,
"title": "[BUG]: Disable all_gather ... | a35a078f0849cf1c805dbae94abe5476b1615ca0 | {
"head_commit": "802df11d53de114e397f231f726697c003c636c8",
"head_commit_message": "fix pytest",
"patch_to_review": "diff --git a/colossalai/quantization/fp8.py b/colossalai/quantization/fp8.py\nindex 388bbde052d2..3d5096c67c6c 100644\n--- a/colossalai/quantization/fp8.py\n+++ b/colossalai/quantization/fp8.py\n@... | [
{
"diff_hunk": "@@ -11,6 +11,8 @@\n SUPPORT_TORCH_COMPILE = Version(torch.__version__) >= Version(\"2.4.0\")\n SCALE_BYTES = 4\n \n+cuda_arch = int(\"\".join(str(i) for i in torch.cuda.get_device_capability()))",
"line": null,
"original_line": 14,
"original_start_line": null,
"path": "colossalai... | b1c1fcabe01c923dd777a2f34c6f521a782306e4 | diff --git a/colossalai/quantization/fp8.py b/colossalai/quantization/fp8.py
index 388bbde052d2..8243a29ac825 100644
--- a/colossalai/quantization/fp8.py
+++ b/colossalai/quantization/fp8.py
@@ -10,6 +10,10 @@
SUPPORT_TORCH_COMPILE = Version(torch.__version__) >= Version("2.4.0")
SCALE_BYTES = 4
+try:
+ cuda_arc... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} | |
huggingface__trl-2246@10bffa0 | huggingface/trl | Python | 2,246 | 🔀 Rename `get_batch_sample` and add `num_items_in_batch` to `compute_loss` | # What does this PR do?
follows https://github.com/huggingface/transformers/pull/34198
## Before submitting
- [ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
- [ ] Did you read the [contributor guideline](https://github.com/huggingface/trl/blob/main/CONTRIB... | 2024-10-18T09:22:37Z | TypeError: XPOTrainer.training_step() takes 3 positional arguments but 4 were given
### System Info
- Platform: Linux-5.4.0-42-generic-x86_64-with-glibc2.35
- Python version: 3.10.15
- PyTorch version: 2.5.0
- CUDA device(s): NVIDIA A800-SXM4-80GB, NVIDIA A800-SXM4-80GB, NVIDIA A800-SXM4-80GB, NVIDIA A800-SXM4-80... | [
{
"body": "### System Info\n\n- Platform: Linux-5.4.0-42-generic-x86_64-with-glibc2.35\r\n- Python version: 3.10.15\r\n- PyTorch version: 2.5.0\r\n- CUDA device(s): NVIDIA A800-SXM4-80GB, NVIDIA A800-SXM4-80GB, NVIDIA A800-SXM4-80GB, NVIDIA A800-SXM4-80GB, NVIDIA A800-SXM4-80GB, NVIDIA A800-SXM4-80GB, NVIDIA A8... | a67f2143c38d6520be8735463ce715ad5c281db8 | {
"head_commit": "10bffa0f5acaa8cc85983599d11043660061ba27",
"head_commit_message": "`num_items_in_batch` in `training_step`",
"patch_to_review": "diff --git a/trl/trainer/bco_trainer.py b/trl/trainer/bco_trainer.py\nindex 91461a9b0d..c6ce2d4902 100644\n--- a/trl/trainer/bco_trainer.py\n+++ b/trl/trainer/bco_trai... | [
{
"diff_hunk": "@@ -866,7 +867,7 @@ def compute_loss(\n return (loss, metrics)\n return loss\n \n- def get_batch_samples(self, model, batch: Dict[str, torch.LongTensor]) -> Tuple[str, str]:\n+ def generate_from_model(self, model, batch: Dict[str, torch.LongTensor]) -> Tuple[str, str]:"... | ca2d98f26d47be3161e48a8cc29fb38b9c6679c5 | diff --git a/trl/trainer/bco_trainer.py b/trl/trainer/bco_trainer.py
index 91461a9b0d..c6ce2d4902 100644
--- a/trl/trainer/bco_trainer.py
+++ b/trl/trainer/bco_trainer.py
@@ -1260,6 +1260,7 @@ def compute_loss(
model: Union[PreTrainedModel, nn.Module],
inputs: Dict[str, Union[torch.Tensor, Any]],
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
gradio-app__gradio-5590@10f6251 | gradio-app/gradio | Python | 5,590 | Attach `elem_classes` selectors to layout elements, and an id to the Tab button (for targeting via CSS/JS) | This PR does two things:
1. It passes the `elem_classes` attribute to the Blocks layouts (e.g. Row, Accordion, Tab, etc.) We had these attributes set up correctly in the frontend, but we were never passing them in from the frontend
2. For the `TabItem`, the `elem_id` would get attached to the div holding the tab ... | 2023-09-18T20:24:00Z | Add id, class, and or attribute to a Tab's button
**Is your feature request related to a problem? Please describe.**
I have Javascript that is added to the page which will activate a tab during specific instances. I do this by scanning the tab buttons in the tab bar and checking the label of each one to know which o... | I'm hesitant to add two separate parameters. However, what if we were to automatically set the btn id to be "{elem_id}-btn", allowing you to target it directly?
that would be perfect | [
{
"body": "**Is your feature request related to a problem? Please describe.** \r\nI have Javascript that is added to the page which will activate a tab during specific instances. I do this by scanning the tab buttons in the tab bar and checking the label of each one to know which one to activate, however, an i... | ff6f5250a7c5cf2a2fe5c9585689dcd70c5c18ad | {
"head_commit": "10f6251db4774679e368c933f24250018ee6c2b6",
"head_commit_message": "add changeset",
"patch_to_review": "diff --git a/.changeset/real-items-cover.md b/.changeset/real-items-cover.md\nnew file mode 100644\nindex 0000000000..b134d02c78\n--- /dev/null\n+++ b/.changeset/real-items-cover.md\n@@ -0,0 +1... | [
{
"diff_hunk": "@@ -58,11 +59,15 @@\n \t<div class=\"tab-nav scroll-hide\">\n \t\t{#each tabs as t, i (t.id)}\n \t\t\t{#if t.id === $selected_tab}\n-\t\t\t\t<button class=\"selected\">\n+\t\t\t\t<button\n+\t\t\t\t\tclass=\"selected\"\n+\t\t\t\t\t{...elem_id ? { id: t.elem_id + \"-button\" } : {}}",
"line": ... | 4efb03039505379cfbb5c47e78a9ced6bd992d70 | diff --git a/.changeset/real-items-cover.md b/.changeset/real-items-cover.md
new file mode 100644
index 0000000000..b134d02c78
--- /dev/null
+++ b/.changeset/real-items-cover.md
@@ -0,0 +1,7 @@
+---
+"@gradio/tabitem": patch
+"@gradio/tabs": patch
+"gradio": patch
+---
+
+feat:Attach `elem_classes` selectors to layout ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
gradio-app__gradio-5436@cbff25c | gradio-app/gradio | Python | 5,436 | api_open does not take precedence over show_api | ## Description
The two parameters now operate independently. If api_open=False, then the api_page will still be shown. This is a slight change in behavior but users still have the ability to hide them if they wish. If we automatically hide the api docs, user's don't have a way to override that.
Closes: #5434
... | 2023-09-06T20:05:07Z | `show_api` doesn't work when queue is enabled
### Describe the bug
Setting `show_api=False` doesn't have any effect if queueing is enabled
### Have you searched existing issues? 🔎
- [X] I have searched and found no existing issues
### Reproduction
```py
import gradio as gr
with gr.Blocks() as demo... | [
{
"body": "### Describe the bug\r\n\r\nSetting `show_api=False` doesn't have any effect if queueing is enabled \r\n\r\n### Have you searched existing issues? 🔎\r\n\r\n- [X] I have searched and found no existing issues\r\n\r\n### Reproduction\r\n\r\n```py\r\nimport gradio as gr\r\n\r\nwith gr.Blocks() as demo:... | 26fef8c7f85a006c7e25cdbed1792df19c512d02 | {
"head_commit": "cbff25cf6bcfde96ef3e7015d56b9a56abaab21c",
"head_commit_message": "Merge branch '5434-show-api-bugfix' of github.com:gradio-app/gradio into 5434-show-api-bugfix",
"patch_to_review": "diff --git a/.changeset/social-bushes-study.md b/.changeset/social-bushes-study.md\nnew file mode 100644\nindex 0... | [
{
"diff_hunk": "@@ -1778,7 +1778,7 @@ def launch(\n ssl_keyfile_password: If a password is provided, will use this with the ssl certificate for https.\n ssl_verify: If False, skips certificate validation which allows self-signed certificates to be used.\n quiet: If True, supp... | 5911a67a65a7b841b12a6cf8d64b0c96b1ee7eea | diff --git a/.changeset/social-bushes-study.md b/.changeset/social-bushes-study.md
new file mode 100644
index 0000000000..294de4f856
--- /dev/null
+++ b/.changeset/social-bushes-study.md
@@ -0,0 +1,5 @@
+---
+"gradio": patch
+---
+
+fix:api_open does not take precedence over show_api
diff --git a/gradio/blocks.py b/gr... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
gradio-app__gradio-5400@81adc2e | gradio-app/gradio | Python | 5,400 | Allow interactive input in `gr.HighlightedText` | ## Description
This PR allows gr.HighlightedText to be used as an input.
- Supports categories mode and scores mode
- Double click on a word or highlight any selection of words within the value passed in to the component
- A label will appear, with the text `label` by default (if in `categories` mode; will... | 2023-09-01T13:09:40Z | Input in HighlightedText
- [*] I have searched to see if a similar issue already exists.
**Is your feature request related to a problem? Please describe.**
As it stands highlighted text can only be used for output (i.e. in case of demonstrating a NER model). There could be a lot of use to adding interactivity to ... | Hi @shahbuland thanks for creating the issue! We've talked a little bit about this internally but haven't had a chance to implement. I do think this would be a good addition to the library to work on in the next few weeks. @dawoodkhan82 thoughts on this?
Any update on this? I'd also be interested in allowing users to ... | [
{
"body": "- [*] I have searched to see if a similar issue already exists.\r\n\r\n**Is your feature request related to a problem? Please describe.** \r\nAs it stands highlighted text can only be used for output (i.e. in case of demonstrating a NER model). There could be a lot of use to adding interactivity to ... | 05715f5599ae3e928d3183c7b0a7f5291f843a96 | {
"head_commit": "81adc2e7a4d7e3a32f3e1bd833691492c5fa8ebc",
"head_commit_message": "backend test tweaks",
"patch_to_review": "diff --git a/.changeset/ripe-ideas-rest.md b/.changeset/ripe-ideas-rest.md\nnew file mode 100644\nindex 0000000000..f45cd4927d\n--- /dev/null\n+++ b/.changeset/ripe-ideas-rest.md\n@@ -0,0... | [
{
"diff_hunk": "@@ -49,6 +45,7 @@ def __init__(\n visible: bool = True,\n elem_id: str | None = None,\n elem_classes: list[str] | str | None = None,\n+ interactive: bool = False,",
"line": null,
"original_line": 48,
"original_start_line": null,
"path": "gradio/comp... | e8eaefe9e3480e94da19c9181897e8dfb7923a57 | diff --git a/.changeset/ripe-ideas-rest.md b/.changeset/ripe-ideas-rest.md
new file mode 100644
index 0000000000..f45cd4927d
--- /dev/null
+++ b/.changeset/ripe-ideas-rest.md
@@ -0,0 +1,7 @@
+---
+"@gradio/app": minor
+"@gradio/highlightedtext": minor
+"gradio": minor
+---
+
+feat:Allow interactive input in `gr.Highlig... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
huggingface__trl-2193@39d23d2 | huggingface/trl | Python | 2,193 | `skip_prompt=True` in `TextIteratorStreamer` | # What does this PR do?
Adds `skip_prompt=True` in `TextIteratorStreamer`.
Instead of the output in https://github.com/huggingface/trl/issues/1866#issuecomment-2396987672, you get:
```
<quentin_gallouedec>:
Hello, world!
<microsoft/Phi-3-mini-4k-instruct>:
This is a simple greeting message. You can imagi... | 2024-10-07T13:51:34Z | Bugs in examples/scripts/chat.py
I'm trying to use this script to chat with microsoft/Phi-3-mini-4k-instruct, but an issue, possibly with the tokenizer, is formatting the chat incorrectly. Loading a local PEFT adapter for microsoft/Phi-3-mini-4k-instruct creates further issues. I ended up making my own chat script beca... | Hi, thanks for reporting.
Can you provide the code to reproduce, and be more specific than "an issue [...] is formatting the chat incorrectly", or "further issues"? This would enable better referencing and help us address the issue.
Currently, running
```sh
python examples/scripts/chat.py --model_name_or_path m... | [
{
"body": "I'm trying to use this script to chat with microsoft/Phi-3-mini-4k-instruct, but an issue, possibly with the tokenizer, is formatting the chat incorrectly. Loading a local PEFT adapter for microsoft/Phi-3-mini-4k-instruct creates further issues. I ended up making my own chat script because of these i... | 9aa022503cbd73f3841ca60592a446f8963a9ae6 | {
"head_commit": "39d23d2276ae66e3759e67e0759a7791c0fbf2e8",
"head_commit_message": "Merge branch 'main' into fix-chat-cli",
"patch_to_review": "diff --git a/trl/commands/cli.py b/trl/commands/cli.py\nindex 3a9f8f83a3..55b48882d7 100644\n--- a/trl/commands/cli.py\n+++ b/trl/commands/cli.py\n@@ -96,6 +96,8 @@ def ... | [
{
"diff_hunk": "@@ -96,6 +96,8 @@ def train(command_name):\n encoding=\"utf-8\",\n cwd=os.getcwd(),\n env=os.environ.copy(),\n+ stdout=subprocess.PIPE,\n+ stderr=subprocess.PIPE,",
"line": null,
"original_line": 100,
"original_start_line": 99... | b784914ebc658593d56378d3fbb3057bc288ac1f | diff --git a/examples/scripts/chat.py b/examples/scripts/chat.py
index 99139f209c..d29200055c 100644
--- a/examples/scripts/chat.py
+++ b/examples/scripts/chat.py
@@ -273,7 +273,7 @@ def chat_cli():
user = args.user
model, tokenizer = load_model_and_tokenizer(args)
- generation_streamer = TextIterato... | {
"difficulty": "medium",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
gradio-app__gradio-5232@5b83994 | gradio-app/gradio | Python | 5,232 | `gr.Radio` and `gr.CheckboxGroup` can now accept different names and values | The `choices` parameter in `gr.Radio` and `gr.CheckboxGroup` can now accept tuples in the form `(name, value)` where the `name` is the string that is displayed in the frontend while `value` is the string or numeric that is passed into the backend. This answers a long-standing request, closes #4754
Adds stories for ... | 2023-08-15T14:53:57Z | `gr.Radio` and `gr.CheckboxGroup` choices display text.
- [x] I have searched to see if a similar issue already exists.
**Is your feature request related to a problem? Please describe.**
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Usually for the `gr.Radio` an... | Similar to #3019, we should probably tackle them together | [
{
"body": "- [x] I have searched to see if a similar issue already exists.\r\n\r\n\r\n**Is your feature request related to a problem? Please describe.** \r\nA clear and concise description of what the problem is. Ex. I'm always frustrated when [...]\r\n\r\nUsually for the `gr.Radio` and `gr.CheckboxGroup`, the... | b3e50db92f452f376aa2cc081326d40bb69d6dd7 | {
"head_commit": "5b839947b47290fbfd21fb24c3888f8bbf50e167",
"head_commit_message": "fix unit test",
"patch_to_review": "diff --git a/.changeset/cold-steaks-cover.md b/.changeset/cold-steaks-cover.md\nnew file mode 100644\nindex 0000000000..b8e104d1f9\n--- /dev/null\n+++ b/.changeset/cold-steaks-cover.md\n@@ -0,0... | [
{
"diff_hunk": "@@ -9,7 +9,7 @@\n \texport let visible = true;\n \texport let value: string[] = [];\n \texport let value_is_output = false;\n-\texport let choices: string[];\n+\texport let choices: string[][];",
"line": null,
"original_line": 12,
"original_start_line": null,
"path": "js/checkbox... | ed3bbbd50fffc6feeb59c0d9e707b303a6832f98 | diff --git a/.changeset/cold-steaks-cover.md b/.changeset/cold-steaks-cover.md
new file mode 100644
index 0000000000..b8e104d1f9
--- /dev/null
+++ b/.changeset/cold-steaks-cover.md
@@ -0,0 +1,7 @@
+---
+"@gradio/checkboxgroup": minor
+"@gradio/radio": minor
+"gradio": minor
+---
+
+feat:`gr.Radio` and `gr.CheckboxGroup... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
gradio-app__gradio-5342@3e528f3 | gradio-app/gradio | Python | 5,342 | significantly improve the performance of `gr.Dataframe` for large datasets | ## Description
Creating PR to do some more testing but I think this is working.
You can test with the following code:
```python
import gradio as gr
df = [[f"col: {i} -- row:{j}" for j in range(1, 11)] for i in range(1, 10000)]
with gr.Blocks() as demo:
gr.DataFrame(df, headers=list(range(1, 11)), i... | 2023-08-25T17:10:47Z | datafrme is slow, make it go brrr
- [x] I have searched to see if a similar issue already exists.
This is separate from pagination / max_rows, although it could _replace_ pagination.
If you have a large dataset then the performance can get pretty bad with the current dataframe. | Motion to rename the issue to "datafrme is slow, make it go brr" | [
{
"body": "- [x] I have searched to see if a similar issue already exists.\r\n\r\nThis is separate from pagination / max_rows, although it could _replace_ pagination.\r\n\r\nIf you have a large dataset then the performance can get pretty bad with the current dataframe.",
"number": 5343,
"title": "datafr... | 7ab4b70f6821afb4e85cef225d1235c19df8ebbf | {
"head_commit": "3e528f3972631b7ca9e983e2b22a97a445174fa9",
"head_commit_message": "add changeset",
"patch_to_review": "diff --git a/.changeset/five-gifts-bathe.md b/.changeset/five-gifts-bathe.md\nnew file mode 100644\nindex 0000000000..aead67b0a9\n--- /dev/null\n+++ b/.changeset/five-gifts-bathe.md\n@@ -0,0 +1... | [
{
"diff_hunk": "@@ -722,19 +808,22 @@\n \t}\n \n \ttable {\n+\t\tposition: absolute;\n+\t\topacity: 0;\n \t\ttransition: 150ms;\n \t\twidth: var(--size-full);\n \t\ttable-layout: auto;\n-\t\toverflow: hidden;\n+\t\t/* overflow: hidden; */\n \t\tcolor: var(--body-text-color);\n \t\tfont-size: var(--input-text-si... | 5212493919791fddfc3282de0cd8512079f2d756 | diff --git a/.changeset/five-gifts-bathe.md b/.changeset/five-gifts-bathe.md
new file mode 100644
index 0000000000..fe209ffa17
--- /dev/null
+++ b/.changeset/five-gifts-bathe.md
@@ -0,0 +1,9 @@
+---
+"@gradio/dataframe": minor
+"@gradio/markdown": minor
+"@gradio/statustracker": minor
+"@gradio/theme": minor
+"gradio":... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "Performance Optimizations"
} |
home-assistant__core-111262@31257ac | home-assistant/core | Python | 111,262 | Subscribe to Traccar Server events | <!--
You are amazing! Thanks for contributing to our project!
Please, DO NOT DELETE ANY TEXT from this template! (unless instructed).
-->
## Proposed change
<!--
Describe the big picture of your changes here to communicate to the
maintainers why we should accept this pull request. If it fixes a bug
or... | 2024-02-24T09:09:45Z | Home Assistant 2024.2.0 and greater Integration Traccar now sends Status / Location even if device offline
### The problem
Now that Traccar Integration is setup via UI it seems to get the device status from traccar AND proccessing it even if the device is offline.
Real World impact:
A person / account in HA has mu... | Hey there @ludeeus, mind taking a look at this issue as it has been labeled with an integration (`traccar`) you are listed as a [code owner](https://github.com/home-assistant/core/blob/dev/CODEOWNERS#L1396) for? Thanks!
<details>
<summary>Code owner commands</summary>
Code owners of `traccar` can trigger bot actions... | [
{
"body": "### The problem\r\n\r\nNow that Traccar Integration is setup via UI it seems to get the device status from traccar AND proccessing it even if the device is offline.\r\nReal World impact:\r\nA person / account in HA has multiple device tracker (Mobile Companion App and Traccar).\r\nNow the person.<nam... | d08fc1f34292f71200d0c1111a14db4facc2f4b7 | {
"head_commit": "31257aca485744da0e8c5e0aaa50b29e898d5a65",
"head_commit_message": "Subscribe to Traccar Server events",
"patch_to_review": "diff --git a/homeassistant/components/traccar_server/__init__.py b/homeassistant/components/traccar_server/__init__.py\nindex 53770757c8189f..5f37be16e046fd 100644\n--- a/h... | [
{
"diff_hunk": "@@ -123,12 +110,47 @@ async def _async_update_data(self) -> TraccarServerCoordinatorData:\n \"attributes\": attr,\n }\n \n- if self.events:\n- self.hass.async_create_task(self.import_events(devices))\n+ await self.subscribe()\n \n retu... | 5c480a7aa9f4d1458aef7511fb54adace0b48c40 | diff --git a/homeassistant/components/traccar_server/__init__.py b/homeassistant/components/traccar_server/__init__.py
index 53770757c8189f..5f37be16e046fd 100644
--- a/homeassistant/components/traccar_server/__init__.py
+++ b/homeassistant/components/traccar_server/__init__.py
@@ -1,6 +1,9 @@
"""The Traccar Server in... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
gradio-app__gradio-5221@0df9092 | gradio-app/gradio | Python | 5,221 | Allows setting a height to `gr.File` and improves the UI of the component | This PR:
* Adds a `height` parameter to `gr.File()` which sets both the height of upload box as well as the maximum height of the displayed files. If the number of files exceeds what can be displayed, then a scrollbar appears. This is useful when displaying a large number of files (and closes: #5131)
* Fixes some i... | 2023-08-14T19:33:16Z | Limit height for Files Component and adding vertical scrollbar
- [x] I have searched to see if a similar issue already exists.
**Is your feature request related to a problem? Please describe.**
Since currently the limit for File upload was removed it is especially cumbersome to have a large filelist display, wh... | [
{
"body": "- [x] I have searched to see if a similar issue already exists.\r\n\r\n\r\n**Is your feature request related to a problem? Please describe.** \r\nSince currently the limit for File upload was removed it is especially cumbersome to have a large filelist display, which is completely trashing an otherw... | ddac7e4d0f55c3bdc6c3e9a9e24588b2563e4049 | {
"head_commit": "0df9092e193ad6bdbaeff428adfa954d79aedb60",
"head_commit_message": "add changeset",
"patch_to_review": "diff --git a/.changeset/lovely-bikes-thank.md b/.changeset/lovely-bikes-thank.md\nnew file mode 100644\nindex 0000000000..76f3244425\n--- /dev/null\n+++ b/.changeset/lovely-bikes-thank.md\n@@ -... | [
{
"diff_hunk": "@@ -41,12 +38,16 @@\n \t\t\t\t\t\t\t\t\t? null\n \t\t\t\t\t\t\t\t\t: file.orig_name || file.name}\n \t\t\t\t\t\t\t>\n-\t\t\t\t\t\t\t\tDownload\n+\t\t\t\t\t\t\t\t{display_file_name(file)}",
"line": null,
"original_line": 41,
"original_start_line": null,
"path": "js/file/shared/Fil... | da41f51600c17dfdc004dfffa5e7bf8830d24fb5 | diff --git a/.changeset/lovely-bikes-thank.md b/.changeset/lovely-bikes-thank.md
new file mode 100644
index 0000000000..41c9c18cf4
--- /dev/null
+++ b/.changeset/lovely-bikes-thank.md
@@ -0,0 +1,6 @@
+---
+"@gradio/file": minor
+"gradio": minor
+---
+
+feat:Allows setting a height to `gr.File` and improves the UI of th... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
huggingface__trl-2172@2d2471b | huggingface/trl | Python | 2,172 | Update incorrect data processing in DataCollatorForChatML | # What does this PR do?
Fix the extra BOS token and the absence of an EOS token in the returned input_ids, and potentially the absence of a target string in the returned labels.
<!--
Congratulations! You've made it this far! You're not quite done yet though.
Once merged, your PR is going to appear in the releas... | 2024-10-04T11:06:01Z | Incorrect data processing in DataCollatorForChatML
### System Info
Python 3.11.9
trl 0.11.0
transformers 4.45.1
### Information
- [ ] The official example scripts
- [X] My own modified scripts
### Tasks
- [X] An officially supported task in the `examples` folder
- [X] My own task or dataset (give det... | Thanks a lot for this detailed report @ruijunfeng
This is indeed a critical issue. Are you willing to submit a PR to solve it?
> Thanks a lot for this detailed report @ruijunfeng This is indeed a critical issue. Are you willing to submit a PR to solve it?
Hi there, I have submitted a PR to fix this, hope this will... | [
{
"body": "### System Info\r\n\r\nPython 3.11.9\r\ntrl 0.11.0\r\ntransformers 4.45.1\r\n\r\n### Information\r\n\r\n- [ ] The official example scripts\r\n- [X] My own modified scripts\r\n\r\n### Tasks\r\n\r\n- [X] An officially supported task in the `examples` folder\r\n- [X] My own task or dataset (give details... | 7e5924d17ebf7036f03091d60bde15e2367e7fe6 | {
"head_commit": "2d2471b7e7abec66a34a0121e2d691bb15caebca",
"head_commit_message": "Update tests/test_utils.py",
"patch_to_review": "diff --git a/tests/test_utils.py b/tests/test_utils.py\nindex e79edc755f..dbd68e0b44 100644\n--- a/tests/test_utils.py\n+++ b/tests/test_utils.py\n@@ -20,7 +20,13 @@\n from transfo... | [
{
"diff_hunk": "@@ -169,3 +175,87 @@ def test_val_none(self):\n assert \"my_model\" in card_text\n assert 'pipeline(\"text-generation\", model=\"username/my_hub_model\", device=\"cuda\")' in card_text\n assert \"My Trainer\" in card_text\n+\n+\n+class TestDataCollatorForChatML(unittest.T... | b4a2e971db1dd3596b830dc9253b09053cbf61a5 | diff --git a/tests/test_utils.py b/tests/test_utils.py
index e79edc755f..226861d96f 100644
--- a/tests/test_utils.py
+++ b/tests/test_utils.py
@@ -15,12 +15,19 @@
import unittest
import torch
+from datasets import load_dataset
from transformers import AutoTokenizer
from transformers.testing_utils import require_p... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
home-assistant__core-110973@6c2fae5 | home-assistant/core | Python | 110,973 | Return group unit of measurement when device_class is None | <!--
You are amazing! Thanks for contributing to our project!
Please, DO NOT DELETE ANY TEXT from this template! (unless instructed).
-->
## Proposed change
<!--
Describe the big picture of your changes here to communicate to the
maintainers why we should accept this pull request. If it fixes a bug
... | 2024-02-19T21:03:23Z | Unit of measurements is not correct
### The problem
Unit of measurements is not correct
Unit of measurements °C, °C, °C of input sensors sensor.izone_current_temperature_upstairs, sensor.ble_temperature_upstairs_lounge_ble_climate, sensor.upstairs_climate_display_temperature are not compatible using no device class... | Hey there @home-assistant/core, mind taking a look at this issue as it has been labeled with an integration (`group`) you are listed as a [code owner](https://github.com/home-assistant/core/blob/dev/CODEOWNERS#L516) for? Thanks!
<details>
<summary>Code owner commands</summary>
Code owners of `group` can trigger bot ... | [
{
"body": "### The problem\r\n\r\nUnit of measurements is not correct\r\nUnit of measurements °C, °C, °C of input sensors sensor.izone_current_temperature_upstairs, sensor.ble_temperature_upstairs_lounge_ble_climate, sensor.upstairs_climate_display_temperature are not compatible using no device class of sensor ... | 61766c0e599d4681b697afaa9af81264987f21cd | {
"head_commit": "6c2fae54bb5b24429dcf5e08a5b52336bf991093",
"head_commit_message": "Groups: Return units when device_class is None",
"patch_to_review": "diff --git a/homeassistant/components/group/sensor.py b/homeassistant/components/group/sensor.py\nindex 8e1a0a242075a..379ccb6cd4c80 100644\n--- a/homeassistant... | [
{
"diff_hunk": "@@ -602,6 +602,9 @@ def _calculate_unit_of_measurement(\n \"uoms\": \", \".join(unit_of_measurements),\n },\n )\n+",
"line": null,
"original_line": 605,
"original_start_line": null,
"path": "homeassistant/components/group/sensor.py"... | 798275ea100e66c85ed3de59941a86fda72a3ae6 | diff --git a/homeassistant/components/group/sensor.py b/homeassistant/components/group/sensor.py
index 8e1a0a242075ae..7334831211d9ea 100644
--- a/homeassistant/components/group/sensor.py
+++ b/homeassistant/components/group/sensor.py
@@ -396,7 +396,7 @@ def async_update_group_state(self) -> None:
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
horovod__horovod-3279@295155a | horovod/horovod | Python | 3,279 | Fix lightning and pytorch estimator loading from checkpoint | ## Checklist before submitting
- [x] Did you read the [contributor guide](https://github.com/horovod/horovod/blob/master/CONTRIBUTING.md)?
- [ ] Did you update the docs?
- [ ] Did you write any tests to validate this change?
- [ ] Did you update the [CHANGELOG](https://github.com/horovod/horovod/blob/master/CHA... | 2021-11-17T04:30:56Z | Unable to load most recent checkpoint for Pytorch and Pytorch lightning Estimator
**Environment:**
1. Framework: PyTorch
2. Framework version: 1.8.1
3. Horovod version: 0.23.0
4. MPI version:
5. CUDA version:
6. NCCL version:
7. Python version: 3.8
8. Spark / PySpark version: 3.1.2
9. Ray version:
10. OS and ... | [
{
"body": "**Environment:**\r\n1. Framework: PyTorch\r\n2. Framework version: 1.8.1\r\n3. Horovod version: 0.23.0\r\n4. MPI version:\r\n5. CUDA version:\r\n6. NCCL version:\r\n7. Python version: 3.8\r\n8. Spark / PySpark version: 3.1.2\r\n9. Ray version:\r\n10. OS and version:\r\n11. GCC version:\r\n12. CMake v... | e1ddf3da8cb8116955e7154893f07c2561f77ecf | {
"head_commit": "295155a102c0dcfcdf0b98088fd3099027db6844",
"head_commit_message": "Enabled checkpoint test for lightning\n\nSigned-off-by: Kamal Sharma <kamalbhardwaj020@gmail.com>",
"patch_to_review": "diff --git a/horovod/spark/common/store.py b/horovod/spark/common/store.py\nindex e39ac92992..7ba4315912 1006... | [
{
"diff_hunk": "@@ -262,7 +262,7 @@ def on_epoch_end(self, trainer: \"pl.Trainer\", pl_module: \"pl.LightningModule\") -\n if hvd.rank() == 0:\n if remote_store.saving_runs and trainer.profiler:\n # One more file sync to push profiler result.\n- ... | 5a2588b50ff590ab4d60815ea93460a004ff07ee | diff --git a/horovod/spark/common/store.py b/horovod/spark/common/store.py
index e39ac92992..7ba4315912 100644
--- a/horovod/spark/common/store.py
+++ b/horovod/spark/common/store.py
@@ -150,6 +150,7 @@ def _remote_attrs(self, run_id, dataset_idx):
'checkpoint_filename': self.get_checkpoint_filename(),
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
gradio-app__gradio-5075@e6bcf1f | gradio-app/gradio | Python | 5,075 | Allow supporting >1000 files in `gr.File()` and `gr.UploadButton()` | A few months ago, `starlette` decided to limit the number of files that could be uploaded via a single request to [1,000 by default (though configurable)](https://github.com/encode/starlette/commit/8c74c2c8dba7030154f8af18e016136bea1938fa). FastAPI does not support configuring this yet, [though there is an open PR](htt... | 2023-08-02T18:42:06Z | An error happened when upload a directory more than 1000 files
### Describe the bug
it receive an error when I upload a directory with more 1000 pictures.
### Is there an existing issue for this?
- [X] I have searched the existing issues
### Reproduction
import gradio as gr
def upload_file(files):
file_pat... | Same problem. Suggest to support batched input. | [
{
"body": "### Describe the bug\n\nit receive an error when I upload a directory with more 1000 pictures.\n\n### Is there an existing issue for this?\n\n- [X] I have searched the existing issues\n\n### Reproduction\n\nimport gradio as gr\r\n\r\ndef upload_file(files):\r\n file_paths = [file.name for file in ... | 2745075a26f80e0e16863d483401ff1b6c5ada7a | {
"head_commit": "e6bcf1fd2a6ff46939ad756de2430643435aae6e",
"head_commit_message": "add changeset",
"patch_to_review": "diff --git a/.changeset/late-shrimps-tease.md b/.changeset/late-shrimps-tease.md\nnew file mode 100644\nindex 0000000000..dd94699d25\n--- /dev/null\n+++ b/.changeset/late-shrimps-tease.md\n@@ -... | [
{
"diff_hunk": "@@ -185,22 +185,28 @@ export function api_factory(fetch_implementation: typeof fetch) {\n \t\tif (token) {\n \t\t\theaders.Authorization = `Bearer ${token}`;\n \t\t}\n-\n-\t\tconst formData = new FormData();\n-\t\tfiles.forEach((file) => {\n-\t\t\tformData.append(\"files\", file);\n-\t\t});\n-\t... | 57c3b7c92dd0973a1bec4fcbafd5ca9793c8d66e | diff --git a/.changeset/late-shrimps-tease.md b/.changeset/late-shrimps-tease.md
new file mode 100644
index 0000000000..dd94699d25
--- /dev/null
+++ b/.changeset/late-shrimps-tease.md
@@ -0,0 +1,6 @@
+---
+"@gradio/client": patch
+"gradio": patch
+---
+
+fix:Allow supporting >1000 files in `gr.File()` and `gr.UploadBut... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
horovod__horovod-3274@8354368 | horovod/horovod | Python | 3,274 | Fix Horovod pyarrow IndexError: list index out of range | ## Checklist before submitting
- [x] Did you read the [contributor guide](https://github.com/horovod/horovod/blob/master/CONTRIBUTING.md)?
- [ ] Did you update the docs?
- [ ] Did you write any tests to validate this change?
- [ ] Did you update the [CHANGELOG](https://github.com/horovod/horovod/blob/master/CHA... | 2021-11-12T13:45:14Z | Horovod pyarrow IndexError: list index out of range
**Environment:**
1. Framework: TensorFlow
2. Framework version: 1.14
3. Horovod version: 0.19.5
4. MPI version: 4.0.4
5. CUDA version: NA
6. NCCL version: NA
7. Python version: 3.6
8. Spark / PySpark version: 2.4.4
9. OS and version: Amazon Linux
10. GCC ver... | Hey @ZhenyiLin, I believe Databricks ran into this issue when implementing the Spark Dataset Converter for Petastorm (https://github.com/uber/petastorm/pull/496).
We have a PR in progress to migrate to the Spark Dataset Converter API, which should hopefully resolve this issue: #2091.
@WeichenXu123, can you conf... | [
{
"body": "**Environment:**\r\n1. Framework: TensorFlow\r\n2. Framework version: 1.14\r\n3. Horovod version: 0.19.5\r\n4. MPI version: 4.0.4\r\n5. CUDA version: NA\r\n6. NCCL version: NA\r\n7. Python version: 3.6\r\n8. Spark / PySpark version: 2.4.4\r\n9. OS and version: Amazon Linux\r\n10. GCC version: 7.2.1\r... | d395a88c5dc06733cd4f87f69aa929fb2ef21717 | {
"head_commit": "83543684e959cb968410ba8d5bace551f1259310",
"head_commit_message": "update\n\nSigned-off-by: Weichen Xu <weichen.xu@databricks.com>",
"patch_to_review": "diff --git a/horovod/spark/common/util.py b/horovod/spark/common/util.py\nindex ae2a41a261..1a1dc604c0 100644\n--- a/horovod/spark/common/util.... | [
{
"diff_hunk": "@@ -539,6 +543,46 @@ def _train_val_split(df, validation):\n return train_df, val_df, validation_ratio\n \n \n+_FILE_AVAILABILITY_WAIT_TIMEOUT_SECS = \\\n+ int(os.environ.get('FILE_AVAILABILITY_WAIT_TIMEOUT_SECS', '30'))\n+\n+\n+def _wait_file_available(store, url_list):\n+ \"\"\"Waiti... | 2b88126525b5a835796a0b00036e279004f50dfa | diff --git a/horovod/spark/common/util.py b/horovod/spark/common/util.py
index ae2a41a261..d396a640b4 100644
--- a/horovod/spark/common/util.py
+++ b/horovod/spark/common/util.py
@@ -17,7 +17,9 @@
import contextlib
import os
+import time
+from multiprocessing.pool import ThreadPool
import pyarrow as pa
import n... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
horovod__horovod-3148@ce40a3e | horovod/horovod | Python | 3,148 | fix MPICH implementation | ## Checklist before submitting
- [x] Did you read the [contributor guide](https://github.com/horovod/horovod/blob/master/CONTRIBUTING.md)?
- [ ] Did you update the docs?
- [x] Did you write any tests to validate this change?
- [ ] Did you update the [CHANGELOG](https://github.com/horovod/horovod/blob/master/CHA... | 2021-09-04T02:32:31Z | Support MPICH when using horovodrun
I'm using MPICH instead of OpenMPI.
I'm able to train models using mpiexec and mpirun on my cluster but when I try to use horovodrun, it fails with the following error
```python
[ec2-user@master ~]$python3 ./horovodrun -np 8 python3 <train command>
[mpiexec@master.amazon.com] ... | Hey @chandana1332, `horovodrun` should support OpenMPI, Spectrum MPI, MPICH, and Gloo. However, we've run into some issues with MPICH in the past around `--allow-run-as-root`, and possibly other commands. Contributions would definitely be welcome, if you know what needs to be modified to fully support MPICH.
Thanks f... | [
{
"body": "I'm using MPICH instead of OpenMPI. \r\nI'm able to train models using mpiexec and mpirun on my cluster but when I try to use horovodrun, it fails with the following error\r\n\r\n```python\r\n[ec2-user@master ~]$python3 ./horovodrun -np 8 python3 <train command>\r\n[mpiexec@master.amazon.com] match_a... | 78ed3157c812a8dd4e368f3071a99a45f8bbc3bd | {
"head_commit": "ce40a3ee59c1f15b9a63ba0d5c868ad09ef78453",
"head_commit_message": "enable tests for MPICH and Intel MPI\n\nSigned-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>",
"patch_to_review": "diff --git a/horovod/runner/mpi_run.py b/horovod/runner/mpi_run.py\nindex 7b5be2787d..a9b39cc085 100644\n--- a/hor... | [
{
"diff_hunk": "@@ -153,7 +153,7 @@ def mpi_run(settings, nics, env, command, stdout=None, stderr=None):\n if mpi_impl_flags is None:\n raise Exception(_MPI_NOT_FOUND_ERROR_MSG)\n \n- impi = _IMPI_IMPL == mpi\n+ impi = (_IMPI_IMPL == mpi or _MPICH_IMPL == mpi)",
"line": null,
"original... | 7d42e11669125b86487ec836d81a326e78d08f41 | diff --git a/horovod/runner/mpi_run.py b/horovod/runner/mpi_run.py
index 7b5be2787d..5bcce0bb8c 100644
--- a/horovod/runner/mpi_run.py
+++ b/horovod/runner/mpi_run.py
@@ -153,7 +153,7 @@ def mpi_run(settings, nics, env, command, stdout=None, stderr=None):
if mpi_impl_flags is None:
raise Exception(_MPI_NO... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
gradio-app__gradio-4986@6c8da15 | gradio-app/gradio | Python | 4,986 | unified release process | closes #4851.
This PR overhauls our versioning and release process, and unifies it across the JS and Python files/libraries.
---
Before I explain this PR I just want to point out that change will increase the frequency with which you have to pull changes from a PR branch because the bot will be pushing to the... | 2023-07-20T11:19:38Z | The ability to not have all those extra image editing tools, only cropping
One of our users wants a cleaner image editing interface with only cropping. Is that possible?
unify release process
- [x] I have searched to see if a similar issue already exists.
**Is your feature request related to a problem? Please descri... | Yes, set tools=“select” in the image input kwargs
On Thu, Feb 25, 2021 at 1:40 PM Abubakar Abid <notifications@github.com>
wrote:
> One of our users wants a cleaner image editing interface with only
> cropping. Is that possible?
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this... | [
{
"body": "One of our users wants a cleaner image editing interface with only cropping. Is that possible?",
"number": 123,
"title": "The ability to not have all those extra image editing tools, only cropping"
},
{
"body": "- [x] I have searched to see if a similar issue already exists.\n\n\n**Is... | d51f61692b0bdb001bf902bbc02a24ed6fc1109d | {
"head_commit": "6c8da153f6c706051b5aa093c27bfc5ce19f1f67",
"head_commit_message": "fix changelog",
"patch_to_review": "diff --git a/.changeset/changeset.cjs b/.changeset/changeset.cjs\nnew file mode 100644\nindex 0000000000..82c24a2370\n--- /dev/null\n+++ b/.changeset/changeset.cjs\n@@ -0,0 +1,260 @@\n+const { ... | [
{
"diff_hunk": "@@ -0,0 +1,38 @@\n+name: Generate changeset\n+on:\n+ workflow_run:\n+ workflows: [\"trigger changeset generation\"]\n+ types:\n+ - completed\n+\n+env:\n+ CI: true\n+ NODE_OPTIONS: \"--max-old-space-size=4096\"\n+\n+concurrency:\n+ group: ${{ github.event.workflow_run.head_reposito... | 73ad5b5f24132d212e25dbe1b00dafd9c1728615 | diff --git a/.changeset/changeset.cjs b/.changeset/changeset.cjs
new file mode 100644
index 0000000000..82c24a2370
--- /dev/null
+++ b/.changeset/changeset.cjs
@@ -0,0 +1,260 @@
+const { getPackagesSync } = require("@manypkg/get-packages");
+const gh = require("@changesets/get-github-info");
+const { existsSync, readFi... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
Subsets and Splits
Review Test Instances
Retrieves basic metadata about code review instances but doesn't provide any analytical insights or patterns beyond raw data access.