instance_id stringlengths 21 53 | repo stringclasses 188
values | language stringclasses 1
value | pull_number int64 20 148k | title stringlengths 6 144 | body stringlengths 0 83.4k | created_at stringdate 2015-09-25 03:17:17 2025-07-10 16:50:35 | problem_statement stringlengths 188 240k | hints_text stringlengths 0 145k | resolved_issues listlengths 1 6 | base_commit stringlengths 40 40 | commit_to_review dict | reference_review_comments listlengths 1 62 | merged_commit stringlengths 40 40 | merged_patch stringlengths 297 9.87M | metadata dict |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
home-assistant__core-95911@8be2a2f | home-assistant/core | Python | 95,911 | Handle integrations with empty services or failing to load during service description enumeration |
## Proposed change
<!--
Describe the big picture of your changes here to communicate to the
maintainers why we should accept this pull request. If it fixes a bug
or resolves a feature request, be sure to link to that issue in the
additional information section.
-->
fixes #95581
## Type of change... | 2023-07-05T15:00:48Z | ERROR (MainThread) [homeassistant.components.websocket_api.http.connection]
### The problem
I am experiencing a issue, where the web interface continuously displays the message "Loading data" without fully loading the dashboard. This problem is not limited to a specific device, as multiple devices on the network are a... | This probably is due to an external service requesting service descriptions over the API. One service which can do that is the remote home-assistant integration, do you use that?
I have the same problem, as soon as my remote instance of HA sends a request to my 'main' HA for the service descriptions, the API call ge... | [
{
"body": "### The problem\n\nI am experiencing a issue, where the web interface continuously displays the message \"Loading data\" without fully loading the dashboard. This problem is not limited to a specific device, as multiple devices on the network are affected. The issue occurs both when accessing Home As... | d9721702af611049c04d2700764e8267718cde01 | {
"head_commit": "8be2a2f27aa8e77dc190bf6245615b0f8e374ebc",
"head_commit_message": "add coverage",
"patch_to_review": "diff --git a/homeassistant/helpers/service.py b/homeassistant/helpers/service.py\nindex 715a960de5dc0..90d3668b9f4fa 100644\n--- a/homeassistant/helpers/service.py\n+++ b/homeassistant/helpers/s... | [
{
"diff_hunk": "@@ -599,34 +599,28 @@ async def async_get_all_descriptions(\n for int_or_exc in ints_or_excs.values()",
"line": null,
"original_line": 599,
"original_start_line": null,
"path": "homeassistant/helpers/service.py",
"start_line": null,
"text": "@author:\nWe shoul... | abde1df7e30565e16983204e2b297761c78fa69a | diff --git a/homeassistant/helpers/service.py b/homeassistant/helpers/service.py
index 715a960de5dc03..b1e2dd9a723a96 100644
--- a/homeassistant/helpers/service.py
+++ b/homeassistant/helpers/service.py
@@ -566,7 +566,9 @@ async def async_get_all_descriptions(
hass: HomeAssistant,
) -> dict[str, dict[str, Any]]:
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ivy-llc__ivy-21287@30dc9dd | ivy-llc/ivy | Python | 21,287 | Solve numpy.vector_norm assertion error in case of 0-dim array input | Solved by converting it to 1-dim array before computation and then convert it back to 0-dim in case of keepdims
Fix #21099 | 2023-08-04T14:35:14Z | numpy.vector_norm has too high rounding errors
Running `test_vector_norm` for the numpy backend with tolerance set to `1e-03` still causes an assertion error:
```
FAILED [ 25%]WARNING:tensorflow:You are casting an input of type complex128 to an incompatible dtype float64. This will discard the imaginary pa... | [
{
"body": "Running `test_vector_norm` for the numpy backend with tolerance set to `1e-03` still causes an assertion error:\r\n```\r\nFAILED [ 25%]WARNING:tensorflow:You are casting an input of type complex128 to an incompatible dtype float64. This will discard the imaginary part and may not be what y... | f0389c2f584abc564d7eca9ef9b5d806295f7161 | {
"head_commit": "30dc9dd7b26ad9d8eba4587fcfb9a78e8c82bf53",
"head_commit_message": "Solve numpy.vector_norm assertion error in case of 0-dim array input\n\nSolved by converting it to 1-dim array before computation and then convert it back to 0-dim in case of keepdims",
"patch_to_review": "diff --git a/ivy/functi... | [
{
"diff_hunk": "@@ -388,10 +388,19 @@ def vector_norm(\n elif ord == -inf:\n return np.min(abs_x, axis=axis, keepdims=keepdims, out=out)\n else:\n- return (\n+ # There is a rounding error whenever the input is a 0-dim\n+ # The solution at the moment is to convert the 0-dim a... | e8c46720335a5fb41e1b3740ad22ca991491060e | diff --git a/ivy/functional/backends/numpy/linear_algebra.py b/ivy/functional/backends/numpy/linear_algebra.py
index b8b1971f77fdd..9f9fcdbc17f1b 100644
--- a/ivy/functional/backends/numpy/linear_algebra.py
+++ b/ivy/functional/backends/numpy/linear_algebra.py
@@ -388,10 +388,21 @@ def vector_norm(
elif ord == -in... | {
"difficulty": "low",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
home-assistant__core-95160@83d21ea | home-assistant/core | Python | 95,160 | Make `unique_id` of the Shelly button entity immutable | <!--
You are amazing! Thanks for contributing to our project!
Please, DO NOT DELETE ANY TEXT from this template! (unless instructed).
-->
## Breaking change
<!--
If your PR contains a breaking change for existing users, it is important
to tell them what breaks, how to make it work again and why we did th... | 2023-06-24T13:31:03Z | Shelly EM - reboot button unavailable
### The problem
Shelly Em reboot button .. that was always available.. now it's unavailable (maybe after it's recent Fw update?)
Anyone else has the same?
### What version of Home Assistant Core has the issue?
Home Assistant 2023.2.0 Supervisor 2023.01.1 Operating System 9.5 F... | Hey there @balloob, @bieniu, @thecode, @chemelli74, @bdraco, mind taking a look at this issue as it has been labeled with an integration (`shelly`) you are listed as a [code owner](https://github.com/home-assistant/core/blob/dev/CODEOWNERS#L1082) for? Thanks!
<details>
<summary>Code owner commands</summary>
Code own... | [
{
"body": "### The problem\n\nShelly Em reboot button .. that was always available.. now it's unavailable (maybe after it's recent Fw update?)\r\nAnyone else has the same?\n\n### What version of Home Assistant Core has the issue?\n\nHome Assistant 2023.2.0 Supervisor 2023.01.1 Operating System 9.5 Frontend 2023... | e4a7c57b81f0e8ae0800cc674b55491def70562a | {
"head_commit": "83d21ea8335025d3dced217d7eb374b8f75f3911",
"head_commit_message": "Fix tests",
"patch_to_review": "diff --git a/homeassistant/components/shelly/button.py b/homeassistant/components/shelly/button.py\nindex 15a055736560ee..7dfeae8f4c316f 100644\n--- a/homeassistant/components/shelly/button.py\n+++... | [
{
"diff_hunk": "@@ -79,19 +80,61 @@ class ShellyButtonDescription(\n ]\n \n \n+@callback\n+def async_migrate_unique_ids(\n+ entity_entry: er.RegistryEntry,\n+ coordinator: ShellyRpcCoordinator | ShellyBlockCoordinator,\n+) -> dict[str, Any] | None:\n+ \"\"\"Migrate button unique IDs.\"\"\"\n+ if not... | 12cc768eace768574046da41b1051bb4f8d03b3f | diff --git a/homeassistant/components/shelly/button.py b/homeassistant/components/shelly/button.py
index 15a055736560ee..1f684ce137c41a 100644
--- a/homeassistant/components/shelly/button.py
+++ b/homeassistant/components/shelly/button.py
@@ -3,7 +3,7 @@
from collections.abc import Callable, Coroutine
from dataclas... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
home-assistant__core-92593@65db6f7 | home-assistant/core | Python | 92,593 | Lower scan interval for OpenSky | <!--
You are amazing! Thanks for contributing to our project!
Please, DO NOT DELETE ANY TEXT from this template! (unless instructed).
-->
## Proposed change
<!--
Describe the big picture of your changes here to communicate to the
maintainers why we should accept this pull request. If it fixes a bug
... | 2023-05-05T10:27:43Z | OpenSky
### The problem
Hi i have this problem many many times i think last one year same problem.
Logger: homeassistant.components.sensor
Source: components/opensky/sensor.py:156
Integration: Sensor (documentation, issues)
First occurred: 20:12:52 (1 occurrences)
Last logged: 20:12:52
opensky: Error on devi... | [opensky documentation](https://www.home-assistant.io/integrations/opensky)
[opensky source](https://github.com/home-assistant/core/tree/dev/homeassistant/components/opensky)
Can you share your config?
Apparently the scan interval was set too low so it hit the max amount of requests an anonymous user could do. Lowered ... | [
{
"body": "### The problem\n\nHi i have this problem many many times i think last one year same problem.\r\n\r\nLogger: homeassistant.components.sensor\r\nSource: components/opensky/sensor.py:156\r\nIntegration: Sensor (documentation, issues)\r\nFirst occurred: 20:12:52 (1 occurrences)\r\nLast logged: 20:12:52\... | 1976232d5a92d4489ff090761992748298e34fca | {
"head_commit": "65db6f70045bd0f1f45c848544f47ae7f1853e32",
"head_commit_message": "Update homeassistant/components/opensky/sensor.py\n\nCo-authored-by: epenet <6771947+epenet@users.noreply.github.com>",
"patch_to_review": "diff --git a/homeassistant/components/opensky/sensor.py b/homeassistant/components/opensk... | [
{
"diff_hunk": "@@ -38,7 +38,8 @@\n \n EVENT_OPENSKY_ENTRY = f\"{DOMAIN}_entry\"\n EVENT_OPENSKY_EXIT = f\"{DOMAIN}_exit\"\n-SCAN_INTERVAL = timedelta(seconds=12) # opensky public limit is 10 seconds\n+# OpenSky free user has 400 credits. 400/24 = ~16 requests per hour\n+SCAN_INTERVAL = timedelta(minutes=4)",
... | ae089d0d6e28352ff4e4bbd442ca4c5e58b19693 | diff --git a/homeassistant/components/opensky/sensor.py b/homeassistant/components/opensky/sensor.py
index 4c96f2575f0568..03e242f40b2974 100644
--- a/homeassistant/components/opensky/sensor.py
+++ b/homeassistant/components/opensky/sensor.py
@@ -38,7 +38,8 @@
EVENT_OPENSKY_ENTRY = f"{DOMAIN}_entry"
EVENT_OPENSKY_E... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
home-assistant__core-93530@aee392d | home-assistant/core | Python | 93,530 | Fix error if a `custom_sentences` file is empty | <!--
You are amazing! Thanks for contributing to our project!
Please, DO NOT DELETE ANY TEXT from this template! (unless instructed).
-->
## Breaking change
<!--
If your PR contains a breaking change for existing users, it is important
to tell them what breaks, how to make it work again and why we did th... | 2023-05-25T13:28:40Z | HA assist erroring when you have empty custom sentence files
### The problem
If you make custom yaml files in the custom_sentences/{language} folder and have them blank, when you try to run assist you'll end up getting an error when you say/type something, even with default assist intents (turn on {xyz} light). The er... | Hey there @home-assistant/core, @synesthesiam, mind taking a look at this issue as it has been labeled with an integration (`conversation`) you are listed as a [code owner](https://github.com/home-assistant/core/blob/dev/CODEOWNERS#L224) for? Thanks!
<details>
<summary>Code owner commands</summary>
Code owners of `c... | [
{
"body": "### The problem\n\nIf you make custom yaml files in the custom_sentences/{language} folder and have them blank, when you try to run assist you'll end up getting an error when you say/type something, even with default assist intents (turn on {xyz} light). The error HA shows is \r\n\r\n`\"Unexpected er... | a96215bf2ee38162e32f40d0a21974e21fc3b9b1 | {
"head_commit": "aee392d69aa9f1bd2041182f49ebb8d9872a3c10",
"head_commit_message": "Log warning file is invalid",
"patch_to_review": "diff --git a/homeassistant/components/conversation/default_agent.py b/homeassistant/components/conversation/default_agent.py\nindex dccf394ab3fa1a..b53774f39cc2ff 100644\n--- a/ho... | [
{
"diff_hunk": "@@ -419,9 +419,20 @@ def _get_or_load_intents(\n encoding=\"utf-8\"\n ) as custom_sentences_file:\n # Merge custom sentences\n- merge_dict(\n- intents_dict, y... | 54d94393044b7b64b9d17f10ed770dc21a8e7f22 | diff --git a/homeassistant/components/conversation/default_agent.py b/homeassistant/components/conversation/default_agent.py
index dccf394ab3fa1a..6f9840f177b93d 100644
--- a/homeassistant/components/conversation/default_agent.py
+++ b/homeassistant/components/conversation/default_agent.py
@@ -419,9 +419,18 @@ def _get... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
home-assistant__core-92553@1c10d95 | home-assistant/core | Python | 92,553 | Allow duplicate state updates when force_update is set on an esphome sensor | ## Proposed change
<!--
Describe the big picture of your changes here to communicate to the
maintainers why we should accept this pull request. If it fixes a bug
or resolves a feature request, be sure to link to that issue in the
additional information section.
-->
fixes #91221
`sensor` appears to be ... | 2023-05-04T21:32:04Z | ESPHome sensor force update option not working
### The problem
With the force update option set to true, the state of the sensor in Home Assistant don't change when the value stayed the same.
### What version of Home Assistant Core has the issue?
core-2023.4.2
### What was the last working version of Home Assista... | Have the same issue. Gone nuts because of this.
I use bluetooth temperature sensors all over the house and I rely on the "last update" time to decide whether a sensor has gone offline.
Since a few days some sensors started to go offline and could not understand what happened.
Changed the ESP32 to a model with E... | [
{
"body": "### The problem\n\nWith the force update option set to true, the state of the sensor in Home Assistant don't change when the value stayed the same.\r\n\n\n### What version of Home Assistant Core has the issue?\n\ncore-2023.4.2\n\n### What was the last working version of Home Assistant Core?\n\ncore-2... | 9e529d1d5914049ed73829b6be16f1f8523f77ef | {
"head_commit": "1c10d958af6cc744165a3491c1813cd5d401d14e",
"head_commit_message": "Allow duplicate states when force_update is set on an esphome sensor\n\nfixes #91221",
"patch_to_review": "diff --git a/homeassistant/components/esphome/entry_data.py b/homeassistant/components/esphome/entry_data.py\nindex 61d626... | [
{
"diff_hunk": "@@ -240,7 +241,16 @@ def async_update_state(self, state: EntityState) -> None:\n current_state_by_type = self.state[state_type]\n current_state = current_state_by_type.get(key, _SENTINEL)\n subscription_key = (state_type, key)\n- if current_state == state and subsc... | b899ea33336b07c292a8e2fa1565479a5b04fa59 | diff --git a/homeassistant/components/esphome/entry_data.py b/homeassistant/components/esphome/entry_data.py
index 61d6262250c0e1..7ce195d68fce08 100644
--- a/homeassistant/components/esphome/entry_data.py
+++ b/homeassistant/components/esphome/entry_data.py
@@ -25,6 +25,7 @@
NumberInfo,
SelectInfo,
Sens... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
home-assistant__core-92145@384b36c | home-assistant/core | Python | 92,145 | Ensure purge can cleanup old format detached states in the database |
## Proposed change
<!--
Describe the big picture of your changes here to communicate to the
maintainers why we should accept this pull request. If it fixes a bug
or resolves a feature request, be sure to link to that issue in the
additional information section.
-->
If there were still rows in the state... | 2023-04-27T20:34:52Z | recorder purge not purging with "Purge running in legacy format as there are states with event_id remaining"
### The problem
I have a sqlite db that is not purging neither automatically ( in the night routine ) nor by calling directly the service from developers tool.
At the moment my states tables contains +3mln row... | Hey there @home-assistant/core, mind taking a look at this issue as it has been labeled with an integration (`recorder`) you are listed as a [code owner](https://github.com/home-assistant/core/blob/dev/CODEOWNERS#L976) for? Thanks!
<details>
<summary>Code owner commands</summary>
Code owners of `recorder` can trigge... | [
{
"body": "### The problem\n\nI have a sqlite db that is not purging neither automatically ( in the night routine ) nor by calling directly the service from developers tool.\r\nAt the moment my states tables contains +3mln rows starting from 2022-11-26ish and keep growing.\r\nIn configuration.yaml I have the fo... | 89d8bda4bac6dc23d709afa9815417a943ecec8e | {
"head_commit": "384b36c32f54fa307c1c3ff216dfc19e1f2a2ebd",
"head_commit_message": "cover",
"patch_to_review": "diff --git a/homeassistant/components/recorder/purge.py b/homeassistant/components/recorder/purge.py\nindex 662be41b1c8e5..95013de125dcb 100644\n--- a/homeassistant/components/recorder/purge.py\n+++ b/... | [
{
"diff_hunk": "@@ -1104,6 +1106,150 @@ def _recreate_legacy_events_index():\n assert states_without_event_id.count() == 1\n \n \n+async def test_purge_can_mix_legacy_and_new_format_with_detached_state(\n+ async_setup_recorder_instance: RecorderInstanceGenerator,\n+ hass: HomeAssistant,\n+ reco... | dfa25c7a012840a596c79eca23f598290497e58e | diff --git a/homeassistant/components/recorder/purge.py b/homeassistant/components/recorder/purge.py
index 662be41b1c8e5..95013de125dcb 100644
--- a/homeassistant/components/recorder/purge.py
+++ b/homeassistant/components/recorder/purge.py
@@ -34,6 +34,7 @@
find_event_types_to_purge,
find_events_to_purge,
... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
ivy-llc__ivy-18051@ea69e51 | ivy-llc/ivy | Python | 18,051 | added rfftn function at backend | Close #18035 | 2023-06-29T13:31:56Z | rfftn
propose adding the RFFTN function to Ivy's Experimental API., I have been working on the RFFT2 function for the NumPy frontend for over a month now, and I've come across some complexities while iterating over multiple axes within the RFFT2 function.
Considering this, I would like to suggest exploring the impl... | [
{
"body": " propose adding the RFFTN function to Ivy's Experimental API., I have been working on the RFFT2 function for the NumPy frontend for over a month now, and I've come across some complexities while iterating over multiple axes within the RFFT2 function.\r\n\r\nConsidering this, I would like to suggest e... | 6068c57f38f670e7e6da7975fa0436411240aba0 | {
"head_commit": "ea69e5188b8304bb021af07e0482f6c7b88d4931",
"head_commit_message": "3 tests passing except tf",
"patch_to_review": "diff --git a/ivy/data_classes/array/experimental/layers.py b/ivy/data_classes/array/experimental/layers.py\nindex f9092b71cd227..d595e245a45a8 100644\n--- a/ivy/data_classes/array/e... | [
{
"diff_hunk": "@@ -365,3 +366,16 @@ def ifftn(\n out: Optional[paddle.Tensor] = None,\n ) -> paddle.Tensor:\n return paddle.fft.ifftn(x, s, axes, norm)\n+\n+\n+@with_unsupported_dtypes({\"0.4.13 and below\": (\"float32\", \"complex\")}, backend_version)\n+def rfftn(\n+ x: paddle.Tensor,\n+ s: Opt... | 04a20517529c66080a8dd36f42007a8a6ce15f1a | diff --git a/ivy/data_classes/array/experimental/layers.py b/ivy/data_classes/array/experimental/layers.py
index f9092b71cd227..d595e245a45a8 100644
--- a/ivy/data_classes/array/experimental/layers.py
+++ b/ivy/data_classes/array/experimental/layers.py
@@ -1024,3 +1024,35 @@ def ifftn(
[-0.48472244+0.3... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
getsentry__sentry-88799@9d62eed | getsentry/sentry | Python | 88,799 | fix(taskworker) remove signal handler safely | There are some tests for `child_worker` that are not in child processes, and we're currently leaking signal handlers. Use a context manager to add/cancel the signal handler.
Fixes #88742 | 2025-04-04T15:01:01Z | Fix signal leak in taskworker child_worker
```diff
diff --git a/tests/conftest.py b/tests/conftest.py
index 74ff8dbb8de..788cf0a6a9e 100644
--- a/tests/conftest.py
+++ b/tests/conftest.py
@@ -1,6 +1,7 @@
import os
+import signal
import sys
-from collections.abc import MutableMapping
+from collections.abc import Gener... | [
{
"body": "```diff\ndiff --git a/tests/conftest.py b/tests/conftest.py\nindex 74ff8dbb8de..788cf0a6a9e 100644\n--- a/tests/conftest.py\n+++ b/tests/conftest.py\n@@ -1,6 +1,7 @@\n import os\n+import signal\n import sys\n-from collections.abc import MutableMapping\n+from collections.abc import Generator, MutableM... | 4219a4fcb22bd517a314528260ce59ffaafcde7f | {
"head_commit": "9d62eed9ed20c15f3deab084a6e55c88df8b5c54",
"head_commit_message": "fix(taskworker) remove signal handler safely\n\nThere are some tests for `child_worker` that are not in child processes,\nand we're currently leaking signal handlers. Use a context manager to\nadd/cancel the signal handler.\n\nFixe... | [
{
"diff_hunk": "@@ -152,16 +169,12 @@ def handle_alarm(signum: int, frame: Any) -> None:\n \n set_current_task(activation)\n \n- # Set an alarm for the processing_deadline_duration\n- signal.alarm(activation.processing_deadline_duration)\n-\n- execution_start_time = time.time()\n ... | b97cab4d5543520a0758eefe4f9944068d017f9c | diff --git a/src/sentry/taskworker/worker.py b/src/sentry/taskworker/worker.py
index 1daec357e068f1..1c13f75a848675 100644
--- a/src/sentry/taskworker/worker.py
+++ b/src/sentry/taskworker/worker.py
@@ -1,6 +1,7 @@
from __future__ import annotations
import atexit
+import contextlib
import dataclasses
import loggi... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
ivy-llc__ivy-17660@be17c14 | ivy-llc/ivy | Python | 17,660 | All paddle frontend bug fix | Close #17659 | 2023-06-23T17:01:21Z | [Bug]: 'all' function bug in paddle frontend
### Bug Explanation
It's supposed to take tensor of bool but is taking float in the current implementation.
### Steps to Reproduce Bug
By comparing with paddle docs
### Environment
Windows 11 using Pycharm and Docker
### Ivy Version
Latest
### Backend
- [ ] NumPy
- ... | [
{
"body": "### Bug Explanation\n\nIt's supposed to take tensor of bool but is taking float in the current implementation.\n\n### Steps to Reproduce Bug\n\nBy comparing with paddle docs\n\n### Environment\n\nWindows 11 using Pycharm and Docker\n\n### Ivy Version\n\nLatest\n\n### Backend\n\n- [ ] NumPy\n- [ ] Ten... | 98d65d8b37c3bdc41a7b9494cc09efbd58ec7bdc | {
"head_commit": "be17c1454327dd58beed03abbd86ed823bb7cb1a",
"head_commit_message": "all function bug fix",
"patch_to_review": "diff --git a/ivy/functional/frontends/paddle/tensor/tensor.py b/ivy/functional/frontends/paddle/tensor/tensor.py\nindex 43af1bc5c0e13..dd49fd4ba7ed5 100644\n--- a/ivy/functional/frontend... | [
{
"diff_hunk": "@@ -195,9 +195,9 @@ def multiply(self, y, name=None):\n def isfinite(self, name=None):\r\n return ivy.isfinite(self._ivy_array)\r\n \r\n- @with_supported_dtypes({\"2.5.0 and below\": (\"float16\", \"bfloat16\")}, \"paddle\")\r\n- def all(self, axis=None, keepdim=False, dtype=No... | d0702cdc24bd45b69fb59ec00337ee9de7e5fdb1 | diff --git a/ivy/functional/frontends/paddle/tensor/tensor.py b/ivy/functional/frontends/paddle/tensor/tensor.py
index 43af1bc5c0e13..626d49ab464a0 100644
--- a/ivy/functional/frontends/paddle/tensor/tensor.py
+++ b/ivy/functional/frontends/paddle/tensor/tensor.py
@@ -195,9 +195,8 @@ def multiply(self, y, name=None):
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
ivy-llc__ivy-16555@be2d54f | ivy-llc/ivy | Python | 16,555 | remove `# noqa` from docstrings | Closes [this card](https://trello.com/c/M8XzDOQC/1565-remove-noqa-from-docstrings) and also fixes #16517.
Removed `# noqa` from the docstrings that were being rendered by Sphinx undesirably. By running `pre-commit` hooks, formatted the docstrings in a way to contain itself within the limits of the line length defi... | 2023-06-12T05:09:24Z | broken links in docstrings
The docstrings in Ivy are an extension of the docstrings as defined by the Array API Standard.
The URLs to the specific API docstrings are broken. It is crucial to address these broken links to ensure accurate and reliable documentation. | [
{
"body": "The docstrings in Ivy are an extension of the docstrings as defined by the Array API Standard.\r\nThe URLs to the specific API docstrings are broken. It is crucial to address these broken links to ensure accurate and reliable documentation.",
"number": 16517,
"title": "broken links in docstri... | 0e946b265df73a4daf1037734f7952b1ba73e0f0 | {
"head_commit": "be2d54fe6c85994ba9c2314f206468b5046f9042",
"head_commit_message": "removed #noqa from the docstrings while also ensuring the line length does not exceed 88 characters and fixed broken links along",
"patch_to_review": "diff --git a/ivy/data_classes/array/elementwise.py b/ivy/data_classes/array/el... | [
{
"diff_hunk": "@@ -6024,19 +6024,20 @@ def logical_or(\n must have a data type of ``bool``.\n \n This function conforms to the `Array API Standard\n- <https://data-apis.org/array-api/latest/>`_. This docstring is an extension of the\n- `docstring <https://data-apis.org/array-a... | cb2d6b3e494ee987ca89723e5a71a573aa605d3b | diff --git a/ivy/data_classes/array/elementwise.py b/ivy/data_classes/array/elementwise.py
index c1600cc16d576..3ade834a77b02 100644
--- a/ivy/data_classes/array/elementwise.py
+++ b/ivy/data_classes/array/elementwise.py
@@ -1670,13 +1670,14 @@ def logical_or(
must have a data type of ``bool``.
... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Documentation Updates"
} | |
getsentry__sentry-86967@073bb96 | getsentry/sentry | Python | 86,967 | ref(source-map-debugger-modal): Display different copies based on the release userAgent | This PR updates the code to show custom messages in the Sentry debugger modal based on the user agent in the release. If the user agent isn't available, a more general message will be shown, as it is in production.
In the future, it would be helpful always to have the tool used to upload sourcemaps available - mayb... | 2025-03-13T05:53:19Z | Show tool-specific copies and links based on user agent
We can detect the user's tool through the user agent, if available in the release object of an event. Based on this information, we can display relevant links and content tailored to the tool used. | [
{
"body": "We can detect the user's tool through the user agent, if available in the release object of an event. Based on this information, we can display relevant links and content tailored to the tool used.",
"number": 85617,
"title": "Show tool-specific copies and links based on user agent"
}
] | f0767c58e4bf398fd41671d5c5ffb34239dafaca | {
"head_commit": "073bb9666e1b6ceeeebeb0dd994c3cb17cf3327e",
"head_commit_message": "Merge branch 'priscila/ref/debugger-modal/display-copies-based-on-user-agent-of-available' of github.com:getsentry/sentry into priscila/ref/debugger-modal/display-copies-based-on-user-agent-of-available",
"patch_to_review": "diff... | [
{
"diff_hunk": "@@ -621,6 +624,159 @@ function InstalledSdkChecklistItem({\n );\n }\n \n+function getToolUsedToUploadSourceMaps({\n+ releaseUserAgent,\n+}: Pick<FrameSourceMapDebuggerData, 'releaseUserAgent'>) {\n+ const tools = [\n+ 'sentry-cli',\n+ 'vite-plugin',\n+ 'webpack-plugin',\n+ 'rollu... | 28d7a7516a76496867e6d2c3a219173d2a6e0ed4 | diff --git a/static/app/components/events/interfaces/crashContent/exception/useSourceMapDebuggerData.tsx b/static/app/components/events/interfaces/crashContent/exception/useSourceMapDebuggerData.tsx
index c20d71112a2be6..cd48590e399847 100644
--- a/static/app/components/events/interfaces/crashContent/exception/useSourc... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
home-assistant__core-90741@9b2eed8 | home-assistant/core | Python | 90,741 | SharkIQ Hotfix - Handle current installations by using default `REGION` | <!--
You are amazing! Thanks for contributing to our project!
Please, DO NOT DELETE ANY TEXT from this template! (unless instructed).
-->
## Proposed change
<!--
Describe the big picture of your changes here to communicate to the
maintainers why we should accept this pull request. If it fixes a bug
... | 2023-04-03T20:52:14Z | Existing SharkIQ instances break during upgrade - missing `region`
### The problem
The SharkIQ integration fails to run due to a region issue.
### What version of Home Assistant Core has the issue?
core-2023.4.0b4
### What was the last working version of Home Assistant Core?
core-2023.3.x
### What typ... | Hey there @jeffresc, @funkybunch, mind taking a look at this issue as it has been labeled with an integration (`sharkiq`) you are listed as a [code owner](https://github.com/home-assistant/core/blob/dev/CODEOWNERS#L1062) for? Thanks!
<details>
<summary>Code owner commands</summary>
Code owners of `sharkiq` can trigg... | [
{
"body": "### The problem\r\n\r\nThe SharkIQ integration fails to run due to a region issue.\r\n\r\n### What version of Home Assistant Core has the issue?\r\n\r\ncore-2023.4.0b4\r\n\r\n### What was the last working version of Home Assistant Core?\r\n\r\ncore-2023.3.x\r\n\r\n### What type of installation are yo... | 4a0d3e881ae0adb10a9870b783fc017692335677 | {
"head_commit": "9b2eed89e071a05fa763bc6ec7dd4ed8710a538c",
"head_commit_message": "Update Tests & Config setting method",
"patch_to_review": "diff --git a/homeassistant/components/sharkiq/__init__.py b/homeassistant/components/sharkiq/__init__.py\nindex 738dd595a5a7b1..02d8986fbdbc09 100644\n--- a/homeassistant... | [
{
"diff_hunk": "@@ -43,11 +50,19 @@ async def async_connect_or_timeout(ayla_api: AylaApi) -> bool:\n \n async def async_setup_entry(hass: HomeAssistant, config_entry: ConfigEntry) -> bool:\n \"\"\"Initialize the sharkiq platform via config entry.\"\"\"\n+ ayla_region = SHARKIQ_REGION_DEFAULT\n+ if not... | fac6443d2387e7b9656807a6e7585678f64e952f | diff --git a/homeassistant/components/sharkiq/__init__.py b/homeassistant/components/sharkiq/__init__.py
index 738dd595a5a7b..b6cae8ad6053b 100644
--- a/homeassistant/components/sharkiq/__init__.py
+++ b/homeassistant/components/sharkiq/__init__.py
@@ -17,7 +17,14 @@
from homeassistant.core import HomeAssistant
from ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
getsentry__sentry-85342@9676c6b | getsentry/sentry | Python | 85,342 | feat(insights): Tag mobile vitals module as new | Adds a New Tag to the Mobile Vitals module
Fixes https://github.com/getsentry/sentry/issues/84868
<img width="399" alt="image" src="https://github.com/user-attachments/assets/c0ebdc5e-b4b4-47aa-9006-ddddd538d91d" />
| 2025-02-18T10:43:26Z | Add (NEW) badge + description
- Add a (NEW) badge to the Mobile Vitals tab
OR
- Add a blue banner that says "App Starts, Screen Loads & (NEW) Screen Renders have been merged into a cohesive view under Mobile Vitals" with a link | Routing to @getsentry/product-owners-insights for [triage](https://develop.sentry.dev/processing-tickets/#3-triage) ⏲️ | [
{
"body": "- Add a (NEW) badge to the Mobile Vitals tab\nOR\n- Add a blue banner that says \"App Starts, Screen Loads & (NEW) Screen Renders have been merged into a cohesive view under Mobile Vitals\" with a link",
"number": 84868,
"title": "Add (NEW) badge + description"
}
] | 2ed0bdea8d9f913dae7e2eae1256fde6e9223d7d | {
"head_commit": "9676c6b5ab0778ca02a0dd57625370c7c11d1be9",
"head_commit_message": "Improve tests and simply tab component",
"patch_to_review": "diff --git a/static/app/views/insights/mobile/screens/settings.ts b/static/app/views/insights/mobile/screens/settings.ts\nindex 93cb5b9506311e..995e1cfd7af762 100644\n-... | [
{
"diff_hunk": "@@ -123,19 +129,21 @@ function TabLabel({moduleName}: TabLabelProps) {\n const moduleTitles = useModuleTitles();\n const organization = useOrganization();\n const showBusinessIcon = !isModuleEnabled(moduleName, organization);\n- if (showBusinessIcon) {\n+\n+ if (showBusinessIcon || isMod... | 8d42dc26adaef7a679defdf82488fa8393bb0766 | diff --git a/static/app/views/insights/mobile/screens/settings.ts b/static/app/views/insights/mobile/screens/settings.ts
index 93cb5b9506311e..995e1cfd7af762 100644
--- a/static/app/views/insights/mobile/screens/settings.ts
+++ b/static/app/views/insights/mobile/screens/settings.ts
@@ -1,10 +1,12 @@
import {t} from 's... | {
"difficulty": "low",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
home-assistant__core-90712@a80ff90 | home-assistant/core | Python | 90,712 | Fix Livisi climate min/max temperature | <!--
You are amazing! Thanks for contributing to our project!
Please, DO NOT DELETE ANY TEXT from this template! (unless instructed).
-->
## Breaking change
<!--
If your PR contains a breaking change for existing users, it is important
to tell them what breaks, how to make it work again and why we did th... | 2023-04-03T11:21:28Z | Issue with livisi integration, climate devices, turn off and temp
### The problem
- The climate device support only the mode "heat" You canot turn off the climate device. The device itself has the ability to turn them of.
- The maximum temperature is: 30
- The minimum temperature is: 6
### What version of Home Ass... | Hey there @stefaniacoblivisi, @planbnet, mind taking a look at this issue as it has been labeled with an integration (`livisi`) you are listed as a [code owner](https://github.com/home-assistant/core/blob/dev/CODEOWNERS#L663) for? Thanks!
<details>
<summary>Code owner commands</summary>
Code owners of `livisi` can t... | [
{
"body": "### The problem\n\n- The climate device support only the mode \"heat\" You canot turn off the climate device. The device itself has the ability to turn them of.\r\n- The maximum temperature is: 30 \r\n- The minimum temperature is: 6\n\n### What version of Home Assistant Core has the issue?\n\n2023.4.... | 628142527d4d2a4fa9a82c1a598bc7e10d52c69a | {
"head_commit": "a80ff904f5d4cb01b2691f01ded4b30dd2b9e0a8",
"head_commit_message": "Correctly set livisi climate min/max temp",
"patch_to_review": "diff --git a/homeassistant/components/livisi/climate.py b/homeassistant/components/livisi/climate.py\nindex 3a0a219d94340e..214cd54a93a500 100644\n--- a/homeassistan... | [
{
"diff_hunk": "@@ -3,9 +3,12 @@\n \n from typing import Any\n \n+from aiolivisi.const import CAPABILITY_CONFIG\n+\n from homeassistant.components.climate import (\n ClimateEntity,\n ClimateEntityFeature,\n+ HVACAction,",
"line": null,
"original_line": 11,
"original_start_line": null,
... | e859cd120eae678c5d26e23d31554c4677b9b885 | diff --git a/homeassistant/components/livisi/climate.py b/homeassistant/components/livisi/climate.py
index 3a0a219d94340e..952363650d6994 100644
--- a/homeassistant/components/livisi/climate.py
+++ b/homeassistant/components/livisi/climate.py
@@ -3,6 +3,8 @@
from typing import Any
+from aiolivisi.const import CAPA... | {
"difficulty": "medium",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
getsentry__sentry-88532@c57303f | getsentry/sentry | Python | 88,532 | feat(onboarding): Bulletproof critical back actions with new tests |
- closes https://github.com/getsentry/sentry/issues/88302 | 2025-04-02T10:18:53Z | Retro: Add acceptance tests for flow that broke in onboarding
We have acceptance tests for the simple flows in onboarding, but when more complex flows break, like re-creating a project after clicking the back button. Let's add an acceptance test for that flow | [
{
"body": "We have acceptance tests for the simple flows in onboarding, but when more complex flows break, like re-creating a project after clicking the back button. Let's add an acceptance test for that flow",
"number": 88302,
"title": "Retro: Add acceptance tests for flow that broke in onboarding"
}... | 69daf788d2c3dee8acb95ab1521c0871b715c23b | {
"head_commit": "c57303fe59a0ea0619ecee6f85f587f8339ef8bc",
"head_commit_message": "Merge branch 'master' into priscila/feat/onboarding/add-tests-to-bulletproof-critical-actions",
"patch_to_review": "diff --git a/src/sentry/testutils/asserts.py b/src/sentry/testutils/asserts.py\nindex d48cd8f0b5be33..ed45188002a... | [
{
"diff_hunk": "@@ -45,6 +50,22 @@ def assert_status_code(response, minimum: int, maximum: int | None = None):\n )\n \n \n+def verify_project_deletion(org: Organization, platform: str):\n+ # Poll the database to check if the project was deleted\n+ # the timeout is set to 10 seconds\n+ start_time = ... | e0e4e2bc5fe427b05df53ebe2cf0e84e1a697562 | diff --git a/src/sentry/testutils/asserts.py b/src/sentry/testutils/asserts.py
index d48cd8f0b5be33..5ea303596247b0 100644
--- a/src/sentry/testutils/asserts.py
+++ b/src/sentry/testutils/asserts.py
@@ -2,9 +2,12 @@
from django.http import StreamingHttpResponse
+from sentry.constants import ObjectStatus
from sent... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Test Suite / CI Enhancements"
} | |
huggingface__accelerate-3441@45dc368 | huggingface/accelerate | Python | 3,441 | Fix prod issues | # What does this PR do?
Fixes an issue caused by https://github.com/huggingface/accelerate/pull/3420 where said code only works if we're on torch 2.6+. Used a `hasattr` check instead here to make it work.
Fixes https://github.com/huggingface/accelerate/issues/3438
(Did a new PR since the old one had outdated ... | 2025-03-13T13:21:50Z | Version 1.5.0 explicitly depends on pytest
# Issue
Using the latest release (v1.5.0) I get a `ModuleNotFoundError: No module named 'pytest'` when launching any script with `accelerate launch` if pytest is not installed in the virtual environment.
Using v1.4.0 everything works fine, and I think this is the expected beh... | Thanks for flagging, should be fixed now with 1.5.1. Can you confirm?
Yes, v1.5.1 fixes this. Thanks @muellerzr!
Closing the issue 😄 | [
{
"body": "# Issue\nUsing the latest release (v1.5.0) I get a `ModuleNotFoundError: No module named 'pytest'` when launching any script with `accelerate launch` if pytest is not installed in the virtual environment.\n\nUsing v1.4.0 everything works fine, and I think this is the expected behavior.\n\n# Reproduci... | 71036329f7be4d4f97b13e8df245d064c539d8a2 | {
"head_commit": "45dc368a70990ffc0fec7a95e59ed8939740c281",
"head_commit_message": "Fix default device",
"patch_to_review": "diff --git a/src/accelerate/data_loader.py b/src/accelerate/data_loader.py\nindex 150d576a685..43f409ff12c 100644\n--- a/src/accelerate/data_loader.py\n+++ b/src/accelerate/data_loader.py\... | [
{
"diff_hunk": "@@ -89,7 +89,9 @@ def __init__(self, *args, **kwargs):\n \n def __iter__(self):\n if self.generator is None:\n- self.generator = torch.Generator(device=torch.get_default_device())\n+ self.generator = torch.Generator(\n+ device=torch.get_default_de... | a05d6ccdc23e137a6f4f267cf16ca83236266cf6 | diff --git a/src/accelerate/data_loader.py b/src/accelerate/data_loader.py
index 150d576a685..521d6cf6f4f 100644
--- a/src/accelerate/data_loader.py
+++ b/src/accelerate/data_loader.py
@@ -89,7 +89,9 @@ def __init__(self, *args, **kwargs):
def __iter__(self):
if self.generator is None:
- self... | {
"difficulty": "low",
"estimated_review_effort": 3,
"problem_domain": "Dependency Updates & Env Compatibility"
} |
huggingface__accelerate-3581@f08a190 | huggingface/accelerate | Python | 3,581 | Fix: Defer Tracker Initialization to Prevent Premature Distributed Setup | # What does this PR do?
<!--
Congratulations! You've made it this far! You're not quite done yet though.
Once merged, your PR is going to appear in the release notes with the title you set, so make sure it's a great title that fully reflects the extent of your awesome contribution.
Then, please replace this w... | 2025-05-20T12:06:49Z | Timeout does not work when used with TensorboardTracker
### System Info
```Shell
- `Accelerate` version: 1.6.0
- Platform: Linux-5.15.0-70-generic-x86_64-with-glibc2.31
- `accelerate` bash location: /data2/houxiuquan/envs/cp311pt211/bin/accelerate
- Python version: 3.11.9
- Numpy version: 1.26.4
- PyTorch version (GPU... | Thanks for the report ! I'll leave it as a good first issue so that the community can try to solve this if I don't do it in time
I would like to work on this | [
{
"body": "### System Info\n\n```Shell\n- `Accelerate` version: 1.6.0\n- Platform: Linux-5.15.0-70-generic-x86_64-with-glibc2.31\n- `accelerate` bash location: /data2/houxiuquan/envs/cp311pt211/bin/accelerate\n- Python version: 3.11.9\n- Numpy version: 1.26.4\n- PyTorch version (GPU?): 2.1.1 (True)\n- PyTorch X... | 33967d4733ec5bf402d85462ec2bbbcd8e872ea9 | {
"head_commit": "f08a1907db98ed07f87b9b86a88a4b31c9061ad5",
"head_commit_message": "Improve test for #3550",
"patch_to_review": "diff --git a/src/accelerate/accelerator.py b/src/accelerate/accelerator.py\nindex 5dd76f40904..ef25736c081 100755\n--- a/src/accelerate/accelerator.py\n+++ b/src/accelerate/accelerator... | [
{
"diff_hunk": "@@ -962,12 +996,17 @@ class DVCLiveTracker(GeneralTracker):\n name = \"dvclive\"\n requires_logging_directory = False\n \n- @on_main_process\n def __init__(self, run_name: Optional[str] = None, live: Optional[Any] = None, **kwargs):\n+ super().__init__()\n+ self.live... | dbdef320ad3d942b20f653fa8d65f9975eb2ddd3 | diff --git a/src/accelerate/accelerator.py b/src/accelerate/accelerator.py
index 5dd76f40904..ef25736c081 100755
--- a/src/accelerate/accelerator.py
+++ b/src/accelerate/accelerator.py
@@ -2932,6 +2932,10 @@ def init_trackers(self, project_name: str, config: dict | None = None, init_kwar
)
... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
huggingface__accelerate-2998@bb21bdc | huggingface/accelerate | Python | 2,998 | Make env variables optional for FSDP | # Remove env variable requirement for FSDP
## What does this add?
This PR removes the need to lock the user into using `accelerate launch` when using FSDP + accelerate. Instead, the user can now fully create a `FullyShardedDataParallelPlugin` manually.
## Who is it for?
Users of accelerate who want the flex... | 2024-08-07T13:34:41Z | Make plugin classes less environmental-variable focused, let users have an easier time just using `torchrun`, etc if they want
E.g. just let the user do:
```python
from accelerate import Accelerator
from accelerate.utils import FullyShardedDataParallelPlugin
plugin = FullyShardedDataParallelPlugin(...)
accelerator = ... | [
{
"body": "E.g. just let the user do:\n\n```python\nfrom accelerate import Accelerator\nfrom accelerate.utils import FullyShardedDataParallelPlugin\n\nplugin = FullyShardedDataParallelPlugin(...)\naccelerator = Accelerator(fsdp_plugin=plugin)\n```\n(Currently we have much that needs to be set via environmental ... | 13d93c4f505bca7a1075161d8246628e525958ad | {
"head_commit": "bb21bdcfc7bbaa75e43ddbdd3b0e150a297a09fa",
"head_commit_message": "Make diff easier",
"patch_to_review": "diff --git a/src/accelerate/state.py b/src/accelerate/state.py\nindex 82c6cbe7f2d..c3a594de5d7 100644\n--- a/src/accelerate/state.py\n+++ b/src/accelerate/state.py\n@@ -894,7 +894,7 @@ def _... | [
{
"diff_hunk": "@@ -1197,147 +1196,230 @@ class FullyShardedDataParallelPlugin:\n This plugin is used to enable fully sharded data parallelism.\n \"\"\"\n \n- sharding_strategy: \"typing.Any\" = field(\n+ sharding_strategy: Union[str, \"torch.distributed.fsdp.ShardingStrategy\"] = field(\n ... | f8c496c09048d3e0857621257c57335bf615daad | diff --git a/src/accelerate/state.py b/src/accelerate/state.py
index 82c6cbe7f2d..c3a594de5d7 100644
--- a/src/accelerate/state.py
+++ b/src/accelerate/state.py
@@ -894,7 +894,7 @@ def __init__(
DistributedType.MULTI_NPU,
DistributedType.MULTI_XPU,
]:
- if o... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Code Refactoring / Architectural Improvement"
} | |
huggingface__accelerate-2572@34ce852 | huggingface/accelerate | Python | 2,572 | Guard stateful objects | # What does this PR do?
This PR is the second half of solving https://github.com/huggingface/accelerate/issues/2564
The issue boils down to:
1. The user defines a `PartialState`/creates an `Accelerator`
2. The user then calls `_reset_state()` themselves
3. The user then calls subsequent functions in `Acceler... | 2024-03-21T14:14:57Z | 'AcceleratorState' object has no attribute 'distributed_type'
### System Info
```Shell
accelerate == 0.28.0
python == 3.8.18
transformers == 4.37.2
torch == 2.2.1
```
### Information
- [ ] The official example scripts
- [X] My own modified scripts
### Tasks
- [ ] One of the scripts in the example... | Please give us the full stack trace
full stack trace:
```python
Traceback (most recent call last):
File "C:\Users\Noah\PycharmProjects\pythonProject\venv\fine-tune.py", line 44, in <module>
model, optimizer, train_dataloader, eval_dataloader = accelerator.prepare(model, optimizer, train_dataloader, eval_datal... | [
{
"body": "### System Info\r\n\r\n```Shell\r\naccelerate == 0.28.0\r\npython == 3.8.18\r\ntransformers == 4.37.2\r\ntorch == 2.2.1\r\n```\r\n\r\n\r\n### Information\r\n\r\n- [ ] The official example scripts\r\n- [X] My own modified scripts\r\n\r\n### Tasks\r\n\r\n- [ ] One of the scripts in the examples/ folder... | dd62fc90cef6045c4b4d524ef9e1f80da5131a72 | {
"head_commit": "34ce852dd435a2dbf66e1074d97881ae763e74d5",
"head_commit_message": "Add test",
"patch_to_review": "diff --git a/src/accelerate/state.py b/src/accelerate/state.py\nindex 3e3a66d5d18..9ec38714c8f 100644\n--- a/src/accelerate/state.py\n+++ b/src/accelerate/state.py\n@@ -797,6 +797,18 @@ def default_... | [
{
"diff_hunk": "@@ -797,6 +797,18 @@ def default_device(self) -> torch.device:\n else:\n return torch.device(\"cpu\")\n \n+ def __getattr__(self, name: str):\n+ try:\n+ # First try the normal way\n+ return object.__getattribute__(self, name)",
"line": null... | 1b5b9f3b704b77fbe8eb8f88ca4f1b6428d898d9 | diff --git a/src/accelerate/state.py b/src/accelerate/state.py
index 3e3a66d5d18..3f7869fcc13 100644
--- a/src/accelerate/state.py
+++ b/src/accelerate/state.py
@@ -133,6 +133,19 @@ class PartialState:
"""
_shared_state = SharedDict()
+ _known_attrs = [
+ "_cpu",
+ "_mixed_precision",
+ ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
getsentry__sentry-81631@2c50426 | getsentry/sentry | Python | 81,631 | feat(flags): add settings page for webhook secrets | # index: `/settings/feature-flags/`
## Empty state
<img width="1151" alt="SCR-20241203-lyoz" src="https://github.com/user-attachments/assets/ec37b639-7c40-49dd-9c52-46029919ea5b">
## Table populated
<img width="1191" alt="SCR-20241203-oczd" src="https://github.com/user-attachments/assets/a54096be-5eda-4004-878a... | 2024-12-03T22:42:43Z | [Feature Flags] Settings page for secrets
Create org settings page, somewhat similar to auth tokens page. Only 1 secret per provider
- [x] add a "create new secret" button, could be a modal or form (form in a new URL could be easily linked to in the docs)
- [x] pick your provider & input signing secret
- [x] if t... | [
{
"body": "Create org settings page, somewhat similar to auth tokens page. Only 1 secret per provider\n\n- [x] add a \"create new secret\" button, could be a modal or form (form in a new URL could be easily linked to in the docs)\n - [x] pick your provider & input signing secret \n - [x] if the provider alrea... | 42985de24648b7f04e0214a68a2edf981c53bccf | {
"head_commit": "2c504267674093e1ea67c675b32392af01ca2a57",
"head_commit_message": ":sparkles: add feature flag",
"patch_to_review": "diff --git a/static/app/components/events/featureFlags/onboardingIntegrationSection.tsx b/static/app/components/events/featureFlags/onboardingIntegrationSection.tsx\nindex 8c1abab... | [
{
"diff_hunk": "@@ -0,0 +1,201 @@\n+import {Fragment} from 'react';\n+import styled from '@emotion/styled';\n+\n+import {addErrorMessage, addSuccessMessage} from 'sentry/actionCreators/indicator';\n+import Access from 'sentry/components/acl/access';\n+import {LinkButton} from 'sentry/components/button';\n+impor... | 81cf533c2dc87e8c5949b63728eeb416463e1c81 | diff --git a/static/app/components/events/featureFlags/onboardingIntegrationSection.tsx b/static/app/components/events/featureFlags/onboardingIntegrationSection.tsx
index 8c1abab9345b84..738d2eebaf314e 100644
--- a/static/app/components/events/featureFlags/onboardingIntegrationSection.tsx
+++ b/static/app/components/ev... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
getsentry__sentry-83254@b6b8352 | getsentry/sentry | Python | 83,254 | feat(taskworker) Add concurrent worker | Move the taskworker process to be a multiprocess concurrent worker. This will help enable higher CPU usage in worker pods, as we can pack more concurrent CPU operations into each pod (at the cost of memory).
The main process is responsible for:
- Spawning children
- Making RPC requests to fill child queues and s... | 2025-01-10T19:57:17Z | Make taskworker worker support concurrent work
The current worker implementation is single threaded and will have limited throughput. Expand the worker to support concurrent processing based on CLI flags. `--concurrency=12` should create 12 worker threads/processes allowing a worker to process up to 12 tasks concurrent... | [
{
"body": "The current worker implementation is single threaded and will have limited throughput. Expand the worker to support concurrent processing based on CLI flags. `--concurrency=12` should create 12 worker threads/processes allowing a worker to process up to 12 tasks concurrently.\n\nRough thinking would ... | 2c97aba19b21753ab44714152f93691209f14c63 | {
"head_commit": "b6b8352574324a0a0cffc03ef51af34aac7cc310",
"head_commit_message": "More coverage for fetching next task",
"patch_to_review": "diff --git a/src/sentry/runner/commands/run.py b/src/sentry/runner/commands/run.py\nindex 193a5ec171eb12..6a15b17673ed76 100644\n--- a/src/sentry/runner/commands/run.py\n... | [
{
"diff_hunk": "@@ -65,137 +51,84 @@ def get_at_most_once_key(namespace: str, taskname: str, task_id: str) -> str:\n return f\"tw:amo:{namespace}:{taskname}:{task_id}\"\n \n \n-class TaskWorker:\n- \"\"\"\n- A TaskWorker fetches tasks from a taskworker RPC host and handles executing task activations.\... | bd5654cd1928d1311d31b0a5ac20058ab7a6f3fa | diff --git a/src/sentry/runner/commands/run.py b/src/sentry/runner/commands/run.py
index 193a5ec171eb12..6a15b17673ed76 100644
--- a/src/sentry/runner/commands/run.py
+++ b/src/sentry/runner/commands/run.py
@@ -242,6 +242,7 @@ def worker(ignore_unknown_queues: bool, **options: Any) -> None:
@click.option(
"--max-... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
huggingface__accelerate-2561@a28fa3d | huggingface/accelerate | Python | 2,561 | Allow notebook_launcher to launch to multiple GPUs from Colab | # What does this PR do?
Prior behavior for `notebook_launcher` was to ignore the `num_processes` parameter if `in_colab` and simply launch to one CPU/GPU. Since multiple GPUs can be accessed through Colab if the connected VM has multiple GPUs, this behavior was removed. If running in Colab and `num_processes` was un... | 2024-03-17T19:06:38Z | Can't utilize multiple GPUs on Colab environment
### System Info
```Shell
- `Accelerate` version: 0.27.2
- Platform: Linux-6.1.58+-x86_64-with-glibc2.35
- Python version: 3.10.12
- Numpy version: 1.23.5
- PyTorch version (GPU?): 2.1.0+cu121 (True)
- PyTorch XPU available: False
- PyTorch NPU available: False
- ... | This is quite new having colab support multiple GPUs, so thanks for letting us know that this is something that's possible now. This was this behavior before because colab did not have this capability.
Do note that `accelerate config`/`notebook_launcher` are not tied in any way. If you're doing that please just run... | [
{
"body": "### System Info\n\n```Shell\n- `Accelerate` version: 0.27.2\r\n- Platform: Linux-6.1.58+-x86_64-with-glibc2.35\r\n- Python version: 3.10.12\r\n- Numpy version: 1.23.5\r\n- PyTorch version (GPU?): 2.1.0+cu121 (True)\r\n- PyTorch XPU available: False\r\n- PyTorch NPU available: False\r\n- System RAM: 1... | 290446d446985af3a42357546e1a4f7ffb7655c4 | {
"head_commit": "a28fa3d309815cffc7f2682be4de2d2cbc8f7868",
"head_commit_message": "clarified documentation on notebook_launcher (that config file is ignored by notebook_launcher)",
"patch_to_review": "diff --git a/docs/source/basic_tutorials/notebook.md b/docs/source/basic_tutorials/notebook.md\nindex b1aaab935... | [
{
"diff_hunk": "@@ -124,14 +124,14 @@ def train(*args):\n launcher = PrepareForLaunch(function, distributed_type=\"TPU\")\n print(f\"Launching a training on {num_processes} TPU cores.\")\n xmp.spawn(launcher, args=args, nprocs=num_processes, start_method=\"fork\")\n- elif in_colab:\n-... | f528190285666ca141328dddc7596580d7314a44 | diff --git a/docs/source/basic_tutorials/notebook.md b/docs/source/basic_tutorials/notebook.md
index b1aaab93553..724002e50fb 100644
--- a/docs/source/basic_tutorials/notebook.md
+++ b/docs/source/basic_tutorials/notebook.md
@@ -443,6 +443,12 @@ epoch 4: 94.71
And that's it!
+Please note that [`notebook_launcher`]... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
huggingface__accelerate-2151@80d4129 | huggingface/accelerate | Python | 2,151 | Add warning for problematic libraries | # What does this PR do?
Since this is a **very** common issue, adds a check in `notebook_launcher` for specific libraries that are *known* to cause issues (such as starting CUDA forks *on import*).
Fixes https://github.com/huggingface/accelerate/issues/2148
## Before submitting
- [ ] This PR fixes a typo o... | 2023-11-14T17:33:52Z | notebook_launcher fails when loading model from_pretrained
### System Info
```Shell
- `Accelerate` version: 0.25.0.dev0
- Platform: Linux-6.2.0-36-generic-x86_64-with-glibc2.35
- Python version: 3.9.18
- Numpy version: 1.25.0
- PyTorch version (GPU?): 2.0.1+cu117 (True)
- PyTorch XPU available: False
- PyTor... | Pretty sure AutoModel will move the model to CUDA. I would check that, and keep that under your a() function if so.
If that were the case, then the official example for the notebook_launcher would fail too ([link](https://github.com/huggingface/notebooks/blob/main/examples/accelerate_examples/simple_nlp_example.ipynb)... | [
{
"body": "### System Info\r\n\r\n```Shell\r\n- `Accelerate` version: 0.25.0.dev0\r\n- Platform: Linux-6.2.0-36-generic-x86_64-with-glibc2.35\r\n- Python version: 3.9.18\r\n- Numpy version: 1.25.0\r\n- PyTorch version (GPU?): 2.0.1+cu117 (True)\r\n- PyTorch XPU available: False\r\n- PyTorch NPU available: False... | 8dedb140ef8995b4ff6f4b0e2452369a0ab1a969 | {
"head_commit": "80d41296276bda3ed506ecd8b6e73b6ef64321ef",
"head_commit_message": "Rm comment",
"patch_to_review": "diff --git a/src/accelerate/launchers.py b/src/accelerate/launchers.py\nindex 310e52c313d..b381469d1f3 100644\n--- a/src/accelerate/launchers.py\n+++ b/src/accelerate/launchers.py\n@@ -19,7 +19,7 ... | [
{
"diff_hunk": "@@ -48,3 +50,12 @@ def parse_flag_from_env(key, default=False):\n def parse_choice_from_env(key, default=\"no\"):\n value = os.environ.get(key, str(default))\n return value\n+\n+\n+def are_libraries_initialized(library_names: list = []) -> Dict[str, bool]:\n+ \"\"\"\n+ Checks if an... | 8bbb3c2bee1f3a3317138fb5a739bcf86526c87f | diff --git a/src/accelerate/launchers.py b/src/accelerate/launchers.py
index 310e52c313d..0e32d84d06d 100644
--- a/src/accelerate/launchers.py
+++ b/src/accelerate/launchers.py
@@ -19,7 +19,7 @@
import torch
from .state import AcceleratorState, PartialState
-from .utils import PrecisionType, PrepareForLaunch, is_mp... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
getsentry__sentry-79775@2379cb7 | getsentry/sentry | Python | 79,775 | feat(devtool): Refresh issue and feedback panels on page nav | Refresh the issue and feedback panels on page navigation using `startNavigationSpan`. This also gives the transaction name in the callback so we don't need to get the name from the scope.
**Caveat** is that this only works if perf is enabled and using browser tracing instrumentation
https://github.com/user-attachm... | 2024-10-25T16:31:25Z | [DevToolbar] Open Issue and Feedback panels should respond and update themselves when the current transaction name changes
In the toolbar PoC on sentry.io once a panel is open the data inside it won't really change... Instead the panel should always show data relevant to the current url in the browser. So as the url ch... | [
{
"body": "In the toolbar PoC on sentry.io once a panel is open the data inside it won't really change... Instead the panel should always show data relevant to the current url in the browser. So as the url changes, or as the transaction name changes from `/issues` to `/issues/:issueId` we should be re-rendering... | 213aecb2224b561885aed37fe31ea84bab9787b3 | {
"head_commit": "2379cb79511a3f1c5880fbd42cf7b236d1a61ca2",
"head_commit_message": "try using startNavigationSpan",
"patch_to_review": "diff --git a/static/app/components/devtoolbar/components/feedback/feedbackPanel.tsx b/static/app/components/devtoolbar/components/feedback/feedbackPanel.tsx\nindex 4033ace888136... | [
{
"diff_hunk": "@@ -13,7 +16,20 @@ import PanelLayout from '../panelLayout';\n import useInfiniteIssuesList from './useInfiniteIssuesList';\n \n export default function IssuesPanel() {\n- const transactionName = useCurrentTransactionName();\n+ const {scope, client} = useScopeAndClient();\n+ const [transactio... | 2205b83e383e4b509794b48c8dd4217218cbb98d | diff --git a/static/app/components/devtoolbar/components/feedback/feedbackPanel.tsx b/static/app/components/devtoolbar/components/feedback/feedbackPanel.tsx
index 4033ace888136b..4b2a5a60ef4fba 100644
--- a/static/app/components/devtoolbar/components/feedback/feedbackPanel.tsx
+++ b/static/app/components/devtoolbar/com... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
huggingface__accelerate-2132@eda082f | huggingface/accelerate | Python | 2,132 | Raise error when saving with param on meta device | # what does this PR do ?
This PR fixes the `save_model` method when a user tries to use it on a model with some parameters on the `meta` device. I didn't check the `hf_device_map` since it is not the only case where a user might move the model to the meta device. However, the warning that we have put in the dispatch f... | 2023-11-07T20:14:26Z | accelerator.save_model(): NotImplementedError: Cannot copy out of meta tensor; no data!
### System Info
Hi,
I just tried to save a model with "safe_serialization=True" and I got this error ("safe_serialization=False" works):
Like: accelerator.save_model(model, save_dir, safe_serialization=True)
File "/hom... | Hi @blap ,thanks for reporting ! You can't save a model that has been offloaded to the cpu/disk as some of the tensors are on the `meta` device. Furthermore, you shouldn't have to save the model since it is not possible to train de model when some of the parameters are offloaded. In the case of `safe_serialization=Fals... | [
{
"body": "### System Info\r\n\r\nHi,\r\n\r\nI just tried to save a model with \"safe_serialization=True\" and I got this error (\"safe_serialization=False\" works):\r\n\r\nLike: accelerator.save_model(model, save_dir, safe_serialization=True)\r\n\r\n File \"/home/blap/AutoGPTQ-env/lib/python3.10/site-packages... | e638b1e21a52aa6b7846ce4b753401e1a1bcbfad | {
"head_commit": "eda082f4ed5619885f17bfe98c3f43b41973e16a",
"head_commit_message": "style",
"patch_to_review": "diff --git a/src/accelerate/accelerator.py b/src/accelerate/accelerator.py\nindex cc34cd5cb1c..40fd064508f 100755\n--- a/src/accelerate/accelerator.py\n+++ b/src/accelerate/accelerator.py\n@@ -2580,6 +... | [
{
"diff_hunk": "@@ -2580,6 +2580,10 @@ def save_model(\n \n os.makedirs(save_directory, exist_ok=True)\n \n+ for param in model.parameters():\n+ if param.device == torch.device(\"meta\"):\n+ raise RuntimeError(\"You can't save the model since some parameters are on the m... | 11ac38d4fad6183455d5650e723a992d94af4f76 | diff --git a/src/accelerate/accelerator.py b/src/accelerate/accelerator.py
index 68a033cea36..5407395a0df 100755
--- a/src/accelerate/accelerator.py
+++ b/src/accelerate/accelerator.py
@@ -2574,6 +2574,9 @@ def save_model(
logger.error(f"Provided path ({save_directory}) should be a directory, not a file")
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
getsentry__sentry-79601@70b709a | getsentry/sentry | Python | 79,601 | ref(devtools): Return current transaction name and search term | This gets the current transaction name from an instance of the JS SDK, and turns it into an issue search-query.
We get the transaction name from the window's Sentry SDK instead of importing Sentry. The way to access the scope of the SDK changed in v8.6.0, so there's a new way and a legacy way to access the scope. This... | 2024-10-23T15:51:47Z | [DevToolbar] Create a function to return the current transaction name from an instance of the js sdk
I want to have a function that accepts an instance of the sentry SDK and reads off the name of the current transaction.
We're going to convert that transaction name into an issue search-query, so we can find all issues... | cc @c298lee
Here is some code from Spotlight which does detection of the SDK and gets a reference automatically: https://github.com/getsentry/spotlight/blob/e41f7c3efaef589029bd947ff7c49eec080d9ab4/packages/overlay/src/integrations/sentry/index.ts#L260-L280
we should borrow that to start!
We also want to convert non ... | [
{
"body": "I want to have a function that accepts an instance of the sentry SDK and reads off the name of the current transaction.\n\nWe're going to convert that transaction name into an issue search-query, so we can find all issues related to that transaction name. So if the sdk says a transaction name is `/is... | 5a937ece87586f4c73051726bd3f6f4c6ad8993d | {
"head_commit": "70b709a5c7b3efa23f8a229229769fb94dc84ba5",
"head_commit_message": "remove comment",
"patch_to_review": "diff --git a/static/app/components/devtoolbar/hooks/useCurrentTransactionName.test.tsx b/static/app/components/devtoolbar/hooks/useCurrentTransactionName.test.tsx\nnew file mode 100644\nindex ... | [
{
"diff_hunk": "@@ -1,8 +1,88 @@\n-import * as Sentry from '@sentry/react';\n+import type {Scope} from '@sentry/types';\n+\n+type V8Carrier = {\n+ stack: {\n+ getScope?: () => Scope;\n+ };\n+};\n+\n+type LegacyCarrier = {\n+ /** pre-v8 way of accessing scope (v7 and earlier) */\n+ hub?: {\n+ getScope?... | 6e82fd4d734fc2016ffdf7b304a2525305378732 | diff --git a/static/app/components/devtoolbar/hooks/useCurrentTransactionName.test.tsx b/static/app/components/devtoolbar/hooks/useCurrentTransactionName.test.tsx
new file mode 100644
index 00000000000000..c5fd2a04dea85f
--- /dev/null
+++ b/static/app/components/devtoolbar/hooks/useCurrentTransactionName.test.tsx
@@ -0... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
huggingface__accelerate-1919@5ec951b | huggingface/accelerate | Python | 1,919 | fix torch compile with FSDP | # What does this PR do?
1. Fixes https://github.com/huggingface/accelerate/issues/1889 | 2023-09-01T07:40:49Z | ValueError: Expected _orig_mod to NOT be FullyShardedDataParallel if using an `auto_wrap_policy`
### System Info
```Shell
- `Accelerate` version: 0.22.0
- Platform: Linux-5.4.0-121-generic-x86_64-with-glibc2.31
- Python version: 3.10.11
- Numpy version: 1.24.3
- PyTorch version (GPU?): 2.0.1 (True)
- PyTorch X... | cc @pacman100
Hello, I'm able to run it if I remove the torch compile config `dynamo_config: {'dynamo_backend': 'INDUCTOR'}`. torch compile seems to be causing issues with FSDP. Could you raise this issue with the PyTorch team as it doesn't pertain to the integration.
Hello, I looked into this, and the above PR should... | [
{
"body": "### System Info\r\n\r\n```Shell\r\n- `Accelerate` version: 0.22.0\r\n- Platform: Linux-5.4.0-121-generic-x86_64-with-glibc2.31\r\n- Python version: 3.10.11\r\n- Numpy version: 1.24.3\r\n- PyTorch version (GPU?): 2.0.1 (True)\r\n- PyTorch XPU available: False\r\n- PyTorch NPU available: False\r\n- Sys... | 727d624322c67db66a43c559d8c86414d5ffb537 | {
"head_commit": "5ec951b516a095f1a1dafc8e6e88e32bc95ca3d0",
"head_commit_message": "addressing comments",
"patch_to_review": "diff --git a/src/accelerate/accelerator.py b/src/accelerate/accelerator.py\nindex 701dfb2ba30..f9f9b9fa2ab 100755\n--- a/src/accelerate/accelerator.py\n+++ b/src/accelerate/accelerator.py... | [
{
"diff_hunk": "@@ -1215,7 +1216,11 @@ def prepare(self, *args, device_placement=None):\n for obj in args:\n if isinstance(obj, torch.nn.Module):\n model_count += 1\n- is_type_fsdp = type(obj) == FSDP\n+ # if the model is comp... | 2041fa7cea30e4c67431eb7950fb83300524b8af | diff --git a/src/accelerate/accelerator.py b/src/accelerate/accelerator.py
index 701dfb2ba30..58e294c7efc 100755
--- a/src/accelerate/accelerator.py
+++ b/src/accelerate/accelerator.py
@@ -96,6 +96,7 @@
wait_for_everyone,
)
from .utils.constants import FSDP_PYTORCH_VERSION
+from .utils.other import is_compiled_m... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
freqtrade__freqtrade-10902@00318be | freqtrade/freqtrade | Python | 10,902 | feat: enhance data fetching logic with pagination to increase market … |
<!-- Thank you for sending your pull request. But first, have you included
unit tests, and is your code PEP8 conformant? [More details](https://github.com/freqtrade/freqtrade/blob/develop/CONTRIBUTING.md)
-->
## Summary
enhance data fetching logic with pagination to increase market cap rank limit
closes #107... | 2024-11-08T06:55:13Z | Unlimited Marketcap Pairlist?
<!--
Note: this section will not show up in the issue.
Have you search for this feature before requesting it? It's highly likely that a similar request was already filed.
-->
## Describe your environment
(if applicable)
* Operating system: Windows Server 2022
* Python Versi... | Is it technically possible? sure - it's pagination.
is it worth our time to implement, ensure it's correctly working and maintaining it in the future?
I don't think so - unless you can provide a _very compelling_ reason to do so.
It's not a responsability question either - but simply a "it's a pointless feature w... | [
{
"body": "<!-- \r\nNote: this section will not show up in the issue.\r\nHave you search for this feature before requesting it? It's highly likely that a similar request was already filed.\r\n-->\r\n\r\n## Describe your environment\r\n(if applicable)\r\n\r\n * Operating system: Windows Server 2022\r\n * Pytho... | 5ca102ffee403e6a04ad69c042e542d733464906 | {
"head_commit": "00318be59fe0711cb31fa21f843b162033cb661e",
"head_commit_message": "chore: Convert page number to string to ensure type compatibility",
"patch_to_review": "diff --git a/freqtrade/plugins/pairlist/MarketCapPairList.py b/freqtrade/plugins/pairlist/MarketCapPairList.py\nindex 2394e910ec7..b925d0b21e... | [
{
"diff_hunk": "@@ -56,8 +57,8 @@ def __init__(self, *args, **kwargs) -> None:\n f\"You can choose from {category_ids}\"\n )\n \n- if self._max_rank > 250:\n- raise OperationalException(\"This filter only support marketcap rank up to 250.\")\n+ ... | 3a81b6a08f83864c63f2010a92ec5e638d24af60 | diff --git a/docs/includes/pairlists.md b/docs/includes/pairlists.md
index 8d79a7bc1cb..7e465980723 100644
--- a/docs/includes/pairlists.md
+++ b/docs/includes/pairlists.md
@@ -352,7 +352,7 @@ The optional `bearer_token` will be included in the requests Authorization Heade
#### MarketCapPairList
-`MarketCapPairLis... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
freqtrade__freqtrade-10485@1039917 | freqtrade/freqtrade | Python | 10,485 | Add exit signals to export in backtesting | ## Summary
Adding exit signals as data frame to be analysed during backtesting analysis.
Solve the issue: #8902
## Quick changelog
- Store exit_signals in a separate `.pkl` file
## What's new?
- Provides a way to deepdive into backtesting analysis by making indicators available from exit signals as we... | 2024-08-02T10:32:24Z | backtesting-analysis - show signal candle indicators for exit signals
## Describe your environment
* Operating system: _Docker___
* Python Version: __Python 3.11.4
* CCXT version: __ccxt==3.1.44
* Freqtrade Version: __docker-2023.6.dev-e16c433c
In reference to backtesting analysis I can only see sig... | it's .. not immediately clear what you're looking for if i'm honest.
`backtesting-analysis` is looking at enter-reasons - and you can do the same for exit-reasons if that's what you're asking
If not - then please try to phrase your question differently, or more in detial what you're getting on the entry side, but n... | [
{
"body": "## Describe your environment\r\n\r\n * Operating system: _Docker___\r\n * Python Version: __Python 3.11.4\r\n * CCXT version: __ccxt==3.1.44\r\n * Freqtrade Version: __docker-2023.6.dev-e16c433c\r\n \r\nIn reference to backtesting analysis I can only see signal candle indicators for buy signals.... | 9429657a2b526a9cb11d52f87fc79e4e299e9179 | {
"head_commit": "103991746bfe29725a1634f1157c9b344e0b23a7",
"head_commit_message": "chore: type safety and refactoring",
"patch_to_review": "diff --git a/docs/advanced-backtesting.md b/docs/advanced-backtesting.md\nindex 563e5df08b8..c01d763f8c6 100644\n--- a/docs/advanced-backtesting.md\n+++ b/docs/advanced-bac... | [
{
"diff_hunk": "@@ -25,8 +25,8 @@\n \n \n def generate_trade_signal_candles(\n- preprocessed_df: Dict[str, DataFrame], bt_results: Dict[str, Any]\n-) -> DataFrame:\n+ preprocessed_df: Dict[str, DataFrame], bt_results: Dict[str, Any], analysis_on=\"open_date\"",
"line": null,
"original_line": 28,
... | 0858e0a21ecfc6be391bf9f79741a32a3f4a5bbd | diff --git a/docs/advanced-backtesting.md b/docs/advanced-backtesting.md
index 563e5df08b8..b97db79c527 100644
--- a/docs/advanced-backtesting.md
+++ b/docs/advanced-backtesting.md
@@ -18,15 +18,13 @@ freqtrade backtesting -c <config.json> --timeframe <tf> --strategy <strategy_nam
```
This will tell freqtrade to ou... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
getsentry__sentry-81319@a7022c0 | getsentry/sentry | Python | 81,319 | test(taskbroker): Add CLI command for sending taskbroker tasks | ### Overview
This PR is responsible for adding a CLI tool for sending tasks to the taskbroker to assist with iterative local development.
Refs: https://github.com/getsentry/sentry/issues/81240
### Testing
```
sentry run taskbroker-send-tasks --task-function-path sentry.taskworker.tasks.example.say_hello --ar... | 2024-11-26T18:02:23Z | Add command line tool for creating tasks
Would be great for local development if we could have a way to trigger a single task
```
sentry send_task namespace:task_id --args '["one", 2]' --kwargs '{"k": "v"}' --repeat 100
```
this would let folks do iterative development locally more easily as they can generate tasks, ... | [
{
"body": "Would be great for local development if we could have a way to trigger a single task\n\n```\nsentry send_task namespace:task_id --args '[\"one\", 2]' --kwargs '{\"k\": \"v\"}' --repeat 100\n```\n\nthis would let folks do iterative development locally more easily as they can generate tasks, or script ... | 2f93a45c5df00189f0e4fa04b5a1c424cfe888d7 | {
"head_commit": "a7022c09f704f2f1b1912edce06eb636b2d32bf6",
"head_commit_message": "use args and kwargs",
"patch_to_review": "diff --git a/src/sentry/runner/commands/run.py b/src/sentry/runner/commands/run.py\nindex 1c17cbf8d85712..c9a29ff3e5ce77 100644\n--- a/src/sentry/runner/commands/run.py\n+++ b/src/sentry/... | [
{
"diff_hunk": "@@ -0,0 +1,13 @@\n+from __future__ import annotations\n+\n+import logging\n+\n+from sentry.taskworker.registry import taskregistry\n+\n+logger = logging.getLogger(__name__)\n+demotasks = taskregistry.create_namespace(name=\"demos\")\n+\n+\n+@demotasks.register(name=\"demos.say_hello\")\n+def say... | 36396ee44108b4045b907b51f25566b6a07054b4 | diff --git a/src/sentry/runner/commands/run.py b/src/sentry/runner/commands/run.py
index 1c17cbf8d85712..41a2acbd5d97e7 100644
--- a/src/sentry/runner/commands/run.py
+++ b/src/sentry/runner/commands/run.py
@@ -253,6 +253,53 @@ def taskworker(rpc_host: str, max_task_count: int, **options: Any) -> None:
raise S... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "New Feature Additions"
} | |
freqtrade__freqtrade-9945@a4541fd | freqtrade/freqtrade | Python | 9,945 | Nitpicking documentation: | <!-- Thank you for sending your pull request. But first, have you included
unit tests, and is your code PEP8 conformant? [More details](https://github.com/freqtrade/freqtrade/blob/develop/CONTRIBUTING.md)
-->
## Summary
<!-- Explain in one sentence the goal of this PR -->
Solve the issue: #9944
## Quick cha... | 2024-03-12T09:56:08Z | Documentation enhancment
<!--
Note: this section will not show up in the issue.
Have you search for this feature before requesting it? It's highly likely that a similar request was already filed.
-->
## Describe your environment
(if applicable)
* Operating system: Linux 6.7.9-zen1-1-zen
* Python Version... | [
{
"body": "<!-- \r\nNote: this section will not show up in the issue.\r\nHave you search for this feature before requesting it? It's highly likely that a similar request was already filed.\r\n-->\r\n\r\n## Describe your environment\r\n(if applicable)\r\n\r\n * Operating system: Linux 6.7.9-zen1-1-zen\r\n * Py... | a68fbb7f0cebfb486795a63a7d43f9dfdde61de4 | {
"head_commit": "a4541fda2fd827bf78f09a11540c86b9011f8a7b",
"head_commit_message": "Nitpicking documentation:\n\n- Clarify order_types.stoploss_on_exchange\n- Detail available_capital ammendments\n- Clarify BNB fee reduction when BNB runs out on Binance\n- Explain PrecisionFilter",
"patch_to_review": "diff --git... | [
{
"diff_hunk": "@@ -68,6 +68,8 @@ Binance supports [time_in_force](configuration.md#understand-order_time_in_force\n For Binance, it is suggested to add `\"BNB/<STAKE>\"` to your blacklist to avoid issues, unless you are willing to maintain enough extra `BNB` on the account or unless you're willing to disable u... | ec23fec3e6a2f2afa06c7a0a84fdfff6a180155b | diff --git a/docs/configuration.md b/docs/configuration.md
index 2fc54668a80..51c97ae80c7 100644
--- a/docs/configuration.md
+++ b/docs/configuration.md
@@ -326,6 +326,8 @@ You'd set `available_capital=5000` - granting each bot an initial capital of 500
The bot will then split this starting balance equally into `max_o... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "Documentation Updates"
} | |
huggingface__accelerate-1570@8ecf6dd | huggingface/accelerate | Python | 1,570 | Introduce listify, fix tensorboard silently failing | Solves https://github.com/huggingface/accelerate/issues/1546 by introducing a utility which will recursively convert all tensors in a dictionary/list of dictionaries/etc/etc into pure lists of digits. This is needed for tensorboard to log, as it also can't take in numpy arrays either (tried this first, to just bring in... | 2023-06-09T16:16:13Z | accelerator.log(...) silently does nothing when logging a torch.Tensor to TensorBoard
### System Info
```Shell
accelerate==0.16.0
```
### Information
- [ ] The official example scripts
- [X] My own modified scripts
### Tasks
- [ ] One of the scripts in the examples/ folder of Accelerate or an officially supported... | [
{
"body": "### System Info\n\n```Shell\naccelerate==0.16.0\n```\n\n\n### Information\n\n- [ ] The official example scripts\n- [X] My own modified scripts\n\n### Tasks\n\n- [ ] One of the scripts in the examples/ folder of Accelerate or an officially supported `no_trainer` script in the `examples` folder of the ... | e41864ce9d6bf5138961339a98a3ab550e9264c5 | {
"head_commit": "8ecf6dd0a640f8a5cfa1ea96e575bbed056f4da9",
"head_commit_message": "Clean imports and make note",
"patch_to_review": "diff --git a/src/accelerate/tracking.py b/src/accelerate/tracking.py\nindex d1a502ceb0a..553938eb2ff 100644\n--- a/src/accelerate/tracking.py\n+++ b/src/accelerate/tracking.py\n@@... | [
{
"diff_hunk": "@@ -224,6 +224,29 @@ def find_batch_size(data):\n return data.shape[0]\n \n \n+def untensorify(data):",
"line": null,
"original_line": 227,
"original_start_line": null,
"path": "src/accelerate/utils/operations.py",
"start_line": null,
"text": "@user1:\nShould be `list... | cbfefce767fee4245f4ee86c88610149a512b6b4 | diff --git a/src/accelerate/tracking.py b/src/accelerate/tracking.py
index d1a502ceb0a..4fd5b2a786f 100644
--- a/src/accelerate/tracking.py
+++ b/src/accelerate/tracking.py
@@ -32,6 +32,7 @@
is_mlflow_available,
is_tensorboard_available,
is_wandb_available,
+ listify,
)
@@ -236,6 +237,7 @@ def lo... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
huggingface__accelerate-1545@fa958dc | huggingface/accelerate | Python | 1,545 | Add mps support to big model inference | # What does this PR do
This PR add the support for M1/M2 MacOS to big model inference.
The main highlights of this PR are as follows:
- device_map = 'auto' will now detect mps device if available and set the device_map correctly. Since memory is shared between the GPU and CPU, modules are placed on the MPS devi... | 2023-06-06T19:47:07Z | device_map issue with M1_M2 MacOS
### System Info
Hi,
I am on M2 MAX CHIP MACOS that has 12 CPU, 38 GPU. I am having issue with ever modification of this code snippet. Would you please tell me how I can correct it?
### Who can help?
_No response_
### Information
- [ ] The official example scripts
- [ ] My own ... | This does not work yet indeed., this is known and is on our roadmap.
Hi,
Thanks for the reply.
I hope this will come into play. I purchased very expensive MacOS to continue on ML, but apparently I can not use it for now to implement this type of things.
Is there a way to import pdf and then chat with it using this ... | [
{
"body": "### System Info\n\nHi,\r\nI am on M2 MAX CHIP MACOS that has 12 CPU, 38 GPU. I am having issue with ever modification of this code snippet. Would you please tell me how I can correct it?\r\n\n\n### Who can help?\n\n_No response_\n\n### Information\n\n- [ ] The official example scripts\n- [ ] My own m... | 62357f218f72cce88b8e086cc372b15c119b590b | {
"head_commit": "fa958dc18ae47b49cf56c2f92cc6325f9b02a61f",
"head_commit_message": "Fix syntax\n\nCo-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>",
"patch_to_review": "diff --git a/src/accelerate/big_modeling.py b/src/accelerate/big_modeling.py\nindex 8b6d6bcb81b..4aecef26227 100644\n-... | [
{
"diff_hunk": "@@ -694,8 +694,10 @@ def infer_auto_device_map(\n # Devices that need to keep space for a potential offloaded layer.\n if \"mps\" in gpus:\n main_devices = [\"mps\"]\n+ elif len(gpus) > 0:\n+ main_devices = [gpus[0], \"cpu\"] if len(gpus) > 0",
"line": null,
"or... | 322f2109dd4d6a41ab5676a31721a2f962acd216 | diff --git a/src/accelerate/big_modeling.py b/src/accelerate/big_modeling.py
index 8b6d6bcb81b..4aecef26227 100644
--- a/src/accelerate/big_modeling.py
+++ b/src/accelerate/big_modeling.py
@@ -358,7 +358,7 @@ def dispatch_model(
name: main_device if device in ["cpu", "disk"] else device for name, device in dev... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
huggingface__accelerate-1514@03d74bb | huggingface/accelerate | Python | 1,514 | Fix a bug when parameters tied belong to the same module | This fixes a edge case in `infer_auto_device_map` when two sets of parameters are tied and belong to the same module (see #1510 for a reproducer).
Fixes #1510 | 2023-06-02T18:23:50Z | [bug] infer_auto_device_map
### System Info
```Shell
Copy-and-paste the text below in your GitHub issue
- `Accelerate` version: 0.19.0
- Platform: Linux-5.10.16.3-microsoft-standard-WSL2-x86_64-with-glibc2.31
- Python version: 3.9.16
- Numpy version: 1.24.2
- PyTorch version (GPU?): 1.12.1+cu113 (True)
- Syste... | I can reproduce. Will try to have a look later today or early next week. Thanks for the report! | [
{
"body": "### System Info\n\n```Shell\nCopy-and-paste the text below in your GitHub issue\r\n\r\n- `Accelerate` version: 0.19.0\r\n- Platform: Linux-5.10.16.3-microsoft-standard-WSL2-x86_64-with-glibc2.31\r\n- Python version: 3.9.16\r\n- Numpy version: 1.24.2\r\n- PyTorch version (GPU?): 1.12.1+cu113 (True)\r\... | 109f3272f542cbd0e34022f5455078a4ab99d7eb | {
"head_commit": "03d74bb1e8e65c4181c59a8d5ef2d7ae984af18d",
"head_commit_message": "Fix a bug when parameters tied belong to the same module",
"patch_to_review": "diff --git a/src/accelerate/utils/modeling.py b/src/accelerate/utils/modeling.py\nindex 0817c731997..3bd66ca0a99 100644\n--- a/src/accelerate/utils/mo... | [
{
"diff_hunk": "@@ -790,6 +794,7 @@ def infer_auto_device_map(\n )\n current_memory_used += module_size\n device_map[name] = devices[current_device]\n+ print(modules_to_treat)",
"line": null,
"original_line": 797,
"original_start_line": null,
"p... | b8321a7682cc65e2afd7cb2d3d6aae7f2842c6e1 | diff --git a/src/accelerate/utils/modeling.py b/src/accelerate/utils/modeling.py
index 0817c731997..1629617e117 100644
--- a/src/accelerate/utils/modeling.py
+++ b/src/accelerate/utils/modeling.py
@@ -731,8 +731,12 @@ def infer_auto_device_map(
current_memory_used += module_size_with_ties
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
huggingface__accelerate-1446@f3e923b | huggingface/accelerate | Python | 1,446 | Raise error when logging improperly | A user cannot call the logging utility in `Accelerate` without first building the state in some form. This PR introduces an error raising it as such and fixes https://github.com/huggingface/accelerate/issues/1445 | 2023-05-17T14:48:56Z | CPU never used when MPS is available, if logger is used beforehand
### System Info
```Shell
- `Accelerate` version: 0.19.0
- Platform: macOS-13.3.1-arm64-arm-64bit
- Python version: 3.11.3
- Numpy version: 1.24.3
- PyTorch version (GPU?): 2.0.1 (False)
- System RAM: 32.00 GB
- `Accelerate` default config:
-... | The accelerate logger needs to know about your distributed setup when it begins logging, as a result when doing `log()` it spins up an `AcceleratorState`, forcing it to be whatever is in there. For you to do what you would like, the `Accelerator` must be initialized *first* then the logger. | [
{
"body": "### System Info\r\n\r\n```Shell\r\n- `Accelerate` version: 0.19.0\r\n- Platform: macOS-13.3.1-arm64-arm-64bit\r\n- Python version: 3.11.3\r\n- Numpy version: 1.24.3\r\n- PyTorch version (GPU?): 2.0.1 (False)\r\n- System RAM: 32.00 GB\r\n- `Accelerate` default config:\r\n\t- compute_environment: LOCAL... | bc82d1882100f7af48c8ea666d09e2739e800746 | {
"head_commit": "f3e923b64cf9c6984e1ab0407abacf241b40204b",
"head_commit_message": "Raise error when logging",
"patch_to_review": "diff --git a/src/accelerate/logging.py b/src/accelerate/logging.py\nindex 902ddf924cd..49d2dbcfe45 100644\n--- a/src/accelerate/logging.py\n+++ b/src/accelerate/logging.py\n@@ -41,6 ... | [
{
"diff_hunk": "@@ -41,6 +41,10 @@ def log(self, level, msg, *args, **kwargs):\n Accepts a new kwarg of `main_process_only`, which will dictate whether it will be logged across all processes\n or only the main executed one. Default is `True` if not passed\n \"\"\"\n+ if PartialSta... | 9d6388bb5d9ddb8197bfac59590be578a67d3e2c | diff --git a/src/accelerate/logging.py b/src/accelerate/logging.py
index 902ddf924cd..7ee490753a0 100644
--- a/src/accelerate/logging.py
+++ b/src/accelerate/logging.py
@@ -41,6 +41,10 @@ def log(self, level, msg, *args, **kwargs):
Accepts a new kwarg of `main_process_only`, which will dictate whether it will ... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
freqtrade__freqtrade-8184@ade64f2 | freqtrade/freqtrade | Python | 8,184 | Feature market direction | <!-- Thank you for sending your pull request. But first, have you included
unit tests, and is your code PEP8 conformant? [More details](https://github.com/freqtrade/freqtrade/blob/develop/CONTRIBUTING.md)
-->
## Summary
Adds new user set optional field which represents market direction, as well as a telegram comm... | 2023-02-17T22:15:17Z | New variable in Strategy class that can be changed via telegram when bot is running
Variable name :
market_direction = "long" , "short" , ("even" or "side" - one of these 2, which you think fits better as description when market doesn't have a clear direction)
Default startup value will be set in the strategy class,... | while i understand the intend - i don't think that's something we'll be adding / implementing - at least not anytime soon.
The way you propose fits exactly your needs (which is understandable) - but i don't see that generalize well for most strategies.
it will be too restricted for most usecases (maybe i'd like t... | [
{
"body": "Variable name :\r\nmarket_direction = \"long\" , \"short\" , (\"even\" or \"side\" - one of these 2, which you think fits better as description when market doesn't have a clear direction) \r\nDefault startup value will be set in the strategy class, with one of the above 3 parameter.\r\n\r\nAccess and... | c4ec4db050451be6a1164101c976571a52fc10c0 | {
"head_commit": "ade64f25d385d8fffda81b2e6199b7185bdc239a",
"head_commit_message": "fixed formatting",
"patch_to_review": "diff --git a/freqtrade/enums/__init__.py b/freqtrade/enums/__init__.py\nindex 8ef53e12d28..69ef345e81c 100644\n--- a/freqtrade/enums/__init__.py\n+++ b/freqtrade/enums/__init__.py\n@@ -5,6 +... | [
{
"diff_hunk": "@@ -129,7 +129,7 @@ def _init_keyboard(self) -> None:\n r'/weekly$', r'/weekly \\d+$', r'/monthly$', r'/monthly \\d+$',\n r'/forcebuy$', r'/forcelong$', r'/forceshort$',\n r'/forcesell$', r'/forceexit$',\n- r'/edge$', r'/health$', r'/help$', r'/vers... | 0899e5cb8337adde4de58e0b80a578c4af0ed497 | diff --git a/docs/telegram-usage.md b/docs/telegram-usage.md
index 4626944c5d5..653d31ee648 100644
--- a/docs/telegram-usage.md
+++ b/docs/telegram-usage.md
@@ -152,7 +152,7 @@ You can create your own keyboard in `config.json`:
!!! Note "Supported Commands"
Only the following commands are allowed. Command argumen... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
freqtrade__freqtrade-8083@592eebe | freqtrade/freqtrade | Python | 8,083 | Gym aid | Refer to https://github.com/freqtrade/freqtrade/pull/8080
@xmatthias , do you think this way could be any useful for newcomers? | 2023-01-31T15:12:03Z | Running setup.py install for gym did not run successfully.
Running setup.py install for gym ... error
error: subprocess-exited-with-error
## environment
* Operating system: ubuntu-22.04.1-live-server
* Python Version: python3
## Describe the problem:
Hello !
I try to setup freqtrade on Pro... | To be honest - i think `note: This is an issue with the package mentioned above, not pip.` says it all.
We'll need some more info though - for example the output of `python3 --version` and `python -m pip --version` - as well as the system architecture (arm/amd64, ...).
There's a bug report for this in the gym re... | [
{
"body": " Running setup.py install for gym ... error\r\n error: subprocess-exited-with-error\r\n\r\n \r\n\r\n## environment\r\n\r\n * Operating system: ubuntu-22.04.1-live-server\r\n * Python Version: python3\r\n \r\n## Describe the problem:\r\nHello ! \r\nI try to setup freqtrade on ProxmoxVM-ubuntu-22... | 5073c780d8ecbaefb52fce732af701f630d8f565 | {
"head_commit": "592eebe51626f2ab243d3c237cbfdbfaa13e3a35",
"head_commit_message": "Add to setup",
"patch_to_review": "diff --git a/requirements-freqai-rl.txt b/requirements-freqai-rl.txt\nindex 82ff4022dc8..cb77a34c137 100644\n--- a/requirements-freqai-rl.txt\n+++ b/requirements-freqai-rl.txt\n@@ -6,4 +6,5 @@ t... | [
{
"diff_hunk": "@@ -1,6 +1,30 @@\n #!/usr/bin/env bash\n #encoding=utf8\n \n+# This should be deleted as soon as a gym release with a fixed setuptools is made\n+function check_is_new_setuptools_installed() {\n+ stoolversion=$(${PYTHON} -m pip show setuptools | grep \"Version:\")\n+ stoolversion=${stoolversion... | 322d4b53510e27b9f79eed781449412878bab1fc | diff --git a/docs/installation.md b/docs/installation.md
index 9dd14274af8..1c0aed7bad4 100644
--- a/docs/installation.md
+++ b/docs/installation.md
@@ -30,6 +30,12 @@ The easiest way to install and run Freqtrade is to clone the bot Github reposito
!!! Warning "Up-to-date clock"
The clock on the system running th... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Dependency Updates & Env Compatibility"
} |
huggingface__accelerate-1155@5fdb4d9 | huggingface/accelerate | Python | 1,155 | [`Accelerator`] Fix issue with 8bit models | # What does this PR do?
Fixes https://github.com/huggingface/accelerate/issues/1147
In theory it is not possible to fine-tune 8-bit models except if you use adapters that can be used only is a `PeftModel` is used for training (I also need to test the snippet below with a `PeftModel` to make sure this is relevant ... | 2023-03-06T17:25:03Z | Incompatible with 8bit models
### System Info
```Shell
If I load a model in 8bit, it has to be mapped automatically to gpus. However, when `accelerate` tries to load the model to several gpus, I get the following error.
`ValueError: `.to` is not supported for `8-bit` models. Please use the model as it is, since the... | cc @younesbelkada Could you have the same test you did in the Trainer here in Accelerate? | [
{
"body": "### System Info\n\n```Shell\nIf I load a model in 8bit, it has to be mapped automatically to gpus. However, when `accelerate` tries to load the model to several gpus, I get the following error.\r\n\r\n`ValueError: `.to` is not supported for `8-bit` models. Please use the model as it is, since the mod... | cac1ed41eb4d92489fe4a4c3feca21b944faf896 | {
"head_commit": "5fdb4d9acbf1fa8924be8beb69f879eac7ccc984",
"head_commit_message": "add bnb as dependency",
"patch_to_review": "diff --git a/docker/accelerate-gpu/Dockerfile b/docker/accelerate-gpu/Dockerfile\nindex 44aa94b29fb..ae71607d299 100644\n--- a/docker/accelerate-gpu/Dockerfile\n+++ b/docker/accelerate-... | [
{
"diff_hunk": "@@ -1119,8 +1119,27 @@ def prepare_model(self, model: torch.nn.Module, device_placement=None):\n if device_placement is None:\n device_placement = self.device_placement and self.distributed_type != DistributedType.FSDP\n self._models.append(model)\n- if device_... | a38bb57f059f6f9143da365cd7c651bf6a0eb1f1 | diff --git a/docker/accelerate-gpu/Dockerfile b/docker/accelerate-gpu/Dockerfile
index 44aa94b29fb..ae71607d299 100644
--- a/docker/accelerate-gpu/Dockerfile
+++ b/docker/accelerate-gpu/Dockerfile
@@ -25,6 +25,8 @@ RUN source activate accelerate && \
git+https://github.com/huggingface/accelerate#egg=accelerate[tes... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Dependency Updates & Env Compatibility"
} |
home-assistant__core-90248@92720f9 | home-assistant/core | Python | 90,248 | Add proper support for zwave_js Indicator CC | ## Breaking change
On/Off properties for the Indicator CC are no longer discovered as entities. They were previously discovered as sensor entities which were not useful in cases where you wanted to change these values, and you would need to change the value for all three On/Off properties simultaneously in order for t... | 2023-03-24T21:52:59Z | Z-Wave JS: Necessary changes to Indicator CC values
### The problem
As discussed "offline", the values exposed for Indicator CC need to be changed/updated. Here's an overview of what needs to be supported:
**Indicator CC V1** only knows a single value, which needs to be a writable number entity:
```jsonc
{
"... | Hey there @home-assistant/z-wave, mind taking a look at this issue as it has been labeled with an integration (`zwave_js`) you are listed as a [code owner](https://github.com/home-assistant/core/blob/dev/CODEOWNERS#L1408) for? Thanks!
<details>
<summary>Code owner commands</summary>
Code owners of `zwave_js` can tri... | [
{
"body": "### The problem\r\n\r\nAs discussed \"offline\", the values exposed for Indicator CC need to be changed/updated. Here's an overview of what needs to be supported:\r\n\r\n**Indicator CC V1** only knows a single value, which needs to be a writable number entity:\r\n```jsonc\r\n{\r\n \"commandClass\": ... | 89f1677307bff32cf214d187282830f674854197 | {
"head_commit": "92720f9fab9eb370b4289c20e91c4aee9862b179",
"head_commit_message": "add comment so I don't forget",
"patch_to_review": "diff --git a/homeassistant/components/zwave_js/button.py b/homeassistant/components/zwave_js/button.py\nindex 2db82d38d62d13..118f42a2d94bd8 100644\n--- a/homeassistant/componen... | [
{
"diff_hunk": "@@ -782,14 +796,48 @@ def get_config_parameter_discovery_schema(\n property={TARGET_VALUE_PROPERTY},\n )\n ],\n- data_template=NumericSensorDataTemplate(),\n entity_registry_enabled_default=False,\n ),\n+ # number for Indicator CC (exclud... | 6d2250146aeb1fd842c2b87f66f1d82438cf3d41 | diff --git a/homeassistant/components/zwave_js/__init__.py b/homeassistant/components/zwave_js/__init__.py
index 66839026dd4310..8d118fd89f55bd 100644
--- a/homeassistant/components/zwave_js/__init__.py
+++ b/homeassistant/components/zwave_js/__init__.py
@@ -321,6 +321,19 @@ def remove_device(self, device: dr.DeviceEnt... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
freqtrade__freqtrade-7724@037363f | freqtrade/freqtrade | Python | 7,724 | Support git and local changes in dev containers | ## Summary
This PR fixes the problem with git and changes sync in vs code dev container feature
Solve the issue: #7723
## Quick changelog
- postCreateCommand is changed by adding symlink to freqtrade .env directory from the workspace/freqtrade (to have the install environment in the source folder)
- worksp... | 2022-11-09T18:59:12Z | VS Code Dev Container has no access to the local source code
## Describe your environment
* Operating system: Mac OS Ventura 13.0
* Python Version: [container environment]
* CCXT version: [container environment]
* Freqtrade Version: source code in branch develop
## Describe the problem:
I'm not su... | [
{
"body": "## Describe your environment\r\n\r\n * Operating system: Mac OS Ventura 13.0\r\n * Python Version: [container environment]\r\n * CCXT version: [container environment]\r\n * Freqtrade Version: source code in branch develop\r\n\r\n\r\n## Describe the problem:\r\n\r\nI'm not sure if it is a bug or a... | d3006f7f3e7f5e502bb8331f2b85bef089cff995 | {
"head_commit": "037363f9ee3f090acd12284da268cf3489815c9d",
"head_commit_message": "support git and local changes in dev containers #7723",
"patch_to_review": "diff --git a/.devcontainer/devcontainer.json b/.devcontainer/devcontainer.json\nindex 41b8475ec1b..786d317a602 100644\n--- a/.devcontainer/devcontainer.j... | [
{
"diff_hunk": "@@ -35,5 +36,6 @@\n \"davidanson.vscode-markdownlint\",\n \"ms-azuretools.vscode-docker\",\n \"vscode-icons-team.vscode-icons\",\n+ \"github.copilot\",",
"line": null,
"original_line": 39,
"original_start_line": null,
"path": ".devcontainer/devconta... | 4664d5e1d8615879653e8e1328070d8735589f19 | diff --git a/.devcontainer/devcontainer.json b/.devcontainer/devcontainer.json
index 41b8475ec1b..8fb643e8fcf 100644
--- a/.devcontainer/devcontainer.json
+++ b/.devcontainer/devcontainer.json
@@ -11,12 +11,14 @@
"mounts": [
"source=freqtrade-bashhistory,target=/home/ftuser/commandhistory,type=volume"
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
huggingface__accelerate-941@1b14eec | huggingface/accelerate | Python | 941 | raise error for duplicate accelerate config values when using `deepspeed_config_file` | ### What dos this PR do?
1. Fixes: #936
Example:
1. accelerate config manually tweaked to have both `deepspeed_config_file` and other ds config entries that are available in the json config file:
```yaml
command_file: null
commands: null
compute_environment: LOCAL_MACHINE
deepspeed_config:
gradient_accumu... | 2022-12-23T05:45:13Z | [feature] assert on ambiguity config when using deepspeed
OK, so please consider this setup:
```
[...]
deepspeed_config:
deepspeed_multinode_launcher: standard
deepspeed_config_file: ds_config.json
gradient_accumulation_steps: 2
zero3_init_flag: true
zero_stage: 2
zero3_save_16bit_model: true
di... | cc @pacman100
Hello @stas00 , thank you for providing a detailed issue.
One important thing to note from the current design standpoint is that when using the `accelerate config` command to fill out the questionnaire if the user chooses to provide `deepspeed_config_file`, other options aren't asked at all and there... | [
{
"body": "OK, so please consider this setup:\r\n\r\n```\r\n[...]\r\ndeepspeed_config:\r\n deepspeed_multinode_launcher: standard\r\n deepspeed_config_file: ds_config.json\r\n gradient_accumulation_steps: 2\r\n zero3_init_flag: true\r\n zero_stage: 2\r\n zero3_save_16bit_model: true\r\ndistributed_type: D... | 63f09f63b8744ab0bdc7e756deb1e3683d395bfc | {
"head_commit": "1b14eec80f8f0bd14afccfb94df3891538c4fdd1",
"head_commit_message": "address comment",
"patch_to_review": "diff --git a/src/accelerate/commands/launch.py b/src/accelerate/commands/launch.py\nindex 91d4427ac5a..eb641c4c650 100644\n--- a/src/accelerate/commands/launch.py\n+++ b/src/accelerate/comman... | [
{
"diff_hunk": "@@ -549,6 +551,40 @@ def zero3_init_context_manager(self, enable=False):\n self.dschf = None\n self.set_deepspeed_weakref()\n \n+ def _deepspeed_config_checks(self):\n+ env_variable_names_to_ignore = [\n+ \"ACCELERATE_GRADIENT_ACCUMULATION_STEPS\",\n+... | 3733f846499756539be596748d3177bbf24da801 | diff --git a/docs/source/usage_guides/deepspeed.mdx b/docs/source/usage_guides/deepspeed.mdx
index 29561c77bae..0377296c172 100644
--- a/docs/source/usage_guides/deepspeed.mdx
+++ b/docs/source/usage_guides/deepspeed.mdx
@@ -395,6 +395,196 @@ We will look at the changes needed in the code when using these.
based on mo... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
huggingface__accelerate-877@3339476 | huggingface/accelerate | Python | 877 | fix fsdp state_dict_config because of PyTorch changes | ### What does this PR do?
1. Fixes #831 | 2022-11-21T11:41:14Z | FSDP tests fail due to ImportError _state_dict_type_to_config (has been moved inside of set_state_dict_type method
### System Info
```Shell
- `Accelerate` version: 0.15.0.dev0
- Platform: Linux-5.15.68.1-microsoft-standard-WSL2-x86_64-with-glibc2.31
- Python version: 3.9.13
- Numpy version: 1.23.4
- PyTorch versi... | cc @pacman100
Hello @Thomas-MMJ, Thank you for bringing this to the notice. Please use PyTorch 1.13.0 stable version for time-being. We will resolve this issue once PyTorch version 1.14.0 has a stable release. | [
{
"body": "### System Info\n\n```Shell\n- `Accelerate` version: 0.15.0.dev0\r\n- Platform: Linux-5.15.68.1-microsoft-standard-WSL2-x86_64-with-glibc2.31\r\n- Python version: 3.9.13\r\n- Numpy version: 1.23.4\r\n- PyTorch version (GPU?): 1.14.0.dev20221107 (True)\r\n- `Accelerate` default config:\r\n Not ... | 8bf40e587009b9ca70953620d35766132df2feef | {
"head_commit": "3339476687f90358b563960519ee004b1628ed49",
"head_commit_message": "fix fsdp test",
"patch_to_review": "diff --git a/src/accelerate/utils/dataclasses.py b/src/accelerate/utils/dataclasses.py\nindex bb14078d4e2..57ead9be633 100644\n--- a/src/accelerate/utils/dataclasses.py\n+++ b/src/accelerate/ut... | [
{
"diff_hunk": "@@ -616,18 +613,21 @@ def save_model(self, accelerator, model, output_dir, model_index=0):\n from torch.distributed.fsdp.fully_sharded_data_parallel import FullyShardedDataParallel as FSDP\n from torch.distributed.fsdp.fully_sharded_data_parallel import StateDictType\n \n- ... | daf7f1d3bc7696f2e63b0bab63a1a042f720aee0 | diff --git a/src/accelerate/utils/dataclasses.py b/src/accelerate/utils/dataclasses.py
index bb14078d4e2..442b63cf555 100644
--- a/src/accelerate/utils/dataclasses.py
+++ b/src/accelerate/utils/dataclasses.py
@@ -31,6 +31,7 @@
import torch
from .constants import FSDP_AUTO_WRAP_POLICY, FSDP_BACKWARD_PREFETCH, FSDP_S... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
freqtrade__freqtrade-7976@f2fa476 | freqtrade/freqtrade | Python | 7,976 | Hyperopt Max open trades | <!-- Thank you for sending your pull request. But first, have you included
unit tests, and is your code PEP8 conformant? [More details](https://github.com/freqtrade/freqtrade/blob/develop/CONTRIBUTING.md)
-->
## Summary
This pull request is an attempt to add the ability to hyperopt `max_open_trades` and to set `m... | 2023-01-04T12:08:49Z | Add ability to hyperopt max_open_trades
<!--
Note: this section will not show up in the issue.
Have you search for this feature before requesting it? It's highly likely that a similar request was already filed.
-->
## Describe your environment
N/A
## Describe the enhancement
Currently it seems the max_open_... | it actually isn't (not really, anyway) - as `max_open_trades` is a parameter to backtesting - hyperopting it should be pretty easy.
The only "real" problem i see is that `max_open_trades` is currently only configurable from within the configuration (not from the strategy) - so the configuration will (in backtesting)... | [
{
"body": "<!-- \r\nNote: this section will not show up in the issue.\r\nHave you search for this feature before requesting it? It's highly likely that a similar request was already filed.\r\n-->\r\n\r\n## Describe your environment\r\nN/A\r\n\r\n## Describe the enhancement\r\nCurrently it seems the max_open_tra... | 81eb9ebc6e0c8828a6fa5537c44a188daf0d6d49 | {
"head_commit": "f2fa476dc69a9412f705fe1d27bb9a27868bea8d",
"head_commit_message": "max_open_trades should be an integer\n\nMax open trades will be always an integer in the strategy (-1 for infinity), but in the config -1 will be parsed as infinity",
"patch_to_review": "diff --git a/docs/advanced-hyperopt.md b/d... | [
{
"diff_hunk": "@@ -328,6 +341,9 @@ def generate_optimizer(self, raw_params: List[Any]) -> Dict[str, Any]:\n self.backtesting.strategy.trailing_only_offset_is_reached = \\\n d['trailing_only_offset_is_reached']\n \n+ if HyperoptTools.has_space(self.config, 'trades'):\n+ ... | c8ecedf6d56f8f3b22669401f0c3224aa26938d0 | diff --git a/docs/advanced-hyperopt.md b/docs/advanced-hyperopt.md
index 0dace998550..ff0521f4f8a 100644
--- a/docs/advanced-hyperopt.md
+++ b/docs/advanced-hyperopt.md
@@ -75,7 +75,7 @@ This function needs to return a floating point number (`float`). Smaller numbers
## Overriding pre-defined spaces
-To override a... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
getsentry__sentry-78778@17b738e | getsentry/sentry | Python | 78,778 | analytics(toolbar): record api requests in custom middleware | Closes https://github.com/getsentry/sentry-toolbar/issues/33
We're ready to release a developer toolbar for installation on 3rd party sites. Once installed, toolbars will query sentry backend for data - see the [repo](https://github.com/getsentry/sentry-toolbar) or /devtoolbar folder of sentry for examples. This hel... | 2024-10-08T17:50:12Z | [DevToolbar] Analytics for which orgs have the toolbar enabled
I would like to have metrics/analytics on the server side to show what endpoints the toolbar is hitting. This should be possible by looking at incoming requests to the api where the `?queryReferrer=devtoolbar` url query param is set.
The purpose of these ... | @ryan953 could you link the sample dashboards/charts we were looking at?
Update: nvm, I remembered they're Hydration Errors, Rage Clicks, and Replays Search in redash. If there's other good examples lmk. | [
{
"body": "I would like to have metrics/analytics on the server side to show what endpoints the toolbar is hitting. This should be possible by looking at incoming requests to the api where the `?queryReferrer=devtoolbar` url query param is set. \n\nThe purpose of these metrics/analytics would be to:\n- Detect w... | 89bf6460cf99271d126f24fc0e52f9792b2948f0 | {
"head_commit": "17b738e7dfaca3e73c5ba5b6d27f70d30fef9c09",
"head_commit_message": "Rm mixin from base classes",
"patch_to_review": "diff --git a/src/sentry/api/analytics.py b/src/sentry/api/analytics.py\nindex 339c9bc5bc458d..27e3e71928eb27 100644\n--- a/src/sentry/api/analytics.py\n+++ b/src/sentry/api/analyti... | [
{
"diff_hunk": "@@ -0,0 +1,64 @@\n+import logging\n+\n+from sentry import analytics\n+from sentry.utils.http import (\n+ get_api_path_from_request,\n+ origin_from_request,\n+ parse_id_or_slug_param,\n+ query_string,\n+)\n+\n+logger = logging.getLogger(__name__)\n+\n+\n+class AnalyticsMiddleware:",
... | ee5b662869717591dd6ed60943b9bc60d2f186fd | diff --git a/src/sentry/api/analytics.py b/src/sentry/api/analytics.py
index 339c9bc5bc458d..9e170c8a51e545 100644
--- a/src/sentry/api/analytics.py
+++ b/src/sentry/api/analytics.py
@@ -33,6 +33,25 @@ class GroupSimilarIssuesEmbeddingsCountEvent(analytics.Event):
)
+class DevToolbarApiRequestEvent(analytics.E... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
freqtrade__freqtrade-6235@7232324 | freqtrade/freqtrade | Python | 6,235 | Backtest order timeout | ## Summary
Allow backtest orders with custom pricing to fill later (or time out).
this accidentally (on purpose) also closes #6321
## Quick changelog
- Don't autofill orders
- don't move price to be forced within opening candle
## TODO
* [x] call timeout functions
* [x] handle / respect timeout
* [x... | 2022-01-16T18:53:57Z | self.wallets.get_total_stake_amount() returns wrong amount
## Describe your environment
* Operating system: Ubuntu 21.10 (GNU/Linux 5.13.0-27-generic x86_64)
* python3 --version
Python 3.9.7
* CCXT version: pip freeze | grep ccxt
ccxt==1.70.45
* Freqtrade Version: freqtrade --version
freqtrade deve... | This contains the strategy and config i am using in case you need it.
[config_file+strategy.zip](https://github.com/freqtrade/freqtrade/files/7965943/config_file%2Bstrategy.zip)
A quick look at this shows that it's not 100% straightforward to fix without severe impact on performance - therefore i don't think it'll b... | [
{
"body": "## Describe your environment\r\n\r\n * Operating system: Ubuntu 21.10 (GNU/Linux 5.13.0-27-generic x86_64)\r\n\r\n * python3 --version\r\nPython 3.9.7\r\n * CCXT version: pip freeze | grep ccxt\r\nccxt==1.70.45\r\n\r\n * Freqtrade Version: freqtrade --version\r\nfreqtrade develop-aea84dc11\r\n\r\... | 535bbd681fdffb81b29818bccbf0c5b59454a618 | {
"head_commit": "7232324eb7e4cc3e1fb98f2bcf2f27fbb65df6d2",
"head_commit_message": "Update missing doc segment",
"patch_to_review": "diff --git a/docs/bot-basics.md b/docs/bot-basics.md\nindex a9a2628f62f..8c6303063a4 100644\n--- a/docs/bot-basics.md\n+++ b/docs/bot-basics.md\n@@ -62,6 +62,7 @@ This loop will be... | [
{
"diff_hunk": "@@ -697,6 +798,8 @@ def backtest(self, processed: Dict,\n 'config': self.strategy.config,\n 'locks': PairLocks.get_all_locks(),\n 'rejected_signals': self.rejected_trades,\n+ # TODO: timedout_orders should be shown as part of results.\n+ ... | dcf8ad36f9ccb04ee725eaf65e83a7720a5fe315 | diff --git a/docs/backtesting.md b/docs/backtesting.md
index 7420c1decf7..e7846b1f81c 100644
--- a/docs/backtesting.md
+++ b/docs/backtesting.md
@@ -313,6 +313,7 @@ A backtesting result will look like that:
| Avg. Duration Winners | 4:23:00 |
| Avg. Duration Loser | 6:55:00 |
| Rejected Buy... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
freqtrade__freqtrade-5678@45b7a0c | freqtrade/freqtrade | Python | 5,678 | Hyperopt loss function using max drawdown | ## Summary
Hyperopt loss function using max drawdown.
As mentioned [here](https://github.com/freqtrade/freqtrade/issues/5514#issuecomment-909055853), the function calculates a multiplier from drawdown, the lower drawdown is, the higher the multiplier.
closes https://github.com/freqtrade/freqtrade/issues/5514
| 2021-10-06T08:22:15Z | hyperopt loss function max draw down
Hi!
here a small addition to the loss functions already available.
```
from datetime import datetime
from freqtrade.data.btanalysis import calculate_max_drawdown
from freqtrade.optimize.hyperopt import IHyperOptLoss
from pandas import DataFrame
# optimize for max draw d... | The correct / proper way to contribute a new loss function is as Pull request.
pasting finished code into an issue, you're basically dumping it "someplace" - which somehow translates to "throwing it there - do the work to incorporate it properly" ...
---
About the function itself - i fear that with compounding... | [
{
"body": "Hi!\r\n\r\nhere a small addition to the loss functions already available.\r\n\r\n```\r\nfrom datetime import datetime\r\nfrom freqtrade.data.btanalysis import calculate_max_drawdown\r\nfrom freqtrade.optimize.hyperopt import IHyperOptLoss\r\nfrom pandas import DataFrame\r\n\r\n# optimize for max draw... | 11ec1d9b062ae7a063d8b6549cdfd5e468047d63 | {
"head_commit": "45b7a0c8377a5493496abafa70e48b0872d0b4b5",
"head_commit_message": "Add Test and docs for MaxDrawDownHyperOptLoss",
"patch_to_review": "diff --git a/docs/hyperopt.md b/docs/hyperopt.md\nindex 09d43939a87..45e0d444db4 100644\n--- a/docs/hyperopt.md\n+++ b/docs/hyperopt.md\n@@ -60,7 +60,7 @@ option... | [
{
"diff_hunk": "@@ -0,0 +1,43 @@\n+\"\"\"\n+MaxDrawDownHyperOptLoss\n+\n+This module defines the alternative HyperOptLoss class which can be used for\n+Hyperoptimization.\n+\"\"\"\n+from datetime import datetime\n+\n+from pandas import DataFrame\n+\n+from freqtrade.data.btanalysis import calculate_max_drawdown\... | 30bc96cf3f802a882e4e5e35e0c0df8db876acfc | diff --git a/docs/hyperopt.md b/docs/hyperopt.md
index 09d43939a87..45e0d444db4 100644
--- a/docs/hyperopt.md
+++ b/docs/hyperopt.md
@@ -60,7 +60,7 @@ optional arguments:
Specify what timerange of data to use.
--data-format-ohlcv {json,jsongz,hdf5}
Storage format for... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
freqtrade__freqtrade-5846@da4344d | freqtrade/freqtrade | Python | 5,846 | Add /weekly and /monthly to Telegram (#5527) | ## Summary
Add /weekly and /monthly commands to Telegram RPC
Closes #5527 show average profit in overwiew (more or less)
## Quick changelog
- /weekly <n> shows profit & loss the last n ISO weeks (starting from Monday)
- /monthly <n> shows profit & loss the last n months
## What's new?
```
/weekly
... | 2021-11-05T21:53:26Z | Show average profit in overview
<!--
Note: this section will not show up in the issue.
Have you search for this feature before requesting it? It's highly likely that a similar request was already filed.
-->
## Describe your environment
(if applicable)
* Operating system: ____
* Python Version: _____ (`p... | We do however have a `/daily` command - which can also be extended to work for multiple weeks (e.g. `/daily 30`).
Aggregations over longer timeperiods will probably raise more questions than it'll help (is it running current month? is it MTD, expected for the month if it continues as is? ...) - and in the end, you'll ... | [
{
"body": "<!-- \r\nNote: this section will not show up in the issue.\r\nHave you search for this feature before requesting it? It's highly likely that a similar request was already filed.\r\n-->\r\n\r\n## Describe your environment\r\n(if applicable)\r\n\r\n * Operating system: ____\r\n * Python Version: ____... | d99eaccb5a6d87a27aacc9107140db09e570e46d | {
"head_commit": "da4344d2166c7e802af44ccdea6ed15ed39b4455",
"head_commit_message": "Remove line breaks\n\nSigned-off-by: Antoine Merino <antoine.merino.dev@gmail.com>",
"patch_to_review": "diff --git a/docs/telegram-usage.md b/docs/telegram-usage.md\nindex 0c45fbbf163..0c1af9f4ddb 100644\n--- a/docs/telegram-usa... | [
{
"diff_hunk": "@@ -289,6 +290,91 @@ def _rpc_daily_profit(\n 'data': data\n }\n \n+ def _rpc_weekly_profit(\n+ self, timescale: int,\n+ stake_currency: str, fiat_display_currency: str) -> Dict[str, Any]:\n+ today = datetime.utcnow().date()",
"line": null,... | d0e192e20f54322c868c9ffaa4778286429d479b | diff --git a/docs/telegram-usage.md b/docs/telegram-usage.md
index 0c45fbbf163..0c1af9f4ddb 100644
--- a/docs/telegram-usage.md
+++ b/docs/telegram-usage.md
@@ -175,6 +175,8 @@ official commands. You can ask at any moment for help with `/help`.
| `/performance` | Show performance of each finished trade grouped by pair... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
home-assistant__core-85765@ae69af8 | home-assistant/core | Python | 85,765 | Remove sky connect config entry if USB stick is not plugged in | <!--
You are amazing! Thanks for contributing to our project!
Please, DO NOT DELETE ANY TEXT from this template! (unless instructed).
-->
## Proposed change
<!--
Describe the big picture of your changes here to communicate to the
maintainers why we should accept this pull request. If it fixes a bug
or... | 2023-01-12T18:27:47Z | When removing integration "Sky Connect USB" from Raspberry Pi it keeps trying to find it.
### The problem
Hi,
As the title suggest: I disabled the Home Assistant Sky Connect integration. Then removed the USB stick from the Pi. And then deleted the integration. Rebooted. But in the log this keeps popping up:
``... | Hey there @home-assistant/core, mind taking a look at this issue as it has been labeled with an integration (`homeassistant_sky_connect`) you are listed as a [code owner](https://github.com/home-assistant/core/blob/dev/CODEOWNERS#L488) for? Thanks!
<details>
<summary>Code owner commands</summary>
Code owners of `hom... | [
{
"body": "### The problem\r\n\r\nHi,\r\n\r\nAs the title suggest: I disabled the Home Assistant Sky Connect integration. Then removed the USB stick from the Pi. And then deleted the integration. Rebooted. But in the log this keeps popping up:\r\n\r\n```\r\nLogger: homeassistant.config_entries\r\nSource: config... | 596f779254403807fb575079edbd104abdef2c00 | {
"head_commit": "ae69af852f05c8ef2f8f4976e0d635fcffdf1668",
"head_commit_message": "Remove sky connect config entry if USB stick is not plugged in",
"patch_to_review": "diff --git a/homeassistant/components/homeassistant_sky_connect/__init__.py b/homeassistant/components/homeassistant_sky_connect/__init__.py\nin... | [
{
"diff_hunk": "@@ -101,6 +110,22 @@ async def async_setup_entry(hass: HomeAssistant, entry: ConfigEntry) -> bool:\n data=hw_discovery_data,\n )\n \n+\n+async def async_setup_entry(hass: HomeAssistant, entry: ConfigEntry) -> bool:\n+ \"\"\"Set up a Home Assistant Sky Connect config entry.\"\"\"\n... | 00df330c48ab51197f07a9a83d38f09f4423806c | diff --git a/homeassistant/components/homeassistant_sky_connect/__init__.py b/homeassistant/components/homeassistant_sky_connect/__init__.py
index 08d54bdef1283f..af6df6b519deba 100644
--- a/homeassistant/components/homeassistant_sky_connect/__init__.py
+++ b/homeassistant/components/homeassistant_sky_connect/__init__.... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
freqtrade__freqtrade-5582@54ef36a | freqtrade/freqtrade | Python | 5,582 | Added days parameter to PerformanceFilter | ## Summary
Sometimes I want to use PerformanceFilter only according to performance of last N days
## Quick changelog
- added 'minutes' param to PerformanceFilter config
- if minutes > 0 getting performance only of last N days
closes #5060. | 2021-09-16T12:08:40Z | PerformanceFilter - last x mins
Hi for the first time and thank you for this magnificent piece of software :)
I just discovered PerformanceFilter for the pairlists. I am excited about it and I would like to share some thoughts about possible improvements to this.
Idea is to give possibility of taking into acc... | i guess it could be added ...
You'll need to be careful with your scenario though - assuming from the 30 pairs, 11 or 12 are "mostly" winners - you'll exclude most of the latter pairs "in principle" - just because they never got a chance to prove themselfs - so using this sorting method to reduce the number of pair... | [
{
"body": "Hi for the first time and thank you for this magnificent piece of software :) \r\n\r\nI just discovered PerformanceFilter for the pairlists. I am excited about it and I would like to share some thoughts about possible improvements to this. \r\n\r\nIdea is to give possibility of taking into account pe... | 90ad1789323e2c3061110f34bd5d3c54d60b65d7 | {
"head_commit": "54ef36a4971d77467a10fa343857aec27a312e5a",
"head_commit_message": "Updates after review to PerformanceFilter days param",
"patch_to_review": "diff --git a/freqtrade/persistence/models.py b/freqtrade/persistence/models.py\nindex 8c8c1e0a905..222be716934 100644\n--- a/freqtrade/persistence/models.... | [
{
"diff_hunk": "@@ -832,17 +832,21 @@ def total_open_trades_stakes() -> float:\n return total_open_stake_amount or 0\n \n @staticmethod\n- def get_overall_performance() -> List[Dict[str, Any]]:\n+ def get_overall_performance(days=None) -> List[Dict[str, Any]]:\n \"\"\"\n Return... | 56fb25c5e521415c9880e47c4938bfe357550bec | diff --git a/docs/includes/pairlists.md b/docs/includes/pairlists.md
index 69e12d5dcfc..b612a4ddfa2 100644
--- a/docs/includes/pairlists.md
+++ b/docs/includes/pairlists.md
@@ -165,6 +165,7 @@ Example to remove the first 10 pairs from the pairlist:
```json
"pairlists": [
+ // ...
{
"method": "Offse... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
freqtrade__freqtrade-5189@0e4466c | freqtrade/freqtrade | Python | 5,189 | Implement strategy-controlled stake sizes | Submitting initial draft of strategy-controlled stake sizes so you can get the feel of it.
What should be max stake size? Should it be `stake_amount` specified in config or entire available balance? Both have their merits i would say.
Otherwise tests pass, but i totally did not test the code so treat it as a roug... | 2021-06-27T12:21:18Z | Implementing Dynamic stake amount that responds to market status(momentum, volatility, volume.. etc) supporting indicator with TA
I want to implement controlling bet ratio dynamically on market status (for example bet high[90%] on high trend, bet low on minus trend[10%], or use current market volatility for betting rat... | You may look at #3886 for a reference to this - which was an attempt to implement it.
I've now closed this as there was no progress - and too much has changed (so it would no longer apply, and would require almost everything to change) - however it might still serve as a sample ...
Based on your description - i fea... | [
{
"body": "I want to implement controlling bet ratio dynamically on market status (for example bet high[90%] on high trend, bet low on minus trend[10%], or use current market volatility for betting ratio) function for freqtrade. It's basically managing dynamic staking amount on market situations.\r\nAs you guys... | f658cfa3491a7050debd8f86898e3f751d92b46e | {
"head_commit": "0e4466ca1e46ebad19cc28a8ef9ac21123c48de4",
"head_commit_message": "Implement strategy-controlled stake sizes. Expose `self.wallet` to a strategy.",
"patch_to_review": "diff --git a/docs/strategy-advanced.md b/docs/strategy-advanced.md\nindex b06cf3ecb9e..e2fd30575b7 100644\n--- a/docs/strategy-a... | [
{
"diff_hunk": "@@ -312,7 +314,18 @@ def _enter_trade(self, pair: str, row: List) -> Optional[LocalTrade]:\n stake_amount = self.wallets.get_trade_stake_amount(pair, None)\n except DependencyException:\n return None\n- min_stake_amount = self.exchange.get_min_pair_stake_am... | 7ea0a74c532780a89b5fd885c804e437fe0291b9 | diff --git a/docs/strategy-advanced.md b/docs/strategy-advanced.md
index b06cf3ecb9e..4dba9ad4ac5 100644
--- a/docs/strategy-advanced.md
+++ b/docs/strategy-advanced.md
@@ -521,6 +521,39 @@ class AwesomeStrategy(IStrategy):
```
+### Stake size management
+
+It is possible to manage your risk by reducing or increas... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
ivy-llc__ivy-10429@3d75730 | ivy-llc/ivy | Python | 10,429 | change from is_native_array to is_ivy array in get_all_arrays_in_memory | This fixes #10428 | 2023-02-09T04:19:26Z | [Bug]: ivy.get_all_arrays_in_memory() produces errors
### Bug Explanation
when using get_all_arrays_in_memory function gives below error
numpy: is_native_array: maximum recursion depth exceeded in comparison
It should return ivy.Array but it returns garbage value
### Steps to Reproduce Bug
ex:- get_all_arrays_in_... | [
{
"body": "### Bug Explanation\n\nwhen using get_all_arrays_in_memory function gives below error\r\nnumpy: is_native_array: maximum recursion depth exceeded in comparison \r\nIt should return ivy.Array but it returns garbage value\n\n### Steps to Reproduce Bug\n\nex:- get_all_arrays_in_memory() in python consol... | 0630f1e9713d49e48c95078dcf70017ff0f70b8d | {
"head_commit": "3d757302352eb415b4eacd79b4455471dc5bc4ee",
"head_commit_message": "add ivy array instead of native array when current backend is default or numpy",
"patch_to_review": "diff --git a/ivy/functional/ivy/general.py b/ivy/functional/ivy/general.py\nindex afd19cc87d133..d2aeb68e1949a 100644\n--- a/ivy... | [
{
"diff_hunk": "@@ -2177,13 +2177,18 @@ def stable_pow(\n \n \n @handle_exceptions\n-def get_all_arrays_in_memory():\n+def get_all_arrays_in_memory() -> ivy.Array:",
"line": null,
"original_line": 2180,
"original_start_line": null,
"path": "ivy/functional/ivy/general.py",
"start_line": null,... | b7d72ba5ee74dbfac4494f344465562aef4d1b45 | diff --git a/ivy/functional/ivy/general.py b/ivy/functional/ivy/general.py
index afd19cc87d133..8eefebbdb39db 100644
--- a/ivy/functional/ivy/general.py
+++ b/ivy/functional/ivy/general.py
@@ -2177,13 +2177,18 @@ def stable_pow(
@handle_exceptions
-def get_all_arrays_in_memory():
+def get_all_arrays_in_memory() ->... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
huggingface__accelerate-343@3a7a3f1 | huggingface/accelerate | Python | 343 | Improve num_processes question in CLI | # Improve the phrasing of asking the number of processes to be used during training
## What does this add?
This slightly tweaks the question asking how many devices the user will be using when running `accelerate config`
## Who is it for?
Closes https://github.com/huggingface/accelerate/issues/338
## Why is it nee... | 2022-05-05T15:04:31Z | Confusing prompt on accelerator config
When setting up accelerator with deepspeed, the prompt of `how many processes will be used` is really confusing, especially when one only starts with accelerator.
```
In which compute environment are you running? ([0] This machine, [1] AWS (Amazon SageMaker)): 0
Which type of... | It could be TPUs, or even CPUs if you use distributing training in CPU, so we can't replace it with "How many GPUs". Maybe "devices" ?
Across how many devices should everything be distributed? | [
{
"body": "When setting up accelerator with deepspeed, the prompt of `how many processes will be used` is really confusing, especially when one only starts with accelerator.\r\n\r\n```\r\nIn which compute environment are you running? ([0] This machine, [1] AWS (Amazon SageMaker)): 0\r\nWhich type of machine are... | 02e2ed567be0e6d54b65884265a14873c3a30b2a | {
"head_commit": "3a7a3f1bc4352dfb554d8290d819cdceb74f81fb",
"head_commit_message": "Rephrase num_processes question",
"patch_to_review": "diff --git a/src/accelerate/commands/config/cluster.py b/src/accelerate/commands/config/cluster.py\nindex cfab0f7f869..e907effb970 100644\n--- a/src/accelerate/commands/config... | [
{
"diff_hunk": "@@ -133,7 +133,7 @@ def get_cluster_input():\n main_training_function = \"main\"\n \n num_processes = _ask_field(\n- \"How many processes in total will you use? [1]: \",\n+ \"How many devices should be used for (potentially) distributed training? [1:]\",",
"line": n... | b3a847edc638e5e004d97fe5225aba304d765c38 | diff --git a/src/accelerate/commands/config/cluster.py b/src/accelerate/commands/config/cluster.py
index cfab0f7f869..559fda41c72 100644
--- a/src/accelerate/commands/config/cluster.py
+++ b/src/accelerate/commands/config/cluster.py
@@ -133,7 +133,7 @@ def get_cluster_input():
main_training_function = "main"
... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "Bug Fixes"
} |
freqtrade__freqtrade-5299@7d04005 | freqtrade/freqtrade | Python | 5,299 | Add buy signal name | ## Summary
When use multiple buy signal, I (maybe we) need to know the buy signal that trigger a trade
Then on custom_sell, I able to use ```trade.buy_tag```
## What's new?
### Buy Tag on Strategy
Normal way to use populate_buy_trend
```
dataframe.loc[
(
(dataframe['rsi'] < 35) &
... | 2021-07-19T22:15:18Z | Tagging of buy & sell conditions
## New feature request
Ability to tag buy and sell strategies and print what triggered the buy and sell in telegram bit output.
## Example:
Having two dataframe.loc where we can tag a name to each.
Dataframe.loc[
(
(Condition)
), 'buytag'] = 'my tag1'
Dataframe.loc[
... | continuing the discussion started at Slack:
-- the idea itself is great. 👍
-- I would like to keep the float as the return value from populate_buy/sell_trend methods. In the future, this value can be treated as the position size (i.e., 0.5 returned would mean "open the position, but with 0.5 amount of "normal" posi... | [
{
"body": "## New feature request\r\n\r\nAbility to tag buy and sell strategies and print what triggered the buy and sell in telegram bit output. \r\n\r\n## Example:\r\nHaving two dataframe.loc where we can tag a name to each. \r\nDataframe.loc[\r\n(\r\n (Condition)\r\n), 'buytag'] = 'my tag1'\r\n\r\nDatafram... | f870c0099b0de72a18e6f396e63e8f0e8da735a6 | {
"head_commit": "7d040052189d94884609bd004796f53d81ecc437",
"head_commit_message": "add test and migration",
"patch_to_review": "diff --git a/freqtrade/enums/__init__.py b/freqtrade/enums/__init__.py\nindex 78163d86f1d..bcf68d62230 100644\n--- a/freqtrade/enums/__init__.py\n+++ b/freqtrade/enums/__init__.py\n@@ ... | [
{
"diff_hunk": "@@ -160,7 +161,7 @@ def check_migrate(engine, decl_base, previous_tables) -> None:\n table_back_name = get_backup_name(tabs, 'trades_bak')\n \n # Check for latest column\n- if not has_column(cols, 'open_trade_value'):\n+ if not has_column(cols, 'open_trade_value') or not has_column... | aa34889c047e13607a1b60ccca01cf63d6f57bab | diff --git a/docs/strategy-advanced.md b/docs/strategy-advanced.md
index 4dba9ad4ac5..fb78a8796ab 100644
--- a/docs/strategy-advanced.md
+++ b/docs/strategy-advanced.md
@@ -114,6 +114,36 @@ class AwesomeStrategy(IStrategy):
See [Dataframe access](#dataframe-access) for more information about dataframe use in strateg... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
getsentry__sentry-78934@3028422 | getsentry/sentry | Python | 78,934 | feat(flags): Add audit log flag filtering | Allows responses to be filtered by flag.
Closes: https://github.com/getsentry/sentry/issues/78933 | 2024-10-10T13:50:36Z | Add ability to filter by flag when querying the flag audit log
When showing the suspect feature flags table its important that the API response returned only shows flags which were captured by the error event. Extraneous events could force pagination and make showing the table prohibitively difficult. | [
{
"body": "When showing the suspect feature flags table its important that the API response returned only shows flags which were captured by the error event. Extraneous events could force pagination and make showing the table prohibitively difficult.",
"number": 78933,
"title": "Add ability to filter b... | faab8aad5927b5a257d80255533e644cd6303a61 | {
"head_commit": "302842247d877ad7336b2835ad79ed560abb65a1",
"head_commit_message": "Add flag filtering",
"patch_to_review": "diff --git a/src/sentry/flags/docs/api.md b/src/sentry/flags/docs/api.md\nindex 5667acfaf81aa7..13a227ba4861ec 100644\n--- a/src/sentry/flags/docs/api.md\n+++ b/src/sentry/flags/docs/api.m... | [
{
"diff_hunk": "@@ -13,6 +13,7 @@ This document is structured by resource with each resource having actions that c\n ## Flag Logs [/organizations/<organization_id_or_slug>/flags/logs/]\n \n - Parameters\n+ - flag (optional, string) - The flag to filter the result by. Can be specified multiple times.",
"lin... | 84ade5c77f4050278068481988f1fbc4e2b6db0f | diff --git a/src/sentry/flags/docs/api.md b/src/sentry/flags/docs/api.md
index 5667acfaf81aa7..6a42c59fe9ed9d 100644
--- a/src/sentry/flags/docs/api.md
+++ b/src/sentry/flags/docs/api.md
@@ -13,6 +13,7 @@ This document is structured by resource with each resource having actions that c
## Flag Logs [/organizations/<org... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
ivy-llc__ivy-10371@7cf36ea | ivy-llc/ivy | Python | 10,371 | Fixing the randint function when using the torch backend | Closes #10369 | 2023-02-07T15:52:35Z | [Bug]: ivy.randint with torch backend produces undesired values.
### Bug Explanation
When using ivy.randint with the torch backend, the values that are returned are wrong.
It should return a random uniform distribution between low and high, but it returns just the lower value.
### Steps to Reproduce Bug
E.g.: `... | #10371 should resolve the issue | [
{
"body": "### Bug Explanation\n\nWhen using ivy.randint with the torch backend, the values that are returned are wrong. \r\n\r\nIt should return a random uniform distribution between low and high, but it returns just the lower value. \n\n### Steps to Reproduce Bug\n\nE.g.: `ivy.randint(2, 10, shape=(10, 2))`\n... | 92c28d921582ea3f41a74b5a7420d8ebc056b260 | {
"head_commit": "7cf36ea6c2e039157320e0a53c5bb60b875f211f",
"head_commit_message": "when no shape is given the default is a scalar",
"patch_to_review": "diff --git a/ivy/functional/backends/torch/random.py b/ivy/functional/backends/torch/random.py\nindex bcfa4d05a6114..b157c177ce068 100644\n--- a/ivy/functional/... | [
{
"diff_hunk": "@@ -96,21 +96,18 @@ def randint(\n high: Union[int, torch.Tensor],\n /,\n *,\n- shape: Optional[Union[ivy.NativeShape, Sequence[int]]] = None,\n+ shape: Optional[Union[ivy.NativeShape, Sequence[int]]] = (1,),\n device: torch.device,\n- dtype: Optional[Union[torch.dtype, ... | 92ddbccad726b141329dfe1529bb15ccb5afc7ce | diff --git a/ivy/functional/backends/torch/random.py b/ivy/functional/backends/torch/random.py
index bcfa4d05a6114..e42fc5505b7fb 100644
--- a/ivy/functional/backends/torch/random.py
+++ b/ivy/functional/backends/torch/random.py
@@ -104,13 +104,14 @@ def randint(
) -> torch.Tensor:
if not dtype:
dtype = ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ivy-llc__ivy-10587@bacd76f | ivy-llc/ivy | Python | 10,587 | Reimplement ReLu6 in the backends and frontends | closes #10567 , #10584, and #10586
some code is the modified files was reformatted by mistake by black which is irrelevant to the PR | 2023-02-15T20:50:01Z | tensorflow.nn.relu6
[Bug]: torch frontend inconsistent gradient behaviour of torch.nn.relu6
### Bug Explanation
the implementation of torch.nn.relu6 in Pytorch Frontend uses `ivy.minimum` and `ivy.maximum`, this implementation is identical to `ivy.clip` which uses `torch.clamp` when using torch backend.
The pro... | [
{
"body": "",
"number": 10567,
"title": "tensorflow.nn.relu6"
},
{
"body": "### Bug Explanation\r\n\r\nthe implementation of torch.nn.relu6 in Pytorch Frontend uses `ivy.minimum` and `ivy.maximum`, this implementation is identical to `ivy.clip` which uses `torch.clamp` when using torch backend.\... | d080403a5bbb18c365fc8c73ce659244d887c016 | {
"head_commit": "bacd76fa6df8a770b40e76e0419f4a56b0d21d27",
"head_commit_message": "revert unrelated formatting changes",
"patch_to_review": "diff --git a/ivy/array/experimental/activations.py b/ivy/array/experimental/activations.py\nindex 527fb0af9a1ab..61d8882062515 100644\n--- a/ivy/array/experimental/activat... | [
{
"diff_hunk": "@@ -487,7 +487,7 @@ def Pow(*, x, y, name=\"Pow\"):\n \n @to_ivy_arrays_and_back\n def Relu6(features, name=\"Relu6\"):\n- return ivy.clip(features, 0, 6)\n+ return ivy.relu6(features)",
"line": null,
"original_line": 490,
"original_start_line": null,
"path": "ivy/functiona... | c1fbad2ef42843a2eaf6eb0bfef6e49dfac59587 | diff --git a/ivy/array/experimental/activations.py b/ivy/array/experimental/activations.py
index 527fb0af9a1ab..61d8882062515 100644
--- a/ivy/array/experimental/activations.py
+++ b/ivy/array/experimental/activations.py
@@ -109,3 +109,50 @@ def prelu(
-------
"""
return ivy.prelu(self._data,... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
freqtrade__freqtrade-4750@31a2285 | freqtrade/freqtrade | Python | 4,750 | Add IStrategy.custom_sell method which allows per-trade sell signal evaluation | Implementing `custom_sell()` in a strategy is conceptually equal to setting `sell` signal in dataframe.
closes #4276 | 2021-04-17T08:13:52Z | availability of trade profit while generating sell signals
Hi first. I am sorry for my english i know it's not good. I am 32 years old and my hobby is trading. Its a hobby because i won a lot more with my company on accountability.
For the last 2 years I was away from trading because I was studying an MBA. But now... | First of all, please pick a better title next time.
"freqtrade's worst problem" is not a valid title, and i'll simply close the next issue if you can't come up with something clearly identifying it's content.
it may be the worst problem for you, but it's really not a problem, but an enhancement request (and one we wi... | [
{
"body": "Hi first. I am sorry for my english i know it's not good. I am 32 years old and my hobby is trading. Its a hobby because i won a lot more with my company on accountability. \r\n\r\nFor the last 2 years I was away from trading because I was studying an MBA. But now i finished and for the last 3 moth ... | 7448a05f15db0b0ad5c4e023cbd2ea51d500f9ce | {
"head_commit": "31a2285eacaa7ce011a98548809fbe314f4f3c79",
"head_commit_message": "Fix mypy complaints.",
"patch_to_review": "diff --git a/docs/strategy-advanced.md b/docs/strategy-advanced.md\nindex 96c927965b0..f869a3c3a5b 100644\n--- a/docs/strategy-advanced.md\n+++ b/docs/strategy-advanced.md\n@@ -42,32 +42... | [
{
"diff_hunk": "@@ -42,32 +42,34 @@ class AwesomeStrategy(IStrategy):\n \n ***\n \n-### Storing custom information using DatetimeIndex from `dataframe`\n+## Custom sell signal\n \n-Imagine you need to store an indicator like `ATR` or `RSI` into `custom_info`. To use this in a meaningful way, you will not only n... | 3285f6caa35ef555f8956eecd3468eae04c2e9c5 | diff --git a/docs/strategy-advanced.md b/docs/strategy-advanced.md
index 96c927965b0..58e658509ef 100644
--- a/docs/strategy-advanced.md
+++ b/docs/strategy-advanced.md
@@ -42,32 +42,38 @@ class AwesomeStrategy(IStrategy):
***
-### Storing custom information using DatetimeIndex from `dataframe`
+## Custom sell sig... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
freqtrade__freqtrade-5150@85979c3 | freqtrade/freqtrade | Python | 5,150 | Adding command for Filtering and print trades | * Read latest Backtest file and print trades
I just want to know if it is going in the right direction.
## Summary
closes #5121
## Quick changelog
- Adding command for Filtering
- Print trade as text
| 2021-06-17T19:02:10Z | Backtesting: Filter for Pairs with TotalProfit/Win%
<!--
Note: this section will not show up in the issue.
Have you search for this feature before requesting it? It's highly likely that a similar request was already filed.
-->
## Describe your environment
(if applicable)
* Operating system: Ubuntu SMP
*... | To be honest, i don't think that'll gain you much (other than over-fitted strategies).
while pairlist selection IS important - throwing all pairs out that don't perform well usually means that your strategy doesn't generalize well, and looks too closely at how past movements played out - and will be thrown off quite... | [
{
"body": "<!-- \r\nNote: this section will not show up in the issue.\r\nHave you search for this feature before requesting it? It's highly likely that a similar request was already filed.\r\n-->\r\n\r\n## Describe your environment\r\n(if applicable)\r\n\r\n * Operating system: Ubuntu SMP\r\n * Python Version... | e8f85aed6b45c8af61474fceb7a9bfab956784dc | {
"head_commit": "85979c317679a58172fd15c2432d3c94cb1d9c4f",
"head_commit_message": "* Adding command for Filtering\n* Read latest Backtest file and print trades",
"patch_to_review": "diff --git a/freqtrade/commands/__init__.py b/freqtrade/commands/__init__.py\nindex 784b99bedb5..ecce709e5d2 100644\n--- a/freqtra... | [
{
"diff_hunk": "@@ -202,6 +202,11 @@ def __init__(self, *args, **kwargs):\n help='Specify additional lookup path for Hyperopt and Hyperopt Loss functions.',\n metavar='PATH',\n ),\n+ \"backtest_path\": Arg(",
"line": null,
"original_line": 205,
"original_start_line": null,
... | c15f73aa1f35aaea7db1d701ed6d745fd80ecbb6 | diff --git a/docs/utils.md b/docs/utils.md
index a65ba5db452..4a032db26ce 100644
--- a/docs/utils.md
+++ b/docs/utils.md
@@ -577,6 +577,46 @@ Common arguments:
```
+## Show previous Backtest results
+
+Allows you to show previous backtest results.
+Adding `--show-pair-list` outputs a sorted pair list you can easil... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
freqtrade__freqtrade-4302@5656969 | freqtrade/freqtrade | Python | 4,302 | #4289 printing json output | Adding --json flag to print json output
closes #4289 | 2021-02-02T20:41:02Z | Invalid JSON returned by rest_client.py
## Describe your environment
* Operating system: Linux (Docker)
* Python Version: 3.8.6
* CCXT version: 1.40.99
* Freqtrade Version: 2021.1
## Describe the problem:
The JSON output from `rest_client.py` is not a valid JSON.
The reason of the problem is th... | the rest-client is not intended to be used by scripts, and it relies on having basically no dependencies (other than requests) to print.
It uses the `print()` command on the response dictionaries to print, which uses single quotes, and i would not know how to change this behaviour of print.
``` python
print({"as... | [
{
"body": "## Describe your environment\r\n\r\n * Operating system: Linux (Docker)\r\n * Python Version: 3.8.6\r\n * CCXT version: 1.40.99\r\n * Freqtrade Version: 2021.1\r\n \r\n## Describe the problem:\r\n\r\nThe JSON output from `rest_client.py` is not a valid JSON.\r\n\r\nThe reason of the problem is t... | cd41d11b850251036e398faef19e8cdd7d572256 | {
"head_commit": "56569690d978b03ee23f3b7d24d9ceb04a8681fc",
"head_commit_message": "Update rest_client.py",
"patch_to_review": "diff --git a/scripts/rest_client.py b/scripts/rest_client.py\nindex 2232b842122..b214acda3f4 100755\n--- a/scripts/rest_client.py\n+++ b/scripts/rest_client.py\n@@ -331,6 +331,13 @@ def... | [
{
"diff_hunk": "@@ -379,7 +386,11 @@ def main(args):\n print_commands()\n return\n \n- print(getattr(client, command)(*args[\"command_arguments\"]))\n+ output = getattr(client, command)(*args[\"command_arguments\"])\n+ if args['json']:\n+ print(json.dumps(output))\n+ else:\n+ ... | 06b56544a8f51e4e87646acabe14ef166c0638b8 | diff --git a/scripts/rest_client.py b/scripts/rest_client.py
index 2232b842122..b6e66cfa4a2 100755
--- a/scripts/rest_client.py
+++ b/scripts/rest_client.py
@@ -379,7 +379,7 @@ def main(args):
print_commands()
return
- print(getattr(client, command)(*args["command_arguments"]))
+ print(json.du... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
freqtrade__freqtrade-4197@4d7ffa8 | freqtrade/freqtrade | Python | 4,197 | Added support for regex in whitelist | Introduce regex whitelist support
closes #4177 | 2021-01-12T00:37:36Z | UP/DOWN wildcards for whitelist
<!--
Note: this section will not show up in the issue.
Have you search for this feature before requesting it? It's highly likely that a similar request was already filed.
-->
## Describe your environment
(if applicable)
* Operating system: ____
* Python Version: _____ (`p... | I'm labling this as "good first issue" - which means i'll leave it open for an undefined period of time without working on it myself.
This can be a good issue for new contributors to freqtrade.
The logic for the pairs is available (used by blacklist) - and would simply need to be implemented to StaticPairlist - whi... | [
{
"body": "<!-- \r\nNote: this section will not show up in the issue.\r\nHave you search for this feature before requesting it? It's highly likely that a similar request was already filed.\r\n-->\r\n\r\n## Describe your environment\r\n(if applicable)\r\n\r\n * Operating system: ____\r\n * Python Version: ____... | f3de0dd3eb8d55ef085258073d6506bd887f8cc8 | {
"head_commit": "4d7ffa8c810e20b95ca746e61b5e7f2e964ac5ad",
"head_commit_message": "Added suppoort for regex in whitelist",
"patch_to_review": "diff --git a/freqtrade/commands/data_commands.py b/freqtrade/commands/data_commands.py\nindex 25c7d0436c8..1ce02eee500 100644\n--- a/freqtrade/commands/data_commands.py\... | [
{
"diff_hunk": "@@ -50,9 +50,10 @@ def gen_pairlist(self, cached_pairlist: List[str], tickers: Dict) -> List[str]:\n :return: List of pairs\n \"\"\"\n if self._allow_inactive:\n- return self._config['exchange']['pair_whitelist']\n+ return self.verify_whitelist(self.... | bf5868c96da6b0194c6bafa319f09bddef00d350 | diff --git a/docs/configuration.md b/docs/configuration.md
index 13c7eb47b8e..e655182b8ef 100644
--- a/docs/configuration.md
+++ b/docs/configuration.md
@@ -81,7 +81,7 @@ Mandatory parameters are marked as **Required**, which means that they are requi
| `exchange.key` | API key to use for the exchange. Only required w... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
huggingface__accelerate-293@ede8e28 | huggingface/accelerate | Python | 293 | Add logging capabilities | Start of an implementation for a convinence API when logging with Accelerate. I've opted to use abstract functions here in the base class so that if people wish to integrate with their own API's and have it be compatible, an error can be raised if they missed an implementation. Let me know what you think so far @sgugge... | 2022-03-24T19:02:43Z | Add logging capability
# Feature Request: Logging Capability
## Feature Summary
- Add a method called `Accelerator.log` that takes in dictionary-like values and saves to configured logger
- `Accelerator.__init__` should get a new param of `log_with` that takes a list of strings as potential options or `"all"`
- The de... | Is it possible to add support for custom loggers too? Like the open-source experiment tracker Aim (others above other than tboard are closed source): https://github.com/aimhubio/aim .
@ashutoshsaboo essentially this will just be a small convenience wrapper to a few back-ends. For any and all loggers you can simply hav... | [
{
"body": "# Feature Request: Logging Capability\n\n## Feature Summary\n- Add a method called `Accelerator.log` that takes in dictionary-like values and saves to configured logger\n- `Accelerator.__init__` should get a new param of `log_with` that takes a list of strings as potential options or `\"all\"`\n- The... | 5d83eed3d26aa2d7d0fa8a39bbd40cbf73b12e7a | {
"head_commit": "ede8e28dfb0c7a4ce407c6c8c2f2e93200cb01cf",
"head_commit_message": "Initial implementation for review",
"patch_to_review": "diff --git a/src/accelerate/accelerator.py b/src/accelerate/accelerator.py\nindex 2b623db340d..ac684620d71 100644\n--- a/src/accelerate/accelerator.py\n+++ b/src/accelerate/... | [
{
"diff_hunk": "@@ -0,0 +1,72 @@\n+# Copyright 2022 The HuggingFace Team. All rights reserved.\n+#\n+# Licensed under the Apache License, Version 2.0 (the \"License\");\n+# you may not use this file except in compliance with the License.\n+# You may obtain a copy of the License at\n+#\n+# http://www.apache.... | 845f2d0ca72a745987347cc29410787fbc2d212f | diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
index aa04063d8c5..c213a916762 100644
--- a/.github/workflows/test.yml
+++ b/.github/workflows/test.yml
@@ -12,6 +12,6 @@ jobs:
with:
python-version: 3.6
- name: Install Python dependencies
- run: pip install -e .[test]
+ ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
huggingface__accelerate-238@ad91c80 | huggingface/accelerate | Python | 238 | add support of gather_object | fixes #235 | 2022-01-26T08:31:53Z | stronger gather implement
`gather` is crucial in evaluating model. current implementation assumes each tensor across devices has same size, which is very unlikely to happen in the real case. calling `pad_across_processes` results to additional 0s in the output, leading to incorrect results.
```python
def _gpu_gath... | Hi there, thanks for the feedback! We'll look into adding support for `gather_object` as it's impossible to automatically return a tensor from tensors on different devices that are not of the same sizes.
But out of curiosity, in what type of problems do you have tensors of different sizes on different GPUs without h... | [
{
"body": "`gather` is crucial in evaluating model. current implementation assumes each tensor across devices has same size, which is very unlikely to happen in the real case. calling `pad_across_processes` results to additional 0s in the output, leading to incorrect results. \r\n\r\n```python\r\ndef _gpu_gathe... | 4fc586f5af650a5711dc907fb613367d2f009c9a | {
"head_commit": "ad91c807cc7c06c3abff0fa49fb859588cd98b46",
"head_commit_message": "add support of gather_object\n\nfixes #235",
"patch_to_review": "diff --git a/src/accelerate/utils.py b/src/accelerate/utils.py\nindex 99199728248..8a027312b2a 100644\n--- a/src/accelerate/utils.py\n+++ b/src/accelerate/utils.py\... | [
{
"diff_hunk": "@@ -345,6 +345,40 @@ def gather(tensor):\n return tensor\n \n \n+\n+def _gpu_gather_object(object: Any):\n+ def _gpu_gather_object_one(object: Any):\n+ output_objects = [None for _ in range(torch.distributed.get_world_size())]\n+ torch.distributed.all_gather_object(outpu... | dbe75540cd94038488b302aec2d7002ce59c5986 | diff --git a/src/accelerate/utils.py b/src/accelerate/utils.py
index 3af792f1f05..36eaea592be 100644
--- a/src/accelerate/utils.py
+++ b/src/accelerate/utils.py
@@ -18,7 +18,7 @@
from collections.abc import Mapping
from dataclasses import dataclass, field
from enum import Enum
-from typing import List, Optional, Uni... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
huggingface__accelerate-56@930e261 | huggingface/accelerate | Python | 56 | Support for multi-GPU in notebook_launcher | This PR adds support for multi-GPU training in the `notebook_launcher` and cleans a bit the API.
The same constraints as for TPU are applicable: no defining `accelerator` outside of the training function **and** CUDA has to be uninitiliazed until inside the trainnig function or the forking process is not happy.
F... | 2021-04-27T16:04:11Z | Multi GPU Training Not Working
While using Accelerate, it is only utilizing 1 out of the 2 GPUs present. I am training using the general instructions in the repository. The architecture is AutoEncoder.
```
dataloader = DataLoader(dataset, batch_size = 2048, shuffle=True, pin_memory=False, num_workers=20)
encoder ... | Did you set "num_processes" in your config to 2?
I noticed, that when this parameter is set to 1 only one gpu will be used.
My working configuration is this:
```
{
"distributed_type": "MULTI_GPU",
"fp16": true,
"machine_rank": 0,
"main_process_ip": null,
"main_process_port": null,
"main_trai... | [
{
"body": "While using Accelerate, it is only utilizing 1 out of the 2 GPUs present. I am training using the general instructions in the repository. The architecture is AutoEncoder. \r\n\r\n```\r\ndataloader = DataLoader(dataset, batch_size = 2048, shuffle=True, pin_memory=False, num_workers=20)\r\nencoder = En... | ae578b2c05f5440922ffd195ca9ebc4cbe0d92f9 | {
"head_commit": "930e2611da3d8a42789046ad5373d47c546c9510",
"head_commit_message": "Address review comment",
"patch_to_review": "diff --git a/README.md b/README.md\nindex 280473ee565..6e2211143f5 100644\n--- a/README.md\n+++ b/README.md\n@@ -163,8 +163,6 @@ notebook_launcher(training_function)\n \n An example ca... | [
{
"diff_hunk": "@@ -65,15 +63,60 @@ def notebook_launcher(function, args=(), num_processes=None, start_method=\"fork\"\n if num_processes is None:\n num_processes = 8\n \n+ launcher = PrepareForLaunch(function, distributed_type=\"TPU\")\n+ print(f\"Launching a t... | 9dd52e0172cdcec57a67789e8ef95e2327f05074 | diff --git a/README.md b/README.md
index 280473ee565..6e2211143f5 100644
--- a/README.md
+++ b/README.md
@@ -163,8 +163,6 @@ notebook_launcher(training_function)
An example can be found in [this notebook](https://github.com/huggingface/notebooks/blob/master/examples/accelerate/simple_nlp_example.ipynb). [ now, will review iOS+RN when new view renderer is default 🛑
Adds SR config snippets to onboarding feature snippets for iOS/RN as applicable (Flutter will follow in 1-2 months):
- ✅ iOS
- ✅ RN
Note: this PR also... | 2025-03-18T18:21:11Z | [New Org/Project Creation] Add Mobile Replay Instructions, Opt-in Only
## Add Mobile Replay Onboarding Instructions
- to the new org/project creation flow
- covers iOS, Android, and React Native (excl. Flutter until it's out of beta)
- default to replay being 'unchecked'/not enabled
- user analytics to track this funn... | Routing to @getsentry/product-owners-replays for [triage](https://develop.sentry.dev/processing-tickets/#3-triage) ⏲️ | [
{
"body": "## Add Mobile Replay Onboarding Instructions\n\n- to the new org/project creation flow\n- covers iOS, Android, and React Native (excl. Flutter until it's out of beta)\n- default to replay being 'unchecked'/not enabled\n- user analytics to track this funnel (1) users that land on the new org/project c... | ea8d9fa79df07be4576a4151c97ae05c32794904 | {
"head_commit": "7f85f579bf732f6c741f04d3a9fc5244fc34a08d",
"head_commit_message": "add SR feature to iOS onboarding",
"patch_to_review": "diff --git a/static/app/components/onboarding/productSelection.tsx b/static/app/components/onboarding/productSelection.tsx\nindex 225ffb22fe632f..07d9905b371d21 100644\n--- a... | [
{
"diff_hunk": "@@ -135,6 +145,16 @@ struct SwiftUIApp: App {\n // We recommend adjusting this value in production.\n options.profilesSampleRate = 1.0`\n : ''\n+ }${\n+ params.isReplaySelected\n+ ? `\n+\n+ // Record Sessio... | 4604f5731bba66b6e54dbf3e93660e7e73f7431c | diff --git a/static/app/components/onboarding/productSelection.tsx b/static/app/components/onboarding/productSelection.tsx
index db03c58628c829..9136a0ed3d3efc 100644
--- a/static/app/components/onboarding/productSelection.tsx
+++ b/static/app/components/onboarding/productSelection.tsx
@@ -80,7 +80,11 @@ export const p... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
getsentry__sentry-77675@4eb4631 | getsentry/sentry | Python | 77,675 | feat(toolbar): add project settings page w/allowed_origins form | Depends on https://github.com/getsentry/sentry/pull/77674, closes https://github.com/getsentry/sentry/issues/77213
Notice the route on top + in the sidebar. Users need to manually click "Save Changes", which is only enabled if there were changes since the last save.
 that are allowed to host the toolbar. For sentry itself I'd expect the list to be:
```
*.sent... | [
{
"body": "The page should be behind a feature flag!\n\nThe settings should be per-project.\n\nTo start we should let people have a text area to save a list of domains (new-line separated) that are allowed to host the toolbar. For sentry itself I'd expect the list to be: \n```\n*.sentry.io\ndev.getsentry.net:80... | 5d6def28bb6df799eb4d564b3fdd9d458b02a8a9 | {
"head_commit": "4eb463138b48450e61aba83053ba6fbc4d489234",
"head_commit_message": "feat(toolbar): add project settings page w/allowed_origins form",
"patch_to_review": "diff --git a/static/app/routes.tsx b/static/app/routes.tsx\nindex 992570b648c935..144e17d54e732a 100644\n--- a/static/app/routes.tsx\n+++ b/sta... | [
{
"diff_hunk": "@@ -64,6 +64,11 @@ export default function getConfiguration({\n title: t('User Feedback'),\n show: () => !isSelfHostedErrorsOnly,\n },\n+ {\n+ path: `${pathPrefix}/toolbar/`,\n+ title: t('Developer Toolbar'),\n+ show: () => true || !!... | 0a7e87a67d16ee766c8b1dd05a289c22e1156f87 | diff --git a/static/app/routes.tsx b/static/app/routes.tsx
index 992570b648c935..144e17d54e732a 100644
--- a/static/app/routes.tsx
+++ b/static/app/routes.tsx
@@ -557,6 +557,11 @@ function buildRoutes() {
name={t('Replays')}
component={make(() => import('sentry/views/settings/project/projectReplays'))... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
huggingface__accelerate-255@12e4b18 | huggingface/accelerate | Python | 255 | Add in checkpointing capability | Closes https://github.com/huggingface/accelerate/issues/171
This PR adds in two functions, `Accelerator.save_state` and `Accelerator.load_state`, which will go through and checkpoint the current state of everything accelerator touches.
I've included a testing script, but this needs to be properly turned into a te... | 2022-02-17T21:06:16Z | Add utility function to save/load all models/optimizers stored in an accelerator
Hi all,
I'm not from the nlp regime, but I love the concept of accelerate. However, I would like to propose some new features.
Since every accelerator.prepare call will essentially store a reference of the object in accelerator. It sho... | Yes, this is on the roadmap and should come in the next few weeks! It will save everything you said plus all the RNG states, so that one can resume training in the exact same conditions. It will also provide an easy way to upload said checkpoint to the Hub so that you can easily resume training on another machine.
I... | [
{
"body": "Hi all,\r\nI'm not from the nlp regime, but I love the concept of accelerate. However, I would like to propose some new features.\r\n\r\nSince every accelerator.prepare call will essentially store a reference of the object in accelerator. It should be easy to implement a save_all()/load_all() utility... | 4fc586f5af650a5711dc907fb613367d2f009c9a | {
"head_commit": "12e4b184a4b481fab1a0013095c9f70e1e6cf809",
"head_commit_message": "More unwrapping",
"patch_to_review": "diff --git a/src/accelerate/accelerator.py b/src/accelerate/accelerator.py\nindex b841bc809f9..e22a5cc8e65 100644\n--- a/src/accelerate/accelerator.py\n+++ b/src/accelerate/accelerator.py\n@@... | [
{
"diff_hunk": "@@ -560,6 +566,109 @@ def save(self, obj, f):\n \"\"\"\n save(obj, f)\n \n+ def save_state(self, output_dir: str):\n+ \"\"\"\n+ Saves the current states of the model, optimizer, scalar, and RNG generators to `folder_name`.\n+\n+ Args:\n+ output_... | f90b5779735fd0f4b112bf4895e7e632b487f757 | diff --git a/src/accelerate/accelerator.py b/src/accelerate/accelerator.py
index b841bc809f9..1254c19e9af 100644
--- a/src/accelerate/accelerator.py
+++ b/src/accelerate/accelerator.py
@@ -22,6 +22,7 @@
from packaging import version
+from .checkpointing import load_accelerator_state, save_accelerator_state
from .... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
home-assistant__core-84975@6a0322d | home-assistant/core | Python | 84,975 | Disable sky connect config entry if USB stick is not plugged in | <!--
You are amazing! Thanks for contributing to our project!
Please, DO NOT DELETE ANY TEXT from this template! (unless instructed).
-->
## Proposed change
<!--
Describe the big picture of your changes here to communicate to the
maintainers why we should accept this pull request. If it fixes a bug
or... | 2023-01-02T10:07:06Z | When removing integration "Sky Connect USB" from Raspberry Pi it keeps trying to find it.
### The problem
Hi,
As the title suggest: I disabled the Home Assistant Sky Connect integration. Then removed the USB stick from the Pi. And then deleted the integration. Rebooted. But in the log this keeps popping up:
``... | Hey there @home-assistant/core, mind taking a look at this issue as it has been labeled with an integration (`homeassistant_sky_connect`) you are listed as a [code owner](https://github.com/home-assistant/core/blob/dev/CODEOWNERS#L488) for? Thanks!
<details>
<summary>Code owner commands</summary>
Code owners of `hom... | [
{
"body": "### The problem\r\n\r\nHi,\r\n\r\nAs the title suggest: I disabled the Home Assistant Sky Connect integration. Then removed the USB stick from the Pi. And then deleted the integration. Rebooted. But in the log this keeps popping up:\r\n\r\n```\r\nLogger: homeassistant.config_entries\r\nSource: config... | bcbae1388df4a3bd7a87f3882212c7db85e04290 | {
"head_commit": "6a0322d1acebb2fd85b478ab41b62398465d3fef",
"head_commit_message": "Disable sky connect config entry if USB stick is not plugged in",
"patch_to_review": "diff --git a/homeassistant/components/homeassistant_sky_connect/__init__.py b/homeassistant/components/homeassistant_sky_connect/__init__.py\ni... | [
{
"diff_hunk": "@@ -261,7 +270,33 @@ async def test_setup_entry_wait_usb(hass: HomeAssistant) -> None:\n assert not await hass.config_entries.async_setup(config_entry.entry_id)\n await hass.async_block_till_done()\n assert len(mock_is_plugged_in.mock_calls) == 1\n- assert config_e... | 745fa42b6f9c16dbe4b8e6df6ff0db06895cee08 | diff --git a/homeassistant/components/homeassistant_sky_connect/__init__.py b/homeassistant/components/homeassistant_sky_connect/__init__.py
index 08d54bdef1283f..4315862e523b77 100644
--- a/homeassistant/components/homeassistant_sky_connect/__init__.py
+++ b/homeassistant/components/homeassistant_sky_connect/__init__.... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
freqtrade__freqtrade-4147@c9ed213 | freqtrade/freqtrade | Python | 4,147 | Ignoring candles that have expired within timeframe | Signed-off-by: hoeckxer <hawkeyenl@yahoo.com>
Thank you for sending your pull request. But first, have you included
unit tests, and is your code PEP8 conformant? [More details](https://github.com/freqtrade/freqtrade/blob/develop/CONTRIBUTING.md)
## Summary
With this implementation, functionality is added to ign... | 2021-01-04T19:52:59Z | specifying buy signals timeouts during live
An option for configuring signals timeouts is useful for longer timeframes.
1. You have open orders
2. a sell is triggered at 3/4 of the timespan of timeframe
3. the bot processed a buy signals, and after the sell executed a new buy order, but that signal might be old alre... | There's 2 parts to this, both together should suffice your points:
* After a sell, that pair is locked for this candle - so the same pair will not be bought within this candle (it could be bought at the next candle though).
* You can have the bot analyze buy / sell signals only once new candles arrive with
`proc... | [
{
"body": "An option for configuring signals timeouts is useful for longer timeframes.\r\n1. You have open orders\r\n2. a sell is triggered at 3/4 of the timespan of timeframe\r\n3. the bot processed a buy signals, and after the sell executed a new buy order, but that signal might be old already and not worth b... | c010cdf894f97e03e0ce4d5a7d00f2be15d4f9e0 | {
"head_commit": "c9ed2137bb3b324a40d70110e0d5b959744fac10",
"head_commit_message": "Simplified return statements\n\nSigned-off-by: hoeckxer <hawkeyenl@yahoo.com>",
"patch_to_review": "diff --git a/docs/configuration.md b/docs/configuration.md\nindex b70a85c0496..db078cba878 100644\n--- a/docs/configuration.md\n+... | [
{
"diff_hunk": "@@ -144,6 +146,8 @@ Values set in the configuration file always overwrite values set in the strategy\n * `use_sell_signal` (ask_strategy)\n * `sell_profit_only` (ask_strategy)\n * `ignore_roi_if_buy_signal` (ask_strategy)\n+* `ignore_buying_expired_candle`\n+* `ignore_buying_expired_candle_after... | 1f6a71fdd96609a78ee9e75e232581e1d85f3776 | diff --git a/docs/configuration.md b/docs/configuration.md
index b70a85c0496..93693c919e3 100644
--- a/docs/configuration.md
+++ b/docs/configuration.md
@@ -74,6 +74,7 @@ Mandatory parameters are marked as **Required**, which means that they are requi
| `ask_strategy.use_sell_signal` | Use sell signals produced by the... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
freqtrade__freqtrade-3799@44ad0f6 | freqtrade/freqtrade | Python | 3,799 | Introduce Telegram /stats endpoint | ## Summary
Add `/stats` command in Telegram
closes #3783
## Quick changelog
WIP
| 2020-09-22T21:36:41Z | Telegram Recommendations
<!--
Note: this section will not show up in the issue.
Have you search for this feature before requesting it? It's highly likely that a similar request was already filed.
-->
## Describe your environment
(if applicable)
Operating system: UBUNTU 18.04
Python Version: 3.6.9 (python -... | well ideally, you should know this out of backtesting.
I can understand why it might seem tempting to have this - but you'll be mostly interrested in this during the first few hours / days / trades of a new strategy - when this information is not available / not yet reliable.
After running the strategy for a few ... | [
{
"body": "<!-- \r\nNote: this section will not show up in the issue.\r\nHave you search for this feature before requesting it? It's highly likely that a similar request was already filed.\r\n-->\r\n\r\n## Describe your environment\r\n(if applicable)\r\n\r\nOperating system: UBUNTU 18.04\r\nPython Version: 3.6.... | 058d40a72c389ab90c643fe1cede812c4c5038b2 | {
"head_commit": "44ad0f631c00ed00063fa61ebe3aefd6b5f736a1",
"head_commit_message": "Summarize trade reason for telegram command /stats.",
"patch_to_review": "diff --git a/freqtrade/rpc/telegram.py b/freqtrade/rpc/telegram.py\nindex a01efaed6a7..47e9d67dc18 100644\n--- a/freqtrade/rpc/telegram.py\n+++ b/freqtrade... | [
{
"diff_hunk": "@@ -738,6 +739,50 @@ def _version(self, update: Update, context: CallbackContext) -> None:\n \"\"\"\n self._send_msg('*Version:* `{}`'.format(__version__))\n \n+ @authorized_only\n+ def _stats(self, update: Update, context: CallbackContext) -> None:\n+ \"\"\"\n+ ... | ca99d484fcd852561f8acbb3bd9cbb879ddc724d | diff --git a/docs/rest-api.md b/docs/rest-api.md
index 7726ab875aa..9bb35ce91a2 100644
--- a/docs/rest-api.md
+++ b/docs/rest-api.md
@@ -127,6 +127,7 @@ python3 scripts/rest_client.py --config rest_config.json <command> [optional par
| `performance` | Show performance of each finished trade grouped by pair.
| `balanc... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
freqtrade__freqtrade-3438@2f07d21 | freqtrade/freqtrade | Python | 3,438 | Ftx stoploss | ## Summary
Introduce stoploss on exchange for FTX.
closes #3103 (only stoploss is remaining).
## Quick changelog
- Add methods to support stoploss on exchange
- FTX supports both stoploss-limit and stoploss-market (controlled via `order_types.stoploss` key).
- use `cancel_stoploss_order` and `get_stoploss... | 2020-06-03T18:21:57Z | Fee calculation + stoploss support + trade amounts on FTX
So, while testing live trading on FTX using freqtrade. I've spotted a few FTX inconsistencies that I'll be logging here, so that we can start working on them in the future:
1. Fee calculation seems to fail all the time with this error (Leveraged tokens, haven... | First of all - please use one issue per discovered problem. Otherwise discussions get confusing and we're stuck with issues we cannot ever close because one minor thing was never done, but the issue would be 90% done - but noone will be able to figure out which part is still missing.
1) that's not relevant for FTX i... | [
{
"body": "So, while testing live trading on FTX using freqtrade. I've spotted a few FTX inconsistencies that I'll be logging here, so that we can start working on them in the future:\r\n\r\n1. Fee calculation seems to fail all the time with this error (Leveraged tokens, haven't tried perps or options trading y... | 04a2fb16aaf35b65ba3cefb0dcc3685537e5e283 | {
"head_commit": "2f07d21629b8aade68a5916303652133bf57d3cd",
"head_commit_message": "Update documentation with FTX Stoploss on exchange",
"patch_to_review": "diff --git a/docs/configuration.md b/docs/configuration.md\nindex da0f015e8b8..46719046372 100644\n--- a/docs/configuration.md\n+++ b/docs/configuration.md\... | [
{
"diff_hunk": "@@ -2,13 +2,117 @@\n import logging\n from typing import Dict\n \n+import ccxt\n+\n+from freqtrade.exceptions import (DependencyException, InvalidOrderException,\n+ OperationalException, TemporaryError)\n from freqtrade.exchange import Exchange\n+from freqtrade.e... | 534c242d1b44f0cda20202da85632936fc1e6ab3 | diff --git a/docs/configuration.md b/docs/configuration.md
index da0f015e8b8..46719046372 100644
--- a/docs/configuration.md
+++ b/docs/configuration.md
@@ -272,7 +272,7 @@ the static list of pairs) if we should buy.
### Understand order_types
-The `order_types` configuration parameter maps actions (`buy`, `sell`,... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
freqtrade__freqtrade-3369@18d2587 | freqtrade/freqtrade | Python | 3,369 | Improve some api results | ## Summary
API should return timestamps for dates so an application can decide on formatting itself.
## Quick changelog
- Fix inconsistency between /status and /trades (percent vs. ratio)
- add *timestamp key to trade output
- Return *timestamp values for /profit (closes #3364)
| 2020-05-24T07:00:34Z | REST RPC Formatting
{"version":"develop-d31a091d"}
### Observed Results:
* What happened?
JSON-RPC command 'profit'
`"first_trade_date":"5 days ago","latest_trade_date":"a day ago"`
Difficult to parse for any real client (not telegram) in any programming langage and not precise.
* What did you expec... | When you say "RPC" command - which RPC method are we talking about?
telegram? rest? webhooks?
Also - please fill out the issue template containing which version you're using.
Now it makes more sense. #3369 should address this.
If i may ask - what are you building with it?
We're working on a WebUI as well - if... | [
{
"body": "{\"version\":\"develop-d31a091d\"}\r\n\r\n### Observed Results: \r\n\r\n * What happened?\r\nJSON-RPC command 'profit' \r\n`\"first_trade_date\":\"5 days ago\",\"latest_trade_date\":\"a day ago\"`\r\n\r\nDifficult to parse for any real client (not telegram) in any programming langage and not precise... | b50d072d824339110e1957c804d3f47766ac9a2a | {
"head_commit": "18d258780079336b30311c2eb063faace711e43a",
"head_commit_message": "Address feedback",
"patch_to_review": "diff --git a/freqtrade/persistence.py b/freqtrade/persistence.py\nindex 3f7f4e0e9ee..da7137cba1e 100644\n--- a/freqtrade/persistence.py\n+++ b/freqtrade/persistence.py\n@@ -257,10 +257,12 @@... | [
{
"diff_hunk": "@@ -135,9 +135,11 @@ def _rpc_trade_status(self) -> List[Dict[str, Any]]:\n trade_dict = trade.to_json()\n trade_dict.update(dict(\n base_currency=self._freqtrade.config['stake_currency'],\n- close_profit=fmt_close_profit,\n+... | b2125bd6ee5502a5eb132e63c0e3fdb3187f1867 | diff --git a/freqtrade/persistence.py b/freqtrade/persistence.py
index 3f7f4e0e9ee..da7137cba1e 100644
--- a/freqtrade/persistence.py
+++ b/freqtrade/persistence.py
@@ -257,10 +257,12 @@ def to_json(self) -> Dict[str, Any]:
'fee_close_currency': self.fee_close_currency,
'open_date_hum': arrow.... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
freqtrade__freqtrade-3216@a3a045d | freqtrade/freqtrade | Python | 3,216 | Hyperopt should mention that a strategy is mandatory. |
## Summary
Add small section noting that a strategy file is always necessary for hyperopt
closes #3047
| 2020-04-25T13:55:28Z | Docker-Compose: Hyperopt won't start without --strategy
## Step 1: Have you searched for this issue before posting it?
Yes, I did.
## Step 2: Describe your environment
* Operating system: Linux
* Python Version: 3.8.2 (conda-env)
* CCXT version: 1.23.69
* Branch: Master
## Step 3: Describe the... | > So if the are defined, there shouldn't be the need to specify a strategy at all.
No, the strategy is not only the methods, but also attributes, that can significantly change the results of backtesting. Hyperopt class does not support currently all those attributes of the strategy. For simplicity (that was a ration... | [
{
"body": "## Step 1: Have you searched for this issue before posting it?\r\n\r\nYes, I did. \r\n\r\n## Step 2: Describe your environment\r\n\r\n * Operating system: Linux\r\n * Python Version: 3.8.2 (conda-env)\r\n * CCXT version: 1.23.69\r\n * Branch: Master\r\n \r\n## Step 3: Describe the problem:\r\n\r... | 1761f5af1a11a124cc3491d18482ad4b0685d4dd | {
"head_commit": "a3a045dbd4a650b35d1430ab4609bd1947354a01",
"head_commit_message": "Add small section noting that a strategy file is always necessary\n\nfix #3047",
"patch_to_review": "diff --git a/docs/hyperopt.md b/docs/hyperopt.md\nindex 30a22a9697c..55d2d984c9f 100644\n--- a/docs/hyperopt.md\n+++ b/docs/hype... | [
{
"diff_hunk": "@@ -63,6 +63,9 @@ Optional - can also be loaded from a strategy:\n !!! Note\n Assuming the optional methods are not in your hyperopt file, please use `--strategy AweSomeStrategy` which contains these methods so hyperopt can use these methods instead.\n \n+!!! Note\n+ You will always have ... | e928c5fdaf3c46588ecb427427ff2c848104d16b | diff --git a/docs/hyperopt.md b/docs/hyperopt.md
index 30a22a9697c..11161e58bd6 100644
--- a/docs/hyperopt.md
+++ b/docs/hyperopt.md
@@ -63,6 +63,9 @@ Optional - can also be loaded from a strategy:
!!! Note
Assuming the optional methods are not in your hyperopt file, please use `--strategy AweSomeStrategy` which ... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "Bug Fixes"
} |
home-assistant__core-83755@52ec5cf | home-assistant/core | Python | 83,755 | Mark repo as safe directory to git config | <!--
You are amazing! Thanks for contributing to our project!
Please, DO NOT DELETE ANY TEXT from this template! (unless instructed).
-->
## Proposed change
<!--
Describe the big picture of your changes here to communicate to the
maintainers why we should accept this pull request. If it fixes a bug
... | 2022-12-11T11:28:57Z | Devcontainer postCreateCommand fails
### The problem
When starting up a clean environment for HA core development using VSCode DevContainers, I get the following error during the postCreate phase:
```
An error has occurred: FatalError: git failed. Is it installed, and are you in a
Git repository directory?
Chec... | [
{
"body": "### The problem\n\nWhen starting up a clean environment for HA core development using VSCode DevContainers, I get the following error during the postCreate phase:\r\n\r\n```\r\nAn error has occurred: FatalError: git failed. Is it installed, and are you in a\r\n Git repository directory?\r\nCheck the ... | 0aa4d0fb7bbcabe1194f39417f0a413902744e39 | {
"head_commit": "52ec5cf6bce1f5031da58ea5b465861987284c20",
"head_commit_message": "Add Home-Assistant core repo path as safe directory to git config to circumvent devcontainer startup error.",
"patch_to_review": "diff --git a/script/setup b/script/setup\nindex 210779eec4580a..ef5e62b0cf4d89 100755\n--- a/script... | [
{
"diff_hunk": "@@ -23,6 +23,9 @@ fi\n \n script/bootstrap\n \n+# Avoid unsafe git error\n+git config --global --add safe.directory \"$PWD\"",
"line": null,
"original_line": 27,
"original_start_line": null,
"path": "script/setup",
"start_line": null,
"text": "@user1:\nIf this is ran outs... | b9dc4930fe4ec06690cc58b6b623a6fc611ee3d0 | diff --git a/script/setup b/script/setup
index 210779eec4580a..5a5bc84bb279ae 100755
--- a/script/setup
+++ b/script/setup
@@ -23,6 +23,11 @@ fi
script/bootstrap
+# Avoid unsafe git error when running inside devcontainer
+if [ -n "$DEVCONTAINER" ];then
+ git config --global --add safe.directory "$PWD"
+fi
+
pre-... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} | |
freqtrade__freqtrade-2974@cfc2257 | freqtrade/freqtrade | Python | 2,974 | Add timeframe_to_minutes to ROI documentation | ## Summary
sometimes using ROI based on candle can be useful (especially during strategy development when experimenting with different timeframes).
While easily possible, it's so far only been documented in a issue, but not in the documentation.
Closes #2463
## Quick changelog
- add sample for candle based... | 2020-02-25T15:55:06Z | Idea : be able to use candle duration instead of minutes in minimal roi
As a trader
I want to easily test strategies on multi time frames without make any changes in the minimal roi duration and if i test on higher time frames and don't need to do something like `60*24*6` (sixth day after buy on 1 day timeframe)
So t... | we've discussed this before ...
the problem with using candle duration is that it limits you on longer timeframes / makes calculation difficult and odd - assuming you use 1h timeframes.
Maybe you want to sell after 2 hours and 30 minutes. - 2.5 is still okish - but what about after 2 hours 45 minutes? it's not 2.... | [
{
"body": "As a trader\r\nI want to easily test strategies on multi time frames without make any changes in the minimal roi duration and if i test on higher time frames and don't need to do something like `60*24*6` (sixth day after buy on 1 day timeframe)\r\nSo that i can focus on a one fits all easily and have... | 6c8b5ea38c508cd09e92e7622d08621cfa38024f | {
"head_commit": "cfc22577bed042947d40cfa15676c1456aa6f7d4",
"head_commit_message": "Add timeframe_to_minutes to ROI documentation",
"patch_to_review": "diff --git a/docs/strategy-customization.md b/docs/strategy-customization.md\nindex 07833da34cc..0dfeb3978bd 100644\n--- a/docs/strategy-customization.md\n+++ b/... | [
{
"diff_hunk": "@@ -249,6 +249,22 @@ minimal_roi = {\n \n While technically not completely disabled, this would sell once the trade reaches 10000% Profit.\n \n+To use times based on candles, the following snippet can be handy.\n+This will allow you to change the ticket_interval, and ROI will be set as candles (... | e5a9c81412b4a6846872fde59489203184244288 | diff --git a/docs/strategy-customization.md b/docs/strategy-customization.md
index 07833da34cc..4aacd3af6d4 100644
--- a/docs/strategy-customization.md
+++ b/docs/strategy-customization.md
@@ -249,6 +249,23 @@ minimal_roi = {
While technically not completely disabled, this would sell once the trade reaches 10000% Pr... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "New Feature Additions"
} |
freqtrade__freqtrade-2973@31ac459 | freqtrade/freqtrade | Python | 2,973 | Support non pairs | ## Summary
Certain markets are not in the format of quote/base.
This PR allows to extract either side from the markets dict for each pair.
Closes #268
Closes #1107 (the bot should now support inversed pairs too)
most likely will close #2969 (still needs validation / confirmation)
## Quick changelog
-... | 2020-02-25T06:20:07Z | Refactoring pair name handling
Code is crippled with` pair.replace('_', '-'),` what about adding a method in the exchange class that defines the delimiter and remove `pair.replace` in all the code ?
FT hard links wallet and base pair
In any margin or futures exchange balance will more than likely be in the pair not ... | Sounds good to me
after much thinking, I think the name of the pair should be automatically created by the bot. We define the **stake_currency** as for example BTC, and the list of pairs needs to be only something like **[ "XVG" , "XRP" ]**. The bot can then form the correct pair
Thats a good idea, it also gives more ... | [
{
"body": "Code is crippled with` pair.replace('_', '-'),` what about adding a method in the exchange class that defines the delimiter and remove `pair.replace` in all the code ? ",
"number": 268,
"title": "Refactoring pair name handling"
},
{
"body": "In any margin or futures exchange balance w... | 6c8b5ea38c508cd09e92e7622d08621cfa38024f | {
"head_commit": "31ac4598ba966b60be897ef22884442fa63eeb6f",
"head_commit_message": "Fix last occurances of pair splitting",
"patch_to_review": "diff --git a/freqtrade/configuration/config_validation.py b/freqtrade/configuration/config_validation.py\nindex 5183ad0b4ef..5ba7ff2947f 100644\n--- a/freqtrade/configur... | [
{
"diff_hunk": "@@ -322,6 +334,12 @@ def validate_pairs(self, pairs: List[str]) -> None:\n logger.warning(f\"Pair {pair} is restricted for some users on this exchange.\"\n f\"Please check if you are impacted by this restriction \"\n f... | f38accb77b05accfbf328e62c5b417ed7613d527 | diff --git a/freqtrade/configuration/config_validation.py b/freqtrade/configuration/config_validation.py
index 5183ad0b4ef..5ba7ff2947f 100644
--- a/freqtrade/configuration/config_validation.py
+++ b/freqtrade/configuration/config_validation.py
@@ -150,15 +150,3 @@ def _validate_whitelist(conf: Dict[str, Any]) -> None:... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
freqtrade__freqtrade-3210@2307495 | freqtrade/freqtrade | Python | 3,210 | Cancel open orders during shutdown | ✅ Tests passing
✅ PEP8 conformant
✅ Mypy passing
## Summary
closes #907
When stopping the bot (via ctrl+c, `/stop`) open orders are cancelled.
## Quick changelog
- Add `process_stopped` method to `freqtradebot`
- Call `freqtrade.process_stopped` from `Worker`
- Generalize code to cancel open orders
... | 2020-04-24T22:38:56Z | shutdown should cancel open orders
## Proposal
When stopping the bot (via ctrl+c, `/stop`) open orders are kept open and will be filled by the exchange "whenever" the market is ready to.
This can be dangerous should the bot be stopped due to a sudden market crash
A proper shutdown should allow the following (con... | I recommend this to be added to the config file as an option that can be toggle on or off according to what people need.
Just opened this - https://github.com/freqtrade/freqtrade/pull/3210
I did not add a config option yet - that should be very straightforward to work in though!
@xmatthias what is the difference... | [
{
"body": "## Proposal\r\n\r\nWhen stopping the bot (via ctrl+c, `/stop`) open orders are kept open and will be filled by the exchange \"whenever\" the market is ready to.\r\nThis can be dangerous should the bot be stopped due to a sudden market crash\r\n\r\nA proper shutdown should allow the following (configu... | 9d6a41aa7a4094a7d7685b6eb5b5fb08a9344bb6 | {
"head_commit": "2307495f2837971f6325efa97afea7d874ae8c1d",
"head_commit_message": "Update docs/configuration.md\n\nCo-authored-by: Matthias <xmatthias@outlook.com>",
"patch_to_review": "diff --git a/config.json.example b/config.json.example\nindex 8ebb092e1f2..d37a6b33603 100644\n--- a/config.json.example\n+++ ... | [
{
"diff_hunk": "@@ -318,3 +319,10 @@\n 'dataformat_ohlcv',\n 'dataformat_trades',\n ]\n+\n+CANCEL_REASON = {\n+ \"TIMEOUT\": \"cancelled due to timeout\",\n+ \"PARTIALLY_FILLED\": \"partially filled - keeping order open\",\n+ \"ALL_CANCELLED\": \"cancelled (all unfilled orders cancelled)\",",
... | baf5f4f29cd0caa5d0c76471e989a193daec0bcd | diff --git a/config.json.example b/config.json.example
index 8ebb092e1f2..d37a6b33603 100644
--- a/config.json.example
+++ b/config.json.example
@@ -6,6 +6,7 @@
"fiat_display_currency": "USD",
"ticker_interval": "5m",
"dry_run": false,
+ "cancel_open_orders_on_exit": false,
"trailing_stop": false... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
freqtrade__freqtrade-2872@431b244 | freqtrade/freqtrade | Python | 2,872 | Buy order timeout callback | ## Summary
Inspired by the discussions in #2857 - this is a first (very rough) draft of how a strategy interface to customize buy_timeouts could look like.
It's intentionally very simple - it returns False by default (so no impact to users not interrested in this) - however when a strategy implements this (override... | 2020-02-06T19:38:45Z | Unable to analyze ticker for pair WRX/BTC: negative dimensions are not allowed
I shut down the boot and restarted it. I encountered this error message
```
2020-02-05 11:39:13,738 - VolumePairList - INFO - Searching 20 pairs: ['XRP/BTC', 'ICX/BTC', 'ETH/BTC', 'MATIC/BTC', 'ENJ/BTC', 'WRX/BTC', 'EOS/BTC', 'AION/BTC',... | It's basically #1067 - and i think the same solution will apply here, too.
WRX/BTC is a new pair - new pairs usually have a spike in volume the first day - so they're picked up by VolumePairlist.
The error you're receiving is because this pair does not have the full history (it only started trading yesterday) - a... | [
{
"body": "I shut down the boot and restarted it. I encountered this error message\r\n\r\n```\r\n2020-02-05 11:39:13,738 - VolumePairList - INFO - Searching 20 pairs: ['XRP/BTC', 'ICX/BTC', 'ETH/BTC', 'MATIC/BTC', 'ENJ/BTC', 'WRX/BTC', 'EOS/BTC', 'AION/BTC', 'TRX/BTC', 'LTC/BTC', 'ETC/BTC', 'ADA/BTC', 'XTZ/BTC'... | 4bbade245c79e7c76d90fe870a06818a4051bcf0 | {
"head_commit": "431b244f4342e140726aa006884a8036afb4b90b",
"head_commit_message": "Merge branch 'develop' into interface_ordertimeoutcallback",
"patch_to_review": "diff --git a/docs/strategy-advanced.md b/docs/strategy-advanced.md\nnew file mode 100644\nindex 00000000000..dcb8018f98f\n--- /dev/null\n+++ b/docs/... | [
{
"diff_hunk": "@@ -0,0 +1,92 @@\n+# Advanced Strategies\n+\n+This page explains some advanced concepts available for strategies.\n+If you're just getting started, please be familiar with the methods described in the [Strategy Customization](strategy-customization.md) documentation first.\n+\n+## Custom order t... | 255a43c98e75d18fe0a6bc04c513467c7ce85ffe | diff --git a/docs/strategy-advanced.md b/docs/strategy-advanced.md
new file mode 100644
index 00000000000..39e92d651b8
--- /dev/null
+++ b/docs/strategy-advanced.md
@@ -0,0 +1,91 @@
+# Advanced Strategies
+
+This page explains some advanced concepts available for strategies.
+If you're just getting started, please be f... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
freqtrade__freqtrade-2887@d69ddd2 | freqtrade/freqtrade | Python | 2,887 | Wide RPC notifications fixes | This PR addresses issues mentions in #2874 and goes a bit beyond to bring consistency into RPC, Webhook and Telegram messages being sent, also brings two distinct types of messages for Buy and Sell order cancels instead of sending them as generic status messages.
With this, notifications are now being sent for both ... | 2020-02-08T20:04:57Z | /status table not showing complete information
When using /status table with the RPC telegram bot, it returns existing trades (bought pairs) mixed with open buy orders (pending orders) without any way to differentiate between them.
This is not truthful to the purpose of the function, in the sense that it should conv... | Well yeah - but there's another part to this too ...
while `/status` shows you this trade while the order is still open - the notifications in case of a cancel are not consistent.
* A notification is sent on buy
* a notification is sent on sell
* **NO** notification is sent on buy cancel
So if you rely on thes... | [
{
"body": "When using /status table with the RPC telegram bot, it returns existing trades (bought pairs) mixed with open buy orders (pending orders) without any way to differentiate between them.\r\n\r\nThis is not truthful to the purpose of the function, in the sense that it should convey the difference betwee... | 0631fc937a1afefd821a0c707fb0b5881269458d | {
"head_commit": "d69ddd2ac37b18251b55f6f6e40995b1fac04402",
"head_commit_message": "Apply suggestions from code review\r\n\r\nCommitted 1 code suggestion in code review.\n\nCo-Authored-By: hroff-1902 <47309513+hroff-1902@users.noreply.github.com>",
"patch_to_review": "diff --git a/docs/configuration.md b/docs/co... | [
{
"diff_hunk": "@@ -163,8 +168,11 @@ def send_msg(self, msg: Dict[str, Any]) -> None:\n and self._fiat_converter):\n msg['profit_fiat'] = self._fiat_converter.convert_amount(\n msg['profit_amount'], msg['stake_currency'], msg['fiat_currency'])\n- ... | 4cdcf00ddc66078fab81f226f5485a2df99ea811 | diff --git a/docs/configuration.md b/docs/configuration.md
index fd686834fbf..211f7a04ccc 100644
--- a/docs/configuration.md
+++ b/docs/configuration.md
@@ -92,7 +92,9 @@ Mandatory parameters are marked as **Required**, which means that they are requi
| `webhook.enabled` | Enable usage of Webhook notifications <br> **... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
freqtrade__freqtrade-2760@3519ceb | freqtrade/freqtrade | Python | 2,760 | Remove hardcoded exchange parameters | ## Summary
We should not hardcode timeframes nor stake-currencies. THey vary by exchange, so we should use what the exchange gives us.
Closes #2757
closes #1861
## Quick changelog
- Use timeframes from the exchange
- Use quote-currencies from the exchange
- Limit freqtrade to work on timeframes >1m (lower... | 2020-01-11T11:05:13Z | Support USDC as a stake
I would like to use USDC as a stake trading with binance. I am currently using USDT but due to controversy that surround it would be nice if we can use another stable coin as a stake. It wont be a pleasure to wake up one morning and see that USDT have crashed -50% or something like that...
Is... | @xmatthias could the static list of stake currencies be changed to dynamic exchange specific one?
i.e., we could implement get_quote_symbols() (and possibly get_symbols(), get_base_symbols() for completness) methods in the Exchange class and use the returned list for checking the stake_currency to be in it instead of ... | [
{
"body": "I would like to use USDC as a stake trading with binance. I am currently using USDT but due to controversy that surround it would be nice if we can use another stable coin as a stake. It wont be a pleasure to wake up one morning and see that USDT have crashed -50% or something like that...\r\n",
... | 90a905237746d4f0b56b6895e28395718b689e4a | {
"head_commit": "3519cebf66e31aa799ae9422ab31e17c20153844",
"head_commit_message": "Add test for failing stake_validation",
"patch_to_review": "diff --git a/freqtrade/configuration/config_validation.py b/freqtrade/configuration/config_validation.py\nindex 54941043d20..5183ad0b4ef 100644\n--- a/freqtrade/configur... | [
{
"diff_hunk": "@@ -216,8 +216,9 @@ def get_quote_currencies(self) -> List[str]:\n Return a list of supported quote currencies\n \"\"\"\n markets = self.markets\n- currencies = set([x.get('quote') for _, x in markets.items()])\n- return list(currencies)\n+ currencies... | 53abfdbcbf032de93994fb2965b6d0192660df6a | diff --git a/freqtrade/configuration/config_validation.py b/freqtrade/configuration/config_validation.py
index 54941043d20..5183ad0b4ef 100644
--- a/freqtrade/configuration/config_validation.py
+++ b/freqtrade/configuration/config_validation.py
@@ -48,11 +48,6 @@ def validate_config_schema(conf: Dict[str, Any]) -> Dict... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
getsentry__sentry-76053@48c6a71 | getsentry/sentry | Python | 76,053 | feat(tooltip): Create tooltip context | We do not want the tooltip component to be aware of the global modals state, so this PR adds a tooltip context that we use inside the global modal
closes https://github.com/getsentry/sentry/issues/75624 | 2024-08-13T12:27:28Z | Create a Tooltip Context to set the tooltip's position
Work on some kind of tooltip context instead of making the tooltip aware of modals. Basically the context would tell the tooltip where to render. So by default without a context it would render into the body. But then if a tooltip is rendered within the tooltip con... | [
{
"body": "Work on some kind of tooltip context instead of making the tooltip aware of modals. Basically the context would tell the tooltip where to render. So by default without a context it would render into the body. But then if a tooltip is rendered within the tooltip context then it would render somewhere ... | a0237e4ce21aa2469e8b4b776379716d55d3a43a | {
"head_commit": "48c6a716adad407ed053db81c8aec920f90b48e7",
"head_commit_message": "add test",
"patch_to_review": "diff --git a/static/app/components/globalModal/index.spec.tsx b/static/app/components/globalModal/index.spec.tsx\nindex 6eeacc3dace6bc..1d0d5c01d11e3b 100644\n--- a/static/app/components/globalModal... | [
{
"diff_hunk": "@@ -7,6 +7,8 @@ import {\n } from 'sentry-test/reactTestingLibrary';\n \n import {closeModal, openModal} from 'sentry/actionCreators/modal';\n+import {Button} from 'sentry/components/button';",
"line": null,
"original_line": 10,
"original_start_line": null,
"path": "static/app/co... | bbd9154e706dcf040b0274090970035498fb38a3 | diff --git a/static/app/components/globalModal/index.spec.tsx b/static/app/components/globalModal/index.spec.tsx
index 6eeacc3dace6bc..67bcd4133940ce 100644
--- a/static/app/components/globalModal/index.spec.tsx
+++ b/static/app/components/globalModal/index.spec.tsx
@@ -7,6 +7,7 @@ import {
} from 'sentry-test/reactTe... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
freqtrade__freqtrade-2695@a71deed | freqtrade/freqtrade | Python | 2,695 | Improve pairlocking mechanism to allow usage from within strategy | ## Summary
Document usage of custom pairlocks, and slightly improve handling of it. The bot should never be allowed to lower the lock (it's not needed for internal use, and should not override external usage).
Closes #2582
## Quick changelog
* Don't allow lowering the time once a lock is in place (use `unloc... | 2019-12-22T08:59:38Z | Penalize: stop trading losing pairs
It would be very helpful if there was a way to stop or pause losing pairs. For example, if a pair caused 2 subsequent losing trades, it might be a good idea to stop trading said pair for a while. | Just a question, to clarify the idea: assume you 'stopped' a pair. At what conditions should it be returned back to trading? After some timeout or what? Manually by an RPC command?
i think it's a duplicate of #1841.
However, i'm not convinced that this should be part of the in the bot core logic.
Having this... | [
{
"body": "It would be very helpful if there was a way to stop or pause losing pairs. For example, if a pair caused 2 subsequent losing trades, it might be a good idea to stop trading said pair for a while. ",
"number": 2582,
"title": "Penalize: stop trading losing pairs"
}
] | 3f44d51355c634eb915c922d82c4d94ba9ab0874 | {
"head_commit": "a71deeda94f4c55ae1a8f30d10d034ffb0acbcd4",
"head_commit_message": "Document lock-pair implementation",
"patch_to_review": "diff --git a/docs/strategy-customization.md b/docs/strategy-customization.md\nindex 4efca7d2fcd..011f64d705d 100644\n--- a/docs/strategy-customization.md\n+++ b/docs/strateg... | [
{
"diff_hunk": "@@ -455,6 +455,49 @@ Sample return value: ETH/BTC had 5 trades, with a total profit of 1.5% (ratio of\n !!! Warning\n Trade history is not available during backtesting or hyperopt.\n \n+### Prevent trades from happening for a specific pair\n+\n+Freqtrade locks pairs automatically for the cur... | 2195ae59d6227de123a85a1a547be0d956b49656 | diff --git a/docs/strategy-customization.md b/docs/strategy-customization.md
index 4efca7d2fcd..d59b097d76a 100644
--- a/docs/strategy-customization.md
+++ b/docs/strategy-customization.md
@@ -455,6 +455,51 @@ Sample return value: ETH/BTC had 5 trades, with a total profit of 1.5% (ratio of
!!! Warning
Trade histo... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
getsentry__sentry-75210@d7f4634 | getsentry/sentry | Python | 75,210 | feat(toolbar): add red indicator badge if crashes >> healthy sessions | - closes https://github.com/getsentry/sentry/issues/75184
- add red indicator badge with fire icon if over 10% of sessions are crashes (this threshold can be changed; i picked it arbitrarily)
- for ratios < 10%, no indicator badge
<img width="190" alt="SCR-20240729-ocbq" src="https://github.com/user-attachments/as... | 2024-07-29T23:00:39Z | [DevToolbar] Show an indicator on the Open/Close Releases button that indicates whether the latest release has more or less crashes than the prev release
We could do like a subtle green indicator with a checkbox icon when things are good, and a red one with an arrow when things are bad.
Add a tooltip so we know if it... | [
{
"body": "We could do like a subtle green indicator with a checkbox icon when things are good, and a red one with an arrow when things are bad. \n\nAdd a tooltip so we know if it's crash-free rate (which is what's inside the panel) or crash-count. \n- Crash-free rate, higher is better, up to 100%\n- Crash-coun... | 71ecf42d18d6d6c05127f3d1c309274e7520a430 | {
"head_commit": "d7f4634fe13731440555ebd5d3174442f6e4b773",
"head_commit_message": "feat(toolbar): add red indicator badge if crashes >> healthy sessions",
"patch_to_review": "diff --git a/static/app/components/devtoolbar/components/indicatorBadge.tsx b/static/app/components/devtoolbar/components/indicatorBadge.... | [
{
"diff_hunk": "@@ -0,0 +1,24 @@\n+import IndicatorBadge from 'sentry/components/devtoolbar/components/indicatorBadge';\n+import useSessionStatus from 'sentry/components/devtoolbar/components/releases/useSessionStatus';\n+import {IconFire} from 'sentry/icons';\n+\n+export default function CrashCountBadge() {\n+... | 222d5382f3cc6239d9109618bfae63dd40d2aa8d | diff --git a/static/app/components/devtoolbar/components/indicatorBadge.tsx b/static/app/components/devtoolbar/components/indicatorBadge.tsx
new file mode 100644
index 00000000000000..f5cc67d9d586ea
--- /dev/null
+++ b/static/app/components/devtoolbar/components/indicatorBadge.tsx
@@ -0,0 +1,37 @@
+import type React fr... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
freqtrade__freqtrade-2619@1da008b | freqtrade/freqtrade | Python | 2,619 | Document "quick" hyperopt of roi/stoploss and trailing stoploss | ## Summary
Document the "quick" hyperopt mode - without modifying the default hyperopt template.
Works only for ROI / stoploss / trailing stoploss spaces (not for buy / sell).
closes #2231
**Note:** I hope this renders correctly in the docs (codeblock within the "tip"-box), otherwise we'll need to move this a... | 2019-12-05T19:46:31Z | Hyperopting strategies without creation of Hyperopt class
_"Show me the money"_ 😄
The user is looking at the samples of the strategies, for example in the freqtrade-strategies, in the @berlinguyinca dir. She sees a strategy with a very attractive name ('Quickie'), the approach implemented in it also looks promisin... | looks beautiful!
On Fri, Sep 6, 2019 at 7:23 PM hroff-1902 <notifications@github.com> wrote:
> *"Show me the money"* 😄
>
> The user is looking at the samples of the strategies, for example in the
> freqtrade-strategies, in the @berlinguyinca
> <https://github.com/berlinguyinca> dir. She sees a strategy with very
> a... | [
{
"body": "_\"Show me the money\"_ 😄 \r\n\r\nThe user is looking at the samples of the strategies, for example in the freqtrade-strategies, in the @berlinguyinca dir. She sees a strategy with a very attractive name ('Quickie'), the approach implemented in it also looks promising and interesting. She decides to... | 8dd9b5c6fba973b98defc0f9a9e2e3c01af735dd | {
"head_commit": "1da008b3aff2d498044e92bf0b50e612a18eb416",
"head_commit_message": "Document \"quick\" hyperopt of roi/stoploss and trailing stoploss",
"patch_to_review": "diff --git a/docs/hyperopt.md b/docs/hyperopt.md\nindex 0661896a0e0..befd448bb1b 100644\n--- a/docs/hyperopt.md\n+++ b/docs/hyperopt.md\n@@ -... | [
{
"diff_hunk": "@@ -50,6 +50,16 @@ Rarely you may also need to override:\n * `stoploss_space` - for custom stoploss optimization (if you need the range for the stoploss parameter in the optimization hyperspace that differs from default)\n * `trailing_space` - for custom trailing stop optimization (if you need t... | 2bd4008cb2739f6c2cf47698e21e1529c4c77c73 | diff --git a/docs/hyperopt.md b/docs/hyperopt.md
index 0661896a0e0..e0adfb890dd 100644
--- a/docs/hyperopt.md
+++ b/docs/hyperopt.md
@@ -50,6 +50,16 @@ Rarely you may also need to override:
* `stoploss_space` - for custom stoploss optimization (if you need the range for the stoploss parameter in the optimization hyper... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "New Feature Additions"
} |
freqtrade__freqtrade-2625@bb9235c | freqtrade/freqtrade | Python | 2,625 | Validate stake-currency against pairlist | ## Summary
We should verify that only correct pairs are in the whitelist.
Otherwise backtesting may have irritating results (#2622) - and it'll result in the static-pairlist outputting "removing pair from whtitelist" once per iteration for all incompatible pairs.
Closes #2622
## Quick changelog
- Check that ... | 2019-12-07T14:45:34Z | Issue about stake_currency during Backtesting/Hyperopt
When I do a backtest (or Hyperopting) with USDT as the stake currency and XXX/USDT as pair-Iist (& EUR as fiat currency), I have a total profit in "USDT" of 1.5 USDT and a total profit growth of 1254%, but that doesn't seem normal to have 1.2 USDT for a growth of 1... | Please:
Fill the fields:
* Operating system: ____
* Python Version: _____ (`python -V`)
* CCXT version: _____ (`pip freeze | grep ccxt`)
* Branch: Master | Develop
* Last Commit ID: _____ (`git log --format="%H" -n 1`)
Attach the output of both commands (with their complete log) along with commands... | [
{
"body": "When I do a backtest (or Hyperopting) with USDT as the stake currency and XXX/USDT as pair-Iist (& EUR as fiat currency), I have a total profit in \"USDT\" of 1.5 USDT and a total profit growth of 1254%, but that doesn't seem normal to have 1.2 USDT for a growth of 1202% (stake amount = 0.002) and th... | 9e85376a2df3443b2d3cf5888ddb4b08f75601ff | {
"head_commit": "bb9235c7155dbd562c001e3935a7791629d3f846",
"head_commit_message": "Validate stake-currency against pairlist - making sure only correct\npairs are in the whitelist",
"patch_to_review": "diff --git a/freqtrade/configuration/config_validation.py b/freqtrade/configuration/config_validation.py\nindex... | [
{
"diff_hunk": "@@ -131,3 +131,10 @@ def _validate_whitelist(conf: Dict[str, Any]) -> None:\n if (pl.get('method') == 'StaticPairList'\n and not conf.get('exchange', {}).get('pair_whitelist')):\n raise OperationalException(\"StaticPairList requires pair_whitelist to be set.\"... | ed7207d4c8a8f16499f32de7c34dce82a76061c3 | diff --git a/freqtrade/configuration/config_validation.py b/freqtrade/configuration/config_validation.py
index 4bfd246778c..06836488421 100644
--- a/freqtrade/configuration/config_validation.py
+++ b/freqtrade/configuration/config_validation.py
@@ -131,3 +131,15 @@ def _validate_whitelist(conf: Dict[str, Any]) -> None:... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
home-assistant__core-82408@9633957 | home-assistant/core | Python | 82,408 | Attempt to fix occasional Flo timeouts | <!--
You are amazing! Thanks for contributing to our project!
Please, DO NOT DELETE ANY TEXT from this template! (unless instructed).
-->
## Breaking change
<!--
If your PR contains a breaking change for existing users, it is important
to tell them what breaks, how to make it work again and why we did th... | 2022-11-20T12:18:31Z | Flo by Moen Disconnects
### The problem
All my Flo devices report no data. If I do the reload command the data returns. Any ideas. Can I script a daily reload ?
Steven
### What version of Home Assistant Core has the issue?
Home Assistant 2022.10.5 Supervisor 2022.10.0 Operating System 9.3 Frontend 20221010.0 ... | Hey there @dmulcahey, mind taking a look at this issue as it has been labeled with an integration (`flo`) you are listed as a [code owner](https://github.com/home-assistant/core/blob/dev/CODEOWNERS#L362) for? Thanks!
<details>
<summary>Code owner commands</summary>
Code owners of `flo` can trigger bot actions by com... | [
{
"body": "### The problem\n\nAll my Flo devices report no data. If I do the reload command the data returns. Any ideas. Can I script a daily reload ?\r\n\r\nSteven \n\n### What version of Home Assistant Core has the issue?\n\nHome Assistant 2022.10.5 Supervisor 2022.10.0 Operating System 9.3 Frontend 20221010... | 9add474c457b75929f52eb0cc5446c432c84ece9 | {
"head_commit": "963395755d900b0186f88f2fa2ca4f59f6a5c5d0",
"head_commit_message": "Attempt to fix occasional Flo timeouts",
"patch_to_review": "diff --git a/homeassistant/components/flo/device.py b/homeassistant/components/flo/device.py\nindex ca4b6aa623488..c636b23a41d38 100644\n--- a/homeassistant/components/... | [
{
"diff_hunk": "@@ -40,7 +40,7 @@ def __init__(\n async def _async_update_data(self):\n \"\"\"Update data via library.\"\"\"\n try:\n- async with timeout(10):\n+ async with timeout(20):\n await asyncio.gather(",
"line": null,
"original_line": 44,... | d6162d6a9b000a3d6ff51b67b0cf0fd24cb8bd3d | diff --git a/homeassistant/components/flo/device.py b/homeassistant/components/flo/device.py
index ca4b6aa623488..d6e05c1713657 100644
--- a/homeassistant/components/flo/device.py
+++ b/homeassistant/components/flo/device.py
@@ -1,7 +1,6 @@
"""Flo device object."""
from __future__ import annotations
-import asyncio... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
home-assistant__core-82233@ae43bfb | home-assistant/core | Python | 82,233 | Fix high latency from thundering heard at 0 microseconds | ## Proposed change
<!--
Describe the big picture of your changes here to communicate to the
maintainers why we should accept this pull request. If it fixes a bug
or resolves a feature request, be sure to link to that issue in the
additional information section.
-->
Fix high latency at 0 microseconds
fix... | 2022-11-17T00:00:10Z | Event loop has higher latency at 0 microsecond timestamps
### The problem
The latency goes way up at 0 microseconds. It seems we have some type of thundering herd problem where many events align to happen at 0
### What version of Home Assistant Core has the issue?
dev
### What was the last working version of Home ... | Well as soon as I opened the issue I found the issue
#32974 introduced code to align all update coordinators at microsecond 0 | [
{
"body": "### The problem\n\nThe latency goes way up at 0 microseconds. It seems we have some type of thundering herd problem where many events align to happen at 0\n\n### What version of Home Assistant Core has the issue?\n\ndev\n\n### What was the last working version of Home Assistant Core?\n\nn/a\n\n### W... | ba8f69a5ce0d2862c509cba06468a0373a680427 | {
"head_commit": "ae43bfb442679fc00454ce9280da4055fb4373fe",
"head_commit_message": "Fix high latency at 0 microseconds\n\nfixes #82231",
"patch_to_review": "diff --git a/homeassistant/helpers/update_coordinator.py b/homeassistant/helpers/update_coordinator.py\nindex 768b8040729ecc..e344585cc8ccbd 100644\n--- a/h... | [
{
"diff_hunk": "@@ -61,6 +62,10 @@ def __init__(\n # when it was already checked during setup.\n self.data: _T = None # type: ignore[assignment]\n \n+ # Pick a random microsecond to stagger the refreshes\n+ # and avoid a thundering herd.\n+ self._microsecond = randint(50000... | db12845bb7d65de38f3c1e5dc3886116c4d3152c | diff --git a/homeassistant/helpers/event.py b/homeassistant/helpers/event.py
index 613b6fb322716..b553b855be185 100644
--- a/homeassistant/helpers/event.py
+++ b/homeassistant/helpers/event.py
@@ -8,6 +8,7 @@
from datetime import datetime, timedelta
import functools as ft
import logging
+from random import randint
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Performance Optimizations"
} |
getsentry__sentry-74710@d6a49de | getsentry/sentry | Python | 74,710 | ref(traces): Add 'open in metrics' button | ### Goal
On the traces pages, we display a '+' button that allows users to add a new metric based on the span attribute when rendering the additional data card. This PR introduces a new button, 'Open in Metrics', which appears when an existing metrics rule is already defined for the span attribute. By clicking this bu... | 2024-07-23T09:42:27Z | Check for existing extraction rules in trace view
- if we already have a rule for that attribute, show Open in Metrics - otherwise keep the + icon
- open in metrics will adjust the time window to +/- 30 mins of that span | [
{
"body": "- if we already have a rule for that attribute, show Open in Metrics - otherwise keep the + icon\n- open in metrics will adjust the time window to +/- 30 mins of that span",
"number": 74622,
"title": "Check for existing extraction rules in trace view"
}
] | 98f6bc70cc9e874f72c95f98d0781d47149c89a1 | {
"head_commit": "d6a49de273490f7fc6108d7ab4ea64b007120d5c",
"head_commit_message": "feedback",
"patch_to_review": "diff --git a/static/app/components/keyValueData/index.tsx b/static/app/components/keyValueData/index.tsx\nindex f40e1dc2020b5b..919e435cacc59e 100644\n--- a/static/app/components/keyValueData/index.... | [
{
"diff_hunk": "@@ -1,4 +1,5 @@\n import {Fragment, useMemo} from 'react';\n+import {Link} from 'react-router';",
"line": null,
"original_line": 2,
"original_start_line": null,
"path": "static/app/views/performance/newTraceDetails/traceDrawer/details/span/sections/keys.tsx",
"start_line": nu... | 8fa070df14ebec33e553fe171992ae2dbcda6605 | diff --git a/static/app/components/keyValueData/index.tsx b/static/app/components/keyValueData/index.tsx
index f40e1dc2020b5b..919e435cacc59e 100644
--- a/static/app/components/keyValueData/index.tsx
+++ b/static/app/components/keyValueData/index.tsx
@@ -1,5 +1,6 @@
import {Children, isValidElement, type ReactNode, us... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
freqtrade__freqtrade-2492@26a7af8 | freqtrade/freqtrade | Python | 2,492 | Add trailing stoploss hyperspace | Adds the new 'trailing' hyperspace for Hyperopt for optimizing trailing stoploss parameters.
Resolves #2363
* Change to the `--spaces`:
I do not think this should be in the optimization path by default. Optimization for the trailing stop parameters should better be done differently (or specified explicitly, if u... | 2019-11-07T23:02:22Z | Hyperopt trailing stoploss hyperoptimization space
## My environment
* Operating system: Windows
* Python Version: Python 3.7.4
* Branch: freqtrade develop-7d1f66cc
### The suggestion
In hyperopt I currently can't find an easy way to hyperopt values like `trailing_stop_positive` or `trailing_stop_positive_offs... | this is probably not easy to implement...
at first look it looks rather straightforward...
it's another space - almost identical to stoploss...
could probably also be implemented into the stoploss_space() - which will make it a 8 line change (excluding tests and such).
``` python
def stoploss_space() -> Lis... | [
{
"body": "## My environment\r\n\r\n* Operating system: Windows\r\n* Python Version: Python 3.7.4\r\n* Branch: freqtrade develop-7d1f66cc\r\n\r\n### The suggestion\r\nIn hyperopt I currently can't find an easy way to hyperopt values like `trailing_stop_positive` or `trailing_stop_positive_offset`. Maybe make a ... | e0e0bad7c10fe011f9c7b0a035a6b1814a21dab8 | {
"head_commit": "26a7af85eaae69bce974c6ac97837bb248384a05",
"head_commit_message": "Add trailing_space() into AdvancedSampleHyperOpt",
"patch_to_review": "diff --git a/docs/hyperopt.md b/docs/hyperopt.md\nindex 5a3ae7e3ad2..640ea6b74db 100644\n--- a/docs/hyperopt.md\n+++ b/docs/hyperopt.md\n@@ -46,8 +46,9 @@ Opt... | [
{
"diff_hunk": "@@ -46,8 +46,9 @@ Optional - can also be loaded from a strategy:\n Rarely you may also need to override:\n \n * `roi_space` - for custom ROI optimization (if you need the ranges for the ROI parameters in the optimization hyperspace that differ from default)\n-* `generate_roi_table` - for custom ... | 668d42447fa404835e874e6113f846ca51b72436 | diff --git a/docs/hyperopt.md b/docs/hyperopt.md
index 5a3ae7e3ad2..c4db6da8790 100644
--- a/docs/hyperopt.md
+++ b/docs/hyperopt.md
@@ -46,8 +46,9 @@ Optional - can also be loaded from a strategy:
Rarely you may also need to override:
* `roi_space` - for custom ROI optimization (if you need the ranges for the ROI ... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
freqtrade__freqtrade-2451@6928c68 | freqtrade/freqtrade | Python | 2,451 | Bt analysis maxopen at any time | ## Summary
Expose the algorithm to get max_open_trades at each candle to users.
Closes #2449
## Quick changelog
- Add `analyze_trade_parallelism()`
- Document `analyze_trade_parallelism()` as part of the juptyer notebook (Export of the notebook is in `strategy_analysis_example.md `). | 2019-10-30T13:16:56Z | Strategy analysis -> how many max_open_trades i will use for this strategy ?
As an algo trade
I want to perform statistics like maximum drawdown, profit and find an optimum between stake_amount and max_open_trade so i run and export the backtest with --disable-max-market-positions flag and make simulations in jupyter.... | I don't think it should be part of `load_backtest_data()` - since this returns a dataframe with data per pair. Adding the open_trade_number to each line would taint it with non-pair information ... which i don't think is good.
Also (even worse), `load_backtest_data()` includes an open and close time per line. What w... | [
{
"body": "As an algo trade\r\nI want to perform statistics like maximum drawdown, profit and find an optimum between stake_amount and max_open_trade so i run and export the backtest with --disable-max-market-positions flag and make simulations in jupyter.\r\nSo that i can find a comprise between risk and profi... | 669a6cf1190acf3209edcc0f94a055baf0105e01 | {
"head_commit": "6928c685a8ee8894b5494974f90ae079dcae9fc1",
"head_commit_message": "Add documentation sample for parallel_trade_analysis",
"patch_to_review": "diff --git a/docs/strategy_analysis_example.md b/docs/strategy_analysis_example.md\nindex 49800bbb31a..55f1bd908df 100644\n--- a/docs/strategy_analysis_ex... | [
{
"diff_hunk": "@@ -107,6 +107,22 @@ trades = load_trades_from_db(\"sqlite:///tradesv3.sqlite\")\n trades.groupby(\"pair\")[\"sell_reason\"].value_counts()\n ```\n \n+## Analyze the loaded trades for trade parallelism\n+This can be useful to find the best `max_open_trades` parameter, when used with backtesting ... | bba8e614094605c254bed875f0a846026305a437 | diff --git a/docs/strategy_analysis_example.md b/docs/strategy_analysis_example.md
index 49800bbb31a..aa4578ca7b0 100644
--- a/docs/strategy_analysis_example.md
+++ b/docs/strategy_analysis_example.md
@@ -107,6 +107,22 @@ trades = load_trades_from_db("sqlite:///tradesv3.sqlite")
trades.groupby("pair")["sell_reason"].v... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
freqtrade__freqtrade-2430@132a4da | freqtrade/freqtrade | Python | 2,430 | Add Startup period for strategies | ## Summary
Since most indicators need a startup-period, freqtrade should know about it and handle this accordingly.
This PR adds the `startup_candle_count` attribute to the strategy, which should be set to the maximum any indicator looks back.
Backtesting then tries to load data earlier than the specified date -... | 2019-10-27T09:45:39Z | backtesting and timeranges - startup timerange
Signals that require X candles don't work as expected when timeranges are specified because the available data is limited to the timerange, both in timeframes and date notations (?)
This can cause wrong signals at the start of the timerange until enough data is available
... | yes, strategies will require startup time - but it's impossible to determine this automatically, since even if the column is called `ema20`, it could be a typo and contain `ema200` ...
It's an oddity when you try to exactly recreate a trading day - but normally not a problem for backtesting or hyperopt if the exact ti... | [
{
"body": "Signals that require X candles don't work as expected when timeranges are specified because the available data is limited to the timerange, both in timeframes and date notations (?)\r\nThis can cause wrong signals at the start of the timerange until enough data is available\r\na workaround is to add ... | 17fce00a5ec353dda2b8057b7dbf5e070dc4d5e9 | {
"head_commit": "132a4da7cf6ce448877506d28e7fbc9b2b63701d",
"head_commit_message": "Small style fixes and adjusted tests",
"patch_to_review": "diff --git a/docs/backtesting.md b/docs/backtesting.md\nindex 34c5f1fbe89..6d21fa2bf2f 100644\n--- a/docs/backtesting.md\n+++ b/docs/backtesting.md\n@@ -72,6 +72,8 @@ The... | [
{
"diff_hunk": "@@ -126,9 +142,15 @@ def load_pair_history(pair: str,\n :param exchange: Exchange object (needed when using \"refresh_pairs\")\n :param fill_up_missing: Fill missing values with \"No action\"-candles\n :param drop_incomplete: Drop last candle assuming it may be incomplete.\n+ :par... | 61c037f2cf0bb6a43026bc43ad3e2ed4312d0d2b | diff --git a/docs/backtesting.md b/docs/backtesting.md
index 34c5f1fbe89..6d21fa2bf2f 100644
--- a/docs/backtesting.md
+++ b/docs/backtesting.md
@@ -72,6 +72,8 @@ The exported trades can be used for [further analysis](#further-backtest-result-
freqtrade backtesting --export trades --export-filename=backtest_samplestra... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
freqtrade__freqtrade-2343@9b23376 | freqtrade/freqtrade | Python | 2,343 | Move experimental settings to ask_strategy | * Experimental settings moved to `['ask_strategy']`.
* The default value for `ask_strategy.use_sell_signal` changed to True (true in json config)
* Docs adjusted (description of `use_sell_signal` slightly improved)
* Tests adjusted
* An error in json schema fixed (it was using `ignore_roi_if_buy_signal_true` instea... | 2019-10-05T10:32:24Z | Redesign experimental settings
The suggestion is:
* move experimental settings out of experimental to the root:
```
"experimental": {
"use_sell_signal": false,
"sell_profit_only": false,
"ignore_roi_if_buy_signal": false
},
```
They are implemented for more than an year and sh... | yes and yes - we could (probably should) also have a grace-period - where these settings are "copied" to the root-level with a depreciation warning ...
so people can slowly adapt to this.
right, fine,
the latter one (the default value of true for `use_sell_signal`) does not require adding deprecation messages. | [
{
"body": "The suggestion is:\r\n\r\n* move experimental settings out of experimental to the root:\r\n```\r\n \"experimental\": {\r\n \"use_sell_signal\": false,\r\n \"sell_profit_only\": false,\r\n \"ignore_roi_if_buy_signal\": false\r\n },\r\n```\r\nThey are implemented for more tha... | caf415dc97df3cdb607a2ebef18bbc2851b980a8 | {
"head_commit": "9b233764153adcf939e72fc45d8a0c54bd865093",
"head_commit_message": "Move experimental settings to ask_strategy",
"patch_to_review": "diff --git a/config.json.example b/config.json.example\nindex 94084434a98..41901903056 100644\n--- a/config.json.example\n+++ b/config.json.example\n@@ -22,7 +22,10... | [
{
"diff_hunk": "@@ -65,6 +65,9 @@ Mandatory parameters are marked as **Required**, which means that they are requi\n | `ask_strategy.use_order_book` | false | Allows selling of open traded pair using the rates in Order Book Asks.\n | `ask_strategy.order_book_min` | 0 | Bot will scan from the top min to max Orde... | 23b5c0e833b2702b3649ddeec6d11ebdf11b5700 | diff --git a/config.json.example b/config.json.example
index 94084434a98..41901903056 100644
--- a/config.json.example
+++ b/config.json.example
@@ -22,7 +22,10 @@
"ask_strategy":{
"use_order_book": false,
"order_book_min": 1,
- "order_book_max": 9
+ "order_book_max": 9,
+ "u... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Code Refactoring / Architectural Improvement"
} |
freqtrade__freqtrade-2344@82d4051 | freqtrade/freqtrade | Python | 2,344 | Backtest no fees / custom fees | ## Summary
Allow specifying fee percentage to be applied during backtesting.
This can be usefull if you'r exchange account has some rabates applied (for high volume, for example), which ccxt does not detect (it'll always show the basic fees for each exchange).
This can also be "abused" to add slippage, by specif... | 2019-10-05T13:37:45Z | support the configuration of slippage for backtest/hyperopts
idea :
As a trader
i want to configure a slippage when i test a strategy that deal with low volume or xxx/btc that have low decimals digits of precision
so that the backtest look closer to live and the objective function take slippage into account for opt... | > i can write test case if needed to exchange the how to.
Yes, please.
It can be as simple as subtracting some slippage percent from the profit of each trade.
Then the slippage percent should simply be added to the config, this is easiest part.
you call it slippage - but in theory, a simple `--fee` parameter w... | [
{
"body": "idea :\r\nAs a trader\r\ni want to configure a slippage when i test a strategy that deal with low volume or xxx/btc that have low decimals digits of precision \r\nso that the backtest look closer to live and the objective function take slippage into account for optimization\r\n\r\ni can write test ca... | 553a1b90ba9cd467dda53452ccd12176b2b2d2de | {
"head_commit": "82d4051a39545ae8d3425b66649cff56928c6864",
"head_commit_message": "Add --fee to documentation",
"patch_to_review": "diff --git a/docs/backtesting.md b/docs/backtesting.md\nindex 75aba6c73a1..cc3f1102668 100644\n--- a/docs/backtesting.md\n+++ b/docs/backtesting.md\n@@ -72,6 +72,17 @@ The exported... | [
{
"diff_hunk": "@@ -168,22 +168,25 @@ Backtesting also uses the config specified via `-c/--config`.\n \n ```\n usage: freqtrade backtesting [-h] [-i TICKER_INTERVAL] [--timerange TIMERANGE]\n- [--max_open_trades MAX_OPEN_TRADES]\n- [--stake_amount STAKE_AMOUNT... | ad35a3d7ab93aafd8a2921d7d452e4de6f00e22e | diff --git a/docs/backtesting.md b/docs/backtesting.md
index 75aba6c73a1..ec31bec0150 100644
--- a/docs/backtesting.md
+++ b/docs/backtesting.md
@@ -72,6 +72,17 @@ The exported trades can be used for [further analysis](#further-backtest-result-
freqtrade backtesting --export trades --export-filename=backtest_samplestr... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
ivy-llc__ivy-5420@c488104 | ivy-llc/ivy | Python | 5,420 | fix matrix_norm superset behaviour | fixes #5402 | 2022-10-07T23:51:13Z | superset behaviour in matrix_norm (linear_algebra.py)
after adding superset behavoir to matrix_norm , the type hint in `axis: Optional[Union[int, Sequence[int]]] = None` gives the possibility to use an integer while the backend implemetations convert the axis to a tuple, in the case of an integer axis that would throw ... | output after calling the function with an integer axis :
```
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/workspaces/ivy/ivy/func_wrapper.py", line 144, in new_fn
ret = fn(*args, **kwargs)
File "/workspaces/ivy/ivy/func_wrapper.py", line 82, in new_fn
return fn(*n... | [
{
"body": "after adding superset behavoir to matrix_norm , the type hint in `axis: Optional[Union[int, Sequence[int]]] = None` gives the possibility to use an integer while the backend implemetations convert the axis to a tuple, in the case of an integer axis that would throw the error \"int object is not itera... | b3019039ab88bfe23e75d929f0b1d79a0a294dee | {
"head_commit": "c4881047a19c22822218a9807cf9f96569d1c942",
"head_commit_message": "Merge branch 'master' into fix_matrix_norm_superset_behaviour",
"patch_to_review": "diff --git a/ivy/array/linear_algebra.py b/ivy/array/linear_algebra.py\nindex 063a06b568ef5..f5f9aae7ac7b3 100644\n--- a/ivy/array/linear_algebra... | [
{
"diff_hunk": "@@ -808,7 +808,7 @@ def static_matrix_norm(\n /,\n *,\n ord: Optional[Union[int, float, Literal[inf, -inf, \"fro\", \"nuc\"]]] = \"fro\",\n- axis: Optional[Union[int, Sequence[int]]] = None,\n+ axis: Optional[Sequence[int]] = (-2, -1),",
"line": null,
... | f28bec837f1b5ccd455791a71b9624215026d3d4 | diff --git a/ivy/array/linear_algebra.py b/ivy/array/linear_algebra.py
index 063a06b568ef5..59a53f3e58e80 100644
--- a/ivy/array/linear_algebra.py
+++ b/ivy/array/linear_algebra.py
@@ -185,7 +185,7 @@ def matrix_norm(
/,
*,
ord: Optional[Union[int, float, Literal[inf, -inf, "fro", "nuc"]]] = ... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
getsentry__sentry-73943@3b48221 | getsentry/sentry | Python | 73,943 | feat(tags): Make dataset a parameter in organization_tags endpoint | Fixes #73699
This PR replaces the `include_transaction` parameter with a `dataset` parameter in the `organization_tags` endpoint. Previously, the `include_transactions` was used to control whether to pull tags from snuba's `Discover` dataset (if `include_transactions=1`, or `Events` dataset (if `include_transactions... | 2024-07-08T14:50:22Z | Modify organization tags endpoint to accept a dataset parameter
The `OrganizationTagsEndpoint` will query the events dataset with `include_transactions=0` and the Discover dataset when `include_transactions` is enabled. This works for discover and performance issues, because both look at transactions. However, for issu... | [
{
"body": "The `OrganizationTagsEndpoint` will query the events dataset with `include_transactions=0` and the Discover dataset when `include_transactions` is enabled. This works for discover and performance issues, because both look at transactions. However, for issues, we need to be searching the errors and is... | 4a9e9341a264aed62bb52c33f8f1e1cd26372f95 | {
"head_commit": "3b482216b8c6f00af9d409264adbb4a48626cdb0",
"head_commit_message": "Add tests for dataset param",
"patch_to_review": "diff --git a/src/sentry/api/endpoints/organization_tags.py b/src/sentry/api/endpoints/organization_tags.py\nindex b79ac9ffe7d45d..821e7a3bed81ae 100644\n--- a/src/sentry/api/endpo... | [
{
"diff_hunk": "@@ -27,6 +29,12 @@ def get(self, request: Request, organization) -> Response:\n except NoProjects:\n return Response([])\n \n+ if request.GET.get(\"dataset\"):\n+ try:\n+ Dataset(request.GET.get(\"dataset\"))\n+ except ValueError:\n... | cbb5a6495becdf75f7958425b91634093b728eb9 | diff --git a/src/sentry/api/endpoints/organization_tags.py b/src/sentry/api/endpoints/organization_tags.py
index b79ac9ffe7d45d..fc26cc9b1eb8c8 100644
--- a/src/sentry/api/endpoints/organization_tags.py
+++ b/src/sentry/api/endpoints/organization_tags.py
@@ -1,4 +1,5 @@
import sentry_sdk
+from rest_framework.exception... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
freqtrade__freqtrade-2086@d59608f | freqtrade/freqtrade | Python | 2,086 | Restricted pairs warning | ## Summary
Freqtrade should warn users if they have restricted pairs in their whitelist.
As noted in https://github.com/ccxt/ccxt/issues/5624, there is currently
no way to detect if a user is impacted by the restriction or not prior to creating (and eventually failing to create) an order.
Closes #2074,
Closes... | 2019-08-03T11:17:55Z | Bot gets stucked in loop when there're restricted markets (BITTREX)
## Step 1: Have you search for this issue before posting it?
I've been looking for some kind of solution for this issue. Even tried all installation ways, and ended up creating a new instance in Binance (an moving some tokens over there). Then I rea... | This is an interesting issue.. just to be clear, this error occurs when the restricted pair is added in the static whitelist as well as when it's added by the volume pairlist, correct?
Ideally, we'd check for restricted markets in `validate_whitelist`, but I'm not sure ccxt returns any information about restricted m... | [
{
"body": "## Step 1: Have you search for this issue before posting it?\r\n\r\nI've been looking for some kind of solution for this issue. Even tried all installation ways, and ended up creating a new instance in Binance (an moving some tokens over there). Then I realized at least the conditions.\r\n\r\n## Step... | fb103dd16210cea7141ee1885c69a88385121928 | {
"head_commit": "d59608f7649ba5fc352c7a12d89b9466cbd11b2f",
"head_commit_message": "adjust some documentation wordings",
"patch_to_review": "diff --git a/docs/faq.md b/docs/faq.md\nindex 83576af4d3f..e8367608ff4 100644\n--- a/docs/faq.md\n+++ b/docs/faq.md\n@@ -45,6 +45,16 @@ the tutorial [here|Testing-new-strat... | [
{
"diff_hunk": "@@ -45,6 +45,16 @@ the tutorial [here|Testing-new-strategies-with-Hyperopt](bot-usage.md#hyperopt-c\n \n You can use the `/forcesell all` command from Telegram.\n \n+### I get the message \"RESTRICTED_MARKET\"\n+\n+Currently known to happen for US Bittrex users. \n+Bittrex split it's exchange i... | d51fd1a5d0bec672fcadd92fcc38cf15add751ca | diff --git a/docs/faq.md b/docs/faq.md
index 83576af4d3f..a441ffacd3d 100644
--- a/docs/faq.md
+++ b/docs/faq.md
@@ -45,6 +45,16 @@ the tutorial [here|Testing-new-strategies-with-Hyperopt](bot-usage.md#hyperopt-c
You can use the `/forcesell all` command from Telegram.
+### I get the message "RESTRICTED_MARKET"
+
+... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
freqtrade__freqtrade-1988@0c7d14f | freqtrade/freqtrade | Python | 1,988 | Gracefully fail on timeframes exception |
## Summary
This can happen on exchanges which don't have a "real" fetch_OHLCV method.
The example (bitstamp) has this emulated.
From the [ccxt documentation](https://ccxt.readthedocs.io/en/latest/manual.html?highlight=timeframes)
> timeframes: An associative array of timeframes, supported by the fetchOHLCV me... | 2019-06-30T18:33:47Z | Bitstamp has no attribute 'timeframes'
Python Version: Python 3.7.3
CCXT version: ccxt==1.18.805
Branch: Develop
Last Commit ID: ca7080c
## Step 3: Describe the problem:
```
Traceback (most recent call last):
File "/opt/Projects/freqtrade/freqtrade/main.py", line 51, in main
worker... | > timeframes: An associative array of timeframes, supported by the fetchOHLCV method of the exchange. This is only populated when has['fetchOHLCV'] property is true.
(source: [ccxt docs](https://ccxt.readthedocs.io/en/latest/manual.html?highlight=timeframe))
fetchOHLCV is "emulated" for bitstamp, which means that... | [
{
"body": "\r\n Python Version: Python 3.7.3\r\n CCXT version: ccxt==1.18.805\r\n Branch: Develop\r\n Last Commit ID: ca7080c\r\n \r\n## Step 3: Describe the problem:\r\n\r\n```\r\nTraceback (most recent call last):\r\n File \"/opt/Projects/freqtrade/freqtrade/main.py\", line 51, in main\r\n wo... | cdeb649d0b775be9cbc174796b4ec1abf9b814a9 | {
"head_commit": "0c7d14fe50694edd916c550b1c1213990146f648",
"head_commit_message": "Check if timeframes is available and fail gracefully otherwise",
"patch_to_review": "diff --git a/freqtrade/exchange/exchange.py b/freqtrade/exchange/exchange.py\nindex b649a7b65f1..cefee999c53 100644\n--- a/freqtrade/exchange/ex... | [
{
"diff_hunk": "@@ -269,6 +269,13 @@ def validate_timeframes(self, timeframe: List[str]) -> None:\n \"\"\"\n Checks if ticker interval from config is a supported timeframe on the exchange\n \"\"\"\n+ logger.warning(\"validate_timerames\")",
"line": null,
"original_line": 2... | 0d601fd1113615d1155986ffe65ba9b49067b68c | diff --git a/freqtrade/exchange/exchange.py b/freqtrade/exchange/exchange.py
index b649a7b65f1..2350c752fb9 100644
--- a/freqtrade/exchange/exchange.py
+++ b/freqtrade/exchange/exchange.py
@@ -269,6 +269,12 @@ def validate_timeframes(self, timeframe: List[str]) -> None:
"""
Checks if ticker interval f... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
freqtrade__freqtrade-1998@fcdbe84 | freqtrade/freqtrade | Python | 1,998 | Support all types of pairs for /balance | ## Summary
Some pairs are not available as <pair>/BTC - but BTC/<pair>. These pairs are often stake-currencies (like PAX).
we used to have a hardcoded list of these pairs, however using the exchanges "markets" for this is way more flexible, and should eliminate this bug for many other currencies (USDC, ...) too.
C... | 2019-07-03T18:22:55Z | Pax balance not detected
Version 2019.5
Bot won't detect pax base, will update to newest to see if fixed. Will also assumes that this is the same issue for other stable coins that are not tether
Last version of CCTX
Running 2019.6
Exchange Binance
Edited to add more information about the issue | This is lacking quite some information.
What exchange are you using?
what version of ccxt?
Edit: did you get any message while starting the bot?
> This is lacking quite some information.
>
> What exchange are you using?
> what version of ccxt?
>
> Edit: did you get any message while starting the bot?
N... | [
{
"body": "Version 2019.5\r\nBot won't detect pax base, will update to newest to see if fixed. Will also assumes that this is the same issue for other stable coins that are not tether \r\n\r\nLast version of CCTX\r\nRunning 2019.6\r\nExchange Binance\r\nEdited to add more information about the issue",
"numb... | d055dc0c6e0aa24297e5309eee7ea7e511bf9e51 | {
"head_commit": "fcdbe846e51a9c76f86c97b84dec28680d857a71",
"head_commit_message": "Fix #1981 - Detect reverted currency pairs",
"patch_to_review": "diff --git a/freqtrade/exchange/exchange.py b/freqtrade/exchange/exchange.py\nindex c3171b96111..536a707cd69 100644\n--- a/freqtrade/exchange/exchange.py\n+++ b/fre... | [
{
"diff_hunk": "@@ -270,6 +270,15 @@ def validate_pairs(self, pairs: List[str]) -> None:\n f'Pair {pair} is not available on {self.name}. '\n f'Please remove {pair} from your whitelist.')\n \n+ def get_valid_pair_combination(self, paira, pairb) -> str:",
"line": nu... | 6c2415d32fba4dfb784f3e0c18652b9eb304fa80 | diff --git a/freqtrade/exchange/exchange.py b/freqtrade/exchange/exchange.py
index c3171b96111..8aacc0cee6a 100644
--- a/freqtrade/exchange/exchange.py
+++ b/freqtrade/exchange/exchange.py
@@ -270,6 +270,15 @@ def validate_pairs(self, pairs: List[str]) -> None:
f'Pair {pair} is not available on {se... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
getsentry__sentry-73326@e3000fa | getsentry/sentry | Python | 73,326 | feat(frontend): Add timestamp on issue public share page | Added timestamp of latest event on the issue public share page. 
The timestamp shows local time, and a tooltip with date occurred and date received in UTC appears on hover.
resolves #71642 | 2024-06-25T21:37:18Z | Include Timestamp on Issue Public Share page
### Problem Statement
When I share an event with a public link, there is no timestamp, which makes it a lot less useful. Could you add the event timestamp to the public share page?
### Solution Brainstorm
_No response_
### Product Area
Issues | Assigning to @getsentry/support for [routing](https://open.sentry.io/triage/#2-route) ⏲️
Routing to @getsentry/product-owners-issues for [triage](https://develop.sentry.dev/processing-tickets/#3-triage) ⏲️
Hi @keithbrink, since issues often have multiple events are you referring to the timestamp of the latest event?
Th... | [
{
"body": "### Problem Statement\n\nWhen I share an event with a public link, there is no timestamp, which makes it a lot less useful. Could you add the event timestamp to the public share page?\n\n### Solution Brainstorm\n\n_No response_\n\n### Product Area\n\nIssues",
"number": 71642,
"title": "Includ... | accca8f98c4231dae9a484c8985da43e7a6c4645 | {
"head_commit": "e3000fad72d376a8402ebda7169d972920be974e",
"head_commit_message": "removed duplicate",
"patch_to_review": "diff --git a/static/app/views/sharedGroupDetails/index.spec.tsx b/static/app/views/sharedGroupDetails/index.spec.tsx\nindex 7c6c5e6d18e84f..0cc13775aa2872 100644\n--- a/static/app/views/sha... | [
{
"diff_hunk": "@@ -33,6 +41,21 @@ function SharedGroupHeader({group}: Props) {\n />\n )}\n </ShortIdWrapper>\n+ {event && (event.dateCreated ?? event.dateReceived) && (\n+ <TimeStamp data-test-id=\"sgh-timestamp\">\n+ {t('Last seen ')}\n+ ... | bfbf87d7841448395be0b6ab88830f2b423221a6 | diff --git a/static/app/views/sharedGroupDetails/index.spec.tsx b/static/app/views/sharedGroupDetails/index.spec.tsx
index 7c6c5e6d18e84f..0cc13775aa2872 100644
--- a/static/app/views/sharedGroupDetails/index.spec.tsx
+++ b/static/app/views/sharedGroupDetails/index.spec.tsx
@@ -81,5 +81,6 @@ describe('SharedGroupDetail... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
freqtrade__freqtrade-2067@c1bc1e3 | freqtrade/freqtrade | Python | 2,067 | Align userdata usage | ## Summary
Explain in one sentence the goal of this PR
Closes: #1384
## Quick changelog
- Addition of new flag to all commands (`--userdir`, `--user-data-dir`)
- defaults to `Path.cwd()/user_data` (current path's user-data).
- allows configuring `user_data_dir` to use a different one
- enables proper ver... | 2019-07-28T13:35:24Z | Align usage of --data-dir
## problem
Currently different commands implement the same command (`--data-dir`, `--strategy-dir`) - which however needs to be pointed to different folders depending on the action taken.
### examples:
* download-script needs to be pointed to `user_data/data/<exchange>`
## expectation... | #1893 can be considered as a part of this (--export --> --datadir), right?
I the whole, I guess there should be a common setting like --userdata-dir (--user-data, or something) which by default points to the user_data dir. That's in addition to the --datadir option. If --datadir is not specified, its value is compose... | [
{
"body": "## problem\r\nCurrently different commands implement the same command (`--data-dir`, `--strategy-dir`) - which however needs to be pointed to different folders depending on the action taken.\r\n\r\n### examples:\r\n* download-script needs to be pointed to `user_data/data/<exchange>`\r\n\r\n## expecta... | d2958fc0f564979c1621fa2f999c143161414197 | {
"head_commit": "c1bc1e31373f2159c650a1f0d7580f0ddf26f675",
"head_commit_message": "Add documentation for user_data_dir",
"patch_to_review": "diff --git a/docs/backtesting.md b/docs/backtesting.md\nindex 179bcee15af..57f9f629660 100644\n--- a/docs/backtesting.md\n+++ b/docs/backtesting.md\n@@ -237,7 +237,7 @@ Al... | [
{
"diff_hunk": "@@ -82,6 +87,25 @@ of your configuration in the project issues or in the Internet.\n See more details on this technique with examples in the documentation page on\n [configuration](configuration.md).\n \n+### Where to store custom data\n+\n+Freqtrade allows the creation of a user-data directory ... | aaeeb9c0c661fe38d1080bc3c5ec77e5951a5425 | diff --git a/docs/backtesting.md b/docs/backtesting.md
index 90256283e37..a49db47c4a8 100644
--- a/docs/backtesting.md
+++ b/docs/backtesting.md
@@ -248,7 +248,7 @@ All listed Strategies need to be in the same directory.
freqtrade backtesting --timerange 20180401-20180410 --ticker-interval 5m --strategy-list Strategy0... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Code Refactoring / Architectural Improvement"
} |
Subsets and Splits
Review Test Instances
Retrieves basic metadata about code review instances but doesn't provide any analytical insights or patterns beyond raw data access.