instance_id stringlengths 21 53 | repo stringclasses 188
values | language stringclasses 1
value | pull_number int64 20 148k | title stringlengths 6 144 | body stringlengths 0 83.4k | created_at stringdate 2015-09-25 03:17:17 2025-07-10 16:50:35 | problem_statement stringlengths 188 240k | hints_text stringlengths 0 145k | resolved_issues listlengths 1 6 | base_commit stringlengths 40 40 | commit_to_review dict | reference_review_comments listlengths 1 62 | merged_commit stringlengths 40 40 | merged_patch stringlengths 297 9.87M | metadata dict |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
modin-project__modin-3979@4c3e369 | modin-project/modin | Python | 3,979 | FIX-#3896: Change Series.values to default to to_numpy(). | Signed-off-by: jeffreykennethli <jkli@ponder.io>
<!--
Thank you for your contribution!
Please review the contributing docs: https://modin.readthedocs.io/en/latest/CONTRIBUTING.html
if you have questions about contributing.
-->
## What do these changes do?
Modify Series.values to default to Series.to_numpy(... | 2022-01-14T20:00:03Z | IndexError when calling modin.pandas.DataFrame.values.all()
### System information
- **OS Platform and Distribution (e.g., Linux Ubuntu 16.04)**: Microsoft Windows 10 Entreprise 10.0.18363 N/A build 18363
- **Modin version** (`modin.__version__`): 0.12.1
- **Python version**: Python 3.8.5 (tags/v3.8.5:580fbb0, Jul 2... | Thanks for bringing this up! I was able to reproduce this on my Windows machine am looking into the cause.
Can also confirm that this fails on OSX too - the pyreadline module isn't used and removing it from the code block doesn't affect the result on OSX. | [
{
"body": "### System information\r\n- **OS Platform and Distribution (e.g., Linux Ubuntu 16.04)**: Microsoft Windows 10 Entreprise 10.0.18363 N/A build 18363\r\n- **Modin version** (`modin.__version__`): 0.12.1\r\n- **Python version**: Python 3.8.5 (tags/v3.8.5:580fbb0, Jul 20 2020, 15:57:54)\r\n- **Code we ca... | be2716f393fddd2f669f26616f80e051fc7ceee6 | {
"head_commit": "4c3e3694992ad75de5c152e357e98d2c72da4c80",
"head_commit_message": "Change Series.values to default to to_numpy() and add unit test\n\nSigned-off-by: jeffreykennethli <jkli@ponder.io>",
"patch_to_review": "diff --git a/modin/pandas/series.py b/modin/pandas/series.py\nindex b970e0718cc..f6a868d828... | [
{
"diff_hunk": "@@ -3204,6 +3204,21 @@ def test_to_period():\n )\n def test_to_numpy(data):\n modin_series, pandas_series = create_test_series(data)\n+ assert_array_equal(modin_series.to_numpy(), pandas_series.to_numpy())\n+\n+\n+@pytest.mark.parametrize(\n+ \"data\",\n+ test_data_values + test_dat... | 65caf4e71df125744f9d790350337ea210c18a2e | diff --git a/modin/pandas/series.py b/modin/pandas/series.py
index b970e0718cc..f6a868d8281 100644
--- a/modin/pandas/series.py
+++ b/modin/pandas/series.py
@@ -543,7 +543,7 @@ def values(self): # noqa: RT01, D200
"""
Return Series as ndarray or ndarray-like depending on the dtype.
"""
- ... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
modin-project__modin-3777@6478565 | modin-project/modin | Python | 3,777 | FIX-#3736: Don't use a 2-d array to set a categorical column. | Signed-off-by: mvashishtha <mahesh@ponder.io>
<!--
Thank you for your contribution!
Please review the contributing docs: https://modin.readthedocs.io/en/latest/CONTRIBUTING.html
if you have questions about contributing.
-->
## What do these changes do?
Work around https://github.com/pandas-dev/pandas/issue... | 2021-12-03T19:33:49Z | Inconsistent behavior with Categorical.add_categories
### System information
- **OS Platform and Distribution (e.g., Linux Ubuntu 16.04)**: OSX 11.6
- **Modin version** (`modin.__version__`): 0.11.3
- **Python version**: 3.8.11
- **Code we can use to reproduce**:
The following code gives different results betwee... | Thanks @chrisgoddard for the report!
The updated category does not appear to be propagating in the first case. We'll get someone on this, thanks for the detailed report!
There's also probably a simple workaround, will get that to you so you don't have to wait for the release. Thanks again!
Thanks @devin-petersohn... | [
{
"body": "### System information\r\n- **OS Platform and Distribution (e.g., Linux Ubuntu 16.04)**: OSX 11.6\r\n- **Modin version** (`modin.__version__`): 0.11.3\r\n- **Python version**: 3.8.11\r\n- **Code we can use to reproduce**:\r\n\r\nThe following code gives different results between pandas as modin:\r\n\... | d590de080dddb7ed715a58d57c602d96322c4dcf | {
"head_commit": "64785659573e9b8fbbc86c094839224153fa23a0",
"head_commit_message": "FIX-#3736: Don't use a 2-d array to set a categorical column.\n\nSigned-off-by: mvashishtha <mahesh@ponder.io>",
"patch_to_review": "diff --git a/modin/core/dataframe/pandas/partitioning/partition_manager.py b/modin/core/datafram... | [
{
"diff_hunk": "@@ -385,7 +385,34 @@ def __setitem__(self, row_lookup, col_lookup, item, axis=None):\n else:\n new_col_len = len(col_lookup)\n to_shape = new_row_len, new_col_len\n- item = self._broadcast_item(row_lookup, col_lookup, item, to_shape)\n+ ... | 05a4a79c030ce6fb74a580b43645e009ab4cd861 | diff --git a/modin/core/dataframe/pandas/partitioning/partition_manager.py b/modin/core/dataframe/pandas/partitioning/partition_manager.py
index 8aa4fc69600..92089d6f8b5 100644
--- a/modin/core/dataframe/pandas/partitioning/partition_manager.py
+++ b/modin/core/dataframe/pandas/partitioning/partition_manager.py
@@ -120... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
modin-project__modin-3797@233885e | modin-project/modin | Python | 3,797 | DOCS-#3766: update 'read_csv_glob' dispatcher, parser and docstring | Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
<!--
Thank you for your contribution!
Please review the contributing docs: https://modin.readthedocs.io/en/latest/CONTRIBUTING.html
if you have questions about contributing.
-->
## What do these changes do?
1. Update docstring
2. An error with unp... | 2021-12-07T15:09:10Z | Descriptive error message and usage documentation for read_csv_glob
### System information
- Linux Ubuntu 16.04
- ray 1.8.0
- modin 0.12.0
- python 3.8
I'm seeing the below issue with `read_csv_glob` pointing to an S3 prefix that would results in multiple files being returned. I'm using the url `s3://nyc-tlc/tr... | This issue has been mentioned on **Modin Discuss**. There might be relevant details there:
https://discuss.modin.org/t/read-csv-glob-doesnt-work-on-s3-prefixes/251/4
Hi @c3-cjazra!
I don't see `*` symbol in your URL, without which function `read_csv_glob` will not work.
Can you try `read_csv_glob("s3://nyc-tlc/... | [
{
"body": "### System information\r\n- Linux Ubuntu 16.04 \r\n- ray 1.8.0\r\n- modin 0.12.0\r\n- python 3.8\r\n\r\nI'm seeing the below issue with `read_csv_glob` pointing to an S3 prefix that would results in multiple files being returned. I'm using the url `s3://nyc-tlc/trip data/yellow_tripdata_2020-` which ... | c5fc6ca5b1d56fbdcb510e46e76934ee74a91581 | {
"head_commit": "233885e5a4d9b8e4335aa75196587b674e2cca00",
"head_commit_message": "add the paragraph for 'Experimental APIs'\n\nSigned-off-by: Anatoly Myachev <anatoly.myachev@intel.com>",
"patch_to_review": "diff --git a/docs/advanced_usage/index.rst b/docs/advanced_usage/index.rst\nindex bcacde10feb..3d8f9b38... | [
{
"diff_hunk": "@@ -61,6 +61,15 @@ Modin provides an implementation of distributed XGBoost machine learning algorit\n :doc:`Modin XGBoost architecture documentation </flow/modin/experimental/xgboost>` for information about implementation and\n internal execution flow.\n \n+Experimental APIs\n+-----------------\... | f473967bce532ca17917130ad62087930547e460 | diff --git a/modin/core/io/text/csv_glob_dispatcher.py b/modin/core/io/text/csv_glob_dispatcher.py
index dd26e9aa853..f20a6d95780 100644
--- a/modin/core/io/text/csv_glob_dispatcher.py
+++ b/modin/core/io/text/csv_glob_dispatcher.py
@@ -54,6 +54,15 @@ def _read(cls, filepath_or_buffer, **kwargs):
# Ensures tha... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Documentation Updates"
} |
modin-project__modin-3742@12ee808 | modin-project/modin | Python | 3,742 | FIX-#3741: Added delivery of the data argument to df | Signed-off-by: aleksandr.lozovskii <aleksandr.lozovskii@intel.com>
<!--
Thank you for your contribution!
Please review the contributing docs: https://modin.readthedocs.io/en/latest/CONTRIBUTING.html
if you have questions about contributing.
-->
## What do these changes do?
<!-- Please give a short brief ab... | 2021-11-27T16:11:56Z | IndexError: index 0 is out of bounds for axis 0 with size 0
### System information
- **OS Platform and Distribution (e.g., Linux Ubuntu 16.04)**: Windows 10
- **Modin version** (`modin.__version__`): 0.12.0
- **Python version**: 3.8.11
- **Code we can use to reproduce**:
```
set MODIN_EXPERIMENTAL=1
set MODIN_... | [
{
"body": "### System information\r\n- **OS Platform and Distribution (e.g., Linux Ubuntu 16.04)**: Windows 10\r\n- **Modin version** (`modin.__version__`): 0.12.0\r\n- **Python version**: 3.8.11\r\n- **Code we can use to reproduce**:\r\n\r\n```\r\nset MODIN_EXPERIMENTAL=1\r\nset MODIN_ENGINE=Python\r\npython -... | edc16083648e80f9c54095a2817b589511257668 | {
"head_commit": "12ee808b510677d6ec4c85bab23a02f164803569",
"head_commit_message": "FIX-#3741: Added delivery of the data argument to df\n\nSigned-off-by: aleksandr.lozovskii <aleksandr.lozovskii@intel.com>",
"patch_to_review": "diff --git a/modin/experimental/cloud/rpyc_proxy.py b/modin/experimental/cloud/rpyc_... | [
{
"diff_hunk": "@@ -427,6 +427,9 @@ class Wrapper(override, origin_cls, metaclass=ProxyMeta):\n __wrapper_remote__ = remote_cls\n \n def __init__(self, *a, __remote_end__=None, **kw):\n+ if __remote_end__ is None:\n+ if hasattr(self, \"_preprocess_init_args\"):\n+ ... | f7eb65e3f5939ed72d720f3ecfebbad89d3bfcf1 | diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 85cbe64b76a..3b4c3dca1f2 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -549,6 +549,7 @@ jobs:
conda info
conda list
- run: python -m pytest --simulate-cloud=normal modin/pandas/test/test_io.py -... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
modin-project__modin-3765@d2d8bd2 | modin-project/modin | Python | 3,765 | FIX-#3764: Ensure df.loc with a scalar out of bounds appends to df | In pandas, `df.loc[df.index + 1] = df.loc[index]` copies the last row and increases the `df`'s len by 1. When doing the same operation in Modin, we get an error since we're trying to index out of bounds.
Signed-off-by: Rehan Durrani <rehan@ponder.io>
<!--
Thank you for your contribution!
Please review the contrib... | 2021-12-02T02:14:37Z | df.loc[max(df.index) + 1] = df.loc[any_number] raises KeyError
### System information
- **OS Platform and Distribution (e.g., Linux Ubuntu 16.04)**:
- **Modin version** (`modin.__version__`):
- **Python version**:
- **Code we can use to reproduce**:
<!--
You can obtain the Modin version with
python -c "impor... | [
{
"body": "### System information\r\n- **OS Platform and Distribution (e.g., Linux Ubuntu 16.04)**:\r\n- **Modin version** (`modin.__version__`):\r\n- **Python version**:\r\n- **Code we can use to reproduce**:\r\n\r\n<!--\r\nYou can obtain the Modin version with\r\n\r\npython -c \"import modin; print(modin.__ve... | 4bcce6ef12c0c80d6df15ef4a4b2b3a85713c106 | {
"head_commit": "d2d8bd2d22aee12f418674b2fac47432adaeeb3a",
"head_commit_message": "Small change to fix pydoc style error\n\nSigned-off-by: Bill Wang <billiam@ponder.io>",
"patch_to_review": "diff --git a/modin/core/dataframe/pandas/partitioning/partition_manager.py b/modin/core/dataframe/pandas/partitioning/par... | [
{
"diff_hunk": "@@ -412,6 +412,31 @@ def test_loc(data):\n with pytest.raises(KeyError):\n modin_df.loc[\"NO_EXIST\"]\n \n+ # From issue #3764\n+ pandas_df = pandas.DataFrame([[1, 2, 3], [4, 5, 6]])\n+ modin_df = pd.DataFrame([[1, 2, 3], [4, 5, 6]])\n+\n+ for left, right in [(2, 1), (6, ... | 56964d0b52c460eb3daf8cfc0a6ab77087512486 | diff --git a/modin/core/dataframe/pandas/partitioning/partition_manager.py b/modin/core/dataframe/pandas/partitioning/partition_manager.py
index db16ff6de1c..89a250a0962 100644
--- a/modin/core/dataframe/pandas/partitioning/partition_manager.py
+++ b/modin/core/dataframe/pandas/partitioning/partition_manager.py
@@ -122... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} | |
modin-project__modin-3753@a3c0932 | modin-project/modin | Python | 3,753 | DOCS-#3752: improve documentation of `OmnisciOnNative` execution | Signed-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
<!--
Thank you for your contribution!
Please review the contributing docs: https://modin.readthedocs.io/en/latest/CONTRIBUTING.html
if you have questions about contributing.
-->
## What do these changes do?
This PR adds diagrams & descriptions of t... | 2021-11-30T23:16:48Z | Improve documentation of `OmnisciOnNative` execution
The improved documentation should contain:
1. Description & diagram of the query flow.
2. Description & diagram of the data ingress.
P.S. description of the data egress is questionable since there's no implementation for this in Omnisci backend and so it just us... | [
{
"body": "The improved documentation should contain:\r\n1. Description & diagram of the query flow.\r\n2. Description & diagram of the data ingress.\r\n\r\nP.S. description of the data egress is questionable since there's no implementation for this in Omnisci backend and so it just uses pandas.",
"number":... | a4ed72744eee864ce74b374931520e9dba8d3816 | {
"head_commit": "a3c09321dcc20e6da7fcc826185c53b62990f5d6",
"head_commit_message": "Remove separate 'omnisci_engine' page\n\nSigned-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>",
"patch_to_review": "diff --git a/docs/flow/modin/experimental/core/execution/native/implementations/omnisci_on_native/index.rst... | [
{
"diff_hunk": "@@ -1,7 +1,237 @@\n :orphan:\n \n+OmniSciOnNative execution\n+=========================\n+\n+OmniSciDB is an open-source SQL-based relational database designed for the\n+massive parallelism of modern CPU and GPU hardware. Its execution engine\n+is built on LLVM JIT compiler.\n+\n+OmniSciDB can b... | 9b018581749cb4a6621de34bfd111d6ff757da1c | diff --git a/docs/flow/modin/experimental/core/execution/native/implementations/omnisci_on_native/index.rst b/docs/flow/modin/experimental/core/execution/native/implementations/omnisci_on_native/index.rst
index 8b9d77c7413..24c1a8ab6d7 100644
--- a/docs/flow/modin/experimental/core/execution/native/implementations/omni... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Documentation Updates"
} | |
modin-project__modin-3864@5bab3f4 | modin-project/modin | Python | 3,864 | DOCS-#3863: Add usage guide to documentation | Signed-off-by: Igoshev, Yaroslav <yaroslav.igoshev@intel.com>
<!--
Thank you for your contribution!
Please review the contributing docs: https://modin.readthedocs.io/en/latest/CONTRIBUTING.html
if you have questions about contributing.
-->
## What do these changes do?
<!-- Please give a short brief about t... | 2021-12-16T18:03:50Z | Add usage guide to documentation
Our documentation is growing and put everything onto start page probably doesn't look good. We want to add comprehensive examples, which show Modin usage, performance against pandas, etc., as well as some optimization notes regarding improving/accelerating a generic query pipeline (like... | [
{
"body": "Our documentation is growing and put everything onto start page probably doesn't look good. We want to add comprehensive examples, which show Modin usage, performance against pandas, etc., as well as some optimization notes regarding improving/accelerating a generic query pipeline (like put less NPar... | 4b70725e1d13f0b3e21f6037e9797eca117b7d1b | {
"head_commit": "5bab3f47fcaf5542051cef8deefa765f9a4d0680",
"head_commit_message": "DOCS-#3863: Add usage guide to documentaion\n\nSigned-off-by: Igoshev, Yaroslav <yaroslav.igoshev@intel.com>",
"patch_to_review": "diff --git a/docs/index.rst b/docs/index.rst\nindex a5f0e8066bf..c45ac4f4da0 100644\n--- a/docs/in... | [
{
"diff_hunk": "@@ -0,0 +1,58 @@\n+Optimization Guide\n+==================\n+\n+Here you can find information on Modin optimizations both for general query pipeline and for specific operations.\n+\n+Generic settings\n+\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\n+\n+If you are working with a wide DataFrame and performing ... | 27c04e4aaf149e10a5db8862cecbe7991530f12b | diff --git a/docs/development/architecture.rst b/docs/development/architecture.rst
index a194f9bce10..b0d81eddc44 100644
--- a/docs/development/architecture.rst
+++ b/docs/development/architecture.rst
@@ -354,4 +354,4 @@ details. The documentation covers most modules, with more docs being added every
.. _issue: https:... | {
"difficulty": "medium",
"estimated_review_effort": 2,
"problem_domain": "Documentation Updates"
} | |
modin-project__modin-3651@8621ce0 | modin-project/modin | Python | 3,651 | DOCS-#3650: Add optional onboarding instructions and s/onboarding/contributing. | Signed-off-by: mvashishtha <mahesh@ponder.io>
## What do these changes do?
- Move "onboarding" to "contributing".
- Add instructions to:
- A pre-commit hook requiring flake8 to pass before making any commit.
- Make VSCode format code with black on save.
- Reference the new "contributing" doc in the ... | 2021-11-03T21:20:59Z | Add optional development environment steps to onboarding instructions.
I found the following to be helpful:
- A pre-commit hook requiring flake8 to pass before making any commit.
- Making VSCode format my code with black on save.
I can get a Python Debugger to work in VSCode for personal debug scripts, but not f... | [
{
"body": "I found the following to be helpful:\r\n\r\n- A pre-commit hook requiring flake8 to pass before making any commit.\r\n- Making VSCode format my code with black on save.\r\n\r\nI can get a Python Debugger to work in VSCode for personal debug scripts, but not for pytest unit tests, so I won't add instr... | 7ab2d909d1ad42dd0b9d550e2b4e78fd03abf863 | {
"head_commit": "8621ce0e4fa3b2c43de358a034e537106347e897",
"head_commit_message": "Fix the link to contributing instructions.\n\nSigned-off-by: mvashishtha <mahesh@ponder.io>",
"patch_to_review": "diff --git a/onboarding/clone_my_modin.png b/contributing/clone_my_modin.png\nsimilarity index 100%\nrename from on... | [
{
"diff_hunk": "@@ -76,3 +76,16 @@ you should reopen your terminal to find \"(base)\" next to your prompt:  to your Modin account. Your commi... | 8fb211a946dbbec37b06232a7848338e538af73d | diff --git a/onboarding/clone_my_modin.png b/contributing/clone_my_modin.png
similarity index 100%
rename from onboarding/clone_my_modin.png
rename to contributing/clone_my_modin.png
diff --git a/onboarding/clone_upstream_modin.png b/contributing/clone_upstream_modin.png
similarity index 100%
rename from onboarding/clo... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Documentation Updates"
} | |
modin-project__modin-3694@bf042ca | modin-project/modin | Python | 3,694 | FIX-#3686: optimize `__getitem__` flow of loc/iloc | Signed-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
<!--
Thank you for your contribution!
Please review the contributing docs: https://modin.readthedocs.io/en/latest/CONTRIBUTING.html
if you have questions about contributing.
-->
## What do these changes do?
<!-- Please give a short brief about thes... | 2021-11-16T22:14:11Z | Optimize `__getitem__` flow of `loc/iloc`
Indexing DataFrames using `iloc` and `loc` appears to take a lot of time. Here is the results of our ASV Benchmarks ran on OmniSci backend:
```
DataFrame.loc [30000000, 10]_function 3.37
DataFrame.loc [30000000, 10]_list 11.38
DataFrame.loc [30000000, 10]_slice 3.44
DataFr... | [
{
"body": "Indexing DataFrames using `iloc` and `loc` appears to take a lot of time. Here is the results of our ASV Benchmarks ran on OmniSci backend:\r\n```\r\nDataFrame.loc\t[30000000, 10]_function\t3.37\r\nDataFrame.loc\t[30000000, 10]_list\t11.38\r\nDataFrame.loc\t[30000000, 10]_slice\t3.44\r\nDataFrame.loc... | 045eb9353f234f67e5bf35272ea98aac9c05cdf2 | {
"head_commit": "bf042caf8440b0c5df4c306d8666fc64ce1702e4",
"head_commit_message": "Disable broken 'BaseOnPython' tests\n\nSigned-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>",
"patch_to_review": "diff --git a/modin/core/dataframe/pandas/dataframe/dataframe.py b/modin/core/dataframe/pandas/dataframe/dataf... | [
{
"diff_hunk": "@@ -689,49 +768,82 @@ def _compute_lookup(self, row_loc, col_loc):\n \n Returns\n -------\n- row_lookup : numpy.ndarray\n+ row_lookup : slice(None) if full axis grab, pandas.RangeIndex if repetition is detected, numpy.ndarray otherwise\n List of index la... | e9ba2d5db1d3ca857f6d610ae46d841f70eb8fb4 | diff --git a/modin/core/dataframe/pandas/dataframe/dataframe.py b/modin/core/dataframe/pandas/dataframe/dataframe.py
index 37a482aed07..375759ecb96 100644
--- a/modin/core/dataframe/pandas/dataframe/dataframe.py
+++ b/modin/core/dataframe/pandas/dataframe/dataframe.py
@@ -954,7 +954,12 @@ def _get_dict_of_block_index(s... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Performance Optimizations"
} | |
modin-project__modin-3631@58d26c5 | modin-project/modin | Python | 3,631 | FIX-#3619: Fix ValueError when doing loc on empty dataframe | Signed-off-by: Naren Krishna <naren@ponder.io>
<!--
Thank you for your contribution!
Please review the contributing docs: https://modin.readthedocs.io/en/latest/CONTRIBUTING.html
if you have questions about contributing.
-->
## What do these changes do?
<!-- Please give a short brief about these changes. -... | 2021-10-29T18:49:03Z | "ValueError: Invalid integer data type 'f'." when doing `loc` on empty dataframe
We currently default to pandas when we're operating on empty dataframes, but this doesn't happen for some properties. `loc` will fail if you try to use it on an empty dataframe.
Reproduction script:
```python
import modin.pandas as ... | [
{
"body": "We currently default to pandas when we're operating on empty dataframes, but this doesn't happen for some properties. `loc` will fail if you try to use it on an empty dataframe.\r\n\r\nReproduction script:\r\n\r\n```python\r\nimport modin.pandas as pd\r\nimport ray\r\nimport pandas_market_calendars a... | 8acad95ed2dea2c7671d6dc3518d4b0b12c8b682 | {
"head_commit": "58d26c5a80a6f08086d07c71a3b9e13ccd2db580",
"head_commit_message": "add for iloc\n\nSigned-off-by: Naren Krishna <naren@ponder.io>",
"patch_to_review": "diff --git a/modin/pandas/indexing.py b/modin/pandas/indexing.py\nindex aab9469b5f9..d5057e7bf13 100644\n--- a/modin/pandas/indexing.py\n+++ b/m... | [
{
"diff_hunk": "@@ -528,6 +528,8 @@ def __getitem__(self, key):\n else:\n result_slice = self.df.columns.slice_locs(col_loc.start, col_loc.stop)\n return self.df.iloc[:, slice(*result_slice)]\n+ if self.df.empty:\n+ return self.df._default_to_pandas(... | b0d0e8ad123c6c2ac25a5b46f845abd3a8564eda | diff --git a/modin/pandas/indexing.py b/modin/pandas/indexing.py
index aab9469b5f9..3f96e0e656f 100644
--- a/modin/pandas/indexing.py
+++ b/modin/pandas/indexing.py
@@ -514,6 +514,8 @@ def __getitem__(self, key):
--------
pandas.DataFrame.loc
"""
+ if self.df.empty:
+ return... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} | |
modin-project__modin-3575@77413d5 | modin-project/modin | Python | 3,575 | FIX-#3551: fix hanging behaviour for to_csv | Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
<!--
Thank you for your contribution!
Please review the contributing docs: https://modin.readthedocs.io/en/latest/CONTRIBUTING.html
if you have questions about contributing.
-->
## What do these changes do?
<!-- Please give a short brief about thes... | 2021-10-20T08:51:20Z | Modin stuck at to_csv operation
### System information
- **OS Platform and Distribution (e.g., Linux Ubuntu 16.04)**: macOS Big sur, also tested on WSL with windows 10
- **Modin version** (`modin.__version__`): 0.10.2
- **Python version**: Python 3.8.11
- **Code we can use to reproduce**:
### Describe the probl... | The .to_csv() method works when I force the dataframe to default to pandas by using the private method `DataFrame._to_pandas()`
Hello @mbrhd,
Can you provide a dataframe on which the `to_csv` operation stuck so that I can reproduce the problem for myself? | [
{
"body": "### System information\r\n- **OS Platform and Distribution (e.g., Linux Ubuntu 16.04)**: macOS Big sur, also tested on WSL with windows 10\r\n- **Modin version** (`modin.__version__`): 0.10.2\r\n- **Python version**: Python 3.8.11\r\n- **Code we can use to reproduce**:\r\n\r\n### Describe the problem... | 8d67cd3a467d1eb2262898f6f5e2cf159c27d7b0 | {
"head_commit": "77413d553ff6018b8530fa17b3c6f58e69578f49",
"head_commit_message": "FIX-#3551: address review comments\n\nSigned-off-by: Anatoly Myachev <anatoly.myachev@intel.com>",
"patch_to_review": "diff --git a/modin/core/execution/ray/common/utils.py b/modin/core/execution/ray/common/utils.py\nindex eded55... | [
{
"diff_hunk": "@@ -148,51 +132,50 @@ def func(df, **kw):\n Arguments to pass to ``pandas.to_csv(**kw)`` plus an extra argument\n `partition_idx` serving as chunk index to maintain rows order.\n \"\"\"\n- idx = kw[\"partition_idx\"]\n- _kwargs = ... | da134ff382c748cbeb1a9093e342d6f1dfe33bda | diff --git a/modin/core/execution/ray/common/utils.py b/modin/core/execution/ray/common/utils.py
index eded55e99ee..9737c4e1624 100644
--- a/modin/core/execution/ray/common/utils.py
+++ b/modin/core/execution/ray/common/utils.py
@@ -17,6 +17,9 @@
import sys
import psutil
import warnings
+import asyncio
+
+import ray... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
modin-project__modin-3517@74751da | modin-project/modin | Python | 3,517 | FIX-#3515: Make loc with slice and 1 column return dataframe instead of series | The root cause was that in cases like [this](https://github.com/modin-project/modin/issues/3515#issue-1016462060), _LocIndexer.__getitem__ passed a list of columns instead of a scalar column to df.__get__item [here](https://github.com/modin-project/modin/blob/c2b399a0d69baa519dab67acd715061e93986b22/modin/pandas/indexi... | 2021-10-05T23:20:56Z | `loc` with slice for rows and single column returns dataframe instead of series
### System information
- **OS Platform and Distribution (e.g., Linux Ubuntu 16.04)**: Independent
- **Modin version** (`modin.__version__`): latest
- **Python version**: independent
- **Code we can use to reproduce**:
```python
impo... | [
{
"body": "### System information\r\n- **OS Platform and Distribution (e.g., Linux Ubuntu 16.04)**: Independent\r\n- **Modin version** (`modin.__version__`): latest\r\n- **Python version**: independent\r\n- **Code we can use to reproduce**:\r\n\r\n```python\r\nimport numpy as np\r\nimport modin.pandas as pd\r\n... | 6e38ae4f459660460d07e7d93fe1dda4ad9214cd | {
"head_commit": "74751da2b0c3019a67aa077f8fe819fd41a0ef3b",
"head_commit_message": "FIX-#3515: Make loc with slice and 1 column return dataframe instead of series.\n\nThe root cause was that in cases like [this](https://github.com/modin-project/modin/issues/3515#issue-1016462060), _LocIndexer.__getitem__ passed a ... | [
{
"diff_hunk": "@@ -204,15 +204,11 @@ def _parse_tuple(tup):\n Returns\n -------\n row_loc : list",
"line": null,
"original_line": 206,
"original_start_line": null,
"path": "modin/pandas/indexing.py",
"start_line": null,
"text": "@user1:\n```suggestion\r\n row_loc : scalar... | aa2c4a903c63b5e4f4ad8b162fd4068ae33899da | diff --git a/modin/pandas/indexing.py b/modin/pandas/indexing.py
index 5562cedaf7d..aab9469b5f9 100644
--- a/modin/pandas/indexing.py
+++ b/modin/pandas/indexing.py
@@ -463,16 +463,12 @@ def _parse_row_and_column_locators(self, tup):
Returns
-------
- row_loc : list
- List of row l... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
modin-project__modin-3339@696bef3 | modin-project/modin | Python | 3,339 | FEAT-#3338: Add additional parameters for `from_partitions` | Signed-off-by: Alexey Prutskov <alexey.prutskov@intel.com>
<!--
Thank you for your contribution!
Please review the contributing docs: https://modin.readthedocs.io/en/latest/CONTRIBUTING.html
if you have questions about contributing.
-->
## What do these changes do?
<!-- Please give a short brief about thes... | 2021-08-13T11:57:01Z | Expand parameters support of `modin.distributed.dataframe.pandas.from_partitions`
Currently, function `modin.distributed.dataframe.pandas.from_partitions` supports only `partitions` and `axis` parameters. We can avoid internal blocking calls by adding additional optional `index`, `columns`, `row_lengths` and `column_wi... | [
{
"body": "Currently, function `modin.distributed.dataframe.pandas.from_partitions` supports only `partitions` and `axis` parameters. We can avoid internal blocking calls by adding additional optional `index`, `columns`, `row_lengths` and `column_widths` parameters, which can be useful for user in case he has t... | f74eec3b2c807d13721d367f62ee3ba18dcd0ba7 | {
"head_commit": "696bef3cfd0237ce7135d5944455f3b651cbfb13",
"head_commit_message": "FEAT-#3338: Fix pydoc check\n\nSigned-off-by: Alexey Prutskov <alexey.prutskov@intel.com>",
"patch_to_review": "diff --git a/modin/distributed/dataframe/pandas/partitions.py b/modin/distributed/dataframe/pandas/partitions.py\nind... | [
{
"diff_hunk": "@@ -158,9 +175,20 @@ def from_partitions(partitions, axis):\n raise ValueError(\n f\"Got unacceptable value of axis {axis}. Possible values are {0}, {1} or {None}.\"\n )\n+ if index is None:\n+ index = partition_mgr_class.get_indices(0, parts, lambda df: df.... | b5ca7f699cee5e860c638050a398a2d48507572e | diff --git a/modin/distributed/dataframe/pandas/partitions.py b/modin/distributed/dataframe/pandas/partitions.py
index 1bd9ebbde9b..c5e26a59731 100644
--- a/modin/distributed/dataframe/pandas/partitions.py
+++ b/modin/distributed/dataframe/pandas/partitions.py
@@ -89,7 +89,9 @@ def _unwrap_partitions(oid):
]
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
modin-project__modin-3399@1360622 | modin-project/modin | Python | 3,399 | Improve containerized benchmark examples | <!--
Thank you for your contribution!
Please review the contributing docs: https://modin.readthedocs.io/en/latest/CONTRIBUTING.html
if you have questions about contributing.
-->
## What do these changes do?
<!-- Please give a short brief about these changes. -->
- [x] commit message follows format outlined... | 2021-09-03T01:27:29Z | Problems with current modin docker examples
1. Executable scripts build*.sh are not executable.
2. If HTTP(S) proxy is used during build, environment variables remain to be set in the container image. If this image is uploaded to a Docker Hub, and is used by someone else, they will get proxy settings that were used du... | [
{
"body": "1. Executable scripts build*.sh are not executable.\r\n2. If HTTP(S) proxy is used during build, environment variables remain to be set in the container image. If this image is uploaded to a Docker Hub, and is used by someone else, they will get proxy settings that were used during build. These proxy... | 04a0bae73891767b9b113e9caffdd5510278e59d | {
"head_commit": "13606229b38e7ced3d5fa6fb88c0e6645f33e7b6",
"head_commit_message": "FIX-#3392: Cosmetic changes to long lines formatting\n\nSigned-off-by: Gregory Shimansky <gregory.shimansky@intel.com>",
"patch_to_review": "diff --git a/examples/docker/build.sh b/examples/docker/build.sh\ndeleted file mode 1007... | [
{
"diff_hunk": "@@ -0,0 +1,78 @@\n+# Licensed to Modin Development Team under one or more contributor license agreements.\n+# See the NOTICE file distributed with this work for additional information regarding\n+# copyright ownership. The Modin Development Team licenses this file to you under the\n+# Apache Li... | 24aa552dd4c84f8bb4859389c28e147beee41d06 | diff --git a/examples/docker/build.sh b/examples/docker/build.sh
deleted file mode 100755
index 77b29a844d6..00000000000
--- a/examples/docker/build.sh
+++ /dev/null
@@ -1,19 +0,0 @@
-#!/bin/bash -e
-
-# Licensed to Modin Development Team under one or more contributor license agreements.
-# See the NOTICE file distribu... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Code Refactoring / Architectural Improvement"
} | |
modin-project__modin-3592@394b77b | modin-project/modin | Python | 3,592 | FIX-#3376: fix handling of groupby-dict aggregation of 'by' cols | Signed-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
<!--
Thank you for your contribution!
Please review the contributing docs: https://modin.readthedocs.io/en/latest/CONTRIBUTING.html
if you have questions about contributing.
-->
## What do these changes do?
Previously, there was no ability to selec... | 2021-10-22T13:07:12Z | Groupby dictionary aggregation works incorrect in cases when 'by' and columns to aggregate has intersection
### System information
- **OS Platform and Distribution (e.g., Linux Ubuntu 16.04)**:
Ubuntu 20.04.3 LTS
- **Modin version** (`modin.__version__`):
0.10.2+2.g253ecd98.dirty
- **Python version**:
P... | @gshimansky at the reduce phase "by" columns are supposed to be presented only as index levels of the `df`, however, there are some corner cases, that produces the `df` frame which has "by" located at the `df` columns and at the index levels at the same time. The following code cleans up the frame from such duplication... | [
{
"body": "### System information\r\n- **OS Platform and Distribution (e.g., Linux Ubuntu 16.04)**:\r\n\r\nUbuntu 20.04.3 LTS\r\n\r\n- **Modin version** (`modin.__version__`):\r\n\r\n0.10.2+2.g253ecd98.dirty\r\n\r\n- **Python version**:\r\n\r\nPython 3.8.6\r\n\r\n- **Code we can use to reproduce**:\r\n\r\n```py... | 72a3e51aeeae3465a1a3076d962aef95af689dde | {
"head_commit": "394b77b53149b61439b301a8eb2300b83cf9ce94",
"head_commit_message": "Clarify in-code comments\n\nSigned-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>",
"patch_to_review": "diff --git a/modin/core/dataframe/algebra/default2pandas/groupby.py b/modin/core/dataframe/algebra/default2pandas/groupb... | [
{
"diff_hunk": "@@ -270,6 +293,172 @@ def build_groupby(cls, func):\n return cls.build_aggregate_method(func)\n return cls.build_groupby_reduce_method(func)\n \n+ @staticmethod\n+ def handle_as_index(\n+ result_cols,\n+ result_index_names,\n+ internal_by_cols,\n+ ... | 4e4b05b24c9fbc7f0b57acef669560c8db3893a6 | diff --git a/modin/core/dataframe/algebra/default2pandas/groupby.py b/modin/core/dataframe/algebra/default2pandas/groupby.py
index 4999283e18f..6c4b595c0b6 100644
--- a/modin/core/dataframe/algebra/default2pandas/groupby.py
+++ b/modin/core/dataframe/algebra/default2pandas/groupby.py
@@ -16,6 +16,7 @@
from .default im... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
modin-project__modin-3309@06b1fb9 | modin-project/modin | Python | 3,309 | DOCS-#3097: Add section regarding installation from conda-forge | Signed-off-by: izamyati <igor.zamyatin@intel.com>
<!--
Thank you for your contribution!
Please review the contributing docs: https://modin.readthedocs.io/en/latest/CONTRIBUTING.html
if you have questions about contributing.
-->
## What do these changes do?
<!-- Please give a short brief about these changes... | 2021-08-04T08:39:42Z | Specify Differentiation Between Different Modin Installs
On Modin documentation, for all different installs (conda, pip, conda modin[ray], conda-forge, etc.(r, ensure user knows what backends/dependencies are supporting. i.e. For AI Kit Modin, ensure user knows OmniSci backend and Ray are uincluded, but not Dask. This ... | [
{
"body": "On Modin documentation, for all different installs (conda, pip, conda modin[ray], conda-forge, etc.(r, ensure user knows what backends/dependencies are supporting. i.e. For AI Kit Modin, ensure user knows OmniSci backend and Ray are uincluded, but not Dask. This way, users are aware of what underlyin... | 1e03b4f3d0ff1d5e417f47c93be18e9f29315443 | {
"head_commit": "06b1fb918a1619729a11ddddd7c0e04d864c21df",
"head_commit_message": "DOCS-#3097: Fix review comments\n\nSigned-off-by: izamyati <igor.zamyatin@intel.com>",
"patch_to_review": "diff --git a/docs/installation.rst b/docs/installation.rst\nindex a89783fb930..299e83f4495 100644\n--- a/docs/installation... | [
{
"diff_hunk": "@@ -53,6 +53,44 @@ or for different functionalities of Modin. Here is a list of dependency sets for\n \n pip install \"modin[dask]\" # If you want to use the Dask backend\n \n+Installing with conda\n+---------------------\n+\n+Modin releases can be installed using ``Miniconda`` from conda-forg... | f7238aeced848d126cab231f5e8a3c667f8ee3a4 | diff --git a/docs/installation.rst b/docs/installation.rst
index a89783fb930..c9bc70a7f4f 100644
--- a/docs/installation.rst
+++ b/docs/installation.rst
@@ -2,9 +2,9 @@ Installation
============
There are a couple of ways to install Modin. Most users will want to install with
-``pip``, but some users may want to bu... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "New Feature Additions"
} | |
modin-project__modin-3332@add9113 | modin-project/modin | Python | 3,332 | Moving the `xfail` in the `test_io` file from the test code to the decorator | ## What do these changes do?
<!-- Please give a short brief about these changes. -->
- [X] commit message follows format outlined [here](https://modin.readthedocs.io/en/latest/contributing.html)
- [X] passes `flake8 modin`
- [X] passes `black --check modin`
- [X] signed commit with `git commit -s` <!-- you can... | 2021-08-09T15:23:44Z | Some marked as xfail tests pass in "cloud" mode
### System information
- **OS Platform and Distribution (e.g., Linux Ubuntu 16.04)**: Windows 10
- **Modin version** (`modin.__version__`): 0.10.0
- **Python version**: 3.8.10 64-bit
### Describe the problem
There are tests that are marked as xfail in the `"modin i... | I have found that it's possible to transfer in-function `xfail` with check to decorator form, to get proper `xpass` errors if tests are actually passing (which some of them really do now).
Example diff is below:
```diff
diff --git a/modin/pandas/test/test_io.py b/modin/pandas/test/test_io.py
index 33924218..b53... | [
{
"body": "### System information\r\n- **OS Platform and Distribution (e.g., Linux Ubuntu 16.04)**: Windows 10\r\n- **Modin version** (`modin.__version__`): 0.10.0\r\n- **Python version**: 3.8.10 64-bit\r\n\r\n### Describe the problem\r\nThere are tests that are marked as xfail in the `\"modin in the cloud\"` m... | ecf2a44bb7cf8cd0976e1eee6728274684364ae3 | {
"head_commit": "add91132abb8e528b10c0188b86474928347db28",
"head_commit_message": "REFACTOR-#3295: Update reference in issue\n\nSigned-off-by: aleksandr.lozovskii <aleksandr.lozovskii@intel.com>",
"patch_to_review": "diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml\nindex 7d5985c9490..24bde19abd... | [
{
"diff_hunk": "@@ -2056,6 +2132,10 @@ def test_read_pickle(self):\n finally:\n teardown_test_files([unique_filename])\n \n+ @pytest.mark.xfail(\n+ condition=\"config.getoption('--simulate-cloud').lower() != 'off'\",\n+ reason=\"There is no point in reading from local files.... | affb11034016c8303ccec07a507170e6ea5c20a3 | diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 7d5985c9490..24bde19abda 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -558,7 +558,7 @@ jobs:
conda info
conda list
- shell: bash -l {0}
- run: python -m pytest --simulate-cloud=normal mo... | {
"difficulty": "low",
"estimated_review_effort": 3,
"problem_domain": "Test Suite / CI Enhancements"
} |
modin-project__modin-3324@b417a84 | modin-project/modin | Python | 3,324 | DOCS-#3322: Specify proper OS versions for which installation packages are available | Signed-off-by: izamyati <igor.zamyatin@intel.com>
<!--
Thank you for your contribution!
Please review the contributing docs: https://modin.readthedocs.io/en/latest/CONTRIBUTING.html
if you have questions about contributing.
-->
## What do these changes do?
Update info about OSs where modin is available in do... | 2021-08-06T12:02:45Z | Specify proper OS versions for which installation packages are available
### System information
- **OS Platform and Distribution (e.g., Linux Ubuntu 16.04)**:
- **Modin version** (`modin.__version__`):
- **Python version**:
- **Code we can use to reproduce**:
<!--
You can obtain the Modin version with
python... | [
{
"body": "### System information\r\n- **OS Platform and Distribution (e.g., Linux Ubuntu 16.04)**:\r\n- **Modin version** (`modin.__version__`):\r\n- **Python version**:\r\n- **Code we can use to reproduce**:\r\n\r\n<!--\r\nYou can obtain the Modin version with\r\n\r\npython -c \"import modin; print(modin.__ve... | a762913068166c6e59502a50d41a51e449daab16 | {
"head_commit": "b417a8470358907a7ff39069db5058c61a8bae91",
"head_commit_message": "DOCS-#3322: Specify proper OS versions for which installation packages are available\n\nSigned-off-by: izamyati <igor.zamyatin@intel.com>",
"patch_to_review": "diff --git a/docs/installation.rst b/docs/installation.rst\nindex 90d... | [
{
"diff_hunk": "@@ -62,19 +62,19 @@ Using conda-forge channel\n Modin releases can be installed using ``conda`` from conda-forge channel. Starting from 0.10.1\n it is possible to install modin with chosen engine(s) alongside. Current options are:\n \n-+---------------------------------+-------------------------... | 1c9752c38266b0d527b5ba4e127a92a387d52e5e | diff --git a/docs/installation.rst b/docs/installation.rst
index 90d89f84870..df5ed75e85e 100644
--- a/docs/installation.rst
+++ b/docs/installation.rst
@@ -1,7 +1,7 @@
Installation
============
-There are a couple of ways to install Modin. Most users will want to install with
+There are several ways to install Mod... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "Documentation Updates"
} | |
modin-project__modin-3244@df65f9a | modin-project/modin | Python | 3,244 | FEAT-#3243: Add async execution support for Modin xgb.predict | <!--
Thank you for your contribution!
Please review the contributing docs: https://modin.readthedocs.io/en/latest/CONTRIBUTING.html
if you have questions about contributing.
-->
## What do these changes do?
PR adds to Modin xgb.predict the next:
1. async execution support;
2. change approach from Ray actors... | 2021-07-15T12:59:08Z | Add asynchronous execution support in Modin xgboost.predict
### Describe the problem
Current implementation of `predict` in Modin XGBoost can be improved by the next ways:
1. Exclude force partitions redistribution between nodes in Ray cluster.
2. Add asynchronous execution support by excluding blocking calls duri... | [
{
"body": "### Describe the problem\r\nCurrent implementation of `predict` in Modin XGBoost can be improved by the next ways:\r\n\r\n1. Exclude force partitions redistribution between nodes in Ray cluster.\r\n2. Add asynchronous execution support by excluding blocking calls during execution.\r\n\r\n",
"numb... | 7631defe1a8575935f6f557934399286fd737b57 | {
"head_commit": "df65f9aa9ef36277e1fc33960285d7479e20a11d",
"head_commit_message": "FEAT-#3243: Apply part of review comments\n\nSigned-off-by: Alexey Prutskov <alexey.prutskov@intel.com>",
"patch_to_review": "diff --git a/docs/flow/modin/experimental/xgboost.rst b/docs/flow/modin/experimental/xgboost.rst\nindex... | [
{
"diff_hunk": "@@ -58,54 +59,46 @@ internal implementation is the following:\n ..\n \n 2. On this step, the parameter `num_actors` is processed. The internal function :py:func:`~modin.experimental.xgboost.xgboost_ray._get_num_actors`\n- examines the value provided by the user and checks if it fits in the ... | 2d01b105218559fa5b681878789c820eab76927d | diff --git a/docs/flow/modin/experimental/xgboost.rst b/docs/flow/modin/experimental/xgboost.rst
index 658b81e55a4..765fb822677 100644
--- a/docs/flow/modin/experimental/xgboost.rst
+++ b/docs/flow/modin/experimental/xgboost.rst
@@ -27,15 +27,13 @@ row partitions using the function :py:func:`~modin.distributed.datafram... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
modin-project__modin-3220@0bbb577 | modin-project/modin | Python | 3,220 | FIX-#3203: Fix hanging of Modin XGBoost | Signed-off-by: Alexey Prutskov <alexey.prutskov@intel.com>
<!--
Thank you for your contribution!
Please review the contributing docs: https://modin.readthedocs.io/en/latest/CONTRIBUTING.html
if you have questions about contributing.
-->
## What do these changes do?
<!-- Please give a short brief about thes... | 2021-07-07T13:52:48Z | Modin XGBoost hangs
### Describe the problem
<!-- Describe the problem clearly here. -->
ModinXGBoostActors claims all cluster resources. Pending internal tasks can't start and warning message is raised:
```bash
2021-06-25 08:37:46,124 WARNING worker.py:1114 -- The actor or task with ID 46766c5b0167bafaffffffffff... | [
{
"body": "### Describe the problem\r\n<!-- Describe the problem clearly here. -->\r\nModinXGBoostActors claims all cluster resources. Pending internal tasks can't start and warning message is raised:\r\n\r\n```bash\r\n2021-06-25 08:37:46,124 WARNING worker.py:1114 -- The actor or task with ID 46766c5b0167bafaf... | 54898ef78e83209fba3233606841ca988e531aee | {
"head_commit": "0bbb57773e200eaa9d94f4d326ada1cb0310f1e9",
"head_commit_message": "FIX-#3203: Remove superfluous changes\n\nSigned-off-by: Alexey Prutskov <alexey.prutskov@intel.com>",
"patch_to_review": "diff --git a/modin/experimental/xgboost/xgboost_ray.py b/modin/experimental/xgboost/xgboost_ray.py\nindex 7... | [
{
"diff_hunk": "@@ -352,14 +326,22 @@ def create_actors(num_actors):\n Pair of actors list and placement group of actors.\n \"\"\"\n num_cpus_per_actor = _get_cpus_per_actor(num_actors)\n- pg = _create_placement_group(num_cpus_per_actor, num_actors)\n+ nodes_ips = [\n+ key for key, ... | 1ad41075bc4cd83dd387f449a6eb177079e062fe | diff --git a/modin/experimental/xgboost/xgboost_ray.py b/modin/experimental/xgboost/xgboost_ray.py
index 77b7276e9fc..59edb293ef2 100644
--- a/modin/experimental/xgboost/xgboost_ray.py
+++ b/modin/experimental/xgboost/xgboost_ray.py
@@ -27,7 +27,6 @@
import xgboost as xgb
import ray
from ray.services import get_node... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
modin-project__modin-3134@0b38111 | modin-project/modin | Python | 3,134 | Fix case when Index column named 'Unnamed:' after reading DataFrame via read_csv | <!--
Thank you for your contribution!
Please review the contributing docs: https://modin.readthedocs.io/en/latest/CONTRIBUTING.html
if you have questions about contributing.
-->
## What do these changes do?
<!-- Please give a short brief about these changes. -->
- [x] commit message follows format outlined... | 2021-06-08T10:53:30Z | Index column named 'Unnamed: 0' on `.to_csv()` after reading DataFrame with `.read_csv()`
### System information
- **OS Platform and Distribution (e.g., Linux Ubuntu 16.04)**: Ubuntu 20.10
- **Modin version** (`modin.__version__`): 0.9.1
- **Python version**: 3.7.4
- **Code we can use to reproduce**:
```
import n... | Thanks @julibeg for the report!
cc @anmyachev
Some details.
After creating `df2` by the constructor, `df2` has 1 partition:
```python
a b c
i1 0 1 2
i2 3 4 5
i3 6 7 8
i4 9 10 11
```
After creating `df2_re` by `read_csv`, `df2_re` has 2 partitions:
```python
(Pdb) df2_re._quer... | [
{
"body": "### System information\r\n- **OS Platform and Distribution (e.g., Linux Ubuntu 16.04)**: Ubuntu 20.10\r\n- **Modin version** (`modin.__version__`): 0.9.1\r\n- **Python version**: 3.7.4\r\n- **Code we can use to reproduce**:\r\n```\r\nimport numpy as np\r\nimport pandas as pd\r\nimport os\r\nos.enviro... | b58663bd8f2c8802bb45d7bafa2cc65ae988f959 | {
"head_commit": "0b3811180607cdd1e249f51a2996c53c972debb2",
"head_commit_message": "FIX-#3119: handle files with BOM\n\nSigned-off-by: Alexander Myskov <alexander.myskov@intel.com>",
"patch_to_review": "diff --git a/modin/backends/pandas/parsers.py b/modin/backends/pandas/parsers.py\nindex cb9d4185d86..56f9a16f6... | [
{
"diff_hunk": "@@ -220,13 +202,16 @@ def _read_csv_check_support(\n if skiprows is not None and not isinstance(skiprows, int):\n return False\n \n+ # can't pickle dialect object to the worker process\n+ if read_csv_kwargs.get(\"dialect\", None) is not None:\n+ retur... | c427ad7e57c80598b2840e025a2bbd087e6d54a2 | diff --git a/modin/backends/pandas/parsers.py b/modin/backends/pandas/parsers.py
index cb9d4185d86..56f9a16f670 100644
--- a/modin/backends/pandas/parsers.py
+++ b/modin/backends/pandas/parsers.py
@@ -210,16 +210,22 @@ def parse(fname, **kwargs):
num_splits = kwargs.pop("num_splits", None)
start = kwa... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
modin-project__modin-3149@6768f54 | modin-project/modin | Python | 3,149 | FEAT-#3042: support concat via join | <!--
Thank you for your contribution!
Please review the contributing docs: https://modin.readthedocs.io/en/latest/CONTRIBUTING.html
if you have questions about contributing.
-->
## What do these changes do?
Add support for `concat` operation requiring a join operation in the OmniSci engine.
<!-- Please giv... | 2021-06-15T16:49:26Z | [OmniSci] concat requiring join is not supported yet
Reproducer for `NotImplementedError: concat requiring join is not supported yet` error:
```python
from time import time
import numpy as np
from modin.pandas import DataFrame
df1 = DataFrame(np.random.randint(10, size=(5000, 5000)), columns=[f"col{x}" for x... | Same error exist for join operation: `df1.join(df2, how="left", lsuffix="left_", sort=False)._query_compiler._modin_frame._execute()`
We have two problems here. Firstly, `NotImplementedError` shouldn't be visible to users. In this case, the front-end directly calls `concat` in its `merge`/`join` implementation, and IIR... | [
{
"body": "Reproducer for `NotImplementedError: concat requiring join is not supported yet` error:\r\n```python\r\n\r\nfrom time import time\r\n\r\nimport numpy as np\r\nfrom modin.pandas import DataFrame\r\n\r\ndf1 = DataFrame(np.random.randint(10, size=(5000, 5000)), columns=[f\"col{x}\" for x in range(5000)]... | f9c99c3817d35f7bf0d91df9aa9644545ea27517 | {
"head_commit": "6768f541d33cb24c681cf5563a3dae06564da8f8",
"head_commit_message": "FEAT-#3042: fix index name handling\n\nSigned-off-by: ienkovich <ilya.enkovich@intel.com>",
"patch_to_review": "diff --git a/modin/experimental/backends/omnisci/query_compiler.py b/modin/experimental/backends/omnisci/query_compil... | [
{
"diff_hunk": "@@ -1030,32 +1087,38 @@ def value_counts(df, cols, dropna, sort, ascending, **kwargs):\n \n class TestMerge:\n data = {\n- \"a\": [1, 2, 3],\n- \"b\": [10, 20, 30],\n- \"e\": [11, 22, 33],\n+ \"a\": [1, 2, 3, 6, 5, 4],\n+ \"b\": [10, 20, 30, 60, 50, 40],\n+... | 2cf997f7aea891800ca8bfe6d4972b9aabc79e94 | diff --git a/modin/experimental/backends/omnisci/query_compiler.py b/modin/experimental/backends/omnisci/query_compiler.py
index a0bf0fe0bdd..7ff24cd29f1 100644
--- a/modin/experimental/backends/omnisci/query_compiler.py
+++ b/modin/experimental/backends/omnisci/query_compiler.py
@@ -142,7 +142,10 @@ def merge(self, ri... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
modin-project__modin-3062@74a1cb8 | modin-project/modin | Python | 3,062 | Converted docker example images to use dataset outside of container image | <!--
Thank you for your contribution!
Please review the contributing docs: https://modin.readthedocs.io/en/latest/CONTRIBUTING.html
if you have questions about contributing.
-->
## What do these changes do?
<!-- Please give a short brief about these changes. -->
- [x] commit message follows format outlined... | 2021-05-12T21:39:07Z | Convert docker container examples to use external data files instead of packing them inside
**Is your feature request related to a problem? Please describe.**
A clear and concise description of what the problem is. What kind of performance improvements would you like to see with this new API?
Currently we build exa... | [
{
"body": "**Is your feature request related to a problem? Please describe.**\r\nA clear and concise description of what the problem is. What kind of performance improvements would you like to see with this new API?\r\n\r\nCurrently we build example docker containers by packing datasets inside of container imag... | e4fa1409d6ee048dcdcafc092a10bdc90d965303 | {
"head_commit": "74a1cb8abfaa66c859ae0193b2324d7beb7d4518",
"head_commit_message": "FIX-#3061: Converted plastic example to use external dataset\n\nSigned-off-by: Gregory Shimansky <gregory.shimansky@intel.com>",
"patch_to_review": "diff --git a/examples/docker/census-on-omnisci/build-docker-image.sh b/examples/... | [
{
"diff_hunk": "@@ -49,21 +46,12 @@ RUN conda update -n base -c defaults conda -y && \\\n conda config --set channel_priority strict && \\\n conda create -n modin --yes --no-default-packages && \\\n conda activate modin && \\\n- conda install -c intel/label/modin -c conda-forge \"numpy<1.20.0\" o... | dd9e0d6ba2261f1870466d97049d55e9e52fe6a1 | diff --git a/examples/docker/census-on-omnisci/build-docker-image.sh b/examples/docker/census-on-omnisci/build-docker-image.sh
index f4dcb266365..7b3e04d61cc 100644
--- a/examples/docker/census-on-omnisci/build-docker-image.sh
+++ b/examples/docker/census-on-omnisci/build-docker-image.sh
@@ -13,13 +13,13 @@
# ANY KIND... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
modin-project__modin-3156@7c84105 | modin-project/modin | Python | 3,156 | FIX-#3151: Fix default size of Ray obj store memory | Signed-off-by: Alexey Prutskov <alexey.prutskov@intel.com>
<!--
Thank you for your contribution!
Please review the contributing docs: https://modin.readthedocs.io/en/latest/CONTRIBUTING.html
if you have questions about contributing.
-->
## What do these changes do?
<!-- Please give a short brief about thes... | 2021-06-16T10:03:23Z | `ValueError` during initialization of Ray 1.4 in Modin
### System information
- **OS Platform and Distribution (e.g., Linux Ubuntu 16.04)**: Linux Ubuntu
- **Modin version** (`modin.__version__`): 0.10.0
- **Python version**: 3.8.10
- **Code we can use to reproduce**:
```python
import modin.pandas as pd
df = ... | Ray verifies object-store size and raises such exception when [`plasma_directory` is not specified](https://github.com/ray-project/ray/blob/90805d302f5950244f346f55d253b926f1b5504f/python/ray/_private/services.py#L1751), in this case, ray assumes `/dev/shm` to be the default plasma directory (on Linux) and compares spe... | [
{
"body": "### System information\r\n- **OS Platform and Distribution (e.g., Linux Ubuntu 16.04)**: Linux Ubuntu\r\n- **Modin version** (`modin.__version__`): 0.10.0\r\n- **Python version**: 3.8.10\r\n- **Code we can use to reproduce**:\r\n\r\n```python\r\nimport modin.pandas as pd\r\ndf = pd.DataFrame([0])\r\... | b8dd3b2f1a1b416d425ecfe49227fefbe1774505 | {
"head_commit": "7c84105f34feb3cf50721e4482c9f35f6c9a787f",
"head_commit_message": "FIX-#3151: Revert default size for win platform\n\nSigned-off-by: Alexey Prutskov <alexey.prutskov@intel.com>",
"patch_to_review": "diff --git a/modin/engines/ray/utils.py b/modin/engines/ray/utils.py\nindex 060d464b42d..f9e23187... | [
{
"diff_hunk": "@@ -136,7 +136,11 @@ def initialize_ray(\n # In case anything failed above, we can still improve the memory for Modin.\n if object_store_memory is None:\n # Round down to the nearest Gigabyte.\n- system_memory = ray._private.utils.get_system... | d9a9f22e03279ac8fe424887458efafa2e13dd06 | diff --git a/modin/engines/ray/utils.py b/modin/engines/ray/utils.py
index 060d464b42d..501eaaa922b 100644
--- a/modin/engines/ray/utils.py
+++ b/modin/engines/ray/utils.py
@@ -15,6 +15,8 @@
import os
import sys
+import psutil
+import warnings
from modin.config import (
Backend,
@@ -135,9 +137,24 @@ def ini... | {
"difficulty": "low",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
modin-project__modin-3032@a6ac0ad | modin-project/modin | Python | 3,032 | FIX-#3031: Added -n 2 to long running pytest tasks and paralellized windows tasks | Signed-off-by: Gregory Shimansky <gregory.shimansky@intel.com>
<!--
Thank you for your contribution!
Please review the contributing docs: https://modin.readthedocs.io/en/latest/CONTRIBUTING.html
if you have questions about contributing.
-->
## What do these changes do?
<!-- Please give a short brief about ... | 2021-04-28T21:57:13Z | Improve CI performance with xdist pytests
**Is your feature request related to a problem? Please describe.**
A clear and concise description of what the problem is. What kind of performance improvements would you like to see with this new API?
All tests currently executed on GitHub Actions work in single process. T... | Windows on Ray tests fail because of Ray bug https://github.com/ray-project/ray/issues/13213 | [
{
"body": "**Is your feature request related to a problem? Please describe.**\r\nA clear and concise description of what the problem is. What kind of performance improvements would you like to see with this new API?\r\n\r\nAll tests currently executed on GitHub Actions work in single process. This is not optima... | 80754f072f1139e9fe81409a64bf09b0a9ac33a0 | {
"head_commit": "a6ac0adcc0a0ee9abf6de8957b85d6dc9d94a402",
"head_commit_message": "FIX-#3031: Removed xdist for test_concat\n\nSigned-off-by: Gregory Shimansky <gregory.shimansky@intel.com>",
"patch_to_review": "diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml\nindex 72e8ce86199..9a8901b0c8a 100... | [
{
"diff_hunk": "@@ -45,7 +45,7 @@ jobs:\n with:\n python-version: \"3.7.x\"\n architecture: \"x64\"\n- - run: pip install pytest pytest-cov pydocstyle numpydoc\n+ - run: pip install pytest pytest-cov pytest-xdist pydocstyle numpydoc",
"line": null,
"original_line": ... | 47038435a27db59cf27817c3f7fcd3948ab04867 | diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 72e8ce86199..4dceca6cf5e 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -219,11 +219,14 @@ jobs:
- shell: bash -l {0}
run: python -m pytest modin/test/test_envvar_npartitions.py
- shell: bash -l {0}
- ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Test Suite / CI Enhancements"
} |
modin-project__modin-2948@da4d797 | modin-project/modin | Python | 2,948 | DOCS-#2940: add documentation for asv | Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
<!--
Thank you for your contribution!
Please review the contributing docs: https://modin.readthedocs.io/en/latest/CONTRIBUTING.html
if you have questions about contributing.
-->
## What do these changes do?
<!-- Please give a short brief about thes... | 2021-03-30T14:28:13Z | Document asv bench and CI
This should document what we do in asv benchmarking, how we produce the results (and steps for any 3rd party to reproduce the measurements).
It should also document everything about how we run CI on GitHub and TeamCity | [
{
"body": "This should document what we do in asv benchmarking, how we produce the results (and steps for any 3rd party to reproduce the measurements).\r\n\r\nIt should also document everything about how we run CI on GitHub and TeamCity",
"number": 2940,
"title": "Document asv bench and CI"
}
] | 763b05ccb1841c3bec8e9f7e3df276c4ef8b35c6 | {
"head_commit": "da4d79710e4f03617f0e08f61f678b32083e3880",
"head_commit_message": "DOCS-#2940: add function level docstrings\n\nSigned-off-by: Anatoly Myachev <anatoly.myachev@intel.com>",
"patch_to_review": "diff --git a/asv_bench/README.md b/asv_bench/README.md\nnew file mode 100644\nindex 00000000000..5f914e... | [
{
"diff_hunk": "@@ -0,0 +1,87 @@\n+# Modin ASV benchmarks\n+\n+## Here are some scenarios in which [ASV](https://asv.readthedocs.io/en/stable/index.html) can be used:\n+\n+* It is necessary to check the impact of the new patch on the performance of a certain set of operations:\n+\n+ `asv continuous -f 1.05 src... | bb563d1ccbddffced28959f43a6d5b965da5551e | diff --git a/asv_bench/README.md b/asv_bench/README.md
new file mode 100644
index 00000000000..f58e0f0e872
--- /dev/null
+++ b/asv_bench/README.md
@@ -0,0 +1,90 @@
+# Modin ASV benchmarks
+
+## Here are some scenarios in which [ASV](https://asv.readthedocs.io/en/stable/index.html) can be used:
+
+* Check the impact of ... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "Documentation Updates"
} | |
modin-project__modin-2919@60a70fb | modin-project/modin | Python | 2,919 | REFACTOR-#2918: Refactor internal functionality of partitions | Signed-off-by: Igoshev, Yaroslav <yaroslav.igoshev@intel.com>
<!--
Thank you for your contribution!
Please review the contributing docs: https://modin.readthedocs.io/en/latest/CONTRIBUTING.html
if you have questions about contributing.
-->
## What do these changes do?
<!-- Please give a short brief about t... | 2021-03-24T07:55:27Z | Refactor internal functionality of partitions
We can do the following things:
1) Get rid of passing `ray.ObjectRef(s)` within a list to a partition's `apply` (and to a remote call then) to avoid explicit call `ray.get`.
2) Add preprocessing a function for dask engine as it is done for ray engine. | [
{
"body": "We can do the following things:\r\n1) Get rid of passing `ray.ObjectRef(s)` within a list to a partition's `apply` (and to a remote call then) to avoid explicit call `ray.get`.\r\n2) Add preprocessing a function for dask engine as it is done for ray engine.\r\n",
"number": 2918,
"title": "Ref... | f9c99c3817d35f7bf0d91df9aa9644545ea27517 | {
"head_commit": "60a70fb72a7792778a6376450818372ba63a2b46",
"head_commit_message": "REFACTOR-#2918: Add comments\n\nSigned-off-by: Igoshev, Yaroslav <yaroslav.igoshev@intel.com>",
"patch_to_review": "diff --git a/modin/engines/base/frame/partition.py b/modin/engines/base/frame/partition.py\nindex 4dff475c19a..40... | [
{
"diff_hunk": "@@ -151,30 +104,20 @@ def broadcast_apply(cls, axis, apply_func, left, right, other_name=\"r\"):\n NumPy array of result partition objects.\n \"\"\"\n \n- def mapper(df, others):\n+ def map_func(df, *others):\n other = pandas.concat(others, axis=axis... | 1bea29f683babd1cc1de48d8212e134f0c2cff86 | diff --git a/modin/engines/base/frame/partition.py b/modin/engines/base/frame/partition.py
index 4dff475c19a..403374b4fcd 100644
--- a/modin/engines/base/frame/partition.py
+++ b/modin/engines/base/frame/partition.py
@@ -44,7 +44,7 @@ def get(self):
"""
pass
- def apply(self, func, **kwargs):
+ ... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Code Refactoring / Architectural Improvement"
} | |
modin-project__modin-2801@64caea0 | modin-project/modin | Python | 2,801 | FEAT-#2800: add wait_computations, wait apis | Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
<!--
Thank you for your contribution!
Please review the contributing docs: https://modin.readthedocs.io/en/latest/CONTRIBUTING.html
if you have questions about contributing.
-->
## What do these changes do?
<!-- Please give a short brief about thes... | 2021-03-03T11:08:15Z | Add wait function for _modin_frame
**Is your feature request related to a problem? Please describe.**
A clear and concise description of what the problem is. What kind of performance improvements would you like to see with this new API?
This is the most lightweight way to wait for the end of parallel computations o... | [
{
"body": "**Is your feature request related to a problem? Please describe.**\r\nA clear and concise description of what the problem is. What kind of performance improvements would you like to see with this new API?\r\n\r\nThis is the most lightweight way to wait for the end of parallel computations on partitio... | 3f0e39e382fac347240b3c081ade066dc2d6dc38 | {
"head_commit": "64caea03247c413aca7cb86a7867b2255060d502",
"head_commit_message": "FEAT-#2800: correct use of map in asv benchs\n\nSigned-off-by: Anatoly Myachev <anatoly.myachev@intel.com>",
"patch_to_review": "diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml\nindex 492971b43b8..c1a03ece786 100... | [
{
"diff_hunk": "@@ -555,6 +555,14 @@ def to_pandas(cls, partitions):\n else:\n return cls.concatenate(df_rows)\n \n+ @classmethod\n+ def wait_computations(cls, partitions):",
"line": null,
"original_line": 559,
"original_start_line": null,
"path": "modin/engines/base/fr... | 1495b8c620182735ccff766192cd197f6d5a6266 | diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 492971b43b8..33883ed284c 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -285,6 +285,8 @@ jobs:
conda list
- name: Install HDF5
run: sudo apt update && sudo apt install -y libhdf5-dev
+ - shell... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
modin-project__modin-2587@f59d3fc | modin-project/modin | Python | 2,587 | Fixed MultiIndex.from_frame implementation | <!--
Thank you for your contribution!
Please review the contributing docs: https://modin.readthedocs.io/en/latest/CONTRIBUTING.html
if you have questions about contributing.
-->
## What do these changes do?
<!-- Please give a short brief about these changes. -->
- [x] commit message follows format outlined... | 2021-01-08T22:28:09Z | modin DataFrame does not qualify as DataFrame in pd.MultiIndex.from_frame
### System information
- **OS Platform and Distribution**: Linux Ubuntu 16.04
- **Modin version**: 0.8.2
- **Python version**: 3.8.2
- **Code we can use to reproduce**:
```python
from modin import pandas as pd
df = pd.DataFrame(
[[... | Yes, we currently reuse Pandas class `MultiIndex` as is, and therefore its method `from_frame` expects a Pandas DataFrame type, not Modin. As a temporary workaround you can write `pd.MultiIndex.from_frame(df._to_pandas())` and it should work.
The fix for this can be relatively simple, we can just monkey-patch the `fr... | [
{
"body": "### System information\r\n- **OS Platform and Distribution**: Linux Ubuntu 16.04\r\n- **Modin version**: 0.8.2\r\n- **Python version**: 3.8.2\r\n- **Code we can use to reproduce**:\r\n\r\n```python\r\nfrom modin import pandas as pd\r\ndf = pd.DataFrame(\r\n [[\"bar\", 1], [\"bar\", 2], [\"foo\", ... | bcab1cc903151a7fa52dca7c90730fcf12f04ab7 | {
"head_commit": "f59d3fc40a3b270dd47977e413d39d54b3251531",
"head_commit_message": "FIX-#2575: Patch MultiIndex with out implementation of from_frame\n\nSigned-off-by: Gregory Shimansky <gregory.shimansky@intel.com>",
"patch_to_review": "diff --git a/modin/pandas/test/dataframe/test_indexing.py b/modin/pandas/te... | [
{
"diff_hunk": "@@ -105,3 +107,35 @@ def is_scalar(obj):\n from .base import BasePandasDataset\n \n return not isinstance(obj, BasePandasDataset) and pandas_is_scalar(obj)\n+\n+\n+def from_modin_frame(df, sortorder=None, names=None):\n+ \"\"\"\n+ Make a MultiIndex from a DataFrame.\n+\n+ Parame... | de0faa2e7eae48716aacdb0ca8f0a3e93165dbe8 | diff --git a/modin/pandas/test/dataframe/test_indexing.py b/modin/pandas/test/dataframe/test_indexing.py
index d7201dea7c6..db81111de73 100644
--- a/modin/pandas/test/dataframe/test_indexing.py
+++ b/modin/pandas/test/dataframe/test_indexing.py
@@ -1325,3 +1325,17 @@ def test_index_order():
getattr(df_modi... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
modin-project__modin-2643@259eb3e | modin-project/modin | Python | 2,643 | REFACTOR-#2642: Refactor partition API | Signed-off-by: Igoshev, Yaroslav <yaroslav.igoshev@intel.com>
<!--
Thank you for your contribution!
Please review the contributing docs: https://modin.readthedocs.io/en/latest/CONTRIBUTING.html
if you have questions about contributing.
-->
## What do these changes do?
<!-- Please give a short brief about t... | 2021-01-25T07:35:13Z | Refactor partition API
### Describe the problem
<!-- Describe the problem clearly here. -->
For Modin on Ray engine with pandas backend IPs of the remote partitions may not match actual locations if the partitions are lower than 100 kB. Ray saves such objects (<= 100 kB, by default) in in-process store of the calli... | [
{
"body": "### Describe the problem\r\n<!-- Describe the problem clearly here. -->\r\n\r\nFor Modin on Ray engine with pandas backend IPs of the remote partitions may not match actual locations if the partitions are lower than 100 kB. Ray saves such objects (<= 100 kB, by default) in in-process store of the cal... | 07f1cc79931bb94b1836cdbbe423a86cf6feafa2 | {
"head_commit": "259eb3e52a8f25f6db75313242b60547503ca09a",
"head_commit_message": "REFACTOR-#2642: Apply comment; Use apply instead of new func\n\nSigned-off-by: Igoshev, Yaroslav <yaroslav.igoshev@intel.com>",
"patch_to_review": "diff --git a/modin/config/envvars.py b/modin/config/envvars.py\nindex 245619273ef... | [
{
"diff_hunk": "@@ -95,33 +95,33 @@ def shuffle(self, func, lengths, **kwargs):\n def _wrap_partitions(self, partitions):\n return [self.partition_type(obj) for obj in partitions]\n \n- def coalesce(self, bind_ip=False):\n+ def coalesce(self, get_ip=False):",
"line": null,
"original_li... | bee1738160d306e55695e31d2cf7e2e3353f7ef9 | diff --git a/docs/developer/pandas/partition_api.rst b/docs/developer/pandas/partition_api.rst
new file mode 100644
index 00000000000..212c7fc46c8
--- /dev/null
+++ b/docs/developer/pandas/partition_api.rst
@@ -0,0 +1,68 @@
+Partition API in Modin
+======================
+
+When you are working with a Modin Dataframe, ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Code Refactoring / Architectural Improvement"
} | |
modin-project__modin-2515@c9b97d3 | modin-project/modin | Python | 2,515 | FEAT-#2342: Add axis partitions API | <!--
Thank you for your contribution!
Please review the contributing docs: https://modin.readthedocs.io/en/latest/CONTRIBUTING.html
if you have questions about contributing.
-->
## What do these changes do?
<!-- Please give a short brief about these changes. -->
- [x] commit message follows format outlined... | 2020-12-07T08:13:37Z | Row Partition API
**Is your feature request related to a problem? Please describe.**
A clear and concise description of what the problem is. What kind of performance improvements would you like to see with this new API?
I'd like to be able to obtain a list of row partitions from a distributed Modin dataframe.
Th... | Thanks @richardliaw for the request!
We should consider a developer API for cases like this that enable access to Modin internal partitions without needing to dig into them. I have been thinking about this some.
Design can look something like this:
```python
from modin.developer.partitioning import extract_ro... | [
{
"body": "**Is your feature request related to a problem? Please describe.**\r\nA clear and concise description of what the problem is. What kind of performance improvements would you like to see with this new API?\r\n\r\nI'd like to be able to obtain a list of row partitions from a distributed Modin dataframe... | ff9bdbf7ddd218fb00994e7add5c2be6d5a56f34 | {
"head_commit": "c9b97d387cb9200b0317d80482d0f6b8b478da78",
"head_commit_message": "FEAT-#2342: Move to common function of partitions unwrapping\n\nSigned-off-by: Igoshev, Yaroslav <yaroslav.igoshev@intel.com>",
"patch_to_review": "diff --git a/modin/api/__init__.py b/modin/api/__init__.py\nnew file mode 100644\... | [
{
"diff_hunk": "@@ -0,0 +1,75 @@\n+# Licensed to Modin Development Team under one or more contributor license agreements.\n+# See the NOTICE file distributed with this work for additional information regarding\n+# copyright ownership. The Modin Development Team licenses this file to you under the\n+# Apache Li... | 856e18f4a9e3d7c19cec3d0016557e79dd2a25b2 | diff --git a/modin/api/__init__.py b/modin/api/__init__.py
new file mode 100644
index 00000000000..ae69fb73221
--- /dev/null
+++ b/modin/api/__init__.py
@@ -0,0 +1,16 @@
+# Licensed to Modin Development Team under one or more contributor license agreements.
+# See the NOTICE file distributed with this work for addition... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
modin-project__modin-2523@b565fdc | modin-project/modin | Python | 2,523 | TEST-#2509: Io tests refactoring | <!--
Thank you for your contribution!
Please review the contributing docs: https://modin.readthedocs.io/en/latest/CONTRIBUTING.html
if you have questions about contributing.
-->
## What do these changes do?
This PR refactors IO tests in order to unify source code, group similar tests in classes and capability t... | 2020-12-08T16:12:07Z | IO tests refactoring
**Is your feature request related to a problem? Please describe.**
A clear and concise description of what the problem is. What kind of performance improvements would you like to see with this new API?
Entire IO test (`modin/pandas/test/test_io.py`) should be refactored in order to combine simila... | Draft PR containing grouped refactored tests that can be ran in parallel was created. After some optimizations and fixing some bugs PR will be ready for review. | [
{
"body": "**Is your feature request related to a problem? Please describe.**\r\nA clear and concise description of what the problem is. What kind of performance improvements would you like to see with this new API?\r\nEntire IO test (`modin/pandas/test/test_io.py`) should be refactored in order to combine simi... | 1a8cd0a3765df4cd9f76480e9862f522818333b2 | {
"head_commit": "b565fdc843b10db723962b5fef99c5d10c732d7f",
"head_commit_message": "TEST-#2509: fix\n\nSigned-off-by: Alexander Myskov <alexander.myskov@intel.com>",
"patch_to_review": "diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml\nindex 127a36bacef..7d707ea29b9 100644\n--- a/.github/workflow... | [
{
"diff_hunk": "@@ -1102,1229 +1054,1120 @@ def test_read_csv_internal(\n **kwargs,\n )\n \n+ # Issue related, specific or corner cases\n+ @pytest.mark.parametrize(\"nrows\", [2, None])\n+ def test_read_csv_bad_quotes(self, nrows):\n+ csv_bad_quotes = (\n+ ... | e4c43c41ed6166ff1b842b3f0af963898b30b793 | diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 127a36bacef..7d707ea29b9 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -496,7 +496,7 @@ jobs:
conda info
conda list
- shell: bash -l {0}
- run: python -m pytest --simulate-cloud=normal mo... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Code Refactoring / Architectural Improvement"
} |
modin-project__modin-2226@f08756f | modin-project/modin | Python | 2,226 | FIX-#2225: update parameters of ray APIs for cloud features | Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
<!--
Thank you for your contribution!
Please review the contributing docs: https://modin.readthedocs.io/en/latest/contributing.html
if you have questions about contributing.
-->
## What do these changes do?
<!-- Please give a short brief about the... | 2020-10-09T13:25:24Z | Update ray API used for cloud features after pin ray>=1.0.0
### System information
- **OS Platform and Distribution (e.g., Linux Ubuntu 16.04)**:
- **Modin version** (`modin.__version__`): `0.8.1.1`
- **Python version**:
- **Code we can use to reproduce**:
<!--
You can obtain the Modin version with
python -c... | Also add unit tests for the problem. | [
{
"body": "### System information\r\n- **OS Platform and Distribution (e.g., Linux Ubuntu 16.04)**:\r\n- **Modin version** (`modin.__version__`): `0.8.1.1`\r\n- **Python version**:\r\n- **Code we can use to reproduce**:\r\n\r\n<!--\r\nYou can obtain the Modin version with\r\n\r\npython -c \"import modin; print(... | 499fc96cd2d50441dbf376fec84d52828c6b6700 | {
"head_commit": "f08756f251a509e2848ebfeb93c729797c7881f5",
"head_commit_message": "FIX-#2225: use pytest.fixture to create mock objects\n\nSigned-off-by: Anatoly Myachev <anatoly.myachev@intel.com>",
"patch_to_review": "diff --git a/modin/experimental/cloud/rayscale.py b/modin/experimental/cloud/rayscale.py\nin... | [
{
"diff_hunk": "@@ -14,8 +14,111 @@\n import unittest.mock as mock\n import pytest\n from collections import namedtuple\n+from inspect import signature\n from modin.experimental.cloud.rayscale import RayCluster\n from modin.experimental.cloud.cluster import Provider\n+from ray.autoscaler.commands import (\n+ ... | b6537c0d588d13f170f8b6d310305650ef715378 | diff --git a/modin/experimental/cloud/rayscale.py b/modin/experimental/cloud/rayscale.py
index 84d80165a84..6530ac365ec 100644
--- a/modin/experimental/cloud/rayscale.py
+++ b/modin/experimental/cloud/rayscale.py
@@ -200,9 +200,8 @@ def __do_spawn(self):
yes=True,
override_cluster_name... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Dependency Updates & Env Compatibility"
} |
modin-project__modin-2153@7b44309 | modin-project/modin | Python | 2,153 | FEAT-#2138: sync modin version between local and remote contexts | Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
<!--
Thank you for your contribution!
Please review the contributing docs: https://modin.readthedocs.io/en/latest/contributing.html
if you have questions about contributing.
-->
## What do these changes do?
<!-- Please give a short brief about the... | 2020-09-25T08:48:03Z | Sync modin version between local and remote contexts
**Is your feature request related to a problem? Please describe.**
A clear and concise description of what the problem is. What kind of performance improvements would you like to see with this new API? | [
{
"body": "**Is your feature request related to a problem? Please describe.**\r\nA clear and concise description of what the problem is. What kind of performance improvements would you like to see with this new API?\r\n",
"number": 2138,
"title": "Sync modin version between local and remote contexts"
... | c1b7a3ba26feafcfc0d965451228b992b23387b7 | {
"head_commit": "7b44309a2e4c4f9cbac3c94c4ed79e00aca747bc",
"head_commit_message": "FEAT-#2138: fix\n\nSigned-off-by: Anatoly Myachev <anatoly.myachev@intel.com>",
"patch_to_review": "diff --git a/modin/experimental/cloud/ray-autoscaler.yml b/modin/experimental/cloud/ray-autoscaler.yml\nindex 0d022578ae1..52d907... | [
{
"diff_hunk": "@@ -158,17 +160,108 @@ def _conda_requirements(self):\n return reqs_with_quotes\n \n def _update_conda_requirements(self, setup_commands: str):\n- return setup_commands.replace(\n+ setup_commands = setup_commands.replace(\n \"{{CONDA_PACKAGES}}\", \" \".join... | cf46c3fd9f61580546d045105d27767abcf9b415 | diff --git a/modin/experimental/cloud/ray-autoscaler.yml b/modin/experimental/cloud/ray-autoscaler.yml
index 0d022578ae1..7507c5325f5 100644
--- a/modin/experimental/cloud/ray-autoscaler.yml
+++ b/modin/experimental/cloud/ray-autoscaler.yml
@@ -120,7 +120,7 @@ setup_commands:
source ~/.bashrc
conda cr... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Dependency Updates & Env Compatibility"
} | |
modin-project__modin-2270@9aab768 | modin-project/modin | Python | 2,270 | FIX-#1976: indices matching at reduction functions fixed | Signed-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
<!--
Thank you for your contribution!
Please review the contributing docs: https://modin.readthedocs.io/en/latest/contributing.html
if you have questions about contributing.
-->
## What do these changes do?
<!-- Please give a short brief about the... | 2020-10-19T12:45:17Z | Reduction functions doesn't work correctly if `numeric_only!=False`
<!--
General questions should be asked on the mailing list modin-dev@googlegroups.com.
Before submitting an issue, please fill out the following form.
-->
### System information
- **OS Platform and Distribution (e.g., Linux Ubuntu 16.04)**: `W... | The same problem with `prod` method.
Just change `.sum` -> `.prod` in reproducer.
Maybe #1960 will fix this.
Looks like the issue is related to repr method. | [
{
"body": "<!--\r\nGeneral questions should be asked on the mailing list modin-dev@googlegroups.com.\r\n\r\nBefore submitting an issue, please fill out the following form.\r\n-->\r\n\r\n### System information\r\n- **OS Platform and Distribution (e.g., Linux Ubuntu 16.04)**: `Windows 10`\r\n- **Modin installed f... | 6697e05531621a9b3b0209fb6ee8292fed54bd79 | {
"head_commit": "9aab7681a20bb4f49b5ca5f9e469f0faf159a945",
"head_commit_message": "FIX-#1976: 'value_counts' bug fixing\n\nSigned-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>",
"patch_to_review": "diff --git a/modin/backends/pandas/query_compiler.py b/modin/backends/pandas/query_compiler.py\nindex c8c7ca... | [
{
"diff_hunk": "@@ -375,3 +353,16 @@ def test_sum_single_column(data):\n pandas_df = pandas.DataFrame(data).iloc[:, [0]]\n df_equals(modin_df.sum(), pandas_df.sum())\n df_equals(modin_df.sum(axis=1), pandas_df.sum(axis=1))\n+\n+\n+@pytest.mark.parametrize(\n+ \"fn\", [\"max\", \"min\", \"median\"... | 71681b7c2c50c3925cc92a4842a361aeda76c472 | diff --git a/modin/backends/pandas/query_compiler.py b/modin/backends/pandas/query_compiler.py
index c8c7ca4c72f..b4082db158c 100644
--- a/modin/backends/pandas/query_compiler.py
+++ b/modin/backends/pandas/query_compiler.py
@@ -22,12 +22,15 @@
is_scalar,
)
from pandas.core.base import DataError
+from typing imp... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
modin-project__modin-2149@2679b20 | modin-project/modin | Python | 2,149 | FIX-#2148: add note about braceexpand for cloud examples | Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
<!--
Thank you for your contribution!
Please review the contributing docs: https://modin.readthedocs.io/en/latest/contributing.html
if you have questions about contributing.
-->
## What do these changes do?
<!-- Please give a short brief about the... | 2020-09-24T19:29:07Z | Add note about braceexpand for cloud examples.
### System information
- **OS Platform and Distribution (e.g., Linux Ubuntu 16.04)**:
- **Modin version** (`modin.__version__`):
- **Python version**:
- **Code we can use to reproduce**:
<!--
You can obtain the Modin version with
python -c "import modin; print(m... | [
{
"body": "### System information\r\n- **OS Platform and Distribution (e.g., Linux Ubuntu 16.04)**:\r\n- **Modin version** (`modin.__version__`):\r\n- **Python version**:\r\n- **Code we can use to reproduce**:\r\n\r\n<!--\r\nYou can obtain the Modin version with\r\n\r\npython -c \"import modin; print(modin.__ve... | c21351c553d500da53787852563766782ff0cebf | {
"head_commit": "2679b20b088326d75f2116f30e1986a9e438e620",
"head_commit_message": "FIX-#2148: add note about braceexpand for cloud examples\n\nSigned-off-by: Anatoly Myachev <anatoly.myachev@intel.com>",
"patch_to_review": "diff --git a/examples/cluster/h2o-runner.py b/examples/cluster/h2o-runner.py\nindex 56bf... | [
{
"diff_hunk": "@@ -13,6 +13,7 @@\n \n \n # pip install git+https://github.com/intel-go/ibis.git@develop",
"line": null,
"original_line": 15,
"original_start_line": null,
"path": "examples/cluster/h2o-runner.py",
"start_line": null,
"text": "@author:\nI also need to change intel-go repo ... | b6136a689298ee0be38fa2f228204858ecc092a8 | diff --git a/examples/cluster/h2o-runner.py b/examples/cluster/h2o-runner.py
index 56bffcfe5e2..eb5fbbef7bc 100644
--- a/examples/cluster/h2o-runner.py
+++ b/examples/cluster/h2o-runner.py
@@ -12,9 +12,10 @@
# governing permissions and limitations under the License.
-# pip install git+https://github.com/intel-go/i... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "Documentation Updates"
} | |
modin-project__modin-2146@88a9324 | modin-project/modin | Python | 2,146 | FIX-#2147: return interval for python micro version - *.*.X | Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
<!--
Thank you for your contribution!
Please review the contributing docs: https://modin.readthedocs.io/en/latest/contributing.html
if you have questions about contributing.
-->
## What do these changes do?
For RPyC to work correctly, the micro part... | 2020-09-24T19:12:11Z | "conda install python==3.7.9 -c conda-forge" failed when the cluster is created
### System information
- **OS Platform and Distribution (e.g., Linux Ubuntu 16.04)**:
- **Modin version** (`modin.__version__`):
- **Python version**:
- **Code we can use to reproduce**:
<!--
You can obtain the Modin version with
... | [
{
"body": "### System information\r\n- **OS Platform and Distribution (e.g., Linux Ubuntu 16.04)**:\r\n- **Modin version** (`modin.__version__`):\r\n- **Python version**:\r\n- **Code we can use to reproduce**:\r\n\r\n<!--\r\nYou can obtain the Modin version with\r\n\r\npython -c \"import modin; print(modin.__ve... | fe0afedd051f9aa721d27a63fcb8c67df32d9768 | {
"head_commit": "88a932491820eeaf1bb9894abebb03bb87be28a9",
"head_commit_message": "FIX-#2147: return interval for python micro version - *.*.X\n\nSigned-off-by: Anatoly Myachev <anatoly.myachev@intel.com>",
"patch_to_review": "diff --git a/modin/experimental/cloud/rayscale.py b/modin/experimental/cloud/rayscale... | [
{
"diff_hunk": "@@ -33,7 +33,8 @@ def test_update_conda_requirements(setup_commands_source):\n major = sys.version_info.major\n minor = sys.version_info.minor\n micro = sys.version_info.micro\n- python_version = f\"python=={major}.{minor}.{micro}\"\n+ python_version_lower = f\"python>{major}.{... | 2ba1cbe0e8ab41e6c1c988f4702366182e72caff | diff --git a/modin/experimental/cloud/rayscale.py b/modin/experimental/cloud/rayscale.py
index e17af01fe20..e33b5dcea4b 100644
--- a/modin/experimental/cloud/rayscale.py
+++ b/modin/experimental/cloud/rayscale.py
@@ -146,7 +146,7 @@ def _conda_requirements(self):
reqs = []
- reqs.append(f"python=={s... | {
"difficulty": "medium",
"estimated_review_effort": 2,
"problem_domain": "Dependency Updates & Env Compatibility"
} | |
modin-project__modin-2111@e68899d | modin-project/modin | Python | 2,111 | Fix test_from_csv for simulated remote case | <!--
Thank you for your contribution!
Please review the contributing docs: https://modin.readthedocs.io/en/latest/contributing.html
if you have questions about contributing.
-->
## What do these changes do?
Both adapt local testing to possibility of having a remote proxy (by transferring the proxy by-value as ... | 2020-09-21T13:17:16Z | test_io.py::test_from_csv fails in remote context
### Describe the problem
<!-- Describe the problem clearly here. -->
When running `python -m pytest --simulate-cloud=normal modin\pandas\test\test_io.py::test_from_csv[123]` the following errors happen:
1. Bug in `__array__`
```
make_csv_file = <function make_csv... | [
{
"body": "### Describe the problem\r\n<!-- Describe the problem clearly here. -->\r\nWhen running `python -m pytest --simulate-cloud=normal modin\\pandas\\test\\test_io.py::test_from_csv[123]` the following errors happen:\r\n\r\n1. Bug in `__array__`\r\n```\r\nmake_csv_file = <function make_csv_file.<locals>._... | ca8e7b5955527abbe0c7927febbe29d205d7daff | {
"head_commit": "e68899de23291638ba3647ec5623ecc0264b36ab",
"head_commit_message": "FIX-#2100: pandas testing does not work correctly with remote objects\n\nSigned-off-by: Vasilij Litvinov <vasilij.n.litvinov@intel.com>",
"patch_to_review": "diff --git a/modin/conftest.py b/modin/conftest.py\nindex 909055fcf6b..... | [
{
"diff_hunk": "@@ -185,23 +192,33 @@ def __patched_netref(self, id_pack):\n \n So we're patching RPyC netref __getattribute__ to keep a reference\n for certain read-only properties to better emulate local objects.\n+\n+ Also __array__() implementation works only for numpy arrays, but not... | cb95b9d04ca4f31e97333fb7914b4084fd8120df | diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index b7aac1e6569..e822f1c4d48 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -343,6 +343,40 @@ jobs:
- shell: bash -l {0}
run: bash <(curl -s https://codecov.io/bash)
+ test-cloud:
+ needs: [lint-commit, lin... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} | |
modin-project__modin-1889@c776e3b | modin-project/modin | Python | 1,889 | FIX-#1497: Don't sort in concat() when sort=False | <!--
Thank you for your contribution!
Please review the contributing docs: https://modin.readthedocs.io/en/latest/contributing.html
if you have questions about contributing.
-->
## What do these changes do?
<!-- Please give a short brief about these changes. -->
- [x] commit message follows format outline... | 2020-08-04T18:14:27Z | concat ignores sort argument
### System information
- **OS Platform and Distribution (e.g., Linux Ubuntu 16.04)**: Ubuntu 19.04
- **Modin version** (`modin.__version__`): 0.7.3+52.g880545b
- **Python version**: Python 3.7.3
- **Code we can use to reproduce**:
<!--
You can obtain the Modin version with
python... | I will see if I can fix this. | [
{
"body": "### System information\r\n- **OS Platform and Distribution (e.g., Linux Ubuntu 16.04)**: Ubuntu 19.04\r\n- **Modin version** (`modin.__version__`): 0.7.3+52.g880545b\r\n- **Python version**: Python 3.7.3\r\n- **Code we can use to reproduce**:\r\n\r\n<!--\r\nYou can obtain the Modin version with\r\n\r... | 102be4c9c294796abc657287ed7d1919085838cf | {
"head_commit": "c776e3bc8494ab593e6ed0e4cf0dbe5cd5572740",
"head_commit_message": "FIX-#1497: Assert sort=False is respected.\n\nSigned-off-by: Itamar Turner-Trauring <itamar@itamarst.org>",
"patch_to_review": "diff --git a/modin/engines/base/frame/data.py b/modin/engines/base/frame/data.py\nindex d59fbba5dc8..... | [
{
"diff_hunk": "@@ -896,30 +896,37 @@ def _join_index_objects(self, axis, other_index, how, sort):\n \"\"\"\n Joins a pair of index objects (columns or rows) by a given strategy.\n \n+ Unlike Index.join() in Pandas, if axis is 1, the sort is\n+ False, and how is \"outer\", the resu... | 0f74d6b8cd21548f6c5022aa902c8bc6ec0cc58e | diff --git a/modin/engines/base/frame/data.py b/modin/engines/base/frame/data.py
index d59fbba5dc8..b358a85bd90 100644
--- a/modin/engines/base/frame/data.py
+++ b/modin/engines/base/frame/data.py
@@ -896,6 +896,9 @@ def _join_index_objects(self, axis, other_index, how, sort):
"""
Joins a pair of inde... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
modin-project__modin-1727@d38f7ca | modin-project/modin | Python | 1,727 | [FIX] Fix of inconsistent indices #1726 #1731 #1732 #1734 | <!--
Thank you for your contribution!
Please review the contributing docs: https://modin.readthedocs.io/en/latest/contributing.html
if you have questions about contributing.
-->
## What do these changes do?
<!-- Please give a short brief about these changes. -->
- [x] passes `flake8 modin`
- [x] passes `... | 2020-07-14T13:10:33Z | to_pandas in PandasQueryCompiler loses meta information about indices and columns
### System information
- **OS Platform and Distribution (e.g., Linux Ubuntu 16.04)**: Windows 10
- **Modin version** (`modin.__version__`): 0.7.3+198.ge4e3fecb
- **Python version**: 3.7.5
- **Code we can use to reproduce**:
```python... | I figured out that `to_pandas` does not consider indices and columns from modin_frame at all, only from partitions. For example if modin frame has `columns = ['A', 'B']` but in partitions `columns = [1, 2, 3]` (different columns lengths could appear because of incorrect function implementation) then `to_pandas` will re... | [
{
"body": "### System information\r\n- **OS Platform and Distribution (e.g., Linux Ubuntu 16.04)**: Windows 10\r\n- **Modin version** (`modin.__version__`): 0.7.3+198.ge4e3fecb\r\n- **Python version**: 3.7.5\r\n- **Code we can use to reproduce**:\r\n```python\r\nif __name__ == \"__main__\":\r\n import modin.... | 37b7d2c4c5b3ac04408f362b3989de30dd3df1a2 | {
"head_commit": "d38f7ca1f6de8a11e9994819c11cdd502e0339b2",
"head_commit_message": "FIX-#1726: make to_pandas consider external labels\n\nThis fix is also fixing inconsistent indices in some of operations (#1731, #1732 and #1734)\n\nSigned-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>",
"patch_to_review": ... | [
{
"diff_hunk": "@@ -234,6 +256,74 @@ def _filter_empties(self):\n self._column_widths_cache = [w for w in self._column_widths if w > 0]\n self._row_lengths_cache = [r for r in self._row_lengths if r > 0]\n \n+ def _validate_axis_equality(self, axis: int, update: bool):\n+ \"\"\"\n+ ... | f1729fa5fa8e5855dfb2af81de5e7435984a1b12 | diff --git a/modin/backends/pandas/query_compiler.py b/modin/backends/pandas/query_compiler.py
index 14f12ff1a2c..57ce0f06109 100644
--- a/modin/backends/pandas/query_compiler.py
+++ b/modin/backends/pandas/query_compiler.py
@@ -468,13 +468,13 @@ def transpose(self, *args, **kwargs):
# MapReduce operations
- ... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
modin-project__modin-1623@793eafd | modin-project/modin | Python | 1,623 | Fixed #1412, losing dtypes when constructing DataFrame | <!--
Thank you for your contribution!
Please review the contributing docs: https://modin.readthedocs.io/en/latest/contributing.html
if you have questions about contributing.
-->
## What do these changes do?
<!-- Please give a short brief about these changes. -->
- [x] passes `flake8 modin`
- [x] passes `... | 2020-06-17T12:55:23Z | Incorrect dtype when DataFrame is distributed
### System information
- **OS Platform and Distribution (e.g., Linux Ubuntu 16.04)**:
Windows 10
- **Modin version** (`modin.__version__`):
0.7.2+85.gb9b791f.dirty
- **Python version**:
Python 3.7.7
- **Code we can use to reproduce**:
```python
if __n... | Interesting, it appears that it does not happen when data is loaded with `dtype` kwarg.
There is a bug in DataFrame constructor:
https://github.com/modin-project/modin/blob/4c772ab5a97276709ae9e035ead5198caaa7f2bf/modin/pandas/dataframe.py#L113-L116
That list comprehension expression will return a python `list` with ... | [
{
"body": "### System information\r\n- **OS Platform and Distribution (e.g., Linux Ubuntu 16.04)**:\r\n\r\nWindows 10\r\n\r\n- **Modin version** (`modin.__version__`):\r\n\r\n0.7.2+85.gb9b791f.dirty\r\n\r\n- **Python version**:\r\n\r\nPython 3.7.7\r\n\r\n- **Code we can use to reproduce**:\r\n\r\n```python\r\ni... | 4c772ab5a97276709ae9e035ead5198caaa7f2bf | {
"head_commit": "793eafde558121116ea2692dba423f4643ecbc01",
"head_commit_message": "fix\n\nSigned-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>",
"patch_to_review": "diff --git a/modin/pandas/dataframe.py b/modin/pandas/dataframe.py\nindex ad0a908b4ab..635bcae86e7 100644\n--- a/modin/pandas/dataframe.py\n+... | [
{
"diff_hunk": "@@ -111,9 +111,17 @@ def __init__(\n \"Distributing {} object. This may take some time.\".format(type(data))\n )\n if is_list_like(data) and not is_dict_like(data):\n- data = [\n+ old_dtype = getattr(data, \"dtype\", None)\n+ ... | 7007f8a364777ed0a3e89e4654f1e7b44f876dee | diff --git a/modin/pandas/dataframe.py b/modin/pandas/dataframe.py
index ad0a908b4ab..b1a8b7fe00e 100644
--- a/modin/pandas/dataframe.py
+++ b/modin/pandas/dataframe.py
@@ -111,9 +111,17 @@ def __init__(
"Distributing {} object. This may take some time.".format(type(data))
)
i... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
modin-project__modin-1397@8a4a385 | modin-project/modin | Python | 1,397 | Fix parquet file reading when file was written with pandas Index | * Resolves #1366
* Add a check for the Index columns from the pandas metadata maintained
by parquet.
* Do not assign work for the columns that are actually pandas Index
objects.
* Add tests for this behavior.
Also test for MultiIndex object
Signed-off-by: Devin Petersohn <devin.petersohn@gmail.com>
<!... | 2020-04-24T18:45:29Z | KeyError(f"None of [{key}] are in the [{axis_name}]")
### System information
- **OS Platform and Distribution (e.g., Linux Ubuntu 16.04)**:
- **Modin version** (`modin.__version__`): 0.7.2
- **Python version**: 3.7
- **Code we can use to reproduce**:
```
import pandas as pd
import modin.pandas as mpd
df = pd.... | Hi @jadhosn thanks for the report!
This looks like a bug specific to setting the index, I will dig into this, thanks again for the report!
@devin-petersohn thank you!
In the meantime, which of the following workarounds would you recommend to use to still gain an efficiency boost using modin:
* Write out the origi... | [
{
"body": "### System information\r\n- **OS Platform and Distribution (e.g., Linux Ubuntu 16.04)**:\r\n- **Modin version** (`modin.__version__`): 0.7.2\r\n- **Python version**: 3.7\r\n- **Code we can use to reproduce**:\r\n```\r\nimport pandas as pd\r\nimport modin.pandas as mpd\r\n\r\ndf = pd.DataFrame({'idx':... | 6961c50ead66f6b6def9631459880f212908f727 | {
"head_commit": "8a4a38599b6cf41d02ffd784b34032b9f76edc5f",
"head_commit_message": "Fix parquet file reading when file was written with pandas Index\n\n* Resolves #1366\n* Add a check for the Index columns from the pandas metadata maintained\n by parquet.\n* Do not assign work for the columns that are actually pa... | [
{
"diff_hunk": "@@ -428,6 +428,32 @@ def test_from_parquet_partitioned_columns_with_columns(make_parquet_file):\n df_equals(modin_df, pandas_df)\n \n \n+def test_from_parquet_pandas_index():\n+ # Ensure modin can read parquet files written by pandas with a non-RangeIndex object\n+ pandas_df = pandas.D... | a98909ed48bebc879706831ffe24bae85ad4adae | diff --git a/modin/backends/pandas/parsers.py b/modin/backends/pandas/parsers.py
index caf6ca4b20b..d59716ec436 100644
--- a/modin/backends/pandas/parsers.py
+++ b/modin/backends/pandas/parsers.py
@@ -141,18 +141,21 @@ def parse(fname, **kwargs):
class PandasParquetParser(PandasParser):
@staticmethod
def par... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
modin-project__modin-1684@9ce63bc | modin-project/modin | Python | 1,684 | [FIX] Fix #1683 - losing index names in pd.concat | <!--
Thank you for your contribution!
Please review the contributing docs: https://modin.readthedocs.io/en/latest/contributing.html
if you have questions about contributing.
-->
## What do these changes do?
Fix of #1683: `pd.concat` losing indices names
<!-- Please give a short brief about these changes. -->
... | 2020-07-02T10:24:57Z | pd.concat loses index names with MultiIndex
### System information
- **OS Platform and Distribution (e.g., Linux Ubuntu 16.04)**: Windows 10
- **Modin version** (`modin.__version__`): 0.7.3+170.g7a4b735
- **Python version**: 3.7.5
- **Code we can use to reproduce**:
```python
if __name__ == "__main__":
impor... | [
{
"body": "### System information\r\n- **OS Platform and Distribution (e.g., Linux Ubuntu 16.04)**: Windows 10\r\n- **Modin version** (`modin.__version__`): 0.7.3+170.g7a4b735\r\n- **Python version**: 3.7.5\r\n- **Code we can use to reproduce**:\r\n```python\r\nif __name__ == \"__main__\":\r\n import modin.p... | 1a22a890d6163b6595c7cebe70eff06402b21c77 | {
"head_commit": "9ce63bc6c5df0d705754c40b12116615b153e9fa",
"head_commit_message": "test fix\n\nSigned-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>",
"patch_to_review": "diff --git a/modin/pandas/concat.py b/modin/pandas/concat.py\nindex 0b0a98f4b92..bf226493a12 100644\n--- a/modin/pandas/concat.py\n+++ b... | [
{
"diff_hunk": "@@ -132,3 +139,25 @@ def concat(\n else:\n result_df.columns = new_idx\n return result_df\n+\n+\n+def _determine_name(objs: list, axis):\n+ axis_getter = (lambda df: df.columns) if axis else (lambda df: df.index)\n+ name_getter = (\n+ (lambda df: axis_getter(... | d7d2e670d8aeb0d9939262dff1cb7f19dde0c467 | diff --git a/modin/pandas/concat.py b/modin/pandas/concat.py
index 0b0a98f4b92..38694799663 100644
--- a/modin/pandas/concat.py
+++ b/modin/pandas/concat.py
@@ -12,10 +12,13 @@
# governing permissions and limitations under the License.
import pandas
+import numpy as np
from typing import Hashable, Iterable, Mapp... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
modin-project__modin-1407@9307e58 | modin-project/modin | Python | 1,407 | #1401 move env files to a separate folder | Signed-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
<!--
Thank you for your contribution!
Please review the contributing docs: https://modin.readthedocs.io/en/latest/contributing.html
if you have questions about contributing.
-->
## What do these changes do?
<!-- Please give a short brief about the... | 2020-04-28T17:28:50Z | add `modin/env` folder for files with pip and conda packages
At the moment, we have several environment files that are located in the root of the repository. Example: `df_test_requires.txt`, `env_windows.yml`, `requirements.txt`, `windows_test_requires.txt`.
What do you think about adding a folder for these files?
... | [
{
"body": "At the moment, we have several environment files that are located in the root of the repository. Example: `df_test_requires.txt`, `env_windows.yml`, `requirements.txt`, `windows_test_requires.txt`.\r\n\r\nWhat do you think about adding a folder for these files? \r\n\r\n- This will reduce the semantic... | e08a9a1e3143f1bf3810fb108994914602830858 | {
"head_commit": "9307e581c68953e05653d15f80d20fc17223137a",
"head_commit_message": "docker fix recipie 3",
"patch_to_review": "diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml\nindex 792d06f8f2f..d39dcb224af 100644\n--- a/.github/workflows/ci.yml\n+++ b/.github/workflows/ci.yml\n@@ -39,7 +39,7 @@... | [
{
"diff_hunk": "@@ -1,7 +1,7 @@\n FROM python:3.6.6-stretch\n \n-COPY requirements.txt requirements.txt\n-RUN pip install -r requirements.txt\n+COPY env/requirements.txt requirements.txt",
"line": null,
"original_line": 3,
"original_start_line": null,
"path": "ci/jenkins/performance-tests/Docker... | 5b98488a475af2212da762f6ae11397b1aec8144 | diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 792d06f8f2f..6097a80be64 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -97,7 +97,7 @@ jobs:
with:
python-version: ${{matrix.python-version}}
architecture: "x64"
- - run: pip install -r wi... | {
"difficulty": "low",
"estimated_review_effort": 3,
"problem_domain": "Documentation Updates"
} | |
modin-project__modin-732@68f19bd | modin-project/modin | Python | 732 | Add Dask futures implementation | <!--
Thank you for your contribution!
-->
## What do these changes do?
<!-- Please give a short brief about these changes. -->
## Related issue number
Resolves #657
<!-- Are there any issues opened that will be resolved by merging this change? -->
- [x] passes `flake8 modin`
- [x] passes `black --ch... | 2019-07-15T04:44:49Z | Windows support
Ray does not support Windows. It would be good to publish wheels that don't require Ray for Windows users. This is also related to publishing to conda-forge.
We can add an engine that runs strictly off of Python Multiprocessing for starters. It should be relatively straight-forward to add.
Markin... | Hi @devin-petersohn. I started working on a simply multiprocess engine.
My approach is quite naive. In the partition implementation I simply send the work to a different process. Similar to what Ray does with a remote task.
Had some serialization issues so for now using dill instead of pickle.
I have run it on the ... | [
{
"body": "Ray does not support Windows. It would be good to publish wheels that don't require Ray for Windows users. This is also related to publishing to conda-forge.\r\n\r\nWe can add an engine that runs strictly off of Python Multiprocessing for starters. It should be relatively straight-forward to add.\r\... | 453024764ffdad5000047a4cfaa1e322d9941b6e | {
"head_commit": "68f19bd83355e5632ba091cfd5ee41e52c6533a4",
"head_commit_message": "Upgrade dask versions",
"patch_to_review": "diff --git a/modin/data_management/factories.py b/modin/data_management/factories.py\nindex 0e874b0f506..329b60bf56a 100644\n--- a/modin/data_management/factories.py\n+++ b/modin/data_m... | [
{
"diff_hunk": "@@ -332,6 +332,8 @@ def comparison_inter_ops_helper(self, modin_df, pandas_df, op):\n getattr(modin_df, op)(modin_df)\n else:\n modin_result = getattr(modin_df, op)(modin_df)\n+ print(modin_result)",
"line": null,
"original_line": 335,
"... | 0b95376526ed11191ecc610fc3da3ca6ad75d20f | diff --git a/modin/data_management/factories.py b/modin/data_management/factories.py
index 0e874b0f506..329b60bf56a 100644
--- a/modin/data_management/factories.py
+++ b/modin/data_management/factories.py
@@ -208,7 +208,7 @@ class PandasOnPythonFactory(BaseFactory):
class PandasOnDaskFactory(BaseFactory):
- fro... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
modin-project__modin-689@14e70b8 | modin-project/modin | Python | 689 | Default to pandas when trying to get slice from Series | * Resolves #687
<!--
Thank you for your contribution!
-->
## What do these changes do?
<!-- Please give a short brief about these changes. -->
## Related issue number
<!-- Are there any issues opened that will be resolved by merging this change? -->
- [x] passes `flake8 modin`
- [x] passes `black -... | 2019-06-18T05:00:02Z | Expanding dimension for Series with np.newaxis throws TypeError
### Describe the problem
Expanding dimension for Series with np.newaxis throws TypeError
<!-- Describe the problem clearly here. -->
### Source code / logs
```python
df["col1"][:,np.newaxis]
```
Error:
```
----------------------------... | [
{
"body": "\r\n### Describe the problem\r\n\r\nExpanding dimension for Series with np.newaxis throws TypeError\r\n<!-- Describe the problem clearly here. -->\r\n\r\n### Source code / logs\r\n```python\r\n\r\ndf[\"col1\"][:,np.newaxis]\r\n\r\n```\r\n\r\nError:\r\n```\r\n------------------------------------------... | c9a3b8c2215deca4f2e90f01d6ffa2b78af4c8ac | {
"head_commit": "14e70b811d8de3f6dde2f60a90976c4100a377eb",
"head_commit_message": "Default to pandas when trying to get slice from Series\n\n* Resolves #687",
"patch_to_review": "diff --git a/modin/pandas/series.py b/modin/pandas/series.py\nindex 902307d836d..90dffa30bfe 100644\n--- a/modin/pandas/series.py\n++... | [
{
"diff_hunk": "@@ -168,6 +168,8 @@ def _getitem(self, key):\n pandas.RangeIndex(len(self.index))[key]\n )\n )\n+ if isinstance(key, tuple):",
"line": 172,
"original_line": 171,
"original_start_line": null,
"path": "modin/pandas/series.py",
... | da5bc3220c4dd3967f4fcaa1191b5a82f02f1af1 | diff --git a/modin/pandas/series.py b/modin/pandas/series.py
index 902307d836d..b8891c64103 100644
--- a/modin/pandas/series.py
+++ b/modin/pandas/series.py
@@ -168,6 +168,9 @@ def _getitem(self, key):
pandas.RangeIndex(len(self.index))[key]
)
)
+ # TODO: More e... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} | |
modin-project__modin-635@2a8e5d1 | modin-project/modin | Python | 635 | Support boolean indexers and other properties in `loc` | * Resolves #610
* Adds a fastrack to lists of columns and boolean indexers
<!--
Thank you for your contribution!
-->
## What do these changes do?
<!-- Please give a short brief about these changes. -->
## Related issue number
<!-- Are there any issues opened that will be resolved by merging this chang... | 2019-05-24T07:13:05Z | loc gives incorrect values when given a Boolean indexer
<!--
General questions should be asked on the mailing list modin-dev@googlegroups.com.
Before submitting an issue, please fill out the following form.
-->
### System information
- **OS Platform and Distribution (e.g., Linux Ubuntu 16.04)**: OSX
- **Modin... | Hi Devin, i check and loc does not support boolean and callable, the idea is to fallback or support it?
Thanks @ipacheco-uy, we won't fallback to support this because it would be really expensive.
I outlined a bit of what is needed in a post on the discourse: https://discuss.modin.org/t/indexing-update-rewrite/57... | [
{
"body": "<!--\r\nGeneral questions should be asked on the mailing list modin-dev@googlegroups.com.\r\n\r\nBefore submitting an issue, please fill out the following form.\r\n-->\r\n\r\n### System information\r\n- **OS Platform and Distribution (e.g., Linux Ubuntu 16.04)**: OSX\r\n- **Modin installed from (sour... | 11581d552493c7caf42b25d8af2408b75c008a10 | {
"head_commit": "2a8e5d1b8b2140d82781d58107109f5c94bf0cf7",
"head_commit_message": "Fix transposed getitem",
"patch_to_review": "diff --git a/modin/backends/pandas/query_compiler.py b/modin/backends/pandas/query_compiler.py\nindex 42ce8eabf9e..9c87d36e0b9 100644\n--- a/modin/backends/pandas/query_compiler.py\n++... | [
{
"diff_hunk": "@@ -227,6 +227,16 @@ class _LocIndexer(_LocationIndexerBase):\n \"\"\"A indexer for ray_df.loc[] functionality\"\"\"\n \n def __getitem__(self, key):\n+ # When getting along a single axis,\n+ if not isinstance(key, tuple):\n+ # Try to fasttrack the code through a... | df100bc639cdd3778ce706336295058a47dc06c8 | diff --git a/modin/backends/pandas/query_compiler.py b/modin/backends/pandas/query_compiler.py
index 42ce8eabf9e..96051d03736 100644
--- a/modin/backends/pandas/query_compiler.py
+++ b/modin/backends/pandas/query_compiler.py
@@ -1925,11 +1925,13 @@ def back(self, n):
# End Head/Tail/Front/Back
# __getitem__... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
modin-project__modin-644@66e677f | modin-project/modin | Python | 644 | Fix Parquet reader for partitioned files | <!--
Thank you for your contribution!
-->
## What do these changes do?
* Move `ParquetDataset` functionality to experimental
* Filter columns read in the partitions when there is at least one partition column
<!-- Please give a short brief about these changes. -->
## Related issue number
* Resolves #642
<... | 2019-05-31T05:34:17Z | Running query over a dataframe read by read_parquet errors out with Modin 0.5.1
<!--
General questions should be asked on the mailing list modin-dev@googlegroups.com.
Before submitting an issue, please fill out the following form.
-->
### System information
- **OS Platform and Distribution (e.g., Linux Ubuntu ... | Thanks @ddutt, for the report!
We're looking into the issue, others have reported running into a related issue as well. We will get this fixed as soon as possible.
@ddutt Would you be able to tell me if install this way fixes your issue?
```
pip install git+https://github.com/devin-petersohn/modin/tree/issues/64... | [
{
"body": "<!--\r\nGeneral questions should be asked on the mailing list modin-dev@googlegroups.com.\r\n\r\nBefore submitting an issue, please fill out the following form.\r\n-->\r\n\r\n### System information\r\n- **OS Platform and Distribution (e.g., Linux Ubuntu 16.04)**: Ubuntu 19.04\r\n- **Modin installed f... | de70a11d702389bea670323c47c4c623d42509c0 | {
"head_commit": "66e677f019dc762b1b2032e45a3e60347d1c9819",
"head_commit_message": "fix conflict",
"patch_to_review": "diff --git a/modin/engines/ray/generic/io.py b/modin/engines/ray/generic/io.py\nindex 9ea92769ea7..8d1faf0463a 100644\n--- a/modin/engines/ray/generic/io.py\n+++ b/modin/engines/ray/generic/io.p... | [
{
"diff_hunk": "@@ -157,9 +157,6 @@ def read_parquet(cls, path, engine, columns, **kwargs):\n for (root, dir_names, files) in os.walk(path):\n if dir_names:\n partitioned_columns.add(dir_names[0].split(\"=\")[0])\n- if files:\n- f... | 89404b3f1be1ae41d1e241c7a0469e5c7160295e | diff --git a/modin/engines/ray/generic/io.py b/modin/engines/ray/generic/io.py
index 9ea92769ea7..46449a58144 100644
--- a/modin/engines/ray/generic/io.py
+++ b/modin/engines/ray/generic/io.py
@@ -147,6 +147,7 @@ def read_parquet(cls, path, engine, columns, **kwargs):
if cls.read_parquet_remote_task is None:
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
modin-project__modin-598@376a1b5 | modin-project/modin | Python | 598 | Correctly apply Series functions element-wise for correct cases | * Resolves #597
* Mimic the error handling/cases of pandas
* Add checks for UDFs which use args/kwargs
* Add `str` to the tests for `apply`
* Remove those from `DataFrame.apply` tests because of #469
<!--
Thank you for your contribution!
-->
## What do these changes do?
<!-- Please give a short brief abo... | 2019-04-29T17:24:49Z | Series.apply uses DataFrame.apply logic in incorrect order
<!--
General questions should be asked on the mailing list modin-dev@googlegroups.com.
Before submitting an issue, please fill out the following form.
-->
### System information
- **OS Platform and Distribution (e.g., Linux Ubuntu 16.04)**: OSX
- **Mo... | [
{
"body": "<!--\r\nGeneral questions should be asked on the mailing list modin-dev@googlegroups.com.\r\n\r\nBefore submitting an issue, please fill out the following form.\r\n-->\r\n\r\n### System information\r\n- **OS Platform and Distribution (e.g., Linux Ubuntu 16.04)**: OSX\r\n- **Modin installed from (sour... | 371bc481964c30678ecdcb2076058f3d7aae0548 | {
"head_commit": "376a1b57d4addf37237d807c339f5d72acf143dd",
"head_commit_message": "Correctly apply Series functions element-wise for correct cases\n\n* Resolves #597\n* Mimic the error handling/cases of pandas\n* Add checks for UDFs which use args/kwargs\n* Add `str` to the tests for `apply`\n* Remove those from ... | [
{
"diff_hunk": "@@ -357,12 +358,25 @@ def apply(self, func, convert_dtype=True, args=(), **kwds):\n apply_func = \"agg\"\n else:\n apply_func = \"apply\"\n- # Add this because it only applies for `apply` specifically.\n- kwds[\"convert_dtype\"] = convert_dty... | b4f6743e5b8df9592babfc32913e8298dc7ae004 | diff --git a/modin/pandas/base.py b/modin/pandas/base.py
index 051416f8c84..112851bb6dd 100644
--- a/modin/pandas/base.py
+++ b/modin/pandas/base.py
@@ -299,11 +299,9 @@ def aggregate(self, func, axis=0, *args, **kwargs):
result = self._aggregate(func, _axis=axis, *args, **kwargs)
except ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
pwndbg__pwndbg-3033@64e6d85 | pwndbg/pwndbg | Python | 3,033 | Fix #2614: distance command works with function symbols now | Fixes #2614
| 2025-05-27T21:49:15Z | dist error Cannot convert value to long
### Description
```
pwndbg> dist 0x55555555cbe8 win
╭─────────────────────────────── Traceback (most recent call last) ────────────────────────────────╮
│ ------------------------/pwndbg/pwndbg/dbg/gdb.py:1033 in __int__ │
│ ... | `win` is struct/value, not an address 🤔
I don't know, how to know if you(or user) mean comparing `win` as address, or comparing value from `win`
We should throw under the bus, current `arg` implementation xD
> win is struct/value, not an address 🤔
yeah win is a function. it'd be nice if the `dist` function supp... | [
{
"body": "### Description\r\n\r\n```\r\npwndbg> dist 0x55555555cbe8 win\r\n╭─────────────────────────────── Traceback (most recent call last) ────────────────────────────────╮\r\n│ ------------------------/pwndbg/pwndbg/dbg/gdb.py:1033 in __int__ │\r\n│ ... | 506f89584118e194b0d0f542d26aed36b136ae79 | {
"head_commit": "64e6d85c8ec9d95f6b7cc98d2d4e239236c8afd5",
"head_commit_message": "gdb: suggest &main instead of main (address of symbol) in commands",
"patch_to_review": "diff --git a/pwndbg/commands/__init__.py b/pwndbg/commands/__init__.py\nindex cf9d7d4e797..9eb478d50fb 100644\n--- a/pwndbg/commands/__init_... | [
{
"diff_hunk": "@@ -524,8 +524,15 @@ def fix_int_reraise_arg(arg) -> int:\n fixed = fix_reraise_arg(arg)\n return int(fixed)\n except pwndbg.dbg_mod.Error as e:\n+ try:\n+ address_value = int(fix_reraise_arg(f\"&{arg}\"))\n+ colored_arg = message.notice(f\"&{arg}... | aef5067893a4124c09caad76f410f6b1da1c9597 | diff --git a/pwndbg/commands/distance.py b/pwndbg/commands/distance.py
index 6e8f2212302..abba444154c 100644
--- a/pwndbg/commands/distance.py
+++ b/pwndbg/commands/distance.py
@@ -10,8 +10,10 @@
parser = argparse.ArgumentParser(
description="Print the distance between the two arguments, or print the offset to th... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
pydantic__pydantic-11941@7122174 | pydantic/pydantic | Python | 11,941 | Allow callable discriminator to be applied on PEP 695 type aliases | <!-- Thank you for your contribution! -->
<!-- Unless your change is trivial, please create an issue to discuss the change before creating a PR -->
## Change Summary
Fixes https://github.com/pydantic/pydantic/issues/11930.
<!-- Please give a short summary of the changes. -->
## Related issue number
<!--... | 2025-06-02T10:50:01Z | Tag not extracted from Annotated when using nested named type aliases.
### Initial Checks
- [x] I confirm that I'm using Pydantic V2
### Description
During model construction, pydantic doesn't pull Tags from inner named type alias annotations, but will do it if the entire union is a named type alias, as seen in the ... | [
{
"body": "### Initial Checks\n\n- [x] I confirm that I'm using Pydantic V2\n\n### Description\n\nDuring model construction, pydantic doesn't pull Tags from inner named type alias annotations, but will do it if the entire union is a named type alias, as seen in the example below.\n\nResults in the following err... | 88c75cd5adbfbfea4ff1aceb597c93f238db8dcb | {
"head_commit": "71221744011113713716062b747107935383f440",
"head_commit_message": "Allow callable discriminator to be applied on PEP 695 type aliases",
"patch_to_review": "diff --git a/pydantic/types.py b/pydantic/types.py\nindex b5c4fd6060..1e690fc146 100644\n--- a/pydantic/types.py\n+++ b/pydantic/types.py\n@... | [
{
"diff_hunk": "@@ -3093,10 +3095,23 @@ def _convert_schema(self, original_schema: core_schema.CoreSchema) -> core_schem\n if metadata is not None:\n tag = metadata.get('pydantic_internal_union_tag_key') or tag\n if tag is None:\n- raise PydanticUserError(\... | 7f54ea1ab9b0fc886efee2d547618ffb1caf7973 | diff --git a/pydantic/types.py b/pydantic/types.py
index b5c4fd6060..72a752aa50 100644
--- a/pydantic/types.py
+++ b/pydantic/types.py
@@ -3074,9 +3074,11 @@ def __get_pydantic_core_schema__(self, source_type: Any, handler: GetCoreSchemaH
return handler(Annotated[source_type, Field(discriminator=self.discr... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} | |
pwndbg__pwndbg-2944@cd75a6a | pwndbg/pwndbg | Python | 2,944 | add TLS canary address display | Reopen #2751 with fixes, as original author (@kgand) appears inactive
Fix:
- Corrected usage of `@pwndbg.commands.Command(...)` instead of `@pwndbg.commands.ArgparsedCommand(...)`
- Linting
Closes #2511 | 2025-05-03T02:26:31Z | canary command should show the TLS canary address
```
pwndbg> canary
AT_RANDOM = 0x7fff05b46609 # points to (not masked) global canary value
Canary = 0x989538cda22ba700 (may be incorrect on != glibc)
Thread 1: Found valid canaries.
```
The "points to (not masked) global canary value" is somewhat a lie, becau... | Note the TLS address can probably be fetched via one of fs/fs_base/gs/gs_base register (I don't remember which one :shrug:, I think its FS register) | [
{
"body": "```\r\npwndbg> canary\r\nAT_RANDOM = 0x7fff05b46609 # points to (not masked) global canary value\r\nCanary = 0x989538cda22ba700 (may be incorrect on != glibc)\r\nThread 1: Found valid canaries.\r\n```\r\n\r\nThe \"points to (not masked) global canary value\" is somewhat a lie, because this is poin... | 59e570033ff64d5e842aabac6f231d2f66bdefce | {
"head_commit": "cd75a6a38251a4b695628e24acaa274718ee4f6c",
"head_commit_message": "fix: linting",
"patch_to_review": "diff --git a/pwndbg/commands/canary.py b/pwndbg/commands/canary.py\nindex 4f24421fc46..adf78debfe7 100644\n--- a/pwndbg/commands/canary.py\n+++ b/pwndbg/commands/canary.py\n@@ -5,6 +5,7 @@\n imp... | [
{
"diff_hunk": "@@ -40,15 +88,30 @@ def canary_value():\n @pwndbg.commands.Command(parser, command_name=\"canary\", category=CommandCategory.STACK)\n @pwndbg.commands.OnlyWhenRunning\n def canary(all) -> None:\n+ \"\"\"Display information about the stack canary, including its location in TLS and any copies f... | 07fd3f0e1e18e02f7d9d6dbcad76fad22670565b | diff --git a/pwndbg/commands/canary.py b/pwndbg/commands/canary.py
index 4f24421fc46..aaf71b0bc4c 100644
--- a/pwndbg/commands/canary.py
+++ b/pwndbg/commands/canary.py
@@ -1,10 +1,13 @@
from __future__ import annotations
import argparse
+from typing import Optional
+from typing import Tuple
import pwndbg.aglib.... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Code Refactoring / Architectural Improvement"
} |
pytest-dev__pytest-13573@1ef62bc | pytest-dev/pytest | Python | 13,573 | Handled CollectReport without duration attribute in terminal report | <!--
Thanks for submitting a PR, your contribution is really appreciated!
Here is a quick checklist that should be present in PRs.
- [ ] Include documentation when adding new features.
- [ ✅] Include new tests or update existing tests when applicable.
- [✅] Allow maintainers to push and squash when merging my ... | 2025-06-27T20:26:00Z | Crash with `console_output_style=times` and skipping tests
<!--
Thanks for submitting an issue!
Quick check-list while reporting bugs:
-->
Running `uv run pytest -o console_output_style=times tests/test_repro.py tests/test_repro_skip.py` gives me the following backtrace:
```
tests/test_repro.py .
INTERNALERROR> Traceb... | Looks like the code never acvouted for collection reports
We need more typechecks it seems and a test
A ugly nasty workaround would be a session scope fixture to import | [
{
"body": "<!--\nThanks for submitting an issue!\n\nQuick check-list while reporting bugs:\n-->\nRunning `uv run pytest -o console_output_style=times tests/test_repro.py tests/test_repro_skip.py` gives me the following backtrace:\n```\ntests/test_repro.py .\nINTERNALERROR> Traceback (most recent call last):\nIN... | 8c5fc5739532c3a6bb602949b65c4158590813fd | {
"head_commit": "1ef62bcc46adda07be8878ba2c010381167996de",
"head_commit_message": "[pre-commit.ci] auto fixes from pre-commit.com hooks\n\nfor more information, see https://pre-commit.ci",
"patch_to_review": "diff --git a/src/_pytest/terminal.py b/src/_pytest/terminal.py\nindex 5f27c46b41e..a95f79ba6b6 100644\n... | [
{
"diff_hunk": "@@ -0,0 +1,34 @@\n+from __future__ import annotations\n+\n+from _pytest.pytester import Pytester\n+\n+\n+def test_console_output_style_times_with_skipped_and_passed(pytester: Pytester) -> None:\n+ pytester.makepyfile(\n+ test_repro=\"\"\"\n+ def test_hello():\n+ ... | 25c8c0a1f1a849a89e84e11cbde3cf490a719e7b | diff --git a/changelog/13478.bugfix.rst b/changelog/13478.bugfix.rst
new file mode 100644
index 00000000000..1147ee54c9e
--- /dev/null
+++ b/changelog/13478.bugfix.rst
@@ -0,0 +1 @@
+Fixed a crash when using :confval:`console_output_style` with ``times`` and a module is skipped.
diff --git a/src/_pytest/terminal.py b/s... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
pydantic__pydantic-11914@790a88d | pydantic/pydantic | Python | 11,914 | Do not use deprecated methods as default field values | <!-- Thank you for your contribution! -->
<!-- Unless your change is trivial, please create an issue to discuss the change before creating a PR -->
## Change Summary
Fixes https://github.com/pydantic/pydantic/issues/11912.
<!-- Please give a short summary of the changes. -->
## Related issue number
<!--... | 2025-05-26T07:31:58Z | Adding a field named `schema` results in the @schema property being sneakily added as the default value
### Initial Checks
- [x] I confirm that I'm using Pydantic V2
### Description
The code below outputs
```
{'schema': FieldInfo(annotation=int, required=False, default=<bound method BaseModel.schema of <class '__mai... | The name `schema` is reserved and should not be used as a field name:
```bash
UserWarning: Field name "schema" in "Test" shadows an attribute in parent "BaseModel"
```
The default value is inherited from `BaseModel`.
For now you can do something like
```python
schema: int = Field(default_factory=int)
# or
... | [
{
"body": "### Initial Checks\n\n- [x] I confirm that I'm using Pydantic V2\n\n### Description\n\nThe code below outputs\n```\n{'schema': FieldInfo(annotation=int, required=False, default=<bound method BaseModel.schema of <class '__main__.Test'>>)}\n```\n\nI know we are not supposed to have a `schema` named fie... | 2c38bf402c2a7ebadfcf2d1ccf8718513f9dc969 | {
"head_commit": "790a88dbb77f690c173d26dc56248bc7c429b325",
"head_commit_message": "Do not use deprecated methods as default field values",
"patch_to_review": "diff --git a/pydantic/_internal/_fields.py b/pydantic/_internal/_fields.py\nindex f81968c448..8b96e2c41a 100644\n--- a/pydantic/_internal/_fields.py\n+++... | [
{
"diff_hunk": "@@ -265,6 +282,20 @@ def collect_model_fields( # noqa: C901\n continue\n \n assigned_value = getattr(cls, ann_name, PydanticUndefined)\n+ if (",
"line": null,
"original_line": 285,
"original_start_line": null,
"path": "pydantic/_internal/_fields.py",
... | 58a4ea2297f9dc174534d5e6ad7b5b040dc4f5be | diff --git a/pydantic/_internal/_fields.py b/pydantic/_internal/_fields.py
index f81968c448..7d38998487 100644
--- a/pydantic/_internal/_fields.py
+++ b/pydantic/_internal/_fields.py
@@ -199,6 +199,22 @@ def update_field_from_config(config_wrapper: ConfigWrapper, field_name: str, fie
_apply_alias_generator_to_... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
pwndbg__pwndbg-2847@b4debda | pwndbg/pwndbg | Python | 2,847 | Dump the TLS address by default | I am creating a new PR as I messed up the previous one: #2829
This dumps by default the TLS address with `dt tcbhead_t <tls_address>` if there is a `tcbhead_t`. If there is not, use telescope to dump it.
It will print by default until the `__glibc_unused2` on x86-64. If there isn't one, it will print just 10 lines... | 2025-04-08T03:37:15Z | Command request: dump fs at offset (x86-64)
```
pwndbg> p/x $fs:[0x30]
A syntax error in expression, near `:[0x30]'.
```
We can have a command that would:
1) save current state
2) assemble a `mov rax, qword ptr fs:[IDX]` instruction at $RIP
3) execute it
4) revert state
5) print the FS:[0x30] value
maybe: `dumpfs`? o... | [
{
"body": "```\npwndbg> p/x $fs:[0x30]\nA syntax error in expression, near `:[0x30]'.\n```\n\nWe can have a command that would:\n1) save current state\n2) assemble a `mov rax, qword ptr fs:[IDX]` instruction at $RIP\n3) execute it\n4) revert state\n5) print the FS:[0x30] value\n\nmaybe: `dumpfs`? or `dump-fs-re... | 261fac85438d98842f567fd58888d4e55fd5be0a | {
"head_commit": "b4debdaccb4308b7285fd45b194f127476e26812",
"head_commit_message": "Update pwndbg/commands/tls.py",
"patch_to_review": "diff --git a/pwndbg/commands/tls.py b/pwndbg/commands/tls.py\nindex 0eb37880cf7..f11ff746a3a 100644\n--- a/pwndbg/commands/tls.py\n+++ b/pwndbg/commands/tls.py\n@@ -15,6 +15,7 @... | [
{
"diff_hunk": "@@ -46,6 +49,49 @@ def tls(pthread_self=False) -> None:\n print(message.success(\"Thread Local Storage (TLS) base: %#x\" % tls_base))\n print(message.success(\"TLS is located at:\"))\n print(message.notice(pwndbg.aglib.vmmap.find(tls_base)))\n+\n+ # Trying to `dt t... | f4f7fcdbaea56314b3e40b7a34313e69b435cb35 | diff --git a/pwndbg/commands/tls.py b/pwndbg/commands/tls.py
index 0eb37880cf7..8711ea31d72 100644
--- a/pwndbg/commands/tls.py
+++ b/pwndbg/commands/tls.py
@@ -15,6 +15,7 @@
import pwndbg.color.memory as M
import pwndbg.commands
import pwndbg.commands.context
+import pwndbg.commands.telescope
import pwndbg.dbg
fr... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
pwndbg__pwndbg-2819@c6fbe1e | pwndbg/pwndbg | Python | 2,819 | attachp: add default target if not provided | Fixes #2815. The `attachp` command with no arguments will now attempt to attach to a process with the same name as the name of the binary loaded into the debugger.
<!-- Please make sure to read the testing and linting instructions at https://github.com/pwndbg/pwndbg/blob/dev/DEVELOPING.md before creating a PR -->
| 2025-03-31T21:03:16Z | attachp without a target could just look for the loaded binary file
When we do `gdb ./somebinary`, the GDB knows that we have the `somebinary` loaded.
```
pwndbg> attachp
usage: attachp [-h] [--no-truncate] [--retry] [--user USER] [-a] target
attachp: error: the following arguments are required: target
```
Then we co... | [
{
"body": "When we do `gdb ./somebinary`, the GDB knows that we have the `somebinary` loaded.\n\n```\npwndbg> attachp\nusage: attachp [-h] [--no-truncate] [--retry] [--user USER] [-a] target\nattachp: error: the following arguments are required: target\n```\n\nThen we could have `attachp` without a `target` arg... | ff3f1b82d40ec1b4a3317c2a68c554d332467570 | {
"head_commit": "c6fbe1e26a3533b8c05e9563aadbed83518210b6",
"head_commit_message": "attachp: add default target if not provided\n\nFixes #2815. The `attachp` command with no arguments will now attempt to attach to a process with the same name as the\nname of the binary loaded into the debugger.",
"patch_to_revie... | [
{
"diff_hunk": "@@ -119,6 +121,20 @@ def find_pids(target, user, all):\n \n @pwndbg.commands.ArgparsedCommand(parser, category=CommandCategory.START)\n def attachp(target, no_truncate, retry, all, user=None) -> None:\n+ # As a default, the user may want to attach to a binary name taken from currently loaded ... | 8fbd050cd3addb120e24fb71884d09a9e2f897a8 | diff --git a/pwndbg/commands/attachp.py b/pwndbg/commands/attachp.py
index a6b3b301e17..571ff606f62 100644
--- a/pwndbg/commands/attachp.py
+++ b/pwndbg/commands/attachp.py
@@ -63,8 +63,10 @@
)
parser.add_argument(
"target",
+ nargs="?",
+ default=None,
type=str,
- help="pid, process name, part of ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
pydantic__pydantic-11769@d174f8b | pydantic/pydantic | Python | 11,769 | Make sure Pydantic dataclasses with slots and `validate_assignment` can be unpickled |
Fixes https://github.com/pydantic/pydantic/issues/11768.
<!-- Thank you for your contribution! -->
<!-- Unless your change is trivial, please create an issue to discuss the change before creating a PR -->
## Change Summary
<!-- Please give a short summary of the changes. -->
## Related issue number
... | 2025-04-17T12:54:27Z | missing attribute dataclass copy with slots=True & validate_assignment=True
### Initial Checks
- [x] I confirm that I'm using Pydantic V2
### Description
When copying a pydantic v2 dataclass with both `"validate_assignment": True` and `slots=True`, I get `object has no attribute` for an existing field.
### Example ... | I'm not sure how to fix this yet. We could define a custom `__copy__()` method on Pydantic dataclasses, but the issue lies in the fact that pickling (see repro below) uses `setattr()`, and pydantic-core excepts field values to be present when validating on assignment. Probably we can override `__setstate__()` but I'll ... | [
{
"body": "### Initial Checks\n\n- [x] I confirm that I'm using Pydantic V2\n\n### Description\n\nWhen copying a pydantic v2 dataclass with both `\"validate_assignment\": True` and `slots=True`, I get `object has no attribute` for an existing field.\n\n### Example Code\n\n```Python\nfrom copy import copy\n\nfro... | a3f42a4d6e1765d03a9ad49f9f2ae83c4c525794 | {
"head_commit": "d174f8b8f7c1775e3f3ca42a08ec2c6f8fd1f835",
"head_commit_message": "Make sure Pydantic dataclasses with slots and `validate_assignment` are unpickable",
"patch_to_review": "diff --git a/pydantic/_internal/_dataclasses.py b/pydantic/_internal/_dataclasses.py\nindex 954ab32f23..656ef78122 100644\n-... | [
{
"diff_hunk": "@@ -2430,6 +2430,23 @@ class Model:\n assert dc.b == 'bar'\n \n \n+# Must be defined at the module level to be pickable:",
"line": null,
"original_line": 2433,
"original_start_line": null,
"path": "tests/test_dataclasses.py",
"start_line": null,
"text": "@user1:\n```s... | 4cf3a25025a0475a1403889683db9eac3b797d8f | diff --git a/pydantic/_internal/_dataclasses.py b/pydantic/_internal/_dataclasses.py
index 954ab32f23..656ef78122 100644
--- a/pydantic/_internal/_dataclasses.py
+++ b/pydantic/_internal/_dataclasses.py
@@ -5,7 +5,7 @@
import dataclasses
import typing
import warnings
-from functools import partial, wraps
+from funct... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
pwndbg__pwndbg-2828@a720590 | pwndbg/pwndbg | Python | 2,828 | Highlight breakpoints in `nearpc` output | Add visual indication for breakpoints in the `nearpc` output. Addresses in the disassembly which have an active breakpoint attached to them are prefixed using by `b+` and highlighted in red by default.
This can be configured using the new `highlight-breakpoints`, `nearpc-breakpoint`, and `nearpc-breakpoint-color` th... | 2025-04-02T18:19:17Z | Show breakpoints/watchpoints in context
**Is your feature request related to a problem? Please describe.**
Visual debuggers allow you to click next to an assembly line to set a breakpoint at that address. They proceed to highlight that address in the disassembly view in e.g. red to visualize the presence of a breakpoin... | That's a great idea. | [
{
"body": "**Is your feature request related to a problem? Please describe.**\nVisual debuggers allow you to click next to an assembly line to set a breakpoint at that address. They proceed to highlight that address in the disassembly view in e.g. red to visualize the presence of a breakpoint here. gdb/pwndbg d... | 2c3d11a8013500f57631c4a325223fc19b1d33fd | {
"head_commit": "a7205907d2525a9336e345a605e1acbe7bca5a9f",
"head_commit_message": "Update tests/gdb-tests/tests/test_nearpc.py",
"patch_to_review": "diff --git a/pwndbg/aglib/nearpc.py b/pwndbg/aglib/nearpc.py\nindex c008dfa940f..921d2feeaa0 100644\n--- a/pwndbg/aglib/nearpc.py\n+++ b/pwndbg/aglib/nearpc.py\n@@... | [
{
"diff_hunk": "@@ -168,23 +173,36 @@ def nearpc(\n \n assembly_strings = D.instructions_and_padding(instructions)\n \n+ breakpoint_locations = pwndbg.dbg.breakpoint_locations()\n+\n # Print out each instruction\n for i, (address_str, symbol, instr, asm) in enumerate(\n zip(addresses, sym... | 65b8f13ab15b3f849b6fc6875674538b913a655c | diff --git a/pwndbg/aglib/nearpc.py b/pwndbg/aglib/nearpc.py
index c008dfa940f..6f19f82bbfd 100644
--- a/pwndbg/aglib/nearpc.py
+++ b/pwndbg/aglib/nearpc.py
@@ -36,6 +36,7 @@ def ljust_padding(lst):
ColorParamSpec("symbol", "normal", "color for nearpc command (symbol)"),
ColorParamSpec("address", "nor... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
pytest-dev__pytest-13253@60becec | pytest-dev/pytest | Python | 13,253 | add --disable-plugin-autoload | fixes #8969
I'm pretty sure the implementation is solid, but I have a bunch of question marks in comments that should be resolved before merging. I can probably resolve them on my own by digging deep enough into the innards, but wouldn't mind explanations if somebody is more familiar with that territory.
I'm not ... | 2025-02-25T16:45:46Z | Disable plugin autoload via configuration file
#### What's the problem this feature will solve?
I want to use a plugin only when certain conditions are met. Currently, in order to do that I can set the environment variable `PYTEST_DISABLE_PLUGIN_AUTOLOAD` when calling pytest. Since disabling autoload is the "common pa... | [
{
"body": "#### What's the problem this feature will solve?\r\nI want to use a plugin only when certain conditions are met. Currently, in order to do that I can set the environment variable `PYTEST_DISABLE_PLUGIN_AUTOLOAD` when calling pytest. Since disabling autoload is the \"common path\" for the project I'm ... | 9cf2cae94355cd83ad7e8d88f976c5a524c98cfb | {
"head_commit": "60becec6e3ead2195d6a9e01279460220ac73ade",
"head_commit_message": "pemdas except not",
"patch_to_review": "diff --git a/changelog/13253.feature.rst b/changelog/13253.feature.rst\nnew file mode 100644\nindex 00000000000..e497c207223\n--- /dev/null\n+++ b/changelog/13253.feature.rst\n@@ -0,0 +1 @@... | [
{
"diff_hunk": "@@ -1342,23 +1342,60 @@ class PseudoPlugin:\n attrs_used = []\n \n def __getattr__(self, name):\n- assert name == \"__loader__\"\n+ assert name in (\"__loader__\", \"__spec__\")\n self.attrs_used.append(name)\n return object()\n \n ... | e7403ac2a9d173e99759cff08f25f894c0309a96 | diff --git a/changelog/13253.feature.rst b/changelog/13253.feature.rst
new file mode 100644
index 00000000000..e497c207223
--- /dev/null
+++ b/changelog/13253.feature.rst
@@ -0,0 +1 @@
+New flag: :ref:`--disable-plugin-autoload <disable_plugin_autoload>` which works as an alternative to :envvar:`PYTEST_DISABLE_PLUGIN_A... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
pwndbg__pwndbg-2804@836d063 | pwndbg/pwndbg | Python | 2,804 | Add special handling for `version` in LLDB Pwndbg | Fixes: #2800
`version` is another Pwndbg command that has to alias an LLDB command. This PR adds it to the LLDB Pwndbg CLI, in the same way we handle `set`. This PR also introduces a name component to `pwndbg.dbg.Debugger`, as a means to distinguish between debuggers that's more specific than `is_gdblib_available`, ... | 2025-03-27T21:32:49Z | [LLDB] error: cannot add command: can't replace builtin command
pwndbg version: pwndbg-lldb_2025.02.19_x86_64-portable
When lunch ./pwndbg/bin/pwndbg-lldb, there have an error:
`error: cannot add command: can't replace builtin command`
I add a print in `pwndbg-lldb_2025.02.19_x86_64-portable:1808 the function add_com... | Yes, this is an '"error"', but it does not break any functionality in lldb. We have to disable this message or disable `version` command only for lldb.
I think should rename `version` with others, keep the `version` command working.
Why? Wouldn't it be better to override it with ours and return our version + LLDB versi... | [
{
"body": "pwndbg version: pwndbg-lldb_2025.02.19_x86_64-portable\n\nWhen lunch ./pwndbg/bin/pwndbg-lldb, there have an error:\n`error: cannot add command: can't replace builtin command`\n\nI add a print in `pwndbg-lldb_2025.02.19_x86_64-portable:1808 the function add_command` ,\nFound the error becasue command... | d1b754dbb893551d8af210ca8e2596eaca3a7583 | {
"head_commit": "836d06373501b26e2fc3c179e0aceeaf2cd3a92f",
"head_commit_message": "Fix `version` in LLDB Pwndbg",
"patch_to_review": "diff --git a/pwndbg/commands/version.py b/pwndbg/commands/version.py\nindex e1226ddb2da..0c51b62c7c8 100644\n--- a/pwndbg/commands/version.py\n+++ b/pwndbg/commands/version.py\n@... | [
{
"diff_hunk": "@@ -93,13 +93,22 @@ def get_terminal_size():\n return f\"Terminal width: {width_info}, height: {height_info}\\n\"\n \n \n-@pwndbg.commands.ArgparsedCommand(\n- \"Displays Pwndbg and its important deps versions.\", category=CommandCategory.PWNDBG\n-)\n-def version() -> None:\n+def version_... | 92fbb8d066f845e8bfe4325a3ad1193a3740acbd | diff --git a/pwndbg/commands/version.py b/pwndbg/commands/version.py
index e1226ddb2da..7e27fed935a 100644
--- a/pwndbg/commands/version.py
+++ b/pwndbg/commands/version.py
@@ -93,13 +93,22 @@ def get_terminal_size():
return f"Terminal width: {width_info}, height: {height_info}\n"
-@pwndbg.commands.ArgparsedCo... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
pwndbg__pwndbg-2732@4b31915 | pwndbg/pwndbg | Python | 2,732 | Fix remote procinfo errors & remote xinfo | This provides a fix to #2615. The `procinfo` commands attempts to read SELinux attributes from a `/proc`, and reading that file ( `/proc/%PID/task/$TID/attr/current`) sometimes fails (you can reproduce locally with ` cat /proc/$$/attr/current`). There's some discussion of this behavior here - https://serverfault.com/qu... | 2025-02-13T19:38:09Z | procinfo could not download remote file
### Description
```
pwndbg> procinfo
exe '/ctf/lake/order66/order66'
cmdline /ctf/lake/order66/order66 ''
cwd '/ctf/lake/order66'
pid 26861
tid 26861
╭─────────────────────────────── Traceback (most recent call last) ──────────────────────... | We could catch the error and display `selinux: Not available due to error: {e}`. This approach could also be applied in other places where `get_file(/proc/)` is used.
Is this fixed already maybe? I think we had some changes to this... @patryk4815
I think it is not fixed
I don't know much about selinux but there's s... | [
{
"body": "### Description\r\n\r\n```\r\npwndbg> procinfo\r\nexe '/ctf/lake/order66/order66'\r\ncmdline /ctf/lake/order66/order66 ''\r\ncwd '/ctf/lake/order66'\r\npid 26861\r\ntid 26861\r\n╭─────────────────────────────── Traceback (most recent call last) ─────────────────────────... | 5c3d1d3560ab2b19b5dc835dffbae84c4e86b31e | {
"head_commit": "4b31915fbae0b8785e8cf8dbf319ac36092a5e8a",
"head_commit_message": "Fix remote procinfo error due to error in opening SELinux attribute file. Bring full functionality to xinfo on remote hosts",
"patch_to_review": "diff --git a/pwndbg/commands/procinfo.py b/pwndbg/commands/procinfo.py\nindex 4e2d2... | [
{
"diff_hunk": "@@ -596,10 +596,15 @@ def download_remote_file(self, remote_path: str, local_path: str) -> None:\n import pwndbg.aglib.file\n \n if pwndbg.aglib.file.is_vfile_qemu_user_bug():\n- with open(local_path, \"wb\") as fp:\n- for data in pwndbg.aglib.file.vfile... | 1113c1f1c2dd1d0fa4b81ee9e821d2ca1c23dfa0 | diff --git a/pwndbg/commands/procinfo.py b/pwndbg/commands/procinfo.py
index 4e2d287c9a6..5581e93b517 100644
--- a/pwndbg/commands/procinfo.py
+++ b/pwndbg/commands/procinfo.py
@@ -105,10 +105,14 @@ def __init__(self, pid=None, tid=None) -> None:
@property
@pwndbg.lib.cache.cache_until("stop")
- def seli... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
pydantic__pydantic-11755@e7d3bbf | pydantic/pydantic | Python | 11,755 | Remove generics cache workaround |
This results in parameterized classes being different type objects, although they represent the same type.
A new refactor (https://github.com/pydantic/pydantic/pull/11388) was introduced since then and fixes the root issue.
<!-- Thank you for your contribution! -->
<!-- Unless your change is trivial, please cr... | 2025-04-15T10:44:44Z | UserWarning: Pydantic serializer warnings >= v2.11.0
### Initial Checks
- [x] I confirm that I'm using Pydantic V2
### Description
For all pydantic versions >= 2.11.0 I receive the following warning for the code posted below.
- For pydantic 2.10.6 the warning doesn't occur.
- The serializing seems to works correctly... | Bisected to https://github.com/pydantic/pydantic/pull/10704.
Pydantic has a different way of representing parameterized generic classes. Normally, parameterized user-defined generic classes aren't proper types, but rather what we call generic alias instances:
```python
class MyClass[T]: pass
MyClassInt = MyClass[int... | [
{
"body": "### Initial Checks\n\n- [x] I confirm that I'm using Pydantic V2\n\n### Description\n\nFor all pydantic versions >= 2.11.0 I receive the following warning for the code posted below.\n- For pydantic 2.10.6 the warning doesn't occur.\n- The serializing seems to works correctly.\n- The warning itself is... | 121651b22da3a09e82a1c6605eee2475cbcd4948 | {
"head_commit": "e7d3bbf489d2f59e86e068d0cc22891ee6cc511c",
"head_commit_message": "Remove generics cache workaround\n\nThis results in parameterized classes being different type objects,\nalthough they represent the same type.\n\nA new refactor (https://github.com/pydantic/pydantic/pull/11388)\nwas introduced sin... | [
{
"diff_hunk": "@@ -519,6 +520,37 @@ class M(BaseModel):\n del generics\n \n \n+def test_generics_reused() -> None:\n+ \"\"\"https://github.com/pydantic/pydantic/issues/11747\n+\n+ To fix an issue with recursive generics, we introduced a change in 2.11 that would\n+ skip caching the parameterized m... | 95b79f747c5e8783f21978ac83fba925759900e3 | diff --git a/pydantic/main.py b/pydantic/main.py
index ba9324bad2a..820f34f406d 100644
--- a/pydantic/main.py
+++ b/pydantic/main.py
@@ -908,12 +908,7 @@ def __class_getitem__(
submodel = _generics.create_generic_submodel(model_name, origin, args, params)
- # Cache the generated mode... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
pwndbg__pwndbg-2711@9c9e450 | pwndbg/pwndbg | Python | 2,711 | Relay parsing error information to argparse, don't except on command argument parse error | Before:
```
pwndbg> hi nothing!
Exception occurred: hi: No symbol "nothing" in current context. (<class 'pwndbg.dbg.Error'>)
For more info invoke `set exception-verbose on` and rerun the command
or debug it by yourself with `set exception-debugger on`
pwndbg> dt struct a
Exception occurred: dt: No symbol "a" in ... | 2025-01-28T00:51:15Z | dt command crashes easily
### Description
The `dt` command throws an exception when given a bit wacky input, it should probably give an error message, similar to `ptype`.
### Steps to reproduce
```cpp
#include <vector>
int main () { return 0; }
```
`g++ -g ./main.cpp -o ./main`
`gdb ./main`
Here are some... | Hi @k4lizen, hope you're doing well!
I'm new to the community and would like to try solving this issue.
Could you please guide me on how to contribute and set up the environment?
Also, let me know more this bug
@alguiguilo098 Hi, please read the https://github.com/pwndbg/pwndbg/blob/dev/DEVELOPING.md documentation.... | [
{
"body": "### Description\r\n\r\nThe `dt` command throws an exception when given a bit wacky input, it should probably give an error message, similar to `ptype`.\r\n\r\n### Steps to reproduce\r\n\r\n```cpp\r\n#include <vector>\r\nint main () { return 0; }\r\n```\r\n`g++ -g ./main.cpp -o ./main`\r\n`gdb ./main`... | 1ce7ee36e8e3c05aa81308ed357da922c86d915d | {
"head_commit": "9c9e45058591a2cda4003639db52de9eb45f4c27",
"head_commit_message": "relay parsing error information to argparse",
"patch_to_review": "diff --git a/pwndbg/commands/__init__.py b/pwndbg/commands/__init__.py\nindex cfde47451c8..2dc56c2f239 100644\n--- a/pwndbg/commands/__init__.py\n+++ b/pwndbg/comm... | [
{
"diff_hunk": "@@ -264,6 +268,18 @@ def fix_reraise(*a, **kw) -> str | pwndbg.dbg_mod.Value | None:\n return fix(*a, reraise=True, **kw) # type: ignore[misc]\n \n \n+def fix_reraise_arg(arg) -> pwndbg.dbg_mod.Value:\n+ \"\"\"fix_reraise wrapper for evaluating command arguments\"\"\"\n+ try:\n+ ... | 5bdd6e68f5b31370b4830a2646d9e95d37c037bf | diff --git a/pwndbg/commands/__init__.py b/pwndbg/commands/__init__.py
index cfde47451c8..25ebffea18a 100644
--- a/pwndbg/commands/__init__.py
+++ b/pwndbg/commands/__init__.py
@@ -123,6 +123,9 @@ def _handler(_debugger, arguments, is_interactive):
def split_args(self, argument: str) -> Tuple[List[str], Dict[Any, ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
pydantic__pydantic-11761@decec9f | pydantic/pydantic | Python | 11,761 | Do not provide `field_name` in validator core schemas | <!-- Thank you for your contribution! -->
<!-- Unless your change is trivial, please create an issue to discuss the change before creating a PR -->
## Change Summary
Companion to https://github.com/pydantic/pydantic-core/pull/1692 to stop using deprecated `field_name` argument on validation function schemas.
... | 2025-04-16T18:08:56Z | Incorrect `ValidationInfo.field_name` when using `type` statement
### Initial Checks
- [x] I confirm that I'm using Pydantic V2
### Description
Field validators receive an incorrect value for `field_name` for fields defined with a type alias made with a `type` statement.
The following code uses a type alias to reus... | ```py
from typing import Annotated, TypeAlias
from pydantic import AfterValidator, BaseModel, ValidationInfo
def validate_my_field(value: str, info: ValidationInfo):
print(f"{info.field_name} = {value}")
return value
type MyField = Annotated[str, AfterValidator(validate_my_field)]
MyFieldAlias: TypeAlias =... | [
{
"body": "### Initial Checks\n\n- [x] I confirm that I'm using Pydantic V2\n\n### Description\n\nField validators receive an incorrect value for `field_name` for fields defined with a type alias made with a `type` statement.\n\nThe following code uses a type alias to reuse a field validator in multiple fields.... | 07b33c3f3c099e682bb97752fbeb89718242b32f | {
"head_commit": "decec9fa38e98fadcb3e0cf18e3a9e5ae4cbe198",
"head_commit_message": "Bump pydantic-core to 2.34.0",
"patch_to_review": "diff --git a/docs/concepts/types.md b/docs/concepts/types.md\nindex d7cc290b81c..4b6ccfbaffd 100644\n--- a/docs/concepts/types.md\n+++ b/docs/concepts/types.md\n@@ -979,7 +979,7 ... | [
{
"diff_hunk": "@@ -2779,6 +2781,42 @@ class MyModel(BaseModel):\n assert m.foobar == {'value': '1', 'field_name': 'foobar', 'data': {'x': 123}}\n \n \n+@pytest.mark.skipif(sys.version_info < (3, 12), reason='requires Python 3.12+ for PEP 695 type keyword')\n+def test_validator_field_name_with_reused_type(c... | b25047c535fe744af1bfe6ce12b13ec7321a0829 | diff --git a/docs/concepts/types.md b/docs/concepts/types.md
index d7cc290b81c..4b6ccfbaffd 100644
--- a/docs/concepts/types.md
+++ b/docs/concepts/types.md
@@ -979,7 +979,7 @@ class CustomType:
cls, source_type: Any, handler: GetCoreSchemaHandler
) -> core_schema.CoreSchema:
return core_schema.w... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
pydantic__pydantic-11721@0e3e959 | pydantic/pydantic | Python | 11,721 | Properly fetch plain serializer function when serializing default value in JSON Schema |
<!-- Thank you for your contribution! -->
<!-- Unless your change is trivial, please create an issue to discuss the change before creating a PR -->
## Change Summary
Fixes https://github.com/pydantic/pydantic/issues/11446.
<!-- Please give a short summary of the changes. -->
## Related issue number
... | 2025-04-08T16:26:09Z | Serializer is not applied to json schema default value
### Initial Checks
- [x] I confirm that I'm using Pydantic V2
### Description
Hello to all,
I am unsure if this is an actual issue, or a skill issue from my part. Here is the case :
I have an external class, Voltage, I cannot modify.
As suggested by the docs, ... | Hi @Horrih,
First off, thanks for the clean and reproducible example - makes things super easy for us!!
Admittedly, the solution here is frustrating. You'll need to have the `PlainSerializer` on the outer level for the JSON schema generator to recognize that said transformer needs to be applied:
```py
import pydanti... | [
{
"body": "### Initial Checks\n\n- [x] I confirm that I'm using Pydantic V2\n\n### Description\n\nHello to all,\n\nI am unsure if this is an actual issue, or a skill issue from my part. Here is the case :\n\nI have an external class, Voltage, I cannot modify.\nAs suggested by the docs, I wrap it with Annotated ... | 2bf985f3f9efe374433219d28271c3f4763fb211 | {
"head_commit": "0e3e9599c9309c46f4734683d8354aba193253d1",
"head_commit_message": "Properly fetch plain serializer function when serializing default value in JSON Schema",
"patch_to_review": "diff --git a/pydantic/json_schema.py b/pydantic/json_schema.py\nindex be9595c4ffc..fae265f8880 100644\n--- a/pydantic/js... | [
{
"diff_hunk": "@@ -1112,31 +1112,41 @@ def default_schema(self, schema: core_schema.WithDefaultSchema) -> JsonSchemaVal\n if default is NoDefault:\n return json_schema\n \n+ def _get_ser_schema(schema: CoreSchema) -> core_schema.PlainSerializerFunctionSerSchema | None:\n+ ... | 017d78e8155924f85685b6d06eb77bb9bbd54ce2 | diff --git a/pydantic/json_schema.py b/pydantic/json_schema.py
index be9595c4ffc..d6dc74aa9fd 100644
--- a/pydantic/json_schema.py
+++ b/pydantic/json_schema.py
@@ -1115,28 +1115,28 @@ def default_schema(self, schema: core_schema.WithDefaultSchema) -> JsonSchemaVal
# we reflect the application of custom plain,... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
pydantic__pydantic-11658@ea85e99 | pydantic/pydantic | Python | 11,658 | Properly validate parameterized mappings | <!-- Thank you for your contribution! -->
<!-- Unless your change is trivial, please create an issue to discuss the change before creating a PR -->
## Change Summary
Fixes https://github.com/pydantic/pydantic/issues/11650.
Regression in https://github.com/pydantic/pydantic/pull/11247, the logic was somehow tw... | 2025-03-31T10:44:15Z | Regression 2.10: Not properly validating disjunction of dataclasses (or TypedDict) that embed Mapping
### Initial Checks
- [x] I confirm that I'm using Pydantic V2
### Description
Pydantic does not properly validate minimal example below (whereas it was in 2.10.6)
### Example Code
```Python
from collections.abc i... | [
{
"body": "### Initial Checks\n\n- [x] I confirm that I'm using Pydantic V2\n\n### Description\n\nPydantic does not properly validate minimal example below (whereas it was in 2.10.6)\n\n\n### Example Code\n\n```Python\nfrom collections.abc import Mapping\n\nfrom pydantic import TypeAdapter, RootModel\nfrom pyda... | 6c38dc93f40a47f4d1350adca9ec0d72502e223f | {
"head_commit": "ea85e99a5ac50b1d176164b2e548374d4c131809",
"head_commit_message": "Properly validate parameterized mappings",
"patch_to_review": "diff --git a/pydantic/_internal/_generate_schema.py b/pydantic/_internal/_generate_schema.py\nindex c7efbf5b209..8a7f72f7d47 100644\n--- a/pydantic/_internal/_generat... | [
{
"diff_hunk": "@@ -6951,17 +6951,23 @@ class Foo(BaseModel):\n assert exc_info.value.errors(include_url=False) == errors\n \n \n-def test_mutable_mapping() -> None:\n+def test_mutable_mapping_userdict_subclass() -> None:\n \"\"\"Addresses https://github.com/pydantic/pydantic/issues/9549.\n \n Note ... | a071a50dc037c9ddd364c39e9e0e19530de0fb50 | diff --git a/pydantic/_internal/_generate_schema.py b/pydantic/_internal/_generate_schema.py
index c7efbf5b209..8a7f72f7d47 100644
--- a/pydantic/_internal/_generate_schema.py
+++ b/pydantic/_internal/_generate_schema.py
@@ -566,32 +566,38 @@ def _deque_schema(self, items_type: Any) -> CoreSchema:
def _mapping_sch... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
pytest-dev__pytest-13029@74bd56e | pytest-dev/pytest | Python | 13,029 | fix `AttributeError` crash when using `--import-mode=importlib` | closes #13026 .
- [X] Include new tests or update existing tests when applicable.
- [X] Allow maintainers to push and squash when merging my commits.
- [X] Create a new changelog file in the `changelog` folder.
Only parent modules with the `__path__` attribute can be used by the `find_spec` function, and mo... | 2024-12-05T11:34:35Z | Upgrade pytest from 8.3.3 to 8.3.4 triggers `AttributeError: module 'code' has no attribute '__path__'. Did you mean: '__all__'?`
- [x] a detailed description of the bug or problem you are having
I have a number of pytest tests that used to work in 8.3.3.
Since I upgraded to pytest 8.3.4, these tests fail reliabl... | When the top-level directory is named `code`, the issue can be reproduced, for example:
```
code/foo/test_some.py
```
When the top-level directory is not named `code`, it executes normally, such as:
```
my_code/foo/test_some.py
foo/code/test_some.py
```
I am currently trying to trace furt... | [
{
"body": "- [x] a detailed description of the bug or problem you are having\r\n\r\nI have a number of pytest tests that used to work in 8.3.3.\r\n\r\nSince I upgraded to pytest 8.3.4, these tests fail reliably in 2 different projects.\r\n(see details below).\r\n\r\n- [x] output of `pip list` from the virtual e... | ea1a79a93a353223cd8dcb039e45d10ae20bc168 | {
"head_commit": "74bd56ef4d60b0723763101208d16e236dfc41f1",
"head_commit_message": "fix #13026",
"patch_to_review": "diff --git a/changelog/13026.bugfix.rst b/changelog/13026.bugfix.rst\nnew file mode 100644\nindex 00000000000..a7a79234588\n--- /dev/null\n+++ b/changelog/13026.bugfix.rst\n@@ -0,0 +1 @@\n+Fixed `... | [
{
"diff_hunk": "@@ -668,7 +668,7 @@ def _import_module_using_spec(\n parent_module: ModuleType | None = None\n if parent_module_name:\n parent_module = sys.modules.get(parent_module_name)\n- if parent_module is None:\n+ if parent_module is None or not hasattr(parent_module, \"__pat... | 2546d9d9a802a64663ae186a61182cb9ba24655a | diff --git a/changelog/13026.bugfix.rst b/changelog/13026.bugfix.rst
new file mode 100644
index 00000000000..d10edbd111a
--- /dev/null
+++ b/changelog/13026.bugfix.rst
@@ -0,0 +1 @@
+Fixed :class:`AttributeError` crash when using ``--import-mode=importlib`` when top-level directory same name as another module of the s... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
pytest-dev__pytest-13073@4dcbbcb | pytest-dev/pytest | Python | 13,073 | fix #13031: use the concrete id NOTSET for the empty parameter list |
this ensures we dont invoke idfunc with the internal NOTSET enum token
closes #13031
<!--
Thanks for submitting a PR, your contribution is really appreciated!
Here is a quick checklist that should be present in PRs.
- [X] Include documentation when adding new features.
- [X] Include new tests or update ... | 2024-12-17T15:44:09Z | Parametrizing a test with an empty list calls `ids` callback with the private constant `NOTSET`
I parametrize tests based on a user-provided list. Sometimes this list is empty, which disables some tests as a result. However, I would expect the `ids` callback that I provide to not be called at all in that case, but it i... | For empty id lists we generate a single test with a warning
Yes, which is reasonable - but I can't detect this in my ID mapping function because it's a hidden type. Perhaps the sentinel can just be exported? Or don't call the ID map for the "no parametrization" case.
I can make a PR in either case!
https://github.c... | [
{
"body": "I parametrize tests based on a user-provided list. Sometimes this list is empty, which disables some tests as a result. However, I would expect the `ids` callback that I provide to not be called at all in that case, but it is actually called with the private `NOTSET` sentinel. As this is not exported... | 868e1d225e443984a6aa29cfde2d1231eb03ed41 | {
"head_commit": "4dcbbcb824423932c600081f2a4b396f2c8a2a5f",
"head_commit_message": "fix #13031: use the concrete id NOTSET for the empty parameter list stand-in\n\nthis ensures we dont invoke idfunc with the internal NOTSET enum token",
"patch_to_review": "diff --git a/changelog/13031.improvement.rst b/changelog... | [
{
"diff_hunk": "@@ -0,0 +1,2 @@\n+``pytest.mark.parametrize([], idfunc=...)`` will no longer trigger a call to ``idfunc`` with internal objects.",
"line": null,
"original_line": 1,
"original_start_line": null,
"path": "changelog/13031.improvement.rst",
"start_line": null,
"text": "@user1... | 48ac422aa314456a8972a0f1b6c5143ed4e405ef | diff --git a/changelog/13031.improvement.rst b/changelog/13031.improvement.rst
new file mode 100644
index 00000000000..c6c64c4673a
--- /dev/null
+++ b/changelog/13031.improvement.rst
@@ -0,0 +1 @@
+An empty parameter set as in ``pytest.mark.parametrize([], ids=idfunc)`` will no longer trigger a call to ``idfunc`` with ... | {
"difficulty": "low",
"estimated_review_effort": 3,
"problem_domain": "Test Suite / CI Enhancements"
} |
pytest-dev__pytest-13124@42b50b4 | pytest-dev/pytest | Python | 13,124 | Fixed invalid regex handling in filterwarnings | <!--
Thanks for submitting a PR, your contribution is really appreciated!
Here is a quick checklist that should be present in PRs.
- [ ] Include documentation when adding new features.
- [ ] Include new tests or update existing tests when applicable.
- [X] Allow maintainers to push and squash when merging my c... | 2025-01-11T12:00:29Z | config option filterwarnings ignore::DeprecationWarning:* crashes with regex exception: PatternError
Since Python3.13 upgrade there are many deprecation warnings from packages. These are not my concern, I'm sure the maintainers will sort things out by the time they need to. If they don't it won't be a warning and I'll ... | You're asking for modules matching the regex `r"*"` this regex is invalid because of the reasons in the traceback.
You should simply omit the module to match any:
```ini
filterwarnings = ignore::DeprecationWarning
```
The invalid pattern is clearly an user error and shouldn't just magically work, but I agree th... | [
{
"body": "Since Python3.13 upgrade there are many deprecation warnings from packages. These are not my concern, I'm sure the maintainers will sort things out by the time they need to. If they don't it won't be a warning and I'll see the error.\r\n\r\nFound a number of forum posts on how to suppress Deprecatio... | 2f369848ea0ead42182efc77000a5ecef629a0ba | {
"head_commit": "42b50b452049c6202bbf7cf55d8ba094c5b9d51f",
"head_commit_message": "[pre-commit.ci] auto fixes from pre-commit.com hooks\n\nfor more information, see https://pre-commit.ci",
"patch_to_review": "diff --git a/src/_pytest/config/__init__.py b/src/_pytest/config/__init__.py\nindex 0161f5952b8..fd14dc... | [
{
"diff_hunk": "@@ -1953,6 +1953,11 @@ def parse_warning_filter(\n ) from None\n else:\n lineno = 0\n+ try:\n+ re.compile(message)\n+ re.compile(module)\n+ except re.error as e:\n+ raise UsageError(error_template.format(error=f\"invalid regex: {e}\"))",
"li... | 49f0dff702ca181511313358a115024c3b21d7ed | diff --git a/changelog/13119.bugfix.rst b/changelog/13119.bugfix.rst
new file mode 100644
index 00000000000..b7e56af9bb8
--- /dev/null
+++ b/changelog/13119.bugfix.rst
@@ -0,0 +1 @@
+Improved handling of invalid regex patterns for filter warnings by providing a clear error message.
diff --git a/src/_pytest/config/__ini... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
pwndbg__pwndbg-2428@a379be7 | pwndbg/pwndbg | Python | 2,428 | Fix attachp crash in tests | This fixes #2144. When running the `attachp` tests locally (with `echo 0 | sudo tee /proc/sys/kernel/yama/ptrace_scope` to enable the tests), they would unexpectedly background the process and cause the testing to halt.
The tests currently causes two parallel bash session to exist, and the tests make sure that runni... | 2024-09-13T03:27:04Z | Issue running attachp gdb-tests
I don't know why this isn't showing up on CI, but for months now I haven't been able to run `./tests.sh` locally without the process being backgrounded and stopped. I can consistently reproduce with:
```
~/code/pwndbg attachp-tests* ... | [
{
"body": "I don't know why this isn't showing up on CI, but for months now I haven't been able to run `./tests.sh` locally without the process being backgrounded and stopped. I can consistently reproduce with:\r\n\r\n```\r\n~/code/pwndbg attachp-tests* ... | 5d95e98c78265a4c47813101809eb9cb4b9a8d15 | {
"head_commit": "a379be7e14da5bc3ba474ee9654c4f4d3cb92569",
"head_commit_message": "Replace bash with sleep in attachp commands to fix crash due to reading from terminal",
"patch_to_review": "diff --git a/tests/gdb-tests/tests/test_attachp.py b/tests/gdb-tests/tests/test_attachp.py\nindex c4cee17317e..304d5746e8... | [
{
"diff_hunk": "@@ -25,14 +25,18 @@\n \"Test skipped due to inability to attach (needs sudo or sysctl -w kernel.yama.ptrace_scope=0\"\n )\n \n+FLAG = \"1\"\n+DEFAULT_SLEEP = \"10\"\n+\n \n @pytest.fixture\n-def launched_bash_binary():\n+def launched_sleep_binary():\n path = tempfile.mktemp()\n- bash_... | e2e2bd872d34f96333ef0ec1db2bae0d0d4d86e2 | diff --git a/tests/gdb-tests/tests/test_attachp.py b/tests/gdb-tests/tests/test_attachp.py
index c4cee17317e..0a588a45b8b 100644
--- a/tests/gdb-tests/tests/test_attachp.py
+++ b/tests/gdb-tests/tests/test_attachp.py
@@ -25,14 +25,18 @@
"Test skipped due to inability to attach (needs sudo or sysctl -w kernel.yama.... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Test Suite / CI Enhancements"
} | |
pytest-dev__pytest-12975@033120b | pytest-dev/pytest | Python | 12,975 | display single contained exception in excgroups in test summary | fixes #12943
As `ExceptionInfo` still doesn't have proper support for exception groups this continues upon the hacky solution from #10209, modifying the reprcrash as well.
I find this solution ... incredibly hacky and ugly, and am not a fan that n==1 gets handled but not n==2. But conceptually it just gets reall... | 2024-11-18T15:18:01Z | `=== short test summary info ===` messages are not useful for `ExceptionGroup`s
If there is only a single leaf exception, at any depth, I suggest we produce the short summary message _for that leaf exception_, and append `[single exception in an ExceptionGroup]` to the message. | bikeshedding: `[single exception in an ExceptionGroup]` to make it clear it is a single exception, and avoid someone thinking "ok and about the other exceptions in that exception group"?
One problem with appending the `[single exc...]` is it getting lost if the error message is very long and gets truncated, making it i... | [
{
"body": "If there is only a single leaf exception, at any depth, I suggest we produce the short summary message _for that leaf exception_, and append `[single exception in an ExceptionGroup]` to the message.",
"number": 12943,
"title": "`=== short test summary info ===` messages are not useful for `Ex... | 72f17d10d76e5260906c17f279c5fa6bd29b5a8d | {
"head_commit": "033120b6546955b8b430a1f547879dd50a32775c",
"head_commit_message": "add test case for codecov",
"patch_to_review": "diff --git a/changelog/12943.improvement.rst b/changelog/12943.improvement.rst\nnew file mode 100644\nindex 00000000000..eb8ac63650a\n--- /dev/null\n+++ b/changelog/12943.improvemen... | [
{
"diff_hunk": "@@ -589,6 +589,31 @@ def exconly(self, tryshort: bool = False) -> str:\n representation is returned (so 'AssertionError: ' is removed from\n the beginning).\n \"\"\"\n+\n+ def _get_single_subexc(\n+ eg: BaseExceptionGroup[BaseException],\n+ ) -> B... | 6f61360a2b195ad15aba0e09354d662647865846 | diff --git a/changelog/12943.improvement.rst b/changelog/12943.improvement.rst
new file mode 100644
index 00000000000..eb8ac63650a
--- /dev/null
+++ b/changelog/12943.improvement.rst
@@ -0,0 +1 @@
+If a test fails with an exceptiongroup with a single exception, the contained exception will now be displayed in the short... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
pydantic__pydantic-11468@92c01bd | pydantic/pydantic | Python | 11,468 | Improve alias configuration APIs | This PR introduces a few new features and a few changes. They might be easier to digest by checking out this simple API changes snippet:
```py
class ConfigDict:
validate_by_alias: bool = True
serialize_by_alias: bool = False
in v3, serialize_by_alias default should change to True
populate_... | 2025-02-19T19:27:13Z | Unexpected UserWarning when serialize a model with PlainValidator to JSON
### Initial Checks
- [X] I confirm that I'm using Pydantic V2
### Description
When performing json-serialization of a model with a `PlainValidator` on a field of `date` type，there is a `UserWarning` generated by the core which I do not think ... | @hongyuan1306,
Thanks for reporting. This is definitely a bug. Seems like probably in `pydanic-core`.
Almost the same issue with PlainValidator was reported few months ago in #10402 | [
{
"body": "### Initial Checks\n\n- [X] I confirm that I'm using Pydantic V2\n\n### Description\n\nWhen performing json-serialization of a model with a `PlainValidator` on a field of `date` type，there is a `UserWarning` generated by the core which I do not think that it should be raised. \r\n\r\nWith pydantic=... | 52fe6854ec3fd6440c8523c54341acb637ffa258 | {
"head_commit": "92c01bd6d780eac246c96a5de553cad9a80d29dd",
"head_commit_message": "revert third party test change - will fix in another PR",
"patch_to_review": "diff --git a/docs/concepts/alias.md b/docs/concepts/alias.md\nindex 3139e4b99ac..7f7fc5c4cc7 100644\n--- a/docs/concepts/alias.md\n+++ b/docs/concepts/... | [
{
"diff_hunk": "",
"line": null,
"original_line": null,
"original_start_line": null,
"path": "pydantic/mypy.py",
"start_line": null,
"text": "@user1:\nI think you'll have to update the `collect_config()` logic to handle both `validate_by_name` and `populate_by_name`. Mypy does static ana... | ffb5edd9c2fa4c625d6a431b6a093580dd96f240 | diff --git a/docs/concepts/alias.md b/docs/concepts/alias.md
index 3139e4b99ac..20bd701952f 100644
--- a/docs/concepts/alias.md
+++ b/docs/concepts/alias.md
@@ -201,3 +201,227 @@ You may set `alias_priority` on a field to change this behavior:
The same precedence applies to `validation_alias` and `serialization_alia... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
pytest-dev__pytest-12861@0bcdab8 | pytest-dev/pytest | Python | 12,861 | Fix `disable_test_id_escaping_and_forfeit_all_rights_to_community_support` option when using `pytest.param(..., id="...")` | Closes #9037 .
The additional test cases were implemented in almost the same way as the existing similar test cases.
- [X] Include documentation when adding new features.
- [X] Include new tests or update existing tests when applicable.
- [X] Allow maintainers to push and squash when merging my commits. Please un... | 2024-10-07T14:48:28Z | Parametrized tests don't display unicode in ids correctly.
```python
@pytest.mark.parametrize(
"string1", [
pytest.param("test1", id="unicode in id い")
])
def test_unicode_in_param_id(string1:str) -> None:
assert string1 == "test1"
```
running it with `pytest -v test.py` gives me
```
pla... | I just saw this message in the docs, but in 2021 this does not feel reasonable to me anymore. Unicode should have 1st class support everywhere nowadays. Almost anyone using python for business applications needs some level of international text support.
I can understand plugins and OS display issues still being an i... | [
{
"body": "```python\r\n@pytest.mark.parametrize(\r\n \"string1\", [\r\n pytest.param(\"test1\", id=\"unicode in id い\")\r\n])\r\ndef test_unicode_in_param_id(string1:str) -> None:\r\n assert string1 == \"test1\"\r\n\r\n```\r\n\r\nrunning it with `pytest -v test.py` gives me\r\n\r\n```\r\nplatform ... | b451a18cc9db46636bd873e0d8bc7cc71dc818e2 | {
"head_commit": "0bcdab8b49c14ec076084c90729f67859e1cefec",
"head_commit_message": "Update changelog/9037.bugfix.rst\n\nCo-authored-by: Ronny Pfannschmidt <opensource@ronnypfannschmidt.de>",
"patch_to_review": "diff --git a/AUTHORS b/AUTHORS\nindex 1ee868448d4..172ce3cf715 100644\n--- a/AUTHORS\n+++ b/AUTHORS\n@... | [
{
"diff_hunk": "@@ -0,0 +1 @@\n+apply test id escaping opt out as configured by the ``disable_test_id_escaping_and_forfeit_all_rights_to_community_support`` option to ids from ``pytest.param(..., id=\"...\")`` in parametrized tests.",
"line": null,
"original_line": 1,
"original_start_line": null,
... | dbc242932dbd844f689c3c241c46023f47498e62 | diff --git a/AUTHORS b/AUTHORS
index 1ee868448d4..172ce3cf715 100644
--- a/AUTHORS
+++ b/AUTHORS
@@ -406,6 +406,7 @@ Sviatoslav Sydorenko
Sylvain Marié
Tadek Teleżyński
Takafumi Arakaki
+Takumi Otani
Taneli Hukkinen
Tanvi Mehta
Tanya Agarwal
diff --git a/changelog/9037.bugfix.rst b/changelog/9037.bugfix.rst
new f... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Test Suite / CI Enhancements"
} |
pwndbg__pwndbg-2240@bef28ec | pwndbg/pwndbg | Python | 2,240 | Fix caching for pwndbg.gdblib.elf functions | Fixes #2237
Changes two things:
1. Functions in `pwndbg.gdblib.elf` that used to cache on only `start` now cache on both `start` and `objfile`, since changing object files should reload ELF information.
2. Implemented priority event handlers that run before other handlers, so that cache clears will happen before o... | 2024-06-20T17:09:49Z | Incorrect caching on `start` command
### Description
`start` caches the entry breakpoint for too long (I think this is an issue with the caching on `pwndbg.gdblib.elf.entry()` specifically), so if you enable ASLR then `start` twice, the second time won't reset the breakpoint.
### Steps to reproduce
Pick a PIE ... | The `start` command does not cache anything, but it creates a temporary breakpoint on one of the symbols:
https://github.com/pwndbg/pwndbg/blob/6cb96632a4e492a6c943a2a85ea0503b15d35ee4/pwndbg/commands/start.py#L59-L78
It takes the symbol addresses from `pwndbg.gdblib.symbo.address`:
https://github.com/pwndbg/pwndb... | [
{
"body": "### Description\r\n\r\n`start` caches the entry breakpoint for too long (I think this is an issue with the caching on `pwndbg.gdblib.elf.entry()` specifically), so if you enable ASLR then `start` twice, the second time won't reset the breakpoint.\r\n\r\n### Steps to reproduce\r\n\r\nPick a PIE execut... | 6cb96632a4e492a6c943a2a85ea0503b15d35ee4 | {
"head_commit": "bef28ecdee0f7e50ae7b766491114ce1046e5782",
"head_commit_message": "Fix formatting in files",
"patch_to_review": "diff --git a/pwndbg/gdblib/elf.py b/pwndbg/gdblib/elf.py\nindex 1444c8f0ffa..cf588c27f4e 100644\n--- a/pwndbg/gdblib/elf.py\n+++ b/pwndbg/gdblib/elf.py\n@@ -240,7 +240,7 @@ def dump_r... | [
{
"diff_hunk": "@@ -97,7 +100,9 @@ def on_stop(self) -> None:\n objfile_cache: Dict[str, Set[str]] = {}\n \n \n-def connect(func: Callable[P, T], event_handler: Any, name: str = \"\") -> Callable[P, T]:\n+def connect(\n+ func: Callable[P, T], event_handler: Any, name: str = \"\", priority: bool = False",
... | ec52c8264988e1a8833aad8809e43f1b084f3f3b | diff --git a/pwndbg/gdblib/elf.py b/pwndbg/gdblib/elf.py
index 1444c8f0ffa..cf588c27f4e 100644
--- a/pwndbg/gdblib/elf.py
+++ b/pwndbg/gdblib/elf.py
@@ -240,7 +240,7 @@ def dump_relocations_by_section_name(
@pwndbg.gdblib.proc.OnlyWhenRunning
-@pwndbg.lib.cache.cache_until("start")
+@pwndbg.lib.cache.cache_until("... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
pwndbg__pwndbg-2203@40b95c3 | pwndbg/pwndbg | Python | 2,203 | Auto-update dependencies after a git pull | I updated the `gdbinit.py` code which checks for stored hash value, and compares it with current one. Based on the result appropriate `poetry install` command will be executed to install the required dependencies (if any) or completely skipped if the hashes match. I also updated the `setup-dev.sh` so as to add an addit... | 2024-05-31T11:54:58Z | Auto-update dependencies after a `git pull`
After doing a `git pull`, it's possible that there were changes to system dependencies in `setup.sh` or Python dependencies in `pyproject.toml`/`poetry.lock` that need to be updated. If those dependencies don't get updated, things may work fine, or things may break in subtle ... | [
{
"body": "After doing a `git pull`, it's possible that there were changes to system dependencies in `setup.sh` or Python dependencies in `pyproject.toml`/`poetry.lock` that need to be updated. If those dependencies don't get updated, things may work fine, or things may break in subtle and hard to reproduce way... | 20f8fe044c352f805954d3f65acfaf25ccb6facc | {
"head_commit": "40b95c3ffd40ed44b36784300007cf5ead97bf79",
"head_commit_message": "Fixed Linting issues",
"patch_to_review": "diff --git a/gdbinit.py b/gdbinit.py\nindex ca277046dd1..2f770cccd92 100644\n--- a/gdbinit.py\n+++ b/gdbinit.py\n@@ -1,8 +1,10 @@\n from __future__ import annotations\n \n import cProfil... | [
{
"diff_hunk": "@@ -16,8 +18,46 @@\n _start_time = time.time()\n _profiler.enable()\n \n+\n # Get virtualenv's site-packages path\n venv_path = os.environ.get(\"PWNDBG_VENV_PATH\")\n+\n+\n+def calculate_hash(file_path):\n+ return hashlib.file_digest(open(file_path, \"rb\"), \"sha256\").hexdigest()\n+... | e07044e23ecfc947a4563192007f93cf64578f42 | diff --git a/gdbinit.py b/gdbinit.py
index ca277046dd1..16d14fc7034 100644
--- a/gdbinit.py
+++ b/gdbinit.py
@@ -1,8 +1,10 @@
from __future__ import annotations
import cProfile
+import hashlib
import os
import site
+import subprocess
import sys
import time
from glob import glob
@@ -18,9 +20,55 @@
# Get virt... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Dependency Updates & Env Compatibility"
} | |
pydantic__pydantic-11246@1bf52f3 | pydantic/pydantic | Python | 11,246 | Fix various issues with dataclasses and `use_attribute_docstrings` | <!-- Thank you for your contribution! -->
<!-- Unless your change is trivial, please create an issue to discuss the change before creating a PR -->
## Change Summary
Fixes https://github.com/pydantic/pydantic/issues/11243.
Edit post 2.11 release: fixes https://github.com/pydantic/pydantic/issues/11133.
Bes... | 2025-01-09T17:54:31Z | BeforeValidator `func` called twice when input field value is json object in `pydantic.dataclass`
### Initial Checks
- [X] I confirm that I'm using Pydantic V2
### Description
func `_json_to_dict` called twice when pydantic.dataclass A init, first param in is json str, second is dict. But it called right when ... | Are you running this in an interactive terminal? If so, this won't work as described in [the documentation](https://docs.pydantic.dev/latest/api/config/#pydantic.config.ConfigDict.use_attribute_docstrings):
> This requires the source code of the class to be available at runtime.
> Are you running this in an interact... | [
{
"body": "### Initial Checks\r\n\r\n- [X] I confirm that I'm using Pydantic V2\r\n\r\n### Description\r\n\r\nfunc `_json_to_dict` called twice when pydantic.dataclass A init, first param in is json str, second is dict. But it called right when use BaseModel AA.\r\nI added a conditional `if isinstance(data, dic... | 8ef33a0bf51988b4364db14a9732e5eeb0617652 | {
"head_commit": "1bf52f3783fc690dff90c044636df3a1ed000ce0",
"head_commit_message": "Support `use_attribute_docstrings` with stdlib dataclasses",
"patch_to_review": "diff --git a/pydantic/_internal/_fields.py b/pydantic/_internal/_fields.py\nindex 0bbbdd33c2d..7cf61461d4f 100644\n--- a/pydantic/_internal/_fields.... | [
{
"diff_hunk": "@@ -362,6 +366,6 @@ def is_pydantic_dataclass(class_: type[Any], /) -> TypeGuard[type[PydanticDatacl\n `True` if the class is a pydantic dataclass, `False` otherwise.\n \"\"\"\n try:\n- return '__pydantic_validator__' in class_.__dict__ and dataclasses.is_dataclass(class_)... | dbc682597a42db507695a2d4ae46ead4c4324522 | diff --git a/pydantic/_internal/_fields.py b/pydantic/_internal/_fields.py
index 0bbbdd33c2d..55c9eae102f 100644
--- a/pydantic/_internal/_fields.py
+++ b/pydantic/_internal/_fields.py
@@ -64,12 +64,11 @@ def __init__(self, metadata: Any):
return _PydanticGeneralMetadata # type: ignore
-def _update_fields_fro... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
pytest-dev__pytest-12526@7501995 | pytest-dev/pytest | Python | 12,526 | Fixed handling of invalid regex pattern | <!--
Thanks for submitting a PR, your contribution is really appreciated!
Here is a quick checklist that should be present in PRs.
- [X] Include documentation when adding new features.
- [X] Include new tests or update existing tests when applicable.
- [X] Allow maintainers to push and squash when merging my c... | 2024-06-23T20:57:41Z | `pytest.raises` with invalid regex in match kwarg fails with internal `re.error`
<!--
Thanks for submitting an issue!
Quick check-list while reporting bugs:
-->
Using an invalid regex in `pytest.raises` fails in a messy way.
```py
with pytest.raises(ValueError, match="invalid regex character ["):
raise ... | Here's how I would go about this:
- Take the example from above and turn it into a test case
- `testing/python/raises.py` is where the existing tests are for `pytest.raises`
- Since we are mostly interested in the *output* of pytest, a test [using `pytester`](https://doc.pytest.org/en/latest/how-to/writing... | [
{
"body": "<!--\r\nThanks for submitting an issue!\r\n\r\nQuick check-list while reporting bugs:\r\n-->\r\nUsing an invalid regex in `pytest.raises` fails in a messy way. \r\n\r\n```py\r\nwith pytest.raises(ValueError, match=\"invalid regex character [\"):\r\n raise ValueError()\r\n```\r\n\r\n```shell\r\nTra... | f74e947c1fdfef238235b7dd18c8fe52108268f2 | {
"head_commit": "7501995f6c141a9f51242cc72379fcf6d0e258bd",
"head_commit_message": "[pre-commit.ci] auto fixes from pre-commit.com hooks\n\nfor more information, see https://pre-commit.ci",
"patch_to_review": "diff --git a/AUTHORS b/AUTHORS\nindex 5ae80eb02d3..50e44038d4d 100644\n--- a/AUTHORS\n+++ b/AUTHORS\n@@... | [
{
"diff_hunk": "@@ -1006,6 +1007,9 @@ def __exit__(\n # Cast to narrow the exception type now that it's verified.\n exc_info = cast(Tuple[Type[E], E, TracebackType], (exc_type, exc_val, exc_tb))\n self.excinfo.fill_unfilled(exc_info)\n- if self.match_expr is not None:\n- ... | 2e1b09d9ca417f1ec6cc9481e7738b9df660e5a1 | diff --git a/AUTHORS b/AUTHORS
index 5ae80eb02d3..50e44038d4d 100644
--- a/AUTHORS
+++ b/AUTHORS
@@ -429,6 +429,7 @@ Victor Rodriguez
Victor Uriarte
Vidar T. Fauske
Vijay Arora
+Virendra Patil
Virgil Dupras
Vitaly Lashmanov
Vivaan Verma
diff --git a/changelog/12505.bugfix.rst b/changelog/12505.bugfix.rst
new file... | {
"difficulty": "low",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
pwndbg__pwndbg-2075@3d3a319 | pwndbg/pwndbg | Python | 2,075 | show `mypy` errors inline on PRs | <!-- Please make sure to read the testing and linting instructions at https://github.com/pwndbg/pwndbg/blob/dev/DEVELOPING.md before creating a PR -->
fixes #2053
| 2024-03-19T09:52:17Z | Show lint errors as inline annotations in Github PRs
There are Github Actions that can run linters and report any violations inline on the PR itself (similar to the codecov comments we see now). This would be especially useful when we have new contributors who don't know to run the lint script, or struggle with fixing ... | Ruff can automatically do this if we run with `--output-format github`. For `mypy`, we have to use another action: https://github.com/tsuyoshicho/action-mypy
Ruff support was implemented in #2070. Would appreciate it if someone could look into setting this up for `mypy`. | [
{
"body": "There are Github Actions that can run linters and report any violations inline on the PR itself (similar to the codecov comments we see now). This would be especially useful when we have new contributors who don't know to run the lint script, or struggle with fixing an issue. They would see the issue... | 06257f2f3f67495d7ac6e5bea7d7a862b9296714 | {
"head_commit": "3d3a31931277f5cf18eb299001b23ee4e233e405",
"head_commit_message": "Update .github/workflows/lint.yml\n\nCo-authored-by: intrigus-lgtm <60750685+intrigus-lgtm@users.noreply.github.com>",
"patch_to_review": "diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml\nindex 3e6cabc05dd..e... | [
{
"diff_hunk": "@@ -32,3 +32,17 @@ jobs:\n run: |\n git diff-index --quiet HEAD -- pwndbg tests\n ./lint.sh\n+ \n+ - name: Run mypy\n+ uses: tsuyoshicho/action-mypy@v4\n+ with:\n+ github_token: ${{ secrets.GITHUB_TOKEN }}\n+ # Change reviewdog reporter if ... | a57de95db6c3791c0d533dca4993b6b236b92228 | diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml
index 3e6cabc05dd..d7db03c05e4 100644
--- a/.github/workflows/lint.yml
+++ b/.github/workflows/lint.yml
@@ -32,3 +32,21 @@ jobs:
run: |
git diff-index --quiet HEAD -- pwndbg tests
./lint.sh
+
+ - name: Run mypy
+ ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Code Style, Linting, Formatting Fixes"
} |
pwndbg__pwndbg-1971@5033818 | pwndbg/pwndbg | Python | 1,971 | Add a command that tracks function calls through the Global Offset Table | Fixes: #1958
This PR adds a command (`enable-got-tracking`) that allows users to track and collect information about accesses made to dynamically linked functions, by analyzing the instances of a Global Offset Table (GOT) present in the running process's memory space.
## Functioning
Seeing as GDB has little to n... | 2023-12-29T02:36:12Z | Support tracking function calls made through the PLT/GOT
## Motivation
When analyzing the behavior of dynamically linked programs, it's often interesting to know which parts of it interact with functions provided by library code[^1], as well as if the entry points to these external functions may be changed in some way... | I plan to have a PR up, or at least a draft, implementing this, in a few days at most.
Interestingly, even the existing implementation in `pwndbg/commands/got.py`, that goes out of its way to support cases where the `vmmap` is invalid - specifically mentioning QEMU -, will still break if QEMU reports a `vmmap` where no... | [
{
"body": "## Motivation\r\nWhen analyzing the behavior of dynamically linked programs, it's often interesting to know which parts of it interact with functions provided by library code[^1], as well as if the entry points to these external functions may be changed in some way. For many binaries, especially thos... | c4b71af3568f8998d9a7a5048dcf947c723fcc2e | {
"head_commit": "50338186ad57d2f8ec59587a69d5713f1ad782df",
"head_commit_message": "Disable broken r_brk hooks, for now.",
"patch_to_review": "diff --git a/pwndbg/commands/__init__.py b/pwndbg/commands/__init__.py\nindex ae3f5623906..5bfd0dbff0d 100644\n--- a/pwndbg/commands/__init__.py\n+++ b/pwndbg/commands/__... | [
{
"diff_hunk": "@@ -0,0 +1,237 @@\n+from __future__ import annotations\n+\n+import argparse\n+import re\n+\n+import pwndbg.color.message as message\n+import pwndbg.gdblib.dynamic\n+import pwndbg.gdblib.got\n+import pwndbg.gdblib.proc\n+from pwndbg.commands import CommandCategory\n+\n+\n+def columns(rows, colors... | 77de53140b7ccee64bf5260363e42c5fcdb35b84 | diff --git a/pwndbg/commands/__init__.py b/pwndbg/commands/__init__.py
index ae3f5623906..5bfd0dbff0d 100644
--- a/pwndbg/commands/__init__.py
+++ b/pwndbg/commands/__init__.py
@@ -626,6 +626,7 @@ def load_commands() -> None:
import pwndbg.commands.flags
import pwndbg.commands.ghidra
import pwndbg.comman... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
pwndbg__pwndbg-1914@5756842 | pwndbg/pwndbg | Python | 1,914 | Enhance thread context | This PR makes the following changes to the "threads" section of the `context` command's output:
* Add total thread count to banner
* Limit number of threads displayed
* Add `context-max-threads` config variable
* No longer attempt to get frames from running threads (causes an error)
Old behaviour:
![ctx-threads... | 2023-10-04T20:41:59Z | Enhance thread context
The thread context can be improved so that:
1. It shows the number of all threads in the top bar e..g `[ THREADS (20) ]`
2. It limits the number of displayed threads via some config variable
* When there are more threads then the limit, it should display current thread and other threads up to ... | Impl details:
* https://github.com/pwndbg/pwndbg/blob/dev/pwndbg/commands/context.py#L853-L897
* https://github.com/pwndbg/pwndbg/blob/dev/pwndbg/commands/context.py#L620C5-L627
Any objections to using the tabulate library to display this information?
Nope, it probably makes sense to use it | [
{
"body": "The thread context can be improved so that:\r\n1. It shows the number of all threads in the top bar e..g `[ THREADS (20) ]`\r\n2. It limits the number of displayed threads via some config variable\r\n* When there are more threads then the limit, it should display current thread and other threads up t... | 72ab4aa5e873e7799f50b589acc72f671ede9469 | {
"head_commit": "5756842114eeaf3503077794d5e31d831540fcb0",
"head_commit_message": "Add context-max-threads config\n\nChange the number of threads displayed by the `context` command.\nUse `set context-max-threads` to change this value, defaults to 4.\nAdd a total threads count to the banner.",
"patch_to_review":... | [
{
"diff_hunk": "@@ -851,48 +856,57 @@ def get_thread_status(thread):\n \n \n def context_threads(with_banner=True, target=sys.stdout, width=None):\n- threads = gdb.selected_inferior().threads()[::-1]\n+ all_threads = gdb.selected_inferior().threads()[::-1]\n+ displayed_threads = all_threads[: int(confi... | 87fdd247b7e8578e036a2dbba3f12044fe4325da | diff --git a/pwndbg/commands/context.py b/pwndbg/commands/context.py
index 82f23715805..014ada69c69 100644
--- a/pwndbg/commands/context.py
+++ b/pwndbg/commands/context.py
@@ -81,6 +81,11 @@ def clear_screen(out=sys.stdout) -> None:
"regs disasm code ghidra stack backtrace expressions threads",
"which contex... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
pytest-dev__pytest-12220@f14d78d | pytest-dev/pytest | Python | 12,220 | Changed importError to ModuleNotFoundError | Closes #11523
Changed ImportError to ModuleNotFoundError in importorskip()`` | 2024-04-16T14:34:35Z | importorskip variant that uses ModuleNotFoundError
<!--
Thanks for suggesting a feature!
Quick check-list while suggesting features:
-->
#### What's the problem this feature will solve?
sometimes I install a package eg PyTables and it fails to compile properly and fails with an ImportError with an undefined sy... | Hey @graingert thanks for the proposal.
> a new kwarg to importorskip or a new function that catches ModuleNotFoundError instead of ImportError eg
importorskip(exc=ModuleNotFoundError) or findmoduleorskip(...)
I personally like `importorskip(exc=ModuleNotFoundError)` 👍
i think it would be very nice if a requir... | [
{
"body": "<!--\r\nThanks for suggesting a feature!\r\n\r\nQuick check-list while suggesting features:\r\n-->\r\n\r\n#### What's the problem this feature will solve?\r\nsometimes I install a package eg PyTables and it fails to compile properly and fails with an ImportError with an undefined symbol, however I do... | fafab1dbfd2414c2282b558f0c7af9a7ad0318ab | {
"head_commit": "f14d78dbef8c682fc1195dfee45cfebce91d7ca9",
"head_commit_message": "Change exc_type to kw only",
"patch_to_review": "diff --git a/changelog/11523.improvement.rst b/changelog/11523.improvement.rst\nnew file mode 100644\nindex 00000000000..f7d8ff89df6\n--- /dev/null\n+++ b/changelog/11523.improveme... | [
{
"diff_hunk": "@@ -205,30 +211,81 @@ def importorskip(\n :param reason:\n If given, this reason is shown as the message when the module cannot\n be imported.\n+ :param exc_type:\n+ The exception that should be captured in order to skip modules.\n+ Must be :py:class:`ImportE... | a55abeb053ced0b215ab96ef8fdece0dd26f5d9d | diff --git a/changelog/11523.improvement.rst b/changelog/11523.improvement.rst
new file mode 100644
index 00000000000..f7d8ff89df6
--- /dev/null
+++ b/changelog/11523.improvement.rst
@@ -0,0 +1,5 @@
+:func:`pytest.importorskip` will now issue a warning if the module could be found, but raised :class:`ImportError` inste... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
pwndbg__pwndbg-1779@653ad88 | pwndbg/pwndbg | Python | 1,779 | ` telescope -r` should always display the input address #1240 | Fixed #1240
```
pwndbg> telescope -r $rsp
00:0000│ 0x7fffffffd838 —▸ 0x7ffff7e4182a (malloc+410) ◂— test rax, rax
01:0008│ 0x7fffffffd840 ◂— 0x100
02:0010│ 0x7fffffffd848 ◂— 0x140000
03:0018│ 0x7fffffffd850 —▸ 0x7fffffffda38 —▸ 0x7fffffffde6f ◂— '/home/<user>/Projects/pwndbg_test/b.out'
04:0020│... | 2023-07-04T20:29:01Z | `telescope -r` should always display the input address
`telescope -r addr` will skip displaying `addr` if the value at that address is equal to the previous few values:
```
pwndbg> p &target_address
$1 = (unsigned long *) 0x5555555582a0 <target_address>
pwndbg> telescope -r &target_address
00:0000│ 0x555555558... | I found that telescope behaves strangely if `set history remove-duplicates unlimited`.
The `check_repeated` depends on the history of gdb.
https://github.com/pwndbg/pwndbg/blob/e456b317d7d9c3767ebf45b907d31178c3418d3e/pwndbg/commands/__init__.py#L113-L148
If `remove-duplicates` is set, the `check_repeated` is n... | [
{
"body": "`telescope -r addr` will skip displaying `addr` if the value at that address is equal to the previous few values:\r\n```\r\npwndbg> p &target_address\r\n$1 = (unsigned long *) 0x5555555582a0 <target_address>\r\npwndbg> telescope -r &target_address\r\n00:0000│ 0x555555558208 (buf+360) ◂— 0x0\r\n..... | fc083b9865bab64c742ff42fca5a5e17d93b9a69 | {
"head_commit": "653ad8872d42e14a05d2f6eb9eeda756f000fd09",
"head_commit_message": "Fixed linters",
"patch_to_review": "diff --git a/pwndbg/commands/telescope.py b/pwndbg/commands/telescope.py\nindex 928a0650170..0bee311ae54 100644\n--- a/pwndbg/commands/telescope.py\n+++ b/pwndbg/commands/telescope.py\n@@ -81,6... | [
{
"diff_hunk": "@@ -82,3 +82,22 @@ def test_telescope_command_with_address_as_count_and_reversed_flag(start_binary)\n rsp = pwndbg.gdblib.regs.rsp\n \n assert out == [\"00:0000│ %#x ◂— 0x0\" % (rsp - 8), \"01:0008│ rsp %#x ◂— 0x1\" % rsp]\n+\n+\n+def test_command_telescope_reverse_skipped_records_sh... | ff484947d967f3bd2fadc0d4db3a404cb5a05148 | diff --git a/pwndbg/commands/telescope.py b/pwndbg/commands/telescope.py
index 928a0650170..0bee311ae54 100644
--- a/pwndbg/commands/telescope.py
+++ b/pwndbg/commands/telescope.py
@@ -81,6 +81,7 @@ def telescope(address=None, count=telescope_lines, to_string=False, reverse=Fals
telescope.offset = 0
add... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
pydantic__pydantic-11085@9ff54ad | pydantic/pydantic | Python | 11,085 | Include JSON Schema input core schema in function schemas | <!-- Thank you for your contribution! -->
<!-- Unless your change is trivial, please create an issue to discuss the change before creating a PR -->
## Change Summary
Partly fixes https://github.com/pydantic/pydantic/issues/11033.
Requires https://github.com/pydantic/pydantic-core/pull/1572
<!-- Please give a... | 2024-12-10T20:36:05Z | JSON Schema gen chokes on `BeforeValidator` with a union in the `json_schema_input_type`
### Initial Checks
- [X] I confirm that I'm using Pydantic V2
### Description
Using a `BeforeValidator` with a union type (see `example.py` below) results in :
```
Traceback (most recent call last):
...
File "/<...>/.ven... | I suspect this may be related to https://github.com/pydantic/pydantic/blob/aee6057378ccfec02126bf9c984a9b6d6b411777/pydantic/functional_validators.py#L130
(maybe it doesn't handle more complex schemas?)
cc @Viicos
Oh yeah the `input_schema` is `{'type': 'union', 'choices': [{'type': 'definition-ref', 'schema_ref': '... | [
{
"body": "### Initial Checks\n\n- [X] I confirm that I'm using Pydantic V2\n\n### Description\n\nUsing a `BeforeValidator` with a union type (see `example.py` below) results in :\r\n\r\n```\r\nTraceback (most recent call last):\r\n...\r\n File \"/<...>/.venv/lib/python3.11/site-packages/pydantic/json_schema.p... | d8b610c73f186e7a824b075e345dcdf1c0bb2c0c | {
"head_commit": "9ff54adb43f74a5eea747f0296ee0ba1a108ba8d",
"head_commit_message": "Merge branch 'main' into js-input-type-in-cs",
"patch_to_review": "diff --git a/pydantic/_internal/_core_metadata.py b/pydantic/_internal/_core_metadata.py\nindex c8d452443cb..89e3e78833c 100644\n--- a/pydantic/_internal/_core_me... | [
{
"diff_hunk": "@@ -176,6 +176,9 @@ markers = [\n [tool.uv]\n default-groups = ['dev']\n \n+[tool.uv.sources]\n+pydantic-core = { git = \"https://github.com/pydantic/pydantic-core\", branch = \"js-input-type-in-cs\" }\n+",
"line": null,
"original_line": 181,
"original_start_line": 179,
"path": "... | 008f6d9ddfb5b04f85ed318a88eb59cd6ced52a6 | diff --git a/pydantic/_internal/_core_metadata.py b/pydantic/_internal/_core_metadata.py
index c8d452443cb..89e3e78833c 100644
--- a/pydantic/_internal/_core_metadata.py
+++ b/pydantic/_internal/_core_metadata.py
@@ -4,8 +4,6 @@
from warnings import warn
if TYPE_CHECKING:
- from pydantic_core import CoreSchema
-... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
pwndbg__pwndbg-1709@f4483a2 | pwndbg/pwndbg | Python | 1,709 | Updated version.py for bugreport command to display more information | <!-- Please make sure to read the testing and linting instructions at https://github.com/pwndbg/pwndbg/blob/dev/DEVELOPING.md before creating a PR -->
The Bug Report Command now displays:
- osabi
- architecture
- endian
- charset
- width
- height
Depending on current arch -- note that those are only avail... | 2023-05-13T09:32:04Z | bugreport command: show more info
The bugreport command should display more information like:
* show osabi
* show architecture
* show endian
Depending on current arch -- note that those are only available if given arch is supported by current GDB, like `gdb-multiarch`:
* show arm
* show mips
Maybe also:
* s... | Hi, how to get involved in pwndbg project as a newcomer ?
Hi, just [send a pull request with a change that you want implemented](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request).
You can also use `rip grep`/`grep`/g... | [
{
"body": "The bugreport command should display more information like:\r\n* show osabi\r\n* show architecture\r\n* show endian\r\n\r\nDepending on current arch -- note that those are only available if given arch is supported by current GDB, like `gdb-multiarch`:\r\n* show arm\r\n* show mips\r\n\r\nMaybe also:\r... | f402732a333e4fe67494789e9b27d1dfa6f4200d | {
"head_commit": "f4483a223185bce40ef99db05fa4ba30886d6649",
"head_commit_message": "Update version.py",
"patch_to_review": "diff --git a/pwndbg/commands/version.py b/pwndbg/commands/version.py\nindex 81997b813df..bbbebc03f66 100644\n--- a/pwndbg/commands/version.py\n+++ b/pwndbg/commands/version.py\n@@ -157,6 +1... | [
{
"diff_hunk": "@@ -157,6 +157,40 @@ def bugreport(run_browser=False, use_gh=False):\n os_info = match.group(1)\n \n current_setup += \"OS: %s\\n\" % os_info\n+\n+ # 1. showing osabi\n+ osabi_info = platform.uname().version\n+ current_setup += \"OS ABI: %s\\n\" % osabi_info\n+\n+ ... | 708b07046263fcc5039464714b30bb34e75024dd | diff --git a/pwndbg/commands/version.py b/pwndbg/commands/version.py
index 81997b813df..0e598f6117d 100644
--- a/pwndbg/commands/version.py
+++ b/pwndbg/commands/version.py
@@ -157,6 +157,40 @@ def bugreport(run_browser=False, use_gh=False):
os_info = match.group(1)
current_setup += "OS: %s\n" %... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
pydantic__pydantic-10922@0187b9f | pydantic/pydantic | Python | 10,922 | Fix url constraint application | Fix https://github.com/pydantic/pydantic/issues/10914 | 2024-11-21T12:01:50Z | 2.10: URL types issues (application of constraints)
### Initial Checks
- [X] I confirm that I'm using Pydantic V2
### Description
Pydantic v2.10 has issues with Url types and AfterValidators (see example below)
```
tests/security/keycloak/test_config.py:None (tests/security/keycloak/test_config.py)
tests/securi... | I'm pretty sure now that the issue comes down to this construct:
```python
from typing import Annotated
from pydantic import AnyUrl, UrlConstraints, StringConstraints, AfterValidator, TypeAdapter
from pydantic.experimental.pipeline import validate_as
# not working anymore
FQHttpsUrlBroken = Annotated[AnyUrl... | [
{
"body": "### Initial Checks\n\n- [X] I confirm that I'm using Pydantic V2\n\n### Description\n\nPydantic v2.10 has issues with Url types and AfterValidators (see example below)\r\n\r\n```\r\ntests/security/keycloak/test_config.py:None (tests/security/keycloak/test_config.py)\r\ntests/security/keycloak/test_co... | a5d5c237fe99f24d32afbb591e17c876ab258d98 | {
"head_commit": "0187b9f03c5bf9ebc654a22929749596371fa85e",
"head_commit_message": "add tests",
"patch_to_review": "diff --git a/pydantic/networks.py b/pydantic/networks.py\nindex 33799578c06..3cca666b9ef 100644\n--- a/pydantic/networks.py\n+++ b/pydantic/networks.py\n@@ -17,7 +17,7 @@\n \n from pydantic.errors ... | [
{
"diff_hunk": "@@ -96,7 +96,31 @@ def __hash__(self) -> int:\n @property\n def defined_constraints(self) -> dict[str, Any]:\n \"\"\"Fetch a key / value mapping of constraints to values that are not None. Used for core schema updates.\"\"\"\n- return {field.name: getattr(self, field.name)... | 21b240147312b2e30f72b09867f2cdae246067a7 | diff --git a/pydantic/networks.py b/pydantic/networks.py
index 33799578c06..a33accf2260 100644
--- a/pydantic/networks.py
+++ b/pydantic/networks.py
@@ -17,7 +17,7 @@
from pydantic.errors import PydanticUserError
-from ._internal import _fields, _repr, _schema_generation_shared
+from ._internal import _repr, _sche... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
pytest-dev__pytest-11833@007d24a | pytest-dev/pytest | Python | 11,833 | Don't add fixture finalizer if the value is cached | Fixes #1489 - see https://github.com/pytest-dev/pytest/issues/1489#issuecomment-1894057766 for explanation of current behavior.
It's possible this might break test setups that (inadvertently) relies on the teardown order being as it is, but I think it's an improvement on the status quo.
The code for setup & teard... | 2024-01-17T15:30:42Z | fixture finalizer dependency incorrect when using autouse or getfuncargvalue
Calling fixture finalizers in the correct order works by dependent fixtures registering their finalizer in their dependency (see python.FixtureDef.execute+10).
However, this only happens for fixtures explicitly requested in args, not for auto... | Hi @amosonn,
Thanks for taking the time to write down this report.
(I edited your post to add syntax highlight to your examples to make them easier to read, hope you don't mind).
I thought I could use autouse fixtures to do some setup and teardown, but since the teardown part is not garanteed to come after the tear... | [
{
"body": "Calling fixture finalizers in the correct order works by dependent fixtures registering their finalizer in their dependency (see python.FixtureDef.execute+10).\r\nHowever, this only happens for fixtures explicitly requested in args, not for autouse or getfuncargvalue fixtures.\r\nThis code:\r\n\r\n``... | c203f1615cb2bc3f80d973333d3af9005894abd9 | {
"head_commit": "007d24a6faaa4e3eb8f4a7bc981093c2d7ce631a",
"head_commit_message": "improve comment getfixturevalue, move test_scoped_fixture_teardown_order to testing/python/fixtures.py",
"patch_to_review": "diff --git a/changelog/1489.bugfix.rst b/changelog/1489.bugfix.rst\nnew file mode 100644\nindex 00000000... | [
{
"diff_hunk": "@@ -4559,3 +4559,134 @@ def test_deduplicate_names() -> None:\n assert items == (\"a\", \"b\", \"c\", \"d\")\n items = deduplicate_names((*items, \"g\", \"f\", \"g\", \"e\", \"b\"))\n assert items == (\"a\", \"b\", \"c\", \"d\", \"g\", \"f\", \"e\")\n+\n+\n+def test_scoped_fixture_te... | 13d104948ae2af443d1d705b22cd567f835a3feb | diff --git a/changelog/1489.bugfix.rst b/changelog/1489.bugfix.rst
new file mode 100644
index 00000000000..70c5dd1252e
--- /dev/null
+++ b/changelog/1489.bugfix.rst
@@ -0,0 +1 @@
+Fix some instances where teardown of higher-scoped fixtures was not happening in the reverse order they were initialized in.
diff --git a/sr... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
pydantic__pydantic-10911@db356d0 | pydantic/pydantic | Python | 10,911 | Fix type checking issue with `model_fields` and `model_computed_fields` | Fix https://github.com/pydantic/pydantic/issues/10907 | 2024-11-20T23:17:20Z | 2.10: Type checking error on `model_fields` and `model_computed_fields` with mypy
### Initial Checks
- [X] I confirm that I'm using Pydantic V2
### Description
Using pydantic<2.10.0, mypy correctly accepts using `MyModel.model_fields.keys()`. With pydantic 2.10.0, I get this error: `error: "Callable[[BaseModel... | Huh, not able to repro with `pyright`.
Will look into a fix, thanks for the report!
This is odd bc:
```py
@property
def model_fields(self) -> dict[str, FieldInfo]:
"""Get metadata about the fields defined on the model.
Deprecation warning: you should be getting this information from ... | [
{
"body": "### Initial Checks\r\n\r\n- [X] I confirm that I'm using Pydantic V2\r\n\r\n### Description\r\n\r\nUsing pydantic<2.10.0, mypy correctly accepts using `MyModel.model_fields.keys()`. With pydantic 2.10.0, I get this error: `error: \"Callable[[BaseModel], dict[str, FieldInfo]]\" has no attribute \"keys... | a5d5c237fe99f24d32afbb591e17c876ab258d98 | {
"head_commit": "db356d0f8c81cf5347eacb095c70a1cc8ad7c211",
"head_commit_message": "adding type checking tests",
"patch_to_review": "diff --git a/pydantic/main.py b/pydantic/main.py\nindex bd9a92075c7..4aa8c96b1f0 100644\n--- a/pydantic/main.py\n+++ b/pydantic/main.py\n@@ -240,34 +240,39 @@ def __init__(self, /,... | [
{
"diff_hunk": "@@ -28,3 +28,6 @@ class Knight(BaseModel):\n \n \n k = Knight() # type: ignore[call-arg] # pyright: ignore[reportCallIssue]\n+\n+MyModel.model_fields.keys()\n+MyModel.model_computed_fields.keys()",
"line": null,
"original_line": 33,
"original_start_line": 32,
"path": "tests/typ... | 60522afab852b791ed198ec2966d384aca312a31 | diff --git a/pydantic/main.py b/pydantic/main.py
index bd9a92075c7..4aa8c96b1f0 100644
--- a/pydantic/main.py
+++ b/pydantic/main.py
@@ -240,34 +240,39 @@ def __init__(self, /, **data: Any) -> None:
# The following line sets a flag that we use to determine when `__init__` gets overridden by the user
__init__.... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
pydantic__pydantic-10868@3a285fd | pydantic/pydantic | Python | 10,868 | Improve `__setattr__` performance of Pydantic models by caching setter functions | ## Change Summary
Attribute setting has been pretty slow for `BaseModel` due to the extensive checks it has been doing for every `__setattr__` call. PR improves performance of `__setattr__` by memoizing the attribute specific handlers to the model class. This makes the attribute assigning some 7x faster. Also add mi... | 2024-11-18T13:06:01Z | Slow setting an value of a basic Model
### Initial Checks
- [X] I confirm that I'm using Pydantic V2
### Description
Comparing times between instantiating a complete yet simple model and just setting one value of that same model is weird.
Instantiating is 2 times faster than just setting the value.
Here are the ... | Yes, I have also seen this. It is because `__setattr__` does large amount of checks every time for normal attribute setting before actually setting the value [here](https://github.com/pydantic/pydantic/blob/0157e343bac2313064492744ef07493b5c42bd5b/pydantic/main.py#L938). The data validation works a bit differently henc... | [
{
"body": "### Initial Checks\n\n- [X] I confirm that I'm using Pydantic V2\n\n### Description\n\nComparing times between instantiating a complete yet simple model and just setting one value of that same model is weird.\r\nInstantiating is 2 times faster than just setting the value.\r\n\r\nHere are the results ... | 30ee4f41a1277360d1cc68de14ffca44e89bba79 | {
"head_commit": "3a285fdf8dfba9b3297e55f237b982516d5f0cea",
"head_commit_message": "fast setattr",
"patch_to_review": "diff --git a/pydantic/_internal/_model_construction.py b/pydantic/_internal/_model_construction.py\nindex a0c2ecf9cf6..35bd6089cb1 100644\n--- a/pydantic/_internal/_model_construction.py\n+++ b/... | [
{
"diff_hunk": "@@ -890,53 +893,64 @@ def __getattr__(self, item: str) -> Any:\n raise AttributeError(f'{type(self).__name__!r} object has no attribute {item!r}')\n \n def __setattr__(self, name: str, value: Any) -> None:\n- if name in self.__class_vars__:\n+ ... | 404b8b703c22b63c48c6c08957dced5fd1df8c6e | diff --git a/pydantic/_internal/_model_construction.py b/pydantic/_internal/_model_construction.py
index a0c2ecf9cf6..35bd6089cb1 100644
--- a/pydantic/_internal/_model_construction.py
+++ b/pydantic/_internal/_model_construction.py
@@ -152,6 +152,8 @@ def wrapped_model_post_init(self: BaseModel, context: Any, /) -> No... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Performance Optimizations"
} |
pytest-dev__pytest-11594@bf3f655 | pytest-dev/pytest | Python | 11,594 | Sanitize ini-options default handling #11282 | **Overview**
This PR fixes #11282. As per the issue, if an option is created with default value as None and a value for the option is not set in the ini file, then trying to get the option value in code with config.getini() returns an empty list [] instead of None as expected.
**Analysis**
On investigating it was ... | 2023-11-07T13:01:20Z | config.getini returns an empty list for an option of type string absent in INI file
I want to manage this INI option
```
parser.addini(
"my_option",
type="string",
default=None,
help="My option",
)
```
I decide not to include this option in the INI file
I read the ... | Here is an actual reproducer:
`conftest.py`:
```python
import pytest
def pytest_addoption(parser):
parser.addini(
"my_option",
type="string",
default=None,
help="My option",
)
@pytest.fixture(scope='session')
def my_option(request):
return request.config.... | [
{
"body": "I want to manage this INI option \r\n```\r\n parser.addini(\r\n \"my_option\",\r\n type=\"string\",\r\n default=None,\r\n help=\"My option\",\r\n )\r\n```\r\n\r\nI decide not to include this option in the INI file\r\n\r\nI read the value with this code\r\n\r\n```\r\n... | e701df5eb6645c0aaaab385e28f6ecf98b692a31 | {
"head_commit": "bf3f655437147a5aa561d0101f05c4094ce62f67",
"head_commit_message": "Issue 11282 removed unwanted code to fix coverage",
"patch_to_review": "diff --git a/changelog/11282.bugfix.rst b/changelog/11282.bugfix.rst\nnew file mode 100644\nindex 00000000000..7884405f0dc\n--- /dev/null\n+++ b/changelog/11... | [
{
"diff_hunk": "@@ -27,6 +27,14 @@\n FILE_OR_DIR = \"file_or_dir\"\n \n \n+class Notset:\n+ def __repr__(self) -> str:\n+ return \"<notset>\"\n+\n+\n+notset = Notset()",
"line": null,
"original_line": 35,
"original_start_line": 30,
"path": "src/_pytest/config/argparsing.py",
"start... | 4a7856e829efc4319ff9e20d7c69f41766e67ea9 | diff --git a/changelog/11282.breaking.rst b/changelog/11282.breaking.rst
new file mode 100644
index 00000000000..cee9788ef1c
--- /dev/null
+++ b/changelog/11282.breaking.rst
@@ -0,0 +1,11 @@
+Sanitized the handling of the ``default`` parameter when defining configuration options.
+
+Previously if ``default`` was not su... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
pytest-dev__pytest-11489@0537455 | pytest-dev/pytest | Python | 11,489 | Duplicated parameters in parametrize marker | ## Problem Statement
**What's the problem this feature will solve?**
The current behavior of pytest in handling duplicated values in parametrize can lead to confusion regarding the actual parameter values used in tests. This PR aims to address this issue by providing clear and unambiguous parameter identifiers.
... | 2023-10-08T11:30:57Z | Duplicated parameters in @pytest.mark.parametrize
#### What's the problem this feature will solve?
Make unambigious what the values of the parameters used from parametrize are.
#### Describe the solution you'd like
When duplicated values are used in parametrize, pytest adds a number after each duplicated value, s... | I made a typing mistake: the function definition
is not def test_a(a):
but def test_params(a):
Hi @Zac-HD, I would like to pick this issue.
Sure, go ahead! I think there are some open questions about what we _should_ do here though, so I'd suggest writing up some design notes here before opening a pull request.
Su... | [
{
"body": "#### What's the problem this feature will solve?\r\nMake unambigious what the values of the parameters used from parametrize are. \r\n\r\n#### Describe the solution you'd like\r\nWhen duplicated values are used in parametrize, pytest adds a number after each duplicated value, starting from 0 and this... | 54623f0f33c367e19c4041d30f11f71787e30719 | {
"head_commit": "053745501f5d4c0159be03916b5a5b38c6931323",
"head_commit_message": "Bug Fix 11456: Duplicated parameters in @pytest.mark.parametrize",
"patch_to_review": "diff --git a/AUTHORS b/AUTHORS\nindex f8c66cae945..3c23d227730 100644\n--- a/AUTHORS\n+++ b/AUTHORS\n@@ -367,6 +367,7 @@ Tadek Teleżyński\n Ta... | [
{
"diff_hunk": "@@ -0,0 +1,2 @@\n+In this, we propose a solution that ensures the generation of unique identifiers for ParameterSets in the make_unique_parameterset_ids method in Python.py class. It appends numeric suffixes to identifiers, ensuring uniqueness even when the original identifiers have digit ending... | 31efcdd32e00597647f385a762c65daef8e0ee8e | diff --git a/AUTHORS b/AUTHORS
index f8c66cae945..3c23d227730 100644
--- a/AUTHORS
+++ b/AUTHORS
@@ -367,6 +367,7 @@ Tadek Teleżyński
Takafumi Arakaki
Taneli Hukkinen
Tanvi Mehta
+Tanya Agarwal
Tarcisio Fischer
Tareq Alayan
Tatiana Ovary
diff --git a/changelog/11456.bugfix.rst b/changelog/11456.bugfix.rst
new fil... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Test Suite / CI Enhancements"
} |
pwndbg__pwndbg-1233@bea6c56 | pwndbg/pwndbg | Python | 1,233 | Add --shell argument to pwndbg command | ```
pwndbg: loaded 157 pwndbg commands and 49 shell commands. Type pwndbg [--shell | --all] [filter] for a list.
pwndbg: created $rebase, $ida gdb functions (can be used with print/break)
------- tip of the day (disable with set show-tips off) -------
Use GDB's dprintf command to print all calls to given function. ... | 2022-10-06T05:46:24Z | Hide shell commands from the `pwndbg` output by default
We should hide shell commands from the `pwndbg` output by default, and only display them with `pwndbg --all` or `pwndbg --shell` or something like that. This would make it easier to find actual pwndbg commands. | [
{
"body": "We should hide shell commands from the `pwndbg` output by default, and only display them with `pwndbg --all` or `pwndbg --shell` or something like that. This would make it easier to find actual pwndbg commands.",
"number": 1211,
"title": "Hide shell commands from the `pwndbg` output by defaul... | 0d73e9d8c97f1c8975c524a0b46447497308a1c5 | {
"head_commit": "bea6c56cdb7483a1f0c60aedd9af3725a12cd7dd",
"head_commit_message": "Add --shell argument to pwndbg command",
"patch_to_review": "diff --git a/pwndbg/commands/__init__.py b/pwndbg/commands/__init__.py\nindex 227619cf075..4e7a2b1b1b7 100644\n--- a/pwndbg/commands/__init__.py\n+++ b/pwndbg/commands/... | [
{
"diff_hunk": "@@ -74,8 +79,16 @@ def errno_(err):\n \n \n @pwndbg.commands.ArgparsedCommand(parser, command_name=\"pwndbg\")\n-def pwndbg_(filter_pattern):\n- for name, docs in list_and_filter_commands(filter_pattern):\n+def pwndbg_(filter_pattern, shell, all_):\n+ if all_:\n+ shell = True\n+ ... | ca228c14f66e13a7b1981145ec75c707a27d0b03 | diff --git a/pwndbg/commands/__init__.py b/pwndbg/commands/__init__.py
index 227619cf075..4e7a2b1b1b7 100644
--- a/pwndbg/commands/__init__.py
+++ b/pwndbg/commands/__init__.py
@@ -54,7 +54,9 @@ class Command(gdb.Command):
builtin_override_whitelist = {"up", "down", "search", "pwd", "start"}
history = {} # t... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
pytest-dev__pytest-11469@d90ee6c | pytest-dev/pytest | Python | 11,469 | Add more set assertion rewrites e.g. ``>=`` | <!--
Thanks for submitting a PR, your contribution is really appreciated!
Here is a quick checklist that should be present in PRs.
- [ ] Include documentation when adding new features.
- [ ] Include new tests or update existing tests when applicable.
- [X] Allow maintainers to push and squash when merging my c... | 2023-09-27T03:22:33Z | Add more powerful set assertion rewrites for comparisons other than equality `==` (eg: `<=`, etc.)
<!--
Thanks for suggesting a feature!
Quick check-list while suggesting features:
-->
#### What's the problem this feature will solve?
<!-- What are you trying to do, that you are unable to achieve with pytest as... | [
{
"body": "<!--\r\nThanks for suggesting a feature!\r\n\r\nQuick check-list while suggesting features:\r\n-->\r\n\r\n#### What's the problem this feature will solve?\r\n<!-- What are you trying to do, that you are unable to achieve with pytest as it currently stands? -->\r\nSet comparisons that do not check for... | b73b4c464c6fa54f55a1c6ed8eaceb5529a161bb | {
"head_commit": "d90ee6ce9d418380b35e7beca1436f97baa241a7",
"head_commit_message": "cleanup",
"patch_to_review": "diff --git a/changelog/10617.feature.rst b/changelog/10617.feature.rst\nnew file mode 100644\nindex 00000000000..9eb2cce4041\n--- /dev/null\n+++ b/changelog/10617.feature.rst\n@@ -0,0 +1,3 @@\n+This ... | [
{
"diff_hunk": "@@ -1345,48 +1345,98 @@ def test_reprcompare_whitespaces() -> None:\n ]\n \n \n-def test_pytest_assertrepr_compare_integration(pytester: Pytester) -> None:\n+@pytest.mark.parametrize(\"op\", [\">=\", \"<=\"])\n+def test_operators_not_set_for_full_coverage(op, pytester: Pytester) -> None:\n ... | 18604b38374a373b1039f92d234be6d4e1a717c5 | diff --git a/changelog/10617.feature.rst b/changelog/10617.feature.rst
new file mode 100644
index 00000000000..c99ec488912
--- /dev/null
+++ b/changelog/10617.feature.rst
@@ -0,0 +1,2 @@
+Added more comprehensive set assertion rewrites for comparisons other than equality ``==``, with
+the following operations now provi... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
pytest-dev__pytest-11317@ebd571b | pytest-dev/pytest | Python | 11,317 | Fix doctest collection of `functools.cached_property` objects. | I'll be first to admit that the proposed solution is _very_ hacky but felt inspired by some adjacent code to do things this way. Suggestions for improvement are welcomed. 🙂
closes #11237
| 2023-08-16T06:59:28Z | @cached_property is not checked for doctests
- [x] a detailed description of the bug or problem you are having
If I have doctests in a function decorated with `@cached_property`, they will not be run.
- [x] output of `pip list` from the virtual environment you are using
```
Package Version Editable projec... | [
{
"body": "- [x] a detailed description of the bug or problem you are having\r\nIf I have doctests in a function decorated with `@cached_property`, they will not be run.\r\n- [x] output of `pip list` from the virtual environment you are using\r\n```\r\nPackage Version Editable project location\r\n----... | 15fadd8c5cb6a4812c8b2a6ebcbb37c3d05eb7fe | {
"head_commit": "ebd571bb18d2cf00ebc70db8090217fc62d00e98",
"head_commit_message": "Move _from_module override to pre-existsing DocTestFinder subclass",
"patch_to_review": "diff --git a/AUTHORS b/AUTHORS\nindex 313e507f204..18db7808f13 100644\n--- a/AUTHORS\n+++ b/AUTHORS\n@@ -379,6 +379,7 @@ Tor Colvin\n Trevor... | [
{
"diff_hunk": "@@ -536,6 +537,18 @@ def _find(\n tests, obj, name, module, source_lines, globs, seen\n )\n \n+ def _from_module(self, module, object):\n+ \"\"\"`cached_property` objects will are never considered a part",
"line": null,
... | a357c7abc84e0382894a9b53d88ebb7ed2680686 | diff --git a/AUTHORS b/AUTHORS
index 313e507f204..18db7808f13 100644
--- a/AUTHORS
+++ b/AUTHORS
@@ -379,6 +379,7 @@ Tor Colvin
Trevor Bekolay
Tushar Sadhwani
Tyler Goodlet
+Tyler Smart
Tzu-ping Chung
Vasily Kuznetsov
Victor Maryama
diff --git a/changelog/11237.bugfix.rst b/changelog/11237.bugfix.rst
new file mod... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
pytest-dev__pytest-11308@c0cf822 | pytest-dev/pytest | Python | 11,308 | Improve reporting from __iter__ exceptions | Fixes #7966
Previously, the assertion rewrite mechanism would fail to capture raised errors within ``__iter__`` and suggest the error is within ``__repr__``, which this new reporting now fixes.
<!--
Thanks for submitting a PR, your contribution is really appreciated!
Here is a quick checklist that should be p... | 2023-08-11T17:34:00Z | Failure when trying to call __repr__ because __iter__ is called?
## 1. Problem
The following code
```python
class A:
def __iter__(self):
raise ValueError()
def __eq__(self, o: object) -> bool:
return self is o
def test_a():
assert A() == A()
```
...will throw:
```
... | part of the assertion representation logic does try various things to tell more about the object
the isiterable helper unfortunately calls `__iter__` instead of just verifying its existence
it only checks for type-error, which doesn't account for broken implementations of iter
we should decide whether we want to ... | [
{
"body": "## 1. Problem\r\n\r\nThe following code \r\n\r\n```python\r\nclass A:\r\n def __iter__(self):\r\n raise ValueError()\r\n\r\n def __eq__(self, o: object) -> bool:\r\n return self is o\r\n\r\n\r\ndef test_a():\r\n assert A() == A()\r\n```\r\n\r\n...will throw:\r\n\r\n```\r\n d... | 10056865d2a4784934ce043908a0e78d0578f677 | {
"head_commit": "c0cf822ca1d5d6ac74f46ddccbe377c254c6084a",
"head_commit_message": "improve error msg and test",
"patch_to_review": "diff --git a/changelog/7966.bugfix.rst b/changelog/7966.bugfix.rst\nnew file mode 100644\nindex 00000000000..40cad46c69d\n--- /dev/null\n+++ b/changelog/7966.bugfix.rst\n@@ -0,0 +1... | [
{
"diff_hunk": "@@ -134,6 +134,13 @@ def isiterable(obj: Any) -> bool:\n return not istext(obj)\n except TypeError:\n return False\n+ except Exception as e:\n+ raise ValueError(",
"line": null,
"original_line": 138,
"original_start_line": 135,
"path": "src/_pytest/a... | d1722d5c189ff7a1baccadfb514d05402104ccee | diff --git a/changelog/7966.bugfix.rst b/changelog/7966.bugfix.rst
new file mode 100644
index 00000000000..de055768066
--- /dev/null
+++ b/changelog/7966.bugfix.rst
@@ -0,0 +1 @@
+Removes unhelpful error message from assertion rewrite mechanism when exceptions raised in __iter__ methods, and instead treats them as un-i... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
pytest-dev__pytest-11178@db37e34 | pytest-dev/pytest | Python | 11,178 | Fix error assertion handling in approx when None in dict comparison | Closes #10702
Dict comparsion in the ApproxMapping class did not check if values were None before attempting to subtract for max_abs_diff stat, which was throwing an TypeError instead of being handled by pytest error assertion. Check for None has been added before these calculations, so that None will properly show ... | 2023-07-07T19:54:58Z | `pytest.approx` fails with `TypeError: unsupported operand type(s) for -: 'float' and 'NoneType'`
When using `approx` to test float and one of the objects in the `assert` statement contain `None` I see the following TypeError:
`TypeError: unsupported operand type(s) for -: 'float' and 'NoneType'.
`
## Minimal ex... | We should probably error earlier, none is not approx-able
It seems to be a mistake to let approx take dict for convenience
It appears that `None` is currently functional when passing it directly to approx, but not when passed as part of a dictionary (which gets processed by the `ApproxMapping` class, and a subtractio... | [
{
"body": "When using `approx` to test float and one of the objects in the `assert` statement contain `None` I see the following TypeError:\r\n\r\n`TypeError: unsupported operand type(s) for -: 'float' and 'NoneType'.\r\n`\r\n\r\n## Minimal example\r\n### Test\r\n```\r\nimport pytest\r\n\r\n\r\n# Expecting asse... | 97ed533f63d5780a05702a711555cb6744247a37 | {
"head_commit": "db37e34613b7638cb9ac957d3f30b4734b83e497",
"head_commit_message": "Merge branch 'main' into add-none-support-approxmapping",
"patch_to_review": "diff --git a/changelog/10702.bugfix.rst b/changelog/10702.bugfix.rst\nnew file mode 100644\nindex 00000000000..4008cc882ec\n--- /dev/null\n+++ b/change... | [
{
"diff_hunk": "@@ -265,19 +265,20 @@ def _repr_compare(self, other_side: Mapping[object, float]) -> List[str]:\n approx_side_as_map.items(), other_side.values()\n ):\n if approx_value != other_value:\n- max_abs_diff = max(\n- max_abs_diff, abs(a... | d4265448a58434f624c8d1817a7173a168b0f300 | diff --git a/changelog/10702.bugfix.rst b/changelog/10702.bugfix.rst
new file mode 100644
index 00000000000..4008cc882ec
--- /dev/null
+++ b/changelog/10702.bugfix.rst
@@ -0,0 +1 @@
+Fixed error assertion handling in :func:`pytest.approx` when ``None`` is an expected or received value when comparing dictionaries.
diff ... | {
"difficulty": "low",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
onnx__onnx-6217@a548ebe | onnx/onnx | Python | 6,217 | Add check on dimensions in Gemm opset 6 | Fix https://github.com/onnx/onnx/issues/6185
| 2024-07-08T22:43:44Z | Shape Inference crash on Gemm
# Bug Report
### Describe the bug
```
import onnx
import onnx.parser
model = """
<
ir_version: 10,
opset_import: ["" : 6]
>
graph (double[2,1] in0, double in1, double[2] in2) => () {
out0 = Gemm <alpha: float = 1, beta: float = -693.752, broadcast: int = -436, trans... | [
{
"body": "# Bug Report\r\n\r\n### Describe the bug\r\n```\r\nimport onnx\r\nimport onnx.parser\r\n\r\nmodel = \"\"\"\r\n<\r\n ir_version: 10,\r\n opset_import: [\"\" : 6]\r\n>\r\ngraph (double[2,1] in0, double in1, double[2] in2) => () {\r\n out0 = Gemm <alpha: float = 1, beta: float = -693.752, broadcas... | 453aa2f85ea38198b6d9bc50c9c1942a1f16b6c3 | {
"head_commit": "a548ebef341f78ea8caf7169700ed17942249194",
"head_commit_message": "Add check on dimensions in Gemm opset 6\n\nSigned-off-by: Ganesan Ramalingam <grama@microsoft.com>",
"patch_to_review": "diff --git a/onnx/defs/math/old.cc b/onnx/defs/math/old.cc\nindex d63070f9c04..0e428c56b82 100644\n--- a/onn... | [
{
"diff_hunk": "@@ -3304,10 +3304,19 @@ ONNX_OPERATOR_SET_SCHEMA(\n auto transBAttr = ctx.getAttribute(\"transB\");\n bool transB = transBAttr ? static_cast<int>(transBAttr->i()) != 0 : false;\n \n+ auto& first_input_shape = getInputShape(ctx, 0);\n+ auto& second_in... | f5433b63ceeed0db7448e71e6241aad17d3883c7 | diff --git a/onnx/defs/math/old.cc b/onnx/defs/math/old.cc
index d63070f9c04..6c62b133dae 100644
--- a/onnx/defs/math/old.cc
+++ b/onnx/defs/math/old.cc
@@ -3304,10 +3304,15 @@ ONNX_OPERATOR_SET_SCHEMA(
auto transBAttr = ctx.getAttribute("transB");
bool transB = transBAttr ? static_cast<int>(t... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
onnx__onnx-6195@9647e22 | onnx/onnx | Python | 6,195 | Fix a few crashes while running shape inference | ### Description
Fixes #6186, #6185, #6180, #6187.
It also improves the error messages to let users know where something is going wrong.
| 2024-06-20T11:08:22Z | onnx.checker crashes on STFT
# Bug Report
### Describe the bug
```
#!/usr/bin/env python
import onnx
import onnx.parser
modeltxt = """
<
ir_version: 10,
opset_import: ["" : 17]
>
graph (float16[3] in0, int32[2] in1, float16[7,8,8,8] in2, int32[8,1,7,2] in3) => () {
out0 = STFT (in0, in1, in2, i... | [
{
"body": "# Bug Report\r\n\r\n### Describe the bug\r\n```\r\n#!/usr/bin/env python\r\nimport onnx\r\nimport onnx.parser\r\n\r\nmodeltxt = \"\"\"\r\n<\r\n ir_version: 10,\r\n opset_import: [\"\" : 17]\r\n>\r\ngraph (float16[3] in0, int32[2] in1, float16[7,8,8,8] in2, int32[8,1,7,2] in3) => () {\r\n out0 =... | 4c3ed5e08be75bbe1eeb6818e490b1b6a370183e | {
"head_commit": "9647e22d74631d87cae8d13d2c39d6a3443da483",
"head_commit_message": "lint\n\nSigned-off-by: Xavier Dupre <xadupre@microsoft.com>",
"patch_to_review": "diff --git a/onnx/defs/math/defs.cc b/onnx/defs/math/defs.cc\nindex c315a2a7b7f..58963154ab6 100644\n--- a/onnx/defs/math/defs.cc\n+++ b/onnx/defs/... | [
{
"diff_hunk": "@@ -105,6 +105,8 @@ struct InferenceContext {\n virtual const SparseTensorProto* getInputSparseData(size_t index) const = 0;\n // Gets the shape inputs computed by partial data propagation.\n virtual const TensorShapeProto* getSymbolicInput(size_t index) const = 0;\n+ // To display a name... | a3eb6c2fc3b079845efd2fafbdda3360a7e52bfa | diff --git a/onnx/defs/math/defs.cc b/onnx/defs/math/defs.cc
index c315a2a7b7f..58963154ab6 100644
--- a/onnx/defs/math/defs.cc
+++ b/onnx/defs/math/defs.cc
@@ -3472,6 +3472,9 @@ ONNX_OPERATOR_SET_SCHEMA(
}
auto& input_shape = getInputShape(ctx, 0);
+ if (input_shape.dim_size() < 2) {
+... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
pytest-dev__pytest-10958@dbcfdf1 | pytest-dev/pytest | Python | 10,958 | Improve verbose output by wrapping skip/xfail reasons with margin | Fixes #10940.
This functionality is covered by an existing test that only needed minor updates to match new output. There were a couple of identical lines in the output used for text matching, so I added numbers to disambiguate.
Let me know if there are any suggestions or changes needed. | 2023-05-01T16:23:51Z | Improve progress alignment
First of all, thanks to all contributors, your work is much appreciated!
The right aligned percent progress looks great in the terminal, but sometimes the nice alignment is marred by verbose (`-vv`+) output.
Here is an example of the current alignment:
```
tests/implementations/test_h... | Hi @brl0,
Thanks for writing!
I would be glad to review/merge a PR in that regard, for sure. | [
{
"body": "First of all, thanks to all contributors, your work is much appreciated!\r\n\r\nThe right aligned percent progress looks great in the terminal, but sometimes the nice alignment is marred by verbose (`-vv`+) output. \r\nHere is an example of the current alignment:\r\n```\r\ntests/implementations/test... | 762bb61562d1300eedeb80be2ec2fb8150b3cc3f | {
"head_commit": "dbcfdf1e6985f1ce6273c514b3365cd092e5cc01",
"head_commit_message": "Improve changelog description",
"patch_to_review": "diff --git a/AUTHORS b/AUTHORS\nindex dee73514a59..438be759814 100644\n--- a/AUTHORS\n+++ b/AUTHORS\n@@ -56,6 +56,7 @@ Benjamin Peterson\n Bernard Pratz\n Bob Ippolito\n Brian D... | [
{
"diff_hunk": "@@ -0,0 +1 @@\n+Added :func:`TerminalReporter.wrap_write() <pytest.TerminalReporter.wrap_write>`, which improves verbose output by performing text wrapping on skip and xfail reasons while leaving a clear margin for progress output.",
"line": null,
"original_line": 1,
"original_start_... | 04c6f93d1365869aaafdad5115b3062f18d3baf8 | diff --git a/AUTHORS b/AUTHORS
index dee73514a59..438be759814 100644
--- a/AUTHORS
+++ b/AUTHORS
@@ -56,6 +56,7 @@ Benjamin Peterson
Bernard Pratz
Bob Ippolito
Brian Dorsey
+Brian Larsen
Brian Maissy
Brian Okken
Brianna Laugher
diff --git a/changelog/10940.improvement.rst b/changelog/10940.improvement.rst
new fil... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Code Refactoring / Architectural Improvement"
} |
pytest-dev__pytest-10905@6831dd7 | pytest-dev/pytest | Python | 10,905 | Fix `pytrace=False` and `--tb=line` reports `None` | <!--
Thanks for submitting a PR, your contribution is really appreciated!
Here is a quick checklist that should be present in PRs.
- [ ] Include documentation when adding new features.
- [ ] Include new tests or update existing tests when applicable.
- [X] Allow maintainers to push and squash when merging my c... | 2023-04-12T21:50:52Z | `pytrace=False` and "--tb=line" reports "None"
Given test changed as
```diff
import pytest
def test_foo():
- pytest.fail('my message')
+ pytest.fail('my message', pytrace=False)
```
and invoked as
```
pytest --tb=line test_foo.py
```
results in output
```diff
== FAILURES ==
-.../test_foo.py:4:... | Hello, first-time contributor here, so I'm very open to any suggestions on any of the following!
### The Issue
I've managed to track down this issue to lines 448 and 449 in the function `_repr_failure_py` in the nodes.py file:
```
if not excinfo.value.pytrace:
style = "value"
```
It seems that the test... | [
{
"body": "Given test changed as\r\n```diff\r\n import pytest\r\n\r\n def test_foo():\r\n- pytest.fail('my message')\r\n+ pytest.fail('my message', pytrace=False) \r\n```\r\nand invoked as\r\n```\r\npytest --tb=line test_foo.py\r\n```\r\nresults in output\r\n```diff\r\n == FAILURES ==\r\n-.../test_foo.py:... | 7834b3b07f7a7b2409331a8f14141c6ee8546215 | {
"head_commit": "6831dd7aad09a5c53c01a7b38001b9cc692cf0e7",
"head_commit_message": "Update test to confirm expected behavior",
"patch_to_review": "diff --git a/AUTHORS b/AUTHORS\nindex 1aa5265e62e..dee73514a59 100644\n--- a/AUTHORS\n+++ b/AUTHORS\n@@ -13,6 +13,7 @@ Ahn Ki-Wook\n Akiomi Kamakura\n Alan Velasco\n ... | [
{
"diff_hunk": "@@ -445,7 +445,7 @@ def _repr_failure_py(\n if isinstance(excinfo.value, ConftestImportFailure):\n excinfo = ExceptionInfo.from_exc_info(excinfo.value.excinfo)\n if isinstance(excinfo.value, fail.Exception):\n- if not excinfo.value.pytrace:\n+ if... | 7e4a5bd4fadb0520005aad33a9879b9874c304cc | diff --git a/AUTHORS b/AUTHORS
index 1aa5265e62e..dee73514a59 100644
--- a/AUTHORS
+++ b/AUTHORS
@@ -13,6 +13,7 @@ Ahn Ki-Wook
Akiomi Kamakura
Alan Velasco
Alessio Izzo
+Alex Jones
Alexander Johnson
Alexander King
Alexei Kozlenok
diff --git a/changelog/10831.bugfix.rst b/changelog/10831.bugfix.rst
new file mode 1... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
onnx__onnx-5990@72f626c | onnx/onnx | Python | 5,990 | Fix SegFault bug in shape inference | ### Description
The bug is SegFault during shape inference if the schema not be set inference function.
The schema has `CheckInputOutputType` for shape inference and `Verify` for raw node proto. And the behavior is not fully aligned.
### Motivation and Context
fixes #5989
| 2024-03-02T15:26:55Z | SegFault during shape inference if the schema not be set inference function
# Bug Report
### Describe the bug
SegFault during shape inference if the schema not be set inference function
### Reproduction instructions
cpp (Optional):
```
ONNX_OPERATOR_SCHEMA(CustomOp);
```
python:
```
import onnx
f... | [
{
"body": "# Bug Report\r\n\r\n### Describe the bug\r\nSegFault during shape inference if the schema not be set inference function\r\n\r\n### Reproduction instructions\r\n\r\ncpp (Optional):\r\n\r\n```\r\nONNX_OPERATOR_SCHEMA(CustomOp);\r\n```\r\n\r\npython:\r\n\r\n```\r\nimport onnx\r\nfrom onnx import defs\r\... | d7e2b813c1a26cdb8bcb6c4547cb5e6ffeb9b49b | {
"head_commit": "72f626c13176dd685bca85df1f24c4efe3bfaa9a",
"head_commit_message": "reformat py lint\n\nSigned-off-by: opluss <opluss@qq.com>",
"patch_to_review": "diff --git a/onnx/defs/schema.cc b/onnx/defs/schema.cc\nindex b8fab81d22d..f58230383b1 100644\n--- a/onnx/defs/schema.cc\n+++ b/onnx/defs/schema.cc\n... | [
{
"diff_hunk": "@@ -107,6 +107,30 @@ OpSchemaRegistry* OpSchemaRegistry::Instance() {\n \n void OpSchema::CheckInputOutputType(struct InferenceContext& ctx) const {\n std::unordered_map<std::string, std::string> type_constraints;\n+ if (inputs_.empty() && ctx.getNumInputs() > 0) {\n+ fail_check(\n+ ... | 9cad14b591168ad993d0c0a34e73114530f1cc61 | diff --git a/onnx/defs/schema.cc b/onnx/defs/schema.cc
index b8fab81d22d..257fddd3604 100644
--- a/onnx/defs/schema.cc
+++ b/onnx/defs/schema.cc
@@ -107,6 +107,30 @@ OpSchemaRegistry* OpSchemaRegistry::Instance() {
void OpSchema::CheckInputOutputType(struct InferenceContext& ctx) const {
std::unordered_map<std::s... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
Subsets and Splits
Review Test Instances
Retrieves basic metadata about code review instances but doesn't provide any analytical insights or patterns beyond raw data access.