instance_id stringlengths 21 53 | repo stringclasses 188
values | language stringclasses 1
value | pull_number int64 20 148k | title stringlengths 6 144 | body stringlengths 0 83.4k | created_at stringdate 2015-09-25 03:17:17 2025-07-10 16:50:35 | problem_statement stringlengths 188 240k | hints_text stringlengths 0 145k | resolved_issues listlengths 1 6 | base_commit stringlengths 40 40 | commit_to_review dict | reference_review_comments listlengths 1 62 | merged_commit stringlengths 40 40 | merged_patch stringlengths 297 9.87M | metadata dict |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
matplotlib__matplotlib-22356@39cfe2b | matplotlib/matplotlib | Python | 22,356 | Cleanup tripcolor() | ## PR Summary
Commits:
- Rewrite `Triangulation.get_from_args_and_kwargs` to make parameter parsing testable; and add tests.
- Warn when passing `triangles` or `mask` alongside a `Triangulation` to `tripcolor()`
- Cleanup logic and documentation of `tripcolor()`
This issues additional warnings and more preci... | 2022-01-29T23:15:11Z | [Bug]: Args for tripcolor
### Bug summary
Thanks for matplotlib!
`tripcolor` fails if colors are passed with named argument i.e `c=values` instead of just `values`. The error is not very informative and it seems a dangerous practice to ignore `kwargs` and only use `args`.
```bash
File "/mnt/session_space/conda... | Please provide a complete example. (Also, I don't think `c` is a valid keyword argument to `tripcolor`.)
I'll close for lack of response, but do request a re-open if there is still an issue here.
Basically `tripcolor(np.random.rand(5), np.random.rand(5), C=np.random.rand(5))` currently fails with the not-so-informati... | [
{
"body": "### Bug summary\r\nThanks for matplotlib! \r\n`tripcolor` fails if colors are passed with named argument i.e `c=values` instead of just `values`. The error is not very informative and it seems a dangerous practice to ignore `kwargs` and only use `args`.\r\n\r\n```bash\r\n File \"/mnt/session_space/c... | 2e921df22ba6b2a7782241798b042403c04cbdaf | {
"head_commit": "39cfe2b94eb46db86507d68771d832034667dfd7",
"head_commit_message": "Warn when passing triangles or mask alongside a Triangulation",
"patch_to_review": "diff --git a/lib/matplotlib/tests/test_triangulation.py b/lib/matplotlib/tests/test_triangulation.py\nindex 08ed058ddb2e..dc7292696489 100644\n--... | [
{
"diff_hunk": "@@ -12,6 +12,73 @@\n from matplotlib.testing.decorators import image_comparison, check_figures_equal\n \n \n+x = [-1, 0, 1, 0]\n+y = [0, -1, 0, 1]\n+triangles = [[0, 1, 2], [0, 2, 3]]\n+mask = [False, True]",
"line": null,
"original_line": 18,
"original_start_line": 15,
"path": "... | 703b57495891702441e5da0326473f76909f5df8 | diff --git a/lib/matplotlib/tests/test_triangulation.py b/lib/matplotlib/tests/test_triangulation.py
index 08ed058ddb2e..5243b25964da 100644
--- a/lib/matplotlib/tests/test_triangulation.py
+++ b/lib/matplotlib/tests/test_triangulation.py
@@ -12,6 +12,67 @@
from matplotlib.testing.decorators import image_comparison, c... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
mlflow__mlflow-15637@b9f54cc | mlflow/mlflow | Python | 15,637 | Reuse a single empty OTEL Resource in Span.from_dict to cut search_tr… | <details><summary>🛠 DevTools 🛠</summary>
<p>
[](https://codespaces.new/joelrobin18/mlflow/pull/15637?quickstart=1)
#### Install mlflow from this PR
```
# mlflow
pip install git+https://github.com/mlflow/mlflow.git@refs/pull/15637/merg... | 2025-05-09T01:19:06Z | [FR] Improve Download Trace Data Speed by Avoiding Resource Creation in span.from_dict()
### Willingness to contribute
No. I cannot contribute this feature at this time.
### Proposal Summary
The process of downloading trace data in mlflow.search_traces() involves creating a Resource object within the span.from_dict(... | Downloading trace data takes over 7 seconds, with most of the time spent on creating resources within span.from_dict().
 | [
{
"body": "### Willingness to contribute\n\nNo. I cannot contribute this feature at this time.\n\n### Proposal Summary\n\nThe process of downloading trace data in mlflow.search_traces() involves creating a Resource object within the span.from_dict() method, which can be time-consuming and inefficient.\n\nThis f... | 9436f31598a05f92e139b556fcc409d1a448829b | {
"head_commit": "b9f54cc59137465f5d53d5df5eb75a808a0753fa",
"head_commit_message": "Fix\n\nSigned-off-by: joelrobin18 <joelrobin1818@gmail.com>",
"patch_to_review": "diff --git a/mlflow/entities/span.py b/mlflow/entities/span.py\nindex c3d33c8369ad0..dc3bba30862b6 100644\n--- a/mlflow/entities/span.py\n+++ b/mlf... | [
{
"diff_hunk": "@@ -257,6 +261,7 @@ def from_dict(cls, data: dict[str, Any]) -> \"Span\":\n status_code=SpanStatusCode.from_proto_status_code(data[\"status\"][\"code\"]),\n description=data[\"status\"].get(\"message\"),\n ).to_otel_status(),",
"line": ... | 003a72450aaa58be3a64d283f59515bd191fbf36 | diff --git a/mlflow/entities/span.py b/mlflow/entities/span.py
index c3d33c8369ad0..dc50b547f45bc 100644
--- a/mlflow/entities/span.py
+++ b/mlflow/entities/span.py
@@ -6,6 +6,7 @@
from google.protobuf.json_format import MessageToDict, ParseDict
from google.protobuf.struct_pb2 import Value
+from opentelemetry.sdk.r... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Performance Optimizations"
} |
matplotlib__matplotlib-21818@585a000 | matplotlib/matplotlib | Python | 21,818 | Fix collections coerce float | ## PR Summary
Collections `set_offset` was coercing to float, which ruins any units we want to do. Closes #21803
Needs tests....
Tested with
```python
import numpy as np
import matplotlib.pyplot as plt
x = np.linspace(0, 10)
y = np.sin(x)
d = x * np.timedelta64(24, 'h') + np.datetime64('2021-11-29')
... | 2021-11-30T14:52:24Z | [Bug]: using `set_offsets` on scatter object raises TypeError
### Bug summary
`plt.scatter` can accept datetime as arguments, but `set_offsets` method of it's returns cannot.
### Code for reproduction
```python
import numpy as np
import matplotlib.pyplot as plt
x = np.linspace(0, 10)
y = np.sin(x)
d = x... | Thanks, but this has been fixed, at least as of 3.5, so I'll close.
Well, I've just updated to 3.5.0 and the bug is still here with the exact same error.
UPD updating `numpy` to 1.21.4 helped
UPD2 it seems that it works for days, but not for hours. So if I replace `timedelta64(1, 'D')` with `timedelta64(24, 'h')`... | [
{
"body": "### Bug summary\r\n\r\n`plt.scatter` can accept datetime as arguments, but `set_offsets` method of it's returns cannot.\r\n\r\n### Code for reproduction\r\n\r\n```python\r\nimport numpy as np\r\nimport matplotlib.pyplot as plt\r\n\r\nx = np.linspace(0, 10)\r\ny = np.sin(x)\r\nd = x * np.timedelta64(2... | 2e4189b357e1c6d494cec151f58dce55881a673a | {
"head_commit": "585a0009406d3e390392ea6b11d8746530c1056f",
"head_commit_message": "FIX: collections set_offset co-ercing to float",
"patch_to_review": "diff --git a/lib/matplotlib/collections.py b/lib/matplotlib/collections.py\nindex 47f2c9503be7..a31afb86f0c6 100644\n--- a/lib/matplotlib/collections.py\n+++ b/... | [
{
"diff_hunk": "@@ -545,9 +545,12 @@ def set_offsets(self, offsets):\n ----------\n offsets : (N, 2) or (2,) array-like\n \"\"\"\n- offsets = np.asanyarray(offsets, float)\n+ offsets = np.asanyarray(offsets)\n if offsets.shape == (2,): # Broadcast (2,) -> (1, 2) bu... | 4d860b17991643cea63bf6849c094bef30119c99 | diff --git a/lib/matplotlib/collections.py b/lib/matplotlib/collections.py
index 47f2c9503be7..5c242b9086c1 100644
--- a/lib/matplotlib/collections.py
+++ b/lib/matplotlib/collections.py
@@ -545,10 +545,12 @@ def set_offsets(self, offsets):
----------
offsets : (N, 2) or (2,) array-like
"""
-... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
matplotlib__matplotlib-21773@47f9b62 | matplotlib/matplotlib | Python | 21,773 | FIX: Reset label of axis to center | ## PR Summary
Fixes #21772
1) Added elif blocks to center `xlabel` and `ylabel`
2) Added a test for the same in `test_axes.py`
3) Additionally, in `set_ylabel`, the `horizontalalignment` was getting reset instead of `verticalalignment`
## PR Checklist
**Tests and Styling**
- [x] Has pytest style unit tests ... | 2021-11-27T23:07:45Z | [Bug]: cannot reset label of axis to center
### Bug summary
When I do once of setting xlabel of ylabel to left of right, it cannot reset label of axis to center any way.
### Code for reproduction
```python
if I do once:
ax.set_xlabel("my label",loc="left ")
or:
ax.set_xlabel("my label",loc="right")
the followi... | Confirmed. Note that if you do `set_xlabel('label', loc='left'); set_xlabel('label', loc='right');` it works, so "center" is being ignored. This is an easy fix, so I'll mark as good first issue. It just needs a fix in `set_xlabel` and `set_ylabel` and it requires a test in `test_axes.py`.
@jklymak This seems to be... | [
{
"body": "### Bug summary\n\nWhen I do once of setting xlabel of ylabel to left of right, it cannot reset label of axis to center any way.\n\n### Code for reproduction\n\n```python\nif I do once:\r\nax.set_xlabel(\"my label\",loc=\"left \") \r\nor:\r\nax.set_xlabel(\"my label\",loc=\"right\")\r\nthe following ... | 728f0e483f93934b9d3fed738c6503a6ee6df855 | {
"head_commit": "47f9b6299e47c7da76d759968e3eaf0af5dd8582",
"head_commit_message": "Fix label shift and add test",
"patch_to_review": "diff --git a/lib/matplotlib/axes/_base.py b/lib/matplotlib/axes/_base.py\nindex 7a309780c3d7..f423530fd6e6 100644\n--- a/lib/matplotlib/axes/_base.py\n+++ b/lib/matplotlib/axes/_... | [
{
"diff_hunk": "@@ -3837,9 +3839,11 @@ def set_ylabel(self, ylabel, fontdict=None, labelpad=None, *,\n else mpl.rcParams['yaxis.labellocation'])\n _api.check_in_list(('bottom', 'center', 'top'), loc=loc)\n if loc == 'bottom':\n- kwargs.update(y=0, horizontalalignmen... | b836a43e7656ea42ffdc1fd916a14d155c02ab26 | diff --git a/lib/matplotlib/axes/_base.py b/lib/matplotlib/axes/_base.py
index 7a309780c3d7..21d6f5ac552b 100644
--- a/lib/matplotlib/axes/_base.py
+++ b/lib/matplotlib/axes/_base.py
@@ -3487,15 +3487,19 @@ def set_xlabel(self, xlabel, fontdict=None, labelpad=None, *,
f"its correspondin... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
mlflow__mlflow-15287@9a1e0b7 | mlflow/mlflow | Python | 15,287 | Validate auth password to be string longer than 12 chars | <details><summary>🛠 DevTools 🛠</summary>
<p>
[](https://codespaces.new/WeichenXu123/mlflow/pull/15287?quickstart=1)
#### Install mlflow from this PR
```
# mlflow
pip install git+https://github.com/mlflow/mlflow.git@refs/pull/... | 2025-04-11T00:35:57Z | [BUG] Security Vulnerability
Hello,
Trend Micro's Zero Day Initiative is a security/vulnerability research organization. We have discovered a vulnerability in MLflow and we would like to disclose it responsibly to your company. Thank you and best regards,
Kholoud Altookhy
Program Manager, Zero Day Initiative
Trend M... | Hi @zdi-disclosures we have received your report and will be filing a fix for it this week. Thank you for identifying it! The fix will be in MLflow 2.22.0. | [
{
"body": "Hello,\n\nTrend Micro's Zero Day Initiative is a security/vulnerability research organization. We have discovered a vulnerability in MLflow and we would like to disclose it responsibly to your company. Thank you and best regards,\nKholoud Altookhy\nProgram Manager, Zero Day Initiative\nTrend Micro\... | 83b9416cf1cf13216406c81842a5c98c5b1f06fc | {
"head_commit": "9a1e0b7c64d1c0f4e2fd7f6f31befdf8aa845bae",
"head_commit_message": "update\n\nSigned-off-by: Weichen Xu <weichen.xu@databricks.com>",
"patch_to_review": "diff --git a/mlflow/server/auth/__init__.py b/mlflow/server/auth/__init__.py\nindex deadfff164b6e..4609e766b364a 100644\n--- a/mlflow/server/au... | [
{
"diff_hunk": "@@ -623,6 +623,11 @@ def _validate_username(username):\n raise MlflowException(\"Username cannot be empty.\", INVALID_PARAMETER_VALUE)\n \n \n+def _validate_password(password):\n+ if password is None or len(password) < 8:\n+ raise MlflowException(\"Password must be a string lon... | c995daf70f1ff5f0e3be4a8dee16887d60044907 | diff --git a/mlflow/server/auth/__init__.py b/mlflow/server/auth/__init__.py
index deadfff164b6e..5bae5e405dafd 100644
--- a/mlflow/server/auth/__init__.py
+++ b/mlflow/server/auth/__init__.py
@@ -782,7 +782,7 @@ def signup():
<br>
<label for="password">Password:</label>
<br>
- <input type="password" id="pass... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Security Patches / Vulnerability Fixes"
} |
matplotlib__matplotlib-21318@2ad34af | matplotlib/matplotlib | Python | 21,318 | FIX: better error message for shared axes and axis('equal') | ## PR Summary
Closes #11416
The error message was pretty mysterious if you called `ax.axis('equal')` on a shared axes...
Not clear that the functionality users are _trying_ to get from this could not be provided, but at least clarifying the error message will help...
## PR Checklist
<!-- Please mark any ch... | 2021-10-08T15:04:46Z | RuntimeError: adjustable='datalim' is not allowed when both axes are shared.
<!--To help us understand and resolve your issue, please fill out the form to the best of your ability.-->
<!--You can feel free to delete the sections that do not apply.-->
### Bug report
**Bug summary**
Matplotlib 2.2.2 fails to pl... | This was a purposeful change in #10033. However, it should have had an API change entry - our apologies.
I'm also not sure that your use case should error. I think we need to still think about all the sharing/datalim interactions to make sure we always do the right thing.... ping @efiring
This combination is i... | [
{
"body": "<!--To help us understand and resolve your issue, please fill out the form to the best of your ability.-->\r\n<!--You can feel free to delete the sections that do not apply.-->\r\n\r\n### Bug report\r\n\r\n**Bug summary**\r\n\r\nMatplotlib 2.2.2 fails to plot the figure described below. The code work... | a1eef38f6f5a8acccc49f3b54ac429b04d8af15c | {
"head_commit": "2ad34af140cf4798e2abf28ee1fa0492e1515a83",
"head_commit_message": "TST: add test for error",
"patch_to_review": "diff --git a/lib/matplotlib/axes/_base.py b/lib/matplotlib/axes/_base.py\nindex 2f0f8865280f..42ebcd41a51e 100644\n--- a/lib/matplotlib/axes/_base.py\n+++ b/lib/matplotlib/axes/_base.... | [
{
"diff_hunk": "@@ -2044,7 +2046,11 @@ def axis(self, *args, emit=True, **kwargs):\n self.autoscale_view(tight=False)\n # self.apply_aspect()\n if s == 'equal':\n- self.set_aspect('equal', adjustable='datalim')\n+ try:\n+ ... | e07c28f6e6c1d892dd416515742a6bab3fcc83e8 | diff --git a/lib/matplotlib/axes/_base.py b/lib/matplotlib/axes/_base.py
index 2f0f8865280f..7941edc48179 100644
--- a/lib/matplotlib/axes/_base.py
+++ b/lib/matplotlib/axes/_base.py
@@ -1939,10 +1939,12 @@ def apply_aspect(self, position=None):
shared_x = self in self._shared_axes["x"]
shared_y = s... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
matplotlib__matplotlib-21661@496888c | matplotlib/matplotlib | Python | 21,661 | Fix plot directive with func calls | ## PR Summary
This will close #20656 .
I started but did not get through writing tests, I think I see a way to test just `render_figures` in a self-contained way, but wanted to push this up so it did not get lost.
## PR Checklist
<!-- Please mark any checkboxes that do not apply to this PR as [N/A]. -->
**... | 2021-11-18T04:24:28Z | Sphinx extension plot_directive not able to detect function
### Bug report
**Bug summary**
When writing a generical code to generate plots with sphinx documentation, this function cannot be called by other functions from the documentation in the same file
**Code for reproduction**
Repository layout:
- do... | I'm also having this problem.
This occurs because we currently textually split the code at instances of plt.show() that appear as literal strings in the source, and hope that the blocks are independently runnable. Instead, in the case where a function name is given, we should execute the whole code in a context where ... | [
{
"body": "### Bug report\r\n\r\n**Bug summary**\r\n\r\nWhen writing a generical code to generate plots with sphinx documentation, this function cannot be called by other functions from the documentation in the same file\r\n\r\n**Code for reproduction**\r\n\r\nRepository layout:\r\n\r\n- docs\r\n - source\r\n... | ecf6e26f0b0241bdc80466e13ee0c13a0c12f412 | {
"head_commit": "496888c092a8f35a8b8a0b553f926f7fbd3f4b9e",
"head_commit_message": "MNT: pass all input to render_figures an keyword\n\nThere are too many positional arguments and the names are subtly\ndifferent.",
"patch_to_review": "diff --git a/lib/matplotlib/sphinxext/plot_directive.py b/lib/matplotlib/sphin... | [
{
"diff_hunk": "@@ -10,10 +10,31 @@\n import pytest\n \n \n-pytest.importorskip('sphinx',\n- minversion=None if sys.version_info < (3, 10) else '4.1.3')\n+def skip_if_no_sphinx(func):\n+ pytest.importorskip(\n+ 'sphinx',\n+ minversion=None if sys.version_info < (3, 10) else '... | 1411ba3b22bab8185a070633b3c162dbb251b9d1 | diff --git a/doc/api/next_api_changes/removals/21661-TAC.rst b/doc/api/next_api_changes/removals/21661-TAC.rst
new file mode 100644
index 000000000000..78c8837d6a8d
--- /dev/null
+++ b/doc/api/next_api_changes/removals/21661-TAC.rst
@@ -0,0 +1,12 @@
+plot directive removals
+~~~~~~~~~~~~~~~~~~~~~~~
+
+The public method... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
matplotlib__matplotlib-20951@74b76ae | matplotlib/matplotlib | Python | 20,951 | [ENH]: data kwarg support for mplot3d #20912 | ## PR Summary
Fix #20912
Hi, I have started working on this issue. This will be my first open source contribution, so I will need some help and guidance. I have gone through the contributing guide and have setup the development environment and Matplotlib in editable mode on my system.
I am currently working on ... | 2021-08-31T11:13:16Z | [ENH]: data kwarg support for mplot3d
### Problem
3d axes don't support the data kwarg:
```
gcf().add_subplot(projection="3d").scatter("a", "b", "c", data={"a": [0], "b": [1], "c": [2]})
```
results in
```
ValueError: could not convert string to float: 'a'
```
### Proposed solution
I *think* it's "mostly" a m... | Hey I am new to open source can you assign me this issue if its open and some resources that can help me for solving this.
@akshat-max the contributing guide is at https://matplotlib.org/devdocs/devel/index.html. To get familiar w/ the data kwarg, I'd suggest tracing through a couple of the plotting methods that tak... | [
{
"body": "### Problem\n\n3d axes don't support the data kwarg:\r\n```\r\ngcf().add_subplot(projection=\"3d\").scatter(\"a\", \"b\", \"c\", data={\"a\": [0], \"b\": [1], \"c\": [2]})\r\n```\r\nresults in\r\n```\r\nValueError: could not convert string to float: 'a'\r\n```\n\n### Proposed solution\n\nI *think* it... | 32630612e8d3c03a6092aeb7f2829c0fb35e61ee | {
"head_commit": "74b76ae1727aeaa3ae42a961e45ca55fb3e68799",
"head_commit_message": "Blank line removed",
"patch_to_review": "diff --git a/lib/mpl_toolkits/mplot3d/axes3d.py b/lib/mpl_toolkits/mplot3d/axes3d.py\nindex d4eef7ca77e6..488f0786ddfa 100644\n--- a/lib/mpl_toolkits/mplot3d/axes3d.py\n+++ b/lib/mpl_toolk... | [
{
"diff_hunk": "@@ -2271,6 +2271,10 @@ def add_collection3d(self, col, zs=0, zdir='z'):\n collection = super().add_collection(col)\n return collection\n \n+ @_preprocess_data(replace_names=[\"xs\", \"ys\", \"zs\", \"s\",\n+ \"edgecolors\", \"c\", \"facecolo... | ed5330385ce82e0ed36750424f7e18725b2f4095 | diff --git a/lib/mpl_toolkits/mplot3d/axes3d.py b/lib/mpl_toolkits/mplot3d/axes3d.py
index d4eef7ca77e6..6730453aa666 100644
--- a/lib/mpl_toolkits/mplot3d/axes3d.py
+++ b/lib/mpl_toolkits/mplot3d/axes3d.py
@@ -19,7 +19,7 @@
import numpy as np
-from matplotlib import _api, cbook, docstring
+from matplotlib import ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
matplotlib__matplotlib-20916@166fdf2 | matplotlib/matplotlib | Python | 20,916 | Improve deleted Animation warning | Closes #20909.
| 2021-08-26T22:20:02Z | [Bug]: Animation error message
### Bug summary
once I executed my code by matplotlib.animation, The programe response this without any animation: D:\Program Files\Python\Python38\lib\site-packages\matplotlib\animation.py:973: UserWarning: Animation was deleted without rendering anything. This is most likely unintende... | I beleive you are running this as `python my_script.py` or similar via an IDE?
If that is the case, then you either need to call `plt.show()` (which will bring up a blocking window to show your animation) or do `a.save('out.mp4')` (or similar) to save the animation to file.
What is happening is that after you las... | [
{
"body": "### Bug summary\n\nonce I executed my code by matplotlib.animation, The programe response this without any animation: D:\\Program Files\\Python\\Python38\\lib\\site-packages\\matplotlib\\animation.py:973: UserWarning: Animation was deleted without rendering anything. This is most likely unintended. ... | 276a9f3599a3611bcdfbd4cfb8f852bfda19b48d | {
"head_commit": "166fdf2652ce22aba41a965352afca0a7c27dc56",
"head_commit_message": "Improve deleted Animation warning\n\nCloses #20909.",
"patch_to_review": "diff --git a/lib/matplotlib/animation.py b/lib/matplotlib/animation.py\nindex 985181a574c6..846c7e18b04c 100644\n--- a/lib/matplotlib/animation.py\n+++ b/l... | [
{
"diff_hunk": "@@ -888,9 +888,9 @@ def __del__(self):\n if not getattr(self, '_draw_was_started', True):\n warnings.warn(\n 'Animation was deleted without rendering anything. This is '\n- 'most likely unintended. To prevent deletion, assign the '\n- ... | 0d80b82206072128408b09d4df87e8eda813c853 | diff --git a/lib/matplotlib/animation.py b/lib/matplotlib/animation.py
index 985181a574c6..f93f6f1559d0 100644
--- a/lib/matplotlib/animation.py
+++ b/lib/matplotlib/animation.py
@@ -888,9 +888,11 @@ def __del__(self):
if not getattr(self, '_draw_was_started', True):
warnings.warn(
... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "Bug Fixes"
} |
mlflow__mlflow-13005@63a26ec | mlflow/mlflow | Python | 13,005 | [BUG] add support for file removal for local artifact repo | <details><summary>🛠 DevTools 🛠</summary>
<p>
[](https://codespaces.new/rzalawad/mlflow/pull/13005?quickstart=1)
#### Install mlflow from this PR
```
pip install git+https://github.com/mlflow/mlflow.git@refs/pull/13005/merge
`... | 2024-08-23T21:43:18Z | [FR] Add delete_artifact method to mlflow API
## Willingness to contribute
The MLflow Community encourages new feature contributions. Would you or another member of your organization be willing to contribute an implementation of this feature (either as an MLflow Plugin or an enhancement to the MLflow code base)?
... | @amesar Thanks for filing this. Yeah, this is an interesting enhancement as it poses a question about how long should we retain experiment runs and associated artifacts for auditing purposes. Currently, we just move the experiment into a _.trash_ folder under _mlruns_ and have `mlflow gc...` and mark the internal statu... | [
{
"body": "\r\n## Willingness to contribute\r\nThe MLflow Community encourages new feature contributions. Would you or another member of your organization be willing to contribute an implementation of this feature (either as an MLflow Plugin or an enhancement to the MLflow code base)?\r\n\r\n- [ ] Yes. I can co... | e5d1280a467f0b51692ff3edf29e191fc52f36ef | {
"head_commit": "63a26eca4d239224d92bf202d8aaf189ee74f933",
"head_commit_message": "add file removal for local artifact repo and add test cases\n\nSigned-off-by: Ridham Zalawadia <zalavadiaridham@gmail.com>",
"patch_to_review": "diff --git a/mlflow/store/artifact/local_artifact_repo.py b/mlflow/store/artifact/lo... | [
{
"diff_hunk": "@@ -199,6 +199,31 @@ def test_delete_artifacts(local_artifact_repo):\n assert not os.path.exists(os.path.join(local_artifact_repo._artifact_dir))\n \n \n+def test_delete_artifacts_files(local_artifact_repo):\n+ with TempDir() as local_dir:\n+ os.mkdir(local_dir.path(\"subdir\")... | b36c4214f1a9f9abcc0569da5b0dc50ec41fda4a | diff --git a/mlflow/store/artifact/local_artifact_repo.py b/mlflow/store/artifact/local_artifact_repo.py
index 28112451bbfbe..b1ae5fb0e6439 100644
--- a/mlflow/store/artifact/local_artifact_repo.py
+++ b/mlflow/store/artifact/local_artifact_repo.py
@@ -122,7 +122,10 @@ def delete_artifacts(self, artifact_path=None):
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
mlflow__mlflow-12721@b80b8d8 | mlflow/mlflow | Python | 12,721 | Make parent id a parameter | <details><summary>🛠 DevTools 🛠</summary>
<p>
[](https://codespaces.new/Flametaa/mlflow/pull/12721?quickstart=1)
#### Install mlflow from this PR
```
pip install git+https://github.com/mlflow/mlflow.git@refs/pull/12721/merge
`... | 2024-07-19T16:36:01Z | [FR] Make parent_run_id a parameter in start_run for hyperparameter tuning using multiple jobs
### Willingness to contribute
Yes. I can contribute this feature independently.
### Proposal Summary
Add `parent_run_id ` as a parameter in `mlflow.start_run` to avoid having to start a parent run in order to be able to us... | @Flametaa The proposal makes a lot sense! Would you mind contributing for this feature?
A few pointers to start:
* The parent_id is recorded to the run as a system tag here. https://github.com/mlflow/mlflow/blob/master/mlflow/tracking/fluent.py#L362C9-L362C22
* We may want to deprecate the existing `nested` parame... | [
{
"body": "### Willingness to contribute\n\nYes. I can contribute this feature independently.\n\n### Proposal Summary\n\nAdd `parent_run_id ` as a parameter in `mlflow.start_run` to avoid having to start a parent run in order to be able to use nested runs.\n\n### Motivation\n\n> #### What is the use case for th... | 3cb85f16215adbcc93c15c77de92c9d359f8087c | {
"head_commit": "b80b8d82eec8a0348a1d1bd20dfbd276b0feb2cf",
"head_commit_message": "add example\n\nSigned-off-by: SIALA KARIM <37486371+Flametaa@users.noreply.github.com>",
"patch_to_review": "diff --git a/mlflow/tracking/fluent.py b/mlflow/tracking/fluent.py\nindex ebe55a044f0b9..2fd0eed806203 100644\n--- a/mlf... | [
{
"diff_hunk": "@@ -236,6 +237,8 @@ def start_run(\n run_name: Name of new run. Used only when ``run_id`` is unspecified. If a new run is\n created and ``run_name`` is not specified, a random name will be generated for the run.\n nested: Controls whether run is nested in parent run. ... | 4d194a172ffca744a76c3252fc8a34c3fb2a0e57 | diff --git a/mlflow/tracking/fluent.py b/mlflow/tracking/fluent.py
index ebe55a044f0b9..4d35f418eba8c 100644
--- a/mlflow/tracking/fluent.py
+++ b/mlflow/tracking/fluent.py
@@ -204,6 +204,7 @@ def start_run(
experiment_id: Optional[str] = None,
run_name: Optional[str] = None,
nested: bool = False,
+ p... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
matplotlib__matplotlib-20367@6a6a51e | matplotlib/matplotlib | Python | 20,367 | Add parse_math in Text and default it False for TextBox | ## PR Summary
Following up the comment: https://github.com/matplotlib/matplotlib/issues/20266#issuecomment-854794023, this PR adds a `override_math` to Text objects, and make TextBox's text object default it to True.
This resolves https://github.com/matplotlib/matplotlib/issues/20266.
It does not allow GUI to go i... | 2021-06-04T18:13:38Z | "$$" cannot be displayed by ax.text()
<!--To help us understand and resolve your issue, please fill out the form to the best of your ability.-->
<!--You can feel free to delete the sections that do not apply.-->
### Bug report
**Bug summary**
I guess the minimal code-example tells it all...
<!--A short 1-2 sen... | `'$$'` sends the string to the latex parser. Which cannot find anything between the dollar signs and fails. I guess you could argue that it should just no-op. OTOH if you actually want dollar signs, you need to escape them: `'\$\$'`
hey, thanks for the quick response!
my problem actually originated from a gui th... | [
{
"body": "<!--To help us understand and resolve your issue, please fill out the form to the best of your ability.-->\r\n<!--You can feel free to delete the sections that do not apply.-->\r\n\r\n### Bug report\r\n\r\n**Bug summary**\r\nI guess the minimal code-example tells it all...\r\n<!--A short 1-2 sentence... | 3a265b33fdba148bb340e743667c4ba816ced928 | {
"head_commit": "6a6a51e70f8c406c50bc5f3b1560e10a4a1fd9f1",
"head_commit_message": "Add WhatsNew API entry for parse_math",
"patch_to_review": "diff --git a/doc/api/next_api_changes/behavior/20367-AG.rst b/doc/api/next_api_changes/behavior/20367-AG.rst\nnew file mode 100644\nindex 000000000000..decf8b8374b7\n---... | [
{
"diff_hunk": "@@ -0,0 +1,12 @@\n+``Text``\n+~~~~~~~~\n+\n+``Text`` objects now allow a **parse_math** keyword-only argument",
"line": null,
"original_line": 4,
"original_start_line": null,
"path": "doc/api/next_api_changes/behavior/20367-AG.rst",
"start_line": null,
"text": "@user1:\n`... | 9e9b8d562034a1e6af9b1e858d7986fa3e46421a | diff --git a/doc/api/next_api_changes/behavior/20367-AG.rst b/doc/api/next_api_changes/behavior/20367-AG.rst
new file mode 100644
index 000000000000..38bc9ac05ad7
--- /dev/null
+++ b/doc/api/next_api_changes/behavior/20367-AG.rst
@@ -0,0 +1,12 @@
+``Text`` allows a boolean *parse_math*
+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
matplotlib__matplotlib-18947@a2228be | matplotlib/matplotlib | Python | 18,947 | Strictly increasing check with test coverage for streamplot grid | ## PR Summary
This PR fixes #18898, adds check for strictly increasing `x` and `y` in `matplotlib.streamplot.Grid`, and adds test coverage for it.
## PR Checklist
<!-- Please mark any checkboxes that do not apply to this PR as [N/A]. -->
- [x] Has pytest style unit tests (and `pytest` passes).
- [x] Is [Flak... | 2020-11-14T01:29:09Z | wrong bounds checking in streamplot start_points
<!--To help us understand and resolve your issue, please fill out the form to the best of your ability.-->
<!--You can feel free to delete the sections that do not apply.-->
### Bug report
The bounds check for the `start_points` argument is wrong if the `x` or `y`... | It looks like the code in `streamplot` (via `Grid`) assumes that `x` and `y` are monotonic, evenly spaced, and increasing. We do a bunch of checks that it is actually a grid and evenly spaced in https://github.com/matplotlib/matplotlib/blob/eeef6e59386c6cebe2960213128c6a84906ddda9/lib/matplotlib/streamplot.py#L314-L35... | [
{
"body": "<!--To help us understand and resolve your issue, please fill out the form to the best of your ability.-->\r\n<!--You can feel free to delete the sections that do not apply.-->\r\n\r\n### Bug report\r\n\r\nThe bounds check for the `start_points` argument is wrong if the `x` or `y` coordinates are not... | 82442012d044c81dbaaaec71f62a8aea85acf7df | {
"head_commit": "a2228be3723b85993955e56a55f6b697a4190e19",
"head_commit_message": "Add strictly increasing check, corresponding doc fix",
"patch_to_review": "diff --git a/lib/matplotlib/streamplot.py b/lib/matplotlib/streamplot.py\nindex 12b1a54560e2..26c0e8635c46 100644\n--- a/lib/matplotlib/streamplot.py\n+++... | [
{
"diff_hunk": "@@ -114,3 +115,49 @@ def test_streamplot_limits():\n # datalim.\n assert_array_almost_equal(ax.dataLim.bounds, (20, 30, 15, 6),\n decimal=1)\n+\n+\n+def test_streamplot_grid():\n+ u = np.ones((2, 2))\n+ v = np.zeros((2, 2))\n+\n+ # Test for same row... | 7af5e2c5f8a751e06adf39a75091cf775f4997a1 | diff --git a/lib/matplotlib/streamplot.py b/lib/matplotlib/streamplot.py
index 12b1a54560e2..26c0e8635c46 100644
--- a/lib/matplotlib/streamplot.py
+++ b/lib/matplotlib/streamplot.py
@@ -25,8 +25,8 @@ def streamplot(axes, x, y, u, v, density=1, linewidth=None, color=None,
Parameters
----------
- x, y : 1... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
mlflow__mlflow-10954@877f813 | mlflow/mlflow | Python | 10,954 | Optimize Docker image for model serving | <details><summary>🛠 DevTools 🛠</summary>
<p>
[](https://codespaces.new/B-Step62/mlflow/pull/10954?quickstart=1)
#### Install mlflow from this PR
```
pip install git+https://github.com/mlflow/mlflow.git@refs/pull/10954/merge
`... | 2024-01-30T13:52:53Z | [FR] Reduce Docker Image Size for Predict
### Motivation
Docker Image produced by MLFlow for predicting the models is supposed to be the most portable format but unfortunately, the docker image produced by MLFlow is of huge size. We tried with a simple model file with 1kb size (a simple regression model) but the resul... | We should avoid packaging the jar files if it's a python served model, and remove condas for java (MLeap) serving.
It'll also reduce the build time
I suggest we add the libraries (python or java) depending on the serving flavor of the model we download in the the `copy_model_into_container` function instead of har... | [
{
"body": "### Motivation\r\nDocker Image produced by MLFlow for predicting the models is supposed to be the most portable format but unfortunately, the docker image produced by MLFlow is of huge size. We tried with a simple model file with 1kb size (a simple regression model) but the resultant docker image is ... | e358b41685075e101b3cd513b0ea8b0943b85dab | {
"head_commit": "877f813216a3f46d6eb9e54c0ded905c484669dc",
"head_commit_message": "more and more fix\n\nSigned-off-by: B-Step62 <yuki.watanabe@databricks.com>",
"patch_to_review": "diff --git a/.github/workflows/master.yml b/.github/workflows/master.yml\nindex b824a2c8f5415..2af15fb42b0ad 100644\n--- a/.github/... | [
{
"diff_hunk": "",
"line": null,
"original_line": null,
"original_start_line": null,
"path": "tests/pyfunc/docker/__init__.py",
"start_line": null,
"text": "@user1:\ndo we need this file?\n\n@author:\nnope, will remove!"
},
{
"diff_hunk": "@@ -30,106 +22,112 @@\n https://gith... | c9403cbe29a6fc8e4ac4964a25b745b17d5b67c5 | diff --git a/.github/workflows/master.yml b/.github/workflows/master.yml
index b824a2c8f5415..2af15fb42b0ad 100644
--- a/.github/workflows/master.yml
+++ b/.github/workflows/master.yml
@@ -276,7 +276,8 @@ jobs:
- name: Run tests
run: |
pytest --splits=${{ matrix.splits }} --group=${{ matrix.g... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Performance Optimizations"
} |
matplotlib__matplotlib-18565@d1984c5 | matplotlib/matplotlib | Python | 18,565 | Make Tkagg blit thread safe | ## PR Summary
Closes #13293. (possibly?) Use `tk.call` to invoke tkinter's cross-thread signalling when necessary to safely blit from threads. A small amount of architectural changes were made in the hopes of attaining actual CPU parallelism with threads, but that was unsuccessful because of how `Tk_PhotoPutBlock` is... | 2020-09-24T20:58:58Z | FigureCanvasTkAgg.draw() silently crashes in threaded application
<!--To help us understand and resolve your issue, please fill out the form to the best of your ability.-->
<!--You can feel free to delete the sections that do not apply.-->
### Bug report
**Bug summary**
Matplotlib crashes python without risin... | Matplotlib makes no guarantees of thread safety. You'll need to use other methods to ensure that only one thread accesses it (conditions, mutexes, GUI-specific signals (if available), etc.)
```
19:59 $ python -X faulthandler /tmp/tk_thread.py
Fatal Python error: Segmentation fault
Current thread 0x00007f7029ab27... | [
{
"body": "<!--To help us understand and resolve your issue, please fill out the form to the best of your ability.-->\r\n<!--You can feel free to delete the sections that do not apply.-->\r\n\r\n### Bug report\r\n\r\n**Bug summary**\r\n\r\nMatplotlib crashes python without rising any exceptions (python simply c... | f98427d38e8f1486fc93af5f7801f63cb8569847 | {
"head_commit": "d1984c5b1ca963710aa82d930e2b75e67ab5bcd1",
"head_commit_message": "remove lingering threading import",
"patch_to_review": "diff --git a/lib/matplotlib/backends/_backend_tk.py b/lib/matplotlib/backends/_backend_tk.py\nindex 69b57fc15d2a..326df873214e 100644\n--- a/lib/matplotlib/backends/_backend... | [
{
"diff_hunk": "@@ -65,11 +91,30 @@ def blit(photoimage, aggimage, offsets, bbox=None):\n y1 = max(math.floor(y1), 0)\n y2 = min(math.ceil(y2), height)\n bboxptr = (x1, x2, y1, y2)\n+ blank = False\n else:\n- photoimage.blank()\n bboxptr = (0, width, 0, height)\... | 0b1660bfbdf742d795edb1e742c0ee66b40bdef0 | diff --git a/lib/matplotlib/backends/_backend_tk.py b/lib/matplotlib/backends/_backend_tk.py
index 69b57fc15d2a..a6389944f3cf 100644
--- a/lib/matplotlib/backends/_backend_tk.py
+++ b/lib/matplotlib/backends/_backend_tk.py
@@ -1,3 +1,4 @@
+import uuid
from contextlib import contextmanager
import logging
import math
... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
mlflow__mlflow-9878@1f9361d | mlflow/mlflow | Python | 9,878 | Use `pyarrow.fs.HadoopFileSystem` in pyarrow > 2.0.0 | [](https://codespaces.new/maksboyarin/mlflow/pull/9878?quickstart=1)
### Related Issues/PRs
<!-- Uncomment 'Resolve' if this PR can close the linked items. -->
Resolve #8213
### What changes are proposed in this pull request?
Fixed a deprec... | 2023-10-09T09:12:02Z | [BUG] FutureWarning: pyarrow.hdfs.connect is deprecated
### Willingness to contribute
Yes. I can contribute a fix for this bug independently.
### MLflow version
2.2.2
### System information
- **OS Platform and Distribution (e.g., Linux Ubuntu 16.04)**: CentOS 7
- **Python version**: 3.9.6
- **pyarrow version**: ... | Suggested change:
* Switch to new API in this line: https://github.com/mlflow/mlflow/blob/master/mlflow/store/artifact/hdfs_artifact_repo.py#L188
* Require at least `2.0.0` pyarrow version in the setup.py
<!-- assign-maintainer -->
@BenWilson2 @dbczumar @harupy @WeichenXu123 Please assign a maintainer and start tri... | [
{
"body": "### Willingness to contribute\n\nYes. I can contribute a fix for this bug independently.\n\n### MLflow version\n\n2.2.2\n\n### System information\n\n- **OS Platform and Distribution (e.g., Linux Ubuntu 16.04)**: CentOS 7\r\n- **Python version**: 3.9.6\r\n- **pyarrow version**: 5.0.0\r\n\n\n### Descri... | 2d105c0896f3d2c3a9d96618438787e91487a2a8 | {
"head_commit": "1f9361dc21e07b126ed0c205676ad87ef0dbaacd",
"head_commit_message": "made the changes version-specific\n\nSigned-off-by: maksboyarin <99800578+maksboyarin@users.noreply.github.com>",
"patch_to_review": "diff --git a/mlflow/store/artifact/hdfs_artifact_repo.py b/mlflow/store/artifact/hdfs_artifact_... | [
{
"diff_hunk": "@@ -183,14 +183,22 @@ def hdfs_system(scheme, host, port):\n host = scheme + \"://\" + host\n else:\n host = \"default\"\n-\n- connected = pa.hdfs.connect(\n- host=host,\n- port=port or 0,\n- user=kerberos_user,\n- kerb_ticket=kerb_ticket,\n- ... | 93579d557dfe0a03372ea572d837081df581d1c2 | diff --git a/mlflow/store/artifact/hdfs_artifact_repo.py b/mlflow/store/artifact/hdfs_artifact_repo.py
index cacbe2f8a3b41..f54260a4b3bbf 100644
--- a/mlflow/store/artifact/hdfs_artifact_repo.py
+++ b/mlflow/store/artifact/hdfs_artifact_repo.py
@@ -4,6 +4,8 @@
import urllib.parse
from contextlib import contextmanager... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
matplotlib__matplotlib-18956@d7cae82 | matplotlib/matplotlib | Python | 18,956 | Document rasterized parameter in pcolormesh() explicitly | Update _axes.py to include mentions of rasterization within pcolormesh fixes #17708
PyData sprint contribution to enhance the documentation of rasterization within the pcolormesh function. | 2020-11-15T20:36:25Z | Mention rasterized option in more methods
We should mention rasterized in a few places in the docstrings of relavent methods. Ie pcolormesh, contour etc. This option is probably the number one reason I started to use matplotlib, but it seems a lot of people don’t realize it exists. | Also, https://matplotlib.org/gallery/misc/rasterization_demo.html should get some explanatory text.
@timhoffm I'd like to take on this issue (putting explanatory text for rasterization demo)!
@jklymak How do you pass this through to contour? @philip-sparks worked on this a bit at the pydata sprint and we could not sor... | [
{
"body": "We should mention rasterized in a few places in the docstrings of relavent methods. Ie pcolormesh, contour etc. This option is probably the number one reason I started to use matplotlib, but it seems a lot of people don’t realize it exists. ",
"number": 17708,
"title": "Mention rasterized ... | d51638e408f88763d6122cb5b45553867f5ab1d3 | {
"head_commit": "d7cae82961b60c69fbaf7b35a5efc2cf5681a851",
"head_commit_message": "Update _axes.py",
"patch_to_review": "diff --git a/lib/matplotlib/axes/_axes.py b/lib/matplotlib/axes/_axes.py\nindex ef2e6c45f54e..32ade6a1a96b 100644\n--- a/lib/matplotlib/axes/_axes.py\n+++ b/lib/matplotlib/axes/_axes.py\n@@ -... | [
{
"diff_hunk": "@@ -5925,6 +5931,9 @@ def pcolormesh(self, *args, alpha=None, norm=None, cmap=None, vmin=None,\n snap : bool, default: False\n Whether to snap the mesh to pixel boundaries.\n \n+ rasterized: bool, optional\n+ Force rasterized (bitmap) drawing in vector backe... | d18a83ff654f8665b0363ddb52bf24927ed1c84b | diff --git a/lib/matplotlib/axes/_axes.py b/lib/matplotlib/axes/_axes.py
index ef2e6c45f54e..902b56c0fecb 100644
--- a/lib/matplotlib/axes/_axes.py
+++ b/lib/matplotlib/axes/_axes.py
@@ -5834,6 +5834,7 @@ def pcolormesh(self, *args, alpha=None, norm=None, cmap=None, vmin=None,
differences see :ref:`Differen... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "Documentation Updates"
} |
matplotlib__matplotlib-18181@4469385 | matplotlib/matplotlib | Python | 18,181 | Replace ttconv by plain python for pdf subsetting | ## PR Summary
## First commit:
Switch from a hand-written glyph outline decomposer to FreeType's one.
Instead of walking through FT_Outline ourselves, use FreeType's
FT_Outline_Decompose to decompose glyphs into paths.
Fixes incorrect positioning of first and last control points of certain
contours; compa... | 2020-08-05T10:22:11Z | Missing character upon savefig() with Free Serif font
<!--To help us understand and resolve your issue, please fill out the form to the best of your ability.-->
<!--You can feel free to delete the sections that do not apply.-->
### Bug report
**Bug summary**
Choosing the font "Free Serif".
Right parenthesi... | fwiw I cannot repro this locally: [out.pdf](https://github.com/matplotlib/matplotlib/files/4502401/out.pdf)
I can reproduce on Fedora 30; maybe the font was old?
Or not, because the font hasn't been touched in ages. TTF vs OTF, maybe?
In Inkscape, the closing parenthesis is there, but in evince, it's invisible. In okul... | [
{
"body": "<!--To help us understand and resolve your issue, please fill out the form to the best of your ability.-->\r\n<!--You can feel free to delete the sections that do not apply.-->\r\n\r\n### Bug report\r\n\r\n**Bug summary**\r\n\r\nChoosing the font \"Free Serif\".\r\n\r\nRight parenthesis character \")... | 627dd18e18cfb8e157fdc65ddae964a3ea0a4ece | {
"head_commit": "446938586dc50a1e8aed1971ba876e85a65f5ac9",
"head_commit_message": "Switch from a hand-written glyph outline decomposer to FreeType's one.\n\nInstead of walking through FT_Outline ourselves, use FreeType's\nFT_Outline_Decompose to decompose glyphs into paths.\n\nFixes incorrect positioning of first... | [
{
"diff_hunk": "@@ -1089,35 +1089,38 @@ void quad2cubic(double x0, double y0,\n void __add_number(double val, char format_code, int precision,\n std::string& buffer)\n {\n- char *str = PyOS_double_to_string(val, format_code, precision, 0, NULL);\n-\n- // Delete trailing zeros and decimal... | 19359c11c5778b625d0e9e6b8a26f04655342830 | diff --git a/lib/matplotlib/backends/backend_pdf.py b/lib/matplotlib/backends/backend_pdf.py
index e8e8ece1310c..bdd55eeeb8b4 100644
--- a/lib/matplotlib/backends/backend_pdf.py
+++ b/lib/matplotlib/backends/backend_pdf.py
@@ -42,7 +42,6 @@
from matplotlib.path import Path
from matplotlib.dates import UTC
from matpl... | {
"difficulty": "high",
"estimated_review_effort": 5,
"problem_domain": "Bug Fixes"
} |
matplotlib__matplotlib-18275@4018a62 | matplotlib/matplotlib | Python | 18,275 | feat: StepPatch | ## PR Summary
A new `StepPatch` artists based of `PathPatch` facilitation plotting histogram-like data and an associated `pyplot.stairs()` plotting function.
Implementation based on @timhoffm and @jklymak suggestions, after drafts and discussions in #15065 and #15019 and the discussion below.
Closes #6669 and ... | 2020-08-17T14:36:38Z | [Feature request] Functions for "manually" plotting histograms
matplotlib's `pyplot.hist` and `pyplot.hist2d` functions fill the supplied data into histogram bins and plot them, but very often users will have already done the first step (sorting data into bins) in their own code and are merely interested in presenting ... | How is what you're asking for different from passing in the already supported bin kwarg?
```
hist(x, bins=10, range=None, normed=False, weights=None, cumulative=False, bottom=None, histtype='bar', align='mid', orientation='vertical', rwidth=None, log=False, color=None, label=None, stacked=False, **kwargs)
hist2d(x, y... | [
{
"body": "matplotlib's `pyplot.hist` and `pyplot.hist2d` functions fill the supplied data into histogram bins and plot them, but very often users will have already done the first step (sorting data into bins) in their own code and are merely interested in presenting their results in a \"style\" that is evocati... | 5584ba7648b1ab258254fd516977cc15b1ae66f7 | {
"head_commit": "4018a62515947685f2b2fabfe1ae95247b18ed33",
"head_commit_message": "feat: add datetime test for StepPatch",
"patch_to_review": "diff --git a/.flake8 b/.flake8\nindex 20f404db4104..111f14d349e8 100644\n--- a/.flake8\n+++ b/.flake8\n@@ -162,6 +162,7 @@ per-file-ignores =\n examples/lines_bars_a... | [
{
"diff_hunk": "@@ -989,6 +989,122 @@ def set_path(self, path):\n self._path = path\n \n \n+class StepPatch(PathPatch):\n+ \"\"\"An unclosed step path patch.\"\"\"\n+\n+ @docstring.dedent_interpd\n+ def __init__(self, values, edges, *,\n+ orientation='vertical', baseline=0, **kw... | ecc54cb11180fc466f812df37d9bbc7fff94c39d | diff --git a/.flake8 b/.flake8
index 20f404db4104..111f14d349e8 100644
--- a/.flake8
+++ b/.flake8
@@ -162,6 +162,7 @@ per-file-ignores =
examples/lines_bars_and_markers/fill.py: E402
examples/lines_bars_and_markers/fill_between_demo.py: E402
examples/lines_bars_and_markers/filled_step.py: E402
+ exam... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
matplotlib__matplotlib-17897@d5959b5 | matplotlib/matplotlib | Python | 17,897 | Force origin='upper' in pyplot.specgram | ## PR Summary
Fix #17878
In ``pyplot.specgram``, the ``origin`` kwarg is popped. The ``origin`` is explicitly set to 'upper'
in the call to ``imshow`` inside ``pyplot.specgram``. Test added to check that changing the
``image.origin`` rcParam and the ``origin`` kwarg to 'lower' does not change the spectrogram.
... | 2020-07-12T17:15:46Z | flipping of imshow in specgram
<!--To help us understand and resolve your issue, please fill out the form to the best of your ability.-->
<!--You can feel free to delete the sections that do not apply.-->
### Bug report
**Bug summary**
The function
```python
matplotlib.pyplot.specgram
```
uses imshow int... | The semantics around extent / origin / the default extents is a bit complicated (see https://matplotlib.org/tutorials/intermediate/imshow_extent.html).
The relevant code for this is at https://github.com/matplotlib/matplotlib/blob/ec0132f66170dabc6352ba79d839b1dd9eb02157/lib/matplotlib/axes/_axes.py#L7551-L7552 I t... | [
{
"body": "<!--To help us understand and resolve your issue, please fill out the form to the best of your ability.-->\r\n<!--You can feel free to delete the sections that do not apply.-->\r\n\r\n### Bug report\r\n\r\n**Bug summary**\r\n\r\nThe function \r\n```python\r\nmatplotlib.pyplot.specgram\r\n```\r\nuses ... | c12dafdb3181bb18dc60ce7fc0f8e54e5cf66714 | {
"head_commit": "d5959b51d009e10cd892ad2845a37a313affd998",
"head_commit_message": "DOC: Remove note that origin='upper' in specgram\n\nThis note referenced the call to imshow inside of specgram, which might confuse users who do not know the implementation of specgram.",
"patch_to_review": "diff --git a/doc/api/... | [
{
"diff_hunk": "@@ -4099,6 +4099,33 @@ def test_specgram_fs_none():\n assert xmin == 32 and xmax == 96\n \n \n+@check_figures_equal(extensions=[\"png\"])\n+def test_specgram_origin_rcparam(fig_test, fig_ref):\n+ \"\"\"Test specgram ignores image.origin rcParam and uses origin 'upper'.\"\"\"\n+ t = np.... | 0d53e815b591183af93110803c6850800a13e53c | diff --git a/doc/api/next_api_changes/behavior/17897-KLP.rst b/doc/api/next_api_changes/behavior/17897-KLP.rst
new file mode 100644
index 000000000000..f53534e8d1b9
--- /dev/null
+++ b/doc/api/next_api_changes/behavior/17897-KLP.rst
@@ -0,0 +1,11 @@
+pyplot.specgram always uses origin='upper'
+~~~~~~~~~~~~~~~~~~~~~~~~~... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
matplotlib__matplotlib-19677@84c36d1 | matplotlib/matplotlib | Python | 19,677 | Convert axis limit units in Qt plot options widget | ## PR Summary
Qt backend's plot options widget converts axis limits to floats regardless of the actual data type. If the axes use e.g. datetime values, this makes editing the axis limits next to impossible.
This tries to solve the problem at least for datetime values by converting them to a proper type that can b... | 2021-03-10T12:58:12Z | Qt backend's Figure options to support axis units
<!--
Welcome! Thanks for thinking of a way to improve Matplotlib.
Before creating a new feature request please search the issues for relevant feature requests.
-->
### Problem
We often use datetimes on X axis. However, Qt backend's figure options dialog con... | That seems reasonable (in the absence of having a way to get unitized limits back, but I guess that's not going to happen until we have a general unconverter (https://github.com/matplotlib/matplotlib/pull/12270, https://github.com/matplotlib/matplotlib/pull/16922)).
Note that I'd guess the patch at https://github.com/... | [
{
"body": "<!--\r\nWelcome! Thanks for thinking of a way to improve Matplotlib.\r\n\r\n\r\nBefore creating a new feature request please search the issues for relevant feature requests.\r\n-->\r\n\r\n### Problem\r\n\r\nWe often use datetimes on X axis. However, Qt backend's figure options dialog converts these t... | d56e1b4c9ebf4deb7f6355f7fc392e4a075f0699 | {
"head_commit": "84c36d1d24da3a20e4453863c81f51560a961fa6",
"head_commit_message": "Fix unit tests on systems without Qt backend\n\nRe #19075",
"patch_to_review": "diff --git a/lib/matplotlib/backends/qt_editor/_formlayout.py b/lib/matplotlib/backends/qt_editor/_formlayout.py\nindex e2b371f1652d..2f690a8e109c 10... | [
{
"diff_hunk": "@@ -295,3 +311,25 @@ def crashing_callback(fig, stale):\n canvas = FigureCanvasQTAgg(fig)\n fig.stale = True\n assert called\n+\n+\n+@pytest.mark.backend('Qt5Agg', skip_on_importerror=True)\n+def test_form_widget_get_with_datetime_field():\n+ if not QtWidgets.QApplication.instance... | e347200c83f83c471070bcfd4c62e24f95b85753 | diff --git a/lib/matplotlib/backends/qt_editor/_formlayout.py b/lib/matplotlib/backends/qt_editor/_formlayout.py
index e2b371f1652d..2f690a8e109c 100644
--- a/lib/matplotlib/backends/qt_editor/_formlayout.py
+++ b/lib/matplotlib/backends/qt_editor/_formlayout.py
@@ -342,9 +342,17 @@ def get(self):
elif isi... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
matplotlib__matplotlib-17892@cb25841 | matplotlib/matplotlib | Python | 17,892 | Add earlier color validation | ## PR Summary
This PR fixes #17865 by raising an error when an invalid `color` argument is passed.
```
>>> plt.plot([1, 2], c="foobar")
ValueError: 'foobar' is not a valid value for color
```
I used the `_check_in_list` method of `cbook` but had to add an additional parameter to avoid printing all the col... | 2020-07-11T21:34:27Z | Earlier validation of color inputs
<!--To help us understand and resolve your issue, please fill out the form to the best of your ability.-->
<!--You can feel free to delete the sections that do not apply.-->
### Bug report
**Bug summary**
Currently Line2D only validates `color` at draw time, which can lead t... | [
{
"body": "<!--To help us understand and resolve your issue, please fill out the form to the best of your ability.-->\r\n<!--You can feel free to delete the sections that do not apply.-->\r\n\r\n### Bug report\r\n\r\n**Bug summary**\r\n\r\nCurrently Line2D only validates `color` at draw time, which can lead to ... | ec0132f66170dabc6352ba79d839b1dd9eb02157 | {
"head_commit": "cb25841bbb6f4bf515f3a1486028f86cebb02905",
"head_commit_message": "Add earlier color validation",
"patch_to_review": "diff --git a/lib/matplotlib/cbook/__init__.py b/lib/matplotlib/cbook/__init__.py\nindex dd8b6aed9b8a..cf29b569eb1d 100644\n--- a/lib/matplotlib/cbook/__init__.py\n+++ b/lib/matpl... | [
{
"diff_hunk": "@@ -2242,7 +2242,7 @@ def type_name(tp):\n type_name(type(v))))\n \n \n-def _check_in_list(_values, **kwargs):\n+def _check_in_list(_values, _print_supported_values=True, **kwargs):",
"line": null,
"original_line": 2245,
"original_start_line": null,
"path": "l... | 1aab9adb3cef05ea6bdd45910edaabe3b8550148 | diff --git a/lib/matplotlib/cbook/__init__.py b/lib/matplotlib/cbook/__init__.py
index dd8b6aed9b8a..034605e7dc1e 100644
--- a/lib/matplotlib/cbook/__init__.py
+++ b/lib/matplotlib/cbook/__init__.py
@@ -2242,21 +2242,38 @@ def type_name(tp):
type_name(type(v))))
-def _check_in_list(_values, **k... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
matplotlib__matplotlib-17830@f8017d4 | matplotlib/matplotlib | Python | 17,830 | Fix BoundaryNorm for multiple colors and one region | Fixes #17579. I don't understand why the scaling is `scalefac = (self.Ncmap - 1) / (self._n_regions - 1)`, and the logic when the number of colours is > the number of regions is not well defined in the dosctring so I don't know what it should be. This prevents the case with 1 region and > 1 colours from crashing though... | 2020-07-03T15:48:41Z | `BoundaryNorm` yield a `ZeroDivisionError: division by zero`
<!--To help us understand and resolve your issue, please fill out the form to the best of your ability.-->
<!--You can feel free to delete the sections that do not apply.-->
### Bug report
**Bug summary**
```
import matplotlib as mpl
import matpl... | This code path was changed a bin on master branchhttps://github.com/matplotlib/matplotlib/pull/17534 but does not fix this issue.
We need to add logic to https://github.com/matplotlib/matplotlib/blob/af7beaa35cec464547c212699b2843117c411d22/lib/matplotlib/colors.py#L1488-L1490 to handle the case were we only have 1 ... | [
{
"body": "<!--To help us understand and resolve your issue, please fill out the form to the best of your ability.-->\r\n<!--You can feel free to delete the sections that do not apply.-->\r\n\r\n### Bug report\r\n\r\n**Bug summary**\r\n\r\n```\r\nimport matplotlib as mpl\r\nimport matplotlib.pyplot as plt\r\ncm... | 3f4d4c719b0bfbdf9b98b49eebe0f7e7536daa93 | {
"head_commit": "f8017d4a646a45d2e3027bf148d451cbf5d42ae7",
"head_commit_message": "DOC: add inline explanation of the re-scaling logic in BoundrayNorm",
"patch_to_review": "diff --git a/lib/matplotlib/colors.py b/lib/matplotlib/colors.py\nindex b1e76e27175b..dd8718e31b7d 100644\n--- a/lib/matplotlib/colors.py\n... | [
{
"diff_hunk": "@@ -1473,34 +1473,53 @@ def __init__(self, boundaries, ncolors, clip=False, *, extend='neither'):\n self.Ncmap = ncolors\n self.extend = extend\n \n- self._N = self.N - 1 # number of colors needed\n+ self._n_regions = self.N - 1 # number of colors needed\n ... | 39b5dfcb34e3551873671d389b21590bb678c53b | diff --git a/lib/matplotlib/colors.py b/lib/matplotlib/colors.py
index b1e76e27175b..f89017b87a82 100644
--- a/lib/matplotlib/colors.py
+++ b/lib/matplotlib/colors.py
@@ -1429,9 +1429,9 @@ def __init__(self, boundaries, ncolors, clip=False, *, extend='neither'):
Parameters
----------
boundari... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
matplotlib__matplotlib-17822@1db51d4 | matplotlib/matplotlib | Python | 17,822 | Check for float values for min/max values to ax{v,h}line | Fixes #12198. This now errors if a non-float value is provided for xmin/xmax or ymin/ymax to ax{v,h}{line,span}. This should get an API change or a what's new, but I'm not sure which, could someone advise? | 2020-07-02T18:39:54Z | axvline incorrectly tries to handle unitized ymin, ymax
After
```
line = plt.axvline(
x=.5, ymin=matplotlib.dates.num2date(1), ymax=matplotlib.dates.num2date(1.05))
line.set_clip_on(False)
```
and panning the axes around, one sees that matplotlib (3.0) converted ymin and ymax to the scalar values 1 and 1.05, ... | This is still a bug...
I don't understand what panning has to do with this?
it's just to show that 1 and 1.05 have been interpreted as dates, not unitless axes-coordinates values.
But they haven't, they wer... | [
{
"body": "After\r\n```\r\nline = plt.axvline(\r\n x=.5, ymin=matplotlib.dates.num2date(1), ymax=matplotlib.dates.num2date(1.05))\r\nline.set_clip_on(False)\r\n```\r\nand panning the axes around, one sees that matplotlib (3.0) converted ymin and ymax to the scalar values 1 and 1.05, which is not correct: ymi... | c12dafdb3181bb18dc60ce7fc0f8e54e5cf66714 | {
"head_commit": "1db51d4b36485483305d48437ae22b3985775e5e",
"head_commit_message": "Check for float values for min/max values to ax{v,h}line",
"patch_to_review": "diff --git a/lib/matplotlib/axes/_axes.py b/lib/matplotlib/axes/_axes.py\nindex eaf94407e1ea..14a2c3692651 100644\n--- a/lib/matplotlib/axes/_axes.py\... | [
{
"diff_hunk": "@@ -899,11 +900,10 @@ def axvline(self, x=0, ymin=0, ymax=1, **kwargs):\n \n >>> axvline(x=.5, ymin=0.25, ymax=0.75)\n \"\"\"\n-\n+ self._check_no_units([ymin, ymax], ['ymin', 'ymax'])\n if \"transform\" in kwargs:\n- raise ValueError(\n- ... | 65e4afdb4ac3fe65e202753fc927d98b4c84a1b6 | diff --git a/lib/matplotlib/axes/_axes.py b/lib/matplotlib/axes/_axes.py
index eaf94407e1ea..b9b63d3aebaa 100644
--- a/lib/matplotlib/axes/_axes.py
+++ b/lib/matplotlib/axes/_axes.py
@@ -29,6 +29,7 @@
import matplotlib.ticker as mticker
import matplotlib.transforms as mtransforms
import matplotlib.tri as mtri
+impor... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
matplotlib__matplotlib-17470@856ca76 | matplotlib/matplotlib | Python | 17,470 | FIX: add guardrails for too big tk figures | ## PR Summary
Depending on the version of xserver creating a too big tk window
either corrupts xorg (!) or causes the process to exit. This adds a
guard rail that will convert this into a python exception instead.
closes #17460
## PR Checklist
- [ ] Has Pytest style unit tests
- [k] Code is [Flake 8](... | 2020-05-21T02:47:34Z | set_size_inches with a width over 14090 crashes Xorg
<!--To help us understand and resolve your issue, please fill out the form to the best of your ability.-->
<!--You can feel free to delete the sections that do not apply.-->
### Bug report
**Bug summary**
Calling set_size_inches with w=14090.5 causes Xorg t... | Thanks for the report!
Can you try with a newer version of Matplotlib? 2.0 is pretty old at this point. We have added some better checking of too-big images. We do not want to clip to the screen size as you may need to make a figure that is bigger than your screen if you were going to print it on a poster, howeve... | [
{
"body": "<!--To help us understand and resolve your issue, please fill out the form to the best of your ability.-->\r\n<!--You can feel free to delete the sections that do not apply.-->\r\n\r\n### Bug report\r\n\r\n**Bug summary**\r\n\r\nCalling set_size_inches with w=14090.5 causes Xorg to lock up and corrup... | 912752596322c50f66233c1912aa00bba5afe70f | {
"head_commit": "856ca7669dd6c6b4bb90d5f634c588585133a991",
"head_commit_message": "FIX: add guardrails for too big tk figures on linux\n\nDepending on the version of xserver creating a too big tk window\neither corrupts xorg (!) or causes the process to exit. This adds a\nguard rail that will convert this into a... | [
{
"diff_hunk": "@@ -431,6 +431,17 @@ def _get_toolbar(self):\n return toolbar\n \n def resize(self, width, height):\n+ max_size = 1_400_000 # the measured max on xorg 1.20.8 was 1_409_023\n+\n+ if (width > max_size or height > max_size) and sys.platform == 'linux':\n+ raise... | 32b914f02cf55acf1a62669b43de0d1f09c4c127 | diff --git a/lib/matplotlib/backends/_backend_tk.py b/lib/matplotlib/backends/_backend_tk.py
index 9132a859f90f..bc31d31e699b 100644
--- a/lib/matplotlib/backends/_backend_tk.py
+++ b/lib/matplotlib/backends/_backend_tk.py
@@ -431,6 +431,17 @@ def _get_toolbar(self):
return toolbar
def resize(self, widt... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
matplotlib__matplotlib-17625@b6bdcd1 | matplotlib/matplotlib | Python | 17,625 | Give _DummyAxis instances a __name__ | ## PR Summary
`ScalarFormatter.format_data_short` uses `self.axis.__name__` to determine whether it is working with an x-axis, a y-axis, or something else, presumably a _DummyAxis instance. This was failing in the z-cursor formatting of image-like plots for a the colorbar use case with boundaries specified. This cou... | 2020-06-13T05:02:21Z | _DummyAxis needs a __name__ attribute for ScalarFormatter
<!--To help us understand and resolve your issue, please fill out the form to the best of your ability.-->
<!--You can feel free to delete the sections that do not apply.-->
### Bug report
**Bug summary**
`ScalarFormatter.format_data_short(x)` uses `s... | This bug is triggered in normal usage by the following, if you move the cursor over the image:
```python
import numpy as np
import matplotlib.pyplot as plt
import matplotlib.colors as mcolors
z = np.arange(9).reshape((3, 3)).astype(float)
fig, ax = plt.subplots()
im = ax.imshow(z)
cbar = fig.colorbar(im, ax=a... | [
{
"body": "<!--To help us understand and resolve your issue, please fill out the form to the best of your ability.-->\r\n<!--You can feel free to delete the sections that do not apply.-->\r\n\r\n### Bug report\r\n\r\n**Bug summary**\r\n\r\n`ScalarFormatter.format_data_short(x)` uses `self.axis__name__` to get x... | f80d56e69ba2b8a583540c75f1bf8494738839cc | {
"head_commit": "b6bdcd1086371b64e8cb4e0501ba4bb06df2d995",
"head_commit_message": "Handle axis instances even if they don't have a __name__.",
"patch_to_review": "diff --git a/lib/matplotlib/tests/test_ticker.py b/lib/matplotlib/tests/test_ticker.py\nindex 263df149de5d..611b5cf968d8 100644\n--- a/lib/matplotlib... | [
{
"diff_hunk": "@@ -693,7 +695,8 @@ def format_data_short(self, value):\n if isinstance(value, Integral):\n fmt = \"%d\"\n else:\n- if self.axis.__name__ in [\"xaxis\", \"yaxis\"]:\n+ if (hasattr(self.axis, '__name__') and\n+ self.axis.__name_... | f458fc493e5570210d847edb1348711e349e521c | diff --git a/lib/matplotlib/tests/test_ticker.py b/lib/matplotlib/tests/test_ticker.py
index 263df149de5d..611b5cf968d8 100644
--- a/lib/matplotlib/tests/test_ticker.py
+++ b/lib/matplotlib/tests/test_ticker.py
@@ -510,6 +510,14 @@ class TestScalarFormatter:
(True, (6, 6), (-1e5, 1e5), 6, False),
]
+ ... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
letta-ai__letta-2423@9abf0b9 | letta-ai/letta | Python | 2,423 | fix: include missing function arguments in error handling | **Please describe the purpose of this pull request.**
This pr changes `letta/agent.py` file by adding `function_args` as a parameter to several methods, so to ensure that function arguments are correctly passed and logged during error handling process.
**Related issues or PRs**
resolves #2422
| 2025-02-09T13:46:44Z | name 'function_args' is not defined
**Describe the bug**
When chatting with the Letta-created agents, I got the following error:
```sh
error = name 'function_args' is not defined
Letta.letta.agent - ERROR - step() failed with an unrecognized exception: 'name 'function_args' is not defined'
Letta.letta.server.server - ... | [
{
"body": "**Describe the bug**\nWhen chatting with the Letta-created agents, I got the following error:\n\n```sh\nerror = name 'function_args' is not defined\nLetta.letta.agent - ERROR - step() failed with an unrecognized exception: 'name 'function_args' is not defined'\nLetta.letta.server.server - ERROR - Err... | a8585ae2c08a2e3df28403134889d2bd63c3f382 | {
"head_commit": "9abf0b9e695ed94d76e256b3189c2a1d8dead92f",
"head_commit_message": "fix: include missing function arguments in error handling",
"patch_to_review": "diff --git a/letta/agent.py b/letta/agent.py\nindex bb082fbf7f..ce36173ab6 100644\n--- a/letta/agent.py\n+++ b/letta/agent.py\n@@ -260,6 +260,7 @@ de... | [
{
"diff_hunk": "@@ -260,6 +260,7 @@ def _handle_function_error_response(\n error_msg: str,\n tool_call_id: str,\n function_name: str,\n+ function_args: str,",
"line": null,
"original_line": 263,
"original_start_line": null,
"path": "letta/agent.py",
"start_line... | 059aa3d085c795441fceca662ee3944073bd1434 | diff --git a/letta/agent.py b/letta/agent.py
index bb082fbf7f..7b4b94b8a0 100644
--- a/letta/agent.py
+++ b/letta/agent.py
@@ -260,6 +260,7 @@ def _handle_function_error_response(
error_msg: str,
tool_call_id: str,
function_name: str,
+ function_args: dict,
function_response: ... | {
"difficulty": "medium",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} | |
mlflow__mlflow-7922@800a1f7 | mlflow/mlflow | Python | 7,922 | [#7921] Modify pytorch predict to use the GPU if it's available | <!-- 🚨 We recommend pull requests be filed from a non-master branch on a repository fork (e.g. <username>:fix-xxx). 🚨 -->
## Related Issues/PRs
Resolve #7921
## What changes are proposed in this pull request?
This PR proposes a modification in the PyTorch flavor's scoring methodology to use the GPU by de... | 2023-03-01T21:59:04Z | [FR] PyTorch predictions should use the GPU when available
### Willingness to contribute
Yes. I can contribute this feature independently.
### Proposal Summary
When running MLflow's Pytorch predict function, if you want to use the GPU, it's required to pass in the device flag to the predict function. However, PyTorc... | [
{
"body": "### Willingness to contribute\n\nYes. I can contribute this feature independently.\n\n### Proposal Summary\n\nWhen running MLflow's Pytorch predict function, if you want to use the GPU, it's required to pass in the device flag to the predict function. However, PyTorch offers functionality that lets u... | c18744336e0b78dc82175551a6f26eafe2fc9bc4 | {
"head_commit": "800a1f7152170fbb8183a30df8bbb182c6a25b31",
"head_commit_message": "modify pytorch predict to use the GPU if it's available\n\nSigned-off-by: Ankit Mathur <ankit.mathur@databricks.com>",
"patch_to_review": "diff --git a/mlflow/environment_variables.py b/mlflow/environment_variables.py\nindex aa7a... | [
{
"diff_hunk": "@@ -769,9 +771,15 @@ class _PyTorchWrapper:\n def __init__(self, pytorch_model):\n self.pytorch_model = pytorch_model\n \n- def predict(self, data, device=\"cpu\"):\n+ def predict(self, data, device=_DEFAULT_PYTORCH_PREDICTION_DEVICE):\n import torch\n-\n+ if not... | 2df0d0a7ec9e77e112b55b8ad59ec3772c26b9f6 | diff --git a/docs/source/models.rst b/docs/source/models.rst
index 98a351069a452..0c2c032f9b67f 100644
--- a/docs/source/models.rst
+++ b/docs/source/models.rst
@@ -745,6 +745,12 @@ produced by :py:func:`mlflow.pytorch.save_model()` and :py:func:`mlflow.pytorch.
the ``python_function`` flavor, allowing you to load the... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
matplotlib__matplotlib-17355@f62a209 | matplotlib/matplotlib | Python | 17,355 | Change subprocess for inkscape version detection | Use the `--without-gui` (`-z`) for inkscape to prevent depending on an X server for version detection
## PR Summary
A very small change to how inkscape version detection is implemented in order to prevent depending on access to the interactive X session (on Linux, at least)
Resolves #17354
(Apologies if th... | 2020-05-07T17:25:44Z | Converter detection fails for inkscape if on headless system without DISPLAY
<!--To help us understand and resolve your issue, please fill out the form to the best of your ability.-->
<!--You can feel free to delete the sections that do not apply.-->
### Bug report
**Bug summary**
When running `mpl._get_execu... | This can also be solved with a simple `unset DISPLAY` from within the ssh session, but I think it would be better to have matplotlib deal with this situation gracefully | [
{
"body": "<!--To help us understand and resolve your issue, please fill out the form to the best of your ability.-->\r\n<!--You can feel free to delete the sections that do not apply.-->\r\n\r\n### Bug report\r\n\r\n**Bug summary**\r\n\r\nWhen running `mpl._get_executable_info('inkscape')` on a system where `D... | 9e20541c9dc826ed60e0baaaf8c6e15fbfe989ad | {
"head_commit": "f62a2091eba3a685bbb3d4ad55a327c24aaf161e",
"head_commit_message": "Fix remaining flake8 issue",
"patch_to_review": "diff --git a/lib/matplotlib/__init__.py b/lib/matplotlib/__init__.py\nindex 103b650c984b..9e3f3c02dbcd 100644\n--- a/lib/matplotlib/__init__.py\n+++ b/lib/matplotlib/__init__.py\n@... | [
{
"diff_hunk": "@@ -330,7 +330,14 @@ def impl(args, regex, min_ver=None, ignore_exit_code=False):\n message = \"Failed to find a Ghostscript installation\"\n raise ExecutableNotFoundError(message)\n elif name == \"inkscape\":\n- info = impl([\"inkscape\", \"-V\"], \"^Inkscape ([^ ]*)\... | 5962f1adf0345c08223d274d0745a167396e399b | diff --git a/lib/matplotlib/__init__.py b/lib/matplotlib/__init__.py
index 103b650c984b..9154d5f7f4b8 100644
--- a/lib/matplotlib/__init__.py
+++ b/lib/matplotlib/__init__.py
@@ -330,7 +330,14 @@ def impl(args, regex, min_ver=None, ignore_exit_code=False):
message = "Failed to find a Ghostscript installation"
... | {
"difficulty": "low",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
mlflow__mlflow-7123@5c5c02b | mlflow/mlflow | Python | 7,123 | Add 'save_format' param to Keras autolog() | Signed-off-by: Bruno Alvisio <bruno.alvisio@gmail.com>
<!-- 🚨 We recommend pull requests be filed from a non-master branch on a repository fork (e.g. <username>:fix-xxx). 🚨 -->
## Related Issues/PRs
Resolve https://github.com/mlflow/mlflow/issues/7024
## What changes are proposed in this pull request?
... | 2022-10-20T18:59:28Z | [FR] Allowing changing the Keras serialization format when using `mlflow.keras.autolog()`
### Willingness to contribute
Yes. I would be willing to contribute this feature with guidance from the MLflow community.
### Proposal Summary
Currently, it is not possible to change the serialization format of the Keras models... | Hi @balvisio, thank you for your feature request. I think that introducing a `save_format` argument to `mlflow.tensorflow.autolog()` makes sense to me, which may be slightly easier to implement and easier for users to reason about than generic **kwargs for `mlflow.tensorflow.autolog()`. We would be very excited to revi... | [
{
"body": "### Willingness to contribute\n\nYes. I would be willing to contribute this feature with guidance from the MLflow community.\n\n### Proposal Summary\n\nCurrently, it is not possible to change the serialization format of the Keras models (tf) to HDF% when using the `mlflow.keras.autolog()`. It would b... | 1be4d5b9cf13a6e009afc30c230df396ce42d100 | {
"head_commit": "5c5c02bba869bb4d800eebcb83e2be73211bdbe4",
"head_commit_message": "Add 'save_format' param to Keras autolog()\n\nSigned-off-by: Bruno Alvisio <bruno.alvisio@gmail.com>",
"patch_to_review": "diff --git a/mlflow/keras.py b/mlflow/keras.py\nindex 0c6604098f88c..3bfa41d1daaaf 100644\n--- a/mlflow/ke... | [
{
"diff_hunk": "@@ -681,6 +685,12 @@ def autolog(\n stacklevel=2,\n )\n \n+ if save_format != \"tf\" and save_format != \"h5\":\n+ raise Exception(\n+ \"Invalid value for `save_format` argument. \"",
"line": null,
"original_line": 690,
"original_start_line": ... | b11591d507e71865e07898b84e5883447fb50abf | diff --git a/mlflow/keras.py b/mlflow/keras.py
index 0c6604098f88c..b2f63c3144175 100644
--- a/mlflow/keras.py
+++ b/mlflow/keras.py
@@ -22,7 +22,7 @@
from mlflow.models import Model
from mlflow.models.model import MLMODEL_FILE_NAME
import mlflow.tracking
-from mlflow.exceptions import MlflowException
+from mlflow.e... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
mlflow__mlflow-7013@83d24e7 | mlflow/mlflow | Python | 7,013 | Add update_run() Python API | <!-- 🚨 We recommend pull requests be filed from a non-master branch on a repository fork (e.g. <username>:fix-xxx). 🚨 -->
## Related Issues/PRs
<!--
Please reference any related feature requests, issues, or PRs here. For example, `#123`. To automatically close the referenced items when this PR is merged, pleas... | 2022-10-11T07:53:58Z | [FR] rename_run in API
### Willingness to contribute
Yes. I would be willing to contribute this feature with guidance from the MLflow community.
### Proposal Summary
I need to rename many runs (~100 of them). I can do via the UI, but it would take too long.
Since the mlflow command doesn't provide this function, ... | The run name is just a tag under run and an attribute in `run.info`. You can write a simple function like this:
```python
import mlflow
from mlflow.tracking import MlflowClient
from mlflow.entities.run_status import RunStatus
def set_run_name(run_id, run_name):
run = mlflow.get_run(run_id)
client = Mlf... | [
{
"body": "### Willingness to contribute\n\nYes. I would be willing to contribute this feature with guidance from the MLflow community.\n\n### Proposal Summary\n\nI need to rename many runs (~100 of them). I can do via the UI, but it would take too long.\r\n\r\nSince the mlflow command doesn't provide this func... | b98bda05aa0257c327dd157bcc42251a406bbfef | {
"head_commit": "83d24e7830cfef375e7737aa0791f050f57e4345",
"head_commit_message": "remove fluent api\nSigned-off-by: gabrielfu <hfu.gabriel@gmail.com>",
"patch_to_review": "diff --git a/mlflow/tracking/_tracking_service/client.py b/mlflow/tracking/_tracking_service/client.py\nindex cd853749b5220..3df56c0b6f6e6 ... | [
{
"diff_hunk": "@@ -731,3 +731,12 @@ def test_delete_model_version_tag(mock_registry_store_with_get_latest_version):\n # delete_model_version_tag with version and stage not set\n with pytest.raises(MlflowException, match=\"version or stage must be set\"):\n MlflowClient().delete_model_version_ta... | 2f6b6ad382b690f57632673a04396309ed562494 | diff --git a/mlflow/tracking/_tracking_service/client.py b/mlflow/tracking/_tracking_service/client.py
index cd853749b5220..3df56c0b6f6e6 100644
--- a/mlflow/tracking/_tracking_service/client.py
+++ b/mlflow/tracking/_tracking_service/client.py
@@ -357,6 +357,29 @@ def delete_tag(self, run_id, key):
"""
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
letta-ai__letta-576@e0a2e40 | letta-ai/letta | Python | 576 | Add safeguard on tokens returned by functions | Closes #553
---
## Please describe the purpose of this pull request
We currently do not check the size of function responses to make sure they are under X tokens.
This is not a big deal for the base function set, but it a problem for custom functions (eg the HTTP request in extras) which can return huge res... | 2023-12-04T22:37:56Z | Lack of safeguard on tokens returned by external functions
**Describe the bug**
We currently do not check the size of function responses to make sure they are under X tokens.
This is not a big deal for the base function set, but it a problem for custom functions (eg the HTTP request in extras) which can return hu... | [
{
"body": "**Describe the bug**\r\n\r\nWe currently do not check the size of function responses to make sure they are under X tokens.\r\n\r\nThis is not a big deal for the base function set, but it a problem for custom functions (eg the HTTP request in extras) which can return huge responses. This will trigger ... | 093df8b46b852a0542ae0692de4a8686a1877214 | {
"head_commit": "e0a2e4018db4d134667ac33e2c4d7d518ef0dd5a",
"head_commit_message": "discuss function output length in custom function section",
"patch_to_review": "diff --git a/docs/functions.md b/docs/functions.md\nindex 02abe76164..7805ba0695 100644\n--- a/docs/functions.md\n+++ b/docs/functions.md\n@@ -34,6 +... | [
{
"diff_hunk": "@@ -88,6 +88,52 @@ def parse_json(string):\n raise e\r\n \r\n \r\n+def validate_function_response(function_response_string: any, strict: bool = False) -> str:\r\n+ \"\"\"Check to make sure that a function used by MemGPT returned a valid response\r\n+\r\n+ Responses need to be strin... | ee9b4a18474085c0442006f3824578dec0549d29 | diff --git a/docs/functions.md b/docs/functions.md
index 02abe76164..7805ba0695 100644
--- a/docs/functions.md
+++ b/docs/functions.md
@@ -34,6 +34,12 @@ There are three steps to adding more MemGPT functions:
The functions you write MUST have proper docstrings and type hints - this is because MemGPT will use the... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Security Patches / Vulnerability Fixes"
} | |
matplotlib__matplotlib-17028@b26c92a | matplotlib/matplotlib | Python | 17,028 | Changed return type of get_{x,y}ticklabels to plain list | ## PR Summary
Changed return type of get_{x,y}ticklabels to plain list
Fixes #16885
## PR Checklist
- [ ] Has Pytest style unit tests
- [ ] Code is [Flake 8](http://flake8.pycqa.org/en/latest/) compliant
- [ ] New features are documented, with examples if plot related
- [ ] Documentation is sphinx and nump... | 2020-04-04T11:47:44Z | Change return type get_{x,y}ticklabels to plain list
Its fairly often that I use `get_xticklabels` and other similar methods when exploring and visualizing data with matplotlib. I almost always use `list(ax.get_xticklabels())` or `ax.get_xticklabels()[0]` to view. When teaching, it's also much nicer to be able to see s... | I agree that especially for ticklabels, returning a plain list is fine -- it is "unlikely" that there are so many tick labels that this drowns out the terminal.
I think I see the purpose of a silent list - to shorten the output of those plotting methods that return many items (like `bar` or `plot`). I almost never want... | [
{
"body": "Its fairly often that I use `get_xticklabels` and other similar methods when exploring and visualizing data with matplotlib. I almost always use `list(ax.get_xticklabels())` or `ax.get_xticklabels()[0]` to view. When teaching, it's also much nicer to be able to see some of the labels without this wor... | 6253d80f0ff3d4b57fe6f6c1fe6d2ebb6dd204d8 | {
"head_commit": "b26c92aa3db92d9d3fae855c85f9ac7ab9674cca",
"head_commit_message": "doc changes",
"patch_to_review": "diff --git a/doc/api/next_api_changes/behaviour.rst b/doc/api/next_api_changes/behaviour.rst\nindex 9ebe3fe42240..a4d069f3a482 100644\n--- a/doc/api/next_api_changes/behaviour.rst\n+++ b/doc/api/... | [
{
"diff_hunk": "@@ -155,3 +155,12 @@ support for it will be dropped in a future Matplotlib release.\n ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n Previously, keyword arguments were silently ignored when no positional\n arguments were given.\n+\n+\n+`get_minor... | 399c61ca4c47aa0e9c0e8e7d3162f6c2268d2ae6 | diff --git a/doc/api/api_changes_3.3/behaviour.rst b/doc/api/api_changes_3.3/behaviour.rst
index e3b51e61bea1..12493029775a 100644
--- a/doc/api/api_changes_3.3/behaviour.rst
+++ b/doc/api/api_changes_3.3/behaviour.rst
@@ -98,9 +98,9 @@ deprecation warning.
`~.Axes.errorbar` now color cycles when only errorbar color i... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
matplotlib__matplotlib-16553@f0c49c4 | matplotlib/matplotlib | Python | 16,553 | DOC: clarify the expected shapes of eventplot input | closes #16546 | 2020-02-18T21:38:59Z | Problem with eventplot - error message claims events & lineoffsets are unequal sizes
### Bug report
**Matplotlib.pyplot eventplot function is raising an error when i try to generate a raster plot. Given a sequence of event timings, and an equally sized sequence of lineoffsets, the error message 'ValueError: lineoff... | You can either create a single event series, like
```
events=[197, 2175, 4153]
lineoffsets = [1]
plt.eventplot(events, lineoffsets=lineoffsets)
```
or 3 series like
```
events=np.array([[197, 2175, 4153]]).T
lineoffsets = [1, 1, 1]
plt.eventplot(events, lineoffsets=lineoffsets)
```
but creating a sing... | [
{
"body": "### Bug report\r\n\r\n**Matplotlib.pyplot eventplot function is raising an error when i try to generate a raster plot. Given a sequence of event timings, and an equally sized sequence of lineoffsets, the error message 'ValueError: lineoffsets and positions are unequal sized sequences' is returned. C... | b08ab4349ac1692be44e84d15dbc0ea60e4c1950 | {
"head_commit": "f0c49c488ade9a7c814df39c8c63ebeca360034e",
"head_commit_message": "DOC: clarify the expected shapes of eventplot input\n\ncloses #16546",
"patch_to_review": "diff --git a/lib/matplotlib/axes/_axes.py b/lib/matplotlib/axes/_axes.py\nindex 45ceb2c178ba..7f8d9113f978 100644\n--- a/lib/matplotlib/ax... | [
{
"diff_hunk": "@@ -1271,18 +1271,30 @@ def eventplot(self, positions, orientation='horizontal', lineoffsets=1,\n The offset of the center of the lines from the origin, in the\n direction orthogonal to *orientation*.\n \n+ If a sequence, then must match the dimension of *posit... | e9a6336ebd20d328ac50bbaaf78d023f3990fb2f | diff --git a/lib/matplotlib/axes/_axes.py b/lib/matplotlib/axes/_axes.py
index 45ceb2c178ba..733f778abe3d 100644
--- a/lib/matplotlib/axes/_axes.py
+++ b/lib/matplotlib/axes/_axes.py
@@ -1271,18 +1271,30 @@ def eventplot(self, positions, orientation='horizontal', lineoffsets=1,
The offset of the center of ... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "Bug Fixes"
} |
mlflow__mlflow-6881@dee9fc5 | mlflow/mlflow | Python | 6,881 | adding user_id attribute of RunInfo in search_runs | Signed-off-by: Subramaniam Shanmugam <subramaniam02@gmail.com>
<!-- 🚨 We recommend pull requests be filed from a non-master branch on a repository fork (e.g. <username>:fix-xxx). 🚨 -->
## Related Issues/PRs
<!--
Please reference any related feature requests, issues, or PRs here. For example, `#123`. To auto... | 2022-09-25T03:09:55Z | [FR] Add the ability to search runs based on 'user_id'
### Willingness to contribute
No. I cannot contribute this feature at this time.
### Proposal Summary
Enable run search to perform searches based on the `user_id` that submitted the run.
### Motivation
> #### What is the use case for this feature?
To return ... | <!-- assign-maintainer -->
@BenWilson2 @dbczumar @harupy @WeichenXu123 Please assign a maintainer and start triaging this issue. | [
{
"body": "### Willingness to contribute\n\nNo. I cannot contribute this feature at this time.\n\n### Proposal Summary\n\nEnable run search to perform searches based on the `user_id` that submitted the run. \n\n### Motivation\n\n> #### What is the use case for this feature?\r\nTo return runs that have been init... | 3f92b645b668e06764bb8ad3c8d1e5ceeb4d97ce | {
"head_commit": "dee9fc58ca3ed56640ee19cade23594d0cf28ed2",
"head_commit_message": "user_id filter for search_runs\n\nSigned-off-by: Subramaniam Shanmugam <subramaniam02@gmail.com>",
"patch_to_review": "diff --git a/docs/source/search-runs.rst b/docs/source/search-runs.rst\nindex 5a866a9988660..2a508c73ee8a6 100... | [
{
"diff_hunk": "@@ -323,6 +323,38 @@ def test_filter_runs_by_start_time():\n assert SearchUtils.filter(runs, \"attribute.start_time = 2\") == runs[2:]\n \n \n+def test_filter_runs_by_user_id():\n+ runs = [\n+ Run(\n+ run_info=RunInfo(\n+ run_uuid=\"a\",\n+ ... | 6e307be17ed277beea6e2409dc849ddf963cd436 | diff --git a/docs/source/search-runs.rst b/docs/source/search-runs.rst
index feb99aa7e4c92..ff5e57f7e306e 100644
--- a/docs/source/search-runs.rst
+++ b/docs/source/search-runs.rst
@@ -86,7 +86,7 @@ that have a leading number. If an entity name contains a leading number, enclose
Run Attributes
~~~~~~~~~~~~~~
-You c... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
matplotlib__matplotlib-16347@c7eddd6 | matplotlib/matplotlib | Python | 16,347 | FIX: catch warnings from pandas in cbook._check_1d | If we catch the warning or the exception, we need to cast to numpy
because later on in `_plot_args` we again use multi-dimensional
indexing to up-cast to a 2D array.
closes #16295
## PR Summary
## PR Checklist
- [x] Has Pytest style unit tests
- [x] Code is [Flake 8](http://flake8.pycqa.org/en/latest/) compliant
... | 2020-01-27T19:52:19Z | pyplot.plot using pandas series raises DeprecationWarning with pandas=1.0.0rc0
<!--To help us understand and resolve your issue, please fill out the form to the best of your ability.-->
<!--You can feel free to delete the sections that do not apply.-->
### Bug report
**Bug summary**
<!--A short 1-2 sentences ... | This is something we have sort of dealt with before (https://github.com/matplotlib/matplotlib/issues/14992 / https://github.com/matplotlib/matplotlib/pull/15007 and https://github.com/pandas-dev/pandas/issues/27775).
Looks like we are ready for the far future after the deprecation is done, but not the near future wh... | [
{
"body": "<!--To help us understand and resolve your issue, please fill out the form to the best of your ability.-->\r\n<!--You can feel free to delete the sections that do not apply.-->\r\n\r\n### Bug report\r\n\r\n**Bug summary**\r\n\r\n<!--A short 1-2 sentences that succinctly describes the bug-->\r\nThe co... | 5cb84e070bcb4ebc5ddd5b1c8e5e8a1eccec5863 | {
"head_commit": "c7eddd61c28dc198b35243a96e1b35f7030ac072",
"head_commit_message": "FIX: catch warnings from pandas in cbook._check_1d\n\nIf we catch the warning or the exception, we need to cast to numpy\nbecause later on in `_plot_args` we again use multi-dimensional\nindexing to up-cast to a 2D array.\n\ncloses... | [
{
"diff_hunk": "@@ -1367,11 +1367,22 @@ def _check_1d(x):\n return np.atleast_1d(x)\n else:\n try:\n- ndim = x[:, None].ndim\n # work around https://github.com/pandas-dev/pandas/issues/27775\n # which mean the shape is not as expected. That this ever worked... | 77e7b314fb4a9bc4bc2ab8ee8ee2a057a558ed1e | diff --git a/lib/matplotlib/cbook/__init__.py b/lib/matplotlib/cbook/__init__.py
index fbb9ee5f1ec0..7ea6fec67920 100644
--- a/lib/matplotlib/cbook/__init__.py
+++ b/lib/matplotlib/cbook/__init__.py
@@ -1367,11 +1367,33 @@ def _check_1d(x):
return np.atleast_1d(x)
else:
try:
- ndim = x... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
letta-ai__letta-58@d3a3a21 | letta-ai/letta | Python | 58 | Passable gpt-3.5-turbo support | Goal: get gpt-3.5-turbo functional, even if it's buggy
Closes #1
### Example: functional core memory corrections, but model misunderstands that heartbeats are coming from user (vs itself)
```sh
$ python main.py --model gpt-3.5-turbo-0613 --persona sam_simple_pov_gpt35
```
```text
Running... [exit by t... | 2023-10-20T20:40:29Z | Improve gpt-3.5-turbo performance
WIP
Current gpt-3.5-turbo performance is not very good due primarily due to bad understanding of function set (functions called at the wrong times, messages sent w/o call to `send_message`, etc.). Goal is to upload specific variations of the key prompts (tailored towards worse instr... | I'm not sure that this is possible for chatgpt-3.5 (or any version of chatGPT), but for open LLMs, there is this technique called grammar-based sampling which basically forces the LLM to answer according to some predetermined grammar, here is a Hacker News thread and link to a ggml PR describing it: https://news.ycombi... | [
{
"body": "WIP\r\n\r\nCurrent gpt-3.5-turbo performance is not very good due primarily due to bad understanding of function set (functions called at the wrong times, messages sent w/o call to `send_message`, etc.). Goal is to upload specific variations of the key prompts (tailored towards worse instruction foll... | e40c5ce61f5c7a0a15953ecd60cebbe720fe5d98 | {
"head_commit": "d3a3a21ddbf79a0a20a04fc5de39fed8eeb83c28",
"head_commit_message": "fix bad merge",
"patch_to_review": "diff --git a/main.py b/main.py\nindex 5b41b20e28..eaf9388700 100644\n--- a/main.py\n+++ b/main.py\n@@ -21,8 +21,8 @@\n from memgpt.persistence_manager import InMemoryStateManager, InMemoryState... | [
{
"diff_hunk": "@@ -64,7 +64,8 @@ def initialize_message_sequence(\n first_user_message = get_login_event() # event letting MemGPT know the user just logged in\r\n \r\n if include_initial_boot_message:\r\n- initial_boot_messages = get_initial_boot_messages('startup_with_send_message')\r\n+ ... | b0acc9aca0e4e963ff6f95125ec73f69a6f56a01 | diff --git a/main.py b/main.py
index 5b41b20e28..395153ec9c 100644
--- a/main.py
+++ b/main.py
@@ -21,8 +21,8 @@
from memgpt.persistence_manager import InMemoryStateManager, InMemoryStateManagerWithPreloadedArchivalMemory, InMemoryStateManagerWithFaiss
FLAGS = flags.FLAGS
-flags.DEFINE_string("persona", default=... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Performance Optimizations"
} |
matplotlib__matplotlib-15725@96bf24c | matplotlib/matplotlib | Python | 15,725 | Changed line color of boxplot for dark_background | ## PR Summary
Rework of #15705. Closes #15675.
Previously, the black outlines of boxes in boxplots were hidden inside the black background in the `dark_background` style.
Now: Outputs of boxplot_demo.py (https://matplotlib.org/examples/pylab_examples/boxplot_demo.html) using dark_background are as shown below:
... | 2019-11-19T06:56:11Z | Boxplot line color with style dark_background should be bright
<!--To help us understand and resolve your issue, please fill out the form to the best of your ability.-->
<!--You can feel free to delete the sections that do not apply.-->
### Bug report
```
%pylab inline
plt.style.use('dark_background')
plt.box... | ### **Normal:**
**Code:**
`%pylab inline`
`plt.boxplot([1,2,3])`
**Result:**
### **Dark Background:**
**Code:**
`%pylab inline`
`plt.style.use('dark_background')`
`plt.boxplot([1,2,3])`
**Result:*... | [
{
"body": "<!--To help us understand and resolve your issue, please fill out the form to the best of your ability.-->\r\n<!--You can feel free to delete the sections that do not apply.-->\r\n\r\n### Bug report\r\n\r\n```\r\n%pylab inline\r\nplt.style.use('dark_background')\r\nplt.boxplot([1,2,3])\r\n```\r\n\r\n... | cb904b187370119e965e5fe811f796772647e7df | {
"head_commit": "96bf24c8cc157e5f486d33581bd9eaeed0ca46fa",
"head_commit_message": "### Boxplots boxplot.boxprops.color: w boxplot.capprops.color: w boxplot.flierprops.color: w boxplot.flierprops.markeredgecolor: w boxplot.meanprops.color: g boxplot.medianprops.color: g boxplot.meanprops.markerfacecolor: g boxplot... | [
{
"diff_hunk": "@@ -21,3 +21,13 @@ figure.edgecolor: black\n savefig.facecolor: black\n savefig.edgecolor: black\n \n+### Boxplots\n+boxplot.boxprops.color: w\n+boxplot.capprops.color: w\n+boxplot.flierprops.color: w\n+boxplot.flierprops.markeredgecolor: w\n+boxplot.meanprops.color: g",
"line": null,
"o... | 5a184de332b2c2ddc872c8977e9ac380c5c8bfd0 | diff --git a/lib/matplotlib/mpl-data/stylelib/dark_background.mplstyle b/lib/matplotlib/mpl-data/stylelib/dark_background.mplstyle
index a8b754005bfd..c4b7741ae440 100644
--- a/lib/matplotlib/mpl-data/stylelib/dark_background.mplstyle
+++ b/lib/matplotlib/mpl-data/stylelib/dark_background.mplstyle
@@ -21,3 +21,9 @@ fig... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "Bug Fixes"
} |
matplotlib__matplotlib-15512@fd9f102 | matplotlib/matplotlib | Python | 15,512 | FIX: do not consider webagg and nbagg "interactive" for fallback | ## PR Summary
There is logic in pyplot to determine if the user has is some way
selected a backend which is incompatible with the interactive
framework that we detect is running. This helps prevent issues where
the user is already using one GUI frame work (ex tk) before Matplotlib
is imported and has Matplotlib... | 2019-10-25T04:24:35Z | 'MPLBACKEND=webagg' is overwritten by agg when $DISPLAY is not set on Linux
## Bug report
* The environment variable `MPLBACKEND=webagg` is overwritten by 'agg' when $DISPLAY is not set on Linux.
* The behavior of `backend:webagg` written in matplotlibrc was as same as `MPLBACKEND=webagg` (I tried).
* I want to a... | That is definitely a bug in the fallback logic to make sure we don't try to use a GUI backend on a headless server. I suspect we have miss-categorized `webagg` as a GUI backend.
Thanks for your reply!
Also, if `webagg.open_in_browser` is automatically set to `False` when `$DISPLAY` is not set,
I think it is very con... | [
{
"body": "## Bug report\r\n\r\n* The environment variable `MPLBACKEND=webagg` is overwritten by 'agg' when $DISPLAY is not set on Linux.\r\n* The behavior of `backend:webagg` written in matplotlibrc was as same as `MPLBACKEND=webagg` (I tried).\r\n* I want to avoid hard-coding the backend to .py file, because... | 7f171d6ed710b34c3811ec185e04b7fe681b7260 | {
"head_commit": "fd9f102e1a5fd6dacb9af697c8249b3493450ae6",
"head_commit_message": "TST: skip the nbagg test if we don't have IPython installed",
"patch_to_review": "diff --git a/lib/matplotlib/pyplot.py b/lib/matplotlib/pyplot.py\nindex 378dfef082b6..3a08cec7ad1c 100644\n--- a/lib/matplotlib/pyplot.py\n+++ b/li... | [
{
"diff_hunk": "@@ -0,0 +1,22 @@\n+import subprocess\n+import sys\n+import pytest\n+\n+\n+@pytest.mark.parametrize(\"backend\", [\"webagg\", \"nbagg\"])\n+def test_webagg_fallback(backend):\n+ if backend == \"nbagg\":\n+ pytest.importorskip(\"IPython\")\n+ test_code = (\n+ \"import os;\"\n+ ... | 557e56f85b60032fe39eea22ab59056269e9eb24 | diff --git a/lib/matplotlib/pyplot.py b/lib/matplotlib/pyplot.py
index 378dfef082b6..3a08cec7ad1c 100644
--- a/lib/matplotlib/pyplot.py
+++ b/lib/matplotlib/pyplot.py
@@ -2244,7 +2244,8 @@ def getname_val(identifier):
# requested, ignore rcParams['backend'] and force selection of a backend that
# is compatible with t... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
matplotlib__matplotlib-15592@91a78af | matplotlib/matplotlib | Python | 15,592 | Offset text position | ## PR Summary
fixes #5238 (sets offset text to top when using axis.tick_top())
Solves the issue that the power indicator (e.g. ``1e4``) stays on the bottom, even if the ticks are on the top.
## PR Checklist
- [x] Has Pytest style unit tests
- [x] Code is [Flake 8](http://flake8.pycqa.org/en/latest/) compliant
... | 2019-11-02T12:35:46Z | the offset of the scientific notation in xaxis stays at bottom when axis is set to top
the power indicator of an xaxis set to top stays on the bottom axis
I have seen that for the yaxis you have a function ax.yaxis.set_offset_position('right'), but I could not find any equivalent for the xaxis.
here is an example of ... | confirmed. I could have sworn we saw this bug before and addressed it...
This might require some invasive re-factoring of Axis so tagged for 2.1, if I am wrong and we can do this gently enough can go for 2.0.1.
Is there any workaround for this, e.g., using text? I can't seem to get similar text for the upper axis whe... | [
{
"body": "the power indicator of an xaxis set to top stays on the bottom axis\n\nI have seen that for the yaxis you have a function ax.yaxis.set_offset_position('right'), but I could not find any equivalent for the xaxis.\n\nhere is an example of the problem.\n\n`import matplotlib.pyplot as plt`\n`import numpy... | 47c33e0c634cb0aac5fd2299f4fd6a9e01576cd3 | {
"head_commit": "91a78af09d0030c8ba77a7d43061e2c2a663c5ef",
"head_commit_message": "Remove unnecessary .set_va",
"patch_to_review": "diff --git a/lib/matplotlib/axis.py b/lib/matplotlib/axis.py\nindex 5a1778cb311a..046efa50a87a 100644\n--- a/lib/matplotlib/axis.py\n+++ b/lib/matplotlib/axis.py\n@@ -2060,13 +2060... | [
{
"diff_hunk": "@@ -2060,13 +2060,26 @@ def _update_offset_text_position(self, bboxes, bboxes2):\n boxes of all the ticklabels\n \"\"\"\n x, y = self.offsetText.get_position()\n- if not len(bboxes):\n- bottom = self.axes.bbox.ymin\n+ if not hasattr(self, '_text_o... | c93455b9294501135affce8082a567aa354ed071 | diff --git a/doc/users/next_whats_new/2019-11-13-offset-text-position.rst b/doc/users/next_whats_new/2019-11-13-offset-text-position.rst
new file mode 100644
index 000000000000..ac9e58058034
--- /dev/null
+++ b/doc/users/next_whats_new/2019-11-13-offset-text-position.rst
@@ -0,0 +1,4 @@
+Offset text is now set to the t... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
mlflow__mlflow-6358@f560314 | mlflow/mlflow | Python | 6,358 | Increase maximum param value length to 500 | <!-- 🚨 We recommend pull requests be filed from a non-master branch on a repository fork (e.g. <username>:fix-xxx). 🚨 -->
## Related Issues/PRs
<!--
Fix for `#6183`.
Please reference any related feature requests, issues, or PRs here. For example, `#123`. To automatically close the referenced items when this ... | 2022-07-28T13:43:25Z | [BUG] Log_params seems to not use the correct maximum length of value
### Willingness to contribute
Yes. I would be willing to contribute a fix for this bug with guidance from the MLflow community.
### MLflow version
1.27.0
### System information
- **OS Platform and Distribution MacOS 12.1**:
- **Python version 3... | Thanks for reporting this ! I will help review your fixing PR.
The `log_params` limit the param value length <= 250 at here:
https://github.com/mlflow/mlflow/blob/8693a26bf2acd418aa93aa5ea2e5536caa199fc3/mlflow/utils/validation.py#L148
@dbczumar
Which param value length limitation shall we use ?
* `log_param`... | [
{
"body": "### Willingness to contribute\n\nYes. I would be willing to contribute a fix for this bug with guidance from the MLflow community.\n\n### MLflow version\n\n1.27.0\n\n### System information\n\n- **OS Platform and Distribution MacOS 12.1**:\r\n- **Python version 3.8.13**:\n\n### Describe the problem\n\... | d70bc928ebb29b72704e8e79eb8f13f52455785c | {
"head_commit": "f5603145cb3bd81e94b55af152654fecc5d609b0",
"head_commit_message": "1. added test for exceeding max length. 2. lint. 3. validation logic addresses null\n\nSigned-off-by: Jan Sindlar <jan.sindlar@eureka.ai>",
"patch_to_review": "diff --git a/mlflow/store/db_migrations/versions/d2999357da94_change_... | [
{
"diff_hunk": "@@ -1135,6 +1146,21 @@ def _create_run(self, fs):\n experiment_id=FileStore.DEFAULT_EXPERIMENT_ID, user_id=\"user\", start_time=0, tags=[]\n )\n \n+ def test_log_batch_max_length_value(self):\n+ param_entities = [Param(\"long param\", list(range(500))), Param(\"shor... | 001d811af624af74164e3f19653094d499231e76 | diff --git a/mlflow/store/db_migrations/versions/cc1f77228345_change_param_value_length_to_500.py b/mlflow/store/db_migrations/versions/cc1f77228345_change_param_value_length_to_500.py
new file mode 100644
index 0000000000000..84adbc0e549d4
--- /dev/null
+++ b/mlflow/store/db_migrations/versions/cc1f77228345_change_par... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
mlflow__mlflow-6354@07845c5 | mlflow/mlflow | Python | 6,354 | Timebased gc | <!-- 🚨 We recommend pull requests be filed from a non-master branch on a repository fork (e.g. <username>:fix-xxx). 🚨 -->
## Related Issues/PRs
<!--
Please reference any related feature requests, issues, or PRs here. For example, `#123`. To automatically close the referenced items when this PR is merged, ple... | 2022-07-28T10:23:54Z | [FR] Run `mlflow gc` based on time since last deletion
### Willingness to contribute
Yes. I would be willing to contribute this feature with guidance from the MLflow community.
### Proposal Summary
Adding more functionality to `mlflow gc`, where administrators can delete runs based on time criteria (e.g. delet... | Hi @Jason-CKY, thank you for requesting this feature. We would be very excited to review a PR that implements it. Feel free to file a pull request, and please let me know if you have any questions. cc @WeichenXu123
Thanks, was busy for the past few weeks. I will work on this and put up a PR for this feature! | [
{
"body": "### Willingness to contribute\r\n\r\nYes. I would be willing to contribute this feature with guidance from the MLflow community.\r\n\r\n### Proposal Summary\r\n\r\nAdding more functionality to `mlflow gc`, where administrators can delete runs based on time criteria (e.g. delete runs that have been ta... | ca5b76c1cb3823b06c26e464f466d585703ebd7d | {
"head_commit": "07845c5abc52c05e4f227fff06f3ed76199c3908",
"head_commit_message": "Added --older-than flag in mlflow gc command, and added tests for that cli command\n\nSigned-off-by: Jason Cheng <jasoncky96@gmail.com>",
"patch_to_review": "diff --git a/mlflow/cli.py b/mlflow/cli.py\nindex c35c193d166fe..9ab1a6... | [
{
"diff_hunk": "@@ -636,6 +636,9 @@ message RunInfo {\n // Unix timestamp of when the run ended in milliseconds.\n optional int64 end_time = 9;\n \n+ // Unix timestamp of when the run is deleted in milliseconds.\n+ optional int64 delete_time = 10;\n+",
"line": null,
"original_line": 641,
"orig... | df1fedeadc6aa0808fe0fd4e787551dce320a61d | diff --git a/mlflow/cli.py b/mlflow/cli.py
index e2976508e89ab..fabb1b0ebf2ab 100644
--- a/mlflow/cli.py
+++ b/mlflow/cli.py
@@ -1,16 +1,19 @@
import json
import os
+import re
import sys
import logging
import click
from click import UsageError
+from datetime import timedelta
import mlflow.db
import mlflow.e... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
matplotlib__matplotlib-15149@9db17df | matplotlib/matplotlib | Python | 15,149 | pyplot.style.use() to accept pathlib.Path objects as arguments | ## PR Summary
Currently the pyplot.style.use() supports strings, list, and dic as function arguments where string can be a library style or path/URL to style file. Added the code to leverage the function to use pathlib.Path object as an argument.
Fixes #15138
## PR Checklist
- [X] Has Pytest style unit tests... | 2019-08-28T06:02:43Z | Make plt.style.use accept path-like objects in addition to string
`plt.style.use(style)` accepts a `str`, `dict`, or `list`. The `str `can be either the name of a style or a path/URL to a style file. I propose that this also accept a pathlike object (`pathlib.Path`) so that it is unneccesary to cast it like `plt.style.... | This should be a fairly straightforward enhancement, changing a few `isinstance`s and perhaps adding a cast to `str` internally (if necessary).
Hi @QuLogic,
If no one is working on this problem than I would like to give it a shot. Also can you please guide me from where should I start?
Thank You!
Om.
You will ne... | [
{
"body": "`plt.style.use(style)` accepts a `str`, `dict`, or `list`. The `str `can be either the name of a style or a path/URL to a style file. I propose that this also accept a pathlike object (`pathlib.Path`) so that it is unneccesary to cast it like `plt.style.use(str(my_path))`, but accept it like this `pl... | 8ed7c78725f948cf99ef65df53d4b9b23fc39d6a | {
"head_commit": "9db17dfda7d92fbc72b0f96abeee1a3fdfbbbbba",
"head_commit_message": "Update lib/matplotlib/tests/test_style.py\n\nCo-Authored-By: Elliott Sales de Andrade <quantum.analyst@gmail.com>",
"patch_to_review": "diff --git a/lib/matplotlib/__init__.py b/lib/matplotlib/__init__.py\nindex b7cac2a11fa1..d26... | [
{
"diff_hunk": "@@ -948,7 +948,7 @@ def rc_params_from_file(fname, fail_on_error=False, use_default_template=True):\n \n Parameters\n ----------\n- fname : str\n+ fname : str, path-like",
"line": null,
"original_line": 951,
"original_start_line": null,
"path": "lib/matplotlib/__ini... | 0c3a7eaf6f5831643acf1082418fedae8acb5d75 | diff --git a/lib/matplotlib/__init__.py b/lib/matplotlib/__init__.py
index b7cac2a11fa1..81792d2dc68f 100644
--- a/lib/matplotlib/__init__.py
+++ b/lib/matplotlib/__init__.py
@@ -948,7 +948,7 @@ def rc_params_from_file(fname, fail_on_error=False, use_default_template=True):
Parameters
----------
- fname ... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "New Feature Additions"
} |
matplotlib__matplotlib-14979@d66a760 | matplotlib/matplotlib | Python | 14,979 | FIX: Don't enable IPython integration if not entering REPL. | IPython can also be used to simply run files; when this is the case we
are not going to be interactive; and we do not want to enable the
eventloop integration. Otherwise someone doing:
$ ipython script.py
Will simply see a window blink, as IPython will exit immediately instead
of showing the window and exi... | 2019-08-05T03:53:51Z | Matplotlib plt.show() not working in IPython 7.5/7.6 on macOS
I have a simple script from a live training course I teach. The script displays a Seaborn barplot in a Matplotlib Figure and has worked for well over a year without any issues.
If I run the script from a macOS Terminal window with IPython 7.5 or 7.6 (ins... | Can you share the script (even privately by email) ?
The 7.4->7.5 changes were really minimal and did not touch the matpltlib integrations so I'm not sure. 7.6 has a but with the `%matplotlib` magic.
Sure. Where should I send it?
You can send it to me, `bussonniermatthias@gmail.com`.
What Matplotlib backend? W... | [
{
"body": "I have a simple script from a live training course I teach. The script displays a Seaborn barplot in a Matplotlib Figure and has worked for well over a year without any issues. \r\n\r\nIf I run the script from a macOS Terminal window with IPython 7.5 or 7.6 (installed from Anaconda), it does not show... | 73e2f562bff000e8c3f1718151bda968fae89e0a | {
"head_commit": "d66a7608485a84a62913bd5280862aa4cbbb43da",
"head_commit_message": "FIX: preserve interactive state around ip.enable_matplotlib()\n\ncloses #14950",
"patch_to_review": "diff --git a/lib/matplotlib/backend_bases.py b/lib/matplotlib/backend_bases.py\nindex dfa18b92079f..da4adabfcc37 100644\n--- a/l... | [
{
"diff_hunk": "@@ -1649,9 +1663,18 @@ def _fix_ipython_backend2gui(cls):\n # Work around pylabtools.find_gui_and_backend always reading from\n # rcParamsOrig.\n orig_origbackend = mpl.rcParamsOrig[\"backend\"]\n+\n try:\n mpl.rcParamsOrig[\"backen... | bc65530323df308a8abe144a033eed26874d3930 | diff --git a/lib/matplotlib/backend_bases.py b/lib/matplotlib/backend_bases.py
index dfa18b92079f..9aad6a843e71 100644
--- a/lib/matplotlib/backend_bases.py
+++ b/lib/matplotlib/backend_bases.py
@@ -1553,6 +1553,20 @@ def _draw(renderer): raise Done(renderer)
return figure._cachedRenderer
+def _is_non_... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
mlflow__mlflow-6085@c9faa01 | mlflow/mlflow | Python | 6,085 | adding MlflowClient to top level mlflow package | Signed-off-by: subramaniam02 <subramaniam02@gmail.com>
## Related Issues/PRs
Close #6080
## What changes are proposed in this pull request?
- added MlflowClient at top level mlflow package
- changed all references of `from mlflow.tracking import MlflowClient`
## How is this patch tested?
- [ ] I have ... | 2022-06-17T00:13:37Z | [FR] [Roadmap] Alias client at top-level
## MLflow Roadmap Item
This is an MLflow Roadmap item that has been prioritized by the MLflow maintainers. We’ve identified this feature as a highly requested addition to the MLflow package based on community feedback.
We're seeking a community contribution for the implemen... | @BenWilson2 I am willing to contribute.
@subramaniam02 awesome! Thanks for taking this!
Please perform a search within MLflow after creating the alias and replace all in-code references to the alias (including tests) and let me know if you have any questions while working on the PR!
@BenWilson2 I am thinking of creat... | [
{
"body": "## MLflow Roadmap Item\r\n\r\nThis is an MLflow Roadmap item that has been prioritized by the MLflow maintainers. We’ve identified this feature as a highly requested addition to the MLflow package based on community feedback. \r\nWe're seeking a community contribution for the implementation of this f... | 2bf69e5c9a8910d2c1003e128ac4d20ee03fcfce | {
"head_commit": "c9faa0101838d2844f4a73f424fc4c40805b2358",
"head_commit_message": "Autoformat: https://github.com/mlflow/mlflow/actions/runs/2543969877\n\nSigned-off-by: mlflow-automation <mlflow-automation@users.noreply.github.com>",
"patch_to_review": "diff --git a/docs/source/model-registry.rst b/docs/source... | [
{
"diff_hunk": "@@ -45,12 +45,11 @@ def __init__(self, artifact_uri):\n error_code=INVALID_PARAMETER_VALUE,\n )\n super().__init__(artifact_uri)\n- from mlflow.tracking import MlflowClient\n \n self.databricks_profile_uri = (\n get_databricks_profil... | 0f646b7ea692e2bc1bdbc2fb5c893875e5d6f0d6 | diff --git a/docs/source/model-registry.rst b/docs/source/model-registry.rst
index 3262e64ab71f0..d81425624e9c1 100644
--- a/docs/source/model-registry.rst
+++ b/docs/source/model-registry.rst
@@ -135,12 +135,12 @@ For this method, you will need the ``run_id`` as part of the ``runs:URI`` argume
If a registered model w... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "New Feature Additions"
} |
mlflow__mlflow-6486@42afc86 | mlflow/mlflow | Python | 6,486 | Set production variant name | <!-- 🚨 We recommend pull requests be filed from a non-master branch on a repository fork (e.g. <username>:fix-xxx). 🚨 -->
## Related Issues/PRs
<!--
Please reference any related feature requests, issues, or PRs here. For example, `#123`. To automatically close the referenced items when this PR is merged, plea... | 2022-08-16T23:58:52Z | [FR] Currently unable to specify variant names when deploying models to Sagemaker
### Willingness to contribute
Yes. I would be willing to contribute this feature with guidance from the MLflow community.
### Proposal Summary
I would like to add the ability to pass in a specific name for the model variant when ... | To make the model name unique, shall we define this additional argument as a suffix ? so the final model_name will be {generated_model_name}-{suffix}
Adding a suffix would allow for some model name customization. Is the {generated_model_name} you mention in your comment above the full name (endpoint_name-model-uid) t... | [
{
"body": "### Willingness to contribute\r\n\r\nYes. I would be willing to contribute this feature with guidance from the MLflow community.\r\n\r\n### Proposal Summary\r\n\r\nI would like to add the ability to pass in a specific name for the model variant when deploying to Sagmaker as an additional argument to ... | 8098785831a3414bed62ec3239b60a6a500f4dbd | {
"head_commit": "42afc86f3004db9afacedfe6871c194ac228f9de",
"head_commit_message": "added custom variant name\n\nSigned-off-by: Nicole Farley <nicole.m.h.farley@gmail.com>",
"patch_to_review": "diff --git a/mlflow/sagemaker/__init__.py b/mlflow/sagemaker/__init__.py\nindex a28a3bd383f0d..2ade6888198b5 100644\n--... | [
{
"diff_hunk": "@@ -388,6 +394,17 @@ def deploy(\n **assume_role_credentials,\n )\n \n+ if variant_name:\n+ pattern = r\"[a-zA-Z0-9](-*[a-zA-Z0-9]){0,62}\"\n+ if not re.fullmatch(pattern, variant_name):\n+ raise MlflowException(\n+ message=(\n+ \... | 5c5bf8465c94d76b86efafd18f3579274335ac35 | diff --git a/mlflow/sagemaker/__init__.py b/mlflow/sagemaker/__init__.py
index f4fad0b341723..50cca7ff4e66a 100644
--- a/mlflow/sagemaker/__init__.py
+++ b/mlflow/sagemaker/__init__.py
@@ -177,6 +177,7 @@ def deploy(
synchronous=True,
timeout_seconds=1200,
data_capture_config=None,
+ variant_name=None... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
mlflow__mlflow-6041@31e7a30 | mlflow/mlflow | Python | 6,041 | Bugfix/log figure correct file extension | <!-- 🚨 We recommend pull requests be filed from a non-master branch on a repository fork (e.g. <username>:fix-xxx). 🚨 -->
## [BUG] log_figure in plotly format without ".html" extension in artifact_file #6039
<!--
Please reference any related feature requests, issues, or PRs here. For example, `#123`. To automa... | 2022-06-09T13:56:40Z | [BUG] log_figure in plotly format without ".html" extension in artifact_file
### Willingness to contribute
Yes. I can contribute a fix for this bug independently.
### MLflow version
1.25.1
### System information
- **OS Platform and Distribution (e.g., Linux Ubuntu 16.04)**: MacOS
- **Python version**: 3... | @drsantos89 Can we throw an error if the file name doesn't end with `.html`?
@harupy
Yes, that will work and maybe is more clear than just adding `.html`.
If we also want to support the `write_image` method (for png, jpeg, SVG, pdf). We can have an if based on the artifact_file extensions and throw an error is not ... | [
{
"body": "### Willingness to contribute\r\n\r\nYes. I can contribute a fix for this bug independently.\r\n\r\n### MLflow version\r\n\r\n1.25.1\r\n\r\n### System information\r\n\r\n- **OS Platform and Distribution (e.g., Linux Ubuntu 16.04)**: MacOS\r\n- **Python version**: 3.10\r\n\r\n### Describe the problem\... | 17797ec97d9b4be355a756bb99efb7117c1b71a4 | {
"head_commit": "31e7a3028d30137fef9dd60773fc3db8d14a1521",
"head_commit_message": "Apply suggestions from code review\n\nSigned-off-by: Diogo Santos <drsantos989@gmail.com>",
"patch_to_review": "diff --git a/mlflow/tracking/client.py b/mlflow/tracking/client.py\nindex f6f11b8802334..a199ee275f989 100644\n--- a/... | [
{
"diff_hunk": "@@ -45,6 +45,37 @@ def test_log_figure_plotly(subdir):\n assert os.listdir(run_artifact_dir) == [filename]\n \n \n+@pytest.mark.parametrize(\"extension\", ['png', 'jpeg', 'webp', 'svg', 'pdf'])\n+def test_log_figure_plotly_image(extension):\n+ from plotly import graph_objects as go\n+... | 89267179121531e94c68fd3ca424211c47b5945f | diff --git a/mlflow/tracking/client.py b/mlflow/tracking/client.py
index f6f11b8802334..25ee6f3339d6c 100644
--- a/mlflow/tracking/client.py
+++ b/mlflow/tracking/client.py
@@ -1157,7 +1157,15 @@ def _is_plotly_figure(fig):
if "matplotlib" in sys.modules and _is_matplotlib_figure(figure):
... | {
"difficulty": "low",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
matplotlib__matplotlib-14488@7cf2ade | matplotlib/matplotlib | Python | 14,488 | Make sure EventCollection doesn't modify input in-place | Fixes #14487. Not entirely sure if casting any input to an array is correct, but will see if the tests all pass. | 2019-06-07T17:12:13Z | eventplot sorts np.array positions, but not list positions
<!--To help us understand and resolve your issue, please fill out the form to the best of your ability.-->
<!--You can feel free to delete the sections that do not apply.-->
### Bug report
**Bug summary**
When using eventplot, the data is sorted in-p... | [
{
"body": "<!--To help us understand and resolve your issue, please fill out the form to the best of your ability.-->\r\n<!--You can feel free to delete the sections that do not apply.-->\r\n\r\n### Bug report\r\n\r\n**Bug summary**\r\n\r\nWhen using eventplot, the data is sorted in-place if it's passed as a nu... | 177f9df5d2292369f3ce0544be1b3952e61c2f47 | {
"head_commit": "7cf2ade06809bfb0f526f9ae5bc8015ffd3faf7e",
"head_commit_message": "Make sure EventCollection doesn't modify in put inplace",
"patch_to_review": "diff --git a/lib/matplotlib/collections.py b/lib/matplotlib/collections.py\nindex 54d867c394f5..574acec01c58 100644\n--- a/lib/matplotlib/collections.p... | [
{
"diff_hunk": "@@ -1462,7 +1462,7 @@ def __init__(self,\n \n .. plot:: gallery/lines_bars_and_markers/eventcollection_demo.py\n \"\"\"\n-\n+ positions = np.array(positions, copy=True)\n segment = (lineoffset + linelength / 2.,\n lineoffset - linelength / 2.)\n ... | 12f14c01b4439a6cad964e89520010d54bff8591 | diff --git a/lib/matplotlib/collections.py b/lib/matplotlib/collections.py
index 54d867c394f5..e27e445d753e 100644
--- a/lib/matplotlib/collections.py
+++ b/lib/matplotlib/collections.py
@@ -1462,12 +1462,15 @@ def __init__(self,
.. plot:: gallery/lines_bars_and_markers/eventcollection_demo.py
"""
-... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} | |
mlflow__mlflow-5997@a55a115 | mlflow/mlflow | Python | 5,997 | Feature/implement delete in http artifact repository | <!-- 🚨 We recommend pull requests be filed from a non-master branch on a repository fork (e.g. <username>:fix-xxx). 🚨 -->
## Related Issues/PRs
Closes #5996
## What changes are proposed in this pull request?
Implements the `delete_artifacts` method in the `HttpArtifactRepository`.
## How is this patch ... | 2022-05-30T14:53:35Z | [FR] Delete artifact over HTTP is not implemented
### Willingness to contribute
Yes. I can contribute this feature independently.
### Proposal Summary
The `http_artifact_repository` doesn't implement the `delete_artifacts` method, therefore it's not possible to permanently delete artifacts (for instance with the gar... | @idlefella Thanks for the PR, we'll take a look :) | [
{
"body": "### Willingness to contribute\n\nYes. I can contribute this feature independently.\n\n### Proposal Summary\n\nThe `http_artifact_repository` doesn't implement the `delete_artifacts` method, therefore it's not possible to permanently delete artifacts (for instance with the garbace collector `mlflow gc... | 13ca54ebbab0f9b354dec78cfa78d863008c4bec | {
"head_commit": "a55a115254650f6b928c141824436d6710074454",
"head_commit_message": "Fix pylint errors\n\nFixed pylint and formatting errors\n\nSigned-off-by: Marc Liechti <marc.liechti@trivo.ch>",
"patch_to_review": "diff --git a/mlflow/java/client/src/main/java/org/mlflow/api/proto/MlflowArtifacts.java b/mlflow... | [
{
"diff_hunk": "@@ -66,3 +66,11 @@ def _download_file(self, remote_file_path, local_path):\n chunk_size = 1024 * 1024 # 1 MB\n for chunk in resp.iter_content(chunk_size=chunk_size):\n f.write(chunk)\n+\n+ def delete_artifacts(self, artifact_path=\"\"):",
"line": n... | 4f8b0be7ca9785299379a1e2e2618e8b3ea10ba4 | diff --git a/examples/mlflow_artifacts/README.md b/examples/mlflow_artifacts/README.md
index 39105c7f1edf3..83b26431596bb 100644
--- a/examples/mlflow_artifacts/README.md
+++ b/examples/mlflow_artifacts/README.md
@@ -16,6 +16,7 @@ First, launch the tracking server with the artifacts service via `mlflow server`
```sh
... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
mlflow__mlflow-5926@f9c4003 | mlflow/mlflow | Python | 5,926 | Fix two models one code name #5923 | Signed-off-by: Anas BELFADIL <56280198+BFAnas@users.noreply.github.com>
## Related Issues/PRs
<!--
Please reference any related feature requests, issues, or PRs here. For example, `#123`. To automatically close the referenced items when this PR is merged, please use a closing keyword (close, fix, or resolve). Fo... | 2022-05-20T17:58:54Z | Two models one code name
### Willingness to contribute
Yes. I can contribute a fix for this bug independently.
### System information
- **Have I written custom code (as opposed to using a stock example script provided in MLflow)**: custom code
- **OS Platform and Distribution (e.g., Linux Ubuntu 16.04)**: 20... | [
{
"body": "### Willingness to contribute\r\n\r\nYes. I can contribute a fix for this bug independently.\r\n\r\n### System information\r\n\r\n- **Have I written custom code (as opposed to using a stock example script provided in MLflow)**: custom code\r\n- **OS Platform and Distribution (e.g., Linux Ubuntu 16.04... | 51919d52d30b56343482d033d704af934015a19b | {
"head_commit": "f9c4003da30fc4fe8c550d16d63ac903b4bfecb0",
"head_commit_message": "Fix two models one code name #5923\n\nSigned-off-by: Anas BELFADIL <56280198+BFAnas@users.noreply.github.com>",
"patch_to_review": "diff --git a/mlflow/utils/model_utils.py b/mlflow/utils/model_utils.py\nindex 6fd202bc47f30..beb3... | [
{
"diff_hunk": "@@ -118,6 +118,16 @@ def _validate_and_copy_code_paths(code_paths, path, default_subpath=\"code\"):\n \n def _add_code_to_system_path(code_path):\n sys.path = [code_path] + _get_code_dirs(code_path) + sys.path\n+ # delete code modules that are already in sys.modules \n+ # so they will ... | 5821b21f319e0431d51786bb929de459253959a1 | diff --git a/mlflow/utils/model_utils.py b/mlflow/utils/model_utils.py
index 6fd202bc47f30..c10b4ae0158c6 100644
--- a/mlflow/utils/model_utils.py
+++ b/mlflow/utils/model_utils.py
@@ -1,5 +1,6 @@
import os
import sys
+from pathlib import Path
from mlflow.exceptions import MlflowException
from mlflow.models impor... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
mlflow__mlflow-5853@d493b9d | mlflow/mlflow | Python | 5,853 | Fix `validate_docker_installation` to throw when docker daemon is not running | Signed-off-by: harupy <hkawamura0130@gmail.com>
## What changes are proposed in this pull request?
Fixes https://github.com/mlflow/mlflow/issues/5851
## How is this patch tested?
Existing tests
## Does this PR change the documentation?
- [x] No. You can skip the rest of this section.
- [ ] Yes. Make ... | 2022-05-12T03:38:07Z | [BUG] Obscure error when Docker not started
### Willingness to contribute
No. I cannot contribute a bug fix at this time.
### System information
- **Have I written custom code (as opposed to using a stock example script provided in MLflow)**: Nope - pretty standard
- **OS Platform and Distribution (e.g., Linux Ubun... | @stobias123 Can you share the full stack trace?
```
Traceback (most recent call last):
File "/Users/user/.virtualenvs/user/bin/mlflow", line 8, in <module>
sys.exit(cli())
File "/Users/user/.virtualenvs/user/lib/python3.8/site-packages/click/core.py", line 1128, in __call__
return self.main(*args, **kw... | [
{
"body": "### Willingness to contribute\n\nNo. I cannot contribute a bug fix at this time.\n\n### System information\n\n- **Have I written custom code (as opposed to using a stock example script provided in MLflow)**: Nope - pretty standard\r\n- **OS Platform and Distribution (e.g., Linux Ubuntu 16.04)**: OSX\... | 6b67584951c83012344b651a178d908d5e897897 | {
"head_commit": "d493b9d2ea6f0d03670495e5680f73fa9759aa86",
"head_commit_message": "join command\n\nSigned-off-by: harupy <hkawamura0130@gmail.com>",
"patch_to_review": "diff --git a/mlflow/projects/docker.py b/mlflow/projects/docker.py\nindex 0eb2d389a34c8..7d01407684b66 100644\n--- a/mlflow/projects/docker.py\... | [
{
"diff_hunk": "@@ -26,18 +26,23 @@\n \n def validate_docker_installation():\n \"\"\"\n- Verify if Docker is installed on host machine.\n+ Verify if Docker is installed and running on host machine.\n \"\"\"\n- try:\n- docker_path = \"docker\"\n- process._exec_cmd([docker_path, \"-... | daeb60cfac9c58c7e507b6cb7b1a12613b68c837 | diff --git a/mlflow/projects/docker.py b/mlflow/projects/docker.py
index 0eb2d389a34c8..70a58402566b8 100644
--- a/mlflow/projects/docker.py
+++ b/mlflow/projects/docker.py
@@ -5,6 +5,7 @@
import tempfile
import urllib.parse
import urllib.request
+import subprocess
import docker
@@ -26,18 +27,30 @@
def valid... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
mlflow__mlflow-5840@ae360aa | mlflow/mlflow | Python | 5,840 | Ad-hoc connection pool for SFTPArtifactRepository | ## What changes are proposed in this pull request?
Fix #5656.
Add an ad-hoc pool for SFTP Connection objects to prevent deadlocks when fetching directories, which triggers the multi-threaded in the parent class.
## How is this patch tested?
Existing unit tests + local verification of the use case which that... | 2022-05-10T07:16:46Z | [BUG] 1.24.0 regression: Deadlock when downloading directory (async download)
# Regression: Downloading directories using SFTP may cause deadlocks on 1.24.0
### Willingness to contribute
The MLflow Community encourages bug fix contributions. Would you or another member of your organization be willing to contribute ... | @rsundqvist https://github.com/mlflow/mlflow/commit/70fc2dd41162156d11f6070b2e75a478db7ad627 seems suspicious. We're investigating.
@rsundqvist Have you seen https://github.com/paramiko/paramiko/issues/395?
> @rsundqvist Have you seen [paramiko/paramiko#395](https://github.com/paramiko/paramiko/issues/395)?
Yes, saw... | [
{
"body": "# Regression: Downloading directories using SFTP may cause deadlocks on 1.24.0\r\n\r\n### Willingness to contribute\r\nThe MLflow Community encourages bug fix contributions. Would you or another member of your organization be willing to contribute a fix for this bug to the MLflow code base?\r\n\r\n- ... | f3484d8b0a86f816a58fbd622ad8333ac0d83776 | {
"head_commit": "ae360aa7503065fbfe392594c7ca201dc5f66360",
"head_commit_message": "Add test_sftp_artifact_repo::test_download_sklearn; a parallel fetch download test case for SFTPArtifactRepository (#5656)\n\nSigned-off-by: Richard Sundqvist <richard.sundqvist@live.se>",
"patch_to_review": "diff --git a/mlflow/... | [
{
"diff_hunk": "@@ -196,3 +197,14 @@ def test_delete_selective_artifacts(artifact_path):\n assert not posixpath.exists(posixpath.join(remote_dir, file1))\n assert posixpath.isfile(posixpath.join(remote_dir, directory, file2))\n assert posixpath.isdir(remote_dir)\n+\n+\n+def test_log_and_... | 2c6a2fdd3bd4d1e9ee45622305cc097fbc4aff0e | diff --git a/mlflow/store/artifact/artifact_repo.py b/mlflow/store/artifact/artifact_repo.py
index 99a9760c12403..63a0195c3a51a 100644
--- a/mlflow/store/artifact/artifact_repo.py
+++ b/mlflow/store/artifact/artifact_repo.py
@@ -34,9 +34,7 @@ def __init__(self, artifact_uri):
# Limit the number of threads used... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
matplotlib__matplotlib-14107@dbda148 | matplotlib/matplotlib | Python | 14,107 | Feature: draw percentiles in violinplot | ## PR Summary
Resolve #8532
Added an optional argument, a list for percentiles, to violinplot function. User now can specify the percentiles they want to draw for each violin.
I'm opening this as part of coursework from University of Toronto Scarborough's CSCD01 taught by Dr. Anya Tafliovich @atafliovich. (https... | 2019-04-30T20:25:32Z | Feature Request: draw percentiles in violinplot
At the moment violineplot allows to draw the median and the mean into the violin.
Would it be possible to add as an argument e.g. a list for percentiles to be drawn into the violin as well? | Hey @tino-michael
This is definitely possible, it's a matter of finding someone with time to implement, test, and document it. I'd be happy to review a PR if you can take this on.
In the meantime, I'm tempted to simply kick this over to [seaborn](http://seaborn.pydata.org/generated/seaborn.violinplot.html#seabor... | [
{
"body": "At the moment violineplot allows to draw the median and the mean into the violin.\r\nWould it be possible to add as an argument e.g. a list for percentiles to be drawn into the violin as well?",
"number": 8532,
"title": "Feature Request: draw percentiles in violinplot"
}
] | af33de4b22e5c1b16f0241d10387e6a2d1c91f07 | {
"head_commit": "dbda148a19db1c0faf5a6842793075dc9eacecd0",
"head_commit_message": "Run boilerplate",
"patch_to_review": "diff --git a/examples/statistics/violinplot.py b/examples/statistics/violinplot.py\nindex 19d80b494fba..2d3a4217eee1 100644\n--- a/examples/statistics/violinplot.py\n+++ b/examples/statistics... | [
{
"diff_hunk": "@@ -1431,7 +1431,7 @@ def _reshape_2D(X, name):\n raise ValueError(\"{} must have 2 or fewer dimensions\".format(name))\n \n \n-def violin_stats(X, method, points=100):\n+def violin_stats(X, method, percentiles=None, points=100):",
"line": null,
"original_line": 1434,
"origin... | c586932fa13eb54389f3df007b6330930f8d98d3 | diff --git a/examples/statistics/violinplot.py b/examples/statistics/violinplot.py
index 19d80b494fba..5d26cc63966e 100644
--- a/examples/statistics/violinplot.py
+++ b/examples/statistics/violinplot.py
@@ -28,7 +28,7 @@
pos = [1, 2, 4, 5, 7, 8]
data = [np.random.normal(0, std, size=100) for std in pos]
-fig, axes ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
matplotlib__matplotlib-13187@e25f9f7 | matplotlib/matplotlib | Python | 13,187 | FIX: bar mixed units, allow ValueError as well | ## PR Summary
Closes #13186
Follow up to #12903 where we try and do math first for `bar` (x+dx) before units conversion. Pandas throws a `ValueError` for a previously working case. This adds that to the allowable `excepts`...
## PR Checklist
- [ ] Has Pytest style unit tests
- [ ] Code is [Flake 8](http:... | 2019-01-15T00:46:45Z | ax.bar throws when x axis is pandas datetime
<!--To help us understand and resolve your issue, please fill out the form to the best of your ability.-->
<!--You can feel free to delete the sections that do not apply.-->
### Bug report
**Bug summary**
ax.bar throws error when x-axis is datetime, behaviour has c... | That this worked before seems fortuitous, but not consistent with other dates. What units are 10 supposed to be in this example? I’m not clear on what pandas has for a timedelta, but that’s what we would expect for a date using other Datetimes with bar.
Open to the idea that this behaviour still needs to be cha... | [
{
"body": "<!--To help us understand and resolve your issue, please fill out the form to the best of your ability.-->\r\n<!--You can feel free to delete the sections that do not apply.-->\r\n\r\n### Bug report\r\n\r\n**Bug summary**\r\n\r\nax.bar throws error when x-axis is datetime, behaviour has changed betwe... | c9ed6175695eb70bae8d714330155fe429a19455 | {
"head_commit": "e25f9f75622c79d8c5874be266b9bab2d669f5d9",
"head_commit_message": "FIX: bar mixed units, allow ValueError as well\nFIX: make exception in bar for convert(x+dx) more liberal",
"patch_to_review": "diff --git a/lib/matplotlib/axes/_axes.py b/lib/matplotlib/axes/_axes.py\nindex 1830ef5309fe..e4c3b0f... | [
{
"diff_hunk": "@@ -2057,7 +2057,7 @@ def _convert_dx(dx, x0, xconv, convert):\n dx = [convert(x0 + ddx) - x for ddx in dx]\n if delist:\n dx = dx[0]\n- except (TypeError, AttributeError) as e:\n+ except Exception:",
"line": null,
"original_line": 20... | dd2278105aa33f4461858ea63037fa56486b9846 | diff --git a/lib/matplotlib/axes/_axes.py b/lib/matplotlib/axes/_axes.py
index 1830ef5309fe..7c1db6be21c0 100644
--- a/lib/matplotlib/axes/_axes.py
+++ b/lib/matplotlib/axes/_axes.py
@@ -2057,9 +2057,9 @@ def _convert_dx(dx, x0, xconv, convert):
dx = [convert(x0 + ddx) - x for ddx in dx]
if de... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
matplotlib__matplotlib-13738@7359ece | matplotlib/matplotlib | Python | 13,738 | Fix TypeError when plotting stacked bar chart with decimal | ## PR Summary
Hi, I'm opening this as part of coursework from University of Toronto Scarborough's CSCD01 taught by Dr. Anya Tafliovich @atafliovich. (https://www.utsc.utoronto.ca/~atafliovich/cscd01/index.html)
Fixes #10788
### Bug Analysis and Technical Commentary:
When try to plot a bar graph with, a TypeE... | 2019-03-22T17:26:47Z | TypeError when plotting stacked bar chart with decimal
### Bug report
**Bug summary**
When plotting bar graph, TypeError exception is raised if values for bar bases are Decimal types.
**Code for reproduction**
```python
from decimal import Decimal
import matplotlib.pyplot as plt
fig, ax = plt.subplots()
... | First, this can be made even simpler:
```python
from decimal import Decimal
import matplotlib.pyplot as plt
fig, ax = plt.subplots()
x = [Decimal(x) for x in range(10)]
y = [Decimal(x) for x in range(10)]
bar1 = ax.bar(x, y)
```
yields:
```
File "/Users/jklymak/matplotlib/lib/matplotlib/axes/_axes.py", ... | [
{
"body": "### Bug report\r\n\r\n**Bug summary**\r\n\r\nWhen plotting bar graph, TypeError exception is raised if values for bar bases are Decimal types.\r\n\r\n**Code for reproduction**\r\n\r\n```python\r\nfrom decimal import Decimal\r\nimport matplotlib.pyplot as plt\r\nfig, ax = plt.subplots()\r\nx = list(ra... | 34511a636b1d439201e0e6d87eb8c7910573b816 | {
"head_commit": "7359ece1a380ab489fe37dc159cffd3f8d3ef11f",
"head_commit_message": "Add DecimalConverter in units.py\n\nIn axis.py, instead of first checking whether input is number like, direct handle them as a united quantity.\nSince Decimal is a kind of Number, so DecimalConvert doesn't need to provide extra Ax... | [
{
"diff_hunk": "@@ -1555,8 +1551,16 @@ def convert_units(self, x):\n try:\n ret = self.converter.convert(x, self.units, self)\n except Exception as e:\n- raise munits.ConversionError('Failed to convert value(s) to axis '\n- f'units: ... | c56c17525ab53fe994b62f48c25db952664ebb76 | diff --git a/lib/matplotlib/axis.py b/lib/matplotlib/axis.py
index 97d10ae37225..3400d4b67472 100644
--- a/lib/matplotlib/axis.py
+++ b/lib/matplotlib/axis.py
@@ -1565,8 +1565,8 @@ def have_units(self):
return self.converter is not None or self.units is not None
def convert_units(self, x):
- # If... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
matplotlib__matplotlib-12903@1dfdc29 | matplotlib/matplotlib | Python | 12,903 | FIX: (broken)bar(h) math before units | ## PR Summary
OK, this works w/ `bar`, `barh`, and `broken_barh`, and I think it even passes the tests....
~EDIT: now works w/ bar, but see issue below with the pdf (and pgf) determinism tests...~
EDIT: OK, this may not work: i.e. consider `ax.bar(['a', 'b'], ['c', 'd'])`. Width defaults to 0.8, so we can'... | 2018-11-27T23:31:25Z | ax.bar doesn't work correctly when width is a timedelta64 object
The following example
```python
In [1]: x = np.array(range(100), dtype='M8[D]')
In [2]: ax = plt.subplot(1,1,1)
In [3]: y = np.random.random(100)
In [4]: ax.bar(x, y)
Out[4]: <BarContainer object of 100 artists>
```
works fine, but if I ... | Can you provide the full example with the `timedelta64` array that produces that error? I've encountered similar looking problems before, that depend on when we do our unit conversions, and this might actually be fixed in the master branch.
@dstansby - the full example is:
```python
import numpy as np
import matpl... | [
{
"body": "The following example\r\n\r\n```python\r\nIn [1]: x = np.array(range(100), dtype='M8[D]')\r\n\r\nIn [2]: ax = plt.subplot(1,1,1)\r\n\r\nIn [3]: y = np.random.random(100)\r\n\r\nIn [4]: ax.bar(x, y)\r\nOut[4]: <BarContainer object of 100 artists>\r\n```\r\n\r\nworks fine, but if I set width to be the ... | 8466da0a120151a1840b39a3ffc23220b8d24ee7 | {
"head_commit": "1dfdc298f244bfac85afbf3a697577c21eefda78",
"head_commit_message": "FIX: brokenbarh math before units\n\nTST: Add test of broken_barh\nFIX: make bar work with timedeltas\nTST: check bar and barh work with timedelta\nDOC: fix private method docstring\nFIX: revert list comprehension\n\nTST: fix test\... | [
{
"diff_hunk": "@@ -2172,23 +2192,25 @@ def bar(self, x, height, width=0.8, bottom=None, *, align=\"center\",\n else:\n raise ValueError('invalid orientation: %s' % orientation)\n \n+ x, height, width, y, linewidth = np.broadcast_arrays(",
"line": null,
"original_line": 2195,
... | f9c43b7457148b9ae511f64554e692ac7655c540 | diff --git a/lib/matplotlib/axes/_axes.py b/lib/matplotlib/axes/_axes.py
index fd724f55876c..a7164c13cbcb 100644
--- a/lib/matplotlib/axes/_axes.py
+++ b/lib/matplotlib/axes/_axes.py
@@ -2011,6 +2011,58 @@ def step(self, x, y, *args, where='pre', data=None, **kwargs):
kwargs['drawstyle'] = 'steps-' + where
... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
mlflow__mlflow-5395@34fc2ee | mlflow/mlflow | Python | 5,395 | Add model registration argument for autolog | Signed-off-by: Weichen Xu <weichen.xu@databricks.com>
## What changes are proposed in this pull request?
Add model registration argument for autolog
## How is this patch tested?
Unit tests.
## Does this PR change the documentation?
- [ ] No. You can skip the rest of this section.
- [x] Yes. Make sure... | 2022-02-20T12:08:20Z | [FR] Simplify model registration in autolog
## Willingness to contribute
The MLflow Community encourages new feature contributions. Would you or another member of your organization be willing to contribute an implementation of this feature (either as an MLflow Plugin or an enhancement to the MLflow code base)?
- [ ... | This is an approach using existing API: @mmaitre314
```
mlflow.autolog(log_model=False) # disable log model in autolog
with mlflow.start_run():
model = sklearn.XXX().fit(...)
mlflow.sklearn.log_model(model, registered_model_name='a_model_registered_name')
```
If we add `registered_model_name` as autolog ar... | [
{
"body": "## Willingness to contribute\r\nThe MLflow Community encourages new feature contributions. Would you or another member of your organization be willing to contribute an implementation of this feature (either as an MLflow Plugin or an enhancement to the MLflow code base)?\r\n\r\n- [ ] Yes. I can contri... | 2078937040654cf79d7c4c065f994ba537568561 | {
"head_commit": "34fc2eee8b15d354a72d6e7656aa72cbeccc84a6",
"head_commit_message": "init\n\nSigned-off-by: Weichen Xu <weichen.xu@databricks.com>",
"patch_to_review": "diff --git a/mlflow/fastai/__init__.py b/mlflow/fastai/__init__.py\nindex e92239bf1e23e..84a5bdd406c87 100644\n--- a/mlflow/fastai/__init__.py\n+... | [
{
"diff_hunk": "@@ -612,11 +616,15 @@ def infer_model_signature(input_example):\n _logger,\n )\n \n+ registered_model_name = get_autologging_config(\n+ mlflow.paddle.FLAVOR_NAME, \"registered_model_name\", None",
"line": null,
"original_line": 620,
... | c599265481005b987410b7981a830d669fda32a0 | diff --git a/mlflow/fastai/__init__.py b/mlflow/fastai/__init__.py
index e92239bf1e23e..d62bd02d7d50e 100644
--- a/mlflow/fastai/__init__.py
+++ b/mlflow/fastai/__init__.py
@@ -380,6 +380,7 @@ def autolog(
exclusive=False,
disable_for_unsupported_versions=False,
silent=False,
+ registered_model_name=N... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
mlflow__mlflow-5460@ba9c3ad | mlflow/mlflow | Python | 5,460 | #4299 log_batch actually writes in batches | ## What changes are proposed in this pull request?
- Relates to https://github.com/mlflow/mlflow/pull/3024
- Fixes https://github.com/mlflow/mlflow/issues/4299
In this PR, SqlAlchemyStore.log_batch is implemented in a way that it actually writes in batches. Three new public methods are added:
* log_params: l... | 2022-03-06T19:31:17Z | [FR] SqlAlchemyStore.log_batch should really write in batches
## MLflow Roadmap Item
This is an MLflow Roadmap item that has been prioritized by the MLflow maintainers. We're seeking help with the implementation of roadmap items tagged with the `help wanted` label.
For requirements clarifications and implementati... | @simonhessner Currently, in the log_batch we are opening a single session doing multiple writes. A more efficient strategy would be
to write all in a single batch as opposed to iterative over each MLflow entity in a single DB session.
cc: @harupy @WeichenXu123 for commentary.
https://github.com/mlflow/mlflow/issues... | [
{
"body": "## MLflow Roadmap Item\r\n\r\nThis is an MLflow Roadmap item that has been prioritized by the MLflow maintainers. We're seeking help with the implementation of roadmap items tagged with the `help wanted` label.\r\n\r\nFor requirements clarifications and implementation questions, or to request a PR re... | 7c752b6ac08867576abd8e460af5c055277af0d0 | {
"head_commit": "ba9c3ad63b7ca7a8e99a2f00257907b983f4f0f9",
"head_commit_message": "Remove deduplicating params since log_batch controls that param keys are\nunique (#4299)\n\nControl is done by calling _validate_param_keys_unique\n\nSigned-off-by: Eren Sahin <sahineren.09@gmail.com>",
"patch_to_review": "diff -... | [
{
"diff_hunk": "@@ -727,6 +882,76 @@ def set_tag(self, run_id, tag):\n self._check_run_is_active(run)\n session.merge(SqlTag(run_uuid=run_id, key=tag.key, value=tag.value))\n \n+ def _set_tags(self, run_id, tags, attempt=None):\n+ \"\"\"\n+ Set multiple tags on a run\n+\... | e39506c35e51deea363e0c1ea08587420cf52d46 | diff --git a/mlflow/entities/metric.py b/mlflow/entities/metric.py
index e06f9878b9798..355cb3a7cb02e 100644
--- a/mlflow/entities/metric.py
+++ b/mlflow/entities/metric.py
@@ -44,3 +44,12 @@ def to_proto(self):
@classmethod
def from_proto(cls, proto):
return cls(proto.key, proto.value, proto.timesta... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Performance Optimizations"
} |
mlflow__mlflow-4851@b3c0aa3 | mlflow/mlflow | Python | 4,851 | Added start_time and duration to csv export | Signed-off-by: Marijn Valk <marijncv@hotmail.com>
## What changes are proposed in this pull request?
This PR adds the start time and duration of each run to the csv export. closes #4850
## How is this patch tested?
Use the csv export button and see the Start time and duration added. For runs in progress, t... | 2021-09-27T20:39:41Z | [FR] Include start time and run duration in "Download CSV" exported data
## MLflow Roadmap Item
This is an MLflow Roadmap item that has been prioritized by the MLflow maintainers. We're seeking help with the implementation of roadmap items tagged with the `help wanted` label.
For requirements clarifications and i... | cc @harupy @ianshan0915 | [
{
"body": "## MLflow Roadmap Item\r\n\r\nThis is an MLflow Roadmap item that has been prioritized by the MLflow maintainers. We're seeking help with the implementation of roadmap items tagged with the `help wanted` label.\r\n\r\nFor requirements clarifications and implementation questions, or to request a PR re... | c0178c74e86668685f9ab8138ce4b21cdef1a5c2 | {
"head_commit": "b3c0aa39a4999180259f8c8f47d6c8246103751e",
"head_commit_message": "Fix timestamp timezone issue\n\nSigned-off-by: Marijn Valk <marijncv@hotmail.com>",
"patch_to_review": "diff --git a/mlflow/server/js/src/common/utils/Utils.js b/mlflow/server/js/src/common/utils/Utils.js\nindex 168e453c0e9aa..07... | [
{
"diff_hunk": "@@ -191,7 +191,7 @@ class Utils {\n * @param endTime in milliseconds\n */\n static getDuration(startTime, endTime) {\n- return startTime && endTime ? this.formatDuration(endTime - startTime) : null;\n+ return startTime && endTime ? this.formatDuration(endTime - startTime) : '';",
... | 31d7e6096d4aa8b74e6806a72075b3f9491e3b20 | diff --git a/mlflow/server/js/src/experiment-tracking/components/ExperimentView.js b/mlflow/server/js/src/experiment-tracking/components/ExperimentView.js
index 10d0dd35c01e3..bc4d3581deb86 100644
--- a/mlflow/server/js/src/experiment-tracking/components/ExperimentView.js
+++ b/mlflow/server/js/src/experiment-tracking/... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
matplotlib__matplotlib-11921@ec18892 | matplotlib/matplotlib | Python | 11,921 | FIX: allow reshape 2-D to return a bare 1-d list | ## PR Summary
reverts a bit of the logic in https://github.com/matplotlib/matplotlib/pull/8116 Attn @anntzer.
This case allows
```python
import matplotlib.cbook as cbook
x = [datetime(2018,1,1), datetime(2018, 2, 1), datetime(2018,3, 1)]
xnew = cbook._reshape_2D(x, 'x')
```
to return
```
[array... | 2018-08-23T18:24:56Z | Histogram of list of datetimes
### Bug report
**Bug summary**
When creating a histogram of a list of datetimes, the input seems to be interpreted as a sequency of arrays.
**Code for reproduction**
```python
from datetime import datetime
from matplotlib import pyplot as plt
plt.hist([datetime(2018,1,1), da... | Your example is nt quite complete, so maybe I'm doing something wrong, but for
```python
from matplotlib import pyplot as plt
import datetime
n, x = plt.hist([datetime.datetime(2018,1,1), datetime.datetime(2018, 2, 1),
datetime.datetime(2018,3, 1)])
```
on 2.1.2 I get
```
Traceback ... | [
{
"body": "### Bug report\r\n\r\n**Bug summary**\r\nWhen creating a histogram of a list of datetimes, the input seems to be interpreted as a sequency of arrays.\r\n\r\n**Code for reproduction**\r\n\r\n```python\r\nfrom datetime import datetime\r\nfrom matplotlib import pyplot as plt\r\nplt.hist([datetime(2018,1... | 7b5ff33daa955f5be46da6af823c031524164857 | {
"head_commit": "ec18892d56f69fa9fa67ec2ba40f426152f2b2bd",
"head_commit_message": "FIX: allow reshape 2-D to return a bare 1-d list",
"patch_to_review": "diff --git a/lib/matplotlib/cbook/__init__.py b/lib/matplotlib/cbook/__init__.py\nindex 2c5661253873..1d73f8445dc8 100644\n--- a/lib/matplotlib/cbook/__init__... | [
{
"diff_hunk": "@@ -1397,8 +1397,11 @@ def _reshape_2D(X, name):\n # 1D array of scalars: directly return it.\n return [X]\n elif X.ndim in [1, 2]:\n- # 2D array, or 1D array of iterables: flatten them first.\n- return [np.reshape(x, -1) for x in X]\n+ if hasattr(X[0], '... | 9eac832db3b5e281b98d679577fbcff8e93d109f | diff --git a/lib/matplotlib/cbook/__init__.py b/lib/matplotlib/cbook/__init__.py
index 2c5661253873..88b35e171677 100644
--- a/lib/matplotlib/cbook/__init__.py
+++ b/lib/matplotlib/cbook/__init__.py
@@ -1393,7 +1393,7 @@ def _reshape_2D(X, name):
"""
# Iterate over columns for ndarrays, over rows otherwise.
... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
matplotlib__matplotlib-11754@27e9a4c | matplotlib/matplotlib | Python | 11,754 | FIX: update spine positions before get extents | ## PR Summary
Closes #11737 (supercedes #11739, #11742)
If you zoomed on an axes, `get_tightbbox` would return a huge bounding box because spine objects didn't have their x/ylims properly set from the axis info yet. This PR sets those limits when `get_window_extent` is called making the bounding box accurate..... | 2018-07-23T17:48:39Z | Bug in tight_layout
I just found a critical bug in `tight_layout ` in master (unless something is wrong with my installation...).
```
fig, ax=plt.subplots()
fig.set_tight_layout(True)
plt.show()
```
The axes get into a black hole in the middle of the figure if I try to zoom.
master
python 3.5, 3.6
window... | It seems that the new tests for correct `subplotparams` in `tight_layout`for some reason don't work in the use case above. I am looking into it.
Some more information. The left, right etc values in the `tight_layout` module became incorrect. Those values get send to `Subplotparams.update` where they are silently change... | [
{
"body": " I just found a critical bug in `tight_layout ` in master (unless something is wrong with my installation...).\r\n```\r\nfig, ax=plt.subplots()\r\nfig.set_tight_layout(True)\r\nplt.show()\r\n```\r\nThe axes get into a black hole in the middle of the figure if I try to zoom. \r\n \r\nmaster\r\npython ... | cf38546d06e53e640215fdba1105ba8e5fd5d3b8 | {
"head_commit": "27e9a4cb8d555eaaaaa636b0584064554f9912aa",
"head_commit_message": "FIX: update spine positions before gett extents",
"patch_to_review": "diff --git a/lib/matplotlib/spines.py b/lib/matplotlib/spines.py\nindex 5747c40bba69..ee1f6f29af61 100644\n--- a/lib/matplotlib/spines.py\n+++ b/lib/matplotlib... | [
{
"diff_hunk": "@@ -146,6 +146,12 @@ def get_patch_transform(self):\n else:\n return super().get_patch_transform()\n \n+ def get_window_extent(self, renderer=None):\n+ # make sure the location is updated so that transforms etc are\n+ # correct:\n+ self._adjust_locatio... | 5545050ff6ceb1b59d7e46401a9fc56ddf044704 | diff --git a/lib/matplotlib/_constrained_layout.py b/lib/matplotlib/_constrained_layout.py
index f949fc1beadf..7f740b9980a5 100644
--- a/lib/matplotlib/_constrained_layout.py
+++ b/lib/matplotlib/_constrained_layout.py
@@ -145,14 +145,6 @@ def do_constrained_layout(fig, renderer, h_pad, w_pad,
'''
- try:
- ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
matplotlib__matplotlib-11553@90b45e7 | matplotlib/matplotlib | Python | 11,553 | Improved Code for Segments Intersect | ## PR Summary
Supposedly fixes #11527 (Inconsistent path intersection).
`Path.intersects_path` didn't work properly on
collinear paths intersection because underlying
[`segments_intersect`](https://github.com/matplotlib/matplotlib/blob/master/src/_path.h#L815)
handled parallel segments as non-intersecting (ig... | 2018-07-02T17:09:41Z | Inconsistent path intersection
### Bug report
**Bug summary**
If I two paths has a common segment, the result of `a.intersects_path(b)` is inconsistent. I think it should return `True` every time in this case.
**Code for reproduction**
```python
from matplotlib.path import Path
a = Path([(0,1),(0,3)])
b =... | That is interesting.
I am not sure what the convention for 'intersection' with co-linear lines is. If by "intersect" you mean "some points fall on one side and some points fall on the other" then there is a case that everything but 'g' should not be considered intersecting.
What does shapely do in these cases? W... | [
{
"body": "### Bug report\r\n\r\n**Bug summary**\r\nIf I two paths has a common segment, the result of `a.intersects_path(b)` is inconsistent. I think it should return `True` every time in this case.\r\n\r\n**Code for reproduction**\r\n```python\r\nfrom matplotlib.path import Path\r\n\r\na = Path([(0,1),(0,3)])... | d12b8f47d53221bc1a643aa2388718764852f1be | {
"head_commit": "90b45e7d9ec38d9a40c01ed52b66e59d460cc98d",
"head_commit_message": "Merge branch 'segments-intersect' of https://github.com/TarasKuzyo/matplotlib into segments-intersect",
"patch_to_review": "diff --git a/lib/matplotlib/tests/test_path.py b/lib/matplotlib/tests/test_path.py\nindex c99701097d95..f... | [
{
"diff_hunk": "@@ -273,6 +273,82 @@ def test_path_deepcopy():\n copy.deepcopy(path2)\n \n \n+def test_path_intersect_path():\n+ # test for the range of intersection angles\n+ for phi in np.linspace(0, 2*np.pi, 180):",
"line": null,
"original_line": 278,
"original_start_line": null,
"p... | 293e5fa452e46c9a9ee7b1a62cedd8478e7a0052 | diff --git a/lib/matplotlib/tests/test_path.py b/lib/matplotlib/tests/test_path.py
index c99701097d95..452413f842ec 100644
--- a/lib/matplotlib/tests/test_path.py
+++ b/lib/matplotlib/tests/test_path.py
@@ -273,6 +273,83 @@ def test_path_deepcopy():
copy.deepcopy(path2)
+def test_path_intersect_path():
+ # ... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
mlflow__mlflow-3582@8b7bc42 | mlflow/mlflow | Python | 3,582 | Sklearn autologging: Fix behavior when a child and its parent are both patched | ## What changes are proposed in this pull request?
Fixes https://github.com/mlflow/mlflow/issues/3574 by addressing the following two issues:
1. In gorilla 0.3.0, applying a patch that stores a hit to a parent class (e.g., `CountVectorizer`) forces `get_original_attribute` of its children to refer to the parent c... | 2020-10-23T06:38:41Z | sklearn autolog and TfidfVectorizer do not work together
When running this minimal example with mlflow autolog:
```
from sklearn.feature_extraction.text import TfidfVectorizer
import mlflow
mlflow.sklearn.autolog()
X_train = ['blah blah blah blah', 'ho ho ho ho']
tfidf_count = TfidfVectorizer()
tfidf_count... | @sheldonkhall Thanks for reporting this. I was able to reproduce the issue.
@harupy Thanks for jumping on it!
Wrote a script to repro & investigate the issue:
```python
import functools
import gorilla
from mlflow.utils.autologging_utils import wrap_patch
# context
# 1. `TfidfVectorizer` inherits from `CountVe... | [
{
"body": "When running this minimal example with mlflow autolog:\r\n\r\n```\r\nfrom sklearn.feature_extraction.text import TfidfVectorizer\r\nimport mlflow\r\n\r\nmlflow.sklearn.autolog()\r\n\r\nX_train = ['blah blah blah blah', 'ho ho ho ho']\r\ntfidf_count = TfidfVectorizer()\r\ntfidf_count.fit(X_train)\r\nt... | 09f1bf1bf6d3ef0a78ac3dd87abbd8d5eaaacc7e | {
"head_commit": "8b7bc42f62fdb59b414815698ae1838580253cdd",
"head_commit_message": "Black format\n\nSigned-off-by: Corey Zumar <corey.zumar@databricks.com>",
"patch_to_review": "diff --git a/mlflow/_spark_autologging.py b/mlflow/_spark_autologging.py\nindex 31a2a091c4172..1ddba8643695a 100644\n--- a/mlflow/_spar... | [
{
"diff_hunk": "@@ -1033,3 +1034,47 @@ def test_autolog_does_not_capture_runs_for_preprocessing_or_imputation_estimator\n assert len(metrics) == 0\n assert len(tags) == 0\n assert len(artifacts) == 0\n+\n+\n+@pytest.mark.large\n+def test_autolog_produces_expected_results_for_estimator_when_parent_al... | daa732b926250deaa72a1c86ee2b6f09b0370e00 | diff --git a/mlflow/_spark_autologging.py b/mlflow/_spark_autologging.py
index 31a2a091c4172..1ddba8643695a 100644
--- a/mlflow/_spark_autologging.py
+++ b/mlflow/_spark_autologging.py
@@ -3,7 +3,6 @@
import sys
import threading
import uuid
-import gorilla
from py4j.java_gateway import CallbackServerParameters
... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
mlflow__mlflow-3210@ca1ed57 | mlflow/mlflow | Python | 3,210 | Fix error due to names with absolute path returned by ftp.nlst | In vsftpd, `ftp.nlst` returns a list of file names with absolute path.
And, it will cause an error. To solve it, the path need to be removed
with basename.
Fixes https://github.com/mlflow/mlflow/issues/3197
## What changes are proposed in this pull request?
(Please fill in changes proposed in this fix)
##... | 2020-08-01T09:47:11Z | [BUG] Failed to load model from the FTP store
### Willingness to contribute
The MLflow Community encourages bug fix contributions. Would you or another member of your organization be willing to contribute a fix for this bug to the MLflow code base?
- [ ] Yes. I can contribute a fix for this bug independently.
- [x... | @shaneing Thanks for filing this. Does the model file exist in your FTP file store?
> @shaneing Thanks for filing this. Does the model file exist in your FTP file store?
Sorry, I have updated the issue. Please review it again.
@shaneing
I wasn't able to reproduce the issue. Here's my code to log and load a pytor... | [
{
"body": "### Willingness to contribute\r\nThe MLflow Community encourages bug fix contributions. Would you or another member of your organization be willing to contribute a fix for this bug to the MLflow code base?\r\n\r\n- [ ] Yes. I can contribute a fix for this bug independently.\r\n- [x] Yes. I would be w... | ea41b4d59d25ae7c1a10708805cf7213f671fd5b | {
"head_commit": "ca1ed5702da42bc822e96728846f70993cca4935",
"head_commit_message": "Clean up\n\nSigned-off-by: shaneing <z.shane.ing@gmail.com>",
"patch_to_review": "diff --git a/mlflow/store/artifact/ftp_artifact_repo.py b/mlflow/store/artifact/ftp_artifact_repo.py\nindex 7d96af5d7fe49..28cf09be13b1f 100644\n--... | [
{
"diff_hunk": "@@ -112,6 +112,8 @@ def list_artifacts(self, path=None):\n return []\n artifact_files = ftp.nlst(list_dir)\n artifact_files = list(filter(lambda x: x != \".\" and x != \"..\", artifact_files))\n+ # Make sure artifact_files is a list of file name... | 810900a9a48d720324b0cbb6720b76bf733d7577 | diff --git a/mlflow/store/artifact/ftp_artifact_repo.py b/mlflow/store/artifact/ftp_artifact_repo.py
index 7d96af5d7fe49..e6b7d008d83c0 100644
--- a/mlflow/store/artifact/ftp_artifact_repo.py
+++ b/mlflow/store/artifact/ftp_artifact_repo.py
@@ -112,6 +112,9 @@ def list_artifacts(self, path=None):
retur... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
mlflow__mlflow-3347@055ea59 | mlflow/mlflow | Python | 3,347 | Fix for parameter parsing when parameter contains '=' | ## What changes are proposed in this pull request?
Fixes #3346 (a regression introduced by #3061) where project parameters whose values contain the `=` character were not being parsed properly.
## How is this patch tested?
Added unit test coverage to `test_projects_cli`
## Release Notes
Fixed a regressio... | 2020-08-27T20:18:34Z | [BUG] mlflow run won't accept parameters' value containing "="
### Willingness to contribute
The MLflow Community encourages bug fix contributions. Would you or another member of your organization be willing to contribute a fix for this bug to the MLflow code base?
- [x] Yes. I can contribute a fix for this bug ind... | @alpancs Thanks for filing this issue.
With MLproject file:
```
entry_points:
main:
parameters:
equation: {type: string, default: "y=mx+c"}
command: python equation-parser.py --equation {equation}
```
and the equation_parser.py:
```
import sys
if __name__ == "__main__":
equation = ... | [
{
"body": "### Willingness to contribute\r\nThe MLflow Community encourages bug fix contributions. Would you or another member of your organization be willing to contribute a fix for this bug to the MLflow code base?\r\n\r\n- [x] Yes. I can contribute a fix for this bug independently.\r\n- [ ] Yes. I would be w... | 27b9fe82ca38772b53949ddc2619babfe4281065 | {
"head_commit": "055ea59c33c409c939a3c058345442f658a3b3f9",
"head_commit_message": "Black formatting\n\nSigned-off-by: Corey Zumar <corey.zumar@databricks.com>",
"patch_to_review": "diff --git a/mlflow/cli.py b/mlflow/cli.py\nindex 1e85c638addfc..2e72eb89a90a7 100644\n--- a/mlflow/cli.py\n+++ b/mlflow/cli.py\n@@... | [
{
"diff_hunk": "@@ -194,14 +194,14 @@ def run(\n def _user_args_to_dict(arguments, argument_type=\"P\"):\n user_dict = {}\n for arg in arguments:\n- split = arg.split(\"=\")\n+ split_index = arg.find(\"=\")\n # Docker arguments such as `t` don't require a value -> set to True if sp... | a96f91f61897e54068c1cd2b22cee7cbf7de4006 | diff --git a/mlflow/cli.py b/mlflow/cli.py
index 1e85c638addfc..3b72f4fdfff4d 100644
--- a/mlflow/cli.py
+++ b/mlflow/cli.py
@@ -194,7 +194,7 @@ def run(
def _user_args_to_dict(arguments, argument_type="P"):
user_dict = {}
for arg in arguments:
- split = arg.split("=")
+ split = arg.split("=", ... | {
"difficulty": "low",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
mlflow__mlflow-3023@1a9fbf0 | mlflow/mlflow | Python | 3,023 | [pagination] followups to clean up search registered models | ## What changes are proposed in this pull request?
This PR cleans up some issues with testing and edge cases with search registered models:
1. It adds tests to verify that lowercase and uppercase ordering keys work.
2. It changes search `order_by` parsing in `search_runs` and `search_registered_models` to throw ... | 2020-06-29T23:06:34Z | [BUG] `mlflow.search_runs` does not raise error or warning when passed invalid `order_by` expression
`mlflow.search_runs` does not raise error or warning when passed invalid `order_by` expression. I think this behavior is dangerous. Let's consider a scenario where a user wants to select the best model from a bunch of r... | I think this is because we attempt to parse ASC or DESC from the oder by clause, but we default to `is_ascending=True` if we can't parse something valid from it
I can take this one | [
{
"body": "`mlflow.search_runs` does not raise error or warning when passed invalid `order_by` expression. I think this behavior is dangerous. Let's consider a scenario where a user wants to select the best model from a bunch of runs and writes the code below:\r\n\r\n```python\r\norder_by = [\"metrics.accuracy ... | 407ae3f9dce841908d8ace0a1225f11755815163 | {
"head_commit": "1a9fbf07a64716c1d6bf25ab6e641a3641ca10d5",
"head_commit_message": "DRY",
"patch_to_review": "diff --git a/mlflow/utils/search_utils.py b/mlflow/utils/search_utils.py\nindex 2b8712a034b37..66aa6bcbba521 100644\n--- a/mlflow/utils/search_utils.py\n+++ b/mlflow/utils/search_utils.py\n@@ -19,6 +19,9... | [
{
"diff_hunk": "@@ -363,11 +366,20 @@ def _validate_order_by_and_generate_token(cls, order_by):\n def _parse_order_by_string(cls, order_by):\n token_value = cls._validate_order_by_and_generate_token(order_by)\n is_ascending = True\n- if token_value.lower().endswith(\" desc\"):\n- ... | f02ab97e3ba7ab9cba8459ceef70cde8b41d3cd1 | diff --git a/mlflow/utils/search_utils.py b/mlflow/utils/search_utils.py
index 2b8712a034b37..dc5ab118e181c 100644
--- a/mlflow/utils/search_utils.py
+++ b/mlflow/utils/search_utils.py
@@ -19,6 +19,9 @@
class SearchUtils(object):
LIKE_OPERATOR = "LIKE"
ILIKE_OPERATOR = "ILIKE"
+ ASC_OPERATOR = "asc"
+ ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
mlflow__mlflow-1891@c7c0d7b | mlflow/mlflow | Python | 1,891 | Fix handling of empty directories in fs based artifact repositories. | Fixes #1881.
## What changes are proposed in this pull request?
Distinguish between empty directories and files when downloading artifacts from filesystem based artifact repositories.
## How is this patch tested?
Enhanced unit test for local artifact repository.
## Release Notes
Distinguish between em... | 2019-09-30T23:38:06Z | [BUG] Spark UDF cannot load models with empty directories
### System information
- **Have I written custom code (as opposed to using a stock example script provided in MLflow)**: No
- **OS Platform and Distribution (e.g., Linux Ubuntu 16.04)**: Linux
- **MLflow installed from (source or binary)**: Binary
- **MLflo... | Hey @dwyatte, thanks for posting! I have been able to reproduce this. The issue occurs when downloading artifacts which include empty directory.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. | [
{
"body": "### System information\r\n- **Have I written custom code (as opposed to using a stock example script provided in MLflow)**: No\r\n- **OS Platform and Distribution (e.g., Linux Ubuntu 16.04)**: Linux\r\n- **MLflow installed from (source or binary)**: Binary\r\n- **MLflow version (run ``mlflow --versi... | d70d1451b3ca5ed46f6b519fb3daf8d732600d9d | {
"head_commit": "c7c0d7b2fa9f2effabafe8f89b9021635c4bd949",
"head_commit_message": "fix",
"patch_to_review": "diff --git a/mlflow/store/artifact/artifact_repo.py b/mlflow/store/artifact/artifact_repo.py\nindex b92ca185e232a..d72e3c1e7a4a1 100644\n--- a/mlflow/store/artifact/artifact_repo.py\n+++ b/mlflow/store/a... | [
{
"diff_hunk": "@@ -17,7 +18,10 @@ def list_artifacts(self, path):\n raise NotImplementedError()\n \n def _download_file(self, remote_file_path, local_path):\n- print(\"download_file called with \", remote_file_path)\n+ print(\"download_file called with '%s'\" % remote_file_path)\n+ ... | fb45e1ef934e0476143ce20e2641fe0eb6d2c4fd | diff --git a/mlflow/store/artifact/artifact_repo.py b/mlflow/store/artifact/artifact_repo.py
index b92ca185e232a..dd7978f3dfcf8 100644
--- a/mlflow/store/artifact/artifact_repo.py
+++ b/mlflow/store/artifact/artifact_repo.py
@@ -57,6 +57,10 @@ def list_artifacts(self, path):
"""
pass
+ def _is_di... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
mlflow__mlflow-1658@3f53b0b | mlflow/mlflow | Python | 1,658 | Fix Spark bug loading Spark UDFs on Databricks | ## What changes are proposed in this pull request?
Fixes #1657
## How is this patch tested?
Existing unit tests & manual testing.
## Release Notes
### Is this a user-facing change?
- [ ] No. You can skip the rest of this section.
- [x] Yes. Give a description of this change to be included in t... | 2019-07-24T02:23:46Z | [MLflow 1.1] Loading models with mlflow.pyfunc.spark_udf broken on Databricks clusters
### System information
- **Have I written custom code (as opposed to using a stock example script provided in MLflow)**: No
- **OS Platform and Distribution (e.g., Linux Ubuntu 16.04)**: Ubuntu 16.04
- **MLflow installed from (sou... | I noticed this bug with Keras/TensorFlow on DBR ML 5.4. However mlflow.pyfunc.spark_udf() with sklearn works fine. | [
{
"body": "### System information\r\n- **Have I written custom code (as opposed to using a stock example script provided in MLflow)**: No\r\n- **OS Platform and Distribution (e.g., Linux Ubuntu 16.04)**: Ubuntu 16.04\r\n- **MLflow installed from (source or binary)**: Binary\r\n- **MLflow version (run ``mlflow ... | d70c9fae89087f45c9dccc5a2a7ad2b3bb75729f | {
"head_commit": "3f53b0bf8d3ce8cef10abc641da07909c69d9c5a",
"head_commit_message": "WIP, fix test",
"patch_to_review": "diff --git a/mlflow/pyfunc/__init__.py b/mlflow/pyfunc/__init__.py\nindex 58ba8d8bf9c88..52e4aeb124fab 100644\n--- a/mlflow/pyfunc/__init__.py\n+++ b/mlflow/pyfunc/__init__.py\n@@ -414,8 +414,1... | [
{
"diff_hunk": "@@ -72,7 +72,7 @@ def list_artifacts(self, path=None):\n path = os.path.normpath(path)\n list_dir = os.path.join(self.artifact_dir, path) if path else self.artifact_dir\n if os.path.isdir(list_dir):\n- artifact_files = list_all(list_dir, full_path=True)\n+ ... | a25d5c376319934092a9874829c26dffde0e977c | diff --git a/mlflow/pyfunc/__init__.py b/mlflow/pyfunc/__init__.py
index 58ba8d8bf9c88..52e4aeb124fab 100644
--- a/mlflow/pyfunc/__init__.py
+++ b/mlflow/pyfunc/__init__.py
@@ -414,8 +414,10 @@ def spark_udf(spark, model_uri, result_type="double"):
"of the following types types: {}".format(str(elem... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
mlflow__mlflow-875@0d70d15 | mlflow/mlflow | Python | 875 | Fix #849: updated mlflow api set used in the tensorflow example | Fix #849: train_predict.py present in mlflow/examples/tensorflow is corresponding to the old branch (0.7) and the code in master is not working with it.
Run log from test after api update: [tensorflow_example_run_log.txt](https://github.com/mlflow/mlflow/files/2834738/tensorflow_example_run_log.txt)
| 2019-02-06T03:08:32Z | Tensorflow example is corresponding to old version
### System information
- **Have I written custom code (as opposed to using a stock example script provided in MLflow)**: No
- **OS Platform and Distribution (e.g., Linux Ubuntu 16.04)**: Linux Ubuntu 16.04
- **MLflow installed from (source or binary)**: binary
- **... | [
{
"body": "### System information\r\n- **Have I written custom code (as opposed to using a stock example script provided in MLflow)**: No\r\n- **OS Platform and Distribution (e.g., Linux Ubuntu 16.04)**: Linux Ubuntu 16.04\r\n- **MLflow installed from (source or binary)**: binary\r\n- **MLflow version (run ``ml... | c910079bc7c8cdd1abe2a19eb1765d5e498f2039 | {
"head_commit": "0d70d158b977fafc6428e0a7edd461915570b001",
"head_commit_message": "updated mlflow api set used",
"patch_to_review": "diff --git a/examples/tensorflow/train_predict.py b/examples/tensorflow/train_predict.py\nindex 34c0224932529..1bfa06feb8a2e 100644\n--- a/examples/tensorflow/train_predict.py\n++... | [
{
"diff_hunk": "@@ -36,9 +39,12 @@ def main(argv):\n try:\n saved_estimator_path = regressor.export_savedmodel(temp, receiver_fn).decode(\"utf-8\")\n # Logging the saved model\n- tensorflow.log_saved_model(saved_model_dir=saved_estimator_path, signature_def_key=\"predi... | 5d181674ace4b23504de5a847da18e48bb069b3a | diff --git a/examples/tensorflow/train_predict.py b/examples/tensorflow/train_predict.py
index 34c0224932529..752a93868af50 100644
--- a/examples/tensorflow/train_predict.py
+++ b/examples/tensorflow/train_predict.py
@@ -3,12 +3,14 @@
from __future__ import print_function
import mlflow
-from mlflow import tensorflo... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
mlflow__mlflow-2859@398771c | mlflow/mlflow | Python | 2,859 | [Issue #2790] view PDFs in artifact viewer | ## What changes are proposed in this pull request?
In response to Issue #2790, this PR introduces the ability to view PDFs in the artifact viewer.
Here's an example of what it looks like:
To accompli... | 2020-05-19T18:56:19Z | [FR] Add PDF files to Preview
## Willingness to contribute
The MLflow Community encourages new feature contributions. Would you or another member of your organization be willing to contribute an implementation of this feature (either as an MLflow Plugin or an enhancement to the MLflow code base)?
- [ ] Yes. I can c... | Thank you for filling this feature request. We hope that a community member can take this task.
Short of it, you can save the artifact, download it, and view it in a pdf reader.
@pogil a PR for this is up here: #2859 | [
{
"body": "## Willingness to contribute\r\nThe MLflow Community encourages new feature contributions. Would you or another member of your organization be willing to contribute an implementation of this feature (either as an MLflow Plugin or an enhancement to the MLflow code base)?\r\n\r\n- [ ] Yes. I can contri... | 7969f9140874e0644770f255d106f7a729150aad | {
"head_commit": "398771cb4b6bca58154f0ddb914bf9fbe5fcbc56",
"head_commit_message": "Drop extra function bindings\n\nCo-authored-by: Harutaka Kawamura <hkawamura0130@gmail.com>",
"patch_to_review": "diff --git a/mlflow/server/js/package-lock.json b/mlflow/server/js/package-lock.json\nindex 524533232a8b5..7b349ba0... | [
{
"diff_hunk": "@@ -0,0 +1,110 @@\n+import React, { Component } from 'react';\n+import PropTypes from 'prop-types';\n+import './ShowArtifactImageView.css';\n+import { getSrc } from './ShowArtifactPage';\n+import { Document, Page, pdfjs } from 'react-pdf';\n+import { Pagination, Spin } from 'antd';\n+import { ge... | 14fd0a86c2c5b004ea239c9e544d132bd330700f | diff --git a/mlflow/server/js/package-lock.json b/mlflow/server/js/package-lock.json
index 524533232a8b5..7b349ba01a7e3 100644
--- a/mlflow/server/js/package-lock.json
+++ b/mlflow/server/js/package-lock.json
@@ -12523,6 +12523,11 @@
"resolved": "https://registry.npmjs.org/lodash.mergewith/-/lodash.mergewith-4.6... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
matplotlib__matplotlib-11071@12d30e5 | matplotlib/matplotlib | Python | 11,071 | Add note about hist2d resetting axis limits | Maybe fixes #3815? I've also added a couple of other bits of markup to make the docstring nicer in general. | 2018-04-17T11:40:03Z | hist2d and x/y limits
The hist2d doesn't behave as expected (at least as I expected) when setting x and y limits.
``` python
x = randn(10000);
y = randn(10000);
figure()
xlim(-2, 2);
hist(x, bins=100); # obeys the xlim
figure();
xlim(-2, 2);
ylim(-2, 2);
hist2d(x, y, bins=100); # sets it's own xlim that seems to d... | hist2D should probably respect the same auto-scaling rules as (some of) the other plotting methods. Bit worried we won't be able to do this without breaking API..
The source of the problem is hard-coded calls to `ax.set_{x,y}lim` at lines 5994 in `axes/_axes.py`
At a minimum this behavior should be documented, even ... | [
{
"body": "The hist2d doesn't behave as expected (at least as I expected) when setting x and y limits.\n\n``` python\n\nx = randn(10000);\ny = randn(10000);\n\n\nfigure()\nxlim(-2, 2);\nhist(x, bins=100); # obeys the xlim\n\nfigure();\nxlim(-2, 2);\nylim(-2, 2);\nhist2d(x, y, bins=100); # sets it's own xlim tha... | db3be2372db24e467011c0bc4eef3a49415ae487 | {
"head_commit": "12d30e52e31467cfeb3cb88afc40034543b6cc9f",
"head_commit_message": "Add note about hist2d resetting axis limits",
"patch_to_review": "diff --git a/lib/matplotlib/axes/_axes.py b/lib/matplotlib/axes/_axes.py\nindex 1e1b4347bb22..3f41f4ea8f3a 100644\n--- a/lib/matplotlib/axes/_axes.py\n+++ b/lib/ma... | [
{
"diff_hunk": "@@ -6510,31 +6510,33 @@ def hist2d(self, x, y, bins=10, range=None, normed=False, weights=None,\n Other Parameters\n ----------------\n cmap : Colormap or str, optional\n- A :class:`matplotlib.colors.Colormap` instance. If not set, use rc\n+ A :clas... | 4e1035e16abcbae312d9007f1414d6f379e1dc3c | diff --git a/lib/matplotlib/axes/_axes.py b/lib/matplotlib/axes/_axes.py
index 1e1b4347bb22..e502d3b8ec6a 100644
--- a/lib/matplotlib/axes/_axes.py
+++ b/lib/matplotlib/axes/_axes.py
@@ -6462,21 +6462,21 @@ def hist2d(self, x, y, bins=10, range=None, normed=False, weights=None,
- If int, the number of ... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "Bug Fixes"
} |
mlflow__mlflow-1307@6605d21 | mlflow/mlflow | Python | 1,307 | Don't copy local artifacts in download_artifacts | ## What changes are proposed in this pull request?
Trying to resolve https://github.com/mlflow/mlflow/issues/1283.
In this PR, we will no longer copy artifacts to a tmp directory when `LocalArtifactRepository.download_artifact` is invoked with `dst_path=None`.
In order to actually resolve the linked issue, we... | 2019-05-22T00:09:11Z | Avoid extensive copying of model files & artifacts in pyfunc
### Issue
I was trying out mlflow to serve a ML model with large model files (totalling about 2 GB) on sagemaker. I used `mlflow.pyfunc` to load the model data etc. specified via the artifacts-dictionary.
However, when I built the Docker container and ra... | +1 custom gunicorn timeout and
+1 to not duplicating large model artifacts. Currently have a model with a 4Gb artifact... it used to be a 50Gb kdtree 😳.
Thanks for reporting this. _download_artifact_from_uri should actually not do anything special for local paths, so there seems to be something wrong there (maybe it... | [
{
"body": "### Issue\r\nI was trying out mlflow to serve a ML model with large model files (totalling about 2 GB) on sagemaker. I used `mlflow.pyfunc` to load the model data etc. specified via the artifacts-dictionary. \r\n\r\nHowever, when I built the Docker container and ran it locally, gunicorn always timed ... | aba3ab278ecf2d06c0d25703609db7410b63e00b | {
"head_commit": "6605d21d7701949a0b058460a19c6640a340ddeb",
"head_commit_message": "fix lint",
"patch_to_review": "diff --git a/mlflow/pyfunc/backend.py b/mlflow/pyfunc/backend.py\nindex c81ef7c32c790..e933183943d98 100644\n--- a/mlflow/pyfunc/backend.py\n+++ b/mlflow/pyfunc/backend.py\n@@ -27,46 +27,44 @@ def p... | [
{
"diff_hunk": "@@ -39,6 +39,27 @@ def log_artifacts(self, local_dir, artifact_path=None):\n mkdir(artifact_dir)\n dir_util.copy_tree(src=local_dir, dst=artifact_dir)\n \n+ def download_artifacts(self, artifact_path, dst_path=None):\n+ \"\"\"\n+ Download an artifact file or ... | 57325a989bbaaa8dbf590cedf415c3c0f964487b | diff --git a/mlflow/pyfunc/__init__.py b/mlflow/pyfunc/__init__.py
index d407bdfe76f6b..cc2a598d4316f 100644
--- a/mlflow/pyfunc/__init__.py
+++ b/mlflow/pyfunc/__init__.py
@@ -194,14 +194,12 @@
import os
import pandas
import shutil
-import sys
from copy import deepcopy
import mlflow
import mlflow.pyfunc.model
... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Performance Optimizations"
} |
mlflow__mlflow-548@25b635c | mlflow/mlflow | Python | 548 | R Tracking/Fluent API | This change splits the tracking feature into a "fluent" component and a "client" component to be consistent with other languages and fix #432.
The explicit Tracking Service/client API, which is a thin layer on top of the internal REST wrappers, is exposed to the user in `tracking-client.R`. Similar to their Python c... | 2018-09-25T08:27:50Z | Consider mapping Service API 1:1 in R
The tracking service API is currently implemented through the main API by providing an additional `run_uuid` parameter; this issue is tracking an open discussion on whether the API should be locked under a `mlflow_service_api()` block since it's meant to be used by package authors,... | We are planning to map 1:1 the R API to Python/Java Service APIs using functions like:
- `mlflow_service_log_param(service, ...)`
- `mlflow_service_log_metric(service, ...)`
under a `tracking-service.R` or alike file name that can be easily updated across many programming languages, including R. | [
{
"body": "The tracking service API is currently implemented through the main API by providing an additional `run_uuid` parameter; this issue is tracking an open discussion on whether the API should be locked under a `mlflow_service_api()` block since it's meant to be used by package authors, for the most part.... | d0c48f9221e776e3cd0b799d92ed75756a48c9bd | {
"head_commit": "25b635cdbc756cb6bb622fb2132b38e7bbbcedf8",
"head_commit_message": "add mlflow_get_experiment_by_name() and mlflow_set_experiment()",
"patch_to_review": "diff --git a/mlflow/R/mlflow/.Rbuildignore b/mlflow/R/mlflow/.Rbuildignore\nindex d393c4592597d..cbd842cf8aa15 100644\n--- a/mlflow/R/mlflow/.R... | [
{
"diff_hunk": "@@ -0,0 +1,371 @@\n+new_mlflow_client <- function(tracking_uri, server_url = NULL) {\n+ structure(\n+ list(\n+ tracking_uri = tracking_uri,\n+ server_url = server_url %||% tracking_uri\n+ ),\n+ class = \"mlflow_client\"\n+ )\n+}\n+\n+#' Initialize an MLflow client\n+#'\n+#' ... | 90e8fd93a020b123bbacde528607037c9bff4515 | diff --git a/mlflow/R/mlflow/.Rbuildignore b/mlflow/R/mlflow/.Rbuildignore
index d393c4592597d..bf1b8346f00a9 100644
--- a/mlflow/R/mlflow/.Rbuildignore
+++ b/mlflow/R/mlflow/.Rbuildignore
@@ -11,3 +11,5 @@ packrat
document.R
Reference_Manual_mlflow.md
.lintr
+^man-roxygen/
+^internal/
diff --git a/mlflow/R/mlflow/.... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
mlflow__mlflow-473@778b806 | mlflow/mlflow | Python | 473 | Don't allow run creation if the experiment is deleted. | Should resolve https://github.com/mlflow/mlflow/issues/468.
Open question for reviewer, should we validate on APIs like log_param? Would this make the performance too poor? | 2018-09-12T02:48:32Z | Broken mlruns after experiment deletion
### System information
- No custom code
- macOS 10.13.6
- pip
- `mlflow --version` = 0.6.0
- **Python version**: 3.6
- **Exact command to reproduce**: `mlflow experiments delete 1`
### Describe the problem
After deleting an experiment the UI breaks. An error is printed:... | +1 getting the same issue on Ubuntu with no custom code, etc.
I copied the meta.yaml file from another experiment and the problem seemed to go away.
Thanks for reporting the issue. I can report most of these issues and am working on a fix. The specific issue here is that we don't validate creating runs against dele... | [
{
"body": "### System information\r\n- No custom code\r\n- macOS 10.13.6\r\n- pip\r\n- `mlflow --version` = 0.6.0\r\n- **Python version**: 3.6\r\n- **Exact command to reproduce**: `mlflow experiments delete 1`\r\n\r\n### Describe the problem\r\nAfter deleting an experiment the UI breaks. An error is printed:\r\... | d2c3d1ced3116eebd7ee79e9e48a9730f6bd101e | {
"head_commit": "778b80634a95d7300df565c91084015a4766f019",
"head_commit_message": "generate protos",
"patch_to_review": "diff --git a/mlflow/entities/experiment.py b/mlflow/entities/experiment.py\nindex d52c3b32134b1..d423ef24750cb 100644\n--- a/mlflow/entities/experiment.py\n+++ b/mlflow/entities/experiment.py... | [
{
"diff_hunk": "@@ -87,12 +87,12 @@ def _get_experiment_path(self, experiment_id, view_type=ViewType.ALL):\n for parent in parents:\n exp_list = find(parent, str(experiment_id), full_path=True)\n if len(exp_list) > 0:\n- return exp_list\n- return []\n+ ... | 844703d47ff407424a7759491030e7b24aafa018 | diff --git a/mlflow/entities/experiment.py b/mlflow/entities/experiment.py
index d52c3b32134b1..d423ef24750cb 100644
--- a/mlflow/entities/experiment.py
+++ b/mlflow/entities/experiment.py
@@ -7,12 +7,15 @@ class Experiment(_MLflowObject):
Experiment object.
"""
DEFAULT_EXPERIMENT_ID = 0
+ ACTIVE_LIFE... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
mlflow__mlflow-2689@d5773ef | mlflow/mlflow | Python | 2,689 | Add Fastai flavor | ## What changes are proposed in this pull request?
This PR includes a new flavor for Fastai v1. It supports model exporting.
It's also included an improvement of log_fn_args_as_params function that replaces the deprecated function getargspec in favor of getfullargspec which supports keyword-only parameters.
Cl... | 2020-04-11T17:54:35Z | [FR] Autologging functionality for PyTorch/fastai
## Describe the proposal
It'd be nice to add an mlflow.pytorch.autolog() API for automatically logging metrics, params & models generated via PyTorch. In particular, I'd like this to be incorporated with the fastai library (built on PyTorch), which also generates art... | @shalomma @LarsHill would either of you be interested in working on this feature? If so I'm happy to write up / help collaborate on an API proposal :)
@smurching sorry, but in the near future I won't have time working on it. I just thought it would be a useful feature.
@smurching are you working on it ? I will be happy... | [
{
"body": "## Describe the proposal\r\n\r\nIt'd be nice to add an mlflow.pytorch.autolog() API for automatically logging metrics, params & models generated via PyTorch. In particular, I'd like this to be incorporated with the fastai library (built on PyTorch), which also generates artifacts such as learning rat... | 8351d82e6ad4103bc58159175b29b406abb1e052 | {
"head_commit": "d5773ef4f93b170d1c5b0399207695ef32a4831b",
"head_commit_message": "Add fastai flavor",
"patch_to_review": "diff --git a/.travis.yml b/.travis.yml\nindex 1be8011cf35a5..5ddaceaff8a8b 100644\n--- a/.travis.yml\n+++ b/.travis.yml\n@@ -84,7 +84,7 @@ matrix:\n - pip install -r travis/small-re... | [
{
"diff_hunk": "@@ -0,0 +1,287 @@\n+from __future__ import print_function\n+\n+import mock\n+import os\n+import pytest\n+import yaml\n+import json\n+from collections import namedtuple\n+\n+import numpy as np\n+import pandas as pd\n+import pandas.testing\n+import sklearn.datasets as datasets\n+from fastai.tabula... | 55298b5c5d3a67d8fa6fbd14804538c4cf243592 | diff --git a/.travis.yml b/.travis.yml
index 2dd3f11f7fddc..465a05166f95a 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -78,7 +78,8 @@ matrix:
- pip install -r travis/small-requirements.txt
- pip install -e .
script:
- - pytest --verbose --ignore=tests/h2o --ignore=tests/keras --ignore=t... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
matplotlib__matplotlib-9121@d79d6bb | matplotlib/matplotlib | Python | 9,121 | Remove old normalising code from plt.hist | This PR does a few things:
- Add a test for a normed histogram
- Rename the variable `n` to `tops` to make the code more readable
- Remove the old code to normalize histograms. This is now handled with numpy
- Remove the old notes section about how numpy used to be broken (fixes #8333) | 2017-08-29T20:33:47Z | Rely on numpy to properly normalize histograms with unequal bin widths
The source of `hist` contains the following snippets:
```
Notes
-----
Until numpy release 1.5, the underlying numpy histogram function was
incorrect with `normed`=`True` if bin sizes were unequal. MPL
i... | https://github.com/matplotlib/matplotlib/pull/7856 is starting to move this direction.
So it turns out we're not actually testing normed histograms at all..... PR incoming | [
{
"body": "The source of `hist` contains the following snippets:\r\n```\r\n Notes\r\n -----\r\n Until numpy release 1.5, the underlying numpy histogram function was\r\n incorrect with `normed`=`True` if bin sizes were unequal. MPL\r\n inherited that error. It is now correcte... | a67b232db2d1632e97a6f503a15edb5fc9980093 | {
"head_commit": "d79d6bb99102fdda581198eee4ca77dfe9355ca1",
"head_commit_message": "Remove un-used code",
"patch_to_review": "diff --git a/lib/matplotlib/axes/_axes.py b/lib/matplotlib/axes/_axes.py\nindex 15ba96030a89..2c2b246ba654 100644\n--- a/lib/matplotlib/axes/_axes.py\n+++ b/lib/matplotlib/axes/_axes.py\n... | [
{
"diff_hunk": "@@ -1464,6 +1464,14 @@ def test_hist_step_filled():\n assert all([p.get_facecolor() == p.get_edgecolor() for p in patches])\n \n \n+@image_comparison(baseline_images=['hist_density'], extensions=['png'])\n+def test_hist_density():\n+ np.random.seed(0)",
"line": null,
"original_lin... | 2dde48aed02e63fff1477673735fc3dce388c3bd | diff --git a/lib/matplotlib/axes/_axes.py b/lib/matplotlib/axes/_axes.py
index 15ba96030a89..2c2b246ba654 100644
--- a/lib/matplotlib/axes/_axes.py
+++ b/lib/matplotlib/axes/_axes.py
@@ -5988,13 +5988,6 @@ def hist(self, x, bins=None, range=None, density=None, weights=None,
--------
hist2d : 2D histog... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Code Refactoring / Architectural Improvement"
} |
matplotlib__matplotlib-8938@d670a4f | matplotlib/matplotlib | Python | 8,938 | Move float() casting in Rectangle patch | <!--Thank you so much for your PR! To help us review, fill out the form
to the best of your ability. Please make use of the development guide at
https://matplotlib.org/devdocs/devel/index.html-->
<!--Provide a general summary of your changes in the title above, for
example "Raises ValueError on Non-Numeric Input... | 2017-07-25T21:18:14Z | Rectangle patch constructor fails with units
Using unit'ized inputs in Rectangle fails in the constructor:
```
File "test_units_patches.py", line 23, in test_units_rectangle
p = mpatches.Rectangle( ( 5*U.km, 6*U.km ), 1*U.km, 2*U.km )
File "/home/trd/git/TD22057/matplotlib/build/lib.linux-x86_64-2.7/ma... | Pull request #5422 adds a test case and correct image for this this failure but doesn't fix Rectangle. This was changed for #4751 but no test case was added for that failure so there is no easy way to verify both fixes.
Sorry for the long delay here; there's a small python3 compatibility bug in `jpl_units` that needs... | [
{
"body": "Using unit'ized inputs in Rectangle fails in the constructor:\n\n```\n File \"test_units_patches.py\", line 23, in test_units_rectangle\n p = mpatches.Rectangle( ( 5*U.km, 6*U.km ), 1*U.km, 2*U.km )\n File \"/home/trd/git/TD22057/matplotlib/build/lib.linux-x86_64-2.7/matplotlib/patches.p... | c45678e718fcb57554a7552242c5378f2d81cea7 | {
"head_commit": "d670a4f71c2a0ba2b18c54811dac94b31a2ce5f4",
"head_commit_message": "Add uint8 test",
"patch_to_review": "diff --git a/lib/matplotlib/patches.py b/lib/matplotlib/patches.py\nindex 26195999f622..6c1d5fa84a97 100644\n--- a/lib/matplotlib/patches.py\n+++ b/lib/matplotlib/patches.py\n@@ -688,10 +688,1... | [
{
"diff_hunk": "@@ -4946,6 +4946,11 @@ def test_ls_ds_conflict():\n plt.plot(range(32), linestyle='steps-pre:', drawstyle='steps-post')\n \n \n+@image_comparison(baseline_images=['bar_uint8'], extensions=['png'])",
"line": null,
"original_line": 4949,
"original_start_line": null,
"path":... | 17ec69e174006089719bc1474be1b8a4fea671d5 | diff --git a/lib/matplotlib/patches.py b/lib/matplotlib/patches.py
index 26195999f622..6c1d5fa84a97 100644
--- a/lib/matplotlib/patches.py
+++ b/lib/matplotlib/patches.py
@@ -688,10 +688,10 @@ def __init__(self, xy, width, height, angle=0.0, **kwargs):
Patch.__init__(self, **kwargs)
- self._x = floa... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
mlflow__mlflow-5017@18b9fac | mlflow/mlflow | Python | 5,017 | Automatically update metric plots for in-progress runs #2099 | Signed-off-by: Cedric Koffeto cedkoffeto@gmail.com
## What changes are proposed in this pull request?
setInterval function added in metricsPlotPanel component which retrieves execution status and metrics history from API every 8 seconds to update the plot and automatically stops when all executions are complete... | 2021-11-07T20:13:58Z | [FR] Automatically update metric plots for in-progress runs
## MLflow Roadmap Item
This is an MLflow Roadmap item that has been prioritized by the MLflow maintainers. We're seeking help with the implementation of roadmap items tagged with the `help wanted` label. Items tagged with the `needs design` label are awaiti... | would be much appreciated, prob better by a checkbox or similar, being disabled as default, if possible avoid refresh the whole page and keep all visual settings, filters,etc
Just come in to say that this feature is much appreciated! Will make mlflow a tensorboard killer! Now I am using some auto-refresh extension in f... | [
{
"body": "## MLflow Roadmap Item\r\n\r\nThis is an MLflow Roadmap item that has been prioritized by the MLflow maintainers. We're seeking help with the implementation of roadmap items tagged with the `help wanted` label. Items tagged with the `needs design` label are awaiting a design sketch from an MLflow mai... | af8460f4f5f8bd407a597e1e52e2ff77d646a3cd | {
"head_commit": "18b9fac2b5053362be8452748eed4cd1bd7588bf",
"head_commit_message": "bug fix\n\nSigned-off-by: cedric koffeto <cedkoffeto@gmail.com>",
"patch_to_review": "diff --git a/mlflow/server/js/src/experiment-tracking/components/MetricsPlotPanel.js b/mlflow/server/js/src/experiment-tracking/components/Metr... | [
{
"diff_hunk": "@@ -63,6 +65,8 @@ export class MetricsPlotPanel extends React.Component {\n // a single-click event.\n SINGLE_CLICK_EVENT_DELAY_MS = this.MAX_DOUBLE_CLICK_INTERVAL_MS + 10;\n \n+ DURATION_BETWEEN_HISTORY_UPDATES_MS = 8000;",
"line": null,
"original_line": 68,
"original_start_lin... | f246b63f7c4564927d5a38d7c4dc98c8e79a56f7 | diff --git a/mlflow/server/js/src/experiment-tracking/components/MetricsPlotControls.js b/mlflow/server/js/src/experiment-tracking/components/MetricsPlotControls.js
index 95ea5caf633fe..cc0f0a499e806 100644
--- a/mlflow/server/js/src/experiment-tracking/components/MetricsPlotControls.js
+++ b/mlflow/server/js/src/exper... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
mlflow__mlflow-4862@dc2d6e3 | mlflow/mlflow | Python | 4,862 | Added diff-view switch | Signed-off-by: Marijn Valk <marijncv@hotmail.com>
## What changes are proposed in this pull request?
Added a checkbox for switching between diff-only view and regular view. closes #4819
## How is this patch tested?
Create a couple of runs with params, metrics and tag of which some are different accross run... | 2021-10-01T20:06:40Z | [FR] Diff-only view for runs table on experiments page
## MLflow Roadmap Item
This is an MLflow Roadmap item that has been prioritized by the MLflow maintainers. We're seeking help with the implementation of roadmap items tagged with the `help wanted` label.
For requirements clarifications and implementation ques... | Hey @dbczumar & @harupy, I created a rough draft PR to address this FR. No unit tests and not much effort yet in the visual presentation yet but I was wondering if I'm heading in the right direction with this one. Any thoughts on where to place the checkbox in relation to the other buttons/dropdowns? | [
{
"body": "## MLflow Roadmap Item\r\n\r\nThis is an MLflow Roadmap item that has been prioritized by the MLflow maintainers. We're seeking help with the implementation of roadmap items tagged with the `help wanted` label.\r\n\r\nFor requirements clarifications and implementation questions, or to request a PR re... | 706758e753dca1a29f11da83d83007058a335fc7 | {
"head_commit": "dc2d6e3c5a11c8cbf83e0de4f850e448223f2d49",
"head_commit_message": "Small comment update\n\nSigned-off-by: Marijn Valk <marijncv@hotmail.com>",
"patch_to_review": "diff --git a/mlflow/server/js/src/experiment-tracking/components/ExperimentView.js b/mlflow/server/js/src/experiment-tracking/compone... | [
{
"diff_hunk": "@@ -556,6 +557,78 @@ export default class ExperimentViewUtil {\n }\n return numRunsFromLatestSearch < SEARCH_MAX_RESULTS;\n }\n+\n+ /**\n+ * Obtain the categorized columns for which the values in them\n+ * have only a single value (or are undefined)\n+ */\n+ static getCategoriz... | 4c418bb1c20cc951440071ae22fc26afddbdef50 | diff --git a/mlflow/server/js/src/experiment-tracking/components/ExperimentView.js b/mlflow/server/js/src/experiment-tracking/components/ExperimentView.js
index bc4d3581deb86..79f7066da24ac 100644
--- a/mlflow/server/js/src/experiment-tracking/components/ExperimentView.js
+++ b/mlflow/server/js/src/experiment-tracking/... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
matplotlib__matplotlib-8729@f76a010 | matplotlib/matplotlib | Python | 8,729 | Parameterize test_fill_between and test_fill_betweenx | <!--Thank you so much for your PR! To help us review, fill out the form
to the best of your ability. Please make use of the development guide at
https://matplotlib.org/devdocs/devel/index.html-->
<!--Provide a general summary of your changes in the title above, for
example "Raises ValueError on Non-Numeric Input... | 2017-06-07T14:47:07Z | fill_between_2d tests are testing the wrong thing
test_axes.py contains a few tests of the form
```
def test_fill_between_2d_x_input():
x = np.zeros((2, 2))
y1 = 3
y2 = 3
fig = plt.figure()
ax = fig.add_subplot(211)
with pytest.raises(ValueError):
ax.plot(x, y1, x, y2, color='... | Exact work:
- drop the plot call (or seperately test that it fails)
- paraterize all six tests from https://github.com/matplotlib/matplotlib/pull/7817/files into one test
Marked as new contributor friendly because it can be done understanding pytest but not the Matplotlib code base. | [
{
"body": "test_axes.py contains a few tests of the form\r\n```\r\ndef test_fill_between_2d_x_input():\r\n x = np.zeros((2, 2))\r\n y1 = 3\r\n y2 = 3\r\n\r\n fig = plt.figure()\r\n ax = fig.add_subplot(211)\r\n with pytest.raises(ValueError):\r\n ax.plot(x, y1, x, y2, color='black')\r\n... | 6da2b8c988b7a375f6701819266c6f1743a6eeba | {
"head_commit": "f76a010ba2c13d719669ccf5d652ff24d4f26fe3",
"head_commit_message": "Parameterize test_fill_between and test_fill_betweenx",
"patch_to_review": "diff --git a/lib/matplotlib/tests/test_axes.py b/lib/matplotlib/tests/test_axes.py\nindex 86b6f2a3ddc2..5eb9faf48b31 100644\n--- a/lib/matplotlib/tests/t... | [
{
"diff_hunk": "@@ -847,40 +847,32 @@ def test_polycollection_joinstyle():\n ax.set_ybound(0, 3)\n \n \n-def test_fill_between_2d_x_input():\n- x = np.zeros((2, 2))\n- y1 = 3\n- y2 = 3\n-\n- fig = plt.figure()\n- ax = fig.add_subplot(211)\n- with pytest.raises(ValueError):\n- ax.plo... | a0ccb78c269311b4dd4d3b70ee87d989dd2ba1cb | diff --git a/lib/matplotlib/tests/test_axes.py b/lib/matplotlib/tests/test_axes.py
index 86b6f2a3ddc2..f1cc67fde7a4 100644
--- a/lib/matplotlib/tests/test_axes.py
+++ b/lib/matplotlib/tests/test_axes.py
@@ -847,40 +847,40 @@ def test_polycollection_joinstyle():
ax.set_ybound(0, 3)
-def test_fill_between_2d_x_i... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Test Suite / CI Enhancements"
} |
jina-ai__serve-5756@8e25d45 | jina-ai/serve | Python | 5,756 | feat(cli): added option on the new command to create a deployment project or a flow project | I added a feature to allow users to be able to create a deployment themed project from the `new` command on the cli. This would allow users to specify an optional `--type` flag which would allow them to create a project as either a `deployment` or a `flow`. If no `--type` is specified it defaults to a `flow`. If a wron... | 2023-03-11T21:26:34Z | Add option on the Jina CLI to allow deployment centric projects by adding a `deployment` flag
**Describe the feature**
Add option for `jina new` to be either flow centric or deployment centric
**Your proposal**
Add a flag to the `jina new` command to allow optional creation of deployment centric | Hello @asuzukosi,
Thanks for opening this ticket. Any specific UX that you would like this option to have?
Yes, a flag could be added to the `jina new` command `deployment` which would specify that a deployment project is being created and `flow` which would specify that a flow project is being created. It would def... | [
{
"body": "**Describe the feature**\r\nAdd option for `jina new` to be either flow centric or deployment centric\r\n\r\n**Your proposal**\r\nAdd a flag to the `jina new` command to allow optional creation of deployment centric",
"number": 5755,
"title": "Add option on the Jina CLI to allow deployment ce... | f7502a4b3b9fe8ba0ee072109385f1166304cc5f | {
"head_commit": "8e25d4589b709eadb40ba621150df88531dd5c6d",
"head_commit_message": "docs(create-app): correct capitalization on flow and deployment",
"patch_to_review": "diff --git a/docs/get-started/create-app.md b/docs/get-started/create-app.md\nindex 54765ec5f32cc..510bb6bde8372 100644\n--- a/docs/get-started... | [
{
"diff_hunk": "@@ -1,34 +1,175 @@\n # {fas}`folder-plus` Create First Project\n \n-Let's build a toy application with Jina. To start, use Jina CLI to make a new project:\n+Let's build a toy application with Jina. To start, use Jina CLI to make a new Deployment or a Flow: \n \n+````{tab} Deployment\n+\n+To crea... | 7e15e098b2ddc57fb194793e0cd3b97f7b8fcda9 | diff --git a/docs/get-started/create-app.md b/docs/get-started/create-app.md
index 54765ec5f32cc..69ce521b20c83 100644
--- a/docs/get-started/create-app.md
+++ b/docs/get-started/create-app.md
@@ -1,9 +1,11 @@
# {fas}`folder-plus` Create First Project
-Let's build a toy application with Jina. To start, use Jina CLI ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
matplotlib__matplotlib-8011@a4d6768 | matplotlib/matplotlib | Python | 8,011 | Deprecate is_string_like, is_sequence_of_strings | While implementing #7996 (see also #7835), I had missed that numpy's `str_` (and `unicode_` on Py2) derive from the corresponding builtin type(s), so `isinstance(x, six.text_type)` is just as good. So I just inlined that and restored the old definition of `is_string_like`, immediately deprecating it.
Would also (up... | 2017-02-03T00:01:52Z | `is_string_like` returns True for numpy `object` arrays
### Bug report
**Bug summary**
Function `is_string_like` returns True for numpy `object` arrays
**Code for reproduction**
```python
import numpy as np
from matplotlib.cbook import is_string_like
print(is_string_like(np.array(map(str, [1,2,3]), dtype... | In what context is this a problem? A numpy object array of str objects _is_ very string like [he says having flash-backs to MATLAB days].
I use `seaborn`, and a `pandas.Dataframe` to scatter some points.
Here, I need to concatenate a label vector (of type `object`) to my data matrix. Such operation causes the DataFr... | [
{
"body": "### Bug report\r\n\r\n**Bug summary**\r\n\r\nFunction `is_string_like` returns True for numpy `object` arrays\r\n\r\n**Code for reproduction**\r\n\r\n```python\r\nimport numpy as np\r\nfrom matplotlib.cbook import is_string_like\r\nprint(is_string_like(np.array(map(str, [1,2,3]), dtype=object)))\r\n`... | 1c0b96c592e2668f402cee131baeef9d1c2754bb | {
"head_commit": "a4d676839e97072892fb181bd48abc32d0c5f4fd",
"head_commit_message": "Deprecate is_sequence_of_strings; cleanup.\n\n`Axes3D.scatter` no longer flattens a 2D color input.",
"patch_to_review": "diff --git a/doc/api/api_changes/2017-01-30-AL_is_numlike_stringlike.rst b/doc/api/api_changes/2017-01-30-A... | [
{
"diff_hunk": "@@ -1,8 +1,10 @@\n-`cbook.is_numlike` and `cbook.is_string_like` only perform an instance check\n-````````````````````````````````````````````````````````````````````````````\n+`cbook.is_numlike` only performs an instance check, `cbook.is_string_like` is deprecated\n+````````````````````````````... | 7b05193901fffebd2c888f4c96d132a605767b39 | diff --git a/doc/api/api_changes/2017-01-30-AL_is_numlike_stringlike.rst b/doc/api/api_changes/2017-01-30-AL_is_numlike_stringlike.rst
index ba062de5d71a..131003275271 100644
--- a/doc/api/api_changes/2017-01-30-AL_is_numlike_stringlike.rst
+++ b/doc/api/api_changes/2017-01-30-AL_is_numlike_stringlike.rst
@@ -1,8 +1,10... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
mlflow__mlflow-2619@396c1f4 | mlflow/mlflow | Python | 2,619 | Add autologging support for Fastai | ## What changes are proposed in this pull request?
This PR includes a new flavor for Fastai v1. It supports model exporting and autologging.
The autologging functionality keeps track of most used callbacks: EarlyStopping and OneCycleScheduler.
It's also included an improvement of log_fn_args_as_params function ... | 2020-03-21T00:40:09Z | [FR] Autologging functionality for PyTorch/fastai
## Describe the proposal
It'd be nice to add an mlflow.pytorch.autolog() API for automatically logging metrics, params & models generated via PyTorch. In particular, I'd like this to be incorporated with the fastai library (built on PyTorch), which also generates art... | @shalomma @LarsHill would either of you be interested in working on this feature? If so I'm happy to write up / help collaborate on an API proposal :)
@smurching sorry, but in the near future I won't have time working on it. I just thought it would be a useful feature.
@smurching are you working on it ? I will be happy... | [
{
"body": "## Describe the proposal\r\n\r\nIt'd be nice to add an mlflow.pytorch.autolog() API for automatically logging metrics, params & models generated via PyTorch. In particular, I'd like this to be incorporated with the fastai library (built on PyTorch), which also generates artifacts such as learning rat... | dce57147980a4ca4a059a40145cf65a64d21ff07 | {
"head_commit": "396c1f43591650273f481b873525298c10d2ec8c",
"head_commit_message": "Fix linting issues for fastai.py",
"patch_to_review": "diff --git a/.travis.yml b/.travis.yml\nindex 6ec39db277109..66d88514e089f 100644\n--- a/.travis.yml\n+++ b/.travis.yml\n@@ -83,7 +83,7 @@ matrix:\n - pip install -r ... | [
{
"diff_hunk": "@@ -0,0 +1,340 @@\n+\"\"\"\n+The ``mlflow.fastai`` module provides an API for logging and loading fast.ai models. This module\n+exports fast.ai models with the following flavors:\n+\n+fastai (native) format\n+ This is the main flavor that can be loaded back into fastai.\n+:py:mod:`mlflow.pyfu... | c4aab89aec9ddaf1679576070460d439e2a662a5 | diff --git a/mlflow/fastai.py b/mlflow/fastai.py
index 476790e5a6bbc..56e7898c48d82 100644
--- a/mlflow/fastai.py
+++ b/mlflow/fastai.py
@@ -14,6 +14,9 @@
"""
import os
import yaml
+import gorilla
+import tempfile
+import shutil
import pandas as pd
import numpy as np
@@ -25,6 +28,8 @@
from mlflow.tracking.artif... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
jina-ai__serve-5614@7d4c3e7 | jina-ai/serve | Python | 5,614 | feat: add grpc streaming endpoint to worker and head runtimes | closes: https://github.com/jina-ai/jina/issues/5604 | 2023-01-20T13:31:37Z | Add the JinaRPC service to workerRuntime and HeadRuntime
Add the JinaRPC service to workerRuntime and HeadRuntime. This will allow jina client to communicate with both runtimes using `stream=True`.
Currently `stream=False` already works but not tested.
Add tests for client communicating with both runtimes in both cas... | [
{
"body": "Add the JinaRPC service to workerRuntime and HeadRuntime. This will allow jina client to communicate with both runtimes using `stream=True`.\r\nCurrently `stream=False` already works but not tested.\r\nAdd tests for client communicating with both runtimes in both cases",
"number": 5604,
"titl... | 26354a5e22481b58d4ef94f38cb20cf71cfbe751 | {
"head_commit": "7d4c3e77b5d285e044bcba2c93e94a54c7779f94",
"head_commit_message": "fix: await process data in head runtime",
"patch_to_review": "diff --git a/jina/proto/jina.proto b/jina/proto/jina.proto\nindex f844eeffa4812..a021b39d6f1e1 100644\n--- a/jina/proto/jina.proto\n+++ b/jina/proto/jina.proto\n@@ -16... | [
{
"diff_hunk": "@@ -121,6 +123,9 @@ async def _async_setup_grpc_server(self):\n interceptors=self.aio_tracing_server_interceptors(),\n )\n \n+ print('adding JinaRPCServicer')",
"line": null,
"original_line": 126,
"original_start_line": null,
"path": "jina/serve/runtime... | 29728cc289609b486aa0c84d0126ad5cb099fd5e | diff --git a/jina/proto/jina.proto b/jina/proto/jina.proto
index f844eeffa4812..a021b39d6f1e1 100644
--- a/jina/proto/jina.proto
+++ b/jina/proto/jina.proto
@@ -160,7 +160,7 @@ service JinaSingleDataRequestRPC {
}
/**
- * jina Gateway gRPC service.
+ * jina streaming gRPC service.
*/
service JinaRPC {
// Pa... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
jina-ai__serve-5628@786b3ed | jina-ai/serve | Python | 5,628 | feat: deployment yaml | closes: https://github.com/jina-ai/jina/issues/5552
TODOs:
- [x] Separate deployment parser and executor parser
- [x] remove some arguments from executor
- [x] Add jaml parser for Deployment under jaml/parsers/deployment
- [x] Flow.add() should be able to decide whether to call Deployment.load_config(uses=depl... | 2023-01-26T09:49:31Z | Create Deployment YAML separate from Executor YAML
create deployment yaml separate from Executor yaml
* add Deployment.load_config
A deployment can use an Executor YAML like so:
Deployment(uses='executor.yaml', replicas=...)
But a deployment YAML is used like so:
Deployment.load_config(uses='deployment.yaml... | [
{
"body": "create deployment yaml separate from Executor yaml\r\n\r\n* add Deployment.load_config\r\n\r\nA deployment can use an Executor YAML like so:\r\n Deployment(uses='executor.yaml', replicas=...)\r\n\r\nBut a deployment YAML is used like so:\r\nDeployment.load_config(uses='deployment.yaml')\r\n\r\nPossib... | aad4b61a940aac37aa92f7855f5c4273be078e2a | {
"head_commit": "786b3ed1f14af4b31c02d1829513e17a1623f3b1",
"head_commit_message": "test: test flow with deployment",
"patch_to_review": "diff --git a/jina/jaml/__init__.py b/jina/jaml/__init__.py\nindex f09bb5e69fa43..77ec56eef14a8 100644\n--- a/jina/jaml/__init__.py\n+++ b/jina/jaml/__init__.py\n@@ -740,6 +740... | [
{
"diff_hunk": "@@ -1,6 +1,7 @@\n import warnings\n from typing import List, Optional, Type\n \n+from jina import Deployment",
"line": null,
"original_line": 4,
"original_start_line": null,
"path": "jina/jaml/parsers/__init__.py",
"start_line": null,
"text": "@user1:\ncan we avoid import... | 9fd5bbe2ea499398023ed520a57d05ed66d1bcdf | diff --git a/docs/concepts/flow/deployment-args.md b/docs/concepts/flow/deployment-args.md
new file mode 100644
index 0000000000000..1700d3c3b1912
--- /dev/null
+++ b/docs/concepts/flow/deployment-args.md
@@ -0,0 +1,58 @@
+| Name | Description | Type | Default |
+|----|----|----|----|
+| `name` | The name of this objec... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
jina-ai__serve-5607@900d9e3 | jina-ai/serve | Python | 5,607 | feat: add prefetch argument to client post method | <!---Decomposing the complex issue into subtasks can help you build it step-by-step. Thanks for your pull request! :rocket: --->
<!---We know that dev life is hectic, but **please provide a (brief) description** of what your PR does, and how it does it. **Otherwise, your PR cannot be reviewed!** --->
<!---This policy... | 2023-01-17T13:58:09Z | feat: provide post request level prefetch argument
**Describe the feature**
<!-- A clear and concise description of what the feature is. -->
The `prefetch` argument is currently used in the Gateway to control the number of in flight requests. This mechanism acts a preliminary back pressure to the executors by not ... | [
{
"body": "**Describe the feature**\r\n<!-- A clear and concise description of what the feature is. -->\r\n\r\nThe `prefetch` argument is currently used in the Gateway to control the number of in flight requests. This mechanism acts a preliminary back pressure to the executors by not overloading the executors u... | ff7365ff2662b0771b51388922baae896767441c | {
"head_commit": "900d9e37109d9c629981803c5a5a3eb6b10bb027",
"head_commit_message": "style: fix overload and cli autocomplete",
"patch_to_review": "diff --git a/docs/concepts/flow/executor-args.md b/docs/concepts/flow/executor-args.md\nindex 721c7e51c5f0e..eacc98f476c92 100644\n--- a/docs/concepts/flow/executor-a... | [
{
"diff_hunk": "@@ -62,24 +64,38 @@ def __init__(\n self.total_num_floating_tasks_alive = 0\n \n async def stream(\n- self, request_iterator, context=None, results_in_order: bool = False, *args\n+ self,\n+ request_iterator,\n+ context=None,\n+ results_in_order: boo... | 0fc566e8f3bce97b55c0543dcf0052e2cd78e2a9 | diff --git a/docs/concepts/client/index.md b/docs/concepts/client/index.md
index 859203d046c61..1e5f6ef4d3a78 100644
--- a/docs/concepts/client/index.md
+++ b/docs/concepts/client/index.md
@@ -212,6 +212,7 @@ send-receive-data
send-parameters
send-graphql-mutation
callbacks
+rate-limit
instrumentation
third-party-... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
jina-ai__serve-5590@1fdfbc4 | jina-ai/serve | Python | 5,590 | feat: add client to deployment | based on: https://github.com/jina-ai/jina/pull/5574
closes: https://github.com/jina-ai/jina/issues/5551 | 2023-01-10T13:18:20Z | Offer a client as part of Deployment when serving an Executor
When using a Deployment with the context manager, offer a client as well.
Basically, Deployment should extend PostMixin and by default, expose a gateway (like in Flow).
(This might mean adding more gateway args to deployment.)
In Flow, all usages of Deplo... | [
{
"body": "When using a Deployment with the context manager, offer a client as well.\r\nBasically, Deployment should extend PostMixin and by default, expose a gateway (like in Flow).\r\n(This might mean adding more gateway args to deployment.)\r\nIn Flow, all usages of Deployment should not add a gateway",
... | 69ff38aac7026dcd33329189eb2688955a9b1f9b | {
"head_commit": "1fdfbc4bb51e6fa1175662d39de9c06b7b27abcd",
"head_commit_message": "style: fix overload and cli autocomplete",
"patch_to_review": "diff --git a/docs/concepts/executor/serve.md b/docs/concepts/executor/serve.md\nindex ca50c4a69ef68..b572c4cecb15c 100644\n--- a/docs/concepts/executor/serve.md\n+++ ... | [
{
"diff_hunk": "@@ -75,7 +75,8 @@ py_modules:\n from jina import Deployment\n \n with Deployment(uses='executor.yaml', port=12345, replicas=2) as dep:\n- dep.block()\n+ docs = dep.post(inputs=DocumentArray.empty(1), on='/foo')",
"line": null,
"original_line": 78,
"original_start_line": null,
... | b05b682a0f82c8bebee2630ff376dfe163fdcaec | diff --git a/docs/concepts/executor/serve.md b/docs/concepts/executor/serve.md
index ca50c4a69ef68..5017e9d00d1e5 100644
--- a/docs/concepts/executor/serve.md
+++ b/docs/concepts/executor/serve.md
@@ -44,7 +44,6 @@ In other words:
This separation also aims to enhance the reusability of Executors: the same implementati... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
jina-ai__serve-5570@2af7dcb | jina-ai/serve | Python | 5,570 | fix: multi protocol gateway supports monitoring | <!---Decomposing the complex issue into subtasks can help you build it step-by-step. Thanks for your pull request! :rocket: --->
<!---We know that dev life is hectic, but **please provide a (brief) description** of what your PR does, and how it does it. **Otherwise, your PR cannot be reviewed!** --->
<!---This policy... | 2023-01-03T12:56:49Z | multi protocol gateway does not support monitoring
multi protocol gateway currently does not support monitoring:
`jina gateway --monitoring --protocol GRPC HTTP --port 54321 54322`
results in :
```
TypeError: cannot pickle '_thread.lock' object
```
Basically, the metrics_registry object cannot be copied in jina... | [
{
"body": "multi protocol gateway currently does not support monitoring:\r\n`jina gateway --monitoring --protocol GRPC HTTP --port 54321 54322`\r\nresults in :\r\n```\r\nTypeError: cannot pickle '_thread.lock' object\r\n```\r\n\r\nBasically, the metrics_registry object cannot be copied in jina/serve/runtimes/ga... | 34990168f1f17f7e862c65543592f9d162c4e4dd | {
"head_commit": "2af7dcbee25403d5b8a684dd8ad2bce782602fae",
"head_commit_message": "test: add test for multiprotocol with monitoring",
"patch_to_review": "diff --git a/jina/helper.py b/jina/helper.py\nindex 73695148648fc..0a857a204cf2b 100644\n--- a/jina/helper.py\n+++ b/jina/helper.py\n@@ -54,6 +54,7 @@\n '... | [
{
"diff_hunk": "@@ -1265,6 +1266,25 @@ def convert_tuple_to_list(d: Dict):\n convert_tuple_to_list(v)\n \n \n+def deepcopy_with_ignore_attrs(",
"line": null,
"original_line": 1269,
"original_start_line": null,
"path": "jina/helper.py",
"start_line": null,
"text": "@user1:\nwe... | a28f96a0475e64b958696f3d57bb188f21886cae | diff --git a/jina/serve/runtimes/gateway/composite/gateway.py b/jina/serve/runtimes/gateway/composite/gateway.py
index b93458f9477c0..feece8a5debaa 100644
--- a/jina/serve/runtimes/gateway/composite/gateway.py
+++ b/jina/serve/runtimes/gateway/composite/gateway.py
@@ -1,5 +1,5 @@
import copy
-from typing import List, ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
jina-ai__serve-5535@575735b | jina-ai/serve | Python | 5,535 | docs: common args inheritence from Flow API | <!---Decomposing the complex issue into subtasks can help you build it step-by-step. Thanks for your pull request! :rocket: --->
<!---We know that dev life is hectic, but **please provide a (brief) description** of what your PR does, and how it does it. **Otherwise, your PR cannot be reviewed!** --->
<!---This policy... | 2022-12-16T15:10:31Z | Document the common args inheritence from Flow API to Executors and Gateway
Currently, flow API accepts all args of all entities.
These args will be propagated to other entities (gateway, executor) with some occasional exclusion.
We need to document this behavior and document what arguments are excluded | [
{
"body": "Currently, flow API accepts all args of all entities.\r\nThese args will be propagated to other entities (gateway, executor) with some occasional exclusion.\r\nWe need to document this behavior and document what arguments are excluded",
"number": 5353,
"title": "Document the common args inher... | 3c09e6e214eccc30f64d3003d9fbbc1224071118 | {
"head_commit": "575735b60ad5dc9a2de847574d3ded3a05906306",
"head_commit_message": "docs: add excluded arguments to flow",
"patch_to_review": "diff --git a/docs/concepts/flow/basics.md b/docs/concepts/flow/basics.md\nindex 47ab296ffbba3..a3ae0f99ec9c2 100644\n--- a/docs/concepts/flow/basics.md\n+++ b/docs/concep... | [
{
"diff_hunk": "@@ -301,6 +301,13 @@ You can control the access mode, storage class name and capacity of the attached\n `JINA_K8S_ACCESS_MODES`, `JINA_K8S_STORAGE_CLASS_NAME` and `JINA_K8S_STORAGE_CAPACITY`. Only the first volume will be considered to be mounted.\n ```\n \n+```{tip}",
"line": null,
"ori... | fede1c63570124149e45e1dfe2d6afb3c814ca83 | diff --git a/docs/concepts/flow/basics.md b/docs/concepts/flow/basics.md
index 47ab296ffbba3..bccabbf1fb8e5 100644
--- a/docs/concepts/flow/basics.md
+++ b/docs/concepts/flow/basics.md
@@ -18,6 +18,13 @@ f = Flow()
```
````
+```{important}
+All arguments received by {class}`~jina.Flow()` API will be propagated to o... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "Documentation Updates"
} | |
jina-ai__serve-5461@6a1dc34 | jina-ai/serve | Python | 5,461 | feat: add hot reload option to Executor for development | <!---Decomposing the complex issue into subtasks can help you build it step-by-step. Thanks for your pull request! :rocket: --->
<!---We know that dev life is hectic, but **please provide a (brief) description** of what your PR does, and how it does it. **Otherwise, your PR cannot be reviewed!** --->
<!---This policy... | 2022-11-28T12:14:39Z | Hot reload for API endpoints
**Describe the feature**
When editing code while running in a local development environment, something like an inotifywait watcher either kills the existing executor or sends a message to the executor to hotpatch the server. This makes development much easier, and the latter method does no... | Hello @AmericanPresidentJimmyCarter , thanks for this feature request.
Let me clarify what it can be expected and some doubts I have:
Would you expect something like this experience (APPROXIMATE):
```python
from jina import Flow
with Flow().add(uses=some_executor, reload=True) as f:
f.block()
```
... | [
{
"body": "**Describe the feature**\r\nWhen editing code while running in a local development environment, something like an inotifywait watcher either kills the existing executor or sends a message to the executor to hotpatch the server. This makes development much easier, and the latter method does not requir... | 0e34e4ecafc677d05480701911d33738f9349080 | {
"head_commit": "6a1dc348c8b3271fc92dd7a621eccc931781ba19",
"head_commit_message": "docs: add documentation about reload feature",
"patch_to_review": "diff --git a/docs/fundamentals/executor/executor-files.md b/docs/fundamentals/executor/executor-files.md\nindex 833527d5e9b62..7b07f2cca3ebe 100644\n--- a/docs/fu... | [
{
"diff_hunk": "@@ -29,6 +29,7 @@\n | `timeout_ready` | The timeout in milliseconds of a Pod waits for the runtime to be ready, -1 for waiting forever | `number` | `600000` |\n | `env` | The map of environment variables that are available inside runtime | `object` | `None` |\n | `floating` | If set, the current... | 589009ceb444da9602165e14d2951900bf95bf2d | diff --git a/docs/fundamentals/executor/executor-files.md b/docs/fundamentals/executor/executor-files.md
index 833527d5e9b62..7b07f2cca3ebe 100644
--- a/docs/fundamentals/executor/executor-files.md
+++ b/docs/fundamentals/executor/executor-files.md
@@ -18,8 +18,6 @@ py_modules:
## Multiple Python files + YAML
-
-
... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
jina-ai__serve-5564@9f7381d | jina-ai/serve | Python | 5,564 | feat: add beta support to scale Stateful Executors with consensus using RAFT | **Goals:**
Provide a PoC of how StatefulExecutors could handle with consensus
Implementation:
- [x] Handle raftadmin add voters from jina orchestrate
- [x] Handle terminate signals on the raft node
- [x] SIGTERM Shutdown handling
- [x] Logger in raft naming editing (if they merge and release)
- [x] Check the... | 2023-01-02T11:55:42Z | In Local, same request is not guaranteed to try every replica when retries= -1
When the retry happens in the ConnectionPool, the ReplicaList asynchornously gets next connections, but this may imply that for same request, the same replica is tried more than once even in case of failure. | @jina-ai/product This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 14 days | [
{
"body": "When the retry happens in the ConnectionPool, the ReplicaList asynchornously gets next connections, but this may imply that for same request, the same replica is tried more than once even in case of failure.",
"number": 5601,
"title": "In Local, same request is not guaranteed to try every rep... | 87fa2db67c25d2ce1100a4348af93163aca48a95 | {
"head_commit": "9f7381d0381afa3af8db4f2b0b07478a720b81f6",
"head_commit_message": "docs: add numbers of QPS in example\n\nSigned-off-by: Joan Fontanals Martinez <joan.martinez@jina.ai>",
"patch_to_review": "diff --git a/.github/workflows/cd.yml b/.github/workflows/cd.yml\nindex 21b2cd51ccf67..21e3ee7ccae5f 1006... | [
{
"diff_hunk": "@@ -183,3 +183,33 @@ structure.\n ```{tip}\n In the `jina hub new` wizard you can choose from four Dockerfile templates: `cpu`, `tf-gpu`, `torch-gpu`, and `jax-gpu`.\n ```\n+\n+## Stateful-Executor (Beta)\n+\n+Executors sometimes may contain some internal state which changes when some of their m... | e10211cd4dc171484116ca4203e75886d09233e3 | diff --git a/.github/workflows/cd.yml b/.github/workflows/cd.yml
index 93d0922983211..24fd041f1bbf1 100644
--- a/.github/workflows/cd.yml
+++ b/.github/workflows/cd.yml
@@ -70,16 +70,6 @@ jobs:
git pull && git add . && git commit -m "update ${{env.JINA_VERSION}} due to ${{github.event_name}} on ${{github.r... | {
"difficulty": "high",
"estimated_review_effort": 5,
"problem_domain": "Bug Fixes"
} |
jina-ai__serve-5457@04c1707 | jina-ai/serve | Python | 5,457 | feat: add FastAPIBaseGateway | Create a FastAPIBaseGateway where the user just needs to implement a fast API app.
All the rest (setting up, running and shutting down the server) is automatically handled
Also make sure the HTTPGateway inherits from it instead of the BaseGateway
closes: https://github.com/jina-ai/jina/issues/5454 | 2022-11-25T14:42:13Z | create FastAPIBaseGateway
Create a FastAPIBaseGateway where the user just needs to implement a fast API app.
All the rest (setting up, running and shutting down the server) is automatically handled
Also make sure the HTTPGateway inherits from it instead of the BaseGateway | [
{
"body": "Create a FastAPIBaseGateway where the user just needs to implement a fast API app.\r\nAll the rest (setting up, running and shutting down the server) is automatically handled\r\n\r\nAlso make sure the HTTPGateway inherits from it instead of the BaseGateway",
"number": 5454,
"title": "create F... | 23a625d122fae317db4ff5711bfd48a56a8d2e0c | {
"head_commit": "04c1707f977c9885486ac4cc6fb70a683c234fd9",
"head_commit_message": "test: fix fastapi gateway test",
"patch_to_review": "diff --git a/jina/serve/runtimes/gateway/http/fastapi.py b/jina/serve/runtimes/gateway/http/fastapi.py\nnew file mode 100644\nindex 0000000000000..67ef20261232f\n--- /dev/null\... | [
{
"diff_hunk": "@@ -0,0 +1,115 @@\n+import logging\n+import os\n+from abc import abstractmethod\n+from typing import Optional\n+\n+from jina.importer import ImportExtensions\n+from jina.serve.gateway import BaseGateway\n+\n+\n+class FastAPIBaseGateway(BaseGateway):\n+ \"\"\"HTTP Gateway implementation\"\"\"\... | 2d1a041feb314b003ed2177c600d63046a017183 | diff --git a/jina/serve/runtimes/gateway/http/fastapi.py b/jina/serve/runtimes/gateway/http/fastapi.py
new file mode 100644
index 0000000000000..86fd5a21f2156
--- /dev/null
+++ b/jina/serve/runtimes/gateway/http/fastapi.py
@@ -0,0 +1,113 @@
+import logging
+import os
+from abc import abstractmethod
+from typing import ... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
jina-ai__serve-5380@0f7c344 | jina-ai/serve | Python | 5,380 | fix: fix bug inheritance, requests nested dict | **Goals:**
Makes `requests` Executor class method a nested dict including the class name to support inheritance
| 2022-11-11T10:52:55Z | bug: wrong inherited Executor called
At Jina now, we are using the inheritance of executors since it allows us to constrain certain behavior on a group of executors.
For instance, we have a BaseIndexer that makes sure all derived indexers like Qdrant/Elastic have the same interface. And if we change the interface, all... | Can u try without having one of them called `BaseExecutor`? Since this is a special class in our Jina inheritance tree I want to make sure that it is just a very bad coincidence. Does it also happen with `ExecutorBase`and `ExecutorInherited`?
also, can u run here?
```python
exec = Executor.load_executor(ExecutorInh... | [
{
"body": "At Jina now, we are using the inheritance of executors since it allows us to constrain certain behavior on a group of executors.\r\nFor instance, we have a BaseIndexer that makes sure all derived indexers like Qdrant/Elastic have the same interface. And if we change the interface, all Indexers are up... | 33719192e6ea3a21395ccbe7de9d84a521763db1 | {
"head_commit": "0f7c3443075e37202b881ec6d345b7ffbbed0d4c",
"head_commit_message": "test: add regression test",
"patch_to_review": "diff --git a/jina/serve/executors/__init__.py b/jina/serve/executors/__init__.py\nindex 51adfbd795c0b..b1a8d94802f17 100644\n--- a/jina/serve/executors/__init__.py\n+++ b/jina/serve... | [
{
"diff_hunk": "@@ -214,9 +214,20 @@ def _init_instrumentation(self, _runtime_args: Optional[Dict] = None):\n self.meter_provider = None\n self.meter = None\n \n+ @property\n+ def requests(self):\n+ \"\"\"\n+ Get the request dictionary corresponding to this specific c... | 33e264c067a22f70d9bc0cf05955c45d78029d87 | diff --git a/jina/serve/executors/__init__.py b/jina/serve/executors/__init__.py
index 51adfbd795c0b..b0019612d2f1a 100644
--- a/jina/serve/executors/__init__.py
+++ b/jina/serve/executors/__init__.py
@@ -3,6 +3,7 @@
import multiprocessing
import os
import threading
+import copy
import warnings
from types import S... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
jina-ai__serve-5391@42dd038 | jina-ai/serve | Python | 5,391 | fix: use start_as_current_span to maintain tracing operation chain | **Goals:**
<!---https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword--->
- resolves #5386
- the python SDK for whatever reason doesn't consider the span started from the origin request context as the direct child spa... | 2022-11-14T10:50:23Z | bug: worker runtime request handler span appears out of order
**Describe the bug**
<!-- A clear and concise description of what the bug is. -->
The worker runtime request handler starts the span to record the executor request using `trace.start_as_span` which doesn't sequence the span correctly if the executor reques... | [
{
"body": "**Describe the bug**\r\n<!-- A clear and concise description of what the bug is. -->\r\nThe worker runtime request handler starts the span to record the executor request using `trace.start_as_span` which doesn't sequence the span correctly if the executor requests method creates another span using th... | f738d34bfc75437c7203f5746cc602145088d220 | {
"head_commit": "42dd038440be04b160d8490bbdf0ec4406655f22",
"head_commit_message": "style: fix overload and cli autocomplete",
"patch_to_review": "diff --git a/jina/serve/executors/__init__.py b/jina/serve/executors/__init__.py\nindex b0019612d2f1a..d3eaf50257789 100644\n--- a/jina/serve/executors/__init__.py\n+... | [
{
"diff_hunk": "@@ -379,7 +382,9 @@ async def exec_func(\n }\n \n if self.tracer:\n- with self.tracer.start_span(req_endpoint, context=tracing_context) as _:\n+ with self.tracer.start_as_current_span(\n+ req_endpoint, context=tracing_context\n+ ) a... | 66fd73883a10efb052b8adbea0c0d43e421c5c06 | diff --git a/jina/serve/executors/__init__.py b/jina/serve/executors/__init__.py
index b0019612d2f1a..f522cbb0510c8 100644
--- a/jina/serve/executors/__init__.py
+++ b/jina/serve/executors/__init__.py
@@ -1,9 +1,9 @@
import contextlib
+import copy
import inspect
import multiprocessing
import os
import threading
-i... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
jina-ai__serve-5366@930881d | jina-ai/serve | Python | 5,366 | feat: pass `docs_map` to Executor | **Goals:**
Pass `docs_map` to `Executor` as a dictionary with keys as the `last Executors` that processed a Request, and values as the `DocumentArray` in that specific Request.
| 2022-11-08T16:46:41Z | Enforce deterministic results order on 'needs' in topology graph
When making requests to pods running in parallel, the topology graph should await all tasks together to have a deterministic ordering (similar to asyncio.gather in the head runtime)
feat: find out which docs are which in docs_matrix
When pairing with @vi... | @jina-ai/product This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 14 days
You could have the `disable_reduce` flag and have a `... | [
{
"body": "When making requests to pods running in parallel, the topology graph should await all tasks together to have a deterministic ordering (similar to asyncio.gather in the head runtime)",
"number": 4084,
"title": "Enforce deterministic results order on 'needs' in topology graph"
},
{
"bod... | 8d8b4675f07bf018a14cc6599b1ffd41ab7454ed | {
"head_commit": "930881df4ca1d60b5c94fe92d4dbdd64d652df30",
"head_commit_message": "style: fix overload and cli autocomplete",
"patch_to_review": "diff --git a/docs/fundamentals/executor/executor-methods.md b/docs/fundamentals/executor/executor-methods.md\nindex b321b697915a2..7fc5012589ba4 100644\n--- a/docs/fu... | [
{
"diff_hunk": "@@ -290,6 +292,35 @@ def status(self):\n \"\"\"\n return self.proto_wo_data.header.status\n \n+ @property\n+ def last_executor(self):\n+ \"\"\"\n+ Returns the name of the last Executor that has processed this Request\n+\n+ :return: the name of the last ... | e1eec5291d703d52f3e390ac4b4396d0d1c37e84 | diff --git a/docs/fundamentals/executor/executor-methods.md b/docs/fundamentals/executor/executor-methods.md
index b321b697915a2..58f380bdae32b 100644
--- a/docs/fundamentals/executor/executor-methods.md
+++ b/docs/fundamentals/executor/executor-methods.md
@@ -50,11 +50,14 @@ with f:
```
```shell
- Flow@1... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
jina-ai__serve-5464@32b4661 | jina-ai/serve | Python | 5,464 | fix: list-like args passed as string | <!---Decomposing the complex issue into subtasks can help you build it step-by-step. Thanks for your pull request! :rocket: --->
<!---We know that dev life is hectic, but **please provide a (brief) description** of what your PR does, and how it does it. **Otherwise, your PR cannot be reviewed!** --->
<!---This policy... | 2022-11-29T14:03:25Z | bug: list-like args passed as string
**Describe the bug**
Right now in order to have `port-monitoring` (AND OTHER PARAMETERS) support `str` and `List[str]` at the same time, we have to do a hack to pass a string with "," comma separated values.
This feels unnatural in the CLI and Python API.
We should be able t... | [
{
"body": "**Describe the bug**\r\nRight now in order to have `port-monitoring` (AND OTHER PARAMETERS) support `str` and `List[str]` at the same time, we have to do a hack to pass a string with \",\" comma separated values. \r\n\r\nThis feels unnatural in the CLI and Python API.\r\n\r\nWe should be able to pass... | a5b9df58edac2e8c59ad25c9b13ef1ffa75f0bec | {
"head_commit": "32b46613bc6ad7f0138c067eabd659871764c909",
"head_commit_message": "test: opentelemetry-sdk is updated to 1.15.0",
"patch_to_review": "diff --git a/docs/concepts/flow/executor-args.md b/docs/concepts/flow/executor-args.md\nindex 693eb971b7cc6..641203ff678cd 100644\n--- a/docs/concepts/flow/execut... | [
{
"diff_hunk": "@@ -824,40 +817,52 @@ def _set_pod_args(args: Namespace) -> Dict[int, List[Namespace]]:\n _args.name = f'{replica_id}'\n \n # the gateway needs to respect the assigned port\n- if args.deployment_role == DeploymentRoleType.GATEWAY or args.externa... | b32b73ee2f45ac33b298b9712ac81c8ee11ac1ab | diff --git a/docs/concepts/flow/executor-args.md b/docs/concepts/flow/executor-args.md
index 54512c8cd964f..70725283cf426 100644
--- a/docs/concepts/flow/executor-args.md
+++ b/docs/concepts/flow/executor-args.md
@@ -25,16 +25,16 @@
| `volumes` | The path on the host to be mounted inside the container. <br><br>Note, <... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
jina-ai__serve-5344@cbaa4bb | jina-ai/serve | Python | 5,344 | feat: add deployment label in grpc stub metrics | <!---Decomposing the complex issue into subtasks can help you build it step-by-step. Thanks for your pull request! :rocket: --->
<!---We know that dev life is hectic, but **please provide a (brief) description** of what your PR does, and how it does it. **Otherwise, your PR cannot be reviewed!** --->
<!---This policy... | 2022-11-03T07:44:42Z | Metrics on the gateway should always contained a label based on the Executor target
# Context
At the moment the gateway average all of its metrics and does not allow users to make distinction between different Executor.
To give an example:
Lets say we have a flow with two executors, one takes a lot of time to ... | I think then we should duplicate metrics and have `gateway` measure Executor latency regardless of anything
gotcha makes sense | [
{
"body": "# Context\r\n\r\nAt the moment the gateway average all of its metrics and does not allow users to make distinction between different Executor.\r\n\r\nTo give an example:\r\n\r\nLets say we have a flow with two executors, one takes a lot of time to process the other one take few times.\r\n\r\nAt the m... | 8b81b53897109d34278f6d407b7890c74a12e76e | {
"head_commit": "cbaa4bb4a9691240bf7e2bbe6a3f80cdf7a2fe32",
"head_commit_message": "test: add tests for gateway labels",
"patch_to_review": "diff --git a/jina/serve/networking.py b/jina/serve/networking.py\nindex 5f18a15d44762..ada96400a1a89 100644\n--- a/jina/serve/networking.py\n+++ b/jina/serve/networking.py\... | [
{
"diff_hunk": "@@ -64,19 +64,31 @@ class _NetworkingHistograms:\n send_requests_bytes_metrics: Optional['Histogram'] = None\n histogram_metric_labels: Dict[str, str] = None\n \n- def record_sending_requests_time_metrics(self, value: int):\n+ def get_labels(self, additional_labels: Optional[Dict[s... | c04fb2bc1b1c0e75570390ab6aaa557b2286b811 | diff --git a/jina/serve/networking.py b/jina/serve/networking.py
index 5f18a15d44762..93b84e77fcfa0 100644
--- a/jina/serve/networking.py
+++ b/jina/serve/networking.py
@@ -64,19 +64,31 @@ class _NetworkingHistograms:
send_requests_bytes_metrics: Optional['Histogram'] = None
histogram_metric_labels: Dict[str,... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
jina-ai__serve-5342@47e807a | jina-ai/serve | Python | 5,342 | feat: add gateway API | As part of the Custom Gateway feature, we want to avoid confusion between gateway args and flow args.
We need to separate the concerns between gateway API and Flow API where the common parameter `uses` can be specified for both independently.
However, we do not want to introduce a breaking change and aim to keep exis... | 2022-11-02T07:41:12Z | Custom Gateway: expose gateway api in flow api as a separate set of args
As part of the Custom Gateway feature, we want to avoid confusion between gateway args and flow args.
We need to separate the concerns between gateway API and Flow API where the common parameter `uses` can be specified for both independently.
Ho... | [
{
"body": "As part of the Custom Gateway feature, we want to avoid confusion between gateway args and flow args.\r\nWe need to separate the concerns between gateway API and Flow API where the common parameter `uses` can be specified for both independently.\r\nHowever, we do not want to introduce a breaking chan... | bb38842218a0678c9eee9aa9f7575c76776bc2bc | {
"head_commit": "47e807af532d4f17a61102360fefe84361f09fab",
"head_commit_message": "test: test gateway in json schema",
"patch_to_review": "diff --git a/jina/jaml/parsers/flow/v1.py b/jina/jaml/parsers/flow/v1.py\nindex 9c60d208dc5b7..3fd4531381607 100644\n--- a/jina/jaml/parsers/flow/v1.py\n+++ b/jina/jaml/pars... | [
{
"diff_hunk": "@@ -3,6 +3,8 @@\n from jina.parsers.orchestrate.runtimes.container import mixin_container_runtime_parser\n from jina.parsers.orchestrate.runtimes.head import mixin_head_parser\n \n+GATEWAY_NAME = 'gateway'",
"line": null,
"original_line": 6,
"original_start_line": null,
"path": "... | 1a761066d8f42f0e71c141836700b5a657cd3dad | diff --git a/jina/helper.py b/jina/helper.py
index 8009b7d10a26f..4da51679ce83a 100644
--- a/jina/helper.py
+++ b/jina/helper.py
@@ -67,6 +67,7 @@
]
T = TypeVar('T')
+GATEWAY_NAME = 'gateway'
def deprecated_alias(**aliases):
@@ -1456,7 +1457,7 @@ def dunder_get(_dict: Any, key: str) -> Any:
return dunder_... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
jina-ai__serve-5328@d749910 | jina-ai/serve | Python | 5,328 | refactor: remove unnecessary parser args | In some cases, some entities either have arguments with wrong default values or description, or just shouldn't be having that argument.
For instance:
* the gateway accepts `gpus` argument with ~~a description that mentions executors not the gateway~~ and it shouldn't accept it.
* the gateway accepts the output-arra... | 2022-10-28T11:30:34Z | Separate/differentiate parser args that should have different descriptions/defaults
Some args belong to multiple entities (client, flow, gateway, worker pod), have different behavior and should have different default values/descriptions.
We should either replicate those args for different entities with different descr... | [
{
"body": "Some args belong to multiple entities (client, flow, gateway, worker pod), have different behavior and should have different default values/descriptions.\r\nWe should either replicate those args for different entities with different description/defaults or parameterize parser mixins",
"number": 5... | 6a3b091db91a649590f07dcf7e867e8e691dba62 | {
"head_commit": "d74991006c7141ca70fc1053523dd0ee62bddcd5",
"head_commit_message": "style: fix overload and cli autocomplete",
"patch_to_review": "diff --git a/docs/fundamentals/flow/executor-args.md b/docs/fundamentals/flow/executor-args.md\nindex 663d4c1966a56..8d6262acea75b 100644\n--- a/docs/fundamentals/flo... | [
{
"diff_hunk": "@@ -71,4 +72,32 @@ def mixin_worker_runtime_parser(parser):\n `Executor cookbook <https://docs.jina.ai/fundamentals/executor/executor-files/>`__\n ''',\n )\n+\n+ gp.add_argument(",
"line": 76,
"original_line": 76,
"original_start_line": null,
"path": "jina/parsers/orchestr... | dc7b0fd627c5967ba2e781d36ba4eb0fa2947b16 | diff --git a/docs/fundamentals/flow/executor-args.md b/docs/fundamentals/flow/executor-args.md
index 663d4c1966a56..38bb50da17cc2 100644
--- a/docs/fundamentals/flow/executor-args.md
+++ b/docs/fundamentals/flow/executor-args.md
@@ -7,21 +7,23 @@
| `quiet_error` | If set, then exception stack information will not be a... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Code Refactoring / Architectural Improvement"
} | |
jina-ai__serve-5176@76b1bd6 | jina-ai/serve | Python | 5,176 | feat: add multiple attempts options to client.post API | Goal of this PR is to enable `retry_mechanism` in the client.
- [x] Expose `max_attempts`, `initial_backoff`, `max_backoff` and `backoff_multiplier` in the `client.post` API
- [x] Clarify usage of `continue_on_error` with any kind of Errors
- [ ] Test features
- [x] Document
**Changes**
- Allow to pass `max_a... | 2022-09-15T19:08:07Z | fix: no retries in case of network problems
Hi, can we have retries for indexing documents at the flow?
If I disconnect from the internet during indexing and then connect again after 5 seconds, the flow fails without doing retries.
This issue slows us down when making deployments.
Suggested interface:
```python... | Hey @florian-hoenicke ,
To make sure that the `indexing` continues, please use the `continue_on_error` parameter from the `client.post`. | [
{
"body": "Hi, can we have retries for indexing documents at the flow?\r\nIf I disconnect from the internet during indexing and then connect again after 5 seconds, the flow fails without doing retries.\r\nThis issue slows us down when making deployments.\r\n\r\nSuggested interface:\r\n\r\n```python\r\nf.index(i... | 13edf9080e129067a5b2eb4ef7b9092664f9847e | {
"head_commit": "76b1bd6e52556c8310b4704a89826748c0a5919e",
"head_commit_message": "fix: apply suggestions from code review\n\nCo-authored-by: Johannes Messner <44071807+JohannesMessner@users.noreply.github.com>",
"patch_to_review": "diff --git a/docs/fundamentals/client/client.md b/docs/fundamentals/client/clie... | [
{
"diff_hunk": "@@ -668,7 +663,26 @@ with Flow().add() as f, open('output.txt', 'w') as fp:\n )\n ```\n \n+````{admonition} What errors can be handled by the callback\n+:class: caution\n+Callback can handle errors that are caused by Executors raising an Exception.\n+It will not receive exceptions or from th... | 1231c39d0ec1394cbb0540587e71537603780584 | diff --git a/docs/fundamentals/client/client.md b/docs/fundamentals/client/client.md
index cc4d63bfe2163..ae200102551f4 100644
--- a/docs/fundamentals/client/client.md
+++ b/docs/fundamentals/client/client.md
@@ -479,14 +479,9 @@ For example, a `SIGKILL` from the client OS during the handling of the request,
will not ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
Subsets and Splits
Review Test Instances
Retrieves basic metadata about code review instances but doesn't provide any analytical insights or patterns beyond raw data access.