instance_id stringlengths 21 53 | repo stringclasses 188
values | language stringclasses 1
value | pull_number int64 20 148k | title stringlengths 6 144 | body stringlengths 0 83.4k | created_at stringdate 2015-09-25 03:17:17 2025-07-10 16:50:35 | problem_statement stringlengths 188 240k | hints_text stringlengths 0 145k | resolved_issues listlengths 1 6 | base_commit stringlengths 40 40 | commit_to_review dict | reference_review_comments listlengths 1 62 | merged_commit stringlengths 40 40 | merged_patch stringlengths 297 9.87M | metadata dict |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
jina-ai__serve-5221@7606326 | jina-ai/serve | Python | 5,221 | feat: add GRPC metadata to Executors and Gateway deployments | <!---Decomposing the complex issue into subtasks can help you build it step-by-step. Thanks for your pull request! :rocket: --->
<!---We know that dev life is hectic, but **please provide a (brief) description** of what your PR does, and how it does it. **Otherwise, your PR cannot be reviewed!** --->
<!---This policy... | 2022-09-28T07:35:28Z | Define authentication credential for external executors in YAML
**Describe the feature**
<!-- A clear and concise description of what the feature is. -->
When the flow is using an external executor, and its access is protected with an authentication credential (i.g,. access token). For example, the hosted free clip... | [
{
"body": "**Describe the feature**\r\n<!-- A clear and concise description of what the feature is. -->\r\n\r\nWhen the flow is using an external executor, and its access is protected with an authentication credential (i.g,. access token). For example, the hosted free clip-as-service `api.clip.jina.ai`. To acce... | 287d16a27c39e3f258897158f2274f2c7cca4df9 | {
"head_commit": "76063261e40bf5a4156042791c771246bde58ce4",
"head_commit_message": "style: fix overload and cli autocomplete",
"patch_to_review": "diff --git a/docs/fundamentals/flow/add-executors.md b/docs/fundamentals/flow/add-executors.md\nindex 4010a558dd37d..4e99deda6c258 100644\n--- a/docs/fundamentals/flo... | [
{
"diff_hunk": "@@ -37,13 +40,25 @@ def __init__(\n self.ssl_certfile = ssl_certfile\n self.health_servicer = health.HealthServicer(experimental_non_blocking=True)\n \n+ def grpc_extra_server_interceptors(self) -> Optional[List['ServerInterceptor']]:",
"line": null,
"original_line": 4... | 3e0a3d431508a456fc1642e5cae220bcfb45d768 | diff --git a/docs/fundamentals/flow/add-executors.md b/docs/fundamentals/flow/add-executors.md
index 4010a558dd37d..8967b05ecc2d5 100644
--- a/docs/fundamentals/flow/add-executors.md
+++ b/docs/fundamentals/flow/add-executors.md
@@ -128,6 +128,24 @@ Using `tls` to connect to the External Executor is especially needed t... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
jina-ai__serve-5315@343f437 | jina-ai/serve | Python | 5,315 | docs: create a kubernetes section | # Context
based on this issue : https://github.com/jina-ai/jina/issues/5243
This PR revamp the k8s documentation to make k8s more prominent | 2022-10-26T12:24:42Z | docs: make Kubernetes more prominent
Currently everything about Kubernetes is contained in one single how-to article.
"Deploy on Kubernetes" should become its own section on the same level as "Flow" and "Hub" etc. for the following reasons:
- It sends a signal that we are cloud native. Right now our kubernetes stuf... | [
{
"body": "Currently everything about Kubernetes is contained in one single how-to article.\r\n\r\n\"Deploy on Kubernetes\" should become its own section on the same level as \"Flow\" and \"Hub\" etc. for the following reasons:\r\n- It sends a signal that we are cloud native. Right now our kubernetes stuff is h... | 40637bee0bd2c13924dd15614d73197c0acdb8f2 | {
"head_commit": "343f43796bdd787283621d18d30f71a262a4a343",
"head_commit_message": "docs: small fix",
"patch_to_review": "diff --git a/docs/fundamentals/executor/executor-serve.md b/docs/fundamentals/executor/executor-serve.md\nindex 39cf99fca4185..3b42a3c5571d5 100644\n--- a/docs/fundamentals/executor/executor-... | [
{
"diff_hunk": "@@ -0,0 +1,159 @@\n+(kubernetes-docs)=\n+# Kubernetes Support\n+\n+Jina is a cloud native framework and therefore run natively and easily on Kubernetes.\n+Deploying a Jina Flow on Kubernetes is actually the recommended way to use Jina in production.\n+\n+\n+A {class}`~jina.Flow` is composed of d... | c8efb63c7f7bfe71dc788580fd681edd60f8f208 | diff --git a/docs/fundamentals/executor/executor-serve.md b/docs/fundamentals/executor/executor-serve.md
index 39cf99fca4185..3b42a3c5571d5 100644
--- a/docs/fundamentals/executor/executor-serve.md
+++ b/docs/fundamentals/executor/executor-serve.md
@@ -72,6 +72,7 @@ the Executor, and `**kwargs` is passed to the interna... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Documentation Updates"
} | |
jina-ai__serve-4961@99cbe9d | jina-ai/serve | Python | 4,961 | feat: allow to pass a list of port monitoring to replicas | # Context:
Right now it is difficult to use the monitoring feature with replicas/shards because it is impossible to gave a list of port to the Deployment. The current behavior is to randomly assign the port when there is a replicas. It is actually the same behavior as for the normal port. But since the `port_monitor... | 2022-06-24T15:05:14Z | Monitoring: port issue when using shards and replicas locally
There is an port conflict when using shards and replicas
```python
from jina import Flow
from docarray import Document, DocumentArray
with Flow(monitoring=True).add(
name='hello', port_monitoring=9090, replicas=2, shards=2
) as f:
# f.in... | [
{
"body": "There is an port conflict when using shards and replicas\r\n\r\n\r\n```python\r\nfrom jina import Flow\r\nfrom docarray import Document, DocumentArray\r\n\r\nwith Flow(monitoring=True).add(\r\n name='hello', port_monitoring=9090, replicas=2, shards=2\r\n) as f:\r\n # f.index(inputs=DocumentArra... | 2a2f57d6e0bd8c8eb05ffcd9e5065bc592f94eb9 | {
"head_commit": "99cbe9d5adcb5e2a12b73236b769eba6b6239ea6",
"head_commit_message": "refactor: raname port to port monitoring and parser args",
"patch_to_review": "diff --git a/docs/fundamentals/flow/monitoring-flow.md b/docs/fundamentals/flow/monitoring-flow.md\nindex ee72a229bb90f..00a544dde4df6 100644\n--- a/d... | [
{
"diff_hunk": "@@ -1618,3 +1618,30 @@ def is_port_free(host, port):\n return False\n else:\n return True\n+\n+\n+def _parse_port(port: str) -> Union[int, List]:",
"line": null,
"original_line": 1623,
"original_start_line": null,
"path": "jina/helper.py",
"sta... | f8cad92498cf837978af39f00b650464ee99c420 | diff --git a/docs/fundamentals/flow/monitoring-flow.md b/docs/fundamentals/flow/monitoring-flow.md
index ee72a229bb90f..4dd4a085e012c 100644
--- a/docs/fundamentals/flow/monitoring-flow.md
+++ b/docs/fundamentals/flow/monitoring-flow.md
@@ -91,6 +91,56 @@ On the other hand, If you want to only enable the monitoring on ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
jina-ai__serve-5217@28d5bd8 | jina-ai/serve | Python | 5,217 | feat: distributed replicas across different hosts | ## Goal
Allow replicas of the same Executor to run in a distributed manner (on different machines).
Closes #5103
Closes #5231
## Usage
```python
f.add(host='localhost,91.198.174.192', port='12345,12346', external=True)
```
Alternatively:
```python
f.add(host='localhost:12345,91.198.174.192:12346', exte... | 2022-09-27T13:53:40Z | How can I serve replicas of an executor in different hosts?
First, I thank Jina for an easy deployment/scaling framework. In my scenario, I have independent physical instance GPU resources, so is there any way to host replicas of an executor type in a different place? For example, is a `external replica` exist? Or sup... | oh, @JoanFM @samsja @JohannesMessner remember what I told you 2 months ago in the office? The load balancer idea 😉
let's do it,let's do it,let's do it, i feel excited 😆
Hey @nhtlongcs,
This is not possible right now. This solution for now is delivered via Kubernetes where K8s would schedule different Pods in ... | [
{
"body": "First, I thank Jina for an easy deployment/scaling framework. In my scenario, I have independent physical instance GPU resources, so is there any way to host replicas of an executor type in a different place? For example, is a `external replica` exist? Or suppose I have to do that manually. In that c... | 1a0e06b48a7afffdde32830b31d05c9af35bc679 | {
"head_commit": "28d5bd801d4df87830555aaa92d0a4819827b1fc",
"head_commit_message": "test: add test for externial replicas in container",
"patch_to_review": "diff --git a/docs/fundamentals/flow/executor-args.md b/docs/fundamentals/flow/executor-args.md\nindex 9502cf34d82d0..76e33a6a2c872 100644\n--- a/docs/fundam... | [
{
"diff_hunk": "@@ -339,5 +381,46 @@ def foo(self, docs, **kwargs):\n with f:\n response = f.post(on='/', inputs=d, target_executor='external_executor')\n \n-\n assert response[0].text == 'external'\n+\n+\n+@pytest.mark.parametrize('hosts', ['localhost,localhost', 'localhost'])",
"li... | 4384ce1824586b19ea3567f2c31d9fbc2d5e77f7 | diff --git a/docs/fundamentals/executor/executor-serve.md b/docs/fundamentals/executor/executor-serve.md
index 17920c55832fd..2689606409bef 100644
--- a/docs/fundamentals/executor/executor-serve.md
+++ b/docs/fundamentals/executor/executor-serve.md
@@ -9,6 +9,24 @@ There are different options for deploying and running ... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
jina-ai__serve-4918@c6f5769 | jina-ai/serve | Python | 4,918 | feat: allow Executors as dataclass | Goals:
- ...
- ...
- [ ] check and update documentation. See [guide](https://github.com/jina-ai/jina/CONTRIBUTING.md#documentation-guidelines) and ask the team.
| 2022-06-13T08:47:58Z | Support Executor dataclass besides classic init
The way of writing this is getting old:
```python
class GLID3Diffusion(Executor):
def __init__(self, glid3_path: str, steps: int, **kwargs):
super().__init__(**kwargs)
self.glid3_path = glid3_path
self.diffusion_steps = steps
```
We... | [
{
"body": "The way of writing this is getting old:\r\n\r\n```python\r\nclass GLID3Diffusion(Executor):\r\n def __init__(self, glid3_path: str, steps: int, **kwargs):\r\n super().__init__(**kwargs)\r\n self.glid3_path = glid3_path\r\n self.diffusion_steps = steps\r\n```\r\n\r\nWe need to ... | d86f8add2d900ae16d9bca74701c9d1a9ac3711d | {
"head_commit": "c6f5769d5f321c5d19e78612cc0e2044d7c26ac4",
"head_commit_message": "test: add integration test",
"patch_to_review": "diff --git a/jina/jaml/parsers/executor/legacy.py b/jina/jaml/parsers/executor/legacy.py\nindex 67145fc342a50..639217849ef42 100644\n--- a/jina/jaml/parsers/executor/legacy.py\n+++... | [
{
"diff_hunk": "@@ -13,6 +14,15 @@ class MyExecutor(BaseExecutor):\n pass\n \n \n+@dataclasses.dataclass()",
"line": null,
"original_line": 17,
"original_start_line": null,
"path": "tests/unit/jaml/test_type_parse.py",
"start_line": null,
"text": "@author:\n```suggestion\r\n@user1.da... | 3db002cb819c9ff31effa491691238fc81af1958 | diff --git a/docs/fundamentals/executor/executor-api.md b/docs/fundamentals/executor/executor-api.md
index 455b3f8b6ad7a..73ef95e74a2d1 100644
--- a/docs/fundamentals/executor/executor-api.md
+++ b/docs/fundamentals/executor/executor-api.md
@@ -11,7 +11,7 @@ Executor uses `docarray.DocumentArray` as input and output da... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Code Refactoring / Architectural Improvement"
} | |
jina-ai__serve-5410@5fe5931 | jina-ai/serve | Python | 5,410 | feat: dynamic batching | allow dynamic batching for executors. Feature described in detail [here](https://github.com/jina-ai/jina/issues/5033).
## Dynamic Batching Constraints
- len(input) == len(output)
- merge must reduce docs (no docs_matrix)
- no dictionary return allowed
## To Do
- [x] create the decorator
- [x] make overrida... | 2022-11-18T13:06:18Z | Allow dynamic batching in Executor
**Describe the feature**
We have seen that the simple `Request-Response` model with a static `request_size` is limiting in some cases. For instance some `Encoders` would rather accumulate `requests` until a big `enough` batch is accumulated and then all encoded at once. This could be... | @JoanFM @JohannesMessner hey!
I am very interested in this feature. Can you tell, what is the progress here?
Also, can you add `timeout` parameter for `@dynamic_batch` which tells Executer to process all pending requests if some of them is older than `timeout` and their amount lower than `batch_size`?
I am currentl... | [
{
"body": "**Describe the feature**\r\nWe have seen that the simple `Request-Response` model with a static `request_size` is limiting in some cases. For instance some `Encoders` would rather accumulate `requests` until a big `enough` batch is accumulated and then all encoded at once. This could be used to impro... | fd37a092b3294c92ff4943e3bd135d396bc0cd52 | {
"head_commit": "5fe5931692057a332e88136892502a226c46c6a1",
"head_commit_message": "test: create folder for batching tests\n\nSigned-off-by: Johannes Messner <messnerjo@gmail.com>",
"patch_to_review": "diff --git a/docs/fundamentals/flow/executor-args.md b/docs/fundamentals/flow/executor-args.md\nindex a2ec046e0... | [
{
"diff_hunk": "@@ -0,0 +1,172 @@\n+import asyncio\n+from asyncio import Event, Task\n+from typing import Any, Dict, List, Optional\n+\n+from jina import DocumentArray\n+from jina.serve.executors import BaseExecutor\n+from jina.types.request.data import DataRequest\n+\n+\n+async def sleep_then_set(time_seconds:... | a12a684389a075ded82ea31927d4280638d49929 | diff --git a/docs/concepts/client/send-parameters.md b/docs/concepts/client/send-parameters.md
index 0cd3ac0583de1..094d8fa62f3d3 100644
--- a/docs/concepts/client/send-parameters.md
+++ b/docs/concepts/client/send-parameters.md
@@ -1,3 +1,4 @@
+(client-executor-parameters)=
# Send Parameters
The {class}`~jina.Clie... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
jina-ai__serve-5407@89d9645 | jina-ai/serve | Python | 5,407 | feat: add startupProbe and replace readiness probe with liveness probe | <!---Decomposing the complex issue into subtasks can help you build it step-by-step. Thanks for your pull request! :rocket: --->
<!---We know that dev life is hectic, but **please provide a (brief) description** of what your PR does, and how it does it. **Otherwise, your PR cannot be reviewed!** --->
<!---This policy... | 2022-11-17T15:33:55Z | feat: add start up probe and replace readiness probe with liveness probe
**Describe the feature**
<!-- A clear and concise description of what the feature is. -->
Start up probe is better at handling the initial start up conditions of the application rather than increasing the `initialDelaySeconds` of the liveness or... | [
{
"body": "**Describe the feature**\r\n<!-- A clear and concise description of what the feature is. -->\r\nStart up probe is better at handling the initial start up conditions of the application rather than increasing the `initialDelaySeconds` of the liveness or readiness probe.\r\n\r\n**Your proposal**\r\n<!--... | fbac88557a9082ea6f07870510726e1cb5c11b72 | {
"head_commit": "89d96453d0136eb0b231ad3f03530473c113ed55",
"head_commit_message": "test: add test with slow process\n\nSigned-off-by: Joan Fontanals Martinez <joan.martinez@jina.ai>",
"patch_to_review": "diff --git a/.github/workflows/cd.yml b/.github/workflows/cd.yml\nindex f8171b42a200e..01a6f02928e70 100644\... | [
{
"diff_hunk": "@@ -32,7 +33,7 @@ def __init__(\n :param args: args from CLI\n :param kwargs: keyword args\n \"\"\"\n- self._health_servicer = health.aio.HealthServicer()\n+ self._health_servicer = health.HealthServicer(experimental_thread_pool=ThreadPoolExecutor(1))",
... | b2437d8bfc02dbb5d0240c940f8b7ec1dee46351 | diff --git a/jina/checker.py b/jina/checker.py
index 7a396b1af8b74..de3d5caadaef6 100644
--- a/jina/checker.py
+++ b/jina/checker.py
@@ -31,15 +31,15 @@ def __init__(self, args: 'argparse.Namespace'):
) as tc:
if args.target == 'executor':
hostname, port, p... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
jina-ai__serve-4892@0dad2e0 | jina-ai/serve | Python | 4,892 | feat: custom monitoring with context manager | # Custom monitoring with context manager
## Context
having only the possibility to monitor custom part of Executor with a decorator is a limitation. We need to have a context manager as well. See full issue here : https://github.com/jina-ai/jina/issues/4876
## What this PR do
This pr allow developer of Execut... | 2022-06-07T13:34:35Z | Make the monitor decorator a context manager as well
If you always force user to create new functions, how do you do this
```python
def foo():
shared_var
some_code_block_to_measure1
more_shared_var
some_code_block_to_measure2
more_shared_var
some_code_block_to_measure3
```
adding decorator t... | [
{
"body": "If you always force user to create new functions, how do you do this\r\n```python\r\ndef foo():\r\n shared_var\r\n some_code_block_to_measure1\r\n more_shared_var\r\n some_code_block_to_measure2\r\n more_shared_var\r\n some_code_block_to_measure3\r\n```\r\nadding decorator to the three bl... | d9d2dd31adeee4046ceca72328c34427ccef1093 | {
"head_commit": "0dad2e08f1370bd309fe9e94999ec7f8aac41431",
"head_commit_message": "fix(docs): update example",
"patch_to_review": "diff --git a/docs/fundamentals/executor/monitoring-executor.md b/docs/fundamentals/executor/monitoring-executor.md\nindex d3524206c713b..5360f26408f88 100644\n--- a/docs/fundamental... | [
{
"diff_hunk": "@@ -59,3 +59,41 @@ def proces_2(self, docs):\n f'jina_proces_2_seconds_count{{runtime_name=\"executor0/rep-0\"}} 1.0'\n in str(resp.content)\n )\n+\n+\n+def test_context_manager_interface(port_generator):\n+ class DummyExecutor(Executor):\n+ @requests(on... | ee58457cb1d5caa9d48c9cb594a98ddb9adcfa71 | diff --git a/docs/fundamentals/executor/monitoring-executor.md b/docs/fundamentals/executor/monitoring-executor.md
index d3524206c713b..5360f26408f88 100644
--- a/docs/fundamentals/executor/monitoring-executor.md
+++ b/docs/fundamentals/executor/monitoring-executor.md
@@ -41,13 +41,17 @@ Adding the custom monitoring on... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Code Refactoring / Architectural Improvement"
} | |
jina-ai__serve-4824@4ad72ec | jina-ai/serve | Python | 4,824 | feat: expose flow readiness check in gateway | This PR aims to expose a `health` endpoint to the gateway that works as a dry_run to expose to the client a way to know if the Flow is ready to receive requests.
It is important to differentiate this `health` endpoint with the `healthiness check` of an individual runtime.
Maybe the name `health` or `health_check... | 2022-05-24T09:06:06Z | add jina health check to jina ping
We want user to be able to use the jina health checks as now it is only a internal tools.
- [ ] document the jina health checks
- [ ] merge jina health check and jina ping (see further)
How to do health check from client?
`client.check?/.ping?`
Healthcheck endpoints for server.
... | @samsja What is this issue? I assume I cannot join slack, but I would be interested in familiarizing myself with these issues as I'm considering contributing here.
Hey, we are glad that you want to contribute ! You can definitely work on this issue if you want to
To give you some context:
We recently added some h... | [
{
"body": "We want user to be able to use the jina health checks as now it is only a internal tools.\r\n\r\n- [ ] document the jina health checks\r\n- [ ] merge jina health check and jina ping (see further)",
"number": 4544,
"title": "add jina health check to jina ping"
},
{
"body": "`client.che... | 2aad728ed9df16c0c4cfc86f49d268993ddf846d | {
"head_commit": "4ad72ecab49526ac732d480f564f4a7a9f342c5f",
"head_commit_message": "docs: add health check documentation (#4848)",
"patch_to_review": "diff --git a/docs/fundamentals/flow/index.md b/docs/fundamentals/flow/index.md\nindex 9a5c55257af8f..0609cb5accca1 100644\n--- a/docs/fundamentals/flow/index.md\n... | [
{
"diff_hunk": "@@ -0,0 +1,238 @@\n+(health-check-executor)=\n+# Health check of an Executor\n+\n+Executors run as microservices exposing `grpc` endpoints. To give information to the outside world about their health and their readiness to receive requests,\n+Executors expose a [grpc health check](https://github... | d880fe40512cd84781a19abcf44311979554948e | diff --git a/docs/fundamentals/flow/index.md b/docs/fundamentals/flow/index.md
index 9a5c55257af8f..0609cb5accca1 100644
--- a/docs/fundamentals/flow/index.md
+++ b/docs/fundamentals/flow/index.md
@@ -22,6 +22,7 @@ The most important methods of the `Flow` object are the following:
| `.block()` ... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
jina-ai__serve-4855@51c7fb1 | jina-ai/serve | Python | 4,855 | fix: client default port | # context:
Currently the port for the client is selected randomly the same way we do for the gateway. It does not makes sense.
https://github.com/jina-ai/jina/issues/4852
# What this pr do
The default port will be 80 unless tls is enable and then 443 should be the default.
| 2022-06-01T10:09:15Z | Client port should not be random
Currently the port for the client is selected randomly the same way we do for the gateway. It does not makes sense.
The default port should be 80 unless tls is enable and then 443 should be the default. | [
{
"body": "Currently the port for the client is selected randomly the same way we do for the gateway. It does not makes sense.\r\n\r\nThe default port should be 80 unless tls is enable and then 443 should be the default.",
"number": 4852,
"title": "Client port should not be random"
}
] | 3bf1c8663a56df1b47b97ba8dc94448d1b42bb6d | {
"head_commit": "51c7fb165425ac3ea3ec23f26aacd6df1e142b17",
"head_commit_message": "fix: remove random port",
"patch_to_review": "diff --git a/jina/clients/__init__.py b/jina/clients/__init__.py\nindex 2035f2b8e465b..78abae26c5422 100644\n--- a/jina/clients/__init__.py\n+++ b/jina/clients/__init__.py\n@@ -2,7 +2... | [
{
"diff_hunk": "@@ -105,3 +107,81 @@ def on_error_wrap(resp):\n on_error(resp, exception)\n \n _safe_callback(on_error_wrap, False, logger)(response)\n+\n+\n+def parse_client(kwargs) -> Namespace:\n+ \"\"\"\n+ Parse the kwargs for the Client\n+\n+ :param kwargs: kwargs to be parsed\n+\n+ ... | 6e089327d98cff63bb38462fdcc5422f95105703 | diff --git a/jina/helper.py b/jina/helper.py
index f8dfa50eccc08..9b876067c9afd 100644
--- a/jina/helper.py
+++ b/jina/helper.py
@@ -1527,13 +1527,30 @@ def get_rich_console():
from jina.parsers import set_client_cli_parser
+__default_port_client__ = 80
+__default_port_tls_client__ = 443
-def parse_client(kwargs... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
jina-ai__serve-4842@d0db2eb | jina-ai/serve | Python | 4,842 | docs: document behaviour when things go wrong and redo k8s howto | **ToDO**
- [x] document error handling behaviour. See here: https://docs-failures--jina-docs.netlify.app/fundamentals/flow/when-things-go-wrong/
- [x] polish k8s HowTo. See here: https://docs-failures--jina-docs.netlify.app/how-to/kubernetes/
- [x] @samsja edit the "expose flow" details | 2022-05-30T14:30:28Z | Document error handling behaviour
Explain what happens when different kinds of error occur
Docs: explain error modelling and failures
Explain how (connection) errors are handled, locally, in docker and k8s, and how errors are reported to the user.
Also explain that retrying in service mesh is potentially dangerous ... | [
{
"body": "Explain what happens when different kinds of error occur",
"number": 4802,
"title": "Document error handling behaviour"
},
{
"body": "Explain how (connection) errors are handled, locally, in docker and k8s, and how errors are reported to the user.\r\n Also explain that retrying in se... | dc8b2cfb6ea83510b15af14969b9e1b49181ee21 | {
"head_commit": "d0db2ebba1dc437b595d9b24bcd7779b558ea9ea",
"head_commit_message": "docs: add hint box about service meshes",
"patch_to_review": "diff --git a/docs/fundamentals/executor/containerize-executor.md b/docs/fundamentals/executor/containerize-executor.md\nindex b03c56358069a..14e946eef6dc3 100644\n--- ... | [
{
"diff_hunk": "@@ -1,122 +1,197 @@\n (kubernetes)=\n # How to deploy Jina on Kubernetes\n \n-Jina natively supports deploying your Flow and Executors on Kubernetes.\n+Deploying a Flow in Kubernetes is the recommended way of using Jina in production.\n \n-A `Flow` is composed of `Executors` which run Python cod... | f10f24df55ec9919d3385322f30e6af7a3ad88fa | diff --git a/docs/fundamentals/executor/containerize-executor.md b/docs/fundamentals/executor/containerize-executor.md
index b03c56358069a..14e946eef6dc3 100644
--- a/docs/fundamentals/executor/containerize-executor.md
+++ b/docs/fundamentals/executor/containerize-executor.md
@@ -1,3 +1,4 @@
+(dockerize-exec)=
# Docke... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Documentation Updates"
} | |
jina-ai__serve-4883@ca87c3e | jina-ai/serve | Python | 4,883 | feat: add argument to control number of grpc retries | This allows the user to configure the number of retries that the gateway and head perform for each grpc call.
This includes the ability to disable retries altogether, which is useful when the user wants to user a service mesh level retry mechanism instead.
**ToDos:**
- [x] Add in Gateway
- [x] Add in Head
- [x... | 2022-06-07T09:32:49Z | Allow user to disable retry mechanism
We have our own retry mechanism, which interferes with any service meshes retry mechanism (both would happen on top of each other, resulting in m*n retries, if we retry m times, and the service mesh n times).
This makes service mesh level retries not really usable.
We should al... | [
{
"body": "We have our own retry mechanism, which interferes with any service meshes retry mechanism (both would happen on top of each other, resulting in m*n retries, if we retry m times, and the service mesh n times).\r\nThis makes service mesh level retries not really usable.\r\n\r\nWe should allow the user ... | 60fdfc13451dcf2895f60a7a9742d9a4ec40a68b | {
"head_commit": "ca87c3e1ab3979709bd6513d8ec1052cadb31bd8",
"head_commit_message": "style: fix overload and cli autocomplete",
"patch_to_review": "diff --git a/cli/autocomplete.py b/cli/autocomplete.py\nindex 19b9b8fd07cd6..cb0b104dfffe8 100644\n--- a/cli/autocomplete.py\n+++ b/cli/autocomplete.py\n@@ -56,6 +56,... | [
{
"diff_hunk": "@@ -103,3 +103,11 @@ def mixin_pod_parser(parser):\n dest='port_monitoring',\n help=f'The port on which the prometheus server is exposed, default port is {__default_port_monitoring__} ',\n )\n+\n+ gp.add_argument(\n+ '--retries',\n+ type=int,\n+ defaul... | ed25f97299d4c5a8e088cd0dc097a8f5b2204c70 | diff --git a/docs/fundamentals/flow/when-things-go-wrong.md b/docs/fundamentals/flow/when-things-go-wrong.md
index fac63caf5e135..65c2ab68b01f8 100644
--- a/docs/fundamentals/flow/when-things-go-wrong.md
+++ b/docs/fundamentals/flow/when-things-go-wrong.md
@@ -25,6 +25,13 @@ When an {ref}`Executor or Head <architecture... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
jina-ai__serve-4794@8c4cf97 | jina-ai/serve | Python | 4,794 | feat: smart replica retry | Right now, when a replica fails (on local), the gateway will stubbornly retry to connect to that same replica, instead of trying its luck with one of the other replicas. This PR changes that, applying round robing scheduling also for retries, not just successful calls.
**ToDo:**
- [x] smart retry mechanism
- [x]... | 2022-05-17T11:36:18Z | Smarter retry mechanism for Executors with replicas
Currently, the round robin scheduling between replicas does not apply when retrying to send a request, but only when a new request comes in. This means that if a replica is down, the gateway stubbornly tries to connect to the this same replica, ultimately failing the ... | [
{
"body": "Currently, the round robin scheduling between replicas does not apply when retrying to send a request, but only when a new request comes in. This means that if a replica is down, the gateway stubbornly tries to connect to the this same replica, ultimately failing the request despite other replicas be... | 2b5efac1478f33134d481e8cf9fcc7b405c58515 | {
"head_commit": "8c4cf9735fd64fe2a72daa1ce73e4e033a7c7fdc",
"head_commit_message": "refactor: remove print",
"patch_to_review": "diff --git a/jina/excepts.py b/jina/excepts.py\nindex 556dd858a63f6..18cc2c5aff5fc 100644\n--- a/jina/excepts.py\n+++ b/jina/excepts.py\n@@ -1,4 +1,6 @@\n \"\"\"This modules defines al... | [
{
"diff_hunk": "@@ -310,6 +310,7 @@ def get_replicas(\n entity_id: Optional[int] = None,\n increase_access_count: bool = True,\n ) -> ReplicaList:\n+ # returns all replicas of a given deployment, using a \"random\" shard",
"line": null,
"original_line": 313,
... | 6f7e931e8f79b20ef8dfa7dad8a4943337bb17bc | diff --git a/jina/excepts.py b/jina/excepts.py
index 556dd858a63f6..18cc2c5aff5fc 100644
--- a/jina/excepts.py
+++ b/jina/excepts.py
@@ -1,4 +1,6 @@
"""This modules defines all kinds of exceptions raised in Jina."""
+from typing import Set, Union
+
import grpc.aio
@@ -84,13 +86,13 @@ def __init__(
self,
... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} | |
jina-ai__serve-4787@dee80b2 | jina-ai/serve | Python | 4,787 | fix: warn user when calling load config from flow instance | fixing https://github.com/jina-ai/jina/issues/4773
Now when doing
```python
from jina import Flow
Flow().load_config('config.yaml')
```
you got this warning
```
UserWarning: Calling load_config from a Flow instance will override all of its initial parameters. You should probably use `Flow.load_confi... | 2022-05-16T08:52:55Z | It shoud not be possible to pass argument to the Flow init function when loading from a yaml file
It shoud not be possible to pass argument to the Flow init function when loading from a yaml file
```python
from jina import Flow
f = Flow(port=8080).load_config('config.yaml')
```
Here port=8080 could be override... | [
{
"body": "It shoud not be possible to pass argument to the Flow init function when loading from a yaml file\r\n\r\n```python\r\nfrom jina import Flow\r\nf = Flow(port=8080).load_config('config.yaml')\r\n```\r\n\r\nHere port=8080 could be override because load config will override everything.\r\n\r\nload config... | ec923d028282d7994069447fe509fafc235c3268 | {
"head_commit": "dee80b2454314901673f204d93734aa798c14a1f",
"head_commit_message": "fix: fix typo",
"patch_to_review": "diff --git a/jina/orchestrate/flow/base.py b/jina/orchestrate/flow/base.py\nindex af3620dc75d44..97b18393c4f4d 100644\n--- a/jina/orchestrate/flow/base.py\n+++ b/jina/orchestrate/flow/base.py\n... | [
{
"diff_hunk": "@@ -0,0 +1,19 @@\n+import warnings\n+\n+import pytest\n+\n+from jina import Flow\n+\n+\n+def test_load_config_instance():\n+ with pytest.warns(UserWarning): # assert that a warning has been emited\n+ f = Flow().load_config('config.yaml')\n+ f.build()",
"line": null,
"origin... | 0393f444fa930a18bb168b02331f5de8353b841b | diff --git a/jina/orchestrate/flow/base.py b/jina/orchestrate/flow/base.py
index af3620dc75d44..529818b08f338 100644
--- a/jina/orchestrate/flow/base.py
+++ b/jina/orchestrate/flow/base.py
@@ -1,6 +1,7 @@
import argparse
import base64
import copy
+import inspect
import json
import multiprocessing
import os
@@ -8,... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Code Refactoring / Architectural Improvement"
} | |
jina-ai__serve-4734@ede303d | jina-ai/serve | Python | 4,734 | fix: close loop from run_async | We are leaking `asyncio` loops in `run_ascynio`. We use `get_or_reuse_loop()` there to create a new `asyncio` loop in each call. This loop is then used in `run_until_complete`. This completes the coroutine, but does NOT close the loop.
To fix the issue this PR now gets every existing loop. Not only the running loop ... | 2022-05-02T08:43:24Z | Client.encode() does not close file descriptors used.
I am calling .encode() multiple times and it seems as though file descriptors are being opened but not closed which results in this error after running for a period of time.
```
E0429 15:10:27.741673000 4681657856 wakeup_fd_pipe.cc:39] pipe creation... | I can confirm this is a issue of Jina, the backend of CLIP-as-service, the minimum reproducible example is the following:
```python
import os
import subprocess
from jina import Flow
pid = os.getpid()
print('pid', pid)
print('before', subprocess.getoutput(f'lsof -p {pid} | wc -l'))
with Flow() as f:
for... | [
{
"body": "I am calling .encode() multiple times and it seems as though file descriptors are being opened but not closed which results in this error after running for a period of time.\r\n\r\n```\r\nE0429 15:10:27.741673000 4681657856 wakeup_fd_pipe.cc:39] pipe creation failed (24): Too many open f... | 944afbc5797c6c888dc5e9a085f646e157ed31eb | {
"head_commit": "ede303d304dfb32ef3c158a85a250ab231331be5",
"head_commit_message": "fix: create loop if not existing",
"patch_to_review": "diff --git a/extra-requirements.txt b/extra-requirements.txt\nindex c78151378af4e..c574f4d92a656 100644\n--- a/extra-requirements.txt\n+++ b/extra-requirements.txt\n@@ -76,3 ... | [
{
"diff_hunk": "@@ -1006,13 +1007,13 @@ def get_or_reuse_loop():\n \n :return: A new eventloop or reuse the current opened eventloop.\n \"\"\"\n+ _update_policy()\n try:\n- loop = asyncio.get_running_loop()\n+ loop = asyncio.get_event_loop()",
"line": 1028,
"original_line": ... | 5e789f9a6e3201a4e43eb66cb0e74424865eb7ee | diff --git a/extra-requirements.txt b/extra-requirements.txt
index c78151378af4e..c574f4d92a656 100644
--- a/extra-requirements.txt
+++ b/extra-requirements.txt
@@ -76,3 +76,4 @@ pytest-kind==21.1.3: test
pytest-lazy-fixture: test
sgqlc: cicd, graphql
prometheus_client: pe... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
jina-ai__serve-4790@48b3212 | jina-ai/serve | Python | 4,790 | fix: add check that jaml parses to correct class | Fixes silent error when invalid YAML is passed as an Executor
| 2022-05-16T12:44:30Z | Parsing invalid Executor YAML does not fail properly
If a `.yml` that does not define an Executor is passed to `uses=`, it will be parsed into a dict instead of an actual Executor. This dict is then treated like an Executor in the worker runtime ~~, which then fails of course, leading to a cryptic error message.~~
T... | Please put less priority to this ticket. Priority on reliability and robustness should go in the `communication layer` | [
{
"body": "If a `.yml` that does not define an Executor is passed to `uses=`, it will be parsed into a dict instead of an actual Executor. This dict is then treated like an Executor in the worker runtime ~~, which then fails of course, leading to a cryptic error message.~~\r\n\r\nThe behaviour has changed (I be... | ec923d028282d7994069447fe509fafc235c3268 | {
"head_commit": "48b3212129b52627adc74bd61ebee84e1ab75672",
"head_commit_message": "fix: add check that jaml parses to correct class",
"patch_to_review": "diff --git a/jina/jaml/__init__.py b/jina/jaml/__init__.py\nindex 0188323f26e82..124bba634719b 100644\n--- a/jina/jaml/__init__.py\n+++ b/jina/jaml/__init__.p... | [
{
"diff_hunk": "@@ -179,3 +180,11 @@ def test_parsing_brackets_in_envvar():\n assert b['executors'][0]['env']['var2'] == 'a'\n assert b['executors'][0]['env']['var3'] == '{\"1\": \"2\"}-a'\n assert b['executors'][0]['env']['var4'] == '-{\"1\": \"2\"}'\n+\n+\n+def test_exception_invalid_y... | 2575473df7eff3964956c8f8e157dab684c97e4a | diff --git a/jina/jaml/__init__.py b/jina/jaml/__init__.py
index 0188323f26e82..124bba634719b 100644
--- a/jina/jaml/__init__.py
+++ b/jina/jaml/__init__.py
@@ -749,7 +749,12 @@ def _delitem(
# revert yaml's tag and load again, this time with substitution
tag_yml = JAML.unescape(JAML.d... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
jina-ai__serve-4641@7bad622 | jina-ai/serve | Python | 4,641 | fix: remove prometheus import from the top of the files | We want to be able to remove prometheus from core dependency if needed. Therefore we need to remove the import from the top of the file | 2022-04-20T07:16:00Z | perf version of v3.3.2 throw error `No module named 'prometheus_client'`
**Describe the bug**
`docker run --rm --entrypoint jina jinaai/jina:3-py37-perf -v`
<details>
<summary>Result</summary>
```bash
❯ docker run --rm --entrypoint jina jinaai/jina:3-py37-perf -v
Unable to find image 'jinaai/jina:3-py37-p... | Ah. I noticed that #4641 is trying to fix this. | [
{
"body": "**Describe the bug**\r\n\r\n`docker run --rm --entrypoint jina jinaai/jina:3-py37-perf -v`\r\n\r\n<details>\r\n <summary>Result</summary>\r\n\r\n```bash\r\n❯ docker run --rm --entrypoint jina jinaai/jina:3-py37-perf -v\r\nUnable to find image 'jinaai/jina:3-py37-perf' locally\r\n3-py37-perf: Pulling... | 712cccb86b1e07bec6b8b51598c1400333c5de99 | {
"head_commit": "7bad6226a209c40d5653ab731749dcd088ba7f8a",
"head_commit_message": "feat: add github action to test import",
"patch_to_review": "diff --git a/.github/workflows/cd.yml b/.github/workflows/cd.yml\nindex 126ace6009f2d..58abe05b60ee2 100644\n--- a/.github/workflows/cd.yml\n+++ b/.github/workflows/cd.... | [
{
"diff_hunk": "@@ -157,6 +157,28 @@ jobs:\n flags: ${{ steps.test.outputs.codecov_flag }}\n fail_ci_if_error: false\n \n+ import-test:\n+ runs-on: ubuntu-latest\n+ needs: [ commit-lint, lint-flake-8, code-injection ]\n+ strategy:\n+ fail-fast: false\n+ matrix:\n+ ... | eaa83e8d7751419364cdce77abba9f821e85a055 | diff --git a/.github/workflows/cd.yml b/.github/workflows/cd.yml
index 126ace6009f2d..f6d907d95b3ec 100644
--- a/.github/workflows/cd.yml
+++ b/.github/workflows/cd.yml
@@ -157,6 +157,33 @@ jobs:
flags: ${{ steps.test.outputs.codecov_flag }}
fail_ci_if_error: false
+ import-test:
+ runs-on: ... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
jina-ai__serve-4597@51154b4 | jina-ai/serve | Python | 4,597 | feat: Expose Executors as first class citizens | # Expose Executors as first class citizens
## Description
This adds `to_k8s_yaml()` and `to_docker_compose_yaml()` for the Executors. It works similar to `serve()` in the sense that it creates a `Flow` behind the scenes and uses its existing methods to provide a similar user experience.
These features are also ... | 2022-04-11T14:00:15Z | Expose Executor as a Service as First class citizen in Documentation.
**Describe the feature**
Right now we have added `Executor.serve` method and we are seeing increasing interest in serving a single `Executor` as an isolated service.
After `Head` is removed as a result of the `service mesh` introduction, this wil... | Blocked by #4503
Seems like a good thing to do.
I see some conceptual overlap with external Executors, and we probably need to be careful to make the distinction clear.
> Seems like a good thing to do. I see some conceptual overlap with external Executors, and we probably need to be careful to make the distinction cl... | [
{
"body": "**Describe the feature**\r\nRight now we have added `Executor.serve` method and we are seeing increasing interest in serving a single `Executor` as an isolated service.\r\n\r\nAfter `Head` is removed as a result of the `service mesh` introduction, this will be even more performant, and `gateway` rema... | fab9f0736c8d99558d93020cb3f27108627218f1 | {
"head_commit": "51154b47a1e6e7bc61158a8802d6047f5f4093c3",
"head_commit_message": "feat: add k8s/docker export for Executors",
"patch_to_review": "diff --git a/jina/orchestrate/flow/base.py b/jina/orchestrate/flow/base.py\nindex 590150fb9a5db..62c2097caf316 100644\n--- a/jina/orchestrate/flow/base.py\n+++ b/jin... | [
{
"diff_hunk": "@@ -1814,7 +1814,12 @@ def expose_endpoint(self, exec_endpoint: str, **kwargs):\n # for backward support\n join = needs\n \n- def to_k8s_yaml(self, output_base_path: str, k8s_namespace: Optional[str] = None):\n+ def to_k8s_yaml(\n+ self,\n+ output_base_path: str,\n+ ... | 25d12e253dd745c7fafe52bf55627395b5963cca | diff --git a/docs/fundamentals/executor/executor-api.md b/docs/fundamentals/executor/executor-api.md
index 42393abf6c9d2..8e36009f4fcb1 100644
--- a/docs/fundamentals/executor/executor-api.md
+++ b/docs/fundamentals/executor/executor-api.md
@@ -317,11 +317,17 @@ print(docs.embeddings.shape)
```
````
+(serve-executo... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
jina-ai__serve-4571@dde0d09 | jina-ai/serve | Python | 4,571 | fix: start DataRequestHandler before grpc server | # Start DataRequestHandler before grpc server
## Description
We need to start the DataRequestHandler before the grpc Server. We may have Executors which are slow to init (downloading models etc) and we should not indicate to ready before the DataRequestHandler has been started.
This works atm with STATUS request... | 2022-04-01T11:37:52Z | WorkerRuntime starts gRPC Server before DataRequestHandler is ready
The WorkerRuntime calls `super().init()` before `DataRequestHandler(args, self.logger)`. The super init will in turn call `async_setup()`, which will initialize the grpc server. So this server will be ready BEFORE the DataRequestHandler.
This is bad... | [
{
"body": "The WorkerRuntime calls `super().init()` before `DataRequestHandler(args, self.logger)`. The super init will in turn call `async_setup()`, which will initialize the grpc server. So this server will be ready BEFORE the DataRequestHandler.\r\n\r\nThis is bad, because a STATUS request will succeed signa... | d72fe2181ddf3d10e1d1c05b50e2476a6decedf0 | {
"head_commit": "dde0d093127a9f4ab72d923d4a89fe7061909bf7",
"head_commit_message": "fix: start DataRequestHandler before grpc server",
"patch_to_review": "diff --git a/jina/serve/runtimes/worker/__init__.py b/jina/serve/runtimes/worker/__init__.py\nindex 5e73509f2dbc7..996e1c4e8fad6 100644\n--- a/jina/serve/runt... | [
{
"diff_hunk": "@@ -275,5 +274,69 @@ async def task_wrapper(adress, messages_received):\n assert not WorkerRuntime.is_ready(f'{args.host}:{args.port}')\n \n \n+class SlowInitExecutor(Executor):\n+ def __init__(self, *args, **kwargs):\n+ super().__init__(*args, **kwargs)\n+ time.sleep(5.0)\n... | 11bd95d439e2e620bac0d9db91c9efb41a82b768 | diff --git a/jina/serve/runtimes/worker/__init__.py b/jina/serve/runtimes/worker/__init__.py
index 5e73509f2dbc7..996e1c4e8fad6 100644
--- a/jina/serve/runtimes/worker/__init__.py
+++ b/jina/serve/runtimes/worker/__init__.py
@@ -32,13 +32,16 @@ def __init__(
"""
super().__init__(args, cancel_event, **... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
jina-ai__serve-4562@b9f2f30 | jina-ai/serve | Python | 4,562 | fix: check if port is occupied | fix https://github.com/jina-ai/jina/issues/4555 | 2022-03-30T09:31:11Z | Two jina flow can run on the same port
**Describe the bug**
You can launch two flow on the same port, meaning two gateway serving on the same port without any of the two complaining.
**Step to reproduce**
In `toy.py`
```python
from jina import Flow, requests, Executor
class Dummy(Executor):
@requ... | let's give it a higher priority, i think it can be really confusing for users, especially multiple-same-port-gateway gives weird empty results, as we shown in CLIP-as-service | [
{
"body": "**Describe the bug**\r\n\r\nYou can launch two flow on the same port, meaning two gateway serving on the same port without any of the two complaining.\r\n\r\n\r\n**Step to reproduce**\r\n\r\nIn `toy.py`\r\n```python\r\nfrom jina import Flow, requests, Executor\r\n\r\nclass Dummy(Executor):\r\n\r\n ... | 12163af01009772035b2e87523663beb890a2549 | {
"head_commit": "b9f2f305339a4a0c4f3e45ef94598f2294168108",
"head_commit_message": "refactor(tests): move test to issues",
"patch_to_review": "diff --git a/jina/excepts.py b/jina/excepts.py\nindex 2f2e2e8a6dde7..4568b81f3ddf5 100644\n--- a/jina/excepts.py\n+++ b/jina/excepts.py\n@@ -81,3 +81,7 @@ class DockerVer... | [
{
"diff_hunk": "@@ -471,6 +473,12 @@ def _add_gateway(\n \n kwargs.update(self._common_kwargs)\n args = ArgNamespace.kwargs2namespace(kwargs, set_gateway_parser())\n+\n+ if not (\n+ is_port_free(__default_host__, args.port)",
"line": null,
"original_line": 478,
"ori... | c7a9bc1187d60574d4a5d7aa5590e3cfa847a276 | diff --git a/jina/excepts.py b/jina/excepts.py
index 2f2e2e8a6dde7..4568b81f3ddf5 100644
--- a/jina/excepts.py
+++ b/jina/excepts.py
@@ -81,3 +81,7 @@ class DockerVersionError(SystemError, BaseJinaException):
class NoContainerizedError(Exception, BaseJinaException):
"""Raised when trying to use non-containerize... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
jina-ai__serve-4424@8da4751 | jina-ai/serve | Python | 4,424 | refactor: add disable_reduce args | # Refactor: replace has_used with disable_reduce argument
## Description
This PR adds the argument `disable-reduce`. This allows the user to disable the automatic reduce mechanism explicitly. By default it is false.
This only applies if there are no uses_before/uses_after defined. In case those are defined, they... | 2022-03-01T10:10:01Z | Change `_has_uses` logic in Head.
**Describe the bug**
This logic should be an independent `argument` saying `--reduce` that is set to True or False by the Head.
Also needs to check if both `Flow`, `K8s` and `docker-compose` set properly this flag. | [
{
"body": "**Describe the bug**\r\nThis logic should be an independent `argument` saying `--reduce` that is set to True or False by the Head.\r\n\r\nAlso needs to check if both `Flow`, `K8s` and `docker-compose` set properly this flag.\r\n\r\n ",
"number": 4381,
"title": "Change `_has_uses` logic in He... | b22647934e9e51618f51e8d551e6232af07b30e5 | {
"head_commit": "8da475123b634130b8005309753b99a9456470c6",
"head_commit_message": "docs: add disable_reduce param",
"patch_to_review": "diff --git a/cli/autocomplete.py b/cli/autocomplete.py\nindex 4338ccee257ae..11c37180188f5 100644\n--- a/cli/autocomplete.py\n+++ b/cli/autocomplete.py\n@@ -97,6 +97,7 @@\n ... | [
{
"diff_hunk": "@@ -25,3 +27,12 @@ def mixin_head_parser(parser):\n type=str,\n help='dictionary JSON with a list of connections to configure',\n )\n+\n+ gp.add_argument(\n+ '--disable-reduce',\n+ action='store_true',\n+ default=False,\n+ help='Disable the buil... | c15a19eedc73878726c3dc652e432a79326233ee | diff --git a/cli/autocomplete.py b/cli/autocomplete.py
index 4338ccee257ae..11c37180188f5 100644
--- a/cli/autocomplete.py
+++ b/cli/autocomplete.py
@@ -97,6 +97,7 @@
'--uses-before-address',
'--uses-after-address',
'--connection-list',
+ '--disable-reduce',
],... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
jina-ai__serve-4410@b8c48f3 | jina-ai/serve | Python | 4,410 | fix: fix client error 4391 | fixing https://github.com/jina-ai/jina/issues/4391
New behavior:
if an exception is raised then :
- [x] if there is an on_error callback then the callback is called and the original exception is passed to the on_error
- [x] Otherwise we just throw an ClientError which wrap the actual exception
- [x] docs
| 2022-02-25T08:56:21Z | `on_error` broken for Client with unreachable server
```python
from jina import Client, DocumentArray
def on_error(response):
print('on_error called')
print(response.to_dict())
for protocol in ['http', 'grpc', 'websocket']:
print(f'\n\n\n\nprotocol: {protocol}')
try:
Client(host=... | [
{
"body": "```python\r\nfrom jina import Client, DocumentArray\r\n\r\n\r\ndef on_error(response):\r\n print('on_error called')\r\n print(response.to_dict())\r\n\r\n\r\nfor protocol in ['http', 'grpc', 'websocket']:\r\n print(f'\\n\\n\\n\\nprotocol: {protocol}')\r\n try:\r\n Client(host='0.0.0... | b22647934e9e51618f51e8d551e6232af07b30e5 | {
"head_commit": "b8c48f360c8f93aa057675142db96c23be7e94ed",
"head_commit_message": "fix: on_error depcration warning called only onced",
"patch_to_review": "diff --git a/jina/clients/base/grpc.py b/jina/clients/base/grpc.py\nindex b81ad4e310bef..134af1f59e468 100644\n--- a/jina/clients/base/grpc.py\n+++ b/jina/c... | [
{
"diff_hunk": "@@ -325,7 +325,7 @@ class MyExecutor(Executor):\n f = Flow().add(uses=MyExecutor)\n \n \n-def print_why(resp):\n+def print_why(resp, exception: None):",
"line": null,
"original_line": 328,
"original_start_line": null,
"path": "docs/fundamentals/executor/executor-in-flow.md",
... | d5a61006dc3652145f5fe9ca82cbac2cd421c1f5 | diff --git a/docs/fundamentals/executor/executor-in-flow.md b/docs/fundamentals/executor/executor-in-flow.md
index 1f0837ee4a816..2af530de17edd 100644
--- a/docs/fundamentals/executor/executor-in-flow.md
+++ b/docs/fundamentals/executor/executor-in-flow.md
@@ -325,7 +325,7 @@ class MyExecutor(Executor):
f = Flow().add... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} | |
jina-ai__serve-4384@57f5745 | jina-ai/serve | Python | 4,384 | docs: adjust port args | # Adjust ports arguments in docs
## Description
This changes the arguments `port-expose` and `port-in` in the documentation to just `port` as changed in the code [here](https://github.com/jina-ai/jina/pull/4382).
As the docs are not versioned, only merge and deploy this change AFTER THE NEXT RELEASE.
Closes ... | 2022-02-22T08:09:03Z | Unify port_expose and port_in
We have `port_expose` and `port_in` arguments for historical reasons, but we don't have the need anymore to distinguish between the two. Every Jina Pod only exposes a single port.
Thus we should unify the two arguments into a new argument, which is only called `port`. This needs to be don... | [
{
"body": "We have `port_expose` and `port_in` arguments for historical reasons, but we don't have the need anymore to distinguish between the two. Every Jina Pod only exposes a single port.\r\nThus we should unify the two arguments into a new argument, which is only called `port`. This needs to be done in a ba... | 25fefd31aeffeb19cf93954202e75ac63d2fe6e8 | {
"head_commit": "57f57458c9c30a22e6e9a98da97041b32d24f5a3",
"head_commit_message": "docs: adjust port args",
"patch_to_review": "diff --git a/CHANGELOG.md b/CHANGELOG.md\nindex a2eaad9998544..77979d878e31b 100644\n--- a/CHANGELOG.md\n+++ b/CHANGELOG.md\n@@ -10287,7 +10287,7 @@ Jina is released on every Friday ev... | [
{
"diff_hunk": "@@ -10287,7 +10287,7 @@ Jina is released on every Friday evening. The PyPi package and Docker Image will\n \n ### 🐞 Bug fixes\n \n- - [[```0147ad76```](https://github.com/jina-ai/jina/commit/0147ad769bbcd8c2181083b2aade4eece82d1b3d)] __-__ __script__: fix port_expose in jinad (*Han Xiao*)\n+ - ... | fa85b15bfdb735b7c1e53991e9f83cf0d13025ae | diff --git a/README.md b/README.md
index 0853b5176bcf0..ce940823a8d57 100644
--- a/README.md
+++ b/README.md
@@ -120,7 +120,7 @@ Preliminaries: <a href="https://pytorch.org/get-started/locally/">install PyTorc
5. Connect all `Executor`s in a `Flow`, scale embedding to 3:
```python
f = (
- Flow(port_ex... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Code Refactoring / Architectural Improvement"
} | |
jina-ai__serve-3935@07a362e | jina-ai/serve | Python | 3,935 | feat(daemon): scale endpoint for flows & pods | - [x] Separated the `rolling_update` & `scale` endpoints for Flows / Pods.
- [x] Separated `rolling_update` & `scale` methods for `JinaDClient`.
- [x] Removed `UpdateOperation` enums.
- [x] Added unittests for `scale` store, partial-store & client.
- [x] Added distributed tests for scale endpoints (Local Flow-remot... | 2021-11-15T17:39:51Z | add distribuetd test for scale method
**TODO**
In order to support `scale` endpoint for Remote Flows and Pods, JinaD needs to:
- [ ] Clarify the Update endpoint and accept different parameters depending on the `kind` of update operation
- [ ] Add a new UpdateOperation scale
- [ ] Unittest the `update` methods
- ... | Blocked until #3816 is merged | [
{
"body": "**TODO**\r\nIn order to support `scale` endpoint for Remote Flows and Pods, JinaD needs to:\r\n\r\n- [ ] Clarify the Update endpoint and accept different parameters depending on the `kind` of update operation\r\n- [ ] Add a new UpdateOperation scale\r\n- [ ] Unittest the `update` methods\r\n- [ ] Add... | 5db05740ddffe2c4f9e44637139393ffe29861a2 | {
"head_commit": "07a362e1e15a74331b915f8741acc3224d5a8258",
"head_commit_message": "feat(daemon): scale endpoint",
"patch_to_review": "diff --git a/daemon/api/endpoints/flows.py b/daemon/api/endpoints/flows.py\nindex 04f3a6d37565e..7d8f31abe1e11 100644\n--- a/daemon/api/endpoints/flows.py\n+++ b/daemon/api/endpo... | [
{
"diff_hunk": "@@ -60,7 +57,24 @@ async def _update(\n .. #noqa: DAR201\n \"\"\"\n try:\n- return store.update(kind, pod_name, uses_with=uses_with)\n+ return store.rolling_update(pod_name=pod_name, uses_with=uses_with)\n+ except ValueError as ex:\n+ raise PartialDaemon400Exc... | 8513cd45ff6c746c1f5130e54dc32e31475ffe36 | diff --git a/.github/workflows/cd.yml b/.github/workflows/cd.yml
index 714d02f31c241..8b765eda20148 100644
--- a/.github/workflows/cd.yml
+++ b/.github/workflows/cd.yml
@@ -164,7 +164,7 @@ jobs:
if [[ "${{ matrix.test-path }}" =~ ^tests/distributed/* || "${{ matrix.test-path }}" =~ ^tests/daemon/* ]]; then
... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Test Suite / CI Enhancements"
} |
jina-ai__serve-3769@27e73b8 | jina-ai/serve | Python | 3,769 | docs: replace usages of parallel | closes: https://github.com/jina-ai/jina/issues/3748 | 2021-10-25T08:36:14Z | Replace use of parallel in examples and docs
We deprecated the use of `parallel` in favor of the more explicit `replicas` and `shards`. Before `parallel` could mean both `replicas` and `shards` depending on its usage. Now it is an alias for `shards` for backwards compatibility (because replicas has less features), but... | [
{
"body": "We deprecated the use of `parallel` in favor of the more explicit `replicas` and `shards`. Before `parallel` could mean both `replicas` and `shards` depending on its usage. Now it is an alias for `shards` for backwards compatibility (because replicas has less features), but should no longer be adver... | 136ddecda2049084269c5d278454a7baae99cd48 | {
"head_commit": "27e73b849e3d52353e4a92401dc9184aaee94b80",
"head_commit_message": "docs: replace usages of parallel",
"patch_to_review": "diff --git a/README.md b/README.md\nindex 1aec67752578f..ce5d2a9906587 100644\n--- a/README.md\n+++ b/README.md\n@@ -30,7 +30,7 @@ Jina<sup><a href=\".github/pronounce-jina.m... | [
{
"diff_hunk": "@@ -99,7 +99,7 @@ class Indexer(Executor):\n def bar(self, docs: DocumentArray, **kwargs):\n docs.match(self._docs, metric='euclidean')\n \n-f = Flow(port_expose=12345, protocol='http', cors=True).add(uses=CharEmbed, parallel=2).add(uses=Indexer) # build a Flow, with 2 parallel Cha... | fb45ca475662855d16fdd43d74dbbe18be09de1b | diff --git a/README.md b/README.md
index 1aec67752578f..29e85fec25889 100644
--- a/README.md
+++ b/README.md
@@ -30,7 +30,7 @@ Jina<sup><a href=".github/pronounce-jina.mp3">`🔊`</a></sup> is a neural searc
⏱️ **Save time** - *The* design pattern of neural search systems, from zero to a production-ready system in minut... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "Code Refactoring / Architectural Improvement"
} | |
jina-ai__serve-3680@f6ee45e | jina-ai/serve | Python | 3,680 | feat: pass extra search paths to executor load config | add extra search paths to load_config in order to avoid relying just on the stack frame to retrieve executor yaml files
closes: https://github.com/jina-ai/jina/issues/3614 | 2021-10-14T11:06:49Z | Changes to adapt to FastAPI >= 0.70.0
Describe the feature
Due to failing tests/daemon/unit/api/endpoints/partial/test_flow.py::test_flow_api in CI, we found that the reason was the new release of FastAPI.
What we found is that the stack frame that we rely on to find the correct yml files to load did not mantain th... | [
{
"body": "Describe the feature\r\nDue to failing tests/daemon/unit/api/endpoints/partial/test_flow.py::test_flow_api in CI, we found that the reason was the new release of FastAPI.\r\n\r\nWhat we found is that the stack frame that we rely on to find the correct yml files to load did not mantain the tests... fo... | 1830b4e53779b9bd8db3ad4744801a2dc9ff233f | {
"head_commit": "f6ee45e00810e5ce52a619ed62cd8b424aabeb62",
"head_commit_message": "test: add flow load config",
"patch_to_review": "diff --git a/cli/autocomplete.py b/cli/autocomplete.py\nindex 956af4afb9345..3beb28de2539b 100644\n--- a/cli/autocomplete.py\n+++ b/cli/autocomplete.py\n@@ -59,6 +59,7 @@\n ... | [
{
"diff_hunk": "@@ -1,3 +1,4 @@\n+import inspect",
"line": null,
"original_line": 1,
"original_start_line": null,
"path": "jina/jaml/__init__.py",
"start_line": null,
"text": "@user1:\nremove useless import"
}
] | 41883dd0a6323f1bc27b9748c05c8ee706914a40 | diff --git a/cli/autocomplete.py b/cli/autocomplete.py
index 956af4afb9345..3beb28de2539b 100644
--- a/cli/autocomplete.py
+++ b/cli/autocomplete.py
@@ -59,6 +59,7 @@
'--static-routing-table',
'--routing-table',
'--dynamic-routing',
+ '--extra-search-paths',
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Code Refactoring / Architectural Improvement"
} | |
jina-ai__serve-3509@4463c71 | jina-ai/serve | Python | 3,509 | feat(k8s): kubernetes completion, wait for ready and close | 2021-09-28T14:52:58Z | Kubernetes - Flow usage as seemless as native Flow
When creating a K8s Flow, I would like to use it as a native Flow:
```
flow = Flow(
name='test-flow',
port_expose=8080,
infrastructure='K8S',
).add(...)
flow.start()
flow.post(
on='/index',
inputs=[Document(text=str(i), embedding=np... | I think the port forwarding is questionable? That is a debug mechanism you should use while developing and not for production so I would not do that automatically from code? The rest is fine, especially the readyness check we need
Hmm I see. Would you be fine with an argument `automatic_port_forwarding` which defaults ... | [
{
"body": "When creating a K8s Flow, I would like to use it as a native Flow:\r\n```\r\n\r\nflow = Flow(\r\n name='test-flow',\r\n port_expose=8080,\r\n infrastructure='K8S',\r\n).add(...)\r\n\r\nflow.start()\r\n\r\nflow.post(\r\n on='/index',\r\n inputs=[Document(text=str(i), embedding=np.random... | d36220207842f68db8a5a775c3caf9d067e21663 | {
"head_commit": "4463c71d76afa930c25c3db27ec4daa1dc716cf0",
"head_commit_message": "test: remove session",
"patch_to_review": "diff --git a/.github/workflows/cd.yml b/.github/workflows/cd.yml\nindex b743c87cde173..137087a673803 100644\n--- a/.github/workflows/cd.yml\n+++ b/.github/workflows/cd.yml\n@@ -263,8 +26... | [
{
"diff_hunk": "@@ -223,7 +223,7 @@ jobs:\n GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}\n - name: Test k8s\n run: |\n- pytest -v -s --suppress-no-test-exit-code --force-flaky --min-passes 1 --max-runs 5 --cov=jina --cov-report=xml ./tests/k8s/\n+ pytest -v -s --suppress-n... | cfe1982cf01d1d548682eaa219a85cdaeaff22a5 | diff --git a/.github/workflows/cd.yml b/.github/workflows/cd.yml
index b743c87cde173..137087a673803 100644
--- a/.github/workflows/cd.yml
+++ b/.github/workflows/cd.yml
@@ -263,8 +263,8 @@ jobs:
JINAHUB_PASSWORD: ${{ secrets.JINAHUB_PASSWORD }}
k8s-test:
- runs-on: ubuntu-latest
needs: update-sc... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
jina-ai__serve-3562@424d303 | jina-ai/serve | Python | 3,562 | feat(client): add prefetch to http client | 2021-10-03T11:28:50Z | Http client not streaming requests
The HttpClient is not using streaming correctly together with input generators.
See this test code
```
import time
from jina import Flow, Document, Executor, requests
def slow_gen():
for j in range(10):
yield Document()
time.sleep(1)
print(... | [
{
"body": "The HttpClient is not using streaming correctly together with input generators.\r\n\r\nSee this test code\r\n\r\n```\r\nimport time\r\n\r\nfrom jina import Flow, Document, Executor, requests\r\n\r\ndef slow_gen():\r\n for j in range(10):\r\n yield Document()\r\n time.sleep(1)\r\n ... | c77ed1357aa440a6601c6b40bb4ed15fe6fed093 | {
"head_commit": "424d303385e30a2bec277045543a6c75c14c90d9",
"head_commit_message": "feat(client): add prefetch to http client",
"patch_to_review": "diff --git a/jina/clients/base/http.py b/jina/clients/base/http.py\nindex 018ba4ff32308..0cff3ef93e5f3 100644\n--- a/jina/clients/base/http.py\n+++ b/jina/clients/ba... | [
{
"diff_hunk": "@@ -107,11 +107,11 @@ def _register_pollin(self):\n self.poller.register(self.in_connect_sock, zmq.POLLIN)\n \n def pause_pollin(self):\n- \"\"\"Remove :attr:`in_sock` from the poller \"\"\"\n+ \"\"\"Remove :attr:`in_sock` from the poller\"\"\"",
"line": null,
... | 095d4f3327b6e149ccfab1026283b311e541fb40 | diff --git a/cli/autocomplete.py b/cli/autocomplete.py
index fb02a145bf096..90585cb5b3cf7 100644
--- a/cli/autocomplete.py
+++ b/cli/autocomplete.py
@@ -380,6 +380,8 @@
'--https',
'--asyncio',
'--protocol',
+ '--prefetch',
+ '--prefetch-on-recv',
],
... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} | ||
jina-ai__serve-3484@29e3657 | jina-ai/serve | Python | 3,484 | feat: start portforwarding when flow.post in K8s | This pr enables to run k8s flows via context manager.
# Example:
## Before:
```
Flow(
name='test-flow', port_expose=8080, infrastructure='K8S'
).start()
# ... setup port forward ...
with k8s_cluster_namespaced.port_forward(
resp = requests.post(
f'http://l... | 2021-09-27T08:22:25Z | Kubernetes - Flow usage as seemless as native Flow
When creating a K8s Flow, I would like to use it as a native Flow:
```
flow = Flow(
name='test-flow',
port_expose=8080,
infrastructure='K8S',
).add(...)
flow.start()
flow.post(
on='/index',
inputs=[Document(text=str(i), embedding=np... | I think the port forwarding is questionable? That is a debug mechanism you should use while developing and not for production so I would not do that automatically from code? The rest is fine, especially the readyness check we need
Hmm I see. Would you be fine with an argument `automatic_port_forwarding` which defaults ... | [
{
"body": "When creating a K8s Flow, I would like to use it as a native Flow:\r\n```\r\n\r\nflow = Flow(\r\n name='test-flow',\r\n port_expose=8080,\r\n infrastructure='K8S',\r\n).add(...)\r\n\r\nflow.start()\r\n\r\nflow.post(\r\n on='/index',\r\n inputs=[Document(text=str(i), embedding=np.random... | 5be2d49e5aa565d9a40cbd6b2b83ee53ba475366 | {
"head_commit": "29e3657703b9e3a998b30029dcc8f570961406eb",
"head_commit_message": "refactor: probe",
"patch_to_review": "diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml\nindex bd4845bd47660..ff1b071e5273c 100644\n--- a/.github/workflows/ci.yml\n+++ b/.github/workflows/ci.yml\n@@ -322,7 +322,7 @... | [
{
"diff_hunk": "@@ -17,6 +17,14 @@ spec:\n containers:\n - name: executor\n image: {image}\n+# resources:\n+# requests:",
"line": null,
"original_line": 21,
"original_start_line": null,
"path": "jina/resources/k8s/template/deployment.yml",
"start_line": nu... | 13c54309c19c3ecac389d18055c269941cfa9647 | diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index bd4845bd47660..ff1b071e5273c 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -322,7 +322,7 @@ jobs:
# just for blocking the merge until all parallel core-test are successful
success-all-test:
runs-on: ubuntu-latest... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
jina-ai__serve-3590@3623665 | jina-ai/serve | Python | 3,590 | feat: disable prefetch by default, remove on-recv :boom: | # Streamer
Implements request streaming in 2 ways
- prefetch - controls speed of request sending, handles overloading https://github.com/jina-ai/jina/blob/d9b841474e29ffa2d332f006fc2d773881a1b6ae/jina/peapods/runtimes/stream/mixin.py#L108-L110
- no-prefetch - async send/receive requests without control https://git... | 2021-10-06T06:36:08Z | Improve prefetching
If an async client is slow to yield requests (with prefetching > 1) this will also slow done the response streaming. Requests are processed by the flow as they come in via the async iterator, but they results are only streamed back to the client once the input iterator is complete or the prefetching... | [
{
"body": "If an async client is slow to yield requests (with prefetching > 1) this will also slow done the response streaming. Requests are processed by the flow as they come in via the async iterator, but they results are only streamed back to the client once the input iterator is complete or the prefetching ... | cf6705f43109e38df666a0256c8c04bb54df1b37 | {
"head_commit": "3623665262d04d67c7ca2e2f5d2b966d4d54db59",
"head_commit_message": "refactor: set prefetch to 1 by default",
"patch_to_review": "diff --git a/jina/parsers/peapods/runtimes/remote.py b/jina/parsers/peapods/runtimes/remote.py\nindex 838798283ca93..b10b53a67e715 100644\n--- a/jina/parsers/peapods/ru... | [
{
"diff_hunk": "@@ -164,14 +164,8 @@ def mixin_prefetch_parser(parser=None):\n gp.add_argument(\n '--prefetch',\n type=int,\n- default=50,\n- help='The number of pre-fetched requests from the client',\n- )\n- gp.add_argument(\n- '--prefetch-on-recv',\n- type... | b41f183a1977a508ce54520a2b949308c3d26526 | diff --git a/cli/autocomplete.py b/cli/autocomplete.py
index c78832d4569f6..956af4afb9345 100644
--- a/cli/autocomplete.py
+++ b/cli/autocomplete.py
@@ -176,7 +176,6 @@
'--dump-path',
'--k8s-disable-connection-pool',
'--prefetch',
- '--prefetch-on-recv',
'-... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "Performance Optimizations"
} | |
jina-ai__serve-3469@58dcaf3 | jina-ai/serve | Python | 3,469 | fix(daemon): remote flow with parallel>1 | 2021-09-24T02:33:05Z | `JinaD` doesn't set `workspace` properly
While starting a Flow, `JinaD` sets Executor workspace to `<jinad-root-workspace>/<workspace-id>` (e.g.- `/tmp/jinad/jworkspace-0764ff64-ba12-437c-99f0-4a34f135180f` which is only accessible inside dockerhost and not on localhost. Other Flows on the same workspace cannot use the... | [
{
"body": "While starting a Flow, `JinaD` sets Executor workspace to `<jinad-root-workspace>/<workspace-id>` (e.g.- `/tmp/jinad/jworkspace-0764ff64-ba12-437c-99f0-4a34f135180f` which is only accessible inside dockerhost and not on localhost. Other Flows on the same workspace cannot use the already indexed files... | 707b7aac6a92e173ceba568be259506838c13033 | {
"head_commit": "58dcaf3be8be001377745e7b8e7df49ef55b0512",
"head_commit_message": "Merge branch 'master' into fix-remote-flow-replicas",
"patch_to_review": "diff --git a/daemon/clients/flows.py b/daemon/clients/flows.py\nindex a7c0d9219e46e..67cf31b4cc22b 100644\n--- a/daemon/clients/flows.py\n+++ b/daemon/clie... | [
{
"diff_hunk": "@@ -144,6 +145,12 @@ def add(\n pod.replicas_args = CompoundPod._set_replica_args(\n pod.args, pod.head_args, pod.tail_args\n )\n+ else:\n+ # avoid setting runs_in_docker for... | ee97f688cb6a12f6adaa95df97eae5b1e2b4f14c | diff --git a/daemon/api/dependencies.py b/daemon/api/dependencies.py
index 34e92b5f178b7..464d379b47c58 100644
--- a/daemon/api/dependencies.py
+++ b/daemon/api/dependencies.py
@@ -138,8 +138,14 @@ def load_and_dump(self) -> None:
for pod_name, pod in f._pod_nodes.items():
runtime_cls = up... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} | ||
jina-ai__serve-3259@532c55c | jina-ai/serve | Python | 3,259 | feat: add edges and nodes in batches | 2021-08-24T12:57:31Z | [GraphDocument] Add nodes and edges by lists
**Describe the feature**
Building a large graph by adding one node or one edge a time becomes very slow. Let's add the option as other frameworks just as DGL or NetworkX to add nodes and edges by lists.
We could define the interfaces as:
```python
graph = GraphDocume... | [
{
"body": "**Describe the feature**\r\nBuilding a large graph by adding one node or one edge a time becomes very slow. Let's add the option as other frameworks just as DGL or NetworkX to add nodes and edges by lists.\r\n\r\nWe could define the interfaces as:\r\n\r\n```python\r\ngraph = GraphDocument()\r\ngraph.... | caf132dbe136828f147b75a0f58a0d2dcc687b55 | {
"head_commit": "532c55caf15437983e2677ee09908d9d5fcfba9d",
"head_commit_message": "test: add tests for string api",
"patch_to_review": "diff --git a/.github/2.0/cookbooks/Document.md b/.github/2.0/cookbooks/Document.md\nindex 1593a173f6b5b..5aa69a186e6f4 100644\n--- a/.github/2.0/cookbooks/Document.md\n+++ b/.g... | [
{
"diff_hunk": "@@ -84,31 +85,51 @@ def add_node(self, node: 'Document'):\n self._node_id_to_offset[node.id] = len(self.nodes)\n self.nodes.append(node)\n \n- def remove_node(self, node: 'Document'):\n+ @deprecated_method(new_function_name='add_single_node')\n+ def add_node(self, *args,... | 2695d1bf08f500adffae68098acbb2652e3d1aef | diff --git a/.github/2.0/cookbooks/Document.md b/.github/2.0/cookbooks/Document.md
index 1593a173f6b5b..5aa69a186e6f4 100644
--- a/.github/2.0/cookbooks/Document.md
+++ b/.github/2.0/cookbooks/Document.md
@@ -530,7 +530,7 @@ from jina.types.document.graph import GraphDocument
from jina import Document
graph = Graph... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | ||
jina-ai__serve-3212@96ae473 | jina-ai/serve | Python | 3,212 | fix: fix listview insert, append | 2021-08-18T15:12:16Z | bug: appending to list in document tags
**Describe the bug**
When using a python list as a value for the `Document` tags appending to the list raise `AttributeError: insert`.
Reproduce
```
from jina import Document
doc = Document()
doc.tags['key'] = []
doc.tags['key'].append(1)
```
Traceback:
```
Trace... | Will try to take a look. ListView and StructView are tricky
Solved by #3212 | [
{
"body": "**Describe the bug**\r\nWhen using a python list as a value for the `Document` tags appending to the list raise `AttributeError: insert`.\r\n\r\nReproduce\r\n```\r\nfrom jina import Document\r\n\r\ndoc = Document()\r\ndoc.tags['key'] = []\r\ndoc.tags['key'].append(1)\r\n```\r\n\r\nTraceback:\r\n```\r... | 55c49447d66b6e05b9242c99ad58c56a6d199126 | {
"head_commit": "96ae473dcec160a97876b01fcf0b6145660c2bfb",
"head_commit_message": "fix: update tests/unit/types/test_list_view.py\n\nCo-authored-by: Yongxuan Zhang <44033547+Yongxuanzhang@users.noreply.github.com>",
"patch_to_review": "diff --git a/jina/types/list.py b/jina/types/list.py\nindex 2c0cf42372887..4... | [
{
"diff_hunk": "@@ -153,3 +153,27 @@ def test_list_view_access_out_of_bounds(list_proto):\n view = ListView(list_proto)\n with pytest.raises(IndexError):\n _ = view[100]\n+\n+\n+def test_list_view_insert():\n+ lv = ListValue()\n+ view = ListView(lv)\n+ assert len(view) == 0\n+ view.i... | 0ccde0fd39c87a66ccb01987477d12e5d51967f7 | diff --git a/jina/types/list.py b/jina/types/list.py
index 2c0cf42372887..42d19e3578009 100644
--- a/jina/types/list.py
+++ b/jina/types/list.py
@@ -28,7 +28,10 @@ def insert(self, index: int, object: Any) -> None:
:param index: Position of the insertion.
:param object: The object that needs to be ins... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
jina-ai__serve-3144@4e8d454 | jina-ai/serve | Python | 3,144 | fix: executor point to pea again | 2021-08-10T14:44:14Z | docker:// syntax no longer supported
Did we discontinue using `--uses docker://foo:latest`?
on latest master I get
``` ZEDRuntime@45681[E]:fail to load config from docker://foo:latest, if you are using docker image for --uses, please use "docker://YOUR_IMAGE_NAME"
Traceback (most recent call last):
File "/hom... | ### 🆕 New Features
- [[```fa7c4770```](https://github.com/jina-ai/jina/commit/fa7c4770a4377247c8e1ea5739fb051df64140b1)] __-__ add data request handler (#3105) (*Joan Fontanals*)
- [[```4e14b19e```](https://github.com/jina-ai/jina/commit/4e14b19eb3c7f4a6cc98034555431c2d0abe526b)] __-__ __daemon__: rolling update... | [
{
"body": "Did we discontinue using `--uses docker://foo:latest`?\r\n\r\non latest master I get\r\n\r\n``` ZEDRuntime@45681[E]:fail to load config from docker://foo:latest, if you are using docker image for --uses, please use \"docker://YOUR_IMAGE_NAME\"\r\nTraceback (most recent call last):\r\n File \"/home/c... | 6cb52827982ab23fc8c7eca3ada8fea4800922e0 | {
"head_commit": "4e8d45487a07eaa8b8e89517f1fe7f394a5b57fc",
"head_commit_message": "fix: executor point to pea again",
"patch_to_review": "diff --git a/cli/api.py b/cli/api.py\nindex 8ddb5bb47348f..b7df34adffbb2 100644\n--- a/cli/api.py\n+++ b/cli/api.py\n@@ -48,7 +48,7 @@ def zed_runtime(args: 'Namespace'):\n \... | [
{
"diff_hunk": "@@ -205,13 +205,23 @@ def get_main_parser():\n set_pod_parser(\n sp.add_parser(\n 'executor',\n- aliases=['pod'],\n+ aliases=['pea'],",
"line": null,
"original_line": 208,
"original_start_line": null,
"path": "jina/parsers/__init__.py... | 16ab76c94dbd0d6ad8099396c60929b5c1489881 | diff --git a/cli/api.py b/cli/api.py
index fd8a47cac5990..3c1a005dab16b 100644
--- a/cli/api.py
+++ b/cli/api.py
@@ -47,8 +47,23 @@ def zed_runtime(args: 'Namespace'):
runtime.run_forever()
-# alias
-executor = zed_runtime
+def executor(args: 'Namespace'):
+ """
+ Starts a ZEDRuntime
+
+ :param ar... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} | |
jina-ai__serve-2675@afbe577 | jina-ai/serve | Python | 2,675 | refactor: refactor DocumentArray | **Changes proposed**
Have `DocumentArray` be a `view` over a `List or RepeatedContainer of DocumentProro` instead of over an `iterable` of `Document`.
But from the user perspective return `Document` instead of `DocumentProto` when iterating or accessing elements in it.
**Benefits**
We had to revert #2648 becaus... | 2021-06-16T11:08:39Z | `DocumentArray` inconsistency
**Describe the bug**
`DocumentArray` holds a `view` of a list of different `DocumentViews` that can end up living in the same `Array,_docs_view` elements of the native jina types and `Proto` types. Which can lead to problems when applying functions as `sort`, `map`, etc ...
This also crea... | [
{
"body": "**Describe the bug**\n`DocumentArray` holds a `view` of a list of different `DocumentViews` that can end up living in the same `Array,_docs_view` elements of the native jina types and `Proto` types. Which can lead to problems when applying functions as `sort`, `map`, etc ...\n\nThis also creates the ... | 4a456006666973e128da68a46d2e4ef6829d087e | {
"head_commit": "afbe577d284be8b1752822b99047f1a705b60e38",
"head_commit_message": "Merge branch 'master' of https://github.com/jina-ai/jina into fix-2670",
"patch_to_review": "diff --git a/jina/types/arrays/document.py b/jina/types/arrays/document.py\nindex 7aab3915178ee..c1bc7a26f430d 100644\n--- a/jina/types/... | [
{
"diff_hunk": "@@ -98,24 +107,48 @@ class DocumentArray(\n It gives an efficient view of a list of Document. One can iterate over it like\n a generator but ALSO modify it, count it, get item, or union two 'DocumentArray's using the '+' and '+=' operators.\n \n- :param doc_views: A list of :class:`Do... | 3a01c3f1843842e8d07d883d7504d3d0661d9654 | diff --git a/jina/types/arrays/document.py b/jina/types/arrays/document.py
index 7aab3915178ee..d1c5f9b51bdf1 100644
--- a/jina/types/arrays/document.py
+++ b/jina/types/arrays/document.py
@@ -13,11 +13,13 @@
Optional,
Generator,
BinaryIO,
+ TypeVar,
)
from .traversable import TraversableSequence
... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} | |
jina-ai__serve-2689@f80ef3c | jina-ai/serve | Python | 2,689 | feat: add listview | 2021-06-17T08:49:34Z | need to create a `ListValueView` similar to `StructView` for nested array objects
**Describe the bug**
Nested `array` objects in `tags` or `struct-like` protobuf fields cannot be updated:
```python
>>> from jina import Document
>>> d = Document()
>>> d.tags = {'hey': {'nested': True}, 'hoy': [0, 1]}
>>> d.tags
<jina... | [
{
"body": "**Describe the bug**\n\nNested `array` objects in `tags` or `struct-like` protobuf fields cannot be updated:\n\n```python\n\n>>> from jina import Document\n>>> d = Document()\n>>> d.tags = {'hey': {'nested': True}, 'hoy': [0, 1]}\n>>> d.tags\n<jina.types.struct.StructView hoy=[0.0, 1.0] hey={'nested'... | cb8d40006477acec7376464c5efe533e6b458fd5 | {
"head_commit": "f80ef3cef7fdf94a157f04585af388467bc39491",
"head_commit_message": "Merge branch 'master' of https://github.com/jina-ai/jina into feat-listview",
"patch_to_review": "diff --git a/jina/helper.py b/jina/helper.py\nindex 59e9cefd1209a..59df2f8d6cb46 100644\n--- a/jina/helper.py\n+++ b/jina/helper.py... | [
{
"diff_hunk": "@@ -0,0 +1,64 @@\n+from collections.abc import MutableSequence\n+from typing import Union\n+\n+from google.protobuf import struct_pb2\n+\n+from .mixin import ProtoTypeMixin\n+\n+\n+class ListView(ProtoTypeMixin, MutableSequence):\n+ \"\"\"Create a Python mutable sequence view of Protobuf List... | cb8c58b0f4c3b901d3fadc12a83d57135b7d6b60 | diff --git a/jina/helper.py b/jina/helper.py
index 59e9cefd1209a..59df2f8d6cb46 100644
--- a/jina/helper.py
+++ b/jina/helper.py
@@ -1158,11 +1158,14 @@ def dunder_get(_dict: Any, key: str) -> Any:
except ValueError:
pass
+ from google.protobuf.struct_pb2 import ListValue
from google.protobuf.st... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | ||
jina-ai__serve-3113@85661a9 | jina-ai/serve | Python | 3,113 | feat: match with batching capability | This PR adds batching to `d1.match(d2)` to load `d2` in batches. | 2021-08-05T15:13:01Z | Add batching to match function
It may make sense only for `DocumentArrayMemmap` but it may be applicable to also `DocumentArray`.
The point is to have `batching` for the `Y` (The right hand side of the `match` operation) so that the Y can be loaded in memory in batches | The Draft PR is https://github.com/jina-ai/jina/pull/3113 | [
{
"body": "It may make sense only for `DocumentArrayMemmap` but it may be applicable to also `DocumentArray`.\r\n\r\nThe point is to have `batching` for the `Y` (The right hand side of the `match` operation) so that the Y can be loaded in memory in batches\r\n\r\n",
"number": 3088,
"title": "Add batchin... | 2aee8360ba401a6ed58ae497c47f5f6df6515ff3 | {
"head_commit": "85661a9f6a512c5d8040178c1f305e1f81db9f4e",
"head_commit_message": "fix: add types",
"patch_to_review": "diff --git a/jina/math/helper.py b/jina/math/helper.py\nindex 9381f23a16df0..1c1c5c0343a44 100644\n--- a/jina/math/helper.py\n+++ b/jina/math/helper.py\n@@ -49,3 +49,29 @@ def top_k(\n ... | [
{
"diff_hunk": "@@ -52,29 +53,117 @@ def match(\n all values will be rescaled into range `[a, b]`.\n :param use_scipy: use Scipy as the computation backend\n :param metric_name: if provided, then match result will be marked with this string.\n+ :param batch... | 2ac9c568a651e1063dc19fc4e96310c47bf9e4a3 | diff --git a/jina/math/helper.py b/jina/math/helper.py
index 1b1a9ba3a97a0..bc8e264e52610 100644
--- a/jina/math/helper.py
+++ b/jina/math/helper.py
@@ -67,3 +67,28 @@ def top_k(
values = -values
return values, idx
+
+
+def update_rows_x_mat_best(
+ x_mat_best: 'np.ndarray',
+ x_inds_best: 'np.nda... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
jina-ai__serve-2625@e43f635 | jina-ai/serve | Python | 2,625 | feat: allow different evaluation aggregations | 2021-06-11T07:58:10Z | change MeanEvaluationCallback to EvaluationCallback supporting multiple operations in optimizer
**Describe the feature**
MeanEvaluationCallback is the class used to collect evaluations from FlowRunner runs.
However, it only accepts a single way to collect results into a final metric. We can easily support multiple tim... | [
{
"body": "**Describe the feature**\nMeanEvaluationCallback is the class used to collect evaluations from FlowRunner runs.\n\nHowever, it only accepts a single way to collect results into a final metric. We can easily support multiple times the same way `SimpleAggregateRanker` did\n\n",
"number": 2622,
... | 90dbaaeac37a65493d7f1327a1f673b3de75fff7 | {
"head_commit": "e43f63517b30f57cc3eb3e06886a62d29f8c1845",
"head_commit_message": "Merge branch 'master' of https://github.com/jina-ai/jina into feat-evaluation-callback",
"patch_to_review": "diff --git a/jina/optimizers/__init__.py b/jina/optimizers/__init__.py\nindex 62311baaf57c8..8315f2ca6d183 100644\n--- a... | [
{
"diff_hunk": "@@ -58,31 +60,44 @@ def __call__(self, response):\n raise NotImplementedError\n \n \n-class MeanEvaluationCallback(OptimizerCallback):\n+class EvaluationCallback(OptimizerCallback):\n \"\"\"\n- Calculates the mean of all evaluations during a single :py:class:`FlowRunner`\n- exe... | 6979e41a10ec2c5a09d43dd75618907af3547053 | diff --git a/jina/optimizers/__init__.py b/jina/optimizers/__init__.py
index 62311baaf57c8..33f54c6a74554 100644
--- a/jina/optimizers/__init__.py
+++ b/jina/optimizers/__init__.py
@@ -2,6 +2,7 @@
from collections import defaultdict
from typing import Optional
+import numpy as np
import yaml
from .parameters im... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | ||
jina-ai__serve-2714@9e050ea | jina-ai/serve | Python | 2,714 | feat: pass executor specific params |
┆Issue is synchronized with this [Asana task](https://app.asana.com/0/1200479679796904/1200498158412714) by [Unito](https://www.unito.io)
| 2021-06-21T11:24:57Z | Define parameters on executor level
Assume two encoders share parameter names - like batch_size or traversal_path.
When sending the following request, it is not possible to have different batch sizes or traversal_path for both of the encoders.
```
results = f.post(
on='/search',
parameters={'batch_size': 32}... | This is specially `important` for `public shared executors`, where the user won't have capacity to rewrite its behavior | [
{
"body": "Assume two encoders share parameter names - like batch_size or traversal_path.\nWhen sending the following request, it is not possible to have different batch sizes or traversal_path for both of the encoders.\n\n\n```\nresults = f.post(\n on='/search',\n parameters={'batch_size': 32},\n...\n``... | 80dbd82b2ebe5ef7ffa200294979c785485e8fa7 | {
"head_commit": "9e050ea02047fb4b6539aecea9c0a98ceacc58ab",
"head_commit_message": "test: add integration test",
"patch_to_review": "diff --git a/jina/peapods/runtimes/zmq/zed.py b/jina/peapods/runtimes/zmq/zed.py\nindex 658842c3445d3..cd1de0d5bd5e8 100644\n--- a/jina/peapods/runtimes/zmq/zed.py\n+++ b/jina/peap... | [
{
"diff_hunk": "@@ -0,0 +1,41 @@\n+from typing import Dict\n+\n+from jina import Flow, DocumentArray, Document, Executor, requests\n+from tests import validate_callback\n+\n+\n+class DummyOverrideParams(Executor):\n+ def __init__(self, *args, **kwargs):\n+ super().__init__(*args, **kwargs)\n+\n+ @r... | 42ffe4dc2acebcc9666ff56d40341f8fe90a756a | diff --git a/jina/peapods/runtimes/zmq/zed.py b/jina/peapods/runtimes/zmq/zed.py
index df57a5108d63c..89279f9435477 100644
--- a/jina/peapods/runtimes/zmq/zed.py
+++ b/jina/peapods/runtimes/zmq/zed.py
@@ -172,6 +172,14 @@ def _post_hook(self, msg: 'Message') -> 'ZEDRuntime':
msg.update_timestamp()
ret... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
jina-ai__serve-2627@52359ef | jina-ai/serve | Python | 2,627 | feat: undirected graph | Add user-friendly undirected graph support | 2021-06-11T10:39:23Z | add flag to `GraphProto` to indicate if `graph` is directed or indirected
**Describe the feature**
To be able to distinguish if a `Graph` is directed or undirected we can simply add a flag inside the `GraphProto` defaulting to `directed`.
In case it is indirected, we need to change the `to_dgl_graph` to build an `undi... | [
{
"body": "**Describe the feature**\nTo be able to distinguish if a `Graph` is directed or undirected we can simply add a flag inside the `GraphProto` defaulting to `directed`.\n\nIn case it is indirected, we need to change the `to_dgl_graph` to build an `undirected` graph by adding the `edges` twice (forward a... | 4a456006666973e128da68a46d2e4ef6829d087e | {
"head_commit": "52359efe9ef99121114b5b899fca2329a7e7d049",
"head_commit_message": "feat: add undirected support",
"patch_to_review": "diff --git a/jina/proto/jina.proto b/jina/proto/jina.proto\nindex 69be69ad4a0e9..196d42b8aa2a3 100644\n--- a/jina/proto/jina.proto\n+++ b/jina/proto/jina.proto\n@@ -73,6 +73,7 @@... | [
{
"diff_hunk": "@@ -195,6 +209,9 @@ def remove_edge(self, doc1: 'Document', doc2: 'Document'):\n if row.item() == offset1 and col.item() == offset2:\n self._remove_edge_id(edge_id, f'{doc1.id}-{doc2.id}')\n \n+ if self.undirected:",
"line": null,
"original_line": 2... | d0a297eed353de142c6af74abe7c39b860a61bd6 | diff --git a/jina/__init__.py b/jina/__init__.py
index 9b7e22940f9dc..75e43ae56a731 100644
--- a/jina/__init__.py
+++ b/jina/__init__.py
@@ -37,7 +37,7 @@
# do not change this line manually
# this is managed by proto/build-proto.sh and updated on every execution
-__proto_version__ = '0.0.82'
+__proto_version__ = '0... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
jina-ai__serve-2366@c627d55 | jina-ai/serve | Python | 2,366 | feat: ranker trainer | - [x] executor interface
- [x] driver
- [x] integration test
- [x] docstrings and minor updates | 2021-04-29T15:26:11Z | Implement Executors/Drivers for Ranker Trainers
Implement the `Executors` and `Drivers` interfaces that will receive `TrainRequests` and do an incremental learning step for each request as a `batch`. These executors and drivers will be used for training `Rankers`.
`TrainRequests` already reserved at `types.request.... | [
{
"body": "Implement the `Executors` and `Drivers` interfaces that will receive `TrainRequests` and do an incremental learning step for each request as a `batch`. These executors and drivers will be used for training `Rankers`.\r\n\r\n`TrainRequests` already reserved at `types.request.train`\r\n\r\n- [ ] Train... | 199d54ba2968c4c5d13cd9b3767a219c88b2805c | {
"head_commit": "c627d55f45cea69145cafe65eed273876ca49471",
"head_commit_message": "feat: add sklearn to extra",
"patch_to_review": "diff --git a/extra-requirements.txt b/extra-requirements.txt\nindex 1188c360e854a..4087f578b465d 100644\n--- a/extra-requirements.txt\n+++ b/extra-requirements.txt\n@@ -34,7 +34,7 ... | [
{
"diff_hunk": "@@ -34,7 +34,7 @@ onnx: framework, py37\n onnxruntime: framework, py37\n Pillow: cv, cicd, multimodal\n annoy>=1.9.5: index\n-sklearn: numeric\n+sklearn: numeric, test",
"line": null,... | 6c2af26d4301fe55174068b6a544c9cdf8d81b04 | diff --git a/extra-requirements.txt b/extra-requirements.txt
index 1188c360e854a..fcc59b018d751 100644
--- a/extra-requirements.txt
+++ b/extra-requirements.txt
@@ -34,7 +34,7 @@ onnx: framework, py37
onnxruntime: framework, py37
Pillow: cv, cicd, multimodal
a... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
jina-ai__serve-2581@3ea50c7 | jina-ai/serve | Python | 2,581 | feat: allow optimizer to work on executor alternatives | 2021-06-08T11:10:52Z | unittests for Optimizer
**Describe the feature**
There are no unittests for Optimizers
allow optimizer to have executor class as parameter
**Describe the feature**
Right now, FlowOptimizer only receives a set of parameters that can be updated for a given Flow template. This Flow template is static and does not consi... | [
{
"body": "**Describe the feature**\nThere are no unittests for Optimizers\n\n",
"number": 2574,
"title": "unittests for Optimizer"
},
{
"body": "**Describe the feature**\nRight now, FlowOptimizer only receives a set of parameters that can be updated for a given Flow template. This Flow template... | 0bec2e68e777d511858590feb21ad372e51b5aa0 | {
"head_commit": "3ea50c76eed021c8c5c5a4725e0eb3a86c2c035d",
"head_commit_message": "test: add grid sampler tests",
"patch_to_review": "diff --git a/jina/jaml/__init__.py b/jina/jaml/__init__.py\nindex a0b02c59935b8..3bcbc1cdc61b4 100644\n--- a/jina/jaml/__init__.py\n+++ b/jina/jaml/__init__.py\n@@ -445,7 +445,7 ... | [
{
"diff_hunk": "@@ -0,0 +1,86 @@\n+import json\n+import os\n+\n+import pytest\n+import yaml\n+from google.protobuf.json_format import MessageToJson\n+\n+from jina import Document\n+from jina.jaml import JAML\n+from jina.optimizers import FlowOptimizer, MeanEvaluationCallback\n+from jina.optimizers import run_op... | 8f04fba86b97f2e07e645ae3920e46b4e6e015c3 | diff --git a/jina/jaml/__init__.py b/jina/jaml/__init__.py
index a0b02c59935b8..3bcbc1cdc61b4 100644
--- a/jina/jaml/__init__.py
+++ b/jina/jaml/__init__.py
@@ -445,7 +445,7 @@ def load_config(
*,
allow_py_modules: bool = True,
substitute: bool = True,
- context: Dict[str, Any] = None,... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "Test Suite / CI Enhancements"
} | ||
jina-ai__serve-2565@bec39b1 | jina-ai/serve | Python | 2,565 | refactor: merge grpc and rest client | This PR aims at simplify C/S mode (Flow as service) Jina Python client usage with a uniform facade, before and after:
```python
# before
from jina import Client
from jina.clients import WebsocketClient
client = Client('localhost', 12345) # connect to grpc gateway
client = WebsocketClient('localhost', 12345) #... | 2021-06-05T10:59:10Z | Merge jina restful and grpc client usage
```python
# before
from jina import Client
from jina.clients import WebsocketClient
client = Client('localhost', 12345) # connect to grpc gateway
client = WebsocketClient('localhost', 12345) # connect to restful gateway
# expected
from jina import Client
client = Client('loca... | cc @CatStark | [
{
"body": "```python\n# before\nfrom jina import Client\nfrom jina.clients import WebsocketClient\n\nclient = Client('localhost', 12345) # connect to grpc gateway\nclient = WebsocketClient('localhost', 12345) # connect to restful gateway\n\n# expected\nfrom jina import Client\nclient = Client('localhost', 12345... | 0bec2e68e777d511858590feb21ad372e51b5aa0 | {
"head_commit": "bec39b12bcb1751ce9a6c33a6e34bfd29e09c43e",
"head_commit_message": "feat: add grpc client back to distributed test",
"patch_to_review": "diff --git a/.github/2.0/cookbooks/Flow.md b/.github/2.0/cookbooks/Flow.md\nindex 818cd1b213fad..60c03f9262287 100644\n--- a/.github/2.0/cookbooks/Flow.md\n+++ ... | [
{
"diff_hunk": "@@ -912,7 +914,7 @@ def use_grpc_gateway(self, port: Optional[int] = None):\n \n def _switch_gateway(self, gateway: str, port: int):\n restful = gateway == 'RESTRuntime'\n- client = WebSocketClient if gateway == 'RESTRuntime' else Client\n+ client = WebSocketClient if g... | 68a77d072fc0b9dc09e7e747613c3e51b9380841 | diff --git a/.github/2.0/cookbooks/Flow.md b/.github/2.0/cookbooks/Flow.md
index 818cd1b213fad..582642442f073 100644
--- a/.github/2.0/cookbooks/Flow.md
+++ b/.github/2.0/cookbooks/Flow.md
@@ -717,7 +717,7 @@ c.post('/')
```
```text
- Client@27219[S]:connected to the gateway at 192.168.1.14:12345!
+ ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
jina-ai__serve-2297@e1aea7f | jina-ai/serve | Python | 2,297 | feat: add driver and changes in document needed for sparse pipeline | 2021-04-09T18:43:02Z | Integration tests for all sparse vectors compounds
# Maintenance Ticket
<p></p>
For the four tickets.
1. Allow sparse vectors to be stored
2. Allow NumpyIndexer to handle sparse vectors
3. Create encoder for sparse vectors
4. Create ANN for sparse vectors
<p></p>
A suite of integration tests should be wri... | Link to subfeature: https://jinaai.productboard.com/feature-board/planning/features/7331517
NumpyIndexer should only be considered if changes are minimal | [
{
"body": "# Maintenance Ticket\n\n<p></p>\n\nFor the four tickets. \n\n1. Allow sparse vectors to be stored \n\n2. Allow NumpyIndexer to handle sparse vectors \n\n3. Create encoder for sparse vectors \n\n4. Create ANN for sparse vectors \n\n\n<p></p>\n\nA suite of integration tests should be written to test en... | 37a4b71731eb8fdc3651fbc920c1c149a0359d9d | {
"head_commit": "e1aea7fc59550da6e206891ccb58cc0958a5b09e",
"head_commit_message": "fix: formatting",
"patch_to_review": "diff --git a/jina/drivers/encode.py b/jina/drivers/encode.py\nindex 1e3600ba8a3bd..ee9167a37633d 100644\n--- a/jina/drivers/encode.py\n+++ b/jina/drivers/encode.py\n@@ -34,3 +34,22 @@ def _ap... | [
{
"diff_hunk": "@@ -34,23 +34,23 @@ def encode(self, data: Any, *args, **kwargs) -> Any:\n \n \n class DummyCSRSparseIndexer(BaseSparseVectorIndexer):\n-\n def __init__(self, *args, **kwargs):\n super().__init__(*args, **kwargs)\n self.keys = []\n \n- def add(self, keys: Iterable[str], ve... | 0207fcee50a7c282c979417183d1ca702097d2ac | diff --git a/jina/drivers/encode.py b/jina/drivers/encode.py
index 1e3600ba8a3bd..ee9167a37633d 100644
--- a/jina/drivers/encode.py
+++ b/jina/drivers/encode.py
@@ -34,3 +34,22 @@ def _apply_all(self, docs: 'DocumentSet', *args, **kwargs) -> None:
raise LengthMismatchException(msg)
for doc... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Test Suite / CI Enhancements"
} | |
jina-ai__serve-2218@d814a65 | jina-ai/serve | Python | 2,218 | test: add regression for chatbot | Given a system under test, `test_chatbot` depends on the `index` flow to be fired. While `f.block` blocked the process. I did some search and find the official plugin: [pytest-xprocess](https://github.com/pytest-dev/pytest-xprocess)
> pytest plugin for managing processes across test runs.
This plugin:
1. Boots... | 2021-03-22T02:10:20Z | Regression test for all three hello-world demos
**Describe the feature**
hello-world examples are important, if it breaks for a first-time user, then we lose this user.
The current tests on hello-world is not enough, it does not check (1) if index/search is successful (2) the sanity of retrieved results.
**Yo... | Example for multimodal can be taken from reverted change in #2178. It was reverted for other reasons, but the test would still be valid
glad to work on it with other engineers.
Multimodal helloworld has already been added, please add the other integration tests in the same subfolders
One thing to be aware of.
Adding... | [
{
"body": "**Describe the feature**\r\n\r\nhello-world examples are important, if it breaks for a first-time user, then we lose this user.\r\n\r\nThe current tests on hello-world is not enough, it does not check (1) if index/search is successful (2) the sanity of retrieved results. \r\n\r\n**Your proposal**\r\n... | ba702b49b080157ada804da14b01d07f70c93063 | {
"head_commit": "d814a65cdf174bb7e351843f60c498ff137faaba",
"head_commit_message": "test: remove updates on jinahub",
"patch_to_review": "diff --git a/extra-requirements.txt b/extra-requirements.txt\nindex 9615adea042e1..649ae07f15812 100644\n--- a/extra-requirements.txt\n+++ b/extra-requirements.txt\n@@ -59,6 +... | [
{
"diff_hunk": "@@ -59,6 +59,7 @@ pytest-mock: test\n pytest-cov: test\n pytest-repeat: test\n pytest-asyncio: test\n+pytest-xprocess test",
"line": null,
"original_line": 62,
"original_start_line": null,
"path": "extra-requirem... | 0de3afa9ae588bfbaaf17d85d85e45612b9da140 | diff --git a/extra-requirements.txt b/extra-requirements.txt
index 9615adea042e1..c46b00f2185ed 100644
--- a/extra-requirements.txt
+++ b/extra-requirements.txt
@@ -59,6 +59,7 @@ pytest-mock: test
pytest-cov: test
pytest-repeat: test
pytest-asyncio: test
+pytes... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Test Suite / CI Enhancements"
} |
jina-ai__serve-2037@792b165 | jina-ai/serve | Python | 2,037 | feat: add support for multistage dockerfile | - [x] add support for multistag dockerfile
- [x] refactoring the way of adding labels to the docker images as suggested in #1732 | 2021-02-24T15:38:06Z | Enable the `jina hub build` to use Dockerfile with multi-stage building
**Describe the feature**
Enable the `jina hub build` to use Dockerfile with multi-stage building
**Your proposal**
<!-- copy past your code/pull request link -->
---
<!-- Optional, but really help us locate the problem faster -->
**En... | This issue is stale because it has been open 20 days with no activity. Remove stale label or comment or this will be closed in 4 days | [
{
"body": "**Describe the feature**\r\nEnable the `jina hub build` to use Dockerfile with multi-stage building\r\n\r\n\r\n**Your proposal**\r\n<!-- copy past your code/pull request link -->\r\n\r\n---\r\n<!-- Optional, but really help us locate the problem faster -->\r\n\r\n**Environment**\r\n<!-- Run `jina --v... | f45ec5d01f9c6aafcc6376b11b317debd88bba58 | {
"head_commit": "792b165b4f7eb6fee880c469653a7212a102a31d",
"head_commit_message": "feat: add missing files",
"patch_to_review": "diff --git a/jina/docker/hubio.py b/jina/docker/hubio.py\nindex 53c21942e8f68..ed2f94fa2596e 100644\n--- a/jina/docker/hubio.py\n+++ b/jina/docker/hubio.py\n@@ -309,15 +309,18 @@ def ... | [
{
"diff_hunk": "@@ -309,15 +309,18 @@ def build(self) -> Dict:\n \n with TimeContext(f'building {colored(self.args.path, \"green\")}', self.logger) as tc:\n try:\n- self._check_completeness()\n+ _check_result = self._check_completeness()\n ... | 6cbf0b49abd1c065b6b2ac24b5f86fdda55a171d | diff --git a/jina/docker/hubio.py b/jina/docker/hubio.py
index 53c21942e8f68..9dc82b546ec6e 100644
--- a/jina/docker/hubio.py
+++ b/jina/docker/hubio.py
@@ -309,15 +309,18 @@ def build(self) -> Dict:
with TimeContext(f'building {colored(self.args.path, "green")}', self.logger) as tc:
try... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
jina-ai__serve-2133@6399c2f | jina-ai/serve | Python | 2,133 | fix: avoid dump drivers | Removes `_drivers ` from the `__getstate__` method. This allows executors to be loaded with updated `_drivers` information from `.yml` files. Before this commit the information would be serialised. | 2021-03-09T11:45:21Z | Fix: avoid dumping _drivers in executor serialization
We found out that an app would not work 'as expected' when we indexed and then queried if we changed the `.yml` between index and query time. Essentially the change in the `.yml` file was not taken in consideration when it was loaded. | [
{
"body": "We found out that an app would not work 'as expected' when we indexed and then queried if we changed the `.yml` between index and query time. Essentially the change in the `.yml` file was not taken in consideration when it was loaded.",
"number": 2142,
"title": "Fix: avoid dumping _drivers in... | 06ebc5cefcdb986340d2d8ba722a16f8e7b4a0b9 | {
"head_commit": "6399c2f1fce98c13a324f1a1888c871d8e0af207",
"head_commit_message": "fix: modifications done by black",
"patch_to_review": "diff --git a/jina/executors/__init__.py b/jina/executors/__init__.py\nindex e3e4beb3189e2..d78f7f2a6736c 100644\n--- a/jina/executors/__init__.py\n+++ b/jina/executors/__init... | [
{
"diff_hunk": "@@ -27,37 +27,59 @@\n from ..peapods.runtimes.zmq.zed import ZEDRuntime\n from ..drivers import BaseDriver\n \n-__all__ = ['BaseExecutor', 'AnyExecutor', 'ExecutorType']\n+__all__ = [\"BaseExecutor\", \"AnyExecutor\", \"ExecutorType\"]",
"line": null,
"original_line": 30,
"or... | fa3e856af12d48ebf9bde1c6119fb0d08e17a08c | diff --git a/jina/executors/__init__.py b/jina/executors/__init__.py
index e3e4beb3189e2..1d9eef0747059 100644
--- a/jina/executors/__init__.py
+++ b/jina/executors/__init__.py
@@ -1,5 +1,5 @@
-__copyright__ = "Copyright (c) 2020 Jina AI Limited. All rights reserved."
-__license__ = "Apache-2.0"
+__copyright__ = 'Copyr... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
jina-ai__serve-1802@c529e72 | jina-ai/serve | Python | 1,802 | feat: add Python 3.9 support | closes #1253 | 2021-01-27T14:50:25Z | add Python 3.9 support
**Describe the feature**
Jina can not run on Python 3.9. We need community support on this to point out the issues, the out-of-date dependencies on Python 3.9.
**Your proposal**
@alexcg1 as a kick-off, can you add your log here?
---
<!-- Optional, but really help us locate the proble... | https://github.com/jina-ai/jina/issues/1250#issue-739099324
On running `jina hello-world` on jina 0.7.12 on mac. `jina -vf` also fails
```
/opt/miniconda3/envs/test/lib/python3.9/site-packages/jina/importer.py:130: UserWarning: theses modules or classes can not be imported ['jina.drivers.evaluate', 'jina.drivers.en... | [
{
"body": "**Describe the feature**\r\n\r\nJina can not run on Python 3.9. We need community support on this to point out the issues, the out-of-date dependencies on Python 3.9.\r\n\r\n**Your proposal**\r\n\r\n@alexcg1 as a kick-off, can you add your log here?\r\n\r\n---\r\n<!-- Optional, but really help us loc... | 994c13fee4362bb367475ed6fd5e9dbf4e4a4de0 | {
"head_commit": "c529e729dd1e9e8dc4bf1049d943185c7d0ee75b",
"head_commit_message": "feat: add Python 3.9 support",
"patch_to_review": "diff --git a/.github/badges/python-badge.svg b/.github/badges/python-badge.svg\nindex 13130f1386bd0..fabbe247e94cc 100644\n--- a/.github/badges/python-badge.svg\n+++ b/.github/ba... | [
{
"diff_hunk": "@@ -6,7 +6,7 @@ An easier way to build neural search in the cloud\n </p>\n <p align=center>\n <a href=\"#license\"><img src=\"https://github.com/jina-ai/jina/blob/master/.github/badges/license-badge.svg?raw=true\" alt=\"Jina\" title=\"Jina is licensed under Apache-2.0\"></a>\n-<a href=\"https://... | 5c6dfdc24d56e4aece543de0b2433b232bf0bb95 | diff --git a/.github/badges/python-badge.svg b/.github/badges/python-badge.svg
index 13130f1386bd0..fabbe247e94cc 100644
--- a/.github/badges/python-badge.svg
+++ b/.github/badges/python-badge.svg
@@ -1 +1 @@
-<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" width="125" height="20"><li... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Dependency Updates & Env Compatibility"
} |
jina-ai__serve-1933@8747d75 | jina-ai/serve | Python | 1,933 | refactor: move queryset from drivers to types | **Changes introduced**
Move QuerySet logic to `types` so that it can be made a regular way of accessing Documents and other primitive types `attributes`.
Plan to use this change in #1718.
| 2021-02-12T08:23:34Z | dunderkey logic should be moved to Types
#**Describe the bug**
Right now we use dunder_key heavily in our QueryLanguage but we also profit from its features and syntax from the Types module.
This opens the door to potential cyclic dependencies and should be addressed. Types should not depend on other modules except... | This issue is stale because it has been open 20 days with no activity. Remove stale label or comment or this will be closed in 4 days | [
{
"body": "#**Describe the bug**\r\nRight now we use dunder_key heavily in our QueryLanguage but we also profit from its features and syntax from the Types module.\r\n\r\nThis opens the door to potential cyclic dependencies and should be addressed. Types should not depend on other modules except .proto and Driv... | 788ef6767879d2db79e2e7fccbfa2c79291ddcc4 | {
"head_commit": "8747d75e7d6a1bdbc966e2dee6454a0105aeb715",
"head_commit_message": "refactor: move queryset from drivers to types",
"patch_to_review": "diff --git a/jina/drivers/control.py b/jina/drivers/control.py\nindex 1c32aa4b467f4..6201c08451623 100644\n--- a/jina/drivers/control.py\n+++ b/jina/drivers/cont... | [
{
"diff_hunk": "@@ -6,7 +6,7 @@\n from google.protobuf.json_format import MessageToJson\n \n from . import BaseDriver\n-from .querylang.queryset.dunderkey import dunder_get\n+from jina.types.querylang.queryset.dunderkey import dunder_get",
"line": null,
"original_line": 9,
"original_start_line": nul... | 68f8d4c6f2d8e4d855276e5aa097582d4e73ded3 | diff --git a/jina/drivers/control.py b/jina/drivers/control.py
index 1c32aa4b467f4..24f0b28811873 100644
--- a/jina/drivers/control.py
+++ b/jina/drivers/control.py
@@ -6,7 +6,7 @@
from google.protobuf.json_format import MessageToJson
from . import BaseDriver
-from .querylang.queryset.dunderkey import dunder_get
+f... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Code Refactoring / Architectural Improvement"
} |
jina-ai__serve-2347@130152b | jina-ai/serve | Python | 2,347 | test: compound pod sockets | testing the socket configuration of the compound pod
closes https://github.com/jina-ai/jina/issues/2348 | 2021-04-25T14:50:49Z | Add unittests of CompoundPod showing ports/hosts and sockets configuration
**Describe the feature**
Add a unittest in `CompoundPod` to test heavily which ports/hosts/socket configurations are set.
Right now, The argument parsing of these components is not so clean, and having such a test, would help refactoring in ... | [
{
"body": "**Describe the feature**\r\nAdd a unittest in `CompoundPod` to test heavily which ports/hosts/socket configurations are set.\r\n\r\nRight now, The argument parsing of these components is not so clean, and having such a test, would help refactoring in a safer way in the future",
"number": 2337,
... | 0fcfcf285db2766ed57ea65f4fe1d2b473e000d1 | {
"head_commit": "130152be4c0fe28397c43c2034881b87a2a49650",
"head_commit_message": "test: compound pod sockets",
"patch_to_review": "diff --git a/tests/unit/peapods/pods/test_compound_pods.py b/tests/unit/peapods/pods/test_compound_pods.py\nindex a05f54ace5852..f56207e6dcbf6 100644\n--- a/tests/unit/peapods/pods... | [
{
"diff_hunk": "@@ -162,3 +163,65 @@ def test_pod_naming_with_parallel(runtime):\n assert bp.replica_list[2].peas[1].runtime.name == 'pod/2/tail/ZEDRuntime'\n assert bp.replica_list[2].peas[2].runtime.name == 'pod/2/0/ZEDRuntime'\n assert bp.replica_list[2].peas[3].runtime.name == 'pod/2... | 92b954effad43f238fc1d9584403ec0a0208739f | diff --git a/tests/unit/peapods/pods/test_compound_pods.py b/tests/unit/peapods/pods/test_compound_pods.py
index f1e7333d5ffe2..147f59b9f145e 100644
--- a/tests/unit/peapods/pods/test_compound_pods.py
+++ b/tests/unit/peapods/pods/test_compound_pods.py
@@ -1,7 +1,8 @@
import pytest
+from jina.enums import SchedulerT... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Test Suite / CI Enhancements"
} | |
jina-ai__serve-2207@10af7af | jina-ai/serve | Python | 2,207 | feat: support for sparse arrays in documents | This PR wants to complete sparse support, as discussed in #2182 . | 2021-03-18T14:35:03Z | Allow sparse vectors to be supported by Jina Primitive Data Types
# Feature Request
This ticket is a sub compound of implementing sparse vector functionality to Jina. Currently, there is some low-level code implementation to support sparse vectors. Over the course of this epic we will implement the remaining logic. M... | Link to subfeature: https://jinaai.productboard.com/feature-board/planning/features/7331485 | [
{
"body": "# Feature Request\n\nThis ticket is a sub compound of implementing sparse vector functionality to Jina. Currently, there is some low-level code implementation to support sparse vectors. Over the course of this epic we will implement the remaining logic. Main goal is to be able to build a fully neura... | 2be26c6dcc0cff897cb99d0eb29258338c5b86ca | {
"head_commit": "10af7aff02fe7de495b846dd3795f456026f0baa",
"head_commit_message": "fix: update format",
"patch_to_review": "diff --git a/jina/types/document/__init__.py b/jina/types/document/__init__.py\nindex 12475263bb4a5..dcd3b928e2fdb 100644\n--- a/jina/types/document/__init__.py\n+++ b/jina/types/document/... | [
{
"diff_hunk": "@@ -492,6 +494,15 @@ def _update_ndarray(self, k, v):\n elif isinstance(v, NdArray):\n NdArray(getattr(self._pb_body, k)).is_sparse = v.is_sparse\n NdArray(getattr(self._pb_body, k)).value = v.value\n+ elif scipy.sparse.issparse(v) == True:",
"line": nu... | 7cfd85759b82b0f30b9f6d1ad2e85b4284f95736 | diff --git a/jina/types/document/__init__.py b/jina/types/document/__init__.py
index fdcdfac7b9030..c0a05406ef64c 100644
--- a/jina/types/document/__init__.py
+++ b/jina/types/document/__init__.py
@@ -27,6 +27,7 @@
from ...logging import default_logger
from ...proto import jina_pb2
+
__all__ = ['Document', 'Docume... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
jina-ai__serve-1759@710e04b | jina-ai/serve | Python | 1,759 | refactor: avoid import drivers from types | 2021-01-22T12:54:18Z | QueryLang instantiation with Driver instance
**Describe the bug**
When instantiating a QueryLang primitive type from a `BaseDriver` instance, we take all the parameters of that instance, and before moving to primitive types, `QueryLang` intention was to override just a single parameter.
I think this is confusing an... | This issue is stale because it has been open 20 days with no activity. Remove stale label or comment or this will be closed in 4 days
This issue is stale because it has been open 20 days with no activity. Remove stale label or comment or this will be closed in 4 days | [
{
"body": "**Describe the bug**\r\nWhen instantiating a QueryLang primitive type from a `BaseDriver` instance, we take all the parameters of that instance, and before moving to primitive types, `QueryLang` intention was to override just a single parameter.\r\n\r\nI think this is confusing and can lead to unexpe... | e29734b317f2ea229264873be74d767838504fea | {
"head_commit": "710e04bb496e1f2ae146c313bc4e9764db183863",
"head_commit_message": "Merge branch 'master' of github.com:jina-ai/jina into refactor-decouple-types-drivers",
"patch_to_review": "diff --git a/jina/clients/request.py b/jina/clients/request.py\nindex 48819e5995d9e..2709225aad2f3 100644\n--- a/jina/cli... | [
{
"diff_hunk": "@@ -32,31 +31,29 @@ class QueryLang:\n from jina.drivers.querylang.slice import SliceQL\n \n s = SliceQL(start=3, end=4)\n- ql = QueryLang(s)\n+ ql = QueryLang('SliceQL', 1, {'start': 3, 'end': 1, 'priority': 1})\n+\n+ .. warning::\n+ The `... | 74f8c9a330b86245cfda3383f33ac7394c835da7 | diff --git a/jina/clients/request.py b/jina/clients/request.py
index 48819e5995d9e..442babdc19499 100644
--- a/jina/clients/request.py
+++ b/jina/clients/request.py
@@ -112,11 +112,8 @@ def search(*args, **kwargs):
"""Generate a searching request """
if ('top_k' in kwargs) and (kwargs['top_k'] is not None):
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
jina-ai__serve-1762@45e7665 | jina-ai/serve | Python | 1,762 | fix(importer): fix jina check | resolved #1526
- [x] Add unit tests for mocking the loading errors in `import_module`
- [x] Refactor the `import_classes` to improve the readability
- [x] Remove the unused `targets` argument from `import_classes`. The only usage of `targets`argument is removed in #1759 | 2021-01-22T15:37:35Z | `jina check` is broken
**Describe the bug**
jina check can not detect any broken hub executors even though they are warned during *first* imports.
**Describe how you solve it**
Maybe something related to the import orders in `jina/__init__.py`
---
<!-- Optional, but really help us locate the problem fast... | This issue is stale because it has been open 20 days with no activity. Remove stale label or comment or this will be closed in 4 days
need someone to address this important ticket, @nan-wang can you make sure at least we have a test for it? | [
{
"body": "**Describe the bug**\r\n\r\njina check can not detect any broken hub executors even though they are warned during *first* imports.\r\n\r\n**Describe how you solve it**\r\n\r\nMaybe something related to the import orders in `jina/__init__.py`\r\n\r\n---\r\n\r\n<!-- Optional, but really help us locate ... | 8a93fb0894e3cf9b3f40aa51cc4220290b0b0afe | {
"head_commit": "45e76659512b8b10b25977b19e3f4a7ba3ecd9cc",
"head_commit_message": "refactor: clean up import_class",
"patch_to_review": "diff --git a/jina/importer.py b/jina/importer.py\nindex e6c317a6717c1..e9931e9cb6c8a 100644\n--- a/jina/importer.py\n+++ b/jina/importer.py\n@@ -11,6 +11,72 @@\n IMPORTED.hub ... | [
{
"diff_hunk": "@@ -26,62 +92,32 @@ def import_classes(namespace: str, targets=None,\n \n import os, re\n \n- if namespace == 'jina.executors':\n- import_type = 'ExecutorType'\n- if import_once and IMPORTED.executors:\n- return\n- elif namespace == 'jina.drivers':\n- im... | c2f43b5ffb7c70cfadef0dc706cbeef5e8dcc984 | diff --git a/jina/checker.py b/jina/checker.py
index 5253ec3b5e425..338726d848515 100644
--- a/jina/checker.py
+++ b/jina/checker.py
@@ -29,7 +29,7 @@ def __init__(self, args: 'argparse.Namespace'):
_r = import_classes('jina.hub', show_import_table=True, import_once=False)
- if args.summary_exec:
+ ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
jina-ai__serve-1580@d6f140c | jina-ai/serve | Python | 1,580 | refactor(logs): remove legacy SSE logserver from core | ## Breaking Change #1606
`jinad` and `fluentd` logger have been there for quite a while, yet there is no clue they work with dashboard.
I'm leaving this PR here to push the progress a bit and clarify the scope. This PR removes the legacy SSE logger completely from the core, **breaking** the connection between t... | 2021-01-03T10:17:23Z | use jinad for logging and communicating with dashboard
**Describe your proposal/problem**
I have never really see how fluentd works in practice. This makes me doubt the completeness of the old ticket on logging.
High priority. Must be done before 1.0, the hello-world with dashboard example must use fluentd as the... | [
{
"body": "**Describe your proposal/problem**\r\n\r\nI have never really see how fluentd works in practice. This makes me doubt the completeness of the old ticket on logging.\r\n\r\nHigh priority. Must be done before 1.0, the hello-world with dashboard example must use fluentd as the logging source.\r\n\r\nTo m... | b77a56d88b7ed350c17ee4ed877d35216a2b8217 | {
"head_commit": "d6f140cf5514664221fab64373c95c64ead515e1",
"head_commit_message": "refactor: remove sse logger",
"patch_to_review": "diff --git a/.github/workflows/cd.yml b/.github/workflows/cd.yml\nindex 25dcfc32615ac..d36f73f03fd9a 100644\n--- a/.github/workflows/cd.yml\n+++ b/.github/workflows/cd.yml\n@@ -22... | [
{
"diff_hunk": "@@ -82,10 +82,10 @@ def document_generator(num_docs, num_chunks, num_chunks_chunks):\n yield doc\n \n \n-@pytest.mark.parametrize('request_batch_size', [5, 100, 500])\n+@pytest.mark.parametrize('request_batch_size', [8, 16, 32])\n @pytest.mark.parametrize('driver_batch_size', [8, 16, 64]... | df50926d09437b75d21592dcddf70eb6eab534bc | diff --git a/.github/workflows/cd.yml b/.github/workflows/cd.yml
index 25dcfc32615ac..d36f73f03fd9a 100644
--- a/.github/workflows/cd.yml
+++ b/.github/workflows/cd.yml
@@ -22,6 +22,7 @@ jobs:
- uses: actions/checkout@v2
with:
submodules: true
+ fetch-depth: 100
- run: |
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
jina-ai__serve-1256@2f495e3 | jina-ai/serve | Python | 1,256 | style: use f-strings instead of %s-formatting | Closes #1240
- tested by running various examples
- used PyCharm automatic replace f-string. This worked in most cases. Some required manual rewriting | 2020-11-10T10:35:49Z | replace `'%s'` with new string formatting f`{var}` with best reasonable effort
**Describe your problem**
##Good first issue##
In the current codebase, there are two types of string formating, would be nice to replace `'%s'` with new string formatting f`{var}` with the best reasonable effort.
**What is your gue... | [
{
"body": "**Describe your problem**\r\n\r\n##Good first issue##\r\n\r\nIn the current codebase, there are two types of string formating, would be nice to replace `'%s'` with new string formatting f`{var}` with the best reasonable effort.\r\n\r\n**What is your guess?**\r\n<!-- Do you have a guess where the prob... | 8b324ab96e6abc6133768163ea576ed4ac5836f8 | {
"head_commit": "2f495e328e6916e4600d9007c088e1a5f20a27f5",
"head_commit_message": "style: use f-strings instead of %s-formatting",
"patch_to_review": "diff --git a/jina/__init__.py b/jina/__init__.py\nindex fb61c353402df..2b9aaaf8842d1 100644\n--- a/jina/__init__.py\n+++ b/jina/__init__.py\n@@ -15,7 +15,7 @@\n ... | [
{
"diff_hunk": "@@ -73,7 +73,7 @@ class DummyClass:\n assert type(a) == DummyClass\n \n with open(resource_filename('jina',\n- '/'.join(('resources', 'executors.requests.%s.yml' % 'BaseExecutor')))) as fp:\n+ '/'.join(('resources', f'executor... | 59a9a01e87f118d2aa3dd2bbac00c4242a043347 | diff --git a/jina/__init__.py b/jina/__init__.py
index fb61c353402df..2b9aaaf8842d1 100644
--- a/jina/__init__.py
+++ b/jina/__init__.py
@@ -15,7 +15,7 @@
# do some os-wise patches
if sys.version_info < (3, 7, 0):
- raise OSError('Jina requires Python 3.7 and above, but yours is %s' % sys.version_info)
+ rais... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Code Style, Linting, Formatting Fixes"
} | |
jina-ai__serve-1187@a237eb0 | jina-ai/serve | Python | 1,187 | fix: rely on control request to set ready docker pea | **Changes introduced**
Instead of relying on reading messages from the logs to set ready signal to the Pod, it relies in network connection with the Pea running inside docker.
To ensure that the PretrainedModelException is properly passed when building executors in the hub, we are still basing ourselves on reading ... | 2020-10-29T17:42:22Z | Find a better way of communication between `ContainerPea` and `BasePea`
**Describe the feature**
Right now `BasePea` only knows when `ContainerPea` is ready (or any other needed communication by reading a specific message in its logstream).
This logic is really fragile and we should find a better way of communicati... | control port is reserved for this purpose
Then it should be used to communicate that Pea is ready, instead of reading from the logs a specific message. In the code seems that no clear way was found at the time it was implemented
I guess this is because ctrl port use ipc protocol by default, which is not container-pass-... | [
{
"body": "**Describe the feature**\r\nRight now `BasePea` only knows when `ContainerPea` is ready (or any other needed communication by reading a specific message in its logstream).\r\n\r\nThis logic is really fragile and we should find a better way of communicating with the `ContainerPea` to have a reliable w... | d948339ddc407fe81780a0df50d9c0362dab24e3 | {
"head_commit": "a237eb04185af1e539117dc6e324e3b969b9bd1e",
"head_commit_message": "fix: rely on control request to set ready docker pea",
"patch_to_review": "diff --git a/jina/peapods/container.py b/jina/peapods/container.py\nindex 7b41c82da8d4e..cf7a2b6f7036a 100644\n--- a/jina/peapods/container.py\n+++ b/jina... | [
{
"diff_hunk": "@@ -109,6 +112,18 @@ def loop_teardown(self):\n if getattr(self, '_client', None):\n self._client.close()\n \n+ @property\n+ def status(self):\n+ \"\"\"Send the control signal ``STATUS`` to itself and return the status \"\"\"\n+ if getattr(self, 'ctrl_addr... | 683b98624525d06f04f94860e697ad7b7b54ddac | diff --git a/jina/peapods/container.py b/jina/peapods/container.py
index 7b41c82da8d4e..bb68f5ae095f7 100644
--- a/jina/peapods/container.py
+++ b/jina/peapods/container.py
@@ -2,9 +2,13 @@
__license__ = "Apache-2.0"
import os
+import asyncio
+
from pathlib import Path
from .pea import BasePea
+from .zmq import... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
jina-ai__serve-1288@364d956 | jina-ai/serve | Python | 1,288 | feat: add needs_all() | Address https://github.com/jina-ai/jina/issues/1262
1. Add needs_all() to collect all hanging pods so far as a sugary syntax for .needs(['h1', 'h2', ...]), .needs_all() can be used at any part of the Flow.
2. add test_flow_needs_all() in unit test test_flow.py | 2020-11-16T03:28:53Z | add a sugary Flow API: needs_all()
**Describe the feature**
Expected behaviors:
- `Flow()....needs_all()` collect all hanging Pod so far, it is a sugary syntax for `.needs(['h1', 'h2', ...])`
- Like `.needs()`, `.needs_all()` can be used at any part of the Flow
- All other behaviors follow `needs()`
Hanging Po... | [
{
"body": "**Describe the feature**\r\n\r\nExpected behaviors:\r\n- `Flow()....needs_all()` collect all hanging Pod so far, it is a sugary syntax for `.needs(['h1', 'h2', ...])`\r\n- Like `.needs()`, `.needs_all()` can be used at any part of the Flow\r\n- All other behaviors follow `needs()`\r\n\r\nHanging Pods... | 45698b33c497f9851b6557bcc0c0a5ae86f8b753 | {
"head_commit": "364d956affcbd92209a75a15f17c68ee8b34950a",
"head_commit_message": "test: add needs_all() unit test",
"patch_to_review": "diff --git a/jina/flow/__init__.py b/jina/flow/__init__.py\nindex f55d34af57807..0cfa6264befae 100644\n--- a/jina/flow/__init__.py\n+++ b/jina/flow/__init__.py\n@@ -251,6 +251... | [
{
"diff_hunk": "@@ -251,6 +251,19 @@ def needs(self, needs: Union[Tuple[str], List[str]],\n raise FlowTopologyError('no need to wait for a single service, need len(needs) > 1')\n return self.add(name=name, needs=needs, pod_role=PodRoleType.JOIN, *args, **kwargs)\n \n+ def needs_all(self, ... | 8e0f393f2a004e4b403d7410687dd41931e16524 | diff --git a/jina/flow/__init__.py b/jina/flow/__init__.py
index f55d34af57807..2602b929871b0 100644
--- a/jina/flow/__init__.py
+++ b/jina/flow/__init__.py
@@ -251,6 +251,19 @@ def needs(self, needs: Union[Tuple[str], List[str]],
raise FlowTopologyError('no need to wait for a single service, need len(need... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
jina-ai__serve-1168@37b9554 | jina-ai/serve | Python | 1,168 | fix: disabled pip cache in docker | Describe the bug
All of our hub docker containers contain pip cache which increases its size. This cache is useless.
Describe how you solve it
Add these to our jina dockerfiles. This will lead to smaller jina and hub images especially those with big dependencies like tensorflow and torch. This way we don't need to... | 2020-10-27T06:08:52Z | fix: disable pip cache in docker
**Describe the bug**
All of our docker containers contain pip cache which increases its size. This cache is useless.
**Describe how you solve it**
Add these to our jina debianx dockerfile. This will lead to smaller jina and hub images especially those with big dependencies like ten... | [
{
"body": "**Describe the bug**\r\nAll of our docker containers contain pip cache which increases its size. This cache is useless.\r\n\r\n**Describe how you solve it**\r\nAdd these to our jina debianx dockerfile. This will lead to smaller jina and hub images especially those with big dependencies like tensorflo... | 521436c17a3a807bb47c020a4527b209651624c4 | {
"head_commit": "37b955470d6d9b89068e945f36a3063426f8cd97",
"head_commit_message": "fix: disabled pip cache in docker",
"patch_to_review": "diff --git a/Dockerfiles/alpinex.Dockerfile b/Dockerfiles/alpinex.Dockerfile\nindex 5fc49ca5528ba..84e5369ce7847 100644\n--- a/Dockerfiles/alpinex.Dockerfile\n+++ b/Dockerfi... | [
{
"diff_hunk": "@@ -23,11 +23,13 @@ ADD cli ./cli/\n ADD jina ./jina/\n \n ENV PYTHONPATH=$PYTHONPATH:/usr/lib/python3.8/dist-packages:/usr/local/lib/python3.8/site-packages:/usr/lib/python3/dist-packages:/usr/local/lib/python3/site-packages\n+ENV PIP_NO_CACHE_DIR=1",
"line": null,
"original_line": 26,
... | 0792eacfb5084eddfa8067bc9a6f44414039b1a5 | diff --git a/Dockerfiles/alpinex.Dockerfile b/Dockerfiles/alpinex.Dockerfile
index 5fc49ca5528ba..520d0745e8964 100644
--- a/Dockerfiles/alpinex.Dockerfile
+++ b/Dockerfiles/alpinex.Dockerfile
@@ -22,12 +22,14 @@ ADD setup.py MANIFEST.in requirements.txt extra-requirements.txt README.md ./
ADD cli ./cli/
ADD jina ./j... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} | |
jina-ai__serve-531@4fa99d7 | jina-ai/serve | Python | 531 | fix the bug in query with faiss | resolves #530 | 2020-06-16T15:40:24Z | the training function is missing in the Faiss Indexer
**Describe the bug**
the index object initialized by `faiss.index_factory()` should be trained before loading the indexed data.
**Describe how you solve it**
- implement the `train()` function for `FaissIndexer`
---
<!-- Optional, but really help us loca... | note that this is not unnecessarily true. as not all indexer in faiss need to be pretrained. | [
{
"body": "**Describe the bug**\r\nthe index object initialized by `faiss.index_factory()` should be trained before loading the indexed data. \r\n\r\n**Describe how you solve it**\r\n- implement the `train()` function for `FaissIndexer`\r\n\r\n---\r\n\r\n<!-- Optional, but really help us locate the problem fast... | 65b150a2bede718815c564ba56ed295e0623715f | {
"head_commit": "4fa99d7fcd57e423c50fbd570cba7798d6207139",
"head_commit_message": "fix: clean up imports",
"patch_to_review": "diff --git a/jina/executors/indexers/vector/faiss.py b/jina/executors/indexers/vector/faiss.py\nindex 0aeabcd95fea7..e7b64ac7f8a65 100644\n--- a/jina/executors/indexers/vector/faiss.py\... | [
{
"diff_hunk": "@@ -12,35 +12,73 @@ class FaissIndexer(NumpyIndexer):\n \"\"\"Faiss powered vector indexer\n \n For more information about the Faiss supported parameters and installation problems, please consult:\n- - https://github.com/spotify/annoy\n - https://github.com/facebookresearc... | d970b118413bb8f433c3dba9cd6cee33578fc9f5 | diff --git a/jina/executors/indexers/vector/faiss.py b/jina/executors/indexers/vector/faiss.py
index 0aeabcd95fea7..aae99ecf8984b 100644
--- a/jina/executors/indexers/vector/faiss.py
+++ b/jina/executors/indexers/vector/faiss.py
@@ -12,35 +12,93 @@ class FaissIndexer(NumpyIndexer):
"""Faiss powered vector indexer
... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
jina-ai__serve-750@d18aab8 | jina-ai/serve | Python | 750 | fix: test random_port | resolves #741 | 2020-07-31T08:51:07Z | add retry mechanism for port conflicts
**Describe the bug**
The zmq ports conflict in some cases.
```
2020-07-29T16:56:40.0807186Z File "/home/runner/work/jina/jina/jina/peapods/zmq.py", line 142, in init_sockets
2020-07-29T16:56:40.0807474Z in_sock, in_addr = _init_socket(ctx, self.args.host_in, self.args... | warning, this is not as easy as "change to another port and retry". The Flow has no clue about the port-change at Pea/Pod level and has no way but to re-orchestrate the whole stack.
non-trivial
> warning, this is not as easy as "change to another port and retry". The Flow has no clue about the port-change at Pe... | [
{
"body": "**Describe the bug** \r\nThe zmq ports conflict in some cases.\r\n\r\n```\r\n2020-07-29T16:56:40.0807186Z File \"/home/runner/work/jina/jina/jina/peapods/zmq.py\", line 142, in init_sockets\r\n2020-07-29T16:56:40.0807474Z in_sock, in_addr = _init_socket(ctx, self.args.host_in, self.args.port_in... | 16881508e8df6197f7cc69454dd6217a84b1828f | {
"head_commit": "d18aab83abd38cae111c33a9a6d2da31cb191533",
"head_commit_message": "fix: clean up",
"patch_to_review": "diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml\nindex a5c44ce37fc23..f03dba8e06464 100644\n--- a/.github/workflows/ci.yml\n+++ b/.github/workflows/ci.yml\n@@ -69,7 +69,7 @@ jo... | [
{
"diff_hunk": "@@ -260,20 +260,33 @@ def random_name() -> str:\n \n \n def random_port() -> int:\n+ from contextlib import closing\n+ import socket\n if 'JINA_RANDOM_PORTS' not in os.environ:\n # feel like this gives higher chance of collision in unit test\n- from contextlib import clo... | 8cc1e2203916ce318eb7caa527ee4751a46109a2 | diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index a5c44ce37fc23..f03dba8e06464 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -69,7 +69,7 @@ jobs:
jina check
export JINA_LOG_VERBOSITY="ERROR"
pip install pytest pytest-xdist pytest-timeout py... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
jina-ai__serve-406@2370dd6 | jina-ai/serve | Python | 406 | fix(transformer): fix cls embedding | 2020-05-10T02:09:03Z | nlp transformer cls token embedding just support two model names in transformers hub
**Describe the bug**
<!-- A clear and concise description of what the bug is. -->
this code in `BaseTransformerEncoder`:
```
if self.pooling_strategy == 'cls':
if self.model_name in ('bert-base-uncased', 'roberta-base'):
... | [
{
"body": "**Describe the bug**\r\n<!-- A clear and concise description of what the bug is. -->\r\nthis code in `BaseTransformerEncoder`:\r\n```\r\nif self.pooling_strategy == 'cls':\r\n if self.model_name in ('bert-base-uncased', 'roberta-base'):\r\n output = self.tensor2array(extra_output[0])\r\n ... | 2820286360ad40b4b706488559e713272575c63a | {
"head_commit": "2370dd6b046d7cc7ca14f98055a967e22200bb96",
"head_commit_message": "fix(transformer): fix cls embedding",
"patch_to_review": "diff --git a/jina/executors/encoders/nlp/transformer.py b/jina/executors/encoders/nlp/transformer.py\nindex 90ad965c4272f..a4ed36263ea33 100644\n--- a/jina/executors/encod... | [
{
"diff_hunk": "@@ -94,6 +94,9 @@ def post_init(self):\n self._sess_func = None\n self.tmp_model_path = self.model_abspath if os.path.exists(self.model_abspath) else self.model_name\n self._tokenizer = self.get_tokenizer()\n+\n+ self._has_cls_token = True if getattr(self._tokenize... | 482ed876dcdce0d3003800b134ab1ed3960d5e48 | diff --git a/jina/executors/encoders/nlp/transformer.py b/jina/executors/encoders/nlp/transformer.py
index 90ad965c4272f..0305a74c39708 100644
--- a/jina/executors/encoders/nlp/transformer.py
+++ b/jina/executors/encoders/nlp/transformer.py
@@ -65,7 +65,7 @@ def encode(self, data: 'np.ndarray', *args, **kwargs) -> 'np.... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | ||
jina-ai__serve-381@bbbb9e7 | jina-ai/serve | Python | 381 | fix(logging): fix success level message | 2020-05-06T10:42:56Z | success level bug doesn't work well
**Describe the bug**
<!-- A clear and concise description of what the bug is. -->
when I set `ERROR` as logging level, the `SUCCESS` level message still appeared.
**Describe how you solve it**
<!-- copy past your code/pull request link -->
---
<!-- Optional, but really hel... | [
{
"body": "**Describe the bug**\r\n<!-- A clear and concise description of what the bug is. -->\r\nwhen I set `ERROR` as logging level, the `SUCCESS` level message still appeared. \r\n**Describe how you solve it**\r\n<!-- copy past your code/pull request link -->\r\n\r\n---\r\n\r\n<!-- Optional, but really help... | 0d8d89242123a043761093b35f74ba603e4172c7 | {
"head_commit": "bbbb9e7161ef9905d1b2930029c038a687f615db",
"head_commit_message": "fix(logging): fix success level message",
"patch_to_review": "diff --git a/jina/logging/base.py b/jina/logging/base.py\nindex e58d1e4bbd0d1..0d17493c79cd7 100644\n--- a/jina/logging/base.py\n+++ b/jina/logging/base.py\n@@ -112,7 ... | [
{
"diff_hunk": "@@ -224,8 +224,8 @@ def get_logger(context: str, context_len: int = 15,\n console_handler.setFormatter(ColorFormatter(fmt_str))\n logger.addHandler(console_handler)\n \n- logging.SUCCESS = 25 # between WARNING and INFO\n- logging.addLevelName(logging.SUCCESS, 'SUCCESS')\n- seta... | bea55a59708ea9a3b6b43ee8e92bbc21b0edff73 | diff --git a/jina/logging/base.py b/jina/logging/base.py
index e58d1e4bbd0d1..7cd6d2ea123e4 100644
--- a/jina/logging/base.py
+++ b/jina/logging/base.py
@@ -112,7 +112,7 @@ def info(self, msg: str, **kwargs):
sys.stdout.write('I:%s:%s' % (self.context, self._planify(msg)))
def critical(self, msg: st... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} | ||
modin-project__modin-5494@642108c | modin-project/modin | Python | 5,494 | PERF-#5182: Precompute dtypes when performing binary operations in certain cases | <!--
Thank you for your contribution!
Please review the contributing docs: https://modin.readthedocs.io/en/latest/development/contributing.html
if you have questions about contributing.
-->
## What do these changes do?
Added logic to precompute dtypes before add operation was performed on two dataframes.
B... | 2022-12-22T17:47:27Z | [PERF] compute `dtypes` when performing binary operations
It should be possible and beneficial to compute `dtypes` when doing binary operations without remote calls so other subsequent operations, which require `dypes` to be known, do not perform the remote calls to compute it.
Here are some examples when we can com... | https://github.com/modin-project/modin/issues/4868
As resultant dtypes for each function are dependent on the operation. Looks like this has to be done specific to each function.
eg For add(df1+d2) for each column the resultant dtype would be determined by any of the 2 below cases
**Case 1**)Check whethe... | [
{
"body": "It should be possible and beneficial to compute `dtypes` when doing binary operations without remote calls so other subsequent operations, which require `dypes` to be known, do not perform the remote calls to compute it.\r\n\r\nHere are some examples when we can compute/pass known dtypes to the core ... | 8b40350f77662ee9edd0837adec8a7388257577b | {
"head_commit": "642108ce469c7a4c8d32d66f01a8e2fc3f0bcbe8",
"head_commit_message": "removing dtypes calls in base.py\n\nSigned-off-by: arunjose696 <arunjose696@gmail.com>",
"patch_to_review": "diff --git a/modin/core/dataframe/algebra/binary.py b/modin/core/dataframe/algebra/binary.py\nindex 2d9645aeaca..be2964e... | [
{
"diff_hunk": "@@ -19,11 +19,98 @@\n from .operator import Operator\n \n \n+def coerce_int_to_float64(dtype: np.dtype) -> np.dtype:\n+ \"\"\"\n+ Coerce dtype to float64 if it is a variant of integer.\n+\n+ If dtype is integer, function returns float64 datatype.\n+ If not, returns the datatype argum... | 3d22f305df489b8d2467464fa39aab02f6a6c90c | diff --git a/modin/core/dataframe/algebra/binary.py b/modin/core/dataframe/algebra/binary.py
index 2d9645aeaca..64d7476d652 100644
--- a/modin/core/dataframe/algebra/binary.py
+++ b/modin/core/dataframe/algebra/binary.py
@@ -19,11 +19,126 @@
from .operator import Operator
+def coerce_int_to_float64(dtype: np.dtype... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "Performance Optimizations"
} |
modin-project__modin-5422@5ceca02 | modin-project/modin | Python | 5,422 | FEAT-#5423: Add a NumPy API to Modin | <!--
Thank you for your contribution!
Please review the contributing docs: https://modin.readthedocs.io/en/latest/development/contributing.html
if you have questions about contributing.
-->
## What do these changes do?
<!-- Please give a short brief about these changes. -->
- [x] first commit message and P... | 2022-12-12T19:25:33Z | Add a NumPy API Layer to Modin
**Is your feature request related to a problem? Please describe.**
A clear and concise description of what the problem is. What kind of performance improvements would you like to see with this new API?
It would be nice to be able to use the NumPy API to manipulate Modin objects, i.e. ha... | [
{
"body": "**Is your feature request related to a problem? Please describe.**\r\nA clear and concise description of what the problem is. What kind of performance improvements would you like to see with this new API?\r\nIt would be nice to be able to use the NumPy API to manipulate Modin objects, i.e. have a `mo... | 843b0cf02df9ff76f32cc75749203762633ffb27 | {
"head_commit": "5ceca0264113795c6836f4d8c82e32da4297b118",
"head_commit_message": "Add tests to CI\n\nSigned-off-by: Rehan Durrani <rehan@ponder.io>",
"patch_to_review": "diff --git a/.github/workflows/push-to-master.yml b/.github/workflows/push-to-master.yml\nindex 73a66367e05..3886886b596 100644\n--- a/.githu... | [
{
"diff_hunk": "@@ -0,0 +1,333 @@\n+# Licensed to Modin Development Team under one or more contributor license agreements.\n+# See the NOTICE file distributed with this work for additional information regarding\n+# copyright ownership. The Modin Development Team licenses this file to you under the\n+# Apache L... | 1bf6c007312bf10d35e5c2fcf662b9f5d3ac504e | diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 0749a141cd8..ed046a9f0e1 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -623,6 +623,10 @@ jobs:
- run: mpiexec -n 1 python -m pytest modin/pandas/test/test_groupby.py
- run: mpiexec -n 1 python -m pytest modin/... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
modin-project__modin-5377@0522fa3 | modin-project/modin | Python | 5,377 | FIX-#3823: Fix TypeError when creating Series from SparseArray | ## What do these changes do?
<!-- Please give a short brief about these changes. -->
- [x] first commit message and PR title follow format outlined [here](https://modin.readthedocs.io/en/latest/development/contributing.html#commit-message-formatting)
> **_NOTE:_** If you edit the PR title to match this format... | 2022-12-07T14:41:24Z | ``Series`` doesn`t work correctly with ``sparse`` at MODIN_STORAGE_FORMAT=omnisci
When I run at MODIN_STORAGE_FORMAT=omnisci:
```
import numpy as np
import pandas
import modin.pandas as pd
pd.Series(pandas.arrays.SparseArray(np.array([3, 1, 2, 3, 4, np.nan])))
```
I have error:
```
TypeError: Sparse pandas dat... | @modin-project/modin-omnisci could someone please check if this still happens?
@devin-petersohn do we still want to support sparse data?.. | [
{
"body": "When I run at MODIN_STORAGE_FORMAT=omnisci:\r\n```\r\nimport numpy as np\r\nimport pandas\r\nimport modin.pandas as pd\r\npd.Series(pandas.arrays.SparseArray(np.array([3, 1, 2, 3, 4, np.nan])))\r\n```\r\nI have error:\r\n```\r\nTypeError: Sparse pandas data (column F___reduced__) not supported.\r\n``... | 2ebc9cf51bfc773e3d4c898f5a33c0f60ad7ebc5 | {
"head_commit": "0522fa34084f063c41d45ec1e82da917ba19e41b",
"head_commit_message": "FIX-#3823: Fixed TypeError when creating Series from SparseArray\n\nSigned-off-by: Andrey Pavlenko <andrey.a.pavlenko@gmail.com>",
"patch_to_review": "diff --git a/modin/experimental/core/execution/native/implementations/hdk_on_n... | [
{
"diff_hunk": "@@ -12,7 +12,7 @@\n # governing permissions and limitations under the License.\n \n \"\"\"Module provides a partition manager class for ``HdkOnNativeDataframe`` frame.\"\"\"\n-\n+from modin.error_message import ErrorMessage",
"line": 16,
"original_line": 15,
"original_start_line": nu... | b53805c1ee3e68b26b07b886a3d34a6560044373 | diff --git a/modin/experimental/core/execution/native/implementations/hdk_on_native/partitioning/partition_manager.py b/modin/experimental/core/execution/native/implementations/hdk_on_native/partitioning/partition_manager.py
index b0a73a7dfe6..c13e95f82ef 100644
--- a/modin/experimental/core/execution/native/implementa... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
modin-project__modin-5421@e514bd7 | modin-project/modin | Python | 5,421 | TEST-#5420: port asv benchmarks for Repr, MaskBool, isNull, dropNa and equals functions | <!--
Thank you for your contribution!
Please review the contributing docs: https://modin.readthedocs.io/en/latest/development/contributing.html
if you have questions about contributing.
-->
## What do these changes do?
<!-- Please give a short brief about these changes. -->
Added asv benchmarks for Repr, M... | 2022-12-12T13:36:05Z | [ASV] port Repr, MaskBool, isNull, dropNa and equals benchmarks from pandas github
Have to add ASV benchmarks which does the following actions
Gets string representation of dataframe
Applies a mask on a dataframe
Detect missing values
remove missing values
check equality of dataframes | [
{
"body": "Have to add ASV benchmarks which does the following actions\r\n\r\nGets string representation of dataframe\r\nApplies a mask on a dataframe\r\nDetect missing values \r\nremove missing values\r\ncheck equality of dataframes ",
"number": 5420,
"title": "[ASV] port Repr, MaskBool, isNull, dropN... | 1590e65e3bbce2720bfa813725793af4015c55de | {
"head_commit": "e514bd796b928c5bb9eb1f8b9ab4f08608208248",
"head_commit_message": "fixed a flake issue\n\nSigned-off-by: arunjose696 <arunjose696@gmail.com>",
"patch_to_review": "diff --git a/asv_bench/benchmarks/benchmarks.py b/asv_bench/benchmarks/benchmarks.py\nindex d4777d2393e..46ea5a7c402 100644\n--- a/as... | [
{
"diff_hunk": "@@ -1184,4 +1184,96 @@ def time_series_indices(self, shape):\n self.series.groupby(self.series).indices\n \n \n+class TimeRepr:\n+\n+ params = [get_benchmark_shapes(\"TimeRepr\")]\n+ param_names = [\"shape\"]\n+\n+ def setup(self, shape):\n+ self.df = IMPL.DataFrame(np.ra... | 10f97d8f40b13dbc9489151c40c3bede54e5b2c2 | diff --git a/asv_bench/benchmarks/benchmarks.py b/asv_bench/benchmarks/benchmarks.py
index d4777d2393e..8f9e318606e 100644
--- a/asv_bench/benchmarks/benchmarks.py
+++ b/asv_bench/benchmarks/benchmarks.py
@@ -1184,4 +1184,78 @@ def time_series_indices(self, shape):
self.series.groupby(self.series).indices
... | {
"difficulty": "low",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
modin-project__modin-5351@7520dbe | modin-project/modin | Python | 5,351 | TEST-#5350: port DropDuplicates and LevelAlign benchmarks from pandas github | <!--
Thank you for your contribution!
Please review the contributing docs: https://modin.readthedocs.io/en/latest/development/contributing.html
if you have questions about contributing.
-->
## What do these changes do?
Adding 2 benchmark classes from pandas benchmark
Source PR https://github.com/modin-projec... | 2022-12-05T10:22:43Z | [ASV] port align and DropDuplicates benchmarks from pandas github
Have to add ASV benchmarks related which does the following actions
1)Dataframe.align and Dataframe.reindex
2)drop_duplicates method for Dataframe and Series.
- With separate benchmarks for inplace argument true and false
- With... | [
{
"body": "Have to add ASV benchmarks related which does the following actions\r\n\r\n1)Dataframe.align and Dataframe.reindex\r\n\r\n2)drop_duplicates method for Dataframe and Series. \r\n - With separate benchmarks for inplace argument true and false \r\n - With different types of data such as s... | e4c5a47563714068ebd4a0c026daa6ebc8c49c07 | {
"head_commit": "7520dbe43bb064f54b626dd4b920c65d01313326",
"head_commit_message": "adding ASV benchmarks for drop_duplicates and align methods\n\nSigned-off-by: arunjose696 <arunjose696@gmail.com>",
"patch_to_review": "diff --git a/asv_bench/benchmarks/benchmarks.py b/asv_bench/benchmarks/benchmarks.py\nindex 1... | [
{
"diff_hunk": "@@ -992,4 +993,96 @@ def time_float_32(self, shape, method):\n execute(self.df_ts_float32.fillna(method=method))\n \n \n+class TimeLevelAlign:\n+ params = [get_benchmark_shapes(\"TimeLevelAlign\")]\n+ param_names = [\"shape\"]\n+\n+ def setup(self, shape):\n+ row1, col1 =... | b2004443f34c46c90c4edf53394c8d94562a5cae | diff --git a/asv_bench/benchmarks/benchmarks.py b/asv_bench/benchmarks/benchmarks.py
index 10c050251df..3ec5d1970df 100644
--- a/asv_bench/benchmarks/benchmarks.py
+++ b/asv_bench/benchmarks/benchmarks.py
@@ -21,6 +21,7 @@
import numpy as np
import pandas._testing as tm
+import math
from .utils import (
gen... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "New Feature Additions"
} | |
modin-project__modin-5388@b874559 | modin-project/modin | Python | 5,388 | TEST-#5378: port stack, unstack, replace and groups benchmarks from pandas | <!--
Thank you for your contribution!
Please review the contributing docs: https://modin.readthedocs.io/en/latest/development/contributing.html
if you have questions about contributing.
-->
## What do these changes do?
Adding 3 benchmark classes from pandas benchmark TimeSimpleReshape , TimeReplace and TimeGr... | 2022-12-08T10:43:04Z | [ASV] port stack, unstack, replace and groups benchmarks from pandas github
Have to add ASV benchmarks related which does the following actions
1) perform stack and unstack on dataframe.
2) Replace function on a dataframe.
3) Get groups returned by groupby. | @arunjose696 thank you for filing this issue. Could you please add priorities to all new Modin issues? You can ask someone from modin-core if you need help assigning a priority. I think these benchmarking issues can be P2. | [
{
"body": "Have to add ASV benchmarks related which does the following actions\r\n1) perform stack and unstack on dataframe.\r\n2) Replace function on a dataframe.\r\n3) Get groups returned by groupby.",
"number": 5378,
"title": "[ASV] port stack, unstack, replace and groups benchmarks from pandas gith... | 219edb5fb772609d3fafaac02ded0294ea434aa8 | {
"head_commit": "b874559a00f91dce2943402f38293d9016d0a666",
"head_commit_message": " fixing flake issue\n\nSigned-off-by: arunjose696 <arunjose696@gmail.com>",
"patch_to_review": "diff --git a/asv_bench/benchmarks/benchmarks.py b/asv_bench/benchmarks/benchmarks.py\nindex 19574b6be96..e1bf1a92392 100644\n--- a/as... | [
{
"diff_hunk": "@@ -1113,4 +1113,63 @@ def time_remove_categories(self, shape):\n execute(self.ts.cat.remove_categories(self.ts.cat.categories[::2]))\n \n \n+class TimeSimpleReshape:\n+\n+ params = [get_benchmark_shapes(\"TimeSimpleReshape\")]\n+ param_names = [\"shape\"]\n+\n+ def setup(self, ... | f232943bc9f4ee7e771bfdfbf06c1da5342b47a2 | diff --git a/asv_bench/benchmarks/benchmarks.py b/asv_bench/benchmarks/benchmarks.py
index 19574b6be96..a8bea9bd495 100644
--- a/asv_bench/benchmarks/benchmarks.py
+++ b/asv_bench/benchmarks/benchmarks.py
@@ -1113,4 +1113,71 @@ def time_remove_categories(self, shape):
execute(self.ts.cat.remove_categories(self... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "New Feature Additions"
} |
modin-project__modin-5366@1ff556f | modin-project/modin | Python | 5,366 | FEAT-#5367: Introduce new API for repartitioning Modin objects | Signed-off-by: Myachev <anatoly.myachev@intel.com>
<!--
Thank you for your contribution!
Please review the contributing docs: https://modin.readthedocs.io/en/latest/development/contributing.html
if you have questions about contributing.
-->
## What do these changes do?
<!-- Please give a short brief about ... | 2022-12-06T18:35:55Z | FEAT: create API for repartitioning Modin objects
**Is your feature request related to a problem? Please describe.**
A clear and concise description of what the problem is. What kind of performance improvements would you like to see with this new API?
The function is intended to improve performance. It will be usef... | [
{
"body": "**Is your feature request related to a problem? Please describe.**\r\nA clear and concise description of what the problem is. What kind of performance improvements would you like to see with this new API?\r\n\r\nThe function is intended to improve performance. It will be useful for users where the qu... | 2ebc9cf51bfc773e3d4c898f5a33c0f60ad7ebc5 | {
"head_commit": "1ff556fb5edc983c7cac07e6395beb550fea245b",
"head_commit_message": "address review comments\n\nSigned-off-by: Myachev <anatoly.myachev@intel.com>",
"patch_to_review": "diff --git a/modin/core/dataframe/pandas/dataframe/dataframe.py b/modin/core/dataframe/pandas/dataframe/dataframe.py\nindex cdb8d... | [
{
"diff_hunk": "@@ -0,0 +1,58 @@\n+# Licensed to Modin Development Team under one or more contributor license agreements.\n+# See the NOTICE file distributed with this work for additional information regarding\n+# copyright ownership. The Modin Development Team licenses this file to you under the\n+# Apache Li... | 72552df0d0e79616ee841be49f979b97a9d7b596 | diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 82c58eaafed..9f3b64909b1 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -570,6 +570,7 @@ jobs:
sudo docker pull postgres
sudo docker run --name some-postgres -e POSTGRES_USER=sa -e POSTGRES_PASSWORD=Str... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
modin-project__modin-5271@5620a85 | modin-project/modin | Python | 5,271 | FIX-#4859: Add support for PyArrow Dictionary Arrays to type mapping | Signed-off-by: Andrey Pavlenko <andrey.a.pavlenko@gmail.com>
Fixed the issue https://github.com/modin-project/modin/pull/4864#discussion_r1030784639
- [x] first commit message and PR title follow format outlined [here](https://modin.readthedocs.io/en/latest/development/contributing.html#commit-message-formatting)... | 2022-11-25T19:48:40Z | Unable to create DataFrame form a PyArrow table containing a Dictionary Array
### System information
- **OS Platform and Distribution (e.g., Linux Ubuntu 16.04)**: Ubuntu 22.04.1
- **Modin version** (`modin.__version__`): 0.15.0+89.g8f3f3899
- **Python version**: 3.8.13
- **Code we can use to reproduce**:
import... | Reopening the issue because of https://github.com/modin-project/modin/pull/4864#discussion_r1030784639. | [
{
"body": "### System information\r\n- **OS Platform and Distribution (e.g., Linux Ubuntu 16.04)**: Ubuntu 22.04.1\r\n- **Modin version** (`modin.__version__`): 0.15.0+89.g8f3f3899\r\n- **Python version**: 3.8.13\r\n- **Code we can use to reproduce**:\r\n\r\nimport pyarrow as pa\r\nimport modin.config as cfg\r\... | a77a6464c83ad9e3d91fdf9650aa5e43764f6aa9 | {
"head_commit": "5620a85425f9904cd8c382fd4ba400f881f43fe5",
"head_commit_message": "FIX-#4859: Added support for PyArrow Dictionary Arrays to type mapping\n\nMake sure dtype is not materialized after str().\n\nSigned-off-by: Andrey Pavlenko <andrey.a.pavlenko@gmail.com>",
"patch_to_review": "diff --git a/.github... | [
{
"diff_hunk": "@@ -435,6 +435,7 @@ jobs:\n - run: pytest modin/experimental/core/execution/native/implementations/hdk_on_native/test/test_init.py\n - run: pytest modin/experimental/core/execution/native/implementations/hdk_on_native/test/test_dataframe.py\n - run: pytest modin/pandas/test/tes... | d90347cafd6c14c7af8c203b3d9f5176979cb968 | diff --git a/modin/core/dataframe/pandas/dataframe/dataframe.py b/modin/core/dataframe/pandas/dataframe/dataframe.py
index 3f31942162f..6b7292a46a9 100644
--- a/modin/core/dataframe/pandas/dataframe/dataframe.py
+++ b/modin/core/dataframe/pandas/dataframe/dataframe.py
@@ -3095,8 +3095,6 @@ def _arrow_type_to_dtype(cls,... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
modin-project__modin-5507@de88d24 | modin-project/modin | Python | 5,507 | FIX-#1930: Fix one of the cases of heterogeneous data for read_csv | Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
<!--
Thank you for your contribution!
Please review the contributing docs: https://modin.readthedocs.io/en/latest/development/contributing.html
if you have questions about contributing.
-->
## What do these changes do?
<!-- Please give a short brie... | 2022-12-25T16:40:26Z | Different from pandas index at `read_csv` in case of specified `names`
### System information
- **OS Platform and Distribution (e.g., Linux Ubuntu 16.04)**: Any
- **Modin version** (`modin.__version__`): 0.8.0
- **Python version**: 3.7.5
- **Code we can use to reproduce**:
```python
if __name__ == "__main__":
... | This might be a similar issue to #2239.
This is quite an old issue, so we need to figure out whether it still applies.
I was able to create the dataset used: [test.csv](https://github.com/modin-project/modin/files/9570090/test.csv)
Unfortunately, it looks like both `df_equals` statements are now failing. For the fi... | [
{
"body": "### System information\r\n- **OS Platform and Distribution (e.g., Linux Ubuntu 16.04)**: Any\r\n- **Modin version** (`modin.__version__`): 0.8.0\r\n- **Python version**: 3.7.5\r\n- **Code we can use to reproduce**:\r\n```python\r\nif __name__ == \"__main__\":\r\n import pandas\r\n import modin.... | e1d42410c3900f93be420303e745de29c1e6bda1 | {
"head_commit": "de88d24f59a511f73840a3a2ecceb2d9236ff00f",
"head_commit_message": "try unidist from master branch\n\nSigned-off-by: Anatoly Myachev <anatoly.myachev@intel.com>",
"patch_to_review": "diff --git a/modin/core/io/text/text_file_dispatcher.py b/modin/core/io/text/text_file_dispatcher.py\nindex 12a0e2... | [
{
"diff_hunk": "@@ -52,3 +51,4 @@ dependencies:\n - connectorx>=0.2.6a4\n # The `numpydoc` version should match the version installed in the `lint-pydocstyle` job of the CI.\n - numpydoc==1.1.0\n+ - git+https://github.com/modin-project/unidist.git@master#egg=unidist[mpi]",
"line": nul... | 63396ed95c1bc54f0d2f1da716a0b16a8ff6adcb | diff --git a/modin/core/io/text/text_file_dispatcher.py b/modin/core/io/text/text_file_dispatcher.py
index 14447fc7b11..158212b37ec 100644
--- a/modin/core/io/text/text_file_dispatcher.py
+++ b/modin/core/io/text/text_file_dispatcher.py
@@ -1105,6 +1105,14 @@ def _read(cls, filepath_or_buffer, **kwargs):
i... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
modin-project__modin-5156@5bf08fd | modin-project/modin | Python | 5,156 | FIX-#3925: Fixed AssertionError on columns and index drop | ## What do these changes do?
1. Index drop is not supported by the HDK engine. In this case - fall back to pandas.
2. If all columns are dropped and the index is trivial, we are not able to restore it, since we don't know the number of rows. In this case, we calculate the index from the current frame.
**Fixes #3... | 2022-10-25T19:38:59Z | ``series.___delitem__`` doesn`t work correctly at MODIN_STORAGE_FORMAT=omnisci
When I run:
```
import modin.pandas as pd
from modin.pandas.test.utils import test_data
import modin.config as cfg
cfg.StorageFormat.put('omnisci')
data = test_data["float_nan_data"]
modin_series = pd.Series(data[next(iter(data.keys... | This issue should be fixed by #5103 and #5156.
Please link this issue to the PR which is going to resolve it.
> Please link this issue to the PR which is going to resolve it.
Added links to both PRs. Both fixes are required to resolve this issue.
@modin-project/modin-omnisci could someone please check if this still... | [
{
"body": "When I run:\r\n```\r\nimport modin.pandas as pd\r\nfrom modin.pandas.test.utils import test_data\r\nimport modin.config as cfg\r\ncfg.StorageFormat.put('omnisci')\r\n\r\ndata = test_data[\"float_nan_data\"]\r\nmodin_series = pd.Series(data[next(iter(data.keys()))])\r\ndel modin_series[modin_series.in... | 99f9ed17e76707ecc91c2a69be4a79c35be5ede9 | {
"head_commit": "5bf08fd8947f89f1eded925f3d392d62dd479c83",
"head_commit_message": "FIX-#3925: Fixed AssertionError on columns and index drop\n\n1. Index drop is not supported by the HDK engine. In this case - fall\n back to pandas.\n2. If all columns are dropped and the index is trivial, we are\n not able to ... | [
{
"diff_hunk": "@@ -557,18 +557,27 @@ def concat(self, axis, other, **kwargs):\n \n def drop(self, index=None, columns=None, errors: str = \"raise\"):\n if index is not None:\n+ # Only column drop is supported by the HDK engine\n raise NotImplementedError(\"Row drop\")\n ... | 5091725333c935b624aa7e000570bf631343ab54 | diff --git a/modin/experimental/core/execution/native/implementations/hdk_on_native/dataframe/dataframe.py b/modin/experimental/core/execution/native/implementations/hdk_on_native/dataframe/dataframe.py
index 81bb4a304af..4fd27cf3af9 100644
--- a/modin/experimental/core/execution/native/implementations/hdk_on_native/da... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
modin-project__modin-5109@d5bd637 | modin-project/modin | Python | 5,109 | REFACTOR-#4631: Add mypy checks for modin.distributed | Signed-off-by: Rosdyana Kusuma <rosdyana.kusuma@gmail.com>
<!--
Thank you for your contribution!
Please review the contributing docs: https://modin.readthedocs.io/en/latest/development/contributing.html
if you have questions about contributing.
-->
## What do these changes do?
<!-- Please give a short brie... | 2022-10-09T15:42:57Z | Add mypy checks for modin.distributed
We need to expand our mypy checks to cover Python files in `modin/distributed/`. There may be a lot of files to modify at once so folks should focus on type annotations one file at a time. Please make sure to add files to `mypy.ini`! | [
{
"body": "We need to expand our mypy checks to cover Python files in `modin/distributed/`. There may be a lot of files to modify at once so folks should focus on type annotations one file at a time. Please make sure to add files to `mypy.ini`! ",
"number": 4631,
"title": "Add mypy checks for modin.dist... | d0054290ec8305d01b040e740e3f4524815ea77e | {
"head_commit": "d5bd6376d5b7735c4c676e74bd73ef36edcdfdff",
"head_commit_message": "Fixed mypy issue on partitions.py\n\nSigned-off-by: Rosdyana Kusuma <rosdyana.kusuma@gmail.com>",
"patch_to_review": "diff --git a/modin/distributed/dataframe/pandas/partitions.py b/modin/distributed/dataframe/pandas/partitions.p... | [
{
"diff_hunk": "@@ -99,8 +100,13 @@ def get_block(partition):\n \n \n def from_partitions(\n- partitions, axis, index=None, columns=None, row_lengths=None, column_widths=None\n-):\n+ partitions: list,\n+ axis: int,",
"line": null,
"original_line": 104,
"original_start_line": null,
"path... | 2b3293534ddb675488564d4cd669d001ae54e55b | diff --git a/modin/distributed/dataframe/pandas/partitions.py b/modin/distributed/dataframe/pandas/partitions.py
index 45c044203a1..3206c35fa3b 100644
--- a/modin/distributed/dataframe/pandas/partitions.py
+++ b/modin/distributed/dataframe/pandas/partitions.py
@@ -13,13 +13,33 @@
"""Module houses API to operate on M... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
modin-project__modin-4937@d90006e | modin-project/modin | Python | 4,937 | FIX-#4100: Fall back to Pandas on row drop | Signed-off-by: Andrey Pavlenko <andrey.a.pavlenko@gmail.com>
<!--
Thank you for your contribution!
Please review the contributing docs: https://modin.readthedocs.io/en/latest/development/contributing.html
if you have questions about contributing.
-->
## What do these changes do?
Only column drop is currently... | 2022-09-06T21:52:23Z | ``Series.pop()`` doesn`t work correctly at MODIN_STORAGE_FORMAT=omnisci
When I run:
```
import modin.pandas as pd
from modin.pandas.test.utils import test_data_values
import modin.config as cfg
cfg.StorageFormat.put('omnisci')
data = test_data_values[0]
modin_series = pd.Series(data[next(iter(data.keys()))])
... | @modin-project/modin-omnisci could someone please check if this still happens? | [
{
"body": "When I run:\r\n```\r\nimport modin.pandas as pd\r\nfrom modin.pandas.test.utils import test_data_values\r\nimport modin.config as cfg\r\ncfg.StorageFormat.put('omnisci')\r\n\r\ndata = test_data_values[0]\r\nmodin_series = pd.Series(data[next(iter(data.keys()))])\r\nfor key in modin_series.keys():\r\n... | 073dffc31a628978e4dd09b40a6a0ac648f20426 | {
"head_commit": "d90006e18d0b71f2990e50c474f2e7d7190bd29e",
"head_commit_message": "FIX-#4100: Fall back to Pandas on row drop\n\nOnly column drop is currently supported by the omnisci engine.\n\nSigned-off-by: Andrey Pavlenko <andrey.a.pavlenko@gmail.com>",
"patch_to_review": "diff --git a/modin/experimental/co... | [
{
"diff_hunk": "@@ -2145,6 +2145,28 @@ def drop_rename_concat(df1, df2, lib, **kwargs):\n force_arrow_execute=True,\n )\n \n+ def test_drop_row(self):\n+ def drop_row(df, **kwargs):\n+ return df.drop(1)",
"line": null,
"original_line": 2150,
"original_start_l... | 059ec90cb418fd0306502ee87936f9d766443679 | diff --git a/modin/experimental/core/execution/native/implementations/hdk_on_native/test/test_dataframe.py b/modin/experimental/core/execution/native/implementations/hdk_on_native/test/test_dataframe.py
index f75038fa049..561d3a89117 100644
--- a/modin/experimental/core/execution/native/implementations/hdk_on_native/te... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
modin-project__modin-4972@b7e3d62 | modin-project/modin | Python | 4,972 | TEST-#4366: Added regression test |
## What do these changes do?
<!-- Please give a short brief about these changes. -->
- [x] commit message follows format outlined [here](https://modin.readthedocs.io/en/latest/development/contributing.html#commit-message-formatting)
- [x] passes `flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py`
- [x... | 2022-09-14T15:02:14Z | Don't correctly work `dtype` for `column` in `exchange df_protocol` for OmniSci
If we run:
```
import modin.pandas as pd
from modin.test.exchange.dataframe_protocol.omnisci.utils import split_df_into_chunks
import modin.config as cfg
cfg.StorageFormat.put('omnisci')
pd_df = pd.DataFrame({"a": pd.Categorical(lis... | This issue seems to be fixed by #4834.
@AndreyPavlenko, does the example above pass with those changes on your side?
> @AndreyPavlenko, does the example above pass with those changes on your side?
The example above seems not valid - it fails with KeyError. I've fixed the error by replacing get_column_by_name(" ") wi... | [
{
"body": "If we run:\r\n```\r\nimport modin.pandas as pd\r\nfrom modin.test.exchange.dataframe_protocol.omnisci.utils import split_df_into_chunks\r\nimport modin.config as cfg\r\ncfg.StorageFormat.put('omnisci')\r\n\r\npd_df = pd.DataFrame({\"a\": pd.Categorical(list(\"testdataforexchangedataframeprotocol\"))}... | af6f8277cf9caeb7dec8b390ef3652ec0fa04774 | {
"head_commit": "b7e3d629223e8dbb181a774665d05df1d36923b5",
"head_commit_message": "TEST-#4366: Added regression test\n\nSigned-off-by: Andrey Pavlenko <andrey.a.pavlenko@gmail.com>",
"patch_to_review": "diff --git a/modin/test/interchange/dataframe_protocol/omnisci/test_protocol.py b/modin/test/interchange/data... | [
{
"diff_hunk": "@@ -310,3 +310,16 @@ def test_buffer_of_chunked_at(data_has_nulls, n_chunks):\n # Catch exception on attempt of doing a copy due to chunks combining\n with pytest.raises(RuntimeError):\n col.get_buffers()\n+\n+\n+def test_concat_chunks():\n+ \"\"\"Regression test f... | e04b5ff77b1fa89e363f24b2f1a4ef9c00976e39 | diff --git a/modin/test/interchange/dataframe_protocol/omnisci/test_protocol.py b/modin/test/interchange/dataframe_protocol/omnisci/test_protocol.py
index d0f202f272a..49c6ee6f2a7 100644
--- a/modin/test/interchange/dataframe_protocol/omnisci/test_protocol.py
+++ b/modin/test/interchange/dataframe_protocol/omnisci/test... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "Bug Fixes"
} |
modin-project__modin-4951@f4ac943 | modin-project/modin | Python | 4,951 | FIX-#4945: Fix `_take_2d_positional` that loses indexes due to filtering empty dataframes | Signed-off-by: Myachev <anatoly.myachev@intel.com>
<!--
Thank you for your contribution!
Please review the contributing docs: https://modin.readthedocs.io/en/latest/development/contributing.html
if you have questions about contributing.
-->
## What do these changes do?
<!-- Please give a short brief about ... | 2022-09-09T18:44:07Z | BUG: Lazily-evaluated DataFrame not computing Index properly
### System information
- **OS Platform and Distribution (e.g., Linux Ubuntu 16.04)**: macOS 12.2.1
- **Modin version** (`modin.__version__`): 0.15.3
- **Python version**: 3.9.12
- **Code we can use to reproduce**:
```python
import modin.pandas as pd
... | @anmyachev I've been digging into this bug today and it seems that the root issue is from your PR here: https://github.com/modin-project/modin/pull/4921. Although, we currently are getting a different error thrown for the reproducer, I'm finding that we are returning the incorrect result even after resolving the initia... | [
{
"body": "### System information\r\n- **OS Platform and Distribution (e.g., Linux Ubuntu 16.04)**: macOS 12.2.1\r\n- **Modin version** (`modin.__version__`): 0.15.3\r\n- **Python version**: 3.9.12\r\n- **Code we can use to reproduce**:\r\n\r\n```python\r\nimport modin.pandas as pd\r\nimport numpy as np\r\nimpo... | b09dd424e95830e6a19a631741eb8381b9020ee5 | {
"head_commit": "f4ac943323f04a996e0c9b2dee1e7be663546f3b",
"head_commit_message": "FIX-#4945: fix _take_2d_positional that missed indexes due to filtering\n\nSigned-off-by: Myachev <anatoly.myachev@intel.com>",
"patch_to_review": "diff --git a/modin/core/dataframe/pandas/dataframe/dataframe.py b/modin/core/data... | [
{
"diff_hunk": "@@ -1451,7 +1451,6 @@ def rebalance_partitions(cls, partitions):\n for obj in partitions[stop]:\n obj._length_cache = new_last_partition_size\n \n- partition_size = ideal_partition_size",
"line": null,
"original_line": 1454,
... | 9617ebbe2c8dda2d17a25e8a5a73df1d0ec4f9b8 | diff --git a/docs/release_notes/release_notes-0.16.0.rst b/docs/release_notes/release_notes-0.16.0.rst
index 0699b956fd7..fd3032f98ac 100644
--- a/docs/release_notes/release_notes-0.16.0.rst
+++ b/docs/release_notes/release_notes-0.16.0.rst
@@ -42,6 +42,7 @@ Key Features and Updates
* FIX-#4914: `base_lengths` shoul... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
modin-project__modin-4898@161ed31 | modin-project/modin | Python | 4,898 | FEAT-#4766: Support fsspec URLs in `read_csv` and `read_csv_glob` | Signed-off-by: Karthik Velayutham <vkarthik@ponder.io>
<!--
Thank you for your contribution!
Please review the contributing docs: https://modin.readthedocs.io/en/latest/development/contributing.html
if you have questions about contributing.
-->
## What do these changes do?
This PR adds proper support for f... | 2022-08-29T23:12:11Z | FEAT: Add support for Distributed loading on GCS buckets
## Context
The company I work for, heavily uses pandas and Google Cloud Storage (GCS) buckets. We were interested in using Modin to improve performance of loading large datasets and improve data processing tasks.
## Problem
However, it seems as though using... | Connected with #4742
@Anando304 thanks for opening the issue! This is a good point and we haven't properly addressed it yet (for reasons I don't know exactly). I'll work on a PR to add support for `gs://`. | [
{
"body": "## Context\r\nThe company I work for, heavily uses pandas and Google Cloud Storage (GCS) buckets. We were interested in using Modin to improve performance of loading large datasets and improve data processing tasks. \r\n\r\n## Problem\r\nHowever, it seems as though using GCS bucket urls for the `read... | c67324b04b01e7d1f27a7c91565c488537891de1 | {
"head_commit": "161ed3114eecfd38fd6876ce3562296c45db7eb0",
"head_commit_message": "Add release notes",
"patch_to_review": "diff --git a/docs/release_notes/release_notes-0.16.0.rst b/docs/release_notes/release_notes-0.16.0.rst\nindex 8a77e2d6af6..241ad20d076 100644\n--- a/docs/release_notes/release_notes-0.16.0.... | [
{
"diff_hunk": "@@ -331,18 +329,9 @@ def file_exists(cls, file_path: str, storage_options=None) -> bool:\n bool\n True if the path is valid.\n \"\"\"\n- if isinstance(file_path, str) and is_url(file_path):",
"line": 334,
"original_line": 334,
"original_start_line":... | 85d81dc3eafd5a410ad208219bdf9f801d3f9ff1 | diff --git a/docs/release_notes/release_notes-0.16.0.rst b/docs/release_notes/release_notes-0.16.0.rst
index 8a77e2d6af6..241ad20d076 100644
--- a/docs/release_notes/release_notes-0.16.0.rst
+++ b/docs/release_notes/release_notes-0.16.0.rst
@@ -106,6 +106,7 @@ Key Features and Updates
* FEAT-#4664: Finalize compatib... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
modin-project__modin-4908@a663158 | modin-project/modin | Python | 4,908 | FIX-#4907: Implement `radd` for Series and DataFrame | Signed-off-by: Karthik Velayutham <vkarthik@ponder.io>
<!--
Thank you for your contribution!
Please review the contributing docs: https://modin.readthedocs.io/en/latest/development/contributing.html
if you have questions about contributing.
-->
## What do these changes do?
This PR implements a proper imple... | 2022-08-31T18:38:58Z | BUG: Appending string to column returns in different order
### System information
- **OS Platform and Distribution (e.g., Linux Ubuntu 16.04)**: macOS 12.2.1
- **Modin version** (`modin.__version__`): 0.15.0+101.g14edd1ca
- **Python version**: 3.9.12
- **Code we can use to reproduce**:
```python
import modin.pand... | The problem here is that `radd` is just an alias for `add` so we don't actually consider the position of arguments. We'll have to make some changes to handle this case. | [
{
"body": "### System information\r\n- **OS Platform and Distribution (e.g., Linux Ubuntu 16.04)**: macOS 12.2.1\r\n- **Modin version** (`modin.__version__`): 0.15.0+101.g14edd1ca\r\n- **Python version**: 3.9.12\r\n- **Code we can use to reproduce**:\r\n```python\r\nimport modin.pandas as pd\r\nimport pandas\r\... | eee5f435f68786778184c4886ff25d386fce0c4f | {
"head_commit": "a6631582f96d1845bea597f618ebc060a60b4592",
"head_commit_message": "Add release notes",
"patch_to_review": "diff --git a/docs/release_notes/release_notes-0.16.0.rst b/docs/release_notes/release_notes-0.16.0.rst\nindex a62a476bacc..c09184a7d17 100644\n--- a/docs/release_notes/release_notes-0.16.0.... | [
{
"diff_hunk": "@@ -286,3 +286,12 @@ def test_empty_df(empty_operand):\n pandas_res = pandas_df_empty + pandas_df_empty\n \n df_equals(modin_res, pandas_res)\n+\n+\n+def test_concat_string_to_df():",
"line": null,
"original_line": 291,
"original_start_line": null,
"path": "modin/pand... | 8c227747123ef883e170f57d44f227f9d1742caa | diff --git a/docs/release_notes/release_notes-0.16.0.rst b/docs/release_notes/release_notes-0.16.0.rst
index a62a476bacc..c09184a7d17 100644
--- a/docs/release_notes/release_notes-0.16.0.rst
+++ b/docs/release_notes/release_notes-0.16.0.rst
@@ -40,6 +40,7 @@ Key Features and Updates
* FIX-#4835: Handle Pathlike path... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
modin-project__modin-4834@e7c4ef3 | modin-project/modin | Python | 4,834 | FIX-#3983: FIX-#4107: Materialize 'rowid' columns when selecting rows by position | <!--
Thank you for your contribution!
Please review the contributing docs: https://modin.readthedocs.io/en/latest/development/contributing.html
if you have questions about contributing.
-->
## What do these changes do?
Materialize 'rowid' columns when selecting rows by position. Otherwise, it defaults to range,... | 2022-08-17T22:52:57Z | ``Series.iloc()`` and ``Series.loc()`` don`t work correctly at MODIN_STORAGE_FORMAT=omnisci
When I run:
```
import pandas
import modin.pandas as pd
from modin.pandas.test.utils import test_data_values, df_equals
import modin.config as cfg
cfg.StorageFormat.put('omnisci')
data = test_data_values[0]
modin_serie... | @modin-project/modin-omnisci could someone please check if this still happens?
@modin-project/modin-omnisci could someone please check if this still happens? | [
{
"body": "When I run:\r\n```\r\nimport pandas\r\nimport modin.pandas as pd\r\nfrom modin.pandas.test.utils import test_data_values, df_equals\r\nimport modin.config as cfg\r\ncfg.StorageFormat.put('omnisci')\r\n\r\ndata = test_data_values[0]\r\nmodin_series = pd.Series(data[next(iter(data.keys()))])\r\npandas_... | 5991580cc8ac79c038d6dcde8b02d12feda06109 | {
"head_commit": "e7c4ef36a66c4a40eee0495c313718f112616a5b",
"head_commit_message": "FIX-#3983: FIX-#4107: Materialize 'rowid' columns when selecting rows by position\n\n * Materialize the frame when masking by row positions.\n * Masking by labels is not supported.\n * Use the last column in column.py since, after ... | [
{
"diff_hunk": "@@ -2169,5 +2169,51 @@ def test_set_index(self):\n df._query_compiler._modin_frame._set_index(pd.Index([1, 2, 3]))\n \n \n+class TestLoc:\n+ def test_loc(self):\n+ data = [1, 2, 3, 4, 5, 6]\n+ idx = [\"a\", \"b\", \"c\", \"d\", \"e\", \"f\"]\n+ key = [\"b\", \"c\"... | 81009fc072640daf53816e16f9d97bacaae8f6b3 | diff --git a/docs/release_notes/release_notes-0.16.0.rst b/docs/release_notes/release_notes-0.16.0.rst
index 34a14a2142e..903f7eba450 100644
--- a/docs/release_notes/release_notes-0.16.0.rst
+++ b/docs/release_notes/release_notes-0.16.0.rst
@@ -42,7 +42,8 @@ Key Features and Updates
* FIX-#4914: `base_lengths` shoul... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
modin-project__modin-4783@5822eb2 | modin-project/modin | Python | 4,783 | FIX-#4782: Exclude certain non-parquet files in `read_parquet` | Signed-off-by: Karthik Velayutham <vkarthik@ponder.io>
<!--
Thank you for your contribution!
Please review the contributing docs: https://modin.readthedocs.io/en/latest/development/contributing.html
if you have questions about contributing.
-->
## What do these changes do?
This PR fixes a bug where `read_p... | 2022-08-05T16:14:57Z | `read_parquet` fails when there are other non-parquet metadata files in folder
### System information
- **OS Platform and Distribution (e.g., Linux Ubuntu 16.04)**: macOS 12.2.1
- **Modin version** (`modin.__version__`): 0.15.0+67.g5a3eea4b
- **Python version**: 3.9.12
- **Code we can use to reproduce**:
```python... | [
{
"body": "### System information\r\n- **OS Platform and Distribution (e.g., Linux Ubuntu 16.04)**: macOS 12.2.1\r\n- **Modin version** (`modin.__version__`): 0.15.0+67.g5a3eea4b\r\n- **Python version**: 3.9.12\r\n- **Code we can use to reproduce**:\r\n```python\r\nIn [1]: import modin.pandas as pd\r\n\r\nIn [2... | 5a3eea4b8959a2debed16f7233045361ca0eaf86 | {
"head_commit": "5822eb2735370eb1e8f5adc82f8492e50e5521a6",
"head_commit_message": "Add release notes and minor doc fix",
"patch_to_review": "diff --git a/docs/release_notes/release_notes-0.16.0.rst b/docs/release_notes/release_notes-0.16.0.rst\nindex 1b6fdaab1f3..852f4ea0c9b 100644\n--- a/docs/release_notes/rel... | [
{
"diff_hunk": "@@ -65,22 +65,39 @@ def _unstrip_protocol(protocol, path):\n \n if isinstance(path, AbstractBufferedFile):\n return path.fs, [path]\n- protocol, path = split_protocol(path)\n- filesystem = get_filesystem_class(protocol)(**storage_options)\n- if filesystem... | fad888db813eef97f0d2f4824a2626b48c4e7389 | diff --git a/docs/release_notes/release_notes-0.16.0.rst b/docs/release_notes/release_notes-0.16.0.rst
index 1b6fdaab1f3..852f4ea0c9b 100644
--- a/docs/release_notes/release_notes-0.16.0.rst
+++ b/docs/release_notes/release_notes-0.16.0.rst
@@ -29,7 +29,8 @@ Key Features and Updates
* FIX-#4652: Support categorical ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
modin-project__modin-4726@2c702b0 | modin-project/modin | Python | 4,726 | FEAT-#4725: Make index and columns lazy in Modin DataFrame | Signed-off-by: Vasily Litvinov <fam1ly.n4me@yandex.ru>
<!--
Thank you for your contribution!
Please review the contributing docs: https://modin.readthedocs.io/en/latest/development/contributing.html
if you have questions about contributing.
-->
## What do these changes do?
Allow _not_ specifying `index` and ... | 2022-07-27T12:20:34Z | Support lazy initialization of index and columns in Modin Dataframe
**Is your feature request related to a problem? Please describe.**
Current logic requires passing a fully computed index (and columns) when creating `modin.core.dataframe.pandas.dataframe.dataframe.PandasDataframe`, however there might be cases when w... | [
{
"body": "**Is your feature request related to a problem? Please describe.**\r\nCurrent logic requires passing a fully computed index (and columns) when creating `modin.core.dataframe.pandas.dataframe.dataframe.PandasDataframe`, however there might be cases when we do not know the index of resulting operation ... | 05bf659b67d2b7153d8aaa004dd95252377eed51 | {
"head_commit": "2c702b0d0b4765ab8d060c50ffb2f2162e16e1b2",
"head_commit_message": "FEAT-#4725: Make index and columns lazy in Modin DataFrame\n\nSigned-off-by: Vasily Litvinov <fam1ly.n4me@yandex.ru>",
"patch_to_review": "diff --git a/docs/release_notes/release_notes-0.16.0.rst b/docs/release_notes/release_note... | [
{
"diff_hunk": "@@ -423,14 +436,32 @@ def _compute_axis_labels(self, axis: int, partitions=None):\n -------\n pandas.Index\n Labels for the specified `axis`.\n+ tuple of int\n+ Size of partitions alongsize specified `axis`.\n \"\"\"\n if partitions i... | a91992a2009f74606558e896099a9a95cb938e41 | diff --git a/docs/release_notes/release_notes-0.16.0.rst b/docs/release_notes/release_notes-0.16.0.rst
index f06d3e23728..2716a642706 100644
--- a/docs/release_notes/release_notes-0.16.0.rst
+++ b/docs/release_notes/release_notes-0.16.0.rst
@@ -66,6 +66,7 @@ Key Features and Updates
* FEAT-#4419: Extend virtual part... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
modin-project__modin-4621@e8b5550 | modin-project/modin | Python | 4,621 | FIX-#4593: Ensure Modin warns when setting columns via attributes | Signed-off-by: Hazem Elmeleegy <hazem@ponder.io>
<!--
Thank you for your contribution!
Please review the contributing docs: https://modin.readthedocs.io/en/latest/development/contributing.html
if you have questions about contributing.
-->
## What do these changes do?
<!-- Please give a short brief about th... | 2022-06-30T00:56:55Z | Modin should match pandas UserWarning for assigning columns via attributes
### System information
- **OS Platform and Distribution (e.g., Linux Ubuntu 16.04)**: macOS 12.2.1
- **Modin version** (`modin.__version__`): 0.15.0+16.g4574746c
- **Python version**: 3.9.12
- **Code we can use to reproduce**:
```python
... | [
{
"body": "### System information\r\n- **OS Platform and Distribution (e.g., Linux Ubuntu 16.04)**: macOS 12.2.1\r\n- **Modin version** (`modin.__version__`): 0.15.0+16.g4574746c\r\n- **Python version**: 3.9.12\r\n- **Code we can use to reproduce**:\r\n\r\n```python\r\nimport modin.pandas as pd\r\nimport pandas... | a76e2a17a1c0168cffa97f08d164e48025817f05 | {
"head_commit": "e8b5550846895de8647ebaf686a86b757ba2214d",
"head_commit_message": "FIX-#4593: Ensure Modin warns when setting columns via attributes\n\nSigned-off-by: Hazem Elmeleegy <hazem@ponder.io>",
"patch_to_review": "diff --git a/modin/pandas/dataframe.py b/modin/pandas/dataframe.py\nindex fa3bcb07026..94... | [
{
"diff_hunk": "@@ -2496,18 +2496,18 @@ def __setattr__(self, key, value):\n # - `_siblings`, which Modin initializes before it appears in __dict__\n if key in [\"_query_compiler\", \"_siblings\"] or key in self.__dict__:\n pass\n- elif key in self and key not in dir(self):\n+... | 5ea1a05a6dc04940eac27655afe3452fe8f5056f | diff --git a/docs/release_notes/release_notes-0.16.0.rst b/docs/release_notes/release_notes-0.16.0.rst
index 574632ddf09..a5be6949a65 100644
--- a/docs/release_notes/release_notes-0.16.0.rst
+++ b/docs/release_notes/release_notes-0.16.0.rst
@@ -13,6 +13,7 @@ Key Features and Updates
* FIX-#4577: Set attribute of Mod... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
modin-project__modin-4608@b409dbf | modin-project/modin | Python | 4,608 | FIX-#4358: MultiIndex `loc` shouldn't drop levels for full-key lookups | <!--
Thank you for your contribution!
Please review the contributing docs: https://modin.readthedocs.io/en/latest/development/contributing.html
if you have questions about contributing.
-->
## What do these changes do?
<!-- Please give a short brief about these changes. -->
Currently, we try to drop levels f... | 2022-06-27T22:16:07Z | MultiIndex: DataFrame.loc with a tuple on columns defined as MultiIndex returns an error
### System information
- **OS Platform and Distribution**: MacOS Monterey 12.2.1
- **Modin version** 0.14
- **Python version**: 3.8.12
- **Code we can use to reproduce**:
### Using modin:
```python
import ray
ray.init()
... | It will however work when explicitely converting the tuple to a MultiIndex:
```python
df.loc[:, pd.MultiIndex.from_tuples([ ("bar", "two") ]) ]
```
@neltacigreb thank you for the detailed bug report. I reproduced the issue with your code on Modin commit 6d05c31a24da9776723a179c74b70338b9302a82.
The bug happens... | [
{
"body": "### System information\r\n- **OS Platform and Distribution**: MacOS Monterey 12.2.1\r\n- **Modin version** 0.14\r\n- **Python version**: 3.8.12\r\n- **Code we can use to reproduce**:\r\n\r\n### Using modin: \r\n```python\r\nimport ray\r\nray.init()\r\nimport modin.pandas as pd\r\nimport numpy as np\r... | cad123ed479a30898066fb4094fa413fbd06696c | {
"head_commit": "b409dbf6df35395a3398d88b10c44043f5be9cbf",
"head_commit_message": "Add comment, refactor tests",
"patch_to_review": "diff --git a/docs/release_notes/release_notes-0.16.0.rst b/docs/release_notes/release_notes-0.16.0.rst\nindex 8592e5ebe95..769f1861e29 100644\n--- a/docs/release_notes/release_not... | [
{
"diff_hunk": "@@ -528,6 +536,39 @@ def _handle_boolean_masking(self, row_loc, col_loc):\n # Passing `slice(None)` as a row indexer since we've just applied it\n return type(self)(masked_df)[(slice(None), col_loc)]\n \n+ def _multiindex_possibly_contains_key(self, axis, key):\n+ \"\"\... | 18bbd7fc5aa37da25f7b42692bff153e3295c113 | diff --git a/docs/release_notes/release_notes-0.16.0.rst b/docs/release_notes/release_notes-0.16.0.rst
index 8592e5ebe95..769f1861e29 100644
--- a/docs/release_notes/release_notes-0.16.0.rst
+++ b/docs/release_notes/release_notes-0.16.0.rst
@@ -21,6 +21,7 @@ Key Features and Updates
* FIX-#4641: Reindex pandas parti... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
modin-project__modin-4674@308bff2 | modin-project/modin | Python | 4,674 | FIX-#4660: Fix `fillna` when Modin series object is an argument | Signed-off-by: Myachev <anatoly.myachev@intel.com>
<!--
Thank you for your contribution!
Please review the contributing docs: https://modin.readthedocs.io/en/latest/development/contributing.html
if you have questions about contributing.
-->
## What do these changes do?
<!-- Please give a short brief about ... | 2022-07-13T12:21:39Z | Fillna doesn't work when series object is an argument
### System information
- **OS Platform and Distribution (e.g., Linux Ubuntu 16.04)**:
- **Modin version** (`modin.__version__`):
- **Python version**:
- **Code we can use to reproduce**:
```python
import modin.pandas as pd
df = pd.DataFrame({'a': ['a'], '... | As far as I can tell, it seems like something's going awry in `broadcast_axis_partitions`, on [this line](https://github.com/modin-project/modin/blob/35782883efd7e22f8e29a7c9887a4453adabf783/modin/core/dataframe/pandas/partitioning/partition_manager.py#L462): the value in the partition seems to be changed when the data... | [
{
"body": "### System information\r\n- **OS Platform and Distribution (e.g., Linux Ubuntu 16.04)**:\r\n- **Modin version** (`modin.__version__`):\r\n- **Python version**:\r\n- **Code we can use to reproduce**:\r\n\r\n```python\r\nimport modin.pandas as pd\r\n\r\ndf = pd.DataFrame({'a': ['a'], 'b': ['b'],}, inde... | ee6c6ae752f0890e966777f4d0f5a688db8d0f38 | {
"head_commit": "308bff2839cba761e87038213a724d8f8435447d",
"head_commit_message": "remove new parameter from _copartition func\n\nSigned-off-by: Myachev <anatoly.myachev@intel.com>",
"patch_to_review": "diff --git a/docs/release_notes/release_notes-0.16.0.rst b/docs/release_notes/release_notes-0.16.0.rst\nindex... | [
{
"diff_hunk": "@@ -2658,6 +2660,8 @@ def n_ary_op(self, op, right_frames: list, join_type=\"outer\"):\n Modin DataFrames to join with.\n join_type : str, default: \"outer\"\n Type of join to apply.\n+ perform_column_reindex : bool, default: True\n+ For some ops... | 59d5939104f006f191112edf56a85382bb1474d4 | diff --git a/modin/core/dataframe/pandas/dataframe/dataframe.py b/modin/core/dataframe/pandas/dataframe/dataframe.py
index 5b60d54191c..f539cbbcaae 100644
--- a/modin/core/dataframe/pandas/dataframe/dataframe.py
+++ b/modin/core/dataframe/pandas/dataframe/dataframe.py
@@ -2646,7 +2646,9 @@ def _copartition(self, axis, ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
modin-project__modin-4592@ab785a1 | modin-project/modin | Python | 4,592 | FIX-#4411: Fix binary_op between datetime64 Series and pandas timedelta | <!--
Thank you for your contribution!
Please review the contributing docs: https://modin.readthedocs.io/en/latest/development/contributing.html
if you have questions about contributing.
-->
## What do these changes do?
This PR addresses #4411 which tried to add a pandas.timedeltas to a datetime64 Series. The ... | 2022-06-22T20:21:06Z | modin datetime Series fails when touches pandas timedeltas
### System information
- **OS Platform and Distribution**: Ubuntu 18.04.5 LTS
- **Modin version**: 0.14.0
- **Python version**: 3.8.5
- **Code to reproduce**:
`modin.pandas.date_range('2000-12-12','2000-12-13').to_series().pipe(modin.pandas.Series) + m... | @iliya-malecki thank you for reporting this bug. In can reproduce it at Modin commit 5825856a4ee19ff0dd5d1beaf6090bf601d0b411. Here's a copy-pastable script to reproduce the bug:
```python
import modin.pandas as pd
import numpy as np
import pandas
# Make a modin series of dates
s = pd.Series(np.datetime64("20... | [
{
"body": "### System information\r\n- **OS Platform and Distribution**: Ubuntu 18.04.5 LTS\r\n- **Modin version**: 0.14.0\r\n- **Python version**: 3.8.5\r\n- **Code to reproduce**:\r\n `modin.pandas.date_range('2000-12-12','2000-12-13').to_series().pipe(modin.pandas.Series) + modin.pandas.to_timedelta([1,2]... | 8efd8f765fffcd7166a78471620a942174ee8086 | {
"head_commit": "ab785a1c2a2adea52a6a83f32f96046d48f51764",
"head_commit_message": "Added release notes",
"patch_to_review": "diff --git a/docs/release_notes/release_notes-0.16.0.rst b/docs/release_notes/release_notes-0.16.0.rst\nindex a3f1deeb9f1..aba3fe35671 100644\n--- a/docs/release_notes/release_notes-0.16.... | [
{
"diff_hunk": "@@ -1141,6 +1141,20 @@ def test_between_time():\n )\n \n \n+def test_time_ops():\n+ # Make a pandas.core.indexes.timedeltas.TimedeltaIndex\n+ deltas = pd.to_timedelta([1], unit=\"h\")\n+ modin_series = pd.Series(np.datetime64(\"2000-12-12\")) + deltas\n+ pandas_series = pandas.Se... | ef4437975d3b4fff0332628591f84b2d4c11890b | diff --git a/docs/release_notes/release_notes-0.16.0.rst b/docs/release_notes/release_notes-0.16.0.rst
index a3f1deeb9f1..aba3fe35671 100644
--- a/docs/release_notes/release_notes-0.16.0.rst
+++ b/docs/release_notes/release_notes-0.16.0.rst
@@ -11,6 +11,7 @@ Key Features and Updates
* FIX-#4059: Add cell-wise execut... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
modin-project__modin-4519@f036d43 | modin-project/modin | Python | 4,519 | FIX-#4518: Fix Modin Logging to report specific Modin warnings/errors | Signed-off-by: Naren Krishna <naren@ponder.io>
<!--
Thank you for your contribution!
Please review the contributing docs: https://modin.readthedocs.io/en/latest/development/contributing.html
if you have questions about contributing.
-->
## What do these changes do?
Modin Logging currently reports several l... | 2022-06-01T15:16:19Z | Fix Modin Logging to report specific errors instead of error API calls
### Describe the problem
Modin Logging reports several lines like:
> 88001, 4538414592, 2022-05-26,16:44:07.377470, START::MODIN-ERROR::ErrorMessage.catch_bugs_and_request_email
> 88001, 4538414592, 2022-05-26,16:44:07.377538, STOP::MODIN-ERR... | [
{
"body": "### Describe the problem\r\n\r\nModin Logging reports several lines like:\r\n\r\n> 88001, 4538414592, 2022-05-26,16:44:07.377470, START::MODIN-ERROR::ErrorMessage.catch_bugs_and_request_email\r\n> 88001, 4538414592, 2022-05-26,16:44:07.377538, STOP::MODIN-ERROR::ErrorMessage.catch_bugs_and_request_em... | 3d4404e9d9a9b2a3327f8aee664a8e71ac1f18b8 | {
"head_commit": "f036d43b57b05ba334c7c907f4d1455943561056",
"head_commit_message": "remove single warning log line\n\nSigned-off-by: Naren Krishna <naren@ponder.io>",
"patch_to_review": "diff --git a/docs/release_notes/release_notes-0.15.0.rst b/docs/release_notes/release_notes-0.15.0.rst\nindex b24efe1df39..c66... | [
{
"diff_hunk": "@@ -33,7 +33,6 @@ def not_implemented(cls, message=\"\"):\n )\n \n @classmethod\n- @logger_decorator(\"MODIN-ERROR\", \"ErrorMessage.single_warning\", \"debug\")\n def single_warning(cls, message):\n message_hash = hash(message)\n if message_hash in cls.printed... | dfd6dd397267a3f4c9319a17bb8a587e8e4845b7 | diff --git a/docs/release_notes/release_notes-0.15.0.rst b/docs/release_notes/release_notes-0.15.0.rst
index b24efe1df39..c66b661150a 100644
--- a/docs/release_notes/release_notes-0.15.0.rst
+++ b/docs/release_notes/release_notes-0.15.0.rst
@@ -22,6 +22,7 @@ Key Features and Updates
* FIX-#4461: Fix S3 CSV data path... | {
"difficulty": "low",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
modin-project__modin-4601@8c1fe3d | modin-project/modin | Python | 4,601 | FEAT-#3535: Implement partition shuffling mechanism and algebra sort_by | <!--
Thank you for your contribution!
Please review the contributing docs: https://modin.readthedocs.io/en/latest/development/contributing.html
if you have questions about contributing.
-->
## What do these changes do?
<!-- Please give a short brief about these changes. -->
- [x] commit message follows for... | 2022-06-24T03:05:33Z | Improved shuffling mechanism for Ray
Currently, we do not have a good general purpose shuffle. Ideally, we would have a mechanism that could split the data based on some split function or based on some features of the data (e.g. the quantiles of the column for numeric data). | I have been testing an implementation of a numerical sort (not a general purpose shuffle) using Ray actors on an 800 MB test dataset [here](https://drive.google.com/file/d/1pMm8As4IdR_-PfAeI9ZdIuDpCllO8pF7/view?usp=sharing). You can view my latest script [here](https://github.com/mvashishtha/modin/blob/0a3acc150b0856b8... | [
{
"body": "Currently, we do not have a good general purpose shuffle. Ideally, we would have a mechanism that could split the data based on some split function or based on some features of the data (e.g. the quantiles of the column for numeric data). ",
"number": 3535,
"title": "Improved shuffling mechan... | cfcf1507e8262cdb9676a7ac30e79f97e506c054 | {
"head_commit": "8c1fe3d5e72f0f4e2f6d2ba86f165d895b7f3698",
"head_commit_message": "Address review comments\n\nSigned-off-by: Rehan Durrani <rehan@ponder.io>",
"patch_to_review": "diff --git a/modin/core/dataframe/pandas/dataframe/dataframe.py b/modin/core/dataframe/pandas/dataframe/dataframe.py\nindex 3f3194216... | [
{
"diff_hunk": "@@ -2006,83 +2007,84 @@ def sort_function(df):\n return df\n \n axis = Axis(axis)\n- if axis == Axis.ROW_WISE:\n- # If this df is empty, we don't want to try and shuffle or sort.\n- if len(self.axes[0]) == 0 or len(self.axes[1]) == 0:\n- ... | f02961a752b97c00703a5b500806ca3e494091dd | diff --git a/modin/core/dataframe/pandas/dataframe/dataframe.py b/modin/core/dataframe/pandas/dataframe/dataframe.py
index 3f31942162f..3e9a5a82477 100644
--- a/modin/core/dataframe/pandas/dataframe/dataframe.py
+++ b/modin/core/dataframe/pandas/dataframe/dataframe.py
@@ -38,6 +38,7 @@
Axis,
JoinType,
)
+fro... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
modin-project__modin-4535@2b626ee | modin-project/modin | Python | 4,535 | REFACTOR-#4534: Replace logging meta class with class decorator | <!--
Thank you for your contribution!
Please review the contributing docs: https://modin.readthedocs.io/en/latest/development/contributing.html
if you have questions about contributing.
-->
## What do these changes do?
Change the implementation of auto-adding the logging to class decorator and a base class usin... | 2022-06-07T15:37:12Z | Simplify logging design - remove metaclass
**Is your feature request related to a problem? Please describe.**
In some cases, having a custom `metaclass` would harden inheritance.
Plus I feel that it complicates the design a little bit, one of example of that would be the introduction of `metaclass_resolver` which a... | [
{
"body": "**Is your feature request related to a problem? Please describe.**\r\nIn some cases, having a custom `metaclass` would harden inheritance.\r\n\r\nPlus I feel that it complicates the design a little bit, one of example of that would be the introduction of `metaclass_resolver` which aim was to solve ar... | 4ec7f6347903f9133c65ebc5b6e0e15553b98577 | {
"head_commit": "2b626ee470a19608b5e7e838d0b7c0818e6c19dc",
"head_commit_message": "Address review comment, move release notes\n\nSigned-off-by: Vasily Litvinov <fam1ly.n4me@yandex.ru>",
"patch_to_review": "diff --git a/docs/release_notes/release_notes-0.15.0.rst b/docs/release_notes/release_notes-0.15.0.rst\nin... | [
{
"diff_hunk": "@@ -0,0 +1,56 @@\n+# Licensed to Modin Development Team under one or more contributor license agreements.\n+# See the NOTICE file distributed with this work for additional information regarding\n+# copyright ownership. The Modin Development Team licenses this file to you under the\n+# Apache Li... | 49a6ae68444f36f63966a4e5f8ae2f84b3f1cae2 | diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 797f94536ec..ce0686a4fc3 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -261,6 +261,7 @@ jobs:
- run: python -m pytest modin/test/test_utils.py
- run: python -m pytest asv_bench/test/test_utils.py
- run:... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Code Refactoring / Architectural Improvement"
} | |
modin-project__modin-4472@936b268 | modin-project/modin | Python | 4,472 | FIX-#4449 Drain the call queue before waiting on result in benchmark mode. | <!--
Thank you for your contribution!
Please review the contributing docs: https://modin.readthedocs.io/en/latest/development/contributing.html
if you have questions about contributing.
-->
## What do these changes do?
<!-- Please give a short brief about these changes. -->
- [x] commit message follows for... | 2022-05-19T17:55:24Z | Benchmark Mode blocks on computation so all computation occurs on one node
### System information
- **OS Platform and Distribution (e.g., Linux Ubuntu 16.04)**:
- **Modin version** (`modin.__version__`):
- **Python version**:
- **Code we can use to reproduce**:
<!--
You can obtain the Modin version with
pyth... | I just want to clarify that the bug applies only when we have a function like a transpose or a reindex that adds a remote function to each partition's call queue, but doesn't trigger the function's execution. In that case, benchmark mode will [trigger](https://github.com/modin-project/modin/blob/c17dde71ae8114723a13279... | [
{
"body": "### System information\r\n- **OS Platform and Distribution (e.g., Linux Ubuntu 16.04)**:\r\n- **Modin version** (`modin.__version__`):\r\n- **Python version**:\r\n- **Code we can use to reproduce**:\r\n\r\n<!--\r\nYou can obtain the Modin version with\r\n\r\npython -c \"import modin; print(modin.__ve... | cf0eb393daa41abdd8cdf32b52ceee938cdcbe1a | {
"head_commit": "936b268b3c2da946b19d3e9330748d2cd7fc2c5d",
"head_commit_message": "Add a release note.\n\nSigned-off-by: mvashishtha <mahesh@ponder.io>",
"patch_to_review": "diff --git a/docs/release_notes/release_notes-0.15.0.rst b/docs/release_notes/release_notes-0.15.0.rst\nindex 52d41b5b8f1..827e14267bd 100... | [
{
"diff_hunk": "@@ -60,6 +60,13 @@ def wait(*args, **kwargs):\n partitions = result[0]\n else:\n partitions = result\n+ # When partitions have a deferred call queue, calling\n+ # parittion.wait() on each partition serially will serially kick",
... | 6f95eff5db3b74df43d20a78384f6091a28969c8 | diff --git a/docs/release_notes/release_notes-0.15.0.rst b/docs/release_notes/release_notes-0.15.0.rst
index 52d41b5b8f1..827e14267bd 100644
--- a/docs/release_notes/release_notes-0.15.0.rst
+++ b/docs/release_notes/release_notes-0.15.0.rst
@@ -18,6 +18,7 @@ Key Features and Updates
* FIX-#4394: Fix issue with multi... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
modin-project__modin-4468@43bf640 | modin-project/modin | Python | 4,468 | FIX-#4467: 'drop_duplicates' no longer removes items based on index value |
Signed-off-by: Joshua Sacher <joshuasacher@gmail.com>
<!--
Thank you for your contribution!
Please review the contributing docs: https://modin.readthedocs.io/en/latest/development/contributing.html
if you have questions about contributing.
-->
## What do these changes do?
Fix a case where, if index value... | 2022-05-18T21:03:12Z | drop_duplicates after pd.concat not working as expected
### System information
- **OS Platform and Distribution (e.g., Linux Ubuntu 16.04)**: MacOS 12.3.1
- **Modin version** (`modin.__version__`): 0.14.1
- **Python version**: Python 3.9.12
- **Code we can use to reproduce**:
```python
import pandas as pd
impo... | Tested with both Ray and Dask as the engine. Both give the same results.
Think I found the issue in `BasePandasDataset` class in `base.py`
```python
def drop_duplicates(
self, keep="first", inplace=False, **kwargs
): # noqa: PR01, RT01, D200
"""
Return `BasePandasDataset` with d... | [
{
"body": "### System information\r\n- **OS Platform and Distribution (e.g., Linux Ubuntu 16.04)**: MacOS 12.3.1\r\n- **Modin version** (`modin.__version__`): 0.14.1\r\n- **Python version**: Python 3.9.12\r\n- **Code we can use to reproduce**:\r\n\r\n```python\r\nimport pandas as pd\r\nimport modin.pandas as mp... | 49fc2cf3733f20ac6cf8a7c61e42ef7aa5cf4b03 | {
"head_commit": "43bf640d93ec4cb2210124a1fb353b083c5cfbcd",
"head_commit_message": "FIX-#4467: 'drop_duplicates' no longer removes items based on index value\n\nSigned-off-by: Joshua Sacher <joshuasacher@gmail.com>",
"patch_to_review": "diff --git a/docs/release_notes/release_notes-0.15.0.rst b/docs/release_note... | [
{
"diff_hunk": "@@ -1396,8 +1397,15 @@ def drop_duplicates(\n duplicates = self.duplicated(keep=keep, subset=subset)\n else:\n duplicates = self.duplicated(keep=keep)\n- indices = duplicates.values.nonzero()[0]\n- return self.drop(index=self.index[indices], inplace=... | 67888a6bc54a576c6ec375812bab8bf30d80f0fc | diff --git a/docs/release_notes/release_notes-0.15.0.rst b/docs/release_notes/release_notes-0.15.0.rst
index 2ce5043f784..05e2580d860 100644
--- a/docs/release_notes/release_notes-0.15.0.rst
+++ b/docs/release_notes/release_notes-0.15.0.rst
@@ -20,6 +20,7 @@ Key Features and Updates
* FIX-#4457: Fix `loc` in case wh... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
modin-project__modin-4256@9b229cc | modin-project/modin | Python | 4,256 | FIX-#3368: support unsigned integers in OmniSci backend | <!--
Thank you for your contribution!
Please review the contributing docs: https://modin.readthedocs.io/en/latest/development/contributing.html
if you have questions about contributing.
-->
## What do these changes do?
This PR introduces a native workaround for working with unsigned integers via OmniSci backe... | 2022-02-23T15:12:20Z | RuntimeError: uint8 is not yet supported.
### System information
- **OS Platform and Distribution (e.g., Linux Ubuntu 16.04)**: `Ubuntu 20.04`
- **Modin version** (`modin.__version__`): `0.10.2` (from conda-forge)
- **Python version**: `3.9.6`
- **Code we can use to reproduce**:
```shell
conda install modin-omn... | @dchigarev can you take a look?
As far as I know, OmniSci doesn't support uints for most operations.
cc @ienkovich , @fexolm
it seems that PyDBE (not sure about OmniSci itself) does not support unsigned integers at all:
<details><summary>Reproducer</summary>
```python
import sys
sys.setdlopenflags(1 | 256... | [
{
"body": "### System information\r\n- **OS Platform and Distribution (e.g., Linux Ubuntu 16.04)**: `Ubuntu 20.04`\r\n- **Modin version** (`modin.__version__`): `0.10.2` (from conda-forge)\r\n- **Python version**: `3.9.6`\r\n- **Code we can use to reproduce**:\r\n\r\n```shell\r\nconda install modin-omnisci -c c... | e7cb2e82f8b9c7a68f82abdd3b6011d661230b7e | {
"head_commit": "9b229ccf7f6ecb0e912c51c89fe3b9923a4b844a",
"head_commit_message": "Fix flake formatting\n\nSigned-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>",
"patch_to_review": "diff --git a/docs/release_notes/release_notes-0.14.0.rst b/docs/release_notes/release_notes-0.14.0.rst\nindex a2f1ba12594..a... | [
{
"diff_hunk": "@@ -178,6 +179,32 @@ def __init__(self, *dfs):\n def __enter__(self):\n return self\n \n+ def export_frames(self):\n+ \"\"\"\n+ Export tables from OmniSci that was imported by this instance.\n+\n+ Returns\n+ -------\n+ list of modin DataFrames\n+... | b20f135e973f8863b4b41a9ff3701122d2cd07aa | diff --git a/docs/release_notes/release_notes-0.14.0.rst b/docs/release_notes/release_notes-0.14.0.rst
index a2f1ba12594..a777f37cc67 100644
--- a/docs/release_notes/release_notes-0.14.0.rst
+++ b/docs/release_notes/release_notes-0.14.0.rst
@@ -13,6 +13,7 @@ Key Features and Updates
* FIX-#4158: Do not print OmniSci... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
modin-project__modin-4203@9ebb408 | modin-project/modin | Python | 4,203 | TEST-#4201: Add read_parquet, explode, tail, and various arithmetic t… | Signed-off-by: Naren Krishna <naren@ponder.io>
<!--
Thank you for your contribution!
Please review the contributing docs: https://modin.readthedocs.io/en/latest/development/contributing.html
if you have questions about contributing.
-->
## What do these changes do?
Linked to #4201
- [x] commit message ... | 2022-02-15T15:26:26Z | TEST: Add more functions to asv_bench
**Is your feature request related to a problem? Please describe.**
We want to ensure that the most commonly used Pandas functions are a part of `asv_bench` and that they are running benchmarks on different dataset sizes across different numbers of CPUs comparing Modin vs. Pandas... | [
{
"body": "**Is your feature request related to a problem? Please describe.**\r\n\r\nWe want to ensure that the most commonly used Pandas functions are a part of `asv_bench` and that they are running benchmarks on different dataset sizes across different numbers of CPUs comparing Modin vs. Pandas.\r\n\r\nA clea... | dd7fc1bd54c8c34e38562eb18d1c0bcc0da53415 | {
"head_commit": "9ebb408af1da6a5bdf113e9459852ac0cdeb0ab4",
"head_commit_message": "address comments\n\nSigned-off-by: Naren Krishna <naren@ponder.io>",
"patch_to_review": "diff --git a/asv_bench/benchmarks/benchmarks.py b/asv_bench/benchmarks/benchmarks.py\nindex e991575b53c..445c9d8f77d 100644\n--- a/asv_bench... | [
{
"diff_hunk": "@@ -0,0 +1,58 @@\n+# Licensed to Modin Development Team under one or more contributor license agreements.\n+# See the NOTICE file distributed with this work for additional information regarding\n+# copyright ownership. The Modin Development Team licenses this file to you under the\n+# Apache Li... | c8a781bee5a37d64771db4e3449d43ea1b669fd8 | diff --git a/asv_bench/benchmarks/benchmarks.py b/asv_bench/benchmarks/benchmarks.py
index e991575b53c..445c9d8f77d 100644
--- a/asv_bench/benchmarks/benchmarks.py
+++ b/asv_bench/benchmarks/benchmarks.py
@@ -302,6 +302,9 @@ def setup(self, shape, axis):
def time_sum(self, shape, axis):
execute(self.df.su... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
modin-project__modin-4215@69f9652 | modin-project/modin | Python | 4,215 | FIX-#3442: Add support for dt.hour in omnisci | Signed-off-by: izamyati <igor.zamyatin@intel.com>
<!--
Thank you for your contribution!
Please review the contributing docs: https://modin.readthedocs.io/en/latest/development/contributing.html
if you have questions about contributing.
-->
## What do these changes do?
<!-- Please give a short brief about t... | 2022-02-17T09:11:13Z | [omnisci] Exception when trying to access datetime column via .dt accessor and add new column
### System information
- **OS Platform and Distribution (e.g., Linux Ubuntu 16.04)**:
Ubuntu 20.04.1 LTS
- **Modin version** (`modin.__version__`):
0.10.2+26.gda2ad792
- **Python version**:
Python 3.9.7
- **... | Is this fixed?
> Is this fixed?
It was kind of fixed in https://github.com/modin-project/modin/pull/3460 for `Series.dt.day` because the actual problem was because code went into "default to pandas" mode. After `Series.dt.day` is implemented, it doesn't fail for `day` but it may fail for `hour` and it may fail for o... | [
{
"body": "### System information\r\n- **OS Platform and Distribution (e.g., Linux Ubuntu 16.04)**:\r\n\r\nUbuntu 20.04.1 LTS\r\n\r\n- **Modin version** (`modin.__version__`):\r\n\r\n0.10.2+26.gda2ad792\r\n\r\n- **Python version**:\r\n\r\nPython 3.9.7\r\n\r\n- **Code we can use to reproduce**:\r\n\r\n```python\... | a6acfe269c4812da3898231a54bb8e66ce96e82d | {
"head_commit": "69f965213651368f313271fd984e37c3bd6c8e9a",
"head_commit_message": "Formatting fixes\n\nSigned-off-by: izamyati <igor.zamyatin@intel.com>",
"patch_to_review": "diff --git a/modin/experimental/core/execution/native/implementations/omnisci_on_native/test/test_dataframe.py b/modin/experimental/core/... | [
{
"diff_hunk": "@@ -1723,6 +1724,7 @@ class TestDateTime:\n \"c\": pandas.to_datetime(\n [\"20190902\", \"20180913\", \"20190921\", \"20180903\"], format=\"%Y%m%d\"\n ),\n+ \"d\": pandas.to_datetime([\"2018-10-26 12:00\", \"2018-10-26 13:00:15\"]),",
"line": null,
"ori... | dab6907e3de87b0cacdb8810901d545a5cf7a581 | diff --git a/modin/experimental/core/execution/native/implementations/omnisci_on_native/test/test_dataframe.py b/modin/experimental/core/execution/native/implementations/omnisci_on_native/test/test_dataframe.py
index 6e3c003b6f7..8454112b8fe 100644
--- a/modin/experimental/core/execution/native/implementations/omnisci_... | {
"difficulty": "low",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
modin-project__modin-4225@db17514 | modin-project/modin | Python | 4,225 | DOCS-#4224: Add info about Omnisci in Supported APIs sections | Signed-off-by: izamyati <igor.zamyatin@intel.com>
<!--
Thank you for your contribution!
Please review the contributing docs: https://modin.readthedocs.io/en/latest/development/contributing.html
if you have questions about contributing.
-->
## What do these changes do?
<!-- Please give a short brief about t... | 2022-02-18T13:34:23Z | Add info about Omnisci in Supported APIs sections
### System information
- **OS Platform and Distribution (e.g., Linux Ubuntu 16.04)**:
- **Modin version** (`modin.__version__`):
- **Python version**:
- **Code we can use to reproduce**:
<!--
You can obtain the Modin version with
python -c "import modin; prin... | [
{
"body": "### System information\r\n- **OS Platform and Distribution (e.g., Linux Ubuntu 16.04)**:\r\n- **Modin version** (`modin.__version__`):\r\n- **Python version**:\r\n- **Code we can use to reproduce**:\r\n\r\n<!--\r\nYou can obtain the Modin version with\r\n\r\npython -c \"import modin; print(modin.__ve... | 47b8a1ce82c7ff6d786da355edb034ffb1c21b4f | {
"head_commit": "db175143ab2e287ce59facc63785d38a1f368574",
"head_commit_message": "Some more updates for utilities part\n\nSigned-off-by: izamyati <igor.zamyatin@intel.com>",
"patch_to_review": "diff --git a/docs/supported_apis/dataframe_supported.rst b/docs/supported_apis/dataframe_supported.rst\nindex cf414a5... | [
{
"diff_hunk": "@@ -270,6 +290,7 @@ default to pandas.\n | ``pop`` | `pop`_ | Y | |\n +----------------------------+---------------------------+------------------------+---------------------------------... | 7a72b53b2271ab79cc5f111b2372c6e4c96ddcbb | diff --git a/docs/supported_apis/dataframe_supported.rst b/docs/supported_apis/dataframe_supported.rst
index cf414a51d24..a5cd7ea6781 100644
--- a/docs/supported_apis/dataframe_supported.rst
+++ b/docs/supported_apis/dataframe_supported.rst
@@ -7,11 +7,17 @@ of an operation that is listed as not implemented, feel free ... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "New Feature Additions"
} | |
modin-project__modin-4318@81e456f | modin-project/modin | Python | 4,318 | FIX-#4314: Allow passing a series of dtypes to astype. | Signed-off-by: mvashishtha <mahesh@ponder.io>
<!--
Thank you for your contribution!
Please review the contributing docs: https://modin.readthedocs.io/en/latest/development/contributing.html
if you have questions about contributing.
-->
## What do these changes do?
<!-- Please give a short brief about these... | 2022-03-11T20:53:34Z | Can't use astype() to assign a series of dtypes to a frame.
### System information
- **OS Platform and Distribution (e.g., Linux Ubuntu 16.04)**: MacOS Monterey
- **Modin version** (`modin.__version__`): latest source
- **Python version**: 3.9.10
- **Code we can use to reproduce**:
```python
import modin.pandas... | [
{
"body": "### System information\r\n- **OS Platform and Distribution (e.g., Linux Ubuntu 16.04)**: MacOS Monterey\r\n- **Modin version** (`modin.__version__`): latest source\r\n- **Python version**: 3.9.10\r\n- **Code we can use to reproduce**:\r\n\r\n```python\r\nimport modin.pandas as pd\r\ndf = pd.DataFrame... | e5d15f97e1393cd78036f3fc46a7c42f0963a5d9 | {
"head_commit": "81e456f080e8c2ca16a6bb8d89db883734e0f1bb",
"head_commit_message": "Delete a redundant import.\n\nSigned-off-by: mvashishtha <mahesh@ponder.io>",
"patch_to_review": "diff --git a/docs/release_notes/release_notes-0.14.0.rst b/docs/release_notes/release_notes-0.14.0.rst\nindex 99c9b6a6190..53145249... | [
{
"diff_hunk": "@@ -483,6 +483,32 @@ def test_astype():\n with pytest.raises(KeyError):\n modin_df.astype({\"not_exists\": np.uint8})\n \n+ # The dtypes series must have a unique index.\n+ with pytest.raises(ValueError):\n+ modin_df.astype(pd.Series([str, str], index=[\"col1\", \"col1\"... | ed09993ad20ac19aedf05f95e7087d6326b6d1aa | diff --git a/docs/release_notes/release_notes-0.14.0.rst b/docs/release_notes/release_notes-0.14.0.rst
index 2ccf36c3764..5ff583f4d32 100644
--- a/docs/release_notes/release_notes-0.14.0.rst
+++ b/docs/release_notes/release_notes-0.14.0.rst
@@ -25,6 +25,7 @@ Key Features and Updates
* FIX-#4308: Add proper error han... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
modin-project__modin-4192@efa6cdf | modin-project/modin | Python | 4,192 | DOCS-#4176: Update OmniSci usage section | Signed-off-by: izamyati <igor.zamyatin@intel.com>
<!--
Thank you for your contribution!
Please review the contributing docs: https://modin.readthedocs.io/en/latest/development/contributing.html
if you have questions about contributing.
-->
## What do these changes do?
<!-- Please give a short brief about t... | 2022-02-11T12:12:03Z | Update OmniSci usage section
We should mention that users have to set `IsExperimental` config or `MODIN_EXPERIMENTAL` env var in the case of setting `StorageFormat` to `omnisci` and `Engine` to `native`. Otherwise, the following error is arisen.
```python
FactoryNotFoundError: Omnisci on Native is only accessible t... | [
{
"body": "We should mention that users have to set `IsExperimental` config or `MODIN_EXPERIMENTAL` env var in the case of setting `StorageFormat` to `omnisci` and `Engine` to `native`. Otherwise, the following error is arisen.\r\n\r\n```python\r\nFactoryNotFoundError: Omnisci on Native is only accessible throu... | aebdb5223fa2368750247082f544ef43da2801c6 | {
"head_commit": "efa6cdf5385392ff51f0abb3580cc3ade2298ffe",
"head_commit_message": "release notes update\n\nSigned-off-by: izamyati <igor.zamyatin@intel.com>",
"patch_to_review": "diff --git a/docs/development/using_omnisci.rst b/docs/development/using_omnisci.rst\nindex 45cb8b1f31d..9ef1e8f2cc9 100644\n--- a/do... | [
{
"diff_hunk": "@@ -18,8 +18,15 @@ or use it in your code:\n import modin.config as cfg\n cfg.StorageFormat.put('omnisci')\n \n-Since OmniSci is run through its native engine Modin itself sets ``MODIN_ENGINE=Native``\n-and you might not specify it explicitly.\n+Since OmniSci is run through its native engi... | ccdd9ef9eddbddb2d89c6d49175397c5eb69c931 | diff --git a/docs/development/using_omnisci.rst b/docs/development/using_omnisci.rst
index 45cb8b1f31d..4621fad5da6 100644
--- a/docs/development/using_omnisci.rst
+++ b/docs/development/using_omnisci.rst
@@ -18,8 +18,17 @@ or use it in your code:
import modin.config as cfg
cfg.StorageFormat.put('omnisci')
-S... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "Documentation Updates"
} | |
modin-project__modin-4163@cb28ec8 | modin-project/modin | Python | 4,163 | FIX-#4162: Use `skipif` instead of `skip` for compatibility with pytest 7.0 |
Signed-off-by: Rehan Durrani <rehan@ponder.io>
<!--
Thank you for your contribution!
Please review the contributing docs: https://modin.readthedocs.io/en/latest/development/contributing.html
if you have questions about contributing.
-->
## What do these changes do?
<!-- Please give a short brief about ... | 2022-02-04T20:44:58Z | Pytest 7.0 requires us to use `skipif` instead of `skip` if providing a condition
### System information
- **OS Platform and Distribution (e.g., Linux Ubuntu 16.04)**:
- **Modin version** (`modin.__version__`):
- **Python version**:
- **Code we can use to reproduce**:
<!--
You can obtain the Modin version with
... | [
{
"body": "### System information\r\n- **OS Platform and Distribution (e.g., Linux Ubuntu 16.04)**:\r\n- **Modin version** (`modin.__version__`):\r\n- **Python version**:\r\n- **Code we can use to reproduce**:\r\n\r\n<!--\r\nYou can obtain the Modin version with\r\n\r\npython -c \"import modin; print(modin.__ve... | 31e6a1061fffa774102335dfcfa8de9ed5ad63e6 | {
"head_commit": "cb28ec8784bf2b75d2c85ff716f0be43ca9c7a83",
"head_commit_message": "Add release note\n\nSigned-off-by: Rehan Durrani <rehan@ponder.io>",
"patch_to_review": "diff --git a/docs/release_notes/release_notes-0.14.0.rst b/docs/release_notes/release_notes-0.14.0.rst\nindex 9cad243a471..6bd07de66ed 10064... | [
{
"diff_hunk": "@@ -28,10 +29,11 @@ Key Features and Updates\n * Documentation improvements\n * DOCS-#4077: Add release notes template to docs folder (#4078)\n * DOCS-#4082: Add pdf/epub/htmlzip formats for doc builds (#4083)\n+ * DOCS-#4079: Fix link to PandasDataframe in docs (#4108)",
"line": null,
... | c0892c10b2a80b5d92b6a5e6f607863e9d886054 | diff --git a/docs/release_notes/release_notes-0.14.0.rst b/docs/release_notes/release_notes-0.14.0.rst
index 9cad243a471..9ed36b81fe6 100644
--- a/docs/release_notes/release_notes-0.14.0.rst
+++ b/docs/release_notes/release_notes-0.14.0.rst
@@ -9,6 +9,7 @@ Key Features and Updates
* FIX-#4105: Fix names of pandas op... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Test Suite / CI Enhancements"
} | |
modin-project__modin-4152@7795c6e | modin-project/modin | Python | 4,152 | DOCS-#4151: Add info in troubleshooting page related to Dask engine usage | Signed-off-by: Alexey Prutskov <alexey.prutskov@intel.com>
<!--
Thank you for your contribution!
Please review the contributing docs: https://modin.readthedocs.io/en/latest/development/contributing.html
if you have questions about contributing.
-->
## What do these changes do?
PR adds info in troubleshooti... | 2022-02-04T10:57:10Z | Add info in troubleshooting page related to creating Dask Client in the `main` block
Users can be faced with issues like that when Modin on Dask is used:
```bash
File "/home/u119434/.conda/envs/intel-modin/lib/python3.9/multiprocessing/spawn.py", line 134, in _check_not_importing_main
raise RuntimeError('''
R... | [
{
"body": "Users can be faced with issues like that when Modin on Dask is used:\r\n\r\n```bash\r\nFile \"/home/u119434/.conda/envs/intel-modin/lib/python3.9/multiprocessing/spawn.py\", line 134, in _check_not_importing_main\r\n raise RuntimeError('''\r\nRuntimeError: \r\n An attempt has been made to s... | 99e8507cf11c358d352d643479e9ed838a516b55 | {
"head_commit": "7795c6e1f537cfc240950dd753c05318b055d36b",
"head_commit_message": "Apply review suggestions",
"patch_to_review": "diff --git a/docs/getting_started/troubleshooting.rst b/docs/getting_started/troubleshooting.rst\nindex 0476afc989d..bd2815200b3 100644\n--- a/docs/getting_started/troubleshooting.rs... | [
{
"diff_hunk": "@@ -217,5 +217,79 @@ This can happen when you use OmniSci engine along with ``pyarrow.gandiva``:\n \n Do not use OmniSci engine along with ``pyarrow.gandiva``.\n \n+Error when using Dask engine: ``RuntimeError: if __name__ == '__main__':``\n+\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"... | 1bff6d3a9e1d521606c52b861e947359a3182fb7 | diff --git a/docs/getting_started/troubleshooting.rst b/docs/getting_started/troubleshooting.rst
index 0476afc989d..c5b4572ae5a 100644
--- a/docs/getting_started/troubleshooting.rst
+++ b/docs/getting_started/troubleshooting.rst
@@ -217,5 +217,79 @@ This can happen when you use OmniSci engine along with ``pyarrow.gandi... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "Documentation Updates"
} | |
modin-project__modin-4045@189006e | modin-project/modin | Python | 4,045 | FIX-#4044: Update module layout with the ModinDataframe | Signed-off-by: Rehan Durrani <rehan@ponder.io>
<!--
Thank you for your contribution!
Please review the contributing docs: https://modin.readthedocs.io/en/latest/developer/contributing.html
if you have questions about contributing.
-->
## What do these changes do?
This PR updates the System Architecture docum... | 2022-01-24T18:05:48Z | Fix documentation after algebra refactor
**Is your feature request related to a problem? Please describe.**
A clear and concise description of what the problem is. What kind of performance improvements would you like to see with this new API?
The module layout in the system architecture doc is now inaccurate thanks t... | [
{
"body": "**Is your feature request related to a problem? Please describe.**\r\nA clear and concise description of what the problem is. What kind of performance improvements would you like to see with this new API?\r\nThe module layout in the system architecture doc is now inaccurate thanks to both the major r... | 154697bc2fe1fb69330d759b4bd7edc39532c6cf | {
"head_commit": "189006efff4ebfc0ccfc54124aa01dca9ad0f272",
"head_commit_message": "FIX-#4044: Update module layout with the ModinDataframe\n\nSigned-off-by: Rehan Durrani <rehan@ponder.io>",
"patch_to_review": "diff --git a/docs/flow/modin/core/dataframe/base/dataframe.rst b/docs/flow/modin/core/dataframe/base/... | [
{
"diff_hunk": "@@ -1,28 +1,25 @@\n Purpose\n =======\n \n-``BaseDataframe`` serves the purpose of describing and defining the :doc:`Core Dataframe Algebra </flow/modin/core/dataframe/algebra>`.\n+The ``ModinDataframe`` serves the purpose of describing and defining the :doc:`Core Dataframe Algebra </flow/modin/... | 610e51cc8050dd025a895a994f9eb9d8afb9ef2a | diff --git a/docs/flow/modin/core/dataframe/base/dataframe.rst b/docs/flow/modin/core/dataframe/base/dataframe.rst
new file mode 100644
index 00000000000..94e0f8e7037
--- /dev/null
+++ b/docs/flow/modin/core/dataframe/base/dataframe.rst
@@ -0,0 +1,21 @@
+ModinDataframe
+""""""""""""""
+
+The :py:class:`~modin.core.data... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Documentation Updates"
} | |
modin-project__modin-3986@46bbaf8 | modin-project/modin | Python | 3,986 | FIX-#3985: Update pyarrow in environment files | Signed-off-by: Igoshev, Yaroslav <yaroslav.igoshev@intel.com>
<!--
Thank you for your contribution!
Please review the contributing docs: https://modin.readthedocs.io/en/latest/developer/contributing.html
if you have questions about contributing.
-->
## What do these changes do?
<!-- Please give a short bri... | 2022-01-17T12:03:49Z | Update pyarrow in environment files
When creating an env from enviroment.yml pyarrow 3.0.0 is installed. At the same time, when installing modin-ray and modin-omnisci in the same env pyarrow 5.0.0 is installed. So we should update pyarrow in requirement-dev.txt and enviroment.yml files to check correctness tests pass w... | [
{
"body": "When creating an env from enviroment.yml pyarrow 3.0.0 is installed. At the same time, when installing modin-ray and modin-omnisci in the same env pyarrow 5.0.0 is installed. So we should update pyarrow in requirement-dev.txt and enviroment.yml files to check correctness tests pass with a newer pyarr... | be2716f393fddd2f669f26616f80e051fc7ceee6 | {
"head_commit": "46bbaf82ab384fe42daac7c3d13f89dbb87bd2dc",
"head_commit_message": "FIX-#3985: Update pyarrow in environment files\n\nSigned-off-by: Igoshev, Yaroslav <yaroslav.igoshev@intel.com>",
"patch_to_review": "diff --git a/environment-dev.yml b/environment-dev.yml\nindex 849df864b3a..665cd9cbce4 100644\n... | [
{
"diff_hunk": "@@ -4,7 +4,7 @@ channels:\n dependencies:\n - pandas==1.3.5\n - numpy>=1.16.5\n- - pyarrow>=1.0.0\n+ - pyarrow>=6.*",
"line": null,
"original_line": 7,
"original_start_line": null,
"path": "environment-dev.yml",
"start_line": null,
"text": "@user1:\nDon't use relati... | c547be4a2e1e6646581186d71c38908aef6591f8 | diff --git a/environment-dev.yml b/environment-dev.yml
index 849df864b3a..05ffcb23609 100644
--- a/environment-dev.yml
+++ b/environment-dev.yml
@@ -4,8 +4,7 @@ channels:
dependencies:
- pandas==1.3.5
- numpy>=1.16.5
- - pyarrow>=1.0.0
- - libthrift<0.14.1 # ref: modin gh-2840
+ - pyarrow>=4.0.1
- dask[co... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "Dependency Updates & Env Compatibility"
} |
Subsets and Splits
Review Test Instances
Retrieves basic metadata about code review instances but doesn't provide any analytical insights or patterns beyond raw data access.