instance_id stringlengths 21 53 | repo stringclasses 188
values | language stringclasses 1
value | pull_number int64 20 148k | title stringlengths 6 144 | body stringlengths 0 83.4k | created_at stringdate 2015-09-25 03:17:17 2025-07-10 16:50:35 | problem_statement stringlengths 188 240k | hints_text stringlengths 0 145k | resolved_issues listlengths 1 6 | base_commit stringlengths 40 40 | commit_to_review dict | reference_review_comments listlengths 1 62 | merged_commit stringlengths 40 40 | merged_patch stringlengths 297 9.87M | metadata dict |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
scipy__scipy-11425@2fdafaa | scipy/scipy | Python | 11,425 | FIX: _array_newton should preserve complex inputs | #### Reference issue
Closes gh-11412
#### What does this implement/fix?
Instead of casting the input with `dtype=float`, use `np.promote_types` to promote integer types but leave complex types unchanged. This will also avoid truncating `np.longfloat` input as well. | 2020-01-27T17:58:11Z | Array copying causes unwanted type casting from complex to float in _array_newton
<!--
Thank you for taking the time to file a bug report.
Please fill in the fields below, deleting the sections that
don't apply to your issue. You can view the final output
by clicking the preview button above.
Note: This is a co... | My assumption is that the dtype=float is to handle the case of starting with an array of integer values, say. The dtype needed is a type that can store both the provided x0, the desired type of the final result, and the type of any intermediate results. [To find the zeros of a complex function, the np.array needs to ... | [
{
"body": "<!-- \r\nThank you for taking the time to file a bug report. \r\nPlease fill in the fields below, deleting the sections that \r\ndon't apply to your issue. You can view the final output\r\nby clicking the preview button above.\r\nNote: This is a comment, and won't appear in the output.\r\n-->\r\n### ... | 04c59ef48e66675f9902e88163506f3843fccdfb | {
"head_commit": "2fdafaa1259fe41d6a600ab6f91eeb87ef6948a3",
"head_commit_message": "FIX: _array_newton should handle real x0 and complex f(x0)",
"patch_to_review": "diff --git a/scipy/optimize/tests/test_zeros.py b/scipy/optimize/tests/test_zeros.py\nindex e3557da28664..6501d9a2e631 100644\n--- a/scipy/optimize/... | [
{
"diff_hunk": "@@ -374,24 +374,24 @@ def _array_newton(func, x0, fprime, args, tol, maxiter, fprime2, full_output):\n \"\"\"\n # Explicitly copy `x0` as `p` will be modified inplace, but the\n # user's array should not be altered.\n- try:\n- p = np.array(x0, copy=True, dtype=float)\n- ... | 69e53dbcf3c86cd3cf712138f3bd46d7c376c1d7 | diff --git a/scipy/optimize/tests/test_zeros.py b/scipy/optimize/tests/test_zeros.py
index e3557da28664..6501d9a2e631 100644
--- a/scipy/optimize/tests/test_zeros.py
+++ b/scipy/optimize/tests/test_zeros.py
@@ -341,6 +341,25 @@ def f1_2(x, *a):
x = zeros.newton(f1, x0, args=args)
assert_allclose(x, x_... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
scipy__scipy-11096@584d19e | scipy/scipy | Python | 11,096 | BUG: scipy.sparse.csgraph: fixed issue #10774 | <!--
Thanks for contributing a pull request! Please ensure that
your PR satisfies the checklist before submitting:
http://scipy.github.io/devdocs/dev/contributor/development_workflow.html#checklist-before-submitting-a-pr
Also, please name and describe your PR as you would write a
commit message:
https://docs.s... | 2019-11-20T00:36:12Z | min_only=true djisktra infinite loop with duplicate indices
<!--
Thank you for taking the time to file a bug report.
Please fill in the fields below, deleting the sections that
don't apply to your issue. You can view the final output
by clicking the preview button above.
Note: This is a comment, and won't appea... | @fcollman thanks for the report. Can you add a self-contained code example to reproduce the issue you're seeing?
sure working on it now... I think this is likely a bug with code i submitted so was going to follow it up with a PR that at least has a test with a failure, but hopefully a fix too.
@fcollman that would be g... | [
{
"body": "<!-- \r\nThank you for taking the time to file a bug report. \r\nPlease fill in the fields below, deleting the sections that \r\ndon't apply to your issue. You can view the final output\r\nby clicking the preview button above.\r\nNote: This is a comment, and won't appear in the output.\r\n-->\r\n\r\n... | 634d0c03d77cebb3ce162688509ddc9b9f695098 | {
"head_commit": "584d19e8e335616202c248a6a99d4ffffa795c63",
"head_commit_message": "BUG: remove repeated insertion of the same node to the heap in dijkstra",
"patch_to_review": "diff --git a/scipy/sparse/csgraph/_shortest_path.pyx b/scipy/sparse/csgraph/_shortest_path.pyx\nindex 278d4b96ce59..0ca34303b0d6 100644... | [
{
"diff_hunk": "@@ -630,6 +630,8 @@ cdef _dijkstra_setup_heap_multi(FibonacciHeap *heap,\n heap.min_node = NULL\n for i in range(Nind):\n j_source = source_indices[i]\n+ if nodes[j_source].state == SCANNED:",
"line": null,
"original_line": 633,
"original_start_line": null,
... | 035006fe01b59d6308301dbd81d03968d917c0df | diff --git a/scipy/sparse/csgraph/_shortest_path.pyx b/scipy/sparse/csgraph/_shortest_path.pyx
index 278d4b96ce59..2c752f485d99 100644
--- a/scipy/sparse/csgraph/_shortest_path.pyx
+++ b/scipy/sparse/csgraph/_shortest_path.pyx
@@ -630,10 +630,12 @@ cdef _dijkstra_setup_heap_multi(FibonacciHeap *heap,
heap.min_node... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
scipy__scipy-11202@13c9042 | scipy/scipy | Python | 11,202 | BUG: fix edge counting in shortest_path | <!--
Thanks for contributing a pull request! Please ensure that
your PR satisfies the checklist before submitting:
http://scipy.github.io/devdocs/dev/contributor/development_workflow.html#checklist-before-submitting-a-pr
Also, please name and describe your PR as you would write a
commit message:
https://docs.s... | 2019-12-11T08:23:44Z | RuntimeWarning on csgraph.shortest_path when edge lengths are NaN
The documentation for scipy.sparse.csgraph says that NaN entries will be treated as non-edges, the same as 0 or inf. But when using csgraph.shortest_path on a graph where some paths are impossible because of NaN edges, irrelevant warning messages are pri... | thanks @creidieki. Those warnings are harmless but very annoying. They should be easy to avoid. | [
{
"body": "The documentation for scipy.sparse.csgraph says that NaN entries will be treated as non-edges, the same as 0 or inf. But when using csgraph.shortest_path on a graph where some paths are impossible because of NaN edges, irrelevant warning messages are printed. These warning messages don't happen in th... | 0a7b39a3973bf0ed95a497764445ccbaed7e990b | {
"head_commit": "13c90429bec2eb31f113cbf09e1857f20a9b0ef3",
"head_commit_message": "BUG: add counting of negative edges",
"patch_to_review": "diff --git a/scipy/sparse/csgraph/_shortest_path.pyx b/scipy/sparse/csgraph/_shortest_path.pyx\nindex 2c752f485d99..9f1a0d595756 100644\n--- a/scipy/sparse/csgraph/_shorte... | [
{
"diff_hunk": "@@ -166,12 +166,17 @@ def shortest_path(csgraph, method='auto',\n issparse = isspmatrix(csgraph)\n if issparse:\n Nk = csgraph.nnz\n+ edges = csgraph.data",
"line": null,
"original_line": 169,
"original_start_line": null,
"path": "scipy/spar... | 530bc8d11534e96e41952449ac0ec8525e4e4841 | diff --git a/scipy/sparse/csgraph/_shortest_path.pyx b/scipy/sparse/csgraph/_shortest_path.pyx
index 2c752f485d99..91d39450c97f 100644
--- a/scipy/sparse/csgraph/_shortest_path.pyx
+++ b/scipy/sparse/csgraph/_shortest_path.pyx
@@ -166,12 +166,20 @@ def shortest_path(csgraph, method='auto',
issparse = isspmatri... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
scipy__scipy-10988@42e7c51 | scipy/scipy | Python | 10,988 | BUG: signal: fixed issue #10360 | #### Reference issue
Fixes #10360
#### What does this implement/fix?
This fixes few bugs in firwin2 function:
1. Ensures that freq array is not modified and can be passed as tuple.
2. Adds additional requirements for freq and raises an exception when they are not met.
3. Multiplies eps by Nyquist frequency.
... | 2019-10-30T00:55:09Z | firwin2 inadvertently modifies input and may result in undefined behavior for nyq>1
<!--
Thank you for taking the time to report a SciPy issue.
Please describe the issue in detail, and for bug reports
fill in the fields below. You can delete the sections that
don't apply to your issue. You can view the final outp... | This does indeed look like a bug. I would multiply `eps` by `nyq` as in 2B. And if you can add two tests that fail in `master`:
1. `tuple` input works
2. `ndarray` input is not modified by the function
and pass on your PR, that would be great!
Whoops, my bugs. A pull request would be great.
An alternative to... | [
{
"body": "<!-- \r\nThank you for taking the time to report a SciPy issue.\r\nPlease describe the issue in detail, and for bug reports\r\nfill in the fields below. You can delete the sections that \r\ndon't apply to your issue. You can view the final output\r\nby clicking the preview button above.\r\n-->\r\n\r\... | 388192d8fb735515286f2174aa5b61f5d202bcbd | {
"head_commit": "42e7c517dcc67bc87e39b50f6cbe042b0acf5b22",
"head_commit_message": "DOC: add new requirements for input",
"patch_to_review": "diff --git a/scipy/signal/fir_filter_design.py b/scipy/signal/fir_filter_design.py\nindex d84e4aedd091..99c69015b925 100644\n--- a/scipy/signal/fir_filter_design.py\n+++ b... | [
{
"diff_hunk": "@@ -632,13 +637,23 @@ def firwin2(numtaps, freq, gain, nfreqs=None, window='hamming', nyq=None,\n if nfreqs is None:\n nfreqs = 1 + 2 ** int(ceil(log(numtaps, 2)))\n \n+ d = np.diff(freq)\n+ if (d == 0).any():\n+ freq = np.array(freq, copy=True)\n+\n # Tweak any repe... | 14ba5f5039b04629d22ecb9ac2be2be5da610ca4 | diff --git a/scipy/signal/fir_filter_design.py b/scipy/signal/fir_filter_design.py
index d84e4aedd091..8fe6c8ab8d91 100644
--- a/scipy/signal/fir_filter_design.py
+++ b/scipy/signal/fir_filter_design.py
@@ -505,7 +505,8 @@ def firwin2(numtaps, freq, gain, nfreqs=None, window='hamming', nyq=None,
Nyquist. The ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
scipy__scipy-13572@58970f3 | scipy/scipy | Python | 13,572 | ENH: n-D and nan_policy support for scipy.stats.percentileofscore | ENH: Implement nd support for percentileofscore
The enhancement is inspired by https://stackoverflow.com/a/12414469,
which (as necessary before this) uses pure python loops, which is slow.
Note that BrenBarn's top-ranked answer on that question uses `rankdata`,
which has been added to the 'see also' section. Th... | 2021-02-16T13:11:30Z | nan and stats.percentileofscore
In function `stats.percentileofscore`, `nan` is (effectively) treated as +infinity.
E.g.
```
scipy.stats.percentileofscore ([3, 1, numpy.nan, numpy.nan, 2], 5)
```
returns `60.00` (as it the percent of values below 5).
However, other numerical functions (e.g. `scipy.mean`) return `nan... | Functions that are not specifically designed for handling nans (*), don't check whether there are nans.
The behavior then is just a consequence of the implementation. In this case, the numpy `sort` function (which is used by `percentileofscore`, moves nans to the end. In (numpy.)`mean`, all numbers including nans are s... | [
{
"body": "In function `stats.percentileofscore`, `nan` is (effectively) treated as +infinity.\nE.g.\n\n```\nscipy.stats.percentileofscore ([3, 1, numpy.nan, numpy.nan, 2], 5)\n```\n\nreturns `60.00` (as it the percent of values below 5).\n\nHowever, other numerical functions (e.g. `scipy.mean`) return `nan` fo... | 1ab82fffd30f3bf936c1118e55617a978f9b7e90 | {
"head_commit": "58970f3d7c966f79024e3fb5dcf49c9d34c51d33",
"head_commit_message": "Add a kwarg to switch to safer & heavier nan-check\n\nThis allows me to remove my near-duplicate function\ninside percentileofscore().",
"patch_to_review": "diff --git a/scipy/stats/stats.py b/scipy/stats/stats.py\nindex 8df8ffa3... | [
{
"diff_hunk": "@@ -2829,6 +2829,32 @@ def test_percentileofscore():\n \n assert_raises(ValueError, pcos, [1, 2, 3, 3, 4], 3, kind='unrecognized')\n \n+ # score *arrays*\n+ a = 1 + np.arange(10)\n+ assert_equal(pcos(a, [4, 5]), [40.0, 50.0])",
"line": null,
"original_line": 2834,
"origi... | ef933594245aa2f0cab33b4d1844465e673469c6 | diff --git a/scipy/stats/_stats_py.py b/scipy/stats/_stats_py.py
index db49bdcadee1..6664abd45ad4 100644
--- a/scipy/stats/_stats_py.py
+++ b/scipy/stats/_stats_py.py
@@ -34,6 +34,7 @@
import numpy as np
from numpy import array, asarray, ma
from numpy.lib import NumpyVersion
+from numpy.testing import suppress_warni... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
scipy__scipy-10719@0a236cc | scipy/scipy | Python | 10,719 | Enable setting minres initial vector | #### Reference issue
Closes https://github.com/scipy/scipy/issues/6843
#### What does this implement/fix?
Makes sure `scipy.sparse.linalg.isolve.minres` uses parameter `x0` correctly.
#### Additional information
Combines https://github.com/scipy/scipy/pull/6887 and https://github.com/scipy/scipy/pull/7080
T... | 2019-08-24T13:33:34Z | minres always uses zero vector as initial vector and user doesn't know about it
What I mean, is _scipy/sparse/linalg/isolve/minres_, which is in python just `scipy.sparse.linalg.minres`.
In 46 line:
` A,M,x,b,postprocess = make_system(A,M,x0,b,xtype)`
It is usual preprocessing, which just check is `x0` equals... | Maybe better to do it like this:
```
def minres(A, b, shift=0.0, tol=1e-5, maxiter=None, xtype=None,
M=None, callback=None, show=False, check=False):
A,M,x,b,postprocess = make_system(A,M,None,b,xtype)
```
Is there a reason why you want to eliminate `x0` instead of making it work as advertised... | [
{
"body": "What I mean, is _scipy/sparse/linalg/isolve/minres_, which is in python just `scipy.sparse.linalg.minres`.\r\n\r\nIn 46 line:\r\n` A,M,x,b,postprocess = make_system(A,M,x0,b,xtype)`\r\n\r\nIt is usual preprocessing, which just check is `x0` equals to `None`. But in 88 line we have:\r\n` x = zer... | 473dd08e74e02e67b96a38014563afceb9f1f4fd | {
"head_commit": "0a236cc0d34e79ea2945827de5a65be65c349efb",
"head_commit_message": "activated test_gh_6843, added new test for correct x0",
"patch_to_review": "diff --git a/scipy/sparse/linalg/isolve/minres.py b/scipy/sparse/linalg/isolve/minres.py\nindex 22f6808c9a46..846a3102fb74 100644\n--- a/scipy/sparse/lin... | [
{
"diff_hunk": "@@ -110,23 +110,19 @@ def minres(A, b, x0=None, shift=0.0, tol=1e-5, maxiter=None,\n \n eps = finfo(xtype).eps\n \n- x = zeros(n, dtype=xtype)\n-\n # Set up y and v for the first Lanczos vector v1.\n # y = beta1 P' v1, where P = C**(-1).\n # v is really P' v1.\n \n- y =... | 5c584f68f8da432141aed250a0fc9780e5817d2e | diff --git a/scipy/sparse/linalg/isolve/minres.py b/scipy/sparse/linalg/isolve/minres.py
index 22f6808c9a46..218eb6611a80 100644
--- a/scipy/sparse/linalg/isolve/minres.py
+++ b/scipy/sparse/linalg/isolve/minres.py
@@ -82,7 +82,7 @@ def minres(A, b, x0=None, shift=0.0, tol=1e-5, maxiter=None,
maxiter = 5 * n
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
scipy__scipy-10480@dfc225c | scipy/scipy | Python | 10,480 | Add RuntimeError in _distn_infrastructure.py in fit() method | This PR is _one_ proposal to fix #10300 from the discussion w/ @chrisb83 @WarrenWeckesser and @kmundnic (who opened the issue). From the discussion on the issue thread it is not clear to me if we want to implement a `nan_policy` for fit or simply throw an error. Given the inconsistency in the current behavior any fi... | 2019-07-18T03:06:25Z | scipy.stats.rv_continuous.fit throws empty RuntimeError when input has NaNs
<!--
Thank you for taking the time to report a SciPy issue.
Please describe the issue in detail, and for bug reports
fill in the fields below. You can delete the sections that
don't apply to your issue. You can view the final output
by c... | Thanks for reporting this bug. Looks like the generic `fit` method of `rv_continuous` ends up at this runtime error if the distribution has support on the real line (a=-inf and b=inf).
Another issue:
```
x = np.array([1e6, 1e6, 1e6, np.nan])
stats.exponnorm.fit_loc_scale(x, 1) # (0, 1), does not make sense
```
... | [
{
"body": "<!-- \r\nThank you for taking the time to report a SciPy issue.\r\nPlease describe the issue in detail, and for bug reports\r\nfill in the fields below. You can delete the sections that \r\ndon't apply to your issue. You can view the final output\r\nby clicking the preview button above.\r\n-->\r\n\r\... | e90bafdfe1fa7266f3e3befc7f82368ce38bdf9f | {
"head_commit": "dfc225cc78e8478d8587958b6ffb5932c5dbc4e5",
"head_commit_message": "MAINT: remove unnecessary context manager",
"patch_to_review": "diff --git a/scipy/stats/_continuous_distns.py b/scipy/stats/_continuous_distns.py\nindex 604fe42c6f3e..e047e3609d57 100644\n--- a/scipy/stats/_continuous_distns.py\... | [
{
"diff_hunk": "@@ -2020,6 +2066,20 @@ class TestFitMethod(object):\n def setup_method(self):\n np.random.seed(1234)\n \n+ # skip these b/c depracated, or only loc and scale arguments",
"line": null,
"original_line": 2069,
"original_start_line": null,
"path": "scipy/stats/tests/te... | c0b2bede266ffe69d9888faf5b9c7d1d1d6562a5 | diff --git a/scipy/stats/_continuous_distns.py b/scipy/stats/_continuous_distns.py
index 604fe42c6f3e..e047e3609d57 100644
--- a/scipy/stats/_continuous_distns.py
+++ b/scipy/stats/_continuous_distns.py
@@ -284,6 +284,9 @@ def fit(self, data, **kwds):
data = np.asarray(data)
+ if not np.isfinite(dat... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
scipy__scipy-10423@df1fef2 | scipy/scipy | Python | 10,423 | FIX: Use pybind11::isinstace to check array dtypes | Fixes gh-10422 | 2019-07-08T16:10:44Z | BUG: scipy.fft does not support multiprocessing
`scipy.fft` interacts badly with `joblib`, specifically when using the "processes" method. @peterbell10 tested and reports that it also fails for `multiprocessing.Pool` directly. But here was my MWE with joblib:
```Python
>>> import numpy as np
>>> from joblib import P... | Does rfft use openmp?
It's unrelated. The root cause is comparing dtypes using `is` which breaks after `fork`. I have a fix locally, PR soon. | [
{
"body": "`scipy.fft` interacts badly with `joblib`, specifically when using the \"processes\" method. @peterbell10 tested and reports that it also fails for `multiprocessing.Pool` directly. But here was my MWE with joblib:\r\n```Python\r\n>>> import numpy as np\r\n>>> from joblib import Parallel, delayed\r\n>... | 18219f5a1971be9a3fd6d590aeb496a419e8cd0e | {
"head_commit": "df1fef279dac5916947ad3fe51e2c923586648b4",
"head_commit_message": "FIX: Remove unnecessary dtype call",
"patch_to_review": "diff --git a/scipy/fft/_pocketfft/pypocketfft.cxx b/scipy/fft/_pocketfft/pypocketfft.cxx\nindex cf2a4246cdb4..ab7172fbca45 100644\n--- a/scipy/fft/_pocketfft/pypocketfft.cx... | [
{
"diff_hunk": "@@ -13,4 +13,6 @@ SciPy currently vendors [pypocketfft][repo] at:\n \n New interface\n \n+With the changes in `scipychanges.patch`",
"line": null,
"original_line": 16,
"original_start_line": null,
"path": "scipy/fft/_pocketfft/version.md",
"start_line": null,
"tex... | ca0eead216dd372d14af6c4f23aaf31232a3648e | diff --git a/scipy/fft/_pocketfft/pypocketfft.cxx b/scipy/fft/_pocketfft/pypocketfft.cxx
index cf2a4246cdb4..efe85f0bbf55 100644
--- a/scipy/fft/_pocketfft/pypocketfft.cxx
+++ b/scipy/fft/_pocketfft/pypocketfft.cxx
@@ -28,12 +28,12 @@ namespace py = pybind11;
using ldbl_t = typename std::conditional<
sizeof(long do... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
scipy__scipy-10353@5900bc7 | scipy/scipy | Python | 10,353 | Bug: interpolate.NearestNDInterpolator (issue #10352) | fix #10352
The problem is solved by casting the searched array. | 2019-06-25T07:14:30Z | BUG: interpolate.NearestNDInterpolator with pandas
interpolate.NearestNDInterpolator does not work as expected when used with selected pandas dataframe.
This is due to the index being maintained when making selections in pandas.
### Reproducing code example:
```
import numpy as np
import pandas as pd
from scip... | [
{
"body": "interpolate.NearestNDInterpolator does not work as expected when used with selected pandas dataframe.\r\nThis is due to the index being maintained when making selections in pandas.\r\n\r\n### Reproducing code example:\r\n```\r\nimport numpy as np\r\nimport pandas as pd\r\nfrom scipy import interpola... | 7d1481ef99846053039d73805ac60841f84dd902 | {
"head_commit": "5900bc7bb14747c68aadddb4488e41adc6f2669e",
"head_commit_message": "fix #10352",
"patch_to_review": "diff --git a/scipy/interpolate/ndgriddata.py b/scipy/interpolate/ndgriddata.py\nindex 023c439f8451..0aa4aedfb801 100644\n--- a/scipy/interpolate/ndgriddata.py\n+++ b/scipy/interpolate/ndgriddata.p... | [
{
"diff_hunk": "@@ -62,7 +62,7 @@ def __init__(self, x, y, rescale=False, tree_options=None):\n if tree_options is None:\n tree_options = dict()\n self.tree = cKDTree(self.points, **tree_options)\n- self.values = y\n+ self.values = np.array(y)",
"line": null,
"o... | 5ee5df82a547522d7c201571bd986a9514f260f0 | diff --git a/scipy/interpolate/ndgriddata.py b/scipy/interpolate/ndgriddata.py
index 023c439f8451..e7f9fddd7e44 100644
--- a/scipy/interpolate/ndgriddata.py
+++ b/scipy/interpolate/ndgriddata.py
@@ -62,7 +62,7 @@ def __init__(self, x, y, rescale=False, tree_options=None):
if tree_options is None:
... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} | |
scipy__scipy-10410@3a58e13 | scipy/scipy | Python | 10,410 | [ENH] ncx2 dispatch to chi2 when nc=0 | - close #5441
- one test added | 2019-07-07T14:59:28Z | scipy.stats.ncx2 fails for nc=0
For `nc = 0` it should reduce to the chi-squared distribution, but `scipy.stats.ncx2.rvs(1, 0)` gives:
``` python
C:\Anaconda\lib\site-packages\scipy\stats\_distn_infrastructure.pyc in rvs(self, *args, **kwds)
882 cond = logical_and(self._argcheck(*args), (scale >= 0))
8... | This specific error message comes from the fact that `ncx2` inherits a generic `_argcheck` which checks that all shape arguments are strictly positive. The fix is simple, just define `ncx2_gen._argcheck` to be `(df > 0) & (nc >=0)`.
Once this is done, everything will keep failing because neither `np.random.noncentra... | [
{
"body": "For `nc = 0` it should reduce to the chi-squared distribution, but `scipy.stats.ncx2.rvs(1, 0)` gives:\n\n``` python\nC:\\Anaconda\\lib\\site-packages\\scipy\\stats\\_distn_infrastructure.pyc in rvs(self, *args, **kwds)\n 882 cond = logical_and(self._argcheck(*args), (scale >= 0))\n 883... | 975e3e421ca5758983ff734dcfb61c4f6e26cb61 | {
"head_commit": "3a58e137dfcc1dda4385150f2492abebc2a64249",
"head_commit_message": "Add tests for pdf, logpdf, rvs",
"patch_to_review": "diff --git a/scipy/stats/_continuous_distns.py b/scipy/stats/_continuous_distns.py\nindex 53ce63712ad8..d7af333d8a52 100644\n--- a/scipy/stats/_continuous_distns.py\n+++ b/scip... | [
{
"diff_hunk": "@@ -3258,6 +3258,26 @@ def test_ncx2_tails_pdf():\n assert_(np.isneginf(logval).all())\n \n \n+@pytest.mark.parametrize('method, expected', [\n+ ('cdf', np.array([1.72115630e-04, 2.74102033e-05])),\n+ ('pdf', np.array([0.00078975, 0.00013013])),\n+ ('logpdf', np.array([-7.14378973, ... | 2b4a118125b4340f6822ebab89e8a41e86f68b64 | diff --git a/scipy/stats/_continuous_distns.py b/scipy/stats/_continuous_distns.py
index 53ce63712ad8..d7af333d8a52 100644
--- a/scipy/stats/_continuous_distns.py
+++ b/scipy/stats/_continuous_distns.py
@@ -5204,19 +5204,25 @@ class ncx2_gen(rv_continuous):
%(example)s
"""
+ def _argcheck(self, df, nc):
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
scipy__scipy-10844@4cc54dd | scipy/scipy | Python | 10,844 | ENH: add stats.qmc module with quasi Monte Carlo functionality | Add `scipy.stats.qmc`.
#### Reference issue
Closes https://github.com/scipy/scipy/issues/9695
#### What does this implement/fix?
Provide a set of functions to create and assess quasi-Monte Carlo Design of Experiments.
It provides a generic class `scipy.stats.qmc.QMCEngine` which defines a QMC engine/sampler. A... | 2019-09-19T11:45:52Z | [Question] Desire for qMC library in scipy?
I have a fast Cython implementation of a Sobol low-discrepancy quasi-random number generator using Owen scrambling. On top of that I have some transformations (inverse transform, Box-Muller) that make it easy to draw quasi-MC samples from, say, a multivariate normal distribu... | Yes!
Plus there is already Sobol' QMC in `from scipy.optimize._shgo_lib import sobol_seq`. There is some current work on statsmodels to implement some sampling methods: https://github.com/statsmodels/statsmodels/pull/4104 and WIP: https://github.com/statsmodels/statsmodels/pull/4113
There definitely is enough interest,... | [
{
"body": "I have a fast Cython implementation of a Sobol low-discrepancy quasi-random number generator using Owen scrambling. On top of that I have some transformations (inverse transform, Box-Muller) that make it easy to draw quasi-MC samples from, say, a multivariate normal distribution. This code has been ... | c0aed3bceb49c1fc6ff286c05b1f9ba6924d37df | {
"head_commit": "4cc54dd944417710ef4302977e7379dd145deeb1",
"head_commit_message": "Refactor test setup and some raises",
"patch_to_review": "diff --git a/.gitignore b/.gitignore\nindex 03242cc661dc..45d377db1ce8 100644\n--- a/.gitignore\n+++ b/.gitignore\n@@ -270,6 +270,7 @@ scipy/stats/mvnmodule.c\n scipy/stat... | [
{
"diff_hunk": "@@ -0,0 +1,212 @@\n+from collections import Counter\n+\n+import pytest\n+import numpy as np\n+from numpy.testing import (assert_, assert_equal, assert_array_almost_equal,\n+ assert_array_equal)\n+\n+from scipy.stats.qmc import Sobol\n+import scipy.stats.qmc as qmc\n+\n+... | 4bc71c7c263d53be185ba7c616bc0f6a481ca1ef | diff --git a/.gitignore b/.gitignore
index 03242cc661dc..45d377db1ce8 100644
--- a/.gitignore
+++ b/.gitignore
@@ -270,6 +270,7 @@ scipy/stats/mvnmodule.c
scipy/stats/statlibmodule.c
scipy/stats/vonmises_cython.c
scipy/stats/_stats.c
+scipy/stats/_sobol.c
scipy/version.py
scipy/special/_exprel.c
scipy/optimize/_g... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
scipy__scipy-10345@1ceb8cc | scipy/scipy | Python | 10,345 | ENH: Tiled QR wrappers for scipy.linalg.lapack | As per https://github.com/scipy/scipy/issues/10323 I have begun working on the wrappers. I believe the wrappers and documentation are complete.
I still need to write some tests (but they do appear to function according to my brief, informal testing).
Closes #10323 | 2019-06-24T13:19:33Z | Adding more low-level LAPACK wrappers
I would like to be able to make use of the following LAPACK routines from `scipy.linalg.lapack` (which currently have Cython wrappers provided in `scipy.linalg.cython_lapack`): `geqrt`, `gemqrt`, `tpqrt` and `tpmqrt` for tiled QR factorisation. I suggest the following signatures (w... | @AidanGG Thanks for taking the time.
These routines came with Lapack 3.4 which we only recently assumed as the minimum version to support hence their absence.
For getting acquainted with the wrappers gou can check, say, #8965 on what is involved and which files are needed.
Please let me know if you need any m... | [
{
"body": "I would like to be able to make use of the following LAPACK routines from `scipy.linalg.lapack` (which currently have Cython wrappers provided in `scipy.linalg.cython_lapack`): `geqrt`, `gemqrt`, `tpqrt` and `tpmqrt` for tiled QR factorisation. I suggest the following signatures (with work and info a... | 840eb2630c1b3661a05f9d3504fe2c5bdfc70c4f | {
"head_commit": "1ceb8cc5f3335a0e2fa4302d45d7fd0619491e37",
"head_commit_message": "Add missing f2py dependency",
"patch_to_review": "diff --git a/THANKS.txt b/THANKS.txt\nindex e36e51797783..c499992ae1b1 100644\n--- a/THANKS.txt\n+++ b/THANKS.txt\n@@ -209,6 +209,7 @@ William Conner DiPaolo for improvements to t... | [
{
"diff_hunk": "@@ -401,6 +401,116 @@ subroutine <prefix2c>unmqr(side,trans,m,n,k,a,lda,tau,c,ldc,work,lwork,info)\n \n end subroutine <prefix2c>unmqr\n \n+subroutine <prefix>geqrt(m,n,nb,a,lda,t,ldt,work,info)\n+ ! a,t,info = geqrt(nb,a,[overwrite_a=0])\n+ !\n+ ! Computes a QR factorization with block... | 95f5fa8d7801d8db551cdf9ed4381776de4a0a85 | diff --git a/THANKS.txt b/THANKS.txt
index e36e51797783..c499992ae1b1 100644
--- a/THANKS.txt
+++ b/THANKS.txt
@@ -209,6 +209,7 @@ William Conner DiPaolo for improvements to the Clarkson-Woodruff transform.
Forrest Collman for adding multi-target dijsktra to scipy.sparse.csgraph
Carlos Ramos Carreño for adding suppor... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
scipy__scipy-12143@6bfe3f3 | scipy/scipy | Python | 12,143 | BUG: Correctly use `axis` in `scipy.stats.tmean` | Closes #12106
Fixes `scipy.stats.tmean` so that it correctly uses the `axis` keyword.
(_Please check that this addresses gh-9770, too_ - @mdhaber) | 2020-05-17T23:11:51Z | `axis` option for `stats.tmean` do not appear to be working as expected
<!--
Thank you for taking the time to file a bug report.
Please fill in the fields below, deleting the sections that
don't apply to your issue. You can view the final output
by clicking the preview button above.
Note: This is a comment, and... | @jtstanley, thanks for the report. That's a bug. `tmean` is ignoring the `axis` argument.
Hello!
There seem to be two issues with `tmean`.
1. First, as @jtstanley pointed out, it ignores `axis` if no `limits` are provided. The culprit here is this line, where `axis` has been forced to `None`:
```
if limits is... | [
{
"body": "<!-- \r\nThank you for taking the time to file a bug report. \r\nPlease fill in the fields below, deleting the sections that \r\ndon't apply to your issue. You can view the final output\r\nby clicking the preview button above.\r\nNote: This is a comment, and won't appear in the output.\r\n-->\r\n\r\n... | 36ff3c7229441d0291c1abaabaad44dc17a3e4ae | {
"head_commit": "6bfe3f3e6c2ca427415d9cbf9b9607ca1d14c1b4",
"head_commit_message": "MAINT: no need to cast in asarray",
"patch_to_review": "diff --git a/THANKS.txt b/THANKS.txt\nindex 49bbd6d4db53..a7fb9cecafb8 100644\n--- a/THANKS.txt\n+++ b/THANKS.txt\n@@ -236,7 +236,9 @@ Sam Wallan for scipy.linalg.lapack enh... | [
{
"diff_hunk": "@@ -236,7 +236,9 @@ Sam Wallan for scipy.linalg.lapack enhancements\n Richard Weiss for a bug fix in scipy.optimize._differentialevolution.py.\n Luigi F. Cruz for adding time/frequency domain option to scipy.signal.resample.\n Wesley Alves for improvements to scipy.stats.jarque_bera and scipy.st... | e37abc8c9b78e99295663d7bd96d31efa7dbf865 | diff --git a/scipy/stats/_stats_py.py b/scipy/stats/_stats_py.py
index 6e79b50ecf42..723dc0c80e02 100644
--- a/scipy/stats/_stats_py.py
+++ b/scipy/stats/_stats_py.py
@@ -540,7 +540,7 @@ def tmean(a, limits=None, inclusive=(True, True), axis=None):
Returns
-------
- tmean : float
+ tmean : ndarray
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
scipy__scipy-10135@1a9baa9 | scipy/scipy | Python | 10,135 | BUG: fix linprog revised simplex docstring problem failure | Fixes #10124
`linprog` with `method='revised simplex'` failed the `linprog` docstring problem. The cause was that option `'disp'=True` executes `_postsolve`, which changes the solution vector. Simple fix was to copy the solution vector before passing it into `_postsolve`.
`linprog` with `method='interior-point'` wa... | 2019-05-04T19:41:11Z | linprog(method='revised simplex') doctest bug
`linprog` `method='revised simplex'` (in the 1.3 branch) doesn't solve the example problem in the docstring. The example was supposed to be a doctest, but all the outputs were marked "# may vary", so the problem wasn't caught.
I think a small bug in the phase 1 problem ... | We are at RC phase to catch these post branch issues. If needed, which seems so, Tyler would backport it
If you open a PR also mark it backport candidate and remove it here maybe?
Will try to do this weekend. Still scheduled to release 5/20? | [
{
"body": "`linprog` `method='revised simplex'` (in the 1.3 branch) doesn't solve the example problem in the docstring. The example was supposed to be a doctest, but all the outputs were marked \"# may vary\", so the problem wasn't caught. \r\n\r\nI think a small bug in the phase 1 problem formulation was intro... | 368e211cf3a37351f8651cea4dd8ed3c884f9f44 | {
"head_commit": "1a9baa96a7416c34d691524ace8eaba7f77ec94a",
"head_commit_message": "BUG: optimize: fix linprog docstring failure for interior-point",
"patch_to_review": "diff --git a/scipy/optimize/_linprog_ip.py b/scipy/optimize/_linprog_ip.py\nindex 781e61ae93d7..a8b4ec6f8d7b 100644\n--- a/scipy/optimize/_linp... | [
{
"diff_hunk": "@@ -794,7 +794,8 @@ def eta(g=gamma):\n go = rho_p > tol or rho_d > tol or rho_A > tol\n \n if disp:\n- _display_iter(rho_p, rho_d, rho_g, alpha, float(rho_mu), obj)\n+ _display_iter(rho_p, rho_d, rho_g, float(alpha),",
"line": null,
"original_line":... | 33bb8deb6db59ddf6375069f3698294713733fe5 | diff --git a/scipy/optimize/_linprog_ip.py b/scipy/optimize/_linprog_ip.py
index 781e61ae93d7..217a8a33d615 100644
--- a/scipy/optimize/_linprog_ip.py
+++ b/scipy/optimize/_linprog_ip.py
@@ -22,6 +22,7 @@
import numpy as np
import scipy as sp
import scipy.sparse as sps
+import numbers
from warnings import warn
fro... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
scipy__scipy-9898@c37f6bb | scipy/scipy | Python | 9,898 | BUG: Set success attribute in OptimizeResult. See #9801 | closes gh-9801 | 2019-03-04T14:36:37Z | dual_annealing does not set the success attribute in OptimizeResult
```
from scipy.optimize import dual_annealing, rosen
res = dual_annealing(rosen, [(-2, 2), (-2, 2)])
print(res.success)
```
Gives:
```
--------------------------------------------------------------------------
KeyError ... | [
{
"body": "```\r\nfrom scipy.optimize import dual_annealing, rosen\r\nres = dual_annealing(rosen, [(-2, 2), (-2, 2)])\r\nprint(res.success)\r\n```\r\n\r\nGives:\r\n\r\n```\r\n--------------------------------------------------------------------------\r\nKeyError Traceback (most r... | f07bfbaab18fcbeaff54e4e7e877f29cd6342090 | {
"head_commit": "c37f6bb2530574be0eb7d53d15849c2ce1f9d71a",
"head_commit_message": "BUG: Set success attribute in OptimizeResult. See #9801",
"patch_to_review": "diff --git a/scipy/optimize/_dual_annealing.py b/scipy/optimize/_dual_annealing.py\nindex 1b6ccf2ddcab..aa8948ad4e75 100644\n--- a/scipy/optimize/_dual... | [
{
"diff_hunk": "@@ -637,11 +637,16 @@ def dual_annealing(func, bounds, args=(), maxiter=1000,\n # Strategy chain instance\n strategy_chain = StrategyChain(accept, visit_dist, func_wrapper,\n minimizer_wrapper, rand_state, energy_state)\n- # Run the search loop\n nee... | e9678ecc538aac9ecccdb927ce7647fef2c422b0 | diff --git a/scipy/optimize/_dual_annealing.py b/scipy/optimize/_dual_annealing.py
index 1b6ccf2ddcab..d8b6043126ad 100644
--- a/scipy/optimize/_dual_annealing.py
+++ b/scipy/optimize/_dual_annealing.py
@@ -637,11 +637,16 @@ def dual_annealing(func, bounds, args=(), maxiter=1000,
# Strategy chain instance
str... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} | |
scipy__scipy-9838@bf59f62 | scipy/scipy | Python | 9,838 | ENH: Use faster solvers for firls | `Q` is symmetric, so we should use that to speed up solving. Also, we can try using `linalg.solve` first, and fall back to a `pinvh` if necessary.
I'm not 100% sure that it's okay to use `solve` in cases where it warns about rank deficiency. It seems to produce okay results in my tests, but if someone thinks it's be... | 2019-02-18T15:43:03Z | scipy.signal.firls seems to be inefficient versus MATLAB firls
Hi everyone,
I've been porting some code over from MATLAB to Python, and I have run into an issue with scipy.signal.firls. It doesn't seem to be as fast/efficient as the MATLAB equivalent. I don't know if I'm using it wrong, but I wanted to report this and... | The MATLAB documentation for their firls implementation states:
> b = firls(n,f,a) returns row vector b containing the n+1 coefficients of the order n FIR filter whose frequency-amplitude characteristics approximately match those given by vectors f and a. The output filter coefficients, or “taps,” in b obey the symm... | [
{
"body": "Hi everyone,\r\nI've been porting some code over from MATLAB to Python, and I have run into an issue with scipy.signal.firls. It doesn't seem to be as fast/efficient as the MATLAB equivalent. I don't know if I'm using it wrong, but I wanted to report this and maybe get some guidance if I am indeed us... | 8532ca64d5a76e2a014ea1787cd72b79087a5696 | {
"head_commit": "bf59f62a7e7ec0a38c9b56ec5312324917cb303d",
"head_commit_message": "ENH: Use lstsq",
"patch_to_review": "diff --git a/scipy/signal/fir_filter_design.py b/scipy/signal/fir_filter_design.py\nindex 23c7e0b37d48..4e8fb8d74199 100644\n--- a/scipy/signal/fir_filter_design.py\n+++ b/scipy/signal/fir_fil... | [
{
"diff_hunk": "@@ -1032,8 +1035,20 @@ def firls(numtaps, bands, desired, weight=None, nyq=None, fs=None):\n b[1:] += m * np.cos(n[1:] * np.pi * bands) / (np.pi * n[1:]) ** 2\n b = np.dot(np.diff(b, axis=2)[:, :, 0], weight)\n \n- # Now we can solve the equation (use pinv because Q can be rank defici... | 5fb7456ab5756a5dc18ab468a8178c812a713cfe | diff --git a/benchmarks/benchmarks/signal.py b/benchmarks/benchmarks/signal.py
index 46831cd8cbd8..3790c5feeb49 100644
--- a/benchmarks/benchmarks/signal.py
+++ b/benchmarks/benchmarks/signal.py
@@ -210,3 +210,14 @@ def setup(self, up, down, axis):
def time_upfirdn2d(self, up, down, axis):
for h, x in sel... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Performance Optimizations"
} |
scipy__scipy-10495@fee5b46 | scipy/scipy | Python | 10,495 | WIP: optimize: add autoscaling to linprog | #### Reference issue
Closes gh-10466
Partially addresses #9269
#### What does this implement/fix?
Adds an autoscaling routine to `linprog` to enable solution when the original problem is poorly scaled
#### Additional information
- Unfortunately this still doesn't allow interior point to solve problems with ... | 2019-07-20T05:10:17Z | _linprog_ip gives wrong answers
_linprog_ip gives wrong answers.
### Reproducing code example:
<!--
If you place your code between the triple backticks below,
it will be marked as a code block automatically
-->
```
import numpy as np
from scipy.optimize import linprog
from scipy.optimize._linprog_i... | I'll take a closer look later, but it is probably a scaling issue, as your values vary by several orders of magnitude. We plan to add an auto-scaling routine at some point.
In the meantime, consider manually scaling your problem (like expressing in different units to keep the magnitudes of all values similar), or up... | [
{
"body": "_linprog_ip gives wrong answers. \r\n\r\n### Reproducing code example:\r\n<!-- \r\nIf you place your code between the triple backticks below, \r\nit will be marked as a code block automatically \r\n-->\r\n\r\n\r\n```\r\nimport numpy as np\r\n\r\nfrom scipy.optimize import linprog\r\nfrom scipy.optimi... | e4ca3778340040150c5c11a2c30b3fc2345ea4f7 | {
"head_commit": "fee5b4630955f6f450b733d3270c8320d5b1f5a3",
"head_commit_message": "BUG: optimize: address failure of linprog test_bug_10124",
"patch_to_review": "diff --git a/scipy/optimize/_linprog.py b/scipy/optimize/_linprog.py\nindex f22a78ac06e2..ea046e9f61a3 100644\n--- a/scipy/optimize/_linprog.py\n+++ b... | [
{
"diff_hunk": "@@ -1086,6 +1086,79 @@ def vstack(blocks):\n return A, b, c, c0, x0\n \n \n+def _round_to_power_of_two(x):\n+ \"\"\"\n+ Round elements of the array to the nearest power of two.\n+ \"\"\"\n+ return 2**np.round(np.log2(x))\n+\n+def _autoscale(A, b, c, x0):\n+ \"\"\"\n+ Scales... | ceaa84155ad0bea124b74b0000fbd1feb54c2ee2 | diff --git a/scipy/optimize/_linprog.py b/scipy/optimize/_linprog.py
index 9f4efa1097ef..7ac744a75aad 100644
--- a/scipy/optimize/_linprog.py
+++ b/scipy/optimize/_linprog.py
@@ -25,7 +25,7 @@
from ._linprog_simplex import _linprog_simplex
from ._linprog_rs import _linprog_rs
from ._linprog_util import (
- _parse... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
scipy__scipy-9834@4b98b25 | scipy/scipy | Python | 9,834 | DOC: Change mielke distribution default parameters to ensure kurtosis exists. | The kurtosis calculation for mielke distribution (parameters `k` & `s`) does
not converge if `s` is too small. (See gh-9833) Change the default parameters for testing from `(10.4, 3.6)` to `(10.4, 4.6)`. (Any value of `s` bigger than `4` should be sufficient to ensure mathematical convergence. `4.6` is big enough th... | 2019-02-18T01:52:51Z | IntegrationWarning from mielke.stats() during build of html doc.
An IntegrationWarning occurs while building the docs.
### Reproducing code example:
```
$ pushed doc && make clean && make html
```
### Error message:
```
.../scipy/scipy/stats/_distn_infrastructure.py:1613: IntegrationWarning: The integral is... | [
{
"body": "An IntegrationWarning occurs while building the docs.\r\n\r\n### Reproducing code example:\r\n```\r\n$ pushed doc && make clean && make html\r\n```\r\n\r\n### Error message:\r\n```\r\n.../scipy/scipy/stats/_distn_infrastructure.py:1613: IntegrationWarning: The integral is probably divergent, or slow... | 6db252d0105ba6fe3b23dd10d7a0da17dac0ce53 | {
"head_commit": "4b98b25168486ed73ad648e54342789b7dc242da",
"head_commit_message": "DOC: Indent a line in the References section of mielke.",
"patch_to_review": "diff --git a/scipy/stats/_continuous_distns.py b/scipy/stats/_continuous_distns.py\nindex e30a2ff18078..866c8f927094 100644\n--- a/scipy/stats/_continu... | [
{
"diff_hunk": "@@ -4583,7 +4583,7 @@ def _entropy(self):\n \n \n class mielke_gen(rv_continuous):\n- r\"\"\"A Mielke's Beta-Kappa continuous random variable.\n+ r\"\"\"Mielke's Beta-Kappa continuous random variable[1]_.",
"line": null,
"original_line": 4586,
"original_start_line": null,
"... | ae4f4d516606125888761bced23f7e467fdd34af | diff --git a/scipy/stats/_continuous_distns.py b/scipy/stats/_continuous_distns.py
index e30a2ff18078..137695643e66 100644
--- a/scipy/stats/_continuous_distns.py
+++ b/scipy/stats/_continuous_distns.py
@@ -4583,7 +4583,7 @@ def _entropy(self):
class mielke_gen(rv_continuous):
- r"""A Mielke's Beta-Kappa contin... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "Bug Fixes"
} | |
scipy__scipy-9525@31cdb0f | scipy/scipy | Python | 9,525 | BUG: SuperLU 'NATURAL' order applies a column permutation | When using perm_c="NATURAL" in splu and spilu, the column ordering of a SuperLU
factorization is not preserved. This patch sets appropriate options to pass
into SuperLU so that the column ordering is preserved.
Row permutations for partial pivoting can still be performed.
Fix #7700, #8795 | 2018-11-23T05:13:22Z | SuperLU does not respect perm_c="NATURAL"
According to 2.5.1 of the SuperLU user's guide, the `ColPerm` option (set via `scipy.sparse.linalg.splu`'s `permc_spec` parameter) should accept the value:
`NATURAL`: use natural ordering (i.e., Pc = I).
According to this description, I would expect that the returned SuperLU... | I have been working with SuperLU (and sparse matrices in general) quite a bit lately and I have many suggestions, one of which would be to remove the restriction:
```python
M, N = A.shape
if (M != N):
raise ValueError("can only factor square matrices") # is this true?
```
as the first paragraph of the introd... | [
{
"body": "According to 2.5.1 of the SuperLU user's guide, the `ColPerm` option (set via `scipy.sparse.linalg.splu`'s `permc_spec` parameter) should accept the value:\r\n`NATURAL`: use natural ordering (i.e., Pc = I).\r\nAccording to this description, I would expect that the returned SuperLU object's `perm_c` a... | c0dc7fccc53d8a8569cde5d55673fca284bca191 | {
"head_commit": "31cdb0f2ec332129332b145cb8d00f46ddbe375f",
"head_commit_message": "TST: linalg: improve SuperLU permc_spec=NATURAL tests",
"patch_to_review": "diff --git a/scipy/sparse/linalg/dsolve/linsolve.py b/scipy/sparse/linalg/dsolve/linsolve.py\nindex f12ba71fc7b8..93f908c00b6f 100644\n--- a/scipy/sparse... | [
{
"diff_hunk": "@@ -407,6 +412,11 @@ def spilu(A, drop_tol=None, fill_factor=None, drop_rule=None, permc_spec=None,\n PanelSize=panel_size, Relax=relax)\n if options is not None:\n _options.update(options)\n+\n+ # Ensure no column permutations applied",
"line": null,
"... | d76efe6520d1e53279507b30747476b831a1d084 | diff --git a/scipy/sparse/linalg/dsolve/linsolve.py b/scipy/sparse/linalg/dsolve/linsolve.py
index f12ba71fc7b8..9ab9c2ca6342 100644
--- a/scipy/sparse/linalg/dsolve/linsolve.py
+++ b/scipy/sparse/linalg/dsolve/linsolve.py
@@ -321,6 +321,11 @@ def splu(A, permc_spec=None, diag_pivot_thresh=None,
Pa... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
scipy__scipy-9573@00be3a1 | scipy/scipy | Python | 9,573 | BUG fixes range of pk variable pre-check | closes #9564
I applied pre-check for pk range.
previously pk is only checked by summation value (`np.sum(pk) == 1.0`).
In this feature, pk is checked by not only summation value but also each parameter range(0<pk<1).
Please review this PR. | 2018-12-05T01:50:11Z | rv_sample accepts invalid input in scipy.stats
When passing values `(x_k, p_k)` to `stats.rv_discrete`, the only condition that is checked in `rv_sample` is whether `sum(p_k)` is one, but not whether the p_k are between zero and one
### Reproducing code example:
```
from scipy import stats
import numpy as np
c... | Should I scratch this one?
I will make a code and docs.
@akahard2dj please go for it. | [
{
"body": "When passing values `(x_k, p_k)` to `stats.rv_discrete`, the only condition that is checked in `rv_sample` is whether `sum(p_k)` is one, but not whether the p_k are between zero and one\r\n\r\n### Reproducing code example:\r\n\r\n```\r\nfrom scipy import stats\r\nimport numpy as np\r\ncustm = stats.r... | 55393009bbc1dfe07ecd50d45cbea9e95d83b603 | {
"head_commit": "00be3a1d98aff4c4afeead50487c069cdbdd4146",
"head_commit_message": "pk range check method changes",
"patch_to_review": "diff --git a/scipy/stats/_distn_infrastructure.py b/scipy/stats/_distn_infrastructure.py\nindex d1b8524c759d..fe3ecdebee32 100644\n--- a/scipy/stats/_distn_infrastructure.py\n++... | [
{
"diff_hunk": "@@ -2578,7 +2578,8 @@ class rv_discrete(rv_generic):\n The tolerance for the generic calculation of moments.\n values : tuple of two array_like, optional\n ``(xk, pk)`` where ``xk`` are integers with non-zero\n- probabilities ``pk`` with ``sum(pk) = 1``.\n+ pro... | 302857bdd63b2768aad40b0fbf0c1de54519f2eb | diff --git a/scipy/stats/_distn_infrastructure.py b/scipy/stats/_distn_infrastructure.py
index b6ca446c9b3c..6ebb0dd8cc3b 100644
--- a/scipy/stats/_distn_infrastructure.py
+++ b/scipy/stats/_distn_infrastructure.py
@@ -2569,9 +2569,9 @@ class rv_discrete(rv_generic):
moment_tol : float, optional
The toler... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
scipy__scipy-9488@9e81f03 | scipy/scipy | Python | 9,488 | TST Duplicate tests for geometric mean | closes #9467
This is first version for PR.
@Kai-Striega please review the commit.
I changed the structure for testing(Geometric mean only).
If this structure is looks fine, I will apply for Harmonic mean test. | 2018-11-16T04:50:31Z | TST: Duplicate tests for Geometric and Harmonic Means
The Geometric and Harmonic means have two sets of test cases in ``test_stats``. Ideally, the tests for related functions should occur in one place, not spread across multiple suites. I think these tests should be reviewed and combined into a single test suit where p... | Hello,
Should I take this issue?
If no problem, I will follow that.
Go ahead, it will be nice to have it done. | [
{
"body": "The Geometric and Harmonic means have two sets of test cases in ``test_stats``. Ideally, the tests for related functions should occur in one place, not spread across multiple suites. I think these tests should be reviewed and combined into a single test suit where possible. \r\n\r\nFor reference, the... | 3651d2d7d3380c4dcd80303ae50b563d38b4c037 | {
"head_commit": "9e81f039c6aff95af70940f8b5f19fad6d2295f5",
"head_commit_message": "Update test_stats.py\n\n- test method is changed (assert_allclose())\r\n- test_ma is moved to test_mstats_basic.py",
"patch_to_review": "diff --git a/scipy/stats/tests/test_stats.py b/scipy/stats/tests/test_stats.py\nindex f38339... | [
{
"diff_hunk": "@@ -3677,19 +3677,16 @@ def do(self, a, b, axis=None, dtype=None):\n assert_equal(x.dtype, dtype)\n \n \n-class GeoMeanTestMethod(object):\n- def equal_test(self, array_like, desired, axis=None, dtype=None, decimal=7):\n+class StatsTestMethod(object):\n+ def equal_test(self, array_... | b6e0fa5a0baa59250325e5f915780d6bf5be2fdc | diff --git a/scipy/stats/tests/test_mstats_basic.py b/scipy/stats/tests/test_mstats_basic.py
index 6ce2b192f183..953b76eadb0c 100644
--- a/scipy/stats/tests/test_mstats_basic.py
+++ b/scipy/stats/tests/test_mstats_basic.py
@@ -42,88 +42,116 @@ def test_mquantiles_limit_keyword(self):
assert_almost_equal(quants... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Test Suite / CI Enhancements"
} |
scipy__scipy-7353@0a59715 | scipy/scipy | Python | 7,353 | Add _gels functions | This solve the least square problem using the qr decomposition which is faster than gelsy, gelss and gelsd which are svd based. This closes #7316 . | 2017-04-29T17:11:59Z | dgels is missing
``dgels`` doesn't seem to be exposed in ``sp.linalg.lapack``. Would it make sense to expose it? Also it could be added as a driver to ``lstsq``. All the current drivers are SVD based, so it would be nice to have a method based on the QR decomposition. It should be a bit faster too. I can work on a PR i... | [
{
"body": "``dgels`` doesn't seem to be exposed in ``sp.linalg.lapack``. Would it make sense to expose it? Also it could be added as a driver to ``lstsq``. All the current drivers are SVD based, so it would be nice to have a method based on the QR decomposition. It should be a bit faster too. I can work on a PR... | 7fc15d190c27129386f1fdba12437bd279e15030 | {
"head_commit": "0a59715e9fc219570fc58e57a86de49f6500d8cf",
"head_commit_message": "more complete tests",
"patch_to_review": "diff --git a/scipy/linalg/flapack.pyf.src b/scipy/linalg/flapack.pyf.src\nindex c9c1788814ce..43f74e2018de 100644\n--- a/scipy/linalg/flapack.pyf.src\n+++ b/scipy/linalg/flapack.pyf.src\n... | [
{
"diff_hunk": "@@ -138,6 +138,66 @@ def test_clapack(self):\n \n class TestLeastSquaresSolvers(TestCase):\n \n+ def test_gels(self):\n+ for dtype in REAL_DTYPES:\n+ a1 = np.array([[1.0,2.0],\n+ [4.0,5.0],\n+ [7.0,8.0]], dtype=dtype)\n+ ... | 310e96fd2060c15ac5c394aa9eaee60e254c1dbe | diff --git a/scipy/linalg/flapack.pyf.src b/scipy/linalg/flapack.pyf.src
index c9c1788814ce..270e8ceeb445 100644
--- a/scipy/linalg/flapack.pyf.src
+++ b/scipy/linalg/flapack.pyf.src
@@ -1188,6 +1188,103 @@ interface
end subroutine <prefix2c>gesvd_lwork
+ subroutine <prefix2>gels(trans,m,n,nrhs,a,lda,b,ldb,wo... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
scipy__scipy-8907@3dfb0f8 | scipy/scipy | Python | 8,907 | BUG: ENH: Check if guess for newton is already zero before checking derivative | * fixes #8904
* adds a test to see if `RuntimeWarning` is raised for case where `fval(p0)` is already zero where `p0` is the initial guess
* checks in `newton` if `fval(p0)` is already zero, before iterating for any method or evaluating derivatives `fprime` (or `fprime2`) if given, and returns `_ECONVERGED` instead ... | 2018-06-05T18:06:46Z | BUG: if zero derivative at root, then Newton fails with RuntimeWarning
As indicated in [this discussion](../pull/8357#discussion_r192612946) by @pvanmulbregt
>... if the derivative is 0 at the root? E.g. `f(x)=x**3 - x**2`, starting at `x0=0` (immediately at the root), ... It looks like this might be considered a fa... | So I added a test for this:
```python
@pytest.mark.filterwarnings("error")
def test_gh8904_zeroder_at_root_fails():
"""Test that Newton or Halley don't warn if zero derivative at root"""
# a function that has a zero derivative at it's root
def f_zeroder_root(x):
return x ** 3 - x ** 2
... | [
{
"body": "As indicated in [this discussion](../pull/8357#discussion_r192612946) by @pvanmulbregt\r\n\r\n>... if the derivative is 0 at the root? E.g. `f(x)=x**3 - x**2`, starting at `x0=0` (immediately at the root), ... It looks like this might be considered a failure\r\n\r\n\r\n### Reproducing code example:\r... | dd71d65d137278c92e6fba7fc3421dc3101a7162 | {
"head_commit": "3dfb0f8de720e71e2bcd109010bcd9b9a2847d2c",
"head_commit_message": "TST: remove last test for halley since fder isn't zero, not right test",
"patch_to_review": "diff --git a/scipy/optimize/tests/test_zeros.py b/scipy/optimize/tests/test_zeros.py\nindex 15e054b9ca74..ddf77b2fa1ab 100644\n--- a/sci... | [
{
"diff_hunk": "@@ -169,3 +169,36 @@ def f_2(x, *a):\n y = zeros.newton(f, z, args=coeffs, fprime=f_1, fprime2=f_2, tol=1e-6)\n # (-0.75000000000000078+1.1989578808281789j)\n assert_allclose(f(y, *coeffs), 0, atol=1e-6)\n+\n+\n+@pytest.mark.filterwarnings(\"error\")",
"line": null,
"original... | 317fd5ef2dfb078b4089ea68fc958b3ae42f8995 | diff --git a/scipy/optimize/tests/test_zeros.py b/scipy/optimize/tests/test_zeros.py
index 15e054b9ca74..42a12d6a2e68 100644
--- a/scipy/optimize/tests/test_zeros.py
+++ b/scipy/optimize/tests/test_zeros.py
@@ -97,7 +97,7 @@ def test_newton_full_output(self):
x, r = zeros.newton(f1, x0, maxiter=ite... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
scipy__scipy-9174@5b3345e | scipy/scipy | Python | 9,174 | domain check for a < b in stats.truncnorm | I fix and a PR of the bug issued by @chrisb83.
I changed the condition formula for py_test from `a!=b and a<b` to
`np.bitwise_and(np.not_equal(a, b), np.less(a, b))` in `_argcheck`.
Closes #9169 | 2018-08-23T02:12:32Z | truncnorm does not work if b < a in scipy.stats
truncnorm does not check that `a < b`. If `b > a`, one can produce rvs but the pdf and cdf do not work.
Should be easy to fix using `_argcheck`.
### Reproducing code example:
```
from scipy import stats
import numpy as np
x = np.arange(1, 2, 0.1)
stats.truncno... | [
{
"body": "truncnorm does not check that `a < b`. If `b > a`, one can produce rvs but the pdf and cdf do not work.\r\nShould be easy to fix using `_argcheck`. \r\n\r\n### Reproducing code example:\r\n```\r\nfrom scipy import stats\r\nimport numpy as np\r\n\r\nx = np.arange(1, 2, 0.1)\r\nstats.truncnorm(2, 1).pd... | b944bac904a2edb78556de3c8c5680dc78f1d461 | {
"head_commit": "5b3345e4693e7e645284b8fbc3ea55c0ac84b0d0",
"head_commit_message": "argcheck condition updates\n\nChanged the condition for py_test.",
"patch_to_review": "diff --git a/scipy/stats/_continuous_distns.py b/scipy/stats/_continuous_distns.py\nindex 39d01c9c6275..65278fa6eda4 100644\n--- a/scipy/stats... | [
{
"diff_hunk": "@@ -6254,7 +6254,7 @@ def _argcheck(self, a, b):\n -(self._sb - self._sa),\n self._nb - self._na)\n self._logdelta = np.log(self._delta)\n- return a != b\n+ return np.bitwise_and(np.not_equal(a, b), np.less(a, b)... | 1b542389f403f84324290a97b07a6a8e6461d483 | diff --git a/scipy/stats/_continuous_distns.py b/scipy/stats/_continuous_distns.py
index 39d01c9c6275..a947ed9fde2c 100644
--- a/scipy/stats/_continuous_distns.py
+++ b/scipy/stats/_continuous_distns.py
@@ -6254,7 +6254,7 @@ def _argcheck(self, a, b):
-(self._sb - self._sa),
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
scipy__scipy-5288@9b73c67 | scipy/scipy | Python | 5,288 | BUG: multivariate_normal returns a pdf for values outside its support when covariance is singular | Closes #5286.
Before returning a value from `pdf` or `logpdf`, these methods now test that `x` is in the support of the distribution, by removing the projection and seeing if anything is left. The tolerance for this test is the same as that for deciding if the eigenvalues are zero.
The corresponding test, `test_d... | 2015-09-25T03:17:17Z | BUG: multivariate_normal returns a pdf for values outside its support when covariance is singular
When a multivariate normal distribution has a singular covariance matrix, its support (i.e. the set of possible values the random variable can take) is restricted to a manifold. In this case, the density with respect to th... | I've never contributed to scipy before. I've patched this. Do you want it? Do I just submit a pull request? Should I add tests?
https://github.com/scipy/scipy/compare/master...drpeteb:bug-mvn-singular-covariance
This is kind of a tricky issue and I'm not sure how it should have been handled. I think I've understood ... | [
{
"body": "When a multivariate normal distribution has a singular covariance matrix, its support (i.e. the set of possible values the random variable can take) is restricted to a manifold. In this case, the density with respect to the usual Lebesgue measure is not defined. There IS a density with respect to the... | da7a60213a181fe51540e727a9350948d47f8bc9 | {
"head_commit": "9b73c67978d1bc038a7a85832da70398dd9b30c0",
"head_commit_message": "Apply suggestions from code review\n\nCo-authored-by: Tirth Patel <tirthasheshpatel@gmail.com>",
"patch_to_review": "diff --git a/scipy/stats/_multivariate.py b/scipy/stats/_multivariate.py\nindex a5777aab2e44..9ffbed44af97 10064... | [
{
"diff_hunk": "@@ -172,6 +177,37 @@ def _sample_orthonormal_matrix(n):\n assert_allclose(logpdf_kk, logpdf_nn)\n assert_allclose(logpdf_kk, logpdf_rr)\n \n+ # Add an orthogonal component and find the density\n+ y_orth = y + u[:, -1]\n+ ... | 8a3dd3e7cf88f48fcd8adc02086cf04e643b1556 | diff --git a/scipy/stats/_multivariate.py b/scipy/stats/_multivariate.py
index a5777aab2e44..9ffbed44af97 100644
--- a/scipy/stats/_multivariate.py
+++ b/scipy/stats/_multivariate.py
@@ -168,14 +168,26 @@ def __init__(self, M, cond=None, rcond=None, lower=True,
s_pinv = _pinv_1d(s, eps)
U = np.multipl... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
comet-ml__opik-2302@6723a71 | comet-ml/opik | Python | 2,302 | [OPIK-1553]: Add LLM Calls count column to traces | ## Details
- Added llmCallCount to the Trace API model so each trace exposes the number of LLM calls count.
- Aggregated countIf(s.type = 'llm') in TraceDAO queries to compute the count and included it in trace mapping.
- Frontend Traces table includes the “Number of LLM Calls” column using the new field.
## Issu... | 2025-05-28T15:22:11Z | [FR]: Add column "Number of LLM Calls" for a Trace the in Project table
### Proposal summary
Add column "Number of LLM Calls" for a Trace the in Project table
### Motivation
This allows to better understand the complexity of Traces without the need to click on each of them | I'll take it | [
{
"body": "### Proposal summary\n\nAdd column \"Number of LLM Calls\" for a Trace the in Project table\n\n### Motivation\n\nThis allows to better understand the complexity of Traces without the need to click on each of them",
"number": 1553,
"title": "[FR]: Add column \"Number of LLM Calls\" for a Trace... | 3ce25575ed0aabab95d14811df7224f12e44e7b9 | {
"head_commit": "6723a71117b8bfe63f98f01420d4242f937a7c37",
"head_commit_message": "[OPIK-1553]: Code improvement",
"patch_to_review": "diff --git a/apps/opik-backend/src/main/java/com/comet/opik/api/Trace.java b/apps/opik-backend/src/main/java/com/comet/opik/api/Trace.java\nindex da12015b36..8b38a90424 100644\n... | [
{
"diff_hunk": "@@ -63,7 +63,9 @@ public record Trace(\n Trace.View.Public.class}) @Schema(accessMode = Schema.AccessMode.READ_ONLY, description = \"Duration in milliseconds as a decimal number to support sub-millisecond precision\") Double duration,\n @JsonView({Trace.View.Public.class,... | 4c8e6f922a0b37180957c75a8b059aaa3f634cb2 | diff --git a/apps/opik-backend/src/main/java/com/comet/opik/api/Trace.java b/apps/opik-backend/src/main/java/com/comet/opik/api/Trace.java
index da12015b36..7ba5114537 100644
--- a/apps/opik-backend/src/main/java/com/comet/opik/api/Trace.java
+++ b/apps/opik-backend/src/main/java/com/comet/opik/api/Trace.java
@@ -63,7 ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
scipy__scipy-7525@55cceca | scipy/scipy | Python | 7,525 | TST: Warning cleanup | These includes some cleanups, especially, however, it (re)enables that warnings are actually tested for as errors during development.
This flushed quite a few errors on Py3k especially, that were only ignored/caught but not specifically with a filter. Some of these filters could be done a bit more nicely with an `as... | 2017-06-25T14:45:18Z | TST: Clean up "ignore" warnings
gh-5796 has a start (and example) for avoiding "ignore" warning filters, especially in the test suit. They are problematic due to a python issue (actually limited to python <3.4 or so), which means that ignoring them in one test, can sometimes lead to ignoring them in other places as wel... | Thanks @seberg!
Labelled as easy-fix because it is indeed a straightforward task. It's quite a large one, but no need to tackle all of SciPy at once: if you want to do just one file or module, that'd be very welcome too. | [
{
"body": "gh-5796 has a start (and example) for avoiding \"ignore\" warning filters, especially in the test suit. They are problematic due to a python issue (actually limited to python <3.4 or so), which means that ignoring them in one test, can sometimes lead to ignoring them in other places as well. Which is... | e5a0cd71b4ca23475e2e24ccacb553da2c9d2fdf | {
"head_commit": "55cceca800e01fb761cec3dc4b9108a5c9cffec3",
"head_commit_message": "TST: test_stats fixup for NaNs\n\nIt seems I am not seeing them on my computer locally, maybe due to\na different numpy version or so.",
"patch_to_review": "diff --git a/runtests.py b/runtests.py\nindex f2c8e35b9f3b..d506c1541773... | [
{
"diff_hunk": "@@ -20,10 +20,10 @@ cdef public int wrap_PyUFunc_getfperr() nogil:\n cdef extern from \"numpy/npy_math.h\":\n double NPY_NAN\n \n-cimport sf_error\n-cimport _complexstuff\n+from . cimport sf_error\n+from . cimport _complexstuff\n cimport scipy.special._ufuncs_cxx\n-from . import _ufuncs\n+fr... | 970392da010304394572706f541763456d3b56e3 | diff --git a/runtests.py b/runtests.py
index f2c8e35b9f3b..d506c1541773 100755
--- a/runtests.py
+++ b/runtests.py
@@ -266,7 +266,13 @@ def test(*a, **kw):
extra_argv = extra_argv + tests[1:]
kw['extra_argv'] = extra_argv
from numpy.testing import Tester
- return Tester... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Test Suite / CI Enhancements"
} |
comet-ml__opik-1995@a45fc1e | comet-ml/opik | Python | 1,995 | [OPIK-1501]: [SDK] Add cost and token tracking to ADK integration | ## Details
Implemented support token usage tracking in ADK integration.
## Issues
Resolves #1955
## Testing
## Documentation
| 2025-04-30T17:33:02Z | [FR]: Add support for cost and token tracking in the ADK integration
### Proposal summary
When using Google's Agent Development Kit, costs or token usage are not logged to the platform. Cost and token tracking is supported in many other integrations, would be good to have it supported in ADK as well.
### Motivation
... | Hi @jverre, thank you for your request. We will put it on top of our list.
Supporting this use case. This is currently a blocker for me to use Opik in our product, since we moved away from Google generative-ai to google-adk for better support for multi-agent development. | [
{
"body": "### Proposal summary\n\nWhen using Google's Agent Development Kit, costs or token usage are not logged to the platform. Cost and token tracking is supported in many other integrations, would be good to have it supported in ADK as well.\n\n### Motivation\n\n_No response_",
"number": 1955,
"tit... | 5984ef9347df87314fd62505d0e7d8ef52a79e13 | {
"head_commit": "a45fc1e21d20161709b95b768df221f589eac077",
"head_commit_message": "[OPIK-1501]: Started implementation of the ADK library integration test.",
"patch_to_review": "diff --git a/.github/workflows/lib-adk-tests.yml b/.github/workflows/lib-adk-tests.yml\nnew file mode 100644\nindex 0000000000..3b6a1b... | [
{
"diff_hunk": "@@ -0,0 +1,61 @@\n+# Workflow to run ADK tests\n+#\n+# Please read inputs to provide correct values.\n+#\n+name: SDK Lib ADK (Google) Tests\n+run-name: \"SDK Lib ADK Tests ${{ github.ref_name }} by @${{ github.actor }}\"\n+env:\n+ GCP_CREDENTIALS_JSON: ${{ secrets.GCP_CREDENTIALS_JSON }}\n+ GO... | 8cd33e5446039526074c8e0994f264229f07d8bf | diff --git a/.github/actions/install_opik_and_run_e2e_lib_integration_tests/action.yml b/.github/actions/install_opik_and_run_e2e_lib_integration_tests/action.yml
new file mode 100644
index 0000000000..bdf2ab25f6
--- /dev/null
+++ b/.github/actions/install_opik_and_run_e2e_lib_integration_tests/action.yml
@@ -0,0 +1,40... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
comet-ml__opik-2333@5f24370 | comet-ml/opik | Python | 2,333 | [OPIK-1511]: [SDK] Long running jobs traces start and end batch creation with feature flag | ## Details
The Python SDK needs to support the ingestion of long running jobs, for instance taking 500 seconds.
For that:
1. It should create traces when they start by taking benefit of the relaxation of the required input fields.
Then, it should flush the complete details of the traces at finalization.
2. F... | 2025-05-30T14:12:42Z | [FR]: Flush partially completed traces - flush as they come
### Proposal summary
It would be great if traces could flush as they arrive for partial elements, instead of awaiting the top level function/trace to finish.
If the code raises an exception I don't get any data, which sucks for a case with 500s execution.
A... | Thanks for reporting @gustavhartz. We will look into the best way to support this.
Can you share a bit about your use case? Are these spans coming from a production workflow or this is in offline experimentation?
For a long running trace with a lot of sub traces and LLM calls, we cannot see the trace showing in the da... | [
{
"body": "### Proposal summary\n\nIt would be great if traces could flush as they arrive for partial elements, instead of awaiting the top level function/trace to finish. \nIf the code raises an exception I don't get any data, which sucks for a case with 500s execution.\n\nAdditionally, I don't want to wait 50... | 37a727cec8c1f04c8332040b5feed7be95438b60 | {
"head_commit": "5f24370c18130451ce092116cc2ed215594fa133",
"head_commit_message": "Merge branch 'main' into OPIK-1511-long-running-traces",
"patch_to_review": "diff --git a/sdks/python/src/opik/api_objects/opik_client.py b/sdks/python/src/opik/api_objects/opik_client.py\nindex 2e3ca362fd..ae421040c4 100644\n---... | [
{
"diff_hunk": "@@ -101,3 +101,31 @@ def _update_attachments(self, attachments: List[Attachment]) -> None:\n self.attachments = attachments\n else:\n self.attachments.extend(attachments)\n+\n+ @property\n+ def trace_start_parameters(self) -> Dict[str, Any]:",
"line": nu... | ee3034a67c6239453d33c2167c6bee50d095ad77 | diff --git a/sdks/python/src/opik/api_objects/opik_client.py b/sdks/python/src/opik/api_objects/opik_client.py
index 2e3ca362fd..cda3dcf9aa 100644
--- a/sdks/python/src/opik/api_objects/opik_client.py
+++ b/sdks/python/src/opik/api_objects/opik_client.py
@@ -237,6 +237,7 @@ def trace(
start_time = (
... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
comet-ml__opik-675@51d6233 | comet-ml/opik | Python | 675 | [OPIK-427]: remove pandas from the app dependencies; and add it to an unit test requirements; |
## Details
* Removed pandas from the dependencies of the app;
* Added it as a dependency to unit tests;
<img width="882" alt="image" src="https://github.com/user-attachments/assets/1b7f6306-3f86-4967-9474-5d2a446bcbfb">
## Issues
Resolves #
## Testing
## Documentation
| 2024-11-19T18:43:40Z | [FR]: Make pandas, numpy an optional dependency for the Python SDK
### Proposal summary
We are using Opik from within AWS Lambda, and numpy impacts the package size significantly. Unfortunately, it's required as a top-level import, and we use the SDK for only tracing purposes. Can we update the SDK to support working ... | Hi @SanjayBysani!
That's a good suggestion. Yes, we'll exclude pandas from the dependencies (probably next week).
Thanks @alexkuzmik | [
{
"body": "### Proposal summary\n\nWe are using Opik from within AWS Lambda, and numpy impacts the package size significantly. Unfortunately, it's required as a top-level import, and we use the SDK for only tracing purposes. Can we update the SDK to support working without a numpy dependency ?\n\n### Motivation... | 8718709fef2b0fedd548cf8433aaf8f10e8607a0 | {
"head_commit": "51d623398c24a02b0e1a17f7d75f087945af9012",
"head_commit_message": "[OPIK-427]: run linter;",
"patch_to_review": "diff --git a/.github/workflows/python_sdk_unit_tests.yml b/.github/workflows/python_sdk_unit_tests.yml\nindex 38e2f6ce11..2ec1b8f8e0 100644\n--- a/.github/workflows/python_sdk_unit_te... | [
{
"diff_hunk": "@@ -1,16 +1,34 @@\n-import pandas as pd\n import json\n \n-from typing import List, Callable, Any, Dict\n+from typing import List, Callable, Any, Dict, TYPE_CHECKING\n+import importlib.util\n+import logging\n+\n+if TYPE_CHECKING:\n+ import pandas as pd\n \n from . import dataset_item\n \n Ite... | 2ff26be014d874a08c9f53d410bcea557b62be12 | diff --git a/.github/workflows/python_sdk_unit_tests.yml b/.github/workflows/python_sdk_unit_tests.yml
index 38e2f6ce11..2ec1b8f8e0 100644
--- a/.github/workflows/python_sdk_unit_tests.yml
+++ b/.github/workflows/python_sdk_unit_tests.yml
@@ -42,7 +42,7 @@ jobs:
- name: Install test requirements
run: |
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Dependency Updates & Env Compatibility"
} |
comet-ml__opik-804@18466f3 | comet-ml/opik | Python | 804 | [OPIK-374] Add bulk actions to all tables | ## Details
![image](https://github.com/user-at... | 2024-12-03T16:46:21Z | [FR]: Add multi-select options for Dataset view
### Willingness to contribute
No. I can't contribute this feature at this time.
### Proposal summary
It would be great if the experiment/dataset/projets pages UI is consistent. At the moment you can only delete one dataset at the time.
### Motivation
I have created 1... | @idoberko2 Can you take a look at this, I think we might have an endpoint missing for deleting multiple datasets
@jverre from what I see all resources lack multiple deletion endpoints
In addition to deleting multiple datasets it would be useful to be able to delete multiple DatasetItems within a Dataset | [
{
"body": "### Willingness to contribute\n\nNo. I can't contribute this feature at this time.\n\n### Proposal summary\n\nIt would be great if the experiment/dataset/projets pages UI is consistent. At the moment you can only delete one dataset at the time.\n\n### Motivation\n\nI have created 13 datasets which i ... | 143013383e7c8d96f07ed56d0b58d43032925637 | {
"head_commit": "18466f32fde325ed8e9ffc25c04afa6e332bc3a4",
"head_commit_message": "[OPIK-374] Add bulk actions to all tables",
"patch_to_review": "diff --git a/apps/opik-frontend/src/api/datasets/useDatasetBatchDeleteMutation.ts b/apps/opik-frontend/src/api/datasets/useDatasetBatchDeleteMutation.ts\nnew file mo... | [
{
"diff_hunk": "@@ -0,0 +1,58 @@\n+import React, { useCallback, useRef, useState } from \"react\";\n+import { Trash } from \"lucide-react\";\n+\n+import { Button } from \"@/components/ui/button\";\n+import { FeedbackDefinition } from \"@/types/feedback-definitions\";\n+import useFeedbackDefinitionBatchDeleteMut... | faee624d688932c829e6bd430eb7743e054fe42c | diff --git a/apps/opik-frontend/src/api/datasets/useDatasetBatchDeleteMutation.ts b/apps/opik-frontend/src/api/datasets/useDatasetBatchDeleteMutation.ts
new file mode 100644
index 0000000000..db5325a67d
--- /dev/null
+++ b/apps/opik-frontend/src/api/datasets/useDatasetBatchDeleteMutation.ts
@@ -0,0 +1,42 @@
+import { u... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
comet-ml__opik-1276@0d7f439 | comet-ml/opik | Python | 1,276 | [OPIK-689] [FR]: Add Support for Additional AI Provider Configurations (Local Models) | ## Details
This PR should be merged only when the Python SDK part is merged.
Add the ability to select as a provider Ollama installed locally.
![image](https://github.com/user-attachments/assets/8f757294-35c8-4413-a917-28... | 2025-02-13T12:23:54Z | [FR]: Add Support for Additional AI Provider Configurations
### Proposal summary
Currently, the platform supports integrating AI providers like OpenAI in the configuration page for the playground. To improve flexibility and cater to a broader user base, we propose adding configurations for additional AI providers, s... | Hi @madhankumar2211
This is a great idea !
@aadereiko Can we look into this once we have finished the dataset integration for the playground - The idea would be to have an AI provider that doesn't go through the BE proxy but rather Ollama running locally (see https://github.com/ollama/ollama?tab=readme-ov-file#cha... | [
{
"body": "### Proposal summary\r\n\r\nCurrently, the platform supports integrating AI providers like OpenAI in the configuration page for the playground. To improve flexibility and cater to a broader user base, we propose adding configurations for additional AI providers, specifically for locally hosted models... | 2d7413d768c3d805be7d1d57e7aa161907f94057 | {
"head_commit": "0d7f43937030a2952fb8d3a1ab9bfad317c18246",
"head_commit_message": "[OPIK-689] [FR]: Add Support for Additional AI Provider Configurations (Local Models)",
"patch_to_review": "diff --git a/apps/opik-frontend/src/api/api.ts b/apps/opik-frontend/src/api/api.ts\nindex 81f2519765..28fb8ba8e1 100644\n... | [
{
"diff_hunk": "@@ -0,0 +1,93 @@\n+import React from \"react\";\n+import { UseFormReturn } from \"react-hook-form\";\n+import { Label } from \"@/components/ui/label\";\n+import { PROVIDER_TYPE } from \"@/types/providers\";\n+import { PROVIDERS } from \"@/constants/providers\";\n+import { AIProviderFormType } fr... | 78c200d31548e3f5d48d56d20181bb43f1a8a57d | diff --git a/apps/opik-frontend/src/api/api.ts b/apps/opik-frontend/src/api/api.ts
index 81f2519765..28fb8ba8e1 100644
--- a/apps/opik-frontend/src/api/api.ts
+++ b/apps/opik-frontend/src/api/api.ts
@@ -25,7 +25,7 @@ export const COMPARE_EXPERIMENTS_KEY = "compare-experiments";
export const SPANS_KEY = "spans";
expor... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
comet-ml__opik-709@8851945 | comet-ml/opik | Python | 709 | update_current_span now supports updating the output | ## Details
Updated the `update_current_span` and `update_current_trace` methods to not override `input` and `output` values but instead merge them with existing values.
## Issues
Resolves #708
## Testing
Added unit test
## Documentation
No docs updated
| 2024-11-23T22:14:31Z | [Bug]: Calling `update_current_span` with output parameter does nothing
### What component(s) are affected?
- [X] Python SDK
- [ ] Opik UI
- [ ] Opik Server
- [ ] Documentation
### Opik version
- Opik version: 1.1.9
### Describe the problem
Calling `update_current_span(output={"new_key": "test"})` does not updat... | [
{
"body": "### What component(s) are affected?\n\n- [X] Python SDK\n- [ ] Opik UI\n- [ ] Opik Server\n- [ ] Documentation\n\n### Opik version\n\n- Opik version: 1.1.9\r\n\n\n### Describe the problem\n\nCalling `update_current_span(output={\"new_key\": \"test\"})` does not update the output.\n\n### Reproduction ... | 111267a650fe0a697c4005c90c63697df3de0adc | {
"head_commit": "8851945a3e4523a0272b5cee81a4b72e0252e217",
"head_commit_message": "Update end to end test",
"patch_to_review": "diff --git a/sdks/python/src/opik/api_objects/span.py b/sdks/python/src/opik/api_objects/span.py\nindex ec75b15012..99abcfd125 100644\n--- a/sdks/python/src/opik/api_objects/span.py\n+... | [
{
"diff_hunk": "@@ -399,7 +399,7 @@ def _after_call(\n )\n \n client = opik_client.get_client_cached()\n-\n+ print(\"span_data_to_end\", span_data_to_end)",
"line": null,
"original_line": 402,
"original_start_line": null,
"path": "sdks/python/src/opik/decor... | 6228286bfbca5f2430c724ef0488d1efb1b03c51 | diff --git a/sdks/python/src/opik/api_objects/span.py b/sdks/python/src/opik/api_objects/span.py
index ec75b15012..99abcfd125 100644
--- a/sdks/python/src/opik/api_objects/span.py
+++ b/sdks/python/src/opik/api_objects/span.py
@@ -271,6 +271,12 @@ def update(self, **new_data: Any) -> "SpanData":
if key == ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
keephq__keep-5142@d347f64 | keephq/keep | Python | 5,142 | fix: incident enrichments | <!--
Thanks for creating this pull request 🤗
Please make sure that the pull request is limited to one type (docs, feature, etc.) and keep it as small as possible. You can open multiple prs instead of opening a huge one.
-->
<!-- If this pull request closes an issue, please mention the issue number below -->
... | 2025-07-03T12:06:32Z | [🐛 Bug]: Incident made enrichments via workflow aren't visible when using mysql
**To Reproduce**
Steps to reproduce the behavior:
1. Create a workflow:
```yaml
workflow:
id: incident-metadata-enricher
name: Incident Metadata Enricher
description: Enriches incidents with additional metadata including environment... | <!-- Answer -->
The enrichment you add via workflow is being stored in the database, but it's not showing up in the UI—unlike enrichments added manually. Based on recent code and PRs, the backend uses the same enrichment logic for both workflow and manual actions, so the difference is likely in how the UI fetches or fi... | [
{
"body": "**To Reproduce**\nSteps to reproduce the behavior:\n\n1. Create a workflow:\n```yaml\nworkflow:\n id: incident-metadata-enricher\n name: Incident Metadata Enricher\n description: Enriches incidents with additional metadata including environment, incident IDs, URLs, and provider information while l... | 15093b8410e741d47f17bf8b39c941535b872190 | {
"head_commit": "d347f645fd990d1954b85d655a835ea6255b4d75",
"head_commit_message": "fix: add migration",
"patch_to_review": "diff --git a/keep/api/bl/enrichments_bl.py b/keep/api/bl/enrichments_bl.py\nindex 2d6894fc37..44d22f866c 100644\n--- a/keep/api/bl/enrichments_bl.py\n+++ b/keep/api/bl/enrichments_bl.py\n@... | [
{
"diff_hunk": "@@ -67,6 +73,7 @@ def stop(self):\n self.started = False\n # Clear the scheduler reference\n self.scheduler = None\n+ WorkflowManager._instance = None",
"line": null,
"original_line": 76,
"original_start_line": 75,
"path": "keep/workflowmanager/work... | 3a49840f139a5298fc28f8568c77eaeb8de8bec7 | diff --git a/keep/api/bl/enrichments_bl.py b/keep/api/bl/enrichments_bl.py
index 2d6894fc37..44d22f866c 100644
--- a/keep/api/bl/enrichments_bl.py
+++ b/keep/api/bl/enrichments_bl.py
@@ -722,7 +722,7 @@ def disposable_enrich_entity(
def enrich_entity(
self,
- fingerprint: str,
+ fingerprin... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
comet-ml__opik-1192@8c7fe30 | comet-ml/opik | Python | 1,192 | Updated behavior with Opik tracking is disabled | ## Details
Improvements to the `OPIK_TRACK_DISABLE` behavior:
1. No longer display the message about configuring the SDK
2. Fix the LangChain integration to not track traces and spans
Partially resolves #1169 | 2025-02-02T21:02:47Z | [FR]: Some form of transparent delegation or null-object pattern for cases of shared code bases with users gradually onboarding opik
### Proposal summary
My team is still in the process of onboarding use of opik, which means some people will have running instances of opik whereas others won't.
I would like opik to no... | @donatoaz Good suggestion, let me take a look later today
Hi @donatoaz,
I've taken a closer look and indeed I think we can improve the user experience when a user doesn't have Opik configured / installed. We currently have the `OPIK_TRACK_DISABLE` environment variable that disables the logging of data to Opik but it s... | [
{
"body": "### Proposal summary\n\nMy team is still in the process of onboarding use of opik, which means some people will have running instances of opik whereas others won't.\n\nI would like opik to not be obstruction to those who have not yet onboarded without having to add conditional logic across my code.\n... | 0c3fe5f84922974de8a5dd117513898e7d1f8bc9 | {
"head_commit": "8c7fe30d57087c8b713438606ccf3f9ca0a5483c",
"head_commit_message": "Updated behavior with Opik tracking is disabled",
"patch_to_review": "diff --git a/sdks/python/src/opik/api_objects/opik_client.py b/sdks/python/src/opik/api_objects/opik_client.py\nindex 9c8016897f..5de7ff8267 100644\n--- a/sdks... | [
{
"diff_hunk": "@@ -286,38 +286,72 @@ def created_traces(self) -> List[trace.Trace]:\n \"\"\"\n return self._created_traces\n \n+ def _skip_tracking(self) -> bool:\n+ config = self._opik_client._config",
"line": null,
"original_line": 290,
"original_start_line": null,
"... | 795327e70e95db190b8a98d8beffb9ab27c553c8 | diff --git a/sdks/python/src/opik/api_objects/opik_client.py b/sdks/python/src/opik/api_objects/opik_client.py
index fd39fbd12b..eb638981c5 100644
--- a/sdks/python/src/opik/api_objects/opik_client.py
+++ b/sdks/python/src/opik/api_objects/opik_client.py
@@ -70,6 +70,7 @@ def __init__(
api_key=api_key,
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
keephq__keep-5140@8f0cef9 | keephq/keep | Python | 5,140 | fix: Use integer severities for zabbix provider | <!--
Thanks for creating this pull request 🤗
Please make sure that the pull request is limited to one type (docs, feature, etc.) and keep it as small as possible. You can open multiple prs instead of opening a huge one.
-->
<!-- If this pull request closes an issue, please mention the issue number below -->
... | 2025-07-03T07:15:27Z | [🐛 Bug]: Zabbix provider is misclassifying the alert severity
**Describe the bug**
Whenever Zabbix sends a critical alert, Keep does not display it with the correct severity.
**To Reproduce**
Steps to reproduce the behavior:
1. Login to Zabbix as an admin and edit the severity names.
2. Save the changes and let the ... | <!-- Answer -->
The Zabbix provider in Keep uses a static mapping for severity names and only recognizes the default Zabbix severities: "not_classified", "information", "warning", "average", "high", and "disaster". If you customize severity names in Zabbix, Keep won't recognize them and will default to displaying those... | [
{
"body": "**Describe the bug**\nWhenever Zabbix sends a critical alert, Keep does not display it with the correct severity.\n\n**To Reproduce**\nSteps to reproduce the behavior:\n\n1. Login to Zabbix as an admin and edit the severity names.\n2. Save the changes and let the new alerts forward to keep.\n\n**Expe... | 289d858a821014f913c71974dc4158d93fba02cb | {
"head_commit": "8f0cef9cfe48ce2a2721be6b0665d53597c46d11",
"head_commit_message": "Merge branch 'main' into 5139-fix-alert-severity-classification-for-zabbix",
"patch_to_review": "diff --git a/docs/snippets/providers/zabbix-snippet-autogenerated.mdx b/docs/snippets/providers/zabbix-snippet-autogenerated.mdx\nin... | [
{
"diff_hunk": "@@ -205,12 +205,21 @@ class ZabbixProvider(BaseProvider):\n ]\n \n SEVERITIES_MAP = {\n- \"not_classified\": AlertSeverity.LOW,\n- \"information\": AlertSeverity.INFO,\n- \"warning\": AlertSeverity.WARNING,\n- \"average\": AlertSeverity.WARNING,\n- \"hi... | 78d29e567307dec29f38236564de32772f16a75e | diff --git a/docs/snippets/providers/zabbix-snippet-autogenerated.mdx b/docs/snippets/providers/zabbix-snippet-autogenerated.mdx
index 3a077e4f21..d26b20b8fd 100644
--- a/docs/snippets/providers/zabbix-snippet-autogenerated.mdx
+++ b/docs/snippets/providers/zabbix-snippet-autogenerated.mdx
@@ -1,4 +1,4 @@
-{/* This sni... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
keephq__keep-4976@d182571 | keephq/keep | Python | 4,976 | fix: mustache yaml validation | <!--
Thanks for creating this pull request 🤗
Please make sure that the pull request is limited to one type (docs, feature, etc.) and keep it as small as possible. You can open multiple prs instead of opening a huge one.
-->
<!-- If this pull request closes an issue, please mention the issue number below -->
... | 2025-06-04T11:33:38Z | [🐛 Bug]: mustache variable validation in YAML isn't complete
This should be valid:
- `{{ . }}` if used inside a step with foreach
These should be invalid:
- `{{ providers['Default Grafana'] }}`: should use dot notation `{{ providers.Default Grafana }}` (mustache doesn't support whitespaces in dot notation, but we do)... | <!-- Answer -->
You are correct that mustache variable validation in YAML is not fully complete. The current validation logic is implemented in files like `validate-definition.ts` and `validate-yaml.ts`, which check for proper syntax and access rules for mustache variables in workflow definitions. These functions enfor... | [
{
"body": "This should be valid:\n- `{{ . }}` if used inside a step with foreach\n\nThese should be invalid:\n- `{{ providers['Default Grafana'] }}`: should use dot notation `{{ providers.Default Grafana }}` (mustache doesn't support whitespaces in dot notation, but we do)\n- `{{ steps.python-step.result[0][0] ... | ba9c791d24ac8f935f2faf0eaaca67df2844c6b4 | {
"head_commit": "d182571ea262aed926d010751143e522a9720cc4",
"head_commit_message": "fix: severity mapping",
"patch_to_review": "diff --git a/keep-ui/entities/workflows/lib/__tests__/validate-mustache.test.ts b/keep-ui/entities/workflows/lib/__tests__/validate-mustache-ui-builder.test.ts\nsimilarity index 56%\nre... | [
{
"diff_hunk": "@@ -70,38 +70,38 @@ describe(\"validateMustacheVariableName\", () => {\n });\n \n it(\"should prevent accessing current step results\", () => {\n- const result = validateMustacheVariableName(\n- \"{{ steps.First Step.results }}\",\n+ const result = validateMustacheVariableForUIBui... | 28734cbfbf8abf9466a1d80a5968a8ba6915df6a | diff --git a/keep-ui/entities/workflows/lib/__tests__/validate-mustache-ui-builder.test.ts b/keep-ui/entities/workflows/lib/__tests__/validate-mustache-ui-builder.test.ts
new file mode 100644
index 0000000000..13999985ff
--- /dev/null
+++ b/keep-ui/entities/workflows/lib/__tests__/validate-mustache-ui-builder.test.ts
@... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
All-Hands-AI__OpenHands-9211@d528a86 | All-Hands-AI/OpenHands | Python | 9,211 | feat: Add Windows PowerShell support to CLI runtime | ## Summary
This PR implements automatic Windows PowerShell support for the OpenHands CLI runtime, addressing issue #9210. The implementation leverages the existing `WindowsPowershellSession` infrastructure to provide better Windows compatibility.
## Changes
### Core Implementation
- **Automatic Windows Detection**: ... | 2025-06-18T11:27:33Z | CLI mode does not fully support Windows+PowerShell
## Problem
The OpenHands CLI mode currently does not properly support Windows systems with PowerShell. While OpenHands has comprehensive PowerShell support implemented in `openhands/runtime/utils/windows_bash.py`, the CLI runtime (`openhands/runtime/impl/cli/cli_runti... | [
{
"body": "## Problem\n\nThe OpenHands CLI mode currently does not properly support Windows systems with PowerShell. While OpenHands has comprehensive PowerShell support implemented in `openhands/runtime/utils/windows_bash.py`, the CLI runtime (`openhands/runtime/impl/cli/cli_runtime.py`) only uses subprocess w... | 3d9761df7edfe6c85ca612b43e6fd4332ca5960f | {
"head_commit": "d528a86c967d34915cfa8b178086eac04484c20b",
"head_commit_message": "Delete WINDOWS_POWERSHELL_TEST_PLAN.md",
"patch_to_review": "diff --git a/docs/usage/windows-without-wsl.mdx b/docs/usage/windows-without-wsl.mdx\nindex 0ebe321b3ee7..f09d874a2e88 100644\n--- a/docs/usage/windows-without-wsl.mdx\... | [
{
"diff_hunk": "@@ -135,6 +169,20 @@ async def connect(self) -> None:\n # Change to the workspace directory\n os.chdir(self._workspace_path)\n \n+ # Initialize PowerShell session if on Windows\n+ if self._is_windows:\n+ try:\n+ self._powershell_session = W... | 9f704548ce44b8e4ea85769f1872d695158adbd8 | diff --git a/docs/usage/windows-without-wsl.mdx b/docs/usage/windows-without-wsl.mdx
index 0ebe321b3ee7..f09d874a2e88 100644
--- a/docs/usage/windows-without-wsl.mdx
+++ b/docs/usage/windows-without-wsl.mdx
@@ -133,13 +133,66 @@ This guide provides step-by-step instructions for running OpenHands on a Windows
> **... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} | |
All-Hands-AI__OpenHands-9333@ff1a50c | All-Hands-AI/OpenHands | Python | 9,333 | feat: Add user directory support for microagents | - [x] This change is worth documenting at https://docs.all-hands.dev/
- [x] Include this change in the Release Notes. If checked, you **must** provide an **end-user friendly** description for your change below
**End-user friendly description of the problem this fixes or functionality this introduces.**
Supports ... | 2025-06-24T21:47:04Z | Add User Directory Support for Microagents
(openhands-agent, after it made a funny boo-boo and proved it uses `git reflog` better than me 😅)
## Problem
Currently, microagents are read from multiple locations but not from a user-specific directory. This leads to the problem of having uncommitted local microagents in t... | [
{
"body": "(openhands-agent, after it made a funny boo-boo and proved it uses `git reflog` better than me 😅)\n\n## Problem\nCurrently, microagents are read from multiple locations but not from a user-specific directory. This leads to the problem of having uncommitted local microagents in the repository, which ... | dfe6f2d8cc78406dd8b5cb48b58698e5503edfc3 | {
"head_commit": "ff1a50c53288b1abb5f103c82ef5ce0b57faad7e",
"head_commit_message": "feat: Add user directory support for microagents\n\n- Add ~/.openhands/microagents/ as a microagent source directory\n- User microagents are loaded after global ones, allowing overrides\n- Automatically create user microagents dire... | [
{
"diff_hunk": "@@ -33,6 +33,8 @@\n 'microagents',\n )\n \n+USER_MICROAGENTS_DIR = os.path.expanduser('~/.openhands/microagents')",
"line": null,
"original_line": 36,
"original_start_line": null,
"path": "openhands/memory/memory.py",
"start_line": null,
"text": "@user1:\nWill this on... | 03ec0d388471a779dcefdda30b754179d596f196 | diff --git a/openhands/memory/memory.py b/openhands/memory/memory.py
index 488dc795d61f..a9fa2792a635 100644
--- a/openhands/memory/memory.py
+++ b/openhands/memory/memory.py
@@ -2,6 +2,7 @@
import os
import uuid
from datetime import datetime, timezone
+from pathlib import Path
from typing import Callable
import... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
All-Hands-AI__OpenHands-9331@dc489c4 | All-Hands-AI/OpenHands | Python | 9,331 | Add GitLab alternative directory support for microagents | ## Summary
This PR adds support for an alternative directory name `openhands-config` for GitLab repositories to store organization and repository-specific microagents, while maintaining backward compatibility with the existing `.openhands` directory.
## Changes
### Core Implementation
- **Added `_is_gitlab_re... | 2025-06-24T20:53:15Z | [Bug] Openhands `.openhands` org-level repo naming convention unsupported in GitLab / Self-Hosted GitLab.
**What problem or use case are you trying to solve?**
The creation of Org-level microagent repos is neat! Currently the hardcoded naming convention precludes using them in GitLab.
**Describe the UX or technical ... | Thanks for noting this! I noticed the same issue and started working on it, apologies for taking it despite the fact that you offered!
I'm on it! neubig can [track my progress at all-hands.dev](https://app.all-hands.dev/conversations/9f6edd1e131744cb9bf4de882a27ec50) | [
{
"body": "**What problem or use case are you trying to solve?**\n\nThe creation of Org-level microagent repos is neat! Currently the hardcoded naming convention precludes using them in GitLab.\n\n**Describe the UX or technical implementation you have in mind**\n\nAccording to DeepWiki This should be relativel... | 8e4a8a65f841099e6001334623d43364ddf22bd8 | {
"head_commit": "dc489c48f730075b70a9283b833cf95aec69ad1c",
"head_commit_message": "Add GitLab alternative directory support for microagents\n\n- Add _is_gitlab_repository() method to detect GitLab repositories\n- Modify get_microagents_from_org_or_user() to try 'openhands-config' first for GitLab repos\n- Modify ... | [
{
"diff_hunk": "@@ -756,7 +811,19 @@ def get_microagents_from_selected_repo(\n \n # Continue with repository-specific microagents\n repo_root = self.workspace_root / selected_repository.split('/')[-1]\n- microagents_dir = repo_root / '.openhands' / 'microagents'\n+\n+ ... | a043cbd78f55102880d7031c30e7f40da3f71f98 | diff --git a/docs/usage/prompting/microagents-org.mdx b/docs/usage/prompting/microagents-org.mdx
index 3444abb9f531..40ce77e0d869 100644
--- a/docs/usage/prompting/microagents-org.mdx
+++ b/docs/usage/prompting/microagents-org.mdx
@@ -11,6 +11,8 @@ accordingly. However, they are applied to all repositories belonging to... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
keephq__keep-4725@ffa79be | keephq/keep | Python | 4,725 | feat: Improve user interaction with workflow templates | <!--
Thanks for creating this pull request 🤗
Please make sure that the pull request is limited to one type (docs, feature, etc.) and keep it as small as possible. You can open multiple prs instead of opening a huge one.
-->
<!-- If this pull request closes an issue, please mention the issue number below -->
... | 2025-05-07T07:32:17Z | [➕ Feature]: Improve user interaction with workflow templates
**Is your feature request related to a problem? Please describe.**
Currently we display random templates.
**Describe the solution you'd like**
1. When no workflows created - display templates
2. When at least one workflow is created - no templates
3. When t... | [
{
"body": "**Is your feature request related to a problem? Please describe.**\nCurrently we display random templates.\n\n**Describe the solution you'd like**\n1. When no workflows created - display templates\n2. When at least one workflow is created - no templates\n3. When the user tries to create a workflow - ... | 11b8893bd9e337675cc71115636963c8931e79a5 | {
"head_commit": "ffa79beb66596ef9e13e5368b084fecc76f534d8",
"head_commit_message": "remove unused mock for WorkflowTemplates in existing workflows state test",
"patch_to_review": "diff --git a/keep-ui/app/(keep)/workflows/[workflow_id]/workflow-overview.tsx b/keep-ui/app/(keep)/workflows/[workflow_id]/workflow-o... | [
{
"diff_hunk": "@@ -0,0 +1,35 @@\n+import { WorkflowTemplate } from \"@/shared/api/workflows\";\n+import { useApi } from \"@/shared/lib/hooks/useApi\";\n+import useSWR, { SWRConfiguration } from \"swr\";\n+\n+export interface WorkflowTemplatesQuery {\n+ cel: string;\n+ limit: number;\n+ offset: number;\n+}\n... | ae8b355cb10a72cbed61fbc09506079d024d1a7f | diff --git a/keep-ui/app/(keep)/workflows/[workflow_id]/workflow-overview.tsx b/keep-ui/app/(keep)/workflows/[workflow_id]/workflow-overview.tsx
index d7e5b97e59..a29f0e64c5 100644
--- a/keep-ui/app/(keep)/workflows/[workflow_id]/workflow-overview.tsx
+++ b/keep-ui/app/(keep)/workflows/[workflow_id]/workflow-overview.t... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
keephq__keep-4664@98c6960 | keephq/keep | Python | 4,664 | fix: delete workflows that are not provisioned anymore | <!--
Thanks for creating this pull request 🤗
Please make sure that the pull request is limited to one type (docs, feature, etc.) and keep it as small as possible. You can open multiple prs instead of opening a huge one.
-->
<!-- If this pull request closes an issue, please mention the issue number below -->
... | 2025-04-30T15:44:11Z | [🐛 Bug]: Workflow not deleted when we don't provision it anymore
Hi team,
I am provisioning a workflow via the environment, but when I stop provisioning it, the workflow continues to run normally instead of being deleted.
Additionally, I’ve noticed that if I repeatedly stop provisioning and restart the backend, the ... | <!-- Answer -->
When a workflow is no longer provisioned, it should be deprovisioned based on specific conditions. The system checks if the workflow's provisioned file is `None`, does not exist, or is outside the `provisioned_workflows_dir`. If any of these conditions are met, the workflow should be deprovisioned <sup>... | [
{
"body": "Hi team,\n\nI am provisioning a workflow via the environment, but when I stop provisioning it, the workflow continues to run normally instead of being deleted.\n\nAdditionally, I’ve noticed that if I repeatedly stop provisioning and restart the backend, the number of workflows increases significantly... | fc01ed670be54804d40ccaaa73bc28723f7c02e6 | {
"head_commit": "98c69606b2e04a4da5227afab3934b86b74240e1",
"head_commit_message": "fix: use \"workflow\" key value as workflow_dict if present",
"patch_to_review": "diff --git a/keep/api/core/db.py b/keep/api/core/db.py\nindex 5dc0f14dc6..85a3f15faa 100644\n--- a/keep/api/core/db.py\n+++ b/keep/api/core/db.py\n... | [
{
"diff_hunk": "@@ -330,43 +340,53 @@ def provision_workflows(\n f\"Directory {provisioned_workflows_dir} does not exist\"\n )\n \n- # Get all existing provisioned workflows\n- provisioned_workflows = get_all_provisioned_workflows(tenant_id)\n-\n ### Provisionin... | 5259030b1d03f6c902f0752e4b4e936afb1c7753 | diff --git a/keep/api/core/db.py b/keep/api/core/db.py
index 5dc0f14dc6..85a3f15faa 100644
--- a/keep/api/core/db.py
+++ b/keep/api/core/db.py
@@ -481,7 +481,7 @@ def update_workflow_with_values(
existing_workflow: Workflow,
name: str,
description: str | None,
- interval: int,
+ interval: int | Non... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
All-Hands-AI__OpenHands-9283@ad6a8d3 | All-Hands-AI/OpenHands | Python | 9,283 | Fix incomplete localization issue #9282 | ## Summary
This PR fixes issue #9282 about incomplete localization by addressing multiple critical bugs in the localization check script and localizing all previously unlocalized strings in the frontend.
## Changes Made
### 🔧 **Localization Check Script Fixes**
- **Fixed placeholder/alt/aria-label detection**: Remo... | 2025-06-21T20:35:25Z | [Bug]: Incomplete localization
### Is there an existing issue for the same bug? (If one exists, thumbs up or comment on the issue instead).
- [x] I have checked the existing issues.
### Describe the bug and reproduction steps
Our localization is incomplete again.
- Maximum budget per conversation in USD
- Suggested... | I'm on it! neubig can [track my progress at all-hands.dev](https://app.all-hands.dev/conversations/3246560478254750bf968615e9056d5e)
I have successfully fixed GitHub issue #9282 about incomplete localization. The solution involved:
1. **Enhanced the localization check script** to properly detect user-facing text in pl... | [
{
"body": "### Is there an existing issue for the same bug? (If one exists, thumbs up or comment on the issue instead).\n\n- [x] I have checked the existing issues.\n\n### Describe the bug and reproduction steps\n\nOur localization is incomplete again.\n\n- Maximum budget per conversation in USD\n- Suggested ta... | fafbe81d517e2d542102a13a8a2466a9852baa14 | {
"head_commit": "ad6a8d358b41d6fa4bec1b721c783ddea2ed40e7",
"head_commit_message": "Fix TypeScript compilation error in test file\n\n- Fixed null assertion error in localization-fix.test.ts\n- All CI checks now passing:\n - Frontend unit tests: ✅ 366 passed\n - TypeScript compilation: ✅ No errors\n - Frontend l... | [
{
"diff_hunk": "@@ -540,11 +539,15 @@ function isInTranslationContext(path) {\n }\n \n function scanFileForUnlocalizedStrings(filePath) {\n- // Skip all suggestion files as they contain special strings\n- if (filePath.includes(\"suggestions\")) {\n+ // Skip suggestion content files as they contain special st... | d82592282a39a57dd150415509630bd1c0fe3bd6 | diff --git a/frontend/__tests__/components/features/home/repo-connector.test.tsx b/frontend/__tests__/components/features/home/repo-connector.test.tsx
index afbf218c7941..3f7c2248e4d8 100644
--- a/frontend/__tests__/components/features/home/repo-connector.test.tsx
+++ b/frontend/__tests__/components/features/home/repo-... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
All-Hands-AI__OpenHands-9021@d1c3ee6 | All-Hands-AI/OpenHands | Python | 9,021 | Add Bitbucket microagent and backend implementation | - [X] This change is worth documenting at https://docs.all-hands.dev/
- [X] Include this change in the Release Notes. If checked, you **must** provide an **end-user friendly** description for your change below
**End-user friendly description of the problem this fixes or functionality this introduces.**
- Adds inte... | 2025-06-09T19:27:47Z | Create Bitbucket microagent similar to GitHub microagent
## Description
Implement a Bitbucket microagent similar to the existing GitHub and GitLab microagents to provide support for Bitbucket repositories and operations.
## Requirements
### Microagent File
- Create a `bitbucket.md` file in the `microagents` directory... | @openhands start by implementing only the microagent, the other two parts could be implemented later.
I'm on it! neubig can [track my progress at all-hands.dev](https://app.all-hands.dev/conversations/a84fb3a8133340618c7c9d787da0ef6d)
# Work Summary
I successfully implemented the Bitbucket microagent functionality for... | [
{
"body": "## Description\nImplement a Bitbucket microagent similar to the existing GitHub and GitLab microagents to provide support for Bitbucket repositories and operations.\n\n## Requirements\n\n### Microagent File\n- Create a `bitbucket.md` file in the `microagents` directory following the pattern of `githu... | 78af1de8708724a1f0ecf4263a94e5173ca32b0f | {
"head_commit": "d1c3ee62672780fc596aeaf5ba7036be650aa631",
"head_commit_message": "refactor: update get_bitbucket_username to use class properties\n\n- Remove token_value and domain parameters from method signature\n- Use self.token and self.BASE_URL from class instance\n- Replace httpx client with existing _make... | [
{
"diff_hunk": "@@ -50,6 +50,7 @@\n \n class IssueResolver:\n GITLAB_CI = os.getenv('GITLAB_CI') == 'true'\n+ BITBUCKET_CI = os.getenv('BITBUCKET_BUILD_NUMBER') is not None",
"line": null,
"original_line": 53,
"original_start_line": null,
"path": "openhands/resolver/issue_resolver.py",
... | a23b4c361ffe9a3947404005361d91221a82c012 | diff --git a/frontend/__tests__/components/features/home/repo-connector.test.tsx b/frontend/__tests__/components/features/home/repo-connector.test.tsx
index 6066ec43e5fa..afbf218c7941 100644
--- a/frontend/__tests__/components/features/home/repo-connector.test.tsx
+++ b/frontend/__tests__/components/features/home/repo-... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
keephq__keep-4600@c30367a | keephq/keep | Python | 4,600 | fix: dummy workflow per tenant | <!--
Thanks for creating this pull request 🤗
Please make sure that the pull request is limited to one type (docs, feature, etc.) and keep it as small as possible. You can open multiple prs instead of opening a huge one.
-->
<!-- If this pull request closes an issue, please mention the issue number below -->
... | 2025-04-21T09:24:58Z | [🐛 Bug]: system-test-workflow breaks tenant isolation
## Problem
To maintain FK contraints all workflow test runs assigned to `system-test-workflow` on `system-test-workflow` tenant. It breaks multi tenancy - two tenants will have dummy workflows on the same tenant.
## Solution
### Simpliest
For now, create dummy wo... | [
{
"body": "## Problem\nTo maintain FK contraints all workflow test runs assigned to `system-test-workflow` on `system-test-workflow` tenant. It breaks multi tenancy - two tenants will have dummy workflows on the same tenant.\n\n## Solution\n\n### Simpliest\nFor now, create dummy workflow `system-test-workflow` ... | 4cf963b0666b374905e5ad188aa9f603477bea64 | {
"head_commit": "c30367a631bea355d468e1b77474f0dce3c390e5",
"head_commit_message": "fix: delete deprecated dummy workflow in migration",
"patch_to_review": "diff --git a/keep-ui/features/workflows/test-run/ui/workflow-test-run-button.tsx b/keep-ui/features/workflows/test-run/ui/workflow-test-run-button.tsx\ninde... | [
{
"diff_hunk": "@@ -476,10 +477,31 @@ async def run_workflow_from_definition(\n workflow_dict = await get_workflow_dict_from_string(workflow_raw)\n workflowstore = WorkflowStore()\n workflowmanager = WorkflowManager.get_instance()\n+ workflow_id = workflow_dict.get(\"id\")\n+\n+ if workflow_id... | ec18cbe34859a28de8cdaf8fb2705b5850ccba36 | diff --git a/keep-ui/features/workflows/test-run/ui/workflow-test-run-button.tsx b/keep-ui/features/workflows/test-run/ui/workflow-test-run-button.tsx
index 09efb03d93..12e292fba5 100644
--- a/keep-ui/features/workflows/test-run/ui/workflow-test-run-button.tsx
+++ b/keep-ui/features/workflows/test-run/ui/workflow-test-... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} | |
keephq__keep-4588@2ec6b86 | keephq/keep | Python | 4,588 | fix: Handle race conditions when updating incidents in database | Add retry logic to manage race conditions caused by StaleDataError during incident updates. Ensures consistent database state by rolling back and retrying up to 3 times if a conflict occurs. Logs informative messages for better traceability of retries.
<!--
Thanks for creating this pull request 🤗
Please make s... | 2025-04-18T10:17:47Z | [🐛 Bug]: sqlalchemy.orm.exc.StaleDataError once again
```python
Traceback (most recent call last):
File "/venv/lib/python3.11/site-packages/keep/api/tasks/process_event_task.py", line 525, in __handle_formatted_events
incidents: List[IncidentDto] = rules_engine.run_rules(
^^^^^... | <!-- Answer -->
To address the `sqlalchemy.orm.exc.StaleDataError`, you can implement a retry mechanism. This involves attempting to update the incident status and commit the transaction. If a `StaleDataError` occurs, log the error, roll back the session, and retry the operation up to a specified number of times. Here'... | [
{
"body": "```python\nTraceback (most recent call last):\n File \"/venv/lib/python3.11/site-packages/keep/api/tasks/process_event_task.py\", line 525, in __handle_formatted_events\n incidents: List[IncidentDto] = rules_engine.run_rules(\n ^^^^^^^^^^^^^^^^^^^^^^^\n File \"/... | 567781de1dd815f65d47448099ae07d3d1f60421 | {
"head_commit": "2ec6b868a0be1d4bda5381b3d26ff13424de10f7",
"head_commit_message": "Handle race conditions when updating incidents in database\n\nAdd retry logic to manage race conditions caused by StaleDataError during incident updates. Ensures consistent database state by rolling back and retrying up to 3 times ... | [
{
"diff_hunk": "@@ -156,6 +157,23 @@ def _run_cel_rules(\n \n send_created_event = incident.is_visible\n \n+ incident_id = incident\n+ # Incident might change till this moment\n+ for attempt in range... | 25314a850a3a6165b91c6d845ecebd91c77b59ca | diff --git a/keep/rulesengine/rulesengine.py b/keep/rulesengine/rulesengine.py
index 7c90104d5f..e731bb389e 100644
--- a/keep/rulesengine/rulesengine.py
+++ b/keep/rulesengine/rulesengine.py
@@ -9,6 +9,7 @@
import celpy.celparser
import celpy.celtypes
import celpy.evaluation
+from sqlalchemy.orm.exc import StaleData... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
All-Hands-AI__OpenHands-8693@cae2261 | All-Hands-AI/OpenHands | Python | 8,693 | Fix Feedback Submission Retry | ## Problem
Users often encounter failures when submitting feedback for the first time, requiring a manual second click to successfully submit. This issue doesn't occur 100% of the time but happens frequently enough to impact user experience.
## Solution
1. Added automatic retry mechanism that attempts submission u... | 2025-05-25T08:35:39Z | [Bug]: Submitting feedback sometimes does not work on first try
### Is there an existing issue for the same bug? (If one exists, thumbs up or comment on the issue instead).
- [x] I have checked the existing issues.
### Describe the bug and reproduction steps
* Use a simple prompt like "Create a hello world script in... | [
{
"body": "### Is there an existing issue for the same bug? (If one exists, thumbs up or comment on the issue instead).\n\n- [x] I have checked the existing issues.\n\n### Describe the bug and reproduction steps\n\n* Use a simple prompt like \"Create a hello world script in bash\"\n* Press thumbs up button\n* P... | 77cd05c33b1eb292c336db772b973920f5b9daf4 | {
"head_commit": "cae2261dec1a2d5c6a676a29d8d76b3dc7c6f9fa",
"head_commit_message": "fix: 修复提交反馈首次尝试失败问题 (#8637)",
"patch_to_review": "diff --git a/README_CN.md b/README_CN.md\nnew file mode 100644\nindex 000000000000..df43b9c1739c\n--- /dev/null\n+++ b/README_CN.md\n@@ -0,0 +1,146 @@\n+\n+<a name=\"readme-top\">... | [
{
"diff_hunk": "",
"line": null,
"original_line": null,
"original_start_line": null,
"path": "frontend/src/hooks/mutation/use-submit-feedback.ts",
"start_line": null,
"text": "@user1:\nTanStack mutation hooks have a `retry` and `retryDelay` option that should be used instead of implement... | d242838d973ec72d61175956900c8b2cdb6be549 | diff --git a/README_CN.md b/README_CN.md
new file mode 100644
index 000000000000..df43b9c1739c
--- /dev/null
+++ b/README_CN.md
@@ -0,0 +1,146 @@
+
+<a name="readme-top"></a>
+
+<div align="center">
+ <img src="./docs/static/img/logo.png" alt="Logo" width="200">
+ <h1 align="center">OpenHands: 少写代码，多做事</h1>
+</div>
+... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
keephq__keep-4568@aaa03de | keephq/keep | Python | 4,568 | feat: batch alerts enrichment using cel | Closes #4567
## 📑 Description
Implement a new endpoint that allows users to enrich multiple alerts at once by specifying a CEL (Common Expression Language) query instead of listing individual alert fingerprints.
## Usage
```bash
curl --location '127.0.0.1:8080/alerts/batch_enrich?dispose_on_new_alert=true... | 2025-04-17T04:48:18Z | [➕ Feature]: Batch Enrichment by CEL Expression
This is ChatGPT generated description
## Description
Implement a new endpoint that allows users to enrich multiple alerts at once by specifying a CEL (Common Expression Language) query instead of listing individual alert fingerprints.
## Use Cases
- Enrich alerts by att... | [
{
"body": "This is ChatGPT generated description\n\n## Description\nImplement a new endpoint that allows users to enrich multiple alerts at once by specifying a CEL (Common Expression Language) query instead of listing individual alert fingerprints.\n\n## Use Cases\n- Enrich alerts by attributes like severity o... | 7ef6766e111af9a10853f4fbb5ba13eb1bb27fc0 | {
"head_commit": "aaa03de40a1e7a624ed5b71385b462c779d64023",
"head_commit_message": "fix: revert generating openapi docs",
"patch_to_review": "diff --git a/keep/api/models/alert.py b/keep/api/models/alert.py\nindex 2203f59cef..5cdfc149ef 100644\n--- a/keep/api/models/alert.py\n+++ b/keep/api/models/alert.py\n@@ -... | [
{
"diff_hunk": "@@ -805,6 +804,78 @@ def batch_enrich_alerts(\n ):\n enrich_data.enrichments[\"status\"] = AlertStatus.SUPPRESSED.value\n \n+ if not enrich_data.fingerprints and not enrich_data.cel:\n+ raise HTTPException(\n+ status_code=400, detail=\"Either fingerprints or cel ... | 41bc0df1b5119fc77d601287b799be4c25bd3eba | diff --git a/keep/api/models/alert.py b/keep/api/models/alert.py
index 2203f59cef..c2c950c4a3 100644
--- a/keep/api/models/alert.py
+++ b/keep/api/models/alert.py
@@ -367,7 +367,8 @@ class EnrichAlertRequestBody(BaseModel):
class BatchEnrichAlertRequestBody(BaseModel):
enrichments: dict[str, str]
- fingerpri... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
All-Hands-AI__OpenHands-8558@d71054a | All-Hands-AI/OpenHands | Python | 8,558 | Fix Cloud documentation structure and consolidate issue resolver information | This PR addresses issue #8557 by improving the OpenHands Cloud documentation structure:
- Fixed broken image in Cloud UI page by adding a placeholder for future update
- Removed duplicated UI Features section from Cloud UI page and added link to Key Features
- Consolidated GitHub and GitLab resolver usage information ... | 2025-05-17T17:44:13Z | Docs for OpenHands Cloud are Not Clear
**What problem or use case are you trying to solve?**
The documentation for the Open Hands cloud does not clearly demonstrate the usage flow.
**Describe the UX or technical implementation you have in mind**
Within the front page of the OpenHands cloud, it should demonstrate how... | I'm on it! neubig can [track my progress at all-hands.dev](https://app.all-hands.dev/conversations/9ee9dc3a3a0d4e07ae2292a3036e0ec1)
I've successfully addressed issue #8557 by improving the OpenHands Cloud documentation structure. Here's a summary of the changes made:
1. Created separate documentation pages:
- Main... | [
{
"body": "**What problem or use case are you trying to solve?**\n\nThe documentation for the Open Hands cloud does not clearly demonstrate the usage flow.\n\n**Describe the UX or technical implementation you have in mind**\n\nWithin the front page of the OpenHands cloud, it should demonstrate how to step throu... | 27c18f5bdd83cb6d46f5c74fe2c6932336d2f780 | {
"head_commit": "d71054ae1c447235a00e476768c565e6853d6db2",
"head_commit_message": "Translate cloud documentation to all supported languages (fr, ja, pt-BR, zh-Hans)",
"patch_to_review": "diff --git a/.github/workflows/py-unit-tests.yml b/.github/workflows/py-unit-tests.yml\nindex 0e722a1e3631..2221612257d2 1006... | [
{
"diff_hunk": "",
"line": null,
"original_line": null,
"original_start_line": null,
"path": "docs/i18n/fr/docusaurus-plugin-content-docs/current/usage/key-features.md",
"start_line": null,
"text": "@user1:\nSeems strange, a /fr page was changed to English?"
},
{
"diff_hunk": "@@... | 480d7dcbbf4f8544340e4bce742df868468239cf | diff --git a/docs/i18n/fr/docusaurus-plugin-content-docs/current/usage/cloud/cloud-github-resolver.md b/docs/i18n/fr/docusaurus-plugin-content-docs/current/usage/cloud/cloud-github-resolver.md
deleted file mode 100644
index c7ef460943b6..000000000000
--- a/docs/i18n/fr/docusaurus-plugin-content-docs/current/usage/cloud... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Documentation Updates"
} |
All-Hands-AI__OpenHands-8343@9d4e2af | All-Hands-AI/OpenHands | Python | 8,343 | Update pre-commit hook versions to most recent versions | This PR updates the pre-commit hook versions to the most recent versions and fixes related issues.
- Updated pre-commit-hooks from v4.5.0 to v5.0.0
- Updated pyproject-fmt from 1.7.0 to v2.5.1
- Updated validate-pyproject from v0.16 to v0.24.1
- Updated ruff-pre-commit from v0.4.1 to v0.11.8
- Updated mirrors-mypy fro... | 2025-05-08T00:00:23Z | Upgrade pre-commit-config.yaml versions to most recent versions
**What problem or use case are you trying to solve?**
The versions of the linting libraries that are included in pre-commit-config.yaml are very old, so we should upgrade them to the most recent version, and then run pre-commit over all files.
### If you... | I'm on it! neubig can [track my progress at all-hands.dev](https://app.all-hands.dev/conversations/c7223566cb0040d2a14dd8f2feddcb6d)
I've successfully fixed issue #8342 by updating the pre-commit hook versions to the most recent versions and addressing related issues. Here's a summary of what I did:
1. Updated all pre... | [
{
"body": "**What problem or use case are you trying to solve?**\n\nThe versions of the linting libraries that are included in pre-commit-config.yaml are very old, so we should upgrade them to the most recent version, and then run pre-commit over all files.\n\n### If you find this feature request or enhancement... | d5a8d4251cdd72f47cfae6f48756d128f7742bed | {
"head_commit": "9d4e2af7927b387f6a1cd3108ee72b63cab2aca9",
"head_commit_message": "Fix tests by updating logger.py to use 'severity' instead of 'level' and fixing test_cli.py assertions",
"patch_to_review": "diff --git a/.github/scripts/check_version_consistency.py b/.github/scripts/check_version_consistency.py... | [
{
"diff_hunk": "@@ -288,7 +288,12 @@ async def main(loop: asyncio.AbstractEventLoop):\n \n # Use settings from settings store if available and override with command line arguments\n if settings:\n- config.default_agent = args.agent_cls if args.agent_cls else settings.agent\n+ # Handle the ... | 7abdc5eb5766d424a2c79f7f404c59cc11e32320 | diff --git a/.github/scripts/check_version_consistency.py b/.github/scripts/check_version_consistency.py
index 828b583eb56d..fe4d77c2d270 100755
--- a/.github/scripts/check_version_consistency.py
+++ b/.github/scripts/check_version_consistency.py
@@ -2,10 +2,9 @@
import os
import re
import sys
-from typing import Se... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Dependency Updates & Env Compatibility"
} |
All-Hands-AI__OpenHands-8198@bfad32c | All-Hands-AI/OpenHands | Python | 8,198 | Fix issue #8197: Add unit tests for isLikelyDirectory | This pull request fixes #8197.
The issue has been successfully resolved. The requested task was to add unit tests for the isLikelyDirectory() function following existing project patterns, and this has been fully implemented:
1. A new test file path-component.test.tsx was created in the appropriate test directory
2. C... | 2025-05-01T07:14:08Z | Add unit tests for isLikelyDirectory
**What problem or use case are you trying to solve?**
Find the tests we have for path-component.tsx and familiarize yourself with how we unit test frontend code.
Then add unit tests for isLikelyDirectory().
Please make sure to follow the patterns in the project. | [OpenHands](https://github.com/All-Hands-AI/OpenHands) started fixing the issue! You can monitor the progress [here](https://github.com/All-Hands-AI/OpenHands/actions/runs/14771490266). | [
{
"body": "**What problem or use case are you trying to solve?**\n\nFind the tests we have for path-component.tsx and familiarize yourself with how we unit test frontend code.\n\nThen add unit tests for isLikelyDirectory().\n\nPlease make sure to follow the patterns in the project.\n\n",
"number": 8197,
... | e5f25726c0e414f118c6fdecdf2368d1502d2b86 | {
"head_commit": "bfad32cbcfd4447e1696d686a53147b4d6cc4e72",
"head_commit_message": "Fix pr #8198: Fix issue #8197: Add unit tests for isLikelyDirectory",
"patch_to_review": "diff --git a/frontend/__tests__/components/features/chat/path-component.test.tsx b/frontend/__tests__/components/features/chat/path-compone... | [
{
"diff_hunk": "@@ -23,8 +23,9 @@ const isLikelyDirectory = (path: string): boolean => {\n if (path.endsWith(\"/\") || path.endsWith(\"\\\\\")) return true;\n // Check if path has no extension (simple heuristic)\n const lastPart = path.split(/[/\\\\]/).pop() || \"\";\n- // If the last part has no dots or... | 5525e8797cd7d797469881f046e39b36863a7389 | diff --git a/frontend/__tests__/components/features/chat/path-component.test.tsx b/frontend/__tests__/components/features/chat/path-component.test.tsx
new file mode 100644
index 000000000000..90ee0e66e6ce
--- /dev/null
+++ b/frontend/__tests__/components/features/chat/path-component.test.tsx
@@ -0,0 +1,34 @@
+import { ... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Test Suite / CI Enhancements"
} |
All-Hands-AI__OpenHands-8216@a8b8142 | All-Hands-AI/OpenHands | Python | 8,216 | feat(resolver): Support for User-Defined Runners | - [x] This change is worth documenting at https://docs.all-hands.dev/
- [x] Include this change in the Release Notes. If checked, you **must** provide an **end-user friendly** description for your change below
**End-user friendly description of the problem this fixes or functionality that this introduces.**
It e... | 2025-05-02T01:57:12Z | Enhance Workflow Flexibility with Support for User-Defined Runners
**What problem or use case are you trying to solve?**
Right now, the OpenHands resolver workflow have the runs-on locked to ubuntu-latest.
In my setup, for example, I’m running gh runners inside a Kubernetes cluster. These runners are already configur... | [
{
"body": "**What problem or use case are you trying to solve?**\n\nRight now, the OpenHands resolver workflow have the runs-on locked to ubuntu-latest.\n\nIn my setup, for example, I’m running gh runners inside a Kubernetes cluster. These runners are already configured with access to private container registri... | 976019ce11e7113b8c11fefe5a3a49c335bfb3af | {
"head_commit": "a8b81420cbf6f2aca5193d74eb521b05d737019b",
"head_commit_message": "Merge branch 'main' into feat/config-resolver-runners",
"patch_to_review": "diff --git a/.github/workflows/openhands-resolver.yml b/.github/workflows/openhands-resolver.yml\nindex 0b89031fcb4f..f34e49bc6d3e 100644\n--- a/.github/... | [
{
"diff_hunk": "@@ -26,6 +26,7 @@ jobs:\n base_container_image: ${{ vars.OPENHANDS_BASE_CONTAINER_IMAGE || '' }}\n LLM_MODEL: ${{ vars.LLM_MODEL || 'anthropic/claude-3-5-sonnet-20241022' }}\n target_branch: ${{ vars.TARGET_BRANCH || 'main' }}\n+ runner: ${{ vars.TARGET_RUNNER || '' }}",
... | 62eb170930e0a4f7916d21e6581b892bfa70fdbf | diff --git a/.github/workflows/openhands-resolver.yml b/.github/workflows/openhands-resolver.yml
index 0b89031fcb4f..f34e49bc6d3e 100644
--- a/.github/workflows/openhands-resolver.yml
+++ b/.github/workflows/openhands-resolver.yml
@@ -34,6 +34,10 @@ on:
type: string
default: ""
description: "... | {
"difficulty": "medium",
"estimated_review_effort": 2,
"problem_domain": "New Feature Additions"
} | |
keephq__keep-4451@a72f6d4 | keephq/keep | Python | 4,451 | feat: workflow versioning | <!--
Thanks for creating this pull request 🤗
Please make sure that the pull request is limited to one type (docs, feature, etc.) and keep it as small as possible. You can open multiple prs instead of opening a huge one.
-->
<!-- If this pull request closes an issue, please mention the issue number below -->
... | 2025-04-08T07:09:45Z | [➕ Feature]: workflow versioning
first stage proposal:
1. add revision to the primary key constraint
2. for each new revision create new row in workflow table with incremented revision and same id
3. in api, return latest revision for id
4. add endpoints to get revisions, e.g. `/workflows/{id}/revision/{revision}` | [
{
"body": "first stage proposal:\n1. add revision to the primary key constraint\n2. for each new revision create new row in workflow table with incremented revision and same id\n3. in api, return latest revision for id\n4. add endpoints to get revisions, e.g. `/workflows/{id}/revision/{revision}`",
"number... | dc42c262c2fe82ac0fea8b77e6343783fc5fdf4f | {
"head_commit": "a72f6d4c36e19b7676b6e583ad4aa2285fdf76bd",
"head_commit_message": "wip: workflowversion table",
"patch_to_review": "diff --git a/keep-ui/app/(keep)/extraction/[rule_id]/executions/[execution_id]/page.tsx b/keep-ui/app/(keep)/extraction/[rule_id]/executions/[execution_id]/page.tsx\nindex 30414072... | [
{
"diff_hunk": "@@ -0,0 +1,179 @@\n+import {\n+ ClockIcon,\n+ CursorArrowRaysIcon,\n+ QuestionMarkCircleIcon,\n+} from \"@heroicons/react/24/outline\";\n+import Image from \"next/image\";\n+\n+const KeepIncidentIcon = () => (\n+ <Image\n+ src=\"/keep.png\"\n+ className=\"tremor-Badge-icon shrink-0 -ml... | 525f8ff5d8f2e3e627cad5a3ab1fced5ee465b43 | diff --git a/keep-ui/app/(keep)/extraction/[rule_id]/executions/[execution_id]/page.tsx b/keep-ui/app/(keep)/extraction/[rule_id]/executions/[execution_id]/page.tsx
index 304140729a..e110f40082 100644
--- a/keep-ui/app/(keep)/extraction/[rule_id]/executions/[execution_id]/page.tsx
+++ b/keep-ui/app/(keep)/extraction/[r... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
conan-io__conan-18485@0877a3a | conan-io/conan | Python | 18,485 | Removed ObjC/C++ flags from C/C++ ones | Changelog: Bugfix: Redirected Apple ARC flags to the ObjC/C++ ones.
Docs: omit
Closes: https://github.com/conan-io/conan/issues/18467
| 2025-06-18T08:34:46Z | [bug] ObjC ARC compile flag isn't passed to objc files when building with CMake+Ninja
### Describe the bug
I'm trying to build an ObjC library that requires ARC with CMake+Ninja. Adding `tools.apple:enable_arc=True` to the `[conf]` section doesn't help - the `-fobjc-arc` flag isn't passed when compiling objc files. In... | Hi @kambala-decapitator
> tc.variables["CMAKE_OBJC_FLAGS"] = "-fobjc-arc"
As a quick workaround, recall that you can inject CMake variables directly from command line or profiles, without modifying recipes with ``tools.cmake.cmaketoolchain:extra_variables`` conf.
> P.S. Gave the whole ARC thing a second thought. ... | [
{
"body": "### Describe the bug\n\nI'm trying to build an ObjC library that requires ARC with CMake+Ninja. Adding `tools.apple:enable_arc=True` to the `[conf]` section doesn't help - the `-fobjc-arc` flag isn't passed when compiling objc files. In the generated toolchain file I see that the flag is set only for... | 5cd5791c5811978e58e728d0bfdc945fb13db745 | {
"head_commit": "0877a3a5e0cca1297bb0964ef8e54744aa6297d5",
"head_commit_message": "wip",
"patch_to_review": "diff --git a/conan/tools/apple/apple.py b/conan/tools/apple/apple.py\nindex 8afda1ad23a..0e3d7efcebd 100644\n--- a/conan/tools/apple/apple.py\n+++ b/conan/tools/apple/apple.py\n@@ -334,20 +334,14 @@ def ... | [
{
"diff_hunk": "@@ -403,11 +403,18 @@ def _resolve_apple_flags_and_variables(self, build_env, compilers_by_conf):\n self.apple_isysroot_flag = isysroot_flag.split() if isysroot_flag else []\n self.apple_min_version_flag = [apple_min_version_flag(self._conanfile)]\n # Objective C/C++ ones... | 53580089f55c3f10643c7334ded2ed47849d5b62 | diff --git a/conan/tools/apple/apple.py b/conan/tools/apple/apple.py
index 8afda1ad23a..0e3d7efcebd 100644
--- a/conan/tools/apple/apple.py
+++ b/conan/tools/apple/apple.py
@@ -334,20 +334,14 @@ def apple_extra_flags(conanfile):
if not is_apple_os(conanfile):
return []
enable_bitcode = conanfile.conf... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
conan-io__conan-18429@ae7b1f0 | conan-io/conan | Python | 18,429 | [feature] Add generic config for CMake and Meson install strip | Hello!
This PR replaces the current config `tools.cmake:install_strip` with the generic `tools.install:strip`, so it can be used by both `CMake` and `Meson`. The `install_strip` is now marked as deprecated and will warn the user with a message.
Changelog: Feature: Replace `tools.cmake:install_strip` by `tools... | 2025-06-09T11:13:56Z | [feature] Meson Tool support specific args like '--strip' when install()
### What is your suggestion?
From meson 0.62, meson install support '--strip', but there are no way to pass it to conan's tools.Meson.
> --tags TAGS Install only targets having one of the
... | Thanks for the feedback @wsw0108
> do_strip = self._conanfile.conf.get("tools.cmake:install_strip", check_type=bool)
It seems that we would actually want to generalize this into a single ``tools.build:install_strip`` that would apply to different build systems. I'll check the possibility with the team.
the possible ... | [
{
"body": "### What is your suggestion?\n\nFrom meson 0.62, meson install support '--strip', but there are no way to pass it to conan's tools.Meson.\n> --tags TAGS Install only targets having one of the\n given tags. (Since 0.60.0)\n --strip ... | 7581c48609586a1984282f24e52ac65b48f23292 | {
"head_commit": "ae7b1f038dd007c4e29fb565290cc4e99b7afb26",
"head_commit_message": "Improve strip config description\n\nSigned-off-by: Uilian Ries <uilianries@gmail.com>",
"patch_to_review": "diff --git a/conan/internal/model/conf.py b/conan/internal/model/conf.py\nindex 044fda018b8..04dd8c87da6 100644\n--- a/co... | [
{
"diff_hunk": "@@ -209,7 +209,12 @@ def install(self, build_type=None, component=None, cli_args=None, stdout=None, s\n arg_list.extend([\"--component\", component])\n arg_list.extend(self._compilation_verbosity_arg)\n \n- do_strip = self._conanfile.conf.get(\"tools.cmake:install_stri... | 30dfd13f0ac7ed168fd6889ec6fc7eb663c78fb9 | diff --git a/conan/internal/model/conf.py b/conan/internal/model/conf.py
index 044fda018b8..8f186e28c19 100644
--- a/conan/internal/model/conf.py
+++ b/conan/internal/model/conf.py
@@ -86,7 +86,7 @@
"tools.cmake.cmake_layout:test_folder": "(Experimental) Allow configuring the base folder of the build for test_pack... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
conan-io__conan-18422@4b6ad32 | conan-io/conan | Python | 18,422 | fix in autotools win-clang and test for NMake with clang-cl | Changelog: Fix: Fix AutotoolsToolchain/GnuToolchain with LLVM/Clang in Windows for dynamic runtime in Debug.
Changelog: Fix: Test ``NMake`` integration with ``clang-cl``.
Docs: Omit
Close https://github.com/conan-io/conan/issues/17491 | 2025-06-06T07:00:38Z | [bug] NMake toolchain works with CLang-cl incorrectly
### Describe the bug
Hi! Thank you for your great project!
I faced with the following issue.
Context:
- Conan supports `CLang-cl` and knows how to set debug parameters for it (for example, `gline-tables-only` and `fno-inline`);
- Conan has `NMakeToolchain` ... | Hi @molotok-sms
> Hi! Thank you for your great project!
Thanks for your kind words!
Thanks for your report too.
I think this was addressed in https://github.com/conan-io/conan/pull/17387, which was released in latest Conan 2.10.
The way it works is it uses the ``tools.build:compiler_executables`` informat... | [
{
"body": "### Describe the bug\n\nHi! Thank you for your great project!\r\n\r\nI faced with the following issue.\r\n\r\nContext:\r\n- Conan supports `CLang-cl` and knows how to set debug parameters for it (for example, `gline-tables-only` and `fno-inline`);\r\n- Conan has `NMakeToolchain` and supports `NMake`;... | 048565de10232675955056fd41c9f3c4e5305eba | {
"head_commit": "4b6ad32bd37c81292016b2eaad56f204d21de6f9",
"head_commit_message": "fix tests",
"patch_to_review": "diff --git a/conan/tools/build/flags.py b/conan/tools/build/flags.py\nindex 98d068252ac..019eba51f63 100644\n--- a/conan/tools/build/flags.py\n+++ b/conan/tools/build/flags.py\n@@ -134,14 +134,15 @... | [
{
"diff_hunk": "@@ -9,6 +9,7 @@ def check_vs_runtime(artifact, client, vs_version, build_type, architecture=\"amd\n if not static:\n cmd = ('%s && dumpbin /nologo /dependents \"%s\"' % (vcvars, normalized_path))\n client.run_command(cmd)\n+ print(client.out)",
"line": null,
"o... | 476c8bd1c44587dcd75c9d08c8f1ff776be537e2 | diff --git a/conan/tools/build/flags.py b/conan/tools/build/flags.py
index 98d068252ac..019eba51f63 100644
--- a/conan/tools/build/flags.py
+++ b/conan/tools/build/flags.py
@@ -134,14 +134,15 @@ def build_type_flags(conanfile):
if not compiler or not build_type:
return []
- # https://github.com/Kitwa... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
conan-io__conan-18437@6ca798a | conan-io/conan | Python | 18,437 | Add support for sbom and lockfiles for conan audit list | Changelog: Feature: Add support for sbom and lockfiles to `conan audit list`.
Docs: https://github.com/conan-io/docs/pull/4134
Closes #18431
| 2025-06-10T08:20:38Z | Look into acepting SBOMs in conan audit
The two features are aimed at improving security, so it seems ideal that after a user has saved their sboms, that they can later query vulnerabilities from it without having to first pre-process it | I think this is a good feature to add to `conan audit list`, what about reading lockfiles as well?
> I think this is a good feature to add to conan audit list, what about reading lockfiles as well?
Should be easy as well, same for package lists? | [
{
"body": "The two features are aimed at improving security, so it seems ideal that after a user has saved their sboms, that they can later query vulnerabilities from it without having to first pre-process it",
"number": 18431,
"title": "Look into acepting SBOMs in conan audit"
}
] | 935c70047b0ed036aec95bf4e836060ae20df972 | {
"head_commit": "6ca798aa462b251a189a6b13fb1ab73ad5befd83",
"head_commit_message": "Add support for sbom and lockfiles for conan audit list",
"patch_to_review": "diff --git a/conan/cli/commands/audit.py b/conan/cli/commands/audit.py\nindex ddddad0297c..e0c2e72a3c3 100644\n--- a/conan/cli/commands/audit.py\n+++ b... | [
{
"diff_hunk": "@@ -108,18 +109,15 @@ def audit_list(conan_api: ConanAPI, parser, subparser, *args):\n \"\"\"\n List the vulnerabilities of the given reference.\n \"\"\"\n- subparser.add_argument(\"reference\", help=\"Reference to list vulnerabilities for\", nargs=\"?\")\n- subparser.add_argum... | 0212f40d1f211a96cb4bb07d51aad1d9bb326883 | diff --git a/conan/cli/commands/audit.py b/conan/cli/commands/audit.py
index ddddad0297c..9bbe1fff558 100644
--- a/conan/cli/commands/audit.py
+++ b/conan/cli/commands/audit.py
@@ -3,7 +3,7 @@
from conan.api.conan_api import ConanAPI
from conan.api.input import UserInput
-from conan.api.model import MultiPackagesLi... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
keephq__keep-3987@32636a2 | keephq/keep | Python | 3,987 | fix: Add migration to remove and prevent multiple enrichments per fingerprint | <!--
Thanks for creating this pull request 🤗
Please make sure that the pull request is limited to one type (docs, feature, etc.) and keep it as small as possible. You can open multiple prs instead of opening a huge one.
-->
<!-- If this pull request closes an issue, please mention the issue number below -->
... | 2025-03-12T08:42:57Z | [🐛 Bug]: Multiple enrichments per one alert_fingerprint in alertenrichment table
**Describe the bug**
This leads to unexpected results during Alerts querying
**Expected behavior**
One enrichment per fingerprint
**Screenshots**
If applicable, add screenshots to help explain your problem.
**Additional context**
We ne... | [
{
"body": "**Describe the bug**\nThis leads to unexpected results during Alerts querying\n\n**Expected behavior**\nOne enrichment per fingerprint\n\n**Screenshots**\nIf applicable, add screenshots to help explain your problem.\n\n**Additional context**\nWe need to have migration that removes duplicates from ale... | 202e9c71a2877ed5d103f5cfcc2dc46a601459d9 | {
"head_commit": "32636a210993703eac3cf3b4a163396ed3836797",
"head_commit_message": "Merge branch 'main' into investigate-ghost-alerts-problem",
"patch_to_review": "diff --git a/keep/api/models/db/migrations/versions/2025-03-11-16-54_16309df224d1.py b/keep/api/models/db/migrations/versions/2025-03-11-16-54_16309d... | [
{
"diff_hunk": "@@ -0,0 +1,193 @@\n+\"\"\"Add_unique_constraint_for_alert_fingerprint_and_tenant_id\n+\n+Revision ID: 16309df224d1\n+Revises: 0b80bda47ee2\n+Create Date: 2025-03-11 16:54:14.972144\n+\n+\"\"\"\n+\n+import sqlalchemy as sa\n+import sqlmodel\n+from alembic import op\n+\n+# revision identifiers, us... | 29d644d59ef54edd98a332c8ca0e755a6fa3c115 | diff --git a/keep/api/models/db/migrations/versions/2025-03-11-16-54_16309df224d1.py b/keep/api/models/db/migrations/versions/2025-03-11-16-54_16309df224d1.py
new file mode 100644
index 0000000000..622eb317b3
--- /dev/null
+++ b/keep/api/models/db/migrations/versions/2025-03-11-16-54_16309df224d1.py
@@ -0,0 +1,218 @@
+... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} | |
conan-io__conan-18333@91ac324 | conan-io/conan | Python | 18,333 | Add support for extra configure arguments | Changelog: Feature: Add `tools.gnu:configure_args` conf to GnuToolchain and Autotoolchain generator to allow extra arguments to be added to the configure command.
Docs: https://github.com/conan-io/docs/pull/4100
close #18256
- [x] Refer to the issue that supports this Pull Request.
- [x] If the issue has miss... | 2025-05-20T14:42:02Z | [feature] Extend configure args for AutotoolsToolchain
### What is your suggestion?
Hello!
The configuration `tools.cmake.cmaketoolchain:extra_variables` allows extending CMakeToolchain definitions without touching the conanfile.py. This option allows users to customize recipes without needing to open a PR and is eq... | Thanks for your suggestion @uilianries
While CMake is massively popular, and used as de-facto standard for new projects, Autotools is nowadays mostly for legacy gnu-like projects, so the same level of configurability and extensibility is not expected.
What was the use case? What real world scenario did you find? wit... | [
{
"body": "### What is your suggestion?\n\nHello! \n\nThe configuration `tools.cmake.cmaketoolchain:extra_variables` allows extending CMakeToolchain definitions without touching the conanfile.py. This option allows users to customize recipes without needing to open a PR and is equally beneficial to maintainers,... | 86e2822989b555778505c847fe92cc11e04cb853 | {
"head_commit": "91ac324e73d1f159270a2466e01b7175370d1843",
"head_commit_message": "Replace extra_configure_args by configure_args\n\nSigned-off-by: Uilian Ries <uilianries@gmail.com>",
"patch_to_review": "diff --git a/conan/internal/model/conf.py b/conan/internal/model/conf.py\nindex 0b4125bd108..979884de676 10... | [
{
"diff_hunk": "@@ -235,3 +235,24 @@ def test_crossbuild_to_android(build_env_mock):\n assert gnutc.triplets_info[\"host\"][\"triplet\"] == \"aarch64-linux-android\"\n assert env_vars[\"LD\"] == os.path.join(ndk_bin, \"ld\") # exists\n assert env_vars[\"STRIP\"] == os.path.join(ndk_bin, \"llvm-stri... | 53edfbf98a9667f3f288fb543feafc1867c80728 | diff --git a/conan/internal/model/conf.py b/conan/internal/model/conf.py
index 0b4125bd108..044fda018b8 100644
--- a/conan/internal/model/conf.py
+++ b/conan/internal/model/conf.py
@@ -101,6 +101,7 @@
"tools.gnu:pkg_config": "Path to pkg-config executable used by PkgConfig build helper",
"tools.gnu:build_trip... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
conan-io__conan-18390@6f74141 | conan-io/conan | Python | 18,390 | Feature: workspace create | Changelog: Feature: New ``conan workspace create`` orchestrated.
Changelog: Fix: Removed ``Workspaces`` product definition and make ``conan workspace build`` work computing the right build-order.
Docs: https://github.com/conan-io/docs/pull/4138
Close https://github.com/conan-io/conan/issues/18364
| 2025-05-30T17:00:13Z | [question] Conan workspaces CI
### What is your question?
Hello,
I have recently started using the workspaces as it fits my monorepo style project. I'd like to ask using the workspaces how can I automate the CI process in respect the packages and products. From what I understand when we declare new packages or product... | Hi @IYanakiev34
Thanks for your question (though I think it is actually a feature request too).
At the moment, the ``workspace`` implements the standard or "canonical" flow, in which the developers use the ``workspace`` to develop their code locally, but the creation of packages typically happens in CI. So developer... | [
{
"body": "### What is your question?\n\nHello,\nI have recently started using the workspaces as it fits my monorepo style project. I'd like to ask using the workspaces how can I automate the CI process in respect the packages and products. From what I understand when we declare new packages or products in the ... | 629d7d1e1caef06db55f628dadaaab482d0bb852 | {
"head_commit": "6f7414141f0baedfb0e9f804a7183d4fc338d671",
"head_commit_message": "test for conan workspace build too",
"patch_to_review": "diff --git a/conan/api/output.py b/conan/api/output.py\nindex cf291ec9875..535586c00cf 100644\n--- a/conan/api/output.py\n+++ b/conan/api/output.py\n@@ -175,6 +175,12 @@ de... | [
{
"diff_hunk": "@@ -282,3 +265,55 @@ def collapse_editables(self, deps_graph, profile_host, profile_build):\n result.add_edge(root, t.node, r)\n \n return result\n+\n+ def export(self, lockfile=None, remotes=None):\n+ self._check_ws()\n+ exported = []\n+ for ref, info... | 9b5e7aece7149769ec82366e8e73e950a1b019d2 | diff --git a/conan/api/output.py b/conan/api/output.py
index cf291ec9875..535586c00cf 100644
--- a/conan/api/output.py
+++ b/conan/api/output.py
@@ -175,6 +175,12 @@ def write(self, data, fg=None, bg=None, newline=False):
return self
+ def box(self, msg):
+ color = Color.BRIGHT_GREEN
+ sel... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "Test Suite / CI Enhancements"
} |
conan-io__conan-18290@b8abb8b | conan-io/conan | Python | 18,290 | Adding C standard detection | Changelog: Feature: Auto detection of C standard.
Docs: https://github.com/conan-io/docs/pull/4097
- [x] Close https://github.com/conan-io/conan/issues/18281
- [x] I've read the [Contributing guide](https://github.com/conan-io/conan/blob/develop2/.github/CONTRIBUTING.md).
- [x] I've followed the PEP8 style guides... | 2025-05-12T09:48:06Z | [feature] Add C standard version into `detect_api`
### What is your suggestion?
Since GCC 15 switched the default C standard to C23, some of our recipes have broken. It would be helpful to have the ability to detect the C standard via detect_api, as certain patches need to be applied conditionally.
### Have you read ... | Hi @shtanko-sv
Thanks for the suggestion.
The ``detect_api`` doesn't really have a "detect" c++std capability, but a ``default_cppstd(compiler, compiler_version)`` one, which means it is basically a hardcoded mapping of compiler versions.
I guess you would like a similar ``detect.default_cstd()`` method? It sounds ... | [
{
"body": "### What is your suggestion?\n\nSince GCC 15 switched the default C standard to C23, some of our recipes have broken. It would be helpful to have the ability to detect the C standard via detect_api, as certain patches need to be applied conditionally.\n\n### Have you read the CONTRIBUTING guide?\n\n-... | f8d26127baabcf76a651739bb40b5415d3fe65a6 | {
"head_commit": "b8abb8b12b29efd821d3d3a6c3dcd8dc27e4fc6b",
"head_commit_message": "Remove cstd from default generated profiles\n\nCo-authored-by: Abril Rincón Blanco <5364255+AbrilRBS@users.noreply.github.com>",
"patch_to_review": "diff --git a/conan/internal/api/detect/detect_api.py b/conan/internal/api/detect... | [
{
"diff_hunk": "@@ -347,6 +347,54 @@ def detect_cppstd(compiler, compiler_version):\n return cppstd\n \n \n+def default_cstd(compiler, compiler_version):\n+ \"\"\"returns the default cstd for the compiler-version. This is not detected, just the default\"\"\"\n+\n+ def _clang_cstd_default(version):\n+ ... | 349654e06d71889e8d6047c471242ee55137b85d | diff --git a/conan/internal/api/detect/detect_api.py b/conan/internal/api/detect/detect_api.py
index 6b7cbfb58b8..0f96ebcb24c 100644
--- a/conan/internal/api/detect/detect_api.py
+++ b/conan/internal/api/detect/detect_api.py
@@ -347,6 +347,55 @@ def detect_cppstd(compiler, compiler_version):
return cppstd
+def... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
conan-io__conan-18153@6c8a8f1 | conan-io/conan | Python | 18,153 | Raise an error if LocalRecipesIndex user/channel doesn't match requested one | Changelog: Bugfix: Raise a not-found error if "local recipes index" ``user/channel`` doesn't match requested one.
Docs: Omit
Close https://github.com/conan-io/conan/issues/18142
| 2025-04-21T11:49:46Z | [question] Getting Package not resolved Reference already exists errors
### What is your question?
Hello all,
i have a local recipes repository which contains some basic recipes for libraries. When executing **conan install --requires=libname/3.1.1@external/release -s build_type=Debug -s arch=x86_64 -s compiler.versi... | Hi @ibrawada, thanks for opening this issue.
When you say you have a local recipes repository, do you mean a [local recipes index](https://docs.conan.io/2/tutorial/conan_repositories/setup_local_recipes_index.html)? Or a Conan remote (e.g. Artifactory) that is local to you?
Before invoking the `conan install` command... | [
{
"body": "### What is your question?\n\nHello all,\n\ni have a local recipes repository which contains some basic recipes for libraries. When executing **conan install --requires=libname/3.1.1@external/release -s build_type=Debug -s arch=x86_64 -s compiler.version=193 --build missing** twice in a row on the s... | b8aad0d032315f0d6317f7cf570bb65083f0c973 | {
"head_commit": "6c8a8f1b99ec606755eb59be9a27083f9c15e4e6",
"head_commit_message": "raise an error if LocalRecipesIndex user/channel doesn't match requested one",
"patch_to_review": "diff --git a/conans/client/rest_client_local_recipe_index.py b/conans/client/rest_client_local_recipe_index.py\nindex 3a4e65d1d92.... | [
{
"diff_hunk": "@@ -162,6 +162,8 @@ def _export_recipe(self, ref):\n sys.stderr = original_stderr\n ConanOutput(scope=\"local-recipes-index\").debug(f\"Internal export for {ref}:\\n\"\n f\"{textwrap.indent(export_err, ' ')}\")... | 0427c4abd58b7fbd9a2e5eba46bf885cbf9b027c | diff --git a/conans/client/rest_client_local_recipe_index.py b/conans/client/rest_client_local_recipe_index.py
index 3a4e65d1d92..a5f896defcd 100644
--- a/conans/client/rest_client_local_recipe_index.py
+++ b/conans/client/rest_client_local_recipe_index.py
@@ -134,11 +134,6 @@ def get_latest_package_reference(self, pre... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Dependency Updates & Env Compatibility"
} |
conan-io__conan-18037@830ab08 | conan-io/conan | Python | 18,037 | Improve error messages when parsing JSON input files | Changelog: Feature: Improve error messages when dealing with incorrect JSON input file formats.
Docs: omit
Close https://github.com/conan-io/conan/issues/17882
- [x] Refer to the issue that supports this Pull Request.
- [x] If the issue has missing info, explain the purpose/use case/pain/need that covers this P... | 2025-03-28T11:51:25Z | Improve error messages when provided wrong json
- Package-lists and graph json files are used by users incorrectly as inputs
- The error messages are not that clear, it would be nice if possible to say: "This json file should be a pkg-list, but it seems you provided a file that is not a package list. It seems to be a g... | [
{
"body": "- Package-lists and graph json files are used by users incorrectly as inputs\n- The error messages are not that clear, it would be nice if possible to say: \"This json file should be a pkg-list, but it seems you provided a file that is not a package list. It seems to be a graph.json file\"\n- For som... | 1f112d48a2829dd8f274275bb1a5cc0a11379f62 | {
"head_commit": "830ab08a1d114ffca59c06c32581fdbc73bbc0d7",
"head_commit_message": "Restore absolute paths in API",
"patch_to_review": "diff --git a/conan/api/model/list.py b/conan/api/model/list.py\nindex 520d221faa3..7ad45c288df 100644\n--- a/conan/api/model/list.py\n+++ b/conan/api/model/list.py\n@@ -4,6 +4,7... | [
{
"diff_hunk": "@@ -65,22 +73,30 @@ def load_graph(graphfile, graph_recipes=None, graph_binaries=None, context=None)\n try:\n base_context = context.split(\"-\")[0] if context else None\n graph = json.loads(load(graphfile))\n- mpkglist = MultiPackagesList._define_grap... | 5adb5464fcb7037dbe201a6d8133e8f0b6057489 | diff --git a/conan/api/model/list.py b/conan/api/model/list.py
index 520d221faa3..8351654975f 100644
--- a/conan/api/model/list.py
+++ b/conan/api/model/list.py
@@ -4,6 +4,7 @@
from json import JSONDecodeError
from conan.api.model import RecipeReference, PkgReference
+from conan.cli import make_abs_path
from conan... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
All-Hands-AI__OpenHands-7082@766d4db | All-Hands-AI/OpenHands | Python | 7,082 | Expose accumulate and llm_metric from eventstream to frontend (backend only) | - [ ] This change is worth documenting at https://docs.all-hands.dev/
- [ ] Include this change in the Release Notes. If checked, you **must** provide an **end-user friendly** description for your change below
**Give a summary of what the PR does, explaining any non-trivial design decisions.**
This is part of the ... | 2025-03-03T18:17:49Z | Display API costs in frontend
**What problem or use case are you trying to solve?**
Direct communication from a user:
> the unknown API costs are a fairly intimidating part of the current user experience. I tried running a relatively simple query and wasn’t sure if it was going to cost 1 cent or 10 dollars (it en... | [OpenHands](https://github.com/All-Hands-AI/OpenHands) started fixing the issue! You can monitor the progress [here](https://github.com/All-Hands-AI/OpenHands/actions/runs/12011697935).
An attempt was made to automatically fix this issue, but it was unsuccessful. A branch named 'openhands-fix-issue-5257' has been creat... | [
{
"body": "**What problem or use case are you trying to solve?**\r\n\r\nDirect communication from a user:\r\n\r\n> the unknown API costs are a fairly intimidating part of the current user experience. I tried running a relatively simple query and wasn’t sure if it was going to cost 1 cent or 10 dollars (it ended... | f51eb93d3ea92231e72247266df6df2d024db826 | {
"head_commit": "766d4dbb72fee980aae423039c380e8bfed33bba",
"head_commit_message": "refactor",
"patch_to_review": "diff --git a/openhands/controller/agent_controller.py b/openhands/controller/agent_controller.py\nindex 59f17804de80..323d2dd8a098 100644\n--- a/openhands/controller/agent_controller.py\n+++ b/openh... | [
{
"diff_hunk": "@@ -1086,6 +1091,44 @@ def _is_stuck(self) -> bool:\n \n return self._stuck_detector.is_stuck(self.headless_mode)\n \n+ def _prepare_metrics_for_frontend(self, action: Action) -> None:\n+ \"\"\"Create a minimal metrics object for frontend display and log it.\n+\n+ To avo... | b029c62a82f52956a7fd41e9f83680cdb230940a | diff --git a/openhands/controller/agent_controller.py b/openhands/controller/agent_controller.py
index 59f17804de80..61bebacfc908 100644
--- a/openhands/controller/agent_controller.py
+++ b/openhands/controller/agent_controller.py
@@ -53,6 +53,7 @@
)
from openhands.events.serialization.event import event_to_trajector... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
All-Hands-AI__OpenHands-7002@2f9cc20 | All-Hands-AI/OpenHands | Python | 7,002 | [agent] improve finish tool for sonnet 3.7 | - [ ] This change is worth documenting at https://docs.all-hands.dev/
- [ ] Include this change in the Release Notes. If checked, you **must** provide an **end-user friendly** description for your change below
**End-user friendly description of the problem this fixes or functionality that this introduces.**
Impr... | 2025-02-27T17:13:40Z | [Bug]: The LLM doesn't understand the Finish tool very well
### Is there an existing issue for the same bug?
- [x] I have checked the existing issues.
### Describe the bug and reproduction steps
Looking at trajectories, specially on evals, but also on those in the resolver I think, I seem to see too often that when ... | This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days. | [
{
"body": "### Is there an existing issue for the same bug?\n\n- [x] I have checked the existing issues.\n\n### Describe the bug and reproduction steps\n\nLooking at trajectories, specially on evals, but also on those in the resolver I think, I seem to see too often that when the LLM is happy with the job, it s... | 42332294a13829ac9385feb35bfe4bbdb288e6b6 | {
"head_commit": "2f9cc20629375d474858f2cd41779c04ed956265",
"head_commit_message": "fix logging error: --- Logging error ---\nTraceback (most recent call last):\n File \"/home/xingyaow/OpenHands-dev/evaluation/utils/shared.py\", line 323, in _process_instance_wrapper\n result = process_instance_func(instance, ... | [
{
"diff_hunk": "@@ -108,7 +108,10 @@ def response_to_actions(response: ModelResponse) -> list[Action]:\n # AgentFinishAction\n # ================================================\n elif tool_call.function.name == FinishTool['function']['name']:\n- action = Agent... | cd7bcc37f0ab72f69adde26ead46062869537a58 | diff --git a/frontend/src/services/actions.ts b/frontend/src/services/actions.ts
index d6702aad088f..485c807dd0dc 100644
--- a/frontend/src/services/actions.ts
+++ b/frontend/src/services/actions.ts
@@ -57,6 +57,28 @@ const messageActions = {
store.dispatch(appendJupyterInput(message.args.code));
}
},
+ ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
All-Hands-AI__OpenHands-8139@cb09940 | All-Hands-AI/OpenHands | Python | 8,139 | Add back microagent files with special handling for user inputs | - [x] This change is worth documenting at https://docs.all-hands.dev/
- [x] Include this change in the Release Notes. If checked, you **must** provide an **end-user friendly** description for your change below
**End-user friendly description of the problem this fixes or functionality this introduces.**
This PR adds m... | 2025-04-29T01:33:48Z | [Feature]: Add input-based micro-agents to support template workflows
**What problem or use case are you trying to solve?**
We need to extend micro-agents to support template-based workflows. Currently, micro-agents are triggered by keywords and inject specialized knowledge (e.g., GitHub API understanding). However, us... | This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.
This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.
This issue is stale because it has been op... | [
{
"body": "**What problem or use case are you trying to solve?**\nWe need to extend micro-agents to support template-based workflows. Currently, micro-agents are triggered by keywords and inject specialized knowledge (e.g., GitHub API understanding). However, users often find themselves repeatedly typing simila... | 46c12ce2586c49a7b83a051095c4944d911fe949 | {
"head_commit": "cb0994027f808fe3a26aac679f8d1714bc40a9d2",
"head_commit_message": "🤖 Auto-fix Python linting issues",
"patch_to_review": "diff --git a/microagents/add_openhands_repo_instruction.md b/microagents/add_openhands_repo_instruction.md\nnew file mode 100644\nindex 000000000000..c016af84e96a\n--- /dev/... | [
{
"diff_hunk": "@@ -0,0 +1,23 @@\n+---\n+name: update_pr_description\n+version: 1.0.0\n+author: openhands\n+agent: CodeActAgent\n+triggers:\n+- /update_pr",
"line": null,
"original_line": 7,
"original_start_line": null,
"path": "microagents/update_pr_description.md",
"start_line": null,
... | 58845b01a327ac6fd88e42c71016deac074f3858 | diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS
index 668e9837b93e..af869ec229a3 100644
--- a/.github/CODEOWNERS
+++ b/.github/CODEOWNERS
@@ -5,7 +5,7 @@
/frontend/ @rbren @amanape
# Evaluation code owners
-/evaluation/ @xingyaoww @neubig
+/evaluation/ @xingyaoww @neubig
# Documentation code owners
/docs/... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
keephq__keep-3740@39b6fae | keephq/keep | Python | 3,740 | feat: Filtering/search workflows | <!--
Thanks for creating this pull request 🤗
Please make sure that the pull request is limited to one type (docs, feature, etc.) and keep it as small as possible. You can open multiple prs instead of opening a huge one.
-->
<!-- If this pull request closes an issue, please mention the issue number below -->
... | 2025-02-27T14:02:50Z | [➕ Feature]: Filtering / search / sort workflows
Customer is heading towards having many workflows & they need tooling to manage them at high scale. They need to:
- Search by Workflows (Minimal: by name. Nice to have: by description as well)
- Sort or filter by last successful or failed execution
- Filter disabled/enab... | [
{
"body": "Customer is heading towards having many workflows & they need tooling to manage them at high scale. They need to:\n- Search by Workflows (Minimal: by name. Nice to have: by description as well)\n- Sort or filter by last successful or failed execution\n- Filter disabled/enabled workflows\n\nCustomer d... | e75cd6dc422f16b61db6bd8a6aec146c61bb42d9 | {
"head_commit": "39b6faec42dccab9733dc93911be9b674b8fb12b",
"head_commit_message": "Merge branch 'main' into 3624-Filtering_search_sort-workflows\n\nSigned-off-by: Ihor Panasiuk <igorskynet13@gmail.com>",
"patch_to_review": "diff --git a/keep-ui/app/(keep)/workflows/page.tsx b/keep-ui/app/(keep)/workflows/page.t... | [
{
"diff_hunk": "@@ -15,11 +22,26 @@ import Modal from \"@/components/ui/Modal\";\n import { WorkflowTemplates } from \"./mockworkflows\";\n import { useApi } from \"@/shared/lib/hooks/useApi\";\n import { Input, ErrorComponent } from \"@/shared/ui\";\n-import { Textarea } from \"@/components/ui\";\n-import { us... | 61e7a30f41ac74dff2e15162a66b9dc2b20c24f3 | diff --git a/keep-ui/app/(keep)/workflows/page.tsx b/keep-ui/app/(keep)/workflows/page.tsx
index 25f9fce6e9..7776022a59 100644
--- a/keep-ui/app/(keep)/workflows/page.tsx
+++ b/keep-ui/app/(keep)/workflows/page.tsx
@@ -1,8 +1,27 @@
import React from "react";
import WorkflowsPage from "./workflows.client";
+import { F... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
conan-io__conan-17940@ee4dd17 | conan-io/conan | Python | 17,940 | improve jinja2 failure error messages | Changelog: Fix: Improve error message when ``jinja2`` profile rendering fails due to unexpected syntax.
Docs: Omit
Close https://github.com/conan-io/conan/issues/17932 | 2025-03-11T19:11:10Z | [bug] unclear message about error in profile
### Describe the bug
macOS, Conan 2.13, Python 3.13
I have a chain of profiles that are included in one another, one of the base profiles uses Jinja features (variables, comments). Looks like I made a mistake in one of Jinja expressions, but Conan's error doesn't help me t... | Thanks for your feedback @kambala-decapitator
Could you please provide a ``common`` profile file that triggers that error? (I guess the rest should be relatively easy to replicate, just with profiles with ``include(ios) -> include(apple) -> include(common)`` isn't it?
> (I guess the rest should be relatively easy to ... | [
{
"body": "### Describe the bug\n\nmacOS, Conan 2.13, Python 3.13\n\nI have a chain of profiles that are included in one another, one of the base profiles uses Jinja features (variables, comments). Looks like I made a mistake in one of Jinja expressions, but Conan's error doesn't help me tracking it down at all... | 9f44e5836cfa441e2b6b5134c53ab87e52fbdd2f | {
"head_commit": "ee4dd1792539fffa14a975d9b4328ad9d74a2a89",
"head_commit_message": "improve jinja2 failure error messages",
"patch_to_review": "diff --git a/conan/__init__.py b/conan/__init__.py\nindex 64d0beef500..f889dbda6f2 100644\n--- a/conan/__init__.py\n+++ b/conan/__init__.py\n@@ -2,5 +2,5 @@\n from conan... | [
{
"diff_hunk": "@@ -2,5 +2,5 @@\n from conan.internal.model.workspace import Workspace\n from conan.internal.model.version import Version\n \n-__version__ = '2.14.0-dev'\n+__version__ = '2.15.0-dev'",
"line": null,
"original_line": 5,
"original_start_line": null,
"path": "conan/__init__.py",
... | 186c527dadfa031d26d4ab997b86dce41356af16 | diff --git a/conan/internal/api/profile/profile_loader.py b/conan/internal/api/profile/profile_loader.py
index 5ed77b1f17a..ddc19bb6486 100644
--- a/conan/internal/api/profile/profile_loader.py
+++ b/conan/internal/api/profile/profile_loader.py
@@ -126,9 +126,9 @@ def _load_profile(self, profile_name, cwd):
# ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
All-Hands-AI__OpenHands-7125@d4b7fc0 | All-Hands-AI/OpenHands | Python | 7,125 | [Feat]: Gitlab p2 - let user add PAT via FE | - [x] This change is worth documenting at https://docs.all-hands.dev/
- [x] Include this change in the Release Notes. If checked, you **must** provide an **end-user friendly** description for your change below
**End-user friendly description of the problem this fixes or functionality that this introduces.**
- User... | 2025-03-06T04:00:08Z | Support GitLab PAT
**What problem or use case are you trying to solve?**
We should support GitLab PAT in Openhands (for auth, repository lists, etc)
**Describe the UX of the solution you'd like**
Use the same PAT field in the settings page; it should accept either a Github or Gitlab token to auth the user in
**Do you... | I am awaiting the completion of this task, which enables the development of support for other Git providers, such as Azure DevOps and/or AWS CodeCommit.
> I am awaiting the completion of this task, which enables the development of support for other Git providers, such as Azure DevOps and/or AWS CodeCommit.
I'm using A... | [
{
"body": "**What problem or use case are you trying to solve?**\nWe should support GitLab PAT in Openhands (for auth, repository lists, etc)\n\n**Describe the UX of the solution you'd like**\nUse the same PAT field in the settings page; it should accept either a Github or Gitlab token to auth the user in\n\n**... | 648c8ffb212d421baed03bc03ebbbc15509ea9f4 | {
"head_commit": "d4b7fc0b674444b293a1a15ac598f6f29498f242",
"head_commit_message": "fix merge overrwrites",
"patch_to_review": "diff --git a/frontend/__tests__/routes/settings.test.tsx b/frontend/__tests__/routes/settings.test.tsx\nindex f06c22839022..4ce0bfb818bb 100644\n--- a/frontend/__tests__/routes/settings... | [
{
"diff_hunk": "@@ -97,7 +97,7 @@ async def get_github_user(\n )\n \n return JSONResponse(\n- content='GitHub token required.',\n+ content='Git token required.',",
"line": null,
"original_line": 100,
"original_start_line": null,
"path": "openhands/server/routes/gith... | 0126b6f8235e99518f153f5874424e0db32b7d57 | diff --git a/frontend/__tests__/components/chat/action-suggestions.test.tsx b/frontend/__tests__/components/chat/action-suggestions.test.tsx
index ccc2eb1e813b..186a0e8ce470 100644
--- a/frontend/__tests__/components/chat/action-suggestions.test.tsx
+++ b/frontend/__tests__/components/chat/action-suggestions.test.tsx
@... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
All-Hands-AI__OpenHands-6898@0ea83ba | All-Hands-AI/OpenHands | Python | 6,898 | Display session ID in CLI mode | This PR adds the session ID to the CLI output at startup, as requested in issue #6417. This helps users to easily identify their session ID when using the CLI.
Fix #6417
---
To run this PR locally, use the following command:
```
docker run -it --rm -p 3000:3000 -v /var/run/docker.sock:/var/run/docker.sock -... | 2025-02-23T09:39:21Z | [Feature] Printing the Session ID for CLI Mode at the start
Within the GUI its really easy to know the session-id as its in the url.
Unfortunately this information is not available to the user in CLI Mode. Knowing the session is critical to then be able to access the docker workspace by name, which is vital if you wan... | Thank you for the report, it sounds good to me.
We have also the ability to name sessions, with the parameter `-n`, for example `-n fix_print_sid` will start the session name with it, so it's more human-readable. Do you find that useful?
[OpenHands](https://github.com/All-Hands-AI/OpenHands) started fixing the issue! ... | [
{
"body": "Within the GUI its really easy to know the session-id as its in the url. \nUnfortunately this information is not available to the user in CLI Mode. Knowing the session is critical to then be able to access the docker workspace by name, which is vital if you want to be able to download the workspace. ... | 70b21d16bd97ed98617ce0d97239123c4029040a | {
"head_commit": "0ea83ba6b649eb5058f7a90aa639d727ee240ac5",
"head_commit_message": "fix: mock input() in test_cli_session_id_output to prevent EOFError",
"patch_to_review": "diff --git a/openhands/core/cli.py b/openhands/core/cli.py\nindex 05a390d8b815..351ced0802bf 100644\n--- a/openhands/core/cli.py\n+++ b/ope... | [
{
"diff_hunk": "@@ -0,0 +1,98 @@\n+import asyncio\n+from unittest.mock import AsyncMock, patch\n+\n+import pytest\n+\n+from openhands.core.cli import main\n+from openhands.core.schema import AgentState\n+from openhands.events.action import ChangeAgentStateAction\n+\n+\n+@pytest.fixture\n+def mock_runtime():\n+ ... | 2704a8c5d3aefe30f26f7244fe9da911a97ee867 | diff --git a/openhands/core/cli.py b/openhands/core/cli.py
index 05a390d8b815..351ced0802bf 100644
--- a/openhands/core/cli.py
+++ b/openhands/core/cli.py
@@ -100,6 +100,7 @@ async def main(loop: asyncio.AbstractEventLoop):
initial_user_action = MessageAction(content=task_str) if task_str else None
sid = st... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "New Feature Additions"
} |
conan-io__conan-17715@3e42c0f | conan-io/conan | Python | 17,715 | [CycloneDX sbom] Improve the default name and add a "name" parameter | Changelog: Omit
Docs: Omit
Close: https://github.com/conan-io/conan/issues/17707
| 2025-02-06T10:45:30Z | [feature] cyclonedx sbom : Override metadata.component.name
### What is your suggestion?
I'm generating a cyclonedx sbom (with the experimental extension) :
metadata section looks like this:
> "metadata": {
> "component": {
> "author": "Conan",
> "bom-ref": "c51464d2-1b72-4a20-b4d0-b0... | Hi @sbouchexbellomie-Philips Thanks for your feedback.
The function returns a JSON object, so you can always edit it with something like `response["metadata"]["component"]["name"] = "my-new-name"`.
Or would you suggest to define it on call as `cyclonedx_1_4(..., name="my-new-name")`
@ErniGH I would go with the "name" ... | [
{
"body": "### What is your suggestion?\n\nI'm generating a cyclonedx sbom (with the experimental extension) :\n\nmetadata section looks like this:\n\n> \"metadata\": {\n> \"component\": {\n> \"author\": \"Conan\",\n> \"bom-ref\": \"c51464d2-1b72-4a20-b4d0-b051a62fbee8\",\n> ... | 000fdeed155220e3126543467dcda9349d883be0 | {
"head_commit": "3e42c0fd7801b05956095e7ac7f5d0cf591abe1b",
"head_commit_message": "use getattr",
"patch_to_review": "diff --git a/conan/tools/sbom/cyclonedx.py b/conan/tools/sbom/cyclonedx.py\nindex 967e452150a..f0500ed0fde 100644\n--- a/conan/tools/sbom/cyclonedx.py\n+++ b/conan/tools/sbom/cyclonedx.py\n@@ -1,... | [
{
"diff_hunk": "@@ -10,6 +10,9 @@ def cyclonedx_1_4(graph, add_build=False, add_tests=False, **kwargs):\n \n has_special_root_node = not (getattr(graph.root.ref, \"name\", False) and getattr(graph.root.ref, \"version\", False) and getattr(graph.root.ref, \"revision\", False))\n special_id = str(uuid.uui... | bd33e52cbe778beb0d220603862a7deb917e8240 | diff --git a/conan/tools/sbom/cyclonedx.py b/conan/tools/sbom/cyclonedx.py
index 967e452150a..22c308a9368 100644
--- a/conan/tools/sbom/cyclonedx.py
+++ b/conan/tools/sbom/cyclonedx.py
@@ -1,6 +1,6 @@
-def cyclonedx_1_4(graph, add_build=False, add_tests=False, **kwargs):
+def cyclonedx_1_4(graph, name=None, add_bui... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
conan-io__conan-17722@93c745b | conan-io/conan | Python | 17,722 | Add a repository parameter to coordinates_to_conandata(). | Changelog: Feature: Forward repository parameter (with same default) from `coordinates_to_conandata()` to `get_url_and_commit()`.
Docs: Omit
fixes #17698
- [x] Refer to the issue that supports this Pull Request.
- [x] If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull R... | 2025-02-06T17:55:21Z | [feature] Git.coordinates_to_conandata() is missing the repository argument.
### What is your suggestion?
As discussed in previous issues, a `repository` argument has been added to both `Git.get_commit()` and `Git.get_url_and_commit()`.
It looks like an oversight that it is not present on `Git.coordinates_to_conandat... | Hi @Adnn
Thanks for the suggestion.
This looks like a valid case, and it looks pretty trivial to implement.
Do you think there is any downside or possible risk? Anything that should be taken into account if storing the repo commit instead of the folder one? Should anything change in the stored data in the ``conandat... | [
{
"body": "### What is your suggestion?\n\nAs discussed in previous issues, a `repository` argument has been added to both `Git.get_commit()` and `Git.get_url_and_commit()`.\nIt looks like an oversight that it is not present on `Git.coordinates_to_conandata()`.\n\n### Have you read the CONTRIBUTING guide?\n\n-... | 9a7f9e2a5628a8646ccc7aadbcf4bb924bd4b959 | {
"head_commit": "93c745b8c44aa3062875a57ede26200800ae1968",
"head_commit_message": "Add a repository parameter to coordinates_to_conandata().",
"patch_to_review": "diff --git a/conan/tools/scm/git.py b/conan/tools/scm/git.py\nindex 6e0ad9e27c3..b09174bd473 100644\n--- a/conan/tools/scm/git.py\n+++ b/conan/tools/... | [
{
"diff_hunk": "@@ -260,15 +260,18 @@ def included_files(self):\n files = files.splitlines()\n return files\n \n- def coordinates_to_conandata(self):\n+ def coordinates_to_conandata(self, repository=False):\n \"\"\"\n Capture the \"url\" and \"commit\" from the Git repo, ca... | e1283c1fc2d25c0da844317a6bf521928c535f0a | diff --git a/conan/tools/scm/git.py b/conan/tools/scm/git.py
index 6e0ad9e27c3..c7bcb6ffe35 100644
--- a/conan/tools/scm/git.py
+++ b/conan/tools/scm/git.py
@@ -260,15 +260,18 @@ def included_files(self):
files = files.splitlines()
return files
- def coordinates_to_conandata(self):
+ def coord... | {
"difficulty": "medium",
"estimated_review_effort": 2,
"problem_domain": "New Feature Additions"
} |
All-Hands-AI__OpenHands-6471@d6f7166 | All-Hands-AI/OpenHands | Python | 6,471 | Fix first user message | **End-user friendly description of the problem this fixes or functionality that this introduces**
- [x] Include this change in the Release Notes. If checked, you must provide an **end-user friendly** description for your change below
Fix DeepSeek error on consecutive user messages.
---
**Give a summary of what ... | 2025-01-27T12:52:36Z | [Bug]: Error while use deepseek R1 model
### Is there an existing issue for the same bug?
- [x] I have checked the existing issues.
### Describe the bug and reproduction steps
`BadRequestError: litellm.BadRequestError: DeepseekException - Error code: 400 - {'error': {'message': 'deepseek-reasoner does not support su... | it works now, add 'AGENT_ENABLE_PROMPT_EXTENSIONS=0'
docker run -it --rm --pull=always \
-e SANDBOX_RUNTIME_CONTAINER_IMAGE=docker.all-hands.dev/all-hands-ai/runtime:0.21-nikolaik \
-e LOG_ALL_EVENTS=true \
-e AGENT_ENABLE_PROMPT_EXTENSIONS=0 \
-v /var/run/docker.sock:/var/run/docker.sock \
-v ~/.o... | [
{
"body": "### Is there an existing issue for the same bug?\n\n- [x] I have checked the existing issues.\n\n### Describe the bug and reproduction steps\n\n`BadRequestError: litellm.BadRequestError: DeepseekException - Error code: 400 - {'error': {'message': 'deepseek-reasoner does not support successive user or... | ffdab28abc5c222ae40451a07ef9c11cf5920379 | {
"head_commit": "d6f716694413a23c09570ae01864d7336e9dc1c3",
"head_commit_message": "fix remote runtime url type",
"patch_to_review": "diff --git a/openhands/agenthub/codeact_agent/codeact_agent.py b/openhands/agenthub/codeact_agent/codeact_agent.py\nindex ecb756781abe..974839e568cf 100644\n--- a/openhands/agenth... | [
{
"diff_hunk": "@@ -501,19 +482,28 @@ def _get_messages(self, state: State) -> list[Message]:\n for response_id in _response_ids_to_remove:\n pending_tool_call_action_messages.pop(response_id)\n \n- for message in messages_to_add:\n- if message:\n- ... | 21d8c0077269eebc78b87608f889a8c2e0269825 | diff --git a/openhands/agenthub/codeact_agent/codeact_agent.py b/openhands/agenthub/codeact_agent/codeact_agent.py
index ecb756781abe..d2b5b35a735d 100644
--- a/openhands/agenthub/codeact_agent/codeact_agent.py
+++ b/openhands/agenthub/codeact_agent/codeact_agent.py
@@ -433,26 +433,6 @@ def _get_messages(self, state: S... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
conan-io__conan-17507@04d4a65 | conan-io/conan | Python | 17,507 | proposing new --format=<format> --out-file=<file.ext> feature | Changelog: Feature: Allow defining ``--out-file=file.ext`` instead of ``--format=ext > file.ext`` to write to files directly and avoid issues with redirects.
Docs: https://github.com/conan-io/docs/pull/3966
This would solve issues with stdout/stderr redirects and potential pollution, while not using new arguments, ... | 2024-12-19T00:15:08Z | [bug] Warnings from Python libraries pollute json output
### Describe the bug
Conan 2
### How to reproduce it
We're using the parameter `--format json` when running `conan create` to get some information about the build. The output is redirected into a file using `> buildinfo.json`. The problem is now that when an i... | Hi @jasal82,
Thanks a lot for your question.
I was trying to check the issue reproducing it but it seems that the logs from urlib3 are not polluting the stdout for me.
We have specifically a line in Conan to avoid this here: https://github.com/conan-io/conan/blob/77a70515cb5f4057d6ff09ffdde4df779bf7d99f/conans... | [
{
"body": "### Describe the bug\n\nConan 2\n\n### How to reproduce it\n\nWe're using the parameter `--format json` when running `conan create` to get some information about the build. The output is redirected into a file using `> buildinfo.json`. The problem is now that when an internally used library like urll... | 6e665578c4cc33949f6ce9a1a891dd7e34446d34 | {
"head_commit": "04d4a652e88804aafd15f0abe44d140f03282856",
"head_commit_message": "add out-file only if formatters",
"patch_to_review": "diff --git a/conan/api/output.py b/conan/api/output.py\nindex 4d110270c56..1a9c0ffad1e 100644\n--- a/conan/api/output.py\n+++ b/conan/api/output.py\n@@ -294,10 +294,7 @@ def c... | [
{
"diff_hunk": "@@ -63,10 +66,13 @@ def _help_formatters(self):\n return [formatter for formatter in self._formatters if formatter != \"text\"]\n \n def _init_formatters(self, parser):\n- formatters = self._help_formatters\n- if formatters:\n- help_message = \"Select the out... | ac895bfcc347e5e50ad01651ee619bc406fe7940 | diff --git a/conan/api/output.py b/conan/api/output.py
index 4d110270c56..ecfaa117bc2 100644
--- a/conan/api/output.py
+++ b/conan/api/output.py
@@ -294,10 +294,14 @@ def cli_out_write(data, fg=None, bg=None, endline="\n", indentation=0):
sys.stdout.write(data)
else:
data = f"{' ' * indentation}{... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
conan-io__conan-17408@4b58023 | conan-io/conan | Python | 17,408 | Fix user/channel when searching patterns in a local-recipes-index | Changelog: Fix: Fix user/channel when searching patterns in a local-recipes-index.
Docs: Omit
Some minor edits to the code still need to be made, but I think this is a better approach than the current one
Closes https://github.com/conan-io/conan/issues/17403 | 2024-12-04T00:16:41Z | [question] Install latest version (or version range) from local recipes index
### What is your question?
In my CI, I use a `local-recipes-index` remote, from which I want to build the latest version of my packages. If I have a "normal" remote, I can do that with
```
$ conan install --requires pkg/[] -b missing
``... | @AbrilRBS I just saw your PR and just wanted to clarify that the issue has nothing to do with an "empty" version range. If I use `[*]` or `[>2]` (or another version range), the behavior is the same.
Hi @fschoenm thanks for your question.
A few things to note here, as locally I'm not able to reproduce with a similar ... | [
{
"body": "### What is your question?\r\n\r\nIn my CI, I use a `local-recipes-index` remote, from which I want to build the latest version of my packages. If I have a \"normal\" remote, I can do that with\r\n```\r\n$ conan install --requires pkg/[] -b missing\r\n```\r\nHowever, that doesn't seem to work with a ... | 6765af055555c60f2170352e3f2d809a101d351a | {
"head_commit": "4b58023913c2d9464d84c8ae72e7ed664a3af10b",
"head_commit_message": "Try to ignore user/channel when searching patterns in a local recipe index",
"patch_to_review": "diff --git a/conans/client/rest_client_local_recipe_index.py b/conans/client/rest_client_local_recipe_index.py\nindex 8615781bdfe..5... | [
{
"diff_hunk": "@@ -213,6 +213,14 @@ def get_recipes_references(self, pattern):\n raise ConanException(f\"Corrupted repo, folder {r} without 'config.yml'\")\n versions = config_yml[\"versions\"]\n for v in versions:\n+ try:\n+ pattern_ref... | 6bf8a12a7dc1859d80e2eb3122824246bc481940 | diff --git a/conans/client/rest_client_local_recipe_index.py b/conans/client/rest_client_local_recipe_index.py
index 8615781bdfe..876b00c212d 100644
--- a/conans/client/rest_client_local_recipe_index.py
+++ b/conans/client/rest_client_local_recipe_index.py
@@ -200,6 +200,16 @@ def get_recipes_references(self, pattern):... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Dependency Updates & Env Compatibility"
} |
conan-io__conan-17129@dfa0b76 | conan-io/conan | Python | 17,129 | POC for tool_requires that make direct dependees inherit generators | Changelog: Feature: Add `self.generators_info` for `tool_requires` to propagate generators to their direct dependencies.
Docs: https://github.com/conan-io/docs/pull/3880
To share as idea for the team
Close https://github.com/conan-io/conan/issues/17113 | 2024-10-08T11:01:07Z | How to tell consumers to use specific generator?
### What is your question?
I have a package that requires certain generator to be used by consumers to work properly. How can I force consumers to use specific generator in addition to what they use in recipes?
### Have you read the CONTRIBUTING guide?
- [X] I've read... | Hi @andrey-zherikov
This is not possible, packages cannot mandate to the consumers what build system should they use.
The information needs to be abstracted in the ``package_info()`` method, and consumers decide how to use it.
Forcing a generator in consumers is also pointless if their build system won't use i... | [
{
"body": "### What is your question?\n\nI have a package that requires certain generator to be used by consumers to work properly. How can I force consumers to use specific generator in addition to what they use in recipes?\n\n### Have you read the CONTRIBUTING guide?\n\n- [X] I've read the CONTRIBUTING guide"... | e25b357d6eab29fcb64ee04340f2d0d479ea09bf | {
"head_commit": "dfa0b760ca937b4cec42c28af4a360aa895590f0",
"head_commit_message": "add: expose create_env_script and register_env_script, adding a test with new custom generator",
"patch_to_review": "diff --git a/conan/internal/api/install/generators.py b/conan/internal/api/install/generators.py\nindex 9b7de140... | [
{
"diff_hunk": "@@ -29,3 +30,45 @@ def package_info(self):\n tc.run(\"create .\")\n assert \"app/1.0: CMakeToolchain generated: conan_toolchain.cmake\" in tc.out\n assert \"app/1.0: MyGenerator generated\" in tc.out\n+\n+\n+def test_inject_vars():\n+ import os\n+ tc = TestClient(light=True)\n+... | ed4b9ca12c3e115017d6e625f0dc1584f24881ac | diff --git a/conan/internal/api/install/generators.py b/conan/internal/api/install/generators.py
index 9b7de140d42..87f53e1b5f1 100644
--- a/conan/internal/api/install/generators.py
+++ b/conan/internal/api/install/generators.py
@@ -73,6 +73,7 @@ def load_cache_generators(path):
def write_generators(conanfile, app, en... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Documentation Updates"
} |
keephq__keep-3387@3c6cd82 | keephq/keep | Python | 3,387 | refactor: workflow builder state | <!--
Thanks for creating this pull request 🤗
Please make sure that the pull request is limited to one type (docs, feature, etc.) and keep it as small as possible. You can open multiple prs instead of opening a huge one.
-->
<!-- If this pull request closes an issue, please mention the issue number below -->
... | 2025-02-10T15:55:47Z | [internal]: refactor workflow builder store
State of workflow builder is stretched between many files: zustand in `builder-store.ts`, local state of `Builder`, `BuilderCard`, `useWorkflowInitialization`, `editors.ts`, etc. Saving logic is complex and relies on refs, and props drilling.
In order to move the "enable/dis... | [
{
"body": "State of workflow builder is stretched between many files: zustand in `builder-store.ts`, local state of `Builder`, `BuilderCard`, `useWorkflowInitialization`, `editors.ts`, etc. Saving logic is complex and relies on refs, and props drilling.\n\nIn order to move the \"enable/disable\" button, \"edit\... | 732a1b20ef04d24c4bd41651e06a2145b9f7624e | {
"head_commit": "3c6cd8238fd442b15f477bbfb7886eec681060e8",
"head_commit_message": "refactor: move workflow-status to global editor",
"patch_to_review": "diff --git a/keep-ui/app/(keep)/workflows/[workflow_id]/workflow-detail-page.tsx b/keep-ui/app/(keep)/workflows/[workflow_id]/workflow-detail-page.tsx\nindex 3... | [
{
"diff_hunk": "@@ -76,100 +131,112 @@ export function WorkflowBuilderPageClient({\n };\n reader.readAsText(file);\n }\n- const incrementState = (s: number) => s + 1;\n+\n+ const handleMetadataSubmit = ({\n+ name,\n+ description,\n+ }: {\n+ name: string;\n+ description: string;\n+ }) =... | cd841aa03222452a2d7d131035fd69cb7135675f | diff --git a/.github/workflows/test-pr-ut-ui.yml b/.github/workflows/test-pr-ut-ui.yml
new file mode 100644
index 0000000000..002321ebfc
--- /dev/null
+++ b/.github/workflows/test-pr-ut-ui.yml
@@ -0,0 +1,52 @@
+name: Frontend Tests
+on:
+ push:
+ paths:
+ - "keep-ui/**"
+ pull_request:
+ paths:
+ - "k... | {
"difficulty": "high",
"estimated_review_effort": 5,
"problem_domain": "Code Refactoring / Architectural Improvement"
} | |
conan-io__conan-17024@86b20b0 | conan-io/conan | Python | 17,024 | Test for universal binaries macOS using Ninja | Changelog: Fix: Replace `|` character in generated CMake and Environment files.
Docs: Omit
Closes: https://github.com/conan-io/conan/issues/17009
| 2024-09-19T12:52:55Z | [bug] Generated CMake files for macOS universal binaries not compatible with Ninja
### Describe the bug
Using generated CMake files for macOS universal binaries aren't compatible with Ninja. For example:
```
# conanfile.txt
[requires]
zlib/1.3.1
[generators]
CMakeToolchain
CMakeDeps
```
```
# CMakeLists.... | Hi @phlipsi
Thanks for the report.
Just to make sure, is this happening if using the ``Unix Makefiles`` CMake generator instead of the Ninja one?
> ZLIB-release-armv8|x86_64-data.cmake
This seems the cause, I am now a bit surprised that this doesn't generate issues with other generators. I guess that we co... | [
{
"body": "### Describe the bug\n\nUsing generated CMake files for macOS universal binaries aren't compatible with Ninja. For example:\r\n```\r\n# conanfile.txt\r\n[requires]\r\nzlib/1.3.1\r\n\r\n[generators]\r\nCMakeToolchain\r\nCMakeDeps\r\n```\r\n\r\n```\r\n# CMakeLists.txt\r\ncmake_minimum_required(VERSION ... | 71795621a800c25021f27ab1fe73c5eefadad04e | {
"head_commit": "86b20b0c8a3abec2e11c89e23a2c22be7c64e9c4",
"head_commit_message": "expand test",
"patch_to_review": "diff --git a/conan/tools/cmake/cmakedeps/templates/target_data.py b/conan/tools/cmake/cmakedeps/templates/target_data.py\nindex 35330ee091d..1e5a6e2862a 100644\n--- a/conan/tools/cmake/cmakedeps/... | [
{
"diff_hunk": "@@ -99,3 +99,47 @@ def test(self):\n client.run_command(\"lipo -info './build/armv8|armv8.3|x86_64/Release/foo'\")\n \n assert \"foo are: x86_64 arm64 arm64e\" in client.out\n+\n+\n+@pytest.mark.skipif(platform.system() != \"Darwin\", reason=\"Only OSX\")\n+@pytest.mark.tool(\"cmake\", \... | f6f16e7203c8d6dcebeb12a3fdd3cd0affe2471b | diff --git a/conan/tools/cmake/cmakedeps/templates/target_data.py b/conan/tools/cmake/cmakedeps/templates/target_data.py
index 35330ee091d..1e5a6e2862a 100644
--- a/conan/tools/cmake/cmakedeps/templates/target_data.py
+++ b/conan/tools/cmake/cmakedeps/templates/target_data.py
@@ -23,7 +23,8 @@ def filename(self):
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
keephq__keep-3326@45f1879 | keephq/keep | Python | 3,326 | feat: manual topology manipulation | <!--
Thanks for creating this pull request 🤗
Please make sure that the pull request is limited to one type (docs, feature, etc.) and keep it as small as possible. You can open multiple prs instead of opening a huge one.
-->
<!-- If this pull request closes an issue, please mention the issue number below -->
... | 2025-02-05T14:36:36Z | [➕ Feature]: Manual creation of topology
As a user, I would like to manually be able to add services and create connection with Keep's topology feature
We imagine the Topology map to be dynamic, allowing users to add new components and drawing the connections between them.
If the Topology item is fetched from 3rd part... | /bounty 500
/attempt #2904
<div id="algora-attempt" />
| [Algora profile](https://console.algora.io/@/35C4n0r) | Completed bounties | Tech | Active attempts | Options |
| --- | --- | --- | --- | --- |
| @35C4n0r | 18 keephq bounties <br/> + 16 bounties from 6 projects | <div align="center">Python, T... | [
{
"body": "As a user, I would like to manually be able to add services and create connection with Keep's topology feature\n\nWe imagine the Topology map to be dynamic, allowing users to add new components and drawing the connections between them.\nIf the Topology item is fetched from 3rd party provider, it shou... | 9783f422c943cdada1ba6d907a8d16615b9f9701 | {
"head_commit": "45f1879cedb2392cb04e524f15942715f541505a",
"head_commit_message": "fix: CI\n\nSigned-off-by: 35C4n0r <jaykumar20march@gmail.com>",
"patch_to_review": "diff --git a/keep-ui/app/(keep)/topology/model/models.ts b/keep-ui/app/(keep)/topology/model/models.ts\nindex e8f01188ad..c9b59234de 100644\n--- ... | [
{
"diff_hunk": "@@ -42,47 +42,49 @@ export function TopologyPageClient({\n }, [selectedObjectId]);\n \n return (\n- <TabGroup\n- id=\"topology-tabs\"\n- className=\"flex flex-col\"\n- index={tabIndex}\n- onIndexChange={setTabIndex}\n- >\n- <TabList className=\"mb-2\">\n- ... | b03597892de10b3372d188ca4a04ec31570064f5 | diff --git a/keep-ui/app/(keep)/topology/model/models.ts b/keep-ui/app/(keep)/topology/model/models.ts
index e8f01188ad..c9b59234de 100644
--- a/keep-ui/app/(keep)/topology/model/models.ts
+++ b/keep-ui/app/(keep)/topology/model/models.ts
@@ -1,14 +1,16 @@
import { InterfaceToType } from "@/utils/type-utils";
import ... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
conan-io__conan-17045@e1ba1cc | conan-io/conan | Python | 17,045 | [BazelDeps][bugfix] Windows and shared libraries | Changelog: Bugfix: BazelDeps did not find DLL files as Conan does not model them in the Windows platform.
Docs: omit
Close: https://github.com/conan-io/conan/issues/16691
| 2024-09-23T17:42:38Z | [bug] generated BUILD.bazel file does not import dll when shared=True for some packages
### Describe the bug
On Windows, with msvc, and shared=True, the bazel build file is not generated with an import statement for the DLL, for many conan packages:
The missing piece is:
```
cc_import(
name = "libcurl_prec... | HI @peakschris
Sorry for the huge delay 😢
Yes, it's a bug so thanks a lot for reporting this. The problem is when the components have all the information about the library names instead of the root package.
I'll open a PR to solve this ASAP 😁
Wonderful! I've been running code that patches the build files afte... | [
{
"body": "### Describe the bug\r\n\r\nOn Windows, with msvc, and shared=True, the bazel build file is not generated with an import statement for the DLL, for many conan packages:\r\n\r\nThe missing piece is:\r\n```\r\ncc_import(\r\n name = \"libcurl_precompiled\",\r\n interface_library = \"lib/libcurl_im... | f5d6598ab0363234d42436ed83a18ef96d78f6fa | {
"head_commit": "e1ba1ccadb6efced7ba9655aa98b1c7e4af6ac38",
"head_commit_message": "Added test",
"patch_to_review": "diff --git a/conan/tools/google/bazeldeps.py b/conan/tools/google/bazeldeps.py\nindex 4cb213e8878..9b89fe7e9d4 100644\n--- a/conan/tools/google/bazeldeps.py\n+++ b/conan/tools/google/bazeldeps.py\... | [
{
"diff_hunk": "@@ -72,18 +72,19 @@ def _get_requirements(conanfile, build_context_activated):\n yield require, dep\n \n \n-def _get_libs(dep, cpp_info=None) -> list:\n+def _get_libs(dep, cpp_info=None, reference_name=None) -> list:\n \"\"\"\n Get the static/shared library paths\n \n :param ... | 1890e15def6d87e88962b1ce7a0a364f3e120f4e | diff --git a/conan/tools/google/bazeldeps.py b/conan/tools/google/bazeldeps.py
index 4cb213e8878..916e13f42a2 100644
--- a/conan/tools/google/bazeldeps.py
+++ b/conan/tools/google/bazeldeps.py
@@ -10,8 +10,8 @@
from conans.model.dependencies import get_transitive_requires
from conans.util.files import save
-_BazelT... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
conan-io__conan-17102@3c031d3 | conan-io/conan | Python | 17,102 | Feature/build order profile args | Changelog: Feature: Add profile arguments information to ``conan graph build-order`` to improve UX and usage in CI systems.
Docs: https://github.com/conan-io/docs/pull/3884
Close https://github.com/conan-io/conan/issues/17089 | 2024-10-02T15:35:31Z | [question] Profile information in merged build-order files
### What is your question?
Hi!
In our workflow, we merge the two build-order JSON files for the Release and Debug profile and then go through the build-order hierarchy and build the packages by using the `build_args` flags from the according JSON entry for a ... | Hi @NilsKlimanis
Thanks for your question.
I am just trying to finalize the docs new CI tutorial covering these aspects, see ongoing work in https://github.com/conan-io/docs/pull/3799
It is true that it is not that straightforward to recover the profile information from the build-order files, it assumes that ... | [
{
"body": "### What is your question?\n\nHi!\r\nIn our workflow, we merge the two build-order JSON files for the Release and Debug profile and then go through the build-order hierarchy and build the packages by using the `build_args` flags from the according JSON entry for a `conan install` command.\r\nTwo ques... | 2e3f51782056b6665560f9af6166e30d7c2801ab | {
"head_commit": "3c031d3be612f715d434f46b961674e2bb369c18",
"head_commit_message": "proposed profile args for build-order",
"patch_to_review": "diff --git a/conan/cli/commands/graph.py b/conan/cli/commands/graph.py\nindex a929f39f1e9..430bad75ec9 100644\n--- a/conan/cli/commands/graph.py\n+++ b/conan/cli/command... | [
{
"diff_hunk": "@@ -331,17 +331,41 @@ def merge(self, other):\n self.filenames.append(d)\n \n \n+class ProfileArgs:\n+ def __init__(self, args):\n+ self._args = args\n+\n+ @staticmethod\n+ def from_args(args):\n+ pr_args = []\n+ for context in \"host\", \"build\":\n... | 9f88e5f6cdfe73b86326e8d7b30bb032838493f9 | diff --git a/conan/cli/commands/graph.py b/conan/cli/commands/graph.py
index 60e71f0d0fd..aa1fb298c2e 100644
--- a/conan/cli/commands/graph.py
+++ b/conan/cli/commands/graph.py
@@ -15,7 +15,7 @@
from conan.errors import ConanException
from conan.internal.deploy import do_deploys
from conans.client.graph.graph import... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
conan-io__conan-16986@150d43f | conan-io/conan | Python | 16,986 | Fix propagation of include_prerelease when calculating VersionRange intersection | Changelog: Bugfix: Propagate include_prerelease flag to intersection of VersionRange.
Docs: Omit
fixes: #16983 | 2024-09-12T12:47:26Z | [bug] VersionRange.intersection doesn't propagate include_prerelease flag
### Describe the bug
Conan 2.7.0
We would like to propagate pre-release packages down our dependency graph by using a composed profile containing [replace_requires]. Since the global configuration should not be changed every time a develope... | I think I have found a simple solution, do you want a PR? | [
{
"body": "### Describe the bug\r\n\r\nConan 2.7.0\r\n\r\nWe would like to propagate pre-release packages down our dependency graph by using a composed profile containing [replace_requires]. Since the global configuration should not be changed every time a developer decides to test a pre-release package, I want... | 216d3acf9a0047a258ac2f3a0645f2dc9a04c630 | {
"head_commit": "150d43fe882bc8bc96e594311c40c33431d31f41",
"head_commit_message": "Add tests for shortcircuit behaviour",
"patch_to_review": "diff --git a/conans/model/version_range.py b/conans/model/version_range.py\nindex 751683e3e73..acd924fb1bf 100644\n--- a/conans/model/version_range.py\n+++ b/conans/model... | [
{
"diff_hunk": "@@ -140,6 +140,14 @@ def valid(self, version, conf_resolve_prepreleases):\n return False\n return True\n \n+ def __eq__(self, other):\n+ if not isinstance(other, _ConditionSet):",
"line": null,
"original_line": 144,
"original_start_line": null,
... | 87d6755f6d87bb87695cfb5251ef401e54a6f230 | diff --git a/conans/model/version_range.py b/conans/model/version_range.py
index ba59e84e6ba..106682f25dc 100644
--- a/conans/model/version_range.py
+++ b/conans/model/version_range.py
@@ -196,6 +196,7 @@ def _calculate_limits(operator, lhs, rhs):
if limits:
return sorted(limits, reverse=o... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
keephq__keep-3054@2d23bf3 | keephq/keep | Python | 3,054 | feat: add e2e tests | <!--
Thanks for creating this pull request 🤗
Please make sure that the pull request is limited to one type (docs, feature, etc.) and keep it as small as possible. You can open multiple prs instead of opening a huge one.
-->
<!-- If this pull request closes an issue, please mention the issue number below -->
... | 2025-01-18T19:34:44Z | [➕ Feature]: add more e2e tests
**Is your feature request related to a problem? Please describe.**
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
**Describe the solution you'd like**
A clear and concise description of what you want to happen.
**Describe alternatives you'v... | [
{
"body": "**Is your feature request related to a problem? Please describe.**\nA clear and concise description of what the problem is. Ex. I'm always frustrated when [...]\n\n**Describe the solution you'd like**\nA clear and concise description of what you want to happen.\n\n**Describe alternatives you've consi... | 4fd693764357c3afb00818317d9344e932414a1c | {
"head_commit": "2d23bf39b9d56aed3ff6c006567a0d3392cc9816",
"head_commit_message": "chore: minor fixes\n\nSigned-off-by: 35C4n0r <jaykumar20march@gmail.com>",
"patch_to_review": "diff --git a/.github/workflows/test-pr-e2e.yml b/.github/workflows/test-pr-e2e.yml\nindex 2a8dfb696c..917e953a7e 100644\n--- a/.github... | [
{
"diff_hunk": "@@ -43,6 +47,73 @@ services:\n depends_on:\n - keep-database\n \n+\n+ ## Keep Services with DB\n+ # Database Service (5433)\n+ keep-database-db-auth:\n+ image: postgres:13\n+ environment:\n+ POSTGRES_USER: keepuser\n+ POSTGRES_PASSWORD: keeppassword\n+ POSTGRES_... | b616e03fc3df675a8fa5ab0723a917f3b5662102 | diff --git a/.github/workflows/test-pr-e2e.yml b/.github/workflows/test-pr-e2e.yml
index 2a8dfb696c..a99f16cad9 100644
--- a/.github/workflows/test-pr-e2e.yml
+++ b/.github/workflows/test-pr-e2e.yml
@@ -92,17 +92,49 @@ jobs:
- name: Wait for database to be ready
run: |
# Add commands to wait ... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "Test Suite / CI Enhancements"
} | |
conan-io__conan-16942@e62c6eb | conan-io/conan | Python | 16,942 | Add `auth_plugin` with tests | Changelog: Feature: New ``auth_remote.py`` plugin for custom user authentication to Conan remotes.
Changelog: Feature: New ``auth_source.py`` plugin for custom user authentication for generic downloads of sources.
Changelog: Bugfix: Allow `remote_login` accept patterns.
Docs: https://github.com/conan-io/docs/pull/38... | 2024-09-05T15:14:15Z | Compatibility with keyring (libsecret) for user login credentials
It would be nice if I could store my credentials for a remote into a keychain such as `libsecret` like I can do with `git`.
[Question] How to use two factor authentication (2FA) like Google Authenticator with Conan?
Hi @memsharded and @lasote ,
I hav... | I have changed the title, as keychain is more related to iOS apps, which does not relate here.
There is a python interface to libsecret thanks to Gnome: https://developer.gnome.org/libsecret/0.16/py-examples.html, which might be useful for this.
It sounds a bit very specific solution for one platform, I don't kno... | [
{
"body": "It would be nice if I could store my credentials for a remote into a keychain such as `libsecret` like I can do with `git`.",
"number": 4196,
"title": "Compatibility with keyring (libsecret) for user login credentials"
},
{
"body": "Hi @memsharded and @lasote ,\r\n\r\nI have a questio... | 6acce7bd9cc864713f57e7fbdcda75bbff2de9c7 | {
"head_commit": "e62c6ebc3fadf6a0058d29bf90067e90c1d4822b",
"head_commit_message": "Add `auth_plugin` with tests",
"patch_to_review": "diff --git a/conan/internal/cache/home_paths.py b/conan/internal/cache/home_paths.py\nindex ba2402ded2a..562dfa994ff 100644\n--- a/conan/internal/cache/home_paths.py\n+++ b/conan... | [
{
"diff_hunk": "@@ -52,6 +52,9 @@ def _apply_migrations(self, old_version):\n # Update profile plugin\n from conan.internal.api.profile.profile_loader import migrate_profile_plugin\n migrate_profile_plugin(self.cache_folder)\n+ # Update auth plugin\n+ from conans.client.res... | d03623dc052761204539074aa457826dbefc43d5 | diff --git a/conan/cli/commands/remote.py b/conan/cli/commands/remote.py
index 8cd43711003..35cffa9b8b3 100644
--- a/conan/cli/commands/remote.py
+++ b/conan/cli/commands/remote.py
@@ -196,14 +196,16 @@ def remote_login(conan_api, parser, subparser, *args):
raise ConanException("There are no remotes matching t... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
conan-io__conan-16883@09d3616 | conan-io/conan | Python | 16,883 | Fix for #16882: Generated CMake build when using tools.build.linker_scripts | The generated build otherwise appends the "-Tfoo.ld" argument directly without a preceding space before which can generate an invalid command line.
Changelog: Bugfix: Avoid ``CMakeToolchain`` error when both architecture flags and ``tools.build:linker_scripts`` are defined, due to missing space.
Docs: Omit
Close... | 2024-08-27T13:17:32Z | [bug] Specifying `tools.build.linker_scripts` in my profile results in an invalid command line when linking.
### Describe the bug
I'm using Fedora 40, with conan from the develop2 branch.
While attempting to move my linker_script setup out of cmake and into my conan profile I encountered the error that the way in w... | [
{
"body": "### Describe the bug\n\nI'm using Fedora 40, with conan from the develop2 branch.\r\n\r\nWhile attempting to move my linker_script setup out of cmake and into my conan profile I encountered the error that the way in which the linker command was appended doesn't put a space between the previous linker... | 0191d7f04d6b1cb85d6bece766b72a2dae87ad5c | {
"head_commit": "09d3616331f72678a4210849391feb6219301270",
"head_commit_message": "Avoids the warning regarding arguments not being separated by space.\n\n```\nCMake Warning (dev) at /home/chipc/.conan2/p/b/mypkgbc25b469ad9ce/b/build/generators/conan_toolchain.cmake:54:\n Syntax Warning in cmake code at column 4... | [
{
"diff_hunk": "@@ -265,7 +265,7 @@ def context(self):\n linker_scripts = [linker_script.replace('\\\\', '/') for linker_script in linker_scripts]\n linker_scripts = [relativize_path(p, self._conanfile, \"${CMAKE_CURRENT_LIST_DIR}\")\n for p in linker_scripts]\n- ... | 5dc917eb277815d02bff68de19239f574b912984 | diff --git a/conan/tools/cmake/toolchain/blocks.py b/conan/tools/cmake/toolchain/blocks.py
index 930d62f484f..5549fdf1dcc 100644
--- a/conan/tools/cmake/toolchain/blocks.py
+++ b/conan/tools/cmake/toolchain/blocks.py
@@ -254,7 +254,7 @@ class LinkerScriptsBlock(Block):
# Add linker flags from tools.build:linke... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} | |
conan-io__conan-16611@865a41c | conan-io/conan | Python | 16,611 | Add html output for graph build-order and graph build-order-merge | Changelog: Feature: Add html output for graph build-order and graph build-order-merge
Docs: https://github.com/conan-io/docs/pull/3805
Closes: https://github.com/conan-io/conan/issues/16356
| 2024-07-04T12:23:13Z | [feature] html graph from existing build-order.json
### What is your suggestion?
The `conan graph info` command has a fantastic html output for graphs that can be used to look through a chosen graph.
The `conan graph build-order` command can be used to produce many such chunks of graphable data,
and the `conan gra... | [
{
"body": "### What is your suggestion?\r\n\r\nThe `conan graph info` command has a fantastic html output for graphs that can be used to look through a chosen graph.\r\nThe `conan graph build-order` command can be used to produce many such chunks of graphable data,\r\nand the `conan graph build-order-merge` com... | 3c72e2a83b468bb0d18e958c7e160fbb324b146e | {
"head_commit": "865a41c28e2029bcf6c28347bf8608775ed09fcf",
"head_commit_message": "different node for build context",
"patch_to_review": "diff --git a/conan/cli/commands/graph.py b/conan/cli/commands/graph.py\nindex 85d7cb510ec..8f412474438 100644\n--- a/conan/cli/commands/graph.py\n+++ b/conan/cli/commands/gra... | [
{
"diff_hunk": "@@ -0,0 +1,266 @@\n+from jinja2 import select_autoescape, Template\n+\n+from conan.api.output import cli_out_write\n+\n+build_order_html = r\"\"\"<html lang=\"en\">\n+ <head>\n+ <script src=\"https://cdnjs.cloudflare.com/ajax/libs/cytoscape/3.30.0/cytoscape.min.js\"\n+ integrity... | 09c0c8de210daee2646d4cbd241963711d22cd8c | diff --git a/conan/cli/commands/graph.py b/conan/cli/commands/graph.py
index 85d7cb510ec..8f412474438 100644
--- a/conan/cli/commands/graph.py
+++ b/conan/cli/commands/graph.py
@@ -8,6 +8,7 @@
from conan.cli.command import conan_command, conan_subcommand
from conan.cli.commands.list import prepare_pkglist_compact, pr... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
All-Hands-AI__OpenHands-5891@0262e25 | All-Hands-AI/OpenHands | Python | 5,891 | Fix issue #5890: Add an automatic check of version consistency in documentation | This pull request fixes #5890.
The issue has been successfully resolved. The AI agent implemented a complete solution that addresses all requirements from the original issue:
1. A version consistency checker script was created that uses regex to find all version references
2. The script was integrated into the CI pip... | 2024-12-29T01:14:10Z | Add an automatic check of version consistency in documentation
**What problem or use case are you trying to solve?**
When we update versions in documentation, they are specified in many different places across the codebase, and sometimes they get out of sync.
**Describe the UX of the solution you'd like**
It w... | [OpenHands](https://github.com/All-Hands-AI/OpenHands) started fixing the issue! You can monitor the progress [here](https://github.com/All-Hands-AI/OpenHands/actions/runs/12531220308).
A potential fix has been generated and a draft PR #5891 has been created. Please review the changes. | [
{
"body": "**What problem or use case are you trying to solve?**\r\n\r\nWhen we update versions in documentation, they are specified in many different places across the codebase, and sometimes they get out of sync.\r\n\r\n**Describe the UX of the solution you'd like**\r\n\r\nIt would be good to have automatic c... | 7f665c2fb68de752fc66dfa56d96789dd9f8ca75 | {
"head_commit": "0262e253536162444fccfa482129a2f1ebb42525",
"head_commit_message": "Merge branch 'main' into openhands-fix-issue-5890",
"patch_to_review": "diff --git a/.github/scripts/check_version_consistency.py b/.github/scripts/check_version_consistency.py\nnew file mode 100755\nindex 000000000000..18180d9e8... | [
{
"diff_hunk": "@@ -0,0 +1,66 @@\n+#!/usr/bin/env python3\n+import os\n+import re\n+import sys\n+from typing import Set, Tuple\n+\n+\n+def find_version_references(directory: str) -> Tuple[Set[str], Set[str]]:\n+ openhands_versions = set()\n+ runtime_versions = set()\n+\n+ version_pattern_openhands = re... | 6d67e338210f7bd25a57cb5bb43ba8b77dfd6c59 | diff --git a/.github/scripts/check_version_consistency.py b/.github/scripts/check_version_consistency.py
new file mode 100755
index 000000000000..daf78a8d2c1a
--- /dev/null
+++ b/.github/scripts/check_version_consistency.py
@@ -0,0 +1,66 @@
+#!/usr/bin/env python3
+import os
+import re
+import sys
+from typing import S... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Test Suite / CI Enhancements"
} |
conan-io__conan-16633@4033bd3 | conan-io/conan | Python | 16,633 | build-folder-vars user.value | Changelog: Feature: Add ``build_folder_vars=["const.myvalue"]`` to create presets for user "myvalue" arbitrary values.
Docs: https://github.com/conan-io/docs/pull/3800
Close https://github.com/conan-io/conan/issues/16557 | 2024-07-09T08:24:36Z | [question] preset name != profile name
### What is your question?
For my conan profile "Release" the cmake preset ends up being "conan-release", and for "Debug" it ends up being "conan-debug". This is fine! But for "DebugASAN", it also ends up being "conan-debug" and not "conan-debugasan".
Is there some easy way I ... | Hi @h-2
Thanks for your question.
The profile file name is never used in the preset itself, if your profile file is named "Release", it is a coincidence. The presets names are taken:
- by default from the ``build_type`` setting
- It can be customized with the ``self.folders.build_folder_vars`` as ``self.folder... | [
{
"body": "### What is your question?\n\nFor my conan profile \"Release\" the cmake preset ends up being \"conan-release\", and for \"Debug\" it ends up being \"conan-debug\". This is fine! But for \"DebugASAN\", it also ends up being \"conan-debug\" and not \"conan-debugasan\".\r\n\r\nIs there some easy way I ... | 59bcd3895b2723f9c360709afd5dff3fe539e0e4 | {
"head_commit": "4033bd363311ea777725910bd61cd21addf814d6",
"head_commit_message": "Update conan/tools/cmake/layout.py\n\nCo-authored-by: Abril Rincón Blanco <git@rinconblanco.es>",
"patch_to_review": "diff --git a/conan/tools/cmake/layout.py b/conan/tools/cmake/layout.py\nindex dad6ce31270..a30364f52ac 100644\n... | [
{
"diff_hunk": "@@ -1278,6 +1278,32 @@ def layout(self):\n assert \"conan-windows-pkg-0.1-debug\" in presets\n \n \n+def test_build_folder_vars_constants_user():\n+ c = TestClient()\n+ conanfile = textwrap.dedent(\"\"\"\n+ from conan import ConanFile\n+ from conan.tools.cmake import cmak... | 5271e725f256e4ac3476545fb72b7848542c1e07 | diff --git a/conan/tools/cmake/layout.py b/conan/tools/cmake/layout.py
index dad6ce31270..fbff89c200c 100644
--- a/conan/tools/cmake/layout.py
+++ b/conan/tools/cmake/layout.py
@@ -94,9 +94,11 @@ def get_build_folder_custom_vars(conanfile):
tmp = "{}_{}".format(var, value)
elif group == "s... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
conan-io__conan-16789@0c8f071 | conan-io/conan | Python | 16,789 | Add `set_property` for PkgConfigDeps | Changelog: Feature: Add `set_property` for PkgConfigDeps to set properties for requirements from consumer recipes.
Docs: Omit
close: #13076
| 2024-08-05T11:17:38Z | [feature] PkgConfigDeps.set_property() for renaming .pc files
### What is your suggestion?
CMakeDeps recently gained a handy set_property() method.
For the ffmpeg recipe, the x264.pc file is manually renamed to libx264.pc,
it would be pretty sweet if it could become
```
pc = PkgConfigDeps(self)
pc.set_property(... | [
{
"body": "### What is your suggestion?\n\nCMakeDeps recently gained a handy set_property() method.\r\n\r\nFor the ffmpeg recipe, the x264.pc file is manually renamed to libx264.pc,\r\nit would be pretty sweet if it could become\r\n```\r\npc = PkgConfigDeps(self)\r\npc.set_property(\"libx264\", \"pkg_config_nam... | 369a3d0751b20cdb19abf7547b8b98e8cbd6dec9 | {
"head_commit": "0c8f07140f3732f0139bcbbdbced42724ed40ef9",
"head_commit_message": "Update test/integration/toolchains/gnu/test_pkgconfigdeps.py\n\nCo-authored-by: Francisco Ramírez <franchuti688@gmail.com>",
"patch_to_review": "diff --git a/conan/tools/gnu/pkgconfigdeps.py b/conan/tools/gnu/pkgconfigdeps.py\nin... | [
{
"diff_hunk": "@@ -397,6 +398,10 @@ def content(self):\n # Filter the build_requires not activated with PkgConfigDeps.build_context_activated\n if require.build and dep.ref.name not in self.build_context_activated:\n continue\n+ if dep.ref.name in self._proper... | 6cba2e46d9d661b77c470e8f29681a2604fe74a8 | diff --git a/conan/tools/gnu/pkgconfigdeps.py b/conan/tools/gnu/pkgconfigdeps.py
index 4e2160989cc..3e743678788 100644
--- a/conan/tools/gnu/pkgconfigdeps.py
+++ b/conan/tools/gnu/pkgconfigdeps.py
@@ -350,6 +350,7 @@ def __init__(self, conanfile):
# Issue: https://github.com/conan-io/conan/issues/14935
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
conan-io__conan-16597@6c0da7e | conan-io/conan | Python | 16,597 | core.scm:local_url=allow|block | Changelog: Feature: Introduce ``core.scm:local_url=allow|block`` to control local folder URLs in conandata ``scm``.
Changelog: Fix: Raise an error when trying to upload a package with a local folder URL in ``conandata`` ``scm``.
Docs: https://github.com/conan-io/docs/pull/3801
Close https://github.com/conan-io/co... | 2024-07-03T11:40:28Z | [bug] Recipes with invalid remote URLs in conandata can be uploaded
### Describe the bug
Conan 1.64.1
### How to reproduce it
When using the `export()`/`source()` methods in combination with manually implemented url and commit capturing (as recommended in the docs as replacement for the deprecated `scm` attrib... | Hi @jasal82
Thanks for your report.
I am having a look to the code, and investigating how this could be improved.
In the meantime, I think the hook approach is not bad, but I would handle this differently, to make it more solid. Instead of patching the method in a ``pre-export`` hook, I would do a ``post-expo... | [
{
"body": "### Describe the bug\r\n\r\nConan 1.64.1\r\n\r\n### How to reproduce it\r\n\r\nWhen using the `export()`/`source()` methods in combination with manually implemented url and commit capturing (as recommended in the docs as replacement for the deprecated `scm` attribute) there is one code path which can... | dd28339d2964593471ead06257b89fec5e4ab24e | {
"head_commit": "6c0da7e8c5e10f18da65641c69d973274e6c238a",
"head_commit_message": "core.scm:local_url=allow|block",
"patch_to_review": "diff --git a/conan/tools/scm/git.py b/conan/tools/scm/git.py\nindex 1c8a12fc06d..117a064b8dd 100644\n--- a/conan/tools/scm/git.py\n+++ b/conan/tools/scm/git.py\n@@ -34,6 +34,7 ... | [
{
"diff_hunk": "@@ -81,10 +81,17 @@ def __init__(self, app: ConanApp, global_conf):\n self._global_conf = global_conf\n \n def prepare(self, upload_bundle, enabled_remotes):\n+ local_url = self._global_conf.get(\"core.scm:local_url\", choices=[\"allow\", \"block\"])\n for ref, bundle ... | 1e1f2c73f91b842676b59bb4e22535e8c49d18c9 | diff --git a/conan/tools/scm/git.py b/conan/tools/scm/git.py
index 1c8a12fc06d..117a064b8dd 100644
--- a/conan/tools/scm/git.py
+++ b/conan/tools/scm/git.py
@@ -34,6 +34,7 @@ def __init__(self, conanfile, folder=".", excluded=None):
self._excluded = c.get("core.scm:excluded", check_type=list)
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
All-Hands-AI__OpenHands-6070@edb4ed6 | All-Hands-AI/OpenHands | Python | 6,070 | Improve i18n support and add missing translations | This PR improves the internationalization (i18n) support in the frontend by:
1. Adding missing translations for all supported languages (zh-CN, zh-TW, ko-KR, de, no, it, pt, es, ar, fr, tr) for:
- Workspace labels and titles
- Project and terminal status messages
- Time-related messages
2. Adding i18n... | 2025-01-06T07:34:50Z | Update the frontend to use i18n keys
**What problem or use case are you trying to solve?**
The new UI hardcodes english text throughout the app. In order to support i18n, we should extend our i18n provider and replaced the hardcoded values with the new keys
**Describe the UX of the solution you'd like**
**Do you... | Went through the codebase and got a good understanding of the changes that I would need to make here. Can I work on this?
Also what are your thoughts on adding [eslint-plugin-i18n](https://www.npmjs.com/package/eslint-plugin-i18n) to give warnings so that we do not miss out on this in the future?
Thanks for taking t... | [
{
"body": "**What problem or use case are you trying to solve?**\r\nThe new UI hardcodes english text throughout the app. In order to support i18n, we should extend our i18n provider and replaced the hardcoded values with the new keys\r\n\r\n**Describe the UX of the solution you'd like**\r\n\r\n**Do you have th... | 92b8d55c2db6884e7883065a9003fc093903f6c2 | {
"head_commit": "edb4ed636839cbb107be3749206a329f4dfc66f6",
"head_commit_message": "Fix linting issues: Fix import order and add newlines at end of files",
"patch_to_review": "diff --git a/frontend/__tests__/components/chat/chat-input.test.tsx b/frontend/__tests__/components/chat/chat-input.test.tsx\nindex 3cf83... | [
{
"diff_hunk": "",
"line": null,
"original_line": null,
"original_start_line": null,
"path": "package-lock.json",
"start_line": null,
"text": "@user1:\nAdded by mistake, should remove"
},
{
"diff_hunk": "",
"line": null,
"original_line": null,
"original_start_line": n... | 70494631870d7ac43b04e871099b8e730a596cee | diff --git a/frontend/__tests__/components/browser.test.tsx b/frontend/__tests__/components/browser.test.tsx
index 6b4bfba73d4d..c51519bf0ff4 100644
--- a/frontend/__tests__/components/browser.test.tsx
+++ b/frontend/__tests__/components/browser.test.tsx
@@ -45,7 +45,7 @@ describe("Browser", () => {
});
// ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
keephq__keep-3001@8e12c68 | keephq/keep | Python | 3,001 | docs: update enrichment.mdx | Close #2995
added to doc | 2025-01-09T15:22:18Z | [📃 Docs]: disposable and enrich alert in trigger interval or manual (from workflow page) or incident
My question is in the context of enrichment in the resolve_old_alert case
1) what does disposable true do?
2) how does the enrichment rule work if you don't have an alert in the trigger?
3) can I call subprocess in ... | <!-- Answer -->
1. The `disposable` attribute in an enrichment rule determines whether the enrichment is temporary and should be discarded when a new alert is received. If `disposable` is set to `True`, the enrichment is added to `disposable_enrichments` and marked with `dispose_on_new_alert=True`. This means the enric... | [
{
"body": "My question is in the context of enrichment in the resolve_old_alert case\r\n1) what does disposable true do?\r\n2) how does the enrichment rule work if you don't have an alert in the trigger?\r\n3) can I call subprocess in trigger interval or other with sending variables (for queried alerts in keep)... | 7b5af458a0afce9a2d7ffd2a651751dc2694dde3 | {
"head_commit": "8e12c68430c711152883c0bd7afb9e06b95af5e2",
"head_commit_message": "Update enrichment.mdx\n\nSigned-off-by: Adilbek Kangerey <adilbekq@halykbank.kz>",
"patch_to_review": "diff --git a/docs/workflows/syntax/enrichment.mdx b/docs/workflows/syntax/enrichment.mdx\nindex 05231d3efb..73e1859cca 100644\... | [
{
"diff_hunk": "@@ -143,3 +144,134 @@ workflow:\n value: \"{{ results.link }}\"\n \n ```\n+\n+\n+---",
"line": null,
"original_line": 149,
"original_start_line": null,
"path": "docs/workflows/syntax/enrichment.mdx",
"start_line": null,
"text": "@user1:\nThis seems like a duplic... | 535f3c298245412970aab07577110c8b4f38af05 | diff --git a/docs/workflows/syntax/enrichment.mdx b/docs/workflows/syntax/enrichment.mdx
index 05231d3efb..f4e84a983a 100644
--- a/docs/workflows/syntax/enrichment.mdx
+++ b/docs/workflows/syntax/enrichment.mdx
@@ -21,6 +21,7 @@ Keep workflows support **enrichment**, a powerful feature that allows you to enh
The `enri... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "Documentation Updates"
} |
All-Hands-AI__OpenHands-5749@098e470 | All-Hands-AI/OpenHands | Python | 5,749 | Fix issue #5748: Rename "Ran a Jupyter Command" to "Ran a Python Command" in UI | This pull request fixes #5748.
The issue has been successfully resolved. The AI agent made the following changes:
1. Located the text in the `JupytrerCellInput` component within the frontend code
2. Changed the display text from "EXECUTE" to "Ran a Python Command" to better reflect that it's running generic Python co... | 2024-12-22T18:16:07Z | Rename "Ran a Jupyter Command" to "Ran a Python Command" in UI
**Summary**
People associate "Jupyter" strongly with data science, so it'd be better to change the UI to say "Ran a Python Command" to indicate that it's running generic commands. | [OpenHands](https://github.com/All-Hands-AI/OpenHands) started fixing the issue! You can monitor the progress [here](https://github.com/All-Hands-AI/OpenHands/actions/runs/12456563483).
A potential fix has been generated and a draft PR #5749 has been created. Please review the changes. | [
{
"body": "**Summary**\r\n\r\nPeople associate \"Jupyter\" strongly with data science, so it'd be better to change the UI to say \"Ran a Python Command\" to indicate that it's running generic commands.",
"number": 5748,
"title": "Rename \"Ran a Jupyter Command\" to \"Ran a Python Command\" in UI"
}
] | b51dd3bc75c73e79e978b1bb3eb734e9da453134 | {
"head_commit": "098e4704f0b2a28e3e9cb6f43875019567f0d3bc",
"head_commit_message": "Fix pr #5749: Fix issue #5748: Rename \"Ran a Jupyter Command\" to \"Ran a Python Command\" in UI",
"patch_to_review": "diff --git a/evaluation/benchmarks/swe_bench/scripts/eval/summarize_outputs.py b/evaluation/benchmarks/swe_be... | [
{
"diff_hunk": "@@ -8,7 +8,7 @@ interface JupytrerCellInputProps {\n export function JupytrerCellInput({ code }: JupytrerCellInputProps) {\n return (\n <div className=\"rounded-lg bg-gray-800 dark:bg-gray-900 p-2 text-xs\">\n- <div className=\"mb-1 text-gray-400\">EXECUTE</div>\n+ <div className... | 041f73f6ffd581aff3bae9fb4b0bb2b4f2c56646 | diff --git a/evaluation/benchmarks/swe_bench/scripts/eval/summarize_outputs.py b/evaluation/benchmarks/swe_bench/scripts/eval/summarize_outputs.py
index f08ee73eee8a..f2fc46095db4 100755
--- a/evaluation/benchmarks/swe_bench/scripts/eval/summarize_outputs.py
+++ b/evaluation/benchmarks/swe_bench/scripts/eval/summarize_... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Code Refactoring / Architectural Improvement"
} |
conan-io__conan-16573@9d313f6 | conan-io/conan | Python | 16,573 | Ensure msvc cppstd compatibility fallback does not ignore 194 binaries | Changelog: Bugfix: Ensure msvc cppstd compatibility fallback does not ignore 194 binaries.
Docs: Omit
This is one of the alternatives, another one might be to test each factor in isolation too?
Closes https://github.com/conan-io/conan/issues/16564 | 2024-06-30T21:21:52Z | [question] How to disable compatilibity?
### What is your question?
Hi,
I'm trying to switch from C++17 to C++20. I'm using
```
core.package_id:default_embed_mode=full_mode
core.package_id:default_non_embed_mode=full_mode
core.package_id:default_unknown_mode=full_mode
```
I've noticed that conan assumes that ... | Hi @Nekto89 thanks a lot for your question.
The main idea behind the compatibility plugin is to allow users to modify it as needed.
While individual recipes can disable the default compatibility checks by using the `extensions_properties` attribute ([docs here](https://docs.conan.io/2/reference/conanfile/attribut... | [
{
"body": "### What is your question?\n\nHi,\r\n\r\nI'm trying to switch from C++17 to C++20. I'm using\r\n```\r\ncore.package_id:default_embed_mode=full_mode\r\ncore.package_id:default_non_embed_mode=full_mode\r\ncore.package_id:default_unknown_mode=full_mode\r\n```\r\nI've noticed that conan assumes that bina... | 9b4033284c1d4c40270be64c2eed3d85e1d4d454 | {
"head_commit": "9d313f632cd283fc18d1f14467d3b02007ff88a9",
"head_commit_message": "More general test, each combination of factors will now be tested",
"patch_to_review": "diff --git a/conans/client/graph/compatibility.py b/conans/client/graph/compatibility.py\nindex a23669c8870..81052537247 100644\n--- a/conans... | [
{
"diff_hunk": "@@ -68,7 +68,7 @@ def cppstd_compat(conanfile):\n comb = comb.copy()\n comb.update(f)\n new_combinations.append(comb)",
"line": null,
"original_line": 70,
"original_start_line": 68,
"path": "conans/client/graph/compatibility.py",
... | 89424f0940dfa14c15ecfa6d917923739b07e370 | diff --git a/conans/client/graph/compatibility.py b/conans/client/graph/compatibility.py
index a23669c8870..7805878c2cd 100644
--- a/conans/client/graph/compatibility.py
+++ b/conans/client/graph/compatibility.py
@@ -65,10 +65,10 @@ def cppstd_compat(conanfile):
new_combinations = []
for comb in combi... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Dependency Updates & Env Compatibility"
} |
conan-io__conan-16594@e5300de | conan-io/conan | Python | 16,594 | Quote build_args in conan graph build-order | Changelog: Fix: Quote `build_args` in `conan graph build-order -f=json` to avoid issues with options with spaces.
Changelog: Bugfix: `build_args` options in `graph build-order` now respect the context of the reference.
Docs: Omit
Closes https://github.com/conan-io/conan/issues/16593
| 2024-07-03T10:11:33Z | [bug] In build-order.json, build_args is wrong when options have whitespaces
### Describe the bug
conan version: 2.4.1
conan profile:
```
[settings]
arch=x86_64
build_type=Release
compiler=gcc
compiler.cppstd=gnu17
compiler.libcxx=libstdc++11
compiler.version=12
os=Linux
```
Description:
I am trying... | Hi @jeremy-coulon thanks a lot for taking the time to report the issue.
While it is true that Conan silently spliting the args is not quite expected without even a warning.
If I change
`boost/*:extra_b2_flags=define=BOOST_LOG_USE_STD_REGEX ... define=BOOST_USE_WINAPI_VERSION=0x0A00`
with
`boost/*:extra_b2_flags... | [
{
"body": "### Describe the bug\n\nconan version: 2.4.1\r\nconan profile:\r\n```\r\n[settings]\r\narch=x86_64\r\nbuild_type=Release\r\ncompiler=gcc\r\ncompiler.cppstd=gnu17\r\ncompiler.libcxx=libstdc++11\r\ncompiler.version=12\r\nos=Linux\r\n```\r\n\r\nDescription: \r\n\r\nI am trying to build `boost/1.82.0` pa... | e25b357d6eab29fcb64ee04340f2d0d479ea09bf | {
"head_commit": "e5300de00c7bef36b7327a26bde1ae9bf95a025e",
"head_commit_message": "Another approach?",
"patch_to_review": "diff --git a/conans/client/graph/install_graph.py b/conans/client/graph/install_graph.py\nindex 65befe30de1..9acce95d924 100644\n--- a/conans/client/graph/install_graph.py\n+++ b/conans/cli... | [
{
"diff_hunk": "@@ -29,10 +29,14 @@ def dumps(self, scope=None):\n if self._value is None:\n return None\n important = \"!\" if self.important else \"\"\n+ value = self._value\n+ if \" \" in value:\n+ value = value.replace('\"', r'\\\"')\n+ value =... | 2962766ec2d0a75999b42520eda5b34913c99eae | diff --git a/conans/client/graph/install_graph.py b/conans/client/graph/install_graph.py
index d51f9082c8f..cc7db6587c2 100644
--- a/conans/client/graph/install_graph.py
+++ b/conans/client/graph/install_graph.py
@@ -1,5 +1,6 @@
import json
import os
+import shlex
import textwrap
from conan.api.output import Cona... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
keephq__keep-2877@070edd1 | keephq/keep | Python | 2,877 | feat: Add deduplication rules provisioning mechanism from KEEP_DEDUPLICATION_RULES env variable | <!--
Thanks for creating this pull request 🤗
Please make sure that the pull request is limited to one type (docs, feature, etc.) and keep it as small as possible. You can open multiple prs instead of opening a huge one.
-->
<!-- If this pull request closes an issue, please mention the issue number below -->
... | 2024-12-22T17:44:43Z | [➕ Feature]: Create Deduplication rule on provision
**Is your feature request related to a problem? Please describe.**
I'm trying to set up Keep using as much IaC as possible, and it's only possible to create dedupe rules in the console or the API. It'd be great for my use case if they could be set up via configuratio... | @fues-joe1 We have a terraform module contributed by the amazing @pehlicd, but it's not too maintained, we need to pick it up: https://github.com/pehlicd/terraform-provider-keep
I'll take care of provisioning for deduplication rules for now
Hi!
I have implemented this feature and added documentation. Details in PR - ... | [
{
"body": "**Is your feature request related to a problem? Please describe.**\r\nI'm trying to set up Keep using as much IaC as possible, and it's only possible to create dedupe rules in the console or the API. It'd be great for my use case if they could be set up via configuration.\r\n\r\n**Describe the soluti... | c5ee5297438723fcc06428c4d44fbfc8812b482e | {
"head_commit": "070edd17f295b09b2de8ec7375b195cf2c7e9674",
"head_commit_message": "adjust configuration",
"patch_to_review": "diff --git a/docs/deployment/provision/overview.mdx b/docs/deployment/provision/overview.mdx\nindex 7d6226f6ab..290030d952 100644\n--- a/docs/deployment/provision/overview.mdx\n+++ b/doc... | [
{
"diff_hunk": "@@ -231,7 +230,8 @@\n \"deployment/provision/overview\",\n \"deployment/provision/provider\",\n \"deployment/provision/workflow\",\n- \"deployment/provision/dashboard\"\n+ \"deployment/provision/dashboard\",\n+ \"deployment/pro... | f2e028c9bb378e81ee10519bb34b71932456aacd | diff --git a/docs/deployment/provision/overview.mdx b/docs/deployment/provision/overview.mdx
index 7d6226f6ab..290030d952 100644
--- a/docs/deployment/provision/overview.mdx
+++ b/docs/deployment/provision/overview.mdx
@@ -8,10 +8,11 @@ Keep supports various deployment and provisioning strategies to accommodate diff
... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
conan-io__conan-16454@d43ae33 | conan-io/conan | Python | 16,454 | [profiles] Raising an error if any profile sections are duplicated | Changelog: Feature: Raising a ConanException if any section is duplicated in the same Conan profile file.
Docs: omit
Closes: https://github.com/conan-io/conan/issues/16448
| 2024-06-10T14:15:14Z | [bug] profile include() does not work with os=Linux
### Describe the bug
(conan 2.4.0, on linux)
I have a base profile, `base-linux`:
```
[settings]
arch=x86_64
os=Linux
```
I have another profile, `base-clang`:
```
include(base-linux)
[settings]
compiler=clang
compiler.libcxx=libstdc++11
compiler... | Hi @paulharris - Thanks for reporting this 😁
I do not get to reproduce the issue. It's working well on my side. Do you have another file named `base-linux` in your Conan v2 home profile? If I put an empty `base-linux` in the Conan profiles folder: `/Users/conan/.conan2/profiles/base-linux`, then the behavior is th... | [
{
"body": "### Describe the bug\r\n\r\n(conan 2.4.0, on linux)\r\n\r\n\r\nI have a base profile, `base-linux`:\r\n```\r\n[settings]\r\narch=x86_64\r\nos=Linux\r\n```\r\n\r\nI have another profile, `base-clang`:\r\n```\r\ninclude(base-linux)\r\n[settings]\r\ncompiler=clang\r\ncompiler.libcxx=libstdc++11\r\ncompi... | ad97c32e65650d5310d435a347d55031634e568f | {
"head_commit": "d43ae33778d6ae02a41c58cc4f074c2a62a776aa",
"head_commit_message": "Added extra warning if sections are duplicated in the same profile file",
"patch_to_review": "diff --git a/conans/client/profile_loader.py b/conans/client/profile_loader.py\nindex cc4763fba8e..8ac2617bdc1 100644\n--- a/conans/cli... | [
{
"diff_hunk": "@@ -263,7 +263,10 @@ def get_profile(profile_text, base_profile=None):\n \"options\", \"conf\", \"buildenv\", \"runenv\",\n \"replace_requires\", \"replace_tool_requires\",\n ... | daa7a448b84c7d230a09dc0a71dd01b55339fd27 | diff --git a/conans/client/profile_loader.py b/conans/client/profile_loader.py
index cc4763fba8e..c532e6b6912 100644
--- a/conans/client/profile_loader.py
+++ b/conans/client/profile_loader.py
@@ -263,7 +263,6 @@ def get_profile(profile_text, base_profile=None):
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
All-Hands-AI__OpenHands-5604@801b134 | All-Hands-AI/OpenHands | Python | 5,604 | Use LLM APIs responses in token counting | **End-user friendly description of the problem this fixes or functionality that this introduces**
- [ ] Include this change in the Release Notes. If checked, you must provide an **end-user friendly** description for your change below
---
**Give a summary of what the PR does, explaining any non-trivial design dec... | 2024-12-14T20:25:22Z | Feat: make use of litellm's response "usage" data
**What problem or use case are you trying to solve?**
**TASK**
We want to enhance our get_token_count() implementation in llm.py, to take advantage of the token counts we are provided from our dependencies, if available, and only fallback to count them if they are not... | This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.
This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.
This issue is stale because it has been op... | [
{
"body": "**What problem or use case are you trying to solve?**\n\n**TASK**\n\nWe want to enhance our get_token_count() implementation in llm.py, to take advantage of the token counts we are provided from our dependencies, if available, and only fallback to count them if they are not already available.\n\nRead... | 70b21d16bd97ed98617ce0d97239123c4029040a | {
"head_commit": "801b134c7f73eefed6266879a79c8133ed673c5f",
"head_commit_message": "fix tests",
"patch_to_review": "diff --git a/openhands/core/message_utils.py b/openhands/core/message_utils.py\nindex 7683c7c4453c..ce8342c6e6b2 100644\n--- a/openhands/core/message_utils.py\n+++ b/openhands/core/message_utils.py... | [
{
"diff_hunk": "@@ -17,18 +17,31 @@ class ResponseLatency(BaseModel):\n response_id: str\n \n \n+class TokensUsage(BaseModel):",
"line": null,
"original_line": 20,
"original_start_line": null,
"path": "openhands/llm/metrics.py",
"start_line": null,
"text": "@user1:\nMinor nit, but I'... | 9d3f77f5e53be9b996ace2696d11799fb63237f0 | diff --git a/openhands/core/message_utils.py b/openhands/core/message_utils.py
index 7683c7c4453c..1ce4b4f84b81 100644
--- a/openhands/core/message_utils.py
+++ b/openhands/core/message_utils.py
@@ -29,6 +29,7 @@
from openhands.events.observation.error import ErrorObservation
from openhands.events.observation.observa... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
All-Hands-AI__OpenHands-5330@f44ceca | All-Hands-AI/OpenHands | Python | 5,330 | Fix issue #5277: [Bug]: AttributeError: 'EventStreamRuntime' object has no attribute 'sid' if runtime_extra_deps is not None | This pull request fixes #5277.
The issue has been successfully resolved through a logical fix that addresses the root cause of the AttributeError. The original problem occurred because the code was attempting to use `self.log()` (which requires `self.sid`) before the base class initialization that sets `self.sid`.
T... | 2024-11-29T21:37:32Z | [Bug]: AttributeError: 'EventStreamRuntime' object has no attribute 'sid' if runtime_extra_deps is not None
### Is there an existing issue for the same bug?
- [X] I have checked the existing issues.
### Describe the bug and reproduction steps
- in config.toml, add field `runtime_extra_deps = <any dockerfile command>... | [OpenHands](https://github.com/All-Hands-AI/OpenHands) started fixing the issue! You can monitor the progress [here](https://github.com/All-Hands-AI/OpenHands/actions/runs/12090780420). | [
{
"body": "### Is there an existing issue for the same bug?\n\n- [X] I have checked the existing issues.\n\n### Describe the bug and reproduction steps\n\n- in config.toml, add field `runtime_extra_deps = <any dockerfile command>` under `[sandbox]`\r\n- set log level to `debug`\r\n- `make run` and start a task\... | 4c432d35e22ca514347ba19b593a3f68eadabd55 | {
"head_commit": "f44cecab0dd3388340e66dbefa9dc3425e298a66",
"head_commit_message": "Fix issue #5277: [Bug]: AttributeError: 'EventStreamRuntime' object has no attribute 'sid' if runtime_extra_deps is not None",
"patch_to_review": "diff --git a/openhands/runtime/impl/eventstream/eventstream_runtime.py b/openhands... | [
{
"diff_hunk": "@@ -66,6 +66,7 @@ pygithub = \"^2.5.0\"\n openhands-aci = \"^0.1.1\"\n python-socketio = \"^5.11.4\"\n redis = \"^5.2.0\"\n+pre-commit = \"^4.0.1\"",
"line": null,
"original_line": 69,
"original_start_line": null,
"path": "pyproject.toml",
"start_line": null,
"text": "@us... | 9ae6c85c6c359f8712dcfe3065d89309faf01af8 | diff --git a/openhands/runtime/impl/eventstream/eventstream_runtime.py b/openhands/runtime/impl/eventstream/eventstream_runtime.py
index 30f78f88a2de..8cedcbe54603 100644
--- a/openhands/runtime/impl/eventstream/eventstream_runtime.py
+++ b/openhands/runtime/impl/eventstream/eventstream_runtime.py
@@ -188,12 +188,6 @@ ... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
All-Hands-AI__OpenHands-5560@1b855d1 | All-Hands-AI/OpenHands | Python | 5,560 | Fix issue #5559: The turn limit should be measured from the last user interaction | This pull request fixes #5559.
The issue has been successfully resolved based on the AI agent's implementation. The solution directly addresses the original problem by:
1. Modifying the `_handle_message_action` method to dynamically extend the max iterations limit by adding the initial_max_iterations value whenever a... | 2024-12-12T16:40:25Z | The turn limit should be measured from the last user interaction
**What problem or use case are you trying to solve?**
OpenHands has a limit on the number of turns the agent can perform before it gets stopped (100 by default), but in long conversations it is frequent to hit this limit.
**Describe the UX of the so... | [OpenHands](https://github.com/All-Hands-AI/OpenHands) started fixing the issue! You can monitor the progress [here](https://github.com/All-Hands-AI/OpenHands/actions/runs/12300523035).
A potential fix has been generated and a draft PR #5560 has been created. Please review the changes. | [
{
"body": "**What problem or use case are you trying to solve?**\r\n\r\nOpenHands has a limit on the number of turns the agent can perform before it gets stopped (100 by default), but in long conversations it is frequent to hit this limit.\r\n\r\n**Describe the UX of the solution you'd like**\r\n\r\nWe should c... | 47169559606a4d2fe3b97e0685f42bfb8d0a4756 | {
"head_commit": "1b855d1c842cf1f0bc891e29b169df86e21989a5",
"head_commit_message": "Fix pr #5560: Fix issue #5559: The turn limit should be measured from the last user interaction",
"patch_to_review": "diff --git a/openhands/controller/agent_controller.py b/openhands/controller/agent_controller.py\nindex 21065f5... | [
{
"diff_hunk": "@@ -18,6 +18,7 @@ class AgentConfig:\n llm_config: The name of the llm config to use. If specified, this will override global llm config.\n use_microagents: Whether to use microagents at all. Default is True.\n disabled_microagents: A list of microagents to disable. Defau... | 6f947a3df7c6401b405099655a4d4f78b2ec0924 | diff --git a/docs/modules/usage/micro-agents.md b/docs/modules/usage/micro-agents.md
index 4bdf69413698..af7893d062b2 100644
--- a/docs/modules/usage/micro-agents.md
+++ b/docs/modules/usage/micro-agents.md
@@ -14,7 +14,7 @@ Micro-agents are defined in markdown files under the `openhands/agenthub/codeact
## Available ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
Subsets and Splits
Review Test Instances
Retrieves basic metadata about code review instances but doesn't provide any analytical insights or patterns beyond raw data access.