instance_id stringlengths 21 53 | repo stringclasses 188
values | language stringclasses 1
value | pull_number int64 20 148k | title stringlengths 6 144 | body stringlengths 0 83.4k | created_at stringdate 2015-09-25 03:17:17 2025-07-10 16:50:35 | problem_statement stringlengths 188 240k | hints_text stringlengths 0 145k | resolved_issues listlengths 1 6 | base_commit stringlengths 40 40 | commit_to_review dict | reference_review_comments listlengths 1 62 | merged_commit stringlengths 40 40 | merged_patch stringlengths 297 9.87M | metadata dict |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
conan-io__conan-16291@913f5f7 | conan-io/conan | Python | 16,291 | Fix stacktrace with nonexistent graph file in `conan list` | Changelog: Bugfix: Fix stacktrace with nonexistent graph file in `conan list`.
Docs: Omit
Closes https://github.com/conan-io/conan/issues/16290 | 2024-05-17T08:47:48Z | [bug] conan list --graph with non-existing file
### Describe the bug
version: 2.3.1
conan_path: D:\venv\Scripts\conan
python
version: 3.9.13
sys_version: 3.9.13 (tags/v3.9.13:6de2ca5, May 17 2022, 16:36:42) [MSC v.1929 64 bit (AMD64)]
sys_executable: D:\venv\Scripts\python.exe
is_frozen: False
archite... | Thanks for the report, we'll make it have a prettier error in these cases | [
{
"body": "### Describe the bug\n\nversion: 2.3.1\r\nconan_path: D:\\venv\\Scripts\\conan\r\npython\r\n version: 3.9.13\r\n sys_version: 3.9.13 (tags/v3.9.13:6de2ca5, May 17 2022, 16:36:42) [MSC v.1929 64 bit (AMD64)]\r\n sys_executable: D:\\venv\\Scripts\\python.exe\r\n is_frozen: False\r\n architecture: ... | 99bd072ab6a76284a65a0150889a936bb64c83e7 | {
"head_commit": "913f5f7d03432a2a7cce308ae66837a87678b182",
"head_commit_message": "Sprinkle some light=True in pkglist tests",
"patch_to_review": "diff --git a/conan/cli/commands/list.py b/conan/cli/commands/list.py\nindex 1fd4a88113d..ccda87aee8b 100644\n--- a/conan/cli/commands/list.py\n+++ b/conan/cli/comman... | [
{
"diff_hunk": "@@ -240,6 +241,8 @@ def list(conan_api: ConanAPI, parser, *args):\n raise ConanException(\"Cannot define lru when loading a graph json file\")\n if args.filter_profile or args.filter_settings or args.filter_options:\n raise ConanException(\"Filtering binaries cann... | c09af33b87595c79f78a5119bd6b75b779796edb | diff --git a/conan/api/model.py b/conan/api/model.py
index 9e23cdfe10e..025e20dd153 100644
--- a/conan/api/model.py
+++ b/conan/api/model.py
@@ -1,5 +1,6 @@
import fnmatch
import json
+import os
from conans.client.graph.graph import RECIPE_EDITABLE, RECIPE_CONSUMER, RECIPE_PLATFORM, \
RECIPE_VIRTUAL, BINARY_S... | {
"difficulty": "low",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
keephq__keep-2871@3f422e3 | keephq/keep | Python | 2,871 | feat: Add infra for cleaning up providers when deleted | <!--
Thanks for creating this pull request 🤗
Please make sure that the pull request is limited to one type (docs, feature, etc.) and keep it as small as possible. You can open multiple prs instead of opening a huge one.
-->
<!-- If this pull request closes an issue, please mention the issue number below -->
... | 2024-12-18T16:10:14Z | Deleting a provider does not clean up the changes on the infrastructure
**Is your feature request related to a problem? Please describe.**
The delete provider option does not undo the changes or recommends you info about how to undo them. Say you add subscriptions to your sns topics, they will stay there and keep send... | [
{
"body": "**Is your feature request related to a problem? Please describe.**\r\nThe delete provider option does not undo the changes or recommends you info about how to undo them. Say you add subscriptions to your sns topics, they will stay there and keep sending data to keep.\r\n\r\n**Describe the solution yo... | ec8db0e1bde051bfd6f9a2e493ef7e60342ad8ca | {
"head_commit": "3f422e3b583ca79a6a555172960f74257489273a",
"head_commit_message": "Log original exception when cleaning up fails",
"patch_to_review": "diff --git a/keep/contextmanager/contextmanager.py b/keep/contextmanager/contextmanager.py\nindex 2dad2563b7..9ec99ed9b5 100644\n--- a/keep/contextmanager/contex... | [
{
"diff_hunk": "@@ -227,34 +227,49 @@ def update_provider(\n def delete_provider(\n tenant_id: str, provider_id: str, session: Session, allow_provisioned=False\n ):\n- provider = session.exec(\n+ provider_model: Provider = session.exec(\n select(Provider).where(\n ... | 4c9b0e630b634fea13259863853f34c324ee5e7a | diff --git a/keep/contextmanager/contextmanager.py b/keep/contextmanager/contextmanager.py
index 018b4e2044..3283ea5065 100644
--- a/keep/contextmanager/contextmanager.py
+++ b/keep/contextmanager/contextmanager.py
@@ -5,6 +5,7 @@
import json5
from pympler.asizeof import asizeof
+from keep.api.core.config import co... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} | |
All-Hands-AI__OpenHands-5493@9aa1429 | All-Hands-AI/OpenHands | Python | 5,493 | refactor: move session initialization from WebSocket to REST API | Currently the frontend starts a session by connecting to the websocket and then sending an INIT event with initialization data. This PR changes that to use a REST API endpoint instead.
### Changes
- Add POST /api/conversation endpoint for session initialization
- Update frontend to use new endpoint instead of WebS... | 2024-12-09T21:59:20Z | Store session ID as a URI param instead of in-memory
**Motivation**
Storing the token as a URI param will make it much more manageable and easier to access (React Router / Remix has a hook `useSearchParams` that can do just that) throughout the app rather than relying on local storage.
**Technical Design**
When a ... | This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days. | [
{
"body": "**Motivation**\r\nStoring the token as a URI param will make it much more manageable and easier to access (React Router / Remix has a hook `useSearchParams` that can do just that) throughout the app rather than relying on local storage.\r\n\r\n**Technical Design**\r\nWhen a new session is created, st... | 0dd919bacf10677f8885e78aef43259251334202 | {
"head_commit": "9aa1429e66b5997bb5b318acdd7a6e6eed1d48d2",
"head_commit_message": "fix: use useMemo for conversation context value",
"patch_to_review": "diff --git a/frontend/__tests__/components/browser.test.tsx b/frontend/__tests__/components/browser.test.tsx\nindex eea2eb910a48..48a3acf9ba67 100644\n--- a/fr... | [
{
"diff_hunk": "",
"line": null,
"original_line": null,
"original_start_line": null,
"path": "frontend/src/i18n/en.ts",
"start_line": null,
"text": "@user1:\nThis looks like it is misplaced"
},
{
"diff_hunk": "@@ -57,21 +64,37 @@ export const TaskForm = React.forwardRef<HTMLFormE... | 9e9e308c86238cacab59be43d6bdc3bb87e1dd5e | diff --git a/README.md b/README.md
index 1193095623d1..d17325e6f22e 100644
--- a/README.md
+++ b/README.md
@@ -71,6 +71,14 @@ or run it on tagged issues with [a github action](https://github.com/All-Hands-A
Visit [Installation](https://docs.all-hands.dev/modules/usage/installation) for more information and setup ins... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
conan-io__conan-16069@575c858 | conan-io/conan | Python | 16,069 | Improve error messages for invalid version ranges operators | Changelog: Fix: Improve the definition of version ranges UX with better error message for invalid ``==, ~=, ^=`` operators.
Docs: Omit
Close https://github.com/conan-io/conan/issues/16066 | 2024-04-11T15:12:07Z | [bug] Exact version range `[==...]` not working anymore with conan2
### Describe the bug
Hello,
I'm currently in the process of upgrading recipes from conan1 to conan 2 and I found out that `package/[==1.0.0]` is no longer working with conan2 (but I couldn't find anything about that in the doc) and conan doesn't thro... | Hi @araffin
Thanks for pointing this out.
The truth is that Conan 1 never intended to support ``[==version]`` syntax, for example the docs in https://docs.conan.io/1/versioning/version_ranges.html doesn't describe this syntax. Furthermore the https://github.com/podhmo/python-node-semver doesn't explicitly mentio... | [
{
"body": "### Describe the bug\n\nHello,\r\nI'm currently in the process of upgrading recipes from conan1 to conan 2 and I found out that `package/[==1.0.0]` is no longer working with conan2 (but I couldn't find anything about that in the doc) and conan doesn't throw an error like for `[~=1.0]` which is now ex... | 52f2435b4217a35886f9bfa5140f8f6e7e0a7409 | {
"head_commit": "575c8588359d55fff0d2e6b5d76148b359c490fe",
"head_commit_message": "wip",
"patch_to_review": "diff --git a/conans/model/version_range.py b/conans/model/version_range.py\nindex 97778f68cf6..83aeb7c745e 100644\n--- a/conans/model/version_range.py\n+++ b/conans/model/version_range.py\n@@ -88,6 +88,8... | [
{
"diff_hunk": "@@ -88,6 +88,8 @@ def _parse_expression(expression):\n if expression[1] == \"=\":\n operator += \"=\"\n index = 2\n+ elif expression[1] == \"=\":\n+ raise ConanException(f\"Invalid version range operator '{operator}=' in {expression}\... | ad5df824471b8d4f89711989c30c891eb807f984 | diff --git a/conans/model/version_range.py b/conans/model/version_range.py
index 97778f68cf6..751683e3e73 100644
--- a/conans/model/version_range.py
+++ b/conans/model/version_range.py
@@ -88,6 +88,8 @@ def _parse_expression(expression):
if expression[1] == "=":
operator += "="
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
conan-io__conan-16073@9926b0b | conan-io/conan | Python | 16,073 | Package vendor new feature | Changelog: Feature: New ``vendor=True`` package creation and build isolation strategy
Docs: https://github.com/conan-io/docs/pull/3756
Close https://github.com/conan-io/conan/issues/13171 | 2024-04-12T11:54:35Z | [feature] Consider the re-package concept
### What is your suggestion?
When a package, that is built using artifacts from other packages, can be built, but completely isolating the transitive dependencies. For consumers of that package, the transitive dependencies will not exist.
This might be a useful mechanism fo... | [
{
"body": "### What is your suggestion?\n\nWhen a package, that is built using artifacts from other packages, can be built, but completely isolating the transitive dependencies. For consumers of that package, the transitive dependencies will not exist.\r\n\r\nThis might be a useful mechanism for releasing, both... | 6d4118aa7e4e515629b2be8f5b0da16f07dfd8b2 | {
"head_commit": "9926b0bc2b23ef0a17c4c773687c7150d9aefd60",
"head_commit_message": "avoid propagate options",
"patch_to_review": "diff --git a/conan/cli/commands/create.py b/conan/cli/commands/create.py\nindex fe16deaf019..13fa6d337e5 100644\n--- a/conan/cli/commands/create.py\n+++ b/conan/cli/commands/create.py... | [
{
"diff_hunk": "@@ -156,6 +158,8 @@ def check_downstream_exists(self, require):\n \n # Seems the algrithm depth-first, would only have 1 dependant at most to propagate down\n # at any given time\n+ if self.conanfile.vendor:\n+ return result",
"line": null,
"original_lin... | e13037c7150f39103b65704ed09a56236f6f5859 | diff --git a/conan/cli/commands/create.py b/conan/cli/commands/create.py
index fe16deaf019..13fa6d337e5 100644
--- a/conan/cli/commands/create.py
+++ b/conan/cli/commands/create.py
@@ -95,6 +95,9 @@ def create(conan_api, parser, *args):
else:
requires = [ref] if not is_build else None
tool_requir... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
All-Hands-AI__OpenHands-4818@f906274 | All-Hands-AI/OpenHands | Python | 4,818 | fix(frontend): Fix Jupyter tab overflow | **End-user friendly description of the problem this fixes or functionality that this introduces**
If there was a really long and single line input/output, it would stretch the container all the way and overflow!
- [ ] Include this change in the Release Notes. If checked, you must provide an **end-user friendly** de... | 2024-11-07T13:38:25Z | [Bug]: if Jupyter Shell output has a long single line output, the UI container grows too wide and goes offscreen
### Is there an existing issue for the same bug?
- [X] I have checked the existing issues.
### Describe the bug and reproduction steps
To repro:
- Make the agent run a python script in the jupyter shell ... | Yep we've definitely seen the Jupyter tab act weird. Thanks for opening this issue! | [
{
"body": "### Is there an existing issue for the same bug?\n\n- [X] I have checked the existing issues.\n\n### Describe the bug and reproduction steps\n\nTo repro:\r\n- Make the agent run a python script in the jupyter shell that outputs a really long line\r\n- Hint, maybe have a raw file with a single extra ... | 0335b1a63494d1ead922d272615b02bcfcd10d7b | {
"head_commit": "f906274cabc1daf8323f469decbe54c979274a6a",
"head_commit_message": "Fix jupyter overflow",
"patch_to_review": "diff --git a/frontend/src/components/Jupyter.tsx b/frontend/src/components/Jupyter.tsx\nindex 26e33a77de18..23eafde69101 100644\n--- a/frontend/src/components/Jupyter.tsx\n+++ b/frontend... | [
{
"diff_hunk": "@@ -88,9 +96,9 @@ function JupyterEditor(): JSX.Element {\n useScrollToBottom(jupyterRef);\n \n return (\n- <div className=\"flex-1\">\n+ <div className=\"flex-1 h-full w-full\" style={{ maxWidth }}>\n <div\n- className=\"overflow-y-auto h-full\"\n+ className=\"ov... | d345a98bef0a24d069cde5f23421c1a2cca05b33 | diff --git a/frontend/src/components/Jupyter.tsx b/frontend/src/components/Jupyter.tsx
index 26e33a77de18..4220e12a39b3 100644
--- a/frontend/src/components/Jupyter.tsx
+++ b/frontend/src/components/Jupyter.tsx
@@ -25,7 +25,11 @@ function JupyterCell({ cell }: IJupyterCell): JSX.Element {
className="scrollba... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
All-Hands-AI__OpenHands-4740@365498f | All-Hands-AI/OpenHands | Python | 4,740 | Fix issue #4739: '[Bug]: The agent doesn'"'"'t know its name' | **End-user friendly description of the problem this fixes or functionality that this introduces**
- [ ] Include this change in the Release Notes. If checked, you must provide an **end-user friendly** description for your change below
---
**Give a summary of what the PR does, explaining any non-trivial design dec... | 2024-11-04T20:32:26Z | [Bug]: The agent doesn't know its name
### Is there an existing issue for the same bug?
- [X] I have checked the existing issues.
### Describe the bug and reproduction steps
When asking the agent to push to github, it will often do the following, because it doesn't know what its name is supposed to be. We should pro... | We can achieve this by adding a description with the name OpenHands Agent" and email "[openhands@all-hands.dev](mailto:openhands@all-hands.dev)" to the system message in `openhands/agenthub/codeact_agent/function_calling.py`
OpenHands started fixing the issue! You can monitor the progress [here](https://github.com/All-... | [
{
"body": "### Is there an existing issue for the same bug?\n\n- [X] I have checked the existing issues.\n\n### Describe the bug and reproduction steps\n\nWhen asking the agent to push to github, it will often do the following, because it doesn't know what its name is supposed to be. We should probably tell the... | ba25b02978dac9da920a8b4bff2deee739ae988f | {
"head_commit": "365498f2ee5fff5b76e9d1dd28af1ec1671b58e7",
"head_commit_message": "minor tweak to system message",
"patch_to_review": "diff --git a/docs/i18n/fr/docusaurus-plugin-content-docs/current/usage/how-to/evaluation-harness.md b/docs/i18n/fr/docusaurus-plugin-content-docs/current/usage/how-to/evaluation... | [
{
"diff_hunk": "@@ -25,9 +25,10 @@\n )\n from openhands.events.tool import ToolCallMetadata\n \n-SYSTEM_PROMPT = \"\"\"You are a helpful assistant that can interact with a computer to solve tasks.\n+SYSTEM_PROMPT = \"\"\"You are OpenHands agent, a helpful AI assistant that can interact with a computer to solve ... | 296b15e18c96fd534aeed27c15471adfdbefa3f5 | diff --git a/docs/i18n/fr/docusaurus-plugin-content-docs/current/usage/how-to/evaluation-harness.md b/docs/i18n/fr/docusaurus-plugin-content-docs/current/usage/how-to/evaluation-harness.md
index d027a0ead929..785112ed6ea0 100644
--- a/docs/i18n/fr/docusaurus-plugin-content-docs/current/usage/how-to/evaluation-harness.m... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
keephq__keep-2661@ced3ca4 | keephq/keep | Python | 2,661 | fix: improve topology ux | <!--
Thanks for creating this pull request 🤗
Please make sure that the pull request is limited to one type (docs, feature, etc.) and keep it as small as possible. You can open multiple prs instead of opening a huge one.
-->
<!-- If this pull request closes an issue, please mention the issue number below -->
... | 2024-11-27T05:55:06Z | [🐛 Bug]: Topology page issues
1. When hovering over an item in topology view, if there's no space in the bottom, open the hover card up
2. Replace number of firing alerts (which could be big) with number of incidents associated with this service (more interesting)
3. We can add more context based on the category of ... | [
{
"body": "1. When hovering over an item in topology view, if there's no space in the bottom, open the hover card up\r\n2. Replace number of firing alerts (which could be big) with number of incidents associated with this service (more interesting)\r\n3. We can add more context based on the category of the serv... | b73c1ea824e36b36a586a85ee08847204cb3178d | {
"head_commit": "ced3ca4d8ef82ec223756674ba10ae9a940a2e45",
"head_commit_message": "fix: build",
"patch_to_review": "diff --git a/keep-ui/app/(keep)/topology/ui/map/service-node.tsx b/keep-ui/app/(keep)/topology/ui/map/service-node.tsx\nindex 41560005b3..d1b840a50b 100644\n--- a/keep-ui/app/(keep)/topology/ui/ma... | [
{
"diff_hunk": "@@ -73,34 +72,52 @@ function ServiceDetailsTooltip({ data }: { data: TopologyService }) {\n }\n \n export function ServiceNode({ data, selected }: NodeProps<ServiceNodeType>) {\n- const { useAllAlerts } = useAlerts();\n- const { data: alerts, mutate } = useAllAlerts(\"feed\");\n- const { data... | 3415019421d2e6b6351d914b75bd1a01f91c2e22 | diff --git a/keep-ui/app/(keep)/topology/model/models.ts b/keep-ui/app/(keep)/topology/model/models.ts
index 2d4c75a327..c6d9277f72 100644
--- a/keep-ui/app/(keep)/topology/model/models.ts
+++ b/keep-ui/app/(keep)/topology/model/models.ts
@@ -26,6 +26,7 @@ export interface TopologyService {
application_ids: string[]... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
conan-io__conan-15842@9b223ef | conan-io/conan | Python | 15,842 | Don't break on empty patch list for version in conandata.yml (#15841) | Changelog: Bugfix: Avoid TypeError when a version in conandata.yml lists no patches.
Docs: Omit
(#15841)
- [x] Refer to the issue that supports this Pull Request.
- [ ] If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
- [x] I've read the [Contributing guide]... | 2024-03-08T20:53:01Z | [bug] Breakage when all patches in conandata.yml are commented out
### Environment details
* Operating System+version: RHEL 8
* Compiler+version: N/A
* Conan version: Git
* Python version: 3.11.5
### Steps to reproduce
I was testing out various permutations of a Conan package build. At one point, I commented ou... | [
{
"body": "### Environment details\n\n* Operating System+version: RHEL 8\r\n* Compiler+version: N/A\r\n* Conan version: Git\r\n* Python version: 3.11.5\r\n\n\n### Steps to reproduce\n\nI was testing out various permutations of a Conan package build. At one point, I commented out all the patches listed for the v... | 825353df37c99928894e902559f6ec4cb429570d | {
"head_commit": "9b223ef0e0290cf7a37ee2563160f6cd4cc60b8f",
"head_commit_message": "Don't break on empty patch list for version in conandata.yml (#15841)",
"patch_to_review": "diff --git a/conan/tools/files/patches.py b/conan/tools/files/patches.py\nindex d3e48d62f53..2add350bac5 100644\n--- a/conan/tools/files/... | [
{
"diff_hunk": "@@ -127,6 +130,9 @@ def export_conandata_patches(conanfile):\n if isinstance(patches, dict):\n assert conanfile.version, \"Can only be exported if conanfile.version is already defined\"\n entries = patches.get(conanfile.version, [])\n+ if entries is None:\n+ ... | e3892184057606927c9cab3a76501118d6c8bb7d | diff --git a/conan/tools/files/patches.py b/conan/tools/files/patches.py
index d3e48d62f53..f3274f83f62 100644
--- a/conan/tools/files/patches.py
+++ b/conan/tools/files/patches.py
@@ -88,6 +88,9 @@ def apply_conandata_patches(conanfile):
if isinstance(patches, dict):
assert conanfile.version, "Can only b... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} | |
keephq__keep-2587@07ddcd0 | keephq/keep | Python | 2,587 | fix: feed counter | <!--
Thanks for creating this pull request 🤗
Please make sure that the pull request is limited to one type (docs, feature, etc.) and keep it as small as possible. You can open multiple prs instead of opening a huge one.
-->
<!-- If this pull request closes an issue, please mention the issue number below -->
... | 2024-11-24T08:06:59Z | [🐛 Bug]: Feed counter is not updating
**Describe the bug**
Feed counter is not reflecting an update without a page reload.
**To Reproduce**
Steps to reproduce the behavior:
1. Open 1 tab of keep-ui any page, (e.g. /alerts/feed)
2. Open/settings?selectedTab=webhook
3. Click `Click to create an example Alert`... | <!-- Answer -->
I found a similar open issue titled "[Feed preset counter is not updating](https://github.com/keephq/keep/issues/1164)" which was last updated on October 02, 2024 <sup>[[1]](https://github.com/keephq/keep/issues/1164)</sup>.
The issue with the feed counter not updating without a page reload could indee... | [
{
"body": "**Describe the bug**\r\nFeed counter is not reflecting an update without a page reload.\r\n\r\n**To Reproduce**\r\nSteps to reproduce the behavior:\r\n\r\n1. Open 1 tab of keep-ui any page, (e.g. /alerts/feed) \r\n2. Open/settings?selectedTab=webhook\r\n3. Click `Click to create an example Alert` but... | 4463c01b89e1e33182213c48743bcbcd21047f67 | {
"head_commit": "07ddcd024b6e107ca5cc8028d2b9efff8a6137bf",
"head_commit_message": "wip: revalidate presets which are updated via `async-presets`\n\n(cherry picked from commit f817864033d7e57698cf5d4e1e632a2e14587772)",
"patch_to_review": "diff --git a/keep-ui/utils/hooks/usePresets.ts b/keep-ui/utils/hooks/useP... | [
{
"diff_hunk": "@@ -2634,6 +2634,11 @@ def get_all_presets(tenant_id: str) -> List[Preset]:\n )\n return presets\n \n+# \n+def get_db_and_static_presets_dtos(tenant_id: str) -> List[PresetDto]:",
"line": null,
"original_line": 2638,
"original_start_line": null,
"path": "keep/api/core... | 9bc29c26218bb0703c087585fa1da74c315208fa | diff --git a/keep-ui/app/(keep)/topology/api/index.ts b/keep-ui/app/(keep)/topology/api/index.ts
index 2d4e3b7f54..5736af7b90 100644
--- a/keep-ui/app/(keep)/topology/api/index.ts
+++ b/keep-ui/app/(keep)/topology/api/index.ts
@@ -2,19 +2,16 @@ import { fetcher } from "@/utils/fetcher";
import { Session } from "next-a... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
conan-io__conan-15914@98b9e18 | conan-io/conan | Python | 15,914 | feat: Add CONAN_RUNTIME_LIB_DIRS to the conan_toolchain.cmake | Changelog: Feature: Add `CONAN_RUNTIME_LIB_DIRS` variable to the `conan_toolchain.cmake`.
Docs: https://github.com/conan-io/docs/pull/3698
Close: #15810 | 2024-03-21T17:12:38Z | [feature] CMakeToolchain: add a variable with all runtime library directories
### What is your suggestion?
In a consumer CMake project, I would like Conan to provide me with a variable to be able to call either:
* `install(RUNTIME_DEPENDENCY_SET ...)`
* `file(GET_RUNTIME_DEPENDENCIES ...`)
example:
```
install(... | [
{
"body": "### What is your suggestion?\n\nIn a consumer CMake project, I would like Conan to provide me with a variable to be able to call either:\r\n* `install(RUNTIME_DEPENDENCY_SET ...)`\r\n* `file(GET_RUNTIME_DEPENDENCIES ...`)\r\n\r\nexample:\r\n```\r\ninstall(TARGETS my_app\r\n DESTINATION ${CMAKE_INS... | 59029095e86eacd402083fca7c308b06889f6301 | {
"head_commit": "98b9e184afb8ff2ae68fa95ad133da4c088155a5",
"head_commit_message": "Fix: hash collision with \"win\" word",
"patch_to_review": "diff --git a/conan/tools/cmake/toolchain/blocks.py b/conan/tools/cmake/toolchain/blocks.py\nindex 36f725ae7c9..0c56193b20e 100644\n--- a/conan/tools/cmake/toolchain/bloc... | [
{
"diff_hunk": "@@ -352,6 +353,85 @@ def generate(self):\n assert \"/path/to/builddir\" in contents\n \n \n+@pytest.mark.skipif(platform.system() != \"Windows\", reason=\"Only Windows\")\n+def test_lib_dirs_windows():\n+ client = TestClient()\n+ conanfile = textwrap.dedent(\"\"\"\n+ from co... | 0ab778d8ae6ba74e7632ce4588c81867e5978874 | diff --git a/conan/tools/cmake/toolchain/blocks.py b/conan/tools/cmake/toolchain/blocks.py
index 36f725ae7c9..63181139a99 100644
--- a/conan/tools/cmake/toolchain/blocks.py
+++ b/conan/tools/cmake/toolchain/blocks.py
@@ -154,7 +154,7 @@ def context(self):
if not config_dict:
return None
- ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
conan-io__conan-15832@30c6c7c | conan-io/conan | Python | 15,832 | fix: need return 3 None on detect_default_compiler() to avoid errors | Changelog: Fix: Make sure `detect_default_compiler()` always returns a 3-tuple.
Docs: Omit
Close: #15712
- [x] Refer to the issue that supports this Pull Request.
- [x] If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
- [x] I've read the [Contributing guide](... | 2024-03-07T14:20:41Z | [bug] Detecting profile crashes
### Environment details
* GhostBSD 24.01.1, FreeBSD jorisp-ghostbsd 14.0-STABLE FreeBSD 14.0-STABLE GENERIC amd64
* /usr/local/bin/clang++15 (15.0.7) /usr/local/bin/gcc12 (12.2.0)
* Conan version: 2.1.0
* Python version: 3.9.18
### Steps to reproduce
`conan profile detect`
### Log... | Thanks for reporting this @jputcu
It seems there is a gap for FreeBSD if it cannot detect the clang compiler:
```python
if platform.system() in ["Darwin", "FreeBSD"]:
clang, clang_version, compiler_exe = _clang_compiler() # prioritize clang
if clang:
return clang, clang_version,... | [
{
"body": "### Environment details\n\n* GhostBSD 24.01.1, FreeBSD jorisp-ghostbsd 14.0-STABLE FreeBSD 14.0-STABLE GENERIC amd64\r\n* /usr/local/bin/clang++15 (15.0.7) /usr/local/bin/gcc12 (12.2.0)\r\n* Conan version: 2.1.0\r\n* Python version: 3.9.18\n\n### Steps to reproduce\n\n`conan profile detect`\n\n### Lo... | a3d4c13b6aafbab028c2aefd14c17a52faad89ee | {
"head_commit": "30c6c7c26adbd47f19061eabcd4101a9cf2b60d5",
"head_commit_message": "fix: need return 3 None on detect_default_compiler() to avoid errors on the call",
"patch_to_review": "diff --git a/conan/internal/api/detect_api.py b/conan/internal/api/detect_api.py\nindex f7449347694..f97c1e95aff 100644\n--- a... | [
{
"diff_hunk": "@@ -397,12 +397,12 @@ def detect_default_compiler():\n clang, clang_version, compiler_exe = _clang_compiler() # prioritize clang\n if clang:\n return clang, clang_version, compiler_exe\n- return",
"line": 400,
"original_line": 400,
"original_start_... | f775c40425b4b3150aeebe1f89f33b97b90023d5 | diff --git a/conan/internal/api/detect_api.py b/conan/internal/api/detect_api.py
index f7449347694..c39a9370e36 100644
--- a/conan/internal/api/detect_api.py
+++ b/conan/internal/api/detect_api.py
@@ -397,12 +397,13 @@ def detect_default_compiler():
clang, clang_version, compiler_exe = _clang_compiler() # pri... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
All-Hands-AI__OpenHands-4138@f5992a9 | All-Hands-AI/OpenHands | Python | 4,138 | Fix issue #4136: 'Restructuring documentation' | - [x] Include this change in the Release Notes. If checked, you must provide an **end-user friendly** description for your change below
**End-user friendly description of the problem this fixes or functionality that this introduces**
Restructure documentation to be in an easier-to-follow format
---
**Give a sum... | 2024-10-01T14:41:38Z | Restructuring documentation
**What problem or use case are you trying to solve?**
It would be best to restructure the OpenHands documentation to make it a bit easier to parse.
This can mostly be done by reordering `sidebars.ts` for now, without changing content.
**Proposal**
Here is a proposal of top-level an... | OpenHands started fixing the issue! You can monitor the progress [here](https://github.com/All-Hands-AI/OpenHands/actions/runs/11127545316).
An attempt was made to automatically fix this issue, but it was unsuccessful. A branch named 'openhands-fix-issue-4136' has been created with the attempted changes. You can view t... | [
{
"body": "**What problem or use case are you trying to solve?**\r\n\r\nIt would be best to restructure the OpenHands documentation to make it a bit easier to parse.\r\nThis can mostly be done by reordering `sidebars.ts` for now, without changing content.\r\n\r\n**Proposal**\r\n\r\nHere is a proposal of top-lev... | ec1a86f150392a3ed2a439e72b2a949f69adc381 | {
"head_commit": "f5992a9dbb1dc81015756044c9732f0ec13b7845",
"head_commit_message": "Remove github actions for now until #4124",
"patch_to_review": "diff --git a/docs/sidebars.ts b/docs/sidebars.ts\nindex 3b4810efe019..2a4420092b62 100644\n--- a/docs/sidebars.ts\n+++ b/docs/sidebars.ts\n@@ -10,17 +10,33 @@ const ... | [
{
"diff_hunk": "@@ -62,48 +83,28 @@ const sidebars: SidebarsConfig = {\n },\n {\n type: 'category',\n- label: 'How-to Guides',\n+ label: 'For OpenHands Developers',\n items: [\n {\n type: 'doc',\n- id: 'usage/how-to/cli-mode',\n- },\n- {\n- ... | d9d7d82a8cac9cd71b0762231943029261cc90af | diff --git a/docs/sidebars.ts b/docs/sidebars.ts
index 396bba809684..23931d0ac850 100644
--- a/docs/sidebars.ts
+++ b/docs/sidebars.ts
@@ -10,44 +10,76 @@ const sidebars: SidebarsConfig = {
},
{
type: 'category',
- label: 'LLMs',
+ label: 'Usage Methods',
items: [
{
... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Documentation Updates"
} |
conan-io__conan-15664@9ea1e79 | conan-io/conan | Python | 15,664 | Switched to cc pattern in compiler detection | Changelog: Fix: Fix gcc detection in conda environments.
Docs: Omit
In a conda environment, the `CC` and `CXX` variables point to /opt/conda/envs/<env name>/bin/x86_64-conda-linux-gnu-cc and /opt/conda/envs/<env name>/bin/x86_64-conda-linux-gnu-c++ and the `command` searched for pattern ends up being /opt/conda/env... | 2024-02-13T21:32:08Z | Conan fails to detect the compiler although `CC` and `CXX` are set
### Environment details
* Operating System+version: ubuntu-22.04
* Compiler+version: 13.1.0
* Conan version: 2.0.9
* Python version: 3.11.4
### Steps to reproduce
I am creating a Conda package of my software, as part of a Github C/I workfl... | Hi @kordejong
It seems that the command ``<compiler> --dumpversion`` is failing in this setup. Could you please execute the command and paste here the output?
The relevant code is:
```python
ret, out = detect_runner('%s -dumpversion' % compiler_exe)
if ret != 0:
return None
compiler = "gcc"
installed_v... | [
{
"body": "### Environment details\r\n\r\n* Operating System+version: ubuntu-22.04\r\n* Compiler+version: 13.1.0\r\n* Conan version: 2.0.9\r\n* Python version: 3.11.4\r\n\r\n\r\n### Steps to reproduce\r\n\r\nI am creating a Conda package of my software, as part of a Github C/I workflow. My software depends on o... | 1940c9fe9444d15a507c422338ef64d6e67ab169 | {
"head_commit": "9ea1e7920a184a8ddaedaa527f9daa55c3a97dcb",
"head_commit_message": "Switched to cc pattern in compiler detection",
"patch_to_review": "diff --git a/conan/internal/api/detect_api.py b/conan/internal/api/detect_api.py\nindex cc0fa762559..60574018721 100644\n--- a/conan/internal/api/detect_api.py\n+... | [
{
"diff_hunk": "@@ -276,7 +276,7 @@ def detect_default_compiler():\n command = cc or cxx\n if \"clang\" in command.lower():\n return _clang_compiler(command)\n- if \"gcc\" in command or \"g++\" in command or \"c++\" in command:\n+ if \"cc\" in command or \"g++\" in comm... | 9039f9e4949877bd5a36c456b2ee54e094bf631b | diff --git a/conan/internal/api/detect_api.py b/conan/internal/api/detect_api.py
index cc0fa762559..4600e769b1f 100644
--- a/conan/internal/api/detect_api.py
+++ b/conan/internal/api/detect_api.py
@@ -276,7 +276,7 @@ def detect_default_compiler():
command = cc or cxx
if "clang" in command.lower():
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
All-Hands-AI__OpenHands-4104@b962b48 | All-Hands-AI/OpenHands | Python | 4,104 | Fix issue #4103: Improve description of how to do frontend setup and testing in `.openhands_instructions` | This pull request fixes #4103.
The PR successfully addresses the issue by updating the .openhands_instructions file to include separate descriptions for both frontend and backend. The agent has added a concise summary of the frontend based on the frontend/README.md file, covering key aspects such as setup, development... | 2024-09-28T06:06:29Z | Improve description of how to do frontend setup and testing in `.openhands_instructions`
**Summary**
The `.openhands_instructions` file provides instructions to the OpenHands coding agent about how to navigate this repository.
However, currently it only really covers backend. This file should be split into separate... | OpenHands started fixing the issue! You can monitor the progress [here](https://github.com/All-Hands-AI/OpenHands/actions/runs/11081614544). | [
{
"body": "**Summary**\r\n\r\nThe `.openhands_instructions` file provides instructions to the OpenHands coding agent about how to navigate this repository.\r\nHowever, currently it only really covers backend. This file should be split into separate descriptions of frontend and backend. To gather the necessary i... | d669c7b60d420e6f31c40ccacf459519f696c3a4 | {
"head_commit": "b962b48404960686bc5cd508c848d389052fbfe9",
"head_commit_message": "Fix issue #4103: Improve description of how to do frontend setup and testing in `.openhands_instructions`",
"patch_to_review": "diff --git a/.openhands_instructions b/.openhands_instructions\nindex 015ea101a075..2e01582ed565 1006... | [
{
"diff_hunk": "@@ -1,7 +1,30 @@\n OpenHands is an automated AI software engineer. It is a repo with a Python backend\n-(in the `openhands` directory) and typescript frontend (in the `frontend` directory).\n+(in the `openhands` directory) and TypeScript frontend (in the `frontend` directory).\n \n-- Setup: To s... | 8a5ff93ea4ce218f01c09d86d1399ccf8d39f527 | diff --git a/.openhands_instructions b/.openhands_instructions
index 015ea101a075..c507eb32ce1b 100644
--- a/.openhands_instructions
+++ b/.openhands_instructions
@@ -1,7 +1,27 @@
OpenHands is an automated AI software engineer. It is a repo with a Python backend
-(in the `openhands` directory) and typescript frontend ... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "Documentation Updates"
} |
conan-io__conan-15613@3a0e60a | conan-io/conan | Python | 15,613 | Add format json option to conan cache path | Changelog: Feature: Add `--format=json` option to `conan cache path`.
Docs: Omit
Added `--format=json` option to the `conan cache path` command that returns a json as:
`{"cache_path": "C:\\Users\\user\\.conan2\\p\\zlib2cad50ee1214e\\e"}`
Closes: https://github.com/conan-io/conan/issues/15599 | 2024-02-06T15:42:23Z | [feature] add `--format=json` to conan cache path
### What is your suggestion?
I would like for conan to be able to give me a machine readable file, rather than having to pipe the output of the `conan cache path` command.
There's nothing wrong with piping, but this makes life slightly easier on a CI system that nee... | We probably want this extended to `conan config home` if we end up likeing this idea
These 2 commands were intended to get the "text" output also valid for automation. So when a command returns a single string (path) as a result, the text in ``stdout`` will be equivalent to a potential ``json`` output with
```
{"pat... | [
{
"body": "### What is your suggestion?\n\nI would like for conan to be able to give me a machine readable file, rather than having to pipe the output of the `conan cache path` command.\r\n\r\nThere's nothing wrong with piping, but this makes life slightly easier on a CI system that needs to support both bash s... | 81d816f57369bf5c428fc5360391382ddd0d170f | {
"head_commit": "3a0e60a9dd10fbd42e6e6628cb5649a00675ba91",
"head_commit_message": "add cache path format json option",
"patch_to_review": "diff --git a/conan/cli/commands/cache.py b/conan/cli/commands/cache.py\nindex e52456f3c3b..466297eab9d 100644\n--- a/conan/cli/commands/cache.py\n+++ b/conan/cli/commands/ca... | [
{
"diff_hunk": "@@ -111,3 +114,14 @@ def test_cache_path_does_not_exist_folder():\n client.run(f\"install --requires mypkg/0.1\")\n client.run(f\"cache path {pref} --folder build\", assert_error=True)\n assert f\"ERROR: 'build' folder does not exist for the reference {pref}\" in client.out\n+\n+def ... | 797446de371a21853b96d051a7a67cefe5ab8a0e | diff --git a/conan/cli/commands/cache.py b/conan/cli/commands/cache.py
index e52456f3c3b..466297eab9d 100644
--- a/conan/cli/commands/cache.py
+++ b/conan/cli/commands/cache.py
@@ -1,3 +1,5 @@
+import json
+
from conan.api.conan_api import ConanAPI
from conan.api.model import ListPattern, MultiPackagesList
from cona... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "New Feature Additions"
} |
conan-io__conan-15653@2cf1b9d | conan-io/conan | Python | 15,653 | To check what to do with version build metadata and prereleases | Changelog: Bugfix: Fix version precendence for metadata version ranges.
Docs: Omit
I suspect more things are still needed
| 2024-02-12T20:36:16Z | [bug] semver fails to resolve metadata field correctly
### Environment details
* Operating System+version: Ubuntu 22.04
* Compiler+version: N/A
* Conan version: 2.0.17
* Python version: 3.10.8
### Steps to reproduce
1. Have a package with a version number followed by a "metadata (i.e. preceded by +)" fiel... | [
{
"body": "### Environment details\r\n\r\n* Operating System+version: Ubuntu 22.04\r\n* Compiler+version: N/A\r\n* Conan version: 2.0.17\r\n* Python version: 3.10.8\r\n\r\n\r\n### Steps to reproduce\r\n\r\n1. Have a package with a version number followed by a \"metadata (i.e. preceded by +)\" field containing a... | 5cbdd1e5ef55ae1c7634e76fd44d0a8c2785f617 | {
"head_commit": "2cf1b9de72b969acde9e24a403aca62fcb83c377",
"head_commit_message": "To think about what to do with build metadata and rpereleases",
"patch_to_review": "diff --git a/conans/model/version_range.py b/conans/model/version_range.py\nindex 4360758a109..f12d6a80a8a 100644\n--- a/conans/model/version_ran... | [
{
"diff_hunk": "@@ -37,7 +37,9 @@\n ['~1.1.2', [[['>=', '1.1.2-'], ['<', '1.2.0-']]], [\"1.1.3\"], [\"1.1.3-alpha1\", \"1.2.0-alpha1\"]],\n ['>=2.0-pre.0 <3', [[['>=', '2.0-pre.0'], ['<', '3-']]], [\"2.1\"], [\"2.0-pre.1\",\"2.0-alpha.1\"]],\n # Or explicitly\n- ['>=2.0-pre.0, include_prereleas... | 12b86f997c86b5b9cbb54ca8bb72f939556d8d63 | diff --git a/conans/model/version_range.py b/conans/model/version_range.py
index 4360758a109..97778f68cf6 100644
--- a/conans/model/version_range.py
+++ b/conans/model/version_range.py
@@ -12,7 +12,7 @@ def __init__(self, operator, version):
self.display_version = version
value = str(version)
- ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
conan-io__conan-15447@793171b | conan-io/conan | Python | 15,447 | Consider adding cmakeExecutable to presets | Changelog: Feature: Add cmakeExecutable to configure preset.
Docs: https://github.com/conan-io/docs/pull/3548
Closes: https://github.com/conan-io/conan/issues/15427
| 2024-01-12T09:21:41Z | [feature] configurePresets.cmakeExecutable in CMakePresets.json should be filled in
### What is your suggestion?
In `CMakePresets.json`, you can set `configurePresets.cmakeExecutable` to set a specific CMake binary.
While this doesn't work at alll with Visual Studio (stupid IDE insists on using built-in, outdated ... | Hi @Ext3h
Thanks for your suggestion.
This looks interesting, we knew that there was a gap when ``tool_requires("cmake/...")`` for certain cases when we recently added the ``env`` environment variables to the ``CMakePresets``. But we didn't think about ``cmakeExecutable``. If this can help for some setups/IDEs, it... | [
{
"body": "### What is your suggestion?\r\n\r\nIn `CMakePresets.json`, you can set `configurePresets.cmakeExecutable` to set a specific CMake binary. \r\nWhile this doesn't work at alll with Visual Studio (stupid IDE insists on using built-in, outdated CMake version), it does work for IDEs like Visual Studio Co... | 98d68db7f3a7d6eec4dc463a24839af542fb70cc | {
"head_commit": "793171b8b7373200dce3eb00e656063d295f3603",
"head_commit_message": "minor changes",
"patch_to_review": "diff --git a/conan/tools/cmake/presets.py b/conan/tools/cmake/presets.py\nindex 27792af73b9..c6fd71bd851 100644\n--- a/conan/tools/cmake/presets.py\n+++ b/conan/tools/cmake/presets.py\n@@ -14,9... | [
{
"diff_hunk": "@@ -184,6 +184,18 @@ def content(self):\n content = relativize_generated_file(content, self._conanfile, \"${CMAKE_CURRENT_LIST_DIR}\")\n return content\n \n+ def _find_cmake_exe(self):\n+ for req in self._conanfile.dependencies.build.values():",
"line": null,
"o... | cbb011a14f7493cc050108f8cfb09842cec96be6 | diff --git a/conan/tools/cmake/presets.py b/conan/tools/cmake/presets.py
index 27792af73b9..c6fd71bd851 100644
--- a/conan/tools/cmake/presets.py
+++ b/conan/tools/cmake/presets.py
@@ -14,9 +14,11 @@
def write_cmake_presets(conanfile, toolchain_file, generator, cache_variables,
- user_preset... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
conan-io__conan-15422@1a129ed | conan-io/conan | Python | 15,422 | set jobs parameter in cmake build presets(#15419) | Changelog: Feature: ``CMakeToolchain`` defines ``jobs`` in generated ``CMakePresets.json`` buildPresets.
Docs: Omit
this should be seen as a proof of concept for the feature request to have conan generate CMakePresets.json with jobs parameter set.
closes #15419
- [x] Refer to the issue that supports this Pull... | 2024-01-09T13:09:29Z | [feature] set jobs parameter in CMakePreset buildPresets to get parallel builds when invoking cmake after conan install
### What is your suggestion?
the generated CMakePresets.json does not contain the "jobs" parameter, making it default to 1 (at least sometimes).
when manually set to a higher number, the cmake build... | Hi @Hailios
Thanks for your suggestion.
I think this could make sense, might be doable, I'll check with the team. | [
{
"body": "### What is your suggestion?\n\nthe generated CMakePresets.json does not contain the \"jobs\" parameter, making it default to 1 (at least sometimes).\r\nwhen manually set to a higher number, the cmake build command builds in parallel as expected.\r\nit would be good if Conan could set this parameter ... | f08b9924712cf0c2f27b93cbb5206d56d0d824d8 | {
"head_commit": "1a129ed0edd7e560e5488f62ad7443fc9c388875",
"head_commit_message": "set jobs parameter in cmake build presets(#15419)",
"patch_to_review": "diff --git a/conan/tools/cmake/presets.py b/conan/tools/cmake/presets.py\nindex cb11e2174f8..1afddfae630 100644\n--- a/conan/tools/cmake/presets.py\n+++ b/co... | [
{
"diff_hunk": "@@ -6,6 +6,7 @@\n from conan.tools.cmake.layout import get_build_folder_custom_vars\n from conan.tools.cmake.toolchain.blocks import GenericSystemBlock\n from conan.tools.cmake.utils import is_multi_configuration\n+import conan.tools.build as build",
"line": null,
"original_line": 9,
... | 55c54e332ce4a06d59bc506cedfaf5027149c6b4 | diff --git a/conan/tools/cmake/presets.py b/conan/tools/cmake/presets.py
index cb11e2174f8..27792af73b9 100644
--- a/conan/tools/cmake/presets.py
+++ b/conan/tools/cmake/presets.py
@@ -6,6 +6,7 @@
from conan.tools.cmake.layout import get_build_folder_custom_vars
from conan.tools.cmake.toolchain.blocks import GenericS... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
conan-io__conan-15418@7f4eca4 | conan-io/conan | Python | 15,418 | Bugfix libcxx detection when using CC/CXX | Changelog: Bugfix: Fix libcxx detection when using `CC/CXX` env vars.
Docs: https://github.com/conan-io/docs/pull/3509
Closes: https://github.com/conan-io/conan/issues/15399
| 2024-01-09T09:18:35Z | [bug] profile detect does not try to use the compiler provided
### Environment details
* Operating System+version: Ubuntu 22.04.3 LTS
* Compiler+version: Ubuntu clang version 17.0.6
* Conan version: Conan version 2.0.16
* Python version: Python 3.10.12
### Steps to reproduce
`CC=clang-17 CXX=clang++-17 conan pr... | Hi @Ignition
Thanks for your report.
Yes, it seems that there could be a bug there, and the detection should be using CC/CXX defined compiler.
@RubenRBS I am having a look how this could be improved:
- Breaking the ``detect_api`` interface, and make "detect_compiler" return: ``compiler, version, compiler_exe = ... | [
{
"body": "### Environment details\n\n* Operating System+version: Ubuntu 22.04.3 LTS\r\n* Compiler+version: Ubuntu clang version 17.0.6\r\n* Conan version: Conan version 2.0.16\r\n* Python version: Python 3.10.12\r\n\n\n### Steps to reproduce\n\n`CC=clang-17 CXX=clang++-17 conan profile detect`\r\nI would expec... | def7bb1150dc87c6b63d5919f103eb873a4730f4 | {
"head_commit": "7f4eca49a6c415def3bc1a4411f0301730f03ba4",
"head_commit_message": "Prettier error when jinja2 rendering fails",
"patch_to_review": "diff --git a/conan/internal/api/detect_api.py b/conan/internal/api/detect_api.py\nindex 0f6ad396313..a38215d6dc8 100644\n--- a/conan/internal/api/detect_api.py\n+++... | [
{
"diff_hunk": "@@ -326,21 +326,27 @@ def _gcc_compiler(compiler_exe=\"gcc\"):\n _, out = detect_runner(\"%s --version\" % compiler_exe)\n out = out.lower()\n if \"clang\" in out:\n- return None, None\n+ return None, None, None\n \n ret, ... | 87e78928977ba05003e97dad1afcfaccaebfc551 | diff --git a/conan/internal/api/detect_api.py b/conan/internal/api/detect_api.py
index 0f6ad396313..8dc76ec74e6 100644
--- a/conan/internal/api/detect_api.py
+++ b/conan/internal/api/detect_api.py
@@ -122,7 +122,7 @@ def _get_e2k_architecture():
}.get(platform.processor())
-def detect_libcxx(compiler, version)... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
conan-io__conan-15274@89a832d | conan-io/conan | Python | 15,274 | Add different ref tracking syntax for `<host_version>` | Changelog: Feature: Add tracking syntax in `<host_version>` for different references.
Docs: https://github.com/conan-io/docs/pull/3480
Close https://github.com/conan-io/conan/issues/15265
I don't like the current approach, so opening the PR so that I can get some ideas from the team
| 2023-12-14T09:42:16Z | [feature] <host_version>: ability to reference a dependency of a different name
### What is your suggestion?
To cover cases where we have:
* self.requires()
* self.tool_requires()
Against a pair of references that could be separate components of the same tool - e.g. `libgettext` vs `gettext`, or an hypothetical `... | Some of the syntaxes I recall we originally discussed was
```
self.tool_requires("pkg/<host_version(foo)>")
self.tool_requires("pkg/<host_version:foo>")
```
I personally like the second one a bit better, but happy to hear other opnions | [
{
"body": "### What is your suggestion?\n\nTo cover cases where we have:\r\n* self.requires()\r\n* self.tool_requires()\r\n\r\nAgainst a pair of references that could be separate components of the same tool - e.g. `libgettext` vs `gettext`, or an hypothetical `libprotobuf` vs `protobuf-compiler`, when we need a... | c6558094ef63b30a6c816098359345852efa275a | {
"head_commit": "89a832d801b6377c6c8db7bca1f77ae93dee33c4",
"head_commit_message": "Add remote input to build-map command",
"patch_to_review": "diff --git a/conans/client/graph/graph_builder.py b/conans/client/graph/graph_builder.py\nindex 27d8449d82c..e513cd05bde 100644\n--- a/conans/client/graph/graph_builder.... | [
{
"diff_hunk": "@@ -270,14 +272,21 @@ def _resolve_replace_requires(self, node, require, profile_build, profile_host,\n break # First match executes the alternative and finishes checking others\n \n def _create_new_node(self, node, require, graph, profile_host, profile_build, graph_lock):\n- ... | 93cebcc6434ba14227873f957dbf0bd13dd9e3c4 | diff --git a/conans/client/graph/graph_builder.py b/conans/client/graph/graph_builder.py
index 27d8449d82c..f4c0693e16a 100644
--- a/conans/client/graph/graph_builder.py
+++ b/conans/client/graph/graph_builder.py
@@ -1,5 +1,6 @@
import copy
import os
+import re
from collections import deque
from conans.client.con... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
conan-io__conan-15360@5333ad5 | conan-io/conan | Python | 15,360 | Feature: Upload parallel | Changelog: Feature: New ``conan upload`` ``core.upload:parallel`` for faster parallel uploads.
Docs: https://github.com/conan-io/docs/pull/3540
Close https://github.com/conan-io/conan/issues/13224 | 2023-12-29T17:22:42Z | [feature] conan 2.x parallel upload
### What is your suggestion?
It seems that `parallel` upload is missing in Conan 2.x. This feature was present in Conan 1.x and valuable for optimizing uploads.
### Have you read the CONTRIBUTING guide?
- [ ] I've read the CONTRIBUTING guide | [
{
"body": "### What is your suggestion?\n\nIt seems that `parallel` upload is missing in Conan 2.x. This feature was present in Conan 1.x and valuable for optimizing uploads.\n\n### Have you read the CONTRIBUTING guide?\n\n- [ ] I've read the CONTRIBUTING guide",
"number": 13224,
"title": "[feature] con... | 35a9d7d9e369662531e2a32d2893e1d7acb13ccc | {
"head_commit": "5333ad5858ae9a598aa7802180f49879b8580ae1",
"head_commit_message": "wip",
"patch_to_review": "diff --git a/conan/api/model.py b/conan/api/model.py\nindex d1687197e00..67b5edddd99 100644\n--- a/conan/api/model.py\n+++ b/conan/api/model.py\n@@ -135,6 +135,15 @@ class PackagesList:\n def __init_... | [
{
"diff_hunk": "@@ -57,6 +59,40 @@ def upload(self, package_list, remote):\n executor = UploadExecutor(app)\n executor.upload(package_list, remote)\n \n+ def full_upload(self, package_list, remote, enabled_remotes, check_integrity=False, force=False,",
"line": null,
"original_line": 6... | 4fed77786a05b2a5dfbc41ac4d0bcfc436f2e2e4 | diff --git a/conan/api/model.py b/conan/api/model.py
index d1687197e00..8fae75c48d4 100644
--- a/conan/api/model.py
+++ b/conan/api/model.py
@@ -135,6 +135,18 @@ class PackagesList:
def __init__(self):
self.recipes = {}
+ def split(self):
+ """
+ Returns a list of PackageList, splitted ... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
conan-io__conan-15263@81e3dd9 | conan-io/conan | Python | 15,263 | add CONAN_LOG_LEVEL env-var | Changelog: Feature: Define ``CONAN_LOG_LEVEL`` env-var to be able to change verbosity at a global level.
Docs: https://github.com/conan-io/docs/pull/3490
Close https://github.com/conan-io/conan/issues/14693
| 2023-12-13T09:25:26Z | [feature] Support command line verbosity via env-var or global.conf
Instead of requiring always to ``-vvv`` to all commands, it could be convenient to:
- Allow log level to be defined via env-var, for CI systems
- Or allow log level to be defined via ``global.conf`` configuration (this will be a bit more difficult to... | [
{
"body": "Instead of requiring always to ``-vvv`` to all commands, it could be convenient to:\r\n- Allow log level to be defined via env-var, for CI systems\r\n- Or allow log level to be defined via ``global.conf`` configuration (this will be a bit more difficult to implement)\r\n",
"number": 14693,
"t... | 032eefc4a2cf6846a98838f60bacf340af1bc1c3 | {
"head_commit": "81e3dd9baf29723047e9699952ec1829b2e668b2",
"head_commit_message": "add CONAN_LOG_LEVEL env-var",
"patch_to_review": "diff --git a/conan/cli/command.py b/conan/cli/command.py\nindex 85c90e936fe..292303d8537 100644\n--- a/conan/cli/command.py\n+++ b/conan/cli/command.py\n@@ -1,4 +1,5 @@\n import a... | [
{
"diff_hunk": "@@ -101,7 +102,7 @@ def __init__(self, *args, **kwargs):\n \n def parse_args(self, args=None, namespace=None):\n args = super().parse_args(args)\n- ConanOutput.define_log_level(args.v)\n+ ConanOutput.define_log_level(os.getenv(\"CONAN_LOG_LEVEL\") or args.v)",
"line... | dcd318948db6569e37ca8515afff71b20e209023 | diff --git a/conan/cli/command.py b/conan/cli/command.py
index 85c90e936fe..05bda22eebc 100644
--- a/conan/cli/command.py
+++ b/conan/cli/command.py
@@ -1,4 +1,5 @@
import argparse
+import os
import textwrap
from conan.api.output import ConanOutput
@@ -101,7 +102,7 @@ def __init__(self, *args, **kwargs):
de... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "New Feature Additions"
} | |
conan-io__conan-15272@8ebb938 | conan-io/conan | Python | 15,272 | adding tools.microsoft:winsdk_version conf | Changelog: Feature: Adding ``tools.microsoft:winsdk_version`` conf to make ``VCVars`` generator to use the given ``winsdk_version``.
Docs: https://github.com/conan-io/docs/pull/3487
Close https://github.com/conan-io/conan/issues/14383
| 2023-12-13T23:52:56Z | [bug] It's impossible to set winsdk_version argument for vcvars script
### Environment details
* Windows 11
* MSVC 2022
* Conan version: 2.0.9
* Python version: 3.10
### Steps to reproduce
The generated `conanvcvars.bat` contains the following line
```
set "VSCMD_START_DIR=%CD%" && call "C:\Program Files\... | Hi @apyvovar
Yes, you are right, at the moment there is no way to set the ``winsdk_version``.
It shouldn't be difficult to define a way, but I am not sure what would be the right mechanism to input it:
- Is it a ``conf`` like ``tools.microsoft:winsdk_version`` that the ``VCVars`` generator reads it? Or is it an... | [
{
"body": "### Environment details\n\n* Windows 11\r\n* MSVC 2022\r\n* Conan version: 2.0.9\r\n* Python version: 3.10\r\n\r\n\n\n### Steps to reproduce\n\nThe generated `conanvcvars.bat` contains the following line\r\n\r\n```\r\nset \"VSCMD_START_DIR=%CD%\" && call \"C:\\Program Files\\Microsoft Visual Studio\\... | 9afacb4bbbf8679cdf422794bbdfebf573f69e70 | {
"head_commit": "8ebb938e1560b393c3731c36f195d8d097ccf706",
"head_commit_message": "fix",
"patch_to_review": "diff --git a/conan/tools/cmake/toolchain/blocks.py b/conan/tools/cmake/toolchain/blocks.py\nindex ad5e5ee7484..c587534edf6 100644\n--- a/conan/tools/cmake/toolchain/blocks.py\n+++ b/conan/tools/cmake/too... | [
{
"diff_hunk": "@@ -555,6 +555,20 @@ def test_cmake_toolchain_runtime_types_cmake_older_than_3_15():\n assert \"LIBCMTD\" in client.out\n \n \n+@pytest.mark.skipif(platform.system() != \"Windows\", reason=\"Only for windows\")\n+# @pytest.mark.tool(\"cmake\", \"3.28\")\n+def test_cmake_toolchain_winsdk_vers... | 0b7830fdde57ccfc3b1e8dbd17c2f25064b1f8f8 | diff --git a/conan/tools/cmake/toolchain/blocks.py b/conan/tools/cmake/toolchain/blocks.py
index ad5e5ee7484..e90ed2f2682 100644
--- a/conan/tools/cmake/toolchain/blocks.py
+++ b/conan/tools/cmake/toolchain/blocks.py
@@ -577,7 +577,7 @@ def context(self):
che... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
conan-io__conan-15207@b9d2ac3 | conan-io/conan | Python | 15,207 | Feature/cmakedeps legacy adapter | Changelog: Feature: Make ``CMakeDeps`` generator create a ``conandeps.cmake`` that aggregates all direct dependencies in a ``cmake``-like generator style.
Docs: https://github.com/conan-io/docs/pull/3492
Close https://github.com/conan-io/conan/issues/14623 | 2023-12-03T23:43:39Z | [feature] Bring back CMake targets generator for Conan 2
### What is your suggestion?
The new way of injecting dependency information into CMake is a lot more verbose, complex and error prone on the CMake side than conan 1's `conan_basic_setup(TARGETS)`.
1. Need to use find_package for each dependency instead of a ... | Hi @ltjax
Thanks for your feedback.
Conan decided to follow the ``CMakeDeps`` "transparent integration" approach in Conan 1.X (this is not exclusive of Conan 2.0, the migration to ``CMakeDeps`` should be done while in Conan 1.X, then move to 2.0), based on massive feedback against the non-transparent integration... | [
{
"body": "### What is your suggestion?\n\nThe new way of injecting dependency information into CMake is a lot more verbose, complex and error prone on the CMake side than conan 1's `conan_basic_setup(TARGETS)`.\r\n\r\n1. Need to use find_package for each dependency instead of a single include. (more verbose)\r... | 0c786c5fdef49f0060638de90c975367394e02e8 | {
"head_commit": "b9d2ac3626a170b460b86282067d4af2e2e24611",
"head_commit_message": "Merge branch 'release/2.0' into feature/cmakedeps_legacy_adapter",
"patch_to_review": "diff --git a/conan/tools/cmake/cmakedeps/cmakedeps.py b/conan/tools/cmake/cmakedeps/cmakedeps.py\nindex 9ab2816c060..dda5b3dab97 100644\n--- a... | [
{
"diff_hunk": "@@ -162,3 +186,38 @@ def get_find_mode(self, dep):\n if tmp is None:\n return \"config\"\n return tmp.lower()\n+\n+ def generate_aggregator(self):\n+ host = self._conanfile.dependencies.host\n+ build_req = self._conanfile.dependencies.direct_build\n+ ... | 58426c97c555993a8eb28d10cdae3596888546cd | diff --git a/conan/tools/cmake/cmakedeps/cmakedeps.py b/conan/tools/cmake/cmakedeps/cmakedeps.py
index 9ab2816c060..04964f18ffd 100644
--- a/conan/tools/cmake/cmakedeps/cmakedeps.py
+++ b/conan/tools/cmake/cmakedeps/cmakedeps.py
@@ -1,5 +1,10 @@
import os
+import textwrap
+import jinja2
+from jinja2 import Template
... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
conan-io__conan-15172@1bb3955 | conan-io/conan | Python | 15,172 | proposal for deploy() feature | Changelog: Feature: New ``deploy()`` method in recipes for explicit per-recipe deployment.
Docs: https://github.com/conan-io/docs/pull/3494
Close https://github.com/conan-io/conan/issues/14811 | 2023-11-24T14:40:05Z | [feature] Add a `deploy()` method to conanfile for application specific deployment logic
### What is your suggestion?
Hi Team,
# Bottom Line Up Front
### The proposal
Add a `deploy()` method to the conanfile, that would allow the author to specify very specific deployment instructions for applications where a m... | This would be useful for our use cases too.
Currently when we create a product installer, it pulls down Conan dependencies, copies files while changing the layout slightly, add a few installation scripts, then create/publish a mega-package. It's a pretty big waste of storage and network throughput.
@memsharded m... | [
{
"body": "### What is your suggestion?\n\nHi Team,\r\n\r\n# Bottom Line Up Front\r\n### The proposal\r\n\r\nAdd a `deploy()` method to the conanfile, that would allow the author to specify very specific deployment instructions for applications where a more general deployment script is not appropriate. This mig... | f0a1b35fb7e93afee367ab530c6fb0b6a95795d2 | {
"head_commit": "1bb39559c9e45369914a661c83189f28598ce3b1",
"head_commit_message": "Merge branch 'release/2.0' into feature/deploy",
"patch_to_review": "diff --git a/conan/api/subapi/install.py b/conan/api/subapi/install.py\nindex 5558b1de907..7fa09cebec3 100644\n--- a/conan/api/subapi/install.py\n+++ b/conan/ap... | [
{
"diff_hunk": "@@ -33,6 +33,8 @@ def install(conan_api, parser, *args):\n help='Deploy using the provided deployer to the output folder')\n parser.add_argument(\"--deployer-folder\",\n help=\"Deployer output folder, base build folder by default if not set\")\... | 91dac4a2fd905f906ac46b115ca2aee968228fa3 | diff --git a/conan/api/subapi/install.py b/conan/api/subapi/install.py
index 5558b1de907..7fa09cebec3 100644
--- a/conan/api/subapi/install.py
+++ b/conan/api/subapi/install.py
@@ -40,7 +40,7 @@ def install_sources(self, graph, remotes):
# TODO: Look for a better name
def install_consumer(self, deps_graph, ... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
conan-io__conan-15150@d966829 | conan-io/conan | Python | 15,150 | Add `redirect_stdout` to CMake integration methods | Changelog: Feature: Add `redirect_stdout` to CMake integration methods.
Docs: Omit
This PR focuses on adding the functionality to the CMake integrations only. We're happy to make them available in other integrations if there're requests for it from users
Closes #15108 | 2023-11-21T15:24:05Z | [question] Build log file generation in recipe
### What is your question?
Hello everyone,
I searched for that topic, but I couldn't find any result here.
Is it somehow feasible to generate a log file from the build in the build function of the Conan recipe? My personal attempts here weren't successfull, but I am a... | Hi @KarstenErnert thanks a lot for your question.
Conan 2 recently released a metadata feature which aims to solve cases just like this one. [This blog post](https://blog.conan.io/2023/10/24/Conan-launches-metadata-files.html) goes into some detail about using in for different usecases, I suggest you read it - feel ... | [
{
"body": "### What is your question?\n\nHello everyone,\r\n\r\nI searched for that topic, but I couldn't find any result here.\r\nIs it somehow feasible to generate a log file from the build in the build function of the Conan recipe? My personal attempts here weren't successfull, but I am also not the most ski... | c106acc7bae862128a87bfe8c73e791f6a1695d7 | {
"head_commit": "d9668294c16db7a3e52221e253bb433653e80cc3",
"head_commit_message": "Update conans/test/functional/toolchains/cmake/test_cmake_toolchain.py\n\nCo-authored-by: Carlos Zoido <mrgalleta@gmail.com>",
"patch_to_review": "diff --git a/conan/tools/cmake/cmake.py b/conan/tools/cmake/cmake.py\nindex a49ae2... | [
{
"diff_hunk": "@@ -774,6 +774,10 @@ def assert_listed_binary(self, requires, build=False, test=False, test_package=F\n else:\n raise AssertionError(f\"Cant find {r}-{kind} in {reqs}\")\n \n+ def created_build_folder(self, ref):",
"line": null,
"original_line": 777,
"o... | a246ecf73d03632760ceb2facef7cc5b8caa07d5 | diff --git a/conan/tools/cmake/cmake.py b/conan/tools/cmake/cmake.py
index a49ae2d01df..31e50ae7fe7 100644
--- a/conan/tools/cmake/cmake.py
+++ b/conan/tools/cmake/cmake.py
@@ -51,7 +51,8 @@ def __init__(self, conanfile):
self._cmake_program = conanfile.conf.get("tools.cmake:cmake_program", default="cmake")
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
keephq__keep-2169@3596efd | keephq/keep | Python | 2,169 | feat: User can set exact provider log level using environment variable | <!--
Thanks for creating this pull request 🤗
Please make sure that the pull request is limited to one type (docs, feature, etc.) and keep it as small as possible. You can open multiple prs instead of opening a huge one.
-->
<!-- If this pull request closes an issue, please mention the issue number below -->
... | 2024-10-12T15:15:56Z | [➕ Feature]: Allow to change provider logger level via `PROVIDER_{PROVIDER_NAME}_LOG_LEVEL`
**Is your feature request related to a problem? Please describe.**
Sometimes we need to debug the particular provider and setting the global LOG_LEVEL will produce tons of logs.
**Describe the solution you'd like**
The `P... | [
{
"body": "**Is your feature request related to a problem? Please describe.**\r\nSometimes we need to debug the particular provider and setting the global LOG_LEVEL will produce tons of logs. \r\n\r\n**Describe the solution you'd like**\r\nThe `PROVIDER_{PROVIDER_NAME}_LOG_LEVEL` will allow to toggle debug logs... | 505657ae20ad26b4854f400243ea8c8f53344645 | {
"head_commit": "3596efdf68ff22ba29ccd72af7af383825fb3093",
"head_commit_message": "Make test less hardcoded",
"patch_to_review": "diff --git a/keep/contextmanager/contextmanager.py b/keep/contextmanager/contextmanager.py\nindex c46502f585..ce55e2cdac 100644\n--- a/keep/contextmanager/contextmanager.py\n+++ b/ke... | [
{
"diff_hunk": "@@ -66,7 +66,13 @@ def __init__(\n self.webhook_markdown = webhook_markdown\n self.provider_description = provider_description\n self.context_manager = context_manager\n- self.logger = context_manager.get_logger()\n+ self.logger = context_manager.get_logger(... | 5a94630e2cf22989cbb8b3bf090355b14544e06e | diff --git a/keep/contextmanager/contextmanager.py b/keep/contextmanager/contextmanager.py
index c46502f585..b044962c48 100644
--- a/keep/contextmanager/contextmanager.py
+++ b/keep/contextmanager/contextmanager.py
@@ -15,6 +15,7 @@ def __init__(self, tenant_id, workflow_id=None, workflow_execution_id=None):
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
conan-io__conan-15153@ac4642f | conan-io/conan | Python | 15,153 | proposal for source() buildenv discussion | Changelog: Feature: Allow ``tool-requires`` to be used in ``source()`` method injecting environment.
Docs: https://github.com/conan-io/docs/pull/3493
Close https://github.com/conan-io/conan/issues/15152
| 2023-11-21T21:28:25Z | [question] Using tool_requires dependencies in source method
### What is your question?
I maintain a number of Conan packages for internal use by our team, and have recently been working to migrate them to Conan 2.x. Some of these packages have actions in their `source` method that require an external tool — for examp... | Hi @jdent-5c2ff9e
Thanks for your feedback.
This might not be specific to Conan 2.0, but to the way the new ``generate()`` and ``VirtualBuildEnv`` works:
- The ``generate()`` works after ``source()`` method to generate information for the build
- The information for the build is assumed to be configuration spe... | [
{
"body": "### What is your question?\n\nI maintain a number of Conan packages for internal use by our team, and have recently been working to migrate them to Conan 2.x. Some of these packages have actions in their `source` method that require an external tool — for example:\r\n- Using CVS to check out source f... | 08433724b662f83111aed3aa2410e9d2e48e0dcd | {
"head_commit": "ac4642f7ab71262c0a6e8f93f78a84233d1e5426",
"head_commit_message": "wip, failing",
"patch_to_review": "diff --git a/conan/tools/env/__init__.py b/conan/tools/env/__init__.py\nindex 2a6b6da6f97..6b4c29b8a7d 100644\n--- a/conan/tools/env/__init__.py\n+++ b/conan/tools/env/__init__.py\n@@ -1,3 +1,4 ... | [
{
"diff_hunk": "@@ -0,0 +1,91 @@\n+import textwrap\n+\n+from conans.test.utils.tools import TestClient\n+\n+\n+def test_build_requires_source():\n+ c = TestClient()\n+ tool = textwrap.dedent(r\"\"\"\n+ import os\n+ from conan import ConanFile\n+ from conan.tools.files import chdir, sa... | 7f1b994eb1dea3cc69be9f8623e69d060720d2b5 | diff --git a/conan/api/subapi/local.py b/conan/api/subapi/local.py
index 8856f9671a7..45093c07cb4 100644
--- a/conan/api/subapi/local.py
+++ b/conan/api/subapi/local.py
@@ -83,6 +83,8 @@ def source(self, path, name=None, version=None, user=None, channel=None, remotes
conanfile.folders.set_base_source(folder)
... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Dependency Updates & Env Compatibility"
} |
All-Hands-AI__OpenHands-2289@a6cc794 | All-Hands-AI/OpenHands | Python | 2,289 | doc: add Python keyring to Troubleshooting documentation | During build process some Python dependencies could get stuck in "pending" mode if `PYTHON_KEYRING_BACKEND` is not set in env (Poetry had a couple of issues related to this on their site, e.g. https://github.com/python-poetry/poetry/issues/5250).
Probably fixes: https://github.com/OpenDevin/OpenDevin/issues/919, htt... | 2024-06-06T04:56:16Z | make run stuck on dependecies
<!-- You MUST fill out this template. We will close issues that don't include enough information to reproduce -->
installation stuck on dependencies. debian server.
<!-- a short description of the problem -->
**Logs:**
```
Package operations: 210 installs, 1 update, 0 removals
- ... | I'm not sure why it'd do that. 😔
Did you clone and run make build, or something else?
@nowheel do you still face the issue?
Same as here: https://github.com/OpenDevin/OpenDevin/issues/935
That was solved by updating poetry.
I'll close this issue, but if you still experience problems please open a new one.
still... | [
{
"body": "<!-- You MUST fill out this template. We will close issues that don't include enough information to reproduce -->\r\ninstallation stuck on dependencies. debian server.\r\n<!-- a short description of the problem -->\r\n**Logs:**\r\n```\r\nPackage operations: 210 installs, 1 update, 0 removals\r\n\r\n ... | 08137d19685b86854b29c6c43c21fa6f4e1dbd8d | {
"head_commit": "a6cc794aa674745881413002f36a5161eb9f1b99",
"head_commit_message": "fix: set Python keyring for Poetry",
"patch_to_review": "diff --git a/Makefile b/Makefile\nindex 29db6389de87..668792009ff9 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -1,6 +1,11 @@\n SHELL=/bin/bash\n # Makefile for OpenDevin pro... | [
{
"diff_hunk": "@@ -1,6 +1,11 @@\n SHELL=/bin/bash\n # Makefile for OpenDevin project\n \n+# Check and set PYTHON_KEYRING_BACKEND if not already set\n+ifndef PYTHON_KEYRING_BACKEND\n+export PYTHON_KEYRING_BACKEND=keyring.backends.null.Keyring\n+endif",
"line": null,
"original_line": 7,
"original_sta... | 15555b7d908096d46de2a766b58a195682a76eae | diff --git a/Makefile b/Makefile
index 29db6389de87..00467a4b64dc 100644
--- a/Makefile
+++ b/Makefile
@@ -229,7 +229,7 @@ setup-config:
setup-config-prompts:
@echo "[core]" > $(CONFIG_FILE).tmp
- @read -p "Enter your workspace directory [default: $(DEFAULT_WORKSPACE_DIR)]: " workspace_dir; \
+ @read -p "Enter you... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "Dependency Updates & Env Compatibility"
} |
conan-io__conan-15135@e8932b0 | conan-io/conan | Python | 15,135 | fix migration lru | Changelog: Bugfix: Fix the 2.0.14 migration to add LRU data to the cache when ``storage_path`` conf is defined.
Docs: Omit
Close https://github.com/conan-io/conan/pull/15130
Close https://github.com/conan-io/conan/issues/15129 | 2023-11-19T14:10:42Z | 2.0.14's cache migrations do not respect core.cache:storage_path
### Environment details
* Operating System+version: Mac OS 13.4.1
* Compiler+version: n/a
* Conan version: 2.0.14
* Python version: 3.10.8
### Steps to reproduce
* install conan 2.0.13
* set `core.cache:storage_path` to something other than `~... | [
{
"body": "### Environment details\n\n* Operating System+version: Mac OS 13.4.1\r\n* Compiler+version: n/a\r\n* Conan version: 2.0.14\r\n* Python version: 3.10.8\r\n\n\n### Steps to reproduce\n\n* install conan 2.0.13\r\n\r\n* set `core.cache:storage_path` to something other than `~/.conan2/p`. remove `~/.con... | 63ee9c7cd6ea82c087cdfceb978fece170575d3f | {
"head_commit": "e8932b0603f4f447175140b918facfbf3d13878f",
"head_commit_message": "fix back migration",
"patch_to_review": "diff --git a/conan/api/subapi/config.py b/conan/api/subapi/config.py\nindex 22e30fd53b9..04b21e7bc18 100644\n--- a/conan/api/subapi/config.py\n+++ b/conan/api/subapi/config.py\n@@ -43,28 +... | [
{
"diff_hunk": "@@ -75,8 +78,21 @@ def _migrate_pkg_db_lru(cache_folder, old_version):\n undo_lru = textwrap.dedent(\"\"\"\\\n import os\n import sqlite3\n+\n def migrate(cache_folder):\n- db = os.path.join(cache_folder, 'p', 'cache.sqlite3')\n+ ... | 4e70892edf8d67bd83319fbf791bd3fae7e8e649 | diff --git a/conan/api/subapi/config.py b/conan/api/subapi/config.py
index f661c204ede..9c9d33960bb 100644
--- a/conan/api/subapi/config.py
+++ b/conan/api/subapi/config.py
@@ -46,32 +46,38 @@ def global_conf(self):
to the profile ones and passed to the conanfiles.conf, which can be passed to collaborators
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
conan-io__conan-15149@e2d89ff | conan-io/conan | Python | 15,149 | Add `core:warnings_as_errors` configuration option | Changelog: Feature: Add `core:warnings_as_errors` configuration option to make Conan raise on warnings and errors.
Docs: https://github.com/conan-io/docs/pull/3484
First try for `core:warnings_as_errors`. It worries me that people might want to have Conan stop processing on errors in this case (We mostly do that no... | 2023-11-21T15:21:13Z | [feature] Add "warnings as errors" mode
### What is your suggestion?
For example, sometimes when i'm developing a package I get: "Warning: No files in package"...I would like that to show up as an error. Of course, I guess that also implies the need to suppress warnings - so perhaps it's not so simple.
### Have you r... | Thanks for the suggestion @rconde01
There is already some capability of suppressing warnings in Conan 2.0 with ``core:skip_warnings``
I think this is a valid feature request and something we would be interesting to provide. It is true that ``core:skip_warnings`` is not capable of suppressing all warnings, only tho... | [
{
"body": "### What is your suggestion?\n\nFor example, sometimes when i'm developing a package I get: \"Warning: No files in package\"...I would like that to show up as an error. Of course, I guess that also implies the need to suppress warnings - so perhaps it's not so simple.\n\n### Have you read the CONTRIB... | aa844b6ba2bf6092f047741253a2080fa3cd9a2f | {
"head_commit": "e2d89ff206e043aa9c2485969dab962d044acc57",
"head_commit_message": "Add core:warnings_as_errors configuration option",
"patch_to_review": "diff --git a/conan/api/output.py b/conan/api/output.py\nindex 179d983cb13..a01eedfa1c7 100644\n--- a/conan/api/output.py\n+++ b/conan/api/output.py\n@@ -51,6 ... | [
{
"diff_hunk": "@@ -204,11 +209,16 @@ def success(self, msg):\n return self\n \n def warning(self, msg, warn_tag=None):\n- if self._conan_output_level <= LEVEL_WARNING:\n- if warn_tag is not None and warn_tag in self._silent_warn_tags:\n+ def _skip_warning():\n+ r... | 35e70a5de3052b09e142905dc567c4b79b45206c | diff --git a/conan/api/output.py b/conan/api/output.py
index 179d983cb13..ad8e541c379 100644
--- a/conan/api/output.py
+++ b/conan/api/output.py
@@ -51,6 +51,7 @@ class ConanOutput:
# Singleton
_conan_output_level = LEVEL_STATUS
_silent_warn_tags = []
+ _warnings_as_errors = False
def __init__(... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
keephq__keep-2167@779df81 | keephq/keep | Python | 2,167 | docs(providers): Added documentation for missing providers | [Fixes #2033]
/claim #2033
<!--
Thanks for creating this pull request 🤗
Please make sure that the pull request is limited to one type (docs, feature, etc.) and keep it as small as possible. You can open multiple prs instead of opening a huge one.
-->
Closes #2033
## ✅ Checks
<!-- Make sure y... | 2024-10-11T12:25:11Z | [📃 Docs]: Missing documentation for a few providers
Those providers are missing docs:
```
"service now",
"python",
"prometheus",
"gke",
"github",
"dynatrace",
"kafka",
"auth0",
"bash",
"keep",
"bigquery",
"parseable",
```
Python and bash are disabled for cloud, "keep" provider is a placeholder for a... | /bounty 25
## 💎 $25 bounty [• Keep (YC W23)](https://console.algora.io/org/keephq)
### Steps to solve:
1. **Start working**: Comment `/attempt #2033` with your implementation plan
2. **Submit work**: Create a pull request including `/claim #2033` in the PR body to claim the bounty
3. **Receive payment**: 100% of the ... | [
{
"body": "Those providers are missing docs:\r\n\r\n```\r\n\"service now\",\r\n\"python\",\r\n\"prometheus\",\r\n\"gke\",\r\n\"github\",\r\n\"dynatrace\",\r\n\"kafka\",\r\n\"auth0\",\r\n\"bash\",\r\n\"keep\",\r\n\"bigquery\",\r\n\"parseable\",\r\n```\r\n\r\nPython and bash are disabled for cloud, \"keep\" provi... | c4d7a30202f543248e076decb893c17eda84dace | {
"head_commit": "779df815e4147ca62c5ad14a734da45ef8972150",
"head_commit_message": "Added documentation for missing providers: service now, python, prometheus, etc. [Fixes #2033]",
"patch_to_review": "diff --git a/docs/providers/documentation/auth0-provider.mdx b/docs/providers/documentation/auth0-provider.mdx\n... | [
{
"diff_hunk": "@@ -0,0 +1,39 @@\n+---\n+title: \"Keep\"\n+sidebarTitle: \"Keep Provider\"\n+description: \"Keep provider acts as a placeholder for alerts without a specific provider.\"",
"line": null,
"original_line": 4,
"original_start_line": null,
"path": "docs/providers/documentation/keep-pr... | 5f6dcb628ac398fb6b1002a16e603f2bc32071ee | diff --git a/docs/mint.json b/docs/mint.json
index d1518d4ddf..2504bd46e0 100644
--- a/docs/mint.json
+++ b/docs/mint.json
@@ -107,84 +107,97 @@
{
"group": "Supported Providers",
"pages": [
- "providers/documentation/aks-provider",
- "providers/documentation/appdynam... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "Documentation Updates"
} |
keephq__keep-1984@e524fe8 | keephq/keep | Python | 1,984 | feat: topology applications api | <!--
Thanks for creating this pull request 🤗
Please make sure that the pull request is limited to one type (docs, feature, etc.) and keep it as small as possible. You can open multiple prs instead of opening a huge one.
-->
<!-- If this pull request closes an issue, please mention the issue number below -->
... | 2024-09-22T14:54:02Z | [➕ Feature] Allow to group services into applications in topology
**Reasoning**
If you happen to have huge system with a lot of services (100+ services), it would be beneficial to group them into applications and to enrich alerts with information about affected application.
**Describe the solution you'd like**
A... | [
{
"body": "**Reasoning**\r\nIf you happen to have huge system with a lot of services (100+ services), it would be beneficial to group them into applications and to enrich alerts with information about affected application. \r\n\r\n**Describe the solution you'd like**\r\nAs a user, I can select services on topol... | c41f345346278a49542156d46d9a6add5949177d | {
"head_commit": "e524fe8b45332e767e537ee6f159929097f33f14",
"head_commit_message": "fix: remove unused imports",
"patch_to_review": "diff --git a/keep/api/core/db.py b/keep/api/core/db.py\nindex 89c550c6dc..7cea195357 100644\n--- a/keep/api/core/db.py\n+++ b/keep/api/core/db.py\n@@ -2782,55 +2782,6 @@ def update... | [
{
"diff_hunk": "@@ -41,17 +43,91 @@ def get_topology_data(\n # )\n \n try:\n- topology_data = get_all_topology_data(\n- tenant_id, provider_id, service_id, environment\n+ topology_data = TopologiesService.get_all_topology_data(\n+ tenant_id, session, provider_id, ... | 0758182726684e237f44498b2000c801729d9f35 | diff --git a/docs/api-ref/topology/create-application.mdx b/docs/api-ref/topology/create-application.mdx
new file mode 100644
index 0000000000..6b05b9b7af
--- /dev/null
+++ b/docs/api-ref/topology/create-application.mdx
@@ -0,0 +1,3 @@
+---
+openapi: post /topology/applications
+---
\ No newline at end of file
diff --g... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
conan-io__conan-14760@ebd0191 | conan-io/conan | Python | 14,760 | Add `--dry-run` for `conan remove` | Changelog: Feature: Add `--dry-run` for `conan remove`.
Docs: https://github.com/conan-io/docs/pull/3404
After discussing with the team, the deciding factor was the difference in defaults between the semantics of `conan list` selection pattern and that of `conan remove`, which might make the usage of the pkglist fe... | 2023-09-17T23:23:37Z | [feature] conan remove should have a --dry-run option
### What is your suggestion?
`conan remove` asks for every package if it really should be deleted. This is really bothersome when removing many packages (e.g. when removing all but the last revision with `conan remove '*#!latest'`).
However, it would be nice to... | Hi @fschoenm thanks for your request.
Do you know about the packages lists feature? ([Release blog here](https://blog.conan.io/2023/06/28/Conan-bulk-package-operations.html))
It's a way to have the output of some commands be the input of a few others. [See here for an example of your use case](https://docs.conan.... | [
{
"body": "### What is your suggestion?\n\n`conan remove` asks for every package if it really should be deleted. This is really bothersome when removing many packages (e.g. when removing all but the last revision with `conan remove '*#!latest'`). \r\n\r\nHowever, it would be nice to see what is deleted before a... | 5353d85bcf18fd3ed2ece151fe8577abfe08bc1b | {
"head_commit": "ebd0191db2745488bc109b888e016496c97fa1c8",
"head_commit_message": "Add --dry-run for remove",
"patch_to_review": "diff --git a/conan/cli/commands/remove.py b/conan/cli/commands/remove.py\nindex a109a4b7494..2e6ea3c0475 100644\n--- a/conan/cli/commands/remove.py\n+++ b/conan/cli/commands/remove.p... | [
{
"diff_hunk": "@@ -65,7 +67,7 @@ def remove(conan_api: ConanAPI, parser, *args):\n cache_name = \"Local Cache\" if not remote else remote.name\n \n def confirmation(message):\n- return args.confirm or ui.request_boolean(message)\n+ return not args.dry_run and (args.confirm or ui.request_b... | d2cb7bba2d06f6ba5b17c5fe6427c2bcc8aa7246 | diff --git a/conan/cli/commands/remove.py b/conan/cli/commands/remove.py
index a109a4b7494..a1ef5b1c563 100644
--- a/conan/cli/commands/remove.py
+++ b/conan/cli/commands/remove.py
@@ -9,8 +9,8 @@
def summary_remove_list(results):
- """ Do litte format modification to serialized
- list bundle so it looks pre... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
keephq__keep-1977@728bdaf | keephq/keep | Python | 1,977 | feat: Added dashboard for Alert Quality | <!--
Thanks for creating this pull request 🤗
Please make sure that the pull request is limited to one type (docs, feature, etc.) and keep it as small as possible. You can open multiple prs instead of opening a huge one.
-->
<!-- If this pull request closes an issue, please mention the issue number below -->
... | 2024-09-21T16:06:45Z | [➕ Feature]: Alert quality widgets for a dashboard
Users connect a lot of providers for Keep, and we should provide some analytics about the quality of events coming out of those providers.
I propose to add a few widgets, and an auto-provisioned dashboard called "Alert quality".
Imagine a use-case when users wan... | /bounty 200
## 💎 $200 bounty [• Keep (YC W23)](https://console.algora.io/org/keephq)
### Steps to solve:
1. **Start working**: Comment `/attempt #1779` with your implementation plan
2. **Submit work**: Create a pull request including `/claim #1779` in the PR body to claim the bounty
3. **Receive payment**: 100% of th... | [
{
"body": "Users connect a lot of providers for Keep, and we should provide some analytics about the quality of events coming out of those providers.\r\n\r\nI propose to add a few widgets, and an auto-provisioned dashboard called \"Alert quality\". \r\n\r\nImagine a use-case when users wants to make sure that a... | e1e7eff1f21fb4d03457a4dfb2c400601d616983 | {
"head_commit": "728bdafc26a954b70dcdb36a6496886f789c80f5",
"head_commit_message": "Merge branch 'main' into main",
"patch_to_review": "diff --git a/keep-ui/app/alerts/quality/alert-quality-table.tsx b/keep-ui/app/alerts/quality/alert-quality-table.tsx\nnew file mode 100644\nindex 0000000000..cc035466ed\n--- /de... | [
{
"diff_hunk": "@@ -0,0 +1,12 @@\n+import QualityAlert from './alert-quality-table'; // Adjust the import path if needed\n+\n+const AlertQualityPage = () => {",
"line": null,
"original_line": 3,
"original_start_line": null,
"path": "keep-ui/app/alerts/quality/page.tsx",
"start_line": null,
... | 52ce66846afaa83cba7f7615d972a6ab02db258c | diff --git a/keep-ui/app/alerts/alert-quality-table.tsx b/keep-ui/app/alerts/alert-quality-table.tsx
new file mode 100644
index 0000000000..bdde64bc88
--- /dev/null
+++ b/keep-ui/app/alerts/alert-quality-table.tsx
@@ -0,0 +1,361 @@
+"use client"; // Add this line at the top to make this a Client Component
+
+import Rea... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
conan-io__conan-14752@a421a01 | conan-io/conan | Python | 14,752 | Feature/Add an option to install() method in package_manager | Changelog: Feature: Add `host_tool` to `install()` method in `package_manager` to indicate whether the package is a host tool or a library.
Docs: https://github.com/conan-io/docs/pull/3401
According to that the we will install a package for the needed arch (host arch or destination arch which can be different in ... | 2023-09-15T13:58:42Z | [bug] Install packages compatible with incorrect architecture
### Environment details
* Operating System+version: all
* Compiler+version: all
* Conan version: 2.0.9 (latest)
* Python version: all
### Steps to reproduce
1. Make sure settings.arch in your profile differs your host architecture, for example:... | Hi @LielHarel
Thanks for your report.
It is not completely clear that the "build" package is always the one to be installed. I understood that some distros allow the ``:arch`` precisely to be able to install some packages that can be used in cross-compilation scenarios, even if they don't match the current machi... | [
{
"body": "### Environment details\r\n\r\n* Operating System+version: all\r\n* Compiler+version: all\r\n* Conan version: 2.0.9 (latest)\r\n* Python version: all\r\n\r\n\r\n### Steps to reproduce\r\n\r\n1. Make sure settings.arch in your profile differs your host architecture, for example:\r\n If your host archi... | 1c5c5dd1c1a706f254fff332d0256d4bec0e29f1 | {
"head_commit": "a421a01b88843d2782bc3733d5bc00964f3fb02d",
"head_commit_message": "Merge branch 'release/2.0' into feature/add-options-when-install-pkgs",
"patch_to_review": "diff --git a/conan/tools/system/package_manager.py b/conan/tools/system/package_manager.py\nindex 87cb6b87174..c1d404dc378 100644\n--- a/... | [
{
"diff_hunk": "@@ -229,11 +229,51 @@ def fake_check(*args, **kwargs):\n return [\"package1\", \"package2\"]\n from conan.tools.system.package_manager import _SystemPackageManagerTool\n with patch.object(_SystemPackageManagerTool, 'check', MagicMock(side_effect=fake_check)):\n- ... | 818de3feed4bcebca0d40caffa649f86fa7fb0df | diff --git a/conan/tools/system/package_manager.py b/conan/tools/system/package_manager.py
index 87cb6b87174..59288f97278 100644
--- a/conan/tools/system/package_manager.py
+++ b/conan/tools/system/package_manager.py
@@ -62,9 +62,12 @@ def get_default_tool(self):
if d in os_name:
r... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
conan-io__conan-14532@c24b8e5 | conan-io/conan | Python | 14,532 | Allow settings_target across compatibility method | Changelog: Feature: Allow access to `settings_target` in compatibility method.
Docs: Omit
Closes #14527
In the info.py module, following the guidance provided in the comments for the settings_target property, this commit focuses on refining the handling of settings_target within various package methods.
Whe... | 2023-08-21T08:27:07Z | [feature][2.0.9] settings_target accessible in the compatibility method
### settings_target in compatibility
Hello,
Currently compatibility method does not allow a tool to be made compatible across various target settings, I have tested a use case with the following patch and it seems to work. Please have a look,... | Hi @adnan-ali1
Thanks for your request.
It is true that at the moment the ``compatibility()`` is only exposing and managing the minimum ``settings`` + ``options``, but not other elements. We typically wait for more real world use cases and requests for it, to make sure the right thing is being added.
I agree ... | [
{
"body": "### settings_target in compatibility\r\n\r\nHello,\r\n\r\nCurrently compatibility method does not allow a tool to be made compatible across various target settings, I have tested a use case with the following patch and it seems to work. Please have a look, if this makes sense then I can also create a... | d739ab66e1474e470952bdc6cdf5fc773a83ce74 | {
"head_commit": "c24b8e59d270886eb085598a3a1adc5d1c540e10",
"head_commit_message": "Adding testcase for compatibility check\n\nSigned-off-by: Adnan Ali <m_adnanali_1@hotmail.com>",
"patch_to_review": "diff --git a/conans/client/graph/compatibility.py b/conans/client/graph/compatibility.py\nindex 44c96b87c05..176... | [
{
"diff_hunk": "@@ -63,6 +63,10 @@ def compute_package_id(node, new_config):\n \n run_validate_package_id(conanfile)\n \n+ if (conanfile.info.settings_target):",
"line": null,
"original_line": 66,
"original_start_line": null,
"path": "conans/client/graph/compute_pid.py",
"start_line":... | f4fb21c2e5cad32bc4655d4ccd952939df8c693d | diff --git a/conans/client/graph/compatibility.py b/conans/client/graph/compatibility.py
index 44c96b87c05..960da6b39f2 100644
--- a/conans/client/graph/compatibility.py
+++ b/conans/client/graph/compatibility.py
@@ -96,6 +96,7 @@ def compatibles(self, conanfile):
# use the compatible ones
con... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
conan-io__conan-14510@2087c77 | conan-io/conan | Python | 14,510 | resolve version ranges for editables too | Changelog: Feature: Allow ``version-ranges`` to resolve to editable packages too.
Docs: Omit
Close https://github.com/conan-io/conan/issues/14507 | 2023-08-17T17:09:20Z | [question] Editables not considered for version ranges
### What is your question?
Say you have two packages pa and pb where pb uses pa via a version range. (E. g. `self.requires("pa/[>1.0]")`)
You can now create the packages pa (version 1.0.0) and pb (version 2.0.0).
Now I want to make changes to pa and test those... | Ok, after some experimenting, I did find two workarounds:
When I capture pb in a lockfile (`conan lock create .`) and then add the editable version of pa to the lockfile (`conan lock add --requires pa/1.0.1`) then I can create a pb binary package which uses the editable package without modifying the pb recipe.
Al... | [
{
"body": "### What is your question?\r\n\r\nSay you have two packages pa and pb where pb uses pa via a version range. (E. g. `self.requires(\"pa/[>1.0]\")`)\r\nYou can now create the packages pa (version 1.0.0) and pb (version 2.0.0).\r\nNow I want to make changes to pa and test those changes with pb. So I inc... | 67dbbfd9c98e8b1ba9af014dde029b572901293a | {
"head_commit": "2087c77cc159302e4713a14db23def5bd392466d",
"head_commit_message": "resolve version ranges for editables too",
"patch_to_review": "diff --git a/conans/client/graph/range_resolver.py b/conans/client/graph/range_resolver.py\nindex 6c0ea17d33a..0d374fc928e 100644\n--- a/conans/client/graph/range_res... | [
{
"diff_hunk": "@@ -54,6 +54,7 @@ def _resolve_local(self, search_ref, version_range):\n # TODO: This is still necessary to filter user/channel, until search_recipes is fixed\n local_found = [ref for ref in local_found if ref.user == search_ref.user\n and ref.c... | 7047b9eb9849c4d8606d8818491190c3979fc83f | diff --git a/conans/client/graph/range_resolver.py b/conans/client/graph/range_resolver.py
index 6c0ea17d33a..a4ac66eb99f 100644
--- a/conans/client/graph/range_resolver.py
+++ b/conans/client/graph/range_resolver.py
@@ -54,6 +54,9 @@ def _resolve_local(self, search_ref, version_range):
# TODO: This is sti... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
conan-io__conan-14320@8e0bb02 | conan-io/conan | Python | 14,320 | Add implements attribute in ConanFile to provide opt-in automatic management of some options and settings. | Changelog: Feature: Add `implements` attribute in ConanFile to provide automatic management of some options and settings.
Docs: https://github.com/conan-io/docs/pull/3303
Closes: https://github.com/conan-io/conan/issues/14308 | 2023-07-18T12:40:38Z | fPIC
### Environment details
* Operating System+version: Ubuntu 22.04
* Compiler+version: gcc 12.1
* Conan version: 2.0.8
* Python version: 3.10
Referring to commit 2af05b5: Why is fPIC automatically disabled when setting shared in the conanfile options? This was a sneaky change that took a while to discover an... | Hi @Halmoni100
Thanks for your report.
> Why is fPIC automatically disabled when setting shared in the conanfile options? This was a sneaky change that took a while to discover and presented an instability between Conan versions.
Conan 2.0.X patch releases main purpose is to stabilize the major Conan 2.0 rele... | [
{
"body": "### Environment details\n\n* Operating System+version: Ubuntu 22.04\r\n* Compiler+version: gcc 12.1\r\n* Conan version: 2.0.8\r\n* Python version: 3.10\r\n\r\nReferring to commit 2af05b5: Why is fPIC automatically disabled when setting shared in the conanfile options? This was a sneaky change that t... | 048295bd4bcc6be9692dab92e232248b67f9541c | {
"head_commit": "8e0bb02ac36abd7084e5d9cabdc571b3591a9912",
"head_commit_message": "fix comment",
"patch_to_review": "diff --git a/conan/tools/__init__.py b/conan/tools/__init__.py\nindex 06b817f9800..a8a45d35375 100644\n--- a/conan/tools/__init__.py\n+++ b/conan/tools/__init__.py\n@@ -1,9 +1,4 @@\n from conans.... | [
{
"diff_hunk": "@@ -0,0 +1,43 @@\n+import inspect\n+\n+from conans.model.pkg_type import PackageType\n+\n+\n+def call(module, implementation_name, conanfile_method, *args, **kwargs):\n+ # first check that we have at least one function in the module that starts\n+ # with the implementation name, then, when... | 3437b9012b02da3a20faf3d5ed5add8bfa729f0a | diff --git a/conan/tools/__init__.py b/conan/tools/__init__.py
index 06b817f9800..a8a45d35375 100644
--- a/conan/tools/__init__.py
+++ b/conan/tools/__init__.py
@@ -1,9 +1,4 @@
from conans.model.build_info import CppInfo as _CppInfo
-from conan.tools.helpers import (
- default_config_options,
- default_configure... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Dependency Updates & Env Compatibility"
} |
All-Hands-AI__OpenHands-1608@25f1b5e | All-Hands-AI/OpenHands | Python | 1,608 | Remove extra message actions | Fixes https://github.com/OpenDevin/OpenDevin/issues/1595 | 2024-05-06T21:11:03Z | Simplify Message actions/observations
## Summary
Currently we have five separate representations of messages/text in the system:
* AgentTalkAction
* UserMessageObservation
* AgentMessageObservation
* MessageAction
* AgentEchoAction
* AgentThinkAction
Each of these serves a slightly different purpose in a diff... | Overall I basically agree with this, I like the simplicity!
> This breaks AgentEchoAction, which is being used by CodeAct, though I'm not sure how. Hopefully @xingyaoww can provide guidance here.
I think `AgentEchoAction` is no longer used by CodeAct, so if other agents are not using it, it is probably save to remov... | [
{
"body": "## Summary\r\nCurrently we have five separate representations of messages/text in the system:\r\n* AgentTalkAction\r\n* UserMessageObservation\r\n* AgentMessageObservation\r\n* MessageAction\r\n* AgentEchoAction\r\n* AgentThinkAction\r\n\r\nEach of these serves a slightly different purpose in a diffe... | 4a2a35b6cff372353dbd5359142dd2c962172f0b | {
"head_commit": "25f1b5ec142e9f3ca2b457b3fdf71cdf284806d3",
"head_commit_message": "help agent exit after hitting max iter",
"patch_to_review": "diff --git a/.gitignore b/.gitignore\nindex 59ef90eaced8..e123abaee8fe 100644\n--- a/.gitignore\n+++ b/.gitignore\n@@ -196,6 +196,7 @@ logs\n # agent\n .envrc\n /worksp... | [
{
"diff_hunk": "@@ -0,0 +1,18 @@\n+from dataclasses import dataclass\n+\n+from opendevin.core.schema import ObservationType\n+\n+from .observation import Observation\n+\n+\n+@dataclass\n+class SuccessObservation(Observation):\n+ \"\"\"\n+ This data class represents an error encountered by the agent.",
... | 4f14788bdde6f9b48108985f6c275bc62da6ba10 | diff --git a/.gitignore b/.gitignore
index 59ef90eaced8..e123abaee8fe 100644
--- a/.gitignore
+++ b/.gitignore
@@ -196,6 +196,7 @@ logs
# agent
.envrc
/workspace
+/_test_workspace
/debug
cache
diff --git a/agenthub/README.md b/agenthub/README.md
index d4c80e8214d9..b69a1739c6ea 100644
--- a/agenthub/README.md
++... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Code Refactoring / Architectural Improvement"
} |
conan-io__conan-14133@53a1170 | conan-io/conan | Python | 14,133 | Add MakeDeps generator | Changelog: Feature: Add support to Makefile by the new MakeDeps generator
Docs: https://github.com/conan-io/docs/pull/3348
closes #13394
This PR adds a new feature, the `MakeDeps` generator, that can be used with Conan install command: `conan install --requires=foobar/0.1.0 -g MakeDeps`. The idea is bringing back ... | 2023-06-20T12:36:52Z | [question] What's the intended way to work with makefiles without autotools in 2.0
### What is your question?
I'm new to Conan with 2.0 and my team is currently using custom makefiles without autotools to build our projects. Googling around I end up on 1.x docs of Conan where there does seem to be built in generators ... | Hi @daltonv
Not sure if you are aware of the ``conan new autotools_lib -d name=pkg -d version=0.1``.
It is true that it is an autotools project, not a pure Makefile one, but I think stripping out the autotools part should be relatively easy and the overall approach should be a good start.
> I can just not have ... | [
{
"body": "### What is your question?\n\nI'm new to Conan with 2.0 and my team is currently using custom makefiles without autotools to build our projects. Googling around I end up on 1.x docs of Conan where there does seem to be built in generators for makefiles. So how do I work with makefiles in 2.0?\r\n\r\n... | b43eb83956f053a47cc3897cfdd57b9da13a16e6 | {
"head_commit": "53a117037bb7bf26e5c450d22a27af3cca010737",
"head_commit_message": "Add Make (and shell) generator (#13394)",
"patch_to_review": "diff --git a/conan/tools/misc/__init__.py b/conan/tools/misc/__init__.py\nnew file mode 100644\nindex 00000000000..0351dc5e13b\n--- /dev/null\n+++ b/conan/tools/misc/_... | [
{
"diff_hunk": "@@ -0,0 +1,213 @@\n+import os.path\n+import platform\n+import re\n+import textwrap\n+\n+import pytest\n+\n+from conans.test.assets.genconanfile import GenConanfile\n+from conans.test.utils.tools import TestClient\n+\n+\n+@pytest.mark.skipif(platform.system() not in [\"Linux\", \"Darwin\"], reaso... | 614c2731e4ddd12cde901be37f2be79167bf1bcc | diff --git a/conan/tools/gnu/__init__.py b/conan/tools/gnu/__init__.py
index a7c75b32404..9c413ed2145 100644
--- a/conan/tools/gnu/__init__.py
+++ b/conan/tools/gnu/__init__.py
@@ -3,3 +3,4 @@
from conan.tools.gnu.autotoolsdeps import AutotoolsDeps
from conan.tools.gnu.pkgconfig import PkgConfig
from conan.tools.gnu... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Documentation Updates"
} |
conan-io__conan-14063@396f479 | conan-io/conan | Python | 14,063 | Git.clone change folder to target one | Changelog: Fix: Allow spaces in path in ``Git`` helper.
Docs: https://github.com/conan-io/docs/pull/3271
Close https://github.com/conan-io/conan/issues/14058
| 2023-06-09T17:46:13Z | [bug] Git.checkout() with a target folder doesn't work with the remaining Git functions
### Environment details
* Operating System+version: n/a
* Compiler+version: n/a
* Conan version: 2.0.6
* Python version: 3.11
### Steps to reproduce
The `conan.tools.scm.Git` interface seems lacking. If I specify a `ta... | Hi @fschoenm
Thanks for your report.
The ``Git()`` constructor itself is nothing but a caching of the target folder to use, for convenience, and the folder is a public attribute. So this works:
````python
def source(self):
git = Git(self)
target = os.path.join(self.source_folder, "target")... | [
{
"body": "### Environment details\r\n\r\n* Operating System+version: n/a\r\n* Compiler+version: n/a\r\n* Conan version: 2.0.6\r\n* Python version: 3.11\r\n\r\n\r\n### Steps to reproduce\r\n\r\nThe `conan.tools.scm.Git` interface seems lacking. If I specify a `target` folder in the `clone()` command, there seem... | 67f472df4ff480397bbf79fbcfccefb72144cce6 | {
"head_commit": "396f479e5614c75f0870f0ca672eaf13d755b052",
"head_commit_message": "not automatic cd folder",
"patch_to_review": "diff --git a/conan/tools/scm/git.py b/conan/tools/scm/git.py\nindex 60441e09461..a47caa0b905 100644\n--- a/conan/tools/scm/git.py\n+++ b/conan/tools/scm/git.py\n@@ -162,7 +162,8 @@ de... | [
{
"diff_hunk": "@@ -210,6 +210,49 @@ def test_clone_checkout(self):\n assert c.load(\"source/src/myfile.h\") == \"myheader!\"\n assert c.load(\"source/CMakeLists.txt\") == \"mycmake\"\n \n+ def test_clone_target(self):\n+ # Clone to a different target folder\n+ # https://github.... | 2ba1ac713d8fa628e99f40bbf115b9b56e83e95b | diff --git a/conan/tools/scm/git.py b/conan/tools/scm/git.py
index 60441e09461..a47caa0b905 100644
--- a/conan/tools/scm/git.py
+++ b/conan/tools/scm/git.py
@@ -162,7 +162,8 @@ def clone(self, url, target="", args=None):
url = url.replace("\\", "/") # Windows local directory
mkdir(self.folder)
... | {
"difficulty": "medium",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
keephq__keep-1480@4c15faf | keephq/keep | Python | 1,480 | feat: API endpoint to see how many alerts a provider has sent | - add service function in api/core/db.py
- add endpoint in api/routes/providers.py
<!--
Thanks for creating this pull request 🤗
Please make sure that the pull request is limited to one type (docs, feature, etc.) and keep it as small as possible. You can open multiple prs instead of opening a huge one.
-->
... | 2024-07-28T03:02:43Z | [➕ Feature] API endpoint to see how many alerts a provider has sent
This endpoint could be then used to monitor the "health" of some provider or just expose some BI of trends.
**Describe your use case**
An API endpoint that exposes the number of alerts a specific provider has received (in a specific time time perio... | @talboren maybe worth making it a prometheus-formatted metrics exporter endpoint?
/bounty 30
/attempt #1249
<div id="algora-attempt" />
| [Algora profile](https://console.algora.io/@/35C4n0r) | Completed bounties | Tech | Active attempts | Options |
| --- | --- | --- | --- | --- |
| @35C4n0r | 11 ke... | [
{
"body": "This endpoint could be then used to monitor the \"health\" of some provider or just expose some BI of trends.\r\n\r\n**Describe your use case**\r\nAn API endpoint that exposes the number of alerts a specific provider has received (in a specific time time period or ever)\r\n\r\n**Are you already using... | c0be6a5f04f35890cb099d5baabbc67b2afe302e | {
"head_commit": "4c15faf95ad538ec64d5f34ee234100fee8acbb5",
"head_commit_message": "feat: add api endpoint to count alerts recieved by a provider\n\n- add service function in api/core/db.py\n- add endpoint in api/routes/providers.py\n\nSigned-off-by: 35C4n0r <jaykumar20march@gmail.com>",
"patch_to_review": "diff... | [
{
"diff_hunk": "@@ -229,6 +229,35 @@ def get_alerts_schema(\n raise HTTPException(404, detail=f\"Provider {provider_type} not found\")\n \n \n+@router.get(\"/{provider_type}/{provider_id}/alerts/count\")\n+def get_alert_count(\n+ provider_type: str,\n+ provider_id: str,\n+ ever: bool,\n+ sta... | 63a4f4a9228b2b50c4635281c3ca06be4528955b | diff --git a/keep/api/core/db.py b/keep/api/core/db.py
index aabb21562b..b86889a8bd 100644
--- a/keep/api/core/db.py
+++ b/keep/api/core/db.py
@@ -733,6 +733,39 @@ def enrich_alert(
)
+def count_alerts(
+ provider_type: str,
+ provider_id: str,
+ ever: bool,
+ start_time: Optional[datetime],
+ e... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Performance Optimizations"
} |
conan-io__conan-13934@24964cc | conan-io/conan | Python | 13,934 | [graph] Changed graph info json output | Changelog: Bugfix: Fixed and completed the `graph info xxxx --format json` output, to publicly document it.
Docs: https://github.com/conan-io/docs/pull/3236
Closes: https://github.com/conan-io/conan/issues/13911
Closes: https://github.com/conan-io/conan/issues/13862
For instance:
```
{
"nodes": {
... | 2023-05-22T14:13:25Z | [question] Conan2: Reading / dumping version ranges for dependencies ?
### What is your question?
In order to integrate a Coan2 into our existing CI infrastructure, we would like to print (or dump to file) not only the RESOLVED dependencies (such as those found in self.dependencies) but also the requirement as set in... | Hi @ATS-AValli
Thanks for your question.
To see if I understood it correctly, you would like to have the same or equivalent of what is printed to screen in the json output of ``conan graph info .. --format=json``?
We plan to put some time this sprint to improve and stabilize that ``json`` output, so we could ... | [
{
"body": "### What is your question?\n\nIn order to integrate a Coan2 into our existing CI infrastructure, we would like to print (or dump to file) not only the RESOLVED dependencies (such as those found in self.dependencies) but also the requirement as set in the requirements() method, that could be a versio... | 2a17403626451b7f62cd77eccba80664e1f3d0c8 | {
"head_commit": "24964cc571ab051be3390fa21e2e8b74e8289871",
"head_commit_message": "Printing the same",
"patch_to_review": "diff --git a/conan/cli/formatters/graph/graph_info_text.py b/conan/cli/formatters/graph/graph_info_text.py\nindex 6c5edc90227..55b6e258a82 100644\n--- a/conan/cli/formatters/graph/graph_inf... | [
{
"diff_hunk": "@@ -224,7 +238,8 @@ def serialize(self):\n result.update(self.conanfile.serialize())\n result[\"context\"] = self.context\n result[\"test\"] = self.test\n- result[\"requires\"] = {n.id: n.ref.repr_notime() for n in self.neighbors()}\n+ result[\"transitive_de... | 1c9edb592f1c79428d27e1ee0339024ef794a17c | diff --git a/conan/cli/formatters/graph/graph.py b/conan/cli/formatters/graph/graph.py
index 3c6ef38df8e..878a90758a0 100644
--- a/conan/cli/formatters/graph/graph.py
+++ b/conan/cli/formatters/graph/graph.py
@@ -14,6 +14,8 @@
from conans.util.files import load
+# FIXME: Check all this code when format_graph_[html... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Test Suite / CI Enhancements"
} |
All-Hands-AI__OpenHands-1573@72beaa8 | All-Hands-AI/OpenHands | Python | 1,573 | feat(frontend): "Reset to Default" button | - Added "Reset to Default" button to frontend settings modal
- Adjusted i18n to reflect button translation
- Passed `key` prop to `<AutocompleteCombobox />` to trigger re-rendering with default values when settings are set to default. | 2024-05-04T07:16:03Z | Settings Modal: Add a "Reset to Defaults" button
**What problem or use case are you trying to solve?**
Some users might randomly click around and mess up their settings. We should have an easy way to get back to the original state.
**Describe the UX of the solution you'd like**
A button in the settings modal that ... | Hi, i have created a PR for that feature | [
{
"body": "**What problem or use case are you trying to solve?**\r\nSome users might randomly click around and mess up their settings. We should have an easy way to get back to the original state.\r\n\r\n**Describe the UX of the solution you'd like**\r\nA button in the settings modal that says \"Reset to Defaul... | fda21d2ce32496644b9de07154cfb782d6b677d3 | {
"head_commit": "72beaa8e909052c33c6d22bef042e685400075d9",
"head_commit_message": "frontend: separate selectedKey and inputValue in Autocompletecombobox",
"patch_to_review": "diff --git a/frontend/src/components/modals/settings/AutocompleteCombobox.test.tsx b/frontend/src/components/modals/settings/Autocomplete... | [
{
"diff_hunk": "@@ -58,16 +67,21 @@ export function AutocompleteCombobox({\n label={t(LABELS[ariaLabel])}\n placeholder={t(PLACEHOLDERS[ariaLabel])}\n defaultItems={items}\n- inputValue={\n- // Find the label for the default key, otherwise use the default key itself\n- ... | 13870575a7c71815bef4871f5155853e1bc5a625 | diff --git a/frontend/src/components/modals/settings/AutocompleteCombobox.test.tsx b/frontend/src/components/modals/settings/AutocompleteCombobox.test.tsx
index 43385a148da1..95909c69e39f 100644
--- a/frontend/src/components/modals/settings/AutocompleteCombobox.test.tsx
+++ b/frontend/src/components/modals/settings/Aut... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
conan-io__conan-13999@05094d8 | conan-io/conan | Python | 13,999 | Add conan version as separated command | Changelog: Feature: Add new command `conan version` to format the output.
Docs: https://github.com/conan-io/docs/pull/3243
The `--version` option stays as usual, but `conan version` offer format output.
closes https://github.com/conan-io/conan/issues/13952
- [x] Refer to the issue that supports this Pull Requ... | 2023-05-30T13:57:16Z | [feature] Include `conan --version` command in `conan --help` text
### What is your suggestion?
Hi,
1. When I use, `conan --help` command, I can see help text message around `conan --version`. Currently, `conan --version` command is hidden and not documented in help message. This is so, as a user I can identify w... | Hi @meghfossa
Thanks for your suggestion.
However, I think this proposal goes a bit too far. Basically all other tools out there do not implement anything remotely similar. ``cmake --version``, ``gcc --version``, etc, which one is expected to be able to give a json output? None of them. Furthermore, reporting al... | [
{
"body": "### What is your suggestion?\n\nHi, \r\n\r\n1. When I use, `conan --help` command, I can see help text message around `conan --version`. Currently, `conan --version` command is hidden and not documented in help message. This is so, as a user I can identify which conan version I'm using easily.\r\n2.... | 9a00e9f182b4bfbc183463f4b1954a21985fd9d2 | {
"head_commit": "05094d84334c9d6598e1ce8d99f0136c5dd1d1bf",
"head_commit_message": "Add conan version command\n\nSigned-off-by: Uilian Ries <uilianries@gmail.com>",
"patch_to_review": "diff --git a/conan/cli/commands/version.py b/conan/cli/commands/version.py\nnew file mode 100644\nindex 00000000000..0a388002fe5... | [
{
"diff_hunk": "@@ -0,0 +1,19 @@\n+from conans.test.utils.tools import TestClient\n+\n+\n+def test_version_json():\n+ t = TestClient()\n+ t.run(\"version --format=json\")\n+ assert ['{', ' \"version\": \"2.0.4\"', '}'] == t.out.splitlines()",
"line": null,
"original_line": 7,
"original_s... | 24e82abc209009f1be60c268886b704939bacdc6 | diff --git a/conan/cli/commands/version.py b/conan/cli/commands/version.py
new file mode 100644
index 00000000000..507f0f7d16e
--- /dev/null
+++ b/conan/cli/commands/version.py
@@ -0,0 +1,21 @@
+from conan.cli.commands.list import print_serial
+from conan.cli.command import conan_command
+from conan.cli.formatters impo... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "New Feature Additions"
} |
conan-io__conan-13841@935b224 | conan-io/conan | Python | 13,841 | CMakeDeps: Fix imported library config suffix | Currently the imported libraries are set without config suffix first. At the end there is one additional set using the config suffix, which overwrites the already set libraries.
Fixes #13504
Changelog: Fix: Fix imported library config suffix.
Docs: Omit
- [X] Refer to the issue that supports this Pull Request... | 2023-05-08T10:36:18Z | [bug] In the CMakeDeps Generator IMPORTED_LOCATION is overridden by IMPORTED_LOCATION${config_suffix}
### Environment details
* Operating System+version: Windows 10
* Compiler+version: MSVC 19
* Conan version: 2.0.2
* Python version: 3.10
### Steps to reproduce
1. Download a dependency (e.g. thrift) with ... | The right thing is to not set IMPORTED_LOCATION at all.
Instead IMPORTED_LOCATION_DEBUG or IMPORTED_LOCATION_RELEASE shall be set to the Library for LIBRARY targets and to the dll (or so) for a shared library. For the latter IMPORTED_IMPLIB_DEBUG or IMPORTED_IMPLIB_RELEASE has to be set to the library. IMPORTED_LOCA... | [
{
"body": "### Environment details\r\n\r\n* Operating System+version: Windows 10\r\n* Compiler+version: MSVC 19\r\n* Conan version: 2.0.2\r\n* Python version: 3.10\r\n\r\n\r\n### Steps to reproduce\r\n\r\n1. Download a dependency (e.g. thrift) with conan using the CMakeDeps generator\r\n2. Have a look at the cr... | b5e840cac71f43ae67431920785ae223010e7296 | {
"head_commit": "935b224a3bb218aa87b8b52e156d6477202733fe",
"head_commit_message": "test_cmake_target_runtime_dlls: requires cmake 3.21",
"patch_to_review": "diff --git a/conan/tools/cmake/cmakedeps/templates/macros.py b/conan/tools/cmake/cmakedeps/templates/macros.py\nindex d3249bcea11..dbddc69d80a 100644\n--- ... | [
{
"diff_hunk": "@@ -661,6 +661,37 @@ def package_info(self):\n assert \"talk: Release!\" in client.out\n assert \"main: Debug!\" in client.out\n \n+@pytest.mark.tool(\"cmake\", \"3.21\")",
"line": null,
"original_line": 664,
"original_start_line": null,
"path": "conans/test/functional/to... | 83300a7337ba7cbb710f6109eb2ebb2f382ce7aa | diff --git a/conan/tools/cmake/cmakedeps/templates/macros.py b/conan/tools/cmake/cmakedeps/templates/macros.py
index d3249bcea11..dbddc69d80a 100644
--- a/conan/tools/cmake/cmakedeps/templates/macros.py
+++ b/conan/tools/cmake/cmakedeps/templates/macros.py
@@ -67,13 +67,13 @@ def template(self):
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
conan-io__conan-13918@7695e46 | conan-io/conan | Python | 13,918 | Metadata files upload/download | Changelog: Feature: New metadata files associated to recipes and packages that can be uploaded, downloaded and added after the package exists.
Docs: Omit
This proposal implements upload + download flows, but not ``conan install`` or ``conan create`` installation of metadata. That would add too much extra complexity... | 2023-05-18T09:59:22Z | Embed test_package in the recipe
Provide a way to avoid having a `test_package` folder. Maybe declaring the contents of a `main.c/cpp` in the recipe could be enough. It would be nice because:
- You could contribute with only a conanfile.py to a library, without polluting the repository.
- The `conan install --buil... | Sometimes we use an example or test from the author. We just copy the original file to test_package.
We could provide a new helper to point that specific file, build (generate cmake, link conan libs) and run.
More things to discuss:
- Does it build the test in the cache ``test/hash`` folder? I'd say yes.
- CMake... | [
{
"body": "Provide a way to avoid having a `test_package` folder. Maybe declaring the contents of a `main.c/cpp` in the recipe could be enough. It would be nice because:\r\n\r\n- You could contribute with only a conanfile.py to a library, without polluting the repository.\r\n- The `conan install --build` could... | 6d9d48d4ae0d50fa566bf704af43d04fcdfd94eb | {
"head_commit": "7695e46b983b288b10ff6c08287d3f0358be5ef9",
"head_commit_message": "wip",
"patch_to_review": "diff --git a/conan/api/subapi/cache.py b/conan/api/subapi/cache.py\nindex 11f0b0073b4..d1d637fc3fe 100644\n--- a/conan/api/subapi/cache.py\n+++ b/conan/api/subapi/cache.py\n@@ -19,6 +19,12 @@ def export_... | [
{
"diff_hunk": "@@ -0,0 +1,38 @@\n+import fnmatch\n+import os\n+\n+from conan.api.output import ConanOutput\n+\n+\n+def _metadata_files(folder, metadata):\n+ result = {}\n+ for root, _, files in os.walk(folder):\n+ for f in files:\n+ abs_path = os.path.join(root, f)\n+ relpath... | 59ce499eaa36fa659ca2f2b42e8489e4255d78d5 | diff --git a/conan/api/subapi/cache.py b/conan/api/subapi/cache.py
index 8f41cfd92e7..d7160a03f80 100644
--- a/conan/api/subapi/cache.py
+++ b/conan/api/subapi/cache.py
@@ -19,6 +19,12 @@ def export_path(self, ref: RecipeReference):
ref_layout = app.cache.recipe_layout(ref)
return ref_layout.export()
... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
All-Hands-AI__OpenHands-1319@12f6016 | All-Hands-AI/OpenHands | Python | 1,319 | feat: set API key from settings modal | depends on https://github.com/OpenDevin/OpenDevin/pull/1291
fix https://github.com/OpenDevin/OpenDevin/issues/1146 | 2024-04-23T21:16:30Z | Setting for API key in the UI
**What problem or use case are you trying to solve?**
Let the user paste their API key into the UI
**Describe the UX of the solution you'd like**
A password box in the settings modal.
It should be saved in local storage, and associated with the selected model.
If the user chang... | I think the GUI should also prevent users from modifying API key when a task is executing.
@li-boxuan that does sound reasonable! Honestly all settings should probably be frozen while a task is in progress
Being frozen is quite necessary. I may prefer that people first finish the setup first, and then run the whole tas... | [
{
"body": "**What problem or use case are you trying to solve?**\r\nLet the user paste their API key into the UI\r\n\r\n**Describe the UX of the solution you'd like**\r\nA password box in the settings modal. \r\n\r\nIt should be saved in local storage, and associated with the selected model.\r\n\r\nIf the user ... | 11d48cc2f3f659210e8bdf2bdf16aefcb466e9c5 | {
"head_commit": "12f6016d4afb4be77fcb709ac5fa44021483a25b",
"head_commit_message": "fix settings update",
"patch_to_review": "diff --git a/frontend/src/components/file-explorer/FileExplorer.tsx b/frontend/src/components/file-explorer/FileExplorer.tsx\nindex f66f1c72a955..89bc6c716ff9 100644\n--- a/frontend/src/c... | [
{
"diff_hunk": "@@ -46,6 +46,11 @@ function SettingsModal({ isOpen, onOpenChange }: SettingsProps) {\n \n const handleModelChange = (model: string) => {\n setSettings((prev) => ({ ...prev, LLM_MODEL: model }));\n+ // Needs to also reset the API key.\n+ const key = localStorage.getItem(\n+ `API_... | 8c860a6aca5d52dc7553408cabd66b00e39393e0 | diff --git a/frontend/src/components/file-explorer/FileExplorer.tsx b/frontend/src/components/file-explorer/FileExplorer.tsx
index f66f1c72a955..89bc6c716ff9 100644
--- a/frontend/src/components/file-explorer/FileExplorer.tsx
+++ b/frontend/src/components/file-explorer/FileExplorer.tsx
@@ -1,4 +1,3 @@
-import { Workspa... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
conan-io__conan-13721@68151a9 | conan-io/conan | Python | 13,721 | Render profile name when using Jinja2 | Parse the profile file name (including its extension) as profile_name for Jinja2 context.
Changelog: Feature: Render the profile file name as profile_name
Docs: https://github.com/conan-io/docs/pull/3180
closes #13698
- [ ] Refer to the issue that supports this Pull Request.
- [ ] If the issue has missing in... | 2023-04-19T12:29:50Z | [feature] Add profile_name variable to profile rendering
### What is your suggestion?
Feature request: Please add `profile_name` variable into profile templates - this will help a lot for the use case with large number of profiles.
In our use case, we have dozens of profiles that have pattern-style names like `<os>... | Hi @andrey-zherikov
Thanks for your suggestion.
I understand the use case, I think it is possible to add it, and it should be relatively straightforward. Would you like to contribute yourself the feature? (don't worry if you don't, we will do it). A couple of notes:
- This kind of new feature should go to next ... | [
{
"body": "### What is your suggestion?\n\nFeature request: Please add `profile_name` variable into profile templates - this will help a lot for the use case with large number of profiles.\r\n\r\nIn our use case, we have dozens of profiles that have pattern-style names like `<os>_<compiler>_<version>_<arch>`. S... | 0efbe7e49fdf554da4d897735b357d85b2a75aca | {
"head_commit": "68151a9d83a9c8ce71618701bbfcff45d4a153ca",
"head_commit_message": "Render profile name\n\nSigned-off-by: Uilian Ries <uilianries@gmail.com>",
"patch_to_review": "diff --git a/conans/client/profile_loader.py b/conans/client/profile_loader.py\nindex 42603045d4a..250ba57baa7 100644\n--- a/conans/cl... | [
{
"diff_hunk": "@@ -105,3 +106,40 @@ def test_profile_version():\n client.run(\"install . -pr=profile1.jinja\")\n assert f\"*:myoption={conan_version}\" in client.out\n assert \"*:myoption2=True\" in client.out\n+\n+\n+def test_profile_template_profile_name():\n+ \"\"\"\n+ The property pro... | c3695a63f0119780a166466c510ce4047d6ceb54 | diff --git a/conans/client/profile_loader.py b/conans/client/profile_loader.py
index 42603045d4a..250ba57baa7 100644
--- a/conans/client/profile_loader.py
+++ b/conans/client/profile_loader.py
@@ -158,9 +158,11 @@ def _load_profile(self, profile_name, cwd):
# All profiles will be now rendered with jinja2 as ... | {
"difficulty": "low",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
keephq__keep-1388@feaefd5 | keephq/keep | Python | 1,388 | feat: incidents | 2024-07-16T15:00:08Z | [➕ Feature]: Incidents
Introduce the incident page and the Incident data model.
**Data model:**
For now, incidents from some providers are pulled as "alerts", they should be pulled as "incidents".
**UI:**
User should be able to manually CRUD Many:One relationships between Alerts and Incidents. Also please note ... | @Matvey-Kuk @VladimirFilonov can we maybe elaborate further on the actual data model for incidents (e.g., actual fields: incident id, name, description, started, ended, who participated, affected services, etc.)
@Matvey-Kuk is it true that alerts can be related with more than 1 incident? e.g. it's Many<alerts>:One<i... | [
{
"body": "Introduce the incident page and the Incident data model.\r\n\r\n**Data model:**\r\nFor now, incidents from some providers are pulled as \"alerts\", they should be pulled as \"incidents\".\r\n\r\n**UI:**\r\nUser should be able to manually CRUD Many:One relationships between Alerts and Incidents. Also ... | ce96e1f0afb3e2e24ec31ad9957405b752a62ffc | {
"head_commit": "feaefd58f457518f0fa9533b31fe1ad2b45adf56",
"head_commit_message": "fix: tests",
"patch_to_review": "diff --git a/LICENSE b/LICENSE\nindex 442fd8f34f..ff7b6827b6 100644\n--- a/LICENSE\n+++ b/LICENSE\n@@ -1,7 +1,10 @@\n-MIT License\n-\n Copyright (c) 2024 Keep\n \n+Portions of this software are li... | [
{
"diff_hunk": "@@ -0,0 +1,392 @@\n+import logging\n+import os\n+import pathlib\n+import sys\n+from typing import List\n+\n+from fastapi import APIRouter, Depends, HTTPException, Response\n+from pusher import Pusher\n+from pydantic.types import UUID\n+\n+from keep.api.core.db import (\n+ add_alerts_to_incide... | d17d7c9dca7bd4edaa7868ca1d8973ea4cf20e7c | diff --git a/.github/workflows/test-pr-e2e.yml b/.github/workflows/test-pr-e2e.yml
index 2e07c6d622..9ebaa40d3a 100644
--- a/.github/workflows/test-pr-e2e.yml
+++ b/.github/workflows/test-pr-e2e.yml
@@ -8,6 +8,10 @@ on:
- 'keep-ui/**'
- 'tests/**'
+concurrency:
+ group: ${{ github.workflow }}-${{ githu... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
conan-io__conan-13757@13b0728 | conan-io/conan | Python | 13,757 | Allow specifying a custom output for the deployers | Changelog: Feature: Allow to specify a custom deployer output folder.
Docs: https://github.com/conan-io/docs/pull/3275
Closes #13728 | 2023-04-24T09:48:55Z | [question] Conan 2.0 custom deployer + output folder
### What is your question?
Hi, I am trying to deploy the binaries of a package with Conan 2.0. I created a simple custom deployer (my_deployer.py) that basically copies the binaries directly to the output folder:
```
from conan.tools.files import copy
def dep... | Hi @malonsorightware, thanks for your question.
The deployers do not get an independent output folder from the install one. The trick here would be to change your custom deployer to something relative to the `output_folder`. This is also how the built-in ones do it:
```
import os
from conan.tools.files import cop... | [
{
"body": "### What is your question?\n\nHi, I am trying to deploy the binaries of a package with Conan 2.0. I created a simple custom deployer (my_deployer.py) that basically copies the binaries directly to the output folder:\r\n\r\n```\r\nfrom conan.tools.files import copy\r\n\r\ndef deploy(graph, output_fold... | a8074a2be4f7e48b328ced4417846a1b318a925e | {
"head_commit": "13b07289de45fdcbd62b60373b66fcdff9583522",
"head_commit_message": "Allow specifying a custom output for the deployers",
"patch_to_review": "diff --git a/conan/api/subapi/install.py b/conan/api/subapi/install.py\nindex 71ba81889cb..1ad83e8c291 100644\n--- a/conan/api/subapi/install.py\n+++ b/cona... | [
{
"diff_hunk": "@@ -118,6 +119,8 @@ def graph_info(conan_api, parser, subparser, *args):\n help='Print information only for packages that match the patterns')\n subparser.add_argument(\"-d\", \"--deployer\", action=\"append\",\n help='Deploy using the pr... | 69de46cd794aa189d043dcad3cd89cfc09745197 | diff --git a/conan/api/subapi/install.py b/conan/api/subapi/install.py
index 71ba81889cb..64f827472b4 100644
--- a/conan/api/subapi/install.py
+++ b/conan/api/subapi/install.py
@@ -3,7 +3,6 @@
from conans.client.generators import write_generators
from conans.client.installer import BinaryInstaller
from conans.errors... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
conan-io__conan-13571@ea8a185 | conan-io/conan | Python | 13,571 | conf dict updates | Changelog: Feature: Introduce the ``conf`` dictionary update semantics with ``*=`` operator.
Docs: https://github.com/conan-io/docs/pull/3141
Close https://github.com/conan-io/conan/issues/13535 | 2023-03-30T11:54:08Z | [feature] Add support for updating values of a dictionary type configuration in profile (e.g. tools.build:compiler_executables)
### What is your suggestion?
Hi there!
I am proposing a new feature for Conan package manager that would allow updating values of a dictionary configuration like `tools.build:compiler_ex... | HI @todorico
I think this might be possible, lets give it a try. | [
{
"body": "### What is your suggestion?\r\n\r\nHi there!\r\n\r\nI am proposing a new feature for Conan package manager that would allow updating values of a dictionary configuration like `tools.build:compiler_executables` in the same way we can already append or prepend values of a list configuration. This woul... | abaa69c1018ba2a5fcdef89cede1b966fad2b0e0 | {
"head_commit": "ea8a185c6d0cb8dd490e5cfe9b7a54bf4050d0c9",
"head_commit_message": "conf dict updates",
"patch_to_review": "diff --git a/conans/model/conf.py b/conans/model/conf.py\nindex d7f56d62f47..6773bf06218 100644\n--- a/conans/model/conf.py\n+++ b/conans/model/conf.py\n@@ -122,13 +122,14 @@ class _ConfVar... | [
{
"diff_hunk": "@@ -43,3 +44,30 @@ def test_profile_cache_folder_priority():\n \n c.run(\"install . -pr=default\")\n assert \"os=AIX\" in c.out\n+\n+\n+def test_profile_cli_priority():\n+ c = TestClient()\n+ profile1 = textwrap.dedent(\"\"\"\\\n+ [settings]\n+ os=AIX\n+ [conf]... | 9fffdd4007fc6532643ad633c7da3fc836dd46ff | diff --git a/conans/model/conf.py b/conans/model/conf.py
index d7f56d62f47..812e926c897 100644
--- a/conans/model/conf.py
+++ b/conans/model/conf.py
@@ -122,13 +122,14 @@ class _ConfVarPlaceHolder:
class _ConfValue(object):
- def __init__(self, name, value, path=False):
+ def __init__(self, name, value, path... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
conan-io__conan-13502@5148945 | conan-io/conan | Python | 13,502 | feature conan cache check-integrity | Changelog: Feature: New ``conan cache check-integrity`` command to replace 1.X legacy ``conan upload --skip-upload --check``.
Docs: https://github.com/conan-io/docs/pull/3147
Close https://github.com/conan-io/conan/issues/13499
| 2023-03-22T14:03:25Z | [question] conan2 local integrity check of cache contents based on manifest
### What is your question?
Hi!
We started an experimental migration of our packages to conan 2.x.
In our integration with conan 1.x we used the following to check the integrity of packages in the local cache based on the manifest:
`co... | Hi @bbandix
It is true that Conan 2.0 removed this "skip-upload" case that can be leveraged for checking packages checksums.
I think we might want to introduce this check, probably as a ``conan cache`` subcommand, labeling this as a possible feature.
In the meantime, it should be relatively easy to create you... | [
{
"body": "### What is your question?\n\nHi!\r\n\r\nWe started an experimental migration of our packages to conan 2.x.\r\n\r\nIn our integration with conan 1.x we used the following to check the integrity of packages in the local cache based on the manifest:\r\n\r\n`conan upload --skip-upload --all -c '*'`\r\n\... | f292b0046517cada5adc5c192f5bde49162fb8bd | {
"head_commit": "5148945d40b9b5b1600e1ef2d6f795ca1e075a90",
"head_commit_message": "feature conan cache check-integrity",
"patch_to_review": "diff --git a/conan/cli/commands/cache.py b/conan/cli/commands/cache.py\nindex ea03cec7bf2..28ddf486789 100644\n--- a/conan/cli/commands/cache.py\n+++ b/conan/cli/commands/... | [
{
"diff_hunk": "@@ -77,3 +77,19 @@ def cache_clean(conan_api: ConanAPI, parser, subparser, *args):\n package_list = conan_api.list.select(ref_pattern, package_query=args.package_query)\n conan_api.cache.clean(package_list, source=args.source, build=args.build,\n download=args.d... | 193897c02d0081be6237d0434231b52ee53db4c2 | diff --git a/conan/cli/commands/cache.py b/conan/cli/commands/cache.py
index ea03cec7bf2..66997b2521b 100644
--- a/conan/cli/commands/cache.py
+++ b/conan/cli/commands/cache.py
@@ -77,3 +77,19 @@ def cache_clean(conan_api: ConanAPI, parser, subparser, *args):
package_list = conan_api.list.select(ref_pattern, packa... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
All-Hands-AI__OpenHands-1115@afc42e1 | All-Hands-AI/OpenHands | Python | 1,115 | feat: add `question.md` template for community Q&A | close #1114 | 2024-04-15T08:57:32Z | Add a `question.md` Issue Template for Enhanced Community Engagement
**Summary**
I would like to propose the addition of a new issue template for questions. This can help organize and streamline the process of asking questions in this repository.
**Motivation**
Having a structured format for questions will make it... | [
{
"body": "**Summary**\r\nI would like to propose the addition of a new issue template for questions. This can help organize and streamline the process of asking questions in this repository.\r\n\r\n**Motivation**\r\nHaving a structured format for questions will make it easier for contributors to provide the ne... | 34ecfe3c753f9bccee884a5035750d26a6e24604 | {
"head_commit": "afc42e1cdc746d9bfd4ce8f3c605e92bc7a98fe2",
"head_commit_message": "feat: add `question.md` template for community Q&A",
"patch_to_review": "diff --git a/.github/ISSUE_TEMPLATE/question.md b/.github/ISSUE_TEMPLATE/question.md\nnew file mode 100644\nindex 000000000000..a0ef17f94e89\n--- /dev/null\... | [
{
"diff_hunk": "@@ -0,0 +1,16 @@\n+---\n+name: Question\n+about: Use this template to ask a question regarding the project.\n+title: ''\n+labels: help wanted",
"line": null,
"original_line": 5,
"original_start_line": null,
"path": ".github/ISSUE_TEMPLATE/question.md",
"start_line": null,
... | 88ad2ab6d17d17a1e23dfea25ed4fc59577399cc | diff --git a/.github/ISSUE_TEMPLATE/question.md b/.github/ISSUE_TEMPLATE/question.md
new file mode 100644
index 000000000000..d03f14a49adf
--- /dev/null
+++ b/.github/ISSUE_TEMPLATE/question.md
@@ -0,0 +1,16 @@
+---
+name: Question
+about: Use this template to ask a question regarding the project.
+title: ''
+labels: q... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "New Feature Additions"
} | |
conan-io__conan-13267@469c99e | conan-io/conan | Python | 13,267 | Fix/cmakedeps tool no build type | Changelog: Bugfix: CMakeDeps generate files for ``tool_requires`` with the same ``build_type`` as the "host" context.
Docs: Omit
Close https://github.com/conan-io/conan/issues/13209 | 2023-02-28T09:32:07Z | [bug] CMakeDeps.generate() fails when `build_context_activated` is used
### Environment details
* Windows 10:
* Compiler: MSVC 2022
* Conan version: 1.58.0
* Python version: 3.7.5
### Steps to reproduce
1. have this in the `conanfile.py`
```
tool_requires = ["clang-style-tools-integration/2.3.1@us/release... | Hi @petermbauer
Thanks for your detailed report.
It seems you are missing ``deps.build_context_build_modules = ["xxxx"]``
The ``build_context_activated`` is meant for generating the config.cmake files, but activating their build-modules is also opt-in. This is because in-package scripts might easily conflict be... | [
{
"body": "### Environment details\n\n* Windows 10:\r\n* Compiler: MSVC 2022\r\n* Conan version: 1.58.0\r\n* Python version: 3.7.5\r\n\n\n### Steps to reproduce\n\n1. have this in the `conanfile.py`\r\n```\r\n tool_requires = [\"clang-style-tools-integration/2.3.1@us/release\"]\r\n \r\n def generate(se... | cf0536f927bd20a2051bcb824fed7c8eb68b6cf6 | {
"head_commit": "469c99ec09a5ffe9db4eb53dadc2ee4aea8df284",
"head_commit_message": "fixing for 2.0",
"patch_to_review": "diff --git a/conan/tools/cmake/cmakedeps/templates/__init__.py b/conan/tools/cmake/cmakedeps/templates/__init__.py\nindex dbf9c0dc668..fb785c59ef0 100644\n--- a/conan/tools/cmake/cmakedeps/tem... | [
{
"diff_hunk": "@@ -2,4 +2,4 @@\n REVISIONS = \"revisions\" # Only when enabled in config, not by default look at server_launcher.py\n OAUTH_TOKEN = \"oauth_token\"\n \n-__version__ = '2.0.0-dev'\n+__version__ = '2.0.1-dev'",
"line": null,
"original_line": 5,
"original_start_line": null,
"path"... | 4ae896dfdf73b6bf4ab39bab7f386fd65ae9176f | diff --git a/conan/tools/cmake/cmakedeps/templates/__init__.py b/conan/tools/cmake/cmakedeps/templates/__init__.py
index dbf9c0dc668..fb785c59ef0 100644
--- a/conan/tools/cmake/cmakedeps/templates/__init__.py
+++ b/conan/tools/cmake/cmakedeps/templates/__init__.py
@@ -60,18 +60,11 @@ def filename(self):
@propert... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
All-Hands-AI__OpenHands-618@1e787cc | All-Hands-AI/OpenHands | Python | 618 | Send initialization arguments only when stored in localStorage | Fixes https://github.com/OpenDevin/OpenDevin/issues/617 (parent https://github.com/OpenDevin/OpenDevin/issues/603)
Settings will only be saved to localStorage when the settings are explicitly changed by the user. Otherwise, the initialization arguments are left blank to respect the server's defaults. | 2024-04-02T23:30:07Z | Send `LLM_MODEL` to frontend
The `LLM_MODEL` setting defines the default model to use when no other model is selected in the frontend.
When first initialized, the frontend needs a model selected in the settings dialog. Currently this is hardcoded to `gpt-4-0125-preview`. Since the frontend now sends this model as an... | How does the backend send the value of `LLM_MODEL` to the frontend? Are you thinking that's a new endpoint?
Yes. | [
{
"body": "The `LLM_MODEL` setting defines the default model to use when no other model is selected in the frontend.\r\n\r\nWhen first initialized, the frontend needs a model selected in the settings dialog. Currently this is hardcoded to `gpt-4-0125-preview`. Since the frontend now sends this model as an initi... | 5f29df088ae26a7e9cea24e247b02f6fe786acc9 | {
"head_commit": "1e787ccb14bafbb3cd6a0aee40436261c808c245",
"head_commit_message": "Send initialization arguments only when stored in localStorage",
"patch_to_review": "diff --git a/frontend/.eslintrc b/frontend/.eslintrc\nindex e259190dc563..c151040b0efd 100644\n--- a/frontend/.eslintrc\n+++ b/frontend/.eslintr... | [
{
"diff_hunk": "@@ -42,5 +42,9 @@ def read_llm_agents():\n \"PlannerAgent\",\n ]\n \n+@app.get(\"default-model\")",
"line": null,
"original_line": 45,
"original_start_line": null,
"path": "opendevin/mock/listen.py",
"start_line": null,
"text": "@user1:\nshouldn't there be a s... | f18daeeb2f357392b7867e6a4fb7b7202ce3a4ea | diff --git a/frontend/.eslintrc b/frontend/.eslintrc
index e259190dc563..c151040b0efd 100644
--- a/frontend/.eslintrc
+++ b/frontend/.eslintrc
@@ -18,11 +18,11 @@
{
"files": ["*.ts", "*.tsx"],
"rules": {
- // Allow state modification in Redux reducers
+ // Allow state modification in re... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
conan-io__conan-12732@4b6b428 | conan-io/conan | Python | 12,732 | Skip subdirectories in fix_apple_shared_install_name | Changelog: Bugfix: Fix issue in `fix_apple_shared_install_name` when libdirs or bindirs have subfolders.
Docs: Omit
Close: https://github.com/conan-io/conan/issues/12727
Co-authored-by: Rubén Rincón Blanco
| 2022-12-19T11:04:49Z | [bug] `fix_apple_shared_install_name()` fails if there is a subfolder in bin folder
### Environment details
* Operating System+version: macOS Monterey
* Compiler+version: apple-clang 14
* Conan version: 1.55.0
* Python version: 3.10.9
### Steps to reproduce
build a recipe creating a subfolder in bin folder & ca... | Hi! Nice catch! We've now identified the issue and have submitted a fix in the linked PR. Thanks for taking the time to open the report :) | [
{
"body": "### Environment details\n\n* Operating System+version: macOS Monterey\r\n* Compiler+version: apple-clang 14\r\n* Conan version: 1.55.0\r\n* Python version: 3.10.9\r\n\n\n### Steps to reproduce\n\nbuild a recipe creating a subfolder in bin folder & calling fix_apple_shared_install_name() in package()\... | 1566562a58c306d1296fdbc8534aee0180f1a096 | {
"head_commit": "4b6b4289c1418506ee8f3f584e9776fc5e35e1c6",
"head_commit_message": "Only check files directly inside declared directories",
"patch_to_review": "diff --git a/conan/tools/apple/apple.py b/conan/tools/apple/apple.py\nindex 8bffb654ec9..409fe7a0088 100644\n--- a/conan/tools/apple/apple.py\n+++ b/cona... | [
{
"diff_hunk": "@@ -167,9 +167,14 @@ def _get_install_name(path_to_dylib):\n install_name = check_output_runner(command).strip().split(\":\")[1].strip()\n return install_name\n \n- def _darwin_collect_dylibs(lib_folder):\n- return [os.path.join(lib_folder, f) for f in os.listdir(lib_fo... | 383f517c503611ab0d0a39a5f251205ec981c6ba | diff --git a/conan/tools/apple/apple.py b/conan/tools/apple/apple.py
index 8bffb654ec9..f08f325d5a0 100644
--- a/conan/tools/apple/apple.py
+++ b/conan/tools/apple/apple.py
@@ -167,9 +167,14 @@ def _get_install_name(path_to_dylib):
install_name = check_output_runner(command).strip().split(":")[1].strip()
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
keephq__keep-904@9597dfd | keephq/keep | Python | 904 | feat: presets can be user private | /claim #640
/close #640
/split @35C4n0r | 2024-03-06T08:37:00Z | Create presets for each user
The feature to create presets it's awesome but right now if i create a preset, all users have the same presets. I think it will be great that each user have their own presets. This way each user can choose the alerts they want to see and have their own customize dashboard. | This one requires a little UX thinking. Will update once we have a thought on how to implement this to get your feedback @Sup3rJ! Thanks for the issue.
### What needs to be done
1. Presets are currently kept in localStorage -> should move to API
2. One should be able to save Preset as a `Global` vs. `Private` (only a... | [
{
"body": "The feature to create presets it's awesome but right now if i create a preset, all users have the same presets. I think it will be great that each user have their own presets. This way each user can choose the alerts they want to see and have their own customize dashboard.\r\n",
"number": 640,
... | dc4b8b66085f879169ebab06b38ac49159d69dd7 | {
"head_commit": "9597dfd5635eed3840020ab6964ca78bccd71250",
"head_commit_message": "fix: update modal size\n\nSigned-off-by: Jay <jaykumar20march@gmail.com>",
"patch_to_review": "diff --git a/keep-ui/app/alerts/alert-presets.tsx b/keep-ui/app/alerts/alert-presets.tsx\nindex ecbcf8b871..1a546fabfe 100644\n--- a/k... | [
{
"diff_hunk": "@@ -168,11 +173,14 @@ export default function AlertPresets({\n }\n \n async function addOrUpdatePreset() {\n- const newPresetName = prompt(\n- `${preset?.name ? \"Update preset name?\" : \"Enter new preset name\"}`,\n- preset?.name === \"feed\" || preset?.name === \"deleted\" ? ... | 9fb0c31b8f63430a48d3903793f7128bb75d3823 | diff --git a/keep-ui/app/alerts/alert-presets.tsx b/keep-ui/app/alerts/alert-presets.tsx
index ecbcf8b871..45e58d472d 100644
--- a/keep-ui/app/alerts/alert-presets.tsx
+++ b/keep-ui/app/alerts/alert-presets.tsx
@@ -1,8 +1,9 @@
-import { useState, useEffect, useRef, useMemo } from "react";
+import React, { useState, use... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
keephq__keep-881@a8ef525 | keephq/keep | Python | 881 | feat: add squadcast provider. |
<!--
Thanks for creating this pull request 🤗
Please make sure that the pull request is limited to one type (docs, feature, etc.) and keep it as small as possible. You can open multiple prs instead of opening a huge one.
-->
<!-- If this pull request closes an issue, please mention the issue number below -... | 2024-03-01T20:44:51Z | New Provider: Squadcast
**Describe the provider you want to add**
Squadcast is a incident management tool similar to Grafana OnCall or PagerDuty.
**Describe your use case**
We route all our alerts through Squadcast for escalation, schedules and notification routing. With the discovery of keep we would like to ha... | Hey @mfroembgen, thanks for opening this ticket :) I'll start digging around Squadcast, hopefully adding it in the next couple of days.
Can you please share what exactly integration you want? for example, for Grafana OnCall and Pager Duty, we have to create ticket, comment on ticket, etc. What will you need - functi... | [
{
"body": "**Describe the provider you want to add**\r\nSquadcast is a incident management tool similar to Grafana OnCall or PagerDuty. \r\n\r\n**Describe your use case**\r\nWe route all our alerts through Squadcast for escalation, schedules and notification routing. With the discovery of keep we would like to... | 60c5f4eda1cbe19621f1a7da988b60a03580f1e0 | {
"head_commit": "a8ef525507abc1916035aa74ab5ffccd52f95c1a",
"head_commit_message": "feat: add squadcast provider.\n\n- Added squadcast API as a provider\n- Updated docs.\n\nSigned-off-by: Jay <jaykumar20march@gmail.com>",
"patch_to_review": "diff --git a/README.md b/README.md\nindex 10ed6f962e..a75147036b 100644... | [
{
"diff_hunk": "@@ -0,0 +1,194 @@\n+\"\"\"\n+SquadcastProvider is a class that implements the Squadcast API and allows creating incidents and notes.\n+\"\"\"\n+import dataclasses\n+import json\n+\n+import pydantic\n+import requests\n+from requests import HTTPError\n+\n+from keep.contextmanager.contextmanager im... | af43278614143d1465e98a195fd9310302315aab | diff --git a/README.md b/README.md
index b3acd56435..ad5b711995 100644
--- a/README.md
+++ b/README.md
@@ -165,6 +165,8 @@ Workflow triggers can either be executed manually when an alert is activated or
<img width=32 height=32 src="https://github.co... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
keephq__keep-872@affb739 | keephq/keep | Python | 872 | feat: add provider for GitLab | <!--
Thanks for creating this pull request 🤗
Please make sure that the pull request is limited to one type (docs, feature, etc.) and keep it as small as possible. You can open multiple prs instead of opening a huge one.
-->
<!-- If this pull request closes an issue, please mention the issue number below -->
... | 2024-02-29T08:40:56Z | New Provider: GitLab on-prem
**Describe the provider you want to add**
Gitlab could be used for ticketing like Jira.
**Describe your use case**
We use Gitlab for for all of our planning and tickets as all of our repos are there.
**Are you already using Keep?**
Yes, we plan to implement it. | /bounty 50
I would like to attempt it @shahargl
Please focus on:
1. Authentication Methods
2. Validating Scopes
3. Opening a ticket
4. Documentation on how to connect GitLab provider
Please take Jira Provider as an example.
@35C4n0r assigned. Please read my previous comment on what to focus on.
/attempt #868
<... | [
{
"body": "**Describe the provider you want to add**\r\nGitlab could be used for ticketing like Jira.\r\n\r\n**Describe your use case**\r\nWe use Gitlab for for all of our planning and tickets as all of our repos are there.\r\n\r\n**Are you already using Keep?**\r\nYes, we plan to implement it. \r\n",
"numb... | 3c8297ba59f5361e31fb878461c9091a1a3f94e8 | {
"head_commit": "affb739cad26c1528c293449bb90a5c205d674fa",
"head_commit_message": "feat: add provider for GitLab\n\n- Integrate gitlab REST API as a provider.\n- Update documentations accordingly.\n\nSigned-off-by: Jay <jaykumar20march@gmail.com>",
"patch_to_review": "diff --git a/README.md b/README.md\nindex d... | [
{
"diff_hunk": "@@ -0,0 +1,39 @@\n+---\n+title: \"GitLab Provider\"\n+sidebarTitle: \"GitLab Provider\"\n+description: \"GitLab provider is a provider used to query data and creating issues in GitLab\"\n+---\n+\n+## Inputs\n+\n+The `query` function take following parameters as inputs:",
"line": null,
"o... | 79d68f0c7cd6b31091a46c65fef731a1581428c5 | diff --git a/README.md b/README.md
index c00a7aa5eb..10ed6f962e 100644
--- a/README.md
+++ b/README.md
@@ -169,6 +169,8 @@ Workflow triggers can either be executed manually when an alert is activated or
<p align="center">
<img width=32 height=32 src="https://github.com/keephq/keep/blob/main/keep-ui/public/icons/j... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
keephq__keep-657@1c89577 | keephq/keep | Python | 657 | feat(ui): Delete Multiple Alerts | <!--
Thanks for creating this pull request 🤗
Please make sure that the pull request is limited to one type (docs, feature, etc.) and keep it as small as possible. You can open multiple prs instead of opening a huge one.
-->
<!-- If this pull request closes an issue, please mention the issue number below -->
... | 2023-12-26T21:22:51Z | Add an option to delete multiple alerts
Now that we support react-table (thanks to @asharonbaltazar!) we want to be able to delete multiple alerts at once.
Alert menu will be moved to the right as an ellipse.
When clicking an alert row, checkbox to the left will be marked and user will be able to check multiple ale... | @talboren does this involves both frontend + backend changes? or is there existing api for multiple deletions?
> @talboren does this involves both frontend + backend changes? or is there existing api for multiple deletions?
There's an API for alert deletion that can easily be enhanced to support multiple alert delet... | [
{
"body": "Now that we support react-table (thanks to @asharonbaltazar!) we want to be able to delete multiple alerts at once.\r\n\r\nAlert menu will be moved to the right as an ellipse.\r\nWhen clicking an alert row, checkbox to the left will be marked and user will be able to check multiple alerts and hit a d... | 68a7cc84a9d97ca9a11c805a9a811d84a910c70e | {
"head_commit": "1c89577af1255af4fd615dbc8ff5d5888576d52b",
"head_commit_message": "Merge branch 'main' into feat/delete-multiple-alerts",
"patch_to_review": "diff --git a/keep-ui/app/alerts/alert-actions.tsx b/keep-ui/app/alerts/alert-actions.tsx\nnew file mode 100644\nindex 0000000000..4929938237\n--- /dev/nul... | [
{
"diff_hunk": "@@ -161,7 +158,7 @@ export default function AlertMenu({\n leaveFrom=\"transform opacity-100 scale-100\"\n leaveTo=\"transform opacity-0 scale-95\"\n >\n- <Menu.Items className=\"z-50 relative mt-2 min-w-36 origin-top-right divide-y divide-gray-100 rounded-md ... | 88d34babe2ec1ee38d80e106ef5404a68ca1e725 | diff --git a/keep-ui/app/alerts/alert-actions.tsx b/keep-ui/app/alerts/alert-actions.tsx
new file mode 100644
index 0000000000..01026dfe29
--- /dev/null
+++ b/keep-ui/app/alerts/alert-actions.tsx
@@ -0,0 +1,72 @@
+import { TrashIcon } from "@heroicons/react/24/outline";
+import { Button } from "@tremor/react";
+import ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
keephq__keep-651@45de7f9 | keephq/keep | Python | 651 | chore: docker-compose templatization | /close #531
- Templatization docker compose file
- Fixes Dockerfile.dev.api entry point
so that also calls config.py at the start of gunicorn server.
- Updates volume binding for backend in otel compose file | 2023-12-24T21:44:44Z | Templatization of our docker-compose files
Today we maintain 4 different docker-compose files:
- docker-compose.yml
- docker-compose.dev.yml
- docker-compose-with-otel.yaml
- docker-compose-with-auth.yml
The main difference between them is either extra services or different environment variables.
We need to ... | @talboren will like to work on this please assign this to me
@talboren @shahargl apologizes for being late on this.
I hope no one working on this issue currently, will be starting work now.
@mohanish2504 happy to have you contribute that :) | [
{
"body": "Today we maintain 4 different docker-compose files:\r\n\r\n- docker-compose.yml\r\n- docker-compose.dev.yml\r\n- docker-compose-with-otel.yaml\r\n- docker-compose-with-auth.yml\r\n\r\nThe main difference between them is either extra services or different environment variables.\r\nWe need to maintain ... | 560e47db075f607b1355ee999b17c4d53af334d5 | {
"head_commit": "45de7f94fa8db8b8c59a5f98ef950a50e17bdf0e",
"head_commit_message": "Merge branch 'main' into mohanish/docker_templatization",
"patch_to_review": "diff --git a/docker-compose-with-auth.yml b/docker-compose-with-auth.yml\nindex d0bca7e2f8..30cc966e1f 100644\n--- a/docker-compose-with-auth.yml\n+++ ... | [
{
"diff_hunk": "@@ -25,4 +25,4 @@ RUN echo \"test\"\n ENV PATH=\"/venv/bin:${PATH}\"\n ENV VIRTUAL_ENV=\"/venv\"\n \n-CMD [\"uvicorn\", \"keep.api.api:get_app\", \"--host\", \"0.0.0.0\", \"--port\", \"8080\", \"--reload\"]",
"line": 27,
"original_line": 27,
"original_start_line": null,
"path": "... | a0ea00e6a038968a384bd861efc283d0ca98c6a3 | diff --git a/docker-compose-with-auth.yml b/docker-compose-with-auth.yml
index d0bca7e2f8..30cc966e1f 100644
--- a/docker-compose-with-auth.yml
+++ b/docker-compose-with-auth.yml
@@ -1,52 +1,28 @@
services:
keep-frontend:
+ extends:
+ file: docker-compose.common.yml
+ service: keep-frontend-common
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Code Refactoring / Architectural Improvement"
} |
keephq__keep-190@98342dd | keephq/keep | Python | 190 | feat: interval option in alert specification | close https://github.com/keephq/keep/issues/189 | 2023-06-26T08:48:55Z | Add "interval" to the alert spec
You can schedule an alert by adding the `-i/--interval` flag to the Keep CLI command.
However, sometimes you want to schedule multiple alerts with different intervals.
The easiest way to do so will be to add the "interval" property to the main alert spec, so Keep will be able to sc... | [
{
"body": "You can schedule an alert by adding the `-i/--interval` flag to the Keep CLI command.\r\n\r\nHowever, sometimes you want to schedule multiple alerts with different intervals. \r\nThe easiest way to do so will be to add the \"interval\" property to the main alert spec, so Keep will be able to schedule... | 5cb14718ebc3c45d64604c05b1cbdff30b9cc256 | {
"head_commit": "98342dd381dffc00a08fe74db701503b774c7261",
"head_commit_message": "feat: add auth0 provider",
"patch_to_review": "diff --git a/examples/alerts/db_disk_space.yml b/examples/alerts/db_disk_space.yml\nindex 92908ec442..e4fbc004db 100644\n--- a/examples/alerts/db_disk_space.yml\n+++ b/examples/alert... | [
{
"diff_hunk": "@@ -1,60 +1,58 @@\n import logging\n import os\n+import threading\n import time\n import typing\n \n from keep.alert.alert import Alert\n+from keep.alertmanager.alertcheduler import AlertScheduler\n from keep.parser.parser import Parser\n \n \n class AlertManager:\n- def __init__(self):\n+ ... | 408d2dabf19caa701096ae51792df2b1f8974056 | diff --git a/examples/alerts/db_disk_space.yml b/examples/alerts/db_disk_space.yml
index 92908ec442..e4fbc004db 100644
--- a/examples/alerts/db_disk_space.yml
+++ b/examples/alerts/db_disk_space.yml
@@ -8,6 +8,8 @@ alert:
services:
- db
- api
+ # Run every 60 seconds
+ interval: 60
steps:
- name:... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
keephq__keep-625@767a6e3 | keephq/keep | Python | 625 | feat: Add mongodb as a provider | fix #624
/claim #624 | 2023-12-12T09:09:34Z | Add mongodb as a provider
**Is your feature request related to a problem? Please describe.**
I'm looking to read data from mongodb in my workflow.
**Describe the solution you'd like**
In my workflow, i have few configurable parameters which are stored in mongodb. I want to fetch them against an evernt (like trigge... | /bounty 50
@shahargl
We want to connect mongodb using `pymongo` https://www.w3schools.com/python/python_mongodb_create_db.asp, right?
yea you can use `pymongo` for that. notice that you need also `scopes` and `validate_scopes` (you can see datadog provider for example). also note that this should support self host... | [
{
"body": "**Is your feature request related to a problem? Please describe.**\r\nI'm looking to read data from mongodb in my workflow.\r\n\r\n**Describe the solution you'd like**\r\nIn my workflow, i have few configurable parameters which are stored in mongodb. I want to fetch them against an evernt (like trigg... | 71d4c91983fd1b3552b77fd1c0ae54894eb9a0bf | {
"head_commit": "767a6e3491853b89fc5fc21db9cf57133c5f1e07",
"head_commit_message": "Create mongodb-provider.mdx\n\nSigned-off-by: Rishi Raj Jain <rishi18304@iiitd.ac.in>",
"patch_to_review": "diff --git a/docs/providers/documentation/mongodb-provider.mdx b/docs/providers/documentation/mongodb-provider.mdx\nnew f... | [
{
"diff_hunk": "@@ -0,0 +1,126 @@\n+import os\n+from pymongo import MongoClient\n+from keep.contextmanager.contextmanager import ContextManager\n+from keep.providers.base.base_provider import BaseProvider\n+from keep.providers.models.provider_config import ProviderConfig, ProviderScope\n+import pydantic\n+impor... | 9b9f9b5e22c2ab3f06623fbbba17584f499d2208 | diff --git a/docs/providers/documentation/mongodb-provider.mdx b/docs/providers/documentation/mongodb-provider.mdx
new file mode 100644
index 0000000000..ac9c16378e
--- /dev/null
+++ b/docs/providers/documentation/mongodb-provider.mdx
@@ -0,0 +1,45 @@
+---
+title: "MongoDB"
+sidebarTitle: "MongoDB Provider"
+descriptio... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
keephq__keep-316@f743e89 | keephq/keep | Python | 316 | feat: added support for step retry | <!--
Thanks for creating this pull request 🤗
Please make sure that the pull request is limited to one type (docs, feature, etc.) and keep it as small as possible. You can open multiple prs instead of opening a huge one.
-->
<!-- If this pull request closes an issue, please mention the issue number below -->
... | 2023-09-10T19:57:34Z | Step retry mechanism
**Is your feature request related to a problem? Please describe.**
Sometimes when a step fails to run (e.g. a simple HTTP request), I'd like to be able to have a retry mechanism before failing the step.
**Describe the solution you'd like**
An optional retry mechanism for steps to define what t... | @talboren correct if I misunderstoof your concern, basically you want an option like a `Retry button` so that you can restart the failed step correct?
can you provide a screenshot or design?
@Abhishek-90 actually I meant the YAML spec.
This is something I've imagined that could potentially work:
```yaml
# Aler... | [
{
"body": "**Is your feature request related to a problem? Please describe.**\r\nSometimes when a step fails to run (e.g. a simple HTTP request), I'd like to be able to have a retry mechanism before failing the step.\r\n\r\n**Describe the solution you'd like**\r\nAn optional retry mechanism for steps to define ... | 2051c5712bd2e3e69b49ab1ff9c79de2eb6fe718 | {
"head_commit": "f743e89e86dd07cd82dce063a6d70deae3d90981",
"head_commit_message": "Merge branch 'main' into task/239",
"patch_to_review": "diff --git a/keep/step/step.py b/keep/step/step.py\nindex daec69d81d..2e9fd56065 100644\n--- a/keep/step/step.py\n+++ b/keep/step/step.py\n@@ -1,6 +1,7 @@\n import asyncio\n... | [
{
"diff_hunk": "@@ -167,28 +172,34 @@ def _run_single(self):\n result = self._run_single_async()\n # else, just run the provider\n else:\n- try:\n- rendered_providers_parameters = {}\n- for parameter in self.provider_parameters:\n- ... | b69e2592aa2ca114652485697fdf19f9a58beda5 | diff --git a/docs/workflows/syntax/basic-syntax.mdx b/docs/workflows/syntax/basic-syntax.mdx
index 31b636aba4..faad12ab4d 100644
--- a/docs/workflows/syntax/basic-syntax.mdx
+++ b/docs/workflows/syntax/basic-syntax.mdx
@@ -60,11 +60,19 @@ provider:
config: "{{ providers.mysql-prod }}"
with:
query: "S... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
conan-io__conan-11594@9cb464d | conan-io/conan | Python | 11,594 | Fix CMake.test() target for Ninja Multi-Config | Changelog: Bugfix: Use correct build target in `CMake.test()` for the Ninja Multi-Config generator.
Docs: omit
Fixes #11405 | 2022-07-08T20:16:31Z | [bug] `cmake.test()` cannot execute
### Environment Details (include every applicable attribute)
* Operating System+version: Ubuntu 22.04 on WSL
* Compiler+version: CMake 3.23.1
* Conan version: 1.49.0
* Python version: 3.10.4
### Steps to reproduce (Include if Applicable)
Put `cmake.test()` and run `... | Yes, sounds that the test target is not taking into account ``Ninja Multi-Config`` generator. Seems the fix could be easy. | [
{
"body": "### Environment Details (include every applicable attribute)\r\n * Operating System+version: Ubuntu 22.04 on WSL\r\n * Compiler+version: CMake 3.23.1\r\n * Conan version: 1.49.0\r\n * Python version: 3.10.4\r\n\r\n### Steps to reproduce (Include if Applicable)\r\n\r\nPut `cmake.test()` and run `c... | 4ed1bee0fb81b2826208e8c1c824c99fb6d69be8 | {
"head_commit": "9cb464da23bed81313799463f8bf8675f44601b9",
"head_commit_message": "Add unit test for the CMake.test() helper",
"patch_to_review": "diff --git a/conan/tools/cmake/cmake.py b/conan/tools/cmake/cmake.py\nindex b3d6535a56a..0805f70922e 100644\n--- a/conan/tools/cmake/cmake.py\n+++ b/conan/tools/cmak... | [
{
"diff_hunk": "@@ -0,0 +1,42 @@\n+import pytest\n+\n+from conan.tools.cmake import CMake\n+from conan.tools.cmake.presets import write_cmake_presets\n+from conans.client.conf import get_default_settings_yml\n+from conans.model.conf import Conf\n+from conans.model.settings import Settings\n+from conans.test.uti... | f85809bc67093c19a1229f8cafe31e78fcd832ea | diff --git a/conan/tools/cmake/cmake.py b/conan/tools/cmake/cmake.py
index b3d6535a56a..0805f70922e 100644
--- a/conan/tools/cmake/cmake.py
+++ b/conan/tools/cmake/cmake.py
@@ -153,7 +153,8 @@ def test(self, build_type=None, target=None, cli_args=None, build_tool_args=None
return
if not target:
... | {
"difficulty": "medium",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
conan-io__conan-11560@876cdd4 | conan-io/conan | Python | 11,560 | Add alwayslink attribute to bazel static library import | Fixes #11559 , if this solution is taken.
There is no test currently for the static library only version
Test exists only for the case when shared_with_interface_libs contains
elements.
Changelog: omit
Docs: omit
- [x] Refer to the issue that supports this Pull Request.
- [x] If the issue has missing info, e... | 2022-06-30T19:04:55Z | [bug] bazel generator not usable for packages with multiple libs, like openssl
### Environment Details
* Operating System+version: All
* Compiler+version: Not relevant
* Conan version: All
* Python version: All
### Steps to reproduce
Use the bazel generator and use libcurl on Linux in your project... | The [alwayslink](https://docs.bazel.build/versions/main/be/c-cpp.html#cc_import.alwayslink) option has of course the disadvantage that it will blow up the size from the consumer
But I have no idea how that could be solved otherwise, since we do not know the required order of the libs.
It could be an option to mak... | [
{
"body": "\r\n### Environment Details \r\n * Operating System+version: All\r\n * Compiler+version: Not relevant\r\n * Conan version: All\r\n * Python version: All\r\n\r\n### Steps to reproduce \r\n\r\nUse the bazel generator and use libcurl on Linux in your project, so it depends on openssl.\r\nlibcurl wi... | 345be91a038e1bda707e07a19889953412d358dc | {
"head_commit": "876cdd4977c404339628b75d68fb15d3b9c86bb1",
"head_commit_message": "fix tests",
"patch_to_review": "diff --git a/conan/tools/google/bazeldeps.py b/conan/tools/google/bazeldeps.py\nindex 8a7b1af2094..c6966c043b2 100644\n--- a/conan/tools/google/bazeldeps.py\n+++ b/conan/tools/google/bazeldeps.py\n... | [
{
"diff_hunk": "@@ -220,6 +220,7 @@ def test_bazeldeps_shared_library_interface_buildfiles():\n includes=[\"include\"],\n visibility=[\"//visibility:public\"],\n deps = [\n+ #donotsort",
"line": null,
"original_line": 223,
"original_start_line": null,
"path": "conans/test/unit... | 69877274ab8f345f626fc048bdb9c0683d4d12fa | diff --git a/conan/tools/google/bazeldeps.py b/conan/tools/google/bazeldeps.py
index 8a7b1af2094..c6966c043b2 100644
--- a/conan/tools/google/bazeldeps.py
+++ b/conan/tools/google/bazeldeps.py
@@ -62,7 +62,7 @@ def _get_dependency_buildfile_content(self, dependency):
{% for libname, filepath in libs.items(... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
keephq__keep-186@7071388 | keephq/keep | Python | 186 | chore: Enhancement: Merge step and action class implementation | <!--
Thanks for creating this pull request 🤗
Please make sure that the pull request is limited to one type (docs, feature, etc.) and keep it as small as possible. You can open multiple prs instead of opening a huge one.
-->
<!-- If this pull request closes an issue, please mention the issue number below -->
... | 2023-06-21T10:16:14Z | Enhancement: Merge step and action class implementation (e.g. base class)
Actions and Steps are practically the same entities, but the fact that Actions has conditions (and we want conditions for steps as well) and "throttling" logic, and Step calls `query` when executed while Actions calls `notify`.
The reason this... | @shahargl FYI, if you have thoughts, please add them.
Adding to this issue: in general, we need to re-think the "errors" mechanism in our alerts workflow.
The run alert function is quite messy and is hard to understand what happens when an error occurs or what an error even is:
```python
def _run_alerts(self, ale... | [
{
"body": "Actions and Steps are practically the same entities, but the fact that Actions has conditions (and we want conditions for steps as well) and \"throttling\" logic, and Step calls `query` when executed while Actions calls `notify`.\r\n\r\nThe reason this is now needed is that we want to add an `on-fail... | 555a666f284c53f49e9a66ef8b652654ba7db623 | {
"head_commit": "70713889d852f9582a0efeca280e5381b9881b80",
"head_commit_message": "chore(Enhancement) Merge step and action class implementation",
"patch_to_review": "diff --git a/docs/platform/core/syntax/basic-syntax.mdx b/docs/platform/core/syntax/basic-syntax.mdx\nindex 261d920d94..f3d989bca3 100644\n--- a/... | [
{
"diff_hunk": "@@ -1,51 +1,198 @@\n+import asyncio\n+from enum import Enum\n+import inspect\n import logging\n from dataclasses import field\n \n import chevron\n from pydantic.dataclasses import dataclass\n \n+from keep.conditions.condition_factory import ConditionFactory\n from keep.contextmanager.contextman... | 91930d8e2ec61ffa235f6c6149cd8b0c9d098565 | diff --git a/docs/platform/core/syntax/basic-syntax.mdx b/docs/platform/core/syntax/basic-syntax.mdx
index 261d920d94..f3d989bca3 100644
--- a/docs/platform/core/syntax/basic-syntax.mdx
+++ b/docs/platform/core/syntax/basic-syntax.mdx
@@ -53,17 +53,6 @@ alert:
- `actions` - list of actions
- `on-failure` - a conditio... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Code Refactoring / Architectural Improvement"
} |
keephq__keep-100@6a8be21 | keephq/keep | Python | 100 | feat: Adding tests for parser |
<!--
Thanks for creating this pull request 🤗
Please make sure that the pull request is limited to one type (docs, feature, etc.) and keep it as small as possible. You can open multiple prs instead of opening a huge one.
-->
<!-- If this pull request closes an issue, please mention the issue number below -->... | 2023-04-02T16:37:56Z | Cover parser with unit test
**Is your feature request related to a problem? Please describe.**
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
**Describe the solution you'd like**
A clear and concise description of what you want to happen.
**Describe alternatives you... | [
{
"body": "**Is your feature request related to a problem? Please describe.**\r\nA clear and concise description of what the problem is. Ex. I'm always frustrated when [...]\r\n\r\n**Describe the solution you'd like**\r\nA clear and concise description of what you want to happen.\r\n\r\n**Describe alternatives ... | c8335a111b669f2c413c5efeebbd65700ef6a84d | {
"head_commit": "6a8be211ffedd8c8126c9eb42e25a3b853cdf1cc",
"head_commit_message": "Added first test's for parser\n\ndipping the toe into the water",
"patch_to_review": "diff --git a/keep/parser/tests_for_parser/test_parser.py b/keep/parser/tests_for_parser/test_parser.py\nnew file mode 100644\nindex 0000000000.... | [
{
"diff_hunk": "@@ -0,0 +1,22 @@\n+# here we are going to create all needed tests for the parser.py parse function\n+import pytest\n+import requests\n+\n+from keep.parser.parser import Parser\n+\n+\n+def test_parse_with_nonexistent_file():\n+ self = Parser()\n+ # Expected error when a given input does not... | dbefaebeec15d04423b84f193cacabd08c482fde | diff --git a/.github/workflows/test-pr.yml b/.github/workflows/test-pr.yml
new file mode 100644
index 0000000000..16e43e4c67
--- /dev/null
+++ b/.github/workflows/test-pr.yml
@@ -0,0 +1,19 @@
+name: Tests
+on: [push, pull_request]
+jobs:
+ tests:
+ runs-on: ubuntu-latest
+ steps:
+ - uses: actions/checkout@v2... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Test Suite / CI Enhancements"
} | |
conan-io__conan-11527@4401481 | conan-io/conan | Python | 11,527 | Keep only one flavor of the same libs in `collect_libs()` | closes https://github.com/conan-io/conan/issues/11282
closes https://github.com/conan-io/conan/issues/11526
Changelog: Fix: In `conans.tools.collect_libs` and `conan.tools.files.collect_libs`, avoids to list other flavors (version, soversion) of the same `dylib` on macOS, so that behavior is consistent on Linux & m... | 2022-06-25T10:22:18Z | [bug] tool.collect_libs behaves differently on mac and linux
Mac and Linux both creaete symlinks without package version and libs with package version.
Linux: libmylib.so -> llibmylib.so.X.Y.Z
Mac: libmylib.dylib -> llibmylib.X.Y.Z.dylib
tools.collect_libs with make a os.path.splitext and check if the extension ... | Jeah, `collect_lib` should collect all libs (even symlinks) and also it should report
a list of (`fileName`, `path`) instead of only the filenames, to allow the user to check other stuff on these files... discarding symlinks.
On linux the additional check:
```python
".so." in name
```
should be done...
https:... | [
{
"body": "Mac and Linux both creaete symlinks without package version and libs with package version.\r\n\r\nLinux: libmylib.so -> llibmylib.so.X.Y.Z\r\nMac: libmylib.dylib -> llibmylib.X.Y.Z.dylib\r\n\r\ntools.collect_libs with make a os.path.splitext and check if the extension is a valid lib extension. Both s... | ae33d68ea3400fe4de45f3140d32820781c68c6b | {
"head_commit": "44014813a50b9af8db70a9db967e127abe95fcb7",
"head_commit_message": "no more warnings if same lib found several times\n\nIndeed, it happens all the time with symlinks",
"patch_to_review": "diff --git a/conan/tools/files/files.py b/conan/tools/files/files.py\nindex 7eca6af893f..9aebe7970dd 100644\n... | [
{
"diff_hunk": "@@ -43,21 +43,6 @@ def test_collect_libs():\n result = collect_libs(conanfile, folder=\"custom_folder\")\n assert [\"customlib\"] == result\n \n- # Warn same lib different folders\n- conanfile = ConanFileMock()\n- conanfile.folders.set_base_package(temp_folder())\n- conanfile... | 799b3c7371fef700cb3e30745eddfd8d4dc3426d | diff --git a/conan/tools/files/files.py b/conan/tools/files/files.py
index 7eca6af893f..9aebe7970dd 100644
--- a/conan/tools/files/files.py
+++ b/conan/tools/files/files.py
@@ -494,24 +494,29 @@ def collect_libs(conanfile, folder=None):
else:
lib_folders = [os.path.join(conanfile.package_folder, folder)
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
conan-io__conan-11321@f1a9473 | conan-io/conan | Python | 11,321 | [feature] Add tools can_run | - Added under cross_building namespace
- TODO: Elaborate tests
Changelog: Feature: Tools `can_run` validates if it is possible to run a and application build for a non-native architecture.
Docs: https://github.com/conan-io/docs/pull/2547
closes #11035
- [x] Refer to the issue that supports this Pull Request.
... | 2022-05-24T15:36:18Z | [feature] Ability to identify if binaries can be executed on a particular platform
Typically there is made use of `tools.cross_building(self.settings)` to identify that for example test binaries can't be executed on a particular platform. Though this particular solution is not really sufficient to handle for example th... | It's true you don't need to invoke Rosetta manually on M1 to execute x86_64, but still, the architecture is not the same and Mac will run Rosetta 2 dynamically, which has some loss of performance. I could use QEMU on Linux and say the same thing, but still, is not optimized.
I disagree adding such feature because an... | [
{
"body": "Typically there is made use of `tools.cross_building(self.settings)` to identify that for example test binaries can't be executed on a particular platform. Though this particular solution is not really sufficient to handle for example the case of running on a macOS with Apple Silicon (M1) chipset, as... | 7811bd4dd70293ee87ffa20770a059aed09d3404 | {
"head_commit": "f1a94731069ddf619599d0b222e0411982aa41d9",
"head_commit_message": "Add can_run\n\nSigned-off-by: Uilian Ries <uilianries@gmail.com>",
"patch_to_review": "diff --git a/conan/tools/build/cross_building.py b/conan/tools/build/cross_building.py\nindex 0e92ace864c..fe68b8403f0 100644\n--- a/conan/too... | [
{
"diff_hunk": "@@ -28,3 +28,14 @@ def get_cross_building_settings(conanfile):\n os_host, arch_host)\n else:\n return os_host, arch_host, os_host, arch_host\n+\n+\n+def can_run(conanfile):\n+ \"\"\"\n+ Validates if the current build platform can run a file which is not for same... | 3c7fa9f33bad17c35d138c335eeab22f70d31509 | diff --git a/conan/tools/build/__init__.py b/conan/tools/build/__init__.py
index bc84116339a..f93b3a4dda9 100644
--- a/conan/tools/build/__init__.py
+++ b/conan/tools/build/__init__.py
@@ -1,2 +1,2 @@
from conan.tools.build.cpu import build_jobs
-from conan.tools.build.cross_building import cross_building
+from conan.... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
conan-io__conan-11233@5e83fff | conan-io/conan | Python | 11,233 | Add components support in XcodeDeps | Changelog: Feature: Add components support in XcodeDeps.
Docs: https://github.com/conan-io/docs/pull/2560
Closes: https://github.com/conan-io/conan/issues/11125
Uses xcodegen instead of adding the xcode project file as a string.
| 2022-05-12T10:07:21Z | [feature] XCodeDeps support Conan Components
Currently the XcodeDeps is not supporting Conan components which is resulting in having all components added to the generated xcconfig context. It would be good to split the xcconfig creation in separate files per component to allow more granular selection of components to b... | Same applies for MSBuildDeps, not split into components yet
Thanks @maikelvdh for the suggestion, I'm adding this to the 1.49 milestone so that we can consider if components support for both MSBuildDeps and XcodeDeps could make it into that release. | [
{
"body": "Currently the XcodeDeps is not supporting Conan components which is resulting in having all components added to the generated xcconfig context. It would be good to split the xcconfig creation in separate files per component to allow more granular selection of components to be utilised on consuming si... | f9215513368e576a82f071ab5d7b4cf990d156ca | {
"head_commit": "5e83fff957d3581ffcf4bfa9d7c26ebc0e18c36f",
"head_commit_message": "update test",
"patch_to_review": "diff --git a/conan/tools/apple/xcodedeps.py b/conan/tools/apple/xcodedeps.py\nindex d31664465ae..6011e030bd7 100644\n--- a/conan/tools/apple/xcodedeps.py\n+++ b/conan/tools/apple/xcodedeps.py\n@@... | [
{
"diff_hunk": "@@ -103,6 +103,7 @@ def test_generator_files():\n assert os.path.isfile(config_file)\n \n conandeps = client.load(\"conandeps.xcconfig\")\n+ print(\"jajsjdasdasda\")",
"line": null,
"original_line": 106,
"original_start_line": null,
"path": "conans/test... | 01e3cb03b2dc1825dc5b75fa05de60a17079903a | diff --git a/conan/tools/apple/xcodedeps.py b/conan/tools/apple/xcodedeps.py
index d31664465ae..6011e030bd7 100644
--- a/conan/tools/apple/xcodedeps.py
+++ b/conan/tools/apple/xcodedeps.py
@@ -17,6 +17,11 @@
GLOBAL_XCCONFIG_FILENAME = "conan_config.xcconfig"
+def _format_name(name):
+ name = name.replace(".", "... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
conan-io__conan-11390@7e4d7f5 | conan-io/conan | Python | 11,390 | [PkgConfigDeps] Creates `*.pc` files for `test_requires` | Changelog: Bugfix: `PkgConfigDeps` creates `*.pc` files for `test_requires`.
Docs: omit
Closes: https://github.com/conan-io/conan/issues/11376
| 2022-06-03T09:34:38Z | [question] PkgConfigDeps does not generate .pc files test_requires dependencies?
Using Conan version 1.48.1
I have a meson project which is dependent on a test dependency "PkgA"
After executing `conan install .` on my recipe
`.pc` file **not** generated when:
```
generators = 'PkgConfigDeps'
def... | Hi @phillipcaofph
Thanks for reporting the issue! And, indeed, it's a bug. This `test_require` should appear there as a normal `*.pc` file. | [
{
"body": "Using Conan version 1.48.1\r\n\r\nI have a meson project which is dependent on a test dependency \"PkgA\"\r\n\r\nAfter executing `conan install .` on my recipe\r\n\r\n`.pc` file **not** generated when:\r\n\r\n```\r\n generators = 'PkgConfigDeps'\r\n\r\n def build_requirements(self):\r\n ... | d4fd4048ebb032ba574dbfe620667d33b594dcf2 | {
"head_commit": "7e4d7f5cabc385890fbeec6a7482eacb7ec1fc06",
"head_commit_message": "Added test and build requires",
"patch_to_review": "diff --git a/conan/tools/gnu/pkgconfigdeps/pkgconfigdeps.py b/conan/tools/gnu/pkgconfigdeps/pkgconfigdeps.py\nindex f13daba39b2..a29908ec82b 100644\n--- a/conan/tools/gnu/pkgcon... | [
{
"diff_hunk": "@@ -11,8 +11,13 @@ def __init__(self, conanfile):\n def content(self):\n \"\"\"Get all the *.pc files content\"\"\"\n pc_files = {}\n+ # Get all the dependencies\n host_req = self._conanfile.dependencies.host\n- for _, dep in host_req.items():\n+ ... | 55c07a6afb9b05df157dca5ac1e4873d10c4f534 | diff --git a/conan/tools/gnu/pkgconfigdeps/pkgconfigdeps.py b/conan/tools/gnu/pkgconfigdeps/pkgconfigdeps.py
index f13daba39b2..bc74f552c04 100644
--- a/conan/tools/gnu/pkgconfigdeps/pkgconfigdeps.py
+++ b/conan/tools/gnu/pkgconfigdeps/pkgconfigdeps.py
@@ -11,8 +11,12 @@ def __init__(self, conanfile):
def content(... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
conan-io__conan-11199@41d9f96 | conan-io/conan | Python | 11,199 | [dev2][package_id] Part 3: Mechanism to add some `conf`s to `package_id` computation | Changelog: Feature: Added mechanism to include some configurations into `package_id` computation via `tools.info.package_id:confs` one.
Docs: omit
Closes: https://github.com/conan-io/conan/issues/11163 | 2022-05-09T12:17:37Z | [feature] [package_id] Improve `ConanInfo` interface to add new `conf` values
Improve the way to add new configurations from `conf` to `ConanInfo.package_id()`. Some proposals:
* Via `[conf]`: having a new configuration to indicate all the configurations to be added like `core.package_id:add=["tools.build:cxxflags"... | [
{
"body": "Improve the way to add new configurations from `conf` to `ConanInfo.package_id()`. Some proposals:\r\n\r\n* Via `[conf]`: having a new configuration to indicate all the configurations to be added like `core.package_id:add=[\"tools.build:cxxflags\"]`\r\n* Via `conanfile.py`: having something like this... | 64763a70b0f2151597f9603ee0332115928da631 | {
"head_commit": "41d9f96d396fb397c7087daf7c2e46a9bac537c3",
"head_commit_message": "Applying different confs to package ID computation",
"patch_to_review": "diff --git a/conans/client/graph/compute_pid.py b/conans/client/graph/compute_pid.py\nindex 0d216c8b345..9dfa82f5d5b 100644\n--- a/conans/client/graph/compu... | [
{
"diff_hunk": "@@ -18,6 +19,7 @@ def compute_package_id(node, new_config):\n embed_mode = new_config.get(\"core.package_id:default_embed_mode\", default=\"full_mode\")\n python_mode = new_config.get(\"core.package_id:default_python_mode\", default=\"minor_mode\")\n build_mode = new_config.get(\"cor... | 307dd891539a769fbcfa1d6f32e8da8cd2143b96 | diff --git a/conans/client/graph/compute_pid.py b/conans/client/graph/compute_pid.py
index 0d216c8b345..5f939c0ae48 100644
--- a/conans/client/graph/compute_pid.py
+++ b/conans/client/graph/compute_pid.py
@@ -40,11 +40,12 @@ def compute_package_id(node, new_config):
build_requires_info = RequirementsInfo(build_dat... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
conan-io__conan-11055@87bee83 | conan-io/conan | Python | 11,055 | self.export_source_folder (based on layout.py) | Changelog: Fix: Renamed `self.base_source_folder` to `self.export_source_folder`. That variable was introduced to reference the folder where the `export_sources` are. Currently, they are copied to the `source` folder but might be changed in the future to avoid copying them, so `self.export_source_folder` will always po... | 2022-04-20T09:17:14Z | [feature] [2.0] exports_sources management
Currently, by default, in the cache, we are copying the `source folder` to the `build folder` unless the `no_copy_source=True`, but _always_, the `self.source_folder` and `self.build_folder` points to the right location.
It might be worth it to explore if the `exports_sourc... | Conan 1.46 introduced ``def base_source_folder(self):`` that points to the base source folder for this purpose. For two reasons:
- The ``exports_sources_folder`` was already used, with different meaning (used in ``export_sources()`` method to point to the cache), and it was creating conflicts
- The ``exports_source... | [
{
"body": "Currently, by default, in the cache, we are copying the `source folder` to the `build folder` unless the `no_copy_source=True`, but _always_, the `self.source_folder` and `self.build_folder` points to the right location.\r\n\r\nIt might be worth it to explore if the `exports_sources` could have a sim... | c62e12a600c99e5bf53b0b71e592dcc88c3b0bfa | {
"head_commit": "87bee8329a110b21ceafd1a870e128800f19f6c2",
"head_commit_message": "remove useless check at update_conandata",
"patch_to_review": "diff --git a/conan/tools/files/conandata.py b/conan/tools/files/conandata.py\nindex 43bd7a12d44..1b7066ac509 100644\n--- a/conan/tools/files/conandata.py\n+++ b/conan... | [
{
"diff_hunk": "@@ -11,8 +11,6 @@ def update_conandata(conanfile, data):\n this only works for updating the conandata on the export() method, it seems it would\n be plain wrong to try to change it anywhere else\n \"\"\"\n- if not hasattr(conanfile, \"export_folder\") or conanfile.export_folder is... | 7dfc27a114f5c701856c04033e974bd88417a69f | diff --git a/conan/tools/files/patches.py b/conan/tools/files/patches.py
index 616b13c0544..dd3084be959 100644
--- a/conan/tools/files/patches.py
+++ b/conan/tools/files/patches.py
@@ -52,7 +52,7 @@ def patch(conanfile, base_path=None, patch_file=None, patch_string=None, strip=0
if patch_file:
# trick *1:... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
conan-io__conan-10659@f3ded2e | conan-io/conan | Python | 10,659 | basic_layout and external_sources for cmake_layout, removed meson_layout | Changelog: Feature: Added `basic_layout`, removed `meson_layout` and added argument `src_folder` to `cmake_layout`as a shortcut for adjusting `conanfile.folders.source`.
Docs: https://github.com/conan-io/docs/pull/2426
Close https://github.com/conan-io/conan/issues/10645
| 2022-02-24T16:17:26Z | [feature] [2.0] predefined layouts when playing locally
- When you work, let's say with CMake, with conan local commands and/or building locally with the build system, if you have a source() method to retrieve the external sources, (e.g conan-center) you may want to adjust the layout as:
```
def layout(self):
... | [
{
"body": "- When you work, let's say with CMake, with conan local commands and/or building locally with the build system, if you have a source() method to retrieve the external sources, (e.g conan-center) you may want to adjust the layout as:\r\n\r\n```\r\n def layout(self):\r\n cmake_layout(self)\r\... | cbbb28978195502cbc43c1f6a8dcafaa91ebb3b6 | {
"head_commit": "f3ded2e11b1ccb5587344ecda030f5ac8c402e54",
"head_commit_message": "src_folder argument",
"patch_to_review": "diff --git a/conan/tools/cmake/layout.py b/conan/tools/cmake/layout.py\nindex 505b077d526..67ef5d6e378 100644\n--- a/conan/tools/cmake/layout.py\n+++ b/conan/tools/cmake/layout.py\n@@ -3,... | [
{
"diff_hunk": "@@ -27,7 +27,12 @@ def cmake_layout(conanfile, generator=None):\n conanfile.folders.build = \"cmake-build-{}\".format(build_type)\n conanfile.folders.generators = os.path.join(conanfile.folders.build, \"conan\")\n \n- conanfile.cpp.source.includedirs = [\"src\"]\n+ if src_f... | f17feabd9959178e1761c4a3b39474987669484d | diff --git a/conan/tools/cmake/layout.py b/conan/tools/cmake/layout.py
index 505b077d526..79a89dd60a8 100644
--- a/conan/tools/cmake/layout.py
+++ b/conan/tools/cmake/layout.py
@@ -3,7 +3,7 @@
from conans.errors import ConanException
-def cmake_layout(conanfile, generator=None):
+def cmake_layout(conanfile, genera... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
conan-io__conan-11310@856ef46 | conan-io/conan | Python | 11,310 | [develop2] Feature/develop2 package signing | Very early stage, to start discussion
| 2022-05-19T17:32:19Z | [feature] Investigate the impact of adding new files to upload/download in the export and package folders
As a mechanism to be able to add metadata to packages and recipes, signatures, etc. Is it breaking to add extra files? Can it be fixed, optin or something? | [
{
"body": "As a mechanism to be able to add metadata to packages and recipes, signatures, etc. Is it breaking to add extra files? Can it be fixed, optin or something?",
"number": 11235,
"title": "[feature] Investigate the impact of adding new files to upload/download in the export and package folders"
... | 631cc13127ffaeab5a5a55bff4268fa4f73c8f21 | {
"head_commit": "856ef46a08034c84102b7d342f9aca3ec97d062b",
"head_commit_message": "restore test",
"patch_to_review": "diff --git a/conan/api/subapi/upload.py b/conan/api/subapi/upload.py\nindex 8f74806b7e6..faf0bf9fee6 100644\n--- a/conan/api/subapi/upload.py\n+++ b/conan/api/subapi/upload.py\n@@ -3,6 +3,7 @@\n... | [
{
"diff_hunk": "@@ -0,0 +1,43 @@\n+import os\n+import textwrap\n+\n+from conans.test.assets.genconanfile import GenConanfile\n+from conans.test.utils.tools import TestClient\n+from conans.util.files import save\n+\n+\n+def test_pkg_sign():\n+ c = TestClient(default_server_user=True)\n+ c.save({\"conanfile... | f147a6bc00a6bfb841cb1a65f7b4a505a6138743 | diff --git a/conan/api/subapi/upload.py b/conan/api/subapi/upload.py
index 8f74806b7e6..faf0bf9fee6 100644
--- a/conan/api/subapi/upload.py
+++ b/conan/api/subapi/upload.py
@@ -3,6 +3,7 @@
from conans.cli.conan_app import ConanApp
from conans.client.cmd.uploader import IntegrityChecker, PackagePreparator, UploadExecu... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
keephq__keep-752@dde0b40 | keephq/keep | Python | 752 | feat: improve api key ux | <!--
Thanks for creating this pull request 🤗
Please make sure that the pull request is limited to one type (docs, feature, etc.) and keep it as small as possible. You can open multiple prs instead of opening a huge one.
-->
<!-- If this pull request closes an issue, please mention the issue number below -->
... | 2024-01-27T05:10:44Z | API Key improvements
Improve API Key UX with:
UI
Settings -> API Key
1. Improve UX with CRUD
2. Add name and details ("api key for team X")
Alerts
3. Add the ability to filter by api key in the UI (or make sure it works)
Backend
4. When pushing alerts via api key, save the relation so it can be later filte... | /bounty 75
@shahargl can i get assigned
/attempt #708
<details id="algora-options">
<summary>Options</summary>
<ul>
<li>
<a href="https://console.algora.io/api/bounties/clrd8w4zs0006l00gwjydg1h6/cancel-attempt">
Cancel my attempt
</a>
</li>
</ul>
</details>
Yep
/attempt #708 I am in... | [
{
"body": "Improve API Key UX with:\r\nUI \r\nSettings -> API Key\r\n1. Improve UX with CRUD\r\n2. Add name and details (\"api key for team X\")\r\n\r\nAlerts\r\n3. Add the ability to filter by api key in the UI (or make sure it works)\r\n\r\nBackend\r\n4. When pushing alerts via api key, save the relation so i... | c1d576b0418a9e5f63614fc2eced328467fdb929 | {
"head_commit": "dde0b403d6230f1fdf60faaabb35711313a6eade",
"head_commit_message": "feat(api): implement api key update function on alert creation",
"patch_to_review": "diff --git a/keep-ui/app/settings/api-key-menu.tsx b/keep-ui/app/settings/api-key-menu.tsx\nnew file mode 100644\nindex 0000000000..990a3bde86\n... | [
{
"diff_hunk": "@@ -0,0 +1,159 @@\n+import React from 'react';\n+import { useForm, Controller, SubmitHandler, FieldValues } from 'react-hook-form';\n+import { Dialog } from \"@headlessui/react\";\n+import { TextInput, Button, Subtitle, SearchSelect, SearchSelectItem, Icon } from \"@tremor/react\";\n+import { Au... | f8463675bc0871fe85c74b000beb5fbe3e47c0c4 | diff --git a/keep-ui/app/settings/api-key-menu.tsx b/keep-ui/app/settings/api-key-menu.tsx
new file mode 100644
index 0000000000..b4ade1f105
--- /dev/null
+++ b/keep-ui/app/settings/api-key-menu.tsx
@@ -0,0 +1,125 @@
+"use client";
+import { Menu, Transition, Portal } from "@headlessui/react";
+import { Fragment} from ... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
conan-io__conan-10633@23e5669 | conan-io/conan | Python | 10,633 | [PkgConfigDeps] Added new property `component_version` | Changelog: Feature: Added new property `component_version` for `PkgConfigDeps` and legacy `PkgConfig`.
Changelog: Feature: Changed `.pc` file description field for components in `PkgConfigDeps`.
Closes: https://github.com/conan-io/conan/issues/10629
Docs: https://github.com/conan-io/docs/pull/2433
- [x] Refer to ... | 2022-02-22T16:10:39Z | [bug] PkgConfigDeps: component version not honored
<!--
Please don't forget to update the issue title.
Include all applicable information to help us reproduce your problem.
To help us debug your issue please explain:
-->
### Environment Details (include every applicable attribute)
* Operating System+v... | [
{
"body": "<!--\r\n Please don't forget to update the issue title.\r\n Include all applicable information to help us reproduce your problem.\r\n\r\n To help us debug your issue please explain:\r\n-->\r\n\r\n### Environment Details (include every applicable attribute)\r\n * Operating System+version: macOS Mo... | a43c1eb782b96fc5d65a054dced719a037974a52 | {
"head_commit": "23e5669e80d13f39325635dc4d95c64e52c9922a",
"head_commit_message": "Added custom versions and descriptions for components",
"patch_to_review": "diff --git a/conan/tools/gnu/pkgconfigdeps/pc_files_creator.py b/conan/tools/gnu/pkgconfigdeps/pc_files_creator.py\nindex 3a33bc83d5c..7a7213dbb96 100644... | [
{
"diff_hunk": "@@ -88,8 +88,8 @@ def _get_formatted_dirs(folders, prefix_path_):\n \n def get_pc_filename_and_content(conanfile, dep, name, requires, description, cpp_info=None):\n package_folder = dep.package_folder\n- version = dep.ref.version\n cpp_info = cpp_info or dep.cpp_info\n+ version = ... | a04724166a5116ac5087c086633dfd8a90767faa | diff --git a/conan/tools/gnu/pkgconfigdeps/pc_files_creator.py b/conan/tools/gnu/pkgconfigdeps/pc_files_creator.py
index 3a33bc83d5c..7a7213dbb96 100644
--- a/conan/tools/gnu/pkgconfigdeps/pc_files_creator.py
+++ b/conan/tools/gnu/pkgconfigdeps/pc_files_creator.py
@@ -33,7 +33,7 @@ def _get_aliases_pc_files_and_content... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
conan-io__conan-10300@9d0799b | conan-io/conan | Python | 10,300 | [feature] Mandatory `os.sdk` for CMakeToolchain (only `AppleSystemBlock` block) | Changelog: Feature: `os.sdk` field is mandatory for CMakeToolchain and OS in `('Macos', 'iOS', 'watchOS', 'tvOS')`.
Docs: omit
Closes: https://github.com/conan-io/conan/issues/10275
- [x] Refer to the issue that supports this Pull Request.
- [x] If the issue has missing info, explain the purpose/use case/pain/n... | 2022-01-10T18:53:44Z | [bug][2.0] CMakeToolchain does not respect os.sdk when targeting armv8 iOS simulator
Hello,
I'm trying to cross-build some iOS recipes, and I think there's a bug in CMakeToolchain. I use this profile:
```ini
[settings]
os=iOS
os.version=9.0
os.sdk=iphonesimulator
build_type=Release
arch=armv8
compiler=appl... | Thanks for reporting, indeed it seems a bug. I think that it should be reproducible in 1.X, so I am targeting this for 1.45 (and it will be automatically merged to 2.0) | [
{
"body": "Hello,\r\n\r\nI'm trying to cross-build some iOS recipes, and I think there's a bug in CMakeToolchain. I use this profile:\r\n\r\n```ini\r\n[settings]\r\nos=iOS\r\nos.version=9.0\r\nos.sdk=iphonesimulator\r\nbuild_type=Release\r\narch=armv8\r\ncompiler=apple-clang\r\ncompiler.version=13.0\r\ncompiler... | f73ada4ca23bfc0c65c944af0b8acb450fe68111 | {
"head_commit": "9d0799b8fb8a19377d3aa59318b8b1903c00c2d2",
"head_commit_message": "Solved bug if os.sdk is passed",
"patch_to_review": "diff --git a/conan/tools/cmake/toolchain.py b/conan/tools/cmake/toolchain.py\nindex 28dc058030a..9472a980938 100644\n--- a/conan/tools/cmake/toolchain.py\n+++ b/conan/tools/cma... | [
{
"diff_hunk": "@@ -356,7 +356,10 @@ def _apple_sdk_name(self):\n we're building for (considering simulators)\"\"\"\n arch = self._conanfile.settings.get_safe('arch')\n os_ = self._conanfile.settings.get_safe('os')\n- if arch.startswith('x86'):\n+ os_sdk = self._conanfile.s... | bb4d00425089da743d6414d5ada4a06ba097b476 | diff --git a/conan/tools/cmake/toolchain.py b/conan/tools/cmake/toolchain.py
index 28dc058030a..8ec99807732 100644
--- a/conan/tools/cmake/toolchain.py
+++ b/conan/tools/cmake/toolchain.py
@@ -350,22 +350,21 @@ def _get_architecture(self):
"armv8": "arm64",
"armv8_32": "arm64_32"}.get(... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
conan-io__conan-10608@9bae5aa | conan-io/conan | Python | 10,608 | Add new sdk_version setting for Apple OS's and new XcodeBuild, XcodeToolchain tools | Changelog: Feature: Add `sdk_version` setting for `Macos`, `iOS`, `watchOS` and `tvOS`.
Changelog: Feature: Add new `XcodeBuild` build helper.
Changelog: Feature: Add new `XcodeToolchain` helper.
Docs: https://github.com/conan-io/docs/pull/2431
Closes: https://github.com/conan-io/conan/issues/9608
Superseeds: ... | 2022-02-17T17:11:38Z | [feature] SDK Version for apple OSes
This is the second year Apple has made a major change to the SDK within the same major release of Xcode.
With Xcode 12.0 Apple shipped macOS SDK 10.15 and with Xcode 12.1 they changed it to macOS SDK 11.0.
Now it looks the same (probably because iOS 15 came out earlier than macOS ... | Thanks for reporting the issue @NoWiseMan
Let me know more about your use case. Have you faced any problem consuming any package at some point?
Adding it directly to the current Conan settings is not such a simple thing I'm afraid. The settings are part of the final `package_id` so we must be careful adding new on... | [
{
"body": "This is the second year Apple has made a major change to the SDK within the same major release of Xcode.\r\nWith Xcode 12.0 Apple shipped macOS SDK 10.15 and with Xcode 12.1 they changed it to macOS SDK 11.0.\r\nNow it looks the same (probably because iOS 15 came out earlier than macOS 12)\r\nXcode 1... | e661edaa4d8ccd0721525e1705f20178190c0f65 | {
"head_commit": "9bae5aa37d06ded1fcf224175a986fba704e28f0",
"head_commit_message": "remove test",
"patch_to_review": "diff --git a/conan/tools/apple/__init__.py b/conan/tools/apple/__init__.py\nindex 06c11573a73..b3a7cb5a388 100644\n--- a/conan/tools/apple/__init__.py\n+++ b/conan/tools/apple/__init__.py\n@@ -6,... | [
{
"diff_hunk": "@@ -154,7 +155,7 @@ def _add_apple_flags(self):\n return\n \n # SDK path is mandatory for cross-building\n- sdk_path = conanfile.conf[\"tools.apple:sdk_path\"]\n+ sdk_path = apple_sdk_path(conanfile)",
"line": null,
"original_line": 158,
"original_st... | 956e3a5eecc5348496cfb012eb968127123d2979 | diff --git a/conan/tools/apple/__init__.py b/conan/tools/apple/__init__.py
index 06c11573a73..b3a7cb5a388 100644
--- a/conan/tools/apple/__init__.py
+++ b/conan/tools/apple/__init__.py
@@ -6,3 +6,5 @@
# from conan.tools.apple.apple import apple_deployment_target_flag
# from conan.tools.apple.apple import to_apple_arc... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
conan-io__conan-10322@08236c6 | conan-io/conan | Python | 10,322 | [Bugfix] Added mandatory fields when VS 2022 auto-detection | Changelog: Bugfix: Visual Studio 2022 auto-detected profile was incomplete.
Docs: omit
Closes: https://github.com/conan-io/conan/issues/10302
- [x] Refer to the issue that supports this Pull Request.
- [x] If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
- [x... | 2022-01-12T10:19:15Z | [bug] Visual Studio 2022 auto-detected profile is incomplete
<!--
Please don't forget to update the issue title.
Include all applicable information to help us reproduce your problem.
To help us debug your issue please explain:
-->
auto-detected profile for Visual Studio 2022 is incompile, and cannot be u... | [
{
"body": "<!--\r\n Please don't forget to update the issue title.\r\n Include all applicable information to help us reproduce your problem.\r\n\r\n To help us debug your issue please explain:\r\n-->\r\n\r\nauto-detected profile for Visual Studio 2022 is incompile, and cannot be used as is, as it's missing t... | 62cdf376ce8e7b713b9a30e37f670c7c43438797 | {
"head_commit": "08236c61267cc1f5843adfb8801af0e56e273340",
"head_commit_message": "Added mandatory fields when VS 2022 auto-detection",
"patch_to_review": "diff --git a/conans/client/conf/detect.py b/conans/client/conf/detect.py\nindex 80b89c543c1..01332987761 100644\n--- a/conans/client/conf/detect.py\n+++ b/c... | [
{
"diff_hunk": "@@ -265,6 +265,11 @@ def _detect_compiler_version(result, output, profile_path):\n result.append((\"compiler.base.version\", \"4.8\"))\n else:\n result.append((\"compiler.base.version\", \"4.4\"))\n+ elif compiler == \"msvc\":\n+ # Add default mandatory ... | 00d0305706a25987501d89b0fc6b8c2ac6474194 | diff --git a/conans/client/conf/detect.py b/conans/client/conf/detect.py
index 80b89c543c1..5b9cf1ed40a 100644
--- a/conans/client/conf/detect.py
+++ b/conans/client/conf/detect.py
@@ -265,6 +265,11 @@ def _detect_compiler_version(result, output, profile_path):
result.append(("compiler.base.version", "4.8"... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} | |
nltk__nltk-3393@838080a | nltk/nltk | Python | 3,393 | Make Wordnet interoperable with various taggers and tagged corpora | Fix #3392 by adding a function that uses Universal Tags (Petrov et al., 2012), to convert the tags available in _nltk_data/taggers/universal_tagset_ to Wordnet Part-of-Speech. This allows to restrict Wordnet searches to the relevant grammatical category.
```
from nltk.corpus import wordnet as wn
from nltk.corpus i... | 2025-05-17T09:02:36Z | Restrict Wordnet searches when Penn Treebank Tags are available
The NLTK Part-of-Speech tagger outputs Penn Treebank tags, which are often neglected when looking the results up in Wordnet. When a word has senses in different grammatical categories, this may lead to considering lots of spurious senses pertaining to irre... | FWIW, here is one implementation of lemmatization with WordNet based on PTB tags:
https://github.com/nschneid/pysupersensetagger/blob/4783c54a28d8e439beb9d115508abb2dc305fbf3/src/morph.py#L24-L47
Thanks @nschneid, L44 in your code is a concise shortcut of the approach I have in mind. You avoid the detour through Unive... | [
{
"body": "The NLTK Part-of-Speech tagger outputs Penn Treebank tags, which are often neglected when looking the results up in Wordnet. When a word has senses in different grammatical categories, this may lead to considering lots of spurious senses pertaining to irrelevant parts-of-speech, which could be avoide... | ebaf5f9ce0736fab9c57ba145081693ab19fd2ee | {
"head_commit": "838080a75e26d7564dd7c76661f5886fb112a89c",
"head_commit_message": "Update nltk/corpus/reader/wordnet.py\n\nCo-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>",
"patch_to_review": "diff --git a/nltk/corpus/reader/wordnet.py b/nltk/corpus/reader/wordnet.py\nindex f74006b90b..4cd9... | [
{
"diff_hunk": "@@ -2108,6 +2108,23 @@ def filter_forms(forms):\n # 2. Return all that are in the database (and check the original too)\n return filter_forms([form] + forms)\n \n+ def tag2pos(self, tag, tagset=\"en-ptb\") -> Optional[str]:\n+ \"\"\"\n+ Convert a tag from one of ... | ba18c70ee8cb1042c9258d3af17a0f10d37a67da | diff --git a/nltk/corpus/reader/wordnet.py b/nltk/corpus/reader/wordnet.py
index f74006b90b..bc52b8686c 100644
--- a/nltk/corpus/reader/wordnet.py
+++ b/nltk/corpus/reader/wordnet.py
@@ -42,6 +42,7 @@
from nltk.corpus.reader import CorpusReader
from nltk.internals import deprecated
from nltk.probability import FreqD... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
conan-io__conan-10532@236db2a | conan-io/conan | Python | 10,532 | File tools at "conan." namespace | Changelog: omit
Docs: omit
Close https://github.com/conan-io/conan/issues/10502
| 2022-02-07T17:00:38Z | [feature] Move file tools to "conan"
There are still some "file" related tools not migrated to "conan".
- Some of them are probably overacting regarding the encoding, probably in some situations, inherited from python2. As we really don't know what is py2 legacy and what is necessary, try to simplify is something look... | I'll keep updating this comment:
**Not moved, not very used** Add to migration guide
- human_size
- untargz (only as internal usage of unzip)
- check_with_algorithm_sum (only as internal usage of sha1, md5, sha256)
- replace_path_in_file (There is some usage in c3i but probably could be omitted)
- replace_prefi... | [
{
"body": "There are still some \"file\" related tools not migrated to \"conan\".\r\n- Some of them are probably overacting regarding the encoding, probably in some situations, inherited from python2. As we really don't know what is py2 legacy and what is necessary, try to simplify is something looks weird or t... | 65082c36268d5a2f402e19ef0dc7197e65e77f63 | {
"head_commit": "236db2a2547c6c64dc5d13c017db81b3593d4d30",
"head_commit_message": "encoding argument, default utf-8",
"patch_to_review": "diff --git a/conan/tools/files/__init__.py b/conan/tools/files/__init__.py\nindex 7a84ecda977..3ac35bd45aa 100644\n--- a/conan/tools/files/__init__.py\n+++ b/conan/tools/file... | [
{
"diff_hunk": "@@ -1,5 +1,7 @@\n from conan.tools.files.files import load, save, mkdir, ftp_download, download, get, rename, \\\n- load_toolchain_args, save_toolchain_args, chdir\n+ load_toolchain_args, save_toolchain_args, chdir, unzip, replace_in_file, collect_libs, \\",
"line": null,
"original... | 1838b976e5c726af593122c9d9da7c62b4576d62 | diff --git a/conan/tools/cmake/cmake.py b/conan/tools/cmake/cmake.py
index e73eb053aa3..b4a2098a6f7 100644
--- a/conan/tools/cmake/cmake.py
+++ b/conan/tools/cmake/cmake.py
@@ -3,7 +3,8 @@
from conan.tools.build import build_jobs
from conan.tools.cmake.utils import is_multi_configuration
-from conan.tools.files imp... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
nltk__nltk-3078@a3d6ae4 | nltk/nltk | Python | 3,078 | Fix wordnet's all_synsets() function | Fix #3077, and a few related problems in wordnet.py.
1. With the English Wordnet, properly distinguish satellites from adjectives:
```
from nltk.corpus import wordnet as wn
print(wn.get_version())
```
3.0
`print(len(list(wn.all_synsets(pos="a"))))`
18156
`print(len(list(wn.all_synsets(pos="s"))))`
106... | 2022-12-01T15:15:46Z | Incorrect part-of-speech filtering in Wordnet's all_synsets()
The _all_synsets()_ function in _wordnet.py_ does not behave as expected when using the _pos_ parameter:
1. With the English wordnet, it confuses adjectives and satellites:
```
from nltk.corpus import wordnet as wn
print(wn.get_version())
```
3.0
... | [
{
"body": "The _all_synsets()_ function in _wordnet.py_ does not behave as expected when using the _pos_ parameter:\r\n\r\n1. With the English wordnet, it confuses adjectives and satellites:\r\n\r\n```\r\nfrom nltk.corpus import wordnet as wn\r\nprint(wn.get_version())\r\n```\r\n3.0\r\n\r\n`print(len(list(wn.al... | 2f34b52da55a6c83fd18306095c9aa00b4996381 | {
"head_commit": "a3d6ae4391ff9219987440284f3683e8fd4faaa8",
"head_commit_message": "Fix all_synsets() function",
"patch_to_review": "diff --git a/nltk/corpus/reader/wordnet.py b/nltk/corpus/reader/wordnet.py\nindex c19e42d1b3..9021fcd0c1 100644\n--- a/nltk/corpus/reader/wordnet.py\n+++ b/nltk/corpus/reader/wordn... | [
{
"diff_hunk": "@@ -1314,6 +1332,10 @@ def add_provs(self, reader):\n lang = f\"{lang}_{prov}\"\n self.provenances[lang] = prov\n \n+ def strip_prov(self, lang):\n+ # return lang[:lang.find(\"_\")+1]\n+ return lang.split(\"_\")[0]\n+",
"line": null... | dda5d05dfb77facdcdd58210abfc7eaac5904863 | diff --git a/nltk/corpus/reader/wordnet.py b/nltk/corpus/reader/wordnet.py
index c19e42d1b3..1b3d5401db 100644
--- a/nltk/corpus/reader/wordnet.py
+++ b/nltk/corpus/reader/wordnet.py
@@ -108,6 +108,11 @@
"Somebody %s VERB-ing",
"It %s that CLAUSE",
"Something %s INFINITIVE",
+ # OEWN additions:
+ "... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} | |
conan-io__conan-10178@bfad507 | conan-io/conan | Python | 10,178 | Multiple CMake User Toolchain | Close #9724
Changelog: Feature: The `CMakeToolchain` is now prepared to apply several user toolchains.
Docs: https://github.com/conan-io/docs/pull/2340
| 2021-12-14T14:58:44Z | [feature] How CMakeToolchain could handle multiple user toolchains
Lets say that we have 2 different build_requires, one ``sdk`` and one ``compiler``. Building a package could use both, and each one would want to inject their own ``user_toolchain.cmake``.
Or they want to propagate information to the consumer in oth... | The ability to provide multiple files to be included in the `UserToolchain` block when using the `CMakeToolchain` generator would provide a lot of flexibility.
I am thinking that we might need a bit more of power in the ``Conf`` class to handle some scenarios. So far the ``Conf`` class is a pure ``key=value`` store, ve... | [
{
"body": "Lets say that we have 2 different build_requires, one ``sdk`` and one ``compiler``. Building a package could use both, and each one would want to inject their own ``user_toolchain.cmake``. \r\n\r\nOr they want to propagate information to the consumer in other ways. Challenges:\r\n\r\n- Passing inform... | da145596d3a22d646c5e000dcf95e7959f86dca9 | {
"head_commit": "bfad50759a09f38221c2144b4152c62413ba5cae",
"head_commit_message": "Removed ordered generators",
"patch_to_review": "diff --git a/conan/tools/cmake/toolchain.py b/conan/tools/cmake/toolchain.py\nindex 52c8c1b130d..832e0251b64 100644\n--- a/conan/tools/cmake/toolchain.py\n+++ b/conan/tools/cmake/t... | [
{
"diff_hunk": "@@ -115,3 +115,69 @@ def test_cmake_toolchain_without_build_type():\n toolchain = client.load(\"conan_toolchain.cmake\")\n assert \"CMAKE_MSVC_RUNTIME_LIBRARY\" not in toolchain\n assert \"CMAKE_BUILD_TYPE\" not in toolchain\n+\n+\n+@pytest.mark.parametrize(\"with_context\", [\"False... | 9468ef557dfa563bff5922984aa33806167169d7 | diff --git a/conan/tools/cmake/toolchain.py b/conan/tools/cmake/toolchain.py
index 52c8c1b130d..b8589b3f450 100644
--- a/conan/tools/cmake/toolchain.py
+++ b/conan/tools/cmake/toolchain.py
@@ -1,3 +1,4 @@
+import json
import os
import re
import textwrap
@@ -457,20 +458,16 @@ def context(self):
class UserToolchain... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
nltk__nltk-3060@b21b5bb | nltk/nltk | Python | 3,060 | Support both iso639-3 codes and BCP-47 language tags | Fix #3058 by adding a function to obtain language names, using their respective iso639-3 language codes.
This PR adds a langname.py module in the nltk directory. I plan to use it with wordnet.py, to obtain the names of the multilingual wordnets from OMW.
```
>>>from nltk.langnames import langname
>>>for code in... | 2022-10-05T10:48:24Z | Translating between language names and iso-639 codes
Some NLTK libraries (tag, crubadan, wordnet) use iso-639 language codes from the International Organization for Standardization (ISO). Iso-639 represents language names using either a 2-letter or 3-letter code that is not always very obvious: for ex. it may be diffic... | _nltk_data/corpora/crubadan/table.txt_ seems to provide the necessary data in 3 columns, and _crubadan.py_ includes functions to translate between columns 1 and 2 from that file. To solve the present issue, it is easy to implement a translation between columns 2 and 3.
However the iso-639 codes in crubadan's _table.tx... | [
{
"body": "Some NLTK libraries (tag, crubadan, wordnet) use iso-639 language codes from the International Organization for Standardization (ISO). Iso-639 represents language names using either a 2-letter or 3-letter code that is not always very obvious: for ex. it may be difficult to guess that _el_ or _ell_ a... | 3ca43e26efd7d5aa37b3cd79446258d8bfa79561 | {
"head_commit": "b21b5bb10691cf2176522c479ffd8c2b54f66363",
"head_commit_message": "Use !r for repr formatting in warnings",
"patch_to_review": "diff --git a/nltk/corpus/__init__.py b/nltk/corpus/__init__.py\nindex 5b0c666a90..c7d1f7b727 100644\n--- a/nltk/corpus/__init__.py\n+++ b/nltk/corpus/__init__.py\n@@ -7... | [
{
"diff_hunk": "@@ -0,0 +1,216 @@\n+# Natural Language Toolkit: BCP-47 language tags\n+#\n+# Copyright (C) 2022 NLTK Project\n+# Author: Eric Kafe <kafe.eric@gmail.com>\n+# URL: <https://www.nltk.org/>\n+# For license information, see LICENSE.TXT\n+\n+import re\n+from warnings import warn\n+from xml.etree impor... | 11f47fc28ae96ef509a165926a9c98a05470f6e2 | diff --git a/nltk/corpus/__init__.py b/nltk/corpus/__init__.py
index 2f8b697e4c..b9d84dbfdb 100644
--- a/nltk/corpus/__init__.py
+++ b/nltk/corpus/__init__.py
@@ -74,6 +74,9 @@
alpino: AlpinoCorpusReader = LazyCorpusLoader(
"alpino", AlpinoCorpusReader, tagset="alpino"
)
+bcp47: BCP47CorpusReader = LazyCorpusLoa... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
nltk__nltk-2883@7f6ebf8 | nltk/nltk | Python | 2,883 | Deprecate 'return_str' parameter in NLTKWordTokenizer and TreebankWordTokenizer | Resolves #2879
As per the discussion on #2879, I have deprecated the use of the 'return_str' parameter in the `tokenize` method of both `NLTKWordTokenizer` and `TreebankWordTokenizer`.
I have currently done this in a way that raises a `DeprecationWarning` if a non-default value is passed to the parameter. | 2021-11-10T19:20:43Z | Deprecate `return_str` parameter in `NLTKWordTokenizer` and `TreebankWordTokenizer`
Hello!
I'd like to discuss a potential enhancements of `NLTKWordTokenizer` and `TreebankWordTokenizer`. For those unaware, the former is the tokenizer that is most frequently used, and is used in the `word_tokenize` function. It's al... | Could we also consider deprecating this usage... I wonder why we did this!
Yeah, sounds good. I can't really imagine a use case for this parameter to begin with.
Hi, I would like to pick this up as my first issue if possible. Does NLTK have a standard way of deprecating parameters already? I have seen the `@Deprecated`... | [
{
"body": "Hello!\r\n\r\nI'd like to discuss a potential enhancements of `NLTKWordTokenizer` and `TreebankWordTokenizer`. For those unaware, the former is the tokenizer that is most frequently used, and is used in the `word_tokenize` function. It's also based on the latter class: `TreebankWordTokenizer`.\r\n\r\... | 7d3d6a4f77b76a1f5eb0d0cbc9731716fcc17e68 | {
"head_commit": "7f6ebf87b31ea99a152ccae02731e06420b378b8",
"head_commit_message": "Deprecated 'return_str' parameter in NLTKWordTokenizer and TreebankWordTokenizer",
"patch_to_review": "diff --git a/AUTHORS.md b/AUTHORS.md\nindex 5b7546d43c..04592e11cc 100644\n--- a/AUTHORS.md\n+++ b/AUTHORS.md\n@@ -285,6 +285,... | [
{
"diff_hunk": "@@ -113,6 +114,15 @@ class NLTKWordTokenizer(TokenizerI):\n CONTRACTIONS3 = list(map(re.compile, _contractions.CONTRACTIONS3))\n \n def tokenize(self, text, convert_parentheses=False, return_str=False):\n+\n+ if return_str is not False:",
"line": null,
"original_line": 118... | ac092f83eb0aafc3a5a379ed5888c57bcf9eef4b | diff --git a/AUTHORS.md b/AUTHORS.md
index 5b7546d43c..04592e11cc 100644
--- a/AUTHORS.md
+++ b/AUTHORS.md
@@ -285,6 +285,7 @@
- Saibo Geng <https://github.com/Saibo-creator>
- Ahmet Yildirim <https://github.com/RnDevelover>
- Yuta Nakamura <https://github.com/yutanakamura-tky>
+- Adam Hawley <https://github.com/ada... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "New Feature Additions"
} |
conan-io__conan-10171@464af1c | conan-io/conan | Python | 10,171 | `test_type` mechanism deprecation | Changelog: Feature: In the conanfile.py of the test_package, the reference being tested is always available at `self.tested_reference_str`.
Changelog: Feature: Introduced a new `test_type` value `explicit` so a user can declare explicitly the `requires` or `build_requires` manually (using `self.tested_reference_str`),... | 2021-12-13T15:30:29Z | [question] How to find out the name of the package to be tested in test_package?
In a `test_package` I can access all dependencies via `self.deps_cpp_info`, but is there any way I can determine which one is the subject under test?
[feature] test package conanfile, `test_type` mechanism deprecation
Conan has the `test_... | Oh, I have found a solution!
Looks like I can get the name from `self.display_name`. Something like `self.display_name.split("/")[0]`.
Is this a good _(and stable)_ way to go?
It seems that ``display_name`` is not documented, so it wouldn't be stable.
Why would you have more than 1 require in a ``test_package`... | [
{
"body": "In a `test_package` I can access all dependencies via `self.deps_cpp_info`, but is there any way I can determine which one is the subject under test?",
"number": 9606,
"title": "[question] How to find out the name of the package to be tested in test_package?"
},
{
"body": "Conan has t... | f42cdf62676f3a8388a9fc1c84c83ec5387b9d13 | {
"head_commit": "464af1c34fd572714fd9b6711faa01f3206166b2",
"head_commit_message": "Rename to testing_reference",
"patch_to_review": "diff --git a/conans/client/graph/graph_manager.py b/conans/client/graph/graph_manager.py\nindex 8ef2708ffbe..e30aa14a36e 100644\n--- a/conans/client/graph/graph_manager.py\n+++ b/... | [
{
"diff_hunk": "@@ -100,6 +100,7 @@ def load_consumer_conanfile(self, conanfile_path, info_folder,\n if test:\n conanfile.display_name = \"%s (test package)\" % str(test)\n conanfile.output.scope = conanfile.display_name\n+ conanfile.testing_reference =... | 83c3ed404660581bb77d9e98a393edfb0dc43aba | diff --git a/conans/client/graph/graph_manager.py b/conans/client/graph/graph_manager.py
index 8ef2708ffbe..25ef2344333 100644
--- a/conans/client/graph/graph_manager.py
+++ b/conans/client/graph/graph_manager.py
@@ -100,6 +100,7 @@ def load_consumer_conanfile(self, conanfile_path, info_folder,
if test:
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
conan-io__conan-10150@151aec8 | conan-io/conan | Python | 10,150 | [fix] Removed CMake warning message | Changelog: Fix: Deleted CMake warning for already existing targets.
Closes: https://github.com/conan-io/conan/issues/10132
Docs: omit
- [x] Refer to the issue that supports this Pull Request.
- [x] If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
- [x] I've rea... | 2021-12-09T08:48:37Z | [bug] CMakeToolchain/CMakeDeps generates CMake warnings when dependency was already found via find_package
### Environment Details (include every applicable attribute)
* Operating System+version: Linux Mint 20.1 Ulyssa
* Compiler+version: gcc 11.1.0
* Conan version: 1.43.0
* Python version: 3.8.10
### St... | I think the issue is doing a ``find_package()`` for a transitive dependency not directly declared in your ``conanfile.py``.
Conan 2.0 is going to completely isolate from transitive dependencies, that ``find_package()`` will probably fail because the headers will not be visible. This feature has been requested many tim... | [
{
"body": "### Environment Details (include every applicable attribute)\r\n * Operating System+version: Linux Mint 20.1 Ulyssa\r\n * Compiler+version: gcc 11.1.0\r\n * Conan version: 1.43.0\r\n * Python version: 3.8.10\r\n\r\n### Steps to reproduce (Include if Applicable)\r\nUse the CMakeToolchain and CMake... | 51a077458b697dcd39e5eb64f1d33a6c52584081 | {
"head_commit": "151aec8b3616244fb6e7d88e7e251b1e9ad82a08",
"head_commit_message": "Keeping aliases warning",
"patch_to_review": "diff --git a/conan/tools/cmake/cmakedeps/templates/targets.py b/conan/tools/cmake/cmakedeps/templates/targets.py\nindex 2f3336ab2d8..007881edbcb 100644\n--- a/conan/tools/cmake/cmaked... | [
{
"diff_hunk": "@@ -899,4 +899,4 @@ def build(self):\n client.save({\"conanfile.py\": consumer, \"CMakeLists.txt\": cmakelists})\n client.run(\"create .\")\n \n- assert \"Target name 'mypkg::name' already exists.\" in client.out\n+ assert \"Target name 'mypkg::name' already exists.\" not in client... | 1d84d6f38687c0cbb9820ba6e773741f4adbf223 | diff --git a/conan/tools/cmake/cmakedeps/templates/targets.py b/conan/tools/cmake/cmakedeps/templates/targets.py
index 2f3336ab2d8..007881edbcb 100644
--- a/conan/tools/cmake/cmakedeps/templates/targets.py
+++ b/conan/tools/cmake/cmakedeps/templates/targets.py
@@ -75,8 +75,6 @@ def template(self):
if(NOT TARGE... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "Bug Fixes"
} |
conan-io__conan-10084@72d88fb | conan-io/conan | Python | 10,084 | Refactored `conan.tools.gnu.pkgconfigdeps` module and added new `pkg_config_aliases` property | Changelog: Feature: `pkg_config_name` is used as the main name for a package/component and it will be used as the name for the `*.pc` file.
Changelog: Feature: Added new property`pkg_config_aliases` which admits a list of strings to define different aliases for any package/component.
Docs: https://github.com/conan-i... | 2021-11-25T16:37:24Z | [feature] introduce alias for PkgConfigDeps
**Issue**: The current PkgConfigDeps scopes the `pc` files with the name of the package, but people, specially from open source and conan-center, want to consume "crypto.pc" not "openssl-crypto.pc", otherwise every consumer would need to modify the build system script.
**P... | For now, it's blocked by https://github.com/conan-io/conan/pull/9851
Actually, it was not blocked by that MR. It can be developed without having it merged | [
{
"body": "**Issue**: The current PkgConfigDeps scopes the `pc` files with the name of the package, but people, specially from open source and conan-center, want to consume \"crypto.pc\" not \"openssl-crypto.pc\", otherwise every consumer would need to modify the build system script.\r\n\r\n**Proposal**\r\n\r\n... | 284de1d77b9ab9196b8c37a1eb42be290cf9f22e | {
"head_commit": "72d88fbf66df489615706b2412eb62185b2bb08c",
"head_commit_message": "Changed 'wrapper' word to 'alias' instead. It's clearer than wrapper",
"patch_to_review": "diff --git a/conan/tools/gnu/__init__.py b/conan/tools/gnu/__init__.py\nindex 287a9e7e207..6c9add03f60 100644\n--- a/conan/tools/gnu/__ini... | [
{
"diff_hunk": "@@ -0,0 +1,139 @@\n+from collections import namedtuple\n+\n+from conans.errors import ConanException\n+\n+\n+def _get_name_with_namespace(namespace, name):\n+ \"\"\"Build a name with a namespace, e.g., openssl-crypto\"\"\"\n+ return \"%s-%s\" % (namespace, name)\n+\n+\n+def _get_package_re... | b00aeec3fb645ddbbd827cdf0330a7038a47334e | diff --git a/conan/tools/gnu/__init__.py b/conan/tools/gnu/__init__.py
index 287a9e7e207..6c9add03f60 100644
--- a/conan/tools/gnu/__init__.py
+++ b/conan/tools/gnu/__init__.py
@@ -1,4 +1,4 @@
from conan.tools.gnu.autotoolstoolchain import AutotoolsToolchain
from conan.tools.gnu.autotoolsdeps import AutotoolsDeps
fr... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
conan-io__conan-9980@b1f9c53 | conan-io/conan | Python | 9,980 | [Bugfix] `CMakeDeps` and options for linking | Changelog: Bugfix: CMakeDeps generated `*-data.cmake` was not including properly the set of link flags.
Changelog: Bugfix: CMakeDeps was not populating `INTERFACE_LINK_OPTIONS` to each target.
Closes: https://github.com/conan-io/conan/issues/9936
Docs: omit
- [x] Refer to the issue that supports this Pull Request... | 2021-11-08T12:20:51Z | [bug] CMakeDeps generated .cmake config files doesn't put linker flags in quotation
<!--
Please don't forget to update the issue title.
Include all applicable information to help us reproduce your problem.
To help us debug your issue please explain:
-->
### Environment Details (include every applicable a... | This is true, the ``sharedlinkflags`` is not prepared to contain things with spaces, this has to be fixed.
Please @franramirez688 try the following:
- Lets build a full functional test, that uses ``exelinkflags``, but also ``cxxflags``
- Real test, building something.
- Only linux
- The dependency defining cp... | [
{
"body": "<!--\r\n Please don't forget to update the issue title.\r\n Include all applicable information to help us reproduce your problem.\r\n\r\n To help us debug your issue please explain:\r\n-->\r\n\r\n### Environment Details (include every applicable attribute)\r\n * Operating System+version: Ubuntu 1... | d27b8b30ea3037a06b31b6f3c5a904db67fc3f00 | {
"head_commit": "b1f9c5361f2251b94a4ae7761f8abd1591247dd9",
"head_commit_message": "Bad indentation",
"patch_to_review": "diff --git a/conan/tools/cmake/cmakedeps/templates/target_configuration.py b/conan/tools/cmake/cmakedeps/templates/target_configuration.py\nindex 1d094692b1d..60cf4e307e3 100644\n--- a/conan/... | [
{
"diff_hunk": "@@ -215,8 +218,8 @@ def join_paths_single_var(values):\n # linker flags without magic: trying to mess with - and / =>\n # https://github.com/conan-io/conan/issues/8811\n # frameworks should be declared with cppinfo.frameworks not \"-framework Foundation\"\n- self.s... | f560ced03de97798f3ac206dd67898ae6aceb5e6 | diff --git a/conan/tools/cmake/cmakedeps/templates/target_configuration.py b/conan/tools/cmake/cmakedeps/templates/target_configuration.py
index 1d094692b1d..60cf4e307e3 100644
--- a/conan/tools/cmake/cmakedeps/templates/target_configuration.py
+++ b/conan/tools/cmake/cmakedeps/templates/target_configuration.py
@@ -110... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
nltk__nltk-2769@b356268 | nltk/nltk | Python | 2,769 | Prevent `debug_decisions` in Punkt from throwing IndexError | Fixes #2519
---
Hello!
### Pull request overview
* Prevent `debug_decisions` in Punkt from throwing IndexError whenever the passed sentence contained a sentence ending in `?`, `!` or a custom defined end character (under `_lang_vars.sent_end_chars`).
* Added 4 tests to show that this no longer throws an Exc... | 2021-07-31T11:24:47Z | PunktSentenceTokenizer doesn't work with custom end sentence character
Example:
```
import nltk
from nltk.tokenize.punkt import PunktLanguageVars
class ExtLangVars(PunktLanguageVars):
sent_end_chars = ('.', '?', '!', '^')
punkt_tk = nltk.data.load('tokenizers/punkt/english.pickle')
punkt_tk._lang_vars ... | [
{
"body": "Example:\r\n\r\n```\r\nimport nltk\r\nfrom nltk.tokenize.punkt import PunktLanguageVars\r\n\r\nclass ExtLangVars(PunktLanguageVars):\r\n sent_end_chars = ('.', '?', '!', '^')\r\n\r\npunkt_tk = nltk.data.load('tokenizers/punkt/english.pickle')\r\npunkt_tk._lang_vars = ExtLangVars()\r\n\r\ntxt1 = 'S... | 1244ab9fc4b130ae20127267d49eea506e30a9ae | {
"head_commit": "b3562688ddc5c0076319dca2a464f60dc74f8985",
"head_commit_message": "Renamed `stanford_segmenter` to `check_stanford_segmenter`\n\nAlso trimmed whitespace",
"patch_to_review": "diff --git a/nltk/test/unit/test_tokenize.py b/nltk/test/unit/test_tokenize.py\nindex 79110e3b4c..a9927cedd0 100644\n--- ... | [
{
"diff_hunk": "@@ -470,3 +462,51 @@ def test_punkt_tokenize_no_custom_lang_vars(self):\n expected = [\"উপরাষ্ট্রপতি শ্রী এম ভেঙ্কাইয়া নাইডু সোমবার আই আই টি দিল্লির হীরক জয়ন্তী উদযাপনের উদ্বোধন করেছেন। অনলাইনের মাধ্যমে এই অনুষ্ঠানে কেন্দ্রীয় মানব সম্পদ উন্নয়নমন্ত্রী শ্রী রমেশ পোখরিয়াল ‘নিশাঙ্ক’ উপস্থিত... | b4155488eefe3a5d83e2a605d7779dd348a65d91 | diff --git a/nltk/test/unit/test_tokenize.py b/nltk/test/unit/test_tokenize.py
index 79110e3b4c..9152ccd091 100644
--- a/nltk/test/unit/test_tokenize.py
+++ b/nltk/test/unit/test_tokenize.py
@@ -14,24 +14,21 @@
LegalitySyllableTokenizer,
)
-def setup_module(module):
- import pytest
+def load_stanford_segme... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
conan-io__conan-9635@c95cb5d | conan-io/conan | Python | 9,635 | Bugfix: PkgConfigDeps generator creates bad `Requires` references | Changelog: Bugfix: Fixed bad `Requires` declaration in `*.pc` files.
Closes: #9631
Docs: omit
- [x] Refer to the issue that supports this Pull Request.
- [x] If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
- [x] I've read the [Contributing guide](https://gith... | 2021-09-20T14:34:21Z | new PkgConfigDeps generator creates wrong gtest suite pc files
<!--
Please don't forget to update the issue title.
Include all applicable information to help us reproduce your problem.
To help us debug your issue please explain:
-->
### Environment Details (include every applicable attribute)
* Operat... | Hi @Makogan
Do you mean the line shot be something like?
```
Requires: gtest-libgtest gtest-gtest_main gtest-gmock gtest-gmock_main
```
So it includes the other .pc file as transitive dependency automatically?
Yes, this seems a bug, lets try to fix it for next release. Thanks for reporting!
Btw, it could b... | [
{
"body": "<!--\r\n Please don't forget to update the issue title.\r\n Include all applicable information to help us reproduce your problem.\r\n\r\n To help us debug your issue please explain:\r\n-->\r\n\r\n### Environment Details (include every applicable attribute)\r\n * Operating System+version: Ubuntu 2... | f95c81b88c97faec708b576ef5da27e25e20b725 | {
"head_commit": "c95cb5dd9b1705fa232cae37ba971642e3a15835",
"head_commit_message": "Fixed bad pkg-config require names",
"patch_to_review": "diff --git a/conan/tools/gnu/pkgconfigdeps.py b/conan/tools/gnu/pkgconfigdeps.py\nindex 13fe1179537..efa9764ffe1 100644\n--- a/conan/tools/gnu/pkgconfigdeps.py\n+++ b/conan... | [
{
"diff_hunk": "@@ -48,14 +48,17 @@ class PkgConfigDeps(object):\n def __init__(self, conanfile):\n self._conanfile = conanfile\n \n+ def _get_composed_require_name(self, pkg_name, comp_name):",
"line": null,
"original_line": 51,
"original_start_line": null,
"path": "conan/tools/g... | 756b3f28c7b66b230caaacd310f6c44fe4366bc5 | diff --git a/conan/tools/gnu/pkgconfigdeps.py b/conan/tools/gnu/pkgconfigdeps.py
index 13fe1179537..9d17756bf28 100644
--- a/conan/tools/gnu/pkgconfigdeps.py
+++ b/conan/tools/gnu/pkgconfigdeps.py
@@ -48,6 +48,10 @@ class PkgConfigDeps(object):
def __init__(self, conanfile):
self._conanfile = conanfile
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
nltk__nltk-2793@d96754b | nltk/nltk | Python | 2,793 | Added multi Bleu functionality and tests | Feature as per #2320
from bleu_score import corpus_bleu
```
references = [[['this', 'is', 'a', 'test'], ['this', 'is' 'test']]]
candidates = [['this', 'is', 'a', 'test']]
print('Individual 1-gram: %f' % corpus_bleu(references, candidates, weights=(1, 0, 0, 0)))
print('Individual 2-gram: %f' % corpus_bleu(refe... | 2021-08-31T10:55:55Z | One-shot BLEU-[2, 3, 4] computation
Hello everyone,
I need to compute the BLEU score with more than one ngram length (ideally, BLEU2, BLEU3, BLEU4, and BLEU5). In my case, this is a very long task, as every hypothesis has some thousand references.
Reading the implementation of the corpus_bleu function, which take... | This would be nice to have... it's a question of who would like to implement it.
Hi, I was looking at getting involved with contributing to NLTK and saw this with the 'goodfirstbug' tag. I will take a crack at this problem if that is OK.
Feel free to take a look at https://github.com/nltk/nltk/blob/develop/CONTRIBUTING... | [
{
"body": "Hello everyone,\r\n\r\nI need to compute the BLEU score with more than one ngram length (ideally, BLEU2, BLEU3, BLEU4, and BLEU5). In my case, this is a very long task, as every hypothesis has some thousand references.\r\n\r\nReading the implementation of the corpus_bleu function, which takes weights... | e629d7e3f22005bd324173f7a7b2cbafb8893aaf | {
"head_commit": "d96754bf6fe42a853cc81854dfdf6fe62fc76502",
"head_commit_message": "Added multi Bleu functionality and tests",
"patch_to_review": "diff --git a/nltk/test/bleu.doctest b/nltk/test/bleu.doctest\nindex a116dcb613..4ea6b8ac9c 100644\n--- a/nltk/test/bleu.doctest\n+++ b/nltk/test/bleu.doctest\n@@ -9,7... | [
{
"diff_hunk": "@@ -150,8 +150,8 @@ def corpus_bleu(\n :type list_of_references: list(list(list(str)))\n :param hypotheses: a list of hypothesis sentences\n :type hypotheses: list(list(str))\n- :param weights: weights for unigrams, bigrams, trigrams and so on\n- :type weights: list(float)\n+ ... | 72e6e6f10c3918512c66e68f95a7f904713efcc3 | diff --git a/nltk/test/bleu.doctest b/nltk/test/bleu.doctest
index a116dcb613..4ea6b8ac9c 100644
--- a/nltk/test/bleu.doctest
+++ b/nltk/test/bleu.doctest
@@ -9,7 +9,7 @@ If the candidate has no alignment to any of the references, the BLEU score is 0.
>>> bleu(
... ['The candidate has no alignment to any of the r... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
conan-io__conan-9504@f1138ec | conan-io/conan | Python | 9,504 | Feature: detect VS2022 as msvc | closes: #9501
Changelog: Feature: Detect Visual Studio 2022 as `msvc`.
Docs: omit
- [ ] Refer to the issue that supports this Pull Request.
- [ ] If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
- [ ] I've read the [Contributing guide](https://github.com/con... | 2021-08-30T18:32:54Z | Make VS2022 use ``msvc`` as the default detected compiler in the profile
We can add as it is experimental, the detection of VS 2022 as ``msvc`` compiler instead of ``Visual Studio``. That might help in improving this new setting, and its support, specially in the new integrations. | [
{
"body": "We can add as it is experimental, the detection of VS 2022 as ``msvc`` compiler instead of ``Visual Studio``. That might help in improving this new setting, and its support, specially in the new integrations.",
"number": 9501,
"title": "Make VS2022 use ``msvc`` as the default detected compile... | a620e5b7ba6b0d2128edd2056b7391b5fabcd77d | {
"head_commit": "f1138ecd5b8d323452b35c381218d3508831f4d1",
"head_commit_message": "- detect VS2022 as msvc\n\nSigned-off-by: SSE4 <tomskside@gmail.com>",
"patch_to_review": "diff --git a/conans/client/conf/compiler_id.py b/conans/client/conf/compiler_id.py\nindex 9fa32e50036..da9adee0591 100644\n--- a/conans/cl... | [
{
"diff_hunk": "@@ -160,6 +160,10 @@ def _get_profile_compiler_version(compiler, version, output):\n return major\n elif compiler == \"intel\" and (int(major) < 19 or (int(major) == 19 and int(minor) == 0)):\n return major\n+ elif compiler == \"msvc\":\n+ # by default, drop the las... | c903143764da458b230b2322b750abdf1da457f8 | diff --git a/conans/client/conf/compiler_id.py b/conans/client/conf/compiler_id.py
index 9fa32e50036..da9adee0591 100644
--- a/conans/client/conf/compiler_id.py
+++ b/conans/client/conf/compiler_id.py
@@ -11,10 +11,11 @@
CLANG = "clang"
APPLE_CLANG = "apple-clang"
SUNCC = "suncc"
-MSVC = "Visual Studio"
+VISUAL_STUD... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
conan-io__conan-9152@a6953d3 | conan-io/conan | Python | 9,152 | New PkgConfigDeps generator #9110 | Changelog: Feature: New ``PkgConfigDeps`` generator.
Docs: https://github.com/conan-io/docs/pull/2133
Closes: #9110
- [x] Refer to the issue that supports this Pull Request.
- [x] If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
- [x] I've read the [Contribu... | 2021-06-24T11:32:20Z | [feature] New ``PkgConfigDeps`` generator
Create a new ``PkgConfigDeps`` generator in ``conan.tools.gnu``:
- Create a .pc file per dependency
- Handle components
- Uses only modern practices (can assume always build/host context)
The location of the output files will be injected by ``AutotoolsToolchain`` and ``... | [
{
"body": "Create a new ``PkgConfigDeps`` generator in ``conan.tools.gnu``:\r\n\r\n- Create a .pc file per dependency\r\n- Handle components\r\n- Uses only modern practices (can assume always build/host context)\r\n\r\nThe location of the output files will be injected by ``AutotoolsToolchain`` and ``MesonToolch... | 413ac92a00964eb23861e20f27de6738883b4459 | {
"head_commit": "a6953d3d8428bcf016509f7aa7a4cc60e6773533",
"head_commit_message": "Deleted bad imports. Using a general class",
"patch_to_review": "diff --git a/conan/tools/gnu/__init__.py b/conan/tools/gnu/__init__.py\nindex 0e60df9ed31..287a9e7e207 100644\n--- a/conan/tools/gnu/__init__.py\n+++ b/conan/tools/... | [
{
"diff_hunk": "@@ -0,0 +1,191 @@\n+\"\"\"\n+ PkgConfigDeps Conan generator\n+\n+ - PC FILE EXAMPLE:\n+\n+ prefix=/usr\n+ exec_prefix=${prefix}\n+ libdir=${exec_prefix}/lib\n+ includedir=${prefix}/include\n+\n+ Name: my-project\n+ Description: Some brief but infor... | 4ff43917806e8df9386b0e6bbc16c231bedf7b2e | diff --git a/conan/tools/gnu/__init__.py b/conan/tools/gnu/__init__.py
index 0e60df9ed31..287a9e7e207 100644
--- a/conan/tools/gnu/__init__.py
+++ b/conan/tools/gnu/__init__.py
@@ -1,3 +1,4 @@
from conan.tools.gnu.autotoolstoolchain import AutotoolsToolchain
from conan.tools.gnu.autotoolsdeps import AutotoolsDeps
fr... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
conan-io__conan-9131@a1a412c | conan-io/conan | Python | 9,131 | Feature/autotools new improvements | Changelog: Feature: Improved the new `AutotoolsToolchain`, `AutotoolsDeps` and `Autotools` build helper.
Docs: https://github.com/conan-io/docs/pull/2135
Closes https://github.com/conan-io/conan/issues/9069 | 2021-06-21T15:19:00Z | [feature] Keep modernizing and testing the new ``conan.tools.gnu`` Autotools integration
It is necessary to keep pushing the new Autotools integration:
- Migrate helpers like ``cppstd_flag_new`` that still live in the old context.
- Modernize them: using always 2 profiles, no auto-detection at all (for example the... | [
{
"body": "It is necessary to keep pushing the new Autotools integration:\r\n\r\n- Migrate helpers like ``cppstd_flag_new`` that still live in the old context. \r\n- Modernize them: using always 2 profiles, no auto-detection at all (for example the one in ``_detected_os()`` in ``get_cross_building()``\r\n- Keep... | bbb47429bc1889c19405c403166626459422eca2 | {
"head_commit": "a1a412ca7a30d89b4108d0d90c03a0781d16885e",
"head_commit_message": "Fix win test",
"patch_to_review": "diff --git a/conan/tools/apple/__init__.py b/conan/tools/apple/__init__.py\nnew file mode 100644\nindex 00000000000..8c89798b32b\n--- /dev/null\n+++ b/conan/tools/apple/__init__.py\n@@ -0,0 +1,7... | [
{
"diff_hunk": "@@ -0,0 +1,270 @@\n+from conans.model.version import Version\n+\n+\n+def cppstd_flag(settings):",
"line": null,
"original_line": 4,
"original_start_line": null,
"path": "conan/tools/gnu/get_cppstd.py",
"start_line": null,
"text": "@user1:\nThis file doesn't look like a ``... | 84b86dc878939aade2dfead65e53fe5368f8d17b | diff --git a/conan/tools/_compilers.py b/conan/tools/_compilers.py
index 7f1f954007a..2eaa2718ca2 100644
--- a/conan/tools/_compilers.py
+++ b/conan/tools/_compilers.py
@@ -1,4 +1,5 @@
from conans.client.tools.apple import to_apple_arch
+from conans.model.version import Version
def architecture_flag(settings):
@@... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
Subsets and Splits
Review Test Instances
Retrieves basic metadata about code review instances but doesn't provide any analytical insights or patterns beyond raw data access.