instance_id stringlengths 21 53 | repo stringclasses 188
values | language stringclasses 1
value | pull_number int64 20 148k | title stringlengths 6 144 | body stringlengths 0 83.4k | created_at stringdate 2015-09-25 03:17:17 2025-07-10 16:50:35 | problem_statement stringlengths 188 240k | hints_text stringlengths 0 145k | resolved_issues listlengths 1 6 | base_commit stringlengths 40 40 | commit_to_review dict | reference_review_comments listlengths 1 62 | merged_commit stringlengths 40 40 | merged_patch stringlengths 297 9.87M | metadata dict |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
conan-io__conan-8985@145eaf3 | conan-io/conan | Python | 8,985 | CMakeDeps build_requires full support | Changelog: Feature: Introduced new options for the `CMakeDeps` generator allowing to manage `build_requires` even declaring the same package as a `require` and `build_require` avoiding the collision of the `config` cmake files and enabling to specify which `build_modules` should be included (e.g protobuf issue)
Docs: ... | 2021-05-21T11:10:04Z | [question] 'build_modules' of `build_requires` are not included when building consumers with build/host profiles
I'm experimenting with the build and host context profiles and many of my builds are breaking due to the changes in how `build_requires` are handled. So I'm just trying to understand if this is intentional ... | Hi @GordonJess
In theory, if that tool is an executable that is running in the current build machine, then it should be in the build context, not the host context.
You are right, it seems you hit some missing functionality. So far, the ``build_modules`` feature only works without contexts. When using contexts, t... | [
{
"body": "I'm experimenting with the build and host context profiles and many of my builds are breaking due to the changes in how `build_requires` are handled. So I'm just trying to understand if this is intentional and whether I need to update my recipes.\r\n\r\nFor example, I have a tool which is used to ge... | 8de0c3315fa9a16da66a143ba68b3936b88a435a | {
"head_commit": "145eaf32fad38d465ff34d38a1d8190970133d4d",
"head_commit_message": "fix win",
"patch_to_review": "diff --git a/conan/tools/cmake/cmakedeps/cmakedeps.py b/conan/tools/cmake/cmakedeps/cmakedeps.py\nindex a1619a68a4d..1deb5553237 100644\n--- a/conan/tools/cmake/cmakedeps/cmakedeps.py\n+++ b/conan/to... | [
{
"diff_hunk": "@@ -8,13 +8,37 @@ class CMakeDepsFileTemplate(object):\n \n def __init__(self, cmakedeps, req):\n self.cmakedeps = cmakedeps\n- if req is not None:\n- self.conanfile = req\n- self.pkg_name = req.ref.name\n- self.package_folder = req.package_fol... | 24212f4ab1bc03aa04ed2a890318c51714371914 | diff --git a/conan/tools/cmake/cmakedeps/cmakedeps.py b/conan/tools/cmake/cmakedeps/cmakedeps.py
index a1619a68a4d..1deb5553237 100644
--- a/conan/tools/cmake/cmakedeps/cmakedeps.py
+++ b/conan/tools/cmake/cmakedeps/cmakedeps.py
@@ -6,6 +6,7 @@
from conan.tools.cmake.cmakedeps.templates.target_configuration import Tar... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
conan-io__conan-8927@0e045ac | conan-io/conan | Python | 8,927 | [fix] Respect order of declared directories when using components | Changelog: BugFix: Respect order of declared directories when using components.
Docs: omit
- [x] Refer to the issue that supports this Pull Request: close #8904
- [x] If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
- [x] I've read the [Contributing guide](https... | 2021-05-06T16:09:56Z | [question] How to specify 'includedirs'?
This refers to Windows and Visual Studio.
I try to change default includedirs of a components on Windows, in package_info() method
I say
self.cpp_info.components["BASE"].includedirs = ['include/Release', 'include']
and get in CONAN_INCLUDE_DIRS: ['include', 'include/Relea... | Hi @gouriano,
What generator are you using to check the result of CONAN_INCLUDE_DIRS?
It is CMake
I am looking at the contents of conanbuildinfo.cmake,
So not sure what might be happening here but I guess is something related to repeated directories across the dependency graph. CONAN_INCLUDE_DIRS variable aggrega... | [
{
"body": "This refers to Windows and Visual Studio. \r\nI try to change default includedirs of a components on Windows, in package_info() method\r\n\r\nI say\r\nself.cpp_info.components[\"BASE\"].includedirs = ['include/Release', 'include']\r\nand get in CONAN_INCLUDE_DIRS: ['include', 'include/Release'] - rev... | 810a11aa84827bad61e8221e7016ded9614a4506 | {
"head_commit": "0e045ac0beac29637ce795b436ac705500e4eb73",
"head_commit_message": "separate functions for aggregating lists and dicts",
"patch_to_review": "diff --git a/conans/model/build_info.py b/conans/model/build_info.py\nindex 514f44c8b62..39f8cbaff68 100644\n--- a/conans/model/build_info.py\n+++ b/conans/... | [
{
"diff_hunk": "@@ -414,3 +414,18 @@ def test_deps_cpp_info_components(self):\n self.assertListEqual([os.path.join(folder, \"include\")], list(deps_cpp_info.include_paths))\n self.assertListEqual([os.path.join(folder, \"include\")],\n list(deps_cpp_info[\"my_lib\"].c... | fd04d94a6a93d22b0aa976096c71eb2eea987011 | diff --git a/conans/model/build_info.py b/conans/model/build_info.py
index 514f44c8b62..39f8cbaff68 100644
--- a/conans/model/build_info.py
+++ b/conans/model/build_info.py
@@ -556,14 +556,29 @@ def __getattr__(self, item):
attr = self._cpp_info.__getattr__(item)
return attr
- def _aggregated... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Documentation Updates"
} |
conan-io__conan-8819@8adcb8e | conan-io/conan | Python | 8,819 | Feature : cross-building tests for new AutoTools build helper | closes: #8762
Changelog: Feature: Add cross-building tests for new AutoTools build helper.
Docs: omit
- [x] Refer to the issue that supports this Pull Request.
- [x] If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
- [x] I've read the [Contributing guide](https... | 2021-04-16T12:56:56Z | [feature] Implementation of cross-build triplets in new conan.tools.gnu AutotoolsToolchain
- Triplets must be defined at toolchain time (``generate()``), and stored in a file or any mechanism that makes as easy as possible to be used by users. In the worst case, yes, copy&paste from file to avoid retyping.
- The ``Aut... | Please @SSE4 use the new ``CONAN_TOOLCHAIN_ARGS_FILE = "conanbuild.json"`` file to gather variables for ``Autotools`` instead of separate files, and lets use that accross build systems. Otherwise it is becoming a bit cluttered. | [
{
"body": "- Triplets must be defined at toolchain time (``generate()``), and stored in a file or any mechanism that makes as easy as possible to be used by users. In the worst case, yes, copy&paste from file to avoid retyping.\r\n- The ``Autootools()`` helper in the ``build()`` method will just use this from t... | 4d00a3e51e8d1b6ac1431831b146b34a1d8829c7 | {
"head_commit": "8adcb8ed8cb9aac41ff1b768331d5f1365668ab3",
"head_commit_message": "- cross-building tests for new AutoTools build helper\n\nSigned-off-by: SSE4 <tomskside@gmail.com>",
"patch_to_review": "diff --git a/conan/tools/gnu/autotools.py b/conan/tools/gnu/autotools.py\nindex 6c912487b43..fd0329e3d1e 100... | [
{
"diff_hunk": "@@ -1,7 +1,12 @@\n+import json\n+\n+from conan.tools import CONAN_TOOLCHAIN_ARGS_FILE\n from conan.tools._compilers import architecture_flag, build_type_flags\n from conan.tools.env import Environment\n # FIXME: need to refactor this import and bring to conan.tools\n from conans.client.build.cpp... | c226955552c9c95a3223af8c605467a618b9c714 | diff --git a/conan/tools/gnu/autotools.py b/conan/tools/gnu/autotools.py
index 6c912487b43..fd0329e3d1e 100644
--- a/conan/tools/gnu/autotools.py
+++ b/conan/tools/gnu/autotools.py
@@ -1,6 +1,9 @@
-import platform
+import json
+import os
+from conan.tools import CONAN_TOOLCHAIN_ARGS_FILE
from conan.tools._compilers ... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
conan-io__conan-8727@d83e979 | conan-io/conan | Python | 8,727 | Alternative way of setting properties that depend on generator specific features. | Changelog: Feature: Add `set_property` and `get_property` to set properties and access them in generators. Can be set only for a specific generator or as a default value for all of them.
Changelog: Feature: Use `set_property` and `get_property` to support custom defined content in `pkg_config` generator.
Changelog: F... | 2021-03-29T15:37:00Z | [feature] Allow arbitrary sections in pkg_config .pc files
pkg_config files can contain extra information, next to include paths/library paths/libs/cflags/requires/...
This is used by some programs to pass around configuration paths.
Because the generated .pc files by conan, are missing this information, configurat... | this blocks https://github.com/conan-io/conan-center-index/pull/3663
This prevents generation of proper .pc files like the gst-plugins-base's gstreamer-video-1.0.pc
another example where it is needed: https://github.com/GNOME/gobject-introspection/blob/master/meson.build#L243
Thanks for the feedback. I am trying to un... | [
{
"body": "pkg_config files can contain extra information, next to include paths/library paths/libs/cflags/requires/...\r\nThis is used by some programs to pass around configuration paths.\r\n\r\nBecause the generated .pc files by conan, are missing this information, configuration fails.\r\n\r\ne.g. glib uses t... | 1bdb0de03d21a625c434721f9eca415105e2ddad | {
"head_commit": "d83e9795a566b377a2cf15bbb5ff87592a3847d9",
"head_commit_message": "remove argument",
"patch_to_review": "diff --git a/conans/client/generators/pkg_config.py b/conans/client/generators/pkg_config.py\nindex 079d354d09e..1a6e4ef7d48 100644\n--- a/conans/client/generators/pkg_config.py\n+++ b/conans... | [
{
"diff_hunk": "@@ -209,15 +210,49 @@ def name(self):\n def name(self, value):\n self._name = value\n \n+ # TODO: Deprecate for 2.0. Only cmake and pkg_config generators should access this.\n+ # Use get_property for 2.0\n def get_name(self, generator):\n- return self.names.get(gene... | a4b7e41aaa6c596dbb0d2005ba2468fd28d0ae35 | diff --git a/conans/client/generators/pkg_config.py b/conans/client/generators/pkg_config.py
index 079d354d09e..fbd1726a32d 100644
--- a/conans/client/generators/pkg_config.py
+++ b/conans/client/generators/pkg_config.py
@@ -81,6 +81,10 @@ def _pc_file_content(self, name, cpp_info, requires_gennames):
incl... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
conan-io__conan-8665@0092d41 | conan-io/conan | Python | 8,665 | More fine-grained control (using [conf]) for build parallelization | Changelog: Feature: More fine-grained control (using [conf]) for build parallelization.
Docs: https://github.com/conan-io/docs/pull/2061
This PR introduces the following entries in `conf`:
* `tools.build:processes`: number of processes to use for every build-helper
* `tools.gnu.make:jobs`: argument for the `--j... | 2021-03-17T18:37:32Z | Propose ``cpu_count`` alternative in [conf] for build systems paralelism
For build helpers in ``conan.tools.xxxx``, the parallelism should be configurable via [conf] (and not ``cpu_count``).
Please propose a solution, some guidelines:
- No need that recipes specify it, not explicitly, not as arguments, and they c... | What about following entries in `conf`:
* `core.build:processes`: number of processes to use for every build-helper
* `tools.gnu.make:jobs`: argument for the `--jobs` parameter when running `make` (overrides the general `core.build:processes`).
* `tools.microsoft.msbuild:maxCpuCount`: argument for the `/m` (`/max... | [
{
"body": "For build helpers in ``conan.tools.xxxx``, the parallelism should be configurable via [conf] (and not ``cpu_count``).\r\n\r\nPlease propose a solution, some guidelines:\r\n\r\n- No need that recipes specify it, not explicitly, not as arguments, and they can default back to whatever the build system l... | acf6de21d5df09c5f9b4743bb9c2c3e1c33d30c8 | {
"head_commit": "0092d4103db8702dd4c034004359fd8b46ebcd92",
"head_commit_message": "add unittesting",
"patch_to_review": "diff --git a/conan/tools/cmake/cmake.py b/conan/tools/cmake/cmake.py\nindex 049926a0e2c..43c216c91a3 100644\n--- a/conan/tools/cmake/cmake.py\n+++ b/conan/tools/cmake/cmake.py\n@@ -3,13 +3,15... | [
{
"diff_hunk": "@@ -23,15 +25,27 @@ def _validate_recipe(conanfile):\n \n def _cmake_cmd_line_args(conanfile, generator, parallel):\n args = []\n- compiler_version = conanfile.settings.get_safe(\"compiler.version\")\n- if generator and parallel:\n- if (\"Makefiles\" in generator or \"Ninja\" in... | 6222e240e16f13e2f4025a3820e62870ac615fcb | diff --git a/conan/tools/cmake/cmake.py b/conan/tools/cmake/cmake.py
index 049926a0e2c..dc6fc8b72c4 100644
--- a/conan/tools/cmake/cmake.py
+++ b/conan/tools/cmake/cmake.py
@@ -3,13 +3,15 @@
from conan.tools.cmake.base import CMakeToolchainBase
from conan.tools.cmake.utils import get_generator, is_multi_configurati... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
conan-io__conan-8625@3c0b44e | conan-io/conan | Python | 8,625 | Do not remove sh from path in the new CMake helper | Changelog: Feature: Do not remove sh from the path in the new CMake helper.
Docs: https://github.com/conan-io/docs/pull/2055
#TAGS: slow
- [x] Refer to the issue that supports this Pull Request: closes #8597
- [x] If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Reques... | 2021-03-10T09:20:11Z | Remove removal of "sh" from path for MinGW in CMake
New conan.tools.cmake CMake helper contains:
```python
if is_windows_mingw:
with tools.remove_from_path("sh"):
self._conanfile.run(command)
```
This is no longer necessary, can be replaced by ``set(DCMAKE_SH="CMAKE_SH-NOT... | [
{
"body": "New conan.tools.cmake CMake helper contains:\r\n\r\n```python\r\n if is_windows_mingw:\r\n with tools.remove_from_path(\"sh\"):\r\n self._conanfile.run(command)\r\n```\r\n\r\nThis is no longer necessary, can be replaced by ``set(DCMAKE_SH=\"CMAKE_SH-NOTFOUND\")``. Pl... | 8946a079a4857e20ab8dc33adac8d3069e0fd3af | {
"head_commit": "3c0b44e6bd0be4a5c6d097698810443002fdc4e7",
"head_commit_message": "Use CMAKE_SH-NOTFOUND",
"patch_to_review": "diff --git a/conan/tools/cmake/base.py b/conan/tools/cmake/base.py\nindex 860892e704f..5a520f642f8 100644\n--- a/conan/tools/cmake/base.py\n+++ b/conan/tools/cmake/base.py\n@@ -95,6 +95... | [
{
"diff_hunk": "@@ -528,3 +528,53 @@ def build(self):\n client.run(\"install .\")\n client.run(\"build .\")\n self.assertIn(\"VALUE OF CONFIG STRING: my new value\", client.out)\n+\n+\n+@pytest.mark.skipif(platform.system() != \"Windows\", reason=\"Tests Windows MinGW\")",
"line": nu... | eaf838224e6ac74fdeef406449dccc7fdbd9eaf5 | diff --git a/conan/tools/cmake/cmake.py b/conan/tools/cmake/cmake.py
index 4139447819d..049926a0e2c 100644
--- a/conan/tools/cmake/cmake.py
+++ b/conan/tools/cmake/cmake.py
@@ -79,17 +79,15 @@ def configure(self, source_folder=None):
self._conanfile.package_folder.replace("\\", "/"),
source)
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Code Refactoring / Architectural Improvement"
} | |
conan-io__conan-8685@608b5b8 | conan-io/conan | Python | 8,685 | Relative profile path should be valid for creation commands | Conan accepts absolute and relative paths for profiles, that's well [documented](https://docs.conan.io/en/latest/reference/profiles.html).
We know the main recommendation is absolute, but relative path is not working well when is associated to same tree level, and profile names is same from default profile folder. I... | 2021-03-22T21:25:33Z | [question] profile search order
From some testing, it seems conan tries to resolve relative paths to profiles in the following order:
1. resolve from `.conan/profiles`
2. resolve from current directory
I'm a bit confused why this order was chosen, as it doesn't seem to be intuitive: Why try the more general solu... | Hi @PengolodhGoedath
It's not clear which steps did you use to validate it. Could you please share your steps?
Indeed Conan tries first `.conan/profiles` because it's the default path. As documented, [profiles](https://docs.conan.io/en/latest/reference/profiles.html) can be used as absolute path, and that's the ... | [
{
"body": "From some testing, it seems conan tries to resolve relative paths to profiles in the following order:\r\n\r\n1. resolve from `.conan/profiles`\r\n2. resolve from current directory\r\n\r\nI'm a bit confused why this order was chosen, as it doesn't seem to be intuitive: Why try the more general solutio... | f230bf104842c160be6ea377497151fe1ea64c38 | {
"head_commit": "608b5b8c90a35b2ecba6d2df9c178bc2800db69a",
"head_commit_message": "#8678 Support relative profile folder\n\nSigned-off-by: Uilian Ries <uilianries@gmail.com>",
"patch_to_review": "diff --git a/conans/client/profile_loader.py b/conans/client/profile_loader.py\nindex 9ba3a1cd295..598f4e92323 10064... | [
{
"diff_hunk": "@@ -90,7 +90,9 @@ def valid_path(_profile_path):\n if os.path.isabs(profile_name):\n return valid_path(profile_name)\n \n- if profile_name[:2] in (\"./\", \".\\\\\"): # local\n+ # relative local profile path\n+ if profile_name[:2] in (\"./\", \".\\\\\") or \\",
"line": ... | 8295aefbbb762f6d59b3fa229155f43f980732d9 | diff --git a/conans/client/profile_loader.py b/conans/client/profile_loader.py
index 9ba3a1cd295..0ce54ba67ea 100644
--- a/conans/client/profile_loader.py
+++ b/conans/client/profile_loader.py
@@ -82,17 +82,17 @@ def _apply_in_profile_text(self):
def get_profile_path(profile_name, default_folder, cwd, exists=True)... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
conan-io__conan-8408@7e9a477 | conan-io/conan | Python | 8,408 | Fix exit code for conan_build_info | Changelog: Bugfix: Fix exit code for `conan_build_info`.
Docs: omit
Fixes: https://github.com/conan-io/conan/issues/8395
- [X] Refer to the issue that supports this Pull Request.
- [X] If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
- [X] I've read the [Cont... | 2021-01-28T18:14:10Z | [bug] conan_build_info does not raise in event of an error
Failure to publish buildinfo in one of our CI jobs went undetected because an error occurred but was not raised.
### Environment Details (include every applicable attribute)
* Operating System+version: Windows 10 64-bit
* Compiler+version: n/a
* Con... | Hi @GordonJess,
Thanks a lot for reporting, you are right the exit code of `conan_build_info` was not correctly applied.
Will be fixed as soon as possible. | [
{
"body": "Failure to publish buildinfo in one of our CI jobs went undetected because an error occurred but was not raised.\r\n\r\n### Environment Details (include every applicable attribute)\r\n * Operating System+version: Windows 10 64-bit\r\n * Compiler+version: n/a\r\n * Conan version: 1.33.0\r\n * Pyth... | fe8ec5185b0fb19951a8aaa0c110a2bcff4120e4 | {
"head_commit": "7e9a477495048d1d28853cf68520c06081e2566e",
"head_commit_message": "exit 1 when error",
"patch_to_review": "diff --git a/conans/build_info/command.py b/conans/build_info/command.py\nindex 20dcc74598d..5bc40ead8cd 100644\n--- a/conans/build_info/command.py\n+++ b/conans/build_info/command.py\n@@ -... | [
{
"diff_hunk": "@@ -121,10 +121,9 @@ def check_credential_arguments():\n check_credential_arguments()\n publish_build_info(args.buildinfo, args.url, args.user, args.password,\n args.apikey)\n- except ConanException as exc:\n- output.error(exc)\n ... | dda0eb8ee619daaa696873873aea74879421fcd9 | diff --git a/conans/build_info/command.py b/conans/build_info/command.py
index 20dcc74598d..f49ded092bc 100644
--- a/conans/build_info/command.py
+++ b/conans/build_info/command.py
@@ -34,10 +34,10 @@ def runv1():
if not os.path.exists(args.trace_path):
output.error("Conan trace log not found! '... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
conan-io__conan-8186@27077e9 | conan-io/conan | Python | 8,186 | add build_requires to conandeps.props file in MSBuildDeps | Changelog: Fix: Include ``build_requires`` in the global ``conandeps.props`` file generated by MSBuildDeps.
Changelog: Fix: Change `MSBuildDeps` file ``conan_deps.props`` to ``conandeps.props`` to avoid collision with a package named "deps".
Docs: Omit
Close https://github.com/conan-io/conan/issues/8170 | 2020-12-10T11:54:48Z | [bug] MSBuildDeps generator: build_requires not added to conan_deps.props
Build requirements are not added to the generated `conan_foo.props` file.
### Environment Details (include every applicable attribute)
* Operating System+version:
* Compiler+version:
* Conan version: 1.32.0
* Python version:
###... | Hi @lieser
This could be a bug, but please take into account that the new ``MSBuildDeps`` generator is an experimental one and might change its behavior, and one of the things that might change is the management of ``build_requires``. As documented, explained in the trainings, etc:
> build_requires are designed... | [
{
"body": "Build requirements are not added to the generated `conan_foo.props` file.\r\n\r\n### Environment Details (include every applicable attribute)\r\n * Operating System+version:\r\n * Compiler+version:\r\n * Conan version: 1.32.0\r\n * Python version:\r\n\r\n### Steps to reproduce (Include if Applica... | da41e3398d46ffc3548166526973d6805ffe0028 | {
"head_commit": "27077e9b71424a96dc067cc4728ffc75225356d2",
"head_commit_message": "using deps_cpp_info.direct_deps instead of conanfile attrs",
"patch_to_review": "diff --git a/conan/tools/microsoft/msbuilddeps.py b/conan/tools/microsoft/msbuilddeps.py\nindex 2853bd973c8..cea59cf308b 100644\n--- a/conan/tools/m... | [
{
"diff_hunk": "@@ -217,11 +217,12 @@ def _content(self):\n if not self._conanfile.settings.get_safe(\"build_type\"):\n raise ConanException(\"The 'msbuild' generator requires a 'build_type' setting value\")\n result = {}\n- general_name = \"conan_deps.props\"\n+ genera... | 8e7f8b5a4191a7af93a5238f4995bcf1ca7ed9ec | diff --git a/conan/tools/microsoft/msbuilddeps.py b/conan/tools/microsoft/msbuilddeps.py
index 2853bd973c8..98823066660 100644
--- a/conan/tools/microsoft/msbuilddeps.py
+++ b/conan/tools/microsoft/msbuilddeps.py
@@ -217,11 +217,12 @@ def _content(self):
if not self._conanfile.settings.get_safe("build_type"):
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
conan-io__conan-8053@c686eaf | conan-io/conan | Python | 8,053 | Feature/validate | Changelog: Feature: Introduce a new `BINARY_INVALID` mode for more flexible definition and management of invalid configurations.
Docs: https://github.com/conan-io/docs/pull/1947
Close https://github.com/conan-io/conan/issues/7591
This PR satisfies 2 current proposals/requests:
- The need to specify "impossibl... | 2020-11-12T22:30:52Z | [feature] Method to be run after the graph is resolved
There are some checks that are needed and cannot be run in the `configure()` method:
* values from options of the requirements
* actual version of the requirements (if using version-ranges or overriding).
**Motivation**
Right now, these checks are moved t... | For hooks I think we can use `pre_build`, but for regular validation this new feature looks interesting.
It would be nice if conan was able to report a summary of options/requirements violations, instead of just raise at the first error. Otherwise, consumers may fall in a "die and retry" or "read your 100 conanfiles" ... | [
{
"body": "There are some checks that are needed and cannot be run in the `configure()` method:\r\n * values from options of the requirements\r\n * actual version of the requirements (if using version-ranges or overriding).\r\n\r\n**Motivation**\r\n\r\nRight now, these checks are moved to the `build()` method, ... | e15dc7902fbbeaf469798a3b9948ead1ecfc8e3c | {
"head_commit": "c686eafa8f63f4310c8bea0a4443d3a91f787241",
"head_commit_message": "add conan info --json checks",
"patch_to_review": "diff --git a/conans/client/graph/graph.py b/conans/client/graph/graph.py\nindex 8c842c974c9..c49bb8e3851 100644\n--- a/conans/client/graph/graph.py\n+++ b/conans/client/graph/gra... | [
{
"diff_hunk": "@@ -0,0 +1,224 @@\n+import json\n+import textwrap\n+import unittest\n+\n+from conans.cli.exit_codes import ERROR_INVALID_CONFIGURATION\n+from conans.client.graph.graph import BINARY_INVALID\n+from conans.model.info import PACKAGE_ID_INVALID\n+from conans.test.assets.genconanfile import GenConanf... | 651966ce31996f887ca62c522f84d76a8614d64f | diff --git a/conans/client/graph/graph.py b/conans/client/graph/graph.py
index 8c842c974c9..c49bb8e3851 100644
--- a/conans/client/graph/graph.py
+++ b/conans/client/graph/graph.py
@@ -21,6 +21,7 @@
BINARY_SKIP = "Skip"
BINARY_EDITABLE = "Editable"
BINARY_UNKNOWN = "Unknown"
+BINARY_INVALID = "Invalid"
CONTEXT_HO... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
conan-io__conan-8457@d5d238e | conan-io/conan | Python | 8,457 | New AutotoolsDeps, AutotoolsToolchain helpers in conan.tools.gnu | Changelog: Feature: New AutotoolsDeps, AutotoolsToolchain helpers in conan.tools.gnu
Docs: https://github.com/conan-io/docs/pull/2057
Close https://github.com/conan-io/conan/issues/7070 (will invert the logic in _GLIBCXX_USE_CXX11_ABI)
| 2021-02-08T00:45:55Z | [bug] Invert the logic of _GLIBCXX_USE_CXX11_ABI ?
<!--
Please don't forget to update the issue title.
Include all applicable information to help us reproduce your problem.
To help us debug your issue please explain:
-->
### Environment Details (include every applicable attribute)
* Operating System+v... | Hi @0x8000-0000
> The default for _GLIBCXX_USE_CXX11_ABI is 1 for several years now. Can we invert the logic of compiler.libcxx to use libstdc++ancient for the older version and use libstdc++ by default, or have libstdc++ NOT emit _GLIBCXX_USE_CXX11_ABI ?
I am not sure I understood that. Is that you are using th... | [
{
"body": "<!--\r\n Please don't forget to update the issue title.\r\n Include all applicable information to help us reproduce your problem.\r\n\r\n To help us debug your issue please explain:\r\n-->\r\n\r\n### Environment Details (include every applicable attribute)\r\n * Operating System+version: Ubuntu 1... | beaca4195d700c944f0f7b098e267a509f78acb4 | {
"head_commit": "d5d238e22c9a255f8b0320cc0a2fc1e562dac2c9",
"head_commit_message": "fix adjust path",
"patch_to_review": "diff --git a/.gitignore b/.gitignore\nindex 2e4f6277c3e..4a27bb1ea69 100644\n--- a/.gitignore\n+++ b/.gitignore\n@@ -7,7 +7,6 @@ __pycache__/\n \n # Distribution / packaging\n .Python\n-env/\... | [
{
"diff_hunk": "@@ -0,0 +1,206 @@\n+import os\n+import platform\n+import textwrap\n+import time\n+\n+import pytest\n+\n+from conans.test.assets.autotools import gen_makefile_am, gen_configure_ac\n+from conans.test.assets.sources import gen_function_cpp\n+from conans.test.functional.utils import check_exe_run\n+... | 67d2275470332b6dda23350df087b98126c454bd | diff --git a/conan/tools/_compilers.py b/conan/tools/_compilers.py
index b1eaf5ec587..05b4d10c399 100644
--- a/conan/tools/_compilers.py
+++ b/conan/tools/_compilers.py
@@ -39,3 +39,76 @@ def architecture_flag(settings):
"e2k-v6": "-march=elbrus-v6",
"e2k-v7": "-march=elbrus-v7"}.get(s... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
conan-io__conan-8046@ed667e6 | conan-io/conan | Python | 8,046 | [feat] Send HTTP GET header with settings when looking for a 'package_reference' | Changelog: Feature: Add headers with settings and options to HTTP GET requests when searching for packages.
Docs: Omit
closes https://github.com/conan-io/conan/issues/7870
Conan sends a request header `Conan-PkgID-Settings` when looking for a `pref` in the remotes:
* if using revisions, it is sent when looking... | 2020-11-11T16:43:49Z | [feature] Identify configuration in remote requests when querying for a packageID
When Conan checks if a package for a given configuration is available in a remote, it sends just the _package ID_. It would be very useful to send the information used to compute that hash:
* We can send _all_ the configuration: _packag... | I've been having a look at it and it can be very challenging to pass the information about the configuration to the place where the calls to the remote are being done. I would say we need first to store the actual configuration for a package (settings, options, requirements,...) in the `node` object to have it availabl... | [
{
"body": "When Conan checks if a package for a given configuration is available in a remote, it sends just the _package ID_. It would be very useful to send the information used to compute that hash:\r\n * We can send _all_ the configuration: _package ID_ computation is reproducible (needed? desired?)\r\n * We... | 201480146740d2ab298b9f360037ab9e56c2a6a5 | {
"head_commit": "ed667e69b58294867d192551418d8105065868c8",
"head_commit_message": "handle info variable with care",
"patch_to_review": "diff --git a/conans/client/conan_api.py b/conans/client/conan_api.py\nindex 798fbe3ef35..69da5ae8dad 100644\n--- a/conans/client/conan_api.py\n+++ b/conans/client/conan_api.py\... | [
{
"diff_hunk": "@@ -1133,7 +1133,8 @@ def get_path(self, reference, package_id=None, path=None, remote_name=None):\n if package_id:\n pref = PackageReference(ref, package_id)\n if self.app.config.revisions_enabled and not pref.revision:\n- pref = se... | b69a00bd5dc7fa6cd2ddfdcf25f09600081036b1 | diff --git a/conans/client/graph/graph_binaries.py b/conans/client/graph/graph_binaries.py
index 033067b313a..ee81dd4aab6 100644
--- a/conans/client/graph/graph_binaries.py
+++ b/conans/client/graph/graph_binaries.py
@@ -93,11 +93,14 @@ def _evaluate_cache_pkg(self, node, package_layout, pref, metadata, remote, remo
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
conan-io__conan-7919@b953ac1 | conan-io/conan | Python | 7,919 | [toolchain] CMake + Ninja | Changelog: Omit
Docs: omit
closes #7814
Testing CMakeToolchain with Ninja generator
CMake + Ninja only uses a specific Ninja var: [CMAKE_NINJA_OUTPUT_PATH_PREFIX](https://cmake.org/cmake/help/v3.7/variable/CMAKE_NINJA_OUTPUT_PATH_PREFIX.html), but it doesn't affect our jobs. It is used for extra ninja files dir... | 2020-10-21T19:14:54Z | [feature] CMakeToolchain + Ninja PoC
Implement a proof of concept of using the new CMakeToolchain feature for building with Ninja:
- From Linux
- From Windows
Notes:
- Ninja can be assumed installed.
- Opt-in to use Ninja instead of the default (MSBuild, Makefiles) build system, or hardcoded in the recipe, in... | I would like to take this one. | [
{
"body": "Implement a proof of concept of using the new CMakeToolchain feature for building with Ninja:\r\n\r\n- From Linux\r\n- From Windows\r\n\r\nNotes:\r\n- Ninja can be assumed installed. \r\n- Opt-in to use Ninja instead of the default (MSBuild, Makefiles) build system, or hardcoded in the recipe, invest... | 8c7bc12106a78ea59ab2d01fe40dbed78aade0e1 | {
"head_commit": "b953ac169ee17765b25bac40ac5ac9187e05ad4a",
"head_commit_message": "#7814 Add new integration test for cmake-ninja\n\nSigned-off-by: Uilian Ries <uilianries@gmail.com>",
"patch_to_review": "diff --git a/conans/test/integration/toolchains/cmake/__init__.py b/conans/test/integration/toolchains/cmak... | [
{
"diff_hunk": "@@ -0,0 +1,127 @@\n+import shutil\n+import textwrap\n+import unittest\n+import os\n+\n+from conans.test.utils.tools import TestClient\n+from conans.test.utils.test_files import temp_folder\n+from conans.client.tools import environment_append\n+\n+\n+class CppProject(object):\n+\n+ header = te... | d3b6e78bd9ba0bd1f023089346f1eb7b08eec25e | diff --git a/conans/test/integration/toolchains/cmake/__init__.py b/conans/test/integration/toolchains/cmake/__init__.py
new file mode 100644
index 00000000000..e69de29bb2d
diff --git a/conans/test/integration/toolchains/cmake/test_ninja.py b/conans/test/integration/toolchains/cmake/test_ninja.py
new file mode 100644
i... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
conan-io__conan-7941@10e7e82 | conan-io/conan | Python | 7,941 | Feature/toolchain msbuild cmd | Changelog: Feature: Provide a ``MSBuildCmd`` helper class that encapsulates calling MSBuild.
Docs: https://github.com/conan-io/docs/pull/1907
Close https://github.com/conan-io/conan/issues/7824
Close https://github.com/conan-io/conan/issues/7606 | 2020-10-26T13:12:11Z | [bug] MSBuild calls devenv by default, even if not available
### Environment Details
* Operating System+version: Windows Server 2019
* Compiler+version: Visual Studio 2017 Build Tools 15.9.2.0
* Conan version:
* Python version: 3.7.0
### Steps to reproduce
On a system with only Visual Studio build tool... | Hi @UnderSampled
I am not sure this is a bug, but instead by design. Conan tries to provide a consistent behavior. Running one thing or another different one based on the existence of a tool in the system is a bit fragile, and this is the reason the default behavior assumes that it exists and will error otherwise, ... | [
{
"body": "### Environment Details\r\n * Operating System+version: Windows Server 2019\r\n * Compiler+version: Visual Studio 2017 Build Tools 15.9.2.0\r\n * Conan version: \r\n * Python version: 3.7.0\r\n\r\n### Steps to reproduce\r\nOn a system with only Visual Studio build tools installed, run a Conan bui... | c7f674942e1fd3c67c316444558d1d9a475f61e2 | {
"head_commit": "10e7e8253ed97b845ec571857091e2817e69589b",
"head_commit_message": "Update conans/client/build/msbuild.py\n\nCo-authored-by: Javier G. Sogo <jgsogo@gmail.com>",
"patch_to_review": "diff --git a/conans/client/build/msbuild.py b/conans/client/build/msbuild.py\nindex 60ca59c0dc1..486ee5322e7 100644\... | [
{
"diff_hunk": "@@ -96,15 +96,16 @@\n <WholeProgramOptimization>true</WholeProgramOptimization>\n <CharacterSet>Unicode</CharacterSet>\n </PropertyGroup>\n+ <!-- Very IMPORTANT this should go BEFORE the Microsoft.Cpp.props -->",
"line": null,
"original_line": 99,
"original_start_line": nu... | 48a954b389a6f2a33e739d7d933b22f065b319cd | diff --git a/conans/client/build/msbuild.py b/conans/client/build/msbuild.py
index 60ca59c0dc1..486ee5322e7 100644
--- a/conans/client/build/msbuild.py
+++ b/conans/client/build/msbuild.py
@@ -5,6 +5,7 @@
from conans.client import tools
from conans.client.build.visual_environment import (VisualStudioBuildEnvironment,... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
conan-io__conan-7867@00ee154 | conan-io/conan | Python | 7,867 | fix cpp_info.names and cpp_info.filenames in the local flow | Changelog: Bugfix: Fix local flow (conan install + build) support for ``cpp_info.names`` and ``cpp_info.filenames``.
Docs: Omit
Close https://github.com/conan-io/conan/issues/7854
| 2020-10-12T22:03:42Z | [bug] deps_cpp_info.get_name returns different results with `create` and `build`
### Environment Details (include every applicable attribute)
* Operating System+version: CentOS 7
* Compiler+version: gcc 4.8.5
* Conan version: 1.30.0
* Python version: 3.6.8
### Steps to reproduce (Include if Applicable)
... | Thanks @mvoelkle-cern for reporting! Indeed a bug ( a missing thing for this new experimental feature)
I have submitted a fix in https://github.com/conan-io/conan/pull/7867 for next Conan 1.31 release. | [
{
"body": "### Environment Details (include every applicable attribute)\r\n * Operating System+version: CentOS 7\r\n * Compiler+version: gcc 4.8.5\r\n * Conan version: 1.30.0\r\n * Python version: 3.6.8\r\n\r\n### Steps to reproduce (Include if Applicable)\r\n\r\nThe following conanfile.py\r\n\r\n```\r\nimp... | 3609faaea4b56a1a3945978214eb571418762600 | {
"head_commit": "00ee154e742b4786bc4ad5096e0a6564701965ca",
"head_commit_message": "fix tests",
"patch_to_review": "diff --git a/conans/client/generators/text.py b/conans/client/generators/text.py\nindex 0e333a35114..f3bbeed4d7c 100644\n--- a/conans/client/generators/text.py\n+++ b/conans/client/generators/text.... | [
{
"diff_hunk": "@@ -164,7 +166,17 @@ def _populate_cpp_info(_cpp_info, _data, _rootpath):\n rootpath = no_config_data.pop('rootpath')[0]\n dep_cpp_info = CppInfo(dep, rootpath)\n dep_cpp_info.filter_empty = filter_empty\n- dep_cpp_info.names[TXTGene... | fb0b769c00659257654d59a231b0586574529413 | diff --git a/conans/client/generators/text.py b/conans/client/generators/text.py
index 0e333a35114..0fdcb07fb6f 100644
--- a/conans/client/generators/text.py
+++ b/conans/client/generators/text.py
@@ -43,6 +43,8 @@ def __init__(self, cpp_info):
self.version = cpp_info.version
self.name = cpp_info.get_... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
conan-io__conan-8353@b442e5a | conan-io/conan | Python | 8,353 | Fix: add preprocessor_definitions to Meson + CC/CXX from build requirements | Changelog: Fix: The new `MesonToolchain` now takes the declared environment variables (`CC`, `CXX`...) from build-requires and profiles to set the variables `c`, `cpp`, `c_ld`, `cpp_ld` etc, into the `conan_meson_native.ini`
Changelog: Fix: Added new `preprocessor_definitions` to new Meson build helper.
Changelog: F... | 2021-01-18T12:18:42Z | [bug] MesonToolchain does not pick up CC/CXX from build requirements (in build profile)
The compiler paths of a build requirement with a cross compiler that sets the CC/CXX environment variables
are not available in `conan_meson_cross.ini`.
I have a build requirement that sets some compiler variables:
```
def pac... | @jgsogo do you have an idea why could it happen? e.g. meson tests use CC from the conan profile, and it works flawlessly
Hi!
The environment from the build requires is populated before entering the `build()` method. The `MesonToolchain` takes all these values from the environment, but they are not available in the ... | [
{
"body": "The compiler paths of a build requirement with a cross compiler that sets the CC/CXX environment variables\r\nare not available in `conan_meson_cross.ini`.\r\n\r\nI have a build requirement that sets some compiler variables:\r\n```\r\ndef package_info(self):\r\n self.env_info.CC = os.path.join(sel... | 80f344c101f892a18104fa12fedc2feeb993fdd1 | {
"head_commit": "b442e5a8ea04e7d213f29bf981c63a32a10cad67",
"head_commit_message": "- fix env propagation\n\nSigned-off-by: SSE4 <tomskside@gmail.com>",
"patch_to_review": "diff --git a/conan/tools/meson/toolchain.py b/conan/tools/meson/toolchain.py\nindex 40c7bd8203a..0e0800d6fa6 100644\n--- a/conan/tools/meson... | [
{
"diff_hunk": "@@ -71,11 +71,13 @@ def env(self):\n cflags += \" -isysroot \" + self.xcrun.sdk_path\n cflags += \" -arch \" + to_apple_arch(self.arch)\n cxxflags = cflags\n+ ldflags = cflags",
"line": null,
"original_line": 74,
"original_start_line": null,
"path":... | 303bd4fb383cd7f7dcfbae3d44b162635a9c2183 | diff --git a/conan/tools/env/environment.py b/conan/tools/env/environment.py
index 76cd69d3825..c1021979eba 100644
--- a/conan/tools/env/environment.py
+++ b/conan/tools/env/environment.py
@@ -236,6 +236,12 @@ def _get_final_value(self, name):
def __getitem__(self, name):
return self._get_final_value(name... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
conan-io__conan-7840@920c2f3 | conan-io/conan | Python | 7,840 | Feature/6207 config single file | Changelog: Feature: Allow ``conan config install`` of a single file
Docs: https://github.com/conan-io/docs/pull/1908
Close https://github.com/conan-io/conan/issues/6207
* Add the possibility to specify a configuration for the command `conan config install`
* Copy only the configuration files in the directory, f... | 2020-10-07T11:59:31Z | [feature] conan config install a single file
When using `conan config install`, allow a single configuration file to be installed.
Normally, the command requires a git repository, a local folder, or a zip file that contains the file(s) to be installed. If I have a single file I want installed, I would have to put i... | Hi @kkaja123
I think this can make sense and shouldn't be very difficult to implement. The only thing is that our backlog is already totally full, so will label it accordingly and lets see if this feature gets contributed by the community. Thanks for the suggestion.
Hi,
I would like to contribute to this feature.
... | [
{
"body": "When using `conan config install`, allow a single configuration file to be installed. \r\n\r\nNormally, the command requires a git repository, a local folder, or a zip file that contains the file(s) to be installed. If I have a single file I want installed, I would have to put it into a folder or zip... | 013c1aea5f5f953fb6dc36f9cee38ce82c7be73a | {
"head_commit": "920c2f3458bd55b5ab14ceb8dd5b69b1859a34c0",
"head_commit_message": "chore(conf): Keep custom files install and specify compressed files\n\n* Keep custom files installation\n* Test if the uri is a compressed file and use decompression\n configuration function\n* Test if the uri is a regular file an... | [
{
"diff_hunk": "@@ -201,9 +207,12 @@ def _process_config(config, cache, output, requester):\n _process_git_repo(config, cache, output)\n elif config.type == \"dir\":\n _process_folder(config, config.uri, cache, output)\n- elif config.type == \"file\":\n+ elif config... | 10a598b6f95b9f50247f32da9a48478859c010da | diff --git a/conans/client/conf/config_installer.py b/conans/client/conf/config_installer.py
index 72ea8f0c7e7..51b709271e1 100644
--- a/conans/client/conf/config_installer.py
+++ b/conans/client/conf/config_installer.py
@@ -12,7 +12,7 @@
from conans.client import tools
from conans.client.cache.remote_registry import... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
conan-io__conan-7781@b2c84dd | conan-io/conan | Python | 7,781 | [bugfix] multiple remotes with single conan upload | Changelog: Bugfix: Fixed bug where uploading to multiple remotes in a single conan upload command would fail.
Docs: omit
Fixes #7780
This bug was due to closing and reusing a thread pool in a loop. Instead, a separate thread pool will be created at each loop iteration.
- [x] Refer to the issue that supports ... | 2020-09-30T22:26:13Z | [bug] Upload fails with multiple remotes in the same command
When uploading several packages at once (without specifying a remote) and some packages are uploaded to different remotes, the command will fail.
The bug appears to be due to reusing a closed thread pool in the loop in CmdUploader.upload() in uploader.py. ... | [
{
"body": "When uploading several packages at once (without specifying a remote) and some packages are uploaded to different remotes, the command will fail.\r\n\r\nThe bug appears to be due to reusing a closed thread pool in the loop in CmdUploader.upload() in uploader.py. Once thread pools are closed they can'... | f767fa175a7708ba82f5816362a43ece8ff8fb0a | {
"head_commit": "b2c84ddd6ffaf3b4d5aaf4cf3a4cd0470f4f651a",
"head_commit_message": "Fixed bug where uploading to multiple remotes in a single conan upload command would fail",
"patch_to_review": "diff --git a/conans/client/cmd/uploader.py b/conans/client/cmd/uploader.py\nindex f47631f397b..2e7e877f47f 100644\n--... | [
{
"diff_hunk": "@@ -201,12 +201,11 @@ def upload(self, reference_or_pattern, remotes, upload_recorder, package_id=None\n all_packages, query)\n \n if parallel_upload:\n- self._upload_thread_pool = ThreadPool(8)\n self._user_io.disable_inp... | d80fd6a0bf9a8b7f69c14185169720ec27a6122a | diff --git a/conans/client/cmd/uploader.py b/conans/client/cmd/uploader.py
index f47631f397b..24c662a91e8 100644
--- a/conans/client/cmd/uploader.py
+++ b/conans/client/cmd/uploader.py
@@ -21,6 +21,7 @@
gzopen_without_timestamps, set_dirty_context_manager)
from conans.util.log import lo... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
conan-io__conan-7763@bd556b9 | conan-io/conan | Python | 7,763 | Feature/lockfiles partial | Changelog: Fix: Removed check in lockfiles computed from other lockfile that it should be part of it. Users can check the resulting lockfile themselves if they want to.
Docs: https://github.com/conan-io/docs/pull/1868
Fix https://github.com/conan-io/conan/issues/7739 | 2020-09-28T14:17:57Z | [bug][question] Conan lockfile behavior change between conan 1.26 and conan 1.29.
We used conan.lock files from a CI build for a big set of comonents where all component versions were synchronized. Later developers used these lockfiles to build new versions of one of those components in the context of that lockfile lo... | Here ist the attachment:
[use_segment_build_lockfile_for_local_component_builds.py.gz](https://github.com/conan-io/conan/files/5262083/use_segment_build_lockfile_for_local_component_builds.py.gz)
Hi @fourbft
The lockfiles have become not more restrictive, but their checks more thorough and complete.
It is true,... | [
{
"body": "We used conan.lock files from a CI build for a big set of comonents where all component versions were synchronized. Later developers used these lockfiles to build new versions of one of those components in the context of that lockfile locally, so they were not affected by new versions of upstreams th... | 25419158ada66ee0119092ffbdc5067153d19272 | {
"head_commit": "bd556b94660c15dfc0afc8c143703fcf2871d5c7",
"head_commit_message": "removing overlap/contained check",
"patch_to_review": "diff --git a/conans/client/conan_api.py b/conans/client/conan_api.py\nindex ca387242949..e4ac5a514d1 100644\n--- a/conans/client/conan_api.py\n+++ b/conans/client/conan_api.p... | [
{
"diff_hunk": "@@ -254,3 +256,35 @@ def augment_test_package_requires(self):\n else:\n self.assertEqual(dep[\"ref\"], \"dep/0.1\")\n self.assertEqual(dep[\"prev\"], \"0\")\n+\n+ def partial_intermediate_package_lock_test(self):\n+ client = TestClient()\n+ client... | e41c4730196263d8f8113f96f191c0eaf984d705 | diff --git a/conans/client/conan_api.py b/conans/client/conan_api.py
index d9f2f89be4d..e5bf26fb67b 100644
--- a/conans/client/conan_api.py
+++ b/conans/client/conan_api.py
@@ -1321,6 +1321,7 @@ def lock_create(self, path, lockfile_out,
if path and reference:
raise ConanException("Both path and re... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
conan-io__conan-7577@c51a88b | conan-io/conan | Python | 7,577 | Handle unknown statement while parsing profile. Fixes #6931 | Changelog: Bugfix: Provide a more descriptive error when an unknown statement is added to a profile
Docs: omit
Closes: #6931
Tested with the example provided in the [examples repository](https://github.com/conan-io/examples/tree/master/features/emscripten)
I replaced the first line:
```
include(default)
``... | 2020-08-22T19:40:15Z | [feature] Confusing error message when typo in profile
I had a typo in my profile file:
```
includes(cmake_3_16)
[build_requires]
doxygen/1.8.15@company/stable
```
Where it should have been `include` instead of `includes`.
When running Conan, I got the following error message:
```
ERROR: Error reading... | Thanks for reporting it. I think it should be easy to identify this error and provide a better message. Thanks! | [
{
"body": "I had a typo in my profile file:\r\n\r\n```\r\nincludes(cmake_3_16)\r\n\r\n[build_requires]\r\ndoxygen/1.8.15@company/stable\r\n```\r\n\r\nWhere it should have been `include` instead of `includes`. \r\nWhen running Conan, I got the following error message:\r\n\r\n```\r\nERROR: Error reading 'document... | 47928cbcd3db1ff05798c5f36fc900412f9fa7c9 | {
"head_commit": "c51a88bc1d5306bb52affa189eb015c04faccfc3",
"head_commit_message": "Handle unknown statement while parsing profile. Fixes #6931",
"patch_to_review": "diff --git a/conans/client/profile_loader.py b/conans/client/profile_loader.py\nindex 431dbad2965..21c8193eb26 100644\n--- a/conans/client/profile_... | [
{
"diff_hunk": "@@ -38,7 +38,10 @@ def __init__(self, text):\n include = include[:-1]\n self.includes.append(include)\n else:\n- name, value = line.split(\"=\", 1)\n+ try:\n+ name, value = line.split(\"=\", 1)\n+ ... | 97ac4e5fc1e6a7709c4ec37ec100fb1f1ab941d5 | diff --git a/conans/client/profile_loader.py b/conans/client/profile_loader.py
index 431dbad2965..2b12567c777 100644
--- a/conans/client/profile_loader.py
+++ b/conans/client/profile_loader.py
@@ -38,7 +38,10 @@ def __init__(self, text):
include = include[:-1]
self.includes.append(incl... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "New Feature Additions"
} |
conan-io__conan-7855@4b53630 | conan-io/conan | Python | 7,855 | [poc] CMake + iOS | Changelog: Feature: Add POC on a toolchain for iOS (using CMake XCode generator).
Docs: https://github.com/conan-io/docs/pull/1906
Only working with XCode generator for the moment: https://cmake.org/cmake/help/v3.18/manual/cmake-toolchains.7.html#cross-compiling-for-ios-tvos-or-watchos
Close https://github.com/c... | 2020-10-09T10:49:22Z | [feature] CMakeToolchain + iOS projects PoC
Implement a proof of concept of using the new CMakeToolchain feature for building iOS projects
Notes:
- Toolchain can be assumed installed
- Focused on creating/building 1 package, both local flow (conan install + native cmake) and ``conan create`` flow.
- Integration t... | [
{
"body": "Implement a proof of concept of using the new CMakeToolchain feature for building iOS projects\r\n\r\nNotes:\r\n- Toolchain can be assumed installed\r\n- Focused on creating/building 1 package, both local flow (conan install + native cmake) and ``conan create`` flow.\r\n- Integration test.\r\n- Test ... | 0caff8eb3b284fdd8eca221d9863ef7bf90a5c9c | {
"head_commit": "4b536304f7ae4b45453189d182c02cc75c05d36c",
"head_commit_message": "minor changes",
"patch_to_review": "diff --git a/conans/client/toolchain/cmake/__init__.py b/conans/client/toolchain/cmake/__init__.py\nindex d9020743b4f..2e04e7cb575 100644\n--- a/conans/client/toolchain/cmake/__init__.py\n+++ b... | [
{
"diff_hunk": "@@ -0,0 +1,72 @@\n+import textwrap\n+\n+lib_h = textwrap.dedent(\"\"\"\n+ #pragma once\n+ #include <string>\n+ class HelloLib {\n+ public:\n+ void hello(const std::string& name);\n+ };\n+\"\"\")\n+\n+lib_cpp = textwrap.dedent(\"\"\"\n+ #include \"hello.h\"\n+ #include... | adda7bd4240d72dab91f8be62e4e8b5eaf819f13 | diff --git a/conans/client/toolchain/cmake/__init__.py b/conans/client/toolchain/cmake/__init__.py
index fb2dfdc0a27..9ca41c03a89 100644
--- a/conans/client/toolchain/cmake/__init__.py
+++ b/conans/client/toolchain/cmake/__init__.py
@@ -1,4 +1,5 @@
from .android import CMakeAndroidToolchain
+from .ios import CMakeiOST... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
conan-io__conan-7843@9559fdc | conan-io/conan | Python | 7,843 | [poc] CMake + Android | Changelog: Feature: Add POC on a toolchain for Android (using CMake provided modules).
Docs: https://github.com/conan-io/docs/pull/1902
Close #7809
There are two main different approaches to compile to Android using CMake, both of them should be equivalent:
* Using CMake provided toolchains: https://cmake.o... | 2020-10-07T16:50:48Z | [feature] CMakeToolchain + Android POC
Implement a proof of concept of using the new CMakeToolchain feature for building:
- Android projects (from Linux/OSX)
- From Windows
Notes:
- Android NDK can be assumed installed
- Focused on creating/building 1 package, both local flow (conan install + native cmake) and... | [
{
"body": "Implement a proof of concept of using the new CMakeToolchain feature for building:\r\n\r\n- Android projects (from Linux/OSX)\r\n- From Windows\r\n\r\nNotes:\r\n- Android NDK can be assumed installed\r\n- Focused on creating/building 1 package, both local flow (conan install + native cmake) and ``con... | d27ac1743facf2b29b0964c5cc47762411e6aab3 | {
"head_commit": "9559fdc392195345e189b5db419f73c3e0b62702",
"head_commit_message": "moving around vars",
"patch_to_review": "diff --git a/conans/client/build/cmake_toolchain_build_helper.py b/conans/client/build/cmake_toolchain_build_helper.py\nindex b1a19c98702..2df4208dff3 100644\n--- a/conans/client/build/cma... | [
{
"diff_hunk": "@@ -0,0 +1,16 @@\n+from conans.client.tools import cross_building\n+from .native import CMakeNativeToolchain\n+from .android import CMakeAndroidToolchain\n+\n+\n+def CMakeToolchain(conanfile, **kwargs):\n+ if not cross_building(conanfile):\n+ return CMakeNativeToolchain(conanfile=conan... | b08f4452c1e365d8179f678386384ceebd315aab | diff --git a/conans/client/toolchain/cmake/android.py b/conans/client/toolchain/cmake/android.py
index 2746e5290b2..4ca60416168 100644
--- a/conans/client/toolchain/cmake/android.py
+++ b/conans/client/toolchain/cmake/android.py
@@ -1,5 +1,93 @@
+import os
+import textwrap
+
+from conans.client.tools.files import which... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
conan-io__conan-7600@dde5092 | conan-io/conan | Python | 7,600 | Set cmake compile options based on language | Changelog: Fix: Set CMake targets compile options based on language
Docs: omit
#tags: slow
- [x] Refer to the issue that supports this Pull Request: closes #7499
- [x] If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
- [x] I've read the [Contributing guide](h... | 2020-08-26T14:03:01Z | [bug] Cmake targets glue C and CXX flags
<!--
Please don't forget to update the issue title.
Include all applicable information to help us reproduce your problem.
To help us debug your issue please explain:
-->
### Environment Details (include every applicable attribute)
* Operating System+version: Ub... | Hi @pgorgon-hem
Thanks for reporting this issue.
Just to understand the severity of the issue, what is the typical effect, just that warning, but the flag is safely ignored by the compilers? Does it fail in some scenarios?
This might need to be changed in other generators as well. As it seems this code section ... | [
{
"body": "<!--\r\n Please don't forget to update the issue title.\r\n Include all applicable information to help us reproduce your problem.\r\n\r\n To help us debug your issue please explain:\r\n-->\r\n\r\n### Environment Details (include every applicable attribute)\r\n * Operating System+version: Ubuntu 2... | 362e81ca1e4ef4d7b3aaca225c653a70e7c641ce | {
"head_commit": "dde5092810e731a0d3a7796b9e8d1ea3723bd464",
"head_commit_message": "fix cmake code and tests",
"patch_to_review": "diff --git a/conans/client/generators/cmake_common.py b/conans/client/generators/cmake_common.py\nindex 72c42d7f951..e95c6102b9b 100644\n--- a/conans/client/generators/cmake_common.p... | [
{
"diff_hunk": "@@ -486,14 +487,6 @@ def build(self):\n client.out)\n \n def cpp_info_filename_test(self):\n- def add_to_conan_file(after, add_lines, spaces_to_indent):",
"line": null,
"original_line": 489,
"original_start_line": null,
"path": "conans/test/functi... | 5ac94165d1d387a6d3744a7a7f7734198de7e684 | diff --git a/conans/client/generators/cmake_find_package.py b/conans/client/generators/cmake_find_package.py
index 4ba8b001d8a..800ecf5d527 100644
--- a/conans/client/generators/cmake_find_package.py
+++ b/conans/client/generators/cmake_find_package.py
@@ -97,7 +97,8 @@ class CMakeFindPackageGenerator(Generator):
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
conan-io__conan-7394@488d857 | conan-io/conan | Python | 7,394 | Fix Conan V2 cli broken help | Changelog: Fix: Fixing `--help` for commands in proposal for command line v2.0.
Docs: omit
Closes: #7366
- [X] Refer to the issue that supports this Pull Request.
- [X] If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
- [X] I've read the [Contributing guide](... | 2020-07-21T12:21:53Z | [bug] Conan V2 cli broken help
```bash
$ conan --help # broken
$ conan help # works
$ conan help search # broken
$ conan search --help # works
```
I am fine with removing the ``conan help`` approach (the --help is more standard).
I would also name the groups like ``Misc`` or ``Consumer``, and let the frame... | [
{
"body": "```bash\r\n$ conan --help # broken\r\n$ conan help # works\r\n$ conan help search # broken\r\n$ conan search --help # works\r\n```\r\n\r\nI am fine with removing the ``conan help`` approach (the --help is more standard). \r\n\r\nI would also name the groups like ``Misc`` or ``Consumer``, and let the... | 0c63663d731b6800336b1ce2c6fe26e19a9a375d | {
"head_commit": "488d8573275828929fccea2cd865359611201a8d",
"head_commit_message": "dont test --help",
"patch_to_review": "diff --git a/conans/cli/cli.py b/conans/cli/cli.py\nindex b9a79b56302..abe850714aa 100644\n--- a/conans/cli/cli.py\n+++ b/conans/cli/cli.py\n@@ -81,13 +81,15 @@ def __init__(self, conan_api)... | [
{
"diff_hunk": "@@ -34,7 +34,7 @@ def __init__(self, method, group, formatters=None):\n self._parser.add_argument('-o', '--output', default=default_output, choices=formatters_list,\n action=OnceArgument, help=self._output_help_message)\n \n- def run(self, con... | 7dd15fe43434e68cd10e675064871a9843dd138c | diff --git a/conans/cli/cli.py b/conans/cli/cli.py
index b9a79b56302..ff10f0d7869 100644
--- a/conans/cli/cli.py
+++ b/conans/cli/cli.py
@@ -81,13 +81,14 @@ def __init__(self, conan_api):
self._commands = {}
conan_commands_path = os.path.join(os.path.dirname(os.path.abspath(__file__)), "commands")
... | {
"difficulty": "low",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
conan-io__conan-7380@fd9532d | conan-io/conan | Python | 7,380 | fixing missing download of conan_sources.tgz for export_sources() method | Changelog: BugFix: Fix missing download of ``conan_sources.tgz`` created using ``export_sources()`` method.
Docs: Omit
Fix https://github.com/conan-io/conan/issues/7377 | 2020-07-17T19:09:32Z | [bug] conan install only considers exports_sources
### Environment Details (include every applicable attribute)
* Conan version: 1.26.0+
### Steps to reproduce (Include if Applicable)
Put a `dummy.txt` next to the following `conanfile.py` in some directory.
# conanfile.py
from conans import ConanFi... | Thanks very much for your complete report and detailed investigation. Indeed a bug that needs to be fixed.
You were just one ``if`` from a Pull Request, next time don't hesitate to submit it, we can help with the testing if necessary :)
I have contributed the fix in https://github.com/conan-io/conan/pull/7380, plan... | [
{
"body": "### Environment Details (include every applicable attribute)\r\n * Conan version: 1.26.0+\r\n\r\n### Steps to reproduce (Include if Applicable)\r\n\r\nPut a `dummy.txt` next to the following `conanfile.py` in some directory.\r\n\r\n # conanfile.py\r\n from conans import ConanFile\r\n from o... | f563439d18dacf4e7310c08c07386f95070eccfc | {
"head_commit": "fd9532dcfe67996d3226e1ee1987bc8829e1f6da",
"head_commit_message": "fire CI",
"patch_to_review": "diff --git a/conans/client/source.py b/conans/client/source.py\nindex ab4e3b5fd53..603d10e8c3d 100644\n--- a/conans/client/source.py\n+++ b/conans/client/source.py\n@@ -25,7 +25,7 @@ def complete_rec... | [
{
"diff_hunk": "@@ -209,3 +209,26 @@ def exports_sources(self):\n client.run(\"export . pkg/0.1@\", assert_error=True)\n self.assertIn(\"ERROR: conanfile 'exports_sources' shouldn't be a method, \"\n \"use 'export_sources()' instead\", client.out)\n+\n+ def test_exports_... | e54bc4fa2c1e67ce9ceee61cde6dc0908b17ea46 | diff --git a/conans/client/source.py b/conans/client/source.py
index ab4e3b5fd53..603d10e8c3d 100644
--- a/conans/client/source.py
+++ b/conans/client/source.py
@@ -25,7 +25,7 @@ def complete_recipe_sources(remote_manager, cache, conanfile, ref, remotes):
if os.path.exists(sources_folder):
return None
-... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
conan-io__conan-7338@c96b388 | conan-io/conan | Python | 7,338 | Do not fail with 'conan remove -r remote -p' if there are no packages in the remote | Changelog: Bugfix: Do not fail for `conan remove -r remote -p` when there are no packages in the remote.
Docs: omit
Check there are no packages before trying to remove the package folder in the server. It prevents a 404 error.
close https://github.com/conan-io/conan/issues/7332
#REVISIONS: 1 | 2020-07-10T15:28:00Z | [bug] conan remove fails when using -p without package id together with -r
When I do `conan remove -f -p -r <remote> <existing_reference>` with a reference for which there is only a recipe but no binary package on the remote Conan fails with the following error message:
```
ERROR: {
"errors" : [ {
"status" ... | It seems that the `-p` option without parameters is broken even when there is a binary package on the remote. I still get the same error.
It totally makes sense. Just to confirm, can you report the server you are using? Artifactory? Which version? Is there any special configuration like virtual repositories?
Thanks!... | [
{
"body": "When I do `conan remove -f -p -r <remote> <existing_reference>` with a reference for which there is only a recipe but no binary package on the remote Conan fails with the following error message:\r\n\r\n```\r\nERROR: {\r\n \"errors\" : [ {\r\n \"status\" : 404,\r\n \"message\" : \"Couldn't fin... | 1ed9b250706c24b222aafcb598fbffc7355f691c | {
"head_commit": "c96b388c82912f028e9f2a516854dd05311d52ff",
"head_commit_message": "if not conaninfo, search doesn't work",
"patch_to_review": "diff --git a/conans/client/rest/rest_client_v1.py b/conans/client/rest/rest_client_v1.py\nindex ad977f59994..5b4d5c9c6da 100644\n--- a/conans/client/rest/rest_client_v1.... | [
{
"diff_hunk": "@@ -246,13 +246,16 @@ def remove_packages(self, ref, package_ids=None):\n for ref in refs:\n assert ref.revision is not None, \"remove_packages needs RREV\"\n if not package_ids:\n- url = self.router.remove_all_packages(ref)\n- respon... | 270cbde8eaae18be2d048c2c309c0e860385787f | diff --git a/conans/client/rest/rest_client_v1.py b/conans/client/rest/rest_client_v1.py
index ad977f59994..96fdbd43c84 100644
--- a/conans/client/rest/rest_client_v1.py
+++ b/conans/client/rest/rest_client_v1.py
@@ -1,6 +1,7 @@
import os
import time
import traceback
+from collections import namedtuple
from six.m... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
conan-io__conan-7337@521baaa | conan-io/conan | Python | 7,337 | [feat] Recipes declare what they provide (and this can create a conflict) | Changelog: Feature: Add `provides` attribute to `ConanFile`: recipes can declare what they provide and Conan will fail if several recipes provide the same functionality (ODR violation).
Docs: https://github.com/conan-io/docs/pull/1786
If nothing is provided explicitly, the `provides` attribute takes one single valu... | 2020-07-10T11:11:02Z | [feature] Declare what a recipe 'provides'
Add a `provides` attribute to the ConanFile class, it will list other package names that define the same functionality. Some examples:
* `libjpeg`, `libjpeg-turbo`, `mozjpeg` are different implementations of the same functionality and break the ODR principle.
* deprecated... | debian documentation: https://www.debian.org/doc/debian-policy/ch-relationships.html#virtual-packages-provides
more cases:
- [LibreSSL](https://www.libressl.org/), [BoringSSL](https://boringssl.googlesource.com/boringssl/) and [OpenSSL](https://www.openssl.org/)
- [libav](https://libav.org/) and [ffmpeg](https://ffmp... | [
{
"body": "Add a `provides` attribute to the ConanFile class, it will list other package names that define the same functionality. Some examples:\r\n * `libjpeg`, `libjpeg-turbo`, `mozjpeg` are different implementations of the same functionality and break the ODR principle. \r\n * deprecated recipes like `cpp-t... | 693a458c2ff87e2182aa56f25e77743580363a74 | {
"head_commit": "521baaafa15a89e59f2c501f61c55a4392bbfeb2",
"head_commit_message": "textwrap.indent not available in py27",
"patch_to_review": "diff --git a/conans/client/graph/graph_manager.py b/conans/client/graph/graph_manager.py\nindex f880e0ea9ee..bbc8c83e759 100644\n--- a/conans/client/graph/graph_manager.... | [
{
"diff_hunk": "@@ -363,6 +369,28 @@ def _load_graph(self, root_node, check_updates, update, build_mode, remotes,\n \n return graph\n \n+ @staticmethod\n+ def _validate_graph_provides(deps_graph):\n+ # Check that two different nodes are not providing the same (ODR violation)\n+ for n... | 1859b38f7d27ecdd72ed88a7bcabce57e1c71b4f | diff --git a/conans/client/conanfile/configure.py b/conans/client/conanfile/configure.py
index 510a935a804..074e524177c 100644
--- a/conans/client/conanfile/configure.py
+++ b/conans/client/conanfile/configure.py
@@ -2,6 +2,7 @@
from conans.model.conan_file import get_env_context_manager
from conans.util.conan_v2_mod... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
conan-io__conan-7303@aafe4de | conan-io/conan | Python | 7,303 | implementing __contains__ for option in self.info.options | Changelog: Fix: Implement missing ``__contains__`` method, so checking ``if "myoption" in self.info.options`` is possible in ``package_id()``.
Docs: Omit
Fix https://github.com/conan-io/conan/issues/7299
| 2020-07-02T22:44:15Z | [bug] Infinite recursion when checking for an option in the package_id method
Thank you for all the great work in conan! I was working on a base class that would invoke `shared_library_package_id` conditionally if "shared" was in the options. (A try-catch would work for this case, but I was working through some ideas... | Thanks for the detailed report! I have provided the necessary ``__contains__`` method so this check is possible: https://github.com/conan-io/conan/pull/7303
In any case, I would also suggest to reconsider the check. It sounds unusual to do the logic based on the existence of an option and not its value. Which option... | [
{
"body": "Thank you for all the great work in conan! I was working on a base class that would invoke `shared_library_package_id` conditionally if \"shared\" was in the options. (A try-catch would work for this case, but I was working through some ideas.) I found that the `in` lookup was causing infinite sta... | 1ed9b250706c24b222aafcb598fbffc7355f691c | {
"head_commit": "aafe4decd4e6d317bed08e9e062cd653918b1918",
"head_commit_message": "fix tests",
"patch_to_review": "diff --git a/conans/model/info.py b/conans/model/info.py\nindex 59bfaf5b186..e1e0b6a2a6a 100644\n--- a/conans/model/info.py\n+++ b/conans/model/info.py\n@@ -617,10 +617,10 @@ def default_std_non_ma... | [
{
"diff_hunk": "@@ -33,37 +29,29 @@ def test(self):\n client.run(\"create . Pkg/0.1@user/testing -o Pkg:shared=2\")\n self.assertIn(\"Pkg/0.1@user/testing: BUILD SHARED: 2\", client.out)\n client.run(\"create . Pkg/0.1@user/testing -o shared=1\", assert_error=True)\n- self.assertI... | 9b4b513d562fc3e437c70a6f589e87f8592885c7 | diff --git a/conans/model/info.py b/conans/model/info.py
index 59bfaf5b186..e1e0b6a2a6a 100644
--- a/conans/model/info.py
+++ b/conans/model/info.py
@@ -617,10 +617,10 @@ def default_std_non_matching(self):
self.settings.compiler.cppstd = self.full_settings.compiler.cppstd
def shared_library_package... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
conan-io__conan-7183@5431589 | conan-io/conan | Python | 7,183 | Required Conan version | The general configuration `required_conan_version` validates the current Conan client version to the required version.
If the current version is out of the range, a warning message
is displayed before executing any command.
Changelog: Feature: Configuration for checking the required Conan client version.
Docs: ... | 2020-06-10T21:58:25Z | [feature] Min (max) conan version checks from conan.conf
Companies would like to introduce a check to guarantee that everyone is using the same version of conan. That should be an easy check with a config in conan.conf.
Possibilities?:
- A min-version check
- A max-version check
- An exact version check
- A ra... | [
{
"body": "Companies would like to introduce a check to guarantee that everyone is using the same version of conan. That should be an easy check with a config in conan.conf.\r\n\r\nPossibilities?:\r\n\r\n- A min-version check\r\n- A max-version check\r\n- An exact version check\r\n- A range\r\n\r\n\r\nThe modes... | 741f3d60a1e955c7294a9f2a00a0d670a0b0d4f0 | {
"head_commit": "5431589a45312d30720395dc9d61285affaf1060",
"head_commit_message": "#7136 Remove env vars\n\nSigned-off-by: Uilian Ries <uilianries@gmail.com>",
"patch_to_review": "diff --git a/conans/client/conan_api.py b/conans/client/conan_api.py\nindex b75a3eb299c..72c21aa74cb 100644\n--- a/conans/client/con... | [
{
"diff_hunk": "@@ -0,0 +1,48 @@\n+import unittest\n+import mock\n+from conans.test.utils.tools import TestClient\n+from conans.errors import ConanException\n+\n+\n+class RequiredVersionTest(unittest.TestCase):\n+\n+ @mock.patch(\"conans.client.conf.required_version.client_version\", \"1.26.0\")\n+ def te... | b5f3ff0f111e5bb646eed53b0da97a405f214705 | diff --git a/conans/client/conan_api.py b/conans/client/conan_api.py
index b75a3eb299c..72c21aa74cb 100644
--- a/conans/client/conan_api.py
+++ b/conans/client/conan_api.py
@@ -20,6 +20,7 @@
from conans.client.cmd.uploader import CmdUpload
from conans.client.cmd.user import user_set, users_clean, users_list, token_pr... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
conan-io__conan-6475@2febb60 | conan-io/conan | Python | 6,475 | fixing mixing apis for download cache | Changelog: Fix: Avoid caching revision "0" under api V2 (revisions enabled) in the download cache.
Docs: https://github.com/conan-io/docs/pull/1552
Fix https://github.com/conan-io/conan/issues/6467
| 2020-02-05T22:03:58Z | [bug] Download cache should handle v1 and v2 clients simultaneously
Download cache uses URLs for caching things in api V2, which works well for revisioned things, because the revision is a hash. But this fails if clients using v1 keep re-uploading the revision "0", which shouldn't be cached.
To do:
- Implement ret... | What do you mean with...?
> Implement return of checksums in Api V2
```python
class RestV2Methods(RestCommonMethods):
def _get_file_list_json(self, url):
data = self.get_json(url)
# Discarding (.keys()) still empty metadata for files
data["files"] = list(data["files"].keys())
... | [
{
"body": "Download cache uses URLs for caching things in api V2, which works well for revisioned things, because the revision is a hash. But this fails if clients using v1 keep re-uploading the revision \"0\", which shouldn't be cached. \r\nTo do:\r\n\r\n- Implement return of checksums in Api V2 (@jgsogo). The... | 2782e27c89d8c32550fe1fdf640c2cf9b38fe91f | {
"head_commit": "2febb60e969496d5a7a0d4e3a285f861d51a0028",
"head_commit_message": "removed defaults",
"patch_to_review": "diff --git a/conans/client/rest/rest_client_v2.py b/conans/client/rest/rest_client_v2.py\nindex 99dc9db1ffe..0cc5b4929c8 100644\n--- a/conans/client/rest/rest_client_v2.py\n+++ b/conans/clie... | [
{
"diff_hunk": "@@ -58,12 +58,14 @@ def get_recipe_manifest(self, ref):\n if not ref.revision:\n ref = self.get_latest_recipe_revision(ref)\n url = self.router.recipe_manifest(ref)\n- content = self._get_remote_file_contents(url)\n+ cache = (ref.revision != \"0\")",
... | c31cf9aa6fbb47a4c65f44112b48129803316bea | diff --git a/conans/client/rest/rest_client_v2.py b/conans/client/rest/rest_client_v2.py
index 99dc9db1ffe..98bfc157c2f 100644
--- a/conans/client/rest/rest_client_v2.py
+++ b/conans/client/rest/rest_client_v2.py
@@ -2,6 +2,7 @@
import time
import traceback
+from conans import DEFAULT_REVISION_V1
from conans.clien... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
conan-io__conan-6947@b057db2 | conan-io/conan | Python | 6,947 | fix package_id computation for mixed modes | Changelog: Bugfix: Prevent crash when mixing package_id modes for the same dependency.
Docs: Omit
Close https://github.com/conan-io/conan/issues/6942
| 2020-05-03T12:58:58Z | [bug] unable to build packages with package_revision_mode enabled.
Conan crashing after enabled package_revision_mode and tried to rebuild all of our projects.
stacktrace attached.
### Environment Details (include every applicable attribute)
* Operating System+version: rh7
* Compiler+version: gcc8
* Conan ... | Checking the trace, I cannot see how a None gets there. Please keep us tuned if you can reproduce, and if not, I will try to provide a branch with some traces so you can run in your environment.
@memsharded its 100% reproducible for me, i just have to wait for full build ( we only upload at the end of the build ) so it... | [
{
"body": "Conan crashing after enabled package_revision_mode and tried to rebuild all of our projects.\r\nstacktrace attached.\r\n\r\n### Environment Details (include every applicable attribute)\r\n * Operating System+version: rh7\r\n * Compiler+version: gcc8\r\n * Conan version: 1.24.0\r\n * Python versio... | e498cefbc8e89308d2f0570707d51a3405401368 | {
"head_commit": "b057db2d6cafafce62c13d16f3fee38f32e2d2f2",
"head_commit_message": "more fixes",
"patch_to_review": "diff --git a/conans/client/build/build.py b/conans/client/build/build.py\nindex 85311e9e174..df8422dbdae 100644\n--- a/conans/client/build/build.py\n+++ b/conans/client/build/build.py\n@@ -9,7 +9,... | [
{
"diff_hunk": "@@ -404,6 +406,8 @@ def _build(self, nodes_by_level, keep_build, root_node, graph_info, remotes, bui\n self._binaries_analyzer.reevaluate_node(node, remotes, build_mode, update)\n _handle_system_requirements(conan_file, node.pref, self._cache, output)\... | 898311ff00be6e1e79df7fb06111a752a3f2a262 | diff --git a/conans/client/build/build.py b/conans/client/build/build.py
index 85311e9e174..df8422dbdae 100644
--- a/conans/client/build/build.py
+++ b/conans/client/build/build.py
@@ -9,7 +9,8 @@
def run_build_method(conanfile, hook_manager, **hook_kwargs):
hook_manager.execute("pre_build", conanfile=conanfile, ... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
conan-io__conan-7051@2851c1f | conan-io/conan | Python | 7,051 | try to fix package_id with package_revision_mode and mixed modes | Changelog: Bugfix: Fix crash while computing the ``package_id`` of a package when different ``package_id_mode`` are mixed and include ``package_revision_mode``.
Docs: Omit
Continuation of https://github.com/conan-io/conan/pull/6947
Fix #6942
#tags: slow
cc/ @fulara | 2020-05-19T14:43:12Z | [bug] unable to build packages with package_revision_mode enabled.
Conan crashing after enabled package_revision_mode and tried to rebuild all of our projects.
stacktrace attached.
### Environment Details (include every applicable attribute)
* Operating System+version: rh7
* Compiler+version: gcc8
* Conan ... | Checking the trace, I cannot see how a None gets there. Please keep us tuned if you can reproduce, and if not, I will try to provide a branch with some traces so you can run in your environment.
@memsharded its 100% reproducible for me, i just have to wait for full build ( we only upload at the end of the build ) so it... | [
{
"body": "Conan crashing after enabled package_revision_mode and tried to rebuild all of our projects.\r\nstacktrace attached.\r\n\r\n### Environment Details (include every applicable attribute)\r\n * Operating System+version: rh7\r\n * Compiler+version: gcc8\r\n * Conan version: 1.24.0\r\n * Python versio... | 56d1bbd05546733dcb927354dad742043a8219f7 | {
"head_commit": "2851c1f91e2204abbd63aca63179de503f748abc",
"head_commit_message": "moved inside propagate_info()",
"patch_to_review": "diff --git a/conans/client/graph/graph.py b/conans/client/graph/graph.py\nindex f4f8ccaf391..9e2afdfb46c 100644\n--- a/conans/client/graph/graph.py\n+++ b/conans/client/graph/gr... | [
{
"diff_hunk": "@@ -507,7 +508,13 @@ def _build_package(self, node, output, keep_build, remotes):\n return pref\n \n @staticmethod\n- def _propagate_info(node, using_build_profile):\n+ def _propagate_info(node, using_build_profile, fixed_package_id):\n+ if fixed_package_id:\n+ ... | ff5d8bba17f83ae12258de9f9ca1807785342147 | diff --git a/conans/client/graph/graph.py b/conans/client/graph/graph.py
index f4f8ccaf391..1308eb963ec 100644
--- a/conans/client/graph/graph.py
+++ b/conans/client/graph/graph.py
@@ -86,6 +86,8 @@ def __init__(self, ref, conanfile, context, recipe=None, path=None):
self._ancestors = _NodeOrderedDict() # set... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
conan-io__conan-6451@a17f880 | conan-io/conan | Python | 6,451 | explore if this fix header-only package-id | Changelog: Feature: Implement a new package-ID computation that includes transitive dependencies even when the direct dependencies have remove them, for example when depending on a header-only library that depends on a static library.
Docs: https://github.com/conan-io/docs/pull/1575
Close https://github.com/conan... | 2020-01-31T00:18:22Z | [bug] conan is too lenient in its specification of header_only libraries.
~~Note: title seems to indicate that this affects only header_only but thats not the case.~~
To make matters clear I am using:
`default_package_id_mode = full_version_mode` for this example.
Consider four projects:
```
#liba:
class Cona... | [
{
"body": "~~Note: title seems to indicate that this affects only header_only but thats not the case.~~\r\n\r\nTo make matters clear I am using:\r\n`default_package_id_mode = full_version_mode` for this example.\r\n\r\nConsider four projects:\r\n```\r\n#liba:\r\nclass Conan(ConanFile):\r\n name = \"liba\"\r\... | bd5920a40d9707001b31966adb0dfa7d6af00eea | {
"head_commit": "a17f8807a4dd53ab20c37420d7fc98a3103051da",
"head_commit_message": "explore if this fix header-only package-id",
"patch_to_review": "diff --git a/conans/client/graph/graph_binaries.py b/conans/client/graph/graph_binaries.py\nindex f87d9115a17..06a1dbea58c 100644\n--- a/conans/client/graph/graph_b... | [
{
"diff_hunk": "@@ -274,15 +274,15 @@ def _compute_package_id(node, default_package_id_mode, default_python_requires_i\n # A bit risky to be done now\n conanfile = node.conanfile\n neighbors = node.neighbors()\n- direct_reqs = [] # of PackageReference\n- indirect_reqs = se... | 786d91aea43a3ffe629694e45cfc28609fee6e16 | diff --git a/conans/client/conf/__init__.py b/conans/client/conf/__init__.py
index d4f97b6aaf6..03343800190 100644
--- a/conans/client/conf/__init__.py
+++ b/conans/client/conf/__init__.py
@@ -431,6 +431,14 @@ def default_python_requires_id_mode(self):
return "minor_mode"
return default_package_id... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} | |
conan-io__conan-7167@b4fccf6 | conan-io/conan | Python | 7,167 | Improve '--update' docstring | Changelog: Feature: More detailed description for `--update` argument.
Docs: https://github.com/conan-io/docs/pull/1778
This flag appears in many commands: `test`, `create`, `install`, `info`, `workspace`, `graph lock`
close https://github.com/conan-io/conan/issues/7146 | 2020-06-09T08:18:40Z | Improve docs for '--update' argument in commands
I got the following problem:
In my project, I normally build my packages with `conan create`.
Now I wanted to use `conan graph lock` to pickup up a previous build from Artifactory.
Now there is a different behavior between both commands.
I use semver versioning an... | Having a look at this issue, I've created a repo here (https://github.com/jgsogo/issue-7146) to reproduce the scenario with a minimal recipes.
First of all, as it is described, I get an error:
```bash
⇒ conan create projA.py
...
ERROR: Version range '^1.3.0-dev' required by 'LibB/1.0@demo/testing' not valid f... | [
{
"body": "I got the following problem:\r\nIn my project, I normally build my packages with `conan create`.\r\nNow I wanted to use `conan graph lock` to pickup up a previous build from Artifactory.\r\n\r\nNow there is a different behavior between both commands.\r\nI use semver versioning and also the `include_p... | b6223181588b2abbaa549819b6536ed70fe02756 | {
"head_commit": "b4fccf698c5de3ac1ed60689a9534c3ed78bd2cf",
"head_commit_message": "update --update docstring",
"patch_to_review": "diff --git a/conans/client/command.py b/conans/client/command.py\nindex c055e641936..0d60de6de8e 100644\n--- a/conans/client/command.py\n+++ b/conans/client/command.py\n@@ -2080,7 +... | [
{
"diff_hunk": "@@ -2080,7 +2080,9 @@ def _add_common_install_arguments(parser, build_help, lockfile=True):\n parser.add_argument(\"-r\", \"--remote\", action=OnceArgument,\n help='Look in the specified remote server')\n parser.add_argument(\"-u\", \"--update\", action='store_tru... | a34d4873db618a405564cce3ca66496833c8cf69 | diff --git a/conans/client/command.py b/conans/client/command.py
index c7929f2e873..428bd6d4246 100644
--- a/conans/client/command.py
+++ b/conans/client/command.py
@@ -661,7 +661,10 @@ def info(self, *args):
build_help = ("Given a build policy, return an ordered list of packages that would be built"
... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "Documentation Updates"
} |
conan-io__conan-6138@62ae836 | conan-io/conan | Python | 6,138 | Fix several issues with download command and revisions | Changelog: Bugfix: Fix different problems when using `conan download` with revisions.
Docs: Omit
This PR fixes the following problems when using revisions with `conan download` command:
- If you had revisions disabled and added a revision to download command it did not fail but even create the revision in the c... | 2019-11-27T10:53:52Z | [bug] conan download pkg/version@user/channel#randomrev downloads latest
Latest 1.20, Windows 10, python 3.7
With revisions disable this doesn't fail (it should). And worse, it creates an entry with revision ``randomrev`` in the cache.
Also, it seems that it is not possible to ``conan download`` a package with a ... | It is important to follow up here, this could be problematic or show underlying problems, for example if using lockfiles, like the locked version is not the one being retrieved. | [
{
"body": "Latest 1.20, Windows 10, python 3.7\r\n\r\nWith revisions disable this doesn't fail (it should). And worse, it creates an entry with revision ``randomrev`` in the cache.\r\n\r\nAlso, it seems that it is not possible to ``conan download`` a package with a given package revision.",
"number": 6106,
... | d42ec055d459489c184b160cafbd3f200ceb6d41 | {
"head_commit": "62ae836c07efeaf0f0b126d1baee6309cf58bceb",
"head_commit_message": "add test without user channel",
"patch_to_review": "diff --git a/conans/client/command.py b/conans/client/command.py\nindex e0cc756b3cf..687a1307f62 100644\n--- a/conans/client/command.py\n+++ b/conans/client/command.py\n@@ -403,... | [
{
"diff_hunk": "@@ -220,3 +220,57 @@ def no_user_channel_test(self):\n client.run(\"download pkg/1.0@\")\n self.assertIn(\"pkg/1.0: Downloading pkg/1.0:%s\" % NO_SETTINGS_PACKAGE_ID, client.out)\n self.assertIn(\"pkg/1.0: Package installed %s\" % NO_SETTINGS_PACKAGE_ID, client.out)\n+\n+... | 187d395a601d4c9969306cc19f67c1d170c13d15 | diff --git a/conans/client/command.py b/conans/client/command.py
index e0cc756b3cf..fd13ef6552c 100644
--- a/conans/client/command.py
+++ b/conans/client/command.py
@@ -403,8 +403,12 @@ def download(self, *args):
else:
reference = repr(pref.ref)
if pref.ref.user is None:
- ... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
conan-io__conan-6251@b5a8a7c | conan-io/conan | Python | 6,251 | add unknown package-ID in build-order | Changelog: Bugfix: Include "Package ID Unknown" nodes in ``conan graph build-order``, as they need to be processed in that order.
Docs: Omit
Close #6232 | 2019-12-18T00:17:44Z | [bug] Wrong conan graph build-order in package_revision_mode
### Environment Details
* Operating System: Red Hat Enterprise Linux 7.4
* Compiler: GCC 4.8.5
* Conan version: 1.21.0
* Python version: 3.7.1
### Steps to reproduce
Assumptions:
- Cache is clean; no binary packages exist so the expectation i... | Hi @radonish
Sorry for the delay in responding this.
I have been having a look at this, first a quick tip: at the moment you should also use ``conan graph lock appX --build=missing`` in the command ``graph lock`` too. Otherwise the lock might not work as expected.
Then, the behavior is correct. It is doing exac... | [
{
"body": "### Environment Details\r\n * Operating System: Red Hat Enterprise Linux 7.4\r\n * Compiler: GCC 4.8.5\r\n * Conan version: 1.21.0\r\n * Python version: 3.7.1\r\n\r\n### Steps to reproduce\r\nAssumptions:\r\n- Cache is clean; no binary packages exist so the expectation is a full build on the CI s... | 69bd779799f02797431b9f2c2acf2bccbae182bf | {
"head_commit": "b5a8a7ce0c7f0d21728b642510f490a0a5383e4e",
"head_commit_message": "add unknown in build-order",
"patch_to_review": "diff --git a/conans/client/graph/graph.py b/conans/client/graph/graph.py\nindex ce1da041a31..92593502ca9 100644\n--- a/conans/client/graph/graph.py\n+++ b/conans/client/graph/graph... | [
{
"diff_hunk": "@@ -619,6 +619,39 @@ def consumer_build_order_test(self):\n client.run(\"graph build-order conan.lock --build=missing\")\n self.assertIn(\"test4/0.1\", client.out)\n \n+ def package_revision_mode_build_order_test(self):\n+ # https://github.com/conan-io/conan/issues/6232... | 71b319cbec1c68ae826cf9688b83da694da8d857 | diff --git a/conans/client/graph/graph.py b/conans/client/graph/graph.py
index ce1da041a31..92593502ca9 100644
--- a/conans/client/graph/graph.py
+++ b/conans/client/graph/graph.py
@@ -276,7 +276,7 @@ def new_build_order(self):
for level in reversed(levels):
new_level = []
for n in le... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
conan-io__conan-6059@34153bc | conan-io/conan | Python | 6,059 | Fixes #6044 Improve error with malformed settings yml | Changelog: Fix: Raise a meaningful error when the `settings.yml` file is invalid
Docs: omit
Fixes #6044
| 2019-11-12T08:50:13Z | [ux] [bug] Improve error raised when 'settings.yml' cannot be parsed
If the file `settings.yml` is invalid, Conan raises an ugly error with all the traceback.
---
How to reproduce:
* Edit `settings.yml` and make it an invalid YAML
* Run something like `conan create ....`:
```
⇒ conan create dep1
Traceb... | I'll take a look. | [
{
"body": "If the file `settings.yml` is invalid, Conan raises an ugly error with all the traceback.\r\n\r\n---\r\n\r\nHow to reproduce:\r\n * Edit `settings.yml` and make it an invalid YAML\r\n * Run something like `conan create ....`:\r\n\r\n```\r\n⇒ conan create dep1 \r\nTraceback (most recent call last):\r... | c7d09b6148edac5b55c564160406c2268bbb6d7b | {
"head_commit": "34153bcd641230c0db8cd7b0ef9f9808851b8a02",
"head_commit_message": "Fixes #6044 Improve error raised when 'settings.yml' cannot be parsed",
"patch_to_review": "diff --git a/conans/model/settings.py b/conans/model/settings.py\nindex 2815d96635d..0835d7a8381 100644\n--- a/conans/model/settings.py\n... | [
{
"diff_hunk": "@@ -233,7 +233,10 @@ def copy_values(self):\n \n @staticmethod\n def loads(text):\n- return Settings(yaml.safe_load(text) or {})\n+ try:\n+ return Settings(yaml.safe_load(text) or {})\n+ except yaml.YAMLError as ye:\n+ raise ConanException(\"set... | 1e9f50e18d91fd322380874a569c798fac7eab94 | diff --git a/conans/model/settings.py b/conans/model/settings.py
index 2815d96635d..6b907572785 100644
--- a/conans/model/settings.py
+++ b/conans/model/settings.py
@@ -233,7 +233,10 @@ def copy_values(self):
@staticmethod
def loads(text):
- return Settings(yaml.safe_load(text) or {})
+ try:
+... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
conan-io__conan-5613@4b64731 | conan-io/conan | Python | 5,613 | #5572 Retrieve Conan home directory | - Add `config home` command to retrieve Conan home dir
- Add functional tests to validate `config home`
Changelog: Feature: New `conan config home` command for getting Conan home directory
Docs: https://github.com/conan-io/docs/pull/1387
closes https://github.com/conan-io/conan/issues/5572
- [x] Refer to the... | 2019-08-12T18:56:29Z | Add a command to retrieve the Conan home directory
A command to know where the `conan.conf` is (we call it Conan home) which is evaluated using the `CONAN_USER_HOME` env variable or defaulted to `~/.conan` would be useful.
Proposals:
* `conan config home`
* `conan home`
* `...` | Amazing, I would say this feature is relevant, for many times I saw users asking it on Slack, "where is conan home directory?".
When someone wants to know where is Conan home dir you need to guess: look for env vars CONAN_USER_HOME and CONAN_USER_HOME_SHORT, or try ~/.conan or %USERPROFILE%/.conan
I would suggest... | [
{
"body": "A command to know where the `conan.conf` is (we call it Conan home) which is evaluated using the `CONAN_USER_HOME` env variable or defaulted to `~/.conan` would be useful.\r\n\r\nProposals:\r\n * `conan config home`\r\n * `conan home`\r\n * `...`",
"number": 5572,
"title": "Add a command to r... | 2dfadb17a66218226a5ace24d15267b0a3f3bee9 | {
"head_commit": "4b64731e34a0ff4e2ac20275bc555a93f1217a65",
"head_commit_message": "#5572 Retrieve Conan home directory\n\n- Add `config home` command to retrieve Conan home dir\n- Add functional tests to validate `config home`\n\nSigned-off-by: Uilian Ries <uilianries@gmail.com>",
"patch_to_review": "diff --git... | [
{
"diff_hunk": "@@ -601,6 +601,11 @@ def config_install(self, path_or_url, verify_ssl, config_type=None, args=None,\n args=args,\n source_folder=source_folder, target_folder=target_folder)\n \n+ @api_method\n+ def config_home(self):... | d5a177fa8cd47c2e51eeb52eb0edcef787e30926 | diff --git a/conans/client/command.py b/conans/client/command.py
index 0892380a71d..988c740ce74 100644
--- a/conans/client/command.py
+++ b/conans/client/command.py
@@ -508,11 +508,13 @@ def config(self, *args):
subparsers = parser.add_subparsers(dest='subcommand', help='sub-command help')
subparsers.... | {
"difficulty": "low",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
conan-io__conan-5841@7f548b6 | conan-io/conan | Python | 5,841 | Issue/5814 fix python_requires with short_paths enabled | Changelog: Bugfix: Use imported python requires' `short_path` value instead of the defined in the `conanfile` that imports it.
Docs: omit
Closes #5814
- [X] Refer to the issue that supports this Pull Request.
- [X] If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Requ... | 2019-09-30T14:58:39Z | Use of python_requires with enabled short_paths fails
In Windows conan fails when a recipe uses `python_requires` and `short_paths = True` at the same time.
To reproduce the issue, it's enough to just add `short_paths = True` into the consumer conanfile of the `python_requires` example.
Conan will end with
```
... | Hi @kdsx,
I was able to reproduce the issue when using `export_sources` in the `python_requires`
While we have a look at it, did you try to set the `short_paths = True` in the python requires as well?
Thanks a lot for the feedback
Hi @czoido,
I've already tried it. Unfortunately with no effect. Conan fails with t... | [
{
"body": "In Windows conan fails when a recipe uses `python_requires` and `short_paths = True` at the same time.\r\n\r\nTo reproduce the issue, it's enough to just add `short_paths = True` into the consumer conanfile of the `python_requires` example.\r\n\r\nConan will end with\r\n```\r\nERROR: Error while tryi... | b2cbb3f2bf65fdf3ccdf6cad1ea93eee80415bc7 | {
"head_commit": "7f548b617c4b25736a33529a6b49e607fc06dca7",
"head_commit_message": "remove line",
"patch_to_review": "diff --git a/conans/client/installer.py b/conans/client/installer.py\nindex 1bd24f6aab7..dac9c92a717 100644\n--- a/conans/client/installer.py\n+++ b/conans/client/installer.py\n@@ -427,7 +427,7 @... | [
{
"diff_hunk": "@@ -576,6 +576,36 @@ class Lib(ConanFile):\n self.assertIn(\"Same python_requires with different versions not allowed for a conanfile\",\n t.out)\n \n+ def short_paths_test(self):\n+ # https://github.com/conan-io/conan/issues/5814\n+ client = TestCl... | 4a6069e608b0e9879db7ea51aac1a9b8525aca58 | diff --git a/conans/client/installer.py b/conans/client/installer.py
index 1bd24f6aab7..dac9c92a717 100644
--- a/conans/client/installer.py
+++ b/conans/client/installer.py
@@ -427,7 +427,7 @@ def _build_package(self, node, output, keep_build, remotes):
assert python_require.ref.revision is not None, \
... | {
"difficulty": "medium",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
conan-io__conan-6052@ca23055 | conan-io/conan | Python | 6,052 | Intel compiler POC using compatible ids feature | Changelog: Feature: Support for Intel compiler.
Docs: https://github.com/conan-io/docs/pull/1479
**This branch is the original @danimtb one but updated and conflict resolved**
- Refactor of compatible packages, (can be extracted to a different PR if needed) I've completely broken the previous experimental approa... | 2019-11-11T08:16:32Z | Add intel compiler to default settings.yml
Suggested:
```
intel:
version: ["17.0.0", "17.0.1", "17.0.2", "17.0.3", "17.0.4", "17.0.5", "17.0.6", "17.0.7", "17.0.8",
"18.0.0", "18.0.1", "18.0.2", "18.0.3", "18.0.4",
"19.0.0", "19.0.1", "19.0.2", "19.0.3"]
libcx... | Seems the Intel C++ compiler is compatible with both GCC and Visual Studio with some considerations:
- GCC support is declared to be compatible with "most versions" https://software.intel.com/en-us/cpp-compiler-developer-guide-and-reference-gcc-compatibility-and-interoperability without any other major consideration... | [
{
"body": "Suggested:\r\n\r\n```\r\nintel:\r\n version: [\"17.0.0\", \"17.0.1\", \"17.0.2\", \"17.0.3\", \"17.0.4\", \"17.0.5\", \"17.0.6\", \"17.0.7\", \"17.0.8\",\r\n \"18.0.0\", \"18.0.1\", \"18.0.2\", \"18.0.3\", \"18.0.4\",\r\n \"19.0.0\", \"19.0.1\", \"19.0.2\", \"... | 9e348424d85fa22b41c93cec4b0a113f25fef24d | {
"head_commit": "ca230557717708529c096f84f8ce894d491cd7c0",
"head_commit_message": "Fix py2",
"patch_to_review": "diff --git a/conans/__init__.py b/conans/__init__.py\nindex 8bd5cbf3a7b..7f0450385be 100644\n--- a/conans/__init__.py\n+++ b/conans/__init__.py\n@@ -9,7 +9,6 @@\n from conans.model.conan_file import ... | [
{
"diff_hunk": "@@ -481,4 +486,30 @@ def shared_library_package_id(self):\n for dep_name in self.requires.pkg_names:\n dep_options = self.full_options[dep_name]\n if \"shared\" not in dep_options or not self.full_options[dep_name].shared:\n- self.re... | 3a1a7aed9282e09fd93fb47724d0ece693287d28 | diff --git a/conans/__init__.py b/conans/__init__.py
index 8bd5cbf3a7b..7f0450385be 100644
--- a/conans/__init__.py
+++ b/conans/__init__.py
@@ -9,7 +9,6 @@
from conans.model.conan_file import ConanFile
from conans.model.options import Options
from conans.model.settings import Settings
-from conans.model.compatible_... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
conan-io__conan-5623@48e2b17 | conan-io/conan | Python | 5,623 | Disabling/enabling remotes: Issue/5544 | Changelog: Feature: Add subcommand for enabling and disabling remotes
Docs: https://github.com/conan-io/docs/pull/1392
This PR provides the option to enable or disable remotes with the subcommand. By default all remotes are created with `disabled=False` and the `remotes.json` file only adds the information in case ... | 2019-08-14T10:27:55Z | Disabling/enabling remotes
A feature request from user could be summarized as:
- They have multiple remotes, 20+, that are defined and installed via ``conan config install``
- Developers need to login only to a few of them 1, 2...
- The remotes that the user is not logged in should be skipped.
After discussin... | So you config install 20+ repositories and you would need to disable 18? I don't like it... I'm that case I think it is better to remove them or not install them.
Maybe allowing patterns for enable/disable is a bit more handy. You can disable * and enable two of them.
I think it is useful when I have artifactory config... | [
{
"body": "A feature request from user could be summarized as:\r\n\r\n- They have multiple remotes, 20+, that are defined and installed via ``conan config install``\r\n- Developers need to login only to a few of them 1, 2...\r\n- The remotes that the user is not logged in should be skipped.\r\n\r\n\r\nAfter dis... | c15779cb336fd208758832263f4ef176ce60b856 | {
"head_commit": "48e2b17271f9ba467892504afd477b95beb03945",
"head_commit_message": "test install with --update",
"patch_to_review": "diff --git a/conans/client/cache/remote_registry.py b/conans/client/cache/remote_registry.py\nindex 4b5dc971883..4fee4f96f59 100644\n--- a/conans/client/cache/remote_registry.py\n+... | [
{
"diff_hunk": "@@ -24,9 +24,10 @@ def search_recipes(self, pattern, remote_name=None, case_sensitive=False):\n # Deprecate: 2.0 can remove this check\n if 'all' not in self._remotes:\n for remote in self._remotes.values():\n- refs = self._remote_manage... | 5f40813efacaca02c07f9a144ca8ab10539b977f | diff --git a/conans/client/cache/remote_registry.py b/conans/client/cache/remote_registry.py
index 4b5dc971883..6b72b519400 100644
--- a/conans/client/cache/remote_registry.py
+++ b/conans/client/cache/remote_registry.py
@@ -1,3 +1,4 @@
+import fnmatch
import json
import os
from collections import OrderedDict, named... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
conan-io__conan-5511@b1a3f76 | conan-io/conan | Python | 5,511 | Feature: Generator for python environment | Changelog: Feature: Virtual environment generator for gathering only the PYTHONPATH.
Docs: https://github.com/conan-io/docs/pull/1369
This pull-request closes #5157
- [X] Refer to the issue that supports this Pull Request.
- [X] If the issue has missing info, explain the purpose/use case/pain/need that covers t... | 2019-07-18T12:21:22Z | [suggestion] Add PYTHONPATH to virtualrunenv
Adding PYTHONPATH would make it sufficient to activate a virtualrunenv to use python modules in conan packages that also have dynamic library dependencies.
Without PYTHONPATH (as it is now) both a virtualrunenv and virtualenv needs to be activated for such python modules ... | Not sure, but might be related to this issue: https://github.com/conan-io/conan/issues/5117
The generators `virtualenv` and `virtualrunenv` are separated because they manage different things. With #5158 you are mixing them. I agree it would be only one step but that is a design decision, and, in my opinion, is random, ... | [
{
"body": "Adding PYTHONPATH would make it sufficient to activate a virtualrunenv to use python modules in conan packages that also have dynamic library dependencies.\r\n\r\nWithout PYTHONPATH (as it is now) both a virtualrunenv and virtualenv needs to be activated for such python modules to work.\r\n\r\nI woul... | 0e8187a118ffa50dcacc385dcdae0c47b5c86484 | {
"head_commit": "b1a3f769ba5d592f94492bbf27d56e47ca96803d",
"head_commit_message": "Merge pull request #1 from lasote/feature/python_virtualenv\n\nFeature/python virtualenv",
"patch_to_review": "diff --git a/conans/client/generators/__init__.py b/conans/client/generators/__init__.py\nindex dde846ad1e0..3fad34f07... | [
{
"diff_hunk": "@@ -0,0 +1,102 @@\n+import platform\n+import unittest\n+import os\n+\n+from conans.util.files import load\n+\n+from conans.test.utils.tools import TestClient, GenConanfile\n+\n+\n+class VirtualEnvPythonGeneratorTest(unittest.TestCase):\n+\n+ def simple_value_test(self):\n+ client = Tes... | 0c50e1339fa5178d15213516fbeee64cf42025f0 | diff --git a/conans/client/generators/__init__.py b/conans/client/generators/__init__.py
index dde846ad1e0..3fad34f07b5 100644
--- a/conans/client/generators/__init__.py
+++ b/conans/client/generators/__init__.py
@@ -24,6 +24,7 @@
from .text import TXTGenerator
from .virtualbuildenv import VirtualBuildEnvGenerator
f... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
conan-io__conan-5537@28bc2f8 | conan-io/conan | Python | 5,537 | conan search <pattern> --revisions with cache Issue/5472 | Changelog: Feature: Output current revision from references in local cache when using a pattern
Docs: https://github.com/conan-io/docs/pull/1381
Previous behaviour was that current revision number could only be shown if a reference was
given with the `--revisions` argument but not a pattern.
Now you can use a p... | 2019-07-26T06:52:34Z | conan search <pattern> --revisions
I miss a list of references but with the current revision in the local cache. Why? Even having the revisions enabled, the "install" traces ~~don't show which RREV is being used~~ (edit: there is a trace P1/1.0@conan/stable: Downloaded recipe revision c9da69cad5ccb88452fa1c6ed3db54b2) ... | [
{
"body": "I miss a list of references but with the current revision in the local cache. Why? Even having the revisions enabled, the \"install\" traces ~~don't show which RREV is being used~~ (edit: there is a trace P1/1.0@conan/stable: Downloaded recipe revision c9da69cad5ccb88452fa1c6ed3db54b2) but still woul... | f4e77dc330437c83f72f0e3053ab619825155766 | {
"head_commit": "28bc2f877d6a1143194520114dbec9fa63ccb0c9",
"head_commit_message": "add some tests",
"patch_to_review": "diff --git a/conans/client/command.py b/conans/client/command.py\nindex 28eb53379d0..ed5eac8434d 100644\n--- a/conans/client/command.py\n+++ b/conans/client/command.py\n@@ -1212,17 +1212,36 @@... | [
{
"diff_hunk": "@@ -1093,7 +1093,7 @@ def get_remote_by_name(self, remote_name):\n return self._cache.registry.load_remotes()[remote_name]\n \n @api_method\n- def get_recipe_revisions(self, reference, remote_name=None):\n+ def get_recipe_revisions(self, reference, remote_name=None, check_rev_t... | 25009a644e14772d3f81787f19de8d79143664c7 | diff --git a/conans/client/command.py b/conans/client/command.py
index 50b68d24a57..0892380a71d 100644
--- a/conans/client/command.py
+++ b/conans/client/command.py
@@ -1211,23 +1211,38 @@ def search(self, *args):
try:
if args.revisions:
+ # Show revisions of a ref
+ ... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} | |
conan-io__conan-5461@5d06f8e | conan-io/conan | Python | 5,461 | Do not raise when accessing the metadata of editable packages | Changelog: Bugfix: Do not raise when accessing the metadata of editable packages
Docs: omit
- [x] Refer to the issue that supports this Pull Request: closes #5424
- [x] If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
- [x] I've read the [Contributing guide](htt... | 2019-07-08T14:22:25Z | conan remote remove fails with editable packages
Trying to update the metadata, it fails because the `PackageEditableLayout` has no `update_metadata()`. The main questions are:
- Should the editable packages still have the metadata methods available?
or
- Should we force always to retrieve the `PackageCacheLayout`... | @memsharded I would like to know what do you think about this.
I think that so far it doesn't make sense, as metadata are revisions (we don't have them while editable) and remote (same). If the package is in editable mode, I think doesn't make much sense to return PackageCacheLayout for it, so far the PacakgeEditableLa... | [
{
"body": "Trying to update the metadata, it fails because the `PackageEditableLayout` has no `update_metadata()`. The main questions are:\r\n- Should the editable packages still have the metadata methods available? \r\nor \r\n- Should we force always to retrieve the `PackageCacheLayout` sometimes, e.g from the... | de33bf7c0372776682fb30bceff0425282f164ea | {
"head_commit": "5d06f8ef7b9ab4f7554adbdc483e9668d8d73584",
"head_commit_message": "fix missing call",
"patch_to_review": "diff --git a/conans/client/cache/remote_registry.py b/conans/client/cache/remote_registry.py\nindex c202e8ec32a..3bd1b173c15 100644\n--- a/conans/client/cache/remote_registry.py\n+++ b/conan... | [
{
"diff_hunk": "@@ -267,6 +268,16 @@ def _validate_url(self, url):\n else:\n self._output.warn(\"The URL is empty. It must contain scheme and hostname.\")\n \n+ @contextmanager\n+ def _editables_metadata_from_cache(self):\n+ \"\"\"\n+ Hide editable packages to get the cac... | ac50278e400585b4fbc490119a2bbee93fc5e2bc | diff --git a/conans/client/cache/editable.py b/conans/client/cache/editable.py
index 0bf08637ca6..6334a80e1c6 100644
--- a/conans/client/cache/editable.py
+++ b/conans/client/cache/editable.py
@@ -1,5 +1,6 @@
import json
import os
+from contextlib import contextmanager
from os.path import join, normpath
from cona... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
conan-io__conan-5346@94af85a | conan-io/conan | Python | 5,346 | Remove packages when version is asterisk | When removing a pattern like _hello/*@conan/testing_, Conan doesn't remove all patterns because all fields (name, version, channel, user) are validated by ConanFileReference. However, when using a pattern like _hello*/*@conan/testing_, the ConanFileReference won't match the name and will search for recipes.
Changelo... | 2019-06-12T13:00:58Z | [bug] conan remove does not find recipe
Hi there,
I tried to delete every version of a recipe in a certain user/channel but Conan stopped working with the error that it could not find the recipe:
```
conan remove cygwin_installer/*@user/channel
ERROR: Recipe not found: 'cygwin_installer/*@user/channel'
```
But wh... | [
{
"body": "Hi there,\r\nI tried to delete every version of a recipe in a certain user/channel but Conan stopped working with the error that it could not find the recipe:\r\n```\r\nconan remove cygwin_installer/*@user/channel\r\nERROR: Recipe not found: 'cygwin_installer/*@user/channel'\r\n```\r\nBut when I modi... | 46663964cbe546f50d29901ce749d694bba117c9 | {
"head_commit": "94af85ae727fd8b96662ca6d3e23e067eb3017b7",
"head_commit_message": "#5297 Validate channel when removing\n\nSigned-off-by: Uilian Ries <uilianries@gmail.com>",
"patch_to_review": "diff --git a/conans/client/remover.py b/conans/client/remover.py\nindex de6ca8675a3..353bbcb8393 100644\n--- a/conans... | [
{
"diff_hunk": "@@ -168,19 +168,22 @@ def remove(self, pattern, remote_name, src=None, build_ids=None, package_ids_fil\n else:\n refs = self._remote_manager.search_recipes(remote, pattern)\n else:\n- if input_ref:\n+ if not input_ref or (input_ref and\n+... | 3b96ee040d257ca1ea18ab5b2112352d214a8bea | diff --git a/conans/client/remover.py b/conans/client/remover.py
index de6ca8675a3..fabcb21386f 100644
--- a/conans/client/remover.py
+++ b/conans/client/remover.py
@@ -3,7 +3,7 @@
from conans.client.cache.remote_registry import Remote
from conans.errors import ConanException, PackageNotFoundException, RecipeNotFound... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
conan-io__conan-5224@42cca07 | conan-io/conan | Python | 5,224 | Upload using pref as the recommended way | Changelog: Feature: The `conan upload` command can receive now the full package reference to upload a binary package. The `-p` argument is now deprecated.
Docs: https://github.com/conan-io/docs/pull/1300
Closes #5196 | 2019-05-27T10:47:18Z | Conan upload receiving a pref instead of -p and from file
- The same we did with `conan get`, the pattern could process automatically the package to be uploaded, the `-p` usage could be warned as deprecated.
- Additionally, following the syntax used by other programs like `gcc`, `conan upload @filepath` could read t... | > Additionally, following the syntax used by other programs like gcc, conan upload @filepath could read the reference from a file.
Probably not a good idea, we plan to be able to specify references like `@user/channel` to disambiguate. | [
{
"body": "- The same we did with `conan get`, the pattern could process automatically the package to be uploaded, the `-p` usage could be warned as deprecated.\r\n\r\n- Additionally, following the syntax used by other programs like `gcc`, `conan upload @filepath` could read the reference from a file.",
"nu... | 6a90926d073d31bd31e8b1eb54ec69e483993391 | {
"head_commit": "42cca07db0f4f4c6796dc4f109fb3379f7e2cc07",
"head_commit_message": "Added test",
"patch_to_review": "diff --git a/conans/client/command.py b/conans/client/command.py\nindex a1085b3985d..236abb46f4a 100644\n--- a/conans/client/command.py\n+++ b/conans/client/command.py\n@@ -83,6 +83,7 @@ def _fill... | [
{
"diff_hunk": "@@ -91,7 +92,11 @@ def _fill_text(self, text, width, indent):\n _KEEP_SOURCE_HELP = (\"Do not remove the source folder in local cache, even if the recipe changed. \"\n \"Use this for testing purposes only\")\n _PATTERN_OR_REFERENCE_HELP = (\"Pattern or package recipe referen... | ea68e820a576dde3a1453d792298d6313f8dae95 | diff --git a/conans/client/command.py b/conans/client/command.py
index a1085b3985d..6ce940387a8 100644
--- a/conans/client/command.py
+++ b/conans/client/command.py
@@ -83,6 +83,7 @@ def _fill_text(self, text, width, indent):
_QUERY_EXAMPLE = ("os=Windows AND (arch=x86 OR compiler=gcc)")
_PATTERN_EXAMPLE = ("boost/*"... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
conan-io__conan-5189@b1baa25 | conan-io/conan | Python | 5,189 | templates for conan new | Changelog: Feature: New ``conan new --template=mytemplate`` to initialize recipes with your own templates
Docs: https://github.com/conan-io/docs/pull/1286
This has been improved with Jinja templates in https://github.com/conan-io/conan/pull/5267
Close #5192 | 2019-05-20T17:02:00Z | conan new template recipes
A use case where a team is creating many packages for their own libraries, and the recipes are very similar, it is useful to have the possibility to use a pre-defined template for the ``conan new`` command. | [
{
"body": "A use case where a team is creating many packages for their own libraries, and the recipes are very similar, it is useful to have the possibility to use a pre-defined template for the ``conan new`` command.\r\n\r\n",
"number": 5192,
"title": "conan new template recipes"
}
] | 6022abf83a61e7bba720bff4349118ee818b018e | {
"head_commit": "b1baa252ccecd5a0eaa868a477147cf22cd019c1",
"head_commit_message": "templates for conan new",
"patch_to_review": "diff --git a/conans/client/cmd/new.py b/conans/client/cmd/new.py\nindex cc7bafc9d7b..70c73f1513b 100644\n--- a/conans/client/cmd/new.py\n+++ b/conans/client/cmd/new.py\n@@ -1,8 +1,11 ... | [
{
"diff_hunk": "@@ -143,6 +143,8 @@ def new(self, *args):\n parser.add_argument(\"-b\", \"--bare\", action='store_true', default=False,\n help='Create the minimum package recipe, without build() method. '\n 'Useful in combination with \"export-pkg\... | b835a162e4408ef460bcd13fce6f53063e5af34e | diff --git a/conans/client/cmd/new.py b/conans/client/cmd/new.py
index cc7bafc9d7b..70c73f1513b 100644
--- a/conans/client/cmd/new.py
+++ b/conans/client/cmd/new.py
@@ -1,8 +1,11 @@
+import os
import re
from conans.client.cmd.new_ci import ci_get_files
from conans.errors import ConanException
from conans.model.re... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
conan-io__conan-5044@b6ea7c0 | conan-io/conan | Python | 5,044 | Feature/improve settings migration | Changelog: omit
Docs: omit
Close #5038 | 2019-04-26T16:40:33Z | Improve migration of settings.yml
**Current behavior**
We are not currently "patching" the `settings.yml` file nor modifying it. Only if we detect that the current yml on disk is the same as the previous version one, we replace it with the new one and store the old one in a `.old` file or similar.
This behavior is... | [
{
"body": "**Current behavior**\r\n\r\nWe are not currently \"patching\" the `settings.yml` file nor modifying it. Only if we detect that the current yml on disk is the same as the previous version one, we replace it with the new one and store the old one in a `.old` file or similar. \r\nThis behavior is like t... | f4d680bd8c193b2735131f7c4968947e5491ab5e | {
"head_commit": "b6ea7c0bb3ae652f4093e0279abc6a37f07f2db9",
"head_commit_message": "Test",
"patch_to_review": "diff --git a/conans/client/migrations.py b/conans/client/migrations.py\nindex db5a91efb42..c7ddbcfd501 100644\n--- a/conans/client/migrations.py\n+++ b/conans/client/migrations.py\n@@ -2,6 +2,7 @@\n imp... | [
{
"diff_hunk": "@@ -17,6 +19,20 @@\n \n class TestMigrations(unittest.TestCase):\n \n+ def is_there_var_for_settings_previous_version_test(self):\n+ from conans import __version__ as current_version\n+\n+ tmp = Version(current_version)\n+ if tmp.minor == 0:\n+ return unittest.... | 58571da28f70b6b90a8e5fac16d371eb155818f0 | diff --git a/conans/client/migrations.py b/conans/client/migrations.py
index db5a91efb42..199bca0957c 100644
--- a/conans/client/migrations.py
+++ b/conans/client/migrations.py
@@ -2,6 +2,7 @@
import shutil
from conans import DEFAULT_REVISION_V1
+from conans.client import migrations_settings
from conans.client.cac... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Code Refactoring / Architectural Improvement"
} | |
conan-io__conan-5206@cb98a7b | conan-io/conan | Python | 5,206 | Exception errors to stderr | Changelog: Feature: Print errors and warnings to `stderr`
Docs: omit
Close #5207 | 2019-05-23T11:19:14Z | stderr not used by Conan
At least, the exception messages printed in the `command.py` should go to stderr. This is important to improve the CI automation feedback on errors.
Maybe we should have the stderr stream on the conan output and print there also the .error messages | [
{
"body": "At least, the exception messages printed in the `command.py` should go to stderr. This is important to improve the CI automation feedback on errors.\r\n\r\nMaybe we should have the stderr stream on the conan output and print there also the .error messages",
"number": 5207,
"title": "stderr no... | a8eccd5da44e390f83f6c3242628eeb8e8f2a36c | {
"head_commit": "cb98a7bcac5108cacb3b557fddbd78a1d2f742a4",
"head_commit_message": "Exception errors to stderr",
"patch_to_review": "diff --git a/conans/client/command.py b/conans/client/command.py\nindex a1085b3985d..585e64914ec 100644\n--- a/conans/client/command.py\n+++ b/conans/client/command.py\n@@ -1711,19... | [
{
"diff_hunk": "@@ -1711,19 +1711,23 @@ def run(self, *args):\n if exc.code != 0:\n logger.error(exc)\n self._user_io.out.error(\"Exiting with code: %d\" % exc.code)\n+ sys.stderr.write(\"Exiting with code: %d\" % exc.code)\n ret_code = exc.... | bdb59e7acb91f120bcea0bf5d4b29e76729f6f49 | diff --git a/conans/client/conan_api.py b/conans/client/conan_api.py
index 97fe4e9e562..ada65621e49 100644
--- a/conans/client/conan_api.py
+++ b/conans/client/conan_api.py
@@ -156,7 +156,7 @@ def factory(interactive=None):
"""Factory"""
# Respect color env setting or check tty if unset
color... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} | |
conan-io__conan-4991@63a518a | conan-io/conan | Python | 4,991 | Skip symlink checks | Changelog: Feature: You can disable broken symlinks checks when packaging using `CONAN_SKIP_BROKEN_SYMLINKS_CHECK` env var or `config.skip_broken_symlinks_check=1`
Docs: https://github.com/conan-io/docs/pull/1272
Closes #4990 | 2019-04-17T09:03:58Z | Opt-in skip broken symlinks check packaging
We need to package directories with broken symlinks. We are trying to package yocto sdk and we didn't manage to fix them or remove them, because the sdk stops working. So we would need something like `CONAN_SKIP_BROKEN_SYMLINKS_CHECK` to remove the check in `manifest.py` line... | [
{
"body": "We need to package directories with broken symlinks. We are trying to package yocto sdk and we didn't manage to fix them or remove them, because the sdk stops working. So we would need something like `CONAN_SKIP_BROKEN_SYMLINKS_CHECK` to remove the check in `manifest.py` line 39",
"number": 4990,... | 44dbdef0ffe44d520e1c401b74b9c01c787ff45a | {
"head_commit": "63a518a396a900f606b45f979526fba695f6da64",
"head_commit_message": "Skip symlink checks",
"patch_to_review": "diff --git a/conans/client/conf/__init__.py b/conans/client/conf/__init__.py\nindex 085ddf9d86f..94d1e56312c 100644\n--- a/conans/client/conf/__init__.py\n+++ b/conans/client/conf/__init_... | [
{
"diff_hunk": "@@ -73,7 +73,9 @@ def touch(fname, times=None):\n def touch_folder(folder):\n for dirname, _, filenames in walk(folder):\n for fname in filenames:\n- os.utime(os.path.join(dirname, fname), None)\n+ path = os.path.join(dirname, fname)\n+ if not os.path... | fb20b3431a2de97eb09413af4e14d03d8761fc56 | diff --git a/conans/client/conf/__init__.py b/conans/client/conf/__init__.py
index 085ddf9d86f..94d1e56312c 100644
--- a/conans/client/conf/__init__.py
+++ b/conans/client/conf/__init__.py
@@ -104,6 +104,7 @@
# use_always_short_paths = False # environment CONAN_USE_ALWAYS_SHORT_PATHS
# skip_vs_projects_upgrade =... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
conan-io__conan-4767@d3b200f | conan-io/conan | Python | 4,767 | Allow to specify revision_mode for each recipe | Changelog: Feature: Allow to specify `revision_mode` for each recipe, values accepted are `scm` or `hash` (default)
Docs: https://github.com/conan-io/docs/pull/1126
- closes #4413: revision mode per recipe
- closes #4728: default revision mode is `hash` | 2019-03-19T11:33:25Z | Revisions: Choose revision_mode
But then, if you use the `scm` feature for third-party source code, you would be using the hash of the sources as the recipe revision, and not taking into account the recipe changes.
Should we provide a mechanism to indicate that the sources are not from the recipe?
`scm = {"url": ... | Maybe an attribute to the conanfile:
```
revision_mode = "auto" # Will choose between scm (if auto)/hash automatically
revision_mode = "scm" # Will use the scm revision ALWAYS
revision_mode = "hash" # Will use the hash of the exported
``` | [
{
"body": "But then, if you use the `scm` feature for third-party source code, you would be using the hash of the sources as the recipe revision, and not taking into account the recipe changes.\r\n\r\nShould we provide a mechanism to indicate that the sources are not from the recipe?\r\n\r\n`scm = {\"url\": \"a... | 41995bbe4bd1636cd91c983606d9b895671a71fe | {
"head_commit": "d3b200f7193d54ff99b22c68747867e08b96c210",
"head_commit_message": "default for revision_mode is 'hash', value 'auto' is no longer needed",
"patch_to_review": "diff --git a/conans/client/cmd/export.py b/conans/client/cmd/export.py\nindex 7bd0e0840f0..6c040e15c53 100644\n--- a/conans/client/cmd/ex... | [
{
"diff_hunk": "@@ -419,3 +421,45 @@ def _create_packages_and_builds(self):\n save(file_path, content)\n file_list.append(file_path)\n return file_list\n+\n+\n+class ExportMetadataTest(unittest.TestCase):\n+ conanfile = textwrap.dedent(\"\"\"\n+ from conans impo... | cfed5ec7e3e5ac325d53e1cc08ca4980e58a7f45 | diff --git a/conans/client/cmd/export.py b/conans/client/cmd/export.py
index 7bd0e0840f0..6c040e15c53 100644
--- a/conans/client/cmd/export.py
+++ b/conans/client/cmd/export.py
@@ -18,12 +18,14 @@
def export_alias(package_layout, target_ref, output, revisions_enabled):
+ revision_mode = "hash"
conanfile = ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
conan-io__conan-4766@b1d42b7 | conan-io/conan | Python | 4,766 | raise error instead of skipping files if short_paths | Changelog: Bugfix: Raise an error if source files cannot be correctly copied to build folder because of long paths in Windows.
Docs: omit
Close #4484
| 2019-03-19T11:19:29Z | Conan should throw an exception instead of a warning when it can't copy a source file because the path is too long on Windows
I just spent a lot of time debugging an issue happening only on Windows. Basically, the build would fail to link when building with conan. But it worked when I built it manually. I eventually fi... | Interesting thing: this issue was implemented this way, long, long time ago, and the offending package was failing to unzip some .html of the documentation. It was totally ok to ignore them.
I think it might be changed, but for that it should be considered a bug, because otherwise it might be breaking, and we cannot... | [
{
"body": "I just spent a lot of time debugging an issue happening only on Windows. Basically, the build would fail to link when building with conan. But it worked when I built it manually. I eventually figured out that conan was skipping files while copying the sources to the build directory warning me like th... | 41995bbe4bd1636cd91c983606d9b895671a71fe | {
"head_commit": "b1d42b79c330098a8f3c6788a40a3106b9f7ab65",
"head_commit_message": "raise error instead of skipping files if short_paths",
"patch_to_review": "diff --git a/conans/client/installer.py b/conans/client/installer.py\nindex 5a81447dfbd..8c1b2511c23 100644\n--- a/conans/client/installer.py\n+++ b/conan... | [
{
"diff_hunk": "@@ -90,13 +89,12 @@ def prepare_build(self):\n mkdir(self.build_folder)\n self._conan_file.source_folder = self.source_folder\n else:\n- if platform.system() == \"Windows\" and os.getenv(\"CONAN_USER_HOME_SHORT\") != \"None\":\n- from con... | 11c4742e78e38009d59e645b38a2ca8c7d092285 | diff --git a/conans/client/installer.py b/conans/client/installer.py
index 5a81447dfbd..1e22f39856c 100644
--- a/conans/client/installer.py
+++ b/conans/client/installer.py
@@ -1,5 +1,4 @@
import os
-import platform
import shutil
import time
@@ -90,13 +89,13 @@ def prepare_build(self):
mkdir(self.buil... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
conan-io__conan-4917@28cf036 | conan-io/conan | Python | 4,917 | Add cppstd as a subsetting of compiler | Changelog: Feature: Add `compiler.cppstd` setting (mark `cppstd` as deprecated)
Docs: https://github.com/conan-io/docs/pull/1266
This PR includes changes from PR #4986 and #4942 (really short ones)
----
Some hints about the new/old behavior:
- It keeps previous behavior: all use cases (tests) should be summ... | 2019-04-05T10:17:12Z | cppstd as a subsetting
We considered better to have the cppstd as a subsetting of every compiler:
- If you don't specify the -s compiler.cppstd=XXX it won't change anything, because will come with a None default value.
- We won't break anything, the global setting will be kept, but deprecated (comment at settings.y... | Q: Although each compiler will have its own flags to set the standard, I wonder if we should add those different names in our `settings.yml` or it is better to set `None, 98, 11, 14, 17, 20` for all the compilers and make the translation inside Conan code.
We don't have to introduce the flag name in the settings. But... | [
{
"body": "We considered better to have the cppstd as a subsetting of every compiler:\r\n\r\n- If you don't specify the -s compiler.cppstd=XXX it won't change anything, because will come with a None default value.\r\n- We won't break anything, the global setting will be kept, but deprecated (comment at settings... | 5f204b37644035d0e5c92e8503fe7813728530bb | {
"head_commit": "28cf036d6994e8afb04e29e734f1d064bd00c3f4",
"head_commit_message": "remove comment",
"patch_to_review": "diff --git a/conans/client/conan_api.py b/conans/client/conan_api.py\nindex abb9fbbe46d..0ea1b833ae7 100644\n--- a/conans/client/conan_api.py\n+++ b/conans/client/conan_api.py\n@@ -1173,7 +117... | [
{
"diff_hunk": "@@ -398,14 +404,31 @@ def default_std_matching(self):\n same as specifying None, packages are the same\n \"\"\"\n \n- if self.full_settings.cppstd and \\\n- self.full_settings.compiler and \\\n- self.full_settings.compiler.version:\n+ i... | b5f230002a55173708da1432b232defe71e9271f | diff --git a/conans/client/build/autotools_environment.py b/conans/client/build/autotools_environment.py
index 737e551481c..f05f4a6320d 100644
--- a/conans/client/build/autotools_environment.py
+++ b/conans/client/build/autotools_environment.py
@@ -8,7 +8,7 @@
format_inc... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
conan-io__conan-4595@184dd5c | conan-io/conan | Python | 4,595 | Raise if using 'conan search ... --revisions' with the feature disabled | Changelog: omit
Docs: omit
closes #4576
@REVISIONS: 1
| 2019-02-22T12:52:57Z | [revisions] Error on search recipe revisions in remote
When revisions are NOT enabled in the Conan Client and a remote search or recipe revisions is done, Conan errors with:
```
$ conan search wiringpi/2.46@conan/stable --revisions -r conan-virtual
ERROR: The remote doesn't support revisions. [Remote: conan-virtua... | [
{
"body": "When revisions are NOT enabled in the Conan Client and a remote search or recipe revisions is done, Conan errors with:\r\n\r\n```\r\n$ conan search wiringpi/2.46@conan/stable --revisions -r conan-virtual\r\nERROR: The remote doesn't support revisions. [Remote: conan-virtual]\r\n```\r\nH\r\nowever, th... | ab0870336550b7521da71595c6babf42d5690f7b | {
"head_commit": "184dd5ca367b001e291149d0b3b017d8053813c0",
"head_commit_message": "raise if using --revisions in search command with the feature disabled",
"patch_to_review": "diff --git a/conans/client/command.py b/conans/client/command.py\nindex 7cd41e5c406..68a57f696a9 100644\n--- a/conans/client/command.py\... | [
{
"diff_hunk": "@@ -1017,8 +1017,15 @@ def search(self, *args):\n parser.add_argument(\"-rev\", \"--revisions\", default=False, action='store_true',\n help='Get a list of revisions for a reference or a '\n 'package reference.')\n+\n ar... | ce94712a93d574d1ee10b416544d7cde9e50ac60 | diff --git a/conans/client/command.py b/conans/client/command.py
index 7cd41e5c406..3de12a8f4e2 100644
--- a/conans/client/command.py
+++ b/conans/client/command.py
@@ -1017,8 +1017,15 @@ def search(self, *args):
parser.add_argument("-rev", "--revisions", default=False, action='store_true',
... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} | |
conan-io__conan-4596@1aa5016 | conan-io/conan | Python | 4,596 | Use Jinja2 to parse layout files (editable packages) | Changelog: Feature: Apply Jinja2 to layout files before parsing them
Docs: https://github.com/conan-io/docs/pull/1093
This PR executes Jinja2 over layout files (context contains `reference`, `settings` and `options`) before parsing those files so the user will be able to apply some logic on the constructed path to ... | 2019-02-22T16:00:47Z | Use jinja2 templates for editable layouts
Syntax in editable layouts are currently using placeholders like ``{settings.build_type}`` to make some conditional logic regarding folder paths.
We knew it has some limitations specially with placeholder like ``{options.shared}``, that will replace the value with a ``True``... | Changed complexity, I think using jinja template engine for this should be relatively easy. | [
{
"body": "Syntax in editable layouts are currently using placeholders like ``{settings.build_type}`` to make some conditional logic regarding folder paths.\r\n\r\nWe knew it has some limitations specially with placeholder like ``{options.shared}``, that will replace the value with a ``True``/``False`` instead ... | 83053d0215fdc3137be527dd5a829b7c8ec9fb67 | {
"head_commit": "1aa5016b8876c9d8c01fd73372754aa1b4495ba0",
"head_commit_message": "remove duplicated test",
"patch_to_review": "diff --git a/conans/client/tools/oss.py b/conans/client/tools/oss.py\nindex 7521320b979..e61f7cc2457 100644\n--- a/conans/client/tools/oss.py\n+++ b/conans/client/tools/oss.py\n@@ -306... | [
{
"diff_hunk": "@@ -13,3 +13,4 @@ pygments>=2.0, <3.0\n astroid>=1.6.5\n deprecation>=2.0, <2.1\n tqdm>=4.28.1, <5\n+Jinja2==2.10",
"line": null,
"original_line": 16,
"original_start_line": null,
"path": "conans/requirements.txt",
"start_line": null,
"text": "@user1:\nMaybe this requirem... | 80615c2318647d827ecb00552fefc4ece9ce66b3 | diff --git a/conans/client/tools/oss.py b/conans/client/tools/oss.py
index 7521320b979..e61f7cc2457 100644
--- a/conans/client/tools/oss.py
+++ b/conans/client/tools/oss.py
@@ -306,7 +306,7 @@ def detect_windows_subsystem():
# https://github.com/Microsoft/WSL/issues/423#issuecomment-221627364
... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
conan-io__conan-4495@096ca0a | conan-io/conan | Python | 4,495 | Do not allow an alias to override an existing package | Changelog: Fix: Do not allow an alias to override an existing package
Docs: omit
closes #4423
✅ Do not pass the `cache` object to the `export_alias` function.
@REVISIONS: 1 | 2019-02-08T19:07:44Z | Prevent conan alias from overwriting existing packages
When creating an alias package with `conan alias` it is easy to mix up the order of parameters:
* Correct: `conan alias boost/ALIAS@conan/stable boost/1.69.0@conan/stable`
* Wrong: `conan alias boost/1.69.0@conan/stable boost/ALIAS@conan/stable`
In case you'... | I just found that a similar feature has been discussed within #3805 - the issue is just named in a way that it's hard to see on first glance what's going on there.
I have added it as "ux", because it is mostly a check. There are some possibilities:
- Throw an error if the package exists, and require ``--force``. Goo... | [
{
"body": "When creating an alias package with `conan alias` it is easy to mix up the order of parameters:\r\n\r\n* Correct: `conan alias boost/ALIAS@conan/stable boost/1.69.0@conan/stable`\r\n* Wrong: `conan alias boost/1.69.0@conan/stable boost/ALIAS@conan/stable`\r\n\r\nIn case you're accidentally calling th... | d51bb7237a00a64b367663b1b3fc22cb175c0305 | {
"head_commit": "096ca0ab70ec6022ec914d7d394d0a115d7350b6",
"head_commit_message": "Merge remote-tracking branch 'conan/develop' into fix/alias-existing",
"patch_to_review": "diff --git a/conans/client/cmd/export.py b/conans/client/cmd/export.py\nindex a85796c7206..f4c26225676 100644\n--- a/conans/client/cmd/exp... | [
{
"diff_hunk": "@@ -15,29 +15,25 @@\n from conans.model.scm import detect_repo_type\n from conans.paths import CONANFILE\n from conans.search.search import search_recipes, search_packages\n-from conans.util.files import is_dirty, load, mkdir, rmdir, save, set_dirty, remove\n+from conans.util.files import is_dir... | aab5fa1b29e67173eda33273c7a864697ad6e48a | diff --git a/conans/client/conan_api.py b/conans/client/conan_api.py
index 0f079fa4827..22017c536d6 100644
--- a/conans/client/conan_api.py
+++ b/conans/client/conan_api.py
@@ -45,6 +45,7 @@
from conans.client.userio import UserIO
from conans.errors import ConanException, NotFoundException
from conans.model.conan_fi... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
frappe__erpnext-45548@447e5eb | frappe/erpnext | Python | 45,548 | fix: Gross Profit Report with Correct Totals and Gross Margin | Support ticket: [Support Ticket - 30225](https://support.frappe.io/helpdesk/tickets/30225)
- closes : #35942
Before :
The add_total_row option was checked, causing the subtotals to combine, which resulted in an incorrect **Selling Amount**, **Buying Amount**, **Gross Profit**, **Gross Profit Percentage**.
<i... | 2025-01-27T13:34:35Z | Gross Profit Report error
### Information about bug
Using the Gross Profit report grouped by invoices shows incorrect gross profit average figure in the 'total' row. Also when changing the grouping to item code, it again gives another average figure which is also wrong.
### Module
accounts
### Version
ERPNext: v1... | I think I figured out the error. In each grouping the figure changes except in monthly when it gives the right figure.
So, it takes the average of the gross profit% column rather than calculate using the totals. That has to be fixed as its a fundamental error in giving averages which have got to be on the totals (i... | [
{
"body": "### Information about bug\n\nUsing the Gross Profit report grouped by invoices shows incorrect gross profit average figure in the 'total' row. Also when changing the grouping to item code, it again gives another average figure which is also wrong. \n\n### Module\n\naccounts\n\n### Version\n\nERPNext:... | 47c2c5377c162c896751cb1988fb80a9ba1ae608 | {
"head_commit": "447e5ebac7bc31ecf108ae7794989ea9f1ed9abb",
"head_commit_message": "test: added test cases for total",
"patch_to_review": "diff --git a/erpnext/accounts/report/gross_profit/gross_profit.json b/erpnext/accounts/report/gross_profit/gross_profit.json\nindex 0730ffd77e5b..dfb7a991e3ea 100644\n--- a/e... | [
{
"diff_hunk": "@@ -189,6 +196,24 @@ def get_data_when_grouped_by_invoice(columns, gross_profit_data, filters, group_\n \n \t\tdata.append(row)\n \n+\ttotal_gross_profit = total_base_amount - total_buying_amount\n+\tdata.append(\n+\t\tfrappe._dict(\n+\t\t\t{\n+\t\t\t\t\"sales_invoice\": \"Total\",\n+\t\t\t\t\"q... | dbdc39d30ffeb5ec545dad23e543f8f114397abe | diff --git a/erpnext/accounts/report/gross_profit/gross_profit.json b/erpnext/accounts/report/gross_profit/gross_profit.json
index 0730ffd77e5b..dfb7a991e3ea 100644
--- a/erpnext/accounts/report/gross_profit/gross_profit.json
+++ b/erpnext/accounts/report/gross_profit/gross_profit.json
@@ -1,5 +1,5 @@
{
- "add_total_r... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
frappe__erpnext-41655@e65f306 | frappe/erpnext | Python | 41,655 | fix: completed DC will not appear in a delivery trip | fixes: #41427
Set the condition for the delivery trip so that a completed Delivery Challan (DC) will not appear. Also, add the customer filter in the "Get stops from".
The `docstatus` 1 was removed from the delivery trip due to https://github.com/frappe/erpnext/pull/38559, but `docstatus` 1 is still set in `deliv... | 2024-05-27T10:06:35Z | Delivery Trip can still schedule a delivery Note Even Delivery Trip is tagged as Completed
### Information about bug
Using the Old Versions, the delivery trip can filter fetching of delivery notes that are not yet delivered. But on version 14, you can still fetch all delivery notes regardless if it was already visited... | [
{
"body": "### Information about bug\n\nUsing the Old Versions, the delivery trip can filter fetching of delivery notes that are not yet delivered. But on version 14, you can still fetch all delivery notes regardless if it was already visited/delivered or not yet. \r\n\r\nYou may encode all delivery notes throu... | 537e0e32b2d02da278824a3e226f45c983326745 | {
"head_commit": "e65f30674d4e390fa6b702b2407588a704df8ac2",
"head_commit_message": "fix: completed DC will not appear in a delivery trip",
"patch_to_review": "diff --git a/erpnext/stock/doctype/delivery_note/delivery_note.js b/erpnext/stock/doctype/delivery_note/delivery_note.js\nindex 06881c99c125..8e9fbcd2adb7... | [
{
"diff_hunk": "@@ -223,7 +223,7 @@ erpnext.stock.DeliveryNoteController = class DeliveryNoteController extends (\n \t\t\t\t);\n \t\t\t}\n \n-\t\t\tif (doc.docstatus == 1 && frappe.model.can_create(\"Delivery Trip\")) {\n+\t\t\tif (doc.docstatus == 1 && doc.status == \"Completed\" && frappe.model.can_create(\"D... | ffc1f4837b305ef698d54dccbec8ee5e2e08ff4a | diff --git a/erpnext/stock/doctype/delivery_note/delivery_note.js b/erpnext/stock/doctype/delivery_note/delivery_note.js
index 06881c99c125..eba41d97c6e0 100644
--- a/erpnext/stock/doctype/delivery_note/delivery_note.js
+++ b/erpnext/stock/doctype/delivery_note/delivery_note.js
@@ -223,7 +223,7 @@ erpnext.stock.Deliver... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
frappe__erpnext-40964@39d6df7 | frappe/erpnext | Python | 40,964 | fix: price list when invoice created from timesheet | **Version 15**
fixes: #40921
**Before:**
https://github.com/frappe/erpnext/assets/141945075/7cf638f5-5874-44ae-b5d4-c0753d0badf6
<br>
**After:**
https://github.com/frappe/erpnext/assets/141945075/a1cfdf4e-d2ae-460c-ae43-b736ad173a67
| 2024-04-11T06:40:18Z | Wrong pricelist when invoice created from timesheet
### Information about bug
When an invoice is created from a timesheet, the pricelist for the invoice is set to the default price list instead of the price list defined in the customer.
Creating an invoice from scratch uses the correct price list for the customer.
... | [
{
"body": "### Information about bug\n\nWhen an invoice is created from a timesheet, the pricelist for the invoice is set to the default price list instead of the price list defined in the customer.\r\n\r\nCreating an invoice from scratch uses the correct price list for the customer.\n\n### Module\n\nselling, p... | fc835ed6b12f09b168c737ccbb467ec98ac3c5a1 | {
"head_commit": "39d6df7c7d225cb946a640e980fcc5bafb1c6a2d",
"head_commit_message": "fix: price list when invoice created from timesheet",
"patch_to_review": "diff --git a/erpnext/projects/doctype/timesheet/timesheet.py b/erpnext/projects/doctype/timesheet/timesheet.py\nindex 90f436831f91..a625f9fee73a 100644\n--... | [
{
"diff_hunk": "@@ -389,6 +389,9 @@ def make_sales_invoice(source_name, item_code=None, customer=None, currency=None\n \ttarget.project = timesheet.parent_project\n \tif customer:\n \t\ttarget.customer = customer\n+\t\tcustomer_doc = frappe.get_doc(\"Customer\", customer)",
"line": null,
"original_line"... | 882227a460ae33e0829c0876f5ad8d33f4ded639 | diff --git a/erpnext/projects/doctype/timesheet/timesheet.py b/erpnext/projects/doctype/timesheet/timesheet.py
index 90f436831f91..64584591cc03 100644
--- a/erpnext/projects/doctype/timesheet/timesheet.py
+++ b/erpnext/projects/doctype/timesheet/timesheet.py
@@ -389,6 +389,9 @@ def make_sales_invoice(source_name, item_... | {
"difficulty": "medium",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} | |
conan-io__conan-4380@e9cf667 | conan-io/conan | Python | 4,380 | Remove double application of env vars from profile | Changelog: BugFix: Prepend environment variables are applied twice in conanfile
Docs: omit
- [x] Refer to the issue that supports this Pull Request: closes #4385
- [x] If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
- [x] I've read the [Contributing guide](htt... | 2019-01-24T15:01:20Z | Virtualenv generator prepends duplicated values in env vars from profile
With a *conanfile.txt* empty and a profile with:
```
[env]
PREPEND_VAR = ['kk','pp']
```
Commands:
```
$ conan install . -g virtualenv
```
In activate.sh there is:
```
PREPEND_VAR="kk":"pp":"kk":"pp"
```
and in *activate.bat* ... | [
{
"body": "With a *conanfile.txt* empty and a profile with:\r\n\r\n```\r\n[env]\r\nPREPEND_VAR = ['kk','pp']\r\n```\r\n\r\nCommands:\r\n\r\n```\r\n$ conan install . -g virtualenv\r\n```\r\n\r\nIn activate.sh there is:\r\n```\r\nPREPEND_VAR=\"kk\":\"pp\":\"kk\":\"pp\"\r\n```\r\nand in *activate.bat* you alaso ha... | 256c14775b6281dec546aec1aa4c5973fe0d3ac8 | {
"head_commit": "e9cf6670b5180d4704cdf073e42bfcdb6b93c235",
"head_commit_message": "make test conditional",
"patch_to_review": "diff --git a/conans/client/loader.py b/conans/client/loader.py\nindex 525ef71b8ca..9bd73cab09c 100644\n--- a/conans/client/loader.py\n+++ b/conans/client/loader.py\n@@ -174,7 +174,6 @@ ... | [
{
"diff_hunk": "@@ -0,0 +1,19 @@\n+import platform\n+import unittest\n+\n+from conans import ConanFile, Settings\n+from conans.client.generators.virtualenv import VirtualEnvGenerator\n+from conans.model.env_info import EnvValues\n+from conans.test.utils.tools import TestBufferConanOutput\n+\n+\n+@unittest.skipU... | 2699c7156e80d76d95894b6372f2e3edc07c80b8 | diff --git a/conans/client/loader.py b/conans/client/loader.py
index 525ef71b8ca..9bd73cab09c 100644
--- a/conans/client/loader.py
+++ b/conans/client/loader.py
@@ -174,7 +174,6 @@ def _parse_conan_txt(self, contents, path, display_name, processed_profile):
# imports method
conanfile.imports = parse... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
conan-io__conan-4354@3612dd7 | conan-io/conan | Python | 4,354 | #3812 Remove system requirements from cache | Related Issue: #3812
Changelog: Feature: Remove system requirements conan folders (not installed binaries) from cache
Docs: https://github.com/conan-io/docs/pull/1038
@PYVERS: Macos@py27, Windows@py36, Linux@py27, py34
closes #3812
- [X] Refer to the issue that supports this Pull Request.
- [X] If the iss... | 2019-01-21T21:55:56Z | system_requirements files not shared between host/docker
I have an application depends on a library libA. libA's recipe has a system_requirements() method which installs a system library. libA's artifact is stored remotely. When I built the applications, it failed to find the system library installed by the libA's reci... | In fact, this is caused by the same reason in https://github.com/conan-io/conan/issues/2262
Everytime libA is installed the system requirements method will be called if it hasn't installed before so I don't understand exactly what is the issue. What do you mean with `When I built the application`? The app is built in... | [
{
"body": "I have an application depends on a library libA. libA's recipe has a system_requirements() method which installs a system library. libA's artifact is stored remotely. When I built the applications, it failed to find the system library installed by the libA's recipe.\r\n\r\nIs system_requirements() tr... | b28d665e63b423d4e1feeef307500cae3657c0c2 | {
"head_commit": "3612dd76050a8d545ed170d9890b298a42bcdae5",
"head_commit_message": "#3812 --system-reqs can raise error\n\n- Conan remove --system-reqs forwards the exception message\n when an error occurs.\n- Re-order remove command arguments\n- Add test to check system-reqs error message\n\nSigned-off-by: Uilia... | [
{
"diff_hunk": "@@ -139,3 +144,45 @@ def wrong_output_test(self):\n pref = PackageReference(ref, \"f0ba3ca2c218df4a877080ba99b65834b9413798\")\n load_file = load(client.cache.system_reqs_package(pref))\n self.assertEqual('', load_file)\n+\n+ def remove_system_reqs_test(self):\n+ ... | a79bd346136d93422a47bac5723e641f6122a43d | diff --git a/conans/client/cache.py b/conans/client/cache.py
index 8f7ac60d589..8d3e272bb44 100644
--- a/conans/client/cache.py
+++ b/conans/client/cache.py
@@ -14,12 +14,12 @@
from conans.model.profile import Profile
from conans.model.ref import ConanFileReference
from conans.model.settings import Settings
-from co... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Dependency Updates & Env Compatibility"
} |
frappe__erpnext-37828@84f0d1f | frappe/erpnext | Python | 37,828 | fix: payments irrespective of party types | **Problem**
Currently, when a Payment Entry is created, the ledger entries that get generated are configured in a way that does not allow the following scenarios -
- Receive from a Payable Party Type like Supplier / Shareholder / Employee.
- Pay to a Receivable Party Type like Customer.
**Solution**
- Remove th... | 2023-11-01T10:12:46Z | Payment Receive from Shareholder
### Information about bug
Trying to submit a payment of type receive from a shareholder with cash payment mode to cash account from creditors account causes an error.. Debit and Credit entries created are not equal. ERPNext puts both entries on one side instead of one entry in Debit a... | Share Traceback? | [
{
"body": "### Information about bug\n\nTrying to submit a payment of type receive from a shareholder with cash payment mode to cash account from creditors account causes an error.. Debit and Credit entries created are not equal. ERPNext puts both entries on one side instead of one entry in Debit and the other ... | 7e67d42d1d1837e47a5df3b1e6e22a72c996d761 | {
"head_commit": "84f0d1ff1ff231f0388033d2304d977b07411253",
"head_commit_message": "chore: linting issues",
"patch_to_review": "diff --git a/erpnext/accounts/doctype/payment_entry/payment_entry.py b/erpnext/accounts/doctype/payment_entry/payment_entry.py\nindex e6403fddefe3..c0e3ab3ed49d 100644\n--- a/erpnext/ac... | [
{
"diff_hunk": "@@ -2041,3 +2041,7 @@ def create_gain_loss_journal(\n \tjournal_entry.save()\n \tjournal_entry.submit()\n \treturn journal_entry.name\n+\n+\n+def get_party_types_from_account_type(account_type):\n+\treturn frappe.db.get_list(\"Party Type\", {\"account_type\": account_type}, pluck=\"name\")",
... | 2984a86f37e72bbdefd0348d7c456bd6ada540bb | diff --git a/erpnext/accounts/doctype/payment_entry/payment_entry.py b/erpnext/accounts/doctype/payment_entry/payment_entry.py
index e6403fddefe3..c0e3ab3ed49d 100644
--- a/erpnext/accounts/doctype/payment_entry/payment_entry.py
+++ b/erpnext/accounts/doctype/payment_entry/payment_entry.py
@@ -33,6 +33,7 @@
get_accou... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
conan-io__conan-4273@a16ecfa | conan-io/conan | Python | 4,273 | fixing version ranges with spaces | Changelog: Bugfix: Fix version ranges containing spaces and not separated by commas.
Docs: Omit
Close #4270
I think it doesn't make sense to replace whitespace in the middle of a <ref>. That should be an error, not "magically" fixed. | 2019-01-10T15:11:56Z | conan install unexpectedly reports invalid version range
i have this requirement in my `conanfile.py`:
`foo/[>16.5.0 <17.0.0]@bar/stable`
`conan install` aborts with this error:
`ERROR: version range expression '>16.5.0<17.0.0' is not valid`
note: using the deprecated comma-based syntax works fine
* Python 3... | Reproduced, indeed an undesired bug. Thanks for reporting @mistafunk ! | [
{
"body": "i have this requirement in my `conanfile.py`:\r\n`foo/[>16.5.0 <17.0.0]@bar/stable`\r\n\r\n`conan install` aborts with this error:\r\n`ERROR: version range expression '>16.5.0<17.0.0' is not valid`\r\n\r\nnote: using the deprecated comma-based syntax works fine\r\n\r\n* Python 3.6 on CentOS 7.5\r\n* ... | 0e8fd48f409faa06ce468d7dae2d01da270dc95d | {
"head_commit": "a16ecfa535268733359c4b3f20b0f2bac3013433",
"head_commit_message": "simplified testing",
"patch_to_review": "diff --git a/conans/model/ref.py b/conans/model/ref.py\nindex 560534eade0..984bb0e3d98 100644\n--- a/conans/model/ref.py\n+++ b/conans/model/ref.py\n@@ -78,7 +78,6 @@ class ConanFileRefere... | [
{
"diff_hunk": "@@ -37,7 +37,7 @@ def basic_test(self):\n def errors_test(self):\n self.assertRaises(ConanException, ConanFileReference.loads, \"\")\n self.assertRaises(ConanException, ConanFileReference.loads, \"opencv/2.4.10\")\n- self.assertRaises(ConanException, ConanFileReference... | 6b6411d514b6b2a821129a7d307c6dc43913653d | diff --git a/conans/model/ref.py b/conans/model/ref.py
index 560534eade0..984bb0e3d98 100644
--- a/conans/model/ref.py
+++ b/conans/model/ref.py
@@ -78,7 +78,6 @@ class ConanFileReference(namedtuple("ConanFileReference", "name version user cha
""" Full reference of a package recipes, e.g.:
opencv/2.4.10@lasot... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
frappe__erpnext-33874@74fab53 | frappe/erpnext | Python | 33,874 | feat: Support for Alternative Items in Quotation | > **Note:** Not to be confused with DocType "Item Alternative"
Documentation Draft: https://docs.erpnext.com/docs/v14/user/manual/en/selling/quotation/edit-wiki?wiki_page_patch=b1a88d79a9
Please check https://github.com/frappe/erpnext/issues/33609 to understand the issue
<details>
<summary>Impact on Quotation... | 2023-01-30T10:58:29Z | Alternative line items in Quotation
Summary: I want to offer multiple variations of an item or service at different prices in the same **Quotation**. Only the main item or service shall be included in the total. The customer can decide to order any one of the proposed variations.
Let's say I'm selling flights. I wan... | [
{
"body": "Summary: I want to offer multiple variations of an item or service at different prices in the same **Quotation**. Only the main item or service shall be included in the total. The customer can decide to order any one of the proposed variations.\r\n\r\nLet's say I'm selling flights. I want to tell my ... | a9920715ab902a276a25936cd1b98a427e7afdbd | {
"head_commit": "74fab53e281b42c2eb3436ae3145d820108b1c13",
"head_commit_message": "test: Alternative items in Quotation\n\n- Taxes and totals, mapping, back updation",
"patch_to_review": "diff --git a/erpnext/controllers/taxes_and_totals.py b/erpnext/controllers/taxes_and_totals.py\nindex 8c403aa9bfe2..1edd7bf8... | [
{
"diff_hunk": "@@ -220,17 +234,111 @@ erpnext.selling.QuotationController = class QuotationController extends erpnext.\n \t\t\t}\n \t\t})\n \t}\n+\n+\tshow_alternative_items_dialog() {\n+\t\tvar me = this;",
"line": null,
"original_line": 239,
"original_start_line": null,
"path": "erpnext/selli... | 47ab26dedfa2ceb3c3b126375ead68aa993ca583 | diff --git a/erpnext/controllers/taxes_and_totals.py b/erpnext/controllers/taxes_and_totals.py
index 8c403aa9bfe2..1edd7bf85e1f 100644
--- a/erpnext/controllers/taxes_and_totals.py
+++ b/erpnext/controllers/taxes_and_totals.py
@@ -24,11 +24,19 @@ class calculate_taxes_and_totals(object):
def __init__(self, doc: Docum... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
frappe__erpnext-30870@d4779e3 | frappe/erpnext | Python | 30,870 | fix(UX): misleading stock entry lables | 1. flip field location (consumption on left, receipt on right like warehouses)
2. Change incorrect label on value difference field
closes https://github.com/frappe/erpnext/issues/30867
before
<img width="1132" alt="Screenshot 2022-05-02 at 2 43 50 PM" src="https://user-images.githubusercontent.com/9079960/166... | 2022-05-02T09:26:29Z | Field "Value Difference" in Stock Entry doctype calculation wrong way round.
### Information about bug
I think the Value Difference field is supposed to calculate the value added to an item. The text says "Total Value Difference(Out - In) but the code calculates (In - Out)
From stock_entry.py
`def set_total_inco... | It's correct.
Example:
Additional cost is added to inventory value using repack:
<img width="1132" alt="Screenshot 2022-05-02 at 2 43 50 PM" src="https://user-images.githubusercontent.com/9079960/166211942-9ac6678e-ba23-4a2f-b5fc-d5f416915fea.png">
Outgoing = consumption
incoming = receipt
differ... | [
{
"body": "### Information about bug\r\n\r\nI think the Value Difference field is supposed to calculate the value added to an item. The text says \"Total Value Difference(Out - In) but the code calculates (In - Out)\r\n\r\nFrom stock_entry.py\r\n`def set_total_incoming_outgoing_value(self):`\r\n\t\t`self.total_... | dcda55641b822f62b9808c36027b59b5eaf697b3 | {
"head_commit": "d4779e3a8416feca156b234ef0feb791f2c02f2e",
"head_commit_message": "fix(UX): misleading stock entry lables",
"patch_to_review": "diff --git a/erpnext/stock/doctype/stock_entry/stock_entry.json b/erpnext/stock/doctype/stock_entry/stock_entry.json\nindex c38dfaa1c844..e658040bd0a6 100644\n--- a/erp... | [
{
"diff_hunk": "@@ -386,15 +386,15 @@\n {\n \"fieldname\": \"total_outgoing_value\",\n \"fieldtype\": \"Currency\",\n- \"label\": \"Total Outgoing Value\",\n+ \"label\": \"Total Outgoing Value (Consumption)\",\n \"options\": \"Company:company:default_currency\",\n \"print_hide\": 1,\n \"rea... | 388de113875bbba6b8c4d7c1539466db32d0c04b | diff --git a/erpnext/stock/doctype/stock_entry/stock_entry.json b/erpnext/stock/doctype/stock_entry/stock_entry.json
index c38dfaa1c844..f56e059f81c3 100644
--- a/erpnext/stock/doctype/stock_entry/stock_entry.json
+++ b/erpnext/stock/doctype/stock_entry/stock_entry.json
@@ -46,9 +46,9 @@
"items",
"get_stock_and_r... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "Bug Fixes"
} |
frappe__erpnext-30865@5e0dee3 | frappe/erpnext | Python | 30,865 | fix: Period Closing Voucher is considering GL entries with is_cancelled=1 | **Period Closing Voucher is considering GL entry with is_cancelled=1 as well**
Frappe version - v13.23.0 (version-13)
ERPNext version - v13.23.0 [(version-13)
Module
accounts
Version
Frappe version - v13.27.0 (version-13)
ERPNext version - v13.27.1 (version-13)
Installation method
FrappeCloud
Curre... | 2022-05-02T07:42:35Z | Period Closing Voucher is considering GL entry with is_cancelled=1 as well
### Information about bug
The period closing voucher is considering the canceled GL entries as well.
If we cancel any transaction and do not delete it and try to post the period closing voucher then the balance of ledger is not mataching wi... | [
{
"body": "### Information about bug\n\nThe period closing voucher is considering the canceled GL entries as well. \r\n\r\nIf we cancel any transaction and do not delete it and try to post the period closing voucher then the balance of ledger is not mataching with a period closing voucher. \r\n\r\nSteps to repr... | 0b9a59c605fe02f49f358b1a3c5a58c1eadec734 | {
"head_commit": "5e0dee3dcd30e7ea190d74061ccde47a60a8bd2f",
"head_commit_message": "fix: Period Closing Voucher - Period Closing Voucher is considering GL entry with is_cancelled=1 as well",
"patch_to_review": "diff --git a/erpnext/accounts/doctype/period_closing_voucher/period_closing_voucher.py b/erpnext/accou... | [
{
"diff_hunk": "@@ -167,7 +167,7 @@ def get_pl_balances(self):\n \t\t\t\tsum(t1.debit) - sum(t1.credit) as bal_in_company_currency\n \t\t\tfrom `tabGL Entry` t1, `tabAccount` t2\n \t\t\twhere t1.account = t2.name and t2.report_type = 'Profit and Loss'\n-\t\t\tand t2.docstatus < 2 and t2.company = %s\n+\t\t\tand... | 681529c6825c86f8f04327a640b4b05a7cc4456d | diff --git a/erpnext/accounts/doctype/period_closing_voucher/period_closing_voucher.py b/erpnext/accounts/doctype/period_closing_voucher/period_closing_voucher.py
index f66cf1c9f1a7..53b1c64c4603 100644
--- a/erpnext/accounts/doctype/period_closing_voucher/period_closing_voucher.py
+++ b/erpnext/accounts/doctype/period... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
frappe__erpnext-32091@2a100ab | frappe/erpnext | Python | 32,091 | fix: Migrate old lead notes as per the new format | fixes #31800 | 2022-09-05T10:03:52Z | notes for leads created in V13 generate exception after upgrade to V14
### Information about bug
All leads created with the version V13 containing a note generate a exception after the upgrade to V14 and are inaccessible.
New Leads work fine but the Notes field is missing in the frontend even if in the tabLead tab... | It looks like even though the `notes` field was changed from `Text Editor` to `Table` in https://github.com/frappe/erpnext/pull/31311, it wasn't patched. | [
{
"body": "### Information about bug\n\nAll leads created with the version V13 containing a note generate a exception after the upgrade to V14 and are inaccessible.\r\nNew Leads work fine but the Notes field is missing in the frontend even if in the tabLead table there's the \"notes\" column filled with the or... | e00ece7a788c31d810857e53bdeaea506fd15492 | {
"head_commit": "2a100abef19d4db9566b7b760b1c029e1609f3e1",
"head_commit_message": "perf: lesser SQL queries and no validation\n\nCo-authored-by: Sagar Vora <sagar@resilient.tech>",
"patch_to_review": "diff --git a/erpnext/patches.txt b/erpnext/patches.txt\nindex 4729add16b38..f48b2a1bb0af 100644\n--- a/erpnext/... | [
{
"diff_hunk": "@@ -0,0 +1,21 @@\n+import frappe\n+from frappe.utils import cstr, strip_html\n+\n+\n+def execute():\n+\tfor doctype in (\"Lead\", \"Prospect\"):",
"line": null,
"original_line": 6,
"original_start_line": null,
"path": "erpnext/patches/v14_0/migrate_existing_lead_notes_as_per_the_... | 51c37aeee326a7648564bb969e2e09416e465e36 | diff --git a/erpnext/patches.txt b/erpnext/patches.txt
index d780213209c8..2a0ca8c49619 100644
--- a/erpnext/patches.txt
+++ b/erpnext/patches.txt
@@ -307,6 +307,7 @@ erpnext.patches.v13_0.job_card_status_on_hold
erpnext.patches.v14_0.copy_is_subcontracted_value_to_is_old_subcontracting_flow
erpnext.patches.v14_0.mig... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
frappe__erpnext-29182@ca17c72 | frappe/erpnext | Python | 29,182 | fix: get project from PO into payment entry | Fix for [Issue 16662]( https://github.com/frappe/erpnext/issues/16662)
Now, creating payments for Purchase orders will pull the project from the line items.
`no-docs`
| 2022-01-07T04:57:19Z | Payment entry from Purchase Invoice does NOT catch Project from PO line
I want to check profitability on Project base and encounter one problem with payment entries created from a Purchase Invoice.
The item in my PO is linked to a certain project
### expected behavior
when I use "Make Payment" from that PO, the... | Thanks for reporting this @vrms | [
{
"body": "I want to check profitability on Project base and encounter one problem with payment entries created from a Purchase Invoice.\r\n\r\nThe item in my PO is linked to a certain project\r\n\r\n### expected behavior \r\nwhen I use \"Make Payment\" from that PO, the Project which is connected to the item l... | 3438e1f0c48f57fe747be3324574374d3d2e1364 | {
"head_commit": "ca17c7226ce343e63cf929023babee425e3da3c5",
"head_commit_message": "fix: get project from PO into payment entry",
"patch_to_review": "diff --git a/erpnext/accounts/doctype/payment_entry/payment_entry.py b/erpnext/accounts/doctype/payment_entry/payment_entry.py\nindex c1b056b9c704..18f35722c0fb 10... | [
{
"diff_hunk": "@@ -1522,6 +1523,8 @@ def get_payment_entry(dt, dn, party_amount=None, bank_account=None, bank_amount=\n \tpe.paid_amount = paid_amount\n \tpe.received_amount = received_amount\n \tpe.letter_head = doc.get(\"letter_head\")\n+\tif dt == 'Purchase Order':",
"line": null,
"original_line": 1... | 09172002e729a2bbee2362f3132d0cbd688c6b20 | diff --git a/erpnext/accounts/doctype/payment_entry/payment_entry.py b/erpnext/accounts/doctype/payment_entry/payment_entry.py
index 0e07abd7255c..02a144d3e79f 100644
--- a/erpnext/accounts/doctype/payment_entry/payment_entry.py
+++ b/erpnext/accounts/doctype/payment_entry/payment_entry.py
@@ -3,6 +3,7 @@
import j... | {
"difficulty": "low",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
frappe__erpnext-28818@44cbd23 | frappe/erpnext | Python | 28,818 | fix: no module named 'redisearch' | This PR aims to fix the module not found error while installing ERPNext.
Objectives:
- [x] Rename `erpnext/e_commerce/redisearch.py`
- [x] Rename its references
Closes #28730 | 2021-12-10T11:18:22Z | Error: No module named 'redisearch' while installing ERPNext.
**Issue:**
Ran `bench get-app erpnext` and then `bench install-app erpnext`
Cannot install ERPNext.
```
Installing erpnext...
Updating DocTypes for erpnext : [=================== ] 99%
An error occurred while installing erpnext:
Module import fa... | Very similar to https://github.com/frappe/frappe/pull/14093
Probably just need to rename the file and fix all the references.
@rtdany10 interested in fixing this? :grinning:
> @rtdany10 interested in fixing this? grinning
Haha, I was planning to send a fix right away, but [github doesn't tell me where all t... | [
{
"body": "**Issue:**\r\nRan `bench get-app erpnext` and then `bench install-app erpnext`\r\nCannot install ERPNext.\r\n```\r\nInstalling erpnext...\r\nUpdating DocTypes for erpnext : [=================== ] 99%\r\nAn error occurred while installing erpnext:\r\nModule import failed for Website Item (erpnex... | d2fac1492292cb7b1f34eb1fa79dbe258766f2d6 | {
"head_commit": "44cbd2341e04346629b0600cf1c2f419407b75ec",
"head_commit_message": "fix: rename ref in product_search.py",
"patch_to_review": "diff --git a/erpnext/e_commerce/doctype/e_commerce_settings/e_commerce_settings.py b/erpnext/e_commerce/doctype/e_commerce_settings/e_commerce_settings.py\nindex 1b0480bb... | [
{
"diff_hunk": "@@ -6,7 +6,7 @@\n from frappe.model.document import Document\n from frappe.utils import comma_and, flt, unique\n \n-from erpnext.e_commerce.redisearch import (\n+from erpnext.e_commerce.rsearch import (",
"line": null,
"original_line": 9,
"original_start_line": null,
"path": "erp... | af2cf67f0882ad074c870b0bd6145b2b844e3630 | diff --git a/erpnext/e_commerce/doctype/e_commerce_settings/e_commerce_settings.py b/erpnext/e_commerce/doctype/e_commerce_settings/e_commerce_settings.py
index 1b0480bbf0de..1110eb1accd7 100644
--- a/erpnext/e_commerce/doctype/e_commerce_settings/e_commerce_settings.py
+++ b/erpnext/e_commerce/doctype/e_commerce_setti... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
frappe__erpnext-33005@404de1e | frappe/erpnext | Python | 33,005 | feat(pos): multiple item prices | - [x] show uom with product price
- [x] multiple item (variant) depending on uom | 2022-11-17T07:05:57Z | Barcode wise UOM not working in Point of Sale
### Information about bug
I have created 2 barcodes of one item in Item Barcode with 2 different UOM i.e., Nos, and Box.
The Barcode UOM is appearing fine if we scan the item barcode in a sales invoice, sales order, or stock entry is created; however, while scanning th... | [
{
"body": "### Information about bug\n\nI have created 2 barcodes of one item in Item Barcode with 2 different UOM i.e., Nos, and Box. \r\n\r\nThe Barcode UOM is appearing fine if we scan the item barcode in a sales invoice, sales order, or stock entry is created; however, while scanning the barcode in Point of... | 3598bcc9a85b79bf1db33f79982023cb658324ca | {
"head_commit": "404de1e65ac3f90201e537ef86c6de342a6c4b71",
"head_commit_message": "chore: format\n\nSigned-off-by: Sabu Siyad <hello@ssiyad.com>",
"patch_to_review": "diff --git a/erpnext/selling/page/point_of_sale/point_of_sale.py b/erpnext/selling/page/point_of_sale/point_of_sale.py\nindex 999ddc23f0c3..20017... | [
{
"diff_hunk": "@@ -17,45 +17,79 @@\n def search_by_term(search_term, warehouse, price_list):\n \tresult = search_for_serial_or_batch_or_barcode_number(search_term) or {}\n \n-\titem_code = result.get(\"item_code\") or search_term\n-\tserial_no = result.get(\"serial_no\") or \"\"\n-\tbatch_no = result.get(\"bat... | f9f9cdc3ee2e74aaaffe56d8001faa21dcbfe617 | diff --git a/erpnext/selling/page/point_of_sale/point_of_sale.py b/erpnext/selling/page/point_of_sale/point_of_sale.py
index 999ddc23f0c3..158ac1d049a5 100644
--- a/erpnext/selling/page/point_of_sale/point_of_sale.py
+++ b/erpnext/selling/page/point_of_sale/point_of_sale.py
@@ -17,45 +17,79 @@
def search_by_term(searc... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} | |
frappe__erpnext-28842@2813e5e | frappe/erpnext | Python | 28,842 | feat: new column 'Time taken to Deliver' in sales order analysis | ### Current Report
_'Sales Order Analysis'_ helps in quickly identifying billed amount, pending amount, delay in days and more information. Along with this a new column is added
### New Column - 'Time taken to Deliver'
This denotes the no of days taken to completely deliver an item. This helps in identifying bottl... | 2021-12-13T09:06:34Z | Include column for 'Days taken to deliver' in Sales Order Analysis Report
Currently, the Sales Order Analysis reflects the Delay in Days took them to deliver the Ordered Items, they want one more column to reflect how many days they take to completely deliver a Sales Order in order to increase the efficiency and get mo... | [
{
"body": "Currently, the Sales Order Analysis reflects the Delay in Days took them to deliver the Ordered Items, they want one more column to reflect how many days they take to completely deliver a Sales Order in order to increase the efficiency and get more productive accordingly.",
"number": 28753,
"... | 98d417602f77700b93f8eccd8d93ca27a5571887 | {
"head_commit": "2813e5ee2956f4667ecb9e02cb3a824c0fb7a0bd",
"head_commit_message": "feat: new column 'Time taken to Deliver' in sales order analysis",
"patch_to_review": "diff --git a/erpnext/selling/report/sales_order_analysis/sales_order_analysis.py b/erpnext/selling/report/sales_order_analysis/sales_order_ana... | [
{
"diff_hunk": "@@ -259,6 +264,12 @@ def get_columns(filters):\n \t\t\t\"fieldname\": \"delay\",\n \t\t\t\"fieldtype\": \"Data\",\n \t\t\t\"width\": 100\n+\t\t},\n+\t\t{\n+\t\t\t\"label\": _(\"Time Taken to Deliver\"),\n+\t\t\t\"fieldname\": \"time_taken_to_deliver\",\n+\t\t\t\"fieldtype\": \"Data\",",
"lin... | da67403bbd5dc5bd304648150b3dac466c6f354c | diff --git a/erpnext/selling/report/sales_order_analysis/sales_order_analysis.py b/erpnext/selling/report/sales_order_analysis/sales_order_analysis.py
index 82e5d0ce57d9..0c0acc76e399 100644
--- a/erpnext/selling/report/sales_order_analysis/sales_order_analysis.py
+++ b/erpnext/selling/report/sales_order_analysis/sales... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
frappe__erpnext-28822@c3453cd | frappe/erpnext | Python | 28,822 | feat: Deferred Revenue and Expense report with actual and upcoming postings | ### Deferred Revenue and Expense Report
This report aim to provide a simplified view of all deferred income/expense in a certain period. It can help in identifying the actual and expected posting.
### Deferred Revenue
<img width="1552" alt="def_revenue" src="https://user-images.githubusercontent.com/3272205/145595... | 2021-12-10T15:11:47Z | Deferred Accounting Report for Income and Expenses
### Problem Statement:
1. Since income and expenses are deferred, you don't come to know:
1. The actual income booked in a current month
2. The upcoming income which will be posted in coming months, as per start and end dat... | [
{
"body": "### Problem Statement:\r\n\r\n1. Since income and expenses are deferred, you don't come to know:\r\n 1. The actual income booked in a current month\r\n 2. The upcoming income which will be posted in coming months, as per start and end date\r\n4. The upcoming ex... | 5c4d3f89d2dd3102edeeb072b63f8ed5a0a22e13 | {
"head_commit": "c3453cd73c14d744264373bab4b2380b63470021",
"head_commit_message": "feat: Deferred Revenue and Expense report\n\n - show deferred revenue and expense with actual and expected postings\n - unit tests added",
"patch_to_review": "diff --git a/erpnext/accounts/report/deferred_revenue_and_expense/__in... | [
{
"diff_hunk": "@@ -0,0 +1,436 @@\n+# Copyright (c) 2013, Frappe Technologies Pvt. Ltd. and contributors\n+# License: MIT. See LICENSE\n+\n+import frappe\n+from frappe import qb\n+from frappe.query_builder import Column, functions\n+from frappe.utils import add_days, date_diff, flt, get_first_day, get_last_day,... | 64f68d5e94e70a6c457bee2fab95bda928d722c1 | diff --git a/erpnext/accounts/report/deferred_revenue_and_expense/__init__.py b/erpnext/accounts/report/deferred_revenue_and_expense/__init__.py
new file mode 100644
index 000000000000..e69de29bb2d1
diff --git a/erpnext/accounts/report/deferred_revenue_and_expense/deferred_revenue_and_expense.js b/erpnext/accounts/repo... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
frappe__erpnext-26949@6e6be15 | frappe/erpnext | Python | 26,949 | fix: Pricing Rule on Transaction Based on Coupon | > Pricing Rule creates for coupon-based get applied for all transition
Fixes #26948 | 2021-08-13T20:54:51Z | Transaction Pricing Rule get applied even if it a based-on coupon
## Description of the issue
- Pricing Rule created for coupon gets applied to all transactions without coupon is applied
## Steps to reproduce the issue
1. Create Pricing Rule for Coupon Based select Apply on Transaction, Price or Product Disc... | [
{
"body": "\r\n## Description of the issue\r\n\r\n- Pricing Rule created for coupon gets applied to all transactions without coupon is applied\r\n\r\n## Steps to reproduce the issue\r\n\r\n1. Create Pricing Rule for Coupon Based select Apply on Transaction, Price or Product Discount - Price\r\n2. In Any Documen... | a9852a54830a68f388956b972933dfac8aec78f9 | {
"head_commit": "6e6be156d028f571134223699ce281d134421b10",
"head_commit_message": "Merge branch 'develop' into develop",
"patch_to_review": "diff --git a/erpnext/accounts/doctype/pricing_rule/utils.py b/erpnext/accounts/doctype/pricing_rule/utils.py\nindex 94abf3b3c06f..96a7672c495a 100644\n--- a/erpnext/accoun... | [
{
"diff_hunk": "@@ -475,6 +475,10 @@ def apply_pricing_rule_on_transaction(doc):\n \t\t\t\t\t\tfrappe.msgprint(_(\"User has not applied rule on the invoice {0}\")\n \t\t\t\t\t\t\t.format(doc.name))\n \t\t\t\t\telse:\n+\t\t\t\t\t\tif d.coupon_code_based:\n+\t\t\t\t\t\t\tif not doc.get('coupon_code') or doc.get('... | bd71999d25687b062fcfec892a54dc57458a1ba5 | diff --git a/erpnext/accounts/doctype/pricing_rule/utils.py b/erpnext/accounts/doctype/pricing_rule/utils.py
index 94abf3b3c06f..5467cb0bc5b0 100644
--- a/erpnext/accounts/doctype/pricing_rule/utils.py
+++ b/erpnext/accounts/doctype/pricing_rule/utils.py
@@ -475,7 +475,20 @@ def apply_pricing_rule_on_transaction(doc):
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
frappe__erpnext-36668@fdf6e1b | frappe/erpnext | Python | 36,668 | fix: accounting dimensions required while creating POS Profile | **Issue:**
<img width="957" alt="image" src="https://github.com/frappe/erpnext/assets/65544983/e2c20632-3b56-4668-8d97-a53fd4ba4e29">
When closing a POS whilst having a Accounting Dimension mandatory for either P&L or BS, we get the above error.
<img width="1366" alt="image" src="https://github.com/frappe/erpnext/as... | 2023-08-16T06:22:10Z | POS Invoice merging doesn't pick the default accounting dimensions set in Accounting Dimension, or on the POS Profile
### Information about bug
1. Create an Accounting Dimension, e.g. Department
2. Tick Mandatory For Profit and Loss Account
3. Set Default Dimension value in the Dimension Defaults
4. In addition or ... | [
{
"body": "### Information about bug\n\n1. Create an Accounting Dimension, e.g. Department\r\n2. Tick Mandatory For Profit and Loss Account\r\n3. Set Default Dimension value in the Dimension Defaults\r\n4. In addition or as an alternative, set the Default Dimension value in the POS Profile, under Accounting Dim... | 2f7b3bbfad76948bd00e7087854502d61d8eab07 | {
"head_commit": "fdf6e1bd74f13ea8c7869a17c1fc2782c82a710c",
"head_commit_message": "chore: code cleanup",
"patch_to_review": "diff --git a/erpnext/accounts/doctype/accounting_dimension/accounting_dimension.py b/erpnext/accounts/doctype/accounting_dimension/accounting_dimension.py\nindex cfe5e6e80092..3a2c3cbeeb1... | [
{
"diff_hunk": "@@ -83,6 +87,11 @@ def on_submit(self):\n \t\tpos_invoice_docs = [\n \t\t\tfrappe.get_cached_doc(\"POS Invoice\", d.pos_invoice) for d in self.pos_invoices\n \t\t]\n+\t\taccounting_dimensions = get_accounting_dimensions()",
"line": null,
"original_line": 90,
"original_start_line": nu... | 9d8036ff8871fa41af2725aaed7f05ff3048dc0b | diff --git a/erpnext/accounts/doctype/accounting_dimension/accounting_dimension.py b/erpnext/accounts/doctype/accounting_dimension/accounting_dimension.py
index cfe5e6e80092..3a2c3cbeeb10 100644
--- a/erpnext/accounts/doctype/accounting_dimension/accounting_dimension.py
+++ b/erpnext/accounts/doctype/accounting_dimensi... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} | |
frappe__erpnext-29137@4535a7a | frappe/erpnext | Python | 29,137 | feat: Payment Terms Status report | ## Payment Terms Status Report
This report aims to provide current status of payment terms based on the associated invoices against the SO.
All invoices associated with Sales Order are fetched and assigned to terms in FIFO method. Statuses shown in the report are calculated at runtime and does not affect the state in... | 2022-01-04T13:13:00Z | Generate Invoice based on Payment Terms
Here are the points to be considered or challenges when creating a payment against a Payment Term:
**Challenge:**
Since the Amount in the Sales Invoice is determined based on Rate and Qty, in order to do 50% billing for an invoice (for eg.) we will have to set either qty to 50... | [
{
"body": "Here are the points to be considered or challenges when creating a payment against a Payment Term:\r\n**Challenge:** \r\nSince the Amount in the Sales Invoice is determined based on Rate and Qty, in order to do 50% billing for an invoice (for eg.) we will have to set either qty to 50% of rate to 50%.... | f89a64db486b46ac756d5ba62faee87f28baf889 | {
"head_commit": "4535a7a301f76fa3b867902f19e806dcb01bdb75",
"head_commit_message": "test: qty and rate changed to remove need for fractional Nos",
"patch_to_review": "diff --git a/erpnext/selling/report/payment_terms_status_for_sales_order/__init__.py b/erpnext/selling/report/payment_terms_status_for_sales_order... | [
{
"diff_hunk": "@@ -0,0 +1,211 @@\n+# Copyright (c) 2013, Frappe Technologies Pvt. Ltd. and contributors\n+# License: MIT. See LICENSE\n+\n+import frappe\n+from frappe import _, qb, query_builder\n+from frappe.query_builder import functions\n+\n+\n+def get_columns():\n+\tcolumns = [\n+\t\t{\n+\t\t\t\"label\": _... | 2f5bfcc0550d60d3e1b5c138d937dedefed36bba | diff --git a/erpnext/selling/report/payment_terms_status_for_sales_order/__init__.py b/erpnext/selling/report/payment_terms_status_for_sales_order/__init__.py
new file mode 100644
index 000000000000..e69de29bb2d1
diff --git a/erpnext/selling/report/payment_terms_status_for_sales_order/payment_terms_status_for_sales_ord... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
frappe__erpnext-22736@33bf057 | frappe/erpnext | Python | 22,736 | fix: reset homepage to home after unchecking products page | resets homepage back to home when "home page is products" is unchecked
fixes: #22733 | 2020-07-18T18:48:35Z | Turning on, then off "Homepage is Products" on the Products settings page does not revert back to Home Page
By default, ERPNext provides a landing page for the main index of the site. If you activate "Home Page is Products" under the Products Settings section, save it, then deactivate the "Home Page is Products" value... | I've made a fix for this. Please try and let me know if it works fine. | [
{
"body": "By default, ERPNext provides a landing page for the main index of the site. If you activate \"Home Page is Products\" under the Products Settings section, save it, then deactivate the \"Home Page is Products\" value, the site still acts as-if the feature is enabled. The expected behavior of this is... | d81372a39cb527aa4efb5591df07f1029bdb6dfd | {
"head_commit": "33bf0574a3bcb241283838bfd10bbcae473a844b",
"head_commit_message": "chore: fix get single value call\n\nSigned-off-by: Chinmay D. Pai <chinmaydpai@gmail.com>",
"patch_to_review": "diff --git a/erpnext/portal/doctype/products_settings/products_settings.py b/erpnext/portal/doctype/products_settings... | [
{
"diff_hunk": "@@ -40,4 +40,5 @@ def home_page_is_products(doc, method):\n \thome_page_is_products = cint(frappe.db.get_single_value('Products Settings', 'home_page_is_products'))\n \tif home_page_is_products:\n \t\tdoc.home_page = 'products'\n-\n+\telif doc.home_page == \"products\":",
"line": null,
"... | 3e503e44040e397fc16b7260830bd8279b7043f6 | diff --git a/erpnext/portal/doctype/products_settings/products_settings.py b/erpnext/portal/doctype/products_settings/products_settings.py
index 82afebf2f1e5..b984aeb67dfe 100644
--- a/erpnext/portal/doctype/products_settings/products_settings.py
+++ b/erpnext/portal/doctype/products_settings/products_settings.py
@@ -1... | {
"difficulty": "low",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
frappe__erpnext-29082@8d10322 | frappe/erpnext | Python | 29,082 | fix: wrong payment days in salary slip for employees joining/leaving during mid payroll dates | In case an employee joins/leaves mid payroll dates, their payment days would be calculated wrong.
This PR aims to consider joining and relieving dates while calculating payment days.
Closes #27943
Salary slip of an employee who joined 3 days after payroll start date and was present for the rest of the month:
<... | 2021-12-30T11:17:53Z | In Salary Slip, negative payment days issue for Left Employees.
**Description Of the Issue:**
In version 13.11.1 , When we created the salary slip against the left employees it shows negative payment days and Earning & Deduction table is not fetched for respective left employees.
**Version:**
version 13.11.1 | 
DESCRIPTION:
1)The employee is relieved in the date of 09-07-2021 , payment days for that employee is two days only , instead it shows -19 (negative value of payment day... | [
{
"body": "**Description Of the Issue:**\r\nIn version 13.11.1 , When we created the salary slip against the left employees it shows negative payment days and Earning & Deduction table is not fetched for respective left employees.\r\n**Version:**\r\nversion 13.11.1\r\n",
"number": 27943,
"title": "In S... | 385830bb51997fb2411a9ac0945a812b2bb47683 | {
"head_commit": "8d103224f1b777054356ceada3c86ea287ef5eee",
"head_commit_message": "chore: optimize comparission logic",
"patch_to_review": "diff --git a/erpnext/payroll/doctype/salary_slip/salary_slip.py b/erpnext/payroll/doctype/salary_slip/salary_slip.py\nindex b035292c0b6a..542d5c809833 100644\n--- a/erpnext... | [
{
"diff_hunk": "@@ -321,13 +321,25 @@ def get_working_days_details(self, joining_date=None, relieving_date=None, lwp=N\n \t\t\tself.payment_days = 0\n \n \tdef get_unmarked_days(self):\n-\t\tmarked_days = frappe.get_all(\"Attendance\", filters = {\n-\t\t\t\t\t\"attendance_date\": [\"between\", [self.start_date,... | d8e42085e707db829dac1a217dd3bd2ce010431d | diff --git a/erpnext/hr/doctype/attendance/attendance.py b/erpnext/hr/doctype/attendance/attendance.py
index b1eaaf8b5872..b1e373e21815 100644
--- a/erpnext/hr/doctype/attendance/attendance.py
+++ b/erpnext/hr/doctype/attendance/attendance.py
@@ -174,16 +174,22 @@ def get_month_map():
def get_unmarked_days(employee, m... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
frappe__erpnext-14770@c7c897b | frappe/erpnext | Python | 14,770 | on delete contact update issue | fixes https://github.com/frappe/frappe/issues/5724 | 2018-07-02T05:53:43Z | Missing tabIssue
Bug report
I installed only frappe without erpnext and created a new Contact. When I tried to delete it I got the error stated below. The error appears every time when deleting Contact. The operation needs table "Issue" which is in erpnext. The error does not appear when the erpnext is installed on ... | [
{
"body": "Bug report\r\n\r\nI installed only frappe without erpnext and created a new Contact. When I tried to delete it I got the error stated below. The error appears every time when deleting Contact. The operation needs table \"Issue\" which is in erpnext. The error does not appear when the erpnext is insta... | afe764264dcb42837b7e1ba8e8a2d52d664b443a | {
"head_commit": "c7c897bbd2194c631d8c0fe047cf7a00f6466d99",
"head_commit_message": "on delete contact update isuue\n\nremove contact from issue if the deleted contact exists",
"patch_to_review": "diff --git a/erpnext/custom_hooks/__init__.py b/erpnext/custom_hooks/__init__.py\nnew file mode 100644\nindex 0000000... | [
{
"diff_hunk": "@@ -0,0 +1,11 @@\n+#!/bin/env python",
"line": null,
"original_line": 1,
"original_start_line": null,
"path": "erpnext/custom_hooks/contacts.py",
"start_line": null,
"text": "@user1:\nput this in `issue.py`"
}
] | 137d046a5aa1a46c397dacad53ce1fb5e82d9338 | diff --git a/erpnext/hooks.py b/erpnext/hooks.py
index 5f1e7d4243c5..b5e130fe33a0 100644
--- a/erpnext/hooks.py
+++ b/erpnext/hooks.py
@@ -206,6 +206,9 @@
},
('Sales Invoice', 'Purchase Invoice', 'Delivery Note'): {
'validate': 'erpnext.regional.india.utils.set_place_of_supply'
+ },
+ "Contact":{
+ "on_trash": ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
frappe__erpnext-14127@e63e97f | frappe/erpnext | Python | 14,127 | Link Share Transfer to Account | Closes: #13415
 related data for the account entries. During a share transfer, corresponding accounting entries take place which affect the balance sheet. We can add the necessary accounts on this doctype ... | [
{
"body": "Can Share transfer doctype have two fields to show the accounts(Equity and Assets) related data for the account entries. During a share transfer, corresponding accounting entries take place which affect the balance sheet. We can add the necessary accounts on this doctype on which basis we can go ahea... | 967d04ed0df8783bf8f558ddbd957792c27ada47 | {
"head_commit": "e63e97fa656366520d6093c4ca4f96f784c33983",
"head_commit_message": "minor changes",
"patch_to_review": "diff --git a/erpnext/accounts/doctype/share_transfer/share_transfer.js b/erpnext/accounts/doctype/share_transfer/share_transfer.js\nindex fbf12e518d75..f280c5ddb2d6 100644\n--- a/erpnext/accoun... | [
{
"diff_hunk": "@@ -26,10 +31,74 @@ frappe.ui.form.on('Share Transfer', {\n \t\tif (frm.doc.no_of_shares != undefined || frm.doc.no_of_shares != null){\n \t\t\terpnext.share_transfer.update_amount(frm);\n \t\t}\n+\t},\n+\tcompany: async function(frm) {\n+\t\tif (frm.doc.company) {\n+\t\t\tlet currency = (await ... | a49c9f25601afdc05ec8acbf7b5188a3b6691c68 | diff --git a/erpnext/accounts/doctype/share_transfer/share_transfer.js b/erpnext/accounts/doctype/share_transfer/share_transfer.js
index fbf12e518d75..af23b2656de3 100644
--- a/erpnext/accounts/doctype/share_transfer/share_transfer.js
+++ b/erpnext/accounts/doctype/share_transfer/share_transfer.js
@@ -16,6 +16,11 @@ fr... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
frappe__erpnext-14249@96b5b5a | frappe/erpnext | Python | 14,249 | Stocking out items with expired batches | 
Closes: #12843 | 2018-05-28T09:07:51Z | Stocking Out Expired Batched Items
As per the current design, once item is expired, then no stock transaction is allowed for it. We will have to explicitly provide an option for the expired batched items to be stocked-out, so that expense could be booked for them.
May be allow selection of Expired batches only in t... | [
{
"body": "As per the current design, once item is expired, then no stock transaction is allowed for it. We will have to explicitly provide an option for the expired batched items to be stocked-out, so that expense could be booked for them. \r\n\r\nMay be allow selection of Expired batches only in the Stock Ent... | 30c88fe1a5d0e727e244e362fd2de7738fd6bf49 | {
"head_commit": "96b5b5af7bbfd838bce8873dcca0712ee9af9457",
"head_commit_message": "Add the fetched item details to stock entry details",
"patch_to_review": "diff --git a/erpnext/stock/doctype/stock_entry/stock_entry.js b/erpnext/stock/doctype/stock_entry/stock_entry.js\nindex 7452da8ea1b1..be66388c9d44 100644\n... | [
{
"diff_hunk": "@@ -1153,6 +1153,15 @@ def get_uom_details(item_code, uom, qty):\n \t\t}\n \treturn ret\n \n+@frappe.whitelist()\n+def get_expired_batch_items():\n+\treturn frappe.db.sql(\"\"\"select b.item, sum(sle.actual_qty) as qty, sle.warehouse, sle.stock_uom\\",
"line": null,
"original_line": 1158... | 857ef2488b03faa2c3ff7a2ee7660256039600aa | diff --git a/erpnext/stock/doctype/stock_entry/stock_entry.js b/erpnext/stock/doctype/stock_entry/stock_entry.js
index 7452da8ea1b1..d9e504bc12c2 100644
--- a/erpnext/stock/doctype/stock_entry/stock_entry.js
+++ b/erpnext/stock/doctype/stock_entry/stock_entry.js
@@ -156,6 +156,29 @@ frappe.ui.form.on('Stock Entry', {
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
frappe__erpnext-13263@28c98a5 | frappe/erpnext | Python | 13,263 | [Feature] Advance Account Balance in Employee Advance | fixes #13054
| 2018-03-10T11:48:12Z | Advance Account Balance in Employee Advance
Hi,
Please add a field in Employee Advance to show the balance on the Employee's Advance Account. This is information that the approver usually needs to see before making a decision to approve or not
Thanks | [
{
"body": "Hi,\r\n\r\nPlease add a field in Employee Advance to show the balance on the Employee's Advance Account. This is information that the approver usually needs to see before making a decision to approve or not\r\n\r\nThanks",
"number": 13054,
"title": "Advance Account Balance in Employee Advance... | fd75d554d20921c0c5b1a213f1f82d61a1bb4333 | {
"head_commit": "28c98a52476181ffb82795bd6166ff22c0bb38d5",
"head_commit_message": "fixes codacy",
"patch_to_review": "diff --git a/erpnext/hr/doctype/employee_advance/employee_advance.js b/erpnext/hr/doctype/employee_advance/employee_advance.js\nindex b6dd7eeb3f79..8ae24d3e4fa4 100644\n--- a/erpnext/hr/doctype/... | [
{
"diff_hunk": "@@ -53,6 +53,10 @@ def set_total_advance_paid(self):\n \t\tself.set_status()\n \t\tfrappe.db.set_value(\"Employee Advance\", self.name , \"status\", self.status)\n \n+\tdef get_due_advance_amount(self):",
"line": null,
"original_line": 56,
"original_start_line": null,
"path": "er... | 96b2d09443706d5be90ac2eab854ade196eca468 | diff --git a/erpnext/hr/doctype/employee_advance/employee_advance.js b/erpnext/hr/doctype/employee_advance/employee_advance.js
index b6dd7eeb3f79..a9407be435e5 100644
--- a/erpnext/hr/doctype/employee_advance/employee_advance.js
+++ b/erpnext/hr/doctype/employee_advance/employee_advance.js
@@ -81,5 +81,18 @@ frappe.ui.... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
frappe__erpnext-28580@a9c179f | frappe/erpnext | Python | 28,580 | feat: Bulk Transaction Processing | **Before this Feature**
Lets take an example to get better idea
1. If the user had to create multiple sales invoice from multiple sales order it had to be done one by one by going into the particular sales order and then create sales invoice against it which consumed a lot of time.Similarly this was the case for ma... | 2021-11-26T08:22:00Z | Bulk Transaction Processing
Problem Statement:
Allow to create bulk transactions to process multiple invoices/DN from Sales Order. Likewise for other common flows (PR/PI from PO).
Expected Solution:
Use bulk actions in list view to give options to create transactions in one go. This will save time in processing mu... | [
{
"body": "Problem Statement:\r\nAllow to create bulk transactions to process multiple invoices/DN from Sales Order. Likewise for other common flows (PR/PI from PO).\r\n\r\nExpected Solution:\r\nUse bulk actions in list view to give options to create transactions in one go. This will save time in processing mul... | 79ab8e645931803eb5ed844683f9923ab3555ec9 | {
"head_commit": "a9c179f0d937d02fabe7f02825a573de0988de2e",
"head_commit_message": "fix: add flags to ignore validations and exception handling correction",
"patch_to_review": "diff --git a/erpnext/accounts/doctype/purchase_invoice/purchase_invoice_list.js b/erpnext/accounts/doctype/purchase_invoice/purchase_inv... | [
{
"diff_hunk": "@@ -0,0 +1,128 @@\n+import json\n+\n+import frappe\n+\n+\n+@frappe.whitelist()\n+def transaction_processing(data, to_create):\n+\tdeserialized_data = json.loads(data)\n+\tlength_of_data = len(deserialized_data)\n+\n+\tif length_of_data > 10:\n+\t\t# frappe.msgprint(\"Started a background job to ... | 36b818c0194a18579cc75ac7cb2a981640de6308 | diff --git a/cypress/integration/test_bulk_transaction_processing.js b/cypress/integration/test_bulk_transaction_processing.js
new file mode 100644
index 000000000000..428ec5100b53
--- /dev/null
+++ b/cypress/integration/test_bulk_transaction_processing.js
@@ -0,0 +1,44 @@
+describe("Bulk Transaction Processing", () =>... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
frappe__erpnext-24879@a2e4564 | frappe/erpnext | Python | 24,879 | fix: Loan Repayment entry cancellation on salary slip cancel | Closes: https://github.com/frappe/erpnext/issues/24543 | 2021-03-15T05:13:58Z | Canceling and deleting a draft salary slip should reset loan repayments-v13-beta
To replicate:
- Create an employee loan, disburse, then run loan interest accrual.
- Create a salary slip via payroll entry, or manually. The salary slip will pick the loan.
- Now, delete the salary slip.
- On creating the salary sli... | [
{
"body": "To replicate:\r\n\r\n- Create an employee loan, disburse, then run loan interest accrual.\r\n- Create a salary slip via payroll entry, or manually. The salary slip will pick the loan.\r\n- Now, delete the salary slip.\r\n- On creating the salary slip again, it won't pick the load repayment.",
"nu... | d77ea7c88bd114e8ca14ffc1f590b2febe35ed6b | {
"head_commit": "a2e45644644651d3e5d6be41f93d7d3087886ce2",
"head_commit_message": "fix: Prevent non sequential repayment entries",
"patch_to_review": "diff --git a/erpnext/loan_management/doctype/loan_repayment/loan_repayment.py b/erpnext/loan_management/doctype/loan_repayment/loan_repayment.py\nindex bac06c4e9... | [
{
"diff_hunk": "@@ -30,6 +31,7 @@ def before_submit(self):\n \tdef on_submit(self):\n \t\tself.update_paid_amount()\n \t\tself.make_gl_entries()\n+\t\t#self.repost_future_loan_interest_accruals()",
"line": null,
"original_line": 34,
"original_start_line": null,
"path": "erpnext/loan_management/d... | 5af6aea9f9a94e8b77372002ddcd5180603ee079 | diff --git a/erpnext/loan_management/doctype/loan_repayment/loan_repayment.py b/erpnext/loan_management/doctype/loan_repayment/loan_repayment.py
index a88e183eadae..5d57cedb4198 100644
--- a/erpnext/loan_management/doctype/loan_repayment/loan_repayment.py
+++ b/erpnext/loan_management/doctype/loan_repayment/loan_repaym... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
oumi-ai__oumi-1678@48f4578 | oumi-ai/oumi | Python | 1,678 | add debug logging capabilities to collators | # Description
<!--
Thank you for contributing to Oumi! Before sending your PR out for review, please take a quick read through this template.
When your PR is merged, its title will appear in our release notes. Make sure your title gives a clear description of your change!
After you've updated your title, plea... | 2025-05-09T20:50:10Z | [Feature] Output tokenized example for debugging during training
### Feature request
When running training, it'd be useful to log a single example from the dataset that has been tokenized for debugging.
For example:
1. Take the first example or batch in the training set (peek the top of the dataloader?)
2. Print all ... | in addition to text output (`print()`) , it may also be useful to write the information into e.g., a nicely-formatted HTML file
Hi @nikg4, I would like to work on this issue if it is still active!
@aniruddh-alt of course! | [
{
"body": "### Feature request\n\nWhen running training, it'd be useful to log a single example from the dataset that has been tokenized for debugging.\n\nFor example:\n1. Take the first example or batch in the training set (peek the top of the dataloader?)\n2. Print all the following:\na. Raw Example\nb. Forma... | 91f6790e5b84d477ded019533717167dc2c03755 | {
"head_commit": "48f457867c52da2286437aaff27e9e60f8971ecd",
"head_commit_message": "Merge branch 'main' into fix/1369-debug-token-logging",
"patch_to_review": "diff --git a/src/oumi/builders/collators.py b/src/oumi/builders/collators.py\nindex 592951a3c..46b3a92bc 100644\n--- a/src/oumi/builders/collators.py\n++... | [
{
"diff_hunk": "@@ -0,0 +1,95 @@\n+import datetime\n+import json\n+import uuid\n+from pathlib import Path\n+from typing import Any\n+\n+from oumi.utils.logging import logger\n+\n+\n+def log_example_for_debugging(\n+ raw_example: Any,\n+ formatted_example: str,\n+ tokenized_example: list[tuple[int, str]... | bb48a41ac9deaac0220874bf93e6a75d2cf12957 | diff --git a/src/oumi/builders/collators.py b/src/oumi/builders/collators.py
index c373564cc9..32b974e7d4 100644
--- a/src/oumi/builders/collators.py
+++ b/src/oumi/builders/collators.py
@@ -40,6 +40,7 @@ def build_data_collator(
*,
max_length: Optional[int],
label_ignore_index: Optional[int] = constants... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
frappe__erpnext-8869@50be447 | frappe/erpnext | Python | 8,869 | Issue 8842 | Fixes #8842. I also added a test for the issue and `encode_company_abbr` | 2017-05-16T13:21:11Z | Warehouse Renaming Issue
Hi,
There's an issue when trying to rename a warehouse to something that has a hyphen like 'New - Name'. Let's assume company abbreviation is ABC. The new ID is supposed to be New - Name - ABC but instead, the system names it as New - ABC
Kindly help resolve
Thanks | Hello @Olawale1
It seems like you are deleting the `- [abbreviation]` in the name field. Is there any special reason for doing that?
Hi @tundebabzy
Thanks for your response. I'm not deleting anything... the system is deleting the part of the name after the first hyphen as explained in my post. That's the bug bein... | [
{
"body": "Hi,\r\n\r\nThere's an issue when trying to rename a warehouse to something that has a hyphen like 'New - Name'. Let's assume company abbreviation is ABC. The new ID is supposed to be New - Name - ABC but instead, the system names it as New - ABC\r\n\r\nKindly help resolve\r\n\r\nThanks",
"number"... | 3bd15fb19e2ab3eb7dda91b8eb4c0da595d6df24 | {
"head_commit": "50be44783a20befcb2f8f841c9fac9d70ed8caa7",
"head_commit_message": "fixes failing test",
"patch_to_review": "diff --git a/__init__.py b/__init__.py\nnew file mode 100644\nindex 000000000000..e69de29bb2d1\ndiff --git a/erpnext/__init__.py b/erpnext/__init__.py\nindex 6f73741e8561..442050d4c9dd 100... | [
{
"diff_hunk": "@@ -1,2 +1,3 @@\n frappe\n unidecode\n+six",
"line": null,
"original_line": 3,
"original_start_line": null,
"path": "requirements.txt",
"start_line": null,
"text": "@user1:\nwhy another library? why not using python's inbuilt `range` or `xrange`?"
}
] | 09134d40c79f2a03a884a68434a2e39bf4f2ed8a | diff --git a/__init__.py b/__init__.py
new file mode 100644
index 000000000000..e69de29bb2d1
diff --git a/erpnext/__init__.py b/erpnext/__init__.py
index 6f73741e8561..442050d4c9dd 100644
--- a/erpnext/__init__.py
+++ b/erpnext/__init__.py
@@ -4,6 +4,7 @@
__version__ = '8.0.26'
+
def get_default_company(user=None... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
oumi-ai__oumi-1406@990a9b7 | oumi-ai/oumi | Python | 1,406 | Add a Slurm cluster and cloud to the oumi launcher. | # Description
<!--
Thank you for contributing to Oumi! Before sending your PR out for review, please take a quick read through this template.
When your PR is merged, its title will appear in our release notes. Make sure your title gives a clear description of your change!
After you've updated your title, plea... | 2025-02-07T02:47:24Z | [Feature] Add Slurm support in Oumi Launch
### Feature request
We should add support for sshing into a slurm head node and kicking off jobs. This is great for local and dedicated clusters.
### Motivation / references
This greatly simplifies workflows with Oumi when working on local clusters that are already running ... | [
{
"body": "### Feature request\n\nWe should add support for sshing into a slurm head node and kicking off jobs. This is great for local and dedicated clusters.\n\n### Motivation / references\n\nThis greatly simplifies workflows with Oumi when working on local clusters that are already running slurm.\n\n### Your... | 407d02e3c0e5ab4dc3e3ce3c70daf47fa5b8be9a | {
"head_commit": "990a9b7078f2b431ed0f1ca4ee91b869154bd779",
"head_commit_message": "Merge branch 'main' into taenin/slurm_cluster",
"patch_to_review": "diff --git a/src/oumi/cli/env.py b/src/oumi/cli/env.py\nindex 32dbd2524..c4e93e766 100644\n--- a/src/oumi/cli/env.py\n+++ b/src/oumi/cli/env.py\n@@ -80,6 +80,7 @... | [
{
"diff_hunk": "@@ -0,0 +1,158 @@\n+# Copyright 2025 - Oumi\n+#\n+# Licensed under the Apache License, Version 2.0 (the \"License\");\n+# you may not use this file except in compliance with the License.\n+# You may obtain a copy of the License at\n+#\n+# http://www.apache.org/licenses/LICENSE-2.0\n+#\n+# Un... | 46a054afa2d99a2dc0d67e852c86ab2f81150565 | diff --git a/src/oumi/cli/env.py b/src/oumi/cli/env.py
index 32dbd25249..c4e93e766a 100644
--- a/src/oumi/cli/env.py
+++ b/src/oumi/cli/env.py
@@ -80,6 +80,7 @@ def env():
"LOCAL_RANK",
"LOCAL_WORLD_SIZE",
"OUMI_EXTRA_DEPS_FILE",
+ "OUMI_SLURM_CONNECTIONS",
... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
oumi-ai__oumi-1422@3340d02 | oumi-ai/oumi | Python | 1,422 | Updated oumi infer to support CLI argument for system prompt | # Description
This change adds an optional argument for ```system_prompt``` in the CLI for the interactive mode. The two tests have been added that test this change with and without image as an input.
<!--
Thank you for contributing to Oumi! Before sending your PR out for review, please take a quick read through thi... | 2025-02-11T17:46:19Z | [Feature] Update `oumi infer` to support CLI argument for system prompt
### Feature request
Add a new command line argument for `oumi infer` command
### Motivation / references
Users may want to adjust system prompt for task-specific instructions
### Your contribution
I can help with code review, and can answer... | @xrdaukar hello! I would like to work on this. I do understand where and how I will add the code for accepting a system-prompt, but then where am I supposed to use this input? I suppose it shall be a part of the ```InferenceConfig```?
Thanks.
Thank you @Spaarsh ! I think, at minimum, we can add a new `system_prompt`... | [
{
"body": "### Feature request\n\nAdd a new command line argument for `oumi infer` command\n\n\n\n### Motivation / references\n\nUsers may want to adjust system prompt for task-specific instructions\n\n### Your contribution\n\nI can help with code review, and can answer questions\n\n\nTowards OPE-1019",
"n... | 20faca9b0f8a07bbf06c9f1c5876380086583f2a | {
"head_commit": "3340d02597ca7be20001d125cf0eccdfe7edfd05",
"head_commit_message": "Merge branch 'main' into 1386/enhancement/add-system-prompt-argument-in-oumi-infer",
"patch_to_review": "diff --git a/src/oumi/__init__.py b/src/oumi/__init__.py\nindex cf70b6580..e9eef515d 100644\n--- a/src/oumi/__init__.py\n+++... | [
{
"diff_hunk": "@@ -93,15 +99,21 @@ def infer(\n # Pass None if no conversations are provided.\n conversations = None\n if inputs is not None and len(inputs) > 0:\n+ base_message = []",
"line": null,
"original_line": 102,
"original_start_line": null,
"path": "src/oumi/infer.py... | 1c85353decc65a867871783c5a9069c08ec1679b | diff --git a/src/oumi/__init__.py b/src/oumi/__init__.py
index cf70b65808..e9eef515dc 100644
--- a/src/oumi/__init__.py
+++ b/src/oumi/__init__.py
@@ -124,12 +124,17 @@ def evaluate(config: EvaluationConfig) -> list[dict[str, Any]]:
def infer_interactive(
- config: InferenceConfig, *, input_image_bytes: bytes |... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
oumi-ai__oumi-1439@3a61935 | oumi-ai/oumi | Python | 1,439 | Added fetch command and modified infer command to resolve oumi:// | # Description
<!--
Thank you for contributing to Oumi! Before sending your PR out for review, please take a quick read through this template.
When your PR is merged, its title will appear in our release notes. Make sure your title gives a clear description of your change!
After you've updated your title, plea... | 2025-02-17T15:32:15Z | [Feature] Add a new "oumi fetch" command to pull configs via the CLI
### Feature request
Create a new CLI command `oumi fetch` that will download configs from the oumi github repo to a local directory specified by an environment variable.
Any CLI actions using the `oumi://` prefix will look for the config in that fo... | I recently worked on a CLI related issue so the steps for this issue seem clear to me. Can this be assigned to me? I already have the code for this (I was just playing around to see if my process was correct😅)
Definitely, thanks for volunteering, @Spaarsh ! Let me know if you have any questions about this task! | [
{
"body": "### Feature request\n\nCreate a new CLI command `oumi fetch` that will download configs from the oumi github repo to a local directory specified by an environment variable.\n\nAny CLI actions using the `oumi://` prefix will look for the config in that folder.\n\n\n\n### Motivation / references\n\nThi... | a5f4be09d8e1c72ac1f2eec87ccdd2bb832a9d2d | {
"head_commit": "3a61935f9ea3b55faffe08de6a029b3b68829533",
"head_commit_message": "Adding fetch registration test",
"patch_to_review": "diff --git a/src/oumi/cli/cli_utils.py b/src/oumi/cli/cli_utils.py\nindex c890b1dbc..d32e78681 100644\n--- a/src/oumi/cli/cli_utils.py\n+++ b/src/oumi/cli/cli_utils.py\n@@ -15,... | [
{
"diff_hunk": "@@ -137,3 +138,46 @@ def set_log_level(level: Optional[LogLevel]):\n callback=set_log_level,\n ),\n ]\n+\n+\n+def resolve_oumi_prefix(\n+ config_path: str, output_dir: Optional[Path] = None\n+) -> tuple[str, Path]:\n+ \"\"\"Resolves oumi:// prefix and determines output director... | 126578417979b7a3110f19d80674336718393a9f | diff --git a/src/oumi/cli/cli_utils.py b/src/oumi/cli/cli_utils.py
index c890b1dbc8..b64dded85c 100644
--- a/src/oumi/cli/cli_utils.py
+++ b/src/oumi/cli/cli_utils.py
@@ -15,6 +15,7 @@
import logging
import os
from enum import Enum
+from pathlib import Path
from typing import Annotated, Optional
import typer
@@ ... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
skypilot-org__skypilot-6221@dbf1369 | skypilot-org/skypilot | Python | 6,221 | Fix db init race condition | <!-- Describe the changes in this PR -->
Close https://github.com/skypilot-org/skypilot/issues/6220
<!-- Describe the tests ran -->
<!-- Unit tests (tests/test_*.py) are part of GitHub CI; below are tests that launch on the cloud. -->
Tested (run the relevant ones):
- [x] Code formatting: install pre-commi... | 2025-07-10T16:50:35Z | [Core] DB init race condition
```
def initialize_and_get_db() -> sqlalchemy.engine.Engine:
global _SQLALCHEMY_ENGINE
if _SQLALCHEMY_ENGINE is not None:
return _SQLALCHEMY_ENGINE
with _DB_INIT_LOCK:
if _SQLALCHEMY_ENGINE is None:
```
Problematic timeline:
```
thread 1 -> AcquireLock -> set ... | [
{
"body": "```\ndef initialize_and_get_db() -> sqlalchemy.engine.Engine:\n global _SQLALCHEMY_ENGINE\n if _SQLALCHEMY_ENGINE is not None:\n return _SQLALCHEMY_ENGINE\n with _DB_INIT_LOCK:\n if _SQLALCHEMY_ENGINE is None:\n```\n\nProblematic timeline:\n\n```\nthread 1 -> AcquireLock -> set... | c7b073165d36ed85f3b83df6624b439bd38b60fa | {
"head_commit": "dbf13691b5adee71f38ad1ead817564e63202741",
"head_commit_message": "Fix\n\nSigned-off-by: Aylei <rayingecho@gmail.com>",
"patch_to_review": "diff --git a/sky/global_user_state.py b/sky/global_user_state.py\nindex 6559b6a0ccc..14543ef75fa 100644\n--- a/sky/global_user_state.py\n+++ b/sky/global_us... | [
{
"diff_hunk": "@@ -1,12 +1,66 @@\n import sys\n+import threading\n+from unittest import mock\n \n import pytest\n \n import sky\n+from sky import global_user_state\n \n \n @pytest.mark.skipif(sys.platform != 'linux', reason='Only test in CI.')\n def test_enabled_clouds_empty():\n # In test environment, no ... | 72f76401cdc2a9a599bad4f746eb3393cc738882 | diff --git a/sky/global_user_state.py b/sky/global_user_state.py
index 6559b6a0ccc..14543ef75fa 100644
--- a/sky/global_user_state.py
+++ b/sky/global_user_state.py
@@ -220,17 +220,16 @@ def replace_char_class(match):
return like_pattern
-def create_table():
+def create_table(engine: sqlalchemy.engine.Engine):... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} | |
oumi-ai__oumi-66@9613e04 | oumi-ai/oumi | Python | 66 | Add text_col param that's required for SFTTrainer | - Replaced the usage of `data.trainer_kwargs["dataset_text_field"]` with `data.text_col` since it's a required field for SFTTrainer
- Changed the default TrainerType to HF. IMO this is more logical as a default value. More practically, I made `text_col` a required field for SFTTrainer, making it not possible to do `Tr... | 2024-06-07T07:30:24Z | trainer_kwargs: avoid listing in config.data
The `trainer_kwargs` seems better fitting to go under training and not data. There is a subtle param listed there `dataset_text_field` which is applicable also on the inference side since it affects the loaders of the data. | I've been wondering about this as well. What about putting dataset_text_field under DataParams? That feels more logical to me. | [
{
"body": "The `trainer_kwargs` seems better fitting to go under training and not data. There is a subtle param listed there `dataset_text_field` which is applicable also on the inference side since it affects the loaders of the data.",
"number": 61,
"title": "trainer_kwargs: avoid listing in config.dat... | 83b17dd5b9fe614b4f67367abe1a8835690b0309 | {
"head_commit": "9613e046970e3bbabfc7f35128d184a616da1c18",
"head_commit_message": "Add text_col param that's required for SFTTrainer",
"patch_to_review": "diff --git a/.vscode/launch.json b/.vscode/launch.json\nindex 669b90841..5af7366cc 100644\n--- a/.vscode/launch.json\n+++ b/.vscode/launch.json\n@@ -9,10 +9,... | [
{
"diff_hunk": "@@ -27,12 +27,13 @@\n },\n \"source\": [\n \"#### 1. Setting up read-only github token\\n\",\n- \"Since the Github repository is private, we need to generate a `read-only` user token scoped for the `lema` repo.\\n\",\n- \"1. In Github.com, go to `Settings -> Developer settings ->... | cf87fa367213f0b38ee390908791a660e51e1697 | diff --git a/.vscode/launch.json b/.vscode/launch.json
index 669b90841f..5af7366ccf 100644
--- a/.vscode/launch.json
+++ b/.vscode/launch.json
@@ -9,10 +9,12 @@
"args": [
"data.dataset_name=yahma/alpaca-cleaned",
"data.preprocessing_function_name=alpaca",
- ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Code Refactoring / Architectural Improvement"
} |
skypilot-org__skypilot-5838@891923b | skypilot-org/skypilot | Python | 5,838 | [UX] Improve error message when one node fails | <!-- Describe the changes in this PR -->
Fixes #4232. Prints:
> ERROR: Job X failed with return code list: [137, 1, 137 137] (A worker failed with return code 1, SkyPilot cleaned up the processes on other nodes with return code 137)
<!-- Describe the tests ran -->
Manually ran with a yaml file that runs `exit... | 2025-06-02T22:14:42Z | [Core/UX] Improve the display of returncode for multi-node
<!-- Describe the bug report / feature request here -->
When a user's job is running on multiple nodes and one node fails with a return code, e.g. 1, SkyPilot will kill the processes on the other nodes, with a return code 137. It is confusing to users to see... | [
{
"body": "<!-- Describe the bug report / feature request here -->\r\n\r\nWhen a user's job is running on multiple nodes and one node fails with a return code, e.g. 1, SkyPilot will kill the processes on the other nodes, with a return code 137. It is confusing to users to see a list of return code like the foll... | f54f8eae7b1edb76c7fc3ef3be42dc833642b120 | {
"head_commit": "891923bad03945f386e7f401b192648670f14fc4",
"head_commit_message": "Removed rank number",
"patch_to_review": "diff --git a/sky/backends/cloud_vm_ray_backend.py b/sky/backends/cloud_vm_ray_backend.py\nindex 147a08e63d5..cfae58e65a3 100644\n--- a/sky/backends/cloud_vm_ray_backend.py\n+++ b/sky/back... | [
{
"diff_hunk": "@@ -699,6 +699,11 @@ def add_epilogue(self) -> None:\n # 139 is the return code of SIGSEGV, i.e. Segmentation Fault.\n if any(r == 139 for r in returncodes):\n reason = '(likely due to Segmentation Fault)'\n+ if any(r == 137 for ... | 3d057ae4f8475bc4d63bfcfa386a86995c6c8dfd | diff --git a/sky/backends/cloud_vm_ray_backend.py b/sky/backends/cloud_vm_ray_backend.py
index 147a08e63d5..04e523dbfa1 100644
--- a/sky/backends/cloud_vm_ray_backend.py
+++ b/sky/backends/cloud_vm_ray_backend.py
@@ -699,6 +699,10 @@ def add_epilogue(self) -> None:
# 139 is the return code of SIGSEGV, ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
skypilot-org__skypilot-5926@372ba7c | skypilot-org/skypilot | Python | 5,926 | [k8s] Better GPU Label Formatter Support for CoreWeave | <!-- Describe the changes in this PR -->
Fixes #5628
so if I add the invalid node labels to a GKE cluster, then I can properly see that the coreweave gpu label formatter is being picked up. For obvious reasons, `show-gpus` fail (as the cluster doesn't actually have H100 gpus with that label).
<!-- Describe the... | 2025-06-09T13:30:05Z | [k8s] Handle invalid formats in GPU label formatter detection
A user had a Coreweave cluster with both GKE and CoreWeave labels
```
cloud.google.com/gke-accelerator=H100_NVLINK_80GB
gpu.nvidia.com/class=H100_NVLINK_80GB
gpu.nvidia.com/count=8
... | @romilbhardwaj @kyuds I was able to successfully launch a SkyPilot cluster on a CoreWeave Kubernetes cluster, but I had to do a few hacky things. I'm sure you can find a better solution for SkyPilot.
1. I ran into a similar invalid GKE cluster accelerator name error, so I put the `CoreWeaveLabelFormatter` at the start... | [
{
"body": "A user had a Coreweave cluster with both GKE and CoreWeave labels\n```\n cloud.google.com/gke-accelerator=H100_NVLINK_80GB\n gpu.nvidia.com/class=H100_NVLINK_80GB\n gpu.nvidia.com/count=8\n gpu.nvidia.com/model=H100_NVLINK_80... | 1e6d2a58148b13e238edd1a47a56b50266da25b8 | {
"head_commit": "372ba7c5c5a943fb184807b71e7e073d97b856b3",
"head_commit_message": "simple fix",
"patch_to_review": "diff --git a/sky/provision/kubernetes/utils.py b/sky/provision/kubernetes/utils.py\nindex 0b792bfaad5..3dbfd18f6a1 100644\n--- a/sky/provision/kubernetes/utils.py\n+++ b/sky/provision/kubernetes/u... | [
{
"diff_hunk": "@@ -564,17 +572,29 @@ def detect_gpu_label_formatter(\n for label, value in node.metadata.labels.items():\n node_labels[node.metadata.name].append((label, value))\n \n- label_formatter = None\n-\n # Check if the node labels contain any of the GPU label prefixes\n f... | 2a8b156f8bc8091ab2c9ccff895293054e08743b | diff --git a/sky/provision/kubernetes/utils.py b/sky/provision/kubernetes/utils.py
index 5931ce88f83..e3d1e937766 100644
--- a/sky/provision/kubernetes/utils.py
+++ b/sky/provision/kubernetes/utils.py
@@ -461,6 +461,14 @@ def get_accelerator_from_label_value(cls, value: str) -> str:
raise ValueError(
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
skypilot-org__skypilot-5812@54d7185 | skypilot-org/skypilot | Python | 5,812 | [k8s] Wait for apt installation to complete before proceeding with setup | As a part of nimbus (https://github.com/skypilot-org/skypilot/pull/4393) we parallelized dependency setup in the k8s pods. However, we did not add a wait for SSH setup to complete. Waiting for SSH is critical for rsync operations to succeed.
A recent archive.ubuntu.com outage caused delayed SSH installs, resulting i... | 2025-05-29T21:16:31Z | [k8s] `sky launch --infra k8s --image-id continuumio/miniconda3:latest` experience undeterministic ssh issue
```
E 05-28 23:26:07 sdk.py:1599] Using Python 3.10.17 environment at: /root/skypilot-runtime
--
| E 05-28 23:26:07 sdk.py:1599] skypilot 1.0.0.dev0
| E 05-28 23:26:07 sdk.py:1599] === Skypi... | Looks like archive.ubuntu.com has been having issues, causing SSH install to fail:
```
Get:32 http://security.ubuntu.com/ubuntu noble-updates/main amd64 openssh-server amd64 1:9.6p1-3ubuntu13.11 [509 kB]
Get:42 http://security.ubuntu.com/ubuntu noble-updates/main amd64 libglib2.0-0t64 amd64 2.80.0-6ubuntu3.4 [1544 kB]... | [
{
"body": "```\nE 05-28 23:26:07 sdk.py:1599] Using Python 3.10.17 environment at: /root/skypilot-runtime\n--\n | E 05-28 23:26:07 sdk.py:1599] skypilot 1.0.0.dev0\n | E 05-28 23:26:07 sdk.py:1599] === Skypilot wheel installation completed in 0 secs ===\n | E 05-28 23:26:07 sdk.py:1599] Defa... | f3edb2141cf7bfea30c552e2812c14f56d7149ab | {
"head_commit": "54d7185ad080b6e99c6e93c0c6b380d73c701e32",
"head_commit_message": "Remove mirror update",
"patch_to_review": "diff --git a/sky/templates/kubernetes-ray.yml.j2 b/sky/templates/kubernetes-ray.yml.j2\nindex f2de21cc091..0c8e9ccee1e 100644\n--- a/sky/templates/kubernetes-ray.yml.j2\n+++ b/sky/templa... | [
{
"diff_hunk": "@@ -395,14 +395,21 @@ available_node_types:\n # STEP 1: Run apt update, install missing packages, and set up ssh.\n (\n (\n+ # For backwards compatibility, we put a marker file in the pod\n+ # to indicate that the apt ssh ... | 3d4b4df29041c8724e7923ddd2e7c78e4ac07bc7 | diff --git a/sky/templates/kubernetes-ray.yml.j2 b/sky/templates/kubernetes-ray.yml.j2
index f2de21cc091..70fa6db2c30 100644
--- a/sky/templates/kubernetes-ray.yml.j2
+++ b/sky/templates/kubernetes-ray.yml.j2
@@ -395,6 +395,13 @@ available_node_types:
# STEP 1: Run apt update, install missing packages, a... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
skypilot-org__skypilot-5602@79d0b57 | skypilot-org/skypilot | Python | 5,602 | [UX] Support `--infra` option and deprecate `cloud/region/zone` | <!-- Describe the changes in this PR -->
This PR updates the UX for the output, and add support for infra
Also, fixes #5600
## Main changes
1. Support `--infra` and deprecate `--cloud`, `--region`, and `--zone`
2. Show `INFRA` in outputs instead of cloud/region/zone
3. Reorder/polishing table outputs
```
... | 2025-05-16T16:47:08Z | [UX] Failover reason table has too narrow width
```
resources:
accelerators: { H100:8, A100-80GB:8 }
cpus: 32+
disk_size: 512 # Ensure model checkpoints can fit.
disk_tier: best
ports: 8081 # Expose to internet traffic.
```
Launching the above on RunPod:
```
⨯ Failed to provision resources. View logs: sky ... | [
{
"body": "```\nresources:\n accelerators: { H100:8, A100-80GB:8 }\n cpus: 32+\n disk_size: 512 # Ensure model checkpoints can fit.\n disk_tier: best\n ports: 8081 # Expose to internet traffic.\n```\nLaunching the above on RunPod:\n\n```\n⨯ Failed to provision resources. View logs: sky api logs -l sky-20... | 6801ad4f316d6be31fe15b324b0c443495c5f1a2 | {
"head_commit": "79d0b570d047a044f2a35d4cbc26a44aacc5b379",
"head_commit_message": "Add escape",
"patch_to_review": "diff --git a/docs/source/cloud-setup/cloud-permissions/aws.rst b/docs/source/cloud-setup/cloud-permissions/aws.rst\nindex 91e4eea2d5d..8a25b67756d 100644\n--- a/docs/source/cloud-setup/cloud-permi... | [
{
"diff_hunk": "@@ -85,6 +85,19 @@ def _get_single_resources_schema():\n 'zone': {\n 'type': 'string',\n },\n+ 'infra': {\n+ 'type': 'string',\n+ 'description':\n+ ('Infrastructure specification in format: '\n+ ... | eccdf0163e617bec70d8e7dfafe3cb2d5b88749a | diff --git a/docs/source/cloud-setup/cloud-permissions/aws.rst b/docs/source/cloud-setup/cloud-permissions/aws.rst
index 91e4eea2d5d..8a25b67756d 100644
--- a/docs/source/cloud-setup/cloud-permissions/aws.rst
+++ b/docs/source/cloud-setup/cloud-permissions/aws.rst
@@ -90,10 +90,10 @@ Example of mixing the default profi... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} | |
skypilot-org__skypilot-5435@50d9632 | skypilot-org/skypilot | Python | 5,435 | Support launch controller and jobs on different cloud for smoke test | <!-- Describe the changes in this PR -->
Resolve #5234
Add one more pytest argument: `--controller-cloud`.
Override this in the Sky env config for `jobs.controller.resources.cloud` when running tests.
<!-- Describe the tests ran -->
<!-- Unit tests (tests/test_*.py) are part of GitHub CI; below are tests t... | 2025-04-29T08:02:49Z | Support launch controller and jobs on different cloud
we should support it from our codebase instead of the buildkite infra. For example:
`sky jobs launch --controller_cloud aws --cloud gcp`
We don’t necessarily need to support these exact parameters, but provide a way to configure the controller cloud and set this i... | Actually, with #5197 we can use `--config jobs.controller.resources.cloud=aws`. But if the jobs controller is already spawned it won't do anything. | [
{
"body": "we should support it from our codebase instead of the buildkite infra. For example:\n\n`sky jobs launch --controller_cloud aws --cloud gcp`\n\nWe don’t necessarily need to support these exact parameters, but provide a way to configure the controller cloud and set this in the test case.",
"number"... | 7b804dafe2f6b775f8a357ac6e147b83e792af93 | {
"head_commit": "50d96329de8bd979e5473ec3b9fc4b59be4b3c8b",
"head_commit_message": "fix",
"patch_to_review": "diff --git a/.buildkite/generate_pipeline.py b/.buildkite/generate_pipeline.py\nindex 3ea4d9eb27f..3cce4b17e35 100644\n--- a/.buildkite/generate_pipeline.py\n+++ b/.buildkite/generate_pipeline.py\n@@ -11... | [
{
"diff_hunk": "@@ -355,6 +356,64 @@ def terminate_gcp_replica(name: str, zone: str, replica_id: int) -> str:\n f' --quiet $({query_cmd})')\n \n \n+@contextlib.contextmanager\n+def override_sky_config(\n+ test: Test, env_dict: Dict[str, str]\n+) -> Generator[Optional[tempfile.NamedTemporaryFile],... | fcc3929fd3e9a4d025fb2f9df03b964e04e21dc8 | diff --git a/.buildkite/generate_pipeline.py b/.buildkite/generate_pipeline.py
index 3ea4d9eb27f..3cce4b17e35 100644
--- a/.buildkite/generate_pipeline.py
+++ b/.buildkite/generate_pipeline.py
@@ -114,6 +114,8 @@ def _parse_args(args: Optional[str] = None):
parser.add_argument('--base-branch')
+ parser.add_... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
skypilot-org__skypilot-5297@d3743c2 | skypilot-org/skypilot | Python | 5,297 | improve CLI config flag's parsing | <!-- Describe the changes in this PR -->
Closes https://github.com/skypilot-org/skypilot/issues/5296
The CLI config flag currently accepts a comma separated list of config overrides. For example:
`--config kubernetes.provision_timeout=600,kubernetes.pod_config.spec.priorityClassName=high-priority`
is a valid CLI ... | 2025-04-21T17:35:33Z | [config] CLI "--config" flag does not properly parse commas passed as values
The CLI config flag accepts a comma separated list of config overrides. For example:
`--config kubernetes.provision_timeout=600,kubernetes.pod_config.spec.priorityClassName=high-priority`
is a valid CLI flag.
The CLI parsing logic currently s... | [
{
"body": "The CLI config flag accepts a comma separated list of config overrides. For example:\n`--config kubernetes.provision_timeout=600,kubernetes.pod_config.spec.priorityClassName=high-priority`\nis a valid CLI flag.\n\nThe CLI parsing logic currently simply splits the input string by commas and feed the r... | c975eab356a7b927a63320cf45452c5d3562db87 | {
"head_commit": "d3743c2baf8547b77a03a6aa1006fa8f2238373a",
"head_commit_message": "improve CLI config flag's parsing",
"patch_to_review": "diff --git a/docs/source/reference/config-sources.rst b/docs/source/reference/config-sources.rst\nindex d09445146d4..8a213602686 100644\n--- a/docs/source/reference/config-s... | [
{
"diff_hunk": "@@ -475,18 +475,16 @@ def _compose_cli_config(cli_config: Optional[str],) -> config_utils.Config:\n return config_utils.Config()\n \n config_source = 'CLI'\n- maybe_config_path = os.path.expanduser(cli_config)\n try:\n- if os.path.isfile(maybe_config_path):\n+ ma... | 830ca817e6327e85bfd63b8c57c660bdfd88b257 | diff --git a/docs/source/reference/config-sources.rst b/docs/source/reference/config-sources.rst
index d09445146d4..8a213602686 100644
--- a/docs/source/reference/config-sources.rst
+++ b/docs/source/reference/config-sources.rst
@@ -138,7 +138,8 @@ CLI flag
You can pass configuration arguments to the CLI using the `... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
skypilot-org__skypilot-5368@de97ecb | skypilot-org/skypilot | Python | 5,368 | [Core][RunPod] Show error for RunPod multi-node | <!-- Describe the changes in this PR -->
Fixes #5344
<img width="976" alt="dimmed" src="https://github.com/user-attachments/assets/184b669d-2bfa-4e5c-ad4a-076e17f49f07" />
This is a general fix to these classes of issues. First, we propagate resource infeasibility hints due to unsupported features to the optimize... | 2025-04-25T13:28:02Z | [Core] Multi-node support error message is not shown
```
(base) ➜ ~ sky launch --cloud runpod --num-nodes 2
No resource satisfying 2x RunPod() on RunPod.
sky.exceptions.ResourcesUnavailableError: Catalog does not contain any instances satisfying the request: 2x RunPod().
To fix: relax or change the resource requiremen... | Will look into this! | [
{
"body": "```\n(base) ➜ ~ sky launch --cloud runpod --num-nodes 2\nNo resource satisfying 2x RunPod() on RunPod.\nsky.exceptions.ResourcesUnavailableError: Catalog does not contain any instances satisfying the request: 2x RunPod().\nTo fix: relax or change the resource requirements.\n\nHint: sky show-gpus to ... | 957a48596a36157861e09df6c15641e513308f2d | {
"head_commit": "de97ecba9a02373c8c1a96f37b6971f256da5def",
"head_commit_message": "update test for changed return param count",
"patch_to_review": "diff --git a/sky/clouds/cloud.py b/sky/clouds/cloud.py\nindex a5777f58a86..d4f4163ebf4 100644\n--- a/sky/clouds/cloud.py\n+++ b/sky/clouds/cloud.py\n@@ -415,13 +415... | [
{
"diff_hunk": "@@ -390,16 +390,27 @@ def get_reservations_available_resources(\n node_resources_reprs = ', '.join(f'{node.num_nodes}x ' +\n r.repr_with_region_zone\n for r in node.resources)\n+ ... | e8da8f72cf55b9f9b857166430aadd81c7f1c107 | diff --git a/sky/clouds/cloud.py b/sky/clouds/cloud.py
index df52fbf292d..0e391113c21 100644
--- a/sky/clouds/cloud.py
+++ b/sky/clouds/cloud.py
@@ -418,13 +418,16 @@ def get_feasible_launchable_resources(
try:
self.check_features_are_supported(resources,
... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
skypilot-org__skypilot-5206@4201726 | skypilot-org/skypilot | Python | 5,206 | [controller] fix kubectl installation | <!-- Describe the changes in this PR -->
This regressed in #4835.
Fixes #5186.
<!-- Describe the tests ran -->
<!-- Unit tests (tests/test_*.py) are part of GitHub CI; below are tests that launch on the cloud. -->
Tested (run the relevant ones):
- [ ] Code formatting: install pre-commit (auto-check on com... | 2025-04-14T19:10:02Z | [Jobs] `kubectl` not found on jobs controller
To reproduce:
1. set up a k8s cluster with nodes that does not have enough CPUs for jobs controller
2. When running `sky jobs launch --cpus 2`
3. The controller starts on a cloud, but `kubectl` is not installed | https://github.com/skypilot-org/skypilot/pull/4835/files#diff-8acc88bd4d951508e5ea2f822f65dbc0bfaaed24fd6f8c18027affe8fda7ce1fL250-R257 is broken | [
{
"body": "To reproduce:\n1. set up a k8s cluster with nodes that does not have enough CPUs for jobs controller\n2. When running `sky jobs launch --cpus 2`\n3. The controller starts on a cloud, but `kubectl` is not installed",
"number": 5186,
"title": "[Jobs] `kubectl` not found on jobs controller"
}
... | e536958f1e9cd2bf91e379bd8381dbb8c084c0b1 | {
"head_commit": "4201726ac002c86c3fc2b4b420aaadd05cca0a0c",
"head_commit_message": "[controller] fix kubectl installation",
"patch_to_review": "diff --git a/sky/utils/controller_utils.py b/sky/utils/controller_utils.py\nindex 4267e4eed21..8fc3bfce344 100644\n--- a/sky/utils/controller_utils.py\n+++ b/sky/utils/c... | [
{
"diff_hunk": "@@ -262,8 +262,10 @@ def _get_cloud_dependencies_installation_commands(\n ' ARCH=\"amd64\"; '\n 'fi && '\n '(command -v kubectl &>/dev/null || '\n- '(\"https://dl.k8s.io/release/v1.31.6/bin/linux/$ARCH/kubectl\" '\n- ... | 39f30630e8a3e4d0ca40435446800b7e90f56fae | diff --git a/sky/utils/controller_utils.py b/sky/utils/controller_utils.py
index 4267e4eed21..398ddeb96b4 100644
--- a/sky/utils/controller_utils.py
+++ b/sky/utils/controller_utils.py
@@ -262,8 +262,9 @@ def _get_cloud_dependencies_installation_commands(
' ARCH="amd64"; '
'fi && '
... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
skypilot-org__skypilot-5273@b32e9f7 | skypilot-org/skypilot | Python | 5,273 | [k8s] Hints for querying stale kube current context | <!-- Describe the changes in this PR -->
Fixes #5258
<!-- Describe the tests ran -->
<!-- Unit tests (tests/test_*.py) are part of GitHub CI; below are tests that launch on the cloud. -->
... | 2025-04-18T01:07:23Z | [k8s] Confusing Error for Stale Current-Context in KubeConfig File
```
E 04-17 13:02:39 sdk.py:1496] === Traceback on SkyPilot API Server ===
...
E 04-17 13:02:39 sdk.py:1496] _load_config(context)
E 04-17 13:02:39 sdk.py:1496] File "/Users/kyuds/dev/skypilot/sky/adaptors/kubernetes.py", line 102, in _load_config... | [
{
"body": "```\nE 04-17 13:02:39 sdk.py:1496] === Traceback on SkyPilot API Server ===\n...\nE 04-17 13:02:39 sdk.py:1496] _load_config(context)\nE 04-17 13:02:39 sdk.py:1496] File \"/Users/kyuds/dev/skypilot/sky/adaptors/kubernetes.py\", line 102, in _load_config\nE 04-17 13:02:39 sdk.py:1496] _load_... | b55219e02a689021f3dee72bcc3c993fbc4c124a | {
"head_commit": "b32e9f7a0116ec239b85d5eb2b02632c62c099f0",
"head_commit_message": "styling",
"patch_to_review": "diff --git a/sky/adaptors/kubernetes.py b/sky/adaptors/kubernetes.py\nindex 1e8607870c3..e8a098c166b 100644\n--- a/sky/adaptors/kubernetes.py\n+++ b/sky/adaptors/kubernetes.py\n@@ -3,6 +3,8 @@\n impo... | [
{
"diff_hunk": "@@ -85,6 +87,11 @@ def _load_config_from_kubeconfig(context: Optional[str] = None):\n 'Please check if your kubeconfig file exists at '\n f'{kubeconfig_path} and is valid.\\n{suffix}')\n err_str += '\\nTo disable Kubernetes for SkyPilot: run `s... | 1346e7766c5bf796d3e99ca5994e970f9a50da38 | diff --git a/sky/adaptors/kubernetes.py b/sky/adaptors/kubernetes.py
index 1e8607870c3..27343bc15c2 100644
--- a/sky/adaptors/kubernetes.py
+++ b/sky/adaptors/kubernetes.py
@@ -70,21 +70,26 @@ def _load_config_from_kubeconfig(context: Optional[str] = None):
kubernetes.config.load_kube_config(context=contex... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} | |
skypilot-org__skypilot-5835@8599d6b | skypilot-org/skypilot | Python | 5,835 | [ManagedJobs] Support failure recovery for HA controller | <!-- Describe the changes in this PR -->
Support recovery logic for managed jobs.
Fixes #3970
<!-- Describe the tests ran -->
<!-- Unit tests (tests/test_*.py) are part of GitHub CI; below are tests that launch on the cloud. -->
Tested (run the relevant ones):
- [ ] Code formatting: install pre-commit ... | 2025-06-02T21:51:58Z | How to make the Controller highly available?
I have a query related to making the controller highly available for production deployment to remove the single point of failure. I have checked the doc but didn't find anything related. Is there any guide available for this? | This issue is stale because it has been open 120 days with no activity. Remove stale label or comment or this will be closed in 10 days.
This issue was closed because it has been stalled for 10 days with no activity.
Reopening for jobs controller. While HA is addressed for Serve controller in #4564, jobs controller sta... | [
{
"body": "I have a query related to making the controller highly available for production deployment to remove the single point of failure. I have checked the doc but didn't find anything related. Is there any guide available for this?",
"number": 3970,
"title": "How to make the Controller highly avail... | aeba5fdd1b113ba9118bdb629e9faf393a79ddef | {
"head_commit": "8599d6b0bb358ca0a023409e3c21c178ca1e60c8",
"head_commit_message": "add file",
"patch_to_review": "diff --git a/charts/skypilot/values.yaml b/charts/skypilot/values.yaml\nindex 21c7438d801..b2c50b02ad5 100644\n--- a/charts/skypilot/values.yaml\n+++ b/charts/skypilot/values.yaml\n@@ -196,6 +196,13... | [
{
"diff_hunk": "@@ -221,8 +241,12 @@ def _run_one_task(self, task_id: int, task: 'sky.Task') -> bool:\n \n # NOTE: we do not check cluster status first because race condition\n # can occur, i.e. cluster can be down during the job status check.\n- job_status = managed_job_utils... | 68934c83ca534e18f989107971e481d629b19883 | diff --git a/docs/repo-images/managed-job-status-diagram.png b/docs/repo-images/managed-job-status-diagram.png
index 98e2a10faa1..ab94a2de917 100644
Binary files a/docs/repo-images/managed-job-status-diagram.png and b/docs/repo-images/managed-job-status-diagram.png differ
diff --git a/sky/backends/cloud_vm_ray_backend.... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Code Refactoring / Architectural Improvement"
} |
Subsets and Splits
Review Test Instances
Retrieves basic metadata about code review instances but doesn't provide any analytical insights or patterns beyond raw data access.