instance_id stringlengths 21 53 | repo stringclasses 188
values | language stringclasses 1
value | pull_number int64 20 148k | title stringlengths 6 144 | body stringlengths 0 83.4k | created_at stringdate 2015-09-25 03:17:17 2025-07-10 16:50:35 | problem_statement stringlengths 188 240k | hints_text stringlengths 0 145k | resolved_issues listlengths 1 6 | base_commit stringlengths 40 40 | commit_to_review dict | reference_review_comments listlengths 1 62 | merged_commit stringlengths 40 40 | merged_patch stringlengths 297 9.87M | metadata dict |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
PrefectHQ__prefect-17362@192f555 | PrefectHQ/prefect | Python | 17,362 | feat: Add Prefect Server and Worker Helm Tutorial | Adds a tutorial for installing Prefect Server and a Worker with Helm
Closes https://github.com/PrefectHQ/prefect/issues/17360
Relates to https://linear.app/prefect/issue/PLA-1087/[quickstart-guide]-how-to-deploy-a-worker-server-with-helm
### Checklist
- [x] This pull request references any related issue by incl... | 2025-03-04T17:17:00Z | PrefectServer + PrefectWorker QuickStart Guide
### Describe the current behavior
Currently only prefect-helm contains instructions / README and is not directly referenced, or can be hard to find for a new user.
### Describe the proposed behavior
Add a quickstart tutorial for platform engineers to quickly stand-up a ... | [
{
"body": "### Describe the current behavior\n\nCurrently only prefect-helm contains instructions / README and is not directly referenced, or can be hard to find for a new user.\n\n### Describe the proposed behavior\n\nAdd a quickstart tutorial for platform engineers to quickly stand-up a Prefect Server (OSS) a... | 459cb4722d0517f36c67656bdb3a0174e6e28630 | {
"head_commit": "192f5554f4c36a59a9facf3fc6c84561b8a44b76",
"head_commit_message": "Update server-and-worker.mdx",
"patch_to_review": "diff --git a/docs/mint.json b/docs/mint.json\nindex 69433b9d826a..30a1acbdd012 100644\n--- a/docs/mint.json\n+++ b/docs/mint.json\n@@ -80,7 +80,8 @@\n \"v3/tutorials/... | [
{
"diff_hunk": "@@ -0,0 +1,189 @@\n+---\n+title: Deploy a Prefect Server and Worker with Helm\n+description: Deploy a Prefect OSS Server and Worker with Helm.\n+---\n+\n+In this tutorial, you'll learn how to deploy an [OSS Server](https://github.com/PrefectHQ/prefect-helm/tree/main/charts/prefect-server) and [W... | ffa3db58d870950793b919503bc0d67c38ec3071 | diff --git a/docs/mint.json b/docs/mint.json
index 69433b9d826a..30a1acbdd012 100644
--- a/docs/mint.json
+++ b/docs/mint.json
@@ -80,7 +80,8 @@
"v3/tutorials/platform",
"v3/tutorials/debug",
"v3/tutorials/alerts",
- "v3/tutorials/modal"
+ "v3/tutorials/modal... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
PrefectHQ__prefect-16517@7da7d9c | PrefectHQ/prefect | Python | 16,517 | log rendered custom `flow_run_name` | closes https://github.com/PrefectHQ/prefect/issues/16513
to log the correct name, we have to defer this info log until after we resolve the custom name
I changed `Created` to `Beginning` since we now "create" the flow run much earlier than we log this message, and I wanted to keep the log accurate - open to alter... | 2024-12-26T19:10:38Z | incorrect `flow_run_name` logged
### Bug summary
Even though the API is getting the right value, we are logging the auto-generated value
```python
In [1]: from prefect import flow
In [2]: @flow(flow_run_name='foo')
...: def f(): pass
In [3]: f()
12:29:41.538 | INFO | prefect.engine - Created flow r... | [
{
"body": "### Bug summary\r\n\r\nEven though the API is getting the right value, we are logging the auto-generated value\r\n\r\n```python\r\nIn [1]: from prefect import flow\r\n\r\nIn [2]: @flow(flow_run_name='foo')\r\n ...: def f(): pass\r\n\r\nIn [3]: f()\r\n12:29:41.538 | INFO | prefect.engine - Create... | f466ce5d3e955c20461cf389f280c58b26e413d4 | {
"head_commit": "7da7d9cb70031710a7ea9a235f156fcfb0fc3213",
"head_commit_message": "fix order of logging",
"patch_to_review": "diff --git a/src/prefect/flow_engine.py b/src/prefect/flow_engine.py\nindex f9cd310e1a5f..57788d6c9ab0 100644\n--- a/src/prefect/flow_engine.py\n+++ b/src/prefect/flow_engine.py\n@@ -490... | [
{
"diff_hunk": "@@ -1184,6 +1175,22 @@ async def setup_run_context(self, client: Optional[PrefectClient] = None):\n )\n self.flow_run.name = flow_run_name\n self._flow_run_name_set = True\n+\n+ _logger, run_type = (\n+ (get_run_logger(Flo... | 06e52b107185b89e4fde5e0b78595bece11cd58d | diff --git a/src/prefect/flow_engine.py b/src/prefect/flow_engine.py
index f9cd310e1a5f..175088f13ca4 100644
--- a/src/prefect/flow_engine.py
+++ b/src/prefect/flow_engine.py
@@ -490,24 +490,13 @@ def create_flow_run(self, client: SyncPrefectClient) -> FlowRun:
):
return subflow_run
- ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
PrefectHQ__prefect-17076@7f04c34 | PrefectHQ/prefect | Python | 17,076 | Adds AWS PrivateLink documentation | <!--
Thanks for opening a pull request to Prefect!
If this is your first contribution, please make sure to review our contribution guidelines: https://docs.prefect.io/contribute/index
-->
<!-- Include an overview of the proposed changes here -->
### Checklist
<!-- These boxes may be checked after opening th... | 2025-02-10T19:03:54Z | Add Documentation for AWS PrivateLink
### Describe the current behavior
Newly added support for AWS PrivateLink, creating an issue to reference in docs
### Describe the proposed behavior
Documentation updated to reflect PrivateLink support and instructions
### Example Use
_No response_
### Additional context
_N... | [
{
"body": "### Describe the current behavior\n\nNewly added support for AWS PrivateLink, creating an issue to reference in docs\n\n### Describe the proposed behavior\n\nDocumentation updated to reflect PrivateLink support and instructions \n\n### Example Use\n\n_No response_\n\n### Additional context\n\n_No res... | 032194ef60aabb0ba24572378c65658d2a9d3bc2 | {
"head_commit": "7f04c3496fa9d05bad4207d5780928b66aaf9cef",
"head_commit_message": "add page to sidebar",
"patch_to_review": "diff --git a/docs/mint.json b/docs/mint.json\nindex 18e3fb0fd78d..392651b369cd 100644\n--- a/docs/mint.json\n+++ b/docs/mint.json\n@@ -231,7 +231,8 @@\n \"v3/manage/cloud/... | [
{
"diff_hunk": "@@ -0,0 +1,36 @@\n+---\n+title: Secure access over PrivateLink\n+description: Manage network access to Prefect Cloud accounts over PrivateLink.\n+---\n+\n+PrivateLink is an available upgrade to certain Enterprise plans. \n+PrivateLink enables account administrators to restrict access to Prefect... | a67d9632d80259c2124f81195c87cd7141b13132 | diff --git a/docs/mint.json b/docs/mint.json
index 60d19cd6e2fa..2b9312ba9406 100644
--- a/docs/mint.json
+++ b/docs/mint.json
@@ -226,7 +226,8 @@
"v3/manage/cloud/manage-users/configure-sso",
"v3/manage/cloud/manage-users/audit-logs",
"v3/manage/cloud/manage-users/obj... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "Documentation Updates"
} | |
PrefectHQ__prefect-16308@adc3153 | PrefectHQ/prefect | Python | 16,308 | Support flow deletion in Prefect Python client | Closes #16307 in Prefect 3 | 2024-12-10T13:45:58Z | Prefect Python client does not support flow deletion
### Bug summary
The Prefect REST API supports flow removal via `DELETE` HTTP method on the `/api/flows/{flow_id}` endpoint. However, the Python Prefect client lacks this functionality, making it impossible to remove the flow without patching the client or calling th... | [
{
"body": "### Bug summary\n\nThe Prefect REST API supports flow removal via `DELETE` HTTP method on the `/api/flows/{flow_id}` endpoint. However, the Python Prefect client lacks this functionality, making it impossible to remove the flow without patching the client or calling the Prefect REST API directly.\n\n... | 5d1c88e92c7d04ff35dcd2708d8bdc5f4c18f7c5 | {
"head_commit": "adc3153ea0028a9db6d29c5636fcdcf85d6f79e8",
"head_commit_message": "Merge branch 'main' into feature/deleting-flows-in-python-client",
"patch_to_review": "diff --git a/src/prefect/client/orchestration.py b/src/prefect/client/orchestration.py\nindex bfcc6232192a..cb5e52dda782 100644\n--- a/src/pre... | [
{
"diff_hunk": "@@ -501,6 +501,24 @@ async def read_flow(self, flow_id: UUID) -> Flow:\n response = await self._client.get(f\"/flows/{flow_id}\")\n return Flow.model_validate(response.json())\n \n+ async def delete_flow(self, flow_id: UUID) -> None:\n+ \"\"\"\n+ Delete a flow by... | b9e40ef03e6366c7e6ca31ab3652273f1f2a5328 | diff --git a/src/prefect/client/orchestration.py b/src/prefect/client/orchestration.py
index bfcc6232192a..7afaf385b6c8 100644
--- a/src/prefect/client/orchestration.py
+++ b/src/prefect/client/orchestration.py
@@ -501,6 +501,24 @@ async def read_flow(self, flow_id: UUID) -> Flow:
response = await self._client... | {
"difficulty": "medium",
"estimated_review_effort": 2,
"problem_domain": "New Feature Additions"
} | |
PrefectHQ__prefect-16051@22c5988 | PrefectHQ/prefect | Python | 16,051 | Adds a dead-letter queue to memory subscriptions to avoid infinite loops | <!--
Thanks for opening a pull request to Prefect!
If this is your first contribution, please make sure to review our contribution guidelines: https://docs.prefect.io/latest/contributing/overview/
-->
<!-- Include an overview of the proposed changes here -->
In https://github.com/PrefectHQ/prefect/issues/15607... | 2024-11-18T22:03:11Z | Infinite Loop Symptoms on Prefect Server
### Bug summary
I ran into an issue with Prefect while working locally that looks like an endless loop happening on the backend.
I've observed the following behavior locally several times:
1. After running several dozen manual script executions, the workflows stop displayin... | Here is an example of the error in the UI. You can see that tasks are not displayed, but there are saved artifacts. The Task Runs list is also empty.
# Artifacts
# Task Runs
![image](https://github.com/user-attachments/asse... | [
{
"body": "### Bug summary\n\nI ran into an issue with Prefect while working locally that looks like an endless loop happening on the backend.\r\n\r\nI've observed the following behavior locally several times:\r\n1. After running several dozen manual script executions, the workflows stop displaying correctly in... | fdca91664a8a11590b4b2b5bf2e67080afac6655 | {
"head_commit": "22c5988921caa0367db74ddcd16207b495962a0a",
"head_commit_message": "Merge branch 'main' into add-dlq-to-subscriptions",
"patch_to_review": "diff --git a/src/prefect/server/utilities/messaging/memory.py b/src/prefect/server/utilities/messaging/memory.py\nindex 1d151cb6a660..e1e04c7ae2e6 100644\n--... | [
{
"diff_hunk": "@@ -29,23 +30,35 @@\n class MemoryMessage:\n data: Union[bytes, str]\n attributes: Dict[str, Any]\n+ retry_count: int = 0\n \n \n class Subscription:\n topic: \"Topic\"\n _queue: asyncio.Queue\n _retry: asyncio.Queue\n \n- def __init__(self, topic: \"Topic\") -> None:\n... | 256c9f19c2b5d6f4b6f4baefdda85f297fbe81a3 | diff --git a/src/prefect/server/utilities/messaging/memory.py b/src/prefect/server/utilities/messaging/memory.py
index 1d151cb6a660..e971dca00b46 100644
--- a/src/prefect/server/utilities/messaging/memory.py
+++ b/src/prefect/server/utilities/messaging/memory.py
@@ -1,7 +1,9 @@
import asyncio
+import copy
from contex... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
PrefectHQ__prefect-15817@322131e | PrefectHQ/prefect | Python | 15,817 | pass through kwargs for `run_shell_process` | closes https://github.com/PrefectHQ/prefect/issues/15816 | 2024-10-27T00:20:37Z | run_shell_process should support passing the current working directory or environment
### Describe the current behavior
The `run_shell_process` flow currently assumes it is running from within the current working directory and with the default environment variables. When the `run_shell_process` flow is either run outs... | hi @Jared314 - thanks for the issue! the PR linked above should allow this - let me know if you have any concerns! | [
{
"body": "### Describe the current behavior\n\nThe `run_shell_process` flow currently assumes it is running from within the current working directory and with the default environment variables. When the `run_shell_process` flow is either run outside the target working directory, or as a child flow, those value... | 0b62de684447c6955e04c722c276edac4002fd40 | {
"head_commit": "322131e2ef90d53b73b099a53790f3bf5f332d01",
"head_commit_message": "slightly cleaner",
"patch_to_review": "diff --git a/src/prefect/cli/shell.py b/src/prefect/cli/shell.py\nindex 6ca13f50bf6c..83a767402cfc 100644\n--- a/src/prefect/cli/shell.py\n+++ b/src/prefect/cli/shell.py\n@@ -8,7 +8,7 @@\n i... | [
{
"diff_hunk": "@@ -91,6 +91,7 @@ def run_shell_process(\n text=True,",
"line": null,
"original_line": 91,
"original_start_line": null,
"path": "src/prefect/cli/shell.py",
"start_line": null,
"text": "@user1:\nI think we should move the existing hard-coded kwargs to defaults on t... | 878aca1f206c4126c4c34b6229c7945a9ff939d5 | diff --git a/src/prefect/cli/shell.py b/src/prefect/cli/shell.py
index 6ca13f50bf6c..6837e5d00950 100644
--- a/src/prefect/cli/shell.py
+++ b/src/prefect/cli/shell.py
@@ -8,7 +8,7 @@
import subprocess
import sys
import threading
-from typing import List, Optional
+from typing import Any, Dict, List, Optional
impo... | {
"difficulty": "medium",
"estimated_review_effort": 2,
"problem_domain": "New Feature Additions"
} |
PrefectHQ__prefect-16476@6ac3784 | PrefectHQ/prefect | Python | 16,476 | Server should exit with non-0 on error | <!--
Thanks for opening a pull request to Prefect!
If this is your first contribution, please make sure to review our contribution guidelines: https://docs.prefect.io/latest/contributing/overview/
-->
<!-- Include an overview of the proposed changes here -->
Closes https://github.com/PrefectHQ/prefect/issues/1... | 2024-12-22T20:05:20Z | Server command exits with exit code 0 even when failing due to database connectivity
### Bug summary
I noticed this when deploying via helm: The pod reaches status `Completed` when an exception is thrown. It should exit with non-0 such that kubernetes will restart the pod.
### Version info
```Text
2024.12.19222717 (... | @martimors we'd love a contribution, either to the main prefect library or https://github.com/PrefectHQ/prefect-helm! We have [some contribution docs here](https://docs.prefect.io/contribute/dev-contribute) if that's helpful to get setup. Let us know if we can help
> @martimors we'd love a contribution, either to the m... | [
{
"body": "### Bug summary\n\nI noticed this when deploying via helm: The pod reaches status `Completed` when an exception is thrown. It should exit with non-0 such that kubernetes will restart the pod.\n\n### Version info\n\n```Text\n2024.12.19222717 (helm)\n```\n\n\n### Additional context\n\nI can potentially... | e5dc8a237262e6e4b9ef33d5148d873365e4c2b5 | {
"head_commit": "6ac3784ca95ef0a7cd1d067497b30d403bb0f904",
"head_commit_message": "Merge branch 'main' into bugfix/exit-with-non-0-on-error",
"patch_to_review": "diff --git a/src/prefect/cli/server.py b/src/prefect/cli/server.py\nindex fb66042be919..72c37daee814 100644\n--- a/src/prefect/cli/server.py\n+++ b/sr... | [
{
"diff_hunk": "@@ -413,3 +414,16 @@ def test_choose_when_multiple_profiles_have_same_api_url(self):\n \n profiles = load_profiles()\n assert profiles.active_name == \"local\"\n+\n+\n+class TestServerExitCodes:\n+ def test_misconfigured_server_exits_nonzero(self) -> None:\n+ invalid_co... | 2ce0f506f932ade22ff30dc765de8419cfc2ceb4 | diff --git a/src/prefect/cli/server.py b/src/prefect/cli/server.py
index fb66042be919..72c37daee814 100644
--- a/src/prefect/cli/server.py
+++ b/src/prefect/cli/server.py
@@ -311,10 +311,10 @@ async def start(
except anyio.EndOfStream:
logging.error("Subprocess stream ended unexpectedly")
- except Ex... | {
"difficulty": "medium",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
Netflix__metaflow-2121@2f516e1 | Netflix/metaflow | Python | 2,121 | use METAFLOW_CARD_LOCALROOT for card server | Fixes https://github.com/Netflix/metaflow/issues/2120 | 2024-10-28T06:37:49Z | The card viewer server should load data from METAFLOW_CARD_LOCALROOT location
We can configure the location of the metadata and cards using the METAFLOW_DATASTORE_SYSROOT_LOCAL and METAFLOW_CARD_LOCALROOT.
Unfortunately, the card viewer server doesn't use these environment variables to determine where the metadata i... | thanks for the bug report! we are looking into it | [
{
"body": "We can configure the location of the metadata and cards using the METAFLOW_DATASTORE_SYSROOT_LOCAL and METAFLOW_CARD_LOCALROOT.\r\n\r\nUnfortunately, the card viewer server doesn't use these environment variables to determine where the metadata is located. Instead, we have to run the command from the... | a37555b6aa673d495390b28b34a36672b024381e | {
"head_commit": "2f516e1f7b00222bc896a2a818134fa39dbb6194",
"head_commit_message": "use the correct path",
"patch_to_review": "diff --git a/metaflow/plugins/cards/card_server.py b/metaflow/plugins/cards/card_server.py\nindex 7b5008410ba..4b3ce0ec8d7 100644\n--- a/metaflow/plugins/cards/card_server.py\n+++ b/meta... | [
{
"diff_hunk": "@@ -50,15 +45,20 @@ class RunWatcher(Thread):\n def __init__(self, flow_name, connection: Connection):\n super().__init__()\n \n- self._watch_file = os.path.join(\n- os.getcwd(), DATASTORE_LOCAL_DIR, flow_name, \"latest_run\"\n+ local_root = LocalStorage.data... | 4ee231be14e6838a9ac8da543441df90794775cb | diff --git a/metaflow/plugins/cards/card_server.py b/metaflow/plugins/cards/card_server.py
index 7b5008410ba..d0050c6559e 100644
--- a/metaflow/plugins/cards/card_server.py
+++ b/metaflow/plugins/cards/card_server.py
@@ -20,14 +20,9 @@ class ThreadingHTTPServer(ThreadingMixIn, HTTPServer):
from .card_client import Car... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
Netflix__metaflow-2446@a522289 | Netflix/metaflow | Python | 2,446 | feature: support custom exit hooks | implementing support for running custom functions as exit hooks with argo workflows, local, kubernetes and batch runtimes.
also refactors current lifecycle hook setup to use the same primitives.
Suggested UX for defining custom exit hooks in the flow file:
```python
from time import sleep
from typing import ... | 2025-06-09T12:51:52Z | Callback on step failure
Is it possible to implement a try:catch:finally kind of a flow for each step?
We have retries, so we have catch. But if none of the retries on a step are successful, there are many scenarios one would want to have a callback, say to alert for step failure, before exiting the flow. | @parulgaba as a work around, you can catch all the errors and depending on the error, take some corrective action before killing the execution.
```
from metaflow import FlowSpec, step, retry, catch
class SuicidalFlow(FlowSpec):
@catch(var='start_failed')
@retry
@step
def start(self):
... | [
{
"body": "Is it possible to implement a try:catch:finally kind of a flow for each step?\r\nWe have retries, so we have catch. But if none of the retries on a step are successful, there are many scenarios one would want to have a callback, say to alert for step failure, before exiting the flow.",
"number": ... | 65fb7d479a16a15346b833b55b9fdf17d0776fd1 | {
"head_commit": "a522289aed514f918fa3b8740af670fdce75d406",
"head_commit_message": "add missing init file",
"patch_to_review": "diff --git a/devtools/Tiltfile b/devtools/Tiltfile\nindex ac6ba29597b..620671b0137 100644\n--- a/devtools/Tiltfile\n+++ b/devtools/Tiltfile\n@@ -224,6 +224,19 @@ if \"argo-workflows\" i... | [
{
"diff_hunk": "@@ -0,0 +1,32 @@\n+from metaflow.decorators import FlowDecorator\n+from metaflow.exception import MetaflowException\n+\n+\n+class ExitHookDecorator(FlowDecorator):\n+ name = \"exit_hook\"\n+ allow_multiple = True\n+\n+ defaults = {\n+ \"image\": None,",
"line": null,
"ori... | 4af5d4bb79311116e5993d258728256c587c450e | diff --git a/devtools/Tiltfile b/devtools/Tiltfile
index ac6ba29597b..620671b0137 100644
--- a/devtools/Tiltfile
+++ b/devtools/Tiltfile
@@ -224,6 +224,19 @@ if "argo-workflows" in enabled_components:
]
)
+ # This fixes issue described in: https://github.com/argoproj/argo-workflows/issues/10340
+ ... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
PrefectHQ__prefect-15624@a95043c | PrefectHQ/prefect | Python | 15,624 | Add check for `prefect-client` version in prefect-client workflow | <!--
Thanks for opening a pull request to Prefect!
If this is your first contribution, please make sure to review our contribution guidelines: https://docs.prefect.io/latest/contributing/overview/
-->
<!-- Include an overview of the proposed changes here -->
Fixes an issue where the `__version__` attribute is ... | 2024-10-09T14:30:05Z | prefect-client has unknown prefect.__version__
### Bug summary
Attempt to run deployed flow via prefect-client==3.0.5 produces this error:
`RuntimeError: Found incompatible versions: client: 0+unknown, server: 3.0.5. Major versions must match.`
```
python -m pip install prefect-client==3.0.5
python -c 'import ... | Thanks for the bug report, @ikseek! It looks like a version check was introduced in 3.0.1 via [#15252](https://github.com/PrefectHQ/prefect/pull/15252), which is where this error is coming from. The missing version on `prefect-client` looks like a long-standing issue that wasn't discovered until now. I will investigate... | [
{
"body": "### Bug summary\r\n\r\nAttempt to run deployed flow via prefect-client==3.0.5 produces this error:\r\n`RuntimeError: Found incompatible versions: client: 0+unknown, server: 3.0.5. Major versions must match.`\r\n\r\n```\r\npython -m pip install prefect-client==3.0.5\r\npython -c 'import prefect; print... | 1d1b92a79b8972823ae9050d70bf60b7c586aabf | {
"head_commit": "a95043c083b4b3a4d799d7e7576ae71a6c3419a3",
"head_commit_message": "Fix markdown tests",
"patch_to_review": "diff --git a/.github/workflows/markdown-tests.yaml b/.github/workflows/markdown-tests.yaml\nindex 7a75a126c2e6..495dfa0a1bbb 100644\n--- a/.github/workflows/markdown-tests.yaml\n+++ b/.git... | [
{
"diff_hunk": "@@ -56,6 +58,10 @@ jobs:\n env:\n TMPDIR: ${{ env.TMPDIR }}\n \n+ - name: (DEBUG) Print versioneer output\n+ run: python -c \"import versioneer; print(versioneer.get_version())\"\n+ working-directory: ${{ env.TMPDIR }}",
"line": null,
"original_line":... | e72be009e4c4513af230ec3cae7e35b7aab743e7 | diff --git a/.github/workflows/markdown-tests.yaml b/.github/workflows/markdown-tests.yaml
index 7a75a126c2e6..495dfa0a1bbb 100644
--- a/.github/workflows/markdown-tests.yaml
+++ b/.github/workflows/markdown-tests.yaml
@@ -95,7 +95,7 @@ jobs:
- name: Start server
run: |
- prefect server start... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
PrefectHQ__prefect-17123@3ef0cda | PrefectHQ/prefect | Python | 17,123 | update idempotency key for scheduled runs to disambiguate schedules | closes #17115
using the [MRE](https://github.com/PrefectHQ/prefect/issues/17115#issue-2848846007) in the linked issue we see that we were clobbering scheduled runs bc the idempotency key didn't consider uniqueness wrt deployment schedule id
## before
, only one is scheduled. As an example, running
```python
"""Create a flow with two schedules that run at the same time."""
from ... | hi @mvdb-enspi - thank you for the report! we'll take a look at this | [
{
"body": "### Bug summary\n\nWhen creating a flow that has two schedules that run at the same time (but with different parameters), only one is scheduled. As an example, running\n\n```python\n\"\"\"Create a flow with two schedules that run at the same time.\"\"\"\n\nfrom prefect import flow\nfrom prefect.sched... | 2df84e40c54d86e36cd285fd8bece1b4116477a3 | {
"head_commit": "3ef0cda0aa58ab50fea25b90478f2fe3b416dfd2",
"head_commit_message": "be more consistent",
"patch_to_review": "diff --git a/src/prefect/_result_records.py b/src/prefect/_result_records.py\nindex dd538e88b2a6..5ddeb6925078 100644\n--- a/src/prefect/_result_records.py\n+++ b/src/prefect/_result_recor... | [
{
"diff_hunk": "@@ -144,8 +144,8 @@ def serialize_result(self) -> bytes:\n \n @model_validator(mode=\"before\")\n @classmethod\n- def coerce_old_format(cls, value: dict[str, Any] | Any) -> dict[str, Any]:\n- if isinstance(value, dict):\n+ def coerce_old_format(cls, value: dict[str, Any]) ->... | a90ebf51582c8a274dab5f9d8be539f1d49273f0 | diff --git a/src/prefect/_result_records.py b/src/prefect/_result_records.py
index dd538e88b2a6..1b04d14574fb 100644
--- a/src/prefect/_result_records.py
+++ b/src/prefect/_result_records.py
@@ -9,6 +9,7 @@
Optional,
TypeVar,
Union,
+ cast,
)
from uuid import UUID
@@ -146,6 +147,8 @@ def serialize... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
Netflix__metaflow-2023@861cf5d | Netflix/metaflow | Python | 2,023 | feature: backwards compatible Kubernetes list and kill | supersedes #1998 as the first attempt, as this approach is backwards compatible.
closes #1631
**caveat**
this approach iterates through all active pods in a namespace indiscriminately (with a limit of `1000` per request), only filtering on the client side for relevant ones. As a result, in deployments with enor... | 2024-09-10T21:48:57Z | Add list and kill support for kubernetes CLI
The metaflow batch CLI supports `list` and `kill` for identifying running jobs on a flow and killing them if needed. This is useful if you get disconnected from the terminal that started the job and need to stop it. The kubernetes CLI doesn't have any similar functionality... | [
{
"body": "The metaflow batch CLI supports `list` and `kill` for identifying running jobs on a flow and killing them if needed. This is useful if you get disconnected from the terminal that started the job and need to stop it. The kubernetes CLI doesn't have any similar functionality. Our current workaround ... | d87030e215f3296d2ce245963be7ab2f47e2f165 | {
"head_commit": "861cf5d3a3f3fec1539f2efd4265c818711478e3",
"head_commit_message": "patch: add fallbacks to kube kill (#2025)\n\n* add fallbacks to kube kill\r\n\r\n* block killing pods managed by argo-workflows",
"patch_to_review": "diff --git a/metaflow/plugins/kubernetes/kube_utils.py b/metaflow/plugins/kuber... | [
{
"diff_hunk": "@@ -60,6 +63,98 @@ def get(self):\n \n return self._client\n \n+ def _find_active_pods(self, flow_name, run_id=None, user=None):\n+ def _request(_continue=None):\n+ # handle paginated responses\n+ return self._client.CoreV1Api().list_namespaced_pod(\n+ ... | 268be585d96ee517ea6b37c45dd1519b2168f74f | diff --git a/metaflow/plugins/kubernetes/kube_utils.py b/metaflow/plugins/kubernetes/kube_utils.py
new file mode 100644
index 00000000000..979b7b9d273
--- /dev/null
+++ b/metaflow/plugins/kubernetes/kube_utils.py
@@ -0,0 +1,25 @@
+from metaflow.exception import CommandException
+from metaflow.util import get_username, ... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
Netflix__metaflow-1588@22ba73f | Netflix/metaflow | Python | 1,588 | Add a uid for the kubernetes job creation | Fixes #1554
When running large for-each branches (3000+) Metaflow will sometimes cause job name collisions on kubernetes. This adds a UUID to the prefix which should add sufficient entropy to prevent this from happening. | 2023-10-12T17:09:10Z | Name collisions on kubernetes jobs cause flow to fail
If there is a random UID created for a kubernetes job that is the same as an existing job, the job will fail:
```
2023-09-26 19:59:06.554 [26708/write_refl_store/232688 (pid 332902)] metaflow.plugins.kubernetes.kubernetes_job.KubernetesJobException: Unable to la... | [
{
"body": "If there is a random UID created for a kubernetes job that is the same as an existing job, the job will fail:\r\n\r\n```\r\n2023-09-26 19:59:06.554 [26708/write_refl_store/232688 (pid 332902)] metaflow.plugins.kubernetes.kubernetes_job.KubernetesJobException: Unable to launch Kubernetes job.\r\n2023-... | efd7a85001c0bbd817bdd5956541d8868948e818 | {
"head_commit": "22ba73fba2c123104fa9c67b88813f990ff3f486",
"head_commit_message": "Add a uid for the kubernetes job creation",
"patch_to_review": "diff --git a/metaflow/plugins/kubernetes/kubernetes.py b/metaflow/plugins/kubernetes/kubernetes.py\nindex 410651f1e29..ed034be8cad 100644\n--- a/metaflow/plugins/kub... | [
{
"diff_hunk": "@@ -178,7 +179,7 @@ def create_job(\n job = (\n KubernetesClient()\n .job(\n- generate_name=\"t-\",\n+ generate_name=\"t-{uid}\".format(uid=str(uuid.uuid4())),",
"line": null,
"original_line": 182,
"original_start_line": n... | 7032434d1bc74244564e2966a7543b070f389b8d | diff --git a/metaflow/plugins/kubernetes/kubernetes.py b/metaflow/plugins/kubernetes/kubernetes.py
index 410651f1e29..a6fee0d2f5b 100644
--- a/metaflow/plugins/kubernetes/kubernetes.py
+++ b/metaflow/plugins/kubernetes/kubernetes.py
@@ -5,6 +5,8 @@
import shlex
import time
from typing import Dict, List, Optional
+im... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} | |
Netflix__metaflow-1546@00f74f5 | Netflix/metaflow | Python | 1,546 | Check for the first finished parallel proccess | This fixes https://github.com/Netflix/metaflow/issues/1316 to optimize the parallel map runs by checking for the first finished process instead of waiting for the first process before checking others. | 2023-09-23T03:19:47Z | Optimize parallel_map by properly waiting on child pids
Currently `parallel_map` launches K subprocesses and then waits for the Kth child to finish before launching another subprocess. A more efficient approach would be to use epoll etc to wait for the first subprocess to finish. | [
{
"body": "Currently `parallel_map` launches K subprocesses and then waits for the Kth child to finish before launching another subprocess. A more efficient approach would be to use epoll etc to wait for the first subprocess to finish.",
"number": 1316,
"title": "Optimize parallel_map by properly waitin... | f8490c241ee1abdffc974ed438ab53dcc731982b | {
"head_commit": "00f74f55f324f4acea28e2c992c8cb47eb006b86",
"head_commit_message": "Fix code format with black",
"patch_to_review": "diff --git a/metaflow/multicore_utils.py b/metaflow/multicore_utils.py\nindex 1ac81039c12..55704623d5b 100644\n--- a/metaflow/multicore_utils.py\n+++ b/metaflow/multicore_utils.py\... | [
{
"diff_hunk": "@@ -68,8 +69,17 @@ def parallel_imap_unordered(func, iterable, max_parallel=None, dir=None):\n \n while pids:\n \n- pid, output_file = pids.pop()\n- if os.waitpid(pid, 0)[1]:\n+ for idx, pid_info in enumerate(pids):\n+ pid, output_file = pid_info\n+ ... | 4975da903eadaa1c20269f35b311ef61f92155e9 | diff --git a/metaflow/multicore_utils.py b/metaflow/multicore_utils.py
index 1ac81039c12..73ad909b3a4 100644
--- a/metaflow/multicore_utils.py
+++ b/metaflow/multicore_utils.py
@@ -4,6 +4,7 @@
from itertools import islice
from multiprocessing import cpu_count
from tempfile import NamedTemporaryFile
+import time
t... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Performance Optimizations"
} | |
PrefectHQ__prefect-15553@ecc6730 | PrefectHQ/prefect | Python | 15,553 | Make database parameter optional in ConnectionComponents #15511 | closes https://github.com/PrefectHQ/prefect/issues/15511 | 2024-10-01T15:59:30Z | ConnectionComponents: Make database optional for proper connection string formation
### Bug summary
In the `ConnectionComponents` class from `prefect_sqlalchemy`, the database parameter is mandatory and used instead of host when creating the connection URL. This leads to incorrect connection string generation. The ... | hi @OUBVITOL - thanks for the issue!
would you be willing to contribute a PR for this? | [
{
"body": "### Bug summary\r\n\r\n In the `ConnectionComponents` class from `prefect_sqlalchemy`, the database parameter is mandatory and used instead of host when creating the connection URL. This leads to incorrect connection string generation. The `database` parameter should be made optional to allow proper ... | c068d7e2db1d5ac06e935ad28213b9fcc4e5ccfd | {
"head_commit": "ecc6730e91f415a1fef28c0ea958ca8207802ec7",
"head_commit_message": "Make database optional in ConnectionComponents",
"patch_to_review": "diff --git a/src/integrations/prefect-sqlalchemy/prefect_sqlalchemy/credentials.py b/src/integrations/prefect-sqlalchemy/prefect_sqlalchemy/credentials.py\ninde... | [
{
"diff_hunk": "@@ -103,7 +103,9 @@ class ConnectionComponents(BaseModel):\n driver: Union[AsyncDriver, SyncDriver, str] = Field(\n default=..., description=\"The driver name to use.\"\n )\n- database: str = Field(default=..., description=\"The name of the database to use.\")\n+ database: ... | 5b638f450f59fa152b11f699b8beb49521b5d4b9 | diff --git a/src/integrations/prefect-sqlalchemy/prefect_sqlalchemy/credentials.py b/src/integrations/prefect-sqlalchemy/prefect_sqlalchemy/credentials.py
index 0758d2eb6aaf..a2ae258fa93d 100644
--- a/src/integrations/prefect-sqlalchemy/prefect_sqlalchemy/credentials.py
+++ b/src/integrations/prefect-sqlalchemy/prefect... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
PaddlePaddle__PaddleSeg-266@012b24f | PaddlePaddle/PaddleSeg | Python | 266 | fix label tool bugs | 1 标注格式转换脚本使用自定义api，去除labelme依赖，避免外部依赖更新导致的bug
2 修复潜在问题，如果图片自带旋转信息，例如来自移动设备，PIL读图结果将不符合预期。已用opencv读图解决
close #263 | 2020-05-25T12:26:54Z | LabelMe标注好图片之后，使用labelme2seg无法生成真值图片
我使用LabelMe标注好图片之后，使用labelme2seg生成真值图片，运行labelme2seg的时候报错，报错信息如下：
class_names: ('_background_', 'steel')
Saved class_names: D:\2\class_names.txt
Generating dataset from: D:\2\2020_5_15_13_19_46_995.json
Traceback (most recent call last):
File "D:\PaddleSeg\pdseg\tools\labelme2... | [
{
"body": "我使用LabelMe标注好图片之后，使用labelme2seg生成真值图片，运行labelme2seg的时候报错，报错信息如下：\r\nclass_names: ('_background_', 'steel')\r\nSaved class_names: D:\\2\\class_names.txt\r\nGenerating dataset from: D:\\2\\2020_5_15_13_19_46_995.json\r\nTraceback (most recent call last):\r\n File \"D:\\PaddleSeg\\pdseg\\tools\\labelme... | 867d4a5bca4e828e98b62b31697f18420ff8415e | {
"head_commit": "012b24f64af52dcfbc2f9a198115edfbeeb4f1b0",
"head_commit_message": "fix label tool bug",
"patch_to_review": "diff --git a/docs/annotation/labelme_demo/annotations/2011_000025.png b/docs/annotation/labelme_demo/annotations/2011_000025.png\ndeleted file mode 100644\nindex 0b5a56dda1..0000000000\nBi... | [
{
"diff_hunk": "@@ -20,10 +20,11 @@\n import json\n import os\n import os.path as osp\n-\n import numpy as np\n import PIL.Image\n-import labelme\n+import PIL.ImageDraw\n+import cv2\n+import math",
"line": null,
"original_line": 27,
"original_start_line": null,
"path": "pdseg/tools/labelme2seg.p... | 74b1e8f6afa17f6db95b2203a82cfaf47d1d4318 | diff --git a/docs/annotation/jingling2seg.md b/docs/annotation/jingling2seg.md
index de36b5395b..2b9ce772e3 100644
--- a/docs/annotation/jingling2seg.md
+++ b/docs/annotation/jingling2seg.md
@@ -59,16 +59,16 @@
* 经过数据格式转换后的数据集目录结构如下：
```
- my_dataset # 根目录
+ my_dataset # 根目录
|-- ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
Netflix__metaflow-902@a6b3626 | Netflix/metaflow | Python | 902 | Fix issue when running on batch with local metadata | Artifacts were persisted *after* the metadata was saved to S3 to be
repatriated locally which caused it to completely miss.
This addresses this issue (fixes #878) and also addresses another issue
in load_metadata when loading non existent metadata. | 2022-01-14T06:11:32Z | KeyError getting results of Batch runs in 2.4.0+
I get a KeyError when getting results of a run that uses AWS Batch starting in metaflow 2.4.0, including 2.4.7. 2.3.6 works fine. Non-Batch runs work fine.
To reproduce, use the following files:
```
# branch_flow.py
from metaflow import FlowSpec, step, resources
... | [
{
"body": "I get a KeyError when getting results of a run that uses AWS Batch starting in metaflow 2.4.0, including 2.4.7. 2.3.6 works fine. Non-Batch runs work fine.\r\n\r\nTo reproduce, use the following files:\r\n\r\n```\r\n# branch_flow.py\r\nfrom metaflow import FlowSpec, step, resources\r\n\r\n\r\nclass B... | c67ce9ee489b4fd6329bb9320875d043f8ea36dd | {
"head_commit": "a6b362601207c4b16b33575a55ac77f239e28c7c",
"head_commit_message": "Fix issue when running on batch with local metadata\n\nArtifacts were persisted *after* the metadata was saved to S3 to be\nrepatriated locally which caused it to completely miss.\n\nThis addresses this issue (fixes #878) and also ... | [
{
"diff_hunk": "@@ -435,6 +435,37 @@ def save_metadata(self, contents, allow_overwrite=True, add_attempt=True):\n add_attempt,\n )\n \n+ @require_mode(\"w\")\n+ def _dangerous_save_metadata_post_done(\n+ self, contents, allow_overwrite=True, add_attempt=True\n+ ):\n+ \... | b0ce5d38fd54587ff015f9e409895367b9723ee8 | diff --git a/metaflow/datastore/task_datastore.py b/metaflow/datastore/task_datastore.py
index 713361461ed..3f264c00f25 100644
--- a/metaflow/datastore/task_datastore.py
+++ b/metaflow/datastore/task_datastore.py
@@ -435,6 +435,42 @@ def save_metadata(self, contents, allow_overwrite=True, add_attempt=True):
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
PrefectHQ__prefect-15342@6d3a70b | PrefectHQ/prefect | Python | 15,342 | Allow child transactions to access parent values set after child transaction opens | <!--
Thanks for opening a pull request to Prefect!
If this is your first contribution, please make sure to review our contribution guidelines: https://docs.prefect.io/latest/contributing/overview/
-->
<!-- Include an overview of the proposed changes here -->
This PR enables child transactions to access paren... | 2024-09-11T20:51:20Z | `transaction.get` functionality depends on `transaction.set` location within flow
### Bug summary
Accessing a transaction key-value pair that is set within the transaction context block without calling `get_transaction` is sensitive to where the `.set` method is called.
MRE where the rollback hook fails. Move the... | [
{
"body": "### Bug summary\r\n\r\nAccessing a transaction key-value pair that is set within the transaction context block without calling `get_transaction` is sensitive to where the `.set` method is called.\r\n\r\nMRE where the rollback hook fails. Move the `transaction.set` above the call to `write_file` and t... | b53bb903cab04944387ef0ac7e17da63fb2027f8 | {
"head_commit": "6d3a70bab88b9d504b8d00a25e3437ab855ddbac",
"head_commit_message": "Allow child transactions to access parent values set after child transaction opens",
"patch_to_review": "diff --git a/src/prefect/transactions.py b/src/prefect/transactions.py\nindex 138b215e56b5..ff4a9fb0bbe5 100644\n--- a/src/p... | [
{
"diff_hunk": "@@ -81,11 +81,22 @@ def set(self, name: str, value: Any) -> None:\n self._stored_values[name] = value\n \n def get(self, name: str, default: Any = NotSet) -> Any:\n- if name not in self._stored_values:\n+ value = self._stored_values.get(name, NotSet)\n+ if value ... | fd1a0adf1a1a2dbc3a6877143205b5757ddb23a5 | diff --git a/src/prefect/transactions.py b/src/prefect/transactions.py
index 138b215e56b5..d60563258752 100644
--- a/src/prefect/transactions.py
+++ b/src/prefect/transactions.py
@@ -78,14 +78,85 @@ class Transaction(ContextModel):
__var__: ContextVar = ContextVar("transaction")
def set(self, name: str, val... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
Netflix__metaflow-1091@9576d41 | Netflix/metaflow | Python | 1,091 | Adding support for Azure Blob Storage as a datastore | The primary change is implementing `AzureStorage` (analogous to existing `S3Storage`, `LocalStorage`). We are consciously deferring the decision of having first class "data tools" support for Azure.
There are some necessary changes to ensure full Azure support on all Metaflow surfaces:
* includefile
* conda
* ca... | 2022-07-20T17:46:38Z | Support for another public cloud - Microsoft Azure
Currently, Metaflow is set up to work with AWS as the default public cloud. The architecture of Metaflow allows for additional public clouds to be supported.
Adding support for Microsoft Azure might broaden the potential user base, which could increase the adaption ... | I can dedicate a few hours here and there for Azure support, but I don't have time to take the reins on this one. If someone goes through the trouble of designing and proposing a solution and could use some extra hands for the implementation, loop me in.
@gerryhernandez: I have asked my contacts at Microsoft (Norwegian... | [
{
"body": "Currently, Metaflow is set up to work with AWS as the default public cloud. The architecture of Metaflow allows for additional public clouds to be supported.\r\n\r\nAdding support for Microsoft Azure might broaden the potential user base, which could increase the adaption rate. This, in turn, could l... | c1ff46994e0a133431e971b8cde92161ed1f61e4 | {
"head_commit": "9576d418f31dc0dacd38986e6ace62f588ad12fc",
"head_commit_message": "remove signature",
"patch_to_review": "diff --git a/metaflow/datastore/__init__.py b/metaflow/datastore/__init__.py\nindex 794ea23ccef..8f0f5f97717 100644\n--- a/metaflow/datastore/__init__.py\n+++ b/metaflow/datastore/__init__.p... | [
{
"diff_hunk": "@@ -36,8 +36,50 @@ def init_config():\n METAFLOW_CONFIG = init_config()\n \n \n-def from_conf(name, default=None):\n- return os.environ.get(name, METAFLOW_CONFIG.get(name, default))\n+def from_conf(name, default=None, from_env_only=False, validate_fn=None):",
"line": null,
"original_l... | d06ecec30dce1a33081e03f0b765eec913e1408b | diff --git a/metaflow/__init__.py b/metaflow/__init__.py
index 91b2a667da5..c9b1aa48c7b 100644
--- a/metaflow/__init__.py
+++ b/metaflow/__init__.py
@@ -102,7 +102,7 @@ class and related decorators.
# Flow spec
from .flowspec import FlowSpec
-from .includefile import IncludeFile
+
from .parameters import Parameter... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
Netflix__metaflow-764@8ffc69c | Netflix/metaflow | Python | 764 | handling exceptions for non-picklizable artifacts | This resolves #763 | 2021-10-14T22:58:46Z | Better error message on failure of Pickle serialization
When Metaflow serializes artifacts to Pickle, It will be a good practice to fail loudly by stating what artifact couldn't be serialized. Currently, when Metaflow fails pickle serialization, it doesn't tell me which particular artifact was the cause of failure duri... | [
{
"body": "When Metaflow serializes artifacts to Pickle, It will be a good practice to fail loudly by stating what artifact couldn't be serialized. Currently, when Metaflow fails pickle serialization, it doesn't tell me which particular artifact was the cause of failure during pickle serialization. ",
"numb... | e2aa6a3e922000fbc836db961d4e6df92de32fad | {
"head_commit": "8ffc69c829b95ec26d05fc2db27f097938d1b81a",
"head_commit_message": "Nit fixes.",
"patch_to_review": "diff --git a/metaflow/datastore/exceptions.py b/metaflow/datastore/exceptions.py\nindex 139a2c25f43..3b77b21cbb8 100644\n--- a/metaflow/datastore/exceptions.py\n+++ b/metaflow/datastore/exceptions... | [
{
"diff_hunk": "@@ -246,7 +249,13 @@ def pickle_iter():\n \"Artifact *%s* is very large (over 2GB). \"\n \"You need to use Python 3.4 or newer if you want to \"\n \"serialize large objects.\" % name)\n- ... | 43d70bf76dda4546a7d36ef62a6e9919441f115e | diff --git a/metaflow/datastore/exceptions.py b/metaflow/datastore/exceptions.py
index 139a2c25f43..1ed108f93f7 100644
--- a/metaflow/datastore/exceptions.py
+++ b/metaflow/datastore/exceptions.py
@@ -1,4 +1,12 @@
from ..exception import MetaflowException
class DataException(MetaflowException):
- headline = "Dat... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
PrefectHQ__prefect-15220@6533322 | PrefectHQ/prefect | Python | 15,220 | Add `KeepAliveClientRequest` class for k8s async client | <!--
Thanks for opening a pull request to Prefect!
If this is your first contribution, please make sure to review our contribution guidelines: https://docs.prefect.io/latest/contributing/overview/
-->
<!-- Include an overview of the proposed changes here -->
Closes #14954
Swaps the request class on the asy... | 2024-09-04T17:56:51Z | K8s worker fails monitoring flow and sets it to crashed.
### Bug summary
We are seeing an issue with the latest k8s worker monitoring flow runs. After some amount of time (5-10 minutes?) we see the worker fail to monitor the flow run with the message provided in additional context. The worker then marks the flow as fa... | Thanks for the issue @meggers!
I'm trying to reproduce this issue, but I haven't been able to do so yet. Do you have any additional logs or tracebacks that you can share?
Thank you @desertaxle ! The worker logs don't have anything more than what I added for additional context. If there is a setting that would expose... | [
{
"body": "### Bug summary\n\nWe are seeing an issue with the latest k8s worker monitoring flow runs. After some amount of time (5-10 minutes?) we see the worker fail to monitor the flow run with the message provided in additional context. The worker then marks the flow as failed. The flow continues to run unti... | 67abdb1bdb0f29c6c107516d3a3ee944b5a5a2d5 | {
"head_commit": "6533322cd4025a365d710a15501f4291bfc3888e",
"head_commit_message": "update values, add docstring to class",
"patch_to_review": "diff --git a/src/integrations/prefect-kubernetes/prefect_kubernetes/utilities.py b/src/integrations/prefect-kubernetes/prefect_kubernetes/utilities.py\nindex 879b8cb3e03... | [
{
"diff_hunk": "@@ -14,34 +16,35 @@\n V1KubernetesModel = TypeVar(\"V1KubernetesModel\")\n \n \n-def enable_socket_keep_alive(client: ApiClient) -> None:\n+class KeepAliveClientRequest(ClientRequest):\n \"\"\"\n- Setting the keep-alive flags on the kubernetes client object.\n- Unfortunately neither th... | a4681016d3ad0977ee54704e2c4743531bbe51f0 | diff --git a/src/integrations/prefect-kubernetes/prefect_kubernetes/utilities.py b/src/integrations/prefect-kubernetes/prefect_kubernetes/utilities.py
index 879b8cb3e030..3d936de50587 100644
--- a/src/integrations/prefect-kubernetes/prefect_kubernetes/utilities.py
+++ b/src/integrations/prefect-kubernetes/prefect_kuber... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
PrefectHQ__prefect-16393@5edd0fb | PrefectHQ/prefect | Python | 16,393 | Added worker for Snowflake's Snowpark Container Services | This PR adds a new worker to the prefect-snowflake integration. The worker can run service jobs in Snowflake's Snowpark Container Services. Closes #15674
A few things worth mentioning:
- ~~Snowflake's Python API currently doesn't support running async service jobs, so I'm temporarily running jobs using SQL comma... | 2024-12-15T19:51:26Z | New worker for running job services in Snowpark Container Services
### Describe the current behavior
There is no worker suitable for running flows in Snowpark Container Services.
### Describe the proposed behavior
A new worker is added, capable of running flows as job services in Snowpark Container Services.
I've... | Hey @bjorhn! It's super cool to hear that you're developing a worker for Snowpark Container Services! I'm definitely open to exploring adding your implementation to `prefect-snowflake`. When you're ready, feel free to open a PR to `prefect-snowflake` and we can give it a look!
Also, if you run into any issues while ... | [
{
"body": "### Describe the current behavior\n\nThere is no worker suitable for running flows in Snowpark Container Services.\n\n### Describe the proposed behavior\n\nA new worker is added, capable of running flows as job services in Snowpark Container Services.\r\n\r\nI've already developed a worker that does ... | d56349e04592a8b685ab1e49b87af34e61d57749 | {
"head_commit": "5edd0fb9265a37c228f15556eecb255b6d2aaa49",
"head_commit_message": "Formatting",
"patch_to_review": "diff --git a/src/integrations/prefect-snowflake/prefect_snowflake/workers/__init__.py b/src/integrations/prefect-snowflake/prefect_snowflake/workers/__init__.py\nnew file mode 100644\nindex 000000... | [
{
"diff_hunk": "@@ -0,0 +1,621 @@\n+\"\"\"Classes and helper functions for creating a worker that can run job services in Snowpark Container Services.\"\"\"\n+\n+import datetime\n+import os\n+import sys\n+import time\n+from pathlib import Path\n+from typing import TYPE_CHECKING, Any, Literal, Optional\n+from uu... | 90f271145e10cdbce47009833a15c9b3c9684feb | diff --git a/src/integrations/prefect-snowflake/prefect_snowflake/experimental/workers/__init__.py b/src/integrations/prefect-snowflake/prefect_snowflake/experimental/workers/__init__.py
new file mode 100644
index 000000000000..e69de29bb2d1
diff --git a/src/integrations/prefect-snowflake/prefect_snowflake/experimental/... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
PrefectHQ__prefect-14729@f9d348e | PrefectHQ/prefect | Python | 14,729 | let `TaskRunRecorder` process events into task runs/task run states | closes: https://github.com/PrefectHQ/prefect/issues/14648
Updates `TaskRunRecorder` from being a no-op service to actually processing `task-run` events that come through.
For every event we see we'll:
- insert or update the task run
- insert the task run state
- update the task run with the state data | 2024-07-24T13:47:49Z | Create task runs from task run events
`TaskRunRecorder` takes in all task run events that have been orchestrated client side.
It should:
- Create and insert a corresponding `TaskRunState`
- This should be able to handle seeing a duplicate task run state.
- Create and insert/update a corresponding `TaskRun
- If thi... | [
{
"body": "`TaskRunRecorder` takes in all task run events that have been orchestrated client side. \nIt should:\n- Create and insert a corresponding `TaskRunState`\n - This should be able to handle seeing a duplicate task run state.\n- Create and insert/update a corresponding `TaskRun\n - If this is the first... | 44e7ebe7c63b882907b6d67429a7049af045452d | {
"head_commit": "f9d348ea3d528ff8627b20c3fbbad938fd0dc6be",
"head_commit_message": "task run recorder",
"patch_to_review": "diff --git a/src/prefect/server/events/schemas/events.py b/src/prefect/server/events/schemas/events.py\nindex 07b240fd6d7e..8d46e1d70c93 100644\n--- a/src/prefect/server/events/schemas/even... | [
{
"diff_hunk": "@@ -1,14 +1,179 @@\n import asyncio\n-from contextlib import asynccontextmanager\n-from typing import AsyncGenerator, Optional\n+from contextlib import AsyncExitStack, asynccontextmanager\n+from typing import Any, AsyncGenerator, Dict, Optional\n+from uuid import UUID\n+\n+import pendulum\n+impo... | 26e74d59176afc28e3282c1c2d4523a154210f0f | diff --git a/src/prefect/server/events/schemas/events.py b/src/prefect/server/events/schemas/events.py
index 07b240fd6d7e..8d46e1d70c93 100644
--- a/src/prefect/server/events/schemas/events.py
+++ b/src/prefect/server/events/schemas/events.py
@@ -66,6 +66,16 @@ def id(self) -> str:
def name(self) -> Optional[str]:... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
Netflix__metaflow-379@f3cdb4e | Netflix/metaflow | Python | 379 | Pipe conda & Includefile setup logs to stderr | 2020-11-09T22:34:19Z | IncludeFile and @conda logs should go to the stderr
Flows with **IncludeFile** generate info logs in the stdout. They break a generated json when used with "step-functions create --only-json". Prohibits to use the output with other tools (e.g. jq) through the shell pipelines.
Steps to reproduce:
```
$ python 02-... | Thanks for the issue. We will fix this promptly. | [
{
"body": "Flows with **IncludeFile** generate info logs in the stdout. They break a generated json when used with \"step-functions create --only-json\". Prohibits to use the output with other tools (e.g. jq) through the shell pipelines.\r\n\r\nSteps to reproduce:\r\n```\r\n$ python 02-statistics/stats.py --n... | 36e0323dc630ffa85edb8161959223672fac5724 | {
"head_commit": "f3cdb4e6c806f81944de6eff11b09771664a10cd",
"head_commit_message": "Pipe conda & Includefile setup logs to stderr",
"patch_to_review": "diff --git a/metaflow/cli.py b/metaflow/cli.py\nindex a6ea2b84cb7..35fb54091b3 100644\n--- a/metaflow/cli.py\n+++ b/metaflow/cli.py\n@@ -90,15 +90,21 @@ def echo... | [
{
"diff_hunk": "@@ -90,15 +90,21 @@ def echo_always(line, **kwargs):\n click.secho(ERASE_TO_EOL, **kwargs)\n \n \n-def logger(body='', system_msg=False, head='', bad=False, timestamp=True):\n+def logger(body='',\n+ system_msg=False,\n+ head='',\n+ bad=False,\n+ ti... | 93d83e02463807acd78d176e0ea863d57c702a63 | diff --git a/metaflow/cli.py b/metaflow/cli.py
index a6ea2b84cb7..448e2d80871 100644
--- a/metaflow/cli.py
+++ b/metaflow/cli.py
@@ -90,7 +90,11 @@ def echo_always(line, **kwargs):
click.secho(ERASE_TO_EOL, **kwargs)
-def logger(body='', system_msg=False, head='', bad=False, timestamp=True):
+def logger(bo... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} | |
PrefectHQ__prefect-14704@cbc661a | PrefectHQ/prefect | Python | 14,704 | Fix task key computation | closes #13735
this PR removes our reliance on the absolute path of the source file, which caused persistent cache misses due to source code being cloned to tmp dirs
the original issue was reported on a 2.x version - if this looks good I can backport this to `2.x` | 2024-07-22T20:24:15Z | Tasks with persisted results are running again on retry after Prefect 2.16.4
### First check
- [X] I added a descriptive title to this issue.
- [X] I used the GitHub search to find a similar issue and didn't find it.
- [X] I searched the Prefect documentation for this issue.
- [X] I checked that this issue is rel... | [
{
"body": "### First check\r\n\r\n- [X] I added a descriptive title to this issue.\r\n- [X] I used the GitHub search to find a similar issue and didn't find it.\r\n- [X] I searched the Prefect documentation for this issue.\r\n- [X] I checked that this issue is related to Prefect and not one of its dependencies.... | 43af48b59b85f8c1aaf0bf735cae44e80e02027f | {
"head_commit": "cbc661a3a34b0cb6049171a472a88a8cb92c9c85",
"head_commit_message": "use existing const NUM_CHARS_DYNAMIC_KEY",
"patch_to_review": "diff --git a/src/prefect/tasks.py b/src/prefect/tasks.py\nindex 91489192c69a..c5331d10149a 100644\n--- a/src/prefect/tasks.py\n+++ b/src/prefect/tasks.py\n@@ -6,7 +6,... | [
{
"diff_hunk": "@@ -188,6 +187,31 @@ def _infer_parent_task_runs(\n return parents\n \n \n+def _generate_task_key(fn: Callable) -> str:",
"line": null,
"original_line": 190,
"original_start_line": null,
"path": "src/prefect/tasks.py",
"start_line": null,
"text": "@user1:\nnit: Callab... | e7d869161b12c8560b8e56ee413b592d7abd429c | diff --git a/src/prefect/tasks.py b/src/prefect/tasks.py
index 91489192c69a..c5406852e58c 100644
--- a/src/prefect/tasks.py
+++ b/src/prefect/tasks.py
@@ -6,7 +6,6 @@
import datetime
import inspect
-import os
from copy import copy
from functools import partial, update_wrapper
from typing import (
@@ -188,6 +187,... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
PrefectHQ__prefect-14616@fba2a94 | PrefectHQ/prefect | Python | 14,616 | Refactors event causal ordering to be reusable by multiple consumers | For the triggers system, we keep track of out-of-order messages and attempt to
replay them in causal order (where an event is processed after the event that
it declares it `follows`). This change extracts this logic to a class and
separates the bookkeeping records so that multiple consumers can keep separate
track of ... | 2024-07-15T19:02:37Z | Factor the event causal ordering logic out of `triggers`
We are going to want our task run state events to be processed in causal order, so let's lift the logic for that out of `triggers` (`with_preceding_event_confirmed` and friends) so it can be reused. Keep in mind that each group of consumers will need its own ord... | [
{
"body": "We are going to want our task run state events to be processed in causal order, so let's lift the logic for that out of `triggers` (`with_preceding_event_confirmed` and friends) so it can be reused. Keep in mind that each group of consumers will need its own ordering, so these should be tracked in s... | ad8e126b6a07fd6f8e08c9d50c22dabc247f765b | {
"head_commit": "fba2a943c30ebbd94206712cf5b450fb47a4cef7",
"head_commit_message": "Refactors event causal ordering to be reusable by multiple consumers\n\nFor the triggers system, we keep track of out-of-order messages and attempt to\nreplay them in causal order (where an event is processed after the event that\n... | [
{
"diff_hunk": "@@ -0,0 +1,59 @@\n+\"\"\"Adding scope to followers\n+\n+Revision ID: 7495a5013e7e\n+Revises: 94622c1663e8\n+Create Date: 2024-07-15 14:52:40.850932\n+\n+\"\"\"\n+\n+import sqlalchemy as sa\n+from alembic import op\n+\n+# revision identifiers, used by Alembic.\n+revision = \"7495a5013e7e\"\n+down... | 2b0ce76cceaf6474d88aa1431861585ef9b0e218 | diff --git a/src/prefect/server/database/migrations/versions/postgresql/2024_07_15_145240_7495a5013e7e_adding_scope_to_followers.py b/src/prefect/server/database/migrations/versions/postgresql/2024_07_15_145240_7495a5013e7e_adding_scope_to_followers.py
new file mode 100644
index 000000000000..c728f1a49ea5
--- /dev/null... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Code Refactoring / Architectural Improvement"
} | |
PrefectHQ__prefect-14661@5f236b9 | PrefectHQ/prefect | Python | 14,661 | Client Side Task Run Orchestration | This PR adds some conditionals to the `TaskRunEngine` based off `PREFECT_EXPERIMENTAL_ENABLE_CLIENT_SIDE_TASK_ORCHESTRATION`.
If the flag is enabled the engine will not call out to the api to perform orchestration:
- For creating a run, it will generate a `TaskRun` locally (with a client side created id)
- For se... | 2024-07-18T15:31:19Z | Remove task run API calls from `TaskRunEngine`
- When orchestrating a task run, the `TaskRunEngine` makes a number of api calls to create the task run and orchestrate the state. We no longer want the engine to call out to the server to orchestrate.
- This behavior should be conditional on `PREFECT_EXPERIMENTAL_ENABLE_C... | [
{
"body": "- When orchestrating a task run, the `TaskRunEngine` makes a number of api calls to create the task run and orchestrate the state. We no longer want the engine to call out to the server to orchestrate.\n- This behavior should be conditional on `PREFECT_EXPERIMENTAL_ENABLE_CLIENT_SIDE_TASK_ORCHESTRATI... | 6604ec94b21724c1f78f103463ef7353220a379c | {
"head_commit": "5f236b9df2ec1863cb991de0315a1f00aceb9c2b",
"head_commit_message": "don't drain",
"patch_to_review": "diff --git a/src/prefect/events/schemas/events.py b/src/prefect/events/schemas/events.py\nindex 13ffa52c77e5..2085f9f92d11 100644\n--- a/src/prefect/events/schemas/events.py\n+++ b/src/prefect/ev... | [
{
"diff_hunk": "@@ -0,0 +1,1723 @@\n+import asyncio\n+import logging\n+import os\n+import random\n+import time\n+from datetime import timedelta\n+from pathlib import Path\n+from typing import List, Optional\n+from unittest.mock import AsyncMock, MagicMock, call\n+from uuid import UUID, uuid4\n+\n+import anyio\n... | c2204194492c43b84c00302a46d5118b84a730d4 | diff --git a/src/prefect/_internal/concurrency/services.py b/src/prefect/_internal/concurrency/services.py
index 5261297ca185..4e34ba53dabd 100644
--- a/src/prefect/_internal/concurrency/services.py
+++ b/src/prefect/_internal/concurrency/services.py
@@ -151,6 +151,7 @@ async def _main_loop(self):
if ite... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Code Refactoring / Architectural Improvement"
} | |
PrefectHQ__prefect-14608@8a3d00f | PrefectHQ/prefect | Python | 14,608 | Adds `wait` utility for `PrefectFutures` | <!--
Thanks for opening a pull request to Prefect! We've got a few requests to help us review contributions:
- Make sure that your title neatly summarizes the proposed changes.
- Provide a short overview of the change and the value it adds.
- Share an example to help us understand the change in user experience.
... | 2024-07-15T14:46:46Z | Add `wait` utility for `PrefectFuture`s
Add a `wait` utility that mirrors `concurrent.futures.wait`. Should accept an iterable of futures to wait for completion and a timeout. It should return a tuple of futures that have completed and those that have not yet completed. | [
{
"body": "Add a `wait` utility that mirrors `concurrent.futures.wait`. Should accept an iterable of futures to wait for completion and a timeout. It should return a tuple of futures that have completed and those that have not yet completed.",
"number": 14240,
"title": "Add `wait` utility for `PrefectFu... | ad8e126b6a07fd6f8e08c9d50c22dabc247f765b | {
"head_commit": "8a3d00f686f1acf59a72bfb8150c516285f7867a",
"head_commit_message": "waits for sequence of futures",
"patch_to_review": "diff --git a/src/prefect/futures.py b/src/prefect/futures.py\nindex d0df04ea9a5a..269cb040d39c 100644\n--- a/src/prefect/futures.py\n+++ b/src/prefect/futures.py\n@@ -1,4 +1,5 @... | [
{
"diff_hunk": "@@ -297,6 +298,41 @@ def result(\n ) from exc\n \n \n+DoneAndNotDoneFutures = collections.namedtuple(\"DoneAndNotDoneFutures\", \"done not_done\")\n+\n+\n+def wait(pfs: List[PrefectFuture], timeout=None) -> DoneAndNotDoneFutures:",
"line": null,
"original_line": 304,
"ori... | 0083176c812df104f6df817dc419027938c0c867 | diff --git a/src/prefect/futures.py b/src/prefect/futures.py
index d0df04ea9a5a..7379aa8c8b06 100644
--- a/src/prefect/futures.py
+++ b/src/prefect/futures.py
@@ -1,4 +1,5 @@
import abc
+import collections
import concurrent.futures
import inspect
import uuid
@@ -256,13 +257,7 @@ def wait(self, timeout: Optional[flo... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
PrefectHQ__prefect-14392@aac04aa | PrefectHQ/prefect | Python | 14,392 | Mark older issues with high engagement as requiring triage | Closes #14304 | 2024-06-27T23:19:06Z | Mark older issues with high engagement as requiring triage
### First check
- [X] I am a contributor to the Prefect codebase
### Description
We should have a way of revisiting older issues that users express interest/concern in
it should be pretty easy to use the GitHub API to automate a process to check for... | [
{
"body": "### First check\r\n\r\n- [X] I am a contributor to the Prefect codebase\r\n\r\n### Description\r\n\r\nWe should have a way of revisiting older issues that users express interest/concern in\r\n\r\nit should be pretty easy to use the GitHub API to automate a process to check for older issues with high ... | 939a262a9df5a858de50e5a8a089071392b47d83 | {
"head_commit": "aac04aaccac538837cdab204d0e40a78d197e27f",
"head_commit_message": "add clarifying example",
"patch_to_review": "diff --git a/.github/workflows/surface-high-engagement-issues.yml b/.github/workflows/surface-high-engagement-issues.yml\nnew file mode 100644\nindex 000000000000..8b47406dae87\n--- /d... | [
{
"diff_hunk": "@@ -0,0 +1,503 @@\n+import argparse\n+import os\n+import re\n+import shutil\n+import subprocess\n+import sys\n+from datetime import datetime, timedelta\n+from typing import Union\n+\n+import httpx\n+\n+GITHUB_REPO = \"PrefectHQ/prefect\"\n+TOKEN_REGEX = re.compile(r\"\\s* Token:\\s(.*)\")\n+ENGA... | 3078526b1738788f4b098ef02321d49cfaf2774a | diff --git a/.github/workflows/surface-high-engagement-issues.yml b/.github/workflows/surface-high-engagement-issues.yml
new file mode 100644
index 000000000000..8b47406dae87
--- /dev/null
+++ b/.github/workflows/surface-high-engagement-issues.yml
@@ -0,0 +1,30 @@
+name: Surface High Engagement Issues
+
+on:
+ schedul... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} | |
PrefectHQ__prefect-14557@795943f | PrefectHQ/prefect | Python | 14,557 | include integration info in `prefect version` | closes https://github.com/PrefectHQ/prefect/issues/14533
includes installed packages named `prefect-*` that are published by us
```console
(prefect) nate :: ~/github.com/prefecthq/prefect ‹main*›
» prefect version
Version: 3.0.0rc10+37.g3c36b3fe90.dirty
API version: 0.8.4
Python version: ... | 2024-07-10T21:51:49Z | integration information in `prefect version`
### First check
- [X] I added a descriptive title to this issue.
- [X] I used the GitHub search to find a similar request and didn't find it.
- [X] I searched the Prefect documentation for this feature.
### Prefect Version
3.x
### Describe the current behavior
`prefect ... | [
{
"body": "### First check\n\n- [X] I added a descriptive title to this issue.\n- [X] I used the GitHub search to find a similar request and didn't find it.\n- [X] I searched the Prefect documentation for this feature.\n\n### Prefect Version\n\n3.x\n\n### Describe the current behavior\n\n`prefect version` only ... | 12e8a77f4f56c0d136a7b50f5198705e6816ca6c | {
"head_commit": "795943fb0c4213093f110447aff4493ec816629f",
"head_commit_message": "Merge branch 'main' into integration-versions",
"patch_to_review": "diff --git a/src/prefect/cli/root.py b/src/prefect/cli/root.py\nindex 9c994de174d3..d01afe5d730e 100644\n--- a/src/prefect/cli/root.py\n+++ b/src/prefect/cli/roo... | [
{
"diff_hunk": "@@ -125,27 +129,47 @@\n version_info[\"Server type\"] = server_type.lower()\n \n try:\n- pydantic_version = version(\"pydantic\")\n+ pydantic_version = import_version(\"pydantic\")\n except PackageNotFoundError:\n pydantic_version = \"Not installed\"\n \n ve... | 23dc57e16f9488ea9bcda586554f277624b57e0b | diff --git a/src/prefect/cli/root.py b/src/prefect/cli/root.py
index 9c994de174d3..bb98e6c6e6ac 100644
--- a/src/prefect/cli/root.py
+++ b/src/prefect/cli/root.py
@@ -5,6 +5,9 @@
import asyncio
import platform
import sys
+from importlib.metadata import PackageNotFoundError
+from importlib.metadata import version as ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
PrefectHQ__prefect-14313@d428713 | PrefectHQ/prefect | Python | 14,313 | Refactor and reorganize the 3.0 docs in the Deploy section | This PR is an attempt to refactor and reorganize all of the 3.0 deploy docs to minimize the amount of overlap between docs and to make the relationships between pages clearer at a glance.
* Establish two main categories of infra docs: concepts and examples.
* Create an umbrella **Deployments overview** page with an... | 2024-06-24T21:57:32Z | Reduce the content on some Deploy section docs pages
### First check
- [X] I added a descriptive title to this issue.
- [X] I used GitHub search to find a similar request and didn't find it 😇
### Describe the issue
Two docs pages that feel quite onerous in length:
Work pools and workers: 3.0rc/deploy/work-pools/... | As mentioned in Slack, I think **Work pools and workers** could be broken up into two pages: **Work pools** and **Workers**.
**Deploy flows to work pools and workers** doesn't seem quite as clear-cut, but one thought is to use a tabbed component when showing equivalent instructions for different deploy providers (e.... | [
{
"body": "### First check\n\n- [X] I added a descriptive title to this issue.\n- [X] I used GitHub search to find a similar request and didn't find it 😇\n\n### Describe the issue\n\nTwo docs pages that feel quite onerous in length:\r\n\r\nWork pools and workers: 3.0rc/deploy/work-pools/control-runs\r\nDeploy ... | 59352a2bcd2493057728c651aff8bd7026b3fff3 | {
"head_commit": "d4287131c1e9a3fb4eeaf017c8f1254d5e3915b8",
"head_commit_message": "Remove warning to not use flow.serve in production deployments",
"patch_to_review": "diff --git a/docs/3.0rc/automate/add-schedules.mdx b/docs/3.0rc/automate/add-schedules.mdx\nindex 0961c38554b3..b58bda8f5679 100644\n--- a/docs/... | [
{
"diff_hunk": "@@ -12,7 +12,9 @@ search:\n boost: 2\n ---\n \n-[Deployments](/3.0rc/deploy/serve-flows/) are server-side representations of flows. \n+## What is a deployment?",
"line": null,
"original_line": 15,
"original_start_line": null,
"path": "docs/3.0rc/deploy/index.mdx",
"start_li... | e9aa1c5c954bfd1cf57f60cd226dfa972e0b0a11 | diff --git a/docs/3.0rc/automate/add-schedules.mdx b/docs/3.0rc/automate/add-schedules.mdx
index 0961c38554b3..b58bda8f5679 100644
--- a/docs/3.0rc/automate/add-schedules.mdx
+++ b/docs/3.0rc/automate/add-schedules.mdx
@@ -4,7 +4,7 @@ description: Prefect can schedule when to automatically create new flow runs.
---
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Documentation Updates"
} |
PrefectHQ__prefect-14359@c1c6e2c | PrefectHQ/prefect | Python | 14,359 | Fix error when returning from task and flows with `cache_result_in_memory=False` | <!--
Thanks for opening a pull request to Prefect! We've got a few requests to help us review contributions:
- Make sure that your title neatly summarizes the proposed changes.
- Provide a short overview of the change and the value it adds.
- Share an example to help us understand the change in user experience.
... | 2024-06-26T20:03:33Z | Turning off result caching in memory crashes tasks
MRE:
```python
from prefect import flow, task
@task(cache_result_in_memory=False)
def my_task():
return 42
@flow
def my_flow():
my_task()
if __name__ == "__main__":
my_flow()
```
Output:
```
13:49:25.313 | INFO | Task run 'my_task' - Created task r... | Resolution of this issue likely involves not relying on the result from the task run state when returning a value to the user from the task engine. | [
{
"body": "MRE:\n```python\nfrom prefect import flow, task\n\n\n@task(cache_result_in_memory=False)\ndef my_task():\n return 42\n\n@flow\ndef my_flow():\n my_task()\n\n\nif __name__ == \"__main__\":\n my_flow()\n```\n\nOutput:\n```\n13:49:25.313 | INFO | Task run 'my_task' - Created task run 'my_tas... | f195e459089d9e596d9bb10799273d5dc0ba3c1f | {
"head_commit": "c1c6e2cb1ff0ce49beccd3d9b8126a6410405084",
"head_commit_message": "Add missing change",
"patch_to_review": "diff --git a/src/prefect/flow_engine.py b/src/prefect/flow_engine.py\nindex a1e5378909f6..a240a0696d5f 100644\n--- a/src/prefect/flow_engine.py\n+++ b/src/prefect/flow_engine.py\n@@ -16,6 ... | [
{
"diff_hunk": "@@ -95,6 +97,7 @@ class FlowRunEngine(Generic[P, R]):\n flow_run_id: Optional[UUID] = None\n logger: logging.Logger = field(default_factory=lambda: get_logger(\"engine\"))\n wait_for: Optional[Iterable[PrefectFuture]] = None\n+ _result: Union[R, Exception, Type[NotSet]] = NotSet",... | 37cf44f9c2e1b2bc4bc222a41480234fd13df18f | diff --git a/src/prefect/flow_engine.py b/src/prefect/flow_engine.py
index 9c25c1edfcba..afbea2ff1e68 100644
--- a/src/prefect/flow_engine.py
+++ b/src/prefect/flow_engine.py
@@ -16,6 +16,7 @@
Literal,
Optional,
Tuple,
+ Type,
TypeVar,
Union,
cast,
@@ -39,7 +40,7 @@
get_run_logger,... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
PrefectHQ__prefect-14093@a2f92d6 | PrefectHQ/prefect | Python | 14,093 | Add OSS to the quickstart | The quickstart is cloud-centric. Because OSS is a popular path for first-time users, let's update the quickstart to give people the option of whether they want to go down the cloud or OSS path.
Closes https://github.com/PrefectHQ/prefect/issues/14029
This PR also converts the quickstart to [ventilated prose](http... | 2024-06-17T20:15:10Z | Update the Quickstart to reflect OSS options
### First check
- [X] I added a descriptive title to this issue.
- [X] I used GitHub search to find a similar request and didn't find it 😇
### Describe the issue
The quickstart in the 3.0 docs is currently aimed only at Prefect Cloud.
### Describe the proposed... | Working on this in a branch: https://github.com/PrefectHQ/prefect/tree/add_oss_to_the_quickstart | [
{
"body": "### First check\r\n\r\n- [X] I added a descriptive title to this issue.\r\n- [X] I used GitHub search to find a similar request and didn't find it 😇\r\n\r\n### Describe the issue\r\n\r\nThe quickstart in the 3.0 docs is currently aimed only at Prefect Cloud. \r\n\r\n### Describe the proposed change\... | 4ad66e738ee6900da581179d9b807c165ce44b9b | {
"head_commit": "a2f92d60b86c86c49668092614147f2b65ed4549",
"head_commit_message": "Merge branch 'main' into add_oss_to_the_quickstart",
"patch_to_review": "diff --git a/docs/3.0rc/get-started/quickstart.mdx b/docs/3.0rc/get-started/quickstart.mdx\nindex 93ab4a34d153..6be69f18a4b0 100644\n--- a/docs/3.0rc/get-st... | [
{
"diff_hunk": "@@ -25,47 +23,63 @@ if __name__ == \"__main__\":\n get_repo_info()\n ```\n \n-The following steps convert this script to a schedulable, observable, resilient, and deployable workflow.\n-\n ## Install Prefect\n \n+Install the Prefect client.\n+If needed, see [Install Prefect](/3.0rc/get-start... | 3fd638656bc171800f73a35eafd5ebd135311b6e | diff --git a/docs/3.0rc/get-started/quickstart.mdx b/docs/3.0rc/get-started/quickstart.mdx
index 351e95b9740f..8d6a75ab6eae 100644
--- a/docs/3.0rc/get-started/quickstart.mdx
+++ b/docs/3.0rc/get-started/quickstart.mdx
@@ -3,18 +3,14 @@ title: Quickstart
description: Get started with Prefect, the easiest way to orches... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Documentation Updates"
} |
PrefectHQ__prefect-13938@4860866 | PrefectHQ/prefect | Python | 13,938 | make task worker resilient to errors | Previously any unhandled exceptions inside of `_submit_scheduled_task_run` would be raised and could lead to the worker shutting down. This particularly problematic because we re-raise a lot of errors in the task run engine.
https://github.com/PrefectHQ/prefect/blob/main/src/prefect/task_engine.py#L472-L486
This... | 2024-06-11T19:16:32Z | task worker shuts down on `Abort`
### First check
- [X] I added a descriptive title to this issue.
- [X] I used the GitHub search to find a similar issue and didn't find it.
- [X] I searched the Prefect documentation for this issue.
- [X] I checked that this issue is related to Prefect and not one of its dependencies.... | [
{
"body": "### First check\n\n- [X] I added a descriptive title to this issue.\n- [X] I used the GitHub search to find a similar issue and didn't find it.\n- [X] I searched the Prefect documentation for this issue.\n- [X] I checked that this issue is related to Prefect and not one of its dependencies.\n\n### Bu... | 86217da3b18890aa6540ac0105f7ef4f022afdd8 | {
"head_commit": "48608660910e487738d3796d887f7e423ef2599d",
"head_commit_message": "fix comment",
"patch_to_review": "diff --git a/src/prefect/task_worker.py b/src/prefect/task_worker.py\nindex 0b7585da3f6c..8f9e1e2caef4 100644\n--- a/src/prefect/task_worker.py\n+++ b/src/prefect/task_worker.py\n@@ -156,12 +156,... | [
{
"diff_hunk": "@@ -156,12 +156,24 @@ async def _subscribe_to_task_scheduling(self):\n client_id=self._client_id,\n base_url=base_url,\n ):\n+ logger.info(f\"Received task run: {task_run.id} - {task_run.name}\")\n if self._limiter:\n await s... | 73d9a57ea4f44c68d486de3ea193fef2f49b417f | diff --git a/src/prefect/task_worker.py b/src/prefect/task_worker.py
index 0b7585da3f6c..214dba14a941 100644
--- a/src/prefect/task_worker.py
+++ b/src/prefect/task_worker.py
@@ -156,10 +156,24 @@ async def _subscribe_to_task_scheduling(self):
client_id=self._client_id,
base_url=base_url,
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
PrefectHQ__prefect-13924@6a413e4 | PrefectHQ/prefect | Python | 13,924 | Automating the Mintlify OpenAPI docs | This script will reconcile the current state of the REST API with what's in
the `docs/<version>/api-ref/server` directory, as well as the navigation within
the `mint.json` file that defines the overall documentation.
I'm also wiring this script up as a pre-commit hook so that any changes to the
API and schemas are aut... | 2024-06-11T17:10:51Z | Automate the production of the Mintlify OpenAPI docs
We've got a manual process now that involves:
1. Producing the `schema.json` file using our script and FastAPI's tooling
2. Adding a few fields to the file to make it amenable to Mintlify's scraper
3. Running the `mintlify-scrape openapi-file ...` command to pro... | [
{
"body": "We've got a manual process now that involves:\r\n\r\n1. Producing the `schema.json` file using our script and FastAPI's tooling\r\n2. Adding a few fields to the file to make it amenable to Mintlify's scraper\r\n3. Running the `mintlify-scrape openapi-file ...` command to produce the markdown docs\r\n... | 05c097cff66f9f531c1cf5ede5a328007416772d | {
"head_commit": "6a413e46046d6fd12bfd05f4c2ae635175fdb457",
"head_commit_message": "Automating the Mintlify OpenAPI docs\n\nThis script will reconcile the current state of the REST API with what's in\nthe `docs/<version>/api-ref/server` directory, as well as the navigation within\nthe `mint.json` file that defines... | [
{
"diff_hunk": "@@ -0,0 +1,168 @@\n+#!/usr/bin/env python3\n+import json\n+import subprocess\n+import sys\n+from pathlib import Path\n+from typing import Any, Union\n+\n+from prefect.server.api.server import create_app\n+\n+Mint = dict[str, Any]\n+Navigation = list[dict[str, Any]]\n+SinglePage = str\n+PageGroup... | 85fdfdebc18bab365baa1f6ebf7858ef4b11db5b | diff --git a/.github/workflows/static-analysis.yaml b/.github/workflows/static-analysis.yaml
index e91a12f721e4..8fef56447baa 100644
--- a/.github/workflows/static-analysis.yaml
+++ b/.github/workflows/static-analysis.yaml
@@ -27,15 +27,37 @@ jobs:
- uses: actions/checkout@v4
with:
persist-cr... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Test Suite / CI Enhancements"
} | |
PrefectHQ__prefect-13756@9326330 | PrefectHQ/prefect | Python | 13,756 | Adds `deferred` kwarg to `Task.map` to executed mapped tasks on a task server | <!--
Thanks for opening a pull request to Prefect! We've got a few requests to help us review contributions:
- Make sure that your title neatly summarizes the proposed changes.
- Provide a short overview of the change and the value it adds.
- Share an example to help us understand the change in user experience.
... | 2024-06-03T18:59:54Z | Add a `deferred` parameter to `Task.map` to control whether to defer or submit tasks
Currently, `Task.map` always submits tasks within a flow or defers tasks outside of a flow. But now that we support using `delay` and `apply_async` within flows correctly, a flow might want to defer tasks with `map` and may not be usin... | [
{
"body": "Currently, `Task.map` always submits tasks within a flow or defers tasks outside of a flow. But now that we support using `delay` and `apply_async` within flows correctly, a flow might want to defer tasks with `map` and may not be using `PrefectTaskRunner`, so we should allow controlling map behavior... | 38b424138539decd1ce396d0d73c6b73451e547b | {
"head_commit": "9326330b52c90d7028834f66770b110dc2a2748e",
"head_commit_message": "Fixes failing tests",
"patch_to_review": "diff --git a/src/prefect/tasks.py b/src/prefect/tasks.py\nindex ec2dcd497d0b..96d0a153ba69 100644\n--- a/src/prefect/tasks.py\n+++ b/src/prefect/tasks.py\n@@ -849,7 +849,11 @@ def submit(... | [
{
"diff_hunk": "@@ -1026,22 +1032,21 @@ def map(\n \"`task.map()` is not currently supported by `flow.visualize()`\"\n )\n \n- if not flow_run_context:\n- # TODO: Should we split out background task mapping into a separate method\n- # like we do for the `... | d5e8e155f2ce6ee305dd3643cc04425734204ab7 | diff --git a/src/prefect/tasks.py b/src/prefect/tasks.py
index ec2dcd497d0b..ece4963f9dc0 100644
--- a/src/prefect/tasks.py
+++ b/src/prefect/tasks.py
@@ -849,7 +849,11 @@ def submit(
flow_run_context = FlowRunContext.get()
if not flow_run_context:
- raise ValueError("Task.submit() must b... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
PrefectHQ__prefect-13983@91295af | PrefectHQ/prefect | Python | 13,983 | Add default store for transactions | <!--
Thanks for opening a pull request to Prefect! We've got a few requests to help us review contributions:
- Make sure that your title neatly summarizes the proposed changes.
- Provide a short overview of the change and the value it adds.
- Share an example to help us understand the change in user experience.
... | 2024-06-12T20:43:48Z | Add default local storage persistence for transactions
Setting up a transaction store is difficult because it requires creating a result store, which requires creating a block. Without a store, transaction results are not persisted. We should be able to set up a default transaction store for users that uses local stora... | Just a thought: we could allow configuring the directory where results are stored along with its structure via a setting for easy testing and local dev.
I like that idea! Can you elaborate on configuring the structure via a setting? What are some examples of structures that we might offer?
I might be a one trick pony o... | [
{
"body": "Setting up a transaction store is difficult because it requires creating a result store, which requires creating a block. Without a store, transaction results are not persisted. We should be able to set up a default transaction store for users that uses local storage. We should not create an anonymou... | 9796f50dac1f140357899644a30ca05a501c0ff4 | {
"head_commit": "91295af0e8e4b8bead796c5dd4358586200947bb",
"head_commit_message": "Add default store and key for `transaction` context manager",
"patch_to_review": "diff --git a/src/prefect/context.py b/src/prefect/context.py\nindex 544ef2d96b5e..4f04a6d2bab1 100644\n--- a/src/prefect/context.py\n+++ b/src/pref... | [
{
"diff_hunk": "@@ -218,6 +234,35 @@ def transaction(\n commit_mode: CommitMode = CommitMode.LAZY,\n overwrite: bool = False,\n ) -> Generator[Transaction, None, None]:\n+ \"\"\"\n+ A context manager for opening and managing a transaction.\n+\n+ Args:\n+ - key: An identifier to use for t... | 78d2a21fcde85f00dcc0e34469b4148d1066fcb4 | diff --git a/src/prefect/results.py b/src/prefect/results.py
index 28784f21a6b8..df4feaccea9a 100644
--- a/src/prefect/results.py
+++ b/src/prefect/results.py
@@ -37,6 +37,7 @@
PREFECT_RESULTS_DEFAULT_SERIALIZER,
PREFECT_RESULTS_PERSIST_BY_DEFAULT,
PREFECT_TASK_SCHEDULING_DEFAULT_STORAGE_BLOCK,
+ defa... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
PrefectHQ__prefect-14144@e7c9c21 | PrefectHQ/prefect | Python | 14,144 | Remove references to `ConcurrentTaskRunner` from docs and ensure examples use `.wait()` | Closes #13953
Helps to close #13954 but I have other pages to take a pass at
<!-- Include an overview here -->
### Example
<!--
Share an example of the change in action.
A code blurb is best. Changes to features should include an example that is executable by a new user.
If changing documentation, a link ... | 2024-06-19T13:05:02Z | Remove all references to `ConcurrentTaskRunner` in 3.0 docs
### First check
- [X] I added a descriptive title to this issue.
- [X] I used GitHub search to find a similar request and didn't find it 😇
### Describe the issue
`ConcurrentTaskRunner` has been replaced by `ThreadPoolTaskRunner`.
### Describe the proposed... | [
{
"body": "### First check\n\n- [X] I added a descriptive title to this issue.\n- [X] I used GitHub search to find a similar request and didn't find it 😇\n\n### Describe the issue\n\n`ConcurrentTaskRunner` has been replaced by `ThreadPoolTaskRunner`.\n\n### Describe the proposed change\n\nReplace mentions/exam... | 4b3b4e16c4bf1d66c217ae588dc166983dd1cc73 | {
"head_commit": "e7c9c2189cb876c844af780fd49a175b7d74808b",
"head_commit_message": "Remove remaining ConcurrentTaskRunner",
"patch_to_review": "diff --git a/docs/2.19.x/concepts/task-runners.mdx b/docs/2.19.x/concepts/task-runners.mdx\nindex e03af3436735..eb4c61eeadaa 100644\n--- a/docs/2.19.x/concepts/task-runn... | [
{
"diff_hunk": "@@ -16,27 +16,26 @@ enables you to run tasks concurrently, or in parallel using a distributed execut\n ### Submitting tasks\n \n Using the `.submit()` method to submit a task also causes the task run to return a \n-[`PrefectFuture`](/3.0rc/api-ref/prefect/futures/#prefect.futures.PrefectFuture),... | f845b52691168899242e38b3ffc87df922953079 | diff --git a/docs/2.19.x/concepts/task-runners.mdx b/docs/2.19.x/concepts/task-runners.mdx
index e03af3436735..00d2f0918596 100644
--- a/docs/2.19.x/concepts/task-runners.mdx
+++ b/docs/2.19.x/concepts/task-runners.mdx
@@ -1,5 +1,5 @@
---
-title: task Runners
+title: Task runners
description: Task runners enable you ... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Documentation Updates"
} | |
PrefectHQ__prefect-13159@79d96c6 | PrefectHQ/prefect | Python | 13,159 | Warn when work queues paused when starting a worker or agent | ## Examples
### Workers
#### Starting a worker normally when at least one work queue is unpaused does not warn
```bash
❯ prefect worker start -p local-pool
Discovered type 'process' for work pool 'local-pool'.
Worker 'ProcessWorker 8fdf8693-a018-4634-a677-73f6f11e7678' started!
```
#### Starting a worker when a... | 2024-04-29T19:11:59Z | Add a warning message when the default work queue is paused
### First check
- [X] I added a descriptive title to this issue.
- [X] I used the GitHub search to find a similar request and didn't find it.
- [X] I searched the Prefect documentation for this feature.
### Prefect Version
2.x
### Describe the cu... | @zhen0
> I get an error message saying the default work queue is paused.
A warning or an error? Seems like the agent should probably continue to run.
@billpalombi could you triage this?
Hmm, this is tricky. The agent (and workers) will successfully find the work pool, but I don't think it has any way of knowing ... | [
{
"body": "### First check\r\n\r\n- [X] I added a descriptive title to this issue.\r\n- [X] I used the GitHub search to find a similar request and didn't find it.\r\n- [X] I searched the Prefect documentation for this feature.\r\n\r\n### Prefect Version\r\n\r\n2.x\r\n\r\n### Describe the current behavior\r\n\r\... | 280a5bbb52c9978b616efd2ba4b7292b50754da3 | {
"head_commit": "79d96c678dbca1c3e4a145f8625d0b63adea4737",
"head_commit_message": "update docstring",
"patch_to_review": "diff --git a/src/prefect/cli/agent.py b/src/prefect/cli/agent.py\nindex 7f7022b428bb..e5061a845d0c 100644\n--- a/src/prefect/cli/agent.py\n+++ b/src/prefect/cli/agent.py\n@@ -4,7 +4,7 @@\n \... | [
{
"diff_hunk": "@@ -222,6 +240,35 @@ async def _check_work_pool_paused(work_pool_name: str) -> bool:\n return False\n \n \n+async def _check_work_queues_paused(\n+ work_pool_name: str, work_queues: Optional[List[str]]\n+) -> bool:\n+ \"\"\"\n+ Check if all work queues in the work pool are pause... | b1c5199193ddeb16f4bdcaab7d831d184246eb41 | diff --git a/src/prefect/cli/agent.py b/src/prefect/cli/agent.py
index 7f7022b428bb..e5061a845d0c 100644
--- a/src/prefect/cli/agent.py
+++ b/src/prefect/cli/agent.py
@@ -4,7 +4,7 @@
import os
from functools import partial
-from typing import List
+from typing import List, Optional
from uuid import UUID
import ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
PrefectHQ__prefect-13882@e7904fc | PrefectHQ/prefect | Python | 13,882 | Adds circuit breaker when a task depends on itself | <!--
Thanks for opening a pull request to Prefect! We've got a few requests to help us review contributions:
- Make sure that your title neatly summarizes the proposed changes.
- Provide a short overview of the change and the value it adds.
- Share an example to help us understand the change in user experience.
... | 2024-06-07T19:01:15Z | Strange hanging behavior with `ThreadPoolTaskRunner` and `wait_for`
### First check
- [X] I added a descriptive title to this issue.
- [X] I used the GitHub search to find a similar issue and didn't find it.
- [X] I searched the Prefect documentation for this issue.
- [X] I checked that this issue is related to Prefec... | potentially related to https://github.com/PrefectHQ/nebula/issues/7925 | [
{
"body": "### First check\n\n- [X] I added a descriptive title to this issue.\n- [X] I used the GitHub search to find a similar issue and didn't find it.\n- [X] I searched the Prefect documentation for this issue.\n- [X] I checked that this issue is related to Prefect and not one of its dependencies.\n\n### Bu... | 5808b64d5929a0e9bcaa7cc50f9e1bca61656145 | {
"head_commit": "e7904fcdfc950bfb00f86b5e719a84178dd5de49",
"head_commit_message": "Adds circuit breaker when a task depends on itself",
"patch_to_review": "diff --git a/src/prefect/task_engine.py b/src/prefect/task_engine.py\nindex ba03ff2a3777..5862b642aa90 100644\n--- a/src/prefect/task_engine.py\n+++ b/src/p... | [
{
"diff_hunk": "@@ -640,6 +640,28 @@ def test_flow():\n assert y == i + 1\n assert exceptions_equal(z, ValueError(\"Fail task\"))\n \n+ async def test_raises_if_depends_on_itself(self):\n+ @task\n+ def say_hello(name):\n+ return f\"Hello {name}!\"\n+\n+ ... | 0dc7eb99949cb42e4016cd33bc3698d2e2f301ff | diff --git a/src/prefect/task_engine.py b/src/prefect/task_engine.py
index 3288038cea8e..1636e3be18be 100644
--- a/src/prefect/task_engine.py
+++ b/src/prefect/task_engine.py
@@ -218,7 +218,7 @@ def _wait_for_dependencies(self):
return_data=False,
max_depth=-1,
remove_annotations=... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
PrefectHQ__prefect-13152@c831636 | PrefectHQ/prefect | Python | 13,152 | Allow case-insensitive state and state type handling when listing flow runs via CLI | ### Examples
#### Improving `--help` display for `prefect flow-runs ls`
```bash
❯ prefect flow-runs ls --help
... | 2024-04-29T16:22:36Z | Handle state parameter case in CLI `flow-run ls`
### First check
- [X] I added a descriptive title to this issue.
- [X] I used the GitHub search to find a similar request and didn't find it.
- [X] I searched the Prefect documentation for this feature.
### Prefect Version
2.x
### Describe the current behavior
When ... | Oh, another frustration, the `State` column shows the values in all uppercase, even when running with `--state Running`, which makes it very easy to assume that uppercase is required when it actually doesn't work.
thanks for the issue @NodeJSmith! we've added this to the backlog
@NodeJSmith, this casing may be causing ... | [
{
"body": "### First check\n\n- [X] I added a descriptive title to this issue.\n- [X] I used the GitHub search to find a similar request and didn't find it.\n- [X] I searched the Prefect documentation for this feature.\n\n### Prefect Version\n\n2.x\n\n### Describe the current behavior\n\nWhen running `prefect f... | 13ff6063de1a216fa75e4452c9f7d779a9b91c76 | {
"head_commit": "c83163676b22f802d320ce7d3241c759d38d080b",
"head_commit_message": "add back last test",
"patch_to_review": "diff --git a/src/prefect/cli/flow_run.py b/src/prefect/cli/flow_run.py\nindex a58868de01ae..808170e59230 100644\n--- a/src/prefect/cli/flow_run.py\n+++ b/src/prefect/cli/flow_run.py\n@@ -1... | [
{
"diff_hunk": "@@ -57,19 +57,57 @@ async def ls(\n flow_name: List[str] = typer.Option(None, help=\"Name of the flow\"),\n limit: int = typer.Option(15, help=\"Maximum number of flow runs to list\"),\n state: List[str] = typer.Option(None, help=\"Name of the flow run's state\"),\n- state_type: L... | ec46ace810e1ce1357b5ff05d5b4d94f19f39e87 | diff --git a/src/prefect/cli/flow_run.py b/src/prefect/cli/flow_run.py
index a58868de01ae..bb34c38332a6 100644
--- a/src/prefect/cli/flow_run.py
+++ b/src/prefect/cli/flow_run.py
@@ -23,6 +23,7 @@
from prefect.client.schemas.responses import SetStateStatus
from prefect.client.schemas.sorting import FlowRunSort, LogSo... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
PrefectHQ__prefect-12743@8cc912f | PrefectHQ/prefect | Python | 12,743 | Add `.serve`, `.deploy`, and composite trigger examples to deployment triggers docs | <!--
Thanks for opening a pull request to Prefect! We've got a few requests to help us review contributions:
- Make sure that your title neatly summarizes the proposed changes.
- Provide a short overview of the change and the value it adds.
- Share an example to help us understand the change in user experience.
... | 2024-04-15T22:18:38Z | Add example of using `flow.deploy` with a trigger
### First check
- [X] I added a descriptive title to this issue.
- [X] I used GitHub search to find a similar request and didn't find it 😇
### Describe the issue
The Automations guide contains an example of `prefect deploy` with a trigger in a YAML file.
### Descri... | [
{
"body": "### First check\n\n- [X] I added a descriptive title to this issue.\n- [X] I used GitHub search to find a similar request and didn't find it 😇\n\n### Describe the issue\n\nThe Automations guide contains an example of `prefect deploy` with a trigger in a YAML file.\n\n### Describe the proposed change... | a45db9b523336aeadbb24f22cf81493811c3e3e3 | {
"head_commit": "8cc912fae201313c687e1f3c5e6f49e4f16b7b73",
"head_commit_message": "Merge branch 'main' into docs-deploy-trigger",
"patch_to_review": "diff --git a/docs/concepts/automations.md b/docs/concepts/automations.md\nindex 401f95e703db..e1e3d18c6900 100644\n--- a/docs/concepts/automations.md\n+++ b/docs/... | [
{
"diff_hunk": "@@ -573,7 +579,101 @@ deployments:\n param_1: \"{{ event }}\"\n ```\n \n-At deployment time, this will create a linked automation that is triggered by events matching your chosen [grammar](/concepts/events/#event-grammar), which will pass the templatable `event` as a parameter to the d... | 7783db54d03e20d76cc4079409734e6963658f00 | diff --git a/docs/concepts/automations.md b/docs/concepts/automations.md
index 401f95e703db..61ac751ea737 100644
--- a/docs/concepts/automations.md
+++ b/docs/concepts/automations.md
@@ -556,15 +556,21 @@ Sequence triggers are defined as:
To enable the simple configuration of event-driven deployments, Prefect provid... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "New Feature Additions"
} | |
PrefectHQ__prefect-12637@a6fe538 | PrefectHQ/prefect | Python | 12,637 | Enable `EventsWorker` to emit events to Prefect servers | <!--
Thanks for opening a pull request to Prefect! We've got a few requests to help us review contributions:
- Make sure that your title neatly summarizes the proposed changes.
- Provide a short overview of the change and the value it adds.
- Share an example to help us understand the change in user experience.
... | 2024-04-09T21:00:15Z | Update OSS events client to write to OSS server
The `EventsWorker` only emits events when Prefect Cloud is configured as the backend. Now that we can send events to OSS Prefect servers, the `EventsWorker` needs to be updated to emit events to OSS Prefect servers too. | [
{
"body": "The `EventsWorker` only emits events when Prefect Cloud is configured as the backend. Now that we can send events to OSS Prefect servers, the `EventsWorker` needs to be updated to emit events to OSS Prefect servers too.",
"number": 12631,
"title": "Update OSS events client to write to OSS ser... | 3e89b2c175e8ab5162de1d8f4e91b6bed9e065bc | {
"head_commit": "a6fe538f3552f96f5e526a99347d0fbc60573812",
"head_commit_message": "Rename function",
"patch_to_review": "diff --git a/src/prefect/events/clients.py b/src/prefect/events/clients.py\nindex ce21dd9cc522..a0bdddefdb1e 100644\n--- a/src/prefect/events/clients.py\n+++ b/src/prefect/events/clients.py\n... | [
{
"diff_hunk": "@@ -238,6 +239,46 @@ async def _emit(self, event: Event) -> None:\n await asyncio.sleep(1)\n \n \n+class PrefectCloudEventsClient(PrefectEventsClient):\n+ \"\"\"A Prefect Events client that streams events to a Prefect Cloud Workspace\"\"\"\n+\n+ _websocket: Optional[Web... | e9018873fd4933da684a70c4fdb27f3b7450569d | diff --git a/src/prefect/events/clients.py b/src/prefect/events/clients.py
index ce21dd9cc522..f4a6cdfad581 100644
--- a/src/prefect/events/clients.py
+++ b/src/prefect/events/clients.py
@@ -17,6 +17,7 @@
import orjson
import pendulum
from cachetools import TTLCache
+from typing_extensions import Self
from websocke... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
PrefectHQ__prefect-12422@068f251 | PrefectHQ/prefect | Python | 12,422 | Add auto-provisioning option for Cloud Run V2 push work pools | Closes #12421
Adds auto-provisioning to the one push work pool that didn't have it.
Requested by a user in Community Slack.
<!-- Include an overview here -->
### Example
<!--
Share an example of the change in action.
A code blurb is best. Changes to features should include an example that is executabl... | 2024-03-25T22:25:04Z | Add infrastructure auto-provisioning for Google Cloud Run V2 push work pools
### First check
- [X] I added a descriptive title to this issue.
- [X] I used the GitHub search to find a similar request and didn't find it.
- [X] I searched the Prefect documentation for this feature.
### Prefect Version
2.x
### Describe... | [
{
"body": "### First check\n\n- [X] I added a descriptive title to this issue.\n- [X] I used the GitHub search to find a similar request and didn't find it.\n- [X] I searched the Prefect documentation for this feature.\n\n### Prefect Version\n\n2.x\n\n### Describe the current behavior\n\nUsers can't auto-provis... | a22e014fbf0ee4b3d10758930558a7aea4bff7b6 | {
"head_commit": "068f251cc7dd0eb317e28f1bcfce1afe09e7655e",
"head_commit_message": "update tests",
"patch_to_review": "diff --git a/src/prefect/infrastructure/provisioners/__init__.py b/src/prefect/infrastructure/provisioners/__init__.py\nindex 4bfa941a47e7..6aee5afdac95 100644\n--- a/src/prefect/infrastructure/... | [
{
"diff_hunk": "@@ -2,13 +2,14 @@\n \n from prefect.client.orchestration import PrefectClient\n from prefect.infrastructure.provisioners.modal import ModalPushProvisioner\n-from .cloud_run import CloudRunPushProvisioner\n+from .cloud_run import CloudRunPushProvisioner, CloudRunV2PushProvisioner\n from .containe... | 61fad3fab39e55c2134c4b027284738a1adc03ff | diff --git a/src/prefect/infrastructure/provisioners/__init__.py b/src/prefect/infrastructure/provisioners/__init__.py
index 4bfa941a47e7..c4ffa079e1cc 100644
--- a/src/prefect/infrastructure/provisioners/__init__.py
+++ b/src/prefect/infrastructure/provisioners/__init__.py
@@ -9,6 +9,7 @@
_provisioners = {
"cl... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
PrefectHQ__prefect-13606@6522842 | PrefectHQ/prefect | Python | 13,606 | Prompt confirmation to any object deletion via CLI | As requested, this PR adds confirmations when deleting anything via CLI: profiles, work pools, etc.
---------------------
_"Measure twice, cut once._" | 2024-05-28T22:05:40Z | Add confirmation when deleting a Prefect profile from the CLI
### First check
- [X] I added a descriptive title to this issue.
- [X] I used the GitHub search to find a similar request and didn't find it.
- [X] I searched the Prefect documentation for this feature.
### Prefect Version
2.x
### Describe the current be... | [
{
"body": "### First check\n\n- [X] I added a descriptive title to this issue.\n- [X] I used the GitHub search to find a similar request and didn't find it.\n- [X] I searched the Prefect documentation for this feature.\n\n### Prefect Version\n\n2.x\n\n### Describe the current behavior\n\nDeleting a profile take... | 5394b022d55d38a3696ed4c5903ef18774392b5f | {
"head_commit": "652284205110f57c311e955bc147abc6b74095f4",
"head_commit_message": "Merge branch 'main' into serina/add-deletion-confirmations",
"patch_to_review": "diff --git a/src/prefect/cli/block.py b/src/prefect/cli/block.py\nindex b63a83db23ac..514226fbb5ad 100644\n--- a/src/prefect/cli/block.py\n+++ b/src... | [
{
"diff_hunk": "@@ -576,6 +576,11 @@ async def delete(\n )\n async with get_client() as client:\n try:\n+ if not typer.confirm(\n+ (f\"Are you sure you want to delete automation {name!r}?\"),",
"line": null,
"original_line": 580,
"original_start_line": null,... | 41fc922120383243d4de6232f1faf089fc851bb1 | diff --git a/src/prefect/cli/artifact.py b/src/prefect/cli/artifact.py
index a023306034d6..cc2b2229bace 100644
--- a/src/prefect/cli/artifact.py
+++ b/src/prefect/cli/artifact.py
@@ -8,7 +8,7 @@
from prefect import get_client
from prefect.cli._types import PrefectTyper
from prefect.cli._utilities import exit_with_er... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
PrefectHQ__prefect-12387@d613b9c | PrefectHQ/prefect | Python | 12,387 | Improve interactive workspace selection | closes https://github.com/PrefectHQ/prefect/issues/12381
This PR updates the interactive `prefect cloud workspace set` (without a handle specified) to prompt for account selection first, only when the user has more than 10 workspaces _and_ more than one account. This makes the experience better for those with lots o... | 2024-03-21T22:27:26Z | improve interactive `prefect cloud workspace set`
### First check
- [X] I added a descriptive title to this issue.
- [X] I used the GitHub search to find a similar request and didn't find it.
- [X] I searched the Prefect documentation for this feature.
### Prefect Version
2.x
### Describe the current behavior
if y... | [
{
"body": "### First check\n\n- [X] I added a descriptive title to this issue.\n- [X] I used the GitHub search to find a similar request and didn't find it.\n- [X] I searched the Prefect documentation for this feature.\n\n### Prefect Version\n\n2.x\n\n### Describe the current behavior\n\nif you have a lot of wo... | 6ef21909dc959a639753aeaf422b77c380af12bd | {
"head_commit": "d613b9c500d833e1b92192bb6aadff89e49e9b54",
"head_commit_message": "Merge branch 'main' into better-interactive-workspace-set",
"patch_to_review": "diff --git a/src/prefect/cli/cloud/__init__.py b/src/prefect/cli/cloud/__init__.py\nindex 2eaafafed26d..71e913e687d7 100644\n--- a/src/prefect/cli/cl... | [
{
"diff_hunk": "@@ -594,23 +594,44 @@ async def set(\n \"Unable to authenticate. Please ensure your credentials are correct.\"\n )\n \n- if workspace_handle:\n- # Search for the given workspace\n- for workspace in workspaces:\n- if workspace.handle == work... | 78c425a163cc78e101018fb137c1d254c32c35a7 | diff --git a/src/prefect/cli/cloud/__init__.py b/src/prefect/cli/cloud/__init__.py
index 2eaafafed26d..77eec02578d5 100644
--- a/src/prefect/cli/cloud/__init__.py
+++ b/src/prefect/cli/cloud/__init__.py
@@ -3,10 +3,11 @@
"""
import signal
import traceback
+import uuid
import urllib.parse
import webbrowser
from co... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
PrefectHQ__prefect-11547@8f882c9 | PrefectHQ/prefect | Python | 11,547 | Ensure `flow.from_source` handles remote git repository updates | This PR addresses issue #11546, where the `flow.from_source(...).serve(...)` functionality crashes when new commits are added to a remote Git repository. The problem was identified as the local clone retaining a shallow copy (`--depth 1`) of the repository, causing conflicts with new commits from the remote. This chang... | 2024-01-04T00:02:09Z | flow.from_source does not work with changes in a remote git repository
### First check
- [X] I added a descriptive title to this issue.
- [X] I used the GitHub search to find a similar issue and didn't find it.
- [X] I searched the Prefect documentation for this issue.
- [X] I checked that this issue is related to Pre... | Hi @Relativity74205, thanks so much for the detailed writeup! I was able to reproduce this issue.
I adapted your example to my own public repo:
```python
from prefect import flow, deploy
from prefect.client.schemas.schedules import IntervalSchedule
from datetime import timedelta, datetime
if __name__ == ... | [
{
"body": "### First check\n\n- [X] I added a descriptive title to this issue.\n- [X] I used the GitHub search to find a similar issue and didn't find it.\n- [X] I searched the Prefect documentation for this issue.\n- [X] I checked that this issue is related to Prefect and not one of its dependencies.\n\n### Bu... | 70dd469d56bf49973c3d4f6188d5bb5f2c9a1a53 | {
"head_commit": "8f882c9eb0a9e098a94783eb146b29b4a12b1c51",
"head_commit_message": "initial commit",
"patch_to_review": "diff --git a/src/prefect/runner/storage.py b/src/prefect/runner/storage.py\nindex 02968b021074..1cf67fcf49fc 100644\n--- a/src/prefect/runner/storage.py\n+++ b/src/prefect/runner/storage.py\n@... | [
{
"diff_hunk": "@@ -218,35 +219,50 @@ async def pull_code(self):\n if self._include_submodules:\n cmd += [\"--recurse-submodules\"]\n cmd += [\"--depth\", \"1\"]\n- await run_process(cmd, cwd=self.destination)\n+ try:\n+ await run_proc... | 5f5760c2003c76e201ca9929097441c133183383 | diff --git a/src/prefect/runner/storage.py b/src/prefect/runner/storage.py
index 02968b021074..62ad7b64af3b 100644
--- a/src/prefect/runner/storage.py
+++ b/src/prefect/runner/storage.py
@@ -1,3 +1,4 @@
+import shutil
import subprocess
from copy import deepcopy
from pathlib import Path
@@ -218,35 +219,49 @@ async de... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
PrefectHQ__prefect-11604@c9f0169 | PrefectHQ/prefect | Python | 11,604 | Raise `StepExecutionError` on non-zero `run_shell_script` return code during `prefect deploy` | This PR focuses on handling errors more effectively during the execution of `run_shell_script` in deployment steps. Instead of silently allowing deployment steps to continue during `prefect deploy`, we raise on error here.
### Example
<!--
Share an example of the change in action.
A code blurb is best. Change... | 2024-01-10T02:18:41Z | Deployment steps continue when script in `run_shell_script` fails
### First check
- [X] I added a descriptive title to this issue.
- [X] I used the GitHub search to find a similar issue and didn't find it.
- [X] I searched the Prefect documentation for this issue.
- [X] I checked that this issue is related to Prefect ... | Thanks for creating an issue as we discussed in the [Slack thread](https://prefecthq.slack.com/archives/CQTTM2M0D/p1704382046332649)! | [
{
"body": "### First check\n\n- [X] I added a descriptive title to this issue.\n- [X] I used the GitHub search to find a similar issue and didn't find it.\n- [X] I searched the Prefect documentation for this issue.\n- [X] I checked that this issue is related to Prefect and not one of its dependencies.\n\n### Bu... | a43e8dbebbff2885fd0dbe980d6388b20c333680 | {
"head_commit": "c9f01691e8c87ddd525a05cab24971a9ff958444",
"head_commit_message": "update older test, add regression test",
"patch_to_review": "diff --git a/src/prefect/deployments/steps/utility.py b/src/prefect/deployments/steps/utility.py\nindex da925be86b77..6bc52c481146 100644\n--- a/src/prefect/deployments... | [
{
"diff_hunk": "@@ -188,6 +188,12 @@ async def run_shell_script(\n \n await process.wait()\n \n+ if process.returncode != 0:\n+ raise RuntimeError(\n+ f\"run_shell_script failed with error code {process.returncode}:\"",
"line": null,
"original_lin... | 81ae41fe595b7c27d073b77d0273d69d895e7064 | diff --git a/src/prefect/deployments/steps/utility.py b/src/prefect/deployments/steps/utility.py
index da925be86b77..8130d2c5cd3a 100644
--- a/src/prefect/deployments/steps/utility.py
+++ b/src/prefect/deployments/steps/utility.py
@@ -188,6 +188,12 @@ async def run_shell_script(
await process.wait()
+ ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
PrefectHQ__prefect-13428@229c822 | PrefectHQ/prefect | Python | 13,428 | Fix authenticate bug and add unverified context | <!--
Thanks for opening a pull request to Prefect! We've got a few requests to help us review contributions:
- Make sure that your title neatly summarizes the proposed changes.
- Provide a short overview of the change and the value it adds.
- Share an example to help us understand the change in user experience.
... | 2024-05-17T12:58:36Z | Add authentication to INSECURE server
<!-- Thanks for submitting an issue! Please describe the issue. -->
# Expectation / Proposal
We don't have authentication in INSECURE servers so we are not able to connect to those mail servers with prefect-email.
Support of unverified smtp server
<!-- Thanks for submitt... | [
{
"body": "<!-- Thanks for submitting an issue! Please describe the issue. -->\r\n\r\n# Expectation / Proposal\r\n\r\nWe don't have authentication in INSECURE servers so we are not able to connect to those mail servers with prefect-email.\r\n\r\n",
"number": 13089,
"title": "Add authentication to INSECU... | 6604ec94b21724c1f78f103463ef7353220a379c | {
"head_commit": "229c822c3d1e28da8899c20c3d3d5622764bc48d",
"head_commit_message": "comments applied",
"patch_to_review": "diff --git a/src/integrations/prefect-email/prefect_email/credentials.py b/src/integrations/prefect-email/prefect_email/credentials.py\nindex 1fdc8bc061f4..9f8d766fc925 100644\n--- a/src/int... | [
{
"diff_hunk": "@@ -95,6 +96,7 @@ class EmailServerCredentials(Block):\n _block_type_name = \"Email Server Credentials\"\n _logo_url = \"https://cdn.sanity.io/images/3ugk85nk/production/82bc6ed16ca42a2252a5512c72233a253b8a58eb-250x250.png\" # noqa\n _documentation_url = \"https://prefecthq.github.i... | 9b2d0d2bd263ab67ad92ea3dec5f15635340e613 | diff --git a/src/integrations/prefect-email/prefect_email/credentials.py b/src/integrations/prefect-email/prefect_email/credentials.py
index 1fdc8bc061f4..fa9e24db0484 100644
--- a/src/integrations/prefect-email/prefect_email/credentials.py
+++ b/src/integrations/prefect-email/prefect_email/credentials.py
@@ -9,6 +9,9 ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
PrefectHQ__prefect-12019@e1936a8 | PrefectHQ/prefect | Python | 12,019 | Fix three memory leaks | <!--
Thanks for opening a pull request to Prefect! We've got a few requests to help us review contributions:
- Make sure that your title neatly summarizes the proposed changes.
- Provide a short overview of the change and the value it adds.
- Share an example to help us understand the change in user experience.
... | 2024-02-16T22:38:37Z | Task input persisted leading to memory not being released (same for output).
### First check
- [X] I added a descriptive title to this issue.
- [X] I used the GitHub search to find a similar request and didn't find it.
- [X] I searched the Prefect documentation for this feature.
### Prefect Version
2.x
##... | Hi @sibbiii, thanks for the well written issue and investigation. I can reproduce the behavior with your MRE.
I think it is unlikely that the references are maintained as part of results as you're not returning anything from your function.
I think this likely has to do with the dependency tracking or as your sai... | [
{
"body": "### First check\r\n\r\n- [X] I added a descriptive title to this issue.\r\n- [X] I used the GitHub search to find a similar request and didn't find it.\r\n- [X] I searched the Prefect documentation for this feature.\r\n\r\n### Prefect Version\r\n\r\n2.x\r\n\r\n### Describe the current behavior\r\n\r\... | 276da8438e84fb7daf05255d1f9d87379d2d647b | {
"head_commit": "e1936a860061a6bfb0ec82e1bd8b43a9f7ea4d53",
"head_commit_message": "Fix two memory leaks",
"patch_to_review": "diff --git a/src/prefect/_internal/concurrency/calls.py b/src/prefect/_internal/concurrency/calls.py\nindex fbd74ba211e9..9d7e5b4c0f99 100644\n--- a/src/prefect/_internal/concurrency/cal... | [
{
"diff_hunk": "@@ -270,6 +270,8 @@ def __exit__(self, exc_type, exc_val, exc_tb):\n # Mark as cancelled\n self.cancel(throw=False)\n \n+ self._anyio_scope.__exit__(exc_type, exc_val, exc_tb)",
"line": 276,
"original_line": 273,
"original_start_line": null,
"path":... | bf3b4d9abeb970524871423c4977142740a3fc4e | diff --git a/src/prefect/_internal/concurrency/calls.py b/src/prefect/_internal/concurrency/calls.py
index 13e9e9bbfc61..6ca4dc45567e 100644
--- a/src/prefect/_internal/concurrency/calls.py
+++ b/src/prefect/_internal/concurrency/calls.py
@@ -10,6 +10,7 @@
import dataclasses
import inspect
import threading
+import w... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
RasaHQ__rasa-11107@b510c78 | RasaHQ/rasa | Python | 11,107 | remove warning when running `rasa x --production` |
**Proposed changes**:
- Move the warning raised for `rasa x` so that it does not warn for `rasa x --production` which does not start localmode.
**Status (please check what you already did)**:
- [x] added some tests for the functionality
- [x] updated the changelog (please check [changelog](https://github.com/Ra... | 2022-05-01T20:24:23Z | Remove `UserWarning` that gets raised when running `rasa x` with rasa 3.0 once rasa-x adds support for 3.0
This is a wrap-up issue once rasa-x support for rasa 3.0 has been added.
**Definition of Done**:
* [ ] `UserWarning` raised in `rasa/cli/x.py::rasa_x` is removed, as well as the accompanying unit test `test_ra... | Hello, Has this issue been resolved?
This issue isn't relevant in its original form anymore, since Rasa 3.0 dropped support for Rasa X localmode.
However, there is an exception that now needs to be handled: The command `rasa x --production`, which starts a Rasa Open Source Server (not Rasa X) should not throw this w... | [
{
"body": "This is a wrap-up issue once rasa-x support for rasa 3.0 has been added.\n\n**Definition of Done**:\n\n* [ ] `UserWarning` raised in `rasa/cli/x.py::rasa_x` is removed, as well as the accompanying unit test `test_rasa_x_raises_warning_above_version_3`",
"number": 10480,
"title": "Remove `Us... | 15b2dfc322a9d5c875a7ae5e1ae623286c9755c1 | {
"head_commit": "b510c78698538bd75f68105efb71423970631557",
"head_commit_message": "changelog",
"patch_to_review": "diff --git a/changelog/10480.bugfix.md b/changelog/10480.bugfix.md\nnew file mode 100644\nindex 000000000000..20c39902fd43\n--- /dev/null\n+++ b/changelog/10480.bugfix.md\n@@ -0,0 +1 @@\n+Remove wa... | [
{
"diff_hunk": "@@ -163,22 +165,34 @@ async def test_pull_runtime_config_from_server():\n assert rasa.shared.utils.io.read_file(credentials_path) == credentials\n \n \n-def test_rasa_x_raises_warning_above_version_3(\n- monkeypatch: MonkeyPatch, run: Callable[..., RunResult]\n-):\n+def test_rasa_x_ra... | a6eb854f2bcb52df189f44a6b2f305e2959d789c | diff --git a/changelog/10480.bugfix.md b/changelog/10480.bugfix.md
new file mode 100644
index 000000000000..20c39902fd43
--- /dev/null
+++ b/changelog/10480.bugfix.md
@@ -0,0 +1 @@
+Remove warning for Rasa X localmode not being supported when the `--production` flag is present.
diff --git a/rasa/cli/x.py b/rasa/cli/x.p... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
RasaHQ__rasa-11326@8f542da | RasaHQ/rasa | Python | 11,326 | ATO 207 run form validation on form activation | **Proposed changes**:
- Revert change here https://github.com/RasaHQ/rasa/pull/10295/files#r807244104 that removed running the form validation action on activation of the form (before the loop is active).
- This would make #10913 obsolete since the 2.x mechanism for achieving the same thing would be returned.
- Clos... | 2022-07-13T10:52:48Z | required_slots function in form is not called
h3\. Rasa Open Source version
3.1.0
h3\. Rasa SDK version
3.1.2
h3\. Python version
3.7
h3\. What operating system are you using?
Windows
h3\. What happened?
I've created a form with form validation. Form doesn't call my required_slots method in spite of I've creat... | I have encountered this as well, when migrating from Rasa 2 to Rasa 3.
In my experience, Rasa 2 called this function before requesting the first slot.
Now, Rasa 3 calls the function after the first requested slot is attemped to be filled.
A **workaround** I have used to mimic Rasa 2 behaviour is to list a dummy ... | [
{
"body": "h3\\. Rasa Open Source version\n\n3.1.0\n\nh3\\. Rasa SDK version\n\n3.1.2\n\nh3\\. Python version\n\n3.7\n\nh3\\. What operating system are you using?\n\nWindows\n\nh3\\. What happened?\n\nI've created a form with form validation. Form doesn't call my required_slots method in spite of I've created a... | 3f69f12a281fe0d2e55d9d419ea0b3a8b544dc61 | {
"head_commit": "8f542daa2e05ddbb44c3adab8bc11fd9c1874ef2",
"head_commit_message": "match mocking methods in other tests",
"patch_to_review": "diff --git a/changelog/11326.bugfix.md b/changelog/11326.bugfix.md\nnew file mode 100644\nindex 000000000000..ee01ea17b258\n--- /dev/null\n+++ b/changelog/11326.bugfix.md... | [
{
"diff_hunk": "@@ -5,6 +5,7 @@\n import pytest\n from _pytest.monkeypatch import MonkeyPatch\n from aioresponses import aioresponses\n+from questionary import form",
"line": null,
"original_line": 8,
"original_start_line": null,
"path": "tests/core/actions/test_forms.py",
"start_line": null... | 2c61306353618be4f4f35d4827628a4031acf441 | diff --git a/changelog/11326.bugfix.md b/changelog/11326.bugfix.md
new file mode 100644
index 000000000000..ee01ea17b258
--- /dev/null
+++ b/changelog/11326.bugfix.md
@@ -0,0 +1 @@
+Revert change in #10295 that removed running the form validation action on activation of the form before the loop is active.
\ No newline ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
RasaHQ__rasa-11683@997c72a | RasaHQ/rasa | Python | 11,683 | Improve logging by adding cli option for custom formatting | **Proposed changes**:
- Fixes #2546 (Jira ticket [ATO-454](https://rasahq.atlassian.net/browse/ATO-454))
- Adds a new logging option parameter to the CLI labelled `--logging-config-file` which accepts a YAML file as value
- In this YAML file, the rasa developer should provide custom configuration of formatters and h... | 2022-10-19T15:35:02Z | Allow configuration of logging format
<!-- THIS INFORMATION IS MANDATORY - YOUR ISSUE WILL BE CLOSED IF IT IS MISSING. If you don't know your Rasa Core version, use `pip list | grep rasa_core`. Removing the below information is allowed for FEATURE REQUESTS. -->
**Rasa Core version**: 0.11.3
**Python version**: 3... | Thanks for raising this issue, @tmbo will get back to you about it soon.
You can configure the logger. It is a standard logger .e.g using
```
import logging
FORMAT = '%(asctime)-15s %(clientip)s %(user)-8s %(message)s'
logging.basicConfig(format=FORMAT)
```
Where to configure this step? I am using below command t... | [
{
"body": "<!-- THIS INFORMATION IS MANDATORY - YOUR ISSUE WILL BE CLOSED IF IT IS MISSING. If you don't know your Rasa Core version, use `pip list | grep rasa_core`. Removing the below information is allowed for FEATURE REQUESTS. --> \r\n\r\n**Rasa Core version**: 0.11.3\r\n\r\n**Python version**: 3.6.2\r\n\r\... | a1a409e5edb7d466dd031300d99174a36c68e3c3 | {
"head_commit": "997c72a61a9adaf2345a4bc505f6be84543939bd",
"head_commit_message": "more cli test fixes",
"patch_to_review": "diff --git a/changelog/2546.improvement.md b/changelog/2546.improvement.md\nnew file mode 100644\nindex 000000000000..ce19b00ffc9f\n--- /dev/null\n+++ b/changelog/2546.improvement.md\n@@ ... | [
{
"diff_hunk": "@@ -117,11 +119,17 @@ def configure_logging_and_warnings(\n log_level: The log level to be used for the 'Rasa' logger. Pass `None` to use\n either the environment variable 'LOG_LEVEL' if it is specified, or the\n default log level otherwise.\n+ logging_conf... | 4619ff84180cacdf5252d5a7b1b5a3df3f9bc338 | diff --git a/changelog/2546.improvement.md b/changelog/2546.improvement.md
new file mode 100644
index 000000000000..ce19b00ffc9f
--- /dev/null
+++ b/changelog/2546.improvement.md
@@ -0,0 +1 @@
+Added CLI option `--logging-config-file` to enable configuration of custom logs formatting.
diff --git a/data/test_logging_con... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
PrefectHQ__prefect-11376@6d18fa8 | PrefectHQ/prefect | Python | 11,376 | Integrate flow run input and schema/response mechanics into pause/suspend | This integrates flow run input into pause/suspend allowing a flow run to pause or suspend and receive structured and validated input, it does this by:
- Creating `RunInput` a sub-classable pydantic model that a user can subclass and add their own fields and validation.
- Adding `wait_for_input` to `pause_flow_run` ... | 2023-12-11T19:37:52Z | Build out client-side primitives for getting, storing, and validating flow run input
Now that we have modeling and an CRUD API to store key/value data associated with a flow run we should build out the client-side primitives to get, store, and validate that data. | [
{
"body": "Now that we have modeling and an CRUD API to store key/value data associated with a flow run we should build out the client-side primitives to get, store, and validate that data.",
"number": 11339,
"title": "Build out client-side primitives for getting, storing, and validating flow run input"... | e41740330df2ba6c96d16c44a81e5a1fb50dd4e8 | {
"head_commit": "6d18fa844464bc2f62d0e72b276a6f33620cfdf8",
"head_commit_message": "Fix suspend test with postgres",
"patch_to_review": "diff --git a/src/prefect/_internal/pydantic/v2_schema.py b/src/prefect/_internal/pydantic/v2_schema.py\nindex cdd73f5a494b..1496258ae461 100644\n--- a/src/prefect/_internal/pyd... | [
{
"diff_hunk": "@@ -1026,12 +1045,19 @@ async def _in_process_pause(\n \n logger.info(\"Pausing flow, execution will continue when this flow run is resumed.\")\n \n+ proposed_state = Paused(\n+ timeout_seconds=timeout, reschedule=reschedule, pause_key=pause_key\n+ )\n+\n+ run_input_keyset = ... | 2a22ef675554ace46dc8aff45beb888e54ce883e | diff --git a/src/prefect/_internal/pydantic/v2_schema.py b/src/prefect/_internal/pydantic/v2_schema.py
index cdd73f5a494b..1496258ae461 100644
--- a/src/prefect/_internal/pydantic/v2_schema.py
+++ b/src/prefect/_internal/pydantic/v2_schema.py
@@ -82,11 +82,18 @@ def process_v2_params(
return name, type_, field
... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
PrefectHQ__prefect-11342@174b1fd | PrefectHQ/prefect | Python | 11,342 | Add data model and methods for FlowRunInput | This adds the `FlowRunInput` data model, schemas and CRUD methods to support the human-in-the-loop work.
Closes #11337
### Checklist
<!-- These boxes may be checked after opening the pull request. -->
- [x] This pull request references any related issue by including "closes `<link to issue>`"
- If no issue e... | 2023-12-06T19:44:07Z | Add modeling for FlowRunInput to OSS
For human-in-the-loop we need a way to store key/value data, to that end we should add modeling for `FlowRunInput` that enables us to store key/value information associated with a flow run. We'll then use this data store to build out the interactivity piece. | [
{
"body": "For human-in-the-loop we need a way to store key/value data, to that end we should add modeling for `FlowRunInput` that enables us to store key/value information associated with a flow run. We'll then use this data store to build out the interactivity piece.",
"number": 11337,
"title": "Add m... | 0792e60db3749599230eed289f44b75d274de649 | {
"head_commit": "174b1fd0235f008dcb4309648e4e87a88fc21e39",
"head_commit_message": "Add data model and methods for FlowRunInput",
"patch_to_review": "diff --git a/src/prefect/server/database/interface.py b/src/prefect/server/database/interface.py\nindex 4e4ae402e144..0f2e49aa3a6a 100644\n--- a/src/prefect/server... | [
{
"diff_hunk": "@@ -0,0 +1,118 @@\n+import copy\n+import uuid\n+from typing import Optional\n+\n+import sqlalchemy as sa\n+from sqlalchemy.dialects.postgresql import JSONB\n+from sqlalchemy.ext.asyncio import AsyncSession\n+\n+import prefect.server.schemas as schemas\n+from prefect.server.database.dependencies ... | 47685a05ca902e2639cf6c3e241d603edd891450 | diff --git a/src/prefect/server/database/interface.py b/src/prefect/server/database/interface.py
index 4e4ae402e144..0f2e49aa3a6a 100644
--- a/src/prefect/server/database/interface.py
+++ b/src/prefect/server/database/interface.py
@@ -258,6 +258,11 @@ def Variable(self):
"""A variable model"""
return ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
PrefectHQ__prefect-11117@a7e9fe2 | PrefectHQ/prefect | Python | 11,117 | Allow `image` passed into `deploy` to be optional if loading flow from storage | Closes https://github.com/PrefectHQ/prefect/issues/11096
### Example Usage
```python
from prefect import flow
from prefect import deploy
@flow(log_prints=True)
def local_flow():
print("I'm a locally defined flow!")
if __name__ == "__main__":
# use an image (`build` and `push` args default `True... | 2023-11-07T20:50:51Z | `image` argument is required with `.deploy` even if `build=False`
### First check
- [X] I added a descriptive title to this issue.
- [X] I used the GitHub search to find a similar request and didn't find it.
- [X] I searched the Prefect documentation for this feature.
### Prefect Version
2.x
### Describe the curren... | [
{
"body": "### First check\n\n- [X] I added a descriptive title to this issue.\n- [X] I used the GitHub search to find a similar request and didn't find it.\n- [X] I searched the Prefect documentation for this feature.\n\n### Prefect Version\n\n2.x\n\n### Describe the current behavior\n\nUsers need to provide a... | ade74e6eac38d63cc224687a5c082cabf6603f4f | {
"head_commit": "a7e9fe2d791685c106a0c90c4d3678fec89a2e9f",
"head_commit_message": "update error msg",
"patch_to_review": "diff --git a/src/prefect/deployments/runner.py b/src/prefect/deployments/runner.py\nindex ed6c2a3b28da..94ecce3a7316 100644\n--- a/src/prefect/deployments/runner.py\n+++ b/src/prefect/deploy... | [
{
"diff_hunk": "@@ -1273,6 +1273,73 @@ async def test_deploy_with_image_string(\n pull=True,\n )\n \n+ async def test_deploy_without_image_with_flow_stored_remotely(\n+ self,\n+ work_pool_with_image_variable,\n+ ):\n+ deployment_id = await deploy(\n+ awa... | e24173129008d2f86a1c21fe3456d7d512afa864 | diff --git a/src/prefect/deployments/runner.py b/src/prefect/deployments/runner.py
index ed6c2a3b28da..94ecce3a7316 100644
--- a/src/prefect/deployments/runner.py
+++ b/src/prefect/deployments/runner.py
@@ -692,7 +692,7 @@ def push(self):
async def deploy(
*deployments: RunnerDeployment,
work_pool_name: str,... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
RasaHQ__rasa-10888@dfa772c | RasaHQ/rasa | Python | 10,888 | Add docs for action and validation action together | Fixes https://github.com/RasaHQ/rasa/issues/10886
| 2022-02-14T11:40:18Z | Slot Mappings: custom validation action doesn't validate the slot when the slot is extracted by a different custom action
**Problem description**:
I tried testing to see if extracting a slot via a custom action inheriting from sdk `Action` class, then validating this extraction with a custom action inheriting from sdk... | This seems to work as expected for me and validated values are used in setting the slot. I've changed the action to have following:
```
if slot_value in self.residence_db():
return {"residential_status": slot_value.upper() + '-VALIDATED'}
```
Shell logs show:
```
2022-02-11 17:30:05 DEBUG rasa.core... | [
{
"body": "**Problem description**:\r\nI tried testing to see if extracting a slot via a custom action inheriting from sdk `Action` class, then validating this extraction with a custom action inheriting from sdk `ValidationAction` works.\r\n\r\nWhile the extraction works fine, the validation code doesn't seem t... | c9dd074abfd9b6dfc0fc53992ac364991e6fe99f | {
"head_commit": "dfa772c449828a5fcedf50911e49580f5af33301",
"head_commit_message": "Add order of Action execution",
"patch_to_review": "diff --git a/docs/docs/slot-validation-actions.mdx b/docs/docs/slot-validation-actions.mdx\nindex db1c71bd05fa..508f3d4ff6b0 100644\n--- a/docs/docs/slot-validation-actions.mdx\... | [
{
"diff_hunk": "@@ -7,6 +7,12 @@ abstract: A slot validation action is a special type of custom action, designed\n \n You can do custom extraction and validation of slot values by writing custom actions in three different ways.\n \n+:::note Extraction and Validation can work together\n+\n+You can have an `Actio... | dc2bec38429d2722766e98de1766ffb668bc03a1 | diff --git a/docs/docs/slot-validation-actions.mdx b/docs/docs/slot-validation-actions.mdx
index db1c71bd05fa..52acb59d9b5e 100644
--- a/docs/docs/slot-validation-actions.mdx
+++ b/docs/docs/slot-validation-actions.mdx
@@ -41,3 +41,9 @@ Any other event type will be filtered out by the default action [`action_extract
T... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "Bug Fixes"
} |
PrefectHQ__prefect-11305@966af02 | PrefectHQ/prefect | Python | 11,305 | wait_for_flow_run PrefectClient function | <!--
Thanks for opening a pull request to Prefect! We've got a few requests to help us review contributions:
- Make sure that your title neatly summarizes the proposed changes.
- Provide a short overview of the change and the value it adds.
- Share an example to help us understand the change in user experience.
... | 2023-12-02T20:44:33Z | client.wait_for_flow_run function proposal
### First check
- [X] I added a descriptive title to this issue.
- [X] I used the GitHub search to find a similar request and didn't find it.
- [X] I searched the Prefect documentation for this feature.
### Prefect Version
2.x
### Describe the current behavior
... | Thanks for opening this issue @Fizzizist!
As you said, there is presently no such method. Do I understand correctly that you are looking for something like the `wait()` method for task futures, but for flows?
@billpalombi I am thinking something that can be done with just the prefect client and a flow run ID. He... | [
{
"body": "### First check\r\n\r\n- [X] I added a descriptive title to this issue.\r\n- [X] I used the GitHub search to find a similar request and didn't find it.\r\n- [X] I searched the Prefect documentation for this feature.\r\n\r\n### Prefect Version\r\n\r\n2.x\r\n\r\n### Describe the current behavior\r\n\r\... | e9e31df23ec9562e332d21e7481132a63d6c741a | {
"head_commit": "966af0215640e62531b424d63e4c353cac15d6b4",
"head_commit_message": "Merge branch 'main' into main",
"patch_to_review": "diff --git a/src/prefect/client/orchestration.py b/src/prefect/client/orchestration.py\nindex 461f7b2531ff..d6d327b6773c 100644\n--- a/src/prefect/client/orchestration.py\n+++ b... | [
{
"diff_hunk": "@@ -0,0 +1,37 @@\n+from uuid import UUID\n+\n+import anyio\n+\n+from prefect.client.orchestration import PrefectClient\n+from prefect.client.schemas import FlowRun\n+from prefect.exceptions import FlowWaitTimeout\n+\n+\n+async def wait_for_flow_run(\n+ client: PrefectClient,\n+ flow_run_id... | eac89f6307440515979a7b43c8fd6610ef96e6da | diff --git a/src/prefect/client/orchestration.py b/src/prefect/client/orchestration.py
index 348d5897e88a..fa5bcfd749f3 100644
--- a/src/prefect/client/orchestration.py
+++ b/src/prefect/client/orchestration.py
@@ -684,7 +684,7 @@ async def delete_flow_run(
httpx.RequestError: If requests fails
""... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
RasaHQ__rasa-10486@b36aa4e | RasaHQ/rasa | Python | 10,486 | rasa data migrate 3.0 | **Proposed changes**:
- closes #10243
- added assertion that files that we want to migrate do not contain the 3.0 version tag already
- prevent users from overwriting existing output or backup location (which prevents us from removing user data when cleaning up the backup location in case migration fails)
- added ... | 2021-12-08T14:49:59Z | `rasa data migrate` fails with a cryptic error if run on a 3.0 domain file
The proposed docs for `rasa data migrate` mention:
> Exceptions will be raised and the migration process terminated if invalid domain files are provided, slots or forms
are missing from your original files[...]
I (accidentally) ran the comm... | [
{
"body": "The proposed docs for `rasa data migrate` mention:\r\n> Exceptions will be raised and the migration process terminated if invalid domain files are provided, slots or forms\r\nare missing from your original files[...]\r\n\r\nI (accidentally) ran the command on an already migrated domain file (a case n... | ba8f7c25d826e27e421a8da4e03e0a2b620bae0e | {
"head_commit": "b36aa4e23abc40467d3616e16cbc0e0fc7dfb476",
"head_commit_message": "Merge branch 'main' into 10243/data-migrate-3.0",
"patch_to_review": "diff --git a/rasa/cli/arguments/data.py b/rasa/cli/arguments/data.py\nindex 081a3f81697e..dae75163fd8d 100644\n--- a/rasa/cli/arguments/data.py\n+++ b/rasa/cli... | [
{
"diff_hunk": "@@ -74,6 +74,8 @@ def set_migrate_arguments(parser: argparse.ArgumentParser) -> None:\n \n add_out_param(\n parser,\n- default=DEFAULT_DOMAIN_PATH,\n- help_text=\"Path (for `yaml`) where to save migrated domain in Rasa 3.0 format.\",\n+ default=None,\n+ he... | 57d9bf243a62419778f4d82b2f421979c5a4e0a1 | diff --git a/rasa/cli/arguments/data.py b/rasa/cli/arguments/data.py
index 081a3f81697e..20df03dd3f83 100644
--- a/rasa/cli/arguments/data.py
+++ b/rasa/cli/arguments/data.py
@@ -7,7 +7,7 @@
add_data_param,
add_domain_param,
)
-from rasa.shared.constants import DEFAULT_CONVERTED_DATA_PATH, DEFAULT_DOMAIN_PAT... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} | |
RasaHQ__rasa-10641@8304754 | RasaHQ/rasa | Python | 10,641 | Add support for different recipes | Fixes https://github.com/RasaHQ/rasa/issues/10473
**Proposed changes**:
- Add support for different recipe files
- See the docs: https://10641--rasahq-docs-rasa-v2.netlify.app/docs/rasa/graph-recipe/
**Status (please check what you already did)**:
- [x] added some tests for the functionality
- [x] updated the... | 2022-01-06T18:16:57Z | Support other recipes - starting with graph
### What problem are you trying to solve?
Currently we only have a single recipe type called `default.v1` which fits most cases but falls short of advanced configuration. For research teams and other users who want customised recipes, we want to add a feature to modularly... | Waiting for this feature - we need it for custom NLU pipelines - hope it will be implemented sometime in Jan!
@tayfun are you taking this on this week?
@m-vdb yes, I'll start working on this now.
The steps in original ticket are deprecated as it doesn't work for the complex case we have in the codebase. I'll work on a ... | [
{
"body": "### What problem are you trying to solve?\r\n\r\nCurrently we only have a single recipe type called `default.v1` which fits most cases but falls short of advanced configuration. For research teams and other users who want customised recipes, we want to add a feature to modularly load different types ... | 4f6af8847065a2ef639ad9191377d5295f81a949 | {
"head_commit": "83047549b817f4ddb10da561043bc287cb42a0af",
"head_commit_message": "Update rasa/engine/recipes/default_recipe.py\n\nCo-authored-by: Joe Juzl <joejuzl@gmail.com>",
"patch_to_review": "diff --git a/changelog/10473.feature.md b/changelog/10473.feature.md\nnew file mode 100644\nindex 000000000000..59... | [
{
"diff_hunk": "@@ -453,3 +465,205 @@ def test_train_core_without_nlu_pipeline():\n DefaultV1Recipe().graph_config_for_recipe(\n {\"policies\": []}, {}, TrainingType.CORE\n )\n+\n+\n+@pytest.mark.parametrize(\n+ \"config_path, expected_keys_to_configure\",\n+ [\n+ (Path(... | 506f130995c53479ae1e985aab5a0e5d391efa19 | diff --git a/changelog/10473.feature.md b/changelog/10473.feature.md
new file mode 100644
index 000000000000..b9ab4a78d1ba
--- /dev/null
+++ b/changelog/10473.feature.md
@@ -0,0 +1,7 @@
+Support other recipe types.
+
+This pull request also adds support for graph recipes, see details at
+https://rasa.com/docs/rasa/mode... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
RasaHQ__rasa-10273@074809a | RasaHQ/rasa | Python | 10,273 | slots extracted `from_intent` or `from_entity` for an un-specified intent/entity raises no error/warning | **Proposed changes**:
- fix #10122
**Status (please check what you already did)**:
- [x] added some tests for the functionality
- [ ] updated the documentation
- [ ] updated the changelog (please check [changelog](https://github.com/RasaHQ/rasa/tree/main/changelog) for instructions)
- [x] reformat files using ... | 2021-11-18T08:59:36Z | slots extracted `from_intent` for an un-specified intent raises no error/warning
### Rasa Open Source version
3.0.0rc1
### Rasa SDK version
_No response_
### Rasa X version
_No response_
### Python version
3.8
### What operating system are you using?
OSX
### What happened?
Start with a `rasa init` project an... | same happens with entities: a mapping from_entity for a non-existent entity does not lead to any warning/error as far as I see | [
{
"body": "### Rasa Open Source version\n\n3.0.0rc1\n\n### Rasa SDK version\n\n_No response_\n\n### Rasa X version\n\n_No response_\n\n### Python version\n\n3.8\n\n### What operating system are you using?\n\nOSX\n\n### What happened?\n\nStart with a `rasa init` project and specify a slot that should be extracte... | ce303b680fca67e526d71f28d152d9be986b4937 | {
"head_commit": "074809a18861923762c37ac5501738b2d6712e09",
"head_commit_message": "Merge branch 'main' into bug/10122",
"patch_to_review": "diff --git a/rasa/core/actions/action.py b/rasa/core/actions/action.py\nindex dcc2923089be..3ca28e7c0cd1 100644\n--- a/rasa/core/actions/action.py\n+++ b/rasa/core/actions/... | [
{
"diff_hunk": "@@ -1154,6 +1154,8 @@ async def run(\n \n for slot in user_slots:\n for mapping in slot.mappings:\n+ _check_mapping_validity(mapping, domain)",
"line": null,
"original_line": 1157,
"original_start_line": null,
"path": "rasa/core/actions/action.p... | 2dcfaf4e5ea11ba9080d860c71bae6c41f6415af | diff --git a/rasa/core/actions/action.py b/rasa/core/actions/action.py
index dcc2923089be..ed99d182c44a 100644
--- a/rasa/core/actions/action.py
+++ b/rasa/core/actions/action.py
@@ -1154,6 +1154,9 @@ async def run(
for slot in user_slots:
for mapping in slot.mappings:
+ if not Sl... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
RasaHQ__rasa-10689@5b6d396 | RasaHQ/rasa | Python | 10,689 | Remove unfeaturized messages for some NLU components before training and prediction | **Proposed changes**:
- Fixes a bug (#10504) which was caused by `DIETClassifier` (`ResponseSelector`, `SklearnIntentClassifier` and `CRFEntityExtractor` have the same issue) trying to process message which didn't have required features. Implements removing unfeaturized messages for the above-mentioned components befo... | 2022-01-16T08:48:51Z | Empty (or some spaces) input text causes Runtime error
### Rasa Open Source version
3.0.0
### Rasa SDK version
3.0.0
### Rasa X version
_No response_
### Python version
3.8
### What operating system are you using?
Linux
### What happened?
In NLU shell, when I input text="" or text=" ... | Thanks for raising this issue, @sebwarnke will get back to you about it soon✨
###### Please also check out the [docs](https://rasa.com/docs/) and the [forum](https://forum.rasa.com/) in case your issue was raised there too 🤗
@sara-tagger any progress??
Hi @whusunny,
I couldn't reproduce the error.
Here's what I did... | [
{
"body": "### Rasa Open Source version\r\n\r\n3.0.0\r\n\r\n### Rasa SDK version\r\n\r\n3.0.0\r\n\r\n### Rasa X version\r\n\r\n_No response_\r\n\r\n### Python version\r\n\r\n3.8\r\n\r\n### What operating system are you using?\r\n\r\nLinux\r\n\r\n### What happened?\r\n\r\nIn NLU shell, when I input text=\"\" or ... | 2320f9af806276bca7f3c667acf9731b2b5c26ac | {
"head_commit": "5b6d396ddb5e9d99ce873161a0bcbaad6c72f1be",
"head_commit_message": "ignore processing empty strings for some components",
"patch_to_review": "diff --git a/changelog/10504.bugfix.md b/changelog/10504.bugfix.md\nnew file mode 100644\nindex 000000000000..fee280a2e193\n--- /dev/null\n+++ b/changelog/... | [
{
"diff_hunk": "@@ -615,6 +615,34 @@ def test_transformer_size_gets_corrected(train_persist_load_with_different_setti\n assert selector.component_config[TRANSFORMER_SIZE] == DEFAULT_TRANSFORMER_SIZE\n \n \n+async def test_process_empty_input(\n+ create_response_selector: Callable[[Dict[Text, Any]], Respo... | c22f767ecd0731ad12d5de621202df61bd6714a9 | diff --git a/changelog/10504.bugfix.md b/changelog/10504.bugfix.md
new file mode 100644
index 000000000000..bea7713f23e8
--- /dev/null
+++ b/changelog/10504.bugfix.md
@@ -0,0 +1 @@
+Fixes a bug which was caused by `DIETClassifier` (`ResponseSelector`, `SklearnIntentClassifier` and `CRFEntityExtractor` have the same iss... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
RasaHQ__rasa-10437@688611b | RasaHQ/rasa | Python | 10,437 | domain_for_core_training_provider | **Proposed changes**:
- closes #10145
**Status (please check what you already did)**:
- [ ] added some tests for the functionality
- [ ] updated the documentation
- [ ] updated the changelog (please check [changelog](https://github.com/RasaHQ/rasa/tree/main/changelog) for instructions)
- [ ] reformat files usin... | 2021-12-01T15:54:01Z | Changing the required slots of a form retrains the model
### Rasa Open Source version
3.0.0rc1
### Rasa SDK version
_No response_
### Rasa X version
_No response_
### Python version
3.8
### What operating system are you using?
OSX
### What happened?
When you change the required slots of... | [
{
"body": "### Rasa Open Source version\r\n\r\n3.0.0rc1\r\n\r\n### Rasa SDK version\r\n\r\n_No response_\r\n\r\n### Rasa X version\r\n\r\n_No response_\r\n\r\n### Python version\r\n\r\n3.8\r\n\r\n### What operating system are you using?\r\n\r\nOSX\r\n\r\n### What happened?\r\n\r\nWhen you change the required sl... | 732cfb9be3d6153559eb94879281334cc99f4266 | {
"head_commit": "688611bec8a0f44033c63db9c93674777681b455",
"head_commit_message": "Merge branch '3.0.x' into 10145/avoid-core-retraining",
"patch_to_review": "diff --git a/rasa/core/actions/action.py b/rasa/core/actions/action.py\nindex 19f22daaa962..97e50bb5128b 100644\n--- a/rasa/core/actions/action.py\n+++ b... | [
{
"diff_hunk": "@@ -208,17 +211,16 @@ def _compare_or_memorize(\n self._fingerprints[fingerprint_key] = new_fingerprint\n \n @staticmethod\n- def _get_fingerprint_of_domain_without_responses(domain: Domain) -> Text:\n- \"\"\"Returns a fingerprint of a version of the given domain withou... | 33db8dbc9fb9a5857303ff7ce702c37e088451d0 | diff --git a/data/graph_schemas/default_config_core_train_schema.yml b/data/graph_schemas/default_config_core_train_schema.yml
index 32d8b0206677..d88dbf639b30 100644
--- a/data/graph_schemas/default_config_core_train_schema.yml
+++ b/data/graph_schemas/default_config_core_train_schema.yml
@@ -34,10 +34,10 @@ nodes:
... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Code Refactoring / Architectural Improvement"
} | |
RasaHQ__rasa-10268@ca8d70d | RasaHQ/rasa | Python | 10,268 | Fix API docs | **Proposed changes**:
Fixes https://github.com/RasaHQ/rasa/issues/10148
- Updates `/model/train` endpoint in docs to only accept YAML input
- Updates `/model` endpoint to clarify model path | 2021-11-17T16:26:17Z | Model API QA: Errors met when testing model training and replacing loaded model
**Problem description**:
1. Testing `/model/train` endpoint with the example in the docs leads to a YAML validation error (400 Bad Request error:
```
"The request body does not contain valid YAML. Error: Failed to validate YAML. Please... | Found the same - @tayfun I see you're assigned so maybe you already saw this, but it expects literal `yaml`, so a documentation issue - this request works:
```
curl --request POST \
--url http://localhost:5005/model/train \
--header 'Content-Type: text/yaml' \
--data 'version: '\''3.0'\''
config:
store_e... | [
{
"body": "**Problem description**:\r\n\r\n1. Testing `/model/train` endpoint with the example in the docs leads to a YAML validation error (400 Bad Request error:\r\n```\r\n\"The request body does not contain valid YAML. Error: Failed to validate YAML. Please make sure the file is correct and all mandatory par... | 5376b15e2c857592f6c2ddca1c759988e0d1fedb | {
"head_commit": "ca8d70d5760cbba8e9d863a571e5236e014bb7a5",
"head_commit_message": "Merge branch 'main' into tayfun/10148-fix-api-docs",
"patch_to_review": "diff --git a/docs/static/spec/rasa.yml b/docs/static/spec/rasa.yml\nindex 1a2029b90e00..5ee7be468259 100644\n--- a/docs/static/spec/rasa.yml\n+++ b/docs/sta... | [
{
"diff_hunk": "@@ -1407,19 +1408,40 @@ components:\n type: integer\n description: Time to wait between pulls from model server\n \n- JSONTrainingRequest:\n+ YAMLTrainingRequest:\n type: object\n properties:\n- domain:\n- $ref: '#/components/schemas/DomainFi... | ca55aada857879d5b5a253470ea66b1ad54d4d24 | diff --git a/docs/static/spec/rasa.yml b/docs/static/spec/rasa.yml
index 1a2029b90e00..ab059bf75436 100644
--- a/docs/static/spec/rasa.yml
+++ b/docs/static/spec/rasa.yml
@@ -482,12 +482,61 @@ paths:
description: >-
The training data should be in YAML format.
content:
- application... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
QuivrHQ__quivr-329@0bc4221 | QuivrHQ/quivr | Python | 329 | feat: user can create api keys | # Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context.
Create and use API keys
#315
## Checklist before requesting a review
Please delete options that are not relevant.
- [ ] My code follows the style guidelines of this project
... | 2023-06-14T15:44:00Z | [API Key Gen] AAUser I can create an API key with the FE for Quivr
BE
1. Create an endpoint called key_routes.
2. This endpoint should have POST
3. Create new table in Supabase for keys.
4. Hit Supabase DB and add row to keys (user_id, key, date_created, date_deleted, isDeleted).
5. Only return key for that call.
6. I... | FE
1. In config page add a new child
2. in child add button for creating new key.
3. the call should hit the endpoint and the key shown from BE | [
{
"body": "BE\n\n1. Create an endpoint called key_routes.\n2. This endpoint should have POST\n3. Create new table in Supabase for keys.\n4. Hit Supabase DB and add row to keys (user_id, key, date_created, date_deleted, isDeleted).\n5. Only return key for that call.\n6. If POST is called again, a new key is crea... | 4c6beea626337d5ae1a4b9e1ef8eaeaf35c083d5 | {
"head_commit": "0bc4221b2c3ae1d6ad2bffc098d51fbe4ae7f6a5",
"head_commit_message": "fix: linting on build",
"patch_to_review": "diff --git a/backend/auth/auth_bearer.py b/backend/auth/auth_bearer.py\nindex cc12c027c569..4a0f073c5fcc 100644\n--- a/backend/auth/auth_bearer.py\n+++ b/backend/auth/auth_bearer.py\n@@... | [
{
"diff_hunk": "@@ -0,0 +1,82 @@\n+from datetime import datetime\n+import time\n+from typing import List\n+from pydantic import BaseModel\n+from auth.auth_bearer import JWTBearer, get_current_user\n+from fastapi import APIRouter, Depends\n+from utils.vectors import fetch_user_id_from_credentials\n+from models.u... | d362204cd8e8c5a7d0f94826938166126a9c70b6 | diff --git a/.vscode/settings.json b/.vscode/settings.json
index 1bb4e1d7d977..403534473481 100644
--- a/.vscode/settings.json
+++ b/.vscode/settings.json
@@ -2,8 +2,9 @@
"[python]": {
"editor.defaultFormatter": "ms-python.autopep8"
},
- "python.formatting.provider": "none",
+ "python.formatting.provider":... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
RasaHQ__rasa-10207@d1ca27e | RasaHQ/rasa | Python | 10,207 | 3.0 mitie nlp error message | closes #10140
Adds a separate error message to clarify when configuration for MITIE NLU component is incorrect due to a missing file.
| 2021-11-15T10:44:25Z | Unclear error message when mitie model does not exist on path
When a model is provided for `MitieNLP` but doesn't exist on disk
e.g.
```yml
pipeline:
- name: MitieNLP
model: "data/total_word_feature_extractor.dat"
```
but no `"data/total_word_feature_extractor.dat"`
This is the error:
```
InvalidConfi... | [
{
"body": "When a model is provided for `MitieNLP` but doesn't exist on disk\r\ne.g.\r\n```yml\r\npipeline:\r\n - name: MitieNLP\r\n model: \"data/total_word_feature_extractor.dat\"\r\n```\r\nbut no `\"data/total_word_feature_extractor.dat\"`\r\n\r\nThis is the error:\r\n```\r\nInvalidConfigException: The M... | 69374ab5b7c370544bedb3b415da665bf02c334b | {
"head_commit": "d1ca27e4c5788659655e3e0925ff1c96e323704a",
"head_commit_message": "Update mitie_utils.py",
"patch_to_review": "diff --git a/rasa/nlu/utils/mitie_utils.py b/rasa/nlu/utils/mitie_utils.py\nindex a2451ac5d3aa..1ce382147fc2 100644\n--- a/rasa/nlu/utils/mitie_utils.py\n+++ b/rasa/nlu/utils/mitie_util... | [
{
"diff_hunk": "@@ -95,6 +95,13 @@ def create(\n \"to get more info about this \"\n \"parameter.\"\n )\n+ if not Path(model_file).is_file():\n+ raise InvalidConfigException(\n+ \"The model file configured in the MITIE \"\n+ ... | b9139aa57a45066af62e7c231aba68b8b57546bf | diff --git a/rasa/nlu/utils/mitie_utils.py b/rasa/nlu/utils/mitie_utils.py
index a2451ac5d3aa..75de2a1af6c4 100644
--- a/rasa/nlu/utils/mitie_utils.py
+++ b/rasa/nlu/utils/mitie_utils.py
@@ -86,7 +86,7 @@ def create(
import mitie
model_file = config.get("model")
- if not model_file or not Pat... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} | |
RasaHQ__rasa-10265@c0b6243 | RasaHQ/rasa | Python | 10,265 | Improve success message of data migration | closes #10242
**Proposed changes**:
This improves the success message when domain data is successfully migrated from 2.0 to 3.0
| 2021-11-17T15:15:15Z | `rasa data migrate` should give more informative message
Upon successfully running `rasa data migrate`, I am told:
```
Your domain was successfully migrated! It's location is domain.yml.
```
I think this isn't clear enough and we should change it to something like:
```
Your domain file (<original domain name fi... | [
{
"body": "Upon successfully running `rasa data migrate`, I am told:\r\n```\r\nYour domain was successfully migrated! It's location is domain.yml.\r\n```\r\n\r\nI think this isn't clear enough and we should change it to something like:\r\n```\r\nYour domain file (<original domain name file/path>) was successful... | f79bb8b902c1daa2bb73768143b7abcb1fe7b7e8 | {
"head_commit": "c0b624369c4d7a742241022630cd0735db8d6635",
"head_commit_message": "address comment",
"patch_to_review": "diff --git a/rasa/core/migrate.py b/rasa/core/migrate.py\nindex 65a22028b434..8fad48e9c241 100644\n--- a/rasa/core/migrate.py\n+++ b/rasa/core/migrate.py\n@@ -245,6 +245,7 @@ def migrate_doma... | [
{
"diff_hunk": "@@ -245,6 +245,7 @@ def migrate_domain_format(\n if domain_file.is_dir():\n backup_dir = current_dir / \"original_domain\"\n backup_dir.mkdir()\n+ backup_path = backup_dir / \"original_domain.yml\"",
"line": null,
"original_line": 248,
"original_start_line"... | 4a81ad8dd79e0067aa4d22810277948e1cad17b5 | diff --git a/rasa/core/migrate.py b/rasa/core/migrate.py
index 65a22028b434..e536a8af6df8 100644
--- a/rasa/core/migrate.py
+++ b/rasa/core/migrate.py
@@ -184,7 +184,7 @@ def _write_final_domain(
def _migrate_domain_files(
- domain_file: Path, backup_dir: Path, out_file: Path
+ domain_file: Path, backup_loca... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "New Feature Additions"
} | |
RasaHQ__rasa-10187@187d2d3 | RasaHQ/rasa | Python | 10,187 | Use a unique fingerprint for a resource that is consistent after caching. | Use a unique fingerprint for a resource that is consistent after caching. This ensures we always retrieve the correct resource for a node from the cache.
Fixes #10147
**Status (please check what you already did)**:
- [x] added some tests for the functionality
- [x] reformat files using `black` (please check [Re... | 2021-11-12T09:52:02Z | Missing intent in domain breaks UnexpecTED intent policy
### Rasa Open Source version
3.0.0rc1
### Rasa SDK version
_No response_
### Rasa X version
_No response_
### Python version
3.8
### What operating system are you using?
OSX
### What happened?
When I have an intent in my NLU data which is not in the do... | [
{
"body": "### Rasa Open Source version\n\n3.0.0rc1\n\n### Rasa SDK version\n\n_No response_\n\n### Rasa X version\n\n_No response_\n\n### Python version\n\n3.8\n\n### What operating system are you using?\n\nOSX\n\n### What happened?\n\nWhen I have an intent in my NLU data which is not in the domain, having a p... | df210f26b4be5e6063c477bdabf75d9da28ef08f | {
"head_commit": "187d2d3955aec7eff30c76d78db72e1339aaca7c",
"head_commit_message": "Merge remote-tracking branch 'origin/main' into 10147/use_unique_fingerprints_for_resource",
"patch_to_review": "diff --git a/rasa/engine/caching.py b/rasa/engine/caching.py\nindex 771b030be59e..596235c86cad 100644\n--- a/rasa/en... | [
{
"diff_hunk": "@@ -434,6 +445,7 @@ def _load_from_cache(\n result_type: Text,\n node_name: Text,\n model_storage: ModelStorage,\n+ output_fingerprint_key,",
"line": null,
"original_line": 448,
"original_start_line": null,
"path": "rasa/engine/caching.py",
"sta... | 5378cc1c77e93010d1ea1d3b75d417ea99bafdbe | diff --git a/rasa/engine/caching.py b/rasa/engine/caching.py
index 771b030be59e..d5301385afd9 100644
--- a/rasa/engine/caching.py
+++ b/rasa/engine/caching.py
@@ -124,7 +124,11 @@ def to_cache(self, directory: Path, model_storage: ModelStorage) -> None:
@classmethod
def from_cache(
- cls, node_name: ... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} | |
RasaHQ__rasa-10191@26ccbc3 | RasaHQ/rasa | Python | 10,191 | `rasa data migrate` doesn't clean up if migration fails | **Proposed changes**:
- fix https://github.com/RasaHQ/rasa/issues/10136
**Status (please check what you already did)**:
- [x] added some tests for the functionality
- [ ] updated the documentation
- [ ] updated the changelog (please check [changelog](https://github.com/RasaHQ/rasa/tree/main/changelog) for instru... | 2021-11-12T14:37:43Z | `rasa data migrate` doesn't clean up if migration fails
### Rasa Open Source version
3.0.0rc1
### Rasa SDK version
_No response_
### Rasa X version
_No response_
### Python version
3.8
### What operating system are you using?
OSX
### What happened?
If run `rasa data migrate` and the migration fails for some... | [
{
"body": "### Rasa Open Source version\n\n3.0.0rc1\n\n### Rasa SDK version\n\n_No response_\n\n### Rasa X version\n\n_No response_\n\n### Python version\n\n3.8\n\n### What operating system are you using?\n\nOSX\n\n### What happened?\n\nIf run `rasa data migrate` and the migration fails for some reason then yo... | 7c918b23135cbd6761bf0d148d9ede92d6380833 | {
"head_commit": "26ccbc300e27d4aa3d1cbf21de468e759457dfe9",
"head_commit_message": "Updated tests",
"patch_to_review": "diff --git a/rasa/core/migrate.py b/rasa/core/migrate.py\nindex a19ca8ff8f2b..003934ee9ab8 100644\n--- a/rasa/core/migrate.py\n+++ b/rasa/core/migrate.py\n@@ -1,4 +1,5 @@\n import copy\n+import... | [
{
"diff_hunk": "@@ -764,3 +765,53 @@ def test_migrate_domain_raises_for_non_domain_files(tmp_path: Path):\n f\"Please make sure to include these for a successful migration.\",\n ):\n rasa.core.migrate.migrate_domain_format(domain_dir, domain_dir)\n+\n+\n+def test_migrate_twice(tmp_path: Path... | 69f81b68c49e7fb1c11f3ff81c8359f3d6ac1e29 | diff --git a/rasa/core/migrate.py b/rasa/core/migrate.py
index a19ca8ff8f2b..ee0f7f738667 100644
--- a/rasa/core/migrate.py
+++ b/rasa/core/migrate.py
@@ -1,4 +1,5 @@
import copy
+import shutil
from pathlib import Path
from typing import List, Dict, Text, Any, Tuple, Optional, Union
@@ -180,12 +181,62 @@ def _writ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
RasaHQ__rasa-10186@82f9029 | RasaHQ/rasa | Python | 10,186 | move training data version from 2.0 to 3.0 | Closes #10150
I updated `LATEST_TRAINING_DATA_FORMAT_VERSION` to 3.0 and then followed the following process to update test/example training data...
`grep -r "version: \"2.0\""` to get list of files and then manually replaced {FILE_NAME} with each file to make sure they were good to update and avoid `sed` reforma... | 2021-11-12T09:29:12Z | Add version for training data for Version 3
### Rasa Open Source version
3.0.0rc1
### Rasa SDK version
_No response_
### Rasa X version
_No response_
### Python version
3.8
### What operating system are you using?
OSX
### What happened?
There have been changes in config file structure b... | [
{
"body": "### Rasa Open Source version\r\n\r\n3.0.0rc1\r\n\r\n### Rasa SDK version\r\n\r\n_No response_\r\n\r\n### Rasa X version\r\n\r\n_No response_\r\n\r\n### Python version\r\n\r\n3.8\r\n\r\n### What operating system are you using?\r\n\r\nOSX\r\n\r\n### What happened?\r\n\r\nThere have been changes in conf... | d08f8dc7b50316a35125fb3e93df7e35daf18d18 | {
"head_commit": "82f9029f9210f9b0613ecb77c98be88fffc71103",
"head_commit_message": "Update docs/docs/migration-guide.mdx",
"patch_to_review": "diff --git a/changelog/10150.feature.md b/changelog/10150.feature.md\nnew file mode 100644\nindex 000000000000..254b8a48de3a\n--- /dev/null\n+++ b/changelog/10150.feature... | [
{
"diff_hunk": "@@ -26,6 +26,18 @@ to convert your data from Markdown to YAML. Please use the commands described\n \n ### Training data\n \n+#### Upgrading `version` from `2.0` to `3.0`\n+\n+At the top of your training data files, you need to change`version: \"2.0\"` to `version: \"3.0\"`.",
"line": null,
... | 27cecca480adf4fb6fc03950b060a0da0adee263 | diff --git a/changelog/10150.feature.md b/changelog/10150.feature.md
new file mode 100644
index 000000000000..254b8a48de3a
--- /dev/null
+++ b/changelog/10150.feature.md
@@ -0,0 +1 @@
+Training data version upgraded from `2.0` to `3.0` due to breaking changes to format in Rasa Open Source 3.0
diff --git a/data/examples... | {
"difficulty": "low",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
RasaHQ__rasa-10009@809e2b4 | RasaHQ/rasa | Python | 10,009 | marker stats | **Proposed changes**:
- closes #9961
**Status (please check what you already did)**:
- [x] added some tests for the functionality
- [ ] updated the documentation
- [ ] updated the changelog (please check [changelog](https://github.com/RasaHQ/rasa/tree/main/changelog) for instructions)
- [x] reformat files usin... | 2021-10-28T17:03:15Z | Success Markers: cleanup/fix stats
**Definition of Done**
- [ ] Ensure it can deal with multiple evaluated dialogues for the same sender_id
- [ ] Ensure that stat computation works with new extractor
- [ ] Document what stats are computed
- [ ] Replace timestamp by event index
- [ ] In the current implementation t... | [
{
"body": "**Definition of Done**\r\n- [ ] Ensure it can deal with multiple evaluated dialogues for the same sender_id\r\n- [ ] Ensure that stat computation works with new extractor\r\n- [ ] Document what stats are computed\r\n- [ ] Replace timestamp by event index\r\n- [ ] In the current implementation the \"n... | 9196c4c2f7859b411af07beb9582d4559fdb83a4 | {
"head_commit": "809e2b475cc31b86d7b735917148f6474ebd8113",
"head_commit_message": "small fixes (types, forgotten assert)",
"patch_to_review": "diff --git a/rasa/core/evaluation/marker_stats.py b/rasa/core/evaluation/marker_stats.py\nindex 45d4aabd1998..2ced0bee715e 100644\n--- a/rasa/core/evaluation/marker_stat... | [
{
"diff_hunk": "@@ -1,143 +1,292 @@\n-import os\n-import sys\n-\n-if sys.version_info >= (3, 8):\n- from typing import TypedDict\n-else:\n- from typing_extensions import TypedDict\n-from typing import Dict, Text, Union, Any, List, Tuple\n+from __future__ import annotations\n+from typing import Dict, Text,... | e8df3d8a109ae4758db419621d0a66efc6f28af9 | diff --git a/rasa/core/evaluation/marker_stats.py b/rasa/core/evaluation/marker_stats.py
index 45d4aabd1998..16874abeb04b 100644
--- a/rasa/core/evaluation/marker_stats.py
+++ b/rasa/core/evaluation/marker_stats.py
@@ -1,143 +1,311 @@
-import os
-import sys
-
-if sys.version_info >= (3, 8):
- from typing import Type... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Code Refactoring / Architectural Improvement"
} | |
RasaHQ__rasa-9854@fd45043 | RasaHQ/rasa | Python | 9,854 | Integrate nlu http interpreter. | **Proposed changes**:
Closes #9765
| 2021-10-13T08:43:44Z | Revamp: Adapt RasaNLUHttpInterpreter for the graph.
### Description
In the old architecture the nlu interpreter and the core policy predictions were separate.
So the interpreter could just be replaced by the `RasaNLUHttpInterpreter` as needed.
Now that the message parsing and policy prediction happen within the gra... | [
{
"body": "### Description\r\nIn the old architecture the nlu interpreter and the core policy predictions were separate. \r\nSo the interpreter could just be replaced by the `RasaNLUHttpInterpreter` as needed.\r\nNow that the message parsing and policy prediction happen within the graph we need to implement the... | 17ad347e8281c24ff6af86015eb108ae1118b7b6 | {
"head_commit": "fd45043ccfeee023630d9433df20e1a0905fe2dc",
"head_commit_message": "Integrate nlu http interpreter.",
"patch_to_review": "diff --git a/rasa/cli/test.py b/rasa/cli/test.py\nindex 47c65b07061d..824826d69b0a 100644\n--- a/rasa/cli/test.py\n+++ b/rasa/cli/test.py\n@@ -92,7 +92,7 @@ def _print_core_te... | [
{
"diff_hunk": "@@ -257,6 +257,15 @@ def run_nlu_test(args: argparse.Namespace) -> None:\n )\n \n \n+def run_core_test(args: argparse.Namespace) -> None:\n+ \"\"\"Runs NLU tests.\n+\n+ Args:\n+ args: the parsed CLI arguments for 'rasa test nlu'.",
"line": null,
"original_line": 264,
... | ac1a6f7b93a42d426a409aa04fc0c49cd5f3f6d9 | diff --git a/rasa/cli/test.py b/rasa/cli/test.py
index 47c65b07061d..619598ff77e7 100644
--- a/rasa/cli/test.py
+++ b/rasa/cli/test.py
@@ -92,7 +92,7 @@ def _print_core_test_execution_info(args: argparse.Namespace) -> None:
)
-def run_core_test(args: argparse.Namespace) -> None:
+async def run_core_test_as... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Code Refactoring / Architectural Improvement"
} | |
RasaHQ__rasa-10095@a8f0965 | RasaHQ/rasa | Python | 10,095 | Markers docs | **Proposed changes**:
- Closes https://github.com/RasaHQ/rasa/issues/9748
**Status (please check what you already did)**:
- [ ] added some tests for the functionality
- [x] updated the documentation
- [x] updated the changelog (please check [changelog](https://github.com/RasaHQ/rasa/tree/main/changelog) for inst... | 2021-11-05T16:57:26Z | Success markers: create docs with usage instructions.
Add success markers usage instructions in to the docs.
**Definition of done:**
- [ ] Docs created, reviewed and merged to main
- [x] Docs references in error messages (add the docs URL constant in error and warning messages as applicable) | @aeshky Are we planning for this first version to be experimental?
@TyDunn I thought research features are always released as experimental first, but maybe that's not the case? Do you think it should be experimental? And does this impact the docs (other than having an experimental label)?
@aeshky I think historically t... | [
{
"body": "Add success markers usage instructions in to the docs. \r\n\r\n**Definition of done:**\r\n- [ ] Docs created, reviewed and merged to main\r\n- [x] Docs references in error messages (add the docs URL constant in error and warning messages as applicable)",
"number": 9748,
"title": "Success mark... | b98305262364e90ee40297480f1c09826ed76b5f | {
"head_commit": "a8f0965c4152ab3efe48b8e605d3f1770c3050b7",
"head_commit_message": "removed the word \"note\"",
"patch_to_review": "diff --git a/docs/docs/markers.mdx b/docs/docs/markers.mdx\nnew file mode 100644\nindex 000000000000..5a1cfc69de85\n--- /dev/null\n+++ b/docs/docs/markers.mdx\n@@ -0,0 +1,291 @@\n+-... | [
{
"diff_hunk": "@@ -0,0 +1,291 @@\n+---\n+id: markers\n+sidebar_label: Markers\n+title: Markers\n+description: Read more about how to mark points of interest in dialogues using logical expressions.\n+abstract: Markers are logical expressions that allow you to describe points in the dialogue that you are interes... | dd7d0c395347760680d995aaf891863acdebeba2 | diff --git a/changelog/10095.doc.md b/changelog/10095.doc.md
new file mode 100644
index 000000000000..eb739e43202b
--- /dev/null
+++ b/changelog/10095.doc.md
@@ -0,0 +1 @@
+Added new docs for Markers.
\ No newline at end of file
diff --git a/docs/docs/command-line-interface.mdx b/docs/docs/command-line-interface.mdx
in... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "Documentation Updates"
} |
RasaHQ__rasa-9971@10444e2 | RasaHQ/rasa | Python | 9,971 | update documentation for custom components / policies | **Proposed changes**:
- fix https://github.com/RasaHQ/rasa/issues/9885
- create one central place which documents how to write custom NLU components **and** custom policies
- link to this central place for policies / components
- add migration guide for policies / nlu components
- add changelog for architecture re... | 2021-10-25T10:07:42Z | Update documentation with architecture related changes to Policies and NLU components
**Overview**
We need to update the documentation with the user implications related to the architecture revamp.
**Definition of Done**
- [x] add migration guides for `Policy` / `NLU component`
- [ ] add docs link in relevant pie... | [
{
"body": "**Overview**\r\nWe need to update the documentation with the user implications related to the architecture revamp.\r\n\r\n**Definition of Done**\r\n- [x] add migration guides for `Policy` / `NLU component`\r\n- [ ] add docs link in relevant pieces of the code (e.g. in `rasa/engine/validation`)\r\n- [... | 8c0db04eaee1cd36cefc511c4c8b9a6d5f1ff0b1 | {
"head_commit": "10444e2a39e3172f5d52680c31bab9756e088a77",
"head_commit_message": "append `.mdx` suffix everywhere",
"patch_to_review": "diff --git a/changelog/9803.feature.md b/changelog/9803.feature.md\nnew file mode 100644\nindex 000000000000..b3df0b3716d0\n--- /dev/null\n+++ b/changelog/9803.feature.md\n@@ ... | [
{
"diff_hunk": "@@ -24,6 +26,904 @@ If you still have training data in Markdown format then the recommended approach\n to convert your data from Markdown to YAML. Please use the commands described\n [here](./migration-guide.mdx#training-data-files).\n \n+### Model Configuration\n+\n+It is required to specify th... | 871505aa15ad767c507d59ca909a4b75160b08f7 | diff --git a/changelog/9803.feature.md b/changelog/9803.feature.md
new file mode 100644
index 000000000000..0dabf78d679c
--- /dev/null
+++ b/changelog/9803.feature.md
@@ -0,0 +1,17 @@
+Rasa Open Source now uses the [model configuration](model-configuration.mdx) to build a
+
+[directed acyclic graph](https://en.wikipedi... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Documentation Updates"
} | |
RasaHQ__rasa-9731@f2ec76b | RasaHQ/rasa | Python | 9,731 | Update documentation workflow to only publish one version per major | **Proposed changes**:
- Resolves #9711
**Status (please check what you already did)**:
- [ ] added some tests for the functionality
- [ ] updated the documentation
- [ ] updated the changelog (please check [changelog](https://github.com/RasaHQ/rasa/tree/main/changelog) for instructions)
- [ ] reformat files us... | 2021-09-28T11:12:10Z | update documentation workflow to only publish one version per major
**Goal**
We want to have only one version of the docs per major release. That means that there will be a `2.x` docs and a `3.x` docs. The `2.x` docs will come from the current 2.8 docs, as @m-vdb has already worked on getting the various other 2.x d... | the original scoping document I wrote is [here](https://www.notion.so/rasa/Doc-versions-for-Majors-only-caaf78eadff34d7d8b49eb2284ccc8f9#ef96a397d21a42ae9d0ba0a82494e901). Under the "Release branches" section, you'll find different considerations, with the only viable solution highlighted in green
> (not for every push... | [
{
"body": "**Goal**\r\n\r\nWe want to have only one version of the docs per major release. That means that there will be a `2.x` docs and a `3.x` docs. The `2.x` docs will come from the current 2.8 docs, as @m-vdb has already worked on getting the various other 2.x docs merged into this latest branch of the doc... | 52f036c53a5923f627e1aaca7232268ced6d4ebd | {
"head_commit": "f2ec76bfd948e598a5fb9b2d150c346b50dd871a",
"head_commit_message": "improvements\n\nSigned-off-by: tczekajlo <t.czekajlo@rasa.com>",
"patch_to_review": "diff --git a/.github/workflows/documentation.yml b/.github/workflows/documentation.yml\nindex 00c8595fdec0..b9b6ac79a41d 100644\n--- a/.github/w... | [
{
"diff_hunk": "@@ -14,7 +14,7 @@ set -Eeuo pipefail\n \n TODAY=`date \"+%Y%m%d\"`\n # we build new versions only for minors and majors\n-PATTERN_FOR_NEW_VERSION=\"^refs/tags/[0-9]+\\\\.[0-9]+\\\\.0$\"\n+PATTERN_FOR_NEW_VERSION=\"^refs/tags/[0-9]+\\\\.0\\\\.0$\"\n PATTERN_FOR_MICRO_VERSION=\"^refs/tags/[0-9]+\\... | 1f97f69ee7df5412fde7a8ec3c9f96b28a5d4f1d | diff --git a/.github/workflows/documentation.yml b/.github/workflows/documentation.yml
index 00c8595fdec0..b9b6ac79a41d 100644
--- a/.github/workflows/documentation.yml
+++ b/.github/workflows/documentation.yml
@@ -15,12 +15,85 @@ on:
env:
DOCS_FOLDER: docs
DOCS_BRANCH: documentation
+ TAG_NAME: ${GITHUB_REF#re... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Documentation Updates"
} |
RasaHQ__rasa-9747@309c1f2 | RasaHQ/rasa | Python | 9,747 | Loading and predicting with graph based model. | **Proposed changes**:
This implements most of the functionality for loading and predicting with the graph runner.
## TODO:
- [x] Fixing caching in tests using a fixture (https://github.com/RasaHQ/rasa/pull/9787)
- [x] Fix interactive.
- [x] `yaml_store_reader` in shared is using `regex_message_handler`.
- [x] D... | 2021-09-29T15:15:48Z | Integrate `rasa train` and `rasa run` with new model architecture
**Description**
It's time for a big step 🔥 After having migrated all components, implementing `rasa.engine`, creating the new components for the graph, and implementing the graph generation using the recipes it is time to integrate everything together.... | - [ ] fix caching of empty resource
- [ ] fix recipe tests
- [ ] not load predict thing as part of train
- [ ] rasa train @wochinge
- [ ] rasa predict @joejuzl (maybe: HTTPInterpreter 😁 )
- [ ] fix recipes tests @wochinge
- [ ] fix check logging @joejuzl
Ideas:
* targets for prediction should be in metad... | [
{
"body": "**Description**\r\nIt's time for a big step 🔥 After having migrated all components, implementing `rasa.engine`, creating the new components for the graph, and implementing the graph generation using the recipes it is time to integrate everything together.\r\n\r\n**Definition of Done**\r\n- [ ] `rasa... | 7885ad20ba13405592dc02b99446ecdd8863924e | {
"head_commit": "309c1f26c9e14cd8e26392465ed00156d33a5093",
"head_commit_message": "remove unneeded nlu_merge_needs",
"patch_to_review": "diff --git a/data/graph_schemas/config_pretrained_embeddings_mitie_predict_schema.yml b/data/graph_schemas/config_pretrained_embeddings_mitie_predict_schema.yml\nindex 07db0e5... | [
{
"diff_hunk": "@@ -392,156 +312,110 @@ class Agent:\n def __init__(\n self,\n domain: Union[Text, Domain, None] = None,\n- policies: Union[PolicyEnsemble, List[Policy], None] = None,\n- interpreter: Optional[NaturalLanguageInterpreter] = None,\n generator: Union[Endpoi... | ae9fa996a7f28a329ffc1b043b2e3a04f40535f8 | diff --git a/data/graph_schemas/config_pretrained_embeddings_mitie_predict_schema.yml b/data/graph_schemas/config_pretrained_embeddings_mitie_predict_schema.yml
index 07db0e535556..b2272b8aa26d 100644
--- a/data/graph_schemas/config_pretrained_embeddings_mitie_predict_schema.yml
+++ b/data/graph_schemas/config_pretrain... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
RasaHQ__rasa-9671@b38e974 | RasaHQ/rasa | Python | 9,671 | 3.0 architecture revamp/9604/train | **Proposed changes**:
- implement training (Rasa models, core / nlu models) with the graph architecture
- implement finetuning with the graph architecture
- only use e2e architecture if we have e2e data
- adapt tests to changed training behavior (as far as possible as some depend on model loading)
- As we have a g... | 2021-09-17T16:48:53Z | Integrate `rasa train` and `rasa run` with new model architecture
**Description**
It's time for a big step 🔥 After having migrated all components, implementing `rasa.engine`, creating the new components for the graph, and implementing the graph generation using the recipes it is time to integrate everything together.... | - [ ] fix caching of empty resource
- [ ] fix recipe tests
- [ ] not load predict thing as part of train
- [ ] rasa train @wochinge
- [ ] rasa predict @joejuzl (maybe: HTTPInterpreter 😁 )
- [ ] fix recipes tests @wochinge
- [ ] fix check logging @joejuzl
Ideas:
* targets for prediction should be in metad... | [
{
"body": "**Description**\r\nIt's time for a big step 🔥 After having migrated all components, implementing `rasa.engine`, creating the new components for the graph, and implementing the graph generation using the recipes it is time to integrate everything together.\r\n\r\n**Definition of Done**\r\n- [ ] `rasa... | 9682e314d458da987bd1bcd58b3899a130ae78ed | {
"head_commit": "b38e974e519cfb60253c1ddbd9295977c96b68d9",
"head_commit_message": "add schema validation to training",
"patch_to_review": "diff --git a/.gitignore b/.gitignore\nindex 75b9cfaee43e..c94e5c619220 100644\n--- a/.gitignore\n+++ b/.gitignore\n@@ -84,6 +84,7 @@ env\n .history\n rasa/segment_key\n rasa... | [
{
"diff_hunk": "@@ -96,10 +105,97 @@ def __init__(self) -> None:\n \"\"\"Creates recipe.\"\"\"\n self._use_core = True\n self._use_nlu = True\n+ self._use_end_to_end = True\n self._is_finetuning = False\n \n+ from rasa.nlu.classifiers.diet_classifier import ( # noq... | def1760fd19ab07435ac87734cf125bc5516997d | diff --git a/.gitignore b/.gitignore
index 75b9cfaee43e..c94e5c619220 100644
--- a/.gitignore
+++ b/.gitignore
@@ -84,6 +84,7 @@ env
.history
rasa/segment_key
rasa/keys
+.rasa
/results/
# Local Netlify folder
.netlify
diff --git a/changelog/9604.improvement.md b/changelog/9604.improvement.md
new file mode 100644
... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
RasaHQ__rasa-9920@fcc0ba5 | RasaHQ/rasa | Python | 9,920 | Add recipe to example bot configs. | Closes #9886. | 2021-10-19T09:20:25Z | Update bot examples in repository to use the `DefaultV1.Recipe`
**Overview**
We use the `DefaultV1Recipe` to convert our current config format to the graph architecture. We choose this recipe by default but print a warning if the `recipe` key is not defined in the config file.
**Definition of Done**
- [ ] update ... | [
{
"body": "**Overview**\r\nWe use the `DefaultV1Recipe` to convert our current config format to the graph architecture. We choose this recipe by default but print a warning if the `recipe` key is not defined in the config file. \r\n\r\n**Definition of Done**\r\n- [ ] update all configs in example projects to ha... | ae6d57640978249dc7e69f990e166ccc7160afac | {
"head_commit": "fcc0ba5451ffaf7669c8526a078fe508b4e4c21f",
"head_commit_message": "Merge branch 'main' into add_recipe_to_example_bot_configs",
"patch_to_review": "diff --git a/data/configs_for_docs/example_for_suggested_config.yml b/data/configs_for_docs/example_for_suggested_config.yml\nindex d8de71b0278a..d1... | [
{
"diff_hunk": "@@ -1,8 +1,10 @@\n+recipe: default.v1\n language: en\n \n pipeline:\n - name: \"SpacyNLP\"\n model: \"en_core_web_md\"\n+ - name: \"SpacyPreprocessor\"",
"line": null,
"original_line": 7,
"original_start_line": null,
"path": "examples/moodbot/config.yml",
"start_line":... | 243c2b2a8a56b9a1c9afce299c9a4e954a600307 | diff --git a/data/configs_for_docs/example_for_suggested_config.yml b/data/configs_for_docs/example_for_suggested_config.yml
index d8de71b0278a..d12b0f676380 100644
--- a/data/configs_for_docs/example_for_suggested_config.yml
+++ b/data/configs_for_docs/example_for_suggested_config.yml
@@ -1,3 +1,4 @@
+recipe: default.... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "New Feature Additions"
} | |
RasaHQ__rasa-9184@581a068 | RasaHQ/rasa | Python | 9,184 | Change `TrainingDataImporter` to be sync | **Proposed changes**:
- fix #9131
**Status (please check what you already did)**:
- [ ] added some tests for the functionality
- [ ] updated the documentation
- [ ] updated the changelog (please check [changelog](https://github.com/RasaHQ/rasa/tree/main/changelog) for instructions)
- [x] reformat files using `... | 2021-07-22T11:41:24Z | Change `TrainingDataImporter` to be sync
**Description of Problem**:
Currently our `TrainingDataImporter` interface (and implementations) has a lot of `async` methods.
This will make integrating it into the new graph architecture difficult + we don't actually make sure of any async IO calls (as far as I'm aware).
... | [
{
"body": "**Description of Problem**:\r\nCurrently our `TrainingDataImporter` interface (and implementations) has a lot of `async` methods.\r\nThis will make integrating it into the new graph architecture difficult + we don't actually make sure of any async IO calls (as far as I'm aware).\r\n\r\n**Overview of ... | 819c339f3f5cdf32593cc725ff7d8f4a8253ea3a | {
"head_commit": "581a06801e11aebbbca5a17e481ec1b54385ed14",
"head_commit_message": "Updated docs",
"patch_to_review": "diff --git a/changelog/9131.misc.md b/changelog/9131.misc.md\nnew file mode 100644\nindex 000000000000..6e5e79ee4df1\n--- /dev/null\n+++ b/changelog/9131.misc.md\n@@ -0,0 +1 @@\n+Change `Trainin... | [
{
"diff_hunk": "@@ -8,7 +8,7 @@\n from pathlib import Path\n \n \n-async def test_verify_nlu_with_e2e_story(tmp_path: Path, nlu_data_path: Path):\n+def test_verify_nlu_with_e2e_story(tmp_path: Path, nlu_data_path: Path):\n print()",
"line": null,
"original_line": 12,
"original_start_line": null,... | dcfc60eb2ecb9cffa93cca5d14a43522a0684a43 | diff --git a/changelog/9131.misc.md b/changelog/9131.misc.md
new file mode 100644
index 000000000000..6e5e79ee4df1
--- /dev/null
+++ b/changelog/9131.misc.md
@@ -0,0 +1 @@
+Change `TrainingDataImporter` to be sync.
\ No newline at end of file
diff --git a/docs/docs/migration-guide.mdx b/docs/docs/migration-guide.mdx
in... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Code Refactoring / Architectural Improvement"
} | |
RasaHQ__rasa-9171@4ac27d3 | RasaHQ/rasa | Python | 9,171 | Remove deprecated SingleStateFeaturizer subclasses and method. | **Proposed changes**:
Removes deprecated `SingleStateFeaturizer` subclasses: `BinarySingleStateFeaturizer` and `LabelTokenizerSingleStateFeaturizer`. Deprecated method `encode_all_actions` of `SingleStateFeaturizer` has been deleted.
No links need to be removed from the docs/changelog as these components did not ha... | 2021-07-19T18:21:29Z | 3.0 Deprecation Warnings: Remove deprecated featurizers
**Background**
These warnings were found in:
- rasa.core.featurizers.single_state_featurizer.py:L382, L410
```
"f""'{self.__class__.__name__}' is deprecated and ""
f""will be removed in Rasa Open Source 3.0.0. ""
f""It is recommended to use the '{SingleState... | Since tokenization and featurization tests are tightly coupled, I'm removing `rasa/nlu/utils/hugging_face/hf_transformers.py` as part of https://github.com/RasaHQ/rasa/pull/9120/ . | [
{
"body": "**Background**\r\nThese warnings were found in:\r\n- rasa.core.featurizers.single_state_featurizer.py:L382, L410\r\n```\r\n\"f\"\"'{self.__class__.__name__}' is deprecated and \"\"\r\nf\"\"will be removed in Rasa Open Source 3.0.0. \"\"\r\nf\"\"It is recommended to use the '{SingleStateFeaturizer.__n... | 3ac95305b47270fa62bb70ecc8742e40e6f6a8f2 | {
"head_commit": "4ac27d33dd0aae7b1a30919e774793d5d1cc9d47",
"head_commit_message": "Merge branch 'main' into remove-deprecated-state-featurizers",
"patch_to_review": "diff --git a/changelog/8879.removal.md b/changelog/8879.removal.md\nnew file mode 100644\nindex 000000000000..be7110d74c9c\n--- /dev/null\n+++ b/c... | [
{
"diff_hunk": "@@ -0,0 +1,3 @@\n+Follow through on removing deprecated dialogue policy state featurizers: `BinarySingleStateFeature` and `LabelTokenizerSingleStateFeaturizer`.\n+\n+Remove deprecated `SingleStateFeaturizer` method `encode_all_actions`. Use `encode_all_labels` instead.",
"line": null,
"o... | d525289ed900aff33060646bb90161cac44469f1 | diff --git a/changelog/8879.removal.md b/changelog/8879.removal.md
new file mode 100644
index 000000000000..8991d1c3e5e7
--- /dev/null
+++ b/changelog/8879.removal.md
@@ -0,0 +1,3 @@
+Removed the deprecated dialogue policy state featurizers: `BinarySingleStateFeature` and `LabelTokenizerSingleStateFeaturizer`.
+
+Remov... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Code Refactoring / Architectural Improvement"
} |
RasaHQ__rasa-9134@689b96d | RasaHQ/rasa | Python | 9,134 | Remove tracker store deprecations | **Proposed changes**:
Fixes #8874
**Status (please check what you already did)**:
- [x] updated the changelog (please check [changelog](https://github.com/RasaHQ/rasa/tree/main/changelog) for instructions)
- [x] reformat files using `black` (please check [Readme](https://github.com/RasaHQ/rasa#code-style) for in... | 2021-07-15T13:58:04Z | 3.0 Deprecation Warnings: Action `TrackerStore` deprecations
**Background**
These warnings were found in:
- rasa.core.tracker_store.py:L99
```
"f""Specifying the `retrieve_events_from_previous_conversation_sessions` ""
f""kwarg for the `{self.__class__.__name__}` class is deprecated and ""
f""will be removed in R... | Also found this one in `DynamoTrackerStore`:
```
def save(self, tracker: DialogueStateTracker) -> None:
"""Saves the current conversation state."""
from botocore.exceptions import ClientError
if self.event_broker:
self.stream_events(tracker)
serialized = self.s... | [
{
"body": "**Background**\r\nThese warnings were found in:\r\n- rasa.core.tracker_store.py:L99\r\n```\r\n\"f\"\"Specifying the `retrieve_events_from_previous_conversation_sessions` \"\"\r\nf\"\"kwarg for the `{self.__class__.__name__}` class is deprecated and \"\"\r\nf\"\"will be removed in Rasa Open Source 3.0... | 55d426476e42b8949757835dba8137775f25e213 | {
"head_commit": "689b96dbd0f2abb12c6c0cd21219424cf2e9eccc",
"head_commit_message": "Remove tracker store deprecations",
"patch_to_review": "diff --git a/changelog/8874.removal.md b/changelog/8874.removal.md\nnew file mode 100644\nindex 000000000000..6a3319494b5f\n--- /dev/null\n+++ b/changelog/8874.removal.md\n@... | [
{
"diff_hunk": "@@ -285,10 +249,12 @@ def deserialise_tracker(\n \n try:\n dialogue = Dialogue.from_parameters(json.loads(serialised_tracker))\n- except UnicodeDecodeError:\n- dialogue = self._deserialize_dialogue_from_pickle(\n- sender_id, serialised_tracker... | 616864a8e717d73d682d6a4cb6e74aa98359d36a | diff --git a/changelog/8874.removal.md b/changelog/8874.removal.md
new file mode 100644
index 000000000000..f44810149989
--- /dev/null
+++ b/changelog/8874.removal.md
@@ -0,0 +1,7 @@
+Specifying the `retrieve_events_from_previous_conversation_sessions` kwarg for the any `TrackerStore` was deprecated and has now been re... | {
"difficulty": "low",
"estimated_review_effort": 3,
"problem_domain": "Code Refactoring / Architectural Improvement"
} |
RasaHQ__rasa-9127@d3157fe | RasaHQ/rasa | Python | 9,127 | Follow through on deprecation warnings for `rasa.shared.data`. | **Proposed changes**:
- fix #8867
**Status (please check what you already did)**:
- [ ] added some tests for the functionality
- [ ] updated the documentation
- [x] updated the changelog (please check [changelog](https://github.com/RasaHQ/rasa/tree/main/changelog) for instructions)
- [x] reformat files using `... | 2021-07-15T07:03:03Z | 3.0 Deprecation Warning: Resolve `rasa.shared.data` warnings
**Background**:
These warnings were found in:
- rasa.shared.data.py:L74
```
"`get_test_directory` is deprecated and will be removed in Rasa 3.0.0. "
```
- rasa.shared.data.py:L120
```
"`get_core_nlu_directories` is deprecated and will be removed in Ra... | [
{
"body": "**Background**:\r\nThese warnings were found in:\r\n- rasa.shared.data.py:L74\r\n```\r\n\"`get_test_directory` is deprecated and will be removed in Rasa 3.0.0. \"\r\n```\r\n- rasa.shared.data.py:L120\r\n```\r\n\"`get_core_nlu_directories` is deprecated and will be removed in Rasa 3.0.0. \"\r\n```\r\n... | cb3d66d36a99fadf552b791942e14f35bdc98cad | {
"head_commit": "d3157fe27211a5371140f491d2110a46280aa444",
"head_commit_message": "Follow through on deprecation warnings for `rasa.shared.data`.",
"patch_to_review": "diff --git a/changelog/8867.removal.md b/changelog/8867.removal.md\nnew file mode 100644\nindex 000000000000..0687f9033b43\n--- /dev/null\n+++ b... | [
{
"diff_hunk": "@@ -75,15 +75,15 @@ chat(model_path, endpoints)\n ## Evaluate your model against test data\n \n Rasa has a convenience function for getting your training data.\n-Rasa's `get_core_nlu_directories` is a function which\n-recursively finds all the stories and NLU data files in a directory\n-and copi... | 7b4c731029986dd7a36e0387b120f5845eadb0fc | diff --git a/changelog/8867.removal.md b/changelog/8867.removal.md
new file mode 100644
index 000000000000..0687f9033b43
--- /dev/null
+++ b/changelog/8867.removal.md
@@ -0,0 +1 @@
+Follow through on deprecation warnings for `rasa.shared.data`.
diff --git a/docs/docs/jupyter-notebooks.mdx b/docs/docs/jupyter-notebooks.... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
RasaHQ__rasa-9119@63d0773 | RasaHQ/rasa | Python | 9,119 | Remove Policy deprecations and set max_history default to None. | **Proposed changes**:
- Remove the following deprecated policy classes:
- `FormPolicy`
- `MappingPolicy`
- `FallbackPolicy`
- `TwoStageFallbackPolicy`
- `SklearnPolicy`
- Update the max history defaults in `MemoizationPolicy`.
- Remove/edit tests that depended on deprecated modules.
- Remove depr... | 2021-07-13T23:41:47Z | 3.0 Deprecation Warnings: Remove Policy deprecations
**Background**
These warnings were found in:
- rasa.core.policies.fallback.py:L66
```
"f""'{self.__class__.__name__}' is deprecated and will be removed ""
""in the future. It is recommended to use the 'RulePolicy' instead."""
```
- rasa.core.policies.form_poli... | @ancalita @JEM-Mosig @TyDunn `TwoStageFallbackPolicy` is listed as deprecated in our [docs page](https://rasa.com/docs/rasa/policies#two-stage-fallback-policy), but does not have a deprecation warning in its constructor. Is this an oversight and should we also remove it from the code base along with these other deprec... | [
{
"body": "**Background**\r\nThese warnings were found in:\r\n- rasa.core.policies.fallback.py:L66\r\n```\r\n\"f\"\"'{self.__class__.__name__}' is deprecated and will be removed \"\"\r\n\"\"in the future. It is recommended to use the 'RulePolicy' instead.\"\"\"\r\n```\r\n- rasa.core.policies.form_policy.py:L51\... | e3a366969c1fa0fda06e27df297647224b2f6643 | {
"head_commit": "63d07731c26a70d6f33137b55c4b052f527b2b47",
"head_commit_message": "Removed broken links in changelog.",
"patch_to_review": "diff --git a/CHANGELOG.mdx b/CHANGELOG.mdx\nindex 45b4ddc82ca7..a673a812c22b 100644\n--- a/CHANGELOG.mdx\n+++ b/CHANGELOG.mdx\n@@ -667,7 +667,7 @@ https://github.com/RasaHQ... | [
{
"diff_hunk": "@@ -1046,9 +400,13 @@ def test_get_training_trackers_for_policy(\n assert len(ml_trackers) == n_ml_trackers\n \n \n-@pytest.mark.parametrize(\n- \"policy\", [FormPolicy, MappingPolicy, FallbackPolicy, TwoStageFallbackPolicy]\n-)\n-def test_deprecation_warnings_for_old_rule_like_policies(p... | bcfe368013bb1efb8b6bd20d7b7a5ea7d78ae511 | diff --git a/CHANGELOG.mdx b/CHANGELOG.mdx
index 8e855f6c5e82..b1dff106517e 100644
--- a/CHANGELOG.mdx
+++ b/CHANGELOG.mdx
@@ -783,7 +783,7 @@ https://github.com/RasaHQ/rasa/tree/main/changelog/ . -->
### Improvements
- [#7520](https://github.com/rasahq/rasa/issues/7520): Improve the warning in case the [RulePolicy... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Code Refactoring / Architectural Improvement"
} |
RasaHQ__rasa-8516@27f3539 | RasaHQ/rasa | Python | 8,516 | Make it possible to use `null` entities in stories | **Proposed changes**:
- fix #8300
**Status (please check what you already did)**:
- [x] added some tests for the functionality
- [ ] updated the documentation
- [x] updated the changelog (please check [changelog](https://github.com/RasaHQ/rasa/tree/main/changelog) for instructions)
- [x] reformat files using `b... | 2021-04-21T08:40:51Z | Erro when specifying "null" entities in stories
**Rasa version**: 2.4.2
**Rasa SDK version** 2.4.1
**Python version**: 3.7.10
**Operating system** (windows, osx, ...): Linux-4.19.112+-x86_64-with-Ubuntu-18.04-bionic
**Issue**:
Rasa crashes when a story contains a "null" entity. That story would be used to ... | Thanks for the issue, @dakshvar22 will get back to you about it soon!
###### You may find help in the [docs](https://rasa.com/docs/) and the [forum,](https://forum.rasa.com/) too 🤗 | [
{
"body": "**Rasa version**: 2.4.2\r\n\r\n**Rasa SDK version** 2.4.1\r\n\r\n**Python version**: 3.7.10\r\n\r\n**Operating system** (windows, osx, ...): Linux-4.19.112+-x86_64-with-Ubuntu-18.04-bionic\r\n\r\n**Issue**:\r\nRasa crashes when a story contains a \"null\" entity. That story would be used to handle th... | f8245fb3458586883dac4c7ec58d069c96c08b15 | {
"head_commit": "27f3539f97d5eb267a8818bfad9b967b7a641ede",
"head_commit_message": "Updated `test_yaml_writer_stories_to_yaml_with_null_entities`",
"patch_to_review": "diff --git a/changelog/8300.bugfix.md b/changelog/8300.bugfix.md\nnew file mode 100644\nindex 000000000000..2a654bac8125\n--- /dev/null\n+++ b/ch... | [
{
"diff_hunk": "@@ -183,6 +183,33 @@ def test_yaml_writer_stories_to_yaml(domain: Domain):\n assert len(result[\"stories\"]) == 1\n \n \n+def test_yaml_writer_stories_to_yaml_with_null_entities(domain: Domain):\n+ from collections import OrderedDict",
"line": null,
"original_line": 187,
"orig... | 2b7fda7502141b1a5ec838f82b07abff2906037e | diff --git a/changelog/8300.bugfix.md b/changelog/8300.bugfix.md
new file mode 100644
index 000000000000..2a654bac8125
--- /dev/null
+++ b/changelog/8300.bugfix.md
@@ -0,0 +1 @@
+Make it possible to use `null` entities in stories.
\ No newline at end of file
diff --git a/rasa/shared/core/training_data/story_writer/yaml... | {
"difficulty": "low",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
RasaHQ__rasa-9114@bd4ca3f | RasaHQ/rasa | Python | 9,114 | Turned `utils.common` deprecation warning into exception | **Proposed changes**:
- fixes #8873
**Status (please check what you already did)**:
- [x] reformat files using `black` (please check [Readme](https://github.com/RasaHQ/rasa#code-style) for instructions)
| 2021-07-13T06:22:31Z | 3.0 Deprecation Warning: Convert warning into exception in `rasa.shared.utils.common.py`
**Background**
This warning was found in `rasa.shared.utils.common.py:L48`
```
"f""`class_from_module_path()` is expected to return a class, ""
f""but {module_path} is not one. ""
f""This warning will be converted ""
f""into ... | [
{
"body": "**Background**\r\nThis warning was found in `rasa.shared.utils.common.py:L48`\r\n```\r\n\"f\"\"`class_from_module_path()` is expected to return a class, \"\"\r\nf\"\"but {module_path} is not one. \"\"\r\nf\"\"This warning will be converted \"\"\r\nf\"\"into an exception in {NEXT_MAJOR_VERSION_FOR_DEP... | d6426e909e687b139b3d9b5671861ac4269b8232 | {
"head_commit": "bd4ca3f62377eab72264c5421916bcd1c2091fa0",
"head_commit_message": "Merge branch 'main' into 8873-utils-common-deprecations",
"patch_to_review": "diff --git a/rasa/shared/utils/common.py b/rasa/shared/utils/common.py\nindex 0a46e87175b4..5ee91e70e2c1 100644\n--- a/rasa/shared/utils/common.py\n+++... | [
{
"diff_hunk": "@@ -45,13 +41,10 @@ def class_from_module_path(\n raise ImportError(f\"Cannot retrieve class from path {module_path}.\")\n \n if not inspect.isclass(klass):\n- rasa.shared.utils.io.raise_deprecation_warning(\n+ raise TypeError(",
"line": null,
"original_line": 4... | 0ae74500b97803668ef42ea707d2610179979aac | diff --git a/changelog/8873.removal.md b/changelog/8873.removal.md
new file mode 100644
index 000000000000..1225dd31acd4
--- /dev/null
+++ b/changelog/8873.removal.md
@@ -0,0 +1,2 @@
+Raising `RasaException` instead of deprecation warning when using
+`class_from_module_path` for loading types other than classes.
diff ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
RasaHQ__rasa-9118@8052ce3 | RasaHQ/rasa | Python | 9,118 | Add ability to point to a certificate in endpoints.yml | **Proposed changes**:
Fixes #9085
Adds support for the parameter `cafile` in `endpoints.yml`.
If this points to a local certificate, this will be used when making a request to that endpoint.
**Status (please check what you already did)**:
- [x] added some tests for the functionality
- [ ] updated the documen... | 2021-07-13T13:52:58Z | Create custom SSL context in Rasa OSS
**Description of Problem**:
When an action server is deployed with a custom SSL certificate the necessary CA certificates also need to be available within Rasa OSS.
**Definition of Done**:
<!-- What needs to be there to consider this feature as done?
- [ ] Tests are added
- ... | [
{
"body": "**Description of Problem**:\r\nWhen an action server is deployed with a custom SSL certificate the necessary CA certificates also need to be available within Rasa OSS.\r\n\r\n**Definition of Done**:\r\n<!-- What needs to be there to consider this feature as done?\r\n- [ ] Tests are added\r\n- [ ] Fea... | f62737148f37bd7ff3c43a85f75abc68de49ba45 | {
"head_commit": "8052ce38b204283395e8d72c485b7861e5fe6d16",
"head_commit_message": "Add cert file functionality to Endpoint",
"patch_to_review": "diff --git a/changelog/9085.improvement.md b/changelog/9085.improvement.md\nnew file mode 100644\nindex 000000000000..20acbfb972b9\n--- /dev/null\n+++ b/changelog/9085... | [
{
"diff_hunk": "@@ -92,6 +93,38 @@ async def test_endpoint_config():\n assert s._default_auth.password == \"pass\"\n \n \n+async def test_endpoint_config_with_cafile(tmp_path):\n+ cafile = \"data/test_endpoints/cert.pem\"\n+\n+ with aioresponses() as mocked:\n+ endpoint = endpoint_utils... | ee44dfdd8ffb14890071075296fcd2fd493095e4 | diff --git a/changelog/9085.improvement.md b/changelog/9085.improvement.md
new file mode 100644
index 000000000000..edffce0cda45
--- /dev/null
+++ b/changelog/9085.improvement.md
@@ -0,0 +1,12 @@
+Add support for `cafile` parameter in `endpoints.yaml`.
+This will load a custom local certificate file and use it when mak... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
RasaHQ__rasa-8718@c0ec313 | RasaHQ/rasa | Python | 8,718 | remake: Tensorlfow cpp warn log supression for pytest | remake of #8702 / seems there was some problem with my poetry version that messed up dependencies
**Proposed changes**:
- fixes #7762
- added pytest-env dependency
- added TF_CPP_MIN_LOG_LEVEL=2 as default to pytest.ini to suppress tensorflow C++ code warnings, info, and debug by default
**Status (please ch... | 2021-05-19T08:45:23Z | Suppress noisy tensorflow logs on linux and Windows
**Rasa version**:
2.2.4
**Python version**:
3.7.2
**Operating system** (windows, osx, ...):
Windows, Linux
**Issue**:
It seems that the hack to suppress noisy tensorflow logs is no longer working for Windows or Linux. This confuses users unnecessarily.
*... | Relates to: https://github.com/RasaHQ/rasa/issues/7738
Based on [this Slack discussion](https://rasa-hq.slack.com/archives/C8LEHMTAM/p1617097796180900?thread_ts=1617090758.172800&cid=C8LEHMTAM), we are going to move this to Enable
This particular warning doesn't seem to be just a nuisance.
Found [a tensorflow issue]... | [
{
"body": "**Rasa version**:\r\n2.2.4\r\n**Python version**:\r\n3.7.2\r\n**Operating system** (windows, osx, ...):\r\nWindows, Linux\r\n\r\n**Issue**:\r\n\r\nIt seems that the hack to suppress noisy tensorflow logs is no longer working for Windows or Linux. This confuses users unnecessarily.\r\n\r\n**Error (inc... | 8130c3047d7431927b1ed0708b867df1b3239d12 | {
"head_commit": "c0ec3139a9611873cc79ca72fea39af5396fb5d5",
"head_commit_message": "Added pytest-env dependency, added tensorlfow warn log supression for all pytest invocations",
"patch_to_review": "diff --git a/poetry.lock b/poetry.lock\nindex 8a253fce13e8..ff1219fe94b4 100644\n--- a/poetry.lock\n+++ b/poetry.l... | [
{
"diff_hunk": "@@ -152,6 +152,7 @@ bandit = \"^1.6.3\"\n typing-extensions = \"^3.7.4\"\n memory-profiler = \"^0.58.0\"\n psutil = \"^5.8.0\"\n+pytest-env = \"^0.6.2\"",
"line": null,
"original_line": 155,
"original_start_line": null,
"path": "pyproject.toml",
"start_line": null,
"text"... | 6bfb948fc71dd97b6cdfa297ee24ad543dc7fe45 | diff --git a/Makefile b/Makefile
index 25dbb959a690..18b6b28e644e 100644
--- a/Makefile
+++ b/Makefile
@@ -158,14 +158,16 @@ prepare-tests-windows-gha: prepare-wget-windows-gha prepare-tests-files
test: clean
# OMP_NUM_THREADS can improve overall performance using one thread by process (on tensorflow), avoiding ov... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
RasaHQ__rasa-9120@5b5a5ae | RasaHQ/rasa | Python | 9,120 | Remove deprecated tokenizers ConveRTTokenizer and LanguageModelTokenizer. | **Proposed changes**:
Remove deprecated `LanguageModelTokenizer` and `ConveRTTokenizer` classes.
There were two tests in `tests/nlu/featurizers/test_lm_featurizer.py` that tested these tokenizers and I have removed them as well.
Docs entries were removed as well.
Also removing `HFTransformersNLP` class, tests, a... | 2021-07-14T00:14:16Z | 3.0 Deprecation Warning: Remove deprecated tokenizers
**Background**
This warning was found in:
- rasa.nlu.tokenizers.convert_tokenizer:L27
- rasa.nlu.tokenizers.lm_tokenizer.py:L21
```
"f""'{self.__class__.__name__}' is deprecated and ""
f""will be removed in the future. ""
f""It is recommended to use the '{Whi... | Are we actually removing these tokenisers in 3.0? 🤔 | [
{
"body": "**Background**\r\nThis warning was found in:\r\n- rasa.nlu.tokenizers.convert_tokenizer:L27\r\n- rasa.nlu.tokenizers.lm_tokenizer.py:L21\r\n```\r\n\"f\"\"'{self.__class__.__name__}' is deprecated and \"\"\r\nf\"\"will be removed in the future. \"\"\r\nf\"\"It is recommended to use the '{WhitespaceTok... | 7c2206d5de7d5562aa667019414151fb90dfeef3 | {
"head_commit": "5b5a5ae52cd9f5b5d0922aeabc07aa5aea97a7a3",
"head_commit_message": "Removed unnecessary imports.",
"patch_to_review": "diff --git a/rasa/nlu/registry.py b/rasa/nlu/registry.py\nindex 4f0891ddda9f..c59af8574e52 100644\n--- a/rasa/nlu/registry.py\n+++ b/rasa/nlu/registry.py\n@@ -33,12 +33,10 @@\n f... | [
{
"diff_hunk": "@@ -129,7 +129,6 @@ def test_all_components_are_in_at_least_one_test_pipeline():\n \n for cls in registry.component_classes:\n if \"convert\" in cls.name.lower():\n- # TODO",
"line": 132,
"original_line": 132,
"original_start_line": null,
"path": "tests/nlu... | 18ee7727eec3a32121ff6e0bcecdbd0522af2f0b | diff --git a/CHANGELOG.mdx b/CHANGELOG.mdx
index b1dff106517e..4b676cd09feb 100644
--- a/CHANGELOG.mdx
+++ b/CHANGELOG.mdx
@@ -1321,7 +1321,7 @@ https://github.com/RasaHQ/rasa/tree/main/changelog/ . -->
### Bugfixes
-- [#7089](https://github.com/rasahq/rasa/issues/7089): Fix [ConveRTTokenizer](components.mdx#conve... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Code Refactoring / Architectural Improvement"
} |
RasaHQ__rasa-9405@a0fe7a2 | RasaHQ/rasa | Python | 9,405 | 3.0 architecture revamp/9340/e2e lookup | **Proposed changes**:
- closes #9340
- build the lookup table:
- lookup table implementation and tests (see `rasa.core.featurizers.precomputation`)
- components for prep/build of lookup table (start and end of e2e featurization pipeline) (see `rasa.core.featurizers.precomputation`)
- using the lookup table: ... | 2021-08-20T08:33:19Z | [Re-implement featurization] Move to integration branch, adapt Policies, and add checks
**Definition of Done**
- [x] moved changes over to `main` branch
- [x] updated graph components (`StoryToTrainingDataConverter` and `MessageE2EFeatureConverter`) and added/adapted unit tests
- [x ] adapted unit tests for `Tracker... | [
{
"body": "**Definition of Done**\r\n- [x] moved changes over to `main` branch\r\n- [x] updated graph components (`StoryToTrainingDataConverter` and `MessageE2EFeatureConverter`) and added/adapted unit tests\r\n- [x ] adapted unit tests for `TrackerFeaturizer`\r\n- [x] adpated unit tests for `TEDPolicy` ~~and `... | b4118747b0e9d7696d49b2ba855ab7d097be923f | {
"head_commit": "a0fe7a2f22ee2388408bc89a0c388f2bced1225a",
"head_commit_message": "minor (add some more features check, types, add note,...)",
"patch_to_review": "diff --git a/rasa/core/featurizers/_single_state_featurizer.py b/rasa/core/featurizers/_single_state_featurizer.py\nnew file mode 100644\nindex 00000... | [
{
"diff_hunk": "@@ -721,19 +722,22 @@ def train(\n \n return self._resource\n \n- def _featurize_tracker_for_e2e(\n+ def _featurize_tracker(\n self,\n tracker: DialogueStateTracker,\n domain: Domain,\n- interpreter: NaturalLanguageInterpreter,\n+ precomputatio... | a2f4a59d08e0ed20dca01ec0f37e1f7e12743e87 | diff --git a/rasa/core/featurizers/_single_state_featurizer.py b/rasa/core/featurizers/_single_state_featurizer.py
new file mode 100644
index 000000000000..f8a6a08aa2f4
--- /dev/null
+++ b/rasa/core/featurizers/_single_state_featurizer.py
@@ -0,0 +1,409 @@
+# WARNING: This module will be dropped before Rasa Open Source... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Code Refactoring / Architectural Improvement"
} | |
RasaHQ__rasa-8151@ccea69e | RasaHQ/rasa | Python | 8,151 | Allow tests to be located anywhere, not just in `tests` directory | **Proposed changes**:
- fix #7763
**Status (please check what you already did)**:
- [x] added some tests for the functionality
- [ ] updated the documentation
- [x] updated the changelog (please check [changelog](https://github.com/RasaHQ/rasa/tree/main/changelog) for instructions)
- [x] reformat files using `... | 2021-03-09T12:27:15Z | `rasa test` should search for test files recursively in all sub-directories, not just under `tests/`
**Rasa version**:
2.2.4
**Python version**:
3.7.2
**Operating system** (windows, osx, ...):
OSX
**Issue**:
`rasa test` looks recursively for files prefixed with `test_`, but only in subdirectories of `tests/`. ... | @kalkbrennerei finally got around to making this. Could you add some comments if you have any? Thank you!
from our Slack discussion:
Lu:"I think rasa test and rasa test core are both using test.py::run_core_test internally but with different args"
thanks @koernerfelicia! I think I have nothing to add 😃
but maybe... | [
{
"body": "**Rasa version**:\r\n2.2.4\r\n**Python version**:\r\n3.7.2\r\n**Operating system** (windows, osx, ...):\r\nOSX\r\n\r\n**Issue**:\r\n`rasa test` looks recursively for files prefixed with `test_`, but only in subdirectories of `tests/`. It should look recursively in all subdirectories.\r\n`rasa test co... | 32eb0717a28708a4d86389e1497544faced99976 | {
"head_commit": "ccea69e67670371d63eaa07ad3a500d22e6dc4c1",
"head_commit_message": "Rollback `test_only_getting_e2e_conversation_tests_if_e2e_enabled` change",
"patch_to_review": "diff --git a/changelog/7763.improvement.md b/changelog/7763.improvement.md\nnew file mode 100644\nindex 000000000000..54906a7b2bfa\n-... | [
{
"diff_hunk": "@@ -341,6 +341,20 @@ def is_stories_file(file_path: Union[Text, Path]) -> bool:\n )\n return False\n \n+ @staticmethod\n+ def _is_tests_file(file_path: Text) -> bool:\n+ \"\"\"Check if the filename of a file at a path is a tests file.\n+\n+ Arguments:\... | f578651e3eed6176c423b03fd1996a3e08cb64dd | diff --git a/changelog/7763.improvement.md b/changelog/7763.improvement.md
new file mode 100644
index 000000000000..54906a7b2bfa
--- /dev/null
+++ b/changelog/7763.improvement.md
@@ -0,0 +1 @@
+Allow tests to be located anywhere, not just in `tests` directory.
\ No newline at end of file
diff --git a/rasa/shared/consta... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
RasaHQ__rasa-8161@f88c4da | RasaHQ/rasa | Python | 8,161 | Rules states should not include the initial values of slots. | **Proposed changes**:
Fixes #7450
When calculating tracker states from rules we were including the initial value of slots.
This meant that the rule only matched when a slot had that initial value.
This change omits initial values of slots from the rule states.
**Status (please check what you already did)**:
... | 2021-03-10T09:36:18Z | Rule applicability depends on slot values when initial_value is used
**Rasa version**: 2.1.2
**Rasa SDK version** (if used & relevant):
**Rasa X version** (if used & relevant):
**Python version**: 3.8.5
**Operating system** (windows, osx, ...): Mac
**Issue**:
When using `initial_value` for some slot `s`... | [
{
"body": "**Rasa version**: 2.1.2\r\n\r\n**Rasa SDK version** (if used & relevant):\r\n\r\n**Rasa X version** (if used & relevant):\r\n\r\n**Python version**: 3.8.5\r\n\r\n**Operating system** (windows, osx, ...): Mac\r\n\r\n**Issue**:\r\nWhen using `initial_value` for some slot `s` whose value influences the ... | 8692ea37d03fa4c4244919e0ab310ed1691990a6 | {
"head_commit": "f88c4dadd9e717512eb3b05c0a0ce92faeb6c217",
"head_commit_message": "Merge branch 'main' into 7450-rule_applicability_depends_on_slots_initial_value",
"patch_to_review": "diff --git a/changelog/7450.bugfix.md b/changelog/7450.bugfix.md\nnew file mode 100644\nindex 000000000000..c09ead50a69c\n--- /... | [
{
"diff_hunk": "@@ -922,6 +920,113 @@ async def test_predict_form_action_if_multiple_turns():\n assert_predicted_action(prediction, domain, form_name, is_no_user_prediction=True)\n \n \n+async def test_predict_slot_initial_value_not_required_in_rule():\n+ domain = Domain.from_yaml(\n+ \"\"\"\n+int... | 88555f66289917ce131a6d1b531155857d6b736e | diff --git a/changelog/7450.bugfix.md b/changelog/7450.bugfix.md
new file mode 100644
index 000000000000..c09ead50a69c
--- /dev/null
+++ b/changelog/7450.bugfix.md
@@ -0,0 +1,2 @@
+Rule tracker states no longer include the initial value of slots.
+Rules now only require slot values when explicitly stated in the rule.
d... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} | |
RasaHQ__rasa-7933@404f988 | RasaHQ/rasa | Python | 7,933 | Rasa NLU data spec update | **Proposed changes**:
Fix #7063
After some investigation I figured the following:
The support of JSON has not been removed but the provided data needs to be a JSON formatted the way it can be read by `RasaReader`. However, there is no information about it in the spec. For example, I used [this JSON](https://gi... | 2021-02-10T15:59:04Z | POST `/model/test/intents` endpoint fails
**Rasa version**: 2.0.0
**Python version**: 3.7
**Operating system** (windows, osx, ...): osx
**Issue**:
Calling POST `/model/test/intents` endpoint from `rasa x` with correct `model` path and body causes `500 Internal Server Error`
**Error (including full traceb... | my findings so far:
the request body I provided is in JSON format (which I get when calling from `rasa x`). It seems like the support for JSON was removed in 2.0
@federicotdn @degiz Can one of you please confirm? Do we need to update the API spec then?
I can definitely confirm that, since we've been debugging this i... | [
{
"body": "**Rasa version**: 2.0.0\r\n\r\n**Python version**: 3.7\r\n\r\n**Operating system** (windows, osx, ...): osx\r\n\r\n**Issue**:\r\nCalling POST `/model/test/intents` endpoint from `rasa x` with correct `model` path and body causes `500 Internal Server Error`\r\n\r\n\r\n**Error (including full traceback... | 403b5064989217eff254fcae7a7c80a19c21f5de | {
"head_commit": "404f988c876e656ed872ecc05cd8642b20b4eb8c",
"head_commit_message": "Updated schema and md changelog entry",
"patch_to_review": "diff --git a/changelog/7063.bugfix.md b/changelog/7063.bugfix.md\nnew file mode 100644\nindex 000000000000..660c79a84b83\n--- /dev/null\n+++ b/changelog/7063.bugfix.md\n... | [
{
"diff_hunk": "@@ -794,6 +794,47 @@ async def test_evaluate_intent(rasa_app: SanicASGITestClient, default_nlu_data:\n }\n \n \n+async def test_evaluate_intent_json(\n+ rasa_app: SanicASGITestClient, default_nlu_data: Text",
"line": null,
"original_line": 798,
"original_start_line": null,
... | 008066dc13dc5877507877949343041d0a090639 | diff --git a/changelog/7063.bugfix.md b/changelog/7063.bugfix.md
new file mode 100644
index 000000000000..660c79a84b83
--- /dev/null
+++ b/changelog/7063.bugfix.md
@@ -0,0 +1,4 @@
+Update the spec of `POST /model/test/intents` and add tests for cases when JSON is provided.
+
+Fix the incorrect temporary file extension ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
RasaHQ__rasa-8030@3859394 | RasaHQ/rasa | Python | 8,030 | Fix logging of conversation level core metrics. | Fix logging of conversation level core metrics to only compute and log conversation level accuracy. Formerly F1-Score and precision were being printed to console but upon investigation, these metrics were not very meaningful (precision was always 1.0 if any story was completely correct and 0 otherwise). Additionally, i... | 2021-02-23T21:08:20Z | Clean up and log to file Conversation level performance measures.
**Description of Problem**:
When running rasa test, performance measures for the core model are printed to the console and/or logged to `results/story_report.json`. What is printed to the console is split into two main result blocks, CONVERSATION (or E2... | Thanks for submitting this feature request 🚀 @joejuzl will get back to you about it soon! ✨ | [
{
"body": "**Description of Problem**:\r\nWhen running rasa test, performance measures for the core model are printed to the console and/or logged to `results/story_report.json`. What is printed to the console is split into two main result blocks, CONVERSATION (or E2E when evaluating E2E data) and ACTION level ... | 5feb5a8ce5ad335e98c848b5fe03b3a25fe2094c | {
"head_commit": "38593940450a93aaac7a880782bf6bb3f5c89cdb",
"head_commit_message": "Fix logging of conversation level core metrics to only show conversation level accuracy. Add conversation level accuracy to story_report.json",
"patch_to_review": "diff --git a/rasa/core/test.py b/rasa/core/test.py\nindex 503cb21... | [
{
"diff_hunk": "@@ -702,26 +702,18 @@ async def _collect_story_predictions(\n success.append(predicted_tracker)\n \n logger.info(\"Finished collecting predictions.\")\n- with warnings.catch_warnings():\n- from sklearn.exceptions import UndefinedMetricWarning\n-\n- warnings.simpl... | 64628eb962d7bd4762982c4c379c63f7a387e255 | diff --git a/changelog/8000.improvement.md b/changelog/8000.improvement.md
new file mode 100644
index 000000000000..beedf1fd1f41
--- /dev/null
+++ b/changelog/8000.improvement.md
@@ -0,0 +1,3 @@
+Remove console logging of conversation level F1-score and precision since these calculations were not meaningful.
+
+Add con... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Code Refactoring / Architectural Improvement"
} |
RasaHQ__rasa-7341@fa99236 | RasaHQ/rasa | Python | 7,341 | Fix tracker init copy method | **Proposed changes**:
- The `init_copy` function of `DialogStateTracker` now uses the `sender_id` of the tracker to be copied
- Fixes #7338
**Status (please check what you already did)**:
- [x] added some tests for the functionality
- [ ] updated the documentation
- [x] updated the changelog (please check [cha... | 2020-11-23T14:04:21Z | tracker.sender_id always returns `default` in custom actions
**Rasa version**: 2.1.0
**Rasa SDK version**: 2.1.1
**Python version**: 3.7.9
**Operating system**: Ubuntu
**Issue**:
In all of my custom actions, `tracker.sender_id` now always returns `default` instead of the actual sender id. We are heavily us... | Thanks for raising this issue, @joejuzl will get back to you about it soon✨
###### Please also check out the [docs](https://rasa.com/docs/) and the [forum](https://forum.rasa.com/) in case your issue was raised there too 🤗
Hi @joejuzl ! I was wondering if you had a chance to look into that? Any help would be greatly ... | [
{
"body": "**Rasa version**: 2.1.0\r\n\r\n**Rasa SDK version**: 2.1.1\r\n\r\n**Python version**: 3.7.9\r\n\r\n**Operating system**: Ubuntu\r\n\r\n**Issue**:\r\nIn all of my custom actions, `tracker.sender_id` now always returns `default` instead of the actual sender id. We are heavily using this sender id as us... | 384b078b74e7f365f9262d80977a30615d6ecb3f | {
"head_commit": "fa99236404651edf8dbce7da14455286a9e8728e",
"head_commit_message": "add changelog for copying the sender id",
"patch_to_review": "diff --git a/changelog/7338.bugfix.md b/changelog/7338.bugfix.md\nnew file mode 100644\nindex 000000000000..006f4e1b69b9\n--- /dev/null\n+++ b/changelog/7338.bugfix.md... | [
{
"diff_hunk": "@@ -0,0 +1 @@\n+Sender id is correctly set when copying the tracker and sending it to the action server (instead of sending the `default` value)",
"line": null,
"original_line": 1,
"original_start_line": null,
"path": "changelog/7338.bugfix.md",
"start_line": null,
"text"... | 9c13e09ff12c4ae67a5b83a8119efac4dc5ab821 | diff --git a/.github/workflows/continous-integration.yml b/.github/workflows/continous-integration.yml
index 45b8da9d39fb..6b819a08a6d4 100644
--- a/.github/workflows/continous-integration.yml
+++ b/.github/workflows/continous-integration.yml
@@ -160,7 +160,7 @@ jobs:
# Fetch entire history for current branc... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
RasaHQ__rasa-7498@903d25a | RasaHQ/rasa | Python | 7,498 | Incremental Training inside Rasa Open Source | **Proposed changes**:
- Closes https://github.com/RasaHQ/rasa/issues/6971
- Adds the ability to load NLU components and Core policies in finetune mode which means they are initialized with a previously trained model and can be further trained on a mix of old and new training data.
Individual PRs:
- Changes to CLI... | 2020-12-09T12:22:45Z | Incremental training
**Description of Problem**:
Once a model is trained it cannot be updated. It is not possible to continue training the model on new data that came in. Instead the model needs to be retrained from scratch, which takes up a lot of time.
**Overview of the Solution**:
It should be possible to load ... | @tabergma how urgent is this one?
@evgeniiaraz We want to tackle this issue this quarter. @dakshvar22 is leading this topic. Why do you ask?
@tabergma I wanted to work on it not to lose shape :) but if it is urgent, I'll pick something non-essential
Based on the discussion in the [document](https://docs.google.com/... | [
{
"body": "**Description of Problem**:\r\nOnce a model is trained it cannot be updated. It is not possible to continue training the model on new data that came in. Instead the model needs to be retrained from scratch, which takes up a lot of time.\r\n\r\n**Overview of the Solution**:\r\nIt should be possible to... | 9bb903342f34fe3176dd020b3f9a1bfb98eb6f39 | {
"head_commit": "903d25acefb18951f125d0b986a36fd6f4518f4d",
"head_commit_message": "Add migration guide for policies (#7522)\n\n* Add migration guide for policies\r\n\r\n* spelling fix\r\n\r\n* changelog",
"patch_to_review": "diff --git a/changelog/6971.feature.md b/changelog/6971.feature.md\nnew file mode 10064... | [
{
"diff_hunk": "@@ -143,8 +149,20 @@ def _load_OOV_params(self) -> None:\n if self.OOV_words:\n self.OOV_words = [w.lower() for w in self.OOV_words]\n \n+ # Additional vocabulary size to be kept reserved\n+ self.additional_vocabulary_size = self.component_config[\n+ ... | bfedf856668c8a313575c1187aaeb9c605e4d79a | diff --git a/changelog/6971.feature.md b/changelog/6971.feature.md
new file mode 100644
index 000000000000..dc1532850d48
--- /dev/null
+++ b/changelog/6971.feature.md
@@ -0,0 +1,14 @@
+Incremental training of models in a pipeline is now supported.
+
+If you have added new NLU training examples or new stories/rules for ... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
RasaHQ__rasa-7716@a11deac | RasaHQ/rasa | Python | 7,716 | Add `split_entities_config` to TEDPolicy | **Proposed changes**:
Closes #7707
**Status (please check what you already did)**:
- [X] added some tests for the functionality
- [x] updated the documentation
- [x] updated the changelog (please check [changelog](https://github.com/RasaHQ/rasa/tree/master/changelog) for instructions)
- [X] reformat files using... | 2021-01-13T09:02:58Z | Add `split_entities_config` to `TEDPolicy` for e2e
**Rasa version**:
2.2.2
**Python version**:
3.7.2
**Operating system** (windows, osx, ...):
OSX
**Issue**:
`TEDPolicy` needs a `split_entities_config` value, to mirror `CRFEntityExtractor` and `DIET`
When we call `convert_predictions_into_entities`, the... | [
{
"body": "\r\n**Rasa version**:\r\n2.2.2\r\n**Python version**:\r\n3.7.2\r\n**Operating system** (windows, osx, ...):\r\nOSX\r\n\r\n**Issue**:\r\n\r\n`TEDPolicy` needs a `split_entities_config` value, to mirror `CRFEntityExtractor` and `DIET`\r\n\r\nWhen we call `convert_predictions_into_entities`, the value o... | 88d97e1d54ce79b9dac2d1091c7db7eb80fc6451 | {
"head_commit": "a11deaccd3bece25e78a214d9c2c1a00988be96e",
"head_commit_message": "Fix typo in docs",
"patch_to_review": "diff --git a/changelog/7707.bugfix.md b/changelog/7707.bugfix.md\nnew file mode 100644\nindex 000000000000..9d81c3ccd708\n--- /dev/null\n+++ b/changelog/7707.bugfix.md\n@@ -0,0 +1,2 @@\n+Add... | [
{
"diff_hunk": "@@ -280,6 +286,16 @@ def _standard_featurizer(max_history: Optional[int] = None) -> TrackerFeaturizer\n SingleStateFeaturizer(), max_history=max_history\n )\n \n+ def init_split_entities(self, split_entities_config):",
"line": null,
"original_line": 289,
"origi... | 4263639ebc9c4623528805d4bdac11f531b29e06 | diff --git a/changelog/7707.bugfix.md b/changelog/7707.bugfix.md
new file mode 100644
index 000000000000..9d81c3ccd708
--- /dev/null
+++ b/changelog/7707.bugfix.md
@@ -0,0 +1,2 @@
+Add the option to configure whether extracted entities should be split by comma (`","`) or not to TEDPolicy. Fixes
+crash when this paramet... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
RasaHQ__rasa-7726@5e04e2e | RasaHQ/rasa | Python | 7,726 | Docker builds - refactor | **Proposed changes**:
- Resolves #7574
- Use Ubuntu 20.04 as a base image
- Build a base image with MITIE
- Tag the latest stable version as `latest`
- Tag Docker images build against the master branch as `master`
- Add options for building Docker images locally to the Makefile
**Status (please check what you ... | 2021-01-14T14:40:14Z | Docker builds - refactor
Proposed changes:
- Switch to Python 3.8 and Ubuntu 20.04 as a base image
- Refactor Dockerfiles in order to manage cache better
- Build a base image with MITIE
- Tag the latest stable version as `latest`
- Tag Docker images build against the master branch as `master`
- Add options for bu... | [
{
"body": "Proposed changes:\r\n- Switch to Python 3.8 and Ubuntu 20.04 as a base image\r\n- Refactor Dockerfiles in order to manage cache better\r\n- Build a base image with MITIE\r\n- Tag the latest stable version as `latest`\r\n- Tag Docker images build against the master branch as `master`\r\n- Add options ... | 7352104604f1a339e64dd4b7a36899f54cf756f1 | {
"head_commit": "5e04e2e5ed51248cb1bfff210b3e76d8e3b56e77",
"head_commit_message": "Add a changelog entry + update the README",
"patch_to_review": "diff --git a/.dockerignore b/.dockerignore\nindex 29e6912ac6c6..8d8690403396 100644\n--- a/.dockerignore\n+++ b/.dockerignore\n@@ -4,3 +4,5 @@ docs\n **/*.pyc\n **/_... | [
{
"diff_hunk": "@@ -0,0 +1,7 @@\n+# The base image used for all images that require a MITIE model\n+FROM alpine:latest\n+\n+# download mitie model\n+RUN mkdir -p /build/data/ && wget -P /build/data/ https://github.com/mit-nlp/MITIE/releases/download/v0.4/MITIE-models-v0.2.tar.bz2 && \\",
"line": null,
"... | 5932c458a802f0da221c729ab5b335e635d096c0 | diff --git a/.dockerignore b/.dockerignore
index 29e6912ac6c6..34d9c074f7df 100644
--- a/.dockerignore
+++ b/.dockerignore
@@ -4,3 +4,7 @@ docs
**/*.pyc
**/__pycache__
!docker/configs
+rasa/tests
+rasa/scripts
+data/
+examples/
diff --git a/.gitattributes b/.gitattributes
index 5378fe089bc2..8f12c43c197e 100644
--- ... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Code Refactoring / Architectural Improvement"
} | |
RasaHQ__rasa-7860@c626809 | RasaHQ/rasa | Python | 7,860 | Mark tests that train a model. | **Proposed changes**:
This PR marks all tests that call either `nlu.train`, `core.train`, `Agent.train`, or `Trainer.train`. This can be directly, or indirectly e.g. through a fixture or http request.
| 2021-02-01T16:41:15Z | Annotate model training in unit tests
**Description of Problem**:
Currently our unit tests take a very long time to run. Part of the cause of this is superfluous or inefficient model training.
**Overview of the Solution**:
We would also like to annotate all tests that train a model.
Training can occur via many di... | Split into annotate, and report tickets.
Should we annotate methods that call a `Policy`/`Component`'s `train` method directly? Or only tests that call `nlu.train` or `core.train`?
- number of tests that call `nlu.train` or `core.train`: 159
- number of tests that call `Policy.train` or `Component.train`: 435
... | [
{
"body": "**Description of Problem**:\r\nCurrently our unit tests take a very long time to run. Part of the cause of this is superfluous or inefficient model training.\r\n\r\n**Overview of the Solution**:\r\nWe would also like to annotate all tests that train a model.\r\nTraining can occur via many different p... | 80202025560dccea9234191ade28e3b9a97cf7f4 | {
"head_commit": "c62680968d253556c8b7b7fdfb0fda94ab26d362",
"head_commit_message": "Merge remote-tracking branch 'origin/main' into 7740-mark_tests_that_train",
"patch_to_review": "diff --git a/tests/core/featurizers/test_single_state_featurizers.py b/tests/core/featurizers/test_single_state_featurizers.py\ninde... | [
{
"diff_hunk": "@@ -385,6 +390,7 @@ async def test_agent_update_model_none_domain(trained_rasa_model: Text):\n assert tracker.events[3].intent[\"name\"] == \"greet\"\n \n \n+@pytest.mark.trains_model",
"line": null,
"original_line": 393,
"original_start_line": null,
"path": "tests/core/test_... | c31cdd1e7d54e9d2a712826b1da7108e9b70145c | diff --git a/.github/workflows/continous-integration.yml b/.github/workflows/continous-integration.yml
index 9780934f0884..d35f8602e9ef 100644
--- a/.github/workflows/continous-integration.yml
+++ b/.github/workflows/continous-integration.yml
@@ -194,6 +194,7 @@ jobs:
matrix:
os: [ubuntu-latest, windows... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Test Suite / CI Enhancements"
} |
RasaHQ__rasa-7382@c77eb04 | RasaHQ/rasa | Python | 7,382 | Fix e2e training edge cases | **Proposed changes**:
- Fixes are variety of training scenarios outlined in #7129
- fixes https://github.com/RasaHQ/rasa/issues/7360
**Status (please check what you already did)**:
- [x] added some tests for the functionality
- [ ] updated the documentation
- [ ] updated the changelog (please check [changelog]... | 2020-11-26T13:50:07Z | make sure that rasa train commands run gracefully with e2e
With e2e we linked training `rasa.nlu` and `rasa.core`. Therefore, we need to make sure that `rasa train`, `rasa train nlu` and `rasa train core` run perfectly
Potential pitfalls (just smth came to my mind, there might. be more edge cases):
- [ ] `rasa trai... | @Ghostvv Somebody mentioned that training on `e2e` is currently broken - does that block implementing a solution or can we move forward with it?
the training on e2e should work now
Is the `e2ebot` example bot meant to be in a working state?
I get this error when using it:
```
2020-11-19 14:44:03 DEBUG rasa.core... | [
{
"body": "With e2e we linked training `rasa.nlu` and `rasa.core`. Therefore, we need to make sure that `rasa train`, `rasa train nlu` and `rasa train core` run perfectly\r\n\r\nPotential pitfalls (just smth came to my mind, there might. be more edge cases):\r\n- [ ] `rasa train` was called, nlu data didn't cha... | cf1b8950a98a2710a2d69ab4f7ecf5cb2d76b7d2 | {
"head_commit": "c77eb042f4fe1a4dc03927c1a449f3aefc6dd5b1",
"head_commit_message": "fix e2e training edge cases",
"patch_to_review": "diff --git a/data/test_yaml_stories/stories_e2e.yml b/data/test_yaml_stories/stories_e2e.yml\nnew file mode 100644\nindex 000000000000..b20be88ed78d\n--- /dev/null\n+++ b/data/tes... | [
{
"diff_hunk": "@@ -317,9 +317,16 @@ def _parse_raw_user_utterance(self, step: Dict[Text, Any]) -> Optional[UserUtter\n return UserUttered(None, intent, entities)\n \n def _parse_user_message(self, step: Dict[Text, Any]) -> None:\n- is_end_to_end_utterance = KEY_USER_INTENT not in step\n+ ... | 999c2fe15d76b2dafee6125d984dd52c290490eb | diff --git a/data/test_yaml_stories/stories_e2e.yml b/data/test_yaml_stories/stories_e2e.yml
new file mode 100644
index 000000000000..b20be88ed78d
--- /dev/null
+++ b/data/test_yaml_stories/stories_e2e.yml
@@ -0,0 +1,30 @@
+version: "2.0"
+
+stories:
+- story: happy path (intent to action)
+ steps:
+ - intent: greet
... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
RasaHQ__rasa-7995@069d3a5 | RasaHQ/rasa | Python | 7,995 | Rasa test evaluates TED e2e entity extraction | **Proposed changes**:
Fixes: #7578
Adds functionality to `rasa test` to evaluate the entities TED extracts.
**Status (please check what you already did)**:
- [x] added some tests for the functionality
- [ ] updated the documentation
- [x] updated the changelog (please check [changelog](https://github.com/RasaH... | 2021-02-19T10:13:50Z | Enable rasa test usage for e2e
Users need `rasa test` to validate and inform their decisions to update their training data. Without it, they cannot have a functioning live project using e2e, which in turns means that we wouldn't be able to get valuable feedback on e2e.
With `e2e` TED can extract entities using data ... | [
{
"body": "Users need `rasa test` to validate and inform their decisions to update their training data. Without it, they cannot have a functioning live project using e2e, which in turns means that we wouldn't be able to get valuable feedback on e2e.\r\n\r\nWith `e2e` TED can extract entities using data in stori... | 5af7175d0cfb6910f5fa6917e5f5c64de850bb79 | {
"head_commit": "069d3a5400867bbc8fea863601444bca0da6fb55",
"head_commit_message": "rasa test e2e evluates TED entity extraction",
"patch_to_review": "diff --git a/changelog/7578.improvement.md b/changelog/7578.improvement.md\nnew file mode 100644\nindex 000000000000..1ac023a1a660\n--- /dev/null\n+++ b/changelog... | [
{
"diff_hunk": "@@ -481,13 +489,38 @@ def emulate_loop_rejection(partial_tracker: DialogueStateTracker) -> None:\n partial_tracker.update(ActionExecutionRejected(rejected_action_name))\n \n \n+def _get_processor_entity_evaluation_result(",
"line": null,
"original_line": 492,
"original_start_line... | 490e07b0ed25c21f60a089824f5f90b8c73b46fa | diff --git a/changelog/7578.improvement.md b/changelog/7578.improvement.md
new file mode 100644
index 000000000000..5cbaf03e51d9
--- /dev/null
+++ b/changelog/7578.improvement.md
@@ -0,0 +1 @@
+When `TED` is configured to extract entities `rasa test` now evaluates them against the labels in the test stories. Results ar... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
Subsets and Splits
Review Test Instances
Retrieves basic metadata about code review instances but doesn't provide any analytical insights or patterns beyond raw data access.