instance_id stringlengths 21 53 | repo stringclasses 188
values | language stringclasses 1
value | pull_number int64 20 148k | title stringlengths 6 144 | body stringlengths 0 83.4k | created_at stringdate 2015-09-25 03:17:17 2025-07-10 16:50:35 | problem_statement stringlengths 188 240k | hints_text stringlengths 0 145k | resolved_issues listlengths 1 6 | base_commit stringlengths 40 40 | commit_to_review dict | reference_review_comments listlengths 1 62 | merged_commit stringlengths 40 40 | merged_patch stringlengths 297 9.87M | metadata dict |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
RasaHQ__rasa-7134@949bd8d | RasaHQ/rasa | Python | 7,134 | warn for invalid keys for components | **Proposed changes**:
- Warn when a user provides a key for a component that is not part of the component's allowed keys
- closes #6966
**Status (please check what you already did)**:
- [x] added some tests for the functionality
- [ ] updated the documentation
- [x] updated the changelog (please check [changelo... | 2020-10-29T15:06:45Z | Warn for invalid keys for classifiers
**Rasa version**: 2.0.0
**Issue**:
If you pass an invalid key to a classifier no warning or error is thrown during training
**Command or request that led to lack of error**:
```
rasa train
```
**Content of configuration file (config.yml)** (if relevant):
```yml
p... | Here's a similar issue with responses. `button_type` is not valid at this location, but `validate` and `train` don't throw an error.
```
utter_ask_feedback:
- buttons:
- button_type: inline
- payload: /feedback{"feedback_value":"positive"}
title: 👍
- payload: /feedback{"feedback_value":"... | [
{
"body": "\r\n**Rasa version**: 2.0.0\r\n\r\n**Issue**:\r\n\r\nIf you pass an invalid key to a classifier no warning or error is thrown during training\r\n\r\n**Command or request that led to lack of error**:\r\n```\r\nrasa train\r\n```\r\n\r\n**Content of configuration file (config.yml)** (if relevant):\r\n``... | 26884fe896956400c95c141012c5649a79998029 | {
"head_commit": "949bd8d218504cc41098262d2f43aa0a107f246a",
"head_commit_message": "remove blank lines after docstrings",
"patch_to_review": "diff --git a/changelog/6966.improvement.md b/changelog/6966.improvement.md\nnew file mode 100644\nindex 000000000000..fb0ebd4b58c0\n--- /dev/null\n+++ b/changelog/6966.imp... | [
{
"diff_hunk": "@@ -161,13 +161,13 @@ def _build_pipeline(\n self, cfg: RasaNLUModelConfig, component_builder: ComponentBuilder\n ) -> List[Component]:\n \"\"\"Transform the passed names of the pipeline components into classes.\"\"\"\n-\n pipeline = []\n \n # Transform the pa... | 3c0db6598fe658ed1e330bd591a7556a6ff288d0 | diff --git a/changelog/6966.improvement.md b/changelog/6966.improvement.md
new file mode 100644
index 000000000000..6f3a38eb70d8
--- /dev/null
+++ b/changelog/6966.improvement.md
@@ -0,0 +1 @@
+Added warning for when an option is provided for a [component](components.mdx) that is not listed as a key in the defaults for... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
RasaHQ__rasa-6882@d7cce9b | RasaHQ/rasa | Python | 6,882 | Update migration guide | **Proposed changes**:
- Fixes https://github.com/RasaHQ/rasa/issues/6863
- Documents https://github.com/RasaHQ/rasa/pull/6854
**Status (please check what you already did)**:
- [ ] added some tests for the functionality
- [x] updated the documentation
- [ ] updated the changelog (please check [changelog](https:/... | 2020-10-02T08:25:33Z | Update migration guide for migrating to rulepolicy
When collecitng user feedback about 2.0, users pointed out some missing information in the migration guide. We should address these comments:
- [x] The migration guide doesn't tell users to remove old policy and replace with RulePolicy (e.g. when migrating from Map... | [
{
"body": "When collecitng user feedback about 2.0, users pointed out some missing information in the migration guide. We should address these comments: \r\n\r\n- [x] The migration guide doesn't tell users to remove old policy and replace with RulePolicy (e.g. when migrating from MappingPolicy to RulePolicy. \r... | fde5cdc8a82ba78426cc15a443e6620f398f6766 | {
"head_commit": "d7cce9bd2f4584624c94111cc5cf306dca8c8e5a",
"head_commit_message": "give an example of what an updated domain looks like",
"patch_to_review": "diff --git a/docs/docs/migration-guide.mdx b/docs/docs/migration-guide.mdx\nindex 9ae0a6fe258d..fd9296b19f28 100644\n--- a/docs/docs/migration-guide.mdx\n... | [
{
"diff_hunk": "@@ -57,34 +57,66 @@ deprecated:\n - [Two-Stage-Fallback Policy](./policies.mdx#two-stage-fallback-policy)\n - [Form Policy](./policies.mdx#form-policy)\n \n-#### Migrating from the Mapping Policy\n+:::tip Automatic migration\n+Rasa Open Source can take care of automatically migrating the Mapping... | bed159262428f3cd28725481c7c63e316022ab72 | diff --git a/docs/docs/migration-guide.mdx b/docs/docs/migration-guide.mdx
index 9ae0a6fe258d..9cafb401706b 100644
--- a/docs/docs/migration-guide.mdx
+++ b/docs/docs/migration-guide.mdx
@@ -47,7 +47,7 @@ Please note, that it's not currently possible to convert stories that contain fo
automatically, these stories will... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "Documentation Updates"
} | |
RasaHQ__rasa-6979@dce70bc | RasaHQ/rasa | Python | 6,979 | Return all sessions for GET /story | **Proposed changes**:
- fixes #6860
**Status (please check what you already did)**:
- [x] added some tests for the functionality
- [x] updated the documentation
- [x] updated the changelog (please check [changelog](https://github.com/RasaHQ/rasa/tree/master/changelog) for instructions)
- [x] reformat files usi... | 2020-10-09T10:33:19Z | /story endpoint does not fetch full tracker
**Issue**: The `GET /story` endpoint currently only fetches the conversation after the last session start. The endpoint should
1. fetch the story for the entire tracker
2. not cause a new session start sequence if the session expiration time has elapsed (this endpoint shoul... | [
{
"body": "**Issue**: The `GET /story` endpoint currently only fetches the conversation after the last session start. The endpoint should\r\n1. fetch the story for the entire tracker\r\n2. not cause a new session start sequence if the session expiration time has elapsed (this endpoint should not modify the trac... | 1f9b79e21a97badb00c88d4b813f69cc25bd462c | {
"head_commit": "dce70bc2b56fe23d1ab7119d20c305b7fd00e60a",
"head_commit_message": "fix deepsource checks",
"patch_to_review": "diff --git a/changelog/6860.improvement.md b/changelog/6860.improvement.md\nnew file mode 100644\nindex 000000000000..ac2af3b64a8c\n--- /dev/null\n+++ b/changelog/6860.improvement.md\n@... | [
{
"diff_hunk": "@@ -213,10 +215,39 @@ def get_tracker(self, conversation_id: Text) -> Optional[DialogueStateTracker]:\n conversation.\n \"\"\"\n conversation_id = conversation_id or DEFAULT_SENDER_ID\n+\n return self.tracker_store.get_or_create_tracker(\n conversa... | 9c26900a2bbec4a180baaac3c41732b402d36fc9 | diff --git a/changelog/6860.improvement.md b/changelog/6860.improvement.md
new file mode 100644
index 000000000000..d619b3b8a296
--- /dev/null
+++ b/changelog/6860.improvement.md
@@ -0,0 +1,19 @@
+Fetching test stories from the HTTP API endpoint
+`GET /conversations/<conversation_id>/story` no longer triggers an updat... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} | |
RasaHQ__rasa-7701@75516ce | RasaHQ/rasa | Python | 7,701 | hide only rule dialogue turns | **Proposed changes**:
- closes https://github.com/RasaHQ/rasa/issues/7226
originally I had 2 ideas: operate on states or use forgetting functionality in tracker.applied_events through specialized events. In the end I used the mix of these approaches.
**Status (please check what you already did)**:
- [x] added s... | 2021-01-08T13:09:23Z | Unfeaturize rule snippets for inference through TED
**Description of Problem**:
Currently, during inference to predict the next bot action, the first check is to see if a rule can be triggered. If not, then the prediction is done through ML policies. However, this can potentially cause a problem because these rule sni... | I just understood, you cannot do it in `tracker.applied_events`, because rule policy should see this events. Rather, you should create a temporary tracker inside predict ted, and rule policy should "learn" whether this predicted action should be unfeaturized or not. This information (rather logical not) can be extracte... | [
{
"body": "**Description of Problem**:\r\nCurrently, during inference to predict the next bot action, the first check is to see if a rule can be triggered. If not, then the prediction is done through ML policies. However, this can potentially cause a problem because these rule snippets may not be part of any st... | 941a2a9c3af2885493a778519695eb88361b7323 | {
"head_commit": "75516ce09bcb69753696b3de9d851cbcc416bba7",
"head_commit_message": "create featurize for prediction helpers to automatically set for_only_ml_policy",
"patch_to_review": "diff --git a/changelog/7701.improvement.md b/changelog/7701.improvement.md\nnew file mode 100644\nindex 000000000000..13e4d8528... | [
{
"diff_hunk": "@@ -621,11 +698,43 @@ def train(\n trackers_as_states, trackers_as_actions\n )\n \n+ def train(\n+ self,\n+ training_trackers: List[TrackerWithCachedStates],\n+ domain: Domain,\n+ interpreter: NaturalLanguageInterpreter,\n+ **kwargs: Any,... | 67502b69db0a30067c3e186b1c3fd321793b22f9 | diff --git a/changelog/7701.improvement.md b/changelog/7701.improvement.md
new file mode 100644
index 000000000000..357e3e54ffde
--- /dev/null
+++ b/changelog/7701.improvement.md
@@ -0,0 +1,10 @@
+Hide dialogue turns predicted by `RulePolicy` in the tracker states
+for ML-only policies like `TEDPolicy`
+if those dialog... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Code Refactoring / Architectural Improvement"
} |
RasaHQ__rasa-6859@c46e3dd | RasaHQ/rasa | Python | 6,859 | Update outdated docs content | **Proposed changes**:
- Update any outdated content in the docs
- closes https://github.com/RasaHQ/rasa/issues/6775
**Status (please check what you already did)**:
- [ ] added some tests for the functionality
- [x] updated the documentation
- [ ] updated the changelog (please check [changelog](https://github.co... | 2020-09-30T19:10:45Z | finish old content check in docs
- [x] Nlu data format
- [x] responses?
- [x] domain.mdx (There are outstanding TODOs here, and the unfeaturized_slot PR also updates this page)
- [x] event-brokers.mdx
- [x] fallback-handoff.mdx
- [x] forms.mdx (have looked through it, changes also coming in from unfeaturized_slot... | @akelad update this
@melindaloubser1 @b-quachtran, if you have some time, could you take on a few of these? The idea is just to go through the page and see if there's any outdated information on them, it's entirely possible that a lot of them don't need any edits.
Sure, I'm already working on NLU data format, and I'll... | [
{
"body": "- [x] Nlu data format \r\n- [x] responses?\r\n- [x] domain.mdx (There are outstanding TODOs here, and the unfeaturized_slot PR also updates this page)\r\n- [x] event-brokers.mdx\r\n- [x] fallback-handoff.mdx\r\n- [x] forms.mdx (have looked through it, changes also coming in from unfeaturized_slot PR)... | 20df6655f813ecef37d2f6268597faece5407b05 | {
"head_commit": "c46e3ddcae489b3bda78f35f9638af7a5d624680",
"head_commit_message": "Apply suggestions from code review\n\nCo-authored-by: Akela Drissner-Schmid <32450038+akelad@users.noreply.github.com>",
"patch_to_review": "diff --git a/docs/docs/event-brokers.mdx b/docs/docs/event-brokers.mdx\nindex 41cb053436... | [
{
"diff_hunk": "@@ -2,12 +2,12 @@\n id: forms\n sidebar_label: Forms\n title: Forms\n-description: Follow a rule-based process of information gathering using FormActions in open source bot framework Rasa.\n----\n+description: Follow a rule-based process of information gathering using forms in open source bot fr... | 129ace47a3e488f1d06391063f12a0ea521843fb | diff --git a/docs/docs/event-brokers.mdx b/docs/docs/event-brokers.mdx
index 41cb05343627..1cb1b51474e3 100644
--- a/docs/docs/event-brokers.mdx
+++ b/docs/docs/event-brokers.mdx
@@ -7,7 +7,7 @@ description: Find out how open source chatbot framework Rasa allows you to strea
An event broker allows you to connect you... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "Documentation Updates"
} |
RasaHQ__rasa-6931@3e72231 | RasaHQ/rasa | Python | 6,931 | Do not filter training data in model.py but on component side | **Proposed changes**:
closes #6919
**Status (please check what you already did)**:
- [ ] added some tests for the functionality
- [ ] updated the documentation
- [x] updated the changelog (please check [changelog](https://github.com/RasaHQ/rasa/tree/master/changelog) for instructions)
- [x] reformat files usin... | 2020-10-06T11:14:07Z | sklearn.exceptions.NotFittedError: Vocabulary not fitted or provided
**Rasa version**: 2.0.0rc4
**Issue**:
Core training fails on the demo bot (`rasa init`) after changing the config to the one below.
**Error (including full traceback)**:
```
(rasa) ➜ ~/Repositories/rasa/demo_bot git:(core-entity-roles-groups... | If you move the `RegexFeaturizer` after the `CountVectorsFeaturizer`s, core training works.
> If you move the `RegexFeaturizer` after the `CountVectorsFeaturizer`s, core training works.
You mean `RegexEntityExtractor` right?
Yes, if you move the `RegexEntityExtractor` after the `CountVectorsFeaturizers`, core traini... | [
{
"body": "**Rasa version**: 2.0.0rc4\r\n\r\n**Issue**:\r\nCore training fails on the demo bot (`rasa init`) after changing the config to the one below.\r\n\r\n**Error (including full traceback)**:\r\n```\r\n(rasa) ➜ ~/Repositories/rasa/demo_bot git:(core-entity-roles-groups) ✔ rasa train\r\nThe configuration ... | 6764365ed8f1104d938d77c489f5ea9fcfe00e6f | {
"head_commit": "3e72231709aae4cb470f4a8b4875d199043eb132",
"head_commit_message": "formatting",
"patch_to_review": "diff --git a/changelog/6919.bugfix.md b/changelog/6919.bugfix.md\nnew file mode 100644\nindex 000000000000..d5b2e5d02a0b\n--- /dev/null\n+++ b/changelog/6919.bugfix.md\n@@ -0,0 +1 @@\n+Do not filt... | [
{
"diff_hunk": "@@ -321,6 +321,20 @@ def _combine_features(\n \n return combined_features\n \n+ def is_e2e_message(self) -> bool:",
"line": null,
"original_line": 324,
"original_start_line": null,
"path": "rasa/shared/nlu/training_data/message.py",
"start_line": null,
"text": ... | 86b035b22afea5e483bef7fe17c92528d4ac3958 | diff --git a/changelog/6919.bugfix.md b/changelog/6919.bugfix.md
new file mode 100644
index 000000000000..d5b2e5d02a0b
--- /dev/null
+++ b/changelog/6919.bugfix.md
@@ -0,0 +1 @@
+Do not filter training data in model.py but on component side.
diff --git a/rasa/nlu/classifiers/diet_classifier.py b/rasa/nlu/classifiers/di... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
RasaHQ__rasa-6789@ab47c23 | RasaHQ/rasa | Python | 6,789 | Updated Convo Pattern & Form Docs to Use Example Bots | **Proposed changes**:
- Updated Convo Pattern & Form Docs to use example bots
- Updated concert bot to include convo patterns doc use case
**Status (please check what you already did)**:
- [ ] added some tests for the functionality
- [x] updated the documentation
- [ ] updated the changelog (please check [chang... | 2020-09-24T23:01:44Z | Revisit example bots before RC
Before the RC, we need to make sure that all the example bots are:
- [x] written as rules/stories according to our docs recommendations
- [x] used as examples in our documentation. if they aren't, we should consider getting rid of them or adapt them to what we describe in the docs | @melindaloubser1 can you take this one on?
Yes | [
{
"body": "Before the RC, we need to make sure that all the example bots are:\r\n- [x] written as rules/stories according to our docs recommendations\r\n- [x] used as examples in our documentation. if they aren't, we should consider getting rid of them or adapt them to what we describe in the docs",
"number... | 92c16c73bb41cdbb9ddeaf5e8d0257525d093ada | {
"head_commit": "ab47c231787b86b5e2af63cafb8dac014602a363",
"head_commit_message": "titles for code blocks",
"patch_to_review": "diff --git a/docs/docs/business-logic.mdx b/docs/docs/business-logic.mdx\nindex 56aaf77bd1bc..0c85a46f6369 100644\n--- a/docs/docs/business-logic.mdx\n+++ b/docs/docs/business-logic.md... | [
{
"diff_hunk": "@@ -38,3 +38,20 @@ nlu:\n - compare reviews\n - show me a comparison of the reviews\n \n+ - intent: how_to_get_started\n+ examples: |\n+ - how do I get started\n+ - what can I do\n+ - start\n+\n+ - intent: affirm\n+ examples: |\n+ - yes\n+ - yeah\n+ ... | b77bab1ccc1a52018e08c83e67652dcf618d71d8 | diff --git a/docs/docs/business-logic.mdx b/docs/docs/business-logic.mdx
index 56aaf77bd1bc..0c85a46f6369 100644
--- a/docs/docs/business-logic.mdx
+++ b/docs/docs/business-logic.mdx
@@ -25,12 +25,9 @@ about the user's preferences to find them a suitable restaurant:
</Chat>
-This page is a guide on handling the bu... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Code Refactoring / Architectural Improvement"
} |
RasaHQ__rasa-6746@26fc7f3 | RasaHQ/rasa | Python | 6,746 | Updated Rasa example bots for 2.0 | **Proposed changes**:
- Updated Rasa example bots for 2.0
**Status (please check what you already did)**:
- [ ] added some tests for the functionality
- [ ] updated the documentation
- [ ] updated the changelog (please check [changelog](https://github.com/RasaHQ/rasa/tree/master/changelog) for instructions)
- [... | 2020-09-22T23:13:29Z | Revisit example bots before RC
Before the RC, we need to make sure that all the example bots are:
- [x] written as rules/stories according to our docs recommendations
- [x] used as examples in our documentation. if they aren't, we should consider getting rid of them or adapt them to what we describe in the docs | @melindaloubser1 can you take this one on?
Yes
@b-quachtran did we check if e.g. the `rules` example bot is actually used anywhere?
@akelad The rules doc has the example
`- intent: greet`
`- action: utter_greet`
that's in the rules example bot, but other than that no.
does it refer to the rules bot example? I... | [
{
"body": "Before the RC, we need to make sure that all the example bots are:\r\n- [x] written as rules/stories according to our docs recommendations\r\n- [x] used as examples in our documentation. if they aren't, we should consider getting rid of them or adapt them to what we describe in the docs",
"number... | 2eddc68fd35a1eb51021bc122c374650b2f08492 | {
"head_commit": "26fc7f33b0a1c646c01a49303e460ba4c901a98d",
"head_commit_message": "Merge branch '2.0.x' into rc_example_updates",
"patch_to_review": "diff --git a/examples/concertbot/data/nlu.yaml b/examples/concertbot/data/nlu.yml\nsimilarity index 100%\nrename from examples/concertbot/data/nlu.yaml\nrename to... | [
{
"diff_hunk": "@@ -0,0 +1,8 @@\n+version: \"2.0\"\n+stories:\n+ - story: Happy path\n+ steps:\n+ - intent: greet\n+ - action: utter_what_can_do\n+ - intent: ask_remind_call\n+ - action: action_set_reminder",
"line": null,
"original_line": 8,
"original_start_line": null,
"path": ... | 9bea362b859c4cda524b4ad8cd96161973f70c54 | diff --git a/examples/concertbot/data/nlu.yaml b/examples/concertbot/data/nlu.yml
similarity index 100%
rename from examples/concertbot/data/nlu.yaml
rename to examples/concertbot/data/nlu.yml
diff --git a/examples/concertbot/data/rules.yaml b/examples/concertbot/data/rules.yml
similarity index 100%
rename from example... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Code Refactoring / Architectural Improvement"
} |
RasaHQ__rasa-6699@bf1602d | RasaHQ/rasa | Python | 6,699 | Model regression tests - show last performance on master | Solves #6393 | 2020-09-17T07:44:38Z | Model regression tests: Show last performance on master
**Description of Problem**:
Currently the model regression tests displays the performance of a PR on the defined set of configurations and datasets. To validate if the PR improves/degrades the performance, the user needs to know the last recorded performance of t... | [
{
"body": "**Description of Problem**:\r\nCurrently the model regression tests displays the performance of a PR on the defined set of configurations and datasets. To validate if the PR improves/degrades the performance, the user needs to know the last recorded performance of the scheduled run on the master bran... | 2bafa80deb7d3b43dbf1e7bc94eb6ba7a36d3bba | {
"head_commit": "bf1602d57f59a5e5e7e94be3f27562d31e98f1b7",
"head_commit_message": "Revert changes related to tests",
"patch_to_review": "diff --git a/.github/templates/model_regression_test_results.tmpl b/.github/templates/model_regression_test_results.tmpl\nindex 3fca8c42b8ff..0f3f8ecac98c 100644\n--- a/.githu... | [
{
"diff_hunk": "@@ -460,6 +460,22 @@ jobs:\n - name: Checkout\n uses: actions/checkout@v2\n \n+ - name: Download an artifact with the results for the schedule version\n+ run: |\n+ # Schedule workflows ID - 1498790",
"line": null,
"original_line": 465,
"original_sta... | 8925945dcff35137ed3eadb2bbcfe34fe4ac3c5d | diff --git a/.github/templates/model_regression_test_results.tmpl b/.github/templates/model_regression_test_results.tmpl
index 3fca8c42b8ff..0f3f8ecac98c 100644
--- a/.github/templates/model_regression_test_results.tmpl
+++ b/.github/templates/model_regression_test_results.tmpl
@@ -5,7 +5,9 @@ as an artifact in the mod... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Test Suite / CI Enhancements"
} | |
RasaHQ__rasa-6822@6d3fc21 | RasaHQ/rasa | Python | 6,822 | Docs accessibility | **Proposed changes**:
- close https://github.com/RasaHQ/rasa/issues/6765
**Status (please check what you already did)**:
- [ ] added some tests for the functionality
- [x] updated the documentation
- [ ] updated the changelog (please check [changelog](https://github.com/RasaHQ/rasa/tree/master/changelog) for ins... | 2020-09-28T17:05:55Z | improve accessibility in docs
- [x] make sure that every image has a descriptive caption and descriptive alt text
- [x] check for non-descriptive link texts, like `here` and `this page` and replace with the name of what is being linked to
- [ ] check for pages where lists/bullets are being used where headers would b... | [
{
"body": "- [x] make sure that every image has a descriptive caption and descriptive alt text \r\n- [x] check for non-descriptive link texts, like `here` and `this page` and replace with the name of what is being linked to\r\n- [ ] check for pages where lists/bullets are being used where headers would be more ... | 84a37f00578524a6b6c31a5a38cddaa2ff322052 | {
"head_commit": "6d3fc217d9593ad5c4b0e3124514f737e743a486",
"head_commit_message": "update pages that shouldnt be all lists",
"patch_to_review": "diff --git a/CHANGELOG.mdx b/CHANGELOG.mdx\nindex ee08f4481ade..d84ea06c0168 100644\n--- a/CHANGELOG.mdx\n+++ b/CHANGELOG.mdx\n@@ -140,7 +140,7 @@ https://github.com/R... | [
{
"diff_hunk": "@@ -13,27 +13,22 @@ responds to a message:\n \n \n \n-<img alt=\"image\" src={useBaseUrl(\"/img/rasa-message-processing.png\")} />\n+<img caption=\"Rasa Open Source architecture\" src={useBaseUrl(\"/img/rasa-message-processing.png\")}",
"line": null,
"original_line": 16,
"original_st... | 3977999af5c58b1b837d4c4674b2f383369f16d4 | diff --git a/CHANGELOG.mdx b/CHANGELOG.mdx
index 227b96eee340..9f729b9519b3 100644
--- a/CHANGELOG.mdx
+++ b/CHANGELOG.mdx
@@ -140,7 +140,7 @@ https://github.com/RasaHQ/rasa/tree/master/changelog/ . -->
* [#5521](https://github.com/rasahq/rasa/issues/5521): Responses used in ResponseSelector now support new lines wi... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Documentation Updates"
} | |
RasaHQ__rasa-6567@bc40018 | RasaHQ/rasa | Python | 6,567 | Better handling of sequences longer than maximum sequence length for BERT style models | **Proposed changes**:
- Closes https://github.com/RasaHQ/rasa/issues/6222
**Status (please check what you already did)**:
- [x] added some tests for the functionality
- [ ] updated the documentation
- [x] updated the changelog (please check [changelog](https://github.com/RasaHQ/rasa/tree/master/changelog) for in... | 2020-09-03T17:49:42Z | Problem with integrating BERT (tensorflow.python.framework.errors_impl.InvalidArgumentError: indices[0,512] = 512 is not in [0, 512))
**Rasa version**: 1.10.7 (also tried with 1.8.3)
**Python version**: 3.7
**Operating system** (windows, osx, ...): Linux and Windows
**Issue**:
I have a problem with integratin... | Thanks for raising this issue, @tabergma will get back to you about it soon✨
###### Please also check out the [docs](https://rasa.com/docs/) and the [forum](https://forum.rasa.com/) in case your issue was raised there too 🤗
@MajaRolevski Thanks for raising the issue. How small is your "very small dataset"? And how do... | [
{
"body": "**Rasa version**: 1.10.7 (also tried with 1.8.3)\r\n\r\n**Python version**: 3.7\r\n\r\n**Operating system** (windows, osx, ...): Linux and Windows\r\n\r\n**Issue**:\r\nI have a problem with integrating BERT into the configuration of my model. Namely, at the very beginning of training it gives the err... | 5d244c3d13aea98d35e0b41fc2f2185dae100a10 | {
"head_commit": "bc40018cd7d4931719e6fee3b7c41801fb227622",
"head_commit_message": "more tests",
"patch_to_review": "diff --git a/changelog/6222.bugfix.md b/changelog/6222.bugfix.md\nnew file mode 100644\nindex 000000000000..1ba2df6e9dc7\n--- /dev/null\n+++ b/changelog/6222.bugfix.md\n@@ -0,0 +1,5 @@\n+Better ha... | [
{
"diff_hunk": "@@ -81,3 +82,45 @@ def test_input_padding(\n if padding_added:\n original_length = len(token_ids[0])\n assert np.all(np.array(padded_input[0][original_length:]) == 0)\n+\n+\n+@pytest.mark.parametrize(\n+ \"sequence_length, model_name, should_overflow\",\n+ [(1000, \"ber... | 8a81b4d9548902050f087d81ace240890163d72a | diff --git a/changelog/6222.bugfix.md b/changelog/6222.bugfix.md
new file mode 100644
index 000000000000..1ba2df6e9dc7
--- /dev/null
+++ b/changelog/6222.bugfix.md
@@ -0,0 +1,5 @@
+Better handling of input sequences longer than the maximum sequence length that the `HFTransformersNLP` models can handle.
+
+During traini... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
RasaHQ__rasa-6589@1f669d4 | RasaHQ/rasa | Python | 6,589 | Add option 'use_lemma' to CountVectorsFeaturizer | **Proposed changes**:
closes #6536
**Status (please check what you already did)**:
- [x] added some tests for the functionality
- [x] updated the documentation
- [x] updated the changelog (please check [changelog](https://github.com/RasaHQ/rasa/tree/master/changelog) for instructions)
- [x] reformat files us... | 2020-09-07T14:13:52Z | Lemmatization and CountVectorFeaturizers
**Rasa version**:
1.8 onwards
**Python version**:
3.6 or 3.7
**Operating system** (windows, osx, ...):
All
**Issue**:
Currently if you use spaCy components in your pipeline then the behaviour of the CountVectorFeaturizer changes. Currently we use the `lem... | A related discussion needs to take place here too. Is this how we want to deal with lemmatisation in Rasa?
My impression is that we've always used the spaCy `lemma` features inside of the CountVectorFeaturizer and never really considered how we think about lemmatisation in general. The reason I want to bring it up ... | [
{
"body": "**Rasa version**:\r\n\r\n1.8 onwards \r\n\r\n**Python version**:\r\n\r\n3.6 or 3.7\r\n\r\n**Operating system** (windows, osx, ...):\r\n\r\nAll \r\n\r\n**Issue**:\r\n\r\nCurrently if you use spaCy components in your pipeline then the behaviour of the CountVectorFeaturizer changes. Currently we use th... | 44d288ce61334c214d52a7f9632bcb1c70c4d5ec | {
"head_commit": "1f669d4a1d6e01f34120470d5949118affbaf140",
"head_commit_message": "update docs",
"patch_to_review": "diff --git a/changelog/6536.feature.md b/changelog/6536.feature.md\nnew file mode 100644\nindex 000000000000..db96b0742f25\n--- /dev/null\n+++ b/changelog/6536.feature.md\n@@ -0,0 +1,4 @@\n+Add o... | [
{
"diff_hunk": "@@ -397,3 +400,46 @@ def test_count_vectors_featurizer_train():\n assert sen_vec is None\n assert (1, 1) == seq_vec.shape\n assert np.all(seq_vec.toarray()[0] == np.array([1]))\n+\n+\n+@pytest.mark.parametrize(\n+ \"sentence, sequence_features, sentence_features, use_lemma\",\n+ ... | 973b07dd729e8afb830fa9cb60468d966983c54f | diff --git a/changelog/6536.feature.md b/changelog/6536.feature.md
new file mode 100644
index 000000000000..db96b0742f25
--- /dev/null
+++ b/changelog/6536.feature.md
@@ -0,0 +1,4 @@
+Add option `use_lemma` to `CountVectorsFeaturizer`. By default it is set to `True`.
+
+`use_lemma` indicates whether the featurizer shou... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
RasaHQ__rasa-6485@69e6903 | RasaHQ/rasa | Python | 6,485 | only suggest config that is required when doing 'rasa train nlu/core' | Fix #6456
**Proposed changes**:
- When running `rasa train nlu`, only `pipeline` is suggested and not `policies`.
- When running `rasa train core`, only `policies` is suggested and not `pipeline`.
- As a side effect, for any custom importer there is now also the option to take an argument `nlu_or_core`. This arg... | 2020-08-25T12:42:07Z | autoconfig chooses policies when training nlu only
When training nlu:
```
new ❯ rasa train nlu
The configuration for policies was chosen automatically. It was written into the config file at 'config.yml'.
```
I wouldn't expect it to choose policies for me because I am not using them in my model. My expectations f... | [
{
"body": "When training nlu:\r\n```\r\nnew ❯ rasa train nlu\r\nThe configuration for policies was chosen automatically. It was written into the config file at 'config.yml'.\r\n```\r\nI wouldn't expect it to choose policies for me because I am not using them in my model. My expectations for the opposite would b... | 3fca2f1ecdadc8c9f555a339eef2b11ce526e93b | {
"head_commit": "69e6903a128650b39741d1b78fd78d94cbe38942",
"head_commit_message": "updated test code style",
"patch_to_review": "diff --git a/data/test_config/config_empty_en_after_dumping_core.yml b/data/test_config/config_empty_en_after_dumping_core.yml\nnew file mode 100644\nindex 000000000000..57a552f7b954\... | [
{
"diff_hunk": "@@ -161,9 +167,12 @@ def _importer_from_dict(\n logging.warning(f\"Importer '{module_path}' not found.\")\n return None\n \n+ importer_config[\"training_type\"] = training_type",
"line": null,
"original_line": 170,
"original_start_line": null,
... | 934474c4f8239fe65c997f4df37d7d51989a9749 | diff --git a/data/test_config/config_empty_en_after_dumping_core.yml b/data/test_config/config_empty_en_after_dumping_core.yml
new file mode 100644
index 000000000000..57a552f7b954
--- /dev/null
+++ b/data/test_config/config_empty_en_after_dumping_core.yml
@@ -0,0 +1,11 @@
+language: en
+pipeline:
+policies:
+# # No co... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
RasaHQ__rasa-6803@7260102 | RasaHQ/rasa | Python | 6,803 | [bugfix][WIP] Fix the bug of language supporting detection function of component | **Proposed changes**:
- `supported_langauge_list` and `not_supported_language_list` are not allowed be setted in same time.
- update the implement of `can_handle_language` function
fix #6802
**Status (please check what you already did)**:
- [ ] added some tests for the functionality
- [ ] updated the document... | 2020-09-27T08:11:01Z | A bug with language supporting detection function of component
**Rasa version**: 2.0.0rc1
**Issue**:
If a new component has such language supporting settings:
```python
supported_language_list = ["en", "xx"]
not_supported_language_list = None # which is the default value
```
it will not work correctly sin... | Thanks for the issue, @erohmensing will get back to you about it soon!
###### You may find help in the [docs](https://rasa.com/docs/) and the [forum,](https://forum.rasa.com/) too 🤗
Thanks for the initiative toward fixing this! | [
{
"body": "**Rasa version**: 2.0.0rc1\r\n\r\n**Issue**:\r\n\r\nIf a new component has such language supporting settings:\r\n\r\n```python\r\nsupported_language_list = [\"en\", \"xx\"]\r\nnot_supported_language_list = None # which is the default value\r\n```\r\nit will not work correctly since the `can_handle_l... | 8fc9b3bb7a0ec1536db49045c5e9ef6c089313d1 | {
"head_commit": "72601027505d3764042872cfd7ef18dc566255fb",
"head_commit_message": "add changelog",
"patch_to_review": "diff --git a/changelog/6803.bugfix.md b/changelog/6803.bugfix.md\nnew file mode 100644\nindex 000000000000..b547b01568f3\n--- /dev/null\n+++ b/changelog/6803.bugfix.md\n@@ -0,0 +1,3 @@\n+Fixed ... | [
{
"diff_hunk": "@@ -629,17 +635,25 @@ def can_handle_language(cls, language: Hashable) -> bool:\n `True` if component can handle specific language, `False` otherwise.\n \"\"\"\n \n- # if language_list is set to `None` it means: support all languages\n+ # If both `supported_lang... | 1a156ff441e905e3a371d27fef5eb1c69cb8f288 | diff --git a/changelog/6803.bugfix.md b/changelog/6803.bugfix.md
new file mode 100644
index 000000000000..225036e452fe
--- /dev/null
+++ b/changelog/6803.bugfix.md
@@ -0,0 +1,3 @@
+Fixed the bug that caused `supported_language_list` of `Component` to not work correctly.
+
+To avoid confusion, only one of `supported_lan... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
OpenBB-finance__OpenBB-6933@a6d4fc5 | OpenBB-finance/OpenBB | Python | 6,933 | [BugFix] Make "logging_suppress" in `SystemSettings` Mutable and Then Actually Suppress Logging Service | 1. **Why**?:
- To provide users with a way to resolve #6926 locally.
- This PR provides a kill switch to completely disable the LoggingService.
- The `SystemSettings` class has an attribute, `logging_suppress`, and it is immutably set as `False`.
- Even if it was mutable, there is no reference t... | 2024-11-05T22:35:30Z | [Bug] Getting a HTTPS error pointing to us.i.posthog.com when running the basic getting started code
**Describe the bug**
When following the getting started guide, I ran the basic code to get historical data of AAPL, I got this error message: `error uploading: HTTPSConnectionPool(host='us.i.posthog.com', port=443): Ma... | Hi there,
What kind of machine is this, a virtual machine or a desktop? Are you connected to the internet via VPN or other kind of proxy?
Can you try, @seantanjx, adding the items below to a file called "system_settings.json"? This is located in a folder called ".openbb_platform", at the root of the OS user acco... | [
{
"body": "**Describe the bug**\r\nWhen following the getting started guide, I ran the basic code to get historical data of AAPL, I got this error message: `error uploading: HTTPSConnectionPool(host='us.i.posthog.com', port=443): Max retries exceeded with url: /batch/ (Caused by NewConnectionError('<urllib3.con... | 85ca5501a5fbcd3550dfde8eff68fcb37d6d97d0 | {
"head_commit": "a6d4fc562196db8a6890c00c1c1bea3de60c027f",
"head_commit_message": "no startup log if true",
"patch_to_review": "diff --git a/openbb_platform/core/openbb_core/app/logs/handlers_manager.py b/openbb_platform/core/openbb_core/app/logs/handlers_manager.py\nindex 8e79d932f0ec..deeaff8d5e5e 100644\n---... | [
{
"diff_hunk": "@@ -217,42 +217,44 @@ def log(\n )\n self._handlers_manager.update_handlers(self._logging_settings)\n \n- if \"login\" in route:\n- self._log_startup(route, custom_headers)\n- else:\n-\n- # Remove CommandContext if any\n- kwargs.pop(... | a2e5dcd4d0bf7ef0ee3a6781e892d2591a8c3068 | diff --git a/openbb_platform/core/openbb_core/app/logs/handlers_manager.py b/openbb_platform/core/openbb_core/app/logs/handlers_manager.py
index 8e79d932f0ec..deeaff8d5e5e 100644
--- a/openbb_platform/core/openbb_core/app/logs/handlers_manager.py
+++ b/openbb_platform/core/openbb_core/app/logs/handlers_manager.py
@@ -3... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
RasaHQ__rasa-6019@d1ec880 | RasaHQ/rasa | Python | 6,019 | Shorten the information in tqdm during training | **Proposed changes**:
- closes https://github.com/RasaHQ/rasa/issues/5855
**Status (please check what you already did)**:
- [ ] added some tests for the functionality
- [ ] updated the documentation
- [x] updated the changelog (please check [changelog](https://github.com/RasaHQ/rasa/tree/master/changelog) for in... | 2020-06-12T15:41:53Z | shorten the information in tqdm during training ML algorithms based on the log level
**Description of Problem**:
currently DIETClassifier output a lot of info in tqdm:
```
Epochs: 11%|▍ | 9/80 [03:58<30:47, 26.02s/it, t_loss=6.703, i_loss=0.451, entity_loss=0.044, role_loss=0.053, i_acc=0.961, entity_f1=0.883, ro... | [
{
"body": "**Description of Problem**:\r\ncurrently DIETClassifier output a lot of info in tqdm:\r\n```\r\nEpochs: 11%|▍ | 9/80 [03:58<30:47, 26.02s/it, t_loss=6.703, i_loss=0.451, entity_loss=0.044, role_loss=0.053, i_acc=0.961, entity_f1=0.883, role_f1=0.717]\r\n```\r\nwhich makes it unusable for small siz... | aad76e5723868bbf8086cdfc9844fc9369c9ca53 | {
"head_commit": "d1ec8803dabb4a32b60866c2a3e50ba03a289ce9",
"head_commit_message": "add changelog",
"patch_to_review": "diff --git a/changelog/5855.improvement.rst b/changelog/5855.improvement.rst\nnew file mode 100644\nindex 000000000000..083779d38b89\n--- /dev/null\n+++ b/changelog/5855.improvement.rst\n@@ -0,... | [
{
"diff_hunk": "@@ -1109,26 +1109,42 @@ def _create_metrics(self) -> None:\n # so create loss metrics first to output losses first\n self.mask_loss = tf.keras.metrics.Mean(name=\"m_loss\")\n self.intent_loss = tf.keras.metrics.Mean(name=\"i_loss\")\n- self.entity_loss = tf.keras.m... | 5792fc9126bc821a33f034aba60b07c204404a91 | diff --git a/changelog/5855.improvement.rst b/changelog/5855.improvement.rst
new file mode 100644
index 000000000000..083779d38b89
--- /dev/null
+++ b/changelog/5855.improvement.rst
@@ -0,0 +1,2 @@
+Shorten the information in tqdm during training ML algorithms based on the log level. If you train your model
+in debug m... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
RasaHQ__rasa-6214@6f35573 | RasaHQ/rasa | Python | 6,214 | Add RegexEntityExtractor | **Proposed changes**:
- closes https://github.com/RasaHQ/rasa/issues/5957
- Add an entity extractor that extracts entities based on a lookup table/regexes
original PR https://github.com/RasaHQ/rasa/pull/6183
**Status (please check what you already did)**:
- [x] added some tests for the functionality
- [x] upd... | 2020-07-15T13:06:38Z | Add a lookup entity extractor
**Description of Problem**:
Lookup tables are used to create additional features for our entity extractors. In order for the features (aka "the word is part of lookup table xyz, so it is likely that is has the entity xyz") to work, you need to have some examples in your training data with... | @tabergma this is an interesting idea -- i definitely think users are confused about this. Do you think a `RegexEntityExtractor` would similarly be helpful? I think some users have implemented it themselves already
@erohmensing Good point 👍 `RegexFeaturizer` could cause a similar issue, might make sense to also add an... | [
{
"body": "**Description of Problem**:\r\nLookup tables are used to create additional features for our entity extractors. In order for the features (aka \"the word is part of lookup table xyz, so it is likely that is has the entity xyz\") to work, you need to have some examples in your training data with entire... | 11577628e6f3cd25c1d1bfe29b835c606fe747f5 | {
"head_commit": "6f35573e896355920c00b07adcbcd96ac47d44b5",
"head_commit_message": "update component name in tests",
"patch_to_review": "diff --git a/changelog/5957.feature.rst b/changelog/5957.feature.rst\nnew file mode 100644\nindex 000000000000..f782ab0ddbca\n--- /dev/null\n+++ b/changelog/5957.feature.rst\n@... | [
{
"diff_hunk": "@@ -102,6 +102,32 @@ def validate_only_one_tokenizer_is_used(pipeline: List[\"Component\"]) -> None:\n )\n \n \n+def validate_only_one_regex_component_is_used(pipeline: List[\"Component\"]) -> None:\n+ \"\"\"Validates that RegexEntityExtractor and RegexFeaturizer are not used at the\n... | b7dae506a6c06c98e23af00a127545a927bdceb5 | diff --git a/changelog/5957.feature.rst b/changelog/5957.feature.rst
new file mode 100644
index 000000000000..85a7b86c5653
--- /dev/null
+++ b/changelog/5957.feature.rst
@@ -0,0 +1,2 @@
+Add new entity extractor ``RegexEntityExtractor``. The entity extractor extracts entities using the lookup tables
+and regexes define... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
RasaHQ__rasa-6345@7e15408 | RasaHQ/rasa | Python | 6,345 | predict core fallback if no rule found | **Proposed changes**:
- fix https://github.com/RasaHQ/rasa/issues/6208
```yaml
policies:
- name: RulePolicy
# Confidence of the prediction if no rule matched d de-facto threshold for a
# core fallback.
core_fallback_threshold: 0.3
# Name of the action which should be predicted if no rule mat... | 2020-08-05T14:28:36Z | RulePolicy should predict Core fallback action if no rule was found
With the RulePolicy you can now write rules to handle low NLU confidence.
However, as we deprecate the FallbackPolicies we now have no policy which predicts a fallback action in case the Core confidence is low.
**Proposed Steps**
- [ ] The `RulePo... | [
{
"body": "With the RulePolicy you can now write rules to handle low NLU confidence.\r\nHowever, as we deprecate the FallbackPolicies we now have no policy which predicts a fallback action in case the Core confidence is low.\r\n\r\n**Proposed Steps**\r\n- [ ] The `RulePolicy` should predict a fallback action `x... | b075af71ef2de8a737e79c1f4fb13cc593de6f48 | {
"head_commit": "7e1540816d68c12e45f0734f3a4f0919c9d666fd",
"head_commit_message": "support predicting a core fallback in case no matching rule was found",
"patch_to_review": "diff --git a/examples/rules/config.yml b/examples/rules/config.yml\nindex d27831df4fb0..c19c8000e9c1 100644\n--- a/examples/rules/config.... | [
{
"diff_hunk": "@@ -20,3 +20,10 @@ pipeline:\n \n policies:\n - name: RulePolicy\n+ # Confidence of the prediction if no rule matched d de-facto threshold for a",
"line": null,
"original_line": 23,
"original_start_line": null,
"path": "examples/rules/config.yml",
"start_line": null,
... | 94ab7221c8d329980669d702b34dd0dc766d4e3d | diff --git a/examples/rules/config.yml b/examples/rules/config.yml
index d27831df4fb0..700e8cbd7d6a 100644
--- a/examples/rules/config.yml
+++ b/examples/rules/config.yml
@@ -8,7 +8,7 @@ pipeline:
- name: DucklingHTTPExtractor
url: http://localhost:8000
dimensions:
- - number
+ - number
- name: ... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
RasaHQ__rasa-5892@9adda67 | RasaHQ/rasa | Python | 5,892 | Fix duplicate logs | **Proposed changes**:
Fixes https://github.com/RasaHQ/rasa/issues/3900
- remove duplicated logs (any level)
- remove duplicated warnings: `UserWarnings`, `DeprecatedWarnings` and `FutureWarnings`
_Caveat: it doesn't work when same warning / log are fired in different processes_
**Status (please check what you ... | 2020-05-26T11:44:34Z | clean up duplicated errors during training
There are certain errors while training that get processed per line, and the repeat a ton when the error shows up a lot:
```
2019-06-28 17:49:21 WARNING rasa.core.domain - Failed to use action 'action_thank_feedback' in history. Please make sure all actions are listed in ... | check if this is still the case
I havent been able to get the earlier warning because it only happens after you remove an action from everywhere. However for example in 1.7.0, if you remove a categorical slot that is in your stories from your domain and then try to train (scroll to the right):
```
Processed Story Blo... | [
{
"body": "There are certain errors while training that get processed per line, and the repeat a ton when the error shows up a lot: \r\n```\r\n2019-06-28 17:49:21 WARNING rasa.core.domain - Failed to use action 'action_thank_feedback' in history. Please make sure all actions are listed in the domains action l... | 07b91a4767b7e688c5a3e9706c6ebbf4e9b6694a | {
"head_commit": "9adda674d3adf88311d42a8d799bc94cbeefe750",
"head_commit_message": "Merge branch '1.10.x' into fix-duplicate-logs",
"patch_to_review": "diff --git a/changelog/3900.improvement.rst b/changelog/3900.improvement.rst\nnew file mode 100644\nindex 000000000000..1a6b17f37139\n--- /dev/null\n+++ b/change... | [
{
"diff_hunk": "@@ -0,0 +1 @@\n+Removed duplicate logs and warnings when running ``rasa train``.",
"line": null,
"original_line": 1,
"original_start_line": null,
"path": "changelog/3900.improvement.rst",
"start_line": null,
"text": "@user1:\nMaybe `Reduce` instead of `Remove`? As you men... | 91bc1152e4cf585ec9ed6fc7ca5d798e8cfc4349 | diff --git a/changelog/3900.improvement.rst b/changelog/3900.improvement.rst
new file mode 100644
index 000000000000..58224dad0ad7
--- /dev/null
+++ b/changelog/3900.improvement.rst
@@ -0,0 +1 @@
+Reduced duplicate logs and warnings when running ``rasa train``.
diff --git a/rasa/__main__.py b/rasa/__main__.py
index 6f3... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Code Refactoring / Architectural Improvement"
} |
RasaHQ__rasa-5963@7197577 | RasaHQ/rasa | Python | 5,963 | Improve testing output of story evaluation | **Proposed changes**:
closes https://github.com/RasaHQ/rasa/issues/5748
Add option to write down successful story predictions to disk.
Add option to disable writing down incorrect story predictions.
Write down summary report to disk.
**Status (please check what you already did)**:
- [x] added some tests for t... | 2020-06-05T08:54:31Z | Standardize testing output
**Description of Problem**:
For intents we currently have the following testing output: report, error, successes, confusion matrix, histogram. However, for stories, entities, and responses only some of those outputs exists. We should standardize the testing output so that you have the same t... | [
{
"body": "**Description of Problem**:\r\nFor intents we currently have the following testing output: report, error, successes, confusion matrix, histogram. However, for stories, entities, and responses only some of those outputs exists. We should standardize the testing output so that you have the same tool to... | a524b4378c4e22c7cee49b742f90d31397d1d6d1 | {
"head_commit": "7197577d2f692869bef5214780106398caec7fbd",
"head_commit_message": "resolve doc warnings",
"patch_to_review": "diff --git a/changelog/5748.improvement.rst b/changelog/5748.improvement.rst\nindex e2eed4ac7724..522a8e9ca0ce 100644\n--- a/changelog/5748.improvement.rst\n+++ b/changelog/5748.improvem... | [
{
"diff_hunk": "@@ -290,11 +284,11 @@ def _emulate_form_rejection(processor, partial_tracker):\n \n \n def _collect_action_executed_predictions(\n- processor,\n- partial_tracker,\n- event,\n- fail_on_prediction_errors,\n- circuit_breaker_tripped,\n+ processor: \"MessageProcessor\",\n+ parti... | 739b54011c050df192d2533b3626f361f05e4ad0 | diff --git a/changelog/5748.improvement.rst b/changelog/5748.improvement.rst
index e2eed4ac7724..522a8e9ca0ce 100644
--- a/changelog/5748.improvement.rst
+++ b/changelog/5748.improvement.rst
@@ -1,6 +1,6 @@
-Standardize testing output. The following test output can be produced for intents, responses and entities:
+Stan... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Test Suite / CI Enhancements"
} | |
RasaHQ__rasa-6639@7671086 | RasaHQ/rasa | Python | 6,639 | Consider confidence values in 'ensure_consistent_bilou_tagging' | **Proposed changes**:
The method `ensure_consistent_bilou_tagging` now also considers the confidence values of the predicted tags
when updating the BIlOU tags.
closes https://github.com/RasaHQ/rasa/issues/6039
**Status (please check what you already did)**:
- [x] added some tests for the functionality
- [ ] u... | 2020-09-11T08:41:05Z | 'ensure_consistent_bilou_tagging' should consider confidence values
**Description of Problem**:
The method `bilou_utils.ensure_consistent_bilou_tagging(tags)` checks if tags are consistently tagged and adapts them if needed. However, confidence values are not modified in this method, although tags might change.
**O... | [
{
"body": "**Description of Problem**:\r\nThe method `bilou_utils.ensure_consistent_bilou_tagging(tags)` checks if tags are consistently tagged and adapts them if needed. However, confidence values are not modified in this method, although tags might change.\r\n\r\n**Overview of the Solution**:\r\nIf a tag chan... | c72ce786c45e68931876ba2425c0b48f72e54cdf | {
"head_commit": "76710869daf9b87ed9cfe9260fa41dfedaac9b90",
"head_commit_message": "add changelog",
"patch_to_review": "diff --git a/changelog/6039.improvment.md b/changelog/6039.improvment.md\nnew file mode 100644\nindex 000000000000..a6049d8471b8\n--- /dev/null\n+++ b/changelog/6039.improvment.md\n@@ -0,0 +1,2... | [
{
"diff_hunk": "@@ -271,6 +277,32 @@ def ensure_consistent_bilou_tagging(predicted_tags: List[Text]) -> List[Text]:\n if prefix == BEGINNING:\n last_idx = _find_bilou_end(idx, predicted_tags)\n \n+ relevant_confidences = predicted_confidences[idx : last_idx + 1]\n+ rele... | bb5048e1157610a1092e3645440e3736a052a427 | diff --git a/changelog/6039.improvment.md b/changelog/6039.improvment.md
new file mode 100644
index 000000000000..9939b2e894aa
--- /dev/null
+++ b/changelog/6039.improvment.md
@@ -0,0 +1,2 @@
+The method `ensure_consistent_bilou_tagging` now also considers the confidence values of the predicted tags
+when updating the ... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} | |
RasaHQ__rasa-5853@17b2d21 | RasaHQ/rasa | Python | 5,853 | Typoci | **Proposed changes**:
- closes https://github.com/RasaHQ/rasa/issues/5720
- Add TypoCI configuration to check docs
- fix legitimate typos found
See https://github.com/melindaloubser1/rasa/pull/3 for behaviour on docs
Things learned about Typo CI:
- only checks changed lines, so in order to test what it will f... | 2020-05-18T22:18:50Z | Add TypoCI to PR workflow to check docs for typos
**Description of Problem**:
Typos get added to the docs occasionally
**Overview of the Solution**:
Add TypoCI to workflow for pull requests to catch typos. Add files & words that should be ignored (i.e. all files except docs, all false-positives).
**Definition o... | [
{
"body": "**Description of Problem**:\r\nTypos get added to the docs occasionally\r\n\r\n**Overview of the Solution**:\r\nAdd TypoCI to workflow for pull requests to catch typos. Add files & words that should be ignored (i.e. all files except docs, all false-positives).\r\n\r\n**Definition of Done**:\r\n- [ ] ... | 12f545c13ae033417bd6e7394c93c20135c68ef2 | {
"head_commit": "17b2d21f61c759fcfd70dbdb61a3af4bb28d5c47",
"head_commit_message": "typos",
"patch_to_review": "diff --git a/.typo-ci.yml b/.typo-ci.yml\nnew file mode 100644\nindex 000000000000..e898f5468c4a\n--- /dev/null\n+++ b/.typo-ci.yml\n@@ -0,0 +1,141 @@\n+# This is a sample .typo-ci.yml file, it's used ... | [
{
"diff_hunk": "@@ -0,0 +1,141 @@\n+# This is a sample .typo-ci.yml file, it's used to configure how Typo CI will behave.\n+# Add it to the root of your project and push it to github.\n+---\n+\n+# What language dictionaries should it use? Currently Typo CI supports:\n+# de\n+# en\n+# en_GB\n+# es\n+# fr\n+# it\... | f2148e83ad2db71f565bbc85f6f6c3dc57735107 | diff --git a/.typo-ci.yml b/.typo-ci.yml
new file mode 100644
index 000000000000..96ea3a2f1588
--- /dev/null
+++ b/.typo-ci.yml
@@ -0,0 +1,160 @@
+# This is a sample .typo-ci.yml file, it's used to configure how Typo CI will behave.
+# Add it to the root of your project and push it to github.
+---
+
+ # What languag... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "Test Suite / CI Enhancements"
} | |
RasaHQ__rasa-5761@6b74888 | RasaHQ/rasa | Python | 5,761 | Don't create TensorBoard logs during prediction | **Proposed changes**:
Don't create TensorBoard log files during prediction.
closes #5617
**Status (please check what you already did)**:
- [ ] added some tests for the functionality
- [ ] updated the documentation
- [x] updated the changelog (please check [changelog](https://github.com/RasaHQ/rasa/tree/master... | 2020-04-30T11:45:42Z | Tensorboard log files are created during prediction as well
**Rasa version**: 1.9.5
**Python version**: 3.6.5
**Operating system** (windows, osx, ...): MacOS
**Issue**: Since the call to `self._set_up_tensorboard_writer(tensorboard_log_level, tensorboard_log_dir)` is made in the constructor of `RasaModel` clas... | [
{
"body": "**Rasa version**: 1.9.5\r\n\r\n**Python version**: 3.6.5\r\n\r\n**Operating system** (windows, osx, ...): MacOS\r\n\r\n**Issue**: Since the call to `self._set_up_tensorboard_writer(tensorboard_log_level, tensorboard_log_dir)` is made in the constructor of `RasaModel` class, these files are created du... | 8f93669914d65367dc6920037586928f73195271 | {
"head_commit": "6b748887757404845d716de9f6b801a854a98105",
"head_commit_message": "add changelog entry",
"patch_to_review": "diff --git a/changelog/5617.bugfix.rst b/changelog/5617.bugfix.rst\nnew file mode 100644\nindex 000000000000..a3cf0560d2eb\n--- /dev/null\n+++ b/changelog/5617.bugfix.rst\n@@ -0,0 +1 @@\n... | [
{
"diff_hunk": "@@ -103,6 +103,10 @@ def fit(\n ) -> None:\n \"\"\"Fit model data\"\"\"\n \n+ if not silent:",
"line": null,
"original_line": 106,
"original_start_line": null,
"path": "rasa/utils/tensorflow/models.py",
"start_line": null,
"text": "@user1:\nWhy do we ne... | 2836b7604d650d112b88c91496f5ff54e8b763b3 | diff --git a/changelog/5617.bugfix.rst b/changelog/5617.bugfix.rst
new file mode 100644
index 000000000000..a3cf0560d2eb
--- /dev/null
+++ b/changelog/5617.bugfix.rst
@@ -0,0 +1 @@
+Don't create TensorBoard log files during prediction.
diff --git a/rasa/utils/tensorflow/models.py b/rasa/utils/tensorflow/models.py
index... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
RasaHQ__rasa-5756@3d6653c | RasaHQ/rasa | Python | 5,756 | Tokenizers don't split words into sub-words | **Proposed changes**:
To avoid the problem of our entity extractors predicting entity labels for just a part of the words, we introduced a cleaning method after the prediction was done. However, we should avoid the incorrect prediction in the first place.
To achieve this we will not tokenize words into sub-words any... | 2020-04-30T08:43:53Z | EntityExtractor in v1.10.0 yield wrong entity value for language without spaces
Rasa version:
v1.10.0
Python version:
3.7
Operating system:
Windows, Linux
I'm not sure if this should be a bug or feature request, but here I go.
**Description of Problem**:
For language that doesn't have space that separate wo... | Hello @tabergma,
Thank you very much for the quick response and I really appreciate it that you're already working on it. | [
{
"body": "Rasa version:\r\nv1.10.0\r\nPython version:\r\n3.7\r\nOperating system:\r\nWindows, Linux\r\n\r\nI'm not sure if this should be a bug or feature request, but here I go.\r\n\r\n**Description of Problem**:\r\nFor language that doesn't have space that separate words, any `EntityExtractor` class will ret... | 1e90073a0a6d14bd8856198c04fb9010aaa554fe | {
"head_commit": "3d6653c1d96983f25c8240242175a4eee520bfa8",
"head_commit_message": "add test for HFTransfomerNLP",
"patch_to_review": "diff --git a/changelog/5756.improvement.rst b/changelog/5756.improvement.rst\nnew file mode 100644\nindex 000000000000..d2a77898a7ad\n--- /dev/null\n+++ b/changelog/5756.improvem... | [
{
"diff_hunk": "@@ -0,0 +1,43 @@\n+import numpy as np\n+\n+import rasa.utils.train_utils as train_utils\n+from nlu.tokenizers.lm_tokenizer import LanguageModelTokenizer\n+from rasa.nlu.utils.hugging_face.hf_transformers import HFTransformersNLP\n+from rasa.nlu.constants import TEXT, NUMBER_OF_SUB_TOKENS\n+from ... | ae2ad82b850cfb1f3b6d89ef1d2b01475e0e2afc | diff --git a/changelog/5756.improvement.rst b/changelog/5756.improvement.rst
new file mode 100644
index 000000000000..4f67b24409ef
--- /dev/null
+++ b/changelog/5756.improvement.rst
@@ -0,0 +1,8 @@
+To avoid the problem of our entity extractors predicting entity labels for just a part of the words,
+we introduced a cle... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
RasaHQ__rasa-5818@693ab41 | RasaHQ/rasa | Python | 5,818 | Release script alpha | **Proposed changes**:
- Add support for `alpha` keyword in the release script [here](https://github.com/RasaHQ/rasa/blob/c4d5302e3e9d6d4f442d15b42f1ad585f0d90d88/scripts/release.py#L129-L150)
- Use strict PEP440 format e.g. `1.10.0a1`
- Use this new simple package I worked on: https://pypi.org/project/pep440-version... | 2020-05-14T09:12:18Z | Update release script to support pre-releases
**Description of Problem**:
If you want to tag a pre-release the release script does not accept, for example, the version number `1.10.0a1`. It just supports `1.10.0-alpha1`. Also the release script deletes all changelog files and update the `CHANGELOG.rst` file. This shou... | @tabergma I'm taking a look at this one and I don't see what you mean by "it just supports 1.10.0-alpha1", because to me, it doesn't even support this:
https://github.com/RasaHQ/rasa/blob/c4d5302e3e9d6d4f442d15b42f1ad585f0d90d88/scripts/release.py#L33-L37
When you execute `make release` it ask you for the next versi... | [
{
"body": "**Description of Problem**:\r\nIf you want to tag a pre-release the release script does not accept, for example, the version number `1.10.0a1`. It just supports `1.10.0-alpha1`. Also the release script deletes all changelog files and update the `CHANGELOG.rst` file. This should not happen on a pre-re... | bd8e8ea9181cbb20a70edd4ae1c7cc26b6c71070 | {
"head_commit": "693ab411b8286582cc54f536b2a60fe6412c8719",
"head_commit_message": "more meaningful message to pick a good version",
"patch_to_review": "diff --git a/scripts/release.py b/scripts/release.py\nindex 466efaedefc3..aeafd815afec 100644\n--- a/scripts/release.py\n+++ b/scripts/release.py\n@@ -7,6 +7,7 ... | [
{
"diff_hunk": "@@ -280,7 +319,9 @@ def main(args: argparse.Namespace) -> None:\n write_version_file(version)\n write_version_to_pyproject(version)\n \n- generate_changelog(version)\n+ if not version.prerelease:\n+ # never update changelog on an alpha version\n+ generate_changelog(ve... | 784cd5081477fc354fc8fbbf3f6bf6d1fe7048d3 | diff --git a/poetry.lock b/poetry.lock
index 1c058e6946c9..b27efd365155 100644
--- a/poetry.lock
+++ b/poetry.lock
@@ -76,7 +76,7 @@ description = "A small Python module for determining appropriate platform-specif
name = "appdirs"
optional = false
python-versions = "*"
-version = "1.4.3"
+version = "1.4.4"
[[pack... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
RasaHQ__rasa-5740@5fc84b9 | RasaHQ/rasa | Python | 5,740 | Build changelog in test docs step | **Proposed changes**:
- In the "test docs" stage, prepare the changelog via the `make release` methods to make sure that no changelog entries will break the build upon releasing
- fix #5739
**Status (please check what you already did)**:
- [ ] added some tests for the functionality
- [ ] updated the documentati... | 2020-04-28T13:58:59Z | Add validation of changelog files
**Problem**:
The single changelog files in `changelog/` are currently not validated. They are only validated when creating a new release since this will generate the actual `Changelog.rst` and include it in the documentation. When the documentation is linted, errors in the changelog w... | [
{
"body": "**Problem**:\r\nThe single changelog files in `changelog/` are currently not validated. They are only validated when creating a new release since this will generate the actual `Changelog.rst` and include it in the documentation. When the documentation is linted, errors in the changelog will surface. ... | c6de93d9b4cd8343529f8f54853b861bee695a0b | {
"head_commit": "5fc84b9291f3f334df0dbad64760d5e385149647",
"head_commit_message": "use poetry run",
"patch_to_review": "diff --git a/.github/workflows/continous-integration.yml b/.github/workflows/continous-integration.yml\nindex 875abcbade3d..0fc748430869 100644\n--- a/.github/workflows/continous-integration.y... | [
{
"diff_hunk": "@@ -0,0 +1 @@\n+this is a fake entry with a bad :ref:`reference-that-should-fail`",
"line": null,
"original_line": 1,
"original_start_line": null,
"path": "changelog/6000.bugfix.rst",
"start_line": null,
"text": "@user1:\ndon't forget to remove that :-D \n\n@author:\nHaha... | 8b723b14ef9c0f2f106ff702ce6beae63572c447 | diff --git a/.github/workflows/continous-integration.yml b/.github/workflows/continous-integration.yml
index 7ee4c0aea49d..b2cb9cdb9e41 100644
--- a/.github/workflows/continous-integration.yml
+++ b/.github/workflows/continous-integration.yml
@@ -104,6 +104,7 @@ jobs:
- name: Test Docs 📃
run: |
ma... | {
"difficulty": "medium",
"estimated_review_effort": 2,
"problem_domain": "New Feature Additions"
} | |
RasaHQ__rasa-5432@5aba713 | RasaHQ/rasa | Python | 5,432 | add full retrieval intent name | **Proposed changes**:
- add full retrieval intent name to tracker
- closes https://github.com/RasaHQ/rasa/issues/4826
**Status (please check what you already did)**:
- [x] added some tests for the functionality
- [ ] updated the documentation
- [x] updated the changelog (please check [changelog](https://github... | 2020-03-17T18:02:54Z | Retrieval intent needs to store full intent name in tracker
**Description of Problem**:
The intent `ask_faq/python_version` is grouped into a single retriever event and placed in the tracker store as `ask_faq`. If you are using the TwoStageFallbackPolicy and the `ActionDefaultAskAffirmation` to further contextualize t... | it should be available in the `tracker.latest_message` right? that should contain the top predicted response for the retrieval action
@amn41 maybe so, but not sure that solves all the problems this issue causes:
> `ask_faq/python_version` is grouped into the single retriever intent and placed in the tracker store as... | [
{
"body": "**Description of Problem**:\r\nThe intent `ask_faq/python_version` is grouped into a single retriever event and placed in the tracker store as `ask_faq`. If you are using the TwoStageFallbackPolicy and the `ActionDefaultAskAffirmation` to further contextualize the conversation with the user, lack of ... | 82e5298ee897fc775503c7924cfc8341042e1336 | {
"head_commit": "5aba713cb14af93e9fe373d5c5e28220bc269421",
"head_commit_message": "Merge branch 'full_retrieval_intent' of github.com:RasaHQ/rasa into full_retrieval_intent",
"patch_to_review": "diff --git a/changelog/4826.improvement.rst b/changelog/4826.improvement.rst\nnew file mode 100644\nindex 00000000000... | [
{
"diff_hunk": "@@ -33,6 +34,12 @@ def test_train_selector(pipeline, component_builder, tmpdir):\n assert trainer.pipeline\n \n loaded = Interpreter.load(persisted_path, component_builder)\n+ parsed = loaded.parse(\"hello\")\n \n assert loaded.pipeline\n- assert loaded.parse(\"hello\") is not ... | 87e550a6ff56e8732fab7b2740b764326c36514d | diff --git a/changelog/4826.improvement.rst b/changelog/4826.improvement.rst
new file mode 100644
index 000000000000..c7a3b11b400f
--- /dev/null
+++ b/changelog/4826.improvement.rst
@@ -0,0 +1,4 @@
+Add full retrieval intent name to message data
+``ResponseSelector`` will now add the full retrieval intent name
+e.g. ``... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
RasaHQ__rasa-5476@5055f1d | RasaHQ/rasa | Python | 5,476 | Fix bug: one word two entity labels | **Proposed changes**:
- closes https://github.com/RasaHQ/rasa/issues/5475
**Status (please check what you already did)**:
- [x] added some tests for the functionality
- [ ] updated the documentation
- [ ] updated the changelog (please check [changelog](https://github.com/RasaHQ/rasa/tree/master/changelog) for in... | 2020-03-24T12:00:27Z | One word two entity labels
**Description of the problem**
ConveRT and also other language models we have in our pipeline split words during tokenization into sub-words. `DIETClassifier` assigns different entities to the individual sub-words.
Example:
```
{
"text": "Aarhus",
"entities": [
{
... | [
{
"body": "**Description of the problem**\r\nConveRT and also other language models we have in our pipeline split words during tokenization into sub-words. `DIETClassifier` assigns different entities to the individual sub-words.\r\n\r\nExample:\r\n```\r\n{\r\n \"text\": \"Aarhus\",\r\n \"entities\": [\r\n... | d946368899c2c8cf3b019cd750e7d44b710364f8 | {
"head_commit": "5055f1ddabfc784db20d5023a676ac54baf41a56",
"head_commit_message": "fix style issues",
"patch_to_review": "diff --git a/changelog/5475.bugfix.rst b/changelog/5475.bugfix.rst\nnew file mode 100644\nindex 000000000000..9f515a0d6421\n--- /dev/null\n+++ b/changelog/5475.bugfix.rst\n@@ -0,0 +1,5 @@\n+... | [
{
"diff_hunk": "@@ -21,6 +21,90 @@ def add_processor_name(self, entity: Dict[Text, Any]) -> Dict[Text, Any]:\n \n return entity\n \n+ def clean_up_entities(\n+ self, entities: List[Dict[Text, Any]], keep: bool = True\n+ ) -> List[Dict[Text, Any]]:\n+ \"\"\"\n+ Checks if multip... | 49c1e41c67e6354414a04b79b9bfa5ecd301e949 | diff --git a/changelog/5475.bugfix.rst b/changelog/5475.bugfix.rst
new file mode 100644
index 000000000000..9f515a0d6421
--- /dev/null
+++ b/changelog/5475.bugfix.rst
@@ -0,0 +1,5 @@
+One word can just have one entity label.
+
+If you are using, for example, ``ConveRTTokenizer`` words can be split into multiple tokens.... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} | |
RasaHQ__rasa-5341@d8b1c24 | RasaHQ/rasa | Python | 5,341 | Add warnings when NLU configuration missing for training data (rebase after tf2) | **Proposed changes**:
- close https://github.com/RasaHQ/rasa/issues/3886
see revision history at https://github.com/RasaHQ/rasa/pull/4706
**Status (please check what you already did)**:
- [X] made PR ready for code review
- [ ] added some tests for the functionality
- [ ] updated the documentation
- [ ] upda... | 2020-02-28T18:48:58Z | Display warning about missing component/policy in config whenever possible
**Description of Problem**:
In most instances, it is straightforward to infer from the domain file or the training data that the user is trying to use a feature that is conditional on a component/policy being included in the `config.yml` file.
... | This is a cool suggestion !
@msamogh is this complete?
No, `Perform checking for NLU pipeline features` is still remaining in the checklist.
ok next time i think it's better to have two separate issues if two separate PRs are going to fix it :)
maybe too much for this issue but from reading our docs it appears we have... | [
{
"body": "**Description of Problem**:\r\nIn most instances, it is straightforward to infer from the domain file or the training data that the user is trying to use a feature that is conditional on a component/policy being included in the `config.yml` file.\r\n\r\nIdentifying these situations while training and... | 58e546be1c353e459f0480abd35fa5e3b0ab50c3 | {
"head_commit": "d8b1c24339c89b3017b843bd3bf9bffb7f47738b",
"head_commit_message": "fix deepsource python recommendations",
"patch_to_review": "diff --git a/data/test_config/config_crf_no_pattern_feature.yml b/data/test_config/config_crf_no_pattern_feature.yml\nnew file mode 100644\nindex 000000000000..cac2cf1a9... | [
{
"diff_hunk": "@@ -179,28 +181,102 @@ def validate_pipeline(pipeline: List[\"Component\"]) -> None:\n validate_required_components(pipeline)\n \n \n+def any_components_in_pipeline(components: Iterable[Text], pipeline: List[\"Component\"]):\n+ \"\"\"Check if any of the provided components are listed in t... | f182eb6e5a0e5988b6fac3d80e74a5c42bcc4ce0 | diff --git a/data/test_config/config_crf_no_pattern_feature.yml b/data/test_config/config_crf_no_pattern_feature.yml
new file mode 100644
index 000000000000..cac2cf1a96a2
--- /dev/null
+++ b/data/test_config/config_crf_no_pattern_feature.yml
@@ -0,0 +1,7 @@
+language: en
+pipeline:
+ - name: "WhitespaceTokenizer"
+ -... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
RasaHQ__rasa-5863@45e4a37 | RasaHQ/rasa | Python | 5,863 | Flexible NLU pipeline | **Proposed changes**:
closes #5510
You can set an alias for every featurizer in your pipeline. You can then specify on, for example, the `DIETClassifier` or the `ResponseSelector` what features from which featurizers should go in.
If you don't set the option `featurizers` all available features will be used. This... | 2020-05-20T07:12:45Z | Make NLU configuration more flexible
**Description of Problem**:
Currently, the NLU pipeline is interpreted as a flat pipeline where each component produces annotations, i.e. tokens, sparse features, dense features, etc. and then they are finally consumed by all the ML components present in the pipeline. This used to ... | [
{
"body": "**Description of Problem**:\r\nCurrently, the NLU pipeline is interpreted as a flat pipeline where each component produces annotations, i.e. tokens, sparse features, dense features, etc. and then they are finally consumed by all the ML components present in the pipeline. This used to work well when w... | aa4c97debc2286d246265d7653459c500a0d7a4b | {
"head_commit": "45e4a37d595bbc98a71c67175494a4c2ffe702e9",
"head_commit_message": "fix tests",
"patch_to_review": "diff --git a/changelog/5510.feature.rst b/changelog/5510.feature.rst\nnew file mode 100644\nindex 000000000000..f4d06a32c7bb\n--- /dev/null\n+++ b/changelog/5510.feature.rst\n@@ -0,0 +1,36 @@\n+You... | [
{
"diff_hunk": "@@ -0,0 +1,23 @@\n+language: \"en\"\n+\n+pipeline:\n+ - name: ConveRTTokenizer\n+ - name: ConveRTFeaturizer\n+ alias: \"convert\"\n+ - name: RegexFeaturizer\n+ alias: \"regex\"\n+ - name: LexicalSyntacticFeaturizer\n+ alias: \"lexical-syntactic\"\n+ - name: CountVectorsFeaturizer\n... | 1766a530a28442d9150ab86648169c144f8ccbb0 | diff --git a/changelog/5510.feature.rst b/changelog/5510.feature.rst
new file mode 100644
index 000000000000..3dfc115798ce
--- /dev/null
+++ b/changelog/5510.feature.rst
@@ -0,0 +1,40 @@
+You can now define what kind of features should be used by what component (see :ref:`choosing-a-pipeline`).
+
+You can set an alias ... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
RasaHQ__rasa-5693@7c5682b | RasaHQ/rasa | Python | 5,693 | update facebook docs with supported attachments | **Proposed changes**:
- update Facebook channel docs with supported attachments:
- `buttons`
- `quick_replies`
- `elements`
- Fixes #5640
**Status (please check what you already did)**:
- [x] updated the documentation
- [x] updated the changelog (please check [changelog](https://github.com/RasaHQ... | 2020-04-21T23:21:13Z | Need docs on Facebook Messenger response template keys
**Description of Problem**:
Had to add a Facebook messenger channel integration into a bot I spun up and found the Facebook Messenger docs lacking a bit especially on the special response template keys `quick_replies` and `elements`; I had to read through the Fac... | Thanks for submitting this feature request 🚀 @degiz will get back to you about it soon! ✨
Hey @ortsaCniveK
Great that you could connect the bot the Facebook Messenger!
Since you've just identified the issues with the current docs, maybe you can propose a PR with all the updated you've mentioned?
Currently work... | [
{
"body": "**Description of Problem**:\r\nHad to add a Facebook messenger channel integration into a bot I spun up and found the Facebook Messenger docs lacking a bit especially on the special response template keys `quick_replies` and `elements`; I had to read through the Facebook channel source to figure out ... | cb25c31e2c6c3c36c768f2d4b442cd4cb6d1928c | {
"head_commit": "7c5682bde7a1990a3af03b44641da65dfa0e27b9",
"head_commit_message": "Merge branch 'master' into docs-facebook",
"patch_to_review": "diff --git a/changelog/5640.doc.rst b/changelog/5640.doc.rst\nnew file mode 100644\nindex 000000000000..1b9258b6fab7\n--- /dev/null\n+++ b/changelog/5640.doc.rst\n@@ ... | [
{
"diff_hunk": "@@ -69,3 +69,78 @@ The endpoint for receiving Facebook messenger messages is\n ``http://localhost:5005/webhooks/facebook/webhook``, replacing\n the host and port with the appropriate values. This is the URL\n you should add in the configuration of the webhook.\n+\n+Supported response attachments... | 99141294e19c84ad954eedc00840654c6da0facd | diff --git a/changelog/5640.doc.rst b/changelog/5640.doc.rst
new file mode 100644
index 000000000000..fb5b9c80c271
--- /dev/null
+++ b/changelog/5640.doc.rst
@@ -0,0 +1 @@
+Updated Facebook Messenger channel docs with supported attachment information
diff --git a/docs/user-guide/connectors/facebook-messenger.rst b/docs... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "Documentation Updates"
} |
RasaHQ__rasa-5122@9d3a927 | RasaHQ/rasa | Python | 5,122 | for "rasa test core --evaluate-model-directory" set default for "--model" to directory | **Proposed changes**:
If rasa test core is called with --evaluate-model-directory and a file as --model, use the folder that file is in as --model instead.
This fixes #4896 : When no --model argument is given, instead of defaulting to the latest model in ./models it now defaults to ./models
Side effect: When cal... | 2020-01-23T14:25:40Z | "rasa test core --evaluate-model-directory" should have directory as default
**Steps to Reproduce**:
1. Hava a rasa project (e.g. by doing `rasa init`)
2. Train a single model (`rasa train`)
3. Run `rasa test core --evaluate-model-directory`
**Problem**:
By default `rasa test core` has the latest model in the ... | [
{
"body": "**Steps to Reproduce**:\r\n1. Hava a rasa project (e.g. by doing `rasa init`)\r\n2. Train a single model (`rasa train`)\r\n3. Run `rasa test core --evaluate-model-directory`\r\n\r\n**Problem**:\r\n\r\nBy default `rasa test core` has the latest model in the `./models` directory as default value for th... | c58ae0b3ad5c34ea96871fb203e8ff883b408482 | {
"head_commit": "9d3a9273480d12812ba1c306bcc47e4bd241a268",
"head_commit_message": "split up tests in 3 functions; more descriptive name; added missing types",
"patch_to_review": "diff --git a/rasa/test.py b/rasa/test.py\nindex d62a14b5e23f..95045c011402 100644\n--- a/rasa/test.py\n+++ b/rasa/test.py\n@@ -2,6 +2... | [
{
"diff_hunk": "@@ -27,6 +32,20 @@ def test_core_models_in_directory(model_directory: Text, stories: Text, output:\n plot_core_results(output, number_of_stories)\n \n \n+def _test_core_models_in_directory_input(model_directory: Text) -> Text:\n+ import rasa.model\n+\n+ p = Path(model_directory)",
... | 302cc95ddc916fa761e35f296ce3d0be93e89957 | diff --git a/changelog/4896.bugfix.rst b/changelog/4896.bugfix.rst
new file mode 100644
index 000000000000..b7f2b8eeb517
--- /dev/null
+++ b/changelog/4896.bugfix.rst
@@ -0,0 +1,3 @@
+Fixed default behavior of ``rasa test core --evaluate-model-directory`` when called without ``--model``. Previously, the latest model fi... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
RasaHQ__rasa-5322@c4ff78b | RasaHQ/rasa | Python | 5,322 | Fix callback resp | **Proposed changes**:
- fix https://github.com/RasaHQ/rasa/issues/5320
- remove unused `return_method` kwarg
- gracefully handle response types other than json instead of raising an error
**Status (please check what you already did)**:
- [x] added some tests for the functionality
- [ ] updated the documentation... | 2020-02-26T14:50:41Z | callback post only expects json response, fails on others
If you use a callback channel to post to a slack incoming webhook, you get a traceback:
```
2020-02-07 10:12:19 DEBUG rasa.server - Traceback (most recent call last):
File "/build/lib/python3.6/site-packages/rasa/server.py", line 663, in trigger_intent
... | [
{
"body": "If you use a callback channel to post to a slack incoming webhook, you get a traceback:\r\n```\r\n2020-02-07 10:12:19 DEBUG rasa.server - Traceback (most recent call last):\r\n File \"/build/lib/python3.6/site-packages/rasa/server.py\", line 663, in trigger_intent\r\n tracker=tracker,\r\n Fi... | f87cc97c202a70ccb3004ff036112fa777353796 | {
"head_commit": "c4ff78b9c23696ad0d8a87451a11140bd2c9736e",
"head_commit_message": "Merge branch 'master' into fix-callback-resp",
"patch_to_review": "diff --git a/changelog/5230.bugfix.rst b/changelog/5230.bugfix.rst\nnew file mode 100644\nindex 000000000000..627ba67bcd71\n--- /dev/null\n+++ b/changelog/5230.bu... | [
{
"diff_hunk": "@@ -94,3 +94,19 @@ def test_endpoint_config_custom_token_name():\n actual = endpoint_utils.EndpointConfig.from_dict(test_data)\n \n assert actual.token_name == \"test_token\"\n+\n+\n+async def test_request_non_json_response():\n+ with aioresponses() as mocked:\n+ endpoint = end... | 6e53fc68fd7f207a9f2fa66c8f1bfcef94512e0f | diff --git a/changelog/5230.bugfix.rst b/changelog/5230.bugfix.rst
new file mode 100644
index 000000000000..627ba67bcd71
--- /dev/null
+++ b/changelog/5230.bugfix.rst
@@ -0,0 +1 @@
+Fixed issue where posting to certain callback channel URLs would return a 500 error on successful posts due to invalid response format
dif... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
RasaHQ__rasa-5112@8eff31c | RasaHQ/rasa | Python | 5,112 | Bug restart fallback | **Proposed changes**:
- Fixes https://github.com/RasaHQ/rasa/issues/4601
- Changed `TwoStageFallbackPolicy._is_user_input_expected` to return `true` only if user input has not been given since executing `action_default_fallback`.
When the two stage fallback policy is used together with the mapping policy with def... | 2020-01-23T01:56:09Z | Restart button not working in two-stage fallback policy
For a question for which it is falling under 2-stage fallback and showing buttons, but if without selecting from those options I am again posting a question then it is giving Restart option. The conversation is getting hanged after this **Restart** button even tho... | Thanks for raising this issue, @btotharye will get back to you about it soon✨
###### Please also check out the [docs](https://rasa.com/docs/) and the [forum](https://forum.rasa.com/) in case your issue was raised there too 🤗
Hey @Pratiksha1312 sorry for the late response was pretty busy the past few days. I'm going ... | [
{
"body": "For a question for which it is falling under 2-stage fallback and showing buttons, but if without selecting from those options I am again posting a question then it is giving Restart option. The conversation is getting hanged after this **Restart** button even though if I am clicking on the **Restart... | 85e71477839aae1d3e659637f87b05bca9aefb2d | {
"head_commit": "8eff31c6e2f46c5ae0538b332ebd32469988b57e",
"head_commit_message": "add exception handling if no UserUttered/ActionExecuted in tracker",
"patch_to_review": "diff --git a/changelog/4601.bugfix.rst b/changelog/4601.bugfix.rst\nnew file mode 100644\nindex 000000000000..48316f97cae1\n--- /dev/null\n+... | [
{
"diff_hunk": "@@ -87,6 +94,34 @@ def test_policy_priority():\n assert result == priority_2_result\n \n \n+def test_fallback_mapping_restart():\n+ domain = Domain.load(\"data/test_domains/default.yml\")\n+ events = [\n+ ActionExecuted(ACTION_DEFAULT_FALLBACK_NAME),\n+ utilities.user_utt... | 8b5857ad1cd72892c95ef19325d667261b9e9fab | diff --git a/changelog/4601.bugfix.rst b/changelog/4601.bugfix.rst
new file mode 100644
index 000000000000..2aef4a9ee83c
--- /dev/null
+++ b/changelog/4601.bugfix.rst
@@ -0,0 +1,2 @@
+Fixed issue with ``action_restart`` getting overridden by ``action_listen`` when the ``MappingPolicy`` and the
+`TwoStageFallbackPolicy ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
RasaHQ__rasa-4996@1d9251e | RasaHQ/rasa | Python | 4,996 | ConvertTokenizer, CLS token & features as sequence | **Proposed changes**:
- Add ConveRT Tokenizer
- Remove option `use_cls_token` from all tokenizers. Tokenizers add CLS token by default now.
- Remove option `return_sequence` from featurizers. Featurizers return sequence by default. The feature vector of the CLS token contains the feature for the complete utterance. ... | 2019-12-19T13:15:56Z | Tokenizer for ConveRT
Implement a tokenizer for ConveRT that allows us to use embedding for ConveRT in a sequence-fashion, for example, for the `CRFEntityExtractor`.
Problem: ConveRT tokenizes words into subwords and adds special characters. Thus, the token start and end does not match the entities. We need to work... | [
{
"body": "Implement a tokenizer for ConveRT that allows us to use embedding for ConveRT in a sequence-fashion, for example, for the `CRFEntityExtractor`. \r\n\r\nProblem: ConveRT tokenizes words into subwords and adds special characters. Thus, the token start and end does not match the entities. We need to wor... | 8a3606513723244b8b05ca91520a825efc561d4c | {
"head_commit": "1d9251eee82c8f274321f4611e3a36d8fdac4075",
"head_commit_message": "refactor intent tokenization",
"patch_to_review": "diff --git a/changelog/4978.feature.rst b/changelog/4978.feature.rst\nnew file mode 100644\nindex 000000000000..2bfa51326f8a\n--- /dev/null\n+++ b/changelog/4978.feature.rst\n@@ ... | [
{
"diff_hunk": "@@ -36,25 +36,15 @@ methods that you should implement:\n :linenos:\n \n .. note::\n- If you create a custom tokenizer you should have the following entry in your default dict.\n-\n- .. code-block:: none\n-\n- # add __CLS__ token to the end of the list of tokens\n- \"use_c... | 789c403b60091ee080321582a018b6ebbc7eb4ac | diff --git a/changelog/4978.feature.rst b/changelog/4978.feature.rst
new file mode 100644
index 000000000000..faacb0986fbd
--- /dev/null
+++ b/changelog/4978.feature.rst
@@ -0,0 +1,7 @@
+Add ``ConveRTTokenizer``.
+
+The tokenizer should be used whenever the ``ConveRTFeaturizer`` is used.
+
+Every tokenizer now supports... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
RasaHQ__rasa-5001@e05b48a | RasaHQ/rasa | Python | 5,001 | Do not dump untrainable entities to markdown | **Proposed changes**:
- fixes #4877
**Status (please check what you already did)**:
- [x] added some tests for the functionality
- [x] updated the documentation
- [x] updated the changelog (please check [changelog](https://github.com/RasaHQ/rasa/tree/master/changelog) for instructions)
- [x] reformat files usi... | 2019-12-19T15:27:34Z | MarkdownWriter shouldn't dump pre-trained entities
I noticed this on Rasa X, that if duckling or ner_spacy entities are recognised and you save it, these entities will get saved to the markdown file. These entities should be filtered out since we don't want to train the crf on it.
I'm not sure how we persist this t... | @akelad these entities aren't used for training of the CRF: https://github.com/RasaHQ/rasa/pull/898
I think dumping them should be okay then, no? we explicitly removed this from rasa X at some point ages ago: https://github.com/RasaHQ/nlu-trainer-backend/pull/42
@ricwo how does that work? We just exported the traini... | [
{
"body": "I noticed this on Rasa X, that if duckling or ner_spacy entities are recognised and you save it, these entities will get saved to the markdown file. These entities should be filtered out since we don't want to train the crf on it. \r\n\r\nI'm not sure how we persist this training data to the database... | 6b879b68a0de5bfbc9155296a908eebb4b9c0333 | {
"head_commit": "e05b48a883db176a6a7a2f1c4d7e083b6115e9ad",
"head_commit_message": "Merge branch 'md-dump-trainable-entities' of https://github.com/RasaHQ/rasa into md-dump-trainable-entities",
"patch_to_review": "diff --git a/changelog/4877.improvement.rst b/changelog/4877.improvement.rst\nnew file mode 100644\... | [
{
"diff_hunk": "@@ -49,3 +51,45 @@ def get_file_format(resource_name: Text) -> Text:\n return fformat\n \n return \"json\"\n+\n+\n+def remove_untrainable_entities_from(example: Dict[Text, Any]) -> None:\n+ \"\"\"Remove untrainable entities from serialised training example `example`.\n+\n+ Enti... | 861031820d81eff9742b99dabba32dba6dd65f50 | diff --git a/changelog/4877.improvement.rst b/changelog/4877.improvement.rst
new file mode 100644
index 000000000000..e279ea67e1c1
--- /dev/null
+++ b/changelog/4877.improvement.rst
@@ -0,0 +1,3 @@
+Entity examples that have been extracted using an external extractor are excluded
+from Markdown dumping in ``MarkdownWri... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
RasaHQ__rasa-5031@d801b4d | RasaHQ/rasa | Python | 5,031 | Add any_of helper method to component | **Proposed changes**:
- Add `one_of` to component. It allows you to say that the component requires either X, Y, or Z.
closes #5029
**Status (please check what you already did)**:
- [x] added some tests for the functionality
- [x] updated the documentation
- [ ] updated the changelog (please check [changelog]... | 2020-01-02T16:35:56Z | Add requries_one_of to custom NLU components
**Description of Problem**:
The `EmbeddingIntentClassifier` requires either `text_sparse_features` or `text_dense_features`. As long as one of them is present the classifier can be trained. However, if none is present, training will fail.
Currently, we only have the field ... | [
{
"body": "**Description of Problem**:\r\nThe `EmbeddingIntentClassifier` requires either `text_sparse_features` or `text_dense_features`. As long as one of them is present the classifier can be trained. However, if none is present, training will fail.\r\nCurrently, we only have the field `requires` to check if... | 89e5a4c8789b62d1dfb82f8656e7a5e83b11c2d0 | {
"head_commit": "d801b4d74193614d62a3d98a6319fd70f3373bff",
"head_commit_message": "update example component in test",
"patch_to_review": "diff --git a/changelog/5029.feature.rst b/changelog/5029.feature.rst\nnew file mode 100644\nindex 000000000000..986f85ce7a1b\n--- /dev/null\n+++ b/changelog/5029.feature.rst\... | [
{
"diff_hunk": "@@ -0,0 +1,5 @@\n+Add ``one_of`` to component. Should be used inside ``requires``.\n+\n+``one_of`` allows you to define multiple attributes of a message for a component.\n+At least one of those attributes needs to be present.\n+Otherwise, the component cannot be trained and an error is raised.",... | 28252189d36bb59762e10d581ae6200fe14487cb | diff --git a/changelog/5029.feature.rst b/changelog/5029.feature.rst
new file mode 100644
index 000000000000..f7fb1d7b2661
--- /dev/null
+++ b/changelog/5029.feature.rst
@@ -0,0 +1,5 @@
+Add ``any_of`` function to the ``Component`` class. Should be used inside ``requires``.
+
+``any_of`` allows you to define multiple a... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
NVIDIA__NeMo-4553@f7b21dc | NVIDIA/NeMo | Python | 4,553 | fix tarred dataset len when num shards is not divisible by workers | Signed-off-by: Iztok Lebar Bajec <ilb@fri.uni-lj.si>
# What does this PR do ?
Fixes #4522. When using tarred datasets and the number of shards is not divisible by `world_size`, nemo logs a warning, but training continues. However, in this case the computation of `DataLoader.len()` becomes incorrect. This leads to... | 2022-07-15T10:27:31Z | [NLP] punctuation_capitalization resume training fails
**Describe the bug**
When training PC from scratch, using the example configs, everything works fine, however if I try to resume an interrupted training from the last checkpoint, I get the following log entry
```
[NeMo W 2022-07-07 21:18:38 nemo_logging:349] /... | Installed `nemo` as you described and could not reproduce the bug. Could you please describe exact setting?
@itzsimpl
@PeganovAnton I apologise for taking so long, I was trying to debug. I haven't found the root cause, but by changing to pytorch:22.06-py3 and nemo:1.10.0, I don't see the issue anymore. I'll just conti... | [
{
"body": "**Describe the bug**\r\n\r\nWhen training PC from scratch, using the example configs, everything works fine, however if I try to resume an interrupted training from the last checkpoint, I get the following log entry\r\n```\r\n[NeMo W 2022-07-07 21:18:38 nemo_logging:349] /opt/conda/lib/python3.8/site... | faf8ad83cbad28ab8aa509caa404e720a1e42378 | {
"head_commit": "f7b21dc59480d30be28f24b599a01b67f19c25f2",
"head_commit_message": "fix style",
"patch_to_review": "diff --git a/docs/source/asr/datasets.rst b/docs/source/asr/datasets.rst\nindex 364c7fea1926..cd4ebc3f9a02 100644\n--- a/docs/source/asr/datasets.rst\n+++ b/docs/source/asr/datasets.rst\n@@ -1,7 +1... | [
{
"diff_hunk": "@@ -210,16 +210,22 @@ of filepaths, e.g. ``['/data/shard1.tar', '/data/shard2.tar']``, or in a single\n ``'/data/shard_{1..64}.tar'`` or ``'/data/shard__OP_1..64_CL_'`` (recommended, see note below).\n \n .. note::\n- For brace expansion, there may be cases where ``{x..y}`` syntax cannot be use... | 9f4d16e6f2700214213ad2b51510c548a0f60a88 | diff --git a/docs/source/asr/datasets.rst b/docs/source/asr/datasets.rst
index 364c7fea1926..8878d66ae739 100644
--- a/docs/source/asr/datasets.rst
+++ b/docs/source/asr/datasets.rst
@@ -1,7 +1,7 @@
Datasets
========
-NeMo has scripts to convert several common ASR datasets into the format expected by the ``nemo_asr... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
PaddlePaddle__PaddleSpeech-2667@b6ccd47 | PaddlePaddle/PaddleSpeech | Python | 2,667 | [TTS]Add TTS Paddle-Lite x86 inference | fix https://github.com/PaddlePaddle/PaddleSpeech/issues/2487 | 2022-11-18T06:58:45Z | [TTS]PaddleLite&MNN离线推理转换问题
想把TTS做离线，尝试了以下两种方式：
## 1、MNN转换：fastspeech2_mix onnx模型错误
`
Error for compute convolution shape, inputCount:1536, outputCount:384, KH:1, KW:3, group:1
inputChannel: 0, batch:1536, width:0, height:0. Input data channel may be mismatch with filter channel count
`
## 2、PaddleLite转换：显示不支... | MNN 不了解是什么，方便发点资料看下嘛，计划下季度做一些 TTS 模型导出 PaddleLite 模型的工作，目前暂时没有相关经验
搜了下 MNN, MNN 相关的东西可能你要去他们的 [repo](https://github.com/alibaba/MNN) 问了，PaddleSpeech 已经负责把模型转换为通用的 ONNX 格式了，后续的模型转化需要开发者自己完成，PaddleLite 相关转换我们会在下个季度和 PaddleLite 的同学一起尝试解决
> 搜了下 MNN, MNN 相关的东西可能你要去他们的 [repo](https://github.com/alibaba/MNN) 问了，PaddleSpeech 已... | [
{
"body": "想把TTS做离线，尝试了以下两种方式：\r\n## 1、MNN转换：fastspeech2_mix onnx模型错误\r\n\r\n`\r\nError for compute convolution shape, inputCount:1536, outputCount:384, KH:1, KW:3, group:1\r\ninputChannel: 0, batch:1536, width:0, height:0. Input data channel may be mismatch with filter channel count\r\n`\r\n\r\n## 2、PaddleLite... | dc9d3baf51011224a0e1f3e59883d61105f1c94a | {
"head_commit": "b6ccd47e7ce3d60ca64216d39f15f44d2c9f1dea",
"head_commit_message": "add paddlelite in setup.py",
"patch_to_review": "diff --git a/docs/source/released_model.md b/docs/source/released_model.md\nindex 45193701dff..9f0c2bea609 100644\n--- a/docs/source/released_model.md\n+++ b/docs/source/released_m... | [
{
"diff_hunk": "@@ -510,3 +512,106 @@ def get_sess(model_path: Optional[os.PathLike],\n sess = ort.InferenceSession(\n model_path, providers=providers, sess_options=sess_options)\n return sess\n+\n+\n+# Paddle-Lite\n+def get_lite_predictor(model_dir: Optional[os.PathLike]=None,\n+ ... | b4065412b7afd98acb8b950e28214e161854e71f | diff --git a/docs/source/released_model.md b/docs/source/released_model.md
index 45193701dff..9f0c2bea609 100644
--- a/docs/source/released_model.md
+++ b/docs/source/released_model.md
@@ -40,37 +40,35 @@ Language Model | Training Data | Token-based | Size | Descriptions
## Text-to-Speech Models
### Acoustic Models... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
RasaHQ__rasa-4935@2df3b36 | RasaHQ/rasa | Python | 4,935 | Updated featurizers | **Proposed changes**:
- Add option ``use_cls_token`` to all tokenizers. If it is set to ``True``, the token ``__CLS__`` will be added to the end of the list of tokens.
- Add option ``return_sequence`` to all featurizers. By default all featurizers return a matrix of size
(1 x feature-dimension). If the option ``retu... | 2019-12-10T14:21:48Z | Replace ner_features by text_dense_features
If you wanted to use additional features in the CRFEntityExtractor you had to add ``ner_features`` to the feature list of the entity extractor. Additionally, you need a featurizer that actually sets those features. The main difference of those features are, that they should c... | [
{
"body": "If you wanted to use additional features in the CRFEntityExtractor you had to add ``ner_features`` to the feature list of the entity extractor. Additionally, you need a featurizer that actually sets those features. The main difference of those features are, that they should come as a sequence.\r\n\r\... | 7f8e3e44e550dc519c82b4cc00fb9a616daf4b30 | {
"head_commit": "2df3b367d1f784ab554504dfdfebdbc46d83adc0",
"head_commit_message": "update model version",
"patch_to_review": "diff --git a/changelog/4935.feature.rst b/changelog/4935.feature.rst\nnew file mode 100644\nindex 000000000000..33c5ee7cd50e\n--- /dev/null\n+++ b/changelog/4935.feature.rst\n@@ -0,0 +1,... | [
{
"diff_hunk": "@@ -0,0 +1,131 @@\n+import numpy as np\n+import typing\n+from typing import Any, List, Text, Dict\n+\n+from rasa.nlu.config import RasaNLUModelConfig\n+from rasa.nlu.featurizers.featurzier import Featurizer\n+from rasa.nlu.tokenizers.tokenizer import Token\n+from rasa.nlu.training_data import Me... | 225320062ecc0cd5255ab2b550cea0258798da67 | diff --git a/changelog/4935.feature.rst b/changelog/4935.feature.rst
new file mode 100644
index 000000000000..13a62e090661
--- /dev/null
+++ b/changelog/4935.feature.rst
@@ -0,0 +1,15 @@
+Preparation for an upcoming change in the ``EmbeddingIntentClassifier``:
+
+Add option ``use_cls_token`` to all tokenizers. If it is... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
PaddlePaddle__PaddleSpeech-2235@1edd474 | PaddlePaddle/PaddleSpeech | Python | 2,235 | add filter for double punctuation in sentences; add homonym, test=tts | fix https://github.com/PaddlePaddle/PaddleSpeech/issues/2232 | 2022-08-09T10:01:44Z | when process english text with !" , get error
English text: The girls stared at their father. Mrs. Bennet said only, "Nonsense, nonsense!"
remove ! then the error disappeared.
Error Log:
Traceback (most recent call last):
File "readText_Paddle.py", line 1175, in <module>
englishTxt2WavbyPaddle(mp3file... | 大概知道问题所在，因为 !" 是 2 个连续的标点，中间其实被拆出来一个为空的句子，所以报错了, 应该在某个位置加个判空就行了, 欢迎开发者提交 pr 修改
<img width="310" alt="image" src="https://user-images.githubusercontent.com/24568452/183379668-fd479fcc-0323-4138-b1e3-6b201bf75319.png"> | [
{
"body": "English text: The girls stared at their father. Mrs. Bennet said only, \"Nonsense, nonsense!\"\r\n\r\nremove ! then the error disappeared.\r\n\r\nError Log:\r\n\r\nTraceback (most recent call last):\r\n File \"readText_Paddle.py\", line 1175, in <module>\r\n englishTxt2WavbyPaddle(mp3filepath,te... | 2f9bdf2306d15f32677dcbf87009c45750312373 | {
"head_commit": "1edd474bcb00939e06269b52b34792b5ee697b0f",
"head_commit_message": "add filter for double punctuation in sentences; add homonym, test=tts",
"patch_to_review": "diff --git a/paddlespeech/t2s/frontend/phonectic.py b/paddlespeech/t2s/frontend/phonectic.py\nindex 8e9f11737d1..ff8c149afb5 100644\n--- ... | [
{
"diff_hunk": "@@ -94,10 +94,12 @@ def __init__pypinyin(self):\n large_pinyin.load()\n \n load_phrases_dict({u'开户行': [[u'ka1i'], [u'hu4'], [u'hang2']]})\n+ load_phrases_dict({u'俩个':[[u'lia3ng'],[u'ge4']]})\n load_phrases_dict({u'发卡行': [[u'fa4'], [u'ka3'], [u'hang2']]})\n ... | 0df7fc8fbf8ab0829661f96cacddf9c72ce43c39 | diff --git a/paddlespeech/t2s/frontend/phonectic.py b/paddlespeech/t2s/frontend/phonectic.py
index 8e9f11737d1..7ec821ed5e5 100644
--- a/paddlespeech/t2s/frontend/phonectic.py
+++ b/paddlespeech/t2s/frontend/phonectic.py
@@ -99,7 +99,8 @@ def get_input_ids(self, sentence: str,
if (phn in self.vocab_pho... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
RasaHQ__rasa-4699@7561b4d | RasaHQ/rasa | Python | 4,699 | Tracker fallback | **Proposed changes**:
- fix https://github.com/RasaHQ/rasa/issues/3243
- add `FailSafeTrackerStore` which wraps the actual tracker store and falls back to a `InMemoryTrackerStore` in case there is any problem
- use `InMemoryTrackerStore` in case there is a problem during the initialization of the tracker store
**... | 2019-10-30T15:02:11Z | Fallback to InMemory tracker store if mongo / sql / redis is not reachable
If you defined an external tracker store, and the tracker store is not reachable, Rasa should automatically fallback to use the InmemoryTrackerStore. Otherwise this leads to weird behavior. | This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
@akelad Should we just do this at the initial connection attempt or also when the tracker store crashes somewhere in between? As far as I remember... | [
{
"body": "If you defined an external tracker store, and the tracker store is not reachable, Rasa should automatically fallback to use the InmemoryTrackerStore. Otherwise this leads to weird behavior.",
"number": 3243,
"title": "Fallback to InMemory tracker store if mongo / sql / redis is not reachable"... | 08298a42193aca1f1399b75d7f0a50d9ee4a2d57 | {
"head_commit": "7561b4d163143132c8eb0191f8cd7dc38357a10e",
"head_commit_message": "add types",
"patch_to_review": "diff --git a/CHANGELOG.rst b/CHANGELOG.rst\nindex 183835a6d36b..f69a0c3f21f9 100644\n--- a/CHANGELOG.rst\n+++ b/CHANGELOG.rst\n@@ -14,6 +14,8 @@ This project adheres to `Semantic Versioning`_ start... | [
{
"diff_hunk": "@@ -827,6 +831,14 @@ def create_processor(\n message_preprocessor=preprocessor,\n )\n \n+ def on_tracker_store_error(self, error: Exception) -> None:",
"line": null,
"original_line": 834,
"original_start_line": null,
"path": "rasa/core/agent.py",
"start... | ce4794492c100c4e0ff9da8ce8bdec8019da4fe7 | diff --git a/CHANGELOG.rst b/CHANGELOG.rst
index 493b76c42aec..3fbfebf318a8 100644
--- a/CHANGELOG.rst
+++ b/CHANGELOG.rst
@@ -14,6 +14,8 @@ This project adheres to `Semantic Versioning`_ starting with version 1.0.
Added
-----
- Added the KeywordIntentClassifier
+- Fall back to ``InMemoryTrackerStore`` in case there... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
RasaHQ__rasa-4661@ea6cee7 | RasaHQ/rasa | Python | 4,661 | Exit early if domain file is invalid | **Proposed changes**:
Closes #4619
* The command `rasa data validate` must exit early if the domain can't be loaded, avoiding a bunch of errors to be shown.
**Expected behavior**:
* If the domain file is configurated as shown below:
```
intents:
- greet
actions:
- utter_greet
- utter_greet
templa... | 2019-10-23T11:18:54Z | rasa data validate should fail early if domain cannot be read
**Description of Problem**:
Currently, if there is a syntax error in your domain, `rasa data validate` will load an empty domain and return a whole bunch of errors. Not super user friendly because you have to scroll through a bunch of errors to get to the t... | I would like to work on this. Are you already assigned to this, @amn41?
certainly not! would be awesome if you could work on it :) | [
{
"body": "**Description of Problem**:\r\nCurrently, if there is a syntax error in your domain, `rasa data validate` will load an empty domain and return a whole bunch of errors. Not super user friendly because you have to scroll through a bunch of errors to get to the top and see that yaml parsing failed. \r\n... | 3374f4eb8572cbe1bc3ad1465f466e7ba22ace6d | {
"head_commit": "ea6cee7c8714890176bd8241f15f4300bcab04e2",
"head_commit_message": "Merge branch 'master' into exit_early_if_domain_empty",
"patch_to_review": "diff --git a/CHANGELOG.rst b/CHANGELOG.rst\nindex 99e93a1546a4..a2014fd940ab 100644\n--- a/CHANGELOG.rst\n+++ b/CHANGELOG.rst\n@@ -13,6 +13,7 @@ This pro... | [
{
"diff_hunk": "@@ -63,3 +66,12 @@ def test_data_validate_help(run: Callable[..., RunResult]):\n \n for i, line in enumerate(lines):\n assert output.outlines[i] == line\n+\n+\n+def test_validate_files_exit_early():\n+ with pytest.raises(SystemExit) as pytest_e:\n+ args = {\"domain\": \"dat... | 4f61b3ca0a7976d7688a78d54e608a36e8e32473 | diff --git a/CHANGELOG.rst b/CHANGELOG.rst
index 99e93a1546a4..a2014fd940ab 100644
--- a/CHANGELOG.rst
+++ b/CHANGELOG.rst
@@ -13,6 +13,7 @@ This project adheres to `Semantic Versioning`_ starting with version 1.0.
Added
-----
+- Added data validator that checks if domain object returned is empty. If so, exit early... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
RasaHQ__rasa-4598@c1e70d0 | RasaHQ/rasa | Python | 4,598 | Add validation for duplicated data example in multiple intents | Closes #4566
**Proposed changes**:
- The command `rasa data validate` checks there is no duplicated example data at nlu file.
**Expected Behavior**:
- nlu data file has some intents as shown:
```
## intent:greet
- hello
## intent:goodbye
- hello
```
- The following warning should be displayed when runni... | 2019-10-11T02:26:50Z | Utterance Replication Checker
**Description of Problem**:
I just wonder, if Rasa would have an feature which checks if an utterances added before to the training set before. If so, it may warn the developer. This enables utterance duplication/replication in the training set. Otherwise same utterance may be added to di... | this would be a nice addition to the `rasa data validate` command https://rasa.com/docs/rasa/user-guide/validate-files/#validate-files - would you be up for contributing this ? | [
{
"body": "**Description of Problem**:\r\nI just wonder, if Rasa would have an feature which checks if an utterances added before to the training set before. If so, it may warn the developer. This enables utterance duplication/replication in the training set. Otherwise same utterance may be added to different i... | 15e3ab41dfcc0dd6c5188d0a54d3086dacb1ac70 | {
"head_commit": "c1e70d09af48f653a5ec7f7812c3e88005c9d171",
"head_commit_message": "Added docs for validator that checks duplication in distinct intents\n\nSigned-off-by: Vinicius Lima <vfbdelima@gmail.com>",
"patch_to_review": "diff --git a/CHANGELOG.rst b/CHANGELOG.rst\nindex 0e406f2f6313..5022563066f6 100644\... | [
{
"diff_hunk": "@@ -57,13 +58,43 @@ def verify_intents(self, ignore_warnings: bool = True) -> bool:\n \n return everything_is_alright\n \n+ def verify_example_repetition_in_intents(\n+ self, ignore_warnings: bool = True\n+ ) -> bool:\n+ \"\"\"Checks if there is no duplicated example ... | c72a5e420089a4baa70e4dd0a7b2e6bfbba18e9b | diff --git a/CHANGELOG.rst b/CHANGELOG.rst
index adcf461f44a3..9fb95501d1b0 100644
--- a/CHANGELOG.rst
+++ b/CHANGELOG.rst
@@ -29,6 +29,7 @@ Added
environment variable ``SANIC_WORKERS`` (default: 1). A value of >1 is allowed only in
combination with ``RedisLockStore`` as the lock store.
- Botframework channel ca... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
NVIDIA__NeMo-2285@a6790f7 | NVIDIA/NeMo | Python | 2,285 | Audio Norm | - added jenkins tests for the normalization_with_audio script (text only, text + audio, manifest)
- all default normalization unit tests will be executed for normalization with audio as well
- added serial class to the default normalization (deterministic): using single digits by default
- addressed [this](https://g... | 2021-05-28T23:24:59Z | Normalizer and NormalizerWithAudio fail with dashed tokens eg "550-pound bomb"
**Describe the bug**
Example sentence fragments for text normalizer:
"It had 12-inch guns and a 21-knot cruising speed."
"Each 550-pound bomb exploded."
**Steps/Code to reproduce bug**
```python
from nemo_text_processing.text_nor... | The taggers pick these examples up as Serials and not as Measures. The options with the spaces between the letters make sense if it's a Serial.
I think a modification to the tagger for Measure that allows the dash between Cardinal and Unit may do the trick. If I can figure out the syntax...
Yes, this is a known issu... | [
{
"body": "**Describe the bug**\r\n\r\nExample sentence fragments for text normalizer:\r\n\"It had 12-inch guns and a 21-knot cruising speed.\"\r\n\"Each 550-pound bomb exploded.\"\r\n\r\n**Steps/Code to reproduce bug**\r\n\r\n```python\r\nfrom nemo_text_processing.text_normalization.normalize import Normalizer... | 020d925437977aabbb5d7584d2f120c97abc277e | {
"head_commit": "a6790f7dfc1a4580ed32ac2d56235c5b42220649",
"head_commit_message": "add serial to the default normalizer, add tests\n\nSigned-off-by: ekmb <ebakhturina@nvidia.com>",
"patch_to_review": "diff --git a/Jenkinsfile b/Jenkinsfile\nindex ba2e3606e5a5..3daec034db46 100644\n--- a/Jenkinsfile\n+++ b/Jenki... | [
{
"diff_hunk": "@@ -101,6 +102,25 @@ def __init__(self, cardinal: GraphFst, decimal: GraphFst, deterministic: bool =\n + pynutil.insert(\" } \")\n + unit_singular\n )\n- final_graph = subgraph_decimal | subgraph_cardinal\n+\n+ subgraph_cardinal_dash = (\n+ ... | 3169d7f4e52120035a00139e467239a41891c08f | diff --git a/Jenkinsfile b/Jenkinsfile
index 6e4cac06d851..3a2f362ecec3 100644
--- a/Jenkinsfile
+++ b/Jenkinsfile
@@ -167,6 +167,32 @@ pipeline {
sh 'rm -rf /home/TestData/nlp/text_denorm/output/*'
}
}
+ stage('L2: TN with Audio (audio and raw text)') {
+ steps {
+ ... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
RasaHQ__rasa-4316@6f6b922 | RasaHQ/rasa | Python | 4,316 | Exclude 'no-entity' from NER evaluation | **Proposed changes**:
- evaluation of NER does not consider 'no-enity' anymore
closes #4313
**Status (please check what you already did)**:
- [x] made PR ready for code review
- [x] added some tests for the functionality
- [ ] updated the documentation
- [x] updated the changelog
- [x] reformat files using `... | 2019-08-23T13:17:00Z | Evaluation of NER: Don't include 'no-entity'
Currently, we take the weighted precision and f1 score as performance metric for our named entity recognition. Weighted means
> Calculate metrics for each label, and find their average weighted
> by support (the number of true instances for each label). This
> alters 'm... | [
{
"body": "Currently, we take the weighted precision and f1 score as performance metric for our named entity recognition. Weighted means\r\n\r\n> Calculate metrics for each label, and find their average weighted\r\n> by support (the number of true instances for each label). This\r\n> alters 'macro' to account f... | 9a75a8ba2e48041d84b77cb93644568832359d09 | {
"head_commit": "6f6b9221ae5dbd3010283efbaa0785e36d1a4295",
"head_commit_message": "check if labels empty",
"patch_to_review": "diff --git a/CHANGELOG.rst b/CHANGELOG.rst\nindex 4814e510338c..fb55b2873b25 100644\n--- a/CHANGELOG.rst\n+++ b/CHANGELOG.rst\n@@ -47,6 +47,7 @@ Changed\n hold out validation set that... | [
{
"diff_hunk": "@@ -173,7 +176,7 @@ def get_evaluation_metrics(\n return report, precision, f1, accuracy\n \n \n-def get_label_set(targets: Iterable[Any], exclude_label: Optional[Text]):\n+def get_label_set(targets: Iterable[Any], exclude_label: Optional[Text]) -> List[Text]:",
"line": null,
"origin... | 84e8029fef9995faecdc666086c6bea486566005 | diff --git a/CHANGELOG.rst b/CHANGELOG.rst
index 4814e510338c..fb55b2873b25 100644
--- a/CHANGELOG.rst
+++ b/CHANGELOG.rst
@@ -47,6 +47,7 @@ Changed
hold out validation set that is excluded from training data
- defaults parameters and architectures for both ``EmbeddingPolicy`` and
``EmbeddingIntentClassifier`` a... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
RasaHQ__rasa-4363@d8b2fe1 | RasaHQ/rasa | Python | 4,363 | Add option to output interactive learning stories in e2e format | **Proposed changes**:
- Fixes #3410
**Status (please check what you already did)**:
- [x] made PR ready for code review
- [ ] added some tests for the functionality
- [ ] updated the documentation
- [x] updated the changelog
- [x] reformat files using `black` (please check [Readme](https://github.com/RasaHQ/r... | 2019-08-31T11:00:25Z | optionally output interactive learning stories in e2e format
In interactive learning, we already have user input and the intent, validated by the user. We could output these stories in end-to-end format if the user desires so that they don't have to write e2e stories or turn regular ones into e2e ones on their own.
... | @erohmensing Hi, i would like to work on this.
Awesome, @chidauri! Let me know if you need any help. I think [this function](https://github.com/RasaHQ/rasa/blob/0354dcf1dc46689f048d3f7dbfca51b6d27e638d/rasa/core/events/__init__.py#L289) will be super useful! | [
{
"body": "In interactive learning, we already have user input and the intent, validated by the user. We could output these stories in end-to-end format if the user desires so that they don't have to write e2e stories or turn regular ones into e2e ones on their own.\r\n\r\nPerhaps this could happen under the fl... | 316b3c410fe6eaaba25c8c14c6dc4c31cacf0fc8 | {
"head_commit": "d8b2fe1fdd857dc1b2b233c30b3d3ad99a25faca",
"head_commit_message": "code refactoring",
"patch_to_review": "diff --git a/rasa/cli/interactive.py b/rasa/cli/interactive.py\nindex 0a4a01ea7258..6e34a5cba3ae 100644\n--- a/rasa/cli/interactive.py\n+++ b/rasa/cli/interactive.py\n@@ -29,6 +29,9 @@ def a... | [
{
"diff_hunk": "@@ -29,6 +29,9 @@ def add_subparser(\n \"Rasa model by chatting.\",\n )\n interactive_parser.set_defaults(func=interactive)\n+ interactive_parser.add_argument(\n+ \"--e2e\", action=\"store_true\", help=\"save file in e2e format\"",
"line": null,
"original_line":... | 32ae574c773becc42ed0ebf3dec97523ae3d7888 | diff --git a/CHANGELOG.rst b/CHANGELOG.rst
index 7c3a9aba27da..05f4c788fc86 100644
--- a/CHANGELOG.rst
+++ b/CHANGELOG.rst
@@ -12,6 +12,7 @@ This project adheres to `Semantic Versioning`_ starting with version 1.0.
Added
-----
+- option to save stories in e2e format for interactive learning
- bot messages contain ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
RasaHQ__rasa-4251@2e9fcd7 | RasaHQ/rasa | Python | 4,251 | Avoid retraining Core model if only templates section is changed | **Proposed changes**:
- Fix #4216
**Status (please check what you already did)**:
- [x] made PR ready for code review
- [x] added some tests for the functionality
- [ ] updated the documentation
- [x] updated the changelog
- [x] reformat files using `black` (please check [Readme](https://github.com/RasaHQ/ras... | 2019-08-15T06:01:13Z | The whole Core model is retrained even if only the templates section is changed
**Description of Problem**:
Having to retrain the Core ML model every time templates are changed is unnecessary and can be very expensive for a large project with lots of stories.
**Overview of the Solution**:
Create a separate, more g... | This is the default behavior; the way to avoid retraining with template changes is to use an [External CMS](https://rasa.com/docs/rasa/core/responses/#managing-assistant-utterances-using-an-external-cms).
If there are no changes to the domain or the training data Rasa already prevents redundant training.
> This is ... | [
{
"body": "**Description of Problem**:\r\nHaving to retrain the Core ML model every time templates are changed is unnecessary and can be very expensive for a large project with lots of stories.\r\n\r\n**Overview of the Solution**:\r\nCreate a separate, more granular fingerprint for the templates section in the ... | 7fcfdd9eaa8704dc44ecbdb2927eb1a07b10d333 | {
"head_commit": "2e9fcd785ac9dfb3fb34f975ef4387c27aa556b4",
"head_commit_message": "remove leading whitespace",
"patch_to_review": "diff --git a/CHANGELOG.rst b/CHANGELOG.rst\nindex 039a28f2a612..950e981c3221 100644\n--- a/CHANGELOG.rst\n+++ b/CHANGELOG.rst\n@@ -15,6 +15,7 @@ Added\n \n Changed\n -------\n+- Do ... | [
{
"diff_hunk": "@@ -340,42 +375,60 @@ def merge_model(source: Text, target: Text) -> bool:\n shutil.move(source, target)\n return True\n except Exception as e:\n- logging.debug(e)\n+ logging.debug(f\"Could not merge model: {e}\")\n return False\n \n \n-def should_retrai... | 422e08f0fc74bf8b41fe43766d0021dad6e6af7b | diff --git a/CHANGELOG.rst b/CHANGELOG.rst
index 183835a6d36b..493b76c42aec 100644
--- a/CHANGELOG.rst
+++ b/CHANGELOG.rst
@@ -17,6 +17,7 @@ Added
Changed
-------
+- Do not retrain the entire Core model if only the ``templates`` section of the domain is changed.
Removed
-------
@@ -228,7 +229,6 @@ Changed
----... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Performance Optimizations"
} |
RasaHQ__rasa-4094@da09ca9 | RasaHQ/rasa | Python | 4,094 | fix 'rasa test core' | **Proposed changes**:
- Add flag `--evaluate-models-in-dir` to test command `rasa test core` to be able to compare models that were trained via `rasa train core -c <config-1> <config-2>`
- `rasa test core` can handle compressed model files
- moved utils methods (`list_files`, `list_subdirectories`, `list_directory`,... | 2019-07-24T08:46:42Z | Rasa Core comparison mode does not work with tar models
`rasa test core -m models/20190715-223529.tar.gz models/20190715-223529.tar.gz` does not work because
- the agent get's a domain which is `None` which in turn leads to an error
- `compare` expects a uncompressed models | [
{
"body": "`rasa test core -m models/20190715-223529.tar.gz models/20190715-223529.tar.gz` does not work because\r\n\r\n- the agent get's a domain which is `None` which in turn leads to an error\r\n- `compare` expects a uncompressed models",
"number": 4016,
"title": "Rasa Core comparison mode does not w... | b01582e0acd83152a309d39273e636134efc9c86 | {
"head_commit": "da09ca9a0568ba8e4b08e24c238e7455629111db",
"head_commit_message": "Update default percentages.",
"patch_to_review": "diff --git a/CHANGELOG.rst b/CHANGELOG.rst\nindex 412f79e7f0d9..d1af071496ae 100644\n--- a/CHANGELOG.rst\n+++ b/CHANGELOG.rst\n@@ -11,6 +11,7 @@ This project adheres to `Semantic ... | [
{
"diff_hunk": "@@ -88,7 +88,7 @@ def add_compare_params(\n \"--percentages\",\n nargs=\"*\",\n type=int,\n- default=[0, 5, 25, 50, 70, 90, 95],\n+ default=[25, 50, 75, 90],",
"line": null,
"original_line": 91,
"original_start_line": null,
"path": "rasa/cli/... | d0b5d48d6942892a33338f8682d3662e0e5e0594 | diff --git a/CHANGELOG.rst b/CHANGELOG.rst
index f0f92839412b..ef5597b0219c 100644
--- a/CHANGELOG.rst
+++ b/CHANGELOG.rst
@@ -12,6 +12,7 @@ This project adheres to `Semantic Versioning`_ starting with version 1.0.
Added
-----
+- add ``--evaluate-model-directory`` to ``rasa test core`` to evaluate models from ``ras... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
RasaHQ__rasa-4097@69ca534 | RasaHQ/rasa | Python | 4,097 | Add new SQL event broker and use it for local Rasa X | **Proposed changes**:
- Create a new event broker, `SQLProducer` (inherits from `EventChannel`).
- Use `SQLProducer` when running Rasa X in local mode. Any event tracker can be used.
- If the user wants to run Rasa X locally with a different event broker than `SQLProducer`, ask them if they want to change it to `SQL... | 2019-07-24T14:59:36Z | SQLite event stream
Currently we are using the sqlite tracker store to stream events from Rasa to Rasa X. This has the downside, that Rasa X locally only works with the sqlite db.
Instread of using the sqlite tracker store to access the events, there should be a separate `EventChannel` implementation which dumps the... | @federicotdn Please update the ticket status | [
{
"body": "Currently we are using the sqlite tracker store to stream events from Rasa to Rasa X. This has the downside, that Rasa X locally only works with the sqlite db.\r\n\r\nInstread of using the sqlite tracker store to access the events, there should be a separate `EventChannel` implementation which dumps ... | d0f7920f1d949fc8df7e117a292f7863e4f9f53f | {
"head_commit": "69ca534216fe43853c65574865a9f552162eccdc",
"head_commit_message": "Update changelog.",
"patch_to_review": "diff --git a/.gitignore b/.gitignore\nindex e0ab574cf4a3..5a141e842565 100644\n--- a/.gitignore\n+++ b/.gitignore\n@@ -80,4 +80,5 @@ examples/moodbot/models*\n docs/core/key \n docs/core/ke... | [
{
"diff_hunk": "@@ -223,3 +225,52 @@ def _publish(self, event):\n \n def _close(self):\n self.producer.close()\n+\n+\n+class SQLProducer(EventChannel):\n+ from sqlalchemy.ext.declarative import declarative_base\n+\n+ Base = declarative_base()\n+\n+ class SQLEvent(Base):\n+ from sqlal... | 726cd85808c5908cf1bec9560fa18ac244883d8b | diff --git a/.gitignore b/.gitignore
index e0ab574cf4a3..fd2ad0f189e6 100644
--- a/.gitignore
+++ b/.gitignore
@@ -80,4 +80,5 @@ examples/moodbot/models*
docs/core/key
docs/core/key.pub
failed_stories.md
-errors.json
\ No newline at end of file
+errors.json
+events.db
diff --git a/CHANGELOG.rst b/CHANGELOG.rst
inde... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
RasaHQ__rasa-4092@7ff5449 | RasaHQ/rasa | Python | 4,092 | Create metadata UserMessage attribute | Signed-off-by: ArthurTemporim <arthurrtl@gmail.com>
Fixes #3199
**Proposed changes**:
- Add `metadata` attribute to UserMessage
**Status (please check what you already did)**:
- [x] made PR ready for code review
- [x] added some tests for the functionality
- [x] updated the documentation
- [x] updated th... | 2019-07-24T03:15:27Z | add metadata field to user message
We should a metadata field to the user message class so that you can add custom information (tokens, user info) to the user message in the input channel and use it in custom actions.
- [x] Add field in UserMessage class
- [x] Make sure it does not get dropped on the way to the act... | Yes I am blocked right now because my external Api call in my custom action needs an access token for every user so this field may be a solution.
You can set an unfeaturized slot at the start by calling the core's event http endpoint (conversations/<sender_id>/tracker/events)
I think we should add this to the `UserUt... | [
{
"body": "We should a metadata field to the user message class so that you can add custom information (tokens, user info) to the user message in the input channel and use it in custom actions.\r\n\r\n- [x] Add field in UserMessage class\r\n- [x] Make sure it does not get dropped on the way to the action server... | 2c4e8f4ee930f3b2310c093e3f5f003d5a49c9cf | {
"head_commit": "7ff544901df0e945143c66389d0084b288a537f1",
"head_commit_message": "Improve docstring of UserMessage\n\nSigned-off-by: ArthurTemporim <arthurrtl@gmail.com>",
"patch_to_review": "diff --git a/CHANGELOG.rst b/CHANGELOG.rst\nindex 938e9ba516ef..1ea92afe410b 100644\n--- a/CHANGELOG.rst\n+++ b/CHANGEL... | [
{
"diff_hunk": "@@ -206,14 +208,17 @@ def __init__(\n super(UserUttered, self).__init__(timestamp)\n \n @staticmethod\n- def _from_parse_data(text, parse_data, timestamp=None, input_channel=None):\n+ def _from_parse_data(\n+ text, parse_data, timestamp=None, input_channel=None, metadata... | 2a3a9756589674f76cb6f113065540934f517f0d | diff --git a/CHANGELOG.rst b/CHANGELOG.rst
index b4f5f2372847..8b833c04eb22 100644
--- a/CHANGELOG.rst
+++ b/CHANGELOG.rst
@@ -24,6 +24,7 @@ Changed
- API requests are not longer logged to ``rasa_core.log`` by default in order to avoid
problems when running on OpenShift (use ``--log-file rasa_core.log`` to retain t... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
RasaHQ__rasa-4054@cbb1ace | RasaHQ/rasa | Python | 4,054 | Update pytype version | Signed-off-by: ArthurTemporim <arthurrtl@gmail.com>
Fixes #3860
**Proposed changes**:
- Update pytype version from `2019.5.31` to `2019.7.11`.
**Status (please check what you already did)**:
- [x] made PR ready for code review
- [ ] added some tests for the functionality
- [ ] updated the documentation
- ... | 2019-07-19T21:51:53Z | Update pytype version
With pytype version `2019.6.21`, the Travis build fails with the following error message:
```
[27/239] check rasa.core.channels.channel
FAILED: /home/travis/build/RasaHQ/rasa/.pytype/pyi/rasa/core/channels/channel.pyi
pytype-single --imports_info /home/travis/build/RasaHQ/rasa/.pytype/imports... | @federicotdn that's covered by https://github.com/RasaHQ/rasa/pull/3994 , isn't it?
https://github.com/RasaHQ/rasa/pull/3994 pins the pytype version, but does not update it.
@federicotdn I have updated the pytype version to `2019.7.11` and the error is the same. But I just added `result = None` [here](https://github.co... | [
{
"body": "With pytype version `2019.6.21`, the Travis build fails with the following error message:\r\n```\r\n[27/239] check rasa.core.channels.channel\r\nFAILED: /home/travis/build/RasaHQ/rasa/.pytype/pyi/rasa/core/channels/channel.pyi \r\npytype-single --imports_info /home/travis/build/RasaHQ/rasa/.pytype/im... | 7e1fe610c7b227651cd46d05c41614ddb60c64ce | {
"head_commit": "cbb1acef85be8c47e1753e6b9d8df5fb5c0651ef",
"head_commit_message": "Merge branch 'master' of github.com:RasaHQ/rasa into improve_pytype",
"patch_to_review": "diff --git a/CHANGELOG.rst b/CHANGELOG.rst\nindex b9e780a4950e..c0cbe8573306 100644\n--- a/CHANGELOG.rst\n+++ b/CHANGELOG.rst\n@@ -17,6 +17... | [
{
"diff_hunk": "@@ -412,8 +412,9 @@ def stream_response(\n on_new_message, text, q, sender_id, input_channel\n )\n )\n+ result = None",
"line": null,
"original_line": 415,
"original_start_line": null,
"path": "rasa/core/channels/channel.... | 2db6ba6d2d9d359427634b098d183143bde5086a | diff --git a/CHANGELOG.rst b/CHANGELOG.rst
index e6db607461fc..55a84b31cff9 100644
--- a/CHANGELOG.rst
+++ b/CHANGELOG.rst
@@ -18,6 +18,7 @@ Changed
-------
- ``Agent.update_model()`` and ``Agent.handle_message()`` now work without needing to set a domain
or a policy ensemble
+- Update pytype to ``2019.7.11``
R... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Dependency Updates & Env Compatibility"
} |
RasaHQ__rasa-3965@a1cf4f7 | RasaHQ/rasa | Python | 3,965 | make sure new intents, actions, and utterances are non-empty | **Proposed changes**:
- a new questionary validator to check whether the input has something other than whitespace
- use this validator for new intent and action names, and utterance texts
- closes #2821 (again)
**Status (please check what you already did)**:
- [x] made PR ready for code review
- [x] added some... | 2019-07-09T14:35:20Z | Exporting interactive training session failes if intent 'None' appears during training
**Rasa Core version**:
0.12.x
**Python version**:
3.6
**Operating system** (windows, osx, ...):
ubuntu
**Issue**:
Exporting fails if e.g. during a FormAction you only provide an answer for a slot, without assigning the answer... | Thanks for raising this issue, @Ghostvv will get back to you about it soon.
Hi, could you please elaborate on: `during a FormAction you only provide an answer for a slot, without assigning the answer to an intent.`?
@Ghostvv : After you provide an answer to the form it asks you to confirms e.g. like this, right?
`I... | [
{
"body": "**Rasa Core version**:\r\n0.12.x\r\n**Python version**: \r\n3.6\r\n**Operating system** (windows, osx, ...):\r\nubuntu\r\n**Issue**:\r\nExporting fails if e.g. during a FormAction you only provide an answer for a slot, without assigning the answer to an intent. In this case the story has an element l... | 1b16a3c39e0ca1ec5438f71c987def59b8255d86 | {
"head_commit": "a1cf4f75fd7bde7291f947524c2cf46ef505bd4e",
"head_commit_message": "Merge branch 'master' into empty-intent",
"patch_to_review": "diff --git a/CHANGELOG.rst b/CHANGELOG.rst\nindex fa1fcfbb941f..1362685c63b8 100644\n--- a/CHANGELOG.rst\n+++ b/CHANGELOG.rst\n@@ -41,6 +41,7 @@ Fixed\n - ``rasa train... | [
{
"diff_hunk": "@@ -277,3 +277,21 @@ def validate(self, document: Document) -> None:\n raise ValidationError(message=error_message)\n \n return ExportPathValidator\n+\n+\n+def questionary_not_empty_text_validator(error_message: Text) -> Type[\"Validator\"]:",
"line": null,
"original_... | 09c498de75c37b2a9d249e5571848dc981868049 | diff --git a/CHANGELOG.rst b/CHANGELOG.rst
index 4240f66d13ea..4f3330802284 100644
--- a/CHANGELOG.rst
+++ b/CHANGELOG.rst
@@ -26,8 +26,8 @@ Removed
Fixed
-----
-- ``MappingPolicy`` now works correctly when used as part of a PolicyEnsemble
- ``rasa run`` without ``--enable-api`` does not require a local model anym... | {
"difficulty": "low",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
RasaHQ__rasa-3976@14dadb8 | RasaHQ/rasa | Python | 3,976 | Remove incorrect predictions from NLU dump at end of interactive learning | Fixes https://github.com/RasaHQ/rasa/issues/3956
When an nlu correction was made, the event is rewound but we never check for this when dumping new data. This would dump incorrect data and additionally cause errors (e.g when there is no confident prediction, rasa tries to dump `"intent": None`)
**Proposed change... | 2019-07-10T10:12:58Z | Interactive learning fails when the intent name and entity type are the same
When dumping NLU data at the end, if there is an entity type that is the same as an intent name, the following error is thrown up:
```bash
2019-07-08 12:51:09 ERROR rasa.core.training.interactive - An exception occurred while recording... | @MetcalfeTom please always add issues to the maintenance board | [
{
"body": "When dumping NLU data at the end, if there is an entity type that is the same as an intent name, the following error is thrown up:\r\n\r\n```bash\r\n2019-07-08 12:51:09 ERROR rasa.core.training.interactive - An exception occurred while recording messages.\r\nTraceback (most recent call last):\r\n... | f699717bcdc0a24b09a29483d604a3201a67cbc5 | {
"head_commit": "14dadb89bb55d8a5efb5ae03302472c01eaf4a34",
"head_commit_message": "Merge branch 'master' into dumping-none-intents",
"patch_to_review": "diff --git a/CHANGELOG.rst b/CHANGELOG.rst\nindex 4c1677159359..ddab83977b94 100644\n--- a/CHANGELOG.rst\n+++ b/CHANGELOG.rst\n@@ -23,6 +23,8 @@ Removed\n \n F... | [
{
"diff_hunk": "@@ -23,6 +23,8 @@ Removed\n \n Fixed\n -----\n+- interactive learning bug where reverted user utterances were dumped to nlu data\n+- ``MappingPolicy`` now works correctly when used as part of a PolicyEnsemble",
"line": null,
"original_line": 27,
"original_start_line": null,
"path... | 9029e1b1ec55b5244a325cddab6c23e4a2ed84e0 | diff --git a/CHANGELOG.rst b/CHANGELOG.rst
index a491c9c7ff95..412f79e7f0d9 100644
--- a/CHANGELOG.rst
+++ b/CHANGELOG.rst
@@ -27,6 +27,7 @@ Removed
Fixed
-----
+- interactive learning bug where reverted user utterances were dumped to training data
- added timeout to terminal input channel to avoid freezing input ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
RasaHQ__rasa-3967@92cee3b | RasaHQ/rasa | Python | 3,967 | Update default syntax for use_entities | **Proposed changes**:
Fixes #3842
**Status (please check what you already did)**:
- [x] made PR ready for code review
- [x] added some tests for the functionality
- [x] updated the documentation
- [ ] updated the changelog
- [ ] reformat files using `black` (please check [Readme](https://github.com/RasaHQ/ras... | 2019-07-09T16:07:08Z | domain entity featurization dump format
Reading a domain with
```
intents:
- intent1:
use_entities: False
```
currently leads to a dump format (if domain is persisted) which is a bit confusing
```
intents:
- intent1:
use_entities: []
ignore_entities: []
```
Ric also said:
> I'm not sure be... | But as far as I can see there is no issue with the `[]` for the value of `use_entities` right? I think we should change the documentation to use `[]` instead of `false`
@akelad Do we also change the schema definitions for `use_entities` to reflect the recommended usage? | [
{
"body": "Reading a domain with\r\n```\r\nintents:\r\n - intent1:\r\n use_entities: False\r\n```\r\n\r\ncurrently leads to a dump format (if domain is persisted) which is a bit confusing\r\n\r\n```\r\nintents:\r\n- intent1:\r\n use_entities: []\r\n ignore_entities: []\r\n```\r\n\r\nRic also said:\r\n> I'... | 16409ce2ab4a02e892cb1c5c95b39a0053f5c76f | {
"head_commit": "92cee3b363b0122a2ac401c5c250ded3902edeed",
"head_commit_message": "Include ignore_entities in domain schema",
"patch_to_review": "diff --git a/data/test_domains/default_unfeaturized_entities.yml b/data/test_domains/default_unfeaturized_entities.yml\nindex 60e43c5b55f3..609227708d07 100644\n--- a... | [
{
"diff_hunk": "@@ -7,6 +7,8 @@ mapping:\n mapping:\n use_entities:\n type: \"bool\"",
"line": null,
"original_line": 9,
"original_start_line": null,
"path": "rasa/core/schemas/domain.yml",
"start_line": null,
"text": "@user1:\nboth `use_entities` and `ignore_enti... | ba6c2f40afdf91a344b1766cadb39aa56c1a5f32 | diff --git a/CHANGELOG.rst b/CHANGELOG.rst
index da53758b4d36..3bf31d1108df 100644
--- a/CHANGELOG.rst
+++ b/CHANGELOG.rst
@@ -15,6 +15,8 @@ Added
Changed
-------
+- recommended syntax for empty ``use_entities`` and ``ignore_entities`` in the domain file
+ has been updated from ``False`` or ``None`` to an empty li... | {
"difficulty": "medium",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
RasaHQ__rasa-3914@4348f22 | RasaHQ/rasa | Python | 3,914 | Fixed crash when --domain not provided for rasa train command | Fixes #3794
**Proposed changes**:
- An Error message will be displayed in case of invalid domain file provided
or no domain file provided at all for `rasa train core` only
- One more additional check added to `--domain` argument
**Tests**:
- [CORE] Provide Invalid domain file path **[Error Message Displayed]... | 2019-07-02T22:17:33Z | rasa train command error message
**Rasa version**: 1.1.13
**Issue**:
If you run the `rasa train` command and don't provide a `--domain` option, a python stack trace results instead of an error message message that the domain file was a required option.
**Error (including full traceback)**:
```
docker run -v ... | Thanks for raising this issue, @ricwo will get back to you about it soon.
Hi @rgstephens, we should indeed throw a more useful warning and not just fail. Thanks for pointing this out!
Hello @ricwo ,
I am currently working on the issue.
I just have one question :
- Should it fires just a warning and continues exec... | [
{
"body": "**Rasa version**: 1.1.13\r\n\r\n**Issue**:\r\n\r\nIf you run the `rasa train` command and don't provide a `--domain` option, a python stack trace results instead of an error message message that the domain file was a required option.\r\n\r\n**Error (including full traceback)**:\r\n```\r\ndocker run -... | 76a91183ac878e96814cc11c3f5a3e6595614317 | {
"head_commit": "4348f22460dbe5261fb6854716ee7d4f18911c19",
"head_commit_message": "Fix linting error",
"patch_to_review": "diff --git a/rasa/train.py b/rasa/train.py\nindex 018694e89755..112d5fe9916f 100644\n--- a/rasa/train.py\n+++ b/rasa/train.py\n@@ -71,12 +71,8 @@ async def train_async(\n try:\n ... | [
{
"diff_hunk": "@@ -99,6 +100,26 @@ def train(\n kwargs,\n )\n \n+ if domain is None:\n+ return handle_domain_if_not_exists(\n+ config, nlu_data_directory, output_path, fixed_model_name\n+ )\n+\n+\n+def handle_domain_if_not_exists(\n+ config, nlu_data_directory... | bc61f206324f5280346bd8e7666971b1dc9beb49 | diff --git a/CHANGELOG.rst b/CHANGELOG.rst
index 790785a1f481..488f760280cd 100644
--- a/CHANGELOG.rst
+++ b/CHANGELOG.rst
@@ -36,6 +36,7 @@ Fixed
- ``x in AnySlotDict`` is now ``True`` for any ``x``, which fixes empty slot warnings in
interactive learning
- ``rasa train`` now also includes NLU files in other form... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
RasaHQ__rasa-3898@c27f2e2 | RasaHQ/rasa | Python | 3,898 | handle invalid export paths | **Proposed changes**:
- fix https://github.com/RasaHQ/rasa/issues/3812
- validate export paths in interactive learning
- added error handling in case path does not exist
**Status (please check what you already did)**:
- [x] made PR ready for code review
- [x] added some tests for the functionality
- [ ] update... | 2019-06-28T16:04:01Z | interactive learning throws error with no output file
```
? Export stories to (if file exists, this will append the stories)
? Export NLU data to (if file exists, this will merge learned data with previous training examples)
? Export domain file to (if file exists, this will be overwritten) domain.yml
2019-06-18 08... | [
{
"body": "```\r\n? Export stories to (if file exists, this will append the stories)\r\n? Export NLU data to (if file exists, this will merge learned data with previous training examples)\r\n? Export domain file to (if file exists, this will be overwritten) domain.yml\r\n2019-06-18 08:16:35 ERROR rasa.core.t... | 3e62036bf9fd458fb5ae81d3b88079604adee357 | {
"head_commit": "c27f2e22a8c63e5ee8d4c5acab5e6bc9aff67473",
"head_commit_message": "fixed types",
"patch_to_review": "diff --git a/CHANGELOG.rst b/CHANGELOG.rst\nindex 8afff776892a..cd2bc03061f3 100644\n--- a/CHANGELOG.rst\n+++ b/CHANGELOG.rst\n@@ -26,6 +26,7 @@ Removed\n -------\n - revert the stripping of trai... | [
{
"diff_hunk": "@@ -778,8 +793,7 @@ def _collect_actions(events: List[Dict[Text, Any]]) -> List[Dict[Text, Any]]:\n try:\n previous_examples = load_data(export_nlu_path)\n except Exception as e:",
"line": 792,
"original_line": 795,
"original_start_line": null,
"path": "rasa/core/... | 1eb1f694b09dc38fcc53086e4136c89f7a411517 | diff --git a/CHANGELOG.rst b/CHANGELOG.rst
index e333c5020e0f..fa1fcfbb941f 100644
--- a/CHANGELOG.rst
+++ b/CHANGELOG.rst
@@ -16,6 +16,7 @@ Added
- the response of ``/model/train`` now includes a response header for the trained model filename
- ``Validator`` class to help developing by checking if the files have any... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
RasaHQ__rasa-3701@bf36abe | RasaHQ/rasa | Python | 3,701 | support loading of files from additional training paths | **Proposed changes**:
- fixes https://github.com/RasaHQ/rasa/issues/3633
**Status (please check what you already did)**:
- [x] made PR ready for code review
- [x] added some tests for the functionality
- [ ] updated the documentation
- [ ] updated the changelog
- [x] reformat files using `black` (please check ... | 2019-06-05T07:37:48Z | Multi Domain loading not importing data directory of root project
Currently the experimental multi bot feature does only load data specified in imported bots or in the root project directory. It should also load data in the data directory of the root project (project in which the command is executed). | Great work Tobias. What would happen in case of name conflicts between skills? Should skills be namespaced eg. action would be called `GreetBot.bye`, same with slots.
At the moment, everything is merged. But we plan to add some support to scope the imports. | [
{
"body": "Currently the experimental multi bot feature does only load data specified in imported bots or in the root project directory. It should also load data in the data directory of the root project (project in which the command is executed).",
"number": 3633,
"title": "Multi Domain loading not imp... | 1a4dee080ab5d02c1b5140253b023a159f8c59f3 | {
"head_commit": "bf36abe5e555d53d310d6f2a56d03a1b647bc5fa",
"head_commit_message": "update changelog",
"patch_to_review": "diff --git a/CHANGELOG.rst b/CHANGELOG.rst\nindex 33e1cfd806d9..0a5ac3cd30d2 100644\n--- a/CHANGELOG.rst\n+++ b/CHANGELOG.rst\n@@ -23,6 +23,7 @@ Fixed\n - slack notifications from bots corre... | [
{
"diff_hunk": "@@ -23,6 +23,7 @@ Fixed\n - slack notifications from bots correctly render text\n - fixed usage of ``--log-file`` argument for ``rasa run`` and ``rasa shell``\n - check if correct tracker store is configured in local mode\n+- loading of additional training data loading with the ``SkillSelector``... | b045899466725019505176aa468ebd1e2ae9c27f | diff --git a/CHANGELOG.rst b/CHANGELOG.rst
index 1973f8967d94..8ecb15ccb0a4 100644
--- a/CHANGELOG.rst
+++ b/CHANGELOG.rst
@@ -21,6 +21,7 @@ Removed
Fixed
-----
+- loading of additional training data with the ``SkillSelector``
[1.0.7] - 2019-06-06
^^^^^^^^^^^^^^^^^^^^
diff --git a/data/test_multi_domain/data/Gr... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
RasaHQ__rasa-3719@e15efc9 | RasaHQ/rasa | Python | 3,719 | Fix duplicate interactive learning events | **Proposed changes**:
- fixes https://github.com/RasaHQ/rasa/issues/3676
- use RevertEvents instead of a replace to update tracker
- remove old `finetuning` stuff since it's not longer supported
**Status (please check what you already did)**:
- [x] made PR ready for code review
- [ ] added some tests for the fu... | 2019-06-06T13:04:09Z | Duplicate event in SQLTracker
<!-- THIS INFORMATION IS MANDATORY - YOUR ISSUE WILL BE CLOSED IF IT IS MISSING. If you don't know your Rasa version, use `pip list | grep rasa`. Removing the below information is allowed for FEATURE REQUESTS. Please format any code or console output with the three ticks ``` above and belo... | Thanks for raising this issue, @wochinge will get back to you about it soon.
This issue is also arising during interactive training since https://github.com/RasaHQ/rasa/blob/master/rasa/core/training/interactive.py#L235 expects the entire event history to be replaced (as done in the `InMemoryTrackerStore` https://gith... | [
{
"body": "<!-- THIS INFORMATION IS MANDATORY - YOUR ISSUE WILL BE CLOSED IF IT IS MISSING. If you don't know your Rasa version, use `pip list | grep rasa`. Removing the below information is allowed for FEATURE REQUESTS. Please format any code or console output with the three ticks ``` above and below. -->\r\n\... | 9de1118de217f26866b70e3024022857913cc768 | {
"head_commit": "e15efc91c446a28d0475663c98b70e244b8addaa",
"head_commit_message": "support for appending multiple events at once to the tracker",
"patch_to_review": "diff --git a/CHANGELOG.rst b/CHANGELOG.rst\nindex 1973f8967d94..a7b56432c48f 100644\n--- a/CHANGELOG.rst\n+++ b/CHANGELOG.rst\n@@ -15,6 +15,9 @@ A... | [
{
"diff_hunk": "@@ -503,31 +496,34 @@ def add_user_cell(data, cell):\n table = SingleTable(table_data, \"Chat History\")\n \n bot_column = []\n- for idx, evt in enumerate(evts):\n- if evt.get(\"event\") == ActionExecuted.type_name:\n- bot_column.append(colored(evt[\"name\"], \"autoc... | 181d7703535efa011ec6dfa3cffa42ca47a0b931 | diff --git a/CHANGELOG.rst b/CHANGELOG.rst
index 139147fc4771..b72a12ffa466 100644
--- a/CHANGELOG.rst
+++ b/CHANGELOG.rst
@@ -14,6 +14,9 @@ Added
Changed
-------
+- update the tracker in interactive learning through reverting and appending events
+ instead of replacing the tracker
+- ``POST /conversations/{conver... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
RasaHQ__rasa-3487@a3f9fa1 | RasaHQ/rasa | Python | 3,487 | Use questionary buttons when interacting with assistant via the terminal | **Proposed changes**:
- if the bot message contains buttons, the user will be able to chose a reply from a list choice instead of having to type the buttons payload
- Fixes #3020
- Works in both interactive learning mode and with `rasa shell`
**Status (please check what you already did)**:
- [x] made PR read... | 2019-05-16T08:56:11Z | Allow users to select buttons when running from cmdline
When an utterance has buttons, we list them like:
```
1: ...
2: ...
```
Would be nice to allow users to select these by, for instance, typing "1" or "2". Or using questionary | [
{
"body": "When an utterance has buttons, we list them like:\r\n```\r\n1: ...\r\n2: ...\r\n```\r\nWould be nice to allow users to select these by, for instance, typing \"1\" or \"2\". Or using questionary",
"number": 3020,
"title": "Allow users to select buttons when running from cmdline"
}
] | d4a1d213d0e638b20b537b9957a4381b80ebda39 | {
"head_commit": "a3f9fa1c730345a810731f63299597e3a19c8f8c",
"head_commit_message": "use old method for printing in restore mode, update changelog",
"patch_to_review": "diff --git a/CHANGELOG.rst b/CHANGELOG.rst\nindex c1191ba2817e..5b0ba322d364 100644\n--- a/CHANGELOG.rst\n+++ b/CHANGELOG.rst\n@@ -6,6 +6,30 @@ R... | [
{
"diff_hunk": "@@ -50,14 +58,20 @@ def print_bot_output(message, color=rasa.cli.utils.bcolors.OKBLUE):\n )\n \n \n-def get_cmd_input():\n- response = questionary.text(\n- \"\", qmark=\"Your input ->\", style=Style([(\"qmark\", \"#b373d6\"), (\"\", \"#b373d6\")])\n- ).ask()\n+def get_cmd_in... | fed9a76d72b4f626a6ad77e4703151ab8ddf12a8 | diff --git a/CHANGELOG.rst b/CHANGELOG.rst
index c1191ba2817e..5b0ba322d364 100644
--- a/CHANGELOG.rst
+++ b/CHANGELOG.rst
@@ -6,6 +6,30 @@ Rasa Change Log
All notable changes to this project will be documented in this file.
This project adheres to `Semantic Versioning`_ starting with version 1.0.
+[Unreleased 1.0.... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
RasaHQ__rasa-3208@a45ffdc | RasaHQ/rasa | Python | 3,208 | Fallback | **Proposed changes**:
- fixes #3187
**Status (please check what you already did)**:
- [x] made PR ready for code review
- [ ] added some tests for the functionality
- [ ] updated the documentation
- [ ] updated the changelog
| 2019-04-04T13:23:33Z | evaluating core stories with two stage fallback causes an error
<!-- THIS INFORMATION IS MANDATORY - YOUR ISSUE WILL BE CLOSED IF IT IS MISSING. If you don't know your Rasa Core version, use `pip list | grep rasa`. Removing the below information is allowed for FEATURE REQUESTS. -->
**Rasa version**: `master`
**P... | [
{
"body": "<!-- THIS INFORMATION IS MANDATORY - YOUR ISSUE WILL BE CLOSED IF IT IS MISSING. If you don't know your Rasa Core version, use `pip list | grep rasa`. Removing the below information is allowed for FEATURE REQUESTS. --> \r\n\r\n**Rasa version**: `master`\r\n\r\n**Python version**: `3.6`\r\n\r\n**Opera... | 3a665c5cc48c591126b0cd2e92ad44a4b09d2fc7 | {
"head_commit": "a45ffdc920d4017ef510b14d27e10986c24c8a16",
"head_commit_message": "Update test.py",
"patch_to_review": "diff --git a/CHANGELOG.rst b/CHANGELOG.rst\nindex 8df6133e6ab5..8f4871976242 100644\n--- a/CHANGELOG.rst\n+++ b/CHANGELOG.rst\n@@ -32,6 +32,7 @@ Removed\n \n Fixed\n -----\n+-evaluating core s... | [
{
"diff_hunk": "@@ -32,6 +32,7 @@ Removed\n \n Fixed\n -----\n+-evaluating core stories with two stage fallback gave an error, trying to handle None for a policy",
"line": null,
"original_line": 35,
"original_start_line": null,
"path": "CHANGELOG.rst",
"start_line": null,
"text": "@user1... | c946c6a6a5f98b151a23d41b2ce9f4214aed7eed | diff --git a/CHANGELOG.rst b/CHANGELOG.rst
index 8df6133e6ab5..f06015c7b1b8 100644
--- a/CHANGELOG.rst
+++ b/CHANGELOG.rst
@@ -32,6 +32,7 @@ Removed
Fixed
-----
+- evaluating core stories with two stage fallback gave an error, trying to handle None for a policy
- the ``/evaluate`` route for the Rasa NLU server now... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
RasaHQ__rasa-3319@95fe09b | RasaHQ/rasa | Python | 3,319 | rasa train core: use additional training arguments | **Proposed changes**:
- Pass additional arguments, such as `augmentation` to train methods.
closes #3274
**Status (please check what you already did)**:
- [x] made PR ready for code review
- [ ] added some tests for the functionality
- [ ] updated the documentation
- [x] updated the changelog
- [x] reforma... | 2019-04-25T09:54:07Z | `rasa train core --augmentation 0` doesn't work
<!-- THIS INFORMATION IS MANDATORY - YOUR ISSUE WILL BE CLOSED IF IT IS MISSING. If you don't know your Rasa Core version, use `pip list | grep rasa`. Removing the below information is allowed for FEATURE REQUESTS. -->
**Rasa version**: `master`
**Python version**:... | we should also check the other kwargs which can be passed to the rasa core train command | [
{
"body": "<!-- THIS INFORMATION IS MANDATORY - YOUR ISSUE WILL BE CLOSED IF IT IS MISSING. If you don't know your Rasa Core version, use `pip list | grep rasa`. Removing the below information is allowed for FEATURE REQUESTS. --> \r\n\r\n**Rasa version**: `master`\r\n\r\n**Python version**: `3.7`\r\n\r\n**Opera... | 747683b0314b63a801456de2a00776af2a33d948 | {
"head_commit": "95fe09b8668934cbcebbf1d06851aac8ff75b990",
"head_commit_message": "Add changelog entry.",
"patch_to_review": "diff --git a/.travis.yml b/.travis.yml\nindex 374575bd517c..c4e060d2dcbe 100644\n--- a/.travis.yml\n+++ b/.travis.yml\n@@ -18,7 +18,7 @@ install:\n - python -m pip install -U pip\n -... | [
{
"diff_hunk": "@@ -99,16 +104,26 @@ def train(\n \n \n def train_core(\n- domain: Text, config: Text, stories: Text, output: Text, train_path: Optional[Text]\n+ domain: Text,\n+ config: Text,\n+ stories: Text,\n+ output: Text,\n+ train_path: Optional[Text],\n+ args: Optional[Dict],\n ) -> ... | 07740919e24de124997bc84e8c4fd4a63cb89cde | diff --git a/.travis.yml b/.travis.yml
index eae0502b575c..fcc73256e6f9 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -19,7 +19,7 @@ install:
- python -m pip install -U pip
- pip install git+https://github.com/tmbo/MITIE.git
- pip install -r requirements-dev.txt
- - pip install -e .
+ - pip install -e . --no... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
RasaHQ__rasa-3206@7a95eee | RasaHQ/rasa | Python | 3,206 | IL action creation | **Proposed changes**:
- fixes #3178
- user can pick action previously created in the same session as action correction
- user can add utterance template during interactive learning to be saved to domain file
**Status (please check what you already did)**:
- [x] made PR ready for code review
- [ ] added some te... | 2019-04-04T12:33:22Z | Adding an `utter_*` action in interactive learning
**Rasa version:**
rasa-core (0.13.6)
rasa-core-sdk (0.12.2)
rasa-nlu (0.14.6)
**Python Version:** Python 3.6.7
**Operating System:** Linux- Ubuntu 18.04.2 LTS
**Issue:** Interactive learning should not throw this warning for an `utter_*` action because it's... | Any update on this please?
well, this isn't an error. This is intended. If you don't have your action implemented it can't be executed. However, this seems to be an `utter_` template, so you should be able to hit "no" here.
I'm going to keep this issue and rename it, because it actually shouldn't be throwing this war... | [
{
"body": "**Rasa version:**\r\nrasa-core (0.13.6)\r\nrasa-core-sdk (0.12.2)\r\nrasa-nlu (0.14.6)\r\n\r\n**Python Version:** Python 3.6.7\r\n\r\n**Operating System:** Linux- Ubuntu 18.04.2 LTS\r\n\r\n**Issue:** Interactive learning should not throw this warning for an `utter_*` action because it's an utterance ... | 63d7dac376191c0f9477f70519f9d7bf688c1f3c | {
"head_commit": "7a95eeec89a22df1d6fb842ad56ed603e69cd381",
"head_commit_message": "Update run-code-in-custom-actions.rst",
"patch_to_review": "diff --git a/CHANGELOG.rst b/CHANGELOG.rst\nindex b2af264964e1..d1f1811dfe01 100644\n--- a/CHANGELOG.rst\n+++ b/CHANGELOG.rst\n@@ -11,8 +11,13 @@ This project adheres to... | [
{
"diff_hunk": "@@ -584,14 +610,37 @@ def _slot_history(tracker_dump: Dict[Text, Any]) -> List[Text]:\n for a in predictions\n ]\n \n+ tracker = await retrieve_tracker(endpoint, sender_id)\n+ evts = tracker.get(\"events\", [])",
"line": null,
"original_line": 614,
"original_start_l... | aa471ba1d1f1efd9cb3b4b59253fa7ecc8cb9ab1 | diff --git a/CHANGELOG.rst b/CHANGELOG.rst
index f9dca346280c..8df6133e6ab5 100644
--- a/CHANGELOG.rst
+++ b/CHANGELOG.rst
@@ -11,8 +11,13 @@ This project adheres to `Semantic Versioning`_ starting with version 1.0.
Added
-----
+
+- option to create template for new utterance action in ``interactive learning``
+- y... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
RasaHQ__rasa-3933@ad5cd4c | RasaHQ/rasa | Python | 3,933 | Ticket lock | **Proposed changes**:
- fixes #3925
**Status (please check what you already did)**:
- [x] made PR ready for code review
- [x] added some tests for the functionality
- [x] updated the documentation
- [x] updated the changelog
- [x] reformat files using `black` (please check [Readme](https://github.com/RasaHQ/ra... | 2019-07-04T09:32:37Z | RedisTrackerStore save data in non-binary format
The redis tracker store currently stores the conversation in a binary format since the tracker object is pickled. Storing this in a human readable format (json) would make the data
* easier reusable (for analyzing, extracting data)
* less error prone | [
{
"body": "The redis tracker store currently stores the conversation in a binary format since the tracker object is pickled. Storing this in a human readable format (json) would make the data\r\n\r\n* easier reusable (for analyzing, extracting data)\r\n* less error prone\r\n",
"number": 3925,
"title": "... | 15fbd8808c99f3b4fb1e142d8c43d6e68e95adf8 | {
"head_commit": "ad5cd4cb11980cc61b09e13b8c238b4374cf1d40",
"head_commit_message": "lint",
"patch_to_review": "diff --git a/rasa/core/agent.py b/rasa/core/agent.py\nindex 3783bd47092e..ac945f0dbdb1 100644\n--- a/rasa/core/agent.py\n+++ b/rasa/core/agent.py\n@@ -4,10 +4,10 @@\n import tempfile\n import uuid\n fro... | [
{
"diff_hunk": "@@ -0,0 +1,210 @@\n+import asyncio\n+import logging\n+import pickle\n+import typing\n+from typing import Text, Optional, Dict, Union\n+\n+from rasa.core.lock import TicketLock\n+\n+if typing.TYPE_CHECKING:\n+ pass\n+\n+logger = logging.getLogger(__name__)\n+\n+ACCEPTED_LOCK_STORES = [\"in_mem... | d6b2a20a5fc1d4f93c24b03a4ba19898da219212 | diff --git a/CHANGELOG.rst b/CHANGELOG.rst
index f02692cfd003..0fbf6aaf9e5d 100644
--- a/CHANGELOG.rst
+++ b/CHANGELOG.rst
@@ -20,14 +20,22 @@ Added
information.
- throw error during training when triggers are defined in the domain without
``MappingPolicy`` being present in the policy ensemble
-- the tracker is ... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Code Refactoring / Architectural Improvement"
} | |
RasaHQ__rasa-3174@dd8758f | RasaHQ/rasa | Python | 3,174 | updated formbot and docs | **Proposed changes**:
- fixes #3176 and 1422 (issue in old core)
- Form validation method is used as intended now and with `validate_{requested_slot}`
**Status (please check what you already did)**:
- [x] made PR ready for code review
- [ ] added some tests for the functionality
- [x] updated the documentation
... | 2019-03-29T10:05:24Z | update form docs
Explain what every line in the story does for the form and when what information is needed in the stories.
For example, the stories shown in the docs include: `- form{"name": null}` but don't say what it is doing. Also since interactive learning is printing much more than required that could be expla... | [
{
"body": "Explain what every line in the story does for the form and when what information is needed in the stories. \r\nFor example, the stories shown in the docs include: `- form{\"name\": null}` but don't say what it is doing. Also since interactive learning is printing much more than required that could be... | cc9d38e7fce069756e419802e225b002167b0a28 | {
"head_commit": "dd8758f211b8bd8ccf921dcade827efc101a3d55",
"head_commit_message": "updated formbot and docs",
"patch_to_review": "diff --git a/docs/core/slotfilling.rst b/docs/core/slotfilling.rst\nindex 7582a325d72a..33bcf674b8dc 100644\n--- a/docs/core/slotfilling.rst\n+++ b/docs/core/slotfilling.rst\n@@ -37,... | [
{
"diff_hunk": "@@ -63,72 +59,68 @@ def cuisine_db():\n \"mexican\"]\n \n @staticmethod\n- def is_int(string: Text) -> bool:\n+ def is_int(string: Text) -> Any:\n \"\"\"Check if a string is an integer\"\"\"\n+\n try:\n int(string)\n return True\n... | a9b63f45ef68d4f004aeeb98e7527977ea762030 | diff --git a/docs/core/slotfilling.rst b/docs/core/slotfilling.rst
index 7582a325d72a..78df3b56b804 100644
--- a/docs/core/slotfilling.rst
+++ b/docs/core/slotfilling.rst
@@ -37,8 +37,8 @@ under ``forms:`` section:
.. _section_form_basics:
-Basics
-------
+Forms Basics
+------------
Using a ``FormAction``, you ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Documentation Updates"
} | |
ManimCommunity__manim-4115@5126242 | ManimCommunity/manim | Python | 4,115 | Completely rewrite `Code` mobject + add support for short notation RGB(A) hex code specifications to `ManimColor` | See title.
Due to a version upgrade of `pygments`, support for short notation color hex codes was required -- which also required a patch to `Code`. This part of this PR could be factored out (e.g., to allow us to finalize the release faster).
The `Code` mobject was in a somewhat bad state, code quality wise. Thi... | 2025-01-18T17:44:33Z | Code Mobject incorrect color string parsing
## Description of bug / unexpected behavior
Code Mobject does not work for me at all in fresh install of mania v0.18.1. Throws ValueError due to attempt to parse an invalid color string. I tracked the issue down to the HTML/JSON for the code text which appears to be specifyi... | I'm having the same problem on my m1 mac with macos 15.1.1 with a fresh install of manim, which is why I'm still using the docker image on tag v0.18.0 (probably the same version the containers on mybinder.com are running, because the interactive example in the [docs](https://docs.manim.community/en/stable/reference/man... | [
{
"body": "## Description of bug / unexpected behavior\r\nCode Mobject does not work for me at all in fresh install of mania v0.18.1. Throws ValueError due to attempt to parse an invalid color string. I tracked the issue down to the HTML/JSON for the code text which appears to be specifying at least some colors... | 86a971940fd7ce8d956aff08f1f15d20e13ab08e | {
"head_commit": "5126242fb1ac18aa764589bd1e0995aa139dd216",
"head_commit_message": "chore: formatting",
"patch_to_review": "diff --git a/manim/mobject/text/code_mobject.py b/manim/mobject/text/code_mobject.py\nindex 999ab3c90e..664e78f7a5 100644\n--- a/manim/mobject/text/code_mobject.py\n+++ b/manim/mobject/text... | [
{
"diff_hunk": "@@ -81,557 +59,207 @@ def construct(self):\n s = Square()\n self.play(FadeIn(s))\n self.play(s.animate.scale(2))\n- self.wait()\n- '''\n- rendered_code = Code(code=code, tab_width=4, background=\"window\",\n- ... | 974ac53640ba9ce90595dafe7ca8910be3e4367f | diff --git a/manim/mobject/text/code_mobject.py b/manim/mobject/text/code_mobject.py
index 999ab3c90e..eb4e6fed16 100644
--- a/manim/mobject/text/code_mobject.py
+++ b/manim/mobject/text/code_mobject.py
@@ -6,50 +6,27 @@
"Code",
]
-import html
-import os
-import re
from pathlib import Path
+from typing import ... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
RasaHQ__rasa-3140@a86596e | RasaHQ/rasa | Python | 3,140 | emulate form rejection in evaluation | **Proposed changes**:
- FormAction is not run, so we add `ActionExecutionRejected` event if form action is predicted, but not expected and if "unhappy" intent is remembered by FormPolicy
- fixes #2792
**Status (please check what you already did)**:
- [x] made PR ready for code review
- [ ] added some tests for... | 2019-03-25T11:00:13Z | How to use e2e evaluation for FormAction
<!-- THIS INFORMATION IS MANDATORY - YOUR ISSUE WILL BE CLOSED IF IT IS MISSING. If you don't know your Rasa Core version, use `pip list | grep rasa_core`. Removing the below information is allowed for FEATURE REQUESTS. -->
**Rasa Core version**: 0.13.0a1
**Python version... | Hey, so the thing is that if you explicitly write all the steps within a form, it has to be written with a form prefix (see https://rasa.com/docs/core/interactive_learning/#the-form-prefix) so that rasa core doesn't get confused. This also means that those lines will get ignored from training though. So I don't think e... | [
{
"body": "<!-- THIS INFORMATION IS MANDATORY - YOUR ISSUE WILL BE CLOSED IF IT IS MISSING. If you don't know your Rasa Core version, use `pip list | grep rasa_core`. Removing the below information is allowed for FEATURE REQUESTS. --> \r\n\r\n**Rasa Core version**: 0.13.0a1\r\n\r\n**Python version**: 3.6.6\r\n\... | 26583aa649bcd65a7f3c01b27f9d8be7d993bad0 | {
"head_commit": "a86596eea55d3921811b7248a6b2999a2059106c",
"head_commit_message": "Merge branch 'master' into fix_form_evaluation",
"patch_to_review": "diff --git a/examples/concertbot/Makefile b/examples/concertbot/Makefile\nindex 81bb58949732..b16b61e84158 100644\n--- a/examples/concertbot/Makefile\n+++ b/exa... | [
{
"diff_hunk": "@@ -15,10 +15,10 @@ train-core:\n \tpython -m rasa.core.train -s data/stories.md -d domain.yml -o models/dialogue --debug\n \n run-core:\n-\tpython -m rasa.core.run --core models/dialogue --nlu models/nlu/current --verbose --endpoints endpoints.yml\n+\tpython -m rasa.core.run --core models/dialo... | 3d30c178c97004f142394c0dae25ac34dedb2d65 | diff --git a/examples/concertbot/Makefile b/examples/concertbot/Makefile
index 81bb58949732..b16b61e84158 100644
--- a/examples/concertbot/Makefile
+++ b/examples/concertbot/Makefile
@@ -20,7 +20,7 @@ run-core:
python -m rasa.core.run --core models/dialogue --endpoints endpoints.yml
run-actions:
- python -m rasa.c... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Documentation Updates"
} |
ManimCommunity__manim-3876@b1c4065 | ManimCommunity/manim | Python | 3,876 | feat: set_default for Animation class | <!-- Thank you for contributing to Manim! Learn more about the process in our contributing guidelines: https://docs.manim.community/en/latest/contributing.html -->
## Overview: What does this pull request change?
<!-- If there is more information than the PR title that should be added to our release changelog, add ... | 2024-07-20T16:18:14Z | Animation.set_default
## Description of proposed feature
One of the useful things in ManimCE for me is set_default method, that can be applied to any subclass of Mobject. Code without duplicates of **mob_kwargs is always nice to look at. What about Animations? I often correct the default values of Create and Uncreate,... | Seems good to keep this in mind. | [
{
"body": "## Description of proposed feature\r\nOne of the useful things in ManimCE for me is set_default method, that can be applied to any subclass of Mobject. Code without duplicates of **mob_kwargs is always nice to look at. What about Animations? I often correct the default values of Create and Uncreate, ... | c8fe4d9e4f9ce1788dfeb3c1f2c3aaa8f99060a4 | {
"head_commit": "b1c40652da3f521803173ea455dbb0a905c5afe8",
"head_commit_message": "test: added missing test",
"patch_to_review": "diff --git a/manim/animation/animation.py b/manim/animation/animation.py\nindex 042054b7ba..35ab008bbe 100644\n--- a/manim/animation/animation.py\n+++ b/manim/animation/animation.py\... | [
{
"diff_hunk": "@@ -479,6 +480,52 @@ def is_introducer(self) -> bool:\n \"\"\"\n return self.introducer\n \n+ @classmethod\n+ def __init_subclass__(cls, **kwargs) -> None:\n+ super().__init_subclass__(**kwargs)\n+\n+ cls._original__init__ = cls.__init__\n+\n+ @classmethod\... | d34c6a3679fb8f0eeee77c42d8e0df34738fda63 | diff --git a/manim/animation/animation.py b/manim/animation/animation.py
index 042054b7ba..8bdf236b3f 100644
--- a/manim/animation/animation.py
+++ b/manim/animation/animation.py
@@ -16,6 +16,7 @@
from collections.abc import Iterable, Sequence
from copy import deepcopy
+from functools import partialmethod
from typ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
RasaHQ__rasa-1604@46a9f15 | RasaHQ/rasa | Python | 1,604 | Fix overlapping entities | **Proposed changes**:
- fixes #1562
**Status (please check what you already did)**:
- [x] made PR ready for code review
- [x] added some tests for the functionality
- [ ] updated the documentation
- [ ] updated the changelog
| 2018-12-31T09:40:47Z | Fix overlapping entities in evaluate script
Right now the evaluate script fails whenever there's any overlapping entity labels. It should only fail for overlapping entities *within* an entity classifier. In fact, I think it only actually makes sense for the `ner_crf`, given `ner_duckling_http` could identify both a num... | @akelad do we have an example of the offending data and/or error logs?
The website demo data causes this, and the error includes "overlapping entities". The error is thrown here: https://github.com/RasaHQ/rasa_nlu/blob/master/rasa_nlu/evaluate.py#L476 and the function is defined here: https://github.com/RasaHQ/rasa_nl... | [
{
"body": "Right now the evaluate script fails whenever there's any overlapping entity labels. It should only fail for overlapping entities *within* an entity classifier. In fact, I think it only actually makes sense for the `ner_crf`, given `ner_duckling_http` could identify both a number and a date in one whi... | b2d26e9c107d00d1c6e4713681979d91fd50aa41 | {
"head_commit": "46a9f15a7da440288edf4b4987dc47a0f145b93f",
"head_commit_message": "Merge branch 'master' into fix-overlapping-entities",
"patch_to_review": "diff --git a/rasa_nlu/evaluate.py b/rasa_nlu/evaluate.py\nindex 2f9098c71c37..b22b2c0c0e8e 100644\n--- a/rasa_nlu/evaluate.py\n+++ b/rasa_nlu/evaluate.py\n... | [
{
"diff_hunk": "@@ -462,18 +462,19 @@ def pick_best_entity_fit(token, candidates):\n return candidates[best_fit][\"entity\"]\n \n \n-def determine_token_labels(token, entities):\n+def determine_token_labels(token, entities, extractors):\n \"\"\"Determines the token label given entities that do not o... | df507cf39d41266d9261d33328cb13028348eb47 | diff --git a/CHANGELOG.rst b/CHANGELOG.rst
index 8795d1fc275c..9b9383a1a85f 100644
--- a/CHANGELOG.rst
+++ b/CHANGELOG.rst
@@ -40,6 +40,7 @@ Fixed
- NLU Server can now handle training data mit emojis in it
- If the ``token_name`` is not given in the endpoint configuration, the default
value is ``token`` instead of... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ManimCommunity__manim-3589@2beefd3 | ManimCommunity/manim | Python | 3,589 | Fix issue where SpiralIn doesn't show elements. | <!-- Thank you for contributing to Manim! Learn more about the process in our contributing guidelines: https://docs.manim.community/en/latest/contributing.html -->
## Overview: What does this pull request change?
<!-- If there is more information than the PR title that should be added to our release changelog, add ... | 2024-01-22T03:30:01Z | `SpiralIn` is not working with the first Element
`SpiralIn` doesn't show the first Element sometimes, for examples just visit the current documentation of `SpiralIn`
- [ ] Tests are needed for SpiralIn to prevent this from happening again
- [ ] Implementation needs to be fixed | Started looking into this issue. Here is an example that fails to show the test object when I run `manim -pqh test.py`:
```python
class SpiralInBugExample(Scene):
def construct(self):
test = MathTex(r"\pi").scale(5)
# test = Tex('test').scale(5) # Uncomment to test Tex
# test = Singl... | [
{
"body": "`SpiralIn` doesn't show the first Element sometimes, for examples just visit the current documentation of `SpiralIn`\r\n\r\n- [ ] Tests are needed for SpiralIn to prevent this from happening again\r\n- [ ] Implementation needs to be fixed",
"number": 3514,
"title": "`SpiralIn` is not working ... | 68bd79093e1ebc1ed9f8051942ffe6e72a9e66a7 | {
"head_commit": "2beefd3e1b0f70e33f5211b0b45e1139eac79e9b",
"head_commit_message": "Create test for SpiralIn",
"patch_to_review": "diff --git a/manim/animation/creation.py b/manim/animation/creation.py\nindex 6f8173e35a..2c8be99d22 100644\n--- a/manim/animation/creation.py\n+++ b/manim/animation/creation.py\n@@ ... | [
{
"diff_hunk": "@@ -476,7 +476,7 @@ def interpolate_mobject(self, alpha: float) -> None:\n for shape in self.shapes:\n shape.restore()\n shape.save_state()\n- opacity = shape.get_fill_opacity()\n+ opacity = shape.get_fill_opacity() or 1",
"line": null,
... | bc711afd5d075e7d3ca385bf7281fca7a9260bef | diff --git a/manim/animation/creation.py b/manim/animation/creation.py
index 6f8173e35a..2e15182bcd 100644
--- a/manim/animation/creation.py
+++ b/manim/animation/creation.py
@@ -456,7 +456,7 @@ def __init__(
fade_in_fraction=0.3,
**kwargs,
) -> None:
- self.shapes = shapes
+ self.s... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
RasaHQ__rasa-253@580c48d | RasaHQ/rasa | Python | 253 | Return default output when parsing an empty text | fixes #240 | 2017-04-03T14:24:41Z | Properly handle empty strings when passed to parse
version: rasa-nlu==0.7.0a8
```
INFO:root:using mitie backend
INFO:root:Started http server on port 5000
root@177-Rancher-host:/home/devuser/rasa_nlu-master# Error categorizing text:
[2017-03-27 05:02:00,849] ERROR in app: Exception on /parse [POST]
Traceba... | @NagarajGond what is the text you are sending to the API endpoint that triggers this behavior?
sorry for the late reply.
It took me hours figure out that my code was sending empty string to RASA sever.
No worries, it's a bug that needs fixing. | [
{
"body": " \r\nversion: rasa-nlu==0.7.0a8\r\n\r\n```\r\nINFO:root:using mitie backend\r\nINFO:root:Started http server on port 5000\r\n\r\nroot@177-Rancher-host:/home/devuser/rasa_nlu-master# Error categorizing text:\r\n[2017-03-27 05:02:00,849] ERROR in app: Exception on /parse [POST]\r\nTraceback (most recen... | 202b9041393a3f0e5667e3a33e18c661bd695232 | {
"head_commit": "580c48d881b6fef346e49c4115c519e414a92d0d",
"head_commit_message": "added test to check if empty parsing works",
"patch_to_review": "diff --git a/_pytest/test_server.py b/_pytest/test_server.py\nindex c97b29c78938..7e60dcb87b8c 100644\n--- a/_pytest/test_server.py\n+++ b/_pytest/test_server.py\n@... | [
{
"diff_hunk": "@@ -54,6 +54,10 @@ def test_status(client):\n u\"/parse?q=hello ńöñàśçií\",\n [{u\"entities\": {}, u\"confidence\": 1.0, u\"intent\": u\"greet\", u\"_text\": u\"hello ńöñàśçií\"}]\n ),\n+ ResponseTest(\n+ u\"/parse?q=\",\n+ [{u\"entities\": {}, u\"confidence\... | 91cb984dc246a3ab12f4325ce7605adafb88cab4 | diff --git a/_pytest/test_server.py b/_pytest/test_server.py
index c97b29c78938..14b660a6fced 100644
--- a/_pytest/test_server.py
+++ b/_pytest/test_server.py
@@ -47,12 +47,16 @@ def test_status(client):
@pytest.mark.parametrize("response_test", [
ResponseTest(
- u"/parse?q=hello",
- [{u"entities"... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ManimCommunity__manim-3756@0046b84 | ManimCommunity/manim | Python | 3,756 | Fix assertions and improve error messages when adding submobjects | Closes #3755.
Initially this PR only improved 2 things:
1. When adding into a `Mobject` a value which is not a `Mobject`, or there's an attempt to add a mobject to itself, **the error messages are now more descriptive**, indicating:
- what's the value being added
- what's its type
- at which index is... | 2024-05-12T03:00:19Z | `VGroup` cannot have a `Mobject` as a child, but `VMobject` can
## Description of bug / unexpected behavior
`Mobject` methods like `add()` assert that all the values passed are also instances of `Mobject`, before adding them as children (into `Mobject.submobjects`).
`VGroup` overrides `add()` to go even further, by... | [
{
"body": "## Description of bug / unexpected behavior\r\n`Mobject` methods like `add()` assert that all the values passed are also instances of `Mobject`, before adding them as children (into `Mobject.submobjects`).\r\n\r\n`VGroup` overrides `add()` to go even further, by asserting that the values are instance... | 739958514f7d3bb680651c66e25a68fbdf4f40f8 | {
"head_commit": "0046b8496d1736ecf65386a719ba7a6971eb5ac3",
"head_commit_message": "Joined string in OpenGLMobject error message",
"patch_to_review": "diff --git a/manim/mobject/mobject.py b/manim/mobject/mobject.py\nindex 9127c2a1d6..de009022e6 100644\n--- a/manim/mobject/mobject.py\n+++ b/manim/mobject/mobject... | [
{
"diff_hunk": "@@ -29,12 +29,20 @@ def test_mobject_add():\n obj = Mobject()\n \n # a Mobject cannot contain itself\n- with pytest.raises(ValueError):\n- obj.add(obj)\n+ with pytest.raises(ValueError) as add_self_info:\n+ obj.add(Mobject(), obj, Mobject())\n+ print(str(add_self_i... | 8f890a1b5b34400c31ac4eca2fb1a8f9f8f49890 | diff --git a/manim/mobject/mobject.py b/manim/mobject/mobject.py
index 3369f3a241..0ae2a29daa 100644
--- a/manim/mobject/mobject.py
+++ b/manim/mobject/mobject.py
@@ -116,6 +116,63 @@ def __init__(
self.generate_points()
self.init_colors()
+ def _assert_valid_submobjects(self, submobjects: Iterab... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
ManimCommunity__manim-3107@f76c07b | ManimCommunity/manim | Python | 3,107 | Porting and drastical rewrite to reach compatibility with `3b1b/manim` again | Porting all the new features from `3b1b/manim` drastical rewrite of the render system.
Currently no explanation because it is highly experimental. Further discussion about this can be found on the discord server. | 2023-01-01T16:16:23Z | Rounding Corners doesn't work for OpenGL as well as Depth Testing
```py
class Test(ThreeDScene):
colors = [RED, GREEN, YELLOW, WHITE, BLUE, ORANGE]
def create_cube(self):
cube = Cube(1)
for i, face in enumerate(cube):
face.set_fill(self.colors[i])
face.set_stroke... | Shader wrapper has depth testing disabled by default and is not updatet by passing anything to the mobject or using `apply_depth_test` | [
{
"body": "```py\r\nclass Test(ThreeDScene):\r\n colors = [RED, GREEN, YELLOW, WHITE, BLUE, ORANGE]\r\n\r\n def create_cube(self):\r\n cube = Cube(1)\r\n for i, face in enumerate(cube):\r\n face.set_fill(self.colors[i])\r\n face.set_stroke(BLACK, 2)\r\n face.... | 3713ed6b1e0f9d51de8e74717bf4489c592f880f | {
"head_commit": "f76c07bffe3c13be221c96b60058fe7be566d551",
"head_commit_message": "first working render",
"patch_to_review": "diff --git a/manim/_config/utils.py b/manim/_config/utils.py\nindex cdbd62fce4..98229ac4c6 100644\n--- a/manim/_config/utils.py\n+++ b/manim/_config/utils.py\n@@ -15,6 +15,8 @@\n import ... | [
{
"diff_hunk": "@@ -2,22 +2,30 @@\n \n import copy\n import itertools as it\n+import numbers\n+import os\n+import pickle\n import random\n import sys\n from functools import partialmethod, wraps\n from math import ceil\n-from typing import Iterable, Sequence\n+from typing import TYPE_CHECKING\n \n import modern... | 862bb338efa9e30d120f7538e9eeb66480fe6fc1 | diff --git a/manim/_config/utils.py b/manim/_config/utils.py
index cdbd62fce4..98229ac4c6 100644
--- a/manim/_config/utils.py
+++ b/manim/_config/utils.py
@@ -15,6 +15,8 @@
import configparser
import copy
import errno
+import importlib
+import inspect
import logging
import os
import re
diff --git a/manim/constant... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
ManimCommunity__manim-3095@b91ee7e | ManimCommunity/manim | Python | 3,095 | Fixed ``get_axis_labels`` for :class:`.Axes` and :class:`.ThreeDAxes` | <!-- Thank you for contributing to Manim! Learn more about the process in our contributing guidelines: https://docs.manim.community/en/latest/contributing.html -->
## Overview: What does this pull request change?
<!-- If there is more information than the PR title that should be added to our release changelog, add ... | 2022-12-26T23:54:53Z | `~.get_axis_labels()` implemented for `Axes`, but not `ThreeDAxes`
## Description of bug / unexpected behavior
<!-- Add a clear and concise description of the problem you encountered. -->
Shouldn't the method `~.get_axis_labels()` work for both `Axes` and `ThreeDAxes`? At the moment it only works for `Axes` and retu... | Yes and no, there is a degree of freedom associated with labels in 3D space. Do you want them always facing the camera, aligned with the axis itself. At the end of the axis or above that you can always read it no matter the orientation.
In 2D it's simply just putting it beside the axis. So unless you propose a system ... | [
{
"body": "## Description of bug / unexpected behavior\r\n<!-- Add a clear and concise description of the problem you encountered. -->\r\nShouldn't the method `~.get_axis_labels()` work for both `Axes` and `ThreeDAxes`? At the moment it only works for `Axes` and returns an error when trying to use with `ThreeD... | c4b40ed138c4b895ce433e68f719f628e823e293 | {
"head_commit": "b91ee7ee65987bb3c2bb9e675f290f5096ecc0ee",
"head_commit_message": "Fix ~.get_axis_labels() for ThreeDAxes",
"patch_to_review": "diff --git a/manim/mobject/graphing/coordinate_systems.py b/manim/mobject/graphing/coordinate_systems.py\nindex 703d879d7c..3604c13bd4 100644\n--- a/manim/mobject/graph... | [
{
"diff_hunk": "@@ -2412,6 +2466,59 @@ def construct(self):\n positioned_label.rotate(rotation, axis=rotation_axis)\n return positioned_label\n \n+ def get_axis_labels(\n+ self,\n+ x_label: float | str | Mobject = \"x\",\n+ y_label: float | str | Mobject = \"y\",\n+ ... | 8c82ed5c46ab7fb984383f87c8b41a65fee44482 | diff --git a/manim/mobject/graphing/coordinate_systems.py b/manim/mobject/graphing/coordinate_systems.py
index 703d879d7c..03f96b838f 100644
--- a/manim/mobject/graphing/coordinate_systems.py
+++ b/manim/mobject/graphing/coordinate_systems.py
@@ -364,52 +364,8 @@ def _get_axis_label(
label.shift_onto_screen(bu... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ManimCommunity__manim-2734@da2f8a8 | ManimCommunity/manim | Python | 2,734 | Fixed OpenGL segfaults when running :meth:`.Scene.play` or :meth:`.Scene.wait` in interactive mode | ## Overview: What does this pull request change?
self.play checks if it's running on the main thread; If it isn't, it schedules the play method to run using the queue.
<!-- If there is more information than the PR title that should be added to our release changelog, add it in the following changelog section. This is ... | 2022-05-24T16:09:26Z | Running `self.play` etc. in the IPython terminal spawned by `interactive_embed` does not work
## Description of bug / unexpected behavior
<!-- Add a clear and concise description of the problem you encountered. -->
While the scene is available as `self` in the spawned IPython terminal, running rendering methods lik... | [
{
"body": "## Description of bug / unexpected behavior\r\n<!-- Add a clear and concise description of the problem you encountered. -->\r\n\r\nWhile the scene is available as `self` in the spawned IPython terminal, running rendering methods like `self.wait` or `self.play` makes Manim crash (hard):\r\n```\r\nIn [... | d3bdefbae26cf2fa07750cddc9ff4a0de5c9b7c7 | {
"head_commit": "da2f8a851a8e2db2af9baf3c902d634a18725a58",
"head_commit_message": "make play run only on main thread",
"patch_to_review": "diff --git a/manim/scene/scene.py b/manim/scene/scene.py\nindex 397fab6a8a..ee04413a39 100644\n--- a/manim/scene/scene.py\n+++ b/manim/scene/scene.py\n@@ -1008,6 +1008,22 @@... | [
{
"diff_hunk": "@@ -1008,6 +1008,22 @@ def play(\n All other keywords are passed to the renderer.\n \n \"\"\"\n+ # Make sure this is running on the main thread\n+ if threading.current_thread().name != \"MainThread\":\n+ self.queue.put(\n+ (\n+ ... | ec38c00e947de7d73f60cd58c3d9bc9d322faa0b | diff --git a/manim/scene/scene.py b/manim/scene/scene.py
index 397fab6a8a..1ddcd13bd1 100644
--- a/manim/scene/scene.py
+++ b/manim/scene/scene.py
@@ -1008,6 +1008,24 @@ def play(
All other keywords are passed to the renderer.
"""
+ # Make sure this is running on the main thread
+ ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
RasaHQ__rasa-3123@9bdb141 | RasaHQ/rasa | Python | 3,123 | Keyword classifier | This reopens PR [1741](https://github.com/RasaHQ/rasa_nlu/pull/1741) which I accidentally closed and adds the modifications that were still required.
@FabianReich Sorry for moving this to another PR, I messed up while trying to add to your original PR.
**Proposed changes**:
- Adding a custom keyword intent cla... | 2019-03-22T09:17:46Z | App Simple Keyword intent classifier
**Feature**:
I want to have a simple keyword matching model.
E.g.
Building a model that recognizes if the sentence is about a female or a male person.
```
Sentence: "I got inspired by my mother."
Intent: "Female"
```
Then I want to provide a list of female people (mothe... | This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. | [
{
"body": "**Feature**:\r\nI want to have a simple keyword matching model. \r\n\r\nE.g.\r\nBuilding a model that recognizes if the sentence is about a female or a male person.\r\n\r\n```\r\nSentence: \"I got inspired by my mother.\"\r\nIntent: \"Female\"\r\n```\r\nThen I want to provide a list of female people ... | dd54bf11c49d5086baf104098fc78eec723ad326 | {
"head_commit": "9bdb141f496468ea6b8887acd5bd670efb099a3b",
"head_commit_message": "intent_keyword_map is now instance attr, `load` method fixed",
"patch_to_review": "diff --git a/.travis.yml b/.travis.yml\nindex 648b65f143d1..eece45adaf23 100644\n--- a/.travis.yml\n+++ b/.travis.yml\n@@ -37,6 +37,8 @@ jobs:\n ... | [
{
"diff_hunk": "@@ -1,32 +1,99 @@\n-from typing import Any, Optional, Text\n+import os\n+import logging\n+import re\n+import typing\n+from typing import Any, Dict, Optional, Text\n \n+from rasa.nlu import utils\n from rasa.nlu.components import Component\n from rasa.nlu.training_data import Message\n \n+logger ... | dce09737c74fcb96cb31659829212da1c92112de | diff --git a/data/test_config/keyword_classifier_config.yml b/data/test_config/keyword_classifier_config.yml
new file mode 100644
index 000000000000..c6a6eca5ef61
--- /dev/null
+++ b/data/test_config/keyword_classifier_config.yml
@@ -0,0 +1,2 @@
+pipeline:
+ - name: "KeywordIntentClassifier"
diff --git a/docs/nlu/comp... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
ManimCommunity__manim-2771@8f100a4 | ManimCommunity/manim | Python | 2,771 | Added documentation and testing for ``path_func`` keyword argument of :class:`.Transform` | <!-- Thank you for contributing to Manim! Learn more about the process in our contributing guidelines: https://docs.manim.community/en/latest/contributing.html -->
## Overview: What does this pull request change?
The Transform class's handling of path_func parameters is unintuitively implemented and undocumented, w... | 2022-06-16T06:22:38Z | Transform: missing documentation of path_arc_centers keyword argument
## Description of bug / unexpected behavior
<!-- Add a clear and concise description of the problem you encountered. -->
The `Transform` constructor accepts a keyword argument, `path_arc_centers`, which is only being used once and this use is not w... | Contrary to what I thought before (and also contrary to any sort of reasonable coding practice), this is actually wrong. When we discussed this earlier, I missed that `path_func` is actually a property whose setter checks whether the value that is being assigned is `None` (and if so, the actual function is not changed)... | [
{
"body": "## Description of bug / unexpected behavior\r\n<!-- Add a clear and concise description of the problem you encountered. -->\r\nThe `Transform` constructor accepts a keyword argument, `path_arc_centers`, which is only being used once and this use is not working as intended.\r\n\r\nInspecting `Transfor... | b583720ac26832db2fcdb8b4aeb0508996dcedae | {
"head_commit": "8f100a4342e1e15c6505cc921ad27a61c136ebea",
"head_commit_message": "Add Transform test for conflicting path settings",
"patch_to_review": "diff --git a/manim/animation/transform.py b/manim/animation/transform.py\nindex 624d36f004..60159ecca9 100644\n--- a/manim/animation/transform.py\n+++ b/manim... | [
{
"diff_hunk": "@@ -46,6 +46,35 @@\n \n \n class Transform(Animation):\n+ \"\"\"A Transform transforms a Mobject into a target Mobject.\n+\n+ Parameters\n+ ----------\n+ mobject\n+ The Mobject to be transformed. The Mobject will be mutated into the target.\n+ target_mobject\n+ The M... | 833d7267fcd7cd805ecfef885c5e726f5e797e66 | diff --git a/manim/animation/transform.py b/manim/animation/transform.py
index 624d36f004..77bed1defb 100644
--- a/manim/animation/transform.py
+++ b/manim/animation/transform.py
@@ -46,6 +46,36 @@
class Transform(Animation):
+ """A Transform transforms a Mobject into a target Mobject.
+
+ Parameters
+ --... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
RasaHQ__rasa-211@b5baeb4 | RasaHQ/rasa | Python | 211 | Component based architecture | This PR contains a major refactoring of the architecture. It makes the different parts of the processing more composable and allows us to add new features in a clean way (e.g. sentiment analysis, different intent classifiers...).
Benefits:
- simpler to add new features
- composable, e.g. you can use what ever int... | 2017-03-13T12:05:47Z | Entity Only Training
Sorry, maybe I am missing something, but your documentation states that the rasa_nlu_documentation contains 3 different examples: common training (intent + entity), intent training, and entity training. But under `entity_examples` all of the entity arrays are empty
`{
"text": "hey",
... | Alright, let's try to improve the documentation then. It states
> In the rasa NLU data format, there are three lists of examples: common_examples, intent_examples, and entity_examples. The common_examples are used to train both the entity and the intent models. In many cases it’s fine to put all of your training ex... | [
{
"body": "Sorry, maybe I am missing something, but your documentation states that the rasa_nlu_documentation contains 3 different examples: common training (intent + entity), intent training, and entity training. But under `entity_examples` all of the entity arrays are empty \r\n\r\n`{\r\n \"text\": \"h... | 9862fc845c41e8b217a9509ed83ac69648d019b0 | {
"head_commit": "b5baeb48bef674b01e1ccbccc765f36bd0dd122c",
"head_commit_message": "fixed pepe8 error",
"patch_to_review": "diff --git a/.gitignore b/.gitignore\nindex 94cef71d1a97..ae759afd19a8 100644\n--- a/.gitignore\n+++ b/.gitignore\n@@ -5,11 +5,9 @@ data/*\n !data/examples\n docs/_build\n server/\n-*.log\n... | [
{
"diff_hunk": "@@ -0,0 +1,76 @@\n+\"\"\"This is a somewhat delicate package. It contains all registered components and preconfigured templates.\n+\n+Hence, it imports all of the components. To avoid cycles, no component should import this in module scope.\"\"\"\n+from typing import Optional\n+from typing impor... | 60c17e16116fb9ea88cd8e33f7e4a083eba05930 | diff --git a/.gitignore b/.gitignore
index 94cef71d1a97..8ce4929c6882 100644
--- a/.gitignore
+++ b/.gitignore
@@ -5,11 +5,9 @@ data/*
!data/examples
docs/_build
server/
-*.log
scala/
mongodb/
.cache/
-build/lib/
build/
*.egg-info/
jnk/
@@ -26,13 +24,11 @@ lastmile_ai/learn/plots/
.coveralls.yml
.idea/
*.im... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
ManimCommunity__manim-2684@92e4120 | ManimCommunity/manim | Python | 2,684 | Created a more accessible way to create Angles with line.py angle function - :meth:`.Angle.from_three_points` | <!-- Thank you for contributing to Manim! Learn more about the process in our contributing guidelines: https://docs.manim.community/en/latest/contributing.html -->
## Overview: What does this pull request change?
<!-- If there is more information than the PR title that should be added to our release changelog, add ... | 2022-04-20T01:08:50Z | More accessible way to create Angles
## Description of proposed feature
<!-- Add a clear and concise description of the new feature, including a motivation: why do you think this will be useful? -->
The current way of creating `Angle` mobjects is somewhat clunky and could be improved. One way of doing so would be t... | I can tackle this with @jbalpert !!!
Where would this function actually get defined? In the line.py file? @behackl
> Where would this function actually get defined? In the line.py file? @behackl
Go ahead! Yes, in `line.py`, as a member of the `Angle` class.
We have implemented the member function and have wrote a p... | [
{
"body": "## Description of proposed feature\r\n<!-- Add a clear and concise description of the new feature, including a motivation: why do you think this will be useful? -->\r\n\r\nThe current way of creating `Angle` mobjects is somewhat clunky and could be improved. One way of doing so would be the introduct... | 584d80242f005c484803f36efa9df7d01fcc599e | {
"head_commit": "92e412062d1ba2bdd8bfa97a53b76be26e9f20e2",
"head_commit_message": "added additional example",
"patch_to_review": "diff --git a/manim/mobject/geometry/line.py b/manim/mobject/geometry/line.py\nindex 76e17cc288..fead180c1a 100644\n--- a/manim/mobject/geometry/line.py\n+++ b/manim/mobject/geometry/... | [
{
"diff_hunk": "@@ -1015,6 +1015,53 @@ def construct(self):\n return self.angle_value / DEGREES\n return self.angle_value\n \n+ @staticmethod\n+ def from_three_points(\n+ A: np.ndarray, B: np.ndarray, C: np.ndarray, **kwargs\n+ ) -> Angle:\n+ \"\"\"The angle between th... | 9f046643367c71286cb11a3f202d2192af721c4f | diff --git a/manim/mobject/geometry/line.py b/manim/mobject/geometry/line.py
index 76e17cc288..cb8d7188d7 100644
--- a/manim/mobject/geometry/line.py
+++ b/manim/mobject/geometry/line.py
@@ -1015,6 +1015,46 @@ def construct(self):
return self.angle_value / DEGREES
return self.angle_value
+ @s... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
ManimCommunity__manim-2574@3e9946d | ManimCommunity/manim | Python | 2,574 | Improved Error in :mod:`.utils.tex_file_writing` | ## Overview: What does this pull request change?
This removes the infamous `max() arg is an empty sequence` error
Added an insight for when a package is not installed
Fixes #2360
## Further Information and Comments
<!-- If applicable, put further comments for the reviewers here. -->
I am not sure if
> Install ... | 2022-02-25T11:00:47Z | Tex value error when handling compilation issue
## Description of bug / unexpected behavior
<!-- Add a clear and concise description of the problem you encountered. -->
I had some missing tex dependencies that are resolved now, but when manim was gathering the details to report the error it failed as `env_markers_i... | This is one of the most-reported errors in our Discord, it would be great to improve the error message. | [
{
"body": "## Description of bug / unexpected behavior\r\n<!-- Add a clear and concise description of the problem you encountered. -->\r\n\r\nI had some missing tex dependencies that are resolved now, but when manim was gathering the details to report the error it failed as `env_markers_indices` in `tex_file_wr... | a038288ac647f993692e9a2ae4347d3122c9abb7 | {
"head_commit": "3e9946dc3277e71f8c653e1950325cd970aae1fd",
"head_commit_message": "Better Error and insight",
"patch_to_review": "diff --git a/manim/utils/tex_file_writing.py b/manim/utils/tex_file_writing.py\nindex 6987996c8b..2da7276265 100644\n--- a/manim/utils/tex_file_writing.py\n+++ b/manim/utils/tex_file... | [
{
"diff_hunk": "@@ -149,6 +149,11 @@ def insight_inputenc_error(match):\n yield \"See the documentation for manim.mobject.svg.tex_mobject for details on using a custom TexTemplate\"\n \n \n+def insight_package_not_found_error(match):\n+ yield f\"You do not have package {match[1]} installed\"",
"line"... | 76dce4f30b45d774d40c16b11ab49841634ce7a9 | diff --git a/manim/utils/tex_file_writing.py b/manim/utils/tex_file_writing.py
index 6987996c8b..f10ee3b512 100644
--- a/manim/utils/tex_file_writing.py
+++ b/manim/utils/tex_file_writing.py
@@ -84,7 +84,7 @@ def generate_tex_file(expression, environment=None, tex_template=None):
result = os.path.join(tex_dir, t... | {
"difficulty": "low",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
RasaHQ__rasa-3145@73f5fd0 | RasaHQ/rasa | Python | 3,145 | Change default paths if arguments are provided | fixes #2741
**Proposed changes**:
- Change default paths to the provided arguments
**Status (please check what you already did)**:
- [x] made PR ready for code review
- [ ] added some tests for the functionality
- [ ] updated the documentation
- [x] updated the changelog
| 2019-03-25T16:52:39Z | Pass default directory to interactive learning
**Rasa Core version**:
0.12.x
**Python version**:
2.7.15
**Operating system** (windows, osx, ...):
Ubuntu
**Issue**:
When training interactively, the default output paths are taken only from the hard-coded PATHS variable in the interactive.py:
```
PATHS = {"sto... | we'd be happy to accept a PR for this
Yes, I was just about to write an issue for this.
I have a custom directory and file naming and on saving after the interactive training I have to manually change all three paths.
```
Do you want to stop? Export & Quit
? Export stories to (if file exists, this will append ... | [
{
"body": "**Rasa Core version**:\r\n0.12.x\r\n**Python version**: \r\n2.7.15\r\n**Operating system** (windows, osx, ...):\r\nUbuntu\r\n**Issue**:\r\nWhen training interactively, the default output paths are taken only from the hard-coded PATHS variable in the interactive.py:\r\n```\r\n\r\nPATHS = {\"stories\":... | 8af492f51e4e49179a0ac04df1411737cf6ce948 | {
"head_commit": "73f5fd0c48e3a1cd59feb64203099fc542efd3fa",
"head_commit_message": "Merge branch 'master' into feature/2741",
"patch_to_review": "diff --git a/rasa/core/cli/train.py b/rasa/core/cli/train.py\nindex 798d26910b58..458ee6f4324b 100644\n--- a/rasa/core/cli/train.py\n+++ b/rasa/core/cli/train.py\n@@ -... | [
{
"diff_hunk": "@@ -50,6 +50,9 @@ def add_interactive_args(parser):\n default=False,\n action='store_true',\n help=\"retrain the model immediately based on feedback.\")\n+ parser.add_argument('--data',",
"line": null,
"original_line": 53,
"original_start_line": null,
"... | 8d19e86dcdbd6eae2a72a284df3162ad29b87b61 | diff --git a/CHANGELOG.rst b/CHANGELOG.rst
index f65250a3fa04..48734edb1917 100644
--- a/CHANGELOG.rst
+++ b/CHANGELOG.rst
@@ -11,6 +11,7 @@ This project adheres to `Semantic Versioning`_ starting with version 1.0.
Added
-----
+- added arguments to set the file paths for interactive training
- added quick reply re... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
ManimCommunity__manim-2332@7b956a2 | ManimCommunity/manim | Python | 2,332 | Changed ``color``, ``stroke_color`` and ``fill_color`` attributes to properties | <!-- Thank you for contributing to Manim! Learn more about the process in our contributing guidelines: https://docs.manim.community/en/latest/contributing.html -->
## Overview: What does this pull request change?
<!-- If there is more information than the PR title that should be added to our release changelog, add ... | 2021-11-26T21:10:58Z | Attribute not updated when animated with `.animate`
## Description of bug / unexpected behavior
<!-- Add a clear and concise description of the problem you encountered. -->
Mobject attributes are not updated when animated with `.animate`, but are successfully changed when done outside of animations
## Expected ... | maybe related to #2320?
It's not related to #2320.
If I've understood correctly, `c1.animate.set_stroke(...)` works by cloning `c1` into `c1.target`, then calling set_stroke on the target. The animation then Tranforms from `c1` to `c1.target`, but never actually edits `c1` beyond that.
I would propose a decent fi... | [
{
"body": "## Description of bug / unexpected behavior\r\n<!-- Add a clear and concise description of the problem you encountered. -->\r\nMobject attributes are not updated when animated with `.animate`, but are successfully changed when done outside of animations\r\n\r\n\r\n## Expected behavior\r\n<!-- Add a c... | 269e5c22cb02de108579eccee2b82583eb71e3dc | {
"head_commit": "7b956a2c04b63b365caf263eced8512ebe0cdbba",
"head_commit_message": "[pre-commit.ci] auto fixes from pre-commit.com hooks\n\nfor more information, see https://pre-commit.ci",
"patch_to_review": "diff --git a/manim/mobject/geometry.py b/manim/mobject/geometry.py\nindex f0f7d07690..db31f8c689 100644... | [
{
"diff_hunk": "@@ -9,11 +9,12 @@\n import re\n import string\n import warnings\n-from typing import Dict, List\n+from typing import Dict, List, Optional",
"line": null,
"original_line": 12,
"original_start_line": null,
"path": "manim/mobject/svg/svg_mobject.py",
"start_line": null,
"tex... | 035ae57f84c312a7b11d61340fee4af1dec32aa5 | diff --git a/manim/mobject/geometry.py b/manim/mobject/geometry.py
index f0f7d07690..db31f8c689 100644
--- a/manim/mobject/geometry.py
+++ b/manim/mobject/geometry.py
@@ -2558,8 +2558,8 @@ def construct(self):
"""
def __init__(self, corner_radius=0.5, **kwargs):
- self.corner_radius = corner_radius
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
PostHog__posthog-33792@0867e5d | PostHog/posthog | Python | 33,792 | feat(experiments): add support for "any order" in funnels | ## Problem
We currently only support sequential funnels. Users have requested support for any order (something we support in product analytics).
## Changes
- Extend the schema for funnel metrics with `funnel_order_type`
- Add a new component `ExperimentMetricFunnelOrderSelector` to `ExperimentMetricForm`
- Use t... | 2025-06-17T10:50:17Z | Support "Any order" in experiment funnel metrics
### Feature request
We only support a specific order of events in experiment funnel metrics. In product analytics, we support "Any order". We should close the feature gap here.
## Potential solutions
What we can consider is to see if we can use the same Clickhouse UDF ... | [
{
"body": "### Feature request\n\nWe only support a specific order of events in experiment funnel metrics. In product analytics, we support \"Any order\". We should close the feature gap here.\n\n## Potential solutions\nWhat we can consider is to see if we can use the same Clickhouse UDF that product analytics ... | 31f65f1de390591bf4a1bde698c9e1588648c765 | {
"head_commit": "0867e5d27f562821492eb35ac2aaa9207de6b674",
"head_commit_message": "add unit tests",
"patch_to_review": "diff --git a/frontend/src/queries/schema.json b/frontend/src/queries/schema.json\nindex f143cf539dc24..fe048ec47a0b5 100644\n--- a/frontend/src/queries/schema.json\n+++ b/frontend/src/queries/... | [
{
"diff_hunk": "@@ -281,7 +281,7 @@ def handle(self, *args, **options):\n posthoganalytics.capture(\n distinct_id=distinct_id,\n event=action.event,\n- timestamp=random_timestamp + timedelta(minutes=1),\n+... | debbe635a52f6496b661de9c2e2f5aec542e9a1b | diff --git a/frontend/src/queries/schema.json b/frontend/src/queries/schema.json
index f143cf539dc24..fe048ec47a0b5 100644
--- a/frontend/src/queries/schema.json
+++ b/frontend/src/queries/schema.json
@@ -9282,6 +9282,9 @@
"conversion_window_unit": {
"$ref": "#/definitions/FunnelCo... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
PostHog__posthog-34068@72579c2 | PostHog/posthog | Python | 34,068 | feat(flags): use redis reader and writer | > [!IMPORTANT]
> 👉 _Stay up-to-date with [PostHog coding conventions](https://posthog.com/docs/contribute/coding-conventions) for a smoother review._
## Problem
Closes https://github.com/PostHog/posthog/issues/34067
## Changes
- uses separate reader and writer clients for accessing redis, with safe fallba... | 2025-06-23T21:57:00Z | split out redis reader and writer instances for `/flags`
We overuse the redis writers and don't hit the readers as much, and we've also noticed that under heavy load the that redis sometimes times out. Our service is read-heavy (although we still write a decent amount for billing), so we're a good candidate for splitt... | [
{
"body": "We overuse the redis writers and don't hit the readers as much, and we've also noticed that under heavy load the that redis sometimes times out. Our service is read-heavy (although we still write a decent amount for billing), so we're a good candidate for splitting these services out.",
"number"... | ecb909108e383eac5f947ae60dd6aa11fb186d9b | {
"head_commit": "72579c29c0464bd0730d8c06c2372ffa502d9da7",
"head_commit_message": "reader and writer now",
"patch_to_review": "diff --git a/rust/feature-flags/src/flags/flag_request.rs b/rust/feature-flags/src/flags/flag_request.rs\nindex 22e4083f33ee4..d0af4131e42ee 100644\n--- a/rust/feature-flags/src/flags/f... | [
{
"diff_hunk": "@@ -337,7 +337,7 @@ mod tests {\n .extract_token()\n .expect(\"failed to extract token\");\n \n- let flag_service = FlagService::new(redis_client.clone(), pg_client.clone());\n+ let flag_service = FlagService::new(redis_client.clone(), redis_client.clone(), ... | 552f534fd7d4e535efc5f0245d9c281b9a9773ec | diff --git a/rust/feature-flags/src/flags/flag_request.rs b/rust/feature-flags/src/flags/flag_request.rs
index 22e4083f33ee4..0a4a571cf21af 100644
--- a/rust/feature-flags/src/flags/flag_request.rs
+++ b/rust/feature-flags/src/flags/flag_request.rs
@@ -337,7 +337,11 @@ mod tests {
.extract_token()
... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Code Refactoring / Architectural Improvement"
} | |
ManimCommunity__manim-2314@4507cf6 | ManimCommunity/manim | Python | 2,314 | Added basic support for adding subcaptions via :meth:`.Scene.add_subcaption` | <!-- Thank you for contributing to Manim! Learn more about the process in our contributing guidelines: https://docs.manim.community/en/latest/contributing.html -->
## Overview: What does this pull request change?
<!-- If there is more information than the PR title that should be added to our release changelog, add ... | 2021-11-21T13:36:04Z | Feature request: Subtitle timings
## Description of proposed feature
<!-- Add a clear and concise description of the new feature, including a motivation: why do you think this will be useful? -->
It would be fairly useful to have animation options that aren't for actually displaying anything, but for marking the ti... | Hello and thanks for the suggestion!
I must say that my position is a "soft no". I am not an expert, but I believe there are ways of adding subtitles that are external to how the video is rendered. For example, in most playback software that accepts subtitles, you have the option to turn subtitles off and on. Howeve... | [
{
"body": "## Description of proposed feature\r\n<!-- Add a clear and concise description of the new feature, including a motivation: why do you think this will be useful? -->\r\n\r\nIt would be fairly useful to have animation options that aren't for actually displaying anything, but for marking the timestamps ... | a4c1c4f15a752d7c40a09516c1950f1ea7386948 | {
"head_commit": "4507cf6914f81f65de37a88594029a0fb7a908dd",
"head_commit_message": "fix typo",
"patch_to_review": "diff --git a/manim/scene/scene.py b/manim/scene/scene.py\nindex afbfa73cfc..b716162f40 100644\n--- a/manim/scene/scene.py\n+++ b/manim/scene/scene.py\n@@ -3,6 +3,7 @@\n __all__ = [\"Scene\"]\n \n im... | [
{
"diff_hunk": "@@ -899,8 +902,46 @@ def get_run_time(self, animations):\n else:\n return np.max([animation.run_time for animation in animations])\n \n- def play(self, *args, **kwargs):\n+ def play(\n+ self,\n+ *args,\n+ subcaption=None,\n+ subcaption_durati... | 4c7edf624dd53c517e91d9c99216663bc08fd889 | diff --git a/manim/scene/scene.py b/manim/scene/scene.py
index afbfa73cfc..ee2c387875 100644
--- a/manim/scene/scene.py
+++ b/manim/scene/scene.py
@@ -3,6 +3,7 @@
__all__ = ["Scene"]
import copy
+import datetime
import inspect
import platform
import random
@@ -12,6 +13,8 @@
from queue import Queue
from typing ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
Significant-Gravitas__AutoGPT-8391@63c838e | Significant-Gravitas/AutoGPT | Python | 8,391 | fix: show error toast on Run failure when inputs or credentials are i… | ### Fixes #8332
## Background
The issue is that when “Run” fails due to invalid inputs (e.g., deleted credentials), no error message is shown in the UI.
### Changes 🏗️
- Added toast notification (variant="destructive") for "Run" failures.
- Displays error when the execution request returns an HTTP 400 due... | 2024-10-22T07:10:29Z | Show error if queueing graph execution fails
If clicking "Run" results in a failure, e.g. the hard-coded input values are no longer valid, this isn't visible in the UI. This can happen e.g. with credentials when they are deleted from the user but not from the graph. The execution request returns an HTTP 400 but the UI ... | @Pwuts Can i try this one?? | [
{
"body": "If clicking \"Run\" results in a failure, e.g. the hard-coded input values are no longer valid, this isn't visible in the UI. This can happen e.g. with credentials when they are deleted from the user but not from the graph. The execution request returns an HTTP 400 but the UI doesn't show anything.\n... | ff1fa2af2d3ba2943900dec4b9571e5e1e69b996 | {
"head_commit": "63c838e65eec3aaa07996fcd32541f530f072e86",
"head_commit_message": "fix: show error toast on Run failure when inputs or credentials are invalid",
"patch_to_review": "diff --git a/autogpt_platform/frontend/src/hooks/useAgentGraph.ts b/autogpt_platform/frontend/src/hooks/useAgentGraph.ts\nindex 589... | [
{
"diff_hunk": "",
"line": null,
"original_line": null,
"original_start_line": null,
"path": "autogpt_platform/supabase",
"start_line": null,
"text": "@user1:\nif we revert the change to supabase, this is good to go!"
}
] | 339e8628baa0577e19f6917a99bae44cdc593ba6 | diff --git a/autogpt_platform/frontend/src/hooks/useAgentGraph.ts b/autogpt_platform/frontend/src/hooks/useAgentGraph.ts
index 0140a07c550e..e8631dbe134a 100644
--- a/autogpt_platform/frontend/src/hooks/useAgentGraph.ts
+++ b/autogpt_platform/frontend/src/hooks/useAgentGraph.ts
@@ -415,10 +415,25 @@ export default func... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
ManimCommunity__manim-2111@1396d83 | ManimCommunity/manim | Python | 2,111 | Improved setting of OpenGL colors | <!-- Thank you for contributing to Manim! Learn more about the process in our contributing guidelines: https://docs.manim.community/en/latest/contributing.html -->
## Overview: What does this pull request change?
<!-- If there is more information than the PR title that should be added to our release changelog, add ... | 2021-09-29T19:01:43Z | Setting colors and opacities in OpenGLVMobject doesn't change attributes
## Description of bug / unexpected behavior
<!-- Add a clear and concise description of the problem you encountered. -->
Calling `set_color`, `set_fill` and `set_stroke` on `OpenGLVMobject` doesn't change attributes like `self.opacity`, `self.... | [
{
"body": "## Description of bug / unexpected behavior\r\n<!-- Add a clear and concise description of the problem you encountered. -->\r\n\r\nCalling `set_color`, `set_fill` and `set_stroke` on `OpenGLVMobject` doesn't change attributes like `self.opacity`, `self.fill_color` etc. It might not have been noticed ... | dd16347eb83466cb5c6281429ca5566dfb1e1513 | {
"head_commit": "1396d83c412e1332c25dfc422189deb9f730c925",
"head_commit_message": "Improve setting of opengl colors",
"patch_to_review": "diff --git a/manim/mobject/opengl_mobject.py b/manim/mobject/opengl_mobject.py\nindex e981e051e2..ae127a7544 100644\n--- a/manim/mobject/opengl_mobject.py\n+++ b/manim/mobjec... | [
{
"diff_hunk": "@@ -163,6 +172,14 @@ def set_stroke(\n background=None,\n recurse=True,\n ):\n+ if color is not None:\n+ self.stroke_color = Color(color)\n+ if opacity is not None:\n+ self.stroke_opacity = opacity\n+ if recurse:\n+ for su... | 931f9d305938156972d6677372e1f4f035aa0db7 | diff --git a/manim/mobject/opengl_mobject.py b/manim/mobject/opengl_mobject.py
index bc29d78a9d..812d0b9d9a 100644
--- a/manim/mobject/opengl_mobject.py
+++ b/manim/mobject/opengl_mobject.py
@@ -1326,6 +1326,10 @@ def set_color(self, color, opacity=None, recurse=True):
self.set_rgba_array(color, opacity, recur... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
ManimCommunity__manim-2075@7a2f0ff | ManimCommunity/manim | Python | 2,075 | Implemented :meth:`.Mobject.set_default`, a mechanism for changing default values of keyword arguments | <!-- Thank you for contributing to Manim! Learn more about the process in our contributing guidelines: https://docs.manim.community/en/latest/contributing.html -->
## Overview: What does this pull request change?
There has been a lot of discussion about default values for Mobjects (I'll go through the list of iss... | 2021-09-24T16:59:59Z | Ability to set the default font
It should be possible to set a global default font, rather than having to explicitly set it in every `Text` object.
If that is already possible somehow then it should be documented, because I could figure it out even after reading the source code. | We currently don't have a mechanism for setting/changing default values; but you can always create a custom subclass
```py
class MyText(Text):
def __init__(self, *args, font=..., **kwargs):
super().__init__(*args, font=font, **kwargs)
```
Also, feel free to join the discussion for a feature like t... | [
{
"body": "It should be possible to set a global default font, rather than having to explicitly set it in every `Text` object.\r\n\r\nIf that is already possible somehow then it should be documented, because I could figure it out even after reading the source code.",
"number": 2074,
"title": "Ability to... | 3f272097110f299ac8a5bf0d8e2f477e0b395819 | {
"head_commit": "7a2f0ff18a208df92c1527291ac510c707169056",
"head_commit_message": "actually fix doctest 🙄",
"patch_to_review": "diff --git a/manim/mobject/mobject.py b/manim/mobject/mobject.py\nindex c949793eb2..afeed5af84 100644\n--- a/manim/mobject/mobject.py\n+++ b/manim/mobject/mobject.py\n@@ -11,7 +11,7 @... | [
{
"diff_hunk": "@@ -180,6 +180,41 @@ def add_animation_override(\n f\"{override_func.__qualname__}.\",\n )\n \n+ @classmethod\n+ def change_default(cls, **kwargs):\n+ \"\"\"Changes the default values of keyword arguments.\n+\n+ Parameters\n+ ----------\n+\n... | 243dfe9909aa334bba2d633723385c9156fb2293 | diff --git a/manim/mobject/mobject.py b/manim/mobject/mobject.py
index f76655362c..f9fac8a115 100644
--- a/manim/mobject/mobject.py
+++ b/manim/mobject/mobject.py
@@ -11,7 +11,7 @@
import sys
import types
import warnings
-from functools import reduce
+from functools import partialmethod, reduce
from math import cei... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
ManimCommunity__manim-2546@1fcfbf3 | ManimCommunity/manim | Python | 2,546 | Fixed a File logging bug and some maintenance | ## Overview: What does this pull request change?
Closes #2285
Removes a test
Removes the ability to change `verbosity` when calling `--log_to_file`
Adds type hints to file_ops
And does some fixes to _config.utils
I have added additional details in the commit messages
## Motivation and Explanation: Why and h... | 2022-02-15T08:20:59Z | `log_to_file` in configuration gives `'Nonetype' is not iterable` traceback
## Description of bug / unexpected behavior
trying to set up logging in a config file fails
## Expected behavior
logs written to a file
## How to reproduce the issue
<details><summary>Code for reproducing the problem</summary>
... | `manim --log_to_file scene.py SquareToCircle` works as expected with a blank `manim.cfg` | [
{
"body": "## Description of bug / unexpected behavior\r\ntrying to set up logging in a config file fails\r\n\r\n\r\n## Expected behavior\r\nlogs written to a file \r\n\r\n\r\n## How to reproduce the issue\r\n\r\n<details><summary>Code for reproducing the problem</summary>\r\n\r\n```cfg\r\n# manim.cfg\r\n\r\n[C... | 5d72d9cfa2e3dd21c844b1da807576f5a7194fda | {
"head_commit": "1fcfbf37dac7f8615259250cefe8a743e18cdfae",
"head_commit_message": "Merge branch 'main' into file_logging",
"patch_to_review": "diff --git a/manim/_config/logger_utils.py b/manim/_config/logger_utils.py\nindex de579dcfef..1c7d93258f 100644\n--- a/manim/_config/logger_utils.py\n+++ b/manim/_config... | [
{
"diff_hunk": "@@ -117,33 +122,42 @@ def write_to_movie() -> bool:\n )\n \n \n-def add_extension_if_not_present(file_name, extension):\n+def log_to_file() -> bool:",
"line": null,
"original_line": 125,
"original_start_line": null,
"path": "manim/utils/file_ops.py",
"start_line": null,
... | 1c0300ab0494bf887412ca5dabb0051ace1ba9a6 | diff --git a/manim/_config/logger_utils.py b/manim/_config/logger_utils.py
index de579dcfef..64b341b7be 100644
--- a/manim/_config/logger_utils.py
+++ b/manim/_config/logger_utils.py
@@ -15,7 +15,6 @@
import copy
import json
import logging
-import os
import sys
from typing import TYPE_CHECKING
@@ -26,7 +25,7 @@
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
PostHog__posthog-33791@5a40dd5 | PostHog/posthog | Python | 33,791 | feat(messaging): Hogflow logical actions, metrics | ## Problem
Closes https://github.com/PostHog/posthog/issues/32442
Closes https://github.com/PostHog/posthog/issues/32439
## Changes
tl;dr - adds all logical actions (time and condition based)
- [x] Adds a common delay helper as it will be used across multiple cases
- [x] Makes the duration more advanced... | 2025-06-17T10:42:41Z | Hogflow metrics + logs
HogFunctions have metrics and logs - we need to extend this to work for HogFlows.
General per-flow invocation metrics and logs will work just fine. Making them be "action" specific is a little trickier... We would either need to add another dimension to the tables for filtering, or do it some ha... | [
{
"body": "HogFunctions have metrics and logs - we need to extend this to work for HogFlows.\n\nGeneral per-flow invocation metrics and logs will work just fine. Making them be \"action\" specific is a little trickier... We would either need to add another dimension to the tables for filtering, or do it some ha... | 00c3e4573fd0e3c8472e232d696b49c4f5dcd9b1 | {
"head_commit": "5a40dd5b4588a075e9018e830d675fdb2a53019d",
"head_commit_message": "Fixes",
"patch_to_review": "diff --git a/plugin-server/src/cdp/_tests/fixtures-hogflows.ts b/plugin-server/src/cdp/_tests/fixtures-hogflows.ts\nindex 3859b7dd91664..3521c4dd4be56 100644\n--- a/plugin-server/src/cdp/_tests/fixture... | [
{
"diff_hunk": "@@ -1,19 +1,63 @@\n import { DateTime } from 'luxon'\n \n-import { CyclotronJobInvocationHogFlow } from '~/cdp/types'\n+import { CyclotronJobInvocationHogFlow, HogFunctionFilterGlobals } from '~/cdp/types'\n+import { convertToHogFunctionFilterGlobal } from '~/cdp/utils'\n+import { filterFunction... | 13dafdc02ed3bed9510ceec1aa5228968e7c90a6 | diff --git a/plugin-server/src/cdp/_tests/builders/hogflow.builder.ts b/plugin-server/src/cdp/_tests/builders/hogflow.builder.ts
new file mode 100644
index 0000000000000..c5bb30e196ac8
--- /dev/null
+++ b/plugin-server/src/cdp/_tests/builders/hogflow.builder.ts
@@ -0,0 +1,121 @@
+import { randomUUID } from 'crypto'
+
+... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
Significant-Gravitas__AutoGPT-7938@a7f885d | Significant-Gravitas/AutoGPT | Python | 7,938 | feat(server): Clean up resources when spinning down services/processes | - Resolves #7937
- Blocked by #7892
### Changes 🏗️
- Add SIGTERM handler and `cleanup()` hook to `AppProcess`
- Implement `cleanup()` on `AppService` to close DB and Redis connections
- Implement `cleanup()` on `ExecutionManager` to shut down worker pool
- Add `atexit` and SIGTERM handlers to node executor t... | 2024-09-01T14:14:53Z | [Server] Clean up resources when spinning down services/processes
* `AppService` instances don't close their DB connection when they are stopped, leaving dozens of zombie Prisma processes running in the background after repeatedly starting/stopping the application.
* `ExecutionManager` doesn't clean up its graph execut... | [
{
"body": "* `AppService` instances don't close their DB connection when they are stopped, leaving dozens of zombie Prisma processes running in the background after repeatedly starting/stopping the application.\n* `ExecutionManager` doesn't clean up its graph execution workers when it is stopped, leaving dozens... | b12dba13f4bbb4be028b271af2d46b7dc5f444a0 | {
"head_commit": "a7f885d6b1491b0b41b3a6007570c2d0dc7fc19a",
"head_commit_message": "Merge branch 'master' into reinier/open-1772-server-clean-up-resources-when-spinning-down",
"patch_to_review": "diff --git a/rnd/autogpt_server/autogpt_server/executor/manager.py b/rnd/autogpt_server/autogpt_server/executor/manag... | [
{
"diff_hunk": "@@ -336,6 +338,14 @@ def on_node_executor_start(cls):\n cls.loop.run_until_complete(db.connect())\n cls.agent_server_client = get_agent_server_client()\n \n+ # Set up shutdown handler\n+ signal.signal(signal.SIGTERM, lambda _, __: cls.node_executor_stop())\n+\n+ ... | 9ad33be7a61a2b7b0662714a6df49007faee4d6c | diff --git a/rnd/autogpt_server/autogpt_server/executor/manager.py b/rnd/autogpt_server/autogpt_server/executor/manager.py
index ff4521160a48..6bf449f6356b 100644
--- a/rnd/autogpt_server/autogpt_server/executor/manager.py
+++ b/rnd/autogpt_server/autogpt_server/executor/manager.py
@@ -1,6 +1,10 @@
import asyncio
+imp... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Code Refactoring / Architectural Improvement"
} | |
Significant-Gravitas__AutoGPT-9759@a3325ca | Significant-Gravitas/AutoGPT | Python | 9,759 | feat(backend/executor): Move execution queue + cancel mechanism to RabbitMQ | The graph execution queue is not disk-persisted; when the executor dies, the executions are lost.
The scope of this issue is migrating the execution queue from an inter-process queue to a RabbitMQ message queue. A sync client should be used for this.
- Resolves #9746
- Resolves #9714
### Changes 🏗️
Move t... | 2025-04-04T12:38:13Z | Convert cancel execution request API into a fan-out event
There is already an API to cancel a running execution, however, the current implementation won't be reliable when working on a multi-executor setup. This is caused by the API call that needs to identify which executor is running the agent, and send it to the rig... | [
{
"body": "There is already an API to cancel a running execution, however, the current implementation won't be reliable when working on a multi-executor setup. This is caused by the API call that needs to identify which executor is running the agent, and send it to the right executor to make it work. Instead of... | 2ca18d77a48e786d74a4c2373ac25a7a10337afd | {
"head_commit": "a3325ca1873d8ae872c1a54f13a2f04c4c92506a",
"head_commit_message": "Move names to variables",
"patch_to_review": "diff --git a/autogpt_platform/autogpt_libs/autogpt_libs/logging/utils.py b/autogpt_platform/autogpt_libs/autogpt_libs/logging/utils.py\nindex 4d7481da515d..8abf04c2261b 100644\n--- a/... | [
{
"diff_hunk": "@@ -952,31 +1011,110 @@ def run_service(self):\n logger.info(f\"[{self.service_name}] ⏳ Connecting to Redis...\")\n redis.connect()\n \n- sync_manager = multiprocessing.Manager()\n+ logger.info(f\"[{self.service_name}] Ready to consume messages...\")\n while... | 573e9b9f4dcfb534192e5afd423764a7cf3c5da5 | diff --git a/autogpt_platform/backend/backend/executor/manager.py b/autogpt_platform/backend/backend/executor/manager.py
index 9596434806ad..7f93a8436aaa 100644
--- a/autogpt_platform/backend/backend/executor/manager.py
+++ b/autogpt_platform/backend/backend/executor/manager.py
@@ -5,11 +5,15 @@
import signal
import ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
ManimCommunity__manim-1949@a21e255 | ManimCommunity/manim | Python | 1,949 | Rewrite installation instructions from scratch | <!-- Thank you for contributing to Manim! Learn more about the process in our contributing guidelines: https://docs.manim.community/en/latest/contributing.html -->
## Overview: What does this pull request change?
This cleans up the installation instructions and tries to make them less confusing.
<!--changelog-... | 2021-08-23T00:44:05Z | Transfer Docker installation and usage instructions to documentation
## Enhancement proposal
The instructions are currently in the README, but should be transferred to the documentation so that everything is organized in one place.
## Additional comments
<!-- Add further context that you think might be relevant.... | [
{
"body": "## Enhancement proposal\r\nThe instructions are currently in the README, but should be transferred to the documentation so that everything is organized in one place.\r\n\r\n\r\n## Additional comments\r\n<!-- Add further context that you think might be relevant. -->\r\n",
"number": 1909,
"titl... | 97109e75b43ce37359be2ea89046de1c2412a4ad | {
"head_commit": "a21e25579ea79a0a5a11b915a13ae5cfaedd5c6a",
"head_commit_message": "cleaned up linux installation instructions",
"patch_to_review": "diff --git a/docs/source/_static/windows_cairo.png b/docs/source/_static/windows_cairo.png\ndeleted file mode 100644\nindex e9691edda9..0000000000\nBinary files a/d... | [
{
"diff_hunk": "@@ -1,174 +1,149 @@\n Linux\n =====\n \n-The following instructions are given for different Linux distributions that use\n-different package managers. After executing the instructions corresponding to\n-your distribution, go to `Certifying a clean install`_ to check whether the\n-dependencies a... | cde6c638922ffa5864f69f46a79cfe9ec0ff87a7 | diff --git a/docs/source/_static/windows_cairo.png b/docs/source/_static/windows_cairo.png
deleted file mode 100644
index e9691edda9..0000000000
Binary files a/docs/source/_static/windows_cairo.png and /dev/null differ
diff --git a/docs/source/_static/windows_miktex.png b/docs/source/_static/windows_miktex.png
deleted ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Documentation Updates"
} | |
ManimCommunity__manim-2025@8f7b269 | ManimCommunity/manim | Python | 2,025 | Implemented :meth:`.CoordinateSystem.input_to_graph_coords` and fixed :meth:`.CoordinateSystem.angle_of_tangent` | <!-- Thank you for contributing to Manim! Learn more about the process in our contributing guidelines: https://docs.manim.community/en/latest/contributing.html -->
## Overview: What does this pull request change?
<!-- If there is more information than the PR title that should be added to our release changelog, add ... | 2021-09-07T17:08:47Z | Typo in coordinate_systems
At `manim/mobject/coordinate_systems.py` line 195 and 196, the origin code is
```python
def get_y_unit_size(self):
return self.get_x_axis().get_unit_size()
```
And it should be
```python
def get_y_unit_size(self):
return self.get_y_axis().get_unit_size()
... | [
{
"body": "At `manim/mobject/coordinate_systems.py` line 195 and 196, the origin code is \r\n\r\n```python\r\n def get_y_unit_size(self):\r\n return self.get_x_axis().get_unit_size()\r\n```\r\n\r\nAnd it should be\r\n```python\r\n def get_y_unit_size(self):\r\n return self.get_y_axis().get_u... | 632a11f4d2b715600ddc1ce93a702b934d852040 | {
"head_commit": "8f7b2692f6b4cd230ddeee3ecb69099a30a978f4",
"head_commit_message": "Merge branch 'main' into coord-sys",
"patch_to_review": "diff --git a/manim/mobject/coordinate_systems.py b/manim/mobject/coordinate_systems.py\nindex c660d8d6bb..b605eef5d4 100644\n--- a/manim/mobject/coordinate_systems.py\n+++ ... | [
{
"diff_hunk": "@@ -814,6 +814,29 @@ def construct(self):\n f\"x={x} not located in the range of the graph ([{self.p2c(graph.get_start())[0]}, {self.p2c(graph.get_end())[0]}])\",\n )\n \n+ def input_to_graph_coords(self, x: float, graph: \"ParametricFunction\") -> Tuple:\n... | 2f90bce0e391ec9ddf5708a980e5f5f979fdd56f | diff --git a/manim/mobject/coordinate_systems.py b/manim/mobject/coordinate_systems.py
index ad56bcbffc..155fb8eb48 100644
--- a/manim/mobject/coordinate_systems.py
+++ b/manim/mobject/coordinate_systems.py
@@ -943,6 +943,30 @@ def construct(self):
f"x={x} not located in the range of the graph ([{s... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
ManimCommunity__manim-1847@088448d | ManimCommunity/manim | Python | 1,847 | Allow :class:`~.Cross` to be created without requiring a mobject | <!--
Thanks for your contribution to ManimCommunity!
Before filling in the details, ensure:
- Your local changes are up-to-date with ManimCommunity/manim
- The title of your PR gives a descriptive summary to end-users. Some examples:
- Fixed last animations not running to completion
- Added gradient su... | 2021-08-01T14:39:03Z | Allow `Cross` to be initialized without being based on an existing Mobject.
## Enhancement proposal
<!-- Add a clear and concise description of your enhancement proposal. In particular,
if your enhancement introduces changes to the API, illustrate them with
(fictional) code examples. -->
Currently Cross... | I could take this up, if its not an urgent fix.
PS: It would be my first contribution.
Sure, it's not urgent! I've assigned you to it👍 | [
{
"body": "## Enhancement proposal\r\n<!-- Add a clear and concise description of your enhancement proposal. In particular,\r\n if your enhancement introduces changes to the API, illustrate them with\r\n (fictional) code examples. -->\r\n\r\nCurrently Cross needs a mobject passed to it, I think it shoul... | 23e1b9f4e0f754fdd2c7a2033daa2740612d321b | {
"head_commit": "088448d380a2a06a63cbff2bcf8b8a9c053f7e7b",
"head_commit_message": "Align Parameters doc text\n\nCo-authored-by: Jan-Hendrik Müller <44469195+kolibril13@users.noreply.github.com>",
"patch_to_review": "diff --git a/manim/mobject/shape_matchers.py b/manim/mobject/shape_matchers.py\nindex 4d4f39dde7... | [
{
"diff_hunk": "@@ -117,13 +119,44 @@ def get_fill_color(self):\n \n \n class Cross(VGroup):\n- def __init__(self, mobject, stroke_color=RED, stroke_width=6, **kwargs):\n- VGroup.__init__(\n- self,\n- Line(UP + LEFT, DOWN + RIGHT),\n- Line(UP + RIGHT, DOWN + LEFT),\n+ ... | b05f27010872e5bf0c340abd3277813d94f6c786 | diff --git a/manim/mobject/shape_matchers.py b/manim/mobject/shape_matchers.py
index 4d4f39dde7..09134c8d90 100644
--- a/manim/mobject/shape_matchers.py
+++ b/manim/mobject/shape_matchers.py
@@ -2,10 +2,12 @@
__all__ = ["SurroundingRectangle", "BackgroundRectangle", "Cross", "Underline"]
+from typing import Option... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
Significant-Gravitas__AutoGPT-7328@5d92f47 | Significant-Gravitas/AutoGPT | Python | 7,328 | feat(autogpt_builder): Add simple `AutoGPTServerAPI` client | API logic is currently scattered throughout `Flow.tsx` and only partially implemented. This is a first shot at a simple API client with fully typed inputs and outputs, to make all our lives a bit easier :)
* Resolves #7327
### Changes
- feat(autogpt_builder): Add `AutoGPTServerAPI` client
- Migrate API calls in... | 2024-07-05T07:37:00Z | autogpt_builder: Add simple `autogpt_server` API client
API logic is currently scattered throughout `Flow.tsx` and only partially implemented. This is not sustainable and makes it not-reusable.
Let's move the API logic to a simple API client that we can import from other places in the application. | [
{
"body": "API logic is currently scattered throughout `Flow.tsx` and only partially implemented. This is not sustainable and makes it not-reusable.\r\n\r\nLet's move the API logic to a simple API client that we can import from other places in the application.",
"number": 7327,
"title": "autogpt_builder... | b7a90ce768d193e833608e0ecb7ae1ccf81a424d | {
"head_commit": "5d92f476500a2e18c14b5dfab016d038cae9bfd4",
"head_commit_message": "migrate API calls in Flow.tsx to new API client",
"patch_to_review": "diff --git a/rnd/autogpt_builder/src/components/Flow.tsx b/rnd/autogpt_builder/src/components/Flow.tsx\nindex c07a9781be29..6baa3a715356 100644\n--- a/rnd/auto... | [
{
"diff_hunk": "@@ -0,0 +1,184 @@\n+import { XYPosition } from \"reactflow\";\n+\n+export default class AutoGPTServerAPI {\n+ private baseUrl: string;\n+\n+ constructor(baseUrl: string = \"http://localhost:8000\") {\n+ this.baseUrl = baseUrl;\n+ }\n+\n+ async getBlocks(): Promise<Block[]> {\n+ try {\n... | 4b7d57b3cbb7a60bcde5cb3b6d3c935715bcdbc6 | diff --git a/rnd/autogpt_builder/src/components/Flow.tsx b/rnd/autogpt_builder/src/components/Flow.tsx
index c07a9781be29..fc4deadf8faf 100644
--- a/rnd/autogpt_builder/src/components/Flow.tsx
+++ b/rnd/autogpt_builder/src/components/Flow.tsx
@@ -15,19 +15,14 @@ import ReactFlow, {
import 'reactflow/dist/style.css';
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
Significant-Gravitas__AutoGPT-7169@4b69090 | Significant-Gravitas/AutoGPT | Python | 7,169 | feat(forge/llm): Add basic support for GPT-4o | ### **User description**
### Background
<!-- Clearly explain the need for these changes: -->
Open AI recently released GPT-4o
### Changes 🏗️
<!-- Concisely describe all of the changes made in this pull request: -->
Adds a new model info for GPT-4o
Closes #7155
### PR Quality Scorecard ✨
<!--
... | 2024-05-24T01:27:15Z | support for gpt-4o?
### Duplicates
- [X] I have searched the existing issues
### Summary 💡
was wondering when this would be supported or how i might add it myself if it's just a text value in a collection. the application rejects it on start as not being valid
### Examples 🌈
_No response_
### Motivation 🔦
_N... | update: i tracked down what needs to be done here, aside from updating the openai provider
the tiktoken package needs to be updated to 0.7.0 which has gpt-4o
however it cannot be updated because autogpt-forge 0.1.0 has a hard requirement of 0.5.0 tiktoken
but if you upgrade to autogpt-forge 0.1.4 which suppor... | [
{
"body": "### Duplicates\n\n- [X] I have searched the existing issues\n\n### Summary 💡\n\nwas wondering when this would be supported or how i might add it myself if it's just a text value in a collection. the application rejects it on start as not being valid\n\n### Examples 🌈\n\n_No response_\n\n### Motiva... | edcbbbce257c29de69f41a348efad14cc46eb3dc | {
"head_commit": "4b69090fc67eed5d20c578423aa5ec43959ba181",
"head_commit_message": "Merge branch 'master' into gpt4-o",
"patch_to_review": "diff --git a/forge/forge/llm/providers/openai.py b/forge/forge/llm/providers/openai.py\nindex 7f0d55384630..2bdc6c6ddb99 100644\n--- a/forge/forge/llm/providers/openai.py\n+... | [
{
"diff_hunk": "@@ -80,6 +80,8 @@ class OpenAIModelName(str, enum.Enum):\n GPT4_VISION = \"gpt-4-vision-preview\"\n GPT4 = GPT4_ROLLING\n GPT4_32k = GPT4_ROLLING_32k\n+ GPT4_O = \"gpt-4o-2024-05-13\"\n+ GPT4_O_ROLLING = GPT4_O",
"line": null,
"original_line": 84,
"original_start_li... | b0897845772fdbdd0140a8a42440a8bfdaad7613 | diff --git a/forge/forge/llm/providers/openai.py b/forge/forge/llm/providers/openai.py
index 7f0d55384630..5f8c6c1a8793 100644
--- a/forge/forge/llm/providers/openai.py
+++ b/forge/forge/llm/providers/openai.py
@@ -78,8 +78,11 @@ class OpenAIModelName(str, enum.Enum):
GPT4_TURBO = "gpt-4-turbo"
GPT4_TURBO_PRE... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "New Feature Additions"
} |
ManimCommunity__manim-1694@ed540ff | ManimCommunity/manim | Python | 1,694 | Added ``font_size`` parameter for :class:`~.Tex` and :class:`~.Text`, replaced ``scale`` parameters with ``font_size`` | <!--
Thanks for your contribution to ManimCommunity!
Before filling in the details, ensure:
- Your local changes are up-to-date with ManimCommunity/manim
- The title of your PR gives a descriptive summary to end-users. Some examples:
- Fixed last animations not running to completion
- Added gradient sup... | 2021-06-15T06:10:45Z | Allow for `font_size` to be specified using `DecimalNumber`, `Tex/MathTex` and `Text`
## Enhancement proposal
<!-- Add a clear and concise description of your enhancement proposal. In particular,
if your enhancement introduces changes to the API, illustrate them with
(fictional) code examples. -->
Curre... | Hmm, `Text` already has this parameter for setting `font_size` called `size`.
I think an explicit parameter that follows traditional numbering (like in documents) would be helpful. The default for manimgl is `font_size`=48
for `Text` without https://github.com/ManimCommunity/manim/issues/1390 having that parameter is u... | [
{
"body": "## Enhancement proposal\r\n<!-- Add a clear and concise description of your enhancement proposal. In particular,\r\n if your enhancement introduces changes to the API, illustrate them with\r\n (fictional) code examples. -->\r\n\r\nCurrently in manimgl, the size of a string of text can be adju... | 44f2f3704400545ec65bfcf1705474a0e66dba1b | {
"head_commit": "ed540ff294c91deec0c1f846b36623f0cc865ba4",
"head_commit_message": "fix error when self.height ==0",
"patch_to_review": "diff --git a/docs/source/examples.rst b/docs/source/examples.rst\nindex b0ff789f0c..287c328f92 100644\n--- a/docs/source/examples.rst\n+++ b/docs/source/examples.rst\n@@ -457,8... | [
{
"diff_hunk": "@@ -15,17 +15,17 @@ def construct(self):\n s6 = Square()\n s7 = Square()\n VGroup(s5, s6, s7).set_x(0).arrange(buff=2.6).shift(2 * DOWN)\n- t1 = Text(\"Write\").scale(0.5).next_to(s1, UP)\n- t2 = Text(\"AddTextLetterByLetter\").scale(0.5)... | 1e213b1082a760e0163a5c27f949e19c5df62589 | diff --git a/docs/source/examples.rst b/docs/source/examples.rst
index b0ff789f0c..ae67dc88f0 100644
--- a/docs/source/examples.rst
+++ b/docs/source/examples.rst
@@ -457,8 +457,8 @@ Special Camera Settings
image = ImageMobject(np.uint8([[0, 100, 30, 200],
[255, ... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
Significant-Gravitas__AutoGPT-7629@a816b7a | Significant-Gravitas/AutoGPT | Python | 7,629 | feat(builder): Addition of prettier for aligned of development styles | ### **User description**
### Background
Resolves: [Implement Prettier for Code Formatting #7628](https://github.com/Significant-Gravitas/AutoGPT/issues/7628)
We currently do not have a formatter in action for our "Builder". This PR will help move PR's across the line faster and align our development styles.
#... | 2024-07-27T02:08:59Z | [Builder]: Implement Prettier for Code Formatting
### Duplicates
- [X] I have searched the existing issues
### Summary 💡
Integration of Prettier, an opinionated code formatter, into the project to ensure consistent code formatting across all files.
Consistent code formatting is crucial for maintaining readabilit... | [
{
"body": "### Duplicates\n\n- [X] I have searched the existing issues\n\n### Summary 💡\n\nIntegration of Prettier, an opinionated code formatter, into the project to ensure consistent code formatting across all files.\r\n\r\nConsistent code formatting is crucial for maintaining readability and reducing the li... | 52bd033a02e832892fc2a39d2a1bdd2432c87851 | {
"head_commit": "a816b7a860d02280d01fff64cbb5c854d2d6d93c",
"head_commit_message": "feat(builder): Running script \"format\" and merging master",
"patch_to_review": "diff --git a/.github/workflows/autogpt-builder-ci.yml b/.github/workflows/autogpt-builder-ci.yml\nindex c7ccb77bf409..47e887b58fa7 100644\n--- a/.g... | [
{
"diff_hunk": "@@ -0,0 +1,15 @@\n+{",
"line": null,
"original_line": 1,
"original_start_line": null,
"path": "rnd/autogpt_builder/.prettierrc.json",
"start_line": null,
"text": "@user1:\nLet's work with Prettier's defaults for now. No need for this file.\n\n@author:\nSounds good, I'll k... | a5eb3ac3ba9428455253eedb60b59fc7689bbfef | diff --git a/.github/workflows/autogpt-builder-ci.yml b/.github/workflows/autogpt-builder-ci.yml
index c7ccb77bf409..7da81c99389b 100644
--- a/.github/workflows/autogpt-builder-ci.yml
+++ b/.github/workflows/autogpt-builder-ci.yml
@@ -17,6 +17,7 @@ defaults:
working-directory: rnd/autogpt_builder
jobs:
+
lin... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Code Style, Linting, Formatting Fixes"
} | |
ManimCommunity__manim-1841@eeec3a2 | ManimCommunity/manim | Python | 1,841 | Reduced default resolution of :class:`~.Dot3D` | <!--
Thanks for your contribution to ManimCommunity!
Before filling in the details, ensure:
- Your local changes are up-to-date with ManimCommunity/manim
- The title of your PR gives a descriptive summary to end-users. Some examples:
- Fixed last animations not running to completion
- Added gradient sup... | 2021-07-29T08:20:20Z | Reduce the resolution of `Dot3D`
## Enhancement proposal
Currently, `Dot3D` uses the default `Sphere` resolution of (12, 24). Running a scene with lots of `Dot3D`s, like a scene with polyhedra, takes incredibly long because of the high resolution. I think a resolution of (8, 8) is a good balance between speed and visu... | Hi! Can I pick up this issue ? I am a newbie to this project and would like to contribute whatever I can!
Sure! I've assigned you to this issue 👍 | [
{
"body": "## Enhancement proposal\r\nCurrently, `Dot3D` uses the default `Sphere` resolution of (12, 24). Running a scene with lots of `Dot3D`s, like a scene with polyhedra, takes incredibly long because of the high resolution. I think a resolution of (8, 8) is a good balance between speed and visual looks. Af... | fbc8c4a2829b72da275a3fad7d00dbb3b0660234 | {
"head_commit": "eeec3a203993743c6ec2b10b653f2b8757cebe02",
"head_commit_message": "added parameter to reduce resolution of Dot3D",
"patch_to_review": "diff --git a/manim/mobject/three_dimensions.py b/manim/mobject/three_dimensions.py\nindex cf1e0e6bd3..ec6a62fa60 100644\n--- a/manim/mobject/three_dimensions.py\... | [
{
"diff_hunk": "@@ -340,7 +340,7 @@ def construct(self):\n \"\"\"\n \n def __init__(self, point=ORIGIN, radius=DEFAULT_DOT_RADIUS, color=WHITE, **kwargs):\n- Sphere.__init__(self, center=point, radius=radius, **kwargs)\n+ Sphere.__init__(self, center=point, radius=radius, resolution=(8, 8)... | a967f9d43aa9b8fb996508db4338ad6c868dcf91 | diff --git a/manim/mobject/three_dimensions.py b/manim/mobject/three_dimensions.py
index cf1e0e6bd3..87f09c1528 100644
--- a/manim/mobject/three_dimensions.py
+++ b/manim/mobject/three_dimensions.py
@@ -339,8 +339,15 @@ def construct(self):
self.add(axes, dot_1, dot_2,dot_3)
"""
- def __init_... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Performance Optimizations"
} |
Subsets and Splits
Review Test Instances
Retrieves basic metadata about code review instances but doesn't provide any analytical insights or patterns beyond raw data access.