instance_id stringlengths 21 53 | repo stringclasses 188
values | language stringclasses 1
value | pull_number int64 20 148k | title stringlengths 6 144 | body stringlengths 0 83.4k | created_at stringdate 2015-09-25 03:17:17 2025-07-10 16:50:35 | problem_statement stringlengths 188 240k | hints_text stringlengths 0 145k | resolved_issues listlengths 1 6 | base_commit stringlengths 40 40 | commit_to_review dict | reference_review_comments listlengths 1 62 | merged_commit stringlengths 40 40 | merged_patch stringlengths 297 9.87M | metadata dict |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
ManimCommunity__manim-1509@449c22c | ManimCommunity/manim | Python | 1,509 | Copyedited Documentation | <!--
Thanks for your contribution to ManimCommunity!
Before filling in the details, ensure:
- Your local changes are up-to-date with ManimCommunity/manim
- The title of your PR gives a descriptive summary to end-users. Some examples:
- Fixed last animations not running to completion
- Added gradient sup... | 2021-05-14T09:21:05Z | Copyediting of documentation
## Enhancement proposal
As I look through the docs, I'll make a list here of pages that could do with some copyediting. Most of these pages are relatively well-written and only need some minor corrections. I think it'll be a good task for new contributors who are proficient with English.
... | I can spend some time working on this.
Assign me this. | [
{
"body": "## Enhancement proposal\r\nAs I look through the docs, I'll make a list here of pages that could do with some copyediting. Most of these pages are relatively well-written and only need some minor corrections. I think it'll be a good task for new contributors who are proficient with English.\r\n\r\n- ... | 6c86d513f1a8d69835431cd242b642aeba78d6a8 | {
"head_commit": "449c22cb71a95deaec8965c9be41efc53ae17bd7",
"head_commit_message": "Finished copyedititng",
"patch_to_review": "diff --git a/docs/source/installation/for_dev.rst b/docs/source/installation/for_dev.rst\nindex 67de4e9e56..b5c7d5fdc1 100644\n--- a/docs/source/installation/for_dev.rst\n+++ b/docs/sou... | [
{
"diff_hunk": "@@ -244,8 +244,8 @@ your scene by calling the :meth:`~.Scene.play` method.\n Put simply, animations are procedures that interpolate between two mobjects.\n For example, :code:`FadeIn(square)` starts with a fully transparent version of\n :code:`square` and ends with a fully opaque version, interp... | d0e718fae78578ea56e1ae3eefd31c597a6b0e1c | diff --git a/docs/source/installation/for_dev.rst b/docs/source/installation/for_dev.rst
index 67de4e9e56..a938355636 100644
--- a/docs/source/installation/for_dev.rst
+++ b/docs/source/installation/for_dev.rst
@@ -1,7 +1,8 @@
-Manim Installation For Developers
-=================================
+For Developers
+======... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "Documentation Updates"
} |
ManimCommunity__manim-1975@9b5a6e4 | ManimCommunity/manim | Python | 1,975 | Improved CLI help page styling | <!-- Thank you for contributing to Manim! Learn more about the process in our contributing guidelines: https://docs.manim.community/en/latest/contributing.html -->
## Overview: What does this pull request change?
<!-- If there is more information than the PR title that should be added to our release changelog, add ... | 2021-08-30T01:21:11Z | Default command line help does not make mention of the subhelp pages
## Enhancement proposal
Running `manim --help` gives the following:
```
Manim Community v0.9.0
Usage: manim [OPTIONS] COMMAND [ARGS]...
Animation engine for explanatory math videos
Options:
--version Show version and exit.
--hel... | I'm picking up this issue
I'd rather they be obtained with the program (/command) name alone. Cloup/Click both have the `no_args_is_help=True` option which is more convenient (e.g. `manim` produces the main help page, `manim render` the help page for render command, etc.). I agree though that the mention of command hel... | [
{
"body": "## Enhancement proposal\r\nRunning `manim --help` gives the following:\r\n\r\n```\r\nManim Community v0.9.0\r\n\r\nUsage: manim [OPTIONS] COMMAND [ARGS]...\r\n\r\n Animation engine for explanatory math videos\r\n\r\nOptions:\r\n --version Show version and exit.\r\n --help Show this message an... | 5f490a98814b019a4b9e9c01c4e67278347c61f1 | {
"head_commit": "9b5a6e45218075b48a099edf52c410ec835cd611",
"head_commit_message": "Merge branch 'main' into CLI",
"patch_to_review": "diff --git a/docs/source/tutorials/configuration.rst b/docs/source/tutorials/configuration.rst\nindex 868f0abcd6..a371fcd561 100644\n--- a/docs/source/tutorials/configuration.rst... | [
{
"diff_hunk": "@@ -0,0 +1,71 @@\n+\"\"\"DefaultGroup allows a subcommand to act as the main command\n+\n+In particular, this class is what allows `manim` to act as `manim render`.\n+\"\"\"\n+import cloup\n+\n+from .. import logger\n+\n+__all__ = [\"DefaultGroup\"]\n+\n+\n+class DefaultGroup(cloup.Group):\n+ ... | e5cb6065e0adfeee957784f46574ac34e51d7d1d | diff --git a/docs/source/tutorials/configuration.rst b/docs/source/tutorials/configuration.rst
index 46c32cbda2..17cdfecc90 100644
--- a/docs/source/tutorials/configuration.rst
+++ b/docs/source/tutorials/configuration.rst
@@ -363,3 +363,41 @@ A list of all config options
'upto_animation_number', 'use_opengl_render... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
ManimCommunity__manim-1461@adf4010 | ManimCommunity/manim | Python | 1,461 | Build the docs - Logging | ## Changelog / Overview
<!--changelog-start-->
<!--changelog-end-->
## Motivation
The logging while building the docs is currently hardly usable.
closes #1456
## Explanation for Changes
...I tried to fix that by disabling manims info logs while rendering and summarizing relevant metrics after the build ... | 2021-05-04T06:22:36Z | Improving the "Build the docs" logging
## Description of proposed feature
The "Build the docs" log is barely usable because it is messy.
Some things I'd like to see changed:
- Reduce the manim rendering log.
- Log the time each example rendering takes.
- Log the time rendering all examples takes.
- (Log what ... | ...I am working on this. | [
{
"body": "## Description of proposed feature\r\nThe \"Build the docs\" log is barely usable because it is messy.\r\n\r\nSome things I'd like to see changed:\r\n\r\n- Reduce the manim rendering log.\r\n- Log the time each example rendering takes.\r\n- Log the time rendering all examples takes.\r\n- (Log what am... | 1104f2d7255f026e4942536ffe2e48567da6f680 | {
"head_commit": "adf40102d2e438fc4bb46f472673661632fb0b8b",
"head_commit_message": "use csv module",
"patch_to_review": "diff --git a/.gitignore b/.gitignore\nindex e1490a2b56..7f73a68744 100644\n--- a/.gitignore\n+++ b/.gitignore\n@@ -59,6 +59,7 @@ docs/build/\n docs/source/_autosummary/\n docs/source/reference... | [
{
"diff_hunk": "@@ -265,6 +279,55 @@ def run(self):\n return []\n \n \n+rendering_times_file_path = \"../rendering_times.csv\"",
"line": null,
"original_line": 282,
"original_start_line": null,
"path": "docs/source/manim_directive.py",
"start_line": null,
"text": "@user1:\nTry us... | 004eb31c9cb82aa32180d3e81e4ab57c10e33fdb | diff --git a/.gitignore b/.gitignore
index e1490a2b56..7f73a68744 100644
--- a/.gitignore
+++ b/.gitignore
@@ -59,6 +59,7 @@ docs/build/
docs/source/_autosummary/
docs/source/reference/
docs/source/_build/
+docs/rendering_times.csv
# PyBuilder
target/
diff --git a/docs/Makefile b/docs/Makefile
index 846802ddae..... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Test Suite / CI Enhancements"
} |
Significant-Gravitas__AutoGPT-5441@b3252cc | Significant-Gravitas/AutoGPT | Python | 5,441 | Restructuring The Docs | Updating and Restructuring the docs.
people working on this: @Bentlybro @Yash-Ambekar @sohamtembhurne @BarneyChambers @ConTronTech
- [x] Move all specific documentation about Auto-GPT (the agent) into a subfolder
- [x] Update setup & usage instructions to match the new repo structure
- [x] Create subfolders w... | 2023-10-01T16:43:18Z | Restructure documentation website
Now that `Auto-GPT-Benchmarks` and friends have been fused into the `Auto-GPT` repo, the documentation should be restructured to accommodate for chapters on the benchmark, forge, and front end.
## To do
- [ ] Move all specific documentation about Auto-GPT (the agent) into a subfolder
... | @Pwuts By creating a main page do you mean changing this section of the docs? as there is literally no explanation of what AutoGPT does.
@Yash-Ambekar yep!
@Pwuts Can I just add content to the main page and... | [
{
"body": "Now that `Auto-GPT-Benchmarks` and friends have been fused into the `Auto-GPT` repo, the documentation should be restructured to accommodate for chapters on the benchmark, forge, and front end.\n\n## To do\n- [ ] Move all specific documentation about Auto-GPT (the agent) into a subfolder\n - [ ] U... | a1d60878141116641ea864ef6de7ca6142e9534c | {
"head_commit": "b3252cc048029c96deb53c1cd3f0345c91c44b94",
"head_commit_message": "introduction.md: fix",
"patch_to_review": "diff --git a/docs/content/setup.md b/docs/content/AutoGPT/Setups/Docker-setup.md\nsimilarity index 60%\nrename from docs/content/setup.md\nrename to docs/content/AutoGPT/Setups/Docker-se... | [
{
"diff_hunk": "@@ -0,0 +1,75 @@\n+### Set up with Git\n+\n+!!! important\n+ Make sure you have [Git](https://git-scm.com/downloads) installed for your OS.\n+\n+!!! info \"Executing commands\"\n+ To execute the given commands, open a CMD, Bash, or Powershell window. \n+ On Windows: press ++win+x++ and... | 4121d79b6e2bb05f25b6bfcc7a41b90fe3b81147 | diff --git a/docs/content/setup.md b/docs/content/AutoGPT/Setups/Docker-setup.md
similarity index 60%
rename from docs/content/setup.md
rename to docs/content/AutoGPT/Setups/Docker-setup.md
index 19fb7b9b50ac..af1c49d1f61a 100644
--- a/docs/content/setup.md
+++ b/docs/content/AutoGPT/Setups/Docker-setup.md
@@ -1,37 +1,... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Documentation Updates"
} |
Significant-Gravitas__AutoGPT-4278@9d30fc0 | Significant-Gravitas/AutoGPT | Python | 4,278 | Fixed #4229 | Resolves: https://github.com/Significant-Gravitas/Auto-GPT/issues/4229
### Background
The defaults need to be adapted for people without access to GPT4 - or the corresponding functions won't work. The default model for people without GPT4 access should be cfg.fast_llm_model and not cfg.smart_llm_model.
### Chang... | 2023-05-17T22:13:58Z | The model: `gpt-4` does not exist / fixing defaults in llm_utils.py
### Duplicates
- [X] I have searched the existing issues
### Summary 💡
the defaults need to be adapted for people without access to GPT4 - or the corresponding functions won't work.
The default model for people without GPT4 access should be ... | Pull request: https://github.com/Significant-Gravitas/Auto-GPT/pull/4278 | [
{
"body": "### Duplicates\r\n\r\n- [X] I have searched the existing issues\r\n\r\n### Summary 💡\r\n\r\nthe defaults need to be adapted for people without access to GPT4 - or the corresponding functions won't work.\r\nThe default model for people without GPT4 access should be cfg.fast_llm_model and not cfg.smar... | c30f5b7d5e5c457ffd1cd458913a4ee4eaaa095d | {
"head_commit": "9d30fc07ae4ca51a7dfdf032ac64cb1a4bd613fc",
"head_commit_message": "Merge branch 'master' into gpt-4-exists",
"patch_to_review": "diff --git a/autogpt/llm/llm_utils.py b/autogpt/llm/llm_utils.py\nindex a77bccbc06ac..41942b990952 100644\n--- a/autogpt/llm/llm_utils.py\n+++ b/autogpt/llm/llm_utils.... | [
{
"diff_hunk": "@@ -293,3 +293,24 @@ def create_embedding(\n ) # normalize the length to one\n chunk_embeddings = chunk_embeddings.tolist()\n return chunk_embeddings\n+\n+\n+def check_smart_llm_model_access() -> None:\n+ \"\"\"Check if smart model is available for use. If not, set to fast model.... | 70f2b972864e62b08fd1cf843163331367035774 | diff --git a/autogpt/configurator.py b/autogpt/configurator.py
index 0fddd1fa8d3c..98bd0b26d079 100644
--- a/autogpt/configurator.py
+++ b/autogpt/configurator.py
@@ -1,9 +1,12 @@
"""Configurator module."""
+from __future__ import annotations
+
import click
from colorama import Back, Fore, Style
from autogpt impo... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ManimCommunity__manim-1454@2d8dffc | ManimCommunity/manim | Python | 1,454 | Fading module enhancements | ## Changelog / Overview
<!--changelog-start-->
Moved functionality of all Fading classes to :class:`~.FadeIn` and :class:`~.FadeOut`. All other fading classes have been deprecated.
<!--changelog-end-->
## Motivation
Closes #1426
## Explanation for Changes
Have a look at the docs. If that doesn't answer all ... | 2021-05-03T09:07:54Z | Fading Module: Removing the clutter
## Enhancement proposal
At the moment, the animation.fading module contains 10 Animation clsses:
`FadeIn`, `FadeInFrom`, `FadeInFromLarge`, `FadeInFromPoint`, `VFadeIn`, `FadeOut`, `FadeOutAndShift`, `FadeOutToPoint`, `VFadeInThenOut`, `VFadeOut`
I think `FadeIn` and `FadeOut`... | [
{
"body": "## Enhancement proposal\r\nAt the moment, the animation.fading module contains 10 Animation clsses:\r\n\r\n`FadeIn`, `FadeInFrom`, `FadeInFromLarge`, `FadeInFromPoint`, `VFadeIn`, `FadeOut`, `FadeOutAndShift`, `FadeOutToPoint`, `VFadeInThenOut`, `VFadeOut`\r\n\r\nI think `FadeIn` and `FadeOut` is eno... | da4f4e026d498d970b689e9b0b6e0d1144994e29 | {
"head_commit": "2d8dffc126d3dae26b4ca1ebe2dc45f93ebecfc1",
"head_commit_message": "Merge branch 'master' into fading-overhaul",
"patch_to_review": "diff --git a/docs/source/examples.rst b/docs/source/examples.rst\nindex 742eb5ffa1..ea198961c1 100644\n--- a/docs/source/examples.rst\n+++ b/docs/source/examples.rs... | [
{
"diff_hunk": "@@ -41,7 +41,7 @@ def construct(self):\n self.add(grid, grid_title) # Make sure title is on top of grid\n self.play(\n FadeOut(title),\n- FadeInFrom(grid_title, direction=DOWN),\n+ FadeIn(grid_title, direction=UP),",
"line": null,
"origi... | 58d5ebaeb9d5e8c913ee798f984dbb24258cffce | diff --git a/docs/source/examples.rst b/docs/source/examples.rst
index 742eb5ffa1..ea198961c1 100644
--- a/docs/source/examples.rst
+++ b/docs/source/examples.rst
@@ -450,12 +450,12 @@ Special Camera Settings
frame_text.next_to(frame, DOWN)
- self.play(Create(frame), FadeInFrom(frame_text, d... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Code Refactoring / Architectural Improvement"
} | |
Significant-Gravitas__AutoGPT-4345@2154ca3 | Significant-Gravitas/AutoGPT | Python | 4,345 | Only take subclasses of AutoGPTPluginTemplate as plugins | this fixes #4215, and is a re-submission of #4217 where i managed to screw up the history of the PR.
### Background
limit plugin detection to classes that implement AutoGPTPluginTemplate (have it as parent),
solving #4215
### Changes
added check to scan_plugin
### Test Plan
create empty plugin, add cla... | 2023-05-22T04:59:42Z | scan_plugin currently will assume any class that has an _abc_impl is a plugin
### ⚠️ Search for existing issues first ⚠️
- [X] I have searched the existing issues, and there is no existing issue for my problem
### Which Operating System are you using?
Docker
### Which version of Auto-GPT are you using?
Master (bra... | [
{
"body": "### ⚠️ Search for existing issues first ⚠️\n\n- [X] I have searched the existing issues, and there is no existing issue for my problem\n\n### Which Operating System are you using?\n\nDocker\n\n### Which version of Auto-GPT are you using?\n\nMaster (branch)\n\n### GPT-3 or GPT-4?\n\nGPT-4\n\n### Steps... | 321edc5e3db0e801430d51aacfa0c343883ee52d | {
"head_commit": "2154ca3b447304259ba4c2f2d192ecd8e4e726ca",
"head_commit_message": "Black formatting",
"patch_to_review": "diff --git a/.gitignore b/.gitignore\nindex 29a0285a86b1..1376ba5dd7c9 100644\n--- a/.gitignore\n+++ b/.gitignore\n@@ -31,7 +31,7 @@ __pycache__/\n build/\n develop-eggs/\n dist/\n-plugins/\... | [
{
"diff_hunk": "@@ -260,10 +260,15 @@ def scan_plugins(config: Config, debug: bool = False) -> List[AutoGPTPluginTempl\n continue\n a_module = getattr(zipped_module, key)\n a_keys = dir(a_module)\n- if (\n- ... | a12d5d94babb0570ef1a774a79ba00fc47b127d9 | diff --git a/.gitignore b/.gitignore
index 29a0285a86b1..1376ba5dd7c9 100644
--- a/.gitignore
+++ b/.gitignore
@@ -31,7 +31,7 @@ __pycache__/
build/
develop-eggs/
dist/
-plugins/
+/plugins/
plugins_config.yaml
downloads/
eggs/
diff --git a/autogpt/plugins/__init__.py b/autogpt/plugins/__init__.py
index d0a4864c59... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
PostHog__posthog-29030@f84d6b9 | PostHog/posthog | Python | 29,030 | feat: Display stickiness data as percentages along with count | ## Problem
Update the stickiness insight to display the data as a percentage instead of the absolute account.
<!-- Who are we building for, what are their needs, why is this important? -->
Closes #16342
## Changes
### Before
<img width="1234" alt="Screenshot 2025-02-20 at 4 41 14 PM" src="https://github.... | 2025-02-20T21:42:11Z | Show stickiness as percentage in addition to absolute count
## Is your feature request related to a problem?
It would be useful to view not just the absolute numbers in stickiness results, but also percentages (funnel style).
## Additional context
Requested in ZEN-3914
#### *Thank you* for your feature requ... | [
{
"body": "## Is your feature request related to a problem?\r\n\r\nIt would be useful to view not just the absolute numbers in stickiness results, but also percentages (funnel style).\r\n\r\n## Additional context\r\n\r\nRequested in ZEN-3914\r\n\r\n#### *Thank you* for your feature request – we love each and ev... | eb04500c656b2e6167cb9676e6d135d54732f487 | {
"head_commit": "f84d6b96c72e7b383cd8def788bb40ce07139fbf",
"head_commit_message": "Display stickiness data as percentages along with count",
"patch_to_review": "diff --git a/frontend/src/scenes/insights/views/InsightsTable/InsightsTable.tsx b/frontend/src/scenes/insights/views/InsightsTable/InsightsTable.tsx\ni... | [
{
"diff_hunk": "@@ -36,13 +38,23 @@ type ValueColumnItemProps = {\n \n export function ValueColumnItem({ index, item, trendsFilter }: ValueColumnItemProps): JSX.Element {\n const { formatPropertyValueForDisplay } = useValues(propertyDefinitionsModel)\n+ const { insightProps } = useValues(insightLogic)\n+... | 20422740ee624143cb256afb9141238178080b23 | diff --git a/frontend/src/scenes/insights/views/InsightsTable/InsightsTable.tsx b/frontend/src/scenes/insights/views/InsightsTable/InsightsTable.tsx
index d4420426ed5bb..d127b000ec057 100644
--- a/frontend/src/scenes/insights/views/InsightsTable/InsightsTable.tsx
+++ b/frontend/src/scenes/insights/views/InsightsTable/I... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
Significant-Gravitas__AutoGPT-3710@ce9ca90 | Significant-Gravitas/AutoGPT | Python | 3,710 | Fix docker volume mounts | This is a quick-fix fixing #1513
### Background
the Issue itself is that the release container is build only including "autogpt", while the documentations docker-compose.yml is trying to mount the local dir assuming its the source dir - which for most users wont be the case, thus the mount will overwrite the con... | 2023-05-02T20:24:46Z | Unable to run built docker container: No module named autogpt
### Duplicates
- [X] I have searched the existing issues
### Steps to reproduce 🕹
Docker buidl goes perfectly fine, albeit with a lot of warning..
docker run -it --env-file=./.env -v ~/auto_gpt_workspace:/app/auto_gpt_workspace autogpt
gives bac... | The fix is on the way with #1425
[Fixed](https://github.com/Significant-Gravitas/Auto-GPT/pull/1516)
edit: oops possibly duplicate by #1425
I just encountered this today after trying to run with Docker (latest).
I reverted from 0.3 to 0.2.2 and it works. Didn't really dig in much past that, but might be worth someb... | [
{
"body": "### Duplicates\n\n- [X] I have searched the existing issues\n\n### Steps to reproduce 🕹\n\nDocker buidl goes perfectly fine, albeit with a lot of warning..\r\n\r\n \r\ndocker run -it --env-file=./.env -v ~/auto_gpt_workspace:/app/auto_gpt_workspace autogpt\r\n\r\ngives back:\r\n\r\n/usr/local/bin/py... | b0c6ed999c30279974926ba8a97e2c891f0b8e25 | {
"head_commit": "ce9ca90998fa5f696aeaad89f4316d8d0a4e8a3a",
"head_commit_message": "this addresses the issues mentioned in #1513",
"patch_to_review": "diff --git a/Dockerfile b/Dockerfile\nindex 6023cefac6ae..d32d4a667d4a 100644\n--- a/Dockerfile\n+++ b/Dockerfile\n@@ -36,5 +36,7 @@ RUN sed -i '/Items below this... | [
{
"diff_hunk": "@@ -54,8 +54,6 @@ Get your OpenAI API key from: [https://platform.openai.com/account/api-keys](htt\n environment:\n MEMORY_BACKEND: ${MEMORY_BACKEND:-redis}\n REDIS_HOST: ${REDIS_HOST:-redis}\n- volumes:\n- - ./:/app",
"line": 5... | 5e667b083b8d6da520a235df73b813c22db05e1a | diff --git a/Dockerfile b/Dockerfile
index 6023cefac6ae..d32d4a667d4a 100644
--- a/Dockerfile
+++ b/Dockerfile
@@ -36,5 +36,7 @@ RUN sed -i '/Items below this point will not be included in the Docker Image/,$d
pip install --no-cache-dir -r requirements.txt
WORKDIR /app
ONBUILD COPY autogpt/ ./autogpt
+ONBUILD COPY ... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
Significant-Gravitas__AutoGPT-3289@4381eee | Significant-Gravitas/AutoGPT | Python | 3,289 | Add makedirs to file operations | <!-- ⚠️ At the moment any non-essential commands are not being merged.
If you want to add non-essential commands to Auto-GPT, please create a plugin instead.
We are expecting to ship plugin support within the week (PR #757).
Resources:
* https://github.com/Significant-Gravitas/Auto-GPT-Plugin-Template
-->
<!-- ... | 2023-04-26T04:35:47Z | download_file fails when downloading to a folder that doesn't exist yet
### ⚠️ Search for existing issues first ⚠️
- [X] I have searched the existing issues, and there is no existing issue for my problem
### Which Operating System are you using?
MacOS
### Which version of Auto-GPT are you using?
Latest Release
##... | I am experiencing this behavior as well. It will talk in circles saying "I am going to to run xyz" then I get back "file not found", where it then says something along the lines of "I apologize for the mistake. Here's the correct command to use:", rinse and repeat | [
{
"body": "### ⚠️ Search for existing issues first ⚠️\n\n- [X] I have searched the existing issues, and there is no existing issue for my problem\n\n### Which Operating System are you using?\n\nMacOS\n\n### Which version of Auto-GPT are you using?\n\nLatest Release\n\n### GPT-3 or GPT-4?\n\nGPT-3.5\n\n### Steps... | 9e17a304dee13e406a5678f263ac307fb4cc7bd0 | {
"head_commit": "4381eeeeb81c329220a6ad438cb0667633893bbf",
"head_commit_message": "Merge branch 'master' into add-makedirs",
"patch_to_review": "diff --git a/autogpt/commands/file_operations.py b/autogpt/commands/file_operations.py\nindex 9999fccf1ed5..f2532e43e174 100644\n--- a/autogpt/commands/file_operations... | [
{
"diff_hunk": "@@ -236,6 +239,9 @@ def download_file(url, filename):\n filename (str): Filename to save the file as\n \"\"\"\n try:\n+ directory = os.path.dirname(filename)\n+ if not os.path.exists(directory):\n+ os.makedirs(directory)",
"line": null,
"original_... | 6a7bb7af465164f6a3c9d528decbe5c97e945b28 | diff --git a/autogpt/commands/file_operations.py b/autogpt/commands/file_operations.py
index 9999fccf1ed5..05f060887003 100644
--- a/autogpt/commands/file_operations.py
+++ b/autogpt/commands/file_operations.py
@@ -142,8 +142,7 @@ def write_to_file(filename: str, text: str) -> str:
return "Error: File has alre... | {
"difficulty": "medium",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
Significant-Gravitas__AutoGPT-1875@cf9cce8 | Significant-Gravitas/AutoGPT | Python | 1,875 | Option to disable working directory restrictions | ### Background
It is constantly unable to access files due to workspace working directory restrictions. An option is needed to remove the restriction on the working directory.
### Changes
- Added new environment variable `WORKING_DIRECTORY_RESTRICTED` that is set to True by default, setting to False will remove th... | 2023-04-16T12:39:30Z | Ability to Navigate Outside Working Directory.
Currently, the best workaround is bringing the desired context into the working directory, but implementing the ability to crawl through files more gracefully would be great. Perhaps for fully autonomous users, this could be an opt-in or out type thing.
SYSTEM: Command... | Yeah, it's an interesting option.
I think the major concern from that though would be that it could, and would easily delete/overwrite files.
I have been playing about with the same approach as you, cloning the repo into the AI's working directory! 😆
Thank you so much for the kind words 😊 I'm glad you're enjoyi... | [
{
"body": "Currently, the best workaround is bringing the desired context into the working directory, but implementing the ability to crawl through files more gracefully would be great. Perhaps for fully autonomous users, this could be an opt-in or out type thing.\r\n\r\nSYSTEM: Command read_file returned: Err... | 24d5e1fc8aa5787c504294cc2280be45a6590a0a | {
"head_commit": "cf9cce88ee47e5170342702b32c73ec3be10cd54",
"head_commit_message": "Updating if statement on check",
"patch_to_review": "diff --git a/autogpt/commands/execute_code.py b/autogpt/commands/execute_code.py\nindex 86d6c177b796..0e824aed362a 100644\n--- a/autogpt/commands/execute_code.py\n+++ b/autogpt... | [
{
"diff_hunk": "@@ -100,9 +100,7 @@ def execute_shell(command_line: str) -> str:\n \"\"\"\n current_dir = os.getcwd()\n # Change dir into workspace if necessary\n- if str(WORKING_DIRECTORY) not in current_dir:\n- work_dir = os.path.join(os.getcwd(), WORKING_DIRECTORY)\n- os.chdir(wo... | 00b845d033b0afa3e1e5339125789c2343356879 | diff --git a/.env.template b/.env.template
index 855cb91ffdd0..4fb09cf22a3a 100644
--- a/.env.template
+++ b/.env.template
@@ -3,6 +3,8 @@
################################################################################
# EXECUTE_LOCAL_COMMANDS - Allow local command execution (Example: False)
EXECUTE_LOCAL_COMMANDS=... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
Significant-Gravitas__AutoGPT-3173@b9530c5 | Significant-Gravitas/AutoGPT | Python | 3,173 | Fix multi-byte character handling in `read_file` | ### Background
Related to issue #232 - Multi-byte character handling
User reports UTF files not being read. Some files may be UTF-8 but have a BOM marker which Python can see as invalid, or may not be UTF-8 at all.
### Changes
The read_file command has been updated to detect the file encoding, then use the detect... | 2023-04-24T23:32:46Z | Multi-byte character handling
It appears that Auto-GPT is not working well with other character encodings. I am trying to use it on information written in Portuguese (Brazilian Portuguese) and sometimes it complains about "string indices must be integers" - I believe it is because of characters with accents (as in comu... | @albertodesouza
I completely agree with you, and I'm also experiencing this issue when working with character encodings in languages like Portuguese. It's crucial for Auto-GPT to handle accented characters properly, as it affects the user experience. Having an easier way to switch between languages throughout the en... | [
{
"body": "It appears that Auto-GPT is not working well with other character encodings. I am trying to use it on information written in Portuguese (Brazilian Portuguese) and sometimes it complains about \"string indices must be integers\" - I believe it is because of characters with accents (as in comunicação, ... | 7fc6f2abfc8d4795937839f66e017b4e93a986f4 | {
"head_commit": "b9530c5b33a7c0d50d4abfcb4890b6fe543850b9",
"head_commit_message": "Merge branch 'master' into detect-file-encoding-3158",
"patch_to_review": "diff --git a/autogpt/commands/file_operations.py b/autogpt/commands/file_operations.py\nindex 05f060887003..d66b3fd1213e 100644\n--- a/autogpt/commands/fi... | [
{
"diff_hunk": "@@ -21,6 +21,7 @@ webdriver-manager\n jsonschema\n tweepy\n click\n+chardet>=5.1.0",
"line": null,
"original_line": 24,
"original_start_line": null,
"path": "requirements.txt",
"start_line": null,
"text": "@user1:\nPlease use `charset-normalizer` instead"
}
] | 9df829ac5f5fa8b6cafbe84691ba0452027b4b1a | diff --git a/autogpt/commands/file_operations.py b/autogpt/commands/file_operations.py
index 9563883e4170..28198ebae277 100644
--- a/autogpt/commands/file_operations.py
+++ b/autogpt/commands/file_operations.py
@@ -6,6 +6,7 @@
import os.path
from typing import Dict, Generator, Literal, Tuple
+import charset_normali... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
Significant-Gravitas__AutoGPT-3144@71007de | Significant-Gravitas/AutoGPT | Python | 3,144 | Fix #942: Respect --gpt4only, --gpt3only cli args | ### Background
Addressing #942:
AutoGPT is hard coded to use fast_llm_model for everything except the write_tests, evaluate_code, and improve_code commands. (see https://github.com/Torantulino/Auto-GPT/blob/master/scripts/chat.py#L66 for example)
The result is that even if I use --gpt4only, we still see GPT 3.5 ... | 2023-04-24T16:20:00Z | Only gpt-3.5 being used, without using --gpt3only modifier
### Duplicates
- [X] I have searched the existing issues
### Steps to reproduce 🕹
Run python scripts/main.py with OpenAI api key that supports gp4 usage in env
### Current behavior 😯
Judging by my USAGE page on Open AI, AutoGPT is only making use of gpt... | I have also seen this, I'm not sure on a cause, yet.
from what I can tell. the script defaults to 3.5. you must use the gpt4only flag.
It's hardcoded to use `fast_llm_model` for everything except the `write_tests`, `evaluate_code` and `improve_code` commands. (see https://github.com/Torantulino/Auto-GPT/blob/master/scr... | [
{
"body": "### Duplicates\n\n- [X] I have searched the existing issues\n\n### Steps to reproduce 🕹\n\nRun python scripts/main.py with OpenAI api key that supports gp4 usage in env \n\n### Current behavior 😯\n\nJudging by my USAGE page on Open AI, AutoGPT is only making use of gpt-3.5-turbo-0301 and text-embed... | 1ddf2324ff514e39df82724350fec05c6ec4e22a | {
"head_commit": "71007dece5bb247849b7d87249f27fdd43e86783",
"head_commit_message": "Merge branch 'master' into bug/942-only-gpt35-being-used-fix",
"patch_to_review": "diff --git a/autogpt/agent/agent.py b/autogpt/agent/agent.py\nindex 9b48d540dc83..f26783fd3ddc 100644\n--- a/autogpt/agent/agent.py\n+++ b/autogpt... | [
{
"diff_hunk": "@@ -0,0 +1,20 @@\n+from click.testing import CliRunner\n+from autogpt import cli\n+from autogpt.config.config import Config\n+from autogpt.configurator import GPT_3_MODEL, GPT_4_MODEL\n+\n+def test_gpt4only_cli_arg():\n+ runner = CliRunner()\n+ runner.invoke(cli.main, ['--gpt4only'])",
... | dbb527de2f2ea38c2825a9fd3411d83383f268ab | diff --git a/autogpt/agent/agent.py b/autogpt/agent/agent.py
index a1673ad9b2d1..3dc4d390092b 100644
--- a/autogpt/agent/agent.py
+++ b/autogpt/agent/agent.py
@@ -128,11 +128,13 @@ def signal_handler(signum, frame):
# Send message to AI, get response
with Spinner("Thinking... ", plain_output=c... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
ManimCommunity__manim-1193@2fbace6 | ManimCommunity/manim | Python | 1,193 | Fixed using :class:`~.Animation` without a child :class:`~.Mobject` in :class:`~.AnimationGroup` | <!--
Thanks for your contribution to ManimCommunity!
Before filling in the details, ensure:
- Your local changes are up-to-date with ManimCommunity/manim
- The title of your PR gives a descriptive summary to end-users. Some examples:
- Fixed last animations not running to completion
- Added gradient sup... | 2021-03-29T17:17:27Z | The Wait animation cannot be added to an AnimationGroup
An AnimationGroup expects each animation to have a mobject attribute. The Wait animation does not have a mobject.
Steps to reproduce:
Compile:
```
class animgrouptest(Scene):
def construct(self):
anim = AnimationGroup(Write(Text("a")), Wait(3))
... | [
{
"body": "An AnimationGroup expects each animation to have a mobject attribute. The Wait animation does not have a mobject.\r\n\r\nSteps to reproduce:\r\nCompile:\r\n```\r\nclass animgrouptest(Scene):\r\n def construct(self):\r\n anim = AnimationGroup(Write(Text(\"a\")), Wait(3))\r\n self.play(anim)\r\... | d8d9a01b9a1c6c5d635629d4338ae4e0c329a450 | {
"head_commit": "2fbace61d564ac4fa6672efd5af9031c293cd9b8",
"head_commit_message": "black",
"patch_to_review": "diff --git a/manim/animation/animation.py b/manim/animation/animation.py\nindex aeb16335a5..ad4edb0b75 100644\n--- a/manim/animation/animation.py\n+++ b/manim/animation/animation.py\n@@ -196,6 +196,13 ... | [
{
"diff_hunk": "@@ -2809,6 +2809,11 @@ def build(self):\n \n return anim\n \n+ def is_dummy(self):\n+ from ..animation.animation import animation_is_dummy\n+\n+ return animation_is_dummy(self)\n+",
"line": null,
"original_line": 2816,
"original_start_line": 2812,
"path":... | 721e1d6d1c7d9fd19cb341b8210bc3f5a7772b3e | diff --git a/manim/animation/animation.py b/manim/animation/animation.py
index aeb16335a5..a92e4fb471 100644
--- a/manim/animation/animation.py
+++ b/manim/animation/animation.py
@@ -196,6 +196,9 @@ def set_name(self, name: str) -> "Animation":
def is_remover(self) -> bool:
return self.remover
+ def ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
ManimCommunity__manim-1220@931f367 | ManimCommunity/manim | Python | 1,220 | Added sanity checks to :meth:`~.Mobject.add_to_back` for Mobjects | <!--
Thanks for your contribution to ManimCommunity!
Before filling in the details, ensure:
- Your local changes are up-to-date with ManimCommunity/manim
- The title of your PR gives a descriptive summary to end-users. Some examples:
- Fixed last animations not running to completion
- Added gradient sup... | 2021-04-01T18:46:32Z | Mobjects add_to_back is missing sanity checks
## Description of bug / unexpected behavior
the Mobject.add method contains sanity checks to make sure, no submobject gets added twice and self is not in self.submobjects.
Mobjext.add_to_back is missing this functionality.
## Expected behavior
Adding self should pro... | Thanks for the tip! Sorry it took so long for one of us to respond.
If you'd like to tackle this problem, feel free to, and let me know by commenting. In the mean time I'll tag it as a good first issue. | [
{
"body": "## Description of bug / unexpected behavior\r\nthe Mobject.add method contains sanity checks to make sure, no submobject gets added twice and self is not in self.submobjects.\r\nMobjext.add_to_back is missing this functionality.\r\n\r\n\r\n## Expected behavior\r\nAdding self should produce a ValueErr... | 053e40060d5a7494850e5e834e686afe4e1c4936 | {
"head_commit": "931f36731c17517a844a3599db70dc3ecf1a0613",
"head_commit_message": "Merge branch 'master' into test/1099-mobject-add_to_back",
"patch_to_review": "diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml\nindex 3c820ad6dc..c37b79399c 100644\n--- a/.pre-commit-config.yaml\n+++ b/.pre-commit-... | [
{
"diff_hunk": "@@ -10,4 +10,8 @@ repos:\n - repo: https://gitlab.com/PyCQA/flake8\n rev: 3.9.0\n hooks:\n- - id: flake8\n+ - id: flake8\n+ - repo: https://github.com/PyCQA/isort\n+ rev: 5.8.0\n+ hooks:\n+ - id: isort",
"line": null,
"original_line": 17,
"original_sta... | 7a87bf9091617b251daf2a953355f2598cada5a8 | diff --git a/manim/mobject/mobject.py b/manim/mobject/mobject.py
index 3ac4e65697..a34c191d49 100644
--- a/manim/mobject/mobject.py
+++ b/manim/mobject/mobject.py
@@ -353,9 +353,36 @@ def add_to_back(self, *mobjects: "Mobject") -> "Mobject":
the head of :attr:`submobjects`. The head of this list is rendere... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ManimCommunity__manim-1234@e5a2a29 | ManimCommunity/manim | Python | 1,234 | Added new method :meth:`~.Mobject.get_midpoint` | <!--
Thanks for your contribution to ManimCommunity!
Before filling in the details, ensure:
- Your local changes are up-to-date with ManimCommunity/manim
- The title of your PR gives a descriptive summary to end-users. Some examples:
- Fixed last animations not running to completion
- Added gradient sup... | 2021-04-02T11:34:10Z | New idea for method: `get_middle_point`
Currently, there are a few methods to get positions like `get_start`, `get_end` and `get_center` To get the middle of a line, it would be very convenient to have a method `get_middle_point` as well. It could look something like this:
```py
class Test(Scene):
def construct... | `mob.point_from_proportion(0.5)` could probably be used for this, right? Though for VMobject `point_from_proportion` works a little awkwardly because it doesn't take into account the length of each bezier curve..
I just added another print to my example and this works!
```console
[0.5 0. 0. ]
[0.49992385 0.0087262... | [
{
"body": "Currently, there are a few methods to get positions like `get_start`, `get_end` and `get_center` To get the middle of a line, it would be very convenient to have a method `get_middle_point` as well. It could look something like this:\r\n```py\r\nclass Test(Scene):\r\n def construct(self):\r\n ... | 401355c090a584fa7aa48832ace77abf04a29e3b | {
"head_commit": "e5a2a29512053d8e2e15769da08ff7b90dae0287",
"head_commit_message": "implemented get_midpoint",
"patch_to_review": "diff --git a/manim/mobject/mobject.py b/manim/mobject/mobject.py\nindex e52aa9fb1c..bfe88a52cb 100644\n--- a/manim/mobject/mobject.py\n+++ b/manim/mobject/mobject.py\n@@ -1724,6 +172... | [
{
"diff_hunk": "@@ -1724,6 +1724,29 @@ def get_boundary_point(self, direction):\n index = np.argmax(np.dot(all_points, np.array(direction).T))\n return all_points[index]\n \n+ def get_midpoint(self) -> np.ndarray:\n+ \"\"\"Get coordinates of the middle of the line that forms the :clas... | a7ead706681418e6e2d05cf00e189ee81ec4e2e8 | diff --git a/manim/mobject/mobject.py b/manim/mobject/mobject.py
index 4cff59d5a9..8bb9e54245 100644
--- a/manim/mobject/mobject.py
+++ b/manim/mobject/mobject.py
@@ -1781,6 +1781,29 @@ def get_boundary_point(self, direction):
index = np.argmax(np.dot(all_points, np.array(direction).T))
return all_poi... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "New Feature Additions"
} |
Significant-Gravitas__AutoGPT-45@30f8ed9 | Significant-Gravitas/AutoGPT | Python | 45 | Makes it possible to use gpt-3.5 | (This is such a neat experiment. Thanks for open-sourcing!)
Fixes #12
Fixes #40
Makes davinci-3.5-turbo the default model (faster and cheaper)
Allows for model configuration
I made JSON parsing a lot more forgiving, including using GPT to fix up the JSON if necessary.
I also improved the prompt to make it ... | 2023-04-02T21:42:14Z | The model: `gpt-4` does not exist
Hi,
Amazing work you're doing here! ❤
I'm getting this message:
>
> Traceback (most recent call last):
> File "/Users/stas/Auto-GPT/AutonomousAI/main.py", line 154, in <module>
> assistant_reply = chat.chat_with_ai(prompt, user_input, full_message_history, mem.permanent_... | You can apply for access to the GPT-4 API here:
https://openai.com/waitlist/gpt-4-api
Unfortunately, in my testing when I've tried to run Auto-GPT using GPT3.5 it does not function at all as the model does not understand it's task.
I'm playing with v3.5 thanks to @Koobah fork: https://github.com/Koobah/Auto-GPT
... | [
{
"body": "Hi,\r\nAmazing work you're doing here! ❤\r\nI'm getting this message:\r\n\r\n> \r\n> Traceback (most recent call last):\r\n> File \"/Users/stas/Auto-GPT/AutonomousAI/main.py\", line 154, in <module>\r\n> assistant_reply = chat.chat_with_ai(prompt, user_input, full_message_history, mem.permanent... | 64af11f4ab9b4fe5e6813a3cbe3d343a1f1b5c98 | {
"head_commit": "30f8ed95e10e6b1fb3f7126e9f39d30508745069",
"head_commit_message": "Remove unused imports",
"patch_to_review": "diff --git a/.env.template b/.env.template\nindex a598aa7b1a55..cbf0cd9bc9b4 100644\n--- a/.env.template\n+++ b/.env.template\n@@ -1,2 +1,4 @@\n OPENAI_API_KEY=your-openai-api-key\n ELE... | [
{
"diff_hunk": "@@ -1,3 +1,9 @@\n+import os\n+",
"line": null,
"original_line": 2,
"original_start_line": null,
"path": "scripts/config.py",
"start_line": null,
"text": "@user1:\n```suggestion\r\nimport openai\r\n```"
}
] | 3093ec9369606d2803a8aa8f7e8c2d5e4309e560 | diff --git a/.env.template b/.env.template
index a598aa7b1a55..cbf0cd9bc9b4 100644
--- a/.env.template
+++ b/.env.template
@@ -1,2 +1,4 @@
OPENAI_API_KEY=your-openai-api-key
ELEVENLABS_API_KEY=your-elevenlabs-api-key
+SMART_LLM_MODEL="gpt-4"
+FAST_LLM_MODEL="gpt-3.5-turbo"
\ No newline at end of file
diff --git a/.gi... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
Significant-Gravitas__AutoGPT-757@fe85f07 | Significant-Gravitas/AutoGPT | Python | 757 | Plugin Support | ### Background
Adds basic plugin support.
### Changes
Add plugins.py which handles scanning plugins folder for zipfiles and check for modules to import.
In main.py on startup it will load the plugins into the config file.
In LLM utils it will iterate the plugins on each response.
### Documentation
... | 2023-04-11T02:02:08Z | Framework for optional features
### Duplicates
- [X] I have searched the existing issues
### Summary 💡
We should make some framework for optional features, so that they:
- don't make default configuration harder for newcomers
- don't bloat .env.template
- don't bloat the prompt
- don't bloat the README
### E... | It would be great to have a config file too, not just everything inside the .env as I would assume the environment vars are more important and less optional than just config.
Right now, my feedback as a newcomer:
It is already really hard to tell what is mandatory and what is not, because the Readme first states so... | [
{
"body": "### Duplicates\n\n- [X] I have searched the existing issues\n\n### Summary 💡\n\nWe should make some framework for optional features, so that they:\r\n\r\n- don't make default configuration harder for newcomers\r\n- don't bloat .env.template\r\n- don't bloat the prompt\r\n- don't bloat the README\n\n... | fa91bc154c239f569346d72e81e5b11b24267413 | {
"head_commit": "fe85f079b08f919efecba1374073c9495ef6d5de",
"head_commit_message": "Fix early abort",
"patch_to_review": "diff --git a/README.md b/README.md\nindex 71957748f067..2fad68737df6 100644\n--- a/README.md\n+++ b/README.md\n@@ -253,6 +253,30 @@ export GOOGLE_API_KEY=\"YOUR_GOOGLE_API_KEY\"\n export CUST... | [
{
"diff_hunk": "@@ -17,8 +24,43 @@ def main() -> None:\n check_openai_api_key()\n parse_arguments()\n logger.set_level(logging.DEBUG if cfg.debug_mode else logging.INFO)\n+ plugins_found = load_plugins(Path(os.getcwd()) / \"plugins\")\n+ loaded_plugins = []\n+ for plugin in plugins_found:\n... | c7316754436990972a8eb1139f860b2c35066d66 | diff --git a/.env.template b/.env.template
index f1b511c2291f..60edecd6cac8 100644
--- a/.env.template
+++ b/.env.template
@@ -188,3 +188,10 @@ OPENAI_API_KEY=your-openai-api-key
# TW_CONSUMER_SECRET=
# TW_ACCESS_TOKEN=
# TW_ACCESS_TOKEN_SECRET=
+
+####################################################################... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
ManimCommunity__manim-1140@ed7dc3d | ManimCommunity/manim | Python | 1,140 | Flake8 Compat & Code Cleanup | <!--
Thanks for your contribution to ManimCommunity!
Before filling in the details, ensure:
- Your local changes are up-to-date with ManimCommunity/manim
- The title of your PR gives a descriptive summary to end-users. Some examples:
- Fixed last animations not running to completion
- Added gradient sup... | 2021-03-21T19:45:11Z | Flake8 Support
I suggest that manim start using the flake8 linter. It would allow for cleaner code. It could be integrated with the pre-commit function. The only issue I see with this is that it needs a special config to work with black, but that issue is a small one. | [
{
"body": "I suggest that manim start using the flake8 linter. It would allow for cleaner code. It could be integrated with the pre-commit function. The only issue I see with this is that it needs a special config to work with black, but that issue is a small one.",
"number": 1132,
"title": "Flake8 Supp... | 196045b471acb8ad2a9bffaa9bca078624526174 | {
"head_commit": "ed7dc3dae4acd1d4a8bcab614c335a5b688b11f7",
"head_commit_message": "Code Refactor 3",
"patch_to_review": "diff --git a/.flake8 b/.flake8\nnew file mode 100644\nindex 0000000000..a52fb2eedc\n--- /dev/null\n+++ b/.flake8\n@@ -0,0 +1,9 @@\n+[flake8]\n+max-line-length = 88\n+ #Required... | [
{
"diff_hunk": "@@ -238,13 +238,12 @@ def FetchSceneData(self, request, context):\n else:\n request.scene.background_color = \"#000000\"\n return request\n- except Exception as e:\n+ except Exception:\n traceback.print_exc()\n \n def ScriptUp... | ee924b80f206eb131e29605d77ff1c8a663d8a67 | diff --git a/.flake8 b/.flake8
new file mode 100644
index 0000000000..a56c9abde7
--- /dev/null
+++ b/.flake8
@@ -0,0 +1,21 @@
+[flake8]
+max-line-length = 88
+ #Black Compatability
+extend-ignore = E203, E266,
+ #Style Changes
+
+ #Temp
+ F84... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Code Style, Linting, Formatting Fixes"
} | |
Significant-Gravitas__AutoGPT-7130@d5a70c5 | Significant-Gravitas/AutoGPT | Python | 7,130 | feat(forge/llm): Add `GroqProvider` | ### Background
This has issues with the profile generator, so maybe merge #7121 first
### Changes 🏗️
* Add `GroqProvider` in `forge.llm.providers.groq`
* Add to `llm.providers.multi`
* Add `groq` dependency (v0.8.0)
* Update AutoGPT docs & config template
* Update .env.template
* Update docs
... | 2024-05-07T15:37:30Z | Support using other/local LLMs
You can modify the code to accept a config file as input, and read the Chosen_Model flag to select the appropriate AI model. Here's an example of how to achieve this:
Create a sample config file named config.ini:
[AI]
Chosen_Model = gpt-4
Offload the call_ai_fuction from the ai_... | Excellent work. Lots of people are asking for this submit a pull request!
In order to fully support gpt3.5 (and other models) we need to harden the prompt.
@Koobah had some success by adding this line to the end of prompt.txt:
```
Before submitting the response, simulate parsing the response with Python json.lo... | [
{
"body": "You can modify the code to accept a config file as input, and read the Chosen_Model flag to select the appropriate AI model. Here's an example of how to achieve this:\r\n\r\nCreate a sample config file named config.ini:\r\n\r\n[AI]\r\nChosen_Model = gpt-4\r\n\r\nOffload the call_ai_fuction from the a... | cdae98d36b35c420883f0bd1f776fa4d7a27b9c5 | {
"head_commit": "d5a70c58e1c68f24fed146321931a6d472f7bf29",
"head_commit_message": "Merge branch 'master' into groq",
"patch_to_review": "diff --git a/autogpts/autogpt/.env.template b/autogpts/autogpt/.env.template\nindex 14c7bcaa5d51..6810b8de35bf 100644\n--- a/autogpts/autogpt/.env.template\n+++ b/autogpts/aut... | [
{
"diff_hunk": "@@ -0,0 +1,420 @@\n+from __future__ import annotations\n+\n+import enum\n+import logging\n+from typing import TYPE_CHECKING, Callable, Optional, ParamSpec, TypeVar\n+\n+import sentry_sdk\n+import tenacity\n+import tiktoken\n+from groq import APIConnectionError, APIStatusError\n+from pydantic imp... | bfc8c0bc44494f0b224b81d4d8acf5d4d65ab688 | diff --git a/autogpt/.env.template b/autogpt/.env.template
index e961391d2ca7..5653780d9bde 100644
--- a/autogpt/.env.template
+++ b/autogpt/.env.template
@@ -8,6 +8,9 @@
## ANTHROPIC_API_KEY - Anthropic API Key (Example: sk-ant-api03-xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
OpenMined__PySyft-7011@e442ccb | OpenMined/PySyft | Python | 7,011 | Add support for Hagrid logs & set --tail=false to default | ## Description
fixes #6971
This PR adds a new command to hagrid, which is `hagrid logs`, and generates an output like so.
Also, this PR sets --tail=false to the default behavior in hagrid when launching domain nodes.
<img width="501" alt="Screenshot 2022-11-10 at 02 18 33" src="https://user-images.githubuse... | 2022-11-09T23:23:25Z | "hagrid launch --tail=False" should be default + a table that lists containers and the commands to see their live logs
The new user experience when --tail=False is incredible and by far the best experience for most users (everyone except devs?), especially since there's a definitive "you're fully launched' moment, as o... | I agree we should default to `tail=false`. To provide more access to information we should build `hagrid status` which will show all the known nodes and allow a user to explore them further, either by checking logs or running commands like, land, update, backup, etc. A small step in that direction would be a `hagrid lo... | [
{
"body": "The new user experience when --tail=False is incredible and by far the best experience for most users (everyone except devs?), especially since there's a definitive \"you're fully launched' moment, as opposed to just watching logs until it stops. --tail=false should be the default experience except w... | 2e84528723aa1c805c05a31c1da4059b828d6e7c | {
"head_commit": "e442ccb0fe4ab591dd3a17f162953a29e84585a8",
"head_commit_message": "Merge branch 'dev' into issue_6971",
"patch_to_review": "diff --git a/packages/hagrid/hagrid/cli.py b/packages/hagrid/hagrid/cli.py\nindex f811a2184d8..7a996e4775c 100644\n--- a/packages/hagrid/hagrid/cli.py\n+++ b/packages/hagri... | [
{
"diff_hunk": "@@ -3511,3 +3519,81 @@ def ssh(ip_address: str, cmd: str) -> None:\n \n \n cli.add_command(ssh)\n+\n+\n+# Add hagrid logs command to the CLI\n+@click.command(help=\"Get the logs of the HAGrid service\")\n+@click.argument(\"domain_name\", type=str)\n+def logs(domain_name: str) -> None: # nosec\n... | 9462fed833ea42aaa74ec2abb6f822fd77b015ed | diff --git a/packages/hagrid/hagrid/cli.py b/packages/hagrid/hagrid/cli.py
index f811a2184d8..0c5cd39d341 100644
--- a/packages/hagrid/hagrid/cli.py
+++ b/packages/hagrid/hagrid/cli.py
@@ -1,4 +1,5 @@
# stdlib
+from collections import namedtuple
import json
import os
from pathlib import Path
@@ -183,7 +184,7 @@ def... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
Significant-Gravitas__AutoGPT-7091@65433ba | Significant-Gravitas/AutoGPT | Python | 7,091 | feat(forge/llm): Add `LlamafileProvider` | ### Background
<!-- Clearly explain the need for these changes: -->
This draft PR is a step toward enabling the use of local models in AutoGPT by adding [llamafile](https://github.com/Mozilla-Ocho/llamafile) as an LLM provider.
Implementation notes are included in `forge/forge/llm/providers/llamafile/README.md... | 2024-04-19T16:27:49Z | Support using other/local LLMs
You can modify the code to accept a config file as input, and read the Chosen_Model flag to select the appropriate AI model. Here's an example of how to achieve this:
Create a sample config file named config.ini:
[AI]
Chosen_Model = gpt-4
Offload the call_ai_fuction from the ai_... | Excellent work. Lots of people are asking for this submit a pull request!
In order to fully support gpt3.5 (and other models) we need to harden the prompt.
@Koobah had some success by adding this line to the end of prompt.txt:
```
Before submitting the response, simulate parsing the response with Python json.lo... | [
{
"body": "You can modify the code to accept a config file as input, and read the Chosen_Model flag to select the appropriate AI model. Here's an example of how to achieve this:\r\n\r\nCreate a sample config file named config.ini:\r\n\r\n[AI]\r\nChosen_Model = gpt-4\r\n\r\nOffload the call_ai_fuction from the a... | 0b9f3be6b8c677d71184ff96132ac6c427fa2011 | {
"head_commit": "65433ba0989d1f596eff8641834ec99a2c1c8181",
"head_commit_message": "combine llamafile setup.sh and serve.sh into single cross-platform serve.py",
"patch_to_review": "diff --git a/autogpt/scripts/llamafile/.gitignore b/autogpt/scripts/llamafile/.gitignore\nnew file mode 100644\nindex 000000000000.... | [
{
"diff_hunk": "",
"line": null,
"original_line": null,
"original_start_line": null,
"path": "autogpt/scripts/llamafile/serve.py",
"start_line": null,
"text": "@user1:\nIf this is just as example then fine but otherwise `LLAMAFILE` could be provided as an argument.\n\n@user2:\nImplemente... | bac353e737b9d98e3a82e7e75d4d3f4130929a2e | diff --git a/autogpt/.env.template b/autogpt/.env.template
index 9d458b90a55d..8d4894988c53 100644
--- a/autogpt/.env.template
+++ b/autogpt/.env.template
@@ -11,6 +11,9 @@
## GROQ_API_KEY - Groq API Key (Example: gsk_xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx)
# GROQ_API_KEY=
+## LLAMAFILE_API_BASE - Lla... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
PostHog__posthog-28109@3b5be49 | PostHog/posthog | Python | 28,109 | chore: add device type filtering on surveys | ## Problem
PR for SDK logic: https://github.com/PostHog/posthog-js/pull/1698
Closes https://github.com/PostHog/posthog/issues/24495
## Changes
adds this a new display condition for ... | 2025-01-30T18:09:08Z | Surveys: Allow targeting by device type
## Problem description
Customers would like to target their surveys by device type in the request.
Currently, we have a `Latest Device Type` person property which is asynchronous and doesn't always work since it uses the _last_ URL visited by a person.
We need to introdu... | +1 https://posthoghelp.zendesk.com/agent/tickets/21364
a workaround for now would be calling the surveys API manually when you are on the desired device type (renderSurvey)
https://github.com/PostHog/posthog-js/blob/50f08e979ff5daeed10c29cd22281c26a9e29e87/src/posthog-core.ts#L1262-L1265
https://posthoghelp.zendesk.co... | [
{
"body": "## Problem description\r\n\r\nCustomers would like to target their surveys by device type in the request. \r\nCurrently, we have a `Latest Device Type` person property which is asynchronous and doesn't always work since it uses the _last_ URL visited by a person. \r\n\r\nWe need to introduce somethin... | d2264966b23edb69525c68c4b97ef4d9e7de93fc | {
"head_commit": "3b5be4920939ff20dfbd4d4b026c78151cd5c5eb",
"head_commit_message": "chore: add device type filtering on surveys",
"patch_to_review": "diff --git a/frontend/src/lib/components/PropertyFilters/components/PropertyValue.tsx b/frontend/src/lib/components/PropertyFilters/components/PropertyValue.tsx\ni... | [
{
"diff_hunk": "@@ -666,6 +668,49 @@ export default function SurveyEdit(): JSX.Element {\n />\n </div>\n </LemonField.Pure>\n+ ... | 2e55e50da3fdee5f8ce3f47cabc5c75ef536f503 | diff --git a/cypress/e2e/surveys.cy.ts b/cypress/e2e/surveys.cy.ts
index 6f404bd809013..887543d639a68 100644
--- a/cypress/e2e/surveys.cy.ts
+++ b/cypress/e2e/surveys.cy.ts
@@ -97,7 +97,7 @@ describe('Surveys', () => {
// select the first property
cy.get('[data-attr="property-select-toggle-0"]').click... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
OpenMined__PySyft-6900@eba6a64 | OpenMined/PySyft | Python | 6,900 | Split Docker Launch into Pull / Build and Start | ## Description
Please include a summary of the change, the motivation, and any additional context that will help others understand your PR. If it closes one or more open issues, [please tag them as described here](https://help.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking... | 2022-10-25T17:36:04Z | Split Docker Launch into Pull / Build and Start
To provide more control over the output filtering and checking what step is working we should split docker launch into docker pull (if they use tag=latest etc) or docker build (if they are building), run those commands and then after they are complete run the next one to ... | Very much looking forward to this one!
@factdroid can we up-prioritize this one? Looks like it's been chillin for a month or so.
> @factdroid can we up-prioritize this one? Looks like it's been chillin for a month or so.
@iamtrask yeah it's a priority for me this week, I'll try to push through it. | [
{
"body": "To provide more control over the output filtering and checking what step is working we should split docker launch into docker pull (if they use tag=latest etc) or docker build (if they are building), run those commands and then after they are complete run the next one to launch the domain.\n\nDuring ... | fade503d7ec21f00526fd684c0681baeaa63adb9 | {
"head_commit": "eba6a649322f42e2c931fb73dd4fa2d25a58a18f",
"head_commit_message": "Fix Building step tracking issue\n- Now we have a reliable method that will count how much images\nwe're trying to build based on matching regex pattern\n- Now we have a reliable method that will count how much images\nwe built bas... | [
{
"diff_hunk": "@@ -409,15 +547,32 @@ def execute_commands(\n else:\n display_jupyter_token(cmd)\n if silent:\n+ ON_POSIX = \"posix\" in sys.builtin_module_names\n+\n process = subprocess.Popen( # nosec\n ... | 0f3ddf9c79474e9758ee2d6ff35d67867ffce730 | diff --git a/packages/grid/.env b/packages/grid/.env
index 79c9dd55249..207f658f495 100644
--- a/packages/grid/.env
+++ b/packages/grid/.env
@@ -25,6 +25,7 @@ DOCKER_IMAGE_VPN_IPTABLES=openmined/grid-vpn-iptables
DOCKER_IMAGE_TRAEFIK=traefik
TRAEFIK_VERSION=v2.8.1
REDIS_VERSION=6.2
+RABBITMQ_VERSION=3
DOCKER_IMAGE_... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
OpenBB-finance__OpenBB-5503@156af94 | OpenBB-finance/OpenBB | Python | 5,503 | fix: Modify 'load' behavior to append data to existing sheet | Details:
- Added logic to detect existing sheet and append data if present.
- There is no direct way to append on the sheet, so I am reading the sheet to get the last row number and then writing after that row number.
Resolves: #5472
# Description
- [x] Summary of the change / bug fix.
- [x] Link # issue, i... | 2023-10-01T20:17:45Z | [IMPROVE] Append existing `--sheet-name` with additional rows when exporting to XLSX
What would be an awesome outcome is if:
`load aapl --start 2022-01-01 --end 2022-12-31 --weekly --export aapl.xlsx --sheet-name weekly`
could be appended to add more rows later:
`load aapl --start 2023-01-01 --weekly --export ... | Hey @deeleeramone, could I work on this issue?
> Hey @deeleeramone, could I work on this issue?
Thank you for assigning this issue to me 😀. Could I please have a starting point to build up from so that... | [
{
"body": "What would be an awesome outcome is if:\r\n\r\n`load aapl --start 2022-01-01 --end 2022-12-31 --weekly --export aapl.xlsx --sheet-name weekly`\r\n\r\ncould be appended to add more rows later:\r\n\r\n`load aapl --start 2023-01-01 --weekly --export aapl.xlsx --sheet-name weekly`\r\n\r\n\r\nThe current ... | 633cdb1528f976552219bb0270320d384934fb84 | {
"head_commit": "156af9427af590a46891f200fc27093e03729fdb",
"head_commit_message": "fix: Modify 'load' behavior to append data to existing sheet\n\nDetails:\n- Added logic to detect existing sheet and append data if present.\n- There is no direct way to append on the sheet, so I am reading the sheet to get the las... | [
{
"diff_hunk": "@@ -1602,15 +1602,28 @@ def export_data(\n )\n \n elif saved_path.exists():\n+ # Load the Excel file to get the existing data\n+ existing_df = pd.read_excel(saved_path, sheet_name=sheet_name)\n+ # Get th... | 5ce94327f3ddd3bb93be9ae5c68257f9993fb7b5 | diff --git a/openbb_terminal/helper_funcs.py b/openbb_terminal/helper_funcs.py
index 700ef0b7316a..c10062b467ac 100644
--- a/openbb_terminal/helper_funcs.py
+++ b/openbb_terminal/helper_funcs.py
@@ -1512,6 +1512,55 @@ def ask_file_overwrite(file_path: Path) -> Tuple[bool, bool]:
return False, True
+def save_to... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
PostHog__posthog-24794@93c56af | PostHog/posthog | Python | 24,794 | feat: recordings ordering | ## Problem
Order replays!
Randomly choose replays! (closes https://github.com/PostHog/posthog/issues/8182)
## Changes
- Add ordering back to replay filtering
- Add more options to filter by (activity mainly)
- Remove ability to customise "duration shown" (it uses the ordering duration or the total duratio... | 2024-09-04T17:37:17Z | Stratified Recordings
## Is your feature request related to a problem?
When I watch recordings, I don't just want to see what people did in the last few hours, I'd like to see a sample of people over the last few days / weeks. So I'm not affected by any biases in that smaller time period (e.g. specific region awake ... | This is really interesting!
Technically, it's pretty easy to do, but I think the trick would be in how we describe what's happening to a user.
It's almost like "shuffle" on a playlist.
@clarkus curious if you have any thoughts here.
I like this idea. I think this feels like a natural evolution of the filtering... | [
{
"body": "## Is your feature request related to a problem?\r\n\r\nWhen I watch recordings, I don't just want to see what people did in the last few hours, I'd like to see a sample of people over the last few days / weeks. So I'm not affected by any biases in that smaller time period (e.g. specific region awake... | cd33d56f5beddd0980c8a1bbee6e28724ae7fc15 | {
"head_commit": "93c56af764334bec152ec81d9798f6e1f81de325",
"head_commit_message": "Update query snapshots",
"patch_to_review": "diff --git a/ee/session_recordings/queries/test/__snapshots__/test_session_recording_list_from_filters.ambr b/ee/session_recordings/queries/test/__snapshots__/test_session_recording_li... | [
{
"diff_hunk": "@@ -234,6 +234,25 @@ function combineLegacyRecordingFilters(\n }\n }\n \n+function sortRecordings(recordings: SessionRecordingType[], order: RecordingsQuery['order']): SessionRecordingType[] {\n+ const orderKey:\n+ | 'recording_duration'\n+ | 'active_seconds'\n+ | 'in... | d79ae5c23a380eb5a9226ddab839e69481097570 | diff --git a/ee/session_recordings/queries/test/__snapshots__/test_session_recording_list_from_filters.ambr b/ee/session_recordings/queries/test/__snapshots__/test_session_recording_list_from_filters.ambr
index fd0b7d5358f5f..decc4844d5185 100644
--- a/ee/session_recordings/queries/test/__snapshots__/test_session_recor... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
OpenMined__PySyft-4752@9f91ef3 | OpenMined/PySyft | Python | 4,752 | fix comparison between FPT and AST | ## Description
this PR fixes #4705
comparison function of additive_share.py is modified.
## Affected Dependencies
none
## How has this been tested?
- test cases are added
## Checklist
- [x] I have followed the [Contribution Guidelines](https://github.com/OpenMined/.github/blob/master/CONTRIBUTING.md) and... | 2020-11-01T16:14:26Z | Comparison between FPT and AST doesn't always works
## Description
Some cases of handling comparison between FixedPrecision and AdditiveSharingTensor are supported, but some are not. We should systematize this.
## How to Reproduce
```python
t1 = torch.tensor([1.2, 1]).fix_precision().share(*workers, crypto_provid... | [
{
"body": "## Description\r\nSome cases of handling comparison between FixedPrecision and AdditiveSharingTensor are supported, but some are not. We should systematize this.\r\n\r\n## How to Reproduce\r\n```python\r\nt1 = torch.tensor([1.2, 1]).fix_precision().share(*workers, crypto_provider=crypto_provider, pro... | eb4d348e19ee0356343a841e19f8df978cf9170f | {
"head_commit": "9f91ef39b9159d76fb65b2ebdee3b9510fe29600",
"head_commit_message": "fixed comparison in AST and added tests",
"patch_to_review": "diff --git a/syft/frameworks/torch/tensors/interpreters/additive_shared.py b/syft/frameworks/torch/tensors/interpreters/additive_shared.py\nindex 56bb860b45b..fb2bfc27... | [
{
"diff_hunk": "@@ -802,6 +813,28 @@ def test_comp(workers, protocol, force_preprocessing):\n assert ((x > y).get().float_prec() == (t1 > t2)).all()\n assert ((x < y).get().float_prec() == (t1 < t2)).all()\n \n+ # for x as AST and y as FPT",
"line": null,
"original_line": 816,
"original_... | 75ff31c1c6ff0ee6f617c7f30c4fd10279f45ce5 | diff --git a/pip-dep/requirements_udacity.txt b/pip-dep/requirements_udacity.txt
index 4b1ceb61f96..558b48bae74 100644
--- a/pip-dep/requirements_udacity.txt
+++ b/pip-dep/requirements_udacity.txt
@@ -1,2 +1,2 @@
-tf_encrypted>=0.5.4,<0.6.0!=0.5.7
h5py==2.10.0
+tf_encrypted>=0.5.4,<0.6.0!=0.5.7
diff --git a/syft/frame... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
ManimCommunity__manim-716@eedc55b | ManimCommunity/manim | Python | 716 | Make it easier to change background color | ## List of Changes
- Change `background_color` and `background_opacity` to become properties of `Camera`
- Add, for convenience, a `camera` property to `Scene`
## Motivation
This is a suggestion for simplifying the interface for setting the background color in a scene by calling `self.camera.background_color = RE... | 2020-11-16T02:38:49Z | Make it easier to change background colour.
**Describe the bug**
Right now I can only change the background colour in my source file by writing
`config["background_color"] = WHITE` for example.
The problem is that this works only for one scene. If I write
```
config["background_color"] = WHITE
...Scene1...
c... | I agree this should be supported. However, the current architecture is not going to allow for it. Because of two reasons.
### Reason 1: the file is read before scenes are rendered
`manim/__main__.py` executes the whole module before rendering the scene. To side-step this, you could use your own script instead of ca... | [
{
"body": "**Describe the bug**\r\nRight now I can only change the background colour in my source file by writing\r\n`config[\"background_color\"] = WHITE` for example.\r\n\r\nThe problem is that this works only for one scene. If I write\r\n```\r\nconfig[\"background_color\"] = WHITE\r\n...Scene1...\r\n\r\nconf... | 3e5fa331897e2cda38e1bab184abf866233cfa95 | {
"head_commit": "eedc55bac1c828aec7dbedbf562d7ed0809a6116",
"head_commit_message": "black",
"patch_to_review": "diff --git a/manim/camera/camera.py b/manim/camera/camera.py\nindex 9835f4a411..63f61d89f0 100644\n--- a/manim/camera/camera.py\n+++ b/manim/camera/camera.py\n@@ -89,11 +89,12 @@ def __init__(self, vid... | [
{
"diff_hunk": "@@ -1,8 +1,28 @@\n import pytest\n-from manim import Camera, tempconfig, config\n+import numpy as np\n+\n+from manim import Camera, Scene, tempconfig, config\n \n \n def test_import_color():\n import manim.utils.color as C\n \n C.WHITE\n+\n+\n+def test_background_color():\n+ import ma... | 619a9473bda0e7a90c5e653e86c9582bed221055 | diff --git a/manim/camera/camera.py b/manim/camera/camera.py
index 9835f4a411..63f61d89f0 100644
--- a/manim/camera/camera.py
+++ b/manim/camera/camera.py
@@ -89,11 +89,12 @@ def __init__(self, video_quality_config, background=None, **kwargs):
"frame_height",
"frame_width",
"frame... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
OpenMined__PySyft-7187@42d1d6a | OpenMined/PySyft | Python | 7,187 | [WIP] 7054 Add AWS support on Hagrid | ## Description
- Adding AWS support on Hagrid
- Using AWS CLI to deploy the required resources
- Asking questions to get the region, name of security group, incoming IP addresses allowed (in CIDR notation), EC2 instance type, name and path of key-pair to connect to instance, Openmined repo & branch to fetch source f... | 2022-12-20T12:05:10Z | Add support for AWS in Hagrid
## Feature Description
Add support for deploying PySyft and Grid stack on AWS cloud VMs using HaGrid.
Add support to deploy the stack either using AWS cli or boto3 client.
- Ask for information for Region, Name, Type of machine, ssh password or key, username, etc.
- Launch a VM on AWS
... | [
{
"body": "## Feature Description\r\nAdd support for deploying PySyft and Grid stack on AWS cloud VMs using HaGrid.\r\nAdd support to deploy the stack either using AWS cli or boto3 client.\r\n- Ask for information for Region, Name, Type of machine, ssh password or key, username, etc.\r\n- Launch a VM on AWS\r\n... | c28f6a93e97a05edb036f0fc4e91aa32c8c1a29f | {
"head_commit": "42d1d6aad2bad7f4be3c5fba5b7cbe1a78250bd3",
"head_commit_message": "Fixed issues with ignoring subprocess checks in hagrid",
"patch_to_review": "diff --git a/packages/hagrid/hagrid/cache.py b/packages/hagrid/hagrid/cache.py\nindex 4b3bd4e36ed..637d65887d7 100644\n--- a/packages/hagrid/hagrid/cach... | [
{
"diff_hunk": "@@ -2013,6 +2203,222 @@ def check_ip_for_ssh(\n return False\n \n \n+def create_aws_security_group(\n+ security_group_name: str, region: str, snake_name: str\n+) -> str:\n+ sg_description = f\"{snake_name} security group\"\n+ create_cmd = f\"aws ec2 create-security-group --group-nam... | e176713ecc559c15635097ceff131ba5a698a3b1 | diff --git a/packages/hagrid/hagrid/cache.py b/packages/hagrid/hagrid/cache.py
index 4b3bd4e36ed..a393ab6822b 100644
--- a/packages/hagrid/hagrid/cache.py
+++ b/packages/hagrid/hagrid/cache.py
@@ -29,6 +29,14 @@
"gcp_repo": DEFAULT_REPO,
"gcp_branch": STABLE_BRANCH,
"install_wizard_complete": False,
+ ... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
OpenMined__PySyft-4522@776c2e8 | OpenMined/PySyft | Python | 4,522 | Added support for FixedPrecisionTensor chain in ReplicatedSharingTensor (RST) | ## Description
> Added support for FixedPrecisionTensor chain in ReplicatedSharingTensor (RST)
> Modified add and sub of FPT to support FPT chain in RST
> Modified falcon files to support (Wrapper)> [ReplicatedSharingTensor]
this PR closed #3931
## Affected Dependencies
None
## How has this been te... | 2020-09-02T14:43:54Z | Replicated Sharing Tensor (RST): Add support for FixedPrecisionTensor chain
Replicated Sharing Tensor currently can work if the plain text type is float or int, we want it to be able to work given a FixedPrecisionTensor as plain text.
When this issue is solved this test case should work properly:
```
a = a.fix_perc... | I'll like to work on this
GREAT! :D
@aanurraj that's not going to be easy :D let me share my progress in this issue so far:
a.fix_perc().share(bob, alice, james, protocol = "falcon")
this line calls the share function of the native tensor instead of the FPT, they both have a "share" method, you want to call the one... | [
{
"body": "Replicated Sharing Tensor currently can work if the plain text type is float or int, we want it to be able to work given a FixedPrecisionTensor as plain text.\r\nWhen this issue is solved this test case should work properly:\r\n```\r\na = a.fix_perc().share(bob, alice, james, protocol = \"falcon\")\r... | c83e615a85bb8944245668d90582fb97c45e6e18 | {
"head_commit": "776c2e824d3e8bd7b3ddf35126200111b75f4c28",
"head_commit_message": "ran black",
"patch_to_review": "diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml\nindex 6eeedfb9ac7..1b32354fcfe 100644\n--- a/.pre-commit-config.yaml\n+++ b/.pre-commit-config.yaml\n@@ -12,7 +12,7 @@ repos:\n -... | [
{
"diff_hunk": "@@ -88,6 +99,8 @@ def select_share(\n c = torch.randint(high=2, size=shape)\n c_2 = c.share(*players, protocol=\"falcon\", field=2)\n c_L = c.share(*players, protocol=\"falcon\", field=ring_size)\n+ print(c_L)",
"line": null,
"original_line": 102,
"orig... | 4e86a1e4b8165b8e4f95c5d4aa177e2376cfc5a9 | diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
index 6eeedfb9ac7..1b32354fcfe 100644
--- a/.pre-commit-config.yaml
+++ b/.pre-commit-config.yaml
@@ -12,7 +12,7 @@ repos:
- id: requirements-txt-fixer
- id: flake8
- repo: https://github.com/psf/black
- rev: 19.10b0
+ rev: 20.8b1
... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
ManimCommunity__manim-586@e72390d | ManimCommunity/manim | Python | 586 | Clean up README | ## List of Changes
- Various grammar fixes and other visual stuff.
## Motivation
- `manimce` has approached v0.1.0, and I believe it's appropriate to update this accordingly.
## Explanation for Changes
- Sentence structure, misc. visual additions.
## Acknowledgement
- [x] I have read the [Contributing Guid... | 2020-10-22T04:24:44Z | Deprecated CLI flag is advertised on our github front page
The main picture on our github landing page is
`manim file.py Scene -pl`
We should change it to `manim myFile.py myScene -p -ql` ... or even `manimce` if that is what we decide on as an entrypoint. | Adding this to #148
How was that picture even created?
This has been there since The Beginning.
shall we make one with manim?
https://discord.com/channels/581738731934056449/581738732646957057/765182589807624192
Yeah, that'd be perfect | [
{
"body": "The main picture on our github landing page is \r\n\r\n`manim file.py Scene -pl` \r\n\r\nWe should change it to `manim myFile.py myScene -p -ql` ... or even `manimce` if that is what we decide on as an entrypoint.",
"number": 572,
"title": "Deprecated CLI flag is advertised on our github fro... | 6fcdafec1ae4b56987941f1f19a750915e51bb62 | {
"head_commit": "e72390d613f905bf806d5df5a882e91e606268cc",
"head_commit_message": "Clean up README",
"patch_to_review": "diff --git a/README.md b/README.md\nindex c8e231d425..c91382bb51 100644\n--- a/README.md\n+++ b/README.md\n@@ -1,34 +1,45 @@\n-![logo](https://raw.githubusercontent.com/ManimCommunity/manim/m... | [
{
"diff_hunk": "@@ -46,56 +57,46 @@ class SquareToCircle(Scene):\n self.play(FadeOut(square))\n ```\n \n-Save this code in a file called `example.py`. Now open your terminal in the\n-folder where you saved the file and execute\n+In order to view the output of this scene, save the code in a file called `... | 11e21a9110987b0598abd40a91d37b3ef7ec1ade | diff --git a/README.md b/README.md
index ef925be878..fabb03a93f 100644
--- a/README.md
+++ b/README.md
@@ -1,34 +1,45 @@
-
-
-
-[![Documentation Status](https://rea... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "New Feature Additions"
} |
Rapptz__discord.py-10084@71f1e5d | Rapptz/discord.py | Python | 10,084 | Change default file size limit | ## Summary
Resolves #10083
Might be worth documenting that this is provided on a "best effort at time of release" means somewhere, but for now, this just covers what discord says the limit is.
## Checklist
<!-- Put an x inside [ ] to check it, like so: [x] -->
- [ ] If code changes were made then they h... | 2025-01-22T01:23:23Z | Guild file size limit is incorrect
### Summary
When getting the guild.filesize_limit attribute with your discord bot, the guild filesize limit is wrong.
### Reproduction Steps
Create your discord bot
Get the channel you want to upload to using it's id
Get the filesize limit of the guild
### Minimal Reproducible Cod... | [
{
"body": "### Summary\n\nWhen getting the guild.filesize_limit attribute with your discord bot, the guild filesize limit is wrong.\n\n### Reproduction Steps\n\nCreate your discord bot\nGet the channel you want to upload to using it's id\nGet the filesize limit of the guild\n\n### Minimal Reproducible Code\n\n`... | 418a7915e687090179a67d12de807db0db4f284c | {
"head_commit": "71f1e5d6d27858b2c3c472fb9c497e6c3510f38e",
"head_commit_message": "Change default file size limit",
"patch_to_review": "diff --git a/discord/utils.py b/discord/utils.py\nindex bd327b5a8bb1..c563d7531695 100644\n--- a/discord/utils.py\n+++ b/discord/utils.py\n@@ -108,7 +108,7 @@\n )\n \n DISCORD_... | [
{
"diff_hunk": "@@ -108,7 +108,7 @@\n )\n \n DISCORD_EPOCH = 1420070400000\n-DEFAULT_FILE_SIZE_LIMIT_BYTES = 26214400\n+DEFAULT_FILE_SIZE_LIMIT_BYTES = 10000000",
"line": null,
"original_line": 111,
"original_start_line": null,
"path": "discord/utils.py",
"start_line": null,
"text": "@us... | c43fcb8a96302d8eb7373ef53a3d3285e7cea52b | diff --git a/discord/utils.py b/discord/utils.py
index bd327b5a8bb1..1caffe7f57f0 100644
--- a/discord/utils.py
+++ b/discord/utils.py
@@ -108,7 +108,7 @@
)
DISCORD_EPOCH = 1420070400000
-DEFAULT_FILE_SIZE_LIMIT_BYTES = 26214400
+DEFAULT_FILE_SIZE_LIMIT_BYTES = 10485760
class _MissingSentinel:
| {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "Bug Fixes"
} | |
ManimCommunity__manim-509@1cbc24f | ManimCommunity/manim | Python | 509 | FEAT : Add increment using += support for ValueTracker | Closes #507
## List of Changes
- Add the `__iadd__` method for `ValueTracker`
## Motivation
Ease of use like `tracker += 3.0`
## Explanation for Changes
The `__iadd__` method in Python is used for overloading the operator `+=`
## Acknowledgement
- [x] I have read the [Contributing Guidelines](https://g... | 2020-10-03T11:25:38Z | ValueTracker must support increment also using +=
Just what the title says. Here's an example
```python
class Test(Scene):
def construct(self):
tracker = ValueTracker(0.0)
tracker.set_value(2.0)
print(tracker.get_value()) # -> 2.000
tracker.increment_value(3.0)
print... | Very good idea. I would love to see a PR :) #
Hey, @huguesdevimeux I can take this if it's still open. | [
{
"body": "Just what the title says. Here's an example \r\n```python\r\nclass Test(Scene):\r\n def construct(self):\r\n tracker = ValueTracker(0.0)\r\n tracker.set_value(2.0)\r\n print(tracker.get_value()) # -> 2.000\r\n tracker.increment_value(3.0)\r\n print(tracker.get_va... | 16e18b26e5e2e230aa46c85fc04fdebf9f2fe1bf | {
"head_commit": "1cbc24fafbf88889b3215f3899d228c27ad97f4e",
"head_commit_message": "Add increment using += support for ValueTracker",
"patch_to_review": "diff --git a/manim/mobject/value_tracker.py b/manim/mobject/value_tracker.py\nindex 13ae1d7586..91b8d1d7b3 100644\n--- a/manim/mobject/value_tracker.py\n+++ b/... | [
{
"diff_hunk": "@@ -57,6 +57,9 @@ def set_value(self, value):\n def increment_value(self, d_value):\n self.set_value(self.get_value() + d_value)\n \n+ def __iadd__(self, d_value):\n+ return ValueTracker(self.get_value() + d_value)",
"line": null,
"original_line": 61,
"original_... | beae7786c9852cea6e6bd8b66a24504c13994041 | diff --git a/docs/source/changelog.rst b/docs/source/changelog.rst
index 940c8efa89..6d410549c1 100644
--- a/docs/source/changelog.rst
+++ b/docs/source/changelog.rst
@@ -62,6 +62,7 @@ Mobjects, Scenes, and Animations
#. Add a :code:`Variable` class for displaying text that continuously updates to reflect the value of... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "New Feature Additions"
} |
OpenMined__PySyft-4065@67c51fb | OpenMined/PySyft | Python | 4,065 | Added support for negative numbers in reciprocal method #4048 | ## Description
This PR fixes #4048
Added support for negative numbers when use different methods in Reciprocal.
Uses a signum function to achieve this
Suggestions are welcome!
## Affected Dependencies
- None
## How has this been tested?
- No additional tests are needed. Changed the default value in test_r... | 2020-08-22T13:44:20Z | Reciprocal test enchantment negative numbers
## Description
Test the ```reciprocal``` method from precision using negative numbers
## Expected Behavior
All tests are passing
## Screenshots
If applicable, add screenshots to help explain your problem.
## Additional Context
It might require changes to the rec... | I guess the Log and NR method are a problem. Division works fine.. Will look into the issue
Adding you :)
> I guess the Log and NR method are a problem. Division works fine.. Will look into the issue
Also, there might be worth checking out how [CrypTen](https://github.com/facebookresearch/CrypTen) is doing - if they... | [
{
"body": "## Description\r\nTest the ```reciprocal``` method from precision using negative numbers\r\n\r\n## Expected Behavior\r\nAll tests are passing\r\n\r\n## Screenshots\r\nIf applicable, add screenshots to help explain your problem.\r\n\r\n## Additional Context\r\nIt might require changes to the reciproca... | 7fe9f79ebbc2df5ee7990c0f1fd80e8afcda02fc | {
"head_commit": "67c51fbe9cfc13bf22be2ddc564f33fe6432c5df",
"head_commit_message": "Negative numbers support for reciprocal",
"patch_to_review": "diff --git a/syft/frameworks/torch/tensors/interpreters/precision.py b/syft/frameworks/torch/tensors/interpreters/precision.py\nindex d906c96fd2d..f00c42ba9af 100644\n... | [
{
"diff_hunk": "@@ -468,6 +468,23 @@ def matmul(self, *args, **kwargs):\n __matmul__ = matmul\n mm = matmul\n \n+ def signum(self):\n+ r\"\"\"\n+ Calculation of signum function for a given tensor\n+ \"\"\"\n+ sgn = self > 0\n+ zero = self == 0\n+ pos = sg... | d9d7d4dd2c14f24ab609692b84d0d1dcd3182902 | diff --git a/syft/frameworks/torch/tensors/interpreters/precision.py b/syft/frameworks/torch/tensors/interpreters/precision.py
index d906c96fd2d..4c1d9336b6a 100644
--- a/syft/frameworks/torch/tensors/interpreters/precision.py
+++ b/syft/frameworks/torch/tensors/interpreters/precision.py
@@ -468,6 +468,19 @@ def matmul... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Test Suite / CI Enhancements"
} |
ManimCommunity__manim-499@7e8bac4 | ManimCommunity/manim | Python | 499 | Make VGroup and VDict printable | Closes #497
## List of Changes
- Added a `__repr__` method to `VGroup` and `VDict`
- Removed the `__str__` method from `Mobject` (reason explained below)
## Motivation
Just printing a VGroup or a VDict object used to print the class name only. While debugging, it is useful to know the mobjects contained. With t... | 2020-10-01T11:13:13Z | VGroup and VDict must override __repr__ to display the mobjects contained
Consider this example:
```python
class Test(Scene):
def construct(self):
sq = Square()
cir = Circle()
grp = VGroup(sq, cir)
print(grp) # --> Just prints: VGroup
self.play(ShowCreation(grp))
... | You have to define the `__str__` method of VGriup/VDict. I think some Mobjects already have a `__str__` method so it should be enough to do something like `return ", ".join(str(m) for m in self.mobjects)`
Seems to be an easy PR, if no one object
Would like to know what would be preferred just `Square` or the full hash... | [
{
"body": "Consider this example:\r\n```python\r\nclass Test(Scene):\r\n def construct(self):\r\n sq = Square()\r\n cir = Circle()\r\n grp = VGroup(sq, cir)\r\n print(grp) # --> Just prints: VGroup\r\n self.play(ShowCreation(grp))\r\n dct = VDict({'s' : sq, 'c' : cir... | 037c9be804a73915d73106167ff4274f04d39576 | {
"head_commit": "7e8bac4d71ec6619be391b92b4c8ff122bbfbe5d",
"head_commit_message": "Add change to changelog.rst",
"patch_to_review": "diff --git a/docs/source/changelog.rst b/docs/source/changelog.rst\nindex 85fdd00ce3..b478a9ff76 100644\n--- a/docs/source/changelog.rst\n+++ b/docs/source/changelog.rst\n@@ -60,7... | [
{
"diff_hunk": "@@ -62,9 +62,6 @@ def __init__(self, **kwargs):\n self.generate_points()\n self.init_colors()\n \n- def __str__(self):",
"line": 65,
"original_line": 65,
"original_start_line": null,
"path": "manim/mobject/mobject.py",
"start_line": null,
"text": "@user... | 829c655e6dedbbeda26bf42ae21d6f0806c79aa7 | diff --git a/docs/source/changelog.rst b/docs/source/changelog.rst
index 85fdd00ce3..80b47905e0 100644
--- a/docs/source/changelog.rst
+++ b/docs/source/changelog.rst
@@ -60,7 +60,7 @@ Mobjects, Scenes, and Animations
#. The :code:`Container` class has been made into an AbstractBaseClass, i.e. in cannot be instantiate... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Code Refactoring / Architectural Improvement"
} |
Rapptz__discord.py-7954@ad12cd0 | Rapptz/discord.py | Python | 7,954 | Add basic slash command example | ## Summary
Adding app_command examples. Preferred structure:
```
examples/
app_commands/
cog.py
groups.py
basic.py
context_menu.py
checks.py
hybrid.py
```
## Checklist
<!-- Put an x inside [ ] to check it, like so: [x] -->
- [ ] If code changes were made then they have be... | 2022-04-29T16:32:55Z | Should Add application_commands usage in examples
### Summary
will you add appcommands usage in examples
### What is the feature request for?
The core library
### The Problem
it's difficult to make a slash commands in discord.py for beginners, because docs are not well documented, may be discord.py guide will be ... | [
{
"body": "### Summary\n\nwill you add appcommands usage in examples \n\n### What is the feature request for?\n\nThe core library\n\n### The Problem\n\nit's difficult to make a slash commands in discord.py for beginners, because docs are not well documented, may be discord.py guide will be release soon but for ... | ef20264b1c42a6719d13b5a47e62b73652377387 | {
"head_commit": "ad12cd0486ced45e9effeab1b75446356c8a53be",
"head_commit_message": "Add basic slash command example",
"patch_to_review": "diff --git a/examples/app_commands/basic.py b/examples/app_commands/basic.py\nnew file mode 100644\nindex 000000000000..72d405c12ca7\n--- /dev/null\n+++ b/examples/app_command... | [
{
"diff_hunk": "@@ -0,0 +1,58 @@\n+import discord\n+from discord import app_commands\n+from discord.ext import commands\n+\n+class MyBot(commands.Bot):\n+\n+ # In this basic example, we just synchronize the app commands to one guild,\n+ # without requiring to set the guild to every command individually by... | 1193b91bb156569bfc0ae47b59899ab91528b4e5 | diff --git a/examples/app_commands/basic.py b/examples/app_commands/basic.py
new file mode 100644
index 000000000000..c617c082f791
--- /dev/null
+++ b/examples/app_commands/basic.py
@@ -0,0 +1,71 @@
+from typing import Optional
+
+import discord
+from discord import app_commands
+
+MY_GUILD = discord.Object(id=0) # re... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "New Feature Additions"
} | |
OpenMined__PySyft-4020@6eb5005 | OpenMined/PySyft | Python | 4,020 | Grid clients serialisation correction | ## Description
Register `DataCentricFLClient` in serde for serialization.
## Affected Dependencies
`DataCentricFLClient` cannot be serialised currently, as it's not registered in serde.
which causes error while doing SMPC as sharing of tensor raises the error during serialization.
Code :
`x = torch.tensor([1,2... | 2020-08-15T09:11:28Z | Serde Can not serialize 'DynamicFLClient' object
Cannot share tensor from reference pointer
** This issue is critical for SyferText, since it breaks functionality when working with Grid nodes **
## How to Reproduce
Nodes Creation :
`python -m gridnode --id=bob --host=localhost --port 3001`
`python -m gridnode... | Should we open this issue in PySyft @AlanAboudib @Nilanshrajput ?
`DynamicFLClient` is defined in PySyft, here :point_right: https://github.com/OpenMined/PySyft/blob/f692b992fe14fab7fe5c2006d087a683a856d914/syft/grid/clients/dynamic_fl_client.py#L16
Done @sachin-101
CC: @IonesioJunior - thoughts on this? Could use yo... | [
{
"body": "Cannot share tensor from reference pointer\r\n\r\n** This issue is critical for SyferText, since it breaks functionality when working with Grid nodes **\r\n## How to Reproduce\r\n\r\nNodes Creation :\r\n`python -m gridnode --id=bob --host=localhost --port 3001`\r\n`python -m gridnode --id=alice --h... | 9e32521888192390e99363a0da2ed4b46a39a9e1 | {
"head_commit": "6eb500518b1b85e8d00208ee77b29b18969b419d",
"head_commit_message": "lint error resolve",
"patch_to_review": "diff --git a/syft/grid/clients/data_centric_fl_client.py b/syft/grid/clients/data_centric_fl_client.py\nindex 38e87a7209f..053fae4e012 100644\n--- a/syft/grid/clients/data_centric_fl_clien... | [
{
"diff_hunk": "@@ -284,3 +285,77 @@ def delete_model(self, model_id: str) -> bool:\n \n def __str__(self) -> str:\n return f\"<Federated Worker id:{self.id}>\"\n+\n+ @staticmethod\n+ def simplify(worker: AbstractWorker, data_centric_fl_client: \"DataCentricFLClient\") -> tuple:\n+\n+ #... | 8b6f8f72bdb60be048288ec1ca6f2d6aa3c37c03 | diff --git a/syft/grid/clients/data_centric_fl_client.py b/syft/grid/clients/data_centric_fl_client.py
index 38e87a7209f..12795428c52 100644
--- a/syft/grid/clients/data_centric_fl_client.py
+++ b/syft/grid/clients/data_centric_fl_client.py
@@ -2,15 +2,17 @@
import requests
from requests_toolbelt import MultipartEnco... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
Rapptz__discord.py-9527@0eb11a1 | Rapptz/discord.py | Python | 9,527 | Add encoder params to VoiceClient.play | ## Summary
Adds kwarg parameters to allow access to setting `VoiceClient`'s underlying `Encoder` initial parameters. In addition, this also changes the APPLICATION_ constants to be like the other CTL TypedDicts. Also fixes an error message typo. I'm not really sure about using stringly typed constants but its what ... | 2023-08-19T21:04:42Z | Audio bitrate limiting
### Summary
Being able to limit the bitrate of outgoing audio streams
### What is the feature request for?
The core library
### The Problem
Hosting bots on connections with low bandwidth can make the played audio lag, this could be solved by giving the option to throttle the outgoi... | you can set the bitrate in kilobytes in [discord.FFmpegOpusAudio](https://discordpy.readthedocs.io/en/latest/api.html#discord.FFmpegOpusAudio)
Oh thanks! A dev of this repo said this wasnt possible and told me to create an issue, must have missunderstood him. Nice! | [
{
"body": "### Summary\r\n\r\nBeing able to limit the bitrate of outgoing audio streams\r\n\r\n### What is the feature request for?\r\n\r\nThe core library\r\n\r\n### The Problem\r\n\r\nHosting bots on connections with low bandwidth can make the played audio lag, this could be solved by giving the option to thr... | 2e2f20c6d5a7d938c1f9546dcf9a187694272e9a | {
"head_commit": "0eb11a12d9e846df1aec54eb00c8ae8f6fc41165",
"head_commit_message": "Fix Encoder class references in docstring",
"patch_to_review": "diff --git a/discord/opus.py b/discord/opus.py\nindex 966a8ccc68b4..4c6ae0122284 100644\n--- a/discord/opus.py\n+++ b/discord/opus.py\n@@ -39,10 +39,17 @@\n \n if TY... | [
{
"diff_hunk": "@@ -45,6 +45,7 @@\n import struct\n import threading\n from typing import Any, Callable, List, Optional, TYPE_CHECKING, Tuple, Union\n+from typing_extensions import Unpack",
"line": null,
"original_line": 48,
"original_start_line": null,
"path": "discord/voice_client.py",
"st... | 04d9e1dbecb9943082eb69b0c9f009180d22625e | diff --git a/discord/opus.py b/discord/opus.py
index 966a8ccc68b4..ab3916138e7f 100644
--- a/discord/opus.py
+++ b/discord/opus.py
@@ -39,10 +39,17 @@
if TYPE_CHECKING:
T = TypeVar('T')
+ APPLICATION_CTL = Literal['audio', 'voip', 'lowdelay']
BAND_CTL = Literal['narrow', 'medium', 'wide', 'superwide', '... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
ManimCommunity__manim-482@f2fd3e3 | ManimCommunity/manim | Python | 482 | Fixed "get_arc_center()" method of Arc class | ## Explaination
`get_arc_center()` method fails if the arc radius is zero. Therefore an if statement has been added to indirectly check whether the arc radius is zero or not.
If the anchor points lie at the same point, it implies that arc radius is zero. Thus arc_center also lie at that point.
This PR fixes #480
... | 2020-09-25T11:35:50Z | Sector.get_arc_center() is broken.
Sector.get_arc_center() does not work and always returns a warning message.
```sh
UserWarning: Can't find Arc center, using ORIGIN instead
warnings.warn("Can't find Arc center, using ORIGIN instead")
```
Above error can be reproduced using the below code.
```py
from manim impo... | Thanks for the report. Something tells me that this *might* even be the desired behavior, but the way it is handled right now, it's impossible to be certain. Cc @ManimCommunity/geometry any takers?
@leotrs I have solved this issue and I'll soon send a PR | [
{
"body": "Sector.get_arc_center() does not work and always returns a warning message.\r\n```sh\r\nUserWarning: Can't find Arc center, using ORIGIN instead\r\n warnings.warn(\"Can't find Arc center, using ORIGIN instead\")\r\n```\r\nAbove error can be reproduced using the below code.\r\n```py\r\nfrom manim impo... | dc4504c29e92881f56c80cd8f16e86f44318b870 | {
"head_commit": "f2fd3e3b0655f34ba6894879cfc8ec5ca551e6d3",
"head_commit_message": "Added test case for get_arc_center()",
"patch_to_review": "diff --git a/manim/mobject/geometry.py b/manim/mobject/geometry.py\nindex 74ab65e9ed..f234ff432a 100644\n--- a/manim/mobject/geometry.py\n+++ b/manim/mobject/geometry.py\... | [
{
"diff_hunk": "@@ -0,0 +1,7 @@\n+import pytest",
"line": null,
"original_line": 1,
"original_start_line": null,
"path": "tests/test_geometry.py",
"start_line": null,
"text": "@user1:\nUnfortunatly there is already a test_geometry file, which is for graphical unit tests of geometrey modu... | 79e58dd0712c65306d93a8205e3620fb540620fb | diff --git a/manim/mobject/geometry.py b/manim/mobject/geometry.py
index 74ab65e9ed..f234ff432a 100644
--- a/manim/mobject/geometry.py
+++ b/manim/mobject/geometry.py
@@ -288,6 +288,12 @@ def get_arc_center(self, warning=True):
"""
# First two anchors and handles
a1, h1, h2, a2 = self.points[... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
Rapptz__discord.py-7413@76a6647 | Rapptz/discord.py | Python | 7,413 | Make enums comparable | ## Summary
Add comparison operations to Enum. Also added docs for supported operations on some enums where comparing values might be relevant. (NotificationLevel, NSFWLevel)
Not sure what to do about the supported operations containers on VerificationLevel and ContentFilter that were added in #688 and then broken... | 2021-08-19T01:11:41Z | Comparing VerificationLevel gives unexpected results
### Summary
Comparing VerificationLevel does not work as expected
### Reproduction Steps
1. Tried to compare VerificationLevel 4 with 1
2. Received a different result than expected
### Minimal Reproducible Code
```python
>>> from discord import Verif... | > I was about to open a PR to use IntEnum instead but I see it was removed for compatibility with 3.5
Just to confirm on this, all PRs currently are for the 2.0 version of the library; which drops compat for 3.5. This means you'd be able to PR this just fine.
This is a bug since this operation is [documented](https:... | [
{
"body": "### Summary\r\n\r\nComparing VerificationLevel does not work as expected\r\n\r\n### Reproduction Steps\r\n\r\n1. Tried to compare VerificationLevel 4 with 1\r\n2. Received a different result than expected\r\n\r\n### Minimal Reproducible Code\r\n\r\n```python\r\n>>> from discord import VerificationLev... | d7a42300077c7f5761401884a76682db96e75939 | {
"head_commit": "76a664743f1f743945db286a4973f19964641954",
"head_commit_message": "add comparable kwarg on EnumMeta",
"patch_to_review": "diff --git a/discord/enums.py b/discord/enums.py\nindex 80af39ece1ca..fe87a19d965c 100644\n--- a/discord/enums.py\n+++ b/discord/enums.py\n@@ -76,12 +76,19 @@ class EnumMeta(... | [
{
"diff_hunk": "@@ -76,12 +76,19 @@ class EnumMeta(type):\n _enum_member_map_: ClassVar[Dict[str, Any]]\n _enum_value_map_: ClassVar[Dict[Any, Any]]\n \n- def __new__(cls, name, bases, attrs):\n+ def __new__(cls, name, bases, attrs, **kwargs):",
"line": null,
"original_line": 79,
... | 4529585fa3bc3dcfeaca70d120202b55cfc9239f | diff --git a/discord/enums.py b/discord/enums.py
index 80af39ece1ca..af8ee2b0a0c3 100644
--- a/discord/enums.py
+++ b/discord/enums.py
@@ -58,13 +58,17 @@
)
-def _create_value_cls(name):
+def _create_value_cls(name, comparable):
cls = namedtuple('_EnumValue_' + name, 'name value')
cls.__repr__ = lambda s... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
OpenMined__PySyft-3870@6e676b0 | OpenMined/PySyft | Python | 3,870 | Parameters validation for the FV scheme | ## Description
closes #3792
Checks basic properties that the parameters should have while setting up, and tests the generated prime nos if those are correct.
## Affected Dependencies
None
## How has this been tested?
This code does not need to have dedicated tests and it is verified by already present tests.... | 2020-07-17T20:53:22Z | Implement parameter validation for FV scheme.
## Feature Description
Need to implement a logic to check the parameter value used in the FV scheme.
I am not very clear at the moment about its implementation.
## Is your feature request related to a problem?
Parameter selection for the FV scheme is really importan... | [
{
"body": "## Feature Description\r\nNeed to implement a logic to check the parameter value used in the FV scheme. \r\nI am not very clear at the moment about its implementation.\r\n\r\n## Is your feature request related to a problem?\r\nParameter selection for the FV scheme is really important, Improper values... | 1ee500768073b2fd7f106357fbf7c6b48e575faa | {
"head_commit": "6e676b09ee79cf5249dedbcc93592e96f2a52af9",
"head_commit_message": "basic param validation before setting",
"patch_to_review": "diff --git a/syft/frameworks/torch/he/fv/context.py b/syft/frameworks/torch/he/fv/context.py\nindex c4dda8378f8..9c5c9332094 100644\n--- a/syft/frameworks/torch/he/fv/co... | [
{
"diff_hunk": "@@ -12,14 +20,68 @@ class Context:\n rns_tool: A RNSTool class instance.\n \"\"\"\n \n- def __init__(self, encryption_param):\n+ def __init__(self, params):\n \n- self.param = encryption_param\n+ # Validation of params provided for the encryption scheme.\n+ ... | 6ee581744f9563275259524dd07c8cb8390a7064 | diff --git a/syft/frameworks/torch/he/fv/context.py b/syft/frameworks/torch/he/fv/context.py
index c4dda8378f8..584f0d54bdf 100644
--- a/syft/frameworks/torch/he/fv/context.py
+++ b/syft/frameworks/torch/he/fv/context.py
@@ -1,4 +1,15 @@
+import math
+from functools import reduce
+
+# from syft.frameworks.torch.he.fv.m... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
PostHog__posthog-20979@340e037 | PostHog/posthog | Python | 20,979 | refactor: Support for multiple file formats in S3 batch exports | ## Problem
Suppport for file formats in S3 batch exports (only Parquet for now, but the new interface allows adding more later). Once done, this will close #20998
<!-- Who are we building for, what are their needs, why is this important? -->
## Changes
TODO:
- [x] Implemented new `BatchExportWriter` inter... | 2024-03-18T15:12:28Z | Support for Parquet file format in S3
S3 batch exports only support exporting data as JSON lines. Although a useful format for interfacing with web systems, providing other formats could better serve other use cases. For example, analytics tends to revolve around Apache Parquet files. S3 batch exports should offer the ... | [
{
"body": "S3 batch exports only support exporting data as JSON lines. Although a useful format for interfacing with web systems, providing other formats could better serve other use cases. For example, analytics tends to revolve around Apache Parquet files. S3 batch exports should offer the option of selecting... | c491bf2cf5c7cc4eac862a15ab5c5b3fbf6d385f | {
"head_commit": "340e0370af4a0b1139ea0ba28d5d75b1531aa09b",
"head_commit_message": "test: Add writer classes tests and docstrings",
"patch_to_review": "diff --git a/posthog/batch_exports/service.py b/posthog/batch_exports/service.py\nindex c26be9a77ed1a..11859e9b4ff82 100644\n--- a/posthog/batch_exports/service.... | [
{
"diff_hunk": "@@ -0,0 +1,523 @@\n+\"\"\"This module contains a temporary file to stage data in batch exports.\"\"\"\n+import abc\n+import collections.abc\n+import contextlib\n+import csv\n+import datetime as dt\n+import gzip\n+import tempfile\n+import typing\n+\n+import brotli\n+import orjson\n+import pyarrow... | 892140383fa37cceb0d5e78c213af8cbb100166c | diff --git a/posthog/batch_exports/service.py b/posthog/batch_exports/service.py
index c26be9a77ed1a..11859e9b4ff82 100644
--- a/posthog/batch_exports/service.py
+++ b/posthog/batch_exports/service.py
@@ -90,6 +90,7 @@ class S3BatchExportInputs:
kms_key_id: str | None = None
batch_export_schema: BatchExportSc... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
OpenMined__PySyft-7136@18b8d18 | OpenMined/PySyft | Python | 7,136 | Add syft helper for handholding/messages | ## Description
Adding a syft.helper based on issue #6921
## Affected Dependencies
List any dependencies that are required for this change.
## How has this been tested?
- Describe the tests that you ran to verify your changes.
- Provide instructions so we can reproduce.
- List any relevant details for your ... | 2022-12-01T16:01:07Z | UX Improvement: More hand-holding. When creating a Syft Tensor, tell DS they can annotate. After annotate, tell DS they can load_dataset
It isn't obvious how a new PySyft user would know they had to call `.private` or `.annotate` on their Syft Tensor. Perhaps we could do some signposting and when a new Syft Tensor is c... | I like this idea. I think this and other queries might be best turned on/off by a syft.helper=True flag (which could default to True)
This was actually opened by @IshanMi
We could also persist this `syft settings` to their `~` home directory the same way we do with `hagrid`.
> We could also persist this `syft settings... | [
{
"body": "It isn't obvious how a new PySyft user would know they had to call `.private` or `.annotate` on their Syft Tensor. Perhaps we could do some signposting and when a new Syft Tensor is created, we could print something like \"Syft Tensor created! To activate Differential Privacy protection, please call ... | 50c8e36bbf96456c847e1d8046894b289f197c8f | {
"head_commit": "18b8d18448a4f88ef732d8a80256c5558764ef7c",
"head_commit_message": "added python-dotenv to setup.cfg",
"patch_to_review": "diff --git a/notebooks/Experimental/Ishan/HelperMessages.ipynb b/notebooks/Experimental/Ishan/HelperMessages.ipynb\nnew file mode 100644\nindex 00000000000..474b7432a05\n--- ... | [
{
"diff_hunk": "@@ -55,6 +55,7 @@ syft =\n tqdm==4.64.0\n typing_extensions==4.1.1 # backport to older python 3\n pyzmq==23.2.1 # https://github.com/zeromq/pyzmq/issues/1764\n+ python-dotenv==0.21.0",
"line": null,
"original_line": 58,
"original_start_line": null,
"path": "package... | 3e575b3c963a885c06c7a06178048932c3a860d9 | diff --git a/notebooks/Experimental/Ishan/HelperMessages.ipynb b/notebooks/Experimental/Ishan/HelperMessages.ipynb
new file mode 100644
index 00000000000..474b7432a05
--- /dev/null
+++ b/notebooks/Experimental/Ishan/HelperMessages.ipynb
@@ -0,0 +1,129 @@
+{
+ "cells": [
+ {
+ "cell_type": "code",
+ "execution_coun... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
PostHog__posthog-21525@d71de94 | PostHog/posthog | Python | 21,525 | feat(surveys): Add support for duplicating survey | ## Problem
Attempts to address - fixes https://github.com/PostHog/posthog/issues/18615
## Changes
Duplication are handled with getting existing survey, patching some of it, and then requesting for a new survey.
Alternatively, since this causes two waterfall calls, we can add a specific endpoint which handles this... | 2024-04-13T21:53:46Z | Duplicate a survey
This would be quite useful to have, because I tested a survey by filling it out myself, and now I want to get rid of the answer so that it doesn’t skew the NPS. But I can’t delete events, so I thought I duplicate it. Nope :confused: | [
{
"body": "This would be quite useful to have, because I tested a survey by filling it out myself, and now I want to get rid of the answer so that it doesn’t skew the NPS. But I can’t delete events, so I thought I duplicate it. Nope :confused:",
"number": 18615,
"title": "Duplicate a survey"
}
] | 1df7232441b7b5e3abf79739dd8c7d2193238c6d | {
"head_commit": "d71de94a5f9d2c26ed48b72fa8f6c52946185de6",
"head_commit_message": "SURVEYS: BACKENDS: Add an endpoint for duplication",
"patch_to_review": "diff --git a/frontend/src/scenes/surveys/SurveyView.tsx b/frontend/src/scenes/surveys/SurveyView.tsx\nindex 95c2ca6df47cf..68a3b18fcfc71 100644\n--- a/front... | [
{
"diff_hunk": "@@ -53,6 +68,11 @@ export const surveysLogic = kea<surveysLogicType>([\n const updatedSurvey = await api.surveys.update(id, { ...updatePayload })\n return values.surveys.map((survey) => (survey.id === id ? updatedSurvey : survey))\n },\n+ du... | 20a984bf7748faad0fc92ff2a5ec1f9a07b8701d | diff --git a/cypress/e2e/surveys.cy.ts b/cypress/e2e/surveys.cy.ts
index e3efcd4c48a0f..fd3a60ca6bc1a 100644
--- a/cypress/e2e/surveys.cy.ts
+++ b/cypress/e2e/surveys.cy.ts
@@ -221,4 +221,64 @@ describe('Surveys', () => {
cy.get('[data-attr=surveys-table]').should('contain', name)
cy.get(`[data-row-ke... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
Rapptz__discord.py-5068@54c9f60 | Rapptz/discord.py | Python | 5,068 | Raise TypeError when Optional is used with Greedy converter | ### Summary
This closes #2253. Having Union[..., `None`] makes no sense in Greedy, and should throw an error.
### Checklist
<!-- Put an x inside [ ] to check it, like so: [x] -->
- [x] If code changes were made then they have been tested.
- [x] I have updated the documentation to reflect the changes.
... | 2020-06-27T23:44:26Z | [Commands] Using a typing.Optional[] converter in a commands.Greedy[] one
### Summary
I tried making a command with an argument like
`cmd(ctx, arg: commands.Greedy[typing.Optional[int]])`
(actual command and types not shown, but they work on their own)
However, the bot gets stuck in an infinite loop in Command._t... | This should probably just error out since it doesn't make sense. | [
{
"body": "### Summary\r\n\r\nI tried making a command with an argument like\r\n`cmd(ctx, arg: commands.Greedy[typing.Optional[int]])`\r\n(actual command and types not shown, but they work on their own)\r\nHowever, the bot gets stuck in an infinite loop in Command._transform_greedy_pos().\r\n\r\n### Reproductio... | f94b00cb48f3763dc3119d28717567ea6dc9e131 | {
"head_commit": "54c9f601fc6b5def31ed0c74c6aff3b28acccca0",
"head_commit_message": "Raise TypeError when Optional is used with Greedy converter",
"patch_to_review": "diff --git a/discord/ext/commands/converter.py b/discord/ext/commands/converter.py\nindex 3d706bf80eeb..993aed776dce 100644\n--- a/discord/ext/comm... | [
{
"diff_hunk": "@@ -555,6 +556,9 @@ def __getitem__(self, params):\n if converter is str or converter is type(None) or converter is _Greedy:\n raise TypeError('Greedy[%s] is invalid.' % converter.__name__)\n \n+ if getattr(converter, '__origin__', None) is typing.Union and type(None) ... | cdebed4429287b1756222d1e69d9afeccb1f49ef | diff --git a/discord/ext/commands/converter.py b/discord/ext/commands/converter.py
index 3d706bf80eeb..123b6699c90f 100644
--- a/discord/ext/commands/converter.py
+++ b/discord/ext/commands/converter.py
@@ -26,6 +26,7 @@
import re
import inspect
+import typing
import discord
@@ -555,6 +556,9 @@ def __getitem__... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
Rapptz__discord.py-6309@fa881f6 | Rapptz/discord.py | Python | 6,309 | Implement PartialMessage.edit | ## Summary
This PR implements a separate `edit` method for `PartialMessage` which returns a `Message` Object on edit. Additionally the `flags` on this edit will default since `ParitalMessage.flags` attribute doesn't exist, closes #6276.
## Checklist
<!-- Put an x inside [ ] to check it, like so: [x] -->
- [... | 2021-01-14T17:48:13Z | Make `PartialMessage.edit()` return a full `discord.Message` object
## The Problem
Discord's Message Edit API endpoint returns a message object, but `PartialMessage.edit()` returns `None`. It could be useful if that method constructed a full `discord.Message` object from the API response and returned it, so that peo... | [
{
"body": "## The Problem\r\n\r\nDiscord's Message Edit API endpoint returns a message object, but `PartialMessage.edit()` returns `None`. It could be useful if that method constructed a full `discord.Message` object from the API response and returned it, so that people can save a fetch request when they alread... | ed2650f7864229464b3317c08abde4345959f191 | {
"head_commit": "fa881f6e88b57c35b9bc2e600aeb0cdbb9738c62",
"head_commit_message": "Implement PartialMessage.edit",
"patch_to_review": "diff --git a/discord/message.py b/discord/message.py\nindex f47a45f30cc5..f732fcaa3cfc 100644\n--- a/discord/message.py\n+++ b/discord/message.py\n@@ -1351,7 +1351,6 @@ class Pa... | [
{
"diff_hunk": "@@ -1416,3 +1415,101 @@ async def fetch(self):\n \n data = await self._state.http.get_message(self.channel.id, self.id)\n return self._state.create_message(channel=self.channel, data=data)\n+\n+ async def edit(self, **fields):\n+ \"\"\"|coro|\n+\n+ Edits the mess... | 27315eb283bcbc11408047409812f812a695e16b | diff --git a/discord/message.py b/discord/message.py
index f47a45f30cc5..040078cb7a2c 100644
--- a/discord/message.py
+++ b/discord/message.py
@@ -1351,7 +1351,6 @@ class PartialMessage(Hashable):
_exported_names = (
'jump_url',
'delete',
- 'edit',
'publish',
'pin',
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
OpenMined__PySyft-3674@6ae9235 | OpenMined/PySyft | Python | 3,674 | Addition operation on FV scheme | ## Description
Closes #3656
Addition operation on FV scheme.
**Implemented:**
- Support Ciphertext Ciphertext addition
- Support Ciphertext Plaintext addition
- Support Plaintext Plaintext addition
## How has this been tested?
Added tests for every private method and simultaneously tested the public metho... | 2020-06-06T11:30:56Z | Implement Addition operation for FV HE Scheme
## Feature Description
Addition operations of FV Scheme need to be implemented.
1. It can **Add** 2 ciphertexts objects.
2. It can **Add** a ciphertext with plaintext objects.
In both cases, the result should be returned as a ciphertext object. | [
{
"body": "## Feature Description\r\nAddition operations of FV Scheme need to be implemented.\r\n\r\n1. It can **Add** 2 ciphertexts objects.\r\n2. It can **Add** a ciphertext with plaintext objects.\r\n\r\nIn both cases, the result should be returned as a ciphertext object.\r\n",
"number": 3656,
"title... | 27c6799a2bdde2a27023bf07e29c34f50ff33995 | {
"head_commit": "6ae923508a16e891321ce53cc63f18050aee4758",
"head_commit_message": "Docs update",
"patch_to_review": "diff --git a/examples/experimental/FV HE Experimentation.ipynb b/examples/experimental/FV HE Experimentation.ipynb\nindex 0c852f98bad..15b2b2a3b5a 100644\n--- a/examples/experimental/FV HE Experi... | [
{
"diff_hunk": "@@ -0,0 +1,91 @@\n+import copy\n+\n+from syft.frameworks.torch.he.fv.util.operations import poly_add_mod\n+from syft.frameworks.torch.he.fv.util.operations import multiply_add_plain_with_delta\n+from syft.frameworks.torch.he.fv.ciphertext import CipherText\n+from syft.frameworks.torch.he.fv.plai... | cc5c50dc5ab320a92af347c5e49dcbc95aed49b7 | diff --git a/examples/experimental/FV HE Experimentation.ipynb b/examples/experimental/FV HE Experimentation.ipynb
index 0c852f98bad..15b2b2a3b5a 100644
--- a/examples/experimental/FV HE Experimentation.ipynb
+++ b/examples/experimental/FV HE Experimentation.ipynb
@@ -19,6 +19,8 @@
}
],
"source": [
+ ... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
Rapptz__discord.py-2637@4805ca4 | Rapptz/discord.py | Python | 2,637 | [commands] Add a converter for discord.Object | ### Summary
Closes #2562. Also parses basic mentions for their IDs.
```py
@bot.command()
async def hackban(ctx, member: discord.Object):
await ctx.guild.ban(member)
```
### Checklist
- [x] If code changes were made then they have been tested.
- [x] I have updated the documentation to reflect th... | 2020-04-05T23:03:26Z | Use discord.Object annotation as an ID converter
### The Problem
It's quite common to have a command accept an arbitrary Discord ID value, in cases where obtaining such value (or it's respective model) via other converters would not be possible. The most iconic example of this would be a `hackban` command, where nor... | [
{
"body": "### The Problem\r\n\r\nIt's quite common to have a command accept an arbitrary Discord ID value, in cases where obtaining such value (or it's respective model) via other converters would not be possible. The most iconic example of this would be a `hackban` command, where normally it's possible for th... | 0542b129c2f7d60c5ec12b837d659ca35a58b1b1 | {
"head_commit": "4805ca46aed8a4dd89271ba5f9ea6fa375ecccfe",
"head_commit_message": "do the needful",
"patch_to_review": "diff --git a/discord/ext/commands/converter.py b/discord/ext/commands/converter.py\nindex 82ea36fd9f75..7479e9e344ae 100644\n--- a/discord/ext/commands/converter.py\n+++ b/discord/ext/commands... | [
{
"diff_hunk": "@@ -122,6 +122,30 @@ def _get_id_match(argument):\n return _ID_REGEX.match(argument)\n \n \n+class ObjectConverter(IDConverter[discord.Object]):\n+ \"\"\"Converts to a :class:`~discord.Object`.\n+\n+ The argument must follow the valid ID or mention formats (e.g. `<@8008851661626982... | 10b07f62403c325cc911d2060acb24478a7cce27 | diff --git a/discord/ext/commands/converter.py b/discord/ext/commands/converter.py
index 82ea36fd9f75..f1fd67201d7d 100644
--- a/discord/ext/commands/converter.py
+++ b/discord/ext/commands/converter.py
@@ -37,6 +37,7 @@
__all__ = (
'Converter',
+ 'ObjectConverter',
'MemberConverter',
'UserConverte... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
OpenMined__PySyft-3591@9fe6198 | OpenMined/PySyft | Python | 3,591 | Avoids multiple peers registration in the same grid environment. | ## Description
I just added a `_registered_peer` variable to hold the very first grid peer registration. So, any register made later, within the same runtime, the same instance is returned.
Resolves #3576
## Checklist:
* [ ] My changes are covered by tests.
* [x] I have run [the pre-commit hooks](https://... | 2020-05-21T22:46:57Z | Calling syft.grid.register() twice should throw an informative error
**Is your feature request related to a problem? Please describe.**
If you call syft.grid.register() twice in the same python runtime it should raise an error describing that you can't do this - that they shoudl restart the python runtime and try agai... | I'd like to take this one. | [
{
"body": "**Is your feature request related to a problem? Please describe.**\r\nIf you call syft.grid.register() twice in the same python runtime it should raise an error describing that you can't do this - that they shoudl restart the python runtime and try again.",
"number": 3576,
"title": "Calling s... | f97e562e1a56c4b37752838490474471e63aa85f | {
"head_commit": "9fe619827a6c3f3b6c86b8aa65700bf6086d2e83",
"head_commit_message": "add user warning message on multiple registration",
"patch_to_review": "diff --git a/syft/grid/__init__.py b/syft/grid/__init__.py\nindex 2e379fc86f4..2180cd92198 100644\n--- a/syft/grid/__init__.py\n+++ b/syft/grid/__init__.py\n... | [
{
"diff_hunk": "@@ -3,20 +3,27 @@\n \n DEFAULT_NETWORK_URL = \"ws://ec2-13-59-45-128.us-east-2.compute.amazonaws.com\"\n \n+_registered_peer = None\n+\n \n def register(**kwargs):\n \"\"\" Add this process as a new peer registering it in the grid network.\n- \n+\n Returns:\n peer:... | 49ad04edfc7d923d8df369ea6527053314545788 | diff --git a/syft/grid/__init__.py b/syft/grid/__init__.py
index dcf6274f2f7..726403516c0 100644
--- a/syft/grid/__init__.py
+++ b/syft/grid/__init__.py
@@ -4,13 +4,25 @@
DEFAULT_NETWORK_URL = "ws://ec2-13-59-45-128.us-east-2.compute.amazonaws.com"
+_registered_peer = None
+
def register(**kwargs):
""" Add... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
OpenMined__PySyft-3582@2c585a3 | OpenMined/PySyft | Python | 3,582 | Connection get overload | ## Description
This PR aims to create a function that will return a node from connections without have to use a private key.
Resolves #3577
## Checklist:
* [ ] My changes are covered by tests.
* [x] I have run [the pre-commit hooks](https://github.com/OpenMined/PySyft/blob/master/CONTRIBUTING.md#setting-up... | 2020-05-21T14:49:22Z | Overload __getitem__ to be able to index into connected nodes
**Is your feature request related to a problem? Please describe.**
When I call
```
me = sy.grid.register()
```
I want to be able to select connected nodes by just calling
```
me['another_node']
```
instead of having to use a private variab... | Can i take this one?
May I suggest something like `me.peers[“another_node”]` to make explicit what’s happening?
@karlhigley in this case, overload `__getitem__` is not necessary anymore?
Yeah, I guess not. 👍 | [
{
"body": "**Is your feature request related to a problem? Please describe.**\r\n\r\nWhen I call \r\n\r\n```\r\nme = sy.grid.register()\r\n```\r\nI want to be able to select connected nodes by just calling \r\n\r\n```\r\nme['another_node']\r\n```\r\n\r\ninstead of having to use a private variable\r\n\r\nme._con... | 501476ff01ae8f69ad12ddac4226291b4d52e46b | {
"head_commit": "2c585a310bb6cd8278f5cf99a8d9a1b82addf64e",
"head_commit_message": "running pre-commit",
"patch_to_review": "diff --git a/syft/grid/network.py b/syft/grid/network.py\nindex cebb1d73c76..a28dbfa60bc 100644\n--- a/syft/grid/network.py\n+++ b/syft/grid/network.py\n@@ -18,7 +18,7 @@\n class Network(t... | [
{
"diff_hunk": "@@ -164,3 +158,12 @@ def __repr__(self):\n list(self._worker.models.keys()),\n list(self._connection_handler.nodes),\n )\n+\n+ def peers(self, key):",
"line": null,
"original_line": 162,
"original_start_line": null,
"path": "syft/grid/network.py... | cfef2a1431364a813a475e3490e38faf06e53bd6 | diff --git a/syft/grid/network.py b/syft/grid/network.py
index cebb1d73c76..e3ebb0af33b 100644
--- a/syft/grid/network.py
+++ b/syft/grid/network.py
@@ -18,7 +18,7 @@
class Network(threading.Thread):
""" Grid Network class to operate in background processing grid requests
and handling multiple peer conne... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
Rapptz__discord.py-2162@2dbeb90 | Rapptz/discord.py | Python | 2,162 | [tasks] Add way to change interval at run-time | ### Summary
This pull request fixes #2158 by creating a `create_interval` method for a Loop, allowing the interval to be changed at run-time
### Checklist
<!-- Put an x inside [ ] to check it -->
- [x] If code changes were made then they have been tested.
- [x] I have updated the documentation to refle... | 2019-05-16T15:34:05Z | [tasks] Run-time changing of the sleep interval
### The Problem
No way to change the sleep interval at run-time.
### The Ideal Solution
Something like `task.change_interval(seconds=20.0)`.
It should apply on the next loop. If someone wants to do it right away regardless of the current loop they can cancel ... | [
{
"body": "### The Problem\r\n\r\nNo way to change the sleep interval at run-time.\r\n\r\n### The Ideal Solution\r\n\r\nSomething like `task.change_interval(seconds=20.0)`. \r\n\r\nIt should apply on the next loop. If someone wants to do it right away regardless of the current loop they can cancel it, change th... | bf5b267c5586a59b16ae8af0038cb628667333d5 | {
"head_commit": "2dbeb9091f7b4cc9a5be667d8bc080c746f73967",
"head_commit_message": "[tasks] Alter Loop.__init__ to use the new change_interval method",
"patch_to_review": "diff --git a/discord/ext/tasks/__init__.py b/discord/ext/tasks/__init__.py\nindex 543086446ccd..5c93dfbe8140 100644\n--- a/discord/ext/tasks/... | [
{
"diff_hunk": "@@ -317,6 +308,43 @@ def after_loop(self, coro):\n self._after_loop = coro\n return coro\n \n+ def change_interval(self, *, seconds=0, minutes=0, hours=0):\n+ \"\"\"Changes the interval for the sleep time, which can be called at run-time.\n+\n+ .. note::\n+\n+ ... | 0cb4ed2f609679ca7d253dc3ec4056a63d867588 | diff --git a/discord/ext/tasks/__init__.py b/discord/ext/tasks/__init__.py
index 543086446ccd..601d060348c4 100644
--- a/discord/ext/tasks/__init__.py
+++ b/discord/ext/tasks/__init__.py
@@ -18,9 +18,6 @@ class Loop:
"""
def __init__(self, coro, seconds, hours, minutes, count, reconnect, loop):
self.... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
PostHog__posthog-21528@eb7367c | PostHog/posthog | Python | 21,528 | feat(surveys): allow to stop surveys once reached enough responses | ## Problem
Fixes https://github.com/PostHog/posthog/issues/21179
## Changes
1. It allows a user to set responses limits for surveys on frontend
2. It creates a periodic task, which stops surveys which reached their limits
## Does this work well for both Cloud and self-hosted?
Yes
## How did you test ... | 2024-04-14T16:47:50Z | Stop a survey once enough responses received
## Is your feature request related to a problem?
*Please describe.*
## Describe the solution you'd like
## Describe alternatives you've considered
## Additional context
#### *Thank you* for your feature request – we love each and every one! | Hi @jurajmajerik, can I work on this issue?
So this requires setting a goal for a survey. I came up with [this](https://github.com/PostHog/posthog/assets/6707908/193cf0f8-7afa-4f8c-9a82-2c265c2ecb6c) design.
This also requires viewing the goal for the survey, something like [this](https://github.com/PostHog/posth... | [
{
"body": "## Is your feature request related to a problem?\r\n\r\n*Please describe.*\r\n\r\n## Describe the solution you'd like\r\n\r\n\r\n\r\n## Describe alternatives you've considered\r\n\r\n\r\n\r\n## Additional context\r\n\r\n\r\n\r\n#### *Thank you* for your feature request – we love each and every one!\r... | 33d09c0db8c8938cd076b53d66d1ac81b45b2b95 | {
"head_commit": "eb7367c785178cca16102f470988455e0dbaa7af",
"head_commit_message": "fix targeting",
"patch_to_review": "diff --git a/frontend/src/scenes/surveys/SurveyEdit.tsx b/frontend/src/scenes/surveys/SurveyEdit.tsx\nindex 1121d79be7f3a..85fc6e3e40270 100644\n--- a/frontend/src/scenes/surveys/SurveyEdit.tsx... | [
{
"diff_hunk": "@@ -0,0 +1,47 @@\n+from typing import List, Dict",
"line": null,
"original_line": 1,
"original_start_line": null,
"path": "posthog/tasks/stop_surveys_reached_target.py",
"start_line": null,
"text": "@author:\nSeems like the formatter wasn't applied here, also I doubt the ... | 78f5e02a8fc48afde86c8d2c3a768cb7d883dfb3 | diff --git a/cypress/e2e/surveys.cy.ts b/cypress/e2e/surveys.cy.ts
index fd3a60ca6bc1a..55a87ddbffe60 100644
--- a/cypress/e2e/surveys.cy.ts
+++ b/cypress/e2e/surveys.cy.ts
@@ -281,4 +281,23 @@ describe('Surveys', () => {
.contains('DRAFT')
.should('exist')
})
+
+ it.only('can set resp... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
OpenMined__PySyft-3525@aae3488 | OpenMined/PySyft | Python | 3,525 | Fix stray objects from FSS `Worker/Plan` initialization | ## Description
The extra objects initialized on every worker for FSS cause weird behavior in tests and very non-obvious object counts in unrelated parts of the code.
Resolves #3464
## Checklist:
* [X] My changes are covered by tests.
* [X] I have run [the pre-commit hooks](https://github.com/OpenMined/PySyft... | 2020-05-13T21:58:36Z | New PySyft workers are created with FSS `Plans` in their object storage
**Describe the bug**
When a new worker is created, it comes with some `Plans` already loaded into the object storage:
```
{67822474598: <Plan Plan id:67822474598 owner:bob Tags: #fss_eq_plan_1 built>,
42739784794: <Plan Plan id:42739784794 own... | I confirm this bug as well | [
{
"body": "**Describe the bug**\r\nWhen a new worker is created, it comes with some `Plans` already loaded into the object storage:\r\n```\r\n{67822474598: <Plan Plan id:67822474598 owner:bob Tags: #fss_eq_plan_1 built>,\r\n 42739784794: <Plan Plan id:42739784794 owner:bob Tags: #fss_eq_plan_2 built>,\r\n 98376... | 7d4f6239ae273af3740422989cdf8c2319370734 | {
"head_commit": "aae348857f86757c9d01f13c981cea8e484e958e",
"head_commit_message": "Fix stray objects from FSS `Worker/Plan` initialization",
"patch_to_review": "diff --git a/syft/workers/base.py b/syft/workers/base.py\nindex 6b79c5f7288..60cb6896706 100644\n--- a/syft/workers/base.py\n+++ b/syft/workers/base.py... | [
{
"diff_hunk": "@@ -710,6 +712,8 @@ def test_comp(workers, protocol):\n )\n \n if protocol == \"fss\":\n+ for worker in workers:",
"line": null,
"original_line": 715,
"original_start_line": null,
"path": "test/torch/tensors/test_additive_shared.py",
"start_line": null,
"te... | b382e9b3ca151587d1380f5eb0b9cf8bd1246500 | diff --git a/syft/workers/base.py b/syft/workers/base.py
index 6b79c5f7288..60cb6896706 100644
--- a/syft/workers/base.py
+++ b/syft/workers/base.py
@@ -182,8 +182,6 @@ def __init__(
# storage object for crypto primitives
self.crypto_store = PrimitiveStorage(owner=self)
- # declare the plans ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
PostHog__posthog-17857@38d0ca3 | PostHog/posthog | Python | 17,857 | fix: early access management cancel button | ## Problem
Fixes: #17841
## Changes
- 
- Also, fixed "cancel" button behaviour while creating and editing early access feature
## How did you test this code?
Locally in my browser
| 2023-10-08T05:33:00Z | Early Access Management issues
## Bug description
1. Early access management says its in beta on the page but not the sidebar (I get that there probably isn't room).
2. It is slightly jarring for the button to be "New public beta" as there is no mention of beta elsewhere
3. The empty state button is "Create featur... | I'd like to work on this. If I understand this correctly, I guess you want that "New public beta" to be same as "Create feature" or the other way around? Also, I observed that "cancel" button isn't working on "New Feature Release" page and I guess we can add that too to this issue.
correct, 'create feature' is good 👍 | [
{
"body": "## Bug description\r\n\r\n1. Early access management says its in beta on the page but not the sidebar (I get that there probably isn't room).\r\n2. It is slightly jarring for the button to be \"New public beta\" as there is no mention of beta elsewhere\r\n3. The empty state button is \"Create feature... | 1ba7328ac43a357307b99d6f7eb4e017522af2ac | {
"head_commit": "38d0ca309e0a80901bc33524f5adadcc68ec26b0",
"head_commit_message": "fix: early access management cancel button behaviour",
"patch_to_review": "diff --git a/frontend/src/scenes/early-access-features/EarlyAccessFeature.tsx b/frontend/src/scenes/early-access-features/EarlyAccessFeature.tsx\nindex 26... | [
{
"diff_hunk": "@@ -72,7 +77,14 @@ export function EarlyAccessFeature({ id }: { id?: string } = {}): JSX.Element {\n <>\n <LemonButton\n type=\"secondary\"\n- onClick={() => cancel(... | 86695a7171ad31fd578ab825d3cb729b8b464618 | diff --git a/cypress/e2e/early-access-management.cy.ts b/cypress/e2e/early-access-management.cy.ts
new file mode 100644
index 0000000000000..9a594d8d1c34c
--- /dev/null
+++ b/cypress/e2e/early-access-management.cy.ts
@@ -0,0 +1,55 @@
+describe('Early Access Management', () => {
+ beforeEach(() => {
+ cy.visit... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
SigmaHQ__sigma-4813@94a748c | SigmaHQ/sigma | Python | 4,813 | Add Image to avoid FP | <!--
Thanks for your contribution. Please make sure to fill the contents of this template with the necessary information to ease and speed up the review process.
!!! PLEASE DO NOT DELETE ANY SECTION, COMMENT OR THE CONTENT OF THE TEMPLATE. !!!
-->
### Summary of the Pull Request
<!--
**Please note that this... | 2024-04-14T07:09:13Z | FPs with "File Enumeration Via Dir Command"
### Rule UUID
7c9340a9-e2ee-4e43-94c5-c54ebbea1006
### Example EventLog
2019-05-21 09:35:12.705 +09:00 · File Enumeration Via Dir Command · low · IEWIN7 · Sysmon · 1 · Disc · T1217 · · 386 · Cmdline: "C:\Program Files\Mozilla Firefox\firefox.exe" -contentproc --channel="3... | [
{
"body": "### Rule UUID\n\n7c9340a9-e2ee-4e43-94c5-c54ebbea1006\n\n### Example EventLog\n\n2019-05-21 09:35:12.705 +09:00 · File Enumeration Via Dir Command · low · IEWIN7 · Sysmon · 1 · Disc · T1217 · · 386 · Cmdline: \"C:\\Program Files\\Mozilla Firefox\\firefox.exe\" -contentproc --channel=\"3168.20.150254... | 93b71ec1bbcff325709b07f0db42947690d7dee8 | {
"head_commit": "94a748c67271c6737c8ab6b3d15667443b916df0",
"head_commit_message": "Add Image to avoid FP",
"patch_to_review": "diff --git a/rules/windows/process_creation/proc_creation_win_cmd_dir_execution.yml b/rules/windows/process_creation/proc_creation_win_cmd_dir_execution.yml\nindex 97785562034..5845f080... | [
{
"diff_hunk": "@@ -1,4 +1,4 @@\n-title: File Enumeration Via Dir Command\n+title: File Enumeration and SubFolder Via Dir Command",
"line": null,
"original_line": 1,
"original_start_line": null,
"path": "rules/windows/process_creation/proc_creation_win_cmd_dir_execution.yml",
"start_line": n... | 0e0c134d69f8dac546e91e02252a24763d0ca237 | diff --git a/rules/windows/process_creation/proc_creation_win_cmd_dir_execution.yml b/rules/windows/process_creation/proc_creation_win_cmd_dir_execution.yml
index 97785562034..186f688a6cc 100644
--- a/rules/windows/process_creation/proc_creation_win_cmd_dir_execution.yml
+++ b/rules/windows/process_creation/proc_creati... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
OpenMined__PySyft-3403@e6bd0bc | OpenMined/PySyft | Python | 3,403 | Garbage Collection in `execute_computation_action`, Fix Inplace-Operation Identification | ## Description
Fixes #3397
Fixes #3398
~Currently breaks inplace computations. WIP 🚧🚧~
- [x] GC
- [x] Fix inplace operations
## Type of change
Please mark options that are relevant.
- [ ] Added/Modified tutorials
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-bre... | 2020-04-24T17:18:22Z | Memory leak in F.relu() method in AST
This code, causes a memory leak only on the first worker in the worker list passed to the `encrypt()`. In this example it is 'alice', the second worker 'bob' does not suffer from any leaks.
The reason is the `F.relu()` method:
```
import torch as th
import torch.optim as ... | [
{
"body": "This code, causes a memory leak only on the first worker in the worker list passed to the `encrypt()`. In this example it is 'alice', the second worker 'bob' does not suffer from any leaks.\r\n\r\nThe reason is the `F.relu()` method:\r\n\r\n```\r\nimport torch as th\r\nimport torch.optim as optim\r\... | bc2acbd67c9dc7e61240e64186c87aeb23ede180 | {
"head_commit": "e6bd0bcaecd0acc05e26391cd5972f2bf72c8e78",
"head_commit_message": "Cleanup",
"patch_to_review": "diff --git a/syft/frameworks/torch/tensors/interpreters/additive_shared.py b/syft/frameworks/torch/tensors/interpreters/additive_shared.py\nindex 0fb821e30bd..1e0535ff71b 100644\n--- a/syft/framework... | [
{
"diff_hunk": "@@ -943,7 +943,7 @@ def max(self, dim=None, return_idx=False):\n the maximum value (possibly across an axis)\n and optionally the index of the maximum value (possibly across an axis)\n \"\"\"\n- values = self\n+ values = self.copy()",
"line": nul... | 6d17ed3f9d3be31932182a1bad58fbdc12939903 | diff --git a/syft/frameworks/torch/torch_attributes.py b/syft/frameworks/torch/torch_attributes.py
index 946f35b215e..7e6fec25244 100644
--- a/syft/frameworks/torch/torch_attributes.py
+++ b/syft/frameworks/torch/torch_attributes.py
@@ -1,10 +1,8 @@
+import re
from types import ModuleType
-from typing import Union
-fr... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} | |
OpenMined__PySyft-3465@d7ecc1b | OpenMined/PySyft | Python | 3,465 | Update `Role.register_action()` to allow registering `CommunicationActions` | ## Description
This mostly standardizes the fields with `ComputationAction`, which makes it possible to register both action types interchangeably in `Roles`.
Depends on OpenMined/syft-proto#100
Resolves #3424
## Type of change
Please mark the options that are relevant.
- [ ] Added/Modified tutorials
... | 2020-05-07T19:56:06Z | Register `CommunicationActions` in `Roles` (for `Protocols`)
**Is your feature request related to a problem? Please describe.**
`Role.register_action()` should be able to register both `ComputationActions` and `CommunicationActions`. Some of the assumptions about which fields are present only make sense for `Computati... | [
{
"body": "**Is your feature request related to a problem? Please describe.**\r\n`Role.register_action()` should be able to register both `ComputationActions` and `CommunicationActions`. Some of the assumptions about which fields are present only make sense for `ComputationActions`, which causes errors when try... | 3f93d852f14ae367c77c0e43442f492288634ec3 | {
"head_commit": "d7ecc1bc08218ba731857b13c868f3e76de3d196",
"head_commit_message": "Remove unnecessary/untested support for lists/dicts as `Action` args",
"patch_to_review": "diff --git a/pip-dep/requirements.txt b/pip-dep/requirements.txt\nindex 60a812ac690..3b25958a32c 100644\n--- a/pip-dep/requirements.txt\n+... | [
{
"diff_hunk": "@@ -401,22 +401,27 @@ def bufferize_arg(worker: AbstractWorker, arg: object) -> ArgPB:\n setattr(protobuf_arg, attr_name, arg)\n except:\n getattr(protobuf_arg, attr_name).CopyFrom(_bufferize(worker, arg))\n+\n return protobuf_arg\n \n \n def unbufferize_args(worker: Abst... | 4623710e2ab94caac3edc9b6ada70e46a0f54cfa | diff --git a/pip-dep/requirements.txt b/pip-dep/requirements.txt
index 60a812ac690..05cf866ae1c 100644
--- a/pip-dep/requirements.txt
+++ b/pip-dep/requirements.txt
@@ -7,7 +7,7 @@ phe~=1.4.0
Pillow~=6.2.2
requests~=2.22.0
scipy~=1.4.1
-syft-proto~=0.4.1
+syft-proto~=0.4.3
tblib~=1.6.0
torchvision~=0.5.0
torch~=1... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
OpenMined__PySyft-3441@85a1515 | OpenMined/PySyft | Python | 3,441 | cleanup rnn.py | ## Description
This pull request simplifies the code in RNNBase. A significant amount of complexity was caused by using the same code to deal handling 2 different data structures of hidden state (LSTMCell has hidden+cell, GRUCell and RNNCell have only hidden). This was simplified by converting these 2 structures int... | 2020-05-03T15:06:43Z | Reduce complexity of ```forward``` from rnn
Split the code from ```forward``` into two separate functions and remove the ```noqa: C901```.
**Describe alternatives you've considered**
Simplify the function such that no split is required.
**Additional context**
Code quality:
```
2020-04-29T13:13:32.6026063Z ./s... | Hey, is it okay if I start working on this one?
Hey, sure. Assigned the issue to you. | [
{
"body": "Split the code from ```forward``` into two separate functions and remove the ```noqa: C901```.\r\n\r\n**Describe alternatives you've considered**\r\nSimplify the function such that no split is required.\r\n\r\n**Additional context**\r\nCode quality:\r\n```\r\n2020-04-29T13:13:32.6026063Z ./syft/frame... | 63af4f2a487d5e96d3a85d256dff13ecd8cbdbb5 | {
"head_commit": "85a1515a6c0ab56a031281564f6cff5115d9b006",
"head_commit_message": "cleanup rnn.py",
"patch_to_review": "diff --git a/syft/frameworks/torch/nn/rnn.py b/syft/frameworks/torch/nn/rnn.py\nindex a5ad317778f..8c79e3b2202 100644\n--- a/syft/frameworks/torch/nn/rnn.py\n+++ b/syft/frameworks/torch/nn/rnn... | [
{
"diff_hunk": "@@ -185,106 +185,77 @@ def __init__(\n # Link to issue: https://github.com/OpenMined/PySyft/issues/2500\n \n # Build RNN layers\n- self.rnn_forward = nn.ModuleList()\n- for layer in range(self.num_layers):\n- if layer == 0:\n- self.rnn_forw... | ef33d3316b8d2188e27bad35b969c08e38970888 | diff --git a/syft/frameworks/torch/nn/rnn.py b/syft/frameworks/torch/nn/rnn.py
index a5ad317778f..8f6ee3d23e1 100644
--- a/syft/frameworks/torch/nn/rnn.py
+++ b/syft/frameworks/torch/nn/rnn.py
@@ -184,107 +184,88 @@ def __init__(
# TODO: implement a nn.Dropout class for PySyft
# Link to issue: https:/... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Code Refactoring / Architectural Improvement"
} |
OpenMined__PySyft-3343@a6ec3ba | OpenMined/PySyft | Python | 3,343 | Fix Memory Leak in AST Operations | Fixes #3316
## Current progress
- [x] Worker 1
- [x] Worker 2
- [x] Crypto Provider
- [x] Multi Party
- [x] Clean-Up
- [x] Tests
## The Change in Behaviour
<details>
<summary>Code Used to Test</summary>
```python
import torch as th
import syft as sy
hook = sy.TorchHook(th)
alice = sy.Vir... | 2020-04-12T13:37:35Z | Garbage collection: memory leak in SMPC
**Describe the bug**
Garbage collection is not working as expected in SMPC
**To Reproduce**
```python
import torch as th
import syft as sy
hook = sy.TorchHook(th)
bob = sy.VirtualWorker(hook, id="bob")
alice = sy.VirtualWorker(hook, id="alice")
crypto_provider = sy.V... | I'd like to take up this issue!
And very importantly to note: if you comment out `classifier(b)` the problem is no longer there
Thanks @Syzygianinfern0!
Let us know if you're blocked. I've put the issue under "High Priority"
Suggestion: you might want to try first if simple multiplication has a GC issue :)
> Thanks ... | [
{
"body": "**Describe the bug**\r\nGarbage collection is not working as expected in SMPC\r\n\r\n**To Reproduce**\r\n```python\r\nimport torch as th\r\nimport syft as sy\r\n\r\nhook = sy.TorchHook(th)\r\nbob = sy.VirtualWorker(hook, id=\"bob\")\r\nalice = sy.VirtualWorker(hook, id=\"alice\")\r\ncrypto_provider =... | c41433301bfa1b156a6fe8b3eac226983a56007d | {
"head_commit": "a6ec3ba01b32e8db882bc1baee84307b03fb0e56",
"head_commit_message": "Add move, mul and nn tests",
"patch_to_review": "diff --git a/syft/frameworks/torch/tensors/interpreters/additive_shared.py b/syft/frameworks/torch/tensors/interpreters/additive_shared.py\nindex 5533508170c..da0dcafb7d8 100644\n-... | [
{
"diff_hunk": "@@ -711,6 +711,7 @@ def register_tensor(\n response_ids: List of ids where the tensor should be stored\n and each id is pop out when needed.\n \"\"\"\n+ # owner.de_register_obj(tensor)",
"line": null,
"original_line": 714,
"original_start_line": null,
"... | 9b72b3c0f24d5d7c5803a09b9adc5454cf6bd289 | diff --git a/syft/frameworks/torch/tensors/interpreters/additive_shared.py b/syft/frameworks/torch/tensors/interpreters/additive_shared.py
index 5533508170c..da0dcafb7d8 100644
--- a/syft/frameworks/torch/tensors/interpreters/additive_shared.py
+++ b/syft/frameworks/torch/tensors/interpreters/additive_shared.py
@@ -155... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
OpenMined__PySyft-3457@673296b | OpenMined/PySyft | Python | 3,457 | Ability to seed the `IdProvider`, Verbosity Toggling from `TorchHook` | ## Features
## Seed the IdProvider
During most of my debugging sessions (especially the GC ones), the need to trace the course of specific tensors was very important. And the way to do that was through their IDs as that is basically the identity of any syft object.
These changes give an ability to seed the `IdPro... | 2020-05-06T13:46:54Z | matmul in AST error when verbose=True
**Describe the bug**
Matrix multiplication of AST throws an error when workers are verbose
**To Reproduce**
```
import torch
import syft as sy
hook = sy.TorchHook(torch)
alice = sy.VirtualWorker(hook=hook, id = "alice", verbose=True)
bob = sy.VirtualWorker(hook=hook, ... | [
{
"body": "**Describe the bug**\r\nMatrix multiplication of AST throws an error when workers are verbose\r\n\r\n**To Reproduce**\r\n\r\n```\r\nimport torch\r\nimport syft as sy\r\nhook = sy.TorchHook(torch)\r\n\r\nalice = sy.VirtualWorker(hook=hook, id = \"alice\", verbose=True)\r\nbob = sy.VirtualWorker(hook=h... | 1b4146945265f9b8372314a4ca26ef635fb2a3fd | {
"head_commit": "673296b196a1f01e5e6b3b134d3e3bc89b22690c",
"head_commit_message": "`_virtual_workers` as set\nVerbose condition corrected\nFix obj_id missing but called",
"patch_to_review": "diff --git a/syft/__init__.py b/syft/__init__.py\nindex 5572d8213f7..e91b8e1acdd 100644\n--- a/syft/__init__.py\n+++ b/sy... | [
{
"diff_hunk": "@@ -97,6 +103,9 @@ def __init__(\n # Save the provided torch module as an attribute of the hook\n self.torch = torch\n self.framework = self.torch\n+ if seed is not None:\n+ syft.manual_seed(seed)",
"line": null,
"original_line": 107,
"origin... | 4cce1797ac7e5889bce29869207a4f0b64045767 | diff --git a/syft/frameworks/torch/hook/hook.py b/syft/frameworks/torch/hook/hook.py
index 38c2a5a4a19..9eef64ea5d1 100644
--- a/syft/frameworks/torch/hook/hook.py
+++ b/syft/frameworks/torch/hook/hook.py
@@ -85,9 +85,15 @@ class TorchHook(FrameworkHook):
"""
def __init__(
- self, torch, local_worker... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
OpenMined__PySyft-3271@f0fd01d | OpenMined/PySyft | Python | 3,271 | Remove implicit inplace fix_precision for PointerTensor | Fixes #3261 | 2020-03-29T14:41:59Z | fix_precision() is inplace when applied to a pointer tensor.
**Description of the bug**
The method fix_precision() applied on pointers is 'inplace'. This should not be the case
In the following code:
```
a = torch.Tensor([2., 3.]).send(bob)
a.fix_precision()
a = a.get()
print(type(a))
```
The variable `... | I can take this!!
Hey @AlanAboudib @karlhigley @LaRiffle ,
so if I understand this correctly,
```python
x = th.Tensor([1.,2.,3.]).send(bob)
x_fx = x.fix_precision()
x = x_fx.get()
```
x_fx is a `PointerTensor` and expected behavior is to be a `FixedPrecisionTensor` with `PointerTensor` as child?
Moreover ... | [
{
"body": "**Description of the bug**\r\nThe method fix_precision() applied on pointers is 'inplace'. This should not be the case\r\n\r\nIn the following code:\r\n\r\n```\r\na = torch.Tensor([2., 3.]).send(bob)\r\na.fix_precision()\r\na = a.get()\r\nprint(type(a))\r\n```\r\n\r\nThe variable `a` after calling `... | 1b0faa3ede31d481c8b535998dc92b229439f02e | {
"head_commit": "f0fd01da97a14475e11089e4217dd646e65b4c8c",
"head_commit_message": "Add test",
"patch_to_review": "diff --git a/syft/frameworks/torch/tensors/interpreters/native.py b/syft/frameworks/torch/tensors/interpreters/native.py\nindex d69acac7a5f..8a6ce38fc13 100644\n--- a/syft/frameworks/torch/tensors/i... | [
{
"diff_hunk": "@@ -812,12 +812,14 @@ def fix_prec(self, *args, storage=\"auto\", field_type=\"int100\", no_wrap: bool = F\n if not kwargs.get(\"owner\"):\n kwargs[\"owner\"] = self.owner\n \n+ # we create a copy of pointer which prevents inplace fix precision\n if self.is_wra... | c6851acdeb125d36985f0f91785c37148e68580e | diff --git a/syft/frameworks/torch/tensors/interpreters/native.py b/syft/frameworks/torch/tensors/interpreters/native.py
index d69acac7a5f..2b899b1b825 100644
--- a/syft/frameworks/torch/tensors/interpreters/native.py
+++ b/syft/frameworks/torch/tensors/interpreters/native.py
@@ -813,11 +813,11 @@ def fix_prec(self, *a... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
OpenMined__PySyft-3296@fddeee4 | OpenMined/PySyft | Python | 3,296 | Plans support for typechecking, lists and dicts using serialized input. | # Description
This PR fixes #3184.
New features:
- Plans now have a new attribute: serialized_input, that will serialized the input at build time and compare it with the serialized input at call time.
- Plans now have support for type-checking at runtime based on the type provided at build time.
- Plans now s... | 2020-04-02T17:37:45Z | Improve Plans flexibility
**Is your feature request related to a problem? Please describe.**
Plans currently don't work exactly as normal function in the following scenarios:
- if some inputs that are not used in the computations
- if some inputs that are not used and are given in the output
- if input/ouput contai... | I will have a look on this. | [
{
"body": "**Is your feature request related to a problem? Please describe.**\r\nPlans currently don't work exactly as normal function in the following scenarios:\r\n- if some inputs that are not used in the computations\r\n- if some inputs that are not used and are given in the output\r\n- if input/ouput conta... | 623f950862ba63bd2b427f2fc9ce02bd3638e0e6 | {
"head_commit": "fddeee4af41cc73b3c902cb033d56295658448c3",
"head_commit_message": " Adding docstrings.",
"patch_to_review": "diff --git a/pip-dep/requirements.txt b/pip-dep/requirements.txt\nindex 60a812ac690..883ed5268d9 100644\n--- a/pip-dep/requirements.txt\n+++ b/pip-dep/requirements.txt\n@@ -7,7 +7,7 @@ ph... | [
{
"diff_hunk": "@@ -904,3 +904,28 @@ def plan_type_warn(dic):\n str(e.value)\n == \"'Plan plan_type_warn key k1 of element 0 of input does not provide the key kk1, while being build with that key.'\"\n )\n+\n+\n+def test_backward_autograd_can_be_traced(hook, workers):\n+ @sy.func2plan(arg... | 9d7d3bb422f1710f83aed36351bded6c7b2a7d15 | diff --git a/syft/execution/plan.py b/syft/execution/plan.py
index 2b4e6df5408..041c196e2d2 100644
--- a/syft/execution/plan.py
+++ b/syft/execution/plan.py
@@ -14,6 +14,7 @@
from syft.execution.role import Role
from syft.execution.state import State
from syft.execution.tracing import trace
+from syft.execution.type... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
OpenMined__PySyft-3256@cf9fdcc | OpenMined/PySyft | Python | 3,256 | Fix the placeholder serialization. | Fixes #3214.
The problem was that when reconstructing the network placeholders, the is_wrapper parameter from tensor was ignored.
The apparent issue with parameter serialization was due to the fact that when fetching a plan the wrapper parameter was incorrectly reconstructed as a plain parameter. This is actually do... | 2020-03-26T14:57:58Z | Fix parameter serialization
In some situations, parameters are not serialized properly. I suspect this is due to our implementation of parameter.data
Here is one example:
```python
class Net(sy.Plan):
def __init__(self):
super(Net, self).__init__()
self.fc1 = nn.Linear(1, 1)
def forwa... | I can take a look | [
{
"body": "In some situations, parameters are not serialized properly. I suspect this is due to our implementation of parameter.data\r\n\r\nHere is one example:\r\n```python\r\nclass Net(sy.Plan):\r\n def __init__(self):\r\n super(Net, self).__init__()\r\n self.fc1 = nn.Linear(1, 1)\r\n\r\n ... | d1bfd6dc0d7148afe9cad8611debdbf58eb490c0 | {
"head_commit": "cf9fdcc631e5834b3d3ed6d92b1aac1b0bfba918",
"head_commit_message": "Update comment to be accurate",
"patch_to_review": "diff --git a/syft/execution/placeholder.py b/syft/execution/placeholder.py\nindex 7986dc508fe..964b6e4600f 100644\n--- a/syft/execution/placeholder.py\n+++ b/syft/execution/plac... | [
{
"diff_hunk": "@@ -640,6 +640,7 @@ def forward(self, x):\n # Compare with local plan\n assert th.all(decrypted - expected.detach() < 1e-2)\n # assert fetched_plan.state.state_placeholders != plan.state.state_placeholders #TODO\n+ assert str(fetched_plan.state.tensors()) == str(plan.state.tensors... | be0374c58eacab79450a46e00bb556a80653a48c | diff --git a/syft/execution/placeholder.py b/syft/execution/placeholder.py
index 7986dc508fe..964b6e4600f 100644
--- a/syft/execution/placeholder.py
+++ b/syft/execution/placeholder.py
@@ -30,12 +30,10 @@ def instantiate(self, tensor):
Add a tensor as a child attribute. All operations on the placeholder will b... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ManimCommunity__manim-189@e9b3cdc | ManimCommunity/manim | Python | 189 | Properly parse the file path to get the module containing the Scenes | This PR will close #171 .
The lines/file concerned are:
https://github.com/ManimCommunity/manim/blob/ea79842b17ccb7e0a5eb33be5edc5abb4ce60b50/manim/__main__.py#L137-L139
The issue was that the regex based approach would fail when there was a `.` in the path and end up importing all scenes in the library instea... | 2020-07-09T09:40:13Z | With no scene specified on CLI, manim gives false choice.
I was running the command:
`manim -pl --media_dir ~/renderings ~/dev/manim/example_scenes/basic.py `
and was greeted by this:
```
[19:29:42] INFO Read configuration files: config.py:... | What a weird bug. Running manim on `basic.py` works as expected, but on `./basic.py` it doesn't:
```
$ manim -pl basic.py
[09:49:01] INFO Read configuration files: ['/home/leo/code/manim/manim/default.cfg'] config.py:416
1: OpeningManimEx... | [
{
"body": "I was running the command:\r\n`manim -pl --media_dir ~/renderings ~/dev/manim/example_scenes/basic.py ` \r\nand was greeted by this:\r\n```\r\n\r\n[19:29:42] INFO Read configuration files: config.py:416\r\n ['... | ea79842b17ccb7e0a5eb33be5edc5abb4ce60b50 | {
"head_commit": "e9b3cdca779133dc73d9ac4578c8ae1da1750c24",
"head_commit_message": "Use a better way of getting the module name from the file path.",
"patch_to_review": "diff --git a/manim/__main__.py b/manim/__main__.py\nindex d1536e26fc..c14ca06126 100644\n--- a/manim/__main__.py\n+++ b/manim/__main__.py\n@@ -... | [
{
"diff_hunk": "@@ -135,7 +135,7 @@ def get_module(file_name):\n sys.exit(2)\n else:\n if os.path.exists(file_name):\n- module_name = re.sub(r\"\\..+$\", \"\", file_name.replace(os.sep, \".\"))\n+ module_name = file_name[:-3].replace(os.sep, '.').split('.')[-1]",
... | 75ebd56029a1da34f7813e2a6c63925d9c90df23 | diff --git a/manim/__main__.py b/manim/__main__.py
index d1536e26fc..df5e9dd307 100644
--- a/manim/__main__.py
+++ b/manim/__main__.py
@@ -135,7 +135,9 @@ def get_module(file_name):
sys.exit(2)
else:
if os.path.exists(file_name):
- module_name = re.sub(r"\..+$", "", file_name.repla... | {
"difficulty": "medium",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
OpenMined__PySyft-3234@044c5be | OpenMined/PySyft | Python | 3,234 | Add a `protocol` kwarg to `encrypt()` method to select between MPC and Paillier HE | Fixes [#3212](https://github.com/OpenMined/PySyft/issues/3212)
> Modify .encrypt() to add a kwarg and be used not only for Paillier encryption but only MPC (default should be MPC, and it should call for mpc .fix_prec(...).share(...) under the hood) | 2020-03-21T14:28:45Z | Enhance encryption API
Two features here:
- Make `crypto_provider` kwargs mandatory in `.share()`and check that it's not a client_worker
- Modify `.encrypt()` to add a kwarg and be used not only for Paillier encryption but only MPC (default should be MPC, and it should call for mpc .fix_prec(...).share(...) under... | I can try the first part. | [
{
"body": "Two features here:\r\n\r\n- Make `crypto_provider` kwargs mandatory in `.share()`and check that it's not a client_worker\r\n- Modify `.encrypt()` to add a kwarg and be used not only for Paillier encryption but only MPC (default should be MPC, and it should call for mpc .fix_prec(...).share(...) und... | 6357bb6251fdc5e0ea6fab06f751d8b9ec8bfeea | {
"head_commit": "044c5be16fe953eb80646a2d92ecd1d6fce58310",
"head_commit_message": "Cover edge case in test\n?",
"patch_to_review": "diff --git a/syft/frameworks/torch/tensors/interpreters/native.py b/syft/frameworks/torch/tensors/interpreters/native.py\nindex d69acac7a5f..9230c1034b0 100644\n--- a/syft/framewor... | [
{
"diff_hunk": "@@ -992,19 +992,57 @@ def torch_type(self):\n else:\n return self.child.torch_type()\n \n- def encrypt(self, public_key):\n- \"\"\"This method will encrypt each value in the tensor using Paillier\n- homomorphic encryption.\n+ def encrypt(self, encryption_m... | 26a4d8b956f36a63336b2a53d2b4cce3b1ed0ca5 | diff --git a/syft/frameworks/torch/tensors/interpreters/native.py b/syft/frameworks/torch/tensors/interpreters/native.py
index d69acac7a5f..497c3e0fc7e 100644
--- a/syft/frameworks/torch/tensors/interpreters/native.py
+++ b/syft/frameworks/torch/tensors/interpreters/native.py
@@ -992,30 +992,94 @@ def torch_type(self):... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
OpenMined__PySyft-3083@7372edc | OpenMined/PySyft | Python | 3,083 | Multi-worker computation graphs (SplitNN) | We add an option to send() to support backpropagation on a computation graph held by several workers.
Fix #3000
Example:
```python
hook.local_worker.is_client_worker = False
x = th.tensor([1., 2., 3, 4, 5], requires_grad=True)
y = (x + x)
me.register_obj(y) # registration on the local worker is sometimes b... | 2020-02-21T18:50:23Z | Make .send() differentiable
**Is your feature request related to a problem? Please describe.**
If you build a graph of computation across multiple workers, you'll use send or move to do so. But those are not differentiable and hence .backward() won't work except on the last worker where you call it
**Describe the s... | Backward references would also be handy for garbage collection. | [
{
"body": "**Is your feature request related to a problem? Please describe.**\r\nIf you build a graph of computation across multiple workers, you'll use send or move to do so. But those are not differentiable and hence .backward() won't work except on the last worker where you call it\r\n\r\n**Describe the solu... | c917153274d767572cf76df0d4d3b116ed7fb17b | {
"head_commit": "7372edc87934fc5c4236affb588cf4b0bba78eb8",
"head_commit_message": "Fix tests",
"patch_to_review": "diff --git a/examples/tutorials/advanced/Split Neural Network/Tutorial 1 - SplitNN Introduction.ipynb b/examples/tutorials/advanced/Split Neural Network/Tutorial 1 - SplitNN Introduction.ipynb\nind... | [
{
"diff_hunk": "@@ -58,6 +58,42 @@ class TorchTensor(AbstractTensor):\n def has_child(self):\n return hasattr(self, \"child\")\n \n+ def trigger_origin_backward_hook(self, sender: str, origin_id: int):\n+ \"\"\"\n+ This hook is triggered when a tensor which was received from a sende... | cd5a646e2dca8dedb64c14ba6b67279ceca51d15 | diff --git a/examples/tutorials/advanced/Split Neural Network/Tutorial 1 - SplitNN Introduction.ipynb b/examples/tutorials/advanced/Split Neural Network/Tutorial 1 - SplitNN Introduction.ipynb
index 5ffade3a544..6f84792c072 100644
--- a/examples/tutorials/advanced/Split Neural Network/Tutorial 1 - SplitNN Introduction.... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
ManimCommunity__manim-203@293ee19 | ManimCommunity/manim | Python | 203 | Allow the user to type manim code when using - as filename. | Fixes the manim feature that allowed end users to enter manim code on the spot if they ran the `manim` command with `-` as the argument.
We just needed to import `types`, a built-in module, and the rest just fell into place.
I have added some log statements that make it clearer as to exactly what the end user had... | 2020-07-14T17:29:25Z | Document and test the '-' file name command line argument
The `get_module` function in `extract_scene.py` allows the user to input the code for a Scene from stdin, but only when the argument passed as file name is `-`. This should be documented somewhere. At the very least, the `-h` flag should mention this possibility... | That's weird, but it could be very useful
We should implement that but with a proper new flag
TBH I think that refactoring this into something usable, alongside with the necessary documentation and testing is going to be much more hassle than it's worth. It's unclear to me that the use cases merit the work needed here... | [
{
"body": "The `get_module` function in `extract_scene.py` allows the user to input the code for a Scene from stdin, but only when the argument passed as file name is `-`. This should be documented somewhere. At the very least, the `-h` flag should mention this possibility.",
"number": 75,
"title": "Doc... | 8c8de97d9a7ddc5aa5ac8d5bd80f691c500c5a35 | {
"head_commit": "293ee1940aeae09f212eb0d120853b7b894bc696",
"head_commit_message": "Allow the user to type manim code when using - as filename.\n\nAdd log statements informing the user of what they must do.",
"patch_to_review": "diff --git a/manim/__main__.py b/manim/__main__.py\nindex 63f7bebba4..0bd7225e54 100... | [
{
"diff_hunk": "@@ -123,7 +124,9 @@ def get_scene_classes_from_module(module):\n def get_module(file_name):\n if file_name == \"-\":\n module = types.ModuleType(\"input_scenes\")\n+ logger.info(\"Enter the code for your animation and end with an EOF (usually CTRL+D):\")",
"line": null,
... | 7cd6216c5fce153af604d3e66adada59888b20ae | diff --git a/manim/__main__.py b/manim/__main__.py
index 63f7bebba4..e47e405d95 100644
--- a/manim/__main__.py
+++ b/manim/__main__.py
@@ -6,6 +6,7 @@
import re
import traceback
import importlib.util
+import types
from .config import file_writer_config
from .scene.scene import Scene
@@ -123,7 +124,12 @@ def get_... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Test Suite / CI Enhancements"
} |
PostHog__posthog-14341@3b1d0b5 | PostHog/posthog | Python | 14,341 | feat(ingestion): run all analytic events through populateTeamDataStep | ## Problem
Closes #14327, part of removing the Postgres dependency from capture.py
## Changes
- Run all events through the `populateTeamDataStep`, not just events without a team_id. This allows us to:
- confirm that the Postgres load will be OK once we fully roll it out (and rollback without getting in a pi... | 2023-02-21T15:58:50Z | Lightweigth capture 1/4: always resolve team_id at p-s and compare result
Let's start doing it as soon as possible to build trust on the performance and accuracy of the resolution code in plugin-server.
- [ ] Always hit postgres for resolution, even if `team_id` is found in the event
- [ ] If `team_id` is found in the... | whether it's at the django or plugin-server level, for flags we already have a token->team cache in redis, which is somewhat battle-tested. You can re-use this too for the prom metric and then decide if it's good enough to switch :)
- if plugin-server-ingestion has lag while a user rotates their token, in-flights even... | [
{
"body": "Let's start doing it as soon as possible to build trust on the performance and accuracy of the resolution code in plugin-server.\n\n- [ ] Always hit postgres for resolution, even if `team_id` is found in the event\n- [ ] If `team_id` is found in the event, compare the lookup result, and increment a p... | 5345975b0c32a1f104cb8dee1462e46793f00aef | {
"head_commit": "3b1d0b5197ba1e09a69972da144a79dca8d0c761",
"head_commit_message": "ingestEvent: run all analytic events through runLightweightCaptureEndpointEventPipeline",
"patch_to_review": "diff --git a/plugin-server/src/main/ingestion-queues/batch-processing/each-batch-ingestion.ts b/plugin-server/src/main/... | [
{
"diff_hunk": "@@ -1,28 +1,69 @@\n import { PluginEvent } from '@posthog/plugin-scaffold'\n+import { Counter } from 'prom-client'\n \n+import { eventDroppedCounter } from '../../../main/ingestion-queues/metrics'\n import { PipelineEvent } from '../../../types'\n import { EventPipelineRunner } from './runner'\n... | 2d10c095a4800928be6b7c88dd2e13625442e0e9 | diff --git a/plugin-server/src/main/ingestion-queues/batch-processing/each-batch-ingestion.ts b/plugin-server/src/main/ingestion-queues/batch-processing/each-batch-ingestion.ts
index 3a7e114df8dab..b8530371aa3fa 100644
--- a/plugin-server/src/main/ingestion-queues/batch-processing/each-batch-ingestion.ts
+++ b/plugin-s... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
ManimCommunity__manim-166@e3ab30a | ManimCommunity/manim | Python | 166 | Added Scene caching | Closes #8
First of all, big thank you to @Aathish04 who helped me and allowed me to get inspiration from his previous attempt to build a Scene Cacher.
## Additions :
`Scene-caching` : if a play or wait invocation has already been rendered, manim now take the already rendreded video instead of rendering it agai... | 2020-06-27T16:21:23Z | Adding a Scene Cacher
For tedious and long animations, people often have to render it multiple times just to see a small change they made, wasting lots of time. I'm not exactly sure how we could accomplish this, but we could look into having a way to cache scenes that have already been animated. Since all partial scene... | This is a very good idea.
That reminds the optimization with the non-moving objects `self.update_frame(excluded_mobjects=moving_mobjects)` (l. 921 of scene.py) Maybe we could do something like that.
Very very good. I'd love to see a PR on this. @safinsingh would you be down to do that?
I can try to, but I'm not ex... | [
{
"body": "For tedious and long animations, people often have to render it multiple times just to see a small change they made, wasting lots of time. I'm not exactly sure how we could accomplish this, but we could look into having a way to cache scenes that have already been animated. Since all partial scenes a... | 74c158cb1d68b0f1b927262cf3b931e0ab4d3a63 | {
"head_commit": "e3ab30a6a49663846343c049c91ac0b049313dca",
"head_commit_message": "Apply suggestions from code review\r\n\r\nThank you Captain Docs !\n\nCo-authored-by: Pg Biel <9021226+PgBiel@users.noreply.github.com>",
"patch_to_review": "diff --git a/manim/default.cfg b/manim/default.cfg\nindex d978e31b93..a... | [
{
"diff_hunk": "@@ -0,0 +1,191 @@\n+import json\n+import zlib\n+import inspect\n+import copy\n+import dis\n+import numpy as np\n+from types import ModuleType\n+\n+from ..logger import logger\n+\n+\n+class CustomEncoder(json.JSONEncoder):\n+ def default(self, obj):\n+ \"\"\"\n+ This method is us... | 7a3e1dc5d2ef47a9b20b65923f3a4fbebe42d0e5 | diff --git a/manim/default.cfg b/manim/default.cfg
index d978e31b93..a5006bd2f7 100644
--- a/manim/default.cfg
+++ b/manim/default.cfg
@@ -97,6 +97,12 @@ frame_rate = 60
pixel_height = 1440
pixel_width = 2560
+# Use -1 to set max_files_cached to infinity.
+max_files_cached = 100
+#Flush cache will delete all the ca... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
PostHog__posthog-14390@6db9afd | PostHog/posthog | Python | 14,390 | feat(funnels): allow seconds for funnel conversion window | ## Problem
A user would like to set their conversion window for a matter of seconds. While probably not _that_ common of a request, adding it seemed easy enough? And I can see how it would be useful.
Fixes https://github.com/PostHog/posthog/issues/14380
![image](https://user-images.githubusercontent.com/185981... | 2023-02-24T05:00:22Z | Allow setting conversion window limit in seconds
## Is your feature request related to a problem?
We would like to create an insight that identifies users returning to the same page very quickly. So far the best option I have identified to do this is to create a three step funnel with a conversion window limit. Howe... | [
{
"body": "## Is your feature request related to a problem?\r\n\r\nWe would like to create an insight that identifies users returning to the same page very quickly. So far the best option I have identified to do this is to create a three step funnel with a conversion window limit. However the minimum window lim... | 359b35dfd99f84045c46254832f76c9216fe3eaf | {
"head_commit": "6db9afd99be93288f07bb664536664794279b660",
"head_commit_message": "Update UI snapshots for `chromium` (1)",
"patch_to_review": "diff --git a/frontend/__snapshots__/components-integrations-slack--slack-integration-added.png b/frontend/__snapshots__/components-integrations-slack--slack-integration... | [
{
"diff_hunk": "@@ -1581,6 +1581,50 @@ def test_funnel_conversion_window(self):\n \n self.assertCountEqual([str(id) for id in self._get_actor_ids_at_step(filter, 2)], ids_to_compare)\n \n+ @snapshot_clickhouse_queries\n+ def test_funnel_conversion_window_seconds(self):\n+ id... | 1c6ae87895ec7a1b29a4c0584c62e9350fa3a57b | diff --git a/frontend/__snapshots__/components-integrations-slack--slack-integration-added.png b/frontend/__snapshots__/components-integrations-slack--slack-integration-added.png
index d55b52a440079..1feda2dcd15a7 100644
Binary files a/frontend/__snapshots__/components-integrations-slack--slack-integration-added.png an... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
ManimCommunity__manim-180@19a7c7c | ManimCommunity/manim | Python | 180 | Implement Logging of Terminal Output to a .log file. | Essentially what the title says.
You will be able to use the `--log_to_file` flag to log `rich`'s terminal output to the default log file location, and use `--log_dir <directory>` to pass a custom directory for logs via the command line.
Default values for both `log_to_file` and `log_dir` have been made in `defau... | 2020-07-08T05:21:53Z | Add save logs option
Add an option to save logs to an external file. Like `save_logs` parameter which can be passed along with CLI. It could help in many ways and would help beginners to get help 🆘.
### My ideas
It can easily be done by adding a file handler along with Rich handler but making it optional is a big ... | I like this. This could also be easily implemented after #98 | [
{
"body": "Add an option to save logs to an external file. Like `save_logs` parameter which can be passed along with CLI. It could help in many ways and would help beginners to get help 🆘.\r\n\r\n### My ideas\r\nIt can easily be done by adding a file handler along with Rich handler but making it optional is a ... | 3f6b9bf4eccca92999ac54cb74de31e196b33358 | {
"head_commit": "19a7c7c1f27362b79c96189ec7344a8f32c2ff67",
"head_commit_message": "Ignored Line Numbers during test.\n\nAdded some documentation for why word-for-word comparisons are not used.",
"patch_to_review": "diff --git a/manim/default.cfg b/manim/default.cfg\nindex 9cf64ede13..75e380871b 100644\n--- a/ma... | [
{
"diff_hunk": "@@ -529,3 +529,13 @@ def print_file_ready_message(self, file_path):\n Prints the \"File Ready\" message to STDOUT.\n \"\"\"\n logger.info(\"\\nFile ready at {}\\n\".format(file_path))\n+\n+ if file_writer_config[\"log_to_file\"]:\n+ self.write_log()\n+\n... | 1f51a2d18310cf68230774417b9bc08aa93a1ce7 | diff --git a/manim/default.cfg b/manim/default.cfg
index 9cf64ede13..c642acd38d 100644
--- a/manim/default.cfg
+++ b/manim/default.cfg
@@ -48,6 +48,9 @@ output_file =
# --leave_progress_bars
leave_progress_bars = False
+# --log_to_file
+log_to_file = False
+
# -c, --color
background_color = BLACK
@@ -67,6 +70,9... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
PostHog__posthog-13631@285e4d5 | PostHog/posthog | Python | 13,631 | feat(feature-flags): tags | ## Problem
<!-- Who are we building for, what are their needs, why is this important? -->
Users currently have no way to categorize or label their feature flags
## Changes
<img width="663" alt="Screen Shot 2023-01-11 at 8 57 28 PM" src="https://user-images.githubusercontent.com/25164963/211957700-beaf47b1-9c1f-4a... | 2023-01-11T03:11:14Z | Mark feature flag as temporary or permanent
## Is your feature request related to a problem?
I'm trying to migrate from LaunchDarkly to PostHog.
One feature I'm missing is the ability to mark a feature flag as "temporary" or "permanent", to make cleanup and management of flags much easier.
## Describe the solu... | Thought about this before. could be good to have a generic "label" with some sensible defaults like `[experiment, devtool, rollout]` or something. That way users can decide what labels are most useful to their workflows.
There is a different ticket to add a end date to a feature flag I think this might over lap with th... | [
{
"body": "## Is your feature request related to a problem?\r\n\r\nI'm trying to migrate from LaunchDarkly to PostHog.\r\n\r\nOne feature I'm missing is the ability to mark a feature flag as \"temporary\" or \"permanent\", to make cleanup and management of flags much easier.\r\n\r\n## Describe the solution you'... | 45d103a1de2faad97b31ede1784d70ce723accc3 | {
"head_commit": "285e4d5c61fd8f12ebd85f139fe0e56056a8b539",
"head_commit_message": "regex sadness",
"patch_to_review": "diff --git a/ee/clickhouse/views/test/test_clickhouse_experiments.py b/ee/clickhouse/views/test/test_clickhouse_experiments.py\nindex b27da90c6e627..0eb6f21d974bd 100644\n--- a/ee/clickhouse/vi... | [
{
"diff_hunk": "@@ -15,6 +15,7 @@ def run_and_check_migration(variable):\n sql = call_command(\"sqlmigrate\", results[0], results[1])\n if (\n re.findall(r\"(?<!DROP) (NOT NULL|DEFAULT)\", sql, re.M & re.I)\n+ and not re.match(r\"(?<!CREATE ... | d2585fea487c9b4cf3a36b77371ec464d49cc20a | diff --git a/ee/api/test/test_tagged_item.py b/ee/api/test/test_tagged_item.py
index d9e0f792e0bb7..18c9d28af38b7 100644
--- a/ee/api/test/test_tagged_item.py
+++ b/ee/api/test/test_tagged_item.py
@@ -4,7 +4,7 @@
from django.utils import timezone
from rest_framework import status
-from posthog.models import Dashboa... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
OpenMined__PySyft-2540@6ee7bd6 | OpenMined/PySyft | Python | 2,540 | Added test with send in plan | Test for plans using `send`.
Closes #2539 | 2019-08-21T19:26:17Z | Test send operation inside a plan
Make tests for using send inside a plan, the test will be something like:
```python
@sy.func2plan([th.Size((2,3))])
def plan_double_abs(x):
x = x.send(bob)
x = x + x
x = th.abs(x)
return x
ptr_result = plan_double_abs(th.zeros(3))
assert type(ptr_result, sy... | [
{
"body": "Make tests for using send inside a plan, the test will be something like:\r\n\r\n```python\r\n@sy.func2plan([th.Size((2,3))])\r\ndef plan_double_abs(x):\r\n x = x.send(bob)\r\n x = x + x\r\n x = th.abs(x)\r\n return x\r\n\r\nptr_result = plan_double_abs(th.zeros(3))\r\nassert type(ptr_res... | de25823127f37e4e7ddcf9bc02262badc6fb7416 | {
"head_commit": "6ee7bd68599ca39ead06dcbc4fee1a8990374efd",
"head_commit_message": "Added test with send in plan",
"patch_to_review": "diff --git a/.gitignore b/.gitignore\nindex 37a338b6333..c210fdfbe52 100644\n--- a/.gitignore\n+++ b/.gitignore\n@@ -20,3 +20,6 @@ docs/_modules\n .vscode/\n **/pip-wheel-metadat... | [
{
"diff_hunk": "@@ -20,3 +20,6 @@ docs/_modules\n .vscode/\n **/pip-wheel-metadata\n \n+# IDE specific",
"line": null,
"original_line": 23,
"original_start_line": null,
"path": ".gitignore",
"start_line": null,
"text": "@user1:\nThis is not related to the PR. Can you remove these changes... | 8af5eef20f5569b16fdf20af8269d75c7d1da725 | diff --git a/test/message/test_plan.py b/test/message/test_plan.py
index 08e08c9e575..136d71f3e8d 100644
--- a/test/message/test_plan.py
+++ b/test/message/test_plan.py
@@ -8,14 +8,10 @@
from syft.serde.serde import deserialize
from syft.serde.serde import serialize
from syft import messaging
-import time
import ... | {
"difficulty": "medium",
"estimated_review_effort": 2,
"problem_domain": "Test Suite / CI Enhancements"
} | |
SigmaHQ__sigma-3646@2aff1ac | SigmaHQ/sigma | Python | 3,646 | Rule Dev | This PR covers the following:
- Fix #3593 by adding more options and rewriting some parts of the rule to take into consideration more options that can be abused. I also added a related field to relate with a very similar rule [207b0396-3689-42d9-8399-4222658efc99](https://github.com/SigmaHQ/sigma/blob/b634e1a3f9d0d8... | 2022-10-26T22:11:49Z | logic error in proc_creation_win_susp_psexex_paexec_escalate_system.yml
The way this rule is applied in relation to the documentation would cause the suppression of true positive alerts due to differences in the command line use of PsExec/PAExec.
The selection `CommandLine|endswith: ' -s cmd.exe'` is used for PAEx... | [
{
"body": "The way this rule is applied in relation to the documentation would cause the suppression of true positive alerts due to differences in the command line use of PsExec/PAExec.\r\n \r\nThe selection `CommandLine|endswith: ' -s cmd.exe'` is used for PAExec but not the documented process for PsExec. Ac... | e74592644f063927e3db9648b8bac05fc542c0d6 | {
"head_commit": "2aff1acccd980d3e59f40f78cde82e443549e24b",
"head_commit_message": "Fix typo in selection",
"patch_to_review": "diff --git a/rules/web/web_win_webshells_in_access_logs.yml b/rules/web/web_win_webshells_in_access_logs.yml\nindex 64a04a2fdb5..6cbcb29639e 100644\n--- a/rules/web/web_win_webshells_in... | [
{
"diff_hunk": "@@ -4,32 +4,62 @@ status: test\n description: Detects Windows Webshells that use GET requests via access logs\n references:\n - https://bad-jubies.github.io/RCE-NOW-WHAT/\n+ - https://m365internals.com/2022/10/07/hunting-in-on-premises-exchange-server-logs/\n author: Florian Roth, Nasredd... | 8e3d1fa6531f12c9d4c1ad08c4973a60525e4927 | diff --git a/rules/web/web_win_webshells_in_access_logs.yml b/rules/web/web_win_webshells_in_access_logs.yml
index 64a04a2fdb5..86aa21bc356 100644
--- a/rules/web/web_win_webshells_in_access_logs.yml
+++ b/rules/web/web_win_webshells_in_access_logs.yml
@@ -4,32 +4,52 @@ status: test
description: Detects Windows Webshe... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} | |
ManimCommunity__manim-164@5eb9fed | ManimCommunity/manim | Python | 164 | Fix #101 | Fixes #101
The issue was that the lines of `NumberPlane` were automatically centred on the axis, which could cause problem when `x_max `was not equal to `x_min`. (same for y).
Example of the issue :
```python
class Test(Scene):
def construct(self):
NPac=NumberPlane(x_max=20).add_coordinates()
... | 2020-06-23T07:13:13Z | Bug in NumberPlane when using x_max (and likely the y/min values too)
```python
NPac=NumberPlane(x_max=20).add_coordinates()
class Test(Scene):
def construct(self):
self.add(NPac.shift([-15,0,0]))
self.wait(1)
```
This results in the horizontal lines not being anywhere near as long as they sh... | [
{
"body": "```python\r\nNPac=NumberPlane(x_max=20).add_coordinates()\r\nclass Test(Scene):\r\n def construct(self):\r\n self.add(NPac.shift([-15,0,0]))\r\n self.wait(1)\r\n```\r\nThis results in the horizontal lines not being anywhere near as long as they should be. Leaving this here for either... | 4b6492b0e7e7e4ae7e35938662571ad765027f3c | {
"head_commit": "5eb9fed85dc16f790a84432375d854020a14e750",
"head_commit_message": "fixed minor bug (small shift of the grid)",
"patch_to_review": "diff --git a/manim/mobject/coordinate_systems.py b/manim/mobject/coordinate_systems.py\nindex 10b2e2dca8..845d0d9845 100644\n--- a/manim/mobject/coordinate_systems.p... | [
{
"diff_hunk": "@@ -310,6 +311,16 @@ def init_background_lines(self):\n )\n \n def get_lines(self):\n+ \"\"\"Generate all the lines, faded and not faded. Two sets of lines are generated, parallel to the X-axis and to Y-axis.\n+ \n+ Returns\n+ -------\n+ :class:`~.V... | 353ca9dcc0eedf2df875120b2fd05ecb63766381 | diff --git a/manim/mobject/coordinate_systems.py b/manim/mobject/coordinate_systems.py
index 10b2e2dca8..3b2b9466f5 100644
--- a/manim/mobject/coordinate_systems.py
+++ b/manim/mobject/coordinate_systems.py
@@ -288,6 +288,7 @@ def __init__(self, **kwargs):
self.init_background_lines()
def init_backgroun... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
PostHog__posthog-12907@2889e84 | PostHog/posthog | Python | 12,907 | fix(action-matching): Match on nulls properly | ## Problem
Fixes https://github.com/PostHog/posthog/issues/12893
<!-- Who are we building for, what are their needs, why is this important? -->
## Changes
<!-- If there are frontend changes, please include screenshots. -->
<!-- If a reference design was involved, include a link to the relevant Figma frame!... | 2022-11-22T13:30:11Z | Webhook sends notifications on actions that don't meet the filter.
## Bug description
We have an action that is defined on an event and has two filters.
1. X event property is set.
2. X event != null.
The action is defined to _Post to webhook when this action is triggered_.
The bug is that PostHog wrongfully... | Hey Elon, mind sharing a link to the action that's problematic?
@neilkakkar Not sure if action IDs are global to all accounts, but here's mine - https://app.posthog.com/data-management/actions/20804.
The issue seems to be with the null exact match:
In Clickhouse matching:
```
( has(['null'], replaceRegexpAll(JSO... | [
{
"body": "## Bug description\r\n\r\nWe have an action that is defined on an event and has two filters.\r\n1. X event property is set.\r\n2. X event != null.\r\n\r\nThe action is defined to _Post to webhook when this action is triggered_.\r\n\r\nThe bug is that PostHog wrongfully sends notification when the act... | 23cce26ed729f57fcefe1d0ad196c4a2a4734278 | {
"head_commit": "2889e84a7ba0c79f6d019e41c16d5602cddffc04",
"head_commit_message": "one more test",
"patch_to_review": "diff --git a/plugin-server/src/worker/ingestion/action-matcher.ts b/plugin-server/src/worker/ingestion/action-matcher.ts\nindex bbbbee282b09d..36f378f5d2083 100644\n--- a/plugin-server/src/work... | [
{
"diff_hunk": "@@ -52,6 +52,25 @@ export function castingCompare(\n b: any,\n operator: PropertyOperator.Exact | PropertyOperator.IsNot | PropertyOperator.LessThan | PropertyOperator.GreaterThan\n ): boolean {\n+ // Check null case first\n+ if (a === null || b === null) {",
"line": null,
... | 2d67e34698548413a4da4daad6f86e39fad17b7a | diff --git a/plugin-server/src/worker/ingestion/action-matcher.ts b/plugin-server/src/worker/ingestion/action-matcher.ts
index bbbbee282b09d..045c13ef82a44 100644
--- a/plugin-server/src/worker/ingestion/action-matcher.ts
+++ b/plugin-server/src/worker/ingestion/action-matcher.ts
@@ -52,6 +52,17 @@ export function cast... | {
"difficulty": "low",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
PostHog__posthog-12213@1730abc | PostHog/posthog | Python | 12,213 | feat: Revamped Recordings list | ## Problem
Needs https://github.com/PostHog/posthog/pull/12207 (some of the logic breaks the old view so we may as well wait till this is merged than fix the old view)
The new recordings playlist uses a LemonTable which is overkill given the data source and we want some specific styles that don't work well with i... | 2022-10-12T10:54:34Z | Display if a recording is watched on the Recordings page
## Is your feature request related to a problem?
I see that the recordings page is updated with a new UI/UX. The last version had a way to identify if the user had already watched the recording or not (the play icon was blue when a recording was not watched, a... | @eraldoforgoli Thanks for the suggestion. This was already in the works but I bumped it up. Should have an indicator as well as some other improvements coming in the next days 💪 | [
{
"body": "## Is your feature request related to a problem?\r\n\r\nI see that the recordings page is updated with a new UI/UX. The last version had a way to identify if the user had already watched the recording or not (the play icon was blue when a recording was not watched, and gray when watched).\r\n\r\n## D... | be11df8177828b864d02596ca45dbfdd07545d19 | {
"head_commit": "1730abc51126abb03875d6616df213745737547f",
"head_commit_message": "Fixed view on small screens",
"patch_to_review": "diff --git a/frontend/src/lib/components/LemonTable/LemonTable.scss b/frontend/src/lib/components/LemonTable/LemonTable.scss\nindex fda2a12bddaff..6bf3fe9e888f5 100644\n--- a/fron... | [
{
"diff_hunk": "@@ -1,123 +1,197 @@\n import React, { useRef } from 'react'\n import { useActions, useValues } from 'kea'\n-import { colonDelimitedDuration } from '~/lib/utils'\n+import { colonDelimitedDuration, range } from '~/lib/utils'\n import { SessionRecordingType } from '~/types'\n-import { getRecordingL... | 82db39d2744c3fe56720a5e27096024a6e3d96df | diff --git a/frontend/src/lib/components/LemonTable/LemonTable.scss b/frontend/src/lib/components/LemonTable/LemonTable.scss
index fda2a12bddaff..6bf3fe9e888f5 100644
--- a/frontend/src/lib/components/LemonTable/LemonTable.scss
+++ b/frontend/src/lib/components/LemonTable/LemonTable.scss
@@ -66,31 +66,6 @@
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
ManimCommunity__manim-105@24f312a | ManimCommunity/manim | Python | 105 | ArcBetweenPoints fix/enhancement | 1. The motivation for making this change (#40)
mobject.py has been slightly changed to fix an issue where points that weren't passed into ArcBetweenPoints as np.array caused manim to fail.
geometry.py had ArcBetweenPoints adjusted to also support radius instead of just angle. Small changes to Arc were necessary to fa... | 2020-05-28T09:30:27Z | Work on ArcBetweenPoints
As some of you know I've been working with arcs. A lot. At some point I'd want to add ArcPolygons to this manim fork, but first I want to work on the Arc derived class I usually work with, ArcBetweenPoints.
As per the tags there are 3 things to do here.
The bug:
ArcBetweenPoints, unlike ... | > Question 1: My issue here though is that this code needs math and cmath to work. What is the correct way of making sure those are available in geometry.py? Sure they can just be imported at the top of the file but is that actually the right way to go around it?
Yes. Importing standard libraries (or even third part... | [
{
"body": "As some of you know I've been working with arcs. A lot. At some point I'd want to add ArcPolygons to this manim fork, but first I want to work on the Arc derived class I usually work with, ArcBetweenPoints.\r\n\r\nAs per the tags there are 3 things to do here.\r\n\r\nThe bug:\r\nArcBetweenPoints, unl... | a29eabdf877442d3bee89a1d66bd0ff721484221 | {
"head_commit": "24f312a9a5830b5334637b12f415dcb2797e5053",
"head_commit_message": "ArcBetweenPoints fix/enhancement\n\nmobject.py has been slightly changed to fix an issue where points that weren't passed into ArcBetweenPoints as np.array caused manim to fail.\ngeometry.py had ArcBetweenPoints adjusted to support... | [
{
"diff_hunk": "@@ -278,7 +282,24 @@ def stop_angle(self):\n \n \n class ArcBetweenPoints(Arc):\n- def __init__(self, start, end, angle=TAU / 4, **kwargs):\n+ \"\"\"\n+ Inherits from Arc and additionally takes 2 points between which the arc is spanned.\n+ \"\"\"\n+ def __init__(self, start, end, ... | eda9ba8ff47d93571d40d29f5cd46cdfa5003301 | diff --git a/manim/mobject/geometry.py b/manim/mobject/geometry.py
index 5636219560..d9de953ac4 100644
--- a/manim/mobject/geometry.py
+++ b/manim/mobject/geometry.py
@@ -1,5 +1,6 @@
import warnings
import numpy as np
+import math
from ..constants import *
from ..mobject.mobject import Mobject
@@ -213,6 +214,7 @@... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
ManimCommunity__manim-59@00a786e | ManimCommunity/manim | Python | 59 | Add logger and replace print calls with appropriate logging functions | This commit adds a logger.py file and also replaces all `print` calls with logging functions like `logger.info`, `logger.warning`, `logger.error` etc.
Also adds rich as a dependency.
| 2020-05-22T07:06:59Z | Use a logging library
The first step in this task is to replace print calls with a logging library. The next step is to add logging calls to places that don't have logging yet.
@eulertour mentions both Loguru and the stdlib logging library as options. I'm partial to stdlib logging. | I’m too. It would save us from adding other dependencies.
Then do we keep the progressbar ?
I think the progressbar can definitely stay, I think the progressbar is a good UI addition for users creating their videos. The logging library would be a catch-all ranging from info to users as well as debugging information fo... | [
{
"body": "The first step in this task is to replace print calls with a logging library. The next step is to add logging calls to places that don't have logging yet.\r\n\r\n@eulertour mentions both Loguru and the stdlib logging library as options. I'm partial to stdlib logging.\r\n",
"number": 5,
"title... | 304ede48d8896ddd28cff71f8946a522053c6559 | {
"head_commit": "00a786edaa0a01f17d18e4902a3e24a80b2d373a",
"head_commit_message": "Add logger and replace print calls with appropriate logging functions\n\nThis commit adds a logger.py file and also replaces all `print` calls with logging functions like `logger.info`, `logger.warning`, `logger.error` etc.\n\nAlso... | [
{
"diff_hunk": "@@ -0,0 +1,12 @@\n+import logging\n+from rich.logging import RichHandler\n+\n+## Setting config for logger.",
"line": null,
"original_line": 4,
"original_start_line": null,
"path": "manim/logger.py",
"start_line": null,
"text": "@user1:\nNot a very useful comment :) I wou... | e447b3448117e20d293cc15597fd511ae3b8c852 | diff --git a/manim/__init__.py b/manim/__init__.py
index 505db0fb4e..2bf9147035 100644
--- a/manim/__init__.py
+++ b/manim/__init__.py
@@ -4,7 +4,7 @@
from . import constants
-def main():
+def main():
args = config.parse_cli()
cfg = config.get_configuration(args)
config.initialize_directories(cf... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Code Refactoring / Architectural Improvement"
} |
ManimCommunity__manim-63@c933394 | ManimCommunity/manim | Python | 63 | Added dry run | I also updated README since python -m doesn't work anymore.
I added a test for quick testing | 2020-05-22T09:43:09Z | -w flag enabled by default
I just noticed an issue with the CLI arguments, and more particular concerning the `-w` (`write_to_movie`) flag.
It appears that when `-s` (`save_last_frame`) is False (most of the time, I think), `write_to_movie `is set True even though -w hasn't been placed. (that's why for example in the... | Good catch. I think we want to allow for four different behaviors:
1. write to movie ONLY
2. generate last frame ONLY
3. do both
4. do neither
Right now, option 1. is the default, no arguments necessary, 2. requires `-s`, and 3. is impossible. Is 4. possible? I think this can be useful for dry runs (for example ... | [
{
"body": "I just noticed an issue with the CLI arguments, and more particular concerning the `-w` (`write_to_movie`) flag. \r\nIt appears that when `-s` (`save_last_frame`) is False (most of the time, I think), `write_to_movie `is set True even though -w hasn't been placed. (that's why for example in the `READ... | 865c4c1499764160d1990bd08b24128ba32468cf | {
"head_commit": "c93339468cd291b601f08c2fbba04e1e64a345a1",
"head_commit_message": "added a very quick test",
"patch_to_review": "diff --git a/README.md b/README.md\nindex f7124d52d3..a26816b114 100644\n--- a/README.md\n+++ b/README.md\n@@ -193,11 +193,6 @@ For users:\n ```sh\n manim example_scenes.py SquareToCi... | [
{
"diff_hunk": "@@ -23,67 +23,72 @@ def parse_cli():\n \"-p\", \"--preview\",\n action=\"store_true\",\n help=\"Automatically open the saved file once its done\",\n- ),\n+ )\n parser.add_argument(\n \"-w\", \"--write_to_movie\",\n ... | 44717c8d882988ab573290a56e02bef3c5addbf2 | diff --git a/README.md b/README.md
index f7124d52d3..a26816b114 100644
--- a/README.md
+++ b/README.md
@@ -193,11 +193,6 @@ For users:
```sh
manim example_scenes.py SquareToCircle -pl
```
-1. Run the following command:
-For developers:
-```sh
-python3 manim.py example_scenes.py SquareToCircle -pl
-```
![](./readm... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ManimCommunity__manim-58@0e93213 | ManimCommunity/manim | Python | 58 | constants.py overhaul | -DIR variables have been moved into their own file to avoid overwriting user changes in the future (dirs.py)
-Initialization of directories has been moved to config.py, and a bunch of bugs associated to file structure generation have been fixed
-Global dir variable handling has been removed. Instead initialize_direct... | 2020-05-22T04:23:57Z | constants.py cleanup and improvement
manimlib/media_dir.txt is deprecated and should be removed, and the constants.py file should be brushed up as well.
Most notably the constant MEDIA_DIR currently gets completely ignored due to **always** being overwritten by this part of the code:
```python
if config["m... | @XorUnison is this issue really about constants.py, as the title suggest?
Yes, just to clarify, this issue is all about the constants.py, except maybe for the single line of code to add a 4K argument.
We should make a separate configuration file for stuff like media_dir and whatnot; .cfg seems like a nice option
The di... | [
{
"body": "manimlib/media_dir.txt is deprecated and should be removed, and the constants.py file should be brushed up as well.\r\n\r\nMost notably the constant MEDIA_DIR currently gets completely ignored due to **always** being overwritten by this part of the code:\r\n```python\r\n if config[\"media_dir\... | a933dd370d8588a5eb7c1ab0becda09ca39dd896 | {
"head_commit": "0e93213b5ca566913604b4ba7d57103cc52315ad",
"head_commit_message": "Small fixes\n\n-Removed an unnecessary line\n-Removed media_dir.txt again because GitHub Desktop had re-added it",
"patch_to_review": "diff --git a/manim/__init__.py b/manim/__init__.py\nindex 1185c9c3b0..08c5844bdc 100644\n--- a... | [
{
"diff_hunk": "@@ -239,3 +239,47 @@ def get_camera_configuration(args):\n camera_config[\"background_opacity\"] = 0\n \n return camera_config\n+\n+\n+def initialize_directories(cfgargs):\n+ dir_config = {}\n+ dir_config[\"media_dir\"] = cfgargs[\"media_dir\"] or dirs.MEDIA_DIR\n+ dir_confi... | e138ee4e0accef18846ce30bf60d6f7bc74f1a42 | diff --git a/manim/__init__.py b/manim/__init__.py
index 1185c9c3b0..505db0fb4e 100644
--- a/manim/__init__.py
+++ b/manim/__init__.py
@@ -1,4 +1,5 @@
#!/usr/bin/env python
+from . import extract_scene
from . import config
from . import constants
@@ -6,6 +7,5 @@
def main():
args = config.parse_cli()
cfg... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Code Refactoring / Architectural Improvement"
} |
PostHog__posthog-8874@960dad4 | PostHog/posthog | Python | 8,874 | perf: Parallel execution of trends graph series | ## Problem
We can massively speed up queries with multiple graph series by executing the clickhouse queries in parallel
closes #8834
## Changes
- Run multiple graph series in parallel
## How did you test this code?
<!-- If the answer is manually, please include a quick step-by-step on how to test this... | 2022-03-04T20:41:06Z | Calculate multi-line trends in parallel
## Is your feature request related to a problem?
If you have a trend with multiple lines, clickhouse queries for each are run one-after-another. If each takes 10s to calculate, then user will need to wait >30s in total.
## Describe the solution you'd like
Run queries in ... | Naive question: Is there a risk with potentially running lots of expensive queries running in parallel they end up causing each-other to fail (due to peak resource consumption)?
I don't think so - the load should be comparable to normal parallelism from users doing queries or background cache refreshes.
But if not ... | [
{
"body": "## Is your feature request related to a problem?\r\n\r\nIf you have a trend with multiple lines, clickhouse queries for each are run one-after-another. If each takes 10s to calculate, then user will need to wait >30s in total.\r\n\r\n## Describe the solution you'd like\r\n\r\nRun queries in parallel.... | e3dcdb5ca0bdf8ffca1eea88c3e04eb134993e62 | {
"head_commit": "960dad4b6cdd0b942bb76beb0d95d19677697366",
"head_commit_message": "remove unused lines",
"patch_to_review": "diff --git a/ee/clickhouse/queries/trends/clickhouse_trends.py b/ee/clickhouse/queries/trends/clickhouse_trends.py\nindex 9053bf4fe3d8f..f6b0d3f90f1c3 100644\n--- a/ee/clickhouse/queries/... | [
{
"diff_hunk": "@@ -52,6 +53,45 @@ def _run_query(self, filter: Filter, entity: Entity, team_id: int) -> List[Dict[\n serialized_data = self._handle_cumulative(serialized_data)\n return serialized_data\n \n+ def _run_query_for_threading(self, result: List, index: int, sql, params):\n+ ... | ee1733d4b8c5fd6b6e3cf71a670befa194a17de7 | diff --git a/ee/clickhouse/queries/trends/clickhouse_trends.py b/ee/clickhouse/queries/trends/clickhouse_trends.py
index 9053bf4fe3d8f..456d48278727e 100644
--- a/ee/clickhouse/queries/trends/clickhouse_trends.py
+++ b/ee/clickhouse/queries/trends/clickhouse_trends.py
@@ -1,6 +1,7 @@
import copy
+import threading
fro... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
PostHog__posthog-10293@7041fd3 | PostHog/posthog | Python | 10,293 | feat: save default live events columns | ## Problem
Fixes #10143
The user can now save live events columns as a project/team-wide default, as well as reorder them by drag and drop
## Changes
- Visible columns can be reordered by drag and drop
- Styled the modal according to [this Figma](https://www.figma.com/file/gQBj9YnNgD8YW4nBwCVLZf/PostHog-Ap... | 2022-06-14T11:31:40Z | Persist custom column settings (per user)
## Is your feature request related to a problem?
When I set custom columns in the live events tables and then leave PostHog these custom columns are not present when I come back
## Describe the solution you'd like
I would like my personal custom columns to be consistent ... | Related: https://github.com/PostHog/posthog/issues/10138
Should this also extend to some filter settings? As an example, if I want to change the default sorting for a list view, should that persist? Are there any other filter options that might be applicable?
This is how Notion does it for filters / sorting:
![image... | [
{
"body": "## Is your feature request related to a problem?\r\n\r\nWhen I set custom columns in the live events tables and then leave PostHog these custom columns are not present when I come back\r\n\r\n## Describe the solution you'd like\r\nI would like my personal custom columns to be consistent every time I ... | 3ced2ae1188093b321de17c2082e2e132b2b4429 | {
"head_commit": "7041fd36affcf61d8ae87e9a09d92edad4a6f984",
"head_commit_message": "fixes after review",
"patch_to_review": "diff --git a/cypress/e2e/events.js b/cypress/e2e/events.js\nindex 5ab0538bd976b..744cc8bdef844 100644\n--- a/cypress/e2e/events.js\n+++ b/cypress/e2e/events.js\n@@ -90,6 +90,14 @@ describe... | [
{
"diff_hunk": "@@ -111,6 +111,7 @@ class Team(UUIDClassicModel):\n timezone: models.CharField = models.CharField(max_length=240, choices=TIMEZONES, default=\"UTC\")\n data_attributes: models.JSONField = models.JSONField(default=get_default_data_attributes)\n person_display_name_properties: ArrayFie... | 523997af76fa2c40ffdee20a85c646f17c5b2580 | diff --git a/cypress/e2e/events.js b/cypress/e2e/events.js
index 5ab0538bd976b..7bec446bfd0ff 100644
--- a/cypress/e2e/events.js
+++ b/cypress/e2e/events.js
@@ -90,6 +90,15 @@ describe('Events', () => {
cy.get('.operator-value-option').contains('> greater than').should('be.visible')
})
+ it('adds and... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
PostHog__posthog-8414@9bb9025 | PostHog/posthog | Python | 8,414 | Fetch person property values via Clickhouse | ## Changes
- Resolves https://github.com/PostHog/posthog/issues/8364
- Moves person property values autocomplete from postgres to clickhouse
- Looks over only 100k persons (ordered by UUID desc... so either 100k at random or last users, not sure), instead of always looking through all persons like before
- Little... | 2022-02-03T09:35:47Z | PostgreSQL - `properties` query is constantly timing out
## Bug description
The query is semi-constantly failing on cloud as it's taking more than the threshold to execute
```
SELECT ("posthog_person"."properties" -> 'utm_campaign'), COUNT("posthog_person"."id") AS "count" FROM "posthog_person" WHERE ("posthog_per... | cc @alexkim205 @mariusandra @EDsCODE for prioritization. I think this query is triggered from various analytics filters for autocomplete, has to do with data taxonomy
Thanks for the context here, it looks like this query traces back to the `PersonViewSet` GET method here: https://github.com/PostHog/posthog/blob/7d84ac... | [
{
"body": "## Bug description\r\n\r\nThe query is semi-constantly failing on cloud as it's taking more than the threshold to execute\r\n```\r\nSELECT (\"posthog_person\".\"properties\" -> 'utm_campaign'), COUNT(\"posthog_person\".\"id\") AS \"count\" FROM \"posthog_person\" WHERE (\"posthog_person\".\"team_id\"... | f1a37b9fb1dc69837dd8f573ec429bb03b31fb34 | {
"head_commit": "9bb9025a90aa8312fdcc6700cd90ab3b2b6ca25e",
"head_commit_message": "no point making it too flat now",
"patch_to_review": "diff --git a/ee/clickhouse/models/property.py b/ee/clickhouse/models/property.py\nindex 5804e02de05d4..06a3627aea1c8 100644\n--- a/ee/clickhouse/models/property.py\n+++ b/ee/c... | [
{
"diff_hunk": "@@ -320,17 +324,20 @@ def calculate_path_persons(self, request: request.Request) -> Dict[str, Tuple[li\n \n @action(methods=[\"GET\"], detail=False)\n def values(self, request: request.Request, **kwargs) -> response.Response:\n- people = self.get_queryset()\n- key = \"prope... | c26b81162837194e1caa083c9fa0c94d5899e473 | diff --git a/ee/clickhouse/models/property.py b/ee/clickhouse/models/property.py
index 5804e02de05d4..06a3627aea1c8 100644
--- a/ee/clickhouse/models/property.py
+++ b/ee/clickhouse/models/property.py
@@ -29,6 +29,8 @@
GET_DISTINCT_IDS_BY_PERSON_ID_FILTER,
GET_DISTINCT_IDS_BY_PROPERTY_SQL,
GET_TEAM_PERSO... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Performance Optimizations"
} |
PostHog__posthog-8520@10f96d1 | PostHog/posthog | Python | 8,520 | fix optimize table timeout on 0002 | ## Changes
closes https://github.com/PostHog/posthog/issues/8511
OPTIMIZE TABLE times out for larger customers.
## How did you test this code?
<!-- If the answer is manually, please include a quick step-by-step on how to test this PR. -->
*Please describe.*
| 2022-02-09T13:09:12Z | Async events migration to handle large events volumes: timeout error
We timed out on a self-hosted instance with 45G of events, that's not the biggest.
The timeout should be configurable from the UI probably.
Ideally we'll want to test to the size of the largest users. | [
{
"body": "We timed out on a self-hosted instance with 45G of events, that's not the biggest. \r\nThe timeout should be configurable from the UI probably.\r\nIdeally we'll want to test to the size of the largest users.",
"number": 8511,
"title": "Async events migration to handle large events volumes: ti... | 2fc73065712b29a3e4f512c255bdba17afd58b65 | {
"head_commit": "10f96d14cad9eecff96b4c40475a642dd72cc8ab",
"head_commit_message": "refactor",
"patch_to_review": "diff --git a/posthog/async_migrations/definition.py b/posthog/async_migrations/definition.py\nindex d78782bae57b8..d1dd86d5431a6 100644\n--- a/posthog/async_migrations/definition.py\n+++ b/posthog/a... | [
{
"diff_hunk": "@@ -60,7 +62,12 @@ def simple_op(\n )\n \n @classmethod\n- def get_db_op(cls, sql: str, database: AnalyticsDBMS = AnalyticsDBMS.CLICKHOUSE, timeout_seconds: int = 60):\n+ def get_db_op(\n+ cls,\n+ sql: str,\n+ database: AnalyticsDBMS = AnalyticsDBMS.CLICKHO... | a309e2e3ef66f3e9540e30af95d0bab52056d312 | diff --git a/posthog/async_migrations/definition.py b/posthog/async_migrations/definition.py
index f9cbbbfc729c5..c366bb34c1764 100644
--- a/posthog/async_migrations/definition.py
+++ b/posthog/async_migrations/definition.py
@@ -2,6 +2,7 @@
from typing import Any, Callable, List, Optional, Tuple
from posthog.consta... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
PostHog__posthog-8096@dc307f0 | PostHog/posthog | Python | 8,096 | Instance status configuration | ## Changes
- You can now configure your instance through PostHog's UI.
- Closes https://github.com/PostHog/charts-clickhouse/issues/114
<img width="1511" alt="" src="https://user-images.githubusercontent.com/5864173/153198218-d7eb1373-9ba2-4109-81ff-e68018b4aeb5.png">
**Nice confirmation screen before sav... | 2022-01-17T16:14:33Z | Email setup from the PostHog app
## Is your feature request related to a problem?
Currently in order to have email available for password reset etc it needs to be set in the values.
## Describe the solution you'd like
Ability to set the email config in the PostHog app.
## Describe alternatives you've consid... | @tiina303 can you add more info about this? Which secret are we trying to create?
@paolodamico has been working on this, not sure if there was an issue tracking it already?
@hazzadous I'm inclined to close this as part of https://github.com/PostHog/charts-clickhouse/pull/286. What do you think?
I think this is actuall... | [
{
"body": "## Is your feature request related to a problem?\r\n\r\nCurrently in order to have email available for password reset etc it needs to be set in the values.\r\n\r\n## Describe the solution you'd like\r\n\r\nAbility to set the email config in the PostHog app.\r\n\r\n## Describe alternatives you've cons... | 31807bbc874666adac730b0083aa83c2fa0585f3 | {
"head_commit": "dc307f0a209add15c661316cd2660f1461479033",
"head_commit_message": "post-merge fixes",
"patch_to_review": "diff --git a/cypress/integration/systemStatus.js b/cypress/integration/systemStatus.js\nindex 1cf440f2a696b..9a0c52d3b6f06 100644\n--- a/cypress/integration/systemStatus.js\n+++ b/cypress/in... | [
{
"diff_hunk": "@@ -238,6 +239,17 @@ function Pages(): JSX.Element {\n )}\n <PageButton icon={<IconTools />} identifier={Scene.ToolbarLaunch} to={urls.toolbarLaunch()} />\n <PageButton icon={<IconSettings />} identifier={Scene.ProjectSettings} to={urls.projectSettings()} />\n... | a22e8bf68d5cc736afb67b57327f857798a4dc67 | diff --git a/cypress/integration/systemStatus.js b/cypress/integration/systemStatus.js
index 1cf440f2a696b..3a0904206a7fa 100644
--- a/cypress/integration/systemStatus.js
+++ b/cypress/integration/systemStatus.js
@@ -6,7 +6,7 @@ describe('System Status', () => {
cy.wait(500)
cy.get('[data-attr=top-men... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
PostHog__posthog-9091@f342ce6 | PostHog/posthog | Python | 9,091 | feat(insights): Warn before leaving insight with unsaved changes | ## Problem
Closes #7121.
This is a [Quality Launch Week](https://github.com/PostHog/posthog/projects/15) problem.
## Changes
Now before you leave an insight with unsaved changes, you'll be prompted whether you're okay with those being discarded.
If you confirm, the changes will be gone forever, but if you pr... | 2022-03-17T18:11:39Z | Warn when leaving an insight with unsaved state
## Is your feature request related to a problem?
Currently when you edit an insight, it's possible to leave the page in the middle of editing e.g. an insight name. All changes are thereupon lost.
Given user needs to manually "confirm" every change for titles, this c... | [
{
"body": "## Is your feature request related to a problem?\r\n\r\nCurrently when you edit an insight, it's possible to leave the page in the middle of editing e.g. an insight name. All changes are thereupon lost.\r\n\r\nGiven user needs to manually \"confirm\" every change for titles, this can lead to annoying... | 78bc48cf94497b5c9a62aa3f2fba5e324e1187c8 | {
"head_commit": "f342ce689773e1662bc94b8edf05953c672c43a8",
"head_commit_message": "Handle insight ID changes and auto-discard",
"patch_to_review": "diff --git a/frontend/src/lib/components/PropertyGroupFilters/PropertyGroupFilters.tsx b/frontend/src/lib/components/PropertyGroupFilters/PropertyGroupFilters.tsx\n... | [
{
"diff_hunk": "@@ -130,6 +132,20 @@ export const insightSceneLogic = kea<insightSceneLogicType>({\n const insightId = String(shortId) as InsightShortId\n const oldInsightId = values.insightId\n if (insightId !== oldInsightId || insightMode !== values.insightMode) {\n+ ... | 5ec201ad6a307fc47da4e2ba58dc48d685fe5139 | diff --git a/cypress/integration/insights.js b/cypress/integration/insights.js
index 6c9a19c271ef1..ec77534463cf5 100644
--- a/cypress/integration/insights.js
+++ b/cypress/integration/insights.js
@@ -20,7 +20,6 @@ describe('Insights', () => {
cy.get('[data-attr=prop-val-0]').click({ force: true })
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
PostHog__posthog-7569@db32271 | PostHog/posthog | Python | 7,569 | [cohort] insight cohorts | ## Changes
*Please describe.*
- adds backend for creating cohorts based on all insights
*If this affects the frontend, include screenshots.*
## How did you test this code?
<!-- If the answer is manually, please include a quick step-by-step on how to test this PR. -->
*Please describe.*
- [ ] add back... | 2021-12-07T23:34:15Z | Create static cohorts
## Is your feature request related to a problem?
I want to be able to easily create cohorts from the list of users I got from doing a query.
## Describe the solution you'd like
Everywhere we can currently click on charts to see a list of users should have an option to create a static coho... | Additional [revelant context](https://posthog.slack.com/archives/C0113360FFV/p1608291956004600). We tried doing this by using an API and some automation to create a cohort with 100+ match groups where each match group represented the exact match to the email address of the users we needed. This caused CH to crash.
T... | [
{
"body": "## Is your feature request related to a problem?\r\n\r\nI want to be able to easily create cohorts from the list of users I got from doing a query.\r\n\r\n## Describe the solution you'd like\r\n\r\nEverywhere we can currently click on charts to see a list of users should have an option to create a st... | 6017a39d7e8a4b66b459c3f8206ba58f197ae87a | {
"head_commit": "db3227153817bdc72462508f87b8f0ccee48940d",
"head_commit_message": "add simplify",
"patch_to_review": "diff --git a/ee/clickhouse/queries/actor_base_query.py b/ee/clickhouse/queries/actor_base_query.py\nindex dd6026996e3c5..0f216810aa003 100644\n--- a/ee/clickhouse/queries/actor_base_query.py\n++... | [
{
"diff_hunk": "@@ -52,17 +52,17 @@ def insert_cohort_actors_into_ch(cohort: Cohort, filter_data: Dict):\n insight_type = filter_data.get(\"insight\")\n \n if insight_type == INSIGHT_TRENDS:\n- filter = Filter(data=filter_data)\n+ filter = Filter(data=filter_data).simplify(team=cohort.team... | 0690aa3a56468aea8b1b06a57232500408f8af1d | diff --git a/ee/clickhouse/queries/actor_base_query.py b/ee/clickhouse/queries/actor_base_query.py
index dd6026996e3c5..0f216810aa003 100644
--- a/ee/clickhouse/queries/actor_base_query.py
+++ b/ee/clickhouse/queries/actor_base_query.py
@@ -48,13 +48,17 @@ class ActorBaseQuery:
entity: Optional[Entity] = None
... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
PostHog__posthog-7258@f89ec86 | PostHog/posthog | Python | 7,258 | Exclude action events from correlation results | ## Changes
Fixes https://github.com/PostHog/posthog/issues/7164
## How did you test this code?
Unit test
| 2021-11-22T13:31:43Z | Exclude underlying events from correlation with actions
## Bug description
When running a Correlation Analysis using actions, you always (or almost always) see the underlying events that comprise the action(s) with large correlation likelihoods. This is obviously pretty useless as we're using the same event to say t... | [
{
"body": "## Bug description\r\n\r\nWhen running a Correlation Analysis using actions, you always (or almost always) see the underlying events that comprise the action(s) with large correlation likelihoods. This is obviously pretty useless as we're using the same event to say there's a high correlation likelih... | 3fd53907387d290d98935580e08d34e1eb3a8007 | {
"head_commit": "f89ec86a1a2e994fef8986649da04a6f91652471",
"head_commit_message": "update snapshots",
"patch_to_review": "diff --git a/ee/clickhouse/queries/funnels/funnel_correlation.py b/ee/clickhouse/queries/funnels/funnel_correlation.py\nindex fccb5c8c842b8..df794c2855f87 100644\n--- a/ee/clickhouse/queries... | [
{
"diff_hunk": "@@ -160,6 +171,104 @@ def test_basic_funnel_correlation_with_events(self):\n self.assertEqual(len(self._get_people_for_event(filter, \"negatively_related\", success=False)), 5)\n self.assertEqual(len(self._get_people_for_event(filter, \"negatively_related\")), 0)\n \n+ @snapsh... | 48eebabf8a077b29b7e694fe05cf8f2901ac38cf | diff --git a/ee/clickhouse/queries/funnels/funnel_correlation.py b/ee/clickhouse/queries/funnels/funnel_correlation.py
index fccb5c8c842b8..df794c2855f87 100644
--- a/ee/clickhouse/queries/funnels/funnel_correlation.py
+++ b/ee/clickhouse/queries/funnels/funnel_correlation.py
@@ -25,7 +25,12 @@
from ee.clickhouse.quer... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
PostHog__posthog-6447@1e6f4eb | PostHog/posthog | Python | 6,447 | Dashboard item: Only pass object id when deleting dashboard item | ## Changes
*Please describe.*
- Dashboard item deletes were passing an entire payload back to api which caused stringifying issues if the dashboard item was a path based viz. Example: can't delete the paths item from [this dashboard](https://app.posthog.com/dashboard/16413)
- This reduces the parameters passed a... | 2021-10-14T18:29:07Z | Dashboard Items: Path dashboard items can't be deleted
## Bug description
*Please describe.*
If you add a path viz to a dashboard and try deleting, it won't delete
## Expected behavior
Item should be deletable
## How to reproduce
1. Add a path viz to dashboards
2. Try deleting
## Environment
- ... | [
{
"body": "## Bug description\r\n\r\n*Please describe.* \r\nIf you add a path viz to a dashboard and try deleting, it won't delete\r\n\r\n## Expected behavior\r\nItem should be deletable\r\n\r\n\r\n## How to reproduce\r\n\r\n1. Add a path viz to dashboards\r\n2. Try deleting\r\n\r\n## Environment\r\n\r\n- [ ] ... | 0f72528a418c99d612307e17f4aff9642f640750 | {
"head_commit": "1e6f4eb58e60969ab35e137e7df30fcadd525a31",
"head_commit_message": "add tests that validate loadResults exists on insight logics for dashboard item refresh",
"patch_to_review": "diff --git a/frontend/src/scenes/dashboard/DashboardItem.tsx b/frontend/src/scenes/dashboard/DashboardItem.tsx\nindex e... | [
{
"diff_hunk": "@@ -565,7 +565,9 @@ export function DashboardItem({\n data-attr={'dashboard-item-' + index + '-dropdown-delete'}\n onClick={() =>\n dele... | d624000717184ca6f42451d9952dd52f9a067319 | diff --git a/frontend/src/scenes/dashboard/DashboardItem.tsx b/frontend/src/scenes/dashboard/DashboardItem.tsx
index e87081ab16fa1..4a5f098b08922 100644
--- a/frontend/src/scenes/dashboard/DashboardItem.tsx
+++ b/frontend/src/scenes/dashboard/DashboardItem.tsx
@@ -565,7 +565,10 @@ export function DashboardItem({
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
PostHog__posthog-5849@28973d7 | PostHog/posthog | Python | 5,849 | Add helm info to instance status page | ## Changes
Closes https://github.com/PostHog/charts-clickhouse/issues/97
if helm info env doesn't exist nothing changes.
if the env exists we see this:
<img width="1242" alt="Screen Shot 2021-09-08 at 18 18 13" src="https://user-images.githubusercontent.com/890921/132547241-427333e1-90c9-4583-b9a2-687e8b9f... | 2021-09-08T02:45:40Z | Add chart version to instance status page
## Is your feature request related to a problem?
Having the chart version there in addition to other metrics can help us detect faster that someone's using old version.
## Describe the solution you'd like
instance/status page has chart version too
## Describe alter... | [
{
"body": "## Is your feature request related to a problem?\r\n\r\nHaving the chart version there in addition to other metrics can help us detect faster that someone's using old version. \r\n\r\n## Describe the solution you'd like\r\n\r\ninstance/status page has chart version too\r\n\r\n## Describe alternatives... | bdb8f50738bb36557425ee849b2c0fa30f50e20d | {
"head_commit": "28973d746dab438161c673e0ea6a2609198f4433",
"head_commit_message": "Use helm install info instead",
"patch_to_review": "diff --git a/posthog/api/instance_status.py b/posthog/api/instance_status.py\nindex f47b7b11c0f8b..d8a221e09dcd8 100644\n--- a/posthog/api/instance_status.py\n+++ b/posthog/api/... | [
{
"diff_hunk": "@@ -44,6 +46,17 @@ def list(self, request: Request) -> Response:\n \n metrics.append({\"key\": \"posthog_git_sha\", \"metric\": \"PostHog Git SHA\", \"value\": GIT_SHA})\n \n+ helm_info = json.loads(os.getenv(\"HELM_INSTALL_INFO\", \"{}\"))",
"line": null,
"original_line":... | ab23842d04bd3b224b35eee5e3d4843e1a4129b9 | diff --git a/posthog/api/instance_status.py b/posthog/api/instance_status.py
index f47b7b11c0f8b..f125f13d87b63 100644
--- a/posthog/api/instance_status.py
+++ b/posthog/api/instance_status.py
@@ -1,3 +1,5 @@
+import json
+import os
from typing import Any, Dict, List, Union
from django.db import connection
@@ -14,6... | {
"difficulty": "medium",
"estimated_review_effort": 2,
"problem_domain": "New Feature Additions"
} | |
PostHog__posthog-5430@3477b6a | PostHog/posthog | Python | 5,430 | Allow "new member" email opt-out | ## Changes
Resolves #5359 by adding opt-out for the "new member" email.
## Checklist
- [x] Django backend tests
- [ ] Jest frontend tests
- [ ] Cypress end-to-end tests
- [x] ... | 2021-08-03T17:32:48Z | Allow for "x user has joined your organization" emails to be disabled
## Is your feature request related to a problem?
*Please describe.*
Users are asking to turn them off because there is quite a few hitting their inbox - they'd rather turn these off than filter them in their inbox.
## Describe the solution y... | [
{
"body": "## Is your feature request related to a problem?\r\n\r\n*Please describe.*\r\n\r\nUsers are asking to turn them off because there is quite a few hitting their inbox - they'd rather turn these off than filter them in their inbox.\r\n\r\n## Describe the solution you'd like\r\n\r\n\r\n## Describe altern... | 5e0fe1247192e9e0be6584382854890849d90eae | {
"head_commit": "3477b6a1679c140a700c86b3bcea363f88f93197",
"head_commit_message": "Improve wording",
"patch_to_review": "diff --git a/frontend/src/scenes/organization/Settings/index.tsx b/frontend/src/scenes/organization/Settings/index.tsx\nindex 89c490bad0f1d..0c594cd2da766 100644\n--- a/frontend/src/scenes/or... | [
{
"diff_hunk": "@@ -103,6 +103,39 @@ function DomainWhitelist({ isRestricted }: RestrictedComponentProps): JSX.Elemen\n )\n }\n \n+function EmailPreferences({ isRestricted }: RestrictedComponentProps): JSX.Element {\n+ const { currentOrganization, currentOrganizationLoading } = useValues(organizationLogi... | bbdf61789750d96264006f4fb67a55a7ad16a119 | diff --git a/ee/api/test/test_organization.py b/ee/api/test/test_organization.py
index 8995e3d44d37a..d666558ecb750 100644
--- a/ee/api/test/test_organization.py
+++ b/ee/api/test/test_organization.py
@@ -93,38 +93,46 @@ def test_no_delete_organization_not_belonging_to(self):
self.assertEqual(response.stat... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
PostHog__posthog-5654@c5469ad | PostHog/posthog | Python | 5,654 | Support `href`/`text` element filters | ## Changes
Resolves #5598.
## Checklist
- [x] All querysets/queries filter by Organization, by Team, and by User
- [x] Django backend tests | 2021-08-19T11:34:24Z | Filtering element `href` by regex does not work
Trying to add an href filter containing URL path (/admin/sites/*/courses/42400-example-course), but it’s returning 0 results, when I use a wildcard (% or *), but when I search a specific path (/admin/sites/56306/courses/42400-example-course), it returns results. What am I... | Can you add a screenshot of the specific filter? Are you using `equals` or `matches regex` or something else?
In this case you want regexes - see an example in the image below.
![Screen Shot 2021-08-17 ... | [
{
"body": "Trying to add an href filter containing URL path (/admin/sites/*/courses/42400-example-course), but it’s returning 0 results, when I use a wildcard (% or *), but when I search a specific path (/admin/sites/56306/courses/42400-example-course), it returns results. What am I doing wrong?",
"number":... | 8b0b4bdf0f3eea618684c58cde8c17541079939c | {
"head_commit": "c5469ad32e850924a58395a3bbbb8ec71db639b2",
"head_commit_message": "Fix `icontains` and support `href/`text` element filters",
"patch_to_review": "diff --git a/ee/clickhouse/models/action.py b/ee/clickhouse/models/action.py\nindex 33a7eb71c8dd3..5076f910a5206 100644\n--- a/ee/clickhouse/models/ac... | [
{
"diff_hunk": "@@ -225,50 +227,60 @@ def get_property_values_for_key(key: str, team: Team, value: Optional[str] = Non\n )\n \n \n-def filter_element(filters: Dict, prepend: str = \"\") -> Tuple[str, Dict]:\n+def filter_element(filters: Dict, *, operator: Optional[OperatorType] = None, prepend: str = \"\") ... | 8610026a1f858c030fe9350e88a85ca158081c5b | diff --git a/ee/clickhouse/models/action.py b/ee/clickhouse/models/action.py
index 33a7eb71c8dd3..5076f910a5206 100644
--- a/ee/clickhouse/models/action.py
+++ b/ee/clickhouse/models/action.py
@@ -25,7 +25,7 @@ def format_action_filter(
if step.event == AUTOCAPTURE_EVENT:
from ee.clickhouse.models... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
PostHog__posthog-5150@6d95518 | PostHog/posthog | Python | 5,150 | Allow Excluding Multiple Events + events in unordered funnels | ~~Don't merge until SQL injection issue is resolved~~
~~To go after #5104 ~~
Fixes #5074
## Changes
Event exclusion in unordered events
Support for multiple exclusions in the same step in ordered + unordered funnels
## Checklist
- [ ] All querysets/queries filter by Organization, by Team, and by U... | 2021-07-15T11:26:28Z | Excluding Events in Funnels
## Is your feature request related to a problem?
Say you have a funnel: Sign Up -> Discover Learning. And you're interested in a specific kind of user: one that, say, didn't invite teammates to the project.
It's hard to represent this using segmentation / breakdowns, since the users yo... | Note that this is not a funnel-specific abstraction/search thing but rather a general analytics filtering capability, often associated with a time window.
He@p has this functionality:
Related issue: ht... | [
{
"body": "## Is your feature request related to a problem?\r\n\r\nSay you have a funnel: Sign Up -> Discover Learning. And you're interested in a specific kind of user: one that, say, didn't invite teammates to the project.\r\n\r\nIt's hard to represent this using segmentation / breakdowns, since the users you... | 8a1bd1c80e9313792fa9fb3576ca9581995dc744 | {
"head_commit": "6d95518b3f32c68ecff079a3b517a0539cb17566",
"head_commit_message": "rm extra imports",
"patch_to_review": "diff --git a/ee/clickhouse/queries/funnels/base.py b/ee/clickhouse/queries/funnels/base.py\nindex e85bd86c6e2a4..5dd80fb0d0000 100644\n--- a/ee/clickhouse/queries/funnels/base.py\n+++ b/ee/c... | [
{
"diff_hunk": "@@ -137,7 +137,7 @@ def test_funnel_exclusions_full_window(self):\n \"funnel_window_days\": 14,\n \"date_from\": \"2021-05-01 00:00:00\",\n \"date_to\": \"2021-05-14 00:00:00\",\n- \"exclusions\": [{\"id\": \"x\", \"type\": \"events\", \"funnel_from... | ab33743334d89ae41fbf3d21bae89fb1ae4412f5 | diff --git a/ee/clickhouse/queries/funnels/base.py b/ee/clickhouse/queries/funnels/base.py
index e85bd86c6e2a4..5dd80fb0d0000 100644
--- a/ee/clickhouse/queries/funnels/base.py
+++ b/ee/clickhouse/queries/funnels/base.py
@@ -128,9 +128,9 @@ def _get_partition_cols(self, level_index: int, max_steps: int):
c... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
PostHog__posthog-6027@031149c | PostHog/posthog | Python | 6,027 | Project-based permissioning `TopNavigation` | ## Changes
This adjusts `TopNavigation` UI for https://github.com/PostHog/posthog/pull/5976 like this:
### Project switcher with an allowed project and a restricted project (restricted only if project-based permissioning is available and enabled)
<img width="262" alt="Screen Shot 2021-09-10 at 14 45 40" src="htt... | 2021-09-20T09:44:09Z | Project-based permissioning
## Is your feature request related to a problem?
A recent focus customer has asked for some granular permissions related to projects. The basic use case is track multiple different properties (websites/apps) under the same account (organization), so each property would be under its own pr... | That's definitely possible and I was thinking about it when implementing organizations, but obviously more complexity involved. Would probably be best as an intermediary many-to-many `ProjectMembership` (for future per-project access levels) model. Probably worth taking a look at what Sentry have done in this area.
Rel... | [
{
"body": "## Is your feature request related to a problem?\r\n\r\nA recent focus customer has asked for some granular permissions related to projects. The basic use case is track multiple different properties (websites/apps) under the same account (organization), so each property would be under its own project... | 9cbece70fdbafeefc948e9344797581ea4af6ca1 | {
"head_commit": "031149c60029dfec5438a766a56c0d997facdf62",
"head_commit_message": "Delete 0169_project_based_permissioning.py",
"patch_to_review": "diff --git a/frontend/src/layout/__stories__/Navigation.stories.tsx b/frontend/src/layout/__stories__/Navigation.stories.tsx\nnew file mode 100644\nindex 0000000000... | [
{
"diff_hunk": "@@ -51,6 +54,53 @@ export function WhoAmI({ user }: { user: UserType }): JSX.Element {\n )\n }\n \n+function ProjectRow({ team }: { team: TeamBasicType }): JSX.Element {\n+ const { currentTeam } = useValues(teamLogic)\n+ const { updateCurrentTeam } = useActions(userLogic)\n+ const {... | 7635a8f9cacef546ce89512700c4aa92df77e075 | diff --git a/.prettierignore b/.prettierignore
new file mode 100644
index 0000000000000..a021cbe9f1561
--- /dev/null
+++ b/.prettierignore
@@ -0,0 +1,15 @@
+venv
+env
+.venv
+__pycache__/
+staticfiles
+.env
+*.code-workspace
+frontend/.cache/
+.mypy_cache
+frontend/dist/
+*Type.ts
+.idea
+.yalc
+.python-version
+storyb... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
PostHog__posthog-5031@396cd8e | PostHog/posthog | Python | 5,031 | Mix and Match ordering and visualization of funnels | ## Changes
Resolves #4988
More details inline. This PR sets up `get_step_counts_without_aggregation_query` as one step "below" `get_step_counts_query` such that everything which needs these values can use them as they see fit.
## Checklist
- [ ] All querysets/queries filter by Organization, by Team, and by... | 2021-07-07T15:08:51Z | Allow mixing and matching funnel ordering and funnel viz types
## Is your feature request related to a problem?
We now possess the ability to run ordered OR unordered funnel analyses.
We can also run queries that return conversion rates for all steps, conversion rates over time, or conversion times bucketed.
_Howe... | One question: Why do you think the unordered one builds on top of the **ordered** one? (assuming that was a typo?). Every funnel building on top of the base query makes sense to me?
Well, the issue is that the base query IS the ordered query. So when dependent queries get subquery `steps_per_person_query` from the base... | [
{
"body": "## Is your feature request related to a problem?\r\n\r\nWe now possess the ability to run ordered OR unordered funnel analyses.\r\nWe can also run queries that return conversion rates for all steps, conversion rates over time, or conversion times bucketed.\r\n_However_ unordered analysis can only be ... | d12b09f89e125d7970122a391c2ba7f4bf502956 | {
"head_commit": "396cd8e45b0d243c793466814ba2c9a5f330e682",
"head_commit_message": "cleanup",
"patch_to_review": "diff --git a/ee/clickhouse/queries/funnels/__init__.py b/ee/clickhouse/queries/funnels/__init__.py\nindex 35c0785d46bbf..fc298ee9d2fe7 100644\n--- a/ee/clickhouse/queries/funnels/__init__.py\n+++ b/e... | [
{
"diff_hunk": "@@ -78,9 +109,86 @@ def test_funnel_trends_basic_post(self):\n \"date_from\": \"2021-05-01 00:00:00\",\n \"date_to\": \"2021-05-07 23:59:59\",\n \"funnel_viz_type\": \"trends\",\n+ \"funnel_order_type\": \"ordered\",",
"line": nu... | d1f45aa2bbddd64901dd52371268521e66fb1ccf | diff --git a/ee/clickhouse/queries/funnels/__init__.py b/ee/clickhouse/queries/funnels/__init__.py
index fa172aa4a3ffa..aaa34917d20f7 100644
--- a/ee/clickhouse/queries/funnels/__init__.py
+++ b/ee/clickhouse/queries/funnels/__init__.py
@@ -1,3 +1,4 @@
+from .base import ClickhouseFunnelBase
from .funnel import Clickh... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
PostHog__posthog-4074@86a78a8 | PostHog/posthog | Python | 4,074 | Fix sessions indefinite loading users bug | ## Changes
Closes #3985
Going to **insights -> sessions -> graph data point** would load indefinitely
The API call was expecting entity values which weren't being set properly in the trends logic
https://user-images.githubusercontent.com/25164963/115620384-1637a500-a2c3-11eb-9dda-2aa645deb77d.mov
## Check... | 2021-04-21T21:04:47Z | Clicking on session datapoint doesn't return people
## Bug description
*Please describe.*
- For sessions in insights, clicking on a datapoint doesn't return people
*If this affects the front-end, screenshots would be of great help.*
## Expected behavior
- the modal should return people
## How to rep... | [
{
"body": "## Bug description\r\n\r\n*Please describe.* \r\n- For sessions in insights, clicking on a datapoint doesn't return people\r\n*If this affects the front-end, screenshots would be of great help.* \r\n\r\n## Expected behavior\r\n- the modal should return people\r\n\r\n\r\n\r\n## How to reproduce\r\n\... | 3db515dcaee82a75f99dfe5813baf67dd9ebf16c | {
"head_commit": "86a78a83d4f589f3f76f4d2b401598c5563bc4a3",
"head_commit_message": "fix sessions loading users bug",
"patch_to_review": "diff --git a/frontend/src/scenes/trends/trendsLogic.ts b/frontend/src/scenes/trends/trendsLogic.ts\nindex d31c38c478ac3..e89a84aaf9c99 100644\n--- a/frontend/src/scenes/trends/... | [
{
"diff_hunk": "@@ -100,8 +100,8 @@ function parsePeopleParams(peopleParams: PeopleParamType, filters: Partial<Filte\n const { action, date_from, date_to, breakdown_value, ...restParams } = peopleParams\n const params = filterClientSideParams({\n ...filters,\n- entity_id: action.id,\n- ... | 14a898e141d3ceca726cbb7430e72bb3d50a1448 | diff --git a/frontend/src/scenes/trends/trendsLogic.ts b/frontend/src/scenes/trends/trendsLogic.ts
index d31c38c478ac3..df02d44604a89 100644
--- a/frontend/src/scenes/trends/trendsLogic.ts
+++ b/frontend/src/scenes/trends/trendsLogic.ts
@@ -100,8 +100,8 @@ function parsePeopleParams(peopleParams: PeopleParamType, filte... | {
"difficulty": "medium",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} | |
PostHog__posthog-4883@6721e0e | PostHog/posthog | Python | 4,883 | Funnel persons per step and dropoff | ## Changes
*Please describe.*
- pointed at #4851
- add ability to get persons by specific dropoff or step
- the api will accept a `funnel_step` parameter that specifies the step at which you want the list of persons. Indexing starts at 1 so 1 = first step, 2 = second step, etc. The dropoffs are denoted by neg... | 2021-06-25T18:52:20Z | Funnels - API for getting persons on a step or drop-off
Issue to document the task of creating the API that will retrieve the person list at each step or drop-off in a funnel.
@buwilliams feel free to take over this issue. | Full product specs can be found [here](https://docs.google.com/document/d/1S7fwha7cph-79YaPADfFKHILCnPmBgk4rqaMu-gPZ3g/edit#heading=h.w1yaw9nwtpu), but an important consideration is that we clearly show in the interface whether a session recording is available for each specific person. I'm thinking this information mig... | [
{
"body": "Issue to document the task of creating the API that will retrieve the person list at each step or drop-off in a funnel.\r\n\r\n@buwilliams feel free to take over this issue.",
"number": 4818,
"title": "Funnels - API for getting persons on a step or drop-off"
}
] | ebea9abad4890724c5acf7e754aa352efc3cb48e | {
"head_commit": "6721e0eba50201cda5f0bd58c5c2524746e16996",
"head_commit_message": "fix tests",
"patch_to_review": "diff --git a/ee/clickhouse/queries/funnels/base.py b/ee/clickhouse/queries/funnels/base.py\nindex 3202fba9c8d03..56cebd697c1e3 100644\n--- a/ee/clickhouse/queries/funnels/base.py\n+++ b/ee/clickhou... | [
{
"diff_hunk": "@@ -55,6 +55,16 @@\n ;\n \"\"\"\n \n+FUNNEL_PERSONS_BY_STEP_SQL = \"\"\"\n+SELECT person_id\n+FROM\n+({steps_per_person_query})\n+WHERE {persons_steps}\n+LIMIT 100",
"line": 64,
"original_line": 63,
"original_start_line": null,
"path": "ee/clickhouse/sql/funnels/funnel.py",
"... | 3508c7fc1d2396c3409fd93c6060acdbf6370fe8 | diff --git a/ee/clickhouse/queries/funnels/base.py b/ee/clickhouse/queries/funnels/base.py
index 85d0f1bb39dab..9a7c023e28736 100644
--- a/ee/clickhouse/queries/funnels/base.py
+++ b/ee/clickhouse/queries/funnels/base.py
@@ -12,7 +12,7 @@
from ee.clickhouse.sql.person import GET_LATEST_PERSON_DISTINCT_ID_SQL
from pos... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
PostHog__posthog-3162@40d2213 | PostHog/posthog | Python | 3,162 | Do not open people modal on retention panel in dashboard | ## Changes
*Please describe.*
*If this affects the frontend, include screenshots.*
Closes #3132
When I opened the issue I was in the middle of a demo so couldn't do the immediate fix.
Here it is now.
## Checklist
- [ ] All querysets/queries filter by Organization, by Team, and by User
- [ ] Django backend tes... | 2021-02-02T16:22:14Z | Hide PII in Shared Dashboards
## Is your feature request related to a problem?
*Please describe.*
When I share a dashboard clicking on a data point gives me the list of users just like in-app. Problem is, if I'm sharing this outside of PostHog, I most likely want to display aggregate data without PII.
## Descr... | Seems like retention is the only one missing, other views already restrict this | [
{
"body": "## Is your feature request related to a problem?\r\n\r\n*Please describe.*\r\n\r\nWhen I share a dashboard clicking on a data point gives me the list of users just like in-app. Problem is, if I'm sharing this outside of PostHog, I most likely want to display aggregate data without PII.\r\n\r\n## Desc... | 0624471b4aa3c7461ab51aead3caa4c8ebae12b0 | {
"head_commit": "40d2213910af817429acb99d585690f8bca5be2b",
"head_commit_message": "Do not open people modal on retention panel in dashboard",
"patch_to_review": "diff --git a/frontend/src/scenes/retention/RetentionTable.tsx b/frontend/src/scenes/retention/RetentionTable.tsx\nindex 7a6f29710d857..1710a79bb2237 1... | [
{
"diff_hunk": "@@ -88,14 +88,14 @@ export function RetentionTable({\n size=\"small\"\n className=\"retention-table\"\n pagination={{ pageSize: 99999, hideOnSinglePage: true }}\n- rowClassName={'cursor-pointer'}\n+ rowClassName={!dash... | b30cf3ee096904ffbdde0fd6e0d1606829b16342 | diff --git a/frontend/src/scenes/retention/RetentionTable.tsx b/frontend/src/scenes/retention/RetentionTable.tsx
index 7a6f29710d857..6b4422c47c80a 100644
--- a/frontend/src/scenes/retention/RetentionTable.tsx
+++ b/frontend/src/scenes/retention/RetentionTable.tsx
@@ -88,14 +88,14 @@ export function RetentionTable({
... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "New Feature Additions"
} |
PostHog__posthog-4868@1372f68 | PostHog/posthog | Python | 4,868 | Funnel Unordered Steps | ## Changes
Fixes #4848
## Checklist
- [ ] All querysets/queries filter by Organization, by Team, and by User
- [ ] Django backend tests
- [ ] Jest frontend tests
- [ ] Cypress end-to-end tests
- [ ] Migrations are safe to run at scale (e.g. PostHog Cloud) – present proof if not obvious
- [ ] Frontend/CSS... | 2021-06-24T14:48:10Z | Funnel unordered steps
## Is your feature request related to a problem?
*Please describe.*
I want to be able to search for funnels as unordered steps meaning the X amount of steps should just occur within the conversion window
## Describe the solution you'd like
Same interface just allow me to specify the funne... | [
{
"body": "## Is your feature request related to a problem?\r\n\r\n*Please describe.*\r\nI want to be able to search for funnels as unordered steps meaning the X amount of steps should just occur within the conversion window\r\n\r\n## Describe the solution you'd like\r\nSame interface just allow me to specify t... | 628b431b6c6c204a3d935cf6ffb32eba54329e29 | {
"head_commit": "1372f68ae98de671a869c6a83092f21fc537a8e6",
"head_commit_message": "rm todo",
"patch_to_review": "diff --git a/ee/clickhouse/queries/funnels/base.py b/ee/clickhouse/queries/funnels/base.py\nindex 3202fba9c8d03..62648a8e96b3e 100644\n--- a/ee/clickhouse/queries/funnels/base.py\n+++ b/ee/clickhouse... | [
{
"diff_hunk": "@@ -6,7 +6,7 @@\n \n \n class FunnelEventQuery(ClickhouseEventQuery):\n- def get_query(self) -> Tuple[str, Dict[str, Any]]:\n+ def get_query(self, entities=[], entity_name=\"events\") -> Tuple[str, Dict[str, Any]]:",
"line": null,
"original_line": 9,
"original_start_line": null... | 1bfa011e2121fea0225f2363bffcd05b48dd34b6 | diff --git a/ee/clickhouse/queries/funnels/base.py b/ee/clickhouse/queries/funnels/base.py
index 2b29dda478537..1398c5a207638 100644
--- a/ee/clickhouse/queries/funnels/base.py
+++ b/ee/clickhouse/queries/funnels/base.py
@@ -10,7 +10,7 @@
from ee.clickhouse.queries.util import parse_timestamps
from ee.clickhouse.sql.... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
Subsets and Splits
Review Test Instances
Retrieves basic metadata about code review instances but doesn't provide any analytical insights or patterns beyond raw data access.