commit_hash stringlengths 40 40 | author stringlengths 1 57 | date timestamp[s]date 2010-07-26 04:45:09 2026-04-14 18:21:10 | message stringlengths 8 1.39M | diff stringlengths 68 51.2k | files_changed int64 1 136 | insertions int64 0 2.35k | deletions int64 0 1.9k |
|---|---|---|---|---|---|---|---|
cd015bf238be0c2c8851d2673d3039eab675ca28 | Glenn Watson | 2018-01-17T20:44:14 | servo: Merge #19780 - Update WR (persistent box-shadow render task cache) (from glennw:update-wr-cache); r=jdm
Source-Repo: https://github.com/servo/servo
Source-Revision: 8612a87ed28bbc4b9050e47b3bc4d49ea076a1cf | diff --git a/layout/display_list/webrender_helpers.rs b/layout/display_list/webrender_helpers.rs
index 4bd6d21c1..4d8afdf54 100644
--- a/layout/display_list/webrender_helpers.rs
+++ b/layout/display_list/webrender_helpers.rs
@@ -166,6 +166,7 @@ impl WebRenderDisplayItemConverter for DisplayItem {
... | 1 | 1 | 0 |
30d9549fa49ebe48633deab79984801ffff65a75 | Josh Matthews | 2018-01-17T16:57:06 | servo: Merge #19397 - Implement the create an element for token algorithm (from cbrewster:create_element_for_token); r=jdm,nox
<!-- Please describe your changes on the following line: -->
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with ... | diff --git a/script/dom/bindings/settings_stack.rs b/script/dom/bindings/settings_stack.rs
index b540b989b..f9438f170 100644
--- a/script/dom/bindings/settings_stack.rs
+++ b/script/dom/bindings/settings_stack.rs
@@ -35,6 +35,12 @@ pub unsafe fn trace(tracer: *mut JSTracer) {
})
}
+pub fn is_execution_stack_emp... | 6 | 165 | 44 |
dbc9c2f16edfe80fc02d994e81cb9b5ce17ddee0 | Emilio Cobos Álvarez | 2018-01-17T15:09:49 | servo: Merge #19791 - style: Cleanup a bit the calc code (from emilio:calc-clean); r=jdm
I happened to be looking at it.
Source-Repo: https://github.com/servo/servo
Source-Revision: 8a740aa4d1e75aad9308e3eb805ed3e15078fb59 | diff --git a/style/values/computed/length.rs b/style/values/computed/length.rs
index 7b3a92bbe..a0a92c713 100644
--- a/style/values/computed/length.rs
+++ b/style/values/computed/length.rs
@@ -92,15 +92,12 @@ impl CalcLengthOrPercentage {
/// Returns a new `CalcLengthOrPercentage` with a specific clamping mode.
... | 2 | 27 | 18 |
205e507c585e1794bd6bdbb1cfc9b1a7ec0c22f7 | Georg Streich | 2018-01-17T13:28:01 | servo: Merge #19755 - Decouple metrics and gfx (from streichgeorg:decoupling_metrics_gfx); r=jdm
Added gfx_traits::DisplayList so metrics doesn't depend on the gfx crate for gfx::display_list::DisplayList.
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and ... | diff --git a/gfx/display_list/mod.rs b/gfx/display_list/mod.rs
index c4c73e50d..fff0d658a 100644
--- a/gfx/display_list/mod.rs
+++ b/gfx/display_list/mod.rs
@@ -17,7 +17,7 @@
use app_units::Au;
use euclid::{Transform3D, Point2D, Vector2D, Rect, Size2D, TypedRect, SideOffsets2D};
use euclid::num::{One, Zero};
-use gf... | 5 | 28 | 22 |
233147584cd8521840ca3c7f86418b79bab6c9e8 | tigercosmos | 2018-01-17T10:30:58 | servo: Merge #19761 - implement range input sanitization (from tigercosmos:m1); r=KiChjang
<!-- Please describe your changes on the following line: -->
implement range input sanitation.
Since there is no `min`, `max`, `step` implementation currently, this should be continued in the future.
r? KiChjang
---
<!-- Thank... | diff --git a/script/dom/bindings/str.rs b/script/dom/bindings/str.rs
index eaabc2980..4520fd15a 100644
--- a/script/dom/bindings/str.rs
+++ b/script/dom/bindings/str.rs
@@ -286,31 +286,37 @@ impl DOMString {
/// YYYY must be four or more digits, MM and DD both must be two digits
/// https://html.spec.whatwg.o... | 2 | 41 | 14 |
547bf161f5e2801a1558876b5a11acf1b6aa552b | Xidorn Quan | 2018-01-16T22:47:29 | servo: Merge #19781 - Optimize selector matching for some common cases (from upsuper:matching-opt); r=emilio
This is the "better way" I mentioned in #19774, which seems to actually improve the score of dromaeo_css on talos.
Source-Repo: https://github.com/servo/servo
Source-Revision: 525758ea5ef67148c28acae9404916691... | diff --git a/selectors/matching.rs b/selectors/matching.rs
index 60699d9d6..b01f7371f 100644
--- a/selectors/matching.rs
+++ b/selectors/matching.rs
@@ -8,6 +8,7 @@ use nth_index_cache::NthIndexCacheInner;
use parser::{AncestorHashes, Combinator, Component, LocalName};
use parser::{Selector, SelectorImpl, SelectorIte... | 2 | 92 | 26 |
439c2acc16c42be686624baba958960e24269f50 | Emilio Cobos Álvarez | 2018-01-16T21:15:01 | servo: Merge #19787 - style: Make GeckoElement::has_class faster (from emilio:opt-has-class); r=bholley
By force-inlining the fast path, and pulling out a branch that rust didn't manage to pull out.
Source-Repo: https://github.com/servo/servo
Source-Revision: 1ac35dc7abd0b984838dfa4be581a319158190a5 | diff --git a/style/gecko/snapshot_helpers.rs b/style/gecko/snapshot_helpers.rs
index 51953a023..f1163d260 100644
--- a/style/gecko/snapshot_helpers.rs
+++ b/style/gecko/snapshot_helpers.rs
@@ -32,7 +32,14 @@ pub fn has_class<T>(
1 => case_sensitivity.eq_atom(name, WeakAtom::new(class)),
n => {... | 2 | 9 | 2 |
d82dfaade2c3435fa7feb6c71acef399c8e4551c | Emilio Cobos Álvarez | 2018-01-16T16:52:38 | servo: Merge #19785 - style: Don't allow fallback alignment in place-content shorthand (from emilio:place-content-fallback); r=xidorn,mats
Bug: 1430622
Reviewed-by: xidorn,mats
MozReview-Commit-ID: sALBFJeqvr
Source-Repo: https://github.com/servo/servo
Source-Revision: 6f53f4fb5ccf03c56cf8ebc684b16ac53ca771dd | diff --git a/style/properties/shorthand/position.mako.rs b/style/properties/shorthand/position.mako.rs
index 0ee37c1a9..1bddeeb8b 100644
--- a/style/properties/shorthand/position.mako.rs
+++ b/style/properties/shorthand/position.mako.rs
@@ -611,17 +611,19 @@
<%helpers:shorthand name="place-content" sub_properties="ali... | 2 | 57 | 28 |
124518e45a8b884209679ffa8296b6d7ee8057a8 | Emilio Cobos Álvarez | 2018-01-16T14:50:35 | servo: Merge #19783 - style: Update shadow dom preference (from jessi3py:bug-1428685); r=emilio
We have updated gecko's preference for shadow dom, so updating servo part too.
Source-Repo: https://github.com/servo/servo
Source-Revision: cafc152e1b536646b156a8e61b3c46183b5c9cc4 | diff --git a/style/gecko/generated/structs.rs b/style/gecko/generated/structs.rs
index 80239ae1d..ada62c704 100644
--- a/style/gecko/generated/structs.rs
+++ b/style/gecko/generated/structs.rs
@@ -1906,8 +1906,8 @@ pub type ServoStyleContextStrong = ::gecko_bindings::sugar::ownership::Strong<::
# [ link_name = "\u{1}... | 2 | 3 | 3 |
f57be00e5ecfa47b2a8208169027fdc37433e3d0 | Bobby Holley | 2018-01-16T01:24:59 | servo: Merge #19779 - Avoid debug serialization of PropertyDeclaration & co in release builds (from bholley:avoid_rule_debug_hooks); r=emilio
In total, this PR saves ~60k.
The conditional compilation on the _Debug FFI function eliminates one
of the ToCss variants, eliminating 54.4k, as well as a bunch of other
<1k fu... | diff --git a/style/font_metrics.rs b/style/font_metrics.rs
index 26be9a17c..e09de05fa 100644
--- a/style/font_metrics.rs
+++ b/style/font_metrics.rs
@@ -12,7 +12,6 @@ use context::SharedStyleContext;
use logical_geometry::WritingMode;
use media_queries::Device;
use properties::style_structs::Font;
-use std::fmt;
... | 1 | 1 | 2 |
f4d3ceec7f6d149f5c80154f8899ecbb96d3d9c9 | Igor Gutorov | 2018-01-15T12:04:30 | servo: Merge #19749 - style: Move -moz-context-properties outside of mako (from gootorov:move_-moz-context-properties_from_mako); r=emilio
<!-- Please describe your changes on the following line: -->
Sub-PR of #19015
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is com... | diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs
index 6ea1ec3e3..81f0af1f1 100644
--- a/style/properties/gecko.mako.rs
+++ b/style/properties/gecko.mako.rs
@@ -5255,16 +5255,16 @@ clip-path
self.gecko.mContextPropsBits = 0;
for (gecko, servo) in self.gecko.mContextProps.... | 6 | 34 | 26 |
5dfcc671d5fca5bc2b1e97fe1852ab25aa32e5fa | Emilio Cobos Álvarez | 2018-01-15T10:14:13 | servo: Merge #19769 - layout: Simplify the pseudo-element setup (from emilio:simplify-layout-construct); r=nox
It's kind of a mess. See individual commits for details.
Source-Repo: https://github.com/servo/servo
Source-Revision: 032fd388e4efdd9ecc682877d017b9d2f78e29e2 | diff --git a/layout/construct.rs b/layout/construct.rs
index f369d41da..79d72c847 100644
--- a/layout/construct.rs
+++ b/layout/construct.rs
@@ -109,7 +109,10 @@ pub enum ConstructionItem {
/// Inline fragments and associated {ib} splits that have not yet found flows.
InlineFragments(InlineFragmentsConstructi... | 7 | 73 | 97 |
e3a08ccab0560361e431ceb4ab7e353600d7a8f9 | Fernando Jiménez Moreno | 2018-01-15T09:20:57 | servo: Merge #19772 - Do not fire pending callbacks on disconnected performance observer (from ferjm:performance.wpt); r=nox
Implement this change in the Performance Timeline API https://github.com/w3c/performance-timeline/issues/66
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not ... | diff --git a/script/dom/performance.rs b/script/dom/performance.rs
index 3ff1d32b5..4a9a9672b 100644
--- a/script/dom/performance.rs
+++ b/script/dom/performance.rs
@@ -184,14 +184,6 @@ impl Performance {
None => return,
};
- if self.pending_notification_observers_task.get() {
- ... | 1 | 0 | 8 |
f19e7e5ef5eb16f2efa78d6db9059199d8ffe971 | Jon Leighton | 2018-01-14T22:55:15 | servo: Merge #19766 - Move image-orientation property outside of mako (from jonleighton:issue-19765); r=emilio
Fixes https://github.com/servo/servo/issues/19765
r? emilio
Source-Repo: https://github.com/servo/servo
Source-Revision: ec34023d7a1ba5d7cc882fbb66b880960ce79c43 | diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs
index e74c2f6fd..6ea1ec3e3 100644
--- a/style/properties/gecko.mako.rs
+++ b/style/properties/gecko.mako.rs
@@ -4609,7 +4609,8 @@ fn static_assert() {
pub fn clone_image_orientation(&self) -> longhands::image_orientation::computed_value... | 6 | 228 | 189 |
53b743b7afcd7d4601b125ad4ada1607108733dc | CYBAI | 2018-01-14T14:27:14 | servo: Merge #19709 - style: Remove -servo-display-for-hypothetical-box from longhand (from CYBAI:servo-display-out-of-mako); r=emilio
This is a sub-PR of #19015
r? emilio
For the `fn set_original_display` inside `properties.mako.rs`, I removed `is_item_or_root` first to see how the tests result is. If it's needed, I... | diff --git a/layout/construct.rs b/layout/construct.rs
index 8efeeb97e..f369d41da 100644
--- a/layout/construct.rs
+++ b/layout/construct.rs
@@ -1485,7 +1485,7 @@ impl<'a, ConcreteThreadSafeLayoutNode> PostorderNodeMutTraversal<ConcreteThreadS
}
Some(LayoutNodeType::Element(_)) => {
... | 5 | 64 | 56 |
2cfce8597421a91554cf21c05731e8491c646168 | Emilio Cobos Álvarez | 2018-01-13T19:16:06 | servo: Merge #19760 - style: Ruby style adjustments shouldn't reset mOriginalDisplay (from emilio:ruby-display-adjust); r=upsuper
This matches what Gecko does:
https://searchfox.org/mozilla-central/rev/7476b71e0010ab3277b77cc0ae4d998c4b1d2b64/layout/style/GeckoStyleContext.cpp#992
And it's conceptually more right,... | diff --git a/style/style_adjuster.rs b/style/style_adjuster.rs
index 1c859532d..c54191b14 100644
--- a/style/style_adjuster.rs
+++ b/style/style_adjuster.rs
@@ -479,7 +479,7 @@ impl<'a, 'b: 'a> StyleAdjuster<'a, 'b> {
if !flags.contains(CascadeFlags::SKIP_ROOT_AND_ITEM_BASED_DISPLAY_FIXUP) {
... | 1 | 1 | 1 |
e094679e7a24fe5f18a5cbfc309dd12bc8f9ef5a | Bobby Holley | 2018-01-13T17:52:15 | servo: Merge #19756 - Avoid entraining various Debug impls in release builds (from bholley:avoid_debug_impls_in_release); r=emilio
See https://bugzilla.mozilla.org/show_bug.cgi?id=1351737#c29
This patch saves more than 80k of code size.
Source-Repo: https://github.com/servo/servo
Source-Revision: 08fc9f190d7e1eaa115... | diff --git a/style/dom.rs b/style/dom.rs
index 57872062e..668f54e4b 100644
--- a/style/dom.rs
+++ b/style/dom.rs
@@ -746,18 +746,9 @@ pub trait TElement
/// element-backed pseudo-element, in which case we return the originating
/// element.
fn rule_hash_target(&self) -> Self {
- if let Some(pseudo... | 8 | 32 | 46 |
c031bee5c675343de9c40e59623013113789dc20 | Emilio Cobos Álvarez | 2018-01-13T12:00:45 | servo: Merge #19758 - style: Adjust the writing-mode fixup to call set_adjusted_display on Servo (from emilio:adjust-display-right); r=emilio
This is functionally equivalent right now (set_adjusted_display will just do
set_display), but won't be after #19709.
Source-Repo: https://github.com/servo/servo
Source-Revisio... | diff --git a/style/style_adjuster.rs b/style/style_adjuster.rs
index 4da9f0f92..1c859532d 100644
--- a/style/style_adjuster.rs
+++ b/style/style_adjuster.rs
@@ -193,7 +193,16 @@ impl<'a, 'b: 'a> StyleAdjuster<'a, 'b> {
if our_writing_mode != parent_writing_mode &&
self.style.get_box().clone_displ... | 1 | 10 | 1 |
2a55c9138adfe9e7f5f785c0376ffc547267494f | Simon Sapin | 2018-01-12T22:55:12 | servo: Merge #19751 - Clean up the selectors crate for a new crates.io release (from servo:selectors); r=bholley
Source-Repo: https://github.com/servo/servo
Source-Revision: 6ca651c0c8271ce185448e1db95b893a276eaed9 | diff --git a/malloc_size_of/Cargo.toml b/malloc_size_of/Cargo.toml
index a5c3acfb8..9b24d6dad 100644
--- a/malloc_size_of/Cargo.toml
+++ b/malloc_size_of/Cargo.toml
@@ -17,6 +17,7 @@ cssparser = "0.23.0"
euclid = "0.16"
hashglobe = { path = "../hashglobe" }
mozjs = { version = "0.1.8", features = ["promises"], optio... | 15 | 79 | 155 |
1e45ac28cc3b03055e2a113a86034a0db09e74d0 | Bobby Holley | 2018-01-12T18:22:10 | servo: Merge #19753 - NoteDirtyElement optimizations (from bholley:notedirtyelement_optimizations); r=emilio
https://bugzilla.mozilla.org/show_bug.cgi?id=1398119
Source-Repo: https://github.com/servo/servo
Source-Revision: 1a8366598afdbf4de31dcbaf0d9585f7a8a5e7b4 | diff --git a/style/gecko/generated/bindings.rs b/style/gecko/generated/bindings.rs
index 3e8276c88..eacccb5da 100644
--- a/style/gecko/generated/bindings.rs
+++ b/style/gecko/generated/bindings.rs
@@ -1597,4 +1597,8 @@ extern "C" {
pub fn Gecko_GetElementsWithId ( aDocument : * const nsIDocument , aId : * mut nsAtom ... | 1 | 4 | 0 |
2c60d9479e266c2b10002f2305960b44de54544b | CYBAI | 2018-01-12T16:56:30 | servo: Merge #19752 - style: Use Python's True instead of string for arbitrary Python code in mako (from CYBAI:fix-mako-true); r=nox
As discussion in IRC with @nox and @gootorov , it's more correct to use Python's `True` for `${arbitrary Python code}` in mako.
Following is related IRC logs
```
15:39 nox
As I said, t... | diff --git a/style/properties/longhand/border.mako.rs b/style/properties/longhand/border.mako.rs
index 505be70d0..11fdf30b9 100644
--- a/style/properties/longhand/border.mako.rs
+++ b/style/properties/longhand/border.mako.rs
@@ -210,7 +210,7 @@ ${helpers.predefined_type("border-image-source", "ImageLayer",
vector=... | 7 | 12 | 12 |
8e00cbb8b2f239149a642cc9fe299ddc93ddca80 | Emilio Cobos Álvarez | 2018-01-12T11:09:04 | servo: Merge #19747 - style: Add a document state invalidator (from emilio:doc-state-invalidator); r=upsuper
Don't use it yet (since I was working from a Servo tree). Will hook it up and improve in the Gecko bug.
Right now it takes a `StyleRuleCascadeData`, which means that if all the origins in the document have sta... | diff --git a/selectors/context.rs b/selectors/context.rs
index ca7a2bfcb..856e18497 100644
--- a/selectors/context.rs
+++ b/selectors/context.rs
@@ -130,6 +130,9 @@ where
/// should match when matching_mode is ForStatelessPseudoElement.
pub pseudo_element_matching_fn: Option<&'a Fn(&Impl::PseudoElement) -> bo... | 12 | 182 | 14 |
ad291f26fe60f8cbb4837baa4278eee18a710636 | Emilio Cobos Álvarez | 2018-01-11T13:50:55 | servo: Merge #19744 - style: A few trivial changes in preparation for document state invalidation (from emilio:doc-invalidation-preparation); r=upsuper
Source-Repo: https://github.com/servo/servo
Source-Revision: 9b3fc43f5a576f4cc466a779e2a308e53a8a46f7 | diff --git a/style/data.rs b/style/data.rs
index 2cd2d84e6..56f2de5be 100644
--- a/style/data.rs
+++ b/style/data.rs
@@ -246,8 +246,8 @@ impl ElementData {
return InvalidationResult::empty();
}
- use invalidation::element::collector::StateAndAttrInvalidationProcessor;
use invalid... | 7 | 106 | 94 |
562d510308691434513383eceea6bc4153b46295 | Pyfisch | 2018-01-11T09:41:43 | servo: Merge #19716 - Use a ToLayout trait for converting from style to webrender types (from pyfisch:conversions); r=emilio
Source-Repo: https://github.com/servo/servo
Source-Revision: 1a4df8f87668d5f5f24f4faeca43fb592a8edfe0 | diff --git a/gfx/display_list/mod.rs b/gfx/display_list/mod.rs
index 6c3df1028..c4c73e50d 100644
--- a/gfx/display_list/mod.rs
+++ b/gfx/display_list/mod.rs
@@ -33,8 +33,8 @@ use style::values::computed::Filter;
use style_traits::cursor::Cursor;
use text::TextRun;
use text::glyph::ByteIndex;
-use webrender_api::{sel... | 7 | 250 | 315 |
867d1d672e0ed947eb2978e42b2a83af0c95963a | Edgar Chen | 2018-01-11T03:06:04 | servo: Merge #19743 - style: Remove :unsolved pseudo-class (from EdgarChen:unresolved); r=heycam
<!-- Please describe your changes on the following line: -->
This is the servo part changes of https://bugzilla.mozilla.org/show_bug.cgi?id=1417829.
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]`... | diff --git a/style/element_state.rs b/style/element_state.rs
index 9d9cf0da7..0960ca3d4 100644
--- a/style/element_state.rs
+++ b/style/element_state.rs
@@ -71,8 +71,7 @@ bitflags! {
const IN_OPTIONAL_STATE = 1 << 22;
/// <https://html.spec.whatwg.org/multipage/#selector-read-write>
const IN_... | 3 | 1 | 4 |
0d84ca5cadde6ec0e8b23aa7c0c15b7e45a90986 | Anthony Ramine | 2018-01-10T16:37:47 | servo: Merge #19727 - Properly handle CR in textarea placeholders (fixes #19717) (from nox:cr-placeholder); r=emilio
Source-Repo: https://github.com/servo/servo
Source-Revision: 2065fa6da23c304093b0fdbbf7c068e0b0c67366 | diff --git a/script/dom/htmltextareaelement.rs b/script/dom/htmltextareaelement.rs
index 7996eecc5..af69e227d 100755
--- a/script/dom/htmltextareaelement.rs
+++ b/script/dom/htmltextareaelement.rs
@@ -50,7 +50,7 @@ pub struct HTMLTextAreaElement {
pub trait LayoutHTMLTextAreaElementHelpers {
#[allow(unsafe_code... | 2 | 10 | 8 |
d6a7e132d61cefad3fd34d640b0db6da5e22a82a | CYBAI | 2018-01-10T13:59:04 | servo: Merge #19737 - style: Move paint-order outside of mako (from CYBAI:move-paint-order-out-of-mako); r=emilio
This is a sub-PR of #19015
r? emilio
---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #19736
- [x] These changes do not re... | diff --git a/style/properties/longhand/inherited_svg.mako.rs b/style/properties/longhand/inherited_svg.mako.rs
index 2cc878a1a..11e39bd09 100644
--- a/style/properties/longhand/inherited_svg.mako.rs
+++ b/style/properties/longhand/inherited_svg.mako.rs
@@ -130,151 +130,11 @@ ${helpers.predefined_type("marker-end", "Url... | 5 | 148 | 148 |
e4068459641ba4681092d2af65cce7336fbe2df4 | Emilio Cobos Álvarez | 2018-01-10T05:34:15 | servo: Merge #19734 - style: Remove some unneeded indirection (from emilio:less-indirection); r=mbrubeck
All TElement's implement Copy, and are just pointers, so the double indirection
is stupid.
I'm going to try to see if removing this double-indirection fixes some
selector-matching performance, and this is a trivia... | diff --git a/script_layout_interface/wrapper_traits.rs b/script_layout_interface/wrapper_traits.rs
index 8a47117a0..348a7a46c 100644
--- a/script_layout_interface/wrapper_traits.rs
+++ b/script_layout_interface/wrapper_traits.rs
@@ -398,22 +398,20 @@ pub trait ThreadSafeLayoutElement
&style... | 4 | 27 | 29 |
96e1a97b41e4016a97fbb5feffe0060ef9656a4c | Nathan | 2018-01-10T04:15:12 | servo: Merge #19730 - number input type validations (from NLincoln:19172-number-input-type-validations); r=KiChjang
I used rust's builtin float parser to implement this. Rust's parser is more permissive than what browsers support (in this case), so I added some code to handle those edge cases.
This passes all the pre... | diff --git a/script/dom/bindings/str.rs b/script/dom/bindings/str.rs
index 9e7c01ed5..eaabc2980 100644
--- a/script/dom/bindings/str.rs
+++ b/script/dom/bindings/str.rs
@@ -303,6 +303,16 @@ impl DOMString {
parse_week_string(&*self.0).is_ok()
}
+ /// A valid number is the same as what rust considers ... | 2 | 16 | 0 |
ae80d0d98a9e09c41e421d53117d0f117c77265b | Emilio Cobos Álvarez | 2018-01-10T02:50:12 | servo: Merge #19733 - style: Use Option::get_or_insert_with (from emilio:less-unwrap); r=glennw
Less unwraps is better.
Source-Repo: https://github.com/servo/servo
Source-Revision: e5a0bb9b4d26156ee675c33968007c7d0d54fd3b | diff --git a/style/sharing/mod.rs b/style/sharing/mod.rs
index fd25c1b72..729a85921 100644
--- a/style/sharing/mod.rs
+++ b/style/sharing/mod.rs
@@ -152,24 +152,25 @@ impl ValidationData {
/// Get or compute the list of presentational attributes associated with
/// this element.
pub fn pres_hints<E>(&mut... | 2 | 27 | 31 |
c2028157602579ee696fb4ed1ddbf0ac1d2d33cc | Manoj | 2018-01-09T01:28:49 | servo: Merge #19724 - Remove out of date FIXME comments from domimplementation (from hindenbug:19723-remove-fixme-comments); r=metajack
<!-- Please describe your changes on the following line: -->
This removes out of date FIXME comments from `domimplementation.rs`
---
<!-- Thank you for contributing to Servo! Please ... | diff --git a/script/dom/domimplementation.rs b/script/dom/domimplementation.rs
index b81f9284b..c25908e67 100644
--- a/script/dom/domimplementation.rs
+++ b/script/dom/domimplementation.rs
@@ -114,7 +114,7 @@ impl DOMImplementationMethods for DOMImplementation {
}
// Step 6.
- // FIXME: https... | 1 | 2 | 2 |
327e1a05413001b57f0f2927094ef207f1e244d2 | tigercosmos | 2018-01-08T17:23:21 | servo: Merge #19647 - replace DocumentSource::NotFromParser with DocumentSource::FromParser (from tigercosmos:x3); r=jdm
<!-- Please describe your changes on the following line: -->
per https://github.com/servo/servo/pull/4297/files#r158729975
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by... | diff --git a/script/dom/domparser.rs b/script/dom/domparser.rs
index 00c18541a..c0de08656 100644
--- a/script/dom/domparser.rs
+++ b/script/dom/domparser.rs
@@ -77,7 +77,6 @@ impl DOMParserMethods for DOMParser {
Ok(document)
}
Text_xml | Application_xml | Application_xhtml_xm... | 1 | 2 | 2 |
c8ed0a41635ce70ed96244fb0d31ad7c19988979 | Adrian Wielgosik | 2018-01-08T10:52:09 | servo: Merge #19722 - Remove js.mem.gc.refresh_frame_slices.enabled pref (from adrian17:master); r=emilio
Clean up after gecko [bug 1421358](https://bugzilla.mozilla.org/show_bug.cgi?id=1421358), which removed the pref entirely.
Source-Repo: https://github.com/servo/servo
Source-Revision: 02f1864770c108a47b3c83c3d892... | diff --git a/script/script_runtime.rs b/script/script_runtime.rs
index ee089a2ee..cf42b47c5 100644
--- a/script/script_runtime.rs
+++ b/script/script_runtime.rs
@@ -260,7 +260,6 @@ pub unsafe fn new_rt_and_cx() -> Runtime {
if let Some(val) = PREFS.get("js.mem.gc.dynamic_mark_slice.enabled").as_boolean() {
... | 1 | 0 | 1 |
393b6fae6d167a4d3b89e6305e36394c40f5fbea | Glenn Watson | 2018-01-07T23:04:54 | servo: Merge #19715 - Update WR (removal of RGB8, which isn't supported on some hardware) (from glennw:update-wr-rgb8); r=emilio
Instead, we convert any source RGB8 images into RGBx (with
an opaque alpha channel).
Source-Repo: https://github.com/servo/servo
Source-Revision: 5d0d6cff81a003e72dda83f6b2dd87ad8821d779 | diff --git a/canvas/webgl_thread.rs b/canvas/webgl_thread.rs
index 106027523..e03021761 100644
--- a/canvas/webgl_thread.rs
+++ b/canvas/webgl_thread.rs
@@ -487,7 +487,7 @@ impl<VR: WebVRRenderHandler + 'static, OB: WebGLThreadObserver> WebGLThread<VR,
width: size.width as u32,
height: size.he... | 2 | 31 | 40 |
d153a0564809a58eff601ff01872bdd346122af5 | tigercosmos | 2018-01-07T11:10:47 | servo: Merge #19602 - implement valid DatetimeLocal input (from tigercosmos:r1); r=KiChjang
<!-- Please describe your changes on the following line: -->
implement valid Date time Local input
part of #19172
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and... | diff --git a/script/dom/bindings/str.rs b/script/dom/bindings/str.rs
index 83c438a26..9e7c01ed5 100644
--- a/script/dom/bindings/str.rs
+++ b/script/dom/bindings/str.rs
@@ -302,6 +302,20 @@ impl DOMString {
pub fn is_valid_week_string(&self) -> bool {
parse_week_string(&*self.0).is_ok()
}
+
+ /// ... | 2 | 104 | 5 |
ec6e333b6b92dd082b9bce97337620e789cec732 | Pyfisch | 2018-01-05T12:37:38 | servo: Merge #19699 - Correctly place images with background-position: center (from pyfisch:background-position-fix); r=emilio
Add a regression ref test.
See also #19680.
<!-- Please describe your changes on the following line: -->
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when... | diff --git a/layout/display_list_builder.rs b/layout/display_list_builder.rs
index 03dbf86fe..05413836a 100644
--- a/layout/display_list_builder.rs
+++ b/layout/display_list_builder.rs
@@ -1581,7 +1581,7 @@ impl FragmentDisplayListBuilding for Fragment {
let mut tile_size = compute_background_image_size(bg_siz... | 1 | 1 | 1 |
36d3c5ae55871f1a7e2b29a9fbd0131d629f23d3 | Emilio Cobos Álvarez | 2018-01-05T11:11:00 | servo: Merge #18893 - style: Remove TNode::set_can_be_fragmented and TNode::can_be_fragmented (from emilio:bye-can-be-fragmented); r=SimonSapin
Replace them instead by a computed value flag, the same way as the
IS_IN_DISPLAY_NONE_SUBTREE flag works.
Source-Repo: https://github.com/servo/servo
Source-Revision: 83a8891... | diff --git a/layout/construct.rs b/layout/construct.rs
index 67e61b7df..8efeeb97e 100644
--- a/layout/construct.rs
+++ b/layout/construct.rs
@@ -1353,13 +1353,14 @@ impl<'a, ConcreteThreadSafeLayoutNode: ThreadSafeLayoutNode>
return false
}
- if node.can_be_fragmented() || node.style(self... | 13 | 58 | 84 |
c4608ba917eb4b3e11ca9613261d6e8308c94354 | Xidorn Quan | 2018-01-05T09:35:04 | servo: Merge #19696 - Skip rule node which contains only inherited properties for rule cache (from upsuper:rule-cache-opt); r=emilio
This is one possible fix for [bug 1427681](https://bugzilla.mozilla.org/show_bug.cgi?id=1427681) which tries to skip some rule nodes when using rule cache.
Try push for correctness: htt... | diff --git a/style/animation.rs b/style/animation.rs
index 7fc57c22f..ada5ccad4 100644
--- a/style/animation.rs
+++ b/style/animation.rs
@@ -485,6 +485,7 @@ fn compute_style_for_animation_step(context: &SharedStyleContext,
properties::apply_declarations(context.stylist.device(),
... | 6 | 75 | 7 |
1bc43b87dd5b48c857ef98460a656d78299ba49b | Pyfisch | 2018-01-05T06:25:12 | servo: Merge #19691 - Remove mention of some old issues (from pyfisch:cleanup-issues); r=emilio
* #228 was done (confirmed by mbrubeck)
* #2012 fixed TODO item
* servo/webrender#28 (zoom does work)
<!-- Please describe your changes on the following line: -->
See #19685
---
<!-- Thank you for contributing to Servo! P... | diff --git a/compositing/compositor.rs b/compositing/compositor.rs
index f0fa2fab8..496a75b0c 100644
--- a/compositing/compositor.rs
+++ b/compositing/compositor.rs
@@ -1034,7 +1034,6 @@ impl<Window: WindowMethods> IOCompositor<Window> {
}
}
- // TODO(gw): Support zoom (WR issue #28).
... | 4 | 11 | 19 |
12d4caddb9dcf4eb642a7369cffab180e6419803 | Hiroyuki Ikezoe | 2018-01-05T04:14:18 | servo: Merge #19693 - Drop animation name and transition property from early properties (from hiikezoe:drop-animation-name-and-transition-property-from-early-properties); r=boris
<!-- Please describe your changes on the following line: -->
https://bugzilla.mozilla.org/show_bug.cgi?id=1420928
Source-Repo: https://gith... | diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs
index 3f8cd13a1..d25a65169 100644
--- a/style/properties/gecko.mako.rs
+++ b/style/properties/gecko.mako.rs
@@ -2948,8 +2948,8 @@ fn static_assert() {
let count = other.gecko.m${type.capitalize()}${gecko_ffi_name}Count;
self.... | 2 | 18 | 17 |
b5166e73ca0161a1f88e3585921fada707684a33 | lizhixun | 2018-01-05T01:52:44 | servo: Merge #19692 - style: Make Contain::parse simpler (from stevel98:Contain); r=emilio
<!-- Please describe your changes on the following line: -->
---
Makes Contain::parse slightly simpler, as discussed in #19682
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any erro... | diff --git a/style/values/specified/box.rs b/style/values/specified/box.rs
index f4b55446a..1ba23a2c9 100644
--- a/style/values/specified/box.rs
+++ b/style/values/specified/box.rs
@@ -553,18 +553,8 @@ impl Parse for Contain {
"layout" => Some(Contain::LAYOUT),
"style" => Some(Contain:... | 1 | 2 | 12 |
43984f3df92305cf831147733bafd5fa3b10c88a | Pyfisch | 2018-01-04T20:06:47 | servo: Merge #19689 - Fix typo. san-serif -> sans-serif (from pyfisch:san-serif); r=jdm
<!-- Please describe your changes on the following line: -->
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach bui... | diff --git a/gfx/platform/freetype/android/font_list.rs b/gfx/platform/freetype/android/font_list.rs
index 2ff8be5a3..6d5a1ea30 100644
--- a/gfx/platform/freetype/android/font_list.rs
+++ b/gfx/platform/freetype/android/font_list.rs
@@ -203,7 +203,7 @@ impl FontList {
// Only used in the unlikely case where no fon... | 1 | 1 | 1 |
aa2536b82b62d08100a5144a30c1b65bb9c22d7e | lizhixun | 2018-01-04T10:28:23 | servo: Merge #19682 - style: Move contain outside of mako (from stevel98:moveContain); r=emilio
<!-- Please describe your changes on the following line: -->
Sub-PR for #19015.
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate d... | diff --git a/style/properties/longhand/box.mako.rs b/style/properties/longhand/box.mako.rs
index a24c3cb03..5a026ae06 100644
--- a/style/properties/longhand/box.mako.rs
+++ b/style/properties/longhand/box.mako.rs
@@ -543,100 +543,14 @@ ${helpers.predefined_type("transform-origin",
boxed=True,... | 5 | 102 | 98 |
5ee4a13952172941cc37f9ba622567379c3fa359 | Glenn Watson | 2018-01-03T20:13:42 | servo: Merge #19677 - Enable GPU queries by default when opening the profiler view (from glennw:wr-queries); r=pcwalton
Source-Repo: https://github.com/servo/servo
Source-Revision: cdf7c0ceff7edc4374521fb19329109f999a9c3b | diff --git a/compositing/compositor.rs b/compositing/compositor.rs
index 9c1bdedcd..f0fa2fab8 100644
--- a/compositing/compositor.rs
+++ b/compositing/compositor.rs
@@ -1524,9 +1524,17 @@ impl<Window: WindowMethods> IOCompositor<Window> {
pub fn toggle_webrender_debug(&mut self, option: WebRenderDebugOption) {
... | 1 | 11 | 3 |
3b3d69526adb31c721029e0c6f119648e78d1bc1 | Pyfisch | 2018-01-03T19:03:49 | servo: Merge #19675 - Implement correct corner clipping for background color (from pyfisch:issue19649); r=emilio
Add one regression ref test.
See also #19649
---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] There are tests for these changes
Source-Rep... | diff --git a/layout/display_list_builder.rs b/layout/display_list_builder.rs
index 09f448531..370ebcdf2 100644
--- a/layout/display_list_builder.rs
+++ b/layout/display_list_builder.rs
@@ -681,7 +681,7 @@ fn build_border_radius(abs_bounds: &Rect<Au>,
fn build_border_radius_for_inner_rect(outer_rect: &Rect<Au>,
... | 1 | 25 | 15 |
f32a56e02b43f247b86bfec6bc6780c2c0d0e05d | Emilio Cobos Álvarez | 2018-01-03T18:01:42 | servo: Merge #19654 - style: Allow building stylo with rust nightly (from emilio:geckolib-nightly); r=jdm
See individual commits for details.
Source-Repo: https://github.com/servo/servo
Source-Revision: f71fb8bddc28060320c233701898541112322d66 | diff --git a/style/gecko/wrapper.rs b/style/gecko/wrapper.rs
index f8a1837de..32871baf5 100644
--- a/style/gecko/wrapper.rs
+++ b/style/gecko/wrapper.rs
@@ -1787,7 +1787,7 @@ impl<'le> Eq for GeckoElement<'le> {}
impl<'le> Hash for GeckoElement<'le> {
#[inline]
fn hash<H: Hasher>(&self, state: &mut H) {
- ... | 2 | 1 | 2 |
55dd3f2589ae11035b105bc5f318dda5f8764388 | Emilio Cobos Álvarez | 2018-01-02T16:00:22 | servo: Merge #19673 - style: Make GetFlattenedTreeParent more straight-forward (from emilio:flattened-tree-parent); r=smaug
Now that accessing nsIContent slots is not a blob of virtual function calls, we
should be able to unify logic here, and speed up the not-so-rare case for
chrome, while keeping the usual case fast... | diff --git a/style/gecko/generated/bindings.rs b/style/gecko/generated/bindings.rs
index 090d2096d..0f8c9d3e9 100644
--- a/style/gecko/generated/bindings.rs
+++ b/style/gecko/generated/bindings.rs
@@ -503,8 +503,6 @@ extern "C" {
pub fn Gecko_RecordTraversalStatistics ( total : u32 , parallel : u32 , total_t : u32 , ... | 2 | 17 | 9 |
358fe48de480a645665e33aa24442d4f30f61e65 | Pyfisch | 2018-01-02T14:47:24 | servo: Merge #19651 - Unify background placement code (from pyfisch:background-placement); r=emilio
Merges the implementations for background-image placement
from gradients and images. Add missing parts and fix bugs.
Now supported are the CSS properties:
* background-attachment (except for local value, see #19650)
*... | diff --git a/gfx/display_list/mod.rs b/gfx/display_list/mod.rs
index 9d0c93d6b..6c3df1028 100644
--- a/gfx/display_list/mod.rs
+++ b/gfx/display_list/mod.rs
@@ -729,6 +729,7 @@ pub struct GradientDisplayItem {
///
/// Without tiles, the tile will be the same size as the background.
pub tile: Size2D<Au>,
... | 4 | 338 | 329 |
c656cdc5602491f777606c532b6c3c4996cc01de | Boris Chiou | 2018-01-02T03:32:59 | servo: Merge #19607 - hashglobe: Dump the requested aligment if out of memory while allocating a table (from BorisChiou:stylo/crash/out_of_memory_alignment); r=emilio
This is for Bug 1418806 and Bug 1416903. We need not only the requested size
but also the requested alignment for debugging.
---
- [X] `./mach build -d... | diff --git a/hashglobe/src/lib.rs b/hashglobe/src/lib.rs
index 6431d3350..49038a518 100644
--- a/hashglobe/src/lib.rs
+++ b/hashglobe/src/lib.rs
@@ -26,17 +26,25 @@ trait Recover<Q: ?Sized> {
fn replace(&mut self, key: Self::Key) -> Option<Self::Key>;
}
+#[derive(Debug)]
+pub struct AllocationInfo {
+ /// Th... | 2 | 17 | 6 |
9ccea9a9503ca3d7e56d9fbb7d26d9b0e9e9cd8f | CYBAI | 2018-01-01T18:14:39 | servo: Merge #19659 - style: Move display outside of mako (from CYBAI:display-out-of-mako); r=emilio
This is a sub-PR of #19015
r? emilio
---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #19658
- [x] These changes do not require tests
... | diff --git a/style/properties/longhand/box.mako.rs b/style/properties/longhand/box.mako.rs
index 58520d3cd..a24c3cb03 100644
--- a/style/properties/longhand/box.mako.rs
+++ b/style/properties/longhand/box.mako.rs
@@ -13,229 +13,36 @@
//
// We allow "display" to apply to placeholders because we need to make the
// pl... | 5 | 249 | 226 |
bc2b3006104a14eed9dbfa0bf687353f092d0510 | Pyfisch | 2018-01-01T15:38:07 | servo: Merge #19652 - Fix division by zero in gradient stop calculation (from pyfisch:issue18435); r=emilio
Check if total_length is zero and return 0.0 instead
of NaN in this case.
Closes #18435
<!-- Please describe your changes on the following line: -->
---
<!-- Thank you for contributing to Servo! Please replac... | diff --git a/layout/display_list_builder.rs b/layout/display_list_builder.rs
index 034e5a2d5..97b1ba4c7 100644
--- a/layout/display_list_builder.rs
+++ b/layout/display_list_builder.rs
@@ -798,6 +798,7 @@ fn convert_gradient_stops(gradient_items: &[GradientItem],
position_to_offset(position, total_leng... | 1 | 4 | 0 |
2b083c15c6ffae0774d1ac5841c2f840bd87abbc | Pyfisch | 2018-01-01T14:19:36 | servo: Merge #19655 - Remove solved FIXMEs about border radii (from pyfisch:border-radii-comments); r=emilio
cc pcwalton
cgaebel: Is this [comment] still accurate?
// TODO(cgaebel): Support border radii even in the case of multiple border widths.
// This is an extension of supporting elliptical radii. For n... | diff --git a/gfx/display_list/mod.rs b/gfx/display_list/mod.rs
index 98b78ef5c..9d0c93d6b 100644
--- a/gfx/display_list/mod.rs
+++ b/gfx/display_list/mod.rs
@@ -775,8 +775,6 @@ pub struct NormalBorder {
pub style: SideOffsets2D<border_style::T>,
/// Border radii.
- ///
- /// TODO(pcwalton): Elliptical... | 2 | 0 | 5 |
78b040729d8a3f2d9a7cace49a1155cc44864592 | Emilio Cobos Álvarez | 2017-12-31T16:01:58 | servo: Merge #19667 - Revert #19666 since we do create NAC elements and expect them to be inline (from emilio:root-and-item); r=emilio
This reverts commit 1970e82b0d310128eabe8466d39d42cc20e7ae4b, reversing
changes made to e882660ea694f9f12d9d2936012dbdf192f8aec8.
The reparenting logic is still bogus, but I'll figure... | diff --git a/layout_thread/dom_wrapper.rs b/layout_thread/dom_wrapper.rs
index 62b9ae8b7..82a9678d7 100644
--- a/layout_thread/dom_wrapper.rs
+++ b/layout_thread/dom_wrapper.rs
@@ -460,6 +460,10 @@ impl<'le> TElement for ServoLayoutElement<'le> {
}
}
+ fn skip_root_and_item_based_display_fixup(&self)... | 6 | 44 | 18 |
490abd0820aaad58d0f1be16a71cdfe6828070da | Emilio Cobos Álvarez | 2017-12-31T13:01:10 | servo: Merge #19666 - style: Simplify the skip item based display fixup adjustment (from emilio:root-and-item); r=upsuper
In practice the only NAC that possibly inherits from a grid or flex container
are pseudos.
In Gecko, if the root element is an item container, custom anon content would
also sometimes incorrectly ... | diff --git a/layout_thread/dom_wrapper.rs b/layout_thread/dom_wrapper.rs
index 82a9678d7..62b9ae8b7 100644
--- a/layout_thread/dom_wrapper.rs
+++ b/layout_thread/dom_wrapper.rs
@@ -460,10 +460,6 @@ impl<'le> TElement for ServoLayoutElement<'le> {
}
}
- fn skip_root_and_item_based_display_fixup(&self)... | 6 | 18 | 44 |
8b2cc72ce83c0bc951858d749114c822aae3a91a | Emilio Cobos Álvarez | 2017-12-31T09:46:22 | servo: Merge #19665 - style_derive: Support parse-time aliases (from emilio:derive-parse-alias); r=Manishearth
This will allow #19659 to use derive on display using:
#[parse(aliases = "-webkit-flex")]
Flex,
#[parse(aliases = "-webkit-inline-flex")]
InlineFlex,
And such.
Source-Repo: https://github.c... | diff --git a/style_derive/lib.rs b/style_derive/lib.rs
index cbe33a3d1..a9a8a32db 100644
--- a/style_derive/lib.rs
+++ b/style_derive/lib.rs
@@ -39,7 +39,7 @@ pub fn derive_to_animated_value(stream: TokenStream) -> TokenStream {
to_animated_value::derive(input).to_string().parse().unwrap()
}
-#[proc_macro_deriv... | 2 | 23 | 1 |
7277910f4b1ff9c0d73cf816c25c08ca24c694e7 | Emilio Cobos Álvarez | 2017-12-31T08:23:59 | servo: Merge #19662 - style: Simplify "prohibit display: contents" adjustment (from emilio:simplify-prohibit-display-contents); r=upsuper
On top of #19661.
The NAC condition is pointless because NAC don't match author rules unless they
are a pseudo-element too.
Source-Repo: https://github.com/servo/servo
Source-Revi... | diff --git a/style/properties/properties.mako.rs b/style/properties/properties.mako.rs
index 97cdf7418..12750e33b 100644
--- a/style/properties/properties.mako.rs
+++ b/style/properties/properties.mako.rs
@@ -3079,18 +3079,13 @@ bitflags! {
/// that it may affect global state, like the Device's root font-size.... | 3 | 12 | 15 |
5f6a13515de4b533b73107e3965094fa5bcb2993 | Emilio Cobos Álvarez | 2017-12-30T21:12:23 | servo: Merge #19661 - style: Simplify ::-moz-fieldset-content special-casing (from emilio:simplify-fieldset-contents); r=upsuper
The style adjuster knows about the pseudo, so there's no reason to thread that
info down.
There are more simplifications that can be done in followups, cleaning a bit the
cascade flags too,... | diff --git a/style/properties/properties.mako.rs b/style/properties/properties.mako.rs
index bdabec78f..97cdf7418 100644
--- a/style/properties/properties.mako.rs
+++ b/style/properties/properties.mako.rs
@@ -3084,9 +3084,6 @@ bitflags! {
/// content.
const PROHIBIT_DISPLAY_CONTENTS = 1 << 4;
- ... | 2 | 5 | 8 |
2a04b763db558f086d4ce2f53e7728b8bdc372b9 | CYBAI | 2017-12-29T12:08:33 | servo: Merge #19646 - style: Move touch-action outside of mako (from CYBAI:move-touch-action-out-of-mako); r=emilio
This is a sub-PR of #19015
r? emilio
---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #19645
- [x] These changes do not ... | diff --git a/style/properties/longhand/box.mako.rs b/style/properties/longhand/box.mako.rs
index 694566ec6..58520d3cd 100644
--- a/style/properties/longhand/box.mako.rs
+++ b/style/properties/longhand/box.mako.rs
@@ -910,81 +910,12 @@ ${helpers.predefined_type(
spec="https://drafts.csswg.org/css-shapes/#shape-outs... | 5 | 111 | 81 |
5a28f7b68f53e6515f93ed15ccbc6031c295c4d0 | tigercosmos | 2017-12-25T13:56:42 | servo: Merge #19622 - pretty print tree (from tigercosmos:x2); r=shinglyu
<!-- Please describe your changes on the following line: -->
```
│ │ │ │ │ │ │ floatspec-out=L 0px R 0px
│ │ │ │ │ │ │ overflow=Overflow { scroll: TypedRect(0px×0px at (0px,0px)), paint: TypedRect(0px×0px at (0px,0px)... | diff --git a/gfx_traits/print_tree.rs b/gfx_traits/print_tree.rs
index a842193e0..e347c82be 100644
--- a/gfx_traits/print_tree.rs
+++ b/gfx_traits/print_tree.rs
@@ -22,12 +22,21 @@ impl PrintTree {
}
}
- /// Descend one level in the tree with the given title.
- pub fn new_level(&mut self, title: S... | 4 | 42 | 15 |
1ff64b2f763d9eb091d2ad53a8c0c8f97396ef30 | tigercosmos | 2017-12-25T11:12:41 | servo: Merge #19642 - cleanup no need cfg target_os (from tigercosmos:c1); r=emilio
<!-- Please describe your changes on the following line: -->
Already in macos, no need cfg target_os
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with app... | diff --git a/gfx/platform/macos/font_list.rs b/gfx/platform/macos/font_list.rs
index c0800f94c..ed3858a84 100644
--- a/gfx/platform/macos/font_list.rs
+++ b/gfx/platform/macos/font_list.rs
@@ -42,6 +42,4 @@ pub fn last_resort_font_families() -> Vec<String> {
vec!("Arial Unicode MS".to_owned(), "Arial".to_owned())
... | 1 | 0 | 2 |
734f5d7541d58b77550b2ec71f0577a892c5f38c | Emilio Cobos Álvarez | 2017-12-25T03:34:21 | servo: Merge #19641 - style: Some trivial cleanup (from emilio:christmas-cleanup); r=cybai
Source-Repo: https://github.com/servo/servo
Source-Revision: d96fb89c3118ff12142397f25d1546235515ec14 | diff --git a/style/counter_style/mod.rs b/style/counter_style/mod.rs
index 4e195dd15..f0fa18fda 100644
--- a/style/counter_style/mod.rs
+++ b/style/counter_style/mod.rs
@@ -401,11 +401,10 @@ pub enum Symbol {
impl Parse for Symbol {
fn parse<'i, 't>(_context: &ParserContext, input: &mut Parser<'i, 't>) -> Result<... | 3 | 17 | 20 |
998d15399b7a22d116557264d72d7fbd4ac1dae1 | Jon Leighton | 2017-12-24T20:08:55 | servo: Merge #19636 - Move list-style-type outside of mako (from jonleighton:issue-19629); r=emilio
Closes issue #19629
r? emilio
Source-Repo: https://github.com/servo/servo
Source-Revision: 9a207d17c57cb8133b198933f754989358b7638e | diff --git a/style/properties/longhand/list.mako.rs b/style/properties/longhand/list.mako.rs
index 149bed1e0..bead5054b 100644
--- a/style/properties/longhand/list.mako.rs
+++ b/style/properties/longhand/list.mako.rs
@@ -30,69 +30,13 @@ ${helpers.single_keyword("list-style-position", "outside inside", animation_valu
... | 5 | 75 | 63 |
b661e80e120be1b018cafc30175fc0eb12af8a15 | tigercosmos | 2017-12-21T19:57:04 | servo: Merge #19612 - deny warnings (from tigercosmos:o1); r=jdm
<!-- Please describe your changes on the following line: -->
deny warnings
related to #19573
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `.... | diff --git a/hashglobe/src/alloc.rs b/hashglobe/src/alloc.rs
index f7d505014..b0d622972 100644
--- a/hashglobe/src/alloc.rs
+++ b/hashglobe/src/alloc.rs
@@ -28,6 +28,7 @@ pub use self::platform::{alloc, dealloc, realloc};
mod platform {
extern crate libc;
+ #[cfg(not(any(target_os = "android")))]
use st... | 1 | 1 | 0 |
4bb175cf8e9cc497f67a6cf72377ce6593c04e73 | 石博文 | 2017-12-21T14:53:21 | servo: Merge #19621 - using local variable instead of a function call (from sbwtw:using_variable); r=jdm
the data of `frame_size` is already storage into variable `new_frame_size`
Source-Repo: https://github.com/servo/servo
Source-Revision: a15cecb3f792d4807ec8b271369fa85bb35924b5 | diff --git a/compositing/compositor.rs b/compositing/compositor.rs
index 8d40374c9..9c1bdedcd 100644
--- a/compositing/compositor.rs
+++ b/compositing/compositor.rs
@@ -674,7 +674,7 @@ impl<Window: WindowMethods> IOCompositor<Window> {
return;
}
- self.frame_size = self.window.framebuffer... | 1 | 1 | 1 |
20fdbac60d82ba82caf43a078b5cdd9485bdc3b2 | Emilio Cobos Álvarez | 2017-12-21T13:01:59 | servo: Merge #19620 - style: Make sure to honor parse_method in transition and animation shorthands (from emilio:parse-transition-longhand); r=bbirtles
Reviewed-by: birtles
Bug: 1426312
MozReview-Commit-ID: HY3jtdSdaga
Source-Repo: https://github.com/servo/servo
Source-Revision: e983a5e982df6f5c4725d5f35a31efb7769be43... | diff --git a/style/properties/shorthand/box.mako.rs b/style/properties/shorthand/box.mako.rs
index 3da5820f6..ca8523173 100644
--- a/style/properties/shorthand/box.mako.rs
+++ b/style/properties/shorthand/box.mako.rs
@@ -97,18 +97,10 @@
</%helpers:shorthand>
macro_rules! try_parse_one {
- ($input: expr, $var: id... | 1 | 4 | 14 |
2e4fa0ac22666b189259fb2a9932e80c22b4721c | Emilio Cobos Álvarez | 2017-12-21T06:10:49 | servo: Merge #19617 - style: Fix inheritance of animation and transition properties of mismatched length (from emilio:inherit-animation-stuff); r=hiro
At least when the animation-name length is bigger than the animation properties,
we mess up inheritance and only set properly the specified counts, then don't
cycle it.... | diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs
index 45fe22f3b..06f315ff0 100644
--- a/style/properties/gecko.mako.rs
+++ b/style/properties/gecko.mako.rs
@@ -2951,10 +2951,12 @@ fn static_assert() {
let count = other.gecko.m${type.capitalize()}${gecko_ffi_name}Count;
sel... | 1 | 7 | 4 |
503eb922c0795b5e1868f642e2060670d3eaa726 | Emilio Cobos Álvarez | 2017-12-21T03:23:29 | servo: Merge #19615 - style: Remove needless and bogus bounds-check (from emilio:useless-check); r=KiChjang
The check should read index >= self.len(). But it doesn't matter anyway since
we're covered by Rust's bound checks by default anyway.
Source-Repo: https://github.com/servo/servo
Source-Revision: 6524d2281453da8... | diff --git a/style/gecko_bindings/sugar/ns_style_auto_array.rs b/style/gecko_bindings/sugar/ns_style_auto_array.rs
index be1a20c57..512b2138d 100644
--- a/style/gecko_bindings/sugar/ns_style_auto_array.rs
+++ b/style/gecko_bindings/sugar/ns_style_auto_array.rs
@@ -15,9 +15,6 @@ use std::slice::{Iter, IterMut};
impl<T>... | 1 | 0 | 6 |
b38a7cfdc79ffae581c03872297fa7f22e072360 | Emilio Cobos Álvarez | 2017-12-20T23:08:30 | servo: Merge #19613 - style: Workaround a likely valgrind false-positive (from emilio:slotted-list); r=jdm
Source-Repo: https://github.com/servo/servo
Source-Revision: fd6847fd764c423b8952d59179f5c08ebec185c5 | diff --git a/style/selector_map.rs b/style/selector_map.rs
index ef70949da..c7c41c6de 100644
--- a/style/selector_map.rs
+++ b/style/selector_map.rs
@@ -433,7 +433,13 @@ fn specific_bucket_for<'a>(
//
// So inserting `span` in the rule hash makes sense since we want to
// match the slotted <s... | 1 | 7 | 1 |
f253bc040abf83dfc3bbf523febc52159938ea68 | Igor Matuszewski | 2017-12-20T18:09:20 | servo: Merge #19611 - Bump mozjs to 0.1.9 (from Xanewok:bump-mozjs); r=jdm
<!-- Please describe your changes on the following line: -->
Bumping rust-mozjs, which was updated in tandem ([here](https://github.com/servo/rust-mozjs/commit/f9664091b1cd6f26b58d7ba6792a16fc83376ce0)) with https://github.com/servo/servo/pull... | diff --git a/script/Cargo.toml b/script/Cargo.toml
index 8c3c77ed2..704d07f39 100644
--- a/script/Cargo.toml
+++ b/script/Cargo.toml
@@ -65,7 +65,7 @@ metrics = {path = "../metrics"}
mitochondria = "1.1.2"
mime = "0.2.1"
mime_guess = "1.8.0"
-mozjs = { version = "0.1.8", features = ["promises"]}
+mozjs = { version =... | 1 | 1 | 1 |
b0754fade4197bf9a8b83f60661807217d567820 | Emilio Cobos Álvarez | 2017-12-20T17:09:50 | servo: Merge #19610 - style: Don't support a list of selectors in ::slotted yet (from emilio:slotted-list); r=xidorn
Bug: 1425757
Reviewed-by: xidorn
MozReview-Commit-ID: G0I0gM2sWTh
Source-Repo: https://github.com/servo/servo
Source-Revision: e074a1c62012e966b499d797b49b2efc08fe4007 | diff --git a/selectors/matching.rs b/selectors/matching.rs
index 1097c288c..60699d9d6 100644
--- a/selectors/matching.rs
+++ b/selectors/matching.rs
@@ -555,18 +555,16 @@ where
{
match *selector {
Component::Combinator(_) => unreachable!(),
- Component::Slotted(ref selectors) => {
+ Compone... | 3 | 62 | 35 |
3e87071963b8b852a280beac568d89c2edef6950 | tigercosmos | 2017-12-20T15:11:56 | servo: Merge #19609 - remove unsued IpcReceiver (from tigercosmos:q1); r=emilio
<!-- Please describe your changes on the following line: -->
```
warning: unused import: `IpcReceiver`
--> components/canvas/canvas_paint_thread.rs:14:41
|
14 | use ipc_channel::ipc::{self, IpcSender, IpcReceiver};
| ... | diff --git a/canvas/canvas_paint_thread.rs b/canvas/canvas_paint_thread.rs
index bb644c60b..28b7fec54 100644
--- a/canvas/canvas_paint_thread.rs
+++ b/canvas/canvas_paint_thread.rs
@@ -11,7 +11,7 @@ use azure::azure_hl::SurfacePattern;
use canvas_traits::canvas::*;
use cssparser::RGBA;
use euclid::{Transform2D, Poin... | 1 | 1 | 1 |
89ccd846217e127f074b220f63cbbb91022908f7 | Manish Goregaokar | 2017-12-19T02:46:31 | servo: Merge #19604 - stylo: Correctly handle interpolation where optional second argument for translate(), skew(), scale() exists in one but not the other (from Manishearth:animate-second); r=emilio
r=emilio https://bugzilla.mozilla.org/show_bug.cgi?id=1424798
Source-Repo: https://github.com/servo/servo
Source-Revis... | diff --git a/style/properties/helpers/animated_properties.mako.rs b/style/properties/helpers/animated_properties.mako.rs
index 8839a58cd..1bde83e7b 100644
--- a/style/properties/helpers/animated_properties.mako.rs
+++ b/style/properties/helpers/animated_properties.mako.rs
@@ -12,6 +12,7 @@ use cssparser::Parser;
#[cfg... | 1 | 39 | 2 |
512d6852f8e290ee47447185e026d01602d304ad | Emilio Cobos Álvarez | 2017-12-19T00:00:27 | servo: Merge #19601 - style: Don't adjust :visited styles (from emilio:adjust-visited); r=upsuper
As the comment says those are not interesting, and it matches what we do for
text and placeholders in Servo_ComputedValues_Inherit.
This fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1425893
Source-Repo: https://gi... | diff --git a/style/style_adjuster.rs b/style/style_adjuster.rs
index 4355a8a43..bf48b9869 100644
--- a/style/style_adjuster.rs
+++ b/style/style_adjuster.rs
@@ -557,6 +557,15 @@ impl<'a, 'b: 'a> StyleAdjuster<'a, 'b> {
layout_parent_style: &ComputedValues,
flags: CascadeFlags,
) {
+ // Don... | 1 | 9 | 0 |
7b2ae996304bdffa70f8ffe0aa78ca5d2889ef5f | Nazım Can Altınova | 2017-12-18T18:12:52 | servo: Merge #19576 - style: Move text-align outside of the mako file (from canaltinova:text-align); r=Manishearth,emilio
I will need this refactoring before my next job. I didn't actually fix the FIXME's along the way. My other PR probably will cover these.
---
- [X] `./mach build -d` does not report any errors
- [X... | diff --git a/layout/flow.rs b/layout/flow.rs
index e4841bd2e..c70651693 100644
--- a/layout/flow.rs
+++ b/layout/flow.rs
@@ -654,7 +654,7 @@ impl FlowFlags {
#[inline]
pub fn set_text_align(&mut self, value: TextAlign) {
*self = (*self & !FlowFlags::TEXT_ALIGN) |
- FlowFlags::from_bits... | 8 | 205 | 165 |
e62306e8d77482d29f8eaa876fcafdf90197b276 | Josh Matthews | 2017-12-18T16:19:30 | servo: Merge #19599 - Revert canvas IPC changes (from jdm:revertcanvas); r=asajeffrey
https://github.com/servo/servo/pull/19547 is responsible for the surge of new intermittent timeouts in canvas-related tests. There's nothing wrong with the change, so I suspect an underlying problem in ipc-channel instead.
Fixes #19... | diff --git a/canvas/canvas_paint_thread.rs b/canvas/canvas_paint_thread.rs
index a985ac7a9..bb644c60b 100644
--- a/canvas/canvas_paint_thread.rs
+++ b/canvas/canvas_paint_thread.rs
@@ -11,7 +11,7 @@ use azure::azure_hl::SurfacePattern;
use canvas_traits::canvas::*;
use cssparser::RGBA;
use euclid::{Transform2D, Poin... | 4 | 18 | 13 |
ab90d37343020de16211416f8ad48a69286a3349 | Emilio Cobos Álvarez | 2017-12-18T13:24:13 | servo: Merge #19595 - style: Add a FIXME comment that I need to write a test-case for (from emilio:broken-code-all-around); r=emilio
Source-Repo: https://github.com/servo/servo
Source-Revision: fab8042fa73ff326a0fa5c65863434eac0070ac1 | diff --git a/style/stylist.rs b/style/stylist.rs
index 1cf306d12..180c421ba 100644
--- a/style/stylist.rs
+++ b/style/stylist.rs
@@ -1292,6 +1292,10 @@ impl Stylist {
if let Some(map) = stylist.cascade_data.author.borrow_for_pseudo(pseudo_element) {
// NOTE(emilio): This is needed because ... | 1 | 4 | 0 |
716a200a185b434a7614cacec13c50132cf1e321 | tigercosmos | 2017-12-17T09:50:33 | servo: Merge #19559 - implement valid week string (from tigercosmos:t1); r=KiChjang
<!-- Please describe your changes on the following line: -->
implement valid week string
part of #19172
r? @KiChjang
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and repl... | diff --git a/script/Cargo.toml b/script/Cargo.toml
index 5561cd7dd..8c3c77ed2 100644
--- a/script/Cargo.toml
+++ b/script/Cargo.toml
@@ -39,6 +39,7 @@ byteorder = "1.0"
canvas_traits = {path = "../canvas_traits"}
caseless = "0.1.0"
cookie = "0.10"
+chrono = "0.4"
cssparser = "0.23.0"
deny_public_fields = {path = "... | 4 | 74 | 1 |
8bfeefa08160ed73ba99f7da5258a235bae7c28f | tigercosmos | 2017-12-17T08:47:09 | servo: Merge #19585 - remove unused `self` in canvas_paint_thread (from tigercosmos:b1); r=KiChjang
<!-- Please describe your changes on the following line: -->
```
Compiling canvas v0.0.1 (file:///Users/tigercosmos/servo/components/canvas)
warning: unused import: `self`
--> components/canvas/canvas_paint_thread.rs:... | diff --git a/canvas/canvas_paint_thread.rs b/canvas/canvas_paint_thread.rs
index 97d3b2d12..a985ac7a9 100644
--- a/canvas/canvas_paint_thread.rs
+++ b/canvas/canvas_paint_thread.rs
@@ -11,7 +11,7 @@ use azure::azure_hl::SurfacePattern;
use canvas_traits::canvas::*;
use cssparser::RGBA;
use euclid::{Transform2D, Poin... | 1 | 1 | 1 |
f13ec032507941c3bab3d831f17e37402c5093c9 | CYBAI | 2017-12-16T22:39:37 | servo: Merge #19583 - style: Move will-change outside of mako (from CYBAI:move-will-change-out-of-mako); r=emilio
This is a sub-PR of #19015
r? emilio
---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #19582
- [x] These changes do not re... | diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs
index 5b46f784d..45fe22f3b 100644
--- a/style/properties/gecko.mako.rs
+++ b/style/properties/gecko.mako.rs
@@ -3619,11 +3619,11 @@ fn static_assert() {
if self.gecko.mWillChange.len() == 0 {
T::Auto
} else {
- ... | 7 | 65 | 65 |
d0aef572b5562c57e889ebcbffa7ed714e139a6b | Emilio Cobos Álvarez | 2017-12-16T21:44:21 | servo: Merge #19584 - style: Remove the grid pref (from emilio:remove-grid-pref); r=mats
Bug: 1398492
Reviewed-by: mats
MozReview-Commit-ID: 6Qez8NE8oze
Source-Repo: https://github.com/servo/servo
Source-Revision: 1501a417044061126401d96f236631c97d4e1946 | diff --git a/style/properties/longhand/position.mako.rs b/style/properties/longhand/position.mako.rs
index 3692ddb0a..8d04c8eba 100644
--- a/style/properties/longhand/position.mako.rs
+++ b/style/properties/longhand/position.mako.rs
@@ -257,7 +257,6 @@ ${helpers.predefined_type("object-position",
... | 2 | 0 | 11 |
f675574c84778f448eadbd2ed92a007e3026ef21 | tigercosmos | 2017-12-16T17:35:40 | servo: Merge #19547 - Send IPC receiver for canvas as part of CreateCanvasPaintThread message (from tigercosmos:b1); r=jdm
<!-- Please describe your changes on the following line: -->
I am not sure if @jdm want this.
r? @jdm
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the ste... | diff --git a/canvas/canvas_paint_thread.rs b/canvas/canvas_paint_thread.rs
index 28b7fec54..97d3b2d12 100644
--- a/canvas/canvas_paint_thread.rs
+++ b/canvas/canvas_paint_thread.rs
@@ -11,7 +11,7 @@ use azure::azure_hl::SurfacePattern;
use canvas_traits::canvas::*;
use cssparser::RGBA;
use euclid::{Transform2D, Poin... | 4 | 13 | 18 |
a71a0b73db932e33e28843f735ed58b28098f5de | Emilio Cobos Álvarez | 2017-12-16T15:13:48 | servo: Merge #19581 - style: Fix grid line serialization to avoid redundant spacing (from emilio:grid-line-serialize); r=canaltinova
This fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1425227.
Source-Repo: https://github.com/servo/servo
Source-Revision: a31fd24ce93f3a8bde1b56e01109ee3b94532e0d | diff --git a/style/values/generics/grid.rs b/style/values/generics/grid.rs
index bd0dc8250..95e1f1d50 100644
--- a/style/values/generics/grid.rs
+++ b/style/values/generics/grid.rs
@@ -59,12 +59,16 @@ where
}
if let Some(ref i) = self.line_num {
- dest.write_str(" ")?;
+ if sel... | 1 | 6 | 2 |
f02cf0fbf2f50bc3f69daf4f1bc18dad3265d876 | Brian Birtles | 2017-12-15T23:39:55 | servo: Merge #19580 - Update references to Web Animations spec (from birtles:update-web-animations-link); r=hiro
This has been reviewed in [Gecko bug 1425548](https://bugzilla.mozilla.org/show_bug.cgi?id=1425548).
Source-Repo: https://github.com/servo/servo
Source-Revision: f7440bf1a68cd0beaf12621c9c460c6f6ddc57e3 | diff --git a/style/properties/helpers/animated_properties.mako.rs b/style/properties/helpers/animated_properties.mako.rs
index 8a035c8c8..8839a58cd 100644
--- a/style/properties/helpers/animated_properties.mako.rs
+++ b/style/properties/helpers/animated_properties.mako.rs
@@ -262,7 +262,7 @@ impl AnimatedProperty {
... | 2 | 6 | 6 |
eff91b455b2b419a5ec8e71d01ec10472ad2d800 | Pyfisch | 2017-12-15T21:54:59 | servo: Merge #19568 - layout: background-origin attribute for gradients (from pyfisch:background-origin-gradients1); r=mbrubeck
Fixes the glitches mentioned in #19554.
Now gradient tiles are placed in the whole bounding box.
<!-- Please describe your changes on the following line: -->
---
<!-- Thank you for contribu... | diff --git a/layout/Cargo.toml b/layout/Cargo.toml
index 28dca1eff..60cf29ca3 100644
--- a/layout/Cargo.toml
+++ b/layout/Cargo.toml
@@ -10,7 +10,7 @@ name = "layout"
path = "lib.rs"
[dependencies]
-app_units = "0.6"
+app_units = "0.6.1"
atomic_refcell = "0.1"
bitflags = "1.0"
canvas_traits = {path = "../canvas_... | 2 | 57 | 11 |
4e941790feed3704c4473b2076311fb855247e42 | Emilio Cobos Álvarez | 2017-12-15T20:55:49 | servo: Merge #19578 - Allow deriving Parse on keywords (from emilio:parse-keyword); r=Manishearth,canaltinova
This makes patches like #19576 much easier.
Source-Repo: https://github.com/servo/servo
Source-Revision: e631d167bf28676e45e37f418b4282fcfba98c1e | diff --git a/style/parser.rs b/style/parser.rs
index 1b1d41516..df8551bff 100644
--- a/style/parser.rs
+++ b/style/parser.rs
@@ -149,8 +149,10 @@ pub trait Parse : Sized {
/// Parse a value of this type.
///
/// Returns an error on failure.
- fn parse<'i, 't>(context: &ParserContext, input: &mut Parse... | 7 | 145 | 51 |
6c668a2ca1a749434fd1272d78a530a6d0e5b00b | Emilio Cobos Álvarez | 2017-12-15T17:28:16 | servo: Merge #19564 - style: Slightly simplify push_applicable_declarations (from emilio:push-applicable-simple); r=mbrubeck
Source-Repo: https://github.com/servo/servo
Source-Revision: 90290cfafed0bff88920fd286ea09656fd9e999f | diff --git a/style/stylist.rs b/style/stylist.rs
index 5147b2844..1cf306d12 100644
--- a/style/stylist.rs
+++ b/style/stylist.rs
@@ -1226,7 +1226,10 @@ impl Stylist {
debug!("Determining if style is shareable: pseudo: {}",
pseudo_element.is_some());
- let only_default_rules = rule_incl... | 1 | 19 | 20 |
8589d9584a92423a63b3e5a36999fc011075fd6a | Felipe Nakandakari | 2017-12-15T05:36:34 | servo: Merge #19570 - style: move list-style-image out of mako (from fenak:list-style-image-mako); r=emilio
<!-- Please describe your changes on the following line: -->
Moving `list-style-image` out of mako.
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, an... | diff --git a/style/properties/longhand/list.mako.rs b/style/properties/longhand/list.mako.rs
index 363f2a926..149bed1e0 100644
--- a/style/properties/longhand/list.mako.rs
+++ b/style/properties/longhand/list.mako.rs
@@ -95,45 +95,13 @@ ${helpers.single_keyword("list-style-position", "outside inside", animation_valu
... | 5 | 45 | 42 |
6cd8cf702bc34d5a40a4c53583a29d82496c1561 | Pyfisch | 2017-12-14T19:20:34 | servo: Merge #19554 - layout: support tiled gradients (from pyfisch:tiled-gradients1); r=mbrubeck
Use background-size, background-position properties to render
CSS gradients.
Some cleanup in display_list_builder.rs related to gradient
calculations.
Adds two wpt tests for tiled gradients.
Note: For now even gradient... | diff --git a/gfx/display_list/mod.rs b/gfx/display_list/mod.rs
index 9c8ef998f..98b78ef5c 100644
--- a/gfx/display_list/mod.rs
+++ b/gfx/display_list/mod.rs
@@ -720,6 +720,15 @@ pub struct GradientDisplayItem {
/// Contains all gradient data. Included start, end point and color stops.
pub gradient: Gradient... | 3 | 183 | 161 |
15d8c4605d1ac2732eb508858c694e9284237902 | Matt Brubeck | 2017-12-14T17:55:25 | servo: Merge #19562 - Make layout depend on style/servo feature (from mbrubeck:feature); r=emilio
This fixes an error when running commands like `./mach check -p layout`.
---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes do not require tests... | diff --git a/layout/Cargo.toml b/layout/Cargo.toml
index a25a6705e..28dca1eff 100644
--- a/layout/Cargo.toml
+++ b/layout/Cargo.toml
@@ -41,7 +41,7 @@ serde_json = "1.0"
servo_config = {path = "../config"}
servo_url = {path = "../url"}
smallvec = "0.6"
-style = {path = "../style"}
+style = {path = "../style", featur... | 1 | 1 | 1 |
2db27a09b47b82aed04153c4305935832a303273 | Emilio Cobos Álvarez | 2017-12-14T16:19:23 | servo: Merge #19558 - selectors: Manually inline any(..) in matches_selector_list (from emilio:sadness); r=heycam
Since the compiler refuses to inline the inner closure even with -O3, which is
sad :(.
Sad try run:
https://treeherder.mozilla.org/perf.html#/compare?originalProject=try&originalRevision=c2724c47e98f99... | diff --git a/selectors/matching.rs b/selectors/matching.rs
index d49d24ee0..1097c288c 100644
--- a/selectors/matching.rs
+++ b/selectors/matching.rs
@@ -72,14 +72,24 @@ pub fn matches_selector_list<E>(
where
E: Element
{
- selector_list.0.iter().any(|selector| {
- matches_selector(selector,
- ... | 1 | 18 | 8 |
6ea5caf929faf0e4fb08436f827ca777d83ac107 | Emilio Cobos Álvarez | 2017-12-14T07:39:38 | servo: Merge #19556 - Move list quotes out of mako (from emilio:quotes-mako); r=emilio
Rebase of https://github.com/servo/servo/pull/19154.
Source-Repo: https://github.com/servo/servo
Source-Revision: 26feea3be5bc70fed7a642ca768187d29469fee0 | diff --git a/layout/generated_content.rs b/layout/generated_content.rs
index 004bcf5d9..e838bde6b 100644
--- a/layout/generated_content.rs
+++ b/layout/generated_content.rs
@@ -311,9 +311,9 @@ impl<'a, 'b> ResolveGeneratedContentFragmentMutator<'a, 'b> {
"es.0[self.traversal.quote as usize]
... | 7 | 114 | 74 |
4660f376142633b36bcd062042c3c321672f11d2 | Emilio Cobos Álvarez | 2017-12-14T06:22:45 | servo: Merge #19541 - selectors: Add parsing support for ::slotted() (from emilio:parse-slotted); r=heycam
Without turning it on yet, of course.
The reason why I didn't use the general PseudoElement mechanism is because this
pseudo is a bit of its own thing, and I found easier to make ::selectors know
about it (becau... | diff --git a/selectors/builder.rs b/selectors/builder.rs
index c996a6a64..b3d61b347 100644
--- a/selectors/builder.rs
+++ b/selectors/builder.rs
@@ -264,12 +264,23 @@ fn complex_selector_specificity<Impl>(mut iter: slice::Iter<Component<Impl>>)
-> Specificity
where Impl: Sele... | 4 | 175 | 42 |
8b4a96bdf304a9cbcf503508c2c24155baa10e5f | Emilio Cobos Álvarez | 2017-12-14T04:47:38 | servo: Merge #19551 - style: Make anon boxes account for :visited (from emilio:anon-box-visited); r=heycam
This should fix one of the test failures of:
https://bugzilla.mozilla.org/show_bug.cgi?id=616436
Source-Repo: https://github.com/servo/servo
Source-Revision: c258bfb430fabc2ebc55db679a52f09c7df04b58 | diff --git a/style/stylist.rs b/style/stylist.rs
index 9f9335885..5147b2844 100644
--- a/style/stylist.rs
+++ b/style/stylist.rs
@@ -666,7 +666,7 @@ impl Stylist {
parent,
cascade_flags,
font_metrics,
- &rule_node
+ rule_node
)
}
@@ -679,37 +6... | 1 | 47 | 49 |
34a39c823ae07a4bac443685574351738faf1d82 | CYBAI | 2017-12-14T01:30:26 | servo: Merge #19548 - style: Move outline-style outside of mako (from CYBAI:move-outline-style-out-of-mako); r=emilio
This is a sub-PR of #19015
r? emilio
---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #19546
- [x] These changes do no... | diff --git a/layout/display_list_builder.rs b/layout/display_list_builder.rs
index 1bcd251b8..efe07fd57 100644
--- a/layout/display_list_builder.rs
+++ b/layout/display_list_builder.rs
@@ -1700,7 +1700,7 @@ impl FragmentDisplayListBuilding for Fragment {
style: &Comp... | 7 | 84 | 53 |
6c168320f5ddbd42f08eb499e86a7f50cb1d88be | Manish Goregaokar | 2017-12-12T16:14:31 | servo: Merge #19549 - Add telemetry probe for measuring frequency of parallel restyles (from Manishearth:telemetry); r=emilio
Servo side of https://bugzilla.mozilla.org/show_bug.cgi?id=1421195
r=emilio
Source-Repo: https://github.com/servo/servo
Source-Revision: 80341b291b3c1f0d423d8b8ab4eb8b1e78e03f2a | diff --git a/style/context.rs b/style/context.rs
index 7b58bfa7d..6c9ba7b47 100644
--- a/style/context.rs
+++ b/style/context.rs
@@ -116,6 +116,21 @@ impl Default for StyleSystemOptions {
}
}
+impl StyleSystemOptions {
+ #[cfg(feature = "servo")]
+ /// On Gecko's nightly build?
+ pub fn is_nightly(&sel... | 5 | 96 | 9 |
392054c1dd9b2fc3686a52896564122fb1556653 | Simon Sapin | 2017-12-10T02:00:23 | servo: Merge #19540 - Check that 'style' is compiled in a supported configuration (from servo:style-features); r=emilio
Provide an explanatory error message when the compilation would fail because of missing or duplicate items.
Source-Repo: https://github.com/servo/servo
Source-Revision: 29d960ee5c043ba87ec0da565b5d6... | diff --git a/style/build.rs b/style/build.rs
index e34fa79cc..517c65f99 100644
--- a/style/build.rs
+++ b/style/build.rs
@@ -94,6 +94,15 @@ fn generate_properties() {
}
fn main() {
+ let gecko = cfg!(feature = "gecko");
+ let servo = cfg!(feature = "servo");
+ if !(gecko || servo) {
+ panic!("The st... | 1 | 9 | 0 |
daad5cd60067d49bf440a6abfa77f735011831a9 | Emilio Cobos Álvarez | 2017-12-09T23:15:14 | servo: Merge #19536 - style: Move the code to parse a list of compound selectors (from emilio:compound-selector-list); r=mbrubeck
I'll need this for ::slotted().
Source-Repo: https://github.com/servo/servo
Source-Revision: c6bf85eca90b9cb71ff05d4454a43a7da5fc3ac8 | diff --git a/selectors/parser.rs b/selectors/parser.rs
index ff9f45eac..cf8464876 100644
--- a/selectors/parser.rs
+++ b/selectors/parser.rs
@@ -55,6 +55,7 @@ pub enum SelectorParseErrorKind<'i> {
EmptySelector,
DanglingCombinator,
NonSimpleSelectorInNegation,
+ NonCompoundSelector,
UnexpectedTok... | 2 | 35 | 11 |
1ae9ec42eeced5f4712a0f257dfbf4d3a9b6576c | Emilio Cobos Álvarez | 2017-12-09T21:27:49 | servo: Merge #19533 - style: Remove unused SelectorImpl::pseudo_element_cascade_type (from emilio:unused-code-should-die); r=emilio
Source-Repo: https://github.com/servo/servo
Source-Revision: 95520ca39c4dde7296584227d49d70615dda0bf0 | diff --git a/style/gecko/selector_parser.rs b/style/gecko/selector_parser.rs
index 0c8e189fa..4da4d9c9c 100644
--- a/style/gecko/selector_parser.rs
+++ b/style/gecko/selector_parser.rs
@@ -9,7 +9,7 @@ use element_state::{DocumentState, ElementState};
use gecko_bindings::structs::CSSPseudoClassType;
use gecko_bindings... | 2 | 1 | 13 |
8b3d26e62eb12bd075f5f8a837f3ed324a4c1077 | Emilio Cobos Álvarez | 2017-12-09T19:58:25 | servo: Merge #19538 - Use ? in Option more often (from emilio:questions-questions-questions); r=mbrubeck
Source-Repo: https://github.com/servo/servo
Source-Revision: 548028fd07d85dbbbd0511386f88ea19825dc258 | diff --git a/constellation/browsingcontext.rs b/constellation/browsingcontext.rs
index 938cf5ef0..a7d617164 100644
--- a/constellation/browsingcontext.rs
+++ b/constellation/browsingcontext.rs
@@ -167,10 +167,7 @@ impl<'a> Iterator for FullyActiveBrowsingContextsIterator<'a> {
type Item = &'a BrowsingContext;
... | 8 | 25 | 62 |
c152e6c1eac099b504cf9919946029e81d981f5a | Matt Brubeck | 2017-12-09T16:50:55 | servo: Merge #19537 - style: Use the ? operator for Option (from mbrubeck:try); r=nox
This is stable in Rust 1.22 (#19532).
---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes do not require tests because it is refactoring only
Source-Repo: ... | diff --git a/layout/fragment.rs b/layout/fragment.rs
index 75b49c14a..548c1636e 100644
--- a/layout/fragment.rs
+++ b/layout/fragment.rs
@@ -1750,22 +1750,17 @@ impl Fragment {
let character_breaking_strategy =
text_fragment_info.run.character_slices_in_range(&text_fragment_info.range);
- ... | 13 | 47 | 129 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.