commit_hash stringlengths 40 40 | author stringlengths 1 57 | date timestamp[s]date 2010-07-26 04:45:09 2026-04-14 18:21:10 | message stringlengths 8 1.39M | diff stringlengths 68 51.2k | files_changed int64 1 136 | insertions int64 0 2.35k | deletions int64 0 1.9k |
|---|---|---|---|---|---|---|---|
f8f736927946b8fcd079f0ee177e9dbae066fa11 | Emilio Cobos Álvarez | 2018-02-16T20:33:48 | servo: Merge #20065 - style: Cleanup GeckoElement::note_explicit_hints (from emilio:note-stuff); r=nox
What it's doing is not so complicated.
Source-Repo: https://github.com/servo/servo
Source-Revision: d423e54d58d6cced950896eed1957ee2989f4eee | diff --git a/style/gecko/wrapper.rs b/style/gecko/wrapper.rs
index 8dd52eb45..adac5713c 100644
--- a/style/gecko/wrapper.rs
+++ b/style/gecko/wrapper.rs
@@ -692,33 +692,14 @@ impl<'le> GeckoElement<'le> {
unsafe { Gecko_GetDocumentLWTheme(node.owner_doc().0) }
}
- /// Only safe to call on the main th... | 1 | 30 | 41 |
0915de42249a373a0cdace10abc960804bbd87e3 | Emilio Cobos Álvarez | 2018-02-16T19:43:50 | servo: Merge #20064 - style: Trivially cleanup length parsing (from emilio:cleanup-length-parsing); r=nox
Mostly formatting signatures properly, but also removing useless functions and
stuff.
Source-Repo: https://github.com/servo/servo
Source-Revision: d092c2e877fdbae241d6f4b53d61701d7d50e346 | diff --git a/style/parser.rs b/style/parser.rs
index df8551bff..04e9204c9 100644
--- a/style/parser.rs
+++ b/style/parser.rs
@@ -113,6 +113,12 @@ impl<'a> ParserContext<'a> {
}
}
+ /// Whether we're in a @page rule.
+ #[inline]
+ pub fn in_page_rule(&self) -> bool {
+ self.rule_type.map_... | 3 | 43 | 37 |
b13ca695a19cde30dc320c4c7571dba76b68815e | Anthony Ramine | 2018-02-16T18:09:28 | servo: Merge #20062 - Remove a single use of rooted_vec (from servo:iamroot); r=emilio
Source-Repo: https://github.com/servo/servo
Source-Revision: e97693ee097cf293178bcc51b4614820331b4d47 | diff --git a/script/dom/document.rs b/script/dom/document.rs
index 47ba21c8e..abe67fc34 100644
--- a/script/dom/document.rs
+++ b/script/dom/document.rs
@@ -107,6 +107,7 @@ use net_traits::request::RequestInit;
use net_traits::response::HttpsState;
use num_traits::ToPrimitive;
use profile_traits::time::{TimerMetadat... | 1 | 2 | 3 |
179e4eeb601ef7e86298cf78354b05b6fabcb7a5 | Nupur Baghel | 2018-02-16T17:16:55 | servo: Merge #20041 - Added extra bool in Window object to know about its Mutation Observers (from paavininanda:mutflags); r=jdm
<!-- Please describe your changes on the following line: -->
- Added Cell<bool> type variable in Window object to know whether its mutation observers are present/absent
- Added get and set f... | diff --git a/script/dom/mutationobserver.rs b/script/dom/mutationobserver.rs
index 5aee5adec..902f0dcce 100644
--- a/script/dom/mutationobserver.rs
+++ b/script/dom/mutationobserver.rs
@@ -9,7 +9,7 @@ use dom::bindings::codegen::Bindings::MutationObserverBinding::MutationCallback;
use dom::bindings::codegen::Bindings:... | 2 | 17 | 1 |
b5108d29fd21cf3cc6ea7a1009eb919c4e6832cd | Fernando Jiménez Moreno | 2018-02-16T10:38:38 | servo: Merge #20054 - Implement element.innerText setter (from ferjm:innertext.setter); r=emilio
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #16107
- [X] There are tests for these changes
Source-Repo: https://github.com/servo/servo
Sou... | diff --git a/script/dom/htmlelement.rs b/script/dom/htmlelement.rs
index ec9b3973c..12dc0d1c1 100644
--- a/script/dom/htmlelement.rs
+++ b/script/dom/htmlelement.rs
@@ -17,10 +17,12 @@ use dom::bindings::root::{Dom, DomRoot, MutNullableDom, RootedReference};
use dom::bindings::str::DOMString;
use dom::cssstyledeclara... | 1 | 58 | 2 |
f6ccf8eb4e6779c4fff84bdc42ec407472b404ac | Emilio Cobos Álvarez | 2018-02-15T19:57:52 | servo: Merge #20056 - style: Remove -moz-user-input: enabled / disabled (from emilio:moz-user-input); r=bz
https://groups.google.com/d/msg/mozilla.dev.platform/E6tfP__wkwg/YVW6nPX9CQA
Bug: 1405087
Reviewed-by: bz
Source-Repo: https://github.com/servo/servo
Source-Revision: ff58cb0a3f19df7f0a12476a68407a65702f3c20 | diff --git a/style/gecko/generated/structs.rs b/style/gecko/generated/structs.rs
index 5762d067e..ec899494f 100644
--- a/style/gecko/generated/structs.rs
+++ b/style/gecko/generated/structs.rs
@@ -4973,9 +4973,7 @@ pub mod root {
#[derive(Debug, Copy, Clone, PartialEq, Eq, Hash)]
pub enum StyleUserInp... | 2 | 2 | 4 |
daf4618792bb31540b9b26ee501598e8e0409b86 | Anthony Ramine | 2018-02-15T11:26:02 | servo: Merge #20047 - Move some font code around (from servo:derive-all-the-things); r=emilio
The only notable change is that KeywordInfo is now generic.
Source-Repo: https://github.com/servo/servo
Source-Revision: 0baab064df950cff65ce76dc5f134e2cd4c7413b | diff --git a/style/gecko/rules.rs b/style/gecko/rules.rs
index 599cdf81e..ce448cddf 100644
--- a/style/gecko/rules.rs
+++ b/style/gecko/rules.rs
@@ -21,7 +21,8 @@ use std::fmt::{self, Write};
use std::str;
use str::CssStringWriter;
use values::computed::font::FamilyName;
-use values::specified::font::{FontTag, FontV... | 12 | 213 | 191 |
3dbe5911889277d923ab6531d123fbe335321cae | Emilio Cobos Álvarez | 2018-02-14T20:09:30 | servo: Merge #20049 - style: Cleanup serialization a bit (from emilio:cleanup-serialization-a-bit); r=SimonSapin
Mostly minor cleanups, in preparation for more refactoring.
Source-Repo: https://github.com/servo/servo
Source-Revision: 6f82110c92e3d0f1e00df68d19f51c9321b97126 | diff --git a/style/properties/declaration_block.rs b/style/properties/declaration_block.rs
index 8612c1244..2be09150e 100644
--- a/style/properties/declaration_block.rs
+++ b/style/properties/declaration_block.rs
@@ -304,64 +304,72 @@ impl PropertyDeclarationBlock {
})
}
+ fn shorthand_to_css(
+ ... | 1 | 216 | 223 |
8dfd22cca5d75ff9f79945b44f68db9b0f1e9bc0 | Emilio Cobos Álvarez | 2018-02-14T18:23:07 | servo: Merge #20046 - style: Move most of allowed_in to NonCustomPropertyId (from emilio:less-dumb); r=nox
Also simplify the servo property id to gecko property id conversion to be faster
and less repetitive.
This is in preparation of some patches to properly allow disabled longhands on enabled shorthands, something ... | diff --git a/style/properties/properties.mako.rs b/style/properties/properties.mako.rs
index fb3281348..e74cad343 100644
--- a/style/properties/properties.mako.rs
+++ b/style/properties/properties.mako.rs
@@ -413,10 +413,112 @@ pub mod animated_properties {
<%include file="/helpers/animated_properties.mako.rs" />
... | 1 | 108 | 125 |
ac1baccf9ea538b8b42b69ab15f85d13d9802020 | Anthony Ramine | 2018-02-14T10:48:10 | servo: Merge #20040 - Change how some clamped types are animated (from servo:derive-all-the-things); r=emilio
Source-Repo: https://github.com/servo/servo
Source-Revision: 112bb55b921dc53b519c85138f64d5701f2c4d2d | diff --git a/style/properties/helpers/animated_properties.mako.rs b/style/properties/helpers/animated_properties.mako.rs
index b44bc15c4..0d6fa24af 100644
--- a/style/properties/helpers/animated_properties.mako.rs
+++ b/style/properties/helpers/animated_properties.mako.rs
@@ -55,7 +55,6 @@ use values::distance::{Comput... | 8 | 72 | 95 |
3c5a4e67e74a93e5bc8e2a489ea67850b7c55c59 | Xidorn Quan | 2018-02-14T07:19:22 | servo: Merge #20044 - Remove initial values from font-face descriptors (from upsuper:font-face-initial); r=SimonSapin
They are not used anyway.
Source-Repo: https://github.com/servo/servo
Source-Revision: 9f3ce51d50401ed6a2472e7d020ba9dcc47fa9a9 | diff --git a/style/font_face.rs b/style/font_face.rs
index c648d8d50..27d8d4f1e 100644
--- a/style/font_face.rs
+++ b/style/font_face.rs
@@ -331,8 +331,7 @@ macro_rules! font_face_descriptors {
$( #[$m_doc: meta] $m_name: tt $m_ident: ident / $m_gecko_ident: ident: $m_ty: ty, )*
]
optiona... | 1 | 10 | 29 |
6fd1978c2e1979aa84342be95a92e3bd5a43405d | Xidorn Quan | 2018-02-14T00:16:34 | servo: Merge #20042 - Integrate font-variation-settings descriptor with stylo (from upsuper:font-variation-desc); r=emilio
This is the Servo side change for [bug 1435984](https://bugzilla.mozilla.org/show_bug.cgi?id=1435984).
Source-Repo: https://github.com/servo/servo
Source-Revision: 27cd4f7b5387f188570a355c58bf87b... | diff --git a/style/font_face.rs b/style/font_face.rs
index b0ef8afab..c648d8d50 100644
--- a/style/font_face.rs
+++ b/style/font_face.rs
@@ -26,7 +26,7 @@ use style_traits::{Comma, CssWriter, OneOrMoreSeparated, ParseError};
use style_traits::{StyleParseErrorKind, ToCss};
use values::computed::font::FamilyName;
#[cf... | 5 | 80 | 17 |
74219a11418f5da0e8bebef2098c34200b0eb825 | Xidorn Quan | 2018-02-12T23:21:47 | servo: Merge #20033 - Output unquoted family name as a series of identifiers (from upsuper:font-space); r=emilio
It tries to serialize unquoted family names as a series of identifiers. For family names which contain special white spaces like leading white space, trailing white space, and consective white spaces, unquo... | diff --git a/style/values/computed/font.rs b/style/values/computed/font.rs
index 646f91155..63b18bb35 100644
--- a/style/values/computed/font.rs
+++ b/style/values/computed/font.rs
@@ -286,10 +286,20 @@ impl ToCss for FamilyName {
write!(CssStringWriter::new(dest), "{}", self.name)?;
d... | 1 | 26 | 17 |
8956f7830570df7db035923d20f693c7b5d7e54b | paavininanda | 2018-02-12T16:56:27 | servo: Merge #19963 - Correct default SelectionStart and SelectionEnd (from paavininanda:Issue#19958); r=<try>
<!-- Please describe your changes on the following line: -->
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data... | diff --git a/script/dom/htmlformelement.rs b/script/dom/htmlformelement.rs
index 27a64d00c..36ebb18db 100755
--- a/script/dom/htmlformelement.rs
+++ b/script/dom/htmlformelement.rs
@@ -651,7 +651,7 @@ impl HTMLFormElement {
child.downcast::<HTMLSelectElement>().unwrap().reset();
}
... | 4 | 92 | 80 |
930146b1ea0e4963c0e628cd22ccf61e45082b3d | Anthony Ramine | 2018-02-12T15:46:42 | servo: Merge #20025 - Merge similar arms in AnimationValue::from_declaration 🐉🐲 (from servo:derive-all-the-things); r=emilio
This slims that function by 12KB according to bloaty.
Source-Repo: https://github.com/servo/servo
Source-Revision: e0b38f9c49157bbe885193fb9754a2790cc141ec | diff --git a/style/properties/helpers/animated_properties.mako.rs b/style/properties/helpers/animated_properties.mako.rs
index 281d9c53f..b44bc15c4 100644
--- a/style/properties/helpers/animated_properties.mako.rs
+++ b/style/properties/helpers/animated_properties.mako.rs
@@ -547,37 +547,58 @@ impl AnimationValue {
... | 1 | 49 | 28 |
876b7b202dc6ffff4b2018731ab62b8f3bcdd4f3 | Emilio Cobos Álvarez | 2018-02-12T13:47:36 | servo: Merge #20030 - style: Remove useless code after #19994 (from emilio:useless-return-is-useless); r=nox
Source-Repo: https://github.com/servo/servo
Source-Revision: 3a42f6f988c4bfb1847ed8dbb7a0013c6b2e528a | diff --git a/style/gecko/data.rs b/style/gecko/data.rs
index ff9e8ae1c..4107fb5c9 100644
--- a/style/gecko/data.rs
+++ b/style/gecko/data.rs
@@ -148,14 +148,6 @@ impl PerDocumentStyleData {
}
}
-impl Drop for PerDocumentStyleDataImpl {
- fn drop(&mut self) {
- if !structs::GECKO_IS_NIGHTLY {
- ... | 1 | 0 | 8 |
4e70e62e915b9ca447fe973abd5191acfa03a416 | Emilio Cobos Álvarez | 2018-02-12T12:36:04 | servo: Merge #20027 - style: Back out ordermap (from emilio:bye-ordermap); r=nox
It was worth a shot!
Source-Repo: https://github.com/servo/servo
Source-Revision: 889bb012efe1bdb08ce85b14b49104a76c4b53f0 | diff --git a/hashglobe/Cargo.toml b/hashglobe/Cargo.toml
index 6122b24ce..6deb04a75 100644
--- a/hashglobe/Cargo.toml
+++ b/hashglobe/Cargo.toml
@@ -11,7 +11,6 @@ readme = "README.md"
[dependencies]
libc = "0.2"
-ordermap = "0.3"
[dev-dependencies]
rand = "0.3"
diff --git a/hashglobe/src/lib.rs b/hashglobe/src/... | 7 | 3 | 376 |
a40915b89523dc184442f8eb1184d5c82767f4e7 | Emilio Cobos Álvarez | 2018-02-12T11:03:30 | servo: Merge #20026 - style: Use more CascadeData and less Stylist for XBL stuff (from emilio:less-stylist-xbl); r=upsuper
Just some more use-cases that can be converted right away.
I'm trying to make XBL not use a whole Stylist, slowly...
Source-Repo: https://github.com/servo/servo
Source-Revision: 63691f01d79874aa... | diff --git a/style/dom.rs b/style/dom.rs
index 0a5733303..81c1e89da 100644
--- a/style/dom.rs
+++ b/style/dom.rs
@@ -31,7 +31,7 @@ use std::fmt;
use std::fmt::Debug;
use std::hash::Hash;
use std::ops::Deref;
-use stylist::{CascadeData, Stylist};
+use stylist::CascadeData;
use traversal_flags::TraversalFlags;
///... | 3 | 23 | 35 |
6982f924cb6b3766546ef7cc77922ef17b65dc2d | Anthony Ramine | 2018-02-11T23:43:17 | servo: Merge #20017 - Optimise more AnimationValue methods 🐉🐲 (from servo:derive-all-the-things); r=emilio
Optimise more AnimationValue methods 🐉🐲
```
__TEXT __DATA __OBJC others dec hex
87101440 5226496 0 64122880 156450816 9534000 XUL.old
87072768 5226496 0 64122880 156422144 952d000 XUL.new
```
Source-Repo: h... | diff --git a/style/properties/helpers/animated_properties.mako.rs b/style/properties/helpers/animated_properties.mako.rs
index ba0eb9500..281d9c53f 100644
--- a/style/properties/helpers/animated_properties.mako.rs
+++ b/style/properties/helpers/animated_properties.mako.rs
@@ -24,11 +24,11 @@ use properties::longhands::... | 2 | 126 | 22 |
126a2df56e086835d62f5303ea05dd570679b2fc | Nupur Baghel | 2018-02-11T19:10:48 | servo: Merge #20019 - Added derive(ToCss) for Content and removed manual implementation (from paavininanda:deriveToCss); r=emilio
Added derive(ToCss) annotation : WIP
<!-- Please describe your changes on the following line: -->
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the... | diff --git a/style/values/computed/counters.rs b/style/values/computed/counters.rs
index 71fecc394..a1b1b7874 100644
--- a/style/values/computed/counters.rs
+++ b/style/values/computed/counters.rs
@@ -146,28 +146,6 @@ impl Parse for Content {
}
}
-impl ToCss for Content {
- fn to_css<W>(&self, dest: &mut Css... | 2 | 2 | 23 |
69693a0e968d812c631ed6333a2e662cb165c517 | Emilio Cobos Álvarez | 2018-02-11T18:19:02 | servo: Merge #20018 - style: Handle quirks-mode changes correctly (from emilio:quirks-mode-flush); r=xidorn
The reason why bug 1355721 regressed this is because in non-e10s we definitely
flush before parsing the standards quirks-mode. And bug 1355721 introduced an
unconditional UpdateStylistIfNeeded, unless the counte... | diff --git a/style/stylist.rs b/style/stylist.rs
index 18e5fb4c7..56f7f4b2f 100644
--- a/style/stylist.rs
+++ b/style/stylist.rs
@@ -77,6 +77,9 @@ impl UserAgentCascadeDataCache {
}
}
+ // FIXME(emilio): This may need to be keyed on quirks-mode too, though there
+ // aren't class / id selectors on... | 1 | 7 | 6 |
0a9d8e628e58e82e1da2c06f3e4b870fd63f9e9c | Jonathan Kew | 2018-02-11T11:57:22 | servo: Merge #20016 - Remove reference to the Gecko pref svg.paint-order.enabled (from jfkthame:master); r=bholley
<!-- Please describe your changes on the following line: -->
This pref (to potentially disable support for a CSS property) is to be removed from Gecko, so we should also remove the reference to it in the ... | diff --git a/style/properties/longhand/inherited_svg.mako.rs b/style/properties/longhand/inherited_svg.mako.rs
index 72189e344..f03d6a8ac 100644
--- a/style/properties/longhand/inherited_svg.mako.rs
+++ b/style/properties/longhand/inherited_svg.mako.rs
@@ -133,7 +133,6 @@ ${helpers.predefined_type("marker-end", "UrlOrN... | 1 | 0 | 1 |
0672c6b38427c2ed0a3b41abf49de975c619deff | Emilio Cobos Álvarez | 2018-02-10T12:46:38 | servo: Merge #20010 - style: Cascade pres hints after normal user rules (from emilio:pres-hints-cascade); r=bholley
Per https://drafts.csswg.org/css-cascade/#preshint and
https://html.spec.whatwg.org/#presentational-hints.
This was causing failures in the link color reftests with the preferences sheet
as a User sheet... | diff --git a/style/rule_tree/mod.rs b/style/rule_tree/mod.rs
index 9c710f07c..0ff2dbf28 100644
--- a/style/rule_tree/mod.rs
+++ b/style/rule_tree/mod.rs
@@ -472,22 +472,28 @@ impl RuleTree {
/// where it likely did not result from a rigorous performance analysis.)
const RULE_TREE_GC_INTERVAL: usize = 300;
-/// The ... | 2 | 43 | 33 |
411fd2526e6acb87b3967b273afe4a0315d88221 | Emilio Cobos Álvarez | 2018-02-10T11:45:52 | servo: Merge #20011 - style: Tidy Stylist::compute_for_declarations (from emilio:cleanup-for-declarations-stuff); r=Manishearth
Source-Repo: https://github.com/servo/servo
Source-Revision: 0098d519030f395f94f3f82fc04b93227fdff4ec | diff --git a/style/stylist.rs b/style/stylist.rs
index 029adf11f..201846820 100644
--- a/style/stylist.rs
+++ b/style/stylist.rs
@@ -1494,19 +1494,16 @@ impl Stylist {
E: TElement,
{
use font_metrics::get_metrics_provider_for_product;
+ use std::iter;
// FIXME(emilio): Why do we... | 1 | 5 | 8 |
a00786dbc688dbfeeb7aa1e45fbc085b1f2317f2 | Xidorn Quan | 2018-02-10T08:59:43 | servo: Merge #20013 - Return whether property was removed from Servo_DeclarationBlock_RemoveProperty (from upsuper:remove-prop-bool); r=bzbarsky
This is the Servo side change of [bug 1435139](https://bugzilla.mozilla.org/show_bug.cgi?id=1435139).
Source-Repo: https://github.com/servo/servo
Source-Revision: afaa51b993... | diff --git a/style/gecko/generated/bindings.rs b/style/gecko/generated/bindings.rs
index cad7e4054..ebd39c6bb 100644
--- a/style/gecko/generated/bindings.rs
+++ b/style/gecko/generated/bindings.rs
@@ -2840,7 +2840,7 @@ extern "C" {
pub fn Servo_DeclarationBlock_RemoveProperty(
declarations: RawServoDeclar... | 1 | 1 | 1 |
5bf1e0961e59468ab03872a13db36da1096c0f79 | Emilio Cobos Álvarez | 2018-02-09T22:18:08 | servo: Merge #20004 - style: Add infrastructure to have a standalone author stylesheet collection (from emilio:author-sheet-collection); r=nox
Right now Gecko uses a whole `Stylist` for stuff like XBL / Shadow DOM.
That's not great, because it has tons of unrelated logic, and also eats up a lot of memory. Also, it pr... | diff --git a/script/dom/bindings/trace.rs b/script/dom/bindings/trace.rs
index 97d9f0626..f49304065 100644
--- a/script/dom/bindings/trace.rs
+++ b/script/dom/bindings/trace.rs
@@ -105,7 +105,7 @@ use style::media_queries::MediaList;
use style::properties::PropertyDeclarationBlock;
use style::selector_parser::{Pseudo... | 5 | 335 | 281 |
c728819378160d7340287406bef9ad45dda98b43 | Emilio Cobos Álvarez | 2018-02-09T11:32:39 | servo: Merge #20003 - style: Remove unneeded clone (from emilio:simplify-font-family-serialize); r=nox
Source-Repo: https://github.com/servo/servo
Source-Revision: f8ac623047085fbb46eab44f6ad7682a45f032b7 | diff --git a/style/values/computed/font.rs b/style/values/computed/font.rs
index 31bd859dd..646f91155 100644
--- a/style/values/computed/font.rs
+++ b/style/values/computed/font.rs
@@ -475,7 +475,7 @@ impl SingleFontFamily {
let mut serialization = String::new();
serialize_atom_identif... | 1 | 1 | 1 |
02d0dd2ea31e0034779f784c7002300deea3e543 | Nupur Baghel | 2018-02-09T10:02:19 | servo: Merge #19972 - replaced content_type from DOCString to Mime (from paavininanda:Issue16483); r=jdm
Replaced content_type from DomString to Mime
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach bu... | diff --git a/script/dom/document.rs b/script/dom/document.rs
index 0ed2c25ff..8df8ba23d 100644
--- a/script/dom/document.rs
+++ b/script/dom/document.rs
@@ -98,6 +98,7 @@ use ipc_channel::ipc::{self, IpcSender};
use js::jsapi::{JSContext, JSObject, JSRuntime};
use js::jsapi::JS_GetRuntime;
use metrics::{InteractiveF... | 6 | 23 | 21 |
08eaefbd43663404e4d1584bdcfd6df149f32cc8 | Pyfisch | 2018-02-08T19:02:32 | servo: Merge #19942 - Use Rect::inner_rect from euclid (from pyfisch:update-euclid); r=emilio
Update euclid.
Source-Repo: https://github.com/servo/servo
Source-Revision: cd663ea33263aaf359bc3d4f78635d1ddfef34c2 | diff --git a/layout/Cargo.toml b/layout/Cargo.toml
index dac80d517..88552e1ce 100644
--- a/layout/Cargo.toml
+++ b/layout/Cargo.toml
@@ -16,7 +16,7 @@ app_units = "0.6.1"
atomic_refcell = "0.1"
bitflags = "1.0"
canvas_traits = {path = "../canvas_traits"}
-euclid = "0.16"
+euclid = "0.16.4"
fnv = "1.0"
gfx = {path ... | 2 | 19 | 45 |
c346723c7f08030c6b2385c6e5e7eb8460cf90ea | Brad Werth | 2018-02-08T19:00:56 | Bug 1265342 Part 0: Servo changes to add shape-margin. r=xidorn
MozReview-Commit-ID: 99pLZsFA9mj | diff --git a/style/properties/longhand/box.mako.rs b/style/properties/longhand/box.mako.rs
index 806afcbd1..026a3ca79 100644
--- a/style/properties/longhand/box.mako.rs
+++ b/style/properties/longhand/box.mako.rs
@@ -660,9 +660,21 @@ ${helpers.predefined_type(
products="gecko",
gecko_pref="layout.css.shape-ou... | 1 | 12 | 0 |
916bf5b6997466747dcbd8c8bba34c5ec18a35ac | Bobby Holley | 2018-04-20T23:28:33 | Bug 1455784 - Update StyleSource to use ArcUnion. r=Manishearth
MozReview-Commit-ID: AT4sud9goGV | diff --git a/style/applicable_declarations.rs b/style/applicable_declarations.rs
index d4674fa1b..a1476917f 100644
--- a/style/applicable_declarations.rs
+++ b/style/applicable_declarations.rs
@@ -116,7 +116,7 @@ impl ApplicableDeclarationBlock {
level: CascadeLevel,
) -> Self {
ApplicableDeclara... | 5 | 89 | 101 |
98b7098e50e35173a68b151d0f3f453f5e1dccf9 | Bobby Holley | 2018-04-20T22:48:18 | Bug 1455784 - ArcUnion. r=Manishearth
MozReview-Commit-ID: Jxp2A7cj6CV | diff --git a/servo_arc/lib.rs b/servo_arc/lib.rs
index 04a76c642..b84ba8793 100644
--- a/servo_arc/lib.rs
+++ b/servo_arc/lib.rs
@@ -39,6 +39,7 @@ use std::convert::From;
use std::fmt;
use std::hash::{Hash, Hasher};
use std::iter::{ExactSizeIterator, Iterator};
+use std::marker::PhantomData;
use std::mem;
use std:... | 1 | 134 | 2 |
1fb1e38348f0494e08cae561a9eafbd889a667bc | dan-robertson | 2018-02-08T18:14:11 | servo: Merge #19965 - Improve Freetype font handling and font selection (from dan-robertson:freetype2); r=jdm
<!-- Please describe your changes on the following line: -->
This correctly implements the boldness and stretchiness properties for Freetype fonts. This also modifies the metric used to select fonts so that it... | diff --git a/gfx/font_template.rs b/gfx/font_template.rs
index 5c00b9e2c..b128ee220 100644
--- a/gfx/font_template.rs
+++ b/gfx/font_template.rs
@@ -40,13 +40,33 @@ impl FontTemplateDescriptor {
///
/// The smaller the score, the better the fonts match. 0 indicates an exact match. This must
/// be commut... | 1 | 24 | 4 |
d5faec7a7cde94f1889dcecf63815e1545742933 | Manish Goregaokar | 2018-02-08T13:10:09 | servo: Merge #19994 - Remove traversal telemetry (from Manishearth:rm-telemetry); r=upsuper
Source-Repo: https://github.com/servo/servo
Source-Revision: e654afbc3e47d97835328e6131ef51b2e27e3409 | diff --git a/style/driver.rs b/style/driver.rs
index 07beb6d40..4b5528703 100644
--- a/style/driver.rs
+++ b/style/driver.rs
@@ -7,7 +7,7 @@
#![deny(missing_docs)]
-use context::{StyleContext, ThreadLocalStyleContext, TraversalStatistics};
+use context::{StyleContext, ThreadLocalStyleContext};
use dom::{SendNode,... | 3 | 2 | 68 |
3f8dde24c80ff3ececb994e47f41b6f3113255d9 | Anthony Ramine | 2018-02-08T11:41:22 | servo: Merge #19985 - Derive ComputeSquaredDistance for animated filters (from servo:derive-these-things-too); r=emilio
Source-Repo: https://github.com/servo/servo
Source-Revision: c22baf58d06d19a9347993698fd70f9a4513bcb2 | diff --git a/style/properties/helpers/animated_properties.mako.rs b/style/properties/helpers/animated_properties.mako.rs
index feda38893..af32c77a6 100644
--- a/style/properties/helpers/animated_properties.mako.rs
+++ b/style/properties/helpers/animated_properties.mako.rs
@@ -2871,25 +2871,6 @@ impl ToAnimatedZero for ... | 3 | 16 | 20 |
e03dd011af9fafb7dc4d117e1ca5c5c87a02e95d | Noemi Erli | 2018-02-08T09:41:37 | Backed out changeset 24f85c628472 for failing in layout/style/test/test_value_storage.html on a CLOSED TREE | diff --git a/style/values/computed/font.rs b/style/values/computed/font.rs
index 1003fb422..31bd859dd 100644
--- a/style/values/computed/font.rs
+++ b/style/values/computed/font.rs
@@ -7,21 +7,20 @@
use Atom;
use app_units::Au;
use byteorder::{BigEndian, ByteOrder};
-use cssparser::{CssStringWriter, Parser};
+use cs... | 1 | 25 | 24 |
b596fc0470241a322dfc8ab6ffdd3d2242f92a2f | Xidorn Quan | 2018-02-08T02:43:36 | servo: Merge #19984 - Use atom for identifier media features (from upsuper:media-ident-atom); r=emilio
This is the Servo side change of [bug 1435944](https://bugzilla.mozilla.org/show_bug.cgi?id=1435944).
Source-Repo: https://github.com/servo/servo
Source-Revision: 0d7c2271c284bcc2d4bd005bd0e89f9a87eba636 | diff --git a/style/gecko/media_queries.rs b/style/gecko/media_queries.rs
index 94dc9271c..d96d4d687 100644
--- a/style/gecko/media_queries.rs
+++ b/style/gecko/media_queries.rs
@@ -7,7 +7,7 @@
use app_units::AU_PER_PX;
use app_units::Au;
use context::QuirksMode;
-use cssparser::{CssStringWriter, Parser, RGBA, Token,... | 1 | 9 | 16 |
ee5b0c1aedc92efbf5631b3fffbc825eefaf0d5f | Glenn Watson | 2018-02-08T01:32:19 | servo: Merge #19982 - Update WR (various transform, hit-testing related fixes) (from glennw:update-wr-fixes); r=emilio
Source-Repo: https://github.com/servo/servo
Source-Revision: ced67db82dbc926d83f98d4a49bd025b59270933 | diff --git a/layout_thread/lib.rs b/layout_thread/lib.rs
index d3a77d1e6..5585891a0 100644
--- a/layout_thread/lib.rs
+++ b/layout_thread/lib.rs
@@ -707,7 +707,7 @@ impl LayoutThread {
let mut txn = webrender_api::Transaction::new();
txn.scroll_node_with_id(
webren... | 1 | 1 | 1 |
f980bae0b14d0ef87835412653689fb5db5b2506 | Emilio Cobos Álvarez | 2018-02-08T00:39:54 | servo: Merge #19983 - style: Tweak font-family serialization so that it is simpler (from emilio:simplify-font-family-serialize); r=xidorn
In particular, every time that there's at least more than one identifier, switch
to quoted family name, since the reconstruction of the serialization will be
lossy anyway.
This all... | diff --git a/style/values/computed/font.rs b/style/values/computed/font.rs
index 31bd859dd..1003fb422 100644
--- a/style/values/computed/font.rs
+++ b/style/values/computed/font.rs
@@ -7,20 +7,21 @@
use Atom;
use app_units::Au;
use byteorder::{BigEndian, ByteOrder};
-use cssparser::{CssStringWriter, Parser, serializ... | 1 | 24 | 25 |
06477f66edb92c35b4f3eba301304d893b8fb451 | Emilio Cobos Álvarez | 2018-02-07T18:33:36 | servo: Merge #19974 - style: Optimize serialization of identifiers of length <= 16 🐉🐲 (from emilio:atom-serialization); r=nox
Much like we optimize to_ascii_lowercase.
Source-Repo: https://github.com/servo/servo
Source-Revision: a0e4ea9f56947e9e47397984566e3e0cb5c3561e | diff --git a/style/Cargo.toml b/style/Cargo.toml
index 16d46eb6e..cb4b93d19 100644
--- a/style/Cargo.toml
+++ b/style/Cargo.toml
@@ -21,7 +21,7 @@ gecko = ["nsstring", "num_cpus",
use_bindgen = ["bindgen", "regex", "toml"]
servo = ["serde", "style_traits/servo", "servo_atoms", "servo_config", "html5ever",
"... | 12 | 95 | 65 |
7644a4a771a7a8c2dc6e03eb7893535ca2dec2e2 | Emilio Cobos Álvarez | 2018-02-07T17:42:18 | servo: Merge #19981 - style: Derive ToCss for FontFamilyList (from emilio:nicer); r=nox
The extra reference in to_css is needed because the family list iterator returns
by value in Gecko.
Source-Repo: https://github.com/servo/servo
Source-Revision: 10552c23fc6c81b37bcfcba8f35430fc8d6a0ea8 | diff --git a/style/values/specified/font.rs b/style/values/specified/font.rs
index c823dca79..6d126def2 100644
--- a/style/values/specified/font.rs
+++ b/style/values/specified/font.rs
@@ -165,9 +165,10 @@ impl From<LengthOrPercentage> for FontSize {
}
/// Specifies a prioritized list of font family names or generi... | 2 | 3 | 22 |
76def96772e8240a55d559d79aa6b6aa9488555f | Pyfisch | 2018-02-07T12:11:41 | servo: Merge #19931 - Use LayoutRects for bounds and overflow in display lists (from pyfisch:float-bounds); r=mrobinson
Convert text runs to glyphs in display list builder.
Remove ComplexClippingRegion and use the WebRender type.
Source-Repo: https://github.com/servo/servo
Source-Revision: 03a1a014ae3f7feeb91246343c4... | diff --git a/gfx/display_list/mod.rs b/gfx/display_list/mod.rs
index 5d41ffa8a..86da27a0e 100644
--- a/gfx/display_list/mod.rs
+++ b/gfx/display_list/mod.rs
@@ -14,8 +14,7 @@
//! They are therefore not exactly analogous to constructs like Skia pictures, which consist of
//! low-level drawing primitives.
-use app_un... | 6 | 223 | 325 |
27bac48edc8691d3c7dcbc271da444a273d49e94 | janczer | 2018-02-07T11:20:36 | servo: Merge #19970 - Change debug assertions to specific ones (from janczer:change_debug_assertions); r=emilio
<!-- Please describe your changes on the following line: -->
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate dat... | diff --git a/compositing/touch.rs b/compositing/touch.rs
index 020afb8a2..fd4877ead 100644
--- a/compositing/touch.rs
+++ b/compositing/touch.rs
@@ -219,7 +219,7 @@ impl TouchHandler {
}
fn pinch_distance_and_center(&self) -> (f32, TypedPoint2D<f32, DevicePixel>) {
- debug_assert!(self.touch_count() ... | 21 | 51 | 51 |
ec84ecffc12682321cd5867268ff4624e619c96b | Emilio Cobos Álvarez | 2018-02-07T06:04:51 | servo: Merge #19969 - style: Fix interpolation of the gecko-size properties (from emilio:whoopsies); r=emilio
Followup to #19966 because, well...
The animation code should probably be more obvious.
Source-Repo: https://github.com/servo/servo
Source-Revision: cf4f89c36e4cd62b8833cfc968ccac055fb091dd | diff --git a/style/properties/longhand/position.mako.rs b/style/properties/longhand/position.mako.rs
index 818899ba7..6cb088a20 100644
--- a/style/properties/longhand/position.mako.rs
+++ b/style/properties/longhand/position.mako.rs
@@ -171,7 +171,7 @@ ${helpers.predefined_type("order", "Integer", "0",
"MozLen... | 1 | 4 | 4 |
c81b8d7305dc5d7d7c74a49c6ca16583f1818519 | Igor Gutorov | 2018-02-06T22:39:03 | servo: Merge #19957 - style: Move content property out of mako (from gootorov:move-counter-from-mako); r=emilio
<!-- Please describe your changes on the following line: -->
r? emilio
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appro... | diff --git a/layout/construct.rs b/layout/construct.rs
index bbbd9287e..3849e43ad 100644
--- a/layout/construct.rs
+++ b/layout/construct.rs
@@ -37,14 +37,12 @@ use script_layout_interface::{LayoutElementType, LayoutNodeType, is_image_data};
use script_layout_interface::wrapper_traits::{PseudoElementType, ThreadSafeLa... | 11 | 302 | 281 |
95b332b62ddf57f5951b0a57192cc258dab3bfb7 | Emilio Cobos Álvarez | 2018-02-06T21:42:23 | servo: Merge #19964 - style: Don't serialize default values of the font shorthand (from emilio:font-shorthand); r=nox
This makes us consistent with the old style system and Blink / WebKit.
Not adding a test because shorthands serialization is a mess... :(
Anyway, nothing like fixing bugs by removing code.
Bug: 1436... | diff --git a/style/properties/shorthand/font.mako.rs b/style/properties/shorthand/font.mako.rs
index 22bbe7d71..fc3f75f78 100644
--- a/style/properties/shorthand/font.mako.rs
+++ b/style/properties/shorthand/font.mako.rs
@@ -143,27 +143,14 @@
None
}
% endif
- enum SerializeFor {
- N... | 1 | 26 | 56 |
f2bb531bdf7592c904d53ffc5955043f005301d7 | paavininanda | 2018-02-06T20:11:54 | servo: Merge #19946 - Change Offset_to_text_point function and add unit tests (from paavininanda:Issue18613); r=jdm
<!-- Please describe your changes on the following line: -->
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate... | diff --git a/script/textinput.rs b/script/textinput.rs
index 937ab38ed..4d8479346 100644
--- a/script/textinput.rs
+++ b/script/textinput.rs
@@ -871,13 +871,12 @@ impl<T: ClipboardProvider> TextInput<T> {
fn offset_to_text_point(&self, abs_point: usize) -> TextPoint {
let mut index = abs_point;
l... | 1 | 3 | 4 |
213289d36dbf0cdbba1c73926dded0155fa9a39d | Anni Ryynänen | 2018-02-06T17:43:50 | servo: Merge #19948 - Remove indirect mozjs dependency from compositing (from anniryynanen:less-dependencies); r=jdm
<!-- Please describe your changes on the following line: -->
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate da... | diff --git a/malloc_size_of/lib.rs b/malloc_size_of/lib.rs
index d4c2656ae..bb6eddb62 100644
--- a/malloc_size_of/lib.rs
+++ b/malloc_size_of/lib.rs
@@ -56,9 +56,9 @@ extern crate smallbitvec;
extern crate smallvec;
#[cfg(feature = "servo")]
extern crate string_cache;
-#[cfg(feature = "servo")]
+#[cfg(feature = "url... | 1 | 25 | 25 |
54b3251365ab62ea41174c50f05c7502e013fce8 | Martin Robinson | 2018-02-06T14:12:58 | servo: Merge #19933 - Update WebRender (from mrobinson:update-wr); r=emilio
This allows servo to use the ExternalScrollId API from WebRender fixing
some issues related to duplicate scroll root ids.
Fixes #17176.
Fixes #19287.
Fixes #19648.
<!-- Please describe your changes on the following line: -->
---
<!-- Thank ... | diff --git a/compositing/compositor.rs b/compositing/compositor.rs
index e15f3ff26..58f735804 100644
--- a/compositing/compositor.rs
+++ b/compositing/compositor.rs
@@ -1171,19 +1171,15 @@ impl<Window: WindowMethods> IOCompositor<Window> {
fn send_viewport_rects(&self) {
let mut scroll_states_per_pipeline... | 15 | 103 | 117 |
e71dc9dd8fe2a766bdf472230eb1917e487a1897 | Emilio Cobos Álvarez | 2018-02-05T12:17:54 | servo: Merge #19953 - style: Various cleanups (from emilio:cleanup); r=wafflespeanut
See each commit for details.
Source-Repo: https://github.com/servo/servo
Source-Revision: 575fecf810f9ee0dcdb2976dafc8b6e5d1fc183c | diff --git a/style/custom_properties.rs b/style/custom_properties.rs
index 0aa43109a..a0c744977 100644
--- a/style/custom_properties.rs
+++ b/style/custom_properties.rs
@@ -8,6 +8,7 @@
use Atom;
use cssparser::{Delimiter, Parser, ParserInput, SourcePosition, Token, TokenSerializationType};
+use hash::map::Entry;
u... | 4 | 44 | 32 |
b7c0dfe0ede43987067372821ae901bc266298c0 | Emilio Cobos Álvarez | 2018-02-05T10:55:59 | servo: Merge #19954 - style: Optimize @keyframes / @font-face rule insertions (from emilio:insert-sheet); r=xidorn,hiro
style: Optimize @keyframes / @font-face rule insertions.
Bug: 1435214
Reviewed-by: xidorn,hiro
Source-Repo: https://github.com/servo/servo
Source-Revision: 2557274f7b3c1c5f31a7553ba62415055fdcb1b2 | diff --git a/style/gecko/generated/bindings.rs b/style/gecko/generated/bindings.rs
index 70fa007c4..2ab4e1542 100644
--- a/style/gecko/generated/bindings.rs
+++ b/style/gecko/generated/bindings.rs
@@ -1179,6 +1179,12 @@ extern "C" {
extern "C" {
pub fn Gecko_NoteAnimationOnlyDirtyElement(element: RawGeckoElementB... | 4 | 47 | 9 |
32b7d99a3d0be60adc67f6c7d02ba5ee4a3f4578 | Anthony Ramine | 2018-02-04T14:11:05 | servo: Merge #19945 - Simplify counter CSS properties (from servo:derive-all-the-things); r=emilio
Source-Repo: https://github.com/servo/servo
Source-Revision: 7f7a460a15debe21117f25042059d6f24b99beda | diff --git a/layout/flow.rs b/layout/flow.rs
index c21371b85..3f2b64827 100644
--- a/layout/flow.rs
+++ b/layout/flow.rs
@@ -1035,8 +1035,8 @@ impl BaseFlow {
}
}
- if !style.get_counters().counter_reset.get_values().is_empty() ||
- !style.ge... | 7 | 114 | 180 |
d494973d12eff0a768a459ce44e2e81832908afc | Emilio Cobos Álvarez | 2018-02-03T20:28:58 | servo: Merge #19941 - style: Handle correctly nested links (from emilio:cleanup-style-builder); r=emilio
Followup to #19935, since I'm dumb and missed some orange in my try run.
Source-Repo: https://github.com/servo/servo
Source-Revision: 2f8cd0fe22d835c4a02f8c7fcaf5c2e28ab0a846 | diff --git a/style/style_adjuster.rs b/style/style_adjuster.rs
index df80cb837..7a637dcf8 100644
--- a/style/style_adjuster.rs
+++ b/style/style_adjuster.rs
@@ -552,8 +552,15 @@ impl<'a, 'b: 'a> StyleAdjuster<'a, 'b> {
self.style.pseudo.is_none() &&
element.map_or(false, |e| e.is_link());
- ... | 1 | 8 | 1 |
d4b2db6a80074d0be42fb054c01df1b6ff0308af | Anthony Ramine | 2018-02-03T19:27:18 | servo: Merge #19938 - Simplify single_keyword (from servo:single-keyword); r=emilio
Source-Repo: https://github.com/servo/servo
Source-Revision: bad455138f6b796e0401a369b928717ca5edc6f9 | diff --git a/style/properties/helpers.mako.rs b/style/properties/helpers.mako.rs
index 411dea7a9..af6d97865 100644
--- a/style/properties/helpers.mako.rs
+++ b/style/properties/helpers.mako.rs
@@ -490,33 +490,6 @@
</%call>
</%def>
-<%def name="single_keyword(name, values, vector=False, **kwargs)">
- <%call e... | 3 | 88 | 104 |
8e7aa556f7cd9ffaa1d30edff204da015963e999 | Emilio Cobos Álvarez | 2018-02-03T17:24:23 | servo: Merge #19935 - style: Cleanup StyleBuilder (from emilio:cleanup-style-builder); r=nox
style: Cleanup StyleBuilder.
This is in preparation of a cascade optimization for custom properties.
This fixes various fishiness around our StyleBuilder stuff. In particular,
StyleBuilder::for_derived_style (renamed to for_... | diff --git a/style/matching.rs b/style/matching.rs
index 5145e26ec..89b60c990 100644
--- a/style/matching.rs
+++ b/style/matching.rs
@@ -336,7 +336,7 @@ trait PrivateMatchMethods: TElement {
// We need to cascade the children in order to ensure the correct
// propagation of inherited computed value ... | 8 | 95 | 104 |
c99084a305f721e032fce352a62e6d084bb8cad5 | Bobby Holley | 2018-02-01T18:59:35 | servo: Merge #19927 - Avoid stylist flushes when sheets are appended and then removed again before flusing layout (from bholley:sheet_flush_optimization); r=emilio
https://bugzilla.mozilla.org/show_bug.cgi?id=1434756
Source-Repo: https://github.com/servo/servo
Source-Revision: 0a8c58dce95da4a42afb82171055821f8aca05d9 | diff --git a/style/stylesheet_set.rs b/style/stylesheet_set.rs
index b50c18cf1..0c3a985c2 100644
--- a/style/stylesheet_set.rs
+++ b/style/stylesheet_set.rs
@@ -18,8 +18,11 @@ struct StylesheetSetEntry<S>
where
S: StylesheetInDocument + PartialEq + 'static,
{
+ /// The sheet.
sheet: S,
- dirty: bool,
... | 1 | 21 | 14 |
750f7550d9b38bbd366017a8dabf84b6d6798406 | Emilio Cobos Álvarez | 2018-02-01T16:27:57 | servo: Merge #19923 - style: Cleanup and remove unused / dubious Length stuff (from emilio:less-crappy-code); r=nox
style: Cleanup and remove unused / dubious Length stuff.
On top of #19918, turns out that the parse_numbers_are_pixels stuff is unused.
Source-Repo: https://github.com/servo/servo
Source-Revision: a070... | diff --git a/style/values/specified/length.rs b/style/values/specified/length.rs
index bd9524ec9..9ac32c208 100644
--- a/style/values/specified/length.rs
+++ b/style/values/specified/length.rs
@@ -11,7 +11,7 @@ use cssparser::{Parser, Token};
use euclid::Size2D;
use font_metrics::FontMetricsQueryResult;
use parser::... | 1 | 45 | 82 |
a447f613afcaad335a07cbca7c321a7b15d625d8 | Jonas Reinwald | 2018-02-01T15:42:40 | servo: Merge #19529 - style: moved css longhand counter-reset out of mako (from DonatJR:counter-reset-out-of-mako); r=emilio
<!-- Please describe your changes on the following line: -->
This is a sub-PR of #19015
Code does not yet compile with `build-geckolib`.
r? emilio
---
<!-- Thank you for contributing to Servo! ... | diff --git a/layout/flow.rs b/layout/flow.rs
index e42871dfa..c21371b85 100644
--- a/layout/flow.rs
+++ b/layout/flow.rs
@@ -1035,8 +1035,8 @@ impl BaseFlow {
}
}
- if !style.get_counters().counter_reset.0.is_empty() ||
- !style.get_counters(... | 10 | 239 | 150 |
4d86365fc21b4d9ab42783dff01925e5e5a74a06 | Mauricio Collares | 2018-02-01T14:24:12 | servo: Merge #19924 - style: Move border-image-repeat outside of mako (from emilio:bim); r=emilio
style: Move border-image-repeat outside of mako.
This is a rebased / nitpick-addressed / bug-fixed version of #19021, and with a commit from #19668 renaming the two `RepeatKeyword`s to different names.
Source-Repo: http... | diff --git a/layout/display_list/background.rs b/layout/display_list/background.rs
index 93cb2ea84..6019e20f9 100644
--- a/layout/display_list/background.rs
+++ b/layout/display_list/background.rs
@@ -21,7 +21,7 @@ use style::values::generics::background::BackgroundSize;
use style::values::generics::image::{Circle, El... | 10 | 139 | 99 |
3a78ea648e7e49b01e12c37dad90e2647df6aa05 | Emilio Cobos Álvarez | 2018-02-01T12:45:20 | servo: Merge #19918 - style: Refactor font-feature-settings and font-variation-settings (from emilio:font-stuff-is-a-mess); r=nox
This fixes all known issues with serialization and parsing of these two
properties, and in particular calc handling and such:
https://bugzilla.mozilla.org/show_bug.cgi?id=1434692
https... | diff --git a/style/font_face.rs b/style/font_face.rs
index 36361c27e..b0ef8afab 100644
--- a/style/font_face.rs
+++ b/style/font_face.rs
@@ -9,7 +9,7 @@
#![deny(missing_docs)]
#[cfg(feature = "gecko")]
-use computed_values::{font_feature_settings, font_stretch, font_style, font_weight};
+use computed_values::{font_... | 12 | 354 | 326 |
fd0c65895ccc89ccf5c69a54b5eaf4bd8b580892 | Anthony Ramine | 2018-02-01T11:52:08 | servo: Merge #19903 - Derive more Parse implementations (fixes #19827) (from servo:derive-all-the-things); r=emilio
Fixes #19827.
Source-Repo: https://github.com/servo/servo
Source-Revision: b4339ab5c8fc31d5eeb7e1fae55cab05e400ec9e | diff --git a/style/font_face.rs b/style/font_face.rs
index 1eae14e4a..36361c27e 100644
--- a/style/font_face.rs
+++ b/style/font_face.rs
@@ -67,13 +67,17 @@ impl ToCss for UrlSource {
/// A font-display value for a @font-face rule.
/// The font-display descriptor determines how a font face is displayed based
/// on ... | 29 | 330 | 343 |
8c27f04664b5a1a6e08363b2ca9e106558427777 | Emilio Cobos Álvarez | 2018-02-01T03:33:36 | servo: Merge #19912 - style: Temporarily use OrderMap on Gecko (from emilio:ordermap); r=Manishearth
This will allow us to discard std hash map as a source of crashes.
Source-Repo: https://github.com/servo/servo
Source-Revision: e6d9c251d1b9770aa520bf358b79d906a00d71bb | diff --git a/hashglobe/Cargo.toml b/hashglobe/Cargo.toml
index 6deb04a75..6122b24ce 100644
--- a/hashglobe/Cargo.toml
+++ b/hashglobe/Cargo.toml
@@ -11,6 +11,7 @@ readme = "README.md"
[dependencies]
libc = "0.2"
+ordermap = "0.3"
[dev-dependencies]
rand = "0.3"
diff --git a/hashglobe/src/lib.rs b/hashglobe/src/... | 8 | 375 | 10 |
e60f801aa6de2471dc1bdc37e43afaa699d11345 | Emilio Cobos Álvarez | 2018-01-31T18:37:33 | servo: Merge #19915 - stylo: Fix missing null terminator in error reporting code (from emilio:color-errors-whee); r=jdm
This was causing the patch in bug 1420026 to fail.
Source-Repo: https://github.com/servo/servo
Source-Revision: 4bd0590117d0c76d59a509287a07c3bb9c8321ae | diff --git a/style/error_reporting.rs b/style/error_reporting.rs
index b3661846c..c1446eaa0 100644
--- a/style/error_reporting.rs
+++ b/style/error_reporting.rs
@@ -13,6 +13,7 @@ use style_traits::ParseError;
use stylesheets::UrlExtraData;
/// Errors that can be encountered while parsing CSS.
+#[derive(Debug)]
pub... | 1 | 1 | 0 |
93851f8792fcdaff7a5090da795751986bd23602 | Simon Sapin | 2018-01-31T17:01:26 | servo: Merge #19914 - Remove #![deny(warnings)] (from servo:dont-deny); r=nox
We already have https://github.com/servo/servo/pull/19612 to deny warnings at the time of landing into master. But it’s not useful to break the build when later compiler with a more recent Rust version that has introduced new warnings:
http... | diff --git a/style/lib.rs b/style/lib.rs
index d789c1d33..8a343496e 100644
--- a/style/lib.rs
+++ b/style/lib.rs
@@ -23,7 +23,6 @@
//! [cssparser]: ../cssparser/index.html
//! [selectors]: ../selectors/index.html
-#![deny(warnings)]
#![deny(missing_docs)]
#![recursion_limit = "500"] // For define_css_keyword_e... | 1 | 0 | 1 |
66616649a8efde5052660c4dfe0ef5fad4e0daa5 | Jon Leighton | 2018-01-31T15:46:48 | servo: Merge #19909 - Refactor implementation of TextControl (from jonleighton:refactor-textcontrol); r=jdm
The intention here is to make the flow more explicit. I.e. rather than
calling `self.dom_select()` and relying on the programmer to
know/realise that this method is provided by a trait, we call
`self.selection()... | diff --git a/script/dom/htmlinputelement.rs b/script/dom/htmlinputelement.rs
index e70afde60..09309da74 100755
--- a/script/dom/htmlinputelement.rs
+++ b/script/dom/htmlinputelement.rs
@@ -32,7 +32,7 @@ use dom::mouseevent::MouseEvent;
use dom::node::{Node, NodeDamage, UnbindContext};
use dom::node::{document_from_no... | 3 | 112 | 95 |
0537c173bc7f880bf5c5963021eee2d87a1abffe | CYBAI | 2018-01-31T13:28:04 | servo: Merge #19465 - Implement GridTemplateAreas with reference counting (from CYBAI:refcount-template-area); r=emilio
Use `Arc` to implement refcounting for `GridTemplateAreas`
r? emilio
---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fi... | diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs
index b40fb81bc..64a729dad 100644
--- a/style/properties/gecko.mako.rs
+++ b/style/properties/gecko.mako.rs
@@ -2188,10 +2188,10 @@ fn static_assert() {
let mut refptr = unsafe {
UniqueRefPtr::from_addrefed(
- ... | 4 | 38 | 15 |
0366742bbab656d8664807a22d58ab96acbe9ffb | Emilio Cobos Álvarez | 2018-01-31T10:45:07 | servo: Merge #19911 - style: Make GeckoElement::has_class more specialized (from emilio:has-class); r=xidorn
Bug: 1431421
Reviewed-by: xidorn
MozReview-Commit-ID: 7LiSEamTCkX
Source-Repo: https://github.com/servo/servo
Source-Revision: c88dc51d03a81e9e405688ccd2baae75d61ffffd | diff --git a/style/gecko/generated/bindings.rs b/style/gecko/generated/bindings.rs
index 81200ed8b..70fa007c4 100644
--- a/style/gecko/generated/bindings.rs
+++ b/style/gecko/generated/bindings.rs
@@ -724,6 +724,13 @@ extern "C" {
classList: *mut *mut *mut nsAtom,
) -> u32;
}
+extern "C" {
+ pub fn Ge... | 4 | 40 | 31 |
18348a01cfa35d4b96a1848db7ba7eef541a8499 | Emilio Cobos Álvarez | 2018-01-31T09:53:13 | servo: Merge #19906 - style: justify-self does accept a <baseline-position> (from emilio:justify-self-whoops); r=nox
Unlike justify-content, as weird as it is.
Source-Repo: https://github.com/servo/servo
Source-Revision: 6101bdf72b4a5ebcc48b20c7558ae92da24c2f53 | diff --git a/style/values/specified/align.rs b/style/values/specified/align.rs
index 9e8d49dfe..94dd02506 100644
--- a/style/values/specified/align.rs
+++ b/style/values/specified/align.rs
@@ -302,10 +302,6 @@ impl SelfAlignment {
/// Returns whether this value is valid for both axis directions.
pub fn is_val... | 1 | 9 | 12 |
4a454dae562250db29ea7ca448bf9645af5ec4a8 | Glenn Watson | 2018-01-31T03:17:56 | servo: Merge #19910 - Add a workaround for headless output sometimes being blank (from glennw:fix-18606); r=jdm
I *think* this is a bug in OSMesa, as the fix here makes no
sense to me. But nonetheless, this change does seem to reliably
fix the headless output issues as reported.
Fixes #18606.
Source-Repo: https://gi... | diff --git a/compositing/compositor.rs b/compositing/compositor.rs
index 304b523c8..e15f3ff26 100644
--- a/compositing/compositor.rs
+++ b/compositing/compositor.rs
@@ -1408,6 +1408,14 @@ impl<Window: WindowMethods> IOCompositor<Window> {
width: usize,
height: usize)
-... | 1 | 8 | 0 |
8fc8ca241d735ed05be0b53675b4a1d5d8461ebc | Emilio Cobos Álvarez | 2018-01-30T15:10:17 | servo: Merge #19902 - style: Fix sheet invalidation in quirks mode documents (from emilio:quirks-invalidation); r=SimonSapin
Bug: 1433589
Source-Repo: https://github.com/servo/servo
Source-Revision: 5114d1dee9dd80222bb8a7a1e89ee213f0bc221f | diff --git a/style/invalidation/stylesheets.rs b/style/invalidation/stylesheets.rs
index 532968781..08c30c542 100644
--- a/style/invalidation/stylesheets.rs
+++ b/style/invalidation/stylesheets.rs
@@ -10,7 +10,7 @@
use Atom;
use CaseSensitivityExt;
use LocalName as SelectorLocalName;
-use dom::{TElement, TNode};
+us... | 1 | 14 | 11 |
e17a141aad0b906ecc3a2dc9cc0373fc38240864 | Pyfisch | 2018-01-30T10:42:36 | servo: Merge #19824 - Use more WebRender types in gfx (from pyfisch:dl-move); r=mrobinson
Removes ImageBorder details from gfx.
Use WebRender BorderRadius in BoxShadow.
Stores cursors as integer.
Use FilterOp, BorderWidths from WebRender.
Store content_rect as LayoutRect.
This amends #19782.
Source-Repo: https://git... | diff --git a/gfx/Cargo.toml b/gfx/Cargo.toml
index 2fc3924cd..7d14ebd31 100644
--- a/gfx/Cargo.toml
+++ b/gfx/Cargo.toml
@@ -40,7 +40,6 @@ servo_geometry = {path = "../geometry"}
servo_url = {path = "../url"}
smallvec = "0.6"
style = {path = "../style"}
-style_traits = {path = "../style_traits"}
time = "0.1.12"
un... | 6 | 126 | 194 |
a3453ed2173ac07a01ed05a2f69a3bbae2980561 | Emilio Cobos Álvarez | 2018-01-29T17:45:11 | servo: Merge #19878 - selectors: Never match ::slotted on <slot>s (from emilio:slotted-slot); r=nox
This fixes the test from https://github.com/w3c/web-platform-tests/pull/9212 in
Gecko.
Source-Repo: https://github.com/servo/servo
Source-Revision: 82922c97dc0313736fedb8021b205d4f84088a15 | diff --git a/layout_thread/dom_wrapper.rs b/layout_thread/dom_wrapper.rs
index 0110704ed..a909ce72e 100644
--- a/layout_thread/dom_wrapper.rs
+++ b/layout_thread/dom_wrapper.rs
@@ -784,6 +784,13 @@ impl<'le> ::selectors::Element for ServoLayoutElement<'le> {
}
}
+ fn is_html_slot_element(&self) -> bo... | 7 | 36 | 7 |
30635e495dd95988c91b8b9d75a5670ef9193f02 | Emilio Cobos Álvarez | 2018-01-29T16:54:13 | servo: Merge #19851 - style: Update css-align to the spec (mostly) (from emilio:content-distribution); r=nox
This is on top of #19850.
This fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1430817, and updates us
to the current version of the css-align spec.
The only remaining change is the justify-items: auto FIX... | diff --git a/style/properties/longhand/position.mako.rs b/style/properties/longhand/position.mako.rs
index 013b93b26..1dc697bd2 100644
--- a/style/properties/longhand/position.mako.rs
+++ b/style/properties/longhand/position.mako.rs
@@ -69,8 +69,8 @@ ${helpers.single_keyword("flex-wrap", "nowrap wrap wrap-reverse",
... | 6 | 352 | 263 |
a71b02b3c52dbb85fad58e5de586586cddaaff00 | Linus Färnstrand | 2018-01-29T12:38:26 | servo: Merge #19759 - Upgrade core foundation (from faern:upgrade-core-foundation); r=jdm
<!-- Please describe your changes on the following line: -->
This PR is the final one in a chain of PRs that tries to make a breaking change to `core-foundation`. This PR makes sure Servo only use the new, not yet released `core-... | diff --git a/gfx/Cargo.toml b/gfx/Cargo.toml
index 5eea73f32..2fc3924cd 100644
--- a/gfx/Cargo.toml
+++ b/gfx/Cargo.toml
@@ -49,9 +49,9 @@ xi-unicode = "0.1.0"
[target.'cfg(target_os = "macos")'.dependencies]
byteorder = "1.0"
-core-foundation = "0.4"
-core-graphics = "0.12.2"
-core-text = "8.0"
+core-foundation = ... | 2 | 7 | 17 |
b01b02d01ab4e6c900e4fffa92afa0b0ba53ddee | CYBAI | 2018-01-28T18:00:45 | servo: Merge #19889 - script: Move `style` as Element method (from CYBAI:style-inside-element); r=emilio
r? emilio
---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #19886
- [x] These changes do not require tests because it should not br... | diff --git a/script/dom/element.rs b/script/dom/element.rs
index a1bcaa043..16a84737c 100644
--- a/script/dom/element.rs
+++ b/script/dom/element.rs
@@ -107,7 +107,8 @@ use style::context::QuirksMode;
use style::dom_apis;
use style::element_state::ElementState;
use style::invalidation::element::restyle_hints::Restyl... | 2 | 14 | 17 |
013d903cd0772eaadefd23bcfca02aaa24580c4c | Jon Leighton | 2018-01-28T11:52:56 | servo: Merge #19881 - Add layout RPC query for getting an element's style (from jonleighton:issue-19811); r=emilio
This enables us to implement Element::has_css_layout_box() in a more
direct way, and also enables us to remove some of the existing more
specific queries.
Fixes #19811.
r? @emilio
Source-Repo: https://... | diff --git a/layout/query.rs b/layout/query.rs
index eac23f563..c5da86940 100644
--- a/layout/query.rs
+++ b/layout/query.rs
@@ -16,9 +16,9 @@ use ipc_channel::ipc::IpcSender;
use msg::constellation_msg::PipelineId;
use opaque_node::OpaqueNodeMethods;
use script_layout_interface::rpc::{ContentBoxResponse, ContentBox... | 10 | 88 | 136 |
a4c4600ce1dd5493b9ad9543e29a98c22534c14e | Emilio Cobos Álvarez | 2018-01-27T02:18:48 | servo: Merge #19877 - style: Look at the snapshots when invalidating due to stylesheet changes (from emilio:remove-sheet-oh-noes); r=bz
Otherwise removal of stylesheets may get out of sync with other DOM changes, and
we may fail to invalidate the style of the affected elements.
Bug: 1432850
Reviewed-by: bz
MozReview... | diff --git a/layout_thread/lib.rs b/layout_thread/lib.rs
index fcd790fe6..66f328f44 100644
--- a/layout_thread/lib.rs
+++ b/layout_thread/lib.rs
@@ -1194,8 +1194,6 @@ impl LayoutThread {
debug!("Doc sheets changed, flushing author sheets too");
self.stylist.force_stylesheet_origins_dir... | 8 | 94 | 30 |
66e19d198cf755c42a8d5f4ff60402f7b3994d20 | Anthony Ramine | 2018-01-26T14:26:49 | servo: Merge #19872 - Make JSTraceable for DomRefCell<T> panic if cell is mutably borrowed (from nox:domrefcell-tracing); r=jdm
Source-Repo: https://github.com/servo/servo
Source-Revision: c0d9f28b044ce377fc421475a943555c8ca6f123 | diff --git a/script/dom/bindings/cell.rs b/script/dom/bindings/cell.rs
index c5a76bb4e..c40885866 100644
--- a/script/dom/bindings/cell.rs
+++ b/script/dom/bindings/cell.rs
@@ -29,18 +29,6 @@ impl<T> DomRefCell<T> {
&*self.value.as_ptr()
}
- /// Borrow the contents for the purpose of GC tracing.
- ... | 2 | 1 | 13 |
82586005f0f4505d3b7d07b611cf2f0c7c1f37d9 | CYBAI | 2018-01-26T00:06:33 | servo: Merge #19868 - Use specific assertions (from CYBAI:specific-assertion); r=emilio
Similar to #19865
r? jdm
Note: Should I squash all the commits into one commit?
---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes do not require tests b... | diff --git a/canvas/canvas_paint_thread.rs b/canvas/canvas_paint_thread.rs
index 28b7fec54..8e7e26786 100644
--- a/canvas/canvas_paint_thread.rs
+++ b/canvas/canvas_paint_thread.rs
@@ -648,7 +648,7 @@ impl<'a> CanvasPaintThread<'a> {
return
}
- assert!(image_data_size.width * image_data_s... | 36 | 72 | 72 |
ec41455664b82e9659feaef1396d62f64fbb21b3 | Josh Matthews | 2018-01-25T23:11:42 | servo: Merge #19865 - Use more specific assertions for http tests (from servo:jdm-patch-6); r=KiChjang
Source-Repo: https://github.com/servo/servo
Source-Revision: fc3b1789318afc8f10e160d40b592234fbdb5cf4 | diff --git a/net/tests/http_loader.rs b/net/tests/http_loader.rs
index bff34263a..b9a84e6d0 100644
--- a/net/tests/http_loader.rs
+++ b/net/tests/http_loader.rs
@@ -343,16 +343,16 @@ fn test_redirected_request_to_devtools() {
let devhttprequest = expect_devtools_http_request(&devtools_port);
let devhttprespon... | 1 | 6 | 6 |
9d7d4c4b6035ed3497de82a22f633cc214791ff8 | Glenn Watson | 2018-01-25T19:48:24 | servo: Merge #19848 - Update WR (new capture API, render target cache optimization) (from glennw:update-wr-tcrt); r=jdm
Source-Repo: https://github.com/servo/servo
Source-Revision: e035f5a17ff307f61cc2a9697bd6bebc5544c710 | diff --git a/canvas/webgl_thread.rs b/canvas/webgl_thread.rs
index 730071421..4f2a45c20 100644
--- a/canvas/webgl_thread.rs
+++ b/canvas/webgl_thread.rs
@@ -502,7 +502,9 @@ impl<VR: WebVRRenderHandler + 'static, OB: WebGLThreadObserver> WebGLThread<VR,
let data = webrender_api::ExternalImageData {
... | 1 | 9 | 5 |
d83f3ce38c930cdffce14a899b4b8a1511fa5006 | Emilio Cobos Álvarez | 2018-01-25T16:18:24 | servo: Merge #19854 - style: make the try_match_ident_ignore_ascii_case macro actually return the error (from emilio:try-match); r=nox
This allows it to be used as an expression, which I'd like to do very soon.
Source-Repo: https://github.com/servo/servo
Source-Revision: 5355265c7481ef5f1a9d869927ad8bb1d8d8357b | diff --git a/style/macros.rs b/style/macros.rs
index ac795bdb0..c3bf87b51 100644
--- a/style/macros.rs
+++ b/style/macros.rs
@@ -53,19 +53,16 @@ macro_rules! trivial_to_computed_value {
/// FIXME(emilio): The fact that `UnexpectedIdent` is a `SelectorParseError`
/// doesn't make a lot of sense to me.
macro_rules! tr... | 2 | 10 | 11 |
28c87c1fd4f33ee9ae0a4dffc4465aa8996abe01 | Manish Goregaokar | 2018-01-25T04:42:59 | servo: Merge #19688 - Detect adjoining text fragments with no line break opportunity between them (from Manishearth:linebreak); r=mbrubeck
First attempt at https://github.com/servo/servo/issues/874
Source-Repo: https://github.com/servo/servo
Source-Revision: 9c1307307575637f5ad360413c6a8395579ab511 | diff --git a/gfx/text/text_run.rs b/gfx/text/text_run.rs
index 8121140e4..62126ab83 100644
--- a/gfx/text/text_run.rs
+++ b/gfx/text/text_run.rs
@@ -15,7 +15,7 @@ use style::str::char_is_whitespace;
use text::glyph::{ByteIndex, GlyphStore};
use unicode_bidi as bidi;
use webrender_api;
-use xi_unicode::LineBreakItera... | 6 | 125 | 28 |
5491564270cd4cc88cf4e2ef312b7be8a59dc62a | Jon Leighton | 2018-01-25T01:35:39 | servo: Merge #19852 - Allow floats to impact list item marker position (from jonleighton:issue-19796); r=mbrubeck
Although not required by the specification, this matches the rendering
of Gecko and Blink.
Fixes #19796.
Source-Repo: https://github.com/servo/servo
Source-Revision: d974411e56e4e31ce3acd53411bb28cee6e13... | diff --git a/layout/list_item.rs b/layout/list_item.rs
index 0fddde149..a658aebb3 100644
--- a/layout/list_item.rs
+++ b/layout/list_item.rs
@@ -63,36 +63,27 @@ impl ListItemFlow {
this
}
-}
-
-impl Flow for ListItemFlow {
- fn class(&self) -> FlowClass {
- FlowClass::ListItem
- }
-
- fn... | 1 | 46 | 28 |
6f750579922392470a737b090ea4c406c9622910 | Emilio Cobos Álvarez | 2018-01-24T18:25:58 | servo: Merge #19850 - style: Minor nits on the alignment properties (from emilio:tidy-align); r=nox
I'm going to touch this in a bit, let's do it a bit less painful.
Source-Repo: https://github.com/servo/servo
Source-Revision: 7354a32c19ca452748ee83452c03a4e15f11f242 | diff --git a/style/properties/longhand/position.mako.rs b/style/properties/longhand/position.mako.rs
index cb666a27f..013b93b26 100644
--- a/style/properties/longhand/position.mako.rs
+++ b/style/properties/longhand/position.mako.rs
@@ -69,8 +69,8 @@ ${helpers.single_keyword("flex-wrap", "nowrap wrap wrap-reverse",
... | 6 | 59 | 64 |
80729c43f682c88146aa0891aa055b7a696377fc | Gregory Terzian | 2018-01-23T20:47:16 | servo: Merge #19350 - Ignore aborted responses in caching (from gterzian:ignore_aborted_responses_in_caching); r=jdm
<!-- Please describe your changes on the following line: -->
@jdm @KiChjang @Manishearth Follow up on https://github.com/servo/servo/pull/18676 and https://github.com/servo/servo/pull/19274 to ignore ab... | diff --git a/net/fetch/methods.rs b/net/fetch/methods.rs
index 729435020..69999d381 100644
--- a/net/fetch/methods.rs
+++ b/net/fetch/methods.rs
@@ -29,6 +29,7 @@ use std::io::Read;
use std::mem;
use std::str;
use std::sync::{Arc, Mutex};
+use std::sync::atomic::Ordering;
use std::sync::mpsc::{Sender, Receiver};
u... | 4 | 92 | 22 |
3b9b9ac3d143073e6e1fda9737b1dbf273a5b5d1 | Emilio Cobos Álvarez | 2018-01-23T16:42:31 | servo: Merge #19845 - style: Disable rustfmt on the bindings for now (from emilio:not-fmt-yet); r=emilio
Source-Repo: https://github.com/servo/servo
Source-Revision: 108cb0e539d00e057d0b283bfd743520e25ab397 | diff --git a/style/build_gecko.rs b/style/build_gecko.rs
index 8c97e540c..7415bff8a 100644
--- a/style/build_gecko.rs
+++ b/style/build_gecko.rs
@@ -204,7 +204,11 @@ mod bindings {
// Disable rust unions, because we replace some types inside of
// them.
+ //
+ // FIXME(... | 1 | 4 | 0 |
8542619e87171a0457b79cbfa74dd9883baf56f9 | Bobby Holley | 2018-01-22T22:58:30 | servo: Merge #19841 - stylo: Avoid separate monomorphizations of CSS serialization for utf-8 and utf-16 (from bholley:single_tocss); r=emilio
https://bugzilla.mozilla.org/show_bug.cgi?id=1431268
Source-Repo: https://github.com/servo/servo
Source-Revision: 6f543d3de1658e3cacf7fc2caed7b9bda69e1d23 | diff --git a/script/dom/cssstyledeclaration.rs b/script/dom/cssstyledeclaration.rs
index b9bf61c19..2699bda9b 100644
--- a/script/dom/cssstyledeclaration.rs
+++ b/script/dom/cssstyledeclaration.rs
@@ -21,7 +21,7 @@ use style::properties::{DeclarationSource, Importance, PropertyDeclarationBlock,
use style::properties::... | 20 | 214 | 108 |
a4568d952b58557759479c57d892aa9055dd419b | Fernando Jiménez Moreno | 2018-01-22T14:14:29 | servo: Merge #19789 - Do not leave space below baseline when it is not needed (i.e.there is… (from ferjm:issue-18831-fb-layout); r=mbrubeck
… no text)
This is my first layout fix and a naive approach to fix #18831.
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors... | diff --git a/layout/inline.rs b/layout/inline.rs
index 934e4aa1f..a934b95ba 100644
--- a/layout/inline.rs
+++ b/layout/inline.rs
@@ -1143,7 +1143,11 @@ impl InlineFlow {
let font_style = style.clone_font();
let font_metrics = text::font_metrics_for_style(font_context, font_style);
let line_he... | 1 | 5 | 1 |
4b5cc245ec4e470abc48d68ae7d1635958bf4202 | Igor Gutorov | 2018-01-20T18:10:58 | servo: Merge #19798 - style: Move cursor property out of mako (from gootorov:move_cursor_from_mako); r=emilio
<!-- Please describe your changes on the following line: -->
Sub-PR of #19015
r? emilio
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace... | diff --git a/compositing/compositor.rs b/compositing/compositor.rs
index fea6fd1dc..d964c0bdb 100644
--- a/compositing/compositor.rs
+++ b/compositing/compositor.rs
@@ -29,7 +29,7 @@ use std::rc::Rc;
use std::sync::mpsc::Sender;
use std::time::{Duration, Instant};
use style_traits::{CSSPixel, DevicePixel, PinchZoomF... | 15 | 331 | 278 |
42c74a185b3915fd37e8da69af3ae3f95845b23f | Emilio Cobos Álvarez | 2018-01-20T05:05:18 | servo: Merge #19822 - style: More tiny selector-matching cleanup (from emilio:less-match-public); r=KiChjang
See each commit individually.
Source-Repo: https://github.com/servo/servo
Source-Revision: 6fc71a7644bd7afcccf83f67cfdaf01897e1a3bc | diff --git a/selectors/context.rs b/selectors/context.rs
index f61823a62..257a29afc 100644
--- a/selectors/context.rs
+++ b/selectors/context.rs
@@ -100,7 +100,7 @@ where
Impl: SelectorImpl,
{
/// Input with the matching mode we should use when matching selectors.
- pub matching_mode: MatchingMode,
+ m... | 4 | 47 | 36 |
91b9f7957c3276aad21b3439277353271627f99a | Emilio Cobos Álvarez | 2018-01-20T01:18:47 | servo: Merge #19805 - style: Handle correctly document state invalidation inside negation (from emilio:doc-state-fix); r=xidorn
style: Handle correctly document state invalidation inside negation.
Source-Repo: https://github.com/servo/servo
Source-Revision: 3b07be555310a3a31445fae1150720cc3ff7d5d5 | diff --git a/selectors/context.rs b/selectors/context.rs
index 75abfea9f..f61823a62 100644
--- a/selectors/context.rs
+++ b/selectors/context.rs
@@ -127,6 +127,9 @@ where
/// MatchingContext immutable again.
nesting_level: usize,
+ /// Whether we're inside a negation or not.
+ in_negation: bool,
+
... | 4 | 35 | 4 |
4399fc26d7e824af4c5d175b3f5dcebdb62ce02b | Jon Leighton | 2018-01-19T20:37:57 | servo: Merge #19803 - Implement Element::has_css_layout_box() (from jonleighton:issue-19765); r=emilio
r? emilio
Here's my initial attempt to fix #19430. It seems surprisingly simple so I am wondering whether I have missed something! (Or maybe it just actually is quite simple...)
Some things I am unsure about:
1. T... | diff --git a/script/dom/element.rs b/script/dom/element.rs
index 4c7d4be40..c6224e7dc 100644
--- a/script/dom/element.rs
+++ b/script/dom/element.rs
@@ -348,11 +348,12 @@ impl Element {
}
// https://drafts.csswg.org/cssom-view/#css-layout-box
- // Elements that have a computed value of the display proper... | 1 | 5 | 4 |
c7caa6fe62867591f6450167596372bc1c669b19 | Emilio Cobos Álvarez | 2018-01-19T18:50:00 | servo: Merge #19817 - style: Track the visited-handling-mode on the MatchingContext (from emilio:matching-context-visited); r=nox
This fixes bugs where we're not passing the value around correctly, like from
::-moz-any.
This is a fix for https://bugzilla.mozilla.org/show_bug.cgi?id=1431539.
Source-Repo: https://gith... | diff --git a/layout_thread/dom_wrapper.rs b/layout_thread/dom_wrapper.rs
index 14a2e5f38..1b58f9f81 100644
--- a/layout_thread/dom_wrapper.rs
+++ b/layout_thread/dom_wrapper.rs
@@ -713,7 +713,6 @@ impl<'le> ::selectors::Element for ServoLayoutElement<'le> {
&self,
pseudo_class: &NonTSPseudoClass,
... | 8 | 127 | 93 |
c23de9c451a93f8639cdcbecbdf5a548aad3dd12 | Fernando Jiménez Moreno | 2018-01-19T17:53:28 | servo: Merge #19806 - Remove gecko-media dependency (from ferjm:rm-gecko-media); r=nox
The effort to import Gecko's media stack into Servo has been canceled, so I am removing the bits of code from gecko-media that we added to Servo.
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not ... | diff --git a/constellation/Cargo.toml b/constellation/Cargo.toml
index 7cadee117..fda299e38 100644
--- a/constellation/Cargo.toml
+++ b/constellation/Cargo.toml
@@ -43,6 +43,3 @@ webrender_api = {git = "https://github.com/servo/webrender", features = ["ipc"]}
[target.'cfg(all(not(target_os = "windows"), not(target_o... | 6 | 0 | 47 |
94cc5576bd989f38f57f82979fc5703e4dd4135c | Glenn Watson | 2018-01-19T15:37:47 | servo: Merge #19814 - Update WR (minimal use of new transaction API) (from glennw:update-wr-txn); r=emilio
Source-Repo: https://github.com/servo/servo
Source-Revision: 0b86b60238f795554f5e7ee07dcc993fc4cdf650 | diff --git a/canvas/webgl_thread.rs b/canvas/webgl_thread.rs
index e03021761..730071421 100644
--- a/canvas/webgl_thread.rs
+++ b/canvas/webgl_thread.rs
@@ -353,7 +353,9 @@ impl<VR: WebVRRenderHandler + 'static, OB: WebGLThreadObserver> WebGLThread<VR,
self.dom_outputs.insert(pipeline_id, DOMToTextureD... | 3 | 35 | 16 |
bb4a07b5e255eccb817be75c83777036e94f260a | Emilio Cobos Álvarez | 2018-01-19T12:49:54 | servo: Merge #19813 - selectors: Simplify SelectorIter::next (from emilio:tidy); r=nox
Source-Repo: https://github.com/servo/servo
Source-Revision: 726a1854b08b7809dbe31fa57c186de39bd5ca42 | diff --git a/selectors/parser.rs b/selectors/parser.rs
index 465e6acaa..919815623 100644
--- a/selectors/parser.rs
+++ b/selectors/parser.rs
@@ -609,13 +609,12 @@ impl<'a, Impl: SelectorImpl> Iterator for SelectorIter<'a, Impl> {
fn next(&mut self) -> Option<Self::Item> {
debug_assert!(self.next_combinato... | 1 | 3 | 4 |
a2fb36ae405cc8de560fb32117e3e3e8340ba99c | Emilio Cobos Álvarez | 2018-01-18T15:36:51 | servo: Merge #19807 - style: Make the Gecko font-size calc() code do what it means to do (from emilio:calc-font-size); r=Manishearth
It makes no sense to pass a custom base size of zero in presence of rem, ex, or
ch units.
Bug: 1431031
Reviewed-by: Manishearth
MozReview-Commit-ID: 7ZZwRzQKREX
Source-Repo: https://git... | diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs
index 81f0af1f1..f21f33bfd 100644
--- a/style/properties/gecko.mako.rs
+++ b/style/properties/gecko.mako.rs
@@ -2505,9 +2505,12 @@ fn static_assert() {
/// Set font size, taking into account scriptminsize and scriptlevel
/// Return... | 3 | 61 | 29 |
075326d5ccea02a1c267d5e9dfb01606d134fabc | Pyfisch | 2018-01-18T11:42:52 | servo: Merge #19782 - Use more WebRender types in gfx/display_list (from pyfisch:dl-simple); r=mrobinson
Use more WebRender types in gfx/display_list.
This uses floating-point (Layout) coordinates in where possible.
Replace NormalBorder struct with WebRender equivalent.
Remove ToPointF and ToRectF traits.
Convert bord... | diff --git a/geometry/Cargo.toml b/geometry/Cargo.toml
index 4dcc2d89f..d860ae213 100644
--- a/geometry/Cargo.toml
+++ b/geometry/Cargo.toml
@@ -14,3 +14,4 @@ app_units = "0.6"
euclid = "0.16"
malloc_size_of = { path = "../malloc_size_of" }
malloc_size_of_derive = { path = "../malloc_size_of_derive" }
+webrender_api... | 12 | 226 | 254 |
dca81dea8a5c81fc227b85eda1754d8cc7178268 | Emilio Cobos Álvarez | 2018-01-18T02:34:47 | servo: Merge #19799 - style: Remove new function added to the build from bindings.rs (from emilio:everything-is-red); r=emilio
Since it was removed from gecko, and this confuses a lot to
ports/geckolib/tests/build.rs.
Source-Repo: https://github.com/servo/servo
Source-Revision: 1f6a864ab5372fe4f59b1a4c3db7cf8e7a79b06... | diff --git a/style/gecko/generated/bindings.rs b/style/gecko/generated/bindings.rs
index a7597a98c..301aba806 100644
--- a/style/gecko/generated/bindings.rs
+++ b/style/gecko/generated/bindings.rs
@@ -1151,8 +1151,6 @@ extern "C" {
pub fn Servo_Element_IsDisplayNone ( element : RawGeckoElementBorrowed , ) -> bool ;
... | 1 | 1 | 3 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.