commit_hash stringlengths 40 40 | author stringlengths 1 57 | date timestamp[s]date 2010-07-26 04:45:09 2026-04-14 18:21:10 | message stringlengths 8 1.39M | diff stringlengths 68 51.2k | files_changed int64 1 136 | insertions int64 0 2.35k | deletions int64 0 1.9k |
|---|---|---|---|---|---|---|---|
380ccb73c6f41ee85be3811244436cd8418ca062 | Emilio Cobos Álvarez | 2017-12-09T15:52:27 | servo: Merge #19534 - style: Simplify naming and signatures of single-colon pseudo stuff (from emilio:naming-is-a-bit-hard-but-not-that-hard); r=nox
Also drop a few FIXMEs while at it, since they look bogus.
Source-Repo: https://github.com/servo/servo
Source-Revision: 051eb6bcb9204ecab1c1481a275a09fd50bf0467 | diff --git a/selectors/parser.rs b/selectors/parser.rs
index 6be95b5d0..ff9f45eac 100644
--- a/selectors/parser.rs
+++ b/selectors/parser.rs
@@ -127,7 +127,7 @@ pub trait Parser<'i> {
/// Whether the name is a pseudo-element that can be specified with
/// the single colon syntax in addition to the double-co... | 2 | 11 | 7 |
db2197fb1a3b2a979499499df8dbf02c116d6b22 | Emilio Cobos Álvarez | 2017-12-09T01:59:38 | servo: Merge #19530 - style: Don't unconditionally extend() the declaration block vector (from emilio:extend-not-much); r=jdm
Since it appears in profiles when used from CSSOM, like the one in the bug
mentioned in the comment.
Source-Repo: https://github.com/servo/servo
Source-Revision: f8a87a76b2c940fdcf1ced230c616b... | diff --git a/style/properties/declaration_block.rs b/style/properties/declaration_block.rs
index f27c2c357..788d39c4b 100644
--- a/style/properties/declaration_block.rs
+++ b/style/properties/declaration_block.rs
@@ -399,15 +399,28 @@ impl PropertyDeclarationBlock {
importance: Importance,
source: Dec... | 1 | 22 | 9 |
88e86b83394ee9caa809aa83228ba46cbfb323ef | Xidorn Quan | 2017-12-09T00:49:39 | servo: Merge #19526 - Add @supports -moz-bool-pref() support for stylo (from upsuper:moz-bool-pref); r=emilio
This is the Servo side change for [bug 1267890](https://bugzilla.mozilla.org/show_bug.cgi?id=1267890).
Source-Repo: https://github.com/servo/servo
Source-Revision: 42a3c1631c27dde2d845338ccf80e0fb1b3cf9bf | diff --git a/style/gecko/generated/bindings.rs b/style/gecko/generated/bindings.rs
index dec8338ee..d4e2bf868 100644
--- a/style/gecko/generated/bindings.rs
+++ b/style/gecko/generated/bindings.rs
@@ -1595,4 +1595,6 @@ extern "C" {
pub fn Gecko_ContentList_AppendAll ( aContentList : * mut nsSimpleContentList , aEleme... | 2 | 52 | 1 |
2530ebea35d81c7e2a31097b6a797d026d2e4975 | Emilio Cobos Álvarez | 2017-12-08T23:37:32 | servo: Merge #19520 - selectors: Simplify :visited by only using the "is inside link" information (from emilio:simplify-visited); r=jryans
Right now we go through a lot of hoops to see if we ever see a relevant link.
However, that information is not needed: if the element is a link, we'll always
need to compute its v... | diff --git a/layout_thread/dom_wrapper.rs b/layout_thread/dom_wrapper.rs
index ebf7d12cb..82a9678d7 100644
--- a/layout_thread/dom_wrapper.rs
+++ b/layout_thread/dom_wrapper.rs
@@ -49,7 +49,7 @@ use script_layout_interface::{OpaqueStyleAndLayoutData, StyleData};
use script_layout_interface::wrapper_traits::{DangerousT... | 10 | 128 | 208 |
ad366f0acb0cba01444add8cd275ecea354e0685 | Keith Yeung | 2017-12-08T22:02:09 | servo: Merge #19522 - Remove border_collapse field in InternalTable (from KiChjang:remove-border-collapse-field); r=emilio
This field doesn't seem to serve a purpose after #18252.
Source-Repo: https://github.com/servo/servo
Source-Revision: fd785f2424bacd6f60cb1937648fed28a43b0f36 | diff --git a/layout/table.rs b/layout/table.rs
index f75053f9f..37e92be32 100644
--- a/layout/table.rs
+++ b/layout/table.rs
@@ -364,9 +364,7 @@ impl Flow for TableFlow {
}
}
- let inline_size_computer = InternalTable {
- border_collapse: self.block_flow.fragment.style.get_inhe... | 4 | 11 | 23 |
8f1d5c91e11f36793b995b4aa59118555abd8ce6 | Matt Brubeck | 2017-12-08T16:29:08 | servo: Merge #19525 - Update to webdriver 0.33 (from mbrubeck:deps); r=nox
Removes the extra version of the `cookie` crate
Source-Repo: https://github.com/servo/servo
Source-Revision: a8be1597c9d1b4d019ed93d68cc7fdfba8ca1f86 | diff --git a/webdriver_server/Cargo.toml b/webdriver_server/Cargo.toml
index 3bd5ee5b3..d8db4d96c 100644
--- a/webdriver_server/Cargo.toml
+++ b/webdriver_server/Cargo.toml
@@ -26,4 +26,4 @@ servo_config = {path = "../config"}
servo_url = {path = "../url"}
url = "1.2"
uuid = {version = "0.5", features = ["v4"]}
-web... | 1 | 1 | 1 |
095a11aec0df30f6b71355559c65f2f74816f35f | Simon Sapin | 2017-12-08T13:49:54 | servo: Merge #19510 - Update some dependencies, remove heapsize from the build (from servo:heapsize); r=nox
Source-Repo: https://github.com/servo/servo
Source-Revision: 07bd84ecc8dc9ba56df873453696993118e18583 | diff --git a/canvas/Cargo.toml b/canvas/Cargo.toml
index d92cc1f0a..6da66760c 100644
--- a/canvas/Cargo.toml
+++ b/canvas/Cargo.toml
@@ -14,13 +14,13 @@ azure = {git = "https://github.com/servo/rust-azure"}
canvas_traits = {path = "../canvas_traits"}
compositing = {path = "../compositing"}
cssparser = "0.23.0"
-eucl... | 34 | 106 | 104 |
660f0bbec6833f855179437611931b84db971999 | Emilio Cobos Álvarez | 2017-12-08T02:32:11 | servo: Merge #19518 - style: Remove useless type parameter (from emilio:useless-code-is-useless); r=KiChjang
Source-Repo: https://github.com/servo/servo
Source-Revision: 22472b4db4564f7bc274eb01447e4f04fd7e7205 | diff --git a/selectors/matching.rs b/selectors/matching.rs
index 58dc331c7..9c6fee091 100644
--- a/selectors/matching.rs
+++ b/selectors/matching.rs
@@ -82,10 +82,7 @@ where
}
#[inline(always)]
-fn may_match<E>(hashes: &AncestorHashes, bf: &BloomFilter) -> bool
-where
- E: Element,
-{
+fn may_match(hashes: &Ance... | 1 | 2 | 5 |
04bd624ad5d7fd4d4981e4d09ffe410e4065505e | Matt Brubeck | 2017-12-08T01:09:07 | servo: Merge #19517 - Defend against bugs in SelectorFlagsMap (from mbrubeck:uluru); r=emilio
Some defensive programming:
* Make `SelectorFlagsMap::apply_flags` private so it's easier to ensure it is called from the correct thread.
* Clear the cache and the map at the same time; otherwise `apply_flags` leaves `Selec... | diff --git a/style/context.rs b/style/context.rs
index 7843c4240..a40537a5a 100644
--- a/style/context.rs
+++ b/style/context.rs
@@ -553,8 +553,9 @@ impl<E: TElement> SelectorFlagsMap<E> {
}
/// Applies the flags. Must be called on the main thread.
- pub fn apply_flags(&mut self) {
+ fn apply_flags(&m... | 1 | 2 | 1 |
fdfd2dda8648a99b6cfff8df8689450eeec7297b | Matt Brubeck | 2017-12-07T22:02:44 | servo: Merge #19512 - Improve LRU cache behavior in SelectorFlagsMap (from mbrubeck:uluru); r=emilio
This code used to insert duplicate entries to avoid expensive shuffling of the LRU cache. With uluru this is no longer necessary, because reordering the cache is cheap.
Now it uses the `LRUCache::find` method from ul... | diff --git a/net/Cargo.toml b/net/Cargo.toml
index 4ed1e4037..23998be34 100644
--- a/net/Cargo.toml
+++ b/net/Cargo.toml
@@ -18,7 +18,7 @@ flate2 = "0.2.0"
hyper = "0.10"
hyper_serde = "0.8"
hyper-openssl = "0.2.2"
-immeta = "0.3.1"
+immeta = "0.3.6"
ipc-channel = "0.9"
lazy_static = "1"
log = "0.3.5"
diff --git ... | 5 | 13 | 17 |
2855f5e0dfd77f8042ef5b59bce493a5dc418ad3 | Fernando Jiménez Moreno | 2017-12-07T20:54:03 | servo: Merge #19516 - Print url of recorded PWM (from ferjm:pwm.url); r=jdm
This makes it a bit easier to compare results with other browsers.
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
Source-Repo: https://github.com/servo/servo
Source-Revision: c4482ebe77... | diff --git a/constellation/pipeline.rs b/constellation/pipeline.rs
index d5a41df44..a5d1c5c63 100644
--- a/constellation/pipeline.rs
+++ b/constellation/pipeline.rs
@@ -489,7 +489,8 @@ impl UnprivilegedPipelineContent {
let paint_time_metrics = PaintTimeMetrics::new(self.id,
... | 5 | 33 | 8 |
9e9763c394d731d3e50abba11bc676a86b7c7d4a | Bastien Orivel | 2017-12-07T19:43:13 | servo: Merge #19514 - Bump string_cache, html5ever and xml5ever (from Eijebong:bump); r=SimonSapin
Source-Repo: https://github.com/servo/servo
Source-Revision: 4016551e89e1cbb9dae988e6fca33a26f1537f02 | diff --git a/atoms/Cargo.toml b/atoms/Cargo.toml
index 5048cee30..9e6e07899 100644
--- a/atoms/Cargo.toml
+++ b/atoms/Cargo.toml
@@ -10,7 +10,7 @@ build = "build.rs"
path = "lib.rs"
[dependencies]
-string_cache = {version = "0.6"}
+string_cache = {version = "0.7"}
[build-dependencies]
string_cache_codegen = "0.... | 8 | 10 | 10 |
2fcc279d9715afe348cc66eae0a261703d399336 | Fernando Jiménez Moreno | 2017-12-07T16:31:45 | servo: Merge #19498 - Fix float conversion of paint timing metrics (from ferjm:pwm.f64); r=jdm
This is a follow up of #19077
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
Source-Repo: https://github.com/servo/servo
Source-Revision: ff70c4426d9ea2f36dc18216678f... | diff --git a/metrics/lib.rs b/metrics/lib.rs
index bd2d488f1..72706d0a0 100644
--- a/metrics/lib.rs
+++ b/metrics/lib.rs
@@ -46,6 +46,15 @@ pub const MAX_TASK_NS: u64 = 50000000;
/// 10 second window (in ns)
const INTERACTIVE_WINDOW_SECONDS_IN_NS: u64 = 10000000000;
+pub trait ToMs<T> {
+ fn to_ms(&self) -> T;
+... | 3 | 15 | 4 |
a9b7b3ea1c9f2275bd34b2f8925152005c6b1533 | Simon Sapin | 2017-12-07T12:53:07 | servo: Merge #19476 - Use workspace.default-members to specify default crates for cargo build (from servo:default-members); r=nox
… and 'cargo test', etc. Include Servo and its unit tests, but not Stylo because that would try to compile the style crate with incompatible feature flags: https://github.com/rust-lang/car... | diff --git a/dom_struct/lib.rs b/dom_struct/lib.rs
index a955f00ce..41cf4a675 100644
--- a/dom_struct/lib.rs
+++ b/dom_struct/lib.rs
@@ -19,5 +19,9 @@ pub fn dom_struct(args: TokenStream, input: TokenStream) -> TokenStream {
#[must_root]
#[repr(C)]
};
+
+ // Work around https://github.com/rust... | 1 | 4 | 0 |
c7a5a02222e0a714971ecbc791ed5cbadefe1d5b | Glenn Watson | 2017-12-07T06:57:40 | servo: Merge #19414 - Update WR (AA on transformed box-shadows, resource leak fixes) (from glennw:update-wr-leaks); r=wafflespeanut
Source-Repo: https://github.com/servo/servo
Source-Revision: e64647188879b8269b62c1d5c8aa05732ab9d96d | diff --git a/layout/webrender_helpers.rs b/layout/webrender_helpers.rs
index 7c15cab13..dd934c79a 100644
--- a/layout/webrender_helpers.rs
+++ b/layout/webrender_helpers.rs
@@ -264,7 +264,6 @@ impl WebRenderDisplayItemConverter for DisplayItem {
// TODO(gw): Make use of the WR backface visibility functiona... | 1 | 0 | 1 |
a55c73aad196067fad676cfa3984743629b05673 | Boris Chiou | 2017-12-06T08:38:22 | servo: Merge #19504 - hashglobe: Dump more information if out of memory while allocating a table (from BorisChiou:stylo/crash/out_of_memory); r=emilio
This is for Bug 1418806 and Bug 1416903. Sometimes, we got a crash message on stylo:
> called `Result::unwrap()` on an `Err` value: FailedAllocationError {
> reason:... | diff --git a/hashglobe/src/lib.rs b/hashglobe/src/lib.rs
index 83012473b..6431d3350 100644
--- a/hashglobe/src/lib.rs
+++ b/hashglobe/src/lib.rs
@@ -29,12 +29,14 @@ trait Recover<Q: ?Sized> {
#[derive(Debug)]
pub struct FailedAllocationError {
reason: &'static str,
+ /// The size we are allocating, if needed.... | 2 | 15 | 10 |
e8c035688ff2242991828e25d2a8c9a91781a848 | Bastien Orivel | 2017-12-05T19:44:19 | servo: Merge #19494 - Update smallvec to 0.6 (from Eijebong:smallvec); r=emilio
Source-Repo: https://github.com/servo/servo
Source-Revision: c20fd7d58a36496ea7d12ea3284172712da006b0 | diff --git a/fallible/Cargo.toml b/fallible/Cargo.toml
index eae094d57..e8f531469 100644
--- a/fallible/Cargo.toml
+++ b/fallible/Cargo.toml
@@ -10,7 +10,7 @@ name = "fallible"
path = "lib.rs"
[dependencies]
-smallvec = "0.4"
+smallvec = "0.6"
hashglobe = { path = "../hashglobe" }
# This crate effectively does ... | 7 | 7 | 7 |
45fa3945cfaebcacdebf120a31df846f7cf00a83 | tigercosmos | 2017-12-05T17:33:03 | servo: Merge #19492 - use entry global's origin in `is_origin_clean` check for canvas rendering (from tigercosmos:b1); r=jdm
use entry global's origin in `is_origin_clean` check for canvas rendering
There is no change with:
```
./mach test-wpt tests/wpt/web-platform-tests/2dcontext
./mach test-wpt tests/wpt/web-platf... | diff --git a/script/dom/canvasrenderingcontext2d.rs b/script/dom/canvasrenderingcontext2d.rs
index cf6b92bc4..93d4981d2 100644
--- a/script/dom/canvasrenderingcontext2d.rs
+++ b/script/dom/canvasrenderingcontext2d.rs
@@ -30,7 +30,7 @@ use dom::canvaspattern::CanvasPattern;
use dom::globalscope::GlobalScope;
use dom::... | 1 | 2 | 7 |
40b6cf0214ee89dc008df9d7fb72737462d0f93b | Bastien Orivel | 2017-12-05T16:31:16 | servo: Merge #19487 - Update lazy_static to 1.0 (from Eijebong:bump); r=jdm
For now it'll be duplicated
Source-Repo: https://github.com/servo/servo
Source-Revision: e2a7360e17e5d6ae8aca274183f67db18f37a6c4 | diff --git a/canvas_traits/Cargo.toml b/canvas_traits/Cargo.toml
index 81ea3340c..d484e4e84 100644
--- a/canvas_traits/Cargo.toml
+++ b/canvas_traits/Cargo.toml
@@ -13,7 +13,7 @@ path = "lib.rs"
cssparser = "0.23.0"
euclid = "0.15"
ipc-channel = "0.9"
-lazy_static = "0.2"
+lazy_static = "1"
malloc_size_of = { path ... | 10 | 11 | 11 |
07b316aee28ba747a1b5e86be1a11b661dc9a926 | shindli | 2017-12-05T15:00:33 | Backed out 4 changesets (bug 1422839) for landing stylo changes on inbound r=backout on a CLOSED TREE
Backed out changeset ff9d1a10cb0b (bug 1422839)
Backed out changeset fc039432e4a6 (bug 1422839)
Backed out changeset 83101ef21e45 (bug 1422839)
Backed out changeset 436d10234366 (bug 1422839) | diff --git a/style/properties/longhand/box.mako.rs b/style/properties/longhand/box.mako.rs
index 4da02c832..838c07d9a 100644
--- a/style/properties/longhand/box.mako.rs
+++ b/style/properties/longhand/box.mako.rs
@@ -373,18 +373,9 @@ ${helpers.single_keyword("-servo-overflow-clip-box", "padding-box content-box",
s... | 2 | 1 | 52 |
a148f80d38a6334d7ebca4f59be8a0bdcf9995bc | shindli | 2017-12-05T15:00:33 | Backed out 4 changesets (bug 1422839) for landing stylo changes on inbound r=backout a=backout
Backed out changeset ff9d1a10cb0b (bug 1422839)
Backed out changeset fc039432e4a6 (bug 1422839)
Backed out changeset 83101ef21e45 (bug 1422839)
Backed out changeset 436d10234366 (bug 1422839) | diff --git a/style/properties/longhand/box.mako.rs b/style/properties/longhand/box.mako.rs
index 4da02c832..838c07d9a 100644
--- a/style/properties/longhand/box.mako.rs
+++ b/style/properties/longhand/box.mako.rs
@@ -373,18 +373,9 @@ ${helpers.single_keyword("-servo-overflow-clip-box", "padding-box content-box",
s... | 2 | 1 | 52 |
2dfa5732741f1c54ee23d2cb107ab6c361c121ce | Fabrice Desré | 2017-12-05T13:13:46 | servo: Merge #19468 - Prevent an unused import warning on non desktop platforms (from servo:fabricedesre-patch-1); r=jdm
opts is not used on Android for instance.
<!-- Please describe your changes on the following line: -->
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the ste... | diff --git a/net/filemanager_thread.rs b/net/filemanager_thread.rs
index 393613d1a..4a84cd297 100644
--- a/net/filemanager_thread.rs
+++ b/net/filemanager_thread.rs
@@ -7,6 +7,7 @@ use mime_guess::guess_mime_type_opt;
use net_traits::blob_url_store::{BlobBuf, BlobURLStoreError};
use net_traits::filemanager_thread::{F... | 1 | 1 | 0 |
0b827a157aedd93adc256544005a386efb0f1fdb | Emilio Cobos Álvarez | 2017-12-05T09:37:18 | servo: Merge #19457 - style: support calc() in color functions (from emilio:color-calc); r=SimonSapin
Depends on #19456 and https://github.com/servo/rust-cssparser/pull/207.
Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=984021
Source-Repo: https://github.com/servo/servo
Source-Revision: 3cef09ae217ece7fa276d1be... | diff --git a/canvas/Cargo.toml b/canvas/Cargo.toml
index 49298cdb7..d92cc1f0a 100644
--- a/canvas/Cargo.toml
+++ b/canvas/Cargo.toml
@@ -13,7 +13,7 @@ path = "lib.rs"
azure = {git = "https://github.com/servo/rust-azure"}
canvas_traits = {path = "../canvas_traits"}
compositing = {path = "../compositing"}
-cssparser =... | 12 | 185 | 71 |
cabf36ef7da55edc978f3aace45bbb195e538dbf | Cameron McCormack | 2017-12-05T05:32:15 | servo: Merge #19490 - allow Gecko FFI functions for color parsing to report errors (from heycam:canvas-color); r=Aethanyc
This is the Servo-side part of https://bugzilla.mozilla.org/show_bug.cgi?id=1420026.
Source-Repo: https://github.com/servo/servo
Source-Revision: e5637770086be7ef69f44c6eb7c9a621fa577d96 | diff --git a/style/error_reporting.rs b/style/error_reporting.rs
index 19e89e233..d989857d1 100644
--- a/style/error_reporting.rs
+++ b/style/error_reporting.rs
@@ -46,6 +46,8 @@ pub enum ContextualParseError<'a> {
InvalidCounterStyleExtendsWithAdditiveSymbols,
/// A media rule was invalid for some reason.
... | 2 | 6 | 1 |
992edd2387a3e12052d4acf2fc99353bf2b8a61d | Mats Palmgren | 2017-12-05T03:36:00 | Bug 1422839 part 2 - Add internal overflow-clip-box-block/-inline properties and make overflow-clip-box a shorthand (Stylo changes). r=emilio | diff --git a/style/properties/longhand/box.mako.rs b/style/properties/longhand/box.mako.rs
index 838c07d9a..4da02c832 100644
--- a/style/properties/longhand/box.mako.rs
+++ b/style/properties/longhand/box.mako.rs
@@ -373,9 +373,18 @@ ${helpers.single_keyword("-servo-overflow-clip-box", "padding-box content-box",
s... | 2 | 52 | 1 |
0a6bd59abe861a88a75a84d803463f31b157daa2 | tigercosmos | 2017-12-05T01:58:08 | servo: Merge #19385 - implement "Date type inputs", "Month type inputs" (from tigercosmos:b1); r=KiChjang
<!-- Please describe your changes on the following line: -->
implement "Date type inputs", "Month type inputs"
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is co... | diff --git a/script/dom/bindings/str.rs b/script/dom/bindings/str.rs
index 6601d8e68..596b2db14 100644
--- a/script/dom/bindings/str.rs
+++ b/script/dom/bindings/str.rs
@@ -279,6 +279,20 @@ impl DOMString {
_ => false
}
}
+
+ /// A valid date string should be "YYYY-MM-DD"
+ /// YYYY mus... | 2 | 114 | 1 |
a148f99cbfe5ea23ac42f2e43ce568fbe7f14c0f | Simon Wörner | 2017-12-04T21:44:58 | servo: Merge #19379 - Implemented sanitize_value for time input (from SWW13:htmlinput_sanitize_time); r=KiChjang
Implemented value sanitization for `<input type=time/>`.
The value has the be valid time string (https://html.spec.whatwg.org/multipage/common-microsyntaxes.html#valid-time-string) or set to empty string.
... | diff --git a/script/dom/bindings/str.rs b/script/dom/bindings/str.rs
index 3667dddf9..6601d8e68 100644
--- a/script/dom/bindings/str.rs
+++ b/script/dom/bindings/str.rs
@@ -208,6 +208,77 @@ impl DOMString {
self.0.truncate(last_non_whitespace);
let _ = self.0.splice(0..first_non_whitespace, "");
... | 2 | 78 | 0 |
f11ca1e1146d6983c95c54a6f266e4a40bc7a68a | Emilio Cobos Álvarez | 2017-12-03T15:14:59 | servo: Merge #19462 - style: Cleanup Angle parsing (from emilio:angle-parsing); r=nox
This PR also contains a functional change, allowing to parse unitless zero angles in hue-rotate().
See the links and the comments for why.
Source-Repo: https://github.com/servo/servo
Source-Revision: e4dba3abef2a4941c5a4d95d58ae0b8... | diff --git a/style/values/specified/angle.rs b/style/values/specified/angle.rs
index 1a89e8235..67f3463a4 100644
--- a/style/values/specified/angle.rs
+++ b/style/values/specified/angle.rs
@@ -102,23 +102,25 @@ impl AsRef<ComputedAngle> for Angle {
}
}
+/// Whether to allow parsing an unitless zero as a valid a... | 4 | 78 | 50 |
13a018c2b4c6dbbc4c230247327a40c5e82515af | Emilio Cobos Álvarez | 2017-12-03T12:02:12 | servo: Merge #19463 - style: Remove free parsing functions, use Integer::parse and Number::parse instead (from emilio:bye-parse-functions); r=jdm
Source-Repo: https://github.com/servo/servo
Source-Revision: 14f757817e16a873e60035c1946ae82535038641 | diff --git a/style/properties/longhand/counters.mako.rs b/style/properties/longhand/counters.mako.rs
index b7b9cc21f..1ac7422cd 100644
--- a/style/properties/longhand/counters.mako.rs
+++ b/style/properties/longhand/counters.mako.rs
@@ -334,7 +334,7 @@
Ok(t) => return Err(location.new_unexpected_token_... | 3 | 57 | 68 |
0c1d65ba051416a235d2d65ab8a7f5369603ee39 | Emilio Cobos Álvarez | 2017-12-02T07:40:00 | servo: Merge #19454 - style: Add a missing fast-path in GeckoElement::each_class (from emilio:has-class-is-stupid); r=upsuper
This shows up when inserting elements in the bloom filter.
Source-Repo: https://github.com/servo/servo
Source-Revision: 45bbbac9d934bc375c735fd167730e37ce063325 | diff --git a/style/gecko/snapshot_helpers.rs b/style/gecko/snapshot_helpers.rs
index 79963e69c..51953a023 100644
--- a/style/gecko/snapshot_helpers.rs
+++ b/style/gecko/snapshot_helpers.rs
@@ -17,11 +17,12 @@ pub type ClassOrClassList<T> = unsafe extern fn (T, *mut *mut nsAtom, *mut *mut
/// Given an item `T`, a cla... | 2 | 23 | 13 |
e99e5196c17d75616a566279871585006634bf9e | Emilio Cobos Álvarez | 2017-12-02T04:08:22 | servo: Merge #19452 - style: Remove pretty useless layer of abstraction (from emilio:layers-as-an-onion); r=jdm
Source-Repo: https://github.com/servo/servo
Source-Revision: e8593e29633a67e6a8f61a213217a19278aa2739 | diff --git a/style/gecko/wrapper.rs b/style/gecko/wrapper.rs
index c31b8f9ea..686f2deae 100644
--- a/style/gecko/wrapper.rs
+++ b/style/gecko/wrapper.rs
@@ -22,7 +22,6 @@ use context::{QuirksMode, SharedStyleContext, PostAnimationTasks, UpdateAnimatio
use data::ElementData;
use dom::{LayoutIterator, NodeInfo, OpaqueN... | 1 | 2 | 16 |
7c70ba071df5a9859dd8ffcfa374fa6085d015c5 | Emilio Cobos Álvarez | 2017-12-02T00:03:11 | servo: Merge #19455 - style: Don't waste an allocation when failing to parse a CSSParserColor (from emilio:color-does-stupid-things-too); r=upsuper
I see that allocation show up in the profiles, and it makes sense, because
system colors and such are common in Firefox, and they're just wasting it.
Note that the clone(... | diff --git a/style/values/specified/color.rs b/style/values/specified/color.rs
index a9f83e0d4..2c961dea8 100644
--- a/style/values/specified/color.rs
+++ b/style/values/specified/color.rs
@@ -213,7 +213,7 @@ impl Color {
// specified value.
let start = input.state();
let authored = match inp... | 1 | 13 | 7 |
f1d51de1da22cff3e8803decd4ea816dce411f79 | Emilio Cobos Álvarez | 2017-12-01T22:52:34 | servo: Merge #19451 - style: Inline some things that should never ever appear in a profile (from emilio:inlining-is-fun); r=upsuper
Source-Repo: https://github.com/servo/servo
Source-Revision: f7aa22a87ee2571d3cdb90bfe361b22ba45ddb23 | diff --git a/style/gecko/wrapper.rs b/style/gecko/wrapper.rs
index 2babb8664..c31b8f9ea 100644
--- a/style/gecko/wrapper.rs
+++ b/style/gecko/wrapper.rs
@@ -211,6 +211,7 @@ impl<'ln> GeckoNode<'ln> {
/// WARNING: This logic is duplicated in Gecko's FlattenedTreeParentIsParent.
/// Make sure to mirror any mo... | 3 | 13 | 5 |
295ead46bcd5663f071a82b65dfd6b47b65c4085 | Emilio Cobos Álvarez | 2017-12-01T21:14:13 | servo: Merge #19453 - style: Add a fast-path for GeckoElement::is_root (from emilio:is-root-is-slow); r=upsuper
Source-Repo: https://github.com/servo/servo
Source-Revision: bca8951182dc3608f3d8c6948bcce636f7860529 | diff --git a/style/gecko/wrapper.rs b/style/gecko/wrapper.rs
index 15d3f785b..2babb8664 100644
--- a/style/gecko/wrapper.rs
+++ b/style/gecko/wrapper.rs
@@ -1917,6 +1917,15 @@ impl<'le> ::selectors::Element for GeckoElement<'le> {
#[inline]
fn is_root(&self) -> bool {
+ let parent_node = match self.a... | 1 | 9 | 0 |
c31f7d992e2a59fa71809b517a3e8d5f5960e03c | Emilio Cobos Álvarez | 2017-12-01T18:58:11 | servo: Merge #19447 - servo_arc: Add some #[inline] and repr(C) annotations (from emilio:arc-soundness); r=jdm
inline is probably unnecessary, but anyway... We rely on those being repr(C), so
they rather have some.
Source-Repo: https://github.com/servo/servo
Source-Revision: 210d0ab30a72b58c2797d29db3c2a5521730285e | diff --git a/servo_arc/lib.rs b/servo_arc/lib.rs
index cc378e237..0e77abd6e 100644
--- a/servo_arc/lib.rs
+++ b/servo_arc/lib.rs
@@ -127,6 +127,7 @@ impl<T: Sized + 'static> Hash for NonZeroPtrMut<T> {
}
}
+#[repr(C)]
pub struct Arc<T: ?Sized + 'static> {
p: NonZeroPtrMut<ArcInner<T>>,
}
@@ -168,6 +169,7... | 1 | 30 | 3 |
ae5ea8d9f40a7aebea4e645537986d3f84224988 | ddh | 2017-12-01T17:41:47 | servo: Merge #19307 - change parse_own_css to queue event not fire synchronously (from avadacatavra:domrefcellpanic); r=jdm
<!-- Please describe your changes on the following line: -->
fixes a panic and aligns with spec
I've also added checks around each mutable borrow of the tokenizer to see if we can catch any othe... | diff --git a/script/dom/document.rs b/script/dom/document.rs
index 5be8e9b76..0cd6b2255 100644
--- a/script/dom/document.rs
+++ b/script/dom/document.rs
@@ -1885,6 +1885,13 @@ impl Document {
self.current_parser.get()
}
+ pub fn can_invoke_script(&self) -> bool {
+ match self.get_current_parse... | 5 | 29 | 3 |
a494a71d75b09063fb4740610b94ae8832f5591f | Emilio Cobos Álvarez | 2017-12-01T16:41:33 | servo: Merge #19446 - style: Make -moz-border-colors chrome only (from emilio:bye-moz-border-colors); r=xidorn
This also makes the `border` shorthand not reset them.
Bug: 1417200
Reviewed-by: xidorn
MozReview-Commit-ID: KNais1e5FnE
Source-Repo: https://github.com/servo/servo
Source-Revision: af8d53372f1cb7364b07f48bb... | diff --git a/style/properties/longhand/border.mako.rs b/style/properties/longhand/border.mako.rs
index 89b707f90..2756cf280 100644
--- a/style/properties/longhand/border.mako.rs
+++ b/style/properties/longhand/border.mako.rs
@@ -74,6 +74,7 @@ ${helpers.gecko_keyword_conversion(Keyword('border-style',
... | 2 | 2 | 11 |
332daf37e3c1d7a7e7a580566942cba54043b877 | Emilio Cobos Álvarez | 2017-11-30T16:45:14 | servo: Merge #19438 - style: Remove redundant style sharing check (from emilio:redundant-sharing); r=upsuper
We check that a few lines before calling test_candidate.
Source-Repo: https://github.com/servo/servo
Source-Revision: ec794c82978a60dd0d5fb65b7712138c3535b714 | diff --git a/style/sharing/mod.rs b/style/sharing/mod.rs
index 360d644f4..79ddd58df 100644
--- a/style/sharing/mod.rs
+++ b/style/sharing/mod.rs
@@ -648,6 +648,8 @@ impl<E: TElement> StyleSharingCache<E> {
nth_index_cache: &mut NthIndexCache,
selector_flags_map: &mut SelectorFlagsMap<E>
) -> Opti... | 1 | 2 | 7 |
a8ba8ad52b2b95fdc22c15a88d73d56ca3d70ec1 | Xidorn Quan | 2017-11-30T14:23:07 | servo: Merge #19429 - Don't try to share style on quirks mode whenever two elements have different id (from upsuper:sharing-quirks-id); r=emilio
This fixes [bug 1420946](https://bugzilla.mozilla.org/show_bug.cgi?id=1420946).
Source-Repo: https://github.com/servo/servo
Source-Revision: fce44a2e139478a5fc3524c2fd72fbee... | diff --git a/style/stylist.rs b/style/stylist.rs
index a9ac4e9ab..1e5e7b39b 100644
--- a/style/stylist.rs
+++ b/style/stylist.rs
@@ -26,7 +26,7 @@ use rule_tree::{CascadeLevel, RuleTree, StrongRuleNode, StyleSource};
use selector_map::{PrecomputedHashMap, SelectorMap, SelectorMapEntry};
use selector_parser::{Selector... | 1 | 8 | 1 |
d0d6bc6f78c3bba6ccb39c412aa773307952c858 | Emilio Cobos Álvarez | 2017-11-30T11:30:01 | servo: Merge #19432 - style: Bail out from invalidation if we're the root and got tons of descendant invalidations (from emilio:invalidation-bail); r=heycam
Bug: 1420741
Reviewed-by: heycam
MozReview-Commit-ID: 4Kja20Ep9qD
Source-Repo: https://github.com/servo/servo
Source-Revision: e4d5e9699b9e784e5eba0aec316a35d0487... | diff --git a/style/invalidation/element/collector.rs b/style/invalidation/element/collector.rs
index 379fe471a..145b441b3 100644
--- a/style/invalidation/element/collector.rs
+++ b/style/invalidation/element/collector.rs
@@ -229,6 +229,17 @@ where
collector.invalidates_self
};
+ // If we ... | 1 | 11 | 0 |
f365072c80cd897b205dfd45a550e121e6efc984 | Emilio Cobos Álvarez | 2017-11-29T22:36:48 | servo: Merge #19426 - style: Require an nth-index cache for invalidation (from emilio:cache-invalidation); r=xidorn
Source-Repo: https://github.com/servo/servo
Source-Revision: 95aac490a5150fd1a354f25c61b01ee0406a1e84 | diff --git a/style/data.rs b/style/data.rs
index 6c02f5430..f1b92fae1 100644
--- a/style/data.rs
+++ b/style/data.rs
@@ -239,7 +239,7 @@ impl ElementData {
element: E,
shared_context: &SharedStyleContext,
stack_limit_checker: Option<&StackLimitChecker>,
- nth_index_cache: Option<&mut N... | 3 | 11 | 9 |
ea58cc26d9b3b6b0e4ef396f236969b327fa7d97 | CYBAI | 2017-11-29T21:24:33 | servo: Merge #19412 - style: Move grid-template-areas outside of mako (from CYBAI:grid-template-areas-out-of-mako); r=emilio
This is a sub-PR of #19015
r? emilio
---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #19409
- [x] These change... | diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs
index bd0a9d672..378274b7e 100644
--- a/style/properties/gecko.mako.rs
+++ b/style/properties/gecko.mako.rs
@@ -2252,7 +2252,7 @@ fn static_assert() {
${impl_simple_type_with_conversion("grid_auto_flow")}
- pub fn set_grid_template... | 7 | 195 | 185 |
a1198e15d26a6532868754f1b48aa82893ef5848 | Emilio Cobos Álvarez | 2017-11-29T20:14:58 | servo: Merge #19425 - style: Log a bit more information about invalidation collection (from emilio:log-invalidation); r=xidorn
Source-Repo: https://github.com/servo/servo
Source-Revision: 05b57e67b6f57ac8af8008c63134deeb5b5c1e12 | diff --git a/style/invalidation/element/collector.rs b/style/invalidation/element/collector.rs
index 49430fd1b..20bca37d6 100644
--- a/style/invalidation/element/collector.rs
+++ b/style/invalidation/element/collector.rs
@@ -164,6 +164,21 @@ where
}
}
+ debug!("Collecting changes for: {:?... | 2 | 18 | 3 |
3b40c198589cc85ea8beb87e91d836454b6dad9b | Matt Brubeck | 2017-11-29T17:47:33 | servo: Merge #19424 - Remove unused generic from push_applicable_declarations (from mbrubeck:veclike); r=emilio
This function is only ever used with one type.
This gets rid of the only use of the `smallvec::VecLike` trait, which we may want to deprecate (servo/rust-smallvec#35). If we do need to make this function g... | diff --git a/style/selector_map.rs b/style/selector_map.rs
index e3acda567..24ce93fa1 100644
--- a/style/selector_map.rs
+++ b/style/selector_map.rs
@@ -6,7 +6,7 @@
//! name, ids and hash.
use {Atom, LocalName};
-use applicable_declarations::ApplicableDeclarationBlock;
+use applicable_declarations::ApplicableDeclar... | 2 | 12 | 22 |
6519744d0126fcd43835ee8dfc468ab16102e794 | Simon Sapin | 2017-11-28T15:20:44 | servo: Merge #19411 - Replace parse-hosts crate with 10 lines of code (from servo:parse-hosts); r=nox
This removes 3927 lines of Rust code in 6 crates from the dependency graph: parse-hosts, multistr, bow, extra-default, len-trait, and push-trait.
One of these crates doesn’t build in today’s Nightly: https://github.c... | diff --git a/net/Cargo.toml b/net/Cargo.toml
index b03b5e7b1..d9d281f5d 100644
--- a/net/Cargo.toml
+++ b/net/Cargo.toml
@@ -28,7 +28,6 @@ mime_guess = "1.8.0"
msg = {path = "../msg"}
net_traits = {path = "../net_traits"}
openssl = "0.9"
-parse-hosts = "0.5.0"
profile_traits = {path = "../profile_traits"}
serde = ... | 3 | 12 | 8 |
22e12af89a0d7e19b455556ee2b015b40f8daaf1 | CYBAI | 2017-11-28T11:16:49 | servo: Merge #19378 - style: Move grid-auto-flow outside of mako (from CYBAI:grid-auto-flow-out-of-mako); r=emilio
This is a sub-PR of #19015
r? emilio
---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #19375
- [x] These changes do not r... | diff --git a/style/properties/longhand/position.mako.rs b/style/properties/longhand/position.mako.rs
index 179ef350c..00a8fd56c 100644
--- a/style/properties/longhand/position.mako.rs
+++ b/style/properties/longhand/position.mako.rs
@@ -293,128 +293,13 @@ ${helpers.predefined_type("object-position",
% endfor
-<%he... | 6 | 134 | 128 |
a1f3aa3acf3f7ac1e3c354bdabb675c1c196e6cb | CYBAI | 2017-11-28T10:08:51 | servo: Merge #19384 - Call children_changed on the parent node consistently (from CYBAI:fix-19177); r=emilio
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #19177
- [x] There are tests for these changes
Source-Repo: https://github.com/ser... | diff --git a/script/dom/characterdata.rs b/script/dom/characterdata.rs
index 65c84f1e2..1222084ed 100644
--- a/script/dom/characterdata.rs
+++ b/script/dom/characterdata.rs
@@ -70,6 +70,16 @@ impl CharacterData {
fn content_changed(&self) {
let node = self.upcast::<Node>();
node.dirty(NodeDamage:... | 1 | 10 | 10 |
208974890036e666cc677ee2dec17e23b196b3d0 | Boris Chiou | 2017-11-28T02:13:34 | servo: Merge #19388 - stylo: Implement Servo_ParseTransformIntoMatrix (from BorisChiou:stylo/dommatrix/parser); r=emilio,heycam
This is an inter-dependent patch of Bug 1408310.
DOMMatrix needs to convert a specified transform list into a matrix, so we rewrite
to_transform_3d_matrix by generics for both specified and ... | diff --git a/layout/fragment.rs b/layout/fragment.rs
index 020c4b65a..5366502ac 100644
--- a/layout/fragment.rs
+++ b/layout/fragment.rs
@@ -46,13 +46,13 @@ use style::computed_values::{transform_style, white_space, word_break};
use style::computed_values::content::ContentItem;
use style::logical_geometry::{Direction... | 11 | 408 | 228 |
d08f2a8333ac3f4f9a06208ef3916906e5860e32 | Emilio Cobos Álvarez | 2017-11-27T23:42:50 | servo: Merge #19391 - style: Add a comment about why early properties are early (from emilio:early-props-docs); r=upsuper
Source-Repo: https://github.com/servo/servo
Source-Revision: df50a9a81cfef5161c0dbb6b47d7d1df2b921bf5 | diff --git a/style/logical_geometry.rs b/style/logical_geometry.rs
index 3b029ba6a..08179ee4f 100644
--- a/style/logical_geometry.rs
+++ b/style/logical_geometry.rs
@@ -6,6 +6,7 @@
use euclid::{Point2D, Rect, Size2D, SideOffsets2D};
use euclid::num::Zero;
+use properties::style_structs;
use std::cmp::{max, min};
... | 2 | 105 | 56 |
29faf9c69160eee869d371865dcf3088be18403d | Emilio Cobos Álvarez | 2017-11-27T20:57:57 | servo: Merge #19398 - style: Disable :visited if the document is being used as an image (from emilio:visited-as-an-image); r=dholbert
Bug: 1420001
Reviewed-by: dholbert
MozReview-Commit-ID: F9MeT1kXZER
Source-Repo: https://github.com/servo/servo
Source-Revision: 7c99ae3bb8056f7e30a3b40340200eced385902d | diff --git a/style/gecko/data.rs b/style/gecko/data.rs
index 7192b75ed..53740eb89 100644
--- a/style/gecko/data.rs
+++ b/style/gecko/data.rs
@@ -164,12 +164,20 @@ impl PerDocumentStyleDataImpl {
}
/// Returns whether private browsing is enabled.
- pub fn is_private_browsing_enabled(&self) -> bool {
+ ... | 1 | 23 | 2 |
70b9206e3d0349cdec73fa798fd7ffb828a7dca3 | Emilio Cobos Álvarez | 2017-11-27T14:41:46 | servo: Merge #19390 - style: Minor cleanups while the sync service is down (from emilio:never-enough-cleanup); r=nox
I cannot land my Gecko-dependent patches, so let's do some cleanup in the meantime.
Source-Repo: https://github.com/servo/servo
Source-Revision: 6d49ec83a15f440f85cb9a045eaf104f30bd3053 | diff --git a/style/gecko/restyle_damage.rs b/style/gecko/restyle_damage.rs
index f8a43e8b7..cd79f644a 100644
--- a/style/gecko/restyle_damage.rs
+++ b/style/gecko/restyle_damage.rs
@@ -72,7 +72,8 @@ impl GeckoRestyleDamage {
} else {
StyleChange::Unchanged
};
- StyleDifference::new... | 8 | 184 | 170 |
5de998484bf8268f2a81e431ea2d45fc1eb757cf | Emilio Cobos Álvarez | 2017-11-26T18:45:41 | servo: Merge #19382 - style: Deindent some property declaration code (from emilio:pdb-deindent); r=canaltinova
Source-Repo: https://github.com/servo/servo
Source-Revision: ac6e04ebfbf27317fea00ea93e855520237b538d | diff --git a/style/properties/declaration_block.rs b/style/properties/declaration_block.rs
index 20bcb70f1..213d1df54 100644
--- a/style/properties/declaration_block.rs
+++ b/style/properties/declaration_block.rs
@@ -470,54 +470,56 @@ impl PropertyDeclarationBlock {
if !definitely_new {
let mut in... | 1 | 44 | 42 |
94c6ba2767b416f7049311215e6edf3c4e575d72 | Csoregi Natalia | 2017-11-26T11:01:43 | Backed out changeset 077ce85c466b for failing devtools webconsole/test/browser_webconsole_bug_595934_message_categories.js on Windows 7 debug without e10s. r=backout on a CLOSED TREE | diff --git a/style/gecko/generated/bindings.rs b/style/gecko/generated/bindings.rs
index aa320c6a4..1e09fa42b 100644
--- a/style/gecko/generated/bindings.rs
+++ b/style/gecko/generated/bindings.rs
@@ -1574,7 +1574,7 @@ extern "C" {
} extern "C" {
pub fn Servo_IsValidCSSColor ( value : * const nsAString , ) -> bool ;... | 1 | 2 | 2 |
8af3e7f9ece769711a6aa8256a56b88685572363 | Cameron McCormack | 2017-11-26T03:25:16 | servo: Merge #19374 - geckolib: Return from Servo_ComputeColor whether the value was currentcolor (from heycam:compute-color); r=TYLin
Servo part of https://bugzilla.mozilla.org/show_bug.cgi?id=1420026, reviewed there by TYLin.
Source-Repo: https://github.com/servo/servo
Source-Revision: b8b5c5371f66a95da9ffb238cba2c... | diff --git a/style/gecko/generated/bindings.rs b/style/gecko/generated/bindings.rs
index 1e09fa42b..aa320c6a4 100644
--- a/style/gecko/generated/bindings.rs
+++ b/style/gecko/generated/bindings.rs
@@ -1574,7 +1574,7 @@ extern "C" {
} extern "C" {
pub fn Servo_IsValidCSSColor ( value : * const nsAString , ) -> bool ;... | 1 | 2 | 2 |
731f3c131d2abd28c37353894eeb04d19651a50e | Jon Leighton | 2017-11-25T22:10:41 | servo: Merge #19358 - Move selection to end when textarea value is assigned (from jonleighton:issue-19171-3); r=KiChjang
Issue #19171
Source-Repo: https://github.com/servo/servo
Source-Revision: 3f0ccd0fef1ad108a22c731e399aa815d0af5441 | diff --git a/script/dom/htmltextareaelement.rs b/script/dom/htmltextareaelement.rs
index aa728dc5a..b9a6ad3ff 100755
--- a/script/dom/htmltextareaelement.rs
+++ b/script/dom/htmltextareaelement.rs
@@ -34,7 +34,7 @@ use std::default::Default;
use std::ops::Range;
use style::attr::AttrValue;
use style::element_state::... | 3 | 33 | 5 |
ce08d79db59953adc56d55d90c3fbf49442f4fbc | tigercosmos | 2017-11-25T16:56:06 | servo: Merge #19369 - Remove WrappedHttpResponse abstraction (from tigercosmos:a1); r=jdm
<!-- Please describe your changes on the following line: -->
Remove `WrappedHttpResponse` abstraction, and use `HyperResponse`
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is co... | diff --git a/net/http_loader.rs b/net/http_loader.rs
index af751ef54..e4bd2a7f3 100644
--- a/net/http_loader.rs
+++ b/net/http_loader.rs
@@ -94,36 +94,6 @@ fn precise_time_ms() -> u64 {
time::precise_time_ns() / (1000 * 1000)
}
-pub struct WrappedHttpResponse {
- pub response: HyperResponse
-}
-
-impl Read f... | 1 | 26 | 54 |
2adf18f61c22f65a1700f54fa4e6e68573a4804b | Emilio Cobos Álvarez | 2017-11-25T01:10:00 | servo: Merge #19371 - style: Don't insert into the `seen` set before ignoring document colors (from emilio:doc-colors); r=whoops
Otherwise we may stop honoring other colors in other cascade levels.
Fixes: #19370
Source-Repo: https://github.com/servo/servo
Source-Revision: 2377d60fa1deb56dcb5196e2206ef2b44ed296d5 | diff --git a/style/properties/properties.mako.rs b/style/properties/properties.mako.rs
index de650d52e..f1ddcd53b 100644
--- a/style/properties/properties.mako.rs
+++ b/style/properties/properties.mako.rs
@@ -3330,7 +3330,6 @@ where
if seen.contains(physical_longhand_id) {
continue
... | 1 | 2 | 1 |
1f9435248fb8c32c673051848c45ed1d179cc52d | Emilio Cobos Álvarez | 2017-11-24T21:59:00 | servo: Merge #19370 - style: Perform variable substitution less often (from emilio:not-so-many-vars); r=xidorn
We're wasting a bunch of work unneedlessly.
Source-Repo: https://github.com/servo/servo
Source-Revision: 990058475797e5832467616d77e7fed651c8a357 | diff --git a/style/properties/properties.mako.rs b/style/properties/properties.mako.rs
index 107481aa1..de650d52e 100644
--- a/style/properties/properties.mako.rs
+++ b/style/properties/properties.mako.rs
@@ -3276,12 +3276,6 @@ where
};
let ignore_colors = !device.use_document_colors();
- let default_bac... | 1 | 40 | 41 |
0cd192fdb0c270940b3d596cf38bc3bca01fee02 | Emilio Cobos Álvarez | 2017-11-24T20:51:46 | servo: Merge #19367 - style: Make a Servo-only assertion apply to Gecko too (from emilio:gecko-assert); r=upsuper
Gecko passes it now, and we want to know if that ever changes.
Source-Repo: https://github.com/servo/servo
Source-Revision: 8349be1b3e768b85fbb09ecb3dd4e9480a24f29e | diff --git a/style/traversal.rs b/style/traversal.rs
index ad600ca3f..b646b715d 100644
--- a/style/traversal.rs
+++ b/style/traversal.rs
@@ -256,8 +256,10 @@ pub trait DomTraversal<E: TElement> : Sync {
parent: E,
parent_data: &ElementData,
) -> bool {
- debug_assert!(cfg!(feature = "gecko... | 1 | 4 | 2 |
d626a3039aa441eb3b421d5f5383fa703f486ebe | Anthony Ramine | 2017-11-24T14:47:31 | servo: Merge #19363 - Use GeckoMedia and only that on platforms that support it (from nox:canplaytype-warning); r=ferjm
Source-Repo: https://github.com/servo/servo
Source-Revision: 3907953d8099dacde06d2156ee906d6ac043760d | diff --git a/script/dom/htmlmediaelement.rs b/script/dom/htmlmediaelement.rs
index a37a06d40..426f5ae32 100644
--- a/script/dom/htmlmediaelement.rs
+++ b/script/dom/htmlmediaelement.rs
@@ -870,22 +870,29 @@ impl HTMLMediaElementMethods for HTMLMediaElement {
self.media_element_load_algorithm();
}
+ #... | 1 | 20 | 13 |
8044e4a582042a9a140573a28d7af3cc302b11ae | Anthony Ramine | 2017-11-24T09:50:37 | servo: Merge #19364 - Update cookie to 0.10 (from nox:cookie); r=KiChjang
Except in webdriver, which source is in m-c.
Source-Repo: https://github.com/servo/servo
Source-Revision: 56b5a4d8cb3a6feecf4df45f9b54f87fa0cb48cb | diff --git a/devtools/Cargo.toml b/devtools/Cargo.toml
index f5d149f40..91a05ef31 100644
--- a/devtools/Cargo.toml
+++ b/devtools/Cargo.toml
@@ -12,7 +12,7 @@ path = "lib.rs"
[dependencies]
devtools_traits = {path = "../devtools_traits"}
hyper = "0.10"
-hyper_serde = "0.7"
+hyper_serde = "0.8"
ipc-channel = "0.9"
... | 7 | 11 | 11 |
bf4c636027e361ed9d214af99b4e3e397dac6b88 | Dzmitry Malyshau | 2017-11-23T20:03:19 | servo: Merge #19360 - WR update to 4595561c49939cb21be9554c1b85c244508bde73 (from kvark:wr-fix); r=jdm
<!-- Please describe your changes on the following line: -->
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- ... | diff --git a/compositing/compositor.rs b/compositing/compositor.rs
index 092131141..49e2b58b7 100644
--- a/compositing/compositor.rs
+++ b/compositing/compositor.rs
@@ -769,7 +769,7 @@ impl<Window: WindowMethods> IOCompositor<Window> {
warn!("Sending event to constellation failed ({}).", e);
... | 3 | 3 | 4 |
aaa878d1d1bbfd1b25184d3ad5b8788542a248a2 | Imanol Fernandez | 2017-11-23T17:14:11 | servo: Merge #19352 - Handle arraybuffer responseType in XHR (from MortimerGoro:xhr_arraybuffer); r=jdm
<!-- Please describe your changes on the following line: -->
Handle arraybuffer responseType in XHR
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and r... | diff --git a/script/dom/xmlhttprequest.rs b/script/dom/xmlhttprequest.rs
index c36a1df67..a316ed8b8 100644
--- a/script/dom/xmlhttprequest.rs
+++ b/script/dom/xmlhttprequest.rs
@@ -14,6 +14,7 @@ use dom::bindings::codegen::UnionTypes::DocumentOrBodyInit;
use dom::bindings::conversions::ToJSValConvertible;
use dom::bi... | 1 | 29 | 4 |
e7153c3bcccbe6c99108d48c29e2fa4ddc6aeb8f | Cameron McCormack | 2017-11-23T15:23:25 | servo: Merge #19349 - style: Stop using nsMediaExpression_Range (from heycam:media-feature-range); r=emilio
Servo part of https://bugzilla.mozilla.org/show_bug.cgi?id=1420071, reviewed there by Emilio.
Source-Repo: https://github.com/servo/servo
Source-Revision: 7ac376eed62ae6a7bb16b1115e718f9c9aee3b00 | diff --git a/style/gecko/media_queries.rs b/style/gecko/media_queries.rs
index 9030e1452..7bb35b72b 100644
--- a/style/gecko/media_queries.rs
+++ b/style/gecko/media_queries.rs
@@ -14,8 +14,7 @@ use gecko::values::{convert_nscolor_to_rgba, convert_rgba_to_nscolor};
use gecko_bindings::bindings;
use gecko_bindings::st... | 1 | 26 | 16 |
ce8e31a94aeb6349bdca6170715ac95dfc372681 | Keith Yeung | 2017-11-23T14:26:03 | servo: Merge #19185 - Implement secure and host cookie prefixes (from KiChjang:cookie-prefixes); r=avadacatavra
Part of #8700.
I modified the algorithm so that it accurately checks for the presence of the `Path` attribute of the cookie, before checking whether it has a value of `/`.
Source-Repo: https://github.com/s... | diff --git a/net/cookie.rs b/net/cookie.rs
index 7029ddee0..e8e7be673 100644
--- a/net/cookie.rs
+++ b/net/cookie.rs
@@ -82,7 +82,11 @@ impl Cookie {
};
// Step 7
- let mut path = cookie.path().unwrap_or("").to_owned();
+ let mut has_path_specified = true;
+ let mut path = cooki... | 1 | 23 | 4 |
f4a0d8de1536adbb31f963cef0c697b5e3a39f52 | Philippe Normand | 2017-11-23T12:52:27 | servo: Merge #19337 - Implement HTMLMediaElement::canPlayType using gecko-media (from philn:gecko-canPlayType); r=nox
<!-- Please describe your changes on the following line: -->
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropria... | diff --git a/script/dom/htmlmediaelement.rs b/script/dom/htmlmediaelement.rs
index 1122e267e..a37a06d40 100644
--- a/script/dom/htmlmediaelement.rs
+++ b/script/dom/htmlmediaelement.rs
@@ -31,10 +31,13 @@ use dom::node::{window_from_node, document_from_node, Node, UnbindContext};
use dom::promise::Promise;
use dom::v... | 1 | 17 | 0 |
953b6f66343538ba1814613877eae7762abc82ba | CYBAI | 2017-11-23T10:28:18 | servo: Merge #19339 - style: Move -moz-script-size-multiplier outside of mako (from CYBAI:moz-script-size-multiplier-out-of-mako); r=emilio
This is a sub-PR of #19015
r? emilio
---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #19333
- [... | diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs
index 6230b7a23..d27b6a2da 100644
--- a/style/properties/gecko.mako.rs
+++ b/style/properties/gecko.mako.rs
@@ -1514,6 +1514,7 @@ impl Clone for ${style_struct.gecko_struct_name} {
"MaxLength": impl_style_coord,
"MozLength": ... | 6 | 51 | 25 |
a63b0d37e4df010a3a5894325bd6361ebec8bd5c | Manish Goregaokar | 2017-11-23T00:30:57 | servo: Merge #19329 - Add RAII guard for cancelling fetch when the consumer no longer cares about it (from Manishearth:fetchcanceller); r=jdm
Source-Repo: https://github.com/servo/servo
Source-Revision: 976f9e3d13b6a7676dd863dd397dd6c60e868d58 | diff --git a/constellation/constellation.rs b/constellation/constellation.rs
index 3fa7ce3c5..2eb19e921 100644
--- a/constellation/constellation.rs
+++ b/constellation/constellation.rs
@@ -1110,9 +1110,9 @@ impl<Message, LTF, STF> Constellation<Message, LTF, STF>
FromScriptMsg::PipelineExited => {
... | 12 | 110 | 35 |
97d0b08f491525485be93b4f5d92aff12e72aeb1 | Michael Wilson | 2017-11-22T10:04:39 | servo: Merge #19332 - moving :dir() param serialization FIXME (from wilsoniya:moving-fixme); r=emilio
<!-- Please describe your changes on the following line: -->
Per emilio's comment, https://github.com/servo/servo/pull/19195#discussion_r152205644, a `FIXME` regarding `:dir()` parameter serialization has been moved.
... | diff --git a/style/gecko/selector_parser.rs b/style/gecko/selector_parser.rs
index 75e53a01d..827e832eb 100644
--- a/style/gecko/selector_parser.rs
+++ b/style/gecko/selector_parser.rs
@@ -96,7 +96,6 @@ impl ToCss for NonTSPseudoClass {
}, )*
NonTSPseudoClass::Dir(ref dir) => {... | 2 | 1 | 1 |
1362990061dbc7167101c294168694c109d32ec8 | Bastien Orivel | 2017-11-22T03:01:35 | servo: Merge #19328 - Remove cancellation map and ResourceId from the net* components (from Eijebong:remove_old_cancellation_code); r=KiChjang
Fixes #19327
Source-Repo: https://github.com/servo/servo
Source-Revision: 78fb3c206d30da8e7b16ea941268b733b21059ed | diff --git a/net/resource_thread.rs b/net/resource_thread.rs
index da16897fc..c319db985 100644
--- a/net/resource_thread.rs
+++ b/net/resource_thread.rs
@@ -17,9 +17,9 @@ use http_loader::{HttpState, http_redirect_fetch};
use hyper_serde::Serde;
use ipc_channel::ipc::{self, IpcReceiver, IpcReceiverSet, IpcSender};
u... | 2 | 3 | 17 |
3c1e77ec870d862cde13118fb484fd60b599fe48 | Dzmitry Malyshau | 2017-11-22T00:40:36 | servo: Merge #19314 - Update WR and the whole macOS crate stack (from servo:wr); r=jdm
Source-Repo: https://github.com/servo/servo
Source-Revision: 37fa711657e6684e234e855be03470a0e17307de | diff --git a/compositing/compositor.rs b/compositing/compositor.rs
index 28bb0a524..092131141 100644
--- a/compositing/compositor.rs
+++ b/compositing/compositor.rs
@@ -329,12 +329,21 @@ impl webrender_api::RenderNotifier for RenderNotifier {
Box::new(RenderNotifier::new(self.compositor_proxy.clone()))
}
... | 4 | 21 | 11 |
58278198da9e35f8d1ffef1248b8a861acdcc74b | Emilio Cobos Álvarez | 2017-11-21T21:27:59 | servo: Merge #19321 - style: Avoid unneessary malloc churn when evaluating @supports rules (from emilio:supports-dumb); r=SimonSapin
Source-Repo: https://github.com/servo/servo
Source-Revision: 06d834c1b984b4fae55da4ac82b5fbe002295dda | diff --git a/style/stylesheets/supports_rule.rs b/style/stylesheets/supports_rule.rs
index 1eae1e9b0..6539560e0 100644
--- a/style/stylesheets/supports_rule.rs
+++ b/style/stylesheets/supports_rule.rs
@@ -256,7 +256,7 @@ impl Declaration {
let mut input = ParserInput::new(&self.0);
let mut input = Par... | 1 | 2 | 2 |
f721b150dc459dba18ebc8fd8de1be9245ad6a63 | CYBAI | 2017-11-21T19:46:49 | servo: Merge #19322 - style: Move -x-lang outside of mako (from CYBAI:x-lang-out-of-mako); r=emilio
This is a sub-PR of #19015
r? emilio
---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #19320
- [x] These changes do not require tests
S... | diff --git a/style/properties/longhand/font.mako.rs b/style/properties/longhand/font.mako.rs
index 62900020f..dc73f537e 100644
--- a/style/properties/longhand/font.mako.rs
+++ b/style/properties/longhand/font.mako.rs
@@ -699,37 +699,13 @@ ${helpers.predefined_type("font-language-override",
fl... | 5 | 38 | 35 |
0e90e4dee47083b8a565d7b318a9a4a24f5ff85f | Josh Matthews | 2017-11-21T18:25:55 | servo: Merge #19318 - Make wdspec tests runnable (from jdm:webdriver); r=jgraham
This makes it possible to run tests in tests/wpt/web-platform-tests/webdriver/tests and focus on investigating why they fail.
---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x... | diff --git a/webdriver_server/Cargo.toml b/webdriver_server/Cargo.toml
index 6c1cc50e5..ddd46de18 100644
--- a/webdriver_server/Cargo.toml
+++ b/webdriver_server/Cargo.toml
@@ -26,4 +26,4 @@ servo_config = {path = "../config"}
servo_url = {path = "../url"}
url = "1.2"
uuid = {version = "0.5", features = ["v4"]}
-web... | 3 | 35 | 21 |
67949613c07e38358181d38df8fe936be931eefa | Anthony Ramine | 2017-11-21T16:13:02 | servo: Merge #19225 - Shut down the media stack when shutting down the constellation (from servo:media); r=jdm
Source-Repo: https://github.com/servo/servo
Source-Revision: b13107a31864b24463d112aca4e94c93d597243c | diff --git a/constellation/Cargo.toml b/constellation/Cargo.toml
index 0e48b302d..3968d5f11 100644
--- a/constellation/Cargo.toml
+++ b/constellation/Cargo.toml
@@ -43,3 +43,6 @@ webrender_api = {git = "https://github.com/servo/webrender", features = ["ipc"]}
[target.'cfg(all(not(target_os = "windows"), not(target_o... | 3 | 17 | 0 |
ab957cb63054f6e4e57925cf1b7dd74b6632a78b | Hugh Gallagher | 2017-11-21T14:51:52 | servo: Merge #19319 - Removed unused import in net/http_cache.rs (from hgallagher1993:local_branch); r=jdm
<!-- Please describe your changes on the following line: -->
`use http_loader::is_redirect_status;` was unused
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is co... | diff --git a/net/http_cache.rs b/net/http_cache.rs
index cd0211399..1b7d8ad37 100644
--- a/net/http_cache.rs
+++ b/net/http_cache.rs
@@ -8,7 +8,6 @@
//! and <http://tools.ietf.org/html/rfc7232>.
use fetch::methods::DoneChannel;
-use http_loader::is_redirect_status;
use hyper::header;
use hyper::header::ContentTyp... | 1 | 0 | 1 |
3d533f5b02b80b27736dd0777d826af251da2783 | Emilio Cobos Álvarez | 2017-11-21T13:47:52 | servo: Merge #19317 - style: Move property allowance tests to PropertyId::parse_into (from emilio:property-allowed-in); r=SimonSapin
It's not only more consistent (since we have a proper ParserContext there), but
also fixes a bunch of bugs where Gecko accidentally exposes and allows setting
internal state because of c... | diff --git a/layout/query.rs b/layout/query.rs
index 7fac8d3b5..13ecfd7a8 100644
--- a/layout/query.rs
+++ b/layout/query.rs
@@ -689,9 +689,11 @@ pub fn process_resolved_style_request<'a, N>(context: &LayoutContext,
let styles = resolve_style(&mut context, element, RuleInclusion::All, false, pseudo.as_ref());
... | 8 | 134 | 133 |
bcbdf7ccb1ea4051698458d0533f149be608a787 | Emilio Cobos Álvarez | 2017-11-21T10:27:25 | servo: Merge #19315 - style: Enable chrome-only CSS features in user stylesheets (from emilio:chrome-rules-user-sheets); r=heycam
MozReview-Commit-ID: FJ4vTiOrotH
Bug: 1418963
Reviewed-by: heycam
Source-Repo: https://github.com/servo/servo
Source-Revision: 5905f8d3eab42ce759c9802699ee5bd50498dd59 | diff --git a/style/gecko/media_queries.rs b/style/gecko/media_queries.rs
index 1ee90e2fe..9030e1452 100644
--- a/style/gecko/media_queries.rs
+++ b/style/gecko/media_queries.rs
@@ -588,7 +588,7 @@ impl Expression {
let mut flags = 0;
- if context.in_chrome_stylesheet() ||
+ ... | 5 | 52 | 29 |
d16f73221004965ad3745dbd5466aa036c28eead | Michael Wilson | 2017-11-21T08:56:49 | servo: Merge #19195 - style: :dir() pseudo class now represented by enum (from wilsoniya:issue-16840); r=emilio
`:dir()` pseudo class param now represented as enum variants.
---
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #16840
- [X] ... | diff --git a/selectors/gecko_like_types.rs b/selectors/gecko_like_types.rs
index e0ef0f81e..de0c4034e 100644
--- a/selectors/gecko_like_types.rs
+++ b/selectors/gecko_like_types.rs
@@ -10,6 +10,7 @@
pub enum PseudoClass {
Bare,
String(Box<[u16]>),
+ Dir(Box<()>),
MozAny(Box<[()]>),
}
diff --git a/... | 7 | 73 | 27 |
e9d692f195675cf11b1c0d329b89d89f532f7958 | Ting-Yu Lin | 2017-11-21T07:39:44 | servo: Merge #19312 - style: Use ComputedUrl instead of SpecifiedUrl in conversion.rs (from aethanyc:use-computedurl); r=heycam
In stylo, ComputedUrl and SpecifiedUrl happen to be the same. However, using
ComputedUrl can make code clearer that conversion.rs is for converting
computed values between gecko and servo typ... | diff --git a/style/gecko/conversions.rs b/style/gecko/conversions.rs
index cc879dfd7..c23f760fa 100644
--- a/style/gecko/conversions.rs
+++ b/style/gecko/conversions.rs
@@ -17,13 +17,12 @@ use gecko_bindings::structs::{nsStyleImage, nsresult, SheetType};
use gecko_bindings::sugar::ns_style_coord::{CoordDataValue, Coor... | 2 | 9 | 10 |
b8e10342976b69e026ddb552d2001f691a72a588 | Manish Goregaokar | 2017-11-21T02:48:17 | servo: Merge #19274 - Fetch cancellation (from Manishearth:xhr-cancel); r=jdm
This PR implements cancellation for fetch, and uses it for XHR. This means that fetch clients can now send a message to the fetch task asking for the network request to be aborted.
Previously, clients like XHR had abort functionality but wo... | diff --git a/constellation/network_listener.rs b/constellation/network_listener.rs
index 034dacf0e..2a39c4bec 100644
--- a/constellation/network_listener.rs
+++ b/constellation/network_listener.rs
@@ -57,14 +57,14 @@ impl NetworkListener {
Some(ref res_init_) => CoreResourceMsg::FetchRedirect(
... | 10 | 93 | 28 |
e120b483f2f5ce2f2fcbf5c5139349dba570689e | Jon Leighton | 2017-11-21T01:31:52 | servo: Merge #19272 - Further changes in relation to #19171 (from jonleighton:issue-19171-2); r=jdm
Source-Repo: https://github.com/servo/servo
Source-Revision: 979793593269ed1197e15adeb0b029662ff9d460 | diff --git a/script/dom/htmlinputelement.rs b/script/dom/htmlinputelement.rs
index 78afb4630..e048f4193 100755
--- a/script/dom/htmlinputelement.rs
+++ b/script/dom/htmlinputelement.rs
@@ -31,6 +31,7 @@ use dom::mouseevent::MouseEvent;
use dom::node::{Node, NodeDamage, UnbindContext};
use dom::node::{document_from_no... | 4 | 118 | 66 |
7d17ed98b09c48e97960ca1acf35d146f80a2f8c | Gregory Terzian | 2017-11-21T00:22:06 | servo: Merge #18676 - Continue http cache work (from gterzian:continue_http_cache_work); r=jdm
<!-- Please describe your changes on the following line: -->
Work in progress, and not quite worth a review yet. (Continuation of https://github.com/servo/servo/pull/4117)
TODO
- [ ] cache metadata (find some subset of`ne... | diff --git a/net/http_cache.rs b/net/http_cache.rs
new file mode 100644
index 000000000..cd0211399
--- /dev/null
+++ b/net/http_cache.rs
@@ -0,0 +1,655 @@
+/* This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obt... | 7 | 721 | 49 |
61886f88a2b78b948708594d74fdf59bfe55d406 | Emilio Cobos Álvarez | 2017-11-20T21:58:46 | servo: Merge #19297 - style: Expose some properties to chrome code, and hide some accidentally-exposed ones (from emilio:hidden-props); r=upsuper
I'm adding a test for internal properties after this in Gecko.
Source-Repo: https://github.com/servo/servo
Source-Revision: e67bb6ccb5a4fa64f5aaea76cfe76943e873c7c5 | diff --git a/style/properties/longhand/font.mako.rs b/style/properties/longhand/font.mako.rs
index 585d6510a..62900020f 100644
--- a/style/properties/longhand/font.mako.rs
+++ b/style/properties/longhand/font.mako.rs
@@ -768,6 +768,7 @@ ${helpers.single_keyword("-moz-math-display",
gecko_const... | 2 | 9 | 5 |
3c0898d91a6257384a49f213d8d7b7c34b46d766 | Emilio Cobos Álvarez | 2017-11-20T14:57:50 | servo: Merge #19303 - style: Account for fallback content in GetFlattenedTreeParent (from emilio:flattened-tree-fallback); r=heycam
Otherwise we may inappropriately style it or what not. This asserts with the
patches of bug 1414999 plus the cleanup of bug 1418456, since we no longer do
StyleNewChildren (which walks ov... | diff --git a/style/gecko/wrapper.rs b/style/gecko/wrapper.rs
index d26a1d866..ec3d6f919 100644
--- a/style/gecko/wrapper.rs
+++ b/style/gecko/wrapper.rs
@@ -227,8 +227,10 @@ impl<'ln> GeckoNode<'ln> {
return false;
}
- if parent_el.map_or(false, |el| el.has_shadow_root()) {
- r... | 1 | 4 | 2 |
41d3dc5b87198ec8ef9ff58f73516ae505e1ddd3 | CYBAI | 2017-11-20T13:58:00 | servo: Merge #19298 - Implement normal for FontSettings (from CYBAI:implement-normal-for-fontsettings); r=emilio
As discussed with emilio in #19293 , this PR will move the `normal` function into `FontSettings` implementation.
r? emilio
---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` do... | diff --git a/style/values/computed/font.rs b/style/values/computed/font.rs
index ed2b7c9f8..86f33856d 100644
--- a/style/values/computed/font.rs
+++ b/style/values/computed/font.rs
@@ -290,14 +290,6 @@ pub type FontVariantNumeric = specified::VariantNumeric;
/// Use FontSettings as computed type of FontFeatureSettings... | 3 | 8 | 16 |
fd6497f62d990f1a63284c36837273d383bbfd55 | Emilio Cobos Álvarez | 2017-11-20T10:18:30 | servo: Merge #19296 - style: Get rid of unstyled children only traversals (from emilio:bye-unstyled-only); r=heycam
They're useless now, provided we remove the hack to not traverse XBL-bound
elements on initial styling.
Bug: 1418456
Reviewed-by: heycam
MozReview-Commit-ID: AvBVdyF1wb6
Source-Repo: https://github.com/... | diff --git a/style/dom.rs b/style/dom.rs
index 1916e8db7..b78493272 100644
--- a/style/dom.rs
+++ b/style/dom.rs
@@ -557,11 +557,6 @@ pub trait TElement
!data.hint.has_animation_hint_or_recascade();
}
- if traversal_flags.contains(TraversalFlags::UnstyledOnly) {
- // We ... | 3 | 7 | 66 |
dbb6f3b2555c2ac26cd40f8dd4ca94b1ce845396 | Emilio Cobos Álvarez | 2017-11-20T08:29:59 | servo: Merge #19294 - style: Collect more debugging info when collecting rules of detached pseudos (from emilio:debug-detached-pseudo); r=heycam
Called Option::unwrap() on a None value is not a helpful crash message.
This will hopefully help figure out what is causing bug 1418856.
Source-Repo: https://github.com/ser... | diff --git a/style/dom.rs b/style/dom.rs
index b1a123073..1916e8db7 100644
--- a/style/dom.rs
+++ b/style/dom.rs
@@ -756,11 +756,18 @@ pub trait TElement
/// element-backed pseudo-element, in which case we return the originating
/// element.
fn rule_hash_target(&self) -> Self {
- let is_implemente... | 1 | 12 | 5 |
eed232517898519782217a563940db3b07f932bb | CYBAI | 2017-11-20T06:48:16 | servo: Merge #19293 - style: Move font-feature-settings outside of mako (from CYBAI:font-feature-settings-out-of-mako); r=emilio
This is a sub-PR of #19015
r? emilio
---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #19290
- [x] These ch... | diff --git a/style/properties/longhand/font.mako.rs b/style/properties/longhand/font.mako.rs
index c0dda84c2..585d6510a 100644
--- a/style/properties/longhand/font.mako.rs
+++ b/style/properties/longhand/font.mako.rs
@@ -15,42 +15,6 @@
%endif
</%def>
-// Define ToComputedValue, ToCss, and other boilerplate for ... | 5 | 91 | 75 |
c9107016c33d20466bcbb246b9c15d1adb5fd945 | CYBAI | 2017-11-20T03:43:25 | servo: Merge #19282 - Use macro to impl From for font variant (from CYBAI:use-macro-for-font-variant); r=canaltinova
As I discussed in #19277, I'd like to change the implementation for `From` of font variant to use macro, `impl_gecko_keyword_conversions`.
r? @emilio
---
- [x] `./mach build -d` does not report any err... | diff --git a/style/values/specified/font.rs b/style/values/specified/font.rs
index 56e4b88b1..b0690f557 100644
--- a/style/values/specified/font.rs
+++ b/style/values/specified/font.rs
@@ -929,18 +929,7 @@ impl ToCss for VariantEastAsian {
}
#[cfg(feature = "gecko")]
-impl From<u16> for VariantEastAsian {
- fn f... | 1 | 2 | 24 |
ff95da7fbe564a3941c020697a05db50d27afe71 | Cameron McCormack | 2017-11-20T02:18:57 | servo: Merge #19292 - style: Add comment about -moz-control-character-visibility initial value (from heycam:moz-cc-comment); r=KiChjang
Source-Repo: https://github.com/servo/servo
Source-Revision: cea3fd62297e5e61fb6676ff53b2988d378d3c86 | diff --git a/style/properties/longhand/inherited_text.mako.rs b/style/properties/longhand/inherited_text.mako.rs
index cc3ae4d52..d0b616c86 100644
--- a/style/properties/longhand/inherited_text.mako.rs
+++ b/style/properties/longhand/inherited_text.mako.rs
@@ -745,6 +745,8 @@ ${helpers.single_keyword("text-rendering",
... | 1 | 2 | 0 |
801c06410511d0ba34b6b810946e6ceb62cf98fc | Nazım Can Altınova | 2017-11-19T20:07:35 | servo: Merge #19279 - style: Move -moz-force-broken-image-icon out of mako (from canaltinova:force-broken-image); r=emilio
<!-- Please describe your changes on the following line: -->
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appr... | diff --git a/style/properties/longhand/ui.mako.rs b/style/properties/longhand/ui.mako.rs
index c48cf01ba..f2d79d77f 100644
--- a/style/properties/longhand/ui.mako.rs
+++ b/style/properties/longhand/ui.mako.rs
@@ -63,57 +63,9 @@ ${helpers.predefined_type("-moz-window-transform-origin",
enabled... | 5 | 71 | 54 |
7407ced201eab4ac1d9bc8c31f41914748c8777b | Christian Gati | 2017-11-18T21:09:15 | servo: Merge #19182 - Treat application/xml like text/xml in ParserContext::process_response (from cgati:parse-xml); r=KiChjang
<!-- Please describe your changes on the following line: -->
* components/script/dom/servoparser/mod.rs updated to handle application/xml as text/xml, along with hoisting application/xhtml+x... | diff --git a/script/dom/servoparser/mod.rs b/script/dom/servoparser/mod.rs
index 1478c043d..7a948890a 100644
--- a/script/dom/servoparser/mod.rs
+++ b/script/dom/servoparser/mod.rs
@@ -652,13 +652,11 @@ impl FetchResponseListener for ParserContext {
parser.parse_sync();
}
... | 1 | 4 | 6 |
36d9e5c4472f51420acfa04fbb091714935fc3be | CYBAI | 2017-11-18T19:22:10 | servo: Merge #19277 - style: Move font-variant-numeric outside of mako (from CYBAI:font-variant-numeric-out-of-mako); r=emilio
This is a sub-PR of #19015
r? @emilio
---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #19276
- [x] These cha... | diff --git a/style/macros.rs b/style/macros.rs
index 236a03f1f..aa505498d 100644
--- a/style/macros.rs
+++ b/style/macros.rs
@@ -14,6 +14,23 @@ macro_rules! exclusive_value {
}
}
+#[cfg(feature = "gecko")]
+macro_rules! impl_gecko_keyword_conversions {
+ ($name: ident, $utype: ty) => {
+ impl From<$ut... | 6 | 253 | 176 |
8daf8633e47e208cacc7d5b59d843f6af9c93a13 | Cameron McCormack | 2017-11-18T06:47:57 | servo: Merge #19263 - selectors: Allow white space in the brackets of an attribute selector (from heycam:attr-ws); r=SimonSapin
Source-Repo: https://github.com/servo/servo
Source-Revision: 7b886b4479763018ecad62aa6db96049732ca9ed | diff --git a/selectors/parser.rs b/selectors/parser.rs
index 88ee70bde..6be95b5d0 100644
--- a/selectors/parser.rs
+++ b/selectors/parser.rs
@@ -1365,6 +1365,9 @@ where
{
let namespace;
let local_name;
+
+ input.skip_whitespace();
+
match parse_qualified_name(parser, input, /* in_attr_selector = */ t... | 1 | 3 | 0 |
44b078bd0fe5147d3f8b94495352904828f12eb2 | CYBAI | 2017-11-17T21:03:14 | servo: Merge #19253 - style: Move font-variant-ligatures outside of mako (from CYBAI:font-variant-ligatures-out-of-mako); r=emilio
This is a sub-PR of #19015
r? @emilio
---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #19246
- [x] These... | diff --git a/style/properties/longhand/font.mako.rs b/style/properties/longhand/font.mako.rs
index 726843b23..917237b0b 100644
--- a/style/properties/longhand/font.mako.rs
+++ b/style/properties/longhand/font.mako.rs
@@ -699,167 +699,14 @@ ${helpers.predefined_type("font-variant-east-asian",
... | 6 | 272 | 165 |
5eb5a2ae546b03f378327f069c4065e1d2bf2594 | Emilio Cobos Álvarez | 2017-11-17T16:03:05 | servo: Merge #19264 - style: Remove unused argument in element_needs_traversal (from emilio:unused-arg); r=mbrubeck
Source-Repo: https://github.com/servo/servo
Source-Revision: bd6caef234f9a1c29cc01c907255a4f307fbc827 | diff --git a/layout/traversal.rs b/layout/traversal.rs
index c6cc07ae7..b69d69268 100644
--- a/layout/traversal.rs
+++ b/layout/traversal.rs
@@ -76,8 +76,7 @@ impl<'a, E> DomTraversal<E> for RecalcStyleAndConstructFlows<'a>
// flow construction:
// (1) They child doesn't yet have layout data (preorder... | 2 | 7 | 15 |
d7ad95b47772627269d903df1a2438d6bfa1736b | Glenn Watson | 2017-11-17T00:38:48 | servo: Merge #19260 - Update WR (opaque image optimizations, property binding optimizations) (from glennw:update-wr-bindings-opaque); r=emilio
Source-Repo: https://github.com/servo/servo
Source-Revision: e61a4d04e9982df94c402916da1cddfd6d0fdfa7 | diff --git a/layout/webrender_helpers.rs b/layout/webrender_helpers.rs
index 3f7940aad..1976c1418 100644
--- a/layout/webrender_helpers.rs
+++ b/layout/webrender_helpers.rs
@@ -200,7 +200,9 @@ impl ToFilterOps for Vec<Filter> {
GenericFilter::Grayscale(amount) => result.push(webrender_api::FilterOp::Gr... | 1 | 3 | 1 |
4428d3c0e031023adb206e653e33373f50bc984c | tigercosmos | 2017-11-16T13:49:20 | servo: Merge #19249 - fix annotation URL (from tigercosmos:info); r=jdm
The annotation URL for `scroll_node` is wrong. (The origin URL is where it is called, not its implement.)
The implement is in https://drafts.csswg.org/cssom-view/#element-scrolling-members
---
<!-- Thank you for contributing to Servo! Please repl... | diff --git a/script/dom/window.rs b/script/dom/window.rs
index 9e514a4fd..76457e1ba 100644
--- a/script/dom/window.rs
+++ b/script/dom/window.rs
@@ -1418,7 +1418,7 @@ impl Window {
Vector2D::new(0.0, 0.0)
}
- // https://drafts.csswg.org/cssom-view/#dom-element-scroll
+ // https://drafts.csswg.org/... | 1 | 1 | 1 |
b9a834cc0b5931d767af9f413cad26f817023e32 | Anthony Ramine | 2017-11-16T12:47:34 | servo: Merge #19247 - Bump servo-websocket to 0.20 (from servo:bumps); r=jdm
This removes one use of an obsolete bitflags version.
Source-Repo: https://github.com/servo/servo
Source-Revision: 2755c1a89a4576c6a737f6f1ac2e5d68f99213db | diff --git a/net/Cargo.toml b/net/Cargo.toml
index 074cbfe7d..ae607b565 100644
--- a/net/Cargo.toml
+++ b/net/Cargo.toml
@@ -34,7 +34,7 @@ serde = "1.0"
serde_json = "1.0"
servo_config = {path = "../config"}
servo_url = {path = "../url"}
-servo-websocket = "0.19"
+servo-websocket = "0.20"
threadpool = "1.0"
time =... | 1 | 1 | 1 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.