commit_hash stringlengths 40 40 | author stringlengths 1 57 | date timestamp[s]date 2010-07-26 04:45:09 2026-04-14 18:21:10 | message stringlengths 8 1.39M | diff stringlengths 68 51.2k | files_changed int64 1 136 | insertions int64 0 2.35k | deletions int64 0 1.9k |
|---|---|---|---|---|---|---|---|
dadfedb04f2bda91e6b3bcc484ef9b8c44294e6b | Sebastian Hengst | 2017-10-20T19:31:59 | Backed out changeset 196206f129ef (bug 1403213) for referencing non-existing xpcom/rust/gtest/moz.build in xpcom/moz.build. r=backout on a CLOSED TREE | diff --git a/style/Cargo.toml b/style/Cargo.toml
index 821b8eb71..6c692a743 100644
--- a/style/Cargo.toml
+++ b/style/Cargo.toml
@@ -16,7 +16,7 @@ path = "lib.rs"
doctest = false
[features]
-gecko = ["nsstring", "num_cpus",
+gecko = ["nsstring_vendor", "num_cpus",
"style_traits/gecko", "fallible/known_sys... | 4 | 1,044 | 4 |
94002c94ca0f51b782ba864bd874880c99b61f5a | Nika Layzell | 2017-10-20T17:32:05 | servo: Merge #18941 - Move nsstring from gecko into servo/support/gecko/nsstring (from mystor:nsstring); r=mystor
This is the servo side of bug 1403213.
This cannot merge until https://bugzilla.mozilla.org/show_bug.cgi?id=1377351 merges. It is currently on inbound. This will break autoland when it merges until the ge... | diff --git a/style/Cargo.toml b/style/Cargo.toml
index 6c692a743..821b8eb71 100644
--- a/style/Cargo.toml
+++ b/style/Cargo.toml
@@ -16,7 +16,7 @@ path = "lib.rs"
doctest = false
[features]
-gecko = ["nsstring_vendor", "num_cpus",
+gecko = ["nsstring", "num_cpus",
"style_traits/gecko", "fallible/known_sys... | 4 | 4 | 1,044 |
087e55dbf366ae9cf982b38da4297d66c7c2a226 | Nikhil Shagrithaya | 2017-10-20T13:49:09 | servo: Merge #18946 - Update h5e version (from cynicaldevil:update-h5e); r=nox
<!-- Please describe your changes on the following line: -->
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` do... | diff --git a/gfx/Cargo.toml b/gfx/Cargo.toml
index d28c7b8f4..0b1735d3a 100644
--- a/gfx/Cargo.toml
+++ b/gfx/Cargo.toml
@@ -59,7 +59,7 @@ servo_allocator = {path = "../allocator"}
servo-fontconfig = "0.2.1"
[target.'cfg(target_os = "android")'.dependencies]
-xml5ever = {version = "0.10"}
+xml5ever = {version = "0.... | 9 | 21 | 27 |
2a8c2174e6ebb1973e046280b149805f649368ee | Cameron McCormack | 2017-10-20T10:26:18 | servo: Merge #18963 - geckolib: Make Servo_DeclarationBlock_RemovePropertyById return whether it did remove a property (from heycam:rm-property-id); r=upsuper
From https://bugzilla.mozilla.org/show_bug.cgi?id=1408311, reviewed there by Xidorn.
Source-Repo: https://github.com/servo/servo
Source-Revision: 7b61e3b6ee62a... | diff --git a/style/gecko/generated/bindings.rs b/style/gecko/generated/bindings.rs
index b2414bf1b..4f835ea19 100644
--- a/style/gecko/generated/bindings.rs
+++ b/style/gecko/generated/bindings.rs
@@ -2733,7 +2733,7 @@ extern "C" {
pub fn Servo_DeclarationBlock_RemovePropertyById(declarations:
... | 1 | 1 | 1 |
d5ac882a55b47aac2c11dff1a09daf1f6d43277c | Xidorn Quan | 2017-10-20T09:18:53 | servo: Merge #18962 - Support matching for ::-moz-tree-* pseudo-elements (from upsuper:tree-pseudos); r=emilio
This is the Servo side change of [bug 1397644](https://bugzilla.mozilla.org/show_bug.cgi?id=1397644).
Source-Repo: https://github.com/servo/servo
Source-Revision: b1e6f05ae455748f6091ddf81c1c0488e09546a1 | diff --git a/script_layout_interface/wrapper_traits.rs b/script_layout_interface/wrapper_traits.rs
index b94ee469e..c33e24797 100644
--- a/script_layout_interface/wrapper_traits.rs
+++ b/script_layout_interface/wrapper_traits.rs
@@ -408,7 +408,8 @@ pub trait ThreadSafeLayoutElement: Clone + Copy + Sized + Debug +
... | 12 | 423 | 256 |
36a983613a3bcd21e2b2b9a3bfdc87c2c792b277 | Cameron McCormack | 2017-10-20T07:56:47 | servo: Merge #18936 - style: Keep track of document state dependencies (from heycam:document-state); r=emilio
Servo half of https://bugzilla.mozilla.org/show_bug.cgi?id=1390694, reviewed there by Emilio.
Source-Repo: https://github.com/servo/servo
Source-Revision: 44eeb1999b2bf1729ff8ae41438c687f6380e33d | diff --git a/style/element_state.rs b/style/element_state.rs
index d6ecc3bf5..adc05293e 100644
--- a/style/element_state.rs
+++ b/style/element_state.rs
@@ -144,6 +144,7 @@ bitflags! {
///
/// NB: Is important for this to remain in sync with Gecko's
/// dom/base/nsIDocument.h.
+ #[derive(MallocSizeOf)... | 4 | 39 | 22 |
cac7cc7c9c19b050ec1b023199f53e5c9d34103d | Simon Sapin | 2017-10-19T14:15:17 | servo: Merge #18944 - Stop relying on linking details of std’s default allocator (from servo:jemallocator2); r=nox
We’ve been bitten before by symbol names changing: https://github.com/servo/heapsize/pull/46, and upstream is planning to stop using jemalloc by default: https://github.com/rust-lang/rust/issues/33082#iss... | diff --git a/allocator/Cargo.toml b/allocator/Cargo.toml
new file mode 100644
index 000000000..fccec48a5
--- /dev/null
+++ b/allocator/Cargo.toml
@@ -0,0 +1,18 @@
+[package]
+name = "servo_allocator"
+version = "0.0.1"
+authors = ["The Servo Project Developers"]
+license = "MPL-2.0"
+publish = false
+
+[lib]
+path = "l... | 15 | 107 | 60 |
f0004724d79e68cdf593ca4751c4e5d3db9d5c45 | Emilio Cobos Álvarez | 2017-10-19T10:43:51 | servo: Merge #18934 - style: Make MatchingContext generic over SelectorImpl (from emilio:matching-context-generic); r=xidorn,heycam
This will help Xidorn implement tree pseudos, and in general makes sense,
allowing to put specific matching data in a selectors implementation.
Source-Repo: https://github.com/servo/serv... | diff --git a/layout_thread/dom_wrapper.rs b/layout_thread/dom_wrapper.rs
index f19e5e13b..899c47b47 100644
--- a/layout_thread/dom_wrapper.rs
+++ b/layout_thread/dom_wrapper.rs
@@ -686,21 +686,23 @@ impl<'le> ::selectors::Element for ServoLayoutElement<'le> {
self.element.namespace()
}
- fn match_pse... | 9 | 121 | 85 |
ba364c2b57bf8fe4ff505917d48d77f1d0b119d7 | Martin Robinson | 2017-10-19T07:36:32 | servo: Merge #18933 - Use WebRender to compute text index on click events (from mrobinson:wr-text-index); r=jdm
This is the second half of switching over to WebRender for hit testing.
Now that WebRender gives us the location of the hit tested point in the
display item, we can use that to calculate text index.
<!-- Pl... | diff --git a/compositing/compositor.rs b/compositing/compositor.rs
index 3be9d0162..43dc5d5a6 100644
--- a/compositing/compositor.rs
+++ b/compositing/compositor.rs
@@ -702,20 +702,20 @@ impl<Window: WindowMethods> IOCompositor<Window> {
None => return,
};
- let point = result.point_in_vi... | 12 | 194 | 370 |
d11eb314f7763f32cba48faeaadc7b9d8815404c | Boris Chiou | 2017-10-19T06:24:38 | servo: Merge #18945 - stylo: Add an FFI to get the ServoStyleContext with an extra animation value (from BorisChiou:stylo/animation/cumulative_hints); r=hiro
This is an inter-dependent patch of Bug 1303235. We add an FFI
to create a temporary ServoStyleContext with the animation value.
We need this because we calculat... | diff --git a/style/gecko/generated/bindings.rs b/style/gecko/generated/bindings.rs
index 404e072b0..3ffab7ccf 100644
--- a/style/gecko/generated/bindings.rs
+++ b/style/gecko/generated/bindings.rs
@@ -3004,6 +3004,19 @@ extern "C" {
CSSPseudoElementType)
... | 2 | 32 | 0 |
6d375ffa4db61109b36cdeaaff9fdbb5a623379f | Glenn Watson | 2017-10-19T04:52:54 | servo: Merge #18926 - Update WR (box shadows, subpixel + alpha text) (from glennw:update-wr-bs); r=jdm
Source-Repo: https://github.com/servo/servo
Source-Revision: 59d727b020f18260e0bacc9aed6ffa5b75b3f0b6 | diff --git a/gfx/display_list/mod.rs b/gfx/display_list/mod.rs
index 9915328ad..b9c43e644 100644
--- a/gfx/display_list/mod.rs
+++ b/gfx/display_list/mod.rs
@@ -1153,8 +1153,6 @@ pub struct DefineClipScrollNodeItem {
/// How a box shadow should be clipped.
#[derive(Clone, Copy, Debug, Deserialize, MallocSizeOf, Parti... | 2 | 0 | 3 |
2b2c7217e3be061ff87615358098b2c4f123890a | Martin Robinson | 2017-10-19T02:34:23 | servo: Merge #18921 - Fix duplicate stacking context creation for anonymous Flows (from mrobinson:incremental-stacking-context-ids); r=emilio
Anonymous nodes were previously creating duplicate stacking contexts,
one for each node in the anonymous node chain. This change eliminates
that for tables.
Additionally the us... | diff --git a/gfx_traits/lib.rs b/gfx_traits/lib.rs
index 9688d90bb..6f5b380dd 100644
--- a/gfx_traits/lib.rs
+++ b/gfx_traits/lib.rs
@@ -42,10 +42,9 @@ impl StackingContextId {
StackingContextId(0)
}
- /// Returns a new sacking context id with the given numeric id.
- #[inline]
- pub fn new(id: ... | 5 | 64 | 36 |
70180791830a4b0d647e4d9777b9fa2966581d36 | Emilio Cobos Álvarez | 2017-10-18T17:44:32 | servo: Merge #18937 - style: Use a proper flattened tree iterator if we're under a shadow tree (from emilio:shadow-proper-flattened-tree); r=heycam
Source-Repo: https://github.com/servo/servo
Source-Revision: eea678c1412e2bb7db7f9a7459d1b68ef57c55f2 | diff --git a/style/gecko/wrapper.rs b/style/gecko/wrapper.rs
index 3ba4b5d47..908af2b6b 100644
--- a/style/gecko/wrapper.rs
+++ b/style/gecko/wrapper.rs
@@ -867,6 +867,7 @@ impl<'le> TElement for GeckoElement<'le> {
// ::before/::after, XBL bindings, or nsIAnonymousContentCreators.
if self.is_in_anony... | 1 | 1 | 0 |
bd5e27bc973a3ab0f8987dc17bb38f06d3a1c99b | Nicholas Nethercote | 2017-10-18T07:17:40 | servo: Merge #18932 - Rename `size_of_is_0!` as `malloc_size_of_is_0!` (from nnethercote:rename-size_of_is_0); r=emilio
The new name makes it clearer that it comes from the `malloc_size_of`
crate.
<!-- Please describe your changes on the following line: -->
---
<!-- Thank you for contributing to Servo! Please replac... | diff --git a/malloc_size_of/lib.rs b/malloc_size_of/lib.rs
index c722c176c..b2aadc872 100644
--- a/malloc_size_of/lib.rs
+++ b/malloc_size_of/lib.rs
@@ -415,7 +415,7 @@ impl<T: MallocSizeOf, U> MallocSizeOf for euclid::TypedSize2D<T, U> {
/// For use on types where size_of() returns 0.
#[macro_export]
-macro_rules!... | 3 | 12 | 12 |
70384e82584fee7245b3ca709c8920e69149b619 | tigercosmos | 2017-10-17T17:44:15 | servo: Merge #18923 - clean up cjk for os (from tigercosmos:master); r=jdm
<!-- Please describe your changes on the following line: -->
r? @jdm
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d... | diff --git a/gfx/platform/freetype/font_list.rs b/gfx/platform/freetype/font_list.rs
index 8f2898ae6..c4f0cfe4f 100644
--- a/gfx/platform/freetype/font_list.rs
+++ b/gfx/platform/freetype/font_list.rs
@@ -132,7 +132,6 @@ pub fn system_default_family(generic_name: &str) -> Option<String> {
}
}
-#[cfg(target_os =... | 1 | 0 | 13 |
415da9daef1f3a01bda227a66c40769007466de0 | Cameron McCormack | 2017-10-17T13:11:16 | servo: Merge #18917 - style: Add some more tests for disallowed rootMargin values (from heycam:observer-test); r=emilio
Source-Repo: https://github.com/servo/servo
Source-Revision: aa3122e7d1beb6c72868baf80d565b0760641b1d | diff --git a/style/values/specified/gecko.rs b/style/values/specified/gecko.rs
index b36cd582a..486a33eaf 100644
--- a/style/values/specified/gecko.rs
+++ b/style/values/specified/gecko.rs
@@ -81,6 +81,11 @@ impl ToNsCssValue for PixelOrPercentage {
}
/// The value of an IntersectionObserver's rootMargin property.
... | 1 | 5 | 0 |
8ed97ae8c68f3a1f50d327a6ca252a01e84cefe7 | Emilio Cobos Álvarez | 2017-10-17T10:18:29 | servo: Merge #18904 - style: Stop threading the ElementData around the invalidator (from emilio:invalidator-less-dependencies); r=heycam,jdm,nox
style: Stop threading the ElementData around the invalidator.
Source-Repo: https://github.com/servo/servo
Source-Revision: c1e0889971582488ed7a4d3a3af21a49bf497abc | diff --git a/layout_thread/dom_wrapper.rs b/layout_thread/dom_wrapper.rs
index 08d628a6d..f19e5e13b 100644
--- a/layout_thread/dom_wrapper.rs
+++ b/layout_thread/dom_wrapper.rs
@@ -68,7 +68,7 @@ use style::attr::AttrValue;
use style::computed_values::display;
use style::context::SharedStyleContext;
use style::data::... | 10 | 217 | 304 |
829e862100e397bee7443f838fe45e89c85decab | tigercosmos | 2017-10-17T08:27:20 | servo: Merge #18919 - fix unused warning (from tigercosmos:remove); r=SimonSapin
<!-- Please describe your changes on the following line: -->
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` ... | diff --git a/script/dom/element.rs b/script/dom/element.rs
index a908561b1..0cfaf0b42 100644
--- a/script/dom/element.rs
+++ b/script/dom/element.rs
@@ -89,7 +89,7 @@ use script_layout_interface::message::ReflowGoal;
use script_thread::ScriptThread;
use selectors::Element as SelectorsElement;
use selectors::attr::{A... | 1 | 1 | 1 |
c6f1d15fef4e77c93d1e9e470675e3b3f6c5568c | Cameron McCormack | 2017-10-17T06:11:39 | servo: Merge #18915 - style: Add FFI function for parsing IntersectionObserver rootMargin values (from heycam:observer); r=upsuper
Servo-side part of https://bugzilla.mozilla.org/show_bug.cgi?id=1408305, reviewed there by Xidorn.
Source-Repo: https://github.com/servo/servo
Source-Revision: ac74cd57a257fc95e0513524e19... | diff --git a/style/gecko_bindings/sugar/ns_css_value.rs b/style/gecko_bindings/sugar/ns_css_value.rs
index 9c57b788e..8c1d83c8f 100644
--- a/style/gecko_bindings/sugar/ns_css_value.rs
+++ b/style/gecko_bindings/sugar/ns_css_value.rs
@@ -75,10 +75,10 @@ impl nsCSSValue {
pub unsafe fn set_lop(&mut self, lop: Length... | 2 | 81 | 4 |
a3c062d4a73eb6ad4f8f6ed4322005b53dcf717a | Glenn Watson | 2017-10-17T04:42:12 | servo: Merge #18914 - Update WR (hit test relative point, query feature) (from glennw:update-wr-hit-test); r=KiChjang
Source-Repo: https://github.com/servo/servo
Source-Revision: 1715329eb1037cb4f0c723d3db2e22d722c7290d | diff --git a/compositing/compositor.rs b/compositing/compositor.rs
index 85bab91a8..a652346c7 100644
--- a/compositing/compositor.rs
+++ b/compositing/compositor.rs
@@ -1502,9 +1502,9 @@ impl<Window: WindowMethods> IOCompositor<Window> {
pub fn toggle_webrender_debug(&mut self, option: WebRenderDebugOption) {
... | 2 | 4 | 4 |
b17035d5912326a81e08c7e055009d14cba1fc36 | Savid Sharan | 2017-10-17T02:50:04 | servo: Merge #18906 - Removed pdqsort dependency under the style crate (from savanu:pdqsortchange); r=SimonSapin
<!-- Please describe your changes on the following line: -->
Removed the pdqsort dependency from the style crate.
Removed the sort_by_key method and used the stdlib version directly.
---
<!-- Thank you for... | diff --git a/style/Cargo.toml b/style/Cargo.toml
index 1e61fbc22..140c1b7d0 100644
--- a/style/Cargo.toml
+++ b/style/Cargo.toml
@@ -60,7 +60,6 @@ num-traits = "0.1.32"
ordered-float = "0.4"
owning_ref = "0.3.3"
parking_lot = "0.4"
-pdqsort = "0.1.0"
precomputed-hash = "0.1.1"
rayon = "0.8.2"
selectors = { path =... | 3 | 1 | 11 |
2169ad4ea561d7b36b28a79f429bbe4f51f19ac8 | Glenn Watson | 2017-10-16T17:54:02 | servo: Merge #18890 - Update WR (details below): (from glennw:update-wr-clip-text-aa); r=jdm
* Add support for clip masks on text runs.
* Fix atomic ordering of items with multiple shadows.
* Update to bincode + ipc-channel with optimizations.
* Fix some plane splitting precision errors.
* Improve the anti-aliasing qu... | diff --git a/bluetooth/Cargo.toml b/bluetooth/Cargo.toml
index 45a1d381d..5683c7b81 100644
--- a/bluetooth/Cargo.toml
+++ b/bluetooth/Cargo.toml
@@ -13,7 +13,7 @@ path = "lib.rs"
bitflags = "0.7"
bluetooth_traits = {path = "../bluetooth_traits"}
device = {git = "https://github.com/servo/devices", features = ["blueto... | 27 | 34 | 34 |
c8e7686be1f24007c3fe569ccfac5a7eba84e215 | Emilio Cobos Álvarez | 2017-10-16T12:32:40 | servo: Merge #18894 - style: Remove the ElementExt trait (from emilio:bye-elementext); r=nox
It is likely it's the most useless trait ever existing.
Source-Repo: https://github.com/servo/servo
Source-Revision: 7d05c76d1828bc80e578c9b77f0c57b0e1afafc2 | diff --git a/style/dom.rs b/style/dom.rs
index ed8b52f02..1733b5801 100644
--- a/style/dom.rs
+++ b/style/dom.rs
@@ -20,8 +20,8 @@ use properties::{AnimationRules, ComputedValues, PropertyDeclarationBlock};
#[cfg(feature = "gecko")] use properties::LonghandId;
#[cfg(feature = "gecko")] use properties::animated_proper... | 4 | 25 | 31 |
b79c0eacf40f9856356df5f674b0c5d0541edd90 | Cameron McCormack | 2017-10-16T09:49:33 | servo: Merge #18891 - style: add FFI functions for color parsing (from heycam:color-refactor); r=upsuper
Servo side of https://bugzilla.mozilla.org/show_bug.cgi?id=1408312, reviewed there by Xidorn.
Source-Repo: https://github.com/servo/servo
Source-Revision: 1e351ef8c478de507c6ee7b65eeff7524d73a4c9 | diff --git a/style/values/specified/color.rs b/style/values/specified/color.rs
index bee0daecf..aae267480 100644
--- a/style/values/specified/color.rs
+++ b/style/values/specified/color.rs
@@ -67,42 +67,7 @@ impl From<RGBA> for Color {
impl Parse for Color {
fn parse<'i, 't>(_: &ParserContext, input: &mut Parse... | 1 | 90 | 67 |
cd9ed57c3424053ae46ae0de5ab5ac6fa64a00a4 | Emilio Cobos Álvarez | 2017-10-16T08:41:54 | servo: Merge #18884 - style: Use left-to-right indices in the invalidator (from emilio:invalidator-ltr); r=heycam
This will make easier to create external invalidations that don't point to a combinator,
and also makes reasoning about the invalidator a bit easier.
Source-Repo: https://github.com/servo/servo
Source-Rev... | diff --git a/selectors/matching.rs b/selectors/matching.rs
index 711bec885..596fa8afe 100644
--- a/selectors/matching.rs
+++ b/selectors/matching.rs
@@ -299,11 +299,10 @@ where
/// Whether a compound selector matched, and whether it was the rightmost
/// selector inside the complex selector.
pub enum CompoundSelecto... | 5 | 46 | 39 |
b0b1bf114ab415dc0cf6e88e6daa170208523939 | Emilio Cobos Álvarez | 2017-10-16T07:36:22 | servo: Merge #18879 - style: Not all computed value flags are really inherited (from emilio:computed-value-flags-inherited); r=heycam
This fixes the fishiness I noticed in:
https://bugzilla.mozilla.org/show_bug.cgi?id=1407832
Source-Repo: https://github.com/servo/servo
Source-Revision: 9b82d08dc5ca002b34662f805833... | diff --git a/style/matching.rs b/style/matching.rs
index 895fbe743..3b3ee3e01 100644
--- a/style/matching.rs
+++ b/style/matching.rs
@@ -360,8 +360,8 @@ trait PrivateMatchMethods: TElement {
debug!(" > style difference: {:?}", difference);
// We need to cascade the children in order to ensure the co... | 3 | 11 | 3 |
1cc10ebb2e6ca88f619622402008b51736f65154 | tigercosmos | 2017-10-16T06:27:43 | servo: Merge #18888 - fix #18776: use XML fragment serialization for innerHTML in XML documents (from tigercosmos:xml); r=jdm
<!-- Please describe your changes on the following line: -->
I am not sure whether my solution is in the right way.
@jdm Can you give some advises?
---
<!-- Thank you for contributing to Serv... | diff --git a/script/dom/element.rs b/script/dom/element.rs
index e877a8b07..485ad9c91 100644
--- a/script/dom/element.rs
+++ b/script/dom/element.rs
@@ -120,6 +120,11 @@ use style::values::{CSSFloat, Either};
use style::values::{specified, computed};
use stylesheet_loader::StylesheetOwner;
use task::TaskOnce;
+use x... | 1 | 28 | 3 |
4a9c0c3d16d26194334fa3ee49dacbd141466e98 | Anthony Ramine | 2017-10-15T09:53:29 | servo: Merge #18886 - Change AttrValue::Url to AttrValue::ResolvedUrl (from servo:urls); r=SimonSapin
Things make more sense like this.
Source-Repo: https://github.com/servo/servo
Source-Revision: 7e8def9c080faf5a1b8e40fe90747be5439fc3f1 | diff --git a/script/dom/element.rs b/script/dom/element.rs
index 91179ee1b..e877a8b07 100644
--- a/script/dom/element.rs
+++ b/script/dom/element.rs
@@ -1306,26 +1306,13 @@ impl Element {
Some(attr) => attr,
None => return DOMString::new(),
};
- let value = attr.value();
- ... | 9 | 48 | 72 |
dadc453ca67a3c25b1d778659791ef33c3628354 | Emilio Cobos Álvarez | 2017-10-15T07:21:47 | servo: Merge #18876 - style: Do not expose LocalMatchingContext (from emilio:die-localmatchingcontext-die); r=SimonSapin
This type is a lot of complexity related to a very specific thing such as the
hover and active quirk.
Instead of that, move `nesting_level` to `MatchingContext`, and simplify all
this computing whe... | diff --git a/layout_thread/dom_wrapper.rs b/layout_thread/dom_wrapper.rs
index 2a95324cc..2863d840c 100644
--- a/layout_thread/dom_wrapper.rs
+++ b/layout_thread/dom_wrapper.rs
@@ -51,7 +51,7 @@ use script_layout_interface::{OpaqueStyleAndLayoutData, StyleData};
use script_layout_interface::wrapper_traits::{DangerousT... | 8 | 256 | 255 |
df43fb65d71ff27e296d370190ba84fbf74f1800 | Emilio Cobos Álvarez | 2017-10-14T14:49:45 | servo: Merge #18880 - style: Fixup the hack added in #18867 (from emilio:fixup-parse-hack); r=emilio
The declaration can indeed have the same id if it contains variables, or is a
CSS keyword value.
This was making a WPT test fail, so this is tested, though Servo's WPT import
didn't catch this for some reason.
Source... | diff --git a/style/properties/declaration_block.rs b/style/properties/declaration_block.rs
index e951d2589..06e75a0a0 100644
--- a/style/properties/declaration_block.rs
+++ b/style/properties/declaration_block.rs
@@ -509,13 +509,10 @@ impl PropertyDeclarationBlock {
if let PropertyDeclarati... | 1 | 4 | 7 |
322302cc84195c26b208b258d0b4c73e0530de3a | Emilio Cobos Álvarez | 2017-10-14T13:13:59 | servo: Merge #18877 - stylo: Dumb down the return value of SelectorList_Closest (from emilio:closest-why); r=nox
stylo: Dumb down the return value of SelectorList_Closest.
So it builds with rust 1.21.
See: https://bugzilla.mozilla.org/show_bug.cgi?id=1408622
Source-Repo: https://github.com/servo/servo
Source-Revisio... | diff --git a/style/gecko/generated/bindings.rs b/style/gecko/generated/bindings.rs
index b880c0e1a..404e072b0 100644
--- a/style/gecko/generated/bindings.rs
+++ b/style/gecko/generated/bindings.rs
@@ -1921,6 +1921,11 @@ extern "C" {
pub fn Gecko_AddBufferToCrashReport(addr: *const ::std::os::raw::c_void,
... | 1 | 10 | 0 |
1382da5dfc704d703573e898e3fd6d34b9c5acf9 | Emilio Cobos Álvarez | 2017-10-14T10:27:51 | servo: Merge #18867 - style: Dishonor display: -moz-box if -webkit-box was specified before (from emilio:parse-hack); r=heycam
This is a compatibility hack that Gecko supports that is apparently important for android.
I want to remove it, but let's see...
See https://bugzilla.mozilla.org/show_bug.cgi?id=1407701 for ... | diff --git a/script/dom/cssstyledeclaration.rs b/script/dom/cssstyledeclaration.rs
index f2cb3b4e5..71220f6e8 100644
--- a/script/dom/cssstyledeclaration.rs
+++ b/script/dom/cssstyledeclaration.rs
@@ -18,7 +18,7 @@ use servo_arc::Arc;
use servo_url::ServoUrl;
use std::ascii::AsciiExt;
use style::attr::AttrValue;
-us... | 4 | 117 | 53 |
5bb29f19b5955553e9da1a3a02b7c7d588c0fe62 | Simon Sapin | 2017-10-14T02:43:09 | servo: Merge #18870 - Use pointer casts instead of tramsutes to raw::TraitObject (from servo:cast); r=KiChjang
Casting `*const T` to `*const U` with `U: Sized` is allowed even if `T: ?Sized`. This safely extracts the data pointer out of a trait object, without relying on the memory representation of trait objects.
So... | diff --git a/layout/block.rs b/layout/block.rs
index c7f675293..bffcbef0e 100644
--- a/layout/block.rs
+++ b/layout/block.rs
@@ -492,8 +492,12 @@ pub enum FormattingContextType {
Other,
}
+#[allow(unsafe_code)]
+unsafe impl ::flow::HasBaseFlow for BlockFlow {}
+
// A block formatting context.
#[derive(Seriali... | 15 | 74 | 28 |
9c714dc75d95b067fad379c067b406c676cbff77 | Alan Jeffrey | 2017-10-13T20:39:20 | servo: Merge #18810 - Document the can-block-on relationship for servo (from asajeffrey:constellation-document-blocking); r=cbrewster
<!-- Please describe your changes on the following line: -->
This PR adds some documentation comments describing the can-block-on relation that is used to ensure deadlock-freedom.
---... | diff --git a/constellation/constellation.rs b/constellation/constellation.rs
index 51f7b6fbe..3ad7a2e7e 100644
--- a/constellation/constellation.rs
+++ b/constellation/constellation.rs
@@ -64,6 +64,34 @@
//!
//! Since there is only one constellation, and its responsibilities include crash reporting,
//! it is very i... | 1 | 28 | 0 |
2ff5240f21b270ac93a9446575da9624ec134774 | Emilio Cobos Álvarez | 2017-10-13T19:11:02 | servo: Merge #18864 - style: Reformat a few signatures to follow a consistent style (from emilio:reformat); r=jdm
Source-Repo: https://github.com/servo/servo
Source-Revision: db29af160ca43d1b5ed4e6f6259721c176ef2938 | diff --git a/style/gecko/generated/bindings.rs b/style/gecko/generated/bindings.rs
index ba6bdaedc..b880c0e1a 100644
--- a/style/gecko/generated/bindings.rs
+++ b/style/gecko/generated/bindings.rs
@@ -2926,10 +2926,6 @@ extern "C" {
set: RawServoStyleSetBorrowed)
-> ServoStyleContex... | 3 | 31 | 25 |
aad4759ebbe040a1deb7bd46911e45eb0c063133 | Emilio Cobos Álvarez | 2017-10-13T15:48:57 | servo: Merge #18863 - style: Share code between Gecko and Servo for DOM APIs (from emilio:dom-api-dont-repeat); r=jdm
Source-Repo: https://github.com/servo/servo
Source-Revision: ba77ffed173b3a0ed934edead419ab3919cf5147 | diff --git a/script/dom/element.rs b/script/dom/element.rs
index a87e561f9..ee5682b56 100644
--- a/script/dom/element.rs
+++ b/script/dom/element.rs
@@ -107,6 +107,7 @@ use style::CaseSensitivityExt;
use style::applicable_declarations::ApplicableDeclarationBlock;
use style::attr::{AttrValue, LengthOrPercentageOrAuto}... | 3 | 83 | 32 |
1d3601f99cdc2bf8cc1af5849dc76aa32d3581f4 | Emilio Cobos Álvarez | 2017-10-13T11:14:42 | servo: Merge #18847 - style: Split the invalidation processing from the invalidator step (from emilio:invalidation-generic); r=heycam
This is the first step in reusing the invalidation machinery for other stuff,
potentially including QuerySelector / QuerySelectorAll.
Source-Repo: https://github.com/servo/servo
Source... | diff --git a/style/data.rs b/style/data.rs
index bc3f0b174..7e50a67db 100644
--- a/style/data.rs
+++ b/style/data.rs
@@ -244,6 +244,7 @@ impl ElementData {
return InvalidationResult::empty();
}
+ use invalidation::element::collector::StateAndAttrInvalidationProcessor;
use invalid... | 4 | 638 | 442 |
4397052494e512272ba04c4c36270bcfb2f57c81 | Xidorn Quan | 2017-10-13T07:11:55 | servo: Merge #18861 - Some fixes to diagnostic hashmap (from upsuper:diagnose-fix); r=Manishearth
Source-Repo: https://github.com/servo/servo
Source-Revision: ec00c660f0a1892033ca89a31d393427d3c6a2d3 | diff --git a/hashglobe/src/diagnostic.rs b/hashglobe/src/diagnostic.rs
index 0c4df266b..f761e31a6 100644
--- a/hashglobe/src/diagnostic.rs
+++ b/hashglobe/src/diagnostic.rs
@@ -1,6 +1,7 @@
use hash_map::HashMap;
use std::borrow::Borrow;
use std::hash::{BuildHasher, Hash};
+use std::ptr;
use FailedAllocationError;... | 1 | 20 | 6 |
b40095ddd3c60be2f9ef766164cce2d480f057ba | Xidorn Quan | 2017-10-13T01:30:28 | servo: Merge #18858 - Rewrite cycle removal algorithm of custom properties and integrate it with substitution (from upsuper:cycle-removal); r=SimonSapin
This fixes [bug 1403839](https://bugzilla.mozilla.org/show_bug.cgi?id=1403839).
Source-Repo: https://github.com/servo/servo
Source-Revision: 1099bc8b92f043ba39e6a4b3... | diff --git a/style/custom_properties.rs b/style/custom_properties.rs
index 07392b768..32c113878 100644
--- a/style/custom_properties.rs
+++ b/style/custom_properties.rs
@@ -16,6 +16,7 @@ use servo_arc::Arc;
use smallvec::SmallVec;
use std::ascii::AsciiExt;
use std::borrow::{Borrow, Cow};
+use std::cmp;
use std::fmt... | 1 | 221 | 150 |
75835dee3c60c7fd2abc6967765ffa531e89ae68 | Alan Jeffrey | 2017-10-12T18:07:19 | servo: Merge #18853 - Random pipeline closure is less likely to kill pending pipelines (from asajeffrey:constellation-chaos-monkey-dont-kill-pending-pipelines); r=jdm
<!-- Please describe your changes on the following line: -->
Make it less likely for pending pipelines to be randomly killed. Pending pipelines send mo... | diff --git a/constellation/constellation.rs b/constellation/constellation.rs
index 4141e04d8..76fb0e947 100644
--- a/constellation/constellation.rs
+++ b/constellation/constellation.rs
@@ -2902,12 +2902,21 @@ impl<Message, LTF, STF> Constellation<Message, LTF, STF>
// In order to get repeatability, we sort the... | 1 | 10 | 1 |
8fd20975391515dc4502a9f653b7d15f0e28dac8 | Emilio Cobos Álvarez | 2017-10-12T14:06:22 | servo: Merge #18850 - Update bindgen (from emilio:bindgenup); r=jdm
This includes a clang-sys upgrade that removes crashes in linux32, and nothing
else.
Source-Repo: https://github.com/servo/servo
Source-Revision: bc18ef78617553fa4b11927ca0c7738f5d14556b | diff --git a/style/Cargo.toml b/style/Cargo.toml
index 23130d091..1e61fbc22 100644
--- a/style/Cargo.toml
+++ b/style/Cargo.toml
@@ -83,7 +83,7 @@ kernel32-sys = "0.2"
[build-dependencies]
lazy_static = "0.2"
log = "0.3"
-bindgen = { version = "0.29", optional = true }
+bindgen = { version = "0.29.1", optional = tru... | 1 | 1 | 1 |
e1e9d557a044f7b52c162d18a0347cf01db75607 | Emilio Cobos Álvarez | 2017-10-12T12:05:42 | servo: Merge #18848 - stylo: Remove :-moz-system-metric pseudo-class (from emilio:unship-but-a-bit-more-slowly); r=xidorn
Bug: 1405311
Reviewed-by: xidorn
MozReview-Commit-ID: CIF64dG1F2k
Source-Repo: https://github.com/servo/servo
Source-Revision: 55bf65021d03a6ec6811077b606612d7c9f3fd62 | diff --git a/style/gecko/non_ts_pseudo_class_list.rs b/style/gecko/non_ts_pseudo_class_list.rs
index 0399c8d4b..6a16d4dc3 100644
--- a/style/gecko/non_ts_pseudo_class_list.rs
+++ b/style/gecko/non_ts_pseudo_class_list.rs
@@ -116,8 +116,6 @@ macro_rules! apply_non_ts_list {
("-moz-window-inactive", MozW... | 2 | 0 | 3 |
fc5d57756cf4156c59df513a49171a4515366ce8 | Xidorn Quan | 2017-10-12T08:12:26 | servo: Merge #18843 - Remove text-shadow handling from HasAuthorSpecifiedRules (from upsuper:author-text-shadow); r=heycam
This is the Servo side change of [bug 1363088](https://bugzilla.mozilla.org/show_bug.cgi?id=1363088).
Source-Repo: https://github.com/servo/servo
Source-Revision: 5682eeff486ae4c6963cb04af1a44343... | diff --git a/style/gecko/generated/structs.rs b/style/gecko/generated/structs.rs
index 4d0c256f6..aadb27014 100644
--- a/style/gecko/generated/structs.rs
+++ b/style/gecko/generated/structs.rs
@@ -959,7 +959,6 @@ pub mod root {
pub const NS_AUTHOR_SPECIFIED_BACKGROUND: ::std::os::raw::c_uint = 1;
pub const NS... | 2 | 4 | 30 |
03f7fd7f34f9803432cd190912c2d3e271dd8eda | J. Ryan Stinnett | 2017-10-12T06:04:57 | servo: Merge #18844 - Limit visited cascade for reparenting (from jryans:stylo-visited-reparent-cascade); r=emilio
The specialized cascade flow in `stylist::compute_style_with_inputs` (used with
reparenting) currently computes all properties for visited styles, but we only
need visited-dependent properties.
This adds... | diff --git a/style/stylist.rs b/style/stylist.rs
index eb4976d24..710f0cb56 100644
--- a/style/stylist.rs
+++ b/style/stylist.rs
@@ -25,6 +25,7 @@ use properties::{AnimationRules, PropertyDeclarationBlock};
#[cfg(feature = "servo")]
use properties::INHERIT_ALL;
use properties::IS_LINK;
+use properties::VISITED_DEPEN... | 1 | 2 | 1 |
a1a6faa8b533eb5a738ed60bdc1822feb37f79da | Cameron McCormack | 2017-10-12T03:51:51 | servo: Merge #18803 - style: more custom properties optimizations (from heycam:more-custom-prop-opts); r=emilio
These help slightly with https://bugzilla.mozilla.org/show_bug.cgi?id=1405411.
Source-Repo: https://github.com/servo/servo
Source-Revision: 99e15f0f03fceb97f2dd54e049fc133a7001c157 | diff --git a/style/custom_properties.rs b/style/custom_properties.rs
index 86dd60631..07392b768 100644
--- a/style/custom_properties.rs
+++ b/style/custom_properties.rs
@@ -507,11 +507,15 @@ impl<'a> CustomPropertiesBuilder<'a> {
return;
}
+ if !self.value_may_affect_style(name, &specifie... | 1 | 47 | 3 |
d8096064766875f91d614b674160d7a1824158ea | Cameron McCormack | 2017-10-12T02:45:51 | servo: Merge #18842 - style: Skip custom properties comparison if other inherited properties changed (from heycam:skip-var-check); r=emilio
Servo half of https://bugzilla.mozilla.org/show_bug.cgi?id=1407246, reviewed there by Emilio.
Source-Repo: https://github.com/servo/servo
Source-Revision: 9f8514d2b94713b6dc3bb91... | diff --git a/style/gecko/restyle_damage.rs b/style/gecko/restyle_damage.rs
index f325e7916..f8a43e8b7 100644
--- a/style/gecko/restyle_damage.rs
+++ b/style/gecko/restyle_damage.rs
@@ -57,6 +57,16 @@ impl GeckoRestyleDamage {
&mut reset_only,
)
};
+ if reset_only &&
+ ... | 1 | 10 | 0 |
dda9d3ab33badfb8c1f54d6fcc9043e284dfe059 | J. Ryan Stinnett | 2017-10-11T23:50:23 | servo: Merge #18841 - Clear visited rules for text inheritance (from jryans:stylo-visited-first-line); r=emilio
https://bugzilla.mozilla.org/show_bug.cgi?id=1406254
Source-Repo: https://github.com/servo/servo
Source-Revision: dbf0991f8cab54516c5b0211e1818a16cfbf9e19 | diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs
index e1625ff74..7831f76aa 100644
--- a/style/properties/gecko.mako.rs
+++ b/style/properties/gecko.mako.rs
@@ -251,7 +251,7 @@ impl ops::DerefMut for ComputedValues {
impl ComputedValuesInner {
/// Clone the visited style. Used for i... | 2 | 15 | 3 |
ecbe834f1e909e944f05110de4e972007b79ab82 | Bobby Holley | 2017-10-11T18:53:01 | servo: Merge #18829 - Verify in DiagnosticHashMap::drop (from bholley:verify_in_drop); r=Manishearth
This will let us reason better about the drop_in_place crashes.
Source-Repo: https://github.com/servo/servo
Source-Revision: 882b22b6068826f49e8279910784db8b3ebb61f0 | diff --git a/hashglobe/src/diagnostic.rs b/hashglobe/src/diagnostic.rs
index 05a044b02..0c4df266b 100644
--- a/hashglobe/src/diagnostic.rs
+++ b/hashglobe/src/diagnostic.rs
@@ -209,7 +209,9 @@ impl<K: Hash + Eq, V, S: BuildHasher> Drop for DiagnosticHashMap<K, V, S>
S: BuildHasher
{
fn drop(&mut self) ... | 1 | 2 | 0 |
e1a4555dfb767514389cff321a744637756d0268 | Emilio Cobos Álvarez | 2017-10-11T15:59:05 | servo: Merge #18826 - style: Fix invalidation collection for XBL when quirks modes don't match (from emilio:invalidation-xbl-stuff); r=heycam
Source-Repo: https://github.com/servo/servo
Source-Revision: 105c5d2a0692c6e09320c5d967b43f879c3cd00d | diff --git a/style/invalidation/element/invalidator.rs b/style/invalidation/element/invalidator.rs
index 80d5f7043..540408db2 100644
--- a/style/invalidation/element/invalidator.rs
+++ b/style/invalidation/element/invalidator.rs
@@ -6,7 +6,7 @@
//! element styles need to be invalidated.
use Atom;
-use context::{Sha... | 1 | 12 | 8 |
fc8bf052b4c7ae92395cb4278ac46aa3d73c9ee6 | Anthony Ramine | 2017-10-11T13:45:44 | servo: Merge #18825 - Fix a bunch of URL-reflecting IDL attributes (from servo:urls); r=emilio
Source-Repo: https://github.com/servo/servo
Source-Revision: 528d0fb40939311625dd977b52e879758d6f6aab | diff --git a/script/dom/element.rs b/script/dom/element.rs
index 438d01f4d..c16eb7f06 100644
--- a/script/dom/element.rs
+++ b/script/dom/element.rs
@@ -1302,21 +1302,30 @@ impl Element {
pub fn get_url_attribute(&self, local_name: &LocalName) -> DOMString {
assert!(*local_name == local_name.to_ascii_lo... | 12 | 90 | 73 |
b130cb9b0a0bee31d2e4b79ffe6286dbaf742e75 | Cameron McCormack | 2017-10-11T11:55:03 | servo: Merge #18827 - style: Support more selectors in the style sheet invalidator (from heycam:invalidate-less); r=emilio
In addition to being able to invalidate just based on local name, this
also adds support for invalidating based on selectors with no ancestor
combinator in them (resulting in a RESTYLE_SELF for th... | diff --git a/style/invalidation/stylesheets.rs b/style/invalidation/stylesheets.rs
index 7d9af116a..c65dfc056 100644
--- a/style/invalidation/stylesheets.rs
+++ b/style/invalidation/stylesheets.rs
@@ -8,45 +8,65 @@
#![deny(unsafe_code)]
use Atom;
+use LocalName as SelectorLocalName;
use dom::{TElement, TNode};
us... | 1 | 114 | 54 |
d86853c99147aac9b34dedbffc14dac377ba6adc | Cameron McCormack | 2017-10-11T01:24:48 | servo: Merge #18793 - servo_arc: Try pointer equality test first when comparing two Arcs (from heycam:ptr-eq); r=emilio
This doesn't actually help https://bugzilla.mozilla.org/show_bug.cgi?id=1405411 but seems like something we should do.
Source-Repo: https://github.com/servo/servo
Source-Revision: b1c7a2fa6dd94bde09... | diff --git a/servo_arc/lib.rs b/servo_arc/lib.rs
index 49a04dea1..7d17c26cd 100644
--- a/servo_arc/lib.rs
+++ b/servo_arc/lib.rs
@@ -389,11 +389,11 @@ impl<T: ?Sized> Drop for Arc<T> {
impl<T: ?Sized + PartialEq> PartialEq for Arc<T> {
fn eq(&self, other: &Arc<T>) -> bool {
- *(*self) == *(*other)
+ ... | 1 | 2 | 2 |
55bf6e75e19e78ccfffc3d28c475ceaeca37271b | Xidorn Quan | 2017-10-10T23:31:18 | servo: Merge #18823 - Support pseudo-element properly in HasAuthorSpecifiedRules (from upsuper:author-pseudo); r=emilio
This is the Servo side change of [bug 1401825](https://bugzilla.mozilla.org/show_bug.cgi?id=1401825).
Source-Repo: https://github.com/servo/servo
Source-Revision: 3c6e7b56c3469d29df8f6ff3332f50e4476... | diff --git a/style/gecko/generated/bindings.rs b/style/gecko/generated/bindings.rs
index 2dd250613..ba6bdaedc 100644
--- a/style/gecko/generated/bindings.rs
+++ b/style/gecko/generated/bindings.rs
@@ -2944,7 +2944,9 @@ extern "C" {
primary_style: ServoStyleContextBorrowed);
}
extern... | 2 | 19 | 8 |
cd4d92304b10ff651f4c81fc9ac44f24421fc697 | Bobby Holley | 2017-10-10T21:17:20 | servo: Merge #18822 - More hashmap diagnostics (from bholley:more_hashmap_diagnostics); r=Manishearth
https://bugzilla.mozilla.org/show_bug.cgi?id=1407080
Source-Repo: https://github.com/servo/servo
Source-Revision: be5839fae6444c5134faa67e43c44d4d277a778a | diff --git a/hashglobe/src/diagnostic.rs b/hashglobe/src/diagnostic.rs
index 0a5a6c4d0..05a044b02 100644
--- a/hashglobe/src/diagnostic.rs
+++ b/hashglobe/src/diagnostic.rs
@@ -1,7 +1,6 @@
use hash_map::HashMap;
use std::borrow::Borrow;
use std::hash::{BuildHasher, Hash};
-use table::SafeHash;
use FailedAllocatio... | 3 | 65 | 27 |
db56f0495cb7e0416ed389b0adfe1b6e3fd6a135 | Alan Jeffrey | 2017-10-10T20:10:01 | servo: Merge #18820 - Updated swapper to version 0.1 (from asajeffrey:update-swapper); r=wafflespeanut
<!-- Please describe your changes on the following line: -->
Update swapper to v0.1, which removes the skeptic dependency.
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the s... | diff --git a/script/Cargo.toml b/script/Cargo.toml
index be1af3a2a..6ae95d2fd 100644
--- a/script/Cargo.toml
+++ b/script/Cargo.toml
@@ -84,7 +84,7 @@ servo_url = {path = "../url"}
smallvec = "0.4"
style = {path = "../style"}
style_traits = {path = "../style_traits"}
-swapper = "0.0.4"
+swapper = "0.1"
time = "0.1.... | 1 | 1 | 1 |
b7a772869a935c47b8e4f4dcd383a47a92000f5c | Emilio Cobos Álvarez | 2017-10-10T19:13:29 | servo: Merge #18807 - style: Fix ex computation with more than one operand (from emilio:ex-calc); r=jdm
Source-Repo: https://github.com/servo/servo
Source-Revision: b1926b465671ce56474fc24827eb9562ff7b575b | diff --git a/style/values/specified/calc.rs b/style/values/specified/calc.rs
index dd0a6f8c6..532b41ea0 100644
--- a/style/values/specified/calc.rs
+++ b/style/values/specified/calc.rs
@@ -373,7 +373,7 @@ impl CalcNode {
ret.em = Some(ret.em.unwrap_or(0.) + em * factor);
... | 1 | 1 | 1 |
e3832e0e223d749b4bec00895e7e983aac78a276 | Hiroyuki Ikezoe | 2017-10-10T09:34:47 | servo: Merge #18738 - Use atom for animation name property (from hiikezoe:use-atom-for-animation-name-property); r=xidorn
<!-- Please describe your changes on the following line: -->
https://bugzilla.mozilla.org/show_bug.cgi?id=1329169
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` w... | diff --git a/style/gecko/generated/bindings.rs b/style/gecko/generated/bindings.rs
index 57f08684e..2dd250613 100644
--- a/style/gecko/generated/bindings.rs
+++ b/style/gecko/generated/bindings.rs
@@ -235,6 +235,7 @@ use gecko_bindings::structs::UpdateAnimationsTasks;
use gecko_bindings::structs::ParsingMode;
use gec... | 4 | 98 | 71 |
2032f6be09eed132200193e436b8ff38613b68a0 | Emilio Cobos Álvarez | 2017-10-10T07:47:29 | servo: Merge #18798 - style: Optimize custom properties cycle removal (from emilio:faster-custom-props); r=SimonSapin
After #18791, this is the major custom_properties perf bottleneck in the
testcase from bug 1405411.
I'm looking into how to efficiently merge this into `substitute_all`, but
meanwhile this is worth la... | diff --git a/style/custom_properties.rs b/style/custom_properties.rs
index 5507739a7..ca9e41949 100644
--- a/style/custom_properties.rs
+++ b/style/custom_properties.rs
@@ -13,6 +13,7 @@ use properties::{CSSWideKeyword, DeclaredValue};
use selector_map::{PrecomputedHashSet, PrecomputedHashMap, PrecomputedDiagnosticHas... | 1 | 25 | 17 |
f3e39e2becb27cff2b715193d4f804435501d639 | Xidorn Quan | 2017-10-10T04:04:15 | servo: Merge #18790 - Support :scope pseudo-class (from upsuper:scope); r=emilio
This fixes [bug 1406817](https://bugzilla.mozilla.org/show_bug.cgi?id=1406817).
Source-Repo: https://github.com/servo/servo
Source-Revision: bbb2a3cde9f4c7fc9debd5784fce2b07966101ff | diff --git a/script/dom/element.rs b/script/dom/element.rs
index 6c69b09d1..438d01f4d 100644
--- a/script/dom/element.rs
+++ b/script/dom/element.rs
@@ -87,6 +87,7 @@ use net_traits::request::CorsSettings;
use ref_filter_map::ref_filter_map;
use script_layout_interface::message::ReflowGoal;
use script_thread::Script... | 5 | 32 | 3 |
a7c8483b1deb2e93c34cc2e390f93a9f0f13871e | tigercosmos | 2017-10-09T19:05:14 | servo: Merge #18792 - fix #18472:outdated png crate: various panics (from tigercosmos:img); r=jdm
<!-- Please describe your changes on the following line: -->
fix #18472:outdated png crate: various panics
---
- [X] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [X] ... | diff --git a/compositing/Cargo.toml b/compositing/Cargo.toml
index 890f948a1..40e5b724f 100644
--- a/compositing/Cargo.toml
+++ b/compositing/Cargo.toml
@@ -13,7 +13,7 @@ path = "lib.rs"
euclid = "0.15"
gfx_traits = {path = "../gfx_traits"}
gleam = "0.4"
-image = "0.14"
+image = "0.16"
ipc-channel = "0.8"
log = "0... | 4 | 4 | 4 |
3891f0ad6df1fff5ffbb2000013b6254ba62c015 | Jyotsna Prakash | 2017-10-09T16:12:53 | servo: Merge #18747 - Serializing childrenonly (from jdm:serializing-childrenonly); r=jdm
Rebased from #17896.
---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #14975 (github issue number if applicable).
- [x] There are tests for these ... | diff --git a/gfx/Cargo.toml b/gfx/Cargo.toml
index 7282dc797..3d7aea1b5 100644
--- a/gfx/Cargo.toml
+++ b/gfx/Cargo.toml
@@ -55,7 +55,7 @@ freetype = "0.3"
servo-fontconfig = "0.2.1"
[target.'cfg(target_os = "android")'.dependencies]
-xml5ever = {version = "0.9"}
+xml5ever = {version = "0.10"}
[target.'cfg(any(t... | 8 | 13 | 10 |
09b64ec545889b009f7994af9ced91c2050385ef | Emilio Cobos Álvarez | 2017-10-09T14:29:18 | servo: Merge #18791 - style: Optimize custom property cascading (from emilio:faster-custom-props); r=heycam
This should help a bunch with https://bugzilla.mozilla.org/show_bug.cgi?id=1405411
Source-Repo: https://github.com/servo/servo
Source-Revision: 8c314ff5d07acc71f556dcca87d7bc2facf93830 | diff --git a/style/custom_properties.rs b/style/custom_properties.rs
index ca6e82033..5507739a7 100644
--- a/style/custom_properties.rs
+++ b/style/custom_properties.rs
@@ -10,7 +10,7 @@ use Atom;
use cssparser::{Delimiter, Parser, ParserInput, SourcePosition, Token, TokenSerializationType};
use precomputed_hash::Pre... | 7 | 202 | 168 |
9799c938a94ec18d78dbf8e53fd4f0f8efa40bc0 | Boris Chiou | 2017-10-09T11:51:47 | servo: Merge #18788 - Use defualt Debug trait for AnimationValue (from BorisChiou:style/animation_value/debug); r=emilio
We use AnimationValue for animation backend to do interpolation,
accumulation, or computing distance. While debugging it, dumping the
property name is not enough. We need to dump the detailed value ... | diff --git a/style/properties/helpers/animated_properties.mako.rs b/style/properties/helpers/animated_properties.mako.rs
index c3a272239..5bf10a8b3 100644
--- a/style/properties/helpers/animated_properties.mako.rs
+++ b/style/properties/helpers/animated_properties.mako.rs
@@ -337,7 +337,7 @@ unsafe impl HasSimpleFFI fo... | 1 | 1 | 7 |
9f040fd03a60b5e0db617e43bea7619f9c71c0aa | Emilio Cobos Álvarez | 2017-10-09T10:04:15 | servo: Merge #18794 - style: use the XBL styleset quirks mode to match XBL rules (from emilio:xbl-quirks-mode); r=heycam
This fixes bug 1405543.
MozReview-Commit-ID: Dv3mt3Fb8Yp
Source-Repo: https://github.com/servo/servo
Source-Revision: 604cc4e311f1aec72599d43c5a0138b04c8b780d | diff --git a/style/gecko/data.rs b/style/gecko/data.rs
index 2db087186..2f4fbc070 100644
--- a/style/gecko/data.rs
+++ b/style/gecko/data.rs
@@ -123,6 +123,11 @@ impl PerDocumentStyleData {
/// Create a dummy `PerDocumentStyleData`.
pub fn new(pres_context: RawGeckoPresContextOwned) -> Self {
let dev... | 2 | 16 | 2 |
b69007db8de147eb93d129ad24c467d473d5466b | Bobby Holley | 2017-10-09T07:04:17 | servo: Merge #18789 - Assert more things in hashtables (from bholley:more_hashmap_asserts); r=Manishearth
https://bugzilla.mozilla.org/show_bug.cgi?id=1406815
Source-Repo: https://github.com/servo/servo
Source-Revision: 49376c9e544c6b3f0d340dff0450ad3267219428 | diff --git a/hashglobe/src/table.rs b/hashglobe/src/table.rs
index 8fc306a39..788e98aa5 100644
--- a/hashglobe/src/table.rs
+++ b/hashglobe/src/table.rs
@@ -43,7 +43,7 @@ struct TaggedHashUintPtr(Unique<HashUint>);
impl TaggedHashUintPtr {
#[inline]
unsafe fn new(ptr: *mut HashUint) -> Self {
- debug_... | 1 | 73 | 26 |
f78122c69a52cbb383b86d31b39cfc6ca209f735 | Emilio Cobos Álvarez | 2017-10-08T14:50:04 | servo: Merge #18783 - style: Introduce CustomPropertiesBuilder (from emilio:custom-props-builder); r=SimonSapin
I'm about to introduce more state here to implement optimizations for custom
property cascading, so this abstraction is useful to encapsulate that state.
Source-Repo: https://github.com/servo/servo
Source-R... | diff --git a/style/custom_properties.rs b/style/custom_properties.rs
index 7fd74f83c..ca6e82033 100644
--- a/style/custom_properties.rs
+++ b/style/custom_properties.rs
@@ -457,9 +457,59 @@ fn parse_var_function<'i, 't>(
Ok(())
}
+/// A struct that takes care of encapsulating the cascade process for custom
+///... | 3 | 67 | 51 |
1926d42cb589634fb86b7dd3b9bab532a8f362ff | Stuart Nelson | 2017-10-08T12:47:50 | servo: Merge #18758 - Add support for dynamic bgcolor change (from stuartnelson3:stn/dynamic-body-bgcolor); r=emilio
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] There are tests for these changes
Source-Repo: https://github.com/servo/servo
Source-Revisio... | diff --git a/script/dom/htmlbodyelement.rs b/script/dom/htmlbodyelement.rs
index 4ade55607..53fb0637b 100644
--- a/script/dom/htmlbodyelement.rs
+++ b/script/dom/htmlbodyelement.rs
@@ -125,6 +125,14 @@ impl VirtualMethods for HTMLBodyElement {
Some(self.upcast::<HTMLElement>() as &VirtualMethods)
}
+ ... | 1 | 8 | 0 |
e847245152831bab698df737824e49ace87a1af4 | Emilio Cobos Álvarez | 2017-10-08T11:04:28 | servo: Merge #18781 - style: Add a simple custom properties benchmark (from emilio:custom-props-bench); r=heycam
This is going to help the work in bug 1405411.
Source-Repo: https://github.com/servo/servo
Source-Revision: 47efcd5e52afd62dcd84ba350948039f67613e20 | diff --git a/style/custom_properties.rs b/style/custom_properties.rs
index 9da84c3cc..7fd74f83c 100644
--- a/style/custom_properties.rs
+++ b/style/custom_properties.rs
@@ -8,7 +8,6 @@
use Atom;
use cssparser::{Delimiter, Parser, ParserInput, SourcePosition, Token, TokenSerializationType};
-use parser::ParserContex... | 4 | 16 | 13 |
37a95e1eeeb6cce550182c65b3ac56a52df00529 | Bobby Holley | 2017-10-07T19:55:03 | servo: Merge #18779 - DiagnosticHashMap (from bholley:canary_and_journal); r=Manishearth
https://bugzilla.mozilla.org/show_bug.cgi?id=1405879
Source-Repo: https://github.com/servo/servo
Source-Revision: 3f4afbafab7c0a8bfcf596ea444269bb01af3955 | diff --git a/hashglobe/src/diagnostic.rs b/hashglobe/src/diagnostic.rs
new file mode 100644
index 000000000..0a5a6c4d0
--- /dev/null
+++ b/hashglobe/src/diagnostic.rs
@@ -0,0 +1,210 @@
+use hash_map::HashMap;
+use std::borrow::Borrow;
+use std::hash::{BuildHasher, Hash};
+use table::SafeHash;
+
+use FailedAllocationErr... | 13 | 379 | 72 |
115d02696a335742faaec80d61eb1c7b105a190a | Emilio Cobos Álvarez | 2017-10-07T13:31:44 | servo: Merge #18773 - style: Cleanup MatchingContext construction (from emilio:mc-cleanup); r=nox
Source-Repo: https://github.com/servo/servo
Source-Revision: 438b9df00cc9b1ba6733543ff9f4c99d07a3f27b | diff --git a/selectors/context.rs b/selectors/context.rs
index f0da3b14e..c67ef6638 100644
--- a/selectors/context.rs
+++ b/selectors/context.rs
@@ -94,38 +94,36 @@ pub struct MatchingContext<'a> {
impl<'a> MatchingContext<'a> {
/// Constructs a new `MatchingContext`.
- pub fn new(matching_mode: MatchingMode... | 1 | 25 | 27 |
67a1191fd17589449658428b7015b58107221812 | Emilio Cobos Álvarez | 2017-10-06T17:56:27 | servo: Merge #18763 - style: Check transitions per longhand to know which transitions to keep (from emilio:transition-longhand-id); r=hiro,birtles
This fixes bug https://bugzilla.mozilla.org/show_bug.cgi?id=1406111
This fixes the fishy TransitionProperty mapping which I complained about in my
previous refactor.
Turn... | diff --git a/style/dom.rs b/style/dom.rs
index 4c57edcb1..ed8b52f02 100644
--- a/style/dom.rs
+++ b/style/dom.rs
@@ -19,7 +19,6 @@ use media_queries::Device;
use properties::{AnimationRules, ComputedValues, PropertyDeclarationBlock};
#[cfg(feature = "gecko")] use properties::LonghandId;
#[cfg(feature = "gecko")] use... | 2 | 26 | 34 |
776efb1d7d083d9c2cde67bc6889c00c6327e61c | Paul Rouget | 2017-10-06T15:09:40 | servo: Merge #18737 - remove android specific workaround (from paulrouget:rm_errno_location); r=emilio
https://github.com/lfairy/rust-errno/pull/5 has landed.
I tested on Android. It runs.
Source-Repo: https://github.com/servo/servo
Source-Revision: cfca26a7e0efdf3a2835a576bb1bca998779dadb | diff --git a/servo/lib.rs b/servo/lib.rs
index 3a2d2671d..262f5a221 100644
--- a/servo/lib.rs
+++ b/servo/lib.rs
@@ -650,16 +650,6 @@ pub fn run_content_process(token: String) {
script::script_thread::ScriptThread>(true);
}
-// This is a workaround for https://github.com/rust-la... | 1 | 0 | 10 |
a5b9a8798b6113bebf3a12ef3cc8872ada0558cd | Emilio Cobos Álvarez | 2017-10-06T10:28:28 | servo: Merge #18765 - stylo: Make :-moz-styleeditor-transitioning only valid in UA sheets (from emilio:unship-moz-se-transitioning); r=upsuper
Bug: 1396099
Reviewed-by: xidorn
Source-Repo: https://github.com/servo/servo
Source-Revision: a468d05fffc0246bd5881f4720841c6b3fe5b364 | diff --git a/style/gecko/non_ts_pseudo_class_list.rs b/style/gecko/non_ts_pseudo_class_list.rs
index 497c80654..c9f711cb7 100644
--- a/style/gecko/non_ts_pseudo_class_list.rs
+++ b/style/gecko/non_ts_pseudo_class_list.rs
@@ -60,8 +60,7 @@ macro_rules! apply_non_ts_list {
("target", Target, target, IN_T... | 1 | 1 | 2 |
866aee6d940aed4f1fee9ac65d09763ee04a0443 | Brad Werth | 2017-10-06T08:39:42 | servo: Merge #18764 - Change MediaExpressionValue::from_css_value to only accept pixels (from bradwerth:onlyDPPX); r=heycam
MozReview-Commit-ID: Hn3twVa8xLo
<!-- Please describe your changes on the following line: -->
https://bugzilla.mozilla.org/show_bug.cgi?id=1404097
https://reviewboard.mozilla.org/r/184746/
---
... | diff --git a/style/gecko/media_queries.rs b/style/gecko/media_queries.rs
index ea4d0d55e..e0be4e742 100644
--- a/style/gecko/media_queries.rs
+++ b/style/gecko/media_queries.rs
@@ -374,18 +374,8 @@ impl MediaExpressionValue {
Some(MediaExpressionValue::BoolInteger(i == 1))
}
n... | 1 | 2 | 12 |
392166c5e56da158bae733454056391ca177ac9d | Boris Zbarsky | 2017-10-06T06:53:12 | servo: Merge #18767 - Don't assume that inputs to compute_style_with_inputs have any rules (from bzbarsky:fix-inputs-no-rules); r=heycam
It could be a text style, which never has any rules attached to it.
Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1406222
<!-- Please describe your changes on the following li... | diff --git a/style/stylist.rs b/style/stylist.rs
index b992b7c24..a8bc12085 100644
--- a/style/stylist.rs
+++ b/style/stylist.rs
@@ -894,12 +894,12 @@ impl Stylist {
// We need to compute visited values if we have visited rules or if our
// parent has visited values.
let visited_values = if i... | 1 | 4 | 4 |
6818f37ba24b23eb73eb9718e185b5787b33e539 | Matt Brubeck | 2017-10-06T02:24:24 | servo: Merge #18754 - Use raw pointers instead of transmute for UnsafeFlow (from mbrubeck:unsafe-flow); r=nox
This makes the code depend a bit less on rustc implementation details.
r? pcwalton
---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These chang... | diff --git a/layout/parallel.rs b/layout/parallel.rs
index 44b5f83c7..3793ad648 100644
--- a/layout/parallel.rs
+++ b/layout/parallel.rs
@@ -8,6 +8,7 @@
#![allow(unsafe_code)]
+use block::BlockFlow;
use context::LayoutContext;
use flow::{self, Flow};
use flow_ref::FlowRef;
@@ -16,6 +17,7 @@ use rayon;
use serv... | 1 | 12 | 14 |
de1557c3f13cae88bc5053afc42cfb8c13fc3bb5 | Bastien Orivel | 2017-10-06T00:37:30 | servo: Merge #18743 - Bump base64 to 0.6 (from Eijebong:base64); r=jdm
This allows us to update hyper to 0.10.13 (closer to 0.11)
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes do not require tests because they're just a version bump
Source-... | diff --git a/net/Cargo.toml b/net/Cargo.toml
index 8a7dea67e..ef6dbe2a0 100644
--- a/net/Cargo.toml
+++ b/net/Cargo.toml
@@ -10,7 +10,7 @@ name = "net"
path = "lib.rs"
[dependencies]
-base64 = "0.5.2"
+base64 = "0.6"
brotli = "1.0.6"
cookie = "0.6"
devtools_traits = {path = "../devtools_traits"}
diff --git a/scr... | 3 | 3 | 3 |
c67b143e29863b72f5b18e041d299ab9f427bc31 | Emilio Cobos Álvarez | 2017-10-05T14:22:24 | servo: Merge #18761 - style: Iterate in the expected order in the custom_properties module (from emilio:custom-props-iter); r=SimonSapin
In #18745, I replaced a few manual iterations over `index` with the iterator,
and it changed the behavior of `layout/style/test/test_variables_order.html`,
since it turns out that th... | diff --git a/style/custom_properties.rs b/style/custom_properties.rs
index 7a1302b46..8351248a3 100644
--- a/style/custom_properties.rs
+++ b/style/custom_properties.rs
@@ -190,14 +190,14 @@ where
type Item = (&'a K, &'a V);
fn next(&mut self) -> Option<Self::Item> {
- let ref index = self.inner.inde... | 1 | 5 | 5 |
41606c62504ea012aea45a94bb943d0946ee77b8 | Emilio Cobos Álvarez | 2017-10-05T10:49:06 | servo: Merge #18752 - style: Use the flattened tree parent to find the closest non-nac ancestor of an element (from emilio:cc-parent); r=bzbarsky
This only matters for document level NAC like canvas custom content, in which
case otherwise we inherit from the document element (which is wrong).
Bug: 1405635
Source-Repo... | diff --git a/style/gecko/wrapper.rs b/style/gecko/wrapper.rs
index a32d86bb3..7d82c6ddd 100644
--- a/style/gecko/wrapper.rs
+++ b/style/gecko/wrapper.rs
@@ -930,7 +930,7 @@ impl<'le> TElement for GeckoElement<'le> {
fn closest_non_native_anonymous_ancestor(&self) -> Option<Self> {
debug_assert!(self.is_... | 1 | 2 | 2 |
d5c1f0647d086f473a7ec084df16cc4732eba440 | Emilio Cobos Álvarez | 2017-10-05T07:18:52 | servo: Merge #18745 - style: Custom properties cleanup (from emilio:custom-props-less-unwrap); r=nox
Use less unwrap and custom types in custom properties.
The idea is for this to shed some light in https://bugzilla.mozilla.org/show_bug.cgi?id=1403845.
Source-Repo: https://github.com/servo/servo
Source-Revision: 9bf... | diff --git a/style/custom_properties.rs b/style/custom_properties.rs
index 0277b16fb..7a1302b46 100644
--- a/style/custom_properties.rs
+++ b/style/custom_properties.rs
@@ -197,7 +197,7 @@ where
let ref key = index[index.len() - self.pos - 1];
self.pos += 1;
- let value = self.inner.values.ge... | 1 | 31 | 24 |
1efeda3baa619d6da4bf3906e4423a66b10573a1 | Bobby Holley | 2017-10-05T04:54:56 | servo: Merge #18751 - Poison hashtable buffers (from bholley:poison_hashtable); r=Manishearth
This gives us extra defense in depth.
Source-Repo: https://github.com/servo/servo
Source-Revision: 2bbc458c5b2ad44d008cfa57415fe41d1a7ada5e | diff --git a/hashglobe/src/table.rs b/hashglobe/src/table.rs
index 45dcb2673..71212ccf6 100644
--- a/hashglobe/src/table.rs
+++ b/hashglobe/src/table.rs
@@ -777,13 +777,16 @@ impl<K, V> RawTable<K, V> {
// FORK NOTE: Uses alloc shim instead of Heap.alloc
- let buffer = alloc(size, alignment);
+ ... | 1 | 4 | 1 |
6774c92834282e88a9bc609c0ab7fb85d017df07 | Manish Goregaokar | 2017-10-05T01:57:24 | servo: Merge #18734 - stylo: `all` shorthand should not apply to internal properties (from Manishearth:stylo-all); r=upsuper
r=xidorn https://bugzilla.mozilla.org/show_bug.cgi?id=1404057
Source-Repo: https://github.com/servo/servo
Source-Revision: 43686a8738513db728eebcc535b5ac6e1a2f17f7 | diff --git a/style/properties/properties.mako.rs b/style/properties/properties.mako.rs
index 4c83089c5..7de94c689 100644
--- a/style/properties/properties.mako.rs
+++ b/style/properties/properties.mako.rs
@@ -175,7 +175,9 @@ pub mod shorthands {
// We don't defined the 'all' shorthand using the regular helpers:sho... | 1 | 3 | 1 |
4bb64e66804d98f4488aba5e220d026e86f00172 | Glenn Watson | 2017-10-04T22:09:40 | servo: Merge #18735 - Update WR (clip masks on angle gradients, fix clips on transformed images) (from glennw:update-wr-angle-clips); r=mbrubeck
Source-Repo: https://github.com/servo/servo
Source-Revision: 22685465156a07eadca0edfcc5eca119f3ec4681 | diff --git a/layout/webrender_helpers.rs b/layout/webrender_helpers.rs
index 55f13d389..8f86477e9 100644
--- a/layout/webrender_helpers.rs
+++ b/layout/webrender_helpers.rs
@@ -458,15 +458,15 @@ impl WebRenderDisplayItemConverter for DisplayItem {
}
DisplayItem::PushTextShadow(ref item) => {
... | 1 | 7 | 7 |
2a2727ae4cab1edc81f0af926523629acdfdeedf | Brad Werth | 2017-10-04T20:31:17 | servo: Merge #18733 - Change resolution queries to compare in unconverted dppx units (from bradwerth:nativeDPPX); r=heycam
MozReview-Commit-ID: 7wYlixTQTIC
<!-- Please describe your changes on the following line: -->
https://bugzilla.mozilla.org/show_bug.cgi?id=1376931
https://reviewboard.mozilla.org/r/182424/
---
<... | diff --git a/style/gecko/media_queries.rs b/style/gecko/media_queries.rs
index 394cd5c18..00e2d0887 100644
--- a/style/gecko/media_queries.rs
+++ b/style/gecko/media_queries.rs
@@ -373,8 +373,18 @@ impl MediaExpressionValue {
Some(MediaExpressionValue::BoolInteger(i == 1))
}
n... | 1 | 12 | 2 |
b314447fee0ccc724b5b357ab41207bb665b9cc6 | Hiroyuki Ikezoe | 2017-10-04T16:56:42 | servo: Merge #18719 - Use NormalDeclarationIterator for AnimationValueIterator (from hiikezoe:use-normal-declaration-iterator); r=emilio
<!-- Please describe your changes on the following line: -->
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace ... | diff --git a/style/properties/declaration_block.rs b/style/properties/declaration_block.rs
index 4c1c3c5b5..b1c7d547b 100644
--- a/style/properties/declaration_block.rs
+++ b/style/properties/declaration_block.rs
@@ -148,7 +148,7 @@ impl<'a> Iterator for NormalDeclarationIterator<'a> {
/// Iterator for AnimationValu... | 1 | 4 | 8 |
b14f07a7c6e10b08d110eefc598449df477c7937 | Paul Rouget | 2017-10-04T15:34:52 | servo: Merge #18702 - do not force resource_path on android (from paulrouget:android_res_path); r=Manishearth
I want to be able to configure the resource path via `set_resources_path`.
Source-Repo: https://github.com/servo/servo
Source-Revision: b1c2d7195dd01a131c10d2bc2ad457a51c3fa118 | diff --git a/config/resource_files.rs b/config/resource_files.rs
index bc3e9a78e..e8fc58328 100644
--- a/config/resource_files.rs
+++ b/config/resource_files.rs
@@ -27,10 +27,18 @@ pub fn set_resources_path(path: Option<String>) {
#[cfg(target_os = "android")]
#[allow(unsafe_code)]
pub fn resources_dir_path() -> io:... | 1 | 10 | 2 |
baa13b536e3e842dfcea08c006f6173efecd87d7 | Neha | 2017-10-04T12:32:53 | servo: Merge #18716 - Parse srcset attribute values (from jdm:parseSrcset); r=jdm
Squashed version of #18313.
---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix (partially) #11416
- [x] There are tests for these changes
Source-Repo: http... | diff --git a/script/dom/htmlimageelement.rs b/script/dom/htmlimageelement.rs
index 1fea05fc0..027221a88 100644
--- a/script/dom/htmlimageelement.rs
+++ b/script/dom/htmlimageelement.rs
@@ -57,15 +57,34 @@ use std::char;
use std::default::Default;
use std::i32;
use std::sync::{Arc, Mutex};
-use style::attr::{AttrValu... | 3 | 200 | 2 |
9337b219381534096d2e153be6b5e6e778b27d04 | Simon Sapin | 2017-10-04T08:12:33 | servo: Merge #18741 - Remove usage the unstable Step trait (from servo:no-step); r=nox
Source-Repo: https://github.com/servo/servo
Source-Revision: f044fa4e9f69ca8b23d96f55e7846976203ab732 | diff --git a/gfx/text/glyph.rs b/gfx/text/glyph.rs
index ce3bad9cd..c0e1be96d 100644
--- a/gfx/text/glyph.rs
+++ b/gfx/text/glyph.rs
@@ -696,7 +696,7 @@ pub struct GlyphIterator<'a> {
store: &'a GlyphStore,
byte_index: ByteIndex,
byte_range: Range<ByteIndex>,
- glyph_range: Option<EachIndex<isize, Byt... | 2 | 30 | 17 |
4b6f60215c72378e7f1df2fa87cd9bcae66e6993 | Nicholas Nethercote | 2017-10-04T04:21:18 | servo: Merge #18736 - Remove nsTFixedString<T> (from nnethercote:bug-1403506); r=erahm,mystor
This is for https://bugzilla.mozilla.org/show_bug.cgi?id=1403506, which is r=erahm,mystor.
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropr... | diff --git a/style/gecko/rules.rs b/style/gecko/rules.rs
index fbdc8dbf3..88e9600c8 100644
--- a/style/gecko/rules.rs
+++ b/style/gecko/rules.rs
@@ -15,6 +15,7 @@ use gecko_bindings::structs::{self, nsCSSFontFaceRule, nsCSSValue};
use gecko_bindings::structs::{nsCSSCounterDesc, nsCSSCounterStyleRule};
use gecko_bindi... | 3 | 15 | 166 |
a4d51ac969c9ed451d03e3a45f85e5d0ef357515 | Emilio Cobos Álvarez | 2017-10-04T01:34:09 | servo: Merge #18728 - style: Update rayon (from emilio:rayonup); r=jdm
It has a couple soundness fixes.
Source-Repo: https://github.com/servo/servo
Source-Revision: a4f642185e741db879043890d6f9043520fa0cb1 | diff --git a/style/Cargo.toml b/style/Cargo.toml
index 769f7bf0c..1d22a23df 100644
--- a/style/Cargo.toml
+++ b/style/Cargo.toml
@@ -62,7 +62,7 @@ owning_ref = "0.3.3"
parking_lot = "0.4"
pdqsort = "0.1.0"
precomputed-hash = "0.1.1"
-rayon = "0.8"
+rayon = "0.8.2"
selectors = { path = "../selectors" }
serde = {ver... | 1 | 1 | 1 |
c348af4ca143a7723c3a9ca988ccfe721b8b42e3 | Manish Goregaokar | 2017-10-03T23:47:46 | servo: Merge #18712 - stylo: use FnvHashMap everywhere, remove default HashMap construction methods (from Manishearth:fnv); r=bholley
r=bholley bug 1385971
Source-Repo: https://github.com/servo/servo
Source-Revision: 89724c6b32c6c0b7673df6d5b735e057a392f51b | diff --git a/hashglobe/src/fake.rs b/hashglobe/src/fake.rs
index a19931f95..eed48fc91 100644
--- a/hashglobe/src/fake.rs
+++ b/hashglobe/src/fake.rs
@@ -43,24 +43,6 @@ impl<K, V, S> DerefMut for HashMap<K, V, S> {
}
}
-impl<K: Hash + Eq, V> HashMap<K, V, RandomState> {
- #[inline]
- pub fn new() -> HashMa... | 7 | 12 | 98 |
8fd0c50e64d029535aeff4a5701ee2367cb99d2d | Bobby Holley | 2017-10-03T19:45:33 | servo: Merge #18732 - Revert #18668 - Add mprotect diagnostics for HashMap crash (except for round-up-to-page behavior) (from bholley:revert_mprotect_diagnostics); r=bholley
These diagnostics have served their purpose, time to remove them.
https://bugzilla.mozilla.org/show_bug.cgi?id=1403397
Source-Repo: https://git... | diff --git a/hashglobe/src/hash_map.rs b/hashglobe/src/hash_map.rs
index c1c4db4d3..69bd06344 100644
--- a/hashglobe/src/hash_map.rs
+++ b/hashglobe/src/hash_map.rs
@@ -1027,12 +1027,6 @@ impl<K, V, S> HashMap<K, V, S>
self.table.size()
}
- /// Access to the raw buffer backing this hashmap.
- pub ... | 11 | 9 | 432 |
7863f69334eeb50b1843977a089577d53a602989 | Emilio Cobos Álvarez | 2017-10-03T17:46:53 | servo: Merge #18696 - layout_thread: Avoid adding the UA sheets multiple times when there's no root flow (from emilio:ua-sheets-reflow); r=jdm
Source-Repo: https://github.com/servo/servo
Source-Revision: 3dc4614991bad12502bf4c5194f7fd2255872b60 | diff --git a/layout_thread/lib.rs b/layout_thread/lib.rs
index 76146989f..1bfcf112c 100644
--- a/layout_thread/lib.rs
+++ b/layout_thread/lib.rs
@@ -1318,6 +1318,7 @@ impl LayoutThread {
&mut layout_context);
}
+ self.first_reflow.set(false);
... | 1 | 16 | 16 |
8dc314986a1c8818c848ef8aba8f6c68d9fe954d | Josh Matthews | 2017-10-03T16:25:28 | servo: Merge #18414 - Reduce the size of AnimationValue code (from jdm:animdecl-codesize); r=SimonSapin
According to bloaty, these commits shave off 25k from code in the animated_properties module.
---
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
Source-Repo:... | diff --git a/style/properties/helpers/animated_properties.mako.rs b/style/properties/helpers/animated_properties.mako.rs
index f3d6f9aa7..c3a272239 100644
--- a/style/properties/helpers/animated_properties.mako.rs
+++ b/style/properties/helpers/animated_properties.mako.rs
@@ -407,7 +407,7 @@ impl AnimationValue {
... | 1 | 40 | 29 |
71252dca4f69d41e886dc86ea217d50bc6eca3a3 | Martin Robinson | 2017-10-03T15:21:23 | servo: Merge #18725 - TickAnimations should create a display list (from mrobinson:tick-animation-display-list); r=jdm
This is a regression from the removal of ReflowQueryType.
Fixes #18701.
<!-- Please describe your changes on the following line: -->
---
<!-- Thank you for contributing to Servo! Please replace each... | diff --git a/script_layout_interface/message.rs b/script_layout_interface/message.rs
index 2df0b7de1..a026b349a 100644
--- a/script_layout_interface/message.rs
+++ b/script_layout_interface/message.rs
@@ -126,12 +126,13 @@ impl ReflowGoal {
pub fn needs_display_list(&self) -> bool {
match *self {
... | 1 | 3 | 2 |
eee4572bdf7f0bae92be0a155f7b8578f5f87d52 | Julian Seward | 2017-10-03T11:06:14 | servo: Merge #18661 - Bug 1400754 - stylo: crash on Win64 Asan build. r=manishearth, dmajor (from julian-seward1:master); r=emilio
* adds a hashglobe::alloc::realloc, as that was previously not implemented,
copying and simplifying from liballoc_system.
* routes malloc and realloc calls through hashglobe::alloc::, ... | diff --git a/fallible/lib.rs b/fallible/lib.rs
index 4a48190a1..c220699a7 100644
--- a/fallible/lib.rs
+++ b/fallible/lib.rs
@@ -6,16 +6,12 @@ extern crate hashglobe;
extern crate smallvec;
use hashglobe::FailedAllocationError;
+#[cfg(feature = "known_system_malloc")]
+use hashglobe::alloc;
use smallvec::Array;
u... | 3 | 22 | 12 |
1cc2796b9af9b108529a97af6b2ac80620f49132 | Rakhi Sharma | 2017-10-03T09:16:00 | servo: Merge #18714 - Parse sizes attribute values (from jdm:sizes); r=jdm
Squashed version of #17808.
---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix (partially) #11416
- [x] There are tests for these changes
Source-Repo: https://git... | diff --git a/script/dom/htmlimageelement.rs b/script/dom/htmlimageelement.rs
index 7c2255d66..1fea05fc0 100644
--- a/script/dom/htmlimageelement.rs
+++ b/script/dom/htmlimageelement.rs
@@ -3,6 +3,7 @@
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
use app_units::{Au, AU_PER_PX};
+use cssparser::{Par... | 3 | 74 | 1 |
06905e2dd3e4b010b332fe8138d770f631811c74 | Emilio Cobos Álvarez | 2017-10-03T05:40:03 | servo: Merge #18703 - style: Allow passing an nth-index-cache to the invalidation code (from emilio:nth-index-cache-invalidate); r=bholley
style: Allow passing an nth-index-cache to the invalidation code.
Source-Repo: https://github.com/servo/servo
Source-Revision: 2a5121357a76e2b558ecd0dae7689d709b6a2b41 | diff --git a/style/data.rs b/style/data.rs
index 8d9a982b8..bc3f0b174 100644
--- a/style/data.rs
+++ b/style/data.rs
@@ -14,6 +14,7 @@ use properties::ComputedValues;
use properties::longhands::display::computed_value as display;
use rule_tree::StrongRuleNode;
use selector_parser::{EAGER_PSEUDO_COUNT, PseudoElement,... | 3 | 105 | 74 |
452b587b7e444fe6e9b36b640e9dd5794e8ccba6 | Emilio Cobos Álvarez | 2017-10-02T07:10:25 | servo: Merge #18699 - Remove some cfg'd imports (from emilio:remove-cfg); r=jdm
Source-Repo: https://github.com/servo/servo
Source-Revision: e13f5a656af682add10cdc41fb8e625c04b60347 | diff --git a/style/properties/properties.mako.rs b/style/properties/properties.mako.rs
index a68bb7352..4c83089c5 100644
--- a/style/properties/properties.mako.rs
+++ b/style/properties/properties.mako.rs
@@ -17,7 +17,6 @@ use smallbitvec::SmallBitVec;
use std::borrow::Cow;
use std::{fmt, mem, ops};
use std::cell::R... | 2 | 8 | 13 |
83d7e86ab719816f18c42914cf46472178af607b | Emilio Cobos Álvarez | 2017-10-02T06:06:23 | servo: Merge #18698 - style: Remove the last of the explicit style fixups (from emilio:always-been-cleaning-up-ifdefs); r=mrobinson
No more `modify_style_for_foo` in `properties.mako.rs`!
Source-Repo: https://github.com/servo/servo
Source-Revision: 28b8f8eba5c77ffe4175dc6da1c56c87e0ae44d7 | diff --git a/layout/display_list_builder.rs b/layout/display_list_builder.rs
index 08b19d46a..dc2375b76 100644
--- a/layout/display_list_builder.rs
+++ b/layout/display_list_builder.rs
@@ -50,8 +50,8 @@ use std::sync::Arc;
use style::computed_values::{background_attachment, background_clip, background_origin};
use st... | 2 | 96 | 104 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.