commit_hash stringlengths 40 40 | author stringlengths 1 57 | date timestamp[s]date 2010-07-26 04:45:09 2026-04-14 18:21:10 | message stringlengths 8 1.39M | diff stringlengths 68 51.2k | files_changed int64 1 136 | insertions int64 0 2.35k | deletions int64 0 1.9k |
|---|---|---|---|---|---|---|---|
5fbc48d447ac0bd7e8819de970695ac83b99b805 | Cameron McCormack | 2017-09-14T09:28:50 | servo: Merge #18499 - style: add a TLS-based cache of reset style structs (from heycam:rule-cache); r=emilio
Rule cache
<!-- Please describe your changes on the following line: -->
This adds a TLS-based cache reset styles structs keyed off rule nodes. Reviewed in https://bugzilla.mozilla.org/show_bug.cgi?id=1367635 ... | diff --git a/servo_arc/lib.rs b/servo_arc/lib.rs
index 5cac8c9b9..9ed2801ac 100644
--- a/servo_arc/lib.rs
+++ b/servo_arc/lib.rs
@@ -122,6 +122,12 @@ impl<T: ?Sized + 'static> PartialEq for NonZeroPtrMut<T> {
impl<T: ?Sized + 'static> Eq for NonZeroPtrMut<T> {}
+impl<T: Sized + 'static> Hash for NonZeroPtrMut<T> {... | 20 | 458 | 33 |
54ff35101ed4901020dab2f7c0d41a0165736e23 | Bobby Holley | 2017-09-14T05:07:52 | servo: Merge #18496 - do a second pass on the style sharing cache after computing the rule node (from bholley:2ndpass); r=emilio
https://bugzilla.mozilla.org/show_bug.cgi?id=1397976
Source-Repo: https://github.com/servo/servo
Source-Revision: 298b1363ffd7e830a6ad28424421ead6628ac9b7 | diff --git a/style/context.rs b/style/context.rs
index de8c95bb4..b94f70491 100644
--- a/style/context.rs
+++ b/style/context.rs
@@ -313,6 +313,9 @@ pub struct TraversalStatistics {
pub elements_matched: u32,
/// The number of cache hits from the StyleSharingCache.
pub styles_shared: u32,
+ /// The nu... | 8 | 342 | 124 |
cb690daeeadf212611ad9042587e78e983fe49cd | Corey Farwell | 2017-09-14T00:38:32 | servo: Merge #18494 - Implement `size_hint` for more iterators (from frewsxcv:frewsxcv-size-hint); r=jdm
```
implement size hint for
more iterators because why
not we like fast things
```
Source-Repo: https://github.com/servo/servo
Source-Revision: bb2030a49314433c1b31f853e4fa50afa241b596 | diff --git a/layout/flow.rs b/layout/flow.rs
index f4c545ec7..a2a057614 100644
--- a/layout/flow.rs
+++ b/layout/flow.rs
@@ -765,6 +765,10 @@ impl<'a> Iterator for AbsoluteDescendantIter<'a> {
fn next(&mut self) -> Option<&'a mut Flow> {
self.iter.next().map(|info| FlowRef::deref_mut(&mut info.flow))
... | 8 | 36 | 0 |
0038a6390fb0600aae9f5581cd9a4a02caa1a386 | Emilio Cobos Álvarez | 2017-09-13T22:44:21 | servo: Merge #18486 - style: Move ExtraStyleData into CascadeData (from emilio:extra-data-to-cascade-data); r=SimonSapin
It logically belongs there, and the only reason it wasn't there before we were
working around other stuff. Now it's needed to share UA stylesheets across documents.
Source-Repo: https://github.com/... | diff --git a/layout_thread/lib.rs b/layout_thread/lib.rs
index cd9bf1ac2..15407b2ba 100644
--- a/layout_thread/lib.rs
+++ b/layout_thread/lib.rs
@@ -1198,11 +1198,9 @@ impl LayoutThread {
self.stylist.force_stylesheet_origins_dirty(Origin::Author.into());
}
- let mut extra_dat... | 3 | 52 | 28 |
49237608ca3e22df9a9467a73ea8e529b314a3a5 | Emilio Cobos Álvarez | 2017-09-13T19:59:16 | servo: Merge #18484 - style: Store stylesheets per origin (from emilio:per-origin-sheets); r=SimonSapin
This is the first step that will allow us to cache UA sheets across documents.
Source-Repo: https://github.com/servo/servo
Source-Revision: d461347adf47c47a73a7242e23d57a5741872d4f | diff --git a/script/dom/document.rs b/script/dom/document.rs
index 886e392de..c20ab9905 100644
--- a/script/dom/document.rs
+++ b/script/dom/document.rs
@@ -141,7 +141,7 @@ use style::selector_parser::{RestyleDamage, Snapshot};
use style::shared_lock::{SharedRwLock as StyleSharedRwLock, SharedRwLockReadGuard};
use st... | 8 | 221 | 101 |
c1342d80bace5fb8c28381cfecddba8b71de7315 | Josh Matthews | 2017-09-13T15:51:00 | servo: Merge #18352 - Make serialization match Gecko in a few corner cases (from jdm:serialize-fun); r=emilio
This addresses the testcases from https://bugzilla.mozilla.org/show_bug.cgi?id=1345218. Gecko differs from the specification by doing the following:
* reusing longhands that have previously been serialized in ... | diff --git a/style/properties/declaration_block.rs b/style/properties/declaration_block.rs
index c458bad17..a87b87fe9 100644
--- a/style/properties/declaration_block.rs
+++ b/style/properties/declaration_block.rs
@@ -657,10 +657,6 @@ impl ToCss for PropertyDeclarationBlock {
if is_system_font {
... | 2 | 21 | 9 |
c8d5f892587638128ee8c48e130c54c0488678bf | Anthony Ramine | 2017-09-13T14:18:41 | servo: Merge #18480 - Store microtask queues directly in GlobalScope (from servo:rc-microtask-queue); r=jdm
Source-Repo: https://github.com/servo/servo
Source-Revision: 2c576e5613b16ba9353461498086b279c283e018 | diff --git a/script/dom/dedicatedworkerglobalscope.rs b/script/dom/dedicatedworkerglobalscope.rs
index 9c4949027..8ea89562f 100644
--- a/script/dom/dedicatedworkerglobalscope.rs
+++ b/script/dom/dedicatedworkerglobalscope.rs
@@ -247,7 +247,7 @@ impl DedicatedWorkerGlobalScope {
global.handle_event(... | 8 | 213 | 229 |
1360241804604b75f2c3d1eb5af10a1e88ea8411 | Nicholas Nethercote | 2017-09-13T13:02:45 | servo: Merge #18474 - malloc_size_of tweaks (from nnethercote:malloc_size_of-tweaks); r=jdm
<!-- Please describe your changes on the following line: -->
A couple of tweaks.
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate dat... | diff --git a/malloc_size_of/lib.rs b/malloc_size_of/lib.rs
index ae80385eb..5ecd29d79 100644
--- a/malloc_size_of/lib.rs
+++ b/malloc_size_of/lib.rs
@@ -103,25 +103,32 @@ impl MallocSizeOfOps {
/// Check if an allocation is empty. This relies on knowledge of how Rust
/// handles empty allocations, which may... | 3 | 34 | 17 |
aa48bd86784f19a1a9f602b9352d46e0bc4925c9 | Glenn Watson | 2017-09-13T00:07:49 | servo: Merge #18470 - Update WR (backface API changes) (from glennw:update-wr-bf); r=pcwalton
This does the minimal work to update to the API changes related
to backface support. It doesn't actually pass through any info
about the backface visibility flags yet.
Source-Repo: https://github.com/servo/servo
Source-Revis... | diff --git a/layout/webrender_helpers.rs b/layout/webrender_helpers.rs
index 59aa20d95..4bcd4f337 100644
--- a/layout/webrender_helpers.rs
+++ b/layout/webrender_helpers.rs
@@ -19,6 +19,16 @@ use style::values::generics::effects::Filter as GenericFilter;
use webrender_api::{self, ClipAndScrollInfo, ComplexClipRegion, ... | 1 | 30 | 27 |
b6e9dde5f7c5fb03d0c5d3ba857f96252cbb915e | Julian Seward | 2017-09-12T20:25:52 | servo: Merge #18460 - Bug 1398593 - stylo: mitigate performance impact of fallible allocati… (from julian-seward1:master); r=emilio
…on on stylist rebuilds. r=emilio.
<!-- Please describe your changes on the following line: -->
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when th... | diff --git a/fallible/lib.rs b/fallible/lib.rs
index 816e20573..4a48190a1 100644
--- a/fallible/lib.rs
+++ b/fallible/lib.rs
@@ -27,7 +27,7 @@ pub trait FallibleVec<T> {
// Vec
impl<T> FallibleVec<T> for Vec<T> {
- #[inline]
+ #[inline(always)]
fn try_push(&mut self, val: T) -> Result<(), FailedAllocatio... | 2 | 3 | 2 |
792294e893f61ea3b742be141022206be266d671 | Anthony Ramine | 2017-09-12T19:14:33 | servo: Merge #18459 - Kill ComputedValueAsSpecified 🔫 (from servo:kill-cvas); r=emilio
Source-Repo: https://github.com/servo/servo
Source-Revision: b856f11388b629759773a905379b1f238a9ca348 | diff --git a/style/properties/helpers.mako.rs b/style/properties/helpers.mako.rs
index ab290abef..3e24a0810 100644
--- a/style/properties/helpers.mako.rs
+++ b/style/properties/helpers.mako.rs
@@ -316,7 +316,7 @@
% if not property.derived_from:
match value {
- Declared... | 8 | 35 | 76 |
e07f023f63a6d55cf2bcf58088c501956b18924d | Bobby Holley | 2017-09-12T18:16:26 | servo: Merge #18465 - Eliminate RestyleData (from bholley:kill_restyledata); r=emilio
https://bugzilla.mozilla.org/show_bug.cgi?id=1399011
Source-Repo: https://github.com/servo/servo
Source-Revision: 72f0fda836ff97d33169cd1fc0d23d2d07ad74c6 | diff --git a/layout/traversal.rs b/layout/traversal.rs
index 48bfc1077..077e43fb4 100644
--- a/layout/traversal.rs
+++ b/layout/traversal.rs
@@ -77,7 +77,7 @@ impl<'a, E> DomTraversal<E> for RecalcStyleAndConstructFlows<'a>
// (1) They child doesn't yet have layout data (preorder traversal initializes it).
... | 11 | 154 | 192 |
456924c7c703bde6839e7f7678236cffa5e74cd3 | Tom Tromey | 2017-09-12T14:44:53 | servo: Merge #18449 - Remove get_location_with_offset (from tromey:remove-get_location_with_offset); r=jdm
Now that rust-cssparser reports 1-based locations, bump the required
cssparser version and remove get_location_with_offset. Previously,
some code paths were not calling get_location_with_offset; see
https://bugz... | diff --git a/canvas/Cargo.toml b/canvas/Cargo.toml
index 6b35891e8..ac91c12a7 100644
--- a/canvas/Cargo.toml
+++ b/canvas/Cargo.toml
@@ -13,7 +13,7 @@ path = "lib.rs"
azure = {git = "https://github.com/servo/rust-azure"}
canvas_traits = {path = "../canvas_traits"}
compositing = {path = "../compositing"}
-cssparser =... | 9 | 12 | 22 |
f87bf31221018ecb64e29c90e49090896056e57c | Nicholas Nethercote | 2017-09-12T13:40:56 | servo: Merge #18455 - Measure Arc<Locked<T>> fields properly (from nnethercote:measure-Arc-Locked-properly); r=jdm
Currently when we measure various Arc<Locked<T>> fields we don't measure the T
itself, but only the descendants of the T. This patch fixes this.
This fix requires introducing a new trait, MallocUnconditi... | diff --git a/malloc_size_of/lib.rs b/malloc_size_of/lib.rs
index a2f080d6c..ae80385eb 100644
--- a/malloc_size_of/lib.rs
+++ b/malloc_size_of/lib.rs
@@ -141,9 +141,10 @@ pub trait MallocSizeOf {
/// Trait for measuring the "shallow" heap usage of a container.
pub trait MallocShallowSizeOf {
- /// Measure the hea... | 8 | 61 | 22 |
7a0f5e08027d810812202ba1757191a7a389fcd3 | Emilio Cobos Álvarez | 2017-09-12T11:11:58 | servo: Merge #18456 - style: Remove an unused function (from emilio:dead-code); r=upsuper
Nobody will miss it.
Source-Repo: https://github.com/servo/servo
Source-Revision: 61fac2c10de5e0d4ce9d559e0effe2582dcbadb2 | diff --git a/style/matching.rs b/style/matching.rs
index bb5f468c0..7548a9b05 100644
--- a/style/matching.rs
+++ b/style/matching.rs
@@ -708,41 +708,6 @@ pub trait MatchMethods : TElement {
}
}
- /// Computes and applies restyle damage.
- fn accumulate_damage(&self,
- share... | 1 | 0 | 35 |
03da4ae8937e5cfe09dbb96586f1cf21cf6c1f11 | Simon Sapin | 2017-09-12T10:01:24 | servo: Merge #18420 - Get rustc commit hash from channel manifest (from servo:toml); r=nox,emilio
… added in https://github.com/rust-lang/rust/pull/44218, instead of using the GitHub API.
Also upgrade to rustc 1.22.0-nightly (d93036a04 2017-09-07).
Source-Repo: https://github.com/servo/servo
Source-Revision: af077a7... | diff --git a/style/bloom.rs b/style/bloom.rs
index 5c7f753a6..93f390340 100644
--- a/style/bloom.rs
+++ b/style/bloom.rs
@@ -121,6 +121,12 @@ impl<E: TElement> StyleBloom<E> {
/// Create an empty `StyleBloom`. Because StyleBloom acquires the thread-
/// local filter buffer, creating multiple live StyleBloom i... | 2 | 12 | 0 |
9073c369801642369a8dcb3511e7450866be147a | Bobby Holley | 2017-09-12T08:25:36 | servo: Merge #18453 - Refactor the style cache (from bholley:style_cache_refactor); r=emilio
This is the first set of patches from https://bugzilla.mozilla.org/show_bug.cgi?id=1398658
Source-Repo: https://github.com/servo/servo
Source-Revision: def983c29566133ab02ed40b9ab8c5e99da8e53e | diff --git a/style/cache.rs b/style/cache.rs
index 8e4c73719..843f614f0 100644
--- a/style/cache.rs
+++ b/style/cache.rs
@@ -39,13 +39,22 @@ impl<K: Array> LRUCache<K> {
#[inline]
/// Touch a given entry, putting it first in the list.
pub fn touch(&mut self, pos: usize) {
- let last_index = self.e... | 4 | 130 | 132 |
8ed42ca83a31b1a028551f454f831788cabcad4a | Manish Goregaokar | 2017-09-12T02:01:57 | servo: Merge #18451 - stylo: Add support for calcs in base size calculation (from Manishearth:stylo-calc-fontsize); r=emilio
This tracks an offset along with the ratio for the keyword font size data.
The offset gets used when a calc is involved whilst inheriting font-size
(it is the computed value of that calc ignorin... | diff --git a/style/gecko/generated/structs_debug.rs b/style/gecko/generated/structs_debug.rs
index 982722b5e..0ff3aa970 100644
--- a/style/gecko/generated/structs_debug.rs
+++ b/style/gecko/generated/structs_debug.rs
@@ -5007,7 +5007,7 @@ pub mod root {
}
#[test]
fn bindgen_test_layout_ServoS... | 7 | 106 | 91 |
f247b16fbc2d5e168e8ec41a28c11c24b2ef1e1d | Anthony Ramine | 2017-09-12T01:04:12 | servo: Merge #18447 - Remove most uses of ComputedValueAsSpecified (from servo:kill-cvas); r=emilio
Source-Repo: https://github.com/servo/servo
Source-Revision: 5cc2b4f705e420b156899ed55072ccc11d0e50c0 | diff --git a/style/counter_style/mod.rs b/style/counter_style/mod.rs
index 094f14a1c..6bdd22d8e 100644
--- a/style/counter_style/mod.rs
+++ b/style/counter_style/mod.rs
@@ -342,7 +342,7 @@ impl ToCss for System {
}
/// https://drafts.csswg.org/css-counter-styles/#typedef-symbol
-#[derive(Clone, Debug, Eq, PartialEq... | 13 | 30 | 58 |
df26a888d4743279f48c7563f3b9cba597d4b3bc | Xidorn Quan | 2017-09-11T23:50:19 | servo: Merge #18450 - Use the LonghandIdSet to check whether a property is set (from upsuper:property-is-set); r=Manishearth
Servo side change of [bug 1398479](https://bugzilla.mozilla.org/show_bug.cgi?id=1398479).
Source-Repo: https://github.com/servo/servo
Source-Revision: 24b2d8d9cf265a149535ebc22941e427dd5e21b3 | diff --git a/style/properties/declaration_block.rs b/style/properties/declaration_block.rs
index 9d9a3a7b2..c91b3a73f 100644
--- a/style/properties/declaration_block.rs
+++ b/style/properties/declaration_block.rs
@@ -239,6 +239,11 @@ impl PropertyDeclarationBlock {
!self.declarations_importance.all_true()
... | 1 | 5 | 0 |
2d00caf24727f7b4c14b8c734dde9ae66ba1a630 | Manish Goregaokar | 2017-09-11T21:28:14 | servo: Merge #18448 - stylo: Round down when computing viewport units (from Manishearth:viewport-round); r=emilio
r=emilio https://bugzilla.mozilla.org/show_bug.cgi?id=1396045
Source-Repo: https://github.com/servo/servo
Source-Revision: a3a3f4bf4fa27e34855c76c69d95c338499f605d | diff --git a/style/values/specified/length.rs b/style/values/specified/length.rs
index 6e79af833..4267c85f4 100644
--- a/style/values/specified/length.rs
+++ b/style/values/specified/length.rs
@@ -198,23 +198,21 @@ impl ToCss for ViewportPercentageLength {
impl ViewportPercentageLength {
/// Computes the given vi... | 1 | 10 | 12 |
7589de061937fdc19e616266ef135632cd0ecdcb | Fernando Jiménez Moreno | 2017-09-11T17:50:11 | servo: Merge #18444 - stylo: Fix error reporting for invalid values in property alias (from ferjm:bug1384221.alias.errors); r=jdm
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix [bug 1384221](https://bugzilla.mozilla.org/show_bug.cgi?id=138... | diff --git a/style/properties/declaration_block.rs b/style/properties/declaration_block.rs
index 0a158fcca..9d9a3a7b2 100644
--- a/style/properties/declaration_block.rs
+++ b/style/properties/declaration_block.rs
@@ -951,7 +951,8 @@ pub fn parse_one_declaration_into<R>(declarations: &mut SourcePropertyDeclaratio
l... | 4 | 15 | 13 |
c3119297c022026ed5c706c5884c0b8bf684a109 | Boris Zbarsky | 2017-09-11T15:33:24 | servo: Merge #18446 - Update rust-cssparser to 0.20.2 (from bzbarsky:update-cssparser); r=SimonSapin
This reduces memory consumption of list-valued properties in the common case of one entry in the list.
<!-- Please describe your changes on the following line: -->
---
<!-- Thank you for contributing to Servo! Please... | diff --git a/canvas/Cargo.toml b/canvas/Cargo.toml
index c6368dc78..6b35891e8 100644
--- a/canvas/Cargo.toml
+++ b/canvas/Cargo.toml
@@ -13,7 +13,7 @@ path = "lib.rs"
azure = {git = "https://github.com/servo/rust-azure"}
canvas_traits = {path = "../canvas_traits"}
compositing = {path = "../compositing"}
-cssparser =... | 7 | 7 | 7 |
e5fe98f83938a109f44e7ecab76462d1961ee7a5 | Matt Brubeck | 2017-09-11T13:57:07 | servo: Merge #18431 - Use SmallBitVec to optimize size of PropertyDeclarationBlock (from mbrubeck:pdb-size); r=SimonSapin
https://bugzilla.mozilla.org/show_bug.cgi?id=1398322
Source-Repo: https://github.com/servo/servo
Source-Revision: e7f45028dcd4d7015b4eed2ecc193e176b1fbd1c | diff --git a/script/dom/cssstyledeclaration.rs b/script/dom/cssstyledeclaration.rs
index cf03ff45d..5aea41c1b 100644
--- a/script/dom/cssstyledeclaration.rs
+++ b/script/dom/cssstyledeclaration.rs
@@ -410,10 +410,10 @@ impl CSSStyleDeclarationMethods for CSSStyleDeclaration {
// https://dev.w3.org/csswg/cssom/#the... | 10 | 133 | 116 |
5bdda3856d3532b76dd9b9f9e5092a49f392ee3a | tigercosmos | 2017-09-11T10:26:46 | servo: Merge #18372 - TEST: fix and add case of po-observe.any.js (from tigercosmos:userTimingApi); r=ferjm
<!-- Please describe your changes on the following line: -->
1. implementing step 3 from the [`PerformanceObserver.observe()`](https://w3c.github.io/performance-timeline/#dom-performanceobserver-observe()) metho... | diff --git a/script/dom/performance.rs b/script/dom/performance.rs
index 7cef2f280..7d2b053dd 100644
--- a/script/dom/performance.rs
+++ b/script/dom/performance.rs
@@ -163,7 +163,7 @@ impl Performance {
observer.set_entries(obs_entries);
}
let mut observers = self.observers.borrow_mut();... | 1 | 1 | 1 |
de4678d8ccccb8f891d115d81d846d7badb86ff7 | Fernando Jiménez Moreno | 2017-09-11T07:32:38 | servo: Merge #18206 - stylo: store specified value of grid layout repeat() function (from ferjm:bug1382369.grid.repeat.function); r=wafflespeanut
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix [Bug 1382369](https://bugzilla.mozilla.org/sho... | diff --git a/style/gecko/conversions.rs b/style/gecko/conversions.rs
index bd8c17f13..c00420e7b 100644
--- a/style/gecko/conversions.rs
+++ b/style/gecko/conversions.rs
@@ -20,7 +20,7 @@ use stylesheets::{Origin, RulesMutateError};
use values::computed::{Angle, CalcLengthOrPercentage, Gradient, Image};
use values::co... | 5 | 158 | 78 |
97a4b51703d52b4fa3caa6e9688e5dc4bb40c74a | Emilio Cobos Álvarez | 2017-09-10T17:30:39 | servo: Merge #18434 - Bug 1395064 - stylo: Add uses of fallible Vec, SmallVec and HashMap f… (from julian-seward1:master); r=bholley
…acilities. r=emilio@crisal.io.
<!-- Please describe your changes on the following line: -->
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the ... | diff --git a/fallible/Cargo.toml b/fallible/Cargo.toml
index b9425d39a..eae094d57 100644
--- a/fallible/Cargo.toml
+++ b/fallible/Cargo.toml
@@ -11,3 +11,15 @@ path = "lib.rs"
[dependencies]
smallvec = "0.4"
+hashglobe = { path = "../hashglobe" }
+
+# This crate effectively does nothing except if the `known_system_... | 9 | 153 | 64 |
6bc3a0d4e29be3c0ad40f76cbcc3abaa95c38cd9 | Boris Zbarsky | 2017-09-09T14:58:29 | servo: Merge #18430 - Shrink the storage needed by specified background images (from bzbarsky:shrink-background-storage); r=xidorn
<!-- Please describe your changes on the following line: -->
This makes a specified background image take 48 bytes instead of 1024 bytes.
---
<!-- Thank you for contributing to Servo! Ple... | diff --git a/style/gecko/conversions.rs b/style/gecko/conversions.rs
index ee13e6fff..bd8c17f13 100644
--- a/style/gecko/conversions.rs
+++ b/style/gecko/conversions.rs
@@ -151,8 +151,8 @@ impl nsStyleImage {
/// Set a given Servo `Image` value into this `nsStyleImage`.
pub fn set(&mut self, image: Image) {
... | 5 | 77 | 19 |
8709af83223ef9d42834a1321a347cde1a5db2f3 | Emilio Cobos Álvarez | 2017-09-09T12:56:35 | servo: Merge #18428 - style: remove selector_map::find_push (from emilio:find-push); r=nox
It has a single caller and is overly generic, which is going to make harder to
add fallible allocations to it.
Source-Repo: https://github.com/servo/servo
Source-Revision: 91b748ec22a952063c9e00870d4a788bc3799a18 | diff --git a/style/selector_map.rs b/style/selector_map.rs
index cd96aa736..79b3e3035 100644
--- a/style/selector_map.rs
+++ b/style/selector_map.rs
@@ -299,7 +299,10 @@ impl<T: SelectorMapEntry> SelectorMap<T> {
// rulehash lookup may produce superfluous selectors, but the
// subseque... | 1 | 4 | 10 |
fff587b2eedeb5a00add5494e80a43c94b791cd1 | Daniel Johnson | 2017-09-09T09:39:43 | servo: Merge #17083 - "javascript:" urls: execute in correct global scope (from danielj41:javascript-url-global-3); r=jdm
<!-- Please describe your changes on the following line: -->
#### Summary
This pull request makes `javascript:` urls execute in the correct global scope.
#### Example
```html
<script> var x = 4... | diff --git a/constellation/constellation.rs b/constellation/constellation.rs
index ae286fedd..4141e04d8 100644
--- a/constellation/constellation.rs
+++ b/constellation/constellation.rs
@@ -1067,6 +1067,10 @@ impl<Message, LTF, STF> Constellation<Message, LTF, STF>
debug!("constellation got URL load mes... | 5 | 127 | 47 |
67104f7405c7aeb68794b9625d1cdcb64e992211 | Hiroyuki Ikezoe | 2017-09-09T03:11:50 | servo: Merge #18426 - Transition shorthand fix (from hiikezoe:transition-shorthand); r=xidorn,boris
<!-- Please describe your changes on the following line: -->
https://bugzilla.mozilla.org/show_bug.cgi?id=1397122
---
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any erro... | diff --git a/style/properties/helpers/animated_properties.mako.rs b/style/properties/helpers/animated_properties.mako.rs
index 0bbadbf4c..759ba8ae0 100644
--- a/style/properties/helpers/animated_properties.mako.rs
+++ b/style/properties/helpers/animated_properties.mako.rs
@@ -247,21 +247,15 @@ impl TransitionProperty {... | 2 | 59 | 38 |
069bea44674e87bea757707b2f19801eacfb0e3b | Emilio Cobos Álvarez | 2017-09-09T02:09:58 | servo: Merge #18423 - More stale todos (from emilio:more-stale-todos); r=nox
Just removing or rewording stale stuff.
Source-Repo: https://github.com/servo/servo
Source-Revision: 8065eac0ebcadcdab0fd3649cf9e18c591d47ed6 | diff --git a/style/animation.rs b/style/animation.rs
index c2e3f33b7..e76c9b725 100644
--- a/style/animation.rs
+++ b/style/animation.rs
@@ -419,17 +419,15 @@ impl PropertyAnimation {
/// Inserts transitions into the queue of running animations as applicable for
/// the given style difference. This is called from the... | 3 | 14 | 19 |
15d48e5da9f75518668cdc9cb5347989b775ae29 | Emilio Cobos Álvarez | 2017-09-08T21:30:26 | servo: Merge #18422 - style: Remove stale todo about handling scrollbars in viewport units (from emilio:stale-todo); r=bholley
This is effectively not going to happen, per
https://github.com/w3c/csswg-drafts/issues/1766
Source-Repo: https://github.com/servo/servo
Source-Revision: 9c0abfea239077bc490ed8a2d4a7c32ba7829... | diff --git a/style/gecko/media_queries.rs b/style/gecko/media_queries.rs
index c1637b3c2..175b24eff 100644
--- a/style/gecko/media_queries.rs
+++ b/style/gecko/media_queries.rs
@@ -156,11 +156,8 @@ impl Device {
/// Returns the current viewport size in app units.
pub fn au_viewport_size(&self) -> Size2D<Au>... | 1 | 2 | 5 |
6709e828cfa22dbec98c8ac5c0913044e72b5043 | Manish Goregaokar | 2017-09-08T19:06:26 | servo: Merge #18413 - Bump app_units; use from_f64_au (from Manishearth:bump-au); r=jdm
Source-Repo: https://github.com/servo/servo
Source-Revision: 2b737355397f7716510107fa514016332ff0c1f2 | diff --git a/style/Cargo.toml b/style/Cargo.toml
index 6839dea0d..7c46a2c69 100644
--- a/style/Cargo.toml
+++ b/style/Cargo.toml
@@ -29,7 +29,7 @@ servo = ["serde", "heapsize", "heapsize_derive",
gecko_debug = ["nsstring_vendor/gecko_debug"]
[dependencies]
-app_units = "0.5.3"
+app_units = "0.5.5"
arrayvec = "0.3.... | 2 | 14 | 20 |
6b64514fb7f3922ca2c9c5e4a561345b6649b440 | P. Albrecht | 2017-09-08T18:04:26 | servo: Merge #18370 - An observer disconnected after a mark must receive the mark (from pylbrecht:observer); r=ferjm
<!-- Please describe your changes on the following line: -->
I worked on top of #18283 as suggested [here](https://github.com/servo/servo/issues/18284#issuecomment-326043873).
r? @ferjm
<!-- Thank you... | diff --git a/script/dom/performance.rs b/script/dom/performance.rs
index 8e85543f8..7cef2f280 100644
--- a/script/dom/performance.rs
+++ b/script/dom/performance.rs
@@ -182,6 +182,15 @@ impl Performance {
Some(p) => p,
None => return,
};
+
+ if self.pending_notification_observe... | 1 | 9 | 0 |
83b8e81a36b92c315f6cab0cd735c7869e0e0658 | Fernando Jiménez Moreno | 2017-09-08T16:14:51 | servo: Merge #18341 - stylo: Error reporting for unknown media features (from ferjm:bug1384225.media.errors); r=jdm
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix [bug 1384225](https://bugzilla.mozilla.org/show_bug.cgi?id=1384225)
Source-... | diff --git a/script/dom/cssmediarule.rs b/script/dom/cssmediarule.rs
index ff3c32939..dd921d9f7 100644
--- a/script/dom/cssmediarule.rs
+++ b/script/dom/cssmediarule.rs
@@ -72,13 +72,15 @@ impl CSSMediaRule {
let mut input = ParserInput::new(&text);
let mut input = Parser::new(&mut input);
le... | 10 | 171 | 107 |
a12c971eea5f7374d97dbdf595b84a22752bb1d1 | Anthony Ramine | 2017-09-08T11:01:22 | servo: Merge #18418 - Simplify some task-related code (from servo:tasks); r=emilio
Source-Repo: https://github.com/servo/servo
Source-Revision: 84ac9f384a0f32f5cc91a4df3983bff8e7c27e83 | diff --git a/script/script_thread.rs b/script/script_thread.rs
index a576af440..207e47572 100644
--- a/script/script_thread.rs
+++ b/script/script_thread.rs
@@ -114,12 +114,12 @@ use std::sync::mpsc::{Receiver, Select, Sender, channel};
use std::thread;
use style::context::ReflowGoal;
use style::thread_state;
-use t... | 3 | 47 | 65 |
348b4a1e40d7ac60824726b4ccf9e9cf0f5bfb5a | Emilio Cobos Álvarez | 2017-09-08T06:30:07 | servo: Merge #18417 - style: Stop the grid shorthand from resetting grid-gap properties (from emilio:grid-gap-shorthand); r=heycam
Bug: 1387410
Reviewed-by: heycam
MozReview-Commit-ID: GxU9YuAUc00
Source-Repo: https://github.com/servo/servo
Source-Revision: 44072163eb563187c6c1d60c9ad5c004bdf65a66 | diff --git a/style/properties/shorthand/position.mako.rs b/style/properties/shorthand/position.mako.rs
index e0b2b8f75..076a2b40e 100644
--- a/style/properties/shorthand/position.mako.rs
+++ b/style/properties/shorthand/position.mako.rs
@@ -448,8 +448,7 @@
<%helpers:shorthand name="grid"
sub_pro... | 1 | 2 | 14 |
4527794b312668bfc0f7d1bfaaa06ae77d43336b | Nicholas Nethercote | 2017-09-08T05:22:05 | servo: Merge #18404 - Measure PropertyDeclaration better (from nnethercote:measure-PropertyDeclaration); r=heycam
This increases the style-sheets counts for gmail by about 30 MiB.
<!-- Please describe your changes on the following line: -->
r? @heycam
---
<!-- Thank you for contributing to Servo! Please replace eac... | diff --git a/style/properties/properties.mako.rs b/style/properties/properties.mako.rs
index 756535365..1a02a02fa 100644
--- a/style/properties/properties.mako.rs
+++ b/style/properties/properties.mako.rs
@@ -38,7 +38,8 @@ use selectors::parser::SelectorParseError;
use shared_lock::StylesheetGuards;
use style_traits:... | 1 | 22 | 5 |
b068895423f7d920d7bf4cf024a3ade89507717d | Boris Chiou | 2017-09-08T02:34:28 | servo: Merge #18409 - Keep the unit of the serialization of specified::CalcLengthOrPercentage (from BorisChiou:stylo/calc/unit); r=emilio
For the serialization of specified values of calc(), we should keep the
units of absolute lengths, so use AbsoluteLength.
---
- [X] `./mach build -d` does not report any errors
- [... | diff --git a/style/values/computed/length.rs b/style/values/computed/length.rs
index 8c90d38ee..5878fde0f 100644
--- a/style/values/computed/length.rs
+++ b/style/values/computed/length.rs
@@ -223,7 +223,7 @@ impl specified::CalcLengthOrPercentage {
let mut length = Au(0);
if let Some(absolute) = se... | 3 | 61 | 14 |
f13b9d48b2c29e533feefa869bab41126fb92f7e | Anthony Ramine | 2017-09-07T20:56:01 | servo: Merge #18411 - Rename VirtualMethods::attribute_is_mapped (from servo:rename-preshint-method); r=emilio
Source-Repo: https://github.com/servo/servo
Source-Revision: e9336b39a6c24037f8dce1bbc85f437af5f439d7 | diff --git a/script/dom/document.rs b/script/dom/document.rs
index 9201b9a12..886e392de 100644
--- a/script/dom/document.rs
+++ b/script/dom/document.rs
@@ -2500,7 +2500,7 @@ impl Document {
entry.hint.insert(RESTYLE_STYLE_ATTRIBUTE);
}
- if vtable_for(el.upcast()).attribute_is_mapped(att... | 4 | 7 | 7 |
03f98e1b153f5ff5b45209a96c8ac20e5e9ea565 | Anthony Ramine | 2017-09-07T19:53:35 | servo: Merge #18407 - Kill Runnable::is_cancelled ⚔️ (from servo:kill-is-cancelled); r=emilio
Source-Repo: https://github.com/servo/servo
Source-Revision: 867a982fa71b26cec3788e1c825dd9addb9725f9 | diff --git a/script/script_thread.rs b/script/script_thread.rs
index cfd771599..a576af440 100644
--- a/script/script_thread.rs
+++ b/script/script_thread.rs
@@ -221,24 +221,35 @@ pub struct CancellableRunnable<T: Runnable + Send> {
inner: Box<T>,
}
-impl<T: Runnable + Send> Runnable for CancellableRunnable<T> {... | 3 | 21 | 19 |
2f2c4f943a19ecbf1d6cd50651a18ac047db75a9 | Bobby Holley | 2017-09-07T18:52:48 | servo: Merge #18412 - Increase stack safety margin for stylo (from bholley:bump_style_stacks); r=bholley
https://bugzilla.mozilla.org/show_bug.cgi?id=1395708
Source-Repo: https://github.com/servo/servo
Source-Revision: 8868d2223dbb28b07ae1936095bc9ec644fe58a7 | diff --git a/style/parallel.rs b/style/parallel.rs
index ffc02674b..d7604a6a5 100644
--- a/style/parallel.rs
+++ b/style/parallel.rs
@@ -32,23 +32,26 @@ use smallvec::SmallVec;
use traversal::{DomTraversal, PerLevelTraversalData};
/// The minimum stack size for a thread in the styling pool, in kilobytes.
-pub const... | 1 | 13 | 10 |
f2128dfa912dac518763cd817d2c45f0bfdece25 | Anthony Ramine | 2017-09-07T16:41:12 | servo: Merge #18406 - Start cleaning up HTMLMediaElement a bit (from servo:cleanup-media); r=emilio
Source-Repo: https://github.com/servo/servo
Source-Revision: 3a7539a442a1672cd370c3188faf7f7803005222 | diff --git a/script/dom/htmlmediaelement.rs b/script/dom/htmlmediaelement.rs
index 965599e93..497d60898 100644
--- a/script/dom/htmlmediaelement.rs
+++ b/script/dom/htmlmediaelement.rs
@@ -42,279 +42,134 @@ use std::sync::{Arc, Mutex};
use task_source::TaskSource;
use time::{self, Timespec, Duration};
-struct HTMLM... | 1 | 258 | 238 |
1492080e1a0475d10829e68d884ece3da778dba6 | P. Albrecht | 2017-09-07T15:24:16 | servo: Merge #18405 - Handle dynamic font color change (from pylbrecht:dynamic.attribute.change); r=emilio
<!-- Please describe your changes on the following line: -->
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [... | diff --git a/script/dom/document.rs b/script/dom/document.rs
index 06f5107e3..9201b9a12 100644
--- a/script/dom/document.rs
+++ b/script/dom/document.rs
@@ -88,6 +88,7 @@ use dom::touchevent::TouchEvent;
use dom::touchlist::TouchList;
use dom::treewalker::TreeWalker;
use dom::uievent::UIEvent;
+use dom::virtualmetho... | 4 | 31 | 4 |
6f6ba7279014bfa72a6331e46c2b38b48d764e5b | Emilio Cobos Álvarez | 2017-09-07T13:51:10 | servo: Merge #18408 - stylo: Don't add boundary characters to the fixups specified in ServoBindings.toml (from emilio:stylo-fixup-fix); r=upsuper
This allows adjusting the fixups for the patches in bug 1393230 when using
libclang 3.9.
Source-Repo: https://github.com/servo/servo
Source-Revision: 0c2abbd7eac17da99f9a7a... | diff --git a/style/build_gecko.rs b/style/build_gecko.rs
index de8daefd3..32ec46c13 100644
--- a/style/build_gecko.rs
+++ b/style/build_gecko.rs
@@ -292,7 +292,7 @@ mod bindings {
},
};
for fixup in fixups.iter() {
- result = Regex::new(&format!(r"\b{}\b", fixup.pat)).unwrap().... | 1 | 2 | 2 |
f80b7f5de5d749b5054557b03a2d4eb0dc7089f5 | Ryan VanderMeulen | 2017-09-07T13:33:53 | Backed out 3 changesets (bug 1393230) because it touches the servo directory.
Backed out changeset 9115364cd4aa (bug 1393230)
Backed out changeset f762f605dd83 (bug 1393230)
Backed out changeset c366bfc13e86 (bug 1393230) | diff --git a/style/build_gecko.rs b/style/build_gecko.rs
index 32ec46c13..de8daefd3 100644
--- a/style/build_gecko.rs
+++ b/style/build_gecko.rs
@@ -292,7 +292,7 @@ mod bindings {
},
};
for fixup in fixups.iter() {
- result = Regex::new(&fixup.pat).unwrap().replace_all(&result,... | 1 | 2 | 2 |
d14392483acd06169e5450de21a0350bedfce505 | Julian Seward | 2017-09-07T10:54:46 | servo: Merge #18397 - Add fallible append APIs for Vec and SmallVec (from julian-seward1:master); r=Manishearth
…r=manishearth.
<!-- Please describe your changes on the following line: -->
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` wit... | diff --git a/fallible/Cargo.toml b/fallible/Cargo.toml
new file mode 100644
index 000000000..b9425d39a
--- /dev/null
+++ b/fallible/Cargo.toml
@@ -0,0 +1,13 @@
+[package]
+name = "fallible"
+version = "0.0.1"
+authors = ["The Servo Project Developers"]
+license = "MPL-2.0"
+publish = false
+
+[lib]
+name = "fallible"
+... | 3 | 157 | 0 |
acea96336b7628cd70c39a94ecfb81e7198f5f82 | Nicholas Nethercote | 2017-09-07T06:35:02 | servo: Merge #18400 - Measure selectors (from nnethercote:measure-selectors); r=heycam
This patch adds measurement of Selectors within StyleRule. This requires
exposing the pointer within ThinArc.
The patch also adds measurement of the several CssRule variants, in order to
measure nested CssRules (and PropertyDeclara... | diff --git a/selectors/parser.rs b/selectors/parser.rs
index 45ff70df4..c17e8af1a 100644
--- a/selectors/parser.rs
+++ b/selectors/parser.rs
@@ -423,7 +423,6 @@ impl<Impl: SelectorImpl> Selector<Impl> {
))
}
-
/// Returns an iterator over this selector in matching order (right-to-left).
/// Wh... | 8 | 95 | 15 |
49376e6c9c745643454bb94bb47e72b2f9e4273f | Manish Goregaokar | 2017-09-07T06:18:47 | servo: Merge #18399 - stylo: Overflow fixes (from Manishearth:stylo-fuzzfix); r=emilio
r=emilio https://bugzilla.mozilla.org/show_bug.cgi?id=1397363 , https://bugzilla.mozilla.org/show_bug.cgi?id=1397439
Source-Repo: https://github.com/servo/servo
Source-Revision: 812cac78f0f4dba6063ba31d79b24667c5782b13
MozReview-Co... | diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs
index 1a35d2f41..e45fcb6a2 100644
--- a/style/properties/gecko.mako.rs
+++ b/style/properties/gecko.mako.rs
@@ -2341,7 +2341,7 @@ fn static_assert() {
pub fn calculate_script_level_size(&self, parent: &Self, device: &Device) -> (Au, Au) {... | 3 | 6 | 10 |
b5c91af1d001b2dbf241fbbf52d38a966dc37431 | Phil Ringnalda | 2017-09-07T04:08:39 | Backed out changeset 118a2b0b07c2 for assertion failures
MozReview-Commit-ID: 2pR2sdlejqW | diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs
index e45fcb6a2..1a35d2f41 100644
--- a/style/properties/gecko.mako.rs
+++ b/style/properties/gecko.mako.rs
@@ -2341,7 +2341,7 @@ fn static_assert() {
pub fn calculate_script_level_size(&self, parent: &Self, device: &Device) -> (Au, Au) {... | 3 | 10 | 6 |
a437171b325839718369fcf2986bf9eb4e54b45b | Manish Goregaokar | 2017-09-06T22:47:28 | servo: Merge #18399 - stylo: Overflow fixes (from Manishearth:stylo-fuzzfix); r=emilio
r=emilio https://bugzilla.mozilla.org/show_bug.cgi?id=1397363 , https://bugzilla.mozilla.org/show_bug.cgi?id=1397439
Source-Repo: https://github.com/servo/servo
Source-Revision: 812cac78f0f4dba6063ba31d79b24667c5782b13 | diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs
index 1a35d2f41..e45fcb6a2 100644
--- a/style/properties/gecko.mako.rs
+++ b/style/properties/gecko.mako.rs
@@ -2341,7 +2341,7 @@ fn static_assert() {
pub fn calculate_script_level_size(&self, parent: &Self, device: &Device) -> (Au, Au) {... | 3 | 6 | 10 |
f09c78d603e7fbb0bd5ee17bae508faee050740e | Nazım Can Altınova | 2017-09-06T21:40:33 | servo: Merge #18398 - stylo: Pass the @page values to precomputed pseudo element declarations (from canaltinova:at-page-rule); r=emilio
We were parsing @page rules correctly and serializing for cssom when we
we need. But we weren't actually including them to the pseudo element
declarations when we need to print a page... | diff --git a/style/stylist.rs b/style/stylist.rs
index c9211d826..29a0ae59a 100644
--- a/style/stylist.rs
+++ b/style/stylist.rs
@@ -21,7 +21,7 @@ use properties::{AnimationRules, PropertyDeclarationBlock};
#[cfg(feature = "servo")]
use properties::INHERIT_ALL;
use properties::IS_LINK;
-use rule_tree::{CascadeLevel,... | 1 | 82 | 13 |
3e178a7dac8ea1a06f2e4febcddec6abf28d5ff4 | Josh Matthews | 2017-09-06T20:33:20 | servo: Merge #18395 - Use a 1-element smallvec for selector lists (from jdm:selector-smallvec); r=SimonSapin
Profiling shows this reducing parsing time by a few milliseconds on the tp6 facebook case. The gtest benchmark with the same concatenated stylesheets also shows a significant improvement.
---
- [X] `./mach bui... | diff --git a/selectors/parser.rs b/selectors/parser.rs
index cb149e16e..45ff70df4 100644
--- a/selectors/parser.rs
+++ b/selectors/parser.rs
@@ -7,7 +7,7 @@ use attr::{ParsedCaseSensitivity, SELECTOR_WHITESPACE, NamespaceConstraint};
use bloom::BLOOM_HASH_MASK;
use builder::{SelectorBuilder, SpecificityAndFlags};
us... | 1 | 12 | 5 |
39e29c89b281eb0fca4b6231f43479733dee0aab | Josh Matthews | 2017-09-06T18:44:30 | servo: Merge #18396 - Reduce duplication in generated ServoComputedData::to_declaration_block (from jdm:codesize); r=emilio
This reduces the size of the code in libXUL by 23.4k according to bloaty.
---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
Source-Repo:... | diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs
index a4d941608..1a35d2f41 100644
--- a/style/properties/gecko.mako.rs
+++ b/style/properties/gecko.mako.rs
@@ -342,29 +342,27 @@ impl ComputedValuesInner {
pub fn is_multicol(&self) -> bool { false }
pub fn to_declaration_block(&s... | 1 | 12 | 14 |
68cb575c683d56ca44655be8dec36909e5d14b90 | Josh Matthews | 2017-09-06T17:18:41 | servo: Merge #18394 - Report more specific error for invalid filter properties (from jdm:filtererr); r=xidorn
Reviewed by xidorn in https://bugzilla.mozilla.org/show_bug.cgi?id=1386900.
---
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix [... | diff --git a/style/values/specified/effects.rs b/style/values/specified/effects.rs
index cd2482246..7b9ea0c7b 100644
--- a/style/values/specified/effects.rs
+++ b/style/values/specified/effects.rs
@@ -4,9 +4,9 @@
//! Specified types for CSS values related to effects.
-use cssparser::Parser;
+use cssparser::{Parser... | 2 | 18 | 4 |
ae157b041ebefe8c6b74963c0813378dbe18283d | Emilio Cobos Álvarez | 2017-09-06T08:28:56 | servo: Merge #18390 - style: Properly apply the display fixup for ::before and ::after (from emilio:display-fixup-proper); r=heycam
Bug: 1393861
Reviewed-by: heycam
Source-Repo: https://github.com/servo/servo
Source-Revision: f5e23a3a903a8142ff8993418142b0554f580c7d | diff --git a/style/gecko/wrapper.rs b/style/gecko/wrapper.rs
index 591657c4b..071013367 100644
--- a/style/gecko/wrapper.rs
+++ b/style/gecko/wrapper.rs
@@ -1166,14 +1166,15 @@ impl<'le> TElement for GeckoElement<'le> {
#[inline]
fn skip_root_and_item_based_display_fixup(&self) -> bool {
- // We don'... | 1 | 9 | 8 |
cba83a286ea04dc2dd540be9e49ea7d7046dc5ff | Nicholas Nethercote | 2017-09-06T06:39:35 | servo: Merge #18387 - Measure SmallVecs in SelectorMap and InvalidationMap (from nnethercote:measure-smallvec); r=heycam
<!-- Please describe your changes on the following line: -->
This is another ~300 KiB on the Obama wikipedia page.
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` ... | diff --git a/style/invalidation/element/invalidation_map.rs b/style/invalidation/element/invalidation_map.rs
index 4a1a092a2..58d612af1 100644
--- a/style/invalidation/element/invalidation_map.rs
+++ b/style/invalidation/element/invalidation_map.rs
@@ -15,7 +15,7 @@ use selectors::parser::{Selector, SelectorIter, Selec... | 4 | 50 | 13 |
31fdb16cefd862a92b445a8a38d8eb44640c3fd6 | Manish Goregaokar | 2017-09-06T05:32:53 | servo: Merge #18385 - Clean imports in hashglobe (from Manishearth:clean-imports); r=mbrubeck
Source-Repo: https://github.com/servo/servo
Source-Revision: f29fd7757396e8763753215b8e7d82cb437f8f5a | diff --git a/hashglobe/src/hash_map.rs b/hashglobe/src/hash_map.rs
index a8fc574eb..c73f88cef 100644
--- a/hashglobe/src/hash_map.rs
+++ b/hashglobe/src/hash_map.rs
@@ -11,14 +11,14 @@
use self::Entry::*;
use self::VacantEntryState::*;
-use borrow::Borrow;
-use cmp::max;
-use fmt::{self, Debug};
+use std::borrow::B... | 4 | 18 | 21 |
88f8b16c14250f0c8a5917a08db6f7307b7a2ca3 | Bobby Holley | 2017-09-06T04:20:55 | servo: Merge #18386 - Bypass the lock in get_property_value (from bholley:unchecked_cssom_get); r=upsuper
This measurably improves performance - see https://bugzilla.mozilla.org/show_bug.cgi?id=1355599#c21
Source-Repo: https://github.com/servo/servo
Source-Revision: e3568ba07abd74da560d38fc8074471e0c8394c6 | diff --git a/style/shared_lock.rs b/style/shared_lock.rs
index d536673e3..5d10a6f07 100644
--- a/style/shared_lock.rs
+++ b/style/shared_lock.rs
@@ -176,6 +176,13 @@ impl<T> Locked<T> {
}
}
+ /// Access the data for reading without verifying the lock. Use with caution.
+ #[cfg(feature = "gecko")]
... | 1 | 7 | 0 |
2dac8a267718f29a36a58a007414f9225edf0688 | KuoE0 | 2017-09-06T02:43:02 | servo: Merge #18376 - Support None and NotSet for the fallback type of SVGPaint (from kuoe0:set-fallbacktype-to-none-when-the-fallback-color-of-context-property-is-none); r=xidorn
<!-- Please describe your changes on the following line: -->
We didn't set None and NotSet for the fallback type of SVGPaint, and it cause... | diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs
index de1503ad5..a4d941608 100644
--- a/style/properties/gecko.mako.rs
+++ b/style/properties/gecko.mako.rs
@@ -60,7 +60,7 @@ use selector_parser::PseudoElement;
use servo_arc::{Arc, RawOffsetArc};
use std::mem::{forget, uninitialized, trans... | 2 | 32 | 15 |
f87e92ea08a61834e17977c39ad7e4a72489f1c0 | Imanol Fernandez | 2017-09-06T01:23:52 | servo: Merge #18383 - Fix WebGL texture_float and texture_half_float detection on some GPUs (from MortimerGoro:float_textures); r=emilio
<!-- Please describe your changes on the following line: -->
Fix WebGL texture_float and texture_half_float detection on some GPUs. Some of them use different extension names.
---
... | diff --git a/script/dom/webgl_extensions/ext/oestexturefloat.rs b/script/dom/webgl_extensions/ext/oestexturefloat.rs
index 7e5f5a56f..58983c46c 100644
--- a/script/dom/webgl_extensions/ext/oestexturefloat.rs
+++ b/script/dom/webgl_extensions/ext/oestexturefloat.rs
@@ -32,7 +32,8 @@ impl WebGLExtension for OESTextureFlo... | 2 | 4 | 2 |
ab42dedd5069796401e44af17af82b213b88d298 | Nazım Can Altınova | 2017-09-05T23:35:55 | servo: Merge #18373 - Don't unnecessarily construct gfxFontFeatureValueSet (from canaltinova:font-feature-vals); r=xidorn
This is reviewed by xidorn in bugzilla.
---
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix [Bug 1394551](https://bug... | diff --git a/style/gecko/generated/bindings.rs b/style/gecko/generated/bindings.rs
index a200d993e..1b1ad6a62 100644
--- a/style/gecko/generated/bindings.rs
+++ b/style/gecko/generated/bindings.rs
@@ -913,6 +913,10 @@ extern "C" {
extern "C" {
pub fn Gecko_nsFont_Destroy(dst: *mut nsFont);
}
+extern "C" {
+ p... | 2 | 7 | 5 |
8d89c91b088f747e7d0adba1bb90ba1b7eaa7341 | Martin Robinson | 2017-09-05T20:36:47 | servo: Merge #18212 - Add support for position:sticky (from mrobinson:position-sticky); r=emilio
This leverages the position:sticky support in WebRender to bring basic
support for position:sticky in Servo. There are still some issues with
nested sticky flows as well as a few other corner cases. Tests are
imported from... | diff --git a/gfx/display_list/mod.rs b/gfx/display_list/mod.rs
index 718c44487..99a99a47b 100644
--- a/gfx/display_list/mod.rs
+++ b/gfx/display_list/mod.rs
@@ -34,7 +34,8 @@ use style_traits::cursor::Cursor;
use text::TextRun;
use text::glyph::ByteIndex;
use webrender_api::{self, ClipAndScrollInfo, ClipId, ColorF, ... | 14 | 180 | 50 |
9c2c5088665d23ea488b1e9f46afa7a373c666ab | Wei-Cheng Pan | 2017-09-05T19:18:52 | servo: Merge #18271 - Propagate dirty bits after invalidation if needed (from legnaleurc:propagate_dirty_bits); r=emilio
<!-- Please describe your changes on the following line: -->
Follow up for [bug 1388298](https://bugzil.la/1388298).
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]... | diff --git a/style/data.rs b/style/data.rs
index 7d9a8ba67..471b279ab 100644
--- a/style/data.rs
+++ b/style/data.rs
@@ -6,6 +6,7 @@
use context::{SharedStyleContext, StackLimitChecker};
use dom::TElement;
+use invalidation::element::invalidator::InvalidationResult;
use invalidation::element::restyle_hints::Restyl... | 2 | 61 | 19 |
1a087b843a64ca8f93327175ec9b31793d2147f1 | Emilio Cobos Álvarez | 2017-09-05T17:51:17 | servo: Merge #18384 - style: Don't waste a whole selector map for each class / id in the document (from emilio:invalidation-map-bloat); r=bholley
On top of #18375, only last commit needs review.
Source-Repo: https://github.com/servo/servo
Source-Revision: 4721ef81fd7fb6ee15546a6abe140a66ce0280e8 | diff --git a/style/gecko/data.rs b/style/gecko/data.rs
index 67bbcc26a..7bc5e5938 100644
--- a/style/gecko/data.rs
+++ b/style/gecko/data.rs
@@ -16,7 +16,8 @@ use media_queries::{Device, MediaList};
use properties::ComputedValues;
use servo_arc::Arc;
use shared_lock::{Locked, StylesheetGuards, SharedRwLockReadGuard}... | 14 | 374 | 43 |
9611523a0bcf1a2b0cf45a3d5d9f203316dd02c1 | Jeremy Chen | 2017-09-05T16:22:20 | servo: Merge #18365 - stylo: Store location information for keyframe rules (from chenpighead:stylo-keyframe-location); r=upsuper,emilio
So far, we only store location info for the whole Keyframes block, not for each
of the keyframe rule. Without this info, the devtool can't present the rules
on the devtool panel prope... | diff --git a/style/gecko/generated/bindings.rs b/style/gecko/generated/bindings.rs
index d39be9eee..34960eb76 100644
--- a/style/gecko/generated/bindings.rs
+++ b/style/gecko/generated/bindings.rs
@@ -2342,9 +2342,10 @@ extern "C" {
-> u32;
}
extern "C" {
- pub fn Servo_KeyframesRule_GetKeyframe(rule:
- ... | 3 | 26 | 8 |
f332b60f3164173f960de8cd05411058bc53210b | Paul Rouget | 2017-09-05T14:22:28 | servo: Merge #18363 - use cargo manifest path to find build.py (from paulrouget:fix_style_build); r=SimonSapin
Without this, build.py can't be found when servo is built as a dependency.
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with ap... | diff --git a/style/build.rs b/style/build.rs
index 9a3d0169c..607f895c2 100644
--- a/style/build.rs
+++ b/style/build.rs
@@ -69,7 +69,8 @@ fn generate_properties() {
}
}
- let script = Path::new(file!()).parent().unwrap().join("properties").join("build.py");
+ let script = Path::new(&env::var("CAR... | 1 | 2 | 1 |
0cfba6cbbc8d076aeb8abdfa92cb74526fcb7aed | Daisuke Akatsuka | 2017-09-05T11:20:33 | servo: Merge #18380 - Make font-variation-settings animatable (from dadaa:make-font-variation-settings-animatable); r=birtles
<!-- Please describe your changes on the following line: -->
https://bugzilla.mozilla.org/show_bug.cgi?id=1390702 r=birtles
---
<!-- Thank you for contributing to Servo! Please replace each `[... | diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs
index 3eae30f6f..de1503ad5 100644
--- a/style/properties/gecko.mako.rs
+++ b/style/properties/gecko.mako.rs
@@ -5,7 +5,7 @@
// `data` comes from components/style/properties.mako.rs; see build.rs for more details.
<%!
- from data import ... | 4 | 243 | 94 |
b04be1be531cb4cc189f5e6cde71e8fe287b2006 | Simon Sapin | 2017-09-04T18:14:44 | servo: Merge #18355 - Reduce usage of fmt in serialization and error reporting (from servo:no-fmt); r=emilio
`format!` and `write!` create a somewhat-heavyweight `Formatting` struct and use dynamic dispatch to call into impls of `Dispaly` and related traits. The former also allocates an intermediate string that is som... | diff --git a/script_layout_interface/reporter.rs b/script_layout_interface/reporter.rs
index ac5706f51..7f5acfef8 100644
--- a/script_layout_interface/reporter.rs
+++ b/script_layout_interface/reporter.rs
@@ -31,7 +31,7 @@ impl ParseErrorReporter for CSSErrorReporter {
url.as_str(),
... | 18 | 290 | 190 |
4e7c163f6af3d9fce9694bed56fe18a7a0eb8d9a | Emilio Cobos Álvarez | 2017-09-04T16:54:15 | servo: Merge #18366 - style: Avoid dropping the other threads' TLS contexts too early (from emilio:fix-statistics-crash); r=bholley
When collecting style statistics, we have this path that moves the TLS contexts
to be dropped before the local context.
Since destroying the TLS context runs the sequential task queue, t... | diff --git a/style/driver.rs b/style/driver.rs
index 568338c00..c6370d012 100644
--- a/style/driver.rs
+++ b/style/driver.rs
@@ -13,7 +13,6 @@ use parallel;
use parallel::{DispatchMode, WORK_UNIT_MAX};
use rayon;
use scoped_tls::ScopedTLS;
-use std::borrow::Borrow;
use std::collections::VecDeque;
use std::mem;
us... | 1 | 2 | 3 |
d4a53f612e06d839d4cf33f44bd55191b590172e | Emilio Cobos Álvarez | 2017-09-04T10:01:39 | servo: Merge #18359 - style: Move color to use predefined_type (from emilio:bye-color-mako); r=nox
I want to play with autogenerating style structs, and color is the smallest
struct out there.
However, moving it out of the mako file is a requirement. This patch does that.
Source-Repo: https://github.com/servo/servo
... | diff --git a/style/properties/longhand/color.mako.rs b/style/properties/longhand/color.mako.rs
index a2c2c61a3..620d2a11b 100644
--- a/style/properties/longhand/color.mako.rs
+++ b/style/properties/longhand/color.mako.rs
@@ -8,134 +8,107 @@
<% from data import to_rust_ident %>
-<%helpers:longhand name="color" need... | 5 | 125 | 120 |
7ecbb908ee6721c0e758947e94cb0ae71de4b76f | Mantaroh Yoshinaga | 2017-09-04T08:02:08 | servo: Merge #18364 - Don't allow interpolating SVGPaintKind::None (from mantaroh:svgpaintkind-interpolation); r=birtles
This is a PR for https://bugzilla.mozilla.org/show_bug.cgi?id=1396483
PR #18103 disallowed interpolation between fill:none and fill:none, but that change was regressed by the refactoring in PR #182... | diff --git a/style/values/generics/svg.rs b/style/values/generics/svg.rs
index 9b0f19ae4..2d743100d 100644
--- a/style/values/generics/svg.rs
+++ b/style/values/generics/svg.rs
@@ -35,6 +35,7 @@ pub struct SVGPaint<ColorType, UrlPaintServer> {
#[derive(ToAnimatedValue, ToAnimatedZero, ToComputedValue, ToCss)]
pub enu... | 1 | 1 | 0 |
7c282bb4b9ccefc6a4c5969e3425c7a2a9e539c4 | toidiu | 2017-09-03T21:28:25 | servo: Merge #18361 - change function signature to get type name via intrinsics (from toidiu:ak-18354); r=emilio
<!-- Please describe your changes on the following line: -->
change function signature to get type name via intrinsics
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when ... | diff --git a/script/dom/document.rs b/script/dom/document.rs
index 8898c5d08..4097f6b64 100644
--- a/script/dom/document.rs
+++ b/script/dom/document.rs
@@ -4015,8 +4015,6 @@ impl DocumentProgressHandler {
}
impl Runnable for DocumentProgressHandler {
- fn name(&self) -> &'static str { "DocumentProgressHandler" ... | 13 | 2 | 45 |
57e7578882cfb189b97201e460b850aa04ad563b | Anthony Ramine | 2017-09-03T18:05:00 | servo: Merge #18358 - Properly change the kind of the given attribute in SetAttributeNode (from servo:change-attr-kind); r=emilio
Fixes #18357.
Source-Repo: https://github.com/servo/servo
Source-Revision: 096912101b2ea8702a0337aae092241b930d6b5d | diff --git a/script/dom/element.rs b/script/dom/element.rs
index 11df4f6bd..6896d25b9 100644
--- a/script/dom/element.rs
+++ b/script/dom/element.rs
@@ -1649,10 +1649,6 @@ impl ElementMethods for Element {
// https://dom.spec.whatwg.org/#dom-element-setattributenode
fn SetAttributeNode(&self, attr: &Attr) -... | 1 | 10 | 5 |
fe69b1d7605727dbeb9d8199fbbb15d14fb6e959 | Nazım Can Altınova | 2017-09-02T14:37:11 | servo: Merge #18349 - stylo: Remove calc support from media queries (from canaltinova:media-calc); r=emilio
Gecko currently doesn't support calc inside media queries. We should
also remove the calc support temporarily for parity with gecko. We can
add this support back in next releases.
Reviewed by emilio in Bugzilla... | diff --git a/style/gecko/media_queries.rs b/style/gecko/media_queries.rs
index 839357526..2ddc73ebd 100644
--- a/style/gecko/media_queries.rs
+++ b/style/gecko/media_queries.rs
@@ -32,8 +32,9 @@ use string_cache::Atom;
use style_traits::{CSSPixel, DevicePixel};
use style_traits::{ToCss, ParseError, StyleParseError};
... | 1 | 16 | 5 |
d0d0805613199abdb2637faa2f00f60a51941920 | Mateusz Naściszewski | 2017-09-02T08:54:49 | servo: Merge #18351 - Refactor `.sort_by()` calls to use `.partial_cmp()` (from mateon1:profile-sort_by-partial_cmp); r=emilio
Changes the closures passed to `sort_by` in this file with a simpler, and more correct version.
Previously, potential NaNs in the array would float to the top. Either way, the program would c... | diff --git a/profile/time.rs b/profile/time.rs
index 2eb48f57a..9aa952cdb 100644
--- a/profile/time.rs
+++ b/profile/time.rs
@@ -355,13 +355,7 @@ impl Profiler {
write!(file, "_category_\t_incremental?_\t_iframe?_\t_url_\t_mean (ms)_\t\
_median (ms)_\t_min (ms)_\t_max (ms)_\t_event... | 1 | 3 | 21 |
176c28f402e5e13d9e8d469225fc223325f1e7b7 | Emilio Cobos Álvarez | 2017-09-02T07:49:29 | servo: Merge #18350 - stylo: Expose -moz-system-metric and -moz-empty-except-children-with-localname (from emilio:ship-system-metric-stuff); r=bholley,manishearth
They don't have the flag in Gecko.
Though I wonder if we could unship them from non-UA sheets.
Bug: 1396048
Reviewed-by: bholley
MozReview-Commit-ID: LGzG... | diff --git a/style/gecko/non_ts_pseudo_class_list.rs b/style/gecko/non_ts_pseudo_class_list.rs
index 17dce94c9..938cbf3cf 100644
--- a/style/gecko/non_ts_pseudo_class_list.rs
+++ b/style/gecko/non_ts_pseudo_class_list.rs
@@ -59,7 +59,9 @@ macro_rules! apply_non_ts_list {
("-moz-drag-over", MozDragOver,... | 1 | 6 | 2 |
491ce334926ee80414f2e7191a3e3b8768cb65e6 | Anthony Ramine | 2017-09-02T05:48:29 | servo: Merge #18340 - Use the better TokenStream API in dom_struct (from servo:dom-struct-errors); r=SimonSapin
Before:
```rust
error[E0412]: cannot find type `SourceBuffer` in this scope
--> /Users/nox/src/servo/components/script/dom/mediasource.rs:25:1
|
25 | #[dom_struct]
| ^^^^^^^^^^^^^ did you mean `Sour... | diff --git a/dom_struct/Cargo.toml b/dom_struct/Cargo.toml
index 4f3593db6..7a76375ac 100644
--- a/dom_struct/Cargo.toml
+++ b/dom_struct/Cargo.toml
@@ -8,6 +8,3 @@ publish = false
[lib]
path = "lib.rs"
proc-macro = true
-
-[dependencies]
-quote = "0.3.15"
diff --git a/dom_struct/lib.rs b/dom_struct/lib.rs
index f74... | 2 | 5 | 13 |
860e7e30e67320cf29db484d7394f92b84035f90 | Brad Werth | 2017-09-02T04:41:10 | servo: Merge #18344 - Change selector::to_css function to handle combinators in between universal selectors (from bradwerth:selectorSerialize); r=SimonSapin
https://bugzilla.mozilla.org/show_bug.cgi?id=1391169
https://reviewboard.mozilla.org/r/172368/
---
<!-- Thank you for contributing to Servo! Please replace each ... | diff --git a/selectors/parser.rs b/selectors/parser.rs
index 8cacbe6f3..cb149e16e 100644
--- a/selectors/parser.rs
+++ b/selectors/parser.rs
@@ -787,8 +787,8 @@ impl<Impl: SelectorImpl> ToCss for Selector<Impl> {
// something like `... > ::before`, because we store `>` and `::`
// both... | 1 | 16 | 12 |
676075927e8a7fd37b7a1447f5342def0be7447f | Glenn Watson | 2017-09-02T02:42:28 | servo: Merge #18339 - Update WR (mac driver crash, box shadow sharing) (from glennw:update-wr-misc); r=jdm
* Works around a driver / kernel crash on some mac machines.
* Allow more sharing of box shadow and clip render tasks.
* Some shader tidy ups.
Source-Repo: https://github.com/servo/servo
Source-Revision: 7e3c8de... | diff --git a/compositing/compositor.rs b/compositing/compositor.rs
index c7d18be53..11cff035a 100644
--- a/compositing/compositor.rs
+++ b/compositing/compositor.rs
@@ -1285,7 +1285,8 @@ impl<Window: WindowMethods> IOCompositor<Window> {
debug!("compositor: compositing");
// Paint the scene.... | 1 | 2 | 1 |
6e269f22271c75cb0bbf145b688563a510a97d50 | Manish Goregaokar | 2017-09-02T00:17:03 | servo: Merge #18335 - stylo: Compute font-size calcs against appropriate base size (from Manishearth:stylo-calc-anim); r=birtles
r=birtles https://bugzilla.mozilla.org/show_bug.cgi?id=1394302
Source-Repo: https://github.com/servo/servo
Source-Revision: 60daf543524e6c5e6dfb5e309ceae638425f010d | diff --git a/style/properties/longhand/font.mako.rs b/style/properties/longhand/font.mako.rs
index 5d849c746..c95ea97c2 100644
--- a/style/properties/longhand/font.mako.rs
+++ b/style/properties/longhand/font.mako.rs
@@ -859,7 +859,7 @@ ${helpers.single_keyword_system("font-variant-caps",
base_size... | 4 | 10 | 7 |
a7ede7e91dcfe8d82b48d98b8cfc201d4a43672c | Xidorn Quan | 2017-09-01T22:56:57 | servo: Merge #18336 - Parse at-rule without block in two stages (from upsuper:two-stage-at-rule); r=SimonSapin
This is the Servo side change necessary for servo/rust-cssparser#180.
----
This also pulls in other changes from cssparser 0.20.0.
Source-Repo: https://github.com/servo/servo
Source-Revision: f2e5b4992658d... | diff --git a/canvas/Cargo.toml b/canvas/Cargo.toml
index 83d91f93b..c6368dc78 100644
--- a/canvas/Cargo.toml
+++ b/canvas/Cargo.toml
@@ -13,7 +13,7 @@ path = "lib.rs"
azure = {git = "https://github.com/servo/rust-azure"}
canvas_traits = {path = "../canvas_traits"}
compositing = {path = "../compositing"}
-cssparser =... | 14 | 115 | 89 |
e758db8c2881b5969798a57547b7e8743ee4dcc4 | Mateusz Naściszewski | 2017-09-01T20:04:56 | servo: Merge #18272 - Correct "is sorted" check in profile statistics (from mateon1:fix/profile-sorted-assert); r=emilio
<!-- Please describe your changes on the following line: -->
Correct the debug_assert check for whether or not statistics collected by the --profile flag are sorted.
I'm not sure how I could add a t... | diff --git a/profile/time.rs b/profile/time.rs
index 16495b63d..2eb48f57a 100644
--- a/profile/time.rs
+++ b/profile/time.rs
@@ -328,7 +328,7 @@ impl Profiler {
/// Get tuple (mean, median, min, max) for profiler statistics.
pub fn get_statistics(data: &[f64]) -> (f64, f64, f64, f64) {
data.iter().fo... | 1 | 1 | 1 |
ef3f16647f1b6dde32426a63537c41f783c2844e | Simon Sapin | 2017-09-01T18:54:08 | servo: Merge #18327 - Upgrade to rustc 1.21.0-nightly (7eeac1b81 2017-08-30) (from servo:rustup); r=nox
Fix this error in the new Rust Nightly:
```rust
Compiling script v0.0.1 (file:///home/simon/servo2/components/script)
error[E0599]: no method named `trace` found for type `&fn(&dom::node::Node) -> u16` in the cu... | diff --git a/script/dom/bindings/trace.rs b/script/dom/bindings/trace.rs
index df681e3ad..b566e972e 100644
--- a/script/dom/bindings/trace.rs
+++ b/script/dom/bindings/trace.rs
@@ -425,6 +425,13 @@ unsafe impl<A, B> JSTraceable for fn(A) -> B {
}
}
+unsafe impl<'a, A, B> JSTraceable for fn(&A) -> B {
+ #[inl... | 2 | 8 | 1 |
556cd5896615abd585ab80ca1cea84c4ab7a5b49 | Henri Sivonen | 2017-09-01T17:25:54 | servo: Merge #18347 - Take a `u8` pointer and a length instead of `nsACString` pointer from Gecko (from hsivonen:ptr-and-length-from-gecko); r=SimonSapin
This is the Servo side change of [bug 1354989](https://bugzilla.mozilla.org/show_bug.cgi?id=1354989).
- [ ] `./mach build -d` does not report any errors
Fails for ... | diff --git a/style/gecko/generated/bindings.rs b/style/gecko/generated/bindings.rs
index 397000c2b..007fa274f 100644
--- a/style/gecko/generated/bindings.rs
+++ b/style/gecko/generated/bindings.rs
@@ -1930,7 +1930,8 @@ extern "C" {
pub fn Servo_StyleSheet_FromUTF8Bytes(loader: *mut Loader,
... | 1 | 2 | 1 |
53ac7a946c635bcb2f04bf226847afa971bd526a | Emilio Cobos Álvarez | 2017-09-01T13:56:58 | servo: Merge #18342 - style: Remove the for reconstruction traversals (from emilio:die-forreconstruct-die); r=bholley
One less hack, a few more to go.
Bug: 1374235
Reviewed-by: bholley
MozReview-Commit-ID: 6katL1EGn2U
Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>
Source-Repo: https://github.com/servo/servo
... | diff --git a/style/traversal.rs b/style/traversal.rs
index 23f8cc50f..0fac4d221 100644
--- a/style/traversal.rs
+++ b/style/traversal.rs
@@ -290,13 +290,7 @@ pub trait DomTraversal<E: TElement> : Sync {
// Servo uses the post-order traversal for flow construction, so we need
// to traverse any element... | 2 | 1 | 11 |
4bb9adf31412ae3b956528162e4e5b4b4703d8eb | Anthony Ramine | 2017-09-01T10:51:00 | servo: Merge #18314 - Use absolute paths in the event handlers macros (from servo:macro-imports); r=emilio
Source-Repo: https://github.com/servo/servo
Source-Revision: 15c57e8d54f7aae99a42644333060aabaee1c989 | diff --git a/script/dom/bluetooth.rs b/script/dom/bluetooth.rs
index 846b1ff66..adac22b60 100644
--- a/script/dom/bluetooth.rs
+++ b/script/dom/bluetooth.rs
@@ -14,7 +14,6 @@ use dom::bindings::codegen::Bindings::BluetoothBinding::{BluetoothMethods, Reque
use dom::bindings::codegen::Bindings::BluetoothPermissionResult... | 22 | 35 | 36 |
4251692b63d9aa1547976ca7a0ca12110720fe05 | KuoE0 | 2017-09-01T09:15:21 | servo: Merge #18337 - Make the order of rules in DevTools be the specificity order (from kuoe0:make-the-order-of-rules-in-DevTools-be-the-specificity-order); r=emilio
We insert rules with any important declaration into rule tree twice,
one for the normal level and another for the important level. And
when we fetch the... | diff --git a/style/rule_tree/mod.rs b/style/rule_tree/mod.rs
index 7e76d3b34..09f18ddbc 100644
--- a/style/rule_tree/mod.rs
+++ b/style/rule_tree/mod.rs
@@ -199,10 +199,11 @@ impl RuleTree {
for (source, level) in iter {
debug_assert!(last_level <= level, "Not really ordered");
debug_... | 1 | 22 | 15 |
5866288275f3788e6323f32787d09a9e23850d8d | Imanol Fernandez | 2017-09-01T06:22:38 | servo: Merge #18332 - Reuse WebGL ImageKeys after a resize (from MortimerGoro:webgl_reuse_image); r=glennw
<!-- Please describe your changes on the following line: -->
WebRender does now support resizing with the same image key
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the... | diff --git a/canvas/webgl_thread.rs b/canvas/webgl_thread.rs
index ef4ccd579..b6e7959ef 100644
--- a/canvas/webgl_thread.rs
+++ b/canvas/webgl_thread.rs
@@ -8,7 +8,6 @@ use euclid::Size2D;
use fnv::FnvHashMap;
use gleam::gl;
use offscreen_gl_context::{GLContext, GLContextAttributes, GLLimits, NativeGLContextMethods}... | 2 | 43 | 41 |
d65c443e2e22e693cc1930566620ce7384e0ca25 | Nazım Can Altınova | 2017-09-01T04:18:23 | servo: Merge #18321 - Properly set default direction of prefixed linear gradients (from canaltinova:default-linear-gradient); r=Manishearth
The default linear gradient direction is `to bottom`. This correspondes to
`top` keyword in prefixed linear gradients. We should preserve the default value.
---
<!-- Thank you fo... | diff --git a/style/values/computed/image.rs b/style/values/computed/image.rs
index 952e213cc..998216837 100644
--- a/style/values/computed/image.rs
+++ b/style/values/computed/image.rs
@@ -78,10 +78,13 @@ pub type ColorStop = GenericColorStop<RGBA, LengthOrPercentage>;
pub type MozImageRect = GenericMozImageRect<Numbe... | 3 | 17 | 7 |
175dac4ffa54cbbe603570c7b77c2d2409ecdb64 | Glenn Watson | 2017-09-01T02:59:30 | servo: Merge #18322 - Update WR (font instance API) (from glennw:update-wr-fonts-2); r=emilio
WR now has a concept of font templates and font instances. This
makes the WR font interfaces closer to Cairo and Gecko, and also
makes some future performance optimizations possible.
A font template is the font family, and d... | diff --git a/gfx/font.rs b/gfx/font.rs
index a7751e879..9c59f71fb 100644
--- a/gfx/font.rs
+++ b/gfx/font.rs
@@ -112,7 +112,7 @@ pub struct Font {
shaper: Option<Shaper>,
shape_cache: RefCell<HashMap<ShapeCacheEntry, Arc<GlyphStore>>>,
glyph_advance_cache: RefCell<HashMap<u32, FractionalPixel>>,
- pub... | 6 | 65 | 32 |
f53f3e9bc5d534a0041b0280d2428543b462ce23 | Emilio Cobos Álvarez | 2017-08-31T19:14:15 | servo: Merge #18330 - stylo: Add a special case for marking something as dirty from invalidation code (from emilio:invalidation-stuff); r=bholley
Source-Repo: https://github.com/servo/servo
Source-Revision: 09df9c4316779899c7820cac56ecd18793f1f4a3 | diff --git a/style/gecko/generated/bindings.rs b/style/gecko/generated/bindings.rs
index 16e4b98fb..397000c2b 100644
--- a/style/gecko/generated/bindings.rs
+++ b/style/gecko/generated/bindings.rs
@@ -1068,6 +1068,10 @@ extern "C" {
extern "C" {
pub fn Gecko_NoteDirtyElement(element: RawGeckoElementBorrowed);
}
... | 1 | 4 | 0 |
8f98dc2809737efa5b786547fdb5b278209f3e92 | Anthony Ramine | 2017-08-31T14:41:50 | servo: Merge #18301 - Use generics for the vertical-align property (from servo:derive-all-the-things); r=emilio
Source-Repo: https://github.com/servo/servo
Source-Revision: 174c37fddd3ba66797efdb8067c24003f32c04a7 | diff --git a/layout/fragment.rs b/layout/fragment.rs
index 44dc9b873..cef3eff63 100644
--- a/layout/fragment.rs
+++ b/layout/fragment.rs
@@ -42,7 +42,7 @@ use std::collections::LinkedList;
use std::sync::{Arc, Mutex};
use style::computed_values::{border_collapse, box_sizing, clear, color, display, mix_blend_mode};
u... | 13 | 202 | 178 |
dc02754bea3673fc81023087a365e243aac09f32 | Jeremy Chen | 2017-08-31T08:10:23 | servo: Merge #18319 - Do not skip parent display-based style fixups for NAC that is not a NAC root (from chenpighead:stylo-fixup-display-for-NAC); r=heycam
Stylo is currently skipping parent display-based style fixups for all NAC,
whereas we probably only want to do this for NAC roots.
In this patch, we ensure that w... | diff --git a/style/gecko/wrapper.rs b/style/gecko/wrapper.rs
index 7883d9dd8..de534fe6d 100644
--- a/style/gecko/wrapper.rs
+++ b/style/gecko/wrapper.rs
@@ -1171,7 +1171,9 @@ impl<'le> TElement for GeckoElement<'le> {
// level native anonymous content subtree roots, since they're not
// really roots f... | 1 | 3 | 1 |
e27068abcb948cbd2564b7f1cf8841a43eace243 | Nicholas Nethercote | 2017-08-31T05:31:31 | servo: Merge #18310 - Measure memory usage of Stylo's Rule Tree (from nnethercote:bug-1394729); r=heycam
<!-- Please describe your changes on the following line: -->
This is for https://bugzilla.mozilla.org/show_bug.cgi?id=1394729, which was r=heycam.
---
<!-- Thank you for contributing to Servo! Please replace each ... | diff --git a/style/gecko/data.rs b/style/gecko/data.rs
index 7c1bb6f68..67bbcc26a 100644
--- a/style/gecko/data.rs
+++ b/style/gecko/data.rs
@@ -7,8 +7,8 @@
use atomic_refcell::{AtomicRef, AtomicRefCell, AtomicRefMut};
use dom::TElement;
use gecko_bindings::bindings::{self, RawServoStyleSet};
-use gecko_bindings::st... | 6 | 110 | 7 |
f643ab606ec25ac0c9f22ccbbd4386c94229b9ed | Mantaroh Yoshinaga | 2017-08-31T04:21:49 | servo: Merge #18210 - Skip adding/accumulating ClipRect values which corresponding rect offset is auto (from mantaroh:clip-interpolation-fix); r=nox
<!-- Please describe your changes on the following line: -->
This is a PR for https://bugzilla.mozilla.org/show_bug.cgi?id=1390352
This patch will skip adding/accumulati... | diff --git a/style/properties/helpers/animated_properties.mako.rs b/style/properties/helpers/animated_properties.mako.rs
index 25cc6b47e..8358b1e2d 100644
--- a/style/properties/helpers/animated_properties.mako.rs
+++ b/style/properties/helpers/animated_properties.mako.rs
@@ -924,6 +924,27 @@ impl Into<FontStretch> for... | 2 | 22 | 1 |
8b6756f51aa6fe0a145914743dfd78a44e858b2a | Imanol Fernandez | 2017-08-31T03:08:31 | servo: Merge #18316 - Update rust-webvr to 0.8 (from MortimerGoro:rust_webvr_0.8); r=jdm
<!-- Please describe your changes on the following line: -->
The new rust-webvr version includes features like multiview, opaque framebuffers and multiple layer rendering support that will land in separate PRs.
It also splits ru... | diff --git a/script/Cargo.toml b/script/Cargo.toml
index 60f723055..cc9b8efd3 100644
--- a/script/Cargo.toml
+++ b/script/Cargo.toml
@@ -91,7 +91,6 @@ utf-8 = "0.7"
uuid = {version = "0.5", features = ["v4"]}
xml5ever = {version = "0.9"}
webrender_api = {git = "https://github.com/servo/webrender", features = ["ipc"]... | 6 | 7 | 4 |
ff2c6eee6105847b9d11d1207a17f6ecafcd29d6 | Boris Chiou | 2017-08-30T11:03:32 | servo: Merge #18234 - stylo: Bug 1390039 - Implement compute_distance for mismatched transform lists (from BorisChiou:stylo/transform/distance_mismatch); r=birtles,nox
Implement ComputeSquaredDistance for mismatched transform lists.
In order to do this, we have to convert a transform list into a 3d matrix,
so I move t... | diff --git a/layout/fragment.rs b/layout/fragment.rs
index df0bca4cc..44dc9b873 100644
--- a/layout/fragment.rs
+++ b/layout/fragment.rs
@@ -10,7 +10,7 @@ use ServoArc;
use app_units::Au;
use canvas_traits::canvas::CanvasMsg;
use context::{LayoutContext, with_thread_local_font_context};
-use euclid::{Transform3D, Po... | 5 | 191 | 151 |
3f5354fe5f340689b5d54525c53eab73368d29de | Boris Chiou | 2017-08-30T06:06:44 | servo: Merge #18305 - Return Err(()) if determinant is not 1 or -1 while decomposing the 2d matrix (from BorisChiou:stylo/animation/transform/determinant_panic); r=birtles
This error may happen in some cases, and we shouldn't panic in debug mode,
so let's return Err(()) for it to fall back to discrete animation.
---
... | diff --git a/style/properties/helpers/animated_properties.mako.rs b/style/properties/helpers/animated_properties.mako.rs
index 4c2057f61..5cdcb5285 100644
--- a/style/properties/helpers/animated_properties.mako.rs
+++ b/style/properties/helpers/animated_properties.mako.rs
@@ -1692,8 +1692,8 @@ fn decompose_2d_matrix(ma... | 1 | 5 | 3 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.