commit_hash stringlengths 40 40 | author stringlengths 1 57 | date timestamp[s]date 2010-07-26 04:45:09 2026-04-14 18:21:10 | message stringlengths 8 1.39M | diff stringlengths 68 51.2k | files_changed int64 1 136 | insertions int64 0 2.35k | deletions int64 0 1.9k |
|---|---|---|---|---|---|---|---|
42e4b779b677eb8ecaa5401be67aecaab4c618c1 | Anthony Ramine | 2017-06-27T22:34:15 | servo: Merge #17530 - Improve sequence values in style (from servo:derive-all-the-things); r=emilio
Source-Repo: https://github.com/servo/servo
Source-Revision: de0ee6cebfcaad720cd3568b19d2992349c8825c | diff --git a/gfx/display_list/mod.rs b/gfx/display_list/mod.rs
index 789aea472..c8430ab61 100644
--- a/gfx/display_list/mod.rs
+++ b/gfx/display_list/mod.rs
@@ -28,7 +28,8 @@ use std::cmp::{self, Ordering};
use std::collections::HashMap;
use std::fmt;
use std::sync::Arc;
-use style::computed_values::{border_style, f... | 21 | 208 | 238 |
5f6057e893048b26265595a19e26a638231ddfb8 | Shing Lyu | 2017-06-27T21:34:01 | servo: Merge #17428 - Convert -webkit-linear-gradient coordinate system for Stylo (from shinglyu:lineargradient); r=nox
<!-- Please describe your changes on the following line: -->
This patch will fix the -webkit-linear-gradient direction issue in Stylo. I decided to NOT change the behavior of Servo, because according... | diff --git a/style/values/computed/image.rs b/style/values/computed/image.rs
index 3718be2fb..05640c94f 100644
--- a/style/values/computed/image.rs
+++ b/style/values/computed/image.rs
@@ -18,7 +18,9 @@ use values::generics::image::{CompatMode, ColorStop as GenericColorStop, EndingS
use values::generics::image::{Gradi... | 2 | 76 | 11 |
11e42e0a3c22f4f0229e4fd9ed825efacbee0ba6 | Emilio Cobos Álvarez | 2017-06-27T19:44:33 | servo: Merge #17525 - style: Fix propagation of text-decoration lines (from emilio:text-decoration); r=heycam
This also paves up the ground to be able to fix #16825.
Source-Repo: https://github.com/servo/servo
Source-Revision: 79ee821bef68e371b104a7af4fb657460362ff1d | diff --git a/style/gecko/restyle_damage.rs b/style/gecko/restyle_damage.rs
index 9d443b23b..e9be48644 100644
--- a/style/gecko/restyle_damage.rs
+++ b/style/gecko/restyle_damage.rs
@@ -47,9 +47,10 @@ impl GeckoRestyleDamage {
/// them, but Gecko has an interesting optimization when they mark accessed
/// stru... | 6 | 250 | 253 |
3b27c7fcc765cc046fc4c89e2043d441bf6ef209 | Nazım Can Altınova | 2017-06-27T18:35:33 | servo: Merge #17517 - stylo: Implement font-language-override descriptor for @font-face rule (from canaltinova:font-lang-override); r=SimonSapin
Generally we use computed values for `@font-face` rule descriptors but that descriptor is a bit different than the others in gecko side. It accepts strings instead of unsign... | diff --git a/style/font_face.rs b/style/font_face.rs
index 5e1b14528..2c2f5882f 100644
--- a/style/font_face.rs
+++ b/style/font_face.rs
@@ -17,6 +17,8 @@ use error_reporting::ContextualParseError;
#[cfg(feature = "gecko")] use gecko_bindings::structs::CSSFontFaceDescriptors;
#[cfg(feature = "gecko")] use cssparser::... | 3 | 27 | 2 |
e715c3c3797ef5298f2bec8bc589695c5e517248 | Emilio Cobos Álvarez | 2017-06-27T14:08:42 | servo: Merge #17523 - style: Cleanup traversal.rs (from emilio:cleanup-traversal); r=nox
Mostly reflowing comments that have become too long or two short with
refactorings, and using consistent indentation.
Source-Repo: https://github.com/servo/servo
Source-Revision: f93fccac57b358446c8e4b2a99bd60318d3f9634 | diff --git a/style/traversal.rs b/style/traversal.rs
index c181f3162..ddb82e095 100644
--- a/style/traversal.rs
+++ b/style/traversal.rs
@@ -38,6 +38,7 @@ bitflags! {
/// Traverse without generating any change hints.
const FOR_RECONSTRUCT = 0x04,
/// Traverse triggered by CSS rule changes.
+ ... | 1 | 189 | 142 |
5f165e3ff164be31c13041a2067045cfe4505d66 | Boris Zbarsky | 2017-06-27T06:46:13 | servo: Merge #17528 - Fix stylo support for first-letter (from bzbarsky:first-letter-better); r=emilio
<!-- Please describe your changes on the following line: -->
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- ... | diff --git a/style/dom.rs b/style/dom.rs
index de736e291..29311727f 100644
--- a/style/dom.rs
+++ b/style/dom.rs
@@ -426,9 +426,19 @@ pub trait TElement : Eq + PartialEq + Debug + Hash + Sized + Copy + Clone +
/// TODO(emilio, bz): actually implement the logic for it.
fn may_generate_pseudo(
&self,
-... | 6 | 74 | 18 |
6835a0c6cdca99712fbd985e7e6336953860e382 | streichgeorg | 2017-06-27T05:46:27 | servo: Merge #17522 - Replace ParseNodeID with ParseNodeId (from streichgeorg:master); r=emilio
<!-- Please describe your changes on the following line: -->
---
Not really much to this...
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appro... | diff --git a/script/dom/servoparser/async_html.rs b/script/dom/servoparser/async_html.rs
index a7ac04aa6..243e4452b 100644
--- a/script/dom/servoparser/async_html.rs
+++ b/script/dom/servoparser/async_html.rs
@@ -128,11 +128,11 @@ unsafe impl JSTraceable for HtmlTokenizer<TreeBuilder<ParseNode, Sink>> {
}
}
-ty... | 1 | 22 | 22 |
36b90d93bf1f2b713869aa22f7a7ca77045f1923 | Hiroyuki Ikezoe | 2017-06-27T04:12:32 | servo: Merge #17526 - Check has_new_animation_style along with for_css_rule_changes() in ne… (from hiikezoe:check-has_new_animation_style); r=birtles
…eds_animations_update().
<!-- Please describe your changes on the following line: -->
https://bugzilla.mozilla.org/show_bug.cgi?id=1375787
---
- [X] `./mach build -d`... | diff --git a/style/matching.rs b/style/matching.rs
index ab51de215..d6c79e917 100644
--- a/style/matching.rs
+++ b/style/matching.rs
@@ -653,9 +653,14 @@ trait PrivateMatchMethods: TElement {
let old_display_style = old_box_style.clone_display();
let new_display_style = new_box_style.clone_dis... | 1 | 8 | 3 |
f338b99d85d01c68a6c9300c180eb95d53b89faf | Harvey Hunt | 2017-06-25T17:45:42 | servo: Merge #17514 - deny_public_fields: display field identifier in help message (from HarveyHunt:deny-public-fields-error-message); r=jdm
Use a binding's field identifier to produce more descriptive output.
Fall back to a binding's identifier if a field identifier is not
available.
Additionally, make the privatize... | diff --git a/deny_public_fields/lib.rs b/deny_public_fields/lib.rs
index a43db51e4..e9b8b7938 100644
--- a/deny_public_fields/lib.rs
+++ b/deny_public_fields/lib.rs
@@ -17,7 +17,8 @@ fn expand_string(input: &str) -> String {
let style = synstructure::BindStyle::Ref.into();
synstructure::each_field(&type_, &st... | 1 | 2 | 1 |
699cf1b9d7cca752d961213ea5f3f81844117c58 | Jeremy Lempereur | 2017-06-25T16:06:28 | servo: Merge #17383 - #17363 : Passing ProfilerChan by reference to the send_profile_data method (from o0Ignition0o:profiler_chan_by_reference); r=jdm
<!-- Please describe your changes on the following line: -->
Passed the ProfilerChan by reference to the send_profile_data method.
I wonder if I should also refactor t... | diff --git a/layout_thread/lib.rs b/layout_thread/lib.rs
index 96eac55cc..4e407e214 100644
--- a/layout_thread/lib.rs
+++ b/layout_thread/lib.rs
@@ -1253,7 +1253,7 @@ impl LayoutThread {
(self.layout_threads as u64);
time::send_profile_data(time::ProfilerCategory::LayoutTextShaping,
... | 2 | 3 | 3 |
c59728b095245f77032fa220a7fb79f759343364 | Corey Farwell | 2017-06-25T07:38:23 | servo: Merge #17515 - Merge explicit node iterator structures into single generic structure (from frewsxcv:frewsxcv-simple-node-iterator); r=KiChjang
Source-Repo: https://github.com/servo/servo
Source-Revision: f740366c611d375f0bb259ae0f4d846c05ec276e | diff --git a/script/dom/node.rs b/script/dom/node.rs
index 2e0152195..bf24682ed 100644
--- a/script/dom/node.rs
+++ b/script/dom/node.rs
@@ -504,15 +504,17 @@ impl Node {
TreeIterator::new(self)
}
- pub fn inclusively_following_siblings(&self) -> NodeSiblingIterator {
- NodeSiblingIterator {
+... | 2 | 49 | 85 |
f898ffd49623ff7173bb0ab09e9e367f88e2717a | Emilio Cobos Álvarez | 2017-06-25T00:47:46 | servo: Merge #17516 - style: Fix rem computation on the root element (from emilio:rem-root-size); r=heycam
Bug: 1375930
Reviewed-By: heycam
MozReview-Commit-ID: DK98SS1w5nO
Source-Repo: https://github.com/servo/servo
Source-Revision: c39de45d81eb54c3a8dc78b41883b07dbd7d3896 | diff --git a/style/values/specified/length.rs b/style/values/specified/length.rs
index 61789ac8d..d40f6770d 100644
--- a/style/values/specified/length.rs
+++ b/style/values/specified/length.rs
@@ -112,7 +112,6 @@ impl FontRelativeLength {
let reference_font_size = base_size.resolve(context);
- let r... | 1 | 13 | 2 |
b7e4ad502d23e89f738eb2cd4c31681249e08cfe | Anthony Ramine | 2017-06-24T11:46:56 | servo: Merge #17508 - Use generics for SimpleShadow (from servo:derive-all-the-things); r=emilio
Source-Repo: https://github.com/servo/servo
Source-Revision: 946c9aede12b19bab11f7f25db68f18c19c5b4a2 | diff --git a/style/values/animated/effects.rs b/style/values/animated/effects.rs
index d53afdfc9..bbf604836 100644
--- a/style/values/animated/effects.rs
+++ b/style/values/animated/effects.rs
@@ -16,6 +16,7 @@ use values::computed::effects::SimpleShadow as ComputedSimpleShadow;
use values::computed::length::Length;
... | 4 | 23 | 45 |
69433fa593c3c23f5206259d646654be8610a97b | Emilio Cobos Álvarez | 2017-06-24T08:22:45 | servo: Merge #17507 - style: Fix misindented code in font.mako.rs (from emilio:font-indent); r=nox
Source-Repo: https://github.com/servo/servo
Source-Revision: d58d1ddbbdb894d51ef29407afb7e0e20b0bd9ed | diff --git a/style/properties/longhand/font.mako.rs b/style/properties/longhand/font.mako.rs
index c2082af3e..7899cadb5 100644
--- a/style/properties/longhand/font.mako.rs
+++ b/style/properties/longhand/font.mako.rs
@@ -902,9 +902,9 @@ ${helpers.single_keyword_system("font-variant-caps",
#[inline]
... | 1 | 3 | 3 |
b1b4d305586aa916689488058621851f50ff9c3b | Bobby Holley | 2017-06-24T03:07:45 | servo: Merge #17504 - Make EagerPseudoStyles use an Arc, not a Box (from bholley:arc_pseudos); r=bholley
Reviewed in https://bugzilla.mozilla.org/show_bug.cgi?id=1371049
Fixes #17300
Source-Repo: https://github.com/servo/servo
Source-Revision: a29261dec196ab5c887655e479e503ca6cbb9229 | diff --git a/style/context.rs b/style/context.rs
index 33ff5d616..6a8f3535c 100644
--- a/style/context.rs
+++ b/style/context.rs
@@ -332,7 +332,7 @@ impl Clone for EagerPseudoCascadeInputs {
impl EagerPseudoCascadeInputs {
/// Construct inputs from previous cascade results, if any.
fn new_from_style(styles: ... | 2 | 48 | 18 |
b78f3f27e90171eb78753bb332e9961dd05f12bb | Corey Farwell | 2017-06-24T02:01:33 | servo: Merge #17503 - Replace iterator struct with anonymous return iterator types (from frewsxcv:frewsxcv-return-node-list-2); r=mbrubeck
Similar to https://github.com/servo/servo/pull/17488.
Source-Repo: https://github.com/servo/servo
Source-Revision: 1d045e5c3b0f1b07fcf1f3513957c2378db0313c | diff --git a/script/dom/htmlcollection.rs b/script/dom/htmlcollection.rs
index 814ea766f..6cc3dbb8d 100644
--- a/script/dom/htmlcollection.rs
+++ b/script/dom/htmlcollection.rs
@@ -224,11 +224,9 @@ impl HTMLCollection {
pub fn elements_iter_after<'a>(&'a self, after: &'a Node) -> impl Iterator<Item=Root<Element>... | 1 | 6 | 30 |
8f469f5052325086289bde35c176a8378f11e4c0 | Anthony Ramine | 2017-06-24T00:45:58 | servo: Merge #17494 - Marginally improve shadows (from servo:derive-all-the-things); r=emilio
Source-Repo: https://github.com/servo/servo
Source-Revision: c586a241bb488b520b311908b0de28febc79f21e | diff --git a/style/gecko_bindings/sugar/ns_css_shadow_item.rs b/style/gecko_bindings/sugar/ns_css_shadow_item.rs
index 45072ba2e..c186945a4 100644
--- a/style/gecko_bindings/sugar/ns_css_shadow_item.rs
+++ b/style/gecko_bindings/sugar/ns_css_shadow_item.rs
@@ -8,7 +8,7 @@ use app_units::Au;
use gecko::values::{convert... | 6 | 74 | 132 |
39a6bb6dc9d397152f824abd3c777a2bf6776ad6 | Nathan Froyd | 2017-06-23T23:01:02 | servo: Merge #17493 - remove various things now that Rust 1.17 is required (from froydnj:rust-117-fixes); r=jdm
std::ptr::eq and Arc::ptr_eq are now usuable, and we can replace a
panic!() with abort().
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These c... | diff --git a/layout/fragment.rs b/layout/fragment.rs
index 40293bb37..416a15025 100644
--- a/layout/fragment.rs
+++ b/layout/fragment.rs
@@ -1854,7 +1854,7 @@ impl Fragment {
match (&mut self.specific, &next_fragment.specific) {
(&mut SpecificFragmentInfo::ScannedText(ref mut this_info),
... | 6 | 7 | 26 |
dda6b2ab35ec0f5bf99adb897845a262009caefd | Keith Yeung | 2017-06-23T21:56:00 | servo: Merge #17491 - Introduce service-worker mode (from KiChjang:update-fetch); r=jdm
Bringing in the spec changes from whatwg/fetch#435.
Source-Repo: https://github.com/servo/servo
Source-Revision: e2a26e7bd0d8089a441bc3072cf15351b0ef1252 | diff --git a/net/http_loader.rs b/net/http_loader.rs
index 5489a4959..73ef5b464 100644
--- a/net/http_loader.rs
+++ b/net/http_loader.rs
@@ -34,7 +34,7 @@ use msg::constellation_msg::PipelineId;
use net_traits::{CookieSource, FetchMetadata, NetworkError, ReferrerPolicy};
use net_traits::request::{CacheMode, Credentia... | 4 | 58 | 44 |
846406b44294421404086c8eebb3ce8aa064a029 | Corey Farwell | 2017-06-23T19:38:02 | servo: Merge #17488 - Replace iterator struct with anonymous return iterator type (from frewsxcv:frewsxcv-return-node-list); r=jdm
```
hi servo. it's been
some time. here's a pull request.
i hope you like it.
```
Source-Repo: https://github.com/servo/servo
Source-Revision: bc5e8f89fff9bf1922638b3eb2f4c75148dcad1e | diff --git a/script/dom/nodelist.rs b/script/dom/nodelist.rs
index 39b4cc1c4..31e4dfb40 100644
--- a/script/dom/nodelist.rs
+++ b/script/dom/nodelist.rs
@@ -103,11 +103,9 @@ impl NodeList {
}
}
- pub fn iter(&self) -> NodeListIterator {
- NodeListIterator {
- nodes: self,
- ... | 1 | 3 | 20 |
db3d25e1de0fc4aa325ee44867fa0bdb7f96b9a7 | Jonathan Chan | 2017-06-23T18:37:23 | servo: Merge #17259 - Force HTMLStyleElement to create a new CSSStyleSheet when re-parsing (from jyc:new-CSSStyleSheet); r=emilio
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes do not require tests because I'm pushing to find out what test re... | diff --git a/script/dom/htmlstyleelement.rs b/script/dom/htmlstyleelement.rs
index bf4266e18..bbce33f3d 100644
--- a/script/dom/htmlstyleelement.rs
+++ b/script/dom/htmlstyleelement.rs
@@ -111,6 +111,7 @@ impl HTMLStyleElement {
win.layout_chan().send(Msg::AddStylesheet(sheet.clone())).unwrap();
*se... | 1 | 1 | 0 |
6d90802257e24c5b0d7784133318b1108184ad77 | Mike Hommey | 2017-06-23T17:37:43 | servo: Merge #17492 - Separate thread pool from global state for Gecko (from glandium:master); r=emilio
When stylo is not enabled in Gecko, the global state initialization
still creates the style thread pool, even when it's not going to be
used. This wastes address space and a little memory.
See https://bugzilla.mozi... | diff --git a/style/gecko/global_style_data.rs b/style/gecko/global_style_data.rs
index 0f80a1881..f396a4ee4 100644
--- a/style/gecko/global_style_data.rs
+++ b/style/gecko/global_style_data.rs
@@ -16,12 +16,6 @@ use std::ffi::CString;
/// Global style data
pub struct GlobalStyleData {
- /// How many threads para... | 1 | 17 | 11 |
f7045d614cfb4434330e152e8919e6b0333d8257 | Matt Wismer | 2017-06-23T16:39:11 | servo: Merge #17487 - Correct bloom hash bitpacking documentation (from MattWis:patch-1); r=emilio
The two 12 bit keys add to 24 bits, which leaves 8 bits free in each word. (And 8 * 3 = 24, to pack in the fourth hash.)
<!-- Please describe your changes on the following line: -->
I have never actually built servo, bu... | diff --git a/selectors/bloom.rs b/selectors/bloom.rs
index 8caab9935..0e8290fc8 100644
--- a/selectors/bloom.rs
+++ b/selectors/bloom.rs
@@ -7,7 +7,7 @@
use fnv::FnvHasher;
use std::hash::{Hash, Hasher};
-// The top 12 bits of the 32-bit hash value are not used by the bloom filter.
+// The top 8 bits of the 32-bit ... | 1 | 1 | 1 |
ce8b216341df490aad68305168efc0265393c6c7 | Anthony Ramine | 2017-06-23T12:59:49 | servo: Merge #17469 - Distinguish the emptiness of a property from its initial value (from nox:empty-vs-initial); r=emilio
Source-Repo: https://github.com/servo/servo
Source-Revision: 92679480b1dc70007d4de0391327d0cf34015e63 | diff --git a/style/properties/helpers.mako.rs b/style/properties/helpers.mako.rs
index 990e9e664..8c6701497 100644
--- a/style/properties/helpers.mako.rs
+++ b/style/properties/helpers.mako.rs
@@ -9,7 +9,7 @@
<%def name="predefined_type(name, type, initial_value, parse_method='parse',
needs_context=True... | 4 | 46 | 36 |
f9fdff18f316c9c3236e17a1171e0e1d6fe4dc41 | Simon Sapin | 2017-06-23T10:51:23 | servo: Merge #17477 - Pass some 48-bytes closures by references instead of by value (from servo:closures-by-ref); r=emilio
This reduced the generated code size by 74 KB: https://bugzilla.mozilla.org/show_bug.cgi?id=1375222#c4
Source-Repo: https://github.com/servo/servo
Source-Revision: 567f5e8985c6e4ba86fca85ff8ff467... | diff --git a/style/properties/helpers.mako.rs b/style/properties/helpers.mako.rs
index 54b5c313e..990e9e664 100644
--- a/style/properties/helpers.mako.rs
+++ b/style/properties/helpers.mako.rs
@@ -333,7 +333,7 @@
let quirks_mode = context.quirks_mode;
::properties::substitute_v... | 3 | 8 | 8 |
d722694732a5c5dbefa33c96960cb4700d3ae101 | Pyfisch | 2017-06-23T08:50:39 | servo: Merge #17385 - Fix several bugs related to scrolling (from pyfisch:better-scroll); r=mrobinson
* scrollLeft/scrollTop returned values of parent or even document root
Only the scroll of the node itself is returned. Otherwise 0.0.
* Scrolling via script had set viewport.
This resulted in other nodes appeari... | diff --git a/script/dom/document.rs b/script/dom/document.rs
index d603d898f..c97d35287 100644
--- a/script/dom/document.rs
+++ b/script/dom/document.rs
@@ -703,6 +703,7 @@ impl Document {
// Step 3
let global_scope = self.window.upcast::<GlobalScope>();
let webrender_pipeline_id ... | 3 | 23 | 24 |
0f72b68c609934bdbf167fcfdcd906e747d7af9c | Jyotsna Prakash | 2017-06-23T05:01:43 | servo: Merge #17472 - return Option from GlobalScope::current (from moonlightdrive:globalscope-current-option); r=asajeffrey
<!-- Please describe your changes on the following line: -->
handles the case where `GlobalScope::current` calls `CurrentGlobalOrNull` and the result is null
---
<!-- Thank you for contributing... | diff --git a/script/dom/globalscope.rs b/script/dom/globalscope.rs
index ce81958a2..3a47298c5 100644
--- a/script/dom/globalscope.rs
+++ b/script/dom/globalscope.rs
@@ -543,12 +543,16 @@ impl GlobalScope {
///
/// ["current"]: https://html.spec.whatwg.org/multipage/#current
#[allow(unsafe_code)]
- pub... | 4 | 10 | 6 |
c344d595f1e7b86e20c6a0cfecc2e75ff2a6f40b | Mantaroh Yoshinaga | 2017-06-23T03:58:24 | servo: Merge #17467 - Add get_zero_value for IntermediateSVGPaint (from mantaroh:svg-zero-value); r=birtles
<!-- Please describe your changes on the following line: -->
This is a PR for https://bugzilla.mozilla.org/show_bug.cgi?id=1371199
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]... | diff --git a/style/properties/helpers/animated_properties.mako.rs b/style/properties/helpers/animated_properties.mako.rs
index a78af9512..3874f972a 100644
--- a/style/properties/helpers/animated_properties.mako.rs
+++ b/style/properties/helpers/animated_properties.mako.rs
@@ -2765,7 +2765,7 @@ impl Animatable for Inter... | 1 | 21 | 1 |
bab0874dd04d7d1b05e59049afae4af927b19944 | Ting-Yu Lin | 2017-06-23T02:53:37 | servo: Merge #17471 - stylo: Fix pseudo element matching for rules in XBL stylesheets (from aethanyc:fix-pseudo-element-matching-xbl); r=emilio
stylo: Fix pseudo element matching for rules in XBL stylesheets
This change was reviewed in https://bugzilla.mozilla.org/show_bug.cgi?id=1372876
Source-Repo: https://github.... | diff --git a/style/dom.rs b/style/dom.rs
index f4031c1d6..de736e291 100644
--- a/style/dom.rs
+++ b/style/dom.rs
@@ -602,6 +602,21 @@ pub trait TElement : Eq + PartialEq + Debug + Hash + Sized + Copy + Clone +
None
}
+ /// Returns the rule hash target given an element.
+ fn rule_hash_target(&self)... | 3 | 22 | 21 |
612c19e0c41132fc1c7dc4c5a011f9c901ac9edf | Nazım Can Altınova | 2017-06-22T23:52:00 | servo: Merge #17484 - Bump cssparser version to 0.16.1 in toml files (from canaltinova:upup); r=emilio
<!-- Please describe your changes on the following line: -->
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- ... | diff --git a/canvas/Cargo.toml b/canvas/Cargo.toml
index 5fb7776fe..42e8b853e 100644
--- a/canvas/Cargo.toml
+++ b/canvas/Cargo.toml
@@ -12,7 +12,7 @@ path = "lib.rs"
[dependencies]
azure = {git = "https://github.com/servo/rust-azure"}
canvas_traits = {path = "../canvas_traits"}
-cssparser = "0.16"
+cssparser = "0.1... | 7 | 7 | 7 |
27d7616d14185d99eb6f0b884406a37042d0ae9e | Bobby Holley | 2017-06-22T21:39:30 | servo: Merge #17462 - various bloom filter optimizations (from bholley:bloom_optimizations); r=emilio
https://bugzilla.mozilla.org/show_bug.cgi?id=1375323
Source-Repo: https://github.com/servo/servo
Source-Revision: 7fbbfde2787510bf6e65d43cedc6cbe6093fa456 | diff --git a/selectors/Cargo.toml b/selectors/Cargo.toml
index 3894e3e21..dbaf0bdc2 100644
--- a/selectors/Cargo.toml
+++ b/selectors/Cargo.toml
@@ -20,6 +20,7 @@ doctest = false
[features]
gecko_like_types = []
+unstable = []
[dependencies]
bitflags = "0.7"
diff --git a/selectors/bloom.rs b/selectors/bloom.rs
... | 4 | 136 | 74 |
9fbcb10acaf7aa833e771fe5384b41efa6cf7a79 | Nikhil Shagrithaya | 2017-06-22T16:09:07 | servo: Merge #17457 - Remove target and data fields from parse_node_data (from cynicaldevil:trim-parse-node-data); r=nox
<!-- Please describe your changes on the following line: -->
`parse_node_data` does not need to store `data` and `target`, they can automatically be passed as parameters to the parser operation (`Pa... | diff --git a/script/dom/servoparser/async_html.rs b/script/dom/servoparser/async_html.rs
index e13f8169f..e1632ffaf 100644
--- a/script/dom/servoparser/async_html.rs
+++ b/script/dom/servoparser/async_html.rs
@@ -138,8 +138,6 @@ pub struct ParseNode {
#[derive(JSTraceable, HeapSizeOf)]
struct ParseNodeData {
- t... | 1 | 6 | 19 |
64f5868e836866d818834f72e442eafbacb02712 | Alan Jeffrey | 2017-06-22T14:54:10 | servo: Merge #17456 - Paint worklet size should agree with Chrome (from asajeffrey:script-paint-worklets-size); r=emilio
<!-- Please describe your changes on the following line: -->
Getting our implementation to agree with Chrome about the definition of the size parameter to a paint worklet.
---
<!-- Thank you for c... | diff --git a/layout/display_list_builder.rs b/layout/display_list_builder.rs
index 69242321c..8828994c0 100644
--- a/layout/display_list_builder.rs
+++ b/layout/display_list_builder.rs
@@ -1154,10 +1154,14 @@ impl FragmentDisplayListBuilding for Fragment {
paint_w... | 1 | 6 | 2 |
22fc8497dd0f14f896a290eac0ac0756b47c4148 | Nazım Can Altınova | 2017-06-22T13:35:41 | servo: Merge #17455 - Implement webkit prefixed values for display property (from canaltinova:webkit-displays); r=Manishearth
Added -webkit-{flex,inline-flex} values as flex, inline-flex. I didn't do this gecko only since that doesn't require anything in layout side.
---
<!-- Thank you for contributing to Servo! Plea... | diff --git a/style/properties/longhand/box.mako.rs b/style/properties/longhand/box.mako.rs
index a286625fa..4f0449ad0 100644
--- a/style/properties/longhand/box.mako.rs
+++ b/style/properties/longhand/box.mako.rs
@@ -19,9 +19,10 @@
values = """inline block inline-block
table inline-table table-row... | 1 | 8 | 2 |
a2c36a4b83f886c648791d8a2c3768879fc1a2e6 | Emilio Cobos Álvarez | 2017-06-22T11:17:04 | servo: Merge #17447 - style: Be more strict when setting the root font size (from emilio:root-disconnected-subtree); r=heycam,Manishearth
Before this commit, we assumed that if the element had no parent element, it was
the root of the document, which is plain false, since we can arrive there from,
let's say, getComput... | diff --git a/style/animation.rs b/style/animation.rs
index f8fde047b..50735801c 100644
--- a/style/animation.rs
+++ b/style/animation.rs
@@ -502,7 +502,6 @@ fn compute_style_for_animation_step(context: &SharedStyleContext,
// as existing browsers don't appear to animate visited styles.
let com... | 15 | 75 | 56 |
289ddd1d15de9d6d78feb2142664a5a4f57a25f7 | Hiroyuki Ikezoe | 2017-06-22T09:22:34 | servo: Merge #17444 - Use FnvHashmap instead of HashMap for AnimationValueMap (from hiikezoe:fnv-hashmap-for-animation); r=emilio
<!-- Please describe your changes on the following line: -->
https://bugzilla.mozilla.org/show_bug.cgi?id=1374842
---
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-... | diff --git a/style/gecko/wrapper.rs b/style/gecko/wrapper.rs
index 602e500de..6f257ae59 100644
--- a/style/gecko/wrapper.rs
+++ b/style/gecko/wrapper.rs
@@ -616,7 +616,7 @@ fn get_animation_rule(element: &GeckoElement,
-> Option<Arc<Locked<PropertyDeclarationBlock>>> {
use gecko_bindings::su... | 2 | 3 | 3 |
a7c51a8312cad7a899f8bfdf6227ff2e2fe0cbd2 | Anthony Ramine | 2017-06-22T08:19:51 | servo: Merge #17446 - Simplify machinery to serialise optional parts of CSS values (from servo:derive-all-the-things); r=emilio
Source-Repo: https://github.com/servo/servo
Source-Revision: 0913d65243878ac6a37caed57c1cc7dfbd44ff54 | diff --git a/style/properties/longhand/border.mako.rs b/style/properties/longhand/border.mako.rs
index d337c6196..d984a2d80 100644
--- a/style/properties/longhand/border.mako.rs
+++ b/style/properties/longhand/border.mako.rs
@@ -214,7 +214,6 @@ ${helpers.predefined_type("border-image-outset", "LengthOrNumberRect",
<... | 8 | 152 | 131 |
386370e83b980a77331b107db213dd548b992c54 | Emilio Cobos Álvarez | 2017-06-22T07:14:38 | servo: Merge #17443 - style: Don't use SmallVec::into_iter to move into another vector (from emilio:smallwat); r=SimonSapin
See bug 1374848 for why.
Source-Repo: https://github.com/servo/servo
Source-Revision: 6b99318f552c1561392208efd9030d0b4a6f91d1 | diff --git a/style/invalidation/element/invalidator.rs b/style/invalidation/element/invalidator.rs
index a45bd2967..055b5f6ae 100644
--- a/style/invalidation/element/invalidator.rs
+++ b/style/invalidation/element/invalidator.rs
@@ -492,7 +492,7 @@ impl<'a, 'b: 'a, E> TreeStyleInvalidator<'a, 'b, E>
}
... | 2 | 11 | 8 |
1e90b84a788196718ac60f1dbeb71b21890ce7b8 | Fernando Jiménez Moreno | 2017-06-21T17:40:35 | servo: Merge #17343 - stylo: make font-weight descriptor in @font-face preserve keyword values (from ferjm:bug1355368.fontweight.keyword); r=upsuper
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix https://bugzilla.mozilla.org/show_bug.cgi?i... | diff --git a/style/font_face.rs b/style/font_face.rs
index e8801b5a1..5e1b14528 100644
--- a/style/font_face.rs
+++ b/style/font_face.rs
@@ -70,6 +70,66 @@ define_css_keyword_enum!(FontDisplay:
"optional" => Optional);
add_impls_for_keyword_enum!(FontDisplay);
+/// A font-weight value for a... | 2 | 74 | 2 |
5a472a148b935cda63c7cccf07dee943cc0e9ff0 | Bobby Holley | 2017-06-21T16:28:43 | servo: Merge #17439 - Match compound selectors left-to-right (second try) (from bholley:compound_left_to_right); r=SimonSapin
https://bugzilla.mozilla.org/show_bug.cgi?id=1373800
Source-Repo: https://github.com/servo/servo
Source-Revision: b211664e877a3e4d712314fa7f3002fd19cff549 | diff --git a/script/dom/element.rs b/script/dom/element.rs
index f279c2c27..a431d0c9d 100644
--- a/script/dom/element.rs
+++ b/script/dom/element.rs
@@ -89,6 +89,7 @@ use selectors::attr::{AttrSelectorOperation, NamespaceConstraint, CaseSensitivit
use selectors::matching::{ElementSelectorFlags, LocalMatchingContext, M... | 14 | 477 | 298 |
93a17001f946df20d89b2310f6323cdb8c0ddd1e | Glenn Watson | 2017-06-21T14:47:53 | servo: Merge #17398 - Improve decisions in compositor over when to draw a frame (from glennw:opt-composite); r=jdm
This patch fixes a couple of issues in the compositor:
1) Remove the delayed composition code. Previously, this would schedule
a composite for 12ms in the future. This doesn't really make any sense
... | diff --git a/compositing/compositor.rs b/compositing/compositor.rs
index cb2abb781..f6f1a02fc 100644
--- a/compositing/compositor.rs
+++ b/compositing/compositor.rs
@@ -6,7 +6,6 @@ use CompositionPipeline;
use SendableFrameTree;
use compositor_thread::{CompositorProxy, CompositorReceiver};
use compositor_thread::{In... | 6 | 57 | 173 |
121dbf0c3dbfbb4f88a1796492d8b1cc5a5fb993 | Pyfisch | 2017-06-21T13:50:09 | servo: Merge #17395 - Make background gradient cover padding (from pyfisch:issue17387); r=emilio
CSS-gradients should not only cover the content of an
element but also the padding (but not the border).
<!-- Please describe your changes on the following line: -->
Thanks to @atouchet for catching this.
<!-- Thank you... | diff --git a/layout/display_list_builder.rs b/layout/display_list_builder.rs
index 97b26acaa..69242321c 100644
--- a/layout/display_list_builder.rs
+++ b/layout/display_list_builder.rs
@@ -1300,12 +1300,12 @@ impl FragmentDisplayListBuilding for Fragment {
let mut clip = clip.clone();
clip.intersect_r... | 1 | 5 | 5 |
8653d00ac26812f31a24467f8acfa22bf317fc3e | Glenn Watson | 2017-06-21T12:41:08 | servo: Merge #17441 - Update WR (z-buffer fix, border-image fill support) (from glennw:update-wr-fill-z); r=KiChjang
Source-Repo: https://github.com/servo/servo
Source-Revision: 7543acc257d91c2dbbf2d430e071dc71a3a0573c | diff --git a/layout/webrender_helpers.rs b/layout/webrender_helpers.rs
index 9110d95ec..bba2ae20b 100644
--- a/layout/webrender_helpers.rs
+++ b/layout/webrender_helpers.rs
@@ -371,6 +371,7 @@ impl WebRenderDisplayItemConverter for DisplayItem {
height: image.image.height,
... | 1 | 1 | 0 |
71107bb69441002d6cb05b6e9b8a87a801eb1edf | Brad Werth | 2017-06-21T11:36:52 | servo: Merge #17436 - Add an update_stylesheet method to StylesheetSet (from bradwerth:updateStylesheet); r=xidorn,emilio
MozReview-Commit-ID: KlRkApYL8wk
<!-- Please describe your changes on the following line: -->
Provides a method for just-cloned sheets to be swapped in to stylesheet_sets without changing the orde... | diff --git a/style/gecko/generated/bindings.rs b/style/gecko/generated/bindings.rs
index 366b07a3b..4a4650d16 100644
--- a/style/gecko/generated/bindings.rs
+++ b/style/gecko/generated/bindings.rs
@@ -1885,6 +1885,11 @@ extern "C" {
unique_id: u64,
... | 2 | 22 | 0 |
18520af18a4b3b877be555466d5e12d53cfb6044 | KuoE0 | 2017-06-21T10:32:59 | servo: Merge #17424 - Expose -moz-context-properties on stylo (from KuoE0:expose-moz-context-properties-on-stylo); r=heycam
<!-- Please describe your changes on the following line: -->
Gecko already exposed `-moz-context-properties` behind pref `svg.context-properties.content.enabled`. I think we should do the same t... | diff --git a/style/properties/longhand/inherited_svg.mako.rs b/style/properties/longhand/inherited_svg.mako.rs
index 24fa4fdb4..3799c89d3 100644
--- a/style/properties/longhand/inherited_svg.mako.rs
+++ b/style/properties/longhand/inherited_svg.mako.rs
@@ -268,7 +268,6 @@ ${helpers.predefined_type("marker-end", "UrlOrN... | 1 | 0 | 1 |
272ac3dd05078eec67b67ee67bee16421e48e075 | Connor Brewster | 2017-06-21T08:04:18 | servo: Merge #17421 - Fix crash when id attribute is set via SetAttributeNode (from cbrewster:set_attribute_node_fix); r=emilio
fixes #17366
Source-Repo: https://github.com/servo/servo
Source-Revision: 82884050be02c0a72d2e2e2fa5645ecad2b9c668 | diff --git a/script/dom/element.rs b/script/dom/element.rs
index c0570ad83..f279c2c27 100644
--- a/script/dom/element.rs
+++ b/script/dom/element.rs
@@ -1543,6 +1543,10 @@ impl ElementMethods for Element {
// https://dom.spec.whatwg.org/#dom-element-setattributenode
fn SetAttributeNode(&self, attr: &Attr) -... | 1 | 4 | 0 |
d7aaf2a1d59b10512603f151dc9db5470705a952 | Emilio Cobos Álvarez | 2017-06-20T15:13:05 | servo: Merge #17431 - style: Cleanup after #17427, and remove extra-optimistic optimization added in #17429 (from emilio:restyle-hints-xbl); r=emilio
This just addresses my review comments in #17427, and removes a wrong optimization I added in #17429 thinking it was correct.
Source-Repo: https://github.com/servo/serv... | diff --git a/style/gecko/wrapper.rs b/style/gecko/wrapper.rs
index 937d1422e..42c9997e6 100644
--- a/style/gecko/wrapper.rs
+++ b/style/gecko/wrapper.rs
@@ -1747,8 +1747,8 @@ impl<'le> ::selectors::Element for GeckoElement<'le> {
// If this element is the shadow root of an use-element shadow
... | 3 | 5 | 4 |
f0a991e3ec35412a57616a5206c220a31938e9d1 | cku | 2017-06-20T12:17:45 | servo: Merge #17427 - Stylo: Correct style match for element instances under a use-element … (from CJKu:cku-master); r=emilio
<!-- Please describe your changes on the following line: -->
This patch is the last one of bug 265894.
It fixes two things:
1. Do not cross shadow tree boundary while matching rules.
2. Change ... | diff --git a/selectors/matching.rs b/selectors/matching.rs
index 62cd7ee54..252a1c11d 100644
--- a/selectors/matching.rs
+++ b/selectors/matching.rs
@@ -532,8 +532,12 @@ fn matches_complex_selector_internal<E, F>(mut selector_iter: SelectorIter<E::Im
SelectorMatchingResult::NotMatchedAndRestartFro... | 4 | 34 | 3 |
da5592a8d4e49544a14b2239255038a6eca53298 | Jonathan Chan | 2017-06-20T10:08:11 | servo: Merge #17414 - style: Have OneOrMoreSeparated replace OneOrMoreCommaSeparated (from jyc:space-separator); r=nox
**NOTE** The alternative for me is just to duplicate the ToCss code, which is not bad and is less code changed! Don't know what others would think, though. Looking for feedback!
A future patch series... | diff --git a/style/counter_style/mod.rs b/style/counter_style/mod.rs
index cfe35bccf..05c462636 100644
--- a/style/counter_style/mod.rs
+++ b/style/counter_style/mod.rs
@@ -19,7 +19,7 @@ use std::ascii::AsciiExt;
use std::borrow::Cow;
use std::fmt;
use std::ops::Range;
-use style_traits::{ToCss, OneOrMoreCommaSepara... | 6 | 64 | 14 |
6196d7e59dd11d5bc323e66055a0797445eacf57 | Ting-Yu Lin | 2017-06-20T09:05:08 | servo: Merge #17426 - stylo: Fix has_author_specified_rules() for rules in XBL stylesheets (from aethanyc:fix-has-author-specified-rules-xbl); r=heycam
This change is reviewed in https://bugzilla.mozilla.org/show_bug.cgi?id=1372062
Source-Repo: https://github.com/servo/servo
Source-Revision: a7ac9214f2b3e6c5a2b9786ae... | diff --git a/style/rule_tree/mod.rs b/style/rule_tree/mod.rs
index d4bae6670..cc1cec8b9 100644
--- a/style/rule_tree/mod.rs
+++ b/style/rule_tree/mod.rs
@@ -1112,8 +1112,7 @@ impl StrongRuleNode {
CascadeLevel::UANormal |
CascadeLevel::UAImportant |
Cascade... | 1 | 2 | 2 |
a0e5c397740bd419f631676fd15208825d19d9b2 | Boris Chiou | 2017-06-20T06:12:19 | servo: Merge #17422 - stylo: Bug 1369625 - Make stop-color, flood-color, lighting-color animatable (from BorisChiou:stylo/animation/stop_flood_lighting_colors); r=hiro
This is an interdependent patch of Bug 1369625. We make stop-color, flood-color, and lighting-color animatable by using IntermediateRGBA as the animati... | diff --git a/style/properties/longhand/svg.mako.rs b/style/properties/longhand/svg.mako.rs
index b2f2b6f2e..05e5e5083 100644
--- a/style/properties/longhand/svg.mako.rs
+++ b/style/properties/longhand/svg.mako.rs
@@ -23,7 +23,7 @@ ${helpers.predefined_type(
"stop-color", "RGBAColor",
"RGBA::new(0, 0, 0, 255)"... | 1 | 3 | 3 |
c78554086e7b0d3430134a24c6406c0a2e07113c | Hiroyuki Ikezoe | 2017-06-20T03:19:16 | servo: Merge #17400 - Don't run normal traversal for animation only restyle element (from hiikezoe:dont-do-normal-traversal-for-animation-only-restyle-element); r=heycam
<!-- Please describe your changes on the following line: -->
https://bugzilla.mozilla.org/show_bug.cgi?id=1356141
---
<!-- Thank you for contributin... | diff --git a/style/invalidation/element/invalidator.rs b/style/invalidation/element/invalidator.rs
index ed759076e..2ed012d37 100644
--- a/style/invalidation/element/invalidator.rs
+++ b/style/invalidation/element/invalidator.rs
@@ -239,7 +239,7 @@ impl<'a, 'b: 'a, E> TreeStyleInvalidator<'a, 'b, E>
let mut an... | 2 | 22 | 11 |
355a5dc3dff22029ec2eefb49ad33a14c168e4b1 | Boris Zbarsky | 2017-06-20T02:25:45 | servo: Merge #17418 - Add pseudo-classes to match on the state of the "dir" attribute (from bzbarsky:dir-pseudo-classes); r=emilio
Fixes the servo parts of Gecko bug 1373798 <https://bugzilla.mozilla.org/show_bug.cgi?id=1373798>
<!-- Please describe your changes on the following line: -->
---
<!-- Thank you for cont... | diff --git a/style/element_state.rs b/style/element_state.rs
index 809f01218..d8b4d6803 100644
--- a/style/element_state.rs
+++ b/style/element_state.rs
@@ -120,6 +120,18 @@ bitflags! {
const IN_LTR_STATE = 1 << 44,
/// State that elements that match :dir(rtl) are in.
const IN_RTL_STATE = 1 <... | 5 | 94 | 70 |
8c37c800c75dbea269f275abc88e48b6bfed71de | est31 | 2017-06-20T01:22:25 | servo: Merge #17413 - Update clipboard to 0.4 (from est31:master); r=cbrewster
Fixes #17271
Fixes #16459
Source-Repo: https://github.com/servo/servo
Source-Revision: 154186f420f96897e926fa0a7c4a653cd0185e34 | diff --git a/constellation/Cargo.toml b/constellation/Cargo.toml
index 5953c3834..b340a535b 100644
--- a/constellation/Cargo.toml
+++ b/constellation/Cargo.toml
@@ -13,7 +13,7 @@ path = "lib.rs"
backtrace = "0.3"
bluetooth_traits = { path = "../bluetooth_traits" }
canvas = {path = "../canvas"}
-clipboard = "0.3"
+cl... | 1 | 1 | 1 |
1ed007c6362b67deb3c0fd929d31a22156c52897 | Wes Kocher | 2017-06-20T00:21:29 | servo: Merge #17415 - Revert "Add pseudo-classes to match on the state of the "dir" attribute." for preventing me from backing out a gecko-side patch (from KWierso:backout17409); r=jdm
The gecko patches in bug 1373798 broke some gecko-side tests, but they also fixed a stylo build failure that started when this commit ... | diff --git a/style/element_state.rs b/style/element_state.rs
index d8b4d6803..809f01218 100644
--- a/style/element_state.rs
+++ b/style/element_state.rs
@@ -120,18 +120,6 @@ bitflags! {
const IN_LTR_STATE = 1 << 44,
/// State that elements that match :dir(rtl) are in.
const IN_RTL_STATE = 1 <... | 5 | 70 | 94 |
cd9eae97ac1ae70e9ab1c373796521cdd1f5f7a5 | Brian Lewis | 2017-06-19T22:30:21 | servo: Merge #17404 - Shrink rulenode (from zuwow:shrink-rulenode); r=bholley
This shrinks rulenode by one word by removing the Option wrapper around the StyleSource and adding None to StyleSource as an additional variant. The issue mentions shrinking by two words but the free_count one was taken care of in #17368.
-... | diff --git a/style/matching.rs b/style/matching.rs
index a1cde2f85..f65f183e6 100644
--- a/style/matching.rs
+++ b/style/matching.rs
@@ -1068,7 +1068,8 @@ pub trait MatchMethods : TElement {
if log_enabled!(Trace) {
trace!("Matched rules:");
for rn in primary_rule_node.self_and_ancest... | 3 | 46 | 30 |
c62d3b26975559fa3a479567651dff6a7b43e177 | Alan Jeffrey | 2017-06-19T20:25:36 | servo: Merge #17410 - Support nested requestAnimationFrame in the presence of reftest-wait (from asajeffrey:compositor-nested-rAF-with-reftest-wait); r=jdm
<!-- Please describe your changes on the following line: -->
Currently, nested rAF callbacks don't get called in the presence of reftest-wait. This PR fixes that.... | diff --git a/compositing/compositor.rs b/compositing/compositor.rs
index 5cb72fce0..cb2abb781 100644
--- a/compositing/compositor.rs
+++ b/compositing/compositor.rs
@@ -1491,19 +1491,15 @@ impl<Window: WindowMethods> IOCompositor<Window> {
};
if wait_for_stable_image {
- match self.is_rea... | 1 | 9 | 13 |
48971258961f98d7c929806249cda4ef77189638 | Boris Zbarsky | 2017-06-19T18:46:52 | servo: Merge #17409 - Add pseudo-classes to match on the state of the "dir" attribute (from bzbarsky:dir-pseudo-classes); r=emilio
Fixes the servo parts of Gecko bug 1373798 <https://bugzilla.mozilla.org/show_bug.cgi?id=1373798>
<!-- Please describe your changes on the following line: -->
---
<!-- Thank you for cont... | diff --git a/style/element_state.rs b/style/element_state.rs
index 809f01218..d8b4d6803 100644
--- a/style/element_state.rs
+++ b/style/element_state.rs
@@ -120,6 +120,18 @@ bitflags! {
const IN_LTR_STATE = 1 << 44,
/// State that elements that match :dir(rtl) are in.
const IN_RTL_STATE = 1 <... | 5 | 94 | 70 |
28fae17ffdf2d3ef0c2f4bc12d35b3fa57d5308e | Mantaroh Yoshinaga | 2017-06-19T03:28:16 | servo: Merge #17288 - Make filter property animatable (from mantaroh:filter); r=hiro
<!-- Please describe your changes on the following line: -->
This is a PR for https://bugzilla.mozilla.org/show_bug.cgi?id=1362897
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is comp... | diff --git a/style/gecko/url.rs b/style/gecko/url.rs
index 192d43ef5..bafab1c31 100644
--- a/style/gecko/url.rs
+++ b/style/gecko/url.rs
@@ -5,6 +5,7 @@
//! Common handling for the specified value CSS url() values.
use gecko_bindings::structs::{ServoBundledURI, URLExtraData};
+use gecko_bindings::structs::mozilla::... | 4 | 360 | 36 |
1d1fb70ddcc4560bab48b1fae28a342be2ffb96c | Cameron McCormack | 2017-06-19T01:34:05 | servo: Merge #17397 - style: Make checks for attribute/state dependencies take stylist dirty state into account (from heycam:might-have-attr-state-fixes); r=emilio
This is a follow-up Servo-side change for https://bugzilla.mozilla.org/show_bug.cgi?id=1352306
which caused some test failures on landing.
Source-Repo: ht... | diff --git a/style/stylist.rs b/style/stylist.rs
index c205703a0..ae63d62a5 100644
--- a/style/stylist.rs
+++ b/style/stylist.rs
@@ -546,13 +546,29 @@ impl Stylist {
pub fn might_have_attribute_dependency(&self,
local_name: &LocalName)
... | 1 | 17 | 1 |
4815bae36a24906b91517fbf2f9652206c9ff3a7 | Boris Zbarsky | 2017-06-18T09:14:22 | servo: Merge #17386 - :-moz-locale-dir shouldn't be a revalidation selector (from bzbarsky:locale-dir-not-revalidation); r=emilio
Fixes Gecko bug 1374019 <https://bugzilla.mozilla.org/show_bug.cgi?id=1374019>
<!-- Please describe your changes on the following line: -->
---
<!-- Thank you for contributing to Servo! P... | diff --git a/style/gecko/selector_parser.rs b/style/gecko/selector_parser.rs
index 334ba1519..c9bd6c7ed 100644
--- a/style/gecko/selector_parser.rs
+++ b/style/gecko/selector_parser.rs
@@ -176,16 +176,29 @@ impl NonTSPseudoClass {
/// Returns true if the given pseudoclass should trigger style sharing cache reval... | 1 | 18 | 5 |
fa85dc0e8718dfa90c2c12fa104860cda47dd40a | Emilio Cobos Álvarez | 2017-06-17T13:20:45 | servo: Merge #17384 - style: Clean up some stylist code and make it slightly more efficient (from emilio:stylist-attr-dep); r=nox
Source-Repo: https://github.com/servo/servo
Source-Revision: c5433277b44467ccbfd00024000ded5769157e3c | diff --git a/style/stylist.rs b/style/stylist.rs
index a5a6313b3..c205703a0 100644
--- a/style/stylist.rs
+++ b/style/stylist.rs
@@ -549,7 +549,7 @@ impl Stylist {
if *local_name == local_name!("style") {
self.style_attribute_dependency
} else {
- self.attribute_dependencies.mi... | 1 | 6 | 11 |
339c19cb133315a101fa16efecf84a6ccdeebe2f | Anthony Ramine | 2017-06-17T11:53:32 | servo: Merge #17382 - Derive more ToCss impls (from servo:derive-all-the-things); r=emilio
Source-Repo: https://github.com/servo/servo
Source-Revision: effd6f2f877e767352b45fc35c8066a56c1612b7 | diff --git a/layout/flex.rs b/layout/flex.rs
index e2bd1c083..30295eabf 100644
--- a/layout/flex.rs
+++ b/layout/flex.rs
@@ -25,8 +25,9 @@ use style::computed_values::border_collapse;
use style::logical_geometry::{Direction, LogicalSize};
use style::properties::ServoComputedValues;
use style::servo::restyle_damage::... | 24 | 160 | 350 |
4a89b6fcdbf0edb7a586aa88c2d32334e4f88c4d | Nikhil Shagrithaya | 2017-06-17T09:21:19 | servo: Merge #17037 - Added Async HTML Tokenizer (from cynicaldevil:impl-Sink); r=nox
Design: I realized having two different parsers for sync and async was wrong, because the API for both was fundamentally the same. All I needed to do was create another Tokenizer, because `ParseNode` ( representation for nodes which ... | diff --git a/script/dom/servoparser/async_html.rs b/script/dom/servoparser/async_html.rs
new file mode 100644
index 000000000..e13f8169f
--- /dev/null
+++ b/script/dom/servoparser/async_html.rs
@@ -0,0 +1,493 @@
+/* This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of th... | 2 | 514 | 5 |
00dc8456ca71d7350031bf7c048a22f698aa7de6 | Imanol Fernandez | 2017-06-17T02:34:23 | servo: Merge #17380 - Fix over-alignment assert crash on Android (from MortimerGoro:over_alignment); r=bholley
<!-- Please describe your changes on the following line: -->
See https://github.com/servo/servo/issues/17320
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is... | diff --git a/servo_arc/lib.rs b/servo_arc/lib.rs
index 03f502df2..cf4578d0e 100644
--- a/servo_arc/lib.rs
+++ b/servo_arc/lib.rs
@@ -527,12 +527,16 @@ impl<H, T> Arc<HeaderSlice<H, [T]>> {
//
// To avoid alignment issues, we allocate words rather than bytes,
// rounding up to the ... | 1 | 18 | 6 |
dd49fa3c55ae63b2be90a18eb64c4324fef09244 | Josh Matthews | 2017-06-17T00:37:26 | servo: Merge #17360 - Hold stderr lock when using stdout through Console APIs (from servo:stderr); r=emilio
This addresses a longstanding source of intermittent test failures where the stderr and stdout outputs get interleaved and the test harness becomes confused.
---
- [X] `./mach build -d` does not report any erro... | diff --git a/script/dom/console.rs b/script/dom/console.rs
index d9df56ebe..7aa99c2fa 100644
--- a/script/dom/console.rs
+++ b/script/dom/console.rs
@@ -7,6 +7,7 @@ use dom::bindings::inheritance::Castable;
use dom::bindings::str::DOMString;
use dom::globalscope::GlobalScope;
use dom::workerglobalscope::WorkerGlobal... | 1 | 65 | 37 |
1bfa84ef4a11dfbed05e6d1319c9b584b94e219c | Anthony Ramine | 2017-06-16T22:46:12 | servo: Merge #17356 - Minor improvements to #[derive(ToCss)] (from servo:derive-all-the-things); r=SimonSapin
Source-Repo: https://github.com/servo/servo
Source-Revision: 2b02a444ea57448fb30408cba5297101bf9b310d | diff --git a/style_derive/Cargo.toml b/style_derive/Cargo.toml
index d56f32256..80356dd64 100644
--- a/style_derive/Cargo.toml
+++ b/style_derive/Cargo.toml
@@ -11,5 +11,5 @@ proc-macro = true
[dependencies]
quote = "0.3"
-syn = "0.11"
+syn = { version = "0.11", features = ["visit"] }
synstructure = "0.5.2"
diff -... | 2 | 36 | 8 |
2f88e92082920d01ed0e06dce959e87b1c44a06f | Bobby Holley | 2017-06-16T21:13:38 | servo: Merge #17368 - Rule tree gc never runs until teardown (from bholley:rule_tree_gc); r=emilio
https://bugzilla.mozilla.org/show_bug.cgi?id=1373725
Source-Repo: https://github.com/servo/servo
Source-Revision: 2a856edf57dcad7e65861ffe12f5aae16db3aa9c | diff --git a/style/rule_tree/mod.rs b/style/rule_tree/mod.rs
index 198999f61..18c897eae 100644
--- a/style/rule_tree/mod.rs
+++ b/style/rule_tree/mod.rs
@@ -122,6 +122,11 @@ impl RuleTree {
self.root.clone()
}
+ /// Returns true if there are no nodes in the tree aside from the rule node.
+ pub fn ... | 2 | 56 | 21 |
4e20db45cf9247bcf267a124e7b42e447c92607b | Jonathan Chan | 2017-06-16T18:04:51 | servo: Merge #17284 - Propagate changes in custom properties' computed values to descendants (from jyc:custom-properties-cascade); r=emilio
If ComputedValues.custom_properties differs between the old and new
ComputedValues, indicate that we have to propogate changes to
descendants by setting child_cascade_requirement ... | diff --git a/style/custom_properties.rs b/style/custom_properties.rs
index f0528e24f..09834b92b 100644
--- a/style/custom_properties.rs
+++ b/style/custom_properties.rs
@@ -66,7 +66,7 @@ pub struct BorrowedSpecifiedValue<'a> {
/// A computed value is just a set of tokens as well, until we resolve variables
/// prop... | 3 | 18 | 2 |
ea88b833b88a088aac20196f07c734f08a639ac3 | Simon Sapin | 2017-06-16T12:03:18 | servo: Merge #17355 - Bump serde to 1.0 (from servo:serdeup); r=nox
This is a rebase of #17325 with `[replace]` entries removed, a bunch more dependencies updated, and some more compile fixes. Original work by @Eijebong, thanks a lot!
Source-Repo: https://github.com/servo/servo
Source-Revision: 66c130d55aa0d7af1104c0... | diff --git a/atoms/Cargo.toml b/atoms/Cargo.toml
index dc22f8b1d..449f627fe 100644
--- a/atoms/Cargo.toml
+++ b/atoms/Cargo.toml
@@ -11,7 +11,7 @@ workspace = "../.."
path = "lib.rs"
[dependencies]
-string_cache = {version = "0.5", features = ["heapsize"]}
+string_cache = {version = "0.6", features = ["heapsize"]}
... | 63 | 160 | 208 |
95a48e9571aa76dd116c46ad3460d7856ce09737 | Glenn Watson | 2017-06-16T08:21:05 | servo: Merge #17352 - Update WR (CPU text optimizations, image format renames) (from glennw:update-wr-faster-text); r=emilio
Source-Repo: https://github.com/servo/servo
Source-Revision: e1bce241291683ee61abab042d0c808ae5396e91 | diff --git a/canvas/canvas_paint_thread.rs b/canvas/canvas_paint_thread.rs
index 94a235d78..68cb96cd6 100644
--- a/canvas/canvas_paint_thread.rs
+++ b/canvas/canvas_paint_thread.rs
@@ -564,7 +564,7 @@ impl<'a> CanvasPaintThread<'a> {
width: size.width as u32,
height: size.height as u32... | 8 | 12 | 12 |
5e06153beeb5d22aae254f0d174eaf43b011909f | Xidorn Quan | 2017-06-16T06:51:16 | servo: Merge #17353 - Make counter style 'disc' not overridable (from upsuper:counter-style-disc); r=dbaron
This is the Servo side change for [bug 1372488](https://bugzilla.mozilla.org/show_bug.cgi?id=1372488).
Source-Repo: https://github.com/servo/servo
Source-Revision: 32f82959f89ccd0d6f92058f22f11f2cc7d21d52 | diff --git a/style/stylesheets/rule_parser.rs b/style/stylesheets/rule_parser.rs
index 0cecb8bf3..e454b529c 100644
--- a/style/stylesheets/rule_parser.rs
+++ b/style/stylesheets/rule_parser.rs
@@ -365,10 +365,10 @@ impl<'a, 'b, 'i> AtRuleParser<'i> for NestedRuleParser<'a, 'b> {
return Err(StylePar... | 1 | 4 | 4 |
f56aeb61e73ca95ffaa17e46c6f6668b1978a58b | Cameron McCormack | 2017-06-16T05:50:53 | servo: Merge #17351 - style: Tweak an import (from heycam:nit); r=emilio
Source-Repo: https://github.com/servo/servo
Source-Revision: 4d54f2c9bbc700f06cfef7d85df5f43bdbcf085d | diff --git a/style/style_adjuster.rs b/style/style_adjuster.rs
index 19ceecedc..4c4a45187 100644
--- a/style/style_adjuster.rs
+++ b/style/style_adjuster.rs
@@ -8,8 +8,6 @@
use app_units::Au;
use properties::{self, CascadeFlags, ComputedValues};
use properties::{SKIP_ROOT_AND_ITEM_BASED_DISPLAY_FIXUP, StyleBuilder};... | 1 | 2 | 2 |
8ee6ec70fe5bfe434479fee8dc2a23e140f4da82 | Emilio Cobos Álvarez | 2017-06-16T03:28:56 | servo: Merge #17348 - style: Inline RestyleData (from emilio:bup); r=bholley
Bug: 1368236
MozReview-Commit-ID: 49s3SO0PMHf
Source-Repo: https://github.com/servo/servo
Source-Revision: 33766b2714443399808c950e5bb74b1f124f2bc4 | diff --git a/layout/wrapper.rs b/layout/wrapper.rs
index 4ae7c403e..87fe65bb3 100644
--- a/layout/wrapper.rs
+++ b/layout/wrapper.rs
@@ -171,19 +171,14 @@ impl<T: ThreadSafeLayoutNode> ThreadSafeLayoutNodeHelpers for T {
let damage = {
let data = node.get_raw_data().unwrap();
- if let... | 9 | 169 | 192 |
4531f7636f9994fd7adacf55f4ebb70b876e7cdc | Cameron McCormack | 2017-06-16T01:58:01 | servo: Merge #17350 - style: Adjust display:contents to display:inline for NAC (including ::before/::after) (from heycam:gencon-contents); r=emilio
From https://bugzilla.mozilla.org/show_bug.cgi?id=1354879.
Source-Repo: https://github.com/servo/servo
Source-Revision: e3a52536b650f4aeb951b474936a0b67821f112e | diff --git a/style/matching.rs b/style/matching.rs
index e10c19baa..320546147 100644
--- a/style/matching.rs
+++ b/style/matching.rs
@@ -17,7 +17,7 @@ use invalidation::element::restyle_hints::{RESTYLE_CSS_ANIMATIONS, RESTYLE_CSS_T
use invalidation::element::restyle_hints::{RESTYLE_SMIL, RESTYLE_STYLE_ATTRIBUTE};
use... | 3 | 56 | 24 |
d3c08601fde8decf4360765d5809e590d0dfda02 | Ellen Marie Dash | 2017-06-15T23:58:20 | servo: Merge #17347 - Fix setting img src before window.onload causing panic (from duckinator:fix-issue-17319); r=mbrubeck
<!-- Please describe your changes on the following line: -->
Setting an image source asynchronously (e.g. using `setTimeout` or in the callback of an `XMLHttpRequest`) before `window.onload` fire... | diff --git a/script/dom/htmlimageelement.rs b/script/dom/htmlimageelement.rs
index 0eaab8e58..6a4b67a6a 100644
--- a/script/dom/htmlimageelement.rs
+++ b/script/dom/htmlimageelement.rs
@@ -493,6 +493,7 @@ impl HTMLImageElement {
request.image = None;
request.metadata = None;
let document = do... | 1 | 1 | 0 |
f1ac06edae59aa53249c265720f81ed94d409036 | hinaria | 2017-06-15T22:42:38 | servo: Merge #17340 - windows: fix line height handling (from hinaria:master); r=jdm
hi there!
on windows, this change properly scales a font's line height by its size.
previously, line height was not scaled to the font's size at all, which meant line heights become worse and worse the further you scaled away from t... | diff --git a/gfx/platform/windows/font.rs b/gfx/platform/windows/font.rs
index 6046a7077..5746739a1 100644
--- a/gfx/platform/windows/font.rs
+++ b/gfx/platform/windows/font.rs
@@ -372,7 +372,7 @@ impl FontHandleMethods for FontHandle {
descent: au_from_du_s(dm.descent as i32),
max_ad... | 1 | 1 | 1 |
29af574a135024b256fdf54d839d7889999929e4 | Anthony Ramine | 2017-06-15T20:37:04 | servo: Merge #17338 - Derive ToCss for computed LengthOrPercentage types (from servo:derive-all-the-things); r=emilio,waffles
Source-Repo: https://github.com/servo/servo
Source-Revision: 0142d193a3fde057718612028d9c1676e046b816 | diff --git a/layout/block.rs b/layout/block.rs
index 0b09b723a..6a3db5a61 100644
--- a/layout/block.rs
+++ b/layout/block.rs
@@ -322,7 +322,7 @@ impl CandidateBSizeIterator {
let block_size = match (fragment.style.content_block_size(), block_container_block_size) {
(LengthOrPercentageOrAuto::Per... | 20 | 118 | 136 |
fdeaac83526b68e1e332299167d223e259334712 | budaim | 2017-06-15T19:36:19 | servo: Merge #17323 - Avoid panic when reloading a page with mouse event handlers (from ibmandura:issue16057); r=jdm
This PR fixes issue #16057, by nullifying `topmost_mouse_over_target` inside of the `handle_exit_pipeline_msg` method, in case owner document is the same as the pipeline document that is being destroyed... | diff --git a/script/script_thread.rs b/script/script_thread.rs
index 941d80293..c32976795 100644
--- a/script/script_thread.rs
+++ b/script/script_thread.rs
@@ -1650,6 +1650,13 @@ impl ScriptThread {
let load = self.incomplete_loads.borrow_mut().remove(idx);
load.layout_chan.clone()
}... | 1 | 7 | 0 |
3007c478be9162db7564d17bdc5b858180033190 | Emilio Cobos Álvarez | 2017-06-15T18:34:12 | servo: Merge #17341 - style: Bindgen bump (from emilio:bup); r=bholley
To grab https://github.com/servo/rust-bindgen/pull/752.
Source-Repo: https://github.com/servo/servo
Source-Revision: d903bd883ee064b295944af28a76a6223f2bc56d | diff --git a/style/Cargo.toml b/style/Cargo.toml
index c3670d90a..4592cd9ba 100644
--- a/style/Cargo.toml
+++ b/style/Cargo.toml
@@ -78,7 +78,7 @@ kernel32-sys = "0.2"
[build-dependencies]
lazy_static = "0.2"
log = "0.3"
-bindgen = { version = "0.25.4", optional = true }
+bindgen = { version = "0.25.5", optional = t... | 1 | 1 | 1 |
bd1da7a42aa6532d16c54f5a7846e0d42dd3c603 | Bobby Holley | 2017-06-15T17:34:49 | servo: Merge #17334 - Make the traversal work better with the style sharing cache (from bholley:breadth_first_traversal); r=emilio
https://bugzilla.mozilla.org/show_bug.cgi?id=1365692
Source-Repo: https://github.com/servo/servo
Source-Revision: 6ec95ecb9f5159eafa8d3051c259d566d518f29d | diff --git a/style/gecko/global_style_data.rs b/style/gecko/global_style_data.rs
index 2ba8749e2..0f80a1881 100644
--- a/style/gecko/global_style_data.rs
+++ b/style/gecko/global_style_data.rs
@@ -80,6 +80,12 @@ lazy_static! {
} else {
let configuration = rayon::Configuration::new()
... | 2 | 51 | 41 |
da462d16d0a59d0a663aedf315514883192c6a64 | Anthony Ramine | 2017-06-15T12:24:17 | servo: Merge #17337 - Use CustomIdent in more properties (from servo:derive-all-the-things); r=emilio
Source-Repo: https://github.com/servo/servo
Source-Revision: 4b633c8637ec8bf5da7538a04506941325807701 | diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs
index 8c4cdb4a0..c7a46b5e5 100644
--- a/style/properties/gecko.mako.rs
+++ b/style/properties/gecko.mako.rs
@@ -63,8 +63,8 @@ use std::mem::{forget, transmute, zeroed};
use std::ptr;
use stylearc::Arc;
use std::cmp;
+use values::{Auto, Cust... | 4 | 44 | 75 |
420b2d77971cb4fb25c96860a61a0c884361a89f | Fernando Jiménez Moreno | 2017-06-15T08:36:22 | servo: Merge #17324 - stylo: set location for NestedRuleParser during prelude parsing (from ferjm:bug1371393.column); r=SimonSapin
From https://bugzilla.mozilla.org/show_bug.cgi?id=1371393
Source-Repo: https://github.com/servo/servo
Source-Revision: b0392dbf39d36f19cd16ec06e29b6aca6e6135e2 | diff --git a/style/stylesheets/rule_parser.rs b/style/stylesheets/rule_parser.rs
index 34db0c1d6..0cecb8bf3 100644
--- a/style/stylesheets/rule_parser.rs
+++ b/style/stylesheets/rule_parser.rs
@@ -257,15 +257,19 @@ impl<'a, 'i> AtRuleParser<'i> for TopLevelRuleParser<'a> {
}
}
+pub struct QualifiedRuleParserPre... | 1 | 20 | 11 |
695674c837b25c5f446200b205344bdb2b40be17 | Bobby Holley | 2017-06-15T02:12:30 | servo: Merge #17332 - Bump rayon to 0.8 (from bholley:bump_rayon_0_8); r=glennw
Source-Repo: https://github.com/servo/servo
Source-Revision: e0820c8654489a226e3f1348c1e134e890cb84c3 | diff --git a/layout/Cargo.toml b/layout/Cargo.toml
index a08ee6c83..effcbe0d4 100644
--- a/layout/Cargo.toml
+++ b/layout/Cargo.toml
@@ -29,7 +29,7 @@ ordered-float = "0.4"
parking_lot = "0.3.3"
profile_traits = {path = "../profile_traits"}
range = {path = "../range"}
-rayon = "0.7.1"
+rayon = "0.8"
script_layout_i... | 3 | 5 | 5 |
1a0e9f8c54f9f6ab3a5f6576f1b89ce6c2f2db8d | Emilio Cobos Álvarez | 2017-06-15T01:19:21 | servo: Merge #17330 - style: Avoid some branches in common RuleIterator::next cases (from emilio:rules-iter-perf); r=heycam
I saw this function appear in the profiles at #17329.
It was under set_device, which isn't a Stylo path, but probably worth there
anyway.
This reduces the reported overhead of RulesIterator::ne... | diff --git a/style/stylesheets/rules_iterator.rs b/style/stylesheets/rules_iterator.rs
index cbcaf9e01..05dd2e716 100644
--- a/style/stylesheets/rules_iterator.rs
+++ b/style/stylesheets/rules_iterator.rs
@@ -68,8 +68,7 @@ impl<'a, 'b, C> Iterator for RulesIterator<'a, 'b, C>
}
let rule;
- ... | 1 | 18 | 20 |
d9b04c251e85de6df5f0ac64a944ae0acb8ba2e7 | Emilio Cobos Álvarez | 2017-06-14T23:03:35 | servo: Merge #17328 - style: update bindgen (from emilio:bindgenup); r=upsuper
Source-Repo: https://github.com/servo/servo
Source-Revision: 2209566195bf7f8751e720ce227ca38cd7be2220 | diff --git a/style/Cargo.toml b/style/Cargo.toml
index 0c8d02f51..13d6d007c 100644
--- a/style/Cargo.toml
+++ b/style/Cargo.toml
@@ -78,7 +78,7 @@ kernel32-sys = "0.2"
[build-dependencies]
lazy_static = "0.2"
log = "0.3"
-bindgen = { version = "0.25.3", optional = true }
+bindgen = { version = "0.25.4", optional = t... | 1 | 1 | 1 |
4c90dd21985b8b43e2a3d3ada049cc02a5a33ed9 | Emilio Cobos Álvarez | 2017-06-14T15:32:27 | servo: Merge #17315 - style: Avoid quadratic time serialization of a declaration block (from emilio:quadratic-serialization); r=SimonSapin
At least when the longhands aren't custom properties.
We should also look into not serializing the style attribute eagerly when it's
not needed... But a lot of code currently rely... | diff --git a/style/properties/declaration_block.rs b/style/properties/declaration_block.rs
index 0cc0aeca2..efbccd9f9 100644
--- a/style/properties/declaration_block.rs
+++ b/style/properties/declaration_block.rs
@@ -14,6 +14,7 @@ use parser::{ParserContext, log_css_error};
use properties::animated_properties::Animati... | 2 | 72 | 58 |
81d5cf63ad95ba2a1924fc7fae5dfe74ce0be231 | Ting-Yu Lin | 2017-06-14T12:11:31 | servo: Merge #17318 - stylo: Fix pseudo element matching for XBL stylesheets (Bug 1371577) (from aethanyc:fix-pseudo-xbl-stylesheet); r=emilio
This change is reviewed in https://bugzilla.mozilla.org/show_bug.cgi?id=1371577#c9
Source-Repo: https://github.com/servo/servo
Source-Revision: 5dce166266d1f74e2ae88dbe52ca5ce... | diff --git a/style/dom.rs b/style/dom.rs
index 5a6cc5ea9..795eb51c2 100644
--- a/style/dom.rs
+++ b/style/dom.rs
@@ -573,7 +573,8 @@ pub trait TElement : Eq + PartialEq + Debug + Hash + Sized + Copy + Clone +
/// Gets declarations from XBL bindings from the element. Only gecko element could have this.
fn ge... | 3 | 58 | 26 |
1bc1e04a1deae889f402f939847a770e9e4d8502 | Emilio Cobos Álvarez | 2017-06-14T11:16:24 | servo: Merge #17317 - Kill StoredRestyleHint, and shrink RestyleData (from emilio:die-storedrestylehint-die); r=bholley
These are the already-reviewed parts of bug 1368236.
Source-Repo: https://github.com/servo/servo
Source-Revision: 8837c80540327db28a6569f0661816b998b65b9f | diff --git a/layout_thread/lib.rs b/layout_thread/lib.rs
index 364ce2745..f381caed9 100644
--- a/layout_thread/lib.rs
+++ b/layout_thread/lib.rs
@@ -111,9 +111,9 @@ use std::thread;
use style::animation::Animation;
use style::context::{QuirksMode, ReflowGoal, SharedStyleContext};
use style::context::{StyleSystemOpti... | 6 | 76 | 165 |
85b2832c37b6bbd08b05b044726ae3fdc979c39f | Xidorn Quan | 2017-06-14T10:07:27 | servo: Merge #17316 - Resolve counter style during parallel traversal when possible (from upsuper:bug1371976); r=heycam
This is the Servo side change of [bug 1371976](https://bugzilla.mozilla.org/show_bug.cgi?id=1371976).
Source-Repo: https://github.com/servo/servo
Source-Revision: 63a5ab154eabf72595477f8136e371127bc... | diff --git a/style/gecko/generated/bindings.rs b/style/gecko/generated/bindings.rs
index c6e85dff3..38b86d87c 100644
--- a/style/gecko/generated/bindings.rs
+++ b/style/gecko/generated/bindings.rs
@@ -906,7 +906,9 @@ extern "C" {
}
extern "C" {
pub fn Gecko_SetCounterStyleToName(ptr: *mut CounterStylePtr,
- ... | 4 | 20 | 12 |
a8e29baa410e2a1381bd6efab9f0f553a1386dd5 | Jeremy Chen | 2017-06-14T05:23:21 | servo: Merge #17310 - stylo: support font-variant shorthand (from chenpighead:stylo-font-variant); r=xidorn
From gecko bug: [Bug 1356134](https://bugzilla.mozilla.org/show_bug.cgi?id=1356134)
Source-Repo: https://github.com/servo/servo
Source-Revision: c6da6ba06057ec488521edb19f33592f4e98c3d4 | diff --git a/style/properties/longhand/font.mako.rs b/style/properties/longhand/font.mako.rs
index ed0da5f44..be7a8d1e1 100644
--- a/style/properties/longhand/font.mako.rs
+++ b/style/properties/longhand/font.mako.rs
@@ -1376,21 +1376,21 @@ ${helpers.single_keyword_system("font-kerning",
return Ok(Specifie... | 2 | 119 | 85 |
7222fb5853bb5ee7be822492d894a78604dca6dd | Mantaroh Yoshinaga | 2017-06-14T04:28:48 | servo: Merge #17306 - Return zero when computing distance of Option with both value is none (from mantaroh:paced); r=birtles
<!-- Please describe your changes on the following line: -->
This is a PR for https://bugzilla.mozilla.org/show_bug.cgi?id=1371480
---
<!-- Thank you for contributing to Servo! Please replace e... | diff --git a/style/properties/helpers/animated_properties.mako.rs b/style/properties/helpers/animated_properties.mako.rs
index a03d55070..857c0b104 100644
--- a/style/properties/helpers/animated_properties.mako.rs
+++ b/style/properties/helpers/animated_properties.mako.rs
@@ -853,6 +853,7 @@ impl <T> Animatable for Opt... | 1 | 1 | 0 |
063ab21d512afc06e44d9a24252c666f40c2790c | Hiroyuki Ikezoe | 2017-06-14T03:28:18 | servo: Merge #17305 - Don't process RestyleKind::MatchAndCascade during animation-only rest… (from hiikezoe:restyle-kind-fix); r=emilio
…yle.
<!-- Please describe your changes on the following line: -->
https://bugzilla.mozilla.org/show_bug.cgi?id=1372335
---
- [X] `./mach build -d` does not report any errors
- [X] ... | diff --git a/style/data.rs b/style/data.rs
index 677b4d785..d96cfafa9 100644
--- a/style/data.rs
+++ b/style/data.rs
@@ -509,6 +509,7 @@ pub struct ElementData {
}
/// The kind of restyle that a single element should do.
+#[derive(Debug)]
pub enum RestyleKind {
/// We need to run selector matching plus re-cas... | 2 | 25 | 3 |
95c310c9aaa61fccb79d9169a27767749e94313f | Hiroyuki Ikezoe | 2017-06-14T02:25:09 | servo: Merge #17304 - Allow negative length for SMIL (from hiikezoe:allow-negative-length-for-SMIL); r=emilio
<!-- Please describe your changes on the following line: -->
https://bugzilla.mozilla.org/show_bug.cgi?id=1369588
---
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report... | diff --git a/script/dom/css.rs b/script/dom/css.rs
index 66f522b23..31ca21909 100644
--- a/script/dom/css.rs
+++ b/script/dom/css.rs
@@ -10,9 +10,10 @@ use dom::bindings::str::DOMString;
use dom::window::Window;
use dom_struct::dom_struct;
use style::context::QuirksMode;
-use style::parser::{PARSING_MODE_DEFAULT, Pa... | 20 | 112 | 88 |
7a91de632fd962c13d6e5f10734bcdc220d439d0 | Emilio Cobos Álvarez | 2017-06-13T20:01:16 | servo: Merge #17294 - style: Less refcount churn while inserting in the rule tree (from emilio:less-refcount-churn); r=bholley
There's no need for it since we know no GC is happening while we're doing it.
Source-Repo: https://github.com/servo/servo
Source-Revision: 849bdc958c1aff230d308ecb5551aba4866dbf7a | diff --git a/style/rule_tree/mod.rs b/style/rule_tree/mod.rs
index c1a3b2b69..198999f61 100644
--- a/style/rule_tree/mod.rs
+++ b/style/rule_tree/mod.rs
@@ -572,6 +572,17 @@ impl RuleNode {
self.parent.is_none()
}
+ fn next_sibling(&self) -> Option<WeakRuleNode> {
+ // We use acquire semantics... | 1 | 40 | 30 |
333f51dea365566c55d357118257ba1848f43e45 | Alan Jeffrey | 2017-06-13T17:31:25 | servo: Merge #17298 - Added Debug implementations (from asajeffrey:script-more-debug-impls); r=mbrubeck
<!-- Please describe your changes on the following line: -->
Added enough `Debug` implementations to be able to debug script thread message processing.
---
<!-- Thank you for contributing to Servo! Please replace ... | diff --git a/net_traits/image/base.rs b/net_traits/image/base.rs
index a52ed0e71..ccdb11306 100644
--- a/net_traits/image/base.rs
+++ b/net_traits/image/base.rs
@@ -4,9 +4,10 @@
use ipc_channel::ipc::IpcSharedMemory;
use piston_image::{self, DynamicImage, ImageFormat};
+use std::fmt;
use webrender_traits;
-#[der... | 7 | 53 | 6 |
30a4b44ce08c2f62a78ea32808cb32596560696b | Anthony Ramine | 2017-06-13T16:31:19 | servo: Merge #17299 - Revert "Derive ToCss for MozImageRect" (from servo:derive-all-the-things); r=emilio
This reverts commit fe19c3810cd20a2a48dd054386f95462a3513e4c.
Source-Repo: https://github.com/servo/servo
Source-Revision: fe573c1ce9a7cbacf69a846ad966c429faa61703 | diff --git a/style/values/computed/image.rs b/style/values/computed/image.rs
index 9eb6e5205..3718be2fb 100644
--- a/style/values/computed/image.rs
+++ b/style/values/computed/image.rs
@@ -17,7 +17,7 @@ use values::computed::position::Position;
use values::generics::image::{CompatMode, ColorStop as GenericColorStop, E... | 5 | 39 | 21 |
9526ec787e9f8c57a9dd202e879f26f5fe8af579 | Nazım Can Altınova | 2017-06-13T15:34:04 | servo: Merge #17296 - Handle PseudoElement cases in :active and :hover quirk (from canaltinova:pseudo-quirk); r=bholley
Reviewed by bholley in bugzilla bug.
---
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix [Bug 1371963](https://bugzilla... | diff --git a/selectors/matching.rs b/selectors/matching.rs
index 3ab8f83c0..62cd7ee54 100644
--- a/selectors/matching.rs
+++ b/selectors/matching.rs
@@ -66,11 +66,12 @@ pub struct LocalMatchingContext<'a, 'b: 'a, Impl: SelectorImpl> {
/// been advanced partway through the current compound selector, and the callee ... | 2 | 22 | 13 |
ec1c85043cf50d1f9cb261ed69ce00ad1ff0b675 | Alan Jeffrey | 2017-06-13T14:38:12 | servo: Merge #17278 - Clear webrender image id when resizing a canvas (from asajeffrey:canvas-clear-webrender-image-key-when-resizing); r=emilio
<!-- Please describe your changes on the following line: -->
Webrender isn't very happy if images change size, so clear the webrender image key when resizing a canvas.
---
... | diff --git a/canvas/canvas_paint_thread.rs b/canvas/canvas_paint_thread.rs
index 39c633e12..b6360c638 100644
--- a/canvas/canvas_paint_thread.rs
+++ b/canvas/canvas_paint_thread.rs
@@ -547,6 +547,10 @@ impl<'a> CanvasPaintThread<'a> {
fn recreate(&mut self, size: Size2D<i32>) {
self.drawtarget = CanvasP... | 2 | 9 | 1 |
b329d12e51764a49e3549d29c120fcb55256c596 | Anthony Ramine | 2017-06-13T13:36:12 | servo: Merge #17293 - Derive two more ToCss impls (from servo:derive-all-the-things); r=emilio
Source-Repo: https://github.com/servo/servo
Source-Revision: 682af8bb19e3c4750f5e40868a3c2a43c100a160 | diff --git a/style/values/computed/image.rs b/style/values/computed/image.rs
index 3718be2fb..9eb6e5205 100644
--- a/style/values/computed/image.rs
+++ b/style/values/computed/image.rs
@@ -17,7 +17,7 @@ use values::computed::position::Position;
use values::generics::image::{CompatMode, ColorStop as GenericColorStop, E... | 5 | 34 | 56 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.