commit_hash stringlengths 40 40 | author stringlengths 1 57 | date timestamp[s]date 2010-07-26 04:45:09 2026-04-14 18:21:10 | message stringlengths 8 1.39M | diff stringlengths 68 51.2k | files_changed int64 1 136 | insertions int64 0 2.35k | deletions int64 0 1.9k |
|---|---|---|---|---|---|---|---|
39bec15b0d6c8199edb30cc1a9c62b34ef11c039 | Emilio Cobos Álvarez | 2017-07-17T00:53:41 | servo: Merge #17751 - style: Fix a typo that makes us resolve styles for the whole spin to the root (from emilio:embarrasing-typo); r=heycam
For undisplayed elements, at least.
Source-Repo: https://github.com/servo/servo
Source-Revision: d8ba8cad58a21210270faf2b337bef4f1c44aad6 | diff --git a/style/traversal.rs b/style/traversal.rs
index 1038e6e20..485024627 100644
--- a/style/traversal.rs
+++ b/style/traversal.rs
@@ -449,7 +449,7 @@ where
let mut ancestor = element.traversal_parent();
while let Some(current) = ancestor {
if rule_inclusion == RuleInclusion::All {
- ... | 1 | 1 | 1 |
097d75c5eafe2f53ed77ec96f5d86f7443acb773 | Bobby Holley | 2017-07-15T22:07:51 | servo: Merge #17741 - Trim some fat from the traversal (from bholley:trim_traversal_fat); r=emilio
https://bugzilla.mozilla.org/show_bug.cgi?id=1380877
Source-Repo: https://github.com/servo/servo
Source-Revision: 17f99e2a7bb0d7eec167eac952f12a7feafd647d | diff --git a/layout/traversal.rs b/layout/traversal.rs
index cf75a47bb..f821b4a28 100644
--- a/layout/traversal.rs
+++ b/layout/traversal.rs
@@ -12,6 +12,7 @@ use flow::{CAN_BE_FRAGMENTED, Flow, ImmutableFlowUtils, PostorderFlowTraversal};
use script_layout_interface::wrapper_traits::{LayoutNode, ThreadSafeLayoutNode}... | 6 | 171 | 195 |
3058891f52fd87ee5749ab5459fbdfc0c48c833e | Pavel Sergeev | 2017-07-15T21:07:19 | servo: Merge #17745 - rustify if statements style (from SergeevPavel:cleanup); r=emilio
<!-- Please describe your changes on the following line: -->
Rewrite if statement in more rusty style.
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` wi... | diff --git a/style/properties/longhand/inherited_box.mako.rs b/style/properties/longhand/inherited_box.mako.rs
index b6830761a..56a11c0ce 100644
--- a/style/properties/longhand/inherited_box.mako.rs
+++ b/style/properties/longhand/inherited_box.mako.rs
@@ -164,11 +164,19 @@ ${helpers.single_keyword("image-rendering",
... | 1 | 13 | 5 |
1121ab635d824a424384ea069b283c37e1cca9f3 | Emilio Cobos Álvarez | 2017-07-15T18:11:13 | servo: Merge #17747 - style: Remove unused ElementStyles::styles_and_restyle_mut (from emilio:more-stuff-going-away); r=wafflespeanut
Never enough code going away.
Source-Repo: https://github.com/servo/servo
Source-Revision: 9d78008acb3cd89b35e66a88cd308b2dab8a1e38 | diff --git a/style/data.rs b/style/data.rs
index d7b169dee..658c7a42a 100644
--- a/style/data.rs
+++ b/style/data.rs
@@ -228,14 +228,6 @@ pub enum RestyleKind {
}
impl ElementData {
- /// Borrows both styles and restyle mutably at the same time.
- pub fn styles_and_restyle_mut(
- &mut self
- ) -> (&... | 1 | 0 | 8 |
e48de6953b17d9d4f93accdec769fe5d79561967 | Emilio Cobos Álvarez | 2017-07-15T17:04:25 | servo: Merge #17746 - style: Remove some no longer needed type arguments (from emilio:always-be-removing-the-ugly); r=wafflespeanut
Source-Repo: https://github.com/servo/servo
Source-Revision: c69cc88a6aec5a1bfa0630edf54ab90b0d49deee | diff --git a/style/traversal.rs b/style/traversal.rs
index b1a827be5..a5c624eb3 100644
--- a/style/traversal.rs
+++ b/style/traversal.rs
@@ -611,7 +611,7 @@ where
// Compute style for this element if necessary.
if compute_self {
- match compute_style(traversal, traversal_data, context, element, data)... | 1 | 4 | 7 |
b9c6b3f3811cc58b4447ce7ab7205d7f28d3a08a | Emilio Cobos Álvarez | 2017-07-15T14:44:08 | servo: Merge #17744 - script: Move the layout_wrapper outside of script (from emilio:ensure-data); r=nox
This allows us to have ensure_data() and clear_data() functions on the TElement
trait, instead of hacking around it adding methods in random traits.
This also allows us to do some further cleanup, which I'd rather... | diff --git a/layout/lib.rs b/layout/lib.rs
index 868892ea0..3527c3590 100644
--- a/layout/lib.rs
+++ b/layout/lib.rs
@@ -14,7 +14,6 @@ extern crate atomic_refcell;
#[macro_use]
extern crate bitflags;
extern crate canvas_traits;
-extern crate core;
extern crate euclid;
extern crate fnv;
extern crate gfx;
@@ -55,7 ... | 14 | 122 | 155 |
76b40e0cd3c68d316dbc94e5f0fd28a9d9f282aa | Jonathan Chan | 2017-07-15T01:54:45 | servo: Merge #17696 - Sync Servo / Gecko image-orientation rounding; pass as enum (from jyc:image-orientation-redux); r=Manishearth
Make Servo's rounding of image-orientation values agree with Gecko's,
and pass orientations directly as an enum instead of as angles.
Depends on a Gecko change to be subsequently landed ... | diff --git a/style/gecko/generated/bindings.rs b/style/gecko/generated/bindings.rs
index b1812da9a..8466b49a4 100644
--- a/style/gecko/generated/bindings.rs
+++ b/style/gecko/generated/bindings.rs
@@ -900,7 +900,7 @@ extern "C" {
}
extern "C" {
pub fn Gecko_SetImageOrientation(aVisibility: *mut nsStyleVisibility... | 4 | 85 | 29 |
acca3ed06363a0226da9934df3bb7a6650167d64 | Nazım Can Altınova | 2017-07-14T23:50:04 | servo: Merge #17737 - Convert TrackList's `values` field to store only TrackSize (from canaltinova:same-grid-but-better); r=Manishearth,wafflespeanut
It was storing both TrackSize and TrackRepeat before and TrackRepeat have to be
converted into sequence of TrackSize during serialization. Instead of doing this
in seria... | diff --git a/style/properties/shorthand/position.mako.rs b/style/properties/shorthand/position.mako.rs
index 0e630b555..af4f218ee 100644
--- a/style/properties/shorthand/position.mako.rs
+++ b/style/properties/shorthand/position.mako.rs
@@ -289,7 +289,7 @@
line_names.push(names);
strin... | 5 | 92 | 130 |
e058f87b6fffa3134e91e5a4b047c639a71387f0 | Paul Rouget | 2017-07-14T14:16:18 | servo: Merge #17726 - Remove WindowNavigateMsg (from paulrouget:rm_WindowNavigateMsg); r=jdm
Two reasons:
- We want to be able to jump further in history from the embedder.
- We don't want to have an extra translation step in the compositor, where `WindowNavigateMsg` is translated to `TraversalDirection`
---
<!-- Th... | diff --git a/compositing/compositor.rs b/compositing/compositor.rs
index a50c54577..707ccf830 100644
--- a/compositing/compositor.rs
+++ b/compositing/compositor.rs
@@ -35,7 +35,7 @@ use time::{precise_time_ns, precise_time_s};
use touch::{TouchHandler, TouchAction};
use webrender;
use webrender_api::{self, ClipId, ... | 2 | 4 | 14 |
f9780b22b1ddf5556a1e3daa64bbbf935473800b | Emilio Cobos Álvarez | 2017-07-14T12:01:48 | servo: Merge #17732 - style: Simplify font_size::SpecifiedValue::as_font_ratio (from emilio:font-size-as-ratio); r=nox
Source-Repo: https://github.com/servo/servo
Source-Revision: bb0c05dd2b4b81dfe86931c5e2dadcb1af11992d | diff --git a/style/properties/longhand/font.mako.rs b/style/properties/longhand/font.mako.rs
index 51af51699..972395496 100644
--- a/style/properties/longhand/font.mako.rs
+++ b/style/properties/longhand/font.mako.rs
@@ -768,23 +768,31 @@ ${helpers.single_keyword_system("font-variant-caps",
}, 1.)
... | 1 | 22 | 15 |
1d1f8046d696c6473efee77f9c68ef8c8976fa5d | Emilio Cobos Álvarez | 2017-07-14T10:04:38 | servo: Merge #17729 - stylo: Honor cursor: progress (from emilio:cursor-progress); r=heycam
Gecko maps it to NS_STYLE_CURSOR_SPINNING:
http://searchfox.org/mozilla-central/rev/cbd628b085ac809bf5a536109e6288aa91cbdff0/layout/style/nsCSSProps.cpp#1217
Source-Repo: https://github.com/servo/servo
Source-Revision: a24005... | diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs
index 72520d64b..ddb4f627a 100644
--- a/style/properties/gecko.mako.rs
+++ b/style/properties/gecko.mako.rs
@@ -4519,7 +4519,7 @@ clip-path
Cursor::Pointer => structs::NS_STYLE_CURSOR_POINTER,
Cursor::ContextM... | 1 | 1 | 1 |
874e595e361d9b8dcf5dec77396049b947e1eb4f | Emilio Cobos Álvarez | 2017-07-14T07:25:37 | servo: Merge #17713 - style: Kill some style sharing code (from emilio:less-code-is-lovely); r=heycam
It's trivial to do so after #17688.
Source-Repo: https://github.com/servo/servo
Source-Revision: 1c85c55d02458afffea0ec898e4560d62d447e4e | diff --git a/script_layout_interface/wrapper_traits.rs b/script_layout_interface/wrapper_traits.rs
index 05b24bca9..33116058a 100644
--- a/script_layout_interface/wrapper_traits.rs
+++ b/script_layout_interface/wrapper_traits.rs
@@ -346,7 +346,7 @@ pub trait ThreadSafeLayoutElement: Clone + Copy + Sized + Debug +
... | 5 | 55 | 206 |
d41526c99d05e2d00c9bbc68afcc6f508831cfc3 | Cameron McCormack | 2017-07-14T06:21:30 | servo: Merge #17724 - add support for Gecko style difference noticing custom property changes (from heycam:custom-props); r=emilio
From https://bugzilla.mozilla.org/show_bug.cgi?id=1380224.
Source-Repo: https://github.com/servo/servo
Source-Revision: 59f00f58260f935e20a30800eb6d13841cface56 | diff --git a/style/gecko/generated/bindings.rs b/style/gecko/generated/bindings.rs
index ab9e1f064..b1812da9a 100644
--- a/style/gecko/generated/bindings.rs
+++ b/style/gecko/generated/bindings.rs
@@ -2684,6 +2684,13 @@ extern "C" {
ServoComputedValuesBorrowed)
->... | 2 | 12 | 0 |
6b2590be2c925480d82a8d0b4b6c7c76f9ff5faa | Emilio Cobos Álvarez | 2017-07-14T01:57:47 | servo: Merge #17716 - style: Don't early return before updating the root font-size (from emilio:reconstruct-root); r=heycam
We never use the reconstruct path for the root, but feels less handwavy.
Source-Repo: https://github.com/servo/servo
Source-Revision: 394921e33cf9e9d83a7f25d30f007aa1fd0b8179 | diff --git a/style/matching.rs b/style/matching.rs
index bf31369ba..c8b6b26d6 100644
--- a/style/matching.rs
+++ b/style/matching.rs
@@ -482,11 +482,6 @@ pub trait MatchMethods : TElement {
}
}
- // Don't accumulate damage if we're in a restyle for reconstruction.
- if context.shar... | 1 | 5 | 5 |
86fa396979b4a5a1c0e5f54f0dc4bdb60b596695 | Hugh Gallagher | 2017-07-14T00:07:21 | servo: Merge #17720 - Removed unsused import (from hgallagher1993:local_branch); r=emilio
<!-- Please describe your changes on the following line: -->
Removed IS_ABSOLUTELY_POSITIONED from use flow::{self, BaseFlow, Flow, FlowClass, ForceNonfloatedFlag, IS_ABSOLUTELY_POSITIONED};
components/layout/inline.rs
---
<!--... | diff --git a/layout/inline.rs b/layout/inline.rs
index 9dcb670f2..de58b0525 100644
--- a/layout/inline.rs
+++ b/layout/inline.rs
@@ -11,7 +11,7 @@ use context::LayoutContext;
use display_list_builder::{DisplayListBuildState, InlineFlowDisplayListBuilding};
use euclid::{Point2D, Size2D};
use floats::{FloatKind, Float... | 1 | 1 | 1 |
6edb9ffa10cc8ac57e9a0d82a2acfa1b1a71dbe7 | Glenn Watson | 2017-07-13T23:13:41 | servo: Merge #17706 - Improve font layout in Linux / Freetype platforms (from glennw:linux-fonts); r=stshine,emilio
This patch contains two small changes:
* Fix the font size calculation that is passed to Freetype. This
now matches exactly how Webrender and Gecko calculate font size
to pass to layout.
* Enable li... | diff --git a/gfx/platform/freetype/font.rs b/gfx/platform/freetype/font.rs
index b7bcd92d4..f77f77be4 100644
--- a/gfx/platform/freetype/font.rs
+++ b/gfx/platform/freetype/font.rs
@@ -10,7 +10,7 @@ use freetype::freetype::{FT_F26Dot6, FT_Face, FT_FaceRec};
use freetype::freetype::{FT_Get_Char_Index, FT_Get_Postscript... | 1 | 17 | 8 |
ebad6ace572d93710d65d7e7880e284970836141 | Emilio Cobos Álvarez | 2017-07-13T22:05:07 | servo: Merge #17717 - style: Don't stop looking at the sharing cache for various reasons (from emilio:style-sharing-stop); r=bzbarsky
All the information that made those failures expensive is now lazily computed
and cached, or eagerly computed anyway, so seems not worth to stop iteration.
Source-Repo: https://github.... | diff --git a/style/sharing/mod.rs b/style/sharing/mod.rs
index c7c2c946c..f330f2260 100644
--- a/style/sharing/mod.rs
+++ b/style/sharing/mod.rs
@@ -595,16 +595,6 @@ impl<E: TElement> StyleSharingCandidateCache<E> {
}
Err(miss) => {
debug!("Cache miss: {:?}", miss)... | 1 | 0 | 10 |
93aac181d73a5e5a8359a2d30d56ba2cefc6b1bd | Jonathan Chan | 2017-07-13T21:00:13 | servo: Merge #17501 - Have CharacterData call children_changed on its parent when data is set (from jyc:Text-children_changed); r=emilio
**Can't run WPT on my computer, so pushing here to run tests 😢**
Have CharacterData.SetData call children_changed on its parent when
data is set (if it is a Text node) so that HTML... | diff --git a/script/dom/characterdata.rs b/script/dom/characterdata.rs
index be4fc4d0a..9db34a49f 100644
--- a/script/dom/characterdata.rs
+++ b/script/dom/characterdata.rs
@@ -6,6 +6,7 @@
use dom::bindings::cell::DOMRefCell;
use dom::bindings::codegen::Bindings::CharacterDataBinding::CharacterDataMethods;
+use dom... | 3 | 24 | 1 |
92be604a9087c4cfdcf796156eac0a76dedab448 | Simon Sapin | 2017-07-13T19:56:56 | servo: Merge #17714 - Update to rustc 1.20.0-nightly (f85579d4a 2017-07-12) (from servo:rustup); r=SimonSapin
Source-Repo: https://github.com/servo/servo
Source-Revision: 51c94954d1116eb7f60b067a73a830ebb305726f | diff --git a/gfx/lib.rs b/gfx/lib.rs
index b1b9614f7..5a5de4da8 100644
--- a/gfx/lib.rs
+++ b/gfx/lib.rs
@@ -3,19 +3,14 @@
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
// For SIMD
-#![feature(cfg_target_feature)]
-#![cfg_attr(any(target_os = "linux", target_os = "android"), feature(heap_api))]
-
-... | 2 | 11 | 12 |
0eef8168579d0c91c677889f17aca69d6e7c44e7 | Martin Robinson | 2017-07-13T18:52:06 | servo: Merge #17712 - Fix the size and position of overflow:scroll clip (from mrobinson:overflow-scroll-clip); r=emilio
The clip for overflow:scroll clip was not including the space for
padding, which could lead to some content being clipped when it
shouldn't. This changes fixes that issue.
A test is skipped because ... | diff --git a/layout/display_list_builder.rs b/layout/display_list_builder.rs
index 42fab8256..9fdd405a9 100644
--- a/layout/display_list_builder.rs
+++ b/layout/display_list_builder.rs
@@ -633,6 +633,18 @@ fn build_border_radius_for_inner_rect(outer_rect: &Rect<Au>,
radii
}
+fn build_inner_border_box_for_border... | 1 | 15 | 2 |
a8da2ae9798c134c5e874d8824c7317fc3f685ba | Paul Rouget | 2017-07-13T17:50:07 | servo: Merge #17709 - always call new_pipeline() before add_pending_changes() (from paulrouget:new_pipeline_before_add_pending_changes); r=cbrewster
There are some changes we want to make in `add_pending_changes` which require pipelines to be registered in self.pipelines.
---
<!-- Thank you for contributing to Servo!... | diff --git a/constellation/constellation.rs b/constellation/constellation.rs
index 4981980b7..9f147cfba 100644
--- a/constellation/constellation.rs
+++ b/constellation/constellation.rs
@@ -1572,22 +1572,21 @@ impl<Message, LTF, STF> Constellation<Message, LTF, STF>
};
// Create the new pipeline, att... | 1 | 16 | 17 |
d9aec5f197aa64e26d65436ed3c182cda86efaba | Pu Xingyu | 2017-07-13T16:53:39 | servo: Merge #17690 - layout: Stop in-order traversal on children of InlineFlow (from stshine:no-inorder); r=emilio
No need to do in-order traversal for children of InlineFlow, since
they are either inline-block or absolutely positioned elements, which
are guaranteed to be block formatting context.
<!-- Please descri... | diff --git a/layout/inline.rs b/layout/inline.rs
index 60edeedff..9dcb670f2 100644
--- a/layout/inline.rs
+++ b/layout/inline.rs
@@ -1420,6 +1420,8 @@ impl Flow for InlineFlow {
}
/// Calculate and set the block-size of this flow. See CSS 2.1 § 10.6.1.
+ /// Note that we do not need to do in-order traver... | 1 | 2 | 13 |
d865930c06a553dddd563517b3a22c9fb874ff25 | Paul Rouget | 2017-07-13T14:46:32 | servo: Merge #17685 - remove no-op InitializeCompositing message (from paulrouget:rm_InitializeCompositing); r=jdm
I think this is no-op.
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does... | diff --git a/compositing/compositor.rs b/compositing/compositor.rs
index e4382f125..a50c54577 100644
--- a/compositing/compositor.rs
+++ b/compositing/compositor.rs
@@ -742,10 +742,6 @@ impl<Window: WindowMethods> IOCompositor<Window> {
self.composite();
}
- WindowEvent::Initi... | 2 | 0 | 11 |
69cf6e5b3c6473603037324e1c4e4949dba04ef9 | Fernando Jiménez Moreno | 2017-07-13T12:17:06 | servo: Merge #17711 - Implement serialization of linear-gradient the same ways as in Gecko (from ferjm:bug1367274.linear.gradient); r=xidorn
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
From https://bugzilla.mozilla.org/show_bug.cgi?id=1367274
Source-Repo: ht... | diff --git a/layout/display_list_builder.rs b/layout/display_list_builder.rs
index dad561ce2..42fab8256 100644
--- a/layout/display_list_builder.rs
+++ b/layout/display_list_builder.rs
@@ -56,7 +56,7 @@ use style::properties::longhands::border_image_repeat::computed_value::RepeatKey
use style::properties::style_struct... | 3 | 81 | 49 |
c0bc6ab57e0647dfff50f70cb528f0e482f6297e | Emilio Cobos Álvarez | 2017-07-13T11:15:15 | servo: Merge #17707 - stylo: Waste less memory in invalidation stuff and style rules (from emilio:invalidation-less-memory); r=heycam
This should help a lot with https://bugzilla.mozilla.org/show_bug.cgi?id=1380488.
Source-Repo: https://github.com/servo/servo
Source-Revision: 9515abbca396c176e6a5c603a193573ac0cb9e33 | diff --git a/selectors/matching.rs b/selectors/matching.rs
index 9fc5b0815..f65703d05 100644
--- a/selectors/matching.rs
+++ b/selectors/matching.rs
@@ -164,10 +164,10 @@ pub fn matches_selector_list<E>(selector_list: &SelectorList<E::Impl>,
-> bool
where E: Element
{
- selecto... | 7 | 59 | 130 |
19e7e1f833e9c3cf4a86143b9bddf48ecb3da66a | Emilio Cobos Álvarez | 2017-07-13T08:26:34 | servo: Merge #17710 - Revert "Auto merge of #17701 - bholley:reuse_allocations, r=emilio" (from emilio:revert-bloom-sharing); r=heycam
This reverts commit ebfc8f585834948f9b7564ffe382a6e266edf738, reversing
changes made to 5585ff2c440dc27c8e98e834c9c0e9d956581b8e.
Animation code can reenter and create a new TLS conte... | diff --git a/layout/Cargo.toml b/layout/Cargo.toml
index 35860b3f2..a230bff46 100644
--- a/layout/Cargo.toml
+++ b/layout/Cargo.toml
@@ -26,7 +26,7 @@ log = "0.3.5"
msg = {path = "../msg"}
net_traits = {path = "../net_traits"}
ordered-float = "0.4"
-parking_lot = "0.4"
+parking_lot = "0.3.3"
profile_traits = {path ... | 9 | 26 | 116 |
881e6159e4b609c9859f11b053e30de16af246a2 | Emilio Cobos Álvarez | 2017-07-13T03:11:45 | servo: Merge #17705 - style: Avoid parsing negative padding in the padding shorthand (from emilio:neg-padding); r=bholley
Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1380492
Source-Repo: https://github.com/servo/servo
Source-Revision: 28abeab5a5c812c489ce676fced9c5c71f9de4e9 | diff --git a/style/properties/shorthand/padding.mako.rs b/style/properties/shorthand/padding.mako.rs
index c07a80b1e..2972fb452 100644
--- a/style/properties/shorthand/padding.mako.rs
+++ b/style/properties/shorthand/padding.mako.rs
@@ -4,6 +4,6 @@
<%namespace name="helpers" file="/helpers.mako.rs" />
-${helpers.f... | 1 | 1 | 1 |
6dde38af8ae3fa915520f4e0b4e6dbca8924900e | Emilio Cobos Álvarez | 2017-07-13T02:04:21 | servo: Merge #17693 - Revert "Auto merge of #17633 - servo:rustup, r=nox" (from emilio:revert-rustup); r=nox
This reverts commit 327e72aa149cdad347196f37bdb64c3afc5ae5e0, reversing
changes made to eec51cdd575cf985bc1ed926c6cb8868f1ba0e0e.
This closes #17642.
Source-Repo: https://github.com/servo/servo
Source-Revisio... | diff --git a/gfx/lib.rs b/gfx/lib.rs
index c44188602..10ba03c0d 100644
--- a/gfx/lib.rs
+++ b/gfx/lib.rs
@@ -3,9 +3,11 @@
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
// For SIMD
-#![cfg_attr(any(target_os = "linux", target_os = "android"), feature(alloc, allocator_api))]
-#![feature(box_syntax)]
... | 2 | 9 | 12 |
49ff766e8eafbba45d14ad1cb7cba2824a0f279d | Bobby Holley | 2017-07-12T23:48:19 | servo: Merge #17701 - reuse the bloom filter and style sharing cache across traversals (from bholley:reuse_allocations); r=emilio
https://bugzilla.mozilla.org/show_bug.cgi?id=1380198
Source-Repo: https://github.com/servo/servo
Source-Revision: ebfc8f585834948f9b7564ffe382a6e266edf738 | diff --git a/layout/Cargo.toml b/layout/Cargo.toml
index 16f82f223..63b48fded 100644
--- a/layout/Cargo.toml
+++ b/layout/Cargo.toml
@@ -26,7 +26,7 @@ log = "0.3.5"
msg = {path = "../msg"}
net_traits = {path = "../net_traits"}
ordered-float = "0.4"
-parking_lot = "0.3.3"
+parking_lot = "0.4"
profile_traits = {path ... | 9 | 116 | 26 |
6c1b86d6d3b694de242efb2d4191b2b9d20a7188 | Nazım Can Altınova | 2017-07-12T21:38:14 | servo: Merge #17692 - stylo: Fix grid-template serialization in grid shorthand (from canaltinova:grid-pls); r=wafflespeanut
Because of some unnecessary checks, it wasn't able to serialize the '40px / none' value properly before. That will fix one failure on `test_value_storage.html`
---
- [X] `./mach build -d` does n... | diff --git a/style/properties/shorthand/position.mako.rs b/style/properties/shorthand/position.mako.rs
index 55f8c8455..0e630b555 100644
--- a/style/properties/shorthand/position.mako.rs
+++ b/style/properties/shorthand/position.mako.rs
@@ -495,11 +495,9 @@
})
}
- /// Returns true if every sub proper... | 1 | 3 | 5 |
7646be4e24f3f0f0e027d464f8cf231b3f06a5dc | Emilio Cobos Álvarez | 2017-07-12T20:10:12 | servo: Merge #17691 - stylo: Fix causes of non-determinism in gecko_properties.rs (from emilio:nondeter); r=Manishearth
We should sort out all the different ways we have to get sides and all those
nasty loops, eventually...
Bug: 1380327
Reviewed-By: Manishearth
MozReview-Commit-ID: 4lAPEGeZaik
Source-Repo: https://gi... | diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs
index 13f7b1308..53986e486 100644
--- a/style/properties/gecko.mako.rs
+++ b/style/properties/gecko.mako.rs
@@ -1173,7 +1173,7 @@ fn static_assert() {
BorderImageSlice {
offsets:
NumberOrPercentageRect::f... | 1 | 2 | 2 |
003323d3253ab399a3b6b97c3a7af67c2c43dd92 | Paul Rouget | 2017-07-12T16:50:45 | servo: Merge #17686 - remove the ability to request for the title (from paulrouget:rm_Title); r=jdm
If we offer the ability to request info like these, we need to expose a lot of other getters, like url, loading state, favicon, …
It's up to the embedder to keep track of the state of a browser. So let's keep that cons... | diff --git a/compositing/compositor.rs b/compositing/compositor.rs
index 666952d12..337bf23a4 100644
--- a/compositing/compositor.rs
+++ b/compositing/compositor.rs
@@ -463,7 +463,6 @@ impl<Window: WindowMethods> IOCompositor<Window> {
ShutdownState::NotShuttingDown) => {
self.set_frame_t... | 4 | 0 | 33 |
72757aa62ff6ebdb3fc87afbcd8518a79e3ce188 | Brian Birtles | 2017-07-12T08:22:26 | servo: Merge #17683 - Tidy up check for zero-length lists when interpolating (from birtles:tidy-list-length-check); r=emilio
<!-- Please describe your changes on the following line: -->
Address feedback from https://github.com/servo/servo/pull/17613#discussion_r125775874
---
<!-- Thank you for contributing to Servo! ... | diff --git a/style/properties/helpers/animated_properties.mako.rs b/style/properties/helpers/animated_properties.mako.rs
index a84aea36f..959b55b0a 100644
--- a/style/properties/helpers/animated_properties.mako.rs
+++ b/style/properties/helpers/animated_properties.mako.rs
@@ -826,7 +826,7 @@ macro_rules! repeated_vec_i... | 1 | 1 | 1 |
6539cfcb76f7a147b008d618a8e199303cada503 | Hugh Gallagher | 2017-07-12T03:09:52 | servo: Merge #17673 - Removed unused import (from hgallagher1993:local_branch); r=jdm
Removed unused import `script_layout_interface::reporter::CSSErrorReporter in components/layout_thread/lib.rs
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `_... | diff --git a/layout_thread/lib.rs b/layout_thread/lib.rs
index a51cdb7ac..f7a306ce0 100644
--- a/layout_thread/lib.rs
+++ b/layout_thread/lib.rs
@@ -83,7 +83,6 @@ use profile_traits::time::{TimerMetadataFrameType, TimerMetadataReflowType};
use script::layout_wrapper::{ServoLayoutElement, ServoLayoutDocument, ServoLayo... | 1 | 0 | 1 |
2a8f5e3e37d2857a7f25be7f3d961c651e2116a0 | Sadman Kazi | 2017-07-12T01:55:18 | servo: Merge #17672 - Use boxed slice instead of vec for FuntionTimerCallback (from sadmansk:heap_in_box); r=jdm
<!-- Please describe your changes on the following line: -->
Added `fn trace()` implementation for `Box<[T]>` type, and change FunctionTimerCallback to store boxed slices for heap values instead of Vector.
... | diff --git a/script/dom/bindings/trace.rs b/script/dom/bindings/trace.rs
index 6fa16b2c6..5fccae624 100644
--- a/script/dom/bindings/trace.rs
+++ b/script/dom/bindings/trace.rs
@@ -177,6 +177,14 @@ unsafe impl<T: JSTraceable + ?Sized> JSTraceable for Box<T> {
}
}
+unsafe impl<T: JSTraceable> JSTraceable for [T]... | 2 | 10 | 2 |
270319f5d0e2f0de4db58bdc6a235781bc82d9cf | Brian Birtles | 2017-07-12T00:28:29 | servo: Merge #17682 - Check Gecko pref before parsing frames() timing function (from birtles:check-pref-for-frames-timing); r=hiro
These are the Servo-side changes for [Gecko bug 1379582](https://bugzilla.mozilla.org/show_bug.cgi?id=1379582).
They have been reviewed by @hiikezoe.
Source-Repo: https://github.com/serv... | diff --git a/style/gecko/generated/bindings.rs b/style/gecko/generated/bindings.rs
index 427992d89..55c6b4647 100644
--- a/style/gecko/generated/bindings.rs
+++ b/style/gecko/generated/bindings.rs
@@ -803,6 +803,9 @@ extern "C" {
ComputedTimingFunction_BeforeFlag)
-> f64... | 2 | 20 | 2 |
e2316547e20741a01b6ea8557fb17afc450f81a4 | Sebastian Hengst | 2017-07-11T22:11:58 | Backed out changeset 3977404931e5 for failing mochitest layout/style/test/test_value_computation.html. r=backout | diff --git a/style/gecko/generated/bindings.rs b/style/gecko/generated/bindings.rs
index f5c642160..427992d89 100644
--- a/style/gecko/generated/bindings.rs
+++ b/style/gecko/generated/bindings.rs
@@ -897,7 +897,7 @@ extern "C" {
}
extern "C" {
pub fn Gecko_SetImageOrientation(aVisibility: *mut nsStyleVisibility... | 4 | 29 | 85 |
46925622e337bb1c9f5be36175890de1cd6f6283 | Josh Matthews | 2017-07-11T19:28:33 | servo: Merge #17665 - Avoid panic when postMessage targets closed window (from jdm:postmessage-panic); r=KiChjang
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #17664
- [X] There are tests for these changes
Source-Repo: https://github.co... | diff --git a/script/dom/window.rs b/script/dom/window.rs
index 59c3c678f..e7f781fec 100644
--- a/script/dom/window.rs
+++ b/script/dom/window.rs
@@ -2000,7 +2000,8 @@ impl Runnable for PostMessageHandler {
impl Window {
pub fn post_message(&self, origin: Option<ImmutableOrigin>, data: StructuredCloneData) {
... | 1 | 2 | 1 |
0b707eab6f13ffed5e67627bdde0a000545403ff | Jonathan Chan | 2017-07-11T18:22:26 | servo: Merge #17654 - Make Servo's rounding of image-orientation values agree with Gecko's, and pass orientations directly as an enum instead of as angles (from jyc:image-orientation); r=Manishearth
Has been reviewed: https://reviewboard.mozilla.org/r/155336/
<!-- Thank you for contributing to Servo! Please replace e... | diff --git a/style/gecko/generated/bindings.rs b/style/gecko/generated/bindings.rs
index 427992d89..f5c642160 100644
--- a/style/gecko/generated/bindings.rs
+++ b/style/gecko/generated/bindings.rs
@@ -897,7 +897,7 @@ extern "C" {
}
extern "C" {
pub fn Gecko_SetImageOrientation(aVisibility: *mut nsStyleVisibility... | 4 | 85 | 29 |
d9334b678e0ed3b2f84ca93d433296bc0bcd58fe | Alan Jeffrey | 2017-07-11T13:40:33 | servo: Merge #17609 - Clear canvas thread state on recreation (from asajeffrey:canvas-clear-state); r=jdm
<!-- Please describe your changes on the following line: -->
The canvas rendering context is cleared when it is recreated, but not the matching state in the canvas paint thread.
---
<!-- Thank you for contributi... | diff --git a/canvas/canvas_paint_thread.rs b/canvas/canvas_paint_thread.rs
index 68cb96cd6..344e7d184 100644
--- a/canvas/canvas_paint_thread.rs
+++ b/canvas/canvas_paint_thread.rs
@@ -544,6 +544,8 @@ impl<'a> CanvasPaintThread<'a> {
fn recreate(&mut self, size: Size2D<i32>) {
self.drawtarget = CanvasPa... | 1 | 2 | 0 |
16591e6714f2c44ec881a2a8404e380379b4ed23 | Tremoneck | 2017-07-11T08:17:20 | servo: Merge #17652 - Move Ctrl-F12 keybindings outside of libservo (from Tremoneck:debug_key_mover); r=paulrouget
<!-- Please describe your changes on the following line: -->
Creates a new WindowEvent called ToggleProfiller, when this Event is queued the profiler is toggled.
When Crtl + F12 are pressed the Event is ... | diff --git a/compositing/compositor.rs b/compositing/compositor.rs
index 94c806414..666952d12 100644
--- a/compositing/compositor.rs
+++ b/compositing/compositor.rs
@@ -11,7 +11,7 @@ use gfx_traits::Epoch;
use gleam::gl;
use image::{DynamicImage, ImageFormat, RgbImage};
use ipc_channel::ipc::{self, IpcSharedMemory};... | 3 | 10 | 22 |
0ed893dc6daaa663008e06f57ecaf32f4646716d | Xidorn Quan | 2017-07-11T07:19:44 | servo: Merge #17660 - Serialize font longhands to -moz-use-system-font when using system font like what Gecko does (from upsuper:moz-use-system-font); r=Manishearth
This is the Servo side change of [bug 1364289](https://bugzilla.mozilla.org/show_bug.cgi?id=1364289).
Source-Repo: https://github.com/servo/servo
Source-... | diff --git a/style/properties/helpers.mako.rs b/style/properties/helpers.mako.rs
index 2a11bf018..22c514793 100644
--- a/style/properties/helpers.mako.rs
+++ b/style/properties/helpers.mako.rs
@@ -493,8 +493,6 @@
%>
<%call expr="longhand(name, keyword=Keyword(name, values, **keyword_kwargs), **kwargs)">
... | 2 | 22 | 36 |
e34b094858a46bb18ab9ee857e89a9e652d59641 | Emilio Cobos Álvarez | 2017-07-11T02:16:35 | servo: Merge #17658 - selectors: Avoid looking at MatchingMode if the selector isn't the topmost (from emilio:nesting-level); r=bholley
Also, switch the hover quirk to the same mechanism.
Bug: 1379696
Reviewed-By: bholley
MozReview-Commit-ID: KrmNqNyASf6
Source-Repo: https://github.com/servo/servo
Source-Revision: 8f... | diff --git a/selectors/matching.rs b/selectors/matching.rs
index 73dd6c9a9..3d6e86671 100644
--- a/selectors/matching.rs
+++ b/selectors/matching.rs
@@ -53,24 +53,25 @@ impl ElementSelectorFlags {
}
}
-/// Holds per-element data alongside a pointer to MatchingContext.
+/// Holds per-selector data alongside a po... | 2 | 31 | 21 |
917315089e5efbc1f6d885e9234d0d1c9091b08f | Hiroyuki Ikezoe | 2017-07-11T00:03:19 | servo: Merge #17656 - Consider f64 epsilon for add_weighted portions (from hiikezoe:fix-assertion-in-add-weighted); r=birtles
This patch also degrade assert! to debug_assert! since crash reports don't show
us useful information so far (no assertion messages at all).
<!-- Please describe your changes on the following ... | diff --git a/style/properties/helpers/animated_properties.mako.rs b/style/properties/helpers/animated_properties.mako.rs
index 1af4268b3..6b1c91833 100644
--- a/style/properties/helpers/animated_properties.mako.rs
+++ b/style/properties/helpers/animated_properties.mako.rs
@@ -2272,9 +2272,11 @@ impl Animatable for Matr... | 1 | 5 | 3 |
5ab2683278dc1c9a170466fd629930d5080ee219 | Hiroyuki Ikezoe | 2017-07-10T21:57:07 | servo: Merge #17653 - Drop allow resolve stale styles flag (from hiikezoe:drop-AllowResolveStaleStyles); r=emilio
<!-- Please describe your changes on the following line: -->
https://bugzilla.mozilla.org/show_bug.cgi?id=1379529
---
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not ... | diff --git a/style/gecko/generated/bindings.rs b/style/gecko/generated/bindings.rs
index 4d8a47677..256b783dc 100644
--- a/style/gecko/generated/bindings.rs
+++ b/style/gecko/generated/bindings.rs
@@ -2695,8 +2695,8 @@ extern "C" {
}
extern "C" {
pub fn Servo_ResolveStyle(element: RawGeckoElementBorrowed,
- ... | 3 | 6 | 6 |
584796b48f5bcbe915b2eaa596727e58fcdeab09 | J. Ryan Stinnett | 2017-07-10T18:33:04 | servo: Merge #17650 - Pass through visited style for after change (from jryans:link-transition-crash); r=hiikezoe
https://bugzilla.mozilla.org/show_bug.cgi?id=1377975
Source-Repo: https://github.com/servo/servo
Source-Revision: 5010df627d481b95f449b90ff7500471b01ec600 | diff --git a/style/context.rs b/style/context.rs
index dfb657585..db320aa47 100644
--- a/style/context.rs
+++ b/style/context.rs
@@ -297,6 +297,11 @@ impl CascadeInputs {
self.visited_rules.take()
}
+ /// Whether there are any visited values.
+ pub fn has_visited_values(&self) -> bool {
+ s... | 4 | 28 | 3 |
b1451c0dc4b9d6ffdbb24d7acea737bcea4d84db | Hiroyuki Ikezoe | 2017-07-10T09:31:35 | servo: Merge #17648 - Do not fill computed values in missing 0%/100% keyframes in CSS Animation (from hiikezoe:missing-keyframes); r=birtles
<!-- Please describe your changes on the following line: -->
https://bugzilla.mozilla.org/show_bug.cgi?id=1360398
---
- [X] `./mach build -d` does not report any errors
- [X] `.... | diff --git a/style/gecko/generated/atom_macro.rs b/style/gecko/generated/atom_macro.rs
index e07376ccc..03614e695 100644
--- a/style/gecko/generated/atom_macro.rs
+++ b/style/gecko/generated/atom_macro.rs
@@ -184,6 +184,8 @@ cfg_if! {
pub static nsGkAtoms_aria_checked: *mut nsIAtom;
#[link_nam... | 4 | 131 | 77 |
98d36c3d894e33d446648d50d61247f8ffe0a708 | Xidorn Quan | 2017-07-10T03:07:41 | servo: Merge #17646 - stylo: Use ComputedValues rather than element to get style rule list (from upsuper:bug1372464); r=heycam
This is the Servo side of [bug 1372464](https://bugzilla.mozilla.org/show_bug.cgi?id=1372464).
Source-Repo: https://github.com/servo/servo
Source-Revision: 95a85a301f1d014c45448a4d5d4f5a84979... | diff --git a/style/gecko/generated/bindings.rs b/style/gecko/generated/bindings.rs
index 9098a8cac..3c01e4525 100644
--- a/style/gecko/generated/bindings.rs
+++ b/style/gecko/generated/bindings.rs
@@ -2665,15 +2665,16 @@ extern "C" {
-> ServoComputedValuesStrong;
}
extern "C" {
- pub fn Servo_Initialize(dumm... | 1 | 6 | 5 |
31ddc41c2b9da95bb9332a50f3744708d1e24989 | Connor Brewster | 2017-07-09T21:39:59 | servo: Merge #17505 - Remove unnecessary `recv` in the constellation (from cbrewster:less_blocking); r=asajeffrey,glennw
<!-- Please describe your changes on the following line: -->
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with approp... | diff --git a/compositing/compositor.rs b/compositing/compositor.rs
index f6f1a02fc..94c806414 100644
--- a/compositing/compositor.rs
+++ b/compositing/compositor.rs
@@ -10,7 +10,7 @@ use euclid::{Point2D, TypedPoint2D, TypedVector2D, TypedRect, ScaleFactor, Typed
use gfx_traits::Epoch;
use gleam::gl;
use image::{Dyn... | 3 | 6 | 17 |
771443bc193fb2a3de36f64904631cc18053b5d4 | Emilio Cobos Álvarez | 2017-07-09T12:18:36 | servo: Merge #17644 - stylo: Run the stylehseet invalidation pass also for stylesheet removals (from emilio:invalidation-stylesheet-removals); r=heycam
People apparently do all sorts of silly stuff with stylesheets, see Google Inbox
in bug 1379203.
Bug: 1379433
Reviewed-By: heycam
MozReview-Commit-ID: 4x2d3glOFu8
Sou... | diff --git a/style/stylesheet_set.rs b/style/stylesheet_set.rs
index 07ef6fe24..f38ff22d5 100644
--- a/style/stylesheet_set.rs
+++ b/style/stylesheet_set.rs
@@ -125,8 +125,8 @@ where
stylist: &Stylist,
sheet: S,
before_sheet: S,
- guard: &SharedRwLockReadGuard)
- {
+ guard: &... | 1 | 13 | 5 |
d1a8a13a560499b7f916bf8cf434be71c1e12974 | Emilio Cobos Álvarez | 2017-07-08T19:59:29 | servo: Merge #17640 - style: Fix starts_with_ignore_ascii_case (from emilio:starts-with-ignore-ascii-case); r=stshine
In particular, fix a panic when the input is not ASCII and we happen to index in
something that is not a char boundary.
This fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1379380
Source-Repo: ht... | diff --git a/style/str.rs b/style/str.rs
index 96305a59f..92febb408 100644
--- a/style/str.rs
+++ b/style/str.rs
@@ -148,6 +148,6 @@ pub fn str_join<I, T>(strs: I, join: &str) -> String
/// Returns true if a given string has a given prefix with case-insensitive match.
pub fn starts_with_ignore_ascii_case(string: &s... | 1 | 2 | 2 |
68d3b6aba56d24ef0e53c5dab9a6a64ddae4163a | Emilio Cobos Álvarez | 2017-07-08T17:28:10 | servo: Merge #17639 - style: Avoid overriding the root font size from a getDefaultComputedStyle call (from emilio:gdcs-rem); r=heycam
Source-Repo: https://github.com/servo/servo
Source-Revision: 7a17de4fd0688a116b6a53607e040e90dc7c9652 | diff --git a/style/matching.rs b/style/matching.rs
index 1b9f0307a..5629a0e8b 100644
--- a/style/matching.rs
+++ b/style/matching.rs
@@ -341,7 +341,6 @@ trait PrivateMatchMethods: TElement {
if self.is_native_anonymous() || cascade_target == CascadeTarget::EagerPseudo {
cascade_flags.insert(PROHIB... | 2 | 14 | 13 |
eef8067a68b8bc9af7fd3e648c1dbbc5478d33ce | Ralph Giles | 2017-07-08T16:24:08 | servo: Merge #17638 - Fix build_gecko.rs for cross-macOS builds (from rillian:mac-bindgen); r=emilio,gps
This was [reviewed](https://bugzilla.mozilla.org/show_bug.cgi?id=1368083) over on the gecko side, and is now ready to land. This adds an additional build-time `bindgen.toml` file whose compiler args are merged into... | diff --git a/style/build_gecko.rs b/style/build_gecko.rs
index ec23480c6..de8daefd3 100644
--- a/style/build_gecko.rs
+++ b/style/build_gecko.rs
@@ -61,31 +61,44 @@ mod bindings {
}
}
+ fn read_config(path: &PathBuf) -> toml::Table {
+ println!("cargo:rerun-if-changed={}", path.to_str().unwrap... | 1 | 38 | 22 |
b94f76c2965b9d39a3af78fec8b2af354f5a36d8 | Omar Akkila | 2017-07-07T18:21:16 | servo: Merge #17632 - Clean up HTMLImageElement::handle_event (from omakk:master); r=jdm
Reflects desired changes in #15832
<!-- Please describe your changes on the following line: -->
Cleans up `HTMLImageElement::handle_event` located in `components/script/dom/htmlimageelement.rs`
---
<!-- Thank you for contributin... | diff --git a/script/dom/htmlareaelement.rs b/script/dom/htmlareaelement.rs
index 9535fb060..0e3c26155 100644
--- a/script/dom/htmlareaelement.rs
+++ b/script/dom/htmlareaelement.rs
@@ -167,7 +167,7 @@ impl Area {
}
}
- pub fn hit_test(&self, p: Point2D<f32>) -> bool {
+ pub fn hit_test(&self, p: &... | 2 | 30 | 32 |
adab9d376309dc12a8248652e6a1d9281e6e2eba | Simon Sapin | 2017-07-07T13:31:46 | servo: Merge #17633 - Upgrade to rustc 1.20.0-nightly (696412de7 2017-07-06) (from servo:rustup); r=nox
Source-Repo: https://github.com/servo/servo
Source-Revision: 327e72aa149cdad347196f37bdb64c3afc5ae5e0 | diff --git a/gfx/lib.rs b/gfx/lib.rs
index 10ba03c0d..c44188602 100644
--- a/gfx/lib.rs
+++ b/gfx/lib.rs
@@ -3,11 +3,9 @@
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
// For SIMD
-#![feature(cfg_target_feature)]
-#![cfg_attr(any(target_os = "linux", target_os = "android"), feature(heap_api))]
-
-#... | 2 | 12 | 9 |
02bee842db5ef80f8296ed28c3e5094f4dad29a7 | Clar Charr | 2017-07-07T06:34:13 | servo: Merge #17619 - Update parse-hosts (from clarcharr:master); r=SimonSapin
The `parse-hosts` crate was recently updated so that it doesn't use any unstable features.
---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [X] These changes do not require tests ... | diff --git a/net/Cargo.toml b/net/Cargo.toml
index c58260367..eac810a49 100644
--- a/net/Cargo.toml
+++ b/net/Cargo.toml
@@ -28,7 +28,7 @@ mime_guess = "1.8.0"
msg = {path = "../msg"}
net_traits = {path = "../net_traits"}
openssl = "0.9"
-parse-hosts = "0.3.0"
+parse-hosts = "0.4.0"
profile_traits = {path = "../pro... | 2 | 5 | 14 |
2da3e1fe2a8e22b08f44e094496cb7ca9d015a95 | Nazım Can Altınova | 2017-07-07T05:06:36 | servo: Merge #17630 - stylo: Properly serialize grid shorthand (from canaltinova:grid-shorthand); r=wafflespeanut
It was failing to serialize correctly when grid was `<'grid-template'>` or some different edge cases.
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is comp... | diff --git a/style/properties/longhand/position.mako.rs b/style/properties/longhand/position.mako.rs
index bcf6d110f..526c62e4c 100644
--- a/style/properties/longhand/position.mako.rs
+++ b/style/properties/longhand/position.mako.rs
@@ -307,9 +307,7 @@ ${helpers.predefined_type("object-position",
#[derive(Part... | 2 | 28 | 17 |
40d37b21b7df6b54924addc00bc148619a93d2cc | Hiroyuki Ikezoe | 2017-07-07T00:20:38 | servo: Merge #17628 - Return no damage if there is no display property changes (from hiikezoe:restyle-damage); r=heycam
<!-- Please describe your changes on the following line: -->
https://bugzilla.mozilla.org/show_bug.cgi?id=1374175
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` whe... | diff --git a/style/matching.rs b/style/matching.rs
index 9afde754f..1b9f0307a 100644
--- a/style/matching.rs
+++ b/style/matching.rs
@@ -1560,10 +1560,11 @@ pub trait MatchMethods : TElement {
return RestyleDamage::compute_style_difference(source, new_values)
}
- let new_style_is_display_... | 1 | 19 | 9 |
e2154b942c5495f41040badce7e97e221dccad26 | Xidorn Quan | 2017-07-06T23:18:36 | servo: Merge #17430 - Store font-weight as integer directly (from upsuper:font-weight-int); r=nox
It doesn't make much sense to store `font-weight` as separate enums, especially given that we would need to support (somehow) arbitrary font weight value when we implement CSS Fonts Level 4.
This PR refactors the `font-w... | diff --git a/gfx/font_template.rs b/gfx/font_template.rs
index 6a4683490..920e97357 100644
--- a/gfx/font_template.rs
+++ b/gfx/font_template.rs
@@ -46,7 +46,7 @@ impl FontTemplateDescriptor {
// A value higher than all weights.
return 1000
}
- ((self.weight as i16) - (other.we... | 11 | 111 | 194 |
6663bd0a183b47f5f0268351e532880d2f126a90 | Fernando Jiménez Moreno | 2017-07-06T15:27:55 | servo: Merge #17536 - Add cli options to write profiler output to InfluxDB (from ferjm:influxdb.profiler); r=jdm
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
This patch adds the command line options and associated code to write the output of running the profil... | diff --git a/config/opts.rs b/config/opts.rs
index d25720609..b03ed69c1 100644
--- a/config/opts.rs
+++ b/config/opts.rs
@@ -39,8 +39,13 @@ pub struct Opts {
/// platform default setting.
pub device_pixels_per_px: Option<f32>,
- /// `None` to disable the time profiler or `Some` with an interval in second... | 4 | 76 | 6 |
7781545583e04d02b48809f7eac226eff0f4a258 | Omar Akkila | 2017-07-06T11:37:00 | servo: Merge #17620 - Clean up Area::parse (#15834) (from omakk:master); r=nox
Replace mutable reference to array with direct use
Remove unnecessary clone
Replace call to unwrap()
<!-- Please describe your changes on the following line: -->
This PR refactors `Area::parse` in `component/script/dom/htmlareaelement.rs... | diff --git a/script/dom/htmlareaelement.rs b/script/dom/htmlareaelement.rs
index 6826a1883..9535fb060 100644
--- a/script/dom/htmlareaelement.rs
+++ b/script/dom/htmlareaelement.rs
@@ -24,6 +24,7 @@ use html5ever::{LocalName, Prefix};
use net_traits::ReferrerPolicy;
use std::default::Default;
use std::f32;
+use std:... | 1 | 7 | 7 |
5fa2086de83b6c104f079662c1b0204a1364b891 | Mantaroh Yoshinaga | 2017-07-06T04:49:27 | servo: Merge #17617 - Handling of invalid values in svg paint server (from mantaroh:svg-paint-server); r=hiro,manishearth
<!-- Please describe your changes on the following line: -->
This is a PR for https://bugzilla.mozilla.org/show_bug.cgi?id=1374161
---
<!-- Thank you for contributing to Servo! Please replace each... | diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs
index 84271a185..c881dab0c 100644
--- a/style/properties/gecko.mako.rs
+++ b/style/properties/gecko.mako.rs
@@ -475,6 +475,7 @@ def set_gecko_property(ffi_name, expr):
#[allow(non_snake_case)]
pub fn clone_${ident}(&self) -> longhand... | 2 | 23 | 6 |
c5eb22b0376e2402bea576cd33e224715588f882 | Nazım Can Altınova | 2017-07-06T03:34:57 | servo: Merge #17616 - stylo: Add auto-filled line names to mRepeatAutoLineNameListBefore array (from canaltinova:subgrid-autofill); r=wafflespeanut
Line names with `repeat(auto-fill, ...)` were not being added to mRepeatAutoLineNameListBefore. They were being added into mLineNameLists instead.
Basically, `subgrid repe... | diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs
index a2e74b907..84271a185 100644
--- a/style/properties/gecko.mako.rs
+++ b/style/properties/gecko.mako.rs
@@ -1405,9 +1405,14 @@ fn static_assert() {
&mut ${self_grid}.mRepeatAutoLineNameListAfter, 0);
... | 2 | 11 | 4 |
a1b19e179523856c49fb3ac0de3eb13fd50ad9b8 | Bobby Holley | 2017-07-06T02:29:01 | servo: Merge #17615 - Rip out the generic abstractions around ThreadLocalStyleContext (from bholley:simplify_local_context); r=emilio
https://bugzilla.mozilla.org/show_bug.cgi?id=1378540
Source-Repo: https://github.com/servo/servo
Source-Revision: 8923a9e5f0cc292062f852babe878326aff656ef | diff --git a/layout/context.rs b/layout/context.rs
index 22b407d1f..d261fe5d8 100644
--- a/layout/context.rs
+++ b/layout/context.rs
@@ -18,39 +18,12 @@ use script_layout_interface::{PendingImage, PendingImageState};
use script_traits::PaintWorkletExecutor;
use script_traits::UntrustedNodeAddress;
use servo_url::Ser... | 7 | 52 | 102 |
77dcd9ac8166a0945da19348a27b6ff015565f5f | Bobby Holley | 2017-07-06T01:37:04 | servo: Merge #17612 - Make the style statistics dump threshold configurable (from bholley:custom_threshold); r=emilio
I've wanted to change the threshold a couple of times, and adding in a
10-minute opt rebuild cycle is always a bit de-motivating.
I'm making this option gecko-only because it's pretty niche, and addin... | diff --git a/style/context.rs b/style/context.rs
index 18822ca29..dfb657585 100644
--- a/style/context.rs
+++ b/style/context.rs
@@ -61,10 +61,13 @@ pub struct StyleSystemOptions {
pub disable_style_sharing_cache: bool,
/// Whether we should dump statistics about the style system.
pub dump_style_statisti... | 1 | 26 | 4 |
20999d0c33f408f76054d06b43a8abb4f6be6036 | Jonathan Chan | 2017-07-06T00:35:49 | servo: Merge #17556 - layout: Clean up inline_metrics_of_block a little (from jyc:inline-metrics-of-block); r=emilio
Previously the variable names were a little confusing (ascent was used
for the space_above_baseline in one branch and the and ascent field in
another branch, and was not really the ascent in one). Also ... | diff --git a/layout/fragment.rs b/layout/fragment.rs
index d54853fa7..b9bbe5ddd 100644
--- a/layout/fragment.rs
+++ b/layout/fragment.rs
@@ -2158,17 +2158,35 @@ impl Fragment {
let block_flow = flow.as_block();
let start_margin = block_flow.fragment.margin.block_start;
let end_mar... | 1 | 29 | 11 |
a7ff84e002c036839b5dce3b0a68121b4c71766a | Brian Birtles | 2017-07-05T23:47:36 | servo: Merge #17613 - Handle zero length lists when interpolating (from birtles:zero-length-lists); r=hiro
These are the Servo side changes for [Gecko bug 1377053](https://bugzilla.mozilla.org/show_bug.cgi?id=1377053).
These patches have been reviewed by @hiikezoe.
Source-Repo: https://github.com/servo/servo
Source-... | diff --git a/style/properties/helpers/animated_properties.mako.rs b/style/properties/helpers/animated_properties.mako.rs
index 3f5d91ba4..e68faeb89 100644
--- a/style/properties/helpers/animated_properties.mako.rs
+++ b/style/properties/helpers/animated_properties.mako.rs
@@ -828,6 +828,10 @@ macro_rules! repeated_vec_... | 1 | 8 | 0 |
b317e296dec8def8fef46ea055d867a511a5cc9a | Nazım Can Altınova | 2017-07-05T22:46:01 | servo: Merge #17587 - Fix color stop sorting in -webkit-gradient (from canaltinova:webkit-gradient); r=nox
This was causing a reftest failure in gecko side(layout/reftests/webkit-gradient/webkit-gradient-linear-2.html). Basically, it was sorting exactly opposite if two color stops have the same percentage.
---
- [X] ... | diff --git a/style/values/specified/image.rs b/style/values/specified/image.rs
index 5bd143a7a..80b7d8678 100644
--- a/style/values/specified/image.rs
+++ b/style/values/specified/image.rs
@@ -502,10 +502,7 @@ impl Gradient {
(&GenericGradientItem::ColorStop(ref a), &GenericGradientItem::ColorStop(... | 1 | 1 | 4 |
4481f36d47f40f9f91d99199d854a8497916318a | Anthony Ramine | 2017-07-05T14:33:13 | servo: Merge #17603 - Clean up vector_longhand a bit (from servo:derive-all-the-things); r=SimonSapin
Source-Repo: https://github.com/servo/servo
Source-Revision: 296a215e5404eb0fd0c0a34cc1283cd0b84aaea9 | diff --git a/style/properties/helpers.mako.rs b/style/properties/helpers.mako.rs
index 0f2027fe4..f7fd7f608 100644
--- a/style/properties/helpers.mako.rs
+++ b/style/properties/helpers.mako.rs
@@ -69,208 +69,200 @@
// FIXME (Manishearth): Add computed_value_as_specified argument
// and handle the empty case correctly... | 6 | 178 | 197 |
291ce31feda5647af4ad7466bb1e213c71baf490 | Simon Sapin | 2017-07-05T13:08:29 | servo: Merge #17605 - Replace remaining usage of deprecated Range::step_by (from servo:maybereverse); r=nox
… which is being removed in rust-lang/rust#43012
Source-Repo: https://github.com/servo/servo
Source-Revision: 5baea7b73223283b551cf378bb714491a2383c28 | diff --git a/layout/inline.rs b/layout/inline.rs
index 1ce18b562..60edeedff 100644
--- a/layout/inline.rs
+++ b/layout/inline.rs
@@ -962,13 +962,29 @@ impl InlineFlow {
Some(ref runs) => runs[run_count - run_idx - 1], // reverse order for RTL runs
None => (line.range, bidi::Level::ltr(... | 3 | 21 | 7 |
20bb51bb7502f2b057de64acaaa0289eef7dd3d8 | Bobby Holley | 2017-07-04T20:44:52 | servo: Merge #17602 - Use GC machinery rather than recursion for post-rule-tree-teardown node dropping (from bholley:rule_tree_custom_gc); r=emilio
https://bugzilla.mozilla.org/show_bug.cgi?id=1378005
Source-Repo: https://github.com/servo/servo
Source-Revision: 006037f79839b94ae6a2db01919976c47d1589b5 | diff --git a/style/rule_tree/mod.rs b/style/rule_tree/mod.rs
index b4603dbb5..4ef94cd12 100644
--- a/style/rule_tree/mod.rs
+++ b/style/rule_tree/mod.rs
@@ -1408,16 +1408,44 @@ impl Drop for StrongRuleNode {
let free_list = &root.next_free;
let mut old_head = free_list.load(Ordering::Relaxed);
- ... | 1 | 34 | 6 |
ac5ffb8b16689115c4edbe90ed03c867cd14471a | Fernando Jiménez Moreno | 2017-07-04T12:08:03 | servo: Merge #17601 - stylo: Implement ServoStyleRule::SelectorMatchesElement (from ferjm:bug1370502.selector.matches.element); r=emilio
from https://bugzilla.mozilla.org/show_bug.cgi?id=1370502
Source-Repo: https://github.com/servo/servo
Source-Revision: c44b5993ebc9a24241ac443d52a1900c7f79acef | diff --git a/style/gecko/generated/bindings.rs b/style/gecko/generated/bindings.rs
index 96d9b3f9d..84e4c69cb 100644
--- a/style/gecko/generated/bindings.rs
+++ b/style/gecko/generated/bindings.rs
@@ -2144,6 +2144,16 @@ extern "C" {
pub fn Servo_StyleRule_GetSelectorCount(rule: RawServoStyleRuleBorrowed,
... | 2 | 15 | 0 |
05ef8a545758468cd9174918fae4c4e2d3822e1f | Manish Goregaokar | 2017-07-04T05:50:42 | servo: Merge #17600 - Revert "style: Cleanup duplicated code in the definition of ComputedValues." (from Manishearth:revert-cv); r=heycam
This reverts commit 1c2fcb16ca5ab522f23d73800185be8011d5a91c.
We're completely redoing the ComputedValues stuff on the gecko side, this makes it easier to deal with
cc @emilio
So... | diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs
index 7ecda5727..32705300f 100644
--- a/style/properties/gecko.mako.rs
+++ b/style/properties/gecko.mako.rs
@@ -11,6 +11,7 @@
<%namespace name="helpers" file="/helpers.mako.rs" />
use app_units::Au;
+use custom_properties::CustomProperties... | 2 | 167 | 98 |
837da678cd616a4415ccb93c4ce37483783735a3 | Nazım Can Altınova | 2017-07-04T00:10:25 | servo: Merge #17268 - Add support for subgrids and fix some other grid properties (from servo:grid); r=wafflespeanut,canaltinova
This covers the `subgrid <line-name-lists>?` for `grid-template` (for gecko, and hence, stylo).
Source-Repo: https://github.com/servo/servo
Source-Revision: 7a71035793f6d87c8f0f8e63ae045c1a... | diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs
index 9fa06283a..7ecda5727 100644
--- a/style/properties/gecko.mako.rs
+++ b/style/properties/gecko.mako.rs
@@ -1097,26 +1097,20 @@ fn static_assert() {
<% self_grid = "self.gecko.mGridTemplate%s" % kind.title() %>
use gecko:... | 7 | 369 | 111 |
7c3b72b3ab9e021b9d9417d4f21649b55c9e137a | Emilio Cobos Álvarez | 2017-07-03T11:04:44 | servo: Merge #17593 - stylo: properly handle ::before/::after rules applying to replaced elements (from emilio:pseudo-replaced); r=heycam
Bug: 1376352
Reviewed-By: heycam
MozReview-Commit-ID: FO0TyWsPPG7
Source-Repo: https://github.com/servo/servo
Source-Revision: c17134ce485453ff124cc337fa68b9a981106a45 | diff --git a/style/matching.rs b/style/matching.rs
index 49c329d32..9afde754f 100644
--- a/style/matching.rs
+++ b/style/matching.rs
@@ -1576,23 +1576,30 @@ pub trait MatchMethods : TElement {
}
if pseudo.map_or(false, |p| p.is_before_or_after()) {
- if (old_style_is_display_none ||
- ... | 1 | 23 | 16 |
e198558a6b94bf3f01495b1f4468f92a80d85fbe | Hiroyuki Ikezoe | 2017-07-03T06:24:38 | servo: Merge #17592 - Don't use AnimatedProperty functions for gecko (from hiikezoe:remove-animated-property); r=birtles
<!-- Please describe your changes on the following line: -->
https://bugzilla.mozilla.org/show_bug.cgi?id=1377680
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` wh... | diff --git a/style/gecko/wrapper.rs b/style/gecko/wrapper.rs
index 2880689ae..a7aff7f3a 100644
--- a/style/gecko/wrapper.rs
+++ b/style/gecko/wrapper.rs
@@ -1309,8 +1309,6 @@ impl<'le> TElement for GeckoElement<'le> {
existing_transitions: &HashMap<TransitionProperty,
... | 1 | 6 | 6 |
6235760727f84da842579b5309bdf66d6cac747f | Anthony Ramine | 2017-07-02T12:59:34 | servo: Merge #17576 - Merge BoxShadowList and TextShadowList into ShadowList<T> (from servo:derive-all-the-things); r=SimonSapin
Source-Repo: https://github.com/servo/servo
Source-Revision: edb0dafefcdf0285c9bde443c77a17ea2ce7679b | diff --git a/style/properties/helpers/animated_properties.mako.rs b/style/properties/helpers/animated_properties.mako.rs
index 7686d1be5..26e56a89c 100644
--- a/style/properties/helpers/animated_properties.mako.rs
+++ b/style/properties/helpers/animated_properties.mako.rs
@@ -723,21 +723,16 @@ impl Animatable for Anima... | 2 | 91 | 132 |
736adb507eb7e829e0e051cddae9e09c2cb62a61 | Emilio Cobos Álvarez | 2017-07-01T15:13:58 | servo: Merge #17562 - style: Don't treat some document-state-related pseudo-classes as revalidation selectors (from emilio:less-revalidation-stuff); r=bzbarsky
Source-Repo: https://github.com/servo/servo
Source-Revision: be58b99b066757d91d1b7290a55617303c4ac19d | diff --git a/style/gecko/selector_parser.rs b/style/gecko/selector_parser.rs
index 332670c3a..78ddc05df 100644
--- a/style/gecko/selector_parser.rs
+++ b/style/gecko/selector_parser.rs
@@ -174,7 +174,8 @@ impl NonTSPseudoClass {
apply_non_ts_list!(pseudo_class_state)
}
- /// Returns true if the given... | 1 | 11 | 5 |
7c0e6485385ddb07695e3b0703e1cb52a5dae854 | Bobby Holley | 2017-07-01T06:36:50 | servo: Merge #17585 - Allow dropping rule nodes after rule tree teardown (from bholley:rule_tree_teardown); r=emilio
https://bugzilla.mozilla.org/show_bug.cgi?id=1377010
Source-Repo: https://github.com/servo/servo
Source-Revision: 78f05bf593d98acfd8e20eb79b6aeb9a4c386b2a | diff --git a/style/rule_tree/mod.rs b/style/rule_tree/mod.rs
index f4fe5da37..b4603dbb5 100644
--- a/style/rule_tree/mod.rs
+++ b/style/rule_tree/mod.rs
@@ -47,6 +47,21 @@ pub struct RuleTree {
root: StrongRuleNode,
}
+impl Drop for RuleTree {
+ fn drop(&mut self) {
+ // GC the rule tree.
+ uns... | 2 | 93 | 28 |
7f5e64496d365de1c6ec77e88fb16401a93b93b4 | Matt Brubeck | 2017-07-01T05:15:26 | servo: Merge #17581 - Fix incremental layout bugs for absolute and cleared elements (from mbrubeck:incremental); r=pcwalton
Fixes #17307. <del>There were two underlying bugs:</del>
* <del>Nodes were not marked dirty when their style attribute changed.</del>
* BaseFlow flags set during flow construction could get ou... | diff --git a/layout/Cargo.toml b/layout/Cargo.toml
index 6b1ad9d2e..e3e2c76c2 100644
--- a/layout/Cargo.toml
+++ b/layout/Cargo.toml
@@ -12,7 +12,7 @@ path = "lib.rs"
[dependencies]
app_units = "0.5"
atomic_refcell = "0.1"
-bitflags = "0.7"
+bitflags = "0.8"
canvas_traits = {path = "../canvas_traits"}
euclid = "0.... | 3 | 25 | 2 |
f765848bd33e32286b905bbdb91cf0d9f2a93611 | Nazım Can Altınova | 2017-07-01T01:00:50 | servo: Merge #17434 - stylo: Implement -moz-prefixed gradients (from canaltinova:moz-linear-gradient); r=Manishearth,nox
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any er... | diff --git a/layout/display_list_builder.rs b/layout/display_list_builder.rs
index 7ab6c7f78..9aa9301ee 100644
--- a/layout/display_list_builder.rs
+++ b/layout/display_list_builder.rs
@@ -1339,7 +1339,7 @@ impl FragmentDisplayListBuilding for Fragment {
gradient: gradient,
})
... | 8 | 455 | 81 |
5bb88c95822ab06649bfde006ea73dbe1d6f0c27 | Simon Sapin | 2017-06-30T21:34:56 | servo: Merge #17561 - Upgrade to rustc 1.20.0-nightly (69c65d296 2017-06-28) (from servo:rustup); r=nox
Fixes #17575.
Source-Repo: https://github.com/servo/servo
Source-Revision: d16ef3cd332039e2b4def59f55c87f706e2aa6ae | diff --git a/script_plugins/unrooted_must_root.rs b/script_plugins/unrooted_must_root.rs
index ca7c70aeb..5dbd2b1a3 100644
--- a/script_plugins/unrooted_must_root.rs
+++ b/script_plugins/unrooted_must_root.rs
@@ -140,7 +140,7 @@ impl<'a, 'tcx> LateLintPass<'a, 'tcx> for UnrootedPass {
if !in_derive_expn(span... | 1 | 1 | 1 |
25a5877c0c58972a47a47ae68d2d3e5f15cc0aa4 | Matt Brubeck | 2017-06-30T17:13:01 | servo: Merge #17577 - Bug 1348489 - stylo: Implement :-moz-window-inactive (from mbrubeck:inactive); r=emilio
https://bugzilla.mozilla.org/show_bug.cgi?id=1348489
Source-Repo: https://github.com/servo/servo
Source-Revision: a24600d626384c6b3cd214a52ff251d706d59064 | diff --git a/style/element_state.rs b/style/element_state.rs
index d8b4d6803..dbc04ff0f 100644
--- a/style/element_state.rs
+++ b/style/element_state.rs
@@ -138,3 +138,16 @@ bitflags! {
const IN_AUTOFILL_PREVIEW_STATE = 1 << 51,
}
}
+
+bitflags! {
+ /// Event-based document states.
+ ///
+ /// N... | 4 | 30 | 4 |
a2f0b3f6fc840c4cb8a6b921e6f62ee13aa135da | Boris Zbarsky | 2017-06-30T16:11:41 | servo: Merge #17570 - Implement :visited support for lazy pseudo-elements (from bzbarsky:visited-pseudos); r=jryans
<!-- Please describe your changes on the following line: -->
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate... | diff --git a/script_layout_interface/wrapper_traits.rs b/script_layout_interface/wrapper_traits.rs
index cac426156..579ac767d 100644
--- a/script_layout_interface/wrapper_traits.rs
+++ b/script_layout_interface/wrapper_traits.rs
@@ -426,6 +426,7 @@ pub trait ThreadSafeLayoutElement: Clone + Copy + Sized + Debug +
... | 4 | 212 | 59 |
7b0a2d78bf21e12a4315449fb4cffa7019138ebd | Xidorn Quan | 2017-06-30T15:08:00 | servo: Merge #17569 - Support :-moz-full-screen pseudo-class (from upsuper:fullscreen); r=emilio
This fixes [bug 1374901](https://bugzilla.mozilla.org/show_bug.cgi?id=1374901).
Source-Repo: https://github.com/servo/servo
Source-Revision: a04725fa1c744236968df038be7e6093889f6cf7 | diff --git a/style/gecko/non_ts_pseudo_class_list.rs b/style/gecko/non_ts_pseudo_class_list.rs
index 92da05b5b..fe249561c 100644
--- a/style/gecko/non_ts_pseudo_class_list.rs
+++ b/style/gecko/non_ts_pseudo_class_list.rs
@@ -66,6 +66,7 @@ macro_rules! apply_non_ts_list {
// TODO(emilio): Needs pref che... | 2 | 2 | 0 |
83254fbda6fbc724946f8ac6c4abec9e826ce02e | Nazım Can Altınova | 2017-06-30T11:13:15 | servo: Merge #17566 - stylo: Fix font-variant-alternates property (from canaltinova:font-var-alt); r=emilio
`font-variant-alternates` was just parsing values as keywords. But many of the alternates are actually functions instead of keywords. This fixes that.
r=emilio on bugzilla side.
---
- [X] `./mach build -d` doe... | diff --git a/style/gecko/generated/bindings.rs b/style/gecko/generated/bindings.rs
index 3c0d2d945..96b152df9 100644
--- a/style/gecko/generated/bindings.rs
+++ b/style/gecko/generated/bindings.rs
@@ -873,6 +873,17 @@ extern "C" {
extern "C" {
pub fn Gecko_nsFont_Destroy(dst: *mut nsFont);
}
+extern "C" {
+ p... | 3 | 205 | 80 |
2b9fe5c7cde3654ce1acffbf574707982379a593 | Julian Seward | 2017-06-30T10:01:08 | servo: Merge #17563 - Bug 1368302 - stylo: possible stack overflow when processing very dee… (from julian-seward1:master); r=bholley
…p DOM. r=bholley.
Whilst working with variants of the bloom-basic test for Stylo perf
profiling, I noticed that it is easy to cause Firefox to segfault on DOMs
with a depth of more th... | diff --git a/style/parallel.rs b/style/parallel.rs
index 79126f034..0526c07f9 100644
--- a/style/parallel.rs
+++ b/style/parallel.rs
@@ -92,6 +92,7 @@ pub fn traverse_dom<E, D>(traversal: &D,
let nodes = nodes;
traverse_nodes(&*nodes,
DispatchMode::TailCall,
+ ... | 1 | 23 | 4 |
d09345b9bdefe37356fc5528022d9d286a745a8d | Sebastian Hengst | 2017-06-29T20:27:32 | Backed out changeset 90036d4d378e (bug 17564) because gecko-side patch caused bustage on Windows. r=backout on a CLOSED TREE | diff --git a/style/element_state.rs b/style/element_state.rs
index dbc04ff0f..d8b4d6803 100644
--- a/style/element_state.rs
+++ b/style/element_state.rs
@@ -138,16 +138,3 @@ bitflags! {
const IN_AUTOFILL_PREVIEW_STATE = 1 << 51,
}
}
-
-bitflags! {
- /// Event-based document states.
- ///
- /// N... | 4 | 4 | 32 |
b707e40a2832e5b56560ba797af8ca337a153548 | Matt Brubeck | 2017-06-29T18:25:40 | servo: Merge #17564 - Bug 1348489 - stylo: Implement :-moz-window-inactive (from mbrubeck:inactive); r=emilio
https://bugzilla.mozilla.org/show_bug.cgi?id=1348489
Source-Repo: https://github.com/servo/servo
Source-Revision: 8f37de05b2bf3e45c686f5dc25b9d3a4a8c06471 | diff --git a/style/element_state.rs b/style/element_state.rs
index d8b4d6803..dbc04ff0f 100644
--- a/style/element_state.rs
+++ b/style/element_state.rs
@@ -138,3 +138,16 @@ bitflags! {
const IN_AUTOFILL_PREVIEW_STATE = 1 << 51,
}
}
+
+bitflags! {
+ /// Event-based document states.
+ ///
+ /// N... | 4 | 32 | 4 |
c32ea60a0caaa87e182a7428ea5e0e02696aea93 | Anthony Ramine | 2017-06-29T13:49:39 | servo: Merge #17560 - Introduce ToAnimatedValue 🎥 (from servo:derive-all-the-things); r=<try>
Source-Repo: https://github.com/servo/servo
Source-Revision: 9a13cf6bdaa823369f29d7d0f4469087cf17ce6a | diff --git a/style/macros.rs b/style/macros.rs
index 7899ef610..569d5e7d5 100644
--- a/style/macros.rs
+++ b/style/macros.rs
@@ -110,6 +110,7 @@ macro_rules! define_keyword_type {
}
impl $crate::values::computed::ComputedValueAsSpecified for $name {}
+ impl $crate::values::animated::AnimatedV... | 9 | 348 | 214 |
63ef5cd37645a36567e3f2e652d7f05406a6e3d5 | Fernando Jiménez Moreno | 2017-06-29T05:01:17 | servo: Merge #17558 - Derive Eq and PartialEq for CustomPropertiesMap (from ferjm:custompropmap.eq); r=emilio
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
Source-Repo: https://github.com/servo/servo
Source-Revision: 2ff781d0680e81cb66daac01ee2b851a2f4ab319 | diff --git a/style/custom_properties.rs b/style/custom_properties.rs
index d5920a653..5b7c12573 100644
--- a/style/custom_properties.rs
+++ b/style/custom_properties.rs
@@ -97,7 +97,7 @@ impl ToCss for ComputedValue {
/// DOM. CSSDeclarations expose property names as indexed properties, which
/// need to be stable. S... | 1 | 1 | 8 |
57c23c46f77ba73c1e0e5603faa2d4ff9ae872d2 | Matt Brubeck | 2017-06-29T02:11:08 | servo: Merge #17554 - Stop using the unstable optin_builtin_traits feature (from mbrubeck:oibit); r=ManishEarth
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix part of #5286.
- [x] These changes do not require tests because they are refacto... | diff --git a/script/dom/bindings/str.rs b/script/dom/bindings/str.rs
index 33f4f1bc5..97b58a290 100644
--- a/script/dom/bindings/str.rs
+++ b/script/dom/bindings/str.rs
@@ -11,6 +11,7 @@ use std::ascii::AsciiExt;
use std::borrow::{Borrow, Cow, ToOwned};
use std::fmt;
use std::hash::{Hash, Hasher};
+use std::marker::... | 2 | 6 | 8 |
9bee0ae9041ba23eb836cda3c5ffaee9649544c0 | Fernando Jiménez Moreno | 2017-06-29T01:04:58 | servo: Merge #17551 - stylo: implement indexed and count getters for custom properties (from ferjm:bug1375555.stylevariables); r=emilio
From https://bugzilla.mozilla.org/show_bug.cgi?id=1375555
Source-Repo: https://github.com/servo/servo
Source-Revision: b3e2b26a238f2e6683156f3aca880c44fc23a424 | diff --git a/style/custom_properties.rs b/style/custom_properties.rs
index e6dbabdbe..d5920a653 100644
--- a/style/custom_properties.rs
+++ b/style/custom_properties.rs
@@ -13,7 +13,7 @@ use properties::{CSSWideKeyword, DeclaredValue};
use selectors::parser::SelectorParseError;
use std::ascii::AsciiExt;
use std::bor... | 3 | 103 | 28 |
aaf1f5b0eaacba71b90bd9dafd102f5e45a4c4d8 | Emilio Cobos Álvarez | 2017-06-29T00:02:17 | servo: Merge #17550 - Fix dynamic style changes in XBL (from emilio:xbl-is-a-pain-in-the); r=heycam
From bug 1375969
Source-Repo: https://github.com/servo/servo
Source-Revision: c3a202b17d698b855d1aa775899e15e33347ca4e | diff --git a/style/dom.rs b/style/dom.rs
index 27e2a9f75..7d8112a05 100644
--- a/style/dom.rs
+++ b/style/dom.rs
@@ -31,6 +31,7 @@ use std::fmt::Debug;
use std::hash::Hash;
use std::ops::Deref;
use stylearc::Arc;
+use stylist::Stylist;
use thread_state;
pub use style_traits::UnsafeNode;
@@ -623,15 +624,34 @@ pub... | 4 | 125 | 76 |
5c095a170032b3cb5da4a375352c22e78a49af7a | Boris Chiou | 2017-06-28T23:02:33 | servo: Merge #17553 - stylo: Bug 1375812 - Build an identity matrix for InterpolateMatrix (from BorisChiou:stylo/animation/interpolatematrix_none); r=birtles
We have to build an identity matrix while add_weighted() between InterpolateMatrix and none transform in some cases, e.g. trigger a transition from a mid-point o... | diff --git a/style/properties/helpers/animated_properties.mako.rs b/style/properties/helpers/animated_properties.mako.rs
index 9e25244fe..476d53c09 100644
--- a/style/properties/helpers/animated_properties.mako.rs
+++ b/style/properties/helpers/animated_properties.mako.rs
@@ -1621,20 +1621,19 @@ fn build_identity_trans... | 1 | 5 | 6 |
1c156f1d28e89f3769243e2d565274a328b93fb9 | KuoE0 | 2017-06-28T20:01:32 | servo: Merge #17549 - Make '-moz-context-properties' support 'fill-opacity' and 'stroke-opacity' (from KuoE0:make-moz-context-properties-support-fill-opacity-and-stroke-opacity); r=heycam
Enable 'fill-opacity' and 'stroke-opacity' for '-moz-context-properties' to make the context-{fill|stroke}-opacity work in SVG-as-a... | diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs
index 3d972aead..3822acb95 100644
--- a/style/properties/gecko.mako.rs
+++ b/style/properties/gecko.mako.rs
@@ -4021,6 +4021,10 @@ clip-path
self.gecko.mContextPropsBits |= structs::NS_STYLE_CONTEXT_PROPERTY_FILL as u8;
... | 1 | 4 | 0 |
2faebc44c22dcec975b33c1f3c666c0a768009c4 | Matt Brubeck | 2017-06-28T17:08:37 | servo: Merge #17547 - Bug 1367312 - stylo: Implement :-moz-lwtheme* pseudo-classes (from mbrubeck:lwtheme); r=emilio
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix [bug 1367312]
- [x] There are tests for these changes
[bug 1367312]: https... | diff --git a/style/gecko/generated/bindings.rs b/style/gecko/generated/bindings.rs
index e8ec71f66..e94e1cd96 100644
--- a/style/gecko/generated/bindings.rs
+++ b/style/gecko/generated/bindings.rs
@@ -11,6 +11,8 @@ use gecko_bindings::structs::mozilla::css::URLValue;
use gecko_bindings::structs::mozilla::MallocSizeOf;... | 3 | 27 | 2 |
b13169b3a67a4f763c53d029c0916c301e6796c4 | Anthony Ramine | 2017-06-28T14:28:45 | servo: Merge #17543 - Make text-shadow and box-shadow use SimpleShadow (from servo:derive-all-the-things); r=emilio
Source-Repo: https://github.com/servo/servo
Source-Revision: 522d24d1260c93b570882e5bf42f2c9c25ef334c | diff --git a/layout/display_list_builder.rs b/layout/display_list_builder.rs
index 0f3e484b8..3bcc44014 100644
--- a/layout/display_list_builder.rs
+++ b/layout/display_list_builder.rs
@@ -57,7 +57,8 @@ use style::properties::style_structs;
use style::servo::restyle_damage::REPAINT;
use style::values::{Either, RGBA};... | 13 | 400 | 428 |
e9ccafd67ef9038c650ad3a01be08bffc13b892f | Connor Brewster | 2017-06-28T08:59:16 | servo: Merge #17527 - Don't return window proxy if it has been discarded (from cbrewster:iframe_cycles); r=asajeffrey
<!-- Please describe your changes on the following line: -->
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropria... | diff --git a/script/dom/document.rs b/script/dom/document.rs
index 60d4f52ef..ef3c53d42 100644
--- a/script/dom/document.rs
+++ b/script/dom/document.rs
@@ -406,7 +406,7 @@ impl Document {
#[inline]
pub fn browsing_context(&self) -> Option<Root<WindowProxy>> {
if self.has_browsing_context {
- ... | 2 | 11 | 10 |
b950f6b0ffb4892501a7ef3f4fbc0a4c8c9d1aab | Jonathan Chan | 2017-06-28T07:25:03 | servo: Merge #17535 - Have unsafe_no_jsmanaged_fields! macro take a type as argument rather than an ident (from jyc:unsafe-no-jsmanaged-field-ty); r=jdm
We only write unsafe_no_jsmanaged_fields!(SomeType), and the
documentation says it is to be used for types.
<!-- Please describe your changes on the following line: ... | diff --git a/script/dom/macros.rs b/script/dom/macros.rs
index 14c05bd3c..5bf3257d1 100644
--- a/script/dom/macros.rs
+++ b/script/dom/macros.rs
@@ -303,7 +303,7 @@ macro_rules! make_nonzero_dimension_setter(
/// For use on non-jsmanaged types
/// Use #[derive(JSTraceable)] on JS managed types
macro_rules! unsafe_no... | 1 | 1 | 1 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.