commit_hash stringlengths 40 40 | author stringlengths 1 57 | date timestamp[s]date 2010-07-26 04:45:09 2026-04-14 18:21:10 | message stringlengths 8 1.39M | diff stringlengths 68 51.2k | files_changed int64 1 136 | insertions int64 0 2.35k | deletions int64 0 1.9k |
|---|---|---|---|---|---|---|---|
4f1d3243e10c6353c6b3c9f8a2658cd61409b9d1 | Hiroyuki Ikezoe | 2017-07-29T06:01:10 | servo: Merge #17911 - Fix rotate_to_matrix (from hiikezoe:rotate-to-matrix); r=canaltinova
<!-- Please describe your changes on the following line: -->
https://bugzilla.mozilla.org/show_bug.cgi?id=1384410
---
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
Sourc... | diff --git a/style/properties/helpers/animated_properties.mako.rs b/style/properties/helpers/animated_properties.mako.rs
index 44501cf29..1b070e748 100644
--- a/style/properties/helpers/animated_properties.mako.rs
+++ b/style/properties/helpers/animated_properties.mako.rs
@@ -1738,7 +1738,7 @@ fn add_weighted_transform... | 1 | 10 | 10 |
16c33e696bd4b6e3312e5463398a4ce0fda0bae1 | Boris Chiou | 2017-07-29T04:55:55 | servo: Merge #17903 - stylo: Implement ToCss for SpecifiedOperation::{InterpolateMatrix|AccumulateMatrix} (from BorisChiou:stylo/animation/interpolatematrix_to_css); r=birtles
DevTools may serialize an InterpolateMatrix or AccumulateMatrix by
KeyframeEffectReadOnly::GetProperties() (from Gecko side), so we have to imp... | diff --git a/style/properties/longhand/box.mako.rs b/style/properties/longhand/box.mako.rs
index f9ed53a42..7bdb7c1c1 100644
--- a/style/properties/longhand/box.mako.rs
+++ b/style/properties/longhand/box.mako.rs
@@ -979,7 +979,14 @@ ${helpers.predefined_type(
dest, "rotate3d({}, {}, {}, {})",
... | 1 | 8 | 1 |
1c29ca216f80c1266432c005d007915e491f052f | Boris Zbarsky | 2017-07-29T03:51:20 | servo: Merge #17912 - Implement ::first-line support in stylo (from bzbarsky:stylo-first-line); r=emilio
<!-- Please describe your changes on the following line: -->
Fixes Gecko bug 1324619.
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` w... | diff --git a/style/context.rs b/style/context.rs
index 997a3f375..3a17f5d5b 100644
--- a/style/context.rs
+++ b/style/context.rs
@@ -191,7 +191,7 @@ pub struct CascadeInputs {
impl CascadeInputs {
/// Construct inputs from previous cascade results, if any.
- pub fn new_from_style(style: &Arc<ComputedValues>)... | 8 | 127 | 28 |
d1f117780f59ecc95699b187e68e6e70f777dd71 | Xidorn Quan | 2017-07-29T02:49:38 | servo: Merge #17913 - Have check_allowed_in read gPropertyEabled table directly (from upsuper:prop-enabled); r=Manishearth
This is the Servo side change of [bug 1381690](https://bugzilla.mozilla.org/show_bug.cgi?id=1381690).
Source-Repo: https://github.com/servo/servo
Source-Revision: b47e1876bd36656aefdc78d630be554b... | diff --git a/style/gecko/generated/bindings.rs b/style/gecko/generated/bindings.rs
index 4a0604852..5a8de33b0 100644
--- a/style/gecko/generated/bindings.rs
+++ b/style/gecko/generated/bindings.rs
@@ -1418,9 +1418,6 @@ extern "C" {
pub fn Gecko_ReleaseCSSValueSharedListArbitraryThread(aPtr:
... | 2 | 2 | 4 |
825bb1265087cfc076891ccbecbf00333ab0a470 | Boris Zbarsky | 2017-07-29T01:12:37 | servo: Merge #17909 - Don't reconstruct the layout object when going from no pseudo to pseudo with no content for ::before and ::after (from bzbarsky:dont-reframe-before-after); r=emilio
Fixes Gecko bug 1376073. r=emilio
<!-- Please describe your changes on the following line: -->
---
<!-- Thank you for contributin... | diff --git a/style/context.rs b/style/context.rs
index 9393c3522..997a3f375 100644
--- a/style/context.rs
+++ b/style/context.rs
@@ -232,7 +232,7 @@ impl Clone for EagerPseudoCascadeInputs {
impl EagerPseudoCascadeInputs {
/// Construct inputs from previous cascade results, if any.
fn new_from_style(styles: ... | 5 | 70 | 12 |
48a4dfdaf3e5e568b49b62436f0bddeeb9ab8b8d | Wes Kocher | 2017-07-28T23:20:27 | Backed out changeset c424ad1c5f94 for build failures a=backout CLOSED TREE
MozReview-Commit-ID: 2wv9vOLQSHp | diff --git a/compositing/compositor.rs b/compositing/compositor.rs
index 4dd167fa9..051454400 100644
--- a/compositing/compositor.rs
+++ b/compositing/compositor.rs
@@ -6,7 +6,7 @@ use CompositionPipeline;
use SendableFrameTree;
use compositor_thread::{CompositorProxy, CompositorReceiver};
use compositor_thread::{In... | 11 | 70 | 94 |
cf3fe53bed9a4d84a00f9c27909723737a061ef8 | Sebastian Hengst | 2017-07-28T22:04:59 | Backed out changeset a417b9d7712d for vendoring bustage. r=backout on a CLOSED TREE | diff --git a/script/dom/servoparser/async_html.rs b/script/dom/servoparser/async_html.rs
index 59411fda1..243e4452b 100644
--- a/script/dom/servoparser/async_html.rs
+++ b/script/dom/servoparser/async_html.rs
@@ -7,8 +7,9 @@
use dom::bindings::codegen::Bindings::HTMLTemplateElementBinding::HTMLTemplateElementMethods;
... | 4 | 222 | 466 |
b21aa339533b09810b62bc17e1e620b571614122 | Dzmitry Malyshau | 2017-07-28T18:26:52 | servo: Merge #17892 - WR multi-document update (from kvark:wr); r=glennw
<!-- Please describe your changes on the following line: -->
The PR updates WR version to support multiple documents (https://github.com/servo/webrender/pull/1509) but doesn't take advantage of this new feature yet.
It also makes Servo to use `De... | diff --git a/compositing/compositor.rs b/compositing/compositor.rs
index 051454400..4dd167fa9 100644
--- a/compositing/compositor.rs
+++ b/compositing/compositor.rs
@@ -6,7 +6,7 @@ use CompositionPipeline;
use SendableFrameTree;
use compositor_thread::{CompositorProxy, CompositorReceiver};
use compositor_thread::{In... | 11 | 94 | 70 |
f2d114f74e49a40480b023de90ef738a5b82e8a1 | Nikhil Shagrithaya | 2017-07-28T17:23:29 | servo: Merge #17565 - Servo's async Tokenizer: New! Improved! Now with multithreading! (from cynicaldevil:new-parser-thread); r=nox,jdm
<!-- Please describe your changes on the following line: -->
The Tokenizer, defined in the file `async_html.rs` will run on the main thread, while h5e's `Tokenizer`(along with its Si... | diff --git a/script/dom/servoparser/async_html.rs b/script/dom/servoparser/async_html.rs
index 243e4452b..59411fda1 100644
--- a/script/dom/servoparser/async_html.rs
+++ b/script/dom/servoparser/async_html.rs
@@ -7,9 +7,8 @@
use dom::bindings::codegen::Bindings::HTMLTemplateElementBinding::HTMLTemplateElementMethods;
... | 4 | 466 | 222 |
7b3da75665d26e6a89ddcf0ffa68b51252e33a33 | Cameron McCormack | 2017-07-28T14:08:24 | servo: Merge #17901 - style: Remove now-unused empty Variables struct (from heycam:rm-empty-variables); r=emilio
<!-- Please describe your changes on the following line: -->
The `Servo_GetEmptyVariables` FFI function no longer has any callers from Gecko, so we can remove it and the code that creates/frees that struct... | diff --git a/style/gecko/generated/bindings.rs b/style/gecko/generated/bindings.rs
index 41ae49a43..4a0604852 100644
--- a/style/gecko/generated/bindings.rs
+++ b/style/gecko/generated/bindings.rs
@@ -2866,9 +2866,6 @@ extern "C" {
index: u32, name: *mut nsAString)
-> boo... | 2 | 0 | 29 |
8bbf97ea59653bafa13bd6ae33502574f9c1a972 | Boris Chiou | 2017-07-28T07:08:31 | servo: Merge #17898 - stylo: Fix compute_squared_distance for AnimatedFilterList (from BorisChiou:stylo/animation/filter_distance); r=birtles
We implement compute_distance for Angle to avoid returning Err(()) from it, and then rewrite compute_squared_distance of AnimatedFilterLIst to avoid using unwrap() and make it s... | diff --git a/style/Cargo.toml b/style/Cargo.toml
index f09485c3c..01436213c 100644
--- a/style/Cargo.toml
+++ b/style/Cargo.toml
@@ -44,6 +44,7 @@ euclid = "0.15"
fnv = "1.0"
heapsize = {version = "0.4", optional = true}
heapsize_derive = {version = "0.1", optional = true}
+itertools = "0.5"
itoa = "0.3"
html5ever... | 3 | 22 | 29 |
e70ac497c2dc0b1f5d53f7de4f01650ef6497920 | Xidorn Quan | 2017-07-28T05:32:11 | servo: Merge #17902 - Upgrade to bindgen 0.29 (from upsuper:update-bindgen); r=heycam
Source-Repo: https://github.com/servo/servo
Source-Revision: 9566f83c2740b11fe9b7c230ae62600deae0ff7d | diff --git a/style/Cargo.toml b/style/Cargo.toml
index c6424c5b6..f09485c3c 100644
--- a/style/Cargo.toml
+++ b/style/Cargo.toml
@@ -78,7 +78,7 @@ kernel32-sys = "0.2"
[build-dependencies]
lazy_static = "0.2"
log = "0.3"
-bindgen = { version = "0.26.1", optional = true }
+bindgen = { version = "0.29", optional = tru... | 1 | 1 | 1 |
0a2c9b0e2b04250e24c9edefa3f49aa8e3d8e2fc | Manish Goregaokar | 2017-07-28T00:32:30 | servo: Merge #17897 - Bump app units version (take 2) (from Manishearth:bump-au); r=emilio
Source-Repo: https://github.com/servo/servo
Source-Revision: b1d97460419cc60159442fbfc2df483c488597ab | diff --git a/style/Cargo.toml b/style/Cargo.toml
index ec98f0a38..c6424c5b6 100644
--- a/style/Cargo.toml
+++ b/style/Cargo.toml
@@ -30,7 +30,7 @@ testing = []
gecko_debug = ["nsstring_vendor/gecko_debug"]
[dependencies]
-app_units = "0.5"
+app_units = "0.5.1"
arrayvec = "0.3.20"
arraydeque = "0.2.3"
atomic_refc... | 1 | 1 | 1 |
a09f1910594efd9e8b6001c4a74b75725e97607f | Nazım Can Altınova | 2017-07-27T21:15:02 | servo: Merge #17894 - Implement parsing/serialization for @font-feature-values rule (from canaltinova:at-font-feature-values); r=SimonSapin,xidorn
<!-- Please describe your changes on the following line: -->
This is reviewed by SimonSapin and xidorn in [Bug 1365900](https://bugzilla.mozilla.org/show_bug.cgi?id=1365900... | diff --git a/script/dom/cssrule.rs b/script/dom/cssrule.rs
index 32e6ad054..40bd08789 100644
--- a/script/dom/cssrule.rs
+++ b/script/dom/cssrule.rs
@@ -78,6 +78,7 @@ impl CSSRule {
StyleCssRule::Import(s) => Root::upcast(CSSImportRule::new(window, parent_stylesheet, s)),
StyleCssRule::Style(s... | 11 | 482 | 7 |
f37f4716ccdff53e3b630a739c0c0b8ecb986f6a | Nathan Froyd | 2017-07-27T16:07:29 | servo: Merge #17890 - remove workspace key for components/atoms (from froydnj:atoms-workspace); r=jdm
Cargo will already traverse up the directory hierarchy to find an
appropriate workspace, so we don't need to specify anything here. This
change brings components/atoms/Cargo.toml in line with other Cargo.toml
files i... | diff --git a/atoms/Cargo.toml b/atoms/Cargo.toml
index 449f627fe..ff149db72 100644
--- a/atoms/Cargo.toml
+++ b/atoms/Cargo.toml
@@ -5,7 +5,6 @@ authors = ["The Servo Project Developers"]
license = "MPL-2.0"
publish = false
build = "build.rs"
-workspace = "../.."
[lib]
path = "lib.rs" | 1 | 0 | 1 |
1417da163f39e853daa012b07b315f0b60e1b8dd | Jeremy Chen | 2017-07-27T13:25:20 | servo: Merge #17889 - stylo: remove bogus optimization check in replace_rules() for visited styles (from chenpighead:fix-transition-visited); r=hiro
We skipped updating the rule nodes for visited rules during animation-only restyle.
However, this causes isseus that visited style overrides animation styles on visited e... | diff --git a/style/matching.rs b/style/matching.rs
index 24e16cff2..ccd18f75f 100644
--- a/style/matching.rs
+++ b/style/matching.rs
@@ -647,14 +647,12 @@ pub trait MatchMethods : TElement {
CascadeVisitedMode::Unvisited,
cascade_inputs,
);
- if !context.shared.traversal_flags.... | 1 | 6 | 8 |
f08311fbc0a598908e58e2b00584877187250c06 | Emilio Cobos Álvarez | 2017-07-27T11:04:23 | servo: Merge #17888 - style: Avoid exponential blowup when processing invalidations of the same kind (from emilio:o-to-the-n); r=heycam
Bug: 1383981
Reviewed-by: heycam
MozReview-Commit-ID: HZ97UwvblkQ
Source-Repo: https://github.com/servo/servo
Source-Revision: a56d3a5381eb850ea1d26d6ce5f49f105172bf84 | diff --git a/style/invalidation/element/invalidator.rs b/style/invalidation/element/invalidator.rs
index ff60ecc32..055e3e6f3 100644
--- a/style/invalidation/element/invalidator.rs
+++ b/style/invalidation/element/invalidator.rs
@@ -35,6 +35,16 @@ pub struct TreeStyleInvalidator<'a, 'b: 'a, E>
type InvalidationVecto... | 1 | 143 | 29 |
7afc0da8ef29c272bf424f21b083a180e7d29976 | Simon Sapin | 2017-07-27T08:13:34 | servo: Merge #17884 - Upgrade to rustc 1.21.0-nightly (599be0d18 2017-07-26) (from servo:rustup); r=Manishearth
Source-Repo: https://github.com/servo/servo
Source-Revision: 9370a0c4b500a1ad9dc29c0ad8a37d47f00d0817 | diff --git a/gfx/text/shaping/harfbuzz.rs b/gfx/text/shaping/harfbuzz.rs
index 19827c2b1..ce61dd30c 100644
--- a/gfx/text/shaping/harfbuzz.rs
+++ b/gfx/text/shaping/harfbuzz.rs
@@ -421,7 +421,7 @@ lazy_static! {
hb_font_funcs_set_glyph_h_kerning_func(
hb_funcs, Some(glyph_h_kerning_func), ptr::nul... | 18 | 30 | 30 |
75076994d9980f76bd672126d5690aba8336f287 | Emilio Cobos Álvarez | 2017-07-27T07:10:46 | servo: Merge #17881 - style: fix alignment in call to get_all_matching_rules (from emilio:fncall); r=canaltinova
Source-Repo: https://github.com/servo/servo
Source-Revision: 9645ecef3e138de65f205e44ce41257e2ae0bcd0 | diff --git a/style/stylist.rs b/style/stylist.rs
index 29633ae85..1629827a9 100644
--- a/style/stylist.rs
+++ b/style/stylist.rs
@@ -1203,7 +1203,7 @@ impl Stylist {
&rule_hash_target,
applicable_declarations,
... | 1 | 1 | 1 |
174d3c0d81addcb387fce4b4fe14b5a70be9f2b1 | Manish Goregaokar | 2017-07-27T06:09:24 | servo: Merge #17880 - stylo: call update_border_foo when inheriting borders too (from Manishearth:stylo-update-border); r=emilio
this fixes the reftest failure in layout/reftests/bugs/731521-1.html
Source-Repo: https://github.com/servo/servo
Source-Revision: 33c950469034c2b4dbd45a5014d0b6c3560c1dd9 | diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs
index 08a759510..3b92e2071 100644
--- a/style/properties/gecko.mako.rs
+++ b/style/properties/gecko.mako.rs
@@ -378,10 +378,13 @@ impl ${style_struct.gecko_struct_name} {
}
</%def>
-<%def name="impl_simple_copy(ident, gecko_ffi_name, *... | 1 | 5 | 2 |
3fa0a2cb8cbf9bf16bfd2f0620156783a79001d3 | Hiroyuki Ikezoe | 2017-07-27T03:52:40 | servo: Merge #17879 - MatrixDecomposed3D.add_weighted() is called with zero value for other… (from hiikezoe:fix-assert); r=hiikezoe
…_portion in case of iteration composite.
In the case where we accumulate transform:none onto decomposed matrix for
iteration composite whose iteration count is over 2, we pass zero
othe... | diff --git a/style/properties/helpers/animated_properties.mako.rs b/style/properties/helpers/animated_properties.mako.rs
index 17c10809a..4b734167c 100644
--- a/style/properties/helpers/animated_properties.mako.rs
+++ b/style/properties/helpers/animated_properties.mako.rs
@@ -2274,7 +2274,7 @@ impl Animatable for Matri... | 1 | 1 | 1 |
427701ede7bf983a4afdde057c6368d38df8af6c | Wes Kocher | 2017-07-27T01:39:40 | Backed out changeset 1c8d22359d5d because the gecko half was backed out a=backout CLOSED TREE
MozReview-Commit-ID: 6dEpUMwimww | diff --git a/style/Cargo.toml b/style/Cargo.toml
index c6424c5b6..ec98f0a38 100644
--- a/style/Cargo.toml
+++ b/style/Cargo.toml
@@ -30,7 +30,7 @@ testing = []
gecko_debug = ["nsstring_vendor/gecko_debug"]
[dependencies]
-app_units = "0.5.1"
+app_units = "0.5"
arrayvec = "0.3.20"
arraydeque = "0.2.3"
atomic_refc... | 1 | 1 | 1 |
21eea0e6c5f346c9f0c56be57f665382cb8abb4b | Manish Goregaokar | 2017-07-26T21:53:58 | servo: Merge #17878 - stylo: Bump app units version (from Manishearth:bump-au); r=emilio
r=emilio https://bugzilla.mozilla.org/show_bug.cgi?id=1383492
Source-Repo: https://github.com/servo/servo
Source-Revision: 27031b996b905bbe42234729a63352cd7579f0fa | diff --git a/style/Cargo.toml b/style/Cargo.toml
index ec98f0a38..c6424c5b6 100644
--- a/style/Cargo.toml
+++ b/style/Cargo.toml
@@ -30,7 +30,7 @@ testing = []
gecko_debug = ["nsstring_vendor/gecko_debug"]
[dependencies]
-app_units = "0.5"
+app_units = "0.5.1"
arrayvec = "0.3.20"
arraydeque = "0.2.3"
atomic_refc... | 1 | 1 | 1 |
96e50b7627ae61985bbee1c4c1eae32a94ae8f2e | Boris Zbarsky | 2017-07-26T20:21:37 | servo: Merge #17875 - Add support for having two separate parent styles. Fixes gecko bug 1382806 (from bzbarsky:first-line-dual-inheritance); r=emilio
<!-- Please describe your changes on the following line: -->
This is needed for ::first-line support. See https://drafts.csswg.org/css-pseudo-4/#first-line-inheritan... | diff --git a/style/animation.rs b/style/animation.rs
index d90467c7e..69b94edb5 100644
--- a/style/animation.rs
+++ b/style/animation.rs
@@ -499,6 +499,7 @@ fn compute_style_for_animation_step(context: &SharedStyleContext,
iter,
... | 11 | 109 | 33 |
35bfe08e05bfab07ff9fa5b2e1997dd3d580b6f5 | Nazım Can Altınova | 2017-07-26T19:13:02 | servo: Merge #17877 - Cleanup @font-face rule constructor (from canaltinova:font-face-refactoring); r=jdm
Passing SourceLocation into constructor instead of assigning
immediately after construction cleans up the code and helps to
prevent leaving an invalid SourceLocation in the future.
- [X] `./mach build -d` does no... | diff --git a/style/font_face.rs b/style/font_face.rs
index 3dca24182..23f1496b1 100644
--- a/style/font_face.rs
+++ b/style/font_face.rs
@@ -110,8 +110,7 @@ impl Parse for FontWeight {
/// Note that the prelude parsing code lives in the `stylesheets` module.
pub fn parse_font_face_block(context: &ParserContext, input... | 1 | 3 | 7 |
0cf83760d8094392ce5d100bdf930f569492b6ee | Emilio Cobos Álvarez | 2017-07-26T12:51:21 | servo: Merge #17871 - Revert "Auto merge of #17868 - ferjm:bug1380259.radial.gradients, r=xidorn" (from emilio:revert-gradient-stuff); r=emilio
This reverts commit ef233381cc1d6389205a57c9b2a08617880abc49, reversing
changes made to f61528d2977b11673af30e075b4556a2a30f5aaf.
This broke a bunch of tests in m-c, like:
... | diff --git a/style/gecko/conversions.rs b/style/gecko/conversions.rs
index 9e808b5c3..2426bef42 100644
--- a/style/gecko/conversions.rs
+++ b/style/gecko/conversions.rs
@@ -297,7 +297,7 @@ impl nsStyleImage {
Gecko_CreateGradient(gecko_shape,
gecko_size,
... | 3 | 20 | 70 |
5b9d39f11c05360894787d2efcfc886dd1528534 | Josh Matthews | 2017-07-26T11:46:13 | servo: Merge #17859 - Add message suffixes to stylo error reports (from jdm:geckodecl); r=heycam
This is the Servo-side part of https://bugzilla.mozilla.org/show_bug.cgi?id=1381137. This allows us to add the "Declaration dropped" or "Skipped to next declaration" messages after relevant CSS errors that are reported.
-... | diff --git a/style/gecko/generated/bindings.rs b/style/gecko/generated/bindings.rs
index 962cf8056..223aec069 100644
--- a/style/gecko/generated/bindings.rs
+++ b/style/gecko/generated/bindings.rs
@@ -2845,5 +2845,6 @@ extern "C" {
source:
... | 1 | 2 | 1 |
67e55b1074df5d6bb8612fa9f63612f13a14a562 | Fernando Jiménez Moreno | 2017-07-26T10:20:33 | servo: Merge #17868 - stylo: serialize radial gradients using modern unprefixed style (from ferjm:bug1380259.radial.gradients); r=xidorn
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
https://bugzilla.mozilla.org/show_bug.cgi?id=1380259
Source-Repo: https://git... | diff --git a/style/gecko/conversions.rs b/style/gecko/conversions.rs
index 2426bef42..9e808b5c3 100644
--- a/style/gecko/conversions.rs
+++ b/style/gecko/conversions.rs
@@ -297,7 +297,7 @@ impl nsStyleImage {
Gecko_CreateGradient(gecko_shape,
gecko_size,
... | 3 | 70 | 20 |
06ae77586a85462d98fbc927729572880b36cc7f | Emilio Cobos Álvarez | 2017-07-26T09:15:30 | servo: Merge #17867 - style: Don't skip computation of pseudo-elements of display: none elements (from emilio:pseudo-display-none); r=heycam
We have optimizations to avoid doing selector-matching when the style attribute
changes, so, given you can toggle the display property and the pseudo-elements
will suddenly becom... | diff --git a/style/style_resolver.rs b/style/style_resolver.rs
index 306aba45e..71be0609a 100644
--- a/style/style_resolver.rs
+++ b/style/style_resolver.rs
@@ -140,19 +140,10 @@ where
parent_style: Option<&ComputedValues>,
layout_parent_style: Option<&ComputedValues>,
) -> ElementStyles {
- ... | 1 | 2 | 21 |
b8f8ec642d8d4060151647dc35480be09a03b9e9 | Daisuke Akatsuka | 2017-07-26T04:21:53 | servo: Merge #17865 - make font-variant-alternates animatable (from dadaa:bug1379921); r=hiro
<!-- Please describe your changes on the following line: -->
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./ma... | diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs
index b8c2b8860..08a759510 100644
--- a/style/properties/gecko.mako.rs
+++ b/style/properties/gecko.mako.rs
@@ -2119,6 +2119,59 @@ fn static_assert() {
}
}
+ pub fn clone_font_variant_alternates(&self) -> longhands::font_var... | 2 | 54 | 1 |
548b167b129da80d8ed519d9788f9a5daadeb3c5 | Glenn Watson | 2017-07-26T02:16:34 | servo: Merge #17863 - Update WR (scroll/overflow mostly) (from glennw:update-wr-scroll-stuff); r=emilio
Source-Repo: https://github.com/servo/servo
Source-Revision: f351e6819873d208f2fc2b6b9908f8d91655296f | diff --git a/gfx/display_list/mod.rs b/gfx/display_list/mod.rs
index 22d37d05c..ba34abea2 100644
--- a/gfx/display_list/mod.rs
+++ b/gfx/display_list/mod.rs
@@ -34,7 +34,7 @@ use style_traits::cursor::Cursor;
use text::TextRun;
use text::glyph::ByteIndex;
use webrender_api::{self, ClipId, ColorF, GradientStop, Local... | 3 | 20 | 33 |
e852a5c7f2b46c3b3d5f6c8f3be5c69f31ad15ca | Emilio Cobos Álvarez | 2017-07-25T22:42:37 | servo: Merge #17858 - selectors: Fix note_next_sequence (from emilio:hover-quirk-broken); r=canaltinova
Selector-matching can backtrack when looking for ancestor combinators, so we
can't just arrive there once and forget.
Also, there was a further problem before this patch, which was that
note_next_sequence was calle... | diff --git a/selectors/matching.rs b/selectors/matching.rs
index f65703d05..7bd9814d2 100644
--- a/selectors/matching.rs
+++ b/selectors/matching.rs
@@ -93,10 +93,10 @@ impl<'a, 'b, Impl> LocalMatchingContext<'a, 'b, Impl>
/// Updates offset of Selector to show new compound selector.
/// To be able to corre... | 1 | 8 | 7 |
6f39e20d6215fc72082157a4960d24ea99600930 | Manish Goregaokar | 2017-07-25T21:33:19 | servo: Merge #17856 - Use saturating ops when passing computed clip value to gecko (fix bug 1384150) (from Manishearth:stylo-clip-overflow); r=emilio
https://bugzilla.mozilla.org/show_bug.cgi?id=1384150
Source-Repo: https://github.com/servo/servo
Source-Revision: 002ea74a713860be5e537f0113f4cfbb1925cb33 | diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs
index 0c71b82c8..b8c2b8860 100644
--- a/style/properties/gecko.mako.rs
+++ b/style/properties/gecko.mako.rs
@@ -3723,14 +3723,14 @@ fn static_assert() {
}
if let Some(bottom) = rect.bottom {
- ... | 1 | 2 | 2 |
f06427e0c1376215b4e8d9b56baff9fe59e9d4de | Xidorn Quan | 2017-07-25T09:09:45 | servo: Merge #17850 - Record viewport unit usage and generate proper restyle hint (from upsuper:bug1382077); r=heycam
This is the Servo side change of [bug 1382077](https://bugzilla.mozilla.org/show_bug.cgi?id=1382077).
Source-Repo: https://github.com/servo/servo
Source-Revision: e825bf14427c6aab239a82e09d0915467f23a... | diff --git a/style/gecko/generated/bindings.rs b/style/gecko/generated/bindings.rs
index fb3d1a35c..962cf8056 100644
--- a/style/gecko/generated/bindings.rs
+++ b/style/gecko/generated/bindings.rs
@@ -1921,8 +1921,9 @@ extern "C" {
pub fn Servo_StyleSet_RebuildData(set: RawServoStyleSetBorrowed);
}
extern "C" {
... | 3 | 18 | 2 |
bc386a82228590e11539da2370b3905a647a98ab | Cameron McCormack | 2017-07-25T07:51:27 | servo: Merge #17849 - style: Ensure we generate a ReconstructFrame hint when -moz-binding changes on a display:none root (from heycam:binding-display-none); r=emilio
From https://bugzilla.mozilla.org/show_bug.cgi?id=1375383.
Source-Repo: https://github.com/servo/servo
Source-Revision: 3eeb0e5e48fcb045100ed26b396ad852... | diff --git a/style/gecko/restyle_damage.rs b/style/gecko/restyle_damage.rs
index 7d0c29c23..b0f606630 100644
--- a/style/gecko/restyle_damage.rs
+++ b/style/gecko/restyle_damage.rs
@@ -6,7 +6,7 @@
use gecko_bindings::bindings;
use gecko_bindings::structs;
-use gecko_bindings::structs::{nsChangeHint, nsStyleContext}... | 3 | 45 | 3 |
7c24ff7f06a83f8d88cd0a0788965ef0780635bc | Cameron McCormack | 2017-07-25T02:13:08 | servo: Merge #17839 - style: allow out-of-range opacity values for SMIL animations (from heycam:opacity-smil); r=hiro
From https://bugzilla.mozilla.org/show_bug.cgi?id=1371150.
Source-Repo: https://github.com/servo/servo
Source-Revision: bf16b146e8edbf3e3513188fe495354546160988 | diff --git a/style/gecko/media_queries.rs b/style/gecko/media_queries.rs
index 62e891eed..7ce33b506 100644
--- a/style/gecko/media_queries.rs
+++ b/style/gecko/media_queries.rs
@@ -650,6 +650,7 @@ impl Expression {
in_media_query: true,
// TODO: pass the correct value here.
quirks... | 6 | 18 | 1 |
565c0797c55f7e73fc770d3e4179a57c27bd61b7 | Manish Goregaokar | 2017-07-25T00:26:31 | servo: Merge #17846 - Allow nonstandard font-weight values for system fonts (from Manishearth:font-weight); r=upsuper a=tomcat
Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1379895
Source-Repo: https://github.com/servo/servo
Source-Revision: b8ac4a7a2efabe11af1366207f9649982250c0e2 | diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs
index ede7eac91..3d7217207 100644
--- a/style/properties/gecko.mako.rs
+++ b/style/properties/gecko.mako.rs
@@ -2022,10 +2022,8 @@ fn static_assert() {
${impl_simple_copy('font_weight', 'mFont.weight')}
pub fn clone_font_weight(&se... | 2 | 8 | 6 |
b372f728530e5558cda42b4b276ce979afe523a7 | Manish Goregaokar | 2017-07-25T00:26:31 | servo: Merge #17846 - Allow nonstandard font-weight values for system fonts (from Manishearth:font-weight); r=upsuper
Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1379895
Source-Repo: https://github.com/servo/servo
Source-Revision: b8ac4a7a2efabe11af1366207f9649982250c0e2 | diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs
index e6f1c42e3..0c71b82c8 100644
--- a/style/properties/gecko.mako.rs
+++ b/style/properties/gecko.mako.rs
@@ -2022,10 +2022,8 @@ fn static_assert() {
${impl_simple_copy('font_weight', 'mFont.weight')}
pub fn clone_font_weight(&se... | 2 | 8 | 6 |
8fc5ea7371f7c785b1912c88cff32179e833c8c8 | Brian Birtles | 2017-07-24T22:50:20 | servo: Merge #17832 - Only allow animation-timing-function in @keyframes (from birtles:disallow-playstate-keyframes); r=emilio
CSS animations used to erroneously indicate that 'animation-play-state' is permitted in @keyframes. It is not and it'ss non-sensical to allow it there. This mistake was faithfully transferred ... | diff --git a/style/properties/longhand/box.mako.rs b/style/properties/longhand/box.mako.rs
index 41e7a3fb4..f9ed53a42 100644
--- a/style/properties/longhand/box.mako.rs
+++ b/style/properties/longhand/box.mako.rs
@@ -591,6 +591,8 @@ ${helpers.predefined_type("animation-duration",
extra_prefix... | 1 | 3 | 3 |
44952478adb63f4667311fc3c8381c9f98adb132 | Emilio Cobos Álvarez | 2017-07-24T20:22:49 | servo: Merge #17844 - stylo: Read mName as a raw nsIAtom* from NodeInfoInner (from emilio:is-visited); r=bholley
Changes for bug 1383756.
Source-Repo: https://github.com/servo/servo
Source-Revision: 897f5d8884063d903a54cbb186866069c5be97a9 | diff --git a/style/gecko/generated/structs_debug.rs b/style/gecko/generated/structs_debug.rs
index 5a6c073d0..bcdae124f 100644
--- a/style/gecko/generated/structs_debug.rs
+++ b/style/gecko/generated/structs_debug.rs
@@ -4206,19 +4206,21 @@ pub mod root {
fn clone(&self) -> Self { *self }
... | 4 | 60 | 22 |
c0a00d129b63618eaea3f3555fbb698c8f867048 | Alexis Beingessner | 2017-07-24T16:02:50 | servo: Merge #17406 - use DisplayListBuilder::with_capacity (from Gankro:with_cap); r=jdm
DO NOT MERGE until https://github.com/servo/webrender/pull/1399 has landed in Servo.
Previously webrender was reserving 1MB of space for each display list (empirically pages weighed between 100k and 10MB when I implemented this)... | diff --git a/layout/webrender_helpers.rs b/layout/webrender_helpers.rs
index b2521ff15..889ee087b 100644
--- a/layout/webrender_helpers.rs
+++ b/layout/webrender_helpers.rs
@@ -223,8 +223,9 @@ impl WebRenderDisplayListConverter for DisplayList {
fn convert_to_webrender(&self, pipeline_id: PipelineId) -> DisplayLis... | 1 | 3 | 2 |
f06c061d3f028699b25e6d83b5980b2010548b02 | Fernando Jiménez Moreno | 2017-07-24T14:55:06 | servo: Merge #17841 - stylo: make GetRuleColumn report a 1-based value (from ferjm:bug1380890.column); r=jdm
https://bugzilla.mozilla.org/show_bug.cgi?id=1380890
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
Source-Repo: https://github.com/servo/servo
Source-R... | diff --git a/style/stylesheets/rule_parser.rs b/style/stylesheets/rule_parser.rs
index d4c8b6eec..9c223be1f 100644
--- a/style/stylesheets/rule_parser.rs
+++ b/style/stylesheets/rule_parser.rs
@@ -515,6 +515,7 @@ fn get_location_with_offset(
) -> SourceLocation {
SourceLocation {
line: location.line + of... | 1 | 2 | 1 |
3ab7a6dd7739db84fbce3f36fc074a782fb19806 | Emilio Cobos Álvarez | 2017-07-24T11:49:08 | servo: Merge #17837 - style: Avoid looking at descendant hints to check whether the element needs a restyle (from emilio:assert-fix); r=hiikezoe
This makes us hit some assertions in Gecko.
Source-Repo: https://github.com/servo/servo
Source-Revision: 9f412caab21ae407173187cdb5d0250fb1ae6b37 | diff --git a/style/data.rs b/style/data.rs
index 21d352523..c835593fe 100644
--- a/style/data.rs
+++ b/style/data.rs
@@ -324,7 +324,7 @@ impl ElementData {
}
debug_assert!(hint.has_recascade_self(),
- "We definitely need to do something!");
+ "We definitely ... | 3 | 8 | 4 |
66ade1669712ba575ce26cd7c0fe224e38a18884 | Keith Yeung | 2017-07-24T10:07:26 | servo: Merge #17835 - Make network error messages more specific (from KiChjang:clearer-network-error); r=emilio
Instead of having a bogus "Network error" string, we extract the NetworkError struct from the Response and send it back to FetchResponseListener.
Source-Repo: https://github.com/servo/servo
Source-Revision:... | diff --git a/net_traits/lib.rs b/net_traits/lib.rs
index 8cece7086..7e841fd64 100644
--- a/net_traits/lib.rs
+++ b/net_traits/lib.rs
@@ -228,10 +228,8 @@ impl FetchTaskTarget for IpcSender<FetchResponseMsg> {
}
fn process_response_eof(&mut self, response: &Response) {
- if response.is_network_error()... | 1 | 2 | 4 |
14f0a1ba2877a7e61eb3578366c3668544c1f946 | Emilio Cobos Álvarez | 2017-07-24T08:09:24 | servo: Merge #17834 - stylo: Fix the interaction of frame construction restyles with animation restyles (from emilio:animation-fc-crash); r=heycam
Fixes bug 1383001.
Source-Repo: https://github.com/servo/servo
Source-Revision: 30d6d6024bd0a082424395621f620dc9580970e5 | diff --git a/style/data.rs b/style/data.rs
index 47cf4c8a8..21d352523 100644
--- a/style/data.rs
+++ b/style/data.rs
@@ -298,22 +298,16 @@ impl ElementData {
self.styles.primary.is_some()
}
- /// Returns whether we have any outstanding style invalidation.
- pub fn has_invalidations(&self) -> bool ... | 4 | 22 | 43 |
3dcf5b00b2b2a2ac8f25e0d0039cdf23f468dcc4 | Glenn Watson | 2017-07-24T03:04:38 | servo: Merge #17814 - Update WR (switch to new text-decorations API in WR) (from glennw:update-wr-text-decorations); r=emilio
This only makes use of the "Solid" text decoration type, which
matches the existing support. WR now supports dotted, dashed
and wavy text decorations, but supporting those will need some
extra ... | diff --git a/gfx/display_list/mod.rs b/gfx/display_list/mod.rs
index 69074e89a..22d37d05c 100644
--- a/gfx/display_list/mod.rs
+++ b/gfx/display_list/mod.rs
@@ -1146,7 +1146,8 @@ pub struct LineDisplayItem {
pub color: ColorF,
/// The line segment style.
- pub style: border_style::T
+ #[ignore_heap_si... | 3 | 16 | 6 |
ed33c3acb214315dcffba3abebd5ffb9a514573b | Emilio Cobos Álvarez | 2017-07-23T22:06:44 | servo: Merge #17829 - style: Mention when visited styles may be disabled (from emilio:visited-nit); r=Manishearth
Source-Repo: https://github.com/servo/servo
Source-Revision: 104c79dbf2fc83d3b4b36dfa8868b2071edf2d81 | diff --git a/style/context.rs b/style/context.rs
index d53af678a..5abad6c5e 100644
--- a/style/context.rs
+++ b/style/context.rs
@@ -118,6 +118,9 @@ pub struct SharedStyleContext<'a> {
pub stylist: &'a Stylist,
/// Whether visited styles are enabled.
+ ///
+ /// They may be disabled when Gecko's pref ... | 1 | 3 | 0 |
804b12acc062b62cc8d5a003e5229ade11f428ed | Emilio Cobos Álvarez | 2017-07-23T20:46:43 | servo: Merge #17828 - stylo: Visited link fixes (from emilio:visited-now); r=Manishearth
Straight from https://bugzilla.mozilla.org/show_bug.cgi?id=1383307
Source-Repo: https://github.com/servo/servo
Source-Revision: 2241d5879e5d66c52d2b4f17ad730c5de1eff364 | diff --git a/layout_thread/lib.rs b/layout_thread/lib.rs
index 2f0fa57e5..576588abd 100644
--- a/layout_thread/lib.rs
+++ b/layout_thread/lib.rs
@@ -594,6 +594,7 @@ impl LayoutThread {
stylist: &self.stylist,
options: StyleSystemOptions::default(),
guards: guards,
+ ... | 7 | 38 | 7 |
f1d024fe95e326e1805b62ced79dd90ed74f453b | Nikhil Shagrithaya | 2017-07-23T19:45:22 | servo: Merge #17827 - Update step annotations in script's prepare method (from cynicaldevil:fix-step-annotations); r=jdm
<!-- Please describe your changes on the following line: -->
The step annotations in the code were outdated, and did not match the spec: https://html.spec.whatwg.org/multipage/scripting.html#prepare... | diff --git a/script/dom/htmlscriptelement.rs b/script/dom/htmlscriptelement.rs
index 0a5e9b74a..ea0cc4c25 100644
--- a/script/dom/htmlscriptelement.rs
+++ b/script/dom/htmlscriptelement.rs
@@ -342,9 +342,11 @@ impl HTMLScriptElement {
return;
}
- // TODO(#4577): Step 11: CSP.
+ // ... | 1 | 27 | 25 |
bcb73d192fec1e3ace938194d33add989ebc67b5 | Emilio Cobos Álvarez | 2017-07-23T11:15:39 | servo: Merge #17825 - style: Move the RELEVANT_LINK_VISITED flag to servo (from emilio:is-visited); r=manishearth
Bug: 1383307
Reviewed-by: Manishearth
Source-Repo: https://github.com/servo/servo
Source-Revision: 14b12eeb3b7ff110dbdb1f9672c2cbfad4133ae0 | diff --git a/style/dom.rs b/style/dom.rs
index 12eff9c7c..a7f68a965 100644
--- a/style/dom.rs
+++ b/style/dom.rs
@@ -550,6 +550,11 @@ pub trait TElement : Eq + PartialEq + Debug + Hash + Sized + Copy + Clone +
unsafe fn unset_animation_only_dirty_descendants(&self) {
}
+ /// Returns true if this element ... | 6 | 61 | 8 |
8be17cb76630ac5d127dda9c1e42f3502e74f5e6 | Emilio Cobos Álvarez | 2017-07-23T00:50:21 | servo: Merge #17824 - layout: Make -Z show-parallel-layout show something useful again (from emilio:debug-par-layout); r=stshine
I broke this when we switched to rayon, but now rayon added support for getting the worker index there's no reason for not bringing it back to life.
Source-Repo: https://github.com/servo/se... | diff --git a/layout/parallel.rs b/layout/parallel.rs
index 713fdadcf..bdc178b74 100644
--- a/layout/parallel.rs
+++ b/layout/parallel.rs
@@ -127,6 +127,7 @@ fn buttom_up_flow(mut unsafe_flow: UnsafeFlow,
}
fn top_down_flow<'scope>(unsafe_flows: &[UnsafeFlow],
+ pool: &'scope rayon::ThreadPoo... | 1 | 7 | 10 |
a883467cda8b095719fef036e97702ac87c91507 | Emilio Cobos Álvarez | 2017-07-22T00:30:05 | servo: Merge #17819 - stylo: Set the NS_STYLE_IS_TEXT_COMBINED flag (from emilio:text-combined); r=xidorn
This should fix at least
layout/reftests/writing-mode/1135361-ruby-justify-1.html
Source-Repo: https://github.com/servo/servo
Source-Revision: e4ac067a9b4db4f8bee7cf0eebaabd807dd8627b | diff --git a/style/properties/computed_value_flags.rs b/style/properties/computed_value_flags.rs
index 50ad88741..2dc3d91e1 100644
--- a/style/properties/computed_value_flags.rs
+++ b/style/properties/computed_value_flags.rs
@@ -28,5 +28,10 @@ bitflags! {
/// This bit is propagated to all children of line part... | 2 | 8 | 0 |
9c8529817a99d06baa766abe8b81aa986436b459 | Manish Goregaokar | 2017-07-21T22:47:54 | servo: Merge #17822 - Remove last vestiges of stylearc (from Manishearth:die-stylearc-die); r=bzbarsky
Source-Repo: https://github.com/servo/servo
Source-Revision: 9b276565f82e5924a87e713a728daf63a357f3ba | diff --git a/style/lib.rs b/style/lib.rs
index 3280caa5c..debcfd816 100644
--- a/style/lib.rs
+++ b/style/lib.rs
@@ -139,10 +139,6 @@ pub mod traversal;
#[allow(non_camel_case_types)]
pub mod values;
-// Compat shim for the old name when it lived in the style crate.
-// FIXME(bholley) Remove this.
-pub use servo_ar... | 1 | 0 | 4 |
f31aafc9867bec6fad4673ff767af80d3687c07c | Emilio Cobos Álvarez | 2017-07-21T20:31:13 | servo: Merge #17817 - style: Move a conditional import to where it's used (from emilio:always-be-removing-the-ugly); r=stshine
To avoid yet another cfg().
Source-Repo: https://github.com/servo/servo
Source-Revision: d1c4d7a6af44de97f86205cb1a19408492f17833 | diff --git a/style/style_adjuster.rs b/style/style_adjuster.rs
index b8e234085..afd00c503 100644
--- a/style/style_adjuster.rs
+++ b/style/style_adjuster.rs
@@ -12,9 +12,6 @@ use properties::longhands::display::computed_value::T as display;
use properties::longhands::float::computed_value::T as float;
use properties:... | 1 | 2 | 3 |
6a2d28ea456cb0181686387f54d0c15b48a1862f | Boris Zbarsky | 2017-07-21T19:15:50 | servo: Merge #17821 - Implement restrictions on which properties apply to which pseudo-elements (from bzbarsky:pseudo-prop-restrictions); r=emilio
::first-line, ::first-letter, and ::placeholder don't allow all properties to apply to them.
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X... | diff --git a/style/gecko/pseudo_element.rs b/style/gecko/pseudo_element.rs
index 97ce0f4e5..7765122bd 100644
--- a/style/gecko/pseudo_element.rs
+++ b/style/gecko/pseudo_element.rs
@@ -10,6 +10,8 @@
use cssparser::{ToCss, serialize_identifier};
use gecko_bindings::structs::{self, CSSPseudoElementType};
+use propert... | 14 | 132 | 8 |
feb55c2ac4edcd482cb18f1c0d27a67381ee3c76 | Manish Goregaokar | 2017-07-21T18:05:13 | servo: Merge #17818 - stylo: Various ComputedValues fixes (from Manishearth:stylo-fixup); r=heycam
r=heycam https://bugzilla.mozilla.org/show_bug.cgi?id=1382017
Source-Repo: https://github.com/servo/servo
Source-Revision: 992c647f76552ae3abaeffc69331375a69d34dab | diff --git a/servo_arc/lib.rs b/servo_arc/lib.rs
index b1f4f277a..d8a747582 100644
--- a/servo_arc/lib.rs
+++ b/servo_arc/lib.rs
@@ -889,6 +889,12 @@ impl<'a, T> ArcBorrow<'a, T> {
arc
}
+ /// For constructing from a reference known to be Arc-backed,
+ /// e.g. if we obtain such a reference over F... | 7 | 216 | 207 |
132ac6c65a3cee3e56df899368f6a1003569fc98 | Xidorn Quan | 2017-07-21T16:01:57 | servo: Merge #17813 - Store raw string for prop decl in @supports (from upsuper:supports-decl); r=SimonSapin
This fixes the serialization issue of `@supports` rule that whitespaces are not preserved like in other browsers.
It makes the work a bit redundant (the property name and colon is parsed twice), but I suppose ... | diff --git a/script/dom/css.rs b/script/dom/css.rs
index 31ca21909..0ee5a9536 100644
--- a/script/dom/css.rs
+++ b/script/dom/css.rs
@@ -30,7 +30,11 @@ impl CSS {
/// https://drafts.csswg.org/css-conditional/#dom-css-supports
pub fn Supports(win: &Window, property: DOMString, value: DOMString) -> bool {
- ... | 2 | 26 | 31 |
4a96feca676c2e7e9ceb1c26e4d7233611441070 | Fernando Jiménez Moreno | 2017-07-21T13:22:58 | servo: Merge #17816 - PWM tests (from ferjm:pwm-tests); r=jdm
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] There are tests for these changes
Source-Repo: https://github.com/servo/servo
Source-Revision: 291c9576cf386179bddace6cd39815de03beb8f1 | diff --git a/metrics/lib.rs b/metrics/lib.rs
index 98773a1d2..0cbf703a1 100644
--- a/metrics/lib.rs
+++ b/metrics/lib.rs
@@ -110,4 +110,16 @@ impl PaintTimeMetrics {
}
}
}
+
+ pub fn get_navigation_start(&self) -> Option<f64> {
+ self.navigation_start
+ }
+
+ pub fn get_first_... | 1 | 12 | 0 |
3e3a0f714701108762277b0699d941e6ec7ebd34 | Fausto Núñez Alberro | 2017-07-21T06:52:56 | servo: Merge #17811 - Remove unused immeta dependency in net_traits (from brainlessdeveloper:remove-immeta-dep); r=jdm
<!-- Please describe your changes on the following line: -->
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropri... | diff --git a/net_traits/Cargo.toml b/net_traits/Cargo.toml
index b88bcca19..a29555e40 100644
--- a/net_traits/Cargo.toml
+++ b/net_traits/Cargo.toml
@@ -16,7 +16,6 @@ heapsize_derive = "0.1"
hyper = "0.10"
hyper_serde = "0.7"
image = "0.12"
-immeta = "0.3.1"
ipc-channel = "0.8"
lazy_static = "0.2"
log = "0.3.5" | 1 | 0 | 1 |
d6b7cf24ea602fb74cfd2b54c60413ed490ae047 | Emilio Cobos Álvarez | 2017-07-21T05:40:15 | servo: Merge #17806 - selectors: Don't track class and id ancestor hashes in quirks mode (from emilio:quirks-mode-bloom); r=bholley
It's incorrect to track classes and id selectors in a quirks-mode document,
since they should match case-insensitively.
Bug: 1382812
Reviewed-by: bholley
MozReview-Commit-ID: 4uvrfYsWb1v... | diff --git a/selectors/parser.rs b/selectors/parser.rs
index a1162701c..12cefc193 100644
--- a/selectors/parser.rs
+++ b/selectors/parser.rs
@@ -6,6 +6,7 @@ use attr::{AttrSelectorWithNamespace, ParsedAttrSelectorOperation, AttrSelectorO
use attr::{ParsedCaseSensitivity, SELECTOR_WHITESPACE, NamespaceConstraint};
use... | 2 | 23 | 14 |
42a05da4cf00f3609eed40fd80b04b15ca865c5d | Emilio Cobos Álvarez | 2017-07-21T04:38:58 | servo: Merge #17804 - Add a comment about visited style inheritance (from emilio:visited-comment); r=jryans
Source-Repo: https://github.com/servo/servo
Source-Revision: 3c89486de233d7fe8c81050399b5fc15cf6941aa | diff --git a/style/style_resolver.rs b/style/style_resolver.rs
index bd3eb57f7..71598ab14 100644
--- a/style/style_resolver.rs
+++ b/style/style_resolver.rs
@@ -474,6 +474,9 @@ where
cascade_flags.insert(SKIP_ROOT_AND_ITEM_BASED_DISPLAY_FIXUP);
}
if cascade_visited.visited_dependent_only(... | 1 | 3 | 0 |
e03d82b9468df4e9095763e9fe13b1276697c372 | Emilio Cobos Álvarez | 2017-07-21T03:28:25 | servo: Merge #17802 - Revert "Backed out changeset b10e6ba9cbdb because gecko part had to b… (from emilio:reland-stuff); r=heycam
…e backed out."
This reverts commit b96d96d448c8ff93f212f225013461999540a5d0.
The fix on the Gecko side is trivial, and I can land it after this lands.
Source-Repo: https://github.com/se... | diff --git a/layout/animation.rs b/layout/animation.rs
index 5d7a1a87a..e4a2782c1 100644
--- a/layout/animation.rs
+++ b/layout/animation.rs
@@ -161,7 +161,9 @@ pub fn recalc_style_for_animations(context: &LayoutContext,
&mut fragment.style,
... | 6 | 18 | 10 |
9941d6b2e8515d97ac8366e4c7942cfd648a4803 | Xidorn Quan | 2017-07-21T02:23:19 | servo: Merge #17799 - Don't panic when body element don't have style data (from upsuper:body-color-panic); r=heycam
This is the Servo side change of [bug 1381233](https://bugzilla.mozilla.org/show_bug.cgi?id=1381233).
Source-Repo: https://github.com/servo/servo
Source-Revision: fafb8476e87af305d375a27fd0d8cf7e10c9d2d... | diff --git a/style/values/specified/color.rs b/style/values/specified/color.rs
index c5705ce40..7120e7a86 100644
--- a/style/values/specified/color.rs
+++ b/style/values/specified/color.rs
@@ -269,16 +269,12 @@ impl ToComputedValue for Color {
use gecko::wrapper::GeckoElement;
use geck... | 1 | 6 | 10 |
85272f3d271d0c3a73ab8694315452c3a927cb42 | Daisuke Akatsuka | 2017-07-21T01:20:36 | servo: Merge #17797 - make border-XX-style, cursor, -moz-user-select animatable (from dadaa:bug1378076); r=hiro
<!-- Please describe your changes on the following line: -->
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate dat... | diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs
index 9a626f98c..6af189896 100644
--- a/style/properties/gecko.mako.rs
+++ b/style/properties/gecko.mako.rs
@@ -4671,6 +4671,17 @@ clip-path
// background-image to a url() value, since only properties in reset structs
... | 4 | 92 | 11 |
402f3ab432aeca2ea5d5c94002b59ea97afde73a | Alan Jeffrey | 2017-07-21T00:09:06 | servo: Merge #17499 - Fixed scaling artefacts in paint worklets caused by zoom and hidpi (from asajeffrey:script-paint-worklets-zoom); r=glennw
<!-- Please describe your changes on the following line: -->
This PR renders paint worklet canvases at the device pixel resolution, rather than the CSS pixel resolution.
It'... | diff --git a/compositing/compositor.rs b/compositing/compositor.rs
index 93431755a..051454400 100644
--- a/compositing/compositor.rs
+++ b/compositing/compositor.rs
@@ -16,7 +16,7 @@ use msg::constellation_msg::{PipelineId, PipelineIndex, PipelineNamespaceId, Tra
use net_traits::image::base::{Image, PixelFormat};
use... | 17 | 140 | 62 |
c5f4e14aac142206290619ddcdf7388ee1b32ac5 | Manish Goregaokar | 2017-07-20T23:07:51 | servo: Merge #17809 - Stop asserting when cached system font changes (from Manishearth:stylo-system-anim); r=hiikezoe
It may change during animation
fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1382672
Source-Repo: https://github.com/servo/servo
Source-Revision: 4616f4ae772b15ed576ba4079638fcfdec4ac3de | diff --git a/style/properties/longhand/font.mako.rs b/style/properties/longhand/font.mako.rs
index 39f611e7d..538ffe3b0 100644
--- a/style/properties/longhand/font.mako.rs
+++ b/style/properties/longhand/font.mako.rs
@@ -2489,11 +2489,13 @@ ${helpers.single_keyword("-moz-math-variant",
/// Must be called befor... | 1 | 4 | 2 |
da562d43a3b59dd1abdd8240de5275a9e5fd5993 | Hiroyuki Ikezoe | 2017-07-20T21:21:34 | servo: Merge #17793 - Call may_have_animations() for parent element in the case where the t… (from hiikezoe:may-have-animations-check); r=birtles
…arget is pseudo element.
In case of pseudo elements ElementHasAnimations is set on the parent element.
updating-animation-on-pseudo-element.html fails without this patch,... | diff --git a/style/gecko/wrapper.rs b/style/gecko/wrapper.rs
index 9536ed627..59f128086 100644
--- a/style/gecko/wrapper.rs
+++ b/style/gecko/wrapper.rs
@@ -1089,6 +1089,16 @@ impl<'le> TElement for GeckoElement<'le> {
#[inline]
fn may_have_animations(&self) -> bool {
+ if let Some(pseudo) = self.imp... | 1 | 10 | 0 |
a614a9426995b82b28270a22067e4ebafade3bc4 | Xidorn Quan | 2017-07-20T20:08:58 | servo: Merge #17792 - Fix supports rule parsing issues with <any-value> (from upsuper:supports-any-value); r=SimonSapin
This eventually fixes #15482, as well as several reftests in mozilla-central which were added for [bug 883987](https://bugzilla.mozilla.org/show_bug.cgi?id=883987).
The new function should probably ... | diff --git a/style/stylesheets/supports_rule.rs b/style/stylesheets/supports_rule.rs
index ff856bacf..5636a55ca 100644
--- a/style/stylesheets/supports_rule.rs
+++ b/style/stylesheets/supports_rule.rs
@@ -128,21 +128,18 @@ impl SupportsCondition {
let pos = input.position();
match input.next()? {
... | 1 | 16 | 25 |
7d9ebba9bac3b166a13fb8391675760d486b43ed | Fernando Jiménez Moreno | 2017-07-20T18:34:35 | servo: Merge #17256 - Implement basic Time To First Paint and First Contentful Paint PWMs (from ferjm:ttfp); r=jdm
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
Source-Repo: https://github.com/servo/servo
Source-Revision: eba573d774dd2ac07ec8d62f1ad8deffca4667a... | diff --git a/config/opts.rs b/config/opts.rs
index b03ed69c1..e94eef277 100644
--- a/config/opts.rs
+++ b/config/opts.rs
@@ -224,6 +224,9 @@ pub struct Opts {
/// Unminify Javascript.
pub unminify_js: bool,
+
+ /// Print Progressive Web Metrics to console.
+ pub print_pwm: bool,
}
fn print_usage(a... | 19 | 197 | 10 |
60999cca17462a87b823cdcac5137d8ee27e1e06 | Manish Goregaokar | 2017-07-20T17:33:43 | servo: Merge #17803 - servo: Move FontComputationData to the end of ServoComputedValues to make size check easier, make it NonZero (from Manishearth:servo-fontcomputation); r=emilio
We fail bindgen layout tests on 32 bit because FontComputationData does not accurately reflect the size/alignment of the rust-side replac... | diff --git a/style/gecko/generated/bindings.rs b/style/gecko/generated/bindings.rs
index 93e7df0f4..a5bc5d9b0 100644
--- a/style/gecko/generated/bindings.rs
+++ b/style/gecko/generated/bindings.rs
@@ -1984,10 +1984,10 @@ extern "C" {
-> ServoStyleContextStrong;
}
extern "C" {
- pub fn Servo_StyleContext_AddR... | 4 | 78 | 37 |
e8b217bcea8fedf5833ebd3b2b625218b7e271dd | Emilio Cobos Álvarez | 2017-07-20T15:25:09 | servo: Merge #17801 - style: Don't inherit from the parent visited style if we're a link (from emilio:visited-inherited); r=jryans
Bug: 1377469
Reviewed-by: jryans
MozReview-Commit-ID: CoMj9KSb5w9
Source-Repo: https://github.com/servo/servo
Source-Revision: 3d66cdeed40468cb97f9f007ed282d7f3021a890 | diff --git a/style/style_resolver.rs b/style/style_resolver.rs
index 02d80e344..bd3eb57f7 100644
--- a/style/style_resolver.rs
+++ b/style/style_resolver.rs
@@ -474,9 +474,11 @@ where
cascade_flags.insert(SKIP_ROOT_AND_ITEM_BASED_DISPLAY_FIXUP);
}
if cascade_visited.visited_dependent_only... | 1 | 5 | 3 |
5c70213bb79c542524187e72c82f03805cdbae30 | Sebastian Hengst | 2017-07-20T13:42:03 | Backed out changeset b10e6ba9cbdb because gecko part had to be backed out. r=backout on a CLOSED TREE | diff --git a/layout/animation.rs b/layout/animation.rs
index e4a2782c1..5d7a1a87a 100644
--- a/layout/animation.rs
+++ b/layout/animation.rs
@@ -161,9 +161,7 @@ pub fn recalc_style_for_animations(context: &LayoutContext,
&mut fragment.style,
... | 6 | 10 | 18 |
4f339ff51c1a6f511394207d639632deeb92c7d9 | Anthony Ramine | 2017-07-20T11:46:23 | servo: Merge #17798 - Derive some SVGPaint impls (from servo:derive-all-the-things); r=emilio
Source-Repo: https://github.com/servo/servo
Source-Revision: fa34af609fd916f4e4df86ba73e9a5843177a29f | diff --git a/style/values/generics/mod.rs b/style/values/generics/mod.rs
index 637735a0c..d93ea570a 100644
--- a/style/values/generics/mod.rs
+++ b/style/values/generics/mod.rs
@@ -255,7 +255,7 @@ impl ToCss for FontSettingTagFloat {
///
/// https://www.w3.org/TR/SVG2/painting.html#SpecifyingPaint
#[cfg_attr(feature... | 2 | 2 | 77 |
fd8915938c8119d596b9dd2dbff7b3e27be8cfcd | Cameron McCormack | 2017-07-20T10:39:15 | servo: Merge #17796 - style: pass old ComputedValues from Element data into Gecko_CalcStyleDifference (from heycam:calc-difference); r=emilio
This is the Servo-side part of https://bugzilla.mozilla.org/show_bug.cgi?id=1380133.
Source-Repo: https://github.com/servo/servo
Source-Revision: 7b71070c04f1e1b10fdc7aa397ad68... | diff --git a/layout/animation.rs b/layout/animation.rs
index 5d7a1a87a..e4a2782c1 100644
--- a/layout/animation.rs
+++ b/layout/animation.rs
@@ -161,7 +161,9 @@ pub fn recalc_style_for_animations(context: &LayoutContext,
&mut fragment.style,
... | 6 | 18 | 10 |
aa8c3d92d31ff0055241064ff32fa209f4e2f2c2 | Glenn Watson | 2017-07-20T07:55:45 | servo: Merge #17790 - Update WR (text-shadow optimizations) (from glennw:update-wr-shadows-agan); r=KiChjang
Source-Repo: https://github.com/servo/servo
Source-Revision: 069243a474eedb2c914db71c45d121fc4d954f5e | diff --git a/layout/display_list_builder.rs b/layout/display_list_builder.rs
index f527d18f5..d993170fb 100644
--- a/layout/display_list_builder.rs
+++ b/layout/display_list_builder.rs
@@ -2123,7 +2123,7 @@ impl FragmentDisplayListBuilding for Fragment {
// to back).
// Shadows
- for shadow i... | 1 | 1 | 1 |
9e17ff96073d52ca201cdbd5bc2e18edb2b68a2b | Nazım Can Altınova | 2017-07-20T06:54:33 | servo: Merge #17776 - More grid serialization and parsing fixes (from canaltinova:disabled-mochitests); r=emilio
These are the bugs I discovered while I was re-enabling the disabled grid mochitests. Now all grid mochitests are passing! Additionally I converted `Vec<CustomIdent>`'s into `Box<[CustomIdent]>`. We are sto... | diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs
index 055d33a62..cae2495be 100644
--- a/style/properties/gecko.mako.rs
+++ b/style/properties/gecko.mako.rs
@@ -1371,10 +1371,11 @@ fn static_assert() {
let ident = v.ident.as_ref().map_or(&[] as &[_], |ident| ident.0.as_slice());
... | 4 | 156 | 45 |
ec2426d73d202d3a81976d85d7b118a0cd221b08 | Bobby Holley | 2017-07-20T04:02:28 | servo: Merge #17791 - Bring back concise logging for ElementData (from bholley:less_verbose_cv); r=heycam
This was removed recently in the ComputedValues patch, and makes traversal
logging rather unusable.
Reviewed in https://bugzilla.mozilla.org/show_bug.cgi?id=1382357
Source-Repo: https://github.com/servo/servo
So... | diff --git a/style/data.rs b/style/data.rs
index 0927edfc4..47cf4c8a8 100644
--- a/style/data.rs
+++ b/style/data.rs
@@ -13,6 +13,7 @@ use rule_tree::StrongRuleNode;
use selector_parser::{EAGER_PSEUDO_COUNT, PseudoElement, RestyleDamage};
use servo_arc::Arc;
use shared_lock::StylesheetGuards;
+use std::fmt;
use std... | 1 | 27 | 2 |
45a37563385695de2fc5949a47e0996f90537c36 | Jeremy Chen | 2017-07-20T03:07:26 | servo: Merge #17789 - stylo: Fix Y scale computation while decomposing a 3D matrix (from chenpighead:stylo-fix-decompose_3d_matrix); r=hiro
While decomposing a 3D matrix, we should normalize the 2nd row right after the
Y scale computation. However, we accidentally use the length of the 1st row to
do the normalization.... | diff --git a/style/properties/helpers/animated_properties.mako.rs b/style/properties/helpers/animated_properties.mako.rs
index 21c0b25fa..c216201da 100644
--- a/style/properties/helpers/animated_properties.mako.rs
+++ b/style/properties/helpers/animated_properties.mako.rs
@@ -2146,7 +2146,7 @@ fn decompose_3d_matrix(mu... | 1 | 1 | 1 |
0cc52b747818bf0eadb48e8416a7fb791997a0b8 | Pavel Sergeev | 2017-07-19T23:03:51 | servo: Merge #17749 - Extra space check (from SergeevPavel:extra-space-check); r=jdm
<!-- Please describe your changes on the following line: -->
Add tidy check for keywords with more than one space afterwards.
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete,... | diff --git a/constellation/constellation.rs b/constellation/constellation.rs
index 9f147cfba..b9719c64f 100644
--- a/constellation/constellation.rs
+++ b/constellation/constellation.rs
@@ -2037,7 +2037,7 @@ impl<Message, LTF, STF> Constellation<Message, LTF, STF>
let visibility_msg = ConstellationControlMs... | 3 | 3 | 3 |
e42b53d74b6e4d1ff8ddc514511542da0d4ced75 | Pavel Sergeev | 2017-07-19T21:56:24 | servo: Merge #17754 - replace vector iteration by ascii_case_insensitive_phf_map (from SergeevPavel:system-colors-refactor); r=SimonSapin
<!-- Please describe your changes on the following line: -->
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace... | diff --git a/style/properties/longhand/color.mako.rs b/style/properties/longhand/color.mako.rs
index 554edd8aa..e3e8221eb 100644
--- a/style/properties/longhand/color.mako.rs
+++ b/style/properties/longhand/color.mako.rs
@@ -121,21 +121,20 @@
impl SystemColor {
pub fn parse<'i, 't>(input: &mut P... | 1 | 11 | 12 |
63e2ab2da7fd476e0581051df16c3566552f9436 | Josh Matthews | 2017-07-19T17:08:14 | servo: Merge #17787 - Store COW strings in CSS parser errors when possible (from jdm:invalidvalue); r=SimonSapin
This should be a straightforward performance improvement in pages with lots of CSS property values that the parser does not understand.
---
- [X] `./mach build -d` does not report any errors
- [X] `./mach ... | diff --git a/style/properties/properties.mako.rs b/style/properties/properties.mako.rs
index 2f6d3766a..cbaa62b7f 100644
--- a/style/properties/properties.mako.rs
+++ b/style/properties/properties.mako.rs
@@ -1481,7 +1481,7 @@ impl PropertyDeclaration {
Ok(keyword) => DeclaredValueOwned::CSSWideKey... | 2 | 2 | 2 |
f3dbbbb452b935afbbb45248720fd583c7afbb88 | Omar Akkila | 2017-07-19T15:20:35 | servo: Merge #17784 - constellation: Remove unused title attribute from Pipeline struct (from omakk:master); r=jdm
<!-- Please describe your changes on the following line: -->
Removes title attribute from constellation::Pipeline since it is never used
---
<!-- Thank you for contributing to Servo! Please replace each ... | diff --git a/constellation/pipeline.rs b/constellation/pipeline.rs
index dd99446bd..919c6203f 100644
--- a/constellation/pipeline.rs
+++ b/constellation/pipeline.rs
@@ -75,9 +75,6 @@ pub struct Pipeline {
/// to a hash URL.
pub url: ServoUrl,
- /// The title of the most recently-loaded page.
- pub tit... | 1 | 0 | 4 |
4415e5e128b2c72635f79cdc1fb3080b0009edef | Simon Sapin | 2017-07-19T14:12:36 | servo: Merge #17785 - Remove explicit lifetime arguments on a method call (from servo:future-break); r=nox
This causes a warning it today’s Nightly: https://github.com/rust-lang/rust/issues/42868
… which makes the build fail because we use `#![deny(warnings)]`. This warning is planned to become a hard error in a futu... | diff --git a/style/stylesheets/stylesheet.rs b/style/stylesheets/stylesheet.rs
index 1d0103e02..805a539ef 100644
--- a/style/stylesheets/stylesheet.rs
+++ b/style/stylesheets/stylesheet.rs
@@ -240,7 +240,7 @@ pub trait StylesheetInDocument {
device: &'a Device,
guard: &'a SharedRwLockReadGuard<'b>
... | 1 | 1 | 1 |
a7ae53e0cf1b1a981cbfa0ee38c1a894196bd131 | Emilio Cobos Álvarez | 2017-07-19T11:57:23 | servo: Merge #17782 - style: Unify needs_traversal logic (from emilio:needs-traversal); r=heycam
Source-Repo: https://github.com/servo/servo
Source-Revision: 9b060cf4bf5ff49b05370da6dfb82af5ea46f370 | diff --git a/style/traversal.rs b/style/traversal.rs
index ed6635eb0..a3495fac9 100644
--- a/style/traversal.rs
+++ b/style/traversal.rs
@@ -227,27 +227,24 @@ pub trait DomTraversal<E: TElement> : Sync {
}
let flags = shared_context.traversal_flags;
- let data = root.mutate_data();
- l... | 1 | 41 | 44 |
bb99be833ef1a56686096772336c7df5b136dcc0 | Jonathan Chan | 2017-07-19T10:59:50 | servo: Merge #17539 - Simplify <an+b> in selector args when serializing (from jyc:simplify-an-b); r=emilio
<!-- Please describe your changes on the following line: -->
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --... | diff --git a/selectors/parser.rs b/selectors/parser.rs
index fe4dda024..a1162701c 100644
--- a/selectors/parser.rs
+++ b/selectors/parser.rs
@@ -871,6 +871,23 @@ impl ToCss for Combinator {
impl<Impl: SelectorImpl> ToCss for Component<Impl> {
fn to_css<W>(&self, dest: &mut W) -> fmt::Result where W: fmt::Write {
... | 1 | 28 | 4 |
c3cb97fdce37572d14a96003a2771d419fb3089b | Anthony Ramine | 2017-07-19T08:56:05 | servo: Merge #17774 - Prepare some code for future derivation 🌊 (from servo:derive-all-the-things); r=emilio
Source-Repo: https://github.com/servo/servo
Source-Revision: d76d0978911e4823d9d40f7ed161de24f3cc7f61 | diff --git a/style/animation.rs b/style/animation.rs
index 8d652d8e0..123cdf19e 100644
--- a/style/animation.rs
+++ b/style/animation.rs
@@ -9,7 +9,6 @@ use Atom;
use bezier::Bezier;
use context::SharedStyleContext;
use dom::OpaqueNode;
-use euclid::Point2D;
use font_metrics::FontMetricsProvider;
use properties::{... | 16 | 399 | 249 |
7dbe8cf7c7c4bbf094e9114f4d96b7af5c8e285f | Emilio Cobos Álvarez | 2017-07-19T07:44:45 | servo: Merge #17781 - style: Remove bogus assertion (from emilio:assert-not); r=heycam
Bug: 1381682
Reviewed-by: heycam
MozReview-Commit-ID: E6bKyBdMUue
Source-Repo: https://github.com/servo/servo
Source-Revision: 8e73bc5b471d92331d9308821caed62bd30a231f | diff --git a/style/invalidation/element/invalidator.rs b/style/invalidation/element/invalidator.rs
index 7c31f4a3c..ff60ecc32 100644
--- a/style/invalidation/element/invalidator.rs
+++ b/style/invalidation/element/invalidator.rs
@@ -266,12 +266,10 @@ impl<'a, 'b: 'a, E> TreeStyleInvalidator<'a, 'b, E>
// Roo... | 1 | 4 | 6 |
09ae5a98585de46da9b239da4b96f6f12768b3db | Manish Goregaokar | 2017-07-18T20:40:18 | servo: Merge #17778 - stylo: Don't ignore visited state when deciding to share style contexts (from Manishearth:stylo-visited-fix); r=bz
r=bz https://bugzilla.mozilla.org/show_bug.cgi?id=1381635
Source-Repo: https://github.com/servo/servo
Source-Revision: 38e808645292a1e4e9264937b979137b194c2196 | diff --git a/style/sharing/checks.rs b/style/sharing/checks.rs
index b710dffdc..8ff232d7f 100644
--- a/style/sharing/checks.rs
+++ b/style/sharing/checks.rs
@@ -10,7 +10,6 @@ use Atom;
use bloom::StyleBloom;
use context::{SelectorFlagsMap, SharedStyleContext};
use dom::TElement;
-use element_state::*;
use sharing::... | 2 | 4 | 16 |
445533ecdc3d3807e28939f1af6c8c7f9fb96875 | Fernando Jiménez Moreno | 2017-07-18T17:24:44 | servo: Merge #17735 - Set navigation start value according to navigation timing spec (from ferjm:navigationstart); r=jdm
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #17651
Source-Repo: https://github.com/servo/servo
Source-Revision: eb... | diff --git a/script/dom/document.rs b/script/dom/document.rs
index 27bd4f100..2d95efbc2 100644
--- a/script/dom/document.rs
+++ b/script/dom/document.rs
@@ -3659,6 +3659,8 @@ impl DocumentMethods for Document {
// Step 10.
// TODO: prompt to unload.
+ window_from_node(self).set_navigation_sta... | 3 | 28 | 10 |
0978424ae679301967e125aa95f402a6d2b52f32 | Glenn Watson | 2017-07-18T14:08:25 | servo: Merge #17771 - Update WR (text-shadow improvements, iframe + image clips, depth buffer sharing) (from mrobinson:wr-update-shadows); r=emilio
<!-- Please describe your changes on the following line: -->
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, a... | diff --git a/gfx/display_list/mod.rs b/gfx/display_list/mod.rs
index 9a7d21c46..69074e89a 100644
--- a/gfx/display_list/mod.rs
+++ b/gfx/display_list/mod.rs
@@ -605,6 +605,8 @@ pub enum DisplayItem {
RadialGradient(Box<RadialGradientDisplayItem>),
Line(Box<LineDisplayItem>),
BoxShadow(Box<BoxShadowDispla... | 3 | 125 | 72 |
020c43d3e911ddff662b6ddcaac54135e03bb077 | Connor Brewster | 2017-07-18T05:58:53 | servo: Merge #17614 - Implement custom element reactions (from cbrewster:custom_element_reactions); r=jdm
<!-- Please describe your changes on the following line: -->
Initial work for implementing custom element reactions: https://html.spec.whatwg.org/multipage/custom-elements.html#custom-element-reactions
---
<!-- T... | diff --git a/script/dom/attr.rs b/script/dom/attr.rs
index af5f0107a..bf2ecd6e9 100644
--- a/script/dom/attr.rs
+++ b/script/dom/attr.rs
@@ -9,6 +9,7 @@ use dom::bindings::inheritance::Castable;
use dom::bindings::js::{LayoutJS, MutNullableJS, Root, RootedReference};
use dom::bindings::reflector::{Reflector, reflect_... | 7 | 456 | 30 |
cd8806f1135d01d4031c512c4ddf21f5383f5730 | Xidorn Quan | 2017-07-18T04:16:26 | servo: Merge #17764 - Adjust display value for ::-moz-fieldset-content when parent is flex/grid (from upsuper:fieldset-flexgrid); r=emilio,heycam
This is the Servo side change for [bug 1379901](https://bugzilla.mozilla.org/show_bug.cgi?id=1379901).
Source-Repo: https://github.com/servo/servo
Source-Revision: 1b6d29e3... | diff --git a/style/gecko/pseudo_element.rs b/style/gecko/pseudo_element.rs
index 564a288b4..97ce0f4e5 100644
--- a/style/gecko/pseudo_element.rs
+++ b/style/gecko/pseudo_element.rs
@@ -83,6 +83,12 @@ impl PseudoElement {
*self == PseudoElement::FirstLetter
}
+ /// Whether this pseudo-element is ::-mo... | 3 | 35 | 0 |
d0609200ffeed93cdbe0be09c0f5f08ddd43d7b9 | Jonathan Chan | 2017-07-17T23:26:37 | servo: Merge #17537 - Some fixes to selector serialization re: namespaces and universal selector (from jyc:default-namespace-serialization); r=emilio
- Fix eliding default namespace when serializing
- Fix shortest serialization property when namespace prefix is `*|` and there is no default namespace
- Omit universal s... | diff --git a/selectors/parser.rs b/selectors/parser.rs
index 0cb7c6e3f..fe4dda024 100644
--- a/selectors/parser.rs
+++ b/selectors/parser.rs
@@ -763,19 +763,93 @@ impl<Impl: SelectorImpl> ToCss for Selector<Impl> {
// NB: A parse-order iterator is a Rev<>, which doesn't expose as_slice(),
// which we ... | 1 | 171 | 18 |
13b3dc8946714dab1210c96c8eb0554b5b94b6fd | Emilio Cobos Álvarez | 2017-07-17T22:21:22 | servo: Merge #17762 - style: Cascade the visited style with the normal rules if we didn't find a relevant link (from emilio:visited-nested); r=jryans
Source-Repo: https://github.com/servo/servo
Source-Revision: e122ea65fdbb07c237de7f53a998f678c7a0ca5a | diff --git a/style/style_resolver.rs b/style/style_resolver.rs
index 1dc38baa9..0a98e563e 100644
--- a/style/style_resolver.rs
+++ b/style/style_resolver.rs
@@ -121,7 +121,7 @@ where
if should_compute_visited_style {
visited_style = Some(self.cascade_style(
- visited_rules.as_ref(... | 1 | 2 | 2 |
9c04714f5e63a706433fc3d5d82806e345a5920b | Alan Jeffrey | 2017-07-17T20:25:37 | servo: Merge #17606 - Don't delete webrender image keys immediately (from asajeffrey:canvas-delay-deleting-image-keys); r=jdm
<!-- Please describe your changes on the following line: -->
We currently delete webrender image id's immediately on resizing a canvas, which can cause panics. This PR delays deleting the imag... | diff --git a/canvas/canvas_paint_thread.rs b/canvas/canvas_paint_thread.rs
index e2937b097..c285f3aa6 100644
--- a/canvas/canvas_paint_thread.rs
+++ b/canvas/canvas_paint_thread.rs
@@ -59,6 +59,10 @@ pub struct CanvasPaintThread<'a> {
saved_states: Vec<CanvasPaintState<'a>>,
webrender_api: webrender_api::Rend... | 2 | 73 | 17 |
683b732daa1778876e399cb1176632653aa03026 | Austin Hicks | 2017-07-17T16:54:43 | servo: Merge #17520 - Convert node serialization to a purely iterative algorithm (from camlorn:master); r=asajeffrey
We maintain a stack of open element nodes with their children count, popping from the top of the stack and closing when the count reaches zero.
Contrary to my comment in #16696, this is a purely iterat... | diff --git a/script/dom/servoparser/html.rs b/script/dom/servoparser/html.rs
index 6d8f894a0..749174d14 100644
--- a/script/dom/servoparser/html.rs
+++ b/script/dom/servoparser/html.rs
@@ -14,7 +14,7 @@ use dom::documenttype::DocumentType;
use dom::element::Element;
use dom::htmlscriptelement::HTMLScriptElement;
use... | 1 | 121 | 63 |
de5f29fe3cf128ed7e3df872e8373d211a082bb0 | Fausto Núñez Alberro | 2017-07-17T15:29:23 | servo: Merge #16508 - Properly set origin of fetch requests (from brainlessdeveloper:fetch-set-origin); r=asajeffrey
<!-- Please describe your changes on the following line: -->
These changes aim to fix #15247
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete,... | diff --git a/gfx/font_cache_thread.rs b/gfx/font_cache_thread.rs
index ac4809023..9b76a22fa 100644
--- a/gfx/font_cache_thread.rs
+++ b/gfx/font_cache_thread.rs
@@ -216,7 +216,8 @@ impl FontCache {
url: url.clone(),
type_: RequestType::Font,
destination: De... | 16 | 28 | 27 |
592ed1a58a20213281d1172a01b474b76c31b606 | Josh Matthews | 2017-07-17T14:10:11 | servo: Merge #17739 - Suppress CSS parser errors for vendor-prefixed properties (from jdm:no-vendor-prefixed-errors); r=emilio
This matches the behaviour of Gecko's CSS parser.
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #17736
- [X] T... | diff --git a/layout_thread/lib.rs b/layout_thread/lib.rs
index fea91c164..b8436ce0b 100644
--- a/layout_thread/lib.rs
+++ b/layout_thread/lib.rs
@@ -133,7 +133,6 @@ use style::stylist::{ExtraStyleData, Stylist};
use style::thread_state;
use style::timer::Timer;
use style::traversal::{DomTraversal, TraversalDriver, T... | 7 | 54 | 29 |
e03d0b5e331bbe20232b3ced8f2888f5d36440fe | Emilio Cobos Álvarez | 2017-07-17T08:29:11 | servo: Merge #17731 - style: Respect calc for percentages (from emilio:percentage-calc); r=nox
Source-Repo: https://github.com/servo/servo
Source-Revision: 2d37700cf819d901552cfb3954e948f1fbadcf78 | diff --git a/layout/display_list_builder.rs b/layout/display_list_builder.rs
index 9fdd405a9..4b79c5e7a 100644
--- a/layout/display_list_builder.rs
+++ b/layout/display_list_builder.rs
@@ -56,7 +56,7 @@ use style::properties::longhands::border_image_repeat::computed_value::RepeatKey
use style::properties::style_struct... | 23 | 297 | 167 |
2e7bc6902587fae62d27ce684c115e90066729f9 | Paul Rouget | 2017-07-17T06:58:48 | servo: Merge #17684 - allow_navigation: use channel to send response (from paulrouget:fix_allow_navigation); r=paulrouget
From the embedder perspective, this makes things easier in term of synchronicity.
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and re... | diff --git a/compositing/compositor.rs b/compositing/compositor.rs
index 707ccf830..93431755a 100644
--- a/compositing/compositor.rs
+++ b/compositing/compositor.rs
@@ -509,10 +509,7 @@ impl<Window: WindowMethods> IOCompositor<Window> {
}
(Msg::AllowNavigation(url, response_chan), ShutdownSt... | 2 | 3 | 5 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.