commit_hash
stringlengths
40
40
author
stringlengths
1
57
date
timestamp[s]date
2010-07-26 04:45:09
2026-04-14 18:21:10
message
stringlengths
8
1.39M
diff
stringlengths
68
51.2k
files_changed
int64
1
136
insertions
int64
0
2.35k
deletions
int64
0
1.9k
5eed6241ccf21f3929d2bc54be1358abac7a5150
Manish Goregaokar
2025-04-21T21:23:21
Mark Calendar UnstableSealed (#6483) Note: I used a different header than in datetime for the trait, since I think unlike datetime this is a non-scaffolding trait that people will reference often. Personally my rule of thumb for UnstableSealed is that we expect people to want to implement it (check) and we have some ...
diff --git a/components/calendar/src/any_calendar.rs b/components/calendar/src/any_calendar.rs index f8bbabb371..dab56c472e 100644 --- a/components/calendar/src/any_calendar.rs +++ b/components/calendar/src/any_calendar.rs @@ -218,6 +218,7 @@ macro_rules! match_cal { }; } +impl crate::cal::scaffold::UnstableSea...
17
38
3
caa8799da33f75de5d74a2ff37a99f9cbad67683
Shane F. Carr
2025-04-21T21:21:02
CldrCalendar should be bound on UnstableSealed not private::Sealed (#6475)
diff --git a/components/datetime/src/scaffold/calendar.rs b/components/datetime/src/scaffold/calendar.rs index 29d708e842..ab8fcca9c2 100644 --- a/components/datetime/src/scaffold/calendar.rs +++ b/components/datetime/src/scaffold/calendar.rs @@ -22,10 +22,6 @@ use icu_time::{ DateTime, Time, TimeZoneInfo, ZonedDa...
1
1
21
6a013d348b438dbfd4ec0faa837496cd74030f9c
Shane F. Carr
2025-04-21T21:20:17
Change ConflictingField error to contain the previously loaded field (#6480) Part of #6477
diff --git a/components/datetime/src/pattern/mod.rs b/components/datetime/src/pattern/mod.rs index b6d7e5d3ca..1157cc41ff 100644 --- a/components/datetime/src/pattern/mod.rs +++ b/components/datetime/src/pattern/mod.rs @@ -73,8 +73,13 @@ pub enum PatternLoadError { /// Fields conflict if they require the same type...
4
78
18
386e511a1d8dd057f9f33012723df4b2d749e74f
Shane F. Carr
2025-04-21T17:44:26
Make PluralElements::map take FnMut; add try_map (#6478)
diff --git a/components/plurals/src/lib.rs b/components/plurals/src/lib.rs index 1365516232..f14ff179f3 100644 --- a/components/plurals/src/lib.rs +++ b/components/plurals/src/lib.rs @@ -89,6 +89,7 @@ mod raw_operands; pub use raw_operands::RawPluralOperands; use core::cmp::{Ord, PartialOrd}; +use core::convert::In...
1
36
13
4e9c34d93c0d52abb2b78b22393f46885dc56977
Robert Bastian
2025-04-15T19:00:04
Update eras to open CLDR PRs (#6466)
diff --git a/provider/source/src/calendar/eras.rs b/provider/source/src/calendar/eras.rs index 2a1c69aa02..ffd59abdd9 100644 --- a/provider/source/src/calendar/eras.rs +++ b/provider/source/src/calendar/eras.rs @@ -150,7 +150,7 @@ impl SourceDataProvider { fn process_era_dates_map( mut data: BTreeMap<String, cldr...
1
162
145
80afda56dbfab75c733971dab785afc634b9c29d
Robert Bastian
2025-04-15T17:42:03
Use ISO dates for Chinese/Dangi epoch (#6465) Fewer magic numbers
diff --git a/utils/calendrical_calculations/src/chinese_based.rs b/utils/calendrical_calculations/src/chinese_based.rs index 9908fbf26c..017dc5e3aa 100644 --- a/utils/calendrical_calculations/src/chinese_based.rs +++ b/utils/calendrical_calculations/src/chinese_based.rs @@ -64,7 +64,7 @@ impl ChineseBased for Chinese {...
1
14
2
6a0f09e996f9e666c01d83962f2b201540633206
Robert Bastian
2025-04-15T16:09:00
Followup #6440 (#6461) Fixes #6386
diff --git a/components/calendar/src/provider/hijri.rs b/components/calendar/src/provider/hijri.rs index f4aae0fcb4..8eedd1db78 100644 --- a/components/calendar/src/provider/hijri.rs +++ b/components/calendar/src/provider/hijri.rs @@ -75,7 +75,7 @@ impl PackedHijriYearInfo { month_lengths: [bool; 12], ...
4
15
17
c6985bcbdcd72d2f087ebef77068a0000766ff3d
Robert Bastian
2025-04-15T15:21:40
Align Julian/Gregorian docs and eras (#6463)
diff --git a/components/calendar/src/cal/gregorian.rs b/components/calendar/src/cal/gregorian.rs index 667067dcf4..f236702525 100644 --- a/components/calendar/src/cal/gregorian.rs +++ b/components/calendar/src/cal/gregorian.rs @@ -32,6 +32,10 @@ use tinystr::tinystr; /// # Era codes /// /// This calendar uses two er...
2
15
11
54aab1698de4fef9bd2d2f97edaa891672d9b343
Robert Bastian
2025-04-15T06:24:14
Handle CLDR era addition (#6457) This way datagen ignores eras that `icu::calendar` doesn't yet know about. We cannot really do this in the other direction, as `icu::calendar` cannot tell us a list of eras for a calendar
diff --git a/provider/source/src/calendar/eras.rs b/provider/source/src/calendar/eras.rs index 59d4b9fca0..71cabeefea 100644 --- a/provider/source/src/calendar/eras.rs +++ b/provider/source/src/calendar/eras.rs @@ -116,18 +116,21 @@ impl SourceDataProvider { .eras ...
1
7
4
4b283a594b51a300018b775762be1062e40959bc
Robert Bastian
2025-04-14T18:02:00
Chinese calendars are only parameterized by UTC offset (#6450)
diff --git a/components/calendar/src/cal/chinese.rs b/components/calendar/src/cal/chinese.rs index ba1bef1b8e..b7fd69d820 100644 --- a/components/calendar/src/cal/chinese.rs +++ b/components/calendar/src/cal/chinese.rs @@ -25,7 +25,7 @@ use crate::error::DateError; use crate::provider::chinese_based::CalendarChineseV1...
3
43
74
0aef58eddcca746202f506e9c586be037a19e360
Robert Bastian
2025-04-14T17:15:12
Don't require AnyCalendarKind in Calendar trait (#6456)
diff --git a/components/calendar/src/any_calendar.rs b/components/calendar/src/any_calendar.rs index bc9ea09078..e68576b370 100644 --- a/components/calendar/src/any_calendar.rs +++ b/components/calendar/src/any_calendar.rs @@ -523,8 +523,25 @@ impl Calendar for AnyCalendar { } } - fn any_calendar_kin...
19
103
74
159d658608254d0c16c10e0119fdefaa6640ece1
Robert Bastian
2025-04-14T16:40:17
Use `icu::calendar` as the source of truth for era indices (#6452) Based on #6451 Fixes #6444
diff --git a/components/calendar/src/types.rs b/components/calendar/src/types.rs index 7dcb587f43..bd814d8c95 100644 --- a/components/calendar/src/types.rs +++ b/components/calendar/src/types.rs @@ -92,11 +92,7 @@ pub struct EraYear { pub era: TinyStr16, /// An era index, for calendars with a small set of era...
7
83
44
a9101efcfeb0d6129f442965da060920885fa5c0
Shane F. Carr
2025-04-11T23:34:19
Remove unused data markers from datetime crate (#6447)
diff --git a/components/datetime/src/provider/calendar/mod.rs b/components/datetime/src/provider/calendar/mod.rs index 87d4dc32a2..a91affbed7 100644 --- a/components/datetime/src/provider/calendar/mod.rs +++ b/components/datetime/src/provider/calendar/mod.rs @@ -17,72 +17,6 @@ pub use symbols::*; size_test!(DateLeng...
6
630
595
cd9a3e32bcab0eef408b3d12bd0239e8f43a0c24
Manish Goregaokar
2025-04-10T19:58:57
Use range iteration in segmenter datagen (#6430) Followup from https://github.com/unicode-org/icu4x/pull/6367
diff --git a/provider/source/src/segmenter/mod.rs b/provider/source/src/segmenter/mod.rs index be0cc58c66..7eece2bfa5 100644 --- a/provider/source/src/segmenter/mod.rs +++ b/provider/source/src/segmenter/mod.rs @@ -20,8 +20,10 @@ use icu::segmenter::options::WordType; use icu::segmenter::provider::*; use icu_codepoin...
1
60
79
0dc7027054f95fd00bf43cd5637c7a3b2dab2bc8
Robert Bastian
2025-04-10T18:15:21
Restrict Rata Die API (#6440) Fixes #6386
diff --git a/components/calendar/src/types.rs b/components/calendar/src/types.rs index fe2d2acc6e..80872a4aeb 100644 --- a/components/calendar/src/types.rs +++ b/components/calendar/src/types.rs @@ -4,6 +4,7 @@ //! This module contains various types used by `icu_calendar` and `icu::datetime` +#[doc(no_inline)] pu...
2
21
16
096214fca6bf18daac10f29ed4505a86b43ad77f
Robert Bastian
2025-04-10T08:40:10
Follow-up #6405 #6431 (#6438)
diff --git a/components/calendar/src/cal/chinese.rs b/components/calendar/src/cal/chinese.rs index 2e72ab2b5b..593d8119b2 100644 --- a/components/calendar/src/cal/chinese.rs +++ b/components/calendar/src/cal/chinese.rs @@ -57,20 +57,13 @@ use icu_provider::prelude::*; /// /// # Year and Era codes /// -/// This calen...
2
4
11
e4db884459036d65adcd78c05ec7e64c2fa08408
Manish Goregaokar
2025-04-08T18:20:12
Segmenter cleanups, part 2 (reduce trait complexity) (#6417) First set of followups after https://github.com/unicode-org/icu4x/pull/6409 This: - Removes lifetimes and `?Sized` from the BreakType traits - Coalesces the BreakType markers into a single set of RuleBreakTypeFoo markers - Makes LineBreakType depend on R...
diff --git a/components/segmenter/src/complex/dictionary.rs b/components/segmenter/src/complex/dictionary.rs index 5bf28e924d..b4e160a79c 100644 --- a/components/segmenter/src/complex/dictionary.rs +++ b/components/segmenter/src/complex/dictionary.rs @@ -9,9 +9,9 @@ use core::str::CharIndices; use icu_collections::cha...
11
168
282
f028b9a8b3c9e845692f4303afba450e94cc84f8
Manish Goregaokar
2025-04-03T15:15:04
More non_exhaustive (#6408) Fixes #4673 <!-- Thank you for your pull request to ICU4X! Reminder: try to use [Conventional Comments](https://conventionalcomments.org/) to make comments clearer. Please see https://github.com/unicode-org/icu4x/blob/main/CONTRIBUTING.md for general information on contributing to ICU4X...
diff --git a/components/time/src/zone/mod.rs b/components/time/src/zone/mod.rs index bf9426f735..ca29ab23d7 100644 --- a/components/time/src/zone/mod.rs +++ b/components/time/src/zone/mod.rs @@ -131,7 +131,7 @@ pub mod models { /// A time zone containing a time zone ID and optional offset. #[derive(Debug, Par...
2
6
6
63f910b05246079388c3f847a8b2f14287cfaa17
Manish Goregaokar
2025-04-02T20:19:17
More into_ref_counted docs (#6407) Followup from #6392 <!-- Thank you for your pull request to ICU4X! Reminder: try to use [Conventional Comments](https://conventionalcomments.org/) to make comments clearer. Please see https://github.com/unicode-org/icu4x/blob/main/CONTRIBUTING.md for general information on contrib...
diff --git a/components/calendar/src/date.rs b/components/calendar/src/date.rs index 4c30b332f6..eaa30e492a 100644 --- a/components/calendar/src/date.rs +++ b/components/calendar/src/date.rs @@ -349,7 +349,7 @@ impl<C: IntoAnyCalendar> Date<C> { } impl<A: AsCalendar> Date<A> { - /// Wrap the calendar type in `Rc...
1
3
3
46718bb09b817062e956444428d9fe9de9aa3984
Manish Goregaokar
2025-04-02T20:19:01
Add non_exhaustive to most marker types (#6401) Fixes #4673 <!-- Thank you for your pull request to ICU4X! Reminder: try to use [Conventional Comments](https://conventionalcomments.org/) to make comments clearer. Please see https://github.com/unicode-org/icu4x/blob/main/CONTRIBUTING.md for general information on c...
diff --git a/components/segmenter/src/line.rs b/components/segmenter/src/line.rs index 765eb7b490..49832d09ee 100644 --- a/components/segmenter/src/line.rs +++ b/components/segmenter/src/line.rs @@ -1065,6 +1065,7 @@ impl<'l, 's, Y: LineBreakType<'l, 's>> LineBreakIterator<'l, 's, Y> { } #[derive(Debug)] +#[non_exh...
5
13
1
200f3d77bd21ef299badf630f0a813f905de628a
Makoto Kato
2025-04-01T10:09:03
Support Line_Break property for unicodeset_parse. (#6396) Allow to parse [:Line_Break=xxxx:] for unicodeset parser.
diff --git a/components/experimental/src/transliterate/compile/mod.rs b/components/experimental/src/transliterate/compile/mod.rs index 5e84672772..eabc76245e 100644 --- a/components/experimental/src/transliterate/compile/mod.rs +++ b/components/experimental/src/transliterate/compile/mod.rs @@ -230,12 +230,14 @@ impl Ru...
3
34
1
48b04cb757345a08506a281ac990803b25d90213
Manish Goregaokar
2025-03-28T22:55:42
CollationHanDatabase -> CollationRootHan (#6375) Fixes #2784 <!-- Thank you for your pull request to ICU4X! Reminder: try to use [Conventional Comments](https://conventionalcomments.org/) to make comments clearer. Please see https://github.com/unicode-org/icu4x/blob/main/CONTRIBUTING.md for general information on ...
diff --git a/provider/icu4x-datagen/src/main.rs b/provider/icu4x-datagen/src/main.rs index bdf6390d96..1a1fa08762 100644 --- a/provider/icu4x-datagen/src/main.rs +++ b/provider/icu4x-datagen/src/main.rs @@ -145,10 +145,10 @@ struct Cli { #[cfg(feature = "provider")] trie_type: TrieType, - #[arg(long, val...
3
21
21
4fe46588823a21a20aae205dbade149670de1ff9
Robert Bastian
2025-03-28T19:07:45
Remove Hijri scaffolding from semver (#6383) This removes scaffolding and data-provider-specific code from `calendrical_calculations` and moves it into the `icu_calendar` crate. This allows us to iterate on this without breaking semver between `icu_calendar`, `calendrical_calculations`, and `icu_provider_source`. This...
diff --git a/components/calendar/Cargo.toml b/components/calendar/Cargo.toml index edb22d75db..2c5e2e936a 100644 --- a/components/calendar/Cargo.toml +++ b/components/calendar/Cargo.toml @@ -36,6 +36,7 @@ icu_calendar_data = { workspace = true, optional = true } icu_locale = { workspace = true, optional = true } [d...
6
259
341
d50ae5569bc9fc26acab718aad83d45c7f8efe10
Robert Bastian
2025-03-28T18:33:33
Remove prev_year info (#6382) This became dead code in #6319
diff --git a/components/calendar/src/cal/hijri.rs b/components/calendar/src/cal/hijri.rs index 1434a7c79f..93b0850387 100644 --- a/components/calendar/src/cal/hijri.rs +++ b/components/calendar/src/cal/hijri.rs @@ -220,44 +220,9 @@ impl HijriTabular { } } -/// Compact representation of the length of a Hijri yea...
2
56
155
b15d9e19a6773693ee82b9b9188bf736dc40bf3a
Manish Goregaokar
2025-03-27T23:09:42
Fix reexport documentation to be clearer when things are reexports (#6372) Also moves public/stable types TimeZone and TimeZoneVariant out of the provider module, turning the reexport into the other direction. Even with `doc(no_inline)`, I'm more comfortable with the provider module only containing unstable types and ...
diff --git a/components/calendar/src/date.rs b/components/calendar/src/date.rs index 005b76e97b..d4685ac461 100644 --- a/components/calendar/src/date.rs +++ b/components/calendar/src/date.rs @@ -89,6 +89,8 @@ impl<C> Deref for Ref<'_, C> { /// A date for a given calendar. /// +/// **The primary definition of this t...
10
146
134
f67645a753a02f8031b874759f9a1319248a978f
Robert Bastian
2025-03-27T21:07:53
Unify day-of-week calculation (#6368) Weekdays are not calender-specific, and the current code is overly complex.
diff --git a/components/calendar/src/cal/coptic.rs b/components/calendar/src/cal/coptic.rs index 3c0523c078..648def62ff 100644 --- a/components/calendar/src/cal/coptic.rs +++ b/components/calendar/src/cal/coptic.rs @@ -131,10 +131,6 @@ impl Calendar for Coptic { date.0.days_in_month() } - fn day_of_w...
13
54
113
17517bb8b34488fe50cc245a7503e864d3ad909b
Shane F. Carr
2025-03-27T19:53:53
Remove JapaneseExtended from CalMarkers (#6370) Follow-up to #6366
diff --git a/components/datetime/src/scaffold/calendar.rs b/components/datetime/src/scaffold/calendar.rs index e1f25f4eaa..cc506715d8 100644 --- a/components/datetime/src/scaffold/calendar.rs +++ b/components/datetime/src/scaffold/calendar.rs @@ -187,7 +187,7 @@ impl UnstableSealed for JapaneseExtended {} impl Unstabl...
1
1
5
2f5c0e9c970725625707eb9b3f6a605a2773061c
Robert Bastian
2025-03-27T16:07:54
Remove `JapaneseExtended` from `DateTimeFormatter::try_new` (#6366) Fixes #4889
diff --git a/components/datetime/src/external_loaders.rs b/components/datetime/src/external_loaders.rs index e22dae6b8f..3ef3d2f405 100644 --- a/components/datetime/src/external_loaders.rs +++ b/components/datetime/src/external_loaders.rs @@ -8,7 +8,7 @@ use icu_decimal::options::DecimalFormatterOptions; use icu_decim...
7
121
128
71450e0a24378ae0a03e4b83ec53a5dc1afc5b29
Manish Goregaokar
2025-03-26T18:46:12
Add toplevel build.rs to workspace includes (#6356)
diff --git a/Cargo.toml b/Cargo.toml index f9a3f3048c..bfe7c1e277 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -124,6 +124,7 @@ include = [ "Cargo.toml", "LICENSE", "README.md", + "build.rs", ] [workspace.dependencies]
1
1
0
bc9f6dc5774774b6fd5d256a0f1931091e5f0ecc
Robert Bastian
2025-03-26T15:13:41
Borrow in icu_casemap (#6353) #6234
diff --git a/components/casemap/src/casemapper.rs b/components/casemap/src/casemapper.rs index 7ba7c27c2e..9604384eae 100644 --- a/components/casemap/src/casemapper.rs +++ b/components/casemap/src/casemapper.rs @@ -8,7 +8,7 @@ use crate::provider::CaseMap; use crate::provider::CaseMapV1; use crate::set::ClosureSink; ...
5
68
57
c9114d7506d550f386dacc5cdebf3601db16a5bf
Robert Bastian
2025-03-25T16:48:49
AnyCalendarPreferences -> CalendarPreferences (#6349)
diff --git a/components/calendar/src/any_calendar.rs b/components/calendar/src/any_calendar.rs index 300075f83a..a523f5d4f8 100644 --- a/components/calendar/src/any_calendar.rs +++ b/components/calendar/src/any_calendar.rs @@ -20,9 +20,9 @@ use icu_provider::prelude::*; use core::fmt; define_preferences!( - /// ...
5
15
18
f037352623b6a19058388c560e5613b4db9ea7c4
Shane F. Carr
2025-03-25T16:31:21
Fix to_field_set_builder for times (#6347)
diff --git a/components/datetime/src/neo.rs b/components/datetime/src/neo.rs index 243e2aad00..a2cd8767d9 100644 --- a/components/datetime/src/neo.rs +++ b/components/datetime/src/neo.rs @@ -954,6 +954,7 @@ impl<C: CldrCalendar, FSet: DateTimeMarkers> FixedCalendarDateTimeFormatter<C, F /// equivalent_builder.date...
2
10
3
5b1d4f1672bb957841081df9e64145cbcc5fd69b
Younies Mahmoud
2025-03-25T11:11:09
Refactor buffer data constructors to align formatting for `try_new_with_buffer_provider` (#6348)
diff --git a/components/calendar/src/cal/hijri.rs b/components/calendar/src/cal/hijri.rs index 4a55c8f70b..4c395a4a15 100644 --- a/components/calendar/src/cal/hijri.rs +++ b/components/calendar/src/cal/hijri.rs @@ -184,7 +184,7 @@ impl HijriUmmAlQura { icu_provider::gen_buffer_data_constructors!(() -> error: DataE...
21
29
29
1e2727931b94e6d8981a0c62884cef28d1b673fc
Manish Goregaokar
2025-03-23T18:27:11
remove unused doc link (#6335) Fix nightly ci <!-- Thank you for your pull request to ICU4X! Reminder: try to use [Conventional Comments](https://conventionalcomments.org/) to make comments clearer. Please see https://github.com/unicode-org/icu4x/blob/main/CONTRIBUTING.md for general information on contributing to...
diff --git a/components/properties/src/props.rs b/components/properties/src/props.rs index 5994f32e0a..579e08f19f 100644 --- a/components/properties/src/props.rs +++ b/components/properties/src/props.rs @@ -672,7 +672,6 @@ impl From<GeneralCategoryGroup> for u32 { /// assert_eq!(CodePointMapData::<Script>::new().get('...
1
0
1
2bdae6954acacb4172589ee5f077545f92d0ea36
Manish Goregaokar
2025-03-21T21:15:01
Use regions, not languages, for calendar algorithm defaults (#6325) Depends on #6302 Matching on languages is incorrect here, these are region codes (treating `"sa"` as a language code gives us the obviously incorrect result of mapping Sanskrit to the Islamic calendar). Calendar choice is corellated with the region, ...
diff --git a/components/calendar/src/any_calendar.rs b/components/calendar/src/any_calendar.rs index 7db81ecdb7..300075f83a 100644 --- a/components/calendar/src/any_calendar.rs +++ b/components/calendar/src/any_calendar.rs @@ -14,7 +14,7 @@ use crate::{types, AsCalendar, Calendar, Date, DateDuration, DateDurationUnit, ...
3
11
8
3cc9cbc0f17cd53de2d10cd8778b5b8f15cb3751
Robert Bastian
2025-03-21T19:10:17
Simplify calendars in datagen (#6331)
diff --git a/provider/source/src/calendar/eras.rs b/provider/source/src/calendar/eras.rs index 4c193c5e83..062bd6be48 100644 --- a/provider/source/src/calendar/eras.rs +++ b/provider/source/src/calendar/eras.rs @@ -65,11 +65,7 @@ impl SourceDataProvider { DatagenCalendar::Dangi, ...
5
39
59
c1013e3ecab7898d1c7b2cef95dd1ec4baa39fbb
Manish Goregaokar
2025-03-17T18:03:33
fix tzdb github link (#6282) <!-- Thank you for your pull request to ICU4X! Reminder: try to use [Conventional Comments](https://conventionalcomments.org/) to make comments clearer. Please see https://github.com/unicode-org/icu4x/blob/main/CONTRIBUTING.md for general information on contributing to ICU4X. --> ------...
diff --git a/provider/icu4x-datagen/src/main.rs b/provider/icu4x-datagen/src/main.rs index 356e546284..8a6704ddf3 100644 --- a/provider/icu4x-datagen/src/main.rs +++ b/provider/icu4x-datagen/src/main.rs @@ -121,7 +121,7 @@ struct Cli { #[arg(long, value_name = "TAG", default_value = "latest")] #[arg( - ...
1
4
2
35a7097535631e133cf4ba1868bb238fa1d3910a
Robert Bastian
2025-03-17T18:02:35
Support aliases in preferences (#6301) #6220 #6227
diff --git a/components/locale_core/src/preferences/extensions/unicode/keywords/calendar.rs b/components/locale_core/src/preferences/extensions/unicode/keywords/calendar.rs index ba6355f574..87b4b9c346 100644 --- a/components/locale_core/src/preferences/extensions/unicode/keywords/calendar.rs +++ b/components/locale_co...
2
43
3
a03640cc0cd5977962b32e29f052644848b8d610
Shane F. Carr
2025-03-17T17:55:57
Add lower-level datetime benches (#6285)
diff --git a/components/datetime/benches/datetime.rs b/components/datetime/benches/datetime.rs index a11e926aab..19e3360240 100644 --- a/components/datetime/benches/datetime.rs +++ b/components/datetime/benches/datetime.rs @@ -4,11 +4,11 @@ mod fixtures; -use criterion::{criterion_group, criterion_main, Criterion}...
1
154
3
943e191e128a288c9bab16f22debf238397d075b
Shane F. Carr
2025-03-17T17:09:10
Add helper functions for time zone field name loading (#6289) #5940
diff --git a/components/datetime/src/pattern/names.rs b/components/datetime/src/pattern/names.rs index d9f977c3d6..74feb4aef7 100644 --- a/components/datetime/src/pattern/names.rs +++ b/components/datetime/src/pattern/names.rs @@ -353,7 +353,7 @@ impl DayPeriodNameLength { } } -pub struct EmptyDataProvider; +pu...
2
475
135
13f0860083b7ed632f9674d8785d48cf291b13d8
Robert Bastian
2025-03-17T17:04:17
Use `const` blocks (#6300)
diff --git a/components/locale_core/src/extensions/unicode/value.rs b/components/locale_core/src/extensions/unicode/value.rs index 5f0856af60..c2f3381078 100644 --- a/components/locale_core/src/extensions/unicode/value.rs +++ b/components/locale_core/src/extensions/unicode/value.rs @@ -339,24 +339,16 @@ impl_writeable_...
6
73
93
fbedbd82e2a96a8385fe986414a31019ea264b12
Shane F. Carr
2025-03-17T15:43:54
Add VALUES and improve errors of fieldset builder (#6299)
diff --git a/components/datetime/src/builder.rs b/components/datetime/src/builder.rs index 1f02b4ab04..b36975466c 100644 --- a/components/datetime/src/builder.rs +++ b/components/datetime/src/builder.rs @@ -140,6 +140,22 @@ pub enum DateFields { Y, } +impl DateFields { + /// All values of this enumeration. +...
1
66
17
5a3ee1f0c65aef336bb2cf749060acd3ad0b1b2b
Ben Beasley
2025-03-15T01:41:19
Fix test panics/segfaults in litemap on big-endian hosts (#6293) Provide a big-endian version of the serialized bytes in `RKYV`. Fixes #6292. Approach suggested by @sffc. (I tested this in emulation and on real `s390x` hardware.) <!-- Thank you for your pull request to ICU4X! Reminder: try to use [Conventional Com...
diff --git a/utils/litemap/tests/rkyv.rs b/utils/litemap/tests/rkyv.rs index 7ab1eb3f5f..1e6a2d72d2 100644 --- a/utils/litemap/tests/rkyv.rs +++ b/utils/litemap/tests/rkyv.rs @@ -26,16 +26,31 @@ const DATA: [(&str, &str); 11] = [ ("tr", "Turkish"), ]; -const RKYV: AlignedBytes<192> = AlignedBytes([ - 74, 97,...
1
25
10
8a5eeda0fe96d7293a43f987cdb2ffae1887160f
Shane F. Carr
2025-03-13T21:06:05
Improve datetime checksum validation (#6280) Part of #6063
diff --git a/components/datetime/src/pattern/names.rs b/components/datetime/src/pattern/names.rs index 644e2170cf..d9f977c3d6 100644 --- a/components/datetime/src/pattern/names.rs +++ b/components/datetime/src/pattern/names.rs @@ -546,6 +546,35 @@ size_test!( /// ] /// ); /// ``` +/// +/// When loading data for ...
1
33
4
0ff33180740ce4999f62ab51f0e829aeb3b049aa
Younies Mahmoud
2025-03-11T17:57:28
Improve MeasureUnit parsing with SmallVec and input validation (#6272)
diff --git a/components/experimental/src/measure/parser.rs b/components/experimental/src/measure/parser.rs index df65914674..2141c2cb27 100644 --- a/components/experimental/src/measure/parser.rs +++ b/components/experimental/src/measure/parser.rs @@ -2,7 +2,7 @@ // called LICENSE at the top level of the ICU4X source t...
1
85
5
72d64ccce98827a7a914cdd001b7b581bfebe43e
Manish Goregaokar
2025-03-11T16:35:46
Another Saturday wraparound fix for the keviyah math (#6270) Fixes #6261 <!-- Thank you for your pull request to ICU4X! Reminder: try to use [Conventional Comments](https://conventionalcomments.org/) to make comments clearer. Please see https://github.com/unicode-org/icu4x/blob/main/CONTRIBUTING.md for general inf...
diff --git a/utils/calendrical_calculations/src/hebrew_keviyah.rs b/utils/calendrical_calculations/src/hebrew_keviyah.rs index f618494f60..9b91a75ecf 100644 --- a/utils/calendrical_calculations/src/hebrew_keviyah.rs +++ b/utils/calendrical_calculations/src/hebrew_keviyah.rs @@ -677,7 +677,7 @@ impl Keviyah { /...
1
4
2
e183107ae309d00fce04e5ab352b6dfb925d1a30
Kevin Ness
2025-03-11T12:06:59
Fix for offset parsing leap seconds in `ixdtf` (#6213) This removes the support for leap second in UTC offsets along with a couple adjustments to the logic for UTC offsets.
diff --git a/components/time/src/ixdtf.rs b/components/time/src/ixdtf.rs index 97209ae936..2e611bad92 100644 --- a/components/time/src/ixdtf.rs +++ b/components/time/src/ixdtf.rs @@ -772,7 +772,7 @@ mod test { #[test] fn max_possible_ixdtf_utc_offset() { assert_eq!( - ZonedDateTime::try_of...
5
73
40
dbb82003ae8cc9664110dd49b694c45496f69307
Manish Goregaokar
2025-03-11T02:15:14
Fix Saturday week wraparound logic at the 7-18-0 ḥalakim boundary (#6267)
diff --git a/utils/calendrical_calculations/src/hebrew_keviyah.rs b/utils/calendrical_calculations/src/hebrew_keviyah.rs index 28ed4ff78c..f618494f60 100644 --- a/utils/calendrical_calculations/src/hebrew_keviyah.rs +++ b/utils/calendrical_calculations/src/hebrew_keviyah.rs @@ -233,7 +233,7 @@ impl YearInfo { ...
1
23
1
7e29aecb46554b026f179c19a8f822da2628e944
Manish Goregaokar
2025-03-10T21:56:21
Update itertools (#6264) Google3 already has 3 versions of this crate, we cannot import a fourth <!-- Thank you for your pull request to ICU4X! Reminder: try to use [Conventional Comments](https://conventionalcomments.org/) to make comments clearer. Please see https://github.com/unicode-org/icu4x/blob/main/CONTRIBU...
diff --git a/Cargo.lock b/Cargo.lock index a0439f2def..dae59007ad 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -223,7 +223,7 @@ dependencies = [ name = "bies" version = "0.2.3" dependencies = [ - "itertools 0.10.5", + "itertools 0.14.0", "partial-min-max", "rand", "rand_distr", @@ -952,15 +952,6 @@ version = "0...
3
13
27
788852e74732ee08a96168d907d016d654534cf3
Shane F. Carr
2025-03-06T20:18:07
Internal refactor of DateTimeFormatter (#6244) Organizes the inner workings without impacting stack size. I've wanted to do this for a while and #6243 was the impetus.
diff --git a/components/datetime/src/provider/packed_pattern.rs b/components/datetime/src/provider/packed_pattern.rs index 38f069fb5d..54c7f2885d 100644 --- a/components/datetime/src/provider/packed_pattern.rs +++ b/components/datetime/src/provider/packed_pattern.rs @@ -120,10 +120,16 @@ icu_provider::data_marker!( //...
2
247
384
61950ac74bb779f89a7971833357d4c7b7179278
Robert Bastian
2025-03-05T16:48:42
Clean up `icu_provider` docs (#6226) Fixes #6215 ![image](https://github.com/user-attachments/assets/3e144a83-e5b2-475b-b27d-708bb50b988a)
diff --git a/provider/core/src/export/mod.rs b/provider/core/src/export/mod.rs index 425519110f..735aef5e49 100644 --- a/provider/core/src/export/mod.rs +++ b/provider/core/src/export/mod.rs @@ -9,7 +9,9 @@ mod payload; -pub use payload::{ExportBox, ExportMarker}; +#[doc(hidden)] // macro +pub use payload::ExportB...
5
23
24
ca257a20d7178de4974eb385b771d86193a96159
Shane F. Carr
2025-03-04T23:32:12
impl Clone for DateTimeFormatter, DateTimeNames, DecimalFormatter (#6206)
diff --git a/components/datetime/src/neo.rs b/components/datetime/src/neo.rs index 3afd6a8d79..85c6d965d7 100644 --- a/components/datetime/src/neo.rs +++ b/components/datetime/src/neo.rs @@ -135,7 +135,7 @@ size_test!(FixedCalendarDateTimeFormatter<icu_calendar::Gregorian, crate::fields /// /// For more details, plea...
5
52
11
0f045638b131a367dfac0b8dd7bfe077988a764a
Robert Bastian
2025-03-04T18:56:20
Add `chrono` example (#6224)
diff --git a/Cargo.lock b/Cargo.lock index 851ed97a08..676d9dbd8c 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -335,6 +335,36 @@ version = "1.0.0" source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "baf1de4339761588bc0619e3cbc0120ee582ebb74b53b4efbf79117bd2da40fd" +[[package]] +name = "chron...
4
190
86
2aebf55a3a8d7783d87dbcc657b655a290827aa6
Shane F. Carr
2025-03-04T00:15:57
Add additional docs on ZeroFrom, EncodeAsVarULE (#6183) Follow-up from #6133 Originally discussed in #1180 We already say this in the `VarULE` docs. I am adding additional docs about the EncodeAsVarULE/ZeroFrom parallelism in the zerovec universe on the docs of those specific traits, too.
diff --git a/utils/zerovec/src/ule/encode.rs b/utils/zerovec/src/ule/encode.rs index a3515ff061..b940f8cf6c 100644 --- a/utils/zerovec/src/ule/encode.rs +++ b/utils/zerovec/src/ule/encode.rs @@ -39,6 +39,12 @@ use core::mem; /// implementation will add up the sizes of each field on the [`VarULE`] type and then add in ...
1
6
0
5ade4b39d9e9cc43d9eeebfb51b022da0b0ca071
Kevin Ness
2025-02-28T19:32:50
Remove support for U+2212 from `ixdtf` (#6207) <!-- Thank you for your pull request to ICU4X! Reminder: try to use [Conventional Comments](https://conventionalcomments.org/) to make comments clearer. Please see https://github.com/unicode-org/icu4x/blob/main/CONTRIBUTING.md for general information on contributing to ...
diff --git a/Cargo.lock b/Cargo.lock index 6cb5337027..851ed97a08 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -1959,7 +1959,6 @@ dependencies = [ "criterion", "displaydoc", "serde-json-core", - "utf8_iter", ] [[package]] diff --git a/utils/ixdtf/Cargo.toml b/utils/ixdtf/Cargo.toml index 17caf0417a..a4e40938e1...
8
114
136
d0d1b1f1106afea481302b0e3c3032af2b2af1ff
Henri Sivonen
2025-02-28T19:07:19
Tweak the docs for Islamic calendrical calculations (#6209) * Fix copypaste error. * Make the similarity of `civil` and `tbla` clearer. * Fix a typo.
diff --git a/utils/calendrical_calculations/src/islamic.rs b/utils/calendrical_calculations/src/islamic.rs index 3077adec73..b455bd775b 100644 --- a/utils/calendrical_calculations/src/islamic.rs +++ b/utils/calendrical_calculations/src/islamic.rs @@ -127,12 +127,12 @@ pub struct ObservationalIslamicMarker; #[allow(cli...
1
3
3
e40f6f2d221554e0e84113d3ca8f0f46b8b2c1b4
Henri Sivonen
2025-02-28T19:03:55
Say more precisely what the IslamicCivil and IslamicTabular calendar variants are (#6211) See https://cldr.unicode.org/development/development-process/design-proposals/islamic-calendar-types
diff --git a/components/calendar/src/islamic.rs b/components/calendar/src/islamic.rs index fc5833ba8d..a0e6795650 100644 --- a/components/calendar/src/islamic.rs +++ b/components/calendar/src/islamic.rs @@ -63,7 +63,13 @@ pub struct IslamicObservational { data: Option<DataPayload<CalendarIslamicObservationalV1>>, ...
1
15
2
e3e3c96a26307cd348f71f9325304498a3ad0db7
Henri Sivonen
2025-02-28T15:24:52
Fix copypaste error for Hijri era name (#6208)
diff --git a/components/calendar/src/islamic.rs b/components/calendar/src/islamic.rs index 3bdbc1a4e7..fc5833ba8d 100644 --- a/components/calendar/src/islamic.rs +++ b/components/calendar/src/islamic.rs @@ -52,7 +52,7 @@ fn year_as_islamic(standard_era: tinystr::TinyStr16, year: i32) -> types::YearIn /// /// # Era co...
1
4
4
40c3a646731f4a14422c534a9eb5204c2008e623
Manish Goregaokar
2025-02-26T19:03:44
lockfile
diff --git a/Cargo.lock b/Cargo.lock index d60e569423..6cb5337027 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -1288,20 +1288,25 @@ dependencies = [ name = "icu_experimental" version = "0.3.0-beta2" dependencies = [ + "criterion", "databake", "displaydoc", "either", "fixed_decimal", + "icu", "icu_collection...
1
5
0
371bf1a876f01eafe786acbe7847eccdbaab85c3
Manish Goregaokar
2025-02-26T19:01:29
lockfile
diff --git a/Cargo.lock b/Cargo.lock index 6cb5337027..d60e569423 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -1288,25 +1288,20 @@ dependencies = [ name = "icu_experimental" version = "0.3.0-beta2" dependencies = [ - "criterion", "databake", "displaydoc", "either", "fixed_decimal", - "icu", "icu_collection...
1
0
5
86fe50f272858bfc15640b2dd0572603b00e1210
Manish Goregaokar
2025-02-26T18:56:25
fix locale_core dep
diff --git a/components/decimal/Cargo.toml b/components/decimal/Cargo.toml index eb8c69c8fa..90166a0e38 100644 --- a/components/decimal/Cargo.toml +++ b/components/decimal/Cargo.toml @@ -23,7 +23,7 @@ all-features = true displaydoc = { workspace = true } fixed_decimal = { workspace = true } icu_provider = { workspac...
1
1
1
610757581c7d141a6f20f97fe839ef171c320bb1
Manish Goregaokar
2025-02-26T18:37:15
lockfile again
diff --git a/Cargo.lock b/Cargo.lock index 916427befd..6cb5337027 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -1753,6 +1753,10 @@ dependencies = [ [[package]] name = "icu_provider_registry" version = "2.0.0-beta2" +dependencies = [ + "icu", + "icu_provider 2.0.0-beta2", +] [[package]] name = "icu_provider_source...
1
4
0
f47b8ea1a83cadc36043103778d65d3afcca08d1
Manish Goregaokar
2025-02-26T18:36:51
lockfile
diff --git a/Cargo.lock b/Cargo.lock index 6cb5337027..916427befd 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -1753,10 +1753,6 @@ dependencies = [ [[package]] name = "icu_provider_registry" version = "2.0.0-beta2" -dependencies = [ - "icu", - "icu_provider 2.0.0-beta2", -] [[package]] name = "icu_provider_source...
1
0
4
423da5ae829d9fbc4ff401a10b1525e6fcd24ad4
Manish Goregaokar
2025-02-26T18:35:52
lockfile
diff --git a/Cargo.lock b/Cargo.lock index 7e89348048..6cb5337027 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -1403,10 +1403,18 @@ dependencies = [ name = "icu_locale_core" version = "2.0.0-beta2" dependencies = [ + "criterion", "databake", "displaydoc", + "iai", + "icu", + "icu_benchmark_macros", + "icu_provide...
1
8
0
59069da67633be780e68dbb170049121227beed8
Manish Goregaokar
2025-02-26T18:34:42
lockfile
diff --git a/Cargo.lock b/Cargo.lock index 6cb5337027..7e89348048 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -1403,18 +1403,10 @@ dependencies = [ name = "icu_locale_core" version = "2.0.0-beta2" dependencies = [ - "criterion", "databake", "displaydoc", - "iai", - "icu", - "icu_benchmark_macros", - "icu_provide...
1
0
8
c8a616acb260000e0b8ef3545fd6de2c528d7f29
Manish Goregaokar
2025-02-26T18:26:18
lockfile update
diff --git a/Cargo.lock b/Cargo.lock index 43bd6d738d..6cb5337027 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -1187,7 +1187,7 @@ checksum = "db2fa452206ebee18c4b5c2274dbf1de17008e874b4dc4f0aea9d01ca79e4526" dependencies = [ "displaydoc", "yoke 0.7.5", - "zerofrom", + "zerofrom 0.1.6 (registry+https://github.com/ru...
1
51
24
e9ab7308efb2fdc0fca96f71106c68f9f5840056
Manish Goregaokar
2025-02-26T18:22:53
Straggling version bump: tzif
diff --git a/Cargo.lock b/Cargo.lock index e2c068649b..43bd6d738d 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -563,7 +563,7 @@ dependencies = [ [[package]] name = "deduplicating_array" -version = "0.1.7" +version = "0.1.8" dependencies = [ "postcard", "serde", @@ -1187,7 +1187,7 @@ checksum = "db2fa452206ebee1...
13
48
75
f4290a877dfcb0f87cad6de4abdd65f0cbb33c9c
Manish Goregaokar
2025-02-26T18:17:25
Straggling version bump: deduplicating_array
diff --git a/utils/deduplicating_array/Cargo.toml b/utils/deduplicating_array/Cargo.toml index 92780bbd3a..db514d4768 100644 --- a/utils/deduplicating_array/Cargo.toml +++ b/utils/deduplicating_array/Cargo.toml @@ -5,7 +5,7 @@ [package] name = "deduplicating_array" description = "A serde serialization strategy that ...
1
1
1
0ebf9965af8782c505bc83ea5e26319ece7c501a
yongqli
2025-02-26T16:31:16
Implement Borrow for TinyAsciiStr (#6179) Added `Borrow` impl to `TinyAsciiStr`, same as the `Deref` impl. This is helpful if `TinyAsciiStr` is used as a `HashMap` key, for example.
diff --git a/utils/tinystr/src/ascii.rs b/utils/tinystr/src/ascii.rs index 9b0e24e8a3..89ec742b99 100644 --- a/utils/tinystr/src/ascii.rs +++ b/utils/tinystr/src/ascii.rs @@ -5,6 +5,7 @@ use crate::asciibyte::AsciiByte; use crate::int_ops::{Aligned4, Aligned8}; use crate::ParseError; +use core::borrow::Borrow; use ...
1
8
0
c6af9e6db98325012f60c44233fa90ec3ea076ac
Robert Bastian
2025-02-26T12:11:28
Clean up `FallbackMode` (#6194) #2856
diff --git a/provider/icu4x-datagen/src/main.rs b/provider/icu4x-datagen/src/main.rs index b17704d148..2171959962 100644 --- a/provider/icu4x-datagen/src/main.rs +++ b/provider/icu4x-datagen/src/main.rs @@ -235,7 +235,7 @@ enum TrieType { } #[derive(Copy, Clone, PartialEq, Eq, PartialOrd, Ord, ValueEnum, Debug)] -/...
1
2
12
536010cdd4df1072682796ffa619c1696b96b12f
Manish Goregaokar
2025-02-26T09:58:33
Update twoxhash to 2.0 (#5709) Supersedes https://github.com/unicode-org/icu4x/pull/5706
diff --git a/Cargo.lock b/Cargo.lock index 68bf27abf4..2f1fdb4d88 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -2772,12 +2772,6 @@ version = "1.2.0" source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "a8f112729512f8e442d81f95a8a7ddf2b7c6b8a1a6f509a95864142b30cab2d3" -[[package]] -name = "sta...
3
4
18
1a848e9be6ee34c0411ed7b116c736a732384c80
Manish Goregaokar
2025-02-26T00:40:58
Add regression test for #6041 (#6190)
diff --git a/components/properties/src/script.rs b/components/properties/src/script.rs index 22d746ca6c..c2188d1a59 100644 --- a/components/properties/src/script.rs +++ b/components/properties/src/script.rs @@ -686,3 +686,28 @@ impl ScriptWithExtensionsBorrowed<'static> { } } } + +#[cfg(test)] +mod tests...
1
25
0
6f62fe16a0b0fe100a0f722732a8367d25dc88a2
Manish Goregaokar
2025-02-21T19:40:22
Fix more nightly doc links (#6178)
diff --git a/components/locale/src/fallback/mod.rs b/components/locale/src/fallback/mod.rs index 38621dec49..a1029542f9 100644 --- a/components/locale/src/fallback/mod.rs +++ b/components/locale/src/fallback/mod.rs @@ -53,7 +53,6 @@ mod algorithms; /// /// [UTS #35: Locale Inheritance and Matching]: https://www.unico...
3
0
4
2204b1ce2500eba4fd6423967d7c3fc400f35b79
Petros Angelatos
2025-02-20T18:03:36
preserve stucture of timezone designation list (#5581) The intention of this PR is to maintain the structure of the binary data in the `DataBlock` struct. The current code produces a list of timezone designations that has the same length as the list of local time records with the i-th timezone designation correspondin...
diff --git a/utils/tzif/src/data/tzif.rs b/utils/tzif/src/data/tzif.rs index ce1e68fa8f..1948f87aff 100644 --- a/utils/tzif/src/data/tzif.rs +++ b/utils/tzif/src/data/tzif.rs @@ -299,3 +299,17 @@ pub struct DataBlock { /// A series of [`UtLocalIndicator`] objects. pub ut_local_indicators: Vec<UtLocalIndicator...
2
78
97
98fd43bdab55481966cd26c622959eb2f38ac568
Shane F. Carr
2025-02-20T17:40:15
Be less opinionated in HourCycle docs (#6051) Just got to reviewing #6038. I think the changes are good, but I think stylistically they are a bit too opinionated. We normally write our docs to be more matter-of-fact, leaving editorials to tutorials and blog posts.
diff --git a/components/locale_core/src/preferences/extensions/unicode/keywords/hour_cycle.rs b/components/locale_core/src/preferences/extensions/unicode/keywords/hour_cycle.rs index 174e5a6f09..c4f71531f1 100644 --- a/components/locale_core/src/preferences/extensions/unicode/keywords/hour_cycle.rs +++ b/components/loc...
1
6
4
a179fd8ff3acb17c996f6e90c17fc552dff7a50a
Shane F. Carr
2025-02-20T17:39:48
Use longer lifetime when returning normalize iter (#6060) https://github.com/unicode-org/icu4x/discussions/6058 Nothing should borrow from the borrowed type, because the borrowed type should not own anything.
diff --git a/components/normalizer/src/lib.rs b/components/normalizer/src/lib.rs index 2f2d5bbddd..48c3ab0418 100644 --- a/components/normalizer/src/lib.rs +++ b/components/normalizer/src/lib.rs @@ -1767,10 +1767,10 @@ impl DecomposingNormalizerBorrowed<'static> { } } -impl DecomposingNormalizerBorrowed<'_> { +...
1
5
5
b3aba399aff74f15b8fbab9b3dc2744b28fd57f0
Manish Goregaokar
2025-02-20T16:48:40
Remove broken unused intra-doc links (#6168) Looks like rustc started checking these as well
diff --git a/components/plurals/src/provider/rules/reference/serializer.rs b/components/plurals/src/provider/rules/reference/serializer.rs index 21cac64cc8..ed388cf3c8 100644 --- a/components/plurals/src/provider/rules/reference/serializer.rs +++ b/components/plurals/src/provider/rules/reference/serializer.rs @@ -34,14...
1
1
8
5921b95790365702d6e7b3ed78fcfcab330ac79c
Younies Mahmoud
2025-02-20T13:28:26
Refactor MeasureUnit to use `single_units` instead of `contained_units` (#6159)
diff --git a/components/experimental/src/measure/measureunit.rs b/components/experimental/src/measure/measureunit.rs index 93cd2da37a..e5d9469e81 100644 --- a/components/experimental/src/measure/measureunit.rs +++ b/components/experimental/src/measure/measureunit.rs @@ -7,13 +7,24 @@ use smallvec::SmallVec; use super:...
4
31
20
242992ccc3b14e9225c6d75f47ab2224cde2bcfd
Shane F. Carr
2025-02-20T09:46:17
Fix doc path to fields module (#6163) Might fix nightly CI
diff --git a/components/datetime/src/provider/neo/mod.rs b/components/datetime/src/provider/neo/mod.rs index c59a5487c1..ad411e70d6 100644 --- a/components/datetime/src/provider/neo/mod.rs +++ b/components/datetime/src/provider/neo/mod.rs @@ -190,7 +190,7 @@ pub mod marker_attrs { /// to be stable, their Rust repr...
1
1
1
82c6cd0cbe8beaf3e2e52826e44c40900c74ce6c
Arthur Silva
2025-02-16T19:46:18
Implement Entry apis for LiteMap (#6131) Add BTreeMap-like APIs to LiteMap to get closer to the std lib BTreeMap, which has familiarity benefits and allows easier integration of LiteMap into existing projects. Even though `try_get_or_insert` exists, the Entry API is a more familiar API with good performance, as ...
diff --git a/utils/litemap/src/lib.rs b/utils/litemap/src/lib.rs index d0b570311c..a8310d55cd 100644 --- a/utils/litemap/src/lib.rs +++ b/utils/litemap/src/lib.rs @@ -66,4 +66,4 @@ pub mod store; #[cfg(any(test, feature = "testing"))] pub mod testing; -pub use map::LiteMap; +pub use map::{Entry, LiteMap, OccupiedEn...
2
316
1
a51b23edfbf8b08fdfc044d0df4c11779fcb6dff
Saber Haj Rabiee
2025-02-15T13:11:17
Implement `Hash` and `Serde` traits for currency options (#6100)
diff --git a/components/experimental/src/dimension/currency/options.rs b/components/experimental/src/dimension/currency/options.rs index a65b790300..cd080c792d 100644 --- a/components/experimental/src/dimension/currency/options.rs +++ b/components/experimental/src/dimension/currency/options.rs @@ -4,9 +4,13 @@ //! O...
1
9
2
ee324d5fbe17ce8c32b88eeb80f5d205a2986d08
Shane F. Carr
2025-02-14T13:23:47
DateTime: Add conversions between Formatter and Names (#6110) Toward #5940 This allows a client such as FFI to add arbitrary data to a DateTimeFormatter instance. I put the conversion functions and docs on the DateTimeNames types because this is a power-user feature.
diff --git a/components/datetime/src/neo.rs b/components/datetime/src/neo.rs index 5a23d6e447..ba30a5e3ae 100644 --- a/components/datetime/src/neo.rs +++ b/components/datetime/src/neo.rs @@ -138,7 +138,7 @@ size_test!(FixedCalendarDateTimeFormatter<icu_calendar::Gregorian, crate::fields #[derive(Debug)] pub struct Fi...
5
645
107
1f504ba01b2c447ff7da85bd06b0918dd8236d03
Robert Bastian
2025-02-13T22:14:16
Sanity check the data marker names (#6114) #4991
diff --git a/components/list/src/provider/mod.rs b/components/list/src/provider/mod.rs index 8f1cbd89b1..3c10b061b2 100644 --- a/components/list/src/provider/mod.rs +++ b/components/list/src/provider/mod.rs @@ -53,16 +53,19 @@ pub const MARKERS: &[DataMarkerInfo] = &[ListAndV2::INFO, ListOrV2::INFO, ListUn data_marker...
2
22
1
2caaf3dc11e97a3b0621234cf257b64d6aa665cf
Robert Bastian
2025-02-12T16:03:25
Fix nightly (#6106)
diff --git a/components/datetime/src/fieldsets.rs b/components/datetime/src/fieldsets.rs index ba491c5c66..35c7693101 100644 --- a/components/datetime/src/fieldsets.rs +++ b/components/datetime/src/fieldsets.rs @@ -1221,7 +1221,7 @@ pub mod zone { /// ```compile_fail,E0271 /// use icu::calendar::{Date...
1
3
5
7697ae8c08dafd2aa89734f546f4abf67b717fad
Robert Bastian
2025-02-12T13:55:50
Remove normalizer's alloc feature (#6102) It uses a growable buffer internally
diff --git a/Cargo.lock b/Cargo.lock index 44ea11da93..98ee49c57b 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -2040,7 +2040,6 @@ dependencies = [ "icu_calendar", "icu_collections", "icu_locale_core", - "icu_normalizer", "icu_properties", "icu_provider", "icu_provider_baked", diff --git a/components/experime...
5
1
10
945e5c2803713d9fe317bbd3aee7335aada0c648
Robert Bastian
2025-02-11T16:51:46
Add disclaimer to short generic location format (#6095)
diff --git a/components/datetime/src/fieldsets.rs b/components/datetime/src/fieldsets.rs index f0427c674d..f7c71032cd 100644 --- a/components/datetime/src/fieldsets.rs +++ b/components/datetime/src/fieldsets.rs @@ -345,6 +345,10 @@ macro_rules! impl_zone_combo_helpers { } /// Associates this f...
1
8
0
7e935fe42deb924e09071c7d5b765baa8b39ecd9
Robert Bastian
2025-02-11T14:04:37
Update example to jiff 0.2 (#6094)
diff --git a/Cargo.lock b/Cargo.lock index dcf08506d9..44ea11da93 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -1811,9 +1811,9 @@ dependencies = [ [[package]] name = "jiff" -version = "0.1.23" +version = "0.2.0" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "7597657ea66d53f6e926a67d4c...
3
9
9
9617293694f83075ff45968932997a25d7b0c62b
Robert Bastian
2025-02-11T12:03:05
Download retries for `SourceDataProvider` (#6092)
diff --git a/provider/source/src/source.rs b/provider/source/src/source.rs index 1139c16e10..93e7c96a63 100644 --- a/provider/source/src/source.rs +++ b/provider/source/src/source.rs @@ -175,13 +175,21 @@ impl AbstractFs { if !root.exists() { log::info!("Downloading {resource}"); ...
1
15
7
77c4256d5b5691e3ba95a0312e4d9c715f9ba564
Robert Bastian
2025-02-10T10:15:11
Remove unused lifetime (#6089)
diff --git a/components/locale/src/fallback/mod.rs b/components/locale/src/fallback/mod.rs index b622b7abe4..ae14668e53 100644 --- a/components/locale/src/fallback/mod.rs +++ b/components/locale/src/fallback/mod.rs @@ -93,10 +93,9 @@ struct LocaleFallbackIteratorInner<'a> { /// Because the `Iterator` trait does not al...
2
4
6
a051c5bf129d58a5289e14a955c2ae56bfd3eddf
Manish Goregaokar
2025-02-07T23:03:35
Consistently wrap all options bags in None in Rust and FFI (#6084) Fixes #5488 This does not touch experimental stuff. We should add this to the graduation checklist. <!-- Thank you for your pull request to ICU4X! Reminder: try to use [Conventional Comments](https://conventionalcomments.org/) to make comments cle...
diff --git a/components/casemap/src/casemapper.rs b/components/casemap/src/casemapper.rs index 0b1ee5a80a..a0e5e4600e 100644 --- a/components/casemap/src/casemapper.rs +++ b/components/casemap/src/casemapper.rs @@ -182,7 +182,7 @@ impl CaseMapper { char_is_lead: impl Fn(&CaseMap, char) -> bool, ) -> Strin...
15
71
88
b7d772915df54b241d1355930fad6e14361894a8
Robert Bastian
2025-02-07T19:56:01
Remove usages of ForkByMarkerProvider (#6081)
diff --git a/components/decimal/src/grouper.rs b/components/decimal/src/grouper.rs index 9e68dab4a9..c52baef4c6 100644 --- a/components/decimal/src/grouper.rs +++ b/components/decimal/src/grouper.rs @@ -58,8 +58,7 @@ fn test_grouper() { use crate::DecimalFormatter; use fixed_decimal::SignedFixedDecimal; ...
4
164
64
eaaf49fd296b7a07ecf36fbbd83c982638934648
Robert Bastian
2025-02-05T16:16:48
`data_marker!` macro (#6072) This can replace the `#[data_struct]` proc macro. #5124
diff --git a/components/properties/src/provider.rs b/components/properties/src/provider.rs index c56be9611d..c2547332a8 100644 --- a/components/properties/src/provider.rs +++ b/components/properties/src/provider.rs @@ -479,21 +479,15 @@ pub enum PropertyCodePointMap<'data, T: TrieValue> { macro_rules! data_struct_gene...
8
79
107
af50a2fc4727d578c3d33c636554f8916e97d9a7
Younies Mahmoud
2025-02-04T08:43:28
Handle currency pattern parsing with TODO for negative sub-pattern (#6065) # Description: Adds a temporary handling of currency pattern parsing by taking the first part of the pattern before any semicolon. Includes a TODO comment to address handling of negative sub-patterns in the future.
diff --git a/provider/source/src/currency/essentials.rs b/provider/source/src/currency/essentials.rs index da79cd71b8..a53b296344 100644 --- a/provider/source/src/currency/essentials.rs +++ b/provider/source/src/currency/essentials.rs @@ -47,6 +47,9 @@ fn currency_pattern_selection( return Err(DataError::custo...
1
3
0
1b71a22ee84194280cd07f3ff89eb280623545cc
Manish Goregaokar
2025-02-03T13:46:36
More safety comments (#6056) As I'm performing safety audits, I'm coming across things that could be better commented. Opening a draft PR now so I have something to link to, will mark as reviewable when I'm done.
diff --git a/components/collator/src/elements.rs b/components/collator/src/elements.rs index 2ba8c31f65..7488e96a8a 100644 --- a/components/collator/src/elements.rs +++ b/components/collator/src/elements.rs @@ -204,7 +204,7 @@ fn in_inclusive_range(c: char, start: char, end: char) -> bool { /// Bits 5..4: Reserved. M...
13
83
30
5382dcf719d35bd5c975ce6c2b569517bb84afed
Manish Goregaokar
2025-02-02T13:11:09
Fix unsafety in properties (#6059) DataStructLong/DataStructShort are `'static` types, they should not show up in the Borrowed type.
diff --git a/components/properties/src/names.rs b/components/properties/src/names.rs index 23b0f5f833..605e99b4aa 100644 --- a/components/properties/src/names.rs +++ b/components/properties/src/names.rs @@ -365,7 +365,7 @@ impl<T: NamedEnumeratedProperty> core::fmt::Debug for PropertyNamesLong<T> { /// [`PropertyNames...
1
65
18
ff1a8e18be432b4f4ca011339b47b99396c51c95
Manish Goregaokar
2025-02-02T11:48:22
Better unsafe code in zerotrie (#6054) It's not great to have a macro that generates unsafe code based on invariants maintained outside of the macro. The macro should either have unsafe in its name, or the unsafe invariants should be certified outside.
diff --git a/utils/zerotrie/src/zerotrie.rs b/utils/zerotrie/src/zerotrie.rs index 13fbeb7f28..a0320f9fc5 100644 --- a/utils/zerotrie/src/zerotrie.rs +++ b/utils/zerotrie/src/zerotrie.rs @@ -119,6 +119,15 @@ pub struct ZeroTrieSimpleAscii<Store: ?Sized> { pub store: Store, } +impl<Store: ?Sized> ZeroTrieSimpleA...
1
49
4
9920677f209f97ebf0f0814a008dbb2712db430a
Henri Sivonen
2025-01-28T09:49:47
Fix the docs for HourCycle (#6038) Fixes #6030
diff --git a/components/locale_core/src/preferences/extensions/unicode/keywords/hour_cycle.rs b/components/locale_core/src/preferences/extensions/unicode/keywords/hour_cycle.rs index 8570adda4b..174e5a6f09 100644 --- a/components/locale_core/src/preferences/extensions/unicode/keywords/hour_cycle.rs +++ b/components/loc...
1
5
5
2508e6b4e377408e2867dff54e0b9868eadd8d0f
Manish Goregaokar
2025-01-28T09:34:04
Add explicit features list to tinystr (#6040) At this point we should always be using `dep:` to avoid confusion, and it helps when people are looking at the features list.
diff --git a/utils/tinystr/Cargo.toml b/utils/tinystr/Cargo.toml index 16bc01e8a6..0826c6654a 100644 --- a/utils/tinystr/Cargo.toml +++ b/utils/tinystr/Cargo.toml @@ -41,6 +41,9 @@ criterion = { workspace = true } [features] default = ["alloc"] alloc = [] +zerovec = ["dep:zerovec"] +databake = ["dep:databake"] +serd...
1
3
0
f958d463375456f4e73e1e5212deb84dfe0b553c
Robert Bastian
2025-01-27T23:00:15
Fetch tzdb from IANA (#6037) This is preferrable to GitHub because it is the authorative source. They also have a `latest` link.
diff --git a/Cargo.lock b/Cargo.lock index 44a42e5bd4..4d70d27b97 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -712,11 +712,13 @@ dependencies = [ "clap", "crlify", "eyre", + "flate2", "icu_locale_core", "icu_provider", "icu_provider_source", "log", "simple_logger", + "tar", "ureq", "zip", ] @@ -793...
9
224
55
3cad93c7b9084d39a0ec572c6bb0b6cd96491865
Manish Goregaokar
2025-01-22T18:54:58
Remove mutable era style (#6026)
diff --git a/components/calendar/src/ethiopian.rs b/components/calendar/src/ethiopian.rs index 946b066438..a0d58950cb 100644 --- a/components/calendar/src/ethiopian.rs +++ b/components/calendar/src/ethiopian.rs @@ -241,10 +241,6 @@ impl Ethiopian { pub const fn new_with_era_style(era_style: EthiopianEraStyle) -> S...
1
0
4