commit_hash
stringlengths
40
40
author
stringlengths
1
57
date
timestamp[s]date
2010-07-26 04:45:09
2026-04-14 18:21:10
message
stringlengths
8
1.39M
diff
stringlengths
68
51.2k
files_changed
int64
1
136
insertions
int64
0
2.35k
deletions
int64
0
1.9k
aa435298333ff70ae421a389e0493092f958f435
Shane F. Carr
2024-09-25T20:47:20
Display marker attributes in datagen output (#5578)
diff --git a/provider/export/src/export_impl.rs b/provider/export/src/export_impl.rs index 978e564383..8053ee65b7 100644 --- a/provider/export/src/export_impl.rs +++ b/provider/export/src/export_impl.rs @@ -96,7 +96,7 @@ impl ExportDriver { let flush_metadata = flush_metadata; let load_with_fallback...
1
4
9
b8a0b366d1cca32d15a5b52adb72730a6024670e
Robert Bastian
2024-09-24T16:00:35
Add `icu_provider::marker::ErasedMarker` (#5590) Using an erased marker for storage is a common pattern across multiple components. Also removed some unnecessary `cast()`s in datetime.
diff --git a/components/datetime/src/format/neo.rs b/components/datetime/src/format/neo.rs index 53055a3719..5768672bfc 100644 --- a/components/datetime/src/format/neo.rs +++ b/components/datetime/src/format/neo.rs @@ -158,7 +158,7 @@ where match provider.load_bound(req) { Ok(response) => { ...
18
53
95
cc3d7f5ac66cc3a82689c9dc337941e72070ef04
Manish Goregaokar
2024-09-23T20:48:53
Add icu_properties feature to icu_normalizer (#5551)
diff --git a/components/normalizer/Cargo.toml b/components/normalizer/Cargo.toml index f5398c4f05..028ef19a95 100644 --- a/components/normalizer/Cargo.toml +++ b/components/normalizer/Cargo.toml @@ -22,7 +22,7 @@ all-features = true [dependencies] displaydoc = { workspace = true } icu_collections = { workspace = tru...
5
109
50
7fa33d833bb0c0ef6fc614cd2a739b0b1a0d0443
Shane F. Carr
2024-09-23T19:05:27
Add references to LocaleCanonicalizer (#5306)
diff --git a/components/locale_core/src/langid.rs b/components/locale_core/src/langid.rs index 47ac9a392f..13a18153cf 100644 --- a/components/locale_core/src/langid.rs +++ b/components/locale_core/src/langid.rs @@ -26,8 +26,10 @@ use writeable::Writeable; /// At the moment parsing normalizes a well-formed language ide...
2
7
4
63563892481e68b675ffd27a9166855df35cbe1d
Shane F. Carr
2024-09-23T18:56:02
Change metacrate description for crates.io (#5215)
diff --git a/components/icu/Cargo.toml b/components/icu/Cargo.toml index d216551ffe..2ee6b6221d 100644 --- a/components/icu/Cargo.toml +++ b/components/icu/Cargo.toml @@ -4,7 +4,7 @@ [package] name = "icu" -description = "International Components for Unicode" +description = "ICU4X: International Components for Unic...
1
1
1
53a556689cce6029ef5477aa1fe552516a61a0b6
Robert Bastian
2024-09-23T15:57:44
cargo +nightly fmt (#5572) https://github.com/rust-lang/rustfmt/pull/5887
diff --git a/utils/pattern/src/common.rs b/utils/pattern/src/common.rs index cf9c630311..a2e328e4ba 100644 --- a/utils/pattern/src/common.rs +++ b/utils/pattern/src/common.rs @@ -153,7 +153,11 @@ where T: PlaceholderValueProvider<K> + ?Sized, { type Error = T::Error; - type W<'a> = T::W<'a> where T: 'a, '...
4
32
7
622a99208322b4918e89276121482fa5bfaedace
Robert Bastian
2024-09-19T16:24:17
Remove `dbg!` use (#5558)
diff --git a/provider/source/src/lib.rs b/provider/source/src/lib.rs index 96a4509af4..1b45f3db83 100644 --- a/provider/source/src/lib.rs +++ b/provider/source/src/lib.rs @@ -268,9 +268,9 @@ impl SourceDataProvider { pub fn with_tzdb_for_tag(self, tag: &str) -> Self { Self { tzdb_paths: Some(...
1
2
2
cd7075dbce3d019cca27f4ded3a5af626a89f467
Robert Bastian
2024-09-19T15:28:30
Fix `test_bake!` for beta (#5559)
diff --git a/utils/databake/src/lib.rs b/utils/databake/src/lib.rs index e82035f0f1..f736378c6d 100644 --- a/utils/databake/src/lib.rs +++ b/utils/databake/src/lib.rs @@ -182,8 +182,8 @@ macro_rules! test_bake { // For some reason `TokenStream` behaves differently in this line let expected_bake = $cra...
1
2
2
086699969ebcaddf5c6cc965ef9007a2147f8e9c
Shane F. Carr
2024-09-19T02:19:40
Include datagen APIs in bench target, fixing CI (#5557) It wants the datagen `options` APIs for parsing the fixtures. I could remove them from the fixtures, but it seemed easier to just enable them in bench mode.
diff --git a/components/datetime/Cargo.toml b/components/datetime/Cargo.toml index 727695f53c..ae3c1e09b9 100644 --- a/components/datetime/Cargo.toml +++ b/components/datetime/Cargo.toml @@ -93,7 +93,7 @@ datagen = [ ] logging = ["icu_calendar/logging"] experimental = ["dep:litemap"] -bench = ["serde"] +bench = ["se...
1
1
1
987c36431d0b84fec9069318a376327c76c2c7dc
Shane F. Carr
2024-09-18T01:02:37
Remove more obsolete datetime types (#5552) #1317
diff --git a/components/datetime/src/calendar.rs b/components/datetime/src/calendar.rs index 1a0edd2ad6..42ee10cbba 100644 --- a/components/datetime/src/calendar.rs +++ b/components/datetime/src/calendar.rs @@ -2,7 +2,6 @@ // called LICENSE at the top level of the ICU4X source tree // (online at: https://github.com/u...
11
14
465
3ba8697f820b98e1354c7e9830634156bdcc3686
Ben Beasley
2024-09-13T19:56:00
In zerovec, add the yoke version bound to the dev-dependency (#5537)
diff --git a/utils/zerovec/Cargo.toml b/utils/zerovec/Cargo.toml index ee858e9756..6aaba2d27a 100644 --- a/utils/zerovec/Cargo.toml +++ b/utils/zerovec/Cargo.toml @@ -51,7 +51,7 @@ rmp-serde = { workspace = true } serde = { workspace = true, features = ["derive"] } serde_json = { workspace = true } potential_utf = {...
1
1
1
58c3dc6cfc81f662499b19383a24ee94ea07d81a
Robert Bastian
2024-09-12T16:17:44
Don't use `CustomTimeZone` internally in `icu::datetime` (#5534) `CustomTimeZone` is what it says on the lid, `icu::timezone`'s custom timezone type. It should not be used internally by `icu::datetime`, this PR relegates it to an input-only type and instead uses the four fields offset, id, metazone, and zone varian...
diff --git a/components/datetime/src/format/datetime.rs b/components/datetime/src/format/datetime.rs index 0ae58aa186..c5b1a8995a 100644 --- a/components/datetime/src/format/datetime.rs +++ b/components/datetime/src/format/datetime.rs @@ -36,7 +36,7 @@ use icu_calendar::AnyCalendarKind; use icu_decimal::FixedDecimalFo...
5
164
86
ec8a5aa8a10d695da0f540bf825cdf3fb4a4b8aa
Robert Bastian
2024-09-12T16:17:25
Fix quotes in patterns (#5532)
diff --git a/components/experimental/src/relativetime/provider.rs b/components/experimental/src/relativetime/provider.rs index 5f1eed05dc..5f9d4e6078 100644 --- a/components/experimental/src/relativetime/provider.rs +++ b/components/experimental/src/relativetime/provider.rs @@ -135,9 +135,7 @@ where type Error = i...
6
42
61
e26633793303c1ac865dc57c6d371c0e3e2fd518
Manish Goregaokar
2024-09-10T14:34:55
Add a Format parameter to MultiFieldsULE, add Index8 format (#5522) <!-- Thank you for your pull request to ICU4X! Reminder: try to use [Conventional Comments](https://conventionalcomments.org/) to make comments clearer. Please see https://github.com/unicode-org/icu4x/blob/main/CONTRIBUTING.md for general informatio...
diff --git a/utils/zerovec/derive/src/make_varule.rs b/utils/zerovec/derive/src/make_varule.rs index 36a6f6e7a9..597140d32c 100644 --- a/utils/zerovec/derive/src/make_varule.rs +++ b/utils/zerovec/derive/src/make_varule.rs @@ -522,7 +522,8 @@ impl<'a> UnsizedFields<'a> { quote!( let leng...
6
45
10
4c68522931f9403871b150379006dac70854e55d
Kart
2024-09-09T13:17:04
DurationFormatter: Handle zero durations correctly (#5432)
diff --git a/components/experimental/src/duration/duration.rs b/components/experimental/src/duration/duration.rs index 11ebb68207..5842b61abb 100644 --- a/components/experimental/src/duration/duration.rs +++ b/components/experimental/src/duration/duration.rs @@ -59,6 +59,25 @@ impl Duration { self.nanoseco...
2
76
15
775173176d2327c9046e2da54b77ac555c75a962
Shane F. Carr
2024-09-09T04:19:33
Add VarTuple and VarTupleULE (#5511) This abstraction makes things much easier. It is easier to debug than `make_varule`, and it composes nicely. I really want to use this for the plurals and patterns things. I had to use `transmute_copy` because the compiler doesn't know that the generic is a fat pointer. But, ...
diff --git a/utils/zerovec/src/ule/chars.rs b/utils/zerovec/src/ule/chars.rs index 2e1bf82a3a..58cfe1ebf4 100644 --- a/utils/zerovec/src/ule/chars.rs +++ b/utils/zerovec/src/ule/chars.rs @@ -52,6 +52,17 @@ impl CharULE { Self([u0, u1, u2]) } + /// Converts this [`CharULE`] to a [`char`]. This is equi...
3
224
9
e059aaf8f83433f5317325e334417f77699101a7
Shane F. Carr
2024-09-07T00:01:33
Fix main (#5517)
diff --git a/components/experimental/tests/transliterate/lower_ascii.rs b/components/experimental/tests/transliterate/lower_ascii.rs index 76a5fb142f..b997afcc15 100644 --- a/components/experimental/tests/transliterate/lower_ascii.rs +++ b/components/experimental/tests/transliterate/lower_ascii.rs @@ -98,7 +98,7 @@ fn ...
1
1
1
7193a9464018289cc7053bdaf18b1d417dd312c1
Robert Bastian
2024-09-06T19:14:09
Fix transliterator fallback loading (#5489)
diff --git a/components/experimental/src/transliterate/transliterator/mod.rs b/components/experimental/src/transliterate/transliterator/mod.rs index 300f48a977..0c96fb98c6 100644 --- a/components/experimental/src/transliterate/transliterator/mod.rs +++ b/components/experimental/src/transliterate/transliterator/mod.rs @...
1
43
56
ee718bab60204ff6ceb7aa5a00637339155f7628
Shane F. Carr
2024-09-06T16:32:48
Add test for custom transliterator using Latin-ASCII and Lower (#5469)
diff --git a/components/experimental/Cargo.toml b/components/experimental/Cargo.toml index 4ae6c3e296..406668ef58 100644 --- a/components/experimental/Cargo.toml +++ b/components/experimental/Cargo.toml @@ -98,6 +98,10 @@ path = "tests/relativetime/tests.rs" name = "transliterate_test" path = "tests/transliterate/cld...
5
118
2
28dd2cbaece2557d63fb44e53158b92d0d7094ed
Robert Bastian
2024-09-06T14:23:33
Silence collator override loading (#5491) Follow up #5318
diff --git a/components/segmenter/src/sentence.rs b/components/segmenter/src/sentence.rs index dbbb04dd06..d014c42688 100644 --- a/components/segmenter/src/sentence.rs +++ b/components/segmenter/src/sentence.rs @@ -186,23 +186,27 @@ impl SentenceSegmenter { let payload_locale_override = if let Some(locale) = o...
2
70
60
87159802bd2300f82861a37c142dcab5c653c429
Shane F. Carr
2024-09-06T07:08:02
Change docs tests to use try_from_str instead of ::gmt()/::bst() and delete them (#5508) Follow-up to #5495
diff --git a/components/datetime/src/format/neo.rs b/components/datetime/src/format/neo.rs index 8803d0f03b..d6da8e87a1 100644 --- a/components/datetime/src/format/neo.rs +++ b/components/datetime/src/format/neo.rs @@ -347,11 +347,11 @@ size_test!( /// /// // The pattern string contains lots of symbols including "E",...
3
77
58
901390ecb93ee83fe68faf71e238e48c53cd8881
Shane F. Carr
2024-09-05T17:21:11
Add RuleCollection::register_aliases and bigger, working Transliterator docs test (#5483) A more docs-friendly version of the test introduced in #5469 Related: #3991
diff --git a/components/experimental/src/transliterate/compile/mod.rs b/components/experimental/src/transliterate/compile/mod.rs index e37a9d7b44..8bc3e6527a 100644 --- a/components/experimental/src/transliterate/compile/mod.rs +++ b/components/experimental/src/transliterate/compile/mod.rs @@ -113,11 +113,20 @@ impl Ru...
2
83
4
bd2c28e61b978ad9d36513249078bbd3096693aa
Robert Bastian
2024-09-05T13:37:02
Add `DataPayload::get_static` (#5496)
diff --git a/provider/core/src/response.rs b/provider/core/src/response.rs index d011c83cb8..1803eeba07 100644 --- a/provider/core/src/response.rs +++ b/provider/core/src/response.rs @@ -454,6 +454,18 @@ where } } + /// Borrows the underlying data statically if possible. + /// + /// This will s...
1
12
0
0f69524b2b372afc0825f4917e0e8f4afdb87c90
Shane F. Carr
2024-09-05T02:03:39
Migrate example tui to neo datetime and impl fmt::Display for LossyWrap (#5493)
diff --git a/components/icu/examples/tui.rs b/components/icu/examples/tui.rs index a169176889..726c732039 100644 --- a/components/icu/examples/tui.rs +++ b/components/icu/examples/tui.rs @@ -5,14 +5,17 @@ // An example program making use of a number of ICU components // in a pseudo-real-world application of Textual U...
2
23
13
4636092efb50754473f4a40402466082ffb44ac3
Shane F. Carr
2024-09-04T18:53:23
Replace resolved components API with neo-based alternative (#5465)
diff --git a/components/datetime/src/neo_pattern.rs b/components/datetime/src/neo_pattern.rs index 9151c65a8a..483195d311 100644 --- a/components/datetime/src/neo_pattern.rs +++ b/components/datetime/src/neo_pattern.rs @@ -23,16 +23,18 @@ size_test!(DateTimePattern, date_time_pattern_size, 32); /// 1. From a custom pa...
3
71
26
a30ae892df1c0fe61ebfc86c76d46d7376cce7da
Shane F. Carr
2024-09-04T18:53:06
Hour should be included in Column alignment (#5487) Split from #5465 Happy to close this and keep the change in the context of #5465
diff --git a/components/datetime/src/raw/neo.rs b/components/datetime/src/raw/neo.rs index 6bab8d6b0e..99e6d5e8b8 100644 --- a/components/datetime/src/raw/neo.rs +++ b/components/datetime/src/raw/neo.rs @@ -896,7 +896,10 @@ impl<'a> ItemsAndOptions<'a> { && field.length == FieldLength::One ...
1
4
1
38228a7dc2d381bea39209af851948bd554183fe
Shane F. Carr
2024-09-03T22:35:13
Neo datagen: Refactor code from closure to function (#5470)
diff --git a/provider/source/src/datetime/neo_skeleton.rs b/provider/source/src/datetime/neo_skeleton.rs index 4808fd7d47..4967bd1cf9 100644 --- a/provider/source/src/datetime/neo_skeleton.rs +++ b/provider/source/src/datetime/neo_skeleton.rs @@ -245,6 +245,151 @@ impl SourceDataProvider { } } +/// Convert from...
1
147
138
d305618c5c9f3fe11b61248a8d1526a1353eb2ca
Kart
2024-09-03T13:21:30
DurationFormatter: Clamp fractional digits (#5421)
diff --git a/components/experimental/src/duration/options.rs b/components/experimental/src/duration/options.rs index 530a21c157..c1f34c8997 100644 --- a/components/experimental/src/duration/options.rs +++ b/components/experimental/src/duration/options.rs @@ -68,7 +68,8 @@ pub enum FractionalDigits { #[default] ...
2
26
1
69b940cbf06985ee1f43945f42a4058b61cf15df
Robert Bastian
2024-09-03T13:11:44
Fix plurals bench (#5474)
diff --git a/components/plurals/Cargo.toml b/components/plurals/Cargo.toml index ec5a5d41fd..88ec6ba823 100644 --- a/components/plurals/Cargo.toml +++ b/components/plurals/Cargo.toml @@ -46,7 +46,7 @@ std = ["fixed_decimal/std", "icu_locale_core/std", "icu_provider/std"] serde = ["dep:serde", "zerovec/serde", "icu_loc...
2
2
2
fdecd2e31af064deeab71e10c926eb5603725429
Younies Mahmoud
2024-08-28T12:41:52
Chore: Update databake path for currencies & units providers (#5457)
diff --git a/components/experimental/src/dimension/provider/pattern_key.rs b/components/experimental/src/dimension/provider/pattern_key.rs index e4e310277f..d9954841f7 100644 --- a/components/experimental/src/dimension/provider/pattern_key.rs +++ b/components/experimental/src/dimension/provider/pattern_key.rs @@ -14,11...
4
12
30
a806f307500cac21f11f06f62a83ec9fbe106faa
Younies Mahmoud
2024-08-27T23:13:54
Refactor: Rename compactdecimal.rs to formatter.rs and move the options to options.rs (#5458)
diff --git a/components/experimental/src/compactdecimal/format.rs b/components/experimental/src/compactdecimal/format.rs index bfe4a2f96c..e32a035d7b 100644 --- a/components/experimental/src/compactdecimal/format.rs +++ b/components/experimental/src/compactdecimal/format.rs @@ -7,7 +7,7 @@ use fixed_decimal::{CompactDe...
4
58
54
86a08986bbf8f2168243f7457d33a21014cc5dcb
Younies Mahmoud
2024-08-27T23:00:30
Chore: Update databake path for units (#5459) <!-- Thank you for your pull request to ICU4X! Reminder: try to use [Conventional Comments](https://conventionalcomments.org/) to make comments clearer. Please see https://github.com/unicode-org/icu4x/blob/main/CONTRIBUTING.md for general information on contribu...
diff --git a/components/experimental/src/measure/provider/si_prefix.rs b/components/experimental/src/measure/provider/si_prefix.rs index a2700412de..c91b5c95dd 100644 --- a/components/experimental/src/measure/provider/si_prefix.rs +++ b/components/experimental/src/measure/provider/si_prefix.rs @@ -11,11 +11,8 @@ ///...
4
16
40
6d6888bea31a3d8fb469a228fc6560d6534f5d70
Younies Mahmoud
2024-08-27T15:13:10
Chore: Update databake path for extended_currency.rs (#5455)
diff --git a/components/experimental/src/dimension/provider/extended_currency.rs b/components/experimental/src/dimension/provider/extended_currency.rs index 30e71a7ffc..f30595cc2e 100644 --- a/components/experimental/src/dimension/provider/extended_currency.rs +++ b/components/experimental/src/dimension/provider/extend...
1
2
5
c1cec0868e00722fa39c2e14a006e56d11e934ff
Younies Mahmoud
2024-08-27T15:12:41
Chore: Update databake path for currency.rs (#5454)
diff --git a/components/experimental/src/dimension/provider/currency.rs b/components/experimental/src/dimension/provider/currency.rs index f18de8c056..9a7895dbaa 100644 --- a/components/experimental/src/dimension/provider/currency.rs +++ b/components/experimental/src/dimension/provider/currency.rs @@ -35,12 +35,9 @@ pu...
1
8
20
02a2796b9861971438df70129c38ca919ac4663a
Younies Mahmoud
2024-08-27T15:12:23
Chore: Update databake path for currency_patterns.rs (#5453)
diff --git a/components/experimental/src/dimension/provider/currency_patterns.rs b/components/experimental/src/dimension/provider/currency_patterns.rs index 70249e1d62..53f5fb53e1 100644 --- a/components/experimental/src/dimension/provider/currency_patterns.rs +++ b/components/experimental/src/dimension/provider/curren...
1
2
5
0abdda9e4098c63a8eb3d0ab463bb0e018a6e241
Younies Mahmoud
2024-08-27T15:12:02
Chore: Update databake path for currency_compact.rs (#5452)
diff --git a/components/experimental/src/dimension/provider/currency_compact.rs b/components/experimental/src/dimension/provider/currency_compact.rs index 5e720efe6d..c447ac49b9 100644 --- a/components/experimental/src/dimension/provider/currency_compact.rs +++ b/components/experimental/src/dimension/provider/currency_...
1
4
10
e1bada442697b2a0959254cad093aecf5d0c0fcd
Younies Mahmoud
2024-08-27T15:11:42
Chore: Update databake path for currency_displayname.rs (#5451)
diff --git a/components/experimental/src/dimension/provider/currency_displayname.rs b/components/experimental/src/dimension/provider/currency_displayname.rs index 165bd7b085..3d89ce274d 100644 --- a/components/experimental/src/dimension/provider/currency_displayname.rs +++ b/components/experimental/src/dimension/provid...
1
2
5
332dfacf635053efbd6861dddcb66f4126e6d40d
Younies Mahmoud
2024-08-27T15:11:15
Use an appropriate name for currencies' displaynames (#5449)
diff --git a/provider/source/src/cldr_serde/currencies/data.rs b/provider/source/src/cldr_serde/currencies/data.rs index 518b724afb..67c55e340f 100644 --- a/provider/source/src/cldr_serde/currencies/data.rs +++ b/provider/source/src/cldr_serde/currencies/data.rs @@ -11,7 +11,7 @@ use serde::Deserialize; use std::colle...
2
8
8
f06f048d635be5ca45a98f91c679fb512a6029f3
Younies Mahmoud
2024-08-26T21:57:18
Implement `LongCurrencyFormatter` for Long Currency Formatting (#5351)
diff --git a/components/experimental/src/dimension/currency/format.rs b/components/experimental/src/dimension/currency/format.rs index 9d73946373..054d43e24c 100644 --- a/components/experimental/src/dimension/currency/format.rs +++ b/components/experimental/src/dimension/currency/format.rs @@ -7,9 +7,9 @@ use fixed_dec...
6
293
10
286041cc4981cb8bfcd49180f5c2a8282bc60d83
Kart
2024-08-26T18:27:29
DurationFormatter: Correct SmallVec Size (#5445)
diff --git a/components/experimental/src/duration/format.rs b/components/experimental/src/duration/format.rs index abf252d5cf..7cc912279d 100644 --- a/components/experimental/src/duration/format.rs +++ b/components/experimental/src/duration/format.rs @@ -449,10 +449,10 @@ impl<'a> FormattedDuration<'a> { &self...
1
2
2
88f3d3607118b21c24a413b51fe0da68c1f3e1e5
Shane F. Carr
2024-08-22T21:47:55
Add full x/X time zone field support to semantic skeleta (#5410) #1317 This has tests in the upcoming #5411
diff --git a/components/datetime/src/format/datetime.rs b/components/datetime/src/format/datetime.rs index 70406682d2..64c1027979 100644 --- a/components/datetime/src/format/datetime.rs +++ b/components/datetime/src/format/datetime.rs @@ -18,7 +18,6 @@ use crate::provider::date_time::{ DateSymbols, GetSymbolForEra...
4
145
38
fd5258f2fc44b4148fe0efaba5369a5c821643d1
Shane F. Carr
2024-08-22T06:41:45
A bit more code sharing in DataPayload<ExportMarker> (#5431) Follow-up to #5428
diff --git a/provider/core/src/export/payload.rs b/provider/core/src/export/payload.rs index 48102ead74..217fbc96a3 100644 --- a/provider/core/src/export/payload.rs +++ b/provider/core/src/export/payload.rs @@ -198,30 +198,7 @@ impl DataPayload<ExportMarker> { impl core::hash::Hash for DataPayload<ExportMarker> { ...
1
1
24
c3e1fed8dd94660f84dbfa54272ba23047c6fda9
Kart
2024-08-21T21:58:07
DurationFormatter: Add Tests (#5419)
diff --git a/components/experimental/src/duration/format.rs b/components/experimental/src/duration/format.rs index 8b7ab23df8..abf252d5cf 100644 --- a/components/experimental/src/duration/format.rs +++ b/components/experimental/src/duration/format.rs @@ -608,9 +608,12 @@ impl Writeable for FormattedDuration<'_> { ...
2
107
0
44c31777c3aa0d0fbf95589a0e502552eeb543e2
Robert Bastian
2024-08-21T21:54:45
Delete dead `Count` (#5425) https://github.com/unicode-org/icu4x/issues/5369
diff --git a/components/experimental/src/dimension/provider/count.rs b/components/experimental/src/dimension/provider/count.rs deleted file mode 100644 index f19e4b0f62..0000000000 --- a/components/experimental/src/dimension/provider/count.rs +++ /dev/null @@ -1,31 +0,0 @@ -// This file is part of ICU4X. For terms of u...
2
0
32
2e5009230c9d1234e68e03c63baf7ddc89aa15f8
Robert Bastian
2024-08-21T17:22:07
Rename `TinyStrError` to `ParseError` (#5405)
diff --git a/utils/tinystr/src/ascii.rs b/utils/tinystr/src/ascii.rs index 0daf216ca5..2b62427f14 100644 --- a/utils/tinystr/src/ascii.rs +++ b/utils/tinystr/src/ascii.rs @@ -4,7 +4,7 @@ use crate::asciibyte::AsciiByte; use crate::int_ops::{Aligned4, Aligned8}; -use crate::TinyStrError; +use crate::ParseError; use...
4
25
30
9e9e39e004855e3b5db30aa1b51b1b01da1732ec
Younies Mahmoud
2024-08-21T13:10:27
Add unit tests for currency patterns datagen (#5414)
diff --git a/provider/source/src/currency/patterns.rs b/provider/source/src/currency/patterns.rs index f9a504ccf1..20c417f36f 100644 --- a/provider/source/src/currency/patterns.rs +++ b/provider/source/src/currency/patterns.rs @@ -83,3 +83,56 @@ impl IterableDataProviderCached<CurrencyPatternsDataV1Marker> for SourceDa...
1
53
0
8adbf92a124912ea92e163c6a97d0a4671a004ad
Kart
2024-08-21T12:23:47
DurationFormatter: Remove allocations (#5383)
diff --git a/Cargo.lock b/Cargo.lock index e68ac79bbb..03d36ec025 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -1253,6 +1253,7 @@ dependencies = [ "criterion", "databake", "displaydoc", + "either", "fixed_decimal", "icu", "icu_collections", diff --git a/Cargo.toml b/Cargo.toml index 1f08543c9c..443f980935 10...
4
143
169
00b596b76342d958b873bebf3b399a0dbd1af80b
Younies Mahmoud
2024-08-20T10:21:42
Refactor: Update `CompactCount` to use `PluralCategory` enum (#5401)
diff --git a/components/experimental/Cargo.toml b/components/experimental/Cargo.toml index 15837b2090..4dd191d837 100644 --- a/components/experimental/Cargo.toml +++ b/components/experimental/Cargo.toml @@ -69,7 +69,7 @@ icu_normalizer_data = { workspace = true } [features] default = ["compiled_data"] compiled_data ...
4
23
24
be0a1dfb1a8b4bbf48390cfdc0ed26f5717354ce
Younies Mahmoud
2024-08-20T08:17:03
Add databake support for `PluralCount` (#5396)
diff --git a/components/plurals/src/lib.rs b/components/plurals/src/lib.rs index 74ed56a16a..58b44fcfe6 100644 --- a/components/plurals/src/lib.rs +++ b/components/plurals/src/lib.rs @@ -144,7 +144,11 @@ pub enum PluralRuleType { /// assert_eq!(pr.category_for(5_usize), PluralCategory::Other); /// ``` #[derive(Debug...
1
5
1
7d06be3ecc1d201de8423637b284065505b0780d
Robert Bastian
2024-08-19T20:22:57
Restrict postcard version (#5395)
diff --git a/Cargo.toml b/Cargo.toml index e9f2e036f9..1478bd8138 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -244,7 +244,9 @@ memchr = { version = "2.6.0", default-features = false } num-bigint = { version = "0.4.3", default-features = false } num-rational = { version = "0.4.0", default-features = false } num-trait...
1
3
1
b125d4cef252df71a0ce3008212a3f0cdf96e7ab
Shane F. Carr
2024-08-19T20:16:00
Add Alignment neo option (#5381)
diff --git a/components/datetime/src/format/datetime.rs b/components/datetime/src/format/datetime.rs index 1b8b2bbbc0..ddb4734af3 100644 --- a/components/datetime/src/format/datetime.rs +++ b/components/datetime/src/format/datetime.rs @@ -158,7 +158,7 @@ impl<'l> fmt::Display for FormattedDateTime<'l> { } } -//...
7
211
35
7c8b8156dc10f5b7dfd9be64f24f4f02a01ace1e
Shane F. Carr
2024-08-19T18:50:32
make_ule: Support enums with min and max (#5391)
diff --git a/utils/zerovec/derive/Cargo.toml b/utils/zerovec/derive/Cargo.toml index a4f43a3042..0926282099 100644 --- a/utils/zerovec/derive/Cargo.toml +++ b/utils/zerovec/derive/Cargo.toml @@ -32,3 +32,18 @@ serde = { workspace = true, features = ["derive"] } zerofrom = { path = "../../../utils/zerofrom" } bincode ...
3
67
16
0f74162216b2c7025461c451dc7376b7a89b9c3c
Robert Bastian
2024-08-19T15:20:11
Cleanup allowlist (#5394)
diff --git a/tools/make/depcheck/src/allowlist.rs b/tools/make/depcheck/src/allowlist.rs index cea4bbba42..8ddb95cbdc 100644 --- a/tools/make/depcheck/src/allowlist.rs +++ b/tools/make/depcheck/src/allowlist.rs @@ -154,7 +154,7 @@ pub const EXTRA_FS_DEPS: &[&str] = &["icu_provider_fs", "serde-json-core"]; /// Depend...
2
4
4
500a9d66ceda289a6da212fc43b39f3e15f667b3
Shane F. Carr
2024-08-16T20:20:01
Fall back to glue patterns if custom hour cycle is required (#5388) See #5387
diff --git a/components/datetime/src/raw/neo.rs b/components/datetime/src/raw/neo.rs index b57ac6539a..770ad296ef 100644 --- a/components/datetime/src/raw/neo.rs +++ b/components/datetime/src/raw/neo.rs @@ -461,7 +461,8 @@ impl DateTimeZonePatternSelectionData { Ok(Self::Zone(selection)) }...
2
30
1
e438774a56c13cbf1a66f41079638980d8a57577
Younies Mahmoud
2024-08-15T17:30:43
Improve Field Names for `CompactDecimalPattern` (#5377)
diff --git a/provider/source/src/cldr_serde/numbers.rs b/provider/source/src/cldr_serde/numbers.rs index b5c218e050..a1733936c7 100644 --- a/provider/source/src/cldr_serde/numbers.rs +++ b/provider/source/src/cldr_serde/numbers.rs @@ -47,17 +47,17 @@ pub(crate) struct DecimalFormat { #[derive(PartialEq, Debug, Defau...
3
17
22
77576a41080faf542f9d00066c7f008913f2c106
Younies Mahmoud
2024-08-15T09:13:00
Add essential comments for `CompactDecimalPattern` (#5367)
diff --git a/provider/source/src/cldr_serde/numbers.rs b/provider/source/src/cldr_serde/numbers.rs index a738b7c0f2..76ecacaec9 100644 --- a/provider/source/src/cldr_serde/numbers.rs +++ b/provider/source/src/cldr_serde/numbers.rs @@ -47,8 +47,22 @@ pub(crate) struct DecimalFormat { #[derive(PartialEq, Debug, Defaul...
1
14
0
7962dd171c3faf5731ca91d9f1ec026b163b2cd6
Shane F. Carr
2024-08-15T04:23:11
Fix ISO and Hebrew eraDisplay (#5372)
diff --git a/components/datetime/src/input.rs b/components/datetime/src/input.rs index fcb09c6c37..1704d7f498 100644 --- a/components/datetime/src/input.rs +++ b/components/datetime/src/input.rs @@ -217,6 +217,7 @@ impl ExtractedDateTimeInput { | Some(AnyCalendarKind::Coptic) | Some(AnyCalenda...
1
2
1
52bd97a82dfc0042311e0c4938de9a7c0fab90f7
Robert Bastian
2024-08-13T17:08:49
Add script fallback priority; improve language/region fallback priority (#5344) #3867
diff --git a/components/locale/src/fallback/algorithms.rs b/components/locale/src/fallback/algorithms.rs index a3fe9bbed2..702215c526 100644 --- a/components/locale/src/fallback/algorithms.rs +++ b/components/locale/src/fallback/algorithms.rs @@ -8,7 +8,18 @@ use icu_locale_core::subtags::{Language, Region, Script}; u...
3
196
61
8be0aec72b74f81aa5fa8247c20635f6bf3d6ece
Ashutosh Jha
2024-08-13T12:23:21
Add more collator tests (#4767) Fixes #4167. Extension of #4633 Added test for `Tibetan` & `Bosnian`. Checks for change in order for `Japanese`. I couldn't find more language pair for which collator ordering changes.
diff --git a/components/collator/tests/tests.rs b/components/collator/tests/tests.rs index b51066d8f2..60e0dfdf50 100644 --- a/components/collator/tests/tests.rs +++ b/components/collator/tests/tests.rs @@ -112,6 +112,105 @@ fn test_currency() { } } +#[test] +fn test_bo() { + let locale: Locale = ("bo").pars...
1
130
4
1e3ad9b0ff25f850810c76099a2cf69ba60f7058
Kart
2024-08-13T11:29:52
DurationFormatter: Implement DurationFormatter (#5321)
diff --git a/Cargo.lock b/Cargo.lock index 2a467fa934..0739c14c3b 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -1233,6 +1233,7 @@ dependencies = [ "icu_collections", "icu_decimal", "icu_experimental_data", + "icu_list", "icu_locale", "icu_locale_core", "icu_locale_data", diff --git a/components/experimental/...
6
470
48
d801430433d9360c32d37afbb8257e4f9f40505d
Kart
2024-08-13T11:22:22
fixed_decimal: clarify documentation for position sign in padding functions (#5243) Example: `pad_start` documentation states that "Negative numbers have no effect". This is ambiguous between the number being formatted and the position number passed as an argument. Resolve this and other similar instances. Examp...
diff --git a/utils/fixed_decimal/src/decimal.rs b/utils/fixed_decimal/src/decimal.rs index 7e29f9d6ee..add806b494 100644 --- a/utils/fixed_decimal/src/decimal.rs +++ b/utils/fixed_decimal/src/decimal.rs @@ -1024,7 +1024,7 @@ impl FixedDecimal { /// Returns this number padded with leading zeros on a particular po...
1
4
4
88e6d83488b519eb2144a4e527f3d588a6b64846
Shane F. Carr
2024-08-12T10:16:56
Shadow `default` instead of making new function `const_default` (#5354) Suggested by @zbraniecki in https://github.com/unicode-org/icu4x/issues/5199#issuecomment-2278418718
diff --git a/components/collator/src/elements.rs b/components/collator/src/elements.rs index 71f56bccb9..ffad67f30a 100644 --- a/components/collator/src/elements.rs +++ b/components/collator/src/elements.rs @@ -130,11 +130,11 @@ const CONTRACT_TRAILING_CCC: u32 = 0x400; /// Set if at least one contraction suffix conta...
9
19
19
8bf1e2991629bd4219cb6513d18b53e499b4b4ef
Shane F. Carr
2024-08-09T23:20:36
Make h11/h24 work in neo datetime (#5355) #1317
diff --git a/components/datetime/src/format/datetime.rs b/components/datetime/src/format/datetime.rs index 48d2413644..1b8b2bbbc0 100644 --- a/components/datetime/src/format/datetime.rs +++ b/components/datetime/src/format/datetime.rs @@ -4,6 +4,7 @@ use crate::fields::{self, Field, FieldLength, FieldSymbol, Second,...
8
119
68
4f7bc8c105df39626b4e1ece52878f577c969836
Younies Mahmoud
2024-08-08T16:21:03
Fix clippy (#5347)
diff --git a/utils/env_preferences/src/apple.rs b/utils/env_preferences/src/apple.rs index 38304ac53d..bda231b504 100644 --- a/utils/env_preferences/src/apple.rs +++ b/utils/env_preferences/src/apple.rs @@ -157,7 +157,7 @@ pub fn get_system_timezone() -> Result<String, RetrievalError> { let cf_string = unsafe ...
1
1
1
974384f0a09410e5c031191c90e003ad81f1ef72
Younies Mahmoud
2024-08-08T11:11:44
Refactor: Introduce `measure` Module for Experimental Components (#5341)
diff --git a/components/experimental/src/lib.rs b/components/experimental/src/lib.rs index 5109ff6937..b22b7ef513 100644 --- a/components/experimental/src/lib.rs +++ b/components/experimental/src/lib.rs @@ -21,6 +21,7 @@ pub mod compactdecimal; pub mod dimension; pub mod displaynames; pub mod duration; +pub mod meas...
6
10
4
54ff78c5e8b612bb30d3025be4bc9951272fd8e0
Younies Mahmoud
2024-08-07T12:58:17
Add an essential comments for the currency patterns datagen. (#5332)
diff --git a/provider/source/src/currency/patterns.rs b/provider/source/src/currency/patterns.rs index 003d5b672f..f9a504ccf1 100644 --- a/provider/source/src/currency/patterns.rs +++ b/provider/source/src/currency/patterns.rs @@ -45,6 +45,9 @@ impl DataProvider<CurrencyPatternsDataV1Marker> for SourceDataProvider { ...
1
7
0
53e80df003c7451c770f1396f2634819d2fe278a
Alex Kazik
2024-08-07T10:20:41
Add helper structures to databake (#4666) (#5303) These allow to create a &'static str and &'static [T] from not static sources.
diff --git a/utils/databake/src/converter.rs b/utils/databake/src/converter.rs new file mode 100644 index 0000000000..10295e96f6 --- /dev/null +++ b/utils/databake/src/converter.rs @@ -0,0 +1,272 @@ +// This file is part of ICU4X. For terms of use, please see the file +// called LICENSE at the top level of the ICU4X so...
2
273
0
cea2a8c615fb932b87cd0a70745edb8bcd26e07a
Shane F. Carr
2024-08-06T16:54:09
Add Writeable WithPart helper (#5328)
diff --git a/utils/writeable/src/lib.rs b/utils/writeable/src/lib.rs index 47d5fab121..ffc7536b9f 100644 --- a/utils/writeable/src/lib.rs +++ b/utils/writeable/src/lib.rs @@ -86,6 +86,7 @@ pub mod adapters { use super::*; pub use parts_write_adapter::CoreWriteAsPartsWrite; + pub use parts_write_adapter::...
2
87
0
35ef70733dc638d659f53e4379ee8fd347204d48
Robert Bastian
2024-08-06T15:40:02
Attribute filtering during export (#5320) #3632
diff --git a/components/collator/src/provider.rs b/components/collator/src/provider.rs index d394bebba7..506811cbcb 100644 --- a/components/collator/src/provider.rs +++ b/components/collator/src/provider.rs @@ -119,6 +119,7 @@ fn data_ce_to_primary(data_ce: u64, c: char) -> u32 { "collator/data@1", // TODO(#3...
10
119
75
cb02882bc5241490db66346b91909abc8af5fb15
Robert Bastian
2024-07-31T20:52:42
Simplify locale parser (#5313) This keeps track of slices instead of indices during parsing, and also simplifies the parser, which removes some checks that were done redundantly before, which should improve performance.
diff --git a/components/locale_core/src/parser/mod.rs b/components/locale_core/src/parser/mod.rs index 367ac05791..f9c60d6856 100644 --- a/components/locale_core/src/parser/mod.rs +++ b/components/locale_core/src/parser/mod.rs @@ -17,40 +17,19 @@ pub use locale::{ parse_locale, parse_locale_with_single_variant_sin...
1
47
90
f6237e91f3bb252d88e69fd84b9bdee7d4137bce
Kart
2024-07-31T11:32:27
DurationFormatter: Duration Formatter Digital Implementation (#5263)
diff --git a/components/experimental/src/duration/duration.rs b/components/experimental/src/duration/duration.rs index a5309d9c9d..b903f1592a 100644 --- a/components/experimental/src/duration/duration.rs +++ b/components/experimental/src/duration/duration.rs @@ -43,6 +43,24 @@ pub struct Duration { pub nanoseconds...
6
637
53
5a176c1b4ae4748fc8f0c2f6632e6b98502fb7df
Kart
2024-07-31T01:08:09
fix: `pad_end` function does not accept the 0 position (#5319)
diff --git a/utils/fixed_decimal/src/decimal.rs b/utils/fixed_decimal/src/decimal.rs index 13621450e6..7e29f9d6ee 100644 --- a/utils/fixed_decimal/src/decimal.rs +++ b/utils/fixed_decimal/src/decimal.rs @@ -1117,7 +1117,7 @@ impl FixedDecimal { self } - /// Pads this number with trailing zeros on a p...
1
6
7
aff4632b296d59c9b1ecaa7f747424708153049d
Robert Bastian
2024-07-30T12:47:03
Remove `_manual_slice` constructors (#5312) We added these because range slicing `&foo[x..y]` is not available in const. However, it can be worked around with `slice::split_at`/`slice::split_at_checked`/`slice::split_at_unchecked`. Removing this simplifies our API surface as well as the implementation.
diff --git a/components/locale_core/src/extensions/mod.rs b/components/locale_core/src/extensions/mod.rs index 57221d86ef..ef99e1365d 100644 --- a/components/locale_core/src/extensions/mod.rs +++ b/components/locale_core/src/extensions/mod.rs @@ -96,16 +96,12 @@ impl ExtensionType { } } - pub(crate) ...
8
58
109
a3f4255ec932e61451de36dc18db65bf7d041914
Blayne Marjama
2024-07-29T16:20:31
feat: currency formatter now uses the fixedDecimalFormatter (#5315)
diff --git a/components/experimental/src/dimension/currency/format.rs b/components/experimental/src/dimension/currency/format.rs index aa96c24525..9d73946373 100644 --- a/components/experimental/src/dimension/currency/format.rs +++ b/components/experimental/src/dimension/currency/format.rs @@ -4,6 +4,7 @@ use fixed_...
2
47
23
724131e3ae67d048319556466aa1ded7081e4b9e
Shane F. Carr
2024-07-26T21:25:46
Add EraDisplay to neo serde (#5314) Fixes main CI
diff --git a/components/datetime/src/neo_serde.rs b/components/datetime/src/neo_serde.rs index 59bfaaec57..4ac5edf0ef 100644 --- a/components/datetime/src/neo_serde.rs +++ b/components/datetime/src/neo_serde.rs @@ -5,7 +5,7 @@ //! Serde definitions for semantic skeleta use crate::neo_skeleton::{ - NeoComponents,...
1
7
2
33e758cf9bf563c49c99ec6d82715d7cce92052a
Shane F. Carr
2024-07-26T00:47:21
Improve neo marker docs (#5247)
diff --git a/components/datetime/src/neo_marker.rs b/components/datetime/src/neo_marker.rs index 6c4c2276b0..19218b6a3d 100644 --- a/components/datetime/src/neo_marker.rs +++ b/components/datetime/src/neo_marker.rs @@ -1187,7 +1187,7 @@ macro_rules! impl_date_marker { input_day_of_year = $day_of_year_yesno:ide...
1
18
18
77632d849fc87362dd3480e272d6958f9411dda2
Shane F. Carr
2024-07-25T15:50:35
Add docs explaining Ord on Locale (#5296) See #1215 and #5295
diff --git a/components/locale_core/src/langid.rs b/components/locale_core/src/langid.rs index 022657ac21..be41a39b96 100644 --- a/components/locale_core/src/langid.rs +++ b/components/locale_core/src/langid.rs @@ -15,8 +15,36 @@ use writeable::Writeable; /// A core struct representing a [`Unicode BCP47 Language Ide...
2
121
38
f5dc8dece93980ac0417fdab984b2b7f1082e6e0
Shane F. Carr
2024-07-25T15:32:36
Make NeoComponents zone combos more consistent (#5294)
diff --git a/components/datetime/src/neo_marker.rs b/components/datetime/src/neo_marker.rs index 5d6eb25b6f..6c4c2276b0 100644 --- a/components/datetime/src/neo_marker.rs +++ b/components/datetime/src/neo_marker.rs @@ -976,10 +976,8 @@ where T: HasConstTimeComponents, Z: HasConstZoneComponent, { - const C...
3
17
24
1544cbe0b47843c5d14675c7a972834dfde46f66
Shane F. Carr
2024-07-19T21:40:03
Migrate some tests to neo formatter (#5246)
diff --git a/components/datetime/src/neo_marker.rs b/components/datetime/src/neo_marker.rs index 8e705f8f84..5d6eb25b6f 100644 --- a/components/datetime/src/neo_marker.rs +++ b/components/datetime/src/neo_marker.rs @@ -3,6 +3,75 @@ // (online at: https://github.com/unicode-org/icu4x/blob/main/LICENSE ). //! Tempora...
2
69
118
0704266dd82b60f178efaa9793081b57e45a07de
Shane F. Carr
2024-07-19T19:56:05
Add NeoOptions with trait integration (#5248)
diff --git a/components/datetime/benches/datetime.rs b/components/datetime/benches/datetime.rs index d4786dd67f..ed81d89aa9 100644 --- a/components/datetime/benches/datetime.rs +++ b/components/datetime/benches/datetime.rs @@ -130,7 +130,7 @@ fn datetime_benches(c: &mut Criterion) { TypedNe...
9
233
110
e3087537d57d7c87b39af28bc9cdf3dfdd6249e3
Kart
2024-07-18T12:22:54
DurationFormatter: validated_options: add documentation to DurationFormatterOptionsError (#5210)
diff --git a/components/experimental/src/duration/formatter/validated_options.rs b/components/experimental/src/duration/formatter/validated_options.rs index 91ae5dcc14..c37c792308 100644 --- a/components/experimental/src/duration/formatter/validated_options.rs +++ b/components/experimental/src/duration/formatter/valida...
1
14
5
14e86d30275cd41e1bb6405bcc7963e2bdf8edb5
Shane F. Carr
2024-07-17T21:51:41
Add Serde and other impls to neo structs (#5258)
diff --git a/components/datetime/src/neo_skeleton.rs b/components/datetime/src/neo_skeleton.rs index b63676bc72..fa27a24826 100644 --- a/components/datetime/src/neo_skeleton.rs +++ b/components/datetime/src/neo_skeleton.rs @@ -17,7 +17,8 @@ use icu_provider::DataMarkerAttributes; /// [`crate::options::length::Date`], ...
1
15
6
8fdbf68ccdf09e4d1e06e2015c2ca1ea473b93c0
Shane F. Carr
2024-07-17T21:31:36
Remove partial support for quarters and leave TODO referencing #501 (#5257)
diff --git a/components/datetime/src/neo_skeleton.rs b/components/datetime/src/neo_skeleton.rs index 687b955c28..b63676bc72 100644 --- a/components/datetime/src/neo_skeleton.rs +++ b/components/datetime/src/neo_skeleton.rs @@ -71,7 +71,7 @@ impl NeoSkeletonLength { } /// A specification for a set of parts of a date...
2
3
25
33bbe03db4d20cb1f35b2e1ce905c0e91bc8d39e
José Julián Espina
2024-07-15T22:42:49
Improve `FixedDecimal` documentation (#5242) Closes #2902.
diff --git a/utils/fixed_decimal/src/decimal.rs b/utils/fixed_decimal/src/decimal.rs index 7e37e84997..13621450e6 100644 --- a/utils/fixed_decimal/src/decimal.rs +++ b/utils/fixed_decimal/src/decimal.rs @@ -36,13 +36,11 @@ compile_error!("The fixed_decimal crate only works if usizes are at least the si /// /// - Inte...
1
95
59
1d857cfa5839ef50a5498586d567c3be5eb386fa
Younies Mahmoud
2024-07-12T21:40:24
Update units formatter to fallback to `Count::Other` pattern if the pattern is not found. (#5237)
diff --git a/components/experimental/src/dimension/units/format.rs b/components/experimental/src/dimension/units/format.rs index a2e122bae7..8a54a321c0 100644 --- a/components/experimental/src/dimension/units/format.rs +++ b/components/experimental/src/dimension/units/format.rs @@ -39,6 +39,17 @@ impl<'l> Writeable for...
1
21
0
74c773b7014bdb8f44d7726fff692003dd875954
Younies Mahmoud
2024-07-12T09:34:00
Improve units format tests (#5234)
diff --git a/components/experimental/src/dimension/units/format.rs b/components/experimental/src/dimension/units/format.rs index c6b35409a2..a2e122bae7 100644 --- a/components/experimental/src/dimension/units/format.rs +++ b/components/experimental/src/dimension/units/format.rs @@ -65,14 +65,14 @@ fn test_basic() { ...
1
5
5
16c63847580256e42c51c35e6f8d5ece0dd3bafe
Younies Mahmoud
2024-07-11T22:04:23
Use `assert_writable_eq` in units formatting test cases (#5229)
diff --git a/components/experimental/src/dimension/units/format.rs b/components/experimental/src/dimension/units/format.rs index 20a01f201e..c6b35409a2 100644 --- a/components/experimental/src/dimension/units/format.rs +++ b/components/experimental/src/dimension/units/format.rs @@ -11,7 +11,7 @@ use fixed_decimal::Fixe...
1
46
37
747b31a0a0a8d79748ca0a1724564eacc41333ef
Robert Bastian
2024-07-11T16:35:23
Improve examples (#5224) This gets rid of some allocations (like vecs), which we don't want to affect the memory benchmarks.
diff --git a/components/calendar/examples/iso_date_manipulations.rs b/components/calendar/examples/iso_date_manipulations.rs index f4f8e94883..5b5f1d39d9 100644 --- a/components/calendar/examples/iso_date_manipulations.rs +++ b/components/calendar/examples/iso_date_manipulations.rs @@ -9,7 +9,7 @@ icu_benchmark_macros...
8
78
166
997f26f7eefffacc72db63dda34050b487ca259b
Robert Bastian
2024-07-11T09:00:42
Reduce examples benchmark boilerplate (#5220) This makes our examples easier to read.
diff --git a/components/calendar/examples/iso_date_manipulations.rs b/components/calendar/examples/iso_date_manipulations.rs index 4709485a73..f4f8e94883 100644 --- a/components/calendar/examples/iso_date_manipulations.rs +++ b/components/calendar/examples/iso_date_manipulations.rs @@ -6,10 +6,10 @@ // from a log into...
22
178
302
05769e3f3c9e669f33243fa3a4630b745363d448
Shane F. Carr
2024-07-10T17:33:02
Fix warnings when building with all-targets, no-default-features (#5212)
diff --git a/components/casemap/benches/casemap.rs b/components/casemap/benches/casemap.rs index b184578afd..cfe97e5bb1 100644 --- a/components/casemap/benches/casemap.rs +++ b/components/casemap/benches/casemap.rs @@ -5,6 +5,7 @@ use criterion::{black_box, criterion_group, criterion_main, Criterion}; use icu_casemap...
6
15
3
9b911e108e26d420d630912cc0af2f3fe1893160
Henri Sivonen
2024-07-10T11:02:35
Tests for is_normalized_utf16_up_to (#5216)
diff --git a/components/normalizer/tests/tests.rs b/components/normalizer/tests/tests.rs index 6544a55102..8f1153a182 100644 --- a/components/normalizer/tests/tests.rs +++ b/components/normalizer/tests/tests.rs @@ -1618,7 +1618,36 @@ fn test_is_normalized_up_to() { assert!(nfkc.is_normalized(&normalized)); ...
1
90
1
620242ebf5d6a083924c714ae7937bd22828b33c
Shane F. Carr
2024-07-09T23:10:52
Disable default features on metacrate in icu_provider_source (#5205)
diff --git a/provider/source/Cargo.toml b/provider/source/Cargo.toml index d5fb4ad592..8f64fb31cd 100644 --- a/provider/source/Cargo.toml +++ b/provider/source/Cargo.toml @@ -32,7 +32,7 @@ all-features = true [dependencies] # ICU components -icu = { workspace = true, default-features = false, features = ["datagen"]...
1
2
2
81884c3a5e21d693ce079f6967066436adf23900
Manish Goregaokar
2024-07-08T17:43:28
Update zerovec on main with the right versions (#5198)
diff --git a/Cargo.lock b/Cargo.lock index 1f1a743196..24e76a10a0 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -3295,7 +3295,7 @@ dependencies = [ [[package]] name = "zerovec" -version = "0.10.2" +version = "0.10.4" dependencies = [ "bincode", "criterion", @@ -3318,7 +3318,7 @@ dependencies = [ [[package]] ...
3
4
4
451aff8f4f761fab76c205754d1ea46f90c41921
Robert Bastian
2024-07-08T15:07:45
Remove unused cargo dependencies (#5189)
diff --git a/Cargo.lock b/Cargo.lock index 181ecf29c8..1f1a743196 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -222,7 +222,6 @@ dependencies = [ name = "bies" version = "0.2.2" dependencies = [ - "criterion", "itertools", "partial-min-max", "rand", @@ -1050,7 +1049,6 @@ version = "0.3.8" dependencies = [ "ic...
4
0
9
a6529b89a25af9a58c0a2ca761f0c9180d5b3d40
Kart
2024-07-08T14:29:50
Create `DigitalDurationDataV1` (#5186)
diff --git a/components/experimental/src/duration/mod.rs b/components/experimental/src/duration/mod.rs index 57ec74e619..ec21ea1a71 100644 --- a/components/experimental/src/duration/mod.rs +++ b/components/experimental/src/duration/mod.rs @@ -8,6 +8,8 @@ mod duration; mod formatter; +pub mod provider; + pub mod op...
4
97
0
b98c33707ca3fe3276358978e0599ea8a60d627d
Kart
2024-07-06T02:14:00
Validation Duration Options and Duration Formatter Stub (#5112)
diff --git a/components/experimental/src/duration/formatter/mod.rs b/components/experimental/src/duration/formatter/mod.rs new file mode 100644 index 0000000000..44f175ca3b --- /dev/null +++ b/components/experimental/src/duration/formatter/mod.rs @@ -0,0 +1,25 @@ +// This file is part of ICU4X. For terms of use, please...
4
497
47
633aeb8697311502a2b4f463e34a5e3b8fba50b7
Robert Bastian
2024-07-05T18:03:51
Fix bench (#5184)
diff --git a/components/icu/examples/tui.rs b/components/icu/examples/tui.rs index f0fe97669a..637b1a054b 100644 --- a/components/icu/examples/tui.rs +++ b/components/icu/examples/tui.rs @@ -18,7 +18,7 @@ use std::env; #[cfg(not(debug_assertions))] macro_rules! println { - ($($arg:tt)*) => {}; + ($($arg:tt)*)...
1
1
1
1d63545eedf66ce5b544306bccc1ae8a12badc13
Robert Bastian
2024-07-04T14:05:11
`DataMarkerAttributes::try_from_utf8` should not call `try_from_str`. (#5180)
diff --git a/provider/core/src/request.rs b/provider/core/src/request.rs index bd39f928bc..30bf576033 100644 --- a/provider/core/src/request.rs +++ b/provider/core/src/request.rs @@ -759,11 +759,11 @@ impl Debug for DataMarkerAttributes { pub struct AttributeParseError; impl DataMarkerAttributes { - const fn val...
1
15
13
b3006b22c2e5bd6c142b9a221b5ecc0ad0895d1e
Robert Bastian
2024-07-04T10:00:48
`DryDataProvider` (#5141) #58
diff --git a/provider/adapters/src/either.rs b/provider/adapters/src/either.rs index 990a54891c..437df0870a 100644 --- a/provider/adapters/src/either.rs +++ b/provider/adapters/src/either.rs @@ -47,6 +47,23 @@ impl<M: DynamicDataMarker, P0: DynamicDataProvider<M>, P1: DynamicDataProvider<M } } +impl<M: DynamicD...
11
374
50
c7c1a414f1b7a5f2729f9837afb0b095064fc65f
Younies Mahmoud
2024-07-03T22:59:05
Implement `DataMarkerAttributes::try_from_utf8` (#5174)
diff --git a/provider/core/src/request.rs b/provider/core/src/request.rs index ca69a08c65..5a50caa44c 100644 --- a/provider/core/src/request.rs +++ b/provider/core/src/request.rs @@ -768,6 +768,26 @@ impl DataMarkerAttributes { Ok(unsafe { &*(s as *const str as *const Self) }) } + /// Attempts to cre...
1
36
0