commit_hash
stringlengths
40
40
author
stringlengths
1
57
date
timestamp[s]date
2010-07-26 04:45:09
2026-04-14 18:21:10
message
stringlengths
8
1.39M
diff
stringlengths
68
51.2k
files_changed
int64
1
136
insertions
int64
0
2.35k
deletions
int64
0
1.9k
30de31af64d5e3ef79b82ecd2e15e641bffd5011
Robert Bastian
2025-01-21T19:03:18
Add caches to timezone datagen (#6023) These are needed for future PRs.
diff --git a/provider/source/src/cldr_cache.rs b/provider/source/src/cldr_cache.rs index 4529cdef1d..a332f1ee1c 100644 --- a/provider/source/src/cldr_cache.rs +++ b/provider/source/src/cldr_cache.rs @@ -34,6 +34,7 @@ pub(crate) struct CldrCache { pub(crate) transforms: OnceLock< Result<std::sync::Mutex<ic...
5
425
356
beaca4db53fc4fb22aff2d3103d37444c0a0b6cd
Robert Bastian
2025-01-21T16:42:36
Restrict Time to ISO-8601 range, remove arithmetic (#6002) Fixes #5987
diff --git a/components/timezone/src/types.rs b/components/timezone/src/types.rs index 34828b4d13..48b50977e0 100644 --- a/components/timezone/src/types.rs +++ b/components/timezone/src/types.rs @@ -11,8 +11,8 @@ use icu_calendar::{AsCalendar, Date, RangeError}; /// here will return a Result on whether or not the unit...
1
27
169
9fc2b42247c510383ffa9a85ffc2178995444698
Manish Goregaokar
2025-01-20T23:12:22
Audit sealed traits, take 2 (#6015) Fixes #4338 This: - Adds a doc header to all sealed traits - Adds a (different) doc header to all UnstableSealed traits - Ensures all sealed traits have hidden methods - Seals the segmenter type traits since they're implementing a "compile time enum" pattern - Audits the rest o...
diff --git a/components/casemap/src/set.rs b/components/casemap/src/set.rs index 34d5b33276..fd7478c435 100644 --- a/components/casemap/src/set.rs +++ b/components/casemap/src/set.rs @@ -12,6 +12,9 @@ use icu_collections::codepointinvlist::CodePointInversionListBuilder; /// will be some kind of set over codepoints and...
18
169
6
830b0109a112623223c21005d01c6c586d998ec5
Robert Bastian
2025-01-20T17:36:03
Remove "yuko" special case (#6017) Fixes #1781
diff --git a/provider/source/src/time_zones/mod.rs b/provider/source/src/time_zones/mod.rs index 8199b8827e..fc070d3ed6 100644 --- a/provider/source/src/time_zones/mod.rs +++ b/provider/source/src/time_zones/mod.rs @@ -11,7 +11,6 @@ use icu_locale_core::subtags::Region; use icu_provider::prelude::*; use std::collecti...
1
0
3
c5af2444473323741610738079f70939d705ebd0
Robert Bastian
2025-01-20T16:16:33
`Date::wrap_calendar_in_ref` (#6016) Fixes #5859
diff --git a/components/calendar/src/any_calendar.rs b/components/calendar/src/any_calendar.rs index 7c38e13650..8c5de7dc11 100644 --- a/components/calendar/src/any_calendar.rs +++ b/components/calendar/src/any_calendar.rs @@ -123,7 +123,7 @@ pub enum AnyCalendar { // TODO(#3469): Decide on the best way to implement...
9
51
129
584bfd1463e3de2be93aa0552252e8a7e51bc3ac
José Julián Espina
2025-01-15T19:02:30
Expand size of duration records to support ECMA402 (#5996) This updates `IsoDurationParser` to support parsing at least the maximum representable duration in the Temporal proposal
diff --git a/utils/ixdtf/src/parsers/duration.rs b/utils/ixdtf/src/parsers/duration.rs index 0e228f0aeb..e87f2b501f 100644 --- a/utils/ixdtf/src/parsers/duration.rs +++ b/utils/ixdtf/src/parsers/duration.rs @@ -65,14 +65,14 @@ pub(crate) fn parse_date_duration(cursor: &mut Cursor) -> ParserResult<DateDurat let mut...
3
51
16
685ffbb014e3e7b28811380c4f986dac58363f26
Kevin Ness
2025-01-15T18:44:04
Bug fix for subsecond part in `ixdtf` (#6004) Boa / `temporal_rs` had a subtraction overflow panic when running the test262 suite in debug. This PR addressed the bug and adds some unit tests for it. Confirmed that it is correct when plugged into Boa and rerun through the Temporal test suite.
diff --git a/utils/ixdtf/src/parsers/tests.rs b/utils/ixdtf/src/parsers/tests.rs index 5a01c9b655..7b6f77921a 100644 --- a/utils/ixdtf/src/parsers/tests.rs +++ b/utils/ixdtf/src/parsers/tests.rs @@ -975,3 +975,77 @@ fn test_zulu_offset() { }) ); } + +// Examples referenced from +#[test] +fn subsecond_str...
2
75
1
0959d995cf4a1709703948330ba6f442de088aac
Robert Bastian
2025-01-15T13:09:06
Add `jiff` example (#5997) This is the 2.0 version of https://docs.rs/jiff/latest/jiff/_documentation/comparison/index.html#icu-v150
diff --git a/Cargo.lock b/Cargo.lock index bdb5c09643..80aa90f84d 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -958,6 +958,7 @@ dependencies = [ "icu_provider_registry", "icu_segmenter", "icu_timezone", + "jiff", "memchr", "writeable", ] @@ -1792,6 +1793,35 @@ dependencies = [ "utf8_iter", ] +[[package]]...
4
133
3
5b8e8c0d5cd293f866c2520b37585065bd49b91d
Shane F. Carr
2025-01-15T09:00:16
IXDTF parsers: Improve docs and add PartialEq (#5993) #5739 This is mostly docs. The only non-docs is adding PartialEq bounds, including to DateTime and ZonedDateTime, which became reachable via one of my new docs tests. I think adding PartialEq to DateTime is not in contradiction to the thin DateTime effort.
diff --git a/components/calendar/src/ixdtf.rs b/components/calendar/src/ixdtf.rs index a99d26e1b3..8820a66cc7 100644 --- a/components/calendar/src/ixdtf.rs +++ b/components/calendar/src/ixdtf.rs @@ -60,6 +60,9 @@ impl Date<Iso> { /// icu::calendar::types::MonthCode(tinystr::tinystr!(4, "M07")) /// ); ...
4
53
23
7b823de4bde0b93bbc1a180c56d93ec9dbb2fc06
Manish Goregaokar
2025-01-15T00:57:48
Use correct day of year for Japanese (#5992) Fixes #5655
diff --git a/components/calendar/src/japanese.rs b/components/calendar/src/japanese.rs index 2343e38da6..a0c7e396cd 100644 --- a/components/calendar/src/japanese.rs +++ b/components/calendar/src/japanese.rs @@ -286,7 +286,7 @@ impl Calendar for Japanese { let prev_dec_31 = self.date_from_iso(Date::from_raw(pre...
1
1
1
c955e4a9bc17f1d7c61891371c0f40807d372b23
Manish Goregaokar
2025-01-14T06:58:19
Audit exhaustiveness of icu_calendar::types (#5978)
diff --git a/components/calendar/src/types.rs b/components/calendar/src/types.rs index b27e9f4329..373aa33fa5 100644 --- a/components/calendar/src/types.rs +++ b/components/calendar/src/types.rs @@ -316,7 +316,7 @@ impl fmt::Display for MonthCode { /// Representation of a formattable month. #[derive(Copy, Clone, De...
1
4
4
17384ebf1a539ccaa0261986692f63735b0453f8
Manish Goregaokar
2025-01-14T00:52:17
Audit self by-copy vs by-ref on Borrowed types (#5977) Fixes https://github.com/unicode-org/icu4x/issues/5921 We should also land https://github.com/unicode-org/icu4x/pull/5975 <!-- Thank you for your pull request to ICU4X! Reminder: try to use [Conventional Comments](https://conventionalcomments.org/)...
diff --git a/components/datetime/src/provider/pattern/runtime/pattern.rs b/components/datetime/src/provider/pattern/runtime/pattern.rs index 6d7487bc01..aa3a817873 100644 --- a/components/datetime/src/provider/pattern/runtime/pattern.rs +++ b/components/datetime/src/provider/pattern/runtime/pattern.rs @@ -143,7 +143,7 ...
8
37
41
d43d5d5f4f22048a8ba0c4fa4875a751764c4b8d
Manish Goregaokar
2025-01-10T14:31:37
Remove unnecessary verbosity in error docs/Display (#5972)
diff --git a/components/experimental/src/duration/validated_options.rs b/components/experimental/src/duration/validated_options.rs index 3c0438147d..8ac49694d3 100644 --- a/components/experimental/src/duration/validated_options.rs +++ b/components/experimental/src/duration/validated_options.rs @@ -63,21 +63,23 @@ pub s...
2
23
27
e8df60b95733f4293ce837eb448b30510f0e357b
Manish Goregaokar
2025-01-10T00:05:48
Fix timezone naming convention in env_preferences (#5954) As decided in https://github.com/unicode-org/icu4x/issues/4350 <!-- Thank you for your pull request to ICU4X! Reminder: try to use [Conventional Comments](https://conventionalcomments.org/) to make comments clearer. Please see https://github.com/u...
diff --git a/utils/env_preferences/src/apple.rs b/utils/env_preferences/src/apple.rs index c3df73586c..838939f883 100644 --- a/utils/env_preferences/src/apple.rs +++ b/utils/env_preferences/src/apple.rs @@ -152,7 +152,7 @@ pub fn get_system_calendars() -> Result<Vec<(String, String)>, RetrievalError> { } /// Get th...
3
6
6
2ea039e9558e1001dedb8030094f45bc0deb3db1
Manish Goregaokar
2025-01-09T19:56:14
Implement display on all error types (#5969) Fixes #5930 <!-- Thank you for your pull request to ICU4X! Reminder: try to use [Conventional Comments](https://conventionalcomments.org/) to make comments clearer. Please see https://github.com/unicode-org/icu4x/blob/main/CONTRIBUTING.md for general informa...
diff --git a/components/calendar/src/ixdtf.rs b/components/calendar/src/ixdtf.rs index bb00d8768d..5a94d40c4d 100644 --- a/components/calendar/src/ixdtf.rs +++ b/components/calendar/src/ixdtf.rs @@ -10,12 +10,14 @@ use ixdtf::parsers::IxdtfParser; use ixdtf::ParseError as IxdtfError; /// An error returned from pars...
6
48
11
3f7a6380c8acd70087e6bb153c380537cf40e286
Robert Bastian
2025-01-09T17:15:09
Remove keywords from `DataLocale` (#5967)
diff --git a/provider/core/src/request.rs b/provider/core/src/request.rs index cad4ca8cfe..6d21685a52 100644 --- a/provider/core/src/request.rs +++ b/provider/core/src/request.rs @@ -247,7 +247,8 @@ impl Default for DataIdentifierCow<'_> { /// DataLocale::from(locale!("hi-IN-u-sd-inas")) /// ); /// ``` -#[derive...
1
10
61
ab5fab7c774a025e415a8c09df288f37787cf18f
Manish Goregaokar
2025-01-09T07:51:46
Add attributes_domain to DecimalDigitsV1 (#5962) Fixes #5824 <!-- Thank you for your pull request to ICU4X! Reminder: try to use [Conventional Comments](https://conventionalcomments.org/) to make comments clearer. Please see https://github.com/unicode-org/icu4x/blob/main/CONTRIBUTING.md for general information on...
diff --git a/components/decimal/src/provider.rs b/components/decimal/src/provider.rs index 605ada2156..3e6c10a684 100644 --- a/components/decimal/src/provider.rs +++ b/components/decimal/src/provider.rs @@ -229,7 +229,11 @@ pub struct DecimalSymbolsV2<'data> { /// including in SemVer minor releases. While the serde re...
1
5
1
ff90048e7805402a38b8ad0a8292c3fbf7b7d298
José Julián Espina
2025-01-07T16:26:39
Add missing `DryDataProvider` implementations (#5951) Makes it a bit easier to work with `&DryDataProvider`, `&DynamicDryDataProvider` and friends.
diff --git a/provider/core/src/data_provider.rs b/provider/core/src/data_provider.rs index 2f5a4cd75c..9e265820b5 100644 --- a/provider/core/src/data_provider.rs +++ b/provider/core/src/data_provider.rs @@ -53,15 +53,6 @@ where } } -/// A [`DataProvider`] that can iterate over all supported [`DataIdentifierCow`...
1
132
26
e80181330be0d92d4b65926c78bf2b3a9474a6d3
Shane F. Carr
2024-12-24T23:46:17
Fix nightly datetime tests (#5946)
diff --git a/components/datetime/src/fieldsets.rs b/components/datetime/src/fieldsets.rs index 9eb115fd80..4758d33c4d 100644 --- a/components/datetime/src/fieldsets.rs +++ b/components/datetime/src/fieldsets.rs @@ -1284,7 +1284,7 @@ impl_zone_marker!( /// /// let formatter = FixedCalendarDateTimeFormatter::tr...
1
5
5
07b40a170b8647fdee11527664edd3762000dcab
Shane F. Carr
2024-12-19T22:24:52
Add default type for VarZeroSliceIter (#5933)
diff --git a/utils/zerovec/src/varzerovec/components.rs b/utils/zerovec/src/varzerovec/components.rs index 618b64f5b3..8cb28fb25f 100644 --- a/utils/zerovec/src/varzerovec/components.rs +++ b/utils/zerovec/src/varzerovec/components.rs @@ -503,7 +503,7 @@ impl<'a, T: VarULE + ?Sized, F: VarZeroVecFormat> VarZeroVecCompo...
1
1
1
3e2252866ff0a64499acd85b1143b341770e56bc
Manish Goregaokar
2024-12-19T16:12:42
Make utf16_iter/utf8_iter deps optional in normalizer (#5927) Fixes #4988 <!-- Thank you for your pull request to ICU4X! Reminder: try to use [Conventional Comments](https://conventionalcomments.org/) to make comments clearer. Please see https://github.com/unicode-org/icu4x/blob/main/CONTRIBUTING.md for ...
diff --git a/components/normalizer/Cargo.toml b/components/normalizer/Cargo.toml index 028ef19a95..c037959a84 100644 --- a/components/normalizer/Cargo.toml +++ b/components/normalizer/Cargo.toml @@ -25,9 +25,9 @@ icu_collections = { workspace = true } icu_properties = { workspace = true, optional = true } icu_provide...
4
60
17
3d25e72b0e61a80d3f13aaca189bbc4665859138
Shane F. Carr
2024-12-19T03:36:03
More docs on PlaceholderValueProvider (#5910) Follow-up to #5908
diff --git a/components/pattern/src/common.rs b/components/pattern/src/common.rs index 27790035b6..89f11a9375 100644 --- a/components/pattern/src/common.rs +++ b/components/pattern/src/common.rs @@ -204,10 +204,18 @@ pub trait PatternBackend: crate::private::Sealed + 'static + core::fmt::Debug { pub trait PlaceholderV...
1
8
0
99f34fe926b312a45de9012d1c315a86ed8f29c7
Shane F. Carr
2024-12-19T03:35:40
DateTime + Decimal Parts Formatting (#5898) We need this in order to support fractional second digits in #5845 Depends on #5896 Depends on #5897
diff --git a/components/datetime/src/format/datetime.rs b/components/datetime/src/format/datetime.rs index fd377a20a0..bb2547f1f6 100644 --- a/components/datetime/src/format/datetime.rs +++ b/components/datetime/src/format/datetime.rs @@ -30,11 +30,11 @@ where num.pad_start(length.to_len() as i16); if let S...
3
56
39
9b2632f79701276cc48801df3f433c100528e28e
Shane F. Carr
2024-12-19T02:59:23
Export preferences types from icu_experimental (#5912)
diff --git a/components/datetime/src/neo.rs b/components/datetime/src/neo.rs index 9b06d7e223..68525609d2 100644 --- a/components/datetime/src/neo.rs +++ b/components/datetime/src/neo.rs @@ -56,11 +56,17 @@ define_preferences!( [Copy] DateTimeFormatterPreferences, { - /// The user's preferred numb...
12
33
5
263ff0acca6989a595872e101a21a72f94a03561
Shane F. Carr
2024-12-19T02:59:01
Refactoring and tests for dateSkeleton semantic pattern generation (#5826) Research and preliminary work for #5806 (https://unicode-org.atlassian.net/browse/CLDR-14993)
diff --git a/components/datetime/src/fields/components.rs b/components/datetime/src/fields/components.rs index b9353dc53e..acbbf321b6 100644 --- a/components/datetime/src/fields/components.rs +++ b/components/datetime/src/fields/components.rs @@ -32,7 +32,7 @@ use crate::{ fields::{self, Field, FieldLength, Field...
9
376
48
2a257ef413963730d36f8520ec3a1dcd1d674d86
Shane F. Carr
2024-12-19T00:20:47
Add "Reading" message to download-repo-sources (#5923) For help with debugging.
diff --git a/tools/make/download-repo-sources/src/main.rs b/tools/make/download-repo-sources/src/main.rs index fdb50eb62b..b109cf6b88 100644 --- a/tools/make/download-repo-sources/src/main.rs +++ b/tools/make/download-repo-sources/src/main.rs @@ -71,6 +71,8 @@ fn main() -> eyre::Result<()> { )?; }...
1
2
0
a4f6747e0f76cfc30c6889c9dfa3ab1bb7195fd6
Manish Goregaokar
2024-12-18T23:38:58
Add VarZeroSliceIter, ZeroSliceIter (#5924)
diff --git a/utils/zerovec/src/lib.rs b/utils/zerovec/src/lib.rs index eabf1144c8..2d8c34fdf1 100644 --- a/utils/zerovec/src/lib.rs +++ b/utils/zerovec/src/lib.rs @@ -289,10 +289,14 @@ pub mod vecs { #[doc(no_inline)] pub use crate::zerovec::{ZeroSlice, ZeroVec}; + pub use crate::zerovec::ZeroSliceIter; ...
6
110
31
370ade0de291eeb8c3c4deebe93f6eb4c1a02f0b
Shane F. Carr
2024-12-18T22:45:51
Remove dead data struct IanaToBcp47MapV1 (#5920)
diff --git a/components/timezone/src/provider/names.rs b/components/timezone/src/provider/names.rs index 07e771e499..db260cda06 100644 --- a/components/timezone/src/provider/names.rs +++ b/components/timezone/src/provider/names.rs @@ -14,42 +14,9 @@ use crate::TimeZoneBcp47Id; use icu_provider::prelude::*; -use zer...
2
5
83
64f5322764f9965641978ca563e0d0b9c39b640f
Henri Sivonen
2024-12-18T18:00:31
Return Cow instead of String/Vec in the normalizer (#5906)
diff --git a/components/casemap/tests/conversions.rs b/components/casemap/tests/conversions.rs index 7515973151..285cdfb27a 100644 --- a/components/casemap/tests/conversions.rs +++ b/components/casemap/tests/conversions.rs @@ -354,11 +354,11 @@ fn test_greek_upper() { let assert_greek_uppercase = |input: &str, e...
10
69
43
c047d8a5b64e890832ed9631fc4183c84bb07e84
Shane F. Carr
2024-12-18T07:24:22
Add example demonstrating how to get the resolved hour cycle (#5916) Part of #5900
diff --git a/components/datetime/src/neo.rs b/components/datetime/src/neo.rs index 9a1c159965..9b06d7e223 100644 --- a/components/datetime/src/neo.rs +++ b/components/datetime/src/neo.rs @@ -870,6 +870,9 @@ impl_display_with_writeable!(FormattedDateTime<'_>); impl FormattedDateTime<'_> { /// Gets the pattern us...
2
31
0
c26c10c0d2ef355b31d7ca0c7a07345c1f7bc383
Shane F. Carr
2024-12-17T21:27:17
Parts formatting for icu_decimal (#5897)
diff --git a/components/decimal/src/format.rs b/components/decimal/src/format.rs index 967e65a85d..5c5a0d6486 100644 --- a/components/decimal/src/format.rs +++ b/components/decimal/src/format.rs @@ -4,11 +4,16 @@ //! Lower-level types for decimal formatting. +use core::fmt::Write; + use crate::grouper; use crate...
6
148
26
c2af1f0d47f680d98f99aca787e2339cbbd05271
Manish Goregaokar
2024-12-17T21:19:07
Fix rustfmt for nightly/beta (#5911) Unclear if this counts as a breaking change from rustfmt but this should be an easy fix on our side. Fixes beta CI. Nightly CI is also fixed by this, but nightly CI is broken due to other reasons too. <!-- Thank you for your pull request to ICU4X! Reminder: try to use [Conventi...
diff --git a/components/pattern/src/common.rs b/components/pattern/src/common.rs index 951cea986f..27790035b6 100644 --- a/components/pattern/src/common.rs +++ b/components/pattern/src/common.rs @@ -229,11 +229,13 @@ where { type Error = T::Error; - type W<'a> = T::W<'a> + type W<'a> + = T::W<'a> ...
4
28
14
6f10eaaea383d9750137a6a0c2304f7c7ec675b5
Shane F. Carr
2024-12-13T21:55:52
Format to parts in DateTimeFormatter (#5896) Fixes #5845
diff --git a/components/datetime/src/format/datetime.rs b/components/datetime/src/format/datetime.rs index 36164adaf8..fd377a20a0 100644 --- a/components/datetime/src/format/datetime.rs +++ b/components/datetime/src/format/datetime.rs @@ -6,19 +6,44 @@ use super::time_zone::{FormatTimeZone, FormatTimeZoneError, Iso8601...
6
309
89
1e74e77d8c4e470c99f13ac82918ed014ecdfc4e
nerix
2024-12-12T22:04:42
Clarify `iana_to_bcp47` return type in docs (#5889)
diff --git a/components/timezone/src/ids.rs b/components/timezone/src/ids.rs index 2916964b4b..997e64d396 100644 --- a/components/timezone/src/ids.rs +++ b/components/timezone/src/ids.rs @@ -194,7 +194,7 @@ impl TimeZoneIdMapperBorrowed<'_> { /// Gets the BCP-47 time zone ID from an IANA time zone ID /// with...
1
1
1
d2a4937da097bf7c5d77ca2fdfb7a10ba47a0776
nerix
2024-12-12T22:04:32
Add `experimental` to datetime's `bench` features (#5888)
diff --git a/components/datetime/Cargo.toml b/components/datetime/Cargo.toml index 82085f822c..fc81c99596 100644 --- a/components/datetime/Cargo.toml +++ b/components/datetime/Cargo.toml @@ -97,7 +97,7 @@ datagen = [ ] logging = ["icu_calendar/logging"] experimental = ["dep:litemap"] -bench = ["serde", "datagen"] +b...
1
1
1
a26fd3c9e7e4eea32db4cdb6e9d5d0352e4c4758
Arthur Silva
2024-12-12T17:28:49
Add `BTreeMap` like apis to `LiteMap` (#5894) Add BTreeMap-like APIs to LiteMap to get closer to the std lib BTreeMap, which has familiarity benefits and allows easier integration of LiteMap into existing projects. * implement `IntoIter` for `&LiteMap` and `&mut LiteMap` * Deprecate `iter_keys` and `iter_values`...
diff --git a/components/experimental/src/personnames/provided_struct.rs b/components/experimental/src/personnames/provided_struct.rs index ab35678b1f..0ecb42eaa1 100644 --- a/components/experimental/src/personnames/provided_struct.rs +++ b/components/experimental/src/personnames/provided_struct.rs @@ -35,7 +35,7 @@ imp...
4
40
4
08b5298275fac322f33bdf6457d41695bd328713
Shane F. Carr
2024-12-11T21:08:52
Fix transforms datagen to work with both 46.0 and 46.1 (#5891) Split from #5890
diff --git a/provider/source/src/transforms/mod.rs b/provider/source/src/transforms/mod.rs index c5e101eb1c..813b4bc272 100644 --- a/provider/source/src/transforms/mod.rs +++ b/provider/source/src/transforms/mod.rs @@ -74,7 +74,7 @@ impl CldrCache { // I'm not sure why this errors ...
1
1
1
b21d65ae34de88ea4ef55de91becbee22c811d19
Younies Mahmoud
2024-12-11T15:11:41
Implement Short&Narrow Compact Currency Formatter (#5450)
diff --git a/components/experimental/src/dimension/currency/compact_format.rs b/components/experimental/src/dimension/currency/compact_format.rs new file mode 100644 index 0000000000..bf57ca40af --- /dev/null +++ b/components/experimental/src/dimension/currency/compact_format.rs @@ -0,0 +1,162 @@ +// This file is part ...
4
405
0
1823594001e66c27b132150b452c027461ca7ed9
Younies Mahmoud
2024-12-11T15:11:13
Implement Long Compact Currency Formatter (#5456)
diff --git a/components/experimental/src/dimension/currency/long_compact_format.rs b/components/experimental/src/dimension/currency/long_compact_format.rs new file mode 100644 index 0000000000..00096a2c02 --- /dev/null +++ b/components/experimental/src/dimension/currency/long_compact_format.rs @@ -0,0 +1,127 @@ +// Thi...
3
346
0
8717dfc98191fae0f228f63d9d5c337d723ffcad
Shane F. Carr
2024-12-10T19:38:46
Remove icu4x 1.5 from lockfile (#5884) Fixes #5871
diff --git a/Cargo.lock b/Cargo.lock index 7b1c56736e..c23ec65056 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -186,7 +186,7 @@ version = "0.0.0" dependencies = [ "crlify", "icu", - "icu_provider 2.0.0-beta1", + "icu_provider", "icu_provider_export", "icu_provider_source", "log", @@ -227,7 +227,7 @@ dependenc...
1
154
365
9e5a25b88b2bbcb170c6343bd5b67dc96f7d5c1a
Younies Mahmoud
2024-12-09T18:58:07
Breaking: change format_fixed_decimal to accept a reference to `SignedFixedDecimal` (#5882)
diff --git a/components/experimental/src/compactdecimal/formatter.rs b/components/experimental/src/compactdecimal/formatter.rs index 99c8b662e2..08c980a130 100644 --- a/components/experimental/src/compactdecimal/formatter.rs +++ b/components/experimental/src/compactdecimal/formatter.rs @@ -315,7 +315,7 @@ impl CompactD...
1
17
17
e7c271ad2dcc75416d86cdddeb9664db2ba7d97d
Younies Mahmoud
2024-12-03T00:36:01
Refactor: rename variable from `locale` to `currency_preferences` for clarity. (#5878) <!-- Thank you for your pull request to ICU4X! Reminder: try to use [Conventional Comments](https://conventionalcomments.org/) to make comments clearer. Please see https://github.com/unicode-org/icu4x/blob/main/CONTRIBUTING...
diff --git a/components/experimental/src/dimension/currency/long_format.rs b/components/experimental/src/dimension/currency/long_format.rs index 1ad7ce6a50..f7db017927 100644 --- a/components/experimental/src/dimension/currency/long_format.rs +++ b/components/experimental/src/dimension/currency/long_format.rs @@ -50,9 ...
2
8
8
580dec07608be75a8a8130ecee17a6b669bc8b3c
Younies Mahmoud
2024-12-02T23:23:49
Expose CompactDecimalFormatterPreferences in the compactdecimal module (#5877) <!-- Thank you for your pull request to ICU4X! Reminder: try to use [Conventional Comments](https://conventionalcomments.org/) to make comments clearer. Please see https://github.com/unicode-org/icu4x/blob/main/CONTRIBUTING.md for general...
diff --git a/components/experimental/src/compactdecimal/formatter.rs b/components/experimental/src/compactdecimal/formatter.rs index ce5f47ab75..99c8b662e2 100644 --- a/components/experimental/src/compactdecimal/formatter.rs +++ b/components/experimental/src/compactdecimal/formatter.rs @@ -28,6 +28,7 @@ define_preferen...
2
2
0
7a7a89e9525d8219424c711d34441af25ba8b4a9
zhongyi51
2024-11-30T04:41:52
Relax trait bound for `EitherCart` in `Yoke` crate (#5876) The enum `EitherCart` in `Yoke` crate theoretically implements `Deref` and `StableDeref` traits. However, it does not support the dereferenced type `T` being Unsized (like `[u8]`). As a result, types like `EitherCart<Arc<[u8]>, Box<[u8]>>` cause compiler error...
diff --git a/utils/yoke/src/either.rs b/utils/yoke/src/either.rs index 3749e7d83d..7de6edf33f 100644 --- a/utils/yoke/src/either.rs +++ b/utils/yoke/src/either.rs @@ -56,6 +56,7 @@ impl<C0, C1, T> Deref for EitherCart<C0, C1> where C0: Deref<Target = T>, C1: Deref<Target = T>, + T: ?Sized, { type Ta...
1
2
0
b5b45a5b4354f72b5c973bb74335f612e2e93ff6
Paolo Barbolini
2024-11-27T18:44:20
build: improve building with -Zminimal-versions (#5874) This improves building with `-Zminimal-versions` by increasing the minimum allowed version of postcard to the first one that can be used to successfully compile this project.
diff --git a/Cargo.toml b/Cargo.toml index 9e396e483a..864a043f1b 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -249,7 +249,7 @@ memchr = { version = "2.6.0", default-features = false } num-bigint = { version = "0.4.3", default-features = false } num-rational = { version = "0.4.0", default-features = false } num-trait...
1
1
1
9cb01e434ad6af92e77c8046affb1fad2eb54deb
Shane F. Carr
2024-11-23T20:43:30
Touch Cargo.lock
diff --git a/Cargo.lock b/Cargo.lock index 6cb5d97a92..7b1c56736e 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -1160,7 +1160,7 @@ source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "db2fa452206ebee18c4b5c2274dbf1de17008e874b4dc4f0aea9d01ca79e4526" dependencies = [ "displaydoc", - "yoke 0.7.4...
1
17
17
faf472dfe6689efcf7a125b46d47b7a4d57271c6
Shane F. Carr
2024-11-23T20:22:12
icu_codepointtrie_builder: include cpp directory
diff --git a/components/collections/codepointtrie_builder/Cargo.toml b/components/collections/codepointtrie_builder/Cargo.toml index 697d1391ff..5d812113ae 100644 --- a/components/collections/codepointtrie_builder/Cargo.toml +++ b/components/collections/codepointtrie_builder/Cargo.toml @@ -15,7 +15,7 @@ include = [ ...
1
1
1
db77e4254af357bf02d4c621311cdb6ca063d0ef
Shane F. Carr
2024-11-23T20:19:57
icu_codepointtrie_builder 0.4.0
diff --git a/Cargo.lock b/Cargo.lock index 9b2654f90b..6cb5d97a92 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -1111,7 +1111,7 @@ dependencies = [ [[package]] name = "icu_codepointtrie_builder" -version = "0.4.0-dev" +version = "0.4.0" dependencies = [ "icu", "icu_collections 2.0.0-beta1", diff --git a/Cargo.to...
3
4
4
f3b93c6f3fcba9c36176bf0cf14b7a05b740e67a
Shane F. Carr
2024-11-23T02:53:21
Touch Cargo.lock
diff --git a/Cargo.lock b/Cargo.lock index 9c25ecbdf1..9b2654f90b 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -3009,7 +3009,7 @@ checksum = "42ff0bf0c66b8238c6f3b578df37d0b7848e55df8577b3f74f92a69acceeb825" [[package]] name = "tzif" -version = "0.3.0-dev" +version = "0.3.0" dependencies = [ "combine", "walkdir...
1
1
1
279807eb712ec2505a01cbf5a255f090a402051e
Shane F. Carr
2024-11-23T02:11:10
[description] Add description to icu_provider_baked
diff --git a/provider/baked/Cargo.toml b/provider/baked/Cargo.toml index 55d24793aa..c99d89dd40 100644 --- a/provider/baked/Cargo.toml +++ b/provider/baked/Cargo.toml @@ -4,6 +4,7 @@ [package] name = "icu_provider_baked" +description = "Tooling for the ICU4X baked data provider" version.workspace = true rust-ve...
1
1
0
b6e27d9c87c00fa5086df359a536476b436646dd
Shane F. Carr
2024-11-23T02:10:27
[description] Add description to icu_provider_registry
diff --git a/provider/registry/Cargo.toml b/provider/registry/Cargo.toml index d4bac1ec57..66ec92d74a 100644 --- a/provider/registry/Cargo.toml +++ b/provider/registry/Cargo.toml @@ -4,6 +4,7 @@ [package] name = "icu_provider_registry" +description = "A registry of all ICU4X data markers" version.workspace = true ...
1
1
0
0528c185cf994d2a39103b2186e717b17e8356ce
Shane F. Carr
2024-11-23T02:08:27
[dev-deps] Change registry dev deps
diff --git a/provider/registry/Cargo.toml b/provider/registry/Cargo.toml index 0f967c1978..d4bac1ec57 100644 --- a/provider/registry/Cargo.toml +++ b/provider/registry/Cargo.toml @@ -15,5 +15,5 @@ categories.workspace = true include.workspace = true [dev-dependencies] -icu = { workspace = true, features = ["experim...
1
2
2
2a279ccb7233b7b3a6932158955513135853dd35
Shane F. Carr
2024-11-23T02:05:15
[dev-deps] Change locale_core dev deps
diff --git a/components/locale_core/Cargo.toml b/components/locale_core/Cargo.toml index a1f3b9af6d..7b5aa8d441 100644 --- a/components/locale_core/Cargo.toml +++ b/components/locale_core/Cargo.toml @@ -32,7 +32,7 @@ zerovec = { workspace = true, optional = true } [dev-dependencies] iai = { workspace = true } icu = ...
1
1
1
032b9573da26a7de4667e10b0c42f113645f5790
Shane F. Carr
2024-11-23T02:03:55
[dev-deps] Change zerovec dev-deps
diff --git a/utils/potential_utf/Cargo.toml b/utils/potential_utf/Cargo.toml index 36baaf4992..3dd1b5278a 100644 --- a/utils/potential_utf/Cargo.toml +++ b/utils/potential_utf/Cargo.toml @@ -30,4 +30,4 @@ alloc = ["serde?/alloc"] databake = ["dep:databake"] serde = ["dep:serde"] writeable = ["dep:writeable", "alloc"...
2
2
2
f5d8074511c80277382ade0c389c11c768b119a9
Shane F. Carr
2024-11-23T01:20:28
Use workspace deps in potential_utf (#5867) #5635 #5866
diff --git a/utils/potential_utf/Cargo.toml b/utils/potential_utf/Cargo.toml index 06dad94b46..0971500189 100644 --- a/utils/potential_utf/Cargo.toml +++ b/utils/potential_utf/Cargo.toml @@ -21,8 +21,8 @@ zerovec = { workspace = true, optional = true } writeable = { workspace = true, optional = true } [dev-dependen...
1
2
2
da2c1b3132bc909082b2f50813b92816bf25dae9
Shane F. Carr
2024-11-23T00:36:19
Add more links to the fieldsets module (#5860)
diff --git a/components/datetime/src/combo.rs b/components/datetime/src/combo.rs index d23f67ea7b..9f92d8ecd7 100644 --- a/components/datetime/src/combo.rs +++ b/components/datetime/src/combo.rs @@ -9,6 +9,7 @@ use crate::{provider::neo::*, scaffold::*}; /// Struct for combining date/time fields with zone fields. ///...
3
18
1
5cd40918abedf3453e62727eb413d8eacd00e3eb
Shane F. Carr
2024-11-23T00:27:07
Make GetField sealed; other datetime docs fixes (#5858) Fixes https://github.com/unicode-org/icu4x/issues/5633
diff --git a/components/datetime/src/fieldsets.rs b/components/datetime/src/fieldsets.rs index 54b789ebac..1c08ba7642 100644 --- a/components/datetime/src/fieldsets.rs +++ b/components/datetime/src/fieldsets.rs @@ -7,6 +7,27 @@ //! Each field set is a struct containing options specified to that field set. //! The fie...
6
102
6
ae39d818fab24fd61309b6ec4b1e45e498dbc1e0
Shane F. Carr
2024-11-15T19:54:47
Improve locale ordering examples and rename writeable::cmp_bytes to writeable::cmp_utf8 (#5828)
diff --git a/components/locale/src/canonicalizer.rs b/components/locale/src/canonicalizer.rs index dca616b6d7..f265ae801a 100644 --- a/components/locale/src/canonicalizer.rs +++ b/components/locale/src/canonicalizer.rs @@ -63,7 +63,7 @@ where let mut source_variants = source.variants.iter(); '...
12
179
81
11f42d90dec15ff37daf2088c1ce9ca815dcaf51
Shane F. Carr
2024-11-13T22:50:54
Tweaks on preference enum impls (#5814)
diff --git a/components/locale_core/src/preferences/extensions/unicode/macros/enum_keyword.rs b/components/locale_core/src/preferences/extensions/unicode/macros/enum_keyword.rs index 52de1cc09c..65f3ec6fcb 100644 --- a/components/locale_core/src/preferences/extensions/unicode/macros/enum_keyword.rs +++ b/components/loc...
1
13
13
e37d502fadf93fbaa05423a76359004f66621d8a
Shane F. Carr
2024-11-13T22:50:25
Decouple fixture components bag from library components bag; remove serde (#5817)
diff --git a/components/datetime/benches/fixtures/mod.rs b/components/datetime/benches/fixtures/mod.rs index 1206ccd005..e9aca9c1a6 100644 --- a/components/datetime/benches/fixtures/mod.rs +++ b/components/datetime/benches/fixtures/mod.rs @@ -2,7 +2,7 @@ // called LICENSE at the top level of the ICU4X source tree // ...
3
79
16
5029ff38df9f448c982326b1ffa97796b5325fe5
Manish Goregaokar
2024-11-13T00:23:05
Add VarZeroCow (#5809) Fixes https://github.com/unicode-org/icu4x/issues/5561 We can add more methods as needed, right now I think it covers most use cases.
diff --git a/utils/zerovec/src/cow.rs b/utils/zerovec/src/cow.rs new file mode 100644 index 0000000000..b1dcc8c36b --- /dev/null +++ b/utils/zerovec/src/cow.rs @@ -0,0 +1,351 @@ +// This file is part of ICU4X. For terms of use, please see the file +// called LICENSE at the top level of the ICU4X source tree +// (online...
2
353
1
09fde640eecc4c1cce690f77b3f25f947a56ecfd
Shane F. Carr
2024-11-12T02:39:47
Refactor size_test_macro and use it in icu_decimal (#5805) Test for #4437
diff --git a/components/datetime/src/format/neo.rs b/components/datetime/src/format/neo.rs index bf209816ed..bb6b6cc435 100644 --- a/components/datetime/src/format/neo.rs +++ b/components/datetime/src/format/neo.rs @@ -9,7 +9,6 @@ use super::{ }; use crate::external_loaders::*; use crate::fields::{self, Field, Field...
12
114
7
e0c1e0c26a8707f52a5909f3e568ee03a89fb2a4
Manish Goregaokar
2024-11-12T00:44:38
Serde impls for VarULE types (Var tuple types, and make_var) (#5802)
diff --git a/utils/zerovec/derive/examples/make_var.rs b/utils/zerovec/derive/examples/make_var.rs index 3433c366f7..46dd783726 100644 --- a/utils/zerovec/derive/examples/make_var.rs +++ b/utils/zerovec/derive/examples/make_var.rs @@ -3,6 +3,7 @@ // (online at: https://github.com/unicode-org/icu4x/blob/main/LICENSE )....
10
288
17
01c88b8d3f6053a8c6e55cf63619c02bdb3efa0a
Robert Bastian
2024-11-07T16:25:22
Remove duplicate feature notes from docs (#5794)
diff --git a/components/calendar/src/week_of.rs b/components/calendar/src/week_of.rs index 1536e906a9..ad1e39dc5d 100644 --- a/components/calendar/src/week_of.rs +++ b/components/calendar/src/week_of.rs @@ -34,10 +34,6 @@ impl WeekCalculator { icu_provider::gen_any_buffer_data_constructors!( (locale) -> e...
9
13
78
b6e388a22b69f30dbafc801a6d95ff38dd6a9f54
Shane F. Carr
2024-11-07T05:21:58
Fix comment about DecimalSecond (#5787) Follow-up to #5781
diff --git a/components/datetime/src/format/neo.rs b/components/datetime/src/format/neo.rs index 69109669de..846ae5d178 100644 --- a/components/datetime/src/format/neo.rs +++ b/components/datetime/src/format/neo.rs @@ -2192,8 +2192,8 @@ impl<R: DateTimeNamesMarker> RawDateTimeNames<R> { // A ...
1
2
2
4522f5b1fb1e08da2f37f781d2b719ec6a98374c
Manish Goregaokar
2024-11-07T04:11:49
Add TupleNVarULE (#5777) The VarULE counterpart of TupleNULE Part of https://github.com/unicode-org/icu4x/issues/5523. Planned to be used in https://github.com/unicode-org/icu4x/issues/4437 I'm not super happy with the naming with this vs VarTupleULE, but I've tried to make it clearer with the module names and it's ...
diff --git a/utils/zerovec/src/ule/encode.rs b/utils/zerovec/src/ule/encode.rs index fac7f2e249..1a0fa2e254 100644 --- a/utils/zerovec/src/ule/encode.rs +++ b/utils/zerovec/src/ule/encode.rs @@ -81,7 +81,7 @@ pub unsafe trait EncodeAsVarULE<T: VarULE + ?Sized> { /// Given an [`EncodeAsVarULE`] type `S`, encode it into...
4
221
2
5853a2e2c0b34e139b3cea1545c443613c3ba0e6
Robert Bastian
2024-11-06T14:27:23
remove time zone fallback error case
diff --git a/components/datetime/src/format/datetime.rs b/components/datetime/src/format/datetime.rs index 8f523f2ec4..b93a26e166 100644 --- a/components/datetime/src/format/datetime.rs +++ b/components/datetime/src/format/datetime.rs @@ -358,10 +358,10 @@ where let payloads = datetime_names.get_payloads()...
1
15
25
a46e88ff700822f90be2753514ee0148e641f98e
Robert Bastian
2024-11-06T13:26:45
DayOfYear
diff --git a/components/datetime/src/fieldset.rs b/components/datetime/src/fieldset.rs index 8bc0df1243..f392210ef8 100644 --- a/components/datetime/src/fieldset.rs +++ b/components/datetime/src/fieldset.rs @@ -249,6 +249,7 @@ macro_rules! impl_date_or_calendar_period_marker { type YearInput = datetime_mar...
7
29
6
da7646e772bb8b4c4becfa3ac71001437cf784dd
Robert Bastian
2024-11-06T12:45:22
MillisInDay
diff --git a/components/datetime/src/fields/mod.rs b/components/datetime/src/fields/mod.rs index c08886f793..caf93e7d2b 100644 --- a/components/datetime/src/fields/mod.rs +++ b/components/datetime/src/fields/mod.rs @@ -131,9 +131,9 @@ mod test { ], ), ( - Field:...
6
32
25
6d1f087359e4a02e9d95678130a04eed0215db59
Robert Bastian
2024-11-06T17:35:36
Move datetime code and simplify missing-input errors (#5783)
diff --git a/components/datetime/src/error.rs b/components/datetime/src/error.rs index c29d6da2b4..dfaa5a5ed7 100644 --- a/components/datetime/src/error.rs +++ b/components/datetime/src/error.rs @@ -2,8 +2,19 @@ // called LICENSE at the top level of the ICU4X source tree // (online at: https://github.com/unicode-org/...
7
299
363
8d54ba302037dff47c371ab9d23ba82e9a6f3963
Shane F. Carr
2024-11-05T17:04:00
Add TinyAsciiStr::concat (#5772) #5729
diff --git a/utils/tinystr/src/ascii.rs b/utils/tinystr/src/ascii.rs index 2b62427f14..7b3d2c033a 100644 --- a/utils/tinystr/src/ascii.rs +++ b/utils/tinystr/src/ascii.rs @@ -281,6 +281,67 @@ impl<const N: usize> TinyAsciiStr<N> { unsafe { TinyAsciiStr::from_utf8_unchecked(bytes) } } + #[inline] + ...
1
61
0
c359486de7ef7df6006b399cabe9287ce57cac13
Robert Bastian
2024-11-05T16:32:05
Fix some test patterns (#5775) `Y-m-d` is week-of-year, minute, day. It should be `y-M-d`.
diff --git a/components/datetime/src/provider/pattern/common/serde.rs b/components/datetime/src/provider/pattern/common/serde.rs index 9f3080ac41..a1e7934374 100644 --- a/components/datetime/src/provider/pattern/common/serde.rs +++ b/components/datetime/src/provider/pattern/common/serde.rs @@ -99,7 +99,7 @@ mod referen...
5
13
13
8ce5a89151f48f3def3013442f5028ef471f95c4
Younies Mahmoud
2024-11-05T12:46:54
Expose `CompactDecimalFormatterOptions` in the compactdecimal module (#5770)
diff --git a/components/experimental/src/compactdecimal/mod.rs b/components/experimental/src/compactdecimal/mod.rs index 28d90dd83c..2dd1d37f7a 100644 --- a/components/experimental/src/compactdecimal/mod.rs +++ b/components/experimental/src/compactdecimal/mod.rs @@ -27,3 +27,4 @@ pub mod provider; pub use error::Exp...
2
2
1
95bc54a046960edafcd4fcb1a16e414377f44459
Robert Bastian
2024-11-04T10:02:56
Add Chinese collator tests (#5765) Fixes #1964
diff --git a/components/collator/tests/tests.rs b/components/collator/tests/tests.rs index dc97c0e5b9..53d9234c80 100644 --- a/components/collator/tests/tests.rs +++ b/components/collator/tests/tests.rs @@ -921,12 +921,32 @@ fn test_vi_owned() { } #[test] -// See SourceDataProvider test_zh_non_baked for gb2312 and ...
2
38
23
a8cbd8330b563c0eef950a7444cfc20582b4fd0f
Robert Bastian
2024-11-03T19:33:21
Remove transitive meta crate features (#5767) #2856
diff --git a/components/icu/Cargo.toml b/components/icu/Cargo.toml index 09c213c0e5..3a8dba4668 100644 --- a/components/icu/Cargo.toml +++ b/components/icu/Cargo.toml @@ -136,15 +136,9 @@ datagen = [ serde_human = [ "icu_list/serde_human" ] -icu_datetime_experimental = [ - "icu_datetime/experimental", -] -icu...
1
2
8
7cc22e890ea7f8203c85b9d7cae781c5cdfaa36b
Henri Sivonen
2024-10-28T20:09:23
Adapt the collator to Unicode 16 normalization changes (#4878) This is the collator counterpart of #4860. Co-authored-by: Robert Bastian <robertbastian@unicode.org>
diff --git a/components/collator/src/elements.rs b/components/collator/src/elements.rs index 932679afd3..88088d9256 100644 --- a/components/collator/src/elements.rs +++ b/components/collator/src/elements.rs @@ -33,7 +33,19 @@ use crate::provider::CollationDataV1; /// Marker that a complex decomposition isn't round-t...
1
21
7
c3da0ca8802681b1b0b37295662949562e0d8379
Henri Sivonen
2024-10-28T17:19:41
Make the normalizer work with new Unicode 16 normalization behaviors (#4860) Closes #4859 ICU4C PR coming up. --------- Co-authored-by: Robert Bastian <robertbastian@unicode.org>
diff --git a/components/normalizer/src/lib.rs b/components/normalizer/src/lib.rs index c95a5a786b..96bd65c93f 100644 --- a/components/normalizer/src/lib.rs +++ b/components/normalizer/src/lib.rs @@ -179,7 +179,19 @@ const SPECIAL_NON_STARTER_DECOMPOSITION_MARKER_U16: u16 = 2; /// Marker that a complex decomposition ...
2
18
15
aee3cd6d1d1e35ed12f93a332a08e93302714ad4
Robert Bastian
2024-10-26T16:03:02
Update FFI allowlist (#5734)
diff --git a/tools/make/diplomat-coverage/src/allowlist.rs b/tools/make/diplomat-coverage/src/allowlist.rs index d8173cbbf9..a3e4b640b0 100644 --- a/tools/make/diplomat-coverage/src/allowlist.rs +++ b/tools/make/diplomat-coverage/src/allowlist.rs @@ -183,41 +183,20 @@ lazy_static::lazy_static! { "icu::calendar...
1
0
52
87be39cebdd853af05199b9b4c0cf2a295449132
Robert Bastian
2024-10-24T22:31:44
Month and day are 1-indexed (#5726) Co-authored-by: Manish Goregaokar <manishsmail@gmail.com>
diff --git a/components/calendar/src/calendar_arithmetic.rs b/components/calendar/src/calendar_arithmetic.rs index 2bd38cb3db..bc22271cd9 100644 --- a/components/calendar/src/calendar_arithmetic.rs +++ b/components/calendar/src/calendar_arithmetic.rs @@ -292,7 +292,7 @@ impl<C: CalendarArithmetic> ArithmeticDate<C> { ...
3
17
17
4443179d773bace71f2621157ee0eaf63ac3f9b0
Manish Goregaokar
2024-10-24T00:10:33
Fix take/into function names and conventions (#5723) Fixes https://github.com/unicode-org/icu4x/issues/4668 <!-- Thank you for your pull request to ICU4X! Reminder: try to use [Conventional Comments](https://conventionalcomments.org/) to make comments clearer. Please see https://github.com/unicode-org/icu4x/blob/...
diff --git a/components/experimental/src/displaynames/displaynames.rs b/components/experimental/src/displaynames/displaynames.rs index 7f37f0274f..0ec573a3ca 100644 --- a/components/experimental/src/displaynames/displaynames.rs +++ b/components/experimental/src/displaynames/displaynames.rs @@ -78,12 +78,10 @@ impl Regi...
23
115
126
239eb3cf5feaeb0722d52dd5d3a93621e384a28a
Robert Bastian
2024-10-23T18:24:05
Fix FFI ZDT formatting (#5725)
diff --git a/ffi/capi/src/timezone.rs b/ffi/capi/src/timezone.rs index aca5b02565..d38a31f463 100644 --- a/ffi/capi/src/timezone.rs +++ b/ffi/capi/src/timezone.rs @@ -311,23 +311,11 @@ impl From<icu_timezone::TimeZoneInfo<icu_timezone::models::Base>> for TimeZoneIn } } -impl TryFrom<TimeZoneInfoBuilder> for icu...
2
18
18
a1823e4e489585d263e93c05997ed860d533c13e
Shane F. Carr
2024-10-18T23:59:31
Improve time zone docs (#5710)
diff --git a/components/datetime/src/fieldset.rs b/components/datetime/src/fieldset.rs index aab1ace869..89701e3b47 100644 --- a/components/datetime/src/fieldset.rs +++ b/components/datetime/src/fieldset.rs @@ -20,6 +20,9 @@ use icu_calendar::{ use icu_provider::marker::NeverMarker; use icu_timezone::{TimeZoneBcp47Id...
3
40
86
e2dc83bdd9aff445ee1cf56b4fb6315cdd472e13
Shane F. Carr
2024-10-18T21:00:39
Add more strict time zone formatting tests (#5707) #5533
diff --git a/components/datetime/src/neo_marker.rs b/components/datetime/src/neo_marker.rs index dd3e9bd4ff..b08ee3b0bb 100644 --- a/components/datetime/src/neo_marker.rs +++ b/components/datetime/src/neo_marker.rs @@ -313,6 +313,17 @@ //! tzf.format(&time_zone), //! "HST" //! ); +//! +//! // Mis-spelling of...
1
246
1
c717cb0c501371ad350682c452e29c57cd9219ec
Robert Bastian
2024-10-18T03:32:35
Move transliterator data struct invariant (#5705)
diff --git a/components/experimental/src/transliterate/provider.rs b/components/experimental/src/transliterate/provider.rs index 1387bf709f..319ab99897 100644 --- a/components/experimental/src/transliterate/provider.rs +++ b/components/experimental/src/transliterate/provider.rs @@ -31,7 +31,6 @@ use zerovec::*; /// Th...
2
73
64
4925a48bedc483b8f0a9805e4b40cd8a50d55a52
Robert Bastian
2024-10-17T15:00:39
`DataError::allow_identifier_not_found` helper (#5697)
diff --git a/components/datetime/src/raw/neo.rs b/components/datetime/src/raw/neo.rs index 67b1930b1c..511ff24833 100644 --- a/components/datetime/src/raw/neo.rs +++ b/components/datetime/src/raw/neo.rs @@ -353,20 +353,16 @@ impl TimePatternSelectionData { // or if loading the explicit hour cycle fails, then l...
11
86
120
297e06b943721117a7854449414d2ac824d31317
Shane F. Carr
2024-10-16T18:50:18
More datetime polish (#5690) #1317
diff --git a/components/datetime/src/format/neo.rs b/components/datetime/src/format/neo.rs index e42a1dbf5c..3200a18d46 100644 --- a/components/datetime/src/format/neo.rs +++ b/components/datetime/src/format/neo.rs @@ -7,7 +7,6 @@ use super::{ GetNameForDayPeriodError, GetNameForMonthError, GetNameForWeekdayError,...
8
76
77
e5062448f5005a1382d54e5c79d52dc819a0190c
Shane F. Carr
2024-10-14T16:09:49
Add new_without_number_formatting; remove week calculator (#5677)
diff --git a/components/datetime/src/external_loaders.rs b/components/datetime/src/external_loaders.rs index f1d565e860..9702baa4bb 100644 --- a/components/datetime/src/external_loaders.rs +++ b/components/datetime/src/external_loaders.rs @@ -4,7 +4,6 @@ //! Internal traits and structs for loading data from other cr...
6
105
236
4863bfcac35eca10921126cd4c98022baa329d0e
Robert Bastian
2024-10-14T16:04:55
Support localized offsets with seconds (#5674) Fixes #5638 --------- Co-authored-by: Shane F. Carr <shane@unicode.org>
diff --git a/components/datetime/src/time_zone.rs b/components/datetime/src/time_zone.rs index b8fa1beb2b..fce6ec0fea 100644 --- a/components/datetime/src/time_zone.rs +++ b/components/datetime/src/time_zone.rs @@ -402,7 +402,10 @@ impl FormatOffset for LocalizedOffsetFormat { ) ...
2
33
2
3e02edb79704c9130db49213cebb5c5099c63af8
Shane F. Carr
2024-10-14T15:16:22
Remove internal traits DateSymbols, TimeSymbols, ZoneSymbols (#5679) These were useful when code was shared between 1.x and 2.x formatting code paths, but now removing them reduces failure paths. #1317
diff --git a/components/datetime/src/format/datetime.rs b/components/datetime/src/format/datetime.rs index c613c07358..9c931bea98 100644 --- a/components/datetime/src/format/datetime.rs +++ b/components/datetime/src/format/datetime.rs @@ -2,15 +2,15 @@ // called LICENSE at the top level of the ICU4X source tree // (o...
7
128
387
7ca6f7865dab05a3e346129c4cbf7388fb9e8139
Robert Bastian
2024-10-11T20:47:08
Deduplicate short/long time zone formats (#5673)
diff --git a/components/datetime/src/time_zone.rs b/components/datetime/src/time_zone.rs index ad5982440d..b8fa1beb2b 100644 --- a/components/datetime/src/time_zone.rs +++ b/components/datetime/src/time_zone.rs @@ -226,45 +226,45 @@ impl FormatTimeZone for TimeZoneFormatterUnit { ) -> Result<Result<(), FormatTimeZ...
1
53
244
af8dbaccc13f1f00e56433f343d5a0fb17164399
Shane F. Carr
2024-10-08T12:15:02
Remove VVV time zone format (#5659) Unblocks #987 See #5658
diff --git a/components/datetime/src/format/datetime.rs b/components/datetime/src/format/datetime.rs index 0718c682a1..590e58ba05 100644 --- a/components/datetime/src/format/datetime.rs +++ b/components/datetime/src/format/datetime.rs @@ -739,12 +739,6 @@ fn select_zone_units(time_zone: ResolvedNeoTimeZoneSkeleton) -> ...
5
9
64
0bf22dae00ebd21a5d2f3ddc3d8616f2d7e8fcd3
Shane F. Carr
2024-10-08T11:24:08
Change content_locale to be &LanguageIdentifier (#5566)
diff --git a/components/segmenter/src/line.rs b/components/segmenter/src/line.rs index a8fa62f1e7..2d8c042136 100644 --- a/components/segmenter/src/line.rs +++ b/components/segmenter/src/line.rs @@ -11,6 +11,7 @@ use alloc::vec::Vec; use core::char; use core::str::CharIndices; use icu_locale_core::subtags::language;...
9
76
76
35485a9177b0ada10ad3f6b09670ab79344f4fe6
Manish Goregaokar
2024-10-03T23:32:22
Hide away VZV internals (#5650)
diff --git a/utils/zerovec/src/map/vecs.rs b/utils/zerovec/src/map/vecs.rs index b46109dbc1..e236bea56d 100644 --- a/utils/zerovec/src/map/vecs.rs +++ b/utils/zerovec/src/map/vecs.rs @@ -4,6 +4,7 @@ use crate::ule::*; use crate::varzerovec::owned::VarZeroVecOwned; +use crate::varzerovec::vec::VarZeroVecInner; use ...
4
40
62
d3753508f57833b6282d3606b210fb4c049f02a3
Robert Bastian
2024-10-02T19:41:39
Update FFI allowlist (#5642)
diff --git a/tools/make/diplomat-coverage/src/allowlist.rs b/tools/make/diplomat-coverage/src/allowlist.rs index 69a55b3a0f..305f6051f0 100644 --- a/tools/make/diplomat-coverage/src/allowlist.rs +++ b/tools/make/diplomat-coverage/src/allowlist.rs @@ -281,9 +281,6 @@ lazy_static::lazy_static! { "icu::properties...
1
0
5
11ff5896e7edd4db5a29cf0dd9601780ab65d0fc
Manish Goregaokar
2024-10-02T00:31:53
Fix test of PackedPattern repr (#5636) Caused by clash of https://github.com/unicode-org/icu4x/pull/5620 and https://github.com/unicode-org/icu4x/pull/5601 <!-- Thank you for your pull request to ICU4X! Reminder: try to use [Conventional Comments](https://conventionalcomments.org/) to make comments clearer....
diff --git a/components/datetime/src/provider/packed_pattern.rs b/components/datetime/src/provider/packed_pattern.rs index 29ca7fb572..54a02acbc9 100644 --- a/components/datetime/src/provider/packed_pattern.rs +++ b/components/datetime/src/provider/packed_pattern.rs @@ -799,10 +799,10 @@ pub mod tests { assert...
1
4
4
6572ff990af52473b725e60ba02c1bda87faf6f9
Shane F. Carr
2024-10-01T18:44:14
Impl Serde for PackedPatternsV1 with packed-like human form (#5620)
diff --git a/components/datetime/Cargo.toml b/components/datetime/Cargo.toml index ae3c1e09b9..b175a7d48f 100644 --- a/components/datetime/Cargo.toml +++ b/components/datetime/Cargo.toml @@ -87,6 +87,7 @@ datagen = [ "dep:databake", "dep:litemap", "icu_calendar/datagen", + "icu_plurals/datagen", ...
4
369
46
efac6449fc22f52b5b8deca6f9e6c8b39c23e0ac
Robert Bastian
2024-10-01T14:35:45
Add `#[non_exhaustive]` return types to `DataExporter::close` and `ExportDriver::export` (#5629) #4716, #3746
diff --git a/provider/baked/src/export.rs b/provider/baked/src/export.rs index 17ff4c07da..e2cb51222d 100644 --- a/provider/baked/src/export.rs +++ b/provider/baked/src/export.rs @@ -672,7 +672,7 @@ impl DataExporter for BakedExporter { } } - fn close(&mut self) -> Result<(), DataError> { + fn clo...
8
59
38
22c617a00276cd504e438850176d61ce64a9df67
Shane F. Carr
2024-09-30T23:21:25
Add ZeroVec::as_slice (#5621)
diff --git a/utils/zerovec/src/zerovec/mod.rs b/utils/zerovec/src/zerovec/mod.rs index 808fb76e9a..3fc9d9ad1a 100644 --- a/utils/zerovec/src/zerovec/mod.rs +++ b/utils/zerovec/src/zerovec/mod.rs @@ -109,8 +109,7 @@ impl<'a, T: AsULE> Deref for ZeroVec<'a, T> { type Target = ZeroSlice<T>; #[inline] fn der...
1
17
5
e682005b1cdb95635d561da4ebc2250479ec2854
Shane F. Carr
2024-09-29T04:42:45
Remove old skeleton data marker (#5612) Fixes #1678 because the allocated data can no longer be used in the DataProvider framework
diff --git a/components/datetime/src/provider/calendar/skeletons.rs b/components/datetime/src/provider/calendar/skeletons.rs index b118f9b26e..8730b56deb 100644 --- a/components/datetime/src/provider/calendar/skeletons.rs +++ b/components/datetime/src/provider/calendar/skeletons.rs @@ -7,28 +7,18 @@ use crate::{ s...
3
38
97
4b95478715ae5f72b7b44b9df991159ae2086ca9
Ben Beasley
2024-09-27T13:16:59
In zerovec, skip `check_sizes()` test on non-64-bit arches (#5606) Since the expected sizes are based on 64-bit architectures, we need to either maintain additional expected sizes for 32-bit architectures, or (as implemented in this commit) just skip this test on architectures that are not 64-bit. Fixes #5605. <!-- ...
diff --git a/utils/zerovec/src/lib.rs b/utils/zerovec/src/lib.rs index 0ea8ae99c8..ec7c497737 100644 --- a/utils/zerovec/src/lib.rs +++ b/utils/zerovec/src/lib.rs @@ -518,6 +518,8 @@ pub use zerovec_derive::make_ule; pub use zerovec_derive::make_varule; #[cfg(test)] +// Expected sizes are based on a 64-bit architec...
1
2
0