commit_hash stringlengths 40 40 | author stringlengths 1 57 | date timestamp[s]date 2010-07-26 04:45:09 2026-04-14 18:21:10 | message stringlengths 8 1.39M | diff stringlengths 68 51.2k | files_changed int64 1 136 | insertions int64 0 2.35k | deletions int64 0 1.9k |
|---|---|---|---|---|---|---|---|
e44b75b57afd64efa337ec94db9597296493bc55 | Manish Goregaokar | 2024-04-02T06:09:51 | Add description to graveyard (#4765) | diff --git a/tools/graveyard/Cargo.toml b/tools/graveyard/Cargo.toml
index a0387d46af..d5925e6ef1 100644
--- a/tools/graveyard/Cargo.toml
+++ b/tools/graveyard/Cargo.toml
@@ -11,6 +11,7 @@ repository = "https://github.com/unicode-org/icu4x"
homepage = "https://icu4x.unicode.org"
license = "Unicode-3.0"
categories = ... | 1 | 1 | 0 |
dd92e7096eb2e0b591bc52523c9f634931052f7e | Shane F. Carr | 2024-04-02T01:47:58 | Add Writeable impls for char and smart pointers (#4763) | diff --git a/utils/writeable/src/impls.rs b/utils/writeable/src/impls.rs
index 4f0bc1abc6..ef075413e6 100644
--- a/utils/writeable/src/impls.rs
+++ b/utils/writeable/src/impls.rs
@@ -3,7 +3,6 @@
// (online at: https://github.com/unicode-org/icu4x/blob/main/LICENSE ).
use crate::*;
-use alloc::borrow::Cow;
use core... | 1 | 94 | 1 |
63b8125424f3dd428cfb7eb9158eed909566ef23 | Shane F. Carr | 2024-04-02T01:18:46 | Add EitherWriteable and use it for DoublePlaceholder in currency format (#4750)
Cleans up the currency formatter code a bit.
Part of #1441 | diff --git a/Cargo.lock b/Cargo.lock
index aa3d9b448e..e7a431eacc 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -1606,6 +1606,7 @@ version = "0.1.5"
dependencies = [
"databake",
"displaydoc",
+ "either",
"postcard",
"serde",
"serde_json",
@@ -3534,6 +3535,7 @@ name = "writeable"
version = "0.5.4"
dependencie... | 10 | 77 | 22 |
d16238619507c4df7cba740ef49a6068e5b215db | Younies Mahmoud | 2024-03-31T18:57:11 | Fix the naming of `CurrencyPatternsULE` (#4755) | diff --git a/components/experimental/src/dimension/provider/ule.rs b/components/experimental/src/dimension/provider/ule.rs
index 904a1b8a1a..505e4bff41 100644
--- a/components/experimental/src/dimension/provider/ule.rs
+++ b/components/experimental/src/dimension/provider/ule.rs
@@ -17,8 +17,8 @@ const USE_ISO_CODE: u16... | 1 | 9 | 9 |
b7d92c394614cee32768ee0ba5a6f08369b549de | Shane F. Carr | 2024-03-30T00:31:31 | Simplify LocaleExpander::minimize (#4754)
I was reviewing #4752 and I realized that there's a lot of duplicate
code that can be extracted to a helper function, similar to what we do
in the `maximize` routine.
It appears to make the code slightly faster, too, which wasn't my
primary goal but is a nice side-effect... | diff --git a/components/locid_transform/benches/locale_canonicalizer.rs b/components/locid_transform/benches/locale_canonicalizer.rs
index 5bab1d7f66..1a1718cde5 100644
--- a/components/locid_transform/benches/locale_canonicalizer.rs
+++ b/components/locid_transform/benches/locale_canonicalizer.rs
@@ -86,6 +86,15 @@ fn... | 2 | 44 | 72 |
ef3da315952d1513b6a02ff05e81d64bd86a47a7 | Shane F. Carr | 2024-03-29T18:24:17 | Return the sibling count in ZeroTrie probe function (#4735)
Follow-up to #4725 | diff --git a/utils/zerotrie/src/cursor.rs b/utils/zerotrie/src/cursor.rs
index cd378f6868..9a947422d6 100644
--- a/utils/zerotrie/src/cursor.rs
+++ b/utils/zerotrie/src/cursor.rs
@@ -2,6 +2,11 @@
// called LICENSE at the top level of the ICU4X source tree
// (online at: https://github.com/unicode-org/icu4x/blob/main/... | 3 | 51 | 23 |
8b137840174e42e28c5e13d338f505180045d7b5 | Kevin | 2024-03-28T00:46:10 | Address `ixdtf` feedback p.1 (#4749)
This is the first PR addressing the feedback on `ixdtf`.
1. Removes `IxdtfOption` in favor of methods on `IxdtfParser`
2. Shift `in_leap_year` to return a bool (and also fix a typo in the
function body of `in_leap_year`) | diff --git a/utils/ixdtf/src/parsers/datetime.rs b/utils/ixdtf/src/parsers/datetime.rs
index 844a732cef..c619fd1174 100644
--- a/utils/ixdtf/src/parsers/datetime.rs
+++ b/utils/ixdtf/src/parsers/datetime.rs
@@ -310,22 +310,22 @@ fn days_in_month(year: i32, month: u8) -> Option<u8> {
match month {
1 | 3 | ... | 3 | 36 | 75 |
94cb93cf589e6dad9b10006b28a2256b4410b2d9 | Shane F. Carr | 2024-03-27T23:56:16 | Datagen CLI: Add error context to LanguageIdentifier parsing (#4747)
#4629 | diff --git a/provider/datagen/src/bin/datagen/mod.rs b/provider/datagen/src/bin/datagen/mod.rs
index 0265e273fe..9bc8ba1721 100644
--- a/provider/datagen/src/bin/datagen/mod.rs
+++ b/provider/datagen/src/bin/datagen/mod.rs
@@ -120,8 +120,8 @@ fn main() -> eyre::Result<()> {
LanguageIdentifiers(lids) => lid... | 1 | 2 | 2 |
30e1c9b5fc13583227aed29bcaced68e7acc6831 | Younies Mahmoud | 2024-03-27T23:40:31 | Move currency related code to dimension/currency folder (#4745)
Move currency related code to dimension/currency folder in order to
split the formatting code of currency and units. | diff --git a/components/experimental/src/dimension/format.rs b/components/experimental/src/dimension/currency/format.rs
similarity index 92%
rename from components/experimental/src/dimension/format.rs
rename to components/experimental/src/dimension/currency/format.rs
index 9e9aadf80b..c34cc9cbe7 100644
--- a/components... | 8 | 167 | 157 |
b0051afd218144130152aa884b7e973467a681b8 | Robert Bastian | 2024-03-27T17:21:47 | Using units info singleton (#4746) | diff --git a/components/calendar/src/week_of.rs b/components/calendar/src/week_of.rs
index 6aab7af391..61dff01789 100644
--- a/components/calendar/src/week_of.rs
+++ b/components/calendar/src/week_of.rs
@@ -46,7 +46,7 @@ impl From<&WeekDataV1> for WeekCalculator {
}
impl WeekCalculator {
- /// Creates a new [`We... | 5 | 23 | 14 |
69b19dcb4c5ddd5654ce7fc570f96e360aa8c524 | Younies Mahmoud | 2024-03-27T16:11:44 | Refactor `ConversionFactory` to own the Payload (#4531)
Fixes: https://github.com/unicode-org/icu4x/issues/4522
---------
Co-authored-by: Robert Bastian <4706271+robertbastian@users.noreply.github.com> | diff --git a/components/experimental/src/units/converter_factory.rs b/components/experimental/src/units/converter_factory.rs
index fb37d63f7c..b09ee1fa46 100644
--- a/components/experimental/src/units/converter_factory.rs
+++ b/components/experimental/src/units/converter_factory.rs
@@ -2,31 +2,31 @@
// called LICENSE ... | 5 | 62 | 51 |
cba36ee5a5313969faab4b8602c49daefc6555d0 | Younies Mahmoud | 2024-03-27T12:33:01 | Change the error type from `DimensionError` to `DataError` in the cre… (#4744) | diff --git a/components/experimental/src/dimension/error.rs b/components/experimental/src/dimension/error.rs
deleted file mode 100644
index 11aa50fb42..0000000000
--- a/components/experimental/src/dimension/error.rs
+++ /dev/null
@@ -1,38 +0,0 @@
-// This file is part of ICU4X. For terms of use, please see the file
-//... | 2 | 16 | 45 |
d2c380dea3d775bf0734c417b48d1bea297c0987 | Shane F. Carr | 2024-03-26T18:27:34 | Upgrade to criterion 0.5 (#4739) | diff --git a/Cargo.lock b/Cargo.lock
index 3970f4f7a9..7ba9c2069c 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -601,19 +601,19 @@ dependencies = [
[[package]]
name = "criterion"
-version = "0.4.0"
+version = "0.5.1"
source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "e7c76e09c1aae2bc52b3d2... | 26 | 32 | 29 |
5febe658702d11e8060f094d9944a1b9a98a060a | Younies Mahmoud | 2024-03-26T15:45:55 | Implement end to end `CurrencyFormatter` for short and narrow formatting (#4452) | diff --git a/components/experimental/src/dimension/error.rs b/components/experimental/src/dimension/error.rs
new file mode 100644
index 0000000000..11aa50fb42
--- /dev/null
+++ b/components/experimental/src/dimension/error.rs
@@ -0,0 +1,38 @@
+// This file is part of ICU4X. For terms of use, please see the file
+// cal... | 6 | 347 | 0 |
a5851862571f70434b2cbef45b09238f36e47968 | Shane F. Carr | 2024-03-26T15:45:01 | Add more DatagenDriver options tests (#4723)
More testing to make sure #4629 doesn't break people | diff --git a/provider/datagen/tests/test-options.rs b/provider/datagen/tests/test-options.rs
index e4790df18a..42b9889f9e 100644
--- a/provider/datagen/tests/test-options.rs
+++ b/provider/datagen/tests/test-options.rs
@@ -21,6 +21,34 @@ impl TestingProvider {
fn new<const N: usize>(data: [(&'static str, &'static ... | 1 | 222 | 125 |
9622fb1a01f122d9fbbf70db4903a370ae962757 | Shane F. Carr | 2024-03-26T02:45:22 | Add ZeroTrie probe function for stepwise iteration. (#4725)
`probe` is to `iter` as `step` is to `get` | diff --git a/utils/zerotrie/src/cursor.rs b/utils/zerotrie/src/cursor.rs
index 0904802475..cd378f6868 100644
--- a/utils/zerotrie/src/cursor.rs
+++ b/utils/zerotrie/src/cursor.rs
@@ -145,7 +145,7 @@ pub struct ZeroAsciiIgnoreCaseTrieCursor<'a> {
}
impl<'a> ZeroTrieSimpleAsciiCursor<'a> {
- /// Steps the cursor o... | 2 | 184 | 4 |
1f2ea30bf52f013c2239574b59552fae0714d74b | Younies Mahmoud | 2024-03-20T14:09:57 | Rename `cldr/currencies.rs` to `cldr/currency/essentials.rs` (#4715) | diff --git a/provider/datagen/src/transform/cldr/currency/essentials.rs b/provider/datagen/src/transform/cldr/currency/essentials.rs
new file mode 100644
index 0000000000..d20d68a249
--- /dev/null
+++ b/provider/datagen/src/transform/cldr/currency/essentials.rs
@@ -0,0 +1,441 @@
+// This file is part of ICU4X. For term... | 2 | 442 | 437 |
3973fdad605e99ec3bcbdb36ea63aca0317b9177 | Younies Mahmoud | 2024-03-20T13:38:49 | Rename `units/units_constants.rs` to `units/info.rs` (#4714) | diff --git a/provider/datagen/src/transform/cldr/cldr_serde/units/units_constants.rs b/provider/datagen/src/transform/cldr/cldr_serde/units/info.rs
similarity index 100%
rename from provider/datagen/src/transform/cldr/cldr_serde/units/units_constants.rs
rename to provider/datagen/src/transform/cldr/cldr_serde/units/inf... | 4 | 3 | 3 |
bedfdabed124a3db5a6f72766e14be2dc67bfae6 | Younies Mahmoud | 2024-03-19T16:36:36 | Fix comments on `CurrencyPatternConfig` fields (#4707) | diff --git a/components/experimental/src/dimension/provider/currency.rs b/components/experimental/src/dimension/provider/currency.rs
index d5aabf94d4..01ebf48947 100644
--- a/components/experimental/src/dimension/provider/currency.rs
+++ b/components/experimental/src/dimension/provider/currency.rs
@@ -114,12 +114,10 @@... | 1 | 2 | 4 |
b1ca8b6b6bf9834d005f4ae2204813a513a939e2 | Younies Mahmoud | 2024-03-19T15:36:10 | Fix comment for `CompactDecimalPatternDataV1` (#4708) | diff --git a/components/experimental/src/compactdecimal/provider.rs b/components/experimental/src/compactdecimal/provider.rs
index f7b03c707f..98972d8f9f 100644
--- a/components/experimental/src/compactdecimal/provider.rs
+++ b/components/experimental/src/compactdecimal/provider.rs
@@ -26,7 +26,7 @@ use zerovec::ZeroMa... | 1 | 1 | 1 |
13d97ea5bc24c8c5c8f806bf65d965c03067bce8 | Colin Rofls | 2024-03-18T18:18:31 | Add a lossy constructor for tinystr (#4691)
An instance where it is easier for me to write the patch and open a PR
than to start a discussion issue.
I want to be able to write,
```rust
const COMMON_SCRIPT: TinyStr<4> = TinyStr::some_constructor(b"Zyyy");
```
but as far as I can tell, the only way to do thi... | diff --git a/utils/tinystr/src/ascii.rs b/utils/tinystr/src/ascii.rs
index 9ab694f02a..a59afb31ef 100644
--- a/utils/tinystr/src/ascii.rs
+++ b/utils/tinystr/src/ascii.rs
@@ -22,6 +22,37 @@ impl<const N: usize> TinyAsciiStr<N> {
Self::from_bytes_inner(bytes, 0, bytes.len(), false)
}
+ /// Creates a `... | 1 | 49 | 0 |
a1b2e6f5d57bee6a2963b85dc20fcfc6d5528b05 | Robert Bastian | 2024-03-18T14:15:02 | Respect `DisplayNamesOptions.language_display` (#4704) | diff --git a/components/experimental/src/displaynames/displaynames.rs b/components/experimental/src/displaynames/displaynames.rs
index 86234bcffe..d91ece57d3 100644
--- a/components/experimental/src/displaynames/displaynames.rs
+++ b/components/experimental/src/displaynames/displaynames.rs
@@ -406,27 +406,11 @@ impl Lo... | 1 | 52 | 21 |
c2d2c5e26899683c87ddbeaaa5b06a4a21bbf432 | Younies Mahmoud | 2024-03-13T13:43:25 | Adding a required pattern for currency (#4682) | diff --git a/provider/datagen/src/transform/cldr/decimal/decimal_pattern.rs b/provider/datagen/src/transform/cldr/decimal/decimal_pattern.rs
index 2379e1f569..0d1538fa78 100644
--- a/provider/datagen/src/transform/cldr/decimal/decimal_pattern.rs
+++ b/provider/datagen/src/transform/cldr/decimal/decimal_pattern.rs
@@ -6... | 1 | 1 | 0 |
728eb449584da57acc604466702a603c03a82e45 | Younies Mahmoud | 2024-03-12T16:35:50 | Add support for DoublePlaceholder for databake (#4679) | diff --git a/utils/pattern/src/frontend/databake.rs b/utils/pattern/src/frontend/databake.rs
index 2dda9912e2..9131345862 100644
--- a/utils/pattern/src/frontend/databake.rs
+++ b/utils/pattern/src/frontend/databake.rs
@@ -4,6 +4,7 @@
use core::any::TypeId;
+use crate::DoublePlaceholder;
use crate::SinglePlacehol... | 1 | 3 | 0 |
e0131091e1a0ef882b410cf39e163fe04a927645 | Younies Mahmoud | 2024-03-12T15:49:11 | Add a required pattern by currency (#4678) | diff --git a/provider/datagen/src/transform/cldr/decimal/decimal_pattern.rs b/provider/datagen/src/transform/cldr/decimal/decimal_pattern.rs
index 6ee6271425..2379e1f569 100644
--- a/provider/datagen/src/transform/cldr/decimal/decimal_pattern.rs
+++ b/provider/datagen/src/transform/cldr/decimal/decimal_pattern.rs
@@ -6... | 1 | 1 | 0 |
f832e5e4c845bb8c540fc6cc665aa46f3af34f4b | Shane F. Carr | 2024-03-12T11:28:34 | Add NeverMarker (#4674)
Fixes #4186 | diff --git a/provider/baked/calendar/data/macros.rs b/provider/baked/calendar/data/macros.rs
index 9d8a1b1a85..f698f60f3c 100644
--- a/provider/baked/calendar/data/macros.rs
+++ b/provider/baked/calendar/data/macros.rs
@@ -20,6 +20,7 @@ macro_rules! __make_provider {
#[allow(dead_code)]
pub co... | 18 | 124 | 1 |
183c70c116e8da2dd05648e2517eb99bd2ebbc6f | Shane F. Carr | 2024-03-12T08:16:16 | Implement DoublePlaceholderPattern (#4667) | diff --git a/utils/pattern/src/double.rs b/utils/pattern/src/double.rs
new file mode 100644
index 0000000000..2e485d16cd
--- /dev/null
+++ b/utils/pattern/src/double.rs
@@ -0,0 +1,703 @@
+// This file is part of ICU4X. For terms of use, please see the file
+// called LICENSE at the top level of the ICU4X source tree
+/... | 3 | 723 | 0 |
38fe0022bac8a1a80961be770cce9883197471a4 | Henri Sivonen | 2024-03-11T15:54:21 | Prepare for future normalization data for Unicode 16 (#4538)
ICU4X's data representation doesn't have a place for marking the first
character of an expansion as a starter that combines backwards.
To accommodate the Unicode 16 characters discussed in section 5 of
https://www.unicode.org/L2/L2024/24009-utc178-prope... | diff --git a/components/normalizer/src/properties.rs b/components/normalizer/src/properties.rs
index 9794d5209c..f88e04d61a 100644
--- a/components/normalizer/src/properties.rs
+++ b/components/normalizer/src/properties.rs
@@ -302,7 +302,17 @@ impl CanonicalDecomposition {
let offset24 = offset - tables.sc... | 1 | 11 | 1 |
4f6451b640179da192bcb34710eba4f50a276123 | Kartavya Vashishtha | 2024-03-10T07:48:31 | Enumerated property completeness tests (#4645)
fixes #4283
Description of changes:
- Introduced `create_const_array` macro that produces an array of tuples
of the values and names of the constants defined in an impl block.
- Use this constant to iterate over underlying data and report
differences. | diff --git a/components/properties/src/props.rs b/components/properties/src/props.rs
index e9c3030fbb..4dcf98645d 100644
--- a/components/properties/src/props.rs
+++ b/components/properties/src/props.rs
@@ -642,6 +642,39 @@ macro_rules! impl_value_getter {
}
}
+/// See [`test_enumerated_property_completeness`] ... | 1 | 150 | 0 |
8387180cc2d2051a6cbafcfb967d45d6ff3ba495 | Shane F. Carr | 2024-03-08T09:03:51 | Implement Serde for Pattern (#4665) | diff --git a/Cargo.lock b/Cargo.lock
index 05fbf8a344..94483fd05a 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -1604,6 +1604,9 @@ version = "0.1.5"
dependencies = [
"databake",
"displaydoc",
+ "postcard",
+ "serde",
+ "serde_json",
"writeable",
"yoke",
"zerofrom",
diff --git a/utils/pattern/Cargo.toml b/utils... | 7 | 223 | 9 |
a51fa55265bea12cc21375387b5399b55fcbe4d0 | Shane F. Carr | 2024-03-07T17:15:09 | Work around TokenStream stringification inconsistency in test_bake (#4664) | diff --git a/utils/databake/src/lib.rs b/utils/databake/src/lib.rs
index a625bba946..624b024273 100644
--- a/utils/databake/src/lib.rs
+++ b/utils/databake/src/lib.rs
@@ -173,7 +173,8 @@ macro_rules! test_bake {
let env = Default::default();
let expr: &$type = &$expr;
let bake = $crate::Bake:... | 3 | 2 | 15 |
1734713189f8d09f9a6038225855ba023afd9f45 | Shane F. Carr | 2024-03-07T15:17:05 | Add more impls to Pattern (#4658)
This adds Databake, Yokeable, and ZeroFrom. Serde will follow. | diff --git a/Cargo.lock b/Cargo.lock
index 8d17f45cc4..05fbf8a344 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -1602,8 +1602,12 @@ version = "1.4.0"
name = "icu_pattern"
version = "0.1.5"
dependencies = [
+ "databake",
"displaydoc",
"writeable",
+ "yoke",
+ "zerofrom",
+ "zerovec",
]
[[package]]
diff --git a/... | 8 | 161 | 2 |
6af23337c9407bda89bb6b1e929e0e8cfdd960c5 | Shane F. Carr | 2024-03-07T12:34:17 | Yokeable Derive: require Sized on certain types (#4659)
For now only on structs with no explicit lifetimes | diff --git a/utils/yoke/derive/examples/yoke_derive.rs b/utils/yoke/derive/examples/yoke_derive.rs
index a011d5c241..d65ada1bc9 100644
--- a/utils/yoke/derive/examples/yoke_derive.rs
+++ b/utils/yoke/derive/examples/yoke_derive.rs
@@ -4,7 +4,7 @@
#![allow(unused)]
-use std::borrow::Cow;
+use std::{borrow::Cow, mar... | 2 | 25 | 3 |
db1772da034a10e55b29c8343519d99bcf105c3e | Shane F. Carr | 2024-03-06T11:45:24 | Add ZeroVec::take_last and ::take_first (#4651) | diff --git a/utils/zerovec/src/zerovec/mod.rs b/utils/zerovec/src/zerovec/mod.rs
index a0d0f83be3..50cbb3dd52 100644
--- a/utils/zerovec/src/zerovec/mod.rs
+++ b/utils/zerovec/src/zerovec/mod.rs
@@ -914,6 +914,91 @@ where
*self = Self::new_borrowed(&[])
}
+ /// Removes the first element of the ZeroVe... | 1 | 85 | 0 |
49ff029fb96d8ba459f15a2d5753bc1e0e862150 | Shane F. Carr | 2024-03-05T10:52:04 | Fix make_testdata (#4652) | diff --git a/provider/datagen/src/tests/make_testdata.rs b/provider/datagen/src/tests/make_testdata.rs
index 012176e0fd..d7d03b4583 100644
--- a/provider/datagen/src/tests/make_testdata.rs
+++ b/provider/datagen/src/tests/make_testdata.rs
@@ -35,31 +35,23 @@ fn make_testdata() {
.unwrap();
Box::... | 1 | 8 | 16 |
e33525c5f8d98163565fd6ee7621614fd4b758ee | Shane F. Carr | 2024-03-05T08:18:08 | Add another Writeable benchmark (#4649)
See https://github.com/unicode-org/icu4x/issues/4590
```
complex/write_to_string/medium
time: [34.344 ns 34.380 ns 34.417 ns]
complex/display_to_string/medium
time: [90.373 ns 90.482 ns 90.661 ns]
``` | diff --git a/utils/writeable/benches/writeable.rs b/utils/writeable/benches/writeable.rs
index fc433f8953..e2696a6772 100644
--- a/utils/writeable/benches/writeable.rs
+++ b/utils/writeable/benches/writeable.rs
@@ -35,6 +35,36 @@ impl fmt::Display for DisplayMessage<'_> {
}
}
+/// A sample type that contains mu... | 1 | 52 | 0 |
7428f2261422cd65ecdb1f1d38d1324b8e3243ac | Ashutosh Jha | 2024-03-04T07:31:11 | Add more collator tests for vi and u-co-phonebk (#4633) | diff --git a/components/collator/tests/tests.rs b/components/collator/tests/tests.rs
index f0ca687bd4..3ccedb2f7b 100644
--- a/components/collator/tests/tests.rs
+++ b/components/collator/tests/tests.rs
@@ -165,6 +165,36 @@ fn test_de() {
Ordering::Greater,
];
+ let expect_de_at = [
+ Ordering... | 1 | 76 | 0 |
e55cc3385e4527a70deb9659df406c29ae3e034a | Younies Mahmoud | 2024-02-28T15:01:00 | Implement `UnitsConverter` (#4605)
This PR introduces the `UnitsConverter`, a `struct` that wraps three
distinct types of unit converters:
1. **ProportionalConverter**: Handles conversions between units where
the relationship is `unit1 = CR * unit2`.
2. **ReciprocalConverter**: Handles conversions between units ... | diff --git a/experimental/components/src/units/converter.rs b/experimental/components/src/units/converter.rs
index dc883f0829..b687da36de 100644
--- a/experimental/components/src/units/converter.rs
+++ b/experimental/components/src/units/converter.rs
@@ -2,247 +2,101 @@
// called LICENSE at the top level of the ICU4X ... | 4 | 413 | 223 |
bab5c037ca4136138f5cf6400a91164ebef99ef7 | Elango Cheran | 2024-02-27T19:06:53 | Remove logging of missing exemplar data in datagen (#4636)
Fixes #4594 | diff --git a/provider/datagen/src/transform/cldr/characters/mod.rs b/provider/datagen/src/transform/cldr/characters/mod.rs
index f8dfb9e4db..9eec892a88 100644
--- a/provider/datagen/src/transform/cldr/characters/mod.rs
+++ b/provider/datagen/src/transform/cldr/characters/mod.rs
@@ -74,14 +74,7 @@ macro_rules! exemplar_... | 1 | 1 | 8 |
17f2cb091a72efd9ff4812951ff4e3123e9bc513 | Harsh Raj | 2024-02-27T09:00:14 | Remove unused imports from docs tests (#4628)
Cleaned all the unused imports, which can be confusing to clients and developers.
Part of #4570 | diff --git a/components/calendar/src/any_calendar.rs b/components/calendar/src/any_calendar.rs
index 1f3a8f3e53..67cdee0a63 100644
--- a/components/calendar/src/any_calendar.rs
+++ b/components/calendar/src/any_calendar.rs
@@ -40,11 +40,9 @@ use core::fmt;
///
/// There are many ways of constructing an AnyCalendar'd ... | 52 | 43 | 148 |
ec0a70a93919e402e56c0987c1fdd8c79cc0b429 | Shane F. Carr | 2024-02-15T06:16:37 | Refactor shortvec code into its own module with more docs (#4394) | diff --git a/components/locid/src/extensions/other/mod.rs b/components/locid/src/extensions/other/mod.rs
index 933128739d..8a7f36d494 100644
--- a/components/locid/src/extensions/other/mod.rs
+++ b/components/locid/src/extensions/other/mod.rs
@@ -21,9 +21,9 @@
mod subtag;
-use crate::helpers::ShortSlice;
use crat... | 14 | 522 | 387 |
64940f213d862ed3a8c7a52e1291e381d1cd6721 | Colin Rofls | 2024-02-14T18:20:53 | [icu_properties] Derive hash for property types (#4613) | diff --git a/components/properties/src/props.rs b/components/properties/src/props.rs
index 5cfc84fa1c..b7e29a0e88 100644
--- a/components/properties/src/props.rs
+++ b/components/properties/src/props.rs
@@ -647,7 +647,7 @@ macro_rules! impl_value_getter {
/// These are the categories required by the Unicode Bidirectio... | 1 | 11 | 11 |
3e93eeffdeead51c69ce61c2594d73a2d5bc04f5 | Younies Mahmoud | 2024-02-13T03:32:45 | Fix Cargo.lock (#4604)
<!--
Thank you for your pull request to ICU4X!
Reminder: try to use [Conventional
Comments](https://conventionalcomments.org/) to make comments clearer.
Please see
https://github.com/unicode-org/icu4x/blob/main/CONTRIBUTING.md for
general
information on contributing to ICU4X.
--> | diff --git a/docs/tutorials/c/Cargo.lock b/docs/tutorials/c/Cargo.lock
index 757f42e961..6764725b2f 100644
--- a/docs/tutorials/c/Cargo.lock
+++ b/docs/tutorials/c/Cargo.lock
@@ -553,7 +553,6 @@ source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "0638a1c9d0a3c0914158145bc76cff373a75a627e6ecbfb... | 5 | 0 | 5 |
61cf5cd095a1b1a6d195a7fa9d3bc1e7e2e488f4 | Colin Rofls | 2024-02-12T20:01:17 | Add explicit lifetime to `ScriptExtensionsSet` impl (#4603)
By eliding this lifetime, the compiler assumes that the iterator is
valid for the lifetime of self, but it it really valid for the lifetime
of the underlying data. An explicit lifetime makes this clear, and
allows for the returned iterator to outlive the `&se... | diff --git a/components/properties/src/script.rs b/components/properties/src/script.rs
index 7e2595a4c4..918ad89c71 100644
--- a/components/properties/src/script.rs
+++ b/components/properties/src/script.rs
@@ -181,7 +181,7 @@ pub struct ScriptExtensionsSet<'a> {
values: &'a ZeroSlice<Script>,
}
-impl ScriptExt... | 1 | 2 | 2 |
059528bcd1364959d73da1ea937188ae79cc2159 | Robert Bastian | 2024-02-12T15:15:41 | Bump ahash to fix nightly (#4601)
<!--
Thank you for your pull request to ICU4X!
Reminder: try to use [Conventional
Comments](https://conventionalcomments.org/) to make comments clearer.
Please see
https://github.com/unicode-org/icu4x/blob/main/CONTRIBUTING.md for
general
information on contributing to ICU4X.
--> | diff --git a/Cargo.lock b/Cargo.lock
index 69e3bd7c6e..1afb2626f5 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -19,9 +19,9 @@ checksum = "f26201604c87b1e01bd3d98f8d5d9a8fcbb815e8cedb41ffccbeb4bf593a35fe"
[[package]]
name = "ahash"
-version = "0.7.7"
+version = "0.7.8"
source = "registry+https://github.com/rust-lang... | 3 | 6 | 6 |
9f4fb6444ae0cdf7344088aba1b20a03ab5b2fb2 | Younies Mahmoud | 2024-02-08T21:16:17 | Configure the experimental testing correctly and apply minor fixes. (#4595) | diff --git a/Cargo.lock b/Cargo.lock
index d4c8adc77a..69e3bd7c6e 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -2362,9 +2362,9 @@ dependencies = [
[[package]]
name = "num-traits"
-version = "0.2.17"
+version = "0.2.18"
source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "39e3200413f237f41ab... | 19 | 366 | 163 |
5e1624256a67f5dc974086dcaaa89d999dfbb252 | Sean Burke | 2024-02-08T14:27:48 | Address issues in explicit resource bundle handling code (#4267) | diff --git a/utils/resb/src/binary/serializer.rs b/utils/resb/src/binary/serializer.rs
index 3c0484ac2b..cd410156a5 100644
--- a/utils/resb/src/binary/serializer.rs
+++ b/utils/resb/src/binary/serializer.rs
@@ -901,7 +901,7 @@ impl Serializer {
resources_end,
bundle_end: resources_end,
... | 4 | 26 | 205 |
a3c48df96e5cc0f79d97599c9e189c46c1fbf964 | Manish Goregaokar | 2024-02-08T00:24:14 | Fix nightly build (#4591)
I guess ahash is doing the "detect if you're on nightly and autoenable
simd" thing.
Depends on https://github.com/unicode-org/icu4x/pull/4592 to land
<!--
Thank you for your pull request to ICU4X!
Reminder: try to use [Conventional
Comments](https://conventionalcomments.org/) to make comm... | diff --git a/Cargo.lock b/Cargo.lock
index a8cd471580..d4c8adc77a 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -19,9 +19,9 @@ checksum = "f26201604c87b1e01bd3d98f8d5d9a8fcbb815e8cedb41ffccbeb4bf593a35fe"
[[package]]
name = "ahash"
-version = "0.7.6"
+version = "0.7.7"
source = "registry+https://github.com/rust-lang... | 1 | 2 | 2 |
6fda1e86cb4fc1154c148637d280fc261cbe6367 | Shane F. Carr | 2024-02-05T23:18:40 | Add ZeroAsciiIgnoreCaseTrieCursor (#4563) | diff --git a/experimental/zerotrie/src/cursor.rs b/experimental/zerotrie/src/cursor.rs
index 40327d7e85..5ed699faa2 100644
--- a/experimental/zerotrie/src/cursor.rs
+++ b/experimental/zerotrie/src/cursor.rs
@@ -2,7 +2,8 @@
// called LICENSE at the top level of the ICU4X source tree
// (online at: https://github.com/u... | 2 | 197 | 17 |
6b6f6dfa6e0ffbe9aa346f65ed3aa10ddb428bab | Younies Mahmoud | 2024-02-05T14:05:06 | Implement `LinearConverter` (#4404) | diff --git a/Cargo.lock b/Cargo.lock
index 67caec90f6..8afb696713 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -1984,7 +1984,11 @@ dependencies = [
"displaydoc",
"icu_locid",
"icu_provider",
+ "litemap",
"num",
+ "num-bigint",
+ "num-rational",
+ "num-traits",
"serde",
"smallvec",
"zerotrie",
@@ -2404,9 +2... | 7 | 318 | 35 |
6a96034debe0826cc0079cf2b291cc2e5eb37fcf | José Julián Espina | 2024-02-02T22:18:23 | Add benchmark for rounding methods of `FixedDecimal` (#4571) | diff --git a/utils/fixed_decimal/Cargo.toml b/utils/fixed_decimal/Cargo.toml
index 958643f487..b5ebc56ff0 100644
--- a/utils/fixed_decimal/Cargo.toml
+++ b/utils/fixed_decimal/Cargo.toml
@@ -40,7 +40,7 @@ criterion = "0.4"
[features]
std = []
-bench = []
+bench = ["ryu"]
experimental = []
ryu = ["dep:ryu"]
diff... | 2 | 50 | 1 |
b4a2caf597ee3ecaf5c9f96a2dad25a9d18ecea6 | Robert Bastian | 2024-01-31T16:45:21 | Tightening deps allowlist (#4565)
`icu_provider_adapters` should not generally be used by components, it's
for callers to build data pipelines. | diff --git a/tools/depcheck/src/allowlist.rs b/tools/depcheck/src/allowlist.rs
index 08d3a4dda6..f52020fab7 100644
--- a/tools/depcheck/src/allowlist.rs
+++ b/tools/depcheck/src/allowlist.rs
@@ -26,7 +26,6 @@ pub const BASIC_RUNTIME_DEPS: &[&str] = &[
// ICU4X utils
"calendrical_calculations",
"fixed_dec... | 1 | 7 | 2 |
62e6cc6d3850bdb6af8c9f59c767a6c27e980ead | Shane F. Carr | 2024-01-31T16:25:10 | Move the aux key fallback docs test to a unit test (#4556) | diff --git a/components/locid_transform/src/fallback/algorithms.rs b/components/locid_transform/src/fallback/algorithms.rs
index 830aba3e7e..0eb5fc0df7 100644
--- a/components/locid_transform/src/fallback/algorithms.rs
+++ b/components/locid_transform/src/fallback/algorithms.rs
@@ -219,6 +219,30 @@ mod tests {
use... | 2 | 24 | 31 |
5f281207b8086173573fa9098aa0f458edcbd20d | Robert Bastian | 2024-01-31T11:35:26 | Fix Rata Die docs (#4557)
A JD is a Julian Day, which should *not* be mixed up with Rata Die
because it has a different epoch:
https://en.wikipedia.org/wiki/Julian_day | diff --git a/utils/calendrical_calculations/src/lib.rs b/utils/calendrical_calculations/src/lib.rs
index 8ebb328ca7..0ba879a226 100644
--- a/utils/calendrical_calculations/src/lib.rs
+++ b/utils/calendrical_calculations/src/lib.rs
@@ -56,6 +56,6 @@ pub mod iso;
pub mod julian;
/// The persian calendar
pub mod persia... | 1 | 2 | 2 |
aeef4f6bb50357dc101e99aacba05e1345abccc0 | Shane F. Carr | 2024-01-30T22:35:01 | ZeroTrie feedback and refactoring (#4553)
Follow-ups to #4549 | diff --git a/experimental/zerotrie/src/builder/nonconst/builder.rs b/experimental/zerotrie/src/builder/nonconst/builder.rs
index 77c42a23c7..40abf0c435 100644
--- a/experimental/zerotrie/src/builder/nonconst/builder.rs
+++ b/experimental/zerotrie/src/builder/nonconst/builder.rs
@@ -10,49 +10,11 @@ use super::store::Tri... | 6 | 163 | 287 |
7a7e93cf8790968970ecef7adb1610958f485e81 | Shane F. Carr | 2024-01-30T02:53:33 | Document invariants in LocaleFallbacker (#4414)
Follow-up from #4412 | diff --git a/components/locid_transform/src/fallback/algorithms.rs b/components/locid_transform/src/fallback/algorithms.rs
index c3a3d08cab..830aba3e7e 100644
--- a/components/locid_transform/src/fallback/algorithms.rs
+++ b/components/locid_transform/src/fallback/algorithms.rs
@@ -298,7 +298,7 @@ mod tests {
... | 2 | 36 | 36 |
af4bbdba5f9715726caa75528f8b95440db19948 | Manish Goregaokar | 2024-01-26T00:37:28 | More keviyah docs, rearrange code (#4517)
<!--
Thank you for your pull request to ICU4X!
Reminder: try to use [Conventional
Comments](https://conventionalcomments.org/) to make comments clearer.
Please see
https://github.com/unicode-org/icu4x/blob/main/CONTRIBUTING.md for
general
information on contributing to ICU4X... | diff --git a/utils/calendrical_calculations/src/hebrew_keviyah.rs b/utils/calendrical_calculations/src/hebrew_keviyah.rs
index 7cbce9dd3a..dd5ff51793 100644
--- a/utils/calendrical_calculations/src/hebrew_keviyah.rs
+++ b/utils/calendrical_calculations/src/hebrew_keviyah.rs
@@ -7,10 +7,6 @@
// the Apache License, Vers... | 2 | 116 | 57 |
b12ec9a08f8f2f268f0dcc74801c03ab0882ca45 | Shane F. Carr | 2024-01-25T18:45:41 | ZeroAsciiIgnoreCaseTrie (#4549) | diff --git a/experimental/zerotrie/src/builder/nonconst/builder.rs b/experimental/zerotrie/src/builder/nonconst/builder.rs
index 105be09390..77c42a23c7 100644
--- a/experimental/zerotrie/src/builder/nonconst/builder.rs
+++ b/experimental/zerotrie/src/builder/nonconst/builder.rs
@@ -2,6 +2,8 @@
// called LICENSE at the... | 11 | 365 | 13 |
993fa4f1cbbfb863f9b655489c825dbdeaccf012 | Shane F. Carr | 2024-01-24T20:34:33 | ZeroTrieSimpleAscii internals and non-ASCII behavior docs (#4547)
Fixes #4395 | diff --git a/experimental/zerotrie/src/cursor.rs b/experimental/zerotrie/src/cursor.rs
index a7a8864541..40327d7e85 100644
--- a/experimental/zerotrie/src/cursor.rs
+++ b/experimental/zerotrie/src/cursor.rs
@@ -118,9 +118,28 @@ impl<'a> ZeroTrieSimpleAsciiCursor<'a> {
/// cursor.step(b'y');
/// assert_eq!(cur... | 3 | 44 | 21 |
7e30498bd8ef00b7fd3633d6b82e387470184998 | Henri Sivonen | 2024-01-17T14:30:19 | Document how ECMA-402 sensitivity and usage map to ICU4X API (#4529)
Closes #4528.
Co-authored-by: Robert Bastian <4706271+robertbastian@users.noreply.github.com> | diff --git a/components/collator/src/options.rs b/components/collator/src/options.rs
index 77e5c9da37..935cbff506 100644
--- a/components/collator/src/options.rs
+++ b/components/collator/src/options.rs
@@ -22,7 +22,9 @@ use crate::elements::{CASE_MASK, TERTIARY_MASK};
#[non_exhaustive]
pub enum Strength {
/// C... | 2 | 92 | 16 |
415989a5f44631cd3d4ead37b1ae91303cc47c83 | Shane F. Carr | 2024-01-06T06:59:13 | Add size tests for main datetime types (#4513) | diff --git a/components/datetime/src/any/date.rs b/components/datetime/src/any/date.rs
index 4aab37e52c..a7f1838261 100644
--- a/components/datetime/src/any/date.rs
+++ b/components/datetime/src/any/date.rs
@@ -2,6 +2,7 @@
// called LICENSE at the top level of the ICU4X source tree
// (online at: https://github.com/u... | 8 | 117 | 0 |
39a01a4809184ca6b7639d55fd94080486bdf989 | Robert Bastian | 2024-01-06T00:40:33 | Remove manual Default impl for ListLength (#4509) | diff --git a/components/list/src/lib.rs b/components/list/src/lib.rs
index 0e6fd913a6..6875d6c144 100644
--- a/components/list/src/lib.rs
+++ b/components/list/src/lib.rs
@@ -106,10 +106,11 @@ pub use ListError as Error;
/// Represents the style of a list. See the
/// [CLDR spec](https://unicode.org/reports/tr35/tr35... | 1 | 2 | 7 |
1ae5bb34b5cf1d7cd91c06603a03297cf35df4fb | Manish Goregaokar | 2024-01-05T23:18:11 | Use fancy new keviyah module for Hebrew calendrical calculations (#4504) | diff --git a/components/calendar/benches/convert.rs b/components/calendar/benches/convert.rs
index 29d233866d..d28301536a 100644
--- a/components/calendar/benches/convert.rs
+++ b/components/calendar/benches/convert.rs
@@ -75,6 +75,13 @@ fn convert_benches(c: &mut Criterion) {
icu::calendar::gregorian::Gregori... | 6 | 670 | 269 |
877d9d94a19cad426b78c39156f75b6e53109ca8 | Zibi Braniecki | 2024-01-05T20:59:25 | Add Copy, PartialEq, Eq and Hash to DTFOptions (#4503)
We currently implement wider set of traits for `length::Bag` and
`componentsBag` than their union enum.
This makes TF and DF suitable for intl_memoizer, but not DTF (since it
requires options to be hashed).
I'd like to extend the derive traits to match tha... | diff --git a/components/datetime/benches/datetime.rs b/components/datetime/benches/datetime.rs
index edc17445e2..e42322baeb 100644
--- a/components/datetime/benches/datetime.rs
+++ b/components/datetime/benches/datetime.rs
@@ -40,17 +40,14 @@ fn datetime_benches(c: &mut Criterion) {
let dtf = {... | 3 | 8 | 16 |
978ed24845299cad5a58a928ef85b7b2e8928ed8 | Robert Bastian | 2024-01-04T17:17:56 | Make `test-options` test not depend on CLDR (#4319) | diff --git a/provider/datagen/tests/test-options.rs b/provider/datagen/tests/test-options.rs
index 09132d9bf7..976fe0a467 100644
--- a/provider/datagen/tests/test-options.rs
+++ b/provider/datagen/tests/test-options.rs
@@ -2,97 +2,191 @@
// called LICENSE at the top level of the ICU4X source tree
// (online at: https... | 1 | 337 | 170 |
e8d80bf8966602f013760f343802605f931f0882 | Zibi Braniecki | 2024-01-04T01:45:56 | Add Default and Hash to icu::list::ListLength (#4507)
Same as #4503 and #4506 for icu::list | diff --git a/components/list/src/lib.rs b/components/list/src/lib.rs
index 931caf111f..0e6fd913a6 100644
--- a/components/list/src/lib.rs
+++ b/components/list/src/lib.rs
@@ -106,7 +106,7 @@ pub use ListError as Error;
/// Represents the style of a list. See the
/// [CLDR spec](https://unicode.org/reports/tr35/tr35-g... | 1 | 7 | 1 |
fb4ef4b416517a280a13414101b4fd2ffc77a9cd | Zibi Braniecki | 2024-01-04T01:45:49 | Add Copy and Hash derives to FixedDecimlFormtterOptions (#4506)
Similar to #4503 - This enables hashing of fixed decimal options which
is needed by memoizers. | diff --git a/components/decimal/src/options.rs b/components/decimal/src/options.rs
index 15a337da18..758f3fd990 100644
--- a/components/decimal/src/options.rs
+++ b/components/decimal/src/options.rs
@@ -6,7 +6,7 @@
/// A bag of options defining how numbers will be formatted by
/// [`FixedDecimalFormatter`](crate::F... | 1 | 2 | 2 |
729ce9f9f945553a58299821eff063b48311d024 | Shane F. Carr | 2024-01-03T22:25:59 | Maybe fix bench-perf (components/datetime) CI (#4508) | diff --git a/components/datetime/benches/datetime.rs b/components/datetime/benches/datetime.rs
index 4039091202..edc17445e2 100644
--- a/components/datetime/benches/datetime.rs
+++ b/components/datetime/benches/datetime.rs
@@ -8,6 +8,7 @@ use criterion::{criterion_group, criterion_main, Criterion};
use std::fmt::Write... | 1 | 1 | 0 |
3f50b42957d63ea77741ce64ecc2abe49be182c0 | Shane F. Carr | 2023-12-27T17:31:14 | Add GenericPatternItemULE::as_pattern_item_ule (#4497) | diff --git a/components/datetime/src/pattern/item/ule.rs b/components/datetime/src/pattern/item/ule.rs
index 0e71cd91e2..96970705d6 100644
--- a/components/datetime/src/pattern/item/ule.rs
+++ b/components/datetime/src/pattern/item/ule.rs
@@ -25,7 +25,8 @@ use zerovec::ule::{AsULE, ZeroVecError, ULE};
///
/// If the ... | 1 | 26 | 2 |
84d16e9ec04354e9e3666e45208037caef78d692 | Shane F. Carr | 2023-12-27T17:27:48 | Implement AsULE for PluralCategory (#4496) | diff --git a/components/plurals/src/lib.rs b/components/plurals/src/lib.rs
index aa734637cf..db31fa64f5 100644
--- a/components/plurals/src/lib.rs
+++ b/components/plurals/src/lib.rs
@@ -151,6 +151,8 @@ pub enum PluralRuleType {
#[derive(Debug, PartialEq, Eq, Clone, Copy, Hash, Ord, PartialOrd)]
#[cfg_attr(feature = ... | 2 | 11 | 6 |
ce906e63a785c9dc20106420cd7ddb59ea2e6df0 | Shane F. Carr | 2023-12-25T03:39:23 | Make ZeroVec have a niche via NonNull (#4491) | diff --git a/utils/zerovec/src/lib.rs b/utils/zerovec/src/lib.rs
index 51e78b7117..12b29eab6b 100644
--- a/utils/zerovec/src/lib.rs
+++ b/utils/zerovec/src/lib.rs
@@ -549,7 +549,7 @@ mod tests {
check_size_of!(120 | 96, ZeroMap2d<str, str, str>);
check_size_of!(32 | 24, vecs::FlexZeroVec);
- ... | 2 | 16 | 9 |
caab976aa28cbb30d588fb396c1bc5f8a7f94f00 | Shane F. Carr | 2023-12-24T05:42:35 | Fix more size tests to be MSRV friendly (#4492)
Coverage CI is still failing. Maybe this will fix it | diff --git a/provider/core/src/response.rs b/provider/core/src/response.rs
index d85a333f9a..488e1e02c2 100644
--- a/provider/core/src/response.rs
+++ b/provider/core/src/response.rs
@@ -115,28 +115,29 @@ pub struct DataPayload<M: DataMarker>(pub(crate) DataPayloadInner<M>);
///
/// ```
/// use core::mem::size_of;
-... | 2 | 16 | 19 |
5cd3eedb5eea1c56868b2d5412ce1e0433a09407 | Shane F. Carr | 2023-12-23T06:15:33 | Fix sizes test with latest nightly (#4490)
There are more niches than before :) | diff --git a/utils/zerovec/src/lib.rs b/utils/zerovec/src/lib.rs
index 961d62f34c..51e78b7117 100644
--- a/utils/zerovec/src/lib.rs
+++ b/utils/zerovec/src/lib.rs
@@ -550,9 +550,9 @@ mod tests {
check_size_of!(32 | 24, vecs::FlexZeroVec);
check_size_of!(32, Option<ZeroVec<u8>>);
- check_size_... | 1 | 4 | 4 |
8295762bd6891a7e641506932255cb995dc42820 | Shane F. Carr | 2023-12-21T19:28:23 | Add new type DataPayloadOr (#4463) | diff --git a/provider/core/src/lib.rs b/provider/core/src/lib.rs
index 154f27b762..a82fe1a68f 100644
--- a/provider/core/src/lib.rs
+++ b/provider/core/src/lib.rs
@@ -168,6 +168,7 @@ pub use crate::request::DataRequest;
pub use crate::request::DataRequestMetadata;
pub use crate::response::Cart;
pub use crate::respon... | 3 | 205 | 1 |
af49d9103cb8a27aefeccaed7a354c13bc622b2c | Shane F. Carr | 2023-12-21T19:12:39 | Make Yoke test work over more Rust versions (#4481) | diff --git a/utils/yoke/src/yoke.rs b/utils/yoke/src/yoke.rs
index 36138bced4..514100d66b 100644
--- a/utils/yoke/src/yoke.rs
+++ b/utils/yoke/src/yoke.rs
@@ -553,8 +553,8 @@ impl<Y: for<'a> Yokeable<'a>, C: CartablePointerLike> Yoke<Y, Option<C>> {
/// // The data struct is 6 words:
/// # #[derive(yoke::Yoke... | 1 | 2 | 2 |
7b6186b469aea4255c4c82addb540d1c256cb8e3 | Shane F. Carr | 2023-12-21T19:05:29 | Datagen: move HashSet to the trait and other small cleanups (#4473) | diff --git a/provider/datagen/src/provider.rs b/provider/datagen/src/provider.rs
index fdfc914ba5..0588d5c45b 100644
--- a/provider/datagen/src/provider.rs
+++ b/provider/datagen/src/provider.rs
@@ -271,12 +271,7 @@ impl DatagenProvider {
#[allow(deprecated)] // SourceData
self.source
.su... | 20 | 53 | 51 |
5e816b3eeb2d42f8bb04f3d3a37162dcdbc48d42 | Shane F. Carr | 2023-12-21T19:00:10 | Display elapsed time in datagen log (#4469)
Makes the output more useful/actionable. | diff --git a/provider/datagen/src/driver.rs b/provider/datagen/src/driver.rs
index 511fa06eb8..8bc2f06892 100644
--- a/provider/datagen/src/driver.rs
+++ b/provider/datagen/src/driver.rs
@@ -14,6 +14,9 @@ use once_cell::sync::Lazy;
use std::borrow::Cow;
use std::collections::HashMap;
use std::collections::HashSet;
+... | 1 | 127 | 52 |
bd36f1e696286e11779d2c04542662eb7eeb8113 | Shane F. Carr | 2023-12-19T21:05:05 | Datagen: Cache supported_locales impls (#4470) | diff --git a/Cargo.lock b/Cargo.lock
index 74db0ea4d7..2dfb7f484a 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -921,9 +921,9 @@ checksum = "a26ae43d7bcc3b814de94796a5e736d4029efb0ee900c12e2d54c993ad1a1e07"
[[package]]
name = "elsa"
-version = "1.9.0"
+version = "1.10.0"
source = "registry+https://github.com/rust-la... | 24 | 118 | 66 |
6cfe4364d60a030612bb491f09478a8958d245e5 | Shane F. Carr | 2023-12-18T22:54:05 | Print required length in ZeroTrie error (#4466) | diff --git a/experimental/zerotrie/src/builder/konst/store.rs b/experimental/zerotrie/src/builder/konst/store.rs
index e70c057531..73c72290b3 100644
--- a/experimental/zerotrie/src/builder/konst/store.rs
+++ b/experimental/zerotrie/src/builder/konst/store.rs
@@ -163,7 +163,14 @@ impl<const N: usize, T: Copy> ConstArray... | 3 | 72 | 6 |
d602a403a52c16acf6a73a70fdf206e125731a66 | Shane F. Carr | 2023-12-18T18:26:57 | Migrate DataPayload to CartableOptionPointer (#4462) | diff --git a/provider/core/src/response.rs b/provider/core/src/response.rs
index 84af08483b..428df55c5f 100644
--- a/provider/core/src/response.rs
+++ b/provider/core/src/response.rs
@@ -11,6 +11,7 @@ use core::convert::TryFrom;
use core::fmt::Debug;
use core::marker::PhantomData;
use core::ops::Deref;
+use yoke::ca... | 1 | 45 | 13 |
7a272268622284d06973435df46d0cd30ee6b60d | Manish Goregaokar | 2023-12-18T04:41:23 | Use packed data within ChineseBasedYearInfo (#4465)
Part of https://github.com/unicode-org/icu4x/issues/3933
This does not yet add data loading, but it gets very close to it.
This PR makes the size of Date not bloat too much, without requiring
much computation for any of the getters -- they're all basic bit
operatio... | diff --git a/components/calendar/src/chinese.rs b/components/calendar/src/chinese.rs
index 6d5ad4bb4d..df14c24830 100644
--- a/components/calendar/src/chinese.rs
+++ b/components/calendar/src/chinese.rs
@@ -228,64 +228,7 @@ impl Calendar for Chinese {
/// leap months. For example, in a year where an intercalary mo... | 4 | 360 | 263 |
337d268a036d7a254e80a1a3f2302dfad4fec048 | Shane F. Carr | 2023-12-15T23:57:10 | Add CartableOptionPointer and helpers to the yoke crate (#4449) | diff --git a/utils/yoke/src/cartable_ptr.rs b/utils/yoke/src/cartable_ptr.rs
new file mode 100644
index 0000000000..5695cadff8
--- /dev/null
+++ b/utils/yoke/src/cartable_ptr.rs
@@ -0,0 +1,427 @@
+// This file is part of ICU4X. For terms of use, please see the file
+// called LICENSE at the top level of the ICU4X sourc... | 3 | 511 | 1 |
46408239e13c90fa03922d17d20309add5e43d64 | Manish Goregaokar | 2023-12-15T00:20:05 | Remove dep on `fraction` (#4459) | diff --git a/Cargo.lock b/Cargo.lock
index 7d7112f911..6a5089d018 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -1087,15 +1087,6 @@ dependencies = [
"percent-encoding",
]
-[[package]]
-name = "fraction"
-version = "0.14.0"
-source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "59a78dd758a47a7... | 4 | 68 | 89 |
39139b75360d314d83326550c5746bd2b9832f4d | Manish Goregaokar | 2023-12-14T00:52:38 | Make fraction and num-bigint an optional dep of datagen (#4458) | diff --git a/provider/datagen/Cargo.toml b/provider/datagen/Cargo.toml
index 3b4ee54087..b483a32144 100644
--- a/provider/datagen/Cargo.toml
+++ b/provider/datagen/Cargo.toml
@@ -88,8 +88,8 @@ zip = { version = ">=0.5, <0.7", default-features = false, features = ["deflate"
rayon = { version = "1.5", optional = true }
... | 2 | 3 | 8 |
0b51dc1ca434fddb541c4cf57aa1b72089636d09 | Manish Goregaokar | 2023-12-13T21:21:44 | Flesh out safety docs around carts (#4455) | diff --git a/utils/yoke/src/yoke.rs b/utils/yoke/src/yoke.rs
index 22f14d3dc1..74c14be82e 100644
--- a/utils/yoke/src/yoke.rs
+++ b/utils/yoke/src/yoke.rs
@@ -304,6 +304,14 @@ impl<Y: for<'a> Yokeable<'a>, C> Yoke<Y, C> {
/// - `f()` must not panic
/// - References from the yokeable `Y` should still be valid ... | 1 | 13 | 3 |
efed14b822bd0f3da2f4e9b1754074fb3724d6ef | Younies Mahmoud | 2023-12-13T10:51:01 | Split `MeasureUnit` into `MeasureUnitParser` and `MeasureUnit` (#4391) | diff --git a/experimental/unitsconversion/src/measureunit.rs b/experimental/unitsconversion/src/measureunit.rs
index fce1bb3bfa..5ad00aa8c9 100644
--- a/experimental/unitsconversion/src/measureunit.rs
+++ b/experimental/unitsconversion/src/measureunit.rs
@@ -13,14 +13,21 @@ use crate::{
ConversionError,
};
-// ... | 3 | 39 | 21 |
4b0000b4db629fb1148a3965d7145e9c5846c46f | Zibi Braniecki | 2023-12-13T10:49:32 | Inline locid AsRef (#4450)
While porting https://github.com/projectfluent/fluent-langneg-rs to
icu_locid I noticed a major performance impact of inlining `AsRef`.
This patch speeds up language negotiation in that crate by 16%:
```
negotiate time: [746.45 ns 758.98 ns 782.69 ns]
... | diff --git a/components/locid/src/langid.rs b/components/locid/src/langid.rs
index f0fdc50320..22f0f8956d 100644
--- a/components/locid/src/langid.rs
+++ b/components/locid/src/langid.rs
@@ -401,6 +401,7 @@ impl LanguageIdentifier {
}
impl AsRef<LanguageIdentifier> for LanguageIdentifier {
+ #[inline(always)]
... | 2 | 2 | 0 |
41fefd230bae2237679194ce09d0725de58688f9 | Younies Mahmoud | 2023-12-13T09:27:16 | Move icu_unitsconversion to the correct alphabetical place in registry.rs (#4447) | diff --git a/provider/datagen/src/registry.rs b/provider/datagen/src/registry.rs
index 656c8a135a..d352fc6593 100644
--- a/provider/datagen/src/registry.rs
+++ b/provider/datagen/src/registry.rs
@@ -157,8 +157,6 @@ macro_rules! registry {
registry!(
#[cfg(test)]
icu_dimension::provider::CurrencyEssentialsV1M... | 1 | 2 | 2 |
c33f44ce403a19b4bf2910eb1baa4f86a177c1b0 | Shane F. Carr | 2023-12-12T02:45:22 | Add Writeable::write_cmp_bytes and use it in DataLocale and Locale (#4402) | diff --git a/Cargo.lock b/Cargo.lock
index 2f760fad7b..1b55035bdc 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -1895,6 +1895,7 @@ name = "icu_provider"
version = "1.4.0"
dependencies = [
"bincode",
+ "criterion",
"databake",
"displaydoc",
"erased-serde",
diff --git a/components/locid/src/extensions/unicode/key... | 13 | 305 | 49 |
e3c9f9d3bd4a36a774929a6e5df8e8f8002d8db1 | Shane F. Carr | 2023-12-09T00:00:01 | Refactoring in DateTimePatternInterpolator (#4433) | diff --git a/components/datetime/src/format/neo.rs b/components/datetime/src/format/neo.rs
index 12dbd71b78..a25ce9479c 100644
--- a/components/datetime/src/format/neo.rs
+++ b/components/datetime/src/format/neo.rs
@@ -88,7 +88,7 @@ where
impl<S, M> OptionalNames<S, DataPayload<M>>
where
S: Copy,
- M: KeyedDa... | 4 | 413 | 234 |
a340601fd81a3633eec00ab1218f585521c0a041 | Shane F. Carr | 2023-12-08T00:18:32 | Make some traits pub(crate) if they are able to be made pub(crate) (#4339) | diff --git a/components/datetime/src/datetime.rs b/components/datetime/src/datetime.rs
index 51d54dd495..73967b2b46 100644
--- a/components/datetime/src/datetime.rs
+++ b/components/datetime/src/datetime.rs
@@ -20,7 +20,7 @@ use icu_provider::prelude::*;
use writeable::Writeable;
use crate::{
- calendar, input::... | 3 | 4 | 3 |
9c82155e5b757ca7a89a5221c12b4d22d96c5f63 | Manish Goregaokar | 2023-12-07T18:21:35 | Add YearInfo to CalendarArithmetic (but don't use it yet in any calendar) (#4407)
This is mostly a scaffolding PR implementing the first few steps of
https://github.com/unicode-org/icu4x/issues/3933#issuecomment-1830962051.
This:
- Adds a YearInfo type that is stored in CalendarArithmetic and needs to
be compu... | diff --git a/components/calendar/src/calendar_arithmetic.rs b/components/calendar/src/calendar_arithmetic.rs
index 46bda3fc98..8520cd6c98 100644
--- a/components/calendar/src/calendar_arithmetic.rs
+++ b/components/calendar/src/calendar_arithmetic.rs
@@ -3,34 +3,79 @@
// (online at: https://github.com/unicode-org/icu4... | 12 | 152 | 52 |
53e3af33d77adf72b52bab3e3a3e4594715934b1 | Robert Bastian | 2023-12-07T14:40:37 | Using an enum for rule break state (#4401)
Co-authored-by: Robin Leroy <egg.robin.leroy@gmail.com> | diff --git a/components/segmenter/src/lib.rs b/components/segmenter/src/lib.rs
index b286c4e312..c0614568c8 100644
--- a/components/segmenter/src/lib.rs
+++ b/components/segmenter/src/lib.rs
@@ -130,10 +130,6 @@ mod word;
pub mod provider;
-// icu_datagen uses symbols, but we don't want to expose this implementati... | 9 | 477 | 493 |
011c630f395d5e0d7875381159b157ef8a487fe6 | Shane F. Carr | 2023-12-07T11:40:22 | Add more Eq impls to datetime pattern types (#4416) | diff --git a/components/datetime/src/pattern/item/generic.rs b/components/datetime/src/pattern/item/generic.rs
index b421b013d0..7cdf9eb4bf 100644
--- a/components/datetime/src/pattern/item/generic.rs
+++ b/components/datetime/src/pattern/item/generic.rs
@@ -2,7 +2,7 @@
// called LICENSE at the top level of the ICU4X ... | 4 | 4 | 4 |
9baa32a0ece6c59c555190cbff3c74509a248ff1 | Shane F. Carr | 2023-12-05T20:28:34 | Make CldrCalendar trait sealed except with experimental feature (#4392)
Fixes #4341 | diff --git a/components/datetime/src/calendar.rs b/components/datetime/src/calendar.rs
index a156c471ce..8aff938e3b 100644
--- a/components/datetime/src/calendar.rs
+++ b/components/datetime/src/calendar.rs
@@ -19,6 +19,18 @@ use tinystr::{tinystr, TinyAsciiStr};
#[cfg(feature = "experimental")]
use crate::provider::... | 2 | 33 | 1 |
f50e87f916f09a0123a2fd0e01fcb312b9f405b5 | Shane F. Carr | 2023-12-05T09:36:19 | ZeroTrie: Add cursor type for manual iteration and use it in BlobSchemaV2 (#4383)
Fixes #4249
Fixes #4379 | diff --git a/experimental/zerotrie/src/cursor.rs b/experimental/zerotrie/src/cursor.rs
new file mode 100644
index 0000000000..a7a8864541
--- /dev/null
+++ b/experimental/zerotrie/src/cursor.rs
@@ -0,0 +1,210 @@
+// This file is part of ICU4X. For terms of use, please see the file
+// called LICENSE at the top level of ... | 4 | 301 | 4 |
aadc9be000b46edfca903560b546104498d5483b | Robert Bastian | 2023-12-04T13:41:12 | Exclude baked data sources from rustdoc (#4396)
The baked source converted to HTML adds up to dozens of MB and has no
value as it's not readable. | diff --git a/provider/baked/_template_/src/lib.rs b/provider/baked/_template_/src/lib.rs
index 60d17cde01..76436affac 100644
--- a/provider/baked/_template_/src/lib.rs
+++ b/provider/baked/_template_/src/lib.rs
@@ -5,6 +5,8 @@
//! Data for the icu__component_ crate
#![no_std]
+// The source is not readable and is m... | 16 | 32 | 0 |
75848da5dd4a03426f73d7e160a1e0b447c93cc5 | Shane F. Carr | 2023-12-01T21:15:14 | ZeroTrie: Refactor helpers to not require as many Options (#4382) | diff --git a/experimental/zerotrie/src/byte_phf/mod.rs b/experimental/zerotrie/src/byte_phf/mod.rs
index cbbb01a175..e162364101 100644
--- a/experimental/zerotrie/src/byte_phf/mod.rs
+++ b/experimental/zerotrie/src/byte_phf/mod.rs
@@ -213,12 +213,12 @@ where
if n == 0 {
return None;
}
- ... | 5 | 146 | 117 |
af4584dab9e6a9d015c4020c78ef00e77ab68584 | Robin Leroy | 2023-12-01T19:40:55 | Remove the hardcoded line breaking state constants that are both wrong and unused (#4400)
Something should still be done about #1637 eventually, but since the
higher states have been renumbered by #4389, let’s not leave them around
for someone to trip over. Since we have not yet migrated those
properties to 15.1, t... | diff --git a/components/segmenter/src/symbols.rs b/components/segmenter/src/symbols.rs
index b2c9a2450f..abb15b6a52 100644
--- a/components/segmenter/src/symbols.rs
+++ b/components/segmenter/src/symbols.rs
@@ -102,34 +102,6 @@ pub const XX: u8 = 45;
pub const ZW: u8 = 46;
#[allow(dead_code)]
pub const ZWJ: u8 = 47;... | 1 | 0 | 28 |
a9b01f01cc2a8e05645c672128f7a8724db05677 | Robert Bastian | 2023-12-01T19:29:21 | Remove `IanaToBcp47MapperBorrowed::get_bytes` (#4398)
Fixes #4368 | diff --git a/components/timezone/src/iana_ids.rs b/components/timezone/src/iana_ids.rs
index 616e486b9d..5514a00508 100644
--- a/components/timezone/src/iana_ids.rs
+++ b/components/timezone/src/iana_ids.rs
@@ -105,15 +105,10 @@ impl<'a> IanaToBcp47MapperBorrowed<'a> {
///
/// [ECMAScript Temporal]: https://t... | 2 | 10 | 13 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.