commit_hash stringlengths 40 40 | author stringlengths 1 57 | date timestamp[s]date 2010-07-26 04:45:09 2026-04-14 18:21:10 | message stringlengths 8 1.39M | diff stringlengths 68 51.2k | files_changed int64 1 136 | insertions int64 0 2.35k | deletions int64 0 1.9k |
|---|---|---|---|---|---|---|---|
92f106d2bdb44a0394dceb68b43b934fb5c6d407 | Cameron Mulhern | 2024-07-01T21:24:04 | Fixes initialization of SimpleLogger in `icu4x-datagen` (#5152) | diff --git a/provider/icu4x-datagen/src/main.rs b/provider/icu4x-datagen/src/main.rs
index 43417e0b4e..0d576f55ce 100644
--- a/provider/icu4x-datagen/src/main.rs
+++ b/provider/icu4x-datagen/src/main.rs
@@ -279,8 +279,8 @@ fn main() -> eyre::Result<()> {
.unwrap()
} else {
SimpleLogger::new()... | 1 | 1 | 1 |
a65c5f58aba8a087f84a90ab00efa92587992740 | Robert Bastian | 2024-07-01T16:49:36 | Make `DataPayload<ExportMarker>: Hash` (#5160)
This allows putting it in a `HashMap`, as well as compute a stability
hash. | diff --git a/provider/baked/src/export.rs b/provider/baked/src/export.rs
index d4c1c52983..79034167ca 100644
--- a/provider/baked/src/export.rs
+++ b/provider/baked/src/export.rs
@@ -154,9 +154,12 @@ pub struct BakedExporter {
pretty: bool,
use_separate_crates: bool,
use_internal_fallback: bool,
- // ... | 6 | 68 | 29 |
d7461c67aeeab3822c7d1b7ff9b5d4c1331f4411 | Younies Mahmoud | 2024-07-01T10:27:33 | Fix `to_unaligned` fn for PatternKey (#5156) | diff --git a/components/experimental/src/dimension/provider/pattern_key.rs b/components/experimental/src/dimension/provider/pattern_key.rs
index fe4f8bb389..a35209be77 100644
--- a/components/experimental/src/dimension/provider/pattern_key.rs
+++ b/components/experimental/src/dimension/provider/pattern_key.rs
@@ -123,7... | 1 | 9 | 1 |
c81bb30ba967e5ea68e4e925704cb6e6a8789dd0 | Robert Bastian | 2024-07-01T09:13:13 | Audit or fix ignored tests (#5138)
#3734 | diff --git a/components/calendar/src/islamic.rs b/components/calendar/src/islamic.rs
index a83286fd2b..9a00e00ea0 100644
--- a/components/calendar/src/islamic.rs
+++ b/components/calendar/src/islamic.rs
@@ -2149,7 +2149,7 @@ mod test {
}
}
- #[ignore]
+ #[ignore] // slow
#[test]
fn test_... | 6 | 55 | 41 |
8f2f35dc15c101aad9cf1975909db76ec8b87ce2 | Younies Mahmoud | 2024-06-27T17:18:52 | Implement `UnitsFormatter` (#5000) | diff --git a/components/experimental/src/dimension/mod.rs b/components/experimental/src/dimension/mod.rs
index d1149b0037..9cb03b0569 100644
--- a/components/experimental/src/dimension/mod.rs
+++ b/components/experimental/src/dimension/mod.rs
@@ -6,3 +6,4 @@
pub mod currency;
pub mod provider;
+pub mod units;
diff ... | 6 | 314 | 0 |
b391147497616d30a3afd8d9dccafe98f4f17313 | Younies Mahmoud | 2024-06-27T14:02:03 | Remove unneeded error conversion (#5137) | diff --git a/components/experimental/src/dimension/currency/formatter.rs b/components/experimental/src/dimension/currency/formatter.rs
index 7a490b2445..17d2d26cfe 100644
--- a/components/experimental/src/dimension/currency/formatter.rs
+++ b/components/experimental/src/dimension/currency/formatter.rs
@@ -63,13 +63,7 @... | 1 | 2 | 12 |
3f41fa1384a01779b2260269dea6d997976ecd9c | Younies Mahmoud | 2024-06-27T14:01:25 | Implement `PluralCategory` for units displaynames `Count` (#5135) | diff --git a/components/experimental/src/dimension/provider/units.rs b/components/experimental/src/dimension/provider/units.rs
index 7503265acf..441c694ec2 100644
--- a/components/experimental/src/dimension/provider/units.rs
+++ b/components/experimental/src/dimension/provider/units.rs
@@ -9,6 +9,7 @@
//!
//! Read mo... | 1 | 15 | 0 |
e298617dc032a60b16622de02513f7e83b365e59 | Younies Mahmoud | 2024-06-27T10:36:35 | Refactor: Update `PatternKey` enum to use named fields (#5133) | diff --git a/components/experimental/src/dimension/provider/pattern_key.rs b/components/experimental/src/dimension/provider/pattern_key.rs
index 89bb15d2b2..fe4f8bb389 100644
--- a/components/experimental/src/dimension/provider/pattern_key.rs
+++ b/components/experimental/src/dimension/provider/pattern_key.rs
@@ -36,7 ... | 1 | 32 | 9 |
7b1f5208b46ebb83545402cefa40146b0b1759bc | Younies Mahmoud | 2024-06-26T11:59:10 | Run validate_byte_slice for each byte (#5129) | diff --git a/components/experimental/src/dimension/provider/pattern_key.rs b/components/experimental/src/dimension/provider/pattern_key.rs
index 8f4a243fad..89bb15d2b2 100644
--- a/components/experimental/src/dimension/provider/pattern_key.rs
+++ b/components/experimental/src/dimension/provider/pattern_key.rs
@@ -79,35... | 1 | 22 | 26 |
0d381add2eb3568cb10f0ce8f07af0491a3fe934 | Younies Mahmoud | 2024-06-26T11:58:48 | Add needed comments to PatternKeyULE (#5128) | diff --git a/components/experimental/src/dimension/provider/pattern_key.rs b/components/experimental/src/dimension/provider/pattern_key.rs
index 2041e29f9a..8f4a243fad 100644
--- a/components/experimental/src/dimension/provider/pattern_key.rs
+++ b/components/experimental/src/dimension/provider/pattern_key.rs
@@ -68,6 ... | 1 | 22 | 0 |
bdead5995c9641581c863d9db16c62de1089a249 | Shane F. Carr | 2024-06-26T09:46:47 | Add test about negative extended years (#5087) | diff --git a/components/calendar/src/gregorian.rs b/components/calendar/src/gregorian.rs
index 9571d3c78e..ed11979d95 100644
--- a/components/calendar/src/gregorian.rs
+++ b/components/calendar/src/gregorian.rs
@@ -54,7 +54,7 @@ pub struct Gregorian;
#[derive(Copy, Clone, Debug, Hash, Eq, PartialEq, PartialOrd, Ord)... | 2 | 18 | 1 |
8e7e8e76448a343aad84f4a492203e42768dd0e7 | Shane F. Carr | 2024-06-25T21:22:28 | Add TimeZoneFallbackOverride date field length; use NeoTimeZoneSkeleton (#5024)
#1317 | diff --git a/components/datetime/src/fields/length.rs b/components/datetime/src/fields/length.rs
index 4e4c8418e5..3a9ca12e87 100644
--- a/components/datetime/src/fields/length.rs
+++ b/components/datetime/src/fields/length.rs
@@ -54,6 +54,8 @@ pub enum FieldLength {
Fixed(u8),
/// FieldLength::One (numeric),... | 10 | 248 | 138 |
b8883620ddcb34fff7f4bfb7194424ed98f9da7a | Younies Mahmoud | 2024-06-25T20:42:48 | Implement `UnitsEssentials` Data Provider (#5002) | diff --git a/components/experimental/src/dimension/provider/mod.rs b/components/experimental/src/dimension/provider/mod.rs
index 52642f3932..495f5401c4 100644
--- a/components/experimental/src/dimension/provider/mod.rs
+++ b/components/experimental/src/dimension/provider/mod.rs
@@ -4,6 +4,8 @@
pub mod currency;
pub... | 3 | 308 | 0 |
a4895e16b7aae9199dc7c4f5d3bd7c752a6c1d24 | Shane F. Carr | 2024-06-25T19:00:07 | Minor improvement to zerotrie hash function (#5106) | diff --git a/utils/zerotrie/src/byte_phf/builder.rs b/utils/zerotrie/src/byte_phf/builder.rs
index 20a8eecba0..69b97818d2 100644
--- a/utils/zerotrie/src/byte_phf/builder.rs
+++ b/utils/zerotrie/src/byte_phf/builder.rs
@@ -18,21 +18,29 @@ const MAX_L2_SEARCH_MISSES: usize = 24;
/// Returns `(p, [q_0, q_1, ..., q_(N-1)... | 3 | 56 | 52 |
87ec198dc671e11a0d29dd841d7ba2645e5646af | Shane F. Carr | 2024-06-25T17:39:44 | Improve docs on ZeroVecError (#5117)
#5002 | diff --git a/utils/zerovec/src/error.rs b/utils/zerovec/src/error.rs
index 85de3ecc8d..0511625489 100644
--- a/utils/zerovec/src/error.rs
+++ b/utils/zerovec/src/error.rs
@@ -10,11 +10,24 @@ use core::fmt;
#[non_exhaustive]
pub enum ZeroVecError {
/// Attempted to parse a buffer into a slice of the given ULE typ... | 1 | 16 | 3 |
5eb16ba1ff434f6e1c3fc78e89dbb8e36fd4a143 | Manish Goregaokar | 2024-06-25T16:01:54 | Fix libc_alloc linking (#5119) | diff --git a/ffi/capi/Cargo.toml b/ffi/capi/Cargo.toml
index cd3fb1b34f..a17afea274 100644
--- a/ffi/capi/Cargo.toml
+++ b/ffi/capi/Cargo.toml
@@ -143,8 +143,8 @@ log = { workspace = true, optional = true }
[target.'cfg(not(target_arch = "wasm32"))'.dependencies]
# Logging uses diplomat_runtime bindings in wasm, we o... | 1 | 1 | 1 |
30c23cd362c86863aab363b2c3937a200ccfbcd9 | Robert Bastian | 2024-06-25T15:29:48 | Remove `DataMarkerInfo`'s `Display` implementation (#5118)
I want to be explicit about code that actually requires the
`DataKeyPath`. Most code just needs a `Debug` implementation for
logging. | diff --git a/provider/baked/src/export.rs b/provider/baked/src/export.rs
index b6e56c423f..758c9020ad 100644
--- a/provider/baked/src/export.rs
+++ b/provider/baked/src/export.rs
@@ -677,12 +677,12 @@ impl DataExporter for BakedExporter {
macro_rules! cb {
($($marker:path = $path:literal,)+ #[experimental] $($ema... | 12 | 51 | 79 |
c824452bfd69a253bc697bf27d42bce58c4e8d3f | Joonas Satka | 2024-06-25T13:34:12 | Fix integer overflow for `LiteMap` by using correct `Store` trait method (#5113)
In the latest version calling `last()` on empty `LiteMap` panics on
attempt to subtract with overflow.
The correct method that should be called internally is `Store` trait
method `lm_last()`. | diff --git a/utils/litemap/src/map.rs b/utils/litemap/src/map.rs
index b5abd39b99..793987bf37 100644
--- a/utils/litemap/src/map.rs
+++ b/utils/litemap/src/map.rs
@@ -124,7 +124,7 @@ where
/// ```
#[inline]
pub fn last(&self) -> Option<(&K, &V)> {
- self.values.lm_get(self.len() - 1)
+ self... | 1 | 1 | 1 |
125ef71528433d93a22af79b2622bb7366d2452a | Younies Mahmoud | 2024-06-24T21:32:32 | Move unsafe implementations to be in one place. (#5104) | diff --git a/utils/pattern/src/frontend/mod.rs b/utils/pattern/src/frontend/mod.rs
index e2d6bcf08f..2d0df63c28 100644
--- a/utils/pattern/src/frontend/mod.rs
+++ b/utils/pattern/src/frontend/mod.rs
@@ -191,47 +191,6 @@ where
}
}
-impl<B> Pattern<B, B::Store>
-where
- B: PatternBackend,
-{
- /// Creates a... | 2 | 40 | 43 |
4eeb7b7ab2a148c6ff37918a5a246af3759d4fd1 | Luca Versari | 2024-06-22T06:50:43 | Yoke: unsafe review / safety doc improvements (#5046)
Co-authored-by: Manish Goregaokar <manishsmail@gmail.com> | diff --git a/utils/yoke/src/cartable_ptr.rs b/utils/yoke/src/cartable_ptr.rs
index a7b3b844b0..24bf6d312c 100644
--- a/utils/yoke/src/cartable_ptr.rs
+++ b/utils/yoke/src/cartable_ptr.rs
@@ -30,9 +30,17 @@ use core::marker::PhantomData;
use core::ptr::NonNull;
use stable_deref_trait::StableDeref;
+// Safety note: t... | 7 | 223 | 100 |
6adbdf58e10d72d8372b0e1db2363a3e76a2990e | Younies Mahmoud | 2024-06-21T15:11:02 | Add illustrative comment for unit `Patterns` (#5073) | diff --git a/provider/bikeshed/src/cldr_serde/units/data.rs b/provider/bikeshed/src/cldr_serde/units/data.rs
index b2f6625a86..30b507c04b 100644
--- a/provider/bikeshed/src/cldr_serde/units/data.rs
+++ b/provider/bikeshed/src/cldr_serde/units/data.rs
@@ -10,7 +10,10 @@
use serde::Deserialize;
use std::collections::BT... | 1 | 4 | 1 |
ba0bcd1dc00b6ad8b32c6ab5cbeea3d64637df97 | Younies Mahmoud | 2024-06-21T14:41:17 | Implement `ZeroMapKV` for `Pattern<SinglePlaceholder, str>` (#5030) | diff --git a/utils/pattern/Cargo.toml b/utils/pattern/Cargo.toml
index e4139592f3..7b02b8364c 100644
--- a/utils/pattern/Cargo.toml
+++ b/utils/pattern/Cargo.toml
@@ -29,6 +29,7 @@ litemap = { workspace = true, default-features = false, optional = true }
serde = { workspace = true, features = ["derive", "alloc"], opti... | 3 | 49 | 0 |
534936194ef856ba18b62eb7e2ff78dbca436a8a | Robert Bastian | 2024-06-21T14:20:39 | Fix nightly clippy (#5094) | diff --git a/components/datetime/src/external_loaders.rs b/components/datetime/src/external_loaders.rs
index 8897a40c1c..f1d565e860 100644
--- a/components/datetime/src/external_loaders.rs
+++ b/components/datetime/src/external_loaders.rs
@@ -35,35 +35,6 @@ pub(crate) trait AnyCalendarLoader {
fn load(&self, local... | 21 | 58 | 88 |
85ee7bc03124db0978a69d89ffcb49a1f1597f94 | Robert Bastian | 2024-06-21T09:17:10 | Fix datetime bench (#5097) | diff --git a/components/datetime/benches/datetime.rs b/components/datetime/benches/datetime.rs
index 9ee313ac6c..d4786dd67f 100644
--- a/components/datetime/benches/datetime.rs
+++ b/components/datetime/benches/datetime.rs
@@ -9,15 +9,20 @@ use criterion::{criterion_group, criterion_main, Criterion};
use icu_datetime:... | 1 | 6 | 1 |
0ea945efe11a51143b95cfa0fa674065900719b9 | Manish Goregaokar | 2024-06-20T22:08:15 | Update displaydoc (#5093)
Should fix the nonlocal impl warnings on nightly/beta.
Pulls in https://github.com/yaahc/displaydoc/pull/47 | diff --git a/Cargo.lock b/Cargo.lock
index 8b191fc1b2..de4e71fee5 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -662,9 +662,9 @@ dependencies = [
[[package]]
name = "displaydoc"
-version = "0.2.4"
+version = "0.2.5"
source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "487585f4d0c6655fe74905e... | 1 | 2 | 2 |
e053097c171abd1fe5942b253d7215baeb520f32 | Manish Goregaokar | 2024-06-20T18:04:15 | Fix beta rustfmt breakage (#5090)
<!--
Thank you for your pull request to ICU4X!
Reminder: try to use [Conventional
Comments](https://conventionalcomments.org/) to make comments clearer.
Please see
https://github.com/unicode-org/icu4x/blob/main/CONTRIBUTING.md for
general
information on contributing to ICU4... | diff --git a/provider/core/src/hello_world.rs b/provider/core/src/hello_world.rs
index ab46c84a86..42bbcb0d76 100644
--- a/provider/core/src/hello_world.rs
+++ b/provider/core/src/hello_world.rs
@@ -106,12 +106,18 @@ impl HelloWorldProvider {
("de-AT", "", "Servus Welt"),
("el", "", "Καλημέρα κόσμε"),... | 1 | 12 | 6 |
4b035c0cdfc958184ee2c1df165fc0383f80ee00 | Shane F. Carr | 2024-06-19T20:44:40 | Start upgrading old time zone code to new traits/structs/enums (#5027) | diff --git a/components/datetime/src/format/datetime.rs b/components/datetime/src/format/datetime.rs
index 708e0634e3..264d7112f1 100644
--- a/components/datetime/src/format/datetime.rs
+++ b/components/datetime/src/format/datetime.rs
@@ -301,6 +301,9 @@ pub enum DateTimeWriteError {
/// Missing weekday symbol
... | 9 | 220 | 168 |
25e90945ee080abadc9d070addc5719a05db983b | Manish Goregaokar | 2024-06-19T13:34:16 | Leftover nightly fixes (#5077)
The displaydoc warnings need
https://github.com/yaahc/displaydoc/pull/47, but I don't think they
break non-clippy CI for us, and I'm working on getting that published. | diff --git a/ffi/freertos/Cargo.toml b/ffi/freertos/Cargo.toml
index cd04729a92..dab18d2aed 100644
--- a/ffi/freertos/Cargo.toml
+++ b/ffi/freertos/Cargo.toml
@@ -43,3 +43,6 @@ default = ["icu_capi/default_components"]
[build-dependencies]
rustc_version = "0.4"
+
+[lints.rust]
+unexpected_cfgs = { level = "warn", c... | 3 | 6 | 2 |
b935818b32171904bed6ddb51b0d0dfc09ed76c6 | Manish Goregaokar | 2024-06-18T20:57:29 | Get rid of cfg(skip) (#5076)
It was a hack and it breaks rustc-check-cfg, let's not do that anymore.
This is based on https://github.com/unicode-org/icu4x/pull/5075/ so that
I can test this works with beta/nightly | diff --git a/components/calendar/src/any_calendar.rs b/components/calendar/src/any_calendar.rs
index ddabcea251..92f8c9c13d 100644
--- a/components/calendar/src/any_calendar.rs
+++ b/components/calendar/src/any_calendar.rs
@@ -756,9 +756,8 @@ impl AnyCalendar {
icu_provider::gen_any_buffer_data_constructors!(
... | 30 | 103 | 121 |
c923bbd36d77c09def031dd1e084e97dcf42dfbd | Younies Mahmoud | 2024-06-18T19:26:32 | implement `from_borrowed_store_unchecked` fn (#5072) | diff --git a/utils/pattern/src/frontend/mod.rs b/utils/pattern/src/frontend/mod.rs
index a23f3c0013..a67d415538 100644
--- a/utils/pattern/src/frontend/mod.rs
+++ b/utils/pattern/src/frontend/mod.rs
@@ -191,6 +191,47 @@ where
}
}
+impl<B> Pattern<B, B::Store>
+where
+ B: PatternBackend,
+{
+ /// Creates a... | 1 | 41 | 0 |
687e178f434c14bf772eef7ce995e14e0b300f94 | Robert Bastian | 2024-06-18T16:01:07 | Remove primitive type imports, i.e. `core::str`, `core::i16`. (#5071)
The only place these are needed is `core::str::from_utf8[_unchecked]`,
which is only available in the `core::str` module, not in the `str`
type. We do pretty consistently fully qualify these methods though, so I
changed the remaining calls to do ... | diff --git a/components/experimental/src/transliterate/transliterator/mod.rs b/components/experimental/src/transliterate/transliterator/mod.rs
index 9b304f9623..40fbf082c0 100644
--- a/components/experimental/src/transliterate/transliterator/mod.rs
+++ b/components/experimental/src/transliterate/transliterator/mod.rs
@... | 10 | 15 | 25 |
e973fcba95a7c7d2865e904cb6c6796affebc33f | Manish Goregaokar | 2024-06-18T15:34:39 | Cleaner gen_any_buffer_data_constructors macro (#5067) | diff --git a/components/calendar/src/any_calendar.rs b/components/calendar/src/any_calendar.rs
index 27d4ea110f..ddabcea251 100644
--- a/components/calendar/src/any_calendar.rs
+++ b/components/calendar/src/any_calendar.rs
@@ -755,9 +755,7 @@ impl AnyCalendar {
}
icu_provider::gen_any_buffer_data_constructo... | 35 | 125 | 336 |
6d65cb511267b5f7b91fd18db120a37f44ddf615 | Manish Goregaokar | 2024-06-16T20:19:50 | Enforce C,packed, not just packed, on ULE types (#5049)
Fixes https://github.com/unicode-org/icu4x/issues/5039
Caused by https://github.com/rust-lang/rust/pull/125360. We were
assuming that `packed` meant `C, packed` already. This is an assumption
I've seen throughout the Rust ecosystem so there may be reasons to
r... | diff --git a/components/calendar/src/provider/chinese_based.rs b/components/calendar/src/provider/chinese_based.rs
index ebf83436f9..3e2807b622 100644
--- a/components/calendar/src/provider/chinese_based.rs
+++ b/components/calendar/src/provider/chinese_based.rs
@@ -143,7 +143,7 @@ impl<'data> ChineseBasedCacheV1<'data... | 13 | 53 | 29 |
21efbaeb5eb4c5e53c9772a4e6a38ad55eaa0a63 | Younies Mahmoud | 2024-06-14T10:59:51 | Implement `try_from_bytes` for Pattern (#5034) | diff --git a/utils/pattern/src/common.rs b/utils/pattern/src/common.rs
index 5d93b87b3e..06a773b2e6 100644
--- a/utils/pattern/src/common.rs
+++ b/utils/pattern/src/common.rs
@@ -75,6 +75,9 @@ pub trait PatternBackend: crate::private::Sealed + 'static {
/// The type of error that the [`TryWriteable`] for this back... | 8 | 74 | 12 |
8f9bda40d99cbee6a0ea9e6e206a72659c150af8 | Robert Bastian | 2024-06-13T19:05:11 | Improve auxkey bench (#5048) | diff --git a/Cargo.lock b/Cargo.lock
index e9b4cab908..58c133ba6d 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -1514,9 +1514,8 @@ name = "icu_provider_blob"
version = "1.5.0"
dependencies = [
"criterion",
+ "databake",
"icu_datagen",
- "icu_datetime",
- "icu_datetime_data",
"icu_locale",
"icu_locale_core",
"... | 4 | 304 | 115 |
24554d01854e4b4b8e20fd5c75e372e5c4aa0658 | Robert Bastian | 2024-06-13T18:34:28 | Assembling `requested_families` earlier (#5043) | diff --git a/components/locale_core/src/langid.rs b/components/locale_core/src/langid.rs
index 1308f85c12..488ae2a01d 100644
--- a/components/locale_core/src/langid.rs
+++ b/components/locale_core/src/langid.rs
@@ -144,6 +144,14 @@ impl LanguageIdentifier {
variants: subtags::Variants::new(),
};
+ //... | 5 | 154 | 187 |
3ba8f0f064d5d5e5900e5560d4b396d2a0cf6462 | Robert Bastian | 2024-06-12T13:09:25 | Removing `TryFrom<DataResponse<M>> for DataPayload<M>` (#5044) | diff --git a/provider/core/src/response.rs b/provider/core/src/response.rs
index 3fd36b38e4..ab3e30abe6 100644
--- a/provider/core/src/response.rs
+++ b/provider/core/src/response.rs
@@ -7,7 +7,6 @@ use crate::error::DataError;
use crate::marker::DynamicDataMarker;
use crate::request::DataLocale;
use alloc::boxed::B... | 1 | 0 | 12 |
cbf0032bee6933bb1e54a6a74df2f8624f391d37 | Zibi Braniecki | 2024-06-10T23:45:46 | Add constructing TinyAsciiStr from utf16 (#5025)
Introduces TinyAsciiStr constructors from utf16 and converges on the
consensus from #4931.
---------
Co-authored-by: Robert Bastian <4706271+robertbastian@users.noreply.github.com> | diff --git a/components/calendar/src/types.rs b/components/calendar/src/types.rs
index 5305ecaef4..c452f837e2 100644
--- a/components/calendar/src/types.rs
+++ b/components/calendar/src/types.rs
@@ -113,7 +113,7 @@ impl MonthCode {
pub fn get_normal_if_leap(self) -> Option<MonthCode> {
let bytes = self.0.... | 18 | 214 | 69 |
37c4c2e6668c57bab5149d4df52be8a1bf82d9af | Kart | 2024-06-10T15:39:06 | feat(duration): add formatter options (#4998)
- add `duration/options.rs`
follow up to #4978
@younies @sffc | diff --git a/components/experimental/src/duration/mod.rs b/components/experimental/src/duration/mod.rs
index f8eafc6816..272e790df2 100644
--- a/components/experimental/src/duration/mod.rs
+++ b/components/experimental/src/duration/mod.rs
@@ -7,5 +7,6 @@
#![warn(missing_docs)]
mod duration;
+pub mod options;
pub... | 2 | 247 | 0 |
0c41f619fbce715329001cf6a062595545529b48 | Kart | 2024-06-07T07:10:00 | feat(duration): create experimental/duration (#4978) | diff --git a/components/experimental/src/duration/duration.rs b/components/experimental/src/duration/duration.rs
new file mode 100644
index 0000000000..a5309d9c9d
--- /dev/null
+++ b/components/experimental/src/duration/duration.rs
@@ -0,0 +1,62 @@
+// This file is part of ICU4X. For terms of use, please see the file
+... | 3 | 74 | 0 |
af508f52121f17eab0aea7d0c3d7eb551cb7d0e6 | Shane F. Carr | 2024-06-06T02:03:52 | Make ComponentsStruct the type itself for better inference (#5014)
#1317 | diff --git a/components/datetime/benches/datetime.rs b/components/datetime/benches/datetime.rs
index 39018ce1d3..508ebfa0f4 100644
--- a/components/datetime/benches/datetime.rs
+++ b/components/datetime/benches/datetime.rs
@@ -8,8 +8,6 @@ use criterion::{criterion_group, criterion_main, Criterion};
#[cfg(feature = "ex... | 4 | 87 | 101 |
28e4d53a1324302b0f6831c4c3b47105dd9c88a1 | Younies Mahmoud | 2024-06-06T00:03:00 | Fix the message of transient_violations (#5012) | diff --git a/provider/datagen/src/provider/tests/make_testdata.rs b/provider/datagen/src/provider/tests/make_testdata.rs
index 6db32a2f7c..fe55338b3c 100644
--- a/provider/datagen/src/provider/tests/make_testdata.rs
+++ b/provider/datagen/src/provider/tests/make_testdata.rs
@@ -302,8 +302,9 @@ impl<F: Write + Send + Sy... | 1 | 2 | 1 |
9d7c332be0bf50d9fcf12737f16572e822033f02 | Shane F. Carr | 2024-06-04T21:55:05 | twox-hash is a dep of zerovec so it should be no_std (#5007)
Fixes size regression noted by @zbraniecki | diff --git a/Cargo.lock b/Cargo.lock
index 34ff7d7d4f..b3b53706e0 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -2698,7 +2698,6 @@ source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "97fee6b57c6a41524a810daee9286c02d7752c4253064d0b05472833a438f675"
dependencies = [
"cfg-if",
- "rand",
"stat... | 2 | 1 | 2 |
bf16483de81aa9b4b7f2911302eefca2bd279082 | Younies Mahmoud | 2024-06-04T12:03:31 | Fix link about supplemental/units.json (#4997) | diff --git a/provider/datagen/src/transform/cldr/cldr_serde/units/info.rs b/provider/datagen/src/transform/cldr/cldr_serde/units/info.rs
index 8669f4d6e5..886c52ad6d 100644
--- a/provider/datagen/src/transform/cldr/cldr_serde/units/info.rs
+++ b/provider/datagen/src/transform/cldr/cldr_serde/units/info.rs
@@ -5,7 +5,7 ... | 1 | 1 | 1 |
e83fd9b83e187f09442347f600054c95472d69a1 | iyzana | 2024-06-04T11:46:45 | fix: assert >= 14 on num days not given day (#4986)
The assert was probably meant to ensure the complete year has at least
14 days, and not that the given day is at least the 14th day of the year
Fixes: #4977 | diff --git a/components/datetime/src/input.rs b/components/datetime/src/input.rs
index 5773aa472d..07cf07dbfc 100644
--- a/components/datetime/src/input.rs
+++ b/components/datetime/src/input.rs
@@ -389,7 +389,7 @@ impl ExtractedDateTimeInput {
"iso_weekday",
))?;
// We do... | 1 | 1 | 1 |
24761aaed62d0ec06eb369517e0aedc0a02900df | Robert Bastian | 2024-06-03T22:35:01 | Follow-up #4985 (#4995) | diff --git a/provider/datagen/src/provider.rs b/provider/datagen/src/provider.rs
index 7ef99dcc1a..ab3aa736f9 100644
--- a/provider/datagen/src/provider.rs
+++ b/provider/datagen/src/provider.rs
@@ -8,6 +8,7 @@ use elsa::sync::FrozenMap;
use icu_provider::datagen::IterableDataProvider;
use icu_provider::prelude::*;
... | 23 | 102 | 67 |
fffa6242a5dec396be4b5477a415db39cc96d4e5 | Robert Bastian | 2024-06-03T21:45:46 | `BufferProvider` is `DynamicDataProvider<BufferMarker>` (#4992) | diff --git a/provider/adapters/src/either.rs b/provider/adapters/src/either.rs
index eefb0c1106..49b457e4d7 100644
--- a/provider/adapters/src/either.rs
+++ b/provider/adapters/src/either.rs
@@ -33,21 +33,6 @@ impl<P0: AnyProvider, P1: AnyProvider> AnyProvider for EitherProvider<P0, P1> {
}
}
-impl<P0: BufferPr... | 13 | 18 | 185 |
581249f14c916f8f1ad8206f25da63852eac3ecb | Zibi Braniecki | 2024-06-03T20:51:44 | Switch locid Value to use Subtag (#4941)
This is part of #1833 switching Value API to use Subtag. | diff --git a/components/calendar/src/any_calendar.rs b/components/calendar/src/any_calendar.rs
index ec222861f9..54db2b12ba 100644
--- a/components/calendar/src/any_calendar.rs
+++ b/components/calendar/src/any_calendar.rs
@@ -952,7 +952,7 @@ impl AnyCalendarKind {
/// Returns `None` if the calendar is unknown. If... | 16 | 130 | 129 |
b448129237e6efdad6f3da01242d9267a4425703 | Robert Bastian | 2024-06-03T15:27:48 | Update `AnyCalendar` constructor for 1.4 calendars (#4990) | diff --git a/components/calendar/src/any_calendar.rs b/components/calendar/src/any_calendar.rs
index eecb77d325..ec222861f9 100644
--- a/components/calendar/src/any_calendar.rs
+++ b/components/calendar/src/any_calendar.rs
@@ -1091,11 +1091,10 @@ impl AnyCalendarKind {
let lang = l.language();
... | 1 | 4 | 5 |
77da96b677276cffc6cfdf98acef2aca9a509ca6 | Zibi Braniecki | 2024-06-01T19:50:02 | Locid extensions tofromstr (#4934)
Second part of #1833.
This one cleans up from/to str for locid extensions. This prepares
ground for reuse of Subtag in Value API which will be introduced in the
next PR. | diff --git a/components/locale_core/src/extensions/mod.rs b/components/locale_core/src/extensions/mod.rs
index 2de8909a0e..d35bbe9bdd 100644
--- a/components/locale_core/src/extensions/mod.rs
+++ b/components/locale_core/src/extensions/mod.rs
@@ -52,9 +52,9 @@ pub mod unicode;
use core::cmp::Ordering;
use other::Ot... | 9 | 333 | 84 |
38d0497c817867b28e0496044bd3ed7854865d13 | Shane F. Carr | 2024-05-30T21:48:47 | Add non-optional `AnyCalendarKind` getter to `IntoAnyCalendar` (#4975) | diff --git a/components/calendar/src/any_calendar.rs b/components/calendar/src/any_calendar.rs
index ba1fa3d95f..dd49e89d76 100644
--- a/components/calendar/src/any_calendar.rs
+++ b/components/calendar/src/any_calendar.rs
@@ -1122,10 +1122,14 @@ pub trait IntoAnyCalendar: Calendar + Sized {
/// You should not nee... | 14 | 166 | 52 |
7fe5516902632f119abeb4d4fb2ffb9d57202fe7 | Younies Mahmoud | 2024-05-30T09:27:45 | Ensure that tests for unconvertible units fail as expected (#4957) | diff --git a/components/experimental/tests/units/units_test.rs b/components/experimental/tests/units/units_test.rs
index 8e36a4009f..dc381ea625 100644
--- a/components/experimental/tests/units/units_test.rs
+++ b/components/experimental/tests/units/units_test.rs
@@ -13,7 +13,6 @@ use num_traits::{Signed, ToPrimitive};
... | 1 | 175 | 26 |
d8d067de92848d71b83e682441c6668797a2f834 | Younies Mahmoud | 2024-05-30T09:27:26 | Add more unparsable units to unparsable test (#4954) | diff --git a/components/experimental/tests/units/units_test.rs b/components/experimental/tests/units/units_test.rs
index dd599b3ba7..8e36a4009f 100644
--- a/components/experimental/tests/units/units_test.rs
+++ b/components/experimental/tests/units/units_test.rs
@@ -80,20 +80,70 @@ fn test_cldr_unit_tests() {
}
#[t... | 1 | 56 | 6 |
8c7238ab4b23cf08dff4fcc278cb67b08bc3ddc8 | Shane F. Carr | 2024-05-29T21:18:58 | Split neo trait into HasComponents and other helpers (#4963) | diff --git a/components/datetime/src/input.rs b/components/datetime/src/input.rs
index 84fa65815b..c5ac84d1bb 100644
--- a/components/datetime/src/input.rs
+++ b/components/datetime/src/input.rs
@@ -248,7 +248,7 @@ impl ExtractedDateTimeInput {
#[cfg(feature = "experimental")]
pub(crate) fn extract_from_neo_i... | 3 | 401 | 123 |
de39054e54b9dda9ecd0e02e98f430d37a4f7fb4 | Zibi Braniecki | 2024-05-29T06:11:21 | Move generic Subtag to subtags (#4932)
First patch from the #1833 patchset.
It moves the `Subtag` to `locid::subtags::Subtag` - this is a generic
subtag (2..=8, separate from private::Subtag which is 1..=8) which will
be used to iterate over multi-part subtags like
`extensions::unicode::Value` to retrieve specif... | diff --git a/components/locid/src/extensions/other/mod.rs b/components/locid/src/extensions/other/mod.rs
index 8a7f36d494..f629d76ae8 100644
--- a/components/locid/src/extensions/other/mod.rs
+++ b/components/locid/src/extensions/other/mod.rs
@@ -19,14 +19,11 @@
//! let mut loc: Locale = "en-US-a-foo-faa".parse().expe... | 4 | 86 | 43 |
418ae99cac511d8efa04d73df1537585a12709da | Shane F. Carr | 2024-05-28T23:41:36 | Add Neo input markers and use them in TypedNeoFormatter (#4945)
Part of https://github.com/unicode-org/icu4x/issues/1317 | diff --git a/components/datetime/src/input.rs b/components/datetime/src/input.rs
index d412b868c3..84fa65815b 100644
--- a/components/datetime/src/input.rs
+++ b/components/datetime/src/input.rs
@@ -5,6 +5,8 @@
//! A collection of utilities for representing and working with dates as an input to
//! formatting operati... | 3 | 362 | 25 |
599f3366f901eb0cc0af9de6c9de99998734bb8a | Robert Bastian | 2024-05-28T20:46:57 | Published changes (#4958)
#4925 | diff --git a/Cargo.lock b/Cargo.lock
index 4a94750cb8..deead13b7e 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -1369,7 +1369,7 @@ version = "1.5.0"
[[package]]
name = "icu_pattern"
-version = "0.1.0"
+version = "0.2.0"
dependencies = [
"databake",
"displaydoc",
diff --git a/Cargo.toml b/Cargo.toml
index a9ef226... | 6 | 7 | 7 |
8756a3ece3c1468b3797ce00113ace7557b786e1 | Younies Mahmoud | 2024-05-28T13:36:21 | Rename `MeasureUnitParser::try_from_identifier` to `try_from_bytes` (#4952) | diff --git a/components/experimental/src/units/measureunit.rs b/components/experimental/src/units/measureunit.rs
index 92ddeb0ef4..b5392bb631 100644
--- a/components/experimental/src/units/measureunit.rs
+++ b/components/experimental/src/units/measureunit.rs
@@ -85,10 +85,7 @@ impl<'data> MeasureUnitParser<'data> {
... | 4 | 6 | 13 |
2df1324ea8ad26c748911718763e9b564c27ea5f | Younies Mahmoud | 2024-05-28T12:27:58 | Change MeasureUnit parser to work on bytes slices (#4924) | diff --git a/components/experimental/src/units/measureunit.rs b/components/experimental/src/units/measureunit.rs
index 3234bf1877..92ddeb0ef4 100644
--- a/components/experimental/src/units/measureunit.rs
+++ b/components/experimental/src/units/measureunit.rs
@@ -33,12 +33,12 @@ impl<'data> MeasureUnitParser<'data> {
... | 6 | 65 | 59 |
5bbfdf215bb4aa46a236a7317e38bfe2f92205ac | Shane F. Carr | 2024-05-25T00:26:30 | Add time and datetime to NeoFormatter; remove skeletons from old neo formatters (#4944)
Part of https://github.com/unicode-org/icu4x/issues/1317 | diff --git a/components/datetime/src/format/datetime.rs b/components/datetime/src/format/datetime.rs
index 5a8663d612..61e95c0f9d 100644
--- a/components/datetime/src/format/datetime.rs
+++ b/components/datetime/src/format/datetime.rs
@@ -204,13 +204,41 @@ pub(crate) fn try_write_pattern<'data, W, DS, TS>(
fixed_d... | 4 | 212 | 294 |
ff4658b8bcf01a7cf3bb7565dd9bee98e22b8b00 | Robert Bastian | 2024-05-24T21:06:52 | Bump diplomat to 0.8.0 (#4943)
#4925 | diff --git a/Cargo.lock b/Cargo.lock
index b0a6bbd239..1cb53c2211 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -593,8 +593,9 @@ dependencies = [
[[package]]
name = "diplomat"
-version = "0.7.0"
-source = "git+https://github.com/rust-diplomat/diplomat.git?rev=3167e39e89ae612233706f1ade3d9e8a5c6ad358#3167e39e89ae61223... | 11 | 350 | 70 |
79e4f9e06e6ccebbb76d998196530643b03d306f | Robert Bastian | 2024-05-24T18:29:09 | Don't return TinyStr errors over FFI (#4940)
TinyStr is an ICU4X implementation detail, especially over FFI. Return
domain-specific errors instead.
Also cleaned up UTF-8 errors that were being returned as IO errors. | diff --git a/ffi/capi/src/casemap.rs b/ffi/capi/src/casemap.rs
index fc9d91de0a..7a73611bf0 100644
--- a/ffi/capi/src/casemap.rs
+++ b/ffi/capi/src/casemap.rs
@@ -74,9 +74,9 @@ pub mod ffi {
locale: &ICU4XLocale,
write: &mut DiplomatWriteable,
) -> Result<(), ICU4XError> {
- ... | 7 | 44 | 47 |
20a3bae7cbd1ffde5c45374e262393562d6680d2 | Shane F. Carr | 2024-05-23T16:56:58 | Add Yoke example with closure that writes data out (#4909)
See #4908 | diff --git a/Cargo.lock b/Cargo.lock
index 08f28fe0c9..b0a6bbd239 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -3235,6 +3235,7 @@ name = "yoke"
version = "0.7.3"
dependencies = [
"bincode",
+ "postcard",
"serde",
"stable_deref_trait",
"yoke-derive",
diff --git a/utils/yoke/Cargo.toml b/utils/yoke/Cargo.toml
in... | 3 | 35 | 0 |
9150b7b7460a20d993dadff81fe16bd2a2aa11bf | Makoto Kato | 2024-05-22T23:48:01 | Set boundary_property with complex character and EOT (#4903)
Fixes https://github.com/unicode-org/icu4x/issues/4446.
If EOT after SA, we should mark as Letter (SA). | diff --git a/components/segmenter/src/rule_segmenter.rs b/components/segmenter/src/rule_segmenter.rs
index 72171cf8f9..95490141c3 100644
--- a/components/segmenter/src/rule_segmenter.rs
+++ b/components/segmenter/src/rule_segmenter.rs
@@ -63,6 +63,7 @@ impl<'l, 's, Y: RuleBreakType<'l, 's> + ?Sized> Iterator for RuleBr... | 2 | 30 | 1 |
bceda9b5002cfe7a71c96cd920609aaaf882c0b2 | Shane F. Carr | 2024-05-22T17:45:42 | Fix year 2319 in the Chinese calendar (#4929)
Increases the offset from 5 bits to 6 bits. | diff --git a/components/calendar/src/chinese.rs b/components/calendar/src/chinese.rs
index db6ca23bc9..a8385186fc 100644
--- a/components/calendar/src/chinese.rs
+++ b/components/calendar/src/chinese.rs
@@ -445,7 +445,7 @@ mod test {
use super::*;
use crate::types::MonthCode;
- use calendrical_calculatio... | 2 | 16 | 3 |
f5b1fcbae49ddbe0a966600f911a322690779dfc | Shane F. Carr | 2024-05-22T16:25:39 | Inline no_major_solar_term into call sites to reduce duplicate work (#4927)
Split from #4904. This is a productive standalone change. | diff --git a/utils/calendrical_calculations/src/chinese_based.rs b/utils/calendrical_calculations/src/chinese_based.rs
index bf377dcb2a..36fc15408f 100644
--- a/utils/calendrical_calculations/src/chinese_based.rs
+++ b/utils/calendrical_calculations/src/chinese_based.rs
@@ -223,16 +223,6 @@ pub(crate) fn major_solar_te... | 1 | 19 | 20 |
bc0239e6ac39a9dbf5f6bf06768beb5f33156467 | Shane F. Carr | 2024-05-16T15:20:00 | Organize workspace deps and reenable default features where appropriate (#4844)
Fixes https://github.com/unicode-org/icu4x/issues/4843 | diff --git a/Cargo.lock b/Cargo.lock
index eab6f0fc7c..ea3e09f140 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -2450,7 +2450,9 @@ version = "4.2.0"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "2230cd5c29b815c9b699fb610b49a5ed65588f3509d9f0108be3a885da629333"
dependencies = [
+ "colored... | 15 | 97 | 42 |
5b15744b354cac106493212020c7f6324e0c516f | Shane F. Carr | 2024-05-16T08:28:11 | Assorted Rust hygiene fixes (#4911)
Fixes https://github.com/unicode-org/icu4x/issues/4910 | diff --git a/components/datetime/src/fields/symbols.rs b/components/datetime/src/fields/symbols.rs
index b1674a6a57..9db4914ff7 100644
--- a/components/datetime/src/fields/symbols.rs
+++ b/components/datetime/src/fields/symbols.rs
@@ -2,6 +2,7 @@
// called LICENSE at the top level of the ICU4X source tree
// (online ... | 2 | 11 | 5 |
afe6679c804f2d48ad607304e83558338789b3e5 | Younies Mahmoud | 2024-05-14T10:42:52 | Remove unneeded `to_f64` funciton (#4839) | diff --git a/components/experimental/Cargo.toml b/components/experimental/Cargo.toml
index 2a4d63ed45..c7927ebdca 100644
--- a/components/experimental/Cargo.toml
+++ b/components/experimental/Cargo.toml
@@ -47,7 +47,7 @@ zerofrom = { workspace = true }
displaydoc = { workspace = true }
log = { workspace = true, optio... | 3 | 4 | 11 |
fbd61a3687dbd78eb2b058fd800d2655f43a0614 | Shane F. Carr | 2024-05-11T18:44:05 | Add blob provider benchmark for auxiliary key fallback (#4887)
To evaluate solutions for #2699 | diff --git a/Cargo.lock b/Cargo.lock
index 036a78f36e..9101913365 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -1467,8 +1467,12 @@ version = "1.4.0"
dependencies = [
"criterion",
"icu_datagen",
+ "icu_datetime",
+ "icu_datetime_data",
"icu_locid",
+ "icu_locid_transform",
"icu_provider",
+ "icu_provider_adapter... | 3 | 171 | 0 |
31e085a37dec83293e5b26c4f97058ca2d6746de | Shane F. Carr | 2024-05-08T19:27:15 | Add missing std pointer-like impls for DataProvider, DynamicDataProvider (#4880) | diff --git a/provider/core/src/any.rs b/provider/core/src/any.rs
index 8312a21845..153cdc5140 100644
--- a/provider/core/src/any.rs
+++ b/provider/core/src/any.rs
@@ -350,18 +350,21 @@ pub trait AnyProvider {
}
impl<'a, T: AnyProvider + ?Sized> AnyProvider for &'a T {
+ #[inline]
fn load_any(&self, key: Dat... | 3 | 96 | 8 |
fb1df88a6681d2e166310db1d9d2a21d30479288 | Robert Bastian | 2024-05-07T17:54:10 | Reducing generics and indirection in datetime formatters (#4873) | diff --git a/components/datetime/src/error.rs b/components/datetime/src/error.rs
index 64aac56407..cd4013047e 100644
--- a/components/datetime/src/error.rs
+++ b/components/datetime/src/error.rs
@@ -86,6 +86,8 @@ pub enum DateTimeError {
/// The same field occurs multiple times in a pattern or was loaded multiple ... | 8 | 212 | 311 |
92f6c345540a184fad00290647a46725d546fcc3 | Robert Bastian | 2024-05-07T17:03:49 | Timezone formatter error paths (#4863) | diff --git a/components/datetime/src/format/time_zone.rs b/components/datetime/src/format/time_zone.rs
index f5cbe29fa4..7767df57c0 100644
--- a/components/datetime/src/format/time_zone.rs
+++ b/components/datetime/src/format/time_zone.rs
@@ -7,7 +7,7 @@ use core::fmt;
use crate::Error;
use crate::{
input::TimeZ... | 3 | 271 | 272 |
08202ba77ce9bbe3246e57080af34cff0c0f8d15 | Shane F. Carr | 2024-05-06T20:52:20 | Don't enable datagen networking feature when not needed (#4867) | diff --git a/provider/blob/Cargo.toml b/provider/blob/Cargo.toml
index 3849e7ca0d..90891233e3 100644
--- a/provider/blob/Cargo.toml
+++ b/provider/blob/Cargo.toml
@@ -30,8 +30,8 @@ zerotrie = { workspace = true, features = ["serde", "zerovec"] }
log = { workspace = true, optional = true }
[dev-dependencies]
-icu_lo... | 3 | 8 | 7 |
643d7da8b55806bb01ceb3a9f3c3da850c1d5ae2 | Robert Bastian | 2024-05-03T14:51:59 | Fix merge conflict (#4862) | diff --git a/provider/blob/tests/test_versions.rs b/provider/blob/tests/test_versions.rs
index e3326bdc9c..7b653ce1b0 100644
--- a/provider/blob/tests/test_versions.rs
+++ b/provider/blob/tests/test_versions.rs
@@ -79,7 +79,7 @@ fn test_v2_bigger() {
let exporter = BlobExporter::new_v2_with_sink(Box::new(&mut blob... | 1 | 1 | 1 |
041c795fa76a2ba9ca286b3d8f6fb7d477673895 | Shane F. Carr | 2024-05-02T18:57:24 | More assorted datagen renames (#4854)
Part of #4629 | diff --git a/provider/blob/tests/test_versions.rs b/provider/blob/tests/test_versions.rs
index 269bda809d..e3326bdc9c 100644
--- a/provider/blob/tests/test_versions.rs
+++ b/provider/blob/tests/test_versions.rs
@@ -17,7 +17,7 @@ const BLOB_V2: &[u8] = include_bytes!("data/v2.postcard");
fn run_driver(exporter: BlobExp... | 4 | 25 | 27 |
1c52bb3e52bc1c24de9ff8e71b950fb91b14eb82 | Manish Goregaokar | 2024-05-01T01:40:05 | Add support for BlobSchemaV2Bigger (#4856) | diff --git a/Cargo.lock b/Cargo.lock
index 478dad1681..7486afb9ed 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -1472,6 +1472,7 @@ dependencies = [
"log",
"postcard",
"serde",
+ "twox-hash",
"writeable",
"zerotrie",
"zerovec",
diff --git a/provider/blob/Cargo.toml b/provider/blob/Cargo.toml
index dd4417ff68..... | 6 | 152 | 16 |
a87ec8cc7b2f64759d4db4d5edc193416af29b22 | Makoto Kato | 2024-04-26T02:32:37 | Update word break's spec test like others. (#4840)
Unit tests for Word segmenter's specification tests use `assert_eq`, but
others such as line segmenter shows more error information if tests are
failed. So I would like to convert word segmenter test to others. | diff --git a/components/segmenter/tests/spec_test.rs b/components/segmenter/tests/spec_test.rs
index cc10f18c17..74fc38edad 100644
--- a/components/segmenter/tests/spec_test.rs
+++ b/components/segmenter/tests/spec_test.rs
@@ -178,11 +178,44 @@ fn run_line_break_extra_test() {
fn word_break_test(file: &'static str) {
... | 1 | 35 | 2 |
3c2a1b5e782a79a4d75e7500451243269f634fee | Shane F. Carr | 2024-04-25T21:41:50 | Change CLI from --deduplication-strategy to --deduplication (#4845) | diff --git a/provider/datagen/src/bin/icu4x-datagen.rs b/provider/datagen/src/bin/icu4x-datagen.rs
index a4937b7d60..0c2c014a4a 100644
--- a/provider/datagen/src/bin/icu4x-datagen.rs
+++ b/provider/datagen/src/bin/icu4x-datagen.rs
@@ -198,14 +198,14 @@ struct Cli {
#[arg(short, long, value_enum, default_value_t = ... | 1 | 24 | 27 |
5991cd21bd3404fa66e837247d27684d6953d9e9 | Younies Mahmoud | 2024-04-25T11:32:04 | Rename the generic convertible type (#4848) | diff --git a/components/experimental/src/units/converter.rs b/components/experimental/src/units/converter.rs
index 5a4d74042d..0ca5fe9593 100644
--- a/components/experimental/src/units/converter.rs
+++ b/components/experimental/src/units/converter.rs
@@ -2,7 +2,7 @@
// called LICENSE at the top level of the ICU4X sour... | 4 | 17 | 17 |
ec7c7920f7b658915d3bdd6cab2156b12f273152 | Sean Burke | 2024-04-25T07:00:27 | Add API for getting endianness of a binary resource bundle (#4804) | diff --git a/utils/resb/src/binary.rs b/utils/resb/src/binary.rs
index 4271e77bff..5b4cf4fe3f 100644
--- a/utils/resb/src/binary.rs
+++ b/utils/resb/src/binary.rs
@@ -7,6 +7,7 @@
//! file format.
mod deserializer;
+mod header;
pub use self::deserializer::from_bytes;
#[cfg(feature = "serialize")]
@@ -14,56 +15,1... | 4 | 204 | 190 |
1f33a8996676ea548ed1385cef553bdb3b791f7e | Kart | 2024-04-25T06:57:32 | benchmark: CodePointTrie::get_range (#4806)
fixes #1946 | diff --git a/components/collections/benches/codepointtrie.rs b/components/collections/benches/codepointtrie.rs
index 5117330752..5241c1b708 100644
--- a/components/collections/benches/codepointtrie.rs
+++ b/components/collections/benches/codepointtrie.rs
@@ -62,6 +62,18 @@ fn overview_bench(c: &mut Criterion) {
... | 1 | 12 | 0 |
9f23363e4b48f4069855a68982d3e4d36d64ccc0 | Kevin Ness | 2024-04-25T06:54:11 | Adjust `ixdtf`'s TimeDurationRecord representation (#4819)
This PR adjusts TimeDurationRecord to align with some feedback from
#4646 regarding the representation of TimeDurationRecord | diff --git a/utils/ixdtf/src/parsers/duration.rs b/utils/ixdtf/src/parsers/duration.rs
index 459827245e..1ecdde37e3 100644
--- a/utils/ixdtf/src/parsers/duration.rs
+++ b/utils/ixdtf/src/parsers/duration.rs
@@ -12,7 +12,7 @@ use crate::{
is_month_designator, is_second_designator, is_sign, is_time_designato... | 4 | 119 | 103 |
101404f2dc6b277fd65bdbaf4e976be085824a8a | Shane F. Carr | 2024-04-24T20:12:34 | Use TryWriteable in icu_pattern and add MultiNamedPlaceholder backend (#4766)
This PR makes icu_pattern compatible with TryWriteable and implements
MultiNamedPlaceholder as a backend. | diff --git a/Cargo.lock b/Cargo.lock
index f0100ca99c..002e310562 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -1371,6 +1371,7 @@ dependencies = [
"databake",
"displaydoc",
"either",
+ "litemap",
"postcard",
"serde",
"serde_json",
diff --git a/utils/pattern/Cargo.toml b/utils/pattern/Cargo.toml
index 9138b48... | 11 | 890 | 162 |
26b7193544436a2fdcecbd433638ae1b7d45c3d5 | José Julián Espina | 2024-04-24T16:20:53 | Implement `DeduplicationStrategy::RetainBaseLanguages` (#4836) | diff --git a/provider/datagen/src/bin/icu4x-datagen.rs b/provider/datagen/src/bin/icu4x-datagen.rs
index 1c3a667ebc..a4937b7d60 100644
--- a/provider/datagen/src/bin/icu4x-datagen.rs
+++ b/provider/datagen/src/bin/icu4x-datagen.rs
@@ -303,6 +303,7 @@ enum Fallback {
#[derive(Copy, Clone, PartialEq, Eq, PartialOrd, Ord... | 3 | 270 | 78 |
c9fa21d3e3f83389818cc44bb22abd93369778b8 | Robert Bastian | 2024-04-23T16:01:45 | Remove panic `fmt` implementations from `icu_capi` (#4838)
This reduces the dylib size by 8KB, even with `-C panic=abort`. | diff --git a/ffi/capi/src/properties_maps.rs b/ffi/capi/src/properties_maps.rs
index 8eec4cd755..b5fb04f631 100644
--- a/ffi/capi/src/properties_maps.rs
+++ b/ffi/capi/src/properties_maps.rs
@@ -29,10 +29,9 @@ pub mod ffi {
pub struct ICU4XCodePointMapData8(maps::CodePointMapData<u8>);
fn convert_8<P: TrieV... | 1 | 5 | 5 |
1cb8754116963b0509e16d5a6aa560ce9d1fadd6 | Younies Mahmoud | 2024-04-23T06:05:04 | Remove unneeded tests (#4835) | diff --git a/components/experimental/src/units/ratio.rs b/components/experimental/src/units/ratio.rs
index 216a7b8717..ba9dd7a306 100644
--- a/components/experimental/src/units/ratio.rs
+++ b/components/experimental/src/units/ratio.rs
@@ -437,21 +437,6 @@ impl FromStr for IcuRatio {
mod tests {
use super::*;
- ... | 1 | 0 | 15 |
6ed3c7442dd04e5d563fc8b87f819abb68d078a2 | Younies Mahmoud | 2024-04-22T22:11:50 | Remove Redundant Function for Extracting Scientific Notation from Strings in DataGen. (#4831) | diff --git a/components/experimental/src/units/ratio.rs b/components/experimental/src/units/ratio.rs
index 595a6b4d39..216a7b8717 100644
--- a/components/experimental/src/units/ratio.rs
+++ b/components/experimental/src/units/ratio.rs
@@ -54,10 +54,15 @@ pub enum RatioFromStrError {
impl IcuRatio {
/// Creates ... | 2 | 73 | 157 |
c271c85b6ca7a1099c5ec6520ef3141ec4a82d2f | Younies Mahmoud | 2024-04-22T15:51:07 | Use `is_negative` to check the sign an element of the ConversionInfo. (#4833) | diff --git a/Cargo.lock b/Cargo.lock
index 07783de6f7..7e30490954 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -1270,6 +1270,7 @@ dependencies = [
"ndarray",
"num-bigint",
"num-rational",
+ "num-traits",
"once_cell",
"postcard",
"proc-macro2",
diff --git a/provider/datagen/Cargo.toml b/provider/datagen/Cargo... | 3 | 14 | 16 |
827128ddce24c4f745b6d185ee1c8901f5d64880 | Younies Mahmoud | 2024-04-19T20:39:51 | Add doc tests and implement small fix for IcuRatio::fromStr (#4824) | diff --git a/components/experimental/src/units/ratio.rs b/components/experimental/src/units/ratio.rs
index 2bf74a64c0..595a6b4d39 100644
--- a/components/experimental/src/units/ratio.rs
+++ b/components/experimental/src/units/ratio.rs
@@ -84,6 +84,11 @@ impl IcuRatio {
pub fn ten() -> Self {
Self(Ratio::f... | 1 | 118 | 19 |
37b36b3bd9732e7e2bed9423dcc5f70f574f8681 | Younies Mahmoud | 2024-04-19T17:34:44 | Make `IcuRatio::from_str` accept scientific notation numbers. (#4821) | diff --git a/components/experimental/src/units/ratio.rs b/components/experimental/src/units/ratio.rs
index 643d9bd33a..2bf74a64c0 100644
--- a/components/experimental/src/units/ratio.rs
+++ b/components/experimental/src/units/ratio.rs
@@ -7,6 +7,7 @@ use core::{
str::FromStr,
};
+use alloc::borrow::Cow;
use nu... | 2 | 197 | 66 |
d31f4159e40872a3987b6f623e44830c0a25ddbb | Younies Mahmoud | 2024-04-18T18:01:13 | Implement Clone for `UnitsConverter` (#4820)
Implement Clone for UnitsConverter to implement it subsequently in the
FFI.
<!--
Thank you for your pull request to ICU4X!
Reminder: try to use [Conventional
Comments](https://conventionalcomments.org/) to make comments clearer.
Please see
https://github.com/... | diff --git a/components/experimental/src/units/converter.rs b/components/experimental/src/units/converter.rs
index b369a52665..24867f9800 100644
--- a/components/experimental/src/units/converter.rs
+++ b/components/experimental/src/units/converter.rs
@@ -13,6 +13,7 @@ use crate::units::ratio::IcuRatio;
/// NOTE:
/// ... | 1 | 5 | 4 |
65367f88789454541db1e70b71d3799fd6351e86 | Younies Mahmoud | 2024-04-17T08:10:19 | Implement `convert_f64` for units converter. (#4816) | diff --git a/components/experimental/src/units/converter.rs b/components/experimental/src/units/converter.rs
index b407bbe7c8..b369a52665 100644
--- a/components/experimental/src/units/converter.rs
+++ b/components/experimental/src/units/converter.rs
@@ -20,6 +20,13 @@ impl UnitsConverter {
pub fn convert(&self, v... | 4 | 77 | 6 |
6df291fa313e992c09adbd107c31590ae0a0a5e4 | Younies Mahmoud | 2024-04-17T02:57:47 | Implement IcuRatio to represent big numbers. (#4799) | diff --git a/components/experimental/src/units/converter.rs b/components/experimental/src/units/converter.rs
index b687da36de..b407bbe7c8 100644
--- a/components/experimental/src/units/converter.rs
+++ b/components/experimental/src/units/converter.rs
@@ -2,8 +2,7 @@
// called LICENSE at the top level of the ICU4X sour... | 6 | 280 | 99 |
149ed1209e575b79bcc97583a9ff5f5c34767266 | Robert Bastian | 2024-04-16T18:14:36 | Change `TryWriteable::try_write_to_string` to always return a string and use in `PotentiallyValidUtf8/16` (#4812) | diff --git a/ffi/capi/src/list.rs b/ffi/capi/src/list.rs
index 7f1bcc857b..c70e5d7417 100644
--- a/ffi/capi/src/list.rs
+++ b/ffi/capi/src/list.rs
@@ -158,7 +158,12 @@ pub mod ffi {
write: &mut DiplomatWriteable,
) -> Result<(), ICU4XError> {
self.0
- .format(list.iter(... | 3 | 117 | 39 |
7691c35fb66727d4839941c643b2c9351fd88cae | Robert Bastian | 2024-04-16T16:20:40 | Clarify `static_to_owned` docs (#4797) | diff --git a/components/locid_transform/src/fallback/mod.rs b/components/locid_transform/src/fallback/mod.rs
index 56b6ace400..8048deb903 100644
--- a/components/locid_transform/src/fallback/mod.rs
+++ b/components/locid_transform/src/fallback/mod.rs
@@ -215,7 +215,10 @@ impl<'a> LocaleFallbackerBorrowed<'a> {
}
im... | 6 | 40 | 10 |
f0add379eff4ef8fca9791bbcfadd69de37565e0 | iyzana | 2024-04-15T17:22:39 | Fix skeleton matching for weekday symbols (#4730) | diff --git a/components/datetime/src/fields/symbols.rs b/components/datetime/src/fields/symbols.rs
index e7680cb6cc..b1674a6a57 100644
--- a/components/datetime/src/fields/symbols.rs
+++ b/components/datetime/src/fields/symbols.rs
@@ -161,6 +161,22 @@ impl FieldSymbol {
pub(crate) fn discriminant_cmp(&self, other:... | 3 | 77 | 3 |
a01a311dc7dc6f617d8aec590edb5c414e03368a | Roozbeh Pournader | 2024-04-13T08:36:33 | Add override table for Persian calendar (#4796)
Fixes #4713 until about 3000 AP (~3621 CE).
---------
Co-authored-by: Manish Goregaokar <manishsmail@gmail.com> | diff --git a/components/calendar/src/persian.rs b/components/calendar/src/persian.rs
index 2abb2a2648..5c62d69b22 100644
--- a/components/calendar/src/persian.rs
+++ b/components/calendar/src/persian.rs
@@ -80,10 +80,8 @@ impl CalendarArithmetic for Persian {
12
}
- // Calculated using the 33-year ru... | 2 | 68 | 15 |
75cb5b6d114f116894ec4448fe7b7a8f62909876 | Roozbeh Pournader | 2024-04-11T04:25:05 | Replace 2820-year with 33-year cycle in Persian calendar (#4775)
Partial fix for https://github.com/unicode-org/icu4x/issues/4713 | diff --git a/components/calendar/src/persian.rs b/components/calendar/src/persian.rs
index 546712b0ef..2abb2a2648 100644
--- a/components/calendar/src/persian.rs
+++ b/components/calendar/src/persian.rs
@@ -79,17 +79,11 @@ impl CalendarArithmetic for Persian {
fn months_for_every_year(_: i32, _data: ()) -> u8 {
... | 2 | 435 | 154 |
16b770c578d1c6cad87b259a1766a86db0792b20 | Ting-Yu Lin | 2024-04-08T19:08:21 | Add a grapheme cluster test for emoji flags (#4781)
Fixed #4780. | diff --git a/components/segmenter/src/grapheme.rs b/components/segmenter/src/grapheme.rs
index 9cfe0349bc..8bbeacfe20 100644
--- a/components/segmenter/src/grapheme.rs
+++ b/components/segmenter/src/grapheme.rs
@@ -268,3 +268,11 @@ fn empty_string() {
let breaks: Vec<usize> = segmenter.segment_str("").collect();
... | 1 | 8 | 0 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.