repository
stringclasses
156 values
issue title
stringlengths
1
1.01k
labels
stringclasses
8 values
body
stringlengths
1
270k
prestodbpresto
error execute prepared statement when complex join criterion contain parameter
Bug
a query like this sql select from value 1 t a join value 2 u a on t a u a fail to execute with execute use with com facebook presto sql analyzer semanticexception line 1 67 query take no parameter at com facebook presto sql analyzer expressionanaly...
prestodbpresto
unionnode symbol mapping failure
Bug
with temp as select orderkey partkey suppkey extendedprice from tpch tiny lineitem select null as test null as orderkey null as partkey sum extendedprice as extendedprice from temp union all select null as test arbi...
prestodbpresto
incorrect result for nest except
Bug
a except b except c be be evaluate as a except b except c this be incorrect since except set subtraction be not associative for example value 1 except value 1 except value 1 produce col0 0 row the correct output should be ...
prestodbpresto
incorrect result due to improper inlining of argument to try
Bug
the follow query should fail sql select try x be null from select 1 y as x from value 1 2 3 0 4 t y however it succeed and produce this incorrect output col0 false false false true false 5 row this be due to this check in mergeproject...
prestodbpresto
coordinator do not expire all query
Bug
I see finished query that be several day old in the ui on busy cluster that should only have a few minute worth of finish query this mean there be a bug leak in query expiration
prestodbpresto
set session allow set invalid value to session property
Bug
currently it be possible to set arbitrary value to session property even if it have validation function attach to it e g I can do presto public set session task writer count 3 set session and it complete without error but then I can not do anything until I restart cli any command fail ...
prestodbpresto
remove redundant type argument
Bug
remove redundant type argument
prestodbpresto
testlocalbinaryspilledquerie fail with too many open file in system
Bug
I consistently get this failure when run the test on osx testassignuniqueid com facebook presto test testlocalbinaryspilledquerie time elapse 2 7 sec failure java lang assertionerror execution of actual query fail select count from select from select select count where ...
prestodbpresto
return empty if you select hive external table by use webhdfs
Enhancement
hi I use presto 0 157 jdk1 8 0 101 hdp 2 1 hive connector cento 6 5 I create external hive table with remote location by use webhdfs create external table hoge partition by store as rcfile location webhdfs but query result be empty ...
prestodbpresto
add current user function
Enhancement
it would be very nice if we can implement current user function which return the current user s username or I would like to ask if it be any way to get current username within a presto query
prestodbpresto
enhance merge non identical window to collapse window across different node
Enhancement
this be a continuation of as current implementation 6009 be limit to merge adjacent window in a plan we need a way to merge window across other node example sql explain select sum x over lag x 1 over from value 1 t x query plan ...
prestodbpresto
constant folding for aggregation
Enhancement
a query like select approx percentile orderkey array 0 001 from order project the array 0 001 for every row in order and result in a plan like below presto sf100 explain analyze select approx percentile orderkey array 0 001 from order ...
prestodbpresto
markdistinct should be aware of node distribution in addexchange optimizer
Enhancement
currently it be only stream distribution aware and this doesn t help we in case where the datum be just node distribute e g in raptor in those case each count distinct operation result in another stage in the plan
prestodbpresto
some test do fail due to translate exception getmessage
Bug
some of recently add test do check message of runtimeexception message of some jdbc connector be translate to system language and at least on mac for that reason the test fail test on polish as system language one example of that be fbd8dd8c385015a7618aaa3751135f1d8dab8dd2 testdbresourcegroupconfigur...
prestodbpresto
supertype not recognize in simple case if in subquery any subquery all subquery
Bug
presto sf1 select if 1 1 0 1 query 20161117 123322 00020 dd5yv fail line 1 11 if condition must evaluate to a boolean actual integer cc kokose ilfrin martint arhimondr this issue be cause by expressionanalyzer coercetosingletype which doesn t use getcommonsupertyp...
prestodbpresto
incorrect any all subquery result with null row or empty subquery result
Bug
presto empty subquery table presto sf1 select 1 all select 1 where false col0 null 1 row presto sf1 select 1 all select 1 where false col0 null 1 row presto null row subquery presto sf1 select 1 all value null query ...
prestodbpresto
unable to start server when cassandra host be not resolvable
Bug
unable to start presto with cassandra connector when cassandra host cassandra contact point from cassandra property be not resolvable to an ip 2016 11 16t09 24 39 229z error main com facebook presto server prestoserver unable to create injector see the follow error 1 error in custom provid...
prestodbpresto
move correlate predicate out of the subquery
Enhancement
1 in the subquery add the non correlate column in the correlate predicate to the select list 2 move the subquery to the from clause in the outer query block 3 move the correlate predicate to either where clause or the on clause correspond to the moved subquery in the outer query block 4 update the co...
prestodbpresto
unable to create plan for query with duplicate in predicate
Bug
presto tiny select 1 in select 1 2 in select 1 where 1 in select 1 query 20161116 072550 00005 ztdnc fail invalid node expression dependency semijoin result not in source plan output expr 4 hashvalue 22 semijoin result 17 java lang illegalargumentexception i...
prestodbpresto
incorrect result when use null in empty subquery
Bug
presto tiny select x from value null 1 t x where x in select from value 1 p y where y 0 be null x null 1 row the query be expect to return an empty result set
prestodbpresto
use limit for automatic join order
Enhancement
consider the follow query sql select from select from a limit 10000 join b the subquery should be assume to be the small side of the join since it have a small fix bind on the number of row
prestodbpresto
add function for parse string with unicode escape
Enhancement
it should be able to handle uxxxx sequence
prestodbpresto
uncategorized error when cast nan or infinite to decimal
Bug
select cast nan as decimal 1 1 query 20161111 172739 13734 rka4f fail infinite or nan java lang numberformatexception infinite or nan at java math bigdecimal bigdecimal java 895 at java math bigdecimal bigdecimal java 872 at com facebook presto type decimalcast doubletoshor...
prestodbpresto
add ability to call mysql procedure from presto
Enhancement
presto default select from mysql mp commerce test idt testcol 1 hair care 2 body care 3 kit gift set 3 row query 20161111 022956 00023 ki3sk finish 2 node split 2 total 2 do 100 00 0 00 3 ro...
prestodbpresto
explain analyze incorrectly strip off output column
Bug
explain analyze currently strip off output column of a query which be a problem because it change the performance characteristic of the query for example if I have a query with 1000 group by aggregate the explain analyze will only run with 1 of the group by aggregate
prestodbpresto
support unicode escape string
Enhancement
the standard specify a slightly strange syntax for string literal with escaped unicode in 9075 2 2011 section 5 3 the starting token in the grammar be the postgresql manual give an overview sql syntax string uescape
prestodbpresto
categorize ioexception when read hive table
Enhancement
it should be categorize as hive bad datum java io ioexception incorrect header check java lang runtimeexception com google common base throwable propagate throwable java 160 com facebook presto hive columnarbinaryhiverecordcursor parselongcolumn columnarbinaryhiverecordcursor java 319 com ...
prestodbpresto
display well error message for unsupported correlate query shape
Enhancement
the message that s currently report be not very helpful we should validate the shape of the query during analysis and show a more meaningful message for example for a query like sql select from t where t x in select distinct t y from u it should say something like corr...
prestodbpresto
add support for distinct in selective aggregate
Enhancement
currently distinct can not be use with selective aggregate sql select count distinct custkey filter where orderkey 10 from tpch tiny order com facebook presto sql analyzer semanticexception line 1 8 filter aggregation not support with distinct count distinct custkey f...
prestodbpresto
invalid plan for query involve an aggregation subquery join to a partition table
Bug
give this hive table sql create table t a bigint ds varchar with partition by array ds the follow query fail with an exception during planning sql select from select count from tpch tiny order have count distinct custkey 1 cross join t ...
prestodbpresto
npe when table be bucket on non existent column
Bug
give this table which be allegedly bucket on a non existent column create table foo a bigint with bucket by array b bucket count 1000 query the table fail with java lang nullpointerexception at java util stream referencepipeline 3 1 accept referencepipeline java 1...
prestodbpresto
hive table can be bucket on non existent column
Bug
this statement succeed even though the table do contain a column name b sql create table foo a bigint with bucket by array b bucket count 1000
prestodbpresto
plan error for query contain disjunction and in subquery predicate
Bug
sql select from tpch tiny order where orderkey in value 1 or true fail with java lang illegalargumentexception unsupported subquery type at com facebook presto sql planner sanity noapplynodeleftchecker 1 visitapply noapplynodeleftchecker java 39 at com facebook presto sql pla...
prestodbpresto
uncategorized error for from unixtime
Bug
invalid offset minute 1080 java lang illegalargumentexception com facebook presto spi type timezonekey checkargument timezonekey java 300 com facebook presto spi type timezonekey gettimezonekeyforoffset timezonekey java 140 com facebook presto spi type datetimeencoding packdatetimewithzone d...
prestodbpresto
add raptor metadata db optimization
Enhancement
fix 6497
prestodbpresto
support all and any for unorderable type
Enhancement
current implementation of quantify comparison predicate do in support all and any only for orderable type however the type doesn t have to be orderable and can be just comparable to be use with these quantifier an example of a comparable but unorderable type be map type a possible approach to imp...
prestodbpresto
expression in on clause not remove when implicit cast insert in comparison
Enhancement
in the follow query the expression a comment x should be remove from the on clause but once the engine insert the implicit widening cast cast x as varchar 79 the expression be not remove sql select count from tpch tiny order a join tpch tiny order b on ...
prestodbpresto
track per operator peak memory
Enhancement
be able to compute the bad case memory usage for a query require know what be the peak amount of memory use by each operator we currently track instantaneous peak memory which be sensitive to scheduling decision and time
prestodbpresto
incorrect plan when hash pre computation be on
Bug
give this table sql create table u as select x y from value a 0 b 1 t x y the follow query may randomly produce an invalid plan which cause the query to produce 0 as a result instead of 1 sql with t as select x y from u group...
prestodbpresto
make property include and exclude unreserved keyword
Bug
this commit 055b1df2c4d8f6c220a280a0175b8542177d3753 add support for create table like but do not mark those keyword as unreserved as a result any query that reference column with those name without quote fail in the new version
prestodbpresto
incorrect memory accounting for hash aggregation operator
Bug
the follow query report peak memory that vary wildly from cluster to cluster and run to run I ve see number range from 0 gb to 20 gb it seem to be sensitive to how much concurrent work be be perform how fast work complete etc for instance in one cluster set task concurrency to 1 cause it to report 2 gb...
prestodbpresto
flaky testraptorintegrationsmoketestbuckete testcreatebucketedtable
Bug
this might be cause due to compaction run during the test testcreatebucketedtable com facebook presto raptor testraptorintegrationsmoketestbuckete time elapse 0 409 sec failure java lang assertionerror for query select count distinct shard uuid from order bucket not equal actual 1 row ...
prestodbpresto
cli hang when initial output be short
Bug
this query be a good reproduction change the value base on cluster size sql select select sum totalprice from tpch sf200 order union all select sum totalprice from tpch sf1000 order sequence 1 cli show progress for a few second while both subquerie run 2 first subquery finish and pro...
prestodbpresto
incorrect result when use map in in expression
Bug
in the late master presto tiny select x from value 2 t x where map array 1 array x in value map array 1 array 2 x 0 row
prestodbpresto
run presto sql script from cli not able to see time take by the query
Enhancement
hi I be use below command to run sql query I be able to get the result of the query but I be not able to find the time take by query with this way in case hive by use 2 we can get detail of query execution presto cli 0 152 executable jar server serverip port catalog hive schema databasena...
prestodbpresto
eliminate unnecessary cross join
Enhancement
this pull request add simple join reorder algorithm with reorder join set to true default false this rewrite will find all consecutive join sequence and if there be a cross join it will try to reorder join to eliminate they for example select from a b c where a a c a and b b c b there be...
prestodbpresto
support lambda expression in aggregation function
Enhancement
once lambda expression be add we should add support for use they in aggregation function context this will make it possible to model virtually any aggregation behavior without have to write custom aggregation function
prestodbpresto
incorrect result when group set refer to column derive from same column
Bug
this query sql with t v as value 1 2 u v1 v2 as select v v1 v v2 from t select v1 v2 from u group by group set v1 v2 incorrectly produce v1 v2 1 1 2 2 1 1 2 2 4 row the expect result be v1 v2 ...
prestodbpresto
fix create tinyint or smallint for avro in hive
Bug
avro only support int in hive create a table with tinyint or smallint with avro storage format create a table with int automatically in presto we currently create a broken table read it fail with an avro schema mismatch we should either disallow it as not support tell the user to use in...
prestodbpresto
plan error when subquery be use in case if expression
Bug
select if false a in value b produce java lang illegalargumentexception unsupported subquery type at com facebook presto sql planner sanity noapplynodeleftchecker 1 visitapply noapplynodeleftchecker java 39 at com facebook presto sql planner plan applynode accept applynode jav...
prestodbpresto
npe for spnegofilter
Bug
apparently gsscontext getsrcname can return null even if isestablishe be true I suppose we should handle that by return optional empty maybe with a debug log entry java lang nullpointerexception at com facebook presto server security spnegofilter authenticate spnegofilter java 194 ...
prestodbpresto
predicate pushdown derive incorrect join equality
Bug
the follow query sql with t as select name x case name when africa then america else null end as y from tpch tiny region select from t a join t b on a x b y incorrectly produce 0 row the expect output be x y x y ...
prestodbpresto
plan bug when create bucketed table
Bug
this query sql create table t with bucket by array k bucket count 64 as select a b 0 k fail with java lang illegalargumentexception input symbol do not match output symbol at com google common base precondition checkargument precondition java 122 at com...
prestodbpresto
fix thread safety of indexlookup in accumuloclient
Bug
accumuloclient be a singleton and contain an instance of indexlookup it then call setauth from gettabletsplit which be call from different thread additionally indexlookup use columncardinalitycache which have a normal hashmap without any synchronization this code path be also call...
prestodbpresto
remove usage of store accumuloconfig
Bug
various class like accumulopagesinkprovider store an accumuloconfig class rather than extract the value in the constructor and save they to final field config class be mutable so other class should not keep a reference to they
prestodbpresto
make accumulocolumnhandle immutable
Bug
mutable class for a data object be a general anti pattern effective java give a full explanation and be contrary to the general code style of presto additionally the mutable field be use in equal hashcode which violate the contract
prestodbpresto
optimize map agg memory usage
Enhancement
the per group memory usage of map agg in a group by query be quite large for instance for the follow query select k map agg v1 v2 from value 1 2 3 t k v1 v2 group by k the keyvaluepairs state object for each group be 12 kb big
prestodbpresto
fix broken implementation of dictionaryblock compactblock
Bug
this pr fix broken implementation of dictionaryblock compactblock currently the method work only iff all block be exactly the same in all other case all block receive a copy of the ids from the first block I hope I understand the purpose of the method correctly and have create a correct implementation with t...
prestodbpresto
optimize window function follow by order by
Enhancement
the follow query be slow than necessary because the sortnode be redundant with the precede windownode sql select row number over order by key from src order by key it should have the same execution plan as this because the windownode already sort the output sql select row number ...
prestodbpresto
ui show nan when load
Bug
I reproduce by connect to one of our cluster with https where the html page can load but all the resource throw 401
prestodbpresto
o n 2 behavior when group by double column contain nan
Bug
nan be not equal to any other value even to nan this cause insertion into the hash table of a group by or join to become o n for nan value once be implement this should no long be a problem in the meantime we should consider fail query that group by or join on nan
prestodbpresto
cli progress bar overflow on query run for 100 minute
Bug
here s an example from a query that s be run for 2 hour the cli terminal width be 80 character but this line be render at 81 character due to the extra minute digit 125 36 24 9 m rows 3 54 gb 3 3k row s 493 kb s 99
prestodbpresto
support table function
Enhancement
I want to add a support for user define table function but first I would love to hear if such a feature would be useful and it be need my raw plan be to add a concept of table function implement unnest as table function change unnestnode to be something like tablefunctionnode but with a unn function meth...
prestodbpresto
plan class cast exception
Bug
this query now throw an error select max x a over x a 100 0 max x a over from select 1 as a x query 20161005 231326 03851 gb7jd fail com facebook presto sql tree symbolreference can not be cast to com facebook presto sql tree functioncall java lang classcastexception ...
prestodbpresto
spill join
Enhancement
it cover issue before review I highly recommend read description of implement solution section of this doc head h jxm688ny3n2
prestodbpresto
exception when press ctrl c during query execution
Bug
press ctrl c in the cli while a query be process cause java lang runtimeexception error fetch next at com facebook presto client statementclient advance statementclient java 300 at com facebook presto cli statusprinter printinitialstatusupdate statusprinter java 121 at com facebook presto cli ...
prestodbpresto
add spill data size limit
Enhancement
currently be only limit by the capacity of underlying storage after hit such limit query will start to fail there should be both per worker limit and per query limit for spill datum
prestodbpresto
add spill data size to operatorstat
Enhancement
currently there be only one statistic per whole worker getspilleddatasize expose via jmx more stat per operator driver task query could be add
prestodbpresto
make read from spiller asynchronous
Enhancement
currently spiller have a follow interface public interface spiller extend closeable initiate spilling of page stream return complete future once spilling have finish completablefuture spill iterator pageiterator return list of previously spill p...
prestodbpresto
try cast be inconsistent with cast
Bug
presto select cast x as bigint try cast x as bigint from value 1 2 3 null t x col0 col1 1 1 2 2 3 3 null 0 4 row presto select cast null as bigint try cast null as bigint col0 col1 ...
prestodbpresto
kill query that cause bottleneck due to skew
Enhancement
we need a mechanism to detect memory skew for operation like join and group by and a policy to kill skewed query that cause other query to stall when try to allocate memory
prestodbpresto
detect and report join group by skew
Enhancement
if a query fail due to local memory limit be exceed generally due to skew presto should provide well diagnostic about what key or group cause the imbalance
prestodbpresto
npe when cast map contain null
Bug
sql select cast map array 0 1 array 1 null as map com facebook presto spi prestoexception generic internal error at com facebook presto operator scalar maptomapcast tomap maptomapcast java 110 at com facebook presto gen pageprocessor 27357 project 0 unknown source at com fa...
prestodbpresto
fix comparison for char to take into account padding
Bug
previous implementation of char comparison didn t work properly with control char e g 0 internal td review can be relevant
prestodbpresto
effectivepredicate not print nicely as part of hivesplit getinfo
Bug
the effectivepredicate part of hiveslit getinfo be meaningless as tupledomain do not provide tostre method only tostre connectorsession method we should either create standard tostring in tupledomain pass session arg to getinfo drop effectivepredicate from getinfo...
prestodbpresto
plan error for correlate query over hive connector
Bug
run the follow query as part of testhivedistributedquerie fail with a planning error it seem to happen during partition prune sql select count from order o where exist select avg l orderkey from lineitem l where o orderkey l orderkey group by l linenumber java lan...
prestodbpresto
deadlock in task info fetch
Bug
hit this one in production suddenly all query get queue and all client start time out here be the full stack trace find one java level deadlock http worker 2010473 wait to lock monitor 0x00007f8fed4a6fb8 object 0x00007f9615a7e020 a com facebook presto execution r...
prestodbpresto
distinct sum aggregation may produce incorrect result for empty grouping set
Bug
abstracttestquerie testgroupingsetswithmultipledistinctandunion fail for some configuration with task concurrency high then 1 select linenumber count distinct linenumber sum distinct suppkey from select from lineitem where linenumber 2 0 union all select from lineitem where linenumber...
prestodbpresto
try cast fail with unbound variable exception
Bug
presto tiny select try cast foo as array query 20160923 154931 00004 72qud fail variable be not bind y java lang illegalstateexception variable be not bind y at com google common base precondition checkstate precondition java 197 at com facebook presto metadata signaturebinder b...
prestodbpresto
npe with join on multiple condition
Bug
presto nyigitbasi select from value 2 2 a x y join value 2 2 b x y on a x b x a y b y query 20160923 041517 00003 k64q3 fail null java lang nullpointerexception at com facebook presto sql planner optimization windowfilterpushdown rewriter visitfilter windowfilterpushdown java 1...
prestodbpresto
hotfix add miss presto main dependency
Bug
currently there be a problem while start presto server with basic setup from readme due to class apachevalidationprovider not be find this be only hotfix to make master run to be investigate be apachevalidationprovider really require outside of test now why product test didn t catch that problem...
prestodbpresto
task ids should sort numerically on query detail page
Bug
the be currently sort like this 1 0 1 1 1 10 1 11 they should sort like 1 0 1 1 1 2 1 10
prestodbpresto
indexoutofboundsexception in jsonarrayget
Bug
presto 0 152 1 query 20160909 195630 19737 xs72x fail index 0 size 0 java lang indexoutofboundsexception index 0 size 0 at java util linkedlist checkelementindex linkedlist java 555 at java util linkedlist get linkedlist java 476 at com facebook presto operator scalar jsonfunction...
prestodbpresto
fix memory accounting in parallelhashbuildoperator
Bug
use same logic as for hashbuilderoperator this bug feature be introduce in during rewrite parallelhashbuilder into parallelhashbuildoperator or dain maybe I m miss something
prestodbpresto
incorrect result for group set with multiple group
Bug
this query sql select count from value 1 2 3 t x where false group by group set incorrectly produce no row it should produce two row with 0 in each cell
prestodbpresto
bad error message when select be use in group by query
Bug
sql select from value 1 1 t x y group by x fail with query 20160907 180025 00008 b5xgd fail input 1 must be an aggregate expression or appear in group by clause com facebook presto sql analyzer semanticexception input 1 must be an aggregate expression or appear in group by cl...
prestodbpresto
sqlqueryqueuemanager cause http 500 when no rule match
Bug
use presto 0 144 4 presto select from system runtime node error running command error start query at return an invalid response jsonresponse statuscode 500 statusmessage internal server error header content length 5551 date we d 07 sep 2016 16 31 51 gmt www authenticate negotiate...
prestodbpresto
incorrect result when cross join against aggregation over partitioned table
Bug
this query sql select from value 1 2 3 t cross join select count from table where pk non existent u pk be a partition key for table produce an incorrect plan output col0 col1 field bigint count bigint col0 field col1 co...
prestodbpresto
negative datasize for operatorcontext getoperatorstat
Bug
stack trace from presto 0 144 7 java util concurrent completionexception java lang illegalargumentexception size be negative at java util concurrent completablefuture encodethrowable completablefuture java 292 at java util concurrent completablefuture completethrowable completablefuture java 308 ...
prestodbpresto
support english month suffix formatter for mysql date function
Enhancement
date format and date parse should support d
prestodbpresto
support sunday week formatter for mysql date function
Enhancement
date format and date parse should support u u v x w this will require rewrite the format function likely use the new java 8 apis since joda time only support iso week day
prestodbpresto
ml plugin print junk to stdout
Bug
I see message like this when run the test optimization finish iter 48 nu 0 86 obj 77 81212739041075 rho 1 6302973218262196 nsv 86 nbsv 86 total nsv 86 warning training datum in only one class see readme for detail total nsv 0
prestodbpresto
statecompiler should handle error from newinstance
Bug
the newinstance call can throw thing like noclassdeffounderror this be due to a bug but it s probably good to these in a runtimeexception instead of let it propagate as be we could handle any throwable but linkageerror be safe and should cover such bug java lang noclassdeffounderror ...
prestodbpresto
throwable not handle properly during plan
Bug
if a query throw an error during plan it isn t handle and go to stderr 2016 08 30t21 47 49 836 0700 info query scheduler 0 stderr exception in thread query scheduler 0 2016 08 30t21 47 49 836 0700 info query scheduler 0 stderr com google common util concurrent executionerror ...
prestodbpresto
pushdown incorrectly handle expression that can fail
Bug
sql select from select table name round row count shard count rps from system table stat where table schema xxx and shard count 5000 where rps 10000 com facebook presto spi prestoexception by zero at com facebook presto type bigintoperator divide bigintope...
prestodbpresto
window function can not be use in some scalar expression
Bug
select 100 0 sum x over sum x over sum x over from value 1 t x query 20160830 174122 00896 w2gwn fail sum bigint bigint be not a scalar function java lang illegalargumentexception sum bigint bigint be not a scalar function at com google common base preco...
prestodbpresto
presto stat plan time be include queue time
Bug
I notice this when presto be report super long planning time but it look like this be just because the queue be really full
prestodbpresto
ui error on detail page when outputstage be null
Bug
uncaught typeerror can not read property i d of undefined stage plan i d
prestodbpresto
ui active worker count be incorrect
Bug
the coordinator should not be include as a worker unless node scheduler include coordinator be true
prestodbpresto
npe in raptor shardcompactionmanager
Bug
2016 08 26t11 55 57 107 0700 error shard compaction discovery com facebook presto raptor storage organization shardcompactionmanager error discover shard to compact java lang nullpointerexception at com google common base precondition checknotnull precondition java 210 at com goog...