repository
stringclasses
156 values
issue title
stringlengths
1
1.01k
labels
stringclasses
8 values
body
stringlengths
1
270k
prestodbpresto
error execute prepared statement when complex join criterion contain parameter
Bug
a query like this sql select from value 1 t a join value 2 u a on t a u a fail to execute with execute use with com facebook presto sql analyzer semanticexception line 1 67 query take no parameter at com facebook presto sql analyzer expressionanalyzer visitor visitparameter expressionanalyzer java 896 at com facebook presto sql analyzer expressionanalyzer visitor visitparameter expressionanalyzer java 254 at com facebook presto sql tree parameter accept parameter java 48 at com facebook presto sql tree stackableastvisitor process stackableastvisitor java 26 at com facebook presto sql analyzer expressionanalyzer visitor process expressionanalyzer java 273 at com facebook presto sql analyzer expressionanalyzer visitor getoperator expressionanalyzer java 1130 at com facebook presto sql analyzer expressionanalyzer visitor visitcomparisonexpression expressionanalyzer java 423 at com facebook presto sql analyzer expressionanalyzer visitor visitcomparisonexpression expressionanalyzer java 254 at com facebook presto sql tree comparisonexpression accept comparisonexpression java 68 at com facebook presto sql tree stackableastvisitor process stackableastvisitor java 26 at com facebook presto sql analyzer expressionanalyzer visitor process expressionanalyzer java 273 at com facebook presto sql analyzer expressionanalyzer analyze expressionanalyzer java 230 at com facebook presto sql analyzer expressionanalyzer analyzeexpression expressionanalyzer java 1391 at com facebook presto sql analyzer expressionanalyzer analyzeexpressionswithsymbol expressionanalyzer java 1344 at com facebook presto sql analyzer expressionanalyzer getexpressiontype expressionanalyzer java 1310 at com facebook presto sql analyzer expressionanalyzer getexpressiontype expressionanalyzer java 1298 at com facebook presto sql analyzer expressionanalyzer getexpressiontype expressionanalyzer java 1286 at com facebook presto sql planner optimization desugaringoptimizer rewriter desugar desugaringoptimizer java 118 at com facebook presto sql planner optimization desugaringoptimizer rewriter visitfilter desugaringoptimizer java 92 at com facebook presto sql planner optimization desugaringoptimizer rewriter visitfilter desugaringoptimizer java 64 at com facebook presto sql planner plan filternode accept filternode java 71 at com facebook presto sql planner plan simpleplanrewriter rewritecontext rewrite simpleplanrewriter java 85 at com facebook presto sql planner plan simpleplanrewriter rewritecontext rewrite simpleplanrewriter java 96 at com facebook presto sql planner optimization desugaringoptimizer rewriter visitproject desugaringoptimizer java 83 at com facebook presto sql planner optimization desugaringoptimizer rewriter visitproject desugaringoptimizer java 64 at com facebook presto sql planner plan projectnode accept projectnode java 81 at com facebook presto sql planner plan simpleplanrewriter rewritecontext rewrite simpleplanrewriter java 85 at com facebook presto sql planner plan simpleplanrewriter rewritecontext rewrite simpleplanrewriter java 96 at com facebook presto sql planner optimization desugaringoptimizer rewriter visitproject desugaringoptimizer java 83 at com facebook presto sql planner optimization desugaringoptimizer rewriter visitproject desugaringoptimizer java 64 at com facebook presto sql planner plan projectnode accept projectnode java 81 at com facebook presto sql planner plan simpleplanrewriter rewritecontext rewrite simpleplanrewriter java 85 at com facebook presto sql planner plan simpleplanrewriter rewritecontext rewrite simpleplanrewriter java 96 at com facebook presto sql planner optimization desugaringoptimizer rewriter visitproject desugaringoptimizer java 83 at com facebook presto sql planner optimization desugaringoptimizer rewriter visitproject desugaringoptimizer java 64 at com facebook presto sql planner plan projectnode accept projectnode java 81 at com facebook presto sql planner plan simpleplanrewriter rewritecontext rewrite simpleplanrewriter java 85 at com facebook presto sql planner plan simpleplanrewriter rewritecontext rewrite simpleplanrewriter java 96 at com facebook presto sql planner optimization desugaringoptimizer rewriter visitproject desugaringoptimizer java 83 at com facebook presto sql planner optimization desugaringoptimizer rewriter visitproject desugaringoptimizer java 64 at com facebook presto sql planner plan projectnode accept projectnode java 81 at com facebook presto sql planner plan simpleplanrewriter rewritecontext rewrite simpleplanrewriter java 85 at com facebook presto sql planner plan simpleplanrewriter rewritecontext lambda defaultrewrite 0 simpleplanrewriter java 74 at java util stream referencepipeline 3 1 accept referencepipeline java 193 at java util iterator foreachremaine iterator java 116 at java util spliterators iteratorspliterator foreachremaine spliterator java 1801 at java util stream abstractpipeline copyinto abstractpipeline java 481 at java util stream abstractpipeline wrapandcopyinto abstractpipeline java 471 at java util stream reduceop reduceop evaluatesequential reduceop java 708 at java util stream abstractpipeline evaluate abstractpipeline java 234 at java util stream referencepipeline collect referencepipeline java 499 at com facebook presto sql planner plan simpleplanrewriter rewritecontext defaultrewrite simpleplanrewriter java 75 at com facebook presto sql planner plan simpleplanrewriter visitplan simpleplanrewriter java 39 at com facebook presto sql planner plan simpleplanrewriter visitplan simpleplanrewriter java 23 at com facebook presto sql planner plan planvisitor visitoutput planvisitor java 50 at com facebook presto sql planner plan outputnode accept outputnode java 81 at com facebook presto sql planner plan simpleplanrewriter rewritewith simpleplanrewriter java 28 at com facebook presto sql planner optimization desugaringoptimizer optimize desugaringoptimizer java 61 at com facebook presto sql planner logicalplanner plan logicalplanner java 120 at com facebook presto test localqueryrunner createplan localqueryrunner java 676 at com facebook presto test localqueryrunner createplan localqueryrunner java 642 at com facebook presto test localqueryrunner createplan localqueryrunner java 629 at com facebook presto testing localqueryrunner createdriver localqueryrunner java 539 at com facebook presto test localqueryrunner executeinternal localqueryrunner java 500 at com facebook presto testing localqueryrunner lambda execute 2 localqueryrunner java 473 at com facebook presto transaction transactionbuilder execute transactionbuilder java 149 at com facebook presto test localqueryrunner intransaction localqueryrunner java 485 at com facebook presto testing localqueryrunner execute localqueryrunner java 473 at com facebook presto test abstracttestqueryframework computeactual abstracttestqueryframework java 88 at com facebook presto test testlocalquerie testexecuteusingx testlocalquerie java 46 at sun reflect nativemethodaccessorimpl invoke0 native method at sun reflect nativemethodaccessorimpl invoke nativemethodaccessorimpl java 62 at sun reflect delegatingmethodaccessorimpl invoke delegatingmethodaccessorimpl java 43 at java lang reflect method invoke method java 498 at org testng internal methodinvocationhelper invokemethod methodinvocationhelper java 85 at org testng internal invoker invokemethod invoker java 696 at org testng internal invoker invoketestmethod invoker java 882 at org testng internal invoker invoketestmethod invoker java 1189 at org testng internal testmethodworker invoketestmethod testmethodworker java 124 at org testng internal testmethodworker run testmethodworker java 108 at org testng testrunner privaterun testrunner java 767 at org testng testrunner run testrunner java 617 at org testng suiterunner runtest suiterunner java 348 at org testng suiterunner runsequentially suiterunner java 343 at org testng suiterunner privaterun suiterunner java 305 at org testng suiterunner run suiterunner java 254 at org testng suiterunnerworker runsuite suiterunnerworker java 52 at org testng suiterunnerworker run suiterunnerworker java 86 at org testng testng runsuitessequentially testng java 1224 at org testng testng runsuiteslocally testng java 1149 at org testng testng run testng java 1057 at org testng idearemotetestng run idearemotetestng java 72 at org testng remotetestngstarter main remotetestngstarter java 127 at sun reflect nativemethodaccessorimpl invoke0 native method at sun reflect nativemethodaccessorimpl invoke nativemethodaccessorimpl java 62 at sun reflect delegatingmethodaccessorimpl invoke delegatingmethodaccessorimpl java 43 at java lang reflect method invoke method java 498 at com intellij rt execution application appmain main appmain java 147
prestodbpresto
unionnode symbol mapping failure
Bug
with temp as select orderkey partkey suppkey extendedprice from tpch tiny lineitem select null as test null as orderkey null as partkey sum extendedprice as extendedprice from temp union all select null as test arbitrary orderkey as arbitrary orderkey null as partkey sum extendedprice as extendedprice from temp group by suppkey result in query fail every source need to map its symbol to an output unionnode operation symbol java lang illegalargumentexception every source need to map its symbol to an output unionnode operation symbol at com google common base precondition checkargument precondition java 145 at com facebook presto sql planner plan setoperationnode setoperationnode java 67 at com facebook presto sql planner plan unionnode unionnode java 36 at com facebook presto sql planner optimization unaliassymbolreference rewriter visitunion unaliassymbolreference java 584 at com facebook presto sql planner optimization unaliassymbolreference rewriter visitunion unaliassymbolreference java 117 at com facebook presto sql planner plan unionnode accept unionnode java 42 at com facebook presto sql planner plan simpleplanrewriter rewritecontext rewrite simpleplanrewriter java 85 at com facebook presto sql planner plan simpleplanrewriter rewritecontext rewrite simpleplanrewriter java 96 at com facebook presto sql planner optimization unaliassymbolreferences rewriter visitoutput unaliassymbolreference java 473 at com facebook presto sql planner optimization unaliassymbolreferences rewriter visitoutput unaliassymbolreference java 117 at com facebook presto sql planner plan outputnode accept outputnode java 81 at com facebook presto sql planner plan simpleplanrewriter rewritewith simpleplanrewriter java 28 at com facebook presto sql planner optimization unaliassymbolreference optimize unaliassymbolreference java 114 at com facebook presto sql planner logicalplanner plan logicalplanner java 120 at com facebook presto sql planner logicalplanner plan logicalplanner java 111 at com facebook presto execution sqlqueryexecution doanalyzequery sqlqueryexecution java 292 at com facebook presto execution sqlqueryexecution analyzequery sqlqueryexecution java 271 at com facebook presto execution sqlqueryexecution start sqlqueryexecution java 229 at java util concurrent threadpoolexecutor runworker threadpoolexecutor java 1142 at java util concurrent threadpoolexecutor worker run threadpoolexecutor java 617 at java lang thread run thread java 745
prestodbpresto
incorrect result for nest except
Bug
a except b except c be be evaluate as a except b except c this be incorrect since except set subtraction be not associative for example value 1 except value 1 except value 1 produce col0 0 row the correct output should be col0 1 1 row this be due to setflatteningoptimizer treating except in the same manner as union and intersect
prestodbpresto
incorrect result due to improper inlining of argument to try
Bug
the follow query should fail sql select try x be null from select 1 y as x from value 1 2 3 0 4 t y however it succeed and produce this incorrect output col0 false false false true false 5 row this be due to this check in mergeprojection which only test whether try appear at the root of an expression java private static boolean containstry projectnode node return node getassignment value stream anymatch tryexpression class isinstance
prestodbpresto
coordinator do not expire all query
Bug
I see finished query that be several day old in the ui on busy cluster that should only have a few minute worth of finish query this mean there be a bug leak in query expiration
prestodbpresto
set session allow set invalid value to session property
Bug
currently it be possible to set arbitrary value to session property even if it have validation function attach to it e g I can do presto public set session task writer count 3 set session and it complete without error but then I can not do anything until I restart cli any command fail presto public select 1 query 20161201 152600 00032 8zkam fail task writer count must be a power of 2 3 presto public set session task writer count 4 query 20161201 152534 00031 8zkam fail task writer count must be a power of 2 3
prestodbpresto
remove redundant type argument
Bug
remove redundant type argument
prestodbpresto
testlocalbinaryspilledquerie fail with too many open file in system
Bug
I consistently get this failure when run the test on osx testassignuniqueid com facebook presto test testlocalbinaryspilledquerie time elapse 2 7 sec failure java lang assertionerror execution of actual query fail select count from select from select select count where c 1 from select case orderkey when 1 then orderkey else 1 end from select from lineitem union all select from lineitem union all select from lineitem union all select from lineitem union all select from lineitem union all select from lineitem union all select from lineitem union all select from lineitem union all select from lineitem union all select from lineitem union all select from lineitem union all select from lineitem union all select from lineitem union all select from lineitem union all select from lineitem union all select from lineitem union all select from lineitem union all select from lineitem union all select from lineitem union all select from lineitem union all select from lineitem union all select from lineitem union all select from lineitem union all select from lineitem union all select from lineitem union all select from lineitem union all select from lineitem union all select from lineitem union all select from lineitem union all select from lineitem union all select from lineitem union all select from lineitem union all select from lineitem union all select from lineitem union all select from lineitem union all select from lineitem union all select from lineitem union all select from lineitem union all select from lineitem union all select from lineitem union all select from lineitem union all select from lineitem union all select from lineitem union all select from lineitem union all select from lineitem union all select from lineitem union all select from lineitem union all select from lineitem union all select from lineitem union all select from lineitem o c result a where a 1 at com facebook presto test queryassertion assertquery queryassertion java 85 at com facebook presto test abstracttestqueryframework assertquery abstracttestqueryframework java 108 at com facebook presto test abstracttestquerie testassignuniqueid abstracttestquerie java 7738 at java util concurrent threadpoolexecutor runworker threadpoolexecutor java 1142 at java util concurrent threadpoolexecutor worker run threadpoolexecutor java 617 at java lang thread run thread java 745 cause by com facebook presto spi prestoexception fail to read spill page at com facebook presto spiller binaryfilespiller readpage binaryfilespiller java 121 at com facebook presto spiller binaryfilespiller lambda getspill 1 binaryfilespiller java 109 at java util stream intpipeline 4 1 accept intpipeline java 250 at java util stream stream rangeintspliterator foreachremaine stream java 110 at java util spliterator ofint foreachremaine spliterator java 693 at java util stream abstractpipeline copyinto abstractpipeline java 481 at java util stream abstractpipeline wrapandcopyinto abstractpipeline java 471 at java util stream reduceop reduceop evaluatesequential reduceop java 708 at java util stream abstractpipeline evaluate abstractpipeline java 234 at java util stream referencepipeline collect referencepipeline java 499 at com facebook presto spiller binaryfilespiller getspill binaryfilespiller java 110 at com facebook presto operator aggregation builder spillablehashaggregationbuilder mergefromdisk spillablehashaggregationbuilder java 239 at com facebook presto operator aggregation builder spillablehashaggregationbuilder buildresult spillablehashaggregationbuilder java 170 at com facebook presto operator hashaggregationoperator getoutput hashaggregationoperator java 421 at com facebook presto operator driver processinternal driver java 378 at com facebook presto operator driver process driver java 327 at com facebook presto test localqueryrunner executeinternal localqueryrunner java 508 at com facebook presto testing localqueryrunner lambda execute 2 localqueryrunner java 473 at com facebook presto transaction transactionbuilder execute transactionbuilder java 149 at com facebook presto test localqueryrunner intransaction localqueryrunner java 485 at com facebook presto testing localqueryrunner execute localqueryrunner java 473 at com facebook presto test queryassertion assertquery queryassertion java 82 15 more cause by java io filenotfoundexception var folder fz hxvyn4gd06vcggyw9hhr4fnr0000gp t presto spill presto spill1292993305067446573 306 bin too many open file in system at java io fileinputstream open0 native method at java io fileinputstream open fileinputstream java 195 at java io fileinputstream fileinputstream java 138 at com facebook presto spiller binaryfilespiller readpage binaryfilespiller java 116 36 more remove 11 stack frame
prestodbpresto
return empty if you select hive external table by use webhdfs
Enhancement
hi I use presto 0 157 jdk1 8 0 101 hdp 2 1 hive connector cento 6 5 I create external hive table with remote location by use webhdfs create external table hoge partition by store as rcfile location webhdfs but query result be empty select from hoge limit 10 presto server log be as follow java lang noclassdeffounderror javax ws rs core mediatype at org apache hadoop hdfs web webhdfsfilesystem jsonparse webhdfsfilesystem java 328 at org apache hadoop hdfs web webhdfsfilesystem fspathresponserunner getresponse webhdfsfilesystem java 761 at org apache hadoop hdfs web webhdfsfilesystem abstractrunner runwithretry webhdfsfilesystem java 625 at org apache hadoop hdfs web webhdfsfilesystem abstractrunner access 100 webhdfsfilesystem java 472 at org apache hadoop hdfs web webhdfsfilesystem abstractrunner 1 run webhdfsfilesystem java 502 at java security accesscontroller doprivilege native method at javax security auth subject doas subject java 422 at org apache hadoop security usergroupinformation doas usergroupinformation java 1698 at org apache hadoop hdfs web webhdfsfilesystem abstractrunner run webhdfsfilesystem java 498 at org apache hadoop hdfs web webhdfsfilesystem liststatus webhdfsfilesystem java 1330 at org apache hadoop fs filesystem liststatus filesystem java 1517 at org apache hadoop fs filesystem liststatus filesystem java 1557 at org apache hadoop fs filesystem 4 filesystem java 1714 at org apache hadoop fs filesystem listlocatedstatus filesystem java 1713 at org apache hadoop fs filesystem listlocatedstatus filesystem java 1696 at com facebook presto hadoop hadoopfilesystem listlocatedstatus hadoopfilesystem java 30 at com facebook presto hive hadoopdirectorylister list hadoopdirectorylister java 32 at com facebook presto hive util hivefileiterator getlocatedfilestatusremoteiterator hivefileiterator java 113 at com facebook presto hive util hivefileiterator computenext hivefileiterator java 86 at com facebook presto hive util hivefileiterator computenext hivefileiterator java 41 at com google common collect abstractiterator trytocomputenext abstractiterator java 143 at com google common collect abstractiterator hasnext abstractiterator java 138 at com facebook presto hive backgroundhivesplitloader loadsplit backgroundhivesplitloader java 227 at com facebook presto hive backgroundhivesplitloader access 300 backgroundhivesplitloader java 78 at com facebook presto hive backgroundhivesplitloader hivesplitloadertask process backgroundhivesplitloader java 179 at com facebook presto hive util resumabletask safeprocesstask resumabletask java 45 at com facebook presto hive util resumabletask lambda submit 1 resumabletask java 33 at io airlift concurrent boundedexecutor drainqueue boundedexecutor java 77 at java util concurrent threadpoolexecutor runworker threadpoolexecutor java 1142 at java util concurrent threadpoolexecutor worker run threadpoolexecutor java 617 at java lang thread run thread java 745 if I use hdfs it work well but if presto support webhdfs it would be nice create external table hoge partition by store as rcfile location hdfs
prestodbpresto
add current user function
Enhancement
it would be very nice if we can implement current user function which return the current user s username or I would like to ask if it be any way to get current username within a presto query
prestodbpresto
enhance merge non identical window to collapse window across different node
Enhancement
this be a continuation of as current implementation 6009 be limit to merge adjacent window in a plan we need a way to merge window across other node example sql explain select sum x over lag x 1 over from value 1 t x query plan output col0 col1 sum bigint lag integer col0 sum col1 lag project sum bigint lag integer localexchange round robin field integer sum bigint expr 2 bigint lag integer window field integer sum bigint expr 2 bigint lag integer lag lag field expr 2 localexchange single field integer sum bigint expr 2 bigint project expr 2 bigint sum bigint field integer expr 2 bigint 1 localexchange round robin field integer x bigint sum bigint window field integer x bigint sum bigint sum sum x localexchange single field integer x bigint project field integer x bigint x cast field as bigint localexchange round robin field integer value field integer 1 these two window can not be merge because there s localexchange and project between they
prestodbpresto
constant folding for aggregation
Enhancement
a query like select approx percentile orderkey array 0 001 from order project the array 0 001 for every row in order and result in a plan like below presto sf100 explain analyze select approx percentile orderkey array 0 001 from order query plan fragment 1 single cost cpu 4 38 input 4320 802 mb output 1 14b output layout approx percentile output partition single output query plan approx percentile array bigint cost 0 00 output 1 row 14b query plan approx percentile aggregate final approx percentile array bigint cost 99 34 output 1 row 14b approx percentile approx percentile approx percentile 5 remotesource 2 approx percentile 5 varbinary cost 0 66 output 4320 row 802 mb fragment 2 tpch order 150000000 cost cpu 20 17 m input 150000000 3 21 gb output 4320 802 02 mb output layout approx percentile 5 output partition single aggregate partial approx percentile 5 varbinary cost 7 54 output 4320 row 802 02 mb approx percentile 5 approx percentile orderkey expr project expr array double orderkey bigint cost 92 46 output 150000000 row 3 21 gb expr literal array double from base64 cgaaaexptkdfqvjsqvkbaaaaapyp8djnyla tablescan tpch tpch order sf100 0 originalconstraint true orderkey bigint cost unknown output unknown orderkey tpch orderkey 1 row this be very inefficient if you have an array with 1000 element we should fold these constant into the aggregate operation instead of produce they in the project
prestodbpresto
markdistinct should be aware of node distribution in addexchange optimizer
Enhancement
currently it be only stream distribution aware and this doesn t help we in case where the datum be just node distribute e g in raptor in those case each count distinct operation result in another stage in the plan
prestodbpresto
some test do fail due to translate exception getmessage
Bug
some of recently add test do check message of runtimeexception message of some jdbc connector be translate to system language and at least on mac for that reason the test fail test on polish as system language one example of that be fbd8dd8c385015a7618aaa3751135f1d8dab8dd2 testdbresourcegroupconfigurationmanager testduplicate 86 asserttrue ex getcause getmessage startswith unique index or primary key violation but it would be nice to make sure that all standard test that be start by mvn clean install do pass on different system language the fix be to force language for test or to avoid check exception getmessage content
prestodbpresto
supertype not recognize in simple case if in subquery any subquery all subquery
Bug
presto sf1 select if 1 1 0 1 query 20161117 123322 00020 dd5yv fail line 1 11 if condition must evaluate to a boolean actual integer cc kokose ilfrin martint arhimondr this issue be cause by expressionanalyzer coercetosingletype which doesn t use getcommonsupertype
prestodbpresto
incorrect any all subquery result with null row or empty subquery result
Bug
presto empty subquery table presto sf1 select 1 all select 1 where false col0 null 1 row presto sf1 select 1 all select 1 where false col0 null 1 row presto null row subquery presto sf1 select 1 all value null query 20161117 084642 00001 h4d5y fail can not resolve symbol min presto sf1 select 1 any value null query 20161117 112202 00006 tje4f fail expect method methodhandle blockstate block void parameter 1 type to be void unknown postgresql empty subquery table postgre select 1 all select 1 where false column t 1 row postgre select 1 any select 1 where false column f 1 row postgresql null row subquery postgre select 1 any select null error fail to find conversion function from unknown to integer postgre select 1 all select null error fail to find conversion function from unknown to integer cc martint kokose
prestodbpresto
unable to start server when cassandra host be not resolvable
Bug
unable to start presto with cassandra connector when cassandra host cassandra contact point from cassandra property be not resolvable to an ip 2016 11 16t09 24 39 229z error main com facebook presto server prestoserver unable to create injector see the follow error 1 error in custom provider java lang illegalargumentexception cassandra unknown error at com facebook presto cassandra cassandraclientmodule createcassandrasession cassandraclientmodule java 99 at com facebook presto cassandra cassandraclientmodule createcassandrasession cassandraclientmodule java 99 while locate com facebook presto cassandra cassandrasession cause by java lang illegalargumentexception cassandra unknown error at com datastax driver core cluster builder addcontactpoint cluster java 839 at com datastax driver core cluster builder addcontactpoint cluster java 859 at com facebook presto cassandra cassandraclientmodule createcassandrasession cassandraclientmodule java 106 at com facebook presto cassandra cassandraclientmodule fastclassbyguice 2bcb94b1 invoke at com google inject internal providermethod fastclassprovidermethod doprovision providermethod java 272 at com google inject internal providermethod get providermethod java 172 at com google inject internal providerinternalfactory provision providerinternalfactory java 81 at com google inject internal internalfactorytoinitializableadapter provision internalfactorytoinitializableadapter java 53 at com google inject internal providerinternalfactory circularget providerinternalfactory java 61 at com google inject internal internalfactorytoinitializableadapter get internalfactorytoinitializableadapter java 45 at com google inject internal providertointernalfactoryadapter 1 call providertointernalfactoryadapter java 46 at com google inject internal injectorimpl callincontext injectorimpl java 1103 at com google inject internal providertointernalfactoryadapter get providertointernalfactoryadapter java 40 at com google inject internal singletonscope 1 get singletonscope java 145 at com google inject internal internalfactorytoprovideradapter get internalfactorytoprovideradapter java 41 at com google inject internal internalinjectorcreator 1 call internalinjectorcreator java 205 at com google inject internal internalinjectorcreator 1 call internalinjectorcreator java 199 at com google inject internal injectorimpl callincontext injectorimpl java 1092 at com google inject internal internalinjectorcreator loadeagersingleton internalinjectorcreator java 199 at com google inject internal internalinjectorcreator injectdynamically internalinjectorcreator java 180 at com google inject internal internalinjectorcreator build internalinjectorcreator java 110 at com google inject guice createinjector guice java 96 at io airlift bootstrap bootstrap initialize bootstrap java 242 at com facebook presto cassandra cassandraconnectorfactory create cassandraconnectorfactory java 82 at com facebook presto connector connectormanager createconnector connectormanager java 304 at com facebook presto connector connectormanager addcatalogconnector connectormanager java 193 at com facebook presto connector connectormanager createconnection connectormanager java 185 at com facebook presto connector connectormanager createconnection connectormanager java 171 at com facebook presto metadata staticcatalogstore loadcatalog staticcatalogstore java 99 at com facebook presto metadata staticcatalogstore loadcatalog staticcatalogstore java 77 at com facebook presto server prestoserver run prestoserver java 120 at com facebook presto server prestoserver main prestoserver java 67 at sun reflect nativemethodaccessorimpl invoke0 native method at sun reflect nativemethodaccessorimpl invoke nativemethodaccessorimpl java 62 at sun reflect delegatingmethodaccessorimpl invoke delegatingmethodaccessorimpl java 43 at java lang reflect method invoke method java 498 at com intellij rt execution application appmain main appmain java 147 cc maciejgrzybek
prestodbpresto
move correlate predicate out of the subquery
Enhancement
1 in the subquery add the non correlate column in the correlate predicate to the select list 2 move the subquery to the from clause in the outer query block 3 move the correlate predicate to either where clause or the on clause correspond to the moved subquery in the outer query block 4 update the column reference in the correlate predicate to point to the column project out of the subquery 5 add distinct to the subquery or indicate that the subquery be semi join when it be possible before select c custkey c name from customer where exist select from order where o orderdate 1995 01 01 and o totalprice c acctbal after select c custkey c name from customer select distinct o custkey from order where o orderdate 1995 01 01 as v where v o totalprice c acctbal this should affect performance of tpch q4 q21 and q22
prestodbpresto
unable to create plan for query with duplicate in predicate
Bug
presto tiny select 1 in select 1 2 in select 1 where 1 in select 1 query 20161116 072550 00005 ztdnc fail invalid node expression dependency semijoin result not in source plan output expr 4 hashvalue 22 semijoin result 17 java lang illegalargumentexception invalid node expression dependency semijoin result not in source plan output expr 4 hashvalue 22 semijoin result 17 at com google common base precondition checkargument precondition java 145 at com facebook presto sql planner sanity validatedependencieschecker checkdependencie validatedependencieschecker java 610 at com facebook presto sql planner sanity validatedependencieschecker access 100 validatedependencieschecker java 77 at com facebook presto sql planner sanity validatedependencieschecker visitor visitproject validatedependencieschecker java 257 at com facebook presto sql planner sanity validatedependencieschecker visitor visitproject validatedependencieschecker java 91 at com facebook presto sql planner plan projectnode accept projectnode java 81 at com facebook presto sql planner sanity validatedependencieschecker visitor visitexchange validatedependencieschecker java 469 at com facebook presto sql planner sanity validatedependencieschecker visitor visitexchange validatedependencieschecker java 91 at com facebook presto sql planner plan exchangenode accept exchangenode java 208 at com facebook presto sql planner sanity validatedependencieschecker visitor visitoutput validatedependencieschecker java 300 at com facebook presto sql planner sanity validatedependencieschecker visitor visitoutput validatedependencieschecker java 91 at com facebook presto sql planner plan outputnode accept outputnode java 81 at com facebook presto sql planner sanity validatedependencieschecker validate validatedependencieschecker java 88 at com facebook presto sql planner sanity validatedependencieschecker validate validatedependencieschecker java 83 at com facebook presto sql planner sanity plansanitychecker lambda validate 0 plansanitychecker java 43 at java lang iterable foreach iterable java 75 at com facebook presto sql planner sanity plansanitychecker validate plansanitychecker java 43 at com facebook presto sql planner logicalplanner plan logicalplanner java 125 at com facebook presto sql planner logicalplanner plan logicalplanner java 109 at com facebook presto execution sqlqueryexecution doanalyzequery sqlqueryexecution java 292 at com facebook presto execution sqlqueryexecution analyzequery sqlqueryexecution java 271 at com facebook presto execution sqlqueryexecution start sqlqueryexecution java 229 at com facebook presto execution queuedexecution lambda start 1 queuedexecution java 62 at java util concurrent threadpoolexecutor runworker threadpoolexecutor java 1142 at java util concurrent threadpoolexecutor worker run threadpoolexecutor java 617 at java lang thread run thread java 745
prestodbpresto
incorrect result when use null in empty subquery
Bug
presto tiny select x from value null 1 t x where x in select from value 1 p y where y 0 be null x null 1 row the query be expect to return an empty result set
prestodbpresto
use limit for automatic join order
Enhancement
consider the follow query sql select from select from a limit 10000 join b the subquery should be assume to be the small side of the join since it have a small fix bind on the number of row
prestodbpresto
add function for parse string with unicode escape
Enhancement
it should be able to handle uxxxx sequence
prestodbpresto
uncategorized error when cast nan or infinite to decimal
Bug
select cast nan as decimal 1 1 query 20161111 172739 13734 rka4f fail infinite or nan java lang numberformatexception infinite or nan at java math bigdecimal bigdecimal java 895 at java math bigdecimal bigdecimal java 872 at com facebook presto type decimalcast doubletoshortdecimal decimalcast java 427 at java lang invoke methodhandle invokewithargument methodhandle java 627 at java lang invoke methodhandle invokewithargument methodhandle java 649 at com facebook presto sql planner expressioninterpreter invoke expressioninterpreter java 1312 at com facebook presto sql planner expressioninterpreter visitor visitcast expressioninterpreter java 1093 at com facebook presto sql tree cast accept cast java 94 at com facebook presto sql tree astvisitor process astvisitor java 22 at com facebook presto sql planner expressioninterpreter optimize expressioninterpret java 264 at com facebook presto sql planner optimizations simplifyexpression rewriter simplifyexpression simplifyexpression java 157 at com google common collect map 7 transformentry map java 1812 at com google common collect map 10 getvalue map java 1857 at com google common collect immutablemap copyof immutablemap java 292 at com facebook presto sql planner optimization simplifyexpression rewriter visitproject simplifyexpression java 111 at com facebook presto sql planner optimization simplifyexpression rewriter visitproject simplifyexpression java 89 at com facebook presto sql planner plan projectnode accept projectnode java 81 at com facebook presto sql planner plan simpleplanrewriter rewritecontext rewrite simpleplanrewriter java 85 at com facebook presto sql planner plan simpleplanrewriter rewritecontext rewrite simpleplanrewriter java 96 at com facebook presto sql planner optimization simplifyexpression rewriter visitproject simplifyexpression java 110 at com facebook presto sql planner optimization simplifyexpression rewriter visitproject simplifyexpression java 89 at com facebook presto sql planner plan projectnode accept projectnode java 81 at com facebook presto sql planner plan simpleplanrewriter rewritecontext rewrite simpleplanrewriter java 85 at com facebook presto sql planner plan simpleplanrewriter rewritecontext rewrite simpleplanrewriter java 96 at com facebook presto sql planner optimization simplifyexpression rewriter visitproject simplifyexpression java 110 at com facebook presto sql planner optimization simplifyexpression rewriter visitproject simplifyexpression java 89 at com facebook presto sql planner plan projectnode accept projectnode java 81 at com facebook presto sql planner plan simpleplanrewriter rewritecontext rewrite simpleplanrewriter java 85 at com facebook presto sql planner plan simpleplanrewriter rewritecontext rewrite simpleplanrewriter java 96 at com facebook presto sql planner optimization simplifyexpression rewriter visitproject simplifyexpression java 110 at com facebook presto sql planner optimization simplifyexpression rewriter visitproject simplifyexpression java 89 at com facebook presto sql planner plan projectnode accept projectnode java 81 at com facebook presto sql planner plan simpleplanrewriter rewritecontext rewrite simpleplanrewriter java 85 at com facebook presto sql planner plan simpleplanrewriter rewritecontext lambda defaultrewrite 0 simpleplanrewriter java 74 at java util stream referencepipeline 3 1 accept referencepipeline java 193 at java util iterator foreachremaine iterator java 116 at java util spliterators iteratorspliterator foreachremaine spliterator java 1801 at java util stream abstractpipeline copyinto abstractpipeline java 481 at java util stream abstractpipeline wrapandcopyinto abstractpipeline java 471 at java util stream reduceop reduceop evaluatesequential reduceop java 708 at java util stream abstractpipeline evaluate abstractpipeline java 234 at java util stream referencepipeline collect referencepipeline java 499 at com facebook presto sql planner plan simpleplanrewriter rewritecontext defaultrewrite simpleplanrewriter java 75 at com facebook presto sql planner plan simpleplanrewriter visitplan simpleplanrewriter java 39 at com facebook presto sql planner plan simpleplanrewriter visitplan simpleplanrewriter java 23 at com facebook presto sql planner plan planvisitor visitoutput planvisitor java 50 at com facebook presto sql planner plan outputnode accept outputnode java 81 at com facebook presto sql planner plan simpleplanrewriter rewritewith simpleplanrewriter java 28 at com facebook presto sql planner optimization simplifyexpression optimize simplifyexpression java 86 at com facebook presto sql planner logicalplanner plan logicalplanner java 118 at com facebook presto sql planner logicalplanner plan logicalplanner java 109 at com facebook presto execution sqlqueryexecution doanalyzequery sqlqueryexecution java 288 at com facebook presto execution sqlqueryexecution analyzequery sqlqueryexecution java 267 at com facebook presto execution sqlqueryexecution start sqlqueryexecution java 225 at java util concurrent threadpoolexecutor runworker threadpoolexecutor java 1142 at java util concurrent threadpoolexecutor worker run threadpoolexecutor java 617 at java lang thread run thread java 745 it should be categorize as invalid function argument
prestodbpresto
add ability to call mysql procedure from presto
Enhancement
presto default select from mysql mp commerce test idt testcol 1 hair care 2 body care 3 kit gift set 3 row query 20161111 022956 00023 ki3sk finish 2 node split 2 total 2 do 100 00 0 00 3 row 0b 7 rows s 0b s presto default call mysql mp commerce new procedure query 20161111 023022 00024 ki3sk fail procedure not register mysql mp commerce new procedure
prestodbpresto
explain analyze incorrectly strip off output column
Bug
explain analyze currently strip off output column of a query which be a problem because it change the performance characteristic of the query for example if I have a query with 1000 group by aggregate the explain analyze will only run with 1 of the group by aggregate
prestodbpresto
support unicode escape string
Enhancement
the standard specify a slightly strange syntax for string literal with escaped unicode in 9075 2 2011 section 5 3 the starting token in the grammar be the postgresql manual give an overview sql syntax string uescape
prestodbpresto
categorize ioexception when read hive table
Enhancement
it should be categorize as hive bad datum java io ioexception incorrect header check java lang runtimeexception com google common base throwable propagate throwable java 160 com facebook presto hive columnarbinaryhiverecordcursor parselongcolumn columnarbinaryhiverecordcursor java 319 com facebook presto hive columnarbinaryhiverecordcursor parsecolumn columnarbinaryhiverecordcursor java 688 com facebook presto hive columnarbinaryhiverecordcursor isnull columnarbinaryhiverecordcursor java 676 com facebook presto hive hiverecordcursor isnull hiverecordcursor java 237 com facebook presto gen cursorprocessor 58220 filter unknown source com facebook presto gen cursorprocessor 58220 process unknown source com facebook presto operator scanfilterandprojectoperator getoutput scanfilterandprojectoperator java 223 com facebook presto operator driver processinternal driver java 378 com facebook presto operator driver processfor driver java 301 com facebook presto execution sqltaskexecution driversplitrunner processfor sqltaskexecution java 622 com facebook presto execution taskexecutor prioritizedsplitrunner process taskexecutor java 534 com facebook presto execution taskexecutor runner run taskexecutor java 670 java util concurrent threadpoolexecutor runworker threadpoolexecutor java 1142 java util concurrent threadpoolexecutor worker run threadpoolexecutor java 617 java lang thread run thread java 745
prestodbpresto
display well error message for unsupported correlate query shape
Enhancement
the message that s currently report be not very helpful we should validate the shape of the query during analysis and show a more meaningful message for example for a query like sql select from t where t x in select distinct t y from u it should say something like correlate subquerie use distinct not support and possibly include the name of the field reference from the outer scope sometimes a typo in a column name can turn a subquery into a correlate one
prestodbpresto
add support for distinct in selective aggregate
Enhancement
currently distinct can not be use with selective aggregate sql select count distinct custkey filter where orderkey 10 from tpch tiny order com facebook presto sql analyzer semanticexception line 1 8 filter aggregation not support with distinct count distinct custkey filter where orderkey 10 at com facebook presto sql analyzer aggregationanalyzer visitor visitfunctioncall aggregationanalyzer java 303 at com facebook presto sql analyzer aggregationanalyzer visitor visitfunctioncall aggregationanalyzer java 148 at com facebook presto sql tree functioncall accept functioncall java 109 at com facebook presto sql tree astvisitor process astvisitor java 22 at com facebook presto sql analyzer aggregationanalyzer visitor process aggregationanalyzer java 490 at com facebook presto sql analyzer aggregationanalyzer analyze aggregationanalyzer java 143 at com facebook presto sql analyzer statementanalyzer verifyaggregation statementanalyzer java 1416 at com facebook presto sql analyzer statementanalyzer analyzeaggregation statementanalyzer java 1377 at com facebook presto sql analyzer statementanalyzer visitqueryspecification statementanalyzer java 634 at com facebook presto sql analyzer statementanalyzer visitqueryspecification statementanalyzer java 160 at com facebook presto sql tree queryspecification accept queryspecification java 125 at com facebook presto sql tree astvisitor process astvisitor java 22 at com facebook presto sql analyzer statementanalyzer visitquery statementanalyzer java 402 at com facebook presto sql analyzer statementanalyzer visitquery statementanalyzer java 160 at com facebook presto sql tree query accept query java 92 at com facebook presto sql tree astvisitor process astvisitor java 22 at com facebook presto sql analyzer analyzer analyze analyzer java 67 at com facebook presto sql analyzer analyzer analyze analyzer java 59 at com facebook presto execution sqlqueryexecution doanalyzequery sqlqueryexecution java 281 at com facebook presto execution sqlqueryexecution analyzequery sqlqueryexecution java 267 at com facebook presto execution sqlqueryexecution start sqlqueryexecution java 225 at java util concurrent threadpoolexecutor runworker threadpoolexecutor java 1142 at java util concurrent threadpoolexecutor worker run threadpoolexecutor java 617 at java lang thread run thread java 745
prestodbpresto
invalid plan for query involve an aggregation subquery join to a partition table
Bug
give this hive table sql create table t a bigint ds varchar with partition by array ds the follow query fail with an exception during planning sql select from select count from tpch tiny order have count distinct custkey 1 cross join t java lang illegalargumentexception output layout count 20 don t include all partition column custkey at com google common base precondition checkargument precondition java 145 at com facebook presto sql planner partitioningscheme partitioningscheme java 70 at com facebook presto sql planner partitioningscheme partitioningscheme java 50 at com facebook presto sql planner optimization partialaggregationpushdown rewriter visitexchange partialaggregationpushdown java 165 at com facebook presto sql planner optimization partialaggregationpushdown rewriter visitexchange partialaggregationpushdown java 69 at com facebook presto sql planner plan exchangenode accept exchangenode java 208 at com facebook presto sql planner plan simpleplanrewriter rewritecontext rewrite simpleplanrewriter java 85 at com facebook presto sql planner optimization partialaggregationpushdown rewriter visitexchange partialaggregationpushdown java 155 at com facebook presto sql planner optimization partialaggregationpushdown rewriter visitexchange partialaggregationpushdown java 69 at com facebook presto sql planner plan exchangenode accept exchangenode java 208 at com facebook presto sql planner plan simpleplanrewriter rewritecontext rewrite simpleplanrewriter java 85 at com facebook presto sql planner optimization partialaggregationpushdown rewriter visitaggregation partialaggregationpushdown java 126 at com facebook presto sql planner optimization partialaggregationpushdown rewriter visitaggregation partialaggregationpushdown java 69 at com facebook presto sql planner plan aggregationnode accept aggregationnode java 185 at com facebook presto sql planner plan simpleplanrewriter rewritecontext rewrite simpleplanrewriter java 85 at com facebook presto sql planner plan simpleplanrewriter rewritecontext lambda defaultrewrite 0 simpleplanrewriter java 74 at java util stream referencepipeline 3 1 accept referencepipeline java 193 at java util iterator foreachremaine iterator java 116 at java util spliterators iteratorspliterator foreachremaine spliterator java 1801 at java util stream abstractpipeline copyinto abstractpipeline java 481 at java util stream abstractpipeline wrapandcopyinto abstractpipeline java 471 at java util stream reduceop reduceop evaluatesequential reduceop java 708 at java util stream abstractpipeline evaluate abstractpipeline java 234 at java util stream referencepipeline collect referencepipeline java 499 at com facebook presto sql planner plan simpleplanrewriter rewritecontext defaultrewrite simpleplanrewriter java 75 at com facebook presto sql planner plan simpleplanrewriter rewritecontext defaultrewrite simpleplanrewriter java 64 at com facebook presto sql planner optimization partialaggregationpushdown rewriter visitexchange partialaggregationpushdown java 141 at com facebook presto sql planner optimization partialaggregationpushdown rewriter visitexchange partialaggregationpushdown java 69 at com facebook presto sql planner plan exchangenode accept exchangenode java 208 at com facebook presto sql planner plan simpleplanrewriter rewritecontext rewrite simpleplanrewriter java 85 at com facebook presto sql planner plan simpleplanrewriter rewritecontext lambda defaultrewrite 0 simpleplanrewriter java 74 at java util stream referencepipeline 3 1 accept referencepipeline java 193 at java util iterator foreachremaine iterator java 116 at java util spliterators iteratorspliterator foreachremaine spliterator java 1801 at java util stream abstractpipeline copyinto abstractpipeline java 481 at java util stream abstractpipeline wrapandcopyinto abstractpipeline java 471 at java util stream reduceop reduceop evaluatesequential reduceop java 708 at java util stream abstractpipeline evaluate abstractpipeline java 234 at java util stream referencepipeline collect referencepipeline java 499 at com facebook presto sql planner plan simpleplanrewriter rewritecontext defaultrewrite simpleplanrewriter java 75 at com facebook presto sql planner plan simpleplanrewriter visitplan simpleplanrewriter java 39 at com facebook presto sql planner plan simpleplanrewriter visitplan simpleplanrewriter java 23 at com facebook presto sql planner plan planvisitor visitfilter planvisitor java 35 at com facebook presto sql planner plan filternode accept filternode java 71 at com facebook presto sql planner plan simpleplanrewriter rewritecontext rewrite simpleplanrewriter java 85 at com facebook presto sql planner plan simpleplanrewriter rewritecontext lambda defaultrewrite 0 simpleplanrewriter java 74 at java util stream referencepipeline 3 1 accept referencepipeline java 193 at java util iterator foreachremaine iterator java 116 at java util spliterators iteratorspliterator foreachremaine spliterator java 1801 at java util stream abstractpipeline copyinto abstractpipeline java 481 at java util stream abstractpipeline wrapandcopyinto abstractpipeline java 471 at java util stream reduceop reduceop evaluatesequential reduceop java 708 at java util stream abstractpipeline evaluate abstractpipeline java 234 at java util stream referencepipeline collect referencepipeline java 499 at com facebook presto sql planner plan simpleplanrewriter rewritecontext defaultrewrite simpleplanrewriter java 75 at com facebook presto sql planner plan simpleplanrewriter visitplan simpleplanrewriter java 39 at com facebook presto sql planner plan simpleplanrewriter visitplan simpleplanrewriter java 23 at com facebook presto sql planner plan planvisitor visitjoin planvisitor java 90 at com facebook presto sql planner plan joinnode accept joinnode java 170 at com facebook presto sql planner plan simpleplanrewriter rewritecontext rewrite simpleplanrewriter java 85 at com facebook presto sql planner plan simpleplanrewriter rewritecontext lambda defaultrewrite 0 simpleplanrewriter java 74 at java util stream referencepipeline 3 1 accept referencepipeline java 193 at java util iterator foreachremaine iterator java 116 at java util spliterators iteratorspliterator foreachremaine spliterator java 1801 at java util stream abstractpipeline copyinto abstractpipeline java 481 at java util stream abstractpipeline wrapandcopyinto abstractpipeline java 471 at java util stream reduceop reduceop evaluatesequential reduceop java 708 at java util stream abstractpipeline evaluate abstractpipeline java 234 at java util stream referencepipeline collect referencepipeline java 499 at com facebook presto sql planner plan simpleplanrewriter rewritecontext defaultrewrite simpleplanrewriter java 75 at com facebook presto sql planner plan simpleplanrewriter visitplan simpleplanrewriter java 39 at com facebook presto sql planner plan simpleplanrewriter visitplan simpleplanrewriter java 23 at com facebook presto sql planner plan planvisitor visitoutput planvisitor java 50 at com facebook presto sql planner plan outputnode accept outputnode java 81 at com facebook presto sql planner plan simpleplanrewriter rewritewith simpleplanrewriter java 33 at com facebook presto sql planner optimization partialaggregationpushdown optimize partialaggregationpushdown java 66 at com facebook presto sql planner logicalplanner plan logicalplanner java 118 at com facebook presto sql planner logicalplanner plan logicalplanner java 109 at com facebook presto execution sqlqueryexecution doanalyzequery sqlqueryexecution java 288 at com facebook presto execution sqlqueryexecution analyzequery sqlqueryexecution java 267 at com facebook presto execution sqlqueryexecution start sqlqueryexecution java 225 at java util concurrent threadpoolexecutor runworker threadpoolexecutor java 1142 at java util concurrent threadpoolexecutor worker run threadpoolexecutor java 617 at java lang thread run thread java 745
prestodbpresto
npe when table be bucket on non existent column
Bug
give this table which be allegedly bucket on a non existent column create table foo a bigint with bucket by array b bucket count 1000 query the table fail with java lang nullpointerexception at java util stream referencepipeline 3 1 accept referencepipeline java 193 at java util arraylist arraylistspliterator foreachremaine arraylist java 1374 at java util stream abstractpipeline copyinto abstractpipeline java 481 at java util stream abstractpipeline wrapandcopyinto abstractpipeline java 471 at java util stream reduceop reduceop evaluatesequential reduceop java 708 at java util stream abstractpipeline evaluate abstractpipeline java 234 at java util stream referencepipeline collect referencepipeline java 499 at com facebook presto hive hivemetadata lambda gettablelayout 6 hivemetadata java 1037 at java util optional map optional java 215 at com facebook presto hive hivemetadata gettablelayout hivemetadata java 1031 at com facebook presto hive hivemetadata gettablelayouts hivemetadata java 999 at com facebook presto hive prismmetadata gettablelayout prismmetadata java 386 at com facebook presto spi connector classloader classloadersafeconnectormetadata gettablelayout classloadersafeconnectormetadata java 69 at com facebook presto metadata metadatamanager getlayout metadatamanager java 298 at com facebook presto sql planner optimization addexchange rewriter plantablescan addexchange java 583 at com facebook presto sql planner optimizations addexchange rewriter visittablescan addexchange java 535 at com facebook presto sql planner optimizations addexchange rewriter visittablescan addexchange java 197 at com facebook presto sql planner plan tablescannode accept tablescannode java 135 at com facebook presto sql planner optimizations addexchange rewriter planchild addexchange java 1169 at com facebook presto sql planner optimizations addexchange rewriter visitoutput addexchange java 244 at com facebook presto sql planner optimizations addexchange rewriter visitoutput addexchange java 197 at com facebook presto sql planner plan outputnode accept outputnode java 81 at com facebook presto sql planner optimization addexchange optimize addexchange java 147 at com facebook presto sql planner logicalplanner plan logicalplanner java 118 at com facebook presto sql planner logicalplanner plan logicalplanner java 109 at com facebook presto execution sqlqueryexecution doanalyzequery sqlqueryexecution java 288 at com facebook presto execution sqlqueryexecution analyzequery sqlqueryexecution java 267 at com facebook presto execution sqlqueryexecution start sqlqueryexecution java 225 at java util concurrent threadpoolexecutor runworker threadpoolexecutor java 1142 at java util concurrent threadpoolexecutor worker run threadpoolexecutor java 617 at java lang thread run thread java 745 this be relate to
prestodbpresto
hive table can be bucket on non existent column
Bug
this statement succeed even though the table do contain a column name b sql create table foo a bigint with bucket by array b bucket count 1000
prestodbpresto
plan error for query contain disjunction and in subquery predicate
Bug
sql select from tpch tiny order where orderkey in value 1 or true fail with java lang illegalargumentexception unsupported subquery type at com facebook presto sql planner sanity noapplynodeleftchecker 1 visitapply noapplynodeleftchecker java 39 at com facebook presto sql planner plan applynode accept applynode java 96 at com facebook presto sql planner simpleplanvisitor visitplan simpleplanvisitor java 26 at com facebook presto sql planner simpleplanvisitor visitplan simpleplanvisitor java 19 at com facebook presto sql planner plan planvisitor visitexchange planvisitor java 175 at com facebook presto sql planner plan exchangenode accept exchangenode java 208 at com facebook presto sql planner simpleplanvisitor visitplan simpleplanvisitor java 26 at com facebook presto sql planner simpleplanvisitor visitplan simpleplanvisitor java 19 at com facebook presto sql planner plan planvisitor visitoutput planvisitor java 50 at com facebook presto sql planner plan outputnode accept outputnode java 81 at com facebook presto sql planner sanity noapplynodeleftchecker validate noapplynodeleftchecker java 33 at com facebook presto sql planner sanity plansanitychecker lambda validate 0 plansanitychecker java 42 at java lang iterable foreach iterable java 75 at com facebook presto sql planner sanity plansanitychecker validate plansanitychecker java 42 at com facebook presto sql planner logicalplanner plan logicalplanner java 123 at com facebook presto sql planner logicalplanner plan logicalplanner java 107 at com facebook presto execution sqlqueryexecution doanalyzequery sqlqueryexecution java 291 at com facebook presto execution sqlqueryexecution analyzequery sqlqueryexecution java 270 at com facebook presto execution sqlqueryexecution start sqlqueryexecution java 228 at com facebook presto execution queuedexecution lambda start 1 queuedexecution java 62 at java util concurrent threadpoolexecutor runworker threadpoolexecutor java 1142 at java util concurrent threadpoolexecutor worker run threadpoolexecutor java 617 at java lang thread run thread java 745
prestodbpresto
uncategorized error for from unixtime
Bug
invalid offset minute 1080 java lang illegalargumentexception com facebook presto spi type timezonekey checkargument timezonekey java 300 com facebook presto spi type timezonekey gettimezonekeyforoffset timezonekey java 140 com facebook presto spi type datetimeencoding packdatetimewithzone datetimeencode java 41 com facebook presto operator scalar datetimefunction fromunixtime datetimefunction java 149 com facebook presto gen pageprocessor 14559 project 1 unknown source com facebook presto gen pageprocessor 14559 process unknown source com facebook presto operator filterandprojectoperator getoutput filterandprojectoperator java 111 com facebook presto operator driver processinternal driver java 378 com facebook presto operator driver processfor driver java 301 com facebook presto execution sqltaskexecution driversplitrunner processfor sqltaskexecution java 622 com facebook presto execution taskexecutor prioritizedsplitrunner process taskexecutor java 534 com facebook presto execution taskexecutor runner run taskexecutor java 670 java util concurrent threadpoolexecutor runworker threadpoolexecutor java 1142 java util concurrent threadpoolexecutor worker run threadpoolexecutor java 617 java lang thread run thread java 745
prestodbpresto
add raptor metadata db optimization
Enhancement
fix 6497
prestodbpresto
support all and any for unorderable type
Enhancement
current implementation of quantify comparison predicate do in support all and any only for orderable type however the type doesn t have to be orderable and can be just comparable to be use with these quantifier an example of a comparable but unorderable type be map type a possible approach to implement it be to use distinct with limit in a subquery a all b a arbitrary b count distinct b 1 we might be able to rewrite the query along these line x select arbitrary y from b have count distinct y 1 compute count distinct y could get expensive we could far improve it by do something like this which take advantage of the distinct limit optimization x select arbitrary y from select distinct y from b limit 2 have count distinct y 1 note it might be more efficient to keep the current implementation use min max if the type be orderable as it could be more efficient
prestodbpresto
expression in on clause not remove when implicit cast insert in comparison
Enhancement
in the follow query the expression a comment x should be remove from the on clause but once the engine insert the implicit widening cast cast x as varchar 79 the expression be not remove sql select count from tpch tiny order a join tpch tiny order b on a comment x text output col0 count bigint col0 count aggregate final count bigint count count count 23 remoteexchange gather count 23 bigint aggregate partial count 24 bigint count 24 count project innerjoin comment 17 expr 18 comment varchar 79 comment 17 varchar 79 expr 10 varchar 79 expr 18 varchar 79 remoteexchange repartition comment varchar 79 comment 17 varchar 79 filter comment cast x as varchar 79 comment varchar 79 tablescan tpch tpch order sf0 01 originalconstraint comment cast x as varchar 79 comment varchar 79 comment tpch comment remoteexchange repartition expr 10 varchar 79 expr 18 varchar 79 project expr 10 varchar 79 expr 10 cast x as varchar 79 tablescan tpch tpch order sf0 01 originalconstraint true
prestodbpresto
track per operator peak memory
Enhancement
be able to compute the bad case memory usage for a query require know what be the peak amount of memory use by each operator we currently track instantaneous peak memory which be sensitive to scheduling decision and time
prestodbpresto
incorrect plan when hash pre computation be on
Bug
give this table sql create table u as select x y from value a 0 b 1 t x y the follow query may randomly produce an invalid plan which cause the query to produce 0 as a result instead of 1 sql with t as select x y from u group by 1 2 select count from t a join t b on a x a and a y b y 1 correct plan fragment 0 single output layout count output partition single output col0 count bigint col0 count aggregate final count bigint count count count 46 remotesource 1 count 46 bigint fragment 1 hash output layout count 47 output partition single aggregate partial count 47 bigint count 47 count innerjoin x expr 39 and y expr 41 x varchar y integer hashvalue bigint expr 28 varchar expr 29 integer expr 39 varchar expr 41 integer hashvalue 49 bigint aggregate final x y x varchar y integer hashvalue bigint remotesource 2 x varchar y integer hashvalue bigint project expr 28 varchar expr 29 integer expr 39 varchar expr 41 integer hashvalue 49 bigint remotesource 3 expr 28 varchar expr 29 integer expr 39 varchar expr 41 integer hashvalue 49 bigint hashvalue 50 bigint fragment 2 source output layout x y hashvalue 48 output partition hash x y aggregate partial x y x varchar y integer hashvalue 48 bigint project x varchar y integer hashvalue 48 bigint hashvalue 48 combine hash combine hash bigint 0 coalesce operator hash code x 0 coalesce operator hash code y 0 filter x cast a as varchar x varchar y integer tablescan prism batch local goldprism batch local gold tmp martint40 originalconstraint x cast a as varchar x varchar y integer layout prism batch x hivecolumnhandle clientid prism batch name x hivetype string hivecolumnindex 0 columntype regular y hivecolumnhandle clientid prism batch name y hivetype int hivecolumnindex 1 columntype regular fragment 3 hash output layout expr 28 expr 29 expr 28 expr 29 hashvalue 53 hashvalue 53 output partition hash expr 28 expr 29 project expr 28 varchar expr 29 integer hashvalue 53 bigint hashvalue 53 combine hash combine hash bigint 0 coalesce operator hash code expr 28 0 coalesce operator hash code expr 29 0 project expr 28 varchar expr 29 integer expr 28 cast a as varchar expr 29 y 12 1 aggregate final x 11 y 12 x 11 varchar y 12 integer hashvalue 51 bigint remotesource 4 x 11 varchar y 12 integer hashvalue 51 bigint fragment 4 source output layout x 11 y 12 hashvalue 52 output partition hash x 11 y 12 aggregate partial x 11 y 12 x 11 varchar y 12 integer hashvalue 52 bigint project x 11 varchar y 12 integer hashvalue 52 bigint hashvalue 52 combine hash combine hash bigint 0 coalesce operator hash code x 11 0 coalesce operator hash code y 12 0 tablescan prism batch local goldprism batch local gold tmp martint40 originalconstraint true x 11 varchar y 12 integer layout prism batch x 11 hivecolumnhandle clientid prism batch name x hivetype string hivecolumnindex 0 columntype regular y 12 hivecolumnhandle clientid prism batch name y hivetype int hivecolumnindex 1 columntype regular incorrect plan fragment 0 single output layout count output partition single output col0 count bigint col0 count aggregate final count bigint count count count 46 remotesource 1 count 46 bigint fragment 1 hash output layout count 47 output partition single aggregate partial count 47 bigint count 47 count innerjoin y expr 39 and x expr 41 x varchar y integer hashvalue bigint expr 28 varchar expr 29 integer expr 39 integer expr 41 varchar hashvalue 49 bigint aggregate final x y x varchar y integer hashvalue bigint remotesource 2 x varchar y integer hashvalue bigint project expr 28 varchar expr 29 integer expr 39 integer expr 41 varchar hashvalue 49 bigint remotesource 3 expr 28 varchar expr 29 integer expr 39 integer expr 41 varchar hashvalue 49 bigint hashvalue 50 bigint fragment 2 source output layout x y hashvalue 48 output partition hash x y aggregate partial x y x varchar y integer hashvalue 48 bigint project x varchar y integer hashvalue 48 bigint hashvalue 48 combine hash combine hash bigint 0 coalesce operator hash code y 0 coalesce operator hash code x 0 filter x cast a as varchar x varchar y integer tablescan prism batch local goldprism batch local gold tmp martint40 originalconstraint x cast a as varchar x varchar y integer layout prism batch x hivecolumnhandle clientid prism batch name x hivetype string hivecolumnindex 0 columntype regular y hivecolumnhandle clientid prism batch name y hivetype int hivecolumnindex 1 columntype regular fragment 3 hash output layout expr 28 expr 29 expr 29 expr 28 hashvalue 53 hashvalue 54 output partition hash expr 28 expr 29 project expr 28 varchar expr 29 integer hashvalue 53 bigint hashvalue 54 bigint hashvalue 53 combine hash combine hash bigint 0 coalesce operator hash code expr 29 0 coalesce operator hash code expr 28 0 hashvalue 54 combine hash combine hash bigint 0 coalesce operator hash code expr 28 0 coalesce operator hash code expr 29 0 project expr 28 varchar expr 29 integer expr 28 cast a as varchar expr 29 y 12 1 aggregate final x 11 y 12 x 11 varchar y 12 integer hashvalue 51 bigint remotesource 4 x 11 varchar y 12 integer hashvalue 51 bigint fragment 4 source output layout x 11 y 12 hashvalue 52 output partition hash x 11 y 12 aggregate partial x 11 y 12 x 11 varchar y 12 integer hashvalue 52 bigint project x 11 varchar y 12 integer hashvalue 52 bigint hashvalue 52 combine hash combine hash bigint 0 coalesce operator hash code x 11 0 coalesce operator hash code y 12 0 tablescan prism batch local goldprism batch local gold tmp martint40 originalconstraint true x 11 varchar y 12 integer layout prism batch x 11 hivecolumnhandle clientid prism batch name x hivetype string hivecolumnindex 0 columntype regular y 12 hivecolumnhandle clientid prism batch name y hivetype int hivecolumnindex 1 columntype regular the join appear to be use the follow hash hashvalue 53 combine hash combine hash bigint 0 coalesce operator hash code expr 29 0 coalesce operator hash code expr 28 0 which have its input reverse compare to the one use for the aggregation and shuffle this issue happen in master after 0 154 and be likely to be due to this change 15d32ee93f8dd02cee815c3ecf2a1dd76a13e7e0
prestodbpresto
make property include and exclude unreserved keyword
Bug
this commit 055b1df2c4d8f6c220a280a0175b8542177d3753 add support for create table like but do not mark those keyword as unreserved as a result any query that reference column with those name without quote fail in the new version
prestodbpresto
incorrect memory accounting for hash aggregation operator
Bug
the follow query report peak memory that vary wildly from cluster to cluster and run to run I ve see number range from 0 gb to 20 gb it seem to be sensitive to how much concurrent work be be perform how fast work complete etc for instance in one cluster set task concurrency to 1 cause it to report 2 gb with a task concurrency of 2 or high it report 0 gb in another cluster it report 4 4 gb with task concurrency 1 and 3 gb 3 3 gb 3 8 gb with task concurrency 1 sql select custkey count c from tpch sf1000 order group by custkey
prestodbpresto
flaky testraptorintegrationsmoketestbuckete testcreatebucketedtable
Bug
this might be cause due to compaction run during the test testcreatebucketedtable com facebook presto raptor testraptorintegrationsmoketestbuckete time elapse 0 409 sec failure java lang assertionerror for query select count distinct shard uuid from order bucket not equal actual 1 row 75 expect 1 row 100 at org testng assert fail assert java 94 at com facebook presto test queryassertion assertequalsignoreorder queryassertion java 149 at com facebook presto test queryassertion assertquery queryassertion java 132 at com facebook presto test abstracttestqueryframework assertquery abstracttestqueryframework java 112 at com facebook presto raptor testraptorintegrationsmoketest testcreatebucketedtable testraptorintegrationsmoketest java 325 at sun reflect nativemethodaccessorimpl invoke0 native method at sun reflect nativemethodaccessorimpl invoke nativemethodaccessorimpl java 62 at sun reflect delegatingmethodaccessorimpl invoke delegatingmethodaccessorimpl java 43 at java lang reflect method invoke method java 498 at org testng internal methodinvocationhelper invokemethod methodinvocationhelper java 85 at org testng internal invoker invokemethod invoker java 696 at org testng internal invoker invoketestmethod invoker java 882 at org testng internal invoker invoketestmethod invoker java 1189 at org testng internal testmethodworker invoketestmethod testmethodworker java 124 at org testng internal testmethodworker run testmethodworker java 108 at java util concurrent threadpoolexecutor runworker threadpoolexecutor java 1142 at java util concurrent threadpoolexecutor worker run threadpoolexecutor java 617 at java lang thread run thread java 745
prestodbpresto
cli hang when initial output be short
Bug
this query be a good reproduction change the value base on cluster size sql select select sum totalprice from tpch sf200 order union all select sum totalprice from tpch sf1000 order sequence 1 cli show progress for a few second while both subquerie run 2 first subquery finish and produce an output row the second subquery keep run 3 cli clear the progress display execute the pager process and start write output to the pager 4 the buffer in outputhandler wait 3 second for more row before any output be write 5 the header and first row should be output however nothing be display and attempt interact with less include ctrl c do not work an easy way to see what be happen be to set presto pager cat before run the cli
prestodbpresto
incorrect result when use map in in expression
Bug
in the late master presto tiny select x from value 2 t x where map array 1 array x in value map array 1 array 2 x 0 row
prestodbpresto
run presto sql script from cli not able to see time take by the query
Enhancement
hi I be use below command to run sql query I be able to get the result of the query but I be not able to find the time take by query with this way in case hive by use 2 we can get detail of query execution presto cli 0 152 executable jar server serverip port catalog hive schema databasename f script presto q1 hql
prestodbpresto
eliminate unnecessary cross join
Enhancement
this pull request add simple join reorder algorithm with reorder join set to true default false this rewrite will find all consecutive join sequence and if there be a cross join it will try to reorder join to eliminate they for example select from a b c where a a c a and b b c b there be equality join condition betweem a c and b c but join order force to first join a and b which result in cross join this code will rewrite such query to select from a c b where a a c a and b b c b it will also try to preserve original join order as much as possible this solve issue with automatically generate query user query for which user either didn t think about join order or unintentionally introduce cross join some tpch tpcds query have cross join that can be remove this way dramatically improve performance
prestodbpresto
support lambda expression in aggregation function
Enhancement
once lambda expression be add we should add support for use they in aggregation function context this will make it possible to model virtually any aggregation behavior without have to write custom aggregation function
prestodbpresto
incorrect result when group set refer to column derive from same column
Bug
this query sql with t v as value 1 2 u v1 v2 as select v v1 v v2 from t select v1 v2 from u group by group set v1 v2 incorrectly produce v1 v2 1 1 2 2 1 1 2 2 4 row the expect result be v1 v2 1 null 2 null null 1 null 2 4 row
prestodbpresto
fix create tinyint or smallint for avro in hive
Bug
avro only support int in hive create a table with tinyint or smallint with avro storage format create a table with int automatically in presto we currently create a broken table read it fail with an avro schema mismatch we should either disallow it as not support tell the user to use integer instead or automatically translate the type
prestodbpresto
plan error when subquery be use in case if expression
Bug
select if false a in value b produce java lang illegalargumentexception unsupported subquery type at com facebook presto sql planner sanity noapplynodeleftchecker 1 visitapply noapplynodeleftchecker java 39 at com facebook presto sql planner plan applynode accept applynode java 96 at com facebook presto sql planner simpleplanvisitor visitplan simpleplanvisitor java 26 at com facebook presto sql planner simpleplanvisitor visitplan simpleplanvisitor java 19 at com facebook presto sql planner plan planvisitor visitproject planvisitor java 40 at com facebook presto sql planner plan projectnode accept projectnode java 81 at com facebook presto sql planner simpleplanvisitor visitplan simpleplanvisitor java 26 at com facebook presto sql planner simpleplanvisitor visitplan simpleplanvisitor java 19 at com facebook presto sql planner plan planvisitor visitoutput planvisitor java 50 at com facebook presto sql planner plan outputnode accept outputnode java 81 at com facebook presto sql planner sanity noapplynodeleftchecker validate noapplynodeleftchecker java 33 at com facebook presto sql planner sanity plansanitychecker lambda validate 0 plansanitychecker java 42 at java lang iterable foreach iterable java 75 at com facebook presto sql planner sanity plansanitychecker validate plansanitychecker java 42 at com facebook presto sql planner logicalplanner plan logicalplanner java 123 at com facebook presto sql planner logicalplanner plan logicalplanner java 107 at com facebook presto execution sqlqueryexecution doanalyzequery sqlqueryexecution java 291 at com facebook presto execution sqlqueryexecution analyzequery sqlqueryexecution java 270 at com facebook presto execution sqlqueryexecution start sqlqueryexecution java 228 at com facebook presto execution queuedexecution lambda start 1 queuedexecution java 62 at java util concurrent threadpoolexecutor runworker threadpoolexecutor java 1142 at java util concurrent threadpoolexecutor worker run threadpoolexecutor java 617 at java lang thread run thread java 745 this be a regression in 0 153
prestodbpresto
npe for spnegofilter
Bug
apparently gsscontext getsrcname can return null even if isestablishe be true I suppose we should handle that by return optional empty maybe with a debug log entry java lang nullpointerexception at com facebook presto server security spnegofilter authenticate spnegofilter java 194 at com facebook presto server security spnegofilter dofilter spnegofilter java 154 at org eclipse jetty servlet servlethandler cachedchain dofilter servlethandler java 1676 at io airlift http server tracetokenfilter dofilter tracetokenfilter java 63 at org eclipse jetty servlet servlethandler cachedchain dofilter servlethandler java 1676 at io airlift http server timingfilter dofilter timingfilter java 52 at org eclipse jetty servlet servlethandler cachedchain dofilter servlethandler java 1676 at org eclipse jetty servlet servlethandler dohandle servlethandler java 581 at org eclipse jetty server handler scopedhandler handle scopedhandler java 143 at org eclipse jetty server handler gzip gziphandler handle gziphandler java 386 at org eclipse jetty server handler contexthandler dohandle contexthandler java 1176 at org eclipse jetty servlet servlethandler doscope servlethandler java 511 at org eclipse jetty server handler contexthandler doscope contexthandler java 1106 at org eclipse jetty server handler scopedhandler handle scopedhandler java 141 at org eclipse jetty server handler handlercollection handle handlercollection java 119 at org eclipse jetty server handler statisticshandler handle statisticshandler java 169 at org eclipse jetty server handler handlerlist handle handlerlist java 52 at org eclipse jetty server handler handlerwrapper handle handlerwrapper java 134 at org eclipse jetty server server handle server java 518 at org eclipse jetty server httpchannel handle httpchannel java 314 at org eclipse jetty server httpconnection onfillable httpconnection java 253 at org eclipse jetty io abstractconnection readcallback succeed abstractconnection java 273 at org eclipse jetty io fillinterest fillable fillinterest java 95 at org eclipse jetty io ssl sslconnection onfillable sslconnection java 186 at org eclipse jetty io abstractconnection readcallback succeed abstractconnection java 273 at org eclipse jetty io fillinterest fillable fillinterest java 95 at org eclipse jetty io selectchannelendpoint 2 run selectchannelendpoint java 93 at org eclipse jetty util thread strategy executeproduceconsume produceandrun executeproduceconsume java 246 at org eclipse jetty util thread strategy executeproduceconsume run executeproduceconsume java 156 at org eclipse jetty util thread queuedthreadpool runjob queuedthreadpool java 654 at org eclipse jetty util thread queuedthreadpool 3 run queuedthreadpool java 572 at java lang thread run thread java 745
prestodbpresto
predicate pushdown derive incorrect join equality
Bug
the follow query sql with t as select name x case name when africa then america else null end as y from tpch tiny region select from t a join t b on a x b y incorrectly produce 0 row the expect output be x y x y america null africa america this be the plan distribute join and hash generation optimization disabled fragment 0 single output layout name expr name 10 expr 14 output partition single output x y x y name varchar 25 expr varchar 7 name 10 varchar 25 expr 14 varchar 7 x name y expr x name 10 y expr 14 remotesource 1 name varchar 25 expr varchar 7 name 10 varchar 25 expr 14 varchar 7 fragment 1 source output layout name expr name 10 expr 14 output partition single project name varchar 25 expr varchar 7 name 10 varchar 25 expr 14 varchar 7 innerjoin expr expr 46 and name expr 48 name varchar 25 expr varchar 7 name 10 varchar 25 expr 14 varchar 7 expr 46 varchar 7 expr 48 varchar 25 project name varchar 25 expr varchar 7 expr case name when cast africa as varchar 25 then america end filter case name when cast africa as varchar 25 then america end case name when cast africa as varchar 25 then america end name varchar 25 tablescan tpch tpch region sf0 01 originalconstraint true name varchar 25 name tpch name remotesource 2 name 10 varchar 25 expr 14 varchar 7 expr 46 varchar 7 expr 48 varchar 25 fragment 2 source output layout name 10 expr 52 expr 50 expr 51 output partition broadcast project name 10 varchar 25 expr 50 varchar 7 expr 51 varchar 25 expr 52 varchar 7 expr 50 case cast case name 10 when cast africa as varchar 25 then america end as varchar 25 when cast africa as varchar 25 then america end expr 51 cast case name 10 when cast africa as varchar 25 then america end as varchar 25 expr 52 case name 10 when cast africa as varchar 25 then america end filter case cast case name 10 when cast africa as varchar 25 then america end as varchar 25 when cast africa as varchar 25 then america end case cast case name 10 when cast africa as varchar 25 then america end as varchar 25 when cast africa as varchar 25 then america end name 10 varchar 25 tablescan tpch tpch region sf0 01 originalconstraint true name 10 varchar 25 name 10 tpch name the filter above the table scan look incorrect so this would appear to be a bug in predicate projection pushdown cast elide for readability case case name 10 when africa then america end when africa then america end case case name 10 when africa then america end when africa then america end
prestodbpresto
plan bug when create bucketed table
Bug
this query sql create table t with bucket by array k bucket count 64 as select a b 0 k fail with java lang illegalargumentexception input symbol do not match output symbol at com google common base precondition checkargument precondition java 122 at com facebook presto sql planner plan exchangenode exchangenode java 82 at com facebook presto sql planner plan exchangenode partitionedexchange exchangenode java 130 at com facebook presto sql planner optimization addexchange rewriter visittablewriter addexchange java 636 at com facebook presto sql planner optimization addexchange rewriter visittablewriter addexchange java 187 at com facebook presto sql planner plan tablewriternode accept tablewriternode java 128 at com facebook presto sql planner optimizations addexchange rewriter planchild addexchange java 1231 at com facebook presto sql planner optimization addexchange rewriter visittablefinish addexchange java 791 at com facebook presto sql planner optimization addexchange rewriter visittablefinish addexchange java 187 at com facebook presto sql planner plan tablefinishnode accept tablefinishnode java 80 at com facebook presto sql planner optimizations addexchange rewriter planchild addexchange java 1231 at com facebook presto sql planner optimizations addexchange rewriter visitoutput addexchange java 236 at com facebook presto sql planner optimizations addexchange rewriter visitoutput addexchange java 187 at com facebook presto sql planner plan outputnode accept outputnode java 81 at com facebook presto sql planner optimization addexchange optimize addexchange java 149 at com facebook presto sql planner logicalplanner plan logicalplanner java 105 at com facebook presto execution sqlqueryexecution doanalyzequery sqlqueryexecution java 281 at com facebook presto execution sqlqueryexecution analyzequery sqlqueryexecution java 260 at com facebook presto execution sqlqueryexecution start sqlqueryexecution java 224 at com facebook presto execution queuedexecution lambda start 1 queuedexecution java 62 at java util concurrent threadpoolexecutor runworker threadpoolexecutor java 1142 at java util concurrent threadpoolexecutor worker run threadpoolexecutor java 617 at java lang thread run thread java 745
prestodbpresto
fix thread safety of indexlookup in accumuloclient
Bug
accumuloclient be a singleton and contain an instance of indexlookup it then call setauth from gettabletsplit which be call from different thread additionally indexlookup use columncardinalitycache which have a normal hashmap without any synchronization this code path be also call from multiple thread this should probably be do after 6318 since several of the class involve store an accumuloconfig
prestodbpresto
remove usage of store accumuloconfig
Bug
various class like accumulopagesinkprovider store an accumuloconfig class rather than extract the value in the constructor and save they to final field config class be mutable so other class should not keep a reference to they
prestodbpresto
make accumulocolumnhandle immutable
Bug
mutable class for a data object be a general anti pattern effective java give a full explanation and be contrary to the general code style of presto additionally the mutable field be use in equal hashcode which violate the contract
prestodbpresto
optimize map agg memory usage
Enhancement
the per group memory usage of map agg in a group by query be quite large for instance for the follow query select k map agg v1 v2 from value 1 2 3 t k v1 v2 group by k the keyvaluepairs state object for each group be 12 kb big
prestodbpresto
fix broken implementation of dictionaryblock compactblock
Bug
this pr fix broken implementation of dictionaryblock compactblock currently the method work only iff all block be exactly the same in all other case all block receive a copy of the ids from the first block I hope I understand the purpose of the method correctly and have create a correct implementation with test
prestodbpresto
optimize window function follow by order by
Enhancement
the follow query be slow than necessary because the sortnode be redundant with the precede windownode sql select row number over order by key from src order by key it should have the same execution plan as this because the windownode already sort the output sql select row number over order by key from src
prestodbpresto
ui show nan when load
Bug
I reproduce by connect to one of our cluster with https where the html page can load but all the resource throw 401
prestodbpresto
o n 2 behavior when group by double column contain nan
Bug
nan be not equal to any other value even to nan this cause insertion into the hash table of a group by or join to become o n for nan value once be implement this should no long be a problem in the meantime we should consider fail query that group by or join on nan
prestodbpresto
cli progress bar overflow on query run for 100 minute
Bug
here s an example from a query that s be run for 2 hour the cli terminal width be 80 character but this line be render at 81 character due to the extra minute digit 125 36 24 9 m rows 3 54 gb 3 3k row s 493 kb s 99
prestodbpresto
support table function
Enhancement
I want to add a support for user define table function but first I would love to hear if such a feature would be useful and it be need my raw plan be to add a concept of table function implement unnest as table function change unnestnode to be something like tablefunctionnode but with a unn function method expose table function udf interface udtf I could image udtf interface as something like below public interface tablefunction enum distibution gather all the input output row will be handle by single node broadcast all the input output row will be handle by all the nodes scatter all the input output row will be scatter among the node return the list of output type if function be capable to handle give input type optional iscapable list inputtype default distibution getdistribution return distibution scatter one of below method have to be implement default recordset createrecordset recordsink recordsink throw new unsupportedoperationexception default connectorpagesource createpagesource connectorpagesink pagesink throw new unsupportedoperationexception there could be plenty of potential usage of this the most obvious be to leverage the machine learning and statistical tool with presto like r select from rtable lineitem some r code my plan be to work on this in my slack time depend on feedback I get I think I could try prioritize it high to work on it in regular basis martint
prestodbpresto
plan class cast exception
Bug
this query now throw an error select max x a over x a 100 0 max x a over from select 1 as a x query 20161005 231326 03851 gb7jd fail com facebook presto sql tree symbolreference can not be cast to com facebook presto sql tree functioncall java lang classcastexception com facebook presto sql tree symbolreference can not be cast to com facebook presto sql tree functioncall at com facebook presto sql planner queryplanner window queryplanner java 617 at com facebook presto sql planner queryplanner plan queryplanner java 140 at com facebook presto sql planner relationplanner visitqueryspecification relationplanner java 443 at com facebook presto sql planner relationplanner visitqueryspecification relationplanner java 94 at com facebook presto sql tree queryspecification accept queryspecification java 125 at com facebook presto sql tree astvisitor process astvisitor java 22 at com facebook presto sql planner queryplanner planquerybody queryplanner java 220 at com facebook presto sql planner queryplanner plan queryplanner java 113 at com facebook presto sql planner relationplanner visitquery relationplanner java 436 at com facebook presto sql planner relationplanner visitquery relationplanner java 94 at com facebook presto sql tree query accept query java 103 at com facebook presto sql tree astvisitor process astvisitor java 22 at com facebook presto sql planner logicalplanner createrelationplan logicalplanner java 358 at com facebook presto sql planner logicalplanner planstatement logicalplanner java 150 at com facebook presto sql planner logicalplanner plan logicalplanner java 112 at com facebook presto sql planner logicalplanner plan logicalplanner java 107 at com facebook presto execution sqlqueryexecution doanalyzequery sqlqueryexecution java 291 at com facebook presto execution sqlqueryexecution analyzequery sqlqueryexecution java 270 at com facebook presto execution sqlqueryexecution start sqlqueryexecution java 228 at java util concurrent threadpoolexecutor runworker threadpoolexecutor java 1142 at java util concurrent threadpoolexecutor worker run threadpoolexecutor java 617 at java lang thread run thread java 745
prestodbpresto
spill join
Enhancement
it cover issue before review I highly recommend read description of implement solution section of this doc head h jxm688ny3n2
prestodbpresto
exception when press ctrl c during query execution
Bug
press ctrl c in the cli while a query be process cause java lang runtimeexception error fetch next at com facebook presto client statementclient advance statementclient java 300 at com facebook presto cli statusprinter printinitialstatusupdate statusprinter java 121 at com facebook presto cli query renderqueryoutput query java 123 at com facebook presto cli query renderoutput query java 107 at com facebook presto cli console process console java 294 at com facebook presto cli console runconsole console java 234 at com facebook presto cli console run console java 139 at com facebook presto cli presto main presto java 32 cause by java lang runtimeexception java lang interruptedexception at com google common base throwable propagate throwable java 160 at io airlift http client responsehandlerutil propagate responsehandlerutil java 22 version 0 152
prestodbpresto
add spill data size limit
Enhancement
currently be only limit by the capacity of underlying storage after hit such limit query will start to fail there should be both per worker limit and per query limit for spill datum
prestodbpresto
add spill data size to operatorstat
Enhancement
currently there be only one statistic per whole worker getspilleddatasize expose via jmx more stat per operator driver task query could be add
prestodbpresto
make read from spiller asynchronous
Enhancement
currently spiller have a follow interface public interface spiller extend closeable initiate spilling of page stream return complete future once spilling have finish completablefuture spill iterator pageiterator return list of previously spill page stream list getspill this make read from spiller synchronous which can block operator this should be fix the big obstacle be in how to use asynchronous reading method in mergesorter
prestodbpresto
try cast be inconsistent with cast
Bug
presto select cast x as bigint try cast x as bigint from value 1 2 3 null t x col0 col1 1 1 2 2 3 3 null 0 4 row presto select cast null as bigint try cast null as bigint col0 col1 null null 1 row
prestodbpresto
kill query that cause bottleneck due to skew
Enhancement
we need a mechanism to detect memory skew for operation like join and group by and a policy to kill skewed query that cause other query to stall when try to allocate memory
prestodbpresto
detect and report join group by skew
Enhancement
if a query fail due to local memory limit be exceed generally due to skew presto should provide well diagnostic about what key or group cause the imbalance
prestodbpresto
npe when cast map contain null
Bug
sql select cast map array 0 1 array 1 null as map com facebook presto spi prestoexception generic internal error at com facebook presto operator scalar maptomapcast tomap maptomapcast java 110 at com facebook presto gen pageprocessor 27357 project 0 unknown source at com facebook presto gen pageprocessor 27357 process unknown source at com facebook presto operator filterandprojectoperator getoutput filterandprojectoperator java 111 at com facebook presto operator driver processinternal driver java 378 at com facebook presto operator driver processfor driver java 301 at com facebook presto execution sqltaskexecution driversplitrunner processfor sqltaskexecution java 622 at com facebook presto execution taskexecutor prioritizedsplitrunner process taskexecutor java 529 at com facebook presto execution taskexecutor runner run taskexecutor java 665 at java util concurrent threadpoolexecutor runworker threadpoolexecutor java 1142 at java util concurrent threadpoolexecutor worker run threadpoolexecutor java 617 at java lang thread run thread java 745 cause by java lang nullpointerexception at sun invoke util valueconversion unboxlong valueconversion java 121 at com facebook presto operator scalar maptomapcast tomap maptomapcast java 104 11 more
prestodbpresto
fix comparison for char to take into account padding
Bug
previous implementation of char comparison didn t work properly with control char e g 0 internal td review can be relevant
prestodbpresto
effectivepredicate not print nicely as part of hivesplit getinfo
Bug
the effectivepredicate part of hiveslit getinfo be meaningless as tupledomain do not provide tostre method only tostre connectorsession method we should either create standard tostring in tupledomain pass session arg to getinfo drop effectivepredicate from getinfo alltogether
prestodbpresto
plan error for correlate query over hive connector
Bug
run the follow query as part of testhivedistributedquerie fail with a planning error it seem to happen during partition prune sql select count from order o where exist select avg l orderkey from lineitem l where o orderkey l orderkey group by l linenumber java lang illegalargumentexception miss column assignment for orderkey at com google common base precondition checkargument precondition java 145 at com facebook presto sql planner lookupsymbolresolver getvalue lookupsymbolresolver java 44 at com facebook presto sql planner expressioninterpreter visitor visitsymbolreference expressioninterpreter java 430 at com facebook presto sql tree symbolreference accept symbolreference java 38 at com facebook presto sql tree astvisitor process astvisitor java 22 at com facebook presto sql planner expressioninterpreter visitor visitcomparisonexpression expressioninterpreter java 744 at com facebook presto sql tree comparisonexpression accept comparisonexpression java 133 at com facebook presto sql tree astvisitor process astvisitor java 22 at com facebook presto sql planner expressioninterpreter optimize expressioninterpreter java 254 at com facebook presto sql planner optimizations addexchange rewriter shouldprune addexchange java 659 at com facebook presto sql planner optimizations addexchanges rewriter lambda plantablescan 4 addexchange java 572 at com facebook presto hive hivemetadata lambda gettablelayout 5 hivemetadata java 1034 at java util stream referencepipeline 2 1 accept referencepipeline java 174 at java util iterator foreachremaine iterator java 116 at java util spliterators iteratorspliterator foreachremaine spliterator java 1801 at java util stream abstractpipeline copyinto abstractpipeline java 481 at java util stream abstractpipeline wrapandcopyinto abstractpipeline java 471 at java util stream reduceop reduceop evaluatesequential reduceop java 708 at java util stream abstractpipeline evaluate abstractpipeline java 234 at java util stream referencepipeline collect referencepipeline java 499 at com facebook presto hive hivemetadata gettablelayouts hivemetadata java 1035 at com facebook presto spi connector classloader classloadersafeconnectormetadata gettablelayout classloadersafeconnectormetadata java 67 at com facebook presto metadata metadatamanager getlayout metadatamanager java 337 at com facebook presto sql planner optimization addexchange rewriter plantablescan addexchange java 570 at com facebook presto sql planner optimizations addexchange rewriter visitfilter addexchange java 513 at com facebook presto sql planner optimizations addexchange rewriter visitfilter addexchange java 182 at com facebook presto sql planner plan filternode accept filternode java 71 at com facebook presto sql planner optimizations addexchange rewriter planchild addexchange java 1152 at com facebook presto sql planner optimization addexchange rewriter visitproject addexchange java 223 at com facebook presto sql planner optimization addexchange rewriter visitproject addexchange java 182 at com facebook presto sql planner plan projectnode accept projectnode java 81 at com facebook presto sql planner optimizations addexchange rewriter planchild addexchange java 1152 at com facebook presto sql planner optimization addexchange rewriter visitaggregation addexchange java 268 at com facebook presto sql planner optimization addexchange rewriter visitaggregation addexchange java 182 at com facebook presto sql planner plan aggregationnode accept aggregationnode java 204 at com facebook presto sql planner optimizations addexchange rewriter planchild addexchange java 1152 at com facebook presto sql planner optimization addexchange rewriter visitlimit addexchange java 477 at com facebook presto sql planner optimization addexchange rewriter visitlimit addexchange java 182 at com facebook presto sql planner plan limitnode accept limitnode java 86 at com facebook presto sql planner optimizations addexchange rewriter planchild addexchange java 1152 at com facebook presto sql planner optimization addexchange rewriter visitproject addexchange java 223 at com facebook presto sql planner optimization addexchange rewriter visitproject addexchange java 182 at com facebook presto sql planner plan projectnode accept projectnode java 81 at com facebook presto sql planner optimizations addexchange rewriter planchild addexchange java 1152 at com facebook presto sql planner optimization addexchange rewriter visitaggregation addexchange java 268 at com facebook presto sql planner optimization addexchange rewriter visitaggregation addexchange java 182 at com facebook presto sql planner plan aggregationnode accept aggregationnode java 204 at com facebook presto sql planner optimizations addexchange rewriter planchild addexchange java 1152 at com facebook presto sql planner optimization addexchange rewriter visitproject addexchange java 223 at com facebook presto sql planner optimization addexchange rewriter visitproject addexchange java 182 at com facebook presto sql planner plan projectnode accept projectnode java 81 at com facebook presto sql planner optimizations addexchange rewriter planchild addexchange java 1152 at com facebook presto sql planner optimizations addexchange rewriter visitenforcesinglerow addexchange java 243 at com facebook presto sql planner optimizations addexchange rewriter visitenforcesinglerow addexchange java 182 at com facebook presto sql planner plan enforcesinglerownode accept enforcesinglerownode java 64 at com facebook presto sql planner optimization addexchange rewriter visitapply addexchange java 1140 at com facebook presto sql planner optimization addexchange rewriter visitapply addexchange java 182 at com facebook presto sql planner plan applynode accept applynode java 96 at com facebook presto sql planner optimizations addexchange rewriter planchild addexchange java 1152 at com facebook presto sql planner optimizations addexchange rewriter visitfilter addexchange java 516 at com facebook presto sql planner optimizations addexchange rewriter visitfilter addexchange java 182 at com facebook presto sql planner plan filternode accept filternode java 71 at com facebook presto sql planner optimizations addexchange rewriter planchild addexchange java 1152 at com facebook presto sql planner optimization addexchange rewriter visitaggregation addexchange java 268 at com facebook presto sql planner optimization addexchange rewriter visitaggregation addexchange java 182 at com facebook presto sql planner plan aggregationnode accept aggregationnode java 204 at com facebook presto sql planner optimizations addexchange rewriter planchild addexchange java 1152 at com facebook presto sql planner optimizations addexchange rewriter visitoutput addexchange java 229 at com facebook presto sql planner optimizations addexchange rewriter visitoutput addexchange java 182 at com facebook presto sql planner plan outputnode accept outputnode java 81 at com facebook presto sql planner optimization addexchange optimize addexchange java 144 at com facebook presto sql planner logicalplanner plan logicalplanner java 116 at com facebook presto sql planner logicalplanner plan logicalplanner java 107 at com facebook presto execution sqlqueryexecution doanalyzequery sqlqueryexecution java 291 at com facebook presto execution sqlqueryexecution analyzequery sqlqueryexecution java 270 at com facebook presto execution sqlqueryexecution start sqlqueryexecution java 228 at com facebook presto execution queuedexecution lambda start 1 queuedexecution java 62 at java util concurrent threadpoolexecutor runworker threadpoolexecutor java 1142 at java util concurrent threadpoolexecutor worker run threadpoolexecutor java 617 at java lang thread run thread java 745
prestodbpresto
deadlock in task info fetch
Bug
hit this one in production suddenly all query get queue and all client start time out here be the full stack trace find one java level deadlock http worker 2010473 wait to lock monitor 0x00007f8fed4a6fb8 object 0x00007f9615a7e020 a com facebook presto execution resourcegroup resourcegroup rootresourcegroup which be hold by resourcegroupmanager resourcegroupmanager wait to lock monitor 0x00007f91f0cc3598 object 0x00007f9a9f000a48 a com facebook presto execution sqlstageexecution which be hold by httpremotetask 20160926 222904 08073 w6q27 1 105 2010288 httpremotetask 20160926 222904 08073 w6q27 1 105 2010288 wait to lock monitor 0x00007f90ed8c3ee8 object 0x00007f9a9f000870 a com facebook presto server remotetask continuoustaskstatusfetcher which be hold by continuoustaskstatusfetcher 20160926 222904 08073 w6q27 1 105 2009564 continuoustaskstatusfetcher 20160926 222904 08073 w6q27 1 105 2009564 wait to lock monitor 0x00007f910c0b5948 object 0x00007f9a9f0008e0 a com facebook presto server remotetask httpremotetask which be hold by httpremotetask 20160926 222904 08073 w6q27 1 105 2010288 java stack information for the thread list above http worker 2010473 at com facebook presto execution resourcegroup resourcegroup run resourcegroup java 322 wait to lock 0x00007f9615a7e020 a com facebook presto execution resourcegroup resourcegroup rootresourcegroup at com facebook presto execution resourcegroup resourcegroupmanager submit resourcegroupmanager java 89 at com facebook presto execution sqlquerymanager createquery sqlquerymanager java 348 at com facebook presto server statementresource query statementresource java 308 at com facebook presto server statementresource createquery statementresource java 171 at sun reflect generatedmethodaccessor1181 invoke unknown source at sun reflect delegatingmethodaccessorimpl invoke delegatingmethodaccessorimpl java 43 at java lang reflect method invoke method java 498 at org glassfish jersey server model internal resourcemethodinvocationhandlerfactory 1 invoke resourcemethodinvocationhandlerfactory java 81 at org glassfish jersey server model internal abstractjavaresourcemethoddispatcher 1 run abstractjavaresourcemethoddispatcher java 144 at org glassfish jersey server model internal abstractjavaresourcemethoddispatcher invoke abstractjavaresourcemethoddispatcher java 161 at org glassfish jersey server model internal javaresourcemethoddispatcherprovider responseoutinvoker dodispatch javaresourcemethoddispatcherprovider java 160 at org glassfish jersey server model internal abstractjavaresourcemethoddispatcher dispatch abstractjavaresourcemethoddispatcher java 99 at org glassfish jersey server model resourcemethodinvoker invoke resourcemethodinvoker java 389 at org glassfish jersey server model resourcemethodinvoker apply resourcemethodinvoker java 347 at org glassfish jersey server model resourcemethodinvoker apply resourcemethodinvoker java 102 at org glassfish jersey server serverruntime 2 run serverruntime java 326 at org glassfish jersey internal error 1 call error java 271 at org glassfish jersey internal error 1 call error java 267 at org glassfish jersey internal error process error java 315 at org glassfish jersey internal error process error java 297 at org glassfish jersey internal error process error java 267 at org glassfish jersey process internal requestscope runinscope requestscope java 317 at org glassfish jersey server serverruntime process serverruntime java 305 at org glassfish jersey server applicationhandler handle applicationhandler java 1154 at org glassfish jersey servlet webcomponent serviceimpl webcomponent java 473 at org glassfish jersey servlet webcomponent service webcomponent java 427 at org glassfish jersey servlet servletcontainer service servletcontainer java 388 at org glassfish jersey servlet servletcontainer service servletcontainer java 341 at org glassfish jersey servlet servletcontainer service servletcontainer java 228 at org eclipse jetty servlet servletholder handle servletholder java 845 at org eclipse jetty servlet servlethandler cachedchain dofilter servlethandler java 1689 at io airlift http server tracetokenfilter dofilter tracetokenfilter java 63 at org eclipse jetty servlet servlethandler cachedchain dofilter servlethandler java 1676 at io airlift http server timingfilter dofilter timingfilter java 52 at org eclipse jetty servlet servlethandler cachedchain dofilter servlethandler java 1676 at org eclipse jetty servlet servlethandler dohandle servlethandler java 581 at org eclipse jetty server handler scopedhandler handle scopedhandler java 143 at org eclipse jetty server handler gzip gziphandler handle gziphandler java 396 at org eclipse jetty server handler contexthandler dohandle contexthandler java 1176 at org eclipse jetty servlet servlethandler doscope servlethandler java 511 at org eclipse jetty server handler contexthandler doscope contexthandler java 1106 at org eclipse jetty server handler scopedhandler handle scopedhandler java 141 at org eclipse jetty server handler handlercollection handle handlercollection java 119 at org eclipse jetty server handler statisticshandler handle statisticshandler java 169 at org eclipse jetty server handler handlerlist handle handlerlist java 52 at org eclipse jetty server handler handlerwrapper handle handlerwrapper java 134 at org eclipse jetty server server handle server java 518 at org eclipse jetty server httpchannel handle httpchannel java 314 at org eclipse jetty server httpconnection onfillable httpconnection java 253 at org eclipse jetty io abstractconnection readcallback succeed abstractconnection java 273 at org eclipse jetty io fillinterest fillable fillinterest java 95 at org eclipse jetty io selectchannelendpoint 2 run selectchannelendpoint java 93 at org eclipse jetty util thread queuedthreadpool runjob queuedthreadpool java 654 at org eclipse jetty util thread queuedthreadpool 3 run queuedthreadpool java 572 at java lang thread run thread java 745 resourcegroupmanager at com facebook presto execution sqlstageexecution getmemoryreservation sqlstageexecution java 184 wait to lock 0x00007f9a9f000a48 a com facebook presto execution sqlstageexecution at com facebook presto execution scheduler sqlqueryscheduler lambda 792 605126606 applyaslong unknown source at java util stream referencepipeline 5 1 accept referencepipeline java 227 at java util iterator foreachremaine iterator java 116 at java util spliterators iteratorspliterator foreachremaine spliterator java 1801 at java util stream abstractpipeline copyinto abstractpipeline java 481 at java util stream abstractpipeline wrapandcopyinto abstractpipeline java 471 at java util stream reduceop reduceop evaluatesequential reduceop java 708 at java util stream abstractpipeline evaluate abstractpipeline java 234 at java util stream longpipeline reduce longpipeline java 438 at java util stream longpipeline sum longpipeline java 396 at com facebook presto execution scheduler sqlqueryscheduler gettotalmemoryreservation sqlqueryscheduler java 310 at com facebook presto execution sqlqueryexecution gettotalmemoryreservation sqlqueryexecution java 188 at com facebook presto execution resourcegroup resourcegroup internalrefreshstats resourcegroup java 438 lock 0x00007f9615a7e020 a com facebook presto execution resourcegroup resourcegroup rootresourcegroup at com facebook presto execution resourcegroup resourcegroup internalrefreshstats resourcegroup java 445 lock 0x00007f9615a7e020 a com facebook presto execution resourcegroup resourcegroup rootresourcegroup at com facebook presto execution resourcegroup resourcegroup rootresourcegroup processqueuedquerie resourcegroup java 580 lock 0x00007f9615a7e020 a com facebook presto execution resourcegroup resourcegroup rootresourcegroup at com facebook presto execution resourcegroup resourcegroupmanager refreshandstartquerie resourcegroupmanager java 110 at com facebook presto execution resourcegroup resourcegroupmanager lambda 140 724736957 run unknown source at java util concurrent executors runnableadapter call executor java 511 at java util concurrent futuretask runandreset futuretask java 308 at java util concurrent scheduledthreadpoolexecutor scheduledfuturetask access 301 scheduledthreadpoolexecutor java 180 at java util concurrent scheduledthreadpoolexecutor scheduledfuturetask run scheduledthreadpoolexecutor java 294 at java util concurrent threadpoolexecutor runworker threadpoolexecutor java 1142 at java util concurrent threadpoolexecutor worker run threadpoolexecutor java 617 at java lang thread run thread java 745 httpremotetask 20160926 222904 08073 w6q27 1 105 2010288 at com facebook presto server remotetask continuoustaskstatusfetcher updatetaskstatus continuoustaskstatusfetcher java 214 wait to lock 0x00007f9a9f000870 a com facebook presto server remotetask continuoustaskstatusfetcher at com facebook presto server remotetask httpremotetask abort httpremotetask java 560 lock 0x00007f9a9f0008e0 a com facebook presto server remotetask httpremotetask at com facebook presto server remotetask httpremotetask abort httpremotetask java 552 lock 0x00007f9a9f0008e0 a com facebook presto server remotetask httpremotetask at com facebook presto execution sqlstageexecution lambda 1037 616866428 accept unknown source at java lang iterable foreach iterable java 75 at com facebook presto execution sqlstageexecution abort sqlstageexecution java 179 lock 0x00007f9a9f000a48 a com facebook presto execution sqlstageexecution at com facebook presto execution scheduler sqlqueryscheduler lambda 1035 234080167 accept unknown source at java util iterator foreachremaine iterator java 116 at java util spliterators iteratorspliterator foreachremaine spliterator java 1801 at java util stream referencepipeline head foreach referencepipeline java 580 at com facebook presto execution scheduler sqlqueryscheduler abort sqlqueryscheduler java 412 at com facebook presto execution sqlqueryexecution lambda new 0 sqlqueryexecution java 154 at com facebook presto execution sqlqueryexecution lambda 440 1153217709 statechange unknown source at com facebook presto execution statemachine lambda firestatechange 0 statemachine java 225 at com facebook presto execution statemachine lambda 413 743619379 run unknown source at java util concurrent threadpoolexecutor runworker threadpoolexecutor java 1142 at java util concurrent threadpoolexecutor worker run threadpoolexecutor java 617 at java lang thread run thread java 745 continuoustaskstatusfetcher 20160926 222904 08073 w6q27 1 105 2009564 at com facebook presto server remotetask httpremotetask abort httpremotetask java 557 wait to lock 0x00007f9a9f0008e0 a com facebook presto server remotetask httpremotetask at com facebook presto server remotetask httpremotetask failtask httpremotetask java 621 at com facebook presto server remotetask httpremotetask lambda 817 1647878013 accept unknown source at com facebook presto server remotetask continuoustaskstatusfetcher updatetaskstatus continuoustaskstatusfetcher java 234 lock 0x00007f9a9f000870 a com facebook presto server remotetask continuoustaskstatusfetcher at com facebook presto server remotetask continuoustaskstatusfetcher success continuoustaskstatusfetcher java 168 at com facebook presto server remotetask continuoustaskstatusfetcher success continuoustaskstatusfetcher java 52 at com facebook presto server remotetask simplehttpresponsehandler onsuccess simplehttpresponsehandler java 49 at com facebook presto server remotetask simplehttpresponsehandler onsuccess simplehttpresponsehandler java 27 at com google common util concurrent future 6 run future java 1319 at io airlift concurrent boundedexecutor drainqueue boundedexecutor java 77 at io airlift concurrent boundedexecutor lambda 437 311179219 run unknown source at java util concurrent threadpoolexecutor runworker threadpoolexecutor java 1142 at java util concurrent threadpoolexecutor worker run threadpoolexecutor java 617 at java lang thread run thread java 745 find 1 deadlock
prestodbpresto
distinct sum aggregation may produce incorrect result for empty grouping set
Bug
abstracttestquerie testgroupingsetswithmultipledistinctandunion fail for some configuration with task concurrency high then 1 select linenumber count distinct linenumber sum distinct suppkey from select from lineitem where linenumber 2 0 union all select from lineitem where linenumber 2 1 group by group set linenumber not equal actual 8 row 3 1 5050 null 7 30300 7 1 5050 1 1 5050 4 1 5050 6 1 5050 5 1 5050 2 1 5050 expect 8 row 1 1 5050 2 1 5050 3 1 5050 4 1 5050 5 1 5050 6 1 5050 7 1 5050 null 7 5050 simplify query set session task concurrency 8 select a sum distinct b from select from value 0 1 0 2 t a b union all select from value 1 1 1 2 t a b group by group set a a col1 0 3 null 6 1 3 to reproduce this number of worker must be great then 1 task concurrency must be great then 1 query must contain an empty grouping set and there must be union and aggregation function must be sum distinct it seem like multiple partial aggregation of empty grouping set be incorrectly combine in final aggregation effectively multiply result cc kokose
prestodbpresto
try cast fail with unbound variable exception
Bug
presto tiny select try cast foo as array query 20160923 154931 00004 72qud fail variable be not bind y java lang illegalstateexception variable be not bind y at com google common base precondition checkstate precondition java 197 at com facebook presto metadata signaturebinder bindvariable signaturebinder java 440 at com facebook presto metadata signaturebinder lambda bindvariable 1 signaturebinder java 415 at java util stream referencepipeline 3 1 accept referencepipeline java 193 at java util arraylist arraylistspliterator foreachremaine arraylist java 1374 at java util stream abstractpipeline copyinto abstractpipeline java 481 at java util stream abstractpipeline wrapandcopyinto abstractpipeline java 471 at java util stream reduceop reduceop evaluatesequential reduceop java 708 at java util stream abstractpipeline evaluate abstractpipeline java 234 at java util stream referencepipeline collect referencepipeline java 499 at com facebook presto metadata signaturebinder bindvariable signaturebinder java 416 at com facebook presto metadata signaturebinder bindvariable signaturebinder java 368 at com facebook presto metadata signaturebinder bind signaturebinder java 61 at com facebook presto metadata functionregistry getscalarfunctionimplementation functionregistry java 835 at com facebook presto metadata functionregistry getcoercion functionregistry java 964 at com facebook presto metadata functionregistry getcoercion functionregistry java 957 at com facebook presto sql analyzer expressionanalyzer visitor visitcast expressionanalyzer java 861 at com facebook presto sql analyzer expressionanalyzer visitor visitcast expressionanalyzer java 226 at com facebook presto sql tree cast accept cast java 94
prestodbpresto
npe with join on multiple condition
Bug
presto nyigitbasi select from value 2 2 a x y join value 2 2 b x y on a x b x a y b y query 20160923 041517 00003 k64q3 fail null java lang nullpointerexception at com facebook presto sql planner optimization windowfilterpushdown rewriter visitfilter windowfilterpushdown java 152 at com facebook presto sql planner optimization windowfilterpushdown rewriter visitfilter windowfilterpushdown java 84 at com facebook presto sql planner plan filternode accept filternode java 71 at com facebook presto sql planner plan simpleplanrewriter rewritecontext rewrite simpleplanrewriter java 85 at com facebook presto sql planner plan simpleplanrewriter rewritecontext lambda defaultrewrite 0 simpleplanrewriter java 74 at java util stream referencepipeline 3 1 accept referencepipeline java 193 at java util iterator foreachremaine iterator java 116 at java util spliterators iteratorspliterator foreachremaine spliterator java 1801 at java util stream abstractpipeline copyinto abstractpipeline java 481 at java util stream abstractpipeline wrapandcopyinto abstractpipeline java 471 at java util stream reduceop reduceop evaluatesequential reduceop java 708 at java util stream abstractpipeline evaluate abstractpipeline java 234 at java util stream referencepipeline collect referencepipeline java 499 at com facebook presto sql planner plan simpleplanrewriter rewritecontext defaultrewrite simpleplanrewriter java 75 at com facebook presto sql planner plan simpleplanrewriter visitplan simpleplanrewriter java 39 at com facebook presto sql planner plan simpleplanrewriter visitplan simpleplanrewriter java 23 at com facebook presto sql planner plan planvisitor visitoutput planvisitor java 50 at com facebook presto sql planner plan outputnode accept outputnode java 81 at com facebook presto sql planner plan simpleplanrewriter rewritewith simpleplanrewriter java 33 at com facebook presto sql planner optimization windowfilterpushdown optimize windowfilterpushdown java 81 at com facebook presto sql planner logicalplanner plan logicalplanner java 116 at com facebook presto sql planner logicalplanner plan logicalplanner java 107 at com facebook presto execution sqlqueryexecution doanalyzequery sqlqueryexecution java 291 at com facebook presto execution sqlqueryexecution analyzequery sqlqueryexecution java 270 at com facebook presto execution sqlqueryexecution start sqlqueryexecution java 228 at java util concurrent threadpoolexecutor runworker threadpoolexecutor java 1142 at java util concurrent threadpoolexecutor worker run threadpoolexecutor java 617 at java lang thread run thread java 745 not exactly sure about the difference but this work presto nyigitbasi select from value 2 2 a x y inner join value 2 2 b x y on a x b x and a y b y x y x y 2 2 2 2 1 row
prestodbpresto
hotfix add miss presto main dependency
Bug
currently there be a problem while start presto server with basic setup from readme due to class apachevalidationprovider not be find this be only hotfix to make master run to be investigate be apachevalidationprovider really require outside of test now why product test didn t catch that problem
prestodbpresto
task ids should sort numerically on query detail page
Bug
the be currently sort like this 1 0 1 1 1 10 1 11 they should sort like 1 0 1 1 1 2 1 10
prestodbpresto
indexoutofboundsexception in jsonarrayget
Bug
presto 0 152 1 query 20160909 195630 19737 xs72x fail index 0 size 0 java lang indexoutofboundsexception index 0 size 0 at java util linkedlist checkelementindex linkedlist java 555 at java util linkedlist get linkedlist java 476 at com facebook presto operator scalar jsonfunction jsonarrayget jsonfunction java 332 at com facebook presto operator scalar jsonfunction varcharjsonarrayget jsonfunction java 306 at com facebook presto gen cursorprocessor 18730 filter unknown source at com facebook presto gen cursorprocessor 18730 process unknown source at com facebook presto operator scanfilterandprojectoperator getoutput scanfilterandprojectoperator java 215 at com facebook presto operator driver processinternal driver java 378 at com facebook presto operator driver processfor driver java 301 at com facebook presto execution sqltaskexecution driversplitrunner processfor sqltaskexecution java 622 at com facebook presto execution taskexecutor prioritizedsplitrunner process taskexecutor java 529 at com facebook presto execution taskexecutor runner run taskexecutor java 665 at java util concurrent threadpoolexecutor runworker threadpoolexecutor java 1142 at java util concurrent threadpoolexecutor worker run threadpoolexecutor java 617 at java lang thread run thread java 745
prestodbpresto
fix memory accounting in parallelhashbuildoperator
Bug
use same logic as for hashbuilderoperator this bug feature be introduce in during rewrite parallelhashbuilder into parallelhashbuildoperator or dain maybe I m miss something
prestodbpresto
incorrect result for group set with multiple group
Bug
this query sql select count from value 1 2 3 t x where false group by group set incorrectly produce no row it should produce two row with 0 in each cell
prestodbpresto
bad error message when select be use in group by query
Bug
sql select from value 1 1 t x y group by x fail with query 20160907 180025 00008 b5xgd fail input 1 must be an aggregate expression or appear in group by clause com facebook presto sql analyzer semanticexception input 1 must be an aggregate expression or appear in group by clause at com facebook presto sql analyzer aggregationanalyzer analyze aggregationanalyzer java 133 at com facebook presto sql analyzer statementanalyzer verifyaggregations statementanalyzer java 1433 at com facebook presto sql analyzer statementanalyzer analyzeaggregation statementanalyzer java 1394 at com facebook presto sql analyzer statementanalyzer visitqueryspecification statementanalyzer java 655 at com facebook presto sql analyzer statementanalyzer visitqueryspecification statementanalyzer java 161 at com facebook presto sql tree queryspecification accept queryspecification java 125 at com facebook presto sql tree astvisitor process astvisitor java 22 at com facebook presto sql analyzer statementanalyzer visitquery statementanalyzer java 409 at com facebook presto sql analyzer statementanalyzer visitquery statementanalyzer java 161 at com facebook presto sql tree query accept query java 103 at com facebook presto sql tree astvisitor process astvisitor java 22 at com facebook presto sql analyzer analyzer analyze analyzer java 62 at com facebook presto execution sqlqueryexecution doanalyzequery sqlqueryexecution java 274 at com facebook presto execution sqlqueryexecution analyzequery sqlqueryexecution java 260 at com facebook presto execution sqlqueryexecution start sqlqueryexecution java 224 at com facebook presto execution queuedexecution lambda start 1 queuedexecution java 62 at java util concurrent threadpoolexecutor runworker threadpoolexecutor java 1142 at java util concurrent threadpoolexecutor worker run threadpoolexecutor java 617 at java lang thread run thread java 745 the correct message should be query 20160907 180138 16338 4xh5v fail line 1 1 column t y not in group by clause this seem to be a regression in a recent version it doesn t happen in 0 144 7
prestodbpresto
sqlqueryqueuemanager cause http 500 when no rule match
Bug
use presto 0 144 4 presto select from system runtime node error running command error start query at return an invalid response jsonresponse statuscode 500 statusmessage internal server error header content length 5551 date we d 07 sep 2016 16 31 51 gmt www authenticate negotiate realm presto oyh1mihyoamkaqchcwyjkozihvcsaqicom4ebgbqbgkqhkig9xibagicag9bmfmgawibbaedagepok0ws6adagesokqeqg84qekcw3ihlbsbwhzn g3liicbg9cmszchon1kqdvcgb3msvkqhmt9bu11l6qphbut6nuegaioccib76 pbjjabqnubgxgagyjkozihvcsaqicagbvwzbzoamcaqwhawibd6jnmeugawibeqjebeipoebjhft4os20m8b8zf4nyyiggrvxdlm3bzjdsqnvxiadzll5kozrfw1ndzeqj4w1lep7hiacdnhige vj24yqg4 content type text plain hasvalue false value null error com facebook presto spi prestoexception query do not match any queue rule at com facebook presto execution sqlqueryqueuemanager selectqueue sqlqueryqueuemanager java 80 at com facebook presto execution sqlqueryqueuemanager submit sqlqueryqueuemanager java 57 at com facebook presto execution sqlquerymanager createquery sqlquerymanager java 336 at com facebook presto server statementresource query statementresource java 286 at com facebook presto server statementresource createquery statementresource java 167 at sun reflect generatedmethodaccessor1366 invoke unknown source at sun reflect delegatingmethodaccessorimpl invoke delegatingmethodaccessorimpl java 43 at java lang reflect method invoke method java 498 at org glassfish jersey server model internal resourcemethodinvocationhandlerfactory 1 invoke resourcemethodinvocationhandlerfactory java 81 at org glassfish jersey server model internal abstractjavaresourcemethoddispatcher 1 run abstractjavaresourcemethoddispatcher java 144 at org glassfish jersey server model internal abstractjavaresourcemethoddispatcher invoke abstractjavaresourcemethoddispatcher java 161 at org glassfish jersey server model internal javaresourcemethoddispatcherprovider responseoutinvoker dodispatch javaresourcemethoddispatcherprovider java 160 at org glassfish jersey server model internal abstractjavaresourcemethoddispatcher dispatch abstractjavaresourcemethoddispatcher java 99 at org glassfish jersey server model resourcemethodinvoker invoke resourcemethodinvoker java 389 at org glassfish jersey server model resourcemethodinvoker apply resourcemethodinvoker java 347 at org glassfish jersey server model resourcemethodinvoker apply resourcemethodinvoker java 102 at org glassfish jersey server serverruntime 2 run serverruntime java 326 at org glassfish jersey internal error 1 call error java 271 at org glassfish jersey internal error 1 call error java 267 at org glassfish jersey internal error process error java 315 at org glassfish jersey internal error process error java 297 at org glassfish jersey internal error process error java 267 at org glassfish jersey process internal requestscope runinscope requestscope java 317 at org glassfish jersey server serverruntime process serverruntime java 305 at org glassfish jersey server applicationhandler handle applicationhandler java 1154 at org glassfish jersey servlet webcomponent serviceimpl webcomponent java 473 at org glassfish jersey servlet webcomponent service webcomponent java 427 at org glassfish jersey servlet servletcontainer service servletcontainer java 388 at org glassfish jersey servlet servletcontainer service servletcontainer java 341 at org glassfish jersey servlet servletcontainer service servletcontainer java 228 at org eclipse jetty servlet servletholder handle servletholder java 845 at org eclipse jetty servlet servlethandler cachedchain dofilter servlethandler java 1689 at com facebook presto server security spnegofilter dofilter spnegofilter java 157 at org eclipse jetty servlet servlethandler cachedchain dofilter servlethandler java 1676 at io airlift http server tracetokenfilter dofilter tracetokenfilter java 63 at org eclipse jetty servlet servlethandler cachedchain dofilter servlethandler java 1676 at io airlift http server timingfilter dofilter timingfilter java 52 at org eclipse jetty servlet servlethandler cachedchain dofilter servlethandler java 1676 at org eclipse jetty servlet servlethandler dohandle servlethandler java 581 at org eclipse jetty server handler scopedhandler handle scopedhandler java 143 at org eclipse jetty server handler gzip gziphandler handle gziphandler java 399 at org eclipse jetty server handler contexthandler dohandle contexthandler java 1162 at org eclipse jetty servlet servlethandler doscope servlethandler java 511 at org eclipse jetty server handler contexthandler doscope contexthandler java 1092 at org eclipse jetty server handler scopedhandler handle scopedhandler java 141 at org eclipse jetty server handler handlercollection handle handlercollection java 119 at org eclipse jetty server handler statisticshandler handle statisticshandler java 169 at org eclipse jetty server handler handlerlist handle handlerlist java 52 at org eclipse jetty server handler handlerwrapper handle handlerwrapper java 134 at org eclipse jetty server server handle server java 518 at org eclipse jetty server httpchannel handle httpchannel java 308 at org eclipse jetty server httpconnection onfillable httpconnection java 244 at org eclipse jetty io abstractconnection readcallback succeed abstractconnection java 273 at org eclipse jetty io fillinterest fillable fillinterest java 95 at org eclipse jetty io ssl sslconnection onfillable sslconnection java 186 at org eclipse jetty io abstractconnection readcallback succeed abstractconnection java 273 at org eclipse jetty io fillinterest fillable fillinterest java 95 at org eclipse jetty io selectchannelendpoint 2 run selectchannelendpoint java 93 at org eclipse jetty util thread strategy executeproduceconsume produceandrun executeproduceconsume java 246 at org eclipse jetty util thread strategy executeproduceconsume run executeproduceconsume java 156 at org eclipse jetty util thread queuedthreadpool runjob queuedthreadpool java 654 at org eclipse jetty util thread queuedthreadpool 3 run queuedthreadpool java 572 at java lang thread run thread java 745
prestodbpresto
incorrect result when cross join against aggregation over partitioned table
Bug
this query sql select from value 1 2 3 t cross join select count from table where pk non existent u pk be a partition key for table produce an incorrect plan output col0 col1 field bigint count bigint col0 field col1 count innerjoin field bigint count bigint filter false field bigint value field bigint 1 2 3 aggregate final count bigint count count count 235 exchange gather count 235 bigint aggregate partial count 235 bigint count 235 count tablescan none it seem to be push the false predicate due to no matching partition up through the aggregation and push it down on the left side
prestodbpresto
negative datasize for operatorcontext getoperatorstat
Bug
stack trace from presto 0 144 7 java util concurrent completionexception java lang illegalargumentexception size be negative at java util concurrent completablefuture encodethrowable completablefuture java 292 at java util concurrent completablefuture completethrowable completablefuture java 308 at java util concurrent completablefuture uniapply completablefuture java 593 at java util concurrent completablefuture uniapply tryfire completablefuture java 577 at java util concurrent completablefuture postcomplete completablefuture java 474 at java util concurrent completablefuture completeexceptionally completablefuture java 1977 at io airlift concurrent morefuture unmodifiablecompletablefuture internalcompleteexceptionally morefuture java 376 at io airlift concurrent morefuture timeoutfuturetask run morefuture java 444 at java util concurrent executors runnableadapter call executor java 511 at java util concurrent futuretask run futuretask java 266 at java util concurrent scheduledthreadpoolexecutor scheduledfuturetask access 201 scheduledthreadpoolexecutor java 180 at java util concurrent scheduledthreadpoolexecutor scheduledfuturetask run scheduledthreadpoolexecutor java 293 at java util concurrent threadpoolexecutor runworker threadpoolexecutor java 1142 at java util concurrent threadpoolexecutor worker run threadpoolexecutor java 617 at java lang thread run thread java 745 cause by java lang illegalargumentexception size be negative at com google common base precondition checkargument precondition java 122 at io airlift unit datasize datasize java 53 at com facebook presto operator operatorcontext getoperatorstat operatorcontext java 401 at com google common collect iterator 8 transform iterator java 799 at com google common collect transformediterator next transformediterator java 48 at com google common collect immutablecollection builder addall immutablecollection java 301 at com google common collect immutablelist builder addall immutablelist java 691 at com google common collect immutablelist copyof immutablelist java 275 at com google common collect immutablelist copyof immutablelist java 226 at com facebook presto operator drivercontext getdriverstat drivercontext java 323 at com facebook presto operator pipelinecontext getpipelinestat pipelinecontext java 352 at com google common collect iterator 8 transform iterator java 799 at com google common collect transformediterator next transformediterator java 48 at com google common collect immutablelist copyof immutablelist java 271 at com google common collect immutablelist copyof immutablelist java 226 at com facebook presto operator taskcontext gettaskstat taskcontext java 273 at com facebook presto execution sqltask createtaskinfo sqltask java 205 at com facebook presto execution sqltask gettaskinfo sqltask java 178 at com facebook presto execution sqltaskmanager gettaskinfo sqltaskmanager java 240 at com facebook presto server taskresource lambda gettaskinfo 0 taskresource java 158 at io airlift concurrent morefuture timeoutfuturetask run morefuture java 440 7 more at com facebook presto server httpremotetask simplehttpresponsehandler onsuccess httpremotetask java 904 at com facebook presto server httpremotetask simplehttpresponsehandler onsuccess httpremotetask java 873 at com google common util concurrent future 6 run future java 1319 at io airlift concurrent boundedexecutor executeormerge boundedexecutor java 69 at io airlift concurrent boundedexecutor access 000 boundedexecutor java 28 at io airlift concurrent boundedexecutor 1 run boundedexecutor java 40 at java util concurrent threadpoolexecutor runworker threadpoolexecutor java 1142 at java util concurrent threadpoolexecutor worker run threadpoolexecutor java 617 at java lang thread run thread java 745 this be the line in operatorcontext java that throw java new datasize outputdatasize gettotalcount byte converttomostsuccinctdatasize
prestodbpresto
support english month suffix formatter for mysql date function
Enhancement
date format and date parse should support d
prestodbpresto
support sunday week formatter for mysql date function
Enhancement
date format and date parse should support u u v x w this will require rewrite the format function likely use the new java 8 apis since joda time only support iso week day
prestodbpresto
ml plugin print junk to stdout
Bug
I see message like this when run the test optimization finish iter 48 nu 0 86 obj 77 81212739041075 rho 1 6302973218262196 nsv 86 nbsv 86 total nsv 86 warning training datum in only one class see readme for detail total nsv 0
prestodbpresto
statecompiler should handle error from newinstance
Bug
the newinstance call can throw thing like noclassdeffounderror this be due to a bug but it s probably good to these in a runtimeexception instead of let it propagate as be we could handle any throwable but linkageerror be safe and should cover such bug java lang noclassdeffounderror could not initialize class com facebook presto ml learnstatefactory at sun reflect nativeconstructoraccessorimpl newinstance0 native method at sun reflect nativeconstructoraccessorimpl newinstance nativeconstructoraccessorimpl java 62 at sun reflect delegatingconstructoraccessorimpl newinstance delegatingconstructoraccessorimpl java 45 at java lang reflect constructor newinstance constructor java 423 at com facebook presto operator aggregation state statecompiler generatestatefactory statecompiler java 327 at com facebook presto operator aggregation bindableaggregationfunction specialize bindableaggregationfunction java 108 at com facebook presto metadata functionregistry 2 load functionregistry java 321 at com facebook presto metadata functionregistry 2 load functionregistry java 315 at com google common cache localcache loadingvaluereference loadfuture localcache java 3527 at com google common cache localcache segment loadsync localcache java 2319 at com google common cache localcache segment lockedgetorload localcache java 2282 at com google common cache localcache segment get localcache java 2197 at com google common cache localcache get localcache java 3937 at com google common cache localcache getorload localcache java 3941 at com google common cache localcache localloadingcache get localcache java 4824 at com google common cache localcache localloadingcache getunchecke localcache java 4830 at com facebook presto metadata functionregistry getaggregatefunctionimplementation functionregistry java 793 at java util stream referencepipeline 3 1 accept referencepipeline java 193 at java util spliterators iteratorspliterator tryadvance spliterator java 1812 at java util stream referencepipeline foreachwithcancel referencepipeline java 126 at java util stream abstractpipeline copyintowithcancel abstractpipeline java 498 at java util stream abstractpipeline copyinto abstractpipeline java 485 at java util stream abstractpipeline wrapandcopyinto abstractpipeline java 471 at java util stream matchop matchop evaluatesequential matchop java 230 at java util stream matchop matchop evaluatesequential matchop java 196 at java util stream abstractpipeline evaluate abstractpipeline java 234 at java util stream referencepipeline allmatch referencepipeline java 454 at com facebook presto sql planner optimization addexchange rewriter visitaggregation addexchange java 270 at com facebook presto sql planner optimization addexchange rewriter visitaggregation addexchange java 189 at com facebook presto sql planner plan aggregationnode accept aggregationnode java 189 at com facebook presto sql planner optimizations addexchange rewriter planchild addexchange java 1253 at com facebook presto sql planner optimization addexchange rewriter visitproject addexchange java 232 at com facebook presto sql planner optimization addexchange rewriter visitproject addexchange java 189 at com facebook presto sql planner plan projectnode accept projectnode java 81 at com facebook presto sql planner optimizations addexchange rewriter planchild addexchange java 1253 at com facebook presto sql planner optimizations addexchange rewriter visitoutput addexchange java 238 at com facebook presto sql planner optimizations addexchange rewriter visitoutput addexchange java 189 at com facebook presto sql planner plan outputnode accept outputnode java 81 at com facebook presto sql planner optimization addexchange optimize addexchange java 151 at com facebook presto sql planner logicalplanner plan logicalplanner java 116 at com facebook presto sql planner logicalplanner plan logicalplanner java 107 at com facebook presto execution sqlqueryexecution doanalyzequery sqlqueryexecution java 290 at com facebook presto execution sqlqueryexecution analyzequery sqlqueryexecution java 269 at com facebook presto execution sqlqueryexecution start sqlqueryexecution java 227 at com facebook presto execution queuedexecution lambda start 1 queuedexecution java 62 at java util concurrent threadpoolexecutor runworker threadpoolexecutor java 1142 at java util concurrent threadpoolexecutor worker run threadpoolexecutor java 617 at java lang thread run thread java 745
prestodbpresto
throwable not handle properly during plan
Bug
if a query throw an error during plan it isn t handle and go to stderr 2016 08 30t21 47 49 836 0700 info query scheduler 0 stderr exception in thread query scheduler 0 2016 08 30t21 47 49 836 0700 info query scheduler 0 stderr com google common util concurrent executionerror java lang noclassdeffounderror could not initialize class com facebook presto ml learnstatefactory 2016 08 30t21 47 49 837 0700 info query scheduler 0 stderr at com google common cache localcache segment get localcache java 2201 2016 08 30t21 47 49 837 0700 info query scheduler 0 stderr at com google common cache localcache get localcache java 3937 2016 08 30t21 47 49 837 0700 info query scheduler 0 stderr at com google common cache localcache getorload localcache java 3941 2016 08 30t21 47 49 837 0700 info query scheduler 0 stderr at com google common cache localcache localloadingcache get localcache java 4824 2016 08 30t21 47 49 837 0700 info query scheduler 0 stderr at com google common cache localcache localloadingcache getunchecke localcache java 4830 2016 08 30t21 47 49 837 0700 info query scheduler 0 stderr at com facebook presto metadata functionregistry getaggregatefunctionimplementation functionregistry java 793 2016 08 30t21 47 49 837 0700 info query scheduler 0 stderr at java util stream referencepipeline 3 1 accept referencepipeline java 193 2016 08 30t21 47 49 837 0700 info query scheduler 0 stderr at java util spliterators iteratorspliterator tryadvance spliterator java 1812 2016 08 30t21 47 49 837 0700 info query scheduler 0 stderr at java util stream referencepipeline foreachwithcancel referencepipeline java 126 2016 08 30t21 47 49 837 0700 info query scheduler 0 stderr at java util stream abstractpipeline copyintowithcancel abstractpipeline java 498 2016 08 30t21 47 49 837 0700 info query scheduler 0 stderr at java util stream abstractpipeline copyinto abstractpipeline java 485 2016 08 30t21 47 49 837 0700 info query scheduler 0 stderr at java util stream abstractpipeline wrapandcopyinto abstractpipeline java 471 2016 08 30t21 47 49 837 0700 info query scheduler 0 stderr at java util stream matchop matchop evaluatesequential matchop java 230 2016 08 30t21 47 49 837 0700 info query scheduler 0 stderr at java util stream matchop matchop evaluatesequential matchop java 196 2016 08 30t21 47 49 837 0700 info query scheduler 0 stderr at java util stream abstractpipeline evaluate abstractpipeline java 234 2016 08 30t21 47 49 837 0700 info query scheduler 0 stderr at java util stream referencepipeline allmatch referencepipeline java 454 2016 08 30t21 47 49 837 0700 info query scheduler 0 stderr at com facebook presto sql planner optimization addexchange rewriter visitaggregation addexchange java 270 2016 08 30t21 47 49 837 0700 info query scheduler 0 stderr at com facebook presto sql planner optimization addexchange rewriter visitaggregation addexchange java 189 2016 08 30t21 47 49 837 0700 info query scheduler 0 stderr at com facebook presto sql planner plan aggregationnode accept aggregationnode java 189 2016 08 30t21 47 49 837 0700 info query scheduler 0 stderr at com facebook presto sql planner optimizations addexchange rewriter planchild addexchange java 1253 2016 08 30t21 47 49 837 0700 info query scheduler 0 stderr at com facebook presto sql planner optimization addexchange rewriter visitproject addexchange java 232 2016 08 30t21 47 49 837 0700 info query scheduler 0 stderr at com facebook presto sql planner optimization addexchange rewriter visitproject addexchange java 189 2016 08 30t21 47 49 837 0700 info query scheduler 0 stderr at com facebook presto sql planner plan projectnode accept projectnode java 81 2016 08 30t21 47 49 837 0700 info query scheduler 0 stderr at com facebook presto sql planner optimizations addexchange rewriter planchild addexchange java 1253 2016 08 30t21 47 49 837 0700 info query scheduler 0 stderr at com facebook presto sql planner optimizations addexchange rewriter visitoutput addexchange java 238 2016 08 30t21 47 49 837 0700 info query scheduler 0 stderr at com facebook presto sql planner optimizations addexchange rewriter visitoutput addexchange java 189 2016 08 30t21 47 49 837 0700 info query scheduler 0 stderr at com facebook presto sql planner plan outputnode accept outputnode java 81 2016 08 30t21 47 49 837 0700 info query scheduler 0 stderr at com facebook presto sql planner optimization addexchange optimize addexchange java 151 2016 08 30t21 47 49 837 0700 info query scheduler 0 stderr at com facebook presto sql planner logicalplanner plan logicalplanner java 116 2016 08 30t21 47 49 838 0700 info query scheduler 0 stderr at com facebook presto sql planner logicalplanner plan logicalplanner java 107 2016 08 30t21 47 49 838 0700 info query scheduler 0 stderr at com facebook presto execution sqlqueryexecution doanalyzequery sqlqueryexecution java 290 2016 08 30t21 47 49 838 0700 info query scheduler 0 stderr at com facebook presto execution sqlqueryexecution analyzequery sqlqueryexecution java 269 2016 08 30t21 47 49 838 0700 info query scheduler 0 stderr at com facebook presto execution sqlqueryexecution start sqlqueryexecution java 227 2016 08 30t21 47 49 838 0700 info query scheduler 0 stderr at com facebook presto execution queuedexecution lambda start 1 queuedexecution java 62 2016 08 30t21 47 49 838 0700 info query scheduler 0 stderr at java util concurrent threadpoolexecutor runworker threadpoolexecutor java 1142 2016 08 30t21 47 49 838 0700 info query scheduler 0 stderr at java util concurrent threadpoolexecutor worker run threadpoolexecutor java 617 2016 08 30t21 47 49 838 0700 info query scheduler 0 stderr at java lang thread run thread java 745
prestodbpresto
pushdown incorrectly handle expression that can fail
Bug
sql select from select table name round row count shard count rps from system table stat where table schema xxx and shard count 5000 where rps 10000 com facebook presto spi prestoexception by zero at com facebook presto type bigintoperator divide bigintoperator java 101 at com facebook presto gen pageprocessor 130 filter unknown source at com facebook presto gen pageprocessor 130 process unknown source at com facebook presto operator scanfilterandprojectoperator getoutput scanfilterandprojectoperator java 260 at com facebook presto operator driver processinternal driver java 378 at com facebook presto operator driver processfor driver java 301 at com facebook presto execution sqltaskexecution driversplitrunner processfor sqltaskexecution java 622 at com facebook presto execution taskexecutor prioritizedsplitrunner process taskexecutor java 529 at com facebook presto execution taskexecutor runner run taskexecutor java 665 at java util concurrent threadpoolexecutor runworker threadpoolexecutor java 1142 at java util concurrent threadpoolexecutor worker run threadpoolexecutor java 617 at java lang thread run thread java 745 cause by java lang arithmeticexception by zero at com facebook presto type bigintoperator divide bigintoperator java 98 11 more
prestodbpresto
window function can not be use in some scalar expression
Bug
select 100 0 sum x over sum x over sum x over from value 1 t x query 20160830 174122 00896 w2gwn fail sum bigint bigint be not a scalar function java lang illegalargumentexception sum bigint bigint be not a scalar function at com google common base precondition checkargument precondition java 145 at com facebook presto metadata functionregistry getscalarfunctionimplementation functionregistry java 805 at com facebook presto sql planner expressioninterpreter visitor visitfunctioncall expressioninterpreter java 897 at com facebook presto sql tree functioncall accept functioncall java 96 at com facebook presto sql tree astvisitor process astvisitor java 22 at com facebook presto sql planner expressioninterpreter optimize expressioninterpreter java 243 at com facebook presto sql planner optimizations simplifyexpression rewriter simplifyexpression simplifyexpression java 156 at com google common collect map 7 transformentry map java 1812 at com google common collect map 10 getvalue map java 1857 at com google common collect regularimmutablemap regularimmutablemap java 87 at com google common collect immutablemap copyof immutablemap java 294 at com facebook presto sql planner optimization simplifyexpression rewriter visitproject simplifyexpression java 110 at com facebook presto sql planner optimization simplifyexpression rewriter visitproject simplifyexpression java 88 at com facebook presto sql planner plan projectnode accept projectnode java 81 at com facebook presto sql planner plan simpleplanrewriter rewritecontext rewrite simpleplanrewriter java 85 at com facebook presto sql planner plan simpleplanrewriter rewritecontext rewrite simpleplanrewriter java 96 at com facebook presto sql planner optimization simplifyexpression rewriter visitproject simplifyexpression java 109 at com facebook presto sql planner optimization simplifyexpression rewriter visitproject simplifyexpression java 88 at com facebook presto sql planner plan projectnode accept projectnode java 81 at com facebook presto sql planner plan simpleplanrewriter rewritecontext rewrite simpleplanrewriter java 85 at com facebook presto sql planner plan simpleplanrewriter rewritecontext rewrite simpleplanrewriter java 96 at com facebook presto sql planner optimization simplifyexpression rewriter visitproject simplifyexpression java 109 at com facebook presto sql planner optimization simplifyexpression rewriter visitproject simplifyexpression java 88 at com facebook presto sql planner plan projectnode accept projectnode java 81 at com facebook presto sql planner plan simpleplanrewriter rewritecontext rewrite simpleplanrewriter java 85 at com facebook presto sql planner plan simpleplanrewriter rewritecontext rewrite simpleplanrewriter java 96 at com facebook presto sql planner optimization simplifyexpression rewriter visitproject simplifyexpression java 109 at com facebook presto sql planner optimization simplifyexpression rewriter visitproject simplifyexpression java 88 at com facebook presto sql planner plan projectnode accept projectnode java 81 at com facebook presto sql planner plan simpleplanrewriter rewritecontext rewrite simpleplanrewriter java 85 at com facebook presto sql planner plan simpleplanrewriter rewritecontext lambda defaultrewrite 0 simpleplanrewriter java 74
prestodbpresto
presto stat plan time be include queue time
Bug
I notice this when presto be report super long planning time but it look like this be just because the queue be really full
prestodbpresto
ui error on detail page when outputstage be null
Bug
uncaught typeerror can not read property i d of undefined stage plan i d
prestodbpresto
ui active worker count be incorrect
Bug
the coordinator should not be include as a worker unless node scheduler include coordinator be true
prestodbpresto
npe in raptor shardcompactionmanager
Bug
2016 08 26t11 55 57 107 0700 error shard compaction discovery com facebook presto raptor storage organization shardcompactionmanager error discover shard to compact java lang nullpointerexception at com google common base precondition checknotnull precondition java 210 at com google common collect immutablecollection arraybasedbuilder add immutablecollection java 339 at com google common collect immutablelist builder add immutablelist java 652 at com facebook presto raptor storage organization shardorganizerutil getshardrange shardorganizerutil java 231 at com facebook presto raptor storage organization shardorganizerutil toshardindexinfo shardorganizerutil java 118 at com facebook presto raptor storage organization shardcompactionmanager filterandcreatecompactionsets shardcompactionmanager java 199 at com facebook presto raptor storage organization shardcompactionmanager discovershards shardcompactionmanager java 174 at com facebook presto raptor storage organization shardcompactionmanager lambda startdiscovery 0 shardcompactionmanager java 151 at java util concurrent executors runnableadapter call executor java 511 at java util concurrent futuretask runandreset futuretask java 308 at java util concurrent scheduledthreadpoolexecutor scheduledfuturetask access 301 scheduledthreadpoolexecutor java 180 at java util concurrent scheduledthreadpoolexecutor scheduledfuturetask run scheduledthreadpoolexecutor java 294 at java util concurrent threadpoolexecutor runworker threadpoolexecutor java 1142 at java util concurrent threadpoolexecutor worker run threadpoolexecutor java 617 at java lang thread run thread java 745