repository
stringclasses
156 values
issue title
stringlengths
1
1.01k
labels
stringclasses
8 values
body
stringlengths
1
270k
prestodbpresto
add support for a distinct from operator
Enhancement
this be need to support all operation that rely on distinct semantic currently many of they be implement use equal operator or just don t allow use in those context e g array contain null this be a prerequisite for
prestodbpresto
interleavedblock getregion do not update sizeinbyte
Bug
when transport page between machine pagesplitterutil break page up into small unit to reduce buffer requirement the logic be pretty simple repeatably split into two page use getregion util the page be small than a limit this do not work with the new interleavedblock code because getregion do no...
prestodbpresto
datum spill in join
Enhancement
we start to work on datum spill in join currently it be mostly conceptual work not much code yet before we start any serious code we would like to hear you opinion about our idea of how we think it should be do here be a design doc if you notice any problem our code misunderstanding performance or co...
prestodbpresto
large negative timestamp produce invalid result
Bug
presto select from unixtime pow 2 54 query 20160818 221137 21727 4xh5v fail unable to create class com facebook presto execution taskinfo from json response io airlift jaxrs jsonmapperparsingexception invalid json for java type com facebook presto server taskupdaterequ at io airlift jaxrs json...
prestodbpresto
categorize error for joda time arithmeticexception
Bug
presto select hour from unixtime pow 2 54 query 20160818 221052 21696 4xh5v fail add time zone offset cause overflow java lang arithmeticexception add time zone offset cause overflow at org joda time datetimezone convertutctolocal datetimezone java 929 at org joda time chrono zonedchronol...
prestodbpresto
initial support for lateral join
Enhancement
lateral join be join in which sub select and expression on the right side of lateral keyword can use the scope of the join on the left side of lateral keyword e g trivial sql select from foo lateral select from bar where bar i d foo bar i d ss which be equivalent to sql...
prestodbpresto
allow well pushdown for or predicate
Enhancement
currently or predicate be only available for pushdown for connector in spi if they be on the same column
prestodbpresto
mongodb collection name contain dot raise invalid schematablename error
Bug
hi my mongodb collection name contain dot desc table be ok select from will raise a invalid schematablename error presto desc mgo actionlog activity get coupon column type comment account varchar telephone varchar ch i...
prestodbpresto
support pattern match via match recognize
Enhancement
pattern matching allow a number of use case that be difficult or impossible to do otherwise this be specify in sql 2016 as match recognize in 4 17 row pattern match oracle have have an implementation of this for a while and very likely match the standard 1 2 3 1 2 3
prestodbpresto
use revocable memory in spillable hashaggregationoperator
Enhancement
as part of this pr please review only three last commit 1 add setrevocablememoryreservation method 2 use revocable memory for spill in aggregation 3 add query max revocable memory per node property this pull request require both and
prestodbpresto
fix hive sql standard permission on table creation
Bug
when create a hive table all privilege be translate to select insert update delete privilege when presto create a hive table it set the privilege to all rather than grant the underlie privilege this be handle incorrectly when query for authorization explode the all privilege to its constituent solve the...
prestodbpresto
fix for non power of two task writer count conflict with hash partitioning
Bug
poc fix for
prestodbpresto
set task writer count to non power of two can cause partitioncount must be a power of 2
Bug
this might happen when there be union and table writer in one pipeline set session redistribute write false set session task writer count 24 create table blackhole default test as select from tpch sf1 nation union select from tpch sf1 nation
prestodbpresto
spill to disk for aggregation v2
Enhancement
supersede notable change reorder commit remove max entry before spill property
prestodbpresto
aggregation refactor
Enhancement
I have split previous into this refactor and spiller implementation this refactor doesn t add any functionality so it should be easy to review and merge but just fix some thing require by spiller
prestodbpresto
java lang verifyerror with a query
Bug
below query fail with a java lang verifyerror bad type on operand stack with master build 9db10aa sql select a orderkey from select orderkey from tpch sf100 lineitem limit 100 a join select orderkey from tpch sf100 lineitem limit 100 b on a o...
prestodbpresto
aggregation on double column may return nondeterministic result
Bug
let create or replace view revenue as select l suppkey as supplier no sum l extendedprice 1 l discount as total revenue from lineitem where l shipdate date 1996 01 01 and l shipdate date 1996 01 01 interval 3 month group by l suppkey then...
prestodbpresto
fix show create table for raptor
Bug
raptormetadata gettablemetadata do not include table property so show create table do not include they we want to make as few database call as possible these be the property we need order could be add to tablecolumn temporal column could be add to tablecolumn bucket count alre...
prestodbpresto
integer to decimal cast fail with large scale
Bug
presto select cast 1 as decimal 38 30 col0 0 000000000009223372036854775807 1 row issue be cause by this code static for int I 0 I long power of ten length I long power of ten I ...
prestodbpresto
raptor connection leak
Bug
when use mysql as backend there be a connection leak 2016 07 28t14 32 56 300z warn hikaripool 1 housekeeper com zaxxer hikari pool proxyleaktask connection leak detection trigger for com mysql jdbc jdbc4connection 7ef9c8a5 stack trace follow java lang exception apparent connection lea...
prestodbpresto
postgresql connector error stack depth limit exceed
Bug
the testpostgresqldistributedquerie testlargein test for postgresql connector be fail since 0 149 or eali the error be not catch by the ci build because of testpostgresqldistributedquerie java be exclude in postgresql connector pom which maybe be another issue I be go to disable this test with a li...
prestodbpresto
correctly handle error from url decode
Bug
this make the function work with try
prestodbpresto
fix operatorcontext race condition
Bug
address issue first commit fix this issue second be a proposal for the refactor
prestodbpresto
operatorcontext be not threadsafe
Bug
contrary to the misleading threadsafe annotation and usage of atomiclong everywhere in it operatorcontext be not threadsafe I have stumble on it while implement some thing relate to spill and revocable memory there be at least problem with setmemoryreservation trysetmemoryreservation method ...
prestodbpresto
fix decimal stat rescale in presto orc tuple domain predicate
Bug
fyi cberner
prestodbpresto
fix handling of failure class without canonical name
Bug
this fix an npe for thing like anonymous class however I m not sure why getcanonicalname be use at all rather than getname dain
prestodbpresto
fix travis non reporting of product and integration test failure
Bug
the error be introduce in 5421 and 5471 sorry about that luckily there be no test failure in master proof that this commit fix the false positive problem
prestodbpresto
varchar n and var args function
Bug
the follow query fail select from select concat t x t z cc from select from value varchar a varchar c t x z t join select from value varchar a varchar c u x z where z c split part b c 2 u on t z ...
prestodbpresto
miss repartitioning step break window function result
Bug
we find a weird window function behavior when a query involve multiple window function and self join here be how to reproduce this problem in presto 0 146 ok query presto explain with x as select i d rank over partition by i d as rank from kw sequences y as select b i d a ranking f...
prestodbpresto
add support for postgre json type
Enhancement
this could be expose to presto as an unbounded varchar or a presto json type
prestodbpresto
fix ridiculously long error from parser
Enhancement
spit out every possible keyword isn t helpful presto select top 1 query 20160712 200120 24229 y6z74 fail line 1 12 extraneous input 1 expect from add as where group order have limit approximate at confidence or and in not ...
prestodbpresto
handle large split count in cli
Bug
the alignment of column be wrong when there be 100 000 split example stage row row s bytes bytes s queue run do 0 r 0 0 0b 0b 0 1 0 1 r 153k 250 3 36 m 5 62k 0 100 0 2 s 71 7b ...
prestodbpresto
uncategorized error for too many dot
Bug
presto select from a b c d query 20160707 192115 20747 y6z74 fail too many dot in table name a b c d java lang illegalargumentexception too many dot in table name a b c d at com google common base precondition checkargument precondition java 145 at com facebook presto metadata metadatauti...
prestodbpresto
query with function return color type fail
Bug
sql presto select rgb 0 0 0 query be go server restart stack trace query 20160701 183636 00000 9c6sb run 1 node 0 split java lang runtimeexception error fetch next at return an invalid response jsonresponse statuscode 200 statusmessage ok header vary accept encode use...
prestodbpresto
use succinct size in raptor log message for shard copy
Enhancement
message copy shard ab17da2e fd87 4f35 a3a1 6a767f7ba1ef from backup in 15 00 13898959b at 904 94 kb s 13898959b would be easy to read in mb
prestodbpresto
exceededmemorylimitexception at presto 0 148 0 149
Bug
hi I use presto 0 149 jdk1 8 0 92 hdp 2 1 hive connector cento 6 5 if I execute the follow query query exceed max memory size of 70 gb error occur select from test hogeview where yyyymmdd 20160622 limit 1 test hogeview be presto view and have many leave outer join clause an...
prestodbpresto
division by zero error with empty interleaved block
Bug
this change 373c745b30b2db1e96eef844096b3620a11a84c7 add this bit to interleavedblockencode readblock java byte isempty sliceinput readbyte if isempty 1 return new interleavedblock new block 0 interleavedblock perform division use the length of that array column which resu...
prestodbpresto
tableau web connector hard code hive catalog in it
Bug
I find presto tableau web connector hard code hive catalog in it tableau presto connector html var catalogclient new statementclient catalog hive schema default query show catalog ...
prestodbpresto
add connection property for jdbc
Enhancement
after 6078 be merge add property for time zone local source etc
prestodbpresto
non block api in connectorpagesource
Enhancement
it make possible to use asynchronous datum fetch in connector by analogy to the connectorpagesink appendpage method connectorpagesource getnextpage should return completablefuture instead of page all of the connector initially should be migrate to return completablefuture completedfuture page ...
prestodbpresto
grouping set over union fail
Bug
the follow query select x count distinct x as c from select from value 1 t x union all select from value 1 t x t2 group by group set x fail with query 20160622 013115 00003 u5amn fail index 0 must be less tha...
prestodbpresto
add hidden input file name column to hive connector
Enhancement
this be likely a lot of work as this would need to be add to every reader the implementation should work like partition key and it may be possible to leverage that code
prestodbpresto
array agg should not ignore null
Bug
presto select array agg x from value 1 2 3 null t x col0 1 2 3 the expect result be 1 2 3 null from the spec ii otherwise the result of be an array of n element such that for all I 1 one I n the value of the i th element be the v...
prestodbpresto
round nan 2 return 0 0
Bug
select round nan 2 result in 0 0 but should be nan this be a regression since 0 144 5
prestodbpresto
query not fail ed when it doesn t match any selection rule
Bug
the failure isn t properly propagate and the query continue to show queue state until it get expire after 5 minute presto presto show table error running command error start query at return an invalid response jsonresponse statuscode 500 statusmessage internal server error header content...
prestodbpresto
type mismatch in plan
Bug
late master presto tiny explain select avg extendedprice from lineitem query plan output col0 avg double col0 avg ...
prestodbpresto
leave join against empty relation produce no row
Bug
this can be reproduce with the follow test case test public void testemptyleftjoin throw exception use orderkey rand to create an empty relation assertquery select from lineitem a left join select from order where orderkey rand b on a ord...
prestodbpresto
add queued flag to statementstat
Enhancement
this flag should be add before the schedule flag it provide a proper way for client to know if the query be wait in the queue client should not be programmatically use the state field
prestodbpresto
change reserve memory graph in web ui to free memory
Enhancement
instead of display total user memory on the cluster in the new web ui it be more useful to display free distribute memory in the general pool system pool along with min local memory on a node for general system
prestodbpresto
incorrect row construct result
Bug
the late 0 148 snapshot presto tiny select row x y z m n from value row cast null as integer 2 3 4 5 t x y z m n col0 field0 null field1 null field2 null field3 null field4 null 1 row ...
prestodbpresto
support window clause
Enhancement
the standard window clause allow define name window which window function can reference sql select x sum x over w from value 1 2 3 as t x window w as order by x additionally a window specification can reference and modify a name window sql select x sum x over w...
prestodbpresto
parse time stamp
Enhancement
be it possible parse time stamp 28 jan 16 11 45 46 421000000 pm in presto I try it with follow query select date parse 28 jan 16 11 45 46 421000000 pm d b y l I s f p error invalid format 28 jan 16 11 45 46 421000000 pm be malforme at 000 pm I get this time stamp format from...
prestodbpresto
consider add array contain for multiple item
Enhancement
it can be useful to check if an array contain multiple item we could have separate version of contain that handle any and all contain any array 2 3 4 array 3 5 true contain any array 2 3 4 array 5 6 false contain all array 2 3 4 array 3 4 true contain all array ...
prestodbpresto
plan error when same subquery appear in select and where clause
Bug
sql select x in select from value 1 from value 2 t x where x in select from value 1 fail with java lang illegalargumentexception invalid node expression dependency field field 1 not in source plan output field semijoin result at com google common base ...
prestodbpresto
round 0 49999999999999994 give wrong result
Bug
presto use floor value 0 5 concept to round value which cause problem when it come to value 0 49999999999999994 0x1 fffffffffffffp 2 e g sql presto select round 0 49999999999999994 col0 1 0 1 row
prestodbpresto
bad error message when row in value have different number of field
Bug
sql value 1 1 2 fail with java lang indexoutofboundsexception index 1 size 1 at java util arraylist rangecheck arraylist java 653 at java util arraylist get arraylist java 429 at com facebook presto sql analyzer statementanalyzer visitvalues statementanalyzer java 1429 ...
prestodbpresto
presto verifier incorrect manual
Bug
presto verifier verifier config property 2016 05 23t14 12 28 722 0900 error main bootstrap uncaught exception in thread main org skife jdbi v2 exception unabletoexecutestatementexception com mysql jdbc exception jdbc4 mysqlsyntaxerrorexception unknown column session property js...
prestodbpresto
can not chain at time zone
Bug
chain at time zone together result in the error null presto select timestamp 2012 10 31 01 00 at time zone america los angeles at time zone utc query 20160520 185347 00028 kmihc fail null presto can work around this with e g presto with tz la as select timestamp 2...
prestodbpresto
over row between unbounded precede and n precede return incorrect result
Bug
the same issue apply to over row between n follow and unbounded follow the actual behavior be presto tiny select nationkey sum regionkey over row between unbounded preceding and 2 precede from nation limit 5 nationkey col1 0 0 1 0 2 0 3 ...
prestodbpresto
prepare should overwrite exist name
Bug
I be look at the spec under 20 6 and find this 9 if identify a prepared statement ps then an implicit deallocate prepare ssn be execute where ssn be an that identify ps
prestodbpresto
fix redis hash for date
Bug
the schema for the hash test testredisdistributedhash be change to use date instead of varchar in 31118ab8479707aab098db2fe066931c8c2cd868 but the test fail with that change I revert it in 5313 but we should fix the redis connector so it actually work with date note that those test be disable b...
prestodbpresto
allow empty string as delimiter for split
Enhancement
currently you can not provide an empty string as a delimiter for the split function the error be select split abc query 20160517 035643 07058 prqtw fail the delimiter may not be the empty string the expect behavior be that each character in the string will be it s own value in the array ...
prestodbpresto
support quantify comparison predicate
Enhancement
from the spec all some any
prestodbpresto
row type hash implementation throw mislead message
Bug
message should say hash be not support for com facebook presto spi prestoexception row comparison not support for field with null element at com facebook presto type rowtype checkelementnotnull rowtype java 216 at com facebook presto type rowtype hash rowtype java 206
prestodbpresto
no implicit coercion in semijoin
Bug
presto tiny explain select orderkey from order where orderkey in value 39301 39330 query plan output orderkey ord...
prestodbpresto
presto doesn t correctly deal with complex aggregation when argument be also group by column
Bug
hi I might find a bug relate to rollup function could you look into this issue problem rollup function return 0 as total count if count column be use if count be use presto return a correct result postgresql 9 5 2 psql psql 9 5 2 type help for help postgre with ...
prestodbpresto
only abort transaction if query actually fail
Bug
a failure after the query complete be not a true query failure this can happen when a limit race with a failure on a node
prestodbpresto
error in year part of date parse
Bug
select date parse 28 jan 16 11 45 46 421000 pm d b y l I s f p col0 1916 01 28 23 45 46 421 1 row year which have to be 2016 be parse as 1916
prestodbpresto
kafka order by partition offset
Enhancement
in the kafka connector it would be nice if the order by partition offset desc could be push down rely on the fact that kafka partition be order example use case read the late 10 message in kafka select from mytable order by partition offset desc limit 10 any plan to support that thank y...
prestodbpresto
add function which convert time timestamp to different timezone
Enhancement
currently presto have at time zone syntax take a time timestamp and a string or time interval literal to convert the time timestamp we don t need to change the semantic of at time zone instead we only need to rename the exist function make they public and update desugaringoptimzer to rewrite a...
prestodbpresto
typo in extract call crash cli
Bug
select extract hou from create time from value 1 exception in thread main java lang illegalargumentexception no enum constant com facebook presto sql tree extract field hou at java lang enum valueof enum java 238 at com facebook presto sql tree extract field valueof extract...
prestodbpresto
do not allow raptor table and view name to conflict
Bug
raptor currently allow create a view and table with the same name
prestodbpresto
escape identifier in sql formatter
Bug
identifier that contain space dot etc need to be escape properly with double quote in the sql formatter we should have test for every statement that have an identifier
prestodbpresto
spill to disk
Enhancement
we want presto to handle large or skewed query instead of fail with out of memory error generally speak mechanism should be construct in such way that it be possible to implement spiller to disk hdfs and or to compress memory and use those spiller in all relevant operator currently we want to focus on spill ...
prestodbpresto
spill to disk for aggregation
Enhancement
this code have some issue but I think it s some starting point which be worth show before resolve they on our test cluster this poc allow to pass multiple query which be previously fail due to lack of memory for example select avg quantity as aq avg extendedprice as ae avg discount as ad avg ta...
prestodbpresto
noclassdeffounderror subnetutil
Bug
I be get the follow error when try to query a hive table use ether 0 145 or 0 141 t be anyone else also face this issue jdk v1 8 0 72 b15 2016 04 26t22 20 24 414 0200 warn hive hive 110 com facebook presto hive util resumabletask resumabletask complete exceptionally java lang noclassdeffounderro...
prestodbpresto
race condition in array concat
Bug
a query like sql select count x from select concat a b x from t where a and b be of type array map string double fail non deterministically with various exception presto version 0 144 2 java lang illegalstateexception closeentry call before anything be writ...
prestodbpresto
java lang nullpointerexception maxsize be null transient issue
Bug
hi all we re see a very weird issue that only happen in new version of presto here s the setup 50 worker node 1 master node we be use hive connector as follow connector name hive hadoop2 hive metastore uri thrift xxx 9083 hive s3 aw access key xxx hive s3 aws secret key xxx hive parquet use co...
prestodbpresto
feature request show schemas like pattern
Enhancement
hive support show database like pattern languagemanualddl showdatabase it would be nice if presto support something similar show schema like pattern I see that show table already support a like pattern clause so hopefully it win t be too hard to extend that to show database as...
prestodbpresto
optimize union all of similar aggregation
Enhancement
query of the follow shape sql select a1 an agg1 agg2 from t where f1 union all select b1 bn agg3 agg4 from t where f2 a1 an b1 bn be constant can be optimize to process all the datum in a single pass ...
prestodbpresto
add support for filter aggregation syntax
Enhancement
from the sql spec filter where a shall not contain a a or an outer reference 2 let t be the argument source of af 3 a if be specify then the be effectively evaluate for each row of t let t1 be the collection of row of t ...
prestodbpresto
add well type check to plansanitychecker
Enhancement
we need to make sure the type of input and output match each other and what the user type in this will prevent issue like 5075
prestodbpresto
map type literal syntax
Enhancement
when write literal map s with more than a few field my query become very difficult to read especially if the value of the map be complex map array array even if I break up the key and value into separate line when read the query I have to manually associate which key map to which value be...
prestodbpresto
date constructor should handle year 0 correctly
Bug
year zero be convert to january 2nd of 1 ad presto select date 0000 12 31 col0 0001 01 02 1 row it should be reject similar to other invalid date presto select date 2015 02 29 query fail value can not be cast to date 2015 02 29 presto select da...
prestodbpresto
use proper error code for bucket error
Bug
we should use a new error code in backgroundhivesplitloader listandsortbucketfile something like hive invalid bucket file
prestodbpresto
testverticalwidecharactervalue fail with lang or file encoding set to non utf 8
Bug
set the lang env variable or file encoding to anything other than utf 8 cause this test to fail java lang assertionerror expect record 1 name hello bye but find record 1 name hello bye at org testng assert fail assert java 94 at org testng assert failnotequ...
prestodbpresto
sequence function to generate synthetic array
Enhancement
something like sequence from bigint to bigint array bigint sequence from int to int array int sequence 1 10 1 2 3 4 5 6 7 8 9 10
prestodbpresto
testselectpartitionedhivetabledifferentformat be flaky
Bug
just run this test on my box 200 time and see no failure however travis keep randomly fail on this test I m also not sure what it s really mean to test
prestodbpresto
record presto version when write table partition
Enhancement
this can be useful to track down potentially incorrect datum due to bug in specific presto version for hive it could be store in a table property
prestodbpresto
handle hive orc use column name for empty file
Bug
the hive orc writer create the output file lazily if there be no row the close method create a file without any column new hive version create a zero byte file this cause issue for hive orc use column name we should fix the column handle code to account for these empty file additionally fo...
prestodbpresto
need a way to produce empty approx set
Enhancement
approx set currently produce null if there be no input value arguably this be wrong but it s consistent with the behavior of sum avg etc although not with count we need a way to represent empty approx set a couple of alternative change approx set to return an empty set if there s no in...
prestodbpresto
add float type
Enhancement
similar to and there should be native support for float as well
prestodbpresto
support intersect
Enhancement
java sql sqlexception query fail 20160329 122015 00073 tc92r line 410 11 intersect not yet implement at com facebook presto jdbc prestoresultset resultsexception prestoresultset java 1824 at com facebook presto jdbc prestoresultset getcolumn prestoresultset java 1773 at com facebook pres...
prestodbpresto
non deterministic test failure in testraptordistributedquerie testcreatebucketedtable
Bug
this test seem to fail about 1 in 5000 run java lang assertionerror not equal actual 1 row 75 expect 1 row 100 at org testng assert fail assert java 94 at com facebook presto test queryassertion assertequalsignoreorder queryassertion java 132 at com facebook presto test query...
prestodbpresto
support a pluggable authentication mechanism
Enhancement
to support authenticate user against different system it would be nice if presto could support a pluggable authentication mechanism a use case where this can be useful be to have iam role support for s3 access see 2640 a custom s3 authentication module will then authenticate the user use his her iam role and p...
prestodbpresto
print server version before verifier run
Enhancement
have the server version from system runtime nod readily available can help troubleshoot error during verifier run
prestodbpresto
can not insert null into table without explicit cast
Bug
sql create table test a bigint insert into test a value null query 20160331 004854 02765 vpwmu fail insert query have mismatch column type table bigint query unknown com facebook presto sql analyzer semanticexception insert query have mismatch column type table bigint ...
prestodbpresto
support except
Enhancement
sql value 1 except value 2 com facebook presto sql analyzer semanticexception line 1 12 except not yet implement at com facebook presto sql analyzer statementanalyzer visitexcept statementanalyzer java 1098 at com facebook presto sql analyzer statementanalyzer visitexcept statemen...
prestodbpresto
error during analysis in group by query with at timezone
Bug
sql select min x at time zone america chicago from value now t x java lang unsupportedoperationexception aggregation analysis not yet implement for com facebook presto sql tree attimezone at com facebook presto sql analyzer aggregationanalyzer visitor visitexpression aggregationana...
prestodbpresto
try cast fail with multiple predicate in a where clause
Bug
when I run the follow query sql with example as select i d other i d from value 1 23452 3 2354 as t i d other i d select try cast other i d as bigint as other i d from example where i d 1 and try cast other i d a...