repository
stringclasses
156 values
issue title
stringlengths
1
1.01k
labels
stringclasses
8 values
body
stringlengths
1
270k
prestodbpresto
add support for a distinct from operator
Enhancement
this be need to support all operation that rely on distinct semantic currently many of they be implement use equal operator or just don t allow use in those context e g array contain null this be a prerequisite for
prestodbpresto
interleavedblock getregion do not update sizeinbyte
Bug
when transport page between machine pagesplitterutil break page up into small unit to reduce buffer requirement the logic be pretty simple repeatably split into two page use getregion util the page be small than a limit this do not work with the new interleavedblock code because getregion do not return a block with an update sizeinbyte the mean that if we encounter a page with a large interleavedblock we move the datum one row at a time
prestodbpresto
datum spill in join
Enhancement
we start to work on datum spill in join currently it be mostly conceptual work not much code yet before we start any serious code we would like to hear you opinion about our idea of how we think it should be do here be a design doc if you notice any problem our code misunderstanding performance or correctness issue please comment there our idea be to arrange short meeting once you review above document to discuss that design unless everything be obvious and clear then we will just start to code cc pnowojski losipiuk martint dain erichwang cberner feel free to invite other if I miss someone with context
prestodbpresto
large negative timestamp produce invalid result
Bug
presto select from unixtime pow 2 54 query 20160818 221137 21727 4xh5v fail unable to create class com facebook presto execution taskinfo from json response io airlift jaxrs jsonmapperparsingexception invalid json for java type com facebook presto server taskupdaterequ at io airlift jaxrs jsonmapper readfrom jsonmapper java 162 at org glassfish jersey message internal readerinterceptorexecutor terminalreaderinterceptor invokereadfrom readerinterceptorexecutor java 256 at org glassfish jersey message internal readerinterceptorexecutor terminalreaderinterceptor aroundreadfrom readerinterceptorexecutor java 235 at org glassfish jersey message internal readerinterceptorexecutor proceed readerinterceptorexecutor java 155 at org glassfish jersey server internal mappableexceptionwrapperinterceptor aroundreadfrom mappableexceptionwrapperinterceptor java 74 at org glassfish jersey message internal readerinterceptorexecutor proceed readerinterceptorexecutor java 155 at org glassfish jersey message internal messagebodyfactory readfrom messagebodyfactory java 1085 at org glassfish jersey message internal inboundmessagecontext readentity inboundmessagecontext java 874 at org glassfish jersey server containerrequ readentity containerrequest java 271 at org glassfish jersey server internal inject entityparamvaluefactoryprovider entityvaluefactory provide entityparamvaluefactoryprovider java 96 at org glassfish jersey server spi internal paramvaluefactorywithsource provide paramvaluefactorywithsource java 71 at org glassfish jersey server spi internal parametervaluehelper getparametervalue parametervaluehelper java 94 at org glassfish jersey server model internal javaresourcemethoddispatcherprovider abstractmethodparaminvoker getparamvalue javaresourcemethoddispatcherprovider java 127 at org glassfish jersey server model internal javaresourcemethoddispatcherprovider responseoutinvoker dodispatch javaresourcemethoddispatcherprovider java 160 at org glassfish jersey server model internal abstractjavaresourcemethoddispatcher dispatch abstractjavaresourcemethoddispatcher java 99 at org glassfish jersey server model resourcemethodinvoker invoke resourcemethodinvoker java 389 at org glassfish jersey server model resourcemethodinvoker apply resourcemethodinvoker java 347 at org glassfish jersey server model resourcemethodinvoker apply resourcemethodinvoker java 102 at org glassfish jersey server serverruntime 2 run serverruntime java 326 at org glassfish jersey internal error 1 call error java 271 at org glassfish jersey internal error 1 call error java 267 at org glassfish jersey internal error process error java 315 at org glassfish jersey internal error process error java 297 at org glassfish jersey internal error process error java 267 at org glassfish jersey process internal requestscope runinscope requestscope java 317 at org glassfish jersey server serverruntime process serverruntime java 305 at org glassfish jersey server applicationhandler handle applicationhandler java 1154 at org glassfish jersey servlet webcomponent serviceimpl webcomponent java 473 at org glassfish jersey servlet webcomponent service webcomponent java 427 at org glassfish jersey servlet servletcontainer service servletcontainer java 388 at org glassfish jersey servlet servletcontainer service servletcontainer java 341 at org glassfish jersey servlet servletcontainer service servletcontainer java 228 at org eclipse jetty servlet servletholder handle servletholder java 845 at org eclipse jetty servlet servlethandler cachedchain dofilter servlethandler java 1689 at io airlift http server tracetokenfilter dofilter tracetokenfilter java 63 at org eclipse jetty servlet servlethandler cachedchain dofilter servlethandler java 1676 at io airlift http server timingfilter dofilter timingfilter java 52 at org eclipse jetty servlet servlethandler cachedchain dofilter servlethandler java 1676 at org eclipse jetty servlet servlethandler dohandle servlethandler java 581 at org eclipse jetty server handler scopedhandler handle scopedhandler java 143 at org eclipse jetty server handler gzip gziphandler handle gziphandler java 399 at org eclipse jetty server handler contexthandler dohandle contexthandler java 1162 at org eclipse jetty servlet servlethandler doscope servlethandler java 511 at org eclipse jetty server handler contexthandler doscope contexthandler java 1092 at org eclipse jetty server handler scopedhandler handle scopedhandler java 141 at org eclipse jetty server handler handlercollection handle handlercollection java 119 at org eclipse jetty server handler statisticshandler handle statisticshandler java 169 at org eclipse jetty server handler handlerlist handle handlerlist java 52 at org eclipse jetty server handler handlerwrapper handle handlerwrapper java 134 at org eclipse jetty server server handle server java 518 at org eclipse jetty server httpchannel handle httpchannel java 308 at org eclipse jetty server httpconnection onfillable httpconnection java 244 at org eclipse jetty io abstractconnection readcallback succeed abstractconnection java 273 at org eclipse jetty io fillinterest fillable fillinterest java 95 at org eclipse jetty io selectchannelendpoint 2 run selectchannelendpoint java 93 at org eclipse jetty util thread queuedthreadpool runjob queuedthreadpool java 654 at org eclipse jetty util thread queuedthreadpool 3 run queuedthreadpool java 572 at java lang thread run thread java 745 cause by com fasterxml jackson databind jsonmappingexception line 1 1 invalid numeric literal 9223372036854775808 through reference chain java util linkedhashmap from unixtime at com fasterxml jackson databind jsonmappingexception wrapwithpath jsonmappingexception java 210 at com fasterxml jackson databind jsonmappingexception wrapwithpath jsonmappingexception java 177 at com fasterxml jackson databind deser std mapdeserializer wrapandthrow mapdeserializer java 566 at com fasterxml jackson databind deser std mapdeserializer readandbind mapdeserializer java 420 at com fasterxml jackson databind deser std mapdeserializer deserialize mapdeserializer java 323 at com fasterxml jackson databind deser std mapdeserializer deserialize mapdeserializer java 26 at com fasterxml jackson databind deser settablebeanproperty deserialize settablebeanproperty java 538 at com fasterxml jackson databind deser beandeserializer deserializeusingpropertybase beandeserializer java 344 at com fasterxml jackson databind deser beandeserializerbase deserializefromobjectusingnondefault beandeserializerbase java 1064 at com fasterxml jackson databind deser beandeserializer deserializefromobject beandeserializer java 264 at com fasterxml jackson databind deser beandeserializer deserializeother beandeserializer java 156 at com fasterxml jackson databind deser beandeserializer deserialize beandeserializer java 126 at com fasterxml jackson databind jsontype impl aspropertytypedeserializer deserializetypedforid aspropertytypedeserializer java 113 at com fasterxml jackson databind jsontype impl aspropertytypedeserializer deserializetypedfromobject aspropertytypedeserializer java 84 at com fasterxml jackson databind deser abstractdeserializer deserializewithtype abstractdeserializer java 132 at com fasterxml jackson databind deser settablebeanproperty deserialize settablebeanproperty java 536 at com fasterxml jackson databind deser beandeserializer deserializeusingpropertybase beandeserializer java 344 at com fasterxml jackson databind deser beandeserializerbase deserializefromobjectusingnondefault beandeserializerbase java 1064 at com fasterxml jackson databind deser beandeserializer deserializefromobject beandeserializer java 264 at com fasterxml jackson databind deser beandeserializer deserializeother beandeserializer java 156 at com fasterxml jackson databind deser beandeserializer deserialize beandeserializer java 126 at com fasterxml jackson databind jsontype impl aspropertytypedeserializer deserializetypedforid aspropertytypedeserializer java 113 at com fasterxml jackson databind jsontype impl aspropertytypedeserializer deserializetypedfromobject aspropertytypedeserializer java 84 at com fasterxml jackson databind deser abstractdeserializer deserializewithtype abstractdeserializer java 132 at com fasterxml jackson databind deser settablebeanproperty deserialize settablebeanproperty java 536 at com fasterxml jackson databind deser beandeserializer deserializeusingpropertybase beandeserializer java 344 at com fasterxml jackson databind deser beandeserializerbase deserializefromobjectusingnondefault beandeserializerbase java 1064 at com fasterxml jackson databind deser beandeserializer deserializefromobject beandeserializer java 264 at com fasterxml jackson databind deser beandeserializer deserialize beandeserializer java 124 at com fasterxml jackson datatype jdk8 optionaldeserializer deserialize optionaldeserializer java 98 at com fasterxml jackson datatype jdk8 optionaldeserializer deserialize optionaldeserializer java 18 at com fasterxml jackson databind deser settablebeanproperty deserialize settablebeanproperty java 538 at com fasterxml jackson databind deser beandeserializer deserializeusingpropertybase beandeserializer java 344 at com fasterxml jackson databind deser beandeserializerbase deserializefromobjectusingnondefault beandeserializerbase java 1064 at com fasterxml jackson databind deser beandeserializer deserializefromobject beandeserializer java 264 at com fasterxml jackson databind deser beandeserializer deserialize beandeserializer java 124 at com fasterxml jackson databind objectmapper readvalue objectmapper java 3038 at com fasterxml jackson databind objectmapper readvalue objectmapper java 1691 at io airlift jaxrs jsonmapper readfrom jsonmapper java 149 57 more cause by com facebook presto sql parser parsingexception line 1 1 invalid numeric literal 9223372036854775808 at com facebook presto sql tree longliteral longliteral java 45 at com facebook presto sql tree longliteral longliteral java 34 at com facebook presto sql parser astbuilder visitintegerliteral astbuilder java 1217 at com facebook presto sql parser astbuilder visitintegerliteral astbuilder java 151 at com facebook presto sql parser sqlbaseparser integerliteralcontext accept sqlbasepars java 9353 at org antlr v4 runtime tree abstractparsetreevisitor visitchildren abstractparsetreevisitor java 70 at com facebook presto sql parser sqlbasebasevisitor visitnumericliteral sqlbasebasevisitor java 762 at com facebook presto sql parser sqlbaseparser numericliteralcontext accept sqlbasepars java 6415 at org antlr v4 runtime tree abstractparsetreevisitor visitchildren abstractparsetreevisitor java 70 at com facebook presto sql parser sqlbasebasevisitor visitvalueexpressiondefault sqlbasebasevisitor java 573 at com facebook presto sql parser sqlbaseparser valueexpressiondefaultcontext accept sqlbasepars java 5532 at org antlr v4 runtime tree abstractparsetreevisitor visit abstractparsetreevisitor java 42 at com facebook presto sql parser astbuilder visitarithmeticunary astbuilder java 883 at com facebook presto sql parser astbuilder visitarithmeticunary astbuilder java 151 at com facebook presto sql parser sqlbaseparser arithmeticunarycontext accept sqlbasepars java 5609 at org antlr v4 runtime tree abstractparsetreevisitor visit abstractparsetreevisitor java 42 at com facebook presto sql parser astbuilder visitpredicate astbuilder java 768 at com facebook presto sql parser astbuilder visitpredicate astbuilder java 151 at com facebook presto sql parser sqlbaseparser predicatedcontext accept sqlbasepars java 5103 at org antlr v4 runtime tree abstractparsetreevisitor visitchildren abstractparsetreevisitor java 70 at com facebook presto sql parser sqlbasebasevisitor visitbooleandefault sqlbasebasevisitor java 496 at com facebook presto sql parser sqlbaseparser booleandefaultcontext accept sqlbasepars java 4809 at org antlr v4 runtime tree abstractparsetreevisitor visitchildren abstractparsetreevisitor java 70 at com facebook presto sql parser sqlbasebasevisitor visitexpression sqlbasebasevisitor java 482 at com facebook presto sql parser sqlbaseparser expressioncontext accept sqlbasepars java 4737 at org antlr v4 runtime tree abstractparsetreevisitor visit abstractparsetreevisitor java 42 at java util stream referencepipeline 3 1 accept referencepipeline java 193 at java util arraylist arraylistspliterator foreachremaine arraylist java 1374 at java util stream abstractpipeline copyinto abstractpipeline java 481 at java util stream abstractpipeline wrapandcopyinto abstractpipeline java 471 at java util stream reduceop reduceop evaluatesequential reduceop java 708 at java util stream abstractpipeline evaluate abstractpipeline java 234 at java util stream referencepipeline collect referencepipeline java 499 at com facebook presto sql parser astbuilder visit astbuilder java 1296 at com facebook presto sql parser astbuilder visitfunctioncall astbuilder java 1104 at com facebook presto sql parser astbuilder visitfunctioncall astbuilder java 151 at com facebook presto sql parser sqlbaseparser functioncallcontext accept sqlbasepars java 6301 at org antlr v4 runtime tree abstractparsetreevisitor visitchildren abstractparsetreevisitor java 70 at com facebook presto sql parser sqlbasebasevisitor visitvalueexpressiondefault sqlbasebasevisitor java 573 at com facebook presto sql parser sqlbaseparser valueexpressiondefaultcontext accept sqlbasepars java 5532 at org antlr v4 runtime tree abstractparsetreevisitor visit abstractparsetreevisitor java 42 at com facebook presto sql parser astbuilder visitpredicate astbuilder java 768 at com facebook presto sql parser astbuilder visitpredicate astbuilder java 151 at com facebook presto sql parser sqlbaseparser predicatedcontext accept sqlbasepars java 5103 at org antlr v4 runtime tree abstractparsetreevisitor visitchildren abstractparsetreevisitor java 70 at com facebook presto sql parser sqlbasebasevisitor visitbooleandefault sqlbasebasevisitor java 496 at com facebook presto sql parser sqlbaseparser booleandefaultcontext accept sqlbasepars java 4809 at org antlr v4 runtime tree abstractparsetreevisitor visitchildren abstractparsetreevisitor java 70 at com facebook presto sql parser sqlbasebasevisitor visitexpression sqlbasebasevisitor java 482 at com facebook presto sql parser sqlbaseparser expressioncontext accept sqlbasepars java 4737 at org antlr v4 runtime tree abstractparsetreevisitor visit abstractparsetreevisitor java 42 at com facebook presto sql parser astbuilder visitsingleexpression astbuilder java 163 at com facebook presto sql parser astbuilder visitsingleexpression astbuilder java 151 at com facebook presto sql parser sqlbaseparser singleexpressioncontext accept sqlbasepars java 258 at org antlr v4 runtime tree abstractparsetreevisitor visit abstractparsetreevisitor java 42 at com facebook presto sql parser sqlparser invokeparser sqlparser java 103 at com facebook presto sql parser sqlparser createexpression sqlparser java 70 at com facebook presto sql serialization expressiondeserializer deserialize serialization java 60 at com facebook presto sql serialization expressiondeserializer deserialize serialization java 45 at com fasterxml jackson databind deser std mapdeserializer readandbind mapdeserializer java 404 92 more java lang illegalargumentexception unable to create class com facebook presto execution taskinfo from json response io airlift jaxrs jsonmapperparsingexception invalid json for java type com facebook presto server taskupdaterequ at io airlift jaxrs jsonmapper readfrom jsonmapper java 162 at org glassfish jersey message internal readerinterceptorexecutor terminalreaderinterceptor invokereadfrom readerinterceptorexecutor java 256 at org glassfish jersey message internal readerinterceptorexecutor terminalreaderinterceptor aroundreadfrom readerinterceptorexecutor java 235 at org glassfish jersey message internal readerinterceptorexecutor proceed readerinterceptorexecutor java 155 at org glassfish jersey server internal mappableexceptionwrapperinterceptor aroundreadfrom mappableexceptionwrapperinterceptor java 74 at org glassfish jersey message internal readerinterceptorexecutor proceed readerinterceptorexecutor java 155 at org glassfish jersey message internal messagebodyfactory readfrom messagebodyfactory java 1085 at org glassfish jersey message internal inboundmessagecontext readentity inboundmessagecontext java 874 at org glassfish jersey server containerrequ readentity containerrequest java 271 at org glassfish jersey server internal inject entityparamvaluefactoryprovider entityvaluefactory provide entityparamvaluefactoryprovider java 96 at org glassfish jersey server spi internal paramvaluefactorywithsource provide paramvaluefactorywithsource java 71 at org glassfish jersey server spi internal parametervaluehelper getparametervalue parametervaluehelper java 94 at org glassfish jersey server model internal javaresourcemethoddispatcherprovider abstractmethodparaminvoker getparamvalue javaresourcemethoddispatcherprovider java 127 at org glassfish jersey server model internal javaresourcemethoddispatcherprovider responseoutinvoker dodispatch javaresourcemethoddispatcherprovider java 160 at org glassfish jersey server model internal abstractjavaresourcemethoddispatcher dispatch abstractjavaresourcemethoddispatcher java 99 at org glassfish jersey server model resourcemethodinvoker invoke resourcemethodinvoker java 389 at org glassfish jersey server model resourcemethodinvoker apply resourcemethodinvoker java 347 at org glassfish jersey server model resourcemethodinvoker apply resourcemethodinvoker java 102 at org glassfish jersey server serverruntime 2 run serverruntime java 326 at org glassfish jersey internal error 1 call error java 271 at org glassfish jersey internal error 1 call error java 267 at org glassfish jersey internal error process error java 315 at org glassfish jersey internal error process error java 297 at org glassfish jersey internal error process error java 267 at org glassfish jersey process internal requestscope runinscope requestscope java 317 at org glassfish jersey server serverruntime process serverruntime java 305 at org glassfish jersey server applicationhandler handle applicationhandler java 1154 at org glassfish jersey servlet webcomponent serviceimpl webcomponent java 473 at org glassfish jersey servlet webcomponent service webcomponent java 427 at org glassfish jersey servlet servletcontainer service servletcontainer java 388 at org glassfish jersey servlet servletcontainer service servletcontainer java 341 at org glassfish jersey servlet servletcontainer service servletcontainer java 228 at org eclipse jetty servlet servletholder handle servletholder java 845 at org eclipse jetty servlet servlethandler cachedchain dofilter servlethandler java 1689 at io airlift http server tracetokenfilter dofilter tracetokenfilter java 63 at org eclipse jetty servlet servlethandler cachedchain dofilter servlethandler java 1676 at io airlift http server timingfilter dofilter timingfilter java 52 at org eclipse jetty servlet servlethandler cachedchain dofilter servlethandler java 1676 at org eclipse jetty servlet servlethandler dohandle servlethandler java 581 at org eclipse jetty server handler scopedhandler handle scopedhandler java 143 at org eclipse jetty server handler gzip gziphandler handle gziphandler java 399 at org eclipse jetty server handler contexthandler dohandle contexthandler java 1162 at org eclipse jetty servlet servlethandler doscope servlethandler java 511 at org eclipse jetty server handler contexthandler doscope contexthandler java 1092 at org eclipse jetty server handler scopedhandler handle scopedhandler java 141 at org eclipse jetty server handler handlercollection handle handlercollection java 119 at org eclipse jetty server handler statisticshandler handle statisticshandler java 169 at org eclipse jetty server handler handlerlist handle handlerlist java 52 at org eclipse jetty server handler handlerwrapper handle handlerwrapper java 134 at org eclipse jetty server server handle server java 518 at org eclipse jetty server httpchannel handle httpchannel java 308 at org eclipse jetty server httpconnection onfillable httpconnection java 244 at org eclipse jetty io abstractconnection readcallback succeed abstractconnection java 273 at org eclipse jetty io fillinterest fillable fillinterest java 95 at org eclipse jetty io selectchannelendpoint 2 run selectchannelendpoint java 93 at org eclipse jetty util thread queuedthreadpool runjob queuedthreadpool java 654 at org eclipse jetty util thread queuedthreadpool 3 run queuedthreadpool java 572 at java lang thread run thread java 745 cause by com fasterxml jackson databind jsonmappingexception line 1 1 invalid numeric literal 9223372036854775808 through reference chain java util linkedhashmap from unixtime at com fasterxml jackson databind jsonmappingexception wrapwithpath jsonmappingexception java 210 at com fasterxml jackson databind jsonmappingexception wrapwithpath jsonmappingexception java 177 at com fasterxml jackson databind deser std mapdeserializer wrapandthrow mapdeserializer java 566 at com fasterxml jackson databind deser std mapdeserializer readandbind mapdeserializer java 420 at com fasterxml jackson databind deser std mapdeserializer deserialize mapdeserializer java 323 at com fasterxml jackson databind deser std mapdeserializer deserialize mapdeserializer java 26 at com fasterxml jackson databind deser settablebeanproperty deserialize settablebeanproperty java 538 at com fasterxml jackson databind deser beandeserializer deserializeusingpropertybase beandeserializer java 344 at com fasterxml jackson databind deser beandeserializerbase deserializefromobjectusingnondefault beandeserializerbase java 1064 at com fasterxml jackson databind deser beandeserializer deserializefromobject beandeserializer java 264 at com fasterxml jackson databind deser beandeserializer deserializeother beandeserializer java 156 at com fasterxml jackson databind deser beandeserializer deserialize beandeserializer java 126 at com fasterxml jackson databind jsontype impl aspropertytypedeserializer deserializetypedforid aspropertytypedeserializer java 113 at com fasterxml jackson databind jsontype impl aspropertytypedeserializer deserializetypedfromobject aspropertytypedeserializer java 84 at com fasterxml jackson databind deser abstractdeserializer deserializewithtype abstractdeserializer java 132 at com fasterxml jackson databind deser settablebeanproperty deserialize settablebeanproperty java 536 at com fasterxml jackson databind deser beandeserializer deserializeusingpropertybase beandeserializer java 344 at com fasterxml jackson databind deser beandeserializerbase deserializefromobjectusingnondefault beandeserializerbase java 1064 at com fasterxml jackson databind deser beandeserializer deserializefromobject beandeserializer java 264 at com fasterxml jackson databind deser beandeserializer deserializeother beandeserializer java 156 at com fasterxml jackson databind deser beandeserializer deserialize beandeserializer java 126 at com fasterxml jackson databind jsontype impl aspropertytypedeserializer deserializetypedforid aspropertytypedeserializer java 113 at com fasterxml jackson databind jsontype impl aspropertytypedeserializer deserializetypedfromobject aspropertytypedeserializer java 84 at com fasterxml jackson databind deser abstractdeserializer deserializewithtype abstractdeserializer java 132 at com fasterxml jackson databind deser settablebeanproperty deserialize settablebeanproperty java 536 at com fasterxml jackson databind deser beandeserializer deserializeusingpropertybase beandeserializer java 344 at com fasterxml jackson databind deser beandeserializerbase deserializefromobjectusingnondefault beandeserializerbase java 1064 at com fasterxml jackson databind deser beandeserializer deserializefromobject beandeserializer java 264 at com fasterxml jackson databind deser beandeserializer deserialize beandeserializer java 124 at com fasterxml jackson datatype jdk8 optionaldeserializer deserialize optionaldeserializer java 98 at com fasterxml jackson datatype jdk8 optionaldeserializer deserialize optionaldeserializer java 18 at com fasterxml jackson databind deser settablebeanproperty deserialize settablebeanproperty java 538 at com fasterxml jackson databind deser beandeserializer deserializeusingpropertybase beandeserializer java 344 at com fasterxml jackson databind deser beandeserializerbase deserializefromobjectusingnondefault beandeserializerbase java 1064 at com fasterxml jackson databind deser beandeserializer deserializefromobject beandeserializer java 264 at com fasterxml jackson databind deser beandeserializer deserialize beandeserializer java 124 at com fasterxml jackson databind objectmapper readvalue objectmapper java 3038 at com fasterxml jackson databind objectmapper readvalue objectmapper java 1691 at io airlift jaxrs jsonmapper readfrom jsonmapper java 149 57 more cause by com facebook presto sql parser parsingexception line 1 1 invalid numeric literal 9223372036854775808 at com facebook presto sql tree longliteral longliteral java 45 at com facebook presto sql tree longliteral longliteral java 34 at com facebook presto sql parser astbuilder visitintegerliteral astbuilder java 1217 at com facebook presto sql parser astbuilder visitintegerliteral astbuilder java 151 at com facebook presto sql parser sqlbaseparser integerliteralcontext accept sqlbasepars java 9353 at org antlr v4 runtime tree abstractparsetreevisitor visitchildren abstractparsetreevisitor java 70 at com facebook presto sql parser sqlbasebasevisitor visitnumericliteral sqlbasebasevisitor java 762 at com facebook presto sql parser sqlbaseparser numericliteralcontext accept sqlbasepars java 6415 at org antlr v4 runtime tree abstractparsetreevisitor visitchildren abstractparsetreevisitor java 70 at com facebook presto sql parser sqlbasebasevisitor visitvalueexpressiondefault sqlbasebasevisitor java 573 at com facebook presto sql parser sqlbaseparser valueexpressiondefaultcontext accept sqlbasepars java 5532 at org antlr v4 runtime tree abstractparsetreevisitor visit abstractparsetreevisitor java 42 at com facebook presto sql parser astbuilder visitarithmeticunary astbuilder java 883 at com facebook presto sql parser astbuilder visitarithmeticunary astbuilder java 151 at com facebook presto sql parser sqlbaseparser arithmeticunarycontext accept sqlbasepars java 5609 at org antlr v4 runtime tree abstractparsetreevisitor visit abstractparsetreevisitor java 42 at com facebook presto sql parser astbuilder visitpredicate astbuilder java 768 at com facebook presto sql parser astbuilder visitpredicate astbuilder java 151 at com facebook presto sql parser sqlbaseparser predicatedcontext accept sqlbasepars java 5103 at org antlr v4 runtime tree abstractparsetreevisitor visitchildren abstractparsetreevisitor java 70 at com facebook presto sql parser sqlbasebasevisitor visitbooleandefault sqlbasebasevisitor java 496 at com facebook presto sql parser sqlbaseparser booleandefaultcontext accept sqlbasepars java 4809 at org antlr v4 runtime tree abstractparsetreevisitor visitchildren abstractparsetreevisitor java 70 at com facebook presto sql parser sqlbasebasevisitor visitexpression sqlbasebasevisitor java 482 at com facebook presto sql parser sqlbaseparser expressioncontext accept sqlbasepars java 4737 at org antlr v4 runtime tree abstractparsetreevisitor visit abstractparsetreevisitor java 42 at java util stream referencepipeline 3 1 accept referencepipeline java 193 at java util arraylist arraylistspliterator foreachremaine arraylist java 1374 at java util stream abstractpipeline copyinto abstractpipeline java 481 at java util stream abstractpipeline wrapandcopyinto abstractpipeline java 471 at java util stream reduceop reduceop evaluatesequential reduceop java 708 at java util stream abstractpipeline evaluate abstractpipeline java 234 at java util stream referencepipeline collect referencepipeline java 499 at com facebook presto sql parser astbuilder visit astbuilder java 1296 at com facebook presto sql parser astbuilder visitfunctioncall astbuilder java 1104 at com facebook presto sql parser astbuilder visitfunctioncall astbuilder java 151 at com facebook presto sql parser sqlbaseparser functioncallcontext accept sqlbasepars java 6301 at org antlr v4 runtime tree abstractparsetreevisitor visitchildren abstractparsetreevisitor java 70 at com facebook presto sql parser sqlbasebasevisitor visitvalueexpressiondefault sqlbasebasevisitor java 573 at com facebook presto sql parser sqlbaseparser valueexpressiondefaultcontext accept sqlbasepars java 5532 at org antlr v4 runtime tree abstractparsetreevisitor visit abstractparsetreevisitor java 42 at com facebook presto sql parser astbuilder visitpredicate astbuilder java 768 at com facebook presto sql parser astbuilder visitpredicate astbuilder java 151 at com facebook presto sql parser sqlbaseparser predicatedcontext accept sqlbasepars java 5103 at org antlr v4 runtime tree abstractparsetreevisitor visitchildren abstractparsetreevisitor java 70 at com facebook presto sql parser sqlbasebasevisitor visitbooleandefault sqlbasebasevisitor java 496 at com facebook presto sql parser sqlbaseparser booleandefaultcontext accept sqlbasepars java 4809 at org antlr v4 runtime tree abstractparsetreevisitor visitchildren abstractparsetreevisitor java 70 at com facebook presto sql parser sqlbasebasevisitor visitexpression sqlbasebasevisitor java 482 at com facebook presto sql parser sqlbaseparser expressioncontext accept sqlbasepars java 4737 at org antlr v4 runtime tree abstractparsetreevisitor visit abstractparsetreevisitor java 42 at com facebook presto sql parser astbuilder visitsingleexpression astbuilder java 163 at com facebook presto sql parser astbuilder visitsingleexpression astbuilder java 151 at com facebook presto sql parser sqlbaseparser singleexpressioncontext accept sqlbasepars java 258 at org antlr v4 runtime tree abstractparsetreevisitor visit abstractparsetreevisitor java 42 at com facebook presto sql parser sqlparser invokeparser sqlparser java 103 at com facebook presto sql parser sqlparser createexpression sqlparser java 70 at com facebook presto sql serialization expressiondeserializer deserialize serialization java 60 at com facebook presto sql serialization expressiondeserializer deserialize serialization java 45 at com fasterxml jackson databind deser std mapdeserializer readandbind mapdeserializer java 404 92 more at io airlift http client fulljsonresponsehandler jsonresponse fulljsonresponsehandler java 119 at io airlift http client fulljsonresponsehandler handle fulljsonresponsehandler java 66 at io airlift http client fulljsonresponsehandler handle fulljsonresponsehandler java 35 at io airlift http client jetty jettyhttpclient jettyresponsefuture processresponse jettyhttpclient java 797 at io airlift http client jetty jettyhttpclient jettyresponsefuture complete jettyhttpclient java 774 at io airlift http client jetty jettyhttpclient bufferingresponselistener oncomplete jettyhttpclient java 1053 at org eclipse jetty client responsenotifi notifycomplete responsenotifi java 193 at org eclipse jetty client responsenotifi notifycomplete responsenotifi java 185 at org eclipse jetty client httpreceiver terminateresponse httpreceiver java 456 at org eclipse jetty client httpreceiver responsesuccess httpreceiver java 403 at org eclipse jetty client http httpreceiveroverhttp messagecomplete httpreceiveroverhttp java 268 at org eclipse jetty http httpparser parsecontent httpparser java 1548 at org eclipse jetty http httpparser parsenext httpparser java 1281 at org eclipse jetty client http httpreceiveroverhttp parse httpreceiveroverhttp java 158 at org eclipse jetty client http httpreceiveroverhttp process httpreceiveroverhttp java 119 at org eclipse jetty client http httpreceiveroverhttp receive httpreceiveroverhttp java 69 at org eclipse jetty client http httpchanneloverhttp receive httpchanneloverhttp java 90 at org eclipse jetty client http httpconnectionoverhttp onfillable httpconnectionoverhttp java 114 at org eclipse jetty io abstractconnection readcallback succeed abstractconnection java 273 at org eclipse jetty io fillinterest fillable fillinterest java 95 at org eclipse jetty io selectchannelendpoint 2 run selectchannelendpoint java 93 at org eclipse jetty util thread queuedthreadpool runjob queuedthreadpool java 654 at org eclipse jetty util thread queuedthreadpool 3 run queuedthreadpool java 572 at java lang thread run thread java 745 cause by java lang illegalargumentexception invalid simple type class com facebook presto execution taskinfo json bytes at io airlift json jsoncodec fromjson jsoncodec java 174 at io airlift http client fulljsonresponsehandler jsonresponse fulljsonresponsehandler java 116 23 more cause by com fasterxml jackson core jsonparseexception unrecognized token io be expect true false or null at source b 53a5ff2e line 1 column 4 at com fasterxml jackson core jsonparser constructerror jsonparser java 1419 at com fasterxml jackson core base parserminimalbase reporterror parserminimalbase java 508 at com fasterxml jackson core json utf8streamjsonparser reportinvalidtoken utf8streamjsonparser java 3201 at com fasterxml jackson core json utf8streamjsonparser handleunexpectedvalue utf8streamjsonparser java 2360 at com fasterxml jackson core json utf8streamjsonparser nexttokennotinobject utf8streamjsonparser java 794 at com fasterxml jackson core json utf8streamjsonparser nexttoken utf8streamjsonparser java 690 at com fasterxml jackson databind objectmapper initforreading objectmapper java 3105 at com fasterxml jackson databind objectmapper readmapandclose objectmapper java 3051 at com fasterxml jackson databind objectmapper readvalue objectmapper java 2262 at io airlift json jsoncodec fromjson jsoncodec java 171 24 more
prestodbpresto
categorize error for joda time arithmeticexception
Bug
presto select hour from unixtime pow 2 54 query 20160818 221052 21696 4xh5v fail add time zone offset cause overflow java lang arithmeticexception add time zone offset cause overflow at org joda time datetimezone convertutctolocal datetimezone java 929 at org joda time chrono zonedchronology zoneddatetimefield get zonedchronology java 422 at com facebook presto operator scalar datetimefunction hourfromtimestamp datetimefunction java 648 at java lang invoke methodhandle invokewithargument methodhandle java 627 at java lang invoke methodhandle invokewithargument methodhandle java 649 at com facebook presto sql planner expressioninterpreter invoke expressioninterpreter java 1093 at com facebook presto sql planner expressioninterpreter visitor visitfunctioncall expressioninterpreter java 826 at com facebook presto sql tree functioncall accept functioncall java 96 at com facebook presto sql tree astvisitor process astvisitor java 22 at com facebook presto sql planner expressioninterpreter optimize expressioninterpreter java 231 at com facebook presto sql planner optimizations simplifyexpression rewriter simplifyexpression simplifyexpression java 153 at com google common collect map 7 transformentry map java 1812 at com google common collect map 10 getvalue map java 1857 at com google common collect immutablemap copyof immutablemap java 292 at com facebook presto sql planner optimization simplifyexpression rewriter visitproject simplifyexpression java 110 at com facebook presto sql planner optimization simplifyexpression rewriter visitproject simplifyexpression java 88 at com facebook presto sql planner plan projectnode accept projectnode java 76 at com facebook presto sql planner plan simpleplanrewriter rewritecontext rewrite simpleplanrewriter java 86 at com facebook presto sql planner plan simpleplanrewriter rewritecontext rewrite simpleplanrewriter java 97 at com facebook presto sql planner optimization simplifyexpression rewriter visitproject simplifyexpression java 109 at com facebook presto sql planner optimization simplifyexpression rewriter visitproject simplifyexpression java 88 at com facebook presto sql planner plan projectnode accept projectnode java 76 at com facebook presto sql planner plan simpleplanrewriter rewritecontext rewrite simpleplanrewriter java 86 at com facebook presto sql planner plan simpleplanrewriter rewritecontext rewrite simpleplanrewriter java 97 at com facebook presto sql planner optimization simplifyexpression rewriter visitproject simplifyexpression java 109 at com facebook presto sql planner optimization simplifyexpression rewriter visitproject simplifyexpression java 88 at com facebook presto sql planner plan projectnode accept projectnode java 76 at com facebook presto sql planner plan simpleplanrewriter rewritecontext rewrite simpleplanrewriter java 86 at com facebook presto sql planner plan simpleplanrewriter rewritecontext rewrite simpleplanrewriter java 97 at com facebook presto sql planner optimization simplifyexpression rewriter visitproject simplifyexpression java 109 at com facebook presto sql planner optimization simplifyexpression rewriter visitproject simplifyexpression java 88 at com facebook presto sql planner plan projectnode accept projectnode java 76 at com facebook presto sql planner plan simpleplanrewriter rewritecontext rewrite simpleplanrewriter java 86 at com facebook presto sql planner plan simpleplanrewriter rewritecontext lambda defaultrewrite 0 simpleplanrewriter java 75 at java util stream referencepipeline 3 1 accept referencepipeline java 193 at java util iterator foreachremaine iterator java 116 at java util spliterators iteratorspliterator foreachremaine spliterator java 1801 at java util stream abstractpipeline copyinto abstractpipeline java 481 at java util stream abstractpipeline wrapandcopyinto abstractpipeline java 471 at java util stream reduceop reduceop evaluatesequential reduceop java 708 at java util stream abstractpipeline evaluate abstractpipeline java 234 at java util stream referencepipeline collect referencepipeline java 499 at com facebook presto sql planner plan simpleplanrewriter rewritecontext defaultrewrite simpleplanrewriter java 76 at com facebook presto sql planner plan simpleplanrewriter visitplan simpleplanrewriter java 40 at com facebook presto sql planner plan simpleplanrewriter visitplan simpleplanrewriter java 24 at com facebook presto sql planner plan planvisitor visitoutput planvisitor java 50 at com facebook presto sql planner plan outputnode accept outputnode java 81 at com facebook presto sql planner plan simpleplanrewriter rewritewith simpleplanrewriter java 29 at com facebook presto sql planner optimization simplifyexpression optimize simplifyexpression java 85 at com facebook presto sql planner logicalplanner plan logicalplanner java 100 at com facebook presto execution sqlqueryexecution doanalyzequery sqlqueryexecution java 277 at com facebook presto execution sqlqueryexecution analyzequery sqlqueryexecution java 256 at com facebook presto execution sqlqueryexecution start sqlqueryexecution java 220 at com facebook presto execution queuedexecution lambda start 1 queuedexecution java 68 at java util concurrent threadpoolexecutor runworker threadpoolexecutor java 1142 at java util concurrent threadpoolexecutor worker run threadpoolexecutor java 617 at java lang thread run thread java 745
prestodbpresto
initial support for lateral join
Enhancement
lateral join be join in which sub select and expression on the right side of lateral keyword can use the scope of the join on the left side of lateral keyword e g trivial sql select from foo lateral select from bar where bar i d foo bar i d ss which be equivalent to sql select from foo bar where bar i d foo bar i d see postgresql doc query lateral a less trivial example would be sql select month signup visitor p as avg low high from signup by month lateral select signup visitor as p probability lateral select sqrt p 1 p visitor as se std error lateral select p 1 94 se as low lower bind lateral select p 1 94 se as high upper bind source reuse calculation in the same query with lateral join and a truly non trivial one would be sql select r name I inspect at I score count v i d violation from restaurant r leave outer join lateral select from inspection i2 where i2 restaurant i d r i d order by i2 inspect at desc limit 1 I on true left outer join violation v on v inspection i d I i d group by r name I inspect at I score source postgre lateral join plan of attack assume development base on 5824 1 introduce lateral keyword in syntax make join have a islateral property 2 make rhs of lateral join have its scope extend the scope of join s lhs similar to how unn be implement now 3 make the planner emit applynode s for lateral inner join s remember to add proper correlation in the applynode s 4 rewrite applynode s with a projection filter on rhs to inner join the filter condition become the join condition 5 at this point the trivial and less trivial example should work 6 handle leave outer lateral join introduce a emptyresulttonullrow node return single null row for empty relation make the planner emit applynode s with a emptyresulttonullrow as right child for lateral leave outer joinnode s rewrite the above applynode s with left outer join the above rewrite would additionally provide support for a class of non scalar correlate subquerie which be a nice follow up for 5824 the truly non trivial example would have to be investigate on if and how it could be rewrite and be out of scope of the initial lateral support it might turn out that the only reasonable way to implement it would be by implement the iterative approach head h rbfxpcmaul7a for direct execution of applynode s note that right lateral join be well define only when they re not correlate the rhs do not refer to lhs a right lateral join with a correlation should result in an error message postgre select from t1 right join lateral select from t2 where x y ss on true error invalid reference to from clause entry for table t1 line 1 rom t1 right join lateral select from t2 where x y ss detail the combine join type must be inner or leave for a lateral reference
prestodbpresto
allow well pushdown for or predicate
Enhancement
currently or predicate be only available for pushdown for connector in spi if they be on the same column
prestodbpresto
mongodb collection name contain dot raise invalid schematablename error
Bug
hi my mongodb collection name contain dot desc table be ok select from will raise a invalid schematablename error presto desc mgo actionlog activity get coupon column type comment account varchar telephone varchar ch i d varchar activity varchar time timestamp 5 row query 20160815 104043 06592 7mxj2 finish 1 node split 2 total 2 do 100 00 0 00 5 row 380b 15 row s 1 11 kb s backtrace detail presto select from mgo actionlog activity get coupon limit 10 query 20160815 104226 06595 7mxj2 fail 2 node split 1 total 0 do 0 00 0 00 0 row 0b 0 rows s 0b s query 20160815 104226 06595 7mxj2 fail unable to create class com facebook presto execution taskinfo from json response io airlift jaxrs jsonmapperparsingexception invalid json for java type com facebook presto server taskupdaterequ at io airlift jaxrs jsonmapper readfrom jsonmapper java 162 at org glassfish jersey message internal readerinterceptorexecutor terminalreaderinterceptor invokereadfrom readerinterceptorexecutor java 256 at org glassfish jersey message internal readerinterceptorexecutor terminalreaderinterceptor aroundreadfrom readerinterceptorexecutor java 235 at org glassfish jersey message internal readerinterceptorexecutor proceed readerinterceptorexecutor java 155 at org glassfish jersey server internal mappableexceptionwrapperinterceptor aroundreadfrom mappableexceptionwrapperinterceptor java 74 at org glassfish jersey message internal readerinterceptorexecutor proceed readerinterceptorexecutor java 155 at org glassfish jersey message internal messagebodyfactory readfrom messagebodyfactory java 1085 at org glassfish jersey message internal inboundmessagecontext readentity inboundmessagecontext java 874 at org glassfish jersey server containerrequ readentity containerrequest java 271 at org glassfish jersey server internal inject entityparamvaluefactoryprovider entityvaluefactory provide entityparamvaluefactoryprovider java 96 at org glassfish jersey server spi internal paramvaluefactorywithsource provide paramvaluefactorywithsource java 71 at org glassfish jersey server spi internal parametervaluehelper getparametervalue parametervaluehelper java 94 at org glassfish jersey server model internal javaresourcemethoddispatcherprovider abstractmethodparaminvoker getparamvalue javaresourcemethoddispatcherprovider java 127 at org glassfish jersey server model internal javaresourcemethoddispatcherprovider responseoutinvoker dodispatch javaresourcemethoddispatcherprovider java 160 at org glassfish jersey server model internal abstractjavaresourcemethoddispatcher dispatch abstractjavaresourcemethoddispatcher java 99 at org glassfish jersey server model resourcemethodinvoker invoke resourcemethodinvoker java 389 at org glassfish jersey server model resourcemethodinvoker apply resourcemethodinvoker java 347 at org glassfish jersey server model resourcemethodinvoker apply resourcemethodinvoker java 102 at org glassfish jersey server serverruntime 2 run serverruntime java 326 at org glassfish jersey internal error 1 call error java 271 at org glassfish jersey internal error 1 call error java 267 at org glassfish jersey internal error process error java 315 at org glassfish jersey internal error process error java 297 at org glassfish jersey internal error process error java 267 at org glassfish jersey process internal requestscope runinscope requestscope java 317 at org glassfish jersey server serverruntime process serverruntime java 305 at org glassfish jersey server applicationhandler handle applicationhandler java 1154 at org glassfish jersey servlet webcomponent serviceimpl webcomponent java 473 at org glassfish jersey servlet webcomponent service webcomponent java 427 at org glassfish jersey servlet servletcontainer service servletcontainer java 388 at org glassfish jersey servlet servletcontainer service servletcontainer java 341 at org glassfish jersey servlet servletcontainer service servletcontainer java 228 at org eclipse jetty servlet servletholder handle servletholder java 845 at org eclipse jetty servlet servlethandler cachedchain dofilter servlethandler java 1689 at io airlift http server tracetokenfilter dofilter tracetokenfilter java 63 at org eclipse jetty servlet servlethandler cachedchain dofilter servlethandler java 1676 at io airlift http server timingfilter dofilter timingfilter java 52 at org eclipse jetty servlet servlethandler cachedchain dofilter servlethandler java 1676 at org eclipse jetty servlet servlethandler dohandle servlethandler java 581 at org eclipse jetty server handler scopedhandler handle scopedhandler java 143 at org eclipse jetty server handler gzip gziphandler handle gziphandler java 397 at org eclipse jetty server handler contexthandler dohandle contexthandler java 1182 at org eclipse jetty servlet servlethandler doscope servlethandler java 511 at org eclipse jetty server handler contexthandler doscope contexthandler java 1112 at org eclipse jetty server handler scopedhandler handle scopedhandler java 141 at org eclipse jetty server handler handlercollection handle handlercollection java 119 at org eclipse jetty server handler statisticshandler handle statisticshandler java 169 at org eclipse jetty server handler handlerlist handle handlerlist java 52 at org eclipse jetty server handler handlerwrapper handle handlerwrapper java 134 at org eclipse jetty server server handle server java 524 at org eclipse jetty server httpchannel handle httpchannel java 319 at org eclipse jetty server httpconnection onfillable httpconnection java 253 at org eclipse jetty io abstractconnection readcallback succeed abstractconnection java 273 at org eclipse jetty io fillinterest fillable fillinterest java 95 at org eclipse jetty io selectchannelendpoint 2 run selectchannelendpoint java 93 at org eclipse jetty util thread strategy executeproduceconsume executeproduceconsume executeproduceconsume java 303 at org eclipse jetty util thread strategy executeproduceconsume produceconsume executeproduceconsume java 148 at org eclipse jetty util thread strategy executeproduceconsume run executeproduceconsume java 136 at org eclipse jetty util thread queuedthreadpool runjob queuedthreadpool java 671 at org eclipse jetty util thread queuedthreadpool 2 run queuedthreadpool java 589 at java lang thread run thread java 745 cause by com fasterxml jackson databind jsonmappingexception instantiation of simple type class com facebook presto spi schematablename value fail invalid schematablename actionlog activity get coupon at com fasterxml jackson databind deser std stdvalueinstantiator wrapexception stdvalueinstantiator java 405 at com fasterxml jackson databind deser std stdvalueinstantiator createfromstre stdvalueinstantiator java 284 at com fasterxml jackson databind deser beandeserializerbase deserializefromstre beandeserializerbase java 1141 at com fasterxml jackson databind deser beandeserializer deserializeother beandeserializer java 135 at com fasterxml jackson databind deser beandeserializer deserialize beandeserializer java 126 at com fasterxml jackson databind deser settablebeanproperty deserialize settablebeanproperty java 538 at com fasterxml jackson databind deser beandeserializer deserializeusingpropertybase beandeserializer java 344 at com fasterxml jackson databind deser beandeserializerbase deserializefromobjectusingnondefault beandeserializerbase java 1064 at com fasterxml jackson databind deser beandeserializer deserializefromobject beandeserializer java 264 at com fasterxml jackson databind deser beandeserializer deserializeother beandeserializer java 156 at com fasterxml jackson databind deser beandeserializer deserialize beandeserializer java 126 at com fasterxml jackson databind jsontype impl aspropertytypedeserializer deserializetypedforid aspropertytypedeserializer java 113 at com fasterxml jackson databind jsontype impl aspropertytypedeserializer deserializetypedfromobject aspropertytypedeserializer java 84 at com fasterxml jackson databind jsontype impl aspropertytypedeserializer deserializetypedfromany aspropertytypedeserializer java 156 at com facebook presto metadata abstracttypedjacksonmodule internaltypedeserializer deserialize abstracttypedjacksonmodule java 82 at com fasterxml jackson databind deser settablebeanproperty deserialize settablebeanproperty java 538 at com fasterxml jackson databind deser beandeserializer deserializeusingpropertybase beandeserializer java 344 at com fasterxml jackson databind deser beandeserializerbase deserializefromobjectusingnondefault beandeserializerbase java 1064 at com fasterxml jackson databind deser beandeserializer deserializefromobject beandeserializer java 264 at com fasterxml jackson databind deser beandeserializer deserialize beandeserializer java 124 at com fasterxml jackson databind deser settablebeanproperty deserialize settablebeanproperty java 538 at com fasterxml jackson databind deser beandeserializer deserializeusingpropertybase beandeserializer java 344 at com fasterxml jackson databind deser beandeserializerbase deserializefromobjectusingnondefault beandeserializerbase java 1064 at com fasterxml jackson databind deser beandeserializer deserializefromobject beandeserializer java 264 at com fasterxml jackson databind deser beandeserializer deserializeother beandeserializer java 156 at com fasterxml jackson databind deser beandeserializer deserialize beandeserializer java 126 at com fasterxml jackson databind jsontype impl aspropertytypedeserializer deserializetypedforid aspropertytypedeserializer java 113 at com fasterxml jackson databind jsontype impl aspropertytypedeserializer deserializetypedfromobject aspropertytypedeserializer java 84 at com fasterxml jackson databind deser abstractdeserializer deserializewithtype abstractdeserializer java 132 at com fasterxml jackson databind deser settablebeanproperty deserialize settablebeanproperty java 536 at com fasterxml jackson databind deser beandeserializer deserializeusingpropertybase beandeserializer java 344 at com fasterxml jackson databind deser beandeserializerbase deserializefromobjectusingnondefault beandeserializerbase java 1064 at com fasterxml jackson databind deser beandeserializer deserializefromobject beandeserializer java 264 at com fasterxml jackson databind deser beandeserializer deserializeother beandeserializer java 156 at com fasterxml jackson databind deser beandeserializer deserialize beandeserializer java 126 at com fasterxml jackson databind jsontype impl aspropertytypedeserializer deserializetypedforid aspropertytypedeserializer java 113 at com fasterxml jackson databind jsontype impl aspropertytypedeserializer deserializetypedfromobject aspropertytypedeserializer java 84 at com fasterxml jackson databind deser abstractdeserializer deserializewithtype abstractdeserializer java 132 at com fasterxml jackson databind deser settablebeanproperty deserialize settablebeanproperty java 536 at com fasterxml jackson databind deser beandeserializer deserializeusingpropertybase beandeserializer java 344 at com fasterxml jackson databind deser beandeserializerbase deserializefromobjectusingnondefault beandeserializerbase java 1064 at com fasterxml jackson databind deser beandeserializer deserializefromobject beandeserializer java 264 at com fasterxml jackson databind deser beandeserializer deserialize beandeserializer java 124 at com fasterxml jackson datatype jdk8 optionaldeserializer deserialize optionaldeserializer java 98 at com fasterxml jackson datatype jdk8 optionaldeserializer deserialize optionaldeserializer java 18 at com fasterxml jackson databind deser settablebeanproperty deserialize settablebeanproperty java 538 at com fasterxml jackson databind deser beandeserializer deserializeusingpropertybase beandeserializer java 344 at com fasterxml jackson databind deser beandeserializerbase deserializefromobjectusingnondefault beandeserializerbase java 1064 at com fasterxml jackson databind deser beandeserializer deserializefromobject beandeserializer java 264 at com fasterxml jackson databind deser beandeserializer deserialize beandeserializer java 124 at com fasterxml jackson databind objectmapper readvalue objectmapper java 3038 at com fasterxml jackson databind objectmapper readvalue objectmapper java 1691 at io airlift jaxrs jsonmapper readfrom jsonmapper java 149 60 more cause by java lang illegalargumentexception invalid schematablename actionlog activity get coupon at com facebook presto spi schematablename valueof schematablename java 35 at sun reflect generatedmethodaccessor301 invoke unknown source at sun reflect delegatingmethodaccessorimpl invoke delegatingmethodaccessorimpl java 43 at java lang reflect method invoke method java 498 at com fasterxml jackson databind introspect annotatedmethod call1 annotatedmethod java 125 at com fasterxml jackson databind deser std stdvalueinstantiator createfromstre stdvalueinstantiator java 282 111 more
prestodbpresto
support pattern match via match recognize
Enhancement
pattern matching allow a number of use case that be difficult or impossible to do otherwise this be specify in sql 2016 as match recognize in 4 17 row pattern match oracle have have an implementation of this for a while and very likely match the standard 1 2 3 1 2 3
prestodbpresto
use revocable memory in spillable hashaggregationoperator
Enhancement
as part of this pr please review only three last commit 1 add setrevocablememoryreservation method 2 use revocable memory for spill in aggregation 3 add query max revocable memory per node property this pull request require both and
prestodbpresto
fix hive sql standard permission on table creation
Bug
when create a hive table all privilege be translate to select insert update delete privilege when presto create a hive table it set the privilege to all rather than grant the underlie privilege this be handle incorrectly when query for authorization explode the all privilege to its constituent solve the issue example current presto hive show grant user spyne on table customer cta old ok default customer cta spyne user all true 1470714881000 spyne time take 0 587 second fetch 1 row s presto with patch hive show grant user spyne on table customer cta ok default customer cta spyne user delete true 1470712777000 spyne default customer cta spyne user insert true 1470712777000 spyne default customer cta spyne user select true 1470712777000 spyne default customer cta spyne user update true 1470712777000 spyne time take 0 574 second fetch 4 row s
prestodbpresto
fix for non power of two task writer count conflict with hash partitioning
Bug
poc fix for
prestodbpresto
set task writer count to non power of two can cause partitioncount must be a power of 2
Bug
this might happen when there be union and table writer in one pipeline set session redistribute write false set session task writer count 24 create table blackhole default test as select from tpch sf1 nation union select from tpch sf1 nation
prestodbpresto
spill to disk for aggregation v2
Enhancement
supersede notable change reorder commit remove max entry before spill property
prestodbpresto
aggregation refactor
Enhancement
I have split previous into this refactor and spiller implementation this refactor doesn t add any functionality so it should be easy to review and merge but just fix some thing require by spiller
prestodbpresto
java lang verifyerror with a query
Bug
below query fail with a java lang verifyerror bad type on operand stack with master build 9db10aa sql select a orderkey from select orderkey from tpch sf100 lineitem limit 100 a join select orderkey from tpch sf100 lineitem limit 100 b on a orderkey
prestodbpresto
aggregation on double column may return nondeterministic result
Bug
let create or replace view revenue as select l suppkey as supplier no sum l extendedprice 1 l discount as total revenue from lineitem where l shipdate date 1996 01 01 and l shipdate date 1996 01 01 interval 3 month group by l suppkey then the below query return 0 or 1 depend on internal query task execution order while 0 be an incorrect result for below query select count from revenue where total revenue select max total revenue from revenue imo it could be acceptable that aggregation on double can have slight result error but non deterministic error for the same query on the same input be unacceptable solve this issue will make tpc h query 15 to pass my intuition tell that different execution order of task for aggregate final and partial may produce different result one way to solve above query be to make presto to populate view only once per query and the redistribute result to all the stage operator which be read that view in that way query should be execute much fast such approach require deep analysis as it be possibility it may lead query to deadlock
prestodbpresto
fix show create table for raptor
Bug
raptormetadata gettablemetadata do not include table property so show create table do not include they we want to make as few database call as possible these be the property we need order could be add to tablecolumn temporal column could be add to tablecolumn bucket count already in raptortablehandle bucket on could be add to tablecolumn distribution name could be add to raptortablehandle along with distributionid seem ugly to put it in the handle but the handle already have the schema table name just for this metadata call
prestodbpresto
integer to decimal cast fail with large scale
Bug
presto select cast 1 as decimal 38 30 col0 0 000000000009223372036854775807 1 row issue be cause by this code static for int I 0 I long power of ten length I long power of ten I round pow 10 I big integer power of ten I ten pow I when pow 10 I exceed long max value cc sopel39
prestodbpresto
raptor connection leak
Bug
when use mysql as backend there be a connection leak 2016 07 28t14 32 56 300z warn hikaripool 1 housekeeper com zaxxer hikari pool proxyleaktask connection leak detection trigger for com mysql jdbc jdbc4connection 7ef9c8a5 stack trace follow java lang exception apparent connection leak detect at org skife jdbi v2 dbi open dbi java 212 at com facebook presto raptor metadata sharditerator sharditerator java 87 at com facebook presto raptor metadata databaseshardmanager getshardnode databaseshardmanager java 460 at com facebook presto raptor raptorsplitmanager raptorsplitsource raptorsplitmanager java 164 at com facebook presto raptor raptorsplitmanager getsplit raptorsplitmanager java 107 at com facebook presto split splitmanager getsplit splitmanager java 45 at com facebook presto sql planner distributedexecutionplanner visitor visittablescan distributedexecutionplanner java 112 at com facebook presto sql planner distributedexecutionplanner visitor visittablescan distributedexecutionplanner java 92 at com facebook presto sql planner plan tablescannode accept tablescannode java 135 at com facebook presto sql planner distributedexecutionplanner visitor visitproject distributedexecutionplanner java 228 at com facebook presto sql planner distributedexecutionplanner visitor visitproject distributedexecutionplanner java 92 at com facebook presto sql planner plan projectnode accept projectnode java 81 at com facebook presto sql planner distributedexecutionplanner plan distributedexecutionplanner java 78 at com facebook presto sql planner distributedexecutionplanner plan distributedexecutionplanner java 83 at com facebook presto sql planner distributedexecutionplanner plan distributedexecutionplanner java 83 at com facebook presto sql planner distributedexecutionplanner plan distributedexecutionplanner java 83 at com facebook presto sql planner distributedexecutionplanner plan distributedexecutionplanner java 83 at com facebook presto sql planner distributedexecutionplanner plan distributedexecutionplanner java 83 at com facebook presto sql planner distributedexecutionplanner plan distributedexecutionplanner java 83 at com facebook presto sql planner distributedexecutionplanner plan distributedexecutionplanner java 83 at com facebook presto execution sqlqueryexecution plandistribution sqlqueryexecution java 303 at com facebook presto execution sqlqueryexecution start sqlqueryexecution java 226 at com facebook presto execution queuedexecution lambda start 1 queuedexecution java 62 at java util concurrent threadpoolexecutor runworker threadpoolexecutor java 1142 at java util concurrent threadpoolexecutor worker run threadpoolexecutor java 617 at java lang thread run thread java 745 I guess that the follow code from sharditerator java should be catch exception not sqlexception try connection dbi open getconnection statement connection preparestatement sql enablestreamingresult statement predicate bind statement log debug run query s statement resultset statement executequery catch sqlexception e close throw metadataerror e
prestodbpresto
postgresql connector error stack depth limit exceed
Bug
the testpostgresqldistributedquerie testlargein test for postgresql connector be fail since 0 149 or eali the error be not catch by the ci build because of testpostgresqldistributedquerie java be exclude in postgresql connector pom which maybe be another issue I be go to disable this test with a link to this issue so that people don t need to re verify this failure again and again how to reproduce git checkout 0 149 the old commit I ve reproduce it for so far mvnw clean install t c1 pl presto doc presto server rpm dskiptest true dair check skip all true dmaven javadoc skip true mvnw clean test pl presto postgresql dtest com facebook presto plugin postgresql testpostgresqldistributedquerie testlargein the relevant part of the output should be test run 1 failure 1 error 0 skip 0 time elapse 34 96 sec failure testlargein com facebook presto plugin postgresql testpostgresqldistributedquerie time elapse 15 478 sec failure com facebook presto client failureinfo failureexception org postgresql util psqlexception error stack depth limit exceed hint increase the configuration parameter max stack depth currently 2048 kb after ensure the platform s stack depth limit be adequate at org postgresql core v3 queryexecutorimpl receiveerrorresponse queryexecutorimpl java 2198 at org postgresql core v3 queryexecutorimpl processresult queryexecutorimpl java 1927 at org postgresql core v3 queryexecutorimpl execute queryexecutorimpl java 255 at org postgresql jdbc2 abstractjdbc2statement execute abstractjdbc2statement java 561 at org postgresql jdbc2 abstractjdbc2statement executewithflag abstractjdbc2statement java 419 at org postgresql jdbc2 abstractjdbc2statement executequery abstractjdbc2statement java 304 at com facebook presto plugin jdbc jdbcrecordcursor jdbcrecordcursor java 74 at com facebook presto plugin jdbc jdbcrecordset cursor jdbcrecordset java 56 at com facebook presto spi recordpagesource recordpagesource java 37 at com facebook presto split recordpagesourceprovider createpagesource recordpagesourceprovider java 42 at com facebook presto split pagesourcemanager createpagesource pagesourcemanager java 48 at com facebook presto operator scanfilterandprojectoperator createsourceifnecessary scanfilterandprojectoperator java 292 at com facebook presto operator scanfilterandprojectoperator isfinishe scanfilterandprojectoperator java 180 at com facebook presto operator driver processinternal driver java 375 at com facebook presto operator driver processfor driver java 301 at com facebook presto execution sqltaskexecution driversplitrunner processfor sqltaskexecution java 618 at com facebook presto execution taskexecutor prioritizedsplitrunner process taskexecutor java 529 at com facebook presto execution taskexecutor runner run taskexecutor java 665 at java util concurrent threadpoolexecutor runworker threadpoolexecutor java 1142 at java util concurrent threadpoolexecutor worker run threadpoolexecutor java 617 at java lang thread run thread java 745 result fail test failure org postgresql util psqlexception error stack depth limit exceede test run 1 failure 1 error 0 skip 0 info info build failure info info total time 46 695 s info finish at 2016 07 26t13 32 05 02 00 info final memory 105 m 941 m info
prestodbpresto
correctly handle error from url decode
Bug
this make the function work with try
prestodbpresto
fix operatorcontext race condition
Bug
address issue first commit fix this issue second be a proposal for the refactor
prestodbpresto
operatorcontext be not threadsafe
Bug
contrary to the misleading threadsafe annotation and usage of atomiclong everywhere in it operatorcontext be not threadsafe I have stumble on it while implement some thing relate to spill and revocable memory there be at least problem with setmemoryreservation trysetmemoryreservation method and transfermemorytotaskcontext private final atomiclong memoryreservation new atomiclong public void setmemoryreservation long newmemoryreservation checkargument newmemoryreservation 0 newmemoryreservation be negative long delta newmemoryreservation memoryreservation get if delta 0 reservememory delta else freememory delta example scenario memoryreservation equal to 10 1 caller a initiate setmemoryreservation 3 2 a thread calculate delta 7 and hang 3 caller b change memory reservation by call setmemoryreservation 3 which finish before a thread resume work this give we memoryreservation 3 4 a thread resume work freememory 7 be execute 5 we end up with memoryreservation 4 which crash query this bug s might haven t show up so far because this class be mostly only use by single driver s thread I m not familiar with this part of code and I don t feel whether synchronization here be costly but I would be inclined to drop all atomiclong here and switch to synchronize method it would be safe and since operatorcontext call should be rare I don t expect it would have negative performance impact cc cberner sopel39
prestodbpresto
fix decimal stat rescale in presto orc tuple domain predicate
Bug
fyi cberner
prestodbpresto
fix handling of failure class without canonical name
Bug
this fix an npe for thing like anonymous class however I m not sure why getcanonicalname be use at all rather than getname dain
prestodbpresto
fix travis non reporting of product and integration test failure
Bug
the error be introduce in 5421 and 5471 sorry about that luckily there be no test failure in master proof that this commit fix the false positive problem
prestodbpresto
varchar n and var args function
Bug
the follow query fail select from select concat t x t z cc from select from value varchar a varchar c t x z t join select from value varchar a varchar c u x z where z c split part b c 2 u on t z u z where cc ac select from select great t x t z cc from select from value varchar a varchar c t x z t join select from value varchar a varchar c u x z where z c split part b c 2 u on t z u z where cc c select from select least t x t z cc from select from value varchar a varchar c t x z t join select from value varchar a varchar c u x z where z c split part b c 2 u on t z u z where cc a select from select array t x t z cc from select from value varchar a varchar c t x z t join select from value varchar a varchar c u x z where z c split part b c 2 u on t z u z where cc array a c stacktrace com facebook presto spi prestoexception array constructor varchar varchar 1 array varchar not find at com facebook presto metadata functionregistry getscalarfunctionimplementation functionregistry java 852 at com facebook presto sql relational optimizer expressionoptimizer visitor visitcall expressionoptimizer java 145 at com facebook presto sql relational optimizer expressionoptimizer visitor visitcall expressionoptimizer java 70 at com facebook presto sql relational callexpression accept callexpression java 88 at com facebook presto sql relational optimizer expressionoptimizer visitor lambda visitcall 3 expressionoptimizer java 150 at java util stream referencepipeline 3 1 accept referencepipeline java 193 at java util iterator foreachremaine iterator java 116 at java util spliterators iteratorspliterator foreachremaine spliterator java 1801 at java util stream abstractpipeline copyinto abstractpipeline java 481 at java util stream abstractpipeline wrapandcopyinto abstractpipeline java 471 at java util stream reduceop reduceop evaluatesequential reduceop java 708 at java util stream abstractpipeline evaluate abstractpipeline java 234 at java util stream referencepipeline collect referencepipeline java 499 at com facebook presto sql relational optimizer expressionoptimizer visitor visitcall expressionoptimizer java 151 at com facebook presto sql relational optimizer expressionoptimizer visitor visitcall expressionoptimizer java 70 at com facebook presto sql relational callexpression accept callexpression java 88 at com facebook presto sql relational optimizer expressionoptimizer visitor lambda visitcall 2 expressionoptimizer java 140 at java util stream referencepipeline 3 1 accept referencepipeline java 193 at java util iterator foreachremaine iterator java 116 at java util spliterators iteratorspliterator foreachremaine spliterator java 1801 at java util stream abstractpipeline copyinto abstractpipeline java 481 at java util stream abstractpipeline wrapandcopyinto abstractpipeline java 471 at java util stream reduceop reduceop evaluatesequential reduceop java 708 at java util stream abstractpipeline evaluate abstractpipeline java 234 at java util stream referencepipeline collect referencepipeline java 499 at com facebook presto sql relational optimizer expressionoptimizer visitor visitcall expressionoptimizer java 141 at com facebook presto sql relational optimizer expressionoptimizer visitor visitcall expressionoptimizer java 70 at com facebook presto sql relational callexpression accept callexpression java 88 at com facebook presto sql relational optimizer expressionoptimizer optimize expressionoptimizer java 67 at com facebook presto sql relational sqltorowexpressiontranslator translate sqltorowexpressiontranslator java 141 at com facebook presto sql planner localexecutionplanner visitor torowexpression localexecutionplanner java 1100 at com facebook presto sql planner localexecutionplanner visitor visitscanfilterandproject localexecutionplanner java 1002 at com facebook presto sql planner localexecutionplanner visitor visitproject localexecutionplanner java 933 at com facebook presto sql planner localexecutionplanner visitor visitproject localexecutionplanner java 525 at com facebook presto sql planner plan projectnode accept projectnode java 81 at com facebook presto sql planner localexecutionplanner visitor createnestedloopjoin localexecutionplanner java 1418 at com facebook presto sql planner localexecutionplanner visitor visitjoin localexecutionplanner java 1399 at com facebook presto sql planner localexecutionplanner visitor visitjoin localexecutionplanner java 525 at com facebook presto sql planner plan joinnode accept joinnode java 170 at com facebook presto sql planner localexecutionplanner visitor visitscanfilterandproject localexecutionplanner java 973 at com facebook presto sql planner localexecutionplanner visitor visitproject localexecutionplanner java 933 at com facebook presto sql planner localexecutionplanner visitor visitproject localexecutionplanner java 525 at com facebook presto sql planner plan projectnode accept projectnode java 81 at com facebook presto sql planner localexecutionplanner visitor visitoutput localexecutionplanner java 564 at com facebook presto sql planner localexecutionplanner visitor visitoutput localexecutionplanner java 525 at com facebook presto sql planner plan outputnode accept outputnode java 81 at com facebook presto sql planner localexecutionplanner plan localexecutionplanner java 340 at com facebook presto sql planner localexecutionplanner plan localexecutionplanner java 279 at com facebook presto execution sqltaskexecution sqltaskexecution java 161 at com facebook presto execution sqltaskexecution createsqltaskexecution sqltaskexecution java 120 at com facebook presto execution sqltaskexecutionfactory create sqltaskexecutionfactory java 74 at com facebook presto execution sqltask updatetask sqltask java 313 at com facebook presto execution sqltaskmanager updatetask sqltaskmanager java 323 at com facebook presto server taskresource createorupdatetask taskresource java 125 at sun reflect generatedmethodaccessor779 invoke unknown source at sun reflect delegatingmethodaccessorimpl invoke delegatingmethodaccessorimpl java 43 at java lang reflect method invoke method java 498 at org glassfish jersey server model internal resourcemethodinvocationhandlerfactory 1 invoke resourcemethodinvocationhandlerfactory java 81 at org glassfish jersey server model internal abstractjavaresourcemethoddispatcher 1 run abstractjavaresourcemethoddispatcher java 144 at org glassfish jersey server model internal abstractjavaresourcemethoddispatcher invoke abstractjavaresourcemethoddispatcher java 161 at org glassfish jersey server model internal javaresourcemethoddispatcherprovider responseoutinvoker dodispatch javaresourcemethoddispatcherprovider java 160 at org glassfish jersey server model internal abstractjavaresourcemethoddispatcher dispatch abstractjavaresourcemethoddispatcher java 99 at org glassfish jersey server model resourcemethodinvoker invoke resourcemethodinvoker java 389 at org glassfish jersey server model resourcemethodinvoker apply resourcemethodinvoker java 347 at org glassfish jersey server model resourcemethodinvoker apply resourcemethodinvoker java 102 at org glassfish jersey server serverruntime 2 run serverruntime java 326 at org glassfish jersey internal error 1 call error java 271 at org glassfish jersey internal error 1 call error java 267 at org glassfish jersey internal error process error java 315 at org glassfish jersey internal error process error java 297 at org glassfish jersey internal error process error java 267 at org glassfish jersey process internal requestscope runinscope requestscope java 317 at org glassfish jersey server serverruntime process serverruntime java 305 at org glassfish jersey server applicationhandler handle applicationhandler java 1154 at org glassfish jersey servlet webcomponent serviceimpl webcomponent java 473 at org glassfish jersey servlet webcomponent service webcomponent java 427 at org glassfish jersey servlet servletcontainer service servletcontainer java 388 at org glassfish jersey servlet servletcontainer service servletcontainer java 341 at org glassfish jersey servlet servletcontainer service servletcontainer java 228 at org eclipse jetty servlet servletholder handle servletholder java 845 at org eclipse jetty servlet servlethandler cachedchain dofilter servlethandler java 1689 at io airlift http server tracetokenfilter dofilter tracetokenfilter java 63 at org eclipse jetty servlet servlethandler cachedchain dofilter servlethandler java 1676 at io airlift http server timingfilter dofilter timingfilter java 52 at org eclipse jetty servlet servlethandler cachedchain dofilter servlethandler java 1676 at org eclipse jetty servlet servlethandler dohandle servlethandler java 581 at org eclipse jetty server handler scopedhandler handle scopedhandler java 143 at org eclipse jetty server handler gzip gziphandler handle gziphandler java 397 at org eclipse jetty server handler contexthandler dohandle contexthandler java 1182 at org eclipse jetty servlet servlethandler doscope servlethandler java 511 at org eclipse jetty server handler contexthandler doscope contexthandler java 1112 at org eclipse jetty server handler scopedhandler handle scopedhandler java 141 at org eclipse jetty server handler handlercollection handle handlercollection java 119 at org eclipse jetty server handler statisticshandler handle statisticshandler java 169 at org eclipse jetty server handler handlerlist handle handlerlist java 52 at org eclipse jetty server handler handlerwrapper handle handlerwrapper java 134 at org eclipse jetty server server handle server java 524 at org eclipse jetty server httpchannel handle httpchannel java 319 at org eclipse jetty server httpconnection onfillable httpconnection java 253 at org eclipse jetty io abstractconnection readcallback succeed abstractconnection java 273 at org eclipse jetty io fillinterest fillable fillinterest java 95 at org eclipse jetty io selectchannelendpoint 2 run selectchannelendpoint java 93 at org eclipse jetty util thread strategy executeproduceconsume executeproduceconsume executeproduceconsume java 303 at org eclipse jetty util thread strategy executeproduceconsume produceconsume executeproduceconsume java 148 at org eclipse jetty util thread strategy executeproduceconsume run executeproduceconsume java 136 at org eclipse jetty util thread queuedthreadpool runjob queuedthreadpool java 671 at org eclipse jetty util thread queuedthreadpool 2 run queuedthreadpool java 589 at java lang thread run thread java 745
prestodbpresto
miss repartitioning step break window function result
Bug
we find a weird window function behavior when a query involve multiple window function and self join here be how to reproduce this problem in presto 0 146 ok query presto explain with x as select i d rank over partition by i d as rank from kw sequences y as select b i d a ranking from x a join x b on a i d b i d select i d rank over partition by i d order by rank from y query plan output i d col1 i d 11 varchar rank 40 bigint i d i d 11 col1 rank 40 exchange gather i d 11 varchar rank 40 bigint project i d 11 varchar rank 40 bigint window partition by i d 11 order by rank i d 11 varchar rank bigint hashvalue bigint rank 40 bigint rank 40 rank exchange repartition i d 11 varchar rank bigint hashvalue bigint project rank bigint i d 11 varchar hashvalue 50 bigint innerjoin i d i d 11 i d varchar hashvalue 48 bigint rank bigint i d 11 varchar hashvalue 50 bigint window partition by i d i d varchar hashvalue 48 bigint rank bigint rank rank exchange repartition i d varchar hashvalue 48 bigint project i d varchar hashvalue 49 bigint hashvalue 49 combine hash bigint 0 coalesce operator hash code i d 0 tablescan td presto td customer monotaro kw sequences originalconstraint true i d varchar layout com treasure datum presto connector tdtablelayouthandle ebbc2de6 i d td i d window partition by i d 11 i d 11 varchar hashvalue 50 bigint exchange repartition i d 11 varchar hashvalue 50 bigint project i d 11 varchar hashvalue 51 bigint hashvalue 51 combine hash bigint 0 coalesce operator hash code i d 11 0 tablescan td presto td customer monotaro kw sequences originalconstraint true i d 11 varchar layout com treasure datum presto connector tdtablelayouthandle ebbc2de6 i d 11 td i d bad query miss repartitioning presto explain with x as select i d rank over partition by i d as rank from kw sequences y as select a i d a ranking from x a join x b on a i d b i d select i d rank over partition by i d order by rank from y query plan output i d col1 i d varchar rank 40 bigint col1 rank 40 exchange gather i d varchar rank 40 bigint project i d varchar rank 40 bigint window partition by order by rank rank bigint i d varchar hashvalue bigint rank 40 bigint rank 40 rank miss repartitioning step project rank bigint i d varchar hashvalue bigint innerjoin i d i d 11 i d varchar hashvalue bigint rank bigint i d 11 varchar hashvalue 49 bigint window partition by i d i d varchar hashvalue bigint rank bigint rank rank exchange repartition i d varchar hashvalue bigint project i d varchar hashvalue 48 bigint hashvalue 48 combine hash bigint 0 coalesce operator hash code i d 0 tablescan td presto td customer monotaro kw sequences originalconstraint true i d varchar layout com treasure datum presto connector tdtablelayouthandle eddc8608 i d td i d window partition by i d 11 i d 11 varchar hashvalue 49 bigint exchange repartition i d 11 varchar hashvalue 49 bigint project i d 11 varchar hashvalue 50 bigint hashvalue 50 combine hash bigint 0 coalesce operator hash code i d 11 0 tablescan td presto td customer monotaro kw sequences originalconstraint true i d 11 varchar layout com treasure datum presto connector tdtablelayouthandle eddc8608 i d 11 td i d the only difference between two query be use a i d or b i d to extract the self join result but these ids value should be the same because of a i d b i d join condition
prestodbpresto
add support for postgre json type
Enhancement
this could be expose to presto as an unbounded varchar or a presto json type
prestodbpresto
fix ridiculously long error from parser
Enhancement
spit out every possible keyword isn t helpful presto select top 1 query 20160712 200120 24229 y6z74 fail line 1 12 extraneous input 1 expect from add as where group order have limit approximate at confidence or and in not no between like be substre position date time timestamp interval year month day hour minute second zone over partition range row precede follow current row view replace grant privilege public option explain analyze format type text graphviz logical distribute try show table schema catalog column column use partition function union except intersect to system bernoulli poissonize tablesample rescale array map set reset session datum start transaction commit rollback work isolation level serializable repeatable commit uncommitted read write only call nfd nfc nfkd nfkc if nullif coalesce neq identifi digit identifier quote identifier backquote identifi
prestodbpresto
handle large split count in cli
Bug
the alignment of column be wrong when there be 100 000 split example stage row row s bytes bytes s queue run do 0 r 0 0 0b 0b 0 1 0 1 r 153k 250 3 36 m 5 62k 0 100 0 2 s 71 7b 117 m 7 41 t 12 4 g 770 453 131531
prestodbpresto
uncategorized error for too many dot
Bug
presto select from a b c d query 20160707 192115 20747 y6z74 fail too many dot in table name a b c d java lang illegalargumentexception too many dot in table name a b c d at com google common base precondition checkargument precondition java 145 at com facebook presto metadata metadatautil createqualifiedobjectname metadatautil java 119 at com facebook presto sql analyzer statementanalyzer visittable statementanalyzer java 890 at com facebook presto sql analyzer statementanalyzer visittable statementanalyzer java 219 at com facebook presto sql tree table accept table java 50 at com facebook presto sql tree astvisitor process astvisitor java 22 at com facebook presto sql analyzer statementanalyzer analyzefrom statementanalyzer java 1733 at com facebook presto sql analyzer statementanalyzer visitqueryspecification statementanalyzer java 1032 at com facebook presto sql analyzer statementanalyzer visitqueryspecification statementanalyzer java 219 at com facebook presto sql tree queryspecification accept queryspecification java 125 at com facebook presto sql tree astvisitor process astvisitor java 22 at com facebook presto sql analyzer statementanalyzer visitquery statementanalyzer java 829 at com facebook presto sql analyzer statementanalyzer visitquery statementanalyzer java 219 at com facebook presto sql tree query accept query java 103 at com facebook presto sql tree astvisitor process astvisitor java 22 at com facebook presto sql analyzer analyzer analyze analyzer java 60 at com facebook presto execution sqlqueryexecution doanalyzequery sqlqueryexecution java 270 at com facebook presto execution sqlqueryexecution analyzequery sqlqueryexecution java 256 at com facebook presto execution sqlqueryexecution start sqlqueryexecution java 220 at com facebook presto execution queuedexecution lambda start 1 queuedexecution java 68 at java util concurrent threadpoolexecutor runworker threadpoolexecutor java 1142 at java util concurrent threadpoolexecutor worker run threadpoolexecutor java 617 at java lang thread run thread java 745
prestodbpresto
query with function return color type fail
Bug
sql presto select rgb 0 0 0 query be go server restart stack trace query 20160701 183636 00000 9c6sb run 1 node 0 split java lang runtimeexception error fetch next at return an invalid response jsonresponse statuscode 200 statusmessage ok header vary accept encode user agent content length 899 date fri 01 jul 2016 18 36 38 gmt x content type option nosniff content type application json hasvalue false value null error i d 20160701 183636 00000 9c6sb infouri partialcanceluri nexturi column name col0 type color typesignature rawtype color typeargument literalargument argument datum ffff00 stat state run schedule true node 1 totalsplit 1 queuedsplit 0 runningsplit 0 completedsplit 1 usertimemillis 0 cputimemillis 4 walltimemillis 25 processedrow 0 processedbyte 0 rootstage stageid 0 state run do false node 1 totalsplit 1 queuedsplit 0 runningsplit 0 completedsplit 1 usertimemillis 0 cputimemillis 4 walltimemillis 25 processedrow 1 processedbyte 0 substage at com facebook presto client statementclient requestfailedexception statementclient java 344 at com facebook presto client statementclient advance statementclient java 294 at com facebook presto cli statusprinter printinitialstatusupdate statusprinter java 121 at com facebook presto cli query renderqueryoutput query java 123 at com facebook presto cli query renderoutput query java 107 at com facebook presto cli console process console java 294 at com facebook presto cli console runconsole console java 234 at com facebook presto cli console run console java 139 at com facebook presto cli presto main presto java 32 cause by java lang illegalargumentexception unable to create class com facebook presto client queryresult from json response i d 20160701 183636 00000 9c6sb infouri partialcanceluri nexturi column name col0 type color typesignature rawtype color typeargument literalargument argument datum ffff00 stat state run schedule true node 1 totalsplit 1 queuedsplit 0 runningsplit 0 completedsplit 1 usertimemillis 0 cputimemillis 4 walltimemillis 25 processedrow 0 processedbyte 0 rootstage stageid 0 state run do false node 1 totalsplit 1 queuedsplit 0 runningsplit 0 completedsplit 1 usertimemillis 0 cputimemillis 4 walltimemillis 25 processedrow 1 processedbyte 0 substage at io airlift http client fulljsonresponsehandler jsonresponse fulljsonresponsehandler java 119 at io airlift http client fulljsonresponsehandler handle fulljsonresponsehandler java 66 at io airlift http client fulljsonresponsehandler handle fulljsonresponsehandler java 35 at io airlift http client jetty jettyhttpclient execute jettyhttpclient java 365 at com facebook presto client statementclient advance statementclient java 281 7 more cause by java lang illegalargumentexception invalid simple type class com facebook presto client queryresult json bytes at io airlift json jsoncodec fromjson jsoncodec java 174 at io airlift http client fulljsonresponsehandler jsonresponse fulljsonresponsehandler java 116 11 more cause by com fasterxml jackson databind jsonmappingexception instantiation of simple type class com facebook presto client queryresult value fail illegal base64 character 23 at com fasterxml jackson databind deser std stdvalueinstantiator wrapexception stdvalueinstantiator java 405 at com fasterxml jackson databind deser std stdvalueinstantiator createfromobjectwith stdvalueinstantiator java 234 at com fasterxml jackson databind deser impl propertybasedcreator build propertybasedcreator java 167 at com fasterxml jackson databind deser beandeserializer deserializeusingpropertybase beandeserializer java 398 at com fasterxml jackson databind deser beandeserializerbase deserializefromobjectusingnondefault beandeserializerbase java 1064 at com fasterxml jackson databind deser beandeserializer deserializefromobject beandeserializer java 264 at com fasterxml jackson databind deser beandeserializer deserialize beandeserializer java 124 at com fasterxml jackson databind objectmapper readmapandclose objectmapper java 3066 at com fasterxml jackson databind objectmapper readvalue objectmapper java 2262 at io airlift json jsoncodec fromjson jsoncodec java 171 12 more cause by java lang illegalargumentexception illegal base64 character 23 at java util base64 decoder decode0 base64 java 714 at java util base64 decoder decode base64 java 526 at java util base64 decoder decode base64 java 549 at com facebook presto client queryresult fixvalue queryresult java 319 at com facebook presto client queryresult fixdata queryresult java 220 at com facebook presto client queryresult queryresult java 92 at sun reflect generatedconstructoraccessor14 newinstance unknown source at sun reflect delegatingconstructoraccessorimpl newinstance delegatingconstructoraccessorimpl java 45 at java lang reflect constructor newinstance constructor java 423
prestodbpresto
use succinct size in raptor log message for shard copy
Enhancement
message copy shard ab17da2e fd87 4f35 a3a1 6a767f7ba1ef from backup in 15 00 13898959b at 904 94 kb s 13898959b would be easy to read in mb
prestodbpresto
exceededmemorylimitexception at presto 0 148 0 149
Bug
hi I use presto 0 149 jdk1 8 0 92 hdp 2 1 hive connector cento 6 5 if I execute the follow query query exceed max memory size of 70 gb error occur select from test hogeview where yyyymmdd 20160622 limit 1 test hogeview be presto view and have many leave outer join clause and one group by clause although same error occur at presto 0 148 there be no error at presto 0 147 worker config be the follow coordinator false http server http port query max memory 70 gb query max memory per node 3 gb discovery uri task cpu timer enable false exchange http client request timeout 120s
prestodbpresto
division by zero error with empty interleaved block
Bug
this change 373c745b30b2db1e96eef844096b3620a11a84c7 add this bit to interleavedblockencode readblock java byte isempty sliceinput readbyte if isempty 1 return new interleavedblock new block 0 interleavedblock perform division use the length of that array column which result in division by zero error java int positioninblock position column java sql sqlexception query fail 20160623 104612 01302 fsieu by zero at com facebook presto jdbc prestoresultset resultsexception prestoresultset java 1799 at com facebook presto jdbc prestoresultset resultspageiterator computenext prestoresultset java 1787 at com facebook presto jdbc prestoresultset resultspageiterator computenext prestoresultset java 1756 at com facebook presto jdbc internal guava collect abstractiterator trytocomputenext abstractiterator java 143 at com facebook presto jdbc internal guava collect abstractiterator hasnext abstractiterator java 138 at com facebook presto jdbc internal guava collect transformediterator hasnext transformediterator java 43 at com facebook presto jdbc internal guava collect iterator 5 hasnext iterator java 547 at com facebook presto jdbc prestoresultset next prestoresultset java 149 at com facebook presto verifier validator convertjdbcresultset validator java 520 at com facebook presto verifier validator lambda getresultsetconverter 4 validator java 494 at java util concurrent futuretask run futuretask java 266 at java util concurrent threadpoolexecutor runworker threadpoolexecutor java 1142 at java util concurrent threadpoolexecutor worker run threadpoolexecutor java 617 at java lang thread run thread java 745 at java util concurrent futuretask report futuretask java 122 at java util concurrent futuretask get futuretask java 206 at com google common util concurrent simpletimelimiter callwithtimeout simpletimelimiter java 130 at com facebook presto verifier validator executequery validator java 426 at com facebook presto verifier validator executequeryt validator java 304 at com facebook presto verifier validator validate validator java 218 at com facebook presto verifier validator valid validator java 190 at java util concurrent executors runnableadapter call executor java 511 at java util concurrent futuretask run futuretask java 266 at java util concurrent executors runnableadapter call executor java 511 at java util concurrent futuretask run futuretask java 266 at java util concurrent threadpoolexecutor runworker threadpoolexecutor java 1142 at java util concurrent threadpoolexecutor worker run threadpoolexecutor java 617 at java lang thread run thread java 745 cause by java lang arithmeticexception by zero at com facebook presto spi block abstractinterleavedblock getregion abstractinterleavedblock java 260 at com facebook presto spi block abstractinterleavedblock copyregion abstractinterleavedblock java 249 at com facebook presto spi block abstractarrayblock getsinglevalueblock abstractarrayblock java 234 at com facebook presto operator topnoperator topnbuilder getvalue topnoperator java 338 at com facebook presto operator topnoperator topnbuilder addrow topnoperator java 313 at com facebook presto operator topnoperator topnbuilder mergewithglobalcandidate topnoperator java 284 at com facebook presto operator topnoperator topnbuilder processpage topnoperator java 273 at com facebook presto operator topnoperator addinput topnoperator java 202 at com facebook presto operator driver processinternal driver java 384 at com facebook presto operator driver processfor driver java 301 at com facebook presto execution sqltaskexecution driversplitrunner processfor sqltaskexecution java 618 at com facebook presto execution taskexecutor prioritizedsplitrunner process taskexecutor java 529 at com facebook presto execution taskexecutor runner run taskexecutor java 665 3 more this reproduce the issue java interleavedblock block new interleavedblock new block 0 block copyregion 0 0 be that call to copyregion even valid if not there might be another bug far up the stack too also the test in abstractinterleavedblock s constructor be a bit suspect the condition check for non negative but the message say positive moreover give that method use that value in division operation it would seem that we should ensure the value be never 0 java if column 0 throw new illegalargumentexception number of block in interleavedblock must be positive
prestodbpresto
tableau web connector hard code hive catalog in it
Bug
I find presto tableau web connector hard code hive catalog in it tableau presto connector html var catalogclient new statementclient catalog hive schema default query show catalog populateschema hive this make the tableau web connector fail to work when the presto be deploy without hive connector configure and tableau web connector will always report error catalog hive do not exist while user doesn t have hive configure at all probably use the system catalog as default be well
prestodbpresto
add connection property for jdbc
Enhancement
after 6078 be merge add property for time zone local source etc
prestodbpresto
non block api in connectorpagesource
Enhancement
it make possible to use asynchronous datum fetch in connector by analogy to the connectorpagesink appendpage method connectorpagesource getnextpage should return completablefuture instead of page all of the connector initially should be migrate to return completablefuture completedfuture page suppose that wrap the result into completedfuture win t do any harm to performance if there be any performance relate doubt the listenablefuture isblocke method can be add to connectorpagesource interface with the default implementation of return unblock the first approach be more clear and intuitive also it explicitly suggest to use unblocked algorithm for datum fetch the second approach win t introduce any harm to the performance for sure and no connector migration will be require martint dain what do you think what approach be well to choose
prestodbpresto
grouping set over union fail
Bug
the follow query select x count distinct x as c from select from value 1 t x union all select from value 1 t x t2 group by group set x fail with query 20160622 013115 00003 u5amn fail index 0 must be less than size 0 java lang indexoutofboundsexception index 0 must be less than size 0 at com google common base precondition checkelementindex precondition java 310 at com google common base precondition checkelementindex precondition java 292 at com google common collect regularimmutablelist get regularimmutablelist java 65 at com facebook presto sql planner optimization addexchange rewriter visitunion addexchange java 1104 at com facebook presto sql planner optimization addexchange rewriter visitunion addexchange java 188 at com facebook presto sql planner plan unionnode accept unionnode java 139 at com facebook presto sql planner optimizations addexchange rewriter planchild addexchange java 1143 at com facebook presto sql planner optimizations addexchanges rewriter visitplan addexchange java 215 at com facebook presto sql planner optimizations addexchanges rewriter visitplan addexchange java 188 at com facebook presto sql planner plan planvisitor visitgroupid planvisitor java 150 at com facebook presto sql planner plan groupidnode accept groupidnode java 125 at com facebook presto sql planner optimizations addexchange rewriter planchild addexchange java 1143 at com facebook presto sql planner optimization addexchange rewriter visitaggregation addexchange java 283 at com facebook presto sql planner optimization addexchange rewriter visitaggregation addexchange java 188 at com facebook presto sql planner plan aggregationnode accept aggregationnode java 189 at com facebook presto sql planner optimizations addexchange rewriter planchild addexchange java 1143 at com facebook presto sql planner optimization addexchange rewriter visitproject addexchange java 231 at com facebook presto sql planner optimization addexchange rewriter visitproject addexchange java 188 at com facebook presto sql planner plan projectnode accept projectnode java 76 at com facebook presto sql planner optimizations addexchange rewriter planchild addexchange java 1143 at com facebook presto sql planner optimization addexchange rewriter visitaggregation addexchange java 283 at com facebook presto sql planner optimization addexchange rewriter visitaggregation addexchange java 188 at com facebook presto sql planner plan aggregationnode accept aggregationnode java 189 at com facebook presto sql planner optimizations addexchange rewriter planchild addexchange java 1143 at com facebook presto sql planner optimization addexchange rewriter visitproject addexchange java 231 at com facebook presto sql planner optimization addexchange rewriter visitproject addexchange java 188 at com facebook presto sql planner plan projectnode accept projectnode java 76 at com facebook presto sql planner optimizations addexchange rewriter planchild addexchange java 1143 at com facebook presto sql planner optimizations addexchange rewriter visitoutput addexchange java 237 at com facebook presto sql planner optimizations addexchange rewriter visitoutput addexchange java 188 at com facebook presto sql planner plan outputnode accept outputnode java 81 at com facebook presto sql planner optimization addexchange optimize addexchange java 150 at com facebook presto sql planner logicalplanner plan logicalplanner java 100 at com facebook presto execution sqlqueryexecution doanalyzequery sqlqueryexecution java 277 at com facebook presto execution sqlqueryexecution analyzequery sqlqueryexecution java 256 at com facebook presto execution sqlqueryexecution start sqlqueryexecution java 220 at com facebook presto execution queuedexecution lambda start 1 queuedexecution java 68 at java util concurrent threadpoolexecutor runworker threadpoolexecutor java 1142 at java util concurrent threadpoolexecutor worker run threadpoolexecutor java 617 at java lang thread run thread java 745
prestodbpresto
add hidden input file name column to hive connector
Enhancement
this be likely a lot of work as this would need to be add to every reader the implementation should work like partition key and it may be possible to leverage that code
prestodbpresto
array agg should not ignore null
Bug
presto select array agg x from value 1 2 3 null t x col0 1 2 3 the expect result be 1 2 3 null from the spec ii otherwise the result of be an array of n element such that for all I 1 one I n the value of the i th element be the value of the first column of ri note 331 null value be not eliminate when compute this plus the optional set apart from s
prestodbpresto
round nan 2 return 0 0
Bug
select round nan 2 result in 0 0 but should be nan this be a regression since 0 144 5
prestodbpresto
query not fail ed when it doesn t match any selection rule
Bug
the failure isn t properly propagate and the query continue to show queue state until it get expire after 5 minute presto presto show table error running command error start query at return an invalid response jsonresponse statuscode 500 statusmessage internal server error header content length 4950 date thu 09 jun 2016 18 04 40 gmt content type text plain hasvalue false value null error com facebook presto spi prestoexception query do not match any selection rule at com facebook presto execution resourcegroup resourcegroupmanager selectgroup resourcegroupmanager java 157 at com facebook presto execution resourcegroup resourcegroupmanager submit resourcegroupmanager java 80 at com facebook presto execution sqlquerymanager createquery sqlquerymanager java 340 at com facebook presto server statementresource query statementresource java 308 at com facebook presto server statementresource createquery statementresource java 171 at sun reflect generatedmethodaccessor416 invoke unknown source at sun reflect delegatingmethodaccessorimpl invoke delegatingmethodaccessorimpl java 43 at java lang reflect method invoke method java 498 at org glassfish jersey server model internal resourcemethodinvocationhandlerfactory 1 invoke resourcemethodinvocationhandlerfactory java 81 at org glassfish jersey server model internal abstractjavaresourcemethoddispatcher 1 run abstractjavaresourcemethoddispatcher java 144 at org glassfish jersey server model internal abstractjavaresourcemethoddispatcher invoke abstractjavaresourcemethoddispatcher java 161 at org glassfish jersey server model internal javaresourcemethoddispatcherprovider responseoutinvoker dodispatch javaresourcemethoddispatcherprovider java 160 at org glassfish jersey server model internal abstractjavaresourcemethoddispatcher dispatch abstractjavaresourcemethoddispatcher java 99 at org glassfish jersey server model resourcemethodinvoker invoke resourcemethodinvoker java 389 at org glassfish jersey server model resourcemethodinvoker apply resourcemethodinvoker java 347 at org glassfish jersey server model resourcemethodinvoker apply resourcemethodinvoker java 102 at org glassfish jersey server serverruntime 2 run serverruntime java 326 at org glassfish jersey internal error 1 call error java 271 at org glassfish jersey internal error 1 call error java 267 at org glassfish jersey internal error process error java 315 at org glassfish jersey internal error process error java 297 at org glassfish jersey internal error process error java 267 at org glassfish jersey process internal requestscope runinscope requestscope java 317 at org glassfish jersey server serverruntime process serverruntime java 305 at org glassfish jersey server applicationhandler handle applicationhandler java 1154 at org glassfish jersey servlet webcomponent serviceimpl webcomponent java 473 at org glassfish jersey servlet webcomponent service webcomponent java 427 at org glassfish jersey servlet servletcontainer service servletcontainer java 388 at org glassfish jersey servlet servletcontainer service servletcontainer java 341 at org glassfish jersey servlet servletcontainer service servletcontainer java 228 at org eclipse jetty servlet servletholder handle servletholder java 845 at org eclipse jetty servlet servlethandler cachedchain dofilter servlethandler java 1689 at io airlift http server tracetokenfilter dofilter tracetokenfilter java 63 at org eclipse jetty servlet servlethandler cachedchain dofilter servlethandler java 1676 at io airlift http server timingfilter dofilter timingfilter java 52 at org eclipse jetty servlet servlethandler cachedchain dofilter servlethandler java 1676 at org eclipse jetty servlet servlethandler dohandle servlethandler java 581 at org eclipse jetty server handler scopedhandler handle scopedhandler java 143 at org eclipse jetty server handler gzip gziphandler handle gziphandler java 396 at org eclipse jetty server handler contexthandler dohandle contexthandler java 1176 at org eclipse jetty servlet servlethandler doscope servlethandler java 511 at org eclipse jetty server handler contexthandler doscope contexthandler java 1106 at org eclipse jetty server handler scopedhandler handle scopedhandler java 141 at org eclipse jetty server handler handlercollection handle handlercollection java 119 at org eclipse jetty server handler statisticshandler handle statisticshandler java 169 at org eclipse jetty server handler handlerlist handle handlerlist java 52 at org eclipse jetty server handler handlerwrapper handle handlerwrapper java 134 at org eclipse jetty server server handle server java 518 at org eclipse jetty server httpchannel handle httpchannel java 314 at org eclipse jetty server httpconnection onfillable httpconnection java 253 at org eclipse jetty io abstractconnection readcallback succeed abstractconnection java 273 at org eclipse jetty io fillinterest fillable fillinterest java 95 at org eclipse jetty io selectchannelendpoint 2 run selectchannelendpoint java 93 at org eclipse jetty util thread queuedthreadpool runjob queuedthreadpool java 654 at org eclipse jetty util thread queuedthreadpool 3 run queuedthreadpool java 572 at java lang thread run thread java 745
prestodbpresto
type mismatch in plan
Bug
late master presto tiny explain select avg extendedprice from lineitem query plan output col0 avg double col0 avg aggregate final avg double avg avg avg 4 remoteexchange gather avg 4 varchar aggregate partial avg 4 varchar avg 4 avg extendedprice tablescan tpch tpch lineitem sf0 01 originalconstraint true extendedprice double extendedprice tpch extendedprice 1 row presto tiny describe lineitem column type comment orderkey bigint partkey bigint suppkey bigint linenumber integer quantity double extendedprice double discount double tax double returnflag varchar linestatus varchar shipdate date commitdate date receiptdate date shipinstruct varchar shipmode varchar comment varchar 16 row extendedprice be double avg 4 avg extendedprice should be double too however it be varchar I find this when look into the travis failure of 5393
prestodbpresto
leave join against empty relation produce no row
Bug
this can be reproduce with the follow test case test public void testemptyleftjoin throw exception use orderkey rand to create an empty relation assertquery select from lineitem a left join select from order where orderkey rand b on a orderkey b orderkey assertquery select from lineitem a left join select from order where orderkey rand b on 1 1
prestodbpresto
add queued flag to statementstat
Enhancement
this flag should be add before the schedule flag it provide a proper way for client to know if the query be wait in the queue client should not be programmatically use the state field
prestodbpresto
change reserve memory graph in web ui to free memory
Enhancement
instead of display total user memory on the cluster in the new web ui it be more useful to display free distribute memory in the general pool system pool along with min local memory on a node for general system
prestodbpresto
incorrect row construct result
Bug
the late 0 148 snapshot presto tiny select row x y z m n from value row cast null as integer 2 3 4 5 t x y z m n col0 field0 null field1 null field2 null field3 null field4 null 1 row query 20160526 222606 00003 6gx5u finish 1 node split 5 total 5 do 100 00 cpu time 0 0s total 0 rows s 0b s 50 active per node 0 0 parallelism 0 rows s 0b s parallelism 0 0 0 01 0 row 0b 0 rows s 0b s however if there be no null cast the result be correct presto tiny select row x y z m n from value row null 2 3 4 5 t x y z m n col0 field0 null field1 2 field2 3 field3 4 field4 5 1 row query 20160526 222758 00006 6gx5u finish 1 node split 5 total 5 do 100 00 cpu time 0 0s total 0 rows s 0b s 33 active per node 0 0 parallelism 0 rows s 0b s parallelism 0 0 0 00 0 row 0b 0 rows s 0b s
prestodbpresto
support window clause
Enhancement
the standard window clause allow define name window which window function can reference sql select x sum x over w from value 1 2 3 as t x window w as order by x additionally a window specification can reference and modify a name window sql select x sum x over w row between unbounded preceding and 1 precede from value 1 2 3 as t x window w as order by x see the sql standard for full detail
prestodbpresto
parse time stamp
Enhancement
be it possible parse time stamp 28 jan 16 11 45 46 421000000 pm in presto I try it with follow query select date parse 28 jan 16 11 45 46 421000000 pm d b y l I s f p error invalid format 28 jan 16 11 45 46 421000000 pm be malforme at 000 pm I get this time stamp format from oracle db
prestodbpresto
consider add array contain for multiple item
Enhancement
it can be useful to check if an array contain multiple item we could have separate version of contain that handle any and all contain any array 2 3 4 array 3 5 true contain any array 2 3 4 array 5 6 false contain all array 2 3 4 array 3 4 true contain all array 2 3 4 array 3 5 false
prestodbpresto
plan error when same subquery appear in select and where clause
Bug
sql select x in select from value 1 from value 2 t x where x in select from value 1 fail with java lang illegalargumentexception invalid node expression dependency field field 1 not in source plan output field semijoin result at com google common base precondition checkargument precondition java 145 at com facebook presto sql planner sanity validatedependencieschecker checkdependencie validatedependencieschecker java 564 at com facebook presto sql planner sanity validatedependencieschecker access 100 validatedependencieschecker java 71 at com facebook presto sql planner sanity validatedependencieschecker visitor visitproject validatedependencieschecker java 248 at com facebook presto sql planner sanity validatedependencieschecker visitor visitproject validatedependencieschecker java 80 at com facebook presto sql planner plan projectnode accept projectnode java 81 at com facebook presto sql planner sanity validatedependencieschecker visitor visitoutput validatedependencieschecker java 291 at com facebook presto sql planner sanity validatedependencieschecker visitor visitoutput validatedependencieschecker java 80 at com facebook presto sql planner plan outputnode accept outputnode java 81 at com facebook presto sql planner sanity validatedependencieschecker validate validatedependencieschecker java 77 at com facebook presto sql planner sanity plansanitychecker lambda validate 0 plansanitychecker java 35 at java lang iterable foreach iterable java 75 at com facebook presto sql planner sanity plansanitychecker validate plansanitychecker java 35 at com facebook presto sql planner logicalplanner plan logicalplanner java 105 at com facebook presto test localqueryrunner createplan localqueryrunner java 583 we ve bisect it to this commit b5d8bf55da276e55a7be4b43e5c275ea2eb21193
prestodbpresto
round 0 49999999999999994 give wrong result
Bug
presto use floor value 0 5 concept to round value which cause problem when it come to value 0 49999999999999994 0x1 fffffffffffffp 2 e g sql presto select round 0 49999999999999994 col0 1 0 1 row
prestodbpresto
bad error message when row in value have different number of field
Bug
sql value 1 1 2 fail with java lang indexoutofboundsexception index 1 size 1 at java util arraylist rangecheck arraylist java 653 at java util arraylist get arraylist java 429 at com facebook presto sql analyzer statementanalyzer visitvalues statementanalyzer java 1429 at com facebook presto sql analyzer statementanalyzer visitvalues statementanalyzer java 229 at com facebook presto sql tree value accept value java 55 at com facebook presto sql tree astvisitor process astvisitor java 22 at com facebook presto sql analyzer statementanalyzer visitquery statementanalyzer java 928 at com facebook presto sql analyzer statementanalyzer visitquery statementanalyzer java 229 at com facebook presto sql tree query accept query java 103 at com facebook presto sql tree astvisitor process astvisitor java 22 at com facebook presto sql analyzer analyzer analyze analyzer java 60 at com facebook presto execution sqlqueryexecution doanalyzequery sqlqueryexecution java 273 at com facebook presto execution sqlqueryexecution analyzequery sqlqueryexecution java 259 at com facebook presto execution sqlqueryexecution start sqlqueryexecution java 223 at com facebook presto execution queuedexecution lambda start 1 queuedexecution java 62 at java util concurrent threadpoolexecutor runworker threadpoolexecutor java 1142 at java util concurrent threadpoolexecutor worker run threadpoolexecutor java 617 at java lang thread run thread java 745
prestodbpresto
presto verifier incorrect manual
Bug
presto verifier verifier config property 2016 05 23t14 12 28 722 0900 error main bootstrap uncaught exception in thread main org skife jdbi v2 exception unabletoexecutestatementexception com mysql jdbc exception jdbc4 mysqlsyntaxerrorexception unknown column session property json in field list statement select unknown column session property json not find create table verifier query i d int not null auto increment suite varchar 256 not null name varchar 256 test catalog varchar 256 not null test schema varchar 256 not null test prequeries text test query text not null test postquerie text test username varchar 256 not null default verifier test test password varchar 256 control catalog varchar 256 not null control schema varchar 256 not null control prequerie text control query text not null control postquerie text control username varchar 256 not null default verifier test control password varchar 256 primary key i d presto verifier src main java com facebook presto verifier verifierdao java show the top match last index on 18 mar 41 control password n 42 session property json n 43 from verifier query n 44 where suite suite n presto verifier src main java com facebook presto verifier querypairmapper java show the top match last index on 18 mar 38 string json resultset getstre session property json 39 if json null 40 sessionpropertie propertiesjsoncodec fromjson json change schema create table verifier query i d int not null auto increment suite varchar 256 not null name varchar 256 test catalog varchar 256 not null test schema varchar 256 not null test prequeries text test query text not null test postquerie text test username varchar 256 not null default verifier test test password varchar 256 control catalog varchar 256 not null control schema varchar 256 not null control prequerie text control query text not null control postquerie text control username varchar 256 not null default verifier test control password varchar 256 session property json text append column primary key i d
prestodbpresto
can not chain at time zone
Bug
chain at time zone together result in the error null presto select timestamp 2012 10 31 01 00 at time zone america los angeles at time zone utc query 20160520 185347 00028 kmihc fail null presto can work around this with e g presto with tz la as select timestamp 2012 10 31 01 00 at time zone america los angeles as ts select tz la ts tz la ts at time zone utc from tz la ts col1 2012 10 31 01 00 00 000 america los angeles 2012 10 31 08 00 00 000 utc 1 row query 20160520 185900 00029 kmihc finish 1 node split 1 total 0 do 0 00 0 00 0 row 0b 0 rows s 0b s presto this be on presto 0 146 I believe this work before but I could be mistaken and I haven t have time to bisect I ll follow up if I find more info there
prestodbpresto
over row between unbounded precede and n precede return incorrect result
Bug
the same issue apply to over row between n follow and unbounded follow the actual behavior be presto tiny select nationkey sum regionkey over row between unbounded preceding and 2 precede from nation limit 5 nationkey col1 0 0 1 0 2 0 3 1 4 2 the expect behavior be that this match the behavior of the follow presto tiny select nationkey sum regionkey over row between 3 precede and 2 precede from nation limit 5 nationkey col1 0 null 1 null 2 0 3 1 4 2 postgresql match the expect behavior and return null for the first two row the removal of the first row the part of the sql 2011 standard address the window clause be 7 11 the follow reference be in the general rule section of that part in the case when the first row be the current row nationkey 0 the first row nationkey 0 should be remove from the window frame per rule 5 b ii 2 c ii and be specifically cover by note 223 in the case when the second row be the current row nationkey 1 the first row nationkey 0 should be remove from the window frame per the same rule the current second row nationkey 1 be remove per note 223 as above
prestodbpresto
prepare should overwrite exist name
Bug
I be look at the spec under 20 6 and find this 9 if identify a prepared statement ps then an implicit deallocate prepare ssn be execute where ssn be an that identify ps
prestodbpresto
fix redis hash for date
Bug
the schema for the hash test testredisdistributedhash be change to use date instead of varchar in 31118ab8479707aab098db2fe066931c8c2cd868 but the test fail with that change I revert it in 5313 but we should fix the redis connector so it actually work with date note that those test be disable by default and need to be run in the ide or with the maven ci profile they re also super slow I run the following to test the above pr on my 4 ghz imac and it take over 30 minute mvn clean install dskiptest pl presto redis be mvn clean verify pl presto redis p ci
prestodbpresto
allow empty string as delimiter for split
Enhancement
currently you can not provide an empty string as a delimiter for the split function the error be select split abc query 20160517 035643 07058 prqtw fail the delimiter may not be the empty string the expect behavior be that each character in the string will be it s own value in the array so select split abc col0 a b c 1 row which would be equivalent to array a b c
prestodbpresto
support quantify comparison predicate
Enhancement
from the spec all some any
prestodbpresto
row type hash implementation throw mislead message
Bug
message should say hash be not support for com facebook presto spi prestoexception row comparison not support for field with null element at com facebook presto type rowtype checkelementnotnull rowtype java 216 at com facebook presto type rowtype hash rowtype java 206
prestodbpresto
no implicit coercion in semijoin
Bug
presto tiny explain select orderkey from order where orderkey in value 39301 39330 query plan output orderkey orderkey bigint remoteexchange gather orderkey bigint project orderkey bigint filter semijoin result orderkey bigint semijoin result boolean project orderkey bigint semijoin result boolean semijoin orderkey field orderkey bigint hashvalue bigint semijoin result boolean project orderkey bigint hashvalue bigint orderkey be bigint hashvalue combine hash bigint 0 coalesce operator hash code orderkey 0 tablescan tpch tpch order sf0 01 originalconstraint true orderkey bigint orderkey tpch orderkey remoteexchange repartition field integer hashvalue 6 bigint project field integer hashvalue 7 bigint hashvalue 7 combine hash bigint 0 coalesce operator hash code field 0 value field integer integer 39301 39330 presto tiny select orderkey from order where orderkey in value 39301 39330 query 20160512 175141 00023 e9yg3 fail 4 node split 21 total 6 do 28 57 cpu time 0 0s total 0 rows s 0b s 0 active per node 0 0 parallelism 0 rows s 0b s parallelism 0 0 0 00 0 row 0b 0 rows s 0b s query 20160512 175141 00023 e9yg3 fail expect one bigint parameter java lang illegalargumentexception expect one bigint parameter at com google common base precondition checkargument precondition java 122 at com facebook presto tpch tpchnodepartitioningprovider getbucketfunction tpchnodepartitioningprovider java 82 at com facebook presto sql planner nodepartitioningmanager getpartitionfunction nodepartitioningmanager java 78 at com facebook presto sql planner localexecutionplanner plan localexecutionplanner java 312 at com facebook presto execution sqltaskexecution sqltaskexecution java 157 at com facebook presto execution sqltaskexecution createsqltaskexecution sqltaskexecution java 119 at com facebook presto execution sqltaskexecutionfactory create sqltaskexecutionfactory java 73 at com facebook presto execution sqltask updatetask sqltask java 275 at com facebook presto execution sqltaskmanager updatetask sqltaskmanager java 314 at com facebook presto server taskresource createorupdatetask taskresource java 123 at sun reflect generatedmethodaccessor403 invoke unknown source at sun reflect delegatingmethodaccessorimpl invoke delegatingmethodaccessorimpl java 43 at java lang reflect method invoke method java 498 at org glassfish jersey server model internal resourcemethodinvocationhandlerfactory 1 invoke resourcemethodinvocationhandlerfactory java 81 at org glassfish jersey server model internal abstractjavaresourcemethoddispatcher 1 run abstractjavaresourcemethoddispatcher java 144 at org glassfish jersey server model internal abstractjavaresourcemethoddispatcher invoke abstractjavaresourcemethoddispatcher java 161 at org glassfish jersey server model internal javaresourcemethoddispatcherprovider responseoutinvoker dodispatch javaresourcemethoddispatcherprovider java 160 at org glassfish jersey server model internal abstractjavaresourcemethoddispatcher dispatch abstractjavaresourcemethoddispatcher java 99 at org glassfish jersey server model resourcemethodinvoker invoke resourcemethodinvoker java 389 at org glassfish jersey server model resourcemethodinvoker apply resourcemethodinvoker java 347 at org glassfish jersey server model resourcemethodinvoker apply resourcemethodinvoker java 102 at org glassfish jersey server serverruntime 2 run serverruntime java 326 at org glassfish jersey internal error 1 call error java 271 at org glassfish jersey internal error 1 call error java 267 at org glassfish jersey internal error process error java 315 at org glassfish jersey internal error process error java 297 at org glassfish jersey internal error process error java 267 at org glassfish jersey process internal requestscope runinscope requestscope java 317 at org glassfish jersey server serverruntime process serverruntime java 305 at org glassfish jersey server applicationhandler handle applicationhandler java 1154 at org glassfish jersey servlet webcomponent serviceimpl webcomponent java 473 at org glassfish jersey servlet webcomponent service webcomponent java 427 at org glassfish jersey servlet servletcontainer service servletcontainer java 388 at org glassfish jersey servlet servletcontainer service servletcontainer java 341 at org glassfish jersey servlet servletcontainer service servletcontainer java 228 at org eclipse jetty servlet servletholder handle servletholder java 845 at org eclipse jetty servlet servlethandler cachedchain dofilter servlethandler java 1689 at io airlift http server tracetokenfilter dofilter tracetokenfilter java 63 at org eclipse jetty servlet servlethandler cachedchain dofilter servlethandler java 1676 at io airlift http server timingfilter dofilter timingfilter java 52 at org eclipse jetty servlet servlethandler cachedchain dofilter servlethandler java 1676 at org eclipse jetty servlet servlethandler dohandle servlethandler java 581 at org eclipse jetty server handler scopedhandler handle scopedhandler java 143 at org eclipse jetty server handler gzip gziphandler handle gziphandler java 396 at org eclipse jetty server handler contexthandler dohandle contexthandler java 1176 at org eclipse jetty servlet servlethandler doscope servlethandler java 511 at org eclipse jetty server handler contexthandler doscope contexthandler java 1106 at org eclipse jetty server handler scopedhandler handle scopedhandler java 141 at org eclipse jetty server handler handlercollection handle handlercollection java 119 at org eclipse jetty server handler statisticshandler handle statisticshandler java 169 at org eclipse jetty server handler handlerlist handle handlerlist java 52 at org eclipse jetty server handler handlerwrapper handle handlerwrapper java 134 at org eclipse jetty server server handle server java 518 at org eclipse jetty server httpchannel handle httpchannel java 314 at org eclipse jetty server httpconnection onfillable httpconnection java 253 at org eclipse jetty io abstractconnection readcallback succeed abstractconnection java 273 at org eclipse jetty io fillinterest fillable fillinterest java 95 at org eclipse jetty io selectchannelendpoint 2 run selectchannelendpoint java 93 at org eclipse jetty util thread strategy executeproduceconsume produceandrun executeproduceconsume java 246 at org eclipse jetty util thread strategy executeproduceconsume run executeproduceconsume java 156 at org eclipse jetty util thread queuedthreadpool runjob queuedthreadpool java 654 at org eclipse jetty util thread queuedthreadpool 3 run queuedthreadpool java 572 at java lang thread run thread java 745
prestodbpresto
presto doesn t correctly deal with complex aggregation when argument be also group by column
Bug
hi I might find a bug relate to rollup function could you look into this issue problem rollup function return 0 as total count if count column be use if count be use presto return a correct result postgresql 9 5 2 psql psql 9 5 2 type help for help postgre with test datum as select from postgre value postgre a 1 postgre b 2 postgre a 3 postgre as t i d cnt postgre postgre select i d count as s cnt postgre from test data postgre group by rollup i d postgre i d s cnt a 2 b 1 3 3 row postgre with test datum as select from postgre value postgre a 1 postgre b 2 postgre a 3 postgre as t i d cnt postgre postgre select i d count i d as s cnt postgre from test data postgre group by rollup i d i d s cnt a 2 b 1 3 3 row presto 0 146 with test datum as select from value a 1 b 2 a 3 as t i d cnt select i d count as s cnt from test data group by rollup i d i d s cnt null 3 a 2 b 1 3 row in set the follow sql show this problem null return 0 with test datum as select from value a 1 b 2 a 3 as t i d cnt select i d count i d as s cnt from test data group by rollup i d i d s cnt null 0 a 2 b 1 3 row in set
prestodbpresto
only abort transaction if query actually fail
Bug
a failure after the query complete be not a true query failure this can happen when a limit race with a failure on a node
prestodbpresto
error in year part of date parse
Bug
select date parse 28 jan 16 11 45 46 421000 pm d b y l I s f p col0 1916 01 28 23 45 46 421 1 row year which have to be 2016 be parse as 1916
prestodbpresto
kafka order by partition offset
Enhancement
in the kafka connector it would be nice if the order by partition offset desc could be push down rely on the fact that kafka partition be order example use case read the late 10 message in kafka select from mytable order by partition offset desc limit 10 any plan to support that thank you e
prestodbpresto
add function which convert time timestamp to different timezone
Enhancement
currently presto have at time zone syntax take a time timestamp and a string or time interval literal to convert the time timestamp we don t need to change the semantic of at time zone instead we only need to rename the exist function make they public and update desugaringoptimzer to rewrite at time zone as rename function
prestodbpresto
typo in extract call crash cli
Bug
select extract hou from create time from value 1 exception in thread main java lang illegalargumentexception no enum constant com facebook presto sql tree extract field hou at java lang enum valueof enum java 238 at com facebook presto sql tree extract field valueof extract java 30 at com facebook presto sql parser astbuilder visitextract astbuilder java 978 at com facebook presto sql parser astbuilder visitextract astbuilder java 151 at com facebook presto sql parser sqlbaseparser extractcontext accept sqlbasepars java 6210 at org antlr v4 runtime tree abstractparsetreevisitor visitchildren abstractparsetreevisitor java 70 at com facebook presto sql parser sqlbasebasevisitor visitvalueexpressiondefault sqlbasebasevisitor java 573 at com facebook presto sql parser sqlbaseparser valueexpressiondefaultcontext accept sqlbasepars java 5532 at org antlr v4 runtime tree abstractparsetreevisitor visit abstractparsetreevisitor java 42 at com facebook presto sql parser astbuilder visitpredicate astbuilder java 768 at com facebook presto sql parser astbuilder visitpredicate astbuilder java 151 at com facebook presto sql parser sqlbaseparser predicatedcontext accept sqlbasepars java 5103 at org antlr v4 runtime tree abstractparsetreevisitor visitchildren abstractparsetreevisitor java 70 at com facebook presto sql parser sqlbasebasevisitor visitbooleandefault sqlbasebasevisitor java 496 at com facebook presto sql parser sqlbaseparser booleandefaultcontext accept sqlbasepars java 4809 at org antlr v4 runtime tree abstractparsetreevisitor visitchildren abstractparsetreevisitor java 70 at com facebook presto sql parser sqlbasebasevisitor visitexpression sqlbasebasevisitor java 482 at com facebook presto sql parser sqlbaseparser expressioncontext accept sqlbasepars java 4737 at org antlr v4 runtime tree abstractparsetreevisitor visit abstractparsetreevisitor java 42 at com facebook presto sql parser astbuilder visitselectsingle astbuilder java 489 at com facebook presto sql parser astbuilder visitselectsingle astbuilder java 151 at com facebook presto sql parser sqlbaseparser selectsinglecontext accept sqlbasepars java 3772 at org antlr v4 runtime tree abstractparsetreevisitor visit abstractparsetreevisitor java 42 at java util stream referencepipeline 3 1 accept referencepipeline java 193 at java util arraylist arraylistspliterator foreachremaine arraylist java 1374 at java util stream abstractpipeline copyinto abstractpipeline java 481 at java util stream abstractpipeline wrapandcopyinto abstractpipeline java 471 at java util stream reduceop reduceop evaluatesequential reduceop java 708 at java util stream abstractpipeline evaluate abstractpipeline java 234 at java util stream referencepipeline collect referencepipeline java 499 at com facebook presto sql parser astbuilder visit astbuilder java 1296
prestodbpresto
do not allow raptor table and view name to conflict
Bug
raptor currently allow create a view and table with the same name
prestodbpresto
escape identifier in sql formatter
Bug
identifier that contain space dot etc need to be escape properly with double quote in the sql formatter we should have test for every statement that have an identifier
prestodbpresto
spill to disk
Enhancement
we want presto to handle large or skewed query instead of fail with out of memory error generally speak mechanism should be construct in such way that it be possible to implement spiller to disk hdfs and or to compress memory and use those spiller in all relevant operator currently we want to focus on spill to disk for aggregation operator for which we have create poc spike you can review google doc here and the code be here cc losipiuk ilfrin kokose mattsfuller kbp tdc
prestodbpresto
spill to disk for aggregation
Enhancement
this code have some issue but I think it s some starting point which be worth show before resolve they on our test cluster this poc allow to pass multiple query which be previously fail due to lack of memory for example select avg quantity as aq avg extendedprice as ae avg discount as ad avg tax as at from lineitem group by orderkey order by aq desc ae desc limit 10 some of the issue with this code 1 it only support one spiller plugin in the class path 2 decision what to spill be naive spill everything and during spill block aggregation operator 3 currently spillilng aggregation on array map and row column be not support
prestodbpresto
noclassdeffounderror subnetutil
Bug
I be get the follow error when try to query a hive table use ether 0 145 or 0 141 t be anyone else also face this issue jdk v1 8 0 72 b15 2016 04 26t22 20 24 414 0200 warn hive hive 110 com facebook presto hive util resumabletask resumabletask complete exceptionally java lang noclassdeffounderror com facebook presto hadoop internal org apache commons net util subnetutil at org apache hadoop net netutil isvalidsubnet netutil java 838 at org apache hadoop hdfs dfsclient getlocalinterfaceaddr dfsclient java 741 at org apache hadoop hdfs dfsclient dfsclient java 686 at org apache hadoop hdfs dfsclient dfsclient java 619 at org apache hadoop hdfs distributedfilesystem initialize distributedfilesystem java 149 at org apache hadoop fs prestofilesystemcache createfilesystem prestofilesystemcache java 74 at org apache hadoop fs prestofilesystemcache getinternal prestofilesystemcache java 61 at org apache hadoop fs prestofilesystemcache get prestofilesystemcache java 43 at org apache hadoop fs filesystem get filesystem java 371 at org apache hadoop fs path getfilesystem path java 295 at com facebook presto hive hdfsenvironment getfilesystem hdfsenvironment java 53 at com facebook presto hive backgroundhivesplitloader loadpartition backgroundhivesplitloader java 320 at com facebook presto hive backgroundhivesplitloader loadsplit backgroundhivesplitloader java 232 at com facebook presto hive backgroundhivesplitloader access 500 backgroundhivesplitloader java 71 at com facebook presto hive backgroundhivesplitloader hivesplitloadertask lambda process 0 backgroundhivesplitloader java 188 at java security accesscontroller doprivilege native method at javax security auth subject doas subject java 422 at org apache hadoop security usergroupinformation 3 run usergroupinformation java 1677 at org apache hadoop security assubjectinvoker doas assubjectinvoker java 49 at org apache hadoop security usergroupinformation doas usergroupinformation java 1673 at com facebook presto hive backgroundhivesplitloader hivesplitloadertask process backgroundhivesplitloader java 187 at com facebook presto hive util resumabletask safeprocesstask resumabletask java 45 at com facebook presto hive util resumabletask lambda submit 1 resumabletask java 33 at io airlift concurrent boundedexecutor executeormerge boundedexecutor java 69 at io airlift concurrent boundedexecutor access 000 boundedexecutor java 28 at io airlift concurrent boundedexecutor 1 run boundedexecutor java 40 at java util concurrent threadpoolexecutor runworker threadpoolexecutor java 1142 at java util concurrent threadpoolexecutor worker run threadpoolexecutor java 617 at java lang thread run thread java 745
prestodbpresto
race condition in array concat
Bug
a query like sql select count x from select concat a b x from t where a and b be of type array map string double fail non deterministically with various exception presto version 0 144 2 java lang illegalstateexception closeentry call before anything be write at com facebook presto spi block interleavedblockbuilder closeentry interleavedblockbuilder java 212 at com facebook presto spi block arrayelementblockwriter closeentry arrayelementblockwriter java 127 at com facebook presto spi block abstractarrayblock writepositionto abstractarrayblock java 155 at com facebook presto type maptype appendto maptype java 192 at com facebook presto operator scalar arrayconcatfunction concat arrayconcatfunction java 53 at com facebook presto gen cursorprocessor 37019 project 0 unknown source at com facebook presto gen cursorprocessor 37019 process unknown source at com facebook presto operator scanfilterandprojectoperator getoutput scanfilterandprojectoperator java 215 at com facebook presto operator driver processinternal driver java 380 at com facebook presto operator driver processfor driver java 303 at com facebook presto execution sqltaskexecution driversplitrunner processfor sqltaskexecution java 577 at com facebook presto execution taskexecutor prioritizedsplitrunner process taskexecutor java 529 at com facebook presto execution taskexecutor runner run taskexecutor java 665 at java util concurrent threadpoolexecutor runworker threadpoolexecutor java 1142 at java util concurrent threadpoolexecutor worker run threadpoolexecutor java 617 at java lang thread run thread java 745 query 20160425 183530 20138 n949w fail expect current entry size to be exactly 0 but be 0 java lang illegalstateexception expect current entry size to be exactly 0 but be 0 at com facebook presto spi block arrayblockbuilder beginblockentry arrayblockbuilder java 193 at com facebook presto spi block arrayblockbuilder beginblockentry arrayblockbuilder java 24 at com facebook presto spi block abstractarrayblock writepositionto abstractarrayblock java 146 at com facebook presto type maptype appendto maptype java 192 at com facebook presto operator scalar arrayconcatfunction concat arrayconcatfunction java 53 at com facebook presto gen cursorprocessor 36742 project 0 unknown source at com facebook presto gen cursorprocessor 36742 process unknown source at com facebook presto operator scanfilterandprojectoperator getoutput scanfilterandprojectoperator java 215 at com facebook presto operator driver processinternal driver java 380 at com facebook presto operator driver processfor driver java 303 at com facebook presto execution sqltaskexecution driversplitrunner processfor sqltaskexecution java 577 at com facebook presto execution taskexecutor prioritizedsplitrunner process taskexecutor java 529 at com facebook presto execution taskexecutor runner run taskexecutor java 665 at java util concurrent threadpoolexecutor runworker threadpoolexecutor java 1142 at java util concurrent threadpoolexecutor worker run threadpoolexecutor java 617 at java lang thread run thread java 745 query 20160425 183539 20170 n949w fail expect current entry size to be exactly 0 but be 1 java lang illegalstateexception expect current entry size to be exactly 0 but be 1 at com facebook presto spi block arrayblockbuilder beginblockentry arrayblockbuilder java 193 at com facebook presto spi block arrayblockbuilder beginblockentry arrayblockbuilder java 24 at com facebook presto spi block abstractarrayblock writepositionto abstractarrayblock java 146 at com facebook presto type maptype appendto maptype java 192 at com facebook presto operator scalar arrayconcatfunction concat arrayconcatfunction java 53 at com facebook presto gen cursorprocessor 37840 project 0 unknown source at com facebook presto gen cursorprocessor 37840 process unknown source at com facebook presto operator scanfilterandprojectoperator getoutput scanfilterandprojectoperator java 215 at com facebook presto operator driver processinternal driver java 380 at com facebook presto operator driver processfor driver java 303 at com facebook presto execution sqltaskexecution driversplitrunner processfor sqltaskexecution java 577 at com facebook presto execution taskexecutor prioritizedsplitrunner process taskexecutor java 529 at com facebook presto execution taskexecutor runner run taskexecutor java 665 at java util concurrent threadpoolexecutor runworker threadpoolexecutor java 1142 at java util concurrent threadpoolexecutor worker run threadpoolexecutor java 617 at java lang thread run thread java 745
prestodbpresto
java lang nullpointerexception maxsize be null transient issue
Bug
hi all we re see a very weird issue that only happen in new version of presto here s the setup 50 worker node 1 master node we be use hive connector as follow connector name hive hadoop2 hive metastore uri thrift xxx 9083 hive s3 aw access key xxx hive s3 aws secret key xxx hive parquet use column name true hive recursive directory true we be use external table in hive with datum store in s3 the datum format be parquet we do not experience the problem on presto 128 we be on 144 1 and we do experience this problem this error do not happen all of the time only some of the time here be the error we get the first be the master node the second be the worker com facebook presto operator pagetransporterrorexception expect response code to be 200 but be 500 server error at com facebook presto operator httppagebufferclient pageresponsehandler handle httppagebufferclient java 569 at com facebook presto operator httppagebufferclient pageresponsehandler handle httppagebufferclient java 527 at io airlift http client jetty jettyhttpclient jettyresponsefuture processresponse jettyhttpclient java 797 at io airlift http client jetty jettyhttpclient jettyresponsefuture complete jettyhttpclient java 774 at io airlift http client jetty jettyhttpclient bufferingresponselistener oncomplete jettyhttpclient java 1053 at org eclipse jetty client responsenotifi notifycomplete responsenotifi java 193 at org eclipse jetty client responsenotifi notifycomplete responsenotifi java 185 at org eclipse jetty client httpreceiver terminateresponse httpreceiver java 456 at org eclipse jetty client httpreceiver responsesuccess httpreceiver java 403 at org eclipse jetty client http httpreceiveroverhttp messagecomplete httpreceiveroverhttp java 268 at org eclipse jetty http httpparser parsenext httpparser java 1333 at org eclipse jetty client http httpreceiveroverhttp shutdown httpreceiveroverhttp java 184 at org eclipse jetty client http httpreceiveroverhttp process httpreceiveroverhttp java 131 at org eclipse jetty client http httpreceiveroverhttp receive httpreceiveroverhttp java 69 at org eclipse jetty client http httpchanneloverhttp receive httpchanneloverhttp java 90 at org eclipse jetty client http httpconnectionoverhttp onfillable httpconnectionoverhttp java 114 at org eclipse jetty io abstractconnection readcallback succeed abstractconnection java 273 at org eclipse jetty io fillinterest fillable fillinterest java 95 at org eclipse jetty io selectchannelendpoint 2 run selectchannelendpoint java 93 at org eclipse jetty util thread queuedthreadpool runjob queuedthreadpool java 654 at org eclipse jetty util thread queuedthreadpool 3 run queuedthreadpool java 572 at java lang thread run thread java 745 java lang nullpointerexception maxsize be null at java util object requirenonnull object java 228 at com facebook presto execution sqltaskmanager gettaskresult sqltaskmanager java 287 at com facebook presto server taskresource getresult taskresource java 209 at sun reflect generatedmethodaccessor86 invoke unknown source at sun reflect delegatingmethodaccessorimpl invoke delegatingmethodaccessorimpl java 43 at java lang reflect method invoke method java 497 at org glassfish jersey server model internal resourcemethodinvocationhandlerfactory 1 invoke resourcemethodinvocationhandlerfactory java 81 at org glassfish jersey server model internal abstractjavaresourcemethoddispatcher 1 run abstractjavaresourcemethoddispatcher java 144 at org glassfish jersey server model internal abstractjavaresourcemethoddispatcher invoke abstractjavaresourcemethoddispatcher java 161 at org glassfish jersey server model internal javaresourcemethoddispatcherprovider voidoutinvoker dodispatch javaresourcemethoddispatcherprovider java 143 at org glassfish jersey server model internal abstractjavaresourcemethoddispatcher dispatch abstractjavaresourcemethoddispatcher java 99 at org glassfish jersey server model resourcemethodinvoker invoke resourcemethodinvoker java 389 at org glassfish jersey server model resourcemethodinvoker apply resourcemethodinvoker java 347 at org glassfish jersey server model resourcemethodinvoker apply resourcemethodinvoker java 102 at org glassfish jersey server serverruntime 2 run serverruntime java 326 at org glassfish jersey internal error 1 call error java 271 at org glassfish jersey internal error 1 call error java 267 at org glassfish jersey internal error process error java 315 at org glassfish jersey internal error process error java 297 at org glassfish jersey internal error process error java 267 at org glassfish jersey process internal requestscope runinscope requestscope java 317 at org glassfish jersey server serverruntime process serverruntime java 305 at org glassfish jersey server applicationhandler handle applicationhandler java 1154 at org glassfish jersey servlet webcomponent serviceimpl webcomponent java 473 at org glassfish jersey servlet webcomponent service webcomponent java 427 at org glassfish jersey servlet servletcontainer service servletcontainer java 388 at org glassfish jersey servlet servletcontainer service servletcontainer java 341 at org glassfish jersey servlet servletcontainer service servletcontainer java 228 at org eclipse jetty servlet servletholder handle servletholder java 845 at org eclipse jetty servlet servlethandler cachedchain dofilter servlethandler java 1689 at io airlift http server tracetokenfilter dofilter tracetokenfilter java 63 at org eclipse jetty servlet servlethandler cachedchain dofilter servlethandler java 1676 at io airlift http server timingfilter dofilter timingfilter java 52 at org eclipse jetty servlet servlethandler cachedchain dofilter servlethandler java 1676 at org eclipse jetty servlet servlethandler dohandle servlethandler java 581 at org eclipse jetty server handler scopedhandler handle scopedhandler java 143 at org eclipse jetty server handler gzip gziphandler handle gziphandler java 389 at org eclipse jetty server handler contexthandler dohandle contexthandler java 1162 at org eclipse jetty servlet servlethandler doscope servlethandler java 511 at org eclipse jetty server handler contexthandler doscope contexthandler java 1092 at org eclipse jetty server handler scopedhandler handle scopedhandler java 141 at org eclipse jetty server handler handlercollection handle handlercollection java 119 at org eclipse jetty server handler statisticshandler handle statisticshandler java 169 at org eclipse jetty server handler handlerlist handle handlerlist java 52 at org eclipse jetty server handler handlerwrapper handle handlerwrapper java 134 at org eclipse jetty server server handle server java 518 at org eclipse jetty server httpchannel handle httpchannel java 308 at org eclipse jetty server httpconnection onfillable httpconnection java 244 at org eclipse jetty io abstractconnection readcallback succeed abstractconnection java 273 at org eclipse jetty io fillinterest fillable fillinterest java 95 at org eclipse jetty io selectchannelendpoint 2 run selectchannelendpoint java 93 at org eclipse jetty util thread queuedthreadpool runjob queuedthreadpool java 654 at org eclipse jetty util thread queuedthreadpool 3 run queuedthreadpool java 572 at java lang thread run thread java 745 with the follow query select a event a total b total as total lastmonth round cast a total as double cast b total as double 1 0 4 as percentage from select event case when low event x then count when low event in x x x then count distinct uid else null end as total from x event where date between cast date add day day current date 1 current date as varchar and cast date add day 1 current date as varchar and low event in x x x x group by event as a left join select event case when low event x then count when low event in x x x then count distinct uid else null end as total from x event where date between cast date add day day current date 2 date add month 1 date add day 1 current date as varchar and cast date add month 1 date add day 1 current date as varchar and low event in x x x x group by event as b on low a event low b event order by a event any idea thank
prestodbpresto
feature request show schemas like pattern
Enhancement
hive support show database like pattern languagemanualddl showdatabase it would be nice if presto support something similar show schema like pattern I see that show table already support a like pattern clause so hopefully it win t be too hard to extend that to show database as well
prestodbpresto
optimize union all of similar aggregation
Enhancement
query of the follow shape sql select a1 an agg1 agg2 from t where f1 union all select b1 bn agg3 agg4 from t where f2 a1 an b1 bn be constant can be optimize to process all the datum in a single pass to reduce the number of stage in the query execution one possible rewrite could be sql select from unnest select array row a1 an agg1 filter where f1 agg2 filter where f1 row b1 bn agg3 filter where f2 agg3 filter where f2 from t u
prestodbpresto
add support for filter aggregation syntax
Enhancement
from the sql spec filter where a shall not contain a a or an outer reference 2 let t be the argument source of af 3 a if be specify then the be effectively evaluate for each row of t let t1 be the collection of row of t for which the result of the be true the follow query sql select agg x filter where f y from t be semantically equivalent to this query if the aggregation ignore null sql select agg if f y x from t if the aggregation be sensitive to null the filter need to be apply before the value be feed into the aggregation function this could be achieve via the masking mechanism support by aggregation operator
prestodbpresto
add well type check to plansanitychecker
Enhancement
we need to make sure the type of input and output match each other and what the user type in this will prevent issue like 5075
prestodbpresto
map type literal syntax
Enhancement
when write literal map s with more than a few field my query become very difficult to read especially if the value of the map be complex map array array even if I break up the key and value into separate line when read the query I have to manually associate which key map to which value be there room for a literal syntax for map s in presto after peruse the sql standard I can t find anything that say don t add custom syntax of course this doesn t mean we should add it but I would love to get thought on make it easy to read more complex map construction personally I m a fan of the syntax of python s dictionary view display for set and dictionary sql select a sum stuff b avg other stuff but I d settle for anything that make complex map more readable
prestodbpresto
date constructor should handle year 0 correctly
Bug
year zero be convert to january 2nd of 1 ad presto select date 0000 12 31 col0 0001 01 02 1 row it should be reject similar to other invalid date presto select date 2015 02 29 query fail value can not be cast to date 2015 02 29 presto select date 2016 12 32 query fail value can not be cast to date 2016 12 32
prestodbpresto
use proper error code for bucket error
Bug
we should use a new error code in backgroundhivesplitloader listandsortbucketfile something like hive invalid bucket file
prestodbpresto
testverticalwidecharactervalue fail with lang or file encoding set to non utf 8
Bug
set the lang env variable or file encoding to anything other than utf 8 cause this test to fail java lang assertionerror expect record 1 name hello bye but find record 1 name hello bye at org testng assert fail assert java 94 at org testng assert failnotequal assert java 494 at org testng assert assertequal assert java 123 at org testng assert assertequal assert java 176 at org testng assert assertequal assert java 186 at com facebook presto cli testverticalrecordprinter testverticalwidecharactervalue testverticalrecordprinter java 159 at sun reflect nativemethodaccessorimpl invoke0 native method at sun reflect nativemethodaccessorimpl invoke nativemethodaccessorimpl java 62 at sun reflect delegatingmethodaccessorimpl invoke delegatingmethodaccessorimpl java 43 at java lang reflect method invoke method java 498 at org testng internal methodinvocationhelper invokemethod methodinvocationhelper java 85 at org testng internal invoker invokemethod invoker java 696 at org testng internal invoker invoketestmethod invoker java 882 at org testng internal invoker invoketestmethod invoker java 1189 at org testng internal testmethodworker invoketestmethod testmethodworker java 124 at org testng internal testmethodworker run testmethodworker java 108 at org testng testrunner privaterun testrunner java 767 at org testng testrunner run testrunner java 617 at org testng suiterunner runtest suiterunner java 348 at org testng suiterunner runsequentially suiterunner java 343 at org testng suiterunner privaterun suiterunner java 305 at org testng suiterunner run suiterunner java 254 at org testng suiterunnerworker runsuite suiterunnerworker java 52 at org testng suiterunnerworker run suiterunnerworker java 86 at org testng testng runsuitessequentially testng java 1224 at org testng testng runsuiteslocally testng java 1149 at org testng testng run testng java 1057 at org testng idearemotetestng run idearemotetestng java 74 at org testng remotetestngstarter main remotetestngstarter java 121 at sun reflect nativemethodaccessorimpl invoke0 native method at sun reflect nativemethodaccessorimpl invoke nativemethodaccessorimpl java 62 at sun reflect delegatingmethodaccessorimpl invoke delegatingmethodaccessorimpl java 43 at java lang reflect method invoke method java 498 at com intellij rt execution application appmain main appmain java 144
prestodbpresto
sequence function to generate synthetic array
Enhancement
something like sequence from bigint to bigint array bigint sequence from int to int array int sequence 1 10 1 2 3 4 5 6 7 8 9 10
prestodbpresto
testselectpartitionedhivetabledifferentformat be flaky
Bug
just run this test on my box 200 time and see no failure however travis keep randomly fail on this test I m also not sure what it s really mean to test
prestodbpresto
record presto version when write table partition
Enhancement
this can be useful to track down potentially incorrect datum due to bug in specific presto version for hive it could be store in a table property
prestodbpresto
handle hive orc use column name for empty file
Bug
the hive orc writer create the output file lazily if there be no row the close method create a file without any column new hive version create a zero byte file this cause issue for hive orc use column name we should fix the column handle code to account for these empty file additionally for non bucketed table the writer code could delete the file if no row write since the file have no purpose
prestodbpresto
need a way to produce empty approx set
Enhancement
approx set currently produce null if there be no input value arguably this be wrong but it s consistent with the behavior of sum avg etc although not with count we need a way to represent empty approx set a couple of alternative change approx set to return an empty set if there s no input introduce an approx empty set function that can be use to substitute null via coalesce coalesce approx set empty approx set both
prestodbpresto
add float type
Enhancement
similar to and there should be native support for float as well
prestodbpresto
support intersect
Enhancement
java sql sqlexception query fail 20160329 122015 00073 tc92r line 410 11 intersect not yet implement at com facebook presto jdbc prestoresultset resultsexception prestoresultset java 1824 at com facebook presto jdbc prestoresultset getcolumn prestoresultset java 1773 at com facebook presto jdbc prestoresultset prestoresultset java 142 at com facebook presto jdbc prestostatement execute prestostatement java 193 at com facebook presto jdbc prestostatement executequery prestostatement java 68 at com teradata benchto driver execution queryexecutiondriver executeselectquery queryexecutiondriver java 59
prestodbpresto
non deterministic test failure in testraptordistributedquerie testcreatebucketedtable
Bug
this test seem to fail about 1 in 5000 run java lang assertionerror not equal actual 1 row 75 expect 1 row 100 at org testng assert fail assert java 94 at com facebook presto test queryassertion assertequalsignoreorder queryassertion java 132 at com facebook presto test queryassertion assertquery queryassertion java 120 at com facebook presto test abstracttestqueryframework assertquery abstracttestqueryframework java 106 at com facebook presto raptor testraptordistributedquerie testcreatebucketedtable testraptordistributedquerie java 138
prestodbpresto
support a pluggable authentication mechanism
Enhancement
to support authenticate user against different system it would be nice if presto could support a pluggable authentication mechanism a use case where this can be useful be to have iam role support for s3 access see 2640 a custom s3 authentication module will then authenticate the user use his her iam role and pass the principal back to presto which should be pass all the way down to the filesystem cc martint base on our brief discussion at the meetup
prestodbpresto
print server version before verifier run
Enhancement
have the server version from system runtime nod readily available can help troubleshoot error during verifier run
prestodbpresto
can not insert null into table without explicit cast
Bug
sql create table test a bigint insert into test a value null query 20160331 004854 02765 vpwmu fail insert query have mismatch column type table bigint query unknown com facebook presto sql analyzer semanticexception insert query have mismatch column type table bigint query unknown at com facebook presto sql analyzer statementanalyzer visitinsert statementanalyzer java 583 at com facebook presto sql analyzer statementanalyzer visitinsert statementanalyzer java 219 at com facebook presto sql tree insert accept insert java 61 at com facebook presto sql tree astvisitor process astvisitor java 22 at com facebook presto sql analyzer analyzer analyze analyzer java 60 at com facebook presto execution sqlqueryexecution doanalyzequery sqlqueryexecution java 269 at com facebook presto execution sqlqueryexecution analyzequery sqlqueryexecution java 255 at com facebook presto execution sqlqueryexecution start sqlqueryexecution java 219 at com facebook presto execution queuedexecution lambda start 1 queuedexecution java 68 at java util concurrent threadpoolexecutor runworker threadpoolexecutor java 1142 at java util concurrent threadpoolexecutor worker run threadpoolexecutor java 617 at java lang thread run thread java 745
prestodbpresto
support except
Enhancement
sql value 1 except value 2 com facebook presto sql analyzer semanticexception line 1 12 except not yet implement at com facebook presto sql analyzer statementanalyzer visitexcept statementanalyzer java 1098 at com facebook presto sql analyzer statementanalyzer visitexcept statementanalyzer java 219 at com facebook presto sql tree except accept except java 68 at com facebook presto sql tree astvisitor process astvisitor java 22 at com facebook presto sql analyzer statementanalyzer visitquery statementanalyzer java 810 at com facebook presto sql analyzer statementanalyzer visitquery statementanalyzer java 219 at com facebook presto sql tree query accept query java 103 at com facebook presto sql tree astvisitor process astvisitor java 22 at com facebook presto sql analyzer analyzer analyze analyzer java 60 at com facebook presto execution sqlqueryexecution doanalyzequery sqlqueryexecution java 269 at com facebook presto execution sqlqueryexecution analyzequery sqlqueryexecution java 255 at com facebook presto execution sqlqueryexecution start sqlqueryexecution java 219 at com facebook presto execution queuedexecution lambda start 1 queuedexecution java 68 at java util concurrent threadpoolexecutor runworker threadpoolexecutor java 1142 at java util concurrent threadpoolexecutor worker run threadpoolexecutor java 617
prestodbpresto
error during analysis in group by query with at timezone
Bug
sql select min x at time zone america chicago from value now t x java lang unsupportedoperationexception aggregation analysis not yet implement for com facebook presto sql tree attimezone at com facebook presto sql analyzer aggregationanalyzer visitor visitexpression aggregationanalyzer java 150 at com facebook presto sql analyzer aggregationanalyzer visitor visitexpression aggregationanalyzer java 144 at com facebook presto sql tree astvisitor visitattimezone astvisitor java 542 at com facebook presto sql tree attimezone accept attimezone java 59 at com facebook presto sql tree astvisitor process astvisitor java 22 at com facebook presto sql analyzer aggregationanalyzer visitor process aggregationanalyzer java 455 at com facebook presto sql analyzer aggregationanalyzer analyze aggregationanalyzer java 139 at com facebook presto sql analyzer statementanalyzer verifyaggregations statementanalyzer java 1791 at com facebook presto sql analyzer statementanalyzer analyzeaggregation statementanalyzer java 1749 at com facebook presto sql analyzer statementanalyzer visitqueryspecification statementanalyzer java 1022 at com facebook presto sql analyzer statementanalyzer visitqueryspecification statementanalyzer java 219 at com facebook presto sql tree queryspecification accept queryspecification java 125 at com facebook presto sql tree astvisitor process astvisitor java 22 at com facebook presto sql analyzer statementanalyzer visitquery statementanalyzer java 810 at com facebook presto sql analyzer statementanalyzer visitquery statementanalyzer java 219 at com facebook presto sql tree query accept query java 103 at com facebook presto sql tree astvisitor process astvisitor java 22 at com facebook presto sql analyzer analyzer analyze analyzer java 60 at com facebook presto execution sqlqueryexecution doanalyzequery sqlqueryexecution java 269 at com facebook presto execution sqlqueryexecution analyzequery sqlqueryexecution java 255 at com facebook presto execution sqlqueryexecution start sqlqueryexecution java 219 at com facebook presto execution queuedexecution lambda start 1 queuedexecution java 68 at java util concurrent threadpoolexecutor runworker threadpoolexecutor java 1142 at java util concurrent threadpoolexecutor worker run threadpoolexecutor java 617 at java lang thread run thread java 745
prestodbpresto
try cast fail with multiple predicate in a where clause
Bug
when I run the follow query sql with example as select i d other i d from value 1 23452 3 2354 as t i d other i d select try cast other i d as bigint as other i d from example where i d 1 and try cast other i d as bigint be not null it produce the error message compiler fail and interpreter be disable when I remove the i d 1 in the final query the query work as expect