repository
stringclasses
156 values
issue title
stringlengths
1
1.01k
labels
stringclasses
8 values
body
stringlengths
1
270k
prestodbpresto
potential deadlock when use phase scheduler with broadcast join
Bug
sql select from orders cross join value 1 fragment 0 single output layout ord...
prestodbpresto
intermediate aggregation not be apply with union all
Enhancement
this be as simplify as I ve be able to get it we ve get two hdfs back table in parquet hive catalog presto evs describe all event monthly column type comment month partition varchar partition key app partitio...
prestodbpresto
java cli parse type signature from string for each value
Enhancement
the java cli parse the type signature over and over again for each value in the output perf show that under high output rate the cli spend more than 8 of the cpu on this operation since the output schema be fix we should only need to parse each type exactly once here be the perf output 8 30 java ...
prestodbpresto
error when coerce varchar in map
Enhancement
select from value map array test array 1 map array test2 array 1 throw an exception can not cast map varchar 4 bigint to map varchar 5 bigint I think we need to implement cast operator for map to map in order to make it work array type work as expect because there be arra...
prestodbpresto
support for column alias in with clause
Enhancement
sql with a x as value 1 2 3 select from a query 20160316 210951 08931 ukuwz fail line 1 6 column alia not support in with query com facebook presto sql analyzer semanticexception line 1 6 column alia not support in with query at com facebook presto sql analyzer statementanalyzer an...
prestodbpresto
raptor system shard table need to ignore miss index table
Bug
the distribute test can fail due to this race condition com facebook presto spi prestoexception fail to perform metadata operation at com facebook presto raptor util databaseutil metadataerror databaseutil java 68 at com facebook presto raptor systemtables shardmetadatarecordcursor getnextresultset ...
prestodbpresto
join use do not work with a self join
Bug
presto tiny explain select from order join order use orderkey query 20160314 204230 00004 guj48 fail line 1 23 relation appear more than once order com facebook presto sql analyzer semanticexception line 1 23 relation appear more than once order at com facebook presto sql analyzer s...
prestodbpresto
uncategorized error for orcinputstream
Bug
java lang indexoutofboundsexception end index 3737344 must not be great than size 13 at io airlift slice precondition checkpositionindexe precondition java 94 at io airlift slice slice checkindexlength slice java 1194 at io airlift slice slice slice slice java 748 at io airlift slic...
prestodbpresto
failure in phase scheduler
Bug
java lang unsupportedoperationexception not yet implement com facebook presto sql planner plan exchangenode at com facebook presto execution scheduler phasedexecutionschedule visitor visitplan phasedexecutionschedule java 282 at com facebook presto execution scheduler phasedexecutionschedule visitor...
prestodbpresto
improve error message for arrayslicefunction
Enhancement
pass 0 as the index produce a cryptic invalid start index error pass a negative value for length produce invalid array length suggestion sql array index start at 1 to be consistent with the error that occur when try to dereference array index 0 length must be great than or equal to 0
prestodbpresto
add optimization for join criterion that evaluate to false
Enhancement
there be a number of optimization that can be apply if the join criterion optimize to the false expression for example an inner join can be replace with a value node an outer join can be replace with a project node etc
prestodbpresto
implicit coercion not add for expression involve scalar subquery
Bug
sql select 1 0 select 1 fail with query 20160304 012302 02354 wqvkp fail operator divide double bigint double not find com facebook presto spi prestoexception operator divide double bigint double not find at com facebook presto metadata functionregistry getscalarfunctionimplementati...
prestodbpresto
assumption violation in predicatepushdown join predicate to be a valid join equality
Bug
example 20160303 003528 01426 vsmfh expect join predicate to be a valid join equality java lang illegalstateexception com google common base precondition checkstate precondition java 173 com facebook presto sql planner optimization predicatepushdown rewriter visitjoin predicatepushdown java 340 com facebook ...
prestodbpresto
invalid plan for order by expression that refer to output column
Bug
the follow query produce an incorrect plan it resolve a in the order by clause with respect to the from clause but it should be use the output column from the select clause instead sql select 10 a as a from value 1 2 3 t a order by 10 a this be the result plan presto explain sel...
prestodbpresto
provide more context for error message
Enhancement
suppose one of the cast in this query fail sql select cast a as bigint cast b as bigint from it would be helpful if the error message could indicate which expression fail similar to what we do for syntax error
prestodbpresto
mergeprojection duplicate non deterministic expression
Bug
for example presto tiny explain select r r 1 from select rand r from order query plan output r col1 ...
prestodbpresto
add custom pagesink for orc
Enhancement
the orc writer from hive be inefficient for presto to use since it be row orient and require java object
prestodbpresto
add show create table
Enhancement
this should display the sql necessary to create a table example presto show create table hive default foo create table hive default foo x bigint ds varchar with format orc partition by array ds
prestodbpresto
raptor exception during rollback
Bug
2016 02 21t11 33 58 635 0800 error 20160221 192849 19922 hcaf5 1 235 0 29308 com facebook presto operator driver error closing operator 1 for task 20160221 192849 19922 hcaf5 1 235 java lang runtimeexception exception during rollback at com facebook presto raptor raptorpagesink abort ...
prestodbpresto
uncategorized error for raptor system table
Bug
the catch block need to be catch sqlexception dbiexception e org skife jdbi v2 exception unabletoobtainconnectionexception com mysql jdbc exception jdbc4 mysqlsyntaxerrorexception at org skife jdbi v2 dbi open dbi java 230 at com facebook presto raptor systemtable shardmetadatarecordcur...
prestodbpresto
add convenience function date
Enhancement
this function date x should be the same as cast x as date
prestodbpresto
addcolumntask check for exist column should be case insensitive
Bug
I think the containskey element getname need to be element getname tolowercase english this need a test like this sql create table test foo bigint alter table test add column foo bigint
prestodbpresto
cast of min long fail with json deserialization error
Bug
presto select cast 9223372036854775808 as bigint query 20160218 180120 08825 82xht fail unable to create class com facebook presto execution taskinfo from json response io airlift jaxrs jsonmapperparsingexception invalid json for java type com facebook presto server taskupdaterequ at io airlif...
prestodbpresto
tableau connector feature request
Enhancement
presto web service connector can help create tableau extract but the incremental update be not available as fas as I understand we need to specify the list of field that can be use to detect datum change in order to make an incremental update before connect to the web service datum in case of presto connector we do...
prestodbpresto
in memory join
Enhancement
pull request address after profile and investigate the problematic function be com facebook presto operator pageshashstrategy positionequalsposition which be take up over 90 time of com facebook presto operator inmemoryjoinhash inmemoryjoinhash this pull request consist of two fix which one speed up ...
prestodbpresto
add support for null treatment in lag lead
Enhancement
iso sql provide a null treatment clause to respect null or ignore null while compute currently presto s implementation of those function do not support this concept
prestodbpresto
duplication of column order specification
Bug
a query which emit duplication of order term will encounter an error select rank over order by c1 c3 c3 from x y z error query fail 20160215 152308 08739 tff7r orderby and ordering size don t match
prestodbpresto
unbounded varchar should not be serialize with length
Bug
the fact that varchar be internally represent as varchar max int be an implementation detail that should not leak out and be permanently store in external system it also break backwards compatibility with old client cause issue in client that try to allocate a buffer of that size etc
prestodbpresto
cast of varchar x varchar y should fail on truncation
Bug
per the spec 6 13 general rule 11 c 11 if td be variable length character string or large object character string then let mltd be the maximum length in character of td c if sd be fix length character string variable length character string or large object character string then ii if the le...
prestodbpresto
timezonenotsupportedexception should extend prestoexception
Bug
timezonenotsupportedexception should extend prestoexception and use the not support error code also we should change the error string so the zone be at the end java time zone not support zoneid
prestodbpresto
uncategorized error in random
Bug
the bind should be validate with checkcondition bind must be positive java lang illegalargumentexception java util concurrent threadlocalrandom nextlong threadlocalrandom java 403 com facebook presto operator scalar mathfunction random mathfunction java 251 com facebook presto gen pageprocessor 58535 p...
prestodbpresto
uncategorized error in informationschemapagesourceprovider buildpartition
Bug
table do not exist java lang illegalargumentexception com google common base precondition checkargument precondition java 145 com facebook presto connector informationschema informationschemapagesourceprovider buildpartition informationschemapagesourceprovider java 244 com facebook presto connector inform...
prestodbpresto
error in from utf8 invalid code point
Bug
invalid code point 0xd800 io airlift slice invalidcodepointexception io airlift slice sliceutf8 setcodepointat sliceutf8 java 895 io airlift slice sliceutf8 fixinvalidutf8 sliceutf8 java 426 io airlift slice sliceutf8 fixinvalidutf8 sliceutf8 java 388 com facebook presto operator scalar stringfunction fromut...
prestodbpresto
should not allow create view with unknown column type
Bug
this should be disallow since the type of column foo be unknown create view xyz as select null as foo it currently succeed the schema result schema be presto desc xyz column type comment foo unknown 1 row
prestodbpresto
error scalar node can output only one symbol
Bug
scalar node can output only one symbol but get reason 9 hashvalue java lang illegalargumentexception com google common base precondition checkargument precondition java 145 com facebook presto sql planner plan enforcesinglerownode enforcesinglerownode java 42 com facebook presto sql planner plan chil...
prestodbpresto
uncategorized error in datetimefunction
Bug
all of the method in datetimefunction that pass a user specify format string to joda time should transform illegalargumentexception see dateparse in that class for an example illegal pattern component I java lang illegalargumentexception org joda time format datetimeformat parsepatternto dateti...
prestodbpresto
error row number bigint be not a scalar function
Bug
row number bigint be not a scalar function java lang illegalargumentexception com google common base precondition checkargument precondition java 145 com facebook presto metadata functionregistry getscalarfunctionimplementation functionregistry java 555 com facebook presto sql planner expressioninterpreter ...
prestodbpresto
multichannelgroupbyhash error expect null value for unknowntype
Bug
expect null value for unknowntype java lang illegalargumentexception com google common base precondition checkargument precondition java 122 com facebook presto type unknowntype hash unknowntype java 51 com facebook presto gen pageshashstrategy hashrow unknown source com facebook presto operator multicha...
prestodbpresto
uncategorized error orcrecordreader indexoutofboundsexception
Bug
index 0 size 0 java lang indexoutofboundsexception java util arraylist rangecheck arraylist java 653 java util arraylist get arraylist java 429 java util collection unmodifiablelist get collection java 1309 com facebook presto orc reader liststreamreader readblock liststreamreader java 123 com facebo...
prestodbpresto
uncategorized error array creation from cast
Bug
array type expect exactly one type as a parameter get java lang illegalargumentexception com google common base precondition checkargument precondition java 145 com facebook presto type arrayparametrictype createtype arrayparametrictype java 43 com facebook presto type typeregistry instantiateparametrict...
prestodbpresto
npe with in null predicate for varchar column
Bug
this query select count from value a t a where a in null fail with java lang nullpointerexception value be null at java util object requirenonnull object java 228 at com facebook presto spi predicate nullablevalue of nullablevalue java 44 at com facebook presto sql...
prestodbpresto
support username pass as a parameter in uri
Enhancement
I m set the user property in the url jdbc presto xxxxxx us west 2 compute amazonaw com 8889 user sonicd but driver still complain error java sql sqlexception username property user must be set at com facebook presto jdbc prestodriver connect prestodriver java 86 at java sql drivermanage...
prestodbpresto
fix hive alreadyexist exception
Bug
this class tablealreadyexistsexception and viewalreadyexistsexception should extend prestoexception directly and use already exist as the error code
prestodbpresto
add retrie for loadrole and loadtableprivilege in hive connector
Enhancement
make these work like all other metastore call
prestodbpresto
categorize error for negative approx percentile weight
Bug
all the input method in approximatelongpercentileaggregation that take a weight should validate that it be 0 with an error like percentile weight must be 0 use a share helper method so the error message isn t repeat that call checkcondition java lang illegalargumentexception count must...
prestodbpresto
validate column order when create hive table
Bug
partition column for hive table be always at the end because hive work that way when create a table the creation should fail if the column be not in the final order have create table silently rearrange column be quite unexpected we should use a new error code for this hive column order mismatch this...
prestodbpresto
support aggregation for interval
Enhancement
both interval type should support these aggregation sum avg approx percentile corr covar pop covar samp regr intercept regr slope stddev samp and stddev stddev pop var samp and variance ...
prestodbpresto
web ui query detail view doesn t show content at safari after 0 133
Bug
web ui doesn t seem to work anymore at 0 133 in safari 9 0 3 as it use javascript lambda expression it look fine in chrome 47 0 2526 and firefox 43 0 4 screen shoot 2016 01 22 at 1 31 08 pm 2179a69429124fbac0cf549003adf074
prestodbpresto
leverage transaction support in hive connector to model insert overwrite
Enhancement
a delete follow by an insert in a transaction should defer the call to the metastore to delete the table until after the temporary datum for the insert have be generate this help reduce the time gap between the partition be delete and the new one be register and protect against issue where the delete execute successf...
prestodbpresto
add support for row type for in expression
Enhancement
these form should be support select from order where orderkey custkey in value 1 1 2 2 3 3 select from order where orderkey custkey in 1 1 2 2 3 3 null semantic make this particularly tricky to implement we may want to consider add support in phase whe...
prestodbpresto
fix equal hashcode tostring for showschema
Bug
catalog should be use by all of these method but be not
prestodbpresto
performance regression in map dereference
Bug
between 0 132 and 0 133 query with a map dereference be over 10x slow the map type be map
prestodbpresto
use same window operator for same partitioning and order
Enhancement
consider a query like this sql select sum length value over row between 1 precede and 3 precede sum length value over row between 2 precede and 4 precede from src it produce a plan like this project sum bigint sum 4 bigint ...
prestodbpresto
add raptor system table for table property
Enhancement
we need to expose temporal column order column and bucket information need to think about the schema for this
prestodbpresto
need way to monitor progress for insert query via jdbc
Enhancement
the execute call in the jdbc driver block until the query complete we need a way for the client to monitor progress
prestodbpresto
make retry policy when read write to hdfs adaptive
Enhancement
query that have be run for long I e non interactive should do more retrie when encounter error read and write to hdfs
prestodbpresto
add header to allow setting read only mode for autocommit
Enhancement
we should have a header name something like x presto read only that start the autocommit transaction in read only mode client can use this to improve safety and performance if they will only be run select the request to statementresource should fail if this be set during a transaction or be use with start...
prestodbpresto
do not allow call procedure in read only mode
Bug
calltask should have an additional check to prevent run a procedure in read only mode since the expect use of procedure be to modify some system or connector state this probably require another method isreadonly add to querystatemachine that delegate to some additional method in transactionmanager ...
prestodbpresto
improve certain type of insert query mismatch column type error
Enhancement
some case that could be improve with specialized error insert query have additional column insert query be miss column column list length be identical but at least one position have mismatch type the error message should include the column name of the target table and the position that have a mismatch if ...
prestodbpresto
add information about acquire wait on permit to ui
Enhancement
the query detail page should list all the permit the query have acquire or be wait to acquire if it s currently queue in the main page query that be in the queued state should show the permit they be wait to acquire
prestodbpresto
add session property for metadataqueryoptimizer
Enhancement
currently the optimizer can only the activate via a global configuration option we should add a session property to be able to turn it on for specific query
prestodbpresto
create ast node to represent at time zone expression
Enhancement
currently the parser translate they into function invocation of an internal at timezone function this make it hard to roundtrip through the parser and formatter or to synthesize a query that use this feature by build its ast and run it via the formatter
prestodbpresto
raptor shard system table have bogus min max timestamp for date column
Bug
the table have a temporal column of type date with a range of 2015 12 31 to 2016 01 01 but the min max timestamp be report as 16 00 16 800 and 1969 12 31 16 00 16 801
prestodbpresto
add transaction info to ui
Enhancement
specifically transaction in visibility level and readonly flag
prestodbpresto
add start to non reserve word
Bug
the change to add transaction support break support for parse the word start it need to be add to the non reserve word presto select 1 as start fail with query 20160102 200936 00000 pvvtp fail line 1 13 no viable alternative at input start com facebook presto sql parser parsingexc...
prestodbpresto
view be stale immediately after creation
Bug
presto version be presto server 0 123 user my config connector name hive cdh5 hive metastore uri thrift hadoop1 9083 1 I operate create view view nginx log as 2 create or replace view view nginx log as select ip user time line no from select ip user t...
prestodbpresto
implement element at for map
Enhancement
it should have the signature element at x k v and allow you to have query like this select element at m foo bar element at m na null from value map array foo array bar as t m
prestodbpresto
implement explain analyze
Enhancement
this should work similarly to postgresql by execute the query recording stat and then render the stat along with the plan a first pass at implement this could probably be to render similarly to explain type distribute with the stage operator stat insert
prestodbpresto
hive insert create file with the wrong datum type
Bug
presto write the datum to the file as a bigint but the partition column type be int hive create table if not exist test presto int dummy int name string partition by ds string presto insert into test presto int select 3 as dummy abc as name 2015 12 21 as ds hive describe for...
prestodbpresto
support insert for jdbc connector mysql and postgresql
Enhancement
this should create a temporary table with the same schema as the target table then all the worker write into the temporary table and the commit operation do a single atomic insert select
prestodbpresto
exception in sqlqueryscheduler
Bug
this happen when I run the query while the cluster be start probably before any of the worker be online java lang indexoutofboundsexception index 0 size 0 at java util arraylist rangecheck arraylist java 653 at java util arraylist get arraylist java 429 at com facebook presto execution...
prestodbpresto
ab return the wrong value for long min value
Bug
iso 9075 2 section 2 28 8 c otherwise the result be 1 n if 1 n be not representable by the result data type then an exception condition be raise datum exception numeric value out of range we should add a new user error numeric value out of range
prestodbpresto
query fail with position tracker be close
Bug
java lang illegalstateexception position tracker be close at com google common base precondition checkstate precondition java 173 at com facebook presto operator lookupouteroperator outerpositiontracker visit lookupouteroperator java 394 at com facebook presto operator lookupouteroperator outerl...
prestodbpresto
raptor table and view name can overlap
Bug
they should be in the same namespace and not overlap
prestodbpresto
support view in jdbc connector
Bug
I think the problem be that the gettable method in basejdbcclient need to include view in the list of type pass to databasemetadata gettable
prestodbpresto
insert into partitioned table fail with npe if partition column not populate
Bug
sql create table t x varchar y varchar with partition by array y sql insert into t x value a java lang nullpointerexception at java util stream referencepipeline 3 1 accept referencepipeline java 193 at java util spliterator arrayspliterator for...
prestodbpresto
throw exception when use session command from jdbc
Bug
we can consider support these in addition to the setsessionproperty method on prestoconnection but at the very least we should throw an exception rather than silently ignore they
prestodbpresto
the node i d column in delete shard node should not be nullable
Bug
the table track shard for a node so it should be not null be nullable be probably a leftover from when the same table be use for local and global shard during development of the feature
prestodbpresto
raptor local shard cleanup should only mark shard for current node
Bug
the call in shardcleaner to updatecleanedshardnode and updatepurgedshardnode should take the current node i d it be update the shard for all node rather than just the local node
prestodbpresto
aggregation node should respect preference for hash partition if it align with the group key
Enhancement
currently aggregation node and many other repartitioning operator just arbitrarily select a partition order for their group column they should first check to see if the parent have a hash partition preference that align with their own
prestodbpresto
add function for bitwise operation
Enhancement
consideration future support of decimal type same result regardless of type not commit to store number as two s complement internally function that be insensitive to width of number bitwise not 1 2 document as bitwise not in two s complement arithmetic bitwise and 91 15 11 bitwise or 3...
prestodbpresto
array constructor with too many value cause classformaterror
Bug
query that contain very large array constructor cause bytecode to be generate that contain too many method argument select array 1 1 1 2 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 ...
prestodbpresto
bad error message when window function be use in have clause
Bug
sql select count over from value 1 have count over 1 fail with count bigint be not a scalar function full stacktrace java lang illegalargumentexception count bigint be not a scalar function at com google common base precondition checkargument preconditi...
prestodbpresto
push table write through union all
Enhancement
a query like this sql create table t as select from u union all select from v result in a plan that gather all the datum in one node before perform the table write we should be to push the table write through the union all for well parallelism
prestodbpresto
support set comment on table and column
Enhancement
unfortunately there be no standard syntax so we should look at what postgresql and oracle do here we should allow it for both create table and add column plus a way to update exist object
prestodbpresto
categorize exception for invalid raptor shard uuid value
Bug
sql select from order where shard uuid 4c9415cb c37d 4bad b8ac 952670948fa1 java lang numberformatexception for input string 952670948fa1 at java lang numberformatexception forinputstring numberformatexception java 65 at java lang long parselong long java 589 at java...
prestodbpresto
access control exception not properly handle
Bug
resourceutil only catch accessdeniedexception if a generic prestoexception be throw it go all the way out of the container as a 500 error it should be translate to a proper response 2015 11 11t08 17 18 452 0800 warn http worker 97 com facebook presto server throwablemapper request fa...
prestodbpresto
input symbol do not match output symbol
Bug
java lang illegalargumentexception input symbol do not match output symbol at com google common base precondition checkargument precondition java 122 at com facebook presto sql planner plan exchangenode exchangenode java 71 at com facebook presto sql planner optimization projectionpushdown rew...
prestodbpresto
invalid plan for join
Bug
select from select x sin x from value 1 2 3 t x t join select x sin x from value 1 2 3 u x u on t x u x in projectpushdown pushprojectionthrough projection be a map but outputbuilder be a list as a result project...
prestodbpresto
invalid plan for cross join unn
Bug
explain select y from value array 1 2 array 3 union all value array 4 5 array 6 t x cross join unn x u y group by y addexchange visitunn do not exist but it should exist and should check the preferred property and filter the newly generat...
prestodbpresto
correctly handle modification operation for hive external table
Bug
my understanding be that hive external table be basically read only view of externally manage datum create or drop an external table or partition merely modify the metadata in the hive metastore give this assumption it seem that insert or delete operation should not be allow for external table
prestodbpresto
support order by clause for aggregation
Enhancement
example syntax aggregate this be particularly useful for agg function like array agg that count on input order
prestodbpresto
pagetoolargeexception at page fetch
Bug
I encounter pagetoolargeexception with a simple query like select from tab have hundred of bigint column partitionbuffer getpage return from queue page to the max size but the size calculation be base on the page s memory byte not from encode bytes a quick solution be consider page encode margin ...
prestodbpresto
npe in hivepagesink
Bug
java lang nullpointerexception at java util stream referencepipeline 3 1 accept referencepipeline java 193 at java util spliterator arrayspliterator foreachremaine spliterator java 948 at java util stream abstractpipeline copyinto abstractpipeline java 481 at java util stream...
prestodbpresto
plan error for query with have clause
Bug
the follow query sql select a count 1 from value 1 2 3 t a group by a have count 1 1 fail with java lang illegalargumentexception invalid node predicate dependency count 3 expr 2 not in source plan output a count count 3 at com google common base preconditio...
prestodbpresto
analysis error when reference column from subquery
Bug
the follow query sql select x from select a x from value 1 2 3 a x group by x fail with com facebook presto sql analyzer semanticexception column x can not be resolve at com facebook presto sql analyzer expressionanalyzer visitor createmissingattributeexception expre...
prestodbpresto
plan failure for group by query with field dereference
Bug
give a table with the follow shape t x array this query select x 1 key count 1 from t group by 1 order by 2 fail with java lang illegalargumentexception no mapping for expression x 1 key at com google common base precondition checkargument precondition...
prestodbpresto
regex fail with arrayindexoutofboundsexception
Bug
presto select regexp like a a b query fail 1 java lang arrayindexoutofboundsexception 1 at io airlift jcoding multibyteencode safelengthforuptofour multibyteencode java 64 at io airlift jcoding specific nonstrictutf8encode length nonstrictutf8encoding java 30 at io airlift ...
prestodbpresto
view create with uppercase column reference can not be query
Bug
the bug seem to be relate to column reference presto create view test as select x foo from select 123 foo x create view presto select from test query fail view test be stale it must be re create presto describe test column type null partition key comment ...
prestodbpresto
invalid plan produce for this query
Bug
explain select approx percentile 0 5 x med x avg x avg x from value 1 2 3 t x java lang illegalargumentexception invalid node aggregation dependency field 1 not in source plan output expr x at com google common base precondition checkargument precondition java 145 at...