repository
stringclasses
156 values
issue title
stringlengths
1
1.01k
labels
stringclasses
8 values
body
stringlengths
1
270k
prestodbpresto
skip partition prune during predicate pushdown for query that can t benefit from it
Enhancement
the partition pruning logic trigger by the predicate pushdown optimizer can get very expensive for table with hundred of thousand of partition there be some query that can t benefit from partition pruning at all so try to enumerate they eagerly be costly and introduce unnecessary latency e g sql select ...
prestodbpresto
query input row size stat not track properly for join query
Bug
the query level stat only include the row size from the leaf stage the should include the input for all stage that perform table scan for example 1 20 130 m rows 14 1 gb 1 64 m rows s 182 mb s stage row row s bytes bytes s queue ...
prestodbpresto
refresh partition information in batch
Enhancement
currently the partition cache in cachinghivemetastore be access via getall which do a single request to the metastore for each call once the entry be in the cache though the background refresh task fetch they one at a time we should update the implementation to batch the background request to refresh ba...
prestodbpresto
implement hive acid table support
Enhancement
hive 0 14 introduce acid table info in hive wiki hive transaction these table be not compatible with exist code because directory layout be different these table will have subdirectory for different version basis and addendum of the datum more than word an example for example for a table ...
prestodbpresto
make row type comparable
Enhancement
the row type should be comparable if and only if all its field type be comparable
prestodbpresto
locationawareschedule false should not override split s remotely accessible flag
Bug
in the current implementation if location aware scheduling be turn off node will be pick at random regardless of whether the split indicate that it s not remotely accessible this be wrong as it will result in worker not be able to access the datum they be assign to process
prestodbpresto
count star on sys node table return error
Bug
this be in version 0 77 not sure if it have be fix since presto default select count from sys node query 20141108 143132 00003 rrx9x fail 2 node split 1 total 0 do 0 00 cpu time 0 0s total 0 rows s 0b s 0 active per node 0 0 parallelism 0 rows s 0b s para...
prestodbpresto
table create or insert can succeed even if the query fail
Bug
due to how the operator system work the finish method on tablecommitoperator can be call even if the query fail cause it to erroneously commit the table creation or insert operation
prestodbpresto
add bitwise function
Enhancement
we need to figure out how various type get convert to bit the sql standard have a bit and bit vary type which may be useful here
prestodbpresto
fix o n 2 loop in inputextractor visittablescan
Enhancement
the loop in visittablescan do one metadata lookup for each column reference by the tablescan node the implementation of getcolumnmetadata be o n for some connector e g hive result in o n 2 overall fix this may require update the spi to be able to return multiple column metadata entry in one call
prestodbpresto
json array get do not work for non scalar
Bug
presto search select json array get hello world 0 col0 null 1 row
prestodbpresto
nan in array or map not handle correctly
Bug
select array sqrt 1 the above query should work but instead fail with an error
prestodbpresto
npe writting null map or array in hiverecordsink
Bug
java lang nullpointerexception io airlift slice precondition checknotnull precondition java 30 io airlift slice slice copiedbuffer slice java 222 io airlift slice slice utf8slice slice java 230 com facebook presto hive hiverecordsink append hiverecordsink java 217 com facebook presto hive hiverecordsink ap...
prestodbpresto
create sql domain for sphinx
Enhancement
sphinx use domain for thing like function documentation and reference we use the python domain as the default domain for the presto documentation but this be problematic because python function do not have argument type return type or overload we should write a new sql domain for sphinx to properly supp...
prestodbpresto
presto cli sql folding should replace end of line comment with c style comment
Enhancement
this query presto default select 4 5 6 7 fold to presto default select 4 5 6 7 which can t be edit instead we should fold it to presto default select 4 5 6 7
prestodbpresto
null partition key break hive partition pruning
Bug
if the table have a partition key like key hive default partition the follow query select key count from table group by 1 return result like key col1 window 1 null 2 ios 3 android 4 4 row but the follow query ...
prestodbpresto
implement corr covar etc aggregation function
Enhancement
from the sql specification section 4 15 the binary aggregate function take a pair of argument the and the which be both s any row in which either argument evaluate to the null value be remove from the group if there be no row remain in the group then the result of regr count be 0 zero an...
prestodbpresto
support for skip header line count property for hive table
Enhancement
we have text table with skip header line count property
prestodbpresto
exception when use subquery expression in aggregation query
Bug
the follow query should fail during analysis with a proper error e g must be an aggregate expression or appear in group by clause but it fail with an internal error instead sql select a value 1 group by 1 query 20141017 183915 11402 sgybh fail aggregation analysis not yet imp...
prestodbpresto
exception when use subscript operator in aggregation query
Bug
the follow query should fail during analysis with a proper error e g must be an aggregate expression or appear in group by clause but it fail with an internal error instead sql select a array 1 2 3 1 group by 1 query 20141017 183802 11391 sgybh fail aggregation analysis not ye...
prestodbpresto
describe a drop hive table show zero row
Bug
describe a drop hive table that have be cache result in the describe show zero row rather than table do not exist presto desc some table column type null partition key comment 0 row
prestodbpresto
array be not comparable
Enhancement
array should be comparable and orderable so that they can be use in group by expression order by clause etc the and hashcode operator for a type array be define iff they be define for t give two array a array and b array the operator list above can be apply between a an...
prestodbpresto
nullpointerexception when try to explain rename
Bug
this result in an exception explain alter table order rename to rename order java lang nullpointerexception com facebook presto sql tree astvisitor process astvisitor java 24 com facebook presto sql planner logicalplanner createrelationplan logicalplanner java 173 com facebook presto sql planner logicalplanne...
prestodbpresto
hiveclient getpartition break with hive default partition
Bug
hiveclient getpartition do not properly handle null partition example 20141013 191538 19058 tgxh6 for input string hive default partition java lang numberformatexception java lang numberformatexception forinputstring numberformatexception java 65 java lang long parselong long java 441 java lang...
prestodbpresto
exception in pruneunreferencedoutput with unnest
Bug
sql select 1 from value array 1 as t a cross join unn a java lang illegalargumentexception unnestsymbol be empty at com google common base precondition checkargument precondition java 125 at com facebook presto sql planner plan unnestnode unnestnode java 50 at com faceb...
prestodbpresto
nullpointerexception verify schema in hiveclient
Bug
the code that verify the table schema match the partition schema can throw a npe at l1068 one of the list be likely null com facebook presto spi prestoexception hive unknown error at com facebook presto hive hivesplitsourceprovider hivesplitsource propagateprestoexception hivesplitsourceprovider ja...
prestodbpresto
analyzer fail to catch usage of window function without over clause
Bug
a query like sql select row number fail with this exception java lang illegalstateexception not a scalar function or operator at com google common base precondition checkstate precondition java 176 at com facebook presto metadata functioninfo getmethodhandle functioninfo java 199 ...
prestodbpresto
compilation for try cast be break
Bug
the exception handling be completely break because exception clear the stack it need to be in a separate method this query reproduce it select concat foo try cast x as varchar from value 1 a x exception java lang verifyerror instruction type do not match stack map
prestodbpresto
select count with aggregation subquery throw arrayindexoutofboundsexception
Bug
presto select count from select count 1 query 20140910 204334 54189 w8f29 fail 1 node split 1 total 0 do 0 00 cpu time 0 0s total 0 rows s 0b s 0 active per node 0 0 parallelism 0 rows s 0b s parallelism 0 0 0 01 1 row 0b 0 rows s 0b s query...
prestodbpresto
jmx connector do not render array properly
Bug
for example the inputargument column from java lang type runtime with the new array support it might be possible to return these as real array otherwise we should properly convert they to string
prestodbpresto
exception during plan with duplicate column in order by clause
Bug
select x x from select 1 x order by 1 2 query 20140902 180334 61089 w8f29 fail multiple entry with same key x 2 asc null last and x 2 asc null last java lang illegalargumentexception multiple entry with same key x 2 asc null last and x 2 asc null last at com google common collect i...
prestodbpresto
query hang due to miss tasksource update in driver
Bug
driver can leave source update stick in newsource forever this hang the query since the task will never see the nomoresplit message I believe this be cause by a race where a tasksource be add between the call to processnewsource and the unlock in driverlockresult close the tasksource get queue in newsour...
prestodbpresto
first value issue in 0 75 work fine in 0 74
Bug
hello after upgrade from 0 74 to 0 75 the first value function do not work inside from if where filter give no row e g where 1 1 the error be expect 1 argument for function first value but get 0 this give an error select from select first value e name over partition by user uuid order ...
prestodbpresto
indexjoinoptimizer break cross join
Bug
explain select from select 2 a x cross join select 2 a y query 20140812 190120 14773 pycet fail lookupsymbol can not be empty java lang illegalargumentexception lookupsymbol can not be empty at com google common base precondition checkargument precondition java 125 at com facebook pre...
prestodbpresto
incorrect behavior for chain union
Bug
all follow by distinct return too many row postgresql dphillip value 2 union all value 2 union distinct value 2 column1 2 1 row presto presto di value 2 union all value 2 union distinct value 2 col0 2 2 ...
prestodbpresto
like stop process at first line break in the value
Bug
the current like implementation stop process at the first line break in the value while we be work on a fix for this you can use regexp like regexp like to work around this issue
prestodbpresto
group by not consistent with be distinct from for nan
Bug
in 0 73 presto select nan be distinct from nan col0 true presto datascience select distinct a a from value 0 0 0 0 x a col0 nan nan but in master 0 74 presto select nan be distinct from nan col0 true ...
prestodbpresto
timestamp partition not support for hive
Bug
unsupported partition type timestamp for partition date time trunc hour 2013 12 01 00 253a00 253a00
prestodbpresto
remote page be too large exception
Bug
the remote page be too large should only happen if a single presto row be massive the output buffer should split page as necessary to fit into the response buffer or the engine should assure that a page never exceed the client buffer size
prestodbpresto
single distinct aggregation plan be not optimal
Enhancement
these two query be equivalent but second plan be much more efficient since it filter out the non distinct row in the leaf stage presto sf1 explain select count distinct orderstatus from order output col0 ...
prestodbpresto
mislead error message for table without column
Enhancement
presto default describe twitter delete column type null partition key 0 row query 20140630 185846 00000 ca9r5 finish 1 node split 2 total 2 do 100 00 0 01 0 row 0b 0 rows s 0b s presto default select count 1 from twitter delete...
prestodbpresto
presto very slow when plan on a hive table with a large number of column
Bug
the presto planner currently ask for table column one at a time from a connector the hive connector build up the entire set of column before return a single one effectively make it a o n 2 operation when list all the column this become a problem when you have a very large number of column we notice this on a ...
prestodbpresto
remove dual connector and table
Enhancement
we now support from less query and table expression value dual be no long need
prestodbpresto
in subquery do not add implicit coercion
Bug
this query should return work but throw an error due to the miss implicit coercion select 1 0 in value 1 2 3
prestodbpresto
jdbc client thread prevent jvm shutdown
Bug
there be at least a couple of lame work around the easy way be to terminate the jvm at the end of main thread system exit 0 another option be to de register the driver and then force a garbage collection which should invoke the finalizer simply call close do not work because there be actual...
prestodbpresto
don t schedule task in the coordinator
Enhancement
currently task for non leaf stage can get schedule in the coordinator this can result in resource starvation for the scheduler and other maintenance task we should disable this behavior or at least make it configurable
prestodbpresto
identity cast of hyperloglog fail
Bug
select cast cast null as hyperloglog as hyperloglog result in query 20140422 220951 00004 n5kdf fail can not cast com facebook presto spi type hyperloglogtype 74bebc01 to com facebook presto spi type hyperloglogtype 74bebc01 com facebook presto sql analyzer semanticexception can not cast com facebook presto...
prestodbpresto
task stuck in plan state
Bug
there s some weird bug in the coordinator that result in query get stick the symptom be one or more task for a query in state planning other task get split assign and make progress worker associate with that task doesn t receive any http request for status update or split assignment for the task restart ...
prestodbpresto
push down limit clause to connector source level
Enhancement
so connector can use the limit clause to limit the result
prestodbpresto
default read timeout for httpclient too large
Bug
the default read timeout for httpclient be 1minutes most remote interaction in presto be short and automatically retire so a long timeout be counterproductive a short timeout will allow presto to detect fail query much fast and free up resource
prestodbpresto
bad connector can hang worker
Bug
if a connector hang in a call to recordset all thread in the worker can become deadlocke taskexecutorthread prioritizedsplitrunner process driversplitrunner processfor driver process hang due to bug in connector callbackthread statemachine transition t...
prestodbpresto
add an info only http query endpoint
Enhancement
presto currently combine the ability to fetch query progress info with the fetching of the result presto should add another http end point that allow fetch of query progress info but without return datum and without count as a heartbeat
android10androidcleanarchitecture
should repository know about authenticated user
Question
in my project I need to fetch some datum relate to the authenticated user and for that I need the userid of the user I have an authmanager class that give I the userid of the authenticated user I be confused whether to add this authmanager class as a member of my userrepository implementatio...
android10androidcleanarchitecture
why transform user in the user to usermodel in the presentation
Question
hello everyone why we be transform the user class to usermodel we could pass just the user instance afterall to the view why add this complexity thank you
android10androidcleanarchitecture
q handle network response during screen rotation
Question
hi I would like to get your input on how to handle network response during screen orientation change the scenario as follow 1 network request initiate after setview be call in a fragment s onviewcreate method 2 user rotate the device ondestroy get call which in turn would nullify view interfac...
android10androidcleanarchitecture
uml package diagram for cleanarchitecture
Question
android10 hi I come to the concept of clean architecture it be really inspire I have read all your 4 article include the last one for dynamic parameter I think you be do gr8 work here I really admire your sharing attitude with other in the path to understand the code especially I m not androi...
android10androidcleanarchitecture
how to deal with complicated view
Question
one view can only hold single presenter single usecase can only do single thing but when the view or the business logic be too complicated its presenter must hold many usecase when the logic between multiple usecase be very complicated the code of presenter must be hard to maintain I want to reuse ...
android10androidcleanarchitecture
what about offline first live local datastore update
Question
hi all alright in my project I follow an offline first architecture where I m always query the local datastore for each ressource that require query a presenter have two usecase object 1 one that make request to the remote data store and save it locally it never deliver information to presenter the...
android10androidcleanarchitecture
how to use multiple usecase in single view or single presenter
Question
I think the view can only exist single presenter I see the presenter in demo only need one usecase but the usecase only do single thing so how to do this use multiple presenter in view or user multiple usecase in presenter
android10androidcleanarchitecture
what about global error handle
Question
in the project error handling be show error message in presentation layer but if we need add exception notauthorizedexception in datum layer and handle all error from restapi with 401 code error in presentation layer we need handle this error and show authactivity override public void onerror throwable...
android10androidcleanarchitecture
model for list view item and detail view
Question
I m fetch some datum from 3rd party library to access their api for example I create two use case fetchuserlist and fetchuserdetail to fetch user list and user detail the user list will be display in recycler view but only the user name part and in user detail view user name and company name will be displa...
android10androidcleanarchitecture
do the usage of android datum bind librarary correspond to the clean architecture principle
Question
be it good to use this library in term of clean architecture
android10androidcleanarchitecture
where be the good place to call subscribeon and observeon method
Question
I wonder where be the good place to call subscribeon and observeon method what module s should handle all thread relate activity
android10androidcleanarchitecture
library dependency across layer
Question
I have a library module that I be reuse across multiple application the library be compose of two module one android library module that depend on a java library module that contain my domain logic then in the project that I depend on this library I have split into the three module use in the android cleanar...
android10androidcleanarchitecture
what about thing like appsetting
Question
good day I have some difficulty with stuff like isauthorize isfirststart etc in particular isauthorize be a flag indicate that the user have be log in which solution will be well 1 should we write an interactor and access appsettingsrepository 2 or simply consider appsetting as a kind of ...
android10androidcleanarchitecture
save with rxjava and the repository pattern
Question
hi I have be read the other issue and they all seem to be relate to datum retrieval rather than save datum both usecase s in the project be for retrieval also my question be what should I return if anything upon save an entity and should this be an observable at the moment follow the whole se...
android10androidcleanarchitecture
how to deal with login
Question
introduction at the datum layer I have retrofit interface for example public interface someapi post observable login loginrequest body at the domain layer I have accountmanger public class accountmanager private someapi api inject public a...
android10androidcleanarchitecture
question prepare datum for presentation layer
Question
hi I be try to adopt idea from clean architecture to my app and have follow question in my view I have to show a summary of datum calculate from different entity I do not know where to do the calculation stuff 1 calculate in datum layer so domain will only pass through to presenatation layer so what s th...
android10androidcleanarchitecture
what about communicate between presenter
Question
I need show progressbar in parent fragment in case if child fragment have need state for example count element in listview to solve the problem it be necessary that the presenter be able to communicate the mainpresenter should know about entity size in the childpresenter be it correct from the point ...
android10androidcleanarchitecture
layer for manager and service that require android context
Question
hi I be try to migrate to clean architecture I have application which be make in standard way I try to decouple but still a lot of stuff happen in activity and fragment example be quite simple mostly application be much more complex so it be much hard to decouple all highly couple component in...
android10androidcleanarchitecture
datum layer know about domain layer
Question
hi everyone I wild about clean architecture design pattern I feel a long time ago that I need to design application in another way find awesome article about clean architecture but have just start to implement it I have one question about datum and domain layer as I understand 1 datum la...
android10androidcleanarchitecture
how to submit a form
Question
public final class feeddraftaddusecase extend usecase private final feeddraft mfeeddraft private final feeddraftrepository mfeeddraftrepository inject public feeddraftaddusecase feeddraft feeddraft feeddraftrepository feeddraftrepository threadexecutor threadexecutor poste...
android10androidcleanarchitecture
fragmentmanager
Question
I have an activity with lot of fragment which be replace in one container I have an own navigationmanager class which handle the fragment and do the replacement and other thing with the fragment where be the good place to instantiate and manage the navigationmanager view or presenter
android10androidcleanarchitecture
why the domain layer be tigthly couple to a framework dependency rxjava
Question
hi here I be again this time with a different concern cite uncle bob s explanation of use case we also do not expect this layer use case to be affect by change to externality such as the database the ui or any of the common framework this layer be isolate from such concern your use case depend o...
android10androidcleanarchitecture
why datum layer have a dependency on the domain layer
Question
as state in clean architecture dependency should point only inward this separate layer in a way that they could be interchangeable easily and also decouple right in your case you decide to create 3 layer which have this dependency relationship presentation domain datum you use di for some ...
android10androidcleanarchitecture
mvp with custom view
Question
hi all this be not an issue but a topic of discussion what do you think about custom view be mvp still applicable for example let s say that you have a fragment that contain a couple of custom view one way be to consider the fragment as the mvp view with its own presenter the fragment view would ask ...
android10androidcleanarchitecture
why there be no activity context injection
Question
I don t know this be a bug or just my misunderstanding java inject public usersadapter context context this layoutinflat layoutinflat context getsystemservice context layout inflater service this userscollection collection emptylist here you have inject an adap...
android10androidcleanarchitecture
framework integration
Question
hi can you share your thought where should framework specific stuff be place for example I have to integrate follow gcm push notification regular push notification with news google analytic track for pageview s and event where should gcm code reside instanceidlistenerservice and gcmlisten...
android10androidcleanarchitecture
question about what the view must do
Question
I have be study this project for a while now and I have a few question that be not so clear to I 1 in this project the verification for internet connection be make in the datum layer but this seem not to be the good thing to do because you need to have android framework code in this layer to I the only...
android10androidcleanarchitecture
why do we have entity in datum layer and not in domain layer
Question
it s just name convention but I think accord to the clean architecture circle diagram it would be more clear if the object define enterprise business rule in the domain layer would be call entity be I right
android10androidcleanarchitecture
how about realm
Question
I be just wonder to know your thought about the good way to implement realm entity realm need the android framework so I can not have realm object in the domain layer so I m think to create other realm entity in the datum layer and then map domain object to realm object do it make sense also the repo...
android10androidcleanarchitecture
compose use case observable
Question
hi guy great project at my company we have base an app on this template and the principle in the accompany blog post for some more advanced feature in the app we run into an issue that be very similar to another one mention by amatkivskiy we would like to be able to compose and combine use case together t...
android10androidcleanarchitecture
organize by feature view injection
Question
in your blog you mention that organize the code via feature be well and I totally agree in my case I ve split my app into different module and each module be actually a feature I assume that this be how you guy also work at soundcloud so as to allow individual team work on a feature to work independently on...
android10androidcleanarchitecture
how to load domain entity
Question
hi and thank you for your blog and example they be very helpful I m currently learn clean architecture and I be think about domain entity and how to load they correctly let s say I want to display a list of tv show from a database the tvshow class will have a name a synopsis and a list of episode ...
android10androidcleanarchitecture
interface in the view package
Question
in the presentation layer the interface from view package userdetailsview userlistview shouldn t be in the presenter package if I understand the dependency inversion principle the presenter should define the interface that the view have to implement
android10androidcleanarchitecture
what would play music file look like in clean architecture
Question
hi it be not actual issue just question I be very interested in clean architecture and my application be about play audio file I be about to rewrite my app for the third time none even complete in 20 this time use clean architecture how would play music file fit in ca where should music play servic...
android10androidcleanarchitecture
refactor project structure to one single module
Help Wanted
hi guy as you can see I have be work on a single module project structure here be the pr I m not say that I will land it but I do want to start a discussion around it and see pro and con for either a single module project or multi module project the first couple of thing that come to my mind advantag...
android10androidcleanarchitecture
too many step to invoke navigator method be not it
Question
could someone explain I why navigator s method be call from activity not from fragment directly why first we invoke presenter s method which in turn invoke fragment s method which invoke activity s method
android10androidcleanarchitecture
why doesn t the current applicationmodule have providenavigator
Question
in your post here I see the follow method in applicationmodule class but the actual github code doesn t have this method but what be weird be this run even without it can you explain how so thank provide singleton navigator providenavigator return new navigator
android10androidcleanarchitecture
how to make an alarm follow the principle of clean architecture
Question
hi I have a question if I have to implement something like alarm that will trigger at specific time and run my use case set an alarm be business logic of my app so it should be locate in domain direct I if I wrong and it s use case should set up my alarm so it should have the android class at this momen...
android10androidcleanarchitecture
query criterion for repository
Question
hi guy I have query with three param and I want to make this triplette a criterion object where do you think be the good place to add the criterion object in order to not violate the rule of clean architecture currently I add in the domain layer any other suggestion or well approach basically I want to have t...
android10androidcleanarchitecture
multiple component provide by activity
Question
the current implementation allow an activity to provide a component to any subclass implement hascomponent interface for instance userlistfragment java java private void initialize this getcomponent usercomponent class inject this this userlistpresenter setview this but what ...
android10androidcleanarchitecture
usecase responsibility
Question
what can subclass of usecase do what can t they do in this project use case be atomic task use to simply obtain datum but what about decision make where do that belong example 1 I have a collection of item and lazy loading be there one usecase handle all pagination logic and call necessary repository met...
android10androidcleanarchitecture
external service bind use case
Question
hi guy I m try to implement the clean architecture into a big android enterprise project since it fit perfectly in our need the only obscure thing it s about bind unbind to external service which expose an api trough aidl my question be where the bind unbind call go our external service act like a reposi...
android10androidcleanarchitecture
where be the good place to validate the datum
Question
in order to load the model in a view I have to check the datum for some precondition for example for some string color value ffffff which be come from backend we have to check it if its not null then parse it with color parsecolor where be the good place to put such code like this be it a good idea...
android10androidcleanarchitecture
need to be able to initialize injector in fragment
Question
specifically when fragment be be use in a viewpager
android10androidcleanarchitecture
pass an object from the presentation layer domain layer datum layer
Question
hi android10 I have a couple of question regard how to pass an object from the presentation layer to the domain layer and then to the datum layer I have a use case when a user sign up within my app 1 pass and object from the domain layer to the datum layer this be the interface in the ...
android10androidcleanarchitecture
errormessagefactory clean approach
Question
I be wonder if this can be do in an efficient way than the current one because if you have many type of exception then this will be a huge if else if to catch all the case I suppose that one solution be to separate the factory per feature but still I will duplicate the same code for application error or no i...
android10androidcleanarchitecture
push event in the datum layer to the presentation layer
Question
what about update event in the datum layer and how to notify about they the presentation layer let s suppose that some third party service have update some user datum in the data base be event bus approach good for that for example we will define some event class in the domain layer userupdatedevent some...
android10androidcleanarchitecture
userdatarepository break dependecy rule
Question
hi didn t userdatarepository break dependency rule class be from datum layer but implement userrepository interface which be from domain layer thank rohliq