repository
stringclasses
156 values
issue title
stringlengths
1
1.01k
labels
stringclasses
8 values
body
stringlengths
1
270k
prestodbpresto
cli doesn t reset properly with multi line query in debug mode
Bug
step to reproduce 1 run cli with debug 2 run a multi line query 3 ctrl c the output will look like presto select count from table query 20150924 004635 00285 k9mtd run 88 node 290 split split 1 137 total 807 do 70 98 do cpu time 4 2s total 3 3 m rows s 7 34 gb s 9 activee per node 0 0 parallelism 24 5k rows s 55 6 mb s parallelism 0 7 0 06 13 8 m rows 30 7 gb 2 15 m rows s 4 78 gb s query abort by userow s bytes bytes s queue run do presto 0 0 0b 0b 1 0 0 1 s 1 73 m 490k 3 43 g 993 m 114 45 130
prestodbpresto
exception on cli
Bug
presto show table from raptor system table shard 1 row query 20150922 190632 00002 88uiv finish 1 node split 2 total 2 do 100 00 cpu time 0 0s total 111 row s 3 25 kb s 81 active per node 0 1 parallelism 7 rows s 223b s parallelism 0 1 0 00 1 row 30b 7 rows s 223b s presto error fail to disable interrupt character java lang interruptedexception at java lang object wait native method at java lang object wait object java 502 at java lang unixprocess waitfor unixprocess java 396 at jline internal terminallinesetting waitandcapture terminallinesetting java 339 at jline internal terminallinesetting exec terminallinesetting java 311 at jline internal terminallinesetting stty terminallinesetting java 282 at jline internal terminallinesetting undef terminallinesetting java 158 at jline unixterminal disableinterruptcharacter unixterminal java 153 at jline console consolereader readline consolereader java 2445 at jline console consolereader readline consolereader java 2372 at com facebook presto cli linereader readline linereader java 51 at jline console consolereader readline consolereader java 2360 at com facebook presto cli console runconsole console java 149 at com facebook presto cli console run console java 128 at com facebook presto cli presto main presto java 32 error fail to disable litteral next character java lang interruptedexception at java lang object wait native method at java lang object wait object java 502 at java lang unixprocess waitfor unixprocess java 396 at jline internal terminallinesetting waitandcapture terminallinesetting java 339 at jline internal terminallinesetting exec terminallinesetting java 311 at jline internal terminallinesetting stty terminallinesetting java 282 at jline internal terminallinesetting undef terminallinesetting java 158 at jline unixterminal disablelitteralnextcharacter unixterminal java 185 at jline console consolereader readline consolereader java 2448 at jline console consolereader readline consolereader java 2372 at com facebook presto cli linereader readline linereader java 51 at jline console consolereader readline consolereader java 2360 at com facebook presto cli console runconsole console java 149 at com facebook presto cli console run console java 128 at com facebook presto cli presto main presto java 32
prestodbpresto
password with diactric character be not parse correctly
Enhancement
I have a connector with a password contain the letter via native mysql client I be able to connect with the username and password supply in the property file but prestodb could not access anything
prestodbpresto
duplicate distinctlimitnode in query plan
Bug
when explain distinct limit query the plan look like below there be duplicate distinctlimit in the plan presto orc explain select distinct l orderkey from lineitem limit 10 query plan output l orderkey l orderkey bigint distinctlimit 10 l orderkey bigint hashvalue bigint exchange gather l orderkey bigint hashvalue bigint distinctlimit 10 l orderkey bigint hashvalue bigint distinctlimit 10 l orderkey bigint hashvalue bigint project l orderkey bigint hashvalue bigint hashvalue combine hash 0 coalesce operator hash code l orderkey 0 tablescan hive hive orc lineitem originalconstraint true l orderkey bigint layout hive l orderkey hivecolumnhandle clientid hive name l orderkey ordinalposition 0 hivetype bigint hivecolumnindex 0 partitionkey false
prestodbpresto
split scheduling cause scalability bottleneck on large cluster
Enhancement
the split scheduler be by far the large consumer of cpu on large active cluster as report by perf 12 32 com facebook presto execution nodescheduler nodeselector computeassignment 10 78 com facebook presto execution nodetaskmap getpartitionedsplitsonnode 2 78 com facebook presto execution nodescheduler nodeselector selectnode 2 52 java util concurrent concurrenthashmap transfer 2 41 com fasterxml jackson core json utf8streamjsonparser nexttoken
prestodbpresto
replace nativecodeloader in shaded hadoop build
Enhancement
hadoop nativecodeloader always log warning about not load the native code and we use some hacky reflection in hadoopnative to make it work it would be clean just replace the class with our own compatible version
prestodbpresto
add support for grant and revoke
Enhancement
add authorization support on the sql front end
prestodbpresto
hive connector sort bucket table not handle correctly
Bug
user on mailing list report that read from a sort bucket table do not work properly topic presto user pjohcrjcbzw we need a test for this case in abstracttesthiveclient
prestodbpresto
npe in raptor shardejector
Bug
com facebook presto spi prestoexception fail to perform metadata operation at com facebook presto raptor metadata databaseshardmanager runtransaction databaseshardmanager java 351 at com facebook presto raptor metadata databaseshardmanager assignshard databaseshardmanager java 290 at com facebook presto raptor storage shardejector process shardejector java 236 at com facebook presto raptor storage shardejector lambda startjob 26 shardejector java 149 at com facebook presto raptor storage shardejector lambda 173 1922191129 run unknown source at java util concurrent executors runnableadapter call executor java 511 at java util concurrent futuretask runandreset futuretask java 308 at java util concurrent scheduledthreadpoolexecutor scheduledfuturetask access 301 scheduledthreadpoolexecutor java 180 at java util concurrent scheduledthreadpoolexecutor scheduledfuturetask run scheduledthreadpoolexecutor java 294 at java util concurrent threadpoolexecutor runworker threadpoolexecutor java 1142 at java util concurrent threadpoolexecutor worker run threadpoolexecutor java 617 at java lang thread run thread java 745 cause by org skife jdbi v2 exception callbackfailedexception java lang nullpointerexception at org skife jdbi v2 dbi withhandle dbi java 276 at org skife jdbi v2 dbi intransaction dbi java 298 at com facebook presto raptor metadata databaseshardmanager runtransaction databaseshardmanager java 347 11 more cause by java lang nullpointerexception at java nio bytebuffer wrap bytebuffer java 396 at com facebook presto raptor util arrayutil intarrayfrombytes arrayutil java 32 at com facebook presto raptor metadata databaseshardmanager fetchlockednodeids databaseshardmanager java 443 at com facebook presto raptor metadata databaseshardmanager lambda assignshard 10 databaseshardmanager java 293 at com facebook presto raptor metadata databaseshardmanager lambda 621 53440124 intransaction unknown source at org skife jdbi v2 tweak transaction localtransactionhandler intransaction localtransactionhandler java 192 at org skife jdbi v2 basichandle intransaction basichandle java 306 at org skife jdbi v2 dbi 4 withhandle dbi java 301 at org skife jdbi v2 dbi withhandle dbi java 273 13 more
prestodbpresto
remove equalto from type
Enhancement
equalto do not handle null properly it have be supersede in new code by operator the only code leave that use equalto be typedhistogram streamingindexeddata tuplefilterprocessor arrayintersectfunction rowequaloperator maptype keywrapper typeutil positionequalsposition simplepagehashstrategy typedset delegate from other equalto and test code they should be remove
prestodbpresto
be distinct from do not provide expect result for array contain null
Bug
select array 1 be distinct from array cast null as bigint should return false it fail now
prestodbpresto
groupby shouldn t use equalto
Bug
this query fail because type equalto be use instead of be distinct from in group by however be distinct from as be implement today be not an operator select x from value array 1 0 array 2 0 array cast null as bigint 0 t x y group by x
prestodbpresto
raptor stage directory be not clean up when query fail
Bug
node can accumulate quite a lot of dead staging datum between restart
prestodbpresto
presto worker start to accept request before connector be load
Enhancement
it s rarely happen but we find error that connector catalog or udfs do not exist at the very beginning of worker restart it look like httpserver start start to accept request before plugin be not fully load yet I ve send a bootstrap change request if this pull request be accept loadplugin can be surely call before httpserver start
prestodbpresto
filter for information schema fail with uppercase
Bug
select from system information schema column where table schema foo select from system information schema column where table schema runtime and table name foo java lang illegalargumentexception schemaname be not lowercase at com google common base precondition checkargument precondition java 145 at com facebook presto metadata metadatautil checklowercase metadatautil java 94 at com facebook presto metadata metadatautil checklowercase metadatautil java 86 at com facebook presto metadata metadatautil checkschemaname metadatautil java 58 at com facebook presto metadata metadatautil checktablename metadatautil java 40 at com facebook presto metadata qualifiedtableprefix qualifiedtableprefix java 57 at com facebook presto connector informationschema informationschemapagesourceprovider extractqualifiedtableprefix informationschemapagesourceprovider java 324 at com facebook presto connector informationschema informationschemapagesourceprovider getcolumnslist informationschemapagesourceprovider java 182 at com facebook presto connector informationschema informationschemapagesourceprovider buildcolumn informationschemapagesourceprovider java 156 at com facebook presto connector informationschema informationschemapagesourceprovider getinformationschematable informationschemapagesourceprovider java 132 at com facebook presto connector informationschema informationschemapagesourceprovider getinternaltable informationschemapagesourceprovider java 126 at com facebook presto connector informationschema informationschemapagesourceprovider createpagesource informationschemapagesourceprovider java 87 at com facebook presto split pagesourcemanager createpagesource pagesourcemanager java 48 at com facebook presto operator scanfilterandprojectoperator createsourceifnecessary scanfilterandprojectoperator java 254 at com facebook presto operator scanfilterandprojectoperator isfinishe scanfilterandprojectoperator java 169 at com facebook presto operator driver processinternal driver java 377 at com facebook presto operator driver processfor driver java 303 at com facebook presto execution sqltaskexecution driversplitrunner processfor sqltaskexecution java 587 at com facebook presto execution taskexecutor prioritizedsplitrunner process taskexecutor java 505 at com facebook presto execution taskexecutor runner run taskexecutor java 639 at java util concurrent threadpoolexecutor runworker threadpoolexecutor java 1142 at java util concurrent threadpoolexecutor worker run threadpoolexecutor java 617 at java lang thread run thread java 745
prestodbpresto
feature request inmemory temp table support in presto
Enhancement
this be a follow up request from electrum s reply to this post topic presto user 5i480n 1npc create this issue to track development for this task it will be great if presto could provide a way to save output of a query as inmemory temp table something like this from spark dataframe teenager sqlcontext sql select from people where age 13 and age 19 teenager registertemptable teenager now we can slice and dice teenager table dataframe teensfromsf sqlcontext sql select from teenager where city san fransokyo
prestodbpresto
support truncate table
Enhancement
have something like truncate to quickly empty an exist table seem desirable e g note that truncate table name work similarly to delete from table name but particular connector may have a more efficient method to wipe out all datum from a give table than run a generic delete operation that may accept predicate via where clause
prestodbpresto
allow create queue with concurrency 0 but queue space 0
Enhancement
attempt to do so currently throw an exception say that maxqueue must be positive
prestodbpresto
add pause information to system runtime nod
Enhancement
relate to 3406 it be useful to know what cause a query to die we would like to know about anything that cause the jvm to pause I e stop run java code one way to accomplish this be a thread that sleep in a loop for 100ms and measure the system nanotime delta if this delta be long than configurable threshold say 5s by default it assume the jvm be pause these can be add as last pause start as a timestamp and last pause duration as an interval day to second
prestodbpresto
add start time to system runtime node
Enhancement
this should be a timestamp of when the node start it can be add to the announcement as a property like node version in servermainmodule then pull out in discoverynodemanager and add to prestonode
prestodbpresto
dereference of array in row throw exception in localexecutionplanner
Bug
java assertquery select a col1 1 from value row test row true array 1 map array 1 3 array 2 0 4 0 as t a java lang illegalargumentexception can t create a symbol from a qualified name with prefix at com google common base precondition checkargument precondition java 122 at com facebook presto sql planner symbol fromqualifiedname symbol java 52 at com facebook presto sql planner symboltoinputrewriter rewritequalifiednamereference symboltoinputrewriter java 42 at com facebook presto sql planner symboltoinputrewriter rewritequalifiednamereference symboltoinputrewriter java 28 at com facebook presto sql tree expressiontreerewriter rewritingvisitor visitqualifiednamereference expressiontreerewriter java 606 at com facebook presto sql tree expressiontreerewriter rewritingvisitor visitqualifiednamereference expressiontreerewriter java 56 at com facebook presto sql tree qualifiednamereference accept qualifiednamereference java 39 at com facebook presto sql tree astvisitor process astvisitor java 22 at com facebook presto sql tree expressiontreerewriter rewrite expressiontreerewriter java 45 at com facebook presto sql tree expressiontreerewriter rewritingvisitor visitsubscriptexpression expressiontreerewriter java 164 at com facebook presto sql tree expressiontreerewriter rewritingvisitor visitsubscriptexpression expressiontreerewriter java 56 at com facebook presto sql tree subscriptexpression accept subscriptexpression java 35 at com facebook presto sql tree astvisitor process astvisitor java 22 at com facebook presto sql tree expressiontreerewriter rewrite expressiontreerewriter java 45 at com facebook presto sql tree expressiontreerewriter rewritewith expressiontreerewriter java 29 at com facebook presto sql planner localexecutionplanner visitor visitscanfilterandproject localexecutionplanner java 859 at com facebook presto sql planner localexecutionplanner visitor visitproject localexecutionplanner java 802 at com facebook presto sql planner localexecutionplanner visitor visitproject localexecutionplanner java 407 at com facebook presto sql planner plan projectnode accept projectnode java 81 at com facebook presto sql planner localexecutionplanner visitor visitoutput localexecutionplanner java 430 at com facebook presto sql planner localexecutionplanner visitor visitoutput localexecutionplanner java 407 at com facebook presto sql planner plan outputnode accept outputnode java 79 at com facebook presto sql planner localexecutionplanner plan localexecutionplanner java 239 at com facebook presto execution sqltaskexecution sqltaskexecution java 165
prestodbpresto
can t concat an array with an empty array
Bug
concat an array with an empty array will fail because we can t cast the empty array to the type of the non empty array presto tiny select array 1 array query 20150727 073421 00004 25tug fail can not cast array to array com facebook presto spi prestoexception can not cast array to array at com facebook presto operator scalar arraytoarraycast specialize arraytoarraycast java 81 at com facebook presto metadata functionregistry 1 load functionregistry java 224 at com facebook presto metadata functionregistry 1 load functionregistry java 219 at com google common cache localcache loadingvaluereference loadfuture localcache java 3527 at com google common cache localcache segment loadsync localcache java 2319 at com google common cache localcache segment lockedgetorload localcache java 2282 at com google common cache localcache segment get localcache java 2197 at com google common cache localcache get localcache java 3937 at com google common cache localcache getorload localcache java 3941 at com google common cache localcache localloadingcache get localcache java 4824 at com google common cache localcache localloadingcache getunchecke localcache java 4830 at com facebook presto metadata functionregistry getexactfunction functionregistry java 512 at com facebook presto metadata functionregistry getcoercion functionregistry java 552 at com facebook presto sql analyzer expressionanalyzer visitor visitcast expressionanalyzer java 750 at com facebook presto sql analyzer expressionanalyzer visitor visitcast expressionanalyzer java 211 at com facebook presto sql tree cast accept cast java 61 at com facebook presto sql tree astvisitor process astvisitor java 22 at com facebook presto sql analyzer expressionanalyzer visitor process expressionanalyzer java 230 at com facebook presto sql analyzer expressionanalyzer visitor visitfunctioncall expressionanalyzer java 681 at com facebook presto sql analyzer expressionanalyzer visitor visitfunctioncall expressionanalyzer java 211 at com facebook presto sql tree functioncall accept functioncall java 70 at com facebook presto sql analyzer expressionanalyzer analyze expressionanalyzer java 184 at com facebook presto sql analyzer expressionanalyzer analyzeexpression expressionanalyzer java 1010 at com facebook presto sql analyzer expressionanalyzer analyzeexpressionswithsymbol expressionanalyzer java 982 at com facebook presto sql analyzer expressionanalyzer getexpressiontype expressionanalyzer java 944 at com facebook presto sql analyzer expressionanalyzer getexpressiontype expressionanalyzer java 934 at com facebook presto sql planner optimizations simplifyexpression rewriter simplifyexpression simplifyexpression java 131 at com facebook presto sql planner optimization simplifyexpression rewriter lambda 251 554780878 apply unknown source at com google common collect map 7 transformentry map java 1812 at com google common collect map 10 getvalue map java 1857 at com google common collect immutablemap copyof immutablemap java 292 at com facebook presto sql planner optimization simplifyexpression rewriter visitproject simplifyexpression java 92 at com facebook presto sql planner optimization simplifyexpression rewriter visitproject simplifyexpression java 70 at com facebook presto sql planner plan projectnode accept projectnode java 81 at com facebook presto sql planner plan planrewriter rewritecontext rewrite planrewriter java 99 at com facebook presto sql planner plan planrewriter rewritecontext rewrite planrewriter java 110 at com facebook presto sql planner optimization simplifyexpression rewriter visitproject simplifyexpression java 91 at com facebook presto sql planner optimization simplifyexpression rewriter visitproject simplifyexpression java 70 at com facebook presto sql planner plan projectnode accept projectnode java 81 at com facebook presto sql planner plan planrewriter rewritecontext rewrite planrewriter java 99 at com facebook presto sql planner plan planrewriter rewritecontext rewrite planrewriter java 110 at com facebook presto sql planner optimization simplifyexpression rewriter visitproject simplifyexpression java 91 at com facebook presto sql planner optimization simplifyexpression rewriter visitproject simplifyexpression java 70 at com facebook presto sql planner plan projectnode accept projectnode java 81 at com facebook presto sql planner plan planrewriter rewritecontext rewrite planrewriter java 99 at com facebook presto sql planner plan planrewriter rewritecontext rewrite planrewriter java 110 at com facebook presto sql planner optimization simplifyexpression rewriter visitproject simplifyexpression java 91 at com facebook presto sql planner optimization simplifyexpression rewriter visitproject simplifyexpression java 70 at com facebook presto sql planner plan projectnode accept projectnode java 81 at com facebook presto sql planner plan planrewriter rewritecontext rewrite planrewriter java 99 at com facebook presto sql planner plan planrewriter rewritecontext lambda defaultrewrite 41 planrewriter java 73 at com facebook presto sql planner plan planrewriter rewritecontext lambda 247 34398165 apply unknown source at java util stream referencepipeline 3 1 accept referencepipeline java 193 at java util iterator foreachremaine iterator java 116 at java util spliterators iteratorspliterator foreachremaine spliterator java 1801 at java util stream abstractpipeline copyinto abstractpipeline java 512 at java util stream abstractpipeline wrapandcopyinto abstractpipeline java 502 at java util stream reduceop reduceop evaluatesequential reduceop java 708 at java util stream abstractpipeline evaluate abstractpipeline java 234 at java util stream referencepipeline collect referencepipeline java 499 at com facebook presto sql planner plan planrewriter rewritecontext defaultrewrite planrewriter java 74 at com facebook presto sql planner plan planrewriter visitplan planrewriter java 38 at com facebook presto sql planner plan planrewriter visitplan planrewriter java 22 at com facebook presto sql planner plan planvisitor visitoutput planvisitor java 50 at com facebook presto sql planner plan outputnode accept outputnode java 79 at com facebook presto sql planner plan planrewriter rewritewith planrewriter java 27 at com facebook presto sql planner optimization simplifyexpression optimize simplifyexpression java 67 at com facebook presto sql planner logicalplanner plan logicalplanner java 93 at com facebook presto execution sqlqueryexecution doanalyzequery sqlqueryexecution java 258 at com facebook presto execution sqlqueryexecution analyzequery sqlqueryexecution java 237 at com facebook presto execution sqlqueryexecution start sqlqueryexecution java 201 at com facebook presto execution queuedexecution lambda start 61 queuedexecution java 68 at com facebook presto execution queuedexecution lambda 236 1947247162 run unknown source at java util concurrent threadpoolexecutor runworker threadpoolexecutor java 1142 at java util concurrent threadpoolexecutor worker run threadpoolexecutor java 617 at java lang thread run thread java 745
prestodbpresto
window clause for common window frame
Enhancement
in query with multiple common window frame presto should support the window clause select sum salary over w avg salary over w from empsalary window w as partition by depname order by salary desc
prestodbpresto
add shard checksum to raptor
Enhancement
need to decide what checksum to use possibly multiple xxhash64 sha256 etc use both could allow more frequent verification use the fast one but still have the large checksum for less frequent or manual verification when a problem occur
prestodbpresto
track system memory usage
Enhancement
track all memory use by internally by the presto engine when run a user s query for example buffer in exchange s and sharedbuffer s this can then be use to dynamically adjust the number of task run on a worker or the size of buffer it will also allow we to reduce the default size of resource reserve system memory
prestodbpresto
cpu time limit for query
Enhancement
we should support cpu time base limit on query similarly to how memory limit work this should go in clustermemorymanager process and work similarly to how the memory limit be enforce you can get the total cpu time for the query from queryexecution getqueryinfo getquerystat but you may want to add a method to get it directly from a queryexecution similar to gettotalmemoryreservation
prestodbpresto
nullpointerexception when use approximate at
Bug
I try to use approximate query but it throw nullpointerexception query be select count from lineitem approximate at 95 0 confidence error message be java lang nullpointerexception at com facebook presto sql planner localexecutionplanner visitor buildaccumulatorfactory localexecutionplanner java 1623 at com facebook presto sql planner localexecutionplanner visitor planglobalaggregation localexecutionplanner java 1634 at com facebook presto sql planner localexecutionplanner visitor visitaggregation localexecutionplanner java 687 at com facebook presto sql planner localexecutionplanner visitor visitaggregation localexecutionplanner java 410 at com facebook presto sql planner plan aggregationnode accept aggregationnode java 160 at com facebook presto sql planner localexecutionplanner plan localexecutionplanner java 242 at com facebook presto execution sqltaskexecution sqltaskexecution java 165 at com facebook presto execution sqltaskexecution createsqltaskexecution sqltaskexecution java 114 at com facebook presto execution sqltaskexecutionfactory create sqltaskexecutionfactory java 77 at com facebook presto execution sqltask updatetask sqltask java 229 at com facebook presto execution sqltaskmanager updatetask sqltaskmanager java 265 at com facebook presto server taskresource createorupdatetask taskresource java 103 at sun reflect nativemethodaccessorimpl invoke0 native method at sun reflect nativemethodaccessorimpl invoke nativemethodaccessorimpl java 62 at sun reflect delegatingmethodaccessorimpl invoke delegatingmethodaccessorimpl java 43 at java lang reflect method invoke method java 497 at org glassfish jersey server model internal resourcemethodinvocationhandlerfactory 1 invoke resourcemethodinvocationhandlerfactory java 81 at org glassfish jersey server model internal abstractjavaresourcemethoddispatcher 1 run abstractjavaresourcemethoddispatcher java 151 at org glassfish jersey server model internal abstractjavaresourcemethoddispatcher invoke abstractjavaresourcemethoddispatcher java 171 at org glassfish jersey server model internal javaresourcemethoddispatcherprovider responseoutinvoker dodispatch javaresourcemethoddispatcherprovider java 152 at org glassfish jersey server model internal abstractjavaresourcemethoddispatcher dispatch abstractjavaresourcemethoddispatcher java 104 at org glassfish jersey server model resourcemethodinvoker invoke resourcemethodinvoker java 387 at org glassfish jersey server model resourcemethodinvoker apply resourcemethodinvoker java 331 at org glassfish jersey server model resourcemethodinvoker apply resourcemethodinvoker java 103 at org glassfish jersey server serverruntime 1 run serverruntime java 271 at org glassfish jersey internal error 1 call error java 271 at org glassfish jersey internal error 1 call error java 267 at org glassfish jersey internal error process error java 315 at org glassfish jersey internal error process error java 297 at org glassfish jersey internal error process error java 267 at org glassfish jersey process internal requestscope runinscope requestscope java 297 at org glassfish jersey server serverruntime process serverruntime java 254 at org glassfish jersey server applicationhandler handle applicationhandler java 1030 at org glassfish jersey servlet webcomponent service webcomponent java 373 at org glassfish jersey servlet servletcontainer service servletcontainer java 381 at org glassfish jersey servlet servletcontainer service servletcontainer java 344 at org glassfish jersey servlet servletcontainer service servletcontainer java 221 at org eclipse jetty servlet servletholder handle servletholder java 808 at org eclipse jetty servlet servlethandler cachedchain dofilter servlethandler java 1669 at org eclipse jetty servlets useragentfilter dofilter useragentfilter java 83 at org eclipse jetty servlets gzipfilter dofilter gzipfilter java 300 at org eclipse jetty servlet servlethandler cachedchain dofilter servlethandler java 1652 at io airlift http server tracetokenfilter dofilter tracetokenfilter java 62 at org eclipse jetty servlet servlethandler cachedchain dofilter servlethandler java 1652 at io airlift http server timingfilter dofilter timingfilter java 51 at org eclipse jetty servlet servlethandler cachedchain dofilter servlethandler java 1652 at org eclipse jetty servlet servlethandler dohandle servlethandler java 585 at org eclipse jetty server handler contexthandler dohandle contexthandler java 1127 at org eclipse jetty servlet servlethandler doscope servlethandler java 515 at org eclipse jetty server handler contexthandler doscope contexthandler java 1061 at org eclipse jetty server handler scopedhandler handle scopedhandler java 141 at org eclipse jetty server handler handlercollection handle handlercollection java 110 at org eclipse jetty server handler handlerwrapper handle handlerwrapper java 97 at org eclipse jetty server handler statisticshandler handle statisticshandler java 159 at org eclipse jetty server handler handlerlist handle handlerlist java 52 at org eclipse jetty server handler handlerwrapper handle handlerwrapper java 97 at org eclipse jetty server server handle server java 499 at org eclipse jetty server httpchannel handle httpchannel java 310 at org eclipse jetty server httpconnection onfillable httpconnection java 257 at org eclipse jetty io abstractconnection 2 run abstractconnection java 540 at org eclipse jetty util thread queuedthreadpool runjob queuedthreadpool java 635 at org eclipse jetty util thread queuedthreadpool 3 run queuedthreadpool java 555 at java lang thread run thread java 745
prestodbpresto
add topn and topn by
Enhancement
1 implement a custom block base heap like datum structure 2 with the above data structure topn and topn by can be implement without too much work alternative route implement both with single value block if it be immediately need
prestodbpresto
include error location information for unresolved function
Enhancement
query like select 1 1 fail with operator equal bigint varchar not register however the json return from v1 query doesn t include the line number also the error message should include the line number
prestodbpresto
explain fail when partition key be of date time type
Bug
this seem to happen when the domain of the partition be convert to a string because the coercion for those type require a connectorsession to be provide can not convert methodhandle connectorsession long slice to object object java lang invoke wrongmethodtypeexception java lang invoke methodhandle astypeuncached methodhandle java 773 java lang invoke methodhandle astype methodhandle java 759 java lang invoke methodhandle invokewithargument methodhandle java 625 com facebook presto sql planner planprinter formatdomain planprinter java 611 com facebook presto sql planner planprinter printconstraint planprinter java 591 com facebook presto sql planner planprinter access 200 planprinter java 89 com facebook presto sql planner planprinter visitor visittablescan planprinter java 412 com facebook presto sql planner planprinter visitor visittablescan planprinter java 186 com facebook presto sql planner plan tablescannode accept tablescannode java 135 com facebook presto sql planner planprinter visitor processchildren planprinter java 576 com facebook presto sql planner planprinter visitor visitexchange planprinter java 556 com facebook presto sql planner planprinter visitor visitexchange planprinter java 186 com facebook presto sql planner plan exchangenode accept exchangenode java 148 com facebook presto sql planner planprinter visitor processchildren planprinter java 576 com facebook presto sql planner planprinter visitor visitoutput planprinter java 485 com facebook presto sql planner planprinter visitor visitoutput planprinter java 186 com facebook presto sql planner plan outputnode accept outputnode java 79 com facebook presto sql planner planprinter planprinter java 108 com facebook presto sql planner planprinter planprinter java 96 com facebook presto sql planner planprinter textlogicalplan planprinter java 119 com facebook presto sql analyzer queryexplainer getplan queryexplainer java 61 com facebook presto sql analyzer statementanalyzer getqueryplan statementanalyzer java 497 com facebook presto sql analyzer statementanalyzer visitexplain statementanalyzer java 478 com facebook presto sql analyzer statementanalyzer visitexplain statementanalyzer java 115 com facebook presto sql tree explain accept explain java 54 com facebook presto sql tree astvisitor process astvisitor java 22 com facebook presto sql analyzer analyzer analyze analyzer java 52 com facebook presto execution sqlqueryexecution doanalyzequery sqlqueryexecution java 252 com facebook presto execution sqlqueryexecution analyzequery sqlqueryexecution java 238 com facebook presto execution sqlqueryexecution start sqlqueryexecution java 202 com facebook presto execution queuedexecution lambda start 130 queuedexecution java 68 com facebook presto execution queuedexecution lambda 252 1593766152 run unknown source java util concurrent threadpoolexecutor runworker threadpoolexecutor java 1142 java util concurrent threadpoolexecutor worker run threadpoolexecutor java 617 java lang thread run thread java 745
prestodbpresto
type inference break for overloaded function that produce null if any arg be null
Bug
for example presto explain select mod null null query plan output col0 mod bigint col0 mod project mod bigint mod cast null as bigint value there be two valid binding for the call to mod mod bigint bigint bigint and mod double double double in this case the bind be ambiguous but the result be deterministic null therefore the type of the result can be consider as both bigint and double but we don t know which so it should be report as unknown
prestodbpresto
union query fail for unknowntype
Bug
with configuration optimizer optimize hash generation true this query fail value null union value null stack trace com facebook presto spi prestoexception compiler fail and interpreter be disable at com facebook presto sql planner localexecutionplanner visitor visitscanfilterandproject localexecutionplanner java 909 at com facebook presto sql planner localexecutionplanner visitor visitproject localexecutionplanner java 808 at com facebook presto sql planner localexecutionplanner visitor visitproject localexecutionplanner java 410 at com facebook presto sql planner plan projectnode accept projectnode java 81 at com facebook presto sql planner localexecutionplanner visitor visitaggregation localexecutionplanner java 705 at com facebook presto sql planner localexecutionplanner visitor visitaggregation localexecutionplanner java 410 at com facebook presto sql planner plan aggregationnode accept aggregationnode java 160 at com facebook presto sql planner localexecutionplanner plan localexecutionplanner java 242 at com facebook presto execution sqltaskexecution sqltaskexecution java 164 at com facebook presto execution sqltaskexecution createsqltaskexecution sqltaskexecution java 115 at com facebook presto execution sqltaskexecutionfactory create sqltaskexecutionfactory java 80 at com facebook presto execution sqltask updatetask sqltask java 229 at com facebook presto execution sqltaskmanager updatetask sqltaskmanager java 265 at com facebook presto server taskresource createorupdatetask taskresource java 103 at sun reflect generatedmethodaccessor537 invoke unknown source at sun reflect delegatingmethodaccessorimpl invoke delegatingmethodaccessorimpl java 43 at java lang reflect method invoke method java 483 at org glassfish jersey server model internal resourcemethodinvocationhandlerfactory 1 invoke resourcemethodinvocationhandlerfactory java 81 at org glassfish jersey server model internal abstractjavaresourcemethoddispatcher 1 run abstractjavaresourcemethoddispatcher java 151 at org glassfish jersey server model internal abstractjavaresourcemethoddispatcher invoke abstractjavaresourcemethoddispatcher java 171 at org glassfish jersey server model internal javaresourcemethoddispatcherprovider responseoutinvoker dodispatch javaresourcemethoddispatcherprovider java 152 at org glassfish jersey server model internal abstractjavaresourcemethoddispatcher dispatch abstractjavaresourcemethoddispatcher java 104 at org glassfish jersey server model resourcemethodinvoker invoke resourcemethodinvoker java 387 at org glassfish jersey server model resourcemethodinvoker apply resourcemethodinvoker java 331 at org glassfish jersey server model resourcemethodinvoker apply resourcemethodinvoker java 103 at org glassfish jersey server serverruntime 1 run serverruntime java 271 at org glassfish jersey internal error 1 call error java 271 at org glassfish jersey internal error 1 call error java 267 at org glassfish jersey internal error process error java 315 at org glassfish jersey internal error process error java 297 at org glassfish jersey internal error process error java 267 at org glassfish jersey process internal requestscope runinscope requestscope java 297 at org glassfish jersey server serverruntime process serverruntime java 254 at org glassfish jersey server applicationhandler handle applicationhandler java 1030 at org glassfish jersey servlet webcomponent service webcomponent java 373 at org glassfish jersey servlet servletcontainer service servletcontainer java 381 at org glassfish jersey servlet servletcontainer service servletcontainer java 344 at org glassfish jersey servlet servletcontainer service servletcontainer java 221 at org eclipse jetty servlet servletholder handle servletholder java 808 at org eclipse jetty servlet servlethandler cachedchain dofilter servlethandler java 1669 at org eclipse jetty servlets useragentfilter dofilter useragentfilter java 83 at org eclipse jetty servlets gzipfilter dofilter gzipfilter java 300 at org eclipse jetty servlet servlethandler cachedchain dofilter servlethandler java 1652 at io airlift http server tracetokenfilter dofilter tracetokenfilter java 62 at org eclipse jetty servlet servlethandler cachedchain dofilter servlethandler java 1652 at io airlift http server timingfilter dofilter timingfilter java 51 at org eclipse jetty servlet servlethandler cachedchain dofilter servlethandler java 1652 at org eclipse jetty servlet servlethandler dohandle servlethandler java 585 at org eclipse jetty server handler contexthandler dohandle contexthandler java 1127 at org eclipse jetty servlet servlethandler doscope servlethandler java 515 at org eclipse jetty server handler contexthandler doscope contexthandler java 1061 at org eclipse jetty server handler scopedhandler handle scopedhandler java 141 at org eclipse jetty server handler handlercollection handle handlercollection java 110 at org eclipse jetty server handler handlerwrapper handle handlerwrapper java 97 at org eclipse jetty server handler statisticshandler handle statisticshandler java 159 at org eclipse jetty server handler handlerlist handle handlerlist java 52 at org eclipse jetty server handler handlerwrapper handle handlerwrapper java 97 at org eclipse jetty server server handle server java 499 at org eclipse jetty server httpchannel handle httpchannel java 310 at org eclipse jetty server httpconnection onfillable httpconnection java 257 at org eclipse jetty io abstractconnection 2 run abstractconnection java 540 at org eclipse jetty util thread queuedthreadpool runjob queuedthreadpool java 635 at org eclipse jetty util thread queuedthreadpool 3 run queuedthreadpool java 555 at java lang thread run thread java 745 cause by com google common util concurrent uncheckedexecutionexception java lang arrayindexoutofboundsexception 1 at com google common cache localcache segment get localcache java 2203 at com google common cache localcache get localcache java 3937 at com google common cache localcache getorload localcache java 3941 at com google common cache localcache localloadingcache get localcache java 4824 at com google common cache localcache localloadingcache getunchecke localcache java 4830 at com facebook presto sql gen expressioncompiler compilepageprocessor expressioncompiler java 87 at com facebook presto sql planner localexecutionplanner visitor visitscanfilterandproject localexecutionplanner java 897 63 more cause by java lang arrayindexoutofboundsexception 1 at org objectweb asm frame a unknown source at org objectweb asm methodwriter visitmax unknown source at com facebook presto bytecode methoddefinition visit methoddefinition java 253 at com facebook presto bytecode methoddefinition visit methoddefinition java 207 at com facebook presto bytecode classdefinition visit classdefinition java 158 at com facebook presto sql gen compilerutil defineclasse compilerutil java 100 at com facebook presto sql gen compilerutil defineclass compilerutil java 74 at com facebook presto sql gen compilerutil defineclass compilerutil java 80 at com facebook presto sql gen expressioncompiler compileprocessor expressioncompiler java 130 at com facebook presto sql gen expressioncompiler compileandinstantiate expressioncompiler java 93 at com facebook presto sql gen expressioncompiler access 300 expressioncompiler java 42 at com facebook presto sql gen expressioncompiler 1 load expressioncompiler java 53 at com facebook presto sql gen expressioncompiler 1 load expressioncompiler java 48 at com google common cache localcache loadingvaluereference loadfuture localcache java 3527 at com google common cache localcache segment loadsync localcache java 2319 at com google common cache localcache segment lockedgetorload localcache java 2282 at com google common cache localcache segment get localcache java 2197 69 more
prestodbpresto
add more failure info to querycompletionevent
Enhancement
we need to know the task i d and the machine on which the failure occur this help with find log relate to a failure correlating machine with high than average failure count etc
prestodbpresto
analyzer error when row field reference be use in aggregation query
Bug
the follow query add it to abstracttestquerie select a col0 count from value row test row 1 1 t a fail with an exception instead of a col0 not in group by clause java lang illegalstateexception no field for name a col0 at com google common base precondition checkstate precondition java 197 at com facebook presto sql analyzer aggregationanalyzer visitor visitqualifiednamereference aggregationanalyzer java 339 at com facebook presto sql analyzer aggregationanalyzer visitor visitqualifiednamereference aggregationanalyzer java 133 at com facebook presto sql tree qualifiednamereference accept qualifiednamereference java 39 at com facebook presto sql tree astvisitor process astvisitor java 22 at com facebook presto sql analyzer aggregationanalyzer visitor process aggregationanalyzer java 428 at com facebook presto sql analyzer aggregationanalyzer analyze aggregationanalyzer java 128 at com facebook presto sql analyzer tupleanalyzer verifyaggregation tupleanalyzer java 1024 at com facebook presto sql analyzer tupleanalyzer analyzeaggregation tupleanalyzer java 987 at com facebook presto sql analyzer tupleanalyzer visitqueryspecification tupleanalyzer java 358 at com facebook presto sql analyzer tupleanalyzer visitqueryspecification tupleanalyzer java 135 at com facebook presto sql tree queryspecification accept queryspecification java 98 at com facebook presto sql tree astvisitor process astvisitor java 22 at com facebook presto sql analyzer statementanalyzer visitquery statementanalyzer java 520 at com facebook presto sql analyzer statementanalyzer visitquery statementanalyzer java 115 at com facebook presto sql tree query accept query java 80 at com facebook presto sql tree astvisitor process astvisitor java 22 at com facebook presto sql analyzer analyzer analyze analyzer java 52 at com facebook presto testing localqueryrunner createdriver localqueryrunner java 362 at com facebook presto testing localqueryrunner execute localqueryrunner java 324 at com facebook presto test abstracttestqueryframework computeactual abstracttestqueryframework java 83 at com facebook presto test abstracttestqueryframework computeactual abstracttestqueryframework java 78 at com facebook presto test abstracttestquerie testsomethe abstracttestquerie java 4292
prestodbpresto
bad error message when cast to parametric type without type parameter
Bug
select cast null as map fail with query 20150625 162057 09252 bhbmd fail expect two type java lang illegalargumentexception expect two type at com google common base precondition checkargument precondition java 122 at com facebook presto type mapparametrictype createtype mapparametrictype java 41 at com facebook presto type mapparametrictype createtype mapparametrictype java 23 at com facebook presto type typeregistry instantiateparametrictype typeregistry java 136 at com facebook presto type typeregistry gettype typeregistry java 110 at com facebook presto sql analyzer expressionanalyzer visitor visitcast expressionanalyzer java 726 at com facebook presto sql analyzer expressionanalyzer visitor visitcast expressionanalyzer java 206 at com facebook presto sql tree cast accept cast java 61 at com facebook presto sql analyzer expressionanalyzer analyze expressionanalyzer java 179 at com facebook presto sql analyzer expressionanalyzer analyzeexpression expressionanalyzer java 1018 at com facebook presto sql analyzer tupleanalyzer analyzeexpression tupleanalyzer java 1106 at com facebook presto sql analyzer tupleanalyzer analyzeselect tupleanalyzer java 913 at com facebook presto sql analyzer tupleanalyzer visitqueryspecification tupleanalyzer java 353 at com facebook presto sql analyzer tupleanalyzer visitqueryspecification tupleanalyzer java 135 at com facebook presto sql tree queryspecification accept queryspecification java 98 at com facebook presto sql tree astvisitor process astvisitor java 22 at com facebook presto sql analyzer statementanalyzer visitquery statementanalyzer java 520 at com facebook presto sql analyzer statementanalyzer visitquery statementanalyzer java 115 at com facebook presto sql tree query accept query java 80 at com facebook presto sql tree astvisitor process astvisitor java 22 at com facebook presto sql analyzer analyzer analyze analyzer java 52 at com facebook presto execution sqlqueryexecution doanalyzequery sqlqueryexecution java 252 at com facebook presto execution sqlqueryexecution analyzequery sqlqueryexecution java 238 at com facebook presto execution sqlqueryexecution start sqlqueryexecution java 202 at com facebook presto execution queuedexecution lambda start 130 queuedexecution java 68 at com facebook presto execution queuedexecution lambda 237 901458406 run unknown source at java util concurrent threadpoolexecutor runworker threadpoolexecutor java 1142 at java util concurrent threadpoolexecutor worker run threadpoolexecutor java 617 at java lang thread run thread java 745
prestodbpresto
use direct switch for small in list of small primitive
Enhancement
if all of the constant fit in an int less than 2 32 we can switch on the value directly rather than on the hash code this remove both the hash computation of the lookup value and the extra comparison when the hash match l102
prestodbpresto
remove box for in list of primitive
Enhancement
l129
prestodbpresto
support limit all
Enhancement
in some database like postsgresql mysql limit all have the same effect as eliminate the limit clause from a query it return all the row currently it give error in presto that the argument of limit clause must be an integer
prestodbpresto
fix fragment number in explain type distribute
Enhancement
the fragment number do not match the stage number for trivial query they be in the opposite order fix this be a bit more complicated than just munge the number because the plan be a tree
prestodbpresto
topnrownumber optimizer should support composite expression
Enhancement
the follow optimizes correctly sql with t as select x row number over order by x rn from select x from t where rn 10 but these do not sql with t as select x row number over order by x rn from select x from select x from t where rn 10 where rn 5 with t as select x row number over order by x rn from select x from select x from t where rn 10 where x be not null
prestodbpresto
jdbc driver java sql statement setmaxrow not implement
Enhancement
this method doesn t do anything in term of limit the number of row return the implementation should be the same as use the limit clause in sql implement this method be important for gui tool many client tool will use a separate text box where user define the maximum number of row to preview since there be no ansi sql way to limit row from sql yes there be limit but that s rarely support and non generic use the presto driver on a big database be risky and can make the client tool run out of memory very easily
prestodbpresto
topnrownumber should support equality
Enhancement
the follow query should both optimize to use topnrownumber sql select x from select x row number over order by x rn from where rn 1 select x from select x row number over order by x rn from where rn 1 currently only the version work there be actually two case to support convert 1 to 1 as they be equivalent only work for 1 not other value convert x to topnrownumber and add a x filter on top
prestodbpresto
add max size set for hive over s3
Enhancement
prestodb note how much data be be read to execute a query the hive adapter can read datum from a remote source such as amazon s3 presto could cancel a query if the total size read reach a configurable limit avoid unwanted cost for complex or poorly optimize query
prestodbpresto
add mechanism to select which plugin be enable at runtime
Enhancement
currently any plugin that s bundle in the presto package be automatically enable at runtime only connector can be mount selectively but every type and function provider be register automatically
prestodbpresto
expose metaphone and soundex method
Enhancement
they may already be shade in some of the hive lib though I m not sure that help all datum source
prestodbpresto
add support for scalar subquerie
Enhancement
scalar sub query be not support for example sql select from nation where nation key select nation key from nation where name algeria limit 1
prestodbpresto
date format use w day of week return incorrect value 1 7 not 0 6
Bug
when use date format with the w specifi for day of week we get incorrect value presto default select date format date parse 2015 05 03 11 00 y m d h I w col0 7 1 row accord to the documentation w day of the week 0 6 where sunday be the first day of the week 2015 05 03 be a sunday so we should expect this to return 0 not 7 also 7 be out of range of the value expect accord to the documentation testing with a date know to be a monday presto default select date format date parse 2015 05 04 11 00 y m d h I w col0 1 1 row be this a documentation bug or an actual bug presto version be 0 101
prestodbpresto
field reference operator do not work for field name with uppercase letter
Bug
the field reference operator should follow the same resolution rule as all other identifier this bug be most likely because rowparametrictype createfunction do not lower case the function name
prestodbpresto
window function in where clause should fail with analysis error
Bug
when fix this we should check other place that window function could erroneously be use presto select from value 1 t x where lag x 1 query 20150415 231524 22369 7mzjt fail compiler fail and interpreter be disabled com facebook presto spi prestoexception compiler fail and interpreter be disable at com facebook presto sql planner localexecutionplanner visitor visitscanfilterandproject localexecutionplanner java 824 at com facebook presto sql planner localexecutionplanner visitor visitfilter localexecutionplanner java 703 at com facebook presto sql planner localexecutionplanner visitor visitfilter localexecutionplanner java 379 at com facebook presto sql planner plan filternode accept filternode java 71 at com facebook presto sql planner localexecutionplanner visitor visitoutput localexecutionplanner java 402 at com facebook presto sql planner localexecutionplanner visitor visitoutput localexecutionplanner java 379 at com facebook presto sql planner plan outputnode accept outputnode java 79 at com facebook presto sql planner localexecutionplanner plan localexecutionplanner java 223 at com facebook presto execution sqltaskexecution sqltaskexecution java 147 at com facebook presto execution sqltaskexecution createsqltaskexecution sqltaskexecution java 109 at com facebook presto execution sqltaskexecutionfactory create sqltaskexecutionfactory java 101 at com facebook presto execution sqltask updatetask sqltask java 224 at com facebook presto execution sqltaskmanager updatetask sqltaskmanager java 217 at com facebook presto server taskresource createorupdatetask taskresource java 103 at sun reflect generatedmethodaccessor600 invoke unknown source at sun reflect delegatingmethodaccessorimpl invoke delegatingmethodaccessorimpl java 43 at java lang reflect method invoke method java 497 at org glassfish jersey server model internal resourcemethodinvocationhandlerfactory 1 invoke resourcemethodinvocationhandlerfactory java 81 at org glassfish jersey server model internal abstractjavaresourcemethoddispatcher 1 run abstractjavaresourcemethoddispatcher java 151 at org glassfish jersey server model internal abstractjavaresourcemethoddispatcher invoke abstractjavaresourcemethoddispatcher java 171 at org glassfish jersey server model internal javaresourcemethoddispatcherprovider responseoutinvoker dodispatch javaresourcemethoddispatcherprovider java 152 at org glassfish jersey server model internal abstractjavaresourcemethoddispatcher dispatch abstractjavaresourcemethoddispatcher java 104 at org glassfish jersey server model resourcemethodinvoker invoke resourcemethodinvoker java 387 at org glassfish jersey server model resourcemethodinvoker apply resourcemethodinvoker java 331 at org glassfish jersey server model resourcemethodinvoker apply resourcemethodinvoker java 103 at org glassfish jersey server serverruntime 1 run serverruntime java 271 at org glassfish jersey internal error 1 call error java 271 at org glassfish jersey internal error 1 call error java 267 at org glassfish jersey internal error process error java 315 at org glassfish jersey internal error process error java 297 at org glassfish jersey internal error process error java 267 at org glassfish jersey process internal requestscope runinscope requestscope java 297 at org glassfish jersey server serverruntime process serverruntime java 254 at org glassfish jersey server applicationhandler handle applicationhandler java 1030 at org glassfish jersey servlet webcomponent service webcomponent java 373 at org glassfish jersey servlet servletcontainer service servletcontainer java 381 at org glassfish jersey servlet servletcontainer service servletcontainer java 344 at org glassfish jersey servlet servletcontainer service servletcontainer java 221 at org eclipse jetty servlet servletholder handle servletholder java 808 at org eclipse jetty servlet servlethandler cachedchain dofilter servlethandler java 1669 at org eclipse jetty servlets useragentfilter dofilter useragentfilter java 83 at org eclipse jetty servlets gzipfilter dofilter gzipfilter java 300 at org eclipse jetty servlet servlethandler cachedchain dofilter servlethandler java 1652 at io airlift http server tracetokenfilter dofilter tracetokenfilter java 62 at org eclipse jetty servlet servlethandler cachedchain dofilter servlethandler java 1652 at io airlift http server timingfilter dofilter timingfilter java 51 at org eclipse jetty servlet servlethandler cachedchain dofilter servlethandler java 1652 at org eclipse jetty servlet servlethandler dohandle servlethandler java 585 at org eclipse jetty server handler contexthandler dohandle contexthandler java 1127 at org eclipse jetty servlet servlethandler doscope servlethandler java 515 at org eclipse jetty server handler contexthandler doscope contexthandler java 1061 at org eclipse jetty server handler scopedhandler handle scopedhandler java 141 at org eclipse jetty server handler handlercollection handle handlercollection java 110 at org eclipse jetty server handler handlerwrapper handle handlerwrapper java 97 at org eclipse jetty server handler statisticshandler handle statisticshandler java 159 at org eclipse jetty server handler handlerlist handle handlerlist java 52 at org eclipse jetty server handler handlerwrapper handle handlerwrapper java 97 at org eclipse jetty server server handle server java 497 at org eclipse jetty server httpchannel handle httpchannel java 310 at org eclipse jetty server httpconnection onfillable httpconnection java 257 at org eclipse jetty io abstractconnection 2 run abstractconnection java 540 at org eclipse jetty util thread queuedthreadpool runjob queuedthreadpool java 635 at org eclipse jetty util thread queuedthreadpool 3 run queuedthreadpool java 555 at java lang thread run thread java 745 cause by com google common util concurrent uncheckedexecutionexception java lang illegalstateexception not a scalar function or operator at com google common cache localcache segment get localcache java 2203 at com google common cache localcache get localcache java 3937 at com google common cache localcache getorload localcache java 3941 at com google common cache localcache localloadingcache get localcache java 4824 at com google common cache localcache localloadingcache getunchecke localcache java 4830 at com facebook presto sql gen expressioncompiler compilepageprocessor expressioncompiler java 89 at com facebook presto sql planner localexecutionplanner visitor visitscanfilterandproject localexecutionplanner java 812 63 more cause by java lang illegalstateexception not a scalar function or operator at com google common base precondition checkstate precondition java 173 at com facebook presto metadata functioninfo getmethodhandle functioninfo java 202 at com facebook presto sql gen bytecodegeneratorcontext generatecall bytecodegeneratorcontext java 76 at com facebook presto sql gen functioncallcodegenerator generateexpression functioncallcodegenerator java 49 at com facebook presto sql gen bytecodeexpressionvisitor visitcall bytecodeexpressionvisitor java 110 at com facebook presto sql gen bytecodeexpressionvisitor visitcall bytecodeexpressionvisitor java 40 at com facebook presto sql relational callexpression accept callexpression java 87 at com facebook presto sql gen bytecodegeneratorcontext generate bytecodegeneratorcontext java 63 at com facebook presto sql gen functioncallcodegenerator generateexpression functioncallcodegenerator java 46 at com facebook presto sql gen bytecodeexpressionvisitor visitcall bytecodeexpressionvisitor java 110 at com facebook presto sql gen bytecodeexpressionvisitor visitcall bytecodeexpressionvisitor java 40 at com facebook presto sql relational callexpression accept callexpression java 87 at com facebook presto sql gen pageprocessorcompiler generatefiltermethod pageprocessorcompiler java 222 at com facebook presto sql gen pageprocessorcompiler generatemethod pageprocessorcompiler java 74 at com facebook presto sql gen expressioncompiler compileprocessor expressioncompiler java 119 at com facebook presto sql gen expressioncompiler compileandinstantiate expressioncompiler java 95 at com facebook presto sql gen expressioncompiler access 300 expressioncompiler java 44 at com facebook presto sql gen expressioncompiler 1 load expressioncompiler java 55 at com facebook presto sql gen expressioncompiler 1 load expressioncompiler java 50 at com google common cache localcache loadingvaluereference loadfuture localcache java 3527 at com google common cache localcache segment loadsync localcache java 2319 at com google common cache localcache segment lockedgetorload localcache java 2282 at com google common cache localcache segment get localcache java 2197 69 more
prestodbpresto
add error code to queryerror
Bug
queryerror errorcode be currently always set to 0 it should be set to the correct error code additionally we should add errorname from errorcode name and errortype
prestodbpresto
support offset in select
Enhancement
limit be support be it possible to add offset as well I understand I can do that manually but have native support would be nice the downside of manual paging be more datum transmit over the wire from server to client
prestodbpresto
implement range precede for window function
Enhancement
this query should work sql select sum x over order by x range 1 precede from value 1 1 2 2 t x it currently fail with window frame range precede be only support with unbounded
prestodbpresto
regexp like be n 2
Enhancement
the regexp like function use matcher find and this function apply the pattern at every character instead we should prefix and suffix the pattern with and use match
prestodbpresto
bad error message for invalid type
Bug
presto select cast null as array query 20150225 002641 00750 u2hj3 fail null java lang nullpointerexception at com google common base precondition checknotnull precondition java 210 at com google common collect immutablecollection arraybasedbuilder add immutablecollection java 339 at com google common collect immutablelist builder add immutablelist java 652 at com facebook presto type typeregistry instantiateparametrictype typeregistry java 125 at com facebook presto type typeregistry gettype typeregistry java 110 at com facebook presto metadata metadatamanager gettype metadatamanager java 141 at com facebook presto sql analyzer expressionanalyzer visitor visitcast expressionanalyzer java 700 at com facebook presto sql analyzer expressionanalyzer visitor visitcast expressionanalyzer java 181 at com facebook presto sql tree cast accept cast java 61 at com facebook presto sql analyzer expressionanalyzer analyze expressionanalyzer java 178 at com facebook presto sql analyzer expressionanalyzer analyzeexpression expressionanalyzer java 992 at com facebook presto sql analyzer tupleanalyzer analyzeexpression tupleanalyzer java 1064 at com facebook presto sql analyzer tupleanalyzer analyzeselect tupleanalyzer java 867 at com facebook presto sql analyzer tupleanalyzer visitqueryspecification tupleanalyzer java 347 at com facebook presto sql analyzer tupleanalyzer visitqueryspecification tupleanalyzer java 132 at com facebook presto sql tree queryspecification accept queryspecification java 98 at com facebook presto sql tree astvisitor process astvisitor java 22 at com facebook presto sql analyzer statementanalyzer visitquery statementanalyzer java 502 at com facebook presto sql analyzer statementanalyzer visitquery statementanalyzer java 114 at com facebook presto sql tree query accept query java 80 at com facebook presto sql tree astvisitor process astvisitor java 22 at com facebook presto sql analyzer analyzer analyze analyzer java 52 at com facebook presto execution sqlqueryexecution doanalyzequery sqlqueryexecution java 198 at com facebook presto execution sqlqueryexecution analyzequery sqlqueryexecution java 184 at com facebook presto execution sqlqueryexecution start sqlqueryexecution java 145 at com facebook presto execution sqlquerymanager querystarter queryqueue lambda null 42 sqlquerymanager java 473 at com facebook presto execution sqlquerymanager querystarter queryqueue lambda 162 80977279 run unknown source at java util concurrent threadpoolexecutor runworker threadpoolexecutor java 1142 at java util concurrent threadpoolexecutor worker run threadpoolexecutor java 617 at java lang thread run thread java 745
prestodbpresto
show stack trace on query detail page in ui
Enhancement
for fail query it would be very useful if the ui could display the stack trace like the cli do when use debug
prestodbpresto
detect quick worker restart and fail query immediately
Bug
when a worker restart the engine may not notice the change and wait for work that will never complete an easy fix for this be to add the node instance i d to task info and then the httpremotetask would see the change and fail the task this issue be identify by have a task stuck in the running state with 0 split assign if there be multiple query they will all be stick on the same node or node that reboot
prestodbpresto
implement hash function
Enhancement
implement a generic hash function that take any number of argument of any type and return the hash of the value as a bigint the type of the hash be system dependent and subject to change between release this function will be useful for thing like bucketing or sample where the result of the hash be not store and be only use during the query this can be implement use the hash method of block though we might want to augment that in the future with a 64 bit version
prestodbpresto
fix use clause for join
Bug
column that appear in a use clause should not require qualification this be particularly useful for outer join because the non qualified reference always reference the non null value it be not clear if qualifying reference be allow postgresql allow it but oracle do not allow it be useful in order to do be null check for outer join especially when no other column be available presto select x from value 1 a x join value 1 b x use x query 20150202 160415 12625 wu6ji fail column x be ambiguous additionally because use make they the same column the column should only appear once in the output descriptor presto select from value 1 a x join value 1 b x use x x x 1 1 1 row correct behavior for the above postgresql select x from value 1 a x join value 1 b x use x x 1 1 row postgresql select from value 1 a x join value 1 b x use x x 1 1 row additional test case that should return the value from the outside of the join sql select x from value 1 2 a x leave join value 1 b x use x select x from value 1 a x right join value 1 2 b x use x
prestodbpresto
implement xxhash64 function
Enhancement
the function should take varbinary as an argument and return a bigint since we don t have fix size binary type yet or function to operate on they effectively with the 64 bit two s complement interpretation of the little endian representation of the result hash
prestodbpresto
insert should ignore hide column
Bug
when do an insert that do not specify the column list which be not yet support the column list should only be the visible column not hide column thus it should be equivalent to the column return by select from t for example use the tpch connector presto tiny describe region column type null partition key comment regionkey bigint true false name varchar true false comment varchar true false 3 row presto tiny select from region limit 0 regionkey name comment 0 row however the check in statementanalyzer be include the hidden row number column presto tiny insert into region select from region query 20150129 235057 00017 b9dwj fail insert query have mismatch column type table bigint varchar varchar bigint query bigint varchar varchar
prestodbpresto
allow valuesnode with 0 row
Enhancement
once this be fix update limitpushdown to create an empty valuesnode instead of a limit 0 on top of a single row valuesnode
prestodbpresto
add option to cli to configure sock proxy
Enhancement
the httpclient in com facebook presto cli queryrunner use a hard code config with no sock proxy support we need to make this configurable via a command line option to the cli
prestodbpresto
add jmx predicate pushdown for node
Enhancement
run a query like this should only generate a split for that specific node sql select from jmx jmx java lang type runtime where node
prestodbpresto
bad error message for hive insert
Bug
the begininsert method in hivemetadata throw unsupportedoperationexception which result in a horrible error message we should support insert but in the mean time the error message should be fix by throw the correct exception java throw new prestoexception not support insert not yet support for hive the commitinsert method should be fix as well
prestodbpresto
add optimizer for limit 0
Enhancement
currently the plan a query with limit 0 include all node under the limit this cause presto to start schedule the query and then tear down the query instead the plan nod under a limit 0 node should be replace with an empty value node which will cause the query to complete instantly
prestodbpresto
incorrect plan with nest query involve rand
Bug
the follow query select u from select if rand 0 5 0 1 as u where u u produce the follow incorrect plan output u expr bigint u expr project expr bigint expr case when rand 0 5 then 0 else 1 end filter case when rand 0 5 then 0 else 1 end case when rand 0 5 then 0 else 1 end value this be probably a bug in the predicate pushdown optimization when handle non deterministic function
prestodbpresto
add support for hash partition semijoin
Enhancement
semijoin query see example below currently execute use broadcast strategy even if distribute join be enable sql select from t where a in select b from u see l338
prestodbpresto
add memory usage tracking to orcpagesource
Enhancement
read orc datum require large amount so memory which be currently not track by the presto resource system this can lead to worker crash implement this tracking will take a number of change to presto from the top down 1 add a memory resource tracker interface to spi and pass into connectorpagesourceprovider createpagesource 2 change tablescanoperator and scanfilterandprojectoperator to connect operatorcontext memory reservation to the resource tracker and pass this to pagesourceprovider createpagesource 3 modify class between pagesourceprovider and orcpagesourcefactory to pass through the tracker 4 change hdfsorcdatasource to ask for memory before allocate buffer
prestodbpresto
dynamically adapt hive partition to table schema
Enhancement
hive allow partition to have a different schema than the table and then apply implicit coercion to adapt the partition to the table presto should implement the same behavior before we get go on this I d like to document the coercion hive support we should produce the full matrix of convert all type to every other type for example what do hive do when convert a non numeric string to a number a number to a date etc implement this will require a number of change to the hive connector 1 the hivesplit will need to carry the type of the column in the partition normal hivecolumnhandle s carry the type of the table 2 detect a valid schema change in hivepagesourceprovider 3 add a recordcursor wrapper that perform coercion on read 4 add a connectorpagesource wrapper that perform coercion in block assureloade unfortunately to keep lazy read work the coercion logic will need to be implement twice once for record orient reader and once for column orient reader
prestodbpresto
improve syntax error from parser
Enhancement
this technique seem very applicable to presto
prestodbpresto
json function need categorize error
Bug
this be one example but there might be other the unit test need to include negative test as well see assertinvalidfunction in teststringfunction presto select json extract scalar cause by java lang stringindexoutofboundsexception string index out of range 0
prestodbpresto
bad error message for unhandled
Bug
this be cause by an uncategorized error come from the function which should be fix independently but uncategorized error should not result in a compiler fail error message presto tiny select json extract scalar query 20150109 183146 00009 t36py fail compiler fail and interpreter be disabled
prestodbpresto
can not select color type
Bug
presto tiny select rgb 0 0 0 2015 01 09t10 24 34 279 0800 debug main com facebook presto cli statusprinter error print status java lang runtimeexception error fetch next at return an invalid response jsonresponse statuscode 200 statusmessage ok header vary accept encode user agent content length 879 date fri 09 jan 2015 18 24 34 gmt x content type option nosniff content type application json hasvalue false value null at com facebook presto client statementclient requestfailedexception statementclient java 258 presto cli 0 90 snapshot executable jar 0 90 snapshot at com facebook presto client statementclient advance statementclient java 230 presto cli 0 90 snapshot executable jar 0 90 snapshot at com facebook presto cli statusprinter printinitialstatusupdate statusprinter java 94 presto cli 0 90 snapshot executable jar 0 90 snapshot at com facebook presto cli query renderqueryoutput query java 109 presto cli 0 90 snapshot executable jar 0 90 snapshot at com facebook presto cli query renderoutput query java 94 presto cli 0 90 snapshot executable jar 0 90 snapshot at com facebook presto cli console process console java 237 presto cli 0 90 snapshot executable jar 0 90 snapshot at com facebook presto cli console runconsole console java 179 presto cli 0 90 snapshot executable jar 0 90 snapshot at com facebook presto cli console run console java 109 presto cli 0 90 snapshot executable jar 0 90 snapshot at com facebook presto cli presto main presto java 31 presto cli 0 90 snapshot executable jar 0 90 snapshot cause by java lang illegalargumentexception unable to create class com facebook presto client queryresult from json response i d 20150109 182434 00005 t36py infouri partialcanceluri nexturi column name col0 type color typesignature rawtype color typeargument literalargument datum 000000 stat state run schedule false node 1 totalsplit 0 queuedsplit 0 runningsplit 0 completedsplit 0 usertimemillis 0 cputimemillis 0 walltimemillis 0 processedrow 0 processedbyte 0 rootstage stageid 0 state schedule do false node 1 totalsplit 0 queuedsplit 0 runningsplit 0 completedsplit 0 usertimemillis 0 cputimemillis 0 walltimemillis 0 processedrow 0 processedbyte 0 substage at io airlift http client fulljsonresponsehandler jsonresponse fulljsonresponsehandler java 119 presto cli 0 90 snapshot executable jar 0 90 snapshot at io airlift http client fulljsonresponsehandler handle fulljsonresponsehandler java 66 presto cli 0 90 snapshot executable jar 0 90 snapshot at io airlift http client fulljsonresponsehandler handle fulljsonresponsehandler java 35 presto cli 0 90 snapshot executable jar 0 90 snapshot at io airlift http client jetty jettyhttpclient execute jettyhttpclient java 233 presto cli 0 90 snapshot executable jar 0 90 snapshot at com facebook presto client statementclient advance statementclient java 217 presto cli 0 90 snapshot executable jar 0 90 snapshot 7 common frame omit cause by java lang illegalargumentexception invalid simple type class com facebook presto client queryresult json bytes at io airlift json jsoncodec fromjson jsoncodec java 174 presto cli 0 90 snapshot executable jar 0 90 snapshot at io airlift http client fulljsonresponsehandler jsonresponse fulljsonresponsehandler java 116 presto cli 0 90 snapshot executable jar 0 90 snapshot 11 common frame omit cause by com fasterxml jackson databind jsonmappingexception instantiation of simple type class com facebook presto client queryresult value fail unrecognized character at com fasterxml jackson databind deser std stdvalueinstantiator wrapexception stdvalueinstantiator java 405 presto cli 0 90 snapshot executable jar 0 90 snapshot at com fasterxml jackson databind deser std stdvalueinstantiator createfromobjectwith stdvalueinstantiator java 234 presto cli 0 90 snapshot executable jar 0 90 snapshot at com fasterxml jackson databind deser impl propertybasedcreator build propertybasedcreator java 167 presto cli 0 90 snapshot executable jar 0 90 snapshot at com fasterxml jackson databind deser beandeserializer deserializeusingpropertybase beandeserializer java 398 presto cli 0 90 snapshot executable jar 0 90 snapshot at com fasterxml jackson databind deser beandeserializerbase deserializefromobjectusingnondefault beandeserializerbase java 1064 presto cli 0 90 snapshot executable jar 0 90 snapshot at com fasterxml jackson databind deser beandeserializer deserializefromobject beandeserializer java 264 presto cli 0 90 snapshot executable jar 0 90 snapshot at com fasterxml jackson databind deser beandeserializer deserialize beandeserializer java 124 presto cli 0 90 snapshot executable jar 0 90 snapshot at com fasterxml jackson databind objectmapper readmapandclose objectmapper java 3066 presto cli 0 90 snapshot executable jar 0 90 snapshot at com fasterxml jackson databind objectmapper readvalue objectmapper java 2262 presto cli 0 90 snapshot executable jar 0 90 snapshot at io airlift json jsoncodec fromjson jsoncodec java 171 presto cli 0 90 snapshot executable jar 0 90 snapshot 12 common frame omit cause by com google common io baseencode decodingexception unrecognized character at com google common io baseencode alphabet decode baseencode java 503 presto cli 0 90 snapshot executable jar 0 90 snapshot at com google common io baseencode standardbaseencode 2 read baseencode java 675 presto cli 0 90 snapshot executable jar 0 90 snapshot at com google common io baseencode decodechecke baseencoding java 245 presto cli 0 90 snapshot executable jar 0 90 snapshot at com google common io baseencode decode baseencoding java 226 presto cli 0 90 snapshot executable jar 0 90 snapshot at com facebook presto client queryresult fixvalue queryresult java 256 presto cli 0 90 snapshot executable jar 0 90 snapshot at com facebook presto client queryresult fixdata queryresult java 184 presto cli 0 90 snapshot executable jar 0 90 snapshot at com facebook presto client queryresult queryresult java 79 presto cli 0 90 snapshot executable jar 0 90 snapshot at sun reflect nativeconstructoraccessorimpl newinstance0 native method na 1 8 0 25 at sun reflect nativeconstructoraccessorimpl newinstance nativeconstructoraccessorimpl java 62 na 1 8 0 25 at sun reflect delegatingconstructoraccessorimpl newinstance delegatingconstructoraccessorimpl java 45 na 1 8 0 25 at java lang reflect constructor newinstance constructor java 408 na 1 8 0 25 at com fasterxml jackson databind introspect annotatedconstructor call annotatedconstructor java 125 presto cli 0 90 snapshot executable jar 0 90 snapshot at com fasterxml jackson databind deser std stdvalueinstantiator createfromobjectwith stdvalueinstantiator java 230 presto cli 0 90 snapshot executable jar 0 90 snapshot 20 common frame omit query be go server restart
prestodbpresto
support implicit coercion in value
Enhancement
value 1 2 1 2 3 4 currently fail with query 20150108 110048 00012 j5xif fail value row have mismatch type expect bigint bigint actual double double com facebook presto sql analyzer semanticexception value row have mismatch type expect bigint bigint actual double double at com facebook presto sql analyzer tupleanalyzer visitvalue tupleanalyzer java 546 at com facebook presto sql analyzer tupleanalyzer visitvalue tupleanalyzer java 133 at com facebook presto sql tree value accept value java 43 at com facebook presto sql tree astvisitor process astvisitor java 22 at com facebook presto sql analyzer statementanalyzer visitquery statementanalyzer java 493 at com facebook presto sql analyzer statementanalyzer visitquery statementanalyzer java 114 at com facebook presto sql tree query accept query java 81 at com facebook presto sql tree astvisitor process astvisitor java 22 at com facebook presto sql analyzer analyzer analyze analyzer java 52 at com facebook presto execution sqlqueryexecution doanalyzequery sqlqueryexecution java 208 at com facebook presto execution sqlqueryexecution analyzequery sqlqueryexecution java 193 at com facebook presto execution sqlqueryexecution start sqlqueryexecution java 154 at com facebook presto execution sqlquerymanager querystarter querysubmitter 2 run sqlquerymanager java 470 at java util concurrent threadpoolexecutor runworker threadpoolexecutor java 1142 at java util concurrent threadpoolexecutor worker run threadpoolexecutor java 617 at java lang thread run thread java 745 the engine should insert any necessary cast follow the implicit coercion rule effectively resolve it as value cast 1 as double cast 2 as double 1 2 3 4
prestodbpresto
add year of week function
Enhancement
this function should accept a date return the year correspond to the iso week of that date
prestodbpresto
bad error message for great color
Enhancement
the problem be that e must be orderable maybe we should include the type constraint in the error message presto default select great rgb 255 0 0 query 20150105 152051 00033 59tg5 fail unexpected parameter color for function great expect great e
prestodbpresto
combine window operator with same partition and order
Enhancement
window function that share the same partition and ordering can be execute by the same window operator currently each window function be execute in a separate step which require move and sort all the datum again the same operator can be share even if the frame be different this require track the frame per function or group of function that use the same frame rather than use a single frame for the entire operator
prestodbpresto
fix wasnull in prestoresultset
Bug
the method currently always return false
prestodbpresto
bad error message for scalar subquery
Bug
presto select select 123 query 20141229 190248 09947 q9qf4 fail not yet implement com facebook presto sql tree subqueryexpression com facebook presto spi prestoexception not yet implement com facebook presto sql tree subqueryexpression at com facebook presto sql planner expressioninterpreter visitor visitexpression expressioninterpreter java 791 at com facebook presto sql tree astvisitor visitsubqueryexpression astvisitor java 327 at com facebook presto sql tree subqueryexpression accept subqueryexpression java 34 at com facebook presto sql tree astvisitor process astvisitor java 22 at com facebook presto sql planner expressioninterpreter optimize expressioninterpreter java 140 at com facebook presto sql planner optimizations simplifyexpression rewriter simplifyexpression simplifyexpression java 115 at com facebook presto sql planner optimization simplifyexpression rewriter lambda 112 1236990587 apply unknown source at com google common collect map 7 transformentry map java 1812 at com google common collect map 10 getvalue map java 1857 at com google common collect immutablemap copyof immutablemap java 292 at com facebook presto sql planner optimization simplifyexpression rewriter visitproject simplifyexpression java 86 at com facebook presto sql planner optimization simplifyexpression rewriter visitproject simplifyexpression java 66 at com facebook presto sql planner plan projectnode accept projectnode java 81 at com facebook presto sql planner plan planrewriter rewritecontext rewrite planrewriter java 101 at com facebook presto sql planner plan planrewriter rewritecontext rewrite planrewriter java 112 at com facebook presto sql planner optimization simplifyexpression rewriter visitproject simplifyexpression java 85 at com facebook presto sql planner optimization simplifyexpression rewriter visitproject simplifyexpression java 66 at com facebook presto sql planner plan projectnode accept projectnode java 81 at com facebook presto sql planner plan planrewriter rewritecontext rewrite planrewriter java 101 at com facebook presto sql planner plan planrewriter rewritecontext rewrite planrewriter java 112 at com facebook presto sql planner optimization simplifyexpression rewriter visitproject simplifyexpression java 85 at com facebook presto sql planner optimization simplifyexpression rewriter visitproject simplifyexpression java 66 at com facebook presto sql planner plan projectnode accept projectnode java 81 at com facebook presto sql planner plan planrewriter rewritecontext rewrite planrewriter java 101 at com facebook presto sql planner plan planrewriter rewritecontext rewrite planrewriter java 112 at com facebook presto sql planner optimization simplifyexpression rewriter visitproject simplifyexpression java 85 at com facebook presto sql planner optimization simplifyexpression rewriter visitproject simplifyexpression java 66 at com facebook presto sql planner plan projectnode accept projectnode java 81 at com facebook presto sql planner plan planrewriter rewritecontext rewrite planrewriter java 101 at com facebook presto sql planner plan planrewriter rewritecontext lambda defaultrewrite 15 planrewriter java 75 at com facebook presto sql planner plan planrewriter rewritecontext lambda 109 665800274 apply unknown source at java util stream referencepipeline 3 1 accept referencepipeline java 193 at java util iterator foreachremaine iterator java 116 at java util spliterators iteratorspliterator foreachremaine spliterator java 1801 at java util stream abstractpipeline copyinto abstractpipeline java 512 at java util stream abstractpipeline wrapandcopyinto abstractpipeline java 502 at java util stream reduceop reduceop evaluatesequential reduceop java 708 at java util stream abstractpipeline evaluate abstractpipeline java 234 at java util stream referencepipeline collect referencepipeline java 499 at com facebook presto sql planner plan planrewriter rewritecontext defaultrewrite planrewriter java 76 at com facebook presto sql planner plan planrewriter visitplan planrewriter java 40 at com facebook presto sql planner plan planrewriter visitplan planrewriter java 22 at com facebook presto sql planner plan planvisitor visitoutput planvisitor java 50 at com facebook presto sql planner plan outputnode accept outputnode java 79 at com facebook presto sql planner plan planrewriter rewritewith planrewriter java 29 at com facebook presto sql planner optimization simplifyexpression optimize simplifyexpression java 63 at com facebook presto sql planner logicalplanner plan logicalplanner java 88 at com facebook presto execution sqlqueryexecution doanalyzequery sqlqueryexecution java 210 at com facebook presto execution sqlqueryexecution analyzequery sqlqueryexecution java 191 at com facebook presto execution sqlqueryexecution start sqlqueryexecution java 152 at com facebook presto execution sqlquerymanager querystarter querysubmitter 2 run sqlquerymanager java 474 at java util concurrent threadpoolexecutor runworker threadpoolexecutor java 1142 at java util concurrent threadpoolexecutor worker run threadpoolexecutor java 617 at java lang thread run thread java 745
prestodbpresto
hive connector should verify type when create output handle
Bug
relate to 2128 begincreatetable should verify if the type be support rather than fail much later when actually write the method getjavaobjectinspector in hiverecordsink have a list of all the possibly support type but some output format may not support every type
prestodbpresto
npe when get element from empty literal array
Bug
sql select array 0 query 20141218 193145 15184 8t988 fail methodhandle be null java lang nullpointerexception methodhandle be null at com google common base precondition checknotnull precondition java 226 at com facebook presto operator scalar arraysubscriptoperator specialize arraysubscriptoperator java 99 at com facebook presto metadata functionregistry resolvefunction functionregistry java 346 at com facebook presto metadata functionregistry resolveoperator functionregistry java 459 at com facebook presto metadata metadatamanager resolveoperator metadatamanager java 177 at com facebook presto sql analyzer expressionanalyzer visitor getoperator expressionanalyzer java 769 at com facebook presto sql analyzer expressionanalyzer visitor visitsubscriptexpression expressionanalyzer java 467 at com facebook presto sql analyzer expressionanalyzer visitor visitsubscriptexpression expressionanalyzer java 180 at com facebook presto sql tree subscriptexpression accept subscriptexpression java 35 at com facebook presto sql analyzer expressionanalyzer analyze expressionanalyzer java 177 at com facebook presto sql analyzer expressionanalyzer analyzeexpression expressionanalyzer java 961 at com facebook presto sql analyzer tupleanalyzer analyzeexpression tupleanalyzer java 1067 at com facebook presto sql analyzer tupleanalyzer analyzeselect tupleanalyzer java 870 at com facebook presto sql analyzer tupleanalyzer visitqueryspecification tupleanalyzer java 349 at com facebook presto sql analyzer tupleanalyzer visitqueryspecification tupleanalyzer java 134 at com facebook presto sql tree queryspecification accept queryspecification java 99 at com facebook presto sql tree astvisitor process astvisitor java 22 at com facebook presto sql analyzer statementanalyzer visitquery statementanalyzer java 531 at com facebook presto sql analyzer statementanalyzer visitquery statementanalyzer java 104 at com facebook presto sql tree query accept query java 81 at com facebook presto sql tree astvisitor process astvisitor java 22 at com facebook presto sql analyzer analyzer analyze analyzer java 52 at com facebook presto execution sqlqueryexecution doanalyzequery sqlqueryexecution java 206 at com facebook presto execution sqlqueryexecution analyzequery sqlqueryexecution java 191 at com facebook presto execution sqlqueryexecution start sqlqueryexecution java 152 at com facebook presto execution sqlquerymanager querystarter querysubmitter 2 run sqlquerymanager java 474 at java util concurrent threadpoolexecutor runworker threadpoolexecutor java 1142 at java util concurrent threadpoolexecutor worker run threadpoolexecutor java 617 at java lang thread run thread java 745
prestodbpresto
cast to unknown should not be allow
Bug
unknown be not a valid type it s just a way of say there be a type but it s unknown to the sql engine therefore cast a value to unknown be non sensical and shouldn t be allow presto di select cast null as unknown col0 0 row
prestodbpresto
select null incorrectly produce 0 row
Bug
presto select null col0 0 row presto di explain select null query plan output col0 col0 expr project expr unknown expr cast cast null as unknown as unknown value
prestodbpresto
indexoutofboundsexception from io airlift tpch textpool
Bug
presto default select sum quantity from tpch sf101 lineitem query 20141215 222017 00006 39zd8 fail 1 node split 5 total 0 do 0 00 cpu time 7 9s total 1 67 m rows s 0b s 96 active per node 2 6 parallelism 4 32 m rows s 0b s parallelism 2 6 0 03 13 1 m rows 0b 4 32 m rows s 0b s query 20141215 222017 00006 39zd8 fail index 314572800 be beyond end of text pool size 314572800 java lang indexoutofboundsexception index 314572800 be beyond end of text pool size 314572800 at io airlift tpch textpool gettext textpool java 75 at io airlift tpch randomtext nextvalue randomtext java 43 at io airlift tpch lineitemgenerator lineitemgeneratoriterator makelineitem lineitemgenerator java 249 at io airlift tpch lineitemgenerator lineitemgeneratoriterator computenext lineitemgenerator java 171 at io airlift tpch lineitemgenerator lineitemgeneratoriterator computenext lineitemgenerator java 90 at com google common collect abstractiterator trytocomputenext abstractiterator java 143 at com google common collect abstractiterator hasnext abstractiterator java 138 at com facebook presto tpch tpchrecordset tpchrecordcursor advancenextposition tpchrecordset java 122 at com facebook presto spi recordpagesource getnextpage recordpagesource java 93 at com facebook presto operator tablescanoperator getoutput tablescanoperator java 230 at com facebook presto operator driver processinternal driver java 352 at com facebook presto operator driver processfor driver java 284 at com facebook presto execution sqltaskexecution driversplitrunner processfor sqltaskexecution java 558 at com facebook presto execution taskexecutor prioritizedsplitrunner process taskexecutor java 444 at com facebook presto execution taskexecutor runner run taskexecutor java 578 at java util concurrent threadpoolexecutor runworker threadpoolexecutor java 1142 at java util concurrent threadpoolexecutor worker run threadpoolexecutor java 617 at java lang thread run thread java 745
prestodbpresto
quote special function don t resolve correctly
Bug
this work presto di select current timestamp col0 2014 12 12 17 59 18 737 america los angeles 1 row but this do not presto di select current timestamp query 20141213 015319 01754 8t988 fail column current timestamp can not be resolve the same apply to current date and current time
prestodbpresto
add create table if not exist
Enhancement
add the optional if not exist syntax for create table create table if not exist name as
prestodbpresto
row number with limit filter incorrect when filter contain not
Bug
the follow query sql select from select row number over rn from value 0 0 0 0 where not rn 3 produce the follow incorrect output rn 0 row the correct output should be rn 3 4 2 row
prestodbpresto
can not create view if query contain quote table name
Bug
presto create view test as select x from 7day query 20141206 005354 01299 aqkqc fail format query do not parse query querybody queryspecification select select distinct false selectitem x from optional of table 7day where null groupby have null orderby limit null orderby
prestodbpresto
implement great as a variable arity function
Enhancement
the current implementation be specific to a few type and only support two argument it should be replace with something like
prestodbpresto
split page if necessary before send they over the network
Bug
page provide by plugin datum source can be arbitrarily sized relative to the maximum http payload size default 16 mb this can cause query failure with com facebook presto operator pagetoolargeexception remote page be too large at com facebook presto operator httppagebufferclient rewriteexception httppagebufferclient java 396 at com facebook presto operator httppagebufferclient access 1000 httppagebufferclient java 71 at com facebook presto operator httppagebufferclient 2 onfailure httppagebufferclient java 321 at com google common util concurrent future 6 run future java 1310 at java util concurrent executors runnableadapter call executor java 511 at java util concurrent futuretask run futuretask java 266 at java util concurrent scheduledthreadpoolexecutor scheduledfuturetask access 201 scheduledthreadpoolexecutor java 180 at java util concurrent scheduledthreadpoolexecutor scheduledfuturetask run scheduledthreadpoolexecutor java 293 at java util concurrent threadpoolexecutor runworker threadpoolexecutor java 1142 at java util concurrent threadpoolexecutor worker run threadpoolexecutor java 617 at java lang thread run thread java 745 we should probably split the page if necessary before send they over http an example of this happen be with the hive orc reader in which it turn each datum segment into a page without regard to total page size maximum
prestodbpresto
distinct fail for json type when optimizehashgeneration true
Bug
sql select distinct cast array 1 as json fail with com facebook presto spi prestoexception unexpected parameter json for function operator hash code expect operator hash code boolean operator hash code bigint operator hash code double operator hash code varchar operator hash code varbinary operator hash code date operator hash code time operator hash code timestamp operator hash code interval day to second operator hash code interval year to month operator hash code time with time zone operator hash code timestamp with time zone at com facebook presto metadata functionregistry resolvefunction functionregistry java 428 at com facebook presto metadata metadatamanager resolvefunction metadatamanager java 147 at com facebook presto sql analyzer expressionanalyzer visitor visitfunctioncall expressionanalyzer java 601 at com facebook presto sql analyzer expressionanalyzer visitor visitfunctioncall expressionanalyzer java 180 at com facebook presto sql tree functioncall accept functioncall java 67 at com facebook presto sql tree astvisitor process astvisitor java 24 at com facebook presto sql analyzer expressionanalyzer visitor process expressionanalyzer java 198 at com facebook presto sql analyzer expressionanalyzer visitor visitfunctioncall expressionanalyzer java 598 at com facebook presto sql analyzer expressionanalyzer visitor visitfunctioncall expressionanalyzer java 180 at com facebook presto sql tree functioncall accept functioncall java 67 at com facebook presto sql analyzer expressionanalyzer analyze expressionanalyzer java 177 at com facebook presto sql analyzer expressionanalyzer analyzeexpression expressionanalyzer java 928 at com facebook presto sql analyzer expressionanalyzer analyzeexpressionswithinput expressionanalyzer java 916 at com facebook presto sql analyzer expressionanalyzer getexpressiontypesfrominput expressionanalyzer java 877 at com facebook presto sql analyzer expressionanalyzer getexpressiontypesfrominput expressionanalyzer java 867 at com facebook presto sql planner interpretedprojectionfunction interpretedprojectionfunction java 57 at com facebook presto sql planner localexecutionplanner visitor visitscanfilterandproject localexecutionplanner java 852 at com facebook presto sql planner localexecutionplanner visitor visitproject localexecutionplanner java 723 at com facebook presto sql planner localexecutionplanner visitor visitproject localexecutionplanner java 344 at com facebook presto sql planner plan projectnode accept projectnode java 81 at com facebook presto sql planner localexecutionplanner visitor visitaggregation localexecutionplanner java 648 at com facebook presto sql planner localexecutionplanner visitor visitaggregation localexecutionplanner java 344 at com facebook presto sql planner plan aggregationnode accept aggregationnode java 165 at com facebook presto sql planner localexecutionplanner visitor visitoutput localexecutionplanner java 367 at com facebook presto sql planner localexecutionplanner visitor visitoutput localexecutionplanner java 344 at com facebook presto sql planner plan outputnode accept outputnode java 79 at com facebook presto sql planner localexecutionplanner plan localexecutionplanner java 226 at com facebook presto execution sqltaskexecution sqltaskexecution java 147 at com facebook presto execution sqltaskexecution createsqltaskexecution sqltaskexecution java 109 at com facebook presto execution sqltaskexecutionfactory create sqltaskexecutionfactory java 101 at com facebook presto execution sqltask updatetask sqltask java 219 at com facebook presto execution sqltaskmanager updatetask sqltaskmanager java 223 at com facebook presto server taskresource createorupdatetask taskresource java 104 at sun reflect generatedmethodaccessor142 invoke unknown source at sun reflect delegatingmethodaccessorimpl invoke delegatingmethodaccessorimpl java 43 at java lang reflect method invoke method java 497 at org glassfish jersey server model internal resourcemethodinvocationhandlerfactory 1 invoke resourcemethodinvocationhandlerfactory java 81 at org glassfish jersey server model internal abstractjavaresourcemethoddispatcher 1 run abstractjavaresourcemethoddispatcher java 151 at org glassfish jersey server model internal abstractjavaresourcemethoddispatcher invoke abstractjavaresourcemethoddispatcher java 171 at org glassfish jersey server model internal javaresourcemethoddispatcherprovider responseoutinvoker dodispatch javaresourcemethoddispatcherprovider java 152 at org glassfish jersey server model internal abstractjavaresourcemethoddispatcher dispatch abstractjavaresourcemethoddispatcher java 104 at org glassfish jersey server model resourcemethodinvoker invoke resourcemethodinvoker java 387 at org glassfish jersey server model resourcemethodinvoker apply resourcemethodinvoker java 331 at org glassfish jersey server model resourcemethodinvoker apply resourcemethodinvoker java 103 at org glassfish jersey server serverruntime 1 run serverruntime java 271 at org glassfish jersey internal error 1 call error java 271 at org glassfish jersey internal error 1 call error java 267 at org glassfish jersey internal error process error java 315 at org glassfish jersey internal error process error java 297 at org glassfish jersey internal error process error java 267 at org glassfish jersey process internal requestscope runinscope requestscope java 297 at org glassfish jersey server serverruntime process serverruntime java 254 at org glassfish jersey server applicationhandler handle applicationhandler java 1030 at org glassfish jersey servlet webcomponent service webcomponent java 373 at org glassfish jersey servlet servletcontainer service servletcontainer java 381 at org glassfish jersey servlet servletcontainer service servletcontainer java 344 at org glassfish jersey servlet servletcontainer service servletcontainer java 221 at org eclipse jetty servlet servletholder handle servletholder java 769 at org eclipse jetty servlet servlethandler cachedchain dofilter servlethandler java 1667 at org eclipse jetty servlets useragentfilter dofilter useragentfilter java 83 at org eclipse jetty servlets gzipfilter dofilter gzipfilter java 300 at org eclipse jetty servlet servlethandler cachedchain dofilter servlethandler java 1650 at io airlift http server tracetokenfilter dofilter tracetokenfilter java 62 at org eclipse jetty servlet servlethandler cachedchain dofilter servlethandler java 1650 at io airlift http server timingfilter dofilter timingfilter java 51 at org eclipse jetty servlet servlethandler cachedchain dofilter servlethandler java 1650 at org eclipse jetty servlet servlethandler dohandle servlethandler java 583 at org eclipse jetty server handler contexthandler dohandle contexthandler java 1125 at org eclipse jetty servlet servlethandler doscope servlethandler java 515 at org eclipse jetty server handler contexthandler doscope contexthandler java 1059 at org eclipse jetty server handler scopedhandler handle scopedhandler java 141 at org eclipse jetty server handler handlercollection handle handlercollection java 110 at org eclipse jetty server handler handlerwrapper handle handlerwrapper java 97 at org eclipse jetty server handler statisticshandler handle statisticshandler java 159 at org eclipse jetty server handler handlerlist handle handlerlist java 52 at org eclipse jetty server handler handlerwrapper handle handlerwrapper java 97 at org eclipse jetty server server handle server java 485 at org eclipse jetty server httpchannel handle httpchannel java 290 at org eclipse jetty server httpconnection onfillable httpconnection java 248 at org eclipse jetty io abstractconnection 2 run abstractconnection java 540 at org eclipse jetty util thread queuedthreadpool runjob queuedthreadpool java 606 at org eclipse jetty util thread queuedthreadpool 3 run queuedthreadpool java 535 at java lang thread run thread java 745
prestodbpresto
npe when use max by min by
Bug
java lang nullpointerexception at com facebook presto spi type doubletype compareto doubletype java 72 at com facebook presto operator aggregation maxby combine maxby java 125 at com facebook presto gen varcharvarchardoublemaxbygroupedaccumulator 576 addintermediate unknown source at com facebook presto operator hashaggregationoperator aggregator processpage hashaggregationoperator java 388 at com facebook presto operator hashaggregationoperator groupbyhashaggregationbuilder processpage hashaggregationoperator java 296 at com facebook presto operator hashaggregationoperator groupbyhashaggregationbuilder access 200 hashaggregationoperator java 263 at com facebook presto operator hashaggregationoperator addinput hashaggregationoperator java 212 at com facebook presto operator driver processinternal driver java 357 at com facebook presto operator driver processfor driver java 283 at com facebook presto execution sqltaskexecution driversplitrunner processfor sqltaskexecution java 557 at com facebook presto execution taskexecutor prioritizedsplitrunner process taskexecutor java 444 at com facebook presto execution taskexecutor runner run taskexecutor java 578 at java util concurrent threadpoolexecutor runworker threadpoolexecutor java 1142 at java util concurrent threadpoolexecutor worker run threadpoolexecutor java 617 at java lang thread run thread java 745
prestodbpresto
exception when use non deterministic predicate together with in
Bug
the follow query sql select from value 1 t a where rand 0 and a in value 1 fail with this exception java lang illegalargumentexception only deterministic expression may be consider for rewrite at com google common base precondition checkargument precondition java 122 at com facebook presto sql planner equalityinference rewriteexpression equalityinference java 101 at com facebook presto sql planner optimization predicatepushdown rewriter rewritesemijoin predicatepushdown java 677 at com facebook presto sql planner optimization predicatepushdown rewriter rewritesemijoin predicatepushdown java 134 at com facebook presto sql planner plan planrewriter rewritingvisitor visitsemijoin planrewriter java 449 at com facebook presto sql planner plan planrewriter rewritingvisitor visitsemijoin planrewriter java 65 at com facebook presto sql planner plan semijoinnode accept semijoinnode java 120 at com facebook presto sql planner plan planrewriter rewrite planrewriter java 42 at com facebook presto sql planner optimization predicatepushdown rewriter rewritefilter predicatepushdown java 219 at com facebook presto sql planner optimization predicatepushdown rewriter rewritefilter predicatepushdown java 134 at com facebook presto sql planner plan planrewriter rewritingvisitor visitfilter planrewriter java 200 at com facebook presto sql planner plan planrewriter rewritingvisitor visitfilter planrewriter java 65 at com facebook presto sql planner plan filternode accept filternode java 71 at com facebook presto sql planner plan planrewriter rewrite planrewriter java 42 at com facebook presto sql planner plan planrewriter rewritingvisitor visitproject planrewriter java 244 at com facebook presto sql planner plan planrewriter rewritingvisitor visitproject planrewriter java 65 at com facebook presto sql planner plan projectnode accept projectnode java 81 at com facebook presto sql planner plan planrewriter defaultrewrite planrewriter java 50 at com facebook presto sql planner optimization predicatepushdown rewriter rewriteproject predicatepushdown java 178 at com facebook presto sql planner optimization predicatepushdown rewriter rewriteproject predicatepushdown java 134 at com facebook presto sql planner plan planrewriter rewritingvisitor visitproject planrewriter java 238 at com facebook presto sql planner plan planrewriter rewritingvisitor visitproject planrewriter java 65 at com facebook presto sql planner plan projectnode accept projectnode java 81 at com facebook presto sql planner plan planrewriter rewrite planrewriter java 42 at com facebook presto sql planner plan planrewriter rewritingvisitor visitoutput planrewriter java 282 at com facebook presto sql planner plan planrewriter rewritingvisitor visitoutput planrewriter java 65 at com facebook presto sql planner plan outputnode accept outputnode java 79 at com facebook presto sql planner plan planrewriter defaultrewrite planrewriter java 50 at com facebook presto sql planner optimization predicatepushdown rewriter rewritenode predicatepushdown java 166 at com facebook presto sql planner optimization predicatepushdown rewriter rewritenode predicatepushdown java 134 at com facebook presto sql planner plan plannoderewriter rewriteoutput plannoderewriter java 120 at com facebook presto sql planner plan planrewriter rewritingvisitor visitoutput planrewriter java 276 at com facebook presto sql planner plan planrewriter rewritingvisitor visitoutput planrewriter java 65 at com facebook presto sql planner plan outputnode accept outputnode java 79 at com facebook presto sql planner plan planrewriter rewrite planrewriter java 42 at com facebook presto sql planner plan planrewriter rewritewith planrewriter java 31 at com facebook presto sql planner optimization predicatepushdown optimize predicatepushdown java 131 at com facebook presto sql planner logicalplanner plan logicalplanner java 88 at com facebook presto sql analyzer queryexplainer getlogicalplan queryexplainer java 104 at com facebook presto sql analyzer queryexplainer getplan queryexplainer java 66 at com facebook presto sql analyzer statementanalyzer getqueryplan statementanalyzer java 510 at com facebook presto sql analyzer statementanalyzer visitexplain statementanalyzer java 479 at com facebook presto sql analyzer statementanalyzer visitexplain statementanalyzer java 106 at com facebook presto sql tree explain accept explain java 54 at com facebook presto sql tree astvisitor process astvisitor java 24 at com facebook presto sql analyzer analyzer analyze analyzer java 52 at com facebook presto execution sqlqueryexecution doanalyzequery sqlqueryexecution java 206 at com facebook presto execution sqlqueryexecution analyzequery sqlqueryexecution java 191 at com facebook presto execution sqlqueryexecution start sqlqueryexecution java 152 at com facebook presto execution sqlquerymanager querystarter querysubmitter 2 run sqlquerymanager java 490 at java util concurrent threadpoolexecutor runworker threadpoolexecutor java 1142 at java util concurrent threadpoolexecutor worker run threadpoolexecutor java 617 at java lang thread run thread java 745
prestodbpresto
invalid plan when aggregation require implicit coercion
Bug
the follow query sql select min a numeric histogram 10 a from value 1 t a produce this invalid plan output col0 col1 col0 min col1 numeric histogram aggregate min bigint numeric histogram map min min field numeric histogram numeric histogram expr cast field as double project field bigint expr bigint expr 10 value field bigint the cast should be perform by the projection below the aggregation aggregation expect input to be simple qualifiednamereference
prestodbpresto
implement pick any aggregation function
Enhancement
we need an aggregation function to pick an arbitrary value from the group this can be commonly do with min or max but those only work for comparable type possible name be arbitrary choose any
prestodbpresto
implement map agg function
Enhancement
the map agg k v map function should be an aggregation that accept a comparable key k and any value v and aggregate all the row into a single map
prestodbpresto
json type can not be write to hive connector
Enhancement
the json type should be write to the hive connector as a string with some additional datum store in the metastore so that the hive connector still know that it s a presto json type
prestodbpresto
improve error message when type don t match in union query
Enhancement
the follow query sql select 1 union select a fail with a cryptic error com facebook presto sql analyzer semanticexception union query term have mismatch column at com facebook presto sql analyzer tupleanalyzer visitunion tupleanalyzer java 373 at com facebook presto sql analyzer tupleanalyzer visitunion tupleanalyzer java 124 at com facebook presto sql tree union accept union java 51 at com facebook presto sql tree astvisitor process astvisitor java 24 at com facebook presto sql analyzer statementanalyzer visitquery statementanalyzer java 533 at com facebook presto sql analyzer statementanalyzer visitquery statementanalyzer java 106 at com facebook presto sql tree query accept query java 81 at com facebook presto sql tree astvisitor process astvisitor java 24 at com facebook presto sql analyzer analyzer analyze analyzer java 52 at com facebook presto execution sqlqueryexecution doanalyzequery sqlqueryexecution java 206 at com facebook presto execution sqlqueryexecution analyzequery sqlqueryexecution java 191 at com facebook presto execution sqlqueryexecution start sqlqueryexecution java 152 at com facebook presto execution sqlquerymanager querystarter querysubmitter 2 run sqlquerymanager java 490 at java util concurrent threadpoolexecutor runworker threadpoolexecutor java 1142 at java util concurrent threadpoolexecutor worker run threadpoolexecutor java 617 at java lang thread run thread java 745 we should improve the error message to say something like column x in union query have incompatible type varchar bigint or similar
prestodbpresto
make map comparable
Enhancement
map should be consider equal if they contain the same number of key and they be element wise equal ignore key ordering
prestodbpresto
execute use command on the server
Enhancement
the command should be send to the server which should parse validate and return the resolve catalog schema to the client in the same way as session option currently work in progress