mamiksik/analysed-diff-metadata · Datasets at Hugging Face

sha stringlengths 40 40	author stringlengths 1 63	committer stringlengths 1 41	message stringlengths 1 65.5k	subject stringlengths 1 5.64k	subject_length float64 1 5.64k	is_chore bool 2 classes	is_bot bool 2 classes	subject_word_count float64 1 806	verb_object_spacy bool 2 classes	verb_object_stanza bool 2 classes	fits_requirements bool 2 classes	owner stringlengths 2 15	repo stringlengths 2 21	__index_level_0__ int64 0 85k
91b0ebb9f2e0e79d20bef369a4c9450d985aa18c	Robert Jackson	Robert Jackson	Merge pull request #12752 from rwjblue/rebase-12549 Do not re-raise on errors handled in route error action.	merge pull request from rwjblue/rebase-12549	45	true	false	5	true	true	false	emberjs	ember.js	10,500
8cdd2f3f92092eff8be0f2c4dbde2f22b760c2da	Robert Jackson	Robert Jackson	Remove npm-shrinkwrap.json. A simple: ``` npm install --save-dev htmlbars@some-version npm shrinkwrap -dev ``` Results in a bunch of errors, resulting in us manually updating the shrinkwrap file (aka by hand) which is likely even more error prone. The ergonomics here seem to be pretty bad. Would love to be shown what I am doing wrong if that is the case...	remove npm-shrinkwrap.json	26	false	false	2	true	true	false	emberjs	ember.js	10,501
a8dc7ca7517b4715445386d10e8b5e86180bdedd	Robert Jackson	Robert Jackson	[BUGFIX release] Avoid computed for tracking errors in Router.	[bugfix release] avoid computed for tracking errors in router	61	false	false	9	false	false	false	emberjs	ember.js	10,502
ff4d431494f55b319a7085cf1feebaa1e6a44b5e	Robert Jackson	Robert Jackson	Add more route error action scenario tests.	add more route error action scenario tests	42	false	false	7	false	true	false	emberjs	ember.js	10,503
200c3b7b5846e22cb230842fc6fe475531f9eaa3	Mina Smart	Robert Jackson	Add tests with multiple re-throw stratiegies. This provides insurance that handled errors aren't swallowed	add tests with multiple re-throw stratiegies	44	false	false	6	true	true	true	emberjs	ember.js	10,504
ef7108a8d1a97fc263918a0fd37db72889419b4c	Mina Smart	Robert Jackson	[BUGFIX release] Mark handled errors and don't reraise Ember 2.1 introduced a regression where all errors during a transition were thrown, even when those errors had been handled in a route's error action. This PR adds a test to identify the regression, and adds some logic and state to identify errors that have been handled, and not reraise them, while maintaining the desired behaviour of throwing errors that aren't handled. This is especially valuable in any application that tests error handling. Since all errors were being thrown regardless of handling, failed assertions were being registered by qunit, and it became impossible to test application flow that entered the error hook. Further details about this issue are here: https://github.com/emberjs/ember.js/issues/12547 Remove leftover debugger This addresses an issue where handled errors are still thrown The added test passes on Ember 2.0. It fails on Ember 2.1 because even though the error is not bubbled, the application throws the handled error. This is contrary to what the documentation indicates. Full details about this issue are here: https://github.com/emberjs/ember.js/issues/12547 This PR also adds a very naive implementation of how to flag an error as having been handled and prevents reraising, while retaining the functionality of throwing errors that aren't caught, or are bubbled from the application route Make error checking methods a part of the router instance Attach error caching methods to EmberRouter, and use guids for errors Errors used as keys were just getting `.toString()`ed, so multiple `Error`s or hashes would all have the same key. This update uses ember `guidFor` to uniquely identify errors. Thanks for the help @rwjblue! When creating a new promise, resolve it. Don't fork the promise Tests expecting errors to bubble up, should bubble errors	[bugfix release] mark handled errors and don't reraise	54	false	false	8	false	false	false	emberjs	ember.js	10,505
2d622f1206b4f03a2c7d58203e93b421b0c1d01d	Robert Jackson	Robert Jackson	Merge pull request #12749 from rwjblue/router-cleanup Cleanup router & DSL processing.	merge pull request from rwjblue/router-cleanup	47	true	false	5	true	false	false	emberjs	ember.js	10,506
dac7917cefad7042cc138fdb5ac07454174df2c6	Robert Jackson	Robert Jackson	Cleanup router & DSL processing. * Remove manual threading of `moduleBasedResolver`. As of the most recent resolver changes we can directly ask the "real" resolver when we need to. This avoids poluting a bunch of places with `moduleBasedResolver` that do not care about that flag. * Prevent creating additional closure just to create application route. * Avoid manually recreating input options for each layer of DSL (just pass options down). * Make DSL creation a separate function.	cleanup router & dsl processing	31	false	false	5	false	false	false	emberjs	ember.js	10,507
f367e7a508a6188485aa65a54d5d979e56798a67	Robert Jackson	Robert Jackson	Merge pull request #12746 from Serabe/fix/12717 [BUGFIX beta] Update htmlbar to 0.14.11	merge pull request from serabe/fix/12717	41	true	false	5	true	true	false	emberjs	ember.js	10,508
697e9e5b33dbed25e1d2f1bdb6d88783c490cf99	Sergio Arbeo	Sergio Arbeo	[BUGFIX beta] Update htmlbar to 0.14.11 This fixes a bug where a component's cell was being leaked as the first positional parameter. Fixes #12717	[bugfix beta] update htmlbar to 0.14.11	39	false	false	6	false	false	false	emberjs	ember.js	10,509
c3a8dcd4cee1015d00c9ac02395b9d7ab00f76fa	Robert Jackson	Robert Jackson	Merge pull request #12712 from Serabe/fix/positional-params-on-rerender [BUGFIX beta] Create a new hash parameter when creating a component cell	merge pull request from serabe/fix/positional-params-on-rerender	65	true	false	5	true	false	false	emberjs	ember.js	10,510
bdcf5bce9f94ed2805d43c6cd9ffe99f0d121dd8	Jake Worth	Jake Worth	[DOC release] Clean up documentation - This removes a few typos and attempts to make the overall passage more clear	[doc release] clean up documentation	36	false	false	5	false	false	false	emberjs	ember.js	10,511
2f38e75a5f000dc74a18f77afb84a91bbfe600f5	Jake Worth	Jake Worth	[DOC release] Fix typo	[doc release] fix typo	22	false	false	4	false	false	false	emberjs	ember.js	10,512
4e7fe484a09e7f4830cb0d95c7195c037f556956	Sergio Arbeo	Sergio Arbeo	[BUGFIX beta] Create a new hash parameter when creating a component cell If we merge positional and hash parameters without duplicating the hash before, then we get an error when rerendering. Fixes test in #12711	[bugfix beta] create a new hash parameter when creating a component cell	72	false	false	12	false	false	false	emberjs	ember.js	10,513
bbb81bb5bc2d0fdc27eec536c7ea04049355d90c	Yuvaraja Balamurugan	Yuvaraja Balamurugan	Change param to parameter	change param to parameter	25	false	false	4	true	true	true	emberjs	ember.js	10,514
01b1107920498cf2989340c810e45e3806ab134e	Robert Jackson	Robert Jackson	Merge pull request #12731 from rwjblue/fix-setting-container-on-create [BUGFIX beta] Ensure `container` can still be provided to `.create`.	merge pull request from rwjblue/fix-setting-container-on-create	64	true	false	5	true	false	false	emberjs	ember.js	10,515
5db59d87a93e42e273464443e3671faeda33dbea	Chris Santero	Robert Jackson	[BUGFIX beta] restore Ember.computed.collect (cherry picked from commit 3c47522ea1ce7b922f414272347ccf8437aad5b7)	[bugfix beta] restore ember.computed.collect	44	false	false	4	false	false	false	emberjs	ember.js	10,516
eeb8a9ba3857ad0b456611df86e39922bce3134e	Trek Glowacki	Trek Glowacki	Removes reference to Ember.ORDER_DEFINITION. That ain't no thang.	removes reference to ember.order_definition. that ain't no thang	64	false	false	8	false	false	false	emberjs	ember.js	10,517
258fc30e77813c185c3b15c5a9ea719feb47b332	Robert Jackson	Robert Jackson	[BUGFIX beta] Ensure `container` can still be provided to `.create`. In Ember versions until 2.3.0 it was common to provide a `container` property (if needed) when creating instances of a factory manually. This might look like: ``` let Foo = container.lookupFactory('model:foo'); let instance = Foo.create({ container }); ``` Many addons did this (examples include ember-cp-validations and ember-data). Our initial implementation of the deprecated `container` property on extendable factories used `Object.defineProperty` to ensure calling `instance.container` returned the correct value. Unfortunately, we only defined a getter which means calling `Foo.create({ container });` triggers the following error: ``` Cannot set property container of [object Object] which has only a getter ``` This change adds a setter (with an appropriate deprecation) to prevent triggering an error.	[bugfix beta] ensure `container` can still be provided to `.create`	67	false	false	10	false	false	false	emberjs	ember.js	10,518
38630ef1ac873fee983c05a85524fc66c6e064fc	Robert Jackson	Robert Jackson	Merge pull request #12694 from jwworth/pull-request-1449623534 [DOC release] Fix typos	merge pull request from jwworth/pull-request-1449623534	56	true	false	5	true	true	false	emberjs	ember.js	10,519
c3deac3d0627a30b89519236df57995ebd3a6135	Robert Jackson	Robert Jackson	Merge pull request #12710 from raido/master [DOC release] Update link-to classNameBindings and Router.map examples.	merge pull request from raido/master	37	true	false	5	true	false	false	emberjs	ember.js	10,520
dfbdbea00bb94f3c1620bd09145540a8bbb8e224	Robert Jackson	Robert Jackson	Merge pull request #12726 from trek/correct-docs-about-is-equal-and-collections [DOC release] Correct API docs about isEqual and collections	merge pull request from trek/correct-docs-about-is-equal-and-collections	73	true	false	5	true	false	false	emberjs	ember.js	10,521
868bc8d697a3dbb93c4cb0a250e55b426fa96c97	Trek Glowacki	Trek Glowacki	[DOC release] Correct API docs about isEqual and collections	[doc release] correct api docs about isequal and collections	60	false	false	9	false	false	false	emberjs	ember.js	10,522
2a269addc9b27d642a6ba16c5c4b83f5fcc7c65f	Robert Jackson	Robert Jackson	Merge pull request #12725 from trek/documentation-fixup-on-lib-utils [DOC RELEASE] Update isArray to use more common 'Array-like' description	merge pull request from trek/documentation-fixup-on-lib-utils	62	true	false	5	true	false	false	emberjs	ember.js	10,523
997b5c9945335a7b031608c41f15690ec38ba349	Trek Glowacki	Trek Glowacki	[DOC RELEASE] Update isArray to use more common 'Array like' description	[doc release] update isarray to use more common 'array like' description	72	false	false	11	false	false	false	emberjs	ember.js	10,524
706a4d5755db30ab5e1dfb4cf8927bb82216b9b9	Yuvaraja Balamurugan	Yuvaraja Balamurugan	[DOC release] Document on index block param for each helper	[doc release] document on index block param for each helper	59	false	false	10	false	false	false	emberjs	ember.js	10,525
fbab176eb41727dc6a4718ee3dfdc6490706b3b2	Stefan Penner	Stefan Penner	Merge pull request #12714 from chadhietala/dsl-shaping DSL shaping	merge pull request from chadhietala/dsl-shaping	48	true	false	5	true	false	false	emberjs	ember.js	10,526
319e0ed01ea812b86597eb64e033478b59eeb7fc	Chad Hietala	Chad Hietala	DSL shaping	dsl shaping	11	false	false	2	false	false	false	emberjs	ember.js	10,527
07ea1892c3eea8e341b792d48412708d46c5bda3	Marten Schilstra	Marten Schilstra	[WIP][BUGFIX Beta] Positional param clash on rerender of contextual component helper	[wip][bugfix beta] positional param clash on rerender of contextual component helper	84	false	false	11	false	false	false	emberjs	ember.js	10,528
38e6902cd3103945d1a0791e1801d9f663172096	Raido Kuli	Raido Kuli	[DOC release] Update link-to classNameBindings and Router.map examples.	[doc release] update link-to classnamebindings and router.map examples	70	false	false	8	false	false	false	emberjs	ember.js	10,529
302247a0c6212adc5acfbfcf541f36f230b4c8ed	Robert Jackson	Robert Jackson	Merge pull request #12706 from Serabe/feature/upgrade-htmlbars-contextual-components [BUGFIX beta] Update HTMLBars	merge pull request from serabe/feature/upgrade-htmlbars-contextual-components	78	true	false	5	true	true	false	emberjs	ember.js	10,530
55e3723a7ba122ec564b63e00440f017f4f49731	Sergio Arbeo	Sergio Arbeo	[BUGFIX beta] Update HTMLBars Add support for Glimmer components whose name has a dot.	[bugfix beta] update htmlbars	29	false	false	4	false	false	false	emberjs	ember.js	10,531
039167cea22129ab2fbbeadaa7a686dd4dd7a47f	Robert Jackson	Robert Jackson	Merge pull request #12705 from emberjs/fix-fastboot-crash [BUGFIX beta] Fix FastBoot URL parsing crash	merge pull request from emberjs/fix-fastboot-crash	51	true	false	5	true	false	false	emberjs	ember.js	10,532
97ec5ef8bd8f33c318c2e50c527eee49c4d03020	Tom Dale	Tom Dale	[BUGFIX beta] Fix FastBoot URL parsing crash	[bugfix beta] fix fastboot url parsing crash	44	false	false	7	false	false	false	emberjs	ember.js	10,533
0cb5442d08db80667539963877c91f4d9eec844d	Robert Jackson	Robert Jackson	Merge pull request #12701 from rwjblue/update-emberjs-build [BUGFIX beta] Update emberjs-build to prevent IIFE negation.	merge pull request from rwjblue/update-emberjs-build	53	true	false	5	true	false	false	emberjs	ember.js	10,534
8f36fa2509de01de4d080e62c2bd98a425bef30c	Robert Jackson	Robert Jackson	[BUGFIX beta] Update emberjs-build to prevent IIFE negation. See https://github.com/emberjs/emberjs-build/pull/135 for details.	[bugfix beta] update emberjs-build to prevent iife negation	59	false	false	8	false	false	false	emberjs	ember.js	10,535
31eadb4d25fc700fc116c4debeaa177154e1338b	Robert Jackson	Robert Jackson	Merge pull request #12699 from rwjblue/do-not-change-frozen-things [BUGFIX beta] Only add deprecated container after create when present.	merge pull request from rwjblue/do-not-change-frozen-things	60	true	false	5	true	false	false	emberjs	ember.js	10,536
b6e783d6fb4310d020feacb12052cbcac35ec7f8	Robert Jackson	Robert Jackson	[BUGFIX beta] Only add deprecated container after create when present. When the object returned from calling `.create` on a non-extendable factory does not contain a `container` property, do not set it. Previously, in Ember 2.2.0 it was possible to use non-extendable factories that were frozen after creation. After the changes to add a mock container to `.create` and swap that with the deprecated property after `.create` was finished, we trigger errors for anything that is frozen or sealed.	[bugfix beta] only add deprecated container after create when present	69	false	false	10	false	false	false	emberjs	ember.js	10,537
b3ce376faf57a11de253069338c800199fcfdf76	Robert Jackson	Robert Jackson	Merge pull request #12698 from davidpett/convert-super-apply-to-es6 convert all this._super.apply(this, arguments) to this._super(...arguments)	merge pull request from davidpett/convert-super-apply-to-es6	61	true	false	5	true	false	false	emberjs	ember.js	10,538
7847e8fa85c90f3c63ba2b02cdd97a0cfb488e03	David Pett	David Pett	convert all this._super.apply(this, arguments) to this._super(...arguments)	convert all this._super.apply(this, arguments) to this._super(...arguments)	75	false	false	6	false	true	false	emberjs	ember.js	10,539
cb980bc8e46bfc99aee2b6faa06f5f03e4855a2d	Robert Jackson	Robert Jackson	Merge pull request #12693 from thomascchen/doc-remove-function-whitespace [DOC release] Remove whitespace from function declaration	merge pull request from thomascchen/doc-remove-function-whitespace	67	true	false	5	true	false	false	emberjs	ember.js	10,540
8d62be51ce9602ce6f3aa05682a2847af8b5dc7a	Jake Worth	Jake Worth	[DOC release] Fix typos	[doc release] fix typos	23	false	false	4	false	false	false	emberjs	ember.js	10,541
cc325dd5cf8c496cfe3f5fb49b41beb3207f0d2d	Thomas Chen	Thomas Chen	[DOC release] Remove whitespace from function declaration	[doc release] remove whitespace from function declaration	57	false	false	7	false	false	false	emberjs	ember.js	10,542
8fbcf6ddc0d20f0b3ca406ed8c0ad4018f3fa1b1	Robert Jackson	Robert Jackson	Merge pull request #12677 from emberjs/remove-fastboot-monkeypatch [BUGFIX beta] Remove FastBoot monkeypatch	merge pull request from emberjs/remove-fastboot-monkeypatch	60	true	false	5	true	false	false	emberjs	ember.js	10,543
a9145411a1199c77a087cda3f0dee0f54ec943c0	Tom Dale	Tom Dale	[BUGFIX beta] Remove DOM Helper monkeypatches The DOM helper used to require a specially patched version of `protocolForURL` and `setMorphHTML` to work in Node. This commit: 1) Adds a test to verify attributes are correctly sanitized in Node 2) Removes the monkeypatches	[bugfix beta] remove dom helper monkeypatches	45	false	false	6	false	false	false	emberjs	ember.js	10,544
3771c93d83f223f33c1f8cc99d4b1da242e55719	Robert Jackson	Robert Jackson	Merge pull request #12674 from bekzod/remove-unused-prop removed unused `name` prop	merge pull request from bekzod/remove-unused-prop	50	true	false	5	true	false	false	emberjs	ember.js	10,545
0efa8d5b29d33df06de7405ded453f519700e236	Joe Ruello	Joe Ruello	[DOC release] Include NaN as a falsey value in {{if}} docs.	[doc release] include nan as a falsey value in {{if}} docs	58	false	false	11	false	false	false	emberjs	ember.js	10,546
839e765a07a979786ebcd3c72b425a97ee73d5c8	Robert Jackson	Robert Jackson	Merge pull request #12691 from jimbeaudoin/patch-1 Fix deprecation link for Ember.String.fmt	merge pull request from jimbeaudoin/patch-1	44	true	false	5	true	false	false	emberjs	ember.js	10,547
192fcebd005a6bf3798ee7bfdff50f801452c865	Robert Jackson	Robert Jackson	Merge pull request #12685 from dgeb/engines [FEATURE ember-application-engines] Initial extraction of engines from applications	merge pull request from dgeb/engines	37	true	false	5	true	false	false	emberjs	ember.js	10,548
18b0a61d8c792f16afe5c15571978eff73ed3d26	Dan Gebhardt	Dan Gebhardt	[FEATURE ember-application-engines] Expose Ember.EngineInstance and Ember.ApplicationInstance. Expose Ember.EngineInstance and Ember.ApplicationInstance for easy overriding. Need to reanalyze whether to continue exposing them after feature flag is removed.	[feature ember-application-engines] expose ember.engineinstance and ember.applicationinstance	93	false	false	6	false	false	false	emberjs	ember.js	10,549
cb4a6748ee499dc9dda3a9688f0295725e00ea34	Dan Gebhardt	Dan Gebhardt	[FEATURE ember-application-engines] Remove unnecessary get/set calls.	[feature ember-application-engines] remove unnecessary get/set calls	68	false	false	6	false	false	false	emberjs	ember.js	10,550
c17979d6f00ef6d23587b2968872ee0bcf46d097	Dan Gebhardt	Dan Gebhardt	[FEATURE ember-application-engines] Use const for module-level declarations.	[feature ember-application-engines] use const for module-level declarations	75	false	false	7	false	false	false	emberjs	ember.js	10,551
c6dc2783ef6dff8010e17bb63d132731e822ff70	Dan Gebhardt	Dan Gebhardt	[FEATURE ember-application-engines] Tests for engine instances. Replicate appropriate tests from application instances. We don’t want to yet move tests while engines are feature flagged and in flux.	[feature ember-application-engines] tests for engine instances	62	false	false	6	false	false	false	emberjs	ember.js	10,552
2a4ead9c28ed149efa9f354e65eea4c401381289	Dan Gebhardt	Dan Gebhardt	[FEATURE ember-application-engines] Tests for engines. Replicate appropriate tests from applications. We don’t want to yet move tests while engines are feature flagged and in flux.	[feature ember-application-engines] tests for engines	53	false	false	5	false	false	false	emberjs	ember.js	10,553
21e86e04291a60e984bae6d71c7ad0d1df9bae86	Dan Gebhardt	Dan Gebhardt	[FEATURE ember-application-engines] Feature flag for Ember.Engine. Only expose `Ember.Engine` when feature flag is enabled.	[feature ember-application-engines] feature flag for ember.engine	65	false	false	6	false	false	false	emberjs	ember.js	10,554
9f0c63a5bdc07ede7b187f29ffda7323d7b65c80	Dan Gebhardt	Dan Gebhardt	[FEATURE ember-application-engines] Refactor container / registry initialization for engine instances. Move registry and container creation from `ApplicationInstance` to `EngineInstance`.	[feature ember-application-engines] refactor container / registry initialization for engine instances	101	false	false	10	false	false	false	emberjs	ember.js	10,555
7b0a7ecb5b9e863bded0094d8b7e5c1861e1d52f	Dan Gebhardt	Dan Gebhardt	[FEATURE ember-application-engines] Refactor registry and resolver concerns for engines. Provide a spare base implementation of `buildRegistry` for `Engine`, which is extended by `Application`. Also, allow for a custom `Resolver` property on `Engine` (and by extension, `Application`).	[feature ember-application-engines] refactor registry and resolver concerns for engines	87	false	false	9	false	false	false	emberjs	ember.js	10,556
6efba8b8b2160c8fa224e3bc98e22d0e4b77022c	Dan Gebhardt	Dan Gebhardt	[FEATURE ember-application-engines] Move initializers from Application to Engine. Initializers and instance initializers are a common concern for applications and engines.	[feature ember-application-engines] move initializers from application to engine	80	false	false	8	false	false	false	emberjs	ember.js	10,557
ffa7ab1ce7a9f9d806726bb00941a1f65000a3a7	Dan Gebhardt	Dan Gebhardt	[FEATURE ember-application-engines] Initial addition of Engine + EngineInstance	[feature ember-application-engines] initial addition of engine + engineinstance	79	false	false	8	false	false	false	emberjs	ember.js	10,558
254fdf1514020b19ece60d96305e87f2e00ee4f2	Jimmy Beaudoin	Jimmy Beaudoin	Fix deprecation link for Ember.String.fmt	fix deprecation link for ember.string.fmt	41	false	false	5	true	true	true	emberjs	ember.js	10,559
3561214e8491d9d3c97728d37a09a23b04f17fef	Robert Jackson	Robert Jackson	Merge pull request #12686 from bekzod/html-safe-none [BUGFIX beta] htmlsafe warning not thrown for none values	merge pull request from bekzod/html-safe-none	46	true	false	5	true	false	false	emberjs	ember.js	10,560
32e7feea93c37742ae2f35ae03c740abb98f5a7a	bekzod	bekzod	[BUGFIX beta] htmlsafe warning not thrown for none values	[bugfix beta] htmlsafe warning not thrown for none values	57	false	false	9	false	false	false	emberjs	ember.js	10,561
ccf419af51a7383235f8f537033d8bab5ddfd083	bekzod	bekzod	removed unused `name` prop	removed unused `name` prop	26	false	false	4	false	false	false	emberjs	ember.js	10,562
3f4db6ff5d8a26800efa7338de3513754dfcc4bb	Robert Jackson	Robert Jackson	Merge pull request #12682 from Serabe/fix-12678 [BUGFIX beta] Fix rerendering contextual components when invoked with dot syntax and block form	merge pull request from serabe/fix-12678	41	true	false	5	true	true	false	emberjs	ember.js	10,563
f0dafd4d5f3e483a8d8111f8f7b75c6dd80f4adb	Matthew Beale	Matthew Beale	Merge pull request #12673 from rwjblue/local-lookup [FEATURE ember-htmlbars-local-lookup]	merge pull request from rwjblue/local-lookup	45	true	false	5	true	false	false	emberjs	ember.js	10,564
8af7da67c4b1eab94a6adfc82c91af98dc3ee532	Robert Jackson	Robert Jackson	[FEATURE ember-htmlbars-local-lookup] Implements local lookup concepts. This new concept is primarily used from the template layer in this initial implementation, but the `source` option is usable generally. There are a couple main concepts being added here: * Expanding a `type:name` relative to a given source `type:name` into a fully qualified `type:name` (that includes the source info). * Expose the currently rendering `template`'s `meta` information on the `RenderEnv`. * Adding a second layer of lookups in all places that components or helpers are resolved. \#### `expandLocalLookup` We use the `expandLocalLookup` function on the resolver (when present) to take both the source and target full names and return a new fully qualified full name. By default the resolver will not have an `expandLocalLookup` function, but an example implementation exists in the `ember-htmlbars/tests/integration/local-lookup-test` module here. \#### `meta` As of Ember 1.12, metadata has been appended to every template to allow better customization of things like deprecation messages and template compilation errors. With the changes in this commit that metadata is exposed on the `RenderEnv` which is present through the various internal glimmer engine hooks (and provides us the `source` information needed for the local lookups added here). \#### local + global lookups The various places that are responsible for looking helpers and components up have been updated to do two layers of lookups. Once for the current global style lookups, and a second for lookups relative to the invocation template.	[feature ember-htmlbars-local-lookup]	37	false	false	2	false	false	false	emberjs	ember.js	10,565
4bb5ee4669c82efabbe77a78f103948397646b35	Sergio Arbeo	Sergio Arbeo	[BUGFIX beta] Fix rerendering contextual components when invoked with dot syntax and in block form Block form of components does not use the same hooks as the other invocations. A bit of preprocessing is needed to invalidate it and cause a rerender. Fixes #12678	[bugfix beta] fix rerendering contextual components when invoked with dot	73	false	false	10	false	false	false	emberjs	ember.js	10,566
3b2ac4c2a0da6b173ff82c8078f4bffbfaacc613	Robert Jackson	Robert Jackson	Merge pull request #12680 from dgeb/reset-on-unregister [BUGFIX Release] Clear cached instances when factories are unregistered.	merge pull request from dgeb/reset-on-unregister	49	true	false	5	true	false	false	emberjs	ember.js	10,567
8768e67353103ac5e79429addcb8de246433727c	Dan Gebhardt	Dan Gebhardt	[BUGFIX Release] Clear cached instances when factories are unregistered. `ApplicationInstance#unregister` now overrides `RegistryProxy#unregister` in order to clear any cached instances of the unregistered factory (via `__container__.reset()`). [Closes #11173]	[bugfix release] clear cached instances when factories are unregistered	71	false	false	9	false	false	false	emberjs	ember.js	10,568
3d1cf7b6eba35a6502bb33970fb4644cea6820e1	Robert Jackson	Robert Jackson	Merge pull request #12666 from dgeb/disentangle-registry-hooks [BUGFIX release] Prevent triggering V8 memory leak bug through registry / resolver access.	merge pull request from dgeb/disentangle-registry-hooks	56	true	false	5	true	true	false	emberjs	ember.js	10,569
529bfc3bbfa1c1a96d51a085fcc6394101d8ea6f	Dan Gebhardt	Dan Gebhardt	[BUGFIX release] Prevent triggering V8 memory leak bug through registry / resolver access. This fix changes the expectations of Registry to accept a `resolver` that’s an object with a `resolve` method instead of a straight function. This allows us to avoid closing over access to a resolver object inside a function. It also allows us to avoid setting functions which shadow prototype functions unnecessarily. Setting `Registry#resolver` to a function is still allowed through a constructor option. The `resolver` function will be converted into an object with a `resolve` method and will result in a single deprecation warning. This fix also eliminates the need for application instances to override their registry’s `normalizeFullName` and `makeToString` methods. Instead, the fallback registry will be checked when evaluating these methods before returning the defaults. Again, this avoids the need to override instance functions that shadow prototype functions. [Fixes #12618]	[bugfix release] prevent triggering v8 memory leak bug through registry / resolver access	89	false	false	13	false	false	false	emberjs	ember.js	10,570
f455bc9f532512780c81ca5886c8e147a5811d47	Robert Jackson	Robert Jackson	Merge pull request #12664 from balinterdi/precise-docstring-for-with-helper Include NaN as a falsey value in the `with` helper's docstring	merge pull request from balinterdi/precise-docstring-for-with-helper	69	true	false	5	true	false	false	emberjs	ember.js	10,571
32e9438535324609163b9b2b50ad1d0a87e70e89	Balint Erdi	Balint Erdi	Include NaN as a falsey value in the `with` helper's docstring	include nan as a falsey value in the `with` helper's docstring	62	false	false	11	false	true	false	emberjs	ember.js	10,572
4593e27a00293054bbe5ec2373c6a86cc3733a03	Robert Jackson	Robert Jackson	Merge pull request #12662 from mcmarZen/patch-1 correction for Ember.String.capitalize docs	merge pull request from mcmarzen/patch-1	41	true	false	5	true	false	false	emberjs	ember.js	10,573
fd5b180fe466875a5d61fbdc3cce1745d2a41948	Mike Martin	Mike Martin	correction for Ember.String.prototype.capitalize docs	correction for ember.string.prototype.capitalize docs	53	false	false	4	false	false	false	emberjs	ember.js	10,574
4c6ef677bc1c7050c8268e64963072cc8689f010	Robert Jackson	Robert Jackson	Merge pull request #12659 from rwjblue/update-htmlbars [BUGFIX beta] Update HTMLBars to 0.14.7.	merge pull request from rwjblue/update-htmlbars	48	true	false	5	true	false	false	emberjs	ember.js	10,575
16313bc2590a70a4dc728092bb0ce6b2a25e102f	Robert Jackson	Robert Jackson	[BUGFIX beta] Update HTMLBars to 0.14.7. Compare view: https://github.com/tildeio/htmlbars/compare/v0.14.6...v0.14.7 Main issue fixed is for Android 4.0/4.1 builtin browser throwing errors in non-minified builds (due to unquoted usage of `yield`).	[bugfix beta] update htmlbars to 0.14.7	39	false	false	6	false	false	false	emberjs	ember.js	10,576
18041f892dfd9db87b90d8770469df8a2b2b951b	Robert Jackson	Robert Jackson	Update CHANGELOG to include v2.3.0-beta.2.	update changelog to include v2.3.0-beta.2	41	false	false	5	true	true	true	emberjs	ember.js	10,577
27862a18b8773e57c52dbc7141b1f92a505f16ff	Robert Jackson	Robert Jackson	Merge pull request #12648 from rwjblue/move-main-exports Move `packages//lib/main.js` to `packages//lib/index.js`.	merge pull request from rwjblue/move-main-exports	50	true	false	5	true	false	false	emberjs	ember.js	10,578
89f0516c78af31fbd2ef3c9e7a6b84b497be6105	Robert Jackson	Robert Jackson	Remove internal usage of `Ember.__loader`.	remove internal usage of `ember.__loader`	41	false	false	5	true	true	true	emberjs	ember.js	10,579
0770bdd792533c7d6ee0d04df710c7a90ee6c166	Robert Jackson	Robert Jackson	Update emberjs-build to reduce wasted `main.js` manipulation.	update emberjs-build to reduce wasted `main.js` manipulation	60	false	false	7	true	false	false	emberjs	ember.js	10,580
80270f186a7863ea3c946ee2d14ca6118dd7e3a8	Robert Jackson	Robert Jackson	Add fallback for `${moduleName}/index`. This follows suit with changes made in ember-cli/loader.js@v3.5.0.	add fallback for `${modulename}/index`	38	false	false	4	true	true	true	emberjs	ember.js	10,581
83460a5c82260fc87fc0a2dd83ba8e91a5802d3f	Robert Jackson	Robert Jackson	Move `packages//lib/main.js` to `packages//lib/index.js`.	move `packages//lib/main.js` to `packages//lib/index.js`	60	false	false	4	false	true	false	emberjs	ember.js	10,582
ca85208ab2f0d319e04d79bf83aa781f46ee7436	Stefan Penner	Stefan Penner	Merge pull request #12636 from rwjblue/ensure-tostring-has-slot-on-mixin-prototype [BUGFIX beta] Ensure Mixin.prototype.toString is defined.	merge pull request from rwjblue/ensure-tostring-has-slot-on-mixin-prototype	76	true	false	5	true	false	false	emberjs	ember.js	10,583
4638cbcc4f70f8bd47c70b332b5f6945d0523421	Stefan Penner	Stefan Penner	Merge pull request #12638 from StevenNunez/patch-1 Update references to find methods	merge pull request from stevennunez/patch-1	44	true	false	5	true	false	false	emberjs	ember.js	10,584
e931fd790d49f0845339167c9333099c1cb248d6	Stefan Penner	Stefan Penner	Merge pull request #12647 from emberjs/update-cli update cli	merge pull request from emberjs/update-cli	43	true	false	5	true	false	false	emberjs	ember.js	10,585
44f5fc59befadc6d73e5a0551a552b6b05cae718	Stefan Penner	Stefan Penner	update cli	update cli	10	false	false	2	true	false	false	emberjs	ember.js	10,586
7db3a0dbb011699ecf6b58be85a30d9610fdb8c2	Steven Nunez	Steven Nunez	Update references to find methods	update references to find methods	33	false	false	5	false	true	false	emberjs	ember.js	10,587
895bbd7f4e496353d4f1aac331ff7bbd15f8937a	Robert Jackson	Robert Jackson	[BUGFIX beta] Ensure Mixin.prototype.toString is defined. `Mixin.prototype` is sealed after its initial definition, but `Mixin.prototype.toString` is assigned later in `ember-runtime/namespace`. This causes issues when `ember-template-compiler.js` is loaded before the rest of Ember (because the `Mixin.prototype` is sealed). Unfortunately, the debug functions (for `Object.seal`) does not work in the `ember-metal` package at this time. This fix is a temporary fix to allow the loading of `ember-template-compiler.js` to be before or after `ember.debug.js`. The more permanent fix is to ensure that `debugSeal` works in ember-metal properly.	[bugfix beta] ensure mixin.prototype.tostring is defined	56	false	false	6	false	false	false	emberjs	ember.js	10,588
cfed40154285501c19a60aef3c0f51c645c9d44d	Robert Jackson	Robert Jackson	Merge pull request #12629 from rwjblue/add-owner-injection [BUGFIX beta] Expose ownerInjection method on ContainerProxy.	merge pull request from rwjblue/add-owner-injection	52	true	false	5	true	false	false	emberjs	ember.js	10,589
6d063b8f7111190e3535b4503b78fbcc10241439	Robert Jackson	Robert Jackson	[BUGFIX beta] Expose ownerInjection method on ContainerProxy. The `ember-container-inject-owner` feature provides a public API for accessing various container/registry functions. Unfortunately, creating an instance that has access to the same owner is a somewhat annoying API compared to what we would do today. In Ember 2.2 you would often do this (though it still uses private API): ```js User.create({ container: this.container, username: 'John' }); ``` But in 2.3.0-beta.1 to do roughly the same thing, you would have to do: ```js var options = { username: 'John' }; setOwner(options, getOwner(this)); User.create(options); ``` This is definitely less ergonomic for a perfectly supported case. With the changes added here, you would use the following: ```js User.create( getOwner(this).ownerInjection(), { username: 'John' } ); ```	[bugfix beta] expose ownerinjection method on containerproxy	60	false	false	7	false	false	false	emberjs	ember.js	10,590
f03eab4179db6a78877694d28e748a96f9abadb0	Robert Jackson	Robert Jackson	Merge pull request #12628 from Serabe/fix-12613 [BUGFIX beta] Fix processing arguments in rerender	merge pull request from serabe/fix-12613	41	true	false	5	true	true	false	emberjs	ember.js	10,591
ab72105e20626a8d614674ab434aafab52ac3922	Sergio Arbeo	Sergio Arbeo	[BUGFIX beta] Fix processing arguments in rerender Rerendering a dot-syntax closure component failed to update the attributes due to the shortcut being done too soon. Fix #12613	[bugfix beta] fix processing arguments in rerender	50	false	false	7	false	false	false	emberjs	ember.js	10,592
240b8c2f5c7b001fe0d1714ecee387c25b84de2d	Robert Jackson	Robert Jackson	Merge pull request #12627 from emberjs/remove-unused-flag [CLEANUP beta]	merge pull request from emberjs/remove-unused-flag	51	true	false	5	true	false	false	emberjs	ember.js	10,593
9591917d2f9ed5759fadefbce59f0a6bad264855	Kris Selden	Robert Jackson	[CLEANUP beta] Remove unused ENV flags, this is just to keep PRs small, this is part of a fix for Mixin that went into beta. ENABLE_ALL_FEATURES can't actually do anything more than ENABLE_OPTIONAL_FEATURES, other features are always build time. SHIM_ES5 is just unused as is DISABLE_RANGE_API	[cleanup beta]	14	false	false	2	false	false	false	emberjs	ember.js	10,594
9c58ec6435e139a0f4f3743ee590134f1f323cad	Robert Jackson	Robert Jackson	Merge pull request #12626 from Serabe/fix-12625 [BUGFIX beta] Fix positional params in contextual components with dot syntax	merge pull request from serabe/fix-12625	41	true	false	5	true	true	false	emberjs	ember.js	10,595
a18490a7613d8e4e44703a31f68cead99b692cd6	Sergio Arbeo	Sergio Arbeo	[BUGFIX beta] Fix positional params in contextual components with dot syntax As reported in #12625, positional parameters were not being rendered correctly when using the dot syntax. A longer description on the cause of the problem has been added as a comment to `ember-htmlbars/lib/hooks/component.js` for future warning. Fix #12625	[bugfix beta] fix positional params in contextual components with dot syntax	76	false	false	11	false	false	false	emberjs	ember.js	10,596
6b3e6ea91f871cd55fe7215be8320b8d1c2ef77e	Robert Jackson	Robert Jackson	Update released versions in CHANGELOG.md. [ci skip]	update released versions in changelog.md	40	false	false	5	false	false	false	emberjs	ember.js	10,597
d25e0d7760903b6f65f68d674ccc8decda180704	Robert Jackson	Robert Jackson	Update version info and npm-shrinkwrap.json.	update version info and npm-shrinkwrap.json	43	false	false	5	true	true	true	emberjs	ember.js	10,598
a3223359779d4b033de120fb57f311e6259264c9	Homu	Homu	Auto merge of #12619 - SaladFork:doc-add-cp-getter-setter-example, r=rwjblue [DOC release] Add example and clear up wording for CP get/set This PR makes the following changes to `Ember.computed` API documentation: - Changes the `fullName` getter function to match [the example in the latest guides](http://guides.emberjs.com/v2.1.0/object-model/computed-properties/). This involved changing to a template string from a string concatenation. - Switches class property default values to be defined in `init()` instead ([suggested](https://github.com/emberjs/ember.js/pull/12619#discussion_r44983617)) - Minor changes to wording and sentence structure, mostly adding articles. - Adds an example that uses the hash format with `get` and `set` - Removes confusing/incorrect phrase: > The `get` function should accept two parameters, `key` and `value`. My one concern is that the two examples are very similar except for a few lines. Would it be more helpful if the second example only included the computed property (rather than the whole class and usage example)?	doc-add-cp-getter-setter-example, r=rwjblue	43	false	false	2	false	false	false	emberjs	ember.js	10,599

91b0ebb9f2e0e79d20bef369a4c9450d985aa18c

Robert Jackson

Merge pull request #12752 from rwjblue/rebase-12549 Do not re-raise on errors handled in route error action.

merge pull request from rwjblue/rebase-12549

45

true

false

5

true

false

emberjs

ember.js

10,500

8cdd2f3f92092eff8be0f2c4dbde2f22b760c2da

Robert Jackson

Remove npm-shrinkwrap.json. A simple: ``` npm install --save-dev htmlbars@some-version npm shrinkwrap -dev ``` Results in a bunch of errors, resulting in us manually updating the shrinkwrap file (aka by hand) which is likely even more error prone. The ergonomics here seem to be pretty bad. Would love to be shown what I am doing wrong if that is the case...

remove npm-shrinkwrap.json

26

false

2

true

false

emberjs

ember.js

10,501

a8dc7ca7517b4715445386d10e8b5e86180bdedd

Robert Jackson

[BUGFIX release] Avoid computed for tracking errors in Router.

[bugfix release] avoid computed for tracking errors in router

61

false

9

false

emberjs

ember.js

10,502

ff4d431494f55b319a7085cf1feebaa1e6a44b5e

Robert Jackson

Add more route error action scenario tests.

add more route error action scenario tests

42

false

7

false

true

false

emberjs

ember.js

10,503

200c3b7b5846e22cb230842fc6fe475531f9eaa3

Mina Smart

Robert Jackson

Add tests with multiple re-throw stratiegies. This provides insurance that handled errors aren't swallowed

add tests with multiple re-throw stratiegies

44

false

6

true

emberjs

ember.js

10,504

ef7108a8d1a97fc263918a0fd37db72889419b4c

Mina Smart

Robert Jackson

[BUGFIX release] Mark handled errors and don't reraise Ember 2.1 introduced a regression where all errors during a transition were thrown, even when those errors had been handled in a route's error action. This PR adds a test to identify the regression, and adds some logic and state to identify errors that have been handled, and not reraise them, while maintaining the desired behaviour of throwing errors that aren't handled. This is especially valuable in any application that tests error handling. Since all errors were being thrown regardless of handling, failed assertions were being registered by qunit, and it became impossible to test application flow that entered the error hook. Further details about this issue are here: https://github.com/emberjs/ember.js/issues/12547 Remove leftover debugger This addresses an issue where handled errors are still thrown The added test passes on Ember 2.0. It fails on Ember 2.1 because even though the error is not bubbled, the application throws the handled error. This is contrary to what the documentation indicates. Full details about this issue are here: https://github.com/emberjs/ember.js/issues/12547 This PR also adds a very naive implementation of how to flag an error as having been handled and prevents reraising, while retaining the functionality of throwing errors that aren't caught, or are bubbled from the application route Make error checking methods a part of the router instance Attach error caching methods to EmberRouter, and use guids for errors Errors used as keys were just getting `.toString()`ed, so multiple `Error`s or hashes would all have the same key. This update uses ember `guidFor` to uniquely identify errors. Thanks for the help @rwjblue! When creating a new promise, resolve it. Don't fork the promise Tests expecting errors to bubble up, should bubble errors

[bugfix release] mark handled errors and don't reraise

54

false

8

false

emberjs

ember.js

10,505

2d622f1206b4f03a2c7d58203e93b421b0c1d01d

Robert Jackson

Merge pull request #12749 from rwjblue/router-cleanup Cleanup router & DSL processing.

merge pull request from rwjblue/router-cleanup

47

true

false

5

true

false

emberjs

ember.js

10,506

dac7917cefad7042cc138fdb5ac07454174df2c6

Robert Jackson

Cleanup router & DSL processing. * Remove manual threading of `moduleBasedResolver`. As of the most recent resolver changes we can directly ask the "real" resolver when we need to. This avoids poluting a bunch of places with `moduleBasedResolver` that do not care about that flag. * Prevent creating additional closure just to create application route. * Avoid manually recreating input options for each layer of DSL (just pass options down). * Make DSL creation a separate function.

cleanup router & dsl processing

31

false

5

false

emberjs

ember.js

10,507

f367e7a508a6188485aa65a54d5d979e56798a67

Robert Jackson

Merge pull request #12746 from Serabe/fix/12717 [BUGFIX beta] Update htmlbar to 0.14.11

merge pull request from serabe/fix/12717

41

true

false

5

true

false

emberjs

ember.js

10,508

697e9e5b33dbed25e1d2f1bdb6d88783c490cf99

Sergio Arbeo

[BUGFIX beta] Update htmlbar to 0.14.11 This fixes a bug where a component's cell was being leaked as the first positional parameter. Fixes #12717

[bugfix beta] update htmlbar to 0.14.11

39

false

6

false

emberjs

ember.js

10,509

c3a8dcd4cee1015d00c9ac02395b9d7ab00f76fa

Robert Jackson

Merge pull request #12712 from Serabe/fix/positional-params-on-rerender [BUGFIX beta] Create a new hash parameter when creating a component cell

merge pull request from serabe/fix/positional-params-on-rerender

65

true

false

5

true

false

emberjs

ember.js

10,510

bdcf5bce9f94ed2805d43c6cd9ffe99f0d121dd8

Jake Worth

[DOC release] Clean up documentation - This removes a few typos and attempts to make the overall passage more clear

[doc release] clean up documentation

36

false

5

false

emberjs

ember.js

10,511

2f38e75a5f000dc74a18f77afb84a91bbfe600f5

Jake Worth

[DOC release] Fix typo

[doc release] fix typo

22

false

4

false

emberjs

ember.js

10,512

4e7fe484a09e7f4830cb0d95c7195c037f556956

Sergio Arbeo

[BUGFIX beta] Create a new hash parameter when creating a component cell If we merge positional and hash parameters without duplicating the hash before, then we get an error when rerendering. Fixes test in #12711

[bugfix beta] create a new hash parameter when creating a component cell

72

false

12

false

emberjs

ember.js

10,513

bbb81bb5bc2d0fdc27eec536c7ea04049355d90c

Yuvaraja Balamurugan

Change param to parameter

change param to parameter

25

false

4

true

emberjs

ember.js

10,514

01b1107920498cf2989340c810e45e3806ab134e

Robert Jackson

Merge pull request #12731 from rwjblue/fix-setting-container-on-create [BUGFIX beta] Ensure `container` can still be provided to `.create`.

merge pull request from rwjblue/fix-setting-container-on-create

64

true

false

5

true

false

emberjs

ember.js

10,515

5db59d87a93e42e273464443e3671faeda33dbea

Chris Santero

Robert Jackson

[BUGFIX beta] restore Ember.computed.collect (cherry picked from commit 3c47522ea1ce7b922f414272347ccf8437aad5b7)

[bugfix beta] restore ember.computed.collect

44

false

4

false

emberjs

ember.js

10,516

eeb8a9ba3857ad0b456611df86e39922bce3134e

Trek Glowacki

Removes reference to Ember.ORDER_DEFINITION. That ain't no thang.

removes reference to ember.order_definition. that ain't no thang

64

false

8

false

emberjs

ember.js

10,517

258fc30e77813c185c3b15c5a9ea719feb47b332

Robert Jackson

[BUGFIX beta] Ensure `container` can still be provided to `.create`. In Ember versions until 2.3.0 it was common to provide a `container` property (if needed) when creating instances of a factory manually. This might look like: ``` let Foo = container.lookupFactory('model:foo'); let instance = Foo.create({ container }); ``` Many addons did this (examples include ember-cp-validations and ember-data). Our initial implementation of the deprecated `container` property on extendable factories used `Object.defineProperty` to ensure calling `instance.container` returned the correct value. Unfortunately, we only defined a getter which means calling `Foo.create({ container });` triggers the following error: ``` Cannot set property container of [object Object] which has only a getter ``` This change adds a setter (with an appropriate deprecation) to prevent triggering an error.

[bugfix beta] ensure `container` can still be provided to `.create`

67

false

10

false

emberjs

ember.js

10,518

38630ef1ac873fee983c05a85524fc66c6e064fc

Robert Jackson

Merge pull request #12694 from jwworth/pull-request-1449623534 [DOC release] Fix typos

merge pull request from jwworth/pull-request-1449623534

56

true

false

5

true

false

emberjs

ember.js

10,519

c3deac3d0627a30b89519236df57995ebd3a6135

Robert Jackson

Merge pull request #12710 from raido/master [DOC release] Update link-to classNameBindings and Router.map examples.

merge pull request from raido/master

37

true

false

5

true

false

emberjs

ember.js

10,520

dfbdbea00bb94f3c1620bd09145540a8bbb8e224

Robert Jackson

Merge pull request #12726 from trek/correct-docs-about-is-equal-and-collections [DOC release] Correct API docs about isEqual and collections

merge pull request from trek/correct-docs-about-is-equal-and-collections

73

true

false

5

true

false

emberjs

ember.js

10,521

868bc8d697a3dbb93c4cb0a250e55b426fa96c97

Trek Glowacki

[DOC release] Correct API docs about isEqual and collections

[doc release] correct api docs about isequal and collections

60

false

9

false

emberjs

ember.js

10,522

2a269addc9b27d642a6ba16c5c4b83f5fcc7c65f

Robert Jackson

Merge pull request #12725 from trek/documentation-fixup-on-lib-utils [DOC RELEASE] Update isArray to use more common 'Array-like' description

merge pull request from trek/documentation-fixup-on-lib-utils

62

true

false

5

true

false

emberjs

ember.js

10,523

997b5c9945335a7b031608c41f15690ec38ba349

Trek Glowacki

[DOC RELEASE] Update isArray to use more common 'Array like' description

[doc release] update isarray to use more common 'array like' description

72

false

11

false

emberjs

ember.js

10,524

706a4d5755db30ab5e1dfb4cf8927bb82216b9b9

Yuvaraja Balamurugan

[DOC release] Document on index block param for each helper

[doc release] document on index block param for each helper

59

false

10

false

emberjs

ember.js

10,525

fbab176eb41727dc6a4718ee3dfdc6490706b3b2

Stefan Penner

Merge pull request #12714 from chadhietala/dsl-shaping DSL shaping

merge pull request from chadhietala/dsl-shaping

48

true

false

5

true

false

emberjs

ember.js

10,526

319e0ed01ea812b86597eb64e033478b59eeb7fc

Chad Hietala

DSL shaping

dsl shaping

11

false

2

false

emberjs

ember.js

10,527

07ea1892c3eea8e341b792d48412708d46c5bda3

Marten Schilstra

[WIP][BUGFIX Beta] Positional param clash on rerender of contextual component helper

[wip][bugfix beta] positional param clash on rerender of contextual component helper

84

false

11

false

emberjs

ember.js

10,528

38e6902cd3103945d1a0791e1801d9f663172096

Raido Kuli

[DOC release] Update link-to classNameBindings and Router.map examples.

[doc release] update link-to classnamebindings and router.map examples

70

false

8

false

emberjs

ember.js

10,529

302247a0c6212adc5acfbfcf541f36f230b4c8ed

Robert Jackson

Merge pull request #12706 from Serabe/feature/upgrade-htmlbars-contextual-components [BUGFIX beta] Update HTMLBars

merge pull request from serabe/feature/upgrade-htmlbars-contextual-components

78

true

false

5

true

false

emberjs

ember.js

10,530

55e3723a7ba122ec564b63e00440f017f4f49731

Sergio Arbeo

[BUGFIX beta] Update HTMLBars Add support for Glimmer components whose name has a dot.

[bugfix beta] update htmlbars

29

false

4

false

emberjs

ember.js

10,531

039167cea22129ab2fbbeadaa7a686dd4dd7a47f

Robert Jackson

Merge pull request #12705 from emberjs/fix-fastboot-crash [BUGFIX beta] Fix FastBoot URL parsing crash

merge pull request from emberjs/fix-fastboot-crash

51

true

false

5

true

false

emberjs

ember.js

10,532

97ec5ef8bd8f33c318c2e50c527eee49c4d03020

Tom Dale

[BUGFIX beta] Fix FastBoot URL parsing crash

[bugfix beta] fix fastboot url parsing crash

44

false

7

false

emberjs

ember.js

10,533

0cb5442d08db80667539963877c91f4d9eec844d

Robert Jackson

Merge pull request #12701 from rwjblue/update-emberjs-build [BUGFIX beta] Update emberjs-build to prevent IIFE negation.

merge pull request from rwjblue/update-emberjs-build

53

true

false

5

true

false

emberjs

ember.js

10,534

8f36fa2509de01de4d080e62c2bd98a425bef30c

Robert Jackson

[BUGFIX beta] Update emberjs-build to prevent IIFE negation. See https://github.com/emberjs/emberjs-build/pull/135 for details.

[bugfix beta] update emberjs-build to prevent iife negation

59

false

8

false

emberjs

ember.js

10,535

31eadb4d25fc700fc116c4debeaa177154e1338b

Robert Jackson

Merge pull request #12699 from rwjblue/do-not-change-frozen-things [BUGFIX beta] Only add deprecated container after create when present.

merge pull request from rwjblue/do-not-change-frozen-things

60

true

false

5

true

false

emberjs

ember.js

10,536

b6e783d6fb4310d020feacb12052cbcac35ec7f8

Robert Jackson

[BUGFIX beta] Only add deprecated container after create when present. When the object returned from calling `.create` on a non-extendable factory does not contain a `container` property, do not set it. Previously, in Ember 2.2.0 it was possible to use non-extendable factories that were frozen after creation. After the changes to add a mock container to `.create` and swap that with the deprecated property after `.create` was finished, we trigger errors for anything that is frozen or sealed.

[bugfix beta] only add deprecated container after create when present

69

false

10

false

emberjs

ember.js

10,537

b3ce376faf57a11de253069338c800199fcfdf76

Robert Jackson

Merge pull request #12698 from davidpett/convert-super-apply-to-es6 convert all this._super.apply(this, arguments) to this._super(...arguments)

merge pull request from davidpett/convert-super-apply-to-es6

61

true

false

5

true

false

emberjs

ember.js

10,538

7847e8fa85c90f3c63ba2b02cdd97a0cfb488e03

David Pett

convert all this._super.apply(this, arguments) to this._super(...arguments)

75

false

6

false

true

false

emberjs

ember.js

10,539

cb980bc8e46bfc99aee2b6faa06f5f03e4855a2d

Robert Jackson

Merge pull request #12693 from thomascchen/doc-remove-function-whitespace [DOC release] Remove whitespace from function declaration

merge pull request from thomascchen/doc-remove-function-whitespace

67

true

false

5

true

false

emberjs

ember.js

10,540

8d62be51ce9602ce6f3aa05682a2847af8b5dc7a

Jake Worth

[DOC release] Fix typos

[doc release] fix typos

23

false

4

false

emberjs

ember.js

10,541

cc325dd5cf8c496cfe3f5fb49b41beb3207f0d2d

Thomas Chen

[DOC release] Remove whitespace from function declaration

[doc release] remove whitespace from function declaration

57

false

7

false

emberjs

ember.js

10,542

8fbcf6ddc0d20f0b3ca406ed8c0ad4018f3fa1b1

Robert Jackson

Merge pull request #12677 from emberjs/remove-fastboot-monkeypatch [BUGFIX beta] Remove FastBoot monkeypatch

merge pull request from emberjs/remove-fastboot-monkeypatch

60

true

false

5

true

false

emberjs

ember.js

10,543

a9145411a1199c77a087cda3f0dee0f54ec943c0

Tom Dale

[BUGFIX beta] Remove DOM Helper monkeypatches The DOM helper used to require a specially patched version of `protocolForURL` and `setMorphHTML` to work in Node. This commit: 1) Adds a test to verify attributes are correctly sanitized in Node 2) Removes the monkeypatches

[bugfix beta] remove dom helper monkeypatches

45

false

6

false

emberjs

ember.js

10,544

3771c93d83f223f33c1f8cc99d4b1da242e55719

Robert Jackson

Merge pull request #12674 from bekzod/remove-unused-prop removed unused `name` prop

merge pull request from bekzod/remove-unused-prop

50

true

false

5

true

false

emberjs

ember.js

10,545

0efa8d5b29d33df06de7405ded453f519700e236

Joe Ruello

[DOC release] Include NaN as a falsey value in {{if}} docs.

[doc release] include nan as a falsey value in {{if}} docs

58

false

11

false

emberjs

ember.js

10,546

839e765a07a979786ebcd3c72b425a97ee73d5c8

Robert Jackson

Merge pull request #12691 from jimbeaudoin/patch-1 Fix deprecation link for Ember.String.fmt

merge pull request from jimbeaudoin/patch-1

44

true

false

5

true

false

emberjs

ember.js

10,547

192fcebd005a6bf3798ee7bfdff50f801452c865

Robert Jackson

Merge pull request #12685 from dgeb/engines [FEATURE ember-application-engines] Initial extraction of engines from applications

merge pull request from dgeb/engines

37

true

false

5

true

false

emberjs

ember.js

10,548

18b0a61d8c792f16afe5c15571978eff73ed3d26

Dan Gebhardt

[FEATURE ember-application-engines] Expose Ember.EngineInstance and Ember.ApplicationInstance. Expose Ember.EngineInstance and Ember.ApplicationInstance for easy overriding. Need to reanalyze whether to continue exposing them after feature flag is removed.

[feature ember-application-engines] expose ember.engineinstance and ember.applicationinstance

93

false

6

false

emberjs

ember.js

10,549

cb4a6748ee499dc9dda3a9688f0295725e00ea34

Dan Gebhardt

[FEATURE ember-application-engines] Remove unnecessary get/set calls.

[feature ember-application-engines] remove unnecessary get/set calls

68

false

6

false

emberjs

ember.js

10,550

c17979d6f00ef6d23587b2968872ee0bcf46d097

Dan Gebhardt

[FEATURE ember-application-engines] Use const for module-level declarations.

[feature ember-application-engines] use const for module-level declarations

75

false

7

false

emberjs

ember.js

10,551

c6dc2783ef6dff8010e17bb63d132731e822ff70

Dan Gebhardt

[FEATURE ember-application-engines] Tests for engine instances. Replicate appropriate tests from application instances. We don’t want to yet move tests while engines are feature flagged and in flux.

[feature ember-application-engines] tests for engine instances

62

false

6

false

emberjs

ember.js

10,552

2a4ead9c28ed149efa9f354e65eea4c401381289

Dan Gebhardt

[FEATURE ember-application-engines] Tests for engines. Replicate appropriate tests from applications. We don’t want to yet move tests while engines are feature flagged and in flux.

[feature ember-application-engines] tests for engines

53

false

5

false

emberjs

ember.js

10,553

21e86e04291a60e984bae6d71c7ad0d1df9bae86

Dan Gebhardt

[FEATURE ember-application-engines] Feature flag for Ember.Engine. Only expose `Ember.Engine` when feature flag is enabled.

[feature ember-application-engines] feature flag for ember.engine

65

false

6

false

emberjs

ember.js

10,554

9f0c63a5bdc07ede7b187f29ffda7323d7b65c80

Dan Gebhardt

[FEATURE ember-application-engines] Refactor container / registry initialization for engine instances. Move registry and container creation from `ApplicationInstance` to `EngineInstance`.

[feature ember-application-engines] refactor container / registry initialization for engine instances

101

false

10

false

emberjs

ember.js

10,555

7b0a7ecb5b9e863bded0094d8b7e5c1861e1d52f

Dan Gebhardt

[FEATURE ember-application-engines] Refactor registry and resolver concerns for engines. Provide a spare base implementation of `buildRegistry` for `Engine`, which is extended by `Application`. Also, allow for a custom `Resolver` property on `Engine` (and by extension, `Application`).

[feature ember-application-engines] refactor registry and resolver concerns for engines

87

false

9

false

emberjs

ember.js

10,556

6efba8b8b2160c8fa224e3bc98e22d0e4b77022c

Dan Gebhardt

[FEATURE ember-application-engines] Move initializers from Application to Engine. Initializers and instance initializers are a common concern for applications and engines.

[feature ember-application-engines] move initializers from application to engine

80

false

8

false

emberjs

ember.js

10,557

ffa7ab1ce7a9f9d806726bb00941a1f65000a3a7

Dan Gebhardt

[FEATURE ember-application-engines] Initial addition of Engine + EngineInstance

[feature ember-application-engines] initial addition of engine + engineinstance

79

false

8

false

emberjs

ember.js

10,558

254fdf1514020b19ece60d96305e87f2e00ee4f2

Jimmy Beaudoin

Fix deprecation link for Ember.String.fmt

fix deprecation link for ember.string.fmt

41

false

5

true

emberjs

ember.js

10,559

3561214e8491d9d3c97728d37a09a23b04f17fef

Robert Jackson

Merge pull request #12686 from bekzod/html-safe-none [BUGFIX beta] htmlsafe warning not thrown for none values

merge pull request from bekzod/html-safe-none

46

true

false

5

true

false

emberjs

ember.js

10,560

32e7feea93c37742ae2f35ae03c740abb98f5a7a

bekzod

[BUGFIX beta] htmlsafe warning not thrown for none values

[bugfix beta] htmlsafe warning not thrown for none values

57

false

9

false

emberjs

ember.js

10,561

ccf419af51a7383235f8f537033d8bab5ddfd083

bekzod

removed unused `name` prop

26

false

4

false

emberjs

ember.js

10,562

3f4db6ff5d8a26800efa7338de3513754dfcc4bb

Robert Jackson

Merge pull request #12682 from Serabe/fix-12678 [BUGFIX beta] Fix rerendering contextual components when invoked with dot syntax and block form

merge pull request from serabe/fix-12678

41

true

false

5

true

false

emberjs

ember.js

10,563

f0dafd4d5f3e483a8d8111f8f7b75c6dd80f4adb

Matthew Beale

Merge pull request #12673 from rwjblue/local-lookup [FEATURE ember-htmlbars-local-lookup]

merge pull request from rwjblue/local-lookup

45

true

false

5

true

false

emberjs

ember.js

10,564

8af7da67c4b1eab94a6adfc82c91af98dc3ee532

Robert Jackson

[FEATURE ember-htmlbars-local-lookup] Implements local lookup concepts. This new concept is primarily used from the template layer in this initial implementation, but the `source` option is usable generally. There are a couple main concepts being added here: * Expanding a `type:name` relative to a given source `type:name` into a fully qualified `type:name` (that includes the source info). * Expose the currently rendering `template`'s `meta` information on the `RenderEnv`. * Adding a second layer of lookups in all places that components or helpers are resolved. \#### `expandLocalLookup` We use the `expandLocalLookup` function on the resolver (when present) to take both the source and target full names and return a new fully qualified full name. By default the resolver will not have an `expandLocalLookup` function, but an example implementation exists in the `ember-htmlbars/tests/integration/local-lookup-test` module here. \#### `meta` As of Ember 1.12, metadata has been appended to every template to allow better customization of things like deprecation messages and template compilation errors. With the changes in this commit that metadata is exposed on the `RenderEnv` which is present through the various internal glimmer engine hooks (and provides us the `source` information needed for the local lookups added here). \#### local + global lookups The various places that are responsible for looking helpers and components up have been updated to do two layers of lookups. Once for the current global style lookups, and a second for lookups relative to the invocation template.

[feature ember-htmlbars-local-lookup]

37

false

2

false

emberjs

ember.js

10,565

4bb5ee4669c82efabbe77a78f103948397646b35

Sergio Arbeo

[BUGFIX beta] Fix rerendering contextual components when invoked with dot syntax and in block form Block form of components does not use the same hooks as the other invocations. A bit of preprocessing is needed to invalidate it and cause a rerender. Fixes #12678

[bugfix beta] fix rerendering contextual components when invoked with dot

73

false

10

false

emberjs

ember.js

10,566

3b2ac4c2a0da6b173ff82c8078f4bffbfaacc613

Robert Jackson

Merge pull request #12680 from dgeb/reset-on-unregister [BUGFIX Release] Clear cached instances when factories are unregistered.

merge pull request from dgeb/reset-on-unregister

49

true

false

5

true

false

emberjs

ember.js

10,567

8768e67353103ac5e79429addcb8de246433727c

Dan Gebhardt

[BUGFIX Release] Clear cached instances when factories are unregistered. `ApplicationInstance#unregister` now overrides `RegistryProxy#unregister` in order to clear any cached instances of the unregistered factory (via `__container__.reset()`). [Closes #11173]

[bugfix release] clear cached instances when factories are unregistered

71

false

9

false

emberjs

ember.js

10,568

3d1cf7b6eba35a6502bb33970fb4644cea6820e1

Robert Jackson

Merge pull request #12666 from dgeb/disentangle-registry-hooks [BUGFIX release] Prevent triggering V8 memory leak bug through registry / resolver access.

merge pull request from dgeb/disentangle-registry-hooks

56

true

false

5

true

false

emberjs

ember.js

10,569

529bfc3bbfa1c1a96d51a085fcc6394101d8ea6f

Dan Gebhardt

[BUGFIX release] Prevent triggering V8 memory leak bug through registry / resolver access. This fix changes the expectations of Registry to accept a `resolver` that’s an object with a `resolve` method instead of a straight function. This allows us to avoid closing over access to a resolver object inside a function. It also allows us to avoid setting functions which shadow prototype functions unnecessarily. Setting `Registry#resolver` to a function is still allowed through a constructor option. The `resolver` function will be converted into an object with a `resolve` method and will result in a single deprecation warning. This fix also eliminates the need for application instances to override their registry’s `normalizeFullName` and `makeToString` methods. Instead, the fallback registry will be checked when evaluating these methods before returning the defaults. Again, this avoids the need to override instance functions that shadow prototype functions. [Fixes #12618]

[bugfix release] prevent triggering v8 memory leak bug through registry / resolver access

89

false

13

false

emberjs

ember.js

10,570

f455bc9f532512780c81ca5886c8e147a5811d47

Robert Jackson

Merge pull request #12664 from balinterdi/precise-docstring-for-with-helper Include NaN as a falsey value in the `with` helper's docstring

merge pull request from balinterdi/precise-docstring-for-with-helper

69

true

false

5

true

false

emberjs

ember.js

10,571

32e9438535324609163b9b2b50ad1d0a87e70e89

Balint Erdi

Include NaN as a falsey value in the `with` helper's docstring

include nan as a falsey value in the `with` helper's docstring

62

false

11

false

true

false

emberjs

ember.js

10,572

4593e27a00293054bbe5ec2373c6a86cc3733a03

Robert Jackson

Merge pull request #12662 from mcmarZen/patch-1 correction for Ember.String.capitalize docs

merge pull request from mcmarzen/patch-1

41

true

false

5

true

false

emberjs

ember.js

10,573

fd5b180fe466875a5d61fbdc3cce1745d2a41948

Mike Martin

correction for Ember.String.prototype.capitalize docs

correction for ember.string.prototype.capitalize docs

53

false

4

false

emberjs

ember.js

10,574

4c6ef677bc1c7050c8268e64963072cc8689f010

Robert Jackson

Merge pull request #12659 from rwjblue/update-htmlbars [BUGFIX beta] Update HTMLBars to 0.14.7.

merge pull request from rwjblue/update-htmlbars

48

true

false

5

true

false

emberjs

ember.js

10,575

16313bc2590a70a4dc728092bb0ce6b2a25e102f

Robert Jackson

[BUGFIX beta] Update HTMLBars to 0.14.7. Compare view: https://github.com/tildeio/htmlbars/compare/v0.14.6...v0.14.7 Main issue fixed is for Android 4.0/4.1 builtin browser throwing errors in non-minified builds (due to unquoted usage of `yield`).

[bugfix beta] update htmlbars to 0.14.7

39

false

6

false

emberjs

ember.js

10,576

18041f892dfd9db87b90d8770469df8a2b2b951b

Robert Jackson

Update CHANGELOG to include v2.3.0-beta.2.

update changelog to include v2.3.0-beta.2

41

false

5

true

emberjs

ember.js

10,577

27862a18b8773e57c52dbc7141b1f92a505f16ff

Robert Jackson

Merge pull request #12648 from rwjblue/move-main-exports Move `packages/**/lib/main.js` to `packages/**/lib/index.js`.

merge pull request from rwjblue/move-main-exports

50

true

false

5

true

false

emberjs

ember.js

10,578

89f0516c78af31fbd2ef3c9e7a6b84b497be6105

Robert Jackson

Remove internal usage of `Ember.__loader`.

remove internal usage of `ember.__loader`

41

false

5

true

emberjs

ember.js

10,579

0770bdd792533c7d6ee0d04df710c7a90ee6c166

Robert Jackson

Update emberjs-build to reduce wasted `main.js` manipulation.

update emberjs-build to reduce wasted `main.js` manipulation

60

false

7

true

false

emberjs

ember.js

10,580

80270f186a7863ea3c946ee2d14ca6118dd7e3a8

Robert Jackson

Add fallback for `${moduleName}/index`. This follows suit with changes made in ember-cli/loader.js@v3.5.0.

add fallback for `${modulename}/index`

38

false

4

true

emberjs

ember.js

10,581

83460a5c82260fc87fc0a2dd83ba8e91a5802d3f

Robert Jackson

Move `packages/**/lib/main.js` to `packages/**/lib/index.js`.

move `packages/**/lib/main.js` to `packages/**/lib/index.js`

60

false

4

false

true

false

emberjs

ember.js

10,582

ca85208ab2f0d319e04d79bf83aa781f46ee7436

Stefan Penner

Merge pull request #12636 from rwjblue/ensure-tostring-has-slot-on-mixin-prototype [BUGFIX beta] Ensure Mixin.prototype.toString is defined.

merge pull request from rwjblue/ensure-tostring-has-slot-on-mixin-prototype

76

true

false

5

true

false

emberjs

ember.js

10,583

4638cbcc4f70f8bd47c70b332b5f6945d0523421

Stefan Penner

Merge pull request #12638 from StevenNunez/patch-1 Update references to find methods

merge pull request from stevennunez/patch-1

44

true

false

5

true

false

emberjs

ember.js

10,584

e931fd790d49f0845339167c9333099c1cb248d6

Stefan Penner

Merge pull request #12647 from emberjs/update-cli update cli

merge pull request from emberjs/update-cli

43

true

false

5

true

false

emberjs

ember.js

10,585

44f5fc59befadc6d73e5a0551a552b6b05cae718

Stefan Penner

update cli

10

false

2

true

false

emberjs

ember.js

10,586

7db3a0dbb011699ecf6b58be85a30d9610fdb8c2

Steven Nunez

Update references to find methods

update references to find methods

33

false

5

false

true

false

emberjs

ember.js

10,587

895bbd7f4e496353d4f1aac331ff7bbd15f8937a

Robert Jackson

[BUGFIX beta] Ensure Mixin.prototype.toString is defined. `Mixin.prototype` is sealed after its initial definition, but `Mixin.prototype.toString` is assigned later in `ember-runtime/namespace`. This causes issues when `ember-template-compiler.js` is loaded before the rest of Ember (because the `Mixin.prototype` is sealed). Unfortunately, the debug functions (for `Object.seal`) does not work in the `ember-metal` package at this time. This fix is a temporary fix to allow the loading of `ember-template-compiler.js` to be before or after `ember.debug.js`. The more permanent fix is to ensure that `debugSeal` works in ember-metal properly.

[bugfix beta] ensure mixin.prototype.tostring is defined

56

false

6

false

emberjs

ember.js

10,588

cfed40154285501c19a60aef3c0f51c645c9d44d

Robert Jackson

Merge pull request #12629 from rwjblue/add-owner-injection [BUGFIX beta] Expose ownerInjection method on ContainerProxy.

merge pull request from rwjblue/add-owner-injection

52

true

false

5

true

false

emberjs

ember.js

10,589

6d063b8f7111190e3535b4503b78fbcc10241439

Robert Jackson

[BUGFIX beta] Expose ownerInjection method on ContainerProxy. The `ember-container-inject-owner` feature provides a public API for accessing various container/registry functions. Unfortunately, creating an instance that has access to the same owner is a somewhat annoying API compared to what we would do today. In Ember 2.2 you would often do this (though it still uses private API): ```js User.create({ container: this.container, username: 'John' }); ``` But in 2.3.0-beta.1 to do roughly the same thing, you would have to do: ```js var options = { username: 'John' }; setOwner(options, getOwner(this)); User.create(options); ``` This is definitely less ergonomic for a perfectly supported case. With the changes added here, you would use the following: ```js User.create( getOwner(this).ownerInjection(), { username: 'John' } ); ```

[bugfix beta] expose ownerinjection method on containerproxy

60

false

7

false

emberjs

ember.js

10,590

f03eab4179db6a78877694d28e748a96f9abadb0

Robert Jackson

Merge pull request #12628 from Serabe/fix-12613 [BUGFIX beta] Fix processing arguments in rerender

merge pull request from serabe/fix-12613

41

true

false

5

true

false

emberjs

ember.js

10,591

ab72105e20626a8d614674ab434aafab52ac3922

Sergio Arbeo

[BUGFIX beta] Fix processing arguments in rerender Rerendering a dot-syntax closure component failed to update the attributes due to the shortcut being done too soon. Fix #12613

[bugfix beta] fix processing arguments in rerender

50

false

7

false

emberjs

ember.js

10,592

240b8c2f5c7b001fe0d1714ecee387c25b84de2d

Robert Jackson

Merge pull request #12627 from emberjs/remove-unused-flag [CLEANUP beta]

merge pull request from emberjs/remove-unused-flag

51

true

false

5

true

false

emberjs

ember.js

10,593

9591917d2f9ed5759fadefbce59f0a6bad264855

Kris Selden

Robert Jackson

[CLEANUP beta] Remove unused ENV flags, this is just to keep PRs small, this is part of a fix for Mixin that went into beta. ENABLE_ALL_FEATURES can't actually do anything more than ENABLE_OPTIONAL_FEATURES, other features are always build time. SHIM_ES5 is just unused as is DISABLE_RANGE_API

[cleanup beta]

14

false

2

false

emberjs

ember.js

10,594

9c58ec6435e139a0f4f3743ee590134f1f323cad

Robert Jackson

Merge pull request #12626 from Serabe/fix-12625 [BUGFIX beta] Fix positional params in contextual components with dot syntax

merge pull request from serabe/fix-12625

41

true

false

5

true

false

emberjs

ember.js

10,595

a18490a7613d8e4e44703a31f68cead99b692cd6

Sergio Arbeo

[BUGFIX beta] Fix positional params in contextual components with dot syntax As reported in #12625, positional parameters were not being rendered correctly when using the dot syntax. A longer description on the cause of the problem has been added as a comment to `ember-htmlbars/lib/hooks/component.js` for future warning. Fix #12625

[bugfix beta] fix positional params in contextual components with dot syntax

76

false

11

false

emberjs

ember.js

10,596

6b3e6ea91f871cd55fe7215be8320b8d1c2ef77e

Robert Jackson

Update released versions in CHANGELOG.md. [ci skip]

update released versions in changelog.md

40

false

5

false

emberjs

ember.js

10,597

d25e0d7760903b6f65f68d674ccc8decda180704

Robert Jackson

Update version info and npm-shrinkwrap.json.

update version info and npm-shrinkwrap.json

43

false

5

true

emberjs

ember.js

10,598

a3223359779d4b033de120fb57f311e6259264c9

Homu

Auto merge of #12619 - SaladFork:doc-add-cp-getter-setter-example, r=rwjblue [DOC release] Add example and clear up wording for CP get/set This PR makes the following changes to `Ember.computed` API documentation: - Changes the `fullName` getter function to match [the example in the latest guides](http://guides.emberjs.com/v2.1.0/object-model/computed-properties/). This involved changing to a template string from a string concatenation. - Switches class property default values to be defined in `init()` instead ([suggested](https://github.com/emberjs/ember.js/pull/12619#discussion_r44983617)) - Minor changes to wording and sentence structure, mostly adding articles. - Adds an example that uses the hash format with `get` and `set` - Removes confusing/incorrect phrase: > The `get` function should accept two parameters, `key` and `value`. My one concern is that the two examples are very similar except for a few lines. Would it be more helpful if the second example only included the computed property (rather than the whole class and usage example)?

doc-add-cp-getter-setter-example, r=rwjblue

43

false

2

false

emberjs

ember.js

10,599