sha stringlengths 40 40 | author stringlengths 1 63 | committer stringlengths 1 41 | message stringlengths 1 65.5k | subject stringlengths 1 5.64k | subject_length float64 1 5.64k | is_chore bool 2 classes | is_bot bool 2 classes | subject_word_count float64 1 806 | verb_object_spacy bool 2 classes | verb_object_stanza bool 2 classes | fits_requirements bool 2 classes | owner stringlengths 2 15 | repo stringlengths 2 21 | __index_level_0__ int64 0 85k |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
1743e317955f2957d07a7d749c2d02cdf7cad174 | Robert Jackson | Robert Jackson | Merge pull request #12509 from locks/patch-2
[DOC release] Removes extraneous backslash in code snipper | merge pull request from locks/patch-2 | 38 | true | false | 5 | true | false | false | emberjs | ember.js | 10,700 |
f3e3b390e66d2f7db7fa9c380c6bc000aebe9ee0 | Ricardo Mendes | Ricardo Mendes | [DOC release] Removes unused argument from code sample
The commented out `event` argument has an escaping backslash
in the closing comment tag, which is unexpected. Since the
argument is not used it is just removed. | [doc release] removes unused argument from code sample | 54 | false | false | 8 | false | false | false | emberjs | ember.js | 10,701 |
0faab562261a0654163ab23c512d9d6f336ec1cc | Robert Jackson | Robert Jackson | Merge pull request #12511 from duggiefresh/doc-is-present
[DOC release] Update `Ember.isPresent(false)` example | merge pull request from duggiefresh/doc-is-present | 51 | true | false | 5 | true | false | false | emberjs | ember.js | 10,702 |
974bc0397a11a9236dc0f0671324a1c7cdc4a03c | Doug Yun | Doug Yun | [DOC release] Update `Ember.isPresent(false)` example
`Ember.isPresent(false)` returns `true`
[skip ci] | [doc release] update `ember.ispresent(false)` example | 53 | false | false | 5 | false | false | false | emberjs | ember.js | 10,703 |
9d714be8b68bd307baa9c71e7c783816f8ff4613 | Robert Jackson | Robert Jackson | Merge pull request #12507 from ryrych/npm-install-troubleshooting
[DOC] Add `npm install` troubleshooting section | merge pull request from ryrych/npm-install-troubleshooting | 59 | true | false | 5 | true | false | false | emberjs | ember.js | 10,704 |
472822154f0d7ac10c3dace220953d53533e865a | Wojtek Ryrych | Wojtek Ryrych | [DOC] Add `npm install` troubleshooting section | [doc] add `npm install` troubleshooting section | 47 | false | false | 6 | false | false | false | emberjs | ember.js | 10,705 |
f96aecd212fe96b9560c8832b7bbb4988d6670d0 | Robert Jackson | Robert Jackson | Merge pull request #12483 from bmac/missing-since-tags
Add missing @since tags for the 1.12, 1.13 and 2.1 releases. | merge pull request from bmac/missing-since-tags | 48 | true | false | 5 | true | false | false | emberjs | ember.js | 10,706 |
7d51c7a8e07e3fa2b909c27f4a6284e709e36da5 | Robert Jackson | Robert Jackson | Merge pull request #12494 from alexspeller/more-private-fixies
Make Ember.compare public | merge pull request from alexspeller/more-private-fixies | 56 | true | false | 5 | true | false | false | emberjs | ember.js | 10,707 |
c35e15c682b633ee5d68b312b25f138ada635026 | Robert Jackson | Robert Jackson | Merge pull request #12495 from mixonic/dot-path-lookup
[FEATURE ember-contextual-components] dot-path | merge pull request from mixonic/dot-path-lookup | 48 | true | false | 5 | true | false | false | emberjs | ember.js | 10,708 |
e2643a5c9c440ed4bd5d543fbe2230b6a969e5f6 | Robert Jackson | Robert Jackson | Merge pull request #12502 from duggiefresh/remove-unused-import
[CLEANUP beta] - Remove unnecessary module | merge pull request from duggiefresh/remove-unused-import | 57 | true | false | 5 | true | false | false | emberjs | ember.js | 10,709 |
4f9a3bca272ac00011bb9ad07324ace4fc72b102 | Robert Jackson | Robert Jackson | Merge pull request #12503 from miguelcobain/tagless-asserts
add assertions for tagless component event handlers | merge pull request from miguelcobain/tagless-asserts | 53 | true | false | 5 | true | false | false | emberjs | ember.js | 10,710 |
9c2b28904c96e77cd6cbc1f0f6466bb5c80dda93 | Miguel Andrade | Miguel Andrade | add assertions for tagless component event handlers | add assertions for tagless component event handlers | 51 | false | false | 7 | true | true | false | emberjs | ember.js | 10,711 |
1703f3e4747498a6a71a3c961617ff8216712b6d | Doug Yun | Doug Yun | [CLEANUP beta] - Remove unnecessary module
It didn't seem that importing `ember-routing` is required. | [cleanup beta] - remove unnecessary module | 42 | false | false | 6 | false | false | false | emberjs | ember.js | 10,712 |
72cdc4a636e5605cfda7883eeff7122811187630 | Robert Jackson | Robert Jackson | Merge pull request #12498 from ryrych/patch-2
[DOC] Fix alignment in examples | merge pull request from ryrych/patch-2 | 39 | true | false | 5 | true | false | false | emberjs | ember.js | 10,713 |
3ada3afa7f49f00dac2a28cd3e6a88bd431be931 | Wojtek Ryrych | Wojtek Ryrych | [DOC] Fix alignment in examples
According to https://github.com/emberjs/ember.js/blob/master/CONTRIBUTING.md: 'All examples in code blocks must be aligned' | [doc] fix alignment in examples | 31 | false | false | 5 | false | false | false | emberjs | ember.js | 10,714 |
bb5cc203c79da47af1ead291848c280c63ee6fe5 | Robert Jackson | Robert Jackson | Merge pull request #12496 from alexspeller/remove-keys
[CLEANUP beta] Remove keys.js | merge pull request from alexspeller/remove-keys | 48 | true | false | 5 | true | false | false | emberjs | ember.js | 10,715 |
b66a13f56b5607aa91dca4862da9028078eab7a0 | Alex Speller | Alex Speller | [CLEANUP beta] Remove keys.js | [cleanup beta] remove keys.js | 29 | false | false | 4 | false | false | false | emberjs | ember.js | 10,716 |
6178da684ab5c969a537c8d4ee5f0d88e2ad0231 | bmac | bmac | Add missing @since tags for the 1.12, 1.13 and 2.1 releases. | add missing @since tags for the 1.12, 1.13 and 2.1 releases | 59 | false | false | 11 | false | true | false | emberjs | ember.js | 10,717 |
8a34561e4ad612bad3e35dee8e0620529cad543a | Alex Speller | Alex Speller | [DOC release] Fix Ember.compare visibility | [doc release] fix ember.compare visibility | 42 | false | false | 5 | false | false | false | emberjs | ember.js | 10,718 |
76e00890d07c0e5ddc7575ff40d5738b1480526c | Robert Jackson | Robert Jackson | Merge pull request #12486 from chancancode/visit-node-tests
Move FastBoot and resource-discovery tests to node | merge pull request from chancancode/visit-node-tests | 53 | true | false | 5 | true | false | false | emberjs | ember.js | 10,719 |
a6f0487aeecc4143a43aa70086557018894b86c0 | Matthew Beale | Matthew Beale | [FEATURE ember-contextual-components] Add to FEATURES.md | [feature ember-contextual-components] add to features.md | 56 | false | false | 5 | false | false | false | emberjs | ember.js | 10,720 |
dd060f61d1e9b4c3943ab2d84010d6155f55125b | Matthew Beale | Matthew Beale | [FEATURE ember-contextual-components] dot-path
Consider paths with dots in them for rendering as a component. | [feature ember-contextual-components] dot-path | 46 | false | false | 3 | false | false | false | emberjs | ember.js | 10,721 |
0f5c7f5e750d3d1486ee2061fb10515c2f82282c | Matthew Beale | Matthew Beale | Merge pull request #12493 from alexspeller/observer-should-be-publiv
observer should be public | merge pull request from alexspeller/observer-should-be-publiv | 62 | true | false | 5 | true | false | false | emberjs | ember.js | 10,722 |
0cfd33487acae8bf77176dfb4b47e7244a652421 | Alex Speller | Alex Speller | observer should be public | observer should be public | 25 | false | false | 4 | false | false | false | emberjs | ember.js | 10,723 |
08d7949fefa58ccac948f9d1c080df6c255679d0 | Stefan Penner | Stefan Penner | Merge pull request #12485 from trentmwillis/get-got
Access property only once during `Ember.get` | merge pull request from trentmwillis/get-got | 45 | true | false | 5 | true | false | false | emberjs | ember.js | 10,724 |
b3cbe2450de24f5a6ca6d026c92749574526427b | Godfrey Chan | Godfrey Chan | Move FastBoot and resource-discovery tests to node
Since these are server-side scenarios, we should be testing them in node
to more accurately replicated the target environment. | move fastboot and resource-discovery tests to node | 50 | false | false | 7 | false | true | false | emberjs | ember.js | 10,725 |
e8b717d5506dc17d7510f6e1b3ebabca6f8d20fd | Trent Willis | Trent Willis | Access property only once during property get | access property only once during property get | 45 | false | false | 7 | false | true | false | emberjs | ember.js | 10,726 |
ecbc94ac2086e986a1c2633947e40248ecfa1183 | Robert Jackson | Robert Jackson | Merge pull request #12314 from rwjblue/check-prototype-for-setters
[BUGFIX beta] Mandatory setter should check prototype descriptors. | merge pull request from rwjblue/check-prototype-for-setters | 60 | true | false | 5 | true | false | false | emberjs | ember.js | 10,727 |
28163882e229719f496f5cbd72fdc7e84c9431b9 | Robert Jackson | Robert Jackson | Merge pull request #12464 from tricknotes/html-safe
[BUGFIX release] `Ember.String.htmlSafe()` should return a instance of SafeString for `null` / `undefined` | merge pull request from tricknotes/html-safe | 45 | true | false | 5 | true | false | false | emberjs | ember.js | 10,728 |
e75d09788dc55d6c266cc8c2a08d0e7a58c1c048 | Matthew Beale | Matthew Beale | Merge pull request #12468 from anilmaurya/anilmaurya-patch-1
Update README.md, Fix Guides link | merge pull request from anilmaurya/anilmaurya-patch-1 | 54 | true | false | 5 | true | false | false | emberjs | ember.js | 10,729 |
a407440389325d39eca9514c6c3862735c26ac92 | Anil Kumar Maurya | Anil Kumar Maurya | Update README.md | update readme.md | 16 | false | false | 2 | false | false | false | emberjs | ember.js | 10,730 |
cddb12bc3e1f10103b8b5f5702e991661e63b21b | Ryunosuke SATO | Ryunosuke SATO | [BUGFIX release] `Ember.String.htmlSafe()` should return a instance of SafeString for `null` / `undefined`
Currently, `Ember.String.htmlSafe()` returns a just String, not HTML Safe.
We expect it is a safe string. | [bugfix release] `ember.string.htmlsafe()` should return a instance of safestring for `null` / `undefined` | 106 | false | false | 13 | false | false | false | emberjs | ember.js | 10,731 |
e15e5d5da229c7396915489d5c61c1bc57c2f259 | Robert Jackson | Robert Jackson | Merge pull request #12463 from rwjblue/do-not-super-wrap-everything
[BUGFIX release] Fix uglification introduced bug with super wrapping. | merge pull request from rwjblue/do-not-super-wrap-everything | 61 | true | false | 5 | true | false | false | emberjs | ember.js | 10,732 |
7894cae8ed49ff252a47bddebe1d6287fe666f46 | Robert Jackson | Robert Jackson | [BUGFIX release] Fix uglification introduced bug with super wrapping.
We check to see if a function contains `_super` / `.call` / `.apply`
before attempting to super wrap a given method (this saves quite a bit
of extra super wrapping for functions that do not need it).
Unfortunately, a number of platforms that we support do not support
calling `func.toString()` so we attempt to detect this and fall back
to always super wrap everything mode.
We have roughly this code (from
[here](https://github.com/emberjs/ember.js/blob/b4718218dbe5ffe7736c485a594248b20977c621/packages/ember-metal/lib/utils.js#L257-L271))
to detect if we can call `toString()` and get the original source:
```javascript
let sourceAvailable = (function() {
return this;
}).toString().indexOf('return this;') > -1;
```
This works perfectly for development builds, but unfortunately not
when minified. Take a look at the minified source and you will see why:
```javascript
var e=function(){return this}.toString().indexOf("return this;")>-1;
```
Note that minifier has stripped the trailing semicolon from the function
body we are attempting to check against, but sadly our `indexOf` check
still contains the semicolon!
**tldr;** We super wrap every function in uglified builds.
---
This commit removes the trailing semicolon from the source check, and
adds a test that should hopefully allow us to detect if this is
accidentally reintroduced. | [bugfix release] fix uglification introduced bug with super wrapping | 68 | false | false | 9 | false | false | false | emberjs | ember.js | 10,733 |
f1928a94e58381fa5a9d222f1b83b6f655cc7815 | Stefan Penner | Stefan Penner | Merge pull request #12448 from chadhietala/keystream-ops
[PERF] Bail on get if type does not have accessors | merge pull request from chadhietala/keystream-ops | 50 | true | false | 5 | true | false | false | emberjs | ember.js | 10,734 |
1f85853cf8f3a48fb8b77ad5e3fe0117ca52bfd1 | Robert Jackson | Robert Jackson | Merge pull request #12456 from rwjblue/DIE-ATTRS-DIE
[BUGFIX beta] Allow usage of bound properties in {{link-to}}. | merge pull request from rwjblue/die-attrs-die | 46 | true | false | 5 | true | false | false | emberjs | ember.js | 10,735 |
ca1b3069f99f9d8258f00f3aa3e6b1583058cd8b | Chad Hietala | Chad Hietala | [PERF] Bail on KeyStream#compute if bool or string
When compute is called it is expected that object is an actual Object,
sometimes the object is a Bool or String and yet we continue down the stack look
values up on it even though the result will be undefined. This change
bails out early if `object` is a Bool or String. | [perf] bail on keystream#compute if bool or string | 50 | false | false | 8 | false | false | false | emberjs | ember.js | 10,736 |
c8c79dece702f95cd9fcd2a30734cb82ebe40b09 | Robert Jackson | Robert Jackson | Merge pull request #12455 from emberjs/fixup-style
remove extra comma | merge pull request from emberjs/fixup-style | 44 | true | false | 5 | true | false | false | emberjs | ember.js | 10,737 |
036bf4e96c908a4c7dfa7c4c8df430cdd1838d05 | Robert Jackson | Robert Jackson | [BUGFIX beta] Allow usage of bound properties in {{link-to}}.
Due to values in `this.attrs` being either a `MutableCell` or the actual
value, many flags in `link-to` would not function properly when provided
a bound property. | [bugfix beta] allow usage of bound properties in {{link-to}} | 60 | false | false | 9 | false | false | false | emberjs | ember.js | 10,738 |
1b18f8c7730fc6285c2a07389e74655c0e4ce08f | Stefan Penner | Stefan Penner | remove extra comma | remove extra comma | 18 | false | false | 3 | true | true | true | emberjs | ember.js | 10,739 |
d462156d55acd831d8187628965260a2f899812d | Stefan Penner | Stefan Penner | Merge pull request #12423 from emberjs/cleanup-meta
Cleanup meta | merge pull request from emberjs/cleanup-meta | 45 | true | false | 5 | true | false | false | emberjs | ember.js | 10,740 |
8f8f154642e06e8fd445a0c9199ab33b6a135d7a | Robert Jackson | Robert Jackson | [BUGFIX release] Avoid `this.attrs.params` in LinkComponent.
Due to the nature of `positionalParams`, it is trivial to supply
`params` as a hash argument to `{{link-to}}` instead of ordered args
(this allows truly dynamic link's). However, if `{{link-to params=foo}}`
is used `params` will be a `MutableCell` and the current code throws an
error in that circumstance.
*tldr;* `this.attrs` should be avoided. It is quite a :troll: in
non-`GlimmerComponent`'s. | [bugfix release] avoid `this.attrs.params` in linkcomponent | 59 | false | false | 6 | false | false | false | emberjs | ember.js | 10,741 |
c0b010ecd854d6286e723808f749ad23c03dc82f | Robert Jackson | Robert Jackson | Merge pull request #12443 from toddjordan/get-warn-api-doc-generating
[BUGFIX Beta] Move warn api doc to a place where it gets picked up by the build | merge pull request from toddjordan/get-warn-api-doc-generating | 63 | true | false | 5 | true | false | false | emberjs | ember.js | 10,742 |
500cafcf7f5ffcbba85a072eff7a78d601878921 | Todd Jordan | Todd Jordan | [BUGFIX Beta] Move warn api doc to a place where it gets picked up by
the build
updates per feedback | [bugfix beta] move warn api doc to a place where it gets picked up by | 69 | false | false | 15 | false | false | false | emberjs | ember.js | 10,743 |
e7ba39a23c9b10ba40177b1b77e2c12cb3671cd4 | Robert Jackson | Robert Jackson | Merge pull request #12445 from rwjblue/fix-rest-style-positional-params
[BUGFIX release] Ensure rest arg positionalParams can be omitted. | merge pull request from rwjblue/fix-rest-style-positional-params | 65 | true | false | 5 | true | false | false | emberjs | ember.js | 10,744 |
d34aa11c19349972d3eda42018c4b32ff29eb53b | Robert Jackson | Robert Jackson | [BUGFIX release] Ensure rest arg positionalParams can be omitted.
When specifying `postionalParams` like this:
```javascript
App.FooBarComponent = Ember.Component.extend();
App.FooBarComponent.reopenClass({
positionalParams: 'allTheThings'
});
```
You should be able to avoid using positional params by specifying
`allTheThings` as a hash argument:
```hbs
{{foo-bar allTheThings=blah}}
```
Unfortunately, we were triggering an assertion that you used a positional
param that conflicted with a hash param. This change fixes that
assertion by avoiding doing any work when no params are specified. | [bugfix release] ensure rest arg positionalparams can be omitted | 64 | false | false | 9 | false | false | false | emberjs | ember.js | 10,745 |
23258c1eadce4f52c814f0441c13880ddf896f31 | Robert Jackson | Robert Jackson | Merge pull request #12441 from dgeb/remove-di-reform-flag
Remove `ember-registry-container-reform` feature flag. | merge pull request from dgeb/remove-di-reform-flag | 51 | true | false | 5 | true | false | false | emberjs | ember.js | 10,746 |
d34c9ea8333e5c1dca2432ccec72a080592b6d1b | Robert Jackson | Robert Jackson | Merge pull request #12436 from csantero/protected
allow @protected in JSCS | merge pull request from csantero/protected | 43 | true | false | 5 | false | false | false | emberjs | ember.js | 10,747 |
736fdeaedfca2ae7673904fb1d9a4caeedaa808c | Robert Jackson | Robert Jackson | Merge pull request #12422 from Serabe/feature/null-closure-components
[BUGFIX] Fix contextual components handling invalid component paths | merge pull request from serabe/feature/null-closure-components | 63 | true | false | 5 | true | true | false | emberjs | ember.js | 10,748 |
e673f9117ff7deb370b8d90ab31acd6e90670d59 | Robert Jackson | Robert Jackson | Merge pull request #12440 from rwjblue/fix-node-tests
Fix node tests. | merge pull request from rwjblue/fix-node-tests | 47 | true | false | 5 | true | false | false | emberjs | ember.js | 10,749 |
a8107d143d5fa53eff9af4f2d55a217c28c68b71 | Dan Gebhardt | Dan Gebhardt | Remove `ember-registry-container-reform` feature flag.
This flag is no longer needed now that this feature is out of beta. | remove `ember-registry-container-reform` feature flag | 53 | false | false | 4 | false | false | false | emberjs | ember.js | 10,750 |
05e5feb585233e4b27ed4a96df6e36d8d57ef2be | Robert Jackson | Robert Jackson | Fix node tests.
QUnit 1.19 was released and changed the way the npm package exports its
value (it no longer sets up `global.QUnit` and all the assertion methods
automatically).
This updates to a better pattern of importing `QUnit` and using the
`assert` argument for assertions. | fix node tests | 14 | false | false | 3 | true | true | true | emberjs | ember.js | 10,751 |
4984afa783e5db1f653361945f9b90127c3c97c2 | Sergio Arbeo | Sergio Arbeo | [BUGFIX] Fix contextual components handling invalid component paths
Contextual components show a message when passed null or unknown component
paths. | [bugfix] fix contextual components handling invalid component paths | 67 | false | false | 8 | false | false | false | emberjs | ember.js | 10,752 |
7595850b908bb1ac1fac662aba3430c60821471b | Robert Jackson | Robert Jackson | Post release version bump. | post release version bump | 25 | false | false | 4 | false | false | false | emberjs | ember.js | 10,753 |
02b2ccd984c96f42fe775077f8f0f04d996e4b36 | Chris Santero | Chris Santero | allow @protected in JSCS | allow @protected in jscs | 24 | false | false | 4 | false | false | false | emberjs | ember.js | 10,754 |
4303df0a519995d2e3d4fd288e8ec6b0b8773c5d | Matthew Beale | Matthew Beale | Merge pull request #12433 from rwjblue/default-layout-deprecation
[DOC beta] Add link to `Ember.Component#defaultLayout` deprecation guide. | merge pull request from rwjblue/default-layout-deprecation | 59 | true | false | 5 | true | false | false | emberjs | ember.js | 10,755 |
daad20b978fe0d97dfa6eebf987f0fe0c20b59fa | Robert Jackson | Robert Jackson | Merge pull request #12435 from rwjblue/deprecation-guide-appInstance-container
[DOC beta] Add guide links for `Ember.ApplicationInstance#container` | merge pull request from rwjblue/deprecation-guide-appinstance-container | 72 | true | false | 5 | true | false | false | emberjs | ember.js | 10,756 |
2ec5491f09f1c811c0f14063394c5928d21e7d19 | Robert Jackson | Robert Jackson | [DOC beta] Add guide links for `Ember.ApplicationInstance#container`
[ci skip] | [doc beta] add guide links for `ember.applicationinstance#container` | 68 | false | false | 7 | false | false | false | emberjs | ember.js | 10,757 |
1a6431e242fce88fd2d29d8a90d5f5a04ef2ba21 | Robert Jackson | Robert Jackson | Merge pull request #12434 from rwjblue/add-currentState-deprecation-link
[DOC beta] Add Ember.Component#currentState deprecation guide. | merge pull request from rwjblue/add-currentstate-deprecation-link | 66 | true | false | 5 | true | false | false | emberjs | ember.js | 10,758 |
6672640c793ae9f19368b65e2ea562af936e0300 | Robert Jackson | Robert Jackson | [DOC beta] Add Ember.Component#currentState deprecation guide.
[ci skip] | [doc beta] add ember.component#currentstate deprecation guide | 61 | false | false | 6 | false | false | false | emberjs | ember.js | 10,759 |
f79504a0ff3a379a13a1b3e94e1a036f1b8437e8 | Robert Jackson | Robert Jackson | [DOC beta] Add link to `Ember.Component#defaultLayout` deprecation guide. | [doc beta] add link to `ember.component#defaultlayout` deprecation guide | 72 | false | false | 8 | false | false | false | emberjs | ember.js | 10,760 |
7aa114847bf731af77c097715a687ca763ecd7a2 | Robert Jackson | Robert Jackson | Merge pull request #12432 from rwjblue/registry-deprecations
[DOC beta] Add links to app.registry.* deprecations. | merge pull request from rwjblue/registry-deprecations | 54 | true | false | 5 | true | false | false | emberjs | ember.js | 10,761 |
912f90d0c34acfcaef2f53b7ae3d402c11962292 | Robert Jackson | Robert Jackson | [DOC beta] Add links to app.registry.* deprecations. | [doc beta] add links to app.registry.* deprecations | 51 | false | false | 7 | false | false | false | emberjs | ember.js | 10,762 |
f847e9e589e946e4fc8c1dcdd376fe0c19dfc68d | Robert Jackson | Robert Jackson | Merge pull request #12431 from rwjblue/add-deprecation-guide-link-for-debug-functions
[DOC beta] Add deprecation guide links for debug handlers. | merge pull request from rwjblue/add-deprecation-guide-link-for-debug-functions | 79 | true | false | 5 | true | false | false | emberjs | ember.js | 10,763 |
c5d96e2d109415edacab3100db3c51d0fd3cbeb5 | Robert Jackson | Robert Jackson | [DOC beta] Add deprecation guide links for debug handlers. | [doc beta] add deprecation guide links for debug handlers | 57 | false | false | 9 | false | false | false | emberjs | ember.js | 10,764 |
a30eedddaa9d3594208f26923b73ad4381454be5 | Robert Jackson | Robert Jackson | Merge pull request #12430 from rwjblue/add-url-for-initializer-arity
[DOC beta] Add URL for deprecation guide on initializer arity. | merge pull request from rwjblue/add-url-for-initializer-arity | 62 | true | false | 5 | true | false | false | emberjs | ember.js | 10,765 |
a11b1f7531dcbc71f0278a3239971509b00b60f3 | Robert Jackson | Robert Jackson | Merge pull request #12429 from toddjordan/api-doc-for-register-depwarn-handlers
[DOC beta] Issue #12428 Add API Docs for deprecation and warning handlers | merge pull request from toddjordan/api-doc-for-register-depwarn-handlers | 73 | true | false | 5 | true | false | false | emberjs | ember.js | 10,766 |
db70b48cdbe317c9db988c8a8798a8373588874e | Robert Jackson | Robert Jackson | [DOC beta] Add URL for deprecation guide on initializer arity. | [doc beta] add url for deprecation guide on initializer arity | 61 | false | false | 10 | false | false | false | emberjs | ember.js | 10,767 |
bcb9185bec74751adccd325ac83cfdb5d77868e3 | Todd Jordan | Todd Jordan | add api docs for Ember.Debug.registerDeprecationHandler and
Ember.Debug.registerWarnHandler
fix a couple copy/paste issues | add api docs for ember.debug.registerdeprecationhandler and | 59 | false | false | 6 | true | true | false | emberjs | ember.js | 10,768 |
77f6fc86a7dd5e05dd2827ca6b4e746c15973e8d | Edward Faulkner | Edward Faulkner | Merge pull request #12421 from emberjs/remove-extra-call-to-meta-for
remove extra call to metaFor | merge pull request from emberjs/remove-extra-call-to-meta-for | 62 | true | false | 5 | true | false | false | emberjs | ember.js | 10,769 |
07d4d688dc0be6e125113fe328f6936802b146d5 | Stefan Penner | Stefan Penner | Merge pull request #12425 from emberjs/faster-meta-assignment
Update each_proxy.js | merge pull request from emberjs/faster-meta-assignment | 55 | true | false | 5 | true | false | false | emberjs | ember.js | 10,770 |
cabce3eeb5a9b56907c714644c1027ed592d6dd1 | Stefan Penner | Stefan Penner | Merge pull request #12426 from juaniiie/patch-1
Fix spelling error in FEATURES.md | merge pull request from juaniiie/patch-1 | 41 | true | false | 5 | true | false | false | emberjs | ember.js | 10,771 |
e8ccbb06986a852fc507cf4cbc3430354b0a7d90 | Juana | Juana | Update FEATURES.md | update features.md | 18 | false | false | 2 | false | false | false | emberjs | ember.js | 10,772 |
e46e056f1d5ed3136efbdf2136febebacd0461c6 | Stefan Penner | Stefan Penner | use peekMeta + deleteMeta is isolate the code-base. | use peekmeta + deletemeta is isolate the code-base | 50 | false | false | 8 | true | true | true | emberjs | ember.js | 10,773 |
9022bf6c5c605814c90669dbc53f27618a772c37 | Stefan Penner | Stefan Penner | begin cleaning up meta code, prepping for proper WeakMap usage | begin cleaning up meta code, prepping for proper weakmap usage | 62 | false | false | 10 | false | false | false | emberjs | ember.js | 10,774 |
3398cd1820978398e209440e16a9eae27259985b | Stefan Penner | Stefan Penner | remove concept of empty Meta (both private, and unused) | remove concept of empty meta (both private, and unused) | 55 | false | false | 9 | true | true | false | emberjs | ember.js | 10,775 |
08b601eeb8bd87af2f63655c7180383ae17f00d3 | Stefan Penner | Stefan Penner | Update each_proxy.js
secrete handshake for faster meta... | update each_proxy.js | 20 | false | false | 2 | true | false | false | emberjs | ember.js | 10,776 |
9851decd9919e2a3371eeaf4b65e8995980c5c2b | Stefan Penner | Stefan Penner | remove extra call to metaFor | remove extra call to metafor | 28 | false | false | 5 | true | true | true | emberjs | ember.js | 10,777 |
db8721b4a393afee0926a501c96d539338de7db3 | Stefan Penner | Stefan Penner | Merge pull request #12420 from duggiefresh/cleanup-beta-morph-range-error-message
[CLEANUP beta] `morph-range` - add error message test | merge pull request from duggiefresh/cleanup-beta-morph-range-error-message | 75 | true | false | 5 | true | false | false | emberjs | ember.js | 10,778 |
dda8f3ececf1584690275c59cdc2bd1883e55bde | Doug Yun | Doug Yun | [CLEANUP beta] `morph-range` - add error message test
Close #12316 | [cleanup beta] `morph-range` - add error message test | 53 | false | false | 8 | false | false | false | emberjs | ember.js | 10,779 |
b4718218dbe5ffe7736c485a594248b20977c621 | Robert Jackson | Robert Jackson | Merge pull request #12418 from emberjs/remove-init-mixins
Remove no-longer used initMixins code. | merge pull request from emberjs/remove-init-mixins | 51 | true | false | 5 | true | false | false | emberjs | ember.js | 10,780 |
e64c6768a6fff40062d4841116ecfc3ab4974817 | Robert Jackson | Robert Jackson | Merge pull request #12370 from Kuzirashi/master
[BUGFIX canary] Deprecate passing function as test argument to deprecate/warn/assert | merge pull request from kuzirashi/master | 41 | true | false | 5 | true | false | false | emberjs | ember.js | 10,781 |
99f1400970cfddd94849f37d794d4715a303ca7c | Kuzirashi | Kuzirashi | [BUGFIX canary] Deprecate passing function as `test` to deprecate/warn/assert | [bugfix canary] deprecate passing function as `test` to deprecate/warn/assert | 77 | false | false | 9 | false | false | false | emberjs | ember.js | 10,782 |
ab04e97ae2703d86f6605b0be319d555be000764 | Robert Jackson | Robert Jackson | Merge pull request #12416 from rwjblue/action-scoping
[BUGFIX canary] Ensure components actions function without controller. | merge pull request from rwjblue/action-scoping | 47 | true | false | 5 | true | false | false | emberjs | ember.js | 10,783 |
c7913064b38b3c51aeae2d8cb2317bf21659aa6e | Stefan Penner | Stefan Penner | Remove no-longer used initMixins code. | remove no-longer used initmixins code | 37 | false | false | 5 | false | false | false | emberjs | ember.js | 10,784 |
72bdb39d8b6cd6446c6560b8f2e55eb53dc1b2c3 | Stefan Penner | Stefan Penner | Merge pull request #12414 from trentmwillis/teardown-fix
Fix multiplicative observation of controllers in views | merge pull request from trentmwillis/teardown-fix | 50 | true | false | 5 | true | false | false | emberjs | ember.js | 10,785 |
11a0bbe1af154f6c18aee89ccbdb5289b6dcc964 | Robert Jackson | Robert Jackson | [BUGFIX canary] Ensure components actions function without controller.
On canary we no longer create `controller` and `view` template locals.
Unfortunately, our test suite still pretends that they are there (since
they are added back in by the legacy addons) so all tests pass that were
using `scope.getLocal('controller')` and friends).
This commit adds a test for sending actions that runs without the flags
enabled (the test failed prior to this change), and updates
component-node-manager to provide either `_controller` *OR*
`_targetObject` to the component that is being created. | [bugfix canary] ensure components actions function without controller | 69 | false | false | 8 | false | false | false | emberjs | ember.js | 10,786 |
6a6824860686ec8f18adc0fa739258f92df14cec | Trent Willis | Trent Willis | Add test for view controller changes | add test for view controller changes | 36 | false | false | 6 | true | true | true | emberjs | ember.js | 10,787 |
3672822c5d4075c24b17e39bbbfc8d378545f258 | Trent Willis | Trent Willis | Fix multiplicative observation of controllers in views | fix multiplicative observation of controllers in views | 54 | false | false | 7 | true | true | false | emberjs | ember.js | 10,788 |
e88eee778ee1a4c4319bf091dd6785023b868c63 | Robert Jackson | Robert Jackson | Merge pull request #12411 from rwjblue/add-meta-and-guid-to-stream-shape
[BUGFIX canary] Add meta and GUID keys to stream shape. | merge pull request from rwjblue/add-meta-and-guid-to-stream-shape | 66 | true | false | 5 | true | false | false | emberjs | ember.js | 10,789 |
1176b9367553718f525d6eb03869463b92408488 | Robert Jackson | Robert Jackson | [BUGFIX canary] Add meta and GUID keys to stream shape.
After `init` is ran for stream objects we seal the object to ensure that
we maintain a consistent object shape.
In some scenarios the Ember Inspector needs to call `Ember.guidFor` on a
stream to keep track of which streams have already been seen/walked.
Unfortunately, we forgot to add `GUID_KEY` and `__ember_meta__` to the
base stream object before sealing, which causes an error:
```javascript
Uncaught TypeError: Cannot define property:__ember1442443003034, object is not extensible.
```
This adds the proper placeholders to the base stream class to prevent
this error. | [bugfix canary] add meta and guid keys to stream shape | 54 | false | false | 10 | false | false | false | emberjs | ember.js | 10,790 |
a82006d8f1dedd0d0368a175b647e39a48e33a13 | Robert Jackson | Robert Jackson | Merge pull request #12388 from duggiefresh/import-ember-route
[CLEANUP beta] Import `Route` module | merge pull request from duggiefresh/import-ember-route | 55 | true | false | 5 | true | false | false | emberjs | ember.js | 10,791 |
2a94e70fcd98ae44c6e8abb95d413adf26e39b39 | Doug Yun | Doug Yun | [CLEANUP beta] Import `Route` module | [cleanup beta] import `route` module | 36 | false | false | 5 | false | false | false | emberjs | ember.js | 10,792 |
a8ed14c140aea462d9c8a773329b020f49105327 | Yehuda Katz | Yehuda Katz | Don't check in local files | don't check in local files | 26 | false | false | 5 | false | false | false | emberjs | ember.js | 10,793 |
ab1f9dff668d4fc62746d78bdc78172f184679ce | Yehuda Katz | Yehuda Katz | Merge pull request #12394 from chancancode/visit_api
Revisiting the visit API (aka FastBoot™) | merge pull request from chancancode/visit_api | 46 | true | false | 5 | true | false | false | emberjs | ember.js | 10,794 |
5fca89003b46eba529cc7d9e05cf8cb32451309e | Godfrey Chan | Godfrey Chan | Fix node tests to use new APIs | fix node tests to use new apis | 30 | false | false | 7 | true | true | true | emberjs | ember.js | 10,795 |
aefcf141e96fddc0325f3235cc0dc5db37f3738a | Robert Jackson | Robert Jackson | Merge pull request #12383 from skeate/master
[BUGFIX release-1-13] Fix string classify normalizer | merge pull request from skeate/master | 38 | true | false | 5 | true | true | false | emberjs | ember.js | 10,796 |
9d3a62d450e1e73dcba4ecfdbafee8a69318987a | Robert Jackson | Robert Jackson | [BUGFIX beta] Mandatory setter should check prototype descriptors.
Prior to this change, a setter that exists on the prototype of the
object was not detected and was effectively clobbered.
This change updates `handleMandatorySetter` to check both the objects
own descriptors and its prototypes descriptors.
Also removed the guard for `Object.getOwnPropertyDescriptor` since all
supported platforms are ES5. | [bugfix beta] mandatory setter should check prototype descriptors | 65 | false | false | 8 | false | false | false | emberjs | ember.js | 10,797 |
145bc36c5e18354328482acf795008475b6914bf | Robert Jackson | Robert Jackson | Merge pull request #12407 from rwjblue/make-test-less-brittle
Avoid timing brittleness in Ember.Select test. | merge pull request from rwjblue/make-test-less-brittle | 55 | true | false | 5 | true | false | false | emberjs | ember.js | 10,798 |
2e59fe6b2fb3de992438b8a23ca4eec64e06e224 | Robert Jackson | Robert Jackson | Ensure async test helper tests wait properly.
These tests "mostly" worked (by that I mean, they worked on sufficiently
fast hardware), but have random failures on slower VM runs (via Sauce
Labs).
The tests were updated to `return` a promise when chaining was being
used, and `return wait();` (which results in a promise also) when
non-chaining syntax is being used. I kept them different to ensure both
versions are still being tested. | ensure async test helper tests wait properly | 44 | false | false | 7 | false | false | false | emberjs | ember.js | 10,799 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.